Please clarify "pending" reporting at build.webkit.org/dashboard
[WebKit-https.git] / Tools / ChangeLog
1 2013-12-25  Alexey Proskuryakov  <ap@apple.com>
2
3         Please clarify "pending" reporting at build.webkit.org/dashboard
4         https://bugs.webkit.org/show_bug.cgi?id=122191
5
6         Reviewed by Timothy Hatcher.
7
8         Reporting the count of pending runs didn't make a lot of sense - first, runs are
9         coalesced and sometimes even out of order, and second, buildbot's notion of pending
10         run was confusingly different from dashboard's.
11
12         Let's display how many SVN revisions are pending. This can be somewhat misleading
13         too, because some revisions (like those for other platforms) don't trigger builds,
14         but it's better than what we had.
15
16         This patch also lays the groundwork for displaying detailed information about
17         pending revisions.
18
19         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
20         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus): Instead of
21         building pending status line directly, call newly added base class method.
22
23         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
24         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Ditto.
25
26         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
27         (BuildbotQueueView): Listen for events when new SVN revisions are landed, and update the view.
28         (BuildbotQueueView.prototype._appendPendingRevisionCount): Add a line for pending
29         SVN revisions. It uses a new style, StatusLineView.Status.NoBubble, because this
30         information is secondary, and doesn't need as much attention.
31         (BuildbotQueueView.prototype.revisionLinksForIteration): Build revisionURL through
32         Trac, not through Buildbot.
33         (BuildbotQueueView.prototype._newCommitsRecorded): Schedule an update, just like when
34         iterations are updated.
35
36         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
37         Initialize a global webkitTrac object.
38
39         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
40         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
41         Added a new style for messages without a bubble.
42
43         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
44         Added a model class for Trac, which keeps track of SVN timeline, and notifies
45         listeners of changes. It uses an RSS interface to Trac, because there is no JSON one.
46
47         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
48         (loadXML): Added a function to load XML asynchronouly, just like existing JSON.load.
49
50         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
51         Removed tracRevisionURL() function. Now that we have a Trac object, it just makes
52         more sense to build trac URLs through it.
53
54         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
55         Load Trac.js.
56
57 2013-12-25  Jongwoo Choi  <jw0330.choi@samsung.com>
58
59         [EFL] Activate keyboard homepage shortcut on efl minibrowser.
60         https://bugs.webkit.org/show_bug.cgi?id=124636
61
62         Reviewed by Gyuyoung Kim.
63
64         * MiniBrowser/efl/main.c: Added.
65         (on_key_down): Add a homepage shortcut using Alt + Home key. 
66
67 2013-12-25  Alexey Proskuryakov  <ap@apple.com>
68
69         Revision selection behavior at build.webkit.org/dashboard is annoying
70         https://bugs.webkit.org/show_bug.cgi?id=126235
71
72         Reviewed by Tim Horton.
73
74         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
75         (BuildbotQueueView.prototype.revisionLinksForIteration): Make the whole message
76         selectable, not just the numbers in it.
77         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
78         (.selectable): Make selectable enable default behavior, not user-select:all.
79
80 2013-12-25  Martin Robinson  <mrobinson@igalia.com>
81
82         [GTK] [CMake] Clean up generated sources directories
83         https://bugs.webkit.org/show_bug.cgi?id=126216
84
85         Reviewed by Gustavo Noronha Silva.
86
87         * DumpRenderTree/PlatformGTK.cmake: Use the new derived sources variables.
88         * GtkLauncher/CMakeLists.txt: Ditto.
89         * MiniBrowser/gtk/CMakeLists.txt: Ditto.
90         * TestWebKitAPI/CMakeLists.txt: Now that the EFL and GTK+ forwarding header locations differ,
91         move the platform-specific includes to the EFL and GTK platform files. Also clean up forwarding
92         header generation into on target.
93         * TestWebKitAPI/PlatformEfl.cmake: Added EFL-specific locations to the include list.
94         * TestWebKitAPI/PlatformGTK.cmake: Added GTK-specific locations to the include list.
95         * WebKitTestRunner/CMakeLists.txt: Same as for TestWebKitAPI.
96         * WebKitTestRunner/PlatformEfl.cmake: Ditto.
97         * WebKitTestRunner/PlatformGTK.cmake: Ditto.
98         * gtk/generate-gtkdoc: Update to select the appropriate derived sources locations for
99         the cmake build.
100
101 2013-12-23  Alexey Proskuryakov  <ap@apple.com>
102
103         Add a JSON interface for getting EWS queue status
104         https://bugs.webkit.org/show_bug.cgi?id=126182
105
106         Reviewed by Ryosuke Niwa.
107
108         The current goal is to add an indicator of how many patches are in the queue, and
109         the JSON also includes some other information that was easy to add.
110
111         * QueueStatusServer/app.yaml: Updated version for deployment.
112
113         * QueueStatusServer/handlers/queuestatusjson.py: Added. Returns a JSON with some
114         bot and patch queue information.
115
116         * QueueStatusServer/index.yaml: Added an index for a new query that only returns
117         bot ids.
118
119         * QueueStatusServer/main.py: Map /queue-status-json/ directory to QueueStatusJSON
120         handler.
121
122         * QueueStatusServer/config: Added property svn:ignore.
123         * QueueStatusServer/filters: Added property svn:ignore.
124         * QueueStatusServer/loggers: Added property svn:ignore.
125         * QueueStatusServer/handlers: Added property svn:ignore.
126         * QueueStatusServer/model: Added property svn:ignore.
127         Ignore compiled *.pyc files in all directories they appear in when running locally.
128
129 2013-12-23  Martin Robinson  <mrobinson@igalia.com>
130
131         Try to fix the build after r161017
132
133         * gtk/common.py:
134         (is_cmake_build): Instead of checking whether the return value of build_path
135         of the CMakeCache.txt file is None, check if a file actually exists at that path.
136
137 2013-12-23  Gustavo Noronha Silva  <gns@gnome.org>
138
139         [GTK] [CMake] Add support for generating gtkdoc
140         https://bugs.webkit.org/show_bug.cgi?id=116376
141
142         Reviewed by Martin Robinson.
143
144         * gtk/common.py: look for files in the directories used by the cmake build as well.
145
146 2013-12-23  Carlos Garcia Campos  <cgarcia@igalia.com>
147
148         [GTK] Build with network process unconditionally
149         https://bugs.webkit.org/show_bug.cgi?id=126128
150
151         Reviewed by Martin Robinson.
152
153         * Scripts/webkitperl/FeatureList.pm: Remove network-process
154         feature command line option.
155
156 2013-12-23  Carlos Garcia Campos  <cgarcia@igalia.com>
157
158         [GTK] run-gtk-tests should always run glib tests with -k option
159         https://bugs.webkit.org/show_bug.cgi?id=126132
160
161         Reviewed by Philippe Normand.
162
163         With -k command line option, gtester continues running all other
164         test cases after a failure.
165
166         * Scripts/run-gtk-tests:
167         (TestRunner._run_test_glib): Use -k option when runing glib tests
168         to not stop on failure.
169
170 2013-12-22  Martin Robinson  <mrobinson@igalia.com>
171
172         [GTK][CMake] Integrate GResource for inspector files (and others?)
173         https://bugs.webkit.org/show_bug.cgi?id=125569
174
175         Reviewed by Gustavo Noronha Silva.
176
177         * gtk/generate-inspector-gresource-manifest.py: Added.
178
179 2013-12-22  Csaba Osztrogonác  <ossy@webkit.org>
180
181         Last URTBF after r160971 to make EFL build happy.
182
183         * TestWebKitAPI/efl/PlatformWebView.cpp:
184         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
185
186 2013-12-21  Carlos Garcia Campos  <cgarcia@igalia.com>
187
188         Unreviewed. Add myself to some more watch lists.
189
190         * Scripts/webkitpy/common/config/watchlist: Watch also soup, gst
191         and binding scripts patches.
192
193 2013-12-20  Commit Queue  <commit-queue@webkit.org>
194
195         Unreviewed, rolling out r160941.
196         http://trac.webkit.org/changeset/160941
197         https://bugs.webkit.org/show_bug.cgi?id=126095
198
199         Doesn't handle subpixel layout being disabled (Requested by
200         smfr on #webkit).
201
202         * gdb/webkit.py:
203         (JSCJSStringPrinter.to_string):
204         (add_pretty_printers):
205         * lldb/lldb_webkit.py:
206         (WTFMediaTime_SummaryProvider):
207         (WTFStringProvider.to_string):
208
209 2013-12-20  Bem Jones-Bey  <bjonesbe@adobe.com>
210
211         Pretty print LayoutUnit, LayoutPoint, and LayoutSize in gdb and lldb
212         https://bugs.webkit.org/show_bug.cgi?id=126080
213
214         Reviewed by Anders Carlsson.
215
216         This changes the output of printing LayoutUnits to be in px, removing
217         the need to divide by 64 manually.
218
219         This will lead to gdb output like:
220
221         m_frameRect = {
222             m_location = LayoutPoint(0px, 0px),
223             m_size = LayoutSize(800px, 585px)
224         }
225
226         And lldb output like:
227
228         (const WebCore::LayoutRect) $0 = {
229           m_location = { x = 744px, y = 1px }
230           m_size = { width = 236px, height = 40px }
231         }
232
233         This patch is based on patch for Blink by cbiesinger@chromium.org.
234
235         * gdb/webkit.py:
236         (WebCoreLayoutUnitPrinter):
237         (WebCoreLayoutUnitPrinter.__init__):
238         (WebCoreLayoutUnitPrinter.to_string):
239         (WebCoreLayoutSizePrinter):
240         (WebCoreLayoutSizePrinter.__init__):
241         (WebCoreLayoutSizePrinter.to_string):
242         (WebCoreLayoutPointPrinter):
243         (WebCoreLayoutPointPrinter.__init__):
244         (WebCoreLayoutPointPrinter.to_string):
245         (add_pretty_printers):
246         * lldb/lldb_webkit.py:
247         (__lldb_init_module):
248         (WebCoreLayoutUnit_SummaryProvider):
249         (WebCoreLayoutSize_SummaryProvider):
250         (WebCoreLayoutPoint_SummaryProvider):
251         (WebCoreLayoutUnitProvider):
252         (WebCoreLayoutUnitProvider.__init__):
253         (WebCoreLayoutUnitProvider.to_string):
254         (WebCoreLayoutSizeProvider):
255         (WebCoreLayoutSizeProvider.__init__):
256         (WebCoreLayoutSizeProvider.get_width):
257         (WebCoreLayoutSizeProvider.get_height):
258         (WebCoreLayoutPointProvider):
259         (WebCoreLayoutPointProvider.__init__):
260         (WebCoreLayoutPointProvider.get_x):
261         (WebCoreLayoutPointProvider.get_y):
262
263 2013-12-20  Martin Robinson  <mrobinson@igalia.com>
264
265         [GTK] [CMake] Add support for building ImageDiff
266         https://bugs.webkit.org/show_bug.cgi?id=125960
267
268         Reviewed by Gustavo Noronha Silva.
269
270         * CMakeLists.txt: Build ImageDiff for GTK+.
271         * ImageDiff/PlatformGTK.cmake: Added.
272
273 2013-12-20  Martin Robinson  <mrobinson@igalia.com>
274
275         [GTK] [CMake] Add support for building DumpRenderTree
276         https://bugs.webkit.org/show_bug.cgi?id=125767
277
278         Reviewed by Gustavo Noronha Silva.
279
280         * CMakeLists.txt: Load the DumpRenderTree cmake file for GTK+ when WebKit1 is enabled.
281         * DumpRenderTree/PlatformGTK.cmake: Added.
282
283 2013-12-20  Martin Robinson  <mrobinson@igalia.com>
284
285         [GTK] [CMake] Add support for building WebKitTestRunner
286         https://bugs.webkit.org/show_bug.cgi?id=125768
287
288         Reviewed by Gustavo Noronha Silva.
289
290         * CMakeLists.txt: Compile WebKitTestRunner for GTK+ when WebKit2 is enabled.
291         * WebKitTestRunner/CMakeLists.txt: Remove some EFL specific flags from the common
292         build file.
293         * WebKitTestRunner/PlatformEfl.cmake: Move the flags here.
294         * WebKitTestRunner/PlatformGTK.cmake: Added.
295
296 2013-12-20  Myles C. Maxfield  <mmaxfield@apple.com>
297
298         Myles C. Maxfield is a committer now
299
300         Unreviewed.
301
302         * Scripts/webkitpy/common/config/contributors.json:
303
304 2013-12-20  Mario Sanchez Prada  <mario.prada@samsung.com>
305
306         [ATK] [WK2] platform/gtk/accessibility/roles-exposed.html is failing
307         https://bugs.webkit.org/show_bug.cgi?id=125854
308
309         Reviewed by Chris Fleizach.
310
311         Ensure we don't ever create instances of AccessibilityUIElement
312         wrapping invalid platform-specific accessibility objects in DRT,
313         both for consistency with what WKTR does (so we avoid situations
314         where some tests fail in WK2 and not in WK1) and also to avoid
315         overlooking tests that might not be checking the right thing.
316
317         * DumpRenderTree/AccessibilityUIElement.cpp:
318         (AccessibilityUIElement::makeJSAccessibilityUIElement): Return a
319         nullPtr if the platformUIElement() is not a valid one.
320         * DumpRenderTree/AccessibilityUIElement.h:
321         (AccessibilityUIElement::platformUIElement): Added const modifier.
322
323 2013-12-20  Mario Sanchez Prada  <mario.prada@samsung.com>
324
325         Programmatically-inserted children lack accessibility events
326         https://bugs.webkit.org/show_bug.cgi?id=100275
327
328         Reviewed by Chris Fleizach.
329
330         Update DRT and WebKitTestRunner to handle the children-changed
331         signal properly, considering the detail and optional parameters.
332
333         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp: Updated.
334         (axObjectEventListener):
335         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp: Updated.
336
337 2013-12-20  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
338
339         Removed unused BUILDER_BASE_URL.
340         https://bugs.webkit.org/show_bug.cgi?id=125442
341
342         Reviewed by Csaba Osztrogonác.
343
344         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
345         (JSONGeneratorTest._test_json_generation): Trivial test fix after r160900.
346
347 2013-12-20  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
348
349         Removed unused BUILDER_BASE_URL.
350         https://bugs.webkit.org/show_bug.cgi?id=125442
351
352         Reviewed by Csaba Osztrogonác.
353
354         The string constant BUILDER_BASE_URL is passed around several times,
355         but we don't use it anywhere. It is a leftover from Chromium, cleaned it up.
356
357         * Scripts/webkitpy/layout_tests/controllers/manager.py:
358         (Manager._upload_json_files):
359         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
360         (JSONLayoutResultsGenerator.__init__):
361         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
362         (JSONResultsGenerator.__init__):
363
364 2013-12-19  Myles C. Maxfield  <mmaxfield@apple.com>
365
366         check-webkit-style mistakenly flags assigning to a dereferenced pointer
367         https://bugs.webkit.org/show_bug.cgi?id=126041
368
369         Reviewed by Ryosuke Niwa.
370
371         When checking for lines like "Foo *bar;", check-webkit-style doesn't make
372         sure that there is a declaration. This patch makes sure that there is a
373         declaration in order to flag spacing around asterisks.
374
375         * Scripts/webkitpy/style/checkers/cpp.py:
376         (check_spacing):
377         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
378         (CppStyleTest.test_pointer_reference_marker_location):
379
380 2013-12-19  Myles C. Maxfield  <mmaxfield@apple.com>
381
382         check-webkit-style marks rvalue references as violations
383         https://bugs.webkit.org/show_bug.cgi?id=126000
384
385         Reviewed by Ryosuke Niwa.
386
387         Previously, check-webkit-style was making sure that any line with "&&" had
388         spaces around it. However, we can now legitimately use "&&" without a previous
389         space when declaring an rvalue reference. This patch relaxes this check.
390
391         * Scripts/webkitpy/style/checkers/cpp.py:
392         (check_spacing):
393         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
394         (CppStyleTest.test_spacing_for_binary_ops):
395
396 2013-12-19  Myles C. Maxfield  <mmaxfield@apple.com>
397
398         check-webkit-style marks auto return types for functions as violations
399         https://bugs.webkit.org/show_bug.cgi?id=125999
400
401         Reviewed by Ryosuke Niwa.
402
403         If a function declaration ends with a "->" followed by a non whitespace
404         string, don't mark as an invalid "{" on its own line
405
406         * Scripts/webkitpy/style/checkers/cpp.py:
407         (check_braces):
408         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
409         (CppStyleTest.test_brace_at_begin_of_line):
410
411 2013-12-19  Alex Christensen  <achristensen@webkit.org>
412
413         [WinCairo] More GStreamer preparations.
414
415         Unreviewed.
416
417         * WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props:
418         Include FeatureDefinesCairo and WinCairo to compile the GLib part of WinLauncher.
419
420 2013-12-19  Lucas Forschler  <lforschler@apple.com>
421
422         Add Apple Mavericks perf bot.
423         
424         Unreviewed.
425
426         * BuildSlaveSupport/build.webkit.org-config/config.json:
427
428 2013-12-19  Commit Queue  <commit-queue@webkit.org>
429
430         Unreviewed, rolling out r160842.
431         http://trac.webkit.org/changeset/160842
432         https://bugs.webkit.org/show_bug.cgi?id=126003
433
434         broke accessibility/loading-iframe-updates-axtree.html
435         (Requested by ap on #webkit).
436
437         * DumpRenderTree/AccessibilityUIElement.cpp:
438         (AccessibilityUIElement::makeJSAccessibilityUIElement):
439         * DumpRenderTree/AccessibilityUIElement.h:
440         (AccessibilityUIElement::platformUIElement):
441
442 2013-12-19  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
443
444         get_test_baseline should get Host from test_config
445         https://bugs.webkit.org/show_bug.cgi?id=125989
446
447         Reviewed by Ryosuke Niwa.
448
449         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
450         (TestConfig.__init__):
451         (RebaselineServer._prepare_config):
452         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
453         (get_test_baselines):
454         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
455         (get_test_config):
456
457 2013-12-19  Roger Fong  <roger_fong@apple.com>
458
459         Don't check VSINSTALLDIR when looking for Visual Studio install directory.
460         https://bugs.webkit.org/show_bug.cgi?id=125998.
461
462         Reviewed by Alexey Proskuryakov.
463
464         * Scripts/webkitdirs.pm:
465         (visualStudioInstallDir):
466         Get rid of the VSINSTALLDIR check. We can't build on anything besides VS2013 now anyways.
467
468 2013-12-19  Mario Sanchez Prada  <mario.prada@samsung.com>
469
470         [ATK] [WK2] platform/gtk/accessibility/roles-exposed.html is failing
471         https://bugs.webkit.org/show_bug.cgi?id=125854
472
473         Reviewed by Chris Fleizach.
474
475         Ensure we don't ever create instances of AccessibilityUIElement
476         wrapping invalid platform-specific accessibility objects in DRT,
477         both for consistency with what WKTR does (so we avoid situations
478         where some tests fail in WK2 and not in WK1) and also to avoid
479         overlooking tests that might not be checking the right thing.
480
481         * DumpRenderTree/AccessibilityUIElement.cpp:
482         (AccessibilityUIElement::makeJSAccessibilityUIElement): Return a
483         nullPtr if the platformUIElement() is not a valid one.
484         * DumpRenderTree/AccessibilityUIElement.h:
485         (AccessibilityUIElement::platformUIElement): Added const modifier.
486
487 2013-12-18  Anders Carlsson  <andersca@apple.com>
488
489         Deprecate some WKMutableDictionary functions
490         https://bugs.webkit.org/show_bug.cgi?id=125962
491
492         Reviewed by Tim Horton.
493
494         * TestWebKitAPI/PlatformUtilities.cpp:
495         (TestWebKitAPI::Util::createInitializationDictionaryForInjectedBundleTest):
496         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp:
497         (TestWebKitAPI::didAssociateFormControls):
498         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
499         (TestWebKitAPI::WillLoadTest::willLoadURLRequest):
500         (TestWebKitAPI::WillLoadTest::willLoadDataRequest):
501         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
502         (WTR::createMouseMessageBody):
503         (WTR::EventSendingController::mouseMoveTo):
504         (WTR::EventSendingController::leapForward):
505         (WTR::createKeyDownMessageBody):
506         (WTR::EventSendingController::mouseScrollBy):
507         (WTR::EventSendingController::continuousMouseScrollBy):
508         (WTR::EventSendingController::addTouchPoint):
509         (WTR::EventSendingController::updateTouchPoint):
510         (WTR::EventSendingController::setTouchModifier):
511         (WTR::EventSendingController::setTouchPointRadius):
512         (WTR::EventSendingController::touchStart):
513         (WTR::EventSendingController::touchMove):
514         (WTR::EventSendingController::touchEnd):
515         (WTR::EventSendingController::touchCancel):
516         (WTR::EventSendingController::clearTouchPoints):
517         (WTR::EventSendingController::releaseTouchPoint):
518         (WTR::EventSendingController::cancelTouchPoint):
519         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
520         (WTR::InjectedBundle::done):
521         (WTR::InjectedBundle::setMockGeolocationPosition):
522         (WTR::InjectedBundle::setCustomPolicyDelegate):
523         (WTR::InjectedBundle::setVisibilityState):
524         (WTR::InjectedBundle::queueLoad):
525         (WTR::InjectedBundle::queueLoadHTMLString):
526         * WebKitTestRunner/TestController.cpp:
527         (WTR::TestController::initialize):
528         (WTR::TestController::resetStateToConsistentValues):
529         * WebKitTestRunner/TestInvocation.cpp:
530         (WTR::updateThreadedScrollingForCurrentTest):
531         (WTR::updateLayoutType):
532         (WTR::TestInvocation::invoke):
533
534 2013-12-18  Martin Robinson  <mrobinson@igalia.com>
535
536         [GTK] [CMake] Add support for building GtkLauncher
537         https://bugs.webkit.org/show_bug.cgi?id=125766
538
539         Reviewed by Gustavo Noronha Silva.
540
541         * CMakeLists.txt: Add the GtkLauncher subdirectory for the GTK port.
542         * GtkLauncher/CMakeLists.txt: Added.
543         * GtkLauncher/main.c: Support including the CMake config file.
544
545 2013-12-18  Alex Christensen  <achristensen@webkit.org>
546
547         [WinCairo] Preparation for GStreamer on Windows.
548         https://bugs.webkit.org/show_bug.cgi?id=125946
549
550         Reviewed by Brent Fulgham.
551
552         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
553         Use new GStreamer property sheets for WinCairo.
554         * win/DLLLauncher/DLLLauncherMain.cpp:
555         (modifyPath):
556         (wWinMain):
557         Prepend GStreamer bin directory to path if it exists.
558
559 2013-12-18  Anders Carlsson  <andersca@apple.com>
560
561         Remove now useless test.
562
563         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
564         * TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm: Removed.
565         * TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Bundle.mm: Removed.
566         * TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Shared.h: Removed.
567
568 2013-12-18  Gavin Barraclough  <barraclough@apple.com>
569
570         Fix page visibility api test, initialization in WebKit2
571         https://bugs.webkit.org/show_bug.cgi?id=125933
572
573         Reviewed by Anders Carlsson.
574
575         The API test for page visibility is broken, fix this. This revealed a recent regression in WebKit2
576         (introduced in https://bugs.webkit.org/show_bug.cgi?id=123379), caused by a typo removing a '!'.
577
578         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
579         (TestWebKitAPI::TEST_F):
580             - Running a test on WebKit1 twice is not the same as running it on WebKit2!
581
582 2013-12-18  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
583
584         Should not have identifiers with underscores in them, especially not leading underscores.
585         https://bugs.webkit.org/show_bug.cgi?id=125847
586
587         Reviewed by Darin Adler.
588
589         * Scripts/webkitpy/style/checkers/cpp.py:
590         (check_identifier_name_in_declaration):
591         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
592         (CppStyleTest.test_runtime_selfinit):
593         (WebKitStyleTest.test_names):
594
595 2013-12-18  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
596
597         False webkit-check-style warnings on *.
598         https://bugs.webkit.org/show_bug.cgi?id=125915
599
600         Reviewed by Darin Adler.
601
602         * Scripts/webkitpy/style/checkers/cpp.py:
603         (check_spacing):
604         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
605         (CppStyleTest.test_pointer_reference_marker_location):
606
607 2013-12-18  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
608
609         prepare-ChangeLog doesn't handle templates properly
610         https://bugs.webkit.org/show_bug.cgi?id=125853
611
612         Reviewed by Daniel Bates.
613
614         * Scripts/prepare-ChangeLog:
615         (get_function_line_ranges_for_cpp):
616         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
617         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp:
618         (Class110<TemplateClass>::func36):
619
620 2013-12-18  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
621
622         Move expectation parsing out of the constructor of TestExpectations
623         https://bugs.webkit.org/show_bug.cgi?id=125439
624
625         Reviewed by Csaba Osztrogonác.
626
627         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
628         (LayoutTestRunnerTests._run_tests):
629         (LayoutTestRunnerTests.test_interrupt_if_at_failure_limits):
630         (LayoutTestRunnerTests.test_update_summary_with_result):
631         * Scripts/webkitpy/layout_tests/controllers/manager.py:
632         (Manager.run):
633         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
634         (ManagerTest.test_look_for_new_crash_logs):
635         * Scripts/webkitpy/layout_tests/lint_test_expectations.py:
636         (lint):
637         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
638         (TestExpectations.suffixes_for_expectations):
639         (TestExpectations.__init__):
640         (TestExpectations):
641         (TestExpectations.parse_generic_expectations):
642         (TestExpectations.parse_default_port_expectations):
643         (TestExpectations.parse_override_expectations):
644         (TestExpectations.parse_all_expectations):
645         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
646         (parse_exp):
647         (SkippedTests.check):
648         (SkippedTests.test_skipped_entry_dont_exist):
649         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
650         (run_results):
651         * Scripts/webkitpy/tool/commands/queries.py:
652         (PrintExpectations._model):
653         * Scripts/webkitpy/tool/commands/rebaseline.py:
654         (RebaselineTest._update_expectations_file):
655         (RebaselineExpectations._update_expectations_files):
656         (RebaselineExpectations._tests_to_rebaseline):
657
658 2013-12-17  Jer Noble  <jer.noble@apple.com>
659
660         Fix TimeRanges::intersectWith
661         https://bugs.webkit.org/show_bug.cgi?id=118802
662
663         Reviewed by Eric Carlson.
664
665         Add unit tests for WebCore/TimeRanges.
666
667         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
668         * TestWebKitAPI/Tests/WebCore/TimeRanges.cpp: Added.
669         (TestWebKitAPI::ToString):
670         (TestWebKitAPI::TEST):
671
672 2013-12-17  Alexey Proskuryakov  <ap@apple.com>
673
674         Botwatcher's dashboard ceases to update itself after a while
675         https://bugs.webkit.org/show_bug.cgi?id=125885
676
677         Reviewed by Timothy Hatcher.
678
679         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
680         Removed code that checked for the view being hidden. It's none of model's business.
681
682         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
683         (BuildbotQueueView): Find out what platform the view is for. Initlialize update timer.
684         (BuildbotQueueView.prototype._updateHiddenState): Start or stop update timer as appropriate.
685         We now stop the timer for hidden views.
686         (BuildbotQueueView.prototype._updateQueues): Removed the logic for ignoring some updates.
687
688 2013-12-17  Anders Carlsson  <andersca@apple.com>
689
690         Fix the 32-bit build.
691
692         * MiniBrowser/MiniBrowserWebProcessPlugIn.h:
693         * MiniBrowser/MiniBrowserWebProcessPlugIn.m:
694
695 2013-12-17  Anders Carlsson  <andersca@apple.com>
696
697         Give the MiniBrowser a bundle
698         https://bugs.webkit.org/show_bug.cgi?id=125882
699
700         Reviewed by Sam Weinig.
701
702         * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig: Added.
703         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
704         * MiniBrowser/MiniBrowserWebProcessPlugIn.h: Added.
705         * MiniBrowser/MiniBrowserWebProcessPlugIn.m: Added.
706         (-[MiniBrowserWebProcessPlugIn webProcessPlugIn:initializeWithObject:]):
707         * MiniBrowser/mac/AppDelegate.m:
708         (-[BrowserAppDelegate init]):
709         * MiniBrowser/mac/Bundle/Info.plist: Added.
710         * MiniBrowser/mac/Bundle/MiniBrowserBundle_Prefix.pch: Added.
711
712 2013-12-17  Gavin Barraclough  <barraclough@apple.com>
713
714         Remove PageVisibilityStateUnloaded
715         https://bugs.webkit.org/show_bug.cgi?id=125869
716
717         Reviewed by Anders Carlsson.
718
719         This is not currently supported by WebKit, remove this enum value.
720         We can always add this back later if/when we add support for this state.
721
722         * DumpRenderTree/mac/TestRunnerMac.mm:
723         (TestRunner::setPageVisibility):
724         * TestWebKitAPI/Tests/WebKit2/PageVisibilityState.cpp:
725         (TestWebKitAPI::didRunStep3StateChangePrerenderToUnloaded):
726         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
727         (WTR::TestRunner::setPageVisibility):
728             - remove test for visibility state "unloaded"; this is no longer supported (it never really was).
729
730 2013-12-12  Martin Robinson  <mrobinson@igalia.com>
731
732         [GTK] [CMake] Build the plugin process against GTK+ 2
733         https://bugs.webkit.org/show_bug.cgi?id=116374
734
735         Reviewed by Gustavo Noronha Silva.
736
737         * TestWebKitAPI/PlatformGTK.cmake: Add WebCorePlatformGTK to the list of
738         libraries required for WebCore unit tests.
739
740 2013-12-17  Brent Fulgham  <bfulgham@apple.com>
741
742         [Win] Revise filter-build-webkit to deal with Windows build logs
743         https://bugs.webkit.org/show_bug.cgi?id=125866
744
745         Reviewed by David Kilzer.
746
747         Enhance the script to accept a 'platform' argument. When platform
748         'win' is provided, use processing for the Windows build file format.
749         Otherwise, process the files as normal.
750
751         * Scripts/filter-build-webkit:
752         (usageAndExit): Add a 'platform' argument
753         (shouldIgnoreLine): When platform == 'win' use the new Windows
754         rules for processing the build file.
755
756 2013-12-17  Alexey Proskuryakov  <ap@apple.com>
757
758         Update style checker now that ENUM_CLASS is gone
759         https://bugs.webkit.org/show_bug.cgi?id=125864
760
761         Reviewed by Anders Carlsson.
762
763         * Scripts/webkitpy/style/checkers/cpp.py:
764         (_EnumState.process_clean_line):
765         (check_braces):
766         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
767         (NoNonVirtualDestructorsTest.test_enum_casing.Foo):
768         (NoNonVirtualDestructorsTest.test_enum_casing):
769         (NoNonVirtualDestructorsTest.test_enum_casing.Enum123):
770         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon.CPP11EnumClass):
771         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon.MyEnum):
772         (WebKitStyleTest.test_braces.CPP11EnumClass):
773
774 2013-12-17  Mario Sanchez Prada  <mario.prada@samsung.com>
775
776         [ATK] Expose accessibility objects for <dl>, <dt> and <dd>
777         https://bugs.webkit.org/show_bug.cgi?id=125857
778
779         Reviewed by Chris Fleizach.
780
781         Add mappings to DRT & WKTR for the newly exposed roles, and
782         increase the version of ATK used by the internal jhbuild.
783
784         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
785         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
786         * gtk/jhbuild.modules: Raise version of ATK up to 2.11.4.
787
788 2013-12-17  Alex Christensen  <achristensen@webkit.org>
789
790         [WinCairo] Adding support for GStreamer and GLib.
791         https://bugs.webkit.org/show_bug.cgi?id=124867
792
793         Reviewed by Philippe Normand.
794
795         * WinLauncher/WinLauncher.cpp:
796         (wWinMain):
797         Added g_main_context_iteration in main event loop.
798
799 2013-12-17  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
800
801         Fix for C++ should have the & or * beside the type not the variable name check.
802         https://bugs.webkit.org/show_bug.cgi?id=125846
803
804         Reviewed by Darin Adler.
805
806         * Scripts/webkitpy/style/checkers/cpp.py:
807         (check_spacing):
808         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
809         (CppStyleTest.test_pointer_reference_marker_location):
810
811 2013-12-16  Rob Buis  <rob.buis@samsung.com>
812
813         Add my Samsung email address.
814
815         Unreviewed.
816
817         * Scripts/webkitpy/common/config/contributors.json:
818
819 2013-12-16  Oliver Hunt  <oliver@apple.com>
820
821         Cache getters and custom accessors on the prototype chain
822         https://bugs.webkit.org/show_bug.cgi?id=125602
823
824         Reviewed by Michael Saboff.
825
826         Make sure bencher scripts also make noInline exist
827
828         * Scripts/bencher:
829
830 2013-12-16  Anders Carlsson  <andersca@apple.com>
831
832         Fix crash when trying to load a null HTML string
833         https://bugs.webkit.org/show_bug.cgi?id=125801
834
835         Reviewed by Dan Bernstein.
836
837         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp:
838         (TestWebKitAPI::TEST_F):
839         Update test results.
840
841 2013-12-16  Alex Christensen  <achristensen@webkit.org>
842
843         Fixed Win64 build on VS2013.
844         https://bugs.webkit.org/show_bug.cgi?id=125753
845
846         Reviewed by Brent Fulgham.
847
848         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
849         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
850         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
851         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
852         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
853         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
854         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
855         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
856         * win/record-memory/record-memory.vcxproj:
857         Added correct PlatformToolset for 64-bit builds.
858
859 2013-12-16  Simon Fraser  <simon.fraser@apple.com>
860
861         Add a menu option to MiniBrowser to enable UI-side compositing
862         https://bugs.webkit.org/show_bug.cgi?id=125793
863
864         Reviewed by Anders Carlsson.
865         
866         Make it possible to test UI-side compositing in MiniBrowser WK2 windows.
867
868         * MiniBrowser/mac/BrowserWindowController.h: Add optional protocol method
869         to toggle UI-side compositing.
870         * MiniBrowser/mac/MainMenu.xib: Add menu item to Debug menu.
871         * MiniBrowser/mac/WK2BrowserWindowController.m:
872         (-[WK2BrowserWindowController validateMenuItem:]):
873         (-[WK2BrowserWindowController isUISideCompositingEnabled]):
874         (-[WK2BrowserWindowController toggleUISideCompositing:]):
875         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
876         Adjust the window title to indicate whether the window is using UI-side compositing.
877
878 2013-12-16  Commit Queue  <commit-queue@webkit.org>
879
880         Unreviewed, rolling out r160645.
881         http://trac.webkit.org/changeset/160645
882         https://bugs.webkit.org/show_bug.cgi?id=125787
883
884         Change breaks test-webkitpy (Requested by bfulgham on
885         #webkit).
886
887         * Scripts/prepare-ChangeLog:
888         (get_selector_line_ranges_for_css):
889
890 2013-12-16  David Farler  <dfarler@apple.com>
891
892         [ASAN] WebKitLauncher: Include libasancrashreporter.dylib in DYLD_INSERT_LIBRARIES if it exists
893         https://bugs.webkit.org/show_bug.cgi?id=124610
894
895         Reviewed by Mark Rowe.
896
897         * WebKitLauncher/WebKitNightlyEnabler.m:
898         (enableWebKitNightlyBehaviour):
899         Add libasancrashreporter.dylib to DYLD_INSERT_LIBRARIES.
900         * WebKitLauncher/main.m:
901         (main):
902         Include both libasancrashreporter and the nightly enabler to
903         the list of libraries to insert.
904
905 2013-12-16  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
906
907         Resolve inconsistant style warning caused by r160319.
908         https://bugs.webkit.org/show_bug.cgi?id=125772
909
910         Reviewed by Darin Adler.
911
912         * Scripts/webkitpy/style/checkers/cpp.py:
913         (check_for_extra_new_line_at_eof):
914         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
915         (CppStyleTest.test_newline_at_eof):
916         (CppStyleTest.test_extra_newlines_at_eof):
917
918 2013-12-16  Eva Balazsfalvi  <balazsfalvi.eva@stud.u-szeged.hu>
919
920         Remove mock_drt.py: parse_options() - --test-shell and --pixel-tests=<path>
921         https://bugs.webkit.org/show_bug.cgi?id=125780
922
923         Reviewed by Darin Adler.
924
925         * Scripts/webkitpy/port/mock_drt.py:
926         (main):
927         (parse_options):
928         (MockDRT.write_test_output):
929         * Scripts/webkitpy/port/mock_drt_unittest.py:
930         (MockDRTTest.assertTest):
931         (MockDRTTest.test_reftest_mismatch):
932
933 2013-12-16  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
934
935         prepare-Changelog treats CSS keyframes as mismatched parentheses.
936         https://bugs.webkit.org/show_bug.cgi?id=125435
937
938         Reviewed by Darin Adler.
939
940         * Scripts/prepare-ChangeLog:
941         (get_selector_line_ranges_for_css):
942
943 2013-12-16  Mario Sanchez Prada  <mario.prada@samsung.com>
944
945         [ATK] Expose accessibility objects for more WAI-ARIA roles
946         https://bugs.webkit.org/show_bug.cgi?id=125596
947
948         Reviewed by Chris Fleizach.
949
950         Add mappings to DRT & WKTR for the newly exposed roles.
951
952         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
953         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
954
955 2013-12-16  Mario Sanchez Prada  <mario.prada@samsung.com>
956
957         [ATK] Expose accessibility objects with ATK_ROLE_CHECK_MENU_ITEM
958         https://bugs.webkit.org/show_bug.cgi?id=125594
959
960         Reviewed by Chris Fleizach.
961
962         Add mappings to DRT & WKTR for checkmenuitem role.
963
964         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
965         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
966
967 2013-12-16  Mario Sanchez Prada  <mario.prada@samsung.com>
968
969         [ATK] Expose accessibility objects with ATK_ROLE_ARTICLE
970         https://bugs.webkit.org/show_bug.cgi?id=125587
971
972         Reviewed by Chris Fleizach.
973
974         Add mappings to DRT & WKTR for article roles.
975
976         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
977         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
978
979 2013-12-16  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
980
981         [FTL] Allow EFL to build FTL with the build-jsc script.
982         https://bugs.webkit.org/show_bug.cgi?id=125774
983
984         Reviewed by Zoltan Herczeg.
985
986         * Scripts/build-jsc:
987
988 2013-12-16  Krzysztof Czech  <k.czech@samsung.com>
989
990         Add myself as a committer
991
992         Unreviewed.
993
994         * Scripts/webkitpy/common/config/contributors.json:
995
996 2013-12-15  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
997
998         Refactor option handling in WebKitTestRunner.
999         https://bugs.webkit.org/show_bug.cgi?id=123185
1000
1001         Reviewed by Darin Adler.
1002
1003         Option handling is refactored (according to the FIXME) that allows
1004         to automatically generate the help message.
1005
1006         * WebKitTestRunner/CMakeLists.txt:
1007         * WebKitTestRunner/GNUmakefile.am:
1008         * WebKitTestRunner/Options.cpp: Added.
1009         (WTR::Options::Options):
1010         (WTR::handleOptionTimeout):
1011         (WTR::handleOptionNoTimeout):
1012         (WTR::handleOptionNoTimeoutAtAll):
1013         (WTR::handleOptionVerbose):
1014         (WTR::handleOptionGcBetweenTests):
1015         (WTR::handleOptionPixelTests):
1016         (WTR::handleOptionPrintSupportedFeatures):
1017         (WTR::handleOptionComplexText):
1018         (WTR::handleOptionAcceleratedDrawing):
1019         (WTR::handleOptionRemoteLayerTree):
1020         (WTR::handleOptionUnmatched):
1021         (WTR::OptionsHandler::OptionsHandler):
1022         (WTR::Option::Option):
1023         (WTR::Option::matches):
1024         (WTR::OptionsHandler::parse):
1025         (WTR::OptionsHandler::printHelp):
1026         * WebKitTestRunner/Options.h: Added.
1027         * WebKitTestRunner/TestController.cpp:
1028         (WTR::TestController::initialize):
1029         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1030
1031 2013-12-15  Dan Bernstein  <mitz@apple.com>
1032
1033         32-bit build fix.
1034
1035         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
1036         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.mm:
1037
1038 2013-12-14  Tim Horton  <timothy_horton@apple.com>
1039
1040         stylebot should warn when FeatureDefines differ
1041         https://bugs.webkit.org/show_bug.cgi?id=125748
1042
1043         Reviewed by Dan Bernstein.
1044
1045         Add a stylebot checker that ensures that FeatureDefines.xcconfig files
1046         are always exactly equal (and warns people adding new FeatureDefines.xcconfig files,
1047         an unlikely occurrance, to add them to the list).
1048
1049         It's a bit nontraditional for stylebot because it will warn on existing errors in the tree,
1050         but that is the most straightforward way to implement it (and we're at zero diffs right now).
1051
1052         * Scripts/webkitpy/style/checker.py:
1053         (_all_categories):
1054         (FileType):
1055         (CheckerDispatcher._file_type):
1056         (CheckerDispatcher._create_checker):
1057         * Scripts/webkitpy/style/checkers/featuredefines.py: Added.
1058         (FeatureDefinesChecker):
1059         (FeatureDefinesChecker.__init__):
1060         (FeatureDefinesChecker.check):
1061
1062 2013-12-13  Sam Weinig  <sam@webkit.org>
1063
1064         Fix API tests.
1065
1066         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp:
1067         (TestWebKitAPI::TEST_F):
1068
1069 2013-12-13  Brent Fulgham  <bfulgham@apple.com>
1070
1071         [Win] Remove Pre-VS2013 support code.
1072         https://bugs.webkit.org/show_bug.cgi?id=125693
1073
1074         Reviewed by Darin Adler.
1075
1076         * DumpRenderTree/cg/ImageDiffCG.cpp: Remove strtof stub now supplied by
1077         the math library.
1078         * DumpRenderTree/win/ImageDiffCairo.cpp: Ditto.
1079
1080 2013-12-13  Lucas Forschler  <lforschler@apple.com>
1081
1082         Update Webkit bots.
1083         
1084         Unreviewed.
1085         
1086         * BuildSlaveSupport/build.webkit.org-config/config.json:
1087
1088 2013-12-13  Brent Fulgham  <bfulgham@apple.com>
1089
1090         [Win] Unreviewed build fix after r160548
1091
1092         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj: Specify
1093         we are using vs12_xp target for Makefile-based projects.
1094
1095 2013-12-13  Lucas Forschler  <lforschler@apple.com>
1096
1097         Update Apple Webkit Bots
1098         
1099         Unreviewed.
1100
1101         * BuildSlaveSupport/build.webkit.org-config/config.json:
1102
1103 2013-12-13  Brent Fulgham  <bfulgham@apple.com>
1104
1105         Unreviewed build fix after r160548.
1106
1107         * Scripts/webkitdirs.pm:
1108         (setupCygwinEnv): VCExpress.exe is now called WDExpress.exe.
1109
1110 2013-12-13  Lucas Forschler  <lforschler@apple.com>
1111
1112         Update Apple bots.
1113         
1114         Unreviewed.
1115
1116         * BuildSlaveSupport/build.webkit.org-config/config.json:
1117
1118 2013-12-13  Brent Fulgham  <bfulgham@apple.com>
1119
1120         [Win] Switch WebKit solution to Visual Studio 2013
1121         https://bugs.webkit.org/show_bug.cgi?id=125192
1122
1123         Reviewed by Anders Carlsson.
1124
1125         Project files must reference vs12_xp for 32-bit builds. 
1126
1127         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
1128         Update for VS2013
1129         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
1130         Ditto
1131         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
1132         Ditto
1133         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
1134         Ditto
1135         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
1136         Ditto
1137         * Scripts/webkitdirs.pm:
1138         (visualStudioInstallDir): Specify VS2013
1139         (visualStudioVersion): Ditto.
1140         (setupAppleWinEnv): Use VS2013 in messages
1141         (setupCygwinEnv): Ditto
1142         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1143         Update for VS2013
1144         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
1145         Ditto
1146         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
1147         Ditto
1148         * win/record-memory/record-memory.vcxproj:
1149         Ditto
1150
1151 2013-12-11  Martin Robinson  <mrobinson@igalia.com> and Danilo Cesar Lemes de Paula  <danilo.cesar@collabora.co.uk>
1152
1153         Adding a .ycm_extra_conf file for webkitGtk
1154         https://bugs.webkit.org/show_bug.cgi?id=119618
1155
1156         Reviewed by Gustavo Noronha Silva.
1157
1158         Added a YouCompleteMe flag discovery script for Vim and the GTK+ port. The script
1159         read the GTK+ build files to determine dynamically what flags to compile a source
1160         file with. This allows Vim to provide auto-complete for C++/C language. See
1161         https://github.com/Valloric/YouCompleteMe for how to use this file.
1162
1163         * gtk/common.py:
1164         (get_build_path): Added a fatal argument to build_path to avoid crashing YCM on failure.
1165         * gtk/ycm_extra_conf.py: Added.
1166
1167 2013-12-12  Tim Horton  <timothy_horton@apple.com>
1168
1169         [wk2] Handle pinch-to-zoom gesture
1170         https://bugs.webkit.org/show_bug.cgi?id=125604
1171
1172         Reviewed by Simon Fraser.
1173
1174         * MiniBrowser/mac/WK2BrowserWindowController.m:
1175         (-[WK2BrowserWindowController awakeFromNib]):
1176         Enable handling of the magnification gesture in Minibrowser WebKit2 windows.
1177
1178 2013-12-12  Eunmi Lee  <eunmi15.lee@samsung.com>
1179
1180         Unreviewed. Add myself as a committer.
1181
1182         * Scripts/webkitpy/common/config/contributors.json:
1183
1184 2013-12-12  Lucas Forschler  <lforschler@apple.com>
1185
1186         Update hardware for Apple bots.
1187         
1188         Unreviewed.
1189
1190         * BuildSlaveSupport/build.webkit.org-config/config.json:
1191
1192 2013-12-12  Lucas Forschler  <lforschler@apple.com>
1193
1194         Remove unused Apple Bots.
1195         
1196         Unreviewed.
1197
1198         * BuildSlaveSupport/build.webkit.org-config/config.json:
1199
1200 2013-12-12  Thiago de Barros Lacerda  <thiago.lacerda@openbossa.org>
1201
1202         Unreviewed. Add myself as a committer.
1203
1204         * Scripts/webkitpy/common/config/contributors.json:
1205
1206 2013-12-12  Joseph Pecoraro  <pecoraro@apple.com>
1207
1208         Test new JSContext name APIs
1209         https://bugs.webkit.org/show_bug.cgi?id=125607
1210
1211         Reviewed by Darin Adler.
1212
1213         * Scripts/run-javascriptcore-tests:
1214         Remove trailing whitespace.
1215
1216 2013-12-12  Zan Dobersek  <zdobersek@igalia.com>
1217
1218         [Autotools] Prepend the WebCore layer archives' names with 'lib'
1219         https://bugs.webkit.org/show_bug.cgi?id=125627
1220
1221         Reviewed by Martin Robinson.
1222
1223         * TestWebKitAPI/GNUmakefile.am: Libtool can complain about the WebCore layer archives not being prepended
1224         with 'lib' when they are used during linking, so the prefix is now added to avoid such issues.
1225
1226 2013-12-12  Commit Queue  <commit-queue@webkit.org>
1227
1228         Unreviewed, rolling out r160446.
1229         http://trac.webkit.org/changeset/160446
1230         https://bugs.webkit.org/show_bug.cgi?id=125630
1231
1232         The upower-glib-based implementation is using API that was
1233         recently removed (Requested by zdobersek1 on #webkit).
1234
1235         * Scripts/webkitperl/FeatureList.pm:
1236
1237 2013-12-12  Commit Queue  <commit-queue@webkit.org>
1238
1239         Unreviewed, rolling out r160417.
1240         http://trac.webkit.org/changeset/160417
1241         https://bugs.webkit.org/show_bug.cgi?id=125629
1242
1243         The patch is causing crashes (Requested by zdobersek1 on
1244         #webkit).
1245
1246         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
1247         (axObjectEventListener):
1248         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1249
1250 2013-12-12  Zan Dobersek  <zdobersek@igalia.com>
1251
1252         Use of ar T option not supported by older binutils
1253         https://bugs.webkit.org/show_bug.cgi?id=118732
1254
1255         Reviewed by Gustavo Noronha Silva.
1256
1257         * TestWebKitAPI/GNUmakefile.am: To support non-thin archives when generating the WebCoreLayer archive,
1258         switch to using the AR_FLAGS variable (which can be overridden) for providing the ar flags for the
1259         new archive. Non-thin archives also pose the problem as their members are only noted by the basename
1260         of the member's object file, and not the full path to it. To work around that, all the object files
1261         under the build directory are listed by their relative paths. The members of various archives then have
1262         the basenames of their paths grepped against that list, with the found path correlating to the member
1263         finally added as the new member of the WebCoreLayer archive.
1264
1265 2013-12-11  Myles C. Maxfield  <mmaxfield@apple.com>
1266
1267         check-webkit-style shouldn't check spacing in #if preprocessor lines
1268         https://bugs.webkit.org/show_bug.cgi?id=125534
1269
1270         Reviewed by Ryosuke Niwa.
1271
1272         Preprocessor lines that start with #if shouldn't have to adhere to
1273         the same spacing requirements that regular code does
1274
1275         * Scripts/webkitpy/style/checkers/cpp.py:
1276         (check_spacing):
1277         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1278         (CppStyleTest.test_spacing_for_binary_ops):
1279         (WebKitStyleTest.test_line_breaking):
1280
1281 2013-12-11  Myles C. Maxfield  <mmaxfield@apple.com>
1282
1283         check-webkit-style can't determine if a comma is part of an initialization list
1284         https://bugs.webkit.org/show_bug.cgi?id=125537
1285
1286         Reviewed by Darin Adler.
1287
1288         The original check to make sure that initialization list lines start with
1289         a comma didn't distinguish between commas that belong to the initialization
1290         list and commas that are part of function calls. Because we don't want to
1291         match parentheses with regular expressions, we should weaken this check to
1292         only check for commas at the end of initialization list lines.
1293
1294         * Scripts/webkitpy/style/checkers/cpp.py:
1295         (check_member_initialization_list):
1296         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1297         (WebKitStyleTest.test_member_initialization_list):
1298
1299 2013-12-11  Tim Horton  <timothy_horton@apple.com>
1300
1301         Make it possible to compare layout test results between various configurations of WebKit
1302         https://bugs.webkit.org/show_bug.cgi?id=125212
1303         <rdar://problem/15199108>
1304
1305         Reviewed by Darin Adler.
1306
1307         * Scripts/compare-webkit-configurations: Added.
1308         Add a script that allows comparison between the "normal" WebKit configuration
1309         used for testing and a different configuration (e.g. with accelerated drawing
1310         turned on, with the remote layer tree enabled, or WebKit1 vs WebKit2), like so:
1311
1312         compare-webkit-configurations -2 --comparison=accelerated-drawing compositing/background-color
1313
1314         This script runs the tests once in the default configuration, ignoring
1315         all test expectations, writing the results out to a temporary directory.
1316
1317         It then runs the tests again in the modified configuration, against the
1318         just-written temporary results.
1319
1320         Ref tests are treated as pixel tests, with their pixel output dumped to disk.
1321
1322         * DumpRenderTree/mac/DumpRenderTree.mm:
1323         (resetWebPreferencesToConsistentValues):
1324         (initializeGlobalsFromCommandLineOptions):
1325         Enable accelerated drawing if requested.
1326
1327         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1328         (parse_args):
1329         Add --accelerated-drawing and --remote-layer-tree feature switches, which
1330         are forwarded on to the test drivers.
1331         Move those two and --complex-text into their own "feature switches" section.
1332         Drive-by change "Mac OS X" to "OS X".
1333         Add --treat-ref-tests-as-pixel-tests option, which treats ref tests
1334         as traditional pixel tests (with PNGs dumped on disk), and
1335         ignores e.g. -expected.html files.
1336
1337         * Scripts/webkitpy/port/base.py:
1338         (Port.reference_files):
1339         Pretend that there are no ref tests.
1340         Since is_reference_html_file is intact, our mechanism to ignore
1341         the expected files will continue working in this case.
1342
1343         * Scripts/webkitpy/port/driver.py:
1344         (Driver.cmd_line):
1345         Forward --accelerated-drawing and --remote-layer-tree to DRT/WKTR.
1346
1347         * WebKitTestRunner/TestController.cpp:
1348         (WTR::TestController::TestController):
1349         (WTR::TestController::initialize):
1350         (WTR::TestController::resetPreferencesToConsistentValues):
1351         * WebKitTestRunner/TestController.h:
1352         (WTR::TestController::shouldUseRemoteLayerTree):
1353         * WebKitTestRunner/TestInvocation.cpp:
1354         (WTR::updateThreadedScrollingForCurrentTest):
1355         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1356         (WTR::PlatformWebView::PlatformWebView):
1357         Parse and implement the three feature switches.
1358
1359 2013-12-11  Mario Sanchez Prada  <mario.prada@samsung.com>
1360
1361         [ATK] Expose accessibility objects WAI-ARIA landmark roles
1362         https://bugs.webkit.org/show_bug.cgi?id=125584
1363
1364         Reviewed by Chris Fleizach.
1365
1366         Add mappings to DRT & WKTR for landmark roles.
1367
1368         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1369         (AccessibilityUIElement::role):
1370         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1371         (WTR::AccessibilityUIElement::role):
1372         * gtk/jhbuild.modules:
1373
1374 2013-12-11  Alejandro G. Castro  <alex@igalia.com>
1375
1376         [GTK] Avoid double quotations when passing parameters to valgrind in gtk.py
1377         https://bugs.webkit.org/show_bug.cgi?id=125441
1378
1379         Reviewed by Martin Robinson.
1380
1381         Just avoid the double quotations when building the parameter
1382         because some versions of valgrind are not handling it correctly.
1383
1384         * Scripts/webkitpy/port/gtk.py:
1385         (GtkPort.setup_environ_for_server):
1386
1387 2013-12-11  Zan Dobersek  <zdobersek@igalia.com>
1388
1389         [GTK] Enable Battery Status API
1390         https://bugs.webkit.org/show_bug.cgi?id=125453
1391
1392         Reviewed by Martin Robinson.
1393
1394         * Scripts/webkitperl/FeatureList.pm: Enable the Battery Status API feature for the GTK port.
1395
1396 2013-12-11  José Dapena Paz  <jdapena@igalia.com> and Zan Dobersek  <zdobersek@igalia.com>
1397
1398         [GTK][WK2] Add the WebKitBatteryProvider class
1399         https://bugs.webkit.org/show_bug.cgi?id=115720
1400
1401         Reviewed by Martin Robinson.
1402
1403         * gtk/generate-gtkdoc:
1404         (get_webkit2_options): Ignore the WebKitBatteryProvider source files when generating the documentation.
1405
1406 2013-12-11  Mark Rowe  <mrowe@apple.com>
1407
1408         <https://webkit.org/b/125563> Remove the DumpRenderTree Perl Support module
1409
1410         Now that old-run-webkit-tests is not used on OS X it's not worth the time and effort
1411         to build and maintain this custom Perl module.
1412
1413         Reviewed by Anders Carlsson.
1414
1415         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Remove the target.
1416         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport.c: Removed.
1417         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportPregenerated.pm: Removed.
1418         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapPregenerated.c: Removed.
1419         * DumpRenderTree/mac/PerlSupport/Makefile: Removed.
1420         * Scripts/old-run-webkit-tests: Update a comment that referred to DumpRenderTreeSupport as a reason to
1421         build DumpRenderTree.
1422         (dumpToolDidCrash): Stop importing and using the module.
1423         * Scripts/webkitpy/port/base.py:
1424         (Port._build_driver): Update a comment in the same manner as in old-run-webkit-tests.
1425
1426 2013-12-11  Brendan Long  <b.long@cablelabs.com>
1427
1428         [GTK] Add "enable-mediasource" property to WebKitWebSettings
1429         https://bugs.webkit.org/show_bug.cgi?id=125566
1430
1431         Reviewed by Philippe Normand.
1432
1433         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1434         (resetDefaultsToConsistentValues): Turn MediaSource on by default for easier testing.
1435         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
1436         (TestRunner::overridePreference): Allow overriding WebKitMediaSourceEnabled.
1437
1438 2013-12-11  Dan Bernstein  <mitz@apple.com>
1439
1440         [Mac] Observe the activeURL property to keep the MiniBrowser URL field up to date
1441         https://bugs.webkit.org/show_bug.cgi?id=125579
1442
1443         Reviewed by Anders Carlsson.
1444
1445         * MiniBrowser/mac/WK2BrowserWindowController.m:
1446         (-[WK2BrowserWindowController dealloc]): Stop observing the activeURL property.
1447         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]): When the
1448         activeURL property changes, update the URL field with its value.
1449         (-[WK2BrowserWindowController awakeFromNib]): Start observing the activeURL property.
1450         (-[WK2BrowserWindowController browsingContextControllerDidStartProvisionalLoad:]): Just log.
1451         (-[WK2BrowserWindowController browsingContextControllerDidReceiveServerRedirectForProvisionalLoad:]):
1452         Ditto.
1453         (-[WK2BrowserWindowController browsingContextController:didFailProvisionalLoadWithError:]):
1454         Ditto.
1455         (-[WK2BrowserWindowController browsingContextControllerDidCommitLoad:]): Ditto.
1456         (-[WK2BrowserWindowController browsingContextController:didFailLoadWithError:]): Ditto.
1457
1458 2013-12-11  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
1459
1460         Fixed test-wepkitpy logging for buildslaves
1461         https://bugs.webkit.org/show_bug.cgi?id=125445
1462
1463         Reviewed by Csaba Osztrogonác.
1464
1465         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1466         (RunPythonTests):
1467
1468 2013-12-11  Mario Sanchez Prada  <mario.prada@samsung.com>
1469
1470         Programmatically-inserted children lack accessibility events
1471         https://bugs.webkit.org/show_bug.cgi?id=100275
1472
1473         Reviewed by Chris Fleizach.
1474
1475         Update DRT and WebKitTestRunner to handle the children-changed
1476         signal properly, considering the detail and optional parameters.
1477
1478         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp: Updated.
1479         (axObjectEventListener):
1480         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp: Updated.
1481
1482 2013-12-03  Mark Rowe  <mrowe@apple.com>
1483
1484         <https://webkit.org/b/125139> Modernize the WebKit API headers
1485         <rdar://problem/15540175>
1486
1487         Reviewed by Anders Carlsson.
1488
1489         * DumpRenderTree/mac/TestRunnerMac.mm:
1490         (TestRunner::setCacheModel): Cast to the enum type.
1491
1492 2013-12-10  Filip Pizlo  <fpizlo@apple.com>
1493
1494         Get rid of forward exit on DoubleAsInt32
1495         https://bugs.webkit.org/show_bug.cgi?id=125552
1496
1497         Reviewed by Oliver Hunt.
1498         
1499         Add some support for testing the generic (non-X86) paths on X86 by disabling
1500         architecture-specific optimizations (ASO's).
1501
1502         * Scripts/run-javascriptcore-tests:
1503         * Scripts/run-jsc-stress-tests:
1504
1505 2013-12-10  Ryuan Choi  <ryuan.choi@samsung.com>
1506
1507         Unreviewed EFL build fix attempt
1508
1509         * TestWebKitAPI/CMakeLists.txt: Added ${WEBKIT2_DIR}/Platform/CoreIPC to include lists.
1510         * WebKitTestRunner/CMakeLists.txt: Ditto.
1511
1512 2013-12-10  Anders Carlsson  <andersca@apple.com>
1513
1514         Add a HashMap constructor that takes an initializer list
1515         https://bugs.webkit.org/show_bug.cgi?id=125551
1516
1517         Reviewed by Dan Bernstein.
1518
1519         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1520         (TestWebKitAPI::TEST):
1521
1522 2013-12-10  Laszlo Vidacs  <lac@inf.u-szeged.hu>
1523
1524         Use std::array when computing MD5 checksum
1525         https://bugs.webkit.org/show_bug.cgi?id=125509
1526
1527         Reviewed by Anders Carlsson.
1528
1529         Use MD5::Digest type and MD5::hashSize when computing MD5 checksum.
1530
1531         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
1532         (computeMD5HashStringForBitmapContext):
1533         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:
1534         (computeMD5HashStringForBitmapContext):
1535         * TestWebKitAPI/Tests/WTF/MD5.cpp:
1536         (TestWebKitAPI::expectMD5):
1537         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
1538         (WTR::computeMD5HashStringForCairoSurface):
1539         * WebKitTestRunner/cg/TestInvocationCG.cpp:
1540         (WTR::computeMD5HashStringForContext):
1541
1542 2013-12-10  Mario Sanchez Prada  <mario.prada@samsung.com>
1543
1544         [ATK] Expose splitter elements with ATK_ROLE_SEPARATOR
1545         https://bugs.webkit.org/show_bug.cgi?id=125522
1546
1547         Reviewed by Chris Fleizach.
1548
1549         Update strings representing ATK_ROLE_SEPARATOR for layout tests.
1550
1551         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1552         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1553
1554 2013-12-10  Laszlo Vidacs  <lac@inf.u-szeged.hu>
1555
1556         Add --makeargs option to build-jsc
1557         https://bugs.webkit.org/show_bug.cgi?id=125344
1558
1559         Reviewed by Filip Pizlo.
1560
1561         * Scripts/build-jsc: Handle and pass makefile arguments in jsc build.
1562
1563 2013-12-10  Joanmarie Diggs  <jdiggs@igalia.com>
1564
1565         AX: [ATK] Convert the get_text atktest.c unit tests to layout tests
1566         https://bugs.webkit.org/show_bug.cgi?id=125497
1567
1568         Reviewed by Mario Sanchez Prada.
1569
1570         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1571         (AccessibilityUIElement::stringForRange): Implemented.
1572         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1573         (WTR::AccessibilityUIElement::stringForRange): Implemented.
1574
1575 2013-12-10  Martin Robinson  <mrobinson@igalia.com>
1576
1577         Various fixes for the CMake GTK+ build
1578
1579         Reviewed by Gustavo Noronha.
1580
1581         * MiniBrowser/gtk/CMakeLists.txt: Update source list and correct the name of BrowserMarshal.h.
1582         * TestWebKitAPI/PlatformGTK.cmake: Add GTK+ libraries to the test program. They're required.
1583
1584 2013-12-10  László Langó  <lango@inf.u-szeged.hu>
1585
1586         --cloop option does not work in Tools/Scripts/build-jsc.
1587         https://bugs.webkit.org/show_bug.cgi?id=125214
1588
1589         Reviewed by Csaba Osztrogonác.
1590
1591         * Scripts/build-jsc:
1592
1593 2013-12-10  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
1594
1595         Merge mark_for_landing and mark_for_commit_queue into one argument
1596         https://bugs.webkit.org/show_bug.cgi?id=125448
1597
1598         Reviewed by Ryosuke Niwa.
1599
1600         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1601         (CommitQueueFlag):
1602         (Bugzilla._commit_queue_flag):
1603         (Bugzilla._fill_attachment_form):
1604         (Bugzilla.add_patch_to_bug):
1605         (Bugzilla.create_bug):
1606         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1607         (test_commit_queue_flag.assert_commit_queue_flag):
1608         (test_commit_queue_flag):
1609
1610 2013-12-09  Tim Horton  <timothy_horton@apple.com>
1611
1612         Remove dead extract_reference_link.py (and the reftests module)
1613         https://bugs.webkit.org/show_bug.cgi?id=125116
1614
1615         Reviewed by Ryosuke Niwa.
1616
1617         This code doesn't seem to have ever been used.
1618
1619         * Scripts/webkitpy/layout_tests/reftests/__init__.py: Removed.
1620         * Scripts/webkitpy/layout_tests/reftests/extract_reference_link.py: Removed.
1621         * Scripts/webkitpy/layout_tests/reftests/extract_reference_link_unittest.py: Removed.
1622
1623 2013-12-09  Mario Sanchez Prada  <mario.prada@samsung.com>
1624
1625         [ATK] Translate ATK_ROLE_SECTION into "AXSection" in DRT/WKTR
1626         https://bugs.webkit.org/show_bug.cgi?id=125456
1627
1628         Reviewed by Chris Fleizach.
1629
1630         Return 'AXSection' for section roles instead of 'AXDiv'.
1631
1632         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1633         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1634
1635 2013-12-09  Brian J. Burg  <burg@cs.washington.edu>
1636
1637         check-webkit-style should check for extra newlines at EOF
1638         https://bugs.webkit.org/show_bug.cgi?id=125424
1639
1640         Reviewed by Darin Adler.
1641
1642         Report a style violation if extraneous newlines are added
1643         to the end of a C++ file. There should only be one newline at EOF.
1644
1645         * Scripts/webkitpy/style/checkers/cpp.py:
1646         (check_for_missing_new_line_at_eof): Renamed from check_for_new_line_at_eof.
1647         (check_for_extra_new_line_at_eof): Added.
1648         (_process_lines): Added new check and renamed existing EOF check.
1649         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1650         (CppStyleTest.test_extra_newlines_at_eof): Added.
1651         (CppStyleTest.test_extra_newlines_at_eof.do_test): Added.
1652
1653 2013-12-09  Laszlo Vidacs  <lac@inf.u-szeged.hu>
1654
1655         check-webkit-style: ternary operator in macro call identified as initialization list
1656         https://bugs.webkit.org/show_bug.cgi?id=125443
1657
1658         Reviewed by Ryosuke Niwa.
1659
1660         Do not match initialization list when questionmark is placed before :
1661
1662         * Scripts/webkitpy/style/checkers/cpp.py:
1663         (check_member_initialization_list):
1664
1665 2013-12-09  Joanmarie Diggs  <jdiggs@igalia.com>
1666
1667         AX: [ATK] Convert the get_{string,text}_at_offset atktest.c unit tests to layout tests
1668         https://bugs.webkit.org/show_bug.cgi?id=125451
1669
1670         Reviewed by Mario Sanchez Prada.
1671
1672         Create the needed callbacks for DRT and WKTR.
1673
1674         * DumpRenderTree/AccessibilityUIElement.cpp:
1675         (characterAtOffsetCallback): added
1676         (wordAtOffsetCallback): added
1677         (lineAtOffsetCallback): added
1678         (sentenceAtOffsetCallback): added
1679         (AccessibilityUIElement::getJSClass):
1680         * DumpRenderTree/AccessibilityUIElement.h:
1681         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1682         (stringAtOffset): added
1683         (AccessibilityUIElement::characterAtOffset): added
1684         (AccessibilityUIElement::wordAtOffset): added
1685         (AccessibilityUIElement::lineAtOffset): added
1686         (AccessibilityUIElement::sentenceAtOffset): added
1687         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1688         (WTR::AccessibilityUIElement::characterAtOffset): added
1689         (WTR::AccessibilityUIElement::wordAtOffset): added
1690         (WTR::AccessibilityUIElement::lineAtOffset): added
1691         (WTR::AccessibilityUIElement::sentenceAtOffset): added
1692         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1693         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1694         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1695         (WTR::stringAtOffset): added
1696         (WTR::AccessibilityUIElement::characterAtOffset): added
1697         (WTR::AccessibilityUIElement::wordAtOffset): added
1698         (WTR::AccessibilityUIElement::lineAtOffset): added
1699         (WTR::AccessibilityUIElement::sentenceAtOffset): added
1700
1701 2013-12-08  Sam Weinig  <sam@webkit.org>
1702
1703         32-bit MiniBrowser doesn't build
1704         https://bugs.webkit.org/show_bug.cgi?id=125420
1705
1706         Reviewed by Dan Bernstein.
1707
1708         * MiniBrowser/mac/AppDelegate.h:
1709         * MiniBrowser/mac/AppDelegate.m:
1710         (-[BrowserAppDelegate init]):
1711         (-[BrowserAppDelegate applicationWillTerminate:]):
1712
1713 2013-12-08  Brian Holt  <brian.holt@samsung.com>
1714
1715         [WK2] Add ENABLE_NETWORK_PROCESS flag
1716         https://bugs.webkit.org/show_bug.cgi?id=125421
1717
1718         Add support to build with the Network Process enabled.
1719
1720         Reviewed by Martin Robinson.
1721
1722         * Scripts/webkitperl/FeatureList.pm:
1723
1724 2013-12-07  Filip Pizlo  <fpizlo@apple.com>
1725
1726         Fold typedArray.length if typedArray is constant
1727         https://bugs.webkit.org/show_bug.cgi?id=125252
1728
1729         Reviewed by Sam Weinig.
1730         
1731         Add Source/JavaScriptCore/tests/stress to the set of JS tests. This is where you
1732         should put tests that run just like JSRegress but don't run as part of LayoutTests.
1733         Currently I'm using it for tests that require some surgical support from jsc.cpp.
1734
1735         * Scripts/run-javascriptcore-tests:
1736
1737 2013-12-08  Zan Dobersek  <zdobersek@igalia.com>
1738
1739         [gdb] Update printers for WTF::CString, JSC::JSString
1740         https://bugs.webkit.org/show_bug.cgi?id=124600
1741
1742         Reviewed by Gustavo Noronha Silva.
1743
1744         Update the two printers after they fell behind the changes in implementation.
1745
1746         * gdb/webkit.py:
1747         (WTFCStringPrinter.to_string):
1748         (JSCJSStringPrinter.to_string):
1749
1750 2013-12-08  Zan Dobersek  <zdobersek@igalia.com>
1751
1752         [webkitpy] Add a WestonDriver unit test
1753         https://bugs.webkit.org/show_bug.cgi?id=125408
1754
1755         Reviewed by Gustavo Noronha Silva.
1756
1757         Add a webkitpy unit test for the Weston driver.
1758
1759         * Scripts/webkitpy/port/westondriver_unittest.py: Added.
1760         (WestonDriverTest):
1761         (WestonDriverTest.make_driver): Sets up a new WestonDriver instance for testing purposes.
1762         (WestonDriverTest.test_start): Check that the Weston compositor is launched properly and that
1763         the server environment contains proper WAYLAND and GDK_BACKEND entries.
1764         (WestonDriverTest.test_stop): Check that the Weston compositor is terminated properly and that
1765         the driver cleans up the temporary directory.
1766         (WestonDriverTest.test_stop.FakeWestonProcess): A helper class that logs the expected termination.
1767         (WestonDriverTest.test_stop.FakeWestonProcess.terminate):
1768
1769 2013-12-08  Brendan Long  <b.long@cablelabs.com>
1770
1771         [Gtk] install-dependencies doesn't install libgtk-3-dev
1772         https://bugs.webkit.org/show_bug.cgi?id=125320
1773
1774         Reviewed by Gustavo Noronha Silva.
1775
1776         * gtk/install-dependencies: Add libgtk-3-dev, libsoup2.4 and subversion
1777
1778 2013-12-07  Sam Weinig  <sam@webkit.org>
1779
1780         [Cocoa] Convert a few more parts of MiniBrowser over to the Objective-C API
1781         https://bugs.webkit.org/show_bug.cgi?id=125401
1782
1783         Reviewed by Dan Bernstein.
1784
1785         * MiniBrowser/mac/WK2BrowserWindowController.m:
1786         (-[WK2BrowserWindowController fetch:]):
1787         (-[WK2BrowserWindowController reload:]):
1788         (-[WK2BrowserWindowController goBack:]):
1789         (-[WK2BrowserWindowController goForward:]):
1790         (-[WK2BrowserWindowController validateUserInterfaceItem:]):
1791         (-[WK2BrowserWindowController currentZoomFactor]):
1792         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
1793         (-[WK2BrowserWindowController zoomIn:]):
1794         (-[WK2BrowserWindowController zoomOut:]):
1795         (-[WK2BrowserWindowController canResetZoom]):
1796         (-[WK2BrowserWindowController resetZoom:]):
1797         (-[WK2BrowserWindowController toggleZoomMode:]):
1798         (-[WK2BrowserWindowController updateTextFieldFromURL:]):
1799
1800 2013-12-07  Sam Weinig  <sam@webkit.org>
1801
1802         Convert MiniBrowser to use WKProcessGroup and WKBrowsingContextGroup
1803         https://bugs.webkit.org/show_bug.cgi?id=125400
1804
1805         Reviewed by Dan Bernstein.
1806
1807         * MiniBrowser/mac/AppDelegate.h:
1808         * MiniBrowser/mac/AppDelegate.m:
1809         * MiniBrowser/mac/WK2BrowserWindowController.h:
1810         * MiniBrowser/mac/WK2BrowserWindowController.m:
1811         (-[WK2BrowserWindowController initWithProcessGroup:browsingContextGroup:]):
1812         (-[WK2BrowserWindowController dealloc]):
1813         (createNewPage):
1814         (-[WK2BrowserWindowController awakeFromNib]):
1815         (-[WK2BrowserWindowController browsingContextController:didNavigateWithNavigationData:]):
1816         (-[WK2BrowserWindowController browsingContextController:didPerformClientRedirectFromURL:toURL:]):
1817         (-[WK2BrowserWindowController browsingContextController:didPerformServerRedirectFromURL:toURL:]):
1818         (-[WK2BrowserWindowController browsingContextController:didUpdateHistoryTitle:forURL:]):
1819         Replace global WKContextRef and WKPageGroupRef with WKProcessGroup and WKBrowsingContextGroup. Also
1820         replace context based WKContextHistoryClient with WKBrowsingContextController based WKBrowsingContextHistoryDelegate
1821
1822 2013-12-07  Gustavo Noronha Silva  <gns@gnome.org>
1823
1824         [GTK] Run each gtest subtest separately instead of in one go
1825         https://bugs.webkit.org/show_bug.cgi?id=125386
1826
1827         Reviewed by Martin Robinson.
1828
1829         This is what other ports are doing (except they build each test as a separate binary)
1830         and will help with the timeouts we sometimes hit because it applies to the full test
1831         run.
1832
1833         * Scripts/run-gtk-tests:
1834         (TestRunner._get_tests_from_google_test_suite): get a list of available sub-tests.
1835         (TestRunner._run_google_test): run a single subtest from a gtest binary.
1836         (TestRunner._run_google_test_suite): call the binary once per subtest.
1837
1838 2013-12-07  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
1839
1840         Move PrettyPatch related code to prettypatch.py
1841         https://bugs.webkit.org/show_bug.cgi?id=124937
1842
1843         Reviewed by Ryosuke Niwa.
1844
1845         This code seems to have a better place here than in Port, since PrettyPatch already knows
1846         pretty_patch_path, and this also unifies the usage of PrettyPatch
1847
1848         * Scripts/webkitpy/common/prettypatch.py:
1849         (PrettyPatch.__init__):
1850         (PrettyPatch.pretty_diff):
1851         (PrettyPatch):
1852         (PrettyPatch.pretty_patch_available):
1853         (PrettyPatch.check_pretty_patch):
1854         (PrettyPatch.pretty_patch_text):
1855         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1856         (TestResultWriter.create_text_diff_and_write_result):
1857         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1858         (summarize_results):
1859         * Scripts/webkitpy/port/base.py:
1860         (Port.__init__):
1861         (Port.wdiff_available):
1862         (Port.check_image_diff):
1863         (Port.wdiff_text):
1864         * Scripts/webkitpy/port/base_unittest.py:
1865         (PortTest.test_pretty_patch_os_error):
1866         (PortTest.test_pretty_patch_script_error):
1867
1868 2013-12-06  Dan Bernstein  <mitz@apple.com>
1869
1870         [Mac] MiniBrowser Debug builds are compiled with -Os
1871         https://bugs.webkit.org/show_bug.cgi?id=125376
1872
1873         Reviewed by Tim Horton.
1874
1875         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Set GCC_OPTIMIZATION_LEVEL to 0 for
1876         the Debug configuration at the project level.
1877
1878 2013-12-06  Jer Noble  <jer.noble@apple.com>
1879
1880         [MSE] Add a runtime-setting for the MediaSource constructor.
1881         https://bugs.webkit.org/show_bug.cgi?id=125336
1882
1883         Reviewed by Eric Carlson.
1884
1885         Enable MediaSource in DRT and WKTR.
1886
1887         * DumpRenderTree/mac/DumpRenderTree.mm:
1888         (resetWebPreferencesToConsistentValues):
1889         * WebKitTestRunner/TestController.cpp:
1890         (WTR::TestController::resetPreferencesToConsistentValues):
1891
1892 2013-12-06  Jer Noble  <jer.noble@apple.com>
1893
1894         Strip out extraneous logging from AppleGVA in media tests.
1895         https://bugs.webkit.org/show_bug.cgi?id=125357
1896
1897         Reviewed by Simon Fraser.
1898
1899         Add a mechanism for stripping out abritrary regular expressions from test input and output.
1900
1901         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1902         (SingleTestRunner._run_compare_test): Strip out logging
1903         * Scripts/webkitpy/port/base.py:
1904         (Port.logging_patterns_to_strip): Return an empty list by default.
1905         * Scripts/webkitpy/port/driver.py:
1906         (DriverOutput.strip_patterns): Apply the port specific patterns to the text.
1907         * Scripts/webkitpy/port/mac.py:
1908         (MacPort.logging_patterns_to_strip): Return a complete list.
1909
1910 2013-12-06  Dean Jackson  <dino@apple.com>
1911
1912         Updating ANGLE should point to instructions
1913         https://bugs.webkit.org/show_bug.cgi?id=125361
1914
1915         Reviewed by Eric Carlson.
1916
1917         Point to https://trac.webkit.org/wiki/UpdatingANGLE when
1918         someone wants to patch ANGLE.
1919
1920         * Scripts/webkitpy/common/config/watchlist:
1921
1922 2013-12-06  Dan Bernstein  <mitz@apple.com>
1923
1924         [Mac] Transition MiniBrowser to the Cocoa API: load delegate
1925         https://bugs.webkit.org/show_bug.cgi?id=125334
1926
1927         Reviewed by Darin Adler.
1928
1929         * MiniBrowser/mac/WK2BrowserWindowController.m:
1930         (-[WK2BrowserWindowController dealloc]): Nil out the load delegate and stop observing the
1931         title property.
1932         (-[WK2BrowserWindowController isPaginated]): Changed to use Cocoa SPI.
1933         (-[WK2BrowserWindowController togglePaginationMode:]): Ditto.
1934         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]): Update the
1935         window title with the title property changes.
1936         (-[WK2BrowserWindowController awakeFromNib]): Start observing the title property. Changed to
1937         set the load delegate instead of the load client.
1938         (-[WK2BrowserWindowController updateTextFieldFromURL:]): Changed to use Cocoa types.
1939         (-[WK2BrowserWindowController updateProvisionalURL]): Removed frame parameter.
1940         (-[WK2BrowserWindowController updateCommittedURL]): Ditto.
1941         (-[WK2BrowserWindowController browsingContextControllerDidStartProvisionalLoad:]):
1942         Implemented this load delegate method.
1943         (-[WK2BrowserWindowController browsingContextControllerDidReceiveServerRedirectForProvisionalLoad:]):
1944         Ditto.
1945         (-[WK2BrowserWindowController browsingContextController:didFailProvisionalLoadWithError:]): Ditto.
1946         (-[WK2BrowserWindowController browsingContextControllerDidCommitLoad:]): Ditto.
1947         (-[WK2BrowserWindowController browsingContextControllerDidFinishLoad:]): Ditto.
1948         (-[WK2BrowserWindowController browsingContextController:didFailLoadWithError:]): Ditto.
1949         (-[WK2BrowserWindowController browsingContextControllerDidChangeBackForwardList:addedItem:removedItems:]):
1950         Ditto.
1951         (-[WK2BrowserWindowController browsingContextController:canAuthenticateAgainstProtectionSpace:]):
1952         Ditto.
1953         (-[WK2BrowserWindowController browsingContextController:didReceiveAuthenticationChallenge:]): Ditto.
1954
1955 2013-12-06  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
1956
1957         Remove function from style/checkers/cpp.py.
1958         https://bugs.webkit.org/show_bug.cgi?id=125341
1959
1960         Reviewed by Darin Adler.
1961
1962         Corrects a FIXME: by removing a function from cpp.py.
1963
1964         * Scripts/webkitpy/style/checkers/cpp.py:
1965         (CppChecker.__init__):
1966         (CppChecker.check):
1967         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1968         (CppStyleTestBase.process_file_data):
1969
1970 2013-12-06  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
1971
1972         check-webkit-style: false positive warning for indentation of #ifdef code.
1973         https://bugs.webkit.org/show_bug.cgi?id=125254
1974
1975         Reviewed by Darin Adler.
1976
1977         * Scripts/webkitpy/style/checkers/cpp.py:
1978         (check_member_initialization_list):
1979         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1980         (WebKitStyleTest.test_member_initialization_list):
1981
1982 2013-12-06  Chris Fleizach  <cfleizach@apple.com>
1983
1984         Fix spelling error in style checker: beggining
1985         https://bugs.webkit.org/show_bug.cgi?id=125347
1986
1987         Reviewed by Anders Carlsson.
1988
1989         * Scripts/webkitpy/style/checkers/cpp.py:
1990         (check_member_initialization_list):
1991         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1992         (WebKitStyleTest.test_member_initialization_list):
1993
1994 2013-12-06  Lukasz Gajowy  <l.gajowy@samsung.com>
1995
1996         [ATK] Missing aria roles mappings
1997         https://bugs.webkit.org/show_bug.cgi?id=117729
1998
1999         Reviewed by Mario Sanchez Prada.
2000
2001         Added new mappings to AccessibilityUIElementAtk.cpp.
2002
2003         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2004         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2005
2006 2013-12-06  Csaba Osztrogonác  <ossy@webkit.org>
2007
2008         Typo fix after r160218.
2009
2010         * Scripts/webkitpy/test/main.py:
2011         (main):
2012
2013 2013-12-06  Csaba Osztrogonác  <ossy@webkit.org>
2014
2015         Unreviewed fix after r160206.
2016
2017         * Scripts/webkitpy/test/main.py:
2018         (main): sys.platform can be win32 or cygwin too on Windows.
2019
2020 2013-12-05  Csaba Osztrogonác  <ossy@webkit.org>
2021
2022         Disable WebKit2 webkitpy unittests on Windows
2023         https://bugs.webkit.org/show_bug.cgi?id=125318
2024
2025         Reviewed by Ryosuke Niwa.
2026
2027         * Scripts/webkitpy/test/main.py:
2028         (main):
2029
2030 2013-12-05  Anders Carlsson  <andersca@apple.com>
2031
2032         Tweak WeakObjCPtr
2033         https://bugs.webkit.org/show_bug.cgi?id=125311
2034
2035         Reviewed by Darin Adler.
2036
2037         Split up tests into more logical groups. Add new tests for new functionality.
2038
2039         * TestWebKitAPI/Tests/WebKit2/mac/WeakObjCPtr.mm:
2040
2041 2013-12-05  Carlos Garcia Campos  <cgarcia@igalia.com>
2042
2043         [GTK] Fix gtk-doc warnings when generating DOM bindings API docs
2044         https://bugs.webkit.org/show_bug.cgi?id=125302
2045
2046         Reviewed by Philippe Normand.
2047
2048         * gtk/generate-webkitdom-doc-files:
2049         (WebKitDOMDocGeneratorSections.write_footer): Add a new section
2050         containing a private subsection for WEBKIT_API, WEBKIT_DEPRECATED
2051         and WEBKIT_DEPRECATED_FOR macros.
2052
2053 2013-12-05  Laszlo Vidacs  <lac@inf.u-szeged.hu>
2054
2055         Fix cross compilation on x86
2056         https://bugs.webkit.org/show_bug.cgi?id=125295
2057
2058         Reviewed by Zoltan Herczeg.
2059
2060         Certain compiler flags should not be added when cross compilation is enabled.
2061
2062         * Scripts/webkitdirs.pm:
2063         (runAutogenForAutotoolsProjectIfNecessary):
2064         (generateBuildSystemFromCMakeProject):
2065
2066 2013-12-05  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
2067
2068         Remove duplicated/dead code from cpp style checker unit tests.
2069         https://bugs.webkit.org/show_bug.cgi?id=125226
2070
2071         Reviewed by Ryosuke Niwa.
2072
2073         Remove the first definition of OrderOfIncludesTest class as it is
2074         overwritten by the second. Remove a duplicated assert statement
2075         from the second class.
2076
2077         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2078         (OrderOfIncludesTest.setUp):
2079         (OrderOfIncludesTest.test_try_drop_common_suffixes):
2080           The last assert was duplicated.
2081
2082 2013-12-05  László Langó  <lango@inf.u-szeged.hu>
2083
2084         Remove Scripts/generate-qt-inspector-resource.
2085         https://bugs.webkit.org/show_bug.cgi?id=125288
2086
2087         Reviewed by Andreas Kling.
2088
2089         * Scripts/generate-qt-inspector-resource: Removed. There is no QT anymore.
2090         We don't need this file.
2091
2092 2013-12-05  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
2093
2094         Remove certain methods from TestExpectations and use TestExpectationsModel instead of them
2095         https://bugs.webkit.org/show_bug.cgi?id=125218
2096
2097         Reviewed by Ryosuke Niwa.
2098
2099         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
2100         (LayoutTestFinder.skip_tests):
2101         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2102         (LayoutTestRunner.run_tests):
2103         (LayoutTestRunner._update_summary_with_result):
2104         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2105         (Manager._test_is_slow):
2106         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2107         (JSONLayoutResultsGenerator._insert_failure_summaries):
2108         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2109         (TestExpectations.get_rebaselining_failures):
2110         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2111         (assert_exp):
2112         (MiscTests.test_multiple_results):
2113         (MiscTests.test_category_expectations):
2114         (MiscTests.test_get_modifiers):
2115         (MiscTests.test_get_expectations_string):
2116         (MiscTests.test_expectation_to_string):
2117         (MiscTests.test_get_test_set):
2118         (MiscTests.test_more_specific_override_resets_skip):
2119         (SkippedTests.check):
2120         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2121         (TestRunResults.__init__):
2122         (summarize_results):
2123         * Scripts/webkitpy/tool/commands/rebaseline.py:
2124         (RebaselineExpectations._tests_to_rebaseline):
2125
2126 2013-12-04  Ryosuke Niwa  <rniwa@webkit.org>
2127
2128         Enable HTMLTemplateElement by default
2129         https://bugs.webkit.org/show_bug.cgi?id=123851
2130
2131         Reviewed by Antti Koivisto.
2132
2133         * Scripts/webkitperl/FeatureList.pm:
2134
2135 2013-12-04  Jozsef Berta  <jberta@inf.u-szeged.hu>
2136
2137         [EFL] Bumping GStreamer version to 1.2.1
2138         https://bugs.webkit.org/show_bug.cgi?id=125155
2139
2140         Reviewed by Gyuyoung Kim.
2141
2142         * efl/jhbuild.modules: Set the GStreamer version to 1.2.1
2143
2144
2145 2013-12-04  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
2146
2147         Update jhbuild revision.
2148         https://bugs.webkit.org/show_bug.cgi?id=124966
2149         
2150         Reviewed by Gyuyoung Kim.
2151
2152         Used version of Jhbuild failed to create directories and caused
2153         update-webkitefl-libs to fail. Latest Jhbuild version has it fixed.
2154
2155         * jhbuild/jhbuild-wrapper:
2156
2157 2013-12-04  Anders Carlsson  <andersca@apple.com>
2158
2159         Add a WeakObjCPtr class
2160         https://bugs.webkit.org/show_bug.cgi?id=125267
2161
2162         Reviewed by Geoffrey Garen.
2163
2164         Add API tests for WeakObjCPtr.
2165
2166         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2167         * TestWebKitAPI/Tests/WebKit2/mac/WeakObjCPtr.mm: Added.
2168         (TEST):
2169
2170 2013-12-04  Anders Carlsson  <andersca@apple.com>
2171
2172         Make the estimatedProgress property observable using KVO
2173         https://bugs.webkit.org/show_bug.cgi?id=125259
2174
2175         Reviewed by Dan Bernstein.
2176
2177         Bind the progress indicator value to the "estimatedProgress" property.
2178
2179         * MiniBrowser/mac/WK2BrowserWindowController.m:
2180         (-[WK2BrowserWindowController dealloc]):
2181         (-[WK2BrowserWindowController awakeFromNib]):
2182
2183 2013-12-04  Anders Carlsson  <andersca@apple.com>
2184
2185         Add a loading property to WKBrowsingContextController
2186         https://bugs.webkit.org/show_bug.cgi?id=125256
2187
2188         Reviewed by Dan Bernstein.
2189
2190         Bind the progress indicator visibility to the "loading" property.
2191
2192         * MiniBrowser/mac/WK2BrowserWindowController.m:
2193         (-[WK2BrowserWindowController dealloc]):
2194         (-[WK2BrowserWindowController awakeFromNib]):
2195         (-[WK2BrowserWindowController didStartProgress]):
2196         (-[WK2BrowserWindowController didFinishProgress]):
2197
2198 2013-12-04  Nick Diego Yamane  <nick.yamane@openbossa.org>
2199
2200         [EFL][WK2] Buildfix after r160104
2201         https://bugs.webkit.org/show_bug.cgi?id=125231
2202
2203         Reviewed by Anders Carlsson.
2204
2205         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp:
2206         (TestWebKitAPI::TEST): reinterpret_cast<WKFooClientBase*>(&client) -> &client.base
2207         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
2208         (TestWebKitAPI::setViewClient): Ditto.
2209
2210 2013-12-04  Myles C. Maxfield  <mmaxfield@apple.com>
2211
2212         check-webkit-style detected some ternary statements as initialization lists
2213         https://bugs.webkit.org/show_bug.cgi?id=125246
2214
2215         Reviewed by Dean Jackson.
2216
2217         The regular expression that check-webkit-tests uses to detect initialization
2218         lists was too broad, resulting in false positives. This patch makes the
2219         regex more specific
2220
2221         * Scripts/webkitpy/style/checkers/cpp.py:
2222         (check_member_initialization_list):
2223         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2224         (WebKitStyleTest.test_member_initialization_list):
2225
2226 2013-12-04  Mark Hahnenberg  <mhahnenberg@apple.com>
2227
2228         run-jsc-stress-tests can only run locally
2229         https://bugs.webkit.org/show_bug.cgi?id=124551
2230
2231         Reviewed by Filip Pizlo.
2232
2233         * Scripts/jsc-stress-test-helpers/shell-runner.sh: Fixed a couple issues. One was if the script was
2234         killed before the lock directory was removed, future executions wouldn't make any progress. Also 
2235         added a couple more signals to handle gracefully at shutdown. 
2236         * Scripts/run-javascriptcore-tests: Pass through the --remote argument to run-jsc-stress-tests.
2237         * Scripts/run-jsc-stress-tests: Added support for the --remote flag. It accepts a hostname, user, and port.
2238         The script then generates the test bundle, tars it up, and copies it to the remote host via ssh where
2239         it then untars the bundle and executes the shell-based test runner. Also refactored some of the logic
2240         toward the end of the script to make it easier to tell which of the various modes do what.
2241
2242 2013-12-04  Csaba Osztrogonác  <ossy@webkit.org>
2243
2244         [EFL][WK2] Buildfix after r160104
2245         https://bugs.webkit.org/show_bug.cgi?id=125233
2246
2247         Reviewed by Anders Carlsson.
2248
2249         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp:
2250         (TestWebKitAPI::TEST):
2251         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
2252         (TestWebKitAPI::setPageLoaderClient):
2253
2254 2013-12-03  Anders Carlsson  <andersca@apple.com>
2255
2256         Deprecate all unversioned client structs in favor of having explicit versioned structs
2257         https://bugs.webkit.org/show_bug.cgi?id=125203
2258
2259         Reviewed by Dan Bernstein.
2260
2261         Update for WebKit2 API changes.
2262
2263         * MiniBrowser/mac/AppDelegate.m:
2264         (-[BrowserAppDelegate init]):
2265         * MiniBrowser/mac/WK2BrowserWindowController.m:
2266         (-[WK2BrowserWindowController awakeFromNib]):
2267         * TestWebKitAPI/InjectedBundleController.cpp:
2268         (TestWebKitAPI::InjectedBundleController::initialize):
2269         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
2270         (TestWebKitAPI::TEST):
2271         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
2272         (TestWebKitAPI::setInjectedBundleClient):
2273         * TestWebKitAPI/Tests/WebKit2/CloseThenTerminate.cpp:
2274         (TestWebKitAPI::TEST):
2275         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
2276         (TestWebKitAPI::TEST):
2277         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
2278         (TestWebKitAPI::TEST):
2279         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
2280         (TestWebKitAPI::DOMWindowExtensionBasic::didCreatePage):
2281         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache.cpp:
2282         (TestWebKitAPI::TEST):
2283         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
2284         (TestWebKitAPI::DOMWindowExtensionNoCache::didCreatePage):
2285         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp:
2286         (TestWebKitAPI::setInjectedBundleClient):
2287         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp:
2288         (TestWebKitAPI::DidAssociateFormControlsTest::didCreatePage):
2289         * TestWebKitAPI/Tests/WebKit2/DidNotHandleKeyDown.cpp:
2290         (TestWebKitAPI::TEST):
2291         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
2292         (TestWebKitAPI::TEST):
2293         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
2294         (TestWebKitAPI::setContextDownloadClient):
2295         (TestWebKitAPI::setPagePolicyClient):
2296         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
2297         (TestWebKitAPI::TEST):
2298         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
2299         (TestWebKitAPI::TEST):
2300         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
2301         (TestWebKitAPI::TEST):
2302         * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
2303         (TestWebKitAPI::TEST):
2304         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
2305         (TestWebKitAPI::TEST):
2306         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
2307         (TestWebKitAPI::TEST):
2308         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
2309         (TestWebKitAPI::setupGeolocationProvider):
2310         (TestWebKitAPI::setupView):
2311         (TestWebKitAPI::TEST):
2312         * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback.cpp:
2313         (TestWebKitAPI::TEST):
2314         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
2315         (TestWebKitAPI::setPageLoaderClient):
2316         (TestWebKitAPI::setInjectedBundleClient):
2317         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
2318         (TestWebKitAPI::HitTestResultNodeHandleTest::didCreatePage):
2319         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
2320         (TestWebKitAPI::TEST):
2321         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest.cpp:
2322         (TestWebKitAPI::setInjectedBundleClient):
2323         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest_Bundle.cpp:
2324         (TestWebKitAPI::InjectedBundleFrameHitTestTest::didCreatePage):
2325         * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins.cpp:
2326         (TestWebKitAPI::TEST):
2327         * TestWebKitAPI/Tests/WebKit2/LayoutMilestonesWithAllContentInFrame.cpp:
2328         (TestWebKitAPI::TEST):
2329         * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
2330         (TestWebKitAPI::TEST):
2331         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp:
2332         (TestWebKitAPI::TEST):
2333         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp:
2334         (TestWebKitAPI::LoadCanceledNoServerRedirectCallbackTest::didCreatePage):
2335         * TestWebKitAPI/Tests/WebKit2/LoadPageOnCrash.cpp:
2336         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
2337         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
2338         (TestWebKitAPI::setPageLoaderClient):
2339         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:
2340         (TestWebKitAPI::setPageLoaderClient):
2341         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp:
2342         (TestWebKitAPI::setPageLoaderClient):
2343         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
2344         (TestWebKitAPI::setPageLoaderClient):
2345         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
2346         (TestWebKitAPI::setPageLoaderClient):
2347         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
2348         (TestWebKitAPI::TEST):
2349         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2350         (TestWebKitAPI::TEST):
2351         * TestWebKitAPI/Tests/WebKit2/ParentFrame.cpp:
2352         (TestWebKitAPI::setInjectedBundleClient):
2353         * TestWebKitAPI/Tests/WebKit2/ParentFrame_Bundle.cpp:
2354         (TestWebKitAPI::ParentFrameTest::didCreatePage):
2355         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications.mm:
2356         (TestWebKitAPI::setInjectedBundleClient):
2357         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications_Bundle.cpp:
2358         (TestWebKitAPI::PasteboardNotificationsTest::didCreatePage):
2359         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp:
2360         (TestWebKitAPI::TEST):
2361         * TestWebKitAPI/Tests/WebKit2/ReloadPageAfterCrash.cpp:
2362         (TestWebKitAPI::TEST):
2363         * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
2364         (TestWebKitAPI::TEST):
2365         * TestWebKitAPI/Tests/WebKit2/ResizeWindowAfterCrash.cpp:
2366         (TestWebKitAPI::TEST):
2367         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
2368         (TestWebKitAPI::setInjectedBundleClient):
2369         (TestWebKitAPI::setPageLoaderClient):
2370         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
2371         (TestWebKitAPI::setPageLoaderClient):
2372         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
2373         (TestWebKitAPI::TEST):
2374         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp:
2375         (TestWebKitAPI::setPageLoaderClient):
2376         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem_Bundle.cpp:
2377         (TestWebKitAPI::ShouldGoToBackForwardListItemTest::didCreatePage):
2378         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
2379         (TestWebKitAPI::TEST):
2380         * TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp:
2381         (TestWebKitAPI::TEST):
2382         * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp:
2383         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::setInjectedBundleClient):
2384         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::setPageLoaderClient):
2385         * TestWebKitAPI/Tests/WebKit2/WKConnection.cpp:
2386         (TestWebKitAPI::TEST):
2387         * TestWebKitAPI/Tests/WebKit2/WKConnection_Bundle.cpp:
2388         (TestWebKitAPI::WKConnectionTest::initialize):
2389         * TestWebKitAPI/Tests/WebKit2/WKPageGetScaleFactorNotZero.cpp:
2390         (TestWebKitAPI::setPageLoaderClient):
2391         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
2392         (TestWebKitAPI::setInjectedBundleClient):
2393         (TestWebKitAPI::TEST):
2394         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp:
2395         (TestWebKitAPI::WebKit2WillLoadTest::setInjectedBundleClient):
2396         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
2397         * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent.cpp:
2398         (TestWebKitAPI::setInjectedBundleClient):
2399         * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent_Bundle.cpp:
2400         (TestWebKitAPI::WillSendSubmitEventTest::didCreatePage):
2401         * TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm:
2402         (TestWebKitAPI::TEST):
2403         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm:
2404         (TestWebKitAPI::setInjectedBundleClient):
2405         * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp:
2406         (TestWebKitAPI::TEST):
2407         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp:
2408         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing_Bundle.cpp:
2409         (TestWebKitAPI::DenyWillSendRequestTest::didCreatePage):
2410         * TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm:
2411         (TestWebKitAPI::didCreateConnection):
2412         (TestWebKitAPI::TEST):
2413         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
2414         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::initializeView):
2415         * TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Bundle.mm:
2416         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
2417         (TestWebKitAPI::setPageLoaderClient):
2418         * WebKitTestRunner/GeolocationProviderMock.cpp:
2419         (WTR::GeolocationProviderMock::GeolocationProviderMock):
2420         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2421         (WTR::InjectedBundle::initialize):
2422         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2423         (WTR::InjectedBundlePage::InjectedBundlePage):
2424         * WebKitTestRunner/TestController.cpp:
2425         (WTR::TestController::createOtherPage):
2426         (WTR::TestController::initialize):
2427         (WTR::TestController::createWebViewWithOptions):
2428
2429 2013-12-04  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
2430
2431         Style checker for .messages.in files (WTF:: prefix)
2432         https://bugs.webkit.org/show_bug.cgi?id=125142
2433
2434         Reviewed by Anders Carlsson.
2435
2436         A new style checker for .messages.in files, that checks for the use of WTF::
2437         prefix in these files. (Also checks for tabs as these files were previously
2438         handled as text files.)
2439
2440         * Scripts/webkitpy/style/checker.py:
2441         (CheckerDispatcher._create_checker):
2442           New checker is returned for .messages.in files.
2443         * Scripts/webkitpy/style/checkers/messagesin.py: Added.
2444           The new style checker class.
2445         (MessagesInChecker):
2446         (MessagesInChecker.__init__):
2447         (MessagesInChecker.check):
2448         (MessagesInChecker.check_WTF_prefix):
2449         * Scripts/webkitpy/style/checkers/messagesin_unittest.py: Added.
2450           Unit test for the new style  checker class.
2451         (MessagesInCheckerStyleTestCase):
2452         (test_checker):
2453         (test_checker.error_handler_for_test):
2454         (MessagesInCheckerTestCase):
2455         (MessagesInCheckerTestCase.test_init):
2456         (MessagesInCheckerTestCase.test_init.error_handler_for_test):
2457
2458 2013-12-04  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
2459
2460         Style checker requires alphabetical ordering in cmake lists even it contains variable.
2461         https://bugs.webkit.org/show_bug.cgi?id=124918
2462
2463         Reviewed by Csaba Osztrogonác.
2464
2465         * Scripts/webkitpy/style/checkers/cmake_unittest.py:
2466         (CMakeCheckerTest.test_check):
2467         * Scripts/webkitpy/style/checkers/cmake.py:
2468         (CMakeChecker._check_list_order):
2469         This will ignore lines with variable substitution.
2470
2471 2013-12-04  László Langó  <lango@inf.u-szeged.hu>
2472
2473         check-webkit-style is wrong about expected format parameter pack rvalue reference arguments
2474         https://bugs.webkit.org/show_bug.cgi?id=124731
2475
2476         Reviewed by Zoltan Herczeg.
2477
2478         * Scripts/webkitpy/style/checkers/cpp.py:
2479         (check_spacing):
2480         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2481         (Cpp11StyleTest.test_rvaule_reference_in_parameter_pack):
2482
2483 2013-12-04  László Langó  <lango@inf.u-szeged.hu>
2484
2485         Remove codecs and os dependencies from filereader.py in webkitpy/style.
2486         https://bugs.webkit.org/show_bug.cgi?id=124719
2487
2488         Although TextFileReader requires a FileSystem it circumvents it in two places!
2489         We should use the FileSystem only and remove codecs and os imports.
2490
2491         Reviewed by Zoltan Herczeg.
2492
2493         * Scripts/webkitpy/common/system/filesystem.py:
2494         (FileSystem.open_stdin): Moved from TextFileReader
2495         * Scripts/webkitpy/style/filereader.py:
2496         (TextFileReader._read_lines): use FileSystem instead of calling codecs.open directly
2497         (TextFileReader._process_directory): use FileSystem instead of calling os.walk directly
2498
2499 2013-12-04  László Langó  <lango@inf.u-szeged.hu>
2500
2501         check-webkit-style should check member initialization indentation.
2502         https://bugs.webkit.org/show_bug.cgi?id=124820
2503
2504         Reviewed by Zoltan Herczeg.
2505
2506         check-webkit-style should check member initialization indentation
2507         belongs to webkit coding style:
2508         http://www.webkit.org/coding/coding-style.html#punctuation-member-init
2509
2510         * Scripts/webkitpy/style/checkers/cpp.py:
2511         (check_member_initialization_list): Add new method to check member
2512         initialization list.
2513         (check_style): Add the call of the new method.
2514         (check_language): Move self initialization checking into the new method.
2515         (CppChecker): Add a new category for initialization list.
2516         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2517         (CppStyleTest.test_runtime_selfinit):
2518         (CppStyleTest.test_deprecated_cast):
2519         (WebKitStyleTest.test_member_initialization_list): Add new testcases for
2520         the new feature.
2521
2522 2013-12-04  Tamas Gergely  <gertom@inf.u-szeged.hu>
2523
2524         style-bot should reject Committer additions to committers.py
2525         https://bugs.webkit.org/show_bug.cgi?id=107574
2526
2527         Reviewed by Zoltan Herczeg.
2528
2529         The style check when executed in non-interactive mode (probably by a
2530         bot) will raise an additional error if the contributors.json file is
2531         modified. Non-interactive mode information is propagated to the
2532         Dispatcher, which creates a special JSON checker for the
2533         contributors.json file.
2534
2535         * Scripts/webkitpy/style/checker.py:
2536         (check_webkit_style_configuration):
2537         (CheckerDispatcher._create_checker):
2538         (CheckerDispatcher.dispatch):
2539         (StyleProcessorConfiguration.__init__):
2540         (StyleProcessor.process):
2541         * Scripts/webkitpy/style/checker_unittest.py:
2542         (CheckerDispatcherSkipTest._assert_should_skip_without_warning):
2543         (CheckerDispatcherDispatchTest.dispatch):
2544         (StyleProcessorConfigurationTest._style_checker_configuration):
2545         (StyleProcessor_EndToEndTest.test_init):
2546         (StyleProcessor_EndToEndTest.test_process):
2547         (StyleProcessor_CodeCoverageTest.MockDispatcher.dispatch):
2548         (StyleProcessor_CodeCoverageTest.setUp):
2549         * Scripts/webkitpy/style/checkers/jsonchecker.py:
2550         (JSONChecker.line_number_from_json_exception):
2551         (JSONContributorsChecker):
2552         (JSONContributorsChecker.check):
2553         * Scripts/webkitpy/style/error_handlers_unittest.py:
2554         (DefaultStyleErrorHandlerTest._style_checker_configuration):
2555         * Scripts/webkitpy/style/optparser.py:
2556         (CommandOptionValues.__init__):
2557         (ArgumentParser._create_option_parser):
2558         (ArgumentParser.parse):
2559         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2560         (test_post):
2561         (test_upload):
2562         * Scripts/webkitpy/tool/steps/checkstyle.py:
2563         (CheckStyle.run):
2564
2565 2013-12-04  Nick Diego Yamane  <nick.yamane@openbossa.org>
2566
2567         [EFL][WK2] Fix build after API::Client changes
2568         https://bugs.webkit.org/show_bug.cgi?id=125206
2569
2570         Reviewed by Csaba Osztrogonác.
2571
2572         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp:
2573         (TestWebKitAPI::TEST):
2574         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
2575         (TestWebKitAPI::setViewClient):
2576
2577 2013-12-03  Dan Bernstein  <mitz@apple.com>
2578
2579         Fixed a test timing out after r160040.
2580
2581         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
2582         (-[SimpleLoadFailDelegate browsingContextController:didFailProvisionalLoadWithError:]):
2583         Updated for the delegate method rename.
2584
2585 2013-12-03  Filip Pizlo  <fpizlo@apple.com>
2586
2587         REGRESSION: repro scripts disappear when you rerun tests
2588         https://bugs.webkit.org/show_bug.cgi?id=125184
2589
2590         Reviewed by Mark Hahnenberg.
2591         
2592         This bug made it difficult to quickly see if a test that recently failed is still
2593         failing while also running a new batch of tests.
2594
2595         Repro scripts are supposed to stay around until you delete them explicitly. This
2596         patch accomplishes that.
2597
2598         * Scripts/run-jsc-stress-tests:
2599
2600 2013-12-03  peavo@outlook.com  <peavo@outlook.com>
2601
2602         [Win] run-jsc-stress-tests has a great number of failures (2026/7606) on Windows
2603         https://bugs.webkit.org/show_bug.cgi?id=125111
2604
2605         Reviewed by Filip Pizlo.
2606
2607         Almost all errors seem to be caused by differences in line ending when diffing test output with expected output.
2608
2609         * Scripts/run-javascriptcore-tests: Enable api test and stress test for WinCairo.
2610         * Scripts/run-jsc-stress-tests: Ignore carriage return when diffing test output with expected output.
2611
2612 2013-12-03  Ryosuke Niwa  <rniwa@webkit.org>
2613
2614         Add a script to automatically configure a git clone
2615         https://bugs.webkit.org/show_bug.cgi?id=110073
2616
2617         Revert the change to use https for now since git.webkit.org is setup with http.
2618
2619         * Scripts/webkitpy/tool/commands/setupgitclone.py:
2620         (SetupGitClone.execute):
2621
2622 2013-12-03  Ryosuke Niwa  <rniwa@webkit.org>
2623
2624         Add a script to automatically configure a git clone
2625         https://bugs.webkit.org/show_bug.cgi?id=110073
2626
2627         Reviewed by Benjamin Poulain.
2628
2629         Added "webkit-patch setup-git-clone" to setup a brand new Git clone.
2630
2631         This command runs various commands listed on http://trac.webkit.org/wiki/UsingGitWithWebKit
2632
2633         * Scripts/webkitpy/tool/commands/__init__.py:
2634         * Scripts/webkitpy/tool/commands/setupgitclone.py: Added.
2635         (SetupGitClone):
2636         (SetupGitClone.execute):
2637
2638 2013-12-03  Anders Carlsson  <andersca@apple.com>
2639
2640         Deprecate WKNotificationProvider
2641         https://bugs.webkit.org/show_bug.cgi?id=125178
2642
2643         Reviewed by Sam Weinig.
2644
2645         Update for WebKit2 changes.
2646
2647         * WebKitTestRunner/TestController.cpp:
2648         (WTR::TestController::initialize):
2649         * WebKitTestRunner/WebNotificationProvider.cpp:
2650         (WTR::WebNotificationProvider::provider):
2651         * WebKitTestRunner/WebNotificationProvider.h:
2652
2653 2013-12-03  Brent Fulgham  <bfulgham@apple.com>
2654
2655         [Win] Support 64-bit Application Support Libraries Location 
2656         https://bugs.webkit.org/show_bug.cgi?id=125179
2657
2658         Reviewed by Tim Horton.
2659
2660         Enable the user to specify a location for 64-bit support libraries (such as libxml2, ICU, etc.)
2661         on Windows until an official distribution is available that properly creates registry settings
2662         to specify these locations.
2663
2664         * Scripts/webkitdirs.pm:
2665         (setupAppleWinEnv): Notify user to set WEBKIT_64_SUPPORT environment variable if needed.
2666         (setupCygwinEnv): Report WEWBKIT_64_SUPPORT path when running 64-bit builds.
2667         (appleApplicationSupportPath): Add WEBKIT_64_SUPPORT location to runtime environment when
2668         running 64-bit builds.
2669
2670 2013-12-03  Mark Hahnenberg  <mhahnenberg@apple.com>
2671
2672         run-jsc-stress-tests only supports host environments that have make installed
2673         https://bugs.webkit.org/show_bug.cgi?id=124550
2674
2675         Reviewed by Darin Adler.
2676
2677         This might not be the case for all hosts, so this patch implements an alternate "backend" 
2678         for run-jsc-stress-tests to use normal shell commands rather than Makefiles. To remain at 
2679         least somewhat competitive with the make-based test runner, the shell backend uses subshells
2680         run in the background to allow tests to run in parallel. Since the concurrency primitives 
2681         in shell scripting are rather coarse, the overhead of this parallelism is higher than that 
2682         of the make-based runner.
2683
2684         * Scripts/jsc-stress-test-helpers/shell-runner.sh: Added. This is the runner that is copied into
2685         the bundle and controls all of the parallel aspects of the shell-based test runner.
2686         * Scripts/run-jsc-stress-tests:
2687
2688 2013-12-03  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
2689
2690         Remove function from TextChecker
2691         https://bugs.webkit.org/show_bug.cgi?id=125148
2692
2693         Reviewed by Darin Adler.
2694
2695         The process_file_data is used only from the unit tests, so it is simply moved there.
2696
2697         * Scripts/webkitpy/style/checkers/text.py:
2698         (TextChecker.check):
2699         * Scripts/webkitpy/style/checkers/text_unittest.py:
2700         (TextStyleTestCase.process_file_data):
2701         (TextStyleTestCase.assertNoError):
2702         (TextStyleTestCase.assertError):
2703
2704 2013-12-03  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
2705
2706         Remove get_test() and reference test names directly instead.
2707         https://bugs.webkit.org/show_bug.cgi?id=124962
2708
2709         Reviewed by Csaba Osztrogonác.
2710
2711         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2712         (Base.__init__):
2713         (Base.get_basic_tests):
2714         (assert_exp):
2715         (MiscTests.test_multiple_results):
2716         (MiscTests.test_category_expectations):
2717         (MiscTests.test_get_modifiers):
2718         (MiscTests.test_get_expectations_string):
2719         (MiscTests.test_get_test_set):
2720         (MiscTests.test_parse_warning):
2721         (MiscTests.test_pixel_tests_flag.match):
2722
2723 2013-12-03  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
2724
2725         Style Checker false pass.
2726         https://bugs.webkit.org/show_bug.cgi?id=112456
2727
2728         Reviewed by Csaba Osztrogonác.
2729
2730         * Scripts/webkitpy/style/checkers/changelog.py:
2731         (ChangeLogChecker.check_entry):
2732         simple regex fix to check "No new tests (...)."
2733         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
2734         (ChangeLogCheckerTest.test_no_new_tests):
2735
2736 2013-12-02  Filip Pizlo  <fpizlo@apple.com>
2737
2738         run-jsc-stress-tests should allow for tests that have a directory containing .js files nested within a directory containing the data
2739         https://bugs.webkit.org/show_bug.cgi?id=125130
2740
2741         Reviewed by Geoffrey Garen.
2742
2743         * Scripts/run-jsc-stress-tests:
2744
2745 2013-12-02  Samuel White  <samuel_white@apple.com>
2746
2747         AX: Add AXUIElementCountForSearchPredicate parameterized attribute.
2748         https://bugs.webkit.org/show_bug.cgi?id=124561
2749
2750         Reviewed by Chris Fleizach.
2751
2752         Added function to verify that NSAccessibilityUIElementCountForSearchPredicateParameterizedAttribute works as it should.
2753
2754         * DumpRenderTree/AccessibilityUIElement.cpp:
2755         (uiElementCountForSearchPredicateCallback):
2756         (uiElementForSearchPredicateCallback):
2757         (AccessibilityUIElement::getJSClass):
2758         * DumpRenderTree/AccessibilityUIElement.h:
2759         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2760         (AccessibilityUIElement::uiElementCountForSearchPredicate):
2761         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2762         (AccessibilityUIElement::uiElementCountForSearchPredicate):
2763         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2764         (searchPredicateParameterizedAttributeForSearchCriteria):
2765         (AccessibilityUIElement::uiElementCountForSearchPredicate):
2766         (AccessibilityUIElement::uiElementForSearchPredicate):
2767         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2768         (AccessibilityUIElement::uiElementCountForSearchPredicate):
2769         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2770         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
2771         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2772         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2773         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2774         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
2775         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2776         (WTR::searchPredicateParameterizedAttributeForSearchCriteria):
2777         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
2778         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
2779
2780 2013-12-02  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
2781
2782         Instead of a large 'if' block, each failure class should write it's own result in test_result_writer.py
2783         https://bugs.webkit.org/show_bug.cgi?id=124714
2784
2785         Reviewed by Ryosuke Niwa.
2786
2787         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2788         (write_test_result):
2789         * Scripts/webkitpy/layout_tests/models/test_failures.py:
2790         (TestFailure.write_failure):
2791         (FailureText):
2792         (FailureText.write_failure):
2793         (FailureAudio):
2794         (FailureAudio.write_failure):
2795         (FailureCrash.write_failure):
2796         (FailureMissingResult):
2797         (FailureTextMismatch):
2798         (FailureMissingImageHash.write_failure):
2799         (FailureMissingImage.write_failure):
2800         (FailureImageHashMismatch.write_failure):
2801         (FailureReftestMismatch.write_failure):
2802         (FailureReftestMismatchDidNotOccur.write_failure):
2803         (FailureMissingAudio):
2804         (FailureAudioMismatch):
2805
2806 2013-12-02  László Langó  <lango@inf.u-szeged.hu>
2807
2808         Remove the stderr_write attribute from StyleProcessorConfiguration
2809         https://bugs.webkit.org/show_bug.cgi?id=124703
2810
2811         Reviewed by Ryosuke Niwa.
2812
2813         Remove the stderr_write attribute from this class in checker and
2814         replace its use with calls to a logging module logger. We Should 
2815         use logging module instead of writing to stderr directly.
2816
2817         * Scripts/webkitpy/style/checker.py: Change stderr_write attribute to logging module logger.
2818         (check_webkit_style_configuration):
2819         (CheckerDispatcher.dispatch): Remove FIXME comment.
2820         (StyleProcessorConfiguration):
2821         (StyleProcessorConfiguration.__init__):
2822         (StyleProcessorConfiguration.write_style_error):
2823         * Scripts/webkitpy/style/checker_unittest.py: Update test to the modification.
2824         There is an "ERROR" prefix in log messiges from now.
2825         (StyleProcessorConfigurationTest):
2826         (StyleProcessorConfigurationTest._style_checker_configuration):
2827         (StyleProcessorConfigurationTest.test_init):
2828         (StyleProcessorConfigurationTest.test_write_style_error_emacs):
2829         (StyleProcessorConfigurationTest.test_write_style_error_vs7):
2830         (StyleProcessor_EndToEndTest.with):
2831         (StyleProcessor_EndToEndTest.test_init):
2832         (StyleProcessor_EndToEndTest.test_process):
2833         (StyleProcessor_CodeCoverageTest.setUp):
2834         * Scripts/webkitpy/style/error_handlers.py: Remove stderr_write usage and replace with logging module logger.
2835         (DefaultStyleErrorHandler.__call__):
2836         * Scripts/webkitpy/style/error_handlers_unittest.py: Update test to the modification.
2837         There is an "ERROR" prefix in log messiges from now.
2838         (DefaultStyleErrorHandlerTest):
2839         (DefaultStyleErrorHandlerTest.setUp):
2840         (DefaultStyleErrorHandlerTest._mock_increment_error_count):
2841         (DefaultStyleErrorHandlerTest._style_checker_configuration):
2842         (DefaultStyleErrorHandlerTest._check_initialized):
2843         (DefaultStyleErrorHandlerTest.test_non_reportable_error):
2844         (DefaultStyleErrorHandlerTest.test_max_reports_per_category):
2845         (DefaultStyleErrorHandlerTest.test_line_numbers):
2846
2847 2013-12-02  Brian J. Burg  <burg@cs.washington.edu>
2848
2849         Add JavaScript style checker and teach checker.py about .js files
2850         https://bugs.webkit.org/show_bug.cgi?id=125049
2851
2852         Reviewed by Joseph Pecoraro.
2853
2854         Add a JavaScript file type, extension, and checker (JSChecker).
2855         Use TextChecker for JavaScript tests, libraries, website resources,
2856         etc. and use JSChecker for files within WebInspectorUI/UserInterface.
2857
2858         Amended tests for TextChecker to reflect the rule above.
2859
2860         * Scripts/webkitpy/style/checker.py:
2861         (_all_categories): Add categories defined by JSChecker.
2862         (FileType): Add file type for JS and re-number the enum.
2863         (CheckerDispatcher._file_type): Detect .js files as JavaScript.
2864         (CheckerDispatcher._create_checker):
2865         Create a JSChecker or TextChecker depending on the file's path.
2866
2867         * Scripts/webkitpy/style/checker_unittest.py:
2868         (CheckerDispatcherDispatchTest.assert_checker_js): Added.
2869         (CheckerDispatcherDispatchTest.test_js_paths): Added.
2870         (CheckerDispatcherDispatchTest.test_text_paths): Add new test paths
2871         that end in .js but should be checked with TextChecker.
2872         * Scripts/webkitpy/style/checkers/js.py: Added.
2873         (JSChecker):
2874         (JSChecker.__init__):
2875         (JSChecker.check):
2876         * Scripts/webkitpy/style/checkers/js_unittest.py: Added.
2877         (JSTestCase):
2878         (JSTestCase.assertNoError):
2879         (JSTestCase.assertNoError.error_for_test):
2880         (JSTestCase.assertError):
2881         (JSTestCase.assertError.error_for_test):
2882         (JSTestCase.test_no_error):
2883         (JSTestCase.test_error):
2884
2885 2013-12-02  Mark Hahnenberg  <mhahnenberg@apple.com>
2886
2887         run-jsc-stress-tests always copies the VM
2888         https://bugs.webkit.org/show_bug.cgi?id=125092
2889
2890         Reviewed by Filip Pizlo.
2891
2892         This can be slow, especially with full debug builds. It should just symlink the VM into the 
2893         bundle by default and do a full copy only when asked.
2894
2895         * Scripts/run-jsc-stress-tests:
2896
2897 2013-12-02  Brent Fulgham  <bfulgham@apple.com>
2898
2899         [Win] Port run-jsc-stress-tests
2900         https://bugs.webkit.org/show_bug.cgi?id=124801
2901
2902         Reviewed by Filip Pizlo.
2903
2904         * Scripts/run-jsc-stress-tests: Gracefully handle lack of sysctl
2905         command on Windows so that stress tests can run.
2906
2907 2013-12-02  Mark Hahnenberg  <mhahnenberg@apple.com>
2908
2909         Build fix after r159955
2910
2911         * Scripts/run-jsc-stress-tests:
2912
2913 2013-12-02  Mark Hahnenberg  <mhahnenberg@apple.com>
2914
2915         run-jsc-stress-tests should be able to package its tests and move them places
2916         https://bugs.webkit.org/show_bug.cgi?id=124549
2917
2918         Reviewed by Filip Pizlo.
2919
2920         * Scripts/jsc-stress-test-helpers/check-mozilla-failure: Removed. Was just a ruby reimplementation
2921         of grep -i -q
2922         * Scripts/run-javascriptcore-tests: Pass through the --tarball flag.
2923         * Scripts/run-jsc-stress-tests: Changed to create a bundle of tests inside the results directory.
2924         We now also copy whatever VM was specified, along with its associated framework, into this directory.
2925         All of the generated scripts now are completely relative within the results directory. This allows
2926         run-jsc-stress-tests to execute a bundle from anywhere. Also added a --tarball flag which creates a
2927         tarball of the generated results directory. Also refactored several portions of the script into
2928         separate functions to make it easier to run them conditionally depending on which mode we're running in. 
2929
2930 2013-12-02  Andrzej Badowski  <a.badowski@samsung.com>
2931
2932         [ATK] Support active state for listbox elements.
2933         https://bugs.webkit.org/show_bug.cgi?id=125009
2934
2935         Reviewed by Chris Fleizach.
2936
2937         Supplement WebKitTestRunner and DumpRenderTree to support isSelectedOptionActive.
2938
2939         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2940         (AccessibilityUIElement::isSelectedOptionActive):
2941         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2942         (WTR::AccessibilityUIElement::isSelectedOptionActive):
2943         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2944         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2945         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2946         (WTR::AccessibilityUIElement::isSelectedOptionActive):
2947         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2948         (WTR::AccessibilityUIElement::isSelectedOptionActive):
2949
2950 2013-12-02  Zan Dobersek  <zdobersek@igalia.com>
2951
2952         Unreviewed GTK gardening.
2953
2954         * Scripts/run-gtk-tests:
2955         (TestRunner): Skip two unit tests that are causing the subsequent test to crash.
2956
2957 2013-12-01  Dan Bernstein  <mitz@apple.com>
2958
2959         [Mac] Transition MiniBrowser to the Cocoa API: policy delegate   
2960         https://bugs.webkit.org/show_bug.cgi?id=125046
2961
2962         Reviewed by Sam Weinig.
2963
2964         * MiniBrowser/mac/AppDelegate.m:
2965         (-[BrowserAppDelegate newWindow:]): Added WK_API_ENABLED guards.
2966         (-[BrowserAppDelegate openDocument:]): Ditto.
2967         * MiniBrowser/mac/WK2BrowserWindowController.h: Ditto. Also moved ivar declarations from the
2968         interface to the implementation.
2969         * MiniBrowser/mac/WK2BrowserWindowController.m:
2970         (-[WK2BrowserWindowController awakeFromNib]): Changed to set the policy delegate instead of
2971         the policy client.
2972         (-[WK2BrowserWindowController browsingContextController:decidePolicyForNavigationAction:decisionHandler:]):
2973         Moved policy client implementation into this delegate method.
2974         (-[WK2BrowserWindowController browsingContextController:decidePolicyForNewWindowAction:decisionHandler:]):
2975         Ditto.
2976         (-[WK2BrowserWindowController browsingContextController:decidePolicyForResponseAction:decisionHandler:]):
2977         Ditto.
2978
2979 2013-12-01  Dan Bernstein  <mitz@apple.com>
2980
2981         [Mac] Remove the MiniBrowser injected bundle
2982         https://bugs.webkit.org/show_bug.cgi?id=125041
2983
2984         Reviewed by Anders Carlsson.
2985
2986         It had no ops!
2987
2988         * MiniBrowser/Configurations/WebBundle.xcconfig: Removed.
2989         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2990         * MiniBrowser/mac/AppDelegate.m:
2991         (-[BrowserAppDelegate init]):
2992         * MiniBrowser/mac/WebBundle/Info.plist: Removed.
2993         * MiniBrowser/mac/WebBundle/WebBundleMain.m: Removed.
2994
2995 2013-11-29  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
2996
2997         check-webkit-style should check for extraneous newline between config.h and primary header.
2998         https://bugs.webkit.org/show_bug.cgi?id=124821
2999
3000         Reviewed by Csaba Osztrogonác.
3001
3002         * Scripts/webkitpy/style/checkers/cpp.py:
3003         (check_include_line):
3004         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3005         (OrderOfIncludesTest.test_check_line_break_after_own_header):
3006         (OrderOfIncludesTest):
3007         (OrderOfIncludesTest.test_check_line_break_before_own_header):
3008
3009 2013-11-29  Jozsef Berta  <jberta@inf.u-szeged.hu>
3010
3011         test-webkit-scripts should show the failing tests and use an appropriate exit code
3012         https://bugs.webkit.org/show_bug.cgi?id=124840
3013
3014         Reviewed by Ryosuke Niwa.
3015
3016         A fixme in test-webkit-scripts asked that the script should display success or failiure
3017         and exit with a 0 or 1 value accordingly after all of the tests have completed.
3018
3019         * Scripts/test-webkit-scripts:
3020         (ScriptsTester.run_test_script):
3021         The outcome of the currently run script is returned to the main as a boolean value. A boolean is returned,
3022         because at this point we don't need to pass on more information other than success or failiure.
3023         (ScriptsTester.main):
3024         The return values are now stored for each script and when all tests have completed successfully,
3025         the script indicates success and returns 0. Otherwise it will display the name(s) of the failing script(s) and return 1.
3026
3027 2013-11-29  Krzysztof Czech  <k.czech@samsung.com>
3028
3029         [ATK] Added support for isAttributeSettable in AccessibilityUIElementAtk
3030         https://bugs.webkit.org/show_bug.cgi?id=124923
3031
3032         Reviewed by Mario Sanchez Prada.
3033
3034         Added missing implementation of isAttributeSettable. Using
3035         ATK_STATE_EDITABLE for checking whether attribute is settable.
3036
3037         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3038         (AccessibilityUIElement::isAttributeSettable):
3039         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3040         (WTR::AccessibilityUIElement::isAttributeSettable):
3041
3042 2013-11-28  Commit Queue  <commit-queue@webkit.org>
3043
3044         Unreviewed, rolling out r159839.
3045         http://trac.webkit.org/changeset/159839
3046         https://bugs.webkit.org/show_bug.cgi?id=124974
3047
3048         run-webkit-tests doesn't generate pretty diff (Requested by
3049         Ossy on #webkit).
3050
3051         * Scripts/webkitpy/common/prettypatch.py:
3052         (PrettyPatch.__init__):
3053         (PrettyPatch.pretty_diff):
3054         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3055         (TestResultWriter.create_text_diff_and_write_result):
3056         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
3057         (summarize_results):
3058         * Scripts/webkitpy/port/base.py:
3059         (Port.__init__):
3060         (Port.pretty_patch_available):
3061         (Port.check_pretty_patch):
3062         (Port.variable):
3063         (Port.variable.pretty_patch_text):
3064         * Scripts/webkitpy/port/base_unittest.py:
3065         (PortTest.test_pretty_patch_os_error):
3066         (PortTest.test_pretty_patch_script_error):
3067
3068 2013-11-28  Antti Koivisto  <antti@apple.com>
3069
3070         Remove feature: CSS variables
3071         https://bugs.webkit.org/show_bug.cgi?id=114119
3072
3073         Reviewed by Andreas Kling.
3074
3075         * Scripts/webkitperl/FeatureList.pm:
3076
3077 2013-11-28  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
3078
3079         Move PrettyPatch related code to prettypatch.py
3080         https://bugs.webkit.org/show_bug.cgi?id=124937
3081
3082         Reviewed by Ryosuke Niwa.
3083
3084         This code seems to have a better place here than in Port, since PrettyPatch already knows
3085         pretty_patch_path, and this also unifies the usage of PrettyPatch
3086
3087         * Scripts/webkitpy/common/prettypatch.py:
3088         (PrettyPatch.__init__):
3089         (PrettyPatch.pretty_diff):
3090         (PrettyPatch):
3091         (PrettyPatch.pretty_patch_available):
3092         (PrettyPatch.check_pretty_patch):
3093         (PrettyPatch.pretty_patch_text):
3094         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3095         (TestResultWriter.create_text_diff_and_write_result):
3096         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
3097         (summarize_results):
3098         * Scripts/webkitpy/port/base.py:
3099         (Port.__init__):
3100         (Port.wdiff_available):
3101         (Port.check_image_diff):
3102         (Port.wdiff_text):
3103         * Scripts/webkitpy/port/base_unittest.py:
3104         (PortTest.test_pretty_patch_os_error):
3105         (PortTest.test_pretty_patch_script_error):
3106
3107 2013-11-28  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
3108
3109         Checkout should own the scm object in Host
3110         https://bugs.webkit.org/show_bug.cgi?id=124943
3111
3112         Reviewed by Ryosuke Niwa.
3113
3114         * Scripts/webkitpy/common/host.py:
3115         (Host.__init__):
3116         (Host.initialize_scm):
3117         (Host.scm):
3118
3119 2013-11-26  Filip Pizlo  <fpizlo@apple.com>
3120
3121         Do bytecode validation as part of testing
3122         https://bugs.webkit.org/show_bug.cgi?id=124913
3123
3124         Reviewed by Oliver Hunt.
3125
3126         * Scripts/run-jsc-stress-tests:
3127
3128 2013-11-27  Andres Gomez  <agomez@igalia.com>
3129
3130         [GTK] Tools/Scripts/update-webkitgtk-libs fails due to missing fontutils dependencies for building the "xserver" module
3131         https://bugs.webkit.org/show_bug.cgi?id=124940
3132
3133         Reviewed by Martin Robinson.
3134
3135         xserver-font-utils is needed for building gtk port dependencies
3136         with jhbuild.
3137
3138         * gtk/install-dependencies: Added xserver-font-utils to jhbuild
3139         dependecies.
3140
3141 2013-11-27  Andres Gomez  <agomez@igalia.com>
3142
3143         [GTK] Tools/Scripts/update-webkitgtk-libs unsorted and fails because of missing "git"
3144         https://bugs.webkit.org/show_bug.cgi?id=124938
3145
3146         Reviewed by Philippe Normand.
3147
3148         Added needed git dependency for building the gtk port with
3149         jhbuild. Also, the dependencies needed for building the gtk port
3150         are now sorted alphabetically.
3151
3152         * gtk/install-dependencies: Added git as jhbuild dependency and
3153         sorted dependencies alphabetically.
3154
3155 2013-11-27  Jozsef Berta  <jberta@inf.u-szeged.hu>
3156
3157         run_webkit_tests.py: error: no such option: --wincairo
3158         https://bugs.webkit.org/show_bug.cgi?id=124927
3159
3160         Reviewed by Ryosuke Niwa.
3161
3162         * BuildSlaveSupport/build.webkit.org-config/config.json: The run_webkit_tests.py doesn't supports
3163         the layout testing on wincairo, so it is turned off.
3164
3165 2013-11-26  Marcelo Lira  <marcelo.lira@openbossa.org>
3166
3167         Nix upstreaming - Adding build files and supporting scripts
3168         https://bugs.webkit.org/show_bug.cgi?id=118367
3169
3170         Reviewed by Ryosuke Niwa.
3171
3172         * Scripts/build-webkit:
3173         * Scripts/run-nix-tests: Added.
3174         * Scripts/run-webkit-tests:
3175         * Scripts/update-webkit-libs-jhbuild:
3176         * Scripts/update-webkitnix-libs: Added.
3177         * Scripts/webkitdirs.pm:
3178         (determineArchitecture):
3179         (argumentsForConfiguration):
3180         (jscProductDir):
3181         (builtDylibPathForName):
3182         (determineIsNix):
3183         (isNix):
3184         (isAppleWebKit):
3185         (launcherPath):
3186         (launcherName):
3187         (checkRequiredSystemConfig):
3188         (copyInspectorFrontendFiles):
3189         (jhbuildWrapperPrefixIfNeeded):
3190         (buildCMakeProjectOrExit):
3191         (cmakeBasedPortName):
3192         * Scripts/webkitpy/common/config/ports.py:
3193         (DeprecatedPort.port):
3194         (EflWK2Port.build_webkit_command):
3195         (NixPort):
3196         (NixPort.build_webkit_command):
3197         * Scripts/webkitpy/port/factory.py:
3198         (platform_options):
3199         (PortFactory):
3200         * Scripts/webkitpy/port/nix.py: Added.
3201         (NixPort):
3202         (NixPort._wk2_port_name):
3203         (NixPort.determine_full_port_name):
3204         (NixPort.__init__):
3205         (NixPort._port_flag_for_scripts):
3206         (NixPort.setup_test_run):
3207         (NixPort.setup_environ_for_server):
3208         (NixPort.default_timeout_ms):
3209         (NixPort.clean_up_test_run):
3210         (NixPort._generate_all_test_configurations):
3211         (NixPort._path_to_driver):
3212         (NixPort._path_to_image_diff):
3213         (NixPort._image_diff_command):
3214         (NixPort._search_paths):
3215         (NixPort.show_results_html_file):
3216         (NixPort._port_specific_expectations_files):
3217         (NixPort.default_baseline_search_path):
3218         * Scripts/webkitpy/port/nix_unittest.py: Added.
3219         (NixPortTest):
3220         (NixPortTest._assert_search_path):
3221         (NixPortTest._assert_expectations_files):
3222         (NixPortTest.test_baseline_search_path):
3223         (NixPortTest.test_expectations_files):
3224         (NixPortTest.test_default_timeout_ms):
3225         * jhbuild/jhbuild-wrapper:
3226         (determine_platform):
3227         * nix/common.py: Added.
3228         (script_path):
3229         (top_level_path):
3230         * nix/jhbuild.modules: Added.
3231         * nix/jhbuildrc: Added.
3232
3233 2013-11-26  Ryosuke Niwa  <rniwa@webkit.org>
3234
3235         Record subtest values in Dromaeo tests
3236         https://bugs.webkit.org/show_bug.cgi?id=124498
3237
3238         Reviewed by Andreas Kling.
3239
3240         Supported parsing subtest results.
3241
3242         * Scripts/webkitpy/performance_tests/perftest.py: Replaced _metrics with an ordered list of subtests, each of
3243         which contains a dictionary with its name and an ordered list of subtest's metrics.
3244         (PerfTest.__init__): Initialize _metrics as a list.
3245         (PerfTest.run): Go through each subtest and its metrics to create a list of TestMetrics.
3246         (PerfTest._run_with_driver):
3247         (PerfTest._ensure_metrics): Look for a subtest then a metric in _metrics.
3248
3249         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
3250         (TestPerfTest._assert_results_are_correct): Updated the assertions per changes to _metrics.
3251         (TestPerfTest.test_parse_output): Ditto.
3252         (TestPerfTest.test_parse_output_with_subtests): Added the metric and the unit on each subtest result as well as
3253         assertions to ensure subtest results are parsed properly.
3254         (TestReplayPerfTest.test_run_with_driver_accumulates_results): Updated the assertions per changes to _metrics.
3255         (TestReplayPerfTest.test_run_with_driver_accumulates_memory_results): Dittp.
3256
3257         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3258         (_generate_results_dict): When the metric for a subtest is processed before that of the main test, the url is
3259         incorrectly suffixed with '/'. Fix this later by re-computing the url with TestPerfMetric.test_file_name when
3260         adding new results.
3261
3262         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
3263         (TestWithSubtestsData): Added.
3264         (TestDriver.run_test):
3265         (MainTest.test_run_test_with_subtests): Added.
3266
3267 2013-11-26  Ryosuke Niwa  <rniwa@webkit.org>
3268
3269         Enable HTML template element on Windows ports
3270         https://bugs.webkit.org/show_bug.cgi?id=124758
3271
3272         Reviewed by Andreas Kling.
3273
3274         * Scripts/webkitperl/FeatureList.pm:
3275
3276 2013-11-26  Ryosuke Niwa  <rniwa@webkit.org>
3277
3278         Remove replay performance tests as it's not actively maintained
3279         https://bugs.webkit.org/show_bug.cgi?id=124764
3280
3281         Reviewed by Andreas Kling.
3282
3283         Removed the feature.
3284
3285         * Scripts/webkitpy/performance_tests/perftest.py:
3286         (SingleProcessPerfTest.__init__):
3287         (PerfTestFactory):
3288         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
3289         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3290         (PerfTestsRunner._parse_args):
3291         (PerfTestsRunner._collect_tests):
3292         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3293         (MainTest.test_collect_tests_with_ignored_skipped_list):
3294         (MainTest.test_default_args):
3295         * Scripts/webkitpy/thirdparty/__init__.py:
3296         (AutoinstallImportHook.find_module):
3297         (AutoinstallImportHook._install_unittest2):
3298         * Scripts/webkitpy/thirdparty/__init___unittest.py:
3299         (ThirdpartyTest.test_imports):
3300
3301 2013-11-26  Filip Pizlo  <fpizlo@apple.com>
3302
3303         Enable aggressive DFG validation in testing
3304         https://bugs.webkit.org/show_bug.cgi?id=124911
3305
3306         Rubber stamped by Ryosuke Niwa.
3307         
3308         This enables validation testing in non-concurrent-JIT runs.
3309
3310         * Scripts/run-jsc-stress-tests:
3311
3312 2013-11-26  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
3313
3314         Moved methods which belong to Checkout into checkout.py
3315         https://bugs.webkit.org/show_bug.cgi?id=124889
3316
3317         Reviewed by Ryosuke Niwa.
3318
3319         * Scripts/webkitpy/common/checkout/checkout.py:
3320         (Checkout.scripts_directory):
3321         (Checkout):
3322         (Checkout.script_path):
3323         (Checkout.commit_message_for_this_commit):
3324         (Checkout.apply_patch):
3325         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3326         (test_commit_message_for_this_commit):
3327         (CheckoutTest.test_apply_patch):
3328         * Scripts/webkitpy/common/checkout/scm/scm.py:
3329         (SCM.absolute_path):
3330         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3331         (SCMTest._setup_webkittools_scripts_symlink):
3332         * Scripts/webkitpy/common/checkout/scm/svn.py:
3333         (SVN.create_patch):
3334
3335 2013-11-25  Ryuan Choi  <ryuan.choi@samsung.com>
3336
3337         [EFL] Use Config mode of find_package for EFL 1.8
3338         https://bugs.webkit.org/show_bug.cgi?id=124555
3339
3340         Reviewed by Gyuyoung Kim.
3341
3342         * MiniBrowser/efl/CMakeLists.txt:
3343         Added optional config mode and made version requirement optional.
3344
3345 2013-11-25  Andres Gomez  <agomez@igalia.com>
3346
3347         [GTK] Search functionality in MiniBrowser provides feedback on search fail
3348         https://bugs.webkit.org/show_bug.cgi?id=122681
3349
3350         Reviewed by Mario Sanchez Prada.
3351
3352         When using the search functionality in MiniBrowser, if the search
3353         fails, the entry background color gets red to report the user
3354         about the failing condition. When the entry is cleaned or the
3355         search is again succesful the background turns back to its
3356         original color.
3357
3358         * MiniBrowser/gtk/BrowserSearchBar.c:
3359         (setFailedStyleForEntry): Added.
3360         (doSearch): Sets the entry's background to its original style if
3361         there is no text to search.
3362         (findControllerFailedToFindTextCallback): Added.
3363         (findControllerFoundTextCallback): Added.
3364         (browser_search_bar_init): Creates and adds a new CSS provider to
3365         the text entry so we can change its style based on the success
3366         condition of the search.
3367         (browserSearchBarFinalize): Frees the new CSS provider.
3368         (browser_search_bar_new): Connects the two new handlers to the
3369         "failed-to-find-text" and "found-text" signals emitted by the
3370         WebKitFindController.
3371
3372 2013-11-25  Dan Bernstein  <mitz@apple.com>
3373
3374         [Cocoa] Put most of the Cocoa API behind WK_API_ENABLED guards
3375         https://bugs.webkit.org/show_bug.cgi?id=124850
3376
3377         Reviewed by Brady Eidson.
3378
3379         Added #if WK_API_ENABLED guards around tests that use the Objective-C API.
3380
3381         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
3382         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
3383         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
3384         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
3385         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
3386         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:
3387         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
3388
3389 2013-11-25  Commit Queue  <commit-queue@webkit.org>
3390
3391         Unreviewed, rolling out r159752 and r159754.
3392         http://trac.webkit.org/changeset/159752
3393         http://trac.webkit.org/changeset/159754
3394         https://bugs.webkit.org/show_bug.cgi?id=124847
3395
3396         Broke linux test bots. (Requested by mhahnenberg on #webkit).
3397
3398         * Scripts/jsc-stress-test-helpers/check-mozilla-failure: Added.
3399         * Scripts/run-javascriptcore-tests:
3400         * Scripts/run-jsc-stress-tests:
3401
3402 2013-11-25  Mark Hahnenberg  <mhahnenberg@apple.com>
3403
3404         Followup fix after r159752
3405
3406         * Scripts/run-jsc-stress-tests: We need to handle Release builds too.
3407
3408 2013-11-25  Mark Hahnenberg  <mhahnenberg@apple.com>
3409
3410         run-jsc-stress-tests should be able to package its tests and move them places
3411         https://bugs.webkit.org/show_bug.cgi?id=124549
3412
3413         Reviewed by Filip Pizlo.
3414
3415         * Scripts/jsc-stress-test-helpers/check-mozilla-failure: Removed. Was just a ruby reimplementation 
3416         of grep -i -q
3417         * Scripts/run-javascriptcore-tests: Pass through the --tarball flag.
3418         * Scripts/run-jsc-stress-tests: Changed to create a bundle of tests inside the results directory. 
3419         We now also copy whatever VM was specified, along with its associated framework, into this directory. 
3420         All of the generated scripts now are completely relative within the results directory. This allows 
3421         run-jsc-stress-tests to execute a bundle from anywhere. Also added a --tarball flag which creates a 
3422         tarball of the generated results directory. Also refactored several portions of the script into 
3423         separate functions to make it easier to run them conditionally depending on which mode we're running in.
3424
3425 2013-11-25  László Langó  <lango@inf.u-szeged.hu>
3426
3427         EWS creates 0 byte sized log files
3428         https://bugs.webkit.org/show_bug.cgi?id=107606
3429
3430         Reviewed by Ryosuke Niwa.
3431
3432         There was a modification in r138264, that tried to make less log,
3433         because some of the messeges were duplicated. After this the EWS
3434         created the log file (with the same name as the bugID) but doesn't
3435         write anything into it, even if there were errors during the build.
3436         From now only creates the log file only if there is some error.
3437
3438         * Scripts/webkitpy/tool/bot/queueengine.py:
3439         (QueueEngine.run): If the build and tests pass, there is no ScriptError raised,
3440         there is nothing to log. Open the log file only if a ScriptError was raised to
3441         avoid to make empty log files for bugs.
3442         (QueueEngine._open_work_log): Does not need to tee STDOUT to log file anymore,
3443         because of changes in r138264. Teeing is used for locally testing purposes and
3444         this feature is not used anymore.
3445         (QueueEngine._ensure_work_log_closed): Close the logfile. We don't use output
3446         teeing anymore. It is a necessary change because of QueueEngine._open_work_log
3447         change.
3448         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
3449         (LoggingDelegate): The order of the callbacks was changed by this patch.
3450         (QueueEngineTest.test_trivial): Won't create log file if the queue was terminated,
3451         so we have to update this test.
3452         (QueueEngineTest.test_unexpected_error): The order of the callbacks was changed by
3453         this patch.
3454         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3455         (AbstractEarlyWarningSystem.review_patch): Raise again the captured ScriptError
3456         to be able to handle it in QueueEngine.run. Without this change, the existing
3457         exception handler never run (the process_work_item method never raise ScriptError)
3458         We can get the error message only from the ScriptError at this point.
3459
3460 2013-11-22  Dean Jackson  <dino@apple.com>
3461
3462         Speculative Mountain Lion build fix.
3463
3464         * MiniBrowser/mac/AppDelegate.m:
3465         (-[BrowserAppDelegate openDocument:]):
3466
3467 2013-11-22  Anders Carlsson  <andersca@apple.com>
3468
3469         Fix Mountain Lion bug.
3470
3471         * MiniBrowser/mac/AppDelegate.m:
3472         (-[BrowserAppDelegate openDocument:]):
3473
3474 2013-11-22  Anders Carlsson  <andersca@apple.com>
3475
3476         MiniBrowser should use the blocks-based NSOpenPanel API
3477         https://bugs.webkit.org/show_bug.cgi?id=124786
3478
3479         Reviewed by Simon Fraser.
3480
3481         * MiniBrowser/mac/AppDelegate.m:
3482         (-[BrowserAppDelegate frontmostBrowserWindowController]):
3483         Account for windows that don't have a BrowserWindowController.
3484
3485         (-[BrowserAppDelegate openDocument:]):
3486
3487 2013-11-22  Commit Queue  <commit-queue@webkit.org>
3488
3489         Unreviewed, rolling out r159690.
3490         http://trac.webkit.org/changeset/159690
3491         https://bugs.webkit.org/show_bug.cgi?id=124782
3492
3493         Broke webkitpy tests (Requested by ap on #webkit).
3494
3495         * Scripts/webkitpy/tool/bot/queueengine.py:
3496         (QueueEngine.run):
3497         (QueueEngine._open_work_log):
3498         (QueueEngine._ensure_work_log_closed):
3499         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3500         (AbstractEarlyWarningSystem.review_patch):
3501
3502 2013-11-22  László Langó  <lango@inf.u-szeged.hu>
3503
3504         EWS creates 0 byte sized log files
3505         https://bugs.webkit.org/show_bug.cgi?id=107606
3506
3507         Reviewed by Ryosuke Niwa.
3508
3509         There was a modification in r138264, that tried to make less log, 
3510         because some of the messeges were duplicated. After this the EWS 
3511         created the log file (with the same name as the bugID) but doesn't 
3512         write anything into it, even if there were errors during the build. 
3513         From now only creates the log file only if there is some error.
3514
3515         * Scripts/webkitpy/tool/bot/queueengine.py:
3516         (QueueEngine.run): If the build and tests pass, there is no ScriptError raised,
3517         there is nothing to log. Open the log file only if a ScriptError was raised to
3518         avoid to make empty log files for bugs.
3519         (QueueEngine._open_work_log): Does not need to tee STDOUT to log file anymore,
3520         because of changes in r138264. Teeing is used for locally testing purposes and
3521         this feature is not used anymore.
3522         (QueueEngine._ensure_work_log_closed): Close the logfile. We don't use output 
3523         teeing anymore. It is a necessary change because of QueueEngine._open_work_log
3524         change.
3525         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3526         (AbstractEarlyWarningSystem.review_patch): Raise again the captured ScriptError
3527         to be able to handle it in QueueEngine.run. Without this change, the existing
3528         exception handler never run (the process_work_item method never raise ScriptError)
3529         We can get the error message only from the ScriptError at this point.
3530
3531 2013-11-21  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
3532
3533         Remove ENABLE_WORKERS
3534         https://bugs.webkit.org/show_bug.cgi?id=105784
3535
3536         Reviewed by Darin Adler.
3537
3538         * Scripts/webkitperl/FeatureList.pm:
3539
3540 2013-11-21  Darin Adler  <darin@apple.com>
3541
3542         Try to fix buildbot Dashboard for people who have not hidden anything.
3543
3544         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3545         Add a null check for hidden platforms.
3546
3547 2013-11-21  Peter Szanka  <h868064@stud.u-szeged.hu>
3548
3549         Remove chrome/chromium related things from webkitpy.
3550         https://bugs.webkit.org/show_bug.cgi?id=124493
3551
3552         Reviewed by Darin Adler.
3553
3554         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3555         (PortTest.assert_mock_port_works):
3556         * Scripts/webkitpy/port/base.py:
3557         (Port.to.setup_environ_for_server):
3558         * Scripts/webkitpy/port/mac_unittest.py:
3559         (test_tests_for_other_platforms):
3560         * Scripts/webkitpy/port/mock_drt.py:
3561         (MockTestShell.output_for_test):
3562         * Scripts/webkitpy/tool/bot/irc_command.py:
3563         (Restart.execute):
3564         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
3565         (IRCBotTest.test_help):
3566
3567 2013-11-21  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
3568
3569         In filereader.py, process_file() should throw instead of exiting directly when the file doesn't exist
3570         https://bugs.webkit.org/show_bug.cgi?id=124717
3571
3572         Reviewed by Ryosuke Niwa.
3573
3574         * Scripts/webkitpy/style/filereader.py:
3575         (TextFileReader.process_file):
3576         * Scripts/webkitpy/style/filereader_unittest.py:
3577         (TextFileReaderTest.test_process_file__does_not_exist):
3578
3579 2013-11-21  Mark Rowe  <mrowe@apple.com>
3580
3581         <https://webkit.org/b/124702> Stop overriding VALID_ARCHS.
3582
3583         All modern versions of Xcode set it appropriately for our needs.
3584
3585         Reviewed by Alexey Proskuryakov.
3586
3587         * MiniBrowser/Configurations/Base.xcconfig:
3588         * WebKitTestRunner/Configurations/Base.xcconfig:
3589
3590 2013-11-21  Nick Diego Yamane  <nick.yamane@openbossa.org>
3591
3592         webkitdirs::checkForArgumentAndRemoveFromArrayRef() removed wrong element
3593         https://bugs.webkit.org/show_bug.cgi?id=124676
3594
3595         Reviewed by Daniel Bates.
3596
3597         checkForArgumentAndRemoveFromArrayRef functions was removing wrong
3598         elements when there were more then one occurrence of that argument.
3599         E.g: Checking for 'a' in {a, b, a, c}, the resulting array would be
3600         {b, a}, when it should be {b, c}.
3601
3602         * Scripts/webkitdirs.pm:
3603         (checkForArgumentAndRemoveFromArrayRef): bugfix mentioned above.
3604         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRef.pl:
3605         Added; Unit tests for webkitdirs::checkForArgumentAndRemoveFromArrayRef function.
3606
3607 2013-11-21  Ryosuke Niwa  <rniwa@webkit.org>
3608
3609         Update build-webkit after r159550.
3610
3611         * Scripts/webkitperl/FeatureList.pm:
3612
3613 2013-11-21  Lucas Forschler  <lforschler@apple.com>
3614
3615         Bring a new bot online, replacing the previous ones.
3616         
3617         Unreviewed.
3618
3619         * BuildSlaveSupport/build.webkit.org-config/config.json:
3620
3621 2013-11-21  Dean Jackson  <dino@apple.com>
3622
3623         Don't fetch hidden platforms on build.webkit.org/dashboard
3624         https://bugs.webkit.org/show_bug.cgi?id=124750
3625
3626         Reviewed by Tim Horton.
3627
3628         If a platform is hidden, don't fetch its data. If it
3629         becomes unhidden, try to fetch immediately (unless
3630         you've recently fetched).
3631
3632         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3633         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3634
3635 2013-11-21  Commit Queue  <commit-queue@webkit.org>
3636
3637         Unreviewed, rolling out r159633.
3638         http://trac.webkit.org/changeset/159633
3639         https://bugs.webkit.org/show_bug.cgi?id=124726
3640
3641         it broke 10 webkitpy tests (Requested by dino_ on #webkit).
3642
3643         * Scripts/webkitpy/style/checker.py:
3644         (check_webkit_style_configuration):
3645         (CheckerDispatcher.dispatch):
3646         (StyleProcessorConfiguration):
3647         (StyleProcessorConfiguration.__init__):
3648         (StyleProcessorConfiguration.write_style_error):
3649
3650 2013-11-21  László Langó  <lango@inf.u-szeged.hu>
3651
3652         Remove the stderr_write attribute from StyleProcessorConfiguration.
3653         https://bugs.webkit.org/show_bug.cgi?id=124703
3654