ed9b11c2aa0a0446a0d3268765cb0c2ead02bff9
[WebKit-https.git] / Tools / ChangeLog
1 2012-09-14  Simon Hausmann  <simon.hausmann@nokia.com>
2
3         [Qt] Fix linking on Windows
4
5         Reviewed by Tor Arne Vestbø.
6
7         When compiling code _after_ QtWebKit.dll, we need to make sure that the QWEBKIT_EXPORT
8         macro turns into an import macro, which means QT_MAKEDLL should only be set _up until_
9         the QtWebKit.dll creation in the build process and be off afterwards. This is done in
10         win32/default_post.prf using a !contains(QT, webkit): DEFINES += QT_MAKEDLL.
11
12         r128450 sanitized the values of QT and PKGCONFIG to only contain the dependencies we
13         want for QtWebKit.dll, but unfortunately that code was applied to any binary built also
14         after the module. Therefore QT did never contain webkit anymore and we always passed
15         QT_MAKEDLL to DEFINES, resulting in QWEBKIT_EXPORT to _not_ turn into an import macro.
16
17         This patch introduces a creating_module configuration that is used to
18         scope the qt/pkgconfig sanitization.
19
20         * qmake/mkspecs/features/default_post.prf:
21
22 2012-09-14  Christophe Dumez  <christophe.dumez@intel.com>
23
24         [WK2][WKTR] TestRunner is not dumping some frame load callbacks information
25         https://bugs.webkit.org/show_bug.cgi?id=96740
26
27         Reviewed by Kenneth Rohde Christiansen.
28
29         Dump information expected by the test cases about the following
30         frame load callbacks:
31         "didDisplayInsecureContentForFrame"
32         "didRunInsecureContentForFrame"
33         "didDetectXSSForFrame"
34
35         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
36         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame): Print a URL
37         as expected by test results by calling pathSuitableForTestResult() instead
38         of printing raw URL.
39         (WTR::InjectedBundlePage::didDisplayInsecureContentForFrame):
40         (WTR::InjectedBundlePage::didRunInsecureContentForFrame):
41         (WTR::InjectedBundlePage::didDetectXSSForFrame):
42
43 2012-09-14  Peter Beverloo  <peter@chromium.org>
44
45         The runtime/unsigned category should be valid in the cpp style-checker.
46         https://bugs.webkit.org/show_bug.cgi?id=96748
47
48         Reviewed by Csaba Osztrogonác.
49
50         This is causing the webkitpy tests to fail because it's not listed in the
51         category array. Furthermore, change an "int" to "long" because it's
52         throwing a double error in one of the earlier asserts.
53
54         * Scripts/webkitpy/style/checkers/cpp.py:
55         (CppChecker):
56         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
57         (WebKitStyleTest.test_names):
58
59 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
60
61         Evas_Object* is a ref'ed structure, so tread it as such
62         https://bugs.webkit.org/show_bug.cgi?id=96659
63
64         Reviewed by Adam Barth.
65
66         Replace OwnPtr<Evas_Object> with RefPtr.
67
68         * DumpRenderTree/efl/ImageDiff.cpp:
69         (calculateDifference):
70         (printImageDifferences):
71         (readImageFromStdin):
72         (main):
73
74 2012-09-14  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
75
76         Unreviewed, rolling out r128507.
77         http://trac.webkit.org/changeset/128507
78         https://bugs.webkit.org/show_bug.cgi?id=96659
79
80         Revert. r128507 makes too many crashes in EFL layout test bots.
81
82         * DumpRenderTree/efl/ImageDiff.cpp:
83         (calculateDifference):
84         (printImageDifferences):
85         (readImageFromStdin):
86         (main):
87
88 2012-09-13  Kevin Funk  <kevin.funk@kdab.com>
89
90         Make compile with both OS(WINCE) and PLATFORM(QT) support
91         https://bugs.webkit.org/show_bug.cgi?id=95536
92
93         Reviewed by Simon Hausmann.
94
95         Fix wince support in qmake files
96
97         * Tools.pro:
98         * qmake/mkspecs/features/configure.prf:
99         * qmake/mkspecs/features/default_post.prf:
100         * qmake/mkspecs/features/features.prf:
101         * qmake/mkspecs/features/functions.prf:
102
103 2012-09-13  KwangYong Choi  <ky0.choi@samsung.com>
104
105         [WK2] Add color picker API support for WebKit2
106         https://bugs.webkit.org/show_bug.cgi?id=95058
107
108         Reviewed by Gyuyoung Kim.
109
110         Initialization code for color picker callbacks in UI client.
111
112         * MiniBrowser/mac/BrowserWindowController.m:
113         (-[BrowserWindowController awakeFromNib]):
114         * MiniBrowser/win/BrowserView.cpp:
115         (BrowserView::create):
116         * WebKitTestRunner/TestController.cpp:
117         (WTR::TestController::createOtherPage):
118         (WTR::TestController::initialize):
119
120 2012-09-13  Yuta Kitamura  <yutak@chromium.org>
121
122         Upgrade yutak to reviewer
123         https://bugs.webkit.org/show_bug.cgi?id=96721
124
125         Reviewed by Kent Tamura.
126
127         * Scripts/webkitpy/common/config/committers.py:
128
129 2012-09-13  Adenilson Cavalcanti  <cavalcantii@gmail.com>
130
131         Make the style checker report usage of "unsigned int"
132         https://bugs.webkit.org/show_bug.cgi?id=96693
133
134         Reviewed by Dirk Pranke.
135
136         Add a rule to check for uses of unsigned int, as the updated coding style recomends.
137
138         * Scripts/webkitpy/style/checkers/cpp.py:
139         (check_language):
140
141 2012-09-13  Philip Rogers  <pdr@google.com>
142
143         Add gender-neutral form of webkit-patch land-cowboy
144         https://bugs.webkit.org/show_bug.cgi?id=96709
145
146         Reviewed by Adam Barth.
147
148         Add webkit-patch land-cowhand, the confident and courageous form of webkit-patch for everyone.
149
150         * Scripts/webkitpy/tool/commands/download.py:
151         (LandCowhand):
152
153 2012-09-13  Seokju Kwon  <seokju.kwon@samsung.com>
154
155         [EFL] Remove some parameters in browserCreate()
156         https://bugs.webkit.org/show_bug.cgi?id=96499
157
158         Reviewed by Kenneth Rohde Christiansen.
159
160         There are too many parameters in browserCreate(). Lots of it seems like settings from command line argument.
161         And I have moved some parameters into User_Arguments.
162
163         * EWebLauncher/main.c:
164         (_User_Arguments):
165         (_ELauncher):
166         (on_key_down):
167         (browserCreate):
168         (findThemePath):
169         (parseUserArguments):
170         (main):
171
172 2012-09-13  Mark Lam  <mark.lam@apple.com>
173
174         Unreviewed. Adding myself to the committers list.
175
176         * Scripts/webkitpy/common/config/committers.py:
177
178 2012-09-13  Ryosuke Niwa  <rniwa@webkit.org>
179
180         run-perf-tests output cryptic error when the config file is missing.
181         https://bugs.webkit.org/show_bug.cgi?id=96453
182
183         Reviewed by Tony Chang.
184
185         Add a special error message when a configuration file is missing.
186
187         Also update the help message of --source-json-path to signify the fact it specifies
188         the configuration file on performance tests bots.
189
190         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
191         (PerfTestsRunner._parse_args):
192         (PerfTestsRunner._generate_and_show_results):
193         (PerfTestsRunner._merge_slave_config_json):
194         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
195         (_test_run_with_json_output): Make upload to fail by default and assert the result
196         in the function so that we can return logs instead.
197         (_test_run_with_json_output.mock_upload_json):
198         (test_run_with_json_output):
199         (test_run_with_description):
200         (test_run_respects_no_results):
201         (test_run_with_slave_config_json):
202         (test_run_with_bad_slave_config_json):
203         (test_run_with_multiple_repositories):
204
205 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
206
207         Evas_Object* is a ref'ed structure, so tread it as such
208         https://bugs.webkit.org/show_bug.cgi?id=96659
209
210         Reviewed by Adam Barth.
211
212         Replace OwnPtr<Evas_Object> with RefPtr.
213
214         * DumpRenderTree/efl/ImageDiff.cpp:
215         (calculateDifference):
216         (printImageDifferences):
217         (readImageFromStdin):
218         (main):
219
220 2012-09-13  Csaba Osztrogonác  <ossy@webkit.org>
221
222         One more unreviewed trivial fix after r128399.
223
224         * BuildSlaveSupport/build.webkit.org-config/config.json: Fix URLs of the SVN mirror server.
225
226 2012-09-13  Csaba Osztrogonác  <ossy@webkit.org>
227
228         Unreviewed trivial fix after r128399.
229
230         * BuildSlaveSupport/wait-for-SVN-server.py: Renamed from Tools/BuildSlaveSupport/build.webkit.org-config/wait-for-SVN-server.py.
231         (getLatestSVNRevision):
232         (waitForSVNRevision):
233
234 2012-09-13  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
235
236         [WK2][WTR] WebKitTestRunner needs testRunner.callShouldCloseOnWebView
237         https://bugs.webkit.org/show_bug.cgi?id=96366
238
239         Reviewed by Anders Carlsson.
240
241         Implement testRunner.callShouldCloseOnWebView for WebKitTestRunner
242         by calling shouldClose() on the FrameLoader.
243
244         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
245         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
246         (WTR::TestRunner::callShouldCloseOnWebView):
247         (WTR):
248         * WebKitTestRunner/InjectedBundle/TestRunner.h:
249         (TestRunner):
250
251 2012-09-13  Sheriff Bot  <webkit.review.bot@gmail.com>
252
253         Unreviewed, rolling out r128453.
254         http://trac.webkit.org/changeset/128453
255         https://bugs.webkit.org/show_bug.cgi?id=96681
256
257         Having tests use the same appcache directory leads to timeouts
258         (Requested by zdobersek on #webkit).
259
260         * DumpRenderTree/gtk/DumpRenderTree.cpp:
261         (runTest):
262         * Scripts/webkitpy/layout_tests/port/gtk.py:
263         (GtkPort.setup_environ_for_server):
264
265 2012-09-13  James Robinson  <jamesr@chromium.org>
266
267         [chromium] Temporarily remove Android Builder (dbg) from garden-o-matic view
268         https://bugs.webkit.org/show_bug.cgi?id=96678
269
270         Reviewed by Dirk Pranke.
271
272         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
273         (.):
274
275 2012-09-13  Rob Buis  <rbuis@rim.com>
276
277         Unreviewed changes to watchlist.
278
279         - Add myself to BlackBerry bugs
280
281         * Scripts/webkitpy/common/config/watchlist:
282
283 2012-09-13  Stephen Chenney  <schenney@chromium.org>
284
285         Add an SVG entry to the watchlist
286
287         Unreviewed config change.
288
289         * Scripts/webkitpy/common/config/watchlist:
290         - Created a new SVG watchlist label covering WebCore/svg and WebCore/rendering/svg
291         - Added myself and pdr as watchers
292
293 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
294
295         [Qt] Make WebKit2 work on Windows with Qt 5
296         https://bugs.webkit.org/show_bug.cgi?id=76776
297
298         Reviewed by Tor Arne Vestbø.
299
300         WebKit2 should compile with Qt on Windows now, so enable it. This patch in fact corrects
301         the check to disable WebKit when we don't have USE_3D_GRAPHICS available, because we need
302         that for the GL TextureMapper (it's only built when that feature is set).
303
304         * qmake/mkspecs/features/configure.prf:
305
306 2012-09-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
307
308         [Qt] Ensure that QT is finalized before loading qt_module.prf
309
310         As qt_module.prf does dependency tracking based on the content of the
311         QT variable. The intermediate WebKit modules modify the variable in
312         their .pri files, so we have to ensure we've loaded all the modules
313         before loading qt_module.
314
315         Reviewed by Tor Arne Vestbø.
316         Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-09-13
317
318         * qmake/mkspecs/features/default_post.prf:
319         * qmake/mkspecs/features/webkit_modules.prf: Added.
320
321 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
322
323         [Qt] Fix build of Qt WTR/MiniBrowser with MSVC and nmake
324         https://bugs.webkit.org/show_bug.cgi?id=96633
325
326         Reviewed by Csaba Osztrogonác.
327
328         WTR and MiniBrowser both have DRT in their include path (for the shared font stuff). Batch
329         builds with MSVC and nmake result in nmake picking up main.cpp from the wrong directory.
330         It's the usual problem and the usual solution is to rename one of the conflicting files.
331         This patch chooses to rename DRT instead of WTR and MBR.
332
333         Fixed include order at the same time to match style guide.
334
335         * DumpRenderTree/qt/DumpRenderTree.pro:
336         * DumpRenderTree/qt/DumpRenderTreeMain.cpp: Renamed from Tools/DumpRenderTree/qt/main.cpp.
337         (messageHandler):
338         (isOption):
339         (takeOptionValue):
340         (printUsage):
341         (main):
342
343 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
344
345         The Script run-launcher should support -2 in combination with --efl
346         https://bugs.webkit.org/show_bug.cgi?id=96639
347
348         Reviewed by Simon Hausmann.
349
350         Support running the MiniBrowser then supplied -2 as argument.
351
352         * Scripts/run-launcher:
353
354 2012-09-13  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
355
356         Unreviewed, add my Intel email address to the list.
357
358         * Scripts/webkitpy/common/config/committers.py:
359
360 2012-09-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
361
362         [Qt] Don't overwrite LIBS_PRIVATE when sanitizing LIBS
363
364         Reviewed by Ossy.
365
366         * qmake/mkspecs/features/default_post.prf:
367
368 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
369
370         [EFL][DRT] Implement LayoutTestController::layerTreeAsText
371         https://bugs.webkit.org/show_bug.cgi?id=82294
372
373         Reviewed by Gyuyoung Kim.
374
375         Implement layerTreeAsText using the DumpRenderTreeSupportEfl method.
376
377         * DumpRenderTree/efl/TestRunnerEfl.cpp:
378         (TestRunner::layerTreeAsText):
379
380 2012-09-13  Zan Dobersek  <zandobersek@gmail.com>
381
382         [GTK] Clear application cache between tests in DumpRenderTree
383         https://bugs.webkit.org/show_bug.cgi?id=96543
384
385         Reviewed by Philippe Normand.
386
387         Call the new DumpRenderTreeSupportGtk method to clear application cache
388         after each test.
389
390         Set the XDG_CACHE_HOME environment variable when running DumpRenderTree
391         as well. Currently it points to a subdirectory in the layout tests results
392         directory. At least on the builders this ensures an empty cache directory
393         with each test run.
394
395         * DumpRenderTree/gtk/DumpRenderTree.cpp:
396         (runTest):
397         * Scripts/webkitpy/layout_tests/port/gtk.py:
398         (GtkPort.setup_environ_for_server):
399
400 2012-09-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
401
402         [Qt] Make sure LIBS, PKGCONFIG, and QT, do not affect QtWebKit's prl file
403
404         Unless it's actually a dependency of the public QtWebKit API.
405
406         We could replace every occurance of LIBS, PKGCONFIG, and QT, in the pri
407         files with their _PRIVATE equivivalent, but that's likely to break when
408         someone adds a new QT/LIBS/PKGCONFIG += foo line somewhere. Instead we
409         clean up the variables in default_post.
410
411         This means that the CONFIG -= explicitlib in linkAgainstLibrary() is no
412         longer needed, as it was a workaround for the intermediate libraries ending
413         up in the prl file. And, since CONFIG -= staticlib was there to support
414         the explicitlib option, we can remove that too (as well as the exception
415         for gprof, since it would be empty). If gprof needs tweaks to always link
416         statically they should go in gprof.prf.
417
418         Reviewed by Simon Hausmann.
419
420         * qmake/mkspecs/features/default_post.prf:
421         * qmake/mkspecs/features/functions.prf:
422
423 2012-09-13  Mario Sanchez Prada  <msanchez@igalia.com>
424
425         [GTK] "Infinite" loop in AccessibilityUIElementGtk.cpp
426         https://bugs.webkit.org/show_bug.cgi?id=96632
427
428         Reviewed by Carlos Garcia Campos.
429
430         Fix this by using atk_object_get_n_accessible_children instead of
431         calling getChildren() from childCount.
432
433         * WebKitTestRunner/InjectedBundle/gtk/AccessibilityUIElementGtk.cpp:
434         (WTR::AccessibilityUIElement::childrenCount): Avoid the infinite
435         loop by using atk_object_get_n_accessible_children().
436
437 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
438
439         [Qt][Win] Enable USE(3D_GRAPHICS)
440         https://bugs.webkit.org/show_bug.cgi?id=90879
441
442         Reviewed by Kenneth Rohde Christiansen.
443
444         Enable it on Windows as well as on QNX (bug fixed).
445
446         * qmake/mkspecs/features/features.prf:
447
448 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
449
450         [Qt] The ANGLE build on Windows breaks with GnuWin32's flex because it is too old
451         https://bugs.webkit.org/show_bug.cgi?id=96359
452
453         Reviewed by Tor Arne Vestbø.
454
455         GnuWin32's flex is 2.5.4 and that is too old for ANGLE's preprocessor
456         lexer. The only viable alternative I could find on Windows that provides
457         binaries is the winflexbison distribution (http://sourceforge.net/projects/winflexbison/),
458         so let's use that one instead.
459
460         * Scripts/webkitdirs.pm:
461         (checkRequiredSystemConfig):
462         * qmake/mkspecs/features/default_pre.prf:
463
464 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
465
466         [Qt] Add configuration for production builds
467         https://bugs.webkit.org/show_bug.cgi?id=96607
468
469         Reviewed by Kenneth Rohde Christiansen.
470
471         Add configuration tweaks for production builds, to ease memory pressure with the GNU toolchain
472         and enable all-in-one-files optimizations.
473
474         * qmake/mkspecs/features/production_build.prf: Added.
475
476 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
477
478         [Qt] GStreamer detection does not work when cross-compiling
479         https://bugs.webkit.org/show_bug.cgi?id=96608
480
481         Reviewed by Kenneth Rohde Christiansen.
482
483         When cross-compiling it is not safe to just use system(pkg-config),
484         because there is a high probability that it will find packages in the
485         host system instead of in the target one. Instead use qmake's new
486         packagesExist() function that takes care of this delicate aspect of
487         cross compilation by setting PKG_CONFIG_SYSROOT_DIR and
488         PKG_CONFIG_LIBDIR accordingly.
489
490         * qmake/mkspecs/features/features.prf:
491
492 2012-09-13  Christophe Dumez  <christophe.dumez@intel.com>
493
494         [WK2][WTR] More efficient string handling in InjectedBundlePage
495         https://bugs.webkit.org/show_bug.cgi?id=96609
496
497         Reviewed by Kenneth Rohde Christiansen.
498
499         Update StringBuilder usage in InjectedBundlePage to follow
500         the latest recommandations for efficient string handling:
501         http://trac.webkit.org/wiki/EfficientStrings
502
503         This involves using appendLiteral() or appendNumber()
504         instead of append() whenever possible.
505
506         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
507         (WTR::dumpPath):
508         (WTR::rangeToStr):
509         (WTR::styleDecToStr):
510         (WTR::frameToStr):
511         (WTR::dumpResourceURL):
512         (WTR):
513         (WTR::dumpFrameDescriptionSuitableForTestResult):
514         (WTR::dumpRequestDescriptionSuitableForTestResult):
515         (WTR::dumpResponseDescriptionSuitableForTestResult):
516         (WTR::dumpErrorDescriptionSuitableForTestResult):
517         (WTR::InjectedBundlePage::didReceiveIntentForFrame):
518         (WTR::InjectedBundlePage::registerIntentServiceForFrame):
519         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
520         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
521         (WTR::InjectedBundlePage::didCommitLoadForFrame):
522         (WTR::InjectedBundlePage::didFinishProgress):
523         (WTR::dumpFrameScrollPosition):
524         (WTR::dumpFrameText):
525         (WTR::dumpDescendantFramesText):
526         (WTR::InjectedBundlePage::didFinishLoadForFrame):
527         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
528         (WTR::InjectedBundlePage::didCancelClientRedirectForFrame):
529         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
530         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
531         (WTR::InjectedBundlePage::didHandleOnloadEventsForFrame):
532         (WTR::InjectedBundlePage::willSendRequestForFrame):
533         (WTR::InjectedBundlePage::didReceiveResponseForResource):
534         (WTR::InjectedBundlePage::didFinishLoadForResource):
535         (WTR::InjectedBundlePage::didFailLoadForResource):
536         (WTR::InjectedBundlePage::shouldCacheResponse):
537         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
538         (WTR::InjectedBundlePage::willAddMessageToConsole):
539         (WTR::InjectedBundlePage::willSetStatusbarText):
540         (WTR::InjectedBundlePage::willRunJavaScriptAlert):
541         (WTR::InjectedBundlePage::willRunJavaScriptConfirm):
542         (WTR::InjectedBundlePage::willRunJavaScriptPrompt):
543         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
544         (WTR::InjectedBundlePage::shouldBeginEditing):
545         (WTR::InjectedBundlePage::shouldEndEditing):
546         (WTR::InjectedBundlePage::shouldInsertNode):
547         (WTR::InjectedBundlePage::shouldInsertText):
548         (WTR::InjectedBundlePage::shouldDeleteRange):
549         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
550         (WTR::InjectedBundlePage::shouldApplyStyle):
551         (WTR::InjectedBundlePage::didBeginEditing):
552         (WTR::InjectedBundlePage::didEndEditing):
553         (WTR::InjectedBundlePage::didChange):
554         (WTR::InjectedBundlePage::didChangeSelection):
555         (WTR::InjectedBundlePage::supportsFullScreen):
556         (WTR::InjectedBundlePage::enterFullScreenForElement):
557         (WTR::InjectedBundlePage::exitFullScreenForElement):
558         (WTR::InjectedBundlePage::beganEnterFullScreen):
559         (WTR::InjectedBundlePage::beganExitFullScreen):
560         (WTR::InjectedBundlePage::closeFullScreen):
561         (WTR::dumpBackForwardListItem):
562         (WTR::InjectedBundlePage::dumpBackForwardList):
563
564 2012-09-13  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
565
566         [Qt][WK2] Memory leaks in Qt's TestRunner
567         https://bugs.webkit.org/show_bug.cgi?id=96603
568
569         Reviewed by Csaba Osztrogonác.
570
571         Fix memory leaks in Qt's TestRunner code by adopting WKString
572         created with WKStringCreateWithUTF8CString().
573
574         * WebKitTestRunner/qt/TestControllerQt.cpp:
575         (WTR::TestController::initializeInjectedBundlePath):
576         (WTR::TestController::initializeTestPluginDirectory):
577
578 2012-09-13  Zan Dobersek  <zandobersek@gmail.com>
579
580         [GTK][NRWT] Lower timeout value to 6 seconds (12 for debug configuration)
581         https://bugs.webkit.org/show_bug.cgi?id=96506
582
583         Reviewed by Dirk Pranke.
584
585         Lower the timeout value to 6 seconds for release configuration and 12 seconds
586         for debug configuration. These are the same values the Chromium port uses.
587
588         Currently the value is lowered only for the DumpRenderTree, WebKitTestRunner (and
589         the layout tests under WebKit2 generally) requires more attention and gardening
590         than what the current effort produces.
591
592         The unit test is updated as well to test these changes.
593
594         * Scripts/webkitpy/layout_tests/port/gtk.py:
595         (GtkPort.default_timeout_ms):
596         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
597         (GtkPortTest.test_default_timeout_ms):
598         (GtkPortTest.assertLinesEqual):
599
600 2012-09-12  Csaba Osztrogonác  <ossy@webkit.org>
601
602         Add SVN mirror handling feature to build.webkit.org
603         https://bugs.webkit.org/show_bug.cgi?id=85887
604
605         Reviewed by Dirk Pranke.
606
607         * BuildSlaveSupport/build.webkit.org-config/config.json: Add SVN mirrors for Qt buildslaves hosted in Szeged.
608         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
609         (ConfigureBuild.__init__): Add SVNMirror property to be able to watch which slaves use which mirror on build.webkit.org.
610         (ConfigureBuild.start):
611         (CheckOutSource.__init__): Set baseURL to the SVNMirror or the default http://svn.webkit.org/repository/webkit/
612         (WaitForSVNServer): Add new buildstep for waiting the SVNMirror to be in sync with http://svn.webkit.org/repository/webkit/
613         (Factory.__init__):
614         (BuildFactory.__init__):
615         (TestFactory.__init__):
616         (BuildAndTestFactory.__init__):
617         (BuildAndPerfTestFactory.__init__):
618         (BuildAndPerfTestWebKit2Factory.__init__):
619         (DownloadAndPerfTestFactory.__init__):
620         (DownloadAndPerfTestWebKit2Factory.__init__):
621         (loadBuilderConfig): Use kwargs instead of args to be able to add the optional SVNMirror factory argument.
622         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
623         (SVNMirrorTest):
624         (SVNMirrorTest.setUp): Load config.json once at startup.
625         (SVNMirrorTest.get_SVNMirrorFromConfig): Get the SVNMirror from config.json for a given buildslave.
626         (SVNMirrorTest.test_CheckOutSource): Compare CheckOutSource.baseURL with SVNMirror in config.json for all builders
627         * BuildSlaveSupport/build.webkit.org-config/wait-for-SVN-server.py: Added.
628         (getLatestSVNRevision): Get the latest SVN revison from the given server.
629         (waitForSVNRevision): Wait until the given SVN revision is committed to the given server. It doesn't wait if the
630                               SVN revision is empty (force build triggered without revision) or the server is unavailable.
631
632 2012-09-12  Kangil Han  <kangil.han@samsung.com>
633
634         [WK2][WTR] Set waitUntilDone watchdog timer value equal to WK1.
635         https://bugs.webkit.org/show_bug.cgi?id=81606
636
637         Reviewed by Tim Horton.
638
639         6 seconds is harsh for some jquery test cases.
640         Therefore, adjust the value to match DumpRenderTree.
641
642         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
643         (WTR):
644
645 2012-09-12  KyungTae Kim  <ktf.kim@samsung.com>
646
647         [EFL] Support download attribute feature
648         https://bugs.webkit.org/show_bug.cgi?id=96462
649
650         Reviewed by Gyuyoung Kim.
651
652         Enable DOWNLOAD_ATTRIBUTE feature for EFL port,
653         and add "download,request" callback to the DumpRenderTree for EFL.
654
655         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
656         (DumpRenderTreeChrome::createView):
657         (DumpRenderTreeChrome::onDownloadRequest):
658         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
659         (DumpRenderTreeChrome):
660         * Scripts/webkitperl/FeatureList.pm:
661
662 2012-09-12  Stephanie Lewis  <slewis@apple.com>
663
664         Reduce parallism on the wk2 testers.
665         https://bugs.webkit.org/show_bug.cgi?id=95906
666
667         Reviewed by Dirk Pranke.
668
669         The wk2 testers on Mountain Lion are getting stuck and timing out.  The problem appears to be due to
670         resource contention.  Reducing the number of processes alleviates the issue.  
671
672         Starting by reducing 25%.
673
674         * Scripts/webkitpy/layout_tests/port/mac.py:
675         (MacPort.default_child_processes):
676
677 2012-09-12  Brady Eidson  <beidson@apple.com>
678
679         Assert in NetscapePlugin::destroy() with async plugin init
680         <rdar://problem/12277595> and https://bugs.webkit.org/show_bug.cgi?id=96576
681
682         Reviewed by Anders Carlsson.
683
684         Expose NPN_Invoke to plug-in tests:
685         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
686         (PluginTest::NPN_Invoke):
687         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
688         (PluginTest):
689
690         Add a test that uses NPN_Invoke on the window object from inside NPP_New to remove the plug-in element:
691         * DumpRenderTree/TestNetscapePlugIn/Tests/InvokeDestroysPluginWithinNPP_New.cpp: Added.
692         (InvokeDestroysPluginWithinNPP_New):
693         (InvokeDestroysPluginWithinNPP_New::InvokeDestroysPluginWithinNPP_New):
694         (InvokeDestroysPluginWithinNPP_New::NPP_New):
695         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
696
697 2012-09-12  Dirk Pranke  <dpranke@chromium.org>
698
699         refactor TestExpectations tokenization slightly in preparation for the new syntax
700         https://bugs.webkit.org/show_bug.cgi?id=96564
701
702         Reviewed by Ojan Vafai.
703
704         This change changes how we will tokenize/lex the
705         TestExpectations files, in preparation for supporting both the
706         old syntax and the new one. This change by itself should be a
707         no-op.
708
709         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
710         (TestExpectationParser._tokenize_line):
711         (TestExpectationParser):
712         (TestExpectationParser._tokenize_line_using_old_format):
713         (TestExpectationParser._tokenize_line_using_new_format):
714
715 2012-09-12  Dirk Pranke  <dpranke@chromium.org>
716
717         remove unused testexpectations editing code from webkitpy, garden-o-matic
718         https://bugs.webkit.org/show_bug.cgi?id=96562
719
720         Reviewed by Adam Barth.
721
722         This code was prototyped but never fully realized. Removing
723         until it reanimates :).
724
725         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
726         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
727         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor.py: Removed.
728         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py: Removed.
729         * Scripts/webkitpy/tool/servers/gardeningserver.py:
730         (BuildCoverageExtrapolator.extrapolate_test_configurations):
731         (GardeningHTTPRequestHandler._run_webkit_patch):
732         (GardeningHTTPRequestHandler.ping):
733         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
734         (BuildCoverageExtrapolatorTest.test_extrapolate):
735         (GardeningServerTest.test_rebaseline_new_port):
736
737 2012-09-12  Lucas Forschler  <lforschler@apple.com>
738
739         Remove unused bot, apple-xserve-1.
740         https://bugs.webkit.org/show_bug.cgi?id=96570
741         
742         Reviewed by Stephanie Lewis.
743
744         * BuildSlaveSupport/build.webkit.org-config/config.json:
745
746 2012-09-12  Xan Lopez  <xlopez@igalia.com>
747
748         [GTK] We attempt to rebase documentation even if it's not present
749         https://bugs.webkit.org/show_bug.cgi?id=96553
750
751         Reviewed by Martin Robinson.
752
753         Do not make the documentation rebase step fatal. This allows make
754         install to succeed when there's no documentation generated.
755
756         * gtk/generate-gtkdoc:
757
758 2012-09-12  Kenneth Rohde Christiansen  <kenneth@webkit.org>
759
760         Respect WEBKITOUTPUTDIR when running EFL tests
761         https://bugs.webkit.org/show_bug.cgi?id=96528
762
763         Reviewed by Dirk Pranke.
764
765         Expose user set WEBKITOUTPUTDIR to the web process.
766
767         * Scripts/webkitpy/layout_tests/port/driver.py:
768         (Driver._start): Add WEBKITOUTPUTDIR to the environment
769         of the web process and its potential jhbuild wrapper.
770
771 2012-09-12  Dirk Pranke  <dpranke@chromium.org>
772
773         webkitdirs: fix uname version handling for cygwin
774         https://bugs.webkit.org/show_bug.cgi?id=96436
775
776         Reviewed by Jon Honeycutt.
777
778         Newer versions of cygwin embed an additional version string
779         inside parentheses, so you get "1.7.16(0.249/5/3)" instead of "1.7.16".
780         Update the code to handle that.
781
782         * Scripts/webkitdirs.pm:
783         (setupAppleWinEnv):
784
785 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
786
787         Regression(r128338): Broke Windows build
788         https://bugs.webkit.org/show_bug.cgi?id=96537
789
790         Unreviewed build fix.
791
792         Fix Apple-Win build by allocating array dynamically
793         since its size is not constant.
794
795         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
796         (WTR::stringArrayToJS):
797
798 2012-09-12  Alex Sakhartchouk  <alexst@chromium.org>
799
800         [chromium] Add a virtual test suite for fast/hidpi
801         https://bugs.webkit.org/show_bug.cgi?id=90192
802
803         Reviewed by Dirk Pranke.
804
805         Add a virtual test suite to make sure the pixel tests in fast/hidpi give the same result
806         on the hardware accelerated path as the software path.
807
808         * DumpRenderTree/chromium/WebPreferences.cpp:
809         (WebPreferences::applyTo):
810         * Scripts/webkitpy/layout_tests/port/chromium.py:
811         (ChromiumPort.virtual_test_suites):
812
813 2012-09-12  Adam Klein  <adamk@chromium.org>
814
815         [chromium] Add content_browsertests to the flakiness dashboard
816         https://bugs.webkit.org/show_bug.cgi?id=96535
817
818         Reviewed by Ojan Vafai.
819
820         * TestResultServer/static-dashboards/dashboard_base.js:
821
822 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
823
824         [WK2][WKTR] TestRunner needs to implement originsWithApplicationCache
825         https://bugs.webkit.org/show_bug.cgi?id=96496
826
827         Reviewed by Kenneth Rohde Christiansen.
828
829         Add implementation for originsWithApplicationCache to
830         WebKitTestRunner.
831
832         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
833         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
834         (WTR::stringArrayToJS):
835         (WTR):
836         (WTR::TestRunner::originsWithApplicationCache):
837         * WebKitTestRunner/InjectedBundle/TestRunner.h:
838         (TestRunner):
839
840 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
841
842         Fix Qt/Windows build with Python3
843         https://bugs.webkit.org/show_bug.cgi?id=96473
844
845         Reviewed by Csaba Osztrogonác.
846
847         In Python 3 print is a real function, so we must use parentheses around
848         the function parameters. This is backwards compatible with Python 2.
849
850         * Scripts/generate-win32-export-forwards:
851
852 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
853
854         Unreviewed trivial build fix for Qt/Windows after bug #96358.
855
856         As pointed out by Kevin, we should inject the "set PATH=..." statement
857         to add the GnuWin32 directory only if that directory actually exists.
858
859         * qmake/mkspecs/features/default_post.prf:
860
861 2012-09-12  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
862
863         [EFL] [WK2] Memory leaks in TestControllerEfl
864         https://bugs.webkit.org/show_bug.cgi?id=96525
865
866         Reviewed by Kenneth Rohde Christiansen.
867
868         Fix memory leaks in EFL's TestRunner code by adopting an allocation
869         of WKString created with WKStringCreateWithUTF8CString().
870
871         * WebKitTestRunner/efl/TestControllerEfl.cpp:
872         (WTR::TestController::initializeInjectedBundlePath):
873         (WTR::TestController::initializeTestPluginDirectory):
874
875 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
876
877         [WK2][WKTR] TestRunner needs to implement dumpApplicationCacheDelegateCallbacks
878         https://bugs.webkit.org/show_bug.cgi?id=96374
879
880         Reviewed by Kenneth Rohde Christiansen.
881
882         Implement support for dumpApplicationCacheDelegateCallbacks
883         and disallowIncreaseForApplicationCacheQuota in
884         WebKitTestRunner and properly dump the information
885         expected by the tests.
886
887         If the application cache quota is reached for a given
888         security origin, WebKitTestRunner will reset the quota
889         to its default value, unless intructed not to via
890         disallowIncreaseForApplicationCacheQuota().
891
892         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
893         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
894         (WTR::InjectedBundlePage::InjectedBundlePage):
895         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
896         (WTR):
897         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
898         (InjectedBundlePage):
899         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
900         (WTR::TestRunner::TestRunner):
901         (WTR::TestRunner::disallowIncreaseForApplicationCacheQuota):
902         (WTR):
903         * WebKitTestRunner/InjectedBundle/TestRunner.h:
904         (WTR::TestRunner::dumpApplicationCacheDelegateCallbacks):
905         (TestRunner):
906         (WTR::TestRunner::shouldDisallowIncreaseForApplicationCacheQuota):
907         (WTR::TestRunner::shouldDumpApplicationCacheDelegateCallbacks):
908
909 2012-09-12  Jochen Eisinger  <jochen@chromium.org>
910
911         [chromium] remove deprecated and unused sets import from chromium_android driver
912         https://bugs.webkit.org/show_bug.cgi?id=96485
913
914         Reviewed by Dirk Pranke.
915
916         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
917
918 2012-09-12  Zan Dobersek  <zandobersek@gmail.com>
919
920         Flakiness dashboard doesn't recognize new Chromium Android test builder
921         https://bugs.webkit.org/show_bug.cgi?id=96523
922
923         Reviewed by Ojan Vafai.
924
925         Properly return 'ANDROID' as the Chromium platform for Android builders.
926
927         * TestResultServer/static-dashboards/flakiness_dashboard.js:
928         (chromiumPlatform):
929         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
930         (test):
931
932 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
933
934         [Qt] Build on Windows requires bison/flex in PATH
935         https://bugs.webkit.org/show_bug.cgi?id=96358
936
937         Reviewed by Tor Arne Vestbø.
938
939         The build requires flex, bison, etc. and they need to be in the PATH when building. On Mac OS X
940         and Linux that is rarely a problem given how easily available the tools are. On Windows however
941         a separate installation of various GNU tools is required as the operating system doesn't come with
942         them. To make the development more convenient, Qt 5 provides a copy of the most essential tools in
943         the gnuwin32 directory of the qt5.git top-level repository.
944
945         This patch tries to detect the presence of those tools and prepends them to the PATH if found.
946
947         This is required in preparation for the elimination of qt5/qtwebkit.pri, which currently expands
948         PATH before calling build-webkit. It it also required for the upcoming introduction of win_flex
949         as dependency over flex, which can be done with less hassle when qt5's gnuwin32 directory has been
950         updated with the new tool.
951
952         * Scripts/webkitdirs.pm:
953         (checkRequiredSystemConfig):
954         * qmake/mkspecs/features/default_post.prf:
955
956 2012-09-12  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
957
958         [Qt] Update build-jsc after r128174
959
960         Reviewed by Ossy.
961
962         * Scripts/build-jsc:
963
964 2012-09-12  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
965
966         [Qt] Teach addStrictSubdirOrderBetween to handle more than two targets
967
968         By hard-coding the names of the targets we defined we ended up just
969         redefining the previous target when using addStrictSubdirOrderBetween
970         more than once in a single project file.
971
972         We now embed the two base targets into the target names.
973
974         Reviewed by Simon Hausmann.
975
976         * qmake/mkspecs/features/functions.prf:
977
978 2012-09-12  Philippe Liard  <pliard@google.com>
979
980         Depend on {base,net} GYP targets rather than {base,net}_java.
981         https://bugs.webkit.org/show_bug.cgi?id=95690
982
983         Reviewed by Adam Barth.
984
985         {base,net}_java became 'private' targets on the Chromium side that
986         clients should not depend on (see
987         https://chromiumcodereview.appspot.com/10913083/).
988         This removes a bunch of trailing white spaces additionally in
989         TestWebkitAPI.gyp (which includes non-trailing white space changes).
990
991         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
992         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
993
994 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
995
996         [Qt] Fix the build with ENABLE_NETSCAPE_PLUGIN_API=0
997         https://bugs.webkit.org/show_bug.cgi?id=96494
998
999         Reviewed by Tor Arne Vestbø.
1000
1001         WK2's ENABLE_PLUGIN_PROCESS uses the NPAPI functions unconditionally, so disable the
1002         plugin process feature if we don't have NPAPI.
1003
1004         * qmake/mkspecs/features/features.prf:
1005
1006 2012-09-12  Sheriff Bot  <webkit.review.bot@gmail.com>
1007
1008         Unreviewed, rolling out r128280.
1009         http://trac.webkit.org/changeset/128280
1010         https://bugs.webkit.org/show_bug.cgi?id=96498
1011
1012         it broke compilation on windows debug bot (Requested by loislo
1013         on #webkit).
1014
1015         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1016         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1017         (WTR::InjectedBundlePage::InjectedBundlePage):
1018         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1019         (InjectedBundlePage):
1020         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1021         (WTR::TestRunner::TestRunner):
1022         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1023         (TestRunner):
1024
1025 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
1026
1027         [Qt] Make it possible to build with "make release" and "make debug" on Windows
1028         https://bugs.webkit.org/show_bug.cgi?id=96488
1029
1030         Reviewed by Tor Arne Vestbø.
1031
1032         A "make debug" is passed through recursively and currently it aborts at Makefile.DerivedSources
1033         because there are no such targets. We want the generated sources to be independent from release
1034         or debug build configurations, so it is sufficient to provide fake debug and release targets that
1035         redirect to the same general-purpose target (first) of creating the derived sources.
1036
1037         * qmake/mkspecs/features/default_post.prf:
1038
1039 2012-09-12  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1040
1041         [EFL] Make DumpRenderTree smarter at finding the fonts
1042         http://webkit.org/b/96281
1043
1044         Reviewed by Gyuyoung Kim.
1045
1046         Respect WEBKITOUTPUTDIR and expand the font dir from it.
1047         Use CString consistently.
1048
1049         * DumpRenderTree/efl/FontManagement.cpp:
1050         (buildPath):
1051         (getCoreFontFiles):
1052         (addFontDirectory):
1053         (addFontFiles):
1054         (getCustomBuildDir):
1055         (getPlatformFontsPath):
1056         (addFontsToEnvironment):
1057
1058 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
1059
1060         [WK2][WKTR] TestRunner needs to implement dumpApplicationCacheDelegateCallbacks
1061         https://bugs.webkit.org/show_bug.cgi?id=96374
1062
1063         Reviewed by Kenneth Rohde Christiansen.
1064
1065         Implement support for dumpApplicationCacheDelegateCallbacks
1066         and disallowIncreaseForApplicationCacheQuota in
1067         WebKitTestRunner and properly dump the information
1068         expected by the tests.
1069
1070         If the application cache quota is reached for a given
1071         security origin, WebKitTestRunner will reset the quota
1072         to its default value, unless intructed not to via
1073         disallowIncreaseForApplicationCacheQuota().
1074
1075         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1076         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1077         (WTR::InjectedBundlePage::InjectedBundlePage):
1078         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
1079         (WTR):
1080         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1081         (InjectedBundlePage):
1082         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1083         (WTR::TestRunner::TestRunner):
1084         (WTR::TestRunner::disallowIncreaseForApplicationCacheQuota):
1085         (WTR):
1086         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1087         (WTR::TestRunner::dumpApplicationCacheDelegateCallbacks):
1088         (TestRunner):
1089         (WTR::TestRunner::shouldDisallowIncreaseForApplicationCacheQuota):
1090         (WTR::TestRunner::shouldDumpApplicationCacheDelegateCallbacks):
1091
1092 2012-09-12  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1093
1094         [WK2] [WTR] WebKitTestRunner needs TestRunner.workerThreadCount
1095         https://bugs.webkit.org/show_bug.cgi?id=96388
1096
1097         Reviewed by Kenneth Rohde Christiansen.
1098
1099         Exported TestRunner.workerThreadCount as readonly attribute.
1100
1101         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1102         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Added workerThreadCount() method implementation.
1103         (WTR::TestRunner::workerThreadCount): Returns count of worker threads.
1104         (WTR):
1105         * WebKitTestRunner/InjectedBundle/TestRunner.h: Added workerThreadCount() method. 
1106         (TestRunner):
1107
1108 2012-09-12  Jochen Eisinger  <jochen@chromium.org>
1109
1110         [chromium] Consume a user gesture when creating a new view.
1111         https://bugs.webkit.org/show_bug.cgi?id=96373
1112
1113         Reviewed by Adam Barth.
1114
1115         * DumpRenderTree/chromium/WebViewHost.cpp:
1116         (WebViewHost::createView):
1117
1118 2012-09-12  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1119
1120         [WK2][WTR] Some of TestRunner special options are not reset before testing
1121         https://bugs.webkit.org/show_bug.cgi?id=96384
1122
1123         Reviewed by Kenneth Rohde Christiansen.
1124
1125         Now values of the following special options are reset:
1126         void setAcceptsEditing(in boolean value);
1127         void setCloseRemainingWindowsWhenComplete(in boolean value);
1128         void setXSSAuditorEnabled(in boolean value);
1129         void setAllowFileAccessFromFileURLs(in boolean value);
1130         void setPluginsEnabled(in boolean value);
1131         void setPopupBlockingEnabled(in boolean value);
1132
1133         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1134         (WTR::InjectedBundle::beginTesting):
1135
1136 2012-09-11  Ryuan Choi  <ryuan.choi@samsung.com>
1137
1138         [CMAKE] Supply feature defines to CodeGeneratorTestRunner.
1139         https://bugs.webkit.org/show_bug.cgi?id=96273
1140
1141         Reviewed by Gyuyoung Kim.
1142
1143         Passed FEATURE_DEFINES_WITH_SPACE_SEPARATOR to CodeGeneratorTestRunner
1144         in order to distinguish compile time options such as ENABLE(TOUCH_EVENTS).
1145
1146         * WebKitTestRunner/CMakeLists.txt:
1147
1148 2012-09-11  Dirk Pranke  <dpranke@chromium.org>
1149
1150         [chromium] rename webkit_resources
1151         https://bugs.webkit.org/show_bug.cgi?id=95874
1152
1153         Reviewed by James Robinson.
1154
1155         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1156
1157 2012-09-11  Jochen Eisinger  <jochen@chromium.org>
1158
1159         [chromium] don't include content shell builders in the garden-o-matic view
1160         https://bugs.webkit.org/show_bug.cgi?id=96418
1161
1162         Reviewed by James Robinson.
1163
1164         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1165
1166 2012-09-11  Adam Klein  <adamk@chromium.org>
1167
1168         Garden-o-matic should ignore a wider variety of warnings in buildbot json
1169         https://bugs.webkit.org/show_bug.cgi?id=96411
1170
1171         Reviewed by Adam Barth.
1172
1173         Previously only the exact string "warning" was treated as a warning
1174         result. This patch treats any string with "warning" as a substring
1175         as a warning (e.g., "warnings", as seen on the cr-win buildbots).
1176
1177         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
1178         (.):
1179         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
1180
1181 2012-09-11  Marcelo Lira  <marcelo.lira@openbossa.org>
1182
1183         Restore original value of mock scrollbars enabled in InternalSettings
1184         https://bugs.webkit.org/show_bug.cgi?id=87680
1185
1186         Reviewed by Adam Barth.
1187
1188         Added backup support for mock scrollbars state in
1189         InternalSettings::Backup, and removed support for these
1190         from Qt's DumpRenderTree.
1191
1192         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1193         (WebCore::WebPage::resetSettings):
1194         * DumpRenderTree/qt/TestRunnerQt.cpp:
1195         (TestRunner::setFrameFlatteningEnabled):
1196         * DumpRenderTree/qt/TestRunnerQt.h:
1197         (TestRunner):
1198
1199 2012-09-11  Dan Bernstein  <mitz@apple.com>
1200
1201         Fixed a bug where kill-old-processes failed to kill clang++.
1202
1203         Rubber-stamped by Alexey Proskuryakov.
1204
1205         * BuildSlaveSupport/kill-old-processes: Escape the + signs in "clang++"
1206         where it is passed as a regular expression to killall.
1207
1208 2012-09-11  Philippe Liard  <pliard@google.com>
1209
1210         Make sure that md5sum is not setup on non-Chromium Android platforms.
1211         https://bugs.webkit.org/show_bug.cgi?id=96393
1212
1213         Reviewed by Adam Barth.
1214
1215         Previously md5sum was setup in ChromiumAndroidDriver's constructor
1216         which is also invoked on non-Chromium Android platforms. The following patch
1217         moves this logic to _startup_test() which is guaranteed to be invoked
1218         only on Android.
1219
1220         This also updates the prompt unit test in chromium_android_unittest.py.
1221
1222         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1223         (ChromiumAndroidDriver.__init__):
1224         (ChromiumAndroidDriver._setup_md5sum_and_push_data_if_needed):
1225         (ChromiumAndroidDriver._setup_test):
1226
1227 2012-09-11  Raphael Kubo da Costa  <rakuco@webkit.org>
1228
1229         [EFL] Rewrite the EFL-related Find modules
1230         https://bugs.webkit.org/show_bug.cgi?id=95237
1231
1232         Reviewed by Kenneth Rohde Christiansen.
1233
1234         * DumpRenderTree/efl/CMakeLists.txt: Stop setting the LINK_FLAGS
1235         property and include all the Enlightenment Foundation Libraries
1236         required by the target.
1237         * EWebLauncher/CMakeLists.txt: Ditto.
1238         * MiniBrowser/efl/CMakeLists.txt: Ditto.
1239         * TestWebKitAPI/PlatformEfl.cmake: Add missing include directories
1240         now that they are not added implicitly.
1241         * WebKitTestRunner/CMakeLists.txt: Stop setting the LINK_FLAGS
1242         property.
1243         * WebKitTestRunner/PlatformEfl.cmake: Stop setting the LINK_FLAGS
1244         property and include all the Enlightenment Foundation Libraries
1245         required by the target.
1246
1247 2012-09-11  Christophe Dumez  <christophe.dumez@intel.com>
1248
1249         [WK2][WKTR] TestRunner needs to implement setApplicationCacheOriginQuota
1250         https://bugs.webkit.org/show_bug.cgi?id=96379
1251
1252         Reviewed by Kenneth Rohde Christiansen.
1253
1254         Add implementation for setApplicationCacheOriginQuota
1255         to WebKitTestRunner.
1256
1257         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1258         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1259         (WTR::TestRunner::setApplicationCacheOriginQuota):
1260         (WTR):
1261         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1262         (TestRunner):
1263
1264 2012-09-11  Luciano Wolf  <luciano.wolf@openbossa.org>
1265
1266         [Qt] [WK2] editing/inserting/typing-tab-designmode tests are failing
1267         https://bugs.webkit.org/show_bug.cgi?id=91988
1268
1269         Reviewed by Kenneth Rohde Christiansen.
1270
1271         Regular key events generated by Qt for the tab key fill both
1272         keyCode and keyText, so we should do the same for our fake events.
1273
1274         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
1275         (WTR::EventSenderProxy::keyDown):
1276
1277 2012-09-11  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1278
1279         [WK2][WTR] WebKitTestRunner needs testRunner.setSpatialNavigationEnabled
1280         https://bugs.webkit.org/show_bug.cgi?id=96269
1281
1282         Reviewed by Kenneth Rohde Christiansen.
1283
1284         Exported missing testRunner.setSpatialNavigationEnabled() method.
1285
1286         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1287         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1288         (WTR::InjectedBundle::beginTesting):
1289         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1290         (WTR::TestRunner::setSpatialNavigationEnabled):
1291         (WTR):
1292         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1293         (TestRunner):
1294
1295 2012-09-11  Philippe Liard  <pliard@chromium.org>
1296
1297         Support LayoutTests on non-rooted devices for Chromium Android.
1298         https://bugs.webkit.org/show_bug.cgi?id=95346
1299
1300         Reviewed by Dirk Pranke.
1301
1302         We were requiring root permissions to sync resource files with the
1303         device by comparing host and device files' timestamp after we
1304         synchronized the device and host clocks.
1305         We now rely on md5sum provided by Chromium to handle data files
1306         synchronization.
1307
1308         * Scripts/webkitpy/layout_tests/port/chromium.py:
1309         (ChromiumPort._check_driver_build_up_to_date):
1310         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1311         (ChromiumAndroidDriver.__init__):
1312         (ChromiumAndroidDriver._setup_test):
1313         (ChromiumAndroidDriver._push_executable):
1314         (ChromiumAndroidDriver._push_test_resources):
1315         (ChromiumAndroidDriver._read_prompt):
1316
1317 2012-09-11  Simon Hausmann  <simon.hausmann@nokia.com>
1318
1319         [Qt] Fix output paths on Windows
1320
1321         Reviewed by Tor Arne Vestbø.
1322
1323         BUILD_ROOT_RELATIVE_TO_OUT_PWD was calculated incorrectly Windows, resulting in an incorrect
1324         DESTDIR transformation at the end of default_post.prf. The calculation should be baased no qmake
1325         paths, which can use drive letters but always use forward slashes. So the use of QMAKE_DIR_SEP is
1326         incorrect here and instead for the calculation we should use forward slashes.
1327
1328         * qmake/mkspecs/features/default_pre.prf:
1329
1330 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1331
1332         [Qt] Fix passing of defines from the build system
1333
1334         We explicitly have to pass -DENABLE_FOO=0 for every single feature
1335         that's not explicitly enabled in WEBKIT_CONFIG, since Platform.h
1336         will add it's own defaults if the features are not defined.
1337
1338         At some point we might want to run a configure-test to inspect what
1339         Platform.h will do, so we can sync up the build system's view of
1340         the feature-defines with the compile-time situation.
1341
1342         Reviewed by Simon Hausmann.
1343
1344         * qmake/mkspecs/features/functions.prf:
1345
1346 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1347
1348         [Qt] Fix --qt option to build-webkit
1349
1350         Reviewed by Ossy.
1351
1352         * Scripts/webkitdirs.pm:
1353         (buildQMakeProjects):
1354
1355 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1356
1357         [Qt] Add a configure step to the Qt build system
1358
1359         This allows building the Qt port using just 'qmake WebKit.pro'. Using
1360         the build-webkit script is still supported, and will add slightly more
1361         logic to the build, such as detecting the need for clean or incremental
1362         builds.
1363
1364         Internally, the build system now uses a new variable, WEBKIT_CONFIG, for
1365         all things related to configuring the build, such as use/have/enable flags,
1366         and these are translated to defines in default_post. Project files should
1367         no longer check contains(DEFINES,...) to detect features, but use the new
1368         enable?(), use?(), and have?() functions. The no_webkit1 and no_webkit2
1369         options have been translated into WEBKIT_CONFIG options as well, and can
1370         be checked using build?().
1371
1372         Reviewed by Simon Hausmann.
1373
1374         * DumpRenderTree/qt/DumpRenderTree.pro:
1375         * MiniBrowser/qt/MiniBrowser.pro:
1376         * QtTestBrowser/QtTestBrowser.pro:
1377         * Scripts/build-webkit:
1378         * Scripts/webkitdirs.pm:
1379         (qtFeatureDefaults):
1380         (buildQMakeProjects):
1381         * Tools.pro:
1382         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
1383         * WebKitTestRunner/InjectedBundle/Target.pri:
1384         * WebKitTestRunner/Target.pri:
1385         * qmake/.qmake.cache: Added.
1386         * qmake/configure.pri: Removed.
1387         * qmake/configure.pro: Removed.
1388         * qmake/dump-features: Added.
1389         * qmake/mkspecs/features/configure.prf: Added.
1390         * qmake/mkspecs/features/default_post.prf:
1391         * qmake/mkspecs/features/default_pre.prf:
1392         * qmake/mkspecs/features/features.prf:
1393         * qmake/mkspecs/features/features.pri:
1394         * qmake/mkspecs/features/functions.prf:
1395         * qmake/mkspecs/features/gprof.prf:
1396         * qmake/mkspecs/features/mac/default_pre.prf:
1397         * qmake/mkspecs/features/win32/default_pre.prf:
1398
1399 2012-09-11  Christophe Dumez  <christophe.dumez@intel.com>
1400
1401         [WK2][WKTR] TestRunner needs to implement clearApplicationCacheForOrigin
1402         https://bugs.webkit.org/show_bug.cgi?id=96372
1403
1404         Reviewed by Kenneth Rohde Christiansen.
1405
1406         Implement clearApplicationCacheForOrigin() in WebKitTestRunner.
1407
1408         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1409         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1410         (WTR::TestRunner::clearApplicationCacheForOrigin):
1411         (WTR):
1412         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1413         (TestRunner):
1414
1415 2012-09-11  Peter Beverloo  <peter@chromium.org>
1416
1417         Don't ignore .pak files when making an archive for Android
1418         https://bugs.webkit.org/show_bug.cgi?id=96375
1419
1420         Reviewed by Jochen Eisinger.
1421
1422         The .pak files do need to be pushed to the device, which is currently
1423         preventing the layout test runner from correctly pushing all files.
1424
1425         * BuildSlaveSupport/built-product-archive:
1426         (archiveBuiltProduct):
1427
1428 2012-09-11  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1429
1430         [WK2][WTR] WebKitTestRunner needs layoutTestController.setMinimumTimerInterval
1431         https://bugs.webkit.org/show_bug.cgi?id=96256
1432
1433         Reviewed by Kenneth Rohde Christiansen.
1434
1435         Exported TestRunner::setMinimumTimerInterval() method.
1436
1437         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1438         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1439         (WTR::InjectedBundle::beginTesting):
1440         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1441         (WTR::TestRunner::setMinimumTimerInterval):
1442         (WTR):
1443         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1444         (TestRunner):
1445
1446 2012-09-11  Tommy Widenflycht  <tommyw@google.com>
1447
1448         MediaStream API: add RTCPeerConnection::onnegotiationneeded
1449         https://bugs.webkit.org/show_bug.cgi?id=96097
1450
1451         Reviewed by Adam Barth.
1452
1453         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
1454         (MockWebRTCPeerConnectionHandler::addStream):
1455         (MockWebRTCPeerConnectionHandler::removeStream):
1456
1457 2012-09-11  Peter Beverloo  <peter@chromium.org>
1458
1459         Recognize the "--chromium-android" argument in run-webkit-tests
1460         https://bugs.webkit.org/show_bug.cgi?id=96369
1461
1462         Reviewed by Jochen Eisinger.
1463
1464         Chromium for the Android platform cannot determine the platform based on
1465         the host itself, so we'll use the --chromium-android argument as the build
1466         master passes to run-webkit-tests. Make sure the layout test runner
1467         can pick the right port when doing so.
1468
1469         * Scripts/run-webkit-tests:
1470         * Scripts/webkitpy/layout_tests/port/factory.py:
1471         (port_options):
1472
1473 2012-09-11  Simon Hausmann  <simon.hausmann@nokia.com>
1474
1475         [QT] Fix build with newer qmake from Qt 5
1476
1477         Rubber-stamped by Tor Arne Vestbø.
1478
1479         Support for "qmake -query QMAKE_MKSPECS" was removed from qmake. Replace
1480         it with the use of QT_HOST_DATA/mkspecs.
1481         Based on patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com>.
1482
1483         * Scripts/webkitdirs.pm:
1484         (builtDylibPathForName):
1485         (qtMakeCommand):
1486
1487 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1488
1489         [Qt] Remove Qt 4 syncqt, no longer needed
1490
1491         Reviewed by Simon Hausmann.
1492
1493         * qmake/syncqt-4.8: Removed.
1494
1495 2012-09-11  Andras Becsi  <andras.becsi@nokia.com>
1496
1497         [Qt][WK2] Fix the build with recent Qt5
1498         https://bugs.webkit.org/show_bug.cgi?id=96283
1499
1500         Reviewed by Simon Hausmann.
1501
1502         We should not use deprecated Qt API because doing that results
1503         in build failure since all the deprecated API was disabled
1504         in qtbase (https://codereview.qt-project.org/#change,24890).
1505
1506         * DumpRenderTree/qt/main.cpp:
1507         (main):
1508         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1509         (MiniBrowserApplication::notify):
1510         * MiniBrowser/qt/raw/View.cpp:
1511         (View::exposeEvent):
1512         (main):
1513
1514 2012-09-11  Christophe Dumez  <christophe.dumez@intel.com>
1515
1516         WTR needs an implementation of applicationCacheDiskUsageForOrigin
1517         https://bugs.webkit.org/show_bug.cgi?id=87188
1518
1519         Reviewed by Kenneth Rohde Christiansen.
1520
1521         Add implementation for applicationCacheDiskUsageForOrigin()
1522         in WebKitTestRunner.
1523
1524         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1525         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1526         (WTR::TestRunner::applicationCacheDiskUsageForOrigin):
1527         (WTR):
1528         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1529         (TestRunner):
1530
1531 2012-09-10  Joanmarie Diggs  <jdiggs@igalia.com>
1532
1533         Properly expose <legend> elements to ATs
1534         https://bugs.webkit.org/show_bug.cgi?id=84137
1535
1536         Reviewed by Chris Fleizach.
1537
1538         Created a new WebCore Accessibility Role, LegendRole. Used it to map to
1539         the expected platform role, ATK_ROLE_LABEL. Also established the needed
1540         AtkRelation pair, label-for/labelled-by between the legend and fieldset.
1541
1542         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
1543         (roleToString): added "Legend" string for WebAccessibilityRoleLegend
1544
1545 2012-09-10  Jer Noble  <jer.noble@apple.com>
1546
1547         Unreviewed; rolling out r128081.
1548         http://trac.webkit.org/changeset/128081
1549         https://bugs.webkit.org/show_bug.cgi?id=96134
1550
1551         New test http/tests/media/video-donottrack.html fails to run on Apple test bots.
1552
1553         * DumpRenderTree/TestRunner.cpp:
1554         (TestRunner::TestRunner):
1555         (TestRunner::staticFunctions):
1556         * DumpRenderTree/TestRunner.h:
1557         (TestRunner):
1558         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1559         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1560         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1561         (WTR::InjectedBundlePage::InjectedBundlePage):
1562         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1563         (InjectedBundlePage):
1564         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1565         (WTR::TestRunner::TestRunner):
1566         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1567         (TestRunner):
1568
1569 2012-09-10  Christophe Dumez  <christophe.dumez@intel.com>
1570
1571         TestExpectationsChecker._determine_port_from_expectations_path() does not support cascaded TestExpectations
1572         https://bugs.webkit.org/show_bug.cgi?id=96205
1573
1574         Reviewed by Tony Chang.
1575
1576         _determine_port_from_expectations_path() was calling port.path_to_test_expectations_file()
1577         internally, which means that it would support only 1 TestExpectations file per port. This
1578         is an issue for ports such as EFL that support cascased TestExpectations (efl-wk2 -> efl
1579         and efl-wk1 -> efl).
1580
1581         This patch makes _determine_port_from_expectations_path() call port.expectations_files()
1582         instead so that all the ports TestExpectations are recognized. The ports are also
1583         constructed twice, with "webkit_test_runner" option set to True and False so that we
1584         retrieve the TestExpectations paths for both WebKit1 and WebKit2.
1585
1586         * Scripts/webkitpy/style/checkers/test_expectations.py:
1587         (TestExpectationsChecker._determine_port_from_expectations_path):
1588         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Add corresponding unit test.
1589         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
1590
1591 2012-09-10  Ryuan Choi  <ryuan.choi@samsung.com>
1592
1593         [WTR] Generated source files should include config.h
1594         https://bugs.webkit.org/show_bug.cgi?id=96254
1595
1596         Reviewed by Benjamin Poulain.
1597
1598         Current coding style has encouraged to include config.h at the first position,
1599         But derived sources, generated by CodeGeneratorTestRunner.pm, don't follow
1600         this rule.
1601         Therefore, this patch added it.
1602
1603         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
1604         (_generateImplementationFile):
1605
1606 2012-09-10  Rick Byers  <rbyers@chromium.org>
1607
1608         Add handling of new GestureTapCancel in DRT
1609         
1610         https://bugs.webkit.org/show_bug.cgi?id=96183
1611
1612         Reviewed by Adam Barth.
1613
1614         * DumpRenderTree/chromium/TestWebPlugin.cpp:
1615         (TestWebPlugin::handleInputEvent):
1616
1617 2012-09-10  Brady Eidson  <beidson@apple.com>
1618
1619         Javascript in foreground tabs should not wait synchronously for plug-ins to load
1620         <rdar://problem/12067415> and https://bugs.webkit.org/show_bug.cgi?id=96167
1621
1622         Reviewed by Geoff Garen.
1623
1624         Enhance the "Slow NPP_New" plug-in to also be able to return properties to javascript.
1625
1626         * DumpRenderTree/TestNetscapePlugIn/Tests/SlowNPPNew.cpp:
1627         (PluginObject):
1628         (SlowNPPNew::PluginObject::PluginObject):
1629         (SlowNPPNew::PluginObject::~PluginObject):
1630         (SlowNPPNew::PluginObject::hasProperty):
1631         (SlowNPPNew::PluginObject::getProperty):
1632         (SlowNPPNew::NPP_GetValue):
1633         (SlowNPPNew):
1634
1635 2012-09-10  Tim Horton  <timothy_horton@apple.com>
1636
1637         WKTR often reports an unresponsive WebProcess on Mac bots
1638         https://bugs.webkit.org/show_bug.cgi?id=95906
1639
1640         Reviewed by Dan Bernstein.
1641
1642         Attempt to work around resource contention issues by increasing the NRWT
1643         timeout when running against WKTR, as well as WKTR's own WebProcess timeout.
1644
1645         * Scripts/webkitpy/layout_tests/port/base.py:
1646         (Port.default_timeout_ms): Default timeout when using WKTR -> 80 seconds.
1647         * WebKitTestRunner/TestController.cpp:
1648         (WTR): LongTimeout (used when waiting for WebProcess to finish) -> 60 seconds.
1649
1650 2012-09-07  Jer Noble  <jer.noble@apple.com>
1651
1652         <audio> and <video> should send Do Not Track when appropriate
1653         https://bugs.webkit.org/show_bug.cgi?id=96134
1654
1655         Reviewed by Eric Carlson.
1656
1657         Add a testRunner JS API for calling setShouldSendDoNotTrackHTTPHeader to DRT and 
1658         WTR. Add FrameLoaderClient client methods for retrieving that value.
1659
1660         * DumpRenderTree/TestRunner.cpp:
1661         (setShouldSendDoNotTrackHTTPHeaderCallback): Pass through to the TestRunner.
1662         (TestRunner::staticFunctions): Add the setShouldSendDoNotTrackHTTPHeader function.
1663         * DumpRenderTree/TestRunner.h:
1664         (TestRunner::setShouldSendDoNotTrackHTTPHeader): Simple setter.
1665         (TestRunner::shouldSendDoNotTrackHTTPHeader): Simple getter.
1666         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1667         (-[FrameLoadDelegate webViewShouldSendDoNotTrackHTTPHeader:]): 
1668             Pass the question on to the TestRunner.
1669         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1670         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1671         (WTR::InjectedBundlePage::InjectedBundlePage):
1672             Add the setShouldSendDoNotTrackHTTPHeader client function.
1673         (WTR::InjectedBundlePage::shouldSendDoNotTrackHTTPHeader):
1674             Pass the question on to the TestRunner.
1675         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1676         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1677         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1678         (WTR::TestRunner::shouldSendDoNotTrackHTTPHeader): Simple getter.
1679         (WTR::TestRunner::setShouldSendDoNotTrackHTTPHeader): Simple Setter.
1680
1681 2012-09-10  Ojan Vafai  <ojan@chromium.org>
1682
1683         Make EFL bots work on the flakiness dashboard
1684         https://bugs.webkit.org/show_bug.cgi?id=96164
1685
1686         Reviewed by Tony Chang.
1687
1688         Also, update outdated unittests that had started failing.
1689
1690         * TestResultServer/static-dashboards/builders.js:
1691         (isWebkitTestRunner):
1692         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1693         (nonChromiumPlatform):
1694         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1695         (test):
1696
1697 2012-09-10  Tommy Widenflycht  <tommyw@google.com>
1698
1699         [chromium] MediaStream API: Remove the Descriptor postfix
1700         https://bugs.webkit.org/show_bug.cgi?id=96268
1701
1702         Reviewed by Adam Barth.
1703
1704         After consideration I realized that there is no need whatsoever in using the Descriptor prefix
1705         in the WekKit embedder API. Removed from WebRTCSessionDescription and WebRTCICECandidate to start with.
1706
1707         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
1708         (RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
1709         (MockWebRTCPeerConnectionHandler::createOffer):
1710         (MockWebRTCPeerConnectionHandler::createAnswer):
1711         (MockWebRTCPeerConnectionHandler::setLocalDescription):
1712         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
1713         (MockWebRTCPeerConnectionHandler::localDescription):
1714         (MockWebRTCPeerConnectionHandler::remoteDescription):
1715         (MockWebRTCPeerConnectionHandler::addICECandidate):
1716         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
1717         (MockWebRTCPeerConnectionHandler):
1718
1719 2012-09-10  Arnaud Renevier  <a.renevier@sisa.samsung.com>
1720
1721         [Gtk] failure to build jhbuild dependencies with cups 1.6
1722         https://bugs.webkit.org/show_bug.cgi?id=95991
1723
1724         Reviewed by Gustavo Noronha Silva.
1725
1726         Bump gtk+ and gnome-themes-standard dependencies to 3.4.2 to allow
1727         building with cups >= 1.6 [GNOME #670373].
1728
1729         * gtk/jhbuild.modules:
1730
1731 2012-09-10  Christophe Dumez  <christophe.dumez@intel.com>
1732
1733         [EFL][DRT] Encoding issue in printed console messages
1734         https://bugs.webkit.org/show_bug.cgi?id=96263
1735
1736         Reviewed by Kenneth Rohde Christiansen.
1737
1738         Correctly handle CONSOLE messages that contain non-ascii
1739         characters in EFL's DRT. We need to use String::fromUTF8()
1740         to construct a WTF::String from a raw string.
1741
1742         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
1743         (onConsoleMessage):
1744
1745 2012-09-10  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1746
1747         [WK2][WTR] User style sheet location should be reset before each test
1748         https://bugs.webkit.org/show_bug.cgi?id=96262
1749
1750         Reviewed by Kenneth Rohde Christiansen.
1751
1752         User style sheet location is reset before each test now.
1753
1754         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1755         (WTR::InjectedBundle::beginTesting):
1756
1757 2012-09-10  Simon Hausmann  <simon.hausmann@nokia.com>
1758
1759         Fix build of WTR with Qt on Windows
1760         https://bugs.webkit.org/show_bug.cgi?id=96249
1761
1762         Reviewed by Kenneth Rohde Christiansen.
1763
1764         Windows loves to define min and max as macros, which beautifully
1765         clashes in many places where min and max are used as variable or method
1766         names. It can be convinced not to do this when min and max are already
1767         define as macros (expanding to themselves). We have this kind of
1768         workaround in config.h files all over WebKit and as it turns out when
1769         building WTR with Qt on Windows we do end up with such a clash. Therefore
1770         we need the same workaround.
1771
1772         * WebKitTestRunner/config.h:
1773
1774 2012-09-10  Christophe Dumez  <christophe.dumez@intel.com>
1775
1776         [WK2] New fast/forms/number/number-interactive-validation-required.html fails
1777         https://bugs.webkit.org/show_bug.cgi?id=95936
1778
1779         Reviewed by Kenneth Rohde Christiansen.
1780
1781         Enable interactive form validation setting in WebKitTestRunner as
1782         we are currently doing in DumpRenderTree. This is needed for some
1783         tests to pass.
1784
1785         * WebKitTestRunner/TestController.cpp:
1786         (WTR::TestController::resetStateToConsistentValues):
1787
1788 2012-09-09  Zan Dobersek  <zandobersek@gmail.com>
1789
1790         Clean up the code in XvfbDriver
1791         https://bugs.webkit.org/show_bug.cgi?id=96202
1792
1793         Reviewed by Philippe Normand.
1794
1795         Changes:
1796         - Remove unneeded imports,
1797         - assign the _lock_file member variable when the display number is determined,
1798         - no need for parentheses around a single string format argument,
1799         - use FileSystem.exists method when checking if lock file is present as it
1800         makes the intention much more clearer.
1801
1802         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
1803         (XvfbDriver._start):
1804         (XvfbDriver.stop):
1805
1806 2012-09-09  Patrick Gansterer  <paroga@webkit.org>
1807
1808         Make the String initialization on the function side of String::number()
1809         https://bugs.webkit.org/show_bug.cgi?id=95940
1810
1811         Reviewed by Benjamin Poulain.
1812
1813         * TestWebKitAPI/Tests/WTF/IntegerToStringConversion.cpp:
1814         (testBoundaries):
1815         (testNumbers):
1816
1817 2012-09-09  Pierre Rossi  <pierre.rossi@gmail.com>
1818
1819         [WK2] expose element rect for color input type
1820         https://bugs.webkit.org/show_bug.cgi?id=91664
1821
1822         Reviewed by Simon Hausmann.
1823
1824         Update the QML logic in MiniBrowser to take advantage of this.
1825         The picker size is now hardcoded and we try to place it below the
1826         input element if possible.
1827
1828         * MiniBrowser/qt/qml/ColorChooser.qml:
1829
1830 2012-09-08  Christophe Dumez  <christophe.dumez@intel.com>
1831
1832         [WK2] New fast/events/tab-focus-link-in-canvas fails from r126908
1833         https://bugs.webkit.org/show_bug.cgi?id=95329
1834
1835         Reviewed by Kenneth Rohde Christiansen.
1836
1837         Explicitely disable TabToLinks setting in WebKitTestRunner.
1838         Tests override the "WebKitTabToLinksPreferenceKey" preference
1839         to enable it.
1840
1841         * WebKitTestRunner/TestController.cpp:
1842         (WTR::TestController::resetStateToConsistentValues):
1843
1844 2012-09-08  Kenichi Ishibashi  <bashi@chromium.org>
1845
1846         webkit.py gdb pretty printer can't print CString
1847         https://bugs.webkit.org/show_bug.cgi?id=96068
1848
1849         Reviewed by Tony Chang.
1850
1851         Update WTFCStringPrinter to follow r126191.
1852
1853         * gdb/webkit.py:
1854         (WTFCStringPrinter.to_string):
1855
1856 2012-09-07  Benjamin Poulain  <bpoulain@apple.com>
1857
1858         Rename the ustring() accessor to string()
1859         https://bugs.webkit.org/show_bug.cgi?id=95919
1860
1861         Reviewed by Geoffrey Garen.
1862
1863         Update EFL's DRT.
1864
1865         Fix some string conversion that have been made useless
1866         with recent changes.
1867
1868         * DumpRenderTree/efl/EventSender.cpp:
1869         (keyPadNameFromJSValue):
1870         (keyNameFromJSValue):
1871         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1872         (TestRunner::queueLoad):
1873         (TestRunner::addOriginAccessWhitelistEntry):
1874         (TestRunner::removeOriginAccessWhitelistEntry):
1875         (TestRunner::setUserStyleSheetLocation):
1876         (TestRunner::setValueForUser):
1877         (TestRunner::elementDoesAutoCompleteForElementWithId):
1878         (TestRunner::execCommand):
1879         (TestRunner::findString):
1880         (TestRunner::isCommandEnabled):
1881         (TestRunner::clearApplicationCacheForOrigin):
1882         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
1883         (TestRunner::pauseAnimationAtTimeOnElementWithId):
1884         (TestRunner::pauseTransitionAtTimeOnElementWithId):
1885         (toInt):
1886         (TestRunner::overridePreference):
1887         (TestRunner::addUserScript):
1888         (TestRunner::addUserStyleSheet):
1889         (TestRunner::evaluateInWebInspector):
1890         (TestRunner::evaluateScriptInIsolatedWorld):
1891         (TestRunner::setTextDirection):
1892         * DumpRenderTree/efl/WorkQueueItemEfl.cpp:
1893         (LoadItem::invoke):
1894         (LoadHTMLStringItem::invoke):
1895         (ScriptItem::invoke):
1896
1897 2012-09-06  Jeffrey Pfau  <jpfau@apple.com>
1898
1899         Extend third-party storage blocking API to optionally allow blocking all storage
1900         https://bugs.webkit.org/show_bug.cgi?id=95915
1901
1902         Reviewed by Brady Eidson.
1903
1904         Modified API test to use new revised API.
1905
1906         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
1907         (TestWebKitAPI::TEST):
1908
1909 2012-09-07  Dominic Mazzoni  <dmazzoni@google.com>
1910
1911         AX: WebCore accessibility roles should be cross-platform
1912         https://bugs.webkit.org/show_bug.cgi?id=94870
1913
1914         Reviewed by Chris Fleizach.
1915
1916         Add debug strings to Chromium for new accessibility roles.
1917
1918         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
1919         (roleToString):
1920
1921 2012-09-07  Dominic Mazzoni  <dmazzoni@google.com>
1922
1923         AX: Chromium needs access to canvasHasFallbackContent
1924         https://bugs.webkit.org/show_bug.cgi?id=96124
1925
1926         Reviewed by Chris Fleizach.
1927
1928         Distinguish between canvas roles with and without fallback
1929         content on Chromium.
1930
1931         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
1932         (getRole):
1933
1934 2012-09-07  Ojan Vafai  <ojan@chromium.org>
1935
1936         Handle non-existant TestExpectations files gracefully
1937         https://bugs.webkit.org/show_bug.cgi?id=96149
1938
1939         Reviewed by Eric Seidel.
1940
1941         Even when we get rid of Skipped files, we shouldn't have each port
1942         require a TestExpectations file for each platform if it doesn't
1943         need one.
1944
1945         * Scripts/webkitpy/layout_tests/port/base.py:
1946         (Port.expectations_dict):
1947         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1948         (PortTest.test_nonexistant_expectations):
1949
1950 2012-09-07  Tony Chang  <tony@chromium.org>
1951
1952         Regression: check-webkit-style no longer checks TestExpectations for syntax errors
1953         https://bugs.webkit.org/show_bug.cgi?id=96136
1954
1955         Reviewed by Ojan Vafai.
1956
1957         When we renamed the file to TestExpectations, it was no longer considered a text file so
1958         it was no longer being checked. Since then, test_expectations_overrides() has been removed
1959         from the port object, so I've removed that from the check. I'm not sure what it was
1960         supposed to do.
1961
1962         * Scripts/webkitpy/style/checker.py:
1963         (CheckerDispatcher._file_type): Mark TestExpectations as a text file.
1964         * Scripts/webkitpy/style/checkers/test_expectations.py:
1965         (TestExpectationsChecker.check_test_expectations): Remove overrides param.
1966         (TestExpectationsChecker.check): Remove overrides param.
1967         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1968         (TestExpectationsTestCase.assert_lines_lint): Remove overrides param.
1969
1970 2012-09-07  Christophe Dumez  <christophe.dumez@intel.com>
1971
1972         [EFL] Use same default minimum logical font size in DRT and WTR
1973         https://bugs.webkit.org/show_bug.cgi?id=96116
1974
1975         Reviewed by Martin Robinson.
1976
1977         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1978         (DumpRenderTreeChrome::resetDefaultsToConsistentValues): Set minimum
1979         logical font size to 9 to match the value used in WTR.
1980         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1981         (WTR::InjectedBundle::beginTesting): Explicitly set the minimum
1982         logical font size to 9 (default value in WK2)
1983
1984 2012-09-07  Tommy Widenflycht  <tommyw@google.com>
1985
1986         MediaStream API: add RTCPeerConnection::createAnswer
1987         https://bugs.webkit.org/show_bug.cgi?id=96092
1988
1989         Reviewed by Adam Barth.
1990
1991         Expanding and enhancing MockWebRTCPeerConnectionHandler.
1992
1993         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
1994         (MockWebRTCPeerConnectionHandler::createOffer):
1995         (MockWebRTCPeerConnectionHandler::createAnswer):
1996         (MockWebRTCPeerConnectionHandler::setLocalDescription):
1997         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
1998         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
1999         (MockWebRTCPeerConnectionHandler):
2000
2001 2012-09-07  Dean Jackson  <dino@apple.com>
2002
2003         Unreviewed changes to watchlist.
2004
2005         - Add new WebGL and Filters definitions
2006         - Add myself to OpenGL bugs
2007
2008         * Scripts/webkitpy/common/config/watchlist:
2009
2010 2012-09-07  Peter Beverloo  <peter@chromium.org>
2011
2012         Actually trigger the Android Tester
2013         https://bugs.webkit.org/show_bug.cgi?id=96118
2014
2015         Reviewed by Adam Barth.
2016
2017         * BuildSlaveSupport/build.webkit.org-config/config.json:
2018
2019 2012-09-07  Dominic Mazzoni <dmazzoni@google.com>
2020
2021         New time input needs accessibility
2022         https://bugs.webkit.org/show_bug.cgi?id=96032
2023
2024         Reviewed by Chris Fleizach.
2025
2026         Add support for valueDescription for testing.
2027
2028         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
2029         (getValueDescription):
2030         (AccessibilityUIElement::AccessibilityUIElement):
2031         (AccessibilityUIElement::valueDescriptionGetterCallback):
2032         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.h:
2033         (AccessibilityUIElement):
2034
2035 2012-09-07  Peter Beverloo  <peter@chromium.org>
2036
2037         Add the google-android-tests build slave to the master's config
2038         https://bugs.webkit.org/show_bug.cgi?id=96113
2039
2040         Reviewed by Csaba Osztrogonác.
2041
2042         * BuildSlaveSupport/build.webkit.org-config/config.json:
2043
2044 2012-09-07  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2045
2046         [WK2] [EFL] Set theme for WebKit2 API test runner
2047         https://bugs.webkit.org/show_bug.cgi?id=96100
2048
2049         Reviewed by Kenneth Rohde Christiansen.
2050
2051         Set the theme generated by the build for the WebKit2 API test runner.
2052
2053         * TestWebKitAPI/PlatformEfl.cmake:
2054         * TestWebKitAPI/efl/PlatformWebView.cpp:
2055         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2056
2057 2012-09-07  Csaba Osztrogonác  <ossy@webkit.org>
2058
2059         Unreviewed. Add Gábor Ballabás as contributor.
2060
2061         * Scripts/webkitpy/common/config/committers.py:
2062
2063 2012-09-07  Zoltan Arvai  <zarvai@inf.u-szeged.hu>
2064
2065         [Qt] Fix ROOT_BUILD_DIR on Windows MSVC build.
2066         https://bugs.webkit.org/show_bug.cgi?id=96078
2067
2068         Reviewed by Tor Arne Vestbø.
2069
2070         Correct JSC, DumpRenderTree, ImageDiff, QtTestBrowser binaries location by adding $$toSystemPath to ROOT_BUILD_DIR generation.
2071
2072         * qmake/mkspecs/features/default_pre.prf:
2073
2074 2012-09-07  Christophe Dumez  <christophe.dumez@intel.com>
2075
2076         [EFL] Add TestExpectations file for efl-wk1
2077         https://bugs.webkit.org/show_bug.cgi?id=96019
2078
2079         Reviewed by Gyuyoung Kim.
2080
2081         Update TestExpectations cascading for EFL port
2082         so that we use efl-wk1 -> efl search paths
2083         for WebKit1 EFL.
2084
2085         * Scripts/webkitpy/layout_tests/port/efl.py:
2086         (EflPort._search_paths):
2087
2088 2012-09-07  Zan Dobersek  <zandobersek@gmail.com>
2089
2090         [NRWT] XvfbDriver should stop the Xvfb more aggressively
2091         https://bugs.webkit.org/show_bug.cgi?id=95097
2092
2093         Reviewed by Dirk Pranke.
2094
2095         The Xvfb process is now killed when the XvfbDriver is stopping. Simply
2096         terminating the process does not always work as expected, leading to timeouts
2097         in run-webkit-tests on the buildbot. The lock file Xvfb creates is also removed
2098         as it's not removed by the killed Xvfb process.
2099
2100         Also included is a thorough unittest for XvfbDriver. Proper starting of the driver
2101         is tested in different circumstances - whether pixel tests are enabled or not,
2102         with an arbitrary worker number or with an Xorg process already running on the system.
2103         The stopping of the driver is tested by checking that the Xvfb process is truly killed
2104         and then set to None.
2105
2106         * BuildSlaveSupport/kill-old-processes:
2107         Kill any stale Xvfb processes at the start of the build cycle so no Xvfb
2108         is left running, potentially clogging up a display at a certain position.
2109         * Scripts/webkitpy/common/system/executive_mock.py:
2110         (MockExecutive.__init__):
2111         The _running_pids is now a dictionary with process names as keys and pids
2112         as values.
2113         (MockExecutive.check_running_pid):
2114         Check whether the passed-in pid is in the _running_pids dictionary's values.
2115         (MockExecutive):
2116         (MockExecutive.running_pids):
2117         This method returns the list of all the process pids of which the name passes
2118         through the process_name_filter.
2119         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
2120         Use the Executive object of the port's host to check for running pids and open
2121         new subprocesses or kill them throughout the class.
2122         (XvfbDriver._start):
2123         Use the _server_process_constructor to make testing the XvfbDriver possible. Also,
2124         start the server process after it's created.
2125         (XvfbDriver.stop):
2126         Now kills the Xvfb process instead of terminating it and waiting for it to close.
2127         * Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py: Added.
2128         (XvfbDriverTest):
2129         (XvfbDriverTest.make_driver):
2130         (XvfbDriverTest.assertDriverStartSuccessful):
2131         (XvfbDriverTest.test_start_no_pixel_tests):
2132         (XvfbDriverTest.test_start_pixel_tests):
2133         (XvfbDriverTest.test_start_arbitrary_worker_number):
2134         (XvfbDriverTest.test_start_existing_xorg_process):
2135         (XvfbDriverTest.test_stop):
2136         (XvfbDriverTest.test_stop.FakeXvfbProcess):
2137
2138 2012-09-06  Peter Beverloo  <peter@chromium.org>
2139
2140         Introduce the Chromium Android Release (Tests) bot
2141         https://bugs.webkit.org/show_bug.cgi?id=95980
2142
2143         Reviewed by Adam Barth.
2144
2145         This adds the Chromium Android Release (Tests) bot to the WebKit waterfall,
2146         which will be running layout tests on actual Android devices. Right now,
2147         four Galaxy Nexus phones are attached.
2148
2149         * BuildSlaveSupport/build.webkit.org-config/config.json:
2150
2151 2012-09-06  James Robinson  <jamesr@chromium.org>
2152
2153         [chromium] Use WebCompositorSupport functions instead of WebCompositor statics
2154         https://bugs.webkit.org/show_bug.cgi?id=96007
2155
2156         Reviewed by Adrienne Walker.
2157
2158         Fixes initialization / settings code to use WebCompositorSupport.
2159
2160         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2161         (main):
2162         * DumpRenderTree/chromium/TestShell.cpp:
2163         (TestShell::initialize):
2164         (TestShell::setPerTilePaintingEnabled):
2165
2166 2012-09-06  Christophe Dumez  <christophe.dumez@intel.com>
2167
2168         [EFL][WK2] Provide implementation for PlatformWebView::windowFrame()
2169         https://bugs.webkit.org/show_bug.cgi?id=95995
2170
2171         Reviewed by Kenneth Rohde Christiansen.
2172
2173         Provide proper implementation for PlatformWebView::windowFrame()
2174         in EFL's WebKitTestRunner.
2175
2176         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2177         (WTR::PlatformWebView::windowFrame):
2178
2179 2012-09-06  Fady Samuel  <fsamuel@chromium.org>
2180
2181         Fix WTF.Lrint on 32-bit platforms
2182         https://bugs.webkit.org/show_bug.cgi?id=96003
2183
2184         Reviewed by Benjamin Poulain.
2185
2186         Fixed failing WTF.Lrint test on 32-bit platforms.
2187
2188         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2189         (TestWebKitAPI::TEST):
2190
2191 2012-09-06  Tommy Widenflycht  <tommyw@google.com>
2192
2193         MediaStream API: Add the local and remote description functionality to RTCPeerConnection
2194         https://bugs.webkit.org/show_bug.cgi?id=95839
2195
2196         Reviewed by Adam Barth.
2197
2198         In addition to adding the new methods to MockWebRTCPeerConnectionHandler I cleaned
2199         up the task definitions a bit. There was no need to have them in the header file.
2200
2201         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2202         (RTCSessionDescriptionRequestSuccededTask):
2203         (RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
2204         (RTCSessionDescriptionRequestFailedTask):
2205         (RTCSessionDescriptionRequestFailedTask::RTCSessionDescriptionRequestFailedTask):
2206         (RTCVoidRequestTask):
2207         (RTCVoidRequestTask::RTCVoidRequestTask):
2208         (MockWebRTCPeerConnectionHandler::createOffer):
2209         (MockWebRTCPeerConnectionHandler::setLocalDescription):
2210         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
2211         (MockWebRTCPeerConnectionHandler::localDescription):
2212         (MockWebRTCPeerConnectionHandler::remoteDescription):
2213         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
2214         (MockWebRTCPeerConnectionHandler):
2215
2216 2012-09-06  Simon Hausmann  <simon.hausmann@nokia.com>
2217
2218         [Qt] Fix build on Mac OS X 10.6
2219         https://bugs.webkit.org/show_bug.cgi?id=95200
2220
2221         Reviewed by Tor Arne Vestbø.
2222
2223         The build on Mac OS X 10.6 is broken when using QuickTime. Enable it only for
2224         10.7 and newer.
2225
2226         * qmake/mkspecs/features/features.prf:
2227
2228 2012-09-06  Christophe Dumez  <christophe.dumez@intel.com>
2229
2230         [WKTR] addSelectionKey should be mapped to "Control" modifiers on other OSes than Mac
2231         https://bugs.webkit.org/show_bug.cgi?id=95973
2232
2233         Reviewed by Kenneth Rohde Christiansen.
2234
2235         Correctly map "addSelectionKey" to "Control" modifier
2236         in WKTR's EventSender on other OSes than Mac OS X,
2237         instead of mapping it to the "Meta" modifier.
2238
2239         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2240         (WTR::parseModifier):
2241
2242 2012-09-06  Balazs Kelemen  <kbalazs@webkit.org>
2243
2244         [nrwt] Harden against empty stdout/stderr after stopping a crashed/timed out driver
2245         https://bugs.webkit.org/show_bug.cgi?id=95710
2246
2247         Reviewed by Dirk Pranke.
2248
2249         The stdout / stderr output can be None so make sure
2250         we won't raise an exception in this case.
2251
2252         * Scripts/webkitpy/layout_tests/port/driver.py:
2253         (Driver.run_test):
2254
2255 2012-09-06  Christophe Dumez  <christophe.dumez@intel.com>
2256
2257         [EFL] Sanitize URLs in EWebLauncher / Minibrowser
2258         https://bugs.webkit.org/show_bug.cgi?id=95849
2259
2260         Reviewed by Kenneth Rohde Christiansen.
2261
2262         Sanitize URLs passed by the user as program
2263         argument or typed in the URL bar in order to
2264         be more tolerant.
2265
2266         * EWebLauncher/CMakeLists.txt:
2267         * EWebLauncher/main.c:
2268         (main):
2269         * EWebLauncher/url_bar.c:
2270         (_url_bar_url_get_with_protocol):
2271         (on_urlbar_key_down):
2272         * EWebLauncher/url_utils.c: Added.
2273         (has_scheme):
2274         (url_from_user_input): Add utility function to construct a
2275         URL from user input.
2276         * EWebLauncher/url_utils.h: Added.
2277         * MiniBrowser/efl/CMakeLists.txt:
2278         * MiniBrowser/efl/main.c:
2279         (main):
2280
2281 2012-09-06  Simon Hausmann  <simon.hausmann@nokia.com>
2282
2283         [Qt] Various small Windows / MSVC build fixes
2284         https://bugs.webkit.org/show_bug.cgi?id=95934
2285
2286         Reviewed by Kenneth Rohde Christiansen.
2287
2288         setFocus takes a boolean as argument: Don't try to implicitly convert
2289         an enum to a boolean, MSVC doesn't like that. The intent here is to
2290         enable focus, so just pass true.
2291
2292         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2293         (WTR::PlatformWebView::focus):
2294
2295 2012-09-06  Simon Hausmann  <simon.hausmann@nokia.com>
2296
2297         [Qt] Fix build with ANGLE on platforms that provide EGL/GLESv2
2298         https://bugs.webkit.org/show_bug.cgi?id=95965
2299
2300         Reviewed by Tor Arne Vestbø.
2301
2302         Add ANGLE as a static library module to the Qt WebKit build system.
2303
2304         * qmake/mkspecs/features/default_post.prf:
2305         * qmake/mkspecs/modules/angle.prf: Added.
2306
2307 2012-09-06  Andras Becsi  <andras.becsi@nokia.com>
2308
2309         [WK2] Make [Qt]ViewportHandler cross platform
2310         https://bugs.webkit.org/show_bug.cgi?id=91257
2311
2312         Reviewed by Kenneth Rohde Christiansen.
2313
2314         Remove initial scale from viewport info item since it is
2315         set to -1 after applied thus it does not hold any valuable
2316         information.
2317
2318         * MiniBrowser/qt/qml/ViewportInfoItem.qml:
2319
2320 2012-09-05  Tony Chang  <tony@chromium.org>
2321
2322         [chromium] Remove dependency on webkit_user_agent
2323         https://bugs.webkit.org/show_bug.cgi?id=95886
2324
2325         Reviewed by Adam Barth.
2326
2327         The code isn't used by DumpRenderTree.
2328
2329         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2330
2331 2012-09-05  Rick Byers  <rbyers@chromium.org>
2332
2333         Update chromium DumpRenderTree for new WebGestureEvent fields
2334         https://bugs.webkit.org/show_bug.cgi?id=95573
2335
2336         Reviewed by James Robinson.
2337
2338         Update EventSender to write gesture details into the appropriate
2339         type-specific WebGestureEvent fields.
2340         * DumpRenderTree/chromium/TestRunner/EventSender.cpp:
2341         (EventSender::gestureEvent):
2342         (EventSender::gestureFlingStart):
2343
2344 2012-09-05  Dirk Pranke  <dpranke@chromium.org>
2345
2346         NRWT lies about the number of tests that it's skipping when used with --repeat-each
2347         https://bugs.webkit.org/show_bug.cgi?id=95789
2348
2349         Reviewed by Ojan Vafai.
2350
2351         Fix miscalculation in log message.
2352
2353         * Scripts/webkitpy/layout_tests/views/printing.py:
2354         (Printer.print_found):
2355
2356 2012-09-05  Kenichi Ishibashi  <bashi@chromium.org>
2357
2358         Unreviewed, rolling out r127612, r127660, and r127664.
2359         http://trac.webkit.org/changeset/127612
2360         http://trac.webkit.org/changeset/127660
2361         http://trac.webkit.org/changeset/127664
2362         https://bugs.webkit.org/show_bug.cgi?id=95920
2363
2364         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2365         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::SuccessCallbackTask):
2366         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::runIfValid):
2367         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::FailureCallbackTask):
2368         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::runIfValid):
2369         (MockWebRTCPeerConnectionHandler::createOffer):
2370         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
2371         (MockWebRTCPeerConnectionHandler):
2372         (SuccessCallbackTask):
2373         (FailureCallbackTask):
2374
2375 2012-09-05  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
2376
2377         Ignore-metrics includes scroll offsets.
2378         https://bugs.webkit.org/show_bug.cgi?id=95845
2379
2380         Reviewed by Dirk Pranke.
2381
2382         Strip scroll-offsets the same way scroll-height and scroll-width is stripped.
2383
2384         * Scripts/old-run-webkit-tests:
2385         (stripMetrics):
2386         * Scripts/webkitpy/layout_tests/port/driver.py:
2387         (DriverOutput):
2388
2389 2012-09-05  Zan Dobersek  <zandobersek@gmail.com>
2390
2391         Unreviewed test fix.
2392
2393         Including a plugin source file into the build that was added in r127595.
2394
2395         * GNUmakefile.am:
2396
2397 2012-09-05  Tommy Widenflycht  <tommyw@google.com>
2398
2399         MediaStream API: Add the local and remote description functionality to RTCPeerConnection
2400         https://bugs.webkit.org/show_bug.cgi?id=95839
2401
2402         Reviewed by Adam Barth.
2403
2404         In addition to adding the new methods to MockWebRTCPeerConnectionHandler I cleaned
2405         up the task definitions a bit. There was no need to have them in the header file.
2406
2407         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2408         (RTCSessionDescriptionRequestSuccededTask):
2409         (RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
2410         (RTCSessionDescriptionRequestFailedTask):
2411         (RTCSessionDescriptionRequestFailedTask::RTCSessionDescriptionRequestFailedTask):
2412         (RTCVoidRequestTask):
2413         (RTCVoidRequestTask::RTCVoidRequestTask):
2414         (MockWebRTCPeerConnectionHandler::createOffer):
2415         (MockWebRTCPeerConnectionHandler::setLocalDescription):
2416         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
2417         (MockWebRTCPeerConnectionHandler::localDescription):
2418         (MockWebRTCPeerConnectionHandler::remoteDescription):
2419         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
2420         (MockWebRTCPeerConnectionHandler):
2421
2422 2012-09-05  Kangil Han  <kangil.han@samsung.com>
2423
2424         [EFL] Remove '+=' usage in String
2425         https://bugs.webkit.org/show_bug.cgi?id=95808
2426
2427         Reviewed by Benjamin Poulain.
2428
2429         Replaced use of String operator '+=' with StringBuilder.append*() in order to adopt efficient String concatenation.
2430
2431         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2432         (descriptionSuitableForTestResult):
2433
2434 2012-09-05  Christophe Dumez  <christophe.dumez@intel.com>
2435
2436         [EFL][WK2] Provide implementation for TestRunner::pathToLocalResource()
2437         https://bugs.webkit.org/show_bug.cgi?id=95842
2438
2439         Reviewed by Kenneth Rohde Christiansen.
2440
2441         Provide proper implementation for TestRunner::pathToLocalResource()
2442         in EFL WKTR, identical to the one for DumpRenderTree.
2443
2444         Map /tmp to ${DUMPRENDERTREE_TEMP} environment variable and
2445         /tmp/LayoutTests to ${LOCAL_RESOURCE_ROOT} so that local resources
2446         are found my WebKitTestRunner.
2447
2448         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
2449         (WTR::TestRunner::pathToLocalResource):
2450
2451 2012-09-05  Brady Eidson  <beidson@apple.com>
2452
2453         Frequent crashes in PluginView::scriptObject under runtimeObjectCustomGetOwnPropertySlot
2454         <rdar://problem/12142226> and https://bugs.webkit.org/show_bug.cgi?id=95026
2455
2456         Reviewed by Andy Estes.
2457
2458         Add a plug-in that always fails to initialize:
2459         * DumpRenderTree/TestNetscapePlugIn/Tests/NPPNewFails.cpp: Added.
2460         (NPPNewFails):
2461         (NPPNewFails::NPPNewFails):
2462         (NPPNewFails::NPP_New):
2463
2464         Add it to all the project files:
2465         * DumpRenderTree/DumpRenderTree.gypi:
2466         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2467         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
2468         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2469         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2470
2471 2012-09-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2472
2473         [Qt] Fix makefile race condition between derived sources and target
2474
2475         r121966 removed too much of the old qmake logic, including the rule
2476         that ensured that qmake_all would not trigger dual runs of qmake --
2477         one of the derived sources -qmake-all rule, and one for making the
2478         derived sources.
2479
2480         We now follow a similar pattern as before, by introducing a custom
2481         target that explicitly depends on the derived sources' qmake-all before
2482         doing a manual run of make. That ensures a single qmake run for the derived
2483         sources.
2484
2485         https://bugs.webkit.org/show_bug.cgi?id=93847
2486
2487         Reviewed by Csaba Osztrogonác.
2488
2489         * qmake/mkspecs/features/functions.prf:
2490
2491 2012-09-05  Christophe Dumez  <christophe.dumez@intel.com>
2492
2493         WKTR doesn't implement dumpWillCacheResponse()
2494         https://bugs.webkit.org/show_bug.cgi?id=94607
2495
2496         Reviewed by Kenneth Rohde Christiansen.
2497
2498         Define shouldCacheResponse() callback in resource
2499         load client and provide implementation for
2500         dumpWillCacheResponse() in WebKitTestRunner.
2501
2502         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2503         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2504         (WTR::InjectedBundlePage::InjectedBundlePage):
2505         (WTR::InjectedBundlePage::shouldCacheResponse):
2506         (WTR):
2507         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2508         (InjectedBundlePage):
2509         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2510         (WTR::TestRunner::TestRunner):
2511         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2512         (WTR::TestRunner::dumpWillCacheResponse):
2513         (WTR::TestRunner::shouldDumpWillCacheResponse):
2514         (TestRunner):
2515
2516 2012-09-05  Kaustubh Atrawalkar  <kaustubh@motorola.com>
2517
2518         [DRT] LTC:: Move printing related APIs from LayoutTestController to Internals
2519         https://bugs.webkit.org/show_bug.cgi?id=92735
2520
2521         Reviewed by Hajime Morita.
2522
2523         Move numberOfPages, pageProperty & pageSizeAndMarginsInPixels in Internals and remove duplicated code from DumprenderTree & WebkitTestRunner.
2524
2525         * DumpRenderTree/TestRunner.cpp:
2526         (TestRunner::staticFunctions):
2527         * DumpRenderTree/TestRunner.h:
2528         (TestRunner):
2529         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
2530         (TestRunner::addUserStyleSheet):
2531         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2532         (DRTTestRunner::DRTTestRunner):
2533         (DRTTestRunner::hasCustomPageSizeStyle):
2534         * DumpRenderTree/chromium/DRTTestRunner.h:
2535         (DRTTestRunner):
2536         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2537         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
2538         * DumpRenderTree/mac/TestRunnerMac.mm:
2539         * DumpRenderTree/qt/TestRunnerQt.cpp:
2540         (TestRunner::evaluateScriptInIsolatedWorld):
2541         * DumpRenderTree/qt/TestRunnerQt.h:
2542         (TestRunner):
2543         * DumpRenderTree/win/TestRunnerWin.cpp:
2544         * DumpRenderTree/wx/TestRunnerWx.cpp:
2545         (TestRunner::abortModal):
2546         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2547         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2548         (WTR):
2549         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2550         (TestRunner):
2551
2552 2012-09-05  Simon Hausmann  <simon.hausmann@nokia.com>
2553
2554         [Qt] Automate the use of AllInOne files in the Qt build
2555         https://bugs.webkit.org/show_bug.cgi?id=95837
2556
2557         Reviewed by Tor Arne Vestbø.
2558
2559         New feature file that implements the all-in-one file automation by
2560         adding the requested all-in-one files to SOURCES and removing the files
2561         it includes from SOURCES.
2562
2563         * qmake/mkspecs/features/use_all_in_one_files.prf: Added.
2564
2565 2012-09-04  Tim Horton  <timothy_horton@apple.com>
2566
2567         Have NRWT log more output when crash logs are missing
2568         https://bugs.webkit.org/show_bug.cgi?id=95814
2569
2570         Reviewed by Dan Bernstein.
2571
2572         Log the stderr and stdout of the test, in order to provide slightly more
2573         context when the WebProcess times out while running tests.
2574
2575         * Scripts/webkitpy/layout_tests/port/driver.py:
2576         (Driver.run_test):
2577
2578 2012-09-04  Xianzhu Wang  <wangxianzhu@chromium.org>
2579
2580         [Chromium-Android] Include device serial number in ChromiumAndroidDriver log messages
2581         https://bugs.webkit.org/show_bug.cgi?id=95770
2582
2583         Reviewed by Adam Barth.
2584
2585         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2586         (ChromiumAndroidDriver.__init__):
2587         (ChromiumAndroidDriver._log_error): Added to replace original _log.error().
2588         (ChromiumAndroidDriver._log_debug): Added to replace original _log.debug().
2589         (ChromiumAndroidDriver._abort): Added to replace original raise AssertionError().
2590         (ChromiumAndroidDriver._push_executable):
2591         (ChromiumAndroidDriver._push_fonts):
2592         (ChromiumAndroidDriver._push_test_resources):
2593         (ChromiumAndroidDriver._run_adb_command):
2594         (ChromiumAndroidDriver._get_last_stacktrace):
2595         (ChromiumAndroidDriver._get_crash_log):
2596         (ChromiumAndroidDriver._start):
2597         (ChromiumAndroidDriver._start_once):
2598         (ChromiumAndroidDriver._start_once.deadlock_detector):
2599         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
2600         (ChromiumAndroidDriverTest.test_get_crash_log):
2601
2602 2012-09-04  Satish Sampath  <satish@chromium.org>
2603
2604         Run git commands within the checkout directory
2605         https://bugs.webkit.org/show_bug.cgi?id=95742
2606
2607         Reviewed by Eric Seidel.
2608
2609         git commands run from scm/git.py are sometimes run with cwd set to the
2610         checkout_root and other times with whatever directory was the default cwd.
2611         Instead all these should run with the checkout root set as the cwd
2612         (except where we explicitly need a different path)
2613
2614         * Scripts/webkitpy/common/checkout/scm/git.py:
2615         (Git._run_git):
2616         (Git.find_checkout_root):
2617         (Git.discard_local_commits):
2618         (Git.local_commits):
2619         (Git.working_directory_is_clean):
2620         (Git.clean_working_directory):
2621         (Git.add_list):
2622         (Git.delete_list):
2623         (Git.exists):
2624         (Git._current_branch):
2625         (Git._changes_files_for_commit):
2626         (Git.revisions_changing_file):
2627         (Git.svn_revision):
2628         (Git._run_git_svn_find_rev):
2629         (Git.contents_at_revision):
2630         (Git.diff_for_file):
2631         (Git.show_head):
2632         (Git.committer_email_for_revision):
2633         (Git.apply_reverse_diff):
2634         (Git.revert_files):
2635         (Git.commit_with_message):
2636         (Git._commit_on_branch):
2637         (Git.svn_commit_log):
2638         (Git.last_svn_commit_log):
2639         (Git.svn_blame):
2640         (Git._branch_ref_exists):
2641         (Git.delete_branch):
2642         (Git.remote_merge_base):
2643         (Git.commit_locally_with_message):
2644         (Git.push_local_commits_to_server):
2645         (Git.commit_ids_from_commitish_arguments):
2646         (Git.commit_message_for_local_commit):
2647         (Git.files_changed_summary_for_commit):
2648
2649 2012-09-04  Tommy Widenflycht  <tommyw@google.com>
2650
2651         MediaStream API: Add the async createOffer functionality to RTCPeerConnection
2652         https://bugs.webkit.org/show_bug.cgi?id=95734
2653
2654         Reviewed by Adam Barth.
2655
2656         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2657         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::SuccessCallbackTask):
2658         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::runIfValid):
2659         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::FailureCallbackTask):
2660         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::runIfValid):
2661         (MockWebRTCPeerConnectionHandler::createOffer):
2662         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
2663         (MockWebRTCPeerConnectionHandler):
2664         (MockWebRTCPeerConnectionHandler::taskList):
2665         (SuccessCallbackTask):
2666         (FailureCallbackTask):
2667
2668 2012-09-04  Xianzhu Wang  <wangxianzhu@chromium.org>
2669
2670         [Chromium-Android] Output time and thread info in crash log
2671         https://bugs.webkit.org/show_bug.cgi?id=95768
2672
2673         Reviewed by Adam Barth.
2674
2675         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2676         (ChromiumAndroidDriver._get_logcat): Add '-v threadtime' to adb logcat command line to get time and thread info.
2677
2678 2012-09-04  Tommy Widenflycht  <tommyw@google.com>
2679
2680         MediaStream API: Change the MediaStreamTrackList track added/removed signaling
2681         https://bugs.webkit.org/show_bug.cgi?id=95721
2682
2683         Reviewed by Adam Barth.
2684
2685         * DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp:
2686         (MockWebMediaStreamCenter::didAddMediaStreamTrack):
2687         (MockWebMediaStreamCenter::didRemoveMediaStreamTrack):
2688         * DumpRenderTree/chromium/MockWebMediaStreamCenter.h:
2689         (MockWebMediaStreamCenter):
2690
2691 2012-09-04  Tony Chang  <tony@chromium.org>
2692
2693         Elide test names when running new-run-webkit-tests
2694         https://bugs.webkit.org/show_bug.cgi?id=95626
2695
2696         Reviewed by Dirk Pranke.
2697
2698         When the test name exceeds the number of terminal columns, it leaves
2699         text on the screen. Avoid this by eliding the test name when running
2700         tests. This is similar to what ninja does when compiling.
2701
2702         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
2703         (MeteredStream):
2704         (MeteredStream.number_of_columns): Helper method to get number of
2705         terminal columns. Won't work on Win32 python, but meh.
2706         * Scripts/webkitpy/layout_tests/views/printing.py:
2707         (Printer._test_status_line): New method for eliding the text. Doesn't use \u2026
2708         because stderr appears to be ascii only.
2709         (Printer.print_started_test): Route through _test_status_line.
2710         (Printer.print_finished_test): Route through _test_status_line.
2711         (Printer._print_test_trace): Route through _test_status_line.
2712         (Printer._print_baseline): Route through _test_status_line.
2713         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
2714         (test_test_status_line): Test for _test_status_line.
2715
2716 2012-09-04  Martin Robinson  <mrobinson@igalia.com>
2717
2718         [GTK] Print API missing documentation when generating gtkdoc
2719         https://bugs.webkit.org/show_bug.cgi?id=95703
2720
2721         Reviewed by Carlos Garcia Campos.
2722
2723         Print out API missing documentation when generating gtkdoc. This makes it
2724         easier to fix documentation errors.
2725
2726         * gtk/generate-gtkdoc:
2727         (print_missing_api): Added.
2728         (generate_doc): Inline the rebase step, since it now reports an error
2729         when you try to rebase without generating documentation first.
2730         * gtk/gtkdoc.py:
2731         (GTKDoc.rebase_installed_docs): Raise an error when rebasing without
2732         generating documentation first to enable a small cleanup at the caller.
2733         (GTKDoc.api_missing_documentation): Added.
2734
2735 2012-09-04  Vincent Scheib  <scheib@chromium.org>
2736
2737         [Chromium] Allow asyncronous response of pointer lock requests in layout tests.
2738         https://bugs.webkit.org/show_bug.cgi?id=95628
2739
2740         Reviewed by James Robinson.
2741
2742         Future tests need the ability to respond asynchronously that
2743         pointer lock requests have been accepted or rejected. This patch
2744         adds the following:
2745             testRunner.setPointerLockWillRespondAsynchronously();
2746             testRunner.didAcquirePointerLock();
2747             testRunner.didNotAcquirePointerLock();
2748
2749         Tested in existing test:
2750             pointerlockchange-pointerlockerror-events.html
2751
2752         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2753         (DRTTestRunner::DRTTestRunner):
2754         (DRTTestRunner::didAcquirePointerLock):
2755         (DRTTestRunner::didNotAcquirePointerLock):
2756         (DRTTestRunner::setPointerLockWillRespondAsynchronously):
2757         * DumpRenderTree/chromium/DRTTestRunner.h:
2758         (DRTTestRunner):
2759         * DumpRenderTree/chromium/WebViewHost.cpp:
2760         (WebViewHost::requestPointerLock):
2761         (WebViewHost::didAcquirePointerLock):
2762         (WebViewHost::didNotAcquirePointerLock):
2763         * DumpRenderTree/chromium/WebViewHost.h:
2764         (WebViewHost):
2765         (WebViewHost::setPointerLockWillRespondAsynchronously):
2766
2767 2012-09-04  Ojan Vafai  <ojan@chromium.org>
2768
2769         Move content shell bots to their own builder group
2770         https://bugs.webkit.org/show_bug.cgi?id=95765
2771
2772         Reviewed by Adam Barth.
2773
2774         In their current state of instability, they add too much noise. Once they get more stable,
2775         we can add them back to the regular group or just have them replace the other bots.
2776
2777         Also, fix the filter for Apple Windows bots since some of them are now "Apple Win ...".
2778
2779         * TestResultServer/static-dashboards/builders.js:
2780         (isWebkitTestRunner):
2781         (isChromiumContentShellTestRunner):
2782         (isChromiumWebkitTipOfTreeTestRunner):
2783         (loadBuildersList):
2784
2785 2012-09-03  Ryuan Choi  <ryuan.choi@samsung.com>
2786
2787         [EFL] Change the focus when the web view is clicked in MiniBrowser and EWebLauncher
2788         https://bugs.webkit.org/show_bug.cgi?id=95689
2789
2790         Reviewed by Kenneth Rohde Christiansen.
2791
2792         In Minibrowser & EWebLauncher, the web view loses the focus when url bar is clicked.
2793         So, there are bugs that key events are always generated in url bar although
2794         the user clicked the web view.
2795
2796         This patch recovers the focus of the web view when left button is pressed and
2797         adds for MiniBrowser to toggle the focus when middle button is pressed
2798         like EWebLauncher already did.
2799
2800         * EWebLauncher/main.c:
2801         (on_mouse_down):
2802         * MiniBrowser/efl/main.c:
2803         (on_mouse_down):
2804         (browserCreate):
2805
2806 2012-09-03  Tao Bai  <michaelbai@chromium.org>
2807
2808         Added ANDROID_GDBSERVER definition for Ant
2809         https://bugs.webkit.org/show_bug.cgi?id=95265
2810
2811         Reviewed by Adam Barth.
2812
2813         ANDROID_GDBSERVER will replace ANDROID_TOOLCHAIN, because the ANDROID_TOOLCHAIN
2814         is only used for finding the gdbserver.
2815
2816         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2817         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
2818
2819 2012-09-03  Tommy Widenflycht  <tommyw@google.com>
2820
2821         MediaStream API: Add Ice-related functionality to RTCPeerConnection
2822         https://bugs.webkit.org/show_bug.cgi?id=95565
2823
2824         Reviewed by Adam Barth.
2825
2826         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2827         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
2828         (MockWebRTCPeerConnectionHandler::updateICE):
2829         (MockWebRTCPeerConnectionHandler::addICECandidate):
2830         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
2831         (MockWebRTCPeerConnectionHandler):
2832
2833 2012-09-03  Christophe Dumez  <christophe.dumez@intel.com>
2834
2835         [EFL] Fix resizing issues related to URL bar in Minibrowser / EWebLauncher
2836         https://bugs.webkit.org/show_bug.cgi?id=95670
2837
2838         Reviewed by Kenneth Rohde Christiansen.
2839
2840         Fix layout issues related to the URL bar in Minibrowser
2841         and EWebLauncher when the window is resized.
2842
2843         The URL bar was not resized accordingly and the Web
2844         page was moved behing the URL bar, hiding part of it.
2845
2846         * EWebLauncher/main.c:
2847         (on_ecore_evas_resize):
2848         (closeWindow):
2849         * EWebLauncher/url_bar.c:
2850         (url_bar_width_set):
2851         (url_bar_add):
2852         * EWebLauncher/url_bar.h:
2853         * MiniBrowser/efl/main.c:
2854         (on_ecore_evas_resize):
2855         (main):
2856
2857 2012-09-01  Xianzhu Wang  <wangxianzhu@chromium.org>
2858
2859         [Chromium-Android] Remove hard-coded skipped directories in chromium_android.py
2860         https://bugs.webkit.org/show_bug.cgi?id=95605
2861
2862         Reviewed by Dirk Pranke.
2863
2864         Now skipping rules are put in LayoutTests/platform/chromium-android/TestExpectations.
2865
2866         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2867         (ChromiumAndroidPort.check_sys_deps):
2868         (ChromiumAndroidPort.expectations_files):
2869         (ChromiumAndroidPort.clean_up_test_run):
2870
2871 2012-09-01  Joanmarie Diggs  <jdiggs@igalia.com>
2872
2873         [Gtk] Incorrect/unexpected characters in the text of certain accessibles
2874         https://bugs.webkit.org/show_bug.cgi?id=95180
2875
2876         Reviewed by Chris Fleizach.
2877
2878         The bug that was fixed stood in the way of fully implementing stringValue().
2879         Testing that the bug is fixed requires stringValue() to be fully implemented
2880         and object replacement characters to be printable.
2881
2882         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2883         (replaceCharactersForResults): New method which turns object replacement
2884         characters into "<obj>" so that the characters can be properly shown in
2885         Layout Test results. Also turns "\n" into "<\\n>" so that printing the
2886         accessible text of a single object in the accessible tree doesn't mess up
2887         the readibility of the results.
2888         (AccessibilityUIElement::stringValue): Remove the code that immediately
2889         returned upon encountering an object of ATK_ROLE_PANEL and call the new
2890         replaceCharactersForResults() prior to returning the accessible string
2891         value.
2892
2893 2012-09-01  Tommy Widenflycht  <tommyw@google.com>
2894
2895         MediaStream API: Add MediaStream management to RTCPeerConnection
2896         https://bugs.webkit.org/show_bug.cgi?id=95543
2897
2898         Reviewed by Adam Barth.
2899
2900         Extending MockWebRTCPeerConnectionHandler to handle addStream/removeStream.
2901
2902         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2903         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
2904         (MockWebRTCPeerConnectionHandler::addStream):
2905         (MockWebRTCPeerConnectionHandler::removeStream):
2906         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
2907         (MockWebRTCPeerConnectionHandler):
2908
2909 2012-08-31  Tony Chang  <tony@chromium.org>
2910
2911         Remove ENABLE_CSS3_FLEXBOX compile time flag
2912         https://bugs.webkit.org/show_bug.cgi?id=95382
2913
2914         Reviewed by Ojan Vafai.
2915
2916         Everyone is already enabling this by default and the spec has stablized.
2917
2918         * Scripts/webkitperl/FeatureList.pm:
2919         * qmake/mkspecs/features/features.pri:
2920
2921 2012-08-31  Pratik Solanki  <psolanki@apple.com>
2922
2923         objc_msgSend and IMP should be cast appropriately before using
2924         https://bugs.webkit.org/show_bug.cgi?id=95242
2925
2926         Reviewed by Benjamin Poulain.
2927
2928         Fix for older compilers. Pass id as the return type to the template
2929         instead of relying on default type.
2930
2931         * DumpRenderTree/mac/DumpRenderTree.mm:
2932         (drt_NSFontManager_availableFontFamilies):
2933         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
2934         (WTR::wtr_NSFontManager_availableFontFamilies):
2935
2936 2012-08-31  Zan Dobersek  <zandobersek@gmail.com>
2937
2938         nrwt: use scm instead of calling svn directly to get the revision in json results generator
2939         https://bugs.webkit.org/show_bug.cgi?id=89616
2940
2941         Reviewed by Eric Seidel.
2942
2943         Add the new 'executive' optional function argument to the SCM.in_working_directory
2944         class method. This way we get to reuse an Executive instance which is necessary in testing
2945         when we're operating with a mock version of the object.
2946
2947         In JSONResultsGeneratorBase, it's now possible to get the current SVN revision by using
2948         the SCMDetector with the generator's FileSystem and Executive instances.
2949
2950         * Scripts/webkitpy/common/checkout/scm/detection.py:
2951         (SCMDetector.detect_scm_system):
2952         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
2953         (SCMDetectorTest.test_detect_scm_system): Update the unit test to capture the mock
2954         Executive output and test it against expected output.
2955         * Scripts/webkitpy/common/checkout/scm/git.py:
2956         (Git.in_working_directory):
2957         * Scripts/webkitpy/common/checkout/scm/scm.py:
2958         (SCM.in_working_directory):
2959         * Scripts/webkitpy/common/checkout/scm/svn.py:
2960         (SVN.in_working_directory):
2961         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2962         (JSONResultsGeneratorBase.__init__):
2963         (JSONResultsGeneratorBase._get_svn_revision):
2964
2965 2012-08-31  Jon Lee  <jonlee@apple.com>
2966
2967         [Tests] Add basic tests to http/tests/notifications
2968         https://bugs.webkit.org/show_bug.cgi?id=95493
2969         <rdar://problem/12209303>
2970
2971         Reviewed by Alexey Proskuryakov.
2972
2973         Add permission request support for WTR.
2974
2975         * WebKitTestRunner/TestController.cpp:
2976         (WTR::TestController::initialize):
2977         (WTR::TestController::decidePolicyForNotificationPermissionRequest): Always allow.
2978         * WebKitTestRunner/TestController.h:
2979         (TestController):
2980
2981 2012-08-31  Jon Lee  <jonlee@apple.com>
2982
2983         [DRT] Make simulating a web click on a notification a queued task
2984         https://bugs.webkit.org/show_bug.cgi?id=95546
2985         <rdar://problem/12214170>
2986
2987         Reviewed by Alexey Proskuryakov.
2988
2989         Making the web click happen asynchronously better mimics user interaction with the platform.
2990
2991         * DumpRenderTree/TestRunner.h: Add a flag that determines whether we have a pending notification click.
2992         (TestRunner::hasPendingWebNotificationClick): Exposed so that dump() can check that the flag is
2993         not set.
2994         * DumpRenderTree/mac/DumpRenderTree.mm:
2995         (dump): Assert that the flag is not set.
2996         * DumpRenderTree/mac/TestRunnerMac.mm:
2997         (TestRunner::simulateWebNotificationClick): Set the flag, then add a task to click the
2998         notification. In the case where the block gets executed after the flag has been unset, we avoid
2999         performing the click.
3000
3001 2012-08-31  Balazs Kelemen  <kbalazs@webkit.org>
3002
3003         [Qt] ImageDiff output is not in the expected form if image dimensions differ
3004         https://bugs.webkit.org/show_bug.cgi?id=95575
3005
3006         Reviewed by Csaba Osztrogonác.
3007
3008         Output 100% difference in the case of differing image dimensions so
3009         the test harness knows that we won't produce any output further.
3010         This matches the behavior of other ports.
3011
3012         * DumpRenderTree/qt/ImageDiff.cpp:
3013         (main):
3014
3015 2012-08-31  Sheriff Bot  <webkit.review.bot@gmail.com>
3016
3017         Unreviewed, rolling out r127261.
3018         http://trac.webkit.org/changeset/127261
3019         https://bugs.webkit.org/show_bug.cgi?id=95572
3020
3021         This patch depends on other build fixes (see blockers of bug
3022         95466) which should land first (Requested by milian on
3023         #webkit).
3024
3025         * qmake/mkspecs/features/features.prf:
3026
3027 2012-08-31  Milian Wolff  <milian.wolff@kdab.com>
3028
3029         [Qt] Support WebKit2/QML on QNX
3030         https://bugs.webkit.org/show_bug.cgi?id=95466
3031
3032         Reviewed by Noam Rosenthal.
3033
3034         Enable USE(3D_GRAPHICS) on QNX again, paired with the other bug fixes
3035         this should finally work now.
3036
3037         * qmake/mkspecs/features/features.prf:
3038
3039 2012-08-30  Xianzhu Wang  <wangxianzhu@chromium.org>
3040
3041         [Chromium-Android] Skip compositing/webgl and platform/chromium/virtual/threaded/compositing/webgl tests
3042         https://bugs.webkit.org/show_bug.cgi?id=95400
3043
3044         Reviewed by Dirk Pranke.
3045
3046         WebGL is not enabled and should be skipped on Android (http://crbug.com/135877).
3047
3048         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3049         (ChromiumAndroidPort.skipped_layout_tests):
3050
3051 2012-08-30  Gustavo Noronha Silva  <gns@gnome.org>
3052
3053         [GTK] Tries to run empty string when calling generate-gtkdoc when not using jhbuild
3054         https://bugs.webkit.org/show_bug.cgi?id=95499
3055
3056         Unreviewed. One more fix to avoid trying to run the empty string.
3057
3058         * Scripts/webkitdirs.pm:
3059         (buildAutotoolsProject):
3060
3061 2012-08-30  Sheriff Bot  <webkit.review.bot@gmail.com>
3062
3063         Unreviewed, rolling out r127171.
3064         http://trac.webkit.org/changeset/127171
3065         https://bugs.webkit.org/show_bug.cgi?id=95505
3066
3067         testRunner does not need dumpWebNotificationCallbacks().
3068         (Requested by jonlee on #webkit).
3069
3070         * DumpRenderTree/TestRunner.cpp:
3071         (TestRunner::TestRunner):
3072         (TestRunner::staticFunctions):
3073         * DumpRenderTree/TestRunner.h:
3074         (TestRunner):
3075         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
3076         (-[MockWebNotificationProvider webView:didShowNotification:]):
3077         (-[MockWebNotificationProvider webView:didClickNotification:]):
3078         (-[MockWebNotificationProvider webView:didCloseNotifications:]):
3079         * DumpRenderTree/mac/UIDelegate.mm:
3080         (-[UIDelegate webView:decidePolicyForNotificationRequestFromOrigin:listener:]):
3081
3082 2012-08-30  Pratik Solanki  <psolanki@apple.com>
3083
3084         objc_msgSend and IMP should be cast appropriately before using
3085         https://bugs.webkit.org/show_bug.cgi?id=95242
3086
3087         Reviewed by Benjamin Poulain.
3088
3089         Use wtfObjcMsgSend and wtfCallIMP templates which do appropriate casts
3090         to a function pointer with right types when calling objc_msgSend and an
3091         IMP method directly.
3092
3093         * DumpRenderTree/mac/DumpRenderTree.mm:
3094         (drt_NSFontManager_availableFontFamilies):
3095         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
3096         (WTR::wtr_NSFontManager_availableFontFamilies):
3097
3098 2012-08-30  Benjamin Poulain  <bpoulain@apple.com>
3099
3100         Replace JSC::UString by WTF::String
3101         https://bugs.webkit.org/show_bug.cgi?id=95271
3102
3103         Reviewed by Geoffrey Garen.
3104
3105         Get rid of UString.
3106
3107         * DumpRenderTree/efl/WorkQueueItemEfl.cpp:
3108         * gdb/webkit.py:
3109         (WTFStringPrinter.to_string):
3110         (JSCIdentifierPrinter.to_string):
3111         (JSCJSStringPrinter.to_string):
3112         (add_pretty_printers):
3113
3114 2012-08-30  Dirk Pranke  <dpranke@chromium.org>
3115
3116         nrwt should have TestExpectations everywhere we have Skipped files for apple ports
3117         https://bugs.webkit.org/show_bug.cgi?id=95495
3118
3119         Reviewed by Ojan Vafai.
3120
3121         This is a follow-on to bug 95370 that adds in support for
3122         platform/wk2/TestExpectations and
3123         platform/{mac,win}-$version/TestExpectations.
3124
3125         * Scripts/webkitpy/layout_tests/port/apple.py:
3126         (ApplePort.expectations_files):
3127         * Scripts/webkitpy/layout_tests/port/base.py:
3128         (Port._skipped_file_search_paths):
3129         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3130         (MacTest.test_expectations_files):
3131         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
3132         (MockDRTPortTest.make_port):
3133         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
3134         (WinPortTest.test_expectations_files):
3135
3136 2012-08-30  Dirk Pranke  <dpranke@chromium.org>
3137
3138         executive.run_in_parallel() hangs if given nothing to do
3139         https://bugs.webkit.org/show_bug.cgi?id=95387
3140
3141         Reviewed by Ojan Vafai.
3142
3143         Check to make sure that Executive.run_in_parallel() requires
3144         a non-empty list of commands to execute; passing an empty list
3145         seems surely like a programming error.
3146
3147         * Scripts/webkitpy/common/system/executive.py:
3148         (Executive.run_in_parallel):
3149         * Scripts/webkitpy/common/system/executive_unittest.py:
3150         (ExecutiveTest.test_run_in_parallel_assert_nonempty):
3151
3152 2012-08-30  Dirk Pranke  <dpranke@chromium.org>
3153
3154         decide what (and how) we should set the tolerance for ref test pixel compares and test for that
3155         https://bugs.webkit.org/show_bug.cgi?id=94746
3156
3157         Reviewed by Ojan Vafai.
3158
3159         Add an assertion to diff_image() to check that we are passing
3160         tolerance=0 explicitly when diffing ref test results.
3161
3162         * Scripts/webkitpy/layout_tests/port/test.py:
3163         (TestPort.diff_image):
3164
3165 2012-08-30  Dirk Pranke  <dpranke@chromium.org>
3166
3167         NRWT should look in mac-wk2 for a TestExpecations file
3168         https://bugs.webkit.org/show_bug.cgi?id=95370
3169
3170         Reviewed by Ojan Vafai.
3171
3172         Adds support for mac-wk2 and win-wk2 to expectations_files()
3173         for the apple mac and apple win ports.
3174         
3175         * Scripts/webkitpy/layout_tests/port/apple.py:
3176         (ApplePort.expectations_files):
3177         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3178         (MacTest.test_expectations_files):
3179         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
3180         (WinTest.test_expectations_files):
3181         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3182         (PortTestCase.test_expectations_files):
3183
3184 2012-08-30  Jon Lee  <jonlee@apple.com>
3185
3186         [Mac] Add testRunner.dumpWebNotificationCallbacks() to DRT
3187         https://bugs.webkit.org/show_bug.cgi?id=95232
3188         <rdar://problem/12190776>
3189
3190         Reviewed by Alexey Proskuryakov.
3191
3192         Add additional output when running test, if testRunner.dumpWebNotificationCallbacks() is called.
3193
3194         * DumpRenderTree/TestRunner.cpp:
3195         (TestRunner::TestRunner):
3196         (dumpWebNotificationCallbacksCallback):
3197         (TestRunner::staticFunctions):
3198         * DumpRenderTree/TestRunner.h:
3199         (TestRunner):
3200         (TestRunner::dumpWebNotificationCallbacks):
3201         (TestRunner::setDumpWebNotificationCallbacks):
3202         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
3203         (-[WebNotification _drt_descriptionSuitableForTestResult]):
3204         (-[MockWebNotificationProvider webView:didShowNotification:]):
3205         (-[MockWebNotificationProvider webView:didClickNotification:]):
3206         (-[MockWebNotificationProvider webView:didCloseNotifications:]):
3207         * DumpRenderTree/mac/UIDelegate.mm:
3208         (-[UIDelegate webView:decidePolicyForNotificationRequestFromOrigin:listener:]):
3209
3210 2012-08-30  Tommy Widenflycht  <tommyw@google.com>
3211
3212         MediaStream API: Introduce MediaConstraints
3213         https://bugs.webkit.org/show_bug.cgi?id=95198
3214
3215         Reviewed by Adam Barth.
3216
3217         Extending the MockWebRTCPeerConnectionHandler with MediaConstraints functionality.
3218
3219         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
3220         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
3221         (isSupportedConstraint):
3222         (isValidConstraint):
3223         (MockWebRTCPeerConnectionHandler::initialize):
3224         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
3225         (MockWebRTCPeerConnectionHandler):
3226
3227 2012-08-30  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3228
3229         [WK2][WTR] Add didReceiveServerRedirectForProvisionalLoadForFrame dumping
3230         https://bugs.webkit.org/show_bug.cgi?id=95454
3231
3232         Reviewed by Kenneth Rohde Christiansen.
3233
3234         Added didReceiveServerRedirectForProvisionalLoadForFrame dumping to WTR.
3235
3236         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3237         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
3238
3239 2012-08-30  Leo Yang  <leoyang@rim.com>
3240
3241         Update my email address.
3242
3243         Not reviewed.
3244
3245         * Scripts/webkitpy/common/config/committers.py:
3246
3247 2012-08-30  Jochen Eisinger  <jochen@chromium.org>
3248
3249         [NRWT] Add support for recognizing arbitrary process names in crash lines
3250         https://bugs.webkit.org/show_bug.cgi?id=95435
3251
3252         Reviewed by Adam Barth.
3253
3254         When running layout tests in the chromium port using the content shell,
3255         we want to be able to report sub-process crashes as well.
3256
3257         * Scripts/webkitpy/layout_tests/port/driver.py:
3258         (Driver._check_for_driver_crash):
3259         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
3260         (DriverTest.test_check_for_driver_crash):
3261
3262 2012-08-29  Zan Dobersek  <zandobersek@gmail.com>
3263
3264         Random test-webkitpy failures on the buildbot
3265         https://bugs.webkit.org/show_bug.cgi?id=95096
3266
3267         Reviewed by Dirk Pranke.
3268
3269         Suppress occasional errors when running test-webkitpy on GTK builders
3270         by running these tests serially. The 64-bit Release builder is especially
3271         prone to these as it can run up to 24 tests in parallel.
3272
3273         Despite the tests not being run in parallel, the testing only lasts a handful
3274         of seconds more, so this is a worthy trade-off to avoid unnecessary
3275         false-alarm redness on the GTK builders.
3276
3277         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3278         (RunPythonTests.start):
3279
3280 2012-08-29  Benjamin Poulain  <bpoulain@apple.com>
3281
3282         REGRESSION(r126780): Crash using StringImpl::is8Bit before checking if there is an impl
3283         https://bugs.webkit.org/show_bug.cgi?id=95380
3284
3285         Reviewed by Michael Saboff.
3286
3287         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
3288         Add very basic tests for String::ascii(). This covers the case of null strings that caused
3289         the crash.
3290
3291 2012-08-29  Dominic Mazzoni  <dmazzoni@google.com>
3292
3293         AX: Canvas should have a distinct role
3294         https://bugs.webkit.org/show_bug.cgi?id=95248
3295
3296         Reviewed by Chris Fleizach.
3297
3298         Add support for canvas accessibility role.
3299
3300         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
3301         (roleToString):
3302
3303 2012-08-29  José Dapena Paz  <jdapena@igalia.com>
3304
3305         [Gtk] Process Gtk 3.4 smooth scroll events properly
3306         https://bugs.webkit.org/show_bug.cgi?id=88070
3307
3308         Added continousMouseScrollBy support in WebKitTestRunner, and added
3309         implementation for gtk, and stub for Qt, mac and EFL.
3310
3311         Added layout tests support for smooth scroll in Gtk 3.4, and use smooth
3312         scroll for emulating multi-tick mouseScrollBy events.
3313
3314         Reviewed by Martin Robinson.
3315
3316         * DumpRenderTree/gtk/EventSender.cpp:
3317         (mouseScrollByCallback):
3318         (continuousMouseScrollByCallback):
3319         * WebKitTestRunner/EventSenderProxy.h:
3320         (EventSenderProxy):
3321         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
3322         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3323         (WTR::EventSendingController::mouseScrollBy):
3324         (WTR):
3325         (WTR::EventSendingController::continuousMouseScrollBy):
3326         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
3327         (EventSendingController):
3328         * WebKitTestRunner/TestController.cpp:
3329         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
3330         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
3331         (WTR):
3332         (WTR::EventSenderProxy::mouseScrollBy):
3333         (WTR::EventSenderProxy::continuousMouseScrollBy):
3334         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
3335         (WTR):
3336         (WTR::EventSenderProxy::continuousMouseScrollBy):
3337         * WebKitTestRunner/mac/EventSenderProxy.mm:
3338         (WTR::EventSenderProxy::continuousScrollBy):
3339         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
3340         (WTR::EventSenderProxy::continuousMouseScrollBy):
3341         (WTR):
3342
3343 2012-08-29  Alex Sakhartchouk  <alexst@chromium.org>
3344
3345         [chromium] Support high DIP pixel tests with DumpRenderTree
3346         https://bugs.webkit.org/show_bug.cgi?id=94935
3347
3348         Reviewed by James Robinson.
3349
3350         Adding device scale factor into the drt image dumping code
3351
3352         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3353         (DRTTestRunner::reset):
3354         (DRTTestRunner::setBackingScaleFactor):
3355         * DumpRenderTree/chromium/WebViewHost.cpp:
3356         (WebViewHost::setDeviceScaleFactor):
3357         (WebViewHost::paintInvalidatedRegion):
3358         (WebViewHost::canvas):
3359         * DumpRenderTree/chromium/WebViewHost.h:
3360         (WebViewHost):
3361
3362 2012-08-29  Kevin Funk  <kevin.funk@kdab.com>
3363
3364         Fix check-webkit-style (and probably others) when WebKit is in a git submodule
3365         https://bugs.webkit.org/show_bug.cgi?id=95177
3366
3367         Reviewed by Dirk Pranke.
3368
3369         Find the real checkout root by using 'git rev-parse --show-toplevel' instead of '--git-dir'
3370
3371         * Scripts/webkitpy/common/checkout/scm/git.py:
3372
3373 2012-08-29  Dirk Pranke  <dpranke@chromium.org>
3374
3375         webkit-patch rebaseline-expectations wrongly touches other platforms' TestExpectations
3376         https://bugs.webkit.org/show_bug.cgi?id=95222
3377
3378         Reviewed by Adam Barth.
3379
3380         The code we had to remove REBASELINE lines from the
3381         TestExpectations files did not handle multiple files (in a
3382         cascade) correctly; we weren't limiting lines to a particular
3383         file correctly in without_rebaseline_modifier(). This patch
3384         fixes that and corrects the tests (which weren't correct and
3385         didn't cover things very well).
3386
3387         Note also that the webkit-patch rebaseline-commands are still
3388         using the include_overrides=False option in a couple places;
3389         this is never correct or needed at this point. This patch fixes
3390         the usage for webkit-patch rebaseline-expectations, but I still
3391         need to fix rebaseline-test-internal, which I will do in a
3392         separate patch (see bug 95268).
3393
3394         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3395         (TestExpectations.remove_rebaselined_tests.without_rebaseline_modifier):
3396         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3397         (RebaseliningTest.assertRemove):
3398         (RebaseliningTest.test_remove):
3399         * Scripts/webkitpy/tool/commands/rebaseline.py:
3400         (RebaselineExpectations._update_expectations_files):
3401
3402 2012-08-29  Dirk Pranke  <dpranke@chromium.org>
3403
3404         webkit-patch rebaseline-expectations hangs
3405         https://bugs.webkit.org/show_bug.cgi?id=95243
3406
3407         Reviewed by Tony Chang.
3408
3409         Don't try to run no commands in parallel; report an error
3410         instead that we didn't find any tests to rebaseline.
3411
3412         Filed bug 95387 as well to make sure run_in_parallel() doesn't hang forever.
3413
3414         * Scripts/webkitpy/tool/commands/rebaseline.py:
3415         (RebaselineExpectations.execute):
3416         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3417         (_assert_command):
3418         (test_rebaseline_expectations_noop):
3419
3420 2012-08-29  Brady Eidson  <beidson@apple.com>
3421
3422         REGRESSION: Not sending NPP_SetWindow is causing Flash to not throttle itself
3423         <rdar://problem/12133021> and https://bugs.webkit.org/show_bug.cgi?id=95274
3424
3425         Reviewed by Sam Weinig.
3426
3427         Add a test plug-in that calls back into the page with info on the NPWindow passed
3428         in to NPP_SetWindow.
3429
3430         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3431         * DumpRenderTree/TestNetscapePlugIn/Tests/LogNPPSetWindow.cpp: Added.
3432         (LogNPPSetWindow):
3433         (LogNPPSetWindow::LogNPPSetWindow):
3434         (LogNPPSetWindow::NPP_SetWindow):
3435
3436 2012-08-29  Jon Lee  <jonlee@apple.com>
3437
3438         [Mac] Basic DRT support for web notifications
3439         https://bugs.webkit.org/show_bug.cgi?id=79492
3440         <rdar://problem/10357639>
3441
3442         Reviewed by Alexey Proskuryakov.
3443
3444         This patch implements the stubs for web notification support on DRT. Assume that when
3445         Notification.requestPermission() is called, the user always chooses to allow it. This can be easily
3446         overridden in layout tests with testRunner.denyWebNotificationPermission() when needed.
3447
3448         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Add MockWebNotificationProvider.
3449         * DumpRenderTree/mac/DumpRenderTree.mm:
3450         (createWebViewAndOffscreenWindow): Set MockWebNotificationProvider singleton as the provider for the
3451         web view.
3452         (resetWebViewToConsistentStateBeforeTesting): Make sure to reset the provider's state between each test.
3453
3454         * DumpRenderTree/mac/TestRunnerMac.mm:
3455         (TestRunner::grantWebNotificationPermission): Set permission to granted for specified origin.
3456         (TestRunner::denyWebNotificationPermission): Set permission to denied for specified origin.
3457         (TestRunner::removeAllWebNotificationPermissions):
3458         (TestRunner::simulateWebNotificationClick): Retrieve the notification ID from the JS notification object, and
3459         simulate the click. This is similar to how WTR performs the click.
3460         * DumpRenderTree/mac/UIDelegate.mm:
3461         (-[UIDelegate webView:decidePolicyForNotificationRequestFromOrigin:listener:]): Assume when asked, the
3462         user allows web notifications.
3463
3464         * DumpRenderTree/mac/MockWebNotificationProvider.h: Added. Maintains a list of registered web views, known permissions,
3465         a map of notification IDs to WebNotification instances, and a map of the WebViews from which the notifications were dispatched.
3466         * DumpRenderTree/mac/MockWebNotificationProvider.mm: Added.
3467         (+[MockWebNotificationProvider shared]): The provider is a singleton.
3468         (-[MockWebNotificationProvider init]): Instantiate the permissions map.
3469         (-[MockWebNotificationProvider registerWebView:]):
3470         (-[MockWebNotificationProvider unregisterWebView:]):
3471         (-[MockWebNotificationProvider showNotification:fromWebView:]): Add the notification to the maps. Tell the web view that the
3472         notification did show.
3473         (-[MockWebNotificationProvider cancelNotification:]): Tell the web view the notification did close.
3474         (-[MockWebNotificationProvider notificationDestroyed:]): Remove the notification from the maps. Here we don't make a callback.
3475         (-[MockWebNotificationProvider clearNotifications:]): Remove the specified notifications from the maps. Here we don't make a callback.
3476         (-[MockWebNotificationProvider webView:didShowNotification:]): Delegate callback. Dispatch the show event.
3477         (-[MockWebNotificationProvider webView:didClickNotification:]): Delegate callback. Dispatch the click event.
3478         (-[MockWebNotificationProvider webView:didCloseNotifications:]): Delegate callback. Dispatch the close event.
3479         (-[MockWebNotificationProvider simulateWebNotificationClick:]): Tell the web view we clicked the notification.
3480         (-[MockWebNotificationProvider policyForOrigin:]): Look in the permission dictionary.
3481         (-[MockWebNotificationProvider setWebNotificationOrigin:permission:]): Set the permission for the origin in the dictionary.
3482         (-[MockWebNotificationProvider removeAllWebNotificationPermissions]): Clear the permission map.
3483         (-[MockWebNotificationProvider reset]): Remove all mappings and permissions.
3484
3485 2012-08-29  Rob Buis  <rbuis@rim.com>
3486
3487         [BlackBerry] Adjust wtf include header style
3488         https://bugs.webkit.org/show_bug.cgi?id=95368
3489
3490         Reviewed by Yong Li.
3491
3492         Switch to #include <wtf/...> like the other ports.
3493
3494         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
3495         * DumpRenderTree/blackberry/PNGImageEncoder.cpp:
3496         * DumpRenderTree/blackberry/PNGImageEncoder.h:
3497         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
3498         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.h:
3499         * DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp:
3500
3501 2012-08-29  Roger Fong  <roger_fong@apple.com>
3502
3503         Update cygwin-downloader.zip to match modified downloader script.
3504         https://bugs.webkit.org/show_bug.cgi?id=76936
3505
3506         Rubber Stamped by Jon Honeycutt.
3507
3508         cygwin-downloader.py was modified in http://trac.webkit.org/changeset/126948.
3509         Updating zip to reflect changes.
3510
3511         * CygwinDownloader/cygwin-downloader.zip:
3512
3513 2012-08-29  Dominik Röttsches  <dominik.rottsches@intel.com>
3514
3515         Stylechecker warns about comparison to zero when comparing to 0.5
3516         https://bugs.webkit.org/show_bug.cgi?id=94913
3517
3518         Reviewed by Dirk Pranke.
3519
3520         According to the python documentation, \W is the character group with all
3521         non-alphanumeric characters, equivalent to [^a-zA-Z0-9_], which is equal to
3522         to [^\w]. We need to exclude the dot "." as well, so that floating point
3523         values do not trigger this warning. Adding a unit test that shows the problem.
3524
3525         * Scripts/webkitpy/style/checkers/cpp.py:
3526         (check_for_comparisons_to_zero): Modifying the regex to not get triggered by comparing to floats.
3527         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3528         (WebKitStyleTest.test_null_false_zero): Unit test exposing this issue.
3529
3530 2012-08-29  Jon Lee  <jonlee@apple.com>
3531
3532         WTR build fixes.
3533
3534         * WebKitTestRunner/CMakeLists.txt:
3535         * WebKitTestRunner/GNUmakefile.am:
3536         * WebKitTestRunner/Target.pri:
3537         * WebKitTestRunner/WebNotificationProvider.cpp:
3538         (WTR::WebNotificationProvider::showWebNotification): Make ML happier.
3539         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3540
3541 2012-08-29  Jon Lee  <jonlee@apple.com>
3542
3543         [WK2] Basic WTR support for web notifications
3544         https://bugs.webkit.org/show_bug.cgi?id=95154
3545         <rdar://problem/12184492>
3546
3547         Reviewed by Alexey Proskuryakov.
3548
3549         Implement WTR support, without platform event output (bug 95233).
3550
3551         Legacy APIs will not be supported, since many of the tests are skipped
3552         on ports that do test notifications, and the issue with using file:// as the origin means a lot of the permissions
3553         tests won't work. Bugs 81048 and 81697 will track migrating the existing tests to use the new testRunner API, and move
3554         the tests to http/tests/notifications.
3555
3556         Permissions will be handled only in the injected bundle. This allows tests to set permission synchronously, and not
3557         require a chain of setTimeout()'s when writing a notification test. Clicking a notification, however, should
3558         be invoked from the UIProcess.
3559
3560         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3561         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3562         (WTR::InjectedBundle::didReceiveMessage): When told to "Reset", clear out all of the permissions.
3563         (WTR::InjectedBundle::postSimulateWebNotificationClick): Tell the bundle client to simulate a click based on the
3564         notification's internal ID.
3565         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3566         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3567         (WTR::TestRunner::grantWebNotificationPermission): Manually set the permission using WKBundle SPI.
3568         (WTR::TestRunner::denyWebNotificationPermission): Manually set the permission using WKBundle SPI.
3569         (WTR::TestRunner::removeAllWebNotificationPermissions):
3570         (WTR::TestRunner::simulateWebNotificationClick): Post a message through the injected bundle.
3571         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3572
3573         Because supporting web notifications goes beyond a couple functions, move all of the logic into a WebNotificationProvider
3574         class.
3575         * WebKitTestRunner/TestInvocation.cpp:
3576         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): When the injected bundle sends a message to simulate a click,
3577         TestInvocation forwards that request to the TestController.
3578         * WebKitTestRunner/TestController.cpp:
3579         (WTR::TestController::initialize): Set the provider.
3580         (WTR::TestController::resetStateToConsistentValues): Tell the provider to reset.
3581         (WTR::TestController::simulateWebNotificationClick): Tell the provider to simulate a user clicking on a platform notification.
3582         * WebKitTestRunner/TestController.h: Holds an instance to the provider.
3583
3584         The provider maintains a pointer to one notification manager (presumably the web process associated with WTR), and a set
3585         of notification IDs that have been "shown" by the platform. This allows us to simulate a click on a notification.
3586         * WebKitTestRunner/WebNotificationProvider.h: Added.
3587         * WebKitTestRunner/WebNotificationProvider.cpp: Added.
3588         (WTR::WebNotificationProvider::showWebNotification): Adds the notification to set of shown notifications. Notifies provider that
3589         the notification got shown.
3590         (WTR::WebNotificationProvider::closeWebNotification): Removes the notification from the set. Notifies provider that the notification
3591         got closed.
3592         (WTR::WebNotificationProvider::addNotificationManager): Maintains one manager, which is fine for testing purposes.
3593         (WTR::WebNotificationProvider::removeNotificationManager): Maintains one manager.
3594         (WTR::WebNotificationProvider::notificationPermissions): When the web process starts, it maintains an initial set of known
3595         permissions. For testing purposes, we always want this set to be empty.
3596         (WTR::WebNotificationProvider::simulateWebNotificationClick): Notifies provider that the notification got "clicked".
3597         (WTR::WebNotificationProvider::reset): To reset the state, we pretend that we closed all of the platform notifications.
3598
3599         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Add WebNotificationProvider.
3600
3601 2012-08-29  Kamil Blank  <k.blank@samsung.com>
3602
3603         [EFL] Add setting API for allow universal/file access from file URLs.
3604         https://bugs.webkit.org/show_bug.cgi?id=83121
3605
3606         Reviewed by Eric Seidel.
3607
3608         Implementation of setAllowUniversalAccessFromFileURLs and setAllowFileAccessFromFileURLs.
3609
3610         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3611         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3612         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3613         (TestRunner::setAllowUniversalAccessFromFileURLs):
3614         (TestRunner::setAllowFileAccessFromFileURLs):
3615
3616 2012-08-29  Jon Lee  <jonlee@apple.com>
3617
3618         Update TestRunner API for web notifications
3619         https://bugs.webkit.org/show_bug.cgi?id=95093
3620         <rdar://problem/12179649>
3621
3622         Reviewed by Alexey Proskuryakov.
3623
3624         As it turns out the patch for this accidentally got squashed into the commit for
3625         bug 95099 (r126909). This amendment patch adds some comments about the renaming
3626         of the older TestRunner API for web notifications.
3627
3628         * DumpRenderTree/TestRunner.h:
3629         (TestRunner):
3630
3631 2012-08-29  Sheriff Bot  <webkit.review.bot@gmail.com>
3632
3633         Unreviewed, rolling out r126972.
3634         http://trac.webkit.org/changeset/126972
3635         https://bugs.webkit.org/show_bug.cgi?id=95349
3636
3637         accessibility/canvas-description-and-role.html has been
3638         failing consistently on several bots and Dominic needs some
3639         time to investigate why (Requested by jchaffraix on #webkit).
3640
3641         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
3642         (roleToString):
3643
3644 2012-08-29  Raphael Kubo da Costa  <rakuco@webkit.org>
3645
3646         [EFL] Resolve CMake warnings on overlapping search paths for EFL jhbuild-enabled build
3647         https://bugs.webkit.org/show_bug.cgi?id=84707
3648
3649         Reviewed by Gustavo Noronha Silva.
3650
3651         Most of the warnings have been fixed now that FindCairo.cmake and
3652         FindGLIB.cmake have been rewritten. The remaining one, related to
3653         FindFontconfig.cmake, shows up when building on a 64-bit
3654         Debian-based systems.
3655
3656         jhbuild installs libraries into lib64/ by default on 64-bit Linux
3657         installations, while CMake does not look for libraries in lib64/
3658         when /etc/debian_version exists on the system. The FIND_LIBRARY()
3659         would then sometimes end up using the system installation instead of
3660         the jhbuild one, causing mismatches and, when pkg-config is not used
3661         at all, failing to find libraries altogether.
3662
3663         * efl/jhbuildrc: Set the CMAKE_LIBRARY_PATH environment variable
3664         when use_lib64 is set to force CMake to look into lib64/ regardless
3665         of the presence of /etc/debian_version.
3666
3667 2012-08-29  Dominik Röttsches  <dominik.rottsches@intel.com>
3668
3669         The 2d.imageData.object.round canvas test is failing
3670         https://bugs.webkit.org/show_bug.cgi?id=40272
3671
3672         Reviewed by Benjamin Poulain.
3673
3674         Updating patch to address Benjamin's review comments.
3675         Adding a WTF test to test lrint implementation.
3676
3677         * TestWebKitAPI/CMakeLists.txt: Added MathExtras.cpp test file.
3678         * TestWebKitAPI/GNUmakefile.am: Added MathExtras.cpp test file.
3679         * TestWebKitAPI/TestWebKitAPI.gypi: Added MathExtras.cpp test file.
3680         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added MathExtras.cpp test file.
3681         * TestWebKitAPI/Tests/WTF/MathExtras.cpp: Added this test file containing a test for lrint().
3682         (TestWebKitAPI):
3683         (TestWebKitAPI::TEST):
3684         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added MathExtras.cpp test file.
3685
3686 2012-08-29  Florin Malita  <fmalita@chromium.org>
3687
3688         Unreviewed, updating Kelly Norton's email address at his request.
3689
3690         * Scripts/webkitpy/common/config/committers.py:
3691
3692 2012-08-29  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
3693
3694         [NRWT] The nrwt should check the contents of the skipped files with --lint-test-files
3695         https://bugs.webkit.org/show_bug.cgi?id=93723
3696
3697         Reviewed by Dirk Pranke.
3698
3699         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3700         (TestExpectationParser.expectation_for_skipped_test):
3701         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3702         (SkippedTests.test_skipped_entry_dont_exist):
3703
3704 2012-08-29  Sheriff Bot  <webkit.review.bot@gmail.com>
3705
3706         Unreviewed, rolling out r120113.
3707         http://trac.webkit.org/changeset/120113
3708         https://bugs.webkit.org/show_bug.cgi?id=95320
3709
3710         Wrong fix for the problem, experimentally rolling it out for
3711         bug 95237. (Requested by rakuco on #webkit).
3712
3713         * efl/jhbuildrc:
3714
3715 2012-08-29  Dominic Mazzoni  <dmazzoni@google.com>
3716
3717         AX: Canvas should have a distinct role
3718         https://bugs.webkit.org/show_bug.cgi?id=95248
3719
3720         Reviewed by Chris Fleizach.
3721
3722         Add support for canvas accessibility role.
3723
3724         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
3725         (roleToString):
3726
3727 2012-08-28  Eric Seidel  <eric@webkit.org>
3728
3729         cr-ews bot doesn't set CWD correctly when zipping layout test results
3730         https://bugs.webkit.org/show_bug.cgi?id=91265
3731
3732         Reviewed by Kenneth Russell.
3733
3734         This should make the zips slightly less cumbersome to deal with.
3735
3736         * Scripts/webkitpy/common/system/workspace.py:
3737         (Workspace.create_zip):
3738         * Scripts/webkitpy/common/system/workspace_unittest.py:
3739         (WorkspaceTest.test_create_zip):
3740         (WorkspaceTest.test_create_zip_exception):
3741
3742 2012-08-28  Benjamin Poulain  <benjamin@webkit.org>
3743
3744         Fix the Commiters script
3745
3746         Unreviewed.
3747
3748         Remove Roger Fong from the Contributor list, he appears in the Commiter list since r126949.
3749
3750         * Scripts/webkitpy/common/config/committers.py:
3751
3752 2012-08-28  Roger Fong  <roger_fong@apple.com>
3753
3754         Unreviewed. Adding myself to committers list.
3755
3756         * Scripts/webkitpy/common/config/committers.py:
3757
3758 2012-08-28  Roger Fong  <roger_fong@apple.com>
3759
3760         Add minires to list of required cygwin install packages.
3761         https://bugs.webkit.org/show_bug.cgi?id=76936
3762
3763         Reviewed by Tim Horton.
3764
3765         * CygwinDownloader/cygwin-downloader.py:
3766
3767 2012-08-28  Xianzhu Wang  <wangxianzhu@chromium.org>
3768
3769         [Chromium-Android] Upstream layout test expectations (Part 2)
3770         https://bugs.webkit.org/show_bug.cgi?id=95212
3771
3772         Reviewed by Adam Barth.
3773
3774         - Now run both gpu path and non-gpu path of 2d canvas layout tests
3775         because both are used in chromium-android.
3776
3777         - Exclude all webgl tests because webgl is not enabled yet.
3778
3779         - Removed 'win' from the baseline fallback list. This was a mistake.
3780
3781         - Moved some small directories to TestExpectations from skipped_layout_tests().
3782
3783         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3784         (ChromiumAndroidPort):
3785         (ChromiumAndroidPort.skipped_layout_tests):
3786
3787 2012-08-28  Joanmarie Diggs  <jdiggs@igalia.com>
3788
3789         Implement AccessibilityUIElement::titleUIElement() and AccessibilityUIElement::stringValue()
3790         https://bugs.webkit.org/show_bug.cgi?id=95185
3791
3792         Reviewed by Chris Fleizach.
3793
3794         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3795         (AccessibilityUIElement::titleUIElement): Implemented
3796         Gets the ATK_RELATION_LABELLED_BY target.
3797         (AccessibilityUIElement::stringValue): Implemented for all roles but ATK_ROLE_PANEL.
3798         Gets the string from atk_text_get_text(). Will implement for ATK_ROLE_PANEL after
3799         bug 95180 is fixed.
3800
3801 2012-08-28  Dominic Mazzoni  <dmazzoni@google.com>
3802
3803         AX: Crash due to object getting deleted inside updateBackingStore
3804         https://bugs.webkit.org/show_bug.cgi?id=94619
3805
3806         Reviewed by Chris Fleizach.
3807
3808         Change isValid to !isDetached after deleting isValid from
3809         chromium WebAccessibilityObject as being redundant.
3810
3811         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
3812         (AccessibilityUIElement::isValidGetterCallback):
3813
3814 2012-08-28  Sheriff Bot  <webkit.review.bot@gmail.com>
3815
3816         Unreviewed, rolling out r126914.
3817         http://trac.webkit.org/changeset/126914
3818         https://bugs.webkit.org/show_bug.cgi?id=95239
3819
3820         it breaks everything and fixes nothing (Requested by pizlo on
3821         #webkit).
3822
3823         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
3824         (MockWebSpeechInputController::addMockRecognitionResult):
3825         * DumpRenderTree/chromium/NotificationPresenter.cpp:
3826         (NotificationPresenter::simulateClick):
3827         (NotificationPresenter::show):
3828         * DumpRenderTree/chromium/TestRunner/CppBoundClass.cpp:
3829         (CppBoundClass::~CppBoundClass):
3830         (CppBoundClass::invoke):
3831         (CppBoundClass::getProperty):
3832         (CppBoundClass::setProperty):
3833         (CppBoundClass::bindCallback):
3834         (CppBoundClass::bindProperty):
3835         * DumpRenderTree/chromium/WebPreferences.cpp:
3836         (applyFontMap):
3837         * DumpRenderTree/chromium/WebViewHost.cpp:
3838         (WebViewHost::printResourceDescription):
3839         * DumpRenderTree/mac/TestRunnerMac.mm:
3840         (worldIDForWorld):
3841         (TestRunner::evaluateScriptInIsolatedWorld):
3842         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3843         (AccessibilityController::~AccessibilityController):
3844         (AccessibilityController::winNotificationReceived):
3845         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3846         (ResourceLoadDelegate::descriptionSuitableForTestResult):
3847         * DumpRenderTree/win/TestRunnerWin.cpp:
3848         (worldIDForWorld):
3849         (TestRunner::evaluateScriptInIsolatedWorld):
3850         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
3851         (TestWebKitAPI::DOMWindowExtensionBasic::willDestroyPage):
3852         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
3853         (TestWebKitAPI::DOMWindowExtensionNoCache::willDestroyPage):
3854         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3855         (WTR::TestRunner::worldIDForWorld):
3856         (WTR::TestRunner::evaluateScriptInIsolatedWorld):
3857
3858 2012-08-28  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
3859
3860         Rename first/second to key/value in HashMap iterators
3861         https://bugs.webkit.org/show_bug.cgi?id=82784
3862
3863         Reviewed by Eric Seidel.
3864
3865         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
3866         (MockWebSpeechInputController::addMockRecognitionResult):
3867         * DumpRenderTree/chromium/NotificationPresenter.cpp:
3868         (NotificationPresenter::simulateClick):
3869         (NotificationPresenter::show):
3870         * DumpRenderTree/chromium/TestRunner/CppBoundClass.cpp:
3871         (CppBoundClass::~CppBoundClass):
3872         (CppBoundClass::invoke):
3873         (CppBoundClass::getProperty):
3874         (CppBoundClass::setProperty):
3875         (CppBoundClass::bindCallback):
3876         (CppBoundClass::bindProperty):
3877         * DumpRenderTree/chromium/WebPreferences.cpp:
3878         (applyFontMap):
3879         * DumpRenderTree/chromium/WebViewHost.cpp:
3880         (WebViewHost::printResourceDescription):
3881         * DumpRenderTree/mac/TestRunnerMac.mm:
3882         (worldIDForWorld):
3883         (TestRunner::evaluateScriptInIsolatedWorld):
3884         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3885         (AccessibilityController::~AccessibilityController):
3886         (AccessibilityController::winNotificationReceived):
3887         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3888         (ResourceLoadDelegate::descriptionSuitableForTestResult):
3889         * DumpRenderTree/win/TestRunnerWin.cpp:
3890         (worldIDForWorld):
3891         (TestRunner::evaluateScriptInIsolatedWorld):
3892         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
3893         (TestWebKitAPI::DOMWindowExtensionBasic::willDestroyPage):
3894         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
3895         (TestWebKitAPI::DOMWindowExtensionNoCache::willDestroyPage):
3896         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3897         (WTR::TestRunner::worldIDForWorld):
3898         (WTR::TestRunner::evaluateScriptInIsolatedWorld):
3899
3900 2012-08-27  Jon Lee  <jonlee@apple.com>
3901
3902         Update TestRunner API for web notifications
3903         https://bugs.webkit.org/show_bug.cgi?id=95093
3904         <rdar://problem/12179649>
3905
3906         Reviewed by Jessie Berlin.
3907
3908         This is work toward providing Mac support for web notifications in DRT and WTR (77969).
3909
3910         Some of the legacy APIs are less than ideal, and not tenable with the WTR infrastructure.
3911         This first patch renames the TestRunner calls to use the term "web notifications" instead of
3912         "desktop notifications", deprecates a couple API calls that are not used by anyone, and adds
3913         additional calls that will be used in the tests that test the standard API.
3914
3915         * DumpRenderTree/TestRunner.h:
3916         (TestRunner): For consistency, rename a couple member variables. Remove unused checkDesktopNotificationPermission()
3917         and areDesktopNotificationPermissionRequestsIgnored(). Remove origin mapping since each port implements its own solution.
3918         * DumpRenderTree/TestRunner.cpp: Push grantWebNotificationPermission() to individual ports.
3919         (TestRunner::TestRunner):
3920         (ignoreLegacyWebNotificationPermissionRequestsCallback): Renamed.
3921         (simulateLegacyWebNotificationClickCallback): Renamed.
3922         (grantWebNotificationPermissionCallback): Renamed.
3923         (denyWebNotificationPermissionCallback): Added.
3924         (removeAllWebNotificationPermissionsCallback): Added.
3925         (simulateWebNotificationClickCallback): Added.
3926         (TestRunner::staticFunctions):
3927         (TestRunner::ignoreLegacyWebNotificationPermissionRequests):
3928
3929         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3930         (DRTTestRunner::DRTTestRunner): Added bindings for new APIs.
3931         (DRTTestRunner::grantWebNotificationPermission):
3932         (DRTTestRunner::denyWebNotificationPermission): Stub.
3933         (DRTTestRunner::removeAllWebNotificationPermissions): Stub.
3934         (DRTTestRunner::simulateWebNotificationClick): Stub.
3935         (DRTTestRunner::simulateLegacyWebNotificationClick):
3936         * DumpRenderTree/chromium/DRTTestRunner.h:
3937         (DRTTestRunner):
3938
3939         Added stubs.
3940         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
3941         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3942         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
3943         * DumpRenderTree/mac/TestRunnerMac.mm: Later patch will contain implementation of this API.
3944         * DumpRenderTree/qt/TestRunnerQt.cpp: Added Qt-based stubs.
3945         * DumpRenderTree/win/TestRunnerWin.cpp:
3946
3947 2012-08-28  Szilard Ledan  <szledan@inf.u-szeged.hu>
3948
3949         [webkit-patch] gets stuck into an infinite loop if bugzilla doesn't respond in time.
3950         https://bugs.webkit.org/show_bug.cgi?id=94700
3951
3952         Reviewed by Eric Seidel.
3953
3954         Interrupting download with a timeout would be a possible solution.
3955         I imported the socket module and used the setdefaulttimeout() method.
3956         Fixing it is important, because EWS bots need to be restarted regularly
3957         because of this bug.
3958
3959         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3960         (Bugzilla._get_browser):
3961         (Bugzilla.setdefaulttimeout):
3962
3963 2012-08-28  Gabor Rapcsanyi  <rgabor@webkit.org>
3964
3965         [Qt] Keep QT_QPA_PLATFORM_PLUGIN_PATH environment variable in NRWT
3966         https://bugs.webkit.org/show_bug.cgi?id=95194
3967
3968         Reviewed by Simon Hausmann.
3969
3970         * Scripts/webkitpy/layout_tests/port/qt.py:
3971         (QtPort.setup_environ_for_server):
3972
3973 2012-08-28  Andras Becsi  <andras.becsi@nokia.com>
3974
3975         [watchlist] Unreviewed, subscribe to Qt bugs.
3976
3977         * Scripts/webkitpy/common/config/watchlist:
3978
3979 2012-08-28  Simon Hausmann  <simon.hausmann@nokia.com>
3980
3981         [Qt] New test introduced in r126611 fails: fast/css/image-set-setting.html
3982         https://bugs.webkit.org/show_bug.cgi?id=95054
3983
3984         Reviewed by Eric Seidel.
3985
3986         Enable CSS_IMAGE_SET for the Qt build.
3987
3988         * qmake/mkspecs/features/features.pri:
3989
3990 2012-08-27  Csaba Osztrogonác  <ossy@webkit.org>
3991
3992         [Qt] Enable CSS sticky position
3993         https://bugs.webkit.org/show_bug.cgi?id=95172
3994
3995         Reviewed by Simon Hausmann.
3996
3997         * qmake/mkspecs/features/features.pri:
3998
3999 2012-08-27  Zan Dobersek  <zandobersek@gmail.com>
4000
4001         [GTK] Memory cache should be cleared in between test runs
4002         https://bugs.webkit.org/show_bug.cgi?id=95105
4003
4004         Reviewed by Martin Robinson.
4005
4006         Call the new DumpRenderTreeSupportGtk helper method after every test
4007         to clear the memory cache.
4008
4009         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4010         (runTest):
4011
4012 2012-08-27  Sheriff Bot  <webkit.review.bot@gmail.com>
4013
4014         Unreviewed, rolling out r126836.
4015         http://trac.webkit.org/changeset/126836
4016         https://bugs.webkit.org/show_bug.cgi?id=95163
4017
4018         Broke all Apple ports, EFL, and Qt. (Requested by tkent on
4019         #webkit).
4020
4021         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
4022         (MockWebSpeechInputController::addMockRecognitionResult):
4023         * DumpRenderTree/chromium/NotificationPresenter.cpp:
4024         (NotificationPresenter::simulateClick):
4025         (NotificationPresenter::show):
4026         * DumpRenderTree/chromium/TestRunner/CppBoundClass.cpp:
4027         (CppBoundClass::~CppBoundClass):
4028         (CppBoundClass::invoke):
4029         (CppBoundClass::getProperty):
4030         (CppBoundClass::setProperty):
4031         (CppBoundClass::bindCallback):
4032         (CppBoundClass::bindProperty):
4033         * DumpRenderTree/chromium/WebPreferences.cpp:
4034         (applyFontMap):
4035         * DumpRenderTree/chromium/WebViewHost.cpp:
4036         (WebViewHost::printResourceDescription):
4037         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
4038         (AccessibilityController::~AccessibilityController):
4039         (AccessibilityController::winNotificationReceived):
4040         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
4041         (ResourceLoadDelegate::descriptionSuitableForTestResult):
4042         * DumpRenderTree/win/TestRunnerWin.cpp:
4043         (worldIDForWorld):
4044         (TestRunner::evaluateScriptInIsolatedWorld):
4045         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
4046         (TestWebKitAPI::DOMWindowExtensionBasic::willDestroyPage):
4047         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
4048         (TestWebKitAPI::DOMWindowExtensionNoCache::willDestroyPage):
4049         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4050         (WTR::TestRunner::worldIDForWorld):
4051         (WTR::TestRunner::evaluateScriptInIsolatedWorld):
4052
4053 2012-08-27  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
4054
4055         Rename first/second to key/value in HashMap iterators
4056         https://bugs.webkit.org/show_bug.cgi?id=82784
4057
4058         Reviewed by Eric Seidel.
4059
4060         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
4061         (MockWebSpeechInputController::addMockRecognitionResult):
4062         * DumpRenderTree/chromium/NotificationPresenter.cpp:
4063         (NotificationPresenter::simulateClick):
4064         (NotificationPresenter::show):
4065         * DumpRenderTree/chromium/TestRunner/CppBoundClass.cpp:
4066         (CppBoundClass::~CppBoundClass):
4067         (CppBoundClass::invoke):
4068         (CppBoundClass::getProperty):
4069         (CppBoundClass::setProperty):
4070         (CppBoundClass::bindCallback):
4071         (CppBoundClass::bindProperty):
4072         * DumpRenderTree/chromium/WebPreferences.cpp:
4073         (applyFontMap):
4074         * DumpRenderTree/chromium/WebViewHost.cpp:
4075         (WebViewHost::printResourceDescription):
4076         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
4077         (AccessibilityController::~AccessibilityController):
4078         (AccessibilityController::winNotificationReceived):
4079         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
4080         (ResourceLoadDelegate::descriptionSuitableForTestResult):
4081         * DumpRenderTree/win/TestRunnerWin.cpp:
4082         (worldIDForWorld):
4083         (TestRunner::evaluateScriptInIsolatedWorld):
4084         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
4085         (TestWebKitAPI::DOMWindowExtensionBasic::willDestroyPage):
4086         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
4087         (TestWebKitAPI::DOMWindowExtensionNoCache::willDestroyPage):
4088         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4089         (WTR::TestRunner::worldIDForWorld):
4090         (WTR::TestRunner::evaluateScriptInIsolatedWorld):
4091
4092 2012-08-24  James Robinson  <jamesr@chromium.org>
4093
4094         WebGL should not flip textures on presentation if contents are unchanged
4095         https://bugs.webkit.org/show_bug.cgi?id=94961
4096
4097         Reviewed by Kenneth Russell.
4098
4099         Run some compositing webgl tests in threaded mode to catch regressions specific to that mode.
4100
4101         * Scripts/webkitpy/layout_tests/port/chromium.py:
4102         (ChromiumPort.virtual_test_suites):
4103
4104 2012-08-27  Gavin Peters  <gavinp@chromium.org>
4105
4106         [webkit-patch] Don't crash chrome-channels command when a previously unknown platform shows up.
4107         https://bugs.webkit.org/show_bug.cgi?id=95104
4108
4109         Reviewed by Adam Barth.
4110
4111         Today I found out this command was broken by the new iOS platform showing up on omahaproxy. Now the webkit-patch chrome-channels command gracefully handles new, previously unknown platforms. Also, it prints iOS in the proper mixed case.
4112
4113         * Scripts/webkitpy/common/net/omahaproxy.py:
4114         (OmahaProxy):
4115         (OmahaProxy.get_revisions):
4116         * Scripts/webkitpy/common/net/omahaproxy_unittest.py:
4117         (OmahaProxyTest):
4118         (OmahaProxyTest.test_get_revisions):
4119
4120 2012-08-27  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
4121
4122         [EFL][WK2] Free Url_Bar on program exit
4123         https://bugs.webkit.org/show_bug.cgi?id=95086
4124
4125         Reviewed by Eric Seidel.
4126
4127         Fix a memory leak by freeing the Url_Bar on program exit.
4128
4129         * MiniBrowser/efl/main.c:
4130         (main): Call url_bar_del() to free the Url_Bar.
4131
4132 2012-08-27  James Robinson  <jamesr@chromium.org>
4133
4134         [chromium] Fix exit code status logic in run-chromium-webkit-unit-tests
4135         https://bugs.webkit.org/show_bug.cgi?id=95115
4136
4137         Reviewed by Adam Barth.
4138
4139         Use VCSUtils utility function to check if webkit_unit_tests terminates normally so we generate a non-zero exit
4140         code if the unit tests crash.
4141
4142         * Scripts/run-chromium-webkit-unit-tests:
4143
4144 2012-08-27  Benjamin Poulain  <benjamin@webkit.org>
4145
4146         Add ECMAScript Number to String conversion to WTF::String
4147         https://bugs.webkit.org/show_bug.cgi?id=95016
4148
4149         Reviewed by Geoffrey Garen.
4150
4151         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
4152         (TestWebKitAPI::testNumberToStringECMAScript):
4153         (TestWebKitAPI): Add tests for String's ECMAString number conversion.
4154
4155 2012-08-27  Philippe Normand  <pnormand@igalia.com>
4156
4157         [GStreamer][Qt] WebAudio support
4158         https://bugs.webkit.org/show_bug.cgi?id=94806
4159
4160         Reviewed by Simon Hausmann.
4161
4162         * MiniBrowser/qt/qml/BrowserWindow.qml: Enable WebAudio support.
4163
4164 2012-08-27  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
4165
4166         Rename RegisterProtocolHandler API to NavigatorContentUtils
4167         https://bugs.webkit.org/show_bug.cgi?id=94920
4168
4169         Reviewed by Adam Barth.
4170
4171         Renamed 'register-protocol-handler' feature to 'navigator-content-utils'.
4172
4173         * Scripts/webkitperl/FeatureList.pm:
4174         * qmake/mkspecs/features/features.pri:
4175
4176 2012-08-24  Benjamin Poulain  <bpoulain@apple.com>
4177
4178         Unify Number to StringImpl conversion
4179         https://bugs.webkit.org/show_bug.cgi?id=94879
4180
4181         Reviewed by Geoffrey Garen.
4182
4183         Add testing for the new IntegerToStringConversion.
4184
4185         * TestWebKitAPI/CMakeLists.txt:
4186         * TestWebKitAPI/GNUmakefile.am:
4187         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4188         * TestWebKitAPI/Tests/WTF/IntegerToStringConversion.cpp: Added.
4189
4190 2012-08-23  James Robinson  <jamesr@chromium.org>
4191
4192         [chromium] Convert WebLayerTreeView interface into pure virtual
4193         https://bugs.webkit.org/show_bug.cgi?id=94866
4194
4195         Reviewed by Adrienne Walker.
4196
4197         Updates DumpRenderTree's WebViewHost to vend a WebCompositorOutputSurface so DumpRenderTree can run compositing
4198         tests.
4199
4200         * DumpRenderTree/DumpRenderTree.gypi:
4201         * DumpRenderTree/chromium/WebViewHost.cpp:
4202         (WebViewHost::createOutputSurface):
4203         * DumpRenderTree/chromium/WebViewHost.h:
4204         (WebViewHost):
4205         * DumpRenderTree/chromium/WebViewHostOutputSurface.cpp: Copied from Source/WebKit/chromium/src/WebLayerTreeViewImpl.h.
4206         (WebKit):
4207         (WebKit::WebViewHostOutputSurface::WebViewHostOutputSurface):
4208         (WebKit::WebViewHostOutputSurface::~WebViewHostOutputSurface):
4209         (WebKit::WebViewHostOutputSurface::bindToClient):
4210         (WebKit::WebViewHostOutputSurface::capabilities):
4211         (WebKit::WebViewHostOutputSurface::context3D):
4212         (WebKit::WebViewHostOutputSurface::sendFrameToParentCompositor):
4213         * DumpRenderTree/chromium/WebViewHostOutputSurface.h: Copied from Source/WebKit/chromium/src/WebLayerTreeViewImpl.h.
4214         (WebKit):
4215         (WebViewHostOutputSurface):
4216
4217 2012-08-24  Xianzhu Wang  <wangxianzhu@chromium.org>
4218
4219         [Chromium-Android] Many 'Unexpected EOF ...' when a test crashes
4220         https://bugs.webkit.org/show_bug.cgi?id=94865
4221
4222         Reviewed by Dirk Pranke.
4223
4224         Android detects crash of test by checking if the return value of read() is None.
4225         Added a parameter 'treat_no_data_as_crash' to let ServerProcess know the special requirement of Android.
4226         If set, ServerProcess will set _crashed unconditionaly when there is no data.
4227
4228         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
4229         (ChromiumAndroidPort.__init__):
4230         (ChromiumAndroidPort):
4231         (ChromiumAndroidPort._android_server_process_constructor):
4232         (ChromiumAndroidDriver._start_once):
4233         * Scripts/webkitpy/layout_tests/port/server_process.py:
4234         (ServerProcess.__init__):
4235         (ServerProcess._wait_for_data_and_update_buffers_using_select):
4236
4237 2012-08-24  Arnaud Renevier  <a.renevier@sisa.samsung.com>
4238
4239         build-webkit --gtk fails with Can't exec ""
4240         https://bugs.webkit.org/show_bug.cgi?id=94944
4241
4242         Reviewed by Martin Robinson.
4243
4244         When jhbuild wrapper is not needed, do unshift a blank string to build
4245         arguments.
4246
4247         * Scripts/webkitdirs.pm:
4248         (runAutogenForAutotoolsProjectIfNecessary):
4249
4250 2012-08-24  Tommy Widenflycht  <tommyw@google.com>
4251
4252         MediaStream API: Add readyState functionality to RTCPeerConnection
4253         https://bugs.webkit.org/show_bug.cgi?id=94813
4254
4255         Reviewed by Adam Barth.
4256
4257         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
4258         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
4259         (MockWebRTCPeerConnectionHandler::stop):
4260         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
4261         (MockWebRTCPeerConnectionHandler):
4262
4263 2012-08-24  Michael Brüning  <michaelbruening@gmail.com>
4264
4265         Unreviewed. Adding myself to committers list.
4266
4267         Also updated email information.
4268
4269         * Scripts/webkitpy/common/config/committers.py:
4270
4271 2012-08-24  Michael Brüning  <michaelbruening@gmail.com>
4272
4273         [Qt][WK2] Make viewport related experimental.test properties encapsulated.
4274         https://bugs.webkit.org/show_bug.cgi?id=88320
4275
4276         Reviewed by Kenneth Rohde Christiansen.
4277
4278         Changed the access to the viewport attributes to use the viewport object that is introduced by this change.
4279
4280         * MiniBrowser/qt/qml/ViewportInfoItem.qml:
4281
4282 2012-08-23  Dirk Pranke  <dpranke@chromium.org>
4283
4284         leak detection broken after r126247 on mac
4285         https://bugs.webkit.org/show_bug.cgi?id=94893
4286
4287         Unreviewed, build fix.
4288
4289         Adds is_snowleopard(), is_lion back() in for the mac port. We'll
4290         probably need an is_mountainlion() or equivalent at some point,
4291         I'm guessing (but I've deleted the leopard code).
4292
4293         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
4294         (LeakDetector._callstacks_to_exclude_from_leaks):
4295         * Scripts/webkitpy/layout_tests/port/mac.py:
4296         (MacPort):
4297         (MacPort.is_snowleopard):
4298         (MacPort.is_lion):
4299
4300 2012-08-23  Julien Chaffraix  <jchaffraix@webkit.org>
4301
4302         [Chromium] Enable AtomicString && CString && WTFString && StringImpl unit tests
4303         https://bugs.webkit.org/show_bug.cgi?id=94871
4304
4305         Reviewed by Benjamin Poulain.
4306
4307         * TestWebKitAPI/TestWebKitAPI.gypi:
4308         Added the missing files to Chromium's build system.
4309
4310 2012-08-23  Raphael Kubo da Costa  <rakuco@webkit.org>
4311
4312         [watchlist] Unreviewed, subscribe to WebKit2-EFL bugs.
4313
4314         * Scripts/webkitpy/common/config/watchlist:
4315
4316 2012-08-23  Ryosuke Niwa  <rniwa@webkit.org>
4317
4318         Replay tests take forever to load
4319         https://bugs.webkit.org/show_bug.cgi?id=94764
4320
4321         Reviewed by Adam Barth.
4322
4323         Don't load about:blank at the beginning. This appears to clog the DRT.
4324
4325         * Scripts/webkitpy/performance_tests/perftest.py:
4326         (ReplayPerfTest.run_single):
4327         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
4328         (TestReplayPerfTest.test_run_single):
4329         (TestReplayPerfTest.test_run_single_fails_when_output_has_error):
4330
4331 2012-08-23  Kenneth Russell  <kbr@google.com>
4332
4333  &