ed30d72613c5f990479bcb29f1456dc5655ad7f9
[WebKit-https.git] / Tools / ChangeLog
1 2011-05-17  Nat Duca  <nduca@chromium.org>
2
3         Reviewed by James Robinson.
4
5         [chromium] Implement CCLayerTreeHost and CCLayerTreeHostImpl portions of threaded compositor
6         https://bugs.webkit.org/show_bug.cgi?id=58408
7
8         * DumpRenderTree/chromium/WebViewHost.cpp:
9         (WebViewHost::paintInvalidatedRegion):
10
11 2011-06-24  Dominic Cooney   <dominicc@chromium.org>
12
13         Reviewed by Dimitri Glazkov.
14
15         Convert shadow DOM-related tests to use window.internals
16         https://bugs.webkit.org/show_bug.cgi?id=61671
17
18         Remove ensureShadowRoot, shadowRoot, shadowPseudoId and
19         removeShadowRoot from layoutTestController; these have been
20         replaced by equivalents in window.internals instead.
21
22         * DumpRenderTree/LayoutTestController.cpp:
23         (LayoutTestController::staticFunctions):
24         * DumpRenderTree/LayoutTestController.h:
25         * DumpRenderTree/chromium/LayoutTestController.cpp:
26         (LayoutTestController::LayoutTestController):
27         * DumpRenderTree/chromium/LayoutTestController.h:
28         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
29         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
30         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
31         * DumpRenderTree/qt/LayoutTestControllerQt.h:
32         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
33         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
34         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
35         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
36         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
37
38 2011-06-24  Csaba Osztrogonác  <ossy@webkit.org>
39
40         Reviewed by Dirk Schulze.
41
42         Make run-bindings-tests remove its temporary directories.
43         https://bugs.webkit.org/show_bug.cgi?id=63320
44
45         * Scripts/run-bindings-tests:
46
47 2011-06-23  MORITA Hajime  <morrita@google.com>
48
49         Reviewed by Kent Tamura.
50
51         [Chromium] Invalid write inside WebKit::FrameLoaderClientImpl::dispatchDidClearWindowObjectInWorld
52         https://bugs.webkit.org/show_bug.cgi?id=63216
53
54         Deleted m_webViewHost which looks leaked.
55         
56         * DumpRenderTree/chromium/TestShell.h:
57         * DumpRenderTree/chromium/TestShell.cpp:
58         (TestShell::~TestShell):
59
60 2011-06-24  Carlos Garcia Campos  <cgarcia@igalia.com>
61
62         Unreviewed. Fix WebKit2 GTK build.
63
64         * WebKitTestRunner/GNUmakefile.am:
65
66 2011-06-23  Ryuan Choi  <ryuan.choi@samsung.com>
67
68         Unreviewed, add myself as committer.
69
70         * Scripts/webkitpy/common/config/committers.py:
71
72 2011-06-23  Nat Duca  <nduca@chromium.org>
73
74         Unreviewed, add myself as committer.
75
76         * Scripts/webkitpy/common/config/committers.py:
77
78 2011-06-23  Dirk Pranke  <dpranke@chromium.org>
79
80         Reviewed by Tony Chang.
81
82         nrwt: move http locking code into manager
83         https://bugs.webkit.org/show_bug.cgi?id=63103
84
85         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
86         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
87
88 2011-06-23  Alok Priyadarshi  <alokp@chromium.org>
89
90         Reviewed by James Robinson.
91
92         [chromium] Add support for running layout tests with accelerated rendering
93         https://bugs.webkit.org/show_bug.cgi?id=63274
94
95         * Scripts/webkitpy/layout_tests/port/chromium.py:
96         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
97
98 2011-06-23  Adam Roben  <aroben@apple.com>
99
100         Avoid fetching JSON data when possible on TestFailures page to determine if
101         old-run-webkit-tests exited early
102
103         As of r89610, results.html includes information about whether old-run-webkit-tests exited
104         early, so we don't need to look at JSON data to get this information for builds newer than
105         that.
106
107         Fixes <http://webkit.org/b/63281> TestFailures page fetches build JSON for every build,
108         which is slow and limits history to the last build master restart
109
110         Reviewed by David Kilzer.
111
112         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
113         (Builder.prototype._getFailingTests): Moved code dealing with results.html into a new
114         function. If we're dealing with a build that has early-exit information in results.html,
115         don't bother fetching JSON data and go straight to parsing results.html. Otherwise first use
116         the JSON data to determine if old-run-webkit-tests exited early, and then parse results.html
117         (as before).
118
119 2011-06-23  Eric Seidel  <eric@webkit.org>
120
121         Reviewed by Adam Barth.
122
123         sheriffbot can no longer restart
124         https://bugs.webkit.org/show_bug.cgi?id=63221
125
126         Fixed and unit tested.
127
128         * Scripts/webkitpy/tool/bot/queueengine.py:
129         * Scripts/webkitpy/tool/bot/sheriffircbot.py:
130         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
131
132 2011-06-23  Martin Robinson  <mrobinson@igalia.com>
133
134         Reviewed by Xan Lopez.
135
136         [GTK] [WebKit2] WebKitTestRunner does not properly load TestNetscapePlugin
137         https://bugs.webkit.org/show_bug.cgi?id=63287
138
139         Send the path to the TestNetscapePlugin to the WKTR via an environment variable
140         so that the plugin loads properly.
141
142         * Scripts/old-run-webkit-tests: Pass the appropriate environment variable to WKTR.
143         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
144         (WTR::getEnvironmentVariableAsUTF8String): Added this helper which abstracts away some
145         of the work for getting an environment variable and converting it to UTF-8.
146         (WTR::TestController::initializeInjectedBundlePath): Use the helper.
147         (WTR::TestController::initializeTestPluginDirectory): Get the path from an environment variable now.
148
149 2011-06-23  Adam Roben  <aroben@apple.com>
150
151         Record whether old-run-webkit-tests aborted early in results.html
152
153         Fixes <http://webkit.org/b/63280> results.html gives no indication of whether
154         old-run-webkit-tests stopped running tests early
155
156         Reviewed by David Kilzer.
157
158         * Scripts/old-run-webkit-tests:
159         (top level): Switched to heredoc syntax for printing the start of results.html for clarity.
160         Added a <style> element with some styles for the new message. If we stopped running early,
161         put the reason why at the top of results.html.
162         (stopRunningTestsEarlyIfNeeded): Store the message we print in the new
163         $stoppedRunningEarlyMessage global.
164
165 2011-06-23  Adam Roben  <aroben@apple.com>
166
167         Cache some of the TestFailures page's data in localStorage
168
169         This makes reloading TestFailures much faster. Right now we only store the number of failing
170         tests and the list of failing tests for each build. We may choose to store more later, but
171         it's easy to run up against quota limits.
172
173         Fixes <http://webkit.org/b/61520> TestFailures page should take advantage of LocalStorage
174         APIs (or similar) to improve loading performance
175
176         Reviewed by David Kilzer.
177
178         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
179         (Builder.prototype.getNumberOfFailingTests): Changed to use the new PersistentCache object.
180         (Builder.prototype.startFetchingBuildHistory): Changed to pass whether or not we're still
181         fetching data to the callback.
182         (Builder.prototype._getFailingTests): Changed to use the new PersistentCache object. We now
183         store the tests in the cache just before calling the callback. (The previous code in this
184         function relied on being able to modify the tests object after storing it in the cache and
185         having the cached version be updated. This worked while it was a non-serialized cache, but
186         PersistentCache uses serialization.)
187
188         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/PersistentCache.js: Added.
189         (PersistentCache): This object wraps localStorage. It uses JSON to serialize/deserialize
190         values, and stores the date that each value was initially stored along with it. This is
191         later used for pruning the cache.
192         (PersistentCache.contains): Checks whether the key exists in localStorage.
193         (PersistentCache.get): Fetch the string we stored in localStorage and extract the original
194         value out of it.
195         (PersistentCache.set): Serialize the value, add the date to it, and store it in
196         localStorage. If this fails due to quota limits, empty the whole cache and try again.
197         (PersistentCache.prune): Delete any cached data that is deemed old enough.
198         (PersistentCache._addDateToJSONString): Prepend the current date to the string.
199         (PersistentCache._emptyCache): Delete everything from localStorage.
200         (PersistentCache._parseDateAndJSONFromString): Split apart the date and the JSON string and
201         return them.
202
203         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
204         (ViewController.prototype._displayBuilder): Updated for change to callback signature. When
205         we finish fetching data, prune the PersistentCache. While I was here I also fixed a bug
206         where we'd never show the new bug link for tests for which we couldn't determine a passing
207         revision.
208
209         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pull in
210         PersistentCache.js.
211
212 2011-06-23  Adam Roben  <aroben@apple.com>
213
214         Make finding existing bugs and filing new bugs work on TestFailures even when lots of tests are failing
215
216         One bug this fixes is <http://webkit.org/b/61660> New bug links on TestFailures page often
217         contain titles that are so long they are rejected by Bugzilla
218
219         Reviewed by David Kilzer.
220
221         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js:
222         (Bugzilla.prototype.quickSearch): Use fetchResource to POST the search query rather than
223         using a query string on the URL. If the search query is very long, using a query string can
224         cause the request to be rejected due to the URL being too long. POSTing avoids this issue.
225         (Bugzilla.maximumBugTitleLength): Added this constant based on Bugzilla's implementation.
226
227         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
228         (.new-bug-form): Hide the form that we secretly use to file a new bug.
229
230         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:
231         (fetchResource): Added. Code came from getResource. If we're using a GET request, add the
232         query parameters to the URL. Otherwise, send them as the body of the request along with the
233         appropriate headers.
234         (getResource): Now just calls through to fetchResource.
235         (urlEncodedQueryParameters): Added. Moved some code here...
236         (addQueryParametersToURL): ...from here.
237
238         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
239         (ViewController.prototype._domForNewAndExistingBugs): Shorten the title to just mention the
240         number of failing tests if mentioning all the tests would make the title too long. Improved
241         the description for large numbers of failures by listing the tests one-per-line instead of
242         just having them be comma-separated, which was hard to read. Use a form to file the new bug
243         instead of a link so that we can POST the form data. (Using a URL with a query string can
244         result in the URL being too long.) The new bug link now just submits the form.
245
246 2011-06-23  Adam Roben  <aroben@apple.com>
247
248         Show closed bugs on the TestFailures page in addition to open ones
249
250         Fixes <http://webkit.org/b/63194> TestFailures page should show closed bugs, too
251
252         Reviewed by David Kilzer.
253
254         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js:
255         (Bugzilla.prototype.quickSearch): Added code to extract the bug's status and store it in the
256         returned data.
257         (Bugzilla.isOpenStatus): New function, returns true if the passed-in status indicates that
258         the associated bug is still open.
259
260         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:
261         (addQueryParametersToURL): Add a missing semicolon.
262         (Node.prototype.appendChildren): New function, like appendChild but takes an array-like
263         object and appends each of the values stored within.
264
265         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
266         (ViewController.prototype._domForNewAndExistingBugs): Prepend 'ALL' to the query so closed
267         bugs will be included in the results. Split the returned bugs into two sets: those which are
268         open, and those which are closed. Put the open bugs at the top level of the list, and the
269         closed bugs in a second level.
270
271 2011-06-23  Adam Roben  <aroben@apple.com>
272
273         Don't count new tests as failures on the TestFailures page
274
275         Fixes <http://webkit.org/b/63254> TestFailures page calls new tests "failures", even though
276         they aren't
277
278         Reviewed by Anders Carlsson.
279
280         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
281         (Builder.prototype.getNumberOfFailingTests): Don't add the number of new tests to the number
282         of failures.
283
284 2011-06-23  Dirk Pranke  <dpranke@chromium.org>
285
286         Reviewed by Eric Seidel.
287
288         nrwt: make TestInput objects printable
289         https://bugs.webkit.org/show_bug.cgi?id=63225
290
291         This makes debugging slighlty easier.
292
293         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
294
295 2011-06-22  Daniel Bates  <dbates@webkit.org>
296
297         Reviewed by Adam Barth.
298
299         test-webkitpy --all errors out because scm_unittest.py can't find module checkout
300         https://bugs.webkit.org/show_bug.cgi?id=62943
301
302         Remove "from .checkout import Checkout" from scm_unittest.py since it's included
303         by Scripts/webkitpy/common/checkout/__init__.py.
304
305         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
306
307 2011-06-22  Dominic Cooney  <dominicc@chromium.org>
308
309         Reviewed by Mark Rowe.
310
311         Add window.internals to WebKit2's WebKitTestRunner.
312         https://bugs.webkit.org/show_bug.cgi?id=61073
313
314         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pxbproj:
315         * WebKitTestRunner/Configurations/Base.xcconfig:
316         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops:
317         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
318         * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops:
319         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
320         (WTR::InjectedBundlePage::didClearWindowForFrame):
321         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
322         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
323
324 2011-06-22  Eric Seidel  <eric@webkit.org>
325
326         Reviewed by Adam Barth.
327
328         Make sheriff-bot rollout messages a little nicer
329         https://bugs.webkit.org/show_bug.cgi?id=63107
330
331         itertools.chain.from_iterable is new in 2.6,
332         use itertools.chain(*list) for 2.5 compat.
333
334         * Scripts/webkitpy/tool/bot/irc_command.py:
335
336 2011-06-22  Eric Seidel  <eric@webkit.org>
337
338         Reviewed by Adam Barth.
339
340         Make sheriff-bot robust against exceptions from commands
341         https://bugs.webkit.org/show_bug.cgi?id=63211
342
343         sheriff-bot was acting strange this afternoon.
344         We don't know if this will fix the cause, but
345         at least it adds some unit tests and catches
346         one possible cause.
347
348         * Scripts/webkitpy/tool/bot/sheriffircbot.py:
349         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
350
351 2011-06-22  Mark Rowe  <mrowe@apple.com>
352
353         Reviewed by David Levin.
354
355         <http://webkit.org/b/63212> TestWebKitAPI Xcode project has bogus settings since r86287
356
357         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Fix the reference to libgtest.a to
358         be relative to the built products directory rather than using a hard-coded path. Remove the
359         explicit settings of FRAMEWORK_SEARCH_PATHS, HEADER_SEARCH_PATHS and LIBRARY_SEARCH_PATHS
360         as they're all unnecessary. If they were necessary they should be set in the .xcconfig file
361         rather than in the .xcodeproj directly.
362
363 2011-06-22  Dirk Pranke  <dpranke@chromium.org>
364
365         Reviewed by Ojan Vafai.
366
367         new-run-webkit-tests: remove obsolete port.shut_down_http_server method
368         https://bugs.webkit.org/show_bug.cgi?id=59993
369
370         * Scripts/webkitpy/layout_tests/port/base.py:
371         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
372         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
373         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
374         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
375         * Scripts/webkitpy/layout_tests/port/gtk.py:
376         * Scripts/webkitpy/layout_tests/port/mac.py:
377         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
378         * Scripts/webkitpy/layout_tests/port/qt.py:
379         * Scripts/webkitpy/layout_tests/port/win.py:
380
381 2011-06-22  Luke Macpherson   <macpherson@chromium.org>
382
383         Reviewed by Andreas Kling.
384
385         Move macpherson from contributor list to committer list.
386         https://bugs.webkit.org/show_bug.cgi?id=63179
387
388         * Scripts/webkitpy/common/config/committers.py:
389         Move macpherson from contributor list to committer list.
390
391 2011-06-22  David Levin  <levin@chromium.org>
392
393         Reviewed by Adam Barth.
394
395         check-webkit-style should detect returning (Own|Ref)Ptr instead of the Pass*Ptr version.
396         https://bugs.webkit.org/show_bug.cgi?id=63204
397
398         * Scripts/webkitpy/style/checkers/cpp.py: Added a check for the return value and combined
399           with similar code for the parameter checking.
400         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Removed pass_ptr checks from
401           those done for single lines since they don't make sense in that case (variable decls look like function decls).
402           Removed some redundant comments (one of which was slightly wrong).
403           Added checks for the new functionality and minor other test changes.
404
405 2011-06-22  Nate Chapin  <japhet@chromium.org>
406
407         Reviewed by Adam Barth.
408
409         Add libsoup to libWebCoreInternals build.
410         https://bugs.webkit.org/show_bug.cgi?id=62066
411
412         * GNUmakefile.am:
413
414 2011-06-22  Dirk Pranke  <dpranke@chromium.org>
415
416         Reviewed by Tony Chang.
417
418         nrwt: handle missing httpd cleanly
419         https://bugs.webkit.org/show_bug.cgi?id=62027
420
421         We had reverted the change in r89414, so this adds it back in
422         (modifying check_sys_deps() in port/base.py to check for an
423         installed web server).
424
425         This change then fixes the change in r89414 to stub out the
426         check_sys_deps() in the test port so that the unit tests run correctly.
427
428         * Scripts/webkitpy/layout_tests/port/base.py:
429         * Scripts/webkitpy/layout_tests/port/test.py:
430
431 2011-06-22  David Levin  <levin@chromium.org>
432
433         Reviewed by Adam Barth.
434
435         check-webkit-style should check for invalid uses of RefPtr/OwnPtr as parameters.
436         https://bugs.webkit.org/show_bug.cgi?id=63188
437
438         * Scripts/webkitpy/style/checkers/cpp.py: Added the check.
439         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
440
441 2011-06-22  Tony Chang  <tony@chromium.org>
442
443         Reviewed by Ojan Vafai.
444
445         Add a buildbot for testing ENABLE(CSS3_FLEXBOX)
446         https://bugs.webkit.org/show_bug.cgi?id=62891
447
448         * BuildSlaveSupport/build.webkit.org-config/config.json:
449
450 2011-06-22  Dirk Pranke  <dpranke@chromium.org>
451
452         Reviewed by Ojan Vafai.
453
454         nrwt: don't look for http lock when running the test port
455         https://bugs.webkit.org/show_bug.cgi?id=63158
456
457         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
458         * Scripts/webkitpy/layout_tests/port/test.py:
459
460 2011-06-22  Balazs Kelemen  <kbalazs@webkit.org>
461
462         Reviewed by Andreas Kling.
463
464         [Qt][WK2] Set up plugin tests
465         https://bugs.webkit.org/show_bug.cgi?id=63066
466
467         * WebKitTestRunner/qt/TestControllerQt.cpp:
468         (WTR::TestController::initializeTestPluginDirectory):
469         Use the QTWEBKIT_PLUGIN_PATH environment variable as the path
470         of the test plugin like DRT does.
471
472 2011-06-22  Eric Seidel  <eric@webkit.org>
473
474         Reviewed by Ojan Vafai.
475
476         Make sheriff-bot rollout messages a little nicer
477         https://bugs.webkit.org/show_bug.cgi?id=63107
478
479         It annoyed me this afternoon that I had to convert sheriff-bots "r12345" revisions
480         into urls myself.  So I have now fixed its "preparing" message to include a url.
481
482         I also figured that I should make the messages mention all of the responsible parties
483         so that rollouts are never surprises.  If you're in the channel and were involved
484         in a patch, you will see if someone is using sheriff-bot to rollout a patch.
485
486         As part of doing this I also changed (and tested) _parse_args to fail-fast
487         when given invalid args.
488
489         * Scripts/webkitpy/tool/bot/irc_command.py:
490         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
491         * Scripts/webkitpy/tool/bot/sheriff.py:
492         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
493
494 2011-06-22  Dirk Pranke  <dpranke@chromium.org>
495
496         Reviewed by Tony Chang.
497
498         run-webkit-websocketserver fails to stop websocket server
499         https://bugs.webkit.org/show_bug.cgi?id=63123
500
501         There's a ten-character change in new-run-webkit-websocketserver
502         that fixes the actual bug, and then we update the code in
503         new-run-webkit-httpd to do the actual stop call, and add more tests
504         (refactoring the existing test code so that it is shared).
505
506         * Scripts/new-run-webkit-httpd:
507         * Scripts/new-run-webkit-websocketserver:
508         * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py:
509
510 2011-06-22  Adam Roben  <aroben@apple.com>
511
512         Add links to existing bugs related to failing tests on TestFailures page
513
514         I changed the layout of the page a little to make it easier to read with all the new
515         information. Passing/failing revisions have been moved down below the list of tests to be
516         closer to the existing bugs and the new bug link. And each set of tests and its relevant
517         information is in a light gray box.
518
519         Fixes <http://webkit.org/b/61665> TestFailures page should link to existing bugs when
520         possible
521
522         Reviewed by Darin Adler.
523
524         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js: Added.
525         (Bugzilla): This new class represents a single Bugzilla instance.
526         (Bugzilla.prototype.quickSearch): Searches Bugzilla using its Quick Search functionality,
527         passing the resulting bug titles and URLs to the callback when complete. If called multiple
528         times with the same query before the query returns, caches the callbacks so that only one
529         query is sent over the wire. When the query completes, all pending callbacks are called.
530
531         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
532         (#failure-history): Reduce the margin/padding on the top-level list a bit.
533         (#failure-history > li): Put each set of tests in a gray box, and indent most information
534         inside the box.
535         (.test-list): Unindent the list of failing tests so it is visually at the top level.
536         (.new-and-existing-bugs): Reduce the space at the bottom of this area so that the bottom of
537         each box isn't a big empty space.
538         (.existing-bugs-list): Use a smaller text size for existing bugs, since their titles can be
539         quite long.
540
541         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:
542         (addQueryParametersToURL): New function extracted from
543         ViewController.prototype._domForNewAndExistingBugs.
544
545         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
546         (ViewController): Take and store an optional Bugzilla instance.
547         (ViewController.prototype._displayBuilder): Give the top-level list an id for styling
548         purposes and move the list of failing tests above all other information. Only show bug
549         information once we've determined the most-recent passing revision for a set of tests. It's
550         not that useful to file a new bug before this information has been determined, and searching
551         for existing bugs before we've figured out which tests started failing at the same time
552         would end up giving you information about a bunch of unrelated tests.
553         (ViewController.prototype._domForNewAndExistingBugs): Renamed from _domForNewBugLink. Now
554         returns a DocumentFragment instead of an HTMLParagraphElement. If we don't have a Bugzilla
555         instance, just returns an empty DocumentFragment. Starts a search for bugs related to the
556         failing tests, and adds links to the bugs when the search completes.
557
558         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pass a
559         Bugzilla instance for bugs.webkit.org to the ViewController.
560
561 2011-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
562
563         Reviewed by Martin Robinson.
564
565         [GTK] Apply current view settings to newly created views in GtkLauncher
566         https://bugs.webkit.org/show_bug.cgi?id=63142
567
568         * GtkLauncher/main.c:
569         (createWebViewCb):
570
571 2011-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
572
573         Reviewed by Martin Robinson.
574
575         [GTK] Use GOption to parse main arguments in GtkLauncher
576         https://bugs.webkit.org/show_bug.cgi?id=63060
577
578         Instead of getting the settings from the view, create a new
579         settings object not associated with any view so that we can parse
580         the command line arguments before creating the view. It will also
581         allows to use the same settings for more than one view if we
582         eventually support passing more than one uri from the command
583         line.
584
585         * GtkLauncher/main.c:
586         (parseOptionEntryCallback): Make this function static. Also use
587         g_ascii_strtoll/g_ascii_strtod to parse int/float values instead
588         of atoi/atof to provide better error messages. And always fill the
589         error struct when the function fails.
590         (getOptionEntriesFromWebKitWebSettings): Use an array of
591         GOptionEntry structs instead of a GArray, since that is what
592         g_option_group_add_entries() expects and the array size doesn't
593         change.
594         (addWebSettingsGroupToContext): Helper function to add the
595         websettings group to the option context.
596         (main): Create the option context to parse command line arguments.
597
598 2011-06-22  Martin Robinson  <mrobinson@igalia.com>
599
600         Reviewed by Adam Roben.
601
602         [GTK] Implement pixel dump support for WebKitTestRunner
603         https://bugs.webkit.org/show_bug.cgi?id=58242
604
605         * DumpRenderTree/gtk/GNUmakefile.ImageDiff.am: Added.
606         * GNUmakefile.am: Separate out the ImageDiff bits of the GNUmakefile.
607         * Scripts/old-run-webkit-tests: Update to add support for the GTK+ port.
608         * WebKitTestRunner/GNUmakefile.am: Added Cairo specific files to the build.
609         * WebKitTestRunner/TestInvocation.cpp: Moved this code to the platform-independent
610         file so that we can share it across platforms.
611         (WTR::TestInvocation::compareActualHashToExpectedAndDumpResults):
612         * WebKitTestRunner/TestInvocation.h: Updated method list.
613         * WebKitTestRunner/cairo/TestInvocationCairo.cpp: Added Cairo implementation.
614         * WebKitTestRunner/cg/TestInvocationCG.cpp:
615         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Updated to use new helper.
616
617 2011-06-22  Sheriff Bot  <webkit.review.bot@gmail.com>
618
619         Unreviewed, rolling out r89414.
620         http://trac.webkit.org/changeset/89414
621         https://bugs.webkit.org/show_bug.cgi?id=63130
622
623         It broke webkitpy tests (Requested by Ossy on #webkit).
624
625         * Scripts/webkitpy/layout_tests/port/base.py:
626
627 2011-06-22  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
628
629         Reviewed by Dirk Pranke.
630
631         [NRWT] Print error message when there is no httpd present on the system
632         https://bugs.webkit.org/show_bug.cgi?id=62027
633
634         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
635
636 2011-06-21  Dirk Pranke  <dpranke@chromium.org>
637
638         Unreviewed, build fix.
639         Fix crashes in new-run-webkit-tests resulting from the
640         change to the http_server logic in r89400. Python 2.5
641         on Mac 10.5 has some weird error paths.
642
643         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
644         * Scripts/webkitpy/common/system/executive.py:
645
646 2011-06-21  MORITA Hajime  <morrita@google.com>
647
648         Unreviewed, rolling out r89401 and r89403.
649         http://trac.webkit.org/changeset/89401
650         http://trac.webkit.org/changeset/89403
651         https://bugs.webkit.org/show_bug.cgi?id=62970
652
653         Breaks mac build and mistakenly enables the spellcheck API
654
655         * Scripts/build-webkit:
656         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
657
658 2011-06-21  Kent Tamura  <tkent@chromium.org>
659
660         [Mac] Sort Xcode project files.
661
662         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
663
664 2011-06-20  MORITA Hajime  <morrita@google.com>
665
666         Reviewed by Kent Tamura.
667
668         Spellcheck API should be build-able.
669         https://bugs.webkit.org/show_bug.cgi?id=62970
670
671         * Scripts/build-webkit:
672
673 2011-06-21  Dirk Pranke  <dpranke@chromium.org>
674
675         Reviewed by Tony Chang.
676
677         nrwt: attempt #3 at fixing server startup/shutdown
678         https://bugs.webkit.org/show_bug.cgi?id=62829
679
680         Attempt yet again to make starting and stopping servers
681         reliable. It turns out that apache has races between when the
682         ctl process exists and when it writes/removes the pid file.
683         This change accounts for the races.
684
685         * Scripts/new-run-webkit-httpd:
686         * Scripts/webkitpy/common/system/executive.py:
687         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
688         * Scripts/webkitpy/layout_tests/port/base.py:
689         * Scripts/webkitpy/layout_tests/port/http_server.py:
690         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
691         * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Added.
692         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
693         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
694
695 2011-06-21  Dmitry Lomov  <dslomov@google.com>
696
697         Reviewed by Adam Roben.
698
699         https://bugs.webkit.org/show_bug.cgi?id=63080
700         Unit-tests step on test-only bot is broken.
701         Removing the step until run-api-tests is fixed.
702
703         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
704
705 2011-06-20  Dmitry Lomov  <dslomov@google.com>
706
707         Reviewed by David Levin.
708
709         https://bugs.webkit.org/show_bug.cgi?id=63017
710         "Unit tests" step on bots should provide more information in case of failure.
711
712         * BuildSlaveSupport/build.webkit.org-config/master.cfg: added --verbose flag to UnitTests step.
713
714 2011-06-20  Dirk Pranke  <dpranke@chromium.org>
715
716         Reviewed by Ojan Vafai.
717
718         new-run-webkit-tests: order shards by name, not number of tests
719         https://bugs.webkit.org/show_bug.cgi?id=62753
720
721         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
722
723 2011-06-20  Dirk Pranke  <dpranke@chromium.org>
724
725         Reviewed by Ojan Vafai.
726
727         we should only log the test names to the tests_run.txt files during layout_tests
728         https://bugs.webkit.org/show_bug.cgi?id=62751
729
730         * Scripts/old-run-webkit-tests:
731         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
732
733 2011-06-20  Eric Seidel  <eric@webkit.org>
734
735         Reviewed by Adam Barth.
736
737         commit-queue/ews-bots should run run-bindings-tests for every patch
738         https://bugs.webkit.org/show_bug.cgi?id=63010
739
740         * Scripts/webkitpy/common/config/ports.py:
741         * Scripts/webkitpy/tool/commands/download_unittest.py:
742         * Scripts/webkitpy/tool/steps/runtests.py:
743         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
744         * Scripts/webkitpy/tool/steps/steps_unittest.py:
745
746 2011-06-20  Chang Shu  <cshu@webkit.org>
747
748         Reviewed by Adam Barth.
749
750         fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code tests fail when showModalDialog isn't supported
751         https://bugs.webkit.org/show_bug.cgi?id=53676
752
753         * WebKitTestRunner/TestController.cpp:
754         (WTR::TestController::initialize):
755
756 2011-06-20  Eric Seidel  <eric@webkit.org>
757
758         Reviewed by Adam Barth.
759
760         buildbots should run run-bindings-tests
761         https://bugs.webkit.org/show_bug.cgi?id=63001
762
763         run-bindings-tests takes 2.4 seconds on my machine, so
764         I expect this will not be noticeable on the bots.
765
766         I also removed tiger-specific checks since Tiger is no
767         longer a supported platform for webkit.
768
769         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
770
771 2011-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
772
773         Unreviewed. Fix WebKit2 GTK build after r89249.
774
775         * GtkLauncher/main.c:
776         (main):
777
778 2011-06-20  Pavel Feldman  <pfeldman@chromium.org>
779
780         Reviewed by Yury Semikhatsky.
781
782         Web Inspector: remove LayoutTestController::setTimelineProfilingEnabled.
783         https://bugs.webkit.org/show_bug.cgi?id=62994
784
785         * DumpRenderTree/LayoutTestController.cpp:
786         (closeWebInspectorCallback):
787         (LayoutTestController::staticFunctions):
788         * DumpRenderTree/LayoutTestController.h:
789         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
790         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
791         * DumpRenderTree/chromium/LayoutTestController.cpp:
792         (LayoutTestController::LayoutTestController):
793         * DumpRenderTree/chromium/LayoutTestController.h:
794         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
795         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
796         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
797         * DumpRenderTree/qt/LayoutTestControllerQt.h:
798         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
799         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
800         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
801         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
802         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
803
804 2011-06-20  Lukasz Slachciak  <l.slachciak@samsung.com>
805
806         Reviewed by Martin Robinson.
807
808         [GTK] General mechanism for adjusting WebKitWebSettings in GtkLauncher.
809         https://bugs.webkit.org/show_bug.cgi?id=55308
810
811         * GtkLauncher/main.c: Added general mechanism for adjusting WebKitWebSettings.
812         (parseOptionEntryCallback): Callback for parsing option entry.
813         (getOptionEntriesFromWebKitWebSettings): Basing on the WebKitWebSettings properties prepare
814         list of option entries.
815         (transformStringToBoolean): Transform function for boolean convertion used by parseOptionEntryCallback.
816         (transformStringToInt): Transform function for int convertion used by parseOptionEntryCallback.
817         (transformStringToFloat): Transform function for float convertion used by parseOptionEntryCallback.
818         (parseAdditionalOptions): Help function parsing additional commandline options.
819         (main): Added call to parseAdditionalOptions.
820
821 2011-06-20  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
822
823         Reviewed by Andreas Kling.
824
825         [Qt] [WK2] Compile error in ActivateFontsQt.cpp on Mac
826         https://bugs.webkit.org/show_bug.cgi?id=62869
827
828         Add QFont include to fix "incomlete type QFont" error.
829
830         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
831
832 2011-06-19  Adam Bergkvist  <adam.bergkvist@ericsson.com>
833
834         Reviewed by Martin Robinson.
835
836         [GTK] Enable Media Stream feature and make it default on
837         https://bugs.webkit.org/show_bug.cgi?id=60394
838
839         * Scripts/build-webkit:
840
841 2011-06-19  Sheriff Bot  <webkit.review.bot@gmail.com>
842
843         Unreviewed, rolling out r89198.
844         http://trac.webkit.org/changeset/89198
845         https://bugs.webkit.org/show_bug.cgi?id=62953
846
847         Chromium breakage on "Linux Tests" (Requested by senorblanco
848         on #webkit).
849
850         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
851         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
852         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
853
854 2011-06-18  Daniel Bates  <dbates@webkit.org>
855
856         Reviewed by Eric Seidel.
857
858         Git.push_local_commits_to_server() should use passed username and
859         password when we don't have cached credentials
860         https://bugs.webkit.org/show_bug.cgi?id=62941
861
862         Fixes a issue where Git.push_local_commits_to_server() would always look
863         for cached credentials regardless of whether a username and password
864         were passed as arguments. Instead, if given both a username and password
865         then we shouldn't look for cached credentials (since we were explicitly given
866         credentials).
867
868         * Scripts/webkitpy/common/checkout/scm/git.py:
869         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py: Added unit tests.
870
871 2011-06-18  Daniel Bates  <dbates@rim.com>
872
873         Rubber-stamped by Eric Seidel.
874
875         Remove run-javascriptcore-tests --skip-build option; Instead add --build/no-build options
876         https://bugs.webkit.org/show_bug.cgi?id=62767
877
878         Part 3 of 3
879
880         Remove the command-line option --skip-build now that the master BuildBot has been restarted
881         following <http://trac.webkit.org/changeset/89138>.
882
883         Instead, specify --no-build to get analogous functionality.
884
885         * Scripts/run-javascriptcore-tests:
886
887 2011-06-18  Dirk Pranke  <dpranke@chromium.org>
888
889         Reviewed by Tony Chang.
890
891         new-run-webkit-tests: fix test sorting
892         https://bugs.webkit.org/show_bug.cgi?id=58691
893
894         This changes the sorting to use a "natural" sort order such that
895         foo2.html sorts before foo13.html, and sorts the tests so
896         that all the tests in a directory are run before any test in a
897         subdirectory.
898
899         This change also adds a split() method to the filesystem since
900         that is needed to cluster files into a directory otherwise.
901
902         * Scripts/webkitpy/common/system/filesystem.py:
903         * Scripts/webkitpy/common/system/filesystem_mock.py:
904         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
905         * Scripts/webkitpy/layout_tests/layout_package/manager_unittest.py:
906
907 2011-06-18  Evan Martin  <evan@chromium.org>
908
909         Reviewed by Darin Adler.
910
911         Compiler warning in double->int conversion in TestNetscapePlugIn
912         https://bugs.webkit.org/show_bug.cgi?id=51554
913
914         This code is providing a JS API for removing a property by numeric ID.
915         We get it from JS as a double, and must convert it to an int before using it.
916
917         Test: LayoutTests/plugins/npruntime/remove-property.html
918
919         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeRemoveProperty.cpp:
920         (NPRuntimeRemoveProperty::TestObject::invoke):
921
922 2011-06-18  Patrick Gansterer  <paroga@webkit.org>
923
924         Reviewed by Eric Seidel.
925
926         Don't exit webkit-patch when running on Win32 python
927         https://bugs.webkit.org/show_bug.cgi?id=55811
928
929         Most of the basic actions work in the meantime,
930         so let people play with in on Win32 now.
931
932         * Scripts/webkit-patch:
933
934 2011-06-18  Alice Boxhall  <aboxhall@chromium.org>
935
936         Reviewed by Ojan Vafai.
937
938         Convert json_results_generator.py to output version 4 JSON.
939         https://bugs.webkit.org/show_bug.cgi?id=60869
940
941         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
942         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
943         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
944
945 2011-06-18  Berend-Jan Wever  <skylined@chromium.org>
946
947         Reviewed by Eric Seidel.
948
949         Some names with spaces are incorrectly reported as not containing spaces
950         while running prepare-ChangeLog
951         https://bugs.webkit.org/show_bug.cgi?id=55572
952
953         * Scripts/VCSUtils.pm: Updated CHANGE_LOG_NAME check for spaces to allow
954           non-alphanumeric characters in names.
955
956 2011-06-18  Michael Saboff  <msaboff@apple.com>
957
958         Reviewed by Eric Seidel.
959
960         Enhancement: New Script to Format malloc_history output as tree
961         https://bugs.webkit.org/show_bug.cgi?id=56378
962
963         New script to process malloc_history output to tree format.
964
965         * Scripts/malloc-tree: Added.
966
967 2011-06-17  Dmitry Lomov  <dslomov@google.com>
968
969         Reviewed by Daniel Bates.
970
971         https://bugs.webkit.org/show_bug.cgi?id=62918 
972         Pass configuration to UnitTests step in master.cfg
973
974         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
975
976 2011-06-17  Leandro Pereira  <leandro@profusion.mobi>
977
978         Reviewed by Eric Seidel.
979
980         [EFL] Add Evas-based ImageDiff implementation.
981         https://bugs.webkit.org/show_bug.cgi?id=61942
982
983         Build system changes will be performed as soon as the complete
984         DumpRenderTree implementation is upstreamed.
985
986         * DumpRenderTree/efl/ImageDiff.cpp: Added.
987         (pixelFromImageData):
988         (differenceImageFromDifferenceBuffer):
989         (computeDistanceBetweenPixelComponents):
990         (calculatePixelDifference):
991         (calculateDifference):
992         (getTemporaryFile):
993         (printImage):
994         (printImageDifferences):
995         (resizeEcoreEvasIfNeeded):
996         (readImageFromStdin):
997         (parseCommandLineOptions):
998         (shutdownEfl):
999         (abortWithErrorMessage):
1000         (initEfl):
1001         (main):
1002
1003 2011-06-17  Tony Chang  <tony@chromium.org>
1004
1005         Reviewed by Dirk Pranke.
1006
1007         [chromium] force rebaseline-chromium-webkit-tests to use the chromium port
1008         https://bugs.webkit.org/show_bug.cgi?id=62907
1009
1010         This fixes a bug where the ImageDiff on the user's machine doesn't
1011         match the logic used on the Chromium buildbots.  This has the downside
1012         of requiring that the Chromium ImageDiff is built, but it turns out
1013         that even with --tolerance 0, the CG ImageDiff will allow small pixel
1014         differences through.
1015
1016         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1017
1018 2011-06-17  Brent Fulgham  <bfulgham@webkit.org>
1019
1020         [WinCairo] Unreviewed build correction.
1021
1022         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops:
1023         Update WinCairo property sheet to link against the Cairo DLL,
1024         now that we are using a more recent Cairo build. 
1025
1026 2011-06-17  Brent Fulgham  <bfulgham@webkit.org>
1027
1028         Reviewed by Brian Weinstein.
1029
1030         Create a simple example of using the COM-based C++ listeners.
1031         A new onclick event is attached (via C++) to the WebKit logo
1032         in the default test pattern displayed on startup.  Clicking on
1033         the logo causes a message box to be displayed.
1034         https://bugs.webkit.org/show_bug.cgi?id=61885
1035
1036         * WinLauncher/DOMDefaultImpl.h: Added.  Stub implementation of
1037           the WebScriptObject and DOMEventListener.
1038         * WinLauncher/WinLauncher.cpp:
1039         (SimpleEventListener::SimpleEventListener): Example implementation
1040           of a simple DOM event listener.
1041         (SimpleEventListener::handleEvent): 
1042         (WinLauncherWebHost::didFinishLoadForFrame): Added implementation
1043          to bind a C++ method to the 'onclick' event for the WebKit logo.
1044         (_tWinMain):
1045         * WinLauncher/WinLauncher.h:
1046         * WinLauncher/WinLauncher.vcproj: Add new DOMDefaultImpl.h file.
1047
1048 2011-06-17  Chang Shu  <cshu@webkit.org>
1049
1050         Reviewed by Andreas Kling.
1051
1052         [Qt] [WK2] Support undo/redo in MiniBrowser
1053         https://bugs.webkit.org/show_bug.cgi?id=62809
1054
1055         * MiniBrowser/qt/BrowserWindow.cpp:
1056         (BrowserWindow::BrowserWindow):
1057
1058 2011-06-17  Daniel Bates  <dbates@rim.com>
1059
1060         Rubber-stamped by Eric Seidel.
1061
1062         Remove run-javascriptcore-tests --skip-build option; Instead add --build/no-build options
1063         https://bugs.webkit.org/show_bug.cgi?id=62767
1064
1065         Part 2 of 3
1066
1067         Update the BuildBot master.cfg to use the new --no-build run-javascriptcore-tests
1068         command line option instead of --skip-build.
1069
1070         We'll remove --skip-build from run-javascriptcore-test in a follow up patch once the
1071         master buildbot picks up the change.
1072
1073         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1074
1075 2011-06-17  Daniel Bates  <dbates@rim.com>
1076
1077         Rubber-stamped by Eric Seidel.
1078
1079         Remove run-javascriptcore-tests --skip-build option; Instead add --build/no-build options
1080         https://bugs.webkit.org/show_bug.cgi?id=62767
1081
1082         Part 1 of 3
1083
1084         Towards renaming the option --skip-build to --no-build. Add --build/--no-build options to
1085         run-javascriptcore-tests. Also, add a remark about these options to the usage message
1086         printed by run-javascriptcore-tests.
1087
1088         We'll remove --skip-build in a follow up patch once the master buildbot picks up the changes.
1089
1090         * Scripts/run-javascriptcore-tests: Additionally, remove unnecessary initialization
1091           of $showHelp.
1092
1093 2011-06-17  Joone Hur  <joone.hur@collabora.co.uk>
1094
1095         Reviewed by Martin Robinson.
1096
1097         [GTK] Replace GdkRectangle by cairo_rectangle_int_t
1098         https://bugs.webkit.org/show_bug.cgi?id=60687
1099
1100         Replace GdkRectangle by cairo_rectangle_int_t.
1101
1102         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp: Replace GdkRectangle by cairo_rectangle_int_t.
1103         (createBitmapContextFromWebView):
1104         * DumpRenderTree/gtk/TextInputController.cpp: Ditto.
1105         (firstRectForCharacterRangeCallback):
1106
1107 2011-06-16  Dmitry Lomov  <dslomov@google.com>
1108
1109         Reviewed by David Levin.
1110
1111         https://bugs.webkit.org/show_bug.cgi?id=62603
1112         Run run-api-tests on bots in debug mode.
1113         Release mode is disabled due to https://bugs.webkit.org/show_bug.cgi?id=61812.
1114
1115         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1116
1117 2011-06-16  Leandro Pereira  <leandro@profusion.mobi>
1118
1119         Reviewed by Eric Seidel.
1120
1121         [EFL] DumpRenderTree: Add GCController, PixelDumpSupport and
1122         WorkQueueItem.
1123         They will be plugged into the build system once the EFL's DRT is
1124         fully upstreamed.
1125         https://bugs.webkit.org/show_bug.cgi?id=61958
1126
1127         * DumpRenderTree/efl: Added.
1128         * DumpRenderTree/efl/GCControllerEfl.cpp: Added.
1129         (GCController::collect):
1130         (GCController::collectOnAlternateThread):
1131         (GCController::getJSObjectCount):
1132         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp: Added.
1133         (createBitmapContextFromWebView):
1134         * DumpRenderTree/efl/WorkQueueItemEfl.cpp: Added.
1135         (LoadItem::invoke):
1136         (LoadHTMLStringItem::invoke):
1137         (ReloadItem::invoke):
1138         (ScriptItem::invoke):
1139         (BackForwardItem::invoke):
1140         * DumpRenderTree/efl/WorkQueueItemEfl.h: Added.
1141         (WorkQueueItem::~WorkQueueItem):
1142         (LoadItem::LoadItem):
1143         (LoadHTMLStringItem::LoadHTMLStringItem):
1144         (ScriptItem::ScriptItem):
1145         (LoadingScriptItem::LoadingScriptItem):
1146         (LoadingScriptItem::invoke):
1147         (NonLoadingScriptItem::NonLoadingScriptItem):
1148         (NonLoadingScriptItem::invoke):
1149         (BackForwardItem::BackForwardItem):
1150         (BackItem::BackItem):
1151         (ForwardItem::ForwardItem):
1152
1153 2011-06-16  Kevin Ollivier  <kevino@theolliviers.com>
1154
1155         [wx] Unreviewed build fix, make sure the waf build checks the webKitBranchBuild
1156         preference like the perl scripts do.
1157
1158         * waf/build/build_utils.py:
1159         * waf/build/settings.py:
1160
1161 2011-06-16  Tommy Widenflycht  <tommyw@google.com>
1162
1163         Reviewed by Tony Gentilcore.
1164
1165         MediaStream API: Runtime enabled features
1166         https://bugs.webkit.org/show_bug.cgi?id=62798
1167
1168         Add the WebRuntimeFeatures API for Media Streams and enable the feature by default in DumpRenderTree.
1169
1170         * DumpRenderTree/chromium/TestShell.cpp:
1171         (TestShell::TestShell):
1172
1173 2011-06-16  Torsten Kurbad  <gentoo@tk-webart.de>
1174
1175         Reviewed by Eric Seidel.
1176
1177         Add support for sys.platform == 'linux3' by relaxing
1178         conditional statements and/or extending lookup dicts.
1179         This way, Linux kernels >=3.0-rc1 get supported in the
1180         build process.
1181         https://bugs.webkit.org/show_bug.cgi?id=62730
1182
1183         * Scripts/webkitpy/common/system/executive.py:
1184         * Scripts/webkitpy/common/system/file_lock.py:
1185         * Scripts/webkitpy/common/system/path_unittest.py:
1186         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
1187         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1188         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1189         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
1190         * Scripts/webkitpy/layout_tests/port/factory.py:
1191         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1192         * Scripts/webkitpy/layout_tests/port/qt.py:
1193         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1194
1195 2011-06-16  Sheriff Bot  <webkit.review.bot@gmail.com>
1196
1197         Unreviewed, rolling out r88796.
1198         http://trac.webkit.org/changeset/88796
1199         https://bugs.webkit.org/show_bug.cgi?id=62790
1200
1201         It made fast/dom/nodesFromRect-basic.html time out on Qt,
1202         64-bit, debug mode (Requested by Ossy on #webkit).
1203
1204         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1205         (LayoutTestController::nodesFromRect):
1206         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1207         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
1208         (PlainTextController::plainText):
1209         * DumpRenderTree/qt/PlainTextControllerQt.h:
1210
1211 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
1212
1213         Unreviewed, build fix.
1214
1215         Revert the patches in r88995 and r88999; the http servers don't
1216         seem to be shutting down reliably.
1217
1218         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
1219         * Scripts/webkitpy/layout_tests/port/base.py:
1220         * Scripts/webkitpy/layout_tests/port/http_server.py:
1221         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
1222         * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Removed.
1223         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1224         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1225
1226 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
1227
1228         Unreviewed, build fix.
1229
1230         Add some debugging messages to triage problems introduced in
1231         r88995.
1232
1233         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
1234
1235 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
1236
1237         Reviewed by Tony Chang.
1238
1239         nrwt: should clean up stale server processes from a previous run
1240         https://bugs.webkit.org/show_bug.cgi?id=62615
1241
1242         This change fixes cases where NRWT might start a server and then
1243         exit, leaving the server still running. Now NRWT should detect
1244         this case and clean up on the next run, without shutting down
1245         any processes it didn't start.
1246
1247         This change also fixes a bug in executive.kill_process on UNIX
1248         where zombies weren't being handled properly.
1249
1250         * Scripts/webkitpy/common/system/executive.py:
1251         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
1252         * Scripts/webkitpy/layout_tests/port/base.py:
1253         * Scripts/webkitpy/layout_tests/port/http_server.py:
1254         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
1255         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1256         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1257
1258 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
1259
1260         Reviewed by Tony Chang.
1261
1262         nrwt: fix http, websocket server startup, shutdown
1263         https://bugs.webkit.org/show_bug.cgi?id=62180
1264
1265         This change refactors all of the server-related code to
1266         have consistent semantics. It pushes the start()/stop()
1267         logic into the base class and adds four much smaller routines
1268         for specialization:
1269         _prepare_config() - for optionally writing config files etc.
1270             to disk prior to starting the server
1271         _remove_stale_log_files()
1272         _spawn_process() - the actual launch of the subprocess
1273         _cleanup_after_stop() - and custom cleanup code
1274
1275         Prior to this change the three server implementations were
1276         fairly inconsistent, leading to lots of weirdness on the bots
1277         with servers being left around, etc.
1278
1279         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
1280         * Scripts/webkitpy/layout_tests/port/http_server.py:
1281         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
1282         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1283
1284 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
1285
1286         Reviewed by Tony Chang.
1287
1288         webkitpy: clean up code prior to functional changes for server startup/shutdown
1289         https://bugs.webkit.org/show_bug.cgi?id=62256
1290
1291         This patch does a bunch of minor cleanup of the code, but there
1292         should be no functional changes except that all of the modules
1293         will now use the same exception type. Other changes include
1294         removing unused code paths and functions, pushing 'name' and
1295         'pid_file' into the base class of the server objects, and using
1296         the Filesystem object instead of the codecs, tempfile, and
1297         shutils modules.
1298
1299         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
1300         * Scripts/webkitpy/layout_tests/port/http_server.py:
1301         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
1302         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1303
1304 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
1305
1306         Reviewed by Tony Chang.
1307
1308         webkitpy: add integration tests for new-run-webkit-httpd, stop calling shut_down_http_server
1309         https://bugs.webkit.org/show_bug.cgi?id=62251
1310
1311         shut_down_http_server() was a total hack that was only used by
1312         new-run-webkit-httpd, so I've moved the code there and switched
1313         to using executive.kill_process() for the common case. The
1314         method itself will be removed in the patch on bug 59993.
1315
1316         * Scripts/new-run-webkit-httpd:
1317         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
1318         * Scripts/webkitpy/layout_tests/port/http_server.py:
1319         * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Added.
1320         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1321
1322 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
1323
1324         Unreviewed, build fix.
1325
1326         Fix test-webkitpy failure introduced in r88986.
1327
1328         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1329
1330 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
1331
1332         Reviewed by Eric Seidel.
1333
1334         NRWT: doesn't support webarchives, has stale skipping logic.
1335         https://bugs.webkit.org/show_bug.cgi?id=58293
1336
1337         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1338         * Scripts/webkitpy/layout_tests/port/base.py:
1339         * Scripts/webkitpy/layout_tests/port/webkit.py:
1340
1341 2011-06-15  Jeremy Orlow  <jorlow@webkit.org>
1342
1343         Change my email to @webkit.org
1344
1345         * Scripts/webkitpy/common/config/committers.py:
1346
1347 2011-06-15  Nikolas Zimmermann  <nzimmermann@rim.com>
1348
1349         Reviewed by David Hyatt.
1350
1351         CSS 2.1: Support replaced elements with relative intrinsic sizes
1352         https://bugs.webkit.org/show_bug.cgi?id=15849
1353
1354         CSS 2.1 failure: html4/replaced-intrinsic-ratio-001
1355         https://bugs.webkit.org/show_bug.cgi?id=53099
1356
1357         Recognize *.htm tests in the old & new DRT implementation, needed for the vanilla css2.1 html4 tests.
1358
1359         * Scripts/old-run-webkit-tests:
1360         * Scripts/webkitpy/layout_tests/port/test_files.py:
1361
1362 2011-06-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1363
1364         Reviewed by Martin Robinson.
1365
1366         [GTK] Add a statusbar to MiniBrowser
1367         https://bugs.webkit.org/show_bug.cgi?id=62634
1368
1369         It shows the url of the current hovered link.
1370
1371         * MiniBrowser/gtk/BrowserWindow.c:
1372         (browserWindowConstructed): Create the GtkSatusbar.
1373         (mouseDidMoveOverElement): Update statusbar text.
1374         (browserWindowUIClientInit): Add implementation for
1375         mouseDidMoveOverElement().
1376         * MiniBrowser/gtk/GNUmakefile.am: Add new files to compilation.
1377         * MiniBrowser/gtk/WebBundle/WebBundleMain.c: Added.
1378         (mouseDidMoveOverElement): Pass the url of the current hovered
1379         link to the UI process.
1380         (didCreatePage): Set the UI client adding an implementation for
1381         mouseDidMoveOverElement().
1382         (WKBundleInitialize):
1383         * MiniBrowser/gtk/main.c:
1384         (createWKContextWithInjectedBundle): Create a global context with
1385         the injected bundle.
1386         (loadURI): Use the global context.
1387         (main):
1388
1389 2011-06-14  Lucas Forschler  <lforschler@apple.com>
1390
1391         Reviewed by Stephanie Lewis.
1392
1393         https://bugs.webkit.org/show_bug.cgi?id=62495
1394         Bug 62495 - combine windows and mac kill-old-processes script
1395         Add a platform agnostic script.  Remove the recently added mac flavor.
1396         Note: Leaving the windows one alone, since it is currently used by the WebKit bots.
1397         
1398         * BuildSlaveSupport/kill-old-processes: Added.
1399         * BuildSlaveSupport/mac: Removed.
1400         * BuildSlaveSupport/mac/kill-old-processes: Removed.
1401
1402 2011-06-14  Dirk Pranke  <dpranke@chromium.org>
1403
1404         Reviewed by Tony Chang.
1405
1406         nrwt: handle worker exceptions cleanly
1407         https://bugs.webkit.org/show_bug.cgi?id=62614
1408
1409         This change modifiers new-run-webkit-tests to handle exceptions
1410         raised by worker threads better, by:
1411         - capturing the worker's stack and logging it in the manager
1412         - propagating the worker's exception in the caller correctly
1413         - attempting to cancel the workers and clean up even when
1414           we get an unexpected exception
1415
1416         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
1417         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
1418         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1419         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1420
1421 2011-06-14  Qi Zhang  <qi.2.zhang@nokia.com>
1422
1423         Reviewed by Laszlo Gombos.
1424
1425         [Qt] fast/dom/HTMLScriptElement/nested-execution.html failed
1426         https://bugs.webkit.org/show_bug.cgi?id=62227
1427
1428         QtWebkit does not yet support different CacheModels. This change will 
1429         expose setCacheModel() with a stub implementation, which is enough to pass the LayoutTest.
1430
1431         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1432         (LayoutTestController::setCacheModel):
1433         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1434
1435 2011-06-14  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
1436
1437         Reviewed by Andreas Kling.
1438
1439         [Qt] tst_QWebFrame::overloadedSlots() fails
1440         https://bugs.webkit.org/show_bug.cgi?id=37319
1441
1442         Since we don't implictly convert 'document' object to QWebElement
1443         in metacalls anymore, change the controller to expect QVariantMap instead.
1444
1445         The method plainText() was updated to use QVariantMap as well to let the bridge
1446         do the conversion directly for us.
1447
1448         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1449         (LayoutTestController::nodesFromRect):
1450         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1451         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
1452         (PlainTextController::plainText):
1453         * DumpRenderTree/qt/PlainTextControllerQt.h:
1454
1455 2011-06-14  Andras Becsi  <abecsi@webkit.org>
1456
1457         Reviewed by Csaba Osztrogonác.
1458
1459         Remove dead code in DumpRenderTree/TestNetscapePlugIn/main.cpp
1460         https://bugs.webkit.org/show_bug.cgi?id=62630
1461
1462         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1463         (NPP_New): remove dead variable 'forceCarbon'
1464
1465 2011-06-13  Hayato Ito  <hayato@chromium.org>
1466
1467         Reviewed by Ojan Vafai.
1468
1469         [NRWT] Fix a WebKitDriver so that it returns an actual hash value if DRT returns that.
1470         https://bugs.webkit.org/show_bug.cgi?id=59188
1471
1472         A current WebKitDriver doesn't try to return an actual hash value if DRT does not return an image.
1473         WebKitDriver should always return an actual hash value if DRT returns that.
1474
1475         No tests since I'll add sample reftests to make sure mismatch reftests work later,
1476         which should be in a separate patch.
1477
1478         * Scripts/webkitpy/layout_tests/port/webkit.py:
1479
1480 2011-06-13  Kent Tamura  <tkent@chromium.org>
1481
1482         [Chromium-win] Fix two wrong assertions exposed by r88757.
1483
1484         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
1485         (WebThemeEngineDRTWin::paintTrackbar):
1486
1487 2011-06-13  Alexey Proskuryakov  <ap@apple.com>
1488
1489         Added an updated e-mail address for Matt Lilek, to make Bugzilla autocomplete
1490         and commit queue happy.
1491
1492         * Scripts/webkitpy/common/config/committers.py:
1493
1494 2011-06-13  Chris Rogers  <crogers@google.com>
1495
1496         Unreviewed build fix.
1497
1498         Build fix to chromium DRT until we can rebaseline some tests
1499         https://bugs.webkit.org/show_bug.cgi?id=62608
1500
1501         * DumpRenderTree/chromium/TestShell.cpp:
1502         (TestShell::TestShell):
1503
1504 2011-06-13  Chris Rogers  <crogers@google.com>
1505
1506         Reviewed by Dirk Pranke.
1507
1508         Add Web Audio support to chromium DRT
1509         https://bugs.webkit.org/show_bug.cgi?id=62306
1510
1511         * DumpRenderTree/chromium/LayoutTestController.cpp:
1512         (LayoutTestController::LayoutTestController):
1513         (LayoutTestController::reset):
1514         (LayoutTestController::setEncodedAudioData):
1515         * DumpRenderTree/chromium/LayoutTestController.h:
1516         (LayoutTestController::encodedAudioData):
1517         (LayoutTestController::shouldDumpAsAudio):
1518         (LayoutTestController::setShouldDumpAsAudio):
1519         * DumpRenderTree/chromium/TestEventPrinter.cpp:
1520         (DRTPrinter::handleAudioHeader):
1521         (TestShellPrinter::handleAudioHeader):
1522         * DumpRenderTree/chromium/TestEventPrinter.h:
1523         * DumpRenderTree/chromium/TestShell.cpp:
1524         (TestShell::TestShell):
1525         (TestShell::dump):
1526
1527 2011-06-13  Jaehun Lim  <ljaehun.lim@samsung.com>
1528
1529         Reviewed by Eric Seidel.
1530
1531         [EFL] Add load error handler to EWebLauncher
1532         https://bugs.webkit.org/show_bug.cgi?id=62347
1533
1534         Add a handler function of "load,error" to EWebLauncher.
1535         EWebLauncher now displays a simple error page on load errors.
1536
1537         * EWebLauncher/main.c:
1538         (on_load_error):
1539         (browserCreate):
1540
1541 2011-06-13  Martin Robinson  <mrobinson@igalia.com>
1542
1543         Reviewed by Eric Seidel.
1544
1545         [GTK] [Qt] Eliminate duplicate TestNetscapePlugin implementation
1546         https://bugs.webkit.org/show_bug.cgi?id=62385
1547
1548         Remove duplicate TestNetscapePlugIn implementation. Having two copies
1549         of this code makes keeping it in sync much more difficult. The files are
1550         almost identical and this change ports the X11 changes to main.cpp.
1551
1552         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1553         (NPP_New): Do not set the plugin as windowless always. Doing this breaks
1554         some results on Qt and this seems to be unnecessary for the moment.
1555         (keyEventToChar): Added this helper which converts a X11 keycode into a char.
1556         (handleEventX11): Use the handler to properly convert the keycode. Do not print
1557         adjustCursorEvent output. The tests currently do not trigger this for Cocoa and thus
1558         it should not be in the results.
1559         (NPP_GetValue): Properly handle NPPVpluginNeedsXEmbed and make it clearer why the
1560         XP_UNIX block is first by guarding against using a null instance.
1561         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Update source list add
1562         the XP_UNIX define for Linux.
1563         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: Removed.
1564         * GNUmakefile.am: Update source list.
1565
1566 2011-06-13  Sheriff Bot  <webkit.review.bot@gmail.com>
1567
1568         Unreviewed, rolling out r88671.
1569         http://trac.webkit.org/changeset/88671
1570         https://bugs.webkit.org/show_bug.cgi?id=62591
1571
1572         "didn't work" (Requested by dpranke on #webkit).
1573
1574         * Scripts/new-run-webkit-httpd:
1575         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
1576         * Scripts/webkitpy/layout_tests/port/http_server.py:
1577         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
1578         * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Removed.
1579         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1580         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1581
1582 2011-06-13  Nate Chapin  <japhet@chromium.org>
1583
1584         Reviewed by Darin Fisher.
1585
1586         New test method on TestNetscapePlugin for https://bugs.webkit.org/show_bug.cgi?id=61482.
1587
1588         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1589
1590 2011-06-13  Dirk Pranke  <dpranke@chromium.org>
1591
1592         Reviewed by Tony Chang.
1593
1594         webkitpy: add integration tests for new-run-webkit-httpd, stop calling shut_down_http_server
1595         https://bugs.webkit.org/show_bug.cgi?id=62251
1596
1597         shut_down_http_server() was a total hack that was only used by
1598         new-run-webkit-httpd, so I've moved the code there and switched
1599         to using executive.kill_process() for the common case. The
1600         method itself will be removed in the patch on bug 59993.
1601
1602         * Scripts/new-run-webkit-httpd:
1603         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
1604         * Scripts/webkitpy/layout_tests/port/http_server.py:
1605         * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Added.
1606         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1607
1608 2011-06-13  Tony Chang  <tony@chromium.org>
1609
1610         Reviewed by Dimitri Glazkov.
1611
1612         rename ENABLE_NEW_FLEXBOX to ENABLE_CSS3_FLEXBOX
1613         https://bugs.webkit.org/show_bug.cgi?id=62578
1614
1615         * Scripts/build-webkit:
1616
1617 2011-06-13  Tony Chang  <tony@chromium.org>
1618
1619         Reviewed by Adam Barth.
1620
1621         rename ENABLE_FLEXBOX to ENABLE_NEW_FLEXBOX
1622         https://bugs.webkit.org/show_bug.cgi?id=62545
1623
1624         * Scripts/build-webkit:
1625
1626 2011-06-13  Carlos Garcia Campos  <cgarcia@igalia.com>
1627
1628         Reviewed by Martin Robinson.
1629
1630         [GTK] Export an API similar to WebKit1
1631         https://bugs.webkit.org/show_bug.cgi?id=57820
1632
1633         Build GtkLauncher2 for WebKit2. It's actually the same GtkLauncher
1634         code, but linking to libwebkit2gtk.
1635
1636         * GNUmakefile.am:
1637         * GtkLauncher/main.c:
1638         (createBrowser):
1639         (main):
1640
1641 2011-06-12  MORITA Hajime  <morrita@google.com>
1642
1643         Unreviewed, rolling out r88625.
1644         http://trac.webkit.org/changeset/88625
1645         https://bugs.webkit.org/show_bug.cgi?id=61073
1646
1647         Breaks SL Webkit2 Tests
1648
1649         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops:
1650         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
1651         * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops:
1652         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1653         (WTR::InjectedBundlePage::didClearWindowForFrame):
1654         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1655
1656 2011-06-12  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
1657
1658         Reviewed by Antonio Gomes.
1659
1660         [Qt] LayoutTestController needs setTextDirection implementation
1661         https://bugs.webkit.org/show_bug.cgi?id=62442
1662
1663         Implements LayoutController.setTextDirection.
1664
1665         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1666         (LayoutTestController::setTextDirection):
1667         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1668
1669 2011-06-12  Dominic Cooney  <dominicc@chromium.org>
1670
1671         Reviewed by Hajime Morita.
1672
1673         Add window.internals to WebKit2's WebKitTestRunner.
1674         https://bugs.webkit.org/show_bug.cgi?id=61073
1675
1676         Test: fast/harness/internals-object.html
1677
1678         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops:
1679         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
1680         * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops:
1681         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1682         (WTR::InjectedBundlePage::didClearWindowForFrame): initialize window.internals
1683         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1684
1685 2011-06-12  Sheriff Bot  <webkit.review.bot@gmail.com>
1686
1687         Unreviewed, rolling out r88616.
1688         http://trac.webkit.org/changeset/88616
1689         https://bugs.webkit.org/show_bug.cgi?id=62517
1690
1691         It broke editing/text-iterator/findString.html (Requested by
1692         tonikitoo on #webkit).
1693
1694         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1695         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1696
1697 2011-06-12  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
1698
1699         Reviewed by Antonio Gomes.
1700
1701         [Qt] LayoutTestController needs setTextDirection implementation
1702         https://bugs.webkit.org/show_bug.cgi?id=62442
1703
1704         Implements LayoutController.setTextDirection.
1705
1706         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1707         (LayoutTestController::setTextDirection):
1708         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1709
1710 2011-06-10  Ryosuke Niwa  <rniwa@webkit.org>
1711
1712         Reviewed by Ojan Vafai.
1713
1714         new-run-webkit-tests: 'images' links on results.html don't work
1715         https://bugs.webkit.org/show_bug.cgi?id=62194
1716
1717         Use relative path when generating images-diffs.html
1718
1719         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
1720         Added _output_testname.
1721
1722 2011-06-10  Lucas Forschler  <lforschler@apple.com>
1723
1724         Reviewed by Stephanie Lewis.
1725
1726         Script to kill old processes on Mac.
1727         This matches the windows version.
1728         https://bugs.webkit.org/show_bug.cgi?id=62479  
1729         
1730         * BuildSlaveSupport/mac: Added.
1731         * BuildSlaveSupport/mac/kill-old-processes: Added.
1732
1733 2011-06-10  Adam Barth  <abarth@webkit.org>
1734
1735         Reviewed by James Robinson.
1736
1737         When sheriffbot reports failures on IRC instead of saying "(and more..)" it should say the number of tests that are failing
1738         https://bugs.webkit.org/show_bug.cgi?id=62489
1739
1740         * Scripts/webkitpy/tool/bot/sheriff.py:
1741         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
1742
1743 2011-06-10  Tony Chang  <tony@chromium.org>
1744
1745         Reviewed by Ojan Vafai.
1746
1747         add a compile guard ENABLE(FLEXBOX)
1748         https://bugs.webkit.org/show_bug.cgi?id=62049
1749
1750         * Scripts/build-webkit:
1751
1752 2011-06-10  Mark Rowe  <mrowe@apple.com>
1753
1754         Reviewed by Dimitri Glazkov.
1755
1756         <rdar://problem/9562114> Fix DumpRenderTree build for production configuration.
1757
1758         Ensure that DumpRenderTree can find libWebCoreTestSupport.dylib and the associated
1759         header file.
1760
1761         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1762         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1763
1764 2011-06-09  Csaba Osztrogonác  <ossy@webkit.org>
1765
1766         Unreviewed rolling out r88471, because it broke plugin tests on Qt.
1767
1768         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1769         (handleEventX11):
1770         (NPP_GetValue):
1771         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1772         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: Added.
1773         (webkit_test_plugin_new_instance):
1774         (webkit_test_plugin_destroy_instance):
1775         (webkit_test_plugin_set_window):
1776         (executeScript):
1777         (webkit_test_plugin_new_stream):
1778         (webkit_test_plugin_destroy_stream):
1779         (webkit_test_plugin_stream_as_file):
1780         (webkit_test_plugin_write_ready):
1781         (webkit_test_plugin_write):
1782         (webkit_test_plugin_print):
1783         (keyEventToChar):
1784         (webkit_test_plugin_handle_event):
1785         (webkit_test_plugin_url_notify):
1786         (webkit_test_plugin_get_value):
1787         (webkit_test_plugin_set_value):
1788         (NP_GetMIMEDescription):
1789         (NP_Initialize):
1790         (NP_Shutdown):
1791         (NP_GetValue):
1792         * GNUmakefile.am:
1793
1794 2011-06-09  Martin Robinson  <mrobinson@igalia.com>
1795
1796         Reviewed by Eric Seidel.
1797
1798         [GTK] Implement the next bit of the TextInputController (hasMarkedText and markedRange)
1799         https://bugs.webkit.org/show_bug.cgi?id=55603
1800
1801         Add callbacks to support hasMarkedText and markedRange and also clean up existing 
1802         TextInputController support.
1803
1804         * DumpRenderTree/gtk/TextInputController.cpp:
1805         (setMarkedTextCallback): Accept parameters in terms of start and length, instead
1806         of start and end. This matches the other ports. Do not use GLib style early returns.
1807         (hasMarkedTextCallback): Added.
1808         (markedRangeCallback): Added.
1809         (insertTextCallback): Cleanup as described above.
1810         (unmarkTextCallback): Cleanup as described above.
1811         (firstRectForCharacterRangeCallback): Cleanup as described above.
1812         (selectedRangeCallback): Cleanup as described above.
1813
1814 2011-06-09  Dirk Pranke  <dpranke@chromium.org>
1815
1816         Reviewed by Tony Chang.
1817
1818         nrwt: support webaudio in chromium driver
1819         https://bugs.webkit.org/show_bug.cgi?id=62226
1820
1821         * Scripts/webkitpy/layout_tests/port/chromium.py:
1822
1823 2011-06-09  Dan Bernstein  <mitz@apple.com>
1824
1825         Reviewed by Anders Carlsson.
1826
1827         Added a test for Vector::reverse()
1828         https://bugs.webkit.org/show_bug.cgi?id=62393
1829
1830         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1831         * TestWebKitAPI/Tests/WTF/VectorReverse.cpp: Added.
1832         (TestWebKitAPI::TEST):
1833         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1834
1835 2011-06-09  Martin Robinson  <mrobinson@igalia.com>
1836
1837         Reviewed by Andreas Kling.
1838
1839         [GTK] [Qt] Eliminate duplicate TestNetscapePlugin implementation
1840         https://bugs.webkit.org/show_bug.cgi?id=62385
1841
1842         Remove duplicate TestNetscapePlugIn implementation. Having two copies
1843         of this code makes keeping it in sync much more difficult. The files are
1844         almost identical and this change ports the X11 changes to main.cpp.
1845
1846         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1847         (keyEventToChar): Added this helper which converts a X11 keycode into a char.
1848         (handleEventX11): Use the handler to properly convert the keycode. Do not print
1849         adjustCursorEvent output. The tests currently do not trigger this for Cocoa and thus
1850         it should not be in the results.
1851         (NPP_GetValue): Properly handle NPPVpluginNeedsXEmbed.
1852         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Update source list.
1853         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: Removed.
1854         * GNUmakefile.am: Update source list.
1855
1856 2011-06-09  Noel Gordon  <noel.gordon@gmail.com>
1857
1858         Reviewed by Tony Chang.
1859
1860         Test plugin should support event logging on the windows port.
1861         https://bugs.webkit.org/show_bug.cgi?id=61721
1862
1863         The WebKit win port interprets a 0 return from plugin NPP_HandleEvent()
1864         calls to mean the plugin handled the event.
1865
1866         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1867         (handleEventWin): Return 0 for each event on windows.
1868
1869 2011-06-09  Chang Shu  <cshu@webkit.org>
1870
1871         Reviewed by Andreas Kling.
1872
1873         [Qt] [WK2] Many editing tests failed on missing shouldBeginEditingInDOMRange:range printout
1874         https://bugs.webkit.org/show_bug.cgi?id=62381
1875
1876         Activate QGraphicsScene and setFocus on QGraphicsItem to make sure the view has the focus.
1877         QWKPagePrivate::isViewFocused() will check it later.
1878
1879         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1880         (WTR::PlatformWebView::PlatformWebView):
1881
1882 2011-06-09  Robert Hogan  <robert@webkit.org>
1883
1884         Reviewed by Andreas Kling.
1885
1886         Teach Qt about window.internals
1887         https://bugs.webkit.org/show_bug.cgi?id=61074
1888
1889         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1890         (WebCore::DumpRenderTree::initJSObjects):
1891
1892 2011-06-09  Eric Seidel  <eric@webkit.org>
1893
1894         Reviewed by Adam Barth.
1895
1896         Disable running layout tests on Mac EWS bots (and fix cr-linux bots to run them again)
1897         https://bugs.webkit.org/show_bug.cgi?id=62362
1898
1899         The mac bots are failing inspector tests.  We don't know why yet.
1900         So for now, turning run-webkit-tests off for the mac-ews.
1901
1902         Also noticed that due to the wrong variable name the cr-linux
1903         bots weren't running tests!
1904
1905         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1906
1907 2011-06-09  Zoltan Herczeg  <zherczeg@inf.u-szeged.hu>
1908
1909         Reviewed by Csaba Osztrogonac.
1910
1911         [Qt][WK2] Canvas tests make css2.1 ones failing
1912         https://bugs.webkit.org/show_bug.cgi?id=53427
1913
1914         Adding a workaround for this issue by mimicing the behaviour of DumpRenderTree.
1915         Since the Qt port should eventually go to QRawFont, this issue will be resolved
1916         in the future. Both clearMemoryCaches() and removeAllApplicationFonts() are
1917         needed for the workaround.
1918
1919         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
1920         (WTR::LayoutTestController::platformInitialize):
1921
1922 2011-06-09  Mario Sanchez Prada  <msanchez@igalia.com>
1923
1924         Reviewed by Chris Fleizach.
1925
1926         [GTK] Provide a way in DRT to check the platform name
1927         https://bugs.webkit.org/show_bug.cgi?id=56855
1928
1929         Patch for adding 'platformName' static property to DRT's
1930         LayoutController and provide platform specific implementations.
1931
1932         In principle, this feature will be only of interest for writing
1933         accessibility tests, so that's why it's only implemented in the
1934         Mac, Gtk and Win platforms.
1935
1936         * DumpRenderTree/LayoutTestController.h: New method platformName().
1937         * DumpRenderTree/LayoutTestController.cpp:
1938         (getPlatformNameCallback): New callback for 'platformName'.
1939         (LayoutTestController::staticValues): New static property.
1940
1941         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1942         (LayoutTestController::platformName): Implemented.
1943
1944         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1945         (LayoutTestController::platformName): Implemented.
1946
1947         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1948         (LayoutTestController::platformName): Implemented.
1949
1950 2011-06-08  Mike Lawther  <mikelawther@chromium.org>
1951
1952         Reviewed by James Robinson.
1953
1954         Add mikelawther to committers.py
1955         https://bugs.webkit.org/show_bug.cgi?id=62354
1956
1957         * Scripts/webkitpy/common/config/committers.py:
1958
1959 2011-06-08  Kent Tamura  <tkent@chromium.org>
1960
1961         [Chromium] Fix a typo.
1962
1963         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
1964         (WebThemeControlDRTWin::draw):
1965
1966 2011-06-08  Kent Tamura  <tkent@chromium.org>
1967
1968         Reviewed by Hajime Morita.
1969
1970         [Chromium] Support vertical sliders in Windows DRT
1971         https://bugs.webkit.org/show_bug.cgi?id=62352
1972
1973         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
1974         (WebThemeControlDRTWin::draw):
1975           Paint VerticalSliderThumbType and VerticalSliderTrackType.
1976         * DumpRenderTree/chromium/WebThemeControlDRTWin.h:
1977           Add VerticalSliderTrackType and VerticalSliderThumbType.
1978         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
1979         (WebThemeEngineDRTWin::paintTrackbar):
1980           Convert Windows identifiers to the internal identifiers for vertical sliders.
1981
1982 2011-06-08  Ojan Vafai  <ojan@chromium.org>
1983
1984         Reviewed by Tony Chang.
1985
1986         add a short-flag for --experimental-fully-parallel
1987         https://bugs.webkit.org/show_bug.cgi?id=62321
1988
1989         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1990
1991 2011-06-08  Ryosuke Niwa  <rniwa@webkit.org>
1992
1993         Reviewed by Tony Chang.
1994
1995         new-run-webkit-tests: don't turn the tree red when there are new passes
1996         https://bugs.webkit.org/show_bug.cgi?id=62311
1997
1998         Look for "new passes" instead of "passed unexpectedly" in evaluateCommand
1999         to match commandComplete.
2000
2001         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2002
2003 2011-06-08  Tom Hudson  <tomhudson@google.com>
2004
2005         Reviewed by Mihai Parparita.
2006
2007         Allow sorting in RebaselineServer based on 'metric' field in unexpected_results.json
2008         https://bugs.webkit.org/show_bug.cgi?id=60964
2009
2010         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
2011         Add 'Sort tests by metric' link.
2012         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
2013         (disableSorting): Activate 'Sort tests by metric' link.
2014         (enableSorting): Deactivate 'Sort tests by metric' link.
2015         (selectDirectory): Call enableSorting()/disableSorting() depending
2016         on currently selected failure type, and sort tests if requested.
2017         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
2018         New .disabled-control class for deactivated links.
2019
2020 2011-06-08  Tom Sepez  <tsepez@chromium.org>
2021
2022         Reviewed by Adam Barth.
2023
2024         Add web permissions callbacks for mixed content blocking.
2025         https://bugs.webkit.org/show_bug.cgi?id=61946
2026
2027         * DumpRenderTree/chromium/LayoutTestController.cpp:
2028         (LayoutTestController::setAllowDisplayOfInsecureContent):
2029         (LayoutTestController::setAllowRunningOfInsecureContent):
2030         (LayoutTestController::overridePreference):
2031         * DumpRenderTree/chromium/WebPermissions.cpp:
2032         (WebPermissions::allowDisplayingInsecureContent):
2033         (WebPermissions::allowRunningInsecureContent):
2034         (WebPermissions::setDisplayingInsecureContentAllowed):
2035         (WebPermissions::setRunningInsecureContentAllowed):
2036         (WebPermissions::reset):
2037         * DumpRenderTree/chromium/WebPermissions.h:
2038
2039 2011-06-08  Dirk Pranke  <dpranke@chromium.org>
2040
2041         Reviewed by Tony Chang.
2042
2043         webkitpy: fix typo causing us to skip the port unit tests in chromium_linux
2044         https://bugs.webkit.org/show_bug.cgi?id=62259
2045
2046         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
2047
2048 2011-06-08  Ryosuke Niwa  <rniwa@webkit.org>
2049
2050         Reviewed by Tony Chang.
2051
2052         new-run-webkit-tests: master.cfg errors when nrwt successfully runs test
2053         https://bugs.webkit.org/show_bug.cgi?id=62303
2054
2055         Access self.incorrectLayoutLines instead of incorrectLayoutLines in evaluateCommand.
2056
2057         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2058
2059 2011-06-08  Greg Simon  <gregsimon@chromium.org>
2060
2061         Reviewed by Dimitri Glazkov.
2062
2063         Control Indexeddb backends from LayoutTestController
2064         https://bugs.webkit.org/show_bug.cgi?id=61000
2065
2066         * DumpRenderTree/chromium/LayoutTestController.cpp:
2067         (LayoutTestController::LayoutTestController):
2068         (LayoutTestController::setOverrideIndexedDBBackingStore):
2069         (LayoutTestController::clearAllDatabases):
2070         * DumpRenderTree/chromium/LayoutTestController.h:
2071
2072 2011-06-08  Andreas Kling  <kling@webkit.org>
2073
2074         Add Pierre Rossi to contributors list for EZ-CC.
2075
2076         * Scripts/webkitpy/common/config/committers.py:
2077
2078 2011-06-08  Ilya Sherman  <isherman@chromium.org>
2079
2080         Reviewed by Andreas Kling.
2081
2082         Add Ilya Sherman to list of committers
2083         https://bugs.webkit.org/show_bug.cgi?id=62270
2084
2085         * Scripts/webkitpy/common/config/committers.py:
2086
2087 2011-06-07  Ryosuke Niwa  <rniwa@webkit.org>
2088
2089         Reviewed by Tony Chang.
2090
2091         new-run-webkit-tests: Bot master should print useful information on waterfall/console for nrwt
2092         https://bugs.webkit.org/show_bug.cgi?id=62178
2093
2094         Added commandComplete and evaluateCommand for NewRunWebKitTests class
2095         to parse new-run-webkit-tests' results.
2096
2097         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2098
2099 2011-06-07  Dirk Pranke  <dpranke@chromium.org>
2100
2101         Reviewed by Eric Seidel.
2102
2103         webkitpy: add a popen() call to executive
2104         https://bugs.webkit.org/show_bug.cgi?id=62179
2105
2106         This change adds a popen() wrapper call to the Executive object.
2107         This will allow other webkitpy scripts that currently call
2108         subprocess directly to use Executive, instead.
2109
2110         No additional tests are necessary (the existing tests cover the code).
2111
2112         * Scripts/webkitpy/common/system/executive.py:
2113
2114 2011-06-07  Sam Weinig  <sam@webkit.org>
2115
2116         Reviewed by Anders Carlsson.
2117
2118         Remove repeated IPC traffic from SetRenderTreeSize message
2119         https://bugs.webkit.org/show_bug.cgi?id=62244
2120
2121         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2122         (WTR::InjectedBundlePage::InjectedBundlePage):
2123         Add stub for didLayoutForFrame.
2124
2125 2011-06-07  Dirk Pranke  <dpranke@chromium.org>
2126
2127         Reviewed by Tony Chang.
2128
2129         rebaseline-chromium-webkit-tests: fix baselining order for linux, linux_x86_64
2130         https://bugs.webkit.org/show_bug.cgi?id=62241
2131
2132         * Scripts/webkitpy/layout_tests/port/chromium.py:
2133
2134 2011-06-07  Adam Barth  <abarth@webkit.org>
2135
2136         Rubber-stamped by Eric Seidel.
2137
2138         Enable tests on the mac-ews
2139
2140         When we bring the mac-ews back up, we're going to try running tests!
2141
2142         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2143
2144 2011-06-07  Dmitry Lomov  <dslomov@google.com>
2145
2146         Reviewed by David Levin.
2147
2148         https://bugs.webkit.org/show_bug.cgi?id=62215
2149         Allow comparisons with 0 in LIKELY and UNLIKELY macros.
2150
2151         * Scripts/webkitpy/style/checkers/cpp.py:
2152         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2153
2154 2011-06-07  Nico Weber  <thakis@chromium.org>
2155
2156         Reviewed by Dimitri Glazkov.
2157
2158         [chromium] -Wdelete-non-virtual-dtor pass for DumpRenderTree
2159         https://bugs.webkit.org/show_bug.cgi?id=62210
2160
2161         The change to TestEventPrinter fixes a latent bug, because
2162         objects are deleted through the TestEventPrinter type, but none
2163         of the subclasses have destructors or non-POD members.
2164
2165         The changes to NotificationPresenter and WebViewHost do _not_ to fix a
2166         real bug, they just make clang's -Wdelete-non-virtual-dtor happy. As
2167         discussed at http://codereview.chromium.org/7094005/, we prefer making
2168         leaf class destructors virtual over making the leaf classes final.
2169
2170         * DumpRenderTree/chromium/NotificationPresenter.cpp:
2171         (NotificationPresenter::~NotificationPresenter):
2172         * DumpRenderTree/chromium/NotificationPresenter.h:
2173         * DumpRenderTree/chromium/TestEventPrinter.cpp:
2174         (TestEventPrinter::~TestEventPrinter):
2175         * DumpRenderTree/chromium/TestEventPrinter.h:
2176         * DumpRenderTree/chromium/WebViewHost.h:
2177
2178 2011-06-06  Ryosuke Niwa  <rniwa@webkit.org>
2179
2180         Reviewed by Dirk Pranke.
2181
2182         [chromium] Chromium bots on build.webkit.org don't upload results.html
2183         https://bugs.webkit.org/show_bug.cgi?id=61961
2184
2185         Don't fix the path on chromium port erroneously.
2186
2187         * BuildSlaveSupport/test-result-archive:
2188
2189 2011-06-06  Martin Robinson  <mrobinson@igalia.com>
2190
2191         Fix the GTK+ build by ensuring that the autogenerated sources
2192         necessary for libWebCoreInternals are recorded in a predeclared
2193         variable before assigning to BUILT_SOURCES.
2194
2195         * GNUmakefile.am: Predeclare libwebcoreinternals_built_sources.
2196
2197 2011-06-06  Yong Li  <yoli@rim.com>
2198
2199         Reviewed by Eric Seidel.
2200
2201         https://bugs.webkit.org/show_bug.cgi?id=62097
2202         Fix the problem that integral bitfield check incorrectly barked at ?: expressions.
2203
2204         * Scripts/webkitpy/style/checkers/cpp.py:
2205         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2206
2207 2011-06-06  Xan Lopez  <xlopez@igalia.com>
2208
2209         Reviewed by Martin Robinson.
2210
2211         [GTK] Enable feature/symbol detection in NWRT/GTK
2212         https://bugs.webkit.org/show_bug.cgi?id=62136
2213
2214         Disable feature detection through DRT, since we don't support it,
2215         and set the libwebcore patch correctly so that symbol detection
2216         through 'nm' works.
2217
2218         * Scripts/webkitpy/layout_tests/port/gtk.py:
2219
2220 2011-06-06  Shishir Agrawal  <shishir@chromium.org>
2221
2222         Reviewed by Tony Gentilcore.
2223
2224         Add a "prerender" state for page visibility.
2225         https://bugs.webkit.org/show_bug.cgi?id=62062
2226
2227         * DumpRenderTree/chromium/LayoutTestController.cpp:
2228         (LayoutTestController::setPageVisibility):
2229
2230 2011-06-06  Csaba Osztrogonác  <ossy@webkit.org>
2231
2232         [Qt] Implement download feature for QtTestBrowser
2233         https://bugs.webkit.org/show_bug.cgi?id=61865
2234
2235         Buildfix for --minimal and CONFIG+=qt_minimal build after r88161.
2236
2237         * QtTestBrowser/launcherwindow.cpp:
2238         (LauncherWindow::LauncherWindow):
2239         * QtTestBrowser/launcherwindow.h:
2240
2241 2011-06-06  Barát Tibor  <Barat.Tibor@stud.u-szeged.hu>
2242
2243         Reviewed by Csaba Osztrogonác.
2244
2245         [Qt] Implement download feature for QtTestBrowser
2246         https://bugs.webkit.org/show_bug.cgi?id=61865
2247
2248         * QtTestBrowser/launcherwindow.cpp:
2249         (LauncherWindow::LauncherWindow):
2250         (LauncherWindow::downloadRequest):
2251         (LauncherWindow::fileDownloadFinished):
2252         * QtTestBrowser/launcherwindow.h:
2253
2254 2011-06-04  Dominic Cooney  <dominicc@chromium.org>
2255
2256         Reviewed by Dimitri Glazkov.
2257
2258         Make DumpRenderTree initialize window.internals.
2259         https://bugs.webkit.org/show_bug.cgi?id=61076
2260
2261         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: link WebCoreTestSupport.
2262         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2263         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
2264
2265 2011-06-06  Alexandru Chiculita  <achicu@adobe.com>
2266
2267         Reviewed by Kent Tamura.
2268
2269         Add ENABLE_CSS_EXCLUSIONS support for build-webkit script
2270         https://bugs.webkit.org/show_bug.cgi?id=61628
2271
2272         * Scripts/build-webkit:
2273
2274 2011-06-06  Mihnea Ovidenie  <mihnea@adobe.com>
2275
2276         Reviewed by Kent Tamura.
2277
2278         Add ENABLE(CSS_REGIONS) guard for CSS Regions support
2279         https://bugs.webkit.org/show_bug.cgi?id=61631
2280
2281         * Scripts/build-webkit:
2282
2283 2011-06-06  Carlos Garcia Campos  <cgarcia@igalia.com>
2284
2285         Unreviewed. Fix the GTK+ build.
2286
2287         * GNUmakefile.am: Use javascriptcore_cflags when building libWebCoreInternals.
2288
2289 2011-06-05  Alexey Proskuryakov  <ap@apple.com>
2290
2291         Add an e-mail address for Cameron McCormack that matches Bugzilla (so that auto-completion
2292         works properly).
2293
2294         * Scripts/webkitpy/common/config/committers.py:
2295
2296 2011-06-04  Kevin Ollivier  <kevino@theolliviers.com>
2297
2298         [wx] Unreviewed build fix. Update git branch build dir handling to match what other
2299         WebKit scripts expect, so other scripts work properly with wx.
2300
2301         * waf/build/build_utils.py:
2302         * waf/build/settings.py:
2303
2304 2011-06-04  Kevin Ollivier  <kevino@theolliviers.com>
2305
2306         [wx] Unreviewed build fix. Restore the PPC build and allow users to specify architectures
2307         to build on Mac.
2308
2309         * waf/build/settings.py:
2310         * wx/install-unix-extras:
2311
2312 2011-06-04  Kevin Ollivier  <kevino@theolliviers.com>
2313
2314         [wx] Unreviewed build fixes for recent trunk changes.
2315
2316         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2317         (LayoutTestController::setTextDirection):
2318         * waf/build/settings.py:
2319
2320 2011-06-04  Martin Robinson  <mrobinson@igalia.com>
2321
2322         Fix the GTK+ build.
2323
2324         * GNUmakefile.am: Add some missing newline escape.
2325
2326 2011-06-03  Martin Robinson  <mrobinson@igalia.com>
2327
2328         Try to fix the GTK+ bulid.
2329
2330         * GNUmakefile.am: Add JSDOMWrapper.cpp to the libWebCoreInternals
2331         source list.
2332
2333 2011-06-03  Dirk Pranke  <dpranke@chromium.org>
2334
2335         Reviewed by Adam Barth.
2336
2337         nrwt: should skip chromium test expectation overrides on upstream bots
2338         https://bugs.webkit.org/show_bug.cgi?id=61888
2339
2340         * Scripts/webkitpy/layout_tests/port/chromium.py:
2341         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2342
2343 2011-06-03  Dirk Pranke  <dpranke@chromium.org>
2344
2345         Reviewed by Ojan Vafai.
2346
2347         new-run-webkit-tests: minor logging, code cleanup
2348         https://bugs.webkit.org/show_bug.cgi?id=62055
2349
2350         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
2351         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
2352
2353 2011-06-03  Martin Robinson  <mrobinson@igalia.com>
2354
2355         Try to fix the build failure on the GTK+ 32-bit Release bot.
2356
2357         * GNUmakefile.am: Add JSInternal.{cpp,h} to the BUILT_SOURCES list.
2358
2359 2011-05-31  Martin Robinson  <mrobinson@igalia.com>
2360
2361         Reviewed by Ryosuke Niwa.
2362
2363         [GTK] Support smart replace for the pasteboard
2364         https://bugs.webkit.org/show_bug.cgi?id=61734
2365
2366         Call into the DumpRenderTreeSupportGtk hooks to toggle smart replace.
2367         This is required to produce consistent test results.
2368
2369         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2370         (resetDefaultsToConsistentValues): Set the smart replace setting to on by default.
2371         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2372         (LayoutTestController::setSmartInsertDeleteEnabled): Added an implementation of this
2373         methods which calls into DumpRenderTreeSupportGtk.
2374
2375 2011-06-03  Martin Robinson  <mrobinson@igalia.com>
2376
2377         Reviewed by Dimitri Glazkov.
2378
2379         Teach Gtk build about window.internals
2380         https://bugs.webkit.org/show_bug.cgi?id=61071
2381
2382         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2383         (webViewWindowObjectCleared): Inject the new internals object when the
2384         window object clears.
2385         * GNUmakefile.am: Add new source files and includes necessary for window.internals.
2386         Also do a little bit of cleanup.
2387
2388 2011-06-03  Dirk Pranke  <dpranke@chromium.org>
2389
2390         Reviewed by Tony Chang.
2391
2392         Worker may not be stopped after LT.
2393         https://bugs.webkit.org/show_bug.cgi?id=61847
2394
2395         Re-submit a variant of the first fix for this bug. It's possible
2396         that actually calling cleanup() in the worker threads was taking
2397         too long and we triggered the assertions in the manager thread.
2398
2399         I've bumped up the timeout in the manager and added better
2400         diagnostics. I also cleaned up the cleanup() code a bit because
2401         there was some unnecessary if-checks.
2402
2403         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
2404         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
2405
2406 2011-06-03  Dirk Pranke  <dpranke@chromium.org>
2407
2408         Reviewed by Tony Chang.
2409
2410         nrwt: fix duplicate logging regression
2411         https://bugs.webkit.org/show_bug.cgi?id=61981
2412
2413         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2414
2415 2011-06-03  Robert Kroeger  <rjkroege@chromium.org>
2416
2417         Reviewed by Adam Barth.
2418
2419         Modified addTouchPoint to correctly re-use touchPoint id values starting
2420         from the lowest not-un-use touchPoint id as is done by the embedder
2421         APIs. (Fixes BUGCR36415)
2422
2423         https://bugs.webkit.org/show_bug.cgi?id=62016
2424
2425         * DumpRenderTree/chromium/EventSender.cpp:
2426         (EventSender::addTouchPoint):
2427
2428 2011-06-03  Cary Clark  <caryclark@google.com>
2429
2430         Reviewed by Eric Seidel.
2431
2432         Draw DRT scroll bar thumb with CG when WebKit renders with Skia
2433         https://bugs.webkit.org/show_bug.cgi?id=61534
2434
2435         Skia on Mac uses Skia to render WebKit, and CG
2436         to render UI elements. The CG elements need a
2437         transcribed graphics context that preserves the
2438         canvas matrix, and the canvas clip.
2439
2440         The SkiaBitLocker utility class sets up a CGContext
2441         from the SkCanvas, locks the bitmap's bits, and
2442         releases the lock when the class goes out of scope.
2443
2444         The SkiaBitLocker implementation is described by
2445         this patch:
2446         http://codereview.chromium.org/7031006/
2447
2448         When WebKit uses Skia for rendering, the WebCanvas
2449         is an SkCanvas. Create an equivalent CGContext to
2450         draw the scrollbar thumb.
2451
2452         As the Chrome Mac port does not yet use Skia, this
2453         patch has no effect and requires no tests.
2454
2455         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
2456         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
2457
2458 2011-06-03  Andras Becsi  <abecsi@webkit.org>
2459
2460         Unreviewed build fix.
2461
2462         Fix typo.
2463
2464         * Scripts/old-run-webkit-tests:
2465
2466 2011-06-03  Andras Becsi  <abecsi@webkit.org>
2467
2468         Reviewed by Csaba Osztrogonác.
2469
2470         Print error message when there is no httpd present on the system
2471         https://bugs.webkit.org/show_bug.cgi?id=61939
2472
2473         * Scripts/old-run-webkit-tests: Propose to run with --no-httpd.
2474         * Scripts/webkitperl/httpd.pm:
2475
2476 2011-06-03  Mikhail Naganov  <mnaganov@chromium.org>
2477
2478         Reviewed by Yury Semikhatsky.
2479
2480         Web Inspector: [Chromium] cpu-profiler-profiling layout test is flaky on Linux Debug.
2481         https://bugs.webkit.org/show_bug.cgi?id=61533
2482
2483         Skip cpu-profiler-profiling in debug, implement a fast headless alternative.
2484
2485         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
2486         (DRTDevToolsAgent::setJavaScriptProfilingEnabled):
2487         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2488         * DumpRenderTree/chromium/LayoutTestController.cpp:
2489         (LayoutTestController::LayoutTestController):
2490         (LayoutTestController::setJavaScriptProfilingEnabled):
2491         * DumpRenderTree/chromium/LayoutTestController.h:
2492         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2493         (LayoutTestController::setJavaScriptProfilingEnabled):
2494         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2495         (WTR::LayoutTestController::setJavaScriptProfilingEnabled):
2496         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2497
2498 2011-06-02  Dirk Pranke  <dpranke@chromium.org>
2499
2500         Reviewed by Tony Chang.
2501
2502         NRWT needs a way to log to a file without including backspaces without needing --verbose
2503         https://bugs.webkit.org/show_bug.cgi?id=60328
2504
2505         This change modifies NRWT so that if it can tell if it is
2506         writing to a terminal, it will overwrite any messages printed
2507         in the 'one-line-progress' and 'updates' print options, and if
2508         not (or if --verbose was specified) the messages will be printed
2509         without backspaces.
2510
2511         If the overwriting updates are disabled, one-line-progress will
2512         only print every 10 seconds instead of on every update. This
2513         ensures that we still get updates once in a while while the
2514         tests are running, even if we're not in --verbose mode. Note
2515         that one-line-progress will now still be printed in --verbose,
2516         since it's useful as long as you're not flooded with the
2517         updates.
2518
2519         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
2520         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2521         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2522
2523 2011-06-02  Martin Robinson  <mrobinson@igalia.com>
2524
2525         Reviewed by Gustavo Noronha Silva.
2526
2527         [GTK] autogen.sh is run twice for each buld on the bots
2528         https://bugs.webkit.org/show_bug.cgi?id=61951
2529
2530         * Scripts/webkitdirs.pm: Only check the previous autotools arguments
2531         for the WebKit project. This prevents build-jsc runs from forcing subsequent
2532         build-webkit runs to re-rerun autogen.sh.
2533
2534 2011-06-02  Sheriff Bot  <webkit.review.bot@gmail.com>
2535
2536         Unreviewed, rolling out r87946.
2537         http://trac.webkit.org/changeset/87946
2538         https://bugs.webkit.org/show_bug.cgi?id=61965
2539
2540         Cause NRWT to break (Requested by abarth|gardener on #webkit).
2541
2542         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
2543
2544 2011-06-02  Dimitri Glazkov  <dglazkov@chromium.org>
2545
2546         Reviewed by Darin Adler.
2547
2548         Add build logistics and plumbing for window.internals object.
2549         https://bugs.webkit.org/show_bug.cgi?id=60313
2550
2551         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linking new WebCoreTestSupport library.
2552         * DumpRenderTree/chromium/TestShell.cpp:
2553         (TestShell::bindJSObjectsToWindow): Added injection code.
2554         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2555         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): Ditto.
2556
2557 2011-06-02  Hao Zheng  <zhenghao@chromium.org>
2558
2559         Reviewed by Dirk Pranke.
2560
2561         Call cleanup() explicitly at the end of worker.run().
2562         https://bugs.webkit.org/show_bug.cgi?id=61847
2563
2564         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
2565
2566 2011-06-02  Dimitri Glazkov  <dglazkov@chromium.org>
2567
2568         Unreviewed, rolling out r87926.
2569         http://trac.webkit.org/changeset/87926
2570         https://bugs.webkit.org/show_bug.cgi?id=60313
2571
2572         Fails to find WebCoreTestSupport.dylib on bots.
2573
2574         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2575         * DumpRenderTree/chromium/TestShell.cpp:
2576         (TestShell::bindJSObjectsToWindow):
2577         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2578         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
2579
2580 2011-05-21  Dimitri Glazkov  <dglazkov@chromium.org>
2581
2582         Reviewed by Darin Adler.
2583
2584         Add build logistics and plumbing for window.internals object.
2585         https://bugs.webkit.org/show_bug.cgi?id=60313
2586
2587         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linking new WebCoreTestSupport library.
2588         * DumpRenderTree/chromium/TestShell.cpp:
2589         (TestShell::bindJSObjectsToWindow): Added injection code.
2590         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2591         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): Ditto.
2592
2593 2011-06-02  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2594
2595         Reviewed by Eric Seidel.
2596
2597         Adjust efl coding style to more efl directories
2598         https://bugs.webkit.org/show_bug.cgi?id=61903
2599
2600         * Scripts/webkitpy/style/checker.py: Adjust efl coding style to efl directories.
2601
2602 2011-06-01  Dirk Pranke  <dpranke@chromium.org>
2603
2604         Reviewed by Tony Chang.
2605
2606         old-run-webkit-tests: add support for audio files
2607         https://bugs.webkit.org/show_bug.cgi?id=57992
2608
2609         * Scripts/old-run-webkit-tests:
2610
2611 2011-06-01  Jochen Eisinger  <jochen@chromium.org>
2612
2613         Reviewed by Adam Barth.
2614
2615         Implement layoutTestController.setImagesAllowed for controlling the respective behavior of the WebPermissionClient
2616         https://bugs.webkit.org/show_bug.cgi?id=34314
2617
2618         * DumpRenderTree/DumpRenderTree.gypi:
2619         * DumpRenderTree/chromium/LayoutTestController.cpp:
2620         (LayoutTestController::LayoutTestController):
2621         (LayoutTestController::setImagesAllowed):
2622         (LayoutTestController::setStorageAllowed):
2623         * DumpRenderTree/chromium/LayoutTestController.h:
2624         * DumpRenderTree/chromium/WebPermissions.cpp: Copied from Tools/DumpRenderTree/chromium/WebPermissions.h.
2625         (WebPermissions::WebPermissions):
2626         (WebPermissions::~WebPermissions):
2627         (WebPermissions::allowImages):
2628         (WebPermissions::allowStorage):
2629         (WebPermissions::setImagesAllowed):
2630         (WebPermissions::setStorageAllowed):
2631         (WebPermissions::reset):
2632         * DumpRenderTree/chromium/WebPermissions.h:
2633
2634 2011-06-01  Noel Gordon  <noel.gordon@gmail.com>
2635
2636         Reviewed by Tony Chang.
2637
2638         Test plugin should support event logging on the windows port.
2639         https://bugs.webkit.org/show_bug.cgi?id=61721
2640
2641         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2642         (handleEventWin): Well, handle them.
2643
2644 2011-06-01  Daniel Cheng  <dcheng@chromium.org>
2645
2646         Reviewed by Tony Chang.
2647
2648         [chromium] Use correct file name for dragging out images.
2649         https://bugs.webkit.org/show_bug.cgi?id=24887
2650
2651         * DumpRenderTree/chromium/EventSender.cpp:
2652         (EventSender::EventSender):
2653         (EventSender::dumpFilenameBeingDragged):
2654         * DumpRenderTree/chromium/EventSender.h:
2655
2656 2011-06-01  Dirk Pranke  <dpranke@chromium.org>
2657
2658         Reviewed by Tony Chang.
2659
2660         nrwt: make webaudio work w/o content-length header
2661         https://bugs.webkit.org/show_bug.cgi?id=61819
2662
2663         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2664         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
2665         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
2666         * Scripts/webkitpy/layout_tests/port/webkit.py:
2667
2668 2011-06-01  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
2669
2670         Reviewed by Andreas Kling.
2671
2672         [Qt][WK2] Add QGLWidget viewport support to MiniBrowser
2673         https://bugs.webkit.org/show_bug.cgi?id=61802
2674
2675         Add command line parameter and menu item to MiniBrowser application 
2676         enabling use of QGLWidget for browser viewport.
2677
2678         * MiniBrowser/qt/BrowserWindow.cpp:
2679         (BrowserWindow::BrowserWindow):
2680         (BrowserWindow::toggleGLViewport):
2681         * MiniBrowser/qt/BrowserWindow.h:
2682         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2683         (MiniBrowserApplication::handleUserOptions):
2684         * MiniBrowser/qt/MiniBrowserApplication.h:
2685         (WindowOptions::WindowOptions):
2686
2687 2011-06-01  Martin Robinson  <mrobinson@igalia.com>
2688
2689         Reviewed by Xan Lopez.
2690
2691         Print out autogen arguments when they differ from the last set, to help
2692         with debugging build issues.
2693
2694         * Scripts/webkitdirs.pm: Print out previous and current build arguments
2695         when they differ.
2696
2697 2011-06-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2698
2699         Reviewed by Martin Robinson.
2700
2701         [GTK] run-launcher should run MiniBrowser in WebKit2
2702         https://bugs.webkit.org/show_bug.cgi?id=61858
2703
2704         * Scripts/run-launcher: Check whether -2 command line option has
2705         been passed and run MiniBrowser instead of GtkLauncher.
2706
2707 2011-05-31  Hao Zheng  <zhenghao@chromium.org>
2708
2709         Reviewed by Dirk Pranke.
2710
2711         Fix exception in verbose printing mode.
2712         https://bugs.webkit.org/show_bug.cgi?id=61723
2713
2714         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2715
2716 2011-05-31  Yong Li  <yoli@rim.com>
2717
2718         Reviewed by Eric Seidel.
2719
2720         https://bugs.webkit.org/show_bug.cgi?id=54807
2721         We have been assuming plain bitfields (like "int a : 31") are always signed integers.
2722         However some compilers can treat them as unsigned. For example, RVCT 4.0 states plain
2723         bitfields (declared without either signed or unsigned qualifiers) are treats as unsigned.
2724         http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0348c/Babjddhe.html
2725         Although we can use "--signed-bitfields" flag to make RVCT 4.0 behave as most other compilers,
2726         always using "signed"/"unsigned" qualifier to declare integral type bitfields is still a good
2727         rule we should have in order to make our code independent from compilers and compiler flags.
2728
2729         * Scripts/webkitpy/style/checkers/cpp.py:
2730
2731 2011-05-31  Hironori Bono  <hbono@chromium.org>
2732
2733         Reviewed by Eric Seidel.
2734
2735         Add a JavaScript function layoutTestController.setTextDirection().
2736         https://bugs.webkit.org/show_bug.cgi?id=50952
2737
2738         This change adds a new JavaScript function setTextDirection() to the
2739         LayoutTestController class of Safari and Chrome to write layout tests
2740         that changes the text direction of an editable element.
2741
2742         * DumpRenderTree/LayoutTestController.cpp:
2743         (setTextDirectionCallback):
2744         (LayoutTestController::staticFunctions):
2745         * DumpRenderTree/LayoutTestController.h:
2746         * DumpRenderTree/chromium/LayoutTestController.cpp:
2747         (LayoutTestController::LayoutTestController):
2748         (LayoutTestController::setTextDirection):
2749         * DumpRenderTree/chromium/LayoutTestController.h:
2750         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2751         (LayoutTestController::setTextDirection):
2752         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2753         (LayoutTestController::setTextDirection):
2754         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2755         (LayoutTestController::setTextDirection):
2756
2757 2011-05-31  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
2758
2759         Reviewed by Simon Hausmann.
2760
2761         [Qt] User-agent list of Qt test browsers is very outdated
2762         https://bugs.webkit.org/show_bug.cgi?id=61531
2763
2764         The user can edit the user-agent manually, so there's no need to have
2765         a super complete and up to date list, but it's nice to have it
2766         minimally updated.
2767
2768         * MiniBrowser/qt/useragentlist.txt:
2769         * QtTestBrowser/useragentlist.txt:
2770
2771 2011-03-30  Martin Robinson  <mrobinson@igalia.com>
2772
2773         Reviewed by Adam Roben.
2774
2775         [GTK] [WebKit2] Implement a basic WebKitTestRunner
2776         https://bugs.webkit.org/show_bug.cgi?id=57068
2777
2778         Add an implementation of WebKitTestRunner for GTK+.
2779
2780         * Scripts/build-webkittestrunner: Added knowledge of GTK+ TestRunner.
2781         * Scripts/old-run-webkit-tests: Ditto.
2782         * Scripts/run-launcher: Ditto.
2783         * Scripts/webkitdirs.pm: Ditto.
2784         * WebKitTestRunner/GNUmakefile.am: Added.
2785         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2786         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp: Added.
2787         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
2788         * WebKitTestRunner/InjectedBundle/gtk/LayoutTestControllerGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
2789         * WebKitTestRunner/PlatformWebView.h:
2790         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp: Added.
2791         * WebKitTestRunner/gtk/TestControllerGtk.cpp: Added.
2792         * WebKitTestRunner/gtk/TestInvocationGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
2793         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2794         * WebKitTestRunner/gtk/main.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
2795         (main): Added.
2796
2797 2011-05-31  Dirk Pranke  <dpranke@chromium.org>
2798
2799         Reviewed by Tony Chang.
2800
2801         new-run-webkit-tests: doesn't wait for children if it gets a ctrl-c
2802         https://bugs.webkit.org/show_bug.cgi?id=60241
2803
2804         * Scripts/new-run-webkit-tests:
2805
2806 2011-05-31  Eric Seidel  <eric@webkit.org>
2807
2808         Reviewed by David Kilzer.
2809
2810         webkitpy should create zips with zip -9
2811         https://bugs.webkit.org/show_bug.cgi?id=61789
2812
2813         Dave Kilzer suggested we add this to make zips uploaded to bugzilla smaller.
2814
2815         * Scripts/webkitpy/common/system/workspace.py:
2816         * Scripts/webkitpy/common/system/workspace_unittest.py:
2817
2818 2011-05-31  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
2819
2820         Reviewed by Csaba Osztrogonác.
2821
2822         [Qt] Implement find feature for QtTestBrowser
2823         https://bugs.webkit.org/show_bug.cgi?id=61425
2824
2825         Buildfix for --minimal and CONFIG+=qt_minimal build.
2826
2827         * QtTestBrowser/launcherwindow.cpp:
2828         (LauncherWindow::LauncherWindow):
2829         (LauncherWindow::createChrome):
2830         * QtTestBrowser/launcherwindow.h:
2831
2832 2011-05-31  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
2833
2834         Reviewed by Csaba Osztrogonác.
2835
2836         [Qt] Implement find feature for QtTestBrowser
2837         https://bugs.webkit.org/show_bug.cgi?id=61425
2838
2839         * QtTestBrowser/launcherwindow.cpp:
2840         (LauncherWindow::LauncherWindow):
2841         (LauncherWindow::createChrome):
2842         (LauncherWindow::showFindBar):
2843         (LauncherWindow::find):
2844         * QtTestBrowser/launcherwindow.h:
2845
2846 2011-05-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2847
2848         Reviewed by Martin Robinson.
2849
2850         [GTK] Implement JavaScript dialogs in MiniBrowser
2851         https://bugs.webkit.org/show_bug.cgi?id=61725
2852
2853         * MiniBrowser/gtk/BrowserWindow.c:
2854         (WKStringGetCString): Helper function to get a UTF-8 c string from
2855         a WKStringRef.
2856         (WKURLGetCString): Helper function to get a UTF-8 c string from a
2857         WKURLRef.
2858         (browserWindowUpdateURL): Update to use WKURLGetCString.
2859         (didReceiveTitleForFrame): Update to use WKStringGetCString.
2860         (createMessageDialog): Create a GtkMessageDialog.
2861         (runJavaScriptAlert):
2862         (runJavaScriptConfirm):
2863         (runJavaScriptPrompt):
2864         (browserWindowUIClientInit):
2865
2866 2011-05-29  Yuta Kitamura  <yutak@chromium.org>
2867
2868         Reviewed by Kent Tamura.
2869
2870         WebSocket closing handshake
2871         https://bugs.webkit.org/show_bug.cgi?id=35721
2872
2873         * Scripts/webkitpy/thirdparty/__init__.py:
2874         Pull in pywebsocket 0.6b1. We need to update pywebsocket
2875         to get the right behavior of closing handshake.
2876
2877 2011-05-29  Daniel Bates  <dbates@rim.com>
2878
2879         Reviewed by David Kilzer.
2880
2881         REGRESSION (r86515): svn-apply ignores diffs that omit line count in chunk range
2882         https://bugs.webkit.org/show_bug.cgi?id=61162
2883
2884         Fixes an issue where svn-apply may ignore a diff that contains a chunk range line
2885         that omits a line count. In particular, the chunk range regular expression does
2886         not match a chunk range line that omits a line count. GNU diff(1) will omit the
2887         line count in the chunk range if the line count is exactly 1. For example, appending
2888         a new line to the end of an existing file F that contains exactly one line of text will
2889         be represented in a diff with a chunk range line that omits the line count for F.
2890
2891         * Scripts/VCSUtils.pm:
2892           (parseChunkRange): Added.
2893         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl: Added.
2894         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
2895           - Added unit test "Git: Append new line to the end of an existing file".
2896
2897 2011-05-28  Adam Barth  <abarth@webkit.org>
2898
2899         Reviewed by Eric Seidel.
2900
2901         EWS builds patches that fail to build twice, which seems useless and slows down the bots
2902         https://bugs.webkit.org/show_bug.cgi?id=55585
2903
2904         This patch switches all the early warning system bots over to the new
2905         PatchAnalysisTask-based infrastructure.  This patch makes these bots
2906         more efficient (in the case where patches fail to build) and paves the
2907         way for running tests on these bots!
2908
2909         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2910         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
2911         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2912         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2913         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2914         * Scripts/webkitpy/tool/commands/queues.py:
2915
2916 2011-05-28  Kenichi Ishibashi  <bashi@chromium.org>
2917
2918         Reviewed by Kent Tamura.
2919
2920         Add bashi as a committer.
2921
2922         https://bugs.webkit.org/show_bug.cgi?id=61685
2923
2924         * Scripts/webkitpy/common/config/committers.py:
2925
2926 2011-05-27  Adam Barth  <abarth@webkit.org>
2927
2928         Reviewed by Eric Seidel.
2929
2930         When checking whether the tree is red, the EWS posts a link to the wrong log
2931         https://bugs.webkit.org/show_bug.cgi?id=61072
2932
2933         We need to cache the original script error because that contains the
2934         failure log we want to upload.  If we don't cache that script error,
2935         self._script_error will get overwritten when we sanity check the clean
2936         tree (and it also has test failures).
2937
2938         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2939             - This testing approach is slightly goofy.  We'd like to use
2940               assertRaisesRegexp, but that's not available until Python 2.7.
2941         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2942
2943 2011-05-27  Jochen Eisinger  <jochen@chromium.org>
2944
2945         Reviewed by Adam Barth.
2946
2947         Add layoutTestController.setStorageAllowed() to control whether access
2948         to the localStorage API is enabled via the WebPermissionClient
2949         https://bugs.webkit.org/show_bug.cgi?id=61581
2950
2951         * DumpRenderTree/chromium/LayoutTestController.cpp:
2952         (LayoutTestController::LayoutTestController):
2953         (LayoutTestController::setStorageAllowed):
2954         * DumpRenderTree/chromium/LayoutTestController.h:
2955         * DumpRenderTree/chromium/TestShell.cpp:
2956         (TestShell::TestShell):
2957         (TestShell::createNewWindow):
2958         * DumpRenderTree/chromium/TestShell.h:
2959         * DumpRenderTree/chromium/WebPermissions.h: Added.
2960         (WebPermissions::WebPermissions):
2961         (WebPermissions::allowStorage):
2962         (WebPermissions::setStorageAllowed):
2963         (WebPermissions::reset):
2964
2965 2011-05-27  Dirk Pranke  <dpranke@chromium.org>
2966
2967         Reviewed by Eric Seidel.
2968
2969         NRWT: clean up metered_stream code in preparation for 'nooverwriting' patch
2970         https://bugs.webkit.org/show_bug.cgi?id=60326
2971
2972         This patch removes a lot of the complexity from the
2973         metered_stream implementation that was unnecessary since there
2974         was only one caller and the logic could be coordinated better.
2975
2976         There should be no functional changes in this patch, just code
2977         getting deleted and cleaned up.
2978
2979         * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
2980         * Scripts/webkitpy/layout_tests/layout_package/metered_stream_unittest.py:
2981         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2982         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2983
2984 2011-05-27  Dirk Pranke  <dpranke@chromium.org>
2985
2986         Reviewed by Eric Seidel.
2987
2988         NRWT: minor cleanup in printing module
2989         https://bugs.webkit.org/show_bug.cgi?id=60329
2990
2991         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2992
2993 2011-05-27  Steve Lacey  <sjl@chromium.org>
2994
2995         Reviewed by David Levin.
2996
2997         Add sjl@chromium.org as a committer.
2998
2999         https://bugs.webkit.org/show_bug.cgi?id=61672
3000
3001         * Scripts/webkitpy/common/config/committers.py:
3002
3003 2011-05-27  Dirk Pranke  <dpranke@chromium.org>
3004
3005         Reviewed by Adam Barth.
3006
3007         NRWT: remove --print detailed-progress
3008         https://bugs.webkit.org/show_bug.cgi?id=60324
3009
3010         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
3011         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3012         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3013         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3014
3015 2011-05-27  Dirk Pranke  <dpranke@chromium.org>
3016
3017         Reviewed by Ojan Vafai.
3018
3019         NRWT: debug messages from the workers are being logged twice
3020         https://bugs.webkit.org/show_bug.cgi?id=60428
3021
3022         It looks like when the workers are run in separate processes
3023         we end up getting two copies of every log message they print.
3024         This has to do with the multiprocessing module on UNIX cloning
3025         the log configuration in a way I wasn't expecting, and so two
3026         log handlers end up getting registered.
3027
3028         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
3029         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3030         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3031         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3032
3033 2011-05-27  Adam Roben  <aroben@apple.com>
3034
3035         Always decode tester names from location.hash
3036
3037         When navigating directly to a tester-specific URL (e.g.,
3038         <http://build.webkit.org/TestFailures/#/Windows%207%20Release%20(Tests)>), you could end up
3039         with a URL-encoded tester name in the page, and then the encoded name could make its way
3040         into Bugzilla bugs. Bad!
3041
3042         Reviewed by David Kilzer.
3043
3044         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
3045         (ViewController.prototype.parseHash): Pass the tester name we got from location.hash through
3046         decodeURIComponent before trying to use it.
3047
3048 2011-05-27  Adam Roben  <aroben@apple.com>
3049
3050         Remove testing code that snuck into r87528
3051
3052         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
3053         (ViewController.prototype._domForNewBugLink): Remove a line I was using for some testing.
3054
3055 2011-05-27  Adam Roben  <aroben@apple.com>
3056
3057         Add links to TestFailures to easily file bugs about failing tests
3058
3059         Fixes <http://webkit.org/b/61636> <rdar://problem/9514886> TestFailures page should have
3060         links to file bugs for failing tests
3061
3062         Reviewed by David Kilzer.
3063
3064         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
3065         (Builder.prototype.resultsPageURL): New helper function to return the URL to results.html
3066         for a particular build.
3067         (Builder.prototype._getFailingTests): Use resultsPageURL.
3068
3069         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
3070         (ViewController.prototype._displayBuilder): Add links to file bugs about each set of
3071         failures.
3072         (ViewController.prototype._domForBuildName): Use resultsPageURL.
3073         (ViewController.prototype._domForNewBugLink): Added. Creates an element that represents the
3074         new bug link. The bug has a title, description, and URL already filled in for you!
3075
3076 2011-05-27  Sheriff Bot  <webkit.review.bot@gmail.com>
3077
3078         Unreviewed, rolling out r87464.
3079         http://trac.webkit.org/changeset/87464
3080         https://bugs.webkit.org/show_bug.cgi?id=61643
3081
3082         client-close/server-close tests are flaky on Chromium Mac and
3083         Windows (Requested by aklein on #webkit).
3084
3085         * Scripts/webkitpy/thirdparty/__init__.py:
3086
3087 2011-05-27  Alexey Proskuryakov  <ap@apple.com>
3088
3089         Added Douglas Davidson to contributors list for easier CC'ing.
3090
3091         * Scripts/webkitpy/common/config/committers.py:
3092
3093 2011-05-26  Mihai Parparita  <mihaip@chromium.org>
3094
3095         Reviewed by Adam Barth.
3096
3097         Fix worldID and destinationDomain argument names
3098         https://bugs.webkit.org/show_bug.cgi?id=61571
3099
3100         As part of working on r87423, I noticed a couple of inconsistencies in
3101         argument names:
3102         - We would use worldId in .h files but worldID in .cpp files.
3103           Standardize on the latter
3104         - SecurityOrigin::addOriginAccessWhitelistEntry would take a
3105           destinationDomains argument, even though the actual parameter was for
3106           a single domain (renamed to be singular).
3107
3108         * DumpRenderTree/LayoutTestController.h:
3109         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3110         (LayoutTestController::evaluateScriptInIsolatedWorld):
3111
3112 2011-05-26  Yuta Kitamura  <yutak@chromium.org>
3113
3114         Reviewed by Kent Tamura.
3115
3116         WebSocket closing handshake
3117         https://bugs.webkit.org/show_bug.cgi?id=35721
3118
3119         * Scripts/webkitpy/thirdparty/__init__.py:
3120         Pull in pywebsocket 0.6b1. We need to update pywebsocket
3121         to get the right behavior of closing handshake.
3122
3123 2011-05-26  Qi Zhang  <qi.2.zhang@nokia.com>
3124
3125         Reviewed by Andreas Kling.
3126
3127         WebKitTestRunner needs layoutTestController.setAuthorAndUserStylesEnabled
3128         https://bugs.webkit.org/show_bug.cgi?id=42676
3129
3130         Implemented layoutTestController.setAuthorAndUserStylesEnabled for WebKitTestRunner.
3131
3132         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3133         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3134         (WTR::InjectedBundle::beginTesting):
3135         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3136         (WTR::LayoutTestController::setAuthorAndUserStylesEnabled):
3137         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3138
3139 2011-05-26  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>
3140
3141         Reviewed by Andreas Kling.
3142
3143         [Qt] QtTestBrowser "Switch User Agent" dialog is broken
3144         https://bugs.webkit.org/show_bug.cgi?id=61527
3145
3146         The setMaximumHeight() call is unecessary and breaks the dialog at
3147         least on my setup.
3148
3149         * QtTestBrowser/launcherwindow.cpp:
3150         (LauncherWindow::showUserAgentDialog):
3151
3152 2011-05-02  Robert Hogan  <robert@webkit.org>
3153
3154         Reviewed by Adam Roben.
3155
3156         [Qt] Allow popup windows from plugins when initiated by a user gesture
3157
3158         https://bugs.webkit.org/show_bug.cgi?id=41292
3159
3160         Support parameters introduced in plugin-initiate-popup-window.html
3161
3162         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3163         (webkit_test_plugin_new_instance):
3164         (webkit_test_plugin_handle_event):
3165
3166 2011-05-26  Mihai Parparita  <mihaip@chromium.org>
3167
3168         Reviewed by Adam Barth.
3169
3170         Support cross-origin XMLHttpRequest in isolated worlds
3171         https://bugs.webkit.org/show_bug.cgi?id=59843
3172
3173         Expose setIsolatedWorldSecurityOrigin in LayoutTestController.
3174
3175         * DumpRenderTree/chromium/LayoutTestController.cpp:
3176         (LayoutTestController::LayoutTestController):
3177         (LayoutTestController::setIsolatedWorldSecurityOrigin):
3178         * DumpRenderTree/chromium/LayoutTestController.h:
3179
3180 2011-05-25  Brian Weinstein  <bweinstein@apple.com>
3181
3182         Reviewed by Adam Roben.
3183
3184         WebKit2: Status bar, toolbar, and menu bar checks should be in the injected bundle
3185         https://bugs.webkit.org/show_bug.cgi?id=61474
3186         <rdar://problem/9468337>
3187
3188         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3189         (WTR::InjectedBundlePage::InjectedBundlePage): Add empty entries in the WKBundlePageUIClient.
3190
3191 2011-05-26  Andreas Kling  <kling@webkit.org>
3192
3193         Unreviewed, correct address to webkit-committers mailing list.
3194
3195         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3196
3197 2011-05-25  Adam Roben  <aroben@apple.com>
3198
3199         Don't assume that builds finish in the order they were started
3200
3201         Fixes <http://webkit.org/b/61464> TestFailures page shows failures from a not-most-recent
3202         build when one slave is taking a long time to finish a build
3203
3204         Reviewed by Antti Koivisto.
3205
3206         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
3207         (Builder.prototype.getMostRecentCompletedBuildNumber): Don't assume that all builds that are
3208         newer than the oldest in-progress build are also themselves in progress. Just check whether
3209         each build is actually in progress (as signified by its presence in the currentBuilds set).
3210
3211 2011-05-25  Adam Roben  <aroben@apple.com>
3212
3213         Correctly detect cases where only a single test failed/crashed/timed out
3214
3215         Fixes <http://webkit.org/b/61463> TestFailures page doesn't show testers with only a single
3216         failing test
3217
3218         Reviewed by Darin Adler.
3219
3220         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
3221         (Builder.prototype.getNumberOfFailingTests): Don't require "test cases" to be plural. It
3222         will be singular when only a single test fails/crashes/times out.
3223
3224         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
3225         (ViewController.prototype._displayTesters): Only pluralize "test" when more than one test
3226         failed/crashed/timed out.
3227
3228 2011-05-26  Tom Hudson  <tomhudson@google.com>
3229
3230         Reviewed by Tony Chang.
3231
3232         Add flags to Chromium ImageDiff to write image comparison metrics on
3233         stdout.
3234         https://bugs.webkit.org/show_bug.cgi?id=60569
3235
3236         * DumpRenderTree/chromium/ImageDiff.cpp:
3237         (Image::createFromStdin): Fix spelling.
3238         (maxOf3): New function to do 3-way maximum.
3239         (getRedComponent): Extract red component from ABGR packed encoding.
3240         (getGreenComponent): Extract green component from ABGR packed encoding.
3241         (getBlueComponent): Extract blue component from ABGR packed encoding.
3242         (weightedPercentageDifferent): Determine % of pixels different in two
3243         images multiplied by intensity difference of each pixel.
3244         (printHelp): Document new arguments.
3245         (compareImages): Parameterize.
3246         (untestedCompareImages): Parameterize.
3247         (diffImages): Parameterize; write results on stdout if requested.
3248         (main): Parse new arguments.
3249
3250 2011-05-25  Qi Zhang  <qi.2.zhang@nokia.com>
3251
3252         Reviewed by Simon Hausmann.
3253
3254         WebKitTestRunner needs layoutTestController.setPrivateBrowsingEnabled
3255         https://bugs.webkit.org/show_bug.cgi?id=42697
3256
3257         Implemented layoutTestController.setPrivateBrowsingEnabled for WebKitTestRunner.
3258
3259         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3260         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3261         (WTR::InjectedBundle::beginTesting):
3262         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3263         (WTR::LayoutTestController::setPrivateBrowsingEnabled):
3264         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3265
3266 2011-05-25  Jon Honeycutt  <jhoneycutt@apple.com>
3267
3268         REGRESSION (WebKit2): Crash in Flash on USA Today photo gallery
3269         https://bugs.webkit.org/show_bug.cgi?id=61428
3270         <rdar://problem/9457006>
3271
3272         Reviewed by Adam Roben.
3273
3274         The crash occurs when Flash posts a message to a window that it
3275         creates, and in processing the message, it calls NPN_Evaluate to
3276         evaluate JavaScript that removes the plug-in from the page. Flash then
3277         crashes when we return to Flash code.
3278
3279         This test emulates that behavior.
3280
3281         * DumpRenderTree/TestNetscapePlugIn/win/CallJSThatDestroysPlugin.cpp: Added.
3282         (CallJSThatDestroysPlugin::CallJSThatDestroysPlugin):
3283         Initialize member vars.
3284         (CallJSThatDestroysPlugin::~CallJSThatDestroysPlugin):
3285         Remove our custom property from the message window, and destroy it.
3286         (CallJSThatDestroysPlugin::NPP_Destroy):
3287         Set m_isDestroyed, log that the plug-in was destroyed, and notify the
3288         layout test controller that we're done.
3289         (wndProc):
3290         Get the PluginTest object, and call its runTest() function.
3291         (CallJSThatDestroysPlugin::NPP_New):
3292         Setup the test: register a class for the message-only window, create
3293         it, and post a message to it to run the test.
3294         (CallJSThatDestroysPlugin::runTest):
3295         Execute JS that removes the plug-in from the page, and if we're not
3296         destroyed, log a success message.
3297
3298         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3299         Add new test to project.
3300
3301 2011-05-25  Tony Chang  <tony@chromium.org>
3302
3303         Reviewed by Adam Barth.
3304
3305         webkitpy's NetworkTransaction shouldn't use mechanize
3306         https://bugs.webkit.org/show_bug.cgi?id=61450
3307
3308         mechanize.HTTPError is just an alias for urllib2.HTTPError, so
3309         use urllib2 directly.  Re-add NetworkTransaction to
3310         test_results_uploader.py (reverting r87124).
3311
3312         * Scripts/webkitpy/common/net/networktransaction.py:
3313         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
3314
3315 2011-05-25  Kevin Ollivier  <kevino@theolliviers.com>
3316
3317         [Chromium] Unreviewed build fix. Do not define WTF/JS_EXPORT_PRIVATE to JS_EXPORTDATA
3318         until the port begins using those export macros.
3319
3320         * DumpRenderTree/chromium/config.h:
3321
3322 2011-05-25  Sheriff Bot  <webkit.review.bot@gmail.com>
3323
3324         Unreviewed, rolling out r87257.
3325         http://trac.webkit.org/changeset/87257
3326         https://bugs.webkit.org/show_bug.cgi?id=61457
3327
3328         This broke layout tests, see bug 61431. (Requested by
3329         hwennborg on #webkit).
3330
3331         * DumpRenderTree/chromium/LayoutTestController.cpp:
3332         (LayoutTestController::LayoutTestController):
3333         (LayoutTestController::clearAllDatabases):
3334         * DumpRenderTree/chromium/LayoutTestController.h:
3335
3336 2011-05-25  Qi Zhang  <qi.2.zhang@nokia.com>
3337
3338         Reviewed by Andreas Kling.
3339
3340         [Qt] fast/css/disabled-author-styles.html failed
3341         https://bugs.webkit.org/show_bug.cgi?id=61438
3342
3343         Implemented API setAuthorAndUserStylesEnabled in LayoutTestControllerQt.
3344
3345         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3346         (WebCore::WebPage::resetSettings):
3347         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3348         (LayoutTestController::setAuthorAndUserStylesEnabled):
3349         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3350
3351 2011-05-25  Adam Roben  <aroben@apple.com>
3352
3353         Identify, rather than skip, builds where run-webkit-tests exited early due to too many failures
3354
3355         Fixes <http://webkit.org/b/61441> TestFailures page should show when run-webkit-tests
3356         started exiting early due to too many crashes, timeouts, or failures
3357
3358         Reviewed by David Kilzer.
3359
3360         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
3361         (Builder.prototype.getNumberOfFailingTests): Rather than returning -1 ("unknown") when
3362         run-webkit-tests exits early due to too many failures, pass that information in another
3363         argument to the callback.
3364         (Builder.prototype.startFetchingBuildHistory): Updated the documentation comment to reflect
3365         the new structure of the object passed to the callback.
3366         (Builder.prototype._getFailingTests): Updated to expect a tooManyFailures boolean from
3367         getNumberOfFailingTests and to pass that along to our own callbacks.
3368         (Builder.prototype._incorporateBuildHistory): Updated to expect a tooManyFailures boolean
3369         from _getFailingTests and to store that value in the history object.
3370
3371         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
3372         (.info): Added.
3373
3374         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
3375         (ViewController.prototype._displayBuilder): Updated for change in structure to the history
3376         object and to add a note when run-webkit-tests exited early due to too many failures.
3377         (ViewController.prototype._displayTesters): Renamed testersAndFailureCounts to
3378         latestBuildInfos since each entry now contains more than just the tester and failure count.
3379         Now displays a message for testers where the latest build exited early due to too many
3380         failures. Updated to expect a tooManyFailures boolean from getNumberOfFailingTests and to
3381         store that value in latestBuildInfos.
3382
3383 2011-05-24  Keishi Hattori  <keishi@webkit.org>
3384
3385         Reviewed by Kent Tamura.
3386
3387         Disable textfield implementation of <input type=color>. Add INPUT_COLOR feature flag. Add input color sanitizer.
3388         https://bugs.webkit.org/show_bug.cgi?id=61273
3389
3390         * Scripts/build-webkit: Added INPUT_COLOR feature flag.
3391
3392 2011-05-24  Greg Simon  <gregsimon@chromium.org>
3393
3394         Reviewed by Dimitri Glazkov.
3395
3396         Control Indexeddb backends from LayoutTestController
3397         https://bugs.webkit.org/show_bug.cgi?id=61000
3398
3399         * DumpRenderTree/chromium/LayoutTestController.cpp:
3400         (LayoutTestController::LayoutTestController):
3401         (LayoutTestController::setOverrideIndexedDBBackingStore):
3402         (LayoutTestController::clearAllDatabases):
3403         * DumpRenderTree/chromium/LayoutTestController.h:
3404
3405 2011-05-24  Robert Hogan  <robert@webkit.org>
3406
3407         Reviewed by Ryosuke Niwa.
3408
3409         [Qt] Fix fast/events/selectstart-by-single-click-with-shift.html
3410         https://bugs.webkit.org/show_bug.cgi?id=61393
3411
3412         * DumpRenderTree/qt/EventSenderQt.h:
3413         * DumpRenderTree/qt/EventSenderQt.cpp:
3414         (getModifiers): static function for interpreting modifiers
3415         (EventSender::mouseDown): Respect keyboard modifiers
3416         (EventSender::keyDown): use new static function
3417         (EventSender::sendOrQueueEvent): whitespace fix
3418
3419 2011-05-24  Jay Civelli  <jcivelli@chromium.org>
3420
3421         Reviewed by Adam Barth.
3422
3423         Adding MHTML reading support.
3424         https://bugs.webkit.org/show_bug.cgi?id=7168
3425
3426         * Scripts/build-webkit:
3427         * Scripts/old-run-webkit-tests:
3428         * Scripts/webkitperl/features.pm:
3429         * Scripts/webkitpy/layout_tests/port/test_files.py:
3430         * Scripts/webkitpy/layout_tests/port/webkit.py:
3431
3432 2011-05-24  Stephen White  <senorblanco@chromium.org>
3433
3434         Reviewed by Kenneth Russell.
3435
3436         Remove most style checks on Source/ThirdParty/glu, since it doesn't
3437         follow WebKit style.
3438         https://bugs.webkit.org/show_bug.cgi?id=61365
3439
3440         * Scripts/webkitpy/style/checker.py:
3441
3442 2011-05-24  Adam Roben  <aroben@apple.com>
3443
3444         Don't allow forcing builds through the build.webkit.org web interface
3445
3446         Someone has been forcing bogus builds.
3447
3448         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3449
3450 2011-05-24  Qi Zhang  <qi.2.zhang@nokia.com>
3451
3452         Reviewed by Adam Roben.
3453
3454         WebKitTestRunner needs layoutTestController.setJavaScriptCanAccessClipboard
3455         https://bugs.webkit.org/show_bug.cgi?id=42669
3456
3457         Fixes the regression issue caused by patch 94265. The patch didn't intialize the setting before the 
3458         layouttest starting, it will make the test cases after editing/execCommand/clipboard-access.html failed.
3459         Because that case changed the setting.
3460
3461         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3462         (WTR::InjectedBundle::beginTesting):
3463
3464 2011-05-24  Csaba Osztrogonác  <ossy@webkit.org>
3465
3466         Reviewed by Kenneth Rohde Christiansen.
3467
3468         [ORWT]Make --skipped=only option work with parameters with LayoutTests/ prefix
3469         https://bugs.webkit.org/show_bug.cgi?id=61052
3470
3471         * Scripts/old-run-webkit-tests:
3472
3473 2011-05-24  Adam Roben  <aroben@apple.com>
3474
3475         Make TestFailures show how many tests are failing on each tester, and omit testers with no failures
3476
3477         Fixes <http://webkit.org/b/61063> <rdar://problem/9460533> TestFailures page shows testers
3478         that don't have any failing tests, which isn't useful
3479
3480         Reviewed by David Kilzer.
3481
3482         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js:
3483         (Buildbot.prototype.getTesters): Renamed from getTesterNames. Now returns Builder objects
3484         instead of name strings.
3485         (Buildbot.prototype._buildersForNames): Added. Helper function to convert an array of
3486         builder names into an array of builders.
3487
3488         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
3489         (Builder.prototype.getMostRecentCompletedBuildNumber): Added. Returns the build number of
3490         the most recently completed build, or -1 if there is no such build.
3491         (Builder.prototype.getNumberOfFailingTests): Added. Returns the number of tests that failed
3492         in the given build, or -1 if the number could not be determined. Some of this code came from
3493         _getFailingTests.
3494         (Builder.prototype._getBuildJSON): Added. Code came from _getFailingTests.
3495         (Builder.prototype._getFailingTests): Changed to use new _getBuildJSON and
3496         getNumberOfFailingTests functions.
3497
3498         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
3499         (ViewController.prototype._displayTesters): Get the current number of test failures for each
3500         tester and show it in the list. Omit testers that have no failures at all. We keep the
3501         testers and failure counts in an array and sort it before displaying the current data, as
3502         the order in which data will be fetched is unpredictable.
3503
3504 2011-05-23  Tony Chang  <tony@chromium.org>
3505
3506         Reviewed by Ojan Vafai.
3507
3508         [nrwt] don't use NetworkTranslation when uploading results
3509         https://bugs.webkit.org/show_bug.cgi?id=61315
3510
3511         This avoids autoinstalling mechanize.  It didn't matter anyway
3512         because test_results_uploader.py wasn't using mechanize to make the
3513         request so NetworkTransaction::run wasn't doing anything extra
3514         (it only matters if it catches mechanize.HTTPError).
3515
3516         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
3517
3518 2011-05-23  Tony Chang  <tony@chromium.org>
3519
3520         Reviewed by Dirk Pranke.
3521
3522         [chromium] fix the rebaseline tool to work with Linux GPU failures
3523         https://bugs.webkit.org/show_bug.cgi?id=61312
3524
3525         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3526
3527 2011-05-23  Darin Adler  <darin@apple.com>
3528
3529         Ignore generated .pyc files in a directory full of python code.
3530
3531         * Scripts/webkitpy/common/checkout/scm: Added property svn:ignore.
3532
3533 2011-05-23  Adam Barth  <abarth@webkit.org>
3534
3535         Reviewed by Eric Seidel.
3536
3537         sheriffbot should give more details about the failures in IRC
3538         https://bugs.webkit.org/show_bug.cgi?id=61233
3539
3540         With this patch, sheriffbot will annonce the set of failing tests,
3541         which might help folks triage the problem.
3542
3543         * Scripts/webkitpy/tool/commands/sheriffbot.py:
3544         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
3545
3546 2011-05-23  Sheriff Bot  <webkit.review.bot@gmail.com>
3547
3548         Unreviewed, rolling out r87078.
3549         http://trac.webkit.org/changeset/87078
3550         https://bugs.webkit.org/show_bug.cgi?id=61294
3551
3552         Patch contains errors and seems likely to break a bunch of
3553         bots (Requested by abarth on #webkit).
3554
3555         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3556         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3557         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3558
3559 2011-05-23  Alice Boxhall  <aboxhall@chromium.org>
3560
3561         Reviewed by Ojan Vafai.
3562
3563         Convert json_results_generator.py to output version 4 JSON.
3564         https://bugs.webkit.org/show_bug.cgi?id=60869
3565
3566         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3567         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3568         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3569
3570 2011-05-23  Patrick Gansterer  <paroga@webkit.org>
3571
3572         Reviewed by Adam Barth.
3573
3574         Move generation of shell_command from port to executive
3575         https://bugs.webkit.org/show_bug.cgi?id=61251
3576
3577         After move it's possible to use the code in other places too.
3578
3579         * Scripts/webkitpy/common/config/ports.py:
3580         * Scripts/webkitpy/common/system/executive.py:
3581
3582 2011-05-23  Qi Zhang  <qi.2.zhang@nokia.com>
3583
3584         Reviewed by Darin Adler.
3585
3586         WebKitTestRunner needs layoutTestController.setJavaScriptCanAccessClipboard
3587         https://bugs.webkit.org/show_bug.cgi?id=42669
3588
3589         Implement setJavaScriptCanAccessClipboard in WebKitTestRunner.
3590
3591         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3592         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3593         (WTR::LayoutTestController::setJavaScriptCanAccessClipboard):
3594         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3595
3596 2011-05-22  Robert Hogan  <robert@webkit.org>
3597
3598         Reviewed by Kenneth Rohde Christiansen.
3599
3600         Fix policyDelegate in Qt DRT
3601         https://bugs.webkit.org/show_bug.cgi?id=61247
3602
3603         Use the 'policy delegate' implemented in FrameLoaderClient
3604         for layout tests. The partial implementation in DumpRenderTreeQt
3605         is redundant, so remove it.
3606
3607         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3608         (WebCore::WebPage::acceptNavigationRequest):
3609         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3610         (LayoutTestController::waitForPolicyDelegate):
3611
3612 2011-05-22  Patrick Gansterer  <paroga@webkit.org>
3613
3614         Reviewed by Darin Adler.
3615
3616         Use double quotes for filename arguments
3617         https://bugs.webkit.org/show_bug.cgi?id=61250
3618
3619         Windows does not support single quotes on the command line,
3620         so replace them with double quotes.
3621
3622         * Scripts/prepare-ChangeLog:
3623
3624 2011-05-20  Simon Fraser  <simon.fraser@apple.com>
3625
3626         Reviewed by Sam Weinig.
3627
3628         WebKitTestRunner needs layoutTestController.pauseTransitionAtTimeOnElementWithId
3629         https://bugs.webkit.org/show_bug.cgi?id=42550
3630         
3631         Implement pauseTransitionAtTimeOnElementWithId in WebKitTestRunner.
3632
3633         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3634         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3635         Copy the code for pausing animations, FIXME comments and all.
3636         (WTR::LayoutTestController::pauseTransitionAtTimeOnElementWithId):
3637         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3638
3639 2011-05-20  Alok Priyadarshi  <alokp@chromium.org>
3640
3641         Reviewed by Stephen White.
3642
3643         Adding myself to the committers list.
3644
3645         * Scripts/webkitpy/common/config/committers.py:
3646
3647 2011-05-19  Adam Roben  <aroben@apple.com>
3648
3649         Test that the WebKit2 UI process doesn't crash when starting a download
3650
3651         Test for <http://webkit.org/b/61142> <rdar://problem/9471680> REGRESSION (r86812): Crash
3652         (preceded by assertion) in fastMalloc when downloading a file
3653
3654         Reviewed by Darin Adler.
3655
3656         * TestWebKitAPI/Tests/WebKit2/18-characters.html: Added.
3657
3658         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp: Added.
3659         (TestWebKitAPI::decidePolicyForNavigationAction): Start a download.
3660         (TestWebKitAPI::decideDestinationWithSuggestedFilename): Record that the download was
3661         started, cancel the download, and return a bogus string.
3662
3663         (TestWebKitAPI::setContextDownloadClient):
3664         (TestWebKitAPI::setPagePolicyClient):
3665         Simple helper functions.
3666
3667         (TestWebKitAPI::TEST): Load 18-characters.html, which should trigger a download thanks to
3668         our policy client, and run until we know that the download was started. If we haven't
3669         crashed, we win!
3670
3671         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3672         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3673         * TestWebKitAPI/win/copy-resources.cmd:
3674         Added new files.
3675
3676 2011-05-20  Kent Tamura  <tkent@chromium.org>
3677
3678         Reviewed by Ryosuke Niwa.
3679
3680         Fix style errors in DumpRenderTree/chromium/.
3681         https://bugs.webkit.org/show_bug.cgi?id=61172
3682
3683         * DumpRenderTree/chromium/CppBoundClass.cpp:
3684         (CppBoundClass::getAsCppVariant):
3685         (CppBoundClass::bindToJavascript):
3686         * DumpRenderTree/chromium/CppBoundClass.h:
3687         (CppBoundClass::GetterCallback::~GetterCallback):
3688         (CppBoundClass::CppBoundClass):
3689         (CppBoundClass::Callback::~Callback):
3690         (CppBoundClass::MemberCallback::MemberCallback):
3691         (CppBoundClass::MemberCallback::~MemberCallback):
3692         (CppBoundClass::MemberGetterCallback::MemberGetterCallback):
3693         (CppBoundClass::MemberGetterCallback::~MemberGetterCallback):
3694         * DumpRenderTree/chromium/CppVariant.h:
3695         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
3696         (DRTDevToolsAgent::~DRTDevToolsAgent):
3697         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
3698         (DRTDevToolsClient::sendFrontendLoaded):
3699         * DumpRenderTree/chromium/DRTDevToolsClient.h:
3700         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3701         (main):
3702         * DumpRenderTree/chromium/EventSender.cpp:
3703         (SavedEvent::SavedEvent):
3704         (EventSender::EventSender):
3705         (EventSender::keyDown):
3706         * DumpRenderTree/chromium/EventSender.h:
3707         * DumpRenderTree/chromium/ImageDiff.cpp:
3708         (Image::Image):
3709         * DumpRenderTree/chromium/LayoutTestController.cpp:
3710         (LayoutTestController::LayoutTestController):
3711         (LayoutTestController::WorkQueue::reset):
3712         (WorkItemBackForward::WorkItemBackForward):
3713         (WorkItemLoadingScript::WorkItemLoadingScript):
3714         (WorkItemNonLoadingScript::WorkItemNonLoadingScript):
3715         (WorkItemLoad::WorkItemLoad):
3716         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
3717         (LayoutTestController::pathToLocalResource):
3718         * DumpRenderTree/chromium/LayoutTestController.h:
3719         (LayoutTestController::WorkItem::~WorkItem):
3720         (LayoutTestController::WorkQueue::WorkQueue):
3721         * DumpRenderTree/chromium/MockSpellCheck.cpp:
3722         (MockSpellCheck::MockSpellCheck):
3723         (MockSpellCheck::~MockSpellCheck):
3724         * DumpRenderTree/chromium/MockSpellCheck.h:
3725         * DumpRenderTree/chromium/NotificationPresenter.h:
3726         (NotificationPresenter::NotificationPresenter):
3727         * DumpRenderTree/chromium/Task.cpp:
3728         (WebTask::WebTask):
3729         * DumpRenderTree/chromium/Task.h:
3730         (TaskList::TaskList):
3731         * DumpRenderTree/chromium/TestEventPrinter.cpp:
3732         (DRTPrinter::DRTPrinter):
3733         (TestShellPrinter::TestShellPrinter):
3734         * DumpRenderTree/chromium/TestNavigationController.cpp:
3735         (TestNavigationEntry::TestNavigationEntry):
3736         (TestNavigationEntry::~TestNavigationEntry):
3737         (TestNavigationController::TestNavigationController):
3738         (TestNavigationController::reload):
3739         (TestNavigationController::loadEntry):
3740         (TestNavigationController::didNavigateToEntry):
3741         * DumpRenderTree/chromium/TestNavigationController.h:
3742         (TestShellExtraData::TestShellExtraData):
3743         * DumpRenderTree/chromium/TestShell.cpp:
3744         (dumpHistoryItem):
3745         * DumpRenderTree/chromium/TestShell.h:
3746         (TestParams::TestParams):
3747         * DumpRenderTree/chromium/TestShellWin.cpp:
3748         (TestShell::waitTestFinished):
3749         * DumpRenderTree/chromium/TestWebWorker.h:
3750         (TestWebWorker::startWorkerContext):
3751         (TestWebWorker::terminateWorkerContext):
3752         (TestWebWorker::postMessageToWorkerContext):
3753         (TestWebWorker::clientDestroyed):
3754         (TestWebWorker::postMessageToWorkerObject):
3755         (TestWebWorker::postExceptionToWorkerObject):
3756         (TestWebWorker::postConsoleMessageToWorkerObject):
3757         (TestWebWorker::confirmMessageFromWorkerObject):
3758         (TestWebWorker::reportPendingActivity):
3759         (TestWebWorker::workerContextClosed):
3760         (TestWebWorker::~TestWebWorker):
3761         * DumpRenderTree/chromium/TextInputController.cpp:
3762         * DumpRenderTree/chromium/WebThemeControlDRTWin.h:
3763         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
3764         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
3765         (WebThemeEngineDRTWin::paintButton):
3766         (WebThemeEngineDRTWin::paintMenuList):
3767         (WebThemeEngineDRTWin::paintTrackbar):
3768         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h:
3769         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
3770         * DumpRenderTree/chromium/WebViewHost.cpp:
3771         (WebViewHost::navigate):
3772         (WebViewHost::updateSessionHistory):
3773         (WebViewHost::paintInvalidatedRegion):
3774         * DumpRenderTree/chromium/WebViewHost.h:
3775
3776 2011-05-19  Dmitry Lomov  <dslomov@google.com>
3777
3778         Reviewed by Adam Roben.
3779
3780         Detect hangs in run-api-tests
3781         https://bugs.webkit.org/show_bug.cgi?id=48043
3782
3783         * Scripts/run-api-tests: Added test timeouts
3784
3785 2011-05-19  Dmitry Lomov  <dslomov@google.com>
3786
3787         Reviewed by Adam Roben.
3788
3789         run-api-tests should run one test per process
3790         https://bugs.webkit.org/show_bug.cgi?id=61088
3791
3792         * Scripts/run-api-tests: Resurrecting the previous revison of this file, with fixes to system call under Windows, 
3793         return code, and parsing GTest output format.
3794
3795 2011-05-15  Robert Hogan  <robert@webkit.org>
3796
3797         Reviewed by Antonio Gomes.
3798
3799         [Qt][GTK] plugins/get-url-with-javascript-url.html fails
3800         https://bugs.webkit.org/show_bug.cgi?id=60834
3801         Fix unix test plugin for plugins/get-url-with-javascript-url.html
3802
3803         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3804         (webkit_test_plugin_new_stream):
3805         (webkit_test_plugin_write_ready):
3806         (webkit_test_plugin_write):
3807
3808 2011-05-19  Sheriff Bot  <webkit.review.bot@gmail.com>
3809
3810         Unreviewed, rolling out r86869, r86873, r86875, and r86877.
3811         http://trac.webkit.org/changeset/86869
3812         http://trac.webkit.org/changeset/86873
3813         http://trac.webkit.org/changeset/86875
3814         http://trac.webkit.org/changeset/86877
3815         https://bugs.webkit.org/show_bug.cgi?id=61139
3816
3817         broke builds and debug DRT (Requested by rniwa on #webkit).
3818
3819         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3820         * DumpRenderTree/chromium/TestShell.cpp:
3821         (TestShell::bindJSObjectsToWindow):
3822         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3823         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
3824
3825 2011-05-18  Dimitri Glazkov  <dglazkov@chromium.org>
3826
3827         Reviewed by Darin Adler.
3828
3829         Add build logistics and plumbing for window.internals object.
3830         https://bugs.webkit.org/show_bug.cgi?id=60313
3831
3832         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linking new WebCoreTestSupport library.
3833         * DumpRenderTree/chromium/TestShell.cpp:
3834         (TestShell::bindJSObjectsToWindow): Added injection code.
3835         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3836         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): Ditto.
3837
3838 2011-05-19  Zsolt Fehér  <h490267@stud.u-szeged.hu>
3839
3840         Reviewed by Csaba Osztrogonác.
3841
3842         [Qt] Implement eventSender.scalePageBy
3843         https://bugs.webkit.org/show_bug.cgi?id=60015
3844
3845         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3846         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3847         * DumpRenderTree/qt/EventSenderQt.cpp:
3848         (EventSender::scalePageBy):
3849         * DumpRenderTree/qt/EventSenderQt.h:
3850
3851 2011-05-19  Kenichi Ishibashi  <bashi@chromium.org>
3852
3853         Reviewed by Kent Tamura.
3854
3855         [Chromium] IME candidate window appears wrong position in an iframe
3856         https://bugs.webkit.org/show_bug.cgi?id=61023
3857
3858         Call the focused frame's firstRectForCharacterRange() instead of the
3859         main frame so that DRT behaves as the same as Chromium.
3860
3861         * DumpRenderTree/chromium/TextInputController.cpp:
3862         (TextInputController::firstRectForCharacterRange):
3863
3864 2011-05-18  Adam Roben  <aroben@apple.com>
3865
3866         Add a new page to build.webkit.org to help find when tests started failing
3867
3868         The page is accessible at <http://build.webkit.org/TestFailures/>. It is pretty minimalist
3869         right now, but already shows some useful information. It's somewhat similar to webkit-patch
3870         failure-reason and sheriffbot, and perhaps can be combined with them eventually. It's a
3871         little more convenient than either of them, though, because it's all done in the browser
3872         (and thus it's easy to go directly to the relevant test results).
3873
3874         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js: Added.
3875         (Buildbot): This class represents a Buildbot server.
3876         (Buildbot.prototype.buildURL): Returns the URL for the summary page for a particular build.
3877         (Buildbot.prototype.builderNamed): Returns a Builder with the given name.
3878         (Buildbot.prototype.getTesterNames): Fetches the names of all testers and passes them to the
3879         callback.
3880         (Buildbot.prototype.parseBuildName): Breaks up a build name into its constituent parts. Must
3881         be implemented by a derived class that understands this server's build naming scheme.
3882         (Buildbot.prototype.resultsDirectoryURL): Returns the URL for the results directory for a
3883         particular build.
3884
3885         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js: Added.
3886         (Builder): This class represents one builder on the buildbot.
3887         (Builder.prototype.buildURL): Returns the URL for the summary page for a particular build.
3888         (Builder.prototype.failureDiagnosisTextAndURL): Returns data that provides a little more
3889         information about a particular test failure.
3890         (Builder.prototype.startFetchingBuildHistory): Periodically calls the callback with
3891         information about when tests started failing.
3892         (Builder.prototype.resultsDirectoryURL): Returns the URL for the results directory for a
3893         particular build.
3894         (Builder.prototype._getBuildNames): Fetches the names of all builds and passes them to the
3895         callback.
3896         (Builder.prototype._getFailingTests): Fetches the results.html page for the given build and
3897         extracts all the failing tests listed in it, passing them to the callback.
3898         (Builder.prototype._incorporateBuildHistory): Gets the failing tests for the specified
3899         build, merges them into the build history, and calls the callback telling it whether the
3900         next build should be fetched to provide more information.
3901
3902         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
3903         Added. Just some simple styles.
3904
3905         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js: Added.
3906         (createDefinitionList): Takes an array of pairs and turns them into a DL element.
3907         (getResource): Wrapper around XMLHttpRequest.
3908         (Array.prototype.findFirst): Finds the first element matching the given predicate and
3909         returns it.
3910         (Array.prototype.last): Returns the last element of the array.
3911
3912         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js: Added.
3913         (ViewController): This class contains the main logic for displaying the page.
3914         (ViewController.loaded): Just calls through to parseHash.
3915         (ViewController.parseHash): Either starts analyzing failures on a particular builder, or
3916         shows the list of all testers so one can be chosen. This function is called when the page
3917         loads and whenever we get a hashchange event.
3918         (ViewController._displayBuilder): Asks the builder to fetch build history, and displays it
3919         as it is fetched. The display ends up grouping tests by when they started failing.
3920         (ViewController._displayTesters): Gets the list of testers and displays it.
3921
3922         (ViewController._domForBuildName):
3923         (ViewController._domForFailedTest):
3924         Helper functions to create descriptions and links for a particular build or failed test.
3925
3926         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBuildbot.js: Added.
3927         (WebKitBuildbot): Calls up to the base class constructor with the correct base URL.
3928         (WebKitBuildbot.prototype.parseBuildName): Parses a build.webkit.org-style build name.
3929
3930         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Added. Just
3931         loads all the files and sets up a ViewController, which does the rest.
3932
3933         * BuildSlaveSupport/build.webkit.org-config/templates/root.html: Added a link to the new
3934         page.
3935
3936 2011-05-18  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
3937
3938         Reviewed by Csaba Osztrogonác.
3939
3940         [Qt] Implement layoutTestController.setValueForUser()
3941         https://bugs.webkit.org/show_bug.cgi?id=60956
3942
3943         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3944         (LayoutTestController::setValueForUser):
3945         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3946
3947 2011-05-16  Robert Hogan  <robert@webkit.org>
3948
3949         Reviewed by Kenneth Rohde Christiansen.
3950
3951         plugins/invalidate_rect.html fails on linux ports
3952
3953         - Make the unix test netscape plugin recognize the onPaintEvent
3954           and windowedPlugin parameters.
3955
3956         https://bugs.webkit.org/show_bug.cgi?id=54051
3957
3958         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3959         (handleEventX11):
3960         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3961         (LayoutTestController::displayInvalidatedRegion):
3962         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3963         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3964         (webkit_test_plugin_new_instance):
3965         (webkit_test_plugin_handle_event):
3966
3967 2011-05-17  Tony Chang  <tony@chromium.org>
3968
3969         Reviewed by Ojan Vafai.
3970
3971         [chromium] move Lucid 64 bit results into LayoutTests/platform/chromium-linux
3972         https://bugs.webkit.org/show_bug.cgi?id=60895
3973
3974         Update the tools to handle the move.  Lucid 32 results now go in
3975         chromium-linux-x86 and the default platform on Linux is now x86_64.
3976
3977         * Scripts/webkitpy/layout_tests/deduplicate_tests.py: Default to x86_64
3978         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
3979         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: Default to Lucid
3980         * Scripts/webkitpy/layout_tests/port/base.py: ditto
3981         * Scripts/webkitpy/layout_tests/port/chromium_linux.py: Update directory fallback and default to Lucid 64
3982         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
3983         * Scripts/webkitpy/layout_tests/port/test.py: Update tests to default to x86_64
3984         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Update bot names.
3985         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py: Whitespace cleanup.
3986
3987 2011-05-17  Adam Roben  <aroben@apple.com>
3988
3989         Make run-api-tests work on Windows when there are spaces in the path
3990
3991         Fixes <http://webkit.org/b/60954> REGRESSION (r86511): run-api-tests fails if there are
3992         spaces in the path to TestWebKitAPI.exe
3993
3994         Reviewed by David Levin.
3995
3996         * Scripts/run-api-tests:
3997         (runTestTool): Use the "direct object" form of system() to avoid having the path to
3998         TestWebKitAPI.exe be split by the shell.
3999
4000 2011-05-16  Ian Henderson  <ianh@apple.com>
4001
4002         Reviewed by Joseph Pecoraro.
4003
4004         Page::goToItem doesn't work while loading is deferred
4005         https://bugs.webkit.org/show_bug.cgi?id=60412
4006
4007         Add setDefersLoading and goBack methods to LayoutTestController.  We
4008         need to use goBack() instead of history.back() because the latter goes
4009         through NavigationScheduler, hence doesn't exhibit the bug.
4010
4011         * DumpRenderTree/LayoutTestController.cpp:
4012         (goBackCallback):
4013         (setDefersLoadingCallback):
4014         (LayoutTestController::staticFunctions):
4015         * DumpRenderTree/LayoutTestController.h:
4016         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4017         (LayoutTestController::goBack):
4018         (LayoutTestController::setDefersLoading):
4019         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
4020         (LayoutTestController::goBack):
4021         (LayoutTestController::setDefersLoading):
4022         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4023         (LayoutTestController::goBack):
4024         (LayoutTestController::setDefersLoading):
4025         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
4026         (LayoutTestController::goBack):
4027         (LayoutTestController::setDefersLoading):
4028
4029 2011-05-16  Sam Weinig  <sam@webkit.org>
4030
4031         Reviewed by Anders Carlsson.
4032
4033         TestWebKitAPI should build with clang if it can
4034         https://bugs.webkit.org/show_bug.cgi?id=60918
4035
4036         * TestWebKitAPI/Configurations/CompilerVersion.xcconfig:
4037         Update CompilerVersion.xcconfig to match others.
4038
4039         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4040         Add CompilerVersion.xcconfig to the project.
4041
4042         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
4043         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
4044         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
4045         (TestWebKitAPI::didSameDocumentNavigationForFrame):
4046         Add some casts to quiet warnings from clang.
4047
4048 2011-05-16  Dirk Pranke  <dpranke@chromium.org>
4049
4050         Reviewed by David Levin.
4051
4052         add dpranke as a reviewer
4053         https://bugs.webkit.org/show_bug.cgi?id=60919
4054
4055         * Scripts/webkitpy/common/config/committers.py:
4056
4057 2011-05-16  Robert Hogan  <robert@webkit.org>
4058
4059         Reviewed by Anders Carlsson.
4060
4061         [Gtk] plugins/get-url-notify-with-url-that-fails-to-load.html crashes on buildbot
4062
4063         https://bugs.webkit.org/show_bug.cgi?id=60838
4064
4065         The unix test plugin needs to call the test's NPP_URLNotify
4066         rather than the browsers.
4067
4068         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
4069         (webkit_test_plugin_url_notify):
4070
4071 2011-05-16  Brent Fulgham  <bfulgham@webkit.org>
4072
4073         Rubber-stamped by Adam Roben.
4074
4075         Adding myself as a reviewer.
4076         * Scripts/webkitpy/common/config/committers.py:
4077
4078 2011-05-16  Sam Weinig  <sam@webkit.org>
4079
4080         Fix typo pointed out by Dave Levin.
4081
4082         * TestWebKitAPI/PlatformUtilities.h:
4083         (TestWebKitAPI::Util::assertWKStringEqual):
4084         Strig -> String.
4085
4086 2011-05-16  Sam Weinig  <sam@webkit.org>
4087
4088         Reviewed by David Levin.
4089
4090         Convert api tester over to using gtest expectations directly
4091         https://bugs.webkit.org/show_bug.cgi?id=60862
4092
4093         * TestWebKitAPI/PlatformUtilities.cpp:
4094         (TestWebKitAPI::Util::toSTD):
4095         * TestWebKitAPI/PlatformUtilities.h:
4096         (TestWebKitAPI::Util::assertWKStrigEqual):
4097         Add convenience macro to compare WK2 strings. Add some overloads of toSTD to make
4098         the implementation of the macro simpler.
4099
4100         * TestWebKitAPI/Test.h:
4101         Remove TEST_ASSERT forwarder.
4102
4103         [Test changes elided]
4104
4105 2011-05-16  David Kilzer  <ddkilzer@apple.com>
4106
4107         <http://webkit.org/b/60913> C++ exceptions should not be enabled when building with llvm-gcc-4.2
4108         <rdar://problem/9446430>
4109
4110         Reviewed by Mark Rowe.
4111
4112         * MiniBrowser/Configurations/Base.xcconfig: Fixed typo.
4113         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
4114         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
4115
4116 2011-05-16  Jon Lee  <jonlee@apple.com>
4117
4118         Reviewed by Simon Fraser.
4119
4120         Can't horizontally scroll iframes and overflow because wheel events are always accepted
4121         https://bugs.webkit.org/show_bug.cgi?id=60779
4122
4123         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4124         (WTR::InjectedBundlePage::InjectedBundlePage): Set new default method to nil.
4125
4126 2011-05-16  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>
4127
4128         Reviewed by Csaba Osztrogonác.
4129
4130         [Qt] Tools.pro misses include(common.pri)
4131         https://bugs.webkit.org/show_bug.cgi?id=60883
4132
4133         It includes features.pri, which depends on common.pri (the build is
4134         not broken today with the default options, but this is the right
4135         thing to do).
4136
4137         * Tools.pro:
4138
4139 2011-05-15  Dominic Cooney  <dominicc@chromium.org>
4140
4141         Unreviewed: adding myself to committers.py.
4142
4143         * Scripts/webkitpy/common/config/committers.py:
4144
4145 2011-05-15  Daniel Bates  <dbates@webkit.org>
4146
4147         Reviewed by Chris Jerdonek.
4148
4149         svn-apply can't handle Git diff that only changes executable bit
4150         https://bugs.webkit.org/show_bug.cgi?id=60848
4151
4152         Fixes an issue where svn-{apply, unapply} fail to handle a Git diff for a file
4153         that only has an executable bit change.
4154
4155         * Scripts/VCSUtils.pm:
4156           - Modified regex $chunkRangeRegEx to match chunk range with ending text, say: @@ -2,6 +2,18 @@ foo().
4157         (parseDiff): Modified to count the number of text chunks in the diff. This should also help towards
4158         fixing <https://bugs.webkit.org/show_bug.cgi?id=29684>.
4159         * Scripts/svn-apply:
4160         (patch): Only use standard patch tool if the patch is non-empty and for a text file (i.e. not a binary patch).
4161         * Scripts/svn-unapply:
4162         (patch): Ditto.
4163         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
4164           - Updated expected results for test cases to account for numTextChunks.
4165           - Fixed malformed chunk range in test cases: "Git: simple", and "Git: Git diff followed by SVN diff".
4166           - Added test case "Git: file that only has an executable bit change".
4167         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
4168           - Updated expected results for test cases to account for numTextChunks.
4169
4170 2011-05-15  Sam Weinig  <sam@webkit.org>
4171
4172         Fix windows build.
4173
4174         * TestWebKitAPI/win/main.cpp:
4175         (main):
4176
4177 2011-05-15  Sam Weinig  <sam@webkit.org>
4178
4179         Reviewed by David Levin.
4180
4181         Make API tester more gtest friendly
4182         https://bugs.webkit.org/show_bug.cgi?id=60859
4183
4184         * Scripts/run-api-tests:
4185         Numerous changes:
4186         - Remove logic to run tests one at a time.
4187         - Remove logic to build up a list of tests, instead just pass --gtest_list_tests to 
4188           the test runner and allow gtest to print it for us.
4189         - Forward stdout from the test tool to stdout, even in non-verbose runs.
4190         - Run test tool from the current working directory instead of the root webkit
4191           directory.
4192
4193         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4194         Move plist to be with other bundle sources.
4195
4196         * TestWebKitAPI/TestsController.cpp:
4197         (TestWebKitAPI::TestsController::TestsController):
4198         (TestWebKitAPI::TestsController::run):
4199         * TestWebKitAPI/TestsController.h:
4200         * TestWebKitAPI/mac/main.mm:
4201         Simplify TestController down to a single run function. We should consider removing the class
4202         entirely at some point.
4203
4204 2011-05-15  Sheriff Bot  <webkit.review.bot@gmail.com>
4205
4206         Unreviewed, rolling out r86504.
4207         http://trac.webkit.org/changeset/86504
4208         https://bugs.webkit.org/show_bug.cgi?id=60853
4209
4210         "Broke Qt EventSender in editing/selection tests" (Requested
4211         by mwenge on #webkit).
4212
4213         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4214         (WebCore::WebPage::WebPage):
4215         (WebCore::DumpRenderTree::DumpRenderTree):
4216         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
4217         (WebCore::DumpRenderTree::initJSObjects):
4218         * DumpRenderTree/qt/DumpRenderTreeQt.h:
4219         (WebCore::DumpRenderTree::eventSender):
4220         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
4221         (webkit_test_plugin_new_instance):
4222         (webkit_test_plugin_set_window):
4223         (webkit_test_plugin_handle_event):
4224
4225 2011-05-12  Robert Hogan  <robert@webkit.org>
4226
4227         Reviewed by Benjamin Poulain.
4228
4229         [Qt] fix http/tests/plugins/plugin-document-has-focus.html
4230
4231         The support for this test added to the unix test plugin here
4232         may allow other platforms to pass it (nearly everyone
4233         skips it). On Qt it required a bit of trickiness with
4234         the page's EventSender object to get it working fully though,
4235         so only unskipping Qt here.
4236
4237         https://bugs.webkit.org/show_bug.cgi?id=60722
4238
4239         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4240         (WebCore::WebPage::WebPage):
4241         (WebCore::WebPage::eventSender):
4242         (WebCore::DumpRenderTree::DumpRenderTree):
4243         (WebCore::DumpRenderTree::initJSObjects):
4244         (WebCore::DumpRenderTree::createWindow):
4245         * DumpRenderTree/qt/DumpRenderTreeQt.h:
4246         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
4247         (webkit_test_plugin_new_instance):
4248         (webkit_test_plugin_set_window):
4249         (webkit_test_plugin_handle_event):
4250
4251 2011-05-14  Arno Renevier  <arno@renevier.net>
4252
4253         Reviewed by Martin Robinson.
4254
4255         make run-gtk-tests executable
4256         https://bugs.webkit.org/show_bug.cgi?id=59278
4257
4258         * Scripts/run-gtk-tests:
4259
4260 2011-05-14  Anders Carlsson  <andersca@apple.com>
4261
4262         Reviewed by Kevin Decker.
4263
4264         NPP_URLNotify is not called if a URL passed to NPN_GetURLNotify fails to load
4265         https://bugs.webkit.org/show_bug.cgi?id=60823
4266         <rdar://problem/9430386>
4267
4268         Add test that calls NPN_GetURLNotify on a URL that can't be loaded, and checks if NPP_URLNotify is called.
4269
4270         * DumpRenderTree/DumpRenderTree.gypi:
4271         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4272         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLNotifyWithURLThatFailsToLoad.cpp: Added.
4273         (GetURLNotifyWithURLThatFailsToLoad::GetURLNotifyWithURLThatFailsToLoad):
4274         (GetURLNotifyWithURLThatFailsToLoad::NPP_New):
4275         (GetURLNotifyWithURLThatFailsToLoad::NPP_URLNotify):
4276         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
4277         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
4278         * GNUmakefile.am:
4279
4280 2011-05-14  Sheriff Bot  <webkit.review.bot@gmail.com>
4281
4282         Unreviewed, rolling out r86476.
4283         http://trac.webkit.org/changeset/86476
4284         https://bugs.webkit.org/show_bug.cgi?id=60832
4285
4286         It made plugins/get-url-notify-with-url-that-fails-to-
4287         load.html crash on GTK (Requested by Ossy on #webkit).
4288
4289         * DumpRenderTree/DumpRenderTree.gypi:
4290         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4291         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLNotifyWithURLThatFailsToLoad.cpp: Removed.
4292         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
4293         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
4294         * GNUmakefile.am:
4295
4296 2011-05-13  Anders Carlsson  <andersca@apple.com>
4297
4298         Reviewed by Sam Weinig.
4299
4300         NPP_URLNotify is not called if a URL passed to NPN_GetURLNotify fails to load
4301         https://bugs.webkit.org/show_bug.cgi?id=60823
4302         <rdar://problem/9430386>
4303
4304         Add test that calls NPN_GetURLNotify on a URL that can't be loaded, and checks if NPP_URLNotify is called.
4305
4306         * DumpRenderTree/DumpRenderTree.gypi:
4307         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4308         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLNotifyWithURLThatFailsToLoad.cpp: Added.
4309         (GetURLNotifyWithURLThatFailsToLoad::GetURLNotifyWithURLThatFailsToLoad):
4310         (GetURLNotifyWithURLThatFailsToLoad::NPP_New):
4311         (GetURLNotifyWithURLThatFailsToLoad::NPP_URLNotify):
4312         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
4313         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
4314         * GNUmakefile.am:
4315
4316 2011-05-13  Anders Carlsson  <andersca@apple.com>
4317
4318         Build fix.
4319
4320         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLWithJavaScriptURL.cpp:
4321
4322 2011-05-13  Anders Carlsson  <andersca@apple.com>
4323
4324         Reviewed by Sam Weinig.
4325
4326         NPN_GetURL with a javascript: URL doesn't send back the result in the stream
4327         https://bugs.webkit.org/show_bug.cgi?id=60810
4328
4329         Add a test that calls NPN_GetURL on a javascript: URL and checks that it gets back the expect