ed2fb5488a1c8131e8f5c1de5696bcfe360ed5cf
[WebKit-https.git] / Tools / ChangeLog
1 2014-06-17  Dan Bernstein  <mitz@apple.com>
2
3         String::isolatedCopy doesn’t return an isolated copy when used on an rvalue reference
4         https://bugs.webkit.org/show_bug.cgi?id=133968
5
6         Reviewed by Anders Carlsson.
7
8         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
9         (TestWebKitAPI::TEST): Added a test that an isolated copy of an rvalue reference doesn’t
10         share an impl() with the original.
11
12 2014-06-17  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
13
14         [EFL][WK2] Skip failing EFL API tests
15         https://bugs.webkit.org/show_bug.cgi?id=133981
16
17         Reviewed by Csaba Osztrogonác.
18
19         UserMessage, WillLoad and test_ewk2_view have been failed since r169784.
20
21         * TestWebKitAPI/PlatformEfl.cmake:
22
23 2014-06-16  Ryuan Choi  <ryuan.choi@samsung.com>
24
25         [EFL][WK2] Remove workaround for icon display bug in MiniBrowser
26         https://bugs.webkit.org/show_bug.cgi?id=133962
27
28         Reviewed by Gyuyoung Kim.
29
30         Since we bumped EFL to 1.9, this workaround is unnecessary.
31
32         * MiniBrowser/efl/main.c:
33         (update_view_favicon):
34
35 2014-06-16  Gwang Yoon Hwang  <yoon@igalia.com>
36
37         [GTK] Add llvmpipe (Mesa) to the JHBuild moduleset and force it when running layout tests
38         https://bugs.webkit.org/show_bug.cgi?id=131472
39
40         Reviewed by Martin Robinson.
41
42         This patch reapplies r167510 with fixes to add llvm as a dependency for llvmpipe.
43
44         * Scripts/webkitpy/port/xvfbdriver.py:
45         (XvfbDriver._start): Use the LLVMPIPE_LIBGL_PATH to set the LD_LIBRARY_PATH
46         when running WebKitTestRunner with the Xvfb driver.
47         * gtk/install-dependencies: Add LLVM as a dependency to build llvmpipe.
48         * gtk/jhbuild.modules: Add Mesa to the modulelist so that the llvmpipe libGL is build, but not
49         installed.
50         * gtk/jhbuildrc: Set the LLVMPIPE_LIBGL_PATH environment variable so that the test driver knows
51         how to properly set the LD_LIBRARY_PATH variable. We do this because it is much easier to
52         calculate the path in the jhbuildrc than in the test driver code. This simplifies things a great
53         deal.
54
55 2014-06-16  Tanay C  <tanay.c@samsung.com>
56
57         Remove deprecated API warnings in WebKit/Tools/MiniBrowser/efl/main.c
58         https://bugs.webkit.org/show_bug.cgi?id=133792
59
60         Reviewed by Gyuyoung Kim.
61
62         * MiniBrowser/efl/main.c: replaced the deprecated API's with the latest ones
63         (show_file_entry_dialog):
64         (window_create):
65
66 2014-06-16  Mario Sanchez Prada  <mario.prada@samsung.com>
67
68         [ATK] Missing 'selection-changed' signal when navigating a combo box with keyboard
69         https://bugs.webkit.org/show_bug.cgi?id=133512
70
71         Reviewed by Chris Fleizach.
72
73         Added support for connecting to AtkSelection's 'selection-changed'
74         signal, and print it out as AXSelectedChildrenChanged in the tests.
75
76         Also removed some dead code, that became useless after r169487.
77
78         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
79         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Updated.
80
81 2014-06-15  Ryuan Choi  <ryuan.choi@samsung.com>
82
83         [EFL][WK2] Change ewk_view_settings_get to ewk_page_group_settings_get
84         https://bugs.webkit.org/show_bug.cgi?id=133841
85
86         Reviewed by Gyuyoung Kim.
87
88         * MiniBrowser/efl/main.c:
89         (window_create):
90
91 2014-06-15  Dan Bernstein  <mitz@apple.com>
92
93         Set the svn:ignore property on an Xcode project to ignore user and workspace data.
94
95         * jsc-cli/jsc-cli.xcodeproj: Added property svn:ignore.
96
97 2014-06-15  Anders Carlsson  <andersca@apple.com>
98
99         Fix build.
100
101         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
102         (callRunJavaScriptBlockAndRelease):
103         (runJavaScriptInMainFrame):
104         (TEST_F):
105
106 2014-06-13  Xabier Rodriguez Calvar  <calvaris@igalia.com>
107
108         Create MSE and EME watchlist
109         https://bugs.webkit.org/show_bug.cgi?id=133810
110
111         Reviewed by Eric Carlson.
112
113         * Scripts/webkitpy/common/config/watchlist: Create MSEEME
114         definition and add Eric Carlson and myself to it.
115
116 2014-06-12  Carlos Garcia Campos  <cgarcia@igalia.com>
117
118         [GTK] Remove all deprecated API from GObject DOM bindings
119         https://bugs.webkit.org/show_bug.cgi?id=133728
120
121         Reviewed by Martin Robinson.
122
123         * gtk/webkitdom.py:
124         (WebKitDOMDocGenerator): Remove all deleted classes from the list.
125         (WebKitDOMDocGeneratorSections.__init__): Fix a typo in member initialization.
126
127 2014-06-12  Simon Fraser  <simon.fraser@apple.com>
128
129         [iOS] Fix the view being half offscreen in WebKitTestRunner on iOS
130         https://bugs.webkit.org/show_bug.cgi?id=133835
131
132         Reviewed by Tim Horton.
133         
134         Don't do the _fakeOrigin stuff when -initWithFrame: is calling -setFrame:
135
136         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
137         (-[WebKitTestRunnerWindow initWithFrame:]):
138         (-[WebKitTestRunnerWindow setFrame:]):
139
140 2014-06-12  Carlos Alberto Lopez Perez  <clopez@igalia.com>
141
142         [GTK] Performance tests should be always ran with WKTR.
143         https://bugs.webkit.org/show_bug.cgi?id=133780
144
145         Reviewed by Ryosuke Niwa.
146
147         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
148         (PerfTestsRunner.__init__): Enable webkit_test_runner when port
149         is GTK.
150
151 2014-06-12  Sergio Villar Senin  <svillar@igalia.com>
152
153         [GTK] REGRESSION: application name is not correctly appended to the UA
154         https://bugs.webkit.org/show_bug.cgi?id=133793
155
156         Reviewed by Carlos Garcia Campos.
157
158         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
159         (testWebKitSettingsUserAgent):
160
161 2014-06-12  Sergio Villar Senin  <svillar@igalia.com>
162
163         [GTK] Unsupported browser in www.icloud.com
164         https://bugs.webkit.org/show_bug.cgi?id=133403
165
166         Reviewed by Martin Robinson.
167
168         * TestWebKitAPI/Tests/WebCore/gtk/UserAgentQuirks.cpp:
169         (TestWebKitAPI::TEST): removed a test for the NeedsSafariVersion6
170         quirk that was removed.
171
172 2014-06-11  Simon Fraser  <simon.fraser@apple.com>
173
174         [iOS WK2] Give WebKitTestRunner a viewport configuration with initial scale=1 for testing
175         https://bugs.webkit.org/show_bug.cgi?id=133779
176
177         Reviewed by Benjamin Poulain.
178         
179         Tell the WebPage to use the testing viewport configuration from the injected bundle.
180
181         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
182         (WTR::InjectedBundle::didReceiveMessage): Code cleanup.
183         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
184         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame): Call WKBundlePageSetUseTestingViewportConfiguration()
185         on iOS.
186
187 2014-06-11  Simon Fraser  <simon.fraser@apple.com>
188
189         WTR cleanup: push per-test viewport configuration into TestController, where platforms can customize it
190         https://bugs.webkit.org/show_bug.cgi?id=133770
191
192         Reviewed by Anders Carlsson.
193         
194         Push the per-test view configuration up to TestController, so that platforms
195         can modify the behavior. This also allows platform-specific changes (e.g.
196         for threaded scrolling) to made without #ifefs.
197
198         * WebKitTestRunner/TestController.cpp:
199         (WTR::TestController::updateWebViewSizeForTest):
200         (WTR::TestController::updateWindowScaleForTest):
201         (WTR::shouldUseFixedLayout):
202         (WTR::TestController::updateLayoutTypeForTest):
203         (WTR::TestController::platformConfigureViewForTest):
204         (WTR::TestController::configureViewForTest):
205         * WebKitTestRunner/TestController.h:
206         * WebKitTestRunner/TestInvocation.cpp:
207         (WTR::TestInvocation::invoke):
208         (WTR::sizeWebViewForCurrentTest): Deleted.
209         (WTR::changeWindowScaleIfNeeded): Deleted.
210         (WTR::shouldUseThreadedScrolling): Deleted.
211         (WTR::updateThreadedScrollingForCurrentTest): Deleted.
212         (WTR::shouldUseFixedLayout): Deleted.
213         (WTR::updateLayoutType): Deleted.
214         * WebKitTestRunner/TestInvocation.h:
215         (WTR::TestInvocation::pathOrURL):
216         * WebKitTestRunner/ios/TestControllerIOS.mm:
217         (WTR::shouldMakeViewportFlexible):
218         (WTR::TestController::platformConfigureViewForTest):
219         * WebKitTestRunner/mac/TestControllerMac.mm:
220         (WTR::shouldUseThreadedScrolling):
221         (WTR::TestController::platformConfigureViewForTest):
222
223 2014-06-11  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
224
225         [EFL] Add dependencies packages to efl install-dependencies file
226         https://bugs.webkit.org/show_bug.cgi?id=133720
227
228         Reviewed by Csaba Osztrogonác.
229
230         After r169785, EFL port starts to use efl 1.9 ver. EFL port needs to
231         install doxygen and libssl-dev because efl 1.9 depends on those libraries.
232
233         * efl/install-dependencies:
234
235 2014-06-11  Zoltan Horvath  <zoltan@webkit.org>
236
237         Unreviewed. Moving myself to the list of reviewers.
238
239         * Scripts/webkitpy/common/config/contributors.json:
240
241 2014-06-11  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
242
243         [EFL] Drop to maintain EFL 32bit release bot
244         https://bugs.webkit.org/show_bug.cgi?id=133710
245
246         Reviewed by Csaba Osztrogonác.
247
248         * BuildSlaveSupport/build.webkit.org-config/config.json: Removed EFL 32bit bot.
249
250 2014-06-11  Carlos Garcia Campos  <cgarcia@igalia.com>
251
252         [GTK] Use a different user agent string depending on the site
253         https://bugs.webkit.org/show_bug.cgi?id=132681
254
255         Reviewed by Anders Carlsson.
256
257         Add a unit test to check user agent quirks.
258
259         * TestWebKitAPI/PlatformGTK.cmake:
260         * TestWebKitAPI/Tests/WebCore/gtk/UserAgentQuirks.cpp: Added.
261         (TestWebKitAPI::TEST):
262         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
263         (testWebKitSettings): Site specific quirks setting is now enabled
264         by default.
265
266 2014-06-10  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
267
268         Unreviewed, update my list of email addresses in contributors.json.
269
270         * Scripts/webkitpy/common/config/contributors.json:
271
272 2014-06-10  Simon Fraser  <simon.fraser@apple.com>
273
274         Always switch to an sRGB screen color profile when running tests
275         https://bugs.webkit.org/show_bug.cgi?id=133712
276
277         Reviewed by Tim Horton.
278         
279         Switch the screen color profile to sRGB when running tests, because even ref
280         tests need the screen to use the correct color profile.
281
282         * DumpRenderTree/mac/LayoutTestHelper.m:
283         (installLayoutTestColorProfile):
284         * Scripts/webkitpy/port/mac.py:
285         (MacPort.start_helper):
286
287 2014-06-10  Martin Hodovan  <mhodovan@partner.samsung.com>
288
289         [EFL] Bump EFL libraries to 1.9
290         https://bugs.webkit.org/show_bug.cgi?id=125479
291
292         Reviewed by Gyuyoung Kim.
293
294         Based on the work of Ryuan Choi <ryuan.choi@samsung.com>
295         and László Langó <llango.u-szeged@partner.samsung.com>.
296
297         * ImageDiff/CMakeLists.txt:
298         * MiniBrowser/efl/CMakeLists.txt:
299         * efl/install-dependencies:
300         * efl/jhbuild.modules:
301         * efl/jhbuildrc:
302
303 2014-06-10  David Farler  <dfarler@apple.com>
304
305         old-run-webkit-tests: Create CoreSimulator device on demand and find it by name
306         https://bugs.webkit.org/show_bug.cgi?id=133663
307
308         Reviewed by David Kilzer.
309
310         * Scripts/old-run-webkit-tests:
311         (installAndLaunchDumpToolAppUsingNotification):
312         - Remove obsolete notification keys
313         - Key off of mandatory device UDID (a UUID)
314         - Create a device on demand via CoreSimulator if necessary
315         -- Grab the UDID from the created device plist.
316         * Scripts/webkitdirs.pm:
317         (iOSSimulatorDevicesPath): Added
318         (iOSSimulatorDevices): Added
319         (createiOSSimulatorDevice): Added
320         (deleteiOSSimulatorDevice): Added
321
322 2014-06-10  Víctor Manuel Jáquez Leal  <vjaquez@igalia.com>
323
324         [GTK][gtkdoc] remove -Wcast-align
325         https://bugs.webkit.org/show_bug.cgi?id=133640
326
327         Apparently gcc warns that GParamSpec is not castable to
328         GParamSpecInt64/GParamSpecUInt64/GParamSpecDouble due they are 64bit, even
329         though ARM hackers claim that those only need 4byte alignment. As long as gcc
330         behaves that way, this warning is not very useful, also they break the Debian
331         packaging.
332
333         This patch appends the compiler flag -Wno-align-cast for the gtkdoc
334         scanner compilation, thus the compiler ignores the previous
335         -Waling-cast flag.
336
337         Reviewed by Martin Robinson.
338
339         * gtk/generate-gtkdoc:
340         (get_generator_for_config):
341
342 2014-06-09  Alexey Proskuryakov  <ap@apple.com>
343
344         Disable button animations in regression tests
345         https://bugs.webkit.org/show_bug.cgi?id=133647
346         <rdar://problem/16677530>
347
348         Reviewed by Tim Horton.
349
350         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
351         (WTR::InjectedBundle::platformInitialize):
352
353 2014-06-09  Simon Fraser  <simon.fraser@apple.com>
354
355         Move scrolling-related tests to tiled-drawing/scrolling subdirectory, and minor cleanup
356         https://bugs.webkit.org/show_bug.cgi?id=133650
357
358         Reviewed by Tim Horton.
359         
360         No point checking for a Windows-style path in Cocoa code.
361
362         * WebKitTestRunner/TestInvocation.cpp:
363         (WTR::shouldUseThreadedScrolling):
364
365 2014-06-09  Simon Fraser  <simon.fraser@apple.com>
366
367         Fix more latched scrolling test flakiness and slowness
368         https://bugs.webkit.org/show_bug.cgi?id=133601
369
370         Reviewed by Brent Fulgham.
371         
372         Latched scrolling tests were flakey for two reasons. First, the EventSender
373         wheel events were async from the web to the UI process, and the resulting
374         synthetic events also async from the UI to the web process. Make them sync
375         for testing.
376         
377         Secondly, the timer-based scrolling tree commit could result in the scrolling
378         tree (specifically the frame node's notion of the scrollable area and content
379         size) not being updated before the scrolling thread starts getting wheel events.
380         Fix by having WebPage::wheelEventSyncForTesting() commit if necessary.
381         
382         Finally remove all the now-unnecessary timeouts from the tests.
383
384         * WebKitTestRunner/mac/EventSenderProxy.mm:
385         (WTR::EventSenderProxy::mouseMoveTo):
386         (WTR::EventSenderProxy::mouseScrollBy):
387         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
388
389 2014-06-09  Andrzej Badowski  <a.badowski@samsung.com>
390
391         [EFL] Add parameter to MiniBrowser to disable web security
392         https://bugs.webkit.org/show_bug.cgi?id=121095
393
394         Reviewed by Gyuyoung Kim.
395
396         -w (--web-security) commandline allows to disable/enable web security (enabled by default).
397         The reason for this is to test and debug (using, for example, MiniBrowser) scripts accessing
398         resources from other domains (cross-domain requests) such as access map location on another server.
399         Another possibility is to launch in a webkit browser local file tests that will refer to the links
400         in the http website loaded in an iframe. It will not be possible without deactivation of web security.
401
402         * MiniBrowser/efl/main.c:
403         (window_create):
404         (elm_main):
405
406 2014-06-06  Simon Fraser  <simon.fraser@apple.com>
407
408         32-bit build fix.
409
410         * WebKitTestRunner/mac/EventSenderProxy.mm:
411         (WTR::EventSenderProxy::mouseMoveTo):
412         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
413
414 2014-06-06  Simon Fraser  <simon.fraser@apple.com>
415
416         Fix builds on 10.8; -firstObject isn't declared on NSArray there.
417
418         * DumpRenderTree/mac/DumpRenderTree.mm:
419         (createWebViewAndOffscreenWindow):
420         * DumpRenderTree/mac/EventSendingController.mm:
421         (-[EventSendingController mouseScrollByX:andY:continuously:]):
422         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
423         * WebKitTestRunner/mac/EventSenderProxy.mm:
424         (WTR::EventSenderProxy::mouseScrollBy):
425         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
426
427 2014-06-06  Simon Fraser  <simon.fraser@apple.com>
428
429         Latched scrolling tests are flakey on Mavericks
430         https://bugs.webkit.org/show_bug.cgi?id=133578
431         <rdar://problem/17180591>
432
433         Reviewed by Brent Fulgham.
434         
435         The latched scrolling tests rely on synthetic mousewheel events whose coordinates can
436         be wrong on machines with more than one screen. This is because we use
437         [NSScreen mainScreen] when computing the global coordinates of the events, but
438         [NSScreen mainScreen] returns the screen with the key window, not the first screen.
439         
440         So replace calls to [NSScreen mainScreen] with [[NSScreen screens] firstObject]. Also
441         add comments clarifying why the coordinate math works (which is not obvious given
442         the events have no target window).
443         
444         Some scrolling tests also dispatched events outside the 800x600 test window, so
445         fix those tests, and add logging that will appear in test output when this happens.
446
447         * DumpRenderTree/mac/DumpRenderTree.mm:
448         (createWebViewAndOffscreenWindow):
449         * DumpRenderTree/mac/EventSendingController.mm:
450         (-[EventSendingController mouseScrollByX:andY:continuously:]):
451         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
452         * WebKitTestRunner/mac/EventSenderProxy.mm:
453         (WTR::EventSenderProxy::mouseMoveTo):
454         (WTR::EventSenderProxy::mouseScrollBy):
455         (WTR::EventSenderProxy::continuousMouseScrollBy):
456         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
457
458 2014-06-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
459
460         [GTK] run-perf-tests should run the tests inside the jhbuild shell.
461         https://bugs.webkit.org/show_bug.cgi?id=133533
462
463         Reviewed by Carlos Garcia Campos.
464
465         * Scripts/webkitpy/common/multiprocessing_bootstrap.py:
466         (run): Remove the jhbuild-wrapper wrapper from here. It should be
467         on Scripts/webkitpy/port/gtk.py.
468         * Scripts/webkitpy/port/base.py:
469         (Port.set_option): Add a set_option(name, value) function to set
470         the optparse parameter "name" to the value "value", even if the
471         parameter "name" is already initialized.
472         * Scripts/webkitpy/port/gtk.py:
473         (GtkPort.__init__): Set the default wrapper to jhbuild-wrapper.
474         If another wrapper is specified via the option "-l --wrapper=x",
475         then prepend the jhbuild-wrapper to the one specified.
476
477 2014-06-04  David Farler  <dfarler@apple.com>
478
479         Build ASan WebKit for iOS Simulator
480         https://bugs.webkit.org/show_bug.cgi?id=133489
481
482         Reviewed by Darin Adler.
483
484         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
485         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
486         - Add missing ASan LDFLAGS.
487         * asan/asan.xcconfig:
488         - Split compiler-rt linker flags for OS X and iOS Simulator
489
490 2014-06-03  Yoav Weiss  <yoav@yoav.ws>
491
492         Add myself (yoav@yoav.ws) to contributors.json
493         https://bugs.webkit.org/show_bug.cgi?id=133492
494
495         * Scripts/webkitpy/common/config/contributors.json:
496
497 2014-06-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
498
499         REGRESSION(r169092 and r169102): Skip failing JSC tests poperly on non-x86 Darwin platforms
500         https://bugs.webkit.org/show_bug.cgi?id=133149
501
502         Reviewed by Csaba Osztrogonác.
503
504         * Scripts/run-jsc-stress-tests: Added determineOS to determine the host operating system the script run on.
505
506 2014-06-02  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
507
508         Add a verbose flag to binding tests
509         https://bugs.webkit.org/show_bug.cgi?id=122303
510
511         Reviewed by Csaba Osztrogonác.
512
513         This patch will:
514         - Add a verbose keyword argument to the BindingsTests constructor,
515         - Add --no-verbose option to the run-bindigs-test.
516         Verbose mode, which is on by default, prints positive results to stdout as before.
517         When the --no-verbose option added to run-bindings-tests, positive results are not printed at all.
518
519         Original patch from Matthew Hanson <matthew_hanson@apple.com>
520
521         * Scripts/run-bindings-tests:
522         (main):
523         * Scripts/webkitpy/bindings/main.py:
524         (BindingsTests.__init__):
525         (BindingsTests.detect_changes):
526
527 2014-06-01  Ryosuke Niwa  <rniwa@webkit.org>
528
529         Rename DoYouEvenBench 0.17 to Speedometer 1.0 and add a new look.
530         https://bugs.webkit.org/show_bug.cgi?id=133455
531
532         Reviewed by Timothy Hatcher.
533
534         Since the perf. dashboard doesn't support following renamed benchmarks,
535         keep reporting Speedometer results as DoYouEvenBench results.
536
537         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
538         (_generate_results_dict):
539
540 2014-05-31  Darin Adler  <darin@apple.com>
541
542         Viewport percentage tests that resize the viewport are flaky
543         https://bugs.webkit.org/show_bug.cgi?id=133351
544
545         Reviewed by Anders Carlsson.
546
547         * DumpRenderTree/mac/DumpRenderTree.mm:
548         (sizeWebViewForCurrentTest): Added a call to reset the window origin, which
549         happens to be stored in the UI delegate object. This is part of resetting the
550         window position.
551
552         * DumpRenderTree/mac/UIDelegate.h: Store the window origin rather than storing
553         a frame rectangle. The size is stored in the size of the web view itself.
554         * DumpRenderTree/mac/UIDelegate.mm:
555         (-[UIDelegate resetWindowOrigin]): Added.
556         (-[UIDelegate webView:setFrame:]): Changed to set the size of the web view. The
557         old version would store the frame, but not resize the web view!
558         (-[UIDelegate webViewFrame:]): Get the size from the web view.
559
560         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
561         (WTR::PlatformWebView::setWindowFrame): Added code to resize the web view.
562
563         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
564         (WTR::PlatformWebView::resizeTo): Added a comment about missing code to resize
565         the window.
566
567         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
568         (WTR::PlatformWebView::resizeTo): Changed this to call setWindowFrame so the
569         window gets resized too, not just the web view.
570         (WTR::PlatformWebView::setWindowFrame): Added code to set the size of the web view.
571
572         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
573         (WTR::PlatformWebView::resizeTo): Changed this to call setWindowFrame so the
574         window gets resized too, not just the web view.
575         (WTR::PlatformWebView::setWindowFrame): Added code to set the size of the web view.
576
577 2014-05-30  Michael Saboff  <msaboff@apple.com>
578
579         Change run-jsc-stress-tests to not resolve jsc path locally when creating a bundle
580         https://bugs.webkit.org/show_bug.cgi?id=133409
581
582         Reviewed by Filip Pizlo.
583
584         Handle creating a tarball the same way as running remote when processing
585         paths in prepareBundle.
586
587         * Scripts/run-jsc-stress-tests:
588
589 2014-05-30  Mario Sanchez Prada  <mario.prada@samsung.com>
590
591         [ATK] Deprecate usage of logAccessibilityEvents() in layout tests
592         https://bugs.webkit.org/show_bug.cgi?id=132280
593
594         Reviewed by Chris Fleizach.
595
596         Remove implementation of logAccessibilityEvents() for ATK based
597         ports, as this has proved to be a flaky method of checking that
598         ATK events are being properly emitted. Instead, it's better to use
599         the addNotificationListener() functions and provide a JS callback
600         to check that the right events are being emmitted from the tests.
601
602         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
603         (WTR::AccessibilityController::logAccessibilityEvents): Replaced
604         with dummy implementation.
605         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
606         (WTR::AccessibilityNotificationHandler::logAccessibilityEvents): Removed
607
608 2014-05-30  Mario Sanchez Prada  <mario.prada@samsung.com>
609
610         [ATK] Deprecate usage of logAccessibilityEvents() in layout tests
611         https://bugs.webkit.org/show_bug.cgi?id=132280
612
613         Rubber stamped by Carlos Garcia Campos.
614
615         Fix two small issues with previous patch (r169483), that caused some tests to break.
616
617         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
618         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Removed
619         duplicated entry.
620         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
621         (WTR::AccessibilityUIElement::setSelectedTextRange): Fix boolean condition.
622
623 2014-05-30  Jarek Czekalski  <jarekczek@poczta.onet.pl>
624
625         [ATK] Added new accessibility signal: text-caret-moved.
626         Make AccessibilityUIElement.setSelectedTextRange work
627         as atk_text_set_caret_offset when given offset == 0.
628         https://bugs.webkit.org/show_bug.cgi?id=132527
629
630         Reviewed by Mario Sanchez Prada.
631
632         text-caret-moved signal in accessibilityController is needed to
633         implement tests from Tools/TestWebKitAPI/Tests/WebKitGtk/testatk.c
634         as LayoutTests. Add the signal to the controller.
635
636         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
637         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
638         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
639         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
640         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
641         (setSelectedTextRange): Change return type to bool.
642         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
643         (setSelectedTextRange): Call atk_text_set_caret_offset and return bool.
644         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
645         (axObjectEventListener): Add notification name AXTextCaretMoved, allow
646         for extra arguments passed to handler and use it for text-caret-moved offset.
647         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
648         Connect callback to new listener for ATK:AtkText:text-caret-moved.
649         Refactor so that failures be reported.
650         Initialize atk interfaces before trying to connect to them, see
651         https://bugzilla.gnome.org/show_bug.cgi?id=729922
652         (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
653         Simplify code by using a vector in place of dozen variables.
654         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
655         Comment about not synchronizing with accessibilityController.
656
657 2014-05-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
658
659         [GTK] Add a WebKit2 Performance bot.
660         https://bugs.webkit.org/show_bug.cgi?id=132862
661
662         Reviewed by Csaba Osztrogonác.
663
664         This adds a GTK WebKit2 perf bot.
665
666         * BuildSlaveSupport/build.webkit.org-config/config.json:
667
668 2014-05-29  Dan Bernstein  <mitz@apple.com>
669
670         Fixed the WebKitTestRunner build after r169452.
671
672         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
673         (WTR::InjectedBundle::initialize):
674
675 2014-05-28  Gwang Yoon Hwang  <yoon@igalia.com>
676
677         Unreviewed. Update my email addresses in contributors.json.
678
679         * Scripts/webkitpy/common/config/contributors.json:
680
681 2014-05-27  Jon Honeycutt  <jhoneycutt@apple.com>
682
683         Need an API test for bug #133193 (r169315)
684         <https://bugs.webkit.org/show_bug.cgi?id=133324>
685
686         This adds an API test that ensures that calling "stop loading" during a
687         "did fail provisional load" callback doesn't crash.
688
689         Reviewed by Andy Estes.
690
691         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
692         Add new files to project.
693
694         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp: Added.
695         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
696         If the message is the "test done" message, record that.
697         (TestWebKitAPI::setInjectedBundleClient):
698         Register a function for the "did receive message from injected bundle"
699         callback.
700         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
701         Assert that we received the message from the injected bundle, and set
702         'done' to finish the test.
703         (TestWebKitAPI::TEST):
704         Create a WebView, register a page loader client for the "did fail
705         provisional load" callback, and load a non-existent resource.
706
707         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp: Added.
708         (TestWebKitAPI::StopLoadingDuringDidFailProvisionalLoadTest::StopLoadingDuringDidFailProvisionalLoadTest):
709         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrameCallback):
710         Tell the StopLoadingDuringDidFailProvisionalLoadTest object that the
711         provisional load failed.
712         (TestWebKitAPI::StopLoadingDuringDidFailProvisionalLoadTest::didCreatePage):
713         Register a page loader client for the "did fail provisional load"
714         callback.
715         (TestWebKitAPI::StopLoadingDuringDidFailProvisionalLoadTest::didFailProvisionalLoad):
716         Call WKBundlePageStopLoading() during the callback. This not crashing
717         is what we're ensuring with this test.
718
719 2014-05-28  Carlos Garcia Campos  <cgarcia@igalia.com>
720
721         [GTK] Make it possible to build with FTL enabled
722         https://bugs.webkit.org/show_bug.cgi?id=133219
723
724         Reviewed by Philippe Normand.
725
726         * gtk/jhbuild-optional.modules: Add llvm from svn and build the
727         same revision than mac.
728
729 2014-05-27  Michael Saboff  <msaboff@apple.com>
730
731         REGRESSION(r169265): sh: line 0: cd: ../.vm
732         https://bugs.webkit.org/show_bug.cgi?id=133242
733
734         Rubber stamped by Oliver Hunt.
735
736         Changed runAndMonitorTestRunnerCommand() to pass mysys as a string instead of an
737         array since the command may contain character escapes that don't work with the
738         array form of system().
739
740         * Scripts/run-jsc-stress-tests:
741
742 2014-05-27  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
743
744         [EFL] Change download url of freetype6
745         https://bugs.webkit.org/show_bug.cgi?id=133303
746
747         Reviewed by Csaba Osztrogonác.
748
749         freetype6 tarball isn't downloaded in Korea. So, we need to
750         change the url for now.
751
752         * efl/jhbuild.modules:
753
754 2014-05-27  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
755
756         Remove BLOB guards
757         https://bugs.webkit.org/show_bug.cgi?id=132863
758
759         Reviewed by Csaba Osztrogonác.
760
761         * Scripts/webkitperl/FeatureList.pm:
762
763 2014-05-27  Alberto Garcia  <berto@igalia.com>
764
765         Remove leftover comment from r165182.
766
767         Rubber stamped by Carlos Garcia Campos.
768
769         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
770
771 2014-05-26  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
772
773         [EFL] Add LLVM as optional jhbuild module for FTL developers
774         https://bugs.webkit.org/show_bug.cgi?id=133216
775
776         Reviewed by Gyuyoung Kim.
777
778         * efl/jhbuild.modules:
779
780 2014-05-26  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
781
782         Fix test failures on python test
783         https://bugs.webkit.org/show_bug.cgi?id=133297
784
785         Reviewed by Dirk Schulze.
786
787         2 tests are failing because of unbounded local variable reference in test_importer.py.
788
789         * Scripts/webkitpy/w3c/test_importer.py: Move local variable declaration to top.
790         (TestImporter.import_tests):
791
792 2014-05-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
793
794         [GTK] GObject DOM bindings API break test fails in the tests bots
795         https://bugs.webkit.org/show_bug.cgi?id=133211
796
797         Reviewed by Martin Robinson.
798
799         When generating the built product archive on platform GTK, we need
800         to copy also the file gtkdoc-webkitdom.cfg and the directory
801         DerivedSources/webkitdom.
802
803         * BuildSlaveSupport/built-product-archive:
804         (archiveBuiltProduct):
805
806 2014-05-26  Commit Queue  <commit-queue@webkit.org>
807
808         Unreviewed, rolling out r169122.
809         https://bugs.webkit.org/show_bug.cgi?id=133288
810
811         Broke CJK font fallback (Requested by ap on #webkit).
812
813         Reverted changeset:
814
815         "[Mac] WebProcess doesn't follow localization of UI process
816         when run as a service"
817         https://bugs.webkit.org/show_bug.cgi?id=133126
818         http://trac.webkit.org/changeset/169122
819
820 2014-05-26  Carlos Garcia Campos  <cgarcia@igalia.com>
821
822         [GTK] WebProcess leaked when closing pages with network process enabled
823         https://bugs.webkit.org/show_bug.cgi?id=129684
824
825         Reviewed by Anders Carlsson.
826
827         Enable the test to check that web processes finish when the web
828         view is destroyed.
829
830         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
831
832 2014-05-26  Carlos Garcia Campos  <cgarcia@igalia.com>
833
834         REGRESSION(r164632): [GTK] Crash in generate-gtkdoc when rebasing docs
835         https://bugs.webkit.org/show_bug.cgi?id=133279
836
837         Reviewed by Philippe Normand.
838
839         generator.saw_warnings is only set by GTKDoc::generate(), so it
840         should only be used after generate.
841
842         * gtk/generate-gtkdoc:
843         (generate_documentation_for_config): Do not check
844         generator.saw_warnings again, simply return the value returned by
845         generate_doc() which is generator.saw_warnings. When rebasing,
846         returns always False since there aren't warnings.
847
848 2014-05-26  Youenn Fablet  <youenn.fablet@crf.canon.fr>
849
850         W3C test importer should catch exceptions coming from HTML/CSS conversion
851         https://bugs.webkit.org/show_bug.cgi?id=133176
852
853         Reviewed by Darin Adler.
854
855         Exceptions raised when converting HTML/CSS are caught.
856         Files for which conversion failed are still copied to the target directory.
857         Each individual conversion failure is logged.
858         Total conversion failure number is logged at the end of the import process.
859
860         * Scripts/webkitpy/w3c/test_importer.py:
861         (TestImporter.import_tests):
862
863 2014-05-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
864
865         [GTK] Allow to run the tests on the native X display.
866         https://bugs.webkit.org/show_bug.cgi?id=133157
867
868         Reviewed by Benjamin Poulain.
869
870         This adds a new driver (xorgdriver) that runs the tests on the
871         X display referenced by the environment variable DISPLAY.
872
873         This new driver will be activated only if the environment variable
874         USE_NATIVE_XDISPLAY is defined. This can be used both for layout
875         tests and performance tests.
876
877         This patch also makes the script run-perf-tests to check the
878         system dependencies before starting the tests. Previously this
879         was not checked, and if the system dependencies were not met,
880         the script tried to execute the tests anyway, causing massive
881         failures. For example, if you had Xvfb not installed and you
882         wanted to use the Xvfb driver (the default on GTK and EFL),
883         run-perf-tests would not abort.
884
885         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
886         (PerfTestsRunner._parse_args): Check the system dependencies of
887         the driver before starting the tests.
888         * Scripts/webkitpy/port/driver.py:
889         (Driver): Implement generic check_driver method.
890         (Driver.check_driver):
891         (Driver.check_driver.implementation):
892         * Scripts/webkitpy/port/gtk.py:
893         (GtkPort._driver_class): Check for environment variable
894         USE_NATIVE_XDISPLAY to decide if the Xorg driver should be used.
895         * Scripts/webkitpy/port/xorgdriver.py: Added.
896         (XorgDriver): Implement Xorg driver.
897         (XorgDriver.check_driver):
898         (XorgDriver._start):
899
900 2014-05-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
901
902         REGRESSION(r166798): [GTK] [EFL] kill-old-processes should not kill dbus-daemon
903         https://bugs.webkit.org/show_bug.cgi?id=133215
904
905         Reviewed by Csaba Osztrogonác.
906
907         This reverts r166798.
908
909         * BuildSlaveSupport/kill-old-processes:
910         (main):
911
912 2014-05-26  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
913
914         [EFL] Turn on ENABLE_CSS_FILTERS in build script
915         https://bugs.webkit.org/show_bug.cgi?id=133278
916
917         Reviewed by Gyuyoung Kim.
918
919         * Scripts/webkitperl/FeatureList.pm: Add a build script condition missing in r169172.
920
921 2014-05-26  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
922
923         run-javascriptcore-tests warning fix on non Mac platforms
924         https://bugs.webkit.org/show_bug.cgi?id=133260
925
926         Reviewed by Darin Adler.
927
928         * Scripts/webkitdirs.pm:
929         (argumentsForConfiguration):
930
931 2014-05-23  Michael Saboff  <msaboff@apple.com>
932
933         REGRESSION(r169265): sh: line 0: cd: ../.vm
934         https://bugs.webkit.org/show_bug.cgi?id=133242
935
936         Rubber stamped by Geoffrey Garen.
937
938         Added missing shell escapes '\' required as part of previous fix.
939
940         * Scripts/run-jsc-stress-tests:
941
942 2014-05-23  Ryosuke Niwa  <rniwa@webkit.org>
943
944         Revert the erroneous change committed in r169286.
945
946         * Scripts/webkitpy/performance_tests/perftest.py:
947         (PerfTest._run_with_driver):
948
949 2014-05-23  Geoffrey Garen  <ggaren@apple.com>
950
951         run-perf-tests should ignore whitespace lines when snarfing test output
952         https://bugs.webkit.org/show_bug.cgi?id=133238
953
954         Reviewed by Ryosuke Niwa.
955
956         Required for PerformanceTests/Canvas/terrain.html.
957
958         * Scripts/webkitpy/performance_tests/perftest.py:
959         (PerfTest._run_with_driver):
960         (PerfTest):
961
962 2014-05-23  Michael Saboff  <msaboff@apple.com>
963
964         REGRESSION (r169241) Crash running run-jsc-stress-tests on EFL ARM
965         https://bugs.webkit.org/show_bug.cgi?id=133223
966
967         Reviewed by Geoffrey Garen.
968
969         Change runAndMonitorTestRunnerCommand() to convert the *cmd argument to a
970         string before calling IO.popen() to work with older versions of ruby.
971         Changed the remote path in runShellTestRunner to quote the command
972         string we want to run via ssh so that it will work correctly with array
973         to string conversion needed for popen.
974
975         * Scripts/run-jsc-stress-tests:
976
977 2014-05-23  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
978
979         Remove 'css-shaders' option from the build-webkit
980         https://bugs.webkit.org/show_bug.cgi?id=133212
981
982         Reviewed by Daniel Bates.
983
984         Original CSS shaders removed in r162644.
985
986         * Scripts/webkitperl/FeatureList.pm:
987
988 2014-05-23  Carlos Garcia Campos  <cgarcia@igalia.com>
989
990         [GTK] GObject DOM bindings API break test should fail in the bots when the command fails to run
991         https://bugs.webkit.org/show_bug.cgi?id=133209
992
993         Reviewed by Sergio Villar Senin.
994
995         Return FAILURE when the command failed to run.
996
997         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
998         (RunGtkWebKitGObjectDOMBindingsAPIBreakTests.evaluateCommand):
999
1000 2014-05-23  Alberto Garcia  <berto@igalia.com>
1001
1002         [GTK] Install libharfbuzz-dev in Tools/gtk/install-dependencies
1003         https://bugs.webkit.org/show_bug.cgi?id=133210
1004
1005         Reviewed by Carlos Garcia Campos.
1006
1007         * gtk/install-dependencies:
1008
1009 2014-05-22  Benjamin Poulain  <bpoulain@apple.com>
1010
1011         Add Yusuke Suzuki to the list of contributors (for real)
1012
1013         Wrong section...
1014
1015         * Scripts/webkitpy/common/config/contributors.json:
1016
1017 2014-05-22  Benjamin Poulain  <bpoulain@apple.com>
1018
1019         Add Yusuke Suzuki to the list of contributors
1020
1021         * Scripts/webkitpy/common/config/contributors.json:
1022
1023 2014-05-22  Michael Saboff  <msaboff@apple.com>
1024
1025         Eliminate n/total progress update from run-jsc-stress-tests output to file
1026         https://bugs.webkit.org/show_bug.cgi?id=133191
1027
1028         Reviewed by Geoffrey Garen.
1029
1030         Changed progressMeter setting to be based on stdout being a tty instead of
1031         stdin.  Unified the processing of output from the shell runner to match the
1032         same processing as is used by the makefile runner.  As part of this, the 
1033         shell runner script was simplified.  It now forwards the output of each
1034         test_script just like the Makefile and doesn't provide its own progress.
1035
1036         * Scripts/jsc-stress-test-helpers/shell-runner.sh:
1037         * Scripts/run-jsc-stress-tests:
1038
1039 2014-05-22  Michael Saboff  <msaboff@apple.com>
1040
1041         Add option to run-jsc-stress-tests to use installed jsc
1042         https://bugs.webkit.org/show_bug.cgi?id=133102
1043
1044         Reviewed by Geoffrey Garen.
1045
1046         Added --no-copy option to not copy a JavaScriptCore framework, but use the one
1047         provied with the --jsc option.
1048
1049         * Scripts/run-jsc-stress-tests:
1050
1051 2014-05-21  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
1052
1053         [EFL] Add include path of compact_unwind_encoding.h if FTL JIT is enabled
1054         https://bugs.webkit.org/show_bug.cgi?id=132907
1055
1056         Reviewed by Gyuyoung Kim.
1057
1058         We need the mach-o/compact_unwind_encoding.h header from libc++abi-dev package
1059         in JavaScriptCore/ftl/FTLUnwindInfo.cpp when FTL JIT is enabled.
1060
1061         * efl/install-dependencies:
1062
1063 2014-05-21  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1064
1065         REGRESSION(r169092): It broke run-jsc-stress tests on non Mac platforms
1066         https://bugs.webkit.org/show_bug.cgi?id=133145
1067
1068         Reviewed by Csaba Osztrogonác.
1069
1070         * Scripts/run-jsc-stress-tests:
1071
1072 2014-05-20  Alexey Proskuryakov  <ap@apple.com>
1073
1074         [Mac] WebProcess doesn't follow localization of UI process when run as a service
1075         https://bugs.webkit.org/show_bug.cgi?id=133126
1076         <rdar://problem/13396515>
1077         <rdar://problem/16561084>
1078
1079         Reviewed by Sam Weinig and Tim Horton.
1080
1081         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1082         (WTR::InjectedBundle::platformInitialize): It was too late to override language
1083         here, and it's not necessary any more. Keeping the code for older OS versions in
1084         case it did have effect in some code paths.
1085
1086 2014-05-19  David Farler  <dfarler@apple.com>
1087
1088         Move WebKitTestRunner to std::unique_ptr
1089         https://bugs.webkit.org/show_bug.cgi?id=133081
1090
1091         Reviewed by Daniel Bates.
1092
1093         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1094         (WTR::InjectedBundle::didCreatePage):
1095         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1096         * WebKitTestRunner/TestController.cpp:
1097         (WTR::TestController::initialize):
1098         (WTR::TestController::createWebViewWithOptions):
1099         (WTR::TestController::resetStateToConsistentValues):
1100         (WTR::TestController::runTest):
1101         * WebKitTestRunner/TestController.h:
1102         * WebKitTestRunner/TestInvocation.cpp:
1103         * WebKitTestRunner/TestInvocation.h:
1104         * WebKitTestRunner/WorkQueueManager.cpp:
1105         (WTR::WorkQueueManager::processWorkQueue):
1106         (WTR::WorkQueueManager::enqueue):
1107         * WebKitTestRunner/WorkQueueManager.h:
1108
1109 2014-05-20  Carlos Garcia Campos  <cgarcia@igalia.com>
1110
1111         [GTK] WebKitWebPage::send-request always pass a valid pointer for redirected response
1112         https://bugs.webkit.org/show_bug.cgi?id=133119
1113
1114         Reviewed by Sergio Villar Senin.
1115
1116         Check that redirect response parameter of
1117         WebKitWebPage::send-request signal is NULL when not redirecting
1118         and a valid WebKitURIResponse object when redirecting.
1119
1120         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1121         (testWebResourceSendRequest):
1122         (serverCallback):
1123         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1124         (sendRequestCallback):
1125
1126 2014-05-20  Carlos Garcia Campos  <cgarcia@igalia.com>
1127
1128         REGRESSION(CMAKE): [GTK] Several WebKit2GTK+ unit tests are no longer built
1129         https://bugs.webkit.org/show_bug.cgi?id=133117
1130
1131         Reviewed by Philippe Normand.
1132
1133         Bring back missing tests to the build.
1134
1135         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
1136
1137 2014-05-19  Filip Pizlo  <fpizlo@apple.com>
1138
1139         Take care of some ARM64 test failures
1140         https://bugs.webkit.org/show_bug.cgi?id=133090
1141
1142         Reviewed by Geoffrey Garen.
1143
1144         * Scripts/run-jsc-stress-tests: Make it easier to conditionally skip things.
1145
1146 2014-05-19  David Kilzer  <ddkilzer@apple.com>
1147
1148         [iOS] REGRESSION (r168910): webkitdirs.pm: Be more forgiving when parsing --sdk, --device and --sim
1149         <http://webkit.org/b/133089>
1150
1151         Reviewed by Darin Adler.
1152
1153         * Scripts/webkitdirs.pm:
1154         (determineXcodeSDK): If both '--sdk SDKROOT' and '--sim' are
1155         specified on the command line, we would remove the '--sdk'
1156         arguments, but leave '--sim', potentially passing it along to
1157         xcodebuild causing a build failure.  This happens when
1158         'old-run-webkit-tests --release --sim' invokes
1159         build-dumprendertree when DumpRenderTree hasn't been built yet.
1160
1161 2014-05-19  David Farler  <dfarler@apple.com>
1162
1163         Dashboard: OpenSource revision key changed from WebKitOpenSource to WebKit
1164         https://bugs.webkit.org/show_bug.cgi?id=133086
1165
1166         Reviewed by Daniel Bates.
1167
1168         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1169
1170 2014-05-19  David Kilzer  <ddkilzer@apple.com>
1171
1172         REGRESSION (r169042): Fix run-api-tests on Mountain Lion
1173         <http://webkit.org/b/132954>
1174
1175         * Scripts/webkitdirs.pm:
1176         (sharedCommandLineOptionsUsage): Remove the prototype for the
1177         subroutine.  Older perls don't like the "+@" syntax.
1178
1179 2014-05-19  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1180
1181         run-javascriptcore-tests should sort the list of failing stress tests
1182         https://bugs.webkit.org/show_bug.cgi?id=132989
1183
1184         Reviewed by Csaba Osztrogonác.
1185
1186         * Scripts/run-javascriptcore-tests:
1187
1188 2014-05-19  David Kilzer  <ddkilzer@apple.com>
1189
1190         webkitdirs.pm: Add setupMacWebKitEnvironment() to set __XPC_DYLD_FRAMEWORK_PATH consistently
1191         <http://webkit.org/b/132954>
1192
1193         Reviewed by Darin Adler.
1194
1195         Extract code into setupMacWebKitEnvironment() for setting up
1196         common environment variables so it may be shared.  Sets
1197         __XPC_DYLD_FRAMEWORK_PATH consistently and adds support for
1198         using guardmalloc to some scripts.
1199
1200         Also adds support for parsing shared (common) command-line
1201         switches, initially just -g|--guard-malloc.
1202
1203         * Scripts/bisect-builds: Add -g|--guard-malloc support by using
1204         sharedCommandLineOptions() and sharedCommandLineOptionsUsage().
1205         (mountAndRunNightly): Call setupMacWebKitEnvironment().  Use a
1206         local copy of %ENV when launching Safari so we don't have to
1207         restore variables.
1208
1209         * Scripts/run-api-tests: Add -g|--guard-malloc support by using
1210         sharedCommandLineOptions() and sharedCommandLineOptionsUsage().
1211         Check result of GetOptions() to catch invalid command-line
1212         switches.
1213         (runTest): Use a local copy of %ENV when running tests so we
1214         don't have to restore variables.
1215         (prepareEnvironmentForRunningTestTool): Call
1216         setupMacWebKitEnvironment().
1217
1218         * Scripts/run-pageloadtest: Add -g|--guard-malloc support by
1219         using sharedCommandLineOptions() and
1220         sharedCommandLineOptionsUsage().  Call
1221         setupMacWebKitEnvironment().
1222
1223         * Scripts/webkitdirs.pm:
1224         (sharedCommandLineOptions): Return array of common switches to
1225         pass to Getopt::Long::GetOptions().
1226         (sharedCommandLineOptionsUsage): Return formatted string of
1227         common switches for printing usage help text.
1228         (setUpGuardMallocIfNeeded): Support using '-g' for enabling
1229         guardmalloc.
1230         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Ditto.
1231         (setupMacWebKitEnvironment): Extracted from runMacWebKitApp()
1232         and changed not to clobber DYLD_FRAMEWORK_PATH if already set.
1233         (runMacWebKitApp): Call setupMacWebKitEnvironment().  Use a
1234         local copy of %ENV when launching Safari so we don't have to
1235         restore variables.
1236         (execMacWebKitAppForDebugging): Call
1237         setupMacWebKitEnvironment().
1238
1239 2014-05-18  Rik Cabanier  <cabanier@adobe.com>
1240
1241         support for navigator.hardwareConcurrency
1242         https://bugs.webkit.org/show_bug.cgi?id=132588
1243
1244         Reviewed by Filip Pizlo.
1245
1246         * Scripts/webkitperl/FeatureList.pm:
1247
1248 2014-05-18  Anders Carlsson  <andersca@apple.com>
1249
1250         Implement Navigations for all methods declared returning one
1251         https://bugs.webkit.org/show_bug.cgi?id=133048
1252         <rdar://problem/16830064>
1253
1254         Reviewed by Sam Weinig.
1255
1256         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
1257         Import WebKit.h.
1258         
1259         * MiniBrowser/mac/WK2BrowserWindowController.m:
1260         (-[WK2BrowserWindowController webView:didStartProvisionalNavigation:]):
1261         (-[WK2BrowserWindowController webView:didReceiveServerRedirectForProvisionalNavigation:]):
1262         (-[WK2BrowserWindowController webView:didFailProvisionalNavigation:withError:]):
1263         (-[WK2BrowserWindowController webView:didCommitNavigation:]):
1264         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]):
1265         (-[WK2BrowserWindowController webView:didFailNavigation:withError:]):
1266         Print out the navigations.
1267
1268 2014-05-17  Zalan Bujtas  <zalan@apple.com>
1269
1270         Subpixel rendering: Add subpixelCSSOMElementMetricsEnabled to WK1 WebPreferences.
1271         https://bugs.webkit.org/show_bug.cgi?id=133029
1272
1273         Reviewed by Simon Fraser.
1274
1275         Added a menu item to toggle subpixelCSSOMElementMetricsEnabled's value. However
1276         toggling it on a WK2 window needs restart.
1277         Adding dynamic toggle to WK2 requires a WebPreferences SPI. It's not worth cluttering
1278         the WebPreferences just to support this temporary toggle.
1279
1280         * MiniBrowser/mac/BrowserWindowController.h:
1281         * MiniBrowser/mac/MainMenu.xib:
1282         * MiniBrowser/mac/WK1BrowserWindowController.m:
1283         (-[WK1BrowserWindowController validateMenuItem:]):
1284         (-[WK1BrowserWindowController isSubpixelCSSOMElementMetricsEnabled]):
1285         (-[WK1BrowserWindowController toggleSubpixelCSSOMElementMetricsEnabled:]):
1286         * MiniBrowser/mac/WK2BrowserWindowController.m:
1287         (-[WK2BrowserWindowController validateMenuItem:]):
1288         (-[WK2BrowserWindowController isSubpixelCSSOMElementMetricsEnabled]):
1289         (-[WK2BrowserWindowController toggleSubpixelCSSOMElementMetricsEnabled:]):
1290
1291 2014-05-17  Anders Carlsson  <andersca@apple.com>
1292
1293         Replace WKContextSetDatabaseDirectory with two WKContextConfiguration parameters
1294         https://bugs.webkit.org/show_bug.cgi?id=133033
1295         <rdar://problem/16830143>
1296
1297         Reviewed by Sam Weinig.
1298
1299         Set up the WebSQL and IndexedDB directories.
1300
1301         * WebKitTestRunner/TestController.cpp:
1302         (WTR::TestController::initialize):
1303
1304 2014-05-16  Martin Hock  <mhock@apple.com>
1305
1306         MemoryCache::addImageToCache should return the result of add().
1307         https://bugs.webkit.org/show_bug.cgi?id=132928
1308         <rdar://problem/16651547>
1309
1310         Reviewed by Alexey Proskuryakov.
1311
1312         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1313         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1314         * TestWebKitAPI/Tests/ios/MemoryCacheAddImageToCacheIOS.mm: Added.
1315         (TestWebKitAPI::TEST):
1316
1317 2014-05-15  David Farler  <dfarler@apple.com>
1318
1319         old-run-webkit-tests: allow specifying a simulator app path
1320         https://bugs.webkit.org/show_bug.cgi?id=132975
1321
1322         Reviewed by Anders Carlsson.
1323
1324         * Scripts/old-run-webkit-tests:
1325         (openIPhoneSimulator):
1326         Add new --simulator-app command line parameter for specifying the
1327         absolute path to the simulator app to launch before starting a
1328         session.
1329
1330 2014-05-16  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1331
1332         [webkitpy] In case of multiple bug rollout, all bugs should be reopened, not only the oldest one
1333         https://bugs.webkit.org/show_bug.cgi?id=131363
1334
1335         Reviewed by Csaba Osztrogonác.
1336
1337         * Scripts/webkitpy/common/checkout/checkout_mock.py:
1338         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
1339         (MockBugzilla):
1340         * Scripts/webkitpy/tool/commands/download_unittest.py:
1341         (test_create_rollout_multiple_revision_with_one_resolved):
1342         (test_create_rollout_multiple_resolved):
1343         (test_rollout_two_revisions):
1344         (test_rollout_multiple_revisions):
1345         (test_rollout_multiple_revisions_with_a_missing_bug_id):
1346         * Scripts/webkitpy/tool/steps/createbug.py:
1347         (CreateBug.run):
1348         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
1349         (ReopenBugAfterRollout.run):
1350
1351 2014-05-16  Martin Hodovan  <mhodovan.u-szeged@partner.samsung.com>
1352
1353         [WK2] Change the remaining framework includes from WebKit2 to WebKit
1354         https://bugs.webkit.org/show_bug.cgi?id=132956
1355
1356         Reviewed by Sam Weinig.
1357
1358         * MiniBrowser/MiniBrowserWebProcessPlugIn.h:
1359         * MiniBrowser/mac/AppDelegate.m:
1360         * MiniBrowser/mac/WK2BrowserWindowController.m:
1361         * TestWebKitAPI/InjectedBundleController.h:
1362         * TestWebKitAPI/InjectedBundleMain.cpp:
1363         * TestWebKitAPI/JavaScriptTest.cpp:
1364         * TestWebKitAPI/PlatformUtilities.h:
1365         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
1366         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
1367         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
1368         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
1369         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp:
1370         (TestWebKitAPI::TEST):
1371         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive_Bundle.cpp:
1372         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewRestoreZoomAndScrollBackForward.cpp:
1373         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
1374         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
1375         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
1376         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
1377         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp:
1378         * TestWebKitAPI/Tests/WebKit2/DidNotHandleKeyDown.cpp:
1379         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
1380         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
1381         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
1382         * TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp:
1383         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
1384         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
1385         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
1386         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
1387         * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
1388         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
1389         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
1390         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
1391         * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback.cpp:
1392         * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback_Bundle.cpp:
1393         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
1394         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
1395         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
1396         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp:
1397         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest.cpp:
1398         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest_Bundle.cpp:
1399         * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins.cpp:
1400         * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins_Bundle.cpp:
1401         * TestWebKitAPI/Tests/WebKit2/LayoutMilestonesWithAllContentInFrame.cpp:
1402         * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
1403         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp:
1404         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp:
1405         * TestWebKitAPI/Tests/WebKit2/LoadPageOnCrash.cpp:
1406         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:
1407         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp:
1408         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp:
1409         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
1410         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages_Bundle.cpp:
1411         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
1412         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp:
1413         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp:
1414         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
1415         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1416         * TestWebKitAPI/Tests/WebKit2/ParentFrame.cpp:
1417         * TestWebKitAPI/Tests/WebKit2/ParentFrame_Bundle.cpp:
1418         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications.mm:
1419         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications_Bundle.cpp:
1420         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
1421         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp:
1422         * TestWebKitAPI/Tests/WebKit2/ReloadPageAfterCrash.cpp:
1423         * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
1424         * TestWebKitAPI/Tests/WebKit2/ResizeWindowAfterCrash.cpp:
1425         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
1426         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp:
1427         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp:
1428         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem_Bundle.cpp:
1429         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
1430         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
1431         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
1432         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
1433         * TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp:
1434         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
1435         * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent_Bundle.cpp:
1436         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
1437         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks_Bundle.cpp:
1438         * TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm:
1439         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm:
1440         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor_Bundle.mm:
1441         * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp:
1442         * TestWebKitAPI/Tests/WebKit2/mac/WeakObjCPtr.mm:
1443         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
1444         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
1445         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
1446         * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp:
1447         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
1448         * TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp:
1449         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1450         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
1451         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp:
1452         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
1453         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
1454         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing_Bundle.cpp:
1455         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
1456         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:
1457         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
1458         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
1459         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
1460         * TestWebKitAPI/config.h:
1461         * TestWebKitAPI/efl/PlatformWebView.cpp:
1462         * TestWebKitAPI/mac/JavaScriptTestMac.mm:
1463         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
1464         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1465         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
1466         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
1467         * WebKitTestRunner/EventSenderProxy.h:
1468         * WebKitTestRunner/GeolocationProviderMock.cpp:
1469         * WebKitTestRunner/GeolocationProviderMock.h:
1470         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1471         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1472         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1473         * WebKitTestRunner/InjectedBundle/GCController.cpp:
1474         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1475         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1476         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
1477         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1478         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1479         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1480         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1481         * WebKitTestRunner/InjectedBundle/TextInputController.cpp:
1482         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
1483         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1484         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1485         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
1486         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
1487         * WebKitTestRunner/InjectedBundle/ios/EventSenderProxyIOS.mm:
1488         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
1489         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
1490         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1491         * WebKitTestRunner/PlatformWebView.h:
1492         * WebKitTestRunner/StringFunctions.h:
1493         * WebKitTestRunner/TestController.cpp:
1494         * WebKitTestRunner/TestController.h:
1495         * WebKitTestRunner/TestInvocation.cpp:
1496         * WebKitTestRunner/TestInvocation.h:
1497         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
1498         * WebKitTestRunner/WebNotificationProvider.cpp:
1499         * WebKitTestRunner/WebNotificationProvider.h:
1500         * WebKitTestRunner/WorkQueueManager.cpp:
1501         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
1502         * WebKitTestRunner/cg/TestInvocationCG.cpp:
1503         * WebKitTestRunner/cocoa/CrashReporterInfo.mm:
1504         * WebKitTestRunner/config.h:
1505         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1506         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1507         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1508         * WebKitTestRunner/ios/TestControllerIOS.mm:
1509         * WebKitTestRunner/mac/EventSenderProxy.mm:
1510         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1511         * WebKitTestRunner/mac/TestControllerMac.mm:
1512
1513 2014-05-15  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1514
1515         [EFL][WK2] Skip failing unit tests
1516         https://bugs.webkit.org/show_bug.cgi?id=132979
1517
1518         Reviewed by Daniel Bates.
1519
1520         * TestWebKitAPI/PlatformEfl.cmake: Skip failing unit tests for now.
1521
1522 2014-05-15  David Kilzer  <ddkilzer@apple.com>
1523
1524         [iOS] Support TestWebKitAPI in the iOS Simulator
1525         <http://webkit.org/b/129535>
1526         <rdar://problem/16203529>
1527
1528         Reviewed by Daniel Bates.
1529
1530         * Scripts/run-api-tests:
1531         (runTest):
1532         (listAllTests):
1533         - Extract common arguments into local variable.
1534         - Use xcrun to find the sim tool in order to invoke
1535         TestWebKitAPI properly in the iOS Simulator. 
1536
1537         * Scripts/webkitdirs.pm:
1538         (argumentsForConfiguration): Set --device or --sim as
1539         appropriate to fix buildTestTool() in run-api-tests.
1540
1541 2014-05-15  Tim Horton  <timothy_horton@apple.com>
1542
1543         Fix a logging typo in copy-webkitlibraries-to-product-directory
1544
1545         Reviewed by Dean Jackson.
1546
1547         * Scripts/copy-webkitlibraries-to-product-directory:
1548
1549 2014-05-15  David Kilzer  <ddkilzer@apple.com>
1550
1551         TestWebKitAPI: URLExtras.mm should be a shared test for iOS and Mac
1552         <http://webkit.org/b/132959>
1553
1554         Reviewed by Dan Bernstein.
1555
1556         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add
1557         Cocoa directory to project and move URLExtras.mm into it.
1558         * TestWebKitAPI/Tests/Cocoa/URLExtras.mm: Renamed from Tools/TestWebKitAPI/Tests/mac/URLExtras.mm.
1559
1560 2014-05-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1561
1562         [GTK] Compile all installed resources as GResources
1563         https://bugs.webkit.org/show_bug.cgi?id=131099
1564
1565         Reviewed by Philippe Normand.
1566
1567         * Scripts/webkitpy/port/gtk.py:
1568         (GtkPort.setup_environ_for_server): Removed now unneeded
1569         AUDIO_RESOURCES_PATH env var.
1570
1571 2014-05-14  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1572
1573         Remove CSS_STICKY_POSITION guards
1574         https://bugs.webkit.org/show_bug.cgi?id=132676
1575
1576         Reviewed by Simon Fraser.
1577
1578         * Scripts/webkitperl/FeatureList.pm:
1579
1580 2014-05-14  Carlos Garcia Campos  <cgarcia@igalia.com>
1581
1582         REGRESSION(CMAKE): [GTK] InputMethodFilter unit test is not built
1583         https://bugs.webkit.org/show_bug.cgi?id=132686
1584
1585         Reviewed by Philippe Normand.
1586
1587         Bring back InputMethodFilter test to the build and compile it into
1588         a single binary TestWebCore with the other WebCore tests. Also
1589         move it from TestWebKitAPI/gtk/ to TestWebKitAPI/Tests/WebCore/gtk/.
1590
1591         * Scripts/run-gtk-tests:
1592         (TestRunner): Remove WebCoreGtk from the list of test directories.
1593         * TestWebKitAPI/PlatformGTK.cmake:
1594         * TestWebKitAPI/Tests/WebCore/gtk/InputMethodFilter.cpp: Renamed from Tools/TestWebKitAPI/Tests/gtk/InputMethodFilter.cpp.
1595
1596 2014-05-14  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
1597
1598         [EFL] Make XVFBDriver optional
1599         https://bugs.webkit.org/show_bug.cgi?id=131036
1600
1601         Reviewed by Gyuyoung Kim.
1602
1603         * Scripts/webkitpy/port/efl.py:
1604         (EflPort._driver_class):
1605
1606 2014-05-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1607
1608         Flakiness dashboard contains outdated list of bots on builders.jsonp
1609         https://bugs.webkit.org/show_bug.cgi?id=132874
1610
1611         Reviewed by Darin Adler.
1612
1613         * TestResultServer/static-dashboards/builders.jsonp: Regenerate this
1614         file by changing to the directory Tools/TestResultServer and executing
1615         the script generate_builders_json.py
1616
1617 2014-05-11  Anders Carlsson  <andersca@apple.com>
1618
1619         Replace WKContextSetLocalStorageDirectory with a context configuration getter/setter
1620         https://bugs.webkit.org/show_bug.cgi?id=132809
1621
1622         Reviewed by Dan Bernstein.
1623
1624         * WebKitTestRunner/TestController.cpp:
1625         (WTR::TestController::initialize):
1626         Set the local storage directory using WKContextConfigurationSetLocalStorageDirectory.
1627
1628 2014-05-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1629
1630         REGRESSION(CMAKE): [GTK] JavaScriptCore API tests are not built anymore
1631         https://bugs.webkit.org/show_bug.cgi?id=132739
1632
1633         Reviewed Anders Carlsson.
1634
1635         * TestWebKitAPI/CMakeLists.txt: Add missing includes required by
1636         the JSC unit tests.
1637         * TestWebKitAPI/PlatformGTK.cmake: Bring back JavaScriptCore unit tests.
1638
1639 2014-05-11  Anders Carlsson  <andersca@apple.com>
1640
1641         Add a WKContextConfigurationRef object and make the injected bundle path part of the configuration
1642         https://bugs.webkit.org/show_bug.cgi?id=132806
1643
1644         Reviewed by Beth Dakin.
1645
1646         Migrate to WKContextConfiguration.
1647
1648         * WebKitTestRunner/TestController.cpp:
1649         (WTR::TestController::initialize):
1650
1651 2014-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
1652
1653         REGRESSION(CMAKE): [GTK] WebKit2 C API tests are not longer built in the same binary
1654         https://bugs.webkit.org/show_bug.cgi?id=132685
1655
1656         Reviewed by Martin Robinson.
1657
1658         Use a single TestWebKit2 binary for all WebKit2 C API tests.
1659
1660         * TestWebKitAPI/PlatformGTK.cmake:
1661
1662 2014-05-09  Benjamin Poulain  <benjamin@webkit.org>
1663
1664         [iOS] Switch geolocation to an explicit authorization query model
1665         https://bugs.webkit.org/show_bug.cgi?id=132717
1666
1667         Reviewed by Sam Weinig.
1668
1669         * DumpRenderTree/mac/MockGeolocationProvider.mm:
1670         (-[MockGeolocationProvider initializeGeolocationForWebView:listener:]):
1671         (-[MockGeolocationProvider cancelWarmUpForWebView:]): Deleted.
1672
1673 2014-05-09  David Farler  <dfarler@apple.com>
1674
1675         com.apple.iphonesimulator.startSession needs to pass "RuntimeIdentifier"
1676         https://bugs.webkit.org/show_bug.cgi?id=132718
1677
1678         Reviewed by David Kilzer.
1679
1680         The simulator may not be able to look up runtimes by SDK paths
1681         and instead will map SDK versions to runtimes instead. In
1682         com.apple.iphonesimulator.startSession notifications,
1683         'runtimeIdentifier' (SDK version string) is preferred over
1684         'sdkRoot' (SDK path) anyway. Include the 'runtimeIdentifier' key
1685         when creating a new DRT or WKTR simulator session.
1686
1687         IPhoneSimulatorNotification.pm filters out keys for this
1688         notification's userInfo with a hard-coded list. There's no harm
1689         in including extra key-value pairs in an NSNotification userInfo
1690         dictionary anyway and the simulator may again change its
1691         userInfo schema for this notification.
1692
1693         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm:
1694         (postStartSessionNotification):
1695         * Scripts/old-run-webkit-tests:
1696         (installAndLaunchDumpToolAppUsingNotification):
1697
1698 2014-05-09  Anders Carlsson  <andersca@apple.com>
1699
1700         Another build fix.
1701
1702         * Scripts/build-webkit:
1703         WebKit2 should always be built for OS X and iOS.
1704
1705 2014-05-09  Anders Carlsson  <andersca@apple.com>
1706
1707         Follow-up build fix.
1708
1709         * Scripts/build-webkit:
1710         WebKit2 should no longer be built before WebKit.
1711
1712 2014-05-09  Anders Carlsson  <andersca@apple.com>
1713
1714         Rename WebKit2.framework to WebKit.framework
1715         https://bugs.webkit.org/show_bug.cgi?id=132743
1716         <rdar://problem/15920046>
1717
1718         Reviewed by Dan Bernstein.
1719
1720         * Scripts/check-for-inappropriate-files-in-framework:
1721         Use PRODUCT_NAME instead of PROJECT_NAME when matching frameworks.
1722         Change WebKit2 to WebKit.
1723
1724         * Scripts/check-for-webkit-framework-include-consistency:
1725         Change WebKit to WebKitLegacy.
1726
1727 2014-05-09  Manuel Rego Casasnovas  <rego@igalia.com>
1728
1729         Remove GTK+ WK1 EWS from build.webkit.org/dashboard
1730         https://bugs.webkit.org/show_bug.cgi?id=132732
1731
1732         Reviewed by Alexey Proskuryakov.
1733
1734         GTK+ WK1 EWS was removed in r166427, so it shouldn't appear in the dashboard.
1735
1736         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
1737         (EWS): Remove GTK+ WK1 EWS.
1738
1739 2014-05-09  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1740
1741         Add new u-szeged contributors.
1742
1743         Reviewed by Csaba Osztrogonác.
1744
1745         * Scripts/webkitpy/common/config/contributors.json:
1746
1747 2014-05-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1748
1749         REGRESSION(CMAKE): [GTK] run-gtk-tests doesn't set the right injected bundle path
1750         https://bugs.webkit.org/show_bug.cgi?id=132736
1751
1752         Reviewed by Philippe Normand.
1753
1754         There are two problems, the path returned by common.library_build_path() is wrong when
1755         common.binary_build_path() has previously been called, and the test is still looking for
1756         the .la instead of .so
1757
1758         * TestWebKitAPI/gtk/PlatformUtilitiesGtk.cpp:
1759         (TestWebKitAPI::Util::createInjectedBundlePath): Use .so instead
1760         of .la as extension of the injected bundle library.
1761         * gtk/common.py:
1762         (binary_build_path): Remove unused global variable and add a new
1763         one for binary_build_dir instead of sharing the same global
1764         variable for library_build_path and binary_build_path.
1765
1766 2014-05-08  Praveen R Jadhav  <praveen.j@samsung.com>
1767
1768         [EFL] Enable MEDIA_STREAM for EFL port
1769         https://bugs.webkit.org/show_bug.cgi?id=132648
1770
1771         Reviewed by Gyuyoung Kim.
1772
1773         Script modified to enable MEDIA_STREAM for EFL build.
1774
1775         * Scripts/webkitperl/FeatureList.pm: 
1776
1777 2014-05-08  David Farler  <dfarler@apple.com>
1778
1779         old-run-webkit-tests: update strings for simulator devices and app name
1780         https://bugs.webkit.org/show_bug.cgi?id=132687
1781
1782         Reviewed by Darin Adler.
1783
1784         iPhone Retina (4-inch) -> iPhone 5
1785         iPhone Retina (4-inch 64-bit) -> iPhone 5s
1786
1787         * Scripts/old-run-webkit-tests:
1788         (installAndLaunchDumpToolAppUsingNotification):
1789         (openIPhoneSimulator):
1790         (quitIPhoneSimulator):
1791         quit iOS Simulator, not iPhone Simulator.
1792
1793 2014-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1794
1795         REGRESSION(r168471): Update the builder names on the scheduler list.
1796         https://bugs.webkit.org/show_bug.cgi?id=132699
1797
1798         Reviewed by Martin Robinson.
1799
1800         On r168471 I missed to update the builder names for the GTK build
1801         bots on the AnyBranchScheduler type scheduler list of bots.
1802
1803         * BuildSlaveSupport/build.webkit.org-config/config.json:
1804
1805 2014-05-08  Brady Eidson  <beidson@apple.com>
1806
1807         "shouldKeepCurrentBackForwardListItemInList" API should pass clientInfo to the callback
1808         <rdar://problem/16855357> and https://bugs.webkit.org/show_bug.cgi?id=132692
1809
1810         Reviewed by Tim Horton.
1811
1812         * TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp:
1813         (TestWebKitAPI::shouldKeepCurrentBackForwardListItemInList):
1814
1815 2014-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1816
1817         REGRESSION(r168471): Duplicate builddirs broke the build master.
1818         https://bugs.webkit.org/show_bug.cgi?id=132688
1819
1820         Reviewed by Carlos Garcia Campos.
1821
1822         Rename the builddirs of the new GTK bots introduced on r168471 to
1823         be unique. Otherwise the master will break.
1824
1825         * BuildSlaveSupport/build.webkit.org-config/config.json:
1826
1827 2014-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1828
1829         [GTK] webkitdom script assumes mkdir only fails because the directory already exists
1830         https://bugs.webkit.org/show_bug.cgi?id=132674
1831
1832         Reviewed by Philippe Normand.
1833
1834         Only ignore mkdir failure when exception is raised because the
1835         file already exists and it's a directory.
1836
1837         * gtk/webkitdom.py:
1838         (write_doc_files):
1839
1840 2014-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1841
1842         [WK2][GTK] Split the 64-bit GTK buildbots in Build and Test.
1843         https://bugs.webkit.org/show_bug.cgi?id=131358
1844
1845         Reviewed by Carlos Garcia Campos.
1846
1847         Current 64-bit GTK build bots (Release and Debug) not only test
1848         the build, but run all tests. Split each one of the bots in
1849         BuildOnly and TestWebKit2.
1850
1851         This will allow us to have a better overview of the status of
1852         the GTK port.
1853
1854         Original patch from Sergio Villar Senin <svillar@igalia.com>
1855
1856         * BuildSlaveSupport/build.webkit.org-config/config.json:
1857         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1858         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1859         (WebKitBuildbot):
1860         * Scripts/webkitpy/port/builders.py:
1861         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1862         (TestRebaselineTest.test_baseline_directory):
1863         * TestResultServer/static-dashboards/builders.jsonp:
1864         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1865         (resetGlobals):
1866         * TestResultServer/static-dashboards/loader_unittests.js:
1867
1868 2014-05-07  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1869
1870         [CoordinatedGraphics][WK2] Scale factor and scroll position is not being restored properly in a back/forward load
1871         https://bugs.webkit.org/show_bug.cgi?id=126022
1872
1873         Reviewed by Benjamin Poulain.
1874
1875         Original author : Thiago de Barros Lacerda, and finished by Gyuyoung Kim.
1876
1877         Added an unit test case to check if scroll position and scale are restored properly.
1878
1879         * TestWebKitAPI/PlatformEfl.cmake:
1880         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewRestoreZoomAndScrollBackForward.cpp: Added.
1881         (TestWebKitAPI::didFinishLoadForFrame):
1882         (TestWebKitAPI::didChangeContentsPosition):
1883         (TestWebKitAPI::TEST):
1884         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward1.html: Added.
1885         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward2.html: Added.
1886
1887 2014-05-07  Simon Fraser  <simon.fraser@apple.com>
1888
1889         WebKit1 is flashy when compositing layers come and go
1890         https://bugs.webkit.org/show_bug.cgi?id=132655
1891         <rdar://problem/16830981&16788846>
1892
1893         Reviewed by Sam Weinig.
1894         
1895         Revert the change from r166117.
1896
1897         * DumpRenderTree/mac/DumpRenderTree.mm:
1898         (updateDisplay):
1899
1900 2014-05-07  Chris Fleizach  <cfleizach@apple.com>
1901
1902         AX: AXSelectTextWithCriteria should support capitalize/lowercase/uppercase
1903         https://bugs.webkit.org/show_bug.cgi?id=132622
1904
1905         Reviewed by Mario Sanchez Prada.
1906
1907         * DumpRenderTree/AccessibilityUIElement.cpp:
1908         (selectTextWithCriteriaCallback):
1909         (isEqualCallback):
1910         * DumpRenderTree/AccessibilityUIElement.h:
1911         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1912         (AccessibilityUIElement::selectTextWithCriteria):
1913         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1914         (AccessibilityUIElement::selectTextWithCriteria):
1915         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1916         (selectTextParameterizedAttributeForCriteria):
1917         (AccessibilityUIElement::selectTextWithCriteria):
1918         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1919         (AccessibilityUIElement::selectTextWithCriteria):
1920         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1921         (WTR::AccessibilityUIElement::selectTextWithCriteria):
1922         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1923         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1924         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1925         (WTR::AccessibilityUIElement::selectTextWithCriteria):
1926         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1927         (WTR::AccessibilityUIElement::selectTextWithCriteria):
1928         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1929         (WTR::selectTextParameterizedAttributeForCriteria):
1930         (WTR::AccessibilityUIElement::selectTextWithCriteria):
1931
1932 2014-05-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1933
1934         [SOUP] TLSErrors do not cause page load to fail when not ignored
1935         https://bugs.webkit.org/show_bug.cgi?id=121548
1936
1937         Reviewed by Sergio Villar Senin.
1938
1939         Add unit tests to check that the load fails with TLS errors in
1940         case of a redirection.
1941
1942         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
1943         (testTLSErrorsRedirect):
1944         (httpsServerCallback):
1945         (beforeAll):
1946
1947 2014-05-07  Manuel Rego Casasnovas  <rego@igalia.com>
1948
1949         [CSS Grid Layout] Remove runtime feature
1950         https://bugs.webkit.org/show_bug.cgi?id=132382
1951
1952         Reviewed by Benjamin Poulain.
1953
1954         Remove cssGridLayoutEnabled setting usage.
1955
1956         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1957         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1958         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1959         (TestRunner::overridePreference):
1960         * DumpRenderTree/mac/DumpRenderTree.mm:
1961         (resetWebPreferencesToConsistentValues):
1962
1963 2014-05-06  David Kilzer  <ddkilzer@apple.com>
1964
1965         Add Makefile targets for copying static libraries (LLVM and WKSI)
1966         <http://webkit.org/b/132619>
1967
1968         Reviewed by Mark Rowe.
1969
1970         * Scripts/copy-webkitlibraries-to-product-directory: Set a
1971         sensible default for product directory if not specified on
1972         either the command-line or in the environment (by Xcode) by
1973         calling productDir() in webkitdirs.pm.
1974
1975 2014-05-06  Brady Eidson  <beidson@apple.com>
1976
1977         Add WK2 SPI to prevent the previous back/forward item from remaining in the list
1978         <rdar://problem/16248710> and https://bugs.webkit.org/show_bug.cgi?id=132636
1979
1980         Reviewed by Sam Weinig.
1981
1982         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1983
1984         * TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp: Added.
1985         (TestWebKitAPI::itemURLLastComponentIsString):
1986         (TestWebKitAPI::didFinishLoadForFrame):
1987         (TestWebKitAPI::willGoToBackForwardListItem):
1988         (TestWebKitAPI::shouldKeepCurrentBackForwardListItemInList):
1989         (TestWebKitAPI::setPageLoaderClient):
1990         (TestWebKitAPI::TEST):
1991         * TestWebKitAPI/Tests/WebKit2/simple2.html: Added.
1992         * TestWebKitAPI/Tests/WebKit2/simple3.html: Added.
1993
1994         * WebKitTestRunner/TestController.cpp:
1995         (WTR::TestController::createWebViewWithOptions): Update for new client layout.
1996
1997 2014-05-06  Darin Adler  <darin@apple.com>
1998
1999         Try to fix iOS build.
2000
2001         * DumpRenderTree/mac/TestRunnerMac.mm:
2002         (-[APITestDelegateIPhone initWithTestRunner:utf8Data:baseURL:]):
2003         Updated since I changed testRunner into a pointer instead of a reference.
2004         Updated argument names to avoid conflict with field names.
2005         (-[APITestDelegateIPhone run]): Ditto.
2006         (-[APITestDelegateIPhone _cleanUp]): Ditto.
2007
2008 2014-05-06  Commit Queue  <commit-queue@webkit.org>
2009
2010         Unreviewed, rolling out r168304.
2011         https://bugs.webkit.org/show_bug.cgi?id=132607
2012
2013         Broke the build (Requested by KaL on #webkit).
2014
2015         Reverted changeset:
2016
2017         "[GTK][CMake] Unable to do make install"
2018         https://bugs.webkit.org/show_bug.cgi?id=130188
2019         http://trac.webkit.org/changeset/168304
2020
2021 2014-05-04  Darin Adler  <darin@apple.com>
2022
2023         RetainPtr: Use adoptCF function instead of AdoptCF constructor argument
2024         https://bugs.webkit.org/show_bug.cgi?id=80222
2025
2026         Reviewed by Alexey Proskuryakov.
2027
2028         * DumpRenderTree/mac/TestRunnerMac.mm:
2029         (-[APITestDelegateIPhone initWithTestRunner:utf8Data:baseURL:]): Updated to
2030         do more work here so we don't use RetainPtr local variables.
2031         (-[APITestDelegateIPhone dealloc]): Added.
2032         (-[APITestDelegateIPhone run]): Added an early exit if the web view is already
2033         created. Updated for changes to member names and types.
2034         (-[APITestDelegateIPhone _cleanUp]): Added code to set webView to nil and
2035         updated for changes to member names and types. Changed to two word spelling.
2036         (-[APITestDelegateIPhone webView:didFailLoadWithError:forFrame:]): Updated
2037         name of _cleanUp method.
2038         (-[APITestDelegateIPhone webView:didFailProvisionalLoadWithError:forFrame:]):
2039         Ditto.
2040         (-[APITestDelegateIPhone webView:didFinishLoadForFrame:]): Ditto.
2041
2042 2014-05-05  Benjamin Poulain  <benjamin@webkit.org>
2043
2044         Clean up Image Document and tweak the layout and viewport
2045         https://bugs.webkit.org/show_bug.cgi?id=132552
2046
2047         Reviewed by Anders Carlsson.
2048
2049         * DumpRenderTree/mac/DumpRenderTree.mm:
2050         (resetWebPreferencesToConsistentValues):
2051         Update the default settings to have something consistent with WebKit2.
2052
2053 2014-05-05  Martin Robinson  <mrobinson@igalia.com>
2054
2055         [GTK][CMake] Unable to do make install
2056         https://bugs.webkit.org/show_bug.cgi?id=130188
2057
2058         Reviewed by Carlos Garcia Campos.
2059
2060         * Scripts/webkitdirs.pm:
2061         (buildCMakeGeneratedProject): Always build gtkdoc-no-html for WebKitGTK+. This
2062         will give an early signal that a change has broken the documentation.
2063
2064 2014-05-05  Pratik Solanki  <psolanki@apple.com>
2065
2066         Update framework locations in package-root
2067         https://bugs.webkit.org/show_bug.cgi?id=132571
2068
2069         Reviewed by Simon Fraser.
2070
2071         * Scripts/package-root:
2072
2073 2014-05-05  Ryuan Choi  <ryuan.choi@samsung.com>
2074
2075         [EFL][WK2] Refactor favicon database APIs
2076         https://bugs.webkit.org/show_bug.cgi?id=132519
2077
2078         Reviewed by Gyuyoung Kim.
2079
2080         * MiniBrowser/efl/main.c: Use ewk_favicon_database_icon_get instead of ewk_view_favicon_get.
2081         (update_view_favicon):
2082         (on_icon_changed_cb):
2083         (window_free):
2084         (on_url_changed):
2085         (window_create):
2086         (on_view_favicon_changed): Deleted.
2087
2088 2014-05-02  Mark Rowe  <mrowe@apple.com>
2089
2090         <https://webkit.org/b/132505> Make it possible to tell copy-webkitlibraries-to-product-directory which OS X version to copy for
2091
2092         Reviewed by Dan Bernstein.
2093
2094         * Scripts/copy-webkitlibraries-to-product-directory: Add an --osx-version argument and use the passed value
2095         when determining which LLVM archive to extract.
2096
2097 2014-05-02  Jeremy Jones  <jeremyj@apple.com>
2098
2099         Add Jeremy as a committer.
2100         https://bugs.webkit.org/show_bug.cgi?id=132492
2101
2102         Reviewed by Jer Noble.
2103
2104         Add myself as a committer.
2105
2106         * Scripts/webkitpy/common/config/contributors.json:
2107
2108 2014-05-02  Jeremy Jones  <jeremyj@apple.com>
2109
2110         Add Jeremy as a committer.
2111         https://bugs.webkit.org/show_bug.cgi?id=132492
2112
2113         Reviewed by Jer Noble.
2114
2115         Add Jeremy Jones to the committers file.
2116
2117         * Scripts/webkitpy/common/config/contributors.json:
2118
2119 2014-05-02  Brian J. Burg  <burg@cs.washington.edu>
2120
2121         Hard to figure out how to run a single test with run-api-tests
2122         https://bugs.webkit.org/show_bug.cgi?id=116332
2123
2124         Reviewed by Alexey Proskuryakov.
2125
2126         * Scripts/run-api-tests: add two examples to the help message.
2127
2128 2014-05-02  Simon Fraser  <simon.fraser@apple.com>
2129
2130         Fix several memory leaks found by code inspection
2131         https://bugs.webkit.org/show_bug.cgi?id=132472
2132
2133         Reviewed by Geoffrey Garen.
2134         
2135         Fix memory leaks.
2136
2137         * TestWebKitAPI/Tests/mac/WillSendSubmitEvent.mm:
2138         (TestWebKitAPI::TEST):
2139         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2140         (WTR::InjectedBundlePage::willSendRequestForFrame):
2141         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2142         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
2143
2144 2014-05-02  Filip Pizlo  <fpizlo@apple.com>
2145
2146         DFGAbstractInterpreter should not claim Int52 arithmetic creates Int52s
2147         https://bugs.webkit.org/show_bug.cgi?id=132446
2148
2149         Reviewed by Mark Hahnenberg.
2150         
2151         Test the FTL by default now that it's enabled by default.
2152
2153         * Scripts/run-javascriptcore-tests:
2154
2155 2014-05-01  Ryuan Choi  <ryuan.choi@samsung.com>
2156
2157         [EFL][WK1] Drop ewk_view_setting_tiled_backingstore APIs
2158         https://bugs.webkit.org/show_bug.cgi?id=132240
2159
2160         Reviewed by Anders Carlsson.
2161
2162         Removed ewk_view_setting_tiled_backingstore related code.
2163
2164         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2165         (DumpRenderTreeChrome::createView):
2166         (shouldUseTiledBackingStore): Deleted.
2167         * EWebLauncher/main.c:
2168         (windowCreate):
2169         (parseUserArguments):
2170
2171 2014-05-01  Anders Carlsson  <andersca@apple.com>
2172
2173         window.testRunner.keepWebHistory() should update the UI process state
2174         https://bugs.webkit.org/show_bug.cgi?id=132440
2175
2176         Reviewed by Dan Bernstein.
2177
2178         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2179         (WTR::InjectedBundle::postSetAddsVisitedLinks):
2180         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2181         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2182         (WTR::TestRunner::keepWebHistory):
2183         * WebKitTestRunner/TestInvocation.cpp:
2184         (WTR::TestInvocation::invoke):
2185         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2186
2187 2014-05-01  David Kilzer  <ddkilzer@apple.com>
2188
2189         Really remove ENABLE_PLUGIN_PROXY_FOR_VIDEO
2190         <http://webkit.org/b/132432>
2191
2192         Reviewed by Tim Horton.
2193
2194         * Scripts/webkitperl/FeatureList.pm: Remove support for
2195         --plugin-proxy-for-video switch.
2196
2197 2014-04-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2198
2199         Kernel sysctl interface hw.activecpu don't exists on Linux.
2200         https://bugs.webkit.org/show_bug.cgi?id=132286
2201
2202         Reviewed by Filip Pizlo.
2203
2204         * Scripts/run-jsc-stress-tests: Redirect stderr to null when
2205         calling sysctl over hw.activecpu
2206
2207 2014-04-30  Anders Carlsson  <andersca@apple.com>
2208
2209         Move the legacy WebKit API into WebKitLegacy.framework and move it inside WebKit.framework
2210         https://bugs.webkit.org/show_bug.cgi?id=132399
2211         <rdar://problem/15920046>
2212
2213         Reviewed by Dan Bernstein.
2214
2215         * Scripts/check-for-webkit-framework-include-consistency:
2216         Allos WAK headers in WebKitLegacy as well as WebKit.
2217
2218         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2219         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
2220         Update header imports.
2221
2222 2014-04-30  Simon Fraser  <simon.fraser@apple.com>
2223
2224         [iOS WK2] Add test URL to crash reports for the UI process, clean up project
2225         https://bugs.webkit.org/show_bug.cgi?id=131954
2226
2227         Reviewed by Darin Adler.
2228         
2229         WebKitTestRunner was adding application-specific information to crash reports
2230         to log the test path, but only in the web process. Fix it to also do this
2231         for the UI process, for both iOS and OS X.
2232         
2233         Moved InjectedBundlePageMac.mm to InjectedBundlePageCocoa.mm and compile it for
2234         both iOS and OS X.
2235         
2236         Factored crash reprorter-related code into CrashReporterInfo, and call it from
2237         a new TestController::platformWillRunTest() function on Mac and iOS.
2238         
2239         Also remove Xcode-added unit test junk from the project.
2240
2241         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm: Copied from Tools/WebKitTestRunner/InjectedBundle/ios/InjectedBundlePageIOS.mm.
2242         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
2243         * WebKitTestRunner/TestController.cpp:
2244         (WTR::TestController::runTest):
2245         * WebKitTestRunner/TestController.h:
2246         * WebKitTestRunner/TestInvocation.cpp:
2247         (WTR::TestInvocation::url):
2248         * WebKitTestRunner/TestInvocation.h:
2249         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2250         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests-Info.plist: Removed.
2251         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests.m: Removed.
2252         * WebKitTestRunner/WebKitTestRunnerAppTests/en.lproj/InfoPlist.strings: Removed.
2253         * WebKitTestRunner/cocoa/CrashReporterInfo.h: Renamed from Tools/WebKitTestRunner/InjectedBundle/ios/InjectedBundlePageIOS.mm.
2254         * WebKitTestRunner/cocoa/CrashReporterInfo.mm: Renamed from Tools/WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm.
2255         (WTR::testPathFromURL):
2256         (WTR::setCrashReportApplicationSpecificInformationToURL):
2257         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2258         (WTR::TestController::platformWillRunTest):
2259         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2260         (WTR::TestController::platformWillRunTest):
2261         * WebKitTestRunner/ios/TestControllerIOS.mm:
2262         (WTR::TestController::platformWillRunTest):
2263         (WTR::TestController::setHidden):
2264         * WebKitTestRunner/mac/TestControllerMac.mm:
2265         (WTR::TestController::platformWillRunTest):
2266
2267 2014-04-30  Simon Fraser  <simon.fraser@apple.com>
2268
2269         Fix DRT assertion about mock scrollbars, which doesn't apply to iOS.
2270
2271         Reviewed by Tim Horton.
2272
2273         * DumpRenderTree/mac/DumpRenderTree.mm:
2274         (resetWebPreferencesToConsistentValues):
2275         (prepareConsistentTestingEnvironment):
2276
2277 2014-04-30  Anders Carlsson  <andersca@apple.com>
2278
2279         check-for-inappropriate-macros-in-external-headers should get the product name, not the project name
2280         https://bugs.webkit.org/show_bug.cgi?id=132397
2281
2282         Reviewed by Dan Bernstein.
2283
2284         * Scripts/check-for-inappropriate-macros-in-external-headers:
2285
2286 2014-04-29  Martin Robinson  <mrobinson@igalia.com>
2287
2288         [GTK] Make it easier to run CMake for downstreams
2289         https://bugs.webkit.org/show_bug.cgi?id=132370
2290
2291         Reviewed by Carlos Garcia Campos.
2292
2293         * Scripts/webkitdirs.pm:
2294         (generateBuildSystemFromCMakeProject): Pass -DDEVELOPER_MODE when building
2295         the GTK+ port.
2296
2297 2014-04-29  Stephanie Lewis  <slewis@apple.com>
2298
2299         <rdar://problem/16765765> Use JSON::PP in perl scripts instead of JSON.
2300         
2301         Rubber stamped by Jessie Berlin.
2302
2303         JSON.pm was removed from our tools setup.
2304
2305         * Scripts/generate-coverage-data:
2306
2307 2014-04-29  Filip Pizlo  <fpizlo@apple.com>
2308
2309         Use LLVM as a backend for the fourth-tier DFG JIT (a.k.a. the FTL JIT)
2310         https://bugs.webkit.org/show_bug.cgi?id=112840
2311
2312         Rubber stamped by Geoffrey Garen.
2313
2314         * Scripts/build-jsc: Enable it on Mac.
2315         * Scripts/build-webkit: Enable it on Mac.
2316         * Scripts/export-llvm-build: Make it slightly easier to export the build if you've done a "make install".
2317
2318 2014-04-28  Sam Weinig  <sam@webkit.org>
2319
2320         REGRESSION (r167751): svn-create-patch is very slow
2321         https://bugs.webkit.org/show_bug.cgi?id=132300
2322
2323         Reviewed by Alexey Proskuryakov.
2324
2325         * Scripts/svn-create-patch:
2326         Change default behavior of svn-create-patch to no longer run the style checker. It can still be run
2327         by calling `svn-create-patch --style`.
2328
2329 2014-04-29  Enrique Ocaña González  <eocanha@igalia.com>
2330
2331         Generate Eclipse project + ninja build for GTK+ if Eclipse in available in the PATH
2332         https://bugs.webkit.org/show_bug.cgi?id=132190
2333
2334         Reviewed by Gustavo Noronha Silva.
2335
2336         * Scripts/webkitdirs.pm:
2337         (canUseEclipse): Test if Eclipse is in the path. This is the same method used to test
2338             if ninja is in the path.
2339         (generateBuildSystemFromCMakeProject): Use the eclipse generator if possible, fallback
2340             to the previous ninja generator if not.
2341
2342 2014-04-29  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
2343
2344         check-webkit-style should understand --git-index
2345         https://bugs.webkit.org/show_bug.cgi?id=125364
2346
2347         Reviewed by Csaba Osztrogonác.
2348
2349         * Scripts/webkitpy/common/checkout/scm/git.py:
2350         (Git.create_patch): The command now supports the --cached option.
2351         * Scripts/webkitpy/style/main.py:
2352         (CheckWebKitStyle.main): Passing the --git-index option.
2353         * Scripts/webkitpy/style/optparser.py:
2354         (CommandOptionValues.__init__): The git-index option is switched off by default.
2355         (CommandOptionValues.__eq__): Equality check for the new option.
2356         (ArgumentParser._create_option_parser):Adding the --git-index option
2357         (ArgumentParser.parse):
2358         * Scripts/webkitpy/style/optparser_unittest.py: New tests for the --git-index option
2359         (CommandOptionValuesTest.test_init): 
2360         (CommandOptionValuesTest.test_eq):
2361
2362 2014-04-28  Michael Saboff  <msaboff@apple.com>
2363
2364         Crash in platform/mac/accessibility/table-visible-rows.html
2365         https://bugs.webkit.org/show_bug.cgi?id=132146
2366
2367         Reviewed by Filip Pizlo.
2368
2369         Instead of creating a local JSValueRef array on the stack and passing that to
2370         JSObjectMakeArray(), changed to create an empty JSArray and then populate the
2371         values using the JSObjectSetPropertyAtIndex() API.
2372
2373         * DumpRenderTree/AccessibilityUIElement.cpp:
2374         (elementsForRangeCallback):
2375         (convertElementsToObjectArray):
2376         * DumpRenderTree/mac/TestRunnerMac.mm:
2377         (originsArrayToJS):
2378         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2379         (WTR::EventSendingController::contextClick):
2380         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2381         (WTR::stringArrayToJS):
2382         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2383         (WTR::convertElementsToObjectArray):
2384
2385 2014-04-28  Filip Pizlo  <fpizlo@apple.com>
2386
2387         Make sure that the coverage of our tests doesn't change much if we change the thresholds now and in the future, but making
2388         "no-cjit" runs force the old-school threshold.
2389
2390         Rubber stamped by Mark Hahnenberg.
2391
2392         * Scripts/run-jsc-stress-tests:
2393
2394 2014-04-28  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2395
2396         [GTK] install-dependencies should also install ruby-json and ruby-highline
2397         https://bugs.webkit.org/show_bug.cgi?id=132292
2398
2399         Reviewed by Philippe Normand.
2400
2401         * gtk/install-dependencies: Install ruby json and highline packages.
2402
2403 2014-04-27  Joonghun Park  <jh718.park@samsung.com>
2404
2405         [EFL] Remove indexedDB's dependency on leveldb and disable indexedDB
2406         https://bugs.webkit.org/show_bug.cgi?id=132176
2407
2408         Reviewed by Gyuyoung Kim.
2409
2410         EFL port will use sqlite to support indexedDB. So, this patch removes levelDB dependency
2411         and turn off indexedDB feature until the sqlite implementation is introduced.
2412
2413         * Scripts/webkitperl/FeatureList.pm:
2414
2415 2014-04-25  James Craig  <jcraig@apple.com>
2416
2417         Set prepare-Changelog flag so that it no longer runs check-webkit-style by default
2418         https://bugs.webkit.org/show_bug.cgi?id=132209
2419
2420         Reviewed by Daniel Bates.
2421
2422         Set default to --no-style to avoid additional spew from false positives in check-webkit-style.
2423         Run check-webkit-style before generating changelogs to avoid additional spurious errors.
2424
2425         * Scripts/prepare-ChangeLog:
2426         (main): 
2427
2428 2014-04-25  Michael Saboff  <msaboff@apple.com>
2429
2430         Crash in platform/mac/accessibility/table-visible-rows.html
2431         https://bugs.webkit.org/show_bug.cgi?id=132146
2432
2433         Reviewed by Mark Lam.
2434
2435         Changed to use a local JSValueRef array temporary instead of a
2436         std::make_unique<JSValueRef[]> when making an array of JSValues so that the temporary
2437         JSValues are visited during garbage collection when the stack is scanned.  Otherwise,
2438         the temporary values could be collected.
2439
2440         * DumpRenderTree/AccessibilityUIElement.cpp:
2441         (convertElementsToObjectArray):
2442         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2443         (WTR::EventSendingController::contextClick):
2444         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2445         (WTR::convertElementsToObjectArray):
2446
2447 2014-04-24  Eduardo Lima Mitev  <elima@igalia.com>
2448
2449         Unreviewed GTK gardening
2450
2451         * Scripts/run-gtk-tests: Skips one flaky accesibility test in WK2API suite
2452         (TestRunner):
2453
2454 2014-04-24  László Langó  <llango.u-szeged@partner.samsung.com>
2455
2456         prepare-ChangeLog reports as deleted methods that has not been removed.
2457         https://bugs.webkit.org/show_bug.cgi?id=131733
2458
2459         Reviewed by Ryosuke Niwa.
2460
2461         * Scripts/prepare-ChangeLog:
2462         (originalFile): Set merge base to origin/master by default.
2463
2464 2014-04-23  James Craig  <jcraig@apple.com>
2465
2466         prepare-Changelog and svn-create-patch should optionally run check-webkit-style.
2467         https://bugs.webkit.org/show_bug.cgi?id=131115
2468
2469         Reviewed by Daniel Bates.
2470
2471         Added [--[no-]style] param to run check-webkit-style as part of prepare-Changelog and svn-create-patch.
2472
2473         * Scripts/commit-log-editor: Added --no-style.
2474         * Scripts/prepare-ChangeLog: Primary patch.
2475         (main): Primary patch.
2476         (createPatchCommand): Added --no-style.
2477         * Scripts/svn-create-patch: Primary patch.
2478         * Scripts/webkit-tools-completion.sh: Added --style and --no-style.
2479         * Scripts/webkitpy/common/checkout/scm/svn.py: Added --no-style.
2480         (SVN.create_patch): Added --no-style.
2481
2482 2014-04-23  Anders Carlsson  <andersca@apple.com>
2483
2484         Try to fix iOS build.
2485
2486         * DumpRenderTree/mac/DumpRenderTree.mm:
2487
2488 2014-04-23  Alexey Proskuryakov  <ap@apple.com>
2489
2490         Eliminate internals.setMockScrollbarsEnabled()
2491         https://bugs.webkit.org/show_bug.cgi?id=132085
2492
2493         Reviewed by Tim Horton.
2494
2495         * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebPreferencesToConsistentValues):
2496         No need to reset the preference, there is no way it can change.
2497
2498 2014-04-23  James Craig  <jcraig@apple.com>
2499
2500         Unreviewed. Moving myself from Contributors to Committers list.
2501
2502         * Scripts/webkitpy/common/config/contributors.json:
2503
2504 2014-04-23  Tim Horton  <timothy_horton@apple.com>
2505
2506         Mock scrollbars don't always work in DumpRenderTree
2507         https://bugs.webkit.org/show_bug.cgi?id=132082
2508
2509         Reviewed by Alexey Proskuryakov.
2510
2511         * DumpRenderTree/mac/DumpRenderTree.mm:
2512         (prepareConsistentTestingEnvironment):
2513         Set the mock scrollbar setting before creating the WebView, as this setting
2514         cannot be dynamically changed, so any scrollbars that are created during
2515         WebView initialization and are not replaced before snapshotting will end
2516         up being platform scrollbars instead of mock ones.
2517         WebKitTestRunner already sets this preference before creating WKViews,
2518         so we're just matching its behavior.
2519
2520 2014-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2521
2522         [GTK] ShadowRoot API was removed in r164131
2523         https://bugs.webkit.org/show_bug.cgi?id=132059
2524
2525         Reviewed by Gustavo Noronha Silva.
2526
2527         Add WebKitDOMShadowRoot to the list of deleted classes to generate
2528         the API docs.
2529
2530         * gtk/webkitdom.py:
2531         (WebKitDOMDocGenerator):
2532
2533 2014-04-23  Lorenzo Tilve  <ltilve@igalia.com>
2534
2535         [GTK] run-webkit-tests script is failing to invoke run-launcher
2536         https://bugs.webkit.org/show_bug.cgi?id=132051
2537
2538         Reviewed by Philippe Normand.
2539
2540         After the WK1 support was dropped, if run-webkit-tests is executed
2541         without --no-show-results parameter, the launcher is being called
2542         using a -2 parameter that is it causing the run-launcher to break.
2543
2544         * Scripts/webkitpy/port/gtk.py:
2545         (GtkPort.show_results_html_file):
2546
2547 2014-04-22  Tim Horton  <timothy_horton@apple.com>
2548
2549         DumpRenderTree generates black snapshots on some platforms
2550         https://bugs.webkit.org/show_bug.cgi?id=132029
2551         <rdar://problem/16679363>
2552
2553         Reviewed by Simon Fraser.
2554
2555         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2556         (createBitmapContextFromWebView):
2557         DRT checks with the WebView to determine whether it can use the window's
2558         backing store directly or (because of compositing) needs to take a WindowServer
2559         snapshot. However, on some platforms and in some situations, the window can
2560         be layer backed without the WebView necessarily currently being composited.
2561         We should check with the window in addition to the WebView before going
2562         ahead and using its backing store.
2563
2564 2014-04-22  Tim Horton  <timothy_horton@apple.com>
2565
2566         DumpRenderTree generates white snapshots on some platforms
2567         https://bugs.webkit.org/show_bug.cgi?id=132026
2568         <rdar://problem/16679363>
2569
2570         Reviewed by Simon Fraser.
2571
2572         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2573         Link DRT against QuartzCore.
2574
2575         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2576         (createBitmapContextFromWebView):
2577         Force CoreAnimation to synchronously update layers in a more explicit
2578         way that doesn't depend on AppKit behavior. This is very similar to what
2579         WebKitTestRunner does (indirectly) during its force repaint.
2580
2581 2014-04-22  Brent Fulgham  <bfulgham@apple.com>
2582
2583         [Win] Support Python 2.7 in Cygwin
2584         https://bugs.webkit.org/show_bug.cgi?id=132023
2585
2586         Reviewed by Michael Saboff.
2587
2588         * Scripts/webkitdirs.pm:
2589         (checkInstalledTools): Remove check for Python 2.7, since
2590         it now works properly.
2591
2592 2014-04-22  Filip Pizlo  <fpizlo@apple.com>
2593
2594         Switch the LLVMForJSC target to using the LLVM in /usr/local rather than /usr/local/LLVMForJavaScriptCore on iOS
2595         https://bugs.webkit.org/show_bug.cgi?id=130867
2596         <rdar://problem/16432456> 
2597
2598         Reviewed by Mark Hahnenberg.
2599
2600         * Scripts/build-webkit:
2601         * Scripts/copy-webkitlibraries-to-product-directory:
2602
2603 2014-04-22  Gustavo Noronha Silva  <gns@gnome.org>
2604
2605         [GTK] Fails to build documentation when output is redirected
2606         https://bugs.webkit.org/show_bug.cgi?id=131178
2607
2608         Reviewed by Martin Robinson.
2609
2610         * gtk/generate-gtkdoc: set the output for stdout and stderr to UTF-8
2611         explicitly to avoid encoding issues when they are redirected.
2612
2613 2014-04-22  ChangSeok Oh  <changseok.oh@collabora.com>
2614
2615         [GTK] YCM choose a newer compile_commands.json in between Release or Debug
2616         https://bugs.webkit.org/show_bug.cgi?id=131911
2617
2618         Reviewed by Martin Robinson.
2619
2620         common.get_build_path returns release path even though Debug configuration
2621         is newer than Release. So YouCompleteMe is used to refer old build setup inadvertently.
2622
2623         * gtk/ycm_extra_conf.py:
2624         (get_build_path): Compare modified time of Release and Debug. And return a recent modified path.
2625         (FlagsForFile):
2626
2627 2014-04-21  Brent Fulgham  <bfulgham@apple.com>
2628
2629         Unreviewed build fix.
2630
2631         * DumpRenderTree/mac/EventSendingController.mm:
2632         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
2633         Correct a typo that prevented tests from working properly.
2634
2635 2014-04-21  Martin Robinson  <mrobinson@igalia.com>
2636
2637         [GTK] Should have the ability to output composited contents during layout testing
2638         https://bugs.webkit.org/show_bug.cgi?id=131864
2639
2640         Reviewed by Philippe Normand.
2641
2642         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
2643         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Add a path that paints the widget contents
2644         to an image surface. We run the main loop a bit to match the implementation from WebKit1 and EFL.
2645         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2646         (WTR::PlatformWebView::windowSnapshotImage): Use the new UI-process path on GTK+.
2647
2648 2014-04-21  Sam Weinig  <sam@webkit.org>
2649
2650         Attempt to fix the tests.
2651
2652         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
2653         (-[DidFailProvisionalNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2654         Add policy handler to override the new default of denying loads that NSURLConnection cannot handle.
2655
2656 2014-04-21  Filip Pizlo  <fpizlo@apple.com>
2657
2658         Unreviewed test gardening, make no-eager runs run everything except eager (as opposed to
2659         being the same as a "quick run", which is meant for genuinely slow tests).
2660
2661         * Scripts/run-jsc-stress-tests:
2662
2663 2014-04-21  Darin Adler  <darin@apple.com>
2664
2665         Add HashSet::takeAny
2666         https://bugs.webkit.org/show_bug.cgi?id=131928
2667
2668         Reviewed by Benjamin Poulain.
2669
2670         * TestWebKitAPI/Tests/WTF/HashSet.cpp: Added a test for takeAny.
2671
2672 2014-04-20  Dan Bernstein  <mitz@apple.com>
2673
2674         Fixed a test timing out after r167572.
2675
2676         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
2677         (-[NavigationDelegate webView:didFinishNavigation:]): Renamed from
2678         -webView:didFinishLoadingNavigation:.
2679
2680 2014-04-20  Commit Queue  <commit-queue@webkit.org>
2681
2682         Unreviewed, rolling out r167510.
2683         https://bugs.webkit.org/show_bug.cgi?id=131915
2684
2685         broke GTK Debug bot (Requested by philn on #webkit).
2686
2687         Reverted changeset:
2688
2689         "[GTK] Add llvmpipe (Mesa) to the JHBuild moduleset and force
2690         it when running layout tests"
2691         https://bugs.webkit.org/show_bug.cgi?id=131472
2692         http://trac.webkit.org/changeset/167510
2693
2694 2014-04-18  Martin Robinson  <mrobinson@igalia.com>
2695
2696         [GTK] Add llvmpipe (Mesa) to the JHBuild moduleset and force it when running layout tests
2697         https://bugs.webkit.org/show_bug.cgi?id=131472
2698
2699         Reviewed by Philippe Normand.
2700
2701         * Scripts/webkitpy/port/gtk.py:
2702         (GtkPort.setup_environ_for_server): Use the LLVMPIPE_LIBGL_PATH to set the LD_LIBRARY_PATH
2703         when running WebKitTestRunner with run-webkit-tests.
2704         * gtk/jhbuild.modules: Add Mesa to the modulelist so that the llvmpipe libGL is build, but not
2705         installed.
2706         * gtk/jhbuildrc: Set the LLVMPIPE_LIBGL_PATH environment variable so that the test driver knows
2707         how to properly set the LD_LIBRARY_PATH variable. We do this because it is much easier to
2708         calculate the path in the jhbuildrc than in the test driver code. This simplifies things a great
2709         deal.
2710
2711 2014-04-18  Alexey Proskuryakov  <ap@apple.com>
2712
2713         DownloadDecideDestinationCrash API test uses an incorrect value for path
2714         https://bugs.webkit.org/show_bug.cgi?id=131845
2715         <rdar://problem/15925560>
2716
2717         Reviewed by Enrica Casucci.
2718
2719         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
2720         (TestWebKitAPI::decideDestinationWithSuggestedFilename):
2721
2722 2014-04-17  Alexey Proskuryakov  <ap@apple.com>
2723
2724         [Mac] AttributedStringTest API tests fail with async text input
2725         https://bugs.webkit.org/show_bug.cgi?id=131833
2726
2727         Reviewed by Enrica Casucci.
2728
2729         Don't run sync NSTextInputClient tests where we don't implement these calls.
2730
2731         * TestWebKitAPI/Tests/mac/AttributedString.mm:
2732         (TestWebKitAPI::AttributedStringTest_CustomFont::didLoadURL):
2733         (TestWebKitAPI::AttributedStringTest_CustomFont::runSyncTest):
2734         (TestWebKitAPI::AttributedStringTest_Strikethrough::didLoadURL):
2735         (TestWebKitAPI::AttributedStringTest_Strikethrough::runSyncTest):
2736         (TestWebKitAPI::AttributedStringTest_CustomFont::runTest): Deleted.
2737         (TestWebKitAPI::AttributedStringTest_Strikethrough::runTest): Deleted.
2738
2739 2014-04-18  Philippe Normand  <pnormand@igalia.com>
2740
2741         Remove NETWORK_INFO support
2742         https://bugs.webkit.org/show_bug.cgi?id=131841
2743
2744         Reviewed by Gyuyoung Kim.
2745
2746         * Scripts/webkitperl/FeatureList.pm:
2747
2748 2014-04-17  ChangSeok Oh  <changseok.oh@collabora.com>
2749
2750         [GTK] YouCompleteMe doesn't work for cmake build system.
2751         https://bugs.webkit.org/show_bug.cgi?id=131591
2752
2753         Reviewed by Martin Robinson.
2754
2755         Add cmake build system support for YouCompleteMe. It should work regardless of
2756         using make or ninja. In addition, autotools related code is removed since it's
2757         not used anymore in WebKit.
2758
2759         * Scripts/webkitdirs.pm:
2760         (generateBuildSystemFromCMakeProject):
2761         * gtk/ycm_extra_conf.py:
2762         (transform_relative_paths_to_absolute_paths):
2763         (FlagsForFile):
2764
2765 2014-04-17  Anders Carlsson  <andersca@apple.com>
2766
2767         Fix build.
2768
2769         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2770         (-[DownloadNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2771         (-[ConvertResponseToDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2772
2773 2014-04-17  Anders Carlsson  <andersca@apple.com>
2774
2775         Remove unused API enums
2776         https://bugs.webkit.org/show_bug.cgi?id=131836
2777
2778         Reviewed by Tim Horton.
2779
2780         * MiniBrowser/mac/WK2BrowserWindowController.m:
2781         (-[WK2BrowserWindowController webView:decidePolicyForNavigationResponse:decisionHandler:]):
2782
2783 2014-04-16  Brent Fulgham  <bfulgham@apple.com>
2784
2785         [Win] A few final cleanups to the DataObject classes.
2786         https://bugs.webkit.org/show_bug.cgi?id=131784
2787
2788         Reviewed by Anders Carlsson.
2789
2790         * DumpRenderTree/win/DRTDataObject.cpp:
2791         (DRTDataObject::clearData): Use 'last()' method.
2792         * DumpRenderTree/win/UIDelegate.cpp:
2793         (DRTUndoStack::pop): Use 'takeLast()' method.
2794
2795 2014-04-17  Andres Gomez  <agomez@igalia.com>
2796
2797         [Win] cygwin to keep installing curl 7.33.0-1 and subversion 1.7.14-1
2798         https://bugs.webkit.org/show_bug.cgi?id=131365
2799
2800         Reviewed by Brent Fulgham.
2801
2802         The cygwin installer is now downloading the wanted versions for
2803         the local installation given to the setup wizard.
2804
2805         * CygwinDownloader/cygwin-downloader.py:
2806         * CygwinDownloader/cygwin-downloader.zip:
2807
2808 2014-04-17  Adrian Perez de Castro  <aperez@igalia.com>
2809
2810         [GTK] Make run-webkit-tests always use WKTR
2811         https://bugs.webkit.org/show_bug.cgi?id=131737
2812
2813         Reviewed by Darin Adler.
2814
2815         Now that the GTK+ port only has support for WebKit2, instruct
2816         run-webkit-tests to always use WKTR. This avoids needing to pass
2817         flag "-2" every time.
2818
2819         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 
2820         (_set_up_derived_options): Always set webkit_test_runner when
2821         the platform is GTK+.
2822
2823 2014-04-17  Brendan Long  <b.long@cablelabs.com>
2824
2825         [Gtk] Install ninja-build in Tools/gtk/install-dependencies
2826         https://bugs.webkit.org/show_bug.cgi?id=131760
2827
2828         Reviewed by Philippe Normand.
2829
2830         * gtk/install-dependencies: Install ninja-build when it's available.
2831
2832 2014-04-16  peavo@outlook.com  <peavo@outlook.com>
2833
2834         [Win] run-javascriptcore-tests fails to run.
2835         https://bugs.webkit.org/show_bug.cgi?id=131761
2836
2837         Reviewed by Brent Fulgham.
2838
2839         * Scripts/build-jsc: For now, don't try to build bmalloc on Windows.
2840
2841 2014-04-16  Andres Gomez  <agomez@igalia.com>
2842
2843         [Win] Pass default parameters to cygwin setup wizard
2844         https://bugs.webkit.org/show_bug.cgi?id=131361
2845
2846         Reviewed by Brent Fulgham.
2847
2848         Added some parameters to the cygwin setup wizard so the user
2849         doesn't really have to do any interaction.
2850
2851         * CygwinDownloader/cygwin-downloader.py:
2852         * CygwinDownloader/cygwin-downloader.zip:
2853
2854 2014-04-15  Brent Fulgham  <bfulgham@apple.com>
2855
2856         [Win] Eliminate use of deleteAllValues in Windows Files
2857         https://bugs.webkit.org/show_bug.cgi?id=131631
2858
2859         Reviewed by Darin Adler.
2860
2861         Switch to std::unique_ptr for memory lifetime. Get rid of
2862         deleteAllValues now that it is no longer needed. Use ranged
2863         for loops where possible.
2864
2865         * DumpRenderTree/win/DRTDataObject.cpp:
2866         (WCEnumFormatEtc::WCEnumFormatEtc):
2867         (DRTDataObject::~DRTDataObject):
2868         (DRTDataObject::GetData):
2869         (DRTDataObject::QueryGetData):
2870         (DRTDataObject::SetData):
2871         (DRTDataObject::clearData):
2872         * DumpRenderTree/win/DRTDataObject.h:
2873         * DumpRenderTree/win/UIDelegate.cpp:
2874         (DRTUndoObject::DRTUndoObject):
2875         (DRTUndoObject::~DRTUndoObject):
2876         (DRTUndoStack::~DRTUndoStack):
2877         (DRTUndoStack::clear):
2878         (DRTUndoStack::pop):
2879         (DRTUndoManager::DRTUndoManager):
2880         (DRTUndoManager::redo):
2881         (DRTUndoManager::undo):
2882         (UIDelegate::UIDelegate):
2883         (UIDelegate::resetUndoManager):
2884         * DumpRenderTree/win/UIDelegate.h:
2885
2886 2014-04-16  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2887
2888         [GTK] Unreviewed GTK gardening.
2889
2890         Update list of skipped unit tests:
2891
2892           Skip test: WebKit2Gtk/TestWebKitWebView:/webkit2/WebKitWebView/page-visibility
2893
2894           Unskip tests: WebKit2/TestWebKit2:WebKit2.ResizeReversePaginatedWebView
2895           and WebKit2/TestWebKit2:WebKit2.ScrollPinningBehaviors
2896
2897         * Scripts/run-gtk-tests:
2898         (TestRunner):
2899
2900 2014-04-16  Tim Horton  <timothy_horton@apple.com>
2901
2902         check-webkit-style doesn't check code style in .mm or .m files
2903         https://bugs.webkit.org/show_bug.cgi?id=131708
2904
2905         Reviewed by Darin Adler.
2906
2907         * Scripts/webkitpy/style/checker.py:
2908         * Scripts/webkitpy/style/checker_unittest.py:
2909         (CheckerDispatcherDispatchTest.test_cpp_paths):
2910         (CheckerDispatcherDispatchTest.test_text_paths):
2911         Check .mm and .m files as C++.
2912
2913         * Scripts/webkitpy/style/checkers/cpp.py:
2914         (check_spacing):
2915         Add an override for our ordinary "missing spaces around =" for @synthesize,
2916         which should look like "@synthesize propertyName=_varName;"
2917
2918         Add an override for "missing space before {" for blocks' "^{".
2919
2920         Don't follow the "extra space before [" rule for Objective-C, because
2921         it breaks this rule in a multitude of ways because of method calls.
2922
2923         (check_braces):
2924         Don't complain about { not being on the end of the previous line if
2925         the previous line starts with "- (" or "+ (", which would indicate a
2926         Objective-C method definition.
2927
2928 2014-04-16  Darin Adler  <darin@apple.com>
2929
2930         Make Vector::takeLast work with move-only types (and optimize for types where move is faster)
2931         https://bugs.webkit.org/show_bug.cgi?id=131735
2932
2933         Reviewed by Alexey Proskuryakov.
2934
2935         * TestWebKitAPI/Tests/WTF/Vector.cpp: Added a test for Vector::takeLast with move only types.
2936         Fixed invocations of EXPECT macros so the expected value is on the left, and the test result
2937         is on the right. This can be confusing since our JavaScript test framework does it the opposite
2938         way, but gtest works better this way.
2939
2940 2014-04-15  Hyowon Kim  <hw1008.kim@samsung.com>
2941
2942         [EFL] Fix problems with the pixel dump.
2943         https://bugs.webkit.org/show_bug.cgi?id=131265
2944
2945         Reviewed by Gyuyoung Kim.
2946
2947         Painting and compositing paths of WebKit-EFL were totally modified from r166768.
2948         However pixel dump codes still call deprecated functions like ewk_view_paint(),
2949         which causes that nothing is drawn.
2950
2951         This patch adds new member functions to AcceleratedCompositingContext to support pixel dump.
2952         One of new functions is AcceleratedCompositingContext::extractImageData(),
2953         which replaces deprecated function calls. Besides the extractImageData() is invoked by
2954         ewk_view_screenshot_contents_get() in order to take the visible content displayed on the EFL webview.
2955
2956         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
2957         (createBitmapContextFromWebView): Add to call DumpRenderTreeSupportEfl::forcePaint().
2958
2959 2014-04-15  Filip Pizlo  <fpizlo@apple.com>
2960
2961         Update LLVM export scrpt to handle the build directory being different from the
2962         source directory.
2963
2964         Rubber stamped by Geoffrey Garen.
2965
2966         * Scripts/export-llvm-build:
2967
2968 2014-04-15  Ryosuke Niwa  <rniwa@webkit.org>
2969
2970         Update the hyperlink to waterfall views of perf bots on build.webkit.org
2971         https://bugs.webkit.org/show_bug.cgi?id=131695
2972
2973         Reviewed by Antti Koivisto.
2974
2975         Updated.
2976
2977         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2978
2979 2014-04-15  Carlos Garcia Campos  <cgarcia@igalia.com>
2980
2981         [GTK] Reduce the binary size by compressing the text based web inspector resources
2982         https://bugs.webkit.org/show_bug.cgi?id=121545
2983
2984         Reviewed by Gustavo Noronha Silva.
2985
2986         Compress text based files when compiling inspector resources. It
2987         reduces the binary size in 3MB.
2988
2989         * gtk/generate-inspector-gresource-manifest.py:
2990         (find_all_files_in_directory):
2991         (is_compressible):
2992
2993 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
2994
2995         Remove Gtk WebKit1 tester.
2996
2997         Gtk WebKit1 port no longer exists, and dashboard was trying to load its tester
2998         results over and over as fast as it could.
2999
3000         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3001         (WebKitBuildbot):
3002
3003 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
3004
3005         Wrong link for webkitpy tests results in dashboard popover
3006         https://bugs.webkit.org/show_bug.cgi?id=131664
3007
3008         Reviewed by Timothy Hatcher.
3009
3010         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3011         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds):
3012         Use a correct link.
3013
3014 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
3015
3016         Update webkitpy regression test result that started to fail after http://trac.webkit.org/r167243
3017
3018         I'm not sure whether the changes are desirable, but am not suspicious enough to roll out.
3019
3020         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3021         (CommitMessageForThisCommitTest):
3022
3023 2014-04-14  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
3024
3025         Fix commit-log-editor bug revealed by r165447
3026         https://bugs.webkit.org/show_bug.cgi?id=130676
3027
3028         Reviewed by Csaba Osztrogonác.
3029
3030         * Scripts/commit-log-editor:
3031         (createCommitMessage): Omitting empty Source/JavaScriptCore:... blocks.
3032         Add \n before the first block too, because the longest common prefix now ends with only one newline.
3033         (removeLongestCommonPrefixEndingInNewline): The longest common prefix ends with only one newline,
3034         now the last block of the common prefix isn't duplicated below. Changing the function name accordingly.
3035
3036 2014-04-13  Darin Adler  <darin@apple.com>
3037
3038         userVisibleString should not try to "encode" host names
3039         https://bugs.webkit.org/show_bug.cgi?id=131587
3040         rdar://problem/14686849
3041
3042         Reviewed by Alexey Proskuryakov.
3043
3044         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added URLExtras.mm.
3045
3046         * TestWebKitAPI/Tests/mac/URLExtras.mm: Added. A few tests for WebCoreNSURLExtras.
3047         Coverage is tiny at this point; we could add a lot more cases!
3048
3049 2014-04-13  Jaehun Lim  <ljaehun.lim@samsung.com>
3050
3051         Use #include instead of #import
3052         https://bugs.webkit.org/show_bug.cgi?id=131604
3053
3054         Reviewed by Darin Adler.
3055
3056         Fix "warning: #import is a deprecated GCC extension [-Wdeprecated]".
3057
3058         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3059
3060 2014-04-12  Filip Pizlo  <fpizlo@apple.com>
3061
3062         Make slow-stress tests run faster by running fewer VM variants.
3063
3064         Rubber stamped by Geoffrey Garen.
3065
3066         * Scripts/run-javascriptcore-tests:
3067         * Scripts/run-jsc-stress-tests:
3068
3069 2014-04-10  Zan Dobersek  <zdobersek@igalia.com>
3070
3071         [CMake] Add missing WTF unit tests
3072         https://bugs.webkit.org/show_bug.cgi?id=131459
3073
3074         Reviewed by Martin Robinson.
3075
3076         * TestWebKitAPI/CMakeLists.txt: Add a few missing source files
3077         that should be compiled into the TestWTF binary.
3078
3079 2014-04-10  Brendan Long  <b.long@cablelabs.com>
3080
3081         [Gtk] run-launcher doesn't work by default
3082         https://bugs.webkit.org/show_bug.cgi?id=131494
3083
3084         Reviewed by Philippe Normand.
3085
3086         * Scripts/run-launcher: Always use MiniBrowser for WebKitGTK.
3087         * Scripts/webkitdirs.pm:
3088         (launcherName): Same.
3089         * Scripts/webkitpy/style/checker.py: Remove reference to GtkLauncher.
3090         * gtk/common.py:
3091         (get_build_path.is_valid_build_directory): Same.
3092         * gtk/manifest.txt: Same.
3093
3094 2014-04-09  Commit Queue  <commit-queue@webkit.org>
3095
3096         Unreviewed, rolling out r167046.
3097         https://bugs.webkit.org/show_bug.cgi?id=131479
3098
3099         Caused 300+ failures on Mavericks WK1 tester (Requested by ap
3100         on #webkit).
3101
3102         Reverted changeset:
3103
3104         "Remove "System Font" from whitelisted DRT fonts and char
3105         width calculations"
3106         https://bugs.webkit.org/show_bug.cgi?id=131411
3107         http://trac.webkit.org/changeset/167046
3108
3109 2014-04-09  Myles C. Maxfield  <mmaxfield@apple.com>
3110
3111         Remove "System Font" from whitelisted DRT fonts and char width calculations
3112         https://bugs.webkit.org/show_bug.cgi?id=131411
3113
3114         Reviewed by Tim Horton.
3115
3116         Covered by existing tests.
3117
3118         * DumpRenderTree/mac/DumpRenderTree.mm:
3119         (allowedFontFamilySet):
3120
3121 2014-04-09  Myles C. Maxfield  <mmaxfield@apple.com>
3122
3123         systemHiddenFontFamilySet in DRT is unnecessary
3124         https://bugs.webkit.org/show_bug.cgi?id=131414
3125
3126         Reviewed by Tim Horton.
3127
3128         It doesn't seem to affect test results on my machine.
3129
3130         * DumpRenderTree/mac/DumpRenderTree.mm:
3131         (drt_NSFontManager_availableFonts):
3132         (systemHiddenFontFamilySet): Deleted.
3133
3134 2014-04-09  Brent Fulgham  <bfulgham@apple.com>
3135
3136         [Win] Unreviewed test fix: Don't double-release BSTR.
3137
3138         * DumpRenderTree/win/DumpRenderTree.cpp:
3139         (dump): Remove unneeded call to SysFreeString now that we are
3140         using _bstr_t for this variable.
3141
3142 2014-04-09  Brent Fulgham  <bfulgham@apple.com>
3143
3144         [Win] Various DumpRenderTree Fixes.
3145         https://bugs.webkit.org/show_bug.cgi?id=131446.
3146
3147         Reviewed by Tim Horton.
3148
3149         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3150         (AccessibilityUIElement::title): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3151         (AccessibilityUIElement::description): Ditto.
3152         (AccessibilityUIElement::helpText): Ditto.
3153         (AccessibilityUIElement::intValue): Ditto.
3154         (AccessibilityUIElement::isPressActionSupported): Ditto.
3155         (AccessibilityUIElement::accessibilityValue): Ditto.
3156         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
3157         (DRTDesktopNotificationPresenter::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
3158         (DRTDesktopNotificationPresenter::AddRef): Ditto.
3159         (DRTDesktopNotificationPresenter::Release): Ditto.
3160         (DRTDesktopNotificationPresenter::showDesktopNotification): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3161         (DRTDesktopNotificationPresenter::cancelDesktopNotification): Ditto.
3162         (DRTDesktopNotificationPresenter::notificationDestroyed): Ditto.
3163         (DRTDesktopNotificationPresenter::checkNotificationPermission): Ditto.
3164         (DRTDesktopNotificationPresenter::requestNotificationPermission): Ditto.
3165         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
3166         * DumpRenderTree/win/DumpRenderTree.cpp:
3167         (dumpFrameScrollPosition): Ditto.
3168         (dumpFramesAsText): Ditto.
3169         (compareHistoryItems): Ditto.
3170         (dumpHistoryItem): Ditto.
3171         (dump): Ditto.
3172         (resetDefaultsToConsistentValues): Ditto.
3173         (resetWebViewToConsistentStateBeforeTesting): Ditto.
3174         (runTest): Ditto.
3175         (createWebViewAndOffscreenWindow): Ditto.
3176         * DumpRenderTree/win/EditingDelegate.cpp:
3177         (EditingDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
3178         (EditingDelegate::AddRef): Ditto.
3179         (EditingDelegate::Release): Ditto.
3180         (dumpPath): Switch to _bstr_t. Use JSStringCreateWithBSTR
3181         (EditingDelegate::shouldBeginEditingInDOMRange): Get rid of uneeded STDMETHODCALLTYPE declaration.
3182         (EditingDelegate::shouldEndEditingInDOMRange): Ditto.
3183         (EditingDelegate::shouldInsertNode): Ditto.
3184         (EditingDelegate::shouldInsertText): Ditto.
3185         (EditingDelegate::shouldDeleteDOMRange): Ditto.
3186         (EditingDelegate::shouldChangeSelectedDOMRange): Ditto.
3187         (EditingDelegate::shouldApplyStyle): Ditto.
3188         (EditingDelegate::shouldChangeTypingStyle): Ditto.
3189         (EditingDelegate::doPlatformCommand): Ditto.
3190         (EditingDelegate::webViewDidBeginEditing): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3191         (EditingDelegate::webViewDidChange): Ditto.
3192         (EditingDelegate::webViewDidEndEditing): Ditto.
3193         (EditingDelegate::webViewDidChangeTypingStyle): Ditto.
3194         (EditingDelegate::webViewDidChangeSelection): Ditto.
3195         (EditingDelegate::checkSpellingOfString): Ditto.
3196         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3197         (descriptionSuitableForTestResult): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3198         (FrameLoadDelegate::FrameLoadDelegate): Ditto.
3199         (FrameLoadDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
3200         (FrameLoadDelegate::AddRef): Ditto.
3201         (FrameLoadDelegate::Release): Ditto.
3202         (FrameLoadDelegate::didStartProvisionalLoadForFrame): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3203         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame): Ditto.
3204         (FrameLoadDelegate::didFailProvisionalLoadWithError): Ditto.
3205         (FrameLoadDelegate::didCommitLoadForFrame): Ditto.
3206         (FrameLoadDelegate::didReceiveTitle): Ditto.
3207         (FrameLoadDelegate::didChangeIcons): Ditto.
3208         (delegatesWithDelayedWork): Ditto.
3209         (FrameLoadDelegate::didFinishLoadForFrame): Ditto.
3210         (FrameLoadDelegate::didFailLoadWithError): Ditto.
3211         (FrameLoadDelegate::willPerformClientRedirectToURL): Ditto.
3212         (FrameLoadDelegate::didCancelClientRedirectForFrame): Ditto.
3213         (FrameLoadDelegate::willCloseFrame): Ditto.
3214         (FrameLoadDelegate::didFinishDocumentLoadForFrame): Ditto.
3215         (FrameLoadDelegate::didHandleOnloadEventsForFrame): Ditto.
3216         (FrameLoadDelegate::didFirstVisuallyNonEmptyLayoutInFrame): Ditto.
3217         (FrameLoadDelegate::didDisplayInsecureContent): Ditto.
3218         (FrameLoadDelegate::didRunInsecureContent): Ditto.
3219         * DumpRenderTree/win/FrameLoadDelegate.h:
3220         * DumpRenderTree/win/HistoryDelegate.cpp:
3221         (HistoryDelegate::didNavigateWithNavigationData): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3222         (HistoryDelegate::updateHistoryTitle): Ditto.
3223         (HistoryDelegate::populateVisitedLinksForWebView): Ditto.
3224         * DumpRenderTree/win/PolicyDelegate.cpp:
3225         (dumpPath):
3226         (PolicyDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
3227         (PolicyDelegate::AddRef): Ditto.
3228         (PolicyDelegate::Release): Ditto.
3229         (PolicyDelegate::decidePolicyForNavigationAction): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3230         (PolicyDelegate::unableToImplementPolicyWithError): Ditto.
3231         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3232         (ResourceLoadDelegate::descriptionSuitableForTestResult): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3233         (ResourceLoadDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
3234         (ResourceLoadDelegate::AddRef): Ditto.
3235         (ResourceLoadDelegate::Release): Ditto.
3236         (ResourceLoadDelegate::identifierForInitialRequest): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3237         (ResourceLoadDelegate::removeIdentifierForRequest): Ditto.
3238         (ResourceLoadDelegate::willSendRequest): Ditto.
3239         (ResourceLoadDelegate::didReceiveAuthenticationChallenge): Ditto.
3240         (ResourceLoadDelegate::didReceiveResponse): Ditto.
3241         (ResourceLoadDelegate::didFinishLoadingFromDataSource): Ditto.
3242         (ResourceLoadDelegate::didFailLoadingWithError): Ditto.
3243         * DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
3244         (TestRunner::queueLoad): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3245         (TestRunner::setUserStyleSheetLocation): Ditto.
3246         (TestRunner::execCommand): Ditto.
3247         (TestRunner::overridePreference): Ditto.
3248         (TestRunner::evaluateScriptInIsolatedWorld): Ditto.
3249         * DumpRenderTree/win/TextInputControllerWin.cpp: Ditto.
3250         (TextInputController::setMarkedText): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3251         (TextInputController::insertText): Ditto.
3252         * DumpRenderTree/win/UIDelegate.cpp:
3253         (UIDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
3254         (UIDelegate::AddRef): Ditto.
3255         (UIDelegate::Release): Ditto.
3256         (UIDelegate::hasCustomMenuImplementation): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3257         (UIDelegate::trackCustomPopupMenu): Ditto.
3258         (UIDelegate::registerUndoWithTarget): Ditto.
3259         (UIDelegate::removeAllActionsWithTarget): Ditto.
3260         (UIDelegate::setActionTitle): Ditto.
3261         (UIDelegate::undo): Ditto.
3262         (UIDelegate::redo): Ditto.
3263         (UIDelegate::canUndo): Ditto.
3264         (UIDelegate::canRedo): Ditto.
3265         (UIDelegate::printFrame): Ditto.
3266         (UIDelegate::ftpDirectoryTemplatePath): Ditto.
3267         (UIDelegate::webViewHeaderHeight): Ditto.
3268         (UIDelegate::webViewFooterHeight): Ditto.
3269         (UIDelegate::drawHeaderInRect): Ditto.
3270         (UIDelegate::drawFooterInRect): Ditto.
3271         (UIDelegate::webViewPrintingMarginRect): Ditto.
3272         (UIDelegate::canRunModal): Ditto.
3273         (UIDelegate::createModalDialog): Ditto.
3274         (UIDelegate::runModal): Ditto.
3275         (UIDelegate::isMenuBarVisible): Ditto.
3276         (UIDelegate::setMenuBarVisible): Ditto.
3277         (UIDelegate::runDatabaseSizeLimitPrompt): Ditto.
3278         (UIDelegate::paintCustomScrollbar): Ditto.
3279         (UIDelegate::paintCustomScrollCorner): Ditto.
3280         (UIDelegate::setFrame): Ditto.
3281         (UIDelegate::webViewFrame): Ditto.
3282         (UIDelegate::runJavaScriptAlertPanelWithMessage): Ditto.
3283         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Ditto.
3284         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Ditto.
3285         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage): Ditto.
3286         (UIDelegate::webViewAddMessageToConsole): Ditto.
3287         (UIDelegate::doDragDrop): Ditto.
3288         (UIDelegate::webViewGetDlgCode): Ditto.
3289         (UIDelegate::createWebViewWithRequest): Ditto.
3290         (UIDelegate::webViewClose): Ditto.
3291         (UIDelegate::webViewFocus): Ditto.
3292         (UIDelegate::webViewUnfocus): Ditto.
3293         (UIDelegate::webViewPainted): Ditto.
3294         (UIDelegate::exceededDatabaseQuota): Ditto.
3295         (UIDelegate::embeddedViewWithArguments): Ditto.
3296         (UIDelegate::webViewClosing): Ditto.
3297         (UIDelegate::webViewSetCursor): Ditto.
3298         (UIDelegate::webViewDidInvalidate): Ditto.
3299         (UIDelegate::setStatusText): Ditto.
3300         (UIDelegate::desktopNotificationsDelegate): Ditto.
3301         (UIDelegate::drawBackground): Ditto.
3302         (UIDelegate::decidePolicyForGeolocationRequest): Ditto.
3303         (UIDelegate::didPressMissingPluginButton): Ditto.
3304         * DumpRenderTree/win/WorkQueueItemWin.cpp: Ditto.
3305         (LoadItem::invoke):  Switch to _bstr_t. Use JSStringCreateWithBSTR.
3306         (LoadHTMLStringItem::invoke): Ditto.
3307         (ScriptItem::invoke): Ditto.
3308
3309 2014-04-09  Gergo Balogh  <gbalogh.u-szeged@partner.samsung.com>
3310
3311         Stylechecker: False positive on inline asm code.
3312         https://bugs.webkit.org/show_bug.cgi?id=130570
3313
3314         Reviewed by Csaba Osztrogonác.
3315
3316         Disable stylechecking in asm blocks.
3317
3318         * Scripts/webkitpy/style/checkers/cpp.py:
3319         (process_line):
3320         (_InlineASMState):
3321         (_InlineASMState.__init__):
3322         (_InlineASMState.process_line):
3323         (_InlineASMState.isInside):
3324         (_process_lines):
3325         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3326         (WebKitStyleTest.test_member_initialization_list):
3327
3328 2014-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
3329
3330         [GTK] Move WebKit1 unit tests resources used by WebKit2 unit tests to WebKit2 resources dir
3331         https://bugs.webkit.org/show_bug.cgi?id=131029
3332
3333         Reviewed by Philippe Normand.
3334
3335         Add blank.ico and test.pdf to resources dir of WebKit2Gtk unit
3336         tests and remove the getWebKit1TestResoucesDir() method.
3337
3338         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
3339         (testDownloadLocalFile): Use Test::getResourcesDir().
3340         (testDownloadLocalFileError): Ditto.
3341         (serverCallback): Ditto.
3342         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
3343         (serverCallback): Ditto.
3344         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
3345         (httpServerCallback): Ditto.
3346         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
3347         (serverCallback): Ditto.
3348         * TestWebKitAPI/Tests/WebKit2Gtk/resources/blank.ico: Added.
3349         * TestWebKitAPI/Tests/WebKit2Gtk/resources/test.pdf: Added.
3350         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
3351         (Test::getWebKit1TestResoucesDir): Deleted.
3352
3353 2014-04-09  Alexey Proskuryakov  <ap@apple.com>
3354
3355         [WK2] HTTP authentication regression tests fail
3356         https://bugs.webkit.org/show_bug.cgi?id=81627
3357         <rdar://problem/11079296>
3358
3359         Reviewed by Anders Carlsson.
3360
3361         * WebKitTestRunner/TestController.h:
3362         * WebKitTestRunner/TestController.cpp:
3363         (WTR::TestController::createWebViewWithOptions): Added canAuthenticateAgainstProtectionSpaceInFrame
3364         to pageLoaderClient structure.
3365         (WTR::TestController::canAuthenticateAgainstProtectionSpaceInFrame): Return true
3366         for password based authentication (we do get server trust challenges on some tests,
3367         which WKTR can't handle).
3368         When this client call is not implemented or returns false, didReceiveAuthenticationChallengeInFrame
3369         calls won't be made, at least on CFNetwork based platforms.
3370         (WTR::TestController::didReceiveAuthenticationChallengeInFrame): Changed the output
3371         to omit <unknown>. The resource is always unknown with WK2, and it doesn't really
3372         make sense to associate auth requests with individual resources - there can be
3373         multiple resources loading at once from the same protection space, so WebKit1 API
3374         that had a resource identifier was inherently racy.
3375
3376 2014-04-09  Ryuan Choi  <ryuan.choi@samsung.com>
3377
3378         [EFL] Change font path for DumpRenderTree and WebKitTestRunner
3379         https://bugs.webkit.org/show_bug.cgi?id=131427
3380
3381         Reviewed by Gyuyoung Kim.
3382
3383         Since r166973, font path was changed.
3384
3385         * DumpRenderTree/PlatformEfl.cmake:
3386         * WebKitTestRunner/PlatformEfl.cmake:
3387
3388 2014-04-08  Geoffrey Garen  <ggaren@apple.com>
3389
3390         Fix the build-jsc build
3391         https://bugs.webkit.org/show_bug.cgi?id=131410
3392
3393         Reviewed by Michael Saboff.
3394
3395         * Scripts/build-jsc: Make sure to build bmalloc before WTF, since
3396         WTF depends on it.
3397
3398 2014-04-08  Martin Robinson  <mrobinson@igalia.com>
3399
3400         [GTK] Remove WebKit1 unit tests
3401         https://bugs.webkit.org/show_bug.cgi?id=131359
3402
3403         Reviewed by Anders Carlsson.
3404
3405         Remove all WebKit1 GTK+ unit tests, in preparation for removing the WebKit1 port
3406         entirely. We also remove the list of skipped WebKi1 tests from run-gtk-tests, as
3407         they were inadvertently left in http://trac.webkit.org/changeset/166504.
3408
3409         * CMakeLists.txt: No longer load the WebKit1 unit test CMakeLists.txt file.
3410         * Scripts/run-gtk-tests: Remove skipped WebKit1 unit tests.
3411         * TestWebKitAPI/Tests/WebKitGtk/CMakeLists.txt: Removed.
3412         * TestWebKitAPI/Tests/WebKitGtk/resources/blank.ico: Removed.
3413         * TestWebKitAPI/Tests/WebKitGtk/resources/test.html: Removed.
3414         * TestWebKitAPI/Tests/WebKitGtk/resources/test.ogg: Removed.
3415         * TestWebKitAPI/Tests/WebKitGtk/resources/test.pdf: Removed.
3416         * TestWebKitAPI/Tests/WebKitGtk/resources/test.txt: Removed.
3417         * TestWebKitAPI/Tests/WebKitGtk/test_utils.c: Removed.
3418         * TestWebKitAPI/Tests/WebKitGtk/test_utils.h: Removed.
3419         * TestWebKitAPI/Tests/WebKitGtk/testapplicationcache.c: Removed.
3420         * TestWebKitAPI/Tests/WebKitGtk/testatk.c: Removed.
3421         * TestWebKitAPI/Tests/WebKitGtk/testatkroles.c: Removed.
3422         * TestWebKitAPI/Tests/WebKitGtk/testcontextmenu.c: Removed.
3423         * TestWebKitAPI/Tests/WebKitGtk/testcopyandpaste.c: Removed.
3424         * TestWebKitAPI/Tests/WebKitGtk/testdomdocument.c: Removed.
3425         * TestWebKitAPI/Tests/WebKitGtk/testdomdomwindow.c: Removed.
3426         * TestWebKitAPI/Tests/WebKitGtk/testdomnode.c: Removed.
3427         * TestWebKitAPI/Tests/WebKitGtk/testdownload.c: Removed.
3428         * TestWebKitAPI/Tests/WebKitGtk/testfavicondatabase.c: Removed.
3429         * TestWebKitAPI/Tests/WebKitGtk/testglobals.c: Removed.
3430         * TestWebKitAPI/Tests/WebKitGtk/testhittestresult.c: Removed.
3431         * TestWebKitAPI/Tests/WebKitGtk/testhttpbackend.c: Removed.
3432         * TestWebKitAPI/Tests/WebKitGtk/testkeyevents.c: Removed.
3433         * TestWebKitAPI/Tests/WebKitGtk/testloading.c: Removed.
3434         * TestWebKitAPI/Tests/WebKitGtk/testmimehandling.c: Removed.
3435         * TestWebKitAPI/Tests/WebKitGtk/testnetworkrequest.c: Removed.
3436         * TestWebKitAPI/Tests/WebKitGtk/testnetworkresponse.c: Removed.
3437         * TestWebKitAPI/Tests/WebKitGtk/testwebbackforwardlist.c: Removed.
3438         * TestWebKitAPI/Tests/WebKitGtk/testwebdatasource.c: Removed.
3439         * TestWebKitAPI/Tests/WebKitGtk/testwebframe.c: Removed.
3440         * TestWebKitAPI/Tests/WebKitGtk/testwebhistoryitem.c: Removed.
3441         * TestWebKitAPI/Tests/WebKitGtk/testwebinspector.c: Removed.
3442         * TestWebKitAPI/Tests/WebKitGtk/testwebplugindatabase.c: Removed.
3443         * TestWebKitAPI/Tests/WebKitGtk/testwebresource.c: Removed.
3444         * TestWebKitAPI/Tests/WebKitGtk/testwebsettings.c: Removed.
3445         * TestWebKitAPI/Tests/WebKitGtk/testwebview.c: Removed.
3446         * TestWebKitAPI/Tests/WebKitGtk/testwindow.c: Removed.
3447
3448 2014-04-08  Brent Fulgham  <bfulgham@apple.com>
3449
3450         Unreviewed gardening (Take 2): Prevent users from attempting
3451         to build with known invalid cURL. 
3452
3453         * Scripts/webkitdirs.pm:
3454         (checkInstalledTools): Check for 7.34.0 (the broken version), not
3455         7.33.0 (the known good version).
3456
3457 2014-04-08  Martin Robinson  <mrobinson@igalia.com>
3458
3459         [GTK] Remove DumpRenderTree and GtkLauncher
3460         https://bugs.webkit.org/show_bug.cgi?id=131373
3461
3462         Reviewed by Andreas Kling.
3463
3464         Remove the GTK+ port of DumpRenderTree and GtkLauncher. These tools are
3465         no longer necessary now that WebKit1 GTK+ will be removed.
3466
3467         * CMakeLists.txt:
3468         * DumpRenderTree/PlatformGTK.cmake: Removed.
3469         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp: Removed.
3470         * DumpRenderTree/gtk/DumpRenderTree.cpp: Removed.
3471         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Removed.
3472         * DumpRenderTree/gtk/EditingCallbacks.cpp: Removed.
3473         * DumpRenderTree/gtk/EditingCallbacks.h: Removed.
3474         * DumpRenderTree/gtk/EventSender.cpp: Removed.
3475         * DumpRenderTree/gtk/EventSender.h: Removed.
3476         * DumpRenderTree/gtk/GCControllerGtk.cpp: Removed.
3477         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp: Removed.
3478         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp: Removed.
3479         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.h: Removed.
3480         * DumpRenderTree/gtk/TestRunnerGtk.cpp: Removed.
3481         * DumpRenderTree/gtk/TextInputController.cpp: Removed.
3482         * DumpRenderTree/gtk/TextInputController.h: Removed.
3483         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Removed.
3484         * GtkLauncher/CMakeLists.txt: Removed.
3485         * GtkLauncher/LauncherInspectorWindow.c: Removed.
3486         * GtkLauncher/LauncherInspectorWindow.h: Removed.
3487         * GtkLauncher/main.c: Removed.
3488         * GtkLauncher/simple.svg: Removed.
3489         * GtkLauncher/text.html: Removed.
3490         * WebKitTestRunner/PlatformGTK.cmake:
3491         * WebKitTestRunner/gtk/fonts/AHEM____.TTF: Renamed from Tools/DumpRenderTree/gtk/fonts/AHEM____.TTF.
3492         * WebKitTestRunner/gtk/fonts/FontWithNoValidEncoding.fon: Renamed from Tools/DumpRenderTree/gtk/fonts/FontWithNoValidEncoding.fon.
3493         * WebKitTestRunner/gtk/fonts/fonts.conf: Renamed from Tools/DumpRenderTree/gtk/fonts/fonts.conf.
3494
3495 2014-04-08  Mark Rowe  <mrowe@apple.com>
3496
3497         XPC services launched by Safari have wrong DYLD_FRAMEWORK_PATH set when launched via run-safari / debug-safari
3498         <https://webkit.org/b/131388> / <rdar://problem/16291687>
3499
3500         Reviewed by Alexey Proskuryakov.
3501
3502         * Scripts/webkitdirs.pm:
3503         (runMacWebKitApp): Set __XPC_DYLD_FRAMEWORK_PATH to the absolute path to the built products directory.
3504         (execMacWebKitAppForDebugging): Ditto.
3505
3506 2014-04-08  Geoffrey Garen  <ggaren@apple.com>
3507
3508         Build bmalloc on iOS too
3509         https://bugs.webkit.org/show_bug.cgi?id=131381
3510
3511         Reviewed by Andreas Kling.
3512
3513         * Scripts/build-webkit:
3514
3515 2014-04-08  Brent Fulgham  <bfulgham@apple.com>
3516
3517         Unreviewed gardening: Prevent users from attempting
3518         to build with known invalid cURL.
3519
3520         * Scripts/webkitdirs.pm:
3521         (checkInstalledTools): Block build attempts with bad
3522         Cygwin tool set.
3523
3524 2014-04-07  Geoffrey Garen  <ggaren@apple.com>
3525
3526         Build bmalloc on Mac
3527         https://bugs.webkit.org/show_bug.cgi?id=131333
3528
3529         Reviewed by Mark Rowe.
3530
3531         * Scripts/build-webkit: Add the bmalloc target if we're on Mac.
3532         (Note: Just testing Mac is not good enough because in this
3533         script 'Mac' means 'Mac or iOS'.)
3534
3535 2014-03-30  Filip Pizlo  <fpizlo@apple.com>
3536
3537         Move slow JSRegress tests out of the way so that they don't show up in run-jsc-benchmarks runs and also skip tests that are extremely long-running
3538         https://bugs.webkit.org/show_bug.cgi?id=130951
3539
3540         Reviewed by Geoffrey Garen.
3541
3542         * Scripts/run-javascriptcore-tests:
3543
3544 2014-04-06  Darin Adler  <darin@apple.com>
3545
3546         Rework CSS calc logic, fixing some reference count mistakes in Length
3547         https://bugs.webkit.org/show_bug.cgi?id=131280
3548
3549         Reviewed by Andreas Kling.
3550
3551         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added CalculationValue.cpp.
3552         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp: Added.
3553
3554 2014-04-04  Brian J. Burg  <burg@cs.washington.edu>
3555
3556         Enable WEB_REPLAY for PLATFORM(MAC)
3557         https://bugs.webkit.org/show_bug.cgi?id=130700
3558
3559         Reviewed by Timothy Hatcher.
3560
3561         * Scripts/webkitperl/FeatureList.pm: Set the default for WEB_REPLAY for OS X engineering builds.
3562
3563 2014-04-05  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3564
3565         [CMake] Include X11's include dirs in TestNetscapePlugin
3566         https://bugs.webkit.org/show_bug.cgi?id=131270
3567
3568         Reviewed by Martin Robinson.
3569
3570         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Include X11_INCLUDE_DIR since
3571         TestNetscapePlugin includes WebCore code that includes X headers.
3572
3573 2014-04-05  David Kilzer  <ddkilzer@apple.com>
3574
3575         REGRESSION (r166529): Fix build after renaming TileCache to LegacyTileCache
3576         <http://webkit.org/b/130986>
3577
3578         * Scripts/check-for-inappropriate-objc-class-names: Add 'Legacy'
3579         prefix to TileCache class names in exception list.
3580
3581 2014-04-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3582
3583         [GTK] kill-old-processes should kill dbus-daemon processes
3584         https://bugs.webkit.org/show_bug.cgi?id=127352
3585
3586         Reviewed by Martin Robinson.
3587
3588         * BuildSlaveSupport/kill-old-processes:
3589         (main):
3590
3591 2014-04-04  Andres Gomez  <agomez@igalia.com>
3592
3593         [Win] Update obsolete packages in cygwin
3594         https://bugs.webkit.org/show_bug.cgi?id=126264
3595
3596         Reviewed by Brent Fulgham.
3597
3598         Removed "apache" and "minires" as the first has been replaced by
3599         "lighttpd" and the second is now integrated into
3600         "cygwin". Replaced the transitional and now obsolete "gcc" package
3601         with "gcc-g++" and ensure that "python" stays at version "2.6.8"
3602         since the newer version available is "2.7.3" which breaks the
3603         build due to some funniness with environment variable handling.
3604
3605         * CygwinDownloader/cygwin-downloader.py:
3606         * CygwinDownloader/cygwin-downloader.zip:
3607
3608 2014-04-03  Joseph Pecoraro  <pecoraro@apple.com>
3609
3610         check-webkit-style: Improve warnings on Objective-C @property syntax
3611         https://bugs.webkit.org/show_bug.cgi?id=131200
3612
3613         Reviewed by Dan Bernstein.
3614
3615         * Scripts/webkitpy/style/checkers/cpp.py:
3616         (check_spacing):
3617         (CppChecker):
3618         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3619         (CppStyleTest.test_spacing_in_objective_c_properties):
3620
3621 2014-04-03  Santosh Mahto  <santoshbit2007@gmail.com>
3622
3623         Unreviewed. Moving my name to commiter section
3624
3625         * Scripts/webkitpy/common/config/contributors.json:
3626
3627 2014-04-03  Santosh Mahto  <santoshbit2007@gmail.com>
3628
3629         Unreviewed. Add myself as a committer.
3630
3631         * Scripts/webkitpy/common/config/contributors.json:
3632
3633 2014-04-03  Andrzej Badowski  <a.badowski@samsung.com>
3634
3635         [EFL][WK2] Replacing zoom functionality of MiniBrowser from scale_set to page_zoom_set.
3636         https://bugs.webkit.org/show_bug.cgi?id=130391
3637
3638         Reviewed by Gyuyoung Kim.
3639
3640         Change the implementation of the zoom functionality from ewk_view_scale_set
3641         to ewk_view_page_zoom_set.
3642
3643         * MiniBrowser/efl/main.c:
3644
3645 2014-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
3646
3647         [webkitpy] perf profiler does not understand --call-graph argument
3648         https://bugs.webkit.org/show_bug.cgi?id=131132
3649
3650         Reviewed by Ryosuke Niwa.
3651
3652         New versions of perf profiler have changed the argument from --call-graph to -g.
3653
3654         * Scripts/webkitpy/common/system/profiler.py:
3655         (Perf.wrapper_arguments): Use -g instead of --call-graph.
3656         * Scripts/webkitpy/port/driver_unittest.py:
3657         (DriverTest.test_profiler_as_wrapper): Update test accordingly.
3658
3659 2014-04-03  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
3660
3661         Add EFL WK2 performance bot to build.webkit.org
3662         https://bugs.webkit.org/show_bug.cgi?id=131034
3663
3664         Fix after r166707, use "Perf" instead of "perf" for consistency.
3665
3666         Reviewed by Csaba Osztrogonác.
3667
3668         * BuildSlaveSupport/build.webkit.org-config/config.json:
3669
3670 2014-04-03  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
3671
3672         Add EFL WK2 performance bot to build.webkit.org
3673         https://bugs.webkit.org/show_bug.cgi?id=131034
3674
3675         Reviewed by Csaba Osztrogonác.
3676
3677         * BuildSlaveSupport/build.webkit.org-config/config.json:
3678
3679 2014-04-02  Ryuan Choi  <ryuan.choi@samsung.com>
3680
3681         [EFL][WK1] Use Evas_Touch_Point_State instead of Ewk_Touch_Point_Type
3682         https://bugs.webkit.org/show_bug.cgi?id=131151
3683
3684         Reviewed by Gyuyoung Kim.
3685
3686         * DumpRenderTree/efl/EventSender.cpp: Replace Ewk_Touch_Point_Type to Evas_Touch_Point_State.
3687         (TouchEventInfo::TouchEventInfo):
3688         (sendTouchEvent):
3689         (addTouchPointCallback):
3690         (updateTouchPointCallback):
3691         (cancelTouchPointCallback):
3692         (releaseTouchPointCallback):
3693
3694 2014-04-02  David Kilzer  <ddkilzer@apple.com>
3695
3696         filter-build-webkit: Ignore xcodebuild warnings when compiling with newer builds of clang
3697         <http://webkit.org/b/131045>
3698
3699         Reviewed by Daniel Bates.
3700
3701         * Scripts/filter-build-webkit:
3702         (shouldIgnoreLine): Ignore DVTAssertions related to new builds
3703         of clang, plus debug data for all DVTAssertions.
3704
3705 2014-04-01  Dean Jackson  <dino@apple.com>
3706
3707         Load Media Controls js/css from bundle
3708         https://bugs.webkit.org/show_bug.cgi?id=131086
3709
3710         Reviewed by Eric Carlson.
3711
3712         We're now putting CSS files into the bundle, so remove the test for them.
3713
3714         * Scripts/check-for-inappropriate-files-in-framework:
3715
3716 2014-04-02  Martin Hock  <mhock@apple.com>
3717
3718         Unify private browsing with sessions.
3719         https://bugs.webkit.org/show_bug.cgi?id=130099
3720
3721         Reviewed by Alexey Proskuryakov.
3722
3723         Add an API test for ephemeral sessions similar to PrivateBrowsingPushStateNoHistoryCallback.
3724         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3725         * TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp:
3726         (TestWebKitAPI::didNavigateWithNavigationData):
3727         (TestWebKitAPI::didSameDocumentNavigationForFrame):
3728         (TestWebKitAPI::TEST):
3729
3730         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp: Also test to make sure private browsing can be disabled.
3731         (TestWebKitAPI::didNavigateWithoutNavigationData):
3732         (TestWebKitAPI::didNavigateWithNavigationData):
3733         (TestWebKitAPI::didSameDocumentNavigationForFrame):
3734         (TestWebKitAPI::TEST):
3735
3736 2014-04-02  Martin Robinson  <mrobinson@igalia.com>
3737
3738         REGRESSION(r165704): [GTK] Inspector resources not correctly generated
3739         https://bugs.webkit.org/show_bug.cgi?id=130343
3740
3741         Reviewed by Gustavo Noronha Silva.
3742
3743         * gtk/generate-inspector-gresource-manifest.py: Instead of hard-coding the file list, accept a list
3744         of directories on the command line and look for all appropriate files in those directories for the
3745         GResource archive. Also make archive paths relative to those directories.
3746         (find_all_files_in_directory): This helper looks for all the appropriate files in a given directory.
3747         (find_all_files_in_directory.select_file): Whether or not to add the file to the archive.
3748
3749 2014-04-02  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3750
3751         [webkitpy] Avoid multiple "Preparing rollout for bug" log messages
3752         https://bugs.webkit.org/show_bug.cgi?id=131106
3753
3754         Reviewed by Csaba Osztrogonác.
3755
3756         * Scripts/webkitpy/tool/commands/download.py:
3757         (AbstractRolloutPrepCommand._prepare_state):
3758         * Scripts/webkitpy/tool/commands/download_unittest.py:
3759         (test_prepare_rollout):
3760         (test_create_rollout):
3761         (test_create_rollout_resolved):
3762         (test_rollout):
3763
3764 2014-04-02  Krzysztof Wolanski  <k.wolanski@samsung.com>
3765
3766         [EFL] Add option to use separate web process for new window in MiniBrowser
3767         https://bugs.webkit.org/show_bug.cgi?id=130190
3768
3769         Reviewed by Gyuyoung Kim.
3770
3771         New created window (CTRL + n) will be open in separated web process.
3772         This option is enabled by adding a flag (S/separate-process) with launching
3773         MiniBrowser.
3774
3775         * MiniBrowser/efl/main.c:
3776         (elm_main):
3777
3778 2014-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
3779
3780         [GTK] Move NEWS file to a new location
3781         https://bugs.webkit.org/show_bug.cgi?id=130901
3782
3783         Reviewed by Brent Fulgham.
3784
3785         * gtk/manifest.txt: Update the NEWS file path.
3786
3787 2014-04-01  Anders Carlsson  <andersca@apple.com>
3788
3789         Fix build.
3790
3791         * MiniBrowser/mac/WK2BrowserWindowController.m:
3792         (-[WK2BrowserWindowController awakeFromNib]):
3793         (-[WK2BrowserWindowController dealloc]):
3794         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
3795
3796 2014-04-01  Brent Fulgham  <bfulgham@apple.com>
3797
3798         Unreviewed test gardening.
3799
3800         * Scripts/webkitpy/port/base_unittest.py:
3801         (PortTest.test_build_path): Handle the Debug case so we don't get webkitpy-test failures on our test bots.
3802
3803 2014-04-01  Zoltan Horvath  <zoltan@webkit.org>
3804
3805         [CSS Exclusions] Remove exclusions parsing support
3806         https://bugs.webkit.org/show_bug.cgi?id=131046
3807
3808         Reviewed by David Hyatt.
3809
3810         * Scripts/webkitperl/FeatureList.pm:
3811
3812 2014-04-01  Manuel Rego Casasnovas  <rego@igalia.com>
3813
3814         [GTK] Remove last reference to GTK+ WK1 EWS
3815         https://bugs.webkit.org/show_bug.cgi?id=131058
3816
3817         Reviewed by Martin Robinson.
3818
3819         In r166427 WK1 GTK+ bots and EWS where removed, but this file was missing.
3820
3821         * QueueStatusServer/config/queues.py: Remove reference to GTK+ WK1 EWS.
3822
3823 2014-04-01  Lucas Forschler  <lforschler@apple.com>
3824
3825         Add a 32bit JSC builder/tester.
3826         https://bugs.webkit.org/show_bug.cgi?id=131054
3827         
3828         Reviewed by Michael Saboff.
3829
3830         * BuildSlaveSupport/build.webkit.org-config/config.json:
3831         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3832         (Compile32bitJSC):
3833         (Run32bitJSCTests):
3834         (Run32bitJSCTests.countFailures):
3835         (BuildAndTest32bitJSCFactory):
3836         (BuildAndTest32bitJSCFactory.__init__):
3837
3838 2014-04-01  Martin Robinson  <mrobinson@igalia.com>
3839
3840         [GTK] No longer build WebKit1 gtkdoc
3841         https://bugs.webkit.org/show_bug.cgi?id=130970
3842
3843         Reviewed by Anders Carlsson.
3844
3845         * gtk/common.py:
3846         (gtk_version_of_pkg_config_file): Deleted.
3847         * gtk/generate-gtkdoc:
3848         (get_gtkdoc_module_paths): We no longer need to worry about GTK+ 2, since it
3849         was only applicable for WebKit1.
3850         (get_generator_for_config): No longer look for the WebKit1 configuration file.
3851
3852 2014-04-01  Mario Sanchez Prada  <mario.prada@samsung.com>
3853
3854         [GTK] Running minibrowser with url crashes in debug build
3855         https://bugs.webkit.org/show_bug.cgi?id=130492
3856
3857         Reviewed by Martin Robinson.
3858
3859         Update "uri-scheme" test not to use invalid URIs in it, so we
3860         don't get a mistmatch when comparing the original URI stored in
3861         the test class with the one returned by the WebKitWebView.
3862
3863         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
3864         (testWebContextURIScheme): Update the test.
3865
3866 2014-04-01  Mihai Tica  <mitica@adobe.com>
3867
3868         Unreviewed: Add myself as a commiter to the contributors list.
3869
3870         * Scripts/webkitpy/common/config/contributors.json:
3871
3872 2014-03-31  Ryuan Choi  <ryuan.choi@samsung.com>
3873
3874         [EFL][WK2] Extract the control of page background out of color_set
3875         https://bugs.webkit.org/show_bug.cgi?id=127539
3876
3877         Reviewed by Gyuyoung Kim.
3878
3879         Added an option(C) to change background color.
3880
3881         * MiniBrowser/efl/main.c:
3882         (window_create):
3883         (elm_main):
3884
3885 2014-03-31  Ryuan Choi  <ryuan.choi@samsung.com>
3886
3887         Unreviewed build fix on the EFL port with latest EFL libraries since r166149
3888
3889         * ImageDiff/PlatformEfl.cmake: Added ECORE_IMF_INCLUDE_DIRS to include dirs
3890
3891 2014-03-31  Brent Fulgham  <bfulgham@apple.com>
3892
3893         Unreviewed test correction after r166530.
3894
3895         * DumpRenderTree/mac/DumpRenderTree.mm:
3896         (setDefaultsToConsistentValuesForTesting): No need to change preference for all tests. We set the proper
3897         fine-grained setting for swipe tests. This prevents existing tests from breaking.
3898
3899 2014-03-31  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3900
3901         Remove the trigger for webkit1 tests on the gtk-linux-64-release bot
3902         https://bugs.webkit.org/show_bug.cgi?id=130987
3903
3904         r166427 removed the WebKit1 GTK+ bots, so we don't longer need to
3905         trigger the webkit1 bot tests on the gtk-linux-64-release bot.
3906
3907         Reviewed by Martin Robinson.
3908
3909         * BuildSlaveSupport/build.webkit.org-config/config.json:
3910
3911 2014-03-31  Dean Jackson  <dino@apple.com>
3912
3913         Remove WEB_ANIMATIONS
3914         https://bugs.webkit.org/show_bug.cgi?id=130989
3915
3916         Reviewed by Simon Fraser.
3917
3918         Remove this feature flag until we plan to implement.
3919
3920         * Scripts/webkitperl/FeatureList.pm:
3921
3922 2014-03-31  Brent Fulgham  <bfulgham@apple.com>
3923
3924         Reduced Latched Scroll Test Flakiness
3925         https://bugs.webkit.org/show_bug.cgi?id=130983
3926
3927         Reviewed by Darin Adler.
3928
3929         * DumpRenderTree/mac/DumpRenderTree.mm:
3930         (setDefaultsToConsistentValuesForTesting): Test user should have 'high resolution' scrolling.
3931         * DumpRenderTree/mac/EventSendingController.mm:
3932         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]): Generate mouse wheel events
3933         with high resolution flags turned on.
3934         * WebKitTestRunner/mac/EventSenderProxy.mm:
3935         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases): Ditto.
3936
3937 2014-03-31  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
3938
3939         run-webkit-tests should have a --no-timeout option
3940         https://bugs.webkit.org/show_bug.cgi?id=128286
3941
3942         Reviewed by Joseph Pecoraro.
3943
3944         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3945         (Worker._run_test): Renaming _run_test_with_timeout()
3946         (Worker._run_test_with_or_without_timeout): Renaming _run_test_with_timeout(), because tests can now run without timeout.
3947         (Worker._run_test_in_another_thread): Passing the --no-timeout option to the driver
3948         (Worker._run_test_in_this_thread):
3949         (Worker._run_test_with_timeout): Deleted.
3950         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3951         (parse_args): Added the --no-timeout option
3952
3953 2014-03-31  Samuel White  <samuel_white@apple.com>
3954
3955         AX: Need ability to get line range for text marker.
3956         https://bugs.webkit.org/show_bug.cgi?id=130906
3957
3958         Reviewed by Chris Fleizach.
3959
3960         Added a new function in DRT and TestRunner to test that AXLineTextMarkerRangeForTextMarker works as expected.
3961
3962         * DumpRenderTree/AccessibilityUIElement.cpp:
3963         (lineTextMarkerRangeForTextMarkerCallback):
3964         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
3965         (AccessibilityUIElement::getJSClass):
3966         * DumpRenderTree/AccessibilityUIElement.h:
3967         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3968         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
3969         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3970         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
3971         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3972         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3973         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3974         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
3975         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3976         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
3977         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3978         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
3979
3980 2014-03-31  Filip Pizlo  <fpizlo@apple.com>
3981
3982         More validation for FTL inline caches
3983         https://bugs.webkit.org/show_bug.cgi?id=130948
3984
3985         Reviewed by Geoffrey Garen.
3986
3987         * Scripts/run-jsc-stress-tests:
3988
3989 2014-03-31  Carlos Garcia Campos  <cgarcia@igalia.com>
3990
3991         [GTK] Do not run WebKit1 unit tests by default
3992         https://bugs.webkit.org/show_bug.cgi?id=130968
3993
3994         Reviewed by Martin Robinson.
3995
3996         * Scripts/run-gtk-tests:
3997         (TestRunner):
3998
3999 2014-03-31  Martin Robinson  <mrobinson@igalia.com>
4000
4001         [GTK] Remove scripts code only applicable to autotools
4002         https://bugs.webkit.org/show_bug.cgi?id=130841
4003
4004         Reviewed by Anders Carlsson.
4005
4006         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
4007         (_should_file_trigger_build): Update file list to reflect GTK+ CMake port.
4008         * Scripts/webkitpy/common/config/watchlist: Remove the GTK+ build watchlist.
4009         * Scripts/webkitpy/style/checker.py: The GNUmakefile doesn't exist any longer.
4010         * gtk/find-make-dist-errors: Removed.
4011         * gtk/generate-feature-defines-files: Removed.
4012         * gtk/manifest.txt: No longer need to consider autotools files.
4013
4014 2014-03-30  Andy Estes  <aestes@apple.com>
4015
4016         Fix two failing layout tests on Mountain Lion after r166466.
4017
4018         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
4019         (-[DownloadDelegate _downloadDidStart:]):
4020
4021 2014-03-30  Andy Estes  <aestes@apple.com>
4022
4023         [Cocoa] Add an originatingWebView property to _WKDownload
4024         https://bugs.webkit.org/show_bug.cgi?id=130945
4025
4026         Reviewed by Anders Carlsson.
4027
4028         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
4029         (-[DownloadDelegate _downloadDidStart:]):
4030         (-[OriginatingWebViewDownloadDelegate initWithWebView:]):
4031         (-[OriginatingWebViewDownloadDelegate _downloadDidStart:]):
4032         (TEST):
4033
4034 2014-03-28  Filip Pizlo  <fpizlo@apple.com>
4035
4036         Land the stackmap register liveness glue with the uses of the liveness disabled
4037         https://bugs.webkit.org/show_bug.cgi?id=130924
4038
4039         Reviewed by Oliver Hunt.
4040
4041         * Scripts/run-jsc-stress-tests:
4042
4043 2014-03-29  Alexey Proskuryakov  <ap@apple.com>
4044
4045         Update WebKit1.StringTruncator for Mountain Lion.
4046
4047         * TestWebKitAPI/Tests/mac/StringTruncator.mm: Looks like one subtest was failing
4048         due to different font metrics on 10.8.
4049
4050 2014-03-28  Darin Adler  <darin@apple.com>
4051
4052         Fix recently-introduced off-by-one error in centerTruncateToBuffer
4053         https://bugs.webkit.org/show_bug.cgi?id=130889
4054
4055         Reviewed by Alexey Proskuryakov.
4056
4057         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added StringTruncator.mm.
4058         * TestWebKitAPI/Tests/mac/StringTruncator.mm: Added. One test for each of the
4059         WebStringTruncator methods; should be good for a start. These are dependent on the
4060         metrics of Helvetica 12, but I am hoping that will be consistent across OS X machines.
4061
4062 2014-03-28  Martin Hock  <mhock@apple.com>
4063
4064         Unreviewed. Add myself as a committer.
4065
4066         * Scripts/webkitpy/common/config/contributors.json:
4067
4068 2014-03-28  Martin Robinson  <mrobinson@igalia.com>
4069
4070         Remove WebKit1 GTK+ bots
4071         https://bugs.webkit.org/show_bug.cgi?id=130904
4072
4073         Reviewed by Anders Carlsson.
4074
4075         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove references to GTK+ WebKit1 test bot and ensure
4076         all bots are testing WebKit2 only.
4077         * Scripts/webkitpy/common/config/ews.json: Remove references to GTK+ WK1 EWS.
4078         * Scripts/webkitpy/common/config/ports.py: Remove references to GTK+ WK1 bots.
4079         * Scripts/webkitpy/common/config/ports_unittest.py: Ditto.
4080         * Scripts/webkitpy/port/builders.py: Ditto.
4081         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: Ditto.
4082         * TestResultServer/static-dashboards/builders.jsonp: Ditto.
4083
4084 2014-03-28  Timothy Hatcher  <timothy@apple.com>
4085
4086         Remove Brian Burg's apple.com email address.
4087
4088         * Scripts/webkitpy/common/config/contributors.json:
4089
4090 2014-03-28  David Kilzer  <ddkilzer@apple.com>
4091
4092         bisect-builds should print Trac 'changeset' URL if only one build is detected
4093         <http://webkit.org/b/130903>
4094
4095         Reviewed by Dan Bernstein.
4096
4097         * Scripts/bisect-builds:
4098         (printTracLink): Print a direct link to the Trac 'changeset'
4099         URL if there is only one revision in the range.
4100
4101 2014-03-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
4102
4103         [EFL] Bump glib version from 2.36 to 2.38 
4104         https://bugs.webkit.org/show_bug.cgi?id=130886
4105
4106         Reviewed by Csaba Osztrogonác.
4107
4108         There is a build break on EFL port when using glib 2.36 ver. To fix it,
4109         we need to bump glib version up to 2.38 as gtk port.
4110
4111         * efl/jhbuild.modules:
4112
4113 2014-03-27  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
4114
4115         <https://webkit.org/b/42704> WebKitTestRunner needs to print history delegate information
4116
4117         Provide an implementation of WKContextHistoryClient that logs when called for tests in
4118         the globalhistory directory.
4119
4120         Reviewed by Sam Weinig.
4121
4122         * WebKitTestRunner/TestController.cpp:
4123         (WTR::TestController::TestController):
4124         (WTR::TestController::initialize): Set the history client.
4125         (WTR::TestController::resetStateToConsistentValues): Disable logging of history client callbacks.
4126         (WTR::TestController::didNavigateWithNavigationData): Log information about the navigation. Some portions
4127         of the output are hard-coded to match WebKit1's results for now since they're fixed in our existing tests
4128         and we don't yet have API to access the data in question.
4129         (WTR::TestController::didPerformClientRedirect):
4130         (WTR::TestController::didPerformServerRedirect):
4131         (WTR::TestController::didUpdateHistoryTitle):
4132         * WebKitTestRunner/TestController.h:
4133         (WTR::TestController::setShouldLogHistoryClientCallbacks):
4134         * WebKitTestRunner/TestInvocation.cpp:
4135         (WTR::shouldLogHistoryClientCallbacks): Log history client callbacks for tests in a globalhistory directory.
4136         (WTR::TestInvocation::invoke):
4137
4138 2014-03-27  Filip Pizlo  <fpizlo@apple.com>
4139
4140         Revert http://trac.webkit.org/changeset/166386 because it broke builds.
4141
4142         * Scripts/build-webkit:
4143         * Scripts/copy-webkitlibraries-to-product-directory:
4144
4145 2014-03-27  Filip Pizlo  <fpizlo@apple.com>
4146
4147         Switch the LLVMForJSC target to using the LLVM in /usr/local rather than /usr/local/LLVMForJavaScriptCore on iOS
4148         https://bugs.webkit.org/show_bug.cgi?id=130867
4149         <rdar://problem/16432456> 
4150
4151         Reviewed by Mark Hahnenberg.
4152
4153         * Scripts/build-webkit:
4154         * Scripts/copy-webkitlibraries-to-product-directory:
4155
4156 2014-03-26  Andy Estes  <aestes@apple.com>
4157
4158         [Cocoa] Expose DownloadClient::didFail() and DownloadClient::didCancel()
4159         https://bugs.webkit.org/show_bug.cgi?id=130805
4160
4161         Reviewed by Dan Bernstein.
4162
4163         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
4164         (-[DownloadDelegate _download:didReceiveResponse:]):
4165         (-[DownloadDelegate _downloadDidFinish:]):
4166         (runTest):
4167         (TEST):
4168         (-[FailingDownloadDelegate _downloadDidFinish:]):
4169         (-[FailingDownloadDelegate _download:didFailWithError:]):
4170         (-[FailingDownloadDelegate _downloadDidCancel:]):
4171         (-[CancelledDownloadDelegate _downloadDidStart:]):
4172         (-[CancelledDownloadDelegate _downloadDidFinish:]):
4173         (-[CancelledDownloadDelegate _download:didFailWithError:]):
4174         (-[CancelledDownloadDelegate _downloadDidCancel:]):
4175         (-[DownloadDelegate initWithSourceURL:]): Deleted.
4176         (-[DownloadDelegate sourceURL]): Deleted.
4177         (runTestWithNavigationDelegate): Deleted.
4178
4179 2014-03-26  Anders Carlsson  <andersca@apple.com>
4180
4181         Change MiniBrowser to hold on to window controllers instead of windows
4182         https://bugs.webkit.org/show_bug.cgi?id=130797
4183
4184         Reviewed by Oliver Hunt.
4185
4186         * MiniBrowser/mac/AppDelegate.h:
4187         * MiniBrowser/mac/AppDelegate.m:
4188         (-[BrowserAppDelegate init]):
4189         (-[BrowserAppDelegate newWindow:]):
4190         (-[BrowserAppDelegate browserWindowWillClose:]):
4191         (-[BrowserAppDelegate applicationWillTerminate:]):
4192         (-[BrowserAppDelegate frontmostBrowserWindowController]):
4193
4194 2014-03-26  Commit Queue  <commit-queue@webkit.org>
4195
4196         Unreviewed, rolling out r166264.
4197         https://bugs.webkit.org/show_bug.cgi?id=130785
4198
4199         Broke some window.opener tests for WK2 Mavericks (Requested by
4200         brrian__ on #webkit).
4201
4202         Reverted changeset:
4203
4204         "Web Replay: resource unique identifiers should be unique-per-
4205         frame, not globally"
4206         https://bugs.webkit.org/show_bug.cgi?id=130632
4207         http://trac.webkit.org/changeset/166264
4208
4209 2014-03-26  Zoltan Horvath  <zoltan@webkit.org>
4210
4211         [CSS Shapes] Remove shape-inside support
4212         https://bugs.webkit.org/show_bug.cgi?id=130698
4213
4214         Reviewed by David Hyatt.
4215
4216         * Scripts/webkitperl/FeatureList.pm:
4217
4218 2014-02-27  Gurpreet Kaur  <k.gurpreet@samsung.com>
4219
4220         Unreviewed. Add myself as a committer.
4221
4222         * Scripts/webkitpy/common/config/contributors.json:
4223
4224 2014-03-26  Tomas Popela  <tpopela@redhat.com>
4225
4226         run-launcher is Perl script so use elsif and not elif
4227         https://bugs.webkit.org/show_bug.cgi?id=130771
4228
4229         Reviewed by Carlos Garcia Campos.
4230
4231         * Scripts/run-launcher:
4232
4233 2014-03-26  Krzysztof Czech  <k.czech@samsung.com>
4234
4235         [ATK] Utilize new AtkValue interface coming in ATK 2.11.92
4236         https://bugs.webkit.org/show_bug.cgi?id=130575
4237
4238         Reviewed by Mario Sanchez Prada.
4239
4240         Change ATK version to 2.11.92. Adjust current implementation.
4241
4242         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
4243         (AccessibilityUIElement::intValue):
4244         (AccessibilityUIElement::minValue):
4245         (AccessibilityUIElement::maxValue):
4246         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
4247         (WTR::AccessibilityUIElement::intValue):
4248         (WTR::AccessibilityUIElement::minValue):
4249         (WTR::AccessibilityUIElement::maxValue):
4250         * efl/jhbuild.modules:
4251         * gtk/jhbuild.modules:
4252
4253 2014-03-12  Philippe Normand  <pnormand@igalia.com>
4254
4255         [GTK] The gnumake package is no longer needed in jhbuild
4256         https://bugs.webkit.org/show_bug.cgi?id=130121
4257
4258         Reviewed by Martin Robinson.
4259
4260         For GTK build-webkit now relies on cmake and ninja/gnumake. Even
4261         for a debug build cmake/system-gnumake worked just fine for me.
4262
4263         * gtk/jhbuild.modules: Removed gnumake.
4264         * gtk/patches/make-3.82-arg-list-length.patch: Removed.
4265         * gtk/patches/make-3.82-parallel-build.patch: Removed.
4266
4267 2014-03-25  Andy Estes  <aestes@apple.com>
4268
4269         Fix a failing API test on Mountain Lion and remove temporary debug logging.
4270
4271         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
4272         (-[DownloadDelegate _download:didReceiveData:]):
4273         (-[DownloadDelegate _downloadDidFinish:]):
4274
4275 2014-03-25  Brian Burg  <bburg@apple.com>
4276
4277         Web Replay: resource unique identifiers should be unique-per-frame, not globally
4278         https://bugs.webkit.org/show_bug.cgi?id=130623
4279
4280         Reviewed by Timothy Hatcher.
4281
4282         The resource loader callback dumping routines assumed that resource identifiers
4283         were globally unique. Its map of resource identifiers to URLs must also track the
4284         frame associated with the resource.
4285
4286         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4287         (WTR::dumpResourceURL): Additionally take a WKBundleFrameRef argument, and use the
4288         opaque pointer as part of the key for assignedUrlsCache. The frame pointer is
4289         stable as long as the frame is valid.
4290         (WTR::InjectedBundlePage::didInitiateLoadForResource):
4291         (WTR::InjectedBundlePage::willSendRequestForFrame):
4292         (WTR::InjectedBundlePage::didReceiveResponseForResource):
4293         (WTR::InjectedBundlePage::didFinishLoadForResource):
4294         (WTR::InjectedBundlePage::didFailLoadForResource):
4295
4296 2014-03-25  Andy Estes  <aestes@apple.com>
4297
4298         Fix one API test expectation failure on Mountain Lion, and add additional logging to help diagnose another.
4299
4300         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
4301         (-[DownloadDelegate _download:didReceiveResponse:]):
4302         (-[DownloadDelegate _download:didReceiveData:]):
4303
4304 2014-03-25  Andy Estes  <aestes@apple.com>
4305
4306         Add some debug logging to an API test that's failing on Mountain Lion.
4307
4308         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
4309         (-[DownloadDelegate _download:didReceiveResponse:]):
4310         (-[DownloadDelegate _downloadDidFinish:]):
4311
4312 2014-03-25  Anders Carlsson  <andersca@apple.com>
4313
4314         Add goBack: and goForward: IBActions and move stopLoading: to a new WKIBActions category on WKWebView
4315         https://bugs.webkit.org/show_bug.cgi?id=130732
4316
4317         Reviewed by Tim Horton.
4318
4319         * MiniBrowser/mac/WK2BrowserWindowController.m:
4320         (-[WK2BrowserWindowController validateUserInterfaceItem:]):
4321
4322 2014-03-25  Martin Robinson  <mrobinson@igalia.com>
4323
4324         [GTK] Remove the autotools build
4325         https://bugs.webkit.org/show_bug.cgi?id=130717
4326
4327         Reviewed by Anders Carlsson.
4328
4329         * DumpRenderTree/config.h: Remove references to the autotools configure file.
4330         * GNUmakefile.am: Removed.
4331         * GtkLauncher/GNUmakefile.am: Removed.
4332         * GtkLauncher/main.c: Remove references to the autotools configure file.
4333         * MiniBrowser/gtk/BrowserDownloadsBar.c: Ditto.
4334         * MiniBrowser/gtk/BrowserSearchBar.c: Ditto.
4335         * MiniBrowser/gtk/BrowserWindow.c: Ditto.