ec569fb930511e543f811dea471c80462f7db535
[WebKit-https.git] / Tools / ChangeLog
1 2011-12-08  Csaba Osztrogonác  <ossy@webkit.org>
2
3         [Qt][WK2] Unreviewed buildfix after r102352.
4
5         * qmake/mkspecs/features/webkit2.prf:
6
7 2011-12-08  Adam Roben  <aroben@apple.com>
8
9         Make finding crash logs by PID work on Snow Leopard
10
11         Crash Reporter on Snow Leopard doesn't set the "app_description" extended attribute that we
12         were using to check the PID of the crashed process. (Crash Reporter on Lion does.) Now we
13         read the first line of the crash log and pull the PID out of there.
14
15         Fixes <http://webkit.org/b/74094> "webkit-patch crash-log <process> <PID>" doesn't work on
16         Snow Leopard
17
18         Reviewed by Darin Adler.
19
20         * Scripts/webkitpy/common/system/crashlogs.py:
21         (CrashLogs._find_newest_log_darwin): Read the first line of the crash log to get the process
22         name and PID for the log, rather than checking the Lion-only app_description extended
23         attribute. We now also reject the log if the process name doesn't match what we expect.
24
25         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
26         (make_mock_crash_report_darwin): Added. Returns a mock crash report given a process name and
27         PID.
28         (CrashLogsTest.assertLinesEqual): Added. This is a compatibility shim around
29         unittest.TestCase.assertMultiLineEqual, which didn't exist before Python 2.7.
30         (CrashLogsTest.test_find_log_darwin): Made the mock crash reports more believable by using
31         the new make_mock_crash_report_darwin function. Also added tests for files that can't be
32         read, files that actually contain a crash log for some other process, and files that are
33         misformatted.
34
35         * Scripts/webkitpy/common/system/filesystem.py: Removed FileSystem.getxattr, which is now
36         unused.
37
38         * Scripts/webkitpy/common/system/filesystem_mock.py:
39         (MockFileSystem.__init__): Removed xattr support, which is now unused.
40         (MockFileSystem.open_text_file_for_reading): Changed to actually pass the file's data to
41         ReadableTextFileObject. This function was completely broken before!
42         (ReadableBinaryFileObject.__init__): Made the data parameter non-optional to try to prevent
43         bugs like the above.
44         (ReadableTextFileObject.__init__): Added. Wraps the data in a StringIO object so we can do
45         things like readline() and seek().
46
47         (ReadableTextFileObject.close):
48         (ReadableTextFileObject.read):
49         Added. We override the superclass implementation to account for using a StringIO object.
50
51         (ReadableTextFileObject.readline):
52         (ReadableTextFileObject.seek):
53         Added. These just call through to StringIO.
54
55         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
56         (MainTest.test_crash_log):
57         (MainTest.test_web_process_crash_log):
58         Changed to use make_mock_crash_report_darwin.
59
60 2011-12-06  Jon Lee  <jonlee@apple.com>
61
62         [WK2] Add permissions support (73960)
63         https://bugs.webkit.org/show_bug.cgi?id=73960
64         <rdar://problem/10357008>
65
66         Reviewed by Darin Adler.
67
68         Add null function item to comply with added callback to WKPageUIClient.
69
70         * MiniBrowser/mac/BrowserWindowController.m:
71         (-[BrowserWindowController awakeFromNib]):
72         * WebKitTestRunner/TestController.cpp:
73         (WTR::TestController::createOtherPage):
74         (WTR::TestController::initialize):
75
76 2011-12-08  Alexander Færøy  <alexander.faeroy@nokia.com>
77
78         [Qt] Visualize mock points in the Qt MiniBrowser
79         https://bugs.webkit.org/show_bug.cgi?id=74074
80
81         Reviewed by Tor Arne Vestbø.
82
83         * MiniBrowser/qt/BrowserWindow.cpp:
84         (BrowserWindow::updateVisualMockTouchPoints):
85         * MiniBrowser/qt/BrowserWindow.h:
86         * MiniBrowser/qt/MiniBrowser.qrc:
87         * MiniBrowser/qt/MiniBrowserApplication.cpp:
88         (MiniBrowserApplication::notify):
89         (MiniBrowserApplication::sendTouchEvent):
90         * MiniBrowser/qt/MiniBrowserApplication.h:
91         * MiniBrowser/qt/icons/touchpoint.png: Added.
92         * MiniBrowser/qt/qml/MockTouchPoint.qml: Added.
93
94 2011-12-08  Simon Hausmann  <simon.hausmann@nokia.com>
95
96         [Qt] WebKitTestRunner crashes with debug builds
97         https://bugs.webkit.org/show_bug.cgi?id=74090
98
99         Reviewed by Tor Arne Vestbø.
100
101         * WebKitTestRunner/qt/TestControllerQt.cpp:
102         (WTR::TestController::platformInitialize): Call QQuickWebView::platformInitialize
103         to ensure WTF/JSC threading is initialized.
104
105 2011-12-08  Dirk Pranke  <dpranke@chromium.org>
106
107         fix build-webkit --chromium after breakage in r102201
108         https://bugs.webkit.org/show_bug.cgi?id=74031
109
110         Reviewed by Tony Chang.
111
112         * Scripts/webkitdirs.pm:
113         (buildChromium):
114
115 2011-12-08  Kentaro Hara  <haraken@chromium.org>
116
117         Unreviewed, rolling out r102280.
118         http://trac.webkit.org/changeset/102280
119         https://bugs.webkit.org/show_bug.cgi?id=74031
120
121         Chromium/Windows build is broken
122
123         * Scripts/webkitdirs.pm:
124         (buildChromium):
125
126 2011-12-08  Nayan Kumar K  <nayankk@motorola.com>
127
128         Adding myself to committers list.
129
130         Unreviewed.
131
132         * Scripts/webkitpy/common/config/committers.py:
133
134 2011-12-07  Michael Saboff  <msaboff@apple.com>
135
136         StringBuilderTest.Append and StringBuilderTest.ToStringPreserveCapacity are failing.
137         https://bugs.webkit.org/show_bug.cgi?id=73995
138
139         Reenabled failing tests that the code part of the patch fixes.
140
141         Reviewed by Geoffrey Garen.
142
143         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
144         (TestWebKitAPI::TEST):
145
146 2011-12-07  MORITA Hajime  <morrita@google.com>
147
148         [filter-build-webkit] should not emit reset color when --no-color is given
149         https://bugs.webkit.org/show_bug.cgi?id=73992
150
151         Reviewed by Daniel Bates.
152
153         Stop printing control sequences when --no-color is given.
154         After this change, the filter runs nicely even on environments
155         like Emacs compilation-mode which cannot understand the control sequence.
156
157         * Scripts/filter-build-webkit:
158         (printLine):
159
160 2011-12-07  Eric Seidel  <eric@webkit.org>
161
162         Use free memory to determine if we have space for DRT instances instead of total memory
163         https://bugs.webkit.org/show_bug.cgi?id=74021
164
165         Reviewed by Adam Barth.
166
167         This will hopefully make the Mac buildbots behave better.
168
169         I also reduced the expected memory needed per DRT now that
170         we're properly accounting for the system memory in our calculations.
171
172         * Scripts/webkitpy/common/system/platforminfo.py:
173         (PlatformInfo.total_bytes_memory):
174         (PlatformInfo._compute_free_bytes_from_vm_stat_output):
175         * Scripts/webkitpy/common/system/platforminfo_mock.py:
176         (MockPlatformInfo.total_bytes_memory):
177         * Scripts/webkitpy/layout_tests/port/base.py:
178         (Port.default_child_processes):
179         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
180         (PortTest.test_default_child_processes):
181
182 2011-12-07  Dirk Pranke  <dpranke@chromium.org>
183
184         fix build-webkit --chromium after breakage in r102201
185         https://bugs.webkit.org/show_bug.cgi?id=74031
186
187         Reviewed by Tony Chang.
188
189         r102201 introduced a change to the chromium build that splits
190         the executables out of WebKit.gyp into other gyp files, and adds
191         a new "All.gyp" that builds everything. However, I forgot to
192         update the build script to use All.gyp.
193
194         * Scripts/webkitdirs.pm:
195         (buildChromium):
196
197 2011-12-07  Tom Zakrajsek  <tomz@codeaurora.org>
198
199         Moved myself to the committers list.
200
201         * Scripts/webkitpy/common/config/committers.py:
202
203 2011-11-30  Simon Hausmann  <simon.hausmann@nokia.com>
204
205         [Qt] Fix debug shlib build with V8.
206
207         Reviewed by Tor Arne Vestbø.
208
209         * qmake/mkspecs/features/qtwebkit.prf: Don't link jscore with
210         v8 builds.
211
212 2011-11-30  Simon Hausmann  <simon.hausmann@nokia.com>
213
214         [Qt] V8 build fixes.
215
216         Reviewed by Tor Arne Vestbø.
217
218         * qmake/mkspecs/features/javascriptcore.prf: Don't add
219         Source/Thirdparty to the include search path here.
220         * qmake/mkspecs/features/webcore.prf: Instead it belongs here, because it's
221         used when building WebCore as well as using it, because header files like
222         GraphicsContext3D.h include stuff from ThirdParty.
223
224 2011-12-07  Peter Beverloo  <peter@chromium.org>
225
226         [Chromium] Fix project file generation for the Android bot after r102201
227         https://bugs.webkit.org/show_bug.cgi?id=73996
228
229         The gyp refactoring in r102201 was didn't explicitly exclude
230         the Android operating system in Tools/Tools.gyp, which broke
231         as gcc_version is not defined for that configuration.
232
233         Reviewed by Andreas Kling.
234
235         * Tools.gyp:
236
237 2011-12-07  Vsevolod Vlasov  <vsevik@chromium.org>
238
239         Unreviewed. Disabled failing tests on chromium.
240
241         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
242         (TestWebKitAPI::TEST):
243
244 2011-12-06  Dirk Pranke  <dpranke@chromium.org>
245
246         binaries in webkit.gyp should be split into a new file to break circular dependencies on webkit_support
247         https://bugs.webkit.org/show_bug.cgi?id=73382
248
249         Reviewed by Tony Chang.
250
251         XCode (and hence GYP) can't handle circular dependencies between
252         files (and projects). Accordingly, although the binaries in
253         WebKit.gyp depend on webkit_support and webkit_support depends
254         on webkit, we don't mention the latter dependency in the file.
255         To fix this, this change moves the binaries like DRT into a new
256         GYP file, and modifies gyp_webkit to build from that file
257         instead of WebKit.gyp.
258
259         * Tools.gyp: Added.
260
261 2011-12-06  Adam Roben  <aroben@apple.com>
262
263         Add a pid parameter to CrashLogs.find_newest_log
264
265         When a PID is passed, only crash logs corresponding to a crashed process with that PID are
266         considered.
267
268         Fixes <http://webkit.org/b/73942> webkitpy provides no way to specify the PID of the crashed
269         process whose crash log you want to find
270
271         Reviewed by Dirk Pranke.
272
273         * Scripts/webkitpy/common/system/crashlogs.py:
274         (CrashLogs.find_newest_log): Added an optional pid parameter.
275         (CrashLogs._find_newest_log_darwin): Added a pid parameter. When specified, we look at each
276         candidate log's app_description extended attribute to see if that log corresponds to a
277         crashed process with the specified PID.
278
279         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
280         (CrashLogsTest.test_find_newest_log_darwin): Added a few more mock crash logs with various
281         contents and PIDs. Added tests that show that the pid parameter to find_newest_log is
282         respected. Also fixed an erroneous use of assertTrue instead of assertEqual.
283
284         * Scripts/webkitpy/common/system/filesystem.py:
285         (FileSystem.getxattr): Added. On Darwin, calls through to the xattr module. On other
286         systems, raises a KeyError, mimicking the behavior on Darwin when the given attribute isn't
287         present.
288
289         * Scripts/webkitpy/common/system/filesystem_mock.py:
290         (MockFileSystem.__init__): Added an optional xattrs parameter. Documented other parameters.
291         (MockFileSystem.getxattr): Added. Just pulls the given attribute out of the xattrs
292         dictionary.
293
294         * Scripts/webkitpy/tool/commands/queries.py:
295         (CrashLog): Added help text. Added an optional PID parameter.
296         (CrashLog.execute): Pass the PID, if any, through to find_newest_log.
297
298 2011-12-06  Adam Roben  <aroben@apple.com>
299
300         Wait for Crash Reporter to finish even when it lets the crashed process die quickly
301
302         NRWT was only waiting for Crash Reporter in cases where it was keeping the crashed process
303         alive beyond the normal timeout limit. In cases where the crashed process was able to die
304         faster, NRWT would assume that Crash Reporter had finished even though it often was still
305         running, which would lead to an incorrect crash log being picked up.
306
307         Part of <http://webkit.org/b/71380> NRWT incorrectly associates crash logs with tests
308
309         Reviewed by Dirk Pranke.
310
311         * Scripts/webkitpy/layout_tests/port/server_process.py:
312         (ServerProcess._reset):
313         (ServerProcess.write):
314         (ServerProcess._check_for_crash): Changed to use new set_crashed function instead of setting
315         .crashed directly. Added wait_for_crash_reporter parameter, which we pass along to
316         set_crashed.
317
318         (ServerProcess._handle_timeout): Fixed a logic error that would cause .crashed and
319         .timed_out both to be set to True in cases where Crash Reporter took a long time to run. Now
320         we bail out of handling the failure as a timeout if we find out that the process in fact
321         crashed. We tell _check_for_crash not to wait for Crash Reporter because we've already done
322         so.
323         (ServerProcess.set_crashed): Added. When the process crashes, we wait for Crash Reporter to
324         finish running (unless directed otherwise) so we can be sure the crash log has been saved to
325         disk.
326
327         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
328         (TrivialMockPort.is_crash_reporter): Added.
329
330         * Scripts/webkitpy/layout_tests/port/webkit.py:
331         (WebKitDriver._check_for_driver_crash): Changed to use set_crashed. (This also fixed a typo
332         that would have partially broken crash detection on Windows, if NRWT worked on Windows.)
333
334 2011-12-06  Adam Barth  <abarth@webkit.org>
335
336         NRWT fails on unreleased versions of Mac OS X
337         https://bugs.webkit.org/show_bug.cgi?id=72748
338
339         Reviewed by Dirk Pranke.
340
341         Hopefully this patch will make NRWT work on future versions on Mac OS X.
342         Most of the infrastructure was already in place, but there were some
343         asserts that failed.  I've tested this patch by haxoring the version
344         detection logic to simulate an unknown version.  We might need to
345         iterate based on feedback from folks with a real future version.
346
347         * Scripts/webkitpy/layout_tests/port/apple.py:
348         (ApplePort.__init__):
349             - mac-future is an allowed port_name that's used internally by
350               webkitpy to represent future versions of Mac OS X.
351         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
352         (test_versions):
353             - Test that we don't throw exceptions when dealing with future
354               versions of Mac OS X.
355         * Scripts/webkitpy/layout_tests/port/webkit.py:
356         (WebKitPort._expectations_from_skipped_files):
357             - Demote this logging message to "debug".  It's expected that
358               mac-future doesn't have a Skipped file.
359         * Scripts/webkitpy/layout_tests/port/mac.py:
360         (MacPort.__init__):
361         * Scripts/webkitpy/layout_tests/port/win.py:
362         (WinPort.__init__):
363             - Re-order some code in these constructors so that
364               self._operating_system is available to the ApplePort constructor.
365
366 2011-12-06  Tommy Widenflycht  <tommyw@google.com>
367
368         Added myself as a committer.
369
370         * Scripts/webkitpy/common/config/committers.py:
371
372 2011-12-06  Peter Beverloo  <peter@chromium.org>
373
374         Added myself as a committer.
375
376         * Scripts/webkitpy/common/config/committers.py:
377
378 2011-12-06  Kentaro Hara  <haraken@chromium.org>
379
380         [Refactoring] In webkitpy/bindings/main.py, replace subprocess.Popen() with Executive
381         https://bugs.webkit.org/show_bug.cgi?id=73637
382
383         Reviewed by Adam Barth.
384
385         This patch replaces subprocess.Popen() with Executive, similar to other
386         Python scripts in webkitpy/. I manually confirmed that run-bindings-tests
387         works well for cases where no exception is raised, no exception is raised
388         but diff is found, and ScriptError is raised.
389
390         * Scripts/run-bindings-tests:
391         (main):
392         * Scripts/webkitpy/bindings/main.py: Replaces subprocess.Popen() with Executive.
393         (BindingsTests.__init__):
394         (BindingsTests.generate_from_idl):
395         (BindingsTests.generate_supplemental_dependency):
396         (BindingsTests.detect_changes):
397
398 2011-12-05  Alexander Færøy  <alexander.faeroy@nokia.com>
399
400         [Qt] MiniBrowser should default to touch behavior
401         https://bugs.webkit.org/show_bug.cgi?id=73863
402
403         Reviewed by Chang Shu.
404
405         MiniBrowser currently defaults to the traditional desktop behaviour
406         instead of touch behaviour which is prefered.
407
408         * MiniBrowser/qt/BrowserWindow.cpp:
409         (BrowserWindow::BrowserWindow):
410         * MiniBrowser/qt/MiniBrowserApplication.cpp:
411         (printHelp):
412         (MiniBrowserApplication::handleUserOptions):
413         * MiniBrowser/qt/MiniBrowserApplication.h:
414         (WindowOptions::WindowOptions):
415         (WindowOptions::setUseTraditionalDesktopBehavior):
416         (WindowOptions::useTraditionalDesktopBehavior):
417
418 2011-12-05  Raphael Kubo da Costa  <kubo@profusion.mobi>
419
420         webkit.py: Really fix the printing of StringImpl now that 8-bit strings are present.
421         https://bugs.webkit.org/show_bug.cgi?id=73878
422
423         Reviewed by Tony Chang.
424
425         r98624 turned StringImpl::m_data into StringImpl::{m_data8,m_data16}.
426         r98785 made webkit.py always use m_data16, which does not work when
427         the string is an 8-bit string (such as KURL::string()).
428
429         I was not able to directly call StringImpl::is8Bit() in the Python
430         code, so I just reproduced the implementation there.
431
432         * gdb/webkit.py:
433         (WTFStringPrinter.is_8bit): Reproduced StringImpl::is8Bit().
434         (WTFStringPrinter.to_string):
435         (JSCUStringPrinter.is_8bit): Reproduced StringImpl::is8Bit().
436         (JSCUStringPrinter.to_string):
437
438 2011-12-05  Eric Seidel  <eric@webkit.org>
439
440         Up the "expected ram for each DRT instance" to 400MB instead of 300MB
441         in hopes of making the Snow Leopard bot stop timing out.
442
443         Unreviewed.
444
445         * Scripts/webkitpy/layout_tests/port/base.py:
446         (Port.default_child_processes):
447         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
448         (PortTest.test_default_child_processes):
449
450 2011-12-05  Eric Seidel  <eric@webkit.org>
451
452         NRWT creates too many workers on RAM-limited machines
453         https://bugs.webkit.org/show_bug.cgi?id=73847
454
455         Reviewed by Dirk Pranke.
456
457         Make NRWT restrict its number of workers when there isn't enough
458         RAM to support them.
459         Also re-enable parallel testing on the Mac bots which were
460         failing due to not enough ram.
461
462         * Scripts/run-webkit-tests:
463         (platformIsReadyForParallelTesting):
464         * Scripts/webkitpy/common/host.py:
465         (Host.__init__):
466         * Scripts/webkitpy/common/system/executive_mock.py:
467         (MockExecutive.cpu_count):
468         * Scripts/webkitpy/common/system/platforminfo.py:
469         (PlatformInfo.__init__):
470         (PlatformInfo.display_name):
471         * Scripts/webkitpy/common/system/platforminfo_mock.py:
472         (MockPlatformInfo.display_name):
473         * Scripts/webkitpy/layout_tests/port/base.py:
474         (Port.default_child_processes):
475         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
476         (PortTest.test_default_child_processes):
477         (PortTest.test_pretty_patch_os_error):
478
479 2011-12-05  Hugo Parente Lima  <hugo.lima@openbossa.org>
480
481         Last mouse event could be lost if a JS call to eventSender.leapForward is made
482         https://bugs.webkit.org/show_bug.cgi?id=73366
483
484         Reviewed by Kenneth Rohde Christiansen.
485
486         Empty the entire event queue when requested besides using
487         sendEvent instead of postEvent to make sure all events were
488         delivered.
489
490         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
491         (WTR::EventSenderProxy::EventSenderProxy):
492         (WTR::EventSenderProxy::sendOrQueueEvent):
493         (WTR::EventSenderProxy::replaySavedEvents):
494
495 2011-12-05  Adam Barth  <abarth@webkit.org>
496
497         [Chromium] Remove no-longer-used forwarding headers in the WebKit API
498         https://bugs.webkit.org/show_bug.cgi?id=73845
499
500         Reviewed by Darin Fisher.
501
502         Update includes to point to the new header locations.
503
504         * DumpRenderTree/chromium/AccessibilityController.cpp:
505         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
506         * DumpRenderTree/chromium/CppBoundClass.cpp:
507         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
508         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
509         * DumpRenderTree/chromium/DRTDevToolsClient.h:
510         * DumpRenderTree/chromium/EventSender.cpp:
511         * DumpRenderTree/chromium/EventSender.h:
512         * DumpRenderTree/chromium/GamepadController.h:
513         * DumpRenderTree/chromium/LayoutTestController.cpp:
514         * DumpRenderTree/chromium/LayoutTestController.h:
515         * DumpRenderTree/chromium/MockSpellCheck.cpp:
516         * DumpRenderTree/chromium/NotificationPresenter.cpp:
517         * DumpRenderTree/chromium/PlainTextController.cpp:
518         * DumpRenderTree/chromium/Task.cpp:
519         * DumpRenderTree/chromium/TestNavigationController.h:
520         * DumpRenderTree/chromium/TestShell.cpp:
521         * DumpRenderTree/chromium/TestWebPlugin.cpp:
522         * DumpRenderTree/chromium/TestWebPlugin.h:
523         * DumpRenderTree/chromium/TextInputController.cpp:
524         * DumpRenderTree/chromium/WebPermissions.cpp:
525         * DumpRenderTree/chromium/WebPreferences.h:
526         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
527         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
528         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
529         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h:
530         * DumpRenderTree/chromium/WebViewHost.cpp:
531
532 2011-12-05  Ryosuke Niwa  <rniwa@webkit.org>
533
534         Add Aharon Lanin to the contributors list.
535
536         * Scripts/webkitpy/common/config/committers.py:
537
538 2011-12-05  Jarred Nicholls  <jarred@sencha.com>
539
540         Moving myself from contributors to committers.
541
542         * Scripts/webkitpy/common/config/committers.py:
543
544 2011-12-05  Raphael Kubo da Costa  <kubo@profusion.mobi>
545
546         Add myself as a committer.
547
548         * Scripts/webkitpy/common/config/committers.py:
549
550 2011-12-05  Michael Brüning  <michael.bruning@nokia.com>
551
552         [Qt] Rename QQuickWebView::canStop property to just loading 
553         https://bugs.webkit.org/show_bug.cgi?id=73813
554
555         Reviewed by Kenneth Rohde Christiansen.
556
557         Replaced references to WebView.canStop with WebView.loading.
558
559         * MiniBrowser/qt/qml/BrowserWindow.qml:
560
561 2011-12-05  Dirk Pranke  <dpranke@chromium.org>
562
563         run-webkit-tests: limit --child-processes properly on apple mac
564         https://bugs.webkit.org/show_bug.cgi?id=73856
565
566         Reviewed by Adam Roben.
567
568         Fix typos in r102013 so that we correctly pass --child-processes=1 on
569         the apple mac bots temporarily.
570
571         * Scripts/run-webkit-tests:
572         (platformIsReadyForParallelTesting):
573
574 2011-12-05  Ryosuke Niwa  <rniwa@webkit.org>
575
576         Temporarily set --child-process=1 on Mac because 20+ tests are timing out
577         https://bugs.webkit.org/show_bug.cgi?id=73840
578
579         Reviewed by Simon Fraser.
580
581         Temporarily go back to single process mode on Mac.
582
583         * Scripts/run-webkit-tests:
584         (platformIsReadyForParallelTesting):
585
586 2011-12-05  Adam Roben  <aroben@apple.com>
587
588         Redeploy apple-macpro-7 and apple-xserve-1
589
590         These slaves have been sitting idle since we removed our Leopard builders in r97496.
591
592         Fixes <http://webkit.org/b/73829> REGRESSION (r97496): apple-macpro-7 and apple-xserve-1 are
593         sitting idle
594
595         Reviewed by Sam Weinig.
596
597         * BuildSlaveSupport/build.webkit.org-config/config.json: Re-added apple-macpro-7 and
598         apple-xserve-1. The former is now doing "SnowLeopard Intel Debug (WebKit2 Tests)", which
599         allows apple-xserve-9 to be a build-only slave, and the latter is doing "Lion Intel Debug
600         (WebKit2 Tests)".
601
602 2011-12-05  Kenneth Rohde Christiansen  <kenneth@webkit.org>
603
604         [Qt] Make the UI of the MiniBrowser slightly nicer
605
606         Rubberstamped by Simon Hausmann.
607
608         - Add proper padding
609         - Show feedback when pressing on the toolbar icons
610         - Make the text entry better looking
611
612         * MiniBrowser/qt/qml/BrowserWindow.qml:
613
614 2011-12-05  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
615
616         NRWT should handle duplicated expectations
617         https://bugs.webkit.org/show_bug.cgi?id=69750
618
619         Reviewed by Dirk Pranke.
620
621         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
622         (TestExpectations.__init__):
623         (TestExpectations._report_errors):
624         (TestExpectations._add_expectations):
625         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
626         (test_add_skipped_tests):
627         * Scripts/webkitpy/layout_tests/port/base.py:
628         (Port.skipped_tests):
629         * Scripts/webkitpy/layout_tests/port/webkit.py:
630         (WebKitPort.test_expectations):
631         (WebKitPort.skipped_tests):
632         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
633         (test_test_expectations):
634
635 2011-12-04  Eric Seidel  <eric@webkit.org>
636
637         After success with Mac, Win and Gtk, turning on parallel testing
638         by default for all platforms (except Qt).
639
640         We'll add more platforms to the blacklist if we see problems.
641
642         Unreviewed.
643
644         * Scripts/run-webkit-tests:
645         (platformIsReadyForParallelTesting):
646
647 2011-12-04  Sam Weinig  <sam@webkit.org>
648
649         Add tests for RetainPtr::adoptNS/adoptCF
650         https://bugs.webkit.org/show_bug.cgi?id=73470
651
652         Reviewed by Adam Roben and Darin Adler.
653
654         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
655         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp: Added.
656         (TestWebKitAPI::TEST):
657         Test that adopting using adoptCF creates a RetainPtr with a
658         value whose retain count is 1.
659
660         * TestWebKitAPI/Tests/WTF/ns: Added.
661         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm: Added.
662         (TestWebKitAPI::TEST):
663         Test that adopting using adoptNS creates a RetainPtr with a
664         value whose retain count is 1.
665
666 2011-12-04  Martin Robinson  <mrobinson@igalia.com>
667
668         [GTK] Include cairo, pixman and gnome-icon-theme in the jhbuild modules
669         https://bugs.webkit.org/show_bug.cgi?id=73748
670
671         Reviewed by Gustavo Noronha Silva.
672
673         * gtk/jhbuild.modules: Add some new modules the jhbuild moduleset.
674
675 2011-12-04  Philippe Normand  <pnormand@igalia.com>
676
677         Another GTK build fix after r101922.
678
679         Rubber-stamped by Martin Robinson.
680
681         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
682         (LayoutTestController::pathToLocalResource): Plug possible String ref leak.
683
684 2011-12-04  Xan Lopez  <xlopez@igalia.com>
685
686         Fix compiler warning in LayoutTestController
687
688         Reviewed by Philippe Normand.
689
690         * DumpRenderTree/LayoutTestController.cpp:
691         (LayoutTestController::LayoutTestController): fix warning.
692
693 2011-12-04  Alexandre Mazari  <scaroo@gmail.com>
694
695         Add missing methods used by fast/notifications tests to LayoutTestController
696         https://bugs.webkit.org/show_bug.cgi?id=63616
697
698         Reviewed by Martin Robinson.
699
700         Add missing simulateDesktopNotificationClick method used by
701         fast/notifications. Provide a default implementation for
702         areDesktopNotificationPermissionRequestsIgnored and
703         ignoreDesktopNotificationPermissionRequests.
704
705         * DumpRenderTree/LayoutTestController.cpp:
706         (LayoutTestController::LayoutTestController): call into the port implementation.
707         (simulateDesktopNotificationClickCallback): ditto.
708         (ignoreDesktopNotificationPermissionRequestsCallback): default implementation.
709         (LayoutTestController::staticFunctions): declare new methods.
710         (LayoutTestController::ignoreDesktopNotificationPermissionRequests): default implementation.
711         * DumpRenderTree/LayoutTestController.h:
712         (LayoutTestController::areDesktopNotificationPermissionRequestsIgnored):
713         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
714         (LayoutTestController::simulateDesktopNotificationClick): dummy implementation.
715         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
716         (LayoutTestController::simulateDesktopNotificationClick): ditto.
717         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
718         (LayoutTestController::simulateDesktopNotificationClick): ditto.
719         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
720         (LayoutTestController::simulateDesktopNotificationClick): ditto.
721         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
722         (LayoutTestController::simulateDesktopNotificationClick): ditto.
723
724 2011-12-03  Mario Sanchez Prada  <msanchez@igalia.com>
725
726         [GTK] Don't log document events in DRT
727         https://bugs.webkit.org/show_bug.cgi?id=73746
728
729         Reviewed by Martin Robinson.
730
731         Stop connecting globally to document-related events.
732
733         * DumpRenderTree/gtk/AccessibilityCallbacks.cpp:
734         (connectAccessibilityCallbacks): Removed connections.
735         (disconnectAccessibilityCallbacks): Removed disconnections.
736
737 2011-12-03  Dan Bernstein  <mitz@apple.com>
738
739         Added a test for <rdar://problem/10523721> Crash at WebCore::SubresourceLoader::releaseResources
740
741         Reviewed by Darin Adler.
742
743         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
744         * TestWebKitAPI/Tests/mac/SubresourceErrorCrash.mm: Added.
745         (TestWebKitAPI::TEST):
746
747 2011-12-03  Philippe Normand  <pnormand@igalia.com>
748
749         Another GTK build fix after r101922.
750
751         Rubber-stamped by Martin James Robinson.
752
753         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
754         (LayoutTestController::pathToLocalResource): return value needs to
755         be a URI.
756
757 2011-12-03  Martin Robinson  <mrobinson@igalia.com>
758
759         Small fix for my previous patch. Do not try to delete a member
760         of a dictionary that does not exist.
761
762         Reviewed by Gustavo Noronha Silva.
763
764         * gtk/run-with-jhbuild:
765         (install_and_run_jhbuild):
766
767 2011-12-03  Martin Robinson  <mrobinson@igalia.com>
768
769         Fix jhbuild installation for people who have unusual MAKE environment
770         variables such as 'make -j4' as the jhbuild build does not handle it.
771
772         Reviewed by Gustavo Noronha Silva.
773
774         * gtk/run-with-jhbuild:
775         (install_and_run_jhbuild): Remove any MAKE environment variable before building jhbuild.
776
777 2011-12-03  Martin Robinson  <mrobinson@igalia.com>
778
779         Fix the update-webkitgtk-libs script to properly trigger a jhbuild installation
780         when run for the first time.
781
782         Reviewed by Gustavo Noronha Silva.
783
784         * Scripts/update-webkitgtk-libs: Fix first run.
785
786 2011-12-03  Philippe Normand  <pnormand@igalia.com>
787
788         Unreviewed, GTK build fix after r101922.
789
790         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
791         (LayoutTestController::pathToLocalResource): Added sentinel in
792         g_build_filename call.
793
794 2011-12-03  Philippe Normand  <pnormand@igalia.com>
795
796         GTK API tests build fix. Run the tests inside jhbuild.
797
798         Rubber-stamped by Gustavo Noronha Silva.
799
800         * Scripts/run-gtk-tests:
801         (TestRunner.__init__):
802         (TestRunner.run._error_handler):
803         (TestRunner):
804         (TestRunner.run):
805
806 2011-12-03  Martin Robinson  <mrobinson@igalia.com>
807
808         Small build fix. Properly specify the path to the locally installed jhbuild.
809
810         * Scripts/update-webkitgtk-libs: Fix jhbuild path.
811
812 2011-12-03  Martin Robinson  <mrobinson@igalia.com>
813
814         [GTK][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
815         https://bugs.webkit.org/show_bug.cgi?id=67256
816
817         Reviewed by Philippe Normand.
818
819         Implement LayoutTestController::pathToLocalResource for GTK+. Instead of passing 
820         WEBKIT_TEST_FONTS to the GTK+ test harnesses, pass a more generic WEBKIT_TOP_LEVEL,
821         which points to the more generic top-level path of the WebKit checkout. This code is
822         duplicated between WK1 and WK2 harnesses because we do not currently have a way to
823         share code here.
824
825         If WEBKIT_TOP_LEVEL is not provided, we search for the top level based on the binary
826         location. This will cause the fallback to fail if you build into a non-typical location
827         or even fake it with a symlink. In this case it's important to use the environment variable.
828
829         * DumpRenderTree/gtk/DumpRenderTree.cpp:
830         (getTopLevelPath): Added.
831         (initializeFonts): Use the new helper to get the font path.
832         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Expose the new helper.
833         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
834         (LayoutTestController::pathToLocalResource):Use the new helper to normalize
835         test paths.
836         * Scripts/webkitpy/layout_tests/port/gtk.py:
837         (GtkPort.setup_environ_for_server):Pass the top-level path of the
838         checkout instead of passing the font path.
839         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
840         (WTR::getTopLevelPath): Added this helper.
841         (WTR::inititializeFontConfigSetting): Use the helper to find the font path.
842
843 2011-12-02  David Levin  <levin@chromium.org>
844
845         Rename WTF class from TemporarilyChange to TemporaryChange.
846         https://bugs.webkit.org/show_bug.cgi?id=73479
847
848         Reviewed by Eric Seidel.
849
850         * DumpRenderTree/ForwardingHeaders/wtf/TemporarilyChange.h: Removed.
851         * DumpRenderTree/ForwardingHeaders/wtf/TemporaryChange.h: Added.
852         * TestWebKitAPI/TestWebKitAPI.gypi:
853         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
854         * TestWebKitAPI/Tests/WTF/TemporaryChange.cpp: Renamed from Tools/TestWebKitAPI/Tests/WTF/TemporarilyChange.cpp.
855         (TestWebKitAPI::TEST):
856         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
857
858 2011-12-02  Tony Chang  <tony@chromium.org>
859
860         [NRWT] reftest asserts intermittently on the Qt-WK2 bot
861         https://bugs.webkit.org/show_bug.cgi?id=73453
862
863         Reviewed by Ryosuke Niwa.
864
865         We used to assert if a ref test didn't generate pixel results. Instead, just claim it is a failing test.
866         The verbose output will include the failure reason.
867
868         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: Don't assert, return FailureReftestNoImagesGenerated instead.
869         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
870         (write_test_result):
871         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py: Remove stray letter t.
872         * Scripts/webkitpy/layout_tests/models/test_failures.py: Add a new failure type: FailureReftestNoImagesGenerated
873         (determine_result_type):
874         (FailureReftestNoImagesGenerated.__init__):
875         (FailureReftestNoImagesGenerated):
876         (FailureReftestNoImagesGenerated.message):
877         * Scripts/webkitpy/layout_tests/port/test.py: Add a test case for integration tests.
878         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Update test counts.
879         (MainTest.test_run_singly_actually_runs_tests):
880         (MainTest.test_unexpected_failures):
881         (EndToEndTest.test_end_to_end):
882
883 2011-12-02  Ryosuke Niwa  <rniwa@webkit.org>
884
885         ChangeLog should be able to parse annotated changelogs
886         https://bugs.webkit.org/show_bug.cgi?id=72703
887
888         Reviewed by Eric Seidel.
889
890         Make parse_entries_from_file aware of svn blame annotation such as "100000 ossy@webkit.org ",
891         and extract the revision number for each entry.
892
893         Also add a support to extract "svn blame" result from svn/git checkout to scm classes.
894
895         * Scripts/webkitpy/common/checkout/changelog.py:
896         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
897         * Scripts/webkitpy/common/checkout/scm/git.py:
898         * Scripts/webkitpy/common/checkout/scm/scm.py:
899         * Scripts/webkitpy/common/checkout/scm/svn.py:
900
901 2011-12-02  Eric Seidel  <eric@webkit.org>
902
903         Enable parallel testing for Win and Gtk bots
904         after confirming with Lucas and Martin the bots should be OK.
905
906         Unreviewed. (I ran the idea by Lucas and Martin.)
907
908         * Scripts/run-webkit-tests:
909         (platformIsReadyForParallelTesting):
910
911 2011-12-02  Martin Robinson  <mrobinson@igalia.com>
912
913         Try to fix the GTK+ build.
914
915         * gtk/jhbuild.modules: Properly specify the glib-networking
916         dependency for soup.
917
918 2011-12-02  Martin Robinson  <mrobinson@igalia.com>
919
920         Fix a syntax error in the committers.py file.
921
922         * Scripts/webkitpy/common/config/committers.py: Add a missing comma.
923
924 2011-12-02  Ryosuke Niwa  <rniwa@webkit.org>
925
926         Add Alan Stearns and Peter Linss to the contributors list.
927
928         * Scripts/webkitpy/common/config/committers.py:
929
930 2011-12-02  Kent Tamura  <tkent@chromium.org>
931
932         [Chromium] Fix compilation warnings for ASSERT()
933         https://bugs.webkit.org/show_bug.cgi?id=73623
934
935         Reviewed by Tony Chang.
936
937         * DumpRenderTree/chromium/ImageDiff.cpp:
938          - Fix fprintf format: %s -> %d for __LINE__
939          - Do nothing for ASSERT() if NDEBUG.
940
941 2011-12-02  Eric Seidel  <eric@webkit.org>
942
943         Enable parallel testing for all Mac bots.
944
945         Unreviewed.
946
947         * Scripts/run-webkit-tests:
948         (platformIsReadyForParallelTesting):
949
950 2011-12-02  Eric Seidel  <eric@webkit.org>
951
952         Enable parallel testing for run-webkit-tests on Mac Lion.
953         I plan to move all the machines to parallel testing shortly
954         but we're starting with Lion.
955
956         Unreviewed.
957
958         * Scripts/run-webkit-tests:
959         (platformIsReadyForParallelTesting):
960
961 2011-12-02  Kausalya Madhusudhanan  <kmadhusu@chromium.org>
962
963         Added helper method to identify whether the page has custom page size style.
964         https://bugs.webkit.org/show_bug.cgi?id=73585
965
966         Reviewed by Darin Fisher.
967
968         * DumpRenderTree/chromium/LayoutTestController.cpp:
969         (LayoutTestController::LayoutTestController):
970         (LayoutTestController::hasCustomPageSizeStyle):
971         * DumpRenderTree/chromium/LayoutTestController.h:
972
973 2011-12-01  Ryosuke Niwa  <rniwa@webkit.org>
974
975         [NRWT] reftest should support having multiple references per test
976         https://bugs.webkit.org/show_bug.cgi?id=73613
977
978         Reviewed by Dirk Pranke.
979
980         Add a support for having multiple reference files for a single test.
981
982         Because a reftest succeeds when it matches at least one of expected matches and fails when it matches
983         at least one of expected mismatches, we compare expected mismatches first in order to minimize
984         the number of reference files to open on DRT.
985
986         * Scripts/webkitpy/layout_tests/controllers/manager.py:
987         (interpret_test_failures): Remove checks no longer applicable.
988         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
989         (ResultSummaryTest.test_interpret_test_failures): Ditto.
990         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
991         (SingleTestRunner.__init__): Remove a bunch of code and just call port.reference_files.
992         (SingleTestRunner._driver_input):
993         (SingleTestRunner.run):
994         (SingleTestRunner._run_reftest): Compare the output of the test to each reference file.
995         * Scripts/webkitpy/layout_tests/models/test_input.py:
996         (TestInput.__init__): Remove ref_file and is_mismatch_reftest because they are no longer used.
997         * Scripts/webkitpy/layout_tests/port/base.py:
998         (Port.reference_files): Renamed from _reference_file_for. Returns a list of expectation, filename pairs.
999         (_parse_reftest_list): Now supports parsing multiple entries for a single test.
1000         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1001         (PortTest.test_parse_reftest_list):
1002         * Scripts/webkitpy/layout_tests/port/test.py:
1003         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1004         (MainTest.test_unexpected_failures):
1005         (MainTest.test_reftest_skipped_if_unlisted): Renamed from test_missing_and_unexpected_results.
1006         (EndToEndTest.test_end_to_end):
1007         (EndToEndTest.test_reftest_with_two_notrefs): Added.
1008
1009 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
1010
1011         Build libsoup without gnome dependencies (like keyring).
1012
1013         * gtk/jhbuild.modules:
1014
1015 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
1016
1017         Also build gcrypt and p11-kit, and make them dependencies of
1018         gnutls.
1019
1020         * gtk/jhbuild.modules:
1021
1022 2011-12-02  Kevin Ollivier  <kevino@theolliviers.com>
1023
1024         [wx] Unreviewed build fixes for Windows build.
1025
1026         * waf/build/wxpresets.py:
1027
1028 2011-12-01  Eric Seidel  <eric@webkit.org>
1029
1030         Reviewed by Adam Barth.
1031
1032         webkit-patch post, post-commits, upload should warn when posting to a closed bug, and offer to reopen it
1033         https://bugs.webkit.org/show_bug.cgi?id=32006
1034
1035         I decided not to make it warn, and just have it re-open the bug.
1036         That's not that different from today's behavior which will
1037         just silently attach the patch.
1038
1039         This patch makes behavior between upload and land-safely consistent
1040         (previously one would assign patches and the other would not)
1041         as well as adds the ability for both to ensure that the bug is open.
1042
1043         To test this I had to add a few more methods to MockBugzilla which
1044         (positively) affected a few other test results.
1045
1046         I also made AbstractStep keep a cached copy of the Bug object
1047         and used the cached copy where appropriate (including for 'bug_title').
1048         This should reduce the number of bug fetches we perform.
1049
1050         * Scripts/webkitpy/tool/commands/download_unittest.py:
1051         * Scripts/webkitpy/tool/commands/upload.py:
1052         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1053         * Scripts/webkitpy/tool/mocktool.py:
1054         * Scripts/webkitpy/tool/steps/__init__.py:
1055         * Scripts/webkitpy/tool/steps/abstractstep.py:
1056         * Scripts/webkitpy/tool/steps/closebug.py:
1057         * Scripts/webkitpy/tool/steps/ensurebugisopenandassigned.py: Added.
1058         * Scripts/webkitpy/tool/steps/postdiff.py:
1059         * Scripts/webkitpy/tool/steps/postdiffforcommit.py:
1060         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1061         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1062         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
1063
1064 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
1065
1066         Also pass --no-interact to jhbuild when updating dependencies.
1067
1068         * Scripts/update-webkitgtk-libs:
1069
1070 2011-12-02  Alice Boxhall  <aboxhall@chromium.org>
1071
1072         Make _build_path check more thoroughly that build paths exist.
1073         https://bugs.webkit.org/show_bug.cgi?id=73601
1074
1075         Reviewed by Ojan Vafai.
1076
1077         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1078         (ChromiumMacPort._build_path):
1079
1080 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
1081
1082         Add libffi to the jhbuild modules list as a glib dependency.
1083
1084         Rubber-stamped by Martin Robinson.
1085
1086         * gtk/jhbuild.modules:
1087
1088 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
1089
1090         Build fix. Use internal pcre on glib, make gnutls a dependency of
1091         glib-networking, unset AR_FLAGS for jhbuild builds, and run jhbuild
1092         in non-interactive mode.
1093
1094         * Scripts/update-webkitgtk-libs:
1095         * gtk/jhbuild.modules:
1096         * gtk/run-with-jhbuild:
1097
1098 2011-12-02  Adam Roben  <aroben@apple.com>
1099
1100         Fix for Python 2.6
1101
1102         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1103         (RunUnitTests.countFailures): Removed the flags parameter to re.split, which was only added
1104         in Python 2.7, and used whitespace instead of start-of-string/end-of-string markers when
1105         searching for "Tests that timed out:" etc. This makes our check less strict, but it
1106         shouldn't matter given the kinds of content we parse.
1107
1108 2011-12-02  Adam Roben  <aroben@apple.com>
1109
1110         Fix names of failed/timed out tests in run-api-tests output
1111
1112         Fixes <http://webkit.org/b/73663> run-api-tests prints suite names twice for failed or timed
1113         out tests
1114
1115         We were ending up with the suite name doubled (e.g., "WebKit2.WebKit2.MouseMoveAfterCrash").
1116
1117         Reviewed by Simon Fraser.
1118
1119         * Scripts/run-api-tests:
1120         (runTest): Don't prepend the suite name to $test. It's already been prepended at the start
1121         of this function.
1122
1123 2011-11-29  Martin Robinson  <mrobinson@igalia.com>
1124
1125         [GTK] generate-gtkdoc should respect build type
1126         https://bugs.webkit.org/show_bug.cgi?id=73296
1127
1128         Reviewed by Philippe Normand.
1129
1130         * Scripts/webkitdirs.pm:
1131         (buildAutotoolsProject): Pass the --debug to the generate-gtkdoc script.
1132         * gtk/common.py: If --build is passed give preference to the Debug build directory.
1133
1134 2011-12-02  Tony Chang  <tony@chromium.org>
1135
1136         [nrwt] fix wdiff output
1137         https://bugs.webkit.org/show_bug.cgi?id=73604
1138
1139         Reviewed by Adam Barth.
1140
1141         * Scripts/webkitpy/layout_tests/port/base.py:
1142         (Port.wdiff_text):
1143         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1144         (PortTest.test_wdiff_text):
1145
1146 2011-12-02  Adam Roben  <aroben@apple.com>
1147
1148         Teach build.webkit.org to display how many unit tests failed or timed out
1149
1150         Fixes <http://webkit.org/b/73659> It's hard to tell how many unit tests are failing on
1151         build.webkit.org
1152
1153         We now display something like "5 unit tests failed or timed out". Eventually we might want
1154         to split out how many failure vs. timeouts there were.
1155
1156         Reviewed by Darin Adler.
1157
1158         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1159         (TestWithFailureCount): Moved this class up to the top of the file so it is before any other
1160         classes that may want to subclass it.
1161         (RunUnitTests): Changed to inherit from TestWithFailureCount.
1162         (RunUnitTests.countFailures): Added. Counts the number of tests following the "Tests that
1163         timed out:" and "Tests that failed:" lines, if present.
1164
1165         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1166         (StubStdio):
1167         (StubRemoteCommand):
1168         Added these two stub classes to mimic buildbot's RemoteCommand and log classes.
1169
1170         (RunUnitTestsTest.assertFailures): Helper method to check that we interpreted the results of
1171         the test run correctly.
1172
1173         (RunUnitTestsTest.test_no_failures_or_timeouts):
1174         (RunUnitTestsTest.test_one_failure):
1175         (RunUnitTestsTest.test_multiple_failures):
1176         (RunUnitTestsTest.test_one_timeout):
1177         (RunUnitTestsTest.test_multiple_timeouts):
1178         (RunUnitTestsTest.test_multiple_failures_and_timeouts):
1179         Test various cases.
1180
1181 2011-12-02  Adam Roben  <aroben@apple.com>
1182
1183         Teach prepare-ChangeLog to treat master.cfg as a Python file
1184
1185         Fixes <http://webkit.org/b/73658> prepare-ChangeLog doesn't show modified classes/functions
1186         in buildbot's master.cfg
1187
1188         Reviewed by Darin Adler.
1189
1190         * Scripts/prepare-ChangeLog:
1191         (get_function_line_ranges): Use get_function_line_ranges_for_python if the filename is
1192         master.cfg.
1193
1194 2011-12-02  Martin Robinson  <mrobinson@igalia.com>
1195
1196         [GTK] Create a wrapper script that knows how to install jhbuild and run commands with it
1197         https://bugs.webkit.org/show_bug.cgi?id=73669
1198
1199         Reviewed by Gustavo Noronha Silva.
1200
1201         Add a wrapper script that knows how to install jhbuild and also to wrap commands
1202         in the jhbuild shell.
1203
1204         * Scripts/webkitdirs.pm:
1205         (runAutogenForAutotoolsProject): Use the new wrapper script.
1206         (mustReRunAutogen): Ditto.
1207         (buildAutotoolsProject): Ditto.
1208         * Scripts/webkitpy/layout_tests/port/gtk.py:
1209         (GtkDriver.cmd_line): Ditto.
1210         * gtk/run-with-jhbuild: Added.
1211
1212 2011-12-01  Adam Roben  <aroben@apple.com>
1213
1214         Teach check-webkit-style how to check the syntax of JSON files
1215
1216         Fixes <http://webkit.org/b/73590> check-webkit-style doesn't flag JSON syntax errors
1217
1218         I previously landed this patch as r101711, but the new tests failed on Snow Leopard. This
1219         patch is identical to that one except for two change: assertIn(a, b) (which is new to Python
1220         2.7) has been replaced with assertTrue(a in b), and the test_missing_closing_brace test has
1221         been removed, since its output differs by platform.
1222
1223         Reviewed by Darin Adler.
1224
1225         * Scripts/webkitpy/style/checker.py:
1226         (_all_categories): Added JSONChecker's categories to the set of all categories.
1227         (FileType): Added a JSON type. Incremented other types.
1228         (CheckerDispatcher._file_type): Use the JSON file type for .json files.
1229         (CheckerDispatcher._create_checker): Use a JSONChecker for JSON files.
1230
1231         * Scripts/webkitpy/style/checker_unittest.py:
1232         (CheckerDispatcherDispatchTest.assert_checker_json): Added this helper method.
1233         (CheckerDispatcherDispatchTest.test_json_paths): Added. Based on test_python_paths.
1234
1235         * Scripts/webkitpy/style/checkers/jsonchecker.py: Added. (I didn't name this just "json",
1236         which would have matched our other checkers, because I couldn't figure out how to call
1237         "json.loads" without hitting namespace conflicts.)
1238         (JSONChecker.__init__): Turn of line filtering so that we always check the whole file, not
1239         just the modified lines from a patch.
1240         (JSONChecker.check): Try to parse the lines as JSON. Mark an error if there was an
1241         exception.
1242         (JSONChecker.line_number_from_json_exception): Parse the json modules exception message to
1243         try to extract a line number.
1244
1245         * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py: Added.
1246         (MockErrorHandler.__init__):
1247         (MockErrorHandler.turn_off_line_filtering):
1248         (MockErrorHandler.__call__):
1249         Helper class. Copied from xml_unittest.py.
1250
1251         (JSONCheckerTest.test_line_number_from_json_exception): Test the
1252         line_number_from_json_exception helper method.
1253
1254         (JSONCheckerTest.assert_no_error):
1255         (JSONCheckerTest.assert_error):
1256         Helper methods to assert that we did or didn't get an error.
1257
1258         (JSONCheckerTest.mock_handle_style_error): Helper method.
1259
1260         (JSONCheckerTest.test_conflict_marker):
1261         (JSONCheckerTest.test_single_quote):
1262         (JSONCheckerTest.test_init):
1263         (JSONCheckerTest.test_no_error):
1264         Test various cases.
1265
1266 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
1267
1268         [GTK] Add glib, glib-networking, gnutls and libsoup to jhbuild
1269         https://bugs.webkit.org/show_bug.cgi?id=73664
1270
1271         Reviewed by Martin Robinson.
1272
1273         This patch adds our HTTP library and its main dependencies; this
1274         should not affect layout or rendering.
1275
1276         * gtk/jhbuild.modules:
1277
1278 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
1279
1280         [GTK] Also run DumpRenderTree under jhbuild
1281         https://bugs.webkit.org/show_bug.cgi?id=73646
1282
1283         Reviewed by Martin Robinson.
1284
1285         * Scripts/webkitpy/layout_tests/port/gtk.py:
1286         (GtkDriver.cmd_line):
1287
1288 2011-12-02  Hajime Morrita  <morrita@chromium.org>
1289
1290         Unreviewed, rolling out r101751 and r101775.
1291         http://trac.webkit.org/changeset/101751
1292         http://trac.webkit.org/changeset/101775
1293         https://bugs.webkit.org/show_bug.cgi?id=73191
1294
1295         breaks Windows build
1296
1297         * DumpRenderTree/chromium/config.h:
1298         * DumpRenderTree/config.h:
1299         * TestWebKitAPI/config.h:
1300         * WebKitTestRunner/config.h:
1301
1302 2011-12-02  Kentaro Hara  <haraken@chromium.org>
1303
1304         Move run-bindings-tests implementation to webkitpy/bindings/main.py
1305         https://bugs.webkit.org/show_bug.cgi?id=73619
1306
1307         Reviewed by Adam Barth.
1308
1309         As run-bindings-tests has been growing, this patch just moves its implementation
1310         to webkitpy/bindings/main.py to integrate with the rest of webkitpy.
1311
1312         No change in behavior.
1313
1314         * Scripts/run-bindings-tests:
1315         (main):
1316         * Scripts/webkitpy/bindings/__init__.py: Added.
1317         * Scripts/webkitpy/bindings/main.py: Added.
1318         (BindingsTests.__init__):
1319         (BindingsTests.generate_from_idl):
1320         (BindingsTests.generate_supplemental_dependency):
1321         (BindingsTests.detect_changes):
1322         (BindingsTests.run_tests):
1323
1324 2011-12-01  Ilya Tikhonovsky  <loislo@chromium.org>
1325
1326         Tools/Scripts: eliminate find_test_files from Port class.
1327         https://bugs.webkit.org/show_bug.cgi?id=73553
1328
1329         rebaseline.py and chromium_gpu.py use Port.find_test_files() the same way as it is used in Port.tests()
1330         I'd like to replace all calls to find_test_files with tests and eliminate find_tests_files.
1331         Also I'll move _is_test_file() and related functions close to Port.tests().
1332
1333         Reviewed by Dirk Pranke.
1334
1335         * Scripts/webkitpy/layout_tests/port/base.py:
1336         (Port.tests):
1337         (Port.is_reference_html_file):
1338         (Port._has_supported_extension):
1339         (Port._is_test_file):
1340         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1341         (PortTest.test_find_no_paths_specified):
1342         (PortTest.test_find_one_test):
1343         (PortTest.test_find_glob):
1344         (PortTest.test_find_with_skipped_directories):
1345         (PortTest.test_find_with_skipped_directories_2):
1346         (PortTest.test_is_test_file):
1347         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1348         (_default_tests_paths):
1349         (ChromiumGpuLinuxPort.tests):
1350         (ChromiumGpuCgMacPort.tests):
1351         (ChromiumGpuMacPort.tests):
1352         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1353         (ChromiumGpuTest.test_default_tests_paths.test_paths):
1354         (ChromiumGpuTest.test_default_tests_paths):
1355         (ChromiumGpuTest.test_test_files.test_paths):
1356         (ChromiumGpuTest):
1357         (ChromiumGpuTest.test_test_files):
1358         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1359         (get_tests_run.RecordingTestDriver.run_test):
1360         * Scripts/webkitpy/tool/commands/rebaseline.py:
1361         (OptimizeBaselines._optimize_baseline):
1362         (OptimizeBaselines.execute):
1363         (AnalyzeBaselines._analyze_baseline):
1364         (AnalyzeBaselines.execute):
1365
1366 2011-12-01  Hajime Morrita  <morrita@chromium.org>
1367
1368         JS_INLINE and WTF_INLINE should be visible from WebCore
1369         https://bugs.webkit.org/show_bug.cgi?id=73191
1370
1371         Reviewed by Kevin Ollivier.
1372
1373         Removed macro definitions which is now provided by Platform.h
1374
1375         * DumpRenderTree/chromium/config.h:
1376         * DumpRenderTree/config.h:
1377         * TestWebKitAPI/config.h:
1378         * WebKitTestRunner/config.h:
1379
1380 2011-12-01  Hayato Ito  <hayato@chromium.org>
1381
1382         Explicitly pass tolerance=0 to port.diff_image in case of RefTestMismatch failure.
1383         https://bugs.webkit.org/show_bug.cgi?id=73406
1384
1385         Reviewed by Ryosuke Niwa.
1386
1387         WebKitPort's image_diff uses tolerance='0.1' in default.
1388         When reftests fail, we should use tolerace=0 when diff-ing images.
1389
1390         Since ImageDiff on chromium port doesn't use tolerance value as of now,
1391         this change doesn't affect chromium port's behavior.
1392
1393         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1394         (write_test_result):
1395         * Scripts/webkitpy/layout_tests/port/base.py:
1396         (Port.diff_image):
1397         * Scripts/webkitpy/layout_tests/port/chromium.py:
1398         (ChromiumPort.diff_image):
1399         * Scripts/webkitpy/layout_tests/port/test.py:
1400         (TestPort.diff_image):
1401         * Scripts/webkitpy/layout_tests/port/webkit.py:
1402         (WebKitPort.diff_image):
1403         (WebKitPort._start_image_diff_process):
1404         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1405         (MainTest.test_tolerance.ImageDiffTestPort.diff_image):
1406
1407 2011-12-01  Adam Klein  <adamk@chromium.org>
1408
1409         Add Chromium ToT GTest build bots (and group selection support) to flakiness dashboard
1410         https://bugs.webkit.org/show_bug.cgi?id=73599
1411
1412         Reviewed by Ojan Vafai.
1413
1414         * TestResultServer/static-dashboards/builders.js:
1415         * TestResultServer/static-dashboards/dashboard_base.js:
1416         ():
1417         (htmlForTestTypeSwitcher):
1418         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
1419         (testHtmlForTestTypeSwitcherGroup):
1420
1421 2011-12-01  Ryosuke Niwa  <rniwa@webkit.org>
1422
1423         Parse reftest.list and extract types of ref tests
1424         https://bugs.webkit.org/show_bug.cgi?id=66837
1425
1426         Reviewed by Dirk Pranke.
1427
1428         Add support for reftest.list to base port.
1429
1430         * Scripts/webkitpy/common/find_files.py:
1431         (find):
1432         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1433         (SingleTestRunner.__init__):
1434         * Scripts/webkitpy/layout_tests/port/base.py:
1435         (Port.__init__): Initialize self._reftest_list. It's a dictionary mapping from a test directory
1436         to a dictionary of {test path: ("==" or "!=", reference file path)}
1437         (Port._get_reftest_list): Added; calls test_file.parse_reftest_list to fill self._reftest_list.
1438         (Port._reference_file_for): Added; obtains the reference file name given a test name.
1439         (Port.is_reftest): Added; Calls _reference_file_for.
1440         (Port.reftest_expected_filename): Calls _reference_file_for.
1441         (Port.reftest_expected_mismatch_filename): Ditto.
1442         (Port.find_test_files):
1443         (is_reference_html_file): Treat any file that starts with ref- or notref- or ends with
1444         -expected, -expected-mismach, -ref, or -notref as a reference file.
1445         (_is_test_file):
1446         (_parse_reftest_list): Added.
1447         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1448         (PortTest.test_is_test_file):
1449         (PortTest.test_parse_reftest_list):
1450         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1451         (DryrunDriver.run_test):
1452         * Scripts/webkitpy/layout_tests/port/test.py:
1453         (unit_test_filesystem.add_test_file):
1454         (unit_test_filesystem.add_file):
1455         (unit_test_filesystem):
1456         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1457         (get_tests_run.RecordingTestDriver.run_test):
1458         (MainTest.test_unexpected_failures):
1459         (MainTest.test_missing_and_unexpected_results):
1460         (EndToEndTest.test_end_to_end):
1461         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
1462         (Rebaseliner._compile_rebaselining_tests):
1463
1464 2011-12-01  Sheriff Bot  <webkit.review.bot@gmail.com>
1465
1466         Unreviewed, rolling out r101711.
1467         http://trac.webkit.org/changeset/101711
1468         https://bugs.webkit.org/show_bug.cgi?id=73605
1469
1470         Broke 3 webkitpy tests (Requested by rniwa on #webkit).
1471
1472         * Scripts/webkitpy/style/checker.py:
1473         (_all_categories):
1474         (FileType):
1475         (CheckerDispatcher._file_type):
1476         (CheckerDispatcher._create_checker):
1477         * Scripts/webkitpy/style/checker_unittest.py:
1478         (CheckerDispatcherDispatchTest.assert_checker_cpp):
1479         (CheckerDispatcherDispatchTest.test_cpp_paths):
1480         * Scripts/webkitpy/style/checkers/jsonchecker.py: Removed.
1481         * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py: Removed.
1482
1483 2011-12-01  Gustavo Noronha Silva  <gns@gnome.org>
1484
1485         Unreviewed. Add myself to GStreamer and WebKit2GTK+ watchlists.
1486
1487         * Scripts/webkitpy/common/config/watchlist:
1488
1489 2011-12-01  Martin Robinson  <mrobinson@igalia.com>
1490
1491         [GTK] Read fonts from the jhbuild root
1492         https://bugs.webkit.org/show_bug.cgi?id=73487
1493
1494         Reviewed by Gustavo Noronha Silva.
1495
1496         Read fonts from the jhbuild root instead of from the system. This will ensure
1497         that all testers use the same fonts instead of leaving this up to luck.
1498
1499         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1500         (initializeFonts): Load fonts from jhbuild root.
1501         * Scripts/webkitpy/layout_tests/port/gtk.py:
1502         (GtkPort.setup_environ_for_server): Pass an environment variable containing
1503         the path to the jhbuild root.
1504         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1505         (WTR::inititializeFontConfigSetting): Load fonts from the jhbuild root.
1506
1507 2011-12-01  Adam Roben  <aroben@apple.com>
1508
1509         Teach check-webkit-style how to check the syntax of JSON files
1510
1511         Fixes <http://webkit.org/b/73590> check-webkit-style doesn't flag JSON syntax errors
1512
1513         Reviewed by Darin Adler.
1514
1515         * Scripts/webkitpy/style/checker.py:
1516         (_all_categories): Added JSONChecker's categories to the set of all categories.
1517         (FileType): Added a JSON type. Incremented other types.
1518         (CheckerDispatcher._file_type): Use the JSON file type for .json files.
1519         (CheckerDispatcher._create_checker): Use a JSONChecker for JSON files.
1520
1521         * Scripts/webkitpy/style/checker_unittest.py:
1522         (CheckerDispatcherDispatchTest.assert_checker_json): Added this helper method.
1523         (CheckerDispatcherDispatchTest.test_json_paths): Added. Based on test_python_paths.
1524
1525         * Scripts/webkitpy/style/checkers/jsonchecker.py: Added. (I didn't name this just "json",
1526         which would have matched our other checkers, because I couldn't figure out how to call
1527         "json.loads" without hitting namespace conflicts.)
1528         (JSONChecker.__init__): Turn of line filtering so that we always check the whole file, not
1529         just the modified lines from a patch.
1530         (JSONChecker.check): Try to parse the lines as JSON. Mark an error if there was an
1531         exception.
1532         (JSONChecker.line_number_from_json_exception): Parse the json modules exception message to
1533         try to extract a line number.
1534
1535         * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py: Added.
1536         (MockErrorHandler.__init__):
1537         (MockErrorHandler.turn_off_line_filtering):
1538         (MockErrorHandler.__call__):
1539         Helper class. Copied from xml_unittest.py.
1540
1541         (JSONCheckerTest.test_line_number_from_json_exception): Test the
1542         line_number_from_json_exception helper method.
1543
1544         (JSONCheckerTest.assert_no_error):
1545         (JSONCheckerTest.assert_error):
1546         Helper methods to assert that we did or didn't get an error.
1547
1548         (JSONCheckerTest.mock_handle_style_error): Helper method.
1549
1550         (JSONCheckerTest.test_conflict_marker):
1551         (JSONCheckerTest.test_single_quote):
1552         (JSONCheckerTest.test_init):
1553         (JSONCheckerTest.test_missing_closing_brace):
1554         (JSONCheckerTest.test_no_error):
1555         Test various cases.
1556
1557 2011-12-01  Martin Robinson  <mrobinson@igalia.com>
1558
1559         [GTK] Add a helper function to find the current executable's path
1560         https://bugs.webkit.org/show_bug.cgi?id=73473
1561
1562         Reviewed by Gustavo Noronha Silva.
1563
1564         Update MiniBrowser to not pass the binary directory as an environment variable.
1565         This means that you can move the binaries around without it breaking.
1566
1567         * MiniBrowser/gtk/main.c:
1568         (main): No longer set the environment variable.
1569         * WebKitTestRunner/GNUmakefile.am: No longer add the directory path define.
1570         * WebKitTestRunner/gtk/main.cpp:  Ditto.
1571
1572 2011-12-01  Gustavo Noronha Silva  <gns@gnome.org>
1573
1574         Unreviewed. Fix bad file =(.
1575
1576         * gtk/jhbuild.modules:
1577         * Scripts/webkitdirs.pm:
1578         (runAutogenForAutotoolsProject):
1579
1580 2011-12-01  Gustavo Noronha Silva  <gns@gnome.org>
1581
1582         [GTK] Add freetype to our jhbuild setup
1583         https://bugs.webkit.org/show_bug.cgi?id=73488
1584
1585         Reviewed by Martin Robinson.
1586
1587         This adds the first library to our jhbuild setup, and makes sure
1588         build-webkit calls autogen.sh and make with jhbuild, so that the
1589         environment is properly set.
1590
1591         * Scripts/webkitdirs.pm:
1592         (saveSum):
1593         (hashFile):
1594         (runAutogenForAutotoolsProject): save md5sum of jhbuild-related files, and
1595         call autogen under jhbuild run;
1596         (mustRunAutogen): generalized the arguments change checking to also force
1597         running autogen when jhbuild files change;
1598         (buildAutotoolsProject): run make under jhbuild;
1599         * gtk/jhbuild.modules: add freetype.
1600
1601 2011-12-01  Dominic Mazzoni  <dmazzoni@google.com>
1602
1603         Fix WebKitTestRunner compile warnings with XCode 3.2
1604         https://bugs.webkit.org/show_bug.cgi?id=73378
1605
1606         Reviewed by Chris Fleizach.
1607
1608         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp:
1609         (WTR::AccessibilityTextMarker::AccessibilityTextMarker):
1610         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp:
1611         (WTR::AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
1612         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1613         (WTR::AccessibilityUIElement::AccessibilityUIElement):
1614         (WTR::AccessibilityUIElement::verticalScrollbar):
1615
1616 2011-12-01  Adam Roben  <aroben@apple.com>
1617
1618         Allow committers to use their Trac credentials to force builds on the buildbots
1619
1620         Fixes <http://webkit.org/b/73353>
1621
1622         A new class, CommitterAuth, handles authentication of WebKit committers. CommitterAuth uses
1623         three files to do its job: a config file that contains a list of WebKit committer usernames,
1624         an htdigest file that contains Trac credentials, and JSON file that gives the paths for
1625         those two files.
1626
1627         Reviewed by Darin Adler.
1628
1629         * BuildSlaveSupport/build.webkit.org-config/committer_auth.py: Added.
1630         (Error): Basic wrapper around Exception that we use for cases where we couldn't even check
1631         whether credentials were valid or not.
1632         (CommitterAuth.__init__): Just store the path to auth.json.
1633         (CommitterAuth.auth_json): Load, parse, and return auth.json.
1634         (CommitterAuth.auth_json_filename): Return the path to auth.json.
1635         (CommitterAuth.authenticate): Return true if the user is a WebKit committer and their
1636         credentials are valid Trac credentials. Return false otherwise or if an error occurred while
1637         checking those conditions.
1638         (CommitterAuth.is_webkit_committer): Return true if the user is a WebKit committer. Return
1639         false otherwise or if an exception was thrown.
1640         (CommitterAuth.is_webkit_trac_user): Return true if the username/password are present in the
1641         Trac credentials htdigest file. Return false otherwise or if an exception was thrown.
1642
1643         (CommitterAuth.open_auth_json_file):
1644         (CommitterAuth.open_trac_credentials_file):
1645         (CommitterAuth.open_webkit_committers_file):
1646         Open the specified file. These are mostly useful for testing purposes.
1647
1648         (CommitterAuth.trac_credentials_filename):
1649         (CommitterAuth.webkit_committers_filename):
1650         Return the path to the specified file by retrieving it from auth.json.
1651
1652         (CommitterAuth.webkit_committers): Load and parse the committers file and extract the list
1653         of WebKit committers from it.
1654
1655         * BuildSlaveSupport/build.webkit.org-config/committer_auth_unittest.py: Added.
1656         (CMStringIO.__enter__):
1657         (CMStringIO.__exit__):
1658         Helper class that makes it possible to use StringIO with the "with" statement.
1659
1660         (open_override): Helper context manager for overriding the global "open" function
1661         temporarily.
1662
1663         (CommitterAuthTest.setUp): Set up a somewhat-mocked CommitterAuth that is used by most
1664         tests.
1665         (CommitterAuthTest.fake_open_function): Returns a function that can be used in place of
1666         "open" to test that the expected path was opened.
1667         (CommitterAuthTest.test_authentication_success): Test that committers can authenticate
1668         successfully.
1669         (CommitterAuthTest.test_committer_without_trac_credentials_fails): Test that committers who
1670         somehow have no Trac account can't authenticate.
1671
1672         (CommitterAuthTest.test_fail_to_open_auth_json_file):
1673         (CommitterAuthTest.test_fail_to_open_trac_credentials_file):
1674         (CommitterAuthTest.test_fail_to_open_webkit_committers_file):
1675         Test what happens when we can't open the three files we depend upon.
1676
1677         (CommitterAuthTest.test_implements_IAuth): Test that we fulfill buildbot's expectations for
1678         an authentication class.
1679
1680         (CommitterAuthTest.test_invalid_auth_json_file):
1681         (CommitterAuthTest.test_invalid_committers_file):
1682         (CommitterAuthTest.test_invalid_trac_credentials_file):
1683         (CommitterAuthTest.test_missing_auth_json_keys):
1684         Test what happens when the three files we depend upon are invalid in some way.
1685
1686         (CommitterAuthTest.test_open_auth_json_file):
1687         (CommitterAuthTest.test_open_trac_credentials_file):
1688         (CommitterAuthTest.test_open_webkit_committers_file):
1689         Test that we open the expected paths.
1690
1691         (CommitterAuthTest.test_trac_credentials_filename):
1692         (CommitterAuthTest.test_webkit_committers_filename):
1693         Test that we extract filenames out of auth.json correctly.
1694
1695         (CommitterAuthTest.test_non_committer_fails):
1696         (CommitterAuthTest.test_unknown_user_fails):
1697         (CommitterAuthTest.test_username_is_prefix_of_valid_user):
1698         (CommitterAuthTest.test_wrong_password_fails):
1699         Test various failed authentication attempts.
1700
1701         (CommitterAuthTest.test_webkit_committers): Test that we can parse the list of WebKit
1702         committers out of the committers file correctly.
1703
1704         (CommitterAuthTest.fake_auth_json_file):
1705         (CommitterAuthTest.invalid_auth_json_file):
1706         (CommitterAuthTest.fake_committers_file):
1707         (CommitterAuthTest.invalid_committers_file):
1708         (CommitterAuthTest.fake_htdigest_file):
1709         (CommitterAuthTest.invalid_htdigest_file):
1710         Return various fake files for testing.
1711
1712         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Specify an instance of CommitterAuth
1713         to be used for authentication in the web interface, and specify that only authenticated
1714         users may force builds.
1715
1716 2011-12-01  Adam Roben  <aroben@apple.com>
1717
1718         Add an HTDigestParser class to webkitpy
1719
1720         Fixes <http://webkit.org/b/73575> webkitpy doesn't provide a way to parse htdigest files
1721
1722         This class can be used to parse Apache's htdigest files and check whether a given
1723         username/realm/password tuple is present in the file. Eventually this will be used for
1724         authenticating users on build.webkit.org (<http://webkit.org/b/73353>).
1725
1726         Reviewed by Eric Seidel.
1727
1728         * Scripts/webkitpy/common/net/htdigestparser.py: Added.
1729         (HTDigestParser.__init__): Stores the parsed representation of the file.
1730         (HTDigestParser.authenticate): Hashes the username/realm/password tuple to generate a hashed
1731         password and returns whether the resulting tuple is present in the file.
1732         (HTDigestParser.entries): Just returns the parsed representation of the file.
1733         (HTDigestParser.parse_file): Splits each line on colons and checks that each line has the
1734         expected syntax ('username:realm:hashed_password'). If any line is invalid, we treat the
1735         whole file as invalid and all authentication attempts will fail.
1736
1737         * Scripts/webkitpy/common/net/htdigestparser_unittest.py: Added.
1738         (HTDigestParserTest.assertEntriesEqual): Helper method to assert that fake_htdigest_file,
1739         optionally appended with some extra data, generates the expected entries.
1740         (HTDigestParserTest.test_authenticate): Tests that tuples present in the file can
1741         authenticate, and tuples not present cannot.
1742         (HTDigestParserTest.test_entries): Tests that we get the expected entries from
1743         fake_htdigest_file.
1744
1745         (HTDigestParserTest.test_empty_file):
1746         (HTDigestParserTest.test_too_few_colons):
1747         (HTDigestParserTest.test_too_many_colons):
1748         (HTDigestParserTest.test_invalid_hash):
1749         Test various forms of invalid files.
1750
1751         (HTDigestParserTest.fake_htdigest_file): Returns a fake valid htdigest file for testing.
1752
1753 2011-12-01  Philippe Normand  <pnormand@igalia.com>
1754
1755         [GTK] Make the new 64-bit Release bot part of the core set
1756         https://bugs.webkit.org/show_bug.cgi?id=73570
1757
1758         Reviewed by Adam Roben.
1759
1760         The 64-bit Release bot re-introduced in r101676 replaces the 64-bit
1761         Debug bot which was already part of the core set. The GTK
1762         gardeners are willing to actively maintain it.
1763
1764         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1765         (BuildBot.__init__):
1766         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1767         (test_builder_name_regexps):
1768
1769 2011-12-01  Philippe Normand  <pnormand@igalia.com>
1770
1771         [GTK] Buildslave switch from 32-bit Debug to 64-bit Release
1772         https://bugs.webkit.org/show_bug.cgi?id=73547
1773
1774         Reviewed by Adam Roben.
1775
1776         * BuildSlaveSupport/build.webkit.org-config/config.json: Rename
1777         the 32-bit Debug configuration to 64-bit Release. The new slave is
1778         a 64-bit machine already. The 32-bit slave will be shut down.
1779
1780 2011-12-01  Martin Robinson  <mrobinson@igalia.com>
1781
1782         [GTK] build-jsc should not trigger gtkdoc generation
1783         https://bugs.webkit.org/show_bug.cgi?id=73552
1784
1785         Reviewed by Philippe Normand.
1786
1787         Do not generate gtkdoc when building projects other than WebKit. In particular, this ensures
1788         that build-jsc does not try to generate gtkdoc.
1789
1790         * Scripts/webkitdirs.pm:
1791         (buildAutotoolsProject): Only generate gtkdoc if the project is "WebKit".
1792
1793 2011-12-01  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
1794
1795         tests_run0.txt gets clobbered when re-running failing tests
1796         https://bugs.webkit.org/show_bug.cgi?id=63844
1797
1798         Reviewed by Dirk Pranke.
1799
1800         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1801         (Manager.results_directory):
1802         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1803         (AbstractWorker.__init__):
1804         (_ManagerConnection.start_worker):
1805         (_InlineManager.start_worker):
1806         (_MultiProcessManager.start_worker):
1807         (_WorkerConnection.__init__):
1808         (_InlineWorkerConnection.__init__):
1809         (_MultiProcessWorkerConnection.__init__):
1810         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
1811         (_TestWorker.__init__):
1812         (_TestsMixin.test_cancel):
1813         (_TestsMixin.test_done):
1814         (_TestsMixin.test_unknown_message):
1815         (InterfaceTest.test_managerconnection_is_abstract):
1816         (InterfaceTest.test_workerconnection_is_abstract):
1817         * Scripts/webkitpy/layout_tests/controllers/worker.py:
1818         (Worker.__init__):
1819         (Worker.safe_init):
1820         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1821         (MainTest.test_retries_directory):
1822
1823 2011-12-01  Adam Roben  <aroben@apple.com>
1824
1825         Buildbot fix
1826
1827         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Moved all of the initialization of
1828         BuildmasterConfig not performed by loadBuilderConfig up to the top of the file. This makes
1829         it possible for build steps to reference things like the buildbotURL property of the config.
1830
1831 2011-11-30  Adam Roben  <aroben@apple.com>
1832
1833         Use curl for downloading builds to test slaves
1834
1835         Buildbot's built-in file transfer capabilities are transferring files much more slowly than
1836         curl does. This seems to be due to a combination of buildbot being single-threaded (and thus
1837         often busy servicing web requests, etc.) and using an IPC mechanism with fairly high
1838         overhead (courtesy of the Twisted framework).
1839
1840         Eventually we'd like to make Buildbot's built-in transferring more efficient. In the
1841         meantime we'll try using curl for downloads and keep thinking about a solution for uploads.
1842         This should make the test slaves quite a bit faster, and should ease the CPU load on
1843         build.webkit.org a bit.
1844
1845         Part of <http://webkit.org/b/73484> Mac slaves take 7+ minutes to upload or download a build
1846
1847         Reviewed by Mark Rowe.
1848
1849         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added the CreateWebKitBuildDirectory
1850         to Test slaves. It's run just before DownloadBuiltProduct.
1851         (DownloadBuiltProduct): Changed to be a normal ShellCommand that invokes curl to perform the
1852         download.
1853         (CreateWebKitBuildDirectory): Added. Creates the WebKitBuild directory on a slave.
1854         FileDownload used to do this for us automatically.
1855
1856 2011-11-21  Philippe Normand  <pnormand@igalia.com>
1857
1858         [GTK] enable-webaudio websetting
1859         https://bugs.webkit.org/show_bug.cgi?id=69836
1860
1861         Reviewed by Martin Robinson.
1862
1863         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1864         (LayoutTestController::overridePreference): Update WebKitGTK
1865         enable-webaudio setting when a layout test requests it.
1866
1867 2011-11-30  Ilya Tikhonovsky  <loislo@chromium.org>
1868
1869         Web Inspector: chromium: I'd like to add a script for running perf tests for WebInspector.
1870         https://bugs.webkit.org/show_bug.cgi?id=73079
1871
1872         The idea is to have performance tests for WebInspector.
1873         I was suggested to put these tests into PerformanceTests/inspector.
1874         They produce output in a format that is suitable for chromium perf bot drawing scripts.
1875
1876         I'd like to reuse code for scanning folders for test files.
1877         Because of the fact that original test_files.py has common and layout specific parts
1878         I decided to extract the generic part and put it into webkitpy/common
1879         I think the two packages with name test_files look strange but I have no idea about a better name.
1880
1881         Reviewed by Dirk Pranke.
1882
1883         * Scripts/run-inspector-perf-tests.py: Added.
1884         * Scripts/webkitpy/common/find_files.py: Renamed from Tools/Scripts/webkitpy/layout_tests/port/test_files.py.
1885         (find):
1886         (_normalize):
1887         * Scripts/webkitpy/common/find_files_unittest.py: Added.
1888         (MockWinFileSystem.join):
1889         (MockWinFileSystem):
1890         (MockWinFileSystem.normpath):
1891         (TestWinNormalize.assert_filesystem_normalizes):
1892         (TestWinNormalize.test_mocked_win):
1893         (TestWinNormalize):
1894         (TestWinNormalize.test_win):
1895         * Scripts/webkitpy/layout_tests/port/base.py:
1896         (Port.tests):
1897         (Port.find_test_files):
1898         (Port._driver_class):
1899         (is_reference_html_file):
1900         (_has_supported_extension):
1901         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1902         (PortTest.test_find_no_paths_specified):
1903         (PortTest.test_find_one_test):
1904         (PortTest.test_find_glob):
1905         (PortTest.test_find_with_skipped_directories):
1906         (PortTest.test_find_with_skipped_directories_2):
1907         (PortTest):
1908         (PortTest.test_is_test_file):
1909         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1910         (_tests):
1911         * Scripts/webkitpy/layout_tests/port/test.py:
1912         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py: Removed.
1913         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1914         * Scripts/webkitpy/performance_tests/__init__.py: Added.
1915         * Scripts/webkitpy/performance_tests/perftestsrunner.py: Added.
1916         (PerfTestsRunner.__init__):
1917         (PerfTestsRunner._parse_args):
1918         (PerfTestsRunner._collect_tests._is_test_file):
1919         (PerfTestsRunner._collect_tests):
1920         (PerfTestsRunner.run):
1921         (PerfTestsRunner._run_tests_set):
1922         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py: Added.
1923         (MainTest.TestPort):
1924         (MainTest.TestPort.create_driver):
1925         (MainTest.TestDriver.run_test):
1926         (MainTest.TestDriver):
1927         (MainTest.TestDriver.stop):
1928         (MainTest.create_runner):
1929         (MainTest.run_test):
1930         (MainTest.test_run_passing_test):
1931         (MainTest.test_run_silent_test):
1932         (MainTest.test_run_failed_test):
1933         (MainTest.test_run_tonguey_test):
1934         (MainTest.test_run_timeout_test):
1935         (MainTest.test_run_crash_test):
1936         (MainTest.test_run_test_set):
1937         (MainTest.test_collect_tests):
1938         (MainTest):
1939         (MainTest.test_parse_args):
1940         * Scripts/webkitpy/tool/commands/rebaseline.py:
1941         (OptimizeBaselines.execute):
1942         (AnalyzeBaselines.execute):
1943
1944 2011-11-30  nduca@chromium.org  <nduca@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
1945
1946         [chromium] Enable threaded compositing via CCThreadProxy::hasThread only
1947         https://bugs.webkit.org/show_bug.cgi?id=70838
1948
1949         Reviewed by James Robinson.
1950
1951         * DumpRenderTree/chromium/TestShell.cpp:
1952         (TestShell::resetWebSettings):
1953         * DumpRenderTree/chromium/TestShell.h:
1954         (TestShell::threadedCompositingEnabled):
1955         * DumpRenderTree/chromium/WebPreferences.cpp:
1956         (WebPreferences::reset):
1957         (WebPreferences::applyTo):
1958         * DumpRenderTree/chromium/WebPreferences.h:
1959         * DumpRenderTree/chromium/WebViewHost.cpp:
1960         (WebViewHost::WebViewHost):
1961         (WebViewHost::~WebViewHost):
1962
1963 2011-11-30  Chris Fleizach  <cfleizach@apple.com>
1964
1965         AX: Nodes are reporting that focus can be set when they really can't
1966         https://bugs.webkit.org/show_bug.cgi?id=72791
1967
1968         Reviewed by Beth Dakin.
1969
1970         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1971         (AccessibilityUIElement::isFocusable):
1972         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1973         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1974         (WTR::AccessibilityUIElement::isFocusable):
1975
1976 2011-11-30  Alejandro G. Castro  <alex@igalia.com>
1977
1978         Moved myself to the reviewers list.
1979
1980         * Scripts/webkitpy/common/config/committers.py:
1981
1982 2011-11-30  David Levin  <levin@chromium.org>
1983
1984         [chromium] Move didUpdateLayout from WebFrameClient to WebViewClient.
1985         https://bugs.webkit.org/show_bug.cgi?id=73415
1986
1987         Reviewed by Darin Fisher.
1988
1989         * DumpRenderTree/chromium/WebViewHost.cpp:
1990         (WebViewHost::didUpdateLayout): Move didUpdateLayout to account for
1991         it being moved to a new interface and having the parameter removed.
1992         * DumpRenderTree/chromium/WebViewHost.h: Ditto.
1993
1994 2011-11-30  Adam Roben  <aroben@apple.com>
1995
1996         Make NRWT show DRT/WTR build logs when the build fails or --verbose is passed
1997
1998         This will make it a lot easier to investigate build failures on the bots.
1999
2000         Fixes <http://webkit.org/b/71160> NRWT doesn't show build output when building DRT
2001
2002         Reviewed by Eric Seidel.
2003
2004         * Scripts/webkitpy/common/system/executive_mock.py:
2005         (MockExecutive.run_command): Include the mock output in the ScriptError we raise since it
2006         makes the expected output in WebKitPortTest.test_build_driver more closely mimic the output
2007         seen in practice.
2008
2009         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2010         (ManagerTest.test_http_locking): Pass False for the configure_logging parameter to Printer.
2011         The Printer was modifying the root logger in way that would cause my new tests in
2012         WebKitPort.test_build_driver to fail. The value of the configure_logging parameter doesn't
2013         seem important to the functioning of this test, and passing False makes Printer not modify
2014         the root logger.
2015
2016         * Scripts/webkitpy/layout_tests/port/webkit.py:
2017         (WebKitPort._run_script): Log the output of the command at the DEBUG level so it will show
2018         up when --verbose is passed but not otherwise.
2019         (WebKitPort._build_driver): When an error occurs, log the error message and the script's
2020         output at the ERROR level so it will always show up.
2021
2022         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2023         (WebKitPortTest.test_build_driver): Test that nothing is logged in the normal, successful
2024         cases. Test that the build scripts' output is logged when --verbose is passed or the build
2025         fails.
2026
2027 2011-11-30  Adam Roben  <aroben@apple.com>
2028
2029         Add a way to set OutputCapture's log level
2030
2031         This will be used by some unit tests I'm planning to add.
2032
2033         Fixes <http://webkit.org/b/73469> OutputCapture can't be used to capture DEBUG messages
2034
2035         Reviewed by Eric Seidel.
2036
2037         * Scripts/webkitpy/common/system/outputcapture.py:
2038         (OutputCapture.__init__): Initialize our internal logging level to INFO, which was the only
2039         level we ever used before this patch.
2040         (OutputCapture.set_log_level): Added. This is useful for testing what log level code that is
2041         being tested uses. Sets the log level for any current or future logging handlers.
2042         (OutputCapture.capture_output): Use our internal logging level instead of always using INFO.
2043
2044         * Scripts/webkitpy/common/system/outputcapture_unittest.py: Added.
2045         (OutputCaptureTest.setUp): Create an OutputCapture to test.
2046         (OutputCaptureTest.log_all_levels): Helper method to log a message at each log level.
2047         (OutputCaptureTest.assertLogged): Helper method to assert that a particular set of strings
2048         was logged.
2049         (OutputCaptureTest.test_initial_log_level): Test that we start out at the INFO level.
2050         (OutputCaptureTest.test_set_log_level): Test that set_log_level correctly modifies the log
2051         level.
2052
2053 2011-11-29  Beth Dakin  <bdakin@apple.com>
2054
2055         https://bugs.webkit.org/show_bug.cgi?id=72751
2056         WebKit2.MouseMoveAfterCrash API test is failing 
2057
2058         Reviewed by Sam Weinig.
2059
2060         Like DumpRenderTree, the NSWindow should act as an active window.
2061         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2062         (-[ActiveOffscreenWindow isKeyWindow]):
2063         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2064
2065 2011-11-30  Gustavo Noronha Silva  <gns@gnome.org>
2066
2067         Add step to update gtk dependencies to the buildbot
2068         https://bugs.webkit.org/show_bug.cgi?id=73455
2069
2070         Reviewed by Martin Robinson.
2071
2072         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2073
2074 2011-11-30  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2075
2076         [Qt] Add a fullscreen option to MiniBrowser.
2077         https://bugs.webkit.org/show_bug.cgi?id=73445
2078
2079         Reviewed by Noam Rosenthal.
2080
2081         This bypasses the compositor on the N9 to increase performances
2082         and remove the huge useless gray bar part of the window frame
2083         at the bottom.
2084
2085         * MiniBrowser/qt/BrowserWindow.cpp:
2086         (BrowserWindow::BrowserWindow):
2087         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2088         (printHelp):
2089         (MiniBrowserApplication::handleUserOptions):
2090         * MiniBrowser/qt/MiniBrowserApplication.h:
2091         (WindowOptions::setStartFullScreen):
2092         (WindowOptions::startFullScreen):
2093
2094 2011-11-30  Martin Robinson  <mrobinson@igalia.com>
2095
2096         [GTK] Add an initial jhbuild setup which installs fonts into the WebKitBuild
2097         https://bugs.webkit.org/show_bug.cgi?id=73425
2098
2099         Reviewed by Gustavo Noronha Silva.
2100
2101         Add initial jhbuild support to the GTK+ port. update-webkitgtk-libs will
2102         ensure that the jhbuild root is up-to-date. Currently the only module is
2103         the font module.
2104
2105         * Scripts/update-webkitgtk-libs: Added.
2106         * gtk/common.py: Added a helper to get the number of CPUs.
2107         * gtk/jhbuild.modules: Added.
2108         * gtk/jhbuildrc: Added.
2109
2110 2011-11-30  Simon Hausmann  <simon.hausmann@nokia.com>
2111
2112         [Qt] Remove dependency of Qt DRT on JavaScriptCore.
2113
2114         Reviewed by Csaba Osztrogonác.
2115
2116         * DumpRenderTree/WorkQueue.cpp: Include the correct header file we're using anyway,
2117         instead of one that pulls in JavaScriptCore headers.
2118         * DumpRenderTree/qt/DumpRenderTree.pro: There's no need to pull in the JSC headers
2119         with load(javascriptcore).
2120
2121 2011-11-30  Sheriff Bot  <webkit.review.bot@gmail.com>
2122
2123         Unreviewed, rolling out r101440 and r101442.
2124         http://trac.webkit.org/changeset/101440
2125         http://trac.webkit.org/changeset/101442
2126         https://bugs.webkit.org/show_bug.cgi?id=73429
2127
2128         multiple crashes on layout tests (Requested by hayato on
2129         #webkit).
2130
2131         * DumpRenderTree/chromium/TestShell.cpp:
2132         (TestShell::resetWebSettings):
2133         * DumpRenderTree/chromium/TestShell.h:
2134         * DumpRenderTree/chromium/WebPreferences.cpp:
2135         (WebPreferences::reset):
2136         (WebPreferences::applyTo):
2137         * DumpRenderTree/chromium/WebPreferences.h:
2138         * DumpRenderTree/chromium/WebViewHost.cpp:
2139         (WebViewHost::WebViewHost):
2140         (WebViewHost::~WebViewHost):
2141
2142 2011-11-30  Fady Samuel  <fsamuel@chromium.org>
2143
2144         [Chromium] Fix broken DRT build for Aura Linux
2145         https://bugs.webkit.org/show_bug.cgi?id=72667
2146
2147         Reviewed by Tony Chang.
2148
2149         DRT now builds for Aura Linux. This, more or less, shares the same code as Android.
2150
2151         The following changes have been made:
2152
2153           1. Renamed TestShellAndroid to TestShellLinux.
2154           2. Stub code moved added in TestShellStub that will only compile on non-GTK Linux builds.
2155           3. Code common to Gtk, Aura, and Android moved to TestShellLinux.
2156
2157         * DumpRenderTree/DumpRenderTree.gypi:
2158         * DumpRenderTree/chromium/EventSender.cpp:
2159         (EventSender::keyDown):
2160         * DumpRenderTree/chromium/TestShellAndroid.cpp: Removed.
2161         * DumpRenderTree/chromium/TestShellGtk.cpp:
2162         * DumpRenderTree/chromium/TestShellLinux.cpp: Copied from Tools/DumpRenderTree/chromium/TestShellGtk.cpp.
2163         (AlarmHandler):
2164         (TestShell::waitTestFinished):
2165         (setupFontconfig):
2166         (platformInit):
2167         * DumpRenderTree/chromium/TestShellStub.cpp: Added.
2168         (checkLayoutTestSystemDependencies):
2169         (openStartupDialog):
2170
2171 2011-11-30  Fady Samuel  <fsamuel@chromium.org>
2172
2173         [Chromium] Set Result Before Early Exit for Fixed Layout Methods in LayoutTestController
2174         https://bugs.webkit.org/show_bug.cgi?id=73328
2175
2176         Reviewed by Kent Tamura.
2177
2178         * DumpRenderTree/chromium/LayoutTestController.cpp:
2179         (LayoutTestController::enableFixedLayoutMode):
2180         (LayoutTestController::setFixedLayoutSize):
2181
2182 2011-11-29  Hayato Ito  <hayato@chromium.org>
2183
2184         Skip writing the result of diff_image since non-chromium ports don't implement diff_image.
2185         https://bugs.webkit.org/show_bug.cgi?id=73381
2186
2187         Reviewed by Ryosuke Niwa.
2188
2189         This is a quick fix for the breakage of tests on non-chromium port.
2190         We should implement diff_image later on non-chromium ports.
2191
2192         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2193         (write_test_result):
2194
2195 2011-11-29  Balazs Ankes  <Ankes.Balazs@stud.u-szeged.hu>
2196
2197         [NRWT] Fix --platform=qt-5.0 --new-baseline combo
2198         https://bugs.webkit.org/show_bug.cgi?id=72489
2199
2200         Reviewed by Eric Seidel.
2201
2202         Before the this fix always added "qt" option for the option list
2203         * Scripts/run-webkit-tests:
2204         * Scripts/webkitpy/layout_tests/port/qt.py:
2205
2206 2011-11-29  David Levin  <levin@chromium.org>
2207
2208         Add a way to revert a variable to its previous value after leaving a scope.
2209         https://bugs.webkit.org/show_bug.cgi?id=73371
2210
2211         Reviewed by Adam Barth.
2212
2213         * DumpRenderTree/ForwardingHeaders/wtf/TemporarilyChange.h: Added.
2214         * TestWebKitAPI/TestWebKitAPI.gypi: Added test file to the build.
2215         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
2216         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Ditto.
2217         * TestWebKitAPI/Tests/WTF/TemporarilyChange.cpp: Added.
2218         (TestWebKitAPI::TEST): Added a test for TemporarilyChange.
2219
2220 2011-11-28  Kentaro Hara  <haraken@chromium.org>
2221
2222         Implement [Supplemental] IDL and support it in run-bindings-tests
2223         https://bugs.webkit.org/show_bug.cgi?id=73162
2224
2225         Reviewed by Adam Barth.
2226
2227         run-bindings-tests supports the [Supplemental] IDL in the following way.
2228             (1) It creates a file |x| listing all IDL files.
2229             (2) It generates a supplemental dependency file |y| using resolve-supplemental.pl and |x|.
2230             (3) For each IDL file |z|, it runs generate-bindings.pl with |y|.
2231                 Then, generate-bindings.pl generates .h and .cpp files for the IDL file |z|,
2232                 including all attributes in IDL files that are supplementing the IDL file |z|.
2233
2234         * Scripts/run-bindings-tests:
2235         (generate_from_idl):
2236         (generate_supplemental_dependency):
2237         (detect_changes):
2238         (run_tests):
2239         (main):
2240
2241 2011-11-18  Nat Duca  <nduca@chromium.org>
2242
2243         [chromium] Enable threaded compositing via CCThreadProxy::hasThread only
2244         https://bugs.webkit.org/show_bug.cgi?id=70838
2245
2246         Reviewed by James Robinson.
2247
2248         * DumpRenderTree/chromium/TestShell.cpp:
2249         (TestShell::resetWebSettings):
2250         * DumpRenderTree/chromium/TestShell.h:
2251         (TestShell::threadedCompositingEnabled):
2252         * DumpRenderTree/chromium/WebPreferences.cpp:
2253         (WebPreferences::reset):
2254         (WebPreferences::applyTo):
2255         * DumpRenderTree/chromium/WebPreferences.h:
2256         * DumpRenderTree/chromium/WebViewHost.cpp:
2257         (WebViewHost::WebViewHost):
2258         (WebViewHost::~WebViewHost):
2259
2260 2011-11-29  Ojan Vafai  <ojan@chromium.org>
2261
2262         List of builders in the flakiness dashboard is out of date
2263         https://bugs.webkit.org/show_bug.cgi?id=73347
2264
2265         Reviewed by Adam Barth.
2266
2267         The chromium gpu bots no longer run layout tests, so kill that
2268         group entirely.
2269
2270         * TestResultServer/static-dashboards/builders.js:
2271         * TestResultServer/static-dashboards/dashboard_base.js:
2272
2273 2011-11-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2274
2275         [Qt] Don't hard-code the list of WebKit2 generated sources
2276
2277         The generated sources are... wait for it... generated. So
2278         use the generator itself to figure out which sources we need
2279         to compile.
2280
2281         Reviewed by Simon Hausmann.
2282
2283         * qmake/mkspecs/features/default_post.prf:
2284
2285 2011-11-29  Martin Robinson  <mrobinson@igalia.com>
2286
2287         [GTK] Add a method to detect 'make dist' errors without running 'make dist'
2288         https://bugs.webkit.org/show_bug.cgi?id=73216
2289
2290         Reviewed by Philippe Normand.
2291
2292         Add a script that tries to sniff out 'make dist' problems without running
2293         'make dist.' 'make distcheck' takes a very long time to run and this should
2294         reduce the amount of times it needs to be run consecutively.
2295
2296         * gtk/common.py:
2297         (get_build_path.is_valid_build_directory): Guess the source directory
2298         by the existence of the GNUmakefile instead of the .libs directory. This
2299         allows one to run the script after running autogen.sh but before fully
2300         building.
2301         * gtk/find-make-dist-errors: Added.
2302
2303 2011-11-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2304
2305         [Qt] Remove use of internal headers in the MiniBrowser
2306
2307         Reviewed by Simon Hausmann.
2308
2309         * MiniBrowser/qt/MiniBrowser.pro:
2310
2311 2011-11-29  Simon Hausmann  <simon.hausmann@nokia.com>
2312
2313         [Qt] Fix debug-shlib build without webkit2
2314
2315         Reviewed by Tor Arne Vestbø.
2316
2317         * qmake/mkspecs/features/qtwebkit.prf: Respect no_webkit2.
2318
2319 2011-11-28  Csaba Osztrogonác  <ossy@webkit.org>
2320
2321         [Qt][WK2] Unreviewed buildfix after r101307.
2322
2323         * qmake/mkspecs/features/webkit2.prf: Add missing includepath.
2324
2325 2011-11-29  Roland Steiner  <rolandsteiner@chromium.org>
2326
2327         <style scoped>: add ENABLE(STYLE_SCOPED) flag to WebKit
2328         https://bugs.webkit.org/show_bug.cgi?id=72848
2329
2330         Add option to build-webkit.
2331
2332         Reviewed by Dimitri Glazkov.
2333
2334         * Scripts/build-webkit:
2335
2336 2011-11-28  Ojan Vafai  <ojan@chromium.org>
2337
2338         gtest normalization in the test results server is sometimes wrong
2339         https://bugs.webkit.org/show_bug.cgi?id=73262
2340
2341         Reviewed by Tony Chang.
2342
2343         If a gtest has it's modified changed (e.g. add FLAKY_) then it will have two
2344         entries in the incremental JSON, one of the entries will have the correct data
2345         from the run and the other will have dummy no-data values. Make sure to
2346         always pick the one with real data.
2347
2348         * TestResultServer/model/jsonresults.py:
2349         (JsonResults._remove_gtest_modifiers):
2350         * TestResultServer/model/jsonresults_unittest.py:
2351         (JsonResultsTest.test_remove_gtest_modifiers):
2352
2353 2011-11-28  Ojan Vafai  <ojan@chromium.org>
2354
2355         Some of the results.json files have results/times entries at the directory level
2356         https://bugs.webkit.org/show_bug.cgi?id=73261
2357
2358         Reviewed by Tony Chang.
2359
2360         This is just a bug that got introduced in a temporary push of the results server.
2361         This patch repairs the broken files. After all the bots have cycled, we can simplify
2362         this code to just assert that results/times are not at the directory level.
2363
2364         Also, when catching exceptions, log the full stacktrace.
2365
2366         * TestResultServer/model/jsonresults.py:
2367         (_is_directory):
2368         (JsonResults._load_json):
2369         (JsonResults._merge_tests):
2370         (JsonResults.merge):
2371         * TestResultServer/model/jsonresults_unittest.py:
2372         (JsonResultsTest.test_merge_directory_hierarchy_extra_results_and_times):
2373
2374 2011-11-28  Tony Chang  <tony@chromium.org>
2375
2376         ews bots should pass --force to update-webkit-chromium
2377         https://bugs.webkit.org/show_bug.cgi?id=73230
2378
2379         Reviewed by Adam Barth.
2380
2381         This makes it less likely for gclient changes to break the bots (e.g.,
2382         if a DEPS repository moves or is switched to a branch).
2383
2384         Also pass --force when using |build-webkit --update-chromium| since this
2385         appears to only be used by the bots.
2386
2387         Take 2: Add Options.non_interactive to update.py's options() method.
2388
2389         * Scripts/update-webkit:
2390         * Scripts/webkitdirs.pm:
2391         (determineIsChromium): Add --force-update to update-webkit --chromium.
2392         (forceChromiumUpdate):
2393         (buildChromium): Pass --force to update-webkit-chromium.
2394         * Scripts/webkitpy/tool/steps/update.py:
2395         (Update.run): Add --force-update if non-interactive (i.e., bots).
2396         * Scripts/webkitpy/tool/steps/update_unittest.py:
2397
2398 2011-11-28  Tony Chang  <tony@chromium.org>
2399
2400         Revert r101279, broke the ews and cq bots.
2401
2402         * Scripts/update-webkit:
2403         * Scripts/webkitdirs.pm:
2404         (determineIsChromium):
2405         (buildChromium):
2406         * Scripts/webkitpy/common/config/ports.py:
2407         (WebKitPort.update_webkit_command):
2408         (ChromiumPort.update_webkit_command):
2409         * Scripts/webkitpy/common/config/ports_mock.py:
2410         (MockPort.update_webkit_command):
2411         * Scripts/webkitpy/tool/steps/update.py:
2412         * Scripts/webkitpy/tool/steps/update_unittest.py: Removed.
2413
2414 2011-11-28  Ojan Vafai  <ojan@chromium.org>
2415
2416         testlistjson on the test results server doesn't understand hierarchical results format
2417         https://bugs.webkit.org/show_bug.cgi?id=73246
2418
2419         Reviewed by Tony Chang.
2420
2421         * TestResultServer/model/jsonresults.py:
2422         (JsonResults._delete_results_and_times):
2423         Instead of just getting the top-level keys, we now walk the tests tree and
2424         delete the results and times values.
2425
2426         * TestResultServer/model/jsonresults_unittest.py:
2427         Simplify the test harness to take in the same JSON format for the tests
2428         that the actual results.json uses instead of something very similar but
2429         needlessly different. This also allows for testing the broken case of
2430         results and times values being at non-leaf level.
2431
2432 2011-11-28  Tony Chang  <tony@chromium.org>
2433
2434         ews bots should pass --force to update-webkit-chromium
2435         https://bugs.webkit.org/show_bug.cgi?id=73230
2436
2437         Reviewed by Adam Barth.
2438
2439         This makes it less likely for gclient changes to break the bots (e.g.,
2440         if a DEPS repository moves or is switched to a branch).
2441
2442         Also pass --force when using |build-webkit --update-chromium| since this
2443         appears to only be used by the bots.
2444
2445         * Scripts/update-webkit:
2446         * Scripts/webkitdirs.pm:
2447         (determineIsChromium): Add --force-update to update-webkit --chromium.
2448         (forceChromiumUpdate):
2449         (buildChromium): Pass --force to update-webkit-chromium.
2450         * Scripts/webkitpy/tool/steps/update.py:
2451         (Update.run): Add --force-update if non-interactive (i.e., bots).
2452         * Scripts/webkitpy/tool/steps/update_unittest.py:
2453
2454 2011-11-28  Michael Saboff  <msaboff@apple.com>
2455
2456         Fixed help message for --exclude-kraken to say that
2457         it excludes Kraken and not SunSpider.
2458
2459         Rubber-stamped by Filip Pizlo.
2460
2461         * Scripts/bencher:
2462
2463 2011-11-28  Sheriff Bot  <webkit.review.bot@gmail.com>
2464
2465         Unreviewed, rolling out r101273.
2466         http://trac.webkit.org/changeset/101273
2467         https://bugs.webkit.org/show_bug.cgi?id=73244
2468
2469         multiple test failures and timeouts (Requested by tony^work on
2470         #webkit).
2471
2472         * DumpRenderTree/DumpRenderTree.gypi:
2473         * DumpRenderTree/chromium/EventSender.cpp:
2474         (EventSender::keyDown):
2475         * DumpRenderTree/chromium/TestShellAndroid.cpp: Copied from Tools/DumpRenderTree/chromium/TestShellGtk.cpp.
2476         (AlarmHandler):
2477         (TestShell::waitTestFinished):
2478         (platformInit):
2479         (openStartupDialog):
2480         (checkLayoutTestSystemDependencies):
2481         * DumpRenderTree/chromium/TestShellGtk.cpp:
2482         (AlarmHandler):
2483         (setupFontconfig):
2484         (TestShell::waitTestFinished):
2485         (platformInit):
2486         * DumpRenderTree/chromium/TestShellLinux.cpp: Removed.
2487         * DumpRenderTree/chromium/TestShellStub.cpp: Removed.
2488
2489 2011-11-28  John Yani  <vanuan@gmail.com>
2490
2491         new-run-webkit-tests is locale dependent
2492         https://bugs.webkit.org/show_bug.cgi?id=68691
2493
2494         Reviewed and modified by Eric Seidel.
2495
2496         This is a simpler version of John's patch which I'm landing.
2497         This just engages the hacks from the Host constructor on a global
2498         basis.
2499
2500         * Scripts/webkitpy/common/host.py:
2501         (Host.__init__):
2502         (Host._engage_awesome_locale_hacks):
2503
2504 2011-11-28  Fady Samuel  <fsamuel@chromium.org>
2505
2506         [Chromium] Fix broken DRT build for Aura Linux
2507         https://bugs.webkit.org/show_bug.cgi?id=72667
2508
2509         Reviewed by Tony Chang.
2510
2511         DRT now builds for Aura Linux. This, more or less, shares the same code as Android.
2512
2513         The following changes have been made:
2514
2515           1. Renamed TestShellAndroid to TestShellLinux.
2516           2. Stub code moved added in TestShellStub that will only compile on non-GTK Linux builds.
2517           3. Code common to Gtk, Aura, and Android moved to TestShellLinux.
2518
2519         * DumpRenderTree/DumpRenderTree.gypi:
2520         * DumpRenderTree/chromium/EventSender.cpp:
2521         (EventSender::keyDown):
2522         * DumpRenderTree/chromium/TestShellAndroid.cpp: Removed.
2523         * DumpRenderTree/chromium/TestShellGtk.cpp:
2524         * DumpRenderTree/chromium/TestShellLinux.cpp: Copied from Tools/DumpRenderTree/chromium/TestShellGtk.cpp.
2525         (AlarmHandler):
2526         (TestShell::waitTestFinished):
2527         (setupFontconfig):
2528         (platformInit):
2529         * DumpRenderTree/chromium/TestShellStub.cpp: Added.
2530         (checkLayoutTestSystemDependencies):
2531         (openStartupDialog):
2532
2533 2011-11-28  Eric Seidel  <eric@webkit.org>
2534
2535         Add Environment object to Host and fix the GCC smartquotes trouble seen on the commit-queue
2536         https://bugs.webkit.org/show_bug.cgi?id=71983
2537
2538         Reviewed by Adam Barth.
2539
2540         We'll add more code to Environment overtime,
2541         allowing us to mock out more of our direct interactions with os.environ.
2542
2543         This patch also makes run_command print the passed in environment.
2544
2545         * Scripts/webkitpy/common/host_mock.py:
2546         * Scripts/webkitpy/common/system/environment.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
2547         * Scripts/webkitpy/common/system/environment_mock.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
2548         * Scripts/webkitpy/common/system/environment_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
2549         * Scripts/webkitpy/common/system/executive.py:
2550         * Scripts/webkitpy/common/system/executive_mock.py:
2551         * Scripts/webkitpy/layout_tests/port/webkit.py:
2552         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2553         * Scripts/webkitpy/tool/commands/download_unittest.py:
2554         * Scripts/webkitpy/tool/steps/build.py:
2555
2556 2011-11-28  Simon Hausmann  <simon.hausmann@nokia.com>
2557
2558         [Qt] Build system fixes against V8.
2559
2560         Reviewed by Tor Arne Vestbø.
2561
2562         * qmake/mkspecs/features/webcore.prf: Get rid of old v8 cruft.
2563         * qmake/mkspecs/features/wtf.prf: If requested, pull in v8 from Qt and configure
2564         WTF accordingly to use v8. (WTF in the implementation needs it as well as users of WTF)
2565
2566 2011-11-28  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2567
2568         Make sure the useFixedLayout feature is consistently handled
2569         https://bugs.webkit.org/show_bug.cgi?id=73212
2570
2571         Reviewed by Simon Hausmann.
2572
2573         The web page parameters are set to our Qt defaults and are now altered
2574         in the WebKitTestRunner.
2575
2576         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2577         (WTR::WrapperWindow::WrapperWindow):
2578
2579 2011-11-28  Simon Hausmann  <simon.hausmann@nokia.com>
2580
2581         [Qt] WTF should be built as separate static library
2582         https://bugs.webkit.org/show_bug.cgi?id=73201
2583
2584         Reviewed by Tor Arne Vestbø.
2585
2586         * DumpRenderTree/qt/DumpRenderTree.pro: Require wtf.
2587         * MiniBrowser/qt/BrowserWindow.cpp: Remove unnecessary config.h inclusion and
2588         thus wtf dependency.
2589         * WebKitTestRunner/InjectedBundle/Target.pri: Require wtf.
2590         * WebKitTestRunner/Target.pri: Ditto.
2591         * qmake/mkspecs/features/default_post.prf: When re-ordering the static libs
2592         consider wtf, too.
2593         * qmake/mkspecs/features/javascriptcore.prf: Remove WTF specific build stuff,
2594         moved into wtf.prf.
2595         * qmake/mkspecs/features/qtwebkit.prf: For debug builds with shared libs, also
2596         link in libwtf.
2597         * qmake/mkspecs/features/wtf.prf: Added. Stuff needed for building and using WTF.
2598
2599 2011-11-28  Kentaro Hara  <haraken@chromium.org>
2600
2601         run-bindings-tests shows diff error for a newly added binding test
2602         https://bugs.webkit.org/show_bug.cgi?id=73179
2603
2604         Reviewed by Adam Barth.
2605
2606         Currently, when we add a new binding test, say bindings/scripts/test/TestSupplemental.idl,
2607         run-bindings-tests just shows diff error because reference files
2608         (i.e. {V8,JS,...}TestSupplemental.h and {V8,JS,...}TestSupplemental.cpp) do not yet exist:
2609
2610             FAIL: (V8) V8TestSupplemental.h
2611             diff: WebCore/bindings/scripts/test/V8/V8TestSupplemental.h: No such file or directory
2612
2613         Instead, this patch treats a non-existent reference file as an empty file and
2614         shows the result of the newly added binding test, like this:
2615
2616             FAIL: (V8) V8TestSupplemental.h
2617             --- WebCore/bindings/scripts/test/V8/V8TestSupplemental.h       1970-01-01 09:00:00.000000000 +0900
2618             +++ /tmp/tmpmX2i2F/V8TestSupplemental.h 2011-11-28 11:08:34.150707677 +0900
2619             @@ -0,0 +1,84 @@
2620             +/*
2621             +    This file is part of the WebKit open source project.
2622             +    This file has been generated by generate-bindings.pl. DO NOT MODIFY!
2623             +
2624             (omitted)
2625
2626         * Scripts/run-bindings-tests:
2627         (detect_changes): Just added an -N option to the diff command.
2628
2629 2011-11-28  Martin Robinson  <mrobinson@igalia.com>
2630
2631         [Gtk][gtkdoc] Syntax error in Tools/gtk/generate-gtkdoc
2632         https://bugs.webkit.org/show_bug.cgi?id=73165
2633
2634         Reviewed by Philippe Normand.
2635
2636         Fix some syntax errors in this script and remove an unused variable.
2637
2638         * gtk/generate-gtkdoc:
2639         (get_webkit2_options.src_path): 
2640         (get_webkit2_options):
2641         (get_webkit1_options.src_path):
2642
2643 2011-11-26  Kevin Ollivier  <kevino@theolliviers.com>
2644
2645         [wx] Unreviewed build fix. Enable the inspector.
2646         
2647         * waf/build/settings.py:
2648
2649 2011-11-26  Martin Robinson  <mrobinson@igalia.com>
2650
2651         Try to fix the build after r101174.
2652
2653         * gtk/generate-gtkdoc: Properly handle empty PKG_CONFIG_PATHs.
2654
2655 2011-11-17  Martin Robinson  <mrobinson@igalia.com>
2656
2657         [GTK] Integrate build-gtkdoc into build-webkit and make
2658         https://bugs.webkit.org/show_bug.cgi?id=72626
2659
2660         Reviewed by Philippe Normand.
2661
2662         * GNUmakefile.am: Added support for new scripts and "make docs".
2663         * Scripts/webkitdirs.pm: Call generate-gtkdoc when building.
2664         (buildAutotoolsProject):
2665         * gtk/generate-gtkdoc: Added.
2666         * gtk/gtkdoc.py: Renamed from Source/WebKit2/UIProcess/API/gtk/docs/gtkdoc.py.
2667
2668 2011-11-25  Ádám Kallai  <Kallai.Adam@stud.u-szeged.hu>
2669
2670         [Qt] Add support for using OWRT with Qt5
2671         https://bugs.webkit.org/show_bug.cgi?id=72947
2672
2673         Add qt-5.0 platform and don't pass -graphicssystem to QtTestBrowser if using Qt5.
2674
2675         Reviewed by Csaba Osztrogonác.
2676
2677         * Scripts/old-run-webkit-tests:
2678
2679 2011-11-25  Yury Semikhatsky  <yurys@chromium.org>
2680
2681         [Chromium] Web Inspector: get rid of WebDevToolsFrontendClient::sendFrontendLoaded method
2682         https://bugs.webkit.org/show_bug.cgi?id=73126
2683
2684         No need to have a separate client call for this. The front-end can store messages
2685         which arrive before front-end loaded and dispatch them later. This happens in layout
2686         tests only by the way as all other messages should be initiated by the front-end code.
2687
2688         Reviewed by Pavel Feldman.
2689
2690         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
2691         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2692         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
2693         * DumpRenderTree/chromium/DRTDevToolsClient.h:
2694
2695 2011-11-24  Kentaro Hara  <haraken@chromium.org>
2696
2697         Replace subprocess.call() with subprocess.Popen()
2698         https://bugs.webkit.org/show_bug.cgi?id=73105
2699
2700         Reviewed by Adam Barth.
2701
2702         Currently, the stdout and stderr of the child processes of run-bindings-tests
2703         are mixed (or even gone away) with the stdout and stderr of run-bindings-tests itself.
2704         This is the problem of subprocess.call(), which does not synchronize the stdout and stderr
2705         between a parent process and a child process. This patch replaces subprocess.call() with
2706         subprocess.Popen() and synchronizes the stdout and stderr between them.
2707         This patch also makes output messages of run-bindings-tests more readable.
2708
2709         With this patch, the output messages of run-bindings-tests look like as follows:
2710
2711             PASS: (CPP) WebDOMTestObj.h
2712             PASS: (CPP) WebDOMTestObj.cpp
2713             FAIL: (CPP) WebDOMTestInterface.h
2714             --- Source/WebCore/bindings/scripts/test/CPP/WebDOMTestInterface.h      2011-11-25 13:34:09.313516268 +0900
2715             +++ /tmp/tmpDAV87G/WebDOMTestInterface.h        2011-11-25 13:44:42.712946812 +0900
2716             @@ -23,7 +23,7 @@
2717              #ifndef WebDOMTestInterface_h
2718              #define WebDOMTestInterface_h
2719
2720             -#if ENABLE(Condition1) || ENABLE(Condition2)
2721             +#if ENABLE(Condition1) || ENABLE(Condition3)
2722
2723              #include <WebDOMObject.h>
2724              #include <WebDOMString.h>
2725              @@ -53,5 +53,5 @@
2726              WebDOMTestInterface toWebKit(WebCore::TestInterface*);
2727
2728              #endif
2729             -#endif // ENABLE(Condition1) || ENABLE(Condition2)
2730             +#endif // ENABLE(Condition1) || ENABLE(Condition3)
2731             PASS: (CPP) WebDOMFloat64Array.cpp
2732             PASS: (CPP) WebDOMFloat64Array.h
2733
2734             Some tests FAIL! (To update the reference files, execute "run-bindings-tests --reset-results")
2735
2736         * Scripts/run-bindings-tests:
2737         (generate_from_idl):
2738         (detect_changes):
2739         (run_tests):
2740         (main):
2741
2742 2011-11-24  Kentaro Hara  <haraken@chromium.org>
2743
2744         Fix the current working directory of run-bindings-tests
2745         https://bugs.webkit.org/show_bug.cgi?id=73106
2746
2747         Reviewed by Adam Barth.
2748
2749         Currently, run-bindings-tests outputs the following error
2750         (although it outputs "all tests passed!" in the end):
2751
2752             Testing the ObjC generator on TestObj.idl
2753             gcc: WebCore/bindings/objc/PublicDOMInterfaces.h: No such file or directory
2754             gcc: warning: '-x objective-c' after last input file has no effect
2755             gcc: no input files
2756
2757         This is because CodeGeneratorObjC.pm assumes that the current working directory
2758         is WebKit/Source/, but run-bindings-tests sets the current working directory to WebKit/.
2759         Thus, this patch changes it to WebKit/Source/.
2760
2761         * Scripts/run-bindings-tests:
2762         (generate_from_idl):
2763         (main):
2764
2765 2011-11-24  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2766
2767         [Qt] Get rid of the buildDirForSource() function in the build system
2768
2769         At some point the plan was to allow for running qmake on sub-trees
2770         of the sources, into the top level build directory, but this is no
2771         longer possible, so no reason to keep the convenience function around.
2772
2773         Reviewed by Simon Hausmann.
2774
2775         * WebKitTestRunner/DerivedSources.pri:
2776         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
2777         * qmake/mkspecs/features/default_post.prf:
2778         * qmake/mkspecs/features/default_pre.prf:
2779         * qmake/mkspecs/features/functions.prf:
2780         * qmake/mkspecs/features/javascriptcore.prf:
2781         * qmake/mkspecs/features/webcore.prf:
2782         * qmake/mkspecs/features/webkit2.prf:
2783
2784 2011-11-23  Sheriff Bot  <webkit.review.bot@gmail.com>
2785
2786         Unreviewed, rolling out r101107.
2787         http://trac.webkit.org/changeset/101107
2788         https://bugs.webkit.org/show_bug.cgi?id=73062
2789
2790         Breaks the commit-queue (Requested by abarth on #webkit).
2791
2792         * Scripts/webkitpy/common/host.py:
2793         (Host._engage_awesome_windows_hacks):
2794         * Scripts/webkitpy/common/host_mock.py:
2795         (MockHost.__init__):
2796         * Scripts/webkitpy/common/system/environment.py: Removed.
2797         * Scripts/webkitpy/common/system/environment_unittest.py: Removed.
2798         * Scripts/webkitpy/common/system/executive.py:
2799         (Executive._run_command_with_teed_output):
2800         (Executive.run_and_throw_if_fail):
2801         * Scripts/webkitpy/common/system/executive_mock.py:
2802         (MockExecutive.run_and_throw_if_fail):
2803         (MockExecutive.run_command):
2804         * Scripts/webkitpy/layout_tests/port/webkit.py:
2805         (WebKitPort._driver_build_script_name):
2806         (WebKitPort._run_script):
2807         (WebKitPort._build_driver):
2808         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2809         (test_build_driver):
2810         * Scripts/webkitpy/tool/commands/download_unittest.py:
2811         * Scripts/webkitpy/tool/steps/build.py:
2812         (Build.build):
2813
2814 2011-11-23  Ojan Vafai  <ojan@chromium.org>
2815
2816         Unreviewed, rolling out r101110.
2817         http://trac.webkit.org/changeset/101110
2818         https://bugs.webkit.org/show_bug.cgi?id=73057
2819
2820         The bots have now cycled and this patch is no longer needed.
2821
2822         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2823         (Manager._upload_json_files):
2824
2825 2011-11-23  Ojan Vafai  <ojan@chromium.org>
2826
2827         Temporarily save the incremental results json in order to identify bug
2828         https://bugs.webkit.org/show_bug.cgi?id=73057
2829
2830         Reviewed by Dean Jackson.
2831
2832         The test results server needed to be rolled back from tip of tree
2833         due to a JSON merging bug. It's hard to identify what the bug is without
2834         the raw data.
2835
2836         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2837         (Manager._upload_json_files):
2838
2839 2011-11-23  Ojan Vafai  <ojan@chromium.org>
2840
2841         Merging two version 4 results hits an error in the test results server
2842         https://bugs.webkit.org/show_bug.cgi?id=73042
2843
2844         Reviewed by Adam Barth.
2845
2846         The old code assumed that if the aggregate results value was not a leaf
2847         value that the incremental results would exist, which is just totally
2848         wrong. Added a test for that case as well.
2849
2850         * TestResultServer/model/jsonresults.py:
2851         (JsonResults._merge_tests):
2852         * TestResultServer/model/jsonresults_unittest.py:
2853         (JsonResultsTest.test_merge_build_directory_hierarchy_old_version):
2854         (JsonResultsTest.test_merge_build_directory_hierarchy):
2855
2856 2011-11-23  Eric Seidel  <eric@webkit.org>
2857
2858         Add Environment object to Host and fix the GCC smartquotes trouble seen on the commit-queue
2859         https://bugs.webkit.org/show_bug.cgi?id=71983
2860
2861         Reviewed by Adam Barth.
2862
2863         We'll add more code to Environment overtime,
2864         allowing us to mock out more of our direct interactions with os.environ.
2865
2866         This patch also makes run_command print the passed in environment.
2867
2868         * Scripts/webkitpy/common/host_mock.py:
2869         * Scripts/webkitpy/common/system/environment.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
2870         * Scripts/webkitpy/common/system/environment_mock.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
2871         * Scripts/webkitpy/common/system/environment_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
2872         * Scripts/webkitpy/common/system/executive.py:
2873         * Scripts/webkitpy/common/system/executive_mock.py:
2874         * Scripts/webkitpy/layout_tests/port/webkit.py:
2875         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2876         * Scripts/webkitpy/tool/commands/download_unittest.py:
2877         * Scripts/webkitpy/tool/steps/build.py:
2878
2879 2011-11-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2880
2881         [Qt] Re-generate QtWebKit API forwarding headers when API changes
2882
2883         The forwarding headers are generated by syncqt, and syncqt is run by qmake,
2884         so we need sync.profile to live in the same directory as the project file
2885         that will be touched when adding/removing API (api.pri in our case).
2886
2887         Since the WebKit2 APIs live in a separate static library, we have to
2888         add the project file for WebKit2 as a dependency of the api.pri file
2889         as well, so that any changes to the WebKit2 API will still trigger a
2890         run of qmake (and then syncqt).
2891
2892         Lastly, we use the new QMAKE_SYNCQT_OUTDIR variable in Qt 5 to ensure
2893         that the forwarding headers are still generated in the root build dir,
2894         not in the Source dir along with the internal forwarding headers.
2895
2896         Reviewed by Andreas Kling.
2897
2898         * qmake/mkspecs/features/default_pre.prf:
2899         * qmake/mkspecs/features/functions.prf:
2900
2901 2011-11-23  Johnny Ding  <jnd@chromium.org>
2902
2903         Set right default value to baseURL in LayoutTestController::queueLoadHTMLString.
2904         https://bugs.webkit.org/show_bug.cgi?id=72950
2905
2906         Reviewed by Tony Chang.
2907
2908         * DumpRenderTree/chromium/LayoutTestController.cpp:
2909         (LayoutTestController::queueLoadHTMLString):
2910
2911 2011-11-23  Adam Barth  <abarth@webkit.org>
2912
2913         garden-o-matic should display a message if it can't find results to display
2914         https://bugs.webkit.org/show_bug.cgi?id=72991
2915
2916         Reviewed by Dimitri Glazkov.
2917
2918         Not all failures (e.g., TIMEOUT) have results that we can display.
2919         This patch adds a short message so that the user can see that we're
2920         done trying to load the results.
2921
2922         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
2923         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
2924         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
2925
2926 2011-11-23  Adam Barth  <abarth@webkit.org>
2927
2928         garden-o-matic should explain more clearly what the builder lists at the top of the page mean
2929         https://bugs.webkit.org/show_bug.cgi?id=72992
2930
2931         Reviewed by Dimitri Glazkov.
2932
2933         This patch also prepares us to list other sorts of failures, like
2934         performance and unit test.
2935
2936         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2937         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
2938         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
2939         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2940
2941 2011-11-23  Ryan Sleevi  <rsleevi@chromium.org>
2942
2943         Add new Chromium tests to the flakiness dashboard
2944         https://bugs.webkit.org/show_bug.cgi?id=72997
2945
2946         Reviewed by Ojan Vafai.
2947
2948         * TestResultServer/static-dashboards/dashboard_base.js:
2949         ():
2950
2951 2011-11-23  Adam Barth  <abarth@webkit.org>
2952
2953         garden-o-matic should support AUDIO failures
2954         https://bugs.webkit.org/show_bug.cgi?id=69477
2955
2956         Reviewed by Dimitri Glazkov.
2957
2958         This is a first iteration at supporting AUDIO failures in
2959         garden-o-matic.  We'll probably need to iterate a bit when we have a
2960         real audio failure in the tree to play with.  For example, we'll
2961         probably want to add and <audio> element to the "Examine" view to hear
2962         the differences, but that all can be done in a subsequent patch.
2963
2964         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
2965
2966 2011-11-23  Scott Graham  <scottmg@chromium.org>
2967
2968         Adding gamepad support
2969         https://bugs.webkit.org/show_bug.cgi?id=69451
2970
2971         Reviewed by Darin Fisher.
2972
2973         Add a 'gamepadController' to Chromium DRT. Allows for setting of mock
2974         gamepad data that will be retrieved when JS code pulls via API access.
2975
2976         * DumpRenderTree/DumpRenderTree.gypi:
2977         * DumpRenderTree/chromium/GamepadController.cpp: Added.
2978         (GamepadController::GamepadController):
2979         (GamepadController::bindToJavascript):
2980         (GamepadController::reset):
2981         (GamepadController::connect):
2982         (GamepadController::disconnect):
2983         (GamepadController::setId):
2984         (GamepadController::setButtonCount):
2985         (GamepadController::setButtonData):
2986         (GamepadController::setAxisCount):
2987         (GamepadController::setAxisData):
2988         (GamepadController::fallbackCallback):
2989         * DumpRenderTree/chromium/GamepadController.h: Added.
2990         * DumpRenderTree/chromium/TestShell.cpp:
2991         (TestShell::TestShell):
2992         (TestShell::resetTestController):
2993         (TestShell::bindJSObjectsToWindow):
2994         * DumpRenderTree/chromium/TestShell.h:
2995         (TestShell::gamepadController):
2996
2997 2011-11-23  Raphael Kubo da Costa  <kubo@profusion.mobi>
2998
2999         [CMake] Move the top-level logic to the top-level directory.
3000         https://bugs.webkit.org/show_bug.cgi?id=72685
3001
3002         Reviewed by Brent Fulgham.
3003
3004         * CMakeLists.txt: Added.
3005         * DumpRenderTree/efl/CMakeLists.txt: Keep building into Programs/.
3006         * EWebLauncher/CMakeLists.txt: Renamed from Tools/CMakeListsEfl.txt.
3007         * Scripts/webkitdirs.pm:
3008         (generateBuildSystemFromCMakeProject):
3009         * WinCELauncher/CMakeLists.txt: Renamed from Tools/CMakeListsWinCE.txt.
3010
3011 2011-11-17  Vincent Scheib  <scheib@chromium.org>
3012
3013         Pointer Lock: Initial Tests for navigator.webkitPonter
3014         https://bugs.webkit.org/show_bug.cgi?id=72659
3015
3016         Reviewed by Darin Fisher.
3017
3018         * DumpRenderTree/chromium/TestShell.cpp:
3019         (TestShell::TestShell):
3020             Enabling PointerLock in TestShell
3021
3022 2011-11-22  Ryan Sleevi  <rsleevi@chromium.org>
3023
3024         Update flakiness dashboard for new Chromium builders and tests
3025         https://bugs.webkit.org/show_bug.cgi?id=72931
3026
3027         Reviewed by Ojan Vafai.
3028
3029         * TestResultServer/static-dashboards/builders.js:
3030         * TestResultServer/static-dashboards/dashboard_base.js:
3031
3032 2011-11-22  Adam Roben  <aroben@apple.com>
3033
3034         Remove some debugging code I accidentally left in r101005
3035
3036         * Scripts/prepare-ChangeLog:
3037         (get_function_line_ranges_for_python):
3038
3039 2011-11-22  Adam Roben  <aroben@apple.com>
3040
3041         Teach prepare-ChangeLog how to find changed classes/methods/functions in Python files
3042
3043         Fixes <http://webkit.org/b/57008> prepare-ChangeLog doesn't find names of modified
3044         classes/methods in Python source files
3045
3046         Reviewed by Dan Bates.
3047
3048         * Scripts/prepare-ChangeLog:
3049         (get_function_line_ranges): Call get_function_line_ranges_for_python for files ending in .py
3050         or that use python as their interpreter. Modified the code that extracts the interpreter to
3051         ignore a leading "/usr/bin/env " in the interpreter line, as is common for our Python
3052         scripts.
3053         (get_function_line_ranges_for_python): Added. Does simple parsing of Python files to look
3054         for class/def lines and generate ranges based on them.
3055
3056 2011-11-21  Yuta Kitamura  <yutak@chromium.org>
3057
3058         [GTK] Enable WebSocket hybi tests
3059         https://bugs.webkit.org/show_bug.cgi?id=72870
3060
3061         Reviewed by Xan Lopez.
3062
3063         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3064         (resetDefaultsToConsistentValues):
3065         Reset the setting value to the default value (true).
3066         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3067         (LayoutTestController::overridePreference):
3068         Change the setting value through a function in DumpRenderTreeSupportGtk.
3069
3070 2011-11-21  Ryosuke Niwa  <rniwa@webkit.org>
3071
3072         ChangeLogEntry should be able to parse entries with multiple authors
3073         https://bugs.webkit.org/show_bug.cgi?id=72690
3074
3075         Reviewed by Eric Seidel.
3076
3077         Support multi-author change log entries in ChangeLogEntry. Split author names using
3078         the same logic as splitting reviewer names. _authors now stores list of dictionaries
3079         with "name" and "email" as keys. Unlike reviewers, we can't always resolve authors to
3080         accounts because some contributors are never listed in committers.py. 
3081
3082         * Scripts/webkitpy/common/checkout/changelog.py:
3083         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3084         * Scripts/webkitpy/common/config/committers.py: Fixed a bug that *_by_{name|email}
3085         throws an exception when the argument is None.
3086
3087 2011-11-21  Simon Hausmann  <simon.hausmann@nokia.com>
3088
3089         [Qt] Speed up debug builds.
3090         https://bugs.webkit.org/show_bug.cgi?id=72882
3091
3092         Reviewed by Tor Arne Vestbø.
3093
3094         Introduce a special type of build that replaces the static jsc/wc/wk2
3095         static libraries with shared libraries, that individually are much faster
3096         to link and don't require relinking into the big library when changing just
3097         one file in one module. It can be enabled with
3098         --qmakearg="CONFIG+=force_static_libs_as_shared"
3099
3100         * qmake/mkspecs/features/force_static_libs_as_shared.prf: Added. With this configuration,
3101         disable symbol visibility, static linkage and enable rpath.
3102         * qmake/mkspecs/features/functions.prf: Add a helper function to determine if
3103         we need to link the convenience libraries together or not and renamed linkStaticLibrary
3104         to just linkLibrary (because linkage is not necessarily static).
3105         * qmake/mkspecs/features/qtwebkit.prf: When using the trick, make sure to also
3106         link against jsc/wc/wk2 when linking app code against QtWebKit.
3107         * qmake/mkspecs/features/javascriptcore.prf: Use new +needToLinkLibrary helper
3108         function.
3109         * qmake/mkspecs/features/webcore.prf: Ditto.
3110         * qmake/mkspecs/features/webkit2.prf: Ditto.
3111
3112 2011-11-21  Adam Klein  <adamk@chromium.org>
3113
3114         Update flakiness dashboard linkification regexps for crbug.com/100000 and above
3115         https://bugs.webkit.org/show_bug.cgi?id=72898
3116
3117         Reviewed by Ojan Vafai.
3118
3119         Also removed a comment that was going to be more trouble to keep up to
3120         date than seemed worthwhile (the code is now the documentation).
3121
3122         * TestResultServer/static-dashboards/flakiness_dashboard.html:
3123
3124 2011-11-21  Dominic Mazzoni  <dmazzoni@google.com>
3125
3126         [Chromium] WebAccessibilityNotification should use AssertMatchingEnums.
3127         https://bugs.webkit.org/show_bug.cgi?id=72895
3128
3129         Reviewed by Chris Fleizach.
3130
3131         * DumpRenderTree/chromium/WebViewHost.cpp:
3132         (WebViewHost::postAccessibilityNotification):
3133
3134 2011-11-21  Philippe Normand  <pnormand@igalia.com>
3135
3136         Unreviewed, run-gtk-tests temporary workaround after r98500.
3137
3138         * Scripts/run-gtk-tests: Try to find the build directory like in
3139         build-gtkdoc, until webkit-build-directory --configuration gets fixed.
3140
3141 2011-11-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3142
3143         [GTK] Add a way to skip unit tests in the bots
3144         https://bugs.webkit.org/show_bug.cgi?id=72879
3145
3146         Reviewed by Philippe Normand.
3147
3148         Rewrite the script in python to make it easier for everybody to
3149         change it and add support for skipping tests.
3150
3151         * Scripts/run-gtk-tests:
3152
3153 2011-11-21  Raphael Kubo da Costa  <kubo@profusion.mobi>
3154
3155         [EFL] Add more appcache functions to ewk_settings.
3156         https://bugs.webkit.org/show_bug.cgi?id=72143
3157
3158         Reviewed by Kenneth Rohde Christiansen.
3159
3160         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3161         (LayoutTestController::clearAllApplicationCaches):
3162         (LayoutTestController::setAppCacheMaximumSize): Use the right
3163         function, this is not related to the memory cache, but rather to the
3164         appcache.
3165
3166 2011-11-18  Adam Roben  <aroben@apple.com>
3167
3168         Make NRWT consider all lines of output from parse-malloc-history, not just the first
3169
3170         Fixes <http://webkit.org/b/72652> REGRESSION (NRWT): NRWT always reports "1 unique leaks
3171         found" even when there are more than 1 unique leaks
3172
3173         Reviewed by Darin Adler.
3174
3175         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
3176         (LeakDetector.count_total_bytes_and_unique_leaks): Pass re.MULTILINE to re.findall so that
3177         "^" will be considered to match the beginning of any line, not only the beginning of the
3178         string.
3179
3180         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
3181         (LeakDetectorTest.test_count_total_bytes_and_unique_leaks): Added a second callstack to the
3182         fake output and updated expectations to match.
3183
3184 2011-11-21  Andras Becsi  <andras.becsi@nokia.com>
3185
3186         [Qt] Clean up MiniBrowser project file after recent changes
3187         https://bugs.webkit.org/show_bug.cgi?id=72869
3188
3189         Reviewed by Simon Hausmann.
3190
3191         Remove nonexistent files from OTHER_FILES after our touch and desktop webviews were merged.
3192
3193         * MiniBrowser/qt/MiniBrowser.pro:
3194
3195 2011-11-21  Dominic Mazzoni  <dmazzoni@google.com>
3196
3197         Accessibility: Multiselect list boxes need to report the active option in addition to which items are selected.
3198         https://bugs.webkit.org/show_bug.cgi?id=72479
3199
3200         Reviewed by Chris Fleizach.
3201
3202         * DumpRenderTree/AccessibilityUIElement.cpp:
3203         (getIsSelectedOptionActiveCallback):
3204         (AccessibilityUIElement::getJSClass):
3205         * DumpRenderTree/AccessibilityUIElement.h:
3206         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
3207         (AccessibilityUIElement::AccessibilityUIElement):
3208         (AccessibilityUIElement::isSelectedOptionActiveGetterCallback):
3209         * DumpRenderTree/chromium/AccessibilityUIElement.h:
3210         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3211         (AccessibilityUIElement::isSelectedOptionActive):
3212         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3213         (AccessibilityUIElement::isSelectedOptionActive):
3214         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3215         (AccessibilityUIElement::isSelectedOptionActive):
3216
3217 2011-11-21  Takashi Toyoshima  <toyoshim@chromium.org>
3218
3219         Use Host().port_factory instead of webkitpy.layout_tests.port.factory.
3220         https://bugs.webkit.org/show_bug.cgi?id=72859
3221
3222         Reviewed by Eric Seidel.
3223         
3224         * Scripts/new-run-webkit-websocketserver:
3225
3226 2011-11-20  Shinya Kawanaka  <shinyak@google.com>
3227
3228         [Chromium] Layout test does not return correct misspelling positions if there are multiple misspelled words.
3229         https://bugs.webkit.org/show_bug.cgi?id=72655
3230
3231         Reviewed by Hajime Morita.
3232
3233         Fixed the calculation of offset.
3234
3235         * DumpRenderTree/chromium/WebViewHost.cpp:
3236         (WebViewHost::finishLastTextCheck):
3237
3238 2011-11-20  Ojan Vafai  <ojan@chromium.org>
3239
3240         Change the final place where we use version 3 of the results json output
3241         https://bugs.webkit.org/show_bug.cgi?id=72838
3242
3243         Reviewed by Adam Barth.
3244
3245         This converts the json from being a flat map of test name --> results
3246         to being hierarchical by directory. This will make the json files 
3247         considerably smaller.
3248
3249         Also cleaned up some functions that were returning/checking boolean values
3250         that were always True.
3251
3252         * TestResultServer/model/jsonresults.py:
3253         * TestResultServer/model/jsonresults_unittest.py:
3254
3255 2011-11-20  Ojan Vafai  <ojan@chromium.org>
3256
3257         Include the master name when querying the test results server.
3258         This will soon be required since leaving the master name out mean
3259         that multiple files could match the query.
3260
3261         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3262
3263 2011-11-19  Ojan Vafai  <ojan@chromium.org>
3264
3265         Fix jsonp callback code to add the callback if json content
3266         is not jsonp.
3267         * TestResultServer/handlers/testfilehandler.py:
3268
3269 2011-11-19  Alice Boxhall  <aboxhall@chromium.org>
3270
3271         Modify dashboard_base.js to optionally accept version 4 results json.
3272
3273         Reviewed by Ojan Vafai.
3274
3275         * TestResultServer/static-dashboards/dashboard_base.js:
3276         (ADD_RESULTS):
3277         (flattenTrie):
3278         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
3279         (testFlattenTrie):
3280
3281 2011-11-19  Ojan Vafai  <ojan@chromium.org>
3282
3283         Stop storing results files as jsonp in the test results server
3284         https://bugs.webkit.org/show_bug.cgi?id=72814
3285
3286         Reviewed by Adam Barth.
3287
3288         * TestResultServer/model/jsonresults.py:
3289         * TestResultServer/model/jsonresults_unittest.py:
3290
3291 2011-11-19  Ojan Vafai  <ojan@chromium.org>
3292
3293         Remove the dependence on jsonp from more of new-run-webkit-tests and the test results server
3294         https://bugs.webkit.org/show_bug.cgi?id=72813
3295
3296         Reviewed by Adam Barth.
3297
3298         Once this lands, we can start storing pure json in the test results server and then
3299         we can delete the code with all the FIXMEs added here.
3300
3301         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3302         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3303         Only add jsonp for full_results.json.
3304         * TestResultServer/model/jsonresults.py:
3305         * TestResultServer/model/jsonresults_unittest.py:
3306         Accept pure json uploads.
3307         * TestResultServer/static-dashboards/dashboard_base.js:
3308         (appendJSONScriptElementFor):
3309         Use the callback parameter so that the server can start returning pure json if it's left out.
3310
3311 2011-11-19  Ojan Vafai  <ojan@chromium.org>
3312
3313         Allow json NRWT downloads to be pure json and not jsonp
3314         https://bugs.webkit.org/show_bug.cgi?id=72809
3315
3316         Reviewed by Adam Barth.
3317
3318         I'm moving the server to storing and serving up raw json instead of jsonp.
3319         You can still get the jsonp by passing a "callback" parameter, but there's no
3320         need for run-webkit-tests to get jsonp when all it wants is the raw json.
3321
3322         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3323         Make the wrapper stripping only happen if the json is actually wrapped.
3324         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3325
3326 2011-11-18  Daniel Bates  <dbates@rim.com>
3327
3328         Add CMake build infrastructure for the BlackBerry port
3329         https://bugs.webkit.org/show_bug.cgi?id=72768
3330
3331         Reviewed by Antonio Gomes.
3332
3333         Add optional --blackberry command line argument to build-webkit to build the
3334         BlackBerry port.
3335
3336         * Scripts/build-webkit:
3337         * Scripts/webkitdirs.pm:
3338         (determineBaseProductDir):
3339         (argumentsForConfiguration):
3340         (builtDylibPathForName):
3341         (determineIsQt):
3342         (isBlackBerry): Added.
3343         (determineIsBlackBerry): Added.
3344         (blackberryTargetArchitecture): Added.
3345         (isAppleWebKit):
3346
3347 2011-11-18  James Robinson  <jamesr@chromium.org>
3348
3349         Unreviewed, rolling out r100835.
3350         http://trac.webkit.org/changeset/100835
3351         https://bugs.webkit.org/show_bug.cgi?id=72778
3352
3353         Broke some page scale tests
3354
3355         * DumpRenderTree/chromium/EventSender.cpp:
3356         (EventSender::scalePageBy):
3357
3358 2011-11-18  Adam Barth  <abarth@webkit.org>
3359
3360         Prepare to move manual-tests out of WebCore
3361         https://bugs.webkit.org/show_bug.cgi?id=72782
3362
3363         Reviewed by Eric Seidel.
3364
3365         Update this file to refer to the new location of ManualTests.
3366
3367         * Scripts/webkitpy/common/config/build.py:
3368
3369 2011-11-18  James Robinson  <jamesr@chromium.org>
3370
3371         [chromium] Set min/max page scale factors when calling eventSender.scalePageBy to avoid clamping
3372         https://bugs.webkit.org/show_bug.cgi?id=72778
3373
3374         Reviewed by Kenneth Russell.
3375
3376         Set the min/max page scale clamps when a test calls eventSender.scalePageBy() so that the scale isn't clamped.
3377
3378         * DumpRenderTree/chromium/EventSender.cpp:
3379         (EventSender::scalePageBy):
3380
3381 2011-11-18  Scott Graham  <scottmg@chromium.org>
3382
3383         IDL changes for gamepad support
3384         https://bugs.webkit.org/show_bug.cgi?id=71753
3385
3386         Reviewed by Adam Barth.
3387
3388         Runtime enable gamepad in chromium test shell.
3389
3390         * DumpRenderTree/chromium/TestShell.cpp:
3391         (TestShell::TestShell):
3392
3393 2011-10-27  Darin Fisher  <darin@chromium.org>
3394
3395         [chromium] Improve fullscreen API
3396         https://bugs.webkit.org/show_bug.cgi?id=70477
3397
3398         Reviewed by Adam Barth.
3399
3400         Implement enter/exitFullScreen.  The implementation is asynchronous,
3401         via postDelayedTask, to simulate how the browser actually behaves.
3402
3403         * DumpRenderTree/chromium/WebViewHost.cpp:
3404         (WebViewHost::enterFullScreen):
3405         (WebViewHost::exitFullScreen):
3406         (WebViewHost::setAddressBarURL):
3407         (WebViewHost::enterFullScreenNow):
3408         (WebViewHost::exitFullScreenNow):
3409         * DumpRenderTree/chromium/WebViewHost.h:
3410
3411 2011-11-18  Adam Roben  <aroben@apple.com>
3412
3413         Ignore an ANGLE leak that is not WebKit's fault
3414
3415         * Scripts/old-run-webkit-tests:
3416         (countAndPrintLeaks):
3417         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
3418         (LeakDetector._callstacks_to_exclude_from_leaks):
3419         Added ScanFromString to the call stacks to exclude on all OS versions.
3420
3421 2011-11-18  Adam Roben  <aroben@apple.com>
3422
3423         Ignore another Lion-specific leak that is not WebKit's fault
3424
3425         * Scripts/old-run-webkit-tests:
3426         (countAndPrintLeaks):
3427         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
3428         (LeakDetector._callstacks_to_exclude_from_leaks):
3429         Added SecTransformExecute to the call stacks to exclude.
3430
3431 2011-11-18  Yuta Kitamura  <yutak@chromium.org>
3432
3433         [Qt] Enable WebSocket hybi tests
3434         https://bugs.webkit.org/show_bug.cgi?id=72687
3435
3436         Reviewed by Simon Hausmann.
3437
3438         Let LayoutTestControllerQt be able to switch WebSocket protocols via overridePreference().
3439
3440         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3441         (WebCore::WebPage::resetSettings):
3442         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3443         (LayoutTestController::overridePreference):
3444
3445 2011-11-18  Sergio Villar Senin  <svillar@igalia.com>
3446
3447         [GTK][WK2] Invalid TestNetscapePlugin path when using new-run-webkit-tests
3448         https://bugs.webkit.org/show_bug.cgi?id=72707
3449
3450         Reviewed by Philippe Normand.
3451
3452         Make new-run-webkit-tests use the right path to locate the test
3453         plugin used by WebKitTestRunner.
3454
3455         * Scripts/webkitpy/layout_tests/port/gtk.py:
3456
3457 2011-11-18  Simon Hausmann  <simon.hausmann@nokia.com>
3458
3459         [Qt] WTR and InjectedBundle should not link statically against JSC/WTF
3460         https://bugs.webkit.org/show_bug.cgi?id=72697
3461
3462         Reviewed by Kenneth Rohde Christiansen.
3463
3464         * Tools.pro: Make WTR linux only for the moment.
3465         * WebKitTestRunner/InjectedBundle/Target.pri: Remove static jsc/wtf linkage.
3466         * WebKitTestRunner/Target.pri: Ditto.
3467         * qmake/mkspecs/features/default_post.prf: Don't build the main webkit sources
3468         with ELF visibility on Linux. Instead we're temporarily using an LD version script.
3469
3470 2011-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3471
3472         [Qt] Change default size of the MiniBrowser
3473
3474         Reviewed by Simon Hausmann.
3475
3476         As we lay out desktop pages using the width of 980, change our default
3477         size to 980x735 so that we are not scaling down by default.
3478
3479         * MiniBrowser/qt/MiniBrowserApplication.h:
3480         (WindowOptions::WindowOptions):
3481
3482 2011-11-17  Raphael Kubo da Costa  <kubo@profusion.mobi>
3483
3484         [EFL] Clean up the use of DATA_DIR in the buildsystem
3485         https://bugs.webkit.org/show_bug.cgi?id=72681
3486
3487         Reviewed by Daniel Bates.
3488
3489         Instead of adding -DDATA_DIR in all scopes, only define it in
3490         WebCore/PlatformEFL.cmake, as WebCore is the only place that uses
3491         it.
3492
3493         We can then define DATA_DIR to the generated theme directory for
3494         EWebLauncher, since it's what we want here.
3495
3496         * CMakeListsEfl.txt:
3497
3498 2011-11-17  Raphael Kubo da Costa  <kubo@profusion.mobi>
3499
3500         [EFL] Move platform includes last in DRT's include directories.
3501         https://bugs.webkit.org/show_bug.cgi?id=72684
3502
3503         Reviewed by Daniel Bates.
3504
3505         This is the first step in fixing the build when a platform include (in
3506         this case, Valgrind 3.7.0 ships its config.h) and the wrong config.h
3507         is included instead of WebKit's.
3508
3509         * DumpRenderTree/efl/CMakeLists.txt:
3510
3511 2011-11-17  Ryosuke Niwa  <rniwa@webkit.org>
3512
3513         fuzzy_match doesn't recognize "Dan B" or "hyatt"
3514         https://bugs.webkit.org/show_bug.cgi?id=72636
3515
3516         Reviewed by Eric Seidel.
3517
3518         Make contributors_by_fuzz_match search string in shorthand names of contributors such as "Ryosuke N"
3519         and user names of email addreses such as rniwa in rniwa@webkit.org.
3520
3521         Also import legacy contributor names and mispell lists from Eric's script on the bug 26533 as a test.
3522
3523         * Scripts/webkitpy/common/config/committers.py:
3524         * Scripts/webkitpy/common/config/committers_unittest.py:
3525
3526 2011-11-17  Eric Seidel  <eric@webkit.org>
3527
3528         Remove support for running check-webkit-style w/o a webkit checkout
3529         https://bugs.webkit.org/show_bug.cgi?id=72678
3530
3531         Reviewed by Adam Barth.
3532
3533         After talking to Dave Levin we've decided to remove this
3534         code.  I know of no users of check-webkit-style w/o a webkit checkout
3535         and this needlessly adds complexity.
3536
3537         * Scripts/webkitpy/style/main.py:
3538
3539 2011-11-17  Eric Seidel  <eric@webkit.org>
3540
3541         Remove more direct uses of os.path
3542         https://bugs.webkit.org/show_bug.cgi?id=72677
3543
3544         Reviewed by Adam Barth.
3545
3546         Remove more uses of os.path, including refactoring
3547         CommitterValidator to use a Host object instead of
3548         manual hacks to emulate what SCM and FileSystem provide.
3549
3550         * Scripts/webkitpy/common/checkout/changelog.py:
3551         * Scripts/webkitpy/common/config/committervalidator.py:
3552         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
3553         * Scripts/webkitpy/common/system/filesystem_mock.py:
3554          - Turns out none of our unittests actually looked at this path.
3555            now I've made it be a valid path.
3556         * Scripts/webkitpy/tool/bot/feeders.py:
3557         * Scripts/webkitpy/tool/commands/queues.py:
3558
3559 2011-11-17  Eric Seidel  <eric@webkit.org>
3560
3561         Teach TextFileReader about FileSystem
3562         https://bugs.webkit.org/show_bug.cgi?id=72673
3563
3564         Reviewed by Adam Barth.
3565
3566         Unfortunately TextFileReader doesn't use FileSystem
3567         everywhere yet, so we can't move the unittests to
3568         using MockFileSystem, but we're close.
3569
3570         * Scripts/webkitpy/style/filereader.py:
3571         * Scripts/webkitpy/style/filereader_unittest.py:
3572         * Scripts/webkitpy/style/main.py:
3573
3574 2011-11-17  Eric Seidel  <eric@webkit.org>
3575
3576         Give check-webkit-style a Host
3577         https://bugs.webkit.org/show_bug.cgi?id=72670
3578
3579         Reviewed by Adam Barth.
3580
3581         * Scripts/webkitpy/common/checkout/scm/detection.py:
3582         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3583          - We don't run these unittests, but this one was looking for the wrong exception.
3584         * Scripts/webkitpy/style/main.py:
3585         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
3586          - This was create a new scm object even though it already had one?
3587
3588 2011-11-17  Eric Seidel  <eric@webkit.org>
3589
3590         Move check-webkit-style change_directory code to more modern mocks
3591         https://bugs.webkit.org/show_bug.cgi?id=72664
3592
3593         Reviewed by Adam Barth.
3594
3595         * Scripts/check-webkit-style:
3596         * Scripts/webkitpy/style/main.py:
3597         * Scripts/webkitpy/style/main_unittest.py:
3598
3599 2011-11-17  Zan Dobersek  <zandobersek@gmail.com>
3600
3601         [GTK] enable ref tests
3602         https://bugs.webkit.org/show_bug.cgi?id=72601
3603
3604         Re-enable ref tests. Run the driver under evenly numbered display if performing
3605         pixel tests or under oddly numbered display otherwise. This prevents the ref tests
3606         being run in an already used Xvfb instance if pixel tests are disabled.
3607
3608         Reviewed by Tony Chang.
3609
3610         * Scripts/webkitpy/layout_tests/port/gtk.py: Also set Xvfb variable to None
3611         after the process is killed
3612
3613 2011-11-17  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
3614
3615         Make check-webkit-style accept xxx_p.h as a primary header for xxx.cpp for Qt's sake
3616         https://bugs.webkit.org/show_bug.cgi?id=72620
3617
3618         Reviewed by David Levin.
3619
3620         Qt's convention of keeping private (but exposed) API suffixed by "_p.h" but not
3621         adding the suffix the cpp file. One example of false positive
3622         https://bugs.webkit.org/show_bug.cgi?id=72319#c12.
3623
3624         * Scripts/webkitpy/style/checkers/cpp.py: accept headers ending with _p as primary if its
3625         basename contains the cpp's basename.
3626         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3627
3628 2011-11-17  Eric Seidel  <eric@webkit.org>
3629
3630         Move check-webkit-style's guts into webkitpy/style/main.py
3631         https://bugs.webkit.org/show_bug.cgi?id=72657
3632
3633         Reviewed by Adam Barth.
3634
3635         * Scripts/check-webkit-style:
3636         * Scripts/webkitpy/style/main.py:
3637
3638 2011-11-17  Eric Seidel  <eric@webkit.org>
3639
3640         new-run-webkit-tests is locale dependent
3641         https://bugs.webkit.org/show_bug.cgi?id=68691
3642
3643         Reviewed by Adam Barth.
3644
3645         Make NRWT use a clean environment, just like ORWT did.
3646
3647         * Scripts/webkitpy/layout_tests/port/base.py:
3648         * Scripts/webkitpy/layout_tests/port/chromium.py:
3649         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3650         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3651         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3652         * Scripts/webkitpy/layout_tests/port/efl.py:
3653         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
3654         * Scripts/webkitpy/layout_tests/port/mac.py:
3655         * Scripts/webkitpy/layout_tests/port/qt.py:
3656         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
3657         * Scripts/webkitpy/layout_tests/port/webkit.py:
3658         * Scripts/webkitpy/layout_tests/port/win.py:
3659
3660 2011-11-17  Dirk Pranke  <dpranke@chromium.org>
3661
3662         Chromium Mac 10.5 CG dbg bots are failing to run webkit_gpu_tests
3663         https://bugs.webkit.org/show_bug.cgi?id=72615
3664
3665         Reviewed by James Robinson.
3666
3667         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3668
3669 2011-11-17  Simon Hausmann  <simon.hausmann@nokia.com>
3670
3671         [Qt] Layer violation: qt_runtime.cpp accesses QWebElement and QTDRTNode
3672         https://bugs.webkit.org/show_bug.cgi?id=72595
3673
3674         Reviewed by Noam Rosenthal.
3675
3676         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3677         (WebCore::DumpRenderTree::DumpRenderTree): Use new initialize() function to
3678         ensure the registration of the DRTNode JS bindings.
3679         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3680         (LayoutTestController::LayoutTestController): Remove unnecessary explicit qt meta type
3681         registration of QWebElement (now done implicitly through QWebPage ->
3682         QtWebElementRunTime::initialize code path)
3683
3684 2011-11-17  Adam Roben  <aroben@apple.com>
3685
3686         Fix a crash-inducing typo I introduced in r100648
3687
3688         Fixes <http://webkit.org/b/72642> REGRESSION (r100648): NRWT crashes on Chromium when
3689         handling a crashing test
3690
3691         Reviewed by Adam Barth.
3692
3693         * Scripts/webkitpy/layout_tests/port/chromium.py:
3694         (ChromiumDriver.run_test): Get the driver name from the port.
3695
3696         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3697         (ChromiumDriverTest.test_crashed_process_name): Simulate a crash and check that we got the
3698         right crashed process name.
3699
3700 2011-11-17  Adam Roben  <aroben@apple.com>
3701
3702         Fix NRWT's parsing of the number of excluded leaks
3703
3704         Fixes <http://webkit.org/b/72635> NRWT crashes when parsing leaks files from which certain
3705         leaks were excluded
3706
3707         Reviewed by Adam Barth.
3708
3709         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
3710         (LeakDetector._parse_leaks_output): Extract just the number of excluded leaks from the
3711         regular expression match, not the entire matched string.
3712
3713         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
3714         (LeakDetectorTest): Added some example output that shows how things look when leaks are
3715         excluded.
3716         (LeakDetectorTest.test_parse_leaks_output): Test that we parse the number of exclusions
3717         correctly.
3718
3719 2011-11-17  Adam Roben  <aroben@apple.com>
3720
3721         Make NRWT find crash logs for the crashed process, which may not necessarily be the driver process
3722
3723         Fixes <http://webkit.org/b/72526> REGRESSION (NRWT): WebKitTestRunner crash log gets saved
3724         when web process crashes, but WebProcess crash log should get saved instead
3725
3726         Reviewed by Eric Seidel.
3727
3728         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3729         (write_test_result): Simplified a little to share more code between the case where we
3730         crashed when running the test and where we crashed when checking the expected rendering for
3731         a reftest. Changed to pass the crashed process name down to write_crash_report.
3732         (TestResultWriter.write_crash_report): Added crashed_process_name parameter, which we pass
3733         along to CrashLogs.find_newest_log rather than always using the driver name.
3734
3735         * Scripts/webkitpy/layout_tests/port/chromium.py:
3736         (ChromiumDriver.run_test): Pass the driver name as the name of the crashed process if we
3737         crashed.
3738
3739         * Scripts/webkitpy/layout_tests/port/test.py:
3740         (TestInstance.__init__): Initialize new web_process_crash attribute.
3741         (unit_test_list): Added new web-process-crash-with-stderr test, which is used by the new
3742         test this patch adds.
3743         (TestDriver.run_test): Pass a crashed process name to DriverOutput based on whether the test
3744         specifies that the driver crashed or the web process crashed.
3745
3746         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3747         (MainTest.test_web_process_crash_log): Added. Similar to test_crash_log, but uses a test for
3748         which we pretend the web process crashed rather than the driver process.
3749
3750         (MainTest.test_run_singly_actually_runs_tests):
3751         (MainTest.test_unexpected_failures):
3752         (EndToEndTest.test_end_to_end):
3753         Updated magic numbers to account for new unexpected failing test added to unit_test_list.
3754
3755 2011-11-17  Tony Chang  <tony@chromium.org>
3756
3757         [chromium] stop spamming features warning on every build
3758         https://bugs.webkit.org/show_bug.cgi?id=72629
3759
3760         Reviewed by Ojan Vafai.
3761
3762         We toggle $blobSupport on if $mediaStreamSupport is on.  Since
3763         $mediaStreamSupport is on by default for chromium, make the default
3764         for $blobSupport also on.
3765
3766         * Scripts/build-webkit:
3767
3768 2011-11-17  Adam Roben  <aroben@apple.com>
3769
3770         Remove extra quoting of call stacks and types passed to run-leaks by NRWT
3771
3772         Fixes <http://webkit.org/b/72623> REGRESSION (NRWT): run-webkit-tests --leaks reports leaks
3773         that are supposed to be ignored
3774
3775         Reviewed by Adam Barth.
3776
3777         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
3778         (LeakDetector._leaks_args): Removed extra quoting of call stacks and types. Quoting is only
3779         required when passing arguments via the shell (which we aren't doing here). It is not
3780         required by Perl's option-parsing code (as the comment I removed mistakenly claimed).
3781
3782         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
3783         (LeakDetectorTest.test_leaks_args): Updated expectations.
3784
3785 2011-11-17  Philippe Normand  <pnormand@igalia.com>
3786
3787         Unreviewed, run-bindings-tests fix after r91028.
3788
3789         * Scripts/run-bindings-tests: Use scm.detection module.
3790
3791 2011-11-17  Jochen Eisinger  <jochen@chromium.org>
3792
3793         Silence a warning about control reaching the end of a non-void function
3794         https://bugs.webkit.org/show_bug.cgi?id=72616
3795
3796         Reviewed by Tony Gentilcore.
3797
3798         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3799         (AccessibilityUIElement::verticalScrollbar):
3800
3801 2011-11-17  Adam Roben  <aroben@apple.com>
3802
3803         Ignore some leaks in frameworks we link against on Lion
3804
3805         Fixes <http://webkit.org/b/72609> Lion Leaks bot complains about a bunch of leaks that
3806         aren't WebKit's fault
3807
3808         Reviewed by Antti Koivisto.
3809
3810         * Scripts/old-run-webkit-tests:
3811         (countAndPrintLeaks):
3812         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
3813         (LeakDetector._callstacks_to_exclude_from_leaks):
3814         Added some call stacks to exclude on Lion that represent leaks in lower-level frameworks.
3815
3816         * Scripts/webkitpy/layout_tests/port/mac.py:
3817         (MacPort.is_lion): Added.
3818
3819         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3820         (MacPortTest.test_is_version_methods): Added tests for the is_leopard/is_snowleopard/is_lion
3821         methods.
3822
3823 2011-11-17  Philippe Normand  <pnormand@igalia.com>
3824
3825         [GTK] Disable ref tests
3826         https://bugs.webkit.org/show_bug.cgi?id=72599
3827
3828         Reviewed by Xan Lopez.
3829
3830         * Scripts/webkitpy/layout_tests/port/gtk.py: Enforce disabled ref
3831         tests to avoid massive flakiness.
3832
3833 2011-11-17  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3834
3835         [Qt] Move WebKit2 C++ APIs to private API and build QML extension plugin on top of that
3836
3837         A new extension object has been added to QQuickWebView (the same approach should be used
3838         for other API classes that need experimental APIs). The QML extension mechanism is then
3839         built on top of the experimental object.
3840
3841         https://bugs.webkit.org/show_bug.cgi?id=72522
3842
3843         Reviewed by Simon Hausmann.
3844
3845         * MiniBrowser/qt/BrowserWindow.cpp:
3846         (BrowserWindow::BrowserWindow):
3847         (BrowserWindow::webView):
3848         * MiniBrowser/qt/BrowserWindow.h:
3849         * MiniBrowser/qt/UrlLoader.cpp:
3850         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3851         * qmake/mkspecs/features/default_post.prf:
3852         * qmake/mkspecs/features/default_pre.prf:
3853         * qmake/mkspecs/features/qtwebkit-private.prf: Added.
3854         * qmake/mkspecs/features/qtwebkit.prf:
3855
3856 2011-11-17  Adam Barth  <abarth@webkit.org>
3857
3858         Move test_results_uploader.py out of layout_package
3859         https://bugs.webkit.org/show_bug.cgi?id=72590
3860
3861         Reviewed by Eric Seidel.
3862
3863         Most of the lines of code in this file are wrong, but I've restrained
3864         myself and only changed a few of them to generalized this class to the
3865         common package.
3866
3867         This is part of a series of patches to remove layout_package.
3868
3869         * Scripts/webkitpy/common/net/file_uploader.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py.
3870         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3871         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py: Removed.
3872
3873 2011-11-17  Adam Barth  <abarth@webkit.org>
3874
3875         Unreviewed. Fix style nits in printing.py.
3876
3877         * Scripts/webkitpy/layout_tests/views/printing.py:
3878
3879 2011-11-17  Adam Barth  <abarth@webkit.org>
3880
3881         Minor style nits in run_webkit_tests.py
3882         https://bugs.webkit.org/show_bug.cgi?id=72583
3883
3884         Reviewed by Eric Seidel.
3885
3886         This patch just fixes some minor style issues as I work my way back
3887         into this code.
3888
3889         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3890
3891 2011-11-17  Adam Barth  <abarth@webkit.org>
3892
3893         Move test_result_writer out of layout_package
3894         https://bugs.webkit.org/show_bug.cgi?id=72586
3895
3896         Rubber-stamped by Eric Seidel.
3897
3898         This is part of a series of patches to remove layout_package.
3899
3900         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3901         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py.
3902         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py: Removed.
3903         * Scripts/webkitpy/tool/commands/rebaseline.py:
3904
3905 2011-11-17  Adam Barth  <abarth@webkit.org>
3906
3907         svn-apply shouldn't magically move files into Source anymore
3908         https://bugs.webkit.org/show_bug.cgi?id=72579
3909
3910         Reviewed by Eric Seidel.
3911
3912         The Source directory has existed for long enough that we don't need
3913         svn-apply to magically re-write old-style patches anymore.
3914
3915         * Scripts/VCSUtils.pm:
3916         (parseGitDiffHeader):
3917         (parseSvnDiffHeader):
3918
3919 2011-11-16  Ryosuke Niwa  <rniwa@webkit.org>
3920
3921         Add a list of contribution areas
3922         https://bugs.webkit.org/show_bug.cgi?id=72566
3923
3924         Reviewed by Eric Seidel.
3925
3926         Added ContributionAreas class.
3927
3928         * Scripts/webkitpy/common/config/contributionareas.py: Added.
3929         * Scripts/webkitpy/common/config/contributionareas_unittest.py: Added.
3930
3931 2011-11-16  Ryosuke Niwa  <rniwa@webkit.org>
3932
3933         Refactor ChangeLogTest.test_parse_reviewer_text
3934         https://bugs.webkit.org/show_bug.cgi?id=72572
3935
3936         Reviewed by Eric Seidel.
3937
3938         Refactored the test code by introduing two helper functions.
3939
3940         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3941
3942 2011-11-16  Eric Seidel  <eric@webkit.org>
3943
3944         Add SCMDetector object to make scm detection mockable
3945         https://bugs.webkit.org/show_bug.cgi?id=72247
3946
3947         Reviewed by Adam Barth.
3948
3949         I think SCM detection may eventually be rolled into Checkout,
3950         but this patch at least makes it possible to mock code-paths
3951         which rely on scm detection.
3952         In the process of replacing callers of these free-functions
3953         I found that one of the functions was no longer used,
3954         and that one of the callers could instead just use the SCM
3955         object it already had access to through port.host.scm().
3956         I also discovered that I was not calling Host._initialize_scm()
3957         and thus host.scm() was always returning None!
3958
3959         * Scripts/check-webkit-style:
3960         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3961         * Scripts/webkitpy/common/checkout/deps.py:
3962         * Scripts/webkitpy/common/checkout/scm/__init__.py:
3963         * Scripts/webkitpy/common/checkout/scm/detection.py:
3964         * Scripts/webkitpy/common/checkout/scm/git.py:
3965         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3966         * Scripts/webkitpy/common/checkout/scm/svn.py:
3967         * Scripts/webkitpy/common/host.py:
3968         * Scripts/webkitpy/common/host_mock.py:
3969         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3970         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
3971         * Scripts/webkitpy/layout_tests/port/base.py:
3972         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
3973         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3974         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
3975         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
3976
3977 2011-11-16  Mark Rowe  <mrowe@apple.com>
3978
3979         Fix the build.
3980
3981         The C++ standard library interferes with Objective-C exceptions when built with -fno-exceptions.
3982         Apply the workaround that we use in other projects to WebKitTestRunner.
3983
3984         * WebKitTestRunner/Configurations/Base.xcconfig: Use the prefix header for all targets.
3985         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Ditto.
3986         * WebKitTestRunner/WebKitTestRunnerPrefix.h: Work around the C++ standard library obnoxiousness.
3987
3988 2011-11-16  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
3989
3990         [Qt] Fix build after WTR AX support
3991         https://bugs.webkit.org/show_bug.cgi?id=72560
3992
3993         Reviewed by Geoffrey Garen.
3994
3995         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
3996         * WebKitTestRunner/InjectedBundle/Target.pri:
3997
3998 2011-11-16  Tony Chang  <tony@chromium.org>
3999
4000         repurpose the flexbox bot for grid layout
4001         https://bugs.webkit.org/show_bug.cgi?id=72557
4002
4003         Reviewed by Ryosuke Niwa.
4004
4005         Since new flexbox is enabled everywhere, we don't need this bot
4006         anymore.  However, work on grid layout has begun, so we can use this
4007         bot to compile with ENABLE_CSS_GRID_LAYOUT.
4008
4009         * BuildSlaveSupport/build.webkit.org-config/config.json: Just rename
4010         the bot on the waterfall, I will change the slave config to enable
4011         the compile flag and tests.
4012
4013 2011-11-11  Adrienne Walker  <enne@google.com>
4014
4015         [chromium] Expose mock scrollbars to window.internals
4016         https://bugs.webkit.org/show_bug.cgi?id=72195
4017
4018         Reviewed by James Robinson.
4019
4020         Because mock scrollbars are a global setting, reset between runs.
4021
4022         * DumpRenderTree/chromium/WebPreferences.cpp:
4023         (WebPreferences::applyTo):
4024
4025 2011-11-16  James Robinson  <jamesr@chromium.org>
4026
4027         [chromium] Enable video and canvas 2d compositing triggers by default for layout tests in the compositing directory
4028         https://bugs.webkit.org/show_bug.cgi?id=72562
4029
4030         Reviewed by Dirk Pranke.
4031
4032         * DumpRenderTree/chromium/TestShell.cpp:
4033         (TestShell::runFileTest):
4034
4035 2011-11-16  Tony Chang  <tony@chromium.org>
4036
4037         [NRWT] speculative fix for multiple subprocess test on cygwin
4038         https://bugs.webkit.org/show_bug.cgi?id=72518
4039
4040         Reviewed by Adam Barth.
4041
4042         * Scripts/webkitpy/layout_tests/port/chromium.py: cygwin probably
4043             tries to emulate posix fd behavior.
4044         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
4045
4046 2011-11-16  Dirk Pranke  <dpranke@chromium.org>
4047
4048         Revert r100509; change was committed twice (first time as r100491).
4049         Unreviewed, build fix.
4050
4051         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
4052
4053 2011-11-16  Dirk Pranke  <dpranke@chromium.org>
4054
4055         Run a dummy test in the gpu configurations if there's nothing to do.
4056         https://bugs.webkit.org/show_bug.cgi?id=72498
4057
4058         Reviewed by James Robinson.
4059
4060         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
4061
4062 2011-11-16  Ryosuke Niwa  <rniwa@webkit.org>
4063
4064         contributors_by_fuzzy_match is super slow
4065         https://bugs.webkit.org/show_bug.cgi?id=72540
4066
4067         Reviewed by Eric Seidel.
4068
4069         Make contributors_by_name do case insensitive search using a dictionary.
4070
4071         Also call contributors_by_name first in contributors_by_fuzzy_match now that it's fast
4072         because that's the most common case.
4073
4074         * Scripts/webkitpy/common/config/committers.py:
4075         * Scripts/webkitpy/common/config/committers_unittest.py:
4076
4077 2011-11-16  David Levin  <levin@chromium.org>
4078
4079         check-webkit-style should recognize functions even if they have OVERRIDE after them.
4080         https://bugs.webkit.org/show_bug.cgi?id=72515
4081
4082         Reviewed by Adam Barth.
4083
4084         * Scripts/webkitpy/style/checkers/cpp.py:
4085         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4086
4087 2011-11-16  Tony Chang  <tony@chromium.org>
4088
4089         [NRWT] refactor drivers to require pixel_tests param
4090         https://bugs.webkit.org/show_bug.cgi?id=72517
4091
4092         Reviewed by Ojan Vafai.
4093
4094         No tests, just a refactoring.
4095
4096         * Scripts/webkitpy/layout_tests/port/chromium.py:
4097         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
4098         * Scripts/webkitpy/layout_tests/port/webkit.py:
4099         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
4100
4101 2011-11-16  Dirk Pranke  <dpranke@chromium.org>
4102
4103         Run a dummy test in the gpu configurations if there's nothing to do.
4104         https://bugs.webkit.org/show_bug.cgi?id=72498
4105
4106         Reviewed by James Robinson.
4107
4108         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
4109
4110 2011-11-16  Chris Fleizach  <cfleizach@apple.com>
4111
4112         WebKitTestRunner needs to support accessibility-related DRT APIs
4113         https://bugs.webkit.org/show_bug.cgi?id=42131
4114
4115         Reviewed by Beth Dakin.
4116
4117         Port the AX code in DRT to WKTestRunner by using IDL.
4118
4119         * DumpRenderTree/AccessibilityUIElement.cpp:
4120         (horizontalScrollbarCallback):
4121         (verticalScrollbarCallback):
4122         (AccessibilityUIElement::horizontalScrollbar):
4123         (AccessibilityUIElement::verticalScrollbar):
4124         (AccessibilityUIElement::getJSClass):
4125         * DumpRenderTree/AccessibilityUIElement.h:
4126         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
4127         (AccessibilityUIElement::horizontalScrollbar):
4128         (AccessibilityUIElement::verticalScrollbar):
4129         * WebKitTestRunner/DerivedSources.make:
4130         * WebKitTestRunner/GNUmakefile.am:
4131         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp: Added.
4132         (WTR::AccessibilityController::create):
4133         (WTR::AccessibilityController::AccessibilityController):
4134         (WTR::AccessibilityController::~AccessibilityController):
4135         (WTR::AccessibilityController::makeWindowObject):
4136         (WTR::AccessibilityController::wrapperClass):
4137         (WTR::AccessibilityController::rootElement):
4138         (WTR::AccessibilityController::focusedElement):
4139         (WTR::AccessibilityController::elementAtPoint):
4140         * WebKitTestRunner/InjectedBundle/AccessibilityController.h: Added.
4141         (WTR::AccessibilityController::logFocusEvents):
4142         (WTR::AccessibilityController::logValueChangeEvents):
4143         (WTR::AccessibilityController::logScrollingStartEvents):
4144         (WTR::AccessibilityController::logAccessibilityEvents):
4145         (WTR::AccessibilityController::addNotificationListener):
4146         (WTR::AccessibilityController::notificationReceived):
4147         (WTR::AccessibilityController::resetToConsistentState):
4148         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp: Added.
4149         (WTR::AccessibilityTextMarker::create):
4150         (WTR::AccessibilityTextMarker::AccessibilityTextMarker):
4151         (WTR::AccessibilityTextMarker::~AccessibilityTextMarker):
4152         (WTR::AccessibilityTextMarker::platformTextMarker):
4153         (WTR::AccessibilityTextMarker::wrapperClass):
4154         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.h: Added.
4155         (WTR::AccessibilityTextMarker::isEqual):
4156         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp: Added.
4157         (WTR::AccessibilityTextMarkerRange::create):
4158         (WTR::AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
4159         (WTR::AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
4160         (WTR::AccessibilityTextMarkerRange::platformTextMarkerRange):
4161         (WTR::AccessibilityTextMarkerRange::wrapperClass):
4162         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.h: Added.
4163         (WTR::AccessibilityTextMarkerRange::isEqual):
4164         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp: Added.
4165         (WTR::AccessibilityUIElement::create):
4166         (WTR::AccessibilityUIElement::wrapperClass):
4167         (WTR::AccessibilityUIElement::isValid):
4168         (WTR::AccessibilityUIElement::AccessibilityUIElement):
4169         (WTR::AccessibilityUIElement::~AccessibilityUIElement):
4170         (WTR::AccessibilityUIElement::isEqual):
4171         (WTR::AccessibilityUIElement::elementAtPoint):
4172         (WTR::AccessibilityUIElement::childAtIndex):
4173         (WTR::AccessibilityUIElement::indexOfChild):
4174         (WTR::AccessibilityUIElement::childrenCount):
4175         (WTR::AccessibilityUIElement::titleUIElement):
4176         (WTR::AccessibilityUIElement::parentElement):
4177         (WTR::AccessibilityUIElement::takeFocus):
4178         (WTR::AccessibilityUIElement::takeSelection):
4179         (WTR::AccessibilityUIElement::addSelection):
4180         (WTR::AccessibilityUIElement::removeSelection):
4181         (WTR::AccessibilityUIElement::allAttributes):
4182         (WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
4183         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
4184         (WTR::AccessibilityUIElement::attributesOfDocumentLinks):
4185         (WTR::AccessibilityUIElement::attributesOfChildren):
4186         (WTR::AccessibilityUIElement::parameterizedAttributeNames):
4187         (WTR::AccessibilityUIElement::increment):
4188         (WTR::AccessibilityUIElement::decrement):
4189         (WTR::AccessibilityUIElement::showMenu):
4190         (WTR::AccessibilityUIElement::press):
4191         (WTR::AccessibilityUIElement::stringAttributeValue):
4192         (WTR::AccessibilityUIElement::uiElementAttributeValue):
4193         (WTR::AccessibilityUIElement::numberAttributeValue):
4194         (WTR::AccessibilityUIElement::boolAttributeValue):
4195         (WTR::AccessibilityUIElement::isAttributeSupported):
4196         (WTR::AccessibilityUIElement::isAttributeSettable):
4197         (WTR::AccessibilityUIElement::isActionSupported):
4198         (WTR::AccessibilityUIElement::role):
4199         (WTR::AccessibilityUIElement::subrole):
4200         (WTR::AccessibilityUIElement::roleDescription):
4201         (WTR::AccessibilityUIElement::title):
4202         (WTR::AccessibilityUIElement::description):
4203         (WTR::AccessibilityUIElement::language):
4204         (WTR::AccessibilityUIElement::stringValue):
4205         (WTR::AccessibilityUIElement::accessibilityValue):
4206         (WTR::AccessibilityUIElement::helpText):
4207         (WTR::AccessibilityUIElement::orientation):
4208         (WTR::AccessibilityUIElement::x):
4209         (WTR::AccessibilityUIElement::y):
4210         (WTR::AccessibilityUIElement::width):
4211         (WTR::AccessibilityUIElement::height):
4212         (WTR::AccessibilityUIElement::intValue):
4213         (WTR::AccessibilityUIElement::minValue):
4214         (WTR::AccessibilityUIElement::maxValue):
4215         (WTR::AccessibilityUIElement::valueDescription):
4216         (WTR::AccessibilityUIElement::insertionPointLineNumber):
4217         (WTR::AccessibilityUIElement::selectedTextRange):
4218         (WTR::AccessibilityUIElement::isEnabled):
4219         (WTR::AccessibilityUIElement::isRequired):
4220         (WTR::AccessibilityUIElement::isFocused):
4221         (WTR::AccessibilityUIElement::isFocusable):
4222         (WTR::AccessibilityUIElement::isSelected):
4223         (WTR::AccessibilityUIElement::isSelectable):
4224         (WTR::AccessibilityUIElement::isMultiSelectable):
4225         (WTR::AccessibilityUIElement::setSelectedChild):
4226         (WTR::AccessibilityUIElement::selectedChildrenCount):
4227         (WTR::AccessibilityUIElement::selectedChildAtIndex):
4228         (WTR::AccessibilityUIElement::isExpanded):
4229         (WTR::AccessibilityUIElement::isChecked):
4230         (WTR::AccessibilityUIElement::isVisible):
4231         (WTR::AccessibilityUIElement::isOffScreen):
4232         (WTR::AccessibilityUIElement::isCollapsed):
4233         (WTR::AccessibilityUIElement::isIgnored):
4234         (WTR::AccessibilityUIElement::hasPopup):
4235         (WTR::AccessibilityUIElement::hierarchicalLevel):
4236         (WTR::AccessibilityUIElement::clickPointX):
4237         (WTR::AccessibilityUIElement::clickPointY):
4238         (WTR::AccessibilityUIElement::documentEncoding):
4239         (WTR::AccessibilityUIElement::documentURI):
4240         (WTR::AccessibilityUIElement::url):
4241         (WTR::AccessibilityUIElement::speak):
4242         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
4243         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
4244         (WTR::AccessibilityUIElement::attributesOfColumns):
4245         (WTR::AccessibilityUIElement::attributesOfRows):
4246         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
4247         (WTR::AccessibilityUIElement::attributesOfHeader):
4248         (WTR::AccessibilityUIElement::indexInTable):
4249         (WTR::AccessibilityUIElement::rowIndexRange):
4250         (WTR::AccessibilityUIElement::columnIndexRange):
4251         (WTR::AccessibilityUIElement::rowCount):
4252         (WTR::AccessibilityUIElement::columnCount):
4253         (WTR::AccessibilityUIElement::selectedRowAtIndex):
4254         (WTR::AccessibilityUIElement::disclosedByRow):
4255         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
4256         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
4257         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
4258         (WTR::AccessibilityUIElement::ariaIsGrabbed):
4259         (WTR::AccessibilityUIElement::ariaDropEffects):
4260         (WTR::AccessibilityUIElement::lineForIndex):
4261         (WTR::AccessibilityUIElement::rangeForLine):
4262         (WTR::AccessibilityUIElement::boundsForRange):
4263         (WTR::AccessibilityUIElement::setSelectedTextRange):
4264         (WTR::AccessibilityUIElement::stringForRange):
4265         (WTR::AccessibilityUIElement::attributedStringForRange):
4266         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
4267         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
4268         (WTR::AccessibilityUIElement::cellForColumnAndRow):
4269         (WTR::AccessibilityUIElement::horizontalScrollbar):
4270         (WTR::AccessibilityUIElement::verticalScrollbar):
4271         (WTR::AccessibilityUIElement::addNotificationListener):
4272         (WTR::AccessibilityUIElement::removeNotificationListener):
4273         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
4274         (WTR::AccessibilityUIElement::textMarkerRangeLength):
4275         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
4276         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
4277         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
4278         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
4279         (WTR::AccessibilityUIElement::textMarkerForPoint):
4280         (WTR::AccessibilityUIElement::previousTextMarker):
4281         (WTR::AccessibilityUIElement::nextTextMarker):
4282         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
4283