ebdf72225a8093d40ef9693910632b214ba25318
[WebKit-https.git] / Tools / ChangeLog
1 2014-06-10  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2
3         Unreviewed, update my list of email addresses in contributors.json.
4
5         * Scripts/webkitpy/common/config/contributors.json:
6
7 2014-06-10  Simon Fraser  <simon.fraser@apple.com>
8
9         Always switch to an sRGB screen color profile when running tests
10         https://bugs.webkit.org/show_bug.cgi?id=133712
11
12         Reviewed by Tim Horton.
13         
14         Switch the screen color profile to sRGB when running tests, because even ref
15         tests need the screen to use the correct color profile.
16
17         * DumpRenderTree/mac/LayoutTestHelper.m:
18         (installLayoutTestColorProfile):
19         * Scripts/webkitpy/port/mac.py:
20         (MacPort.start_helper):
21
22 2014-06-10  Martin Hodovan  <mhodovan@partner.samsung.com>
23
24         [EFL] Bump EFL libraries to 1.9
25         https://bugs.webkit.org/show_bug.cgi?id=125479
26
27         Reviewed by Gyuyoung Kim.
28
29         Based on the work of Ryuan Choi <ryuan.choi@samsung.com>
30         and László Langó <llango.u-szeged@partner.samsung.com>.
31
32         * ImageDiff/CMakeLists.txt:
33         * MiniBrowser/efl/CMakeLists.txt:
34         * efl/install-dependencies:
35         * efl/jhbuild.modules:
36         * efl/jhbuildrc:
37
38 2014-06-10  David Farler  <dfarler@apple.com>
39
40         old-run-webkit-tests: Create CoreSimulator device on demand and find it by name
41         https://bugs.webkit.org/show_bug.cgi?id=133663
42
43         Reviewed by David Kilzer.
44
45         * Scripts/old-run-webkit-tests:
46         (installAndLaunchDumpToolAppUsingNotification):
47         - Remove obsolete notification keys
48         - Key off of mandatory device UDID (a UUID)
49         - Create a device on demand via CoreSimulator if necessary
50         -- Grab the UDID from the created device plist.
51         * Scripts/webkitdirs.pm:
52         (iOSSimulatorDevicesPath): Added
53         (iOSSimulatorDevices): Added
54         (createiOSSimulatorDevice): Added
55         (deleteiOSSimulatorDevice): Added
56
57 2014-06-10  Víctor Manuel Jáquez Leal  <vjaquez@igalia.com>
58
59         [GTK][gtkdoc] remove -Wcast-align
60         https://bugs.webkit.org/show_bug.cgi?id=133640
61
62         Apparently gcc warns that GParamSpec is not castable to
63         GParamSpecInt64/GParamSpecUInt64/GParamSpecDouble due they are 64bit, even
64         though ARM hackers claim that those only need 4byte alignment. As long as gcc
65         behaves that way, this warning is not very useful, also they break the Debian
66         packaging.
67
68         This patch appends the compiler flag -Wno-align-cast for the gtkdoc
69         scanner compilation, thus the compiler ignores the previous
70         -Waling-cast flag.
71
72         Reviewed by Martin Robinson.
73
74         * gtk/generate-gtkdoc:
75         (get_generator_for_config):
76
77 2014-06-09  Alexey Proskuryakov  <ap@apple.com>
78
79         Disable button animations in regression tests
80         https://bugs.webkit.org/show_bug.cgi?id=133647
81         <rdar://problem/16677530>
82
83         Reviewed by Tim Horton.
84
85         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
86         (WTR::InjectedBundle::platformInitialize):
87
88 2014-06-09  Simon Fraser  <simon.fraser@apple.com>
89
90         Move scrolling-related tests to tiled-drawing/scrolling subdirectory, and minor cleanup
91         https://bugs.webkit.org/show_bug.cgi?id=133650
92
93         Reviewed by Tim Horton.
94         
95         No point checking for a Windows-style path in Cocoa code.
96
97         * WebKitTestRunner/TestInvocation.cpp:
98         (WTR::shouldUseThreadedScrolling):
99
100 2014-06-09  Simon Fraser  <simon.fraser@apple.com>
101
102         Fix more latched scrolling test flakiness and slowness
103         https://bugs.webkit.org/show_bug.cgi?id=133601
104
105         Reviewed by Brent Fulgham.
106         
107         Latched scrolling tests were flakey for two reasons. First, the EventSender
108         wheel events were async from the web to the UI process, and the resulting
109         synthetic events also async from the UI to the web process. Make them sync
110         for testing.
111         
112         Secondly, the timer-based scrolling tree commit could result in the scrolling
113         tree (specifically the frame node's notion of the scrollable area and content
114         size) not being updated before the scrolling thread starts getting wheel events.
115         Fix by having WebPage::wheelEventSyncForTesting() commit if necessary.
116         
117         Finally remove all the now-unnecessary timeouts from the tests.
118
119         * WebKitTestRunner/mac/EventSenderProxy.mm:
120         (WTR::EventSenderProxy::mouseMoveTo):
121         (WTR::EventSenderProxy::mouseScrollBy):
122         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
123
124 2014-06-09  Andrzej Badowski  <a.badowski@samsung.com>
125
126         [EFL] Add parameter to MiniBrowser to disable web security
127         https://bugs.webkit.org/show_bug.cgi?id=121095
128
129         Reviewed by Gyuyoung Kim.
130
131         -w (--web-security) commandline allows to disable/enable web security (enabled by default).
132         The reason for this is to test and debug (using, for example, MiniBrowser) scripts accessing
133         resources from other domains (cross-domain requests) such as access map location on another server.
134         Another possibility is to launch in a webkit browser local file tests that will refer to the links
135         in the http website loaded in an iframe. It will not be possible without deactivation of web security.
136
137         * MiniBrowser/efl/main.c:
138         (window_create):
139         (elm_main):
140
141 2014-06-06  Simon Fraser  <simon.fraser@apple.com>
142
143         32-bit build fix.
144
145         * WebKitTestRunner/mac/EventSenderProxy.mm:
146         (WTR::EventSenderProxy::mouseMoveTo):
147         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
148
149 2014-06-06  Simon Fraser  <simon.fraser@apple.com>
150
151         Fix builds on 10.8; -firstObject isn't declared on NSArray there.
152
153         * DumpRenderTree/mac/DumpRenderTree.mm:
154         (createWebViewAndOffscreenWindow):
155         * DumpRenderTree/mac/EventSendingController.mm:
156         (-[EventSendingController mouseScrollByX:andY:continuously:]):
157         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
158         * WebKitTestRunner/mac/EventSenderProxy.mm:
159         (WTR::EventSenderProxy::mouseScrollBy):
160         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
161
162 2014-06-06  Simon Fraser  <simon.fraser@apple.com>
163
164         Latched scrolling tests are flakey on Mavericks
165         https://bugs.webkit.org/show_bug.cgi?id=133578
166         <rdar://problem/17180591>
167
168         Reviewed by Brent Fulgham.
169         
170         The latched scrolling tests rely on synthetic mousewheel events whose coordinates can
171         be wrong on machines with more than one screen. This is because we use
172         [NSScreen mainScreen] when computing the global coordinates of the events, but
173         [NSScreen mainScreen] returns the screen with the key window, not the first screen.
174         
175         So replace calls to [NSScreen mainScreen] with [[NSScreen screens] firstObject]. Also
176         add comments clarifying why the coordinate math works (which is not obvious given
177         the events have no target window).
178         
179         Some scrolling tests also dispatched events outside the 800x600 test window, so
180         fix those tests, and add logging that will appear in test output when this happens.
181
182         * DumpRenderTree/mac/DumpRenderTree.mm:
183         (createWebViewAndOffscreenWindow):
184         * DumpRenderTree/mac/EventSendingController.mm:
185         (-[EventSendingController mouseScrollByX:andY:continuously:]):
186         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
187         * WebKitTestRunner/mac/EventSenderProxy.mm:
188         (WTR::EventSenderProxy::mouseMoveTo):
189         (WTR::EventSenderProxy::mouseScrollBy):
190         (WTR::EventSenderProxy::continuousMouseScrollBy):
191         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
192
193 2014-06-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
194
195         [GTK] run-perf-tests should run the tests inside the jhbuild shell.
196         https://bugs.webkit.org/show_bug.cgi?id=133533
197
198         Reviewed by Carlos Garcia Campos.
199
200         * Scripts/webkitpy/common/multiprocessing_bootstrap.py:
201         (run): Remove the jhbuild-wrapper wrapper from here. It should be
202         on Scripts/webkitpy/port/gtk.py.
203         * Scripts/webkitpy/port/base.py:
204         (Port.set_option): Add a set_option(name, value) function to set
205         the optparse parameter "name" to the value "value", even if the
206         parameter "name" is already initialized.
207         * Scripts/webkitpy/port/gtk.py:
208         (GtkPort.__init__): Set the default wrapper to jhbuild-wrapper.
209         If another wrapper is specified via the option "-l --wrapper=x",
210         then prepend the jhbuild-wrapper to the one specified.
211
212 2014-06-04  David Farler  <dfarler@apple.com>
213
214         Build ASan WebKit for iOS Simulator
215         https://bugs.webkit.org/show_bug.cgi?id=133489
216
217         Reviewed by Darin Adler.
218
219         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
220         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
221         - Add missing ASan LDFLAGS.
222         * asan/asan.xcconfig:
223         - Split compiler-rt linker flags for OS X and iOS Simulator
224
225 2014-06-03  Yoav Weiss  <yoav@yoav.ws>
226
227         Add myself (yoav@yoav.ws) to contributors.json
228         https://bugs.webkit.org/show_bug.cgi?id=133492
229
230         * Scripts/webkitpy/common/config/contributors.json:
231
232 2014-06-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
233
234         REGRESSION(r169092 and r169102): Skip failing JSC tests poperly on non-x86 Darwin platforms
235         https://bugs.webkit.org/show_bug.cgi?id=133149
236
237         Reviewed by Csaba Osztrogonác.
238
239         * Scripts/run-jsc-stress-tests: Added determineOS to determine the host operating system the script run on.
240
241 2014-06-02  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
242
243         Add a verbose flag to binding tests
244         https://bugs.webkit.org/show_bug.cgi?id=122303
245
246         Reviewed by Csaba Osztrogonác.
247
248         This patch will:
249         - Add a verbose keyword argument to the BindingsTests constructor,
250         - Add --no-verbose option to the run-bindigs-test.
251         Verbose mode, which is on by default, prints positive results to stdout as before.
252         When the --no-verbose option added to run-bindings-tests, positive results are not printed at all.
253
254         Original patch from Matthew Hanson <matthew_hanson@apple.com>
255
256         * Scripts/run-bindings-tests:
257         (main):
258         * Scripts/webkitpy/bindings/main.py:
259         (BindingsTests.__init__):
260         (BindingsTests.detect_changes):
261
262 2014-06-01  Ryosuke Niwa  <rniwa@webkit.org>
263
264         Rename DoYouEvenBench 0.17 to Speedometer 1.0 and add a new look.
265         https://bugs.webkit.org/show_bug.cgi?id=133455
266
267         Reviewed by Timothy Hatcher.
268
269         Since the perf. dashboard doesn't support following renamed benchmarks,
270         keep reporting Speedometer results as DoYouEvenBench results.
271
272         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
273         (_generate_results_dict):
274
275 2014-05-31  Darin Adler  <darin@apple.com>
276
277         Viewport percentage tests that resize the viewport are flaky
278         https://bugs.webkit.org/show_bug.cgi?id=133351
279
280         Reviewed by Anders Carlsson.
281
282         * DumpRenderTree/mac/DumpRenderTree.mm:
283         (sizeWebViewForCurrentTest): Added a call to reset the window origin, which
284         happens to be stored in the UI delegate object. This is part of resetting the
285         window position.
286
287         * DumpRenderTree/mac/UIDelegate.h: Store the window origin rather than storing
288         a frame rectangle. The size is stored in the size of the web view itself.
289         * DumpRenderTree/mac/UIDelegate.mm:
290         (-[UIDelegate resetWindowOrigin]): Added.
291         (-[UIDelegate webView:setFrame:]): Changed to set the size of the web view. The
292         old version would store the frame, but not resize the web view!
293         (-[UIDelegate webViewFrame:]): Get the size from the web view.
294
295         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
296         (WTR::PlatformWebView::setWindowFrame): Added code to resize the web view.
297
298         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
299         (WTR::PlatformWebView::resizeTo): Added a comment about missing code to resize
300         the window.
301
302         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
303         (WTR::PlatformWebView::resizeTo): Changed this to call setWindowFrame so the
304         window gets resized too, not just the web view.
305         (WTR::PlatformWebView::setWindowFrame): Added code to set the size of the web view.
306
307         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
308         (WTR::PlatformWebView::resizeTo): Changed this to call setWindowFrame so the
309         window gets resized too, not just the web view.
310         (WTR::PlatformWebView::setWindowFrame): Added code to set the size of the web view.
311
312 2014-05-30  Michael Saboff  <msaboff@apple.com>
313
314         Change run-jsc-stress-tests to not resolve jsc path locally when creating a bundle
315         https://bugs.webkit.org/show_bug.cgi?id=133409
316
317         Reviewed by Filip Pizlo.
318
319         Handle creating a tarball the same way as running remote when processing
320         paths in prepareBundle.
321
322         * Scripts/run-jsc-stress-tests:
323
324 2014-05-30  Mario Sanchez Prada  <mario.prada@samsung.com>
325
326         [ATK] Deprecate usage of logAccessibilityEvents() in layout tests
327         https://bugs.webkit.org/show_bug.cgi?id=132280
328
329         Reviewed by Chris Fleizach.
330
331         Remove implementation of logAccessibilityEvents() for ATK based
332         ports, as this has proved to be a flaky method of checking that
333         ATK events are being properly emitted. Instead, it's better to use
334         the addNotificationListener() functions and provide a JS callback
335         to check that the right events are being emmitted from the tests.
336
337         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
338         (WTR::AccessibilityController::logAccessibilityEvents): Replaced
339         with dummy implementation.
340         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
341         (WTR::AccessibilityNotificationHandler::logAccessibilityEvents): Removed
342
343 2014-05-30  Mario Sanchez Prada  <mario.prada@samsung.com>
344
345         [ATK] Deprecate usage of logAccessibilityEvents() in layout tests
346         https://bugs.webkit.org/show_bug.cgi?id=132280
347
348         Rubber stamped by Carlos Garcia Campos.
349
350         Fix two small issues with previous patch (r169483), that caused some tests to break.
351
352         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
353         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Removed
354         duplicated entry.
355         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
356         (WTR::AccessibilityUIElement::setSelectedTextRange): Fix boolean condition.
357
358 2014-05-30  Jarek Czekalski  <jarekczek@poczta.onet.pl>
359
360         [ATK] Added new accessibility signal: text-caret-moved.
361         Make AccessibilityUIElement.setSelectedTextRange work
362         as atk_text_set_caret_offset when given offset == 0.
363         https://bugs.webkit.org/show_bug.cgi?id=132527
364
365         Reviewed by Mario Sanchez Prada.
366
367         text-caret-moved signal in accessibilityController is needed to
368         implement tests from Tools/TestWebKitAPI/Tests/WebKitGtk/testatk.c
369         as LayoutTests. Add the signal to the controller.
370
371         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
372         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
373         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
374         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
375         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
376         (setSelectedTextRange): Change return type to bool.
377         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
378         (setSelectedTextRange): Call atk_text_set_caret_offset and return bool.
379         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
380         (axObjectEventListener): Add notification name AXTextCaretMoved, allow
381         for extra arguments passed to handler and use it for text-caret-moved offset.
382         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
383         Connect callback to new listener for ATK:AtkText:text-caret-moved.
384         Refactor so that failures be reported.
385         Initialize atk interfaces before trying to connect to them, see
386         https://bugzilla.gnome.org/show_bug.cgi?id=729922
387         (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
388         Simplify code by using a vector in place of dozen variables.
389         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
390         Comment about not synchronizing with accessibilityController.
391
392 2014-05-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
393
394         [GTK] Add a WebKit2 Performance bot.
395         https://bugs.webkit.org/show_bug.cgi?id=132862
396
397         Reviewed by Csaba Osztrogonác.
398
399         This adds a GTK WebKit2 perf bot.
400
401         * BuildSlaveSupport/build.webkit.org-config/config.json:
402
403 2014-05-29  Dan Bernstein  <mitz@apple.com>
404
405         Fixed the WebKitTestRunner build after r169452.
406
407         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
408         (WTR::InjectedBundle::initialize):
409
410 2014-05-28  Gwang Yoon Hwang  <yoon@igalia.com>
411
412         Unreviewed. Update my email addresses in contributors.json.
413
414         * Scripts/webkitpy/common/config/contributors.json:
415
416 2014-05-27  Jon Honeycutt  <jhoneycutt@apple.com>
417
418         Need an API test for bug #133193 (r169315)
419         <https://bugs.webkit.org/show_bug.cgi?id=133324>
420
421         This adds an API test that ensures that calling "stop loading" during a
422         "did fail provisional load" callback doesn't crash.
423
424         Reviewed by Andy Estes.
425
426         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
427         Add new files to project.
428
429         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp: Added.
430         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
431         If the message is the "test done" message, record that.
432         (TestWebKitAPI::setInjectedBundleClient):
433         Register a function for the "did receive message from injected bundle"
434         callback.
435         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
436         Assert that we received the message from the injected bundle, and set
437         'done' to finish the test.
438         (TestWebKitAPI::TEST):
439         Create a WebView, register a page loader client for the "did fail
440         provisional load" callback, and load a non-existent resource.
441
442         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp: Added.
443         (TestWebKitAPI::StopLoadingDuringDidFailProvisionalLoadTest::StopLoadingDuringDidFailProvisionalLoadTest):
444         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrameCallback):
445         Tell the StopLoadingDuringDidFailProvisionalLoadTest object that the
446         provisional load failed.
447         (TestWebKitAPI::StopLoadingDuringDidFailProvisionalLoadTest::didCreatePage):
448         Register a page loader client for the "did fail provisional load"
449         callback.
450         (TestWebKitAPI::StopLoadingDuringDidFailProvisionalLoadTest::didFailProvisionalLoad):
451         Call WKBundlePageStopLoading() during the callback. This not crashing
452         is what we're ensuring with this test.
453
454 2014-05-28  Carlos Garcia Campos  <cgarcia@igalia.com>
455
456         [GTK] Make it possible to build with FTL enabled
457         https://bugs.webkit.org/show_bug.cgi?id=133219
458
459         Reviewed by Philippe Normand.
460
461         * gtk/jhbuild-optional.modules: Add llvm from svn and build the
462         same revision than mac.
463
464 2014-05-27  Michael Saboff  <msaboff@apple.com>
465
466         REGRESSION(r169265): sh: line 0: cd: ../.vm
467         https://bugs.webkit.org/show_bug.cgi?id=133242
468
469         Rubber stamped by Oliver Hunt.
470
471         Changed runAndMonitorTestRunnerCommand() to pass mysys as a string instead of an
472         array since the command may contain character escapes that don't work with the
473         array form of system().
474
475         * Scripts/run-jsc-stress-tests:
476
477 2014-05-27  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
478
479         [EFL] Change download url of freetype6
480         https://bugs.webkit.org/show_bug.cgi?id=133303
481
482         Reviewed by Csaba Osztrogonác.
483
484         freetype6 tarball isn't downloaded in Korea. So, we need to
485         change the url for now.
486
487         * efl/jhbuild.modules:
488
489 2014-05-27  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
490
491         Remove BLOB guards
492         https://bugs.webkit.org/show_bug.cgi?id=132863
493
494         Reviewed by Csaba Osztrogonác.
495
496         * Scripts/webkitperl/FeatureList.pm:
497
498 2014-05-27  Alberto Garcia  <berto@igalia.com>
499
500         Remove leftover comment from r165182.
501
502         Rubber stamped by Carlos Garcia Campos.
503
504         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
505
506 2014-05-26  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
507
508         [EFL] Add LLVM as optional jhbuild module for FTL developers
509         https://bugs.webkit.org/show_bug.cgi?id=133216
510
511         Reviewed by Gyuyoung Kim.
512
513         * efl/jhbuild.modules:
514
515 2014-05-26  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
516
517         Fix test failures on python test
518         https://bugs.webkit.org/show_bug.cgi?id=133297
519
520         Reviewed by Dirk Schulze.
521
522         2 tests are failing because of unbounded local variable reference in test_importer.py.
523
524         * Scripts/webkitpy/w3c/test_importer.py: Move local variable declaration to top.
525         (TestImporter.import_tests):
526
527 2014-05-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
528
529         [GTK] GObject DOM bindings API break test fails in the tests bots
530         https://bugs.webkit.org/show_bug.cgi?id=133211
531
532         Reviewed by Martin Robinson.
533
534         When generating the built product archive on platform GTK, we need
535         to copy also the file gtkdoc-webkitdom.cfg and the directory
536         DerivedSources/webkitdom.
537
538         * BuildSlaveSupport/built-product-archive:
539         (archiveBuiltProduct):
540
541 2014-05-26  Commit Queue  <commit-queue@webkit.org>
542
543         Unreviewed, rolling out r169122.
544         https://bugs.webkit.org/show_bug.cgi?id=133288
545
546         Broke CJK font fallback (Requested by ap on #webkit).
547
548         Reverted changeset:
549
550         "[Mac] WebProcess doesn't follow localization of UI process
551         when run as a service"
552         https://bugs.webkit.org/show_bug.cgi?id=133126
553         http://trac.webkit.org/changeset/169122
554
555 2014-05-26  Carlos Garcia Campos  <cgarcia@igalia.com>
556
557         [GTK] WebProcess leaked when closing pages with network process enabled
558         https://bugs.webkit.org/show_bug.cgi?id=129684
559
560         Reviewed by Anders Carlsson.
561
562         Enable the test to check that web processes finish when the web
563         view is destroyed.
564
565         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
566
567 2014-05-26  Carlos Garcia Campos  <cgarcia@igalia.com>
568
569         REGRESSION(r164632): [GTK] Crash in generate-gtkdoc when rebasing docs
570         https://bugs.webkit.org/show_bug.cgi?id=133279
571
572         Reviewed by Philippe Normand.
573
574         generator.saw_warnings is only set by GTKDoc::generate(), so it
575         should only be used after generate.
576
577         * gtk/generate-gtkdoc:
578         (generate_documentation_for_config): Do not check
579         generator.saw_warnings again, simply return the value returned by
580         generate_doc() which is generator.saw_warnings. When rebasing,
581         returns always False since there aren't warnings.
582
583 2014-05-26  Youenn Fablet  <youenn.fablet@crf.canon.fr>
584
585         W3C test importer should catch exceptions coming from HTML/CSS conversion
586         https://bugs.webkit.org/show_bug.cgi?id=133176
587
588         Reviewed by Darin Adler.
589
590         Exceptions raised when converting HTML/CSS are caught.
591         Files for which conversion failed are still copied to the target directory.
592         Each individual conversion failure is logged.
593         Total conversion failure number is logged at the end of the import process.
594
595         * Scripts/webkitpy/w3c/test_importer.py:
596         (TestImporter.import_tests):
597
598 2014-05-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
599
600         [GTK] Allow to run the tests on the native X display.
601         https://bugs.webkit.org/show_bug.cgi?id=133157
602
603         Reviewed by Benjamin Poulain.
604
605         This adds a new driver (xorgdriver) that runs the tests on the
606         X display referenced by the environment variable DISPLAY.
607
608         This new driver will be activated only if the environment variable
609         USE_NATIVE_XDISPLAY is defined. This can be used both for layout
610         tests and performance tests.
611
612         This patch also makes the script run-perf-tests to check the
613         system dependencies before starting the tests. Previously this
614         was not checked, and if the system dependencies were not met,
615         the script tried to execute the tests anyway, causing massive
616         failures. For example, if you had Xvfb not installed and you
617         wanted to use the Xvfb driver (the default on GTK and EFL),
618         run-perf-tests would not abort.
619
620         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
621         (PerfTestsRunner._parse_args): Check the system dependencies of
622         the driver before starting the tests.
623         * Scripts/webkitpy/port/driver.py:
624         (Driver): Implement generic check_driver method.
625         (Driver.check_driver):
626         (Driver.check_driver.implementation):
627         * Scripts/webkitpy/port/gtk.py:
628         (GtkPort._driver_class): Check for environment variable
629         USE_NATIVE_XDISPLAY to decide if the Xorg driver should be used.
630         * Scripts/webkitpy/port/xorgdriver.py: Added.
631         (XorgDriver): Implement Xorg driver.
632         (XorgDriver.check_driver):
633         (XorgDriver._start):
634
635 2014-05-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
636
637         REGRESSION(r166798): [GTK] [EFL] kill-old-processes should not kill dbus-daemon
638         https://bugs.webkit.org/show_bug.cgi?id=133215
639
640         Reviewed by Csaba Osztrogonác.
641
642         This reverts r166798.
643
644         * BuildSlaveSupport/kill-old-processes:
645         (main):
646
647 2014-05-26  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
648
649         [EFL] Turn on ENABLE_CSS_FILTERS in build script
650         https://bugs.webkit.org/show_bug.cgi?id=133278
651
652         Reviewed by Gyuyoung Kim.
653
654         * Scripts/webkitperl/FeatureList.pm: Add a build script condition missing in r169172.
655
656 2014-05-26  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
657
658         run-javascriptcore-tests warning fix on non Mac platforms
659         https://bugs.webkit.org/show_bug.cgi?id=133260
660
661         Reviewed by Darin Adler.
662
663         * Scripts/webkitdirs.pm:
664         (argumentsForConfiguration):
665
666 2014-05-23  Michael Saboff  <msaboff@apple.com>
667
668         REGRESSION(r169265): sh: line 0: cd: ../.vm
669         https://bugs.webkit.org/show_bug.cgi?id=133242
670
671         Rubber stamped by Geoffrey Garen.
672
673         Added missing shell escapes '\' required as part of previous fix.
674
675         * Scripts/run-jsc-stress-tests:
676
677 2014-05-23  Ryosuke Niwa  <rniwa@webkit.org>
678
679         Revert the erroneous change committed in r169286.
680
681         * Scripts/webkitpy/performance_tests/perftest.py:
682         (PerfTest._run_with_driver):
683
684 2014-05-23  Geoffrey Garen  <ggaren@apple.com>
685
686         run-perf-tests should ignore whitespace lines when snarfing test output
687         https://bugs.webkit.org/show_bug.cgi?id=133238
688
689         Reviewed by Ryosuke Niwa.
690
691         Required for PerformanceTests/Canvas/terrain.html.
692
693         * Scripts/webkitpy/performance_tests/perftest.py:
694         (PerfTest._run_with_driver):
695         (PerfTest):
696
697 2014-05-23  Michael Saboff  <msaboff@apple.com>
698
699         REGRESSION (r169241) Crash running run-jsc-stress-tests on EFL ARM
700         https://bugs.webkit.org/show_bug.cgi?id=133223
701
702         Reviewed by Geoffrey Garen.
703
704         Change runAndMonitorTestRunnerCommand() to convert the *cmd argument to a
705         string before calling IO.popen() to work with older versions of ruby.
706         Changed the remote path in runShellTestRunner to quote the command
707         string we want to run via ssh so that it will work correctly with array
708         to string conversion needed for popen.
709
710         * Scripts/run-jsc-stress-tests:
711
712 2014-05-23  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
713
714         Remove 'css-shaders' option from the build-webkit
715         https://bugs.webkit.org/show_bug.cgi?id=133212
716
717         Reviewed by Daniel Bates.
718
719         Original CSS shaders removed in r162644.
720
721         * Scripts/webkitperl/FeatureList.pm:
722
723 2014-05-23  Carlos Garcia Campos  <cgarcia@igalia.com>
724
725         [GTK] GObject DOM bindings API break test should fail in the bots when the command fails to run
726         https://bugs.webkit.org/show_bug.cgi?id=133209
727
728         Reviewed by Sergio Villar Senin.
729
730         Return FAILURE when the command failed to run.
731
732         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
733         (RunGtkWebKitGObjectDOMBindingsAPIBreakTests.evaluateCommand):
734
735 2014-05-23  Alberto Garcia  <berto@igalia.com>
736
737         [GTK] Install libharfbuzz-dev in Tools/gtk/install-dependencies
738         https://bugs.webkit.org/show_bug.cgi?id=133210
739
740         Reviewed by Carlos Garcia Campos.
741
742         * gtk/install-dependencies:
743
744 2014-05-22  Benjamin Poulain  <bpoulain@apple.com>
745
746         Add Yusuke Suzuki to the list of contributors (for real)
747
748         Wrong section...
749
750         * Scripts/webkitpy/common/config/contributors.json:
751
752 2014-05-22  Benjamin Poulain  <bpoulain@apple.com>
753
754         Add Yusuke Suzuki to the list of contributors
755
756         * Scripts/webkitpy/common/config/contributors.json:
757
758 2014-05-22  Michael Saboff  <msaboff@apple.com>
759
760         Eliminate n/total progress update from run-jsc-stress-tests output to file
761         https://bugs.webkit.org/show_bug.cgi?id=133191
762
763         Reviewed by Geoffrey Garen.
764
765         Changed progressMeter setting to be based on stdout being a tty instead of
766         stdin.  Unified the processing of output from the shell runner to match the
767         same processing as is used by the makefile runner.  As part of this, the 
768         shell runner script was simplified.  It now forwards the output of each
769         test_script just like the Makefile and doesn't provide its own progress.
770
771         * Scripts/jsc-stress-test-helpers/shell-runner.sh:
772         * Scripts/run-jsc-stress-tests:
773
774 2014-05-22  Michael Saboff  <msaboff@apple.com>
775
776         Add option to run-jsc-stress-tests to use installed jsc
777         https://bugs.webkit.org/show_bug.cgi?id=133102
778
779         Reviewed by Geoffrey Garen.
780
781         Added --no-copy option to not copy a JavaScriptCore framework, but use the one
782         provied with the --jsc option.
783
784         * Scripts/run-jsc-stress-tests:
785
786 2014-05-21  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
787
788         [EFL] Add include path of compact_unwind_encoding.h if FTL JIT is enabled
789         https://bugs.webkit.org/show_bug.cgi?id=132907
790
791         Reviewed by Gyuyoung Kim.
792
793         We need the mach-o/compact_unwind_encoding.h header from libc++abi-dev package
794         in JavaScriptCore/ftl/FTLUnwindInfo.cpp when FTL JIT is enabled.
795
796         * efl/install-dependencies:
797
798 2014-05-21  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
799
800         REGRESSION(r169092): It broke run-jsc-stress tests on non Mac platforms
801         https://bugs.webkit.org/show_bug.cgi?id=133145
802
803         Reviewed by Csaba Osztrogonác.
804
805         * Scripts/run-jsc-stress-tests:
806
807 2014-05-20  Alexey Proskuryakov  <ap@apple.com>
808
809         [Mac] WebProcess doesn't follow localization of UI process when run as a service
810         https://bugs.webkit.org/show_bug.cgi?id=133126
811         <rdar://problem/13396515>
812         <rdar://problem/16561084>
813
814         Reviewed by Sam Weinig and Tim Horton.
815
816         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
817         (WTR::InjectedBundle::platformInitialize): It was too late to override language
818         here, and it's not necessary any more. Keeping the code for older OS versions in
819         case it did have effect in some code paths.
820
821 2014-05-19  David Farler  <dfarler@apple.com>
822
823         Move WebKitTestRunner to std::unique_ptr
824         https://bugs.webkit.org/show_bug.cgi?id=133081
825
826         Reviewed by Daniel Bates.
827
828         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
829         (WTR::InjectedBundle::didCreatePage):
830         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
831         * WebKitTestRunner/TestController.cpp:
832         (WTR::TestController::initialize):
833         (WTR::TestController::createWebViewWithOptions):
834         (WTR::TestController::resetStateToConsistentValues):
835         (WTR::TestController::runTest):
836         * WebKitTestRunner/TestController.h:
837         * WebKitTestRunner/TestInvocation.cpp:
838         * WebKitTestRunner/TestInvocation.h:
839         * WebKitTestRunner/WorkQueueManager.cpp:
840         (WTR::WorkQueueManager::processWorkQueue):
841         (WTR::WorkQueueManager::enqueue):
842         * WebKitTestRunner/WorkQueueManager.h:
843
844 2014-05-20  Carlos Garcia Campos  <cgarcia@igalia.com>
845
846         [GTK] WebKitWebPage::send-request always pass a valid pointer for redirected response
847         https://bugs.webkit.org/show_bug.cgi?id=133119
848
849         Reviewed by Sergio Villar Senin.
850
851         Check that redirect response parameter of
852         WebKitWebPage::send-request signal is NULL when not redirecting
853         and a valid WebKitURIResponse object when redirecting.
854
855         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
856         (testWebResourceSendRequest):
857         (serverCallback):
858         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
859         (sendRequestCallback):
860
861 2014-05-20  Carlos Garcia Campos  <cgarcia@igalia.com>
862
863         REGRESSION(CMAKE): [GTK] Several WebKit2GTK+ unit tests are no longer built
864         https://bugs.webkit.org/show_bug.cgi?id=133117
865
866         Reviewed by Philippe Normand.
867
868         Bring back missing tests to the build.
869
870         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
871
872 2014-05-19  Filip Pizlo  <fpizlo@apple.com>
873
874         Take care of some ARM64 test failures
875         https://bugs.webkit.org/show_bug.cgi?id=133090
876
877         Reviewed by Geoffrey Garen.
878
879         * Scripts/run-jsc-stress-tests: Make it easier to conditionally skip things.
880
881 2014-05-19  David Kilzer  <ddkilzer@apple.com>
882
883         [iOS] REGRESSION (r168910): webkitdirs.pm: Be more forgiving when parsing --sdk, --device and --sim
884         <http://webkit.org/b/133089>
885
886         Reviewed by Darin Adler.
887
888         * Scripts/webkitdirs.pm:
889         (determineXcodeSDK): If both '--sdk SDKROOT' and '--sim' are
890         specified on the command line, we would remove the '--sdk'
891         arguments, but leave '--sim', potentially passing it along to
892         xcodebuild causing a build failure.  This happens when
893         'old-run-webkit-tests --release --sim' invokes
894         build-dumprendertree when DumpRenderTree hasn't been built yet.
895
896 2014-05-19  David Farler  <dfarler@apple.com>
897
898         Dashboard: OpenSource revision key changed from WebKitOpenSource to WebKit
899         https://bugs.webkit.org/show_bug.cgi?id=133086
900
901         Reviewed by Daniel Bates.
902
903         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
904
905 2014-05-19  David Kilzer  <ddkilzer@apple.com>
906
907         REGRESSION (r169042): Fix run-api-tests on Mountain Lion
908         <http://webkit.org/b/132954>
909
910         * Scripts/webkitdirs.pm:
911         (sharedCommandLineOptionsUsage): Remove the prototype for the
912         subroutine.  Older perls don't like the "+@" syntax.
913
914 2014-05-19  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
915
916         run-javascriptcore-tests should sort the list of failing stress tests
917         https://bugs.webkit.org/show_bug.cgi?id=132989
918
919         Reviewed by Csaba Osztrogonác.
920
921         * Scripts/run-javascriptcore-tests:
922
923 2014-05-19  David Kilzer  <ddkilzer@apple.com>
924
925         webkitdirs.pm: Add setupMacWebKitEnvironment() to set __XPC_DYLD_FRAMEWORK_PATH consistently
926         <http://webkit.org/b/132954>
927
928         Reviewed by Darin Adler.
929
930         Extract code into setupMacWebKitEnvironment() for setting up
931         common environment variables so it may be shared.  Sets
932         __XPC_DYLD_FRAMEWORK_PATH consistently and adds support for
933         using guardmalloc to some scripts.
934
935         Also adds support for parsing shared (common) command-line
936         switches, initially just -g|--guard-malloc.
937
938         * Scripts/bisect-builds: Add -g|--guard-malloc support by using
939         sharedCommandLineOptions() and sharedCommandLineOptionsUsage().
940         (mountAndRunNightly): Call setupMacWebKitEnvironment().  Use a
941         local copy of %ENV when launching Safari so we don't have to
942         restore variables.
943
944         * Scripts/run-api-tests: Add -g|--guard-malloc support by using
945         sharedCommandLineOptions() and sharedCommandLineOptionsUsage().
946         Check result of GetOptions() to catch invalid command-line
947         switches.
948         (runTest): Use a local copy of %ENV when running tests so we
949         don't have to restore variables.
950         (prepareEnvironmentForRunningTestTool): Call
951         setupMacWebKitEnvironment().
952
953         * Scripts/run-pageloadtest: Add -g|--guard-malloc support by
954         using sharedCommandLineOptions() and
955         sharedCommandLineOptionsUsage().  Call
956         setupMacWebKitEnvironment().
957
958         * Scripts/webkitdirs.pm:
959         (sharedCommandLineOptions): Return array of common switches to
960         pass to Getopt::Long::GetOptions().
961         (sharedCommandLineOptionsUsage): Return formatted string of
962         common switches for printing usage help text.
963         (setUpGuardMallocIfNeeded): Support using '-g' for enabling
964         guardmalloc.
965         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Ditto.
966         (setupMacWebKitEnvironment): Extracted from runMacWebKitApp()
967         and changed not to clobber DYLD_FRAMEWORK_PATH if already set.
968         (runMacWebKitApp): Call setupMacWebKitEnvironment().  Use a
969         local copy of %ENV when launching Safari so we don't have to
970         restore variables.
971         (execMacWebKitAppForDebugging): Call
972         setupMacWebKitEnvironment().
973
974 2014-05-18  Rik Cabanier  <cabanier@adobe.com>
975
976         support for navigator.hardwareConcurrency
977         https://bugs.webkit.org/show_bug.cgi?id=132588
978
979         Reviewed by Filip Pizlo.
980
981         * Scripts/webkitperl/FeatureList.pm:
982
983 2014-05-18  Anders Carlsson  <andersca@apple.com>
984
985         Implement Navigations for all methods declared returning one
986         https://bugs.webkit.org/show_bug.cgi?id=133048
987         <rdar://problem/16830064>
988
989         Reviewed by Sam Weinig.
990
991         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
992         Import WebKit.h.
993         
994         * MiniBrowser/mac/WK2BrowserWindowController.m:
995         (-[WK2BrowserWindowController webView:didStartProvisionalNavigation:]):
996         (-[WK2BrowserWindowController webView:didReceiveServerRedirectForProvisionalNavigation:]):
997         (-[WK2BrowserWindowController webView:didFailProvisionalNavigation:withError:]):
998         (-[WK2BrowserWindowController webView:didCommitNavigation:]):
999         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]):
1000         (-[WK2BrowserWindowController webView:didFailNavigation:withError:]):
1001         Print out the navigations.
1002
1003 2014-05-17  Zalan Bujtas  <zalan@apple.com>
1004
1005         Subpixel rendering: Add subpixelCSSOMElementMetricsEnabled to WK1 WebPreferences.
1006         https://bugs.webkit.org/show_bug.cgi?id=133029
1007
1008         Reviewed by Simon Fraser.
1009
1010         Added a menu item to toggle subpixelCSSOMElementMetricsEnabled's value. However
1011         toggling it on a WK2 window needs restart.
1012         Adding dynamic toggle to WK2 requires a WebPreferences SPI. It's not worth cluttering
1013         the WebPreferences just to support this temporary toggle.
1014
1015         * MiniBrowser/mac/BrowserWindowController.h:
1016         * MiniBrowser/mac/MainMenu.xib:
1017         * MiniBrowser/mac/WK1BrowserWindowController.m:
1018         (-[WK1BrowserWindowController validateMenuItem:]):
1019         (-[WK1BrowserWindowController isSubpixelCSSOMElementMetricsEnabled]):
1020         (-[WK1BrowserWindowController toggleSubpixelCSSOMElementMetricsEnabled:]):
1021         * MiniBrowser/mac/WK2BrowserWindowController.m:
1022         (-[WK2BrowserWindowController validateMenuItem:]):
1023         (-[WK2BrowserWindowController isSubpixelCSSOMElementMetricsEnabled]):
1024         (-[WK2BrowserWindowController toggleSubpixelCSSOMElementMetricsEnabled:]):
1025
1026 2014-05-17  Anders Carlsson  <andersca@apple.com>
1027
1028         Replace WKContextSetDatabaseDirectory with two WKContextConfiguration parameters
1029         https://bugs.webkit.org/show_bug.cgi?id=133033
1030         <rdar://problem/16830143>
1031
1032         Reviewed by Sam Weinig.
1033
1034         Set up the WebSQL and IndexedDB directories.
1035
1036         * WebKitTestRunner/TestController.cpp:
1037         (WTR::TestController::initialize):
1038
1039 2014-05-16  Martin Hock  <mhock@apple.com>
1040
1041         MemoryCache::addImageToCache should return the result of add().
1042         https://bugs.webkit.org/show_bug.cgi?id=132928
1043         <rdar://problem/16651547>
1044
1045         Reviewed by Alexey Proskuryakov.
1046
1047         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1048         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1049         * TestWebKitAPI/Tests/ios/MemoryCacheAddImageToCacheIOS.mm: Added.
1050         (TestWebKitAPI::TEST):
1051
1052 2014-05-15  David Farler  <dfarler@apple.com>
1053
1054         old-run-webkit-tests: allow specifying a simulator app path
1055         https://bugs.webkit.org/show_bug.cgi?id=132975
1056
1057         Reviewed by Anders Carlsson.
1058
1059         * Scripts/old-run-webkit-tests:
1060         (openIPhoneSimulator):
1061         Add new --simulator-app command line parameter for specifying the
1062         absolute path to the simulator app to launch before starting a
1063         session.
1064
1065 2014-05-16  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1066
1067         [webkitpy] In case of multiple bug rollout, all bugs should be reopened, not only the oldest one
1068         https://bugs.webkit.org/show_bug.cgi?id=131363
1069
1070         Reviewed by Csaba Osztrogonác.
1071
1072         * Scripts/webkitpy/common/checkout/checkout_mock.py:
1073         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
1074         (MockBugzilla):
1075         * Scripts/webkitpy/tool/commands/download_unittest.py:
1076         (test_create_rollout_multiple_revision_with_one_resolved):
1077         (test_create_rollout_multiple_resolved):
1078         (test_rollout_two_revisions):
1079         (test_rollout_multiple_revisions):
1080         (test_rollout_multiple_revisions_with_a_missing_bug_id):
1081         * Scripts/webkitpy/tool/steps/createbug.py:
1082         (CreateBug.run):
1083         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
1084         (ReopenBugAfterRollout.run):
1085
1086 2014-05-16  Martin Hodovan  <mhodovan.u-szeged@partner.samsung.com>
1087
1088         [WK2] Change the remaining framework includes from WebKit2 to WebKit
1089         https://bugs.webkit.org/show_bug.cgi?id=132956
1090
1091         Reviewed by Sam Weinig.
1092
1093         * MiniBrowser/MiniBrowserWebProcessPlugIn.h:
1094         * MiniBrowser/mac/AppDelegate.m:
1095         * MiniBrowser/mac/WK2BrowserWindowController.m:
1096         * TestWebKitAPI/InjectedBundleController.h:
1097         * TestWebKitAPI/InjectedBundleMain.cpp:
1098         * TestWebKitAPI/JavaScriptTest.cpp:
1099         * TestWebKitAPI/PlatformUtilities.h:
1100         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
1101         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
1102         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
1103         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
1104         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp:
1105         (TestWebKitAPI::TEST):
1106         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive_Bundle.cpp:
1107         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewRestoreZoomAndScrollBackForward.cpp:
1108         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
1109         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
1110         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
1111         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
1112         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp:
1113         * TestWebKitAPI/Tests/WebKit2/DidNotHandleKeyDown.cpp:
1114         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
1115         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
1116         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
1117         * TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp:
1118         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
1119         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
1120         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
1121         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
1122         * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
1123         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
1124         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
1125         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
1126         * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback.cpp:
1127         * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback_Bundle.cpp:
1128         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
1129         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
1130         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
1131         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp:
1132         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest.cpp:
1133         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest_Bundle.cpp:
1134         * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins.cpp:
1135         * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins_Bundle.cpp:
1136         * TestWebKitAPI/Tests/WebKit2/LayoutMilestonesWithAllContentInFrame.cpp:
1137         * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
1138         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp:
1139         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp:
1140         * TestWebKitAPI/Tests/WebKit2/LoadPageOnCrash.cpp:
1141         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:
1142         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp:
1143         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp:
1144         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
1145         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages_Bundle.cpp:
1146         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
1147         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp:
1148         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp:
1149         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
1150         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1151         * TestWebKitAPI/Tests/WebKit2/ParentFrame.cpp:
1152         * TestWebKitAPI/Tests/WebKit2/ParentFrame_Bundle.cpp:
1153         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications.mm:
1154         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications_Bundle.cpp:
1155         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
1156         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp:
1157         * TestWebKitAPI/Tests/WebKit2/ReloadPageAfterCrash.cpp:
1158         * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
1159         * TestWebKitAPI/Tests/WebKit2/ResizeWindowAfterCrash.cpp:
1160         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
1161         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp:
1162         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp:
1163         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem_Bundle.cpp:
1164         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
1165         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
1166         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
1167         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
1168         * TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp:
1169         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
1170         * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent_Bundle.cpp:
1171         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
1172         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks_Bundle.cpp:
1173         * TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm:
1174         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm:
1175         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor_Bundle.mm:
1176         * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp:
1177         * TestWebKitAPI/Tests/WebKit2/mac/WeakObjCPtr.mm:
1178         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
1179         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
1180         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
1181         * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp:
1182         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
1183         * TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp:
1184         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1185         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
1186         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp:
1187         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
1188         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
1189         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing_Bundle.cpp:
1190         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
1191         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:
1192         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
1193         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
1194         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
1195         * TestWebKitAPI/config.h:
1196         * TestWebKitAPI/efl/PlatformWebView.cpp:
1197         * TestWebKitAPI/mac/JavaScriptTestMac.mm:
1198         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
1199         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1200         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
1201         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
1202         * WebKitTestRunner/EventSenderProxy.h:
1203         * WebKitTestRunner/GeolocationProviderMock.cpp:
1204         * WebKitTestRunner/GeolocationProviderMock.h:
1205         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1206         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1207         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1208         * WebKitTestRunner/InjectedBundle/GCController.cpp:
1209         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1210         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1211         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
1212         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1213         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1214         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1215         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1216         * WebKitTestRunner/InjectedBundle/TextInputController.cpp:
1217         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
1218         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1219         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1220         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
1221         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
1222         * WebKitTestRunner/InjectedBundle/ios/EventSenderProxyIOS.mm:
1223         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
1224         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
1225         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1226         * WebKitTestRunner/PlatformWebView.h:
1227         * WebKitTestRunner/StringFunctions.h:
1228         * WebKitTestRunner/TestController.cpp:
1229         * WebKitTestRunner/TestController.h:
1230         * WebKitTestRunner/TestInvocation.cpp:
1231         * WebKitTestRunner/TestInvocation.h:
1232         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
1233         * WebKitTestRunner/WebNotificationProvider.cpp:
1234         * WebKitTestRunner/WebNotificationProvider.h:
1235         * WebKitTestRunner/WorkQueueManager.cpp:
1236         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
1237         * WebKitTestRunner/cg/TestInvocationCG.cpp:
1238         * WebKitTestRunner/cocoa/CrashReporterInfo.mm:
1239         * WebKitTestRunner/config.h:
1240         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1241         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1242         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1243         * WebKitTestRunner/ios/TestControllerIOS.mm:
1244         * WebKitTestRunner/mac/EventSenderProxy.mm:
1245         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1246         * WebKitTestRunner/mac/TestControllerMac.mm:
1247
1248 2014-05-15  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1249
1250         [EFL][WK2] Skip failing unit tests
1251         https://bugs.webkit.org/show_bug.cgi?id=132979
1252
1253         Reviewed by Daniel Bates.
1254
1255         * TestWebKitAPI/PlatformEfl.cmake: Skip failing unit tests for now.
1256
1257 2014-05-15  David Kilzer  <ddkilzer@apple.com>
1258
1259         [iOS] Support TestWebKitAPI in the iOS Simulator
1260         <http://webkit.org/b/129535>
1261         <rdar://problem/16203529>
1262
1263         Reviewed by Daniel Bates.
1264
1265         * Scripts/run-api-tests:
1266         (runTest):
1267         (listAllTests):
1268         - Extract common arguments into local variable.
1269         - Use xcrun to find the sim tool in order to invoke
1270         TestWebKitAPI properly in the iOS Simulator. 
1271
1272         * Scripts/webkitdirs.pm:
1273         (argumentsForConfiguration): Set --device or --sim as
1274         appropriate to fix buildTestTool() in run-api-tests.
1275
1276 2014-05-15  Tim Horton  <timothy_horton@apple.com>
1277
1278         Fix a logging typo in copy-webkitlibraries-to-product-directory
1279
1280         Reviewed by Dean Jackson.
1281
1282         * Scripts/copy-webkitlibraries-to-product-directory:
1283
1284 2014-05-15  David Kilzer  <ddkilzer@apple.com>
1285
1286         TestWebKitAPI: URLExtras.mm should be a shared test for iOS and Mac
1287         <http://webkit.org/b/132959>
1288
1289         Reviewed by Dan Bernstein.
1290
1291         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add
1292         Cocoa directory to project and move URLExtras.mm into it.
1293         * TestWebKitAPI/Tests/Cocoa/URLExtras.mm: Renamed from Tools/TestWebKitAPI/Tests/mac/URLExtras.mm.
1294
1295 2014-05-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1296
1297         [GTK] Compile all installed resources as GResources
1298         https://bugs.webkit.org/show_bug.cgi?id=131099
1299
1300         Reviewed by Philippe Normand.
1301
1302         * Scripts/webkitpy/port/gtk.py:
1303         (GtkPort.setup_environ_for_server): Removed now unneeded
1304         AUDIO_RESOURCES_PATH env var.
1305
1306 2014-05-14  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1307
1308         Remove CSS_STICKY_POSITION guards
1309         https://bugs.webkit.org/show_bug.cgi?id=132676
1310
1311         Reviewed by Simon Fraser.
1312
1313         * Scripts/webkitperl/FeatureList.pm:
1314
1315 2014-05-14  Carlos Garcia Campos  <cgarcia@igalia.com>
1316
1317         REGRESSION(CMAKE): [GTK] InputMethodFilter unit test is not built
1318         https://bugs.webkit.org/show_bug.cgi?id=132686
1319
1320         Reviewed by Philippe Normand.
1321
1322         Bring back InputMethodFilter test to the build and compile it into
1323         a single binary TestWebCore with the other WebCore tests. Also
1324         move it from TestWebKitAPI/gtk/ to TestWebKitAPI/Tests/WebCore/gtk/.
1325
1326         * Scripts/run-gtk-tests:
1327         (TestRunner): Remove WebCoreGtk from the list of test directories.
1328         * TestWebKitAPI/PlatformGTK.cmake:
1329         * TestWebKitAPI/Tests/WebCore/gtk/InputMethodFilter.cpp: Renamed from Tools/TestWebKitAPI/Tests/gtk/InputMethodFilter.cpp.
1330
1331 2014-05-14  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
1332
1333         [EFL] Make XVFBDriver optional
1334         https://bugs.webkit.org/show_bug.cgi?id=131036
1335
1336         Reviewed by Gyuyoung Kim.
1337
1338         * Scripts/webkitpy/port/efl.py:
1339         (EflPort._driver_class):
1340
1341 2014-05-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1342
1343         Flakiness dashboard contains outdated list of bots on builders.jsonp
1344         https://bugs.webkit.org/show_bug.cgi?id=132874
1345
1346         Reviewed by Darin Adler.
1347
1348         * TestResultServer/static-dashboards/builders.jsonp: Regenerate this
1349         file by changing to the directory Tools/TestResultServer and executing
1350         the script generate_builders_json.py
1351
1352 2014-05-11  Anders Carlsson  <andersca@apple.com>
1353
1354         Replace WKContextSetLocalStorageDirectory with a context configuration getter/setter
1355         https://bugs.webkit.org/show_bug.cgi?id=132809
1356
1357         Reviewed by Dan Bernstein.
1358
1359         * WebKitTestRunner/TestController.cpp:
1360         (WTR::TestController::initialize):
1361         Set the local storage directory using WKContextConfigurationSetLocalStorageDirectory.
1362
1363 2014-05-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1364
1365         REGRESSION(CMAKE): [GTK] JavaScriptCore API tests are not built anymore
1366         https://bugs.webkit.org/show_bug.cgi?id=132739
1367
1368         Reviewed Anders Carlsson.
1369
1370         * TestWebKitAPI/CMakeLists.txt: Add missing includes required by
1371         the JSC unit tests.
1372         * TestWebKitAPI/PlatformGTK.cmake: Bring back JavaScriptCore unit tests.
1373
1374 2014-05-11  Anders Carlsson  <andersca@apple.com>
1375
1376         Add a WKContextConfigurationRef object and make the injected bundle path part of the configuration
1377         https://bugs.webkit.org/show_bug.cgi?id=132806
1378
1379         Reviewed by Beth Dakin.
1380
1381         Migrate to WKContextConfiguration.
1382
1383         * WebKitTestRunner/TestController.cpp:
1384         (WTR::TestController::initialize):
1385
1386 2014-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
1387
1388         REGRESSION(CMAKE): [GTK] WebKit2 C API tests are not longer built in the same binary
1389         https://bugs.webkit.org/show_bug.cgi?id=132685
1390
1391         Reviewed by Martin Robinson.
1392
1393         Use a single TestWebKit2 binary for all WebKit2 C API tests.
1394
1395         * TestWebKitAPI/PlatformGTK.cmake:
1396
1397 2014-05-09  Benjamin Poulain  <benjamin@webkit.org>
1398
1399         [iOS] Switch geolocation to an explicit authorization query model
1400         https://bugs.webkit.org/show_bug.cgi?id=132717
1401
1402         Reviewed by Sam Weinig.
1403
1404         * DumpRenderTree/mac/MockGeolocationProvider.mm:
1405         (-[MockGeolocationProvider initializeGeolocationForWebView:listener:]):
1406         (-[MockGeolocationProvider cancelWarmUpForWebView:]): Deleted.
1407
1408 2014-05-09  David Farler  <dfarler@apple.com>
1409
1410         com.apple.iphonesimulator.startSession needs to pass "RuntimeIdentifier"
1411         https://bugs.webkit.org/show_bug.cgi?id=132718
1412
1413         Reviewed by David Kilzer.
1414
1415         The simulator may not be able to look up runtimes by SDK paths
1416         and instead will map SDK versions to runtimes instead. In
1417         com.apple.iphonesimulator.startSession notifications,
1418         'runtimeIdentifier' (SDK version string) is preferred over
1419         'sdkRoot' (SDK path) anyway. Include the 'runtimeIdentifier' key
1420         when creating a new DRT or WKTR simulator session.
1421
1422         IPhoneSimulatorNotification.pm filters out keys for this
1423         notification's userInfo with a hard-coded list. There's no harm
1424         in including extra key-value pairs in an NSNotification userInfo
1425         dictionary anyway and the simulator may again change its
1426         userInfo schema for this notification.
1427
1428         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm:
1429         (postStartSessionNotification):
1430         * Scripts/old-run-webkit-tests:
1431         (installAndLaunchDumpToolAppUsingNotification):
1432
1433 2014-05-09  Anders Carlsson  <andersca@apple.com>
1434
1435         Another build fix.
1436
1437         * Scripts/build-webkit:
1438         WebKit2 should always be built for OS X and iOS.
1439
1440 2014-05-09  Anders Carlsson  <andersca@apple.com>
1441
1442         Follow-up build fix.
1443
1444         * Scripts/build-webkit:
1445         WebKit2 should no longer be built before WebKit.
1446
1447 2014-05-09  Anders Carlsson  <andersca@apple.com>
1448
1449         Rename WebKit2.framework to WebKit.framework
1450         https://bugs.webkit.org/show_bug.cgi?id=132743
1451         <rdar://problem/15920046>
1452
1453         Reviewed by Dan Bernstein.
1454
1455         * Scripts/check-for-inappropriate-files-in-framework:
1456         Use PRODUCT_NAME instead of PROJECT_NAME when matching frameworks.
1457         Change WebKit2 to WebKit.
1458
1459         * Scripts/check-for-webkit-framework-include-consistency:
1460         Change WebKit to WebKitLegacy.
1461
1462 2014-05-09  Manuel Rego Casasnovas  <rego@igalia.com>
1463
1464         Remove GTK+ WK1 EWS from build.webkit.org/dashboard
1465         https://bugs.webkit.org/show_bug.cgi?id=132732
1466
1467         Reviewed by Alexey Proskuryakov.
1468
1469         GTK+ WK1 EWS was removed in r166427, so it shouldn't appear in the dashboard.
1470
1471         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
1472         (EWS): Remove GTK+ WK1 EWS.
1473
1474 2014-05-09  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1475
1476         Add new u-szeged contributors.
1477
1478         Reviewed by Csaba Osztrogonác.
1479
1480         * Scripts/webkitpy/common/config/contributors.json:
1481
1482 2014-05-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1483
1484         REGRESSION(CMAKE): [GTK] run-gtk-tests doesn't set the right injected bundle path
1485         https://bugs.webkit.org/show_bug.cgi?id=132736
1486
1487         Reviewed by Philippe Normand.
1488
1489         There are two problems, the path returned by common.library_build_path() is wrong when
1490         common.binary_build_path() has previously been called, and the test is still looking for
1491         the .la instead of .so
1492
1493         * TestWebKitAPI/gtk/PlatformUtilitiesGtk.cpp:
1494         (TestWebKitAPI::Util::createInjectedBundlePath): Use .so instead
1495         of .la as extension of the injected bundle library.
1496         * gtk/common.py:
1497         (binary_build_path): Remove unused global variable and add a new
1498         one for binary_build_dir instead of sharing the same global
1499         variable for library_build_path and binary_build_path.
1500
1501 2014-05-08  Praveen R Jadhav  <praveen.j@samsung.com>
1502
1503         [EFL] Enable MEDIA_STREAM for EFL port
1504         https://bugs.webkit.org/show_bug.cgi?id=132648
1505
1506         Reviewed by Gyuyoung Kim.
1507
1508         Script modified to enable MEDIA_STREAM for EFL build.
1509
1510         * Scripts/webkitperl/FeatureList.pm: 
1511
1512 2014-05-08  David Farler  <dfarler@apple.com>
1513
1514         old-run-webkit-tests: update strings for simulator devices and app name
1515         https://bugs.webkit.org/show_bug.cgi?id=132687
1516
1517         Reviewed by Darin Adler.
1518
1519         iPhone Retina (4-inch) -> iPhone 5
1520         iPhone Retina (4-inch 64-bit) -> iPhone 5s
1521
1522         * Scripts/old-run-webkit-tests:
1523         (installAndLaunchDumpToolAppUsingNotification):
1524         (openIPhoneSimulator):
1525         (quitIPhoneSimulator):
1526         quit iOS Simulator, not iPhone Simulator.
1527
1528 2014-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1529
1530         REGRESSION(r168471): Update the builder names on the scheduler list.
1531         https://bugs.webkit.org/show_bug.cgi?id=132699
1532
1533         Reviewed by Martin Robinson.
1534
1535         On r168471 I missed to update the builder names for the GTK build
1536         bots on the AnyBranchScheduler type scheduler list of bots.
1537
1538         * BuildSlaveSupport/build.webkit.org-config/config.json:
1539
1540 2014-05-08  Brady Eidson  <beidson@apple.com>
1541
1542         "shouldKeepCurrentBackForwardListItemInList" API should pass clientInfo to the callback
1543         <rdar://problem/16855357> and https://bugs.webkit.org/show_bug.cgi?id=132692
1544
1545         Reviewed by Tim Horton.
1546
1547         * TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp:
1548         (TestWebKitAPI::shouldKeepCurrentBackForwardListItemInList):
1549
1550 2014-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1551
1552         REGRESSION(r168471): Duplicate builddirs broke the build master.
1553         https://bugs.webkit.org/show_bug.cgi?id=132688
1554
1555         Reviewed by Carlos Garcia Campos.
1556
1557         Rename the builddirs of the new GTK bots introduced on r168471 to
1558         be unique. Otherwise the master will break.
1559
1560         * BuildSlaveSupport/build.webkit.org-config/config.json:
1561
1562 2014-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1563
1564         [GTK] webkitdom script assumes mkdir only fails because the directory already exists
1565         https://bugs.webkit.org/show_bug.cgi?id=132674
1566
1567         Reviewed by Philippe Normand.
1568
1569         Only ignore mkdir failure when exception is raised because the
1570         file already exists and it's a directory.
1571
1572         * gtk/webkitdom.py:
1573         (write_doc_files):
1574
1575 2014-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1576
1577         [WK2][GTK] Split the 64-bit GTK buildbots in Build and Test.
1578         https://bugs.webkit.org/show_bug.cgi?id=131358
1579
1580         Reviewed by Carlos Garcia Campos.
1581
1582         Current 64-bit GTK build bots (Release and Debug) not only test
1583         the build, but run all tests. Split each one of the bots in
1584         BuildOnly and TestWebKit2.
1585
1586         This will allow us to have a better overview of the status of
1587         the GTK port.
1588
1589         Original patch from Sergio Villar Senin <svillar@igalia.com>
1590
1591         * BuildSlaveSupport/build.webkit.org-config/config.json:
1592         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1593         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1594         (WebKitBuildbot):
1595         * Scripts/webkitpy/port/builders.py:
1596         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1597         (TestRebaselineTest.test_baseline_directory):
1598         * TestResultServer/static-dashboards/builders.jsonp:
1599         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1600         (resetGlobals):
1601         * TestResultServer/static-dashboards/loader_unittests.js:
1602
1603 2014-05-07  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1604
1605         [CoordinatedGraphics][WK2] Scale factor and scroll position is not being restored properly in a back/forward load
1606         https://bugs.webkit.org/show_bug.cgi?id=126022
1607
1608         Reviewed by Benjamin Poulain.
1609
1610         Original author : Thiago de Barros Lacerda, and finished by Gyuyoung Kim.
1611
1612         Added an unit test case to check if scroll position and scale are restored properly.
1613
1614         * TestWebKitAPI/PlatformEfl.cmake:
1615         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewRestoreZoomAndScrollBackForward.cpp: Added.
1616         (TestWebKitAPI::didFinishLoadForFrame):
1617         (TestWebKitAPI::didChangeContentsPosition):
1618         (TestWebKitAPI::TEST):
1619         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward1.html: Added.
1620         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward2.html: Added.
1621
1622 2014-05-07  Simon Fraser  <simon.fraser@apple.com>
1623
1624         WebKit1 is flashy when compositing layers come and go
1625         https://bugs.webkit.org/show_bug.cgi?id=132655
1626         <rdar://problem/16830981&16788846>
1627
1628         Reviewed by Sam Weinig.
1629         
1630         Revert the change from r166117.
1631
1632         * DumpRenderTree/mac/DumpRenderTree.mm:
1633         (updateDisplay):
1634
1635 2014-05-07  Chris Fleizach  <cfleizach@apple.com>
1636
1637         AX: AXSelectTextWithCriteria should support capitalize/lowercase/uppercase
1638         https://bugs.webkit.org/show_bug.cgi?id=132622
1639
1640         Reviewed by Mario Sanchez Prada.
1641
1642         * DumpRenderTree/AccessibilityUIElement.cpp:
1643         (selectTextWithCriteriaCallback):
1644         (isEqualCallback):
1645         * DumpRenderTree/AccessibilityUIElement.h:
1646         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1647         (AccessibilityUIElement::selectTextWithCriteria):
1648         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1649         (AccessibilityUIElement::selectTextWithCriteria):
1650         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1651         (selectTextParameterizedAttributeForCriteria):
1652         (AccessibilityUIElement::selectTextWithCriteria):
1653         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1654         (AccessibilityUIElement::selectTextWithCriteria):
1655         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1656         (WTR::AccessibilityUIElement::selectTextWithCriteria):
1657         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1658         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1659         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1660         (WTR::AccessibilityUIElement::selectTextWithCriteria):
1661         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1662         (WTR::AccessibilityUIElement::selectTextWithCriteria):
1663         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1664         (WTR::selectTextParameterizedAttributeForCriteria):
1665         (WTR::AccessibilityUIElement::selectTextWithCriteria):
1666
1667 2014-05-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1668
1669         [SOUP] TLSErrors do not cause page load to fail when not ignored
1670         https://bugs.webkit.org/show_bug.cgi?id=121548
1671
1672         Reviewed by Sergio Villar Senin.
1673
1674         Add unit tests to check that the load fails with TLS errors in
1675         case of a redirection.
1676
1677         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
1678         (testTLSErrorsRedirect):
1679         (httpsServerCallback):
1680         (beforeAll):
1681
1682 2014-05-07  Manuel Rego Casasnovas  <rego@igalia.com>
1683
1684         [CSS Grid Layout] Remove runtime feature
1685         https://bugs.webkit.org/show_bug.cgi?id=132382
1686
1687         Reviewed by Benjamin Poulain.
1688
1689         Remove cssGridLayoutEnabled setting usage.
1690
1691         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1692         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1693         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1694         (TestRunner::overridePreference):
1695         * DumpRenderTree/mac/DumpRenderTree.mm:
1696         (resetWebPreferencesToConsistentValues):
1697
1698 2014-05-06  David Kilzer  <ddkilzer@apple.com>
1699
1700         Add Makefile targets for copying static libraries (LLVM and WKSI)
1701         <http://webkit.org/b/132619>
1702
1703         Reviewed by Mark Rowe.
1704
1705         * Scripts/copy-webkitlibraries-to-product-directory: Set a
1706         sensible default for product directory if not specified on
1707         either the command-line or in the environment (by Xcode) by
1708         calling productDir() in webkitdirs.pm.
1709
1710 2014-05-06  Brady Eidson  <beidson@apple.com>
1711
1712         Add WK2 SPI to prevent the previous back/forward item from remaining in the list
1713         <rdar://problem/16248710> and https://bugs.webkit.org/show_bug.cgi?id=132636
1714
1715         Reviewed by Sam Weinig.
1716
1717         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1718
1719         * TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp: Added.
1720         (TestWebKitAPI::itemURLLastComponentIsString):
1721         (TestWebKitAPI::didFinishLoadForFrame):
1722         (TestWebKitAPI::willGoToBackForwardListItem):
1723         (TestWebKitAPI::shouldKeepCurrentBackForwardListItemInList):
1724         (TestWebKitAPI::setPageLoaderClient):
1725         (TestWebKitAPI::TEST):
1726         * TestWebKitAPI/Tests/WebKit2/simple2.html: Added.
1727         * TestWebKitAPI/Tests/WebKit2/simple3.html: Added.
1728
1729         * WebKitTestRunner/TestController.cpp:
1730         (WTR::TestController::createWebViewWithOptions): Update for new client layout.
1731
1732 2014-05-06  Darin Adler  <darin@apple.com>
1733
1734         Try to fix iOS build.
1735
1736         * DumpRenderTree/mac/TestRunnerMac.mm:
1737         (-[APITestDelegateIPhone initWithTestRunner:utf8Data:baseURL:]):
1738         Updated since I changed testRunner into a pointer instead of a reference.
1739         Updated argument names to avoid conflict with field names.
1740         (-[APITestDelegateIPhone run]): Ditto.
1741         (-[APITestDelegateIPhone _cleanUp]): Ditto.
1742
1743 2014-05-06  Commit Queue  <commit-queue@webkit.org>
1744
1745         Unreviewed, rolling out r168304.
1746         https://bugs.webkit.org/show_bug.cgi?id=132607
1747
1748         Broke the build (Requested by KaL on #webkit).
1749
1750         Reverted changeset:
1751
1752         "[GTK][CMake] Unable to do make install"
1753         https://bugs.webkit.org/show_bug.cgi?id=130188
1754         http://trac.webkit.org/changeset/168304
1755
1756 2014-05-04  Darin Adler  <darin@apple.com>
1757
1758         RetainPtr: Use adoptCF function instead of AdoptCF constructor argument
1759         https://bugs.webkit.org/show_bug.cgi?id=80222
1760
1761         Reviewed by Alexey Proskuryakov.
1762
1763         * DumpRenderTree/mac/TestRunnerMac.mm:
1764         (-[APITestDelegateIPhone initWithTestRunner:utf8Data:baseURL:]): Updated to
1765         do more work here so we don't use RetainPtr local variables.
1766         (-[APITestDelegateIPhone dealloc]): Added.
1767         (-[APITestDelegateIPhone run]): Added an early exit if the web view is already
1768         created. Updated for changes to member names and types.
1769         (-[APITestDelegateIPhone _cleanUp]): Added code to set webView to nil and
1770         updated for changes to member names and types. Changed to two word spelling.
1771         (-[APITestDelegateIPhone webView:didFailLoadWithError:forFrame:]): Updated
1772         name of _cleanUp method.
1773         (-[APITestDelegateIPhone webView:didFailProvisionalLoadWithError:forFrame:]):
1774         Ditto.
1775         (-[APITestDelegateIPhone webView:didFinishLoadForFrame:]): Ditto.
1776
1777 2014-05-05  Benjamin Poulain  <benjamin@webkit.org>
1778
1779         Clean up Image Document and tweak the layout and viewport
1780         https://bugs.webkit.org/show_bug.cgi?id=132552
1781
1782         Reviewed by Anders Carlsson.
1783
1784         * DumpRenderTree/mac/DumpRenderTree.mm:
1785         (resetWebPreferencesToConsistentValues):
1786         Update the default settings to have something consistent with WebKit2.
1787
1788 2014-05-05  Martin Robinson  <mrobinson@igalia.com>
1789
1790         [GTK][CMake] Unable to do make install
1791         https://bugs.webkit.org/show_bug.cgi?id=130188
1792
1793         Reviewed by Carlos Garcia Campos.
1794
1795         * Scripts/webkitdirs.pm:
1796         (buildCMakeGeneratedProject): Always build gtkdoc-no-html for WebKitGTK+. This
1797         will give an early signal that a change has broken the documentation.
1798
1799 2014-05-05  Pratik Solanki  <psolanki@apple.com>
1800
1801         Update framework locations in package-root
1802         https://bugs.webkit.org/show_bug.cgi?id=132571
1803
1804         Reviewed by Simon Fraser.
1805
1806         * Scripts/package-root:
1807
1808 2014-05-05  Ryuan Choi  <ryuan.choi@samsung.com>
1809
1810         [EFL][WK2] Refactor favicon database APIs
1811         https://bugs.webkit.org/show_bug.cgi?id=132519
1812
1813         Reviewed by Gyuyoung Kim.
1814
1815         * MiniBrowser/efl/main.c: Use ewk_favicon_database_icon_get instead of ewk_view_favicon_get.
1816         (update_view_favicon):
1817         (on_icon_changed_cb):
1818         (window_free):
1819         (on_url_changed):
1820         (window_create):
1821         (on_view_favicon_changed): Deleted.
1822
1823 2014-05-02  Mark Rowe  <mrowe@apple.com>
1824
1825         <https://webkit.org/b/132505> Make it possible to tell copy-webkitlibraries-to-product-directory which OS X version to copy for
1826
1827         Reviewed by Dan Bernstein.
1828
1829         * Scripts/copy-webkitlibraries-to-product-directory: Add an --osx-version argument and use the passed value
1830         when determining which LLVM archive to extract.
1831
1832 2014-05-02  Jeremy Jones  <jeremyj@apple.com>
1833
1834         Add Jeremy as a committer.
1835         https://bugs.webkit.org/show_bug.cgi?id=132492
1836
1837         Reviewed by Jer Noble.
1838
1839         Add myself as a committer.
1840
1841         * Scripts/webkitpy/common/config/contributors.json:
1842
1843 2014-05-02  Jeremy Jones  <jeremyj@apple.com>
1844
1845         Add Jeremy as a committer.
1846         https://bugs.webkit.org/show_bug.cgi?id=132492
1847
1848         Reviewed by Jer Noble.
1849
1850         Add Jeremy Jones to the committers file.
1851
1852         * Scripts/webkitpy/common/config/contributors.json:
1853
1854 2014-05-02  Brian J. Burg  <burg@cs.washington.edu>
1855
1856         Hard to figure out how to run a single test with run-api-tests
1857         https://bugs.webkit.org/show_bug.cgi?id=116332
1858
1859         Reviewed by Alexey Proskuryakov.
1860
1861         * Scripts/run-api-tests: add two examples to the help message.
1862
1863 2014-05-02  Simon Fraser  <simon.fraser@apple.com>
1864
1865         Fix several memory leaks found by code inspection
1866         https://bugs.webkit.org/show_bug.cgi?id=132472
1867
1868         Reviewed by Geoffrey Garen.
1869         
1870         Fix memory leaks.
1871
1872         * TestWebKitAPI/Tests/mac/WillSendSubmitEvent.mm:
1873         (TestWebKitAPI::TEST):
1874         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1875         (WTR::InjectedBundlePage::willSendRequestForFrame):
1876         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1877         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1878
1879 2014-05-02  Filip Pizlo  <fpizlo@apple.com>
1880
1881         DFGAbstractInterpreter should not claim Int52 arithmetic creates Int52s
1882         https://bugs.webkit.org/show_bug.cgi?id=132446
1883
1884         Reviewed by Mark Hahnenberg.
1885         
1886         Test the FTL by default now that it's enabled by default.
1887
1888         * Scripts/run-javascriptcore-tests:
1889
1890 2014-05-01  Ryuan Choi  <ryuan.choi@samsung.com>
1891
1892         [EFL][WK1] Drop ewk_view_setting_tiled_backingstore APIs
1893         https://bugs.webkit.org/show_bug.cgi?id=132240
1894
1895         Reviewed by Anders Carlsson.
1896
1897         Removed ewk_view_setting_tiled_backingstore related code.
1898
1899         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1900         (DumpRenderTreeChrome::createView):
1901         (shouldUseTiledBackingStore): Deleted.
1902         * EWebLauncher/main.c:
1903         (windowCreate):
1904         (parseUserArguments):
1905
1906 2014-05-01  Anders Carlsson  <andersca@apple.com>
1907
1908         window.testRunner.keepWebHistory() should update the UI process state
1909         https://bugs.webkit.org/show_bug.cgi?id=132440
1910
1911         Reviewed by Dan Bernstein.
1912
1913         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1914         (WTR::InjectedBundle::postSetAddsVisitedLinks):
1915         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1916         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1917         (WTR::TestRunner::keepWebHistory):
1918         * WebKitTestRunner/TestInvocation.cpp:
1919         (WTR::TestInvocation::invoke):
1920         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1921
1922 2014-05-01  David Kilzer  <ddkilzer@apple.com>
1923
1924         Really remove ENABLE_PLUGIN_PROXY_FOR_VIDEO
1925         <http://webkit.org/b/132432>
1926
1927         Reviewed by Tim Horton.
1928
1929         * Scripts/webkitperl/FeatureList.pm: Remove support for
1930         --plugin-proxy-for-video switch.
1931
1932 2014-04-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1933
1934         Kernel sysctl interface hw.activecpu don't exists on Linux.
1935         https://bugs.webkit.org/show_bug.cgi?id=132286
1936
1937         Reviewed by Filip Pizlo.
1938
1939         * Scripts/run-jsc-stress-tests: Redirect stderr to null when
1940         calling sysctl over hw.activecpu
1941
1942 2014-04-30  Anders Carlsson  <andersca@apple.com>
1943
1944         Move the legacy WebKit API into WebKitLegacy.framework and move it inside WebKit.framework
1945         https://bugs.webkit.org/show_bug.cgi?id=132399
1946         <rdar://problem/15920046>
1947
1948         Reviewed by Dan Bernstein.
1949
1950         * Scripts/check-for-webkit-framework-include-consistency:
1951         Allos WAK headers in WebKitLegacy as well as WebKit.
1952
1953         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1954         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
1955         Update header imports.
1956
1957 2014-04-30  Simon Fraser  <simon.fraser@apple.com>
1958
1959         [iOS WK2] Add test URL to crash reports for the UI process, clean up project
1960         https://bugs.webkit.org/show_bug.cgi?id=131954
1961
1962         Reviewed by Darin Adler.
1963         
1964         WebKitTestRunner was adding application-specific information to crash reports
1965         to log the test path, but only in the web process. Fix it to also do this
1966         for the UI process, for both iOS and OS X.
1967         
1968         Moved InjectedBundlePageMac.mm to InjectedBundlePageCocoa.mm and compile it for
1969         both iOS and OS X.
1970         
1971         Factored crash reprorter-related code into CrashReporterInfo, and call it from
1972         a new TestController::platformWillRunTest() function on Mac and iOS.
1973         
1974         Also remove Xcode-added unit test junk from the project.
1975
1976         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm: Copied from Tools/WebKitTestRunner/InjectedBundle/ios/InjectedBundlePageIOS.mm.
1977         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
1978         * WebKitTestRunner/TestController.cpp:
1979         (WTR::TestController::runTest):
1980         * WebKitTestRunner/TestController.h:
1981         * WebKitTestRunner/TestInvocation.cpp:
1982         (WTR::TestInvocation::url):
1983         * WebKitTestRunner/TestInvocation.h:
1984         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1985         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests-Info.plist: Removed.
1986         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests.m: Removed.
1987         * WebKitTestRunner/WebKitTestRunnerAppTests/en.lproj/InfoPlist.strings: Removed.
1988         * WebKitTestRunner/cocoa/CrashReporterInfo.h: Renamed from Tools/WebKitTestRunner/InjectedBundle/ios/InjectedBundlePageIOS.mm.
1989         * WebKitTestRunner/cocoa/CrashReporterInfo.mm: Renamed from Tools/WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm.
1990         (WTR::testPathFromURL):
1991         (WTR::setCrashReportApplicationSpecificInformationToURL):
1992         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1993         (WTR::TestController::platformWillRunTest):
1994         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1995         (WTR::TestController::platformWillRunTest):
1996         * WebKitTestRunner/ios/TestControllerIOS.mm:
1997         (WTR::TestController::platformWillRunTest):
1998         (WTR::TestController::setHidden):
1999         * WebKitTestRunner/mac/TestControllerMac.mm:
2000         (WTR::TestController::platformWillRunTest):
2001
2002 2014-04-30  Simon Fraser  <simon.fraser@apple.com>
2003
2004         Fix DRT assertion about mock scrollbars, which doesn't apply to iOS.
2005
2006         Reviewed by Tim Horton.
2007
2008         * DumpRenderTree/mac/DumpRenderTree.mm:
2009         (resetWebPreferencesToConsistentValues):
2010         (prepareConsistentTestingEnvironment):
2011
2012 2014-04-30  Anders Carlsson  <andersca@apple.com>
2013
2014         check-for-inappropriate-macros-in-external-headers should get the product name, not the project name
2015         https://bugs.webkit.org/show_bug.cgi?id=132397
2016
2017         Reviewed by Dan Bernstein.
2018
2019         * Scripts/check-for-inappropriate-macros-in-external-headers:
2020
2021 2014-04-29  Martin Robinson  <mrobinson@igalia.com>
2022
2023         [GTK] Make it easier to run CMake for downstreams
2024         https://bugs.webkit.org/show_bug.cgi?id=132370
2025
2026         Reviewed by Carlos Garcia Campos.
2027
2028         * Scripts/webkitdirs.pm:
2029         (generateBuildSystemFromCMakeProject): Pass -DDEVELOPER_MODE when building
2030         the GTK+ port.
2031
2032 2014-04-29  Stephanie Lewis  <slewis@apple.com>
2033
2034         <rdar://problem/16765765> Use JSON::PP in perl scripts instead of JSON.
2035         
2036         Rubber stamped by Jessie Berlin.
2037
2038         JSON.pm was removed from our tools setup.
2039
2040         * Scripts/generate-coverage-data:
2041
2042 2014-04-29  Filip Pizlo  <fpizlo@apple.com>
2043
2044         Use LLVM as a backend for the fourth-tier DFG JIT (a.k.a. the FTL JIT)
2045         https://bugs.webkit.org/show_bug.cgi?id=112840
2046
2047         Rubber stamped by Geoffrey Garen.
2048
2049         * Scripts/build-jsc: Enable it on Mac.
2050         * Scripts/build-webkit: Enable it on Mac.
2051         * Scripts/export-llvm-build: Make it slightly easier to export the build if you've done a "make install".
2052
2053 2014-04-28  Sam Weinig  <sam@webkit.org>
2054
2055         REGRESSION (r167751): svn-create-patch is very slow
2056         https://bugs.webkit.org/show_bug.cgi?id=132300
2057
2058         Reviewed by Alexey Proskuryakov.
2059
2060         * Scripts/svn-create-patch:
2061         Change default behavior of svn-create-patch to no longer run the style checker. It can still be run
2062         by calling `svn-create-patch --style`.
2063
2064 2014-04-29  Enrique Ocaña González  <eocanha@igalia.com>
2065
2066         Generate Eclipse project + ninja build for GTK+ if Eclipse in available in the PATH
2067         https://bugs.webkit.org/show_bug.cgi?id=132190
2068
2069         Reviewed by Gustavo Noronha Silva.
2070
2071         * Scripts/webkitdirs.pm:
2072         (canUseEclipse): Test if Eclipse is in the path. This is the same method used to test
2073             if ninja is in the path.
2074         (generateBuildSystemFromCMakeProject): Use the eclipse generator if possible, fallback
2075             to the previous ninja generator if not.
2076
2077 2014-04-29  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
2078
2079         check-webkit-style should understand --git-index
2080         https://bugs.webkit.org/show_bug.cgi?id=125364
2081
2082         Reviewed by Csaba Osztrogonác.
2083
2084         * Scripts/webkitpy/common/checkout/scm/git.py:
2085         (Git.create_patch): The command now supports the --cached option.
2086         * Scripts/webkitpy/style/main.py:
2087         (CheckWebKitStyle.main): Passing the --git-index option.
2088         * Scripts/webkitpy/style/optparser.py:
2089         (CommandOptionValues.__init__): The git-index option is switched off by default.
2090         (CommandOptionValues.__eq__): Equality check for the new option.
2091         (ArgumentParser._create_option_parser):Adding the --git-index option
2092         (ArgumentParser.parse):
2093         * Scripts/webkitpy/style/optparser_unittest.py: New tests for the --git-index option
2094         (CommandOptionValuesTest.test_init): 
2095         (CommandOptionValuesTest.test_eq):
2096
2097 2014-04-28  Michael Saboff  <msaboff@apple.com>
2098
2099         Crash in platform/mac/accessibility/table-visible-rows.html
2100         https://bugs.webkit.org/show_bug.cgi?id=132146
2101
2102         Reviewed by Filip Pizlo.
2103
2104         Instead of creating a local JSValueRef array on the stack and passing that to
2105         JSObjectMakeArray(), changed to create an empty JSArray and then populate the
2106         values using the JSObjectSetPropertyAtIndex() API.
2107
2108         * DumpRenderTree/AccessibilityUIElement.cpp:
2109         (elementsForRangeCallback):
2110         (convertElementsToObjectArray):
2111         * DumpRenderTree/mac/TestRunnerMac.mm:
2112         (originsArrayToJS):
2113         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2114         (WTR::EventSendingController::contextClick):
2115         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2116         (WTR::stringArrayToJS):
2117         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2118         (WTR::convertElementsToObjectArray):
2119
2120 2014-04-28  Filip Pizlo  <fpizlo@apple.com>
2121
2122         Make sure that the coverage of our tests doesn't change much if we change the thresholds now and in the future, but making
2123         "no-cjit" runs force the old-school threshold.
2124
2125         Rubber stamped by Mark Hahnenberg.
2126
2127         * Scripts/run-jsc-stress-tests:
2128
2129 2014-04-28  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2130
2131         [GTK] install-dependencies should also install ruby-json and ruby-highline
2132         https://bugs.webkit.org/show_bug.cgi?id=132292
2133
2134         Reviewed by Philippe Normand.
2135
2136         * gtk/install-dependencies: Install ruby json and highline packages.
2137
2138 2014-04-27  Joonghun Park  <jh718.park@samsung.com>
2139
2140         [EFL] Remove indexedDB's dependency on leveldb and disable indexedDB
2141         https://bugs.webkit.org/show_bug.cgi?id=132176
2142
2143         Reviewed by Gyuyoung Kim.
2144
2145         EFL port will use sqlite to support indexedDB. So, this patch removes levelDB dependency
2146         and turn off indexedDB feature until the sqlite implementation is introduced.
2147
2148         * Scripts/webkitperl/FeatureList.pm:
2149
2150 2014-04-25  James Craig  <jcraig@apple.com>
2151
2152         Set prepare-Changelog flag so that it no longer runs check-webkit-style by default
2153         https://bugs.webkit.org/show_bug.cgi?id=132209
2154
2155         Reviewed by Daniel Bates.
2156
2157         Set default to --no-style to avoid additional spew from false positives in check-webkit-style.
2158         Run check-webkit-style before generating changelogs to avoid additional spurious errors.
2159
2160         * Scripts/prepare-ChangeLog:
2161         (main): 
2162
2163 2014-04-25  Michael Saboff  <msaboff@apple.com>
2164
2165         Crash in platform/mac/accessibility/table-visible-rows.html
2166         https://bugs.webkit.org/show_bug.cgi?id=132146
2167
2168         Reviewed by Mark Lam.
2169
2170         Changed to use a local JSValueRef array temporary instead of a
2171         std::make_unique<JSValueRef[]> when making an array of JSValues so that the temporary
2172         JSValues are visited during garbage collection when the stack is scanned.  Otherwise,
2173         the temporary values could be collected.
2174
2175         * DumpRenderTree/AccessibilityUIElement.cpp:
2176         (convertElementsToObjectArray):
2177         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2178         (WTR::EventSendingController::contextClick):
2179         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2180         (WTR::convertElementsToObjectArray):
2181
2182 2014-04-24  Eduardo Lima Mitev  <elima@igalia.com>
2183
2184         Unreviewed GTK gardening
2185
2186         * Scripts/run-gtk-tests: Skips one flaky accesibility test in WK2API suite
2187         (TestRunner):
2188
2189 2014-04-24  László Langó  <llango.u-szeged@partner.samsung.com>
2190
2191         prepare-ChangeLog reports as deleted methods that has not been removed.
2192         https://bugs.webkit.org/show_bug.cgi?id=131733
2193
2194         Reviewed by Ryosuke Niwa.
2195
2196         * Scripts/prepare-ChangeLog:
2197         (originalFile): Set merge base to origin/master by default.
2198
2199 2014-04-23  James Craig  <jcraig@apple.com>
2200
2201         prepare-Changelog and svn-create-patch should optionally run check-webkit-style.
2202         https://bugs.webkit.org/show_bug.cgi?id=131115
2203
2204         Reviewed by Daniel Bates.
2205
2206         Added [--[no-]style] param to run check-webkit-style as part of prepare-Changelog and svn-create-patch.
2207
2208         * Scripts/commit-log-editor: Added --no-style.
2209         * Scripts/prepare-ChangeLog: Primary patch.
2210         (main): Primary patch.
2211         (createPatchCommand): Added --no-style.
2212         * Scripts/svn-create-patch: Primary patch.
2213         * Scripts/webkit-tools-completion.sh: Added --style and --no-style.
2214         * Scripts/webkitpy/common/checkout/scm/svn.py: Added --no-style.
2215         (SVN.create_patch): Added --no-style.
2216
2217 2014-04-23  Anders Carlsson  <andersca@apple.com>
2218
2219         Try to fix iOS build.
2220
2221         * DumpRenderTree/mac/DumpRenderTree.mm:
2222
2223 2014-04-23  Alexey Proskuryakov  <ap@apple.com>
2224
2225         Eliminate internals.setMockScrollbarsEnabled()
2226         https://bugs.webkit.org/show_bug.cgi?id=132085
2227
2228         Reviewed by Tim Horton.
2229
2230         * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebPreferencesToConsistentValues):
2231         No need to reset the preference, there is no way it can change.
2232
2233 2014-04-23  James Craig  <jcraig@apple.com>
2234
2235         Unreviewed. Moving myself from Contributors to Committers list.
2236
2237         * Scripts/webkitpy/common/config/contributors.json:
2238
2239 2014-04-23  Tim Horton  <timothy_horton@apple.com>
2240
2241         Mock scrollbars don't always work in DumpRenderTree
2242         https://bugs.webkit.org/show_bug.cgi?id=132082
2243
2244         Reviewed by Alexey Proskuryakov.
2245
2246         * DumpRenderTree/mac/DumpRenderTree.mm:
2247         (prepareConsistentTestingEnvironment):
2248         Set the mock scrollbar setting before creating the WebView, as this setting
2249         cannot be dynamically changed, so any scrollbars that are created during
2250         WebView initialization and are not replaced before snapshotting will end
2251         up being platform scrollbars instead of mock ones.
2252         WebKitTestRunner already sets this preference before creating WKViews,
2253         so we're just matching its behavior.
2254
2255 2014-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2256
2257         [GTK] ShadowRoot API was removed in r164131
2258         https://bugs.webkit.org/show_bug.cgi?id=132059
2259
2260         Reviewed by Gustavo Noronha Silva.
2261
2262         Add WebKitDOMShadowRoot to the list of deleted classes to generate
2263         the API docs.
2264
2265         * gtk/webkitdom.py:
2266         (WebKitDOMDocGenerator):
2267
2268 2014-04-23  Lorenzo Tilve  <ltilve@igalia.com>
2269
2270         [GTK] run-webkit-tests script is failing to invoke run-launcher
2271         https://bugs.webkit.org/show_bug.cgi?id=132051
2272
2273         Reviewed by Philippe Normand.
2274
2275         After the WK1 support was dropped, if run-webkit-tests is executed
2276         without --no-show-results parameter, the launcher is being called
2277         using a -2 parameter that is it causing the run-launcher to break.
2278
2279         * Scripts/webkitpy/port/gtk.py:
2280         (GtkPort.show_results_html_file):
2281
2282 2014-04-22  Tim Horton  <timothy_horton@apple.com>
2283
2284         DumpRenderTree generates black snapshots on some platforms
2285         https://bugs.webkit.org/show_bug.cgi?id=132029
2286         <rdar://problem/16679363>
2287
2288         Reviewed by Simon Fraser.
2289
2290         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2291         (createBitmapContextFromWebView):
2292         DRT checks with the WebView to determine whether it can use the window's
2293         backing store directly or (because of compositing) needs to take a WindowServer
2294         snapshot. However, on some platforms and in some situations, the window can
2295         be layer backed without the WebView necessarily currently being composited.
2296         We should check with the window in addition to the WebView before going
2297         ahead and using its backing store.
2298
2299 2014-04-22  Tim Horton  <timothy_horton@apple.com>
2300
2301         DumpRenderTree generates white snapshots on some platforms
2302         https://bugs.webkit.org/show_bug.cgi?id=132026
2303         <rdar://problem/16679363>
2304
2305         Reviewed by Simon Fraser.
2306
2307         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2308         Link DRT against QuartzCore.
2309
2310         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2311         (createBitmapContextFromWebView):
2312         Force CoreAnimation to synchronously update layers in a more explicit
2313         way that doesn't depend on AppKit behavior. This is very similar to what
2314         WebKitTestRunner does (indirectly) during its force repaint.
2315
2316 2014-04-22  Brent Fulgham  <bfulgham@apple.com>
2317
2318         [Win] Support Python 2.7 in Cygwin
2319         https://bugs.webkit.org/show_bug.cgi?id=132023
2320
2321         Reviewed by Michael Saboff.
2322
2323         * Scripts/webkitdirs.pm:
2324         (checkInstalledTools): Remove check for Python 2.7, since
2325         it now works properly.
2326
2327 2014-04-22  Filip Pizlo  <fpizlo@apple.com>
2328
2329         Switch the LLVMForJSC target to using the LLVM in /usr/local rather than /usr/local/LLVMForJavaScriptCore on iOS
2330         https://bugs.webkit.org/show_bug.cgi?id=130867
2331         <rdar://problem/16432456> 
2332
2333         Reviewed by Mark Hahnenberg.
2334
2335         * Scripts/build-webkit:
2336         * Scripts/copy-webkitlibraries-to-product-directory:
2337
2338 2014-04-22  Gustavo Noronha Silva  <gns@gnome.org>
2339
2340         [GTK] Fails to build documentation when output is redirected
2341         https://bugs.webkit.org/show_bug.cgi?id=131178
2342
2343         Reviewed by Martin Robinson.
2344
2345         * gtk/generate-gtkdoc: set the output for stdout and stderr to UTF-8
2346         explicitly to avoid encoding issues when they are redirected.
2347
2348 2014-04-22  ChangSeok Oh  <changseok.oh@collabora.com>
2349
2350         [GTK] YCM choose a newer compile_commands.json in between Release or Debug
2351         https://bugs.webkit.org/show_bug.cgi?id=131911
2352
2353         Reviewed by Martin Robinson.
2354
2355         common.get_build_path returns release path even though Debug configuration
2356         is newer than Release. So YouCompleteMe is used to refer old build setup inadvertently.
2357
2358         * gtk/ycm_extra_conf.py:
2359         (get_build_path): Compare modified time of Release and Debug. And return a recent modified path.
2360         (FlagsForFile):
2361
2362 2014-04-21  Brent Fulgham  <bfulgham@apple.com>
2363
2364         Unreviewed build fix.
2365
2366         * DumpRenderTree/mac/EventSendingController.mm:
2367         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
2368         Correct a typo that prevented tests from working properly.
2369
2370 2014-04-21  Martin Robinson  <mrobinson@igalia.com>
2371
2372         [GTK] Should have the ability to output composited contents during layout testing
2373         https://bugs.webkit.org/show_bug.cgi?id=131864
2374
2375         Reviewed by Philippe Normand.
2376
2377         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
2378         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Add a path that paints the widget contents
2379         to an image surface. We run the main loop a bit to match the implementation from WebKit1 and EFL.
2380         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2381         (WTR::PlatformWebView::windowSnapshotImage): Use the new UI-process path on GTK+.
2382
2383 2014-04-21  Sam Weinig  <sam@webkit.org>
2384
2385         Attempt to fix the tests.
2386
2387         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
2388         (-[DidFailProvisionalNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2389         Add policy handler to override the new default of denying loads that NSURLConnection cannot handle.
2390
2391 2014-04-21  Filip Pizlo  <fpizlo@apple.com>
2392
2393         Unreviewed test gardening, make no-eager runs run everything except eager (as opposed to
2394         being the same as a "quick run", which is meant for genuinely slow tests).
2395
2396         * Scripts/run-jsc-stress-tests:
2397
2398 2014-04-21  Darin Adler  <darin@apple.com>
2399
2400         Add HashSet::takeAny
2401         https://bugs.webkit.org/show_bug.cgi?id=131928
2402
2403         Reviewed by Benjamin Poulain.
2404
2405         * TestWebKitAPI/Tests/WTF/HashSet.cpp: Added a test for takeAny.
2406
2407 2014-04-20  Dan Bernstein  <mitz@apple.com>
2408
2409         Fixed a test timing out after r167572.
2410
2411         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
2412         (-[NavigationDelegate webView:didFinishNavigation:]): Renamed from
2413         -webView:didFinishLoadingNavigation:.
2414
2415 2014-04-20  Commit Queue  <commit-queue@webkit.org>
2416
2417         Unreviewed, rolling out r167510.
2418         https://bugs.webkit.org/show_bug.cgi?id=131915
2419
2420         broke GTK Debug bot (Requested by philn on #webkit).
2421
2422         Reverted changeset:
2423
2424         "[GTK] Add llvmpipe (Mesa) to the JHBuild moduleset and force
2425         it when running layout tests"
2426         https://bugs.webkit.org/show_bug.cgi?id=131472
2427         http://trac.webkit.org/changeset/167510
2428
2429 2014-04-18  Martin Robinson  <mrobinson@igalia.com>
2430
2431         [GTK] Add llvmpipe (Mesa) to the JHBuild moduleset and force it when running layout tests
2432         https://bugs.webkit.org/show_bug.cgi?id=131472
2433
2434         Reviewed by Philippe Normand.
2435
2436         * Scripts/webkitpy/port/gtk.py:
2437         (GtkPort.setup_environ_for_server): Use the LLVMPIPE_LIBGL_PATH to set the LD_LIBRARY_PATH
2438         when running WebKitTestRunner with run-webkit-tests.
2439         * gtk/jhbuild.modules: Add Mesa to the modulelist so that the llvmpipe libGL is build, but not
2440         installed.
2441         * gtk/jhbuildrc: Set the LLVMPIPE_LIBGL_PATH environment variable so that the test driver knows
2442         how to properly set the LD_LIBRARY_PATH variable. We do this because it is much easier to
2443         calculate the path in the jhbuildrc than in the test driver code. This simplifies things a great
2444         deal.
2445
2446 2014-04-18  Alexey Proskuryakov  <ap@apple.com>
2447
2448         DownloadDecideDestinationCrash API test uses an incorrect value for path
2449         https://bugs.webkit.org/show_bug.cgi?id=131845
2450         <rdar://problem/15925560>
2451
2452         Reviewed by Enrica Casucci.
2453
2454         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
2455         (TestWebKitAPI::decideDestinationWithSuggestedFilename):
2456
2457 2014-04-17  Alexey Proskuryakov  <ap@apple.com>
2458
2459         [Mac] AttributedStringTest API tests fail with async text input
2460         https://bugs.webkit.org/show_bug.cgi?id=131833
2461
2462         Reviewed by Enrica Casucci.
2463
2464         Don't run sync NSTextInputClient tests where we don't implement these calls.
2465
2466         * TestWebKitAPI/Tests/mac/AttributedString.mm:
2467         (TestWebKitAPI::AttributedStringTest_CustomFont::didLoadURL):
2468         (TestWebKitAPI::AttributedStringTest_CustomFont::runSyncTest):
2469         (TestWebKitAPI::AttributedStringTest_Strikethrough::didLoadURL):
2470         (TestWebKitAPI::AttributedStringTest_Strikethrough::runSyncTest):
2471         (TestWebKitAPI::AttributedStringTest_CustomFont::runTest): Deleted.
2472         (TestWebKitAPI::AttributedStringTest_Strikethrough::runTest): Deleted.
2473
2474 2014-04-18  Philippe Normand  <pnormand@igalia.com>
2475
2476         Remove NETWORK_INFO support
2477         https://bugs.webkit.org/show_bug.cgi?id=131841
2478
2479         Reviewed by Gyuyoung Kim.
2480
2481         * Scripts/webkitperl/FeatureList.pm:
2482
2483 2014-04-17  ChangSeok Oh  <changseok.oh@collabora.com>
2484
2485         [GTK] YouCompleteMe doesn't work for cmake build system.
2486         https://bugs.webkit.org/show_bug.cgi?id=131591
2487
2488         Reviewed by Martin Robinson.
2489
2490         Add cmake build system support for YouCompleteMe. It should work regardless of
2491         using make or ninja. In addition, autotools related code is removed since it's
2492         not used anymore in WebKit.
2493
2494         * Scripts/webkitdirs.pm:
2495         (generateBuildSystemFromCMakeProject):
2496         * gtk/ycm_extra_conf.py:
2497         (transform_relative_paths_to_absolute_paths):
2498         (FlagsForFile):
2499
2500 2014-04-17  Anders Carlsson  <andersca@apple.com>
2501
2502         Fix build.
2503
2504         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2505         (-[DownloadNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2506         (-[ConvertResponseToDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2507
2508 2014-04-17  Anders Carlsson  <andersca@apple.com>
2509
2510         Remove unused API enums
2511         https://bugs.webkit.org/show_bug.cgi?id=131836
2512
2513         Reviewed by Tim Horton.
2514
2515         * MiniBrowser/mac/WK2BrowserWindowController.m:
2516         (-[WK2BrowserWindowController webView:decidePolicyForNavigationResponse:decisionHandler:]):
2517
2518 2014-04-16  Brent Fulgham  <bfulgham@apple.com>
2519
2520         [Win] A few final cleanups to the DataObject classes.
2521         https://bugs.webkit.org/show_bug.cgi?id=131784
2522
2523         Reviewed by Anders Carlsson.
2524
2525         * DumpRenderTree/win/DRTDataObject.cpp:
2526         (DRTDataObject::clearData): Use 'last()' method.
2527         * DumpRenderTree/win/UIDelegate.cpp:
2528         (DRTUndoStack::pop): Use 'takeLast()' method.
2529
2530 2014-04-17  Andres Gomez  <agomez@igalia.com>
2531
2532         [Win] cygwin to keep installing curl 7.33.0-1 and subversion 1.7.14-1
2533         https://bugs.webkit.org/show_bug.cgi?id=131365
2534
2535         Reviewed by Brent Fulgham.
2536
2537         The cygwin installer is now downloading the wanted versions for
2538         the local installation given to the setup wizard.
2539
2540         * CygwinDownloader/cygwin-downloader.py:
2541         * CygwinDownloader/cygwin-downloader.zip:
2542
2543 2014-04-17  Adrian Perez de Castro  <aperez@igalia.com>
2544
2545         [GTK] Make run-webkit-tests always use WKTR
2546         https://bugs.webkit.org/show_bug.cgi?id=131737
2547
2548         Reviewed by Darin Adler.
2549
2550         Now that the GTK+ port only has support for WebKit2, instruct
2551         run-webkit-tests to always use WKTR. This avoids needing to pass
2552         flag "-2" every time.
2553
2554         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 
2555         (_set_up_derived_options): Always set webkit_test_runner when
2556         the platform is GTK+.
2557
2558 2014-04-17  Brendan Long  <b.long@cablelabs.com>
2559
2560         [Gtk] Install ninja-build in Tools/gtk/install-dependencies
2561         https://bugs.webkit.org/show_bug.cgi?id=131760
2562
2563         Reviewed by Philippe Normand.
2564
2565         * gtk/install-dependencies: Install ninja-build when it's available.
2566
2567 2014-04-16  peavo@outlook.com  <peavo@outlook.com>
2568
2569         [Win] run-javascriptcore-tests fails to run.
2570         https://bugs.webkit.org/show_bug.cgi?id=131761
2571
2572         Reviewed by Brent Fulgham.
2573
2574         * Scripts/build-jsc: For now, don't try to build bmalloc on Windows.
2575
2576 2014-04-16  Andres Gomez  <agomez@igalia.com>
2577
2578         [Win] Pass default parameters to cygwin setup wizard
2579         https://bugs.webkit.org/show_bug.cgi?id=131361
2580
2581         Reviewed by Brent Fulgham.
2582
2583         Added some parameters to the cygwin setup wizard so the user
2584         doesn't really have to do any interaction.
2585
2586         * CygwinDownloader/cygwin-downloader.py:
2587         * CygwinDownloader/cygwin-downloader.zip:
2588
2589 2014-04-15  Brent Fulgham  <bfulgham@apple.com>
2590
2591         [Win] Eliminate use of deleteAllValues in Windows Files
2592         https://bugs.webkit.org/show_bug.cgi?id=131631
2593
2594         Reviewed by Darin Adler.
2595
2596         Switch to std::unique_ptr for memory lifetime. Get rid of
2597         deleteAllValues now that it is no longer needed. Use ranged
2598         for loops where possible.
2599
2600         * DumpRenderTree/win/DRTDataObject.cpp:
2601         (WCEnumFormatEtc::WCEnumFormatEtc):
2602         (DRTDataObject::~DRTDataObject):
2603         (DRTDataObject::GetData):
2604         (DRTDataObject::QueryGetData):
2605         (DRTDataObject::SetData):
2606         (DRTDataObject::clearData):
2607         * DumpRenderTree/win/DRTDataObject.h:
2608         * DumpRenderTree/win/UIDelegate.cpp:
2609         (DRTUndoObject::DRTUndoObject):
2610         (DRTUndoObject::~DRTUndoObject):
2611         (DRTUndoStack::~DRTUndoStack):
2612         (DRTUndoStack::clear):
2613         (DRTUndoStack::pop):
2614         (DRTUndoManager::DRTUndoManager):
2615         (DRTUndoManager::redo):
2616         (DRTUndoManager::undo):
2617         (UIDelegate::UIDelegate):
2618         (UIDelegate::resetUndoManager):
2619         * DumpRenderTree/win/UIDelegate.h:
2620
2621 2014-04-16  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2622
2623         [GTK] Unreviewed GTK gardening.
2624
2625         Update list of skipped unit tests:
2626
2627           Skip test: WebKit2Gtk/TestWebKitWebView:/webkit2/WebKitWebView/page-visibility
2628
2629           Unskip tests: WebKit2/TestWebKit2:WebKit2.ResizeReversePaginatedWebView
2630           and WebKit2/TestWebKit2:WebKit2.ScrollPinningBehaviors
2631
2632         * Scripts/run-gtk-tests:
2633         (TestRunner):
2634
2635 2014-04-16  Tim Horton  <timothy_horton@apple.com>
2636
2637         check-webkit-style doesn't check code style in .mm or .m files
2638         https://bugs.webkit.org/show_bug.cgi?id=131708
2639
2640         Reviewed by Darin Adler.
2641
2642         * Scripts/webkitpy/style/checker.py:
2643         * Scripts/webkitpy/style/checker_unittest.py:
2644         (CheckerDispatcherDispatchTest.test_cpp_paths):
2645         (CheckerDispatcherDispatchTest.test_text_paths):
2646         Check .mm and .m files as C++.
2647
2648         * Scripts/webkitpy/style/checkers/cpp.py:
2649         (check_spacing):
2650         Add an override for our ordinary "missing spaces around =" for @synthesize,
2651         which should look like "@synthesize propertyName=_varName;"
2652
2653         Add an override for "missing space before {" for blocks' "^{".
2654
2655         Don't follow the "extra space before [" rule for Objective-C, because
2656         it breaks this rule in a multitude of ways because of method calls.
2657
2658         (check_braces):
2659         Don't complain about { not being on the end of the previous line if
2660         the previous line starts with "- (" or "+ (", which would indicate a
2661         Objective-C method definition.
2662
2663 2014-04-16  Darin Adler  <darin@apple.com>
2664
2665         Make Vector::takeLast work with move-only types (and optimize for types where move is faster)
2666         https://bugs.webkit.org/show_bug.cgi?id=131735
2667
2668         Reviewed by Alexey Proskuryakov.
2669
2670         * TestWebKitAPI/Tests/WTF/Vector.cpp: Added a test for Vector::takeLast with move only types.
2671         Fixed invocations of EXPECT macros so the expected value is on the left, and the test result
2672         is on the right. This can be confusing since our JavaScript test framework does it the opposite
2673         way, but gtest works better this way.
2674
2675 2014-04-15  Hyowon Kim  <hw1008.kim@samsung.com>
2676
2677         [EFL] Fix problems with the pixel dump.
2678         https://bugs.webkit.org/show_bug.cgi?id=131265
2679
2680         Reviewed by Gyuyoung Kim.
2681
2682         Painting and compositing paths of WebKit-EFL were totally modified from r166768.
2683         However pixel dump codes still call deprecated functions like ewk_view_paint(),
2684         which causes that nothing is drawn.
2685
2686         This patch adds new member functions to AcceleratedCompositingContext to support pixel dump.
2687         One of new functions is AcceleratedCompositingContext::extractImageData(),
2688         which replaces deprecated function calls. Besides the extractImageData() is invoked by
2689         ewk_view_screenshot_contents_get() in order to take the visible content displayed on the EFL webview.
2690
2691         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
2692         (createBitmapContextFromWebView): Add to call DumpRenderTreeSupportEfl::forcePaint().
2693
2694 2014-04-15  Filip Pizlo  <fpizlo@apple.com>
2695
2696         Update LLVM export scrpt to handle the build directory being different from the
2697         source directory.
2698
2699         Rubber stamped by Geoffrey Garen.
2700
2701         * Scripts/export-llvm-build:
2702
2703 2014-04-15  Ryosuke Niwa  <rniwa@webkit.org>
2704
2705         Update the hyperlink to waterfall views of perf bots on build.webkit.org
2706         https://bugs.webkit.org/show_bug.cgi?id=131695
2707
2708         Reviewed by Antti Koivisto.
2709
2710         Updated.
2711
2712         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2713
2714 2014-04-15  Carlos Garcia Campos  <cgarcia@igalia.com>
2715
2716         [GTK] Reduce the binary size by compressing the text based web inspector resources
2717         https://bugs.webkit.org/show_bug.cgi?id=121545
2718
2719         Reviewed by Gustavo Noronha Silva.
2720
2721         Compress text based files when compiling inspector resources. It
2722         reduces the binary size in 3MB.
2723
2724         * gtk/generate-inspector-gresource-manifest.py:
2725         (find_all_files_in_directory):
2726         (is_compressible):
2727
2728 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
2729
2730         Remove Gtk WebKit1 tester.
2731
2732         Gtk WebKit1 port no longer exists, and dashboard was trying to load its tester
2733         results over and over as fast as it could.
2734
2735         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2736         (WebKitBuildbot):
2737
2738 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
2739
2740         Wrong link for webkitpy tests results in dashboard popover
2741         https://bugs.webkit.org/show_bug.cgi?id=131664
2742
2743         Reviewed by Timothy Hatcher.
2744
2745         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2746         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds):
2747         Use a correct link.
2748
2749 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
2750
2751         Update webkitpy regression test result that started to fail after http://trac.webkit.org/r167243
2752
2753         I'm not sure whether the changes are desirable, but am not suspicious enough to roll out.
2754
2755         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2756         (CommitMessageForThisCommitTest):
2757
2758 2014-04-14  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
2759
2760         Fix commit-log-editor bug revealed by r165447
2761         https://bugs.webkit.org/show_bug.cgi?id=130676
2762
2763         Reviewed by Csaba Osztrogonác.
2764
2765         * Scripts/commit-log-editor:
2766         (createCommitMessage): Omitting empty Source/JavaScriptCore:... blocks.
2767         Add \n before the first block too, because the longest common prefix now ends with only one newline.
2768         (removeLongestCommonPrefixEndingInNewline): The longest common prefix ends with only one newline,
2769         now the last block of the common prefix isn't duplicated below. Changing the function name accordingly.
2770
2771 2014-04-13  Darin Adler  <darin@apple.com>
2772
2773         userVisibleString should not try to "encode" host names
2774         https://bugs.webkit.org/show_bug.cgi?id=131587
2775         rdar://problem/14686849
2776
2777         Reviewed by Alexey Proskuryakov.
2778
2779         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added URLExtras.mm.
2780
2781         * TestWebKitAPI/Tests/mac/URLExtras.mm: Added. A few tests for WebCoreNSURLExtras.
2782         Coverage is tiny at this point; we could add a lot more cases!
2783
2784 2014-04-13  Jaehun Lim  <ljaehun.lim@samsung.com>
2785
2786         Use #include instead of #import
2787         https://bugs.webkit.org/show_bug.cgi?id=131604
2788
2789         Reviewed by Darin Adler.
2790
2791         Fix "warning: #import is a deprecated GCC extension [-Wdeprecated]".
2792
2793         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2794
2795 2014-04-12  Filip Pizlo  <fpizlo@apple.com>
2796
2797         Make slow-stress tests run faster by running fewer VM variants.
2798
2799         Rubber stamped by Geoffrey Garen.
2800
2801         * Scripts/run-javascriptcore-tests:
2802         * Scripts/run-jsc-stress-tests:
2803
2804 2014-04-10  Zan Dobersek  <zdobersek@igalia.com>
2805
2806         [CMake] Add missing WTF unit tests
2807         https://bugs.webkit.org/show_bug.cgi?id=131459
2808
2809         Reviewed by Martin Robinson.
2810
2811         * TestWebKitAPI/CMakeLists.txt: Add a few missing source files
2812         that should be compiled into the TestWTF binary.
2813
2814 2014-04-10  Brendan Long  <b.long@cablelabs.com>
2815
2816         [Gtk] run-launcher doesn't work by default
2817         https://bugs.webkit.org/show_bug.cgi?id=131494
2818
2819         Reviewed by Philippe Normand.
2820
2821         * Scripts/run-launcher: Always use MiniBrowser for WebKitGTK.
2822         * Scripts/webkitdirs.pm:
2823         (launcherName): Same.
2824         * Scripts/webkitpy/style/checker.py: Remove reference to GtkLauncher.
2825         * gtk/common.py:
2826         (get_build_path.is_valid_build_directory): Same.
2827         * gtk/manifest.txt: Same.
2828
2829 2014-04-09  Commit Queue  <commit-queue@webkit.org>
2830
2831         Unreviewed, rolling out r167046.
2832         https://bugs.webkit.org/show_bug.cgi?id=131479
2833
2834         Caused 300+ failures on Mavericks WK1 tester (Requested by ap
2835         on #webkit).
2836
2837         Reverted changeset:
2838
2839         "Remove "System Font" from whitelisted DRT fonts and char
2840         width calculations"
2841         https://bugs.webkit.org/show_bug.cgi?id=131411
2842         http://trac.webkit.org/changeset/167046
2843
2844 2014-04-09  Myles C. Maxfield  <mmaxfield@apple.com>
2845
2846         Remove "System Font" from whitelisted DRT fonts and char width calculations
2847         https://bugs.webkit.org/show_bug.cgi?id=131411
2848
2849         Reviewed by Tim Horton.
2850
2851         Covered by existing tests.
2852
2853         * DumpRenderTree/mac/DumpRenderTree.mm:
2854         (allowedFontFamilySet):
2855
2856 2014-04-09  Myles C. Maxfield  <mmaxfield@apple.com>
2857
2858         systemHiddenFontFamilySet in DRT is unnecessary
2859         https://bugs.webkit.org/show_bug.cgi?id=131414
2860
2861         Reviewed by Tim Horton.
2862
2863         It doesn't seem to affect test results on my machine.
2864
2865         * DumpRenderTree/mac/DumpRenderTree.mm:
2866         (drt_NSFontManager_availableFonts):
2867         (systemHiddenFontFamilySet): Deleted.
2868
2869 2014-04-09  Brent Fulgham  <bfulgham@apple.com>
2870
2871         [Win] Unreviewed test fix: Don't double-release BSTR.
2872
2873         * DumpRenderTree/win/DumpRenderTree.cpp:
2874         (dump): Remove unneeded call to SysFreeString now that we are
2875         using _bstr_t for this variable.
2876
2877 2014-04-09  Brent Fulgham  <bfulgham@apple.com>
2878
2879         [Win] Various DumpRenderTree Fixes.
2880         https://bugs.webkit.org/show_bug.cgi?id=131446.
2881
2882         Reviewed by Tim Horton.
2883
2884         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2885         (AccessibilityUIElement::title): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2886         (AccessibilityUIElement::description): Ditto.
2887         (AccessibilityUIElement::helpText): Ditto.
2888         (AccessibilityUIElement::intValue): Ditto.
2889         (AccessibilityUIElement::isPressActionSupported): Ditto.
2890         (AccessibilityUIElement::accessibilityValue): Ditto.
2891         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
2892         (DRTDesktopNotificationPresenter::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
2893         (DRTDesktopNotificationPresenter::AddRef): Ditto.
2894         (DRTDesktopNotificationPresenter::Release): Ditto.
2895         (DRTDesktopNotificationPresenter::showDesktopNotification): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2896         (DRTDesktopNotificationPresenter::cancelDesktopNotification): Ditto.
2897         (DRTDesktopNotificationPresenter::notificationDestroyed): Ditto.
2898         (DRTDesktopNotificationPresenter::checkNotificationPermission): Ditto.
2899         (DRTDesktopNotificationPresenter::requestNotificationPermission): Ditto.
2900         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
2901         * DumpRenderTree/win/DumpRenderTree.cpp:
2902         (dumpFrameScrollPosition): Ditto.
2903         (dumpFramesAsText): Ditto.
2904         (compareHistoryItems): Ditto.
2905         (dumpHistoryItem): Ditto.
2906         (dump): Ditto.
2907         (resetDefaultsToConsistentValues): Ditto.
2908         (resetWebViewToConsistentStateBeforeTesting): Ditto.
2909         (runTest): Ditto.
2910         (createWebViewAndOffscreenWindow): Ditto.
2911         * DumpRenderTree/win/EditingDelegate.cpp:
2912         (EditingDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
2913         (EditingDelegate::AddRef): Ditto.
2914         (EditingDelegate::Release): Ditto.
2915         (dumpPath): Switch to _bstr_t. Use JSStringCreateWithBSTR
2916         (EditingDelegate::shouldBeginEditingInDOMRange): Get rid of uneeded STDMETHODCALLTYPE declaration.
2917         (EditingDelegate::shouldEndEditingInDOMRange): Ditto.
2918         (EditingDelegate::shouldInsertNode): Ditto.
2919         (EditingDelegate::shouldInsertText): Ditto.
2920         (EditingDelegate::shouldDeleteDOMRange): Ditto.
2921         (EditingDelegate::shouldChangeSelectedDOMRange): Ditto.
2922         (EditingDelegate::shouldApplyStyle): Ditto.
2923         (EditingDelegate::shouldChangeTypingStyle): Ditto.
2924         (EditingDelegate::doPlatformCommand): Ditto.
2925         (EditingDelegate::webViewDidBeginEditing): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2926         (EditingDelegate::webViewDidChange): Ditto.
2927         (EditingDelegate::webViewDidEndEditing): Ditto.
2928         (EditingDelegate::webViewDidChangeTypingStyle): Ditto.
2929         (EditingDelegate::webViewDidChangeSelection): Ditto.
2930         (EditingDelegate::checkSpellingOfString): Ditto.
2931         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2932         (descriptionSuitableForTestResult): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2933         (FrameLoadDelegate::FrameLoadDelegate): Ditto.
2934         (FrameLoadDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
2935         (FrameLoadDelegate::AddRef): Ditto.
2936         (FrameLoadDelegate::Release): Ditto.
2937         (FrameLoadDelegate::didStartProvisionalLoadForFrame): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2938         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame): Ditto.
2939         (FrameLoadDelegate::didFailProvisionalLoadWithError): Ditto.
2940         (FrameLoadDelegate::didCommitLoadForFrame): Ditto.
2941         (FrameLoadDelegate::didReceiveTitle): Ditto.
2942         (FrameLoadDelegate::didChangeIcons): Ditto.
2943         (delegatesWithDelayedWork): Ditto.
2944         (FrameLoadDelegate::didFinishLoadForFrame): Ditto.
2945         (FrameLoadDelegate::didFailLoadWithError): Ditto.
2946         (FrameLoadDelegate::willPerformClientRedirectToURL): Ditto.
2947         (FrameLoadDelegate::didCancelClientRedirectForFrame): Ditto.
2948         (FrameLoadDelegate::willCloseFrame): Ditto.
2949         (FrameLoadDelegate::didFinishDocumentLoadForFrame): Ditto.
2950         (FrameLoadDelegate::didHandleOnloadEventsForFrame): Ditto.
2951         (FrameLoadDelegate::didFirstVisuallyNonEmptyLayoutInFrame): Ditto.
2952         (FrameLoadDelegate::didDisplayInsecureContent): Ditto.
2953         (FrameLoadDelegate::didRunInsecureContent): Ditto.
2954         * DumpRenderTree/win/FrameLoadDelegate.h:
2955         * DumpRenderTree/win/HistoryDelegate.cpp:
2956         (HistoryDelegate::didNavigateWithNavigationData): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2957         (HistoryDelegate::updateHistoryTitle): Ditto.
2958         (HistoryDelegate::populateVisitedLinksForWebView): Ditto.
2959         * DumpRenderTree/win/PolicyDelegate.cpp:
2960         (dumpPath):
2961         (PolicyDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
2962         (PolicyDelegate::AddRef): Ditto.
2963         (PolicyDelegate::Release): Ditto.
2964         (PolicyDelegate::decidePolicyForNavigationAction): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2965         (PolicyDelegate::unableToImplementPolicyWithError): Ditto.
2966         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2967         (ResourceLoadDelegate::descriptionSuitableForTestResult): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2968         (ResourceLoadDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
2969         (ResourceLoadDelegate::AddRef): Ditto.
2970         (ResourceLoadDelegate::Release): Ditto.
2971         (ResourceLoadDelegate::identifierForInitialRequest): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2972         (ResourceLoadDelegate::removeIdentifierForRequest): Ditto.
2973         (ResourceLoadDelegate::willSendRequest): Ditto.
2974         (ResourceLoadDelegate::didReceiveAuthenticationChallenge): Ditto.
2975         (ResourceLoadDelegate::didReceiveResponse): Ditto.
2976         (ResourceLoadDelegate::didFinishLoadingFromDataSource): Ditto.
2977         (ResourceLoadDelegate::didFailLoadingWithError): Ditto.
2978         * DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
2979         (TestRunner::queueLoad): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2980         (TestRunner::setUserStyleSheetLocation): Ditto.
2981         (TestRunner::execCommand): Ditto.
2982         (TestRunner::overridePreference): Ditto.
2983         (TestRunner::evaluateScriptInIsolatedWorld): Ditto.
2984         * DumpRenderTree/win/TextInputControllerWin.cpp: Ditto.
2985         (TextInputController::setMarkedText): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2986         (TextInputController::insertText): Ditto.
2987         * DumpRenderTree/win/UIDelegate.cpp:
2988         (UIDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
2989         (UIDelegate::AddRef): Ditto.
2990         (UIDelegate::Release): Ditto.
2991         (UIDelegate::hasCustomMenuImplementation): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2992         (UIDelegate::trackCustomPopupMenu): Ditto.
2993         (UIDelegate::registerUndoWithTarget): Ditto.
2994         (UIDelegate::removeAllActionsWithTarget): Ditto.
2995         (UIDelegate::setActionTitle): Ditto.
2996         (UIDelegate::undo): Ditto.
2997         (UIDelegate::redo): Ditto.
2998         (UIDelegate::canUndo): Ditto.
2999         (UIDelegate::canRedo): Ditto.
3000         (UIDelegate::printFrame): Ditto.
3001         (UIDelegate::ftpDirectoryTemplatePath): Ditto.
3002         (UIDelegate::webViewHeaderHeight): Ditto.
3003         (UIDelegate::webViewFooterHeight): Ditto.
3004         (UIDelegate::drawHeaderInRect): Ditto.
3005         (UIDelegate::drawFooterInRect): Ditto.
3006         (UIDelegate::webViewPrintingMarginRect): Ditto.
3007         (UIDelegate::canRunModal): Ditto.
3008         (UIDelegate::createModalDialog): Ditto.
3009         (UIDelegate::runModal): Ditto.
3010         (UIDelegate::isMenuBarVisible): Ditto.
3011         (UIDelegate::setMenuBarVisible): Ditto.
3012         (UIDelegate::runDatabaseSizeLimitPrompt): Ditto.
3013         (UIDelegate::paintCustomScrollbar): Ditto.
3014         (UIDelegate::paintCustomScrollCorner): Ditto.
3015         (UIDelegate::setFrame): Ditto.
3016         (UIDelegate::webViewFrame): Ditto.
3017         (UIDelegate::runJavaScriptAlertPanelWithMessage): Ditto.
3018         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Ditto.
3019         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Ditto.
3020         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage): Ditto.
3021         (UIDelegate::webViewAddMessageToConsole): Ditto.
3022         (UIDelegate::doDragDrop): Ditto.
3023         (UIDelegate::webViewGetDlgCode): Ditto.
3024         (UIDelegate::createWebViewWithRequest): Ditto.
3025         (UIDelegate::webViewClose): Ditto.
3026         (UIDelegate::webViewFocus): Ditto.
3027         (UIDelegate::webViewUnfocus): Ditto.
3028         (UIDelegate::webViewPainted): Ditto.
3029         (UIDelegate::exceededDatabaseQuota): Ditto.
3030         (UIDelegate::embeddedViewWithArguments): Ditto.
3031         (UIDelegate::webViewClosing): Ditto.
3032         (UIDelegate::webViewSetCursor): Ditto.
3033         (UIDelegate::webViewDidInvalidate): Ditto.
3034         (UIDelegate::setStatusText): Ditto.
3035         (UIDelegate::desktopNotificationsDelegate): Ditto.
3036         (UIDelegate::drawBackground): Ditto.
3037         (UIDelegate::decidePolicyForGeolocationRequest): Ditto.
3038         (UIDelegate::didPressMissingPluginButton): Ditto.
3039         * DumpRenderTree/win/WorkQueueItemWin.cpp: Ditto.
3040         (LoadItem::invoke):  Switch to _bstr_t. Use JSStringCreateWithBSTR.
3041         (LoadHTMLStringItem::invoke): Ditto.
3042         (ScriptItem::invoke): Ditto.
3043
3044 2014-04-09  Gergo Balogh  <gbalogh.u-szeged@partner.samsung.com>
3045
3046         Stylechecker: False positive on inline asm code.
3047         https://bugs.webkit.org/show_bug.cgi?id=130570
3048
3049         Reviewed by Csaba Osztrogonác.
3050
3051         Disable stylechecking in asm blocks.
3052
3053         * Scripts/webkitpy/style/checkers/cpp.py:
3054         (process_line):
3055         (_InlineASMState):
3056         (_InlineASMState.__init__):
3057         (_InlineASMState.process_line):
3058         (_InlineASMState.isInside):
3059         (_process_lines):
3060         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3061         (WebKitStyleTest.test_member_initialization_list):
3062
3063 2014-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
3064
3065         [GTK] Move WebKit1 unit tests resources used by WebKit2 unit tests to WebKit2 resources dir
3066         https://bugs.webkit.org/show_bug.cgi?id=131029
3067
3068         Reviewed by Philippe Normand.
3069
3070         Add blank.ico and test.pdf to resources dir of WebKit2Gtk unit
3071         tests and remove the getWebKit1TestResoucesDir() method.
3072
3073         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
3074         (testDownloadLocalFile): Use Test::getResourcesDir().
3075         (testDownloadLocalFileError): Ditto.
3076         (serverCallback): Ditto.
3077         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
3078         (serverCallback): Ditto.
3079         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
3080         (httpServerCallback): Ditto.
3081         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
3082         (serverCallback): Ditto.
3083         * TestWebKitAPI/Tests/WebKit2Gtk/resources/blank.ico: Added.
3084         * TestWebKitAPI/Tests/WebKit2Gtk/resources/test.pdf: Added.
3085         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
3086         (Test::getWebKit1TestResoucesDir): Deleted.
3087
3088 2014-04-09  Alexey Proskuryakov  <ap@apple.com>
3089
3090         [WK2] HTTP authentication regression tests fail
3091         https://bugs.webkit.org/show_bug.cgi?id=81627
3092         <rdar://problem/11079296>
3093
3094         Reviewed by Anders Carlsson.
3095
3096         * WebKitTestRunner/TestController.h:
3097         * WebKitTestRunner/TestController.cpp:
3098         (WTR::TestController::createWebViewWithOptions): Added canAuthenticateAgainstProtectionSpaceInFrame
3099         to pageLoaderClient structure.
3100         (WTR::TestController::canAuthenticateAgainstProtectionSpaceInFrame): Return true
3101         for password based authentication (we do get server trust challenges on some tests,
3102         which WKTR can't handle).
3103         When this client call is not implemented or returns false, didReceiveAuthenticationChallengeInFrame
3104         calls won't be made, at least on CFNetwork based platforms.
3105         (WTR::TestController::didReceiveAuthenticationChallengeInFrame): Changed the output
3106         to omit <unknown>. The resource is always unknown with WK2, and it doesn't really
3107         make sense to associate auth requests with individual resources - there can be
3108         multiple resources loading at once from the same protection space, so WebKit1 API
3109         that had a resource identifier was inherently racy.
3110
3111 2014-04-09  Ryuan Choi  <ryuan.choi@samsung.com>
3112
3113         [EFL] Change font path for DumpRenderTree and WebKitTestRunner
3114         https://bugs.webkit.org/show_bug.cgi?id=131427
3115
3116         Reviewed by Gyuyoung Kim.
3117
3118         Since r166973, font path was changed.
3119
3120         * DumpRenderTree/PlatformEfl.cmake:
3121         * WebKitTestRunner/PlatformEfl.cmake:
3122
3123 2014-04-08  Geoffrey Garen  <ggaren@apple.com>
3124
3125         Fix the build-jsc build
3126         https://bugs.webkit.org/show_bug.cgi?id=131410
3127
3128         Reviewed by Michael Saboff.
3129
3130         * Scripts/build-jsc: Make sure to build bmalloc before WTF, since
3131         WTF depends on it.
3132
3133 2014-04-08  Martin Robinson  <mrobinson@igalia.com>
3134
3135         [GTK] Remove WebKit1 unit tests
3136         https://bugs.webkit.org/show_bug.cgi?id=131359
3137
3138         Reviewed by Anders Carlsson.
3139
3140         Remove all WebKit1 GTK+ unit tests, in preparation for removing the WebKit1 port
3141         entirely. We also remove the list of skipped WebKi1 tests from run-gtk-tests, as
3142         they were inadvertently left in http://trac.webkit.org/changeset/166504.
3143
3144         * CMakeLists.txt: No longer load the WebKit1 unit test CMakeLists.txt file.
3145         * Scripts/run-gtk-tests: Remove skipped WebKit1 unit tests.
3146         * TestWebKitAPI/Tests/WebKitGtk/CMakeLists.txt: Removed.
3147         * TestWebKitAPI/Tests/WebKitGtk/resources/blank.ico: Removed.
3148         * TestWebKitAPI/Tests/WebKitGtk/resources/test.html: Removed.
3149         * TestWebKitAPI/Tests/WebKitGtk/resources/test.ogg: Removed.
3150         * TestWebKitAPI/Tests/WebKitGtk/resources/test.pdf: Removed.
3151         * TestWebKitAPI/Tests/WebKitGtk/resources/test.txt: Removed.
3152         * TestWebKitAPI/Tests/WebKitGtk/test_utils.c: Removed.
3153         * TestWebKitAPI/Tests/WebKitGtk/test_utils.h: Removed.
3154         * TestWebKitAPI/Tests/WebKitGtk/testapplicationcache.c: Removed.
3155         * TestWebKitAPI/Tests/WebKitGtk/testatk.c: Removed.
3156         * TestWebKitAPI/Tests/WebKitGtk/testatkroles.c: Removed.
3157         * TestWebKitAPI/Tests/WebKitGtk/testcontextmenu.c: Removed.
3158         * TestWebKitAPI/Tests/WebKitGtk/testcopyandpaste.c: Removed.
3159         * TestWebKitAPI/Tests/WebKitGtk/testdomdocument.c: Removed.
3160         * TestWebKitAPI/Tests/WebKitGtk/testdomdomwindow.c: Removed.
3161         * TestWebKitAPI/Tests/WebKitGtk/testdomnode.c: Removed.
3162         * TestWebKitAPI/Tests/WebKitGtk/testdownload.c: Removed.
3163         * TestWebKitAPI/Tests/WebKitGtk/testfavicondatabase.c: Removed.
3164         * TestWebKitAPI/Tests/WebKitGtk/testglobals.c: Removed.
3165         * TestWebKitAPI/Tests/WebKitGtk/testhittestresult.c: Removed.
3166         * TestWebKitAPI/Tests/WebKitGtk/testhttpbackend.c: Removed.
3167         * TestWebKitAPI/Tests/WebKitGtk/testkeyevents.c: Removed.
3168         * TestWebKitAPI/Tests/WebKitGtk/testloading.c: Removed.
3169         * TestWebKitAPI/Tests/WebKitGtk/testmimehandling.c: Removed.
3170         * TestWebKitAPI/Tests/WebKitGtk/testnetworkrequest.c: Removed.
3171         * TestWebKitAPI/Tests/WebKitGtk/testnetworkresponse.c: Removed.
3172         * TestWebKitAPI/Tests/WebKitGtk/testwebbackforwardlist.c: Removed.
3173         * TestWebKitAPI/Tests/WebKitGtk/testwebdatasource.c: Removed.
3174         * TestWebKitAPI/Tests/WebKitGtk/testwebframe.c: Removed.
3175         * TestWebKitAPI/Tests/WebKitGtk/testwebhistoryitem.c: Removed.
3176         * TestWebKitAPI/Tests/WebKitGtk/testwebinspector.c: Removed.
3177         * TestWebKitAPI/Tests/WebKitGtk/testwebplugindatabase.c: Removed.
3178         * TestWebKitAPI/Tests/WebKitGtk/testwebresource.c: Removed.
3179         * TestWebKitAPI/Tests/WebKitGtk/testwebsettings.c: Removed.
3180         * TestWebKitAPI/Tests/WebKitGtk/testwebview.c: Removed.
3181         * TestWebKitAPI/Tests/WebKitGtk/testwindow.c: Removed.
3182
3183 2014-04-08  Brent Fulgham  <bfulgham@apple.com>
3184
3185         Unreviewed gardening (Take 2): Prevent users from attempting
3186         to build with known invalid cURL. 
3187
3188         * Scripts/webkitdirs.pm:
3189         (checkInstalledTools): Check for 7.34.0 (the broken version), not
3190         7.33.0 (the known good version).
3191
3192 2014-04-08  Martin Robinson  <mrobinson@igalia.com>
3193
3194         [GTK] Remove DumpRenderTree and GtkLauncher
3195         https://bugs.webkit.org/show_bug.cgi?id=131373
3196
3197         Reviewed by Andreas Kling.
3198
3199         Remove the GTK+ port of DumpRenderTree and GtkLauncher. These tools are
3200         no longer necessary now that WebKit1 GTK+ will be removed.
3201
3202         * CMakeLists.txt:
3203         * DumpRenderTree/PlatformGTK.cmake: Removed.
3204         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp: Removed.
3205         * DumpRenderTree/gtk/DumpRenderTree.cpp: Removed.
3206         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Removed.
3207         * DumpRenderTree/gtk/EditingCallbacks.cpp: Removed.
3208         * DumpRenderTree/gtk/EditingCallbacks.h: Removed.
3209         * DumpRenderTree/gtk/EventSender.cpp: Removed.
3210         * DumpRenderTree/gtk/EventSender.h: Removed.
3211         * DumpRenderTree/gtk/GCControllerGtk.cpp: Removed.
3212         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp: Removed.
3213         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp: Removed.
3214         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.h: Removed.
3215         * DumpRenderTree/gtk/TestRunnerGtk.cpp: Removed.
3216         * DumpRenderTree/gtk/TextInputController.cpp: Removed.
3217         * DumpRenderTree/gtk/TextInputController.h: Removed.
3218         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Removed.
3219         * GtkLauncher/CMakeLists.txt: Removed.
3220         * GtkLauncher/LauncherInspectorWindow.c: Removed.
3221         * GtkLauncher/LauncherInspectorWindow.h: Removed.
3222         * GtkLauncher/main.c: Removed.
3223         * GtkLauncher/simple.svg: Removed.
3224         * GtkLauncher/text.html: Removed.
3225         * WebKitTestRunner/PlatformGTK.cmake:
3226         * WebKitTestRunner/gtk/fonts/AHEM____.TTF: Renamed from Tools/DumpRenderTree/gtk/fonts/AHEM____.TTF.
3227         * WebKitTestRunner/gtk/fonts/FontWithNoValidEncoding.fon: Renamed from Tools/DumpRenderTree/gtk/fonts/FontWithNoValidEncoding.fon.
3228         * WebKitTestRunner/gtk/fonts/fonts.conf: Renamed from Tools/DumpRenderTree/gtk/fonts/fonts.conf.
3229
3230 2014-04-08  Mark Rowe  <mrowe@apple.com>
3231
3232         XPC services launched by Safari have wrong DYLD_FRAMEWORK_PATH set when launched via run-safari / debug-safari
3233         <https://webkit.org/b/131388> / <rdar://problem/16291687>
3234
3235         Reviewed by Alexey Proskuryakov.
3236
3237         * Scripts/webkitdirs.pm:
3238         (runMacWebKitApp): Set __XPC_DYLD_FRAMEWORK_PATH to the absolute path to the built products directory.
3239         (execMacWebKitAppForDebugging): Ditto.
3240
3241 2014-04-08  Geoffrey Garen  <ggaren@apple.com>
3242
3243         Build bmalloc on iOS too
3244         https://bugs.webkit.org/show_bug.cgi?id=131381
3245
3246         Reviewed by Andreas Kling.
3247
3248         * Scripts/build-webkit:
3249
3250 2014-04-08  Brent Fulgham  <bfulgham@apple.com>
3251
3252         Unreviewed gardening: Prevent users from attempting
3253         to build with known invalid cURL.
3254
3255         * Scripts/webkitdirs.pm:
3256         (checkInstalledTools): Block build attempts with bad
3257         Cygwin tool set.
3258
3259 2014-04-07  Geoffrey Garen  <ggaren@apple.com>
3260
3261         Build bmalloc on Mac
3262         https://bugs.webkit.org/show_bug.cgi?id=131333
3263
3264         Reviewed by Mark Rowe.
3265
3266         * Scripts/build-webkit: Add the bmalloc target if we're on Mac.
3267         (Note: Just testing Mac is not good enough because in this
3268         script 'Mac' means 'Mac or iOS'.)
3269
3270 2014-03-30  Filip Pizlo  <fpizlo@apple.com>
3271
3272         Move slow JSRegress tests out of the way so that they don't show up in run-jsc-benchmarks runs and also skip tests that are extremely long-running
3273         https://bugs.webkit.org/show_bug.cgi?id=130951
3274
3275         Reviewed by Geoffrey Garen.
3276
3277         * Scripts/run-javascriptcore-tests:
3278
3279 2014-04-06  Darin Adler  <darin@apple.com>
3280
3281         Rework CSS calc logic, fixing some reference count mistakes in Length
3282         https://bugs.webkit.org/show_bug.cgi?id=131280
3283
3284         Reviewed by Andreas Kling.
3285
3286         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added CalculationValue.cpp.
3287         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp: Added.
3288
3289 2014-04-04  Brian J. Burg  <burg@cs.washington.edu>
3290
3291         Enable WEB_REPLAY for PLATFORM(MAC)
3292         https://bugs.webkit.org/show_bug.cgi?id=130700
3293
3294         Reviewed by Timothy Hatcher.
3295
3296         * Scripts/webkitperl/FeatureList.pm: Set the default for WEB_REPLAY for OS X engineering builds.
3297
3298 2014-04-05  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3299
3300         [CMake] Include X11's include dirs in TestNetscapePlugin
3301         https://bugs.webkit.org/show_bug.cgi?id=131270
3302
3303         Reviewed by Martin Robinson.
3304
3305         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Include X11_INCLUDE_DIR since
3306         TestNetscapePlugin includes WebCore code that includes X headers.
3307
3308 2014-04-05  David Kilzer  <ddkilzer@apple.com>
3309
3310         REGRESSION (r166529): Fix build after renaming TileCache to LegacyTileCache
3311         <http://webkit.org/b/130986>
3312
3313         * Scripts/check-for-inappropriate-objc-class-names: Add 'Legacy'
3314         prefix to TileCache class names in exception list.
3315
3316 2014-04-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3317
3318         [GTK] kill-old-processes should kill dbus-daemon processes
3319         https://bugs.webkit.org/show_bug.cgi?id=127352
3320
3321         Reviewed by Martin Robinson.
3322
3323         * BuildSlaveSupport/kill-old-processes:
3324         (main):
3325
3326 2014-04-04  Andres Gomez  <agomez@igalia.com>
3327
3328         [Win] Update obsolete packages in cygwin
3329         https://bugs.webkit.org/show_bug.cgi?id=126264
3330
3331         Reviewed by Brent Fulgham.
3332
3333         Removed "apache" and "minires" as the first has been replaced by
3334         "lighttpd" and the second is now integrated into
3335         "cygwin". Replaced the transitional and now obsolete "gcc" package
3336         with "gcc-g++" and ensure that "python" stays at version "2.6.8"
3337         since the newer version available is "2.7.3" which breaks the
3338         build due to some funniness with environment variable handling.
3339
3340         * CygwinDownloader/cygwin-downloader.py:
3341         * CygwinDownloader/cygwin-downloader.zip:
3342
3343 2014-04-03  Joseph Pecoraro  <pecoraro@apple.com>
3344
3345         check-webkit-style: Improve warnings on Objective-C @property syntax
3346         https://bugs.webkit.org/show_bug.cgi?id=131200
3347
3348         Reviewed by Dan Bernstein.
3349
3350         * Scripts/webkitpy/style/checkers/cpp.py:
3351         (check_spacing):
3352         (CppChecker):
3353         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3354         (CppStyleTest.test_spacing_in_objective_c_properties):
3355
3356 2014-04-03  Santosh Mahto  <santoshbit2007@gmail.com>
3357
3358         Unreviewed. Moving my name to commiter section
3359
3360         * Scripts/webkitpy/common/config/contributors.json:
3361
3362 2014-04-03  Santosh Mahto  <santoshbit2007@gmail.com>
3363
3364         Unreviewed. Add myself as a committer.
3365
3366         * Scripts/webkitpy/common/config/contributors.json:
3367
3368 2014-04-03  Andrzej Badowski  <a.badowski@samsung.com>
3369
3370         [EFL][WK2] Replacing zoom functionality of MiniBrowser from scale_set to page_zoom_set.
3371         https://bugs.webkit.org/show_bug.cgi?id=130391
3372
3373         Reviewed by Gyuyoung Kim.
3374
3375         Change the implementation of the zoom functionality from ewk_view_scale_set
3376         to ewk_view_page_zoom_set.
3377
3378         * MiniBrowser/efl/main.c:
3379
3380 2014-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
3381
3382         [webkitpy] perf profiler does not understand --call-graph argument
3383         https://bugs.webkit.org/show_bug.cgi?id=131132
3384
3385         Reviewed by Ryosuke Niwa.
3386
3387         New versions of perf profiler have changed the argument from --call-graph to -g.
3388
3389         * Scripts/webkitpy/common/system/profiler.py:
3390         (Perf.wrapper_arguments): Use -g instead of --call-graph.
3391         * Scripts/webkitpy/port/driver_unittest.py:
3392         (DriverTest.test_profiler_as_wrapper): Update test accordingly.
3393
3394 2014-04-03  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
3395
3396         Add EFL WK2 performance bot to build.webkit.org
3397         https://bugs.webkit.org/show_bug.cgi?id=131034
3398
3399         Fix after r166707, use "Perf" instead of "perf" for consistency.
3400
3401         Reviewed by Csaba Osztrogonác.
3402
3403         * BuildSlaveSupport/build.webkit.org-config/config.json:
3404
3405 2014-04-03  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
3406
3407         Add EFL WK2 performance bot to build.webkit.org
3408         https://bugs.webkit.org/show_bug.cgi?id=131034
3409
3410         Reviewed by Csaba Osztrogonác.
3411
3412         * BuildSlaveSupport/build.webkit.org-config/config.json:
3413
3414 2014-04-02  Ryuan Choi  <ryuan.choi@samsung.com>
3415
3416         [EFL][WK1] Use Evas_Touch_Point_State instead of Ewk_Touch_Point_Type
3417         https://bugs.webkit.org/show_bug.cgi?id=131151
3418
3419         Reviewed by Gyuyoung Kim.
3420
3421         * DumpRenderTree/efl/EventSender.cpp: Replace Ewk_Touch_Point_Type to Evas_Touch_Point_State.
3422         (TouchEventInfo::TouchEventInfo):
3423         (sendTouchEvent):
3424         (addTouchPointCallback):
3425         (updateTouchPointCallback):
3426         (cancelTouchPointCallback):
3427         (releaseTouchPointCallback):
3428
3429 2014-04-02  David Kilzer  <ddkilzer@apple.com>
3430
3431         filter-build-webkit: Ignore xcodebuild warnings when compiling with newer builds of clang
3432         <http://webkit.org/b/131045>
3433
3434         Reviewed by Daniel Bates.
3435
3436         * Scripts/filter-build-webkit:
3437         (shouldIgnoreLine): Ignore DVTAssertions related to new builds
3438         of clang, plus debug data for all DVTAssertions.
3439
3440 2014-04-01  Dean Jackson  <dino@apple.com>
3441
3442         Load Media Controls js/css from bundle
3443         https://bugs.webkit.org/show_bug.cgi?id=131086
3444
3445         Reviewed by Eric Carlson.
3446
3447         We're now putting CSS files into the bundle, so remove the test for them.
3448
3449         * Scripts/check-for-inappropriate-files-in-framework:
3450
3451 2014-04-02  Martin Hock  <mhock@apple.com>
3452
3453         Unify private browsing with sessions.
3454         https://bugs.webkit.org/show_bug.cgi?id=130099
3455
3456         Reviewed by Alexey Proskuryakov.
3457
3458         Add an API test for ephemeral sessions similar to PrivateBrowsingPushStateNoHistoryCallback.
3459         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3460         * TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp:
3461         (TestWebKitAPI::didNavigateWithNavigationData):
3462         (TestWebKitAPI::didSameDocumentNavigationForFrame):
3463         (TestWebKitAPI::TEST):
3464
3465         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp: Also test to make sure private browsing can be disabled.
3466         (TestWebKitAPI::didNavigateWithoutNavigationData):
3467         (TestWebKitAPI::didNavigateWithNavigationData):
3468         (TestWebKitAPI::didSameDocumentNavigationForFrame):
3469         (TestWebKitAPI::TEST):
3470
3471 2014-04-02  Martin Robinson  <mrobinson@igalia.com>
3472
3473         REGRESSION(r165704): [GTK] Inspector resources not correctly generated
3474         https://bugs.webkit.org/show_bug.cgi?id=130343
3475
3476         Reviewed by Gustavo Noronha Silva.
3477
3478         * gtk/generate-inspector-gresource-manifest.py: Instead of hard-coding the file list, accept a list
3479         of directories on the command line and look for all appropriate files in those directories for the
3480         GResource archive. Also make archive paths relative to those directories.
3481         (find_all_files_in_directory): This helper looks for all the appropriate files in a given directory.
3482         (find_all_files_in_directory.select_file): Whether or not to add the file to the archive.
3483
3484 2014-04-02  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3485
3486         [webkitpy] Avoid multiple "Preparing rollout for bug" log messages
3487         https://bugs.webkit.org/show_bug.cgi?id=131106
3488
3489         Reviewed by Csaba Osztrogonác.
3490
3491         * Scripts/webkitpy/tool/commands/download.py:
3492         (AbstractRolloutPrepCommand._prepare_state):
3493         * Scripts/webkitpy/tool/commands/download_unittest.py:
3494         (test_prepare_rollout):
3495         (test_create_rollout):
3496         (test_create_rollout_resolved):
3497         (test_rollout):
3498
3499 2014-04-02  Krzysztof Wolanski  <k.wolanski@samsung.com>
3500
3501         [EFL] Add option to use separate web process for new window in MiniBrowser
3502         https://bugs.webkit.org/show_bug.cgi?id=130190
3503
3504         Reviewed by Gyuyoung Kim.
3505
3506         New created window (CTRL + n) will be open in separated web process.
3507         This option is enabled by adding a flag (S/separate-process) with launching
3508         MiniBrowser.
3509
3510         * MiniBrowser/efl/main.c:
3511         (elm_main):
3512
3513 2014-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
3514
3515         [GTK] Move NEWS file to a new location
3516         https://bugs.webkit.org/show_bug.cgi?id=130901
3517
3518         Reviewed by Brent Fulgham.
3519
3520         * gtk/manifest.txt: Update the NEWS file path.
3521
3522 2014-04-01  Anders Carlsson  <andersca@apple.com>
3523
3524         Fix build.
3525
3526         * MiniBrowser/mac/WK2BrowserWindowController.m:
3527         (-[WK2BrowserWindowController awakeFromNib]):
3528         (-[WK2BrowserWindowController dealloc]):
3529         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
3530
3531 2014-04-01  Brent Fulgham  <bfulgham@apple.com>
3532
3533         Unreviewed test gardening.
3534
3535         * Scripts/webkitpy/port/base_unittest.py:
3536         (PortTest.test_build_path): Handle the Debug case so we don't get webkitpy-test failures on our test bots.
3537
3538 2014-04-01  Zoltan Horvath  <zoltan@webkit.org>
3539
3540         [CSS Exclusions] Remove exclusions parsing support
3541         https://bugs.webkit.org/show_bug.cgi?id=131046
3542
3543         Reviewed by David Hyatt.
3544
3545         * Scripts/webkitperl/FeatureList.pm:
3546
3547 2014-04-01  Manuel Rego Casasnovas  <rego@igalia.com>
3548
3549         [GTK] Remove last reference to GTK+ WK1 EWS
3550         https://bugs.webkit.org/show_bug.cgi?id=131058
3551
3552         Reviewed by Martin Robinson.
3553
3554         In r166427 WK1 GTK+ bots and EWS where removed, but this file was missing.
3555
3556         * QueueStatusServer/config/queues.py: Remove reference to GTK+ WK1 EWS.
3557
3558 2014-04-01  Lucas Forschler  <lforschler@apple.com>
3559
3560         Add a 32bit JSC builder/tester.
3561         https://bugs.webkit.org/show_bug.cgi?id=131054
3562         
3563         Reviewed by Michael Saboff.
3564
3565         * BuildSlaveSupport/build.webkit.org-config/config.json:
3566         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3567         (Compile32bitJSC):
3568         (Run32bitJSCTests):
3569         (Run32bitJSCTests.countFailures):
3570         (BuildAndTest32bitJSCFactory):
3571         (BuildAndTest32bitJSCFactory.__init__):
3572
3573 2014-04-01  Martin Robinson  <mrobinson@igalia.com>
3574
3575         [GTK] No longer build WebKit1 gtkdoc
3576         https://bugs.webkit.org/show_bug.cgi?id=130970
3577
3578         Reviewed by Anders Carlsson.
3579
3580         * gtk/common.py:
3581         (gtk_version_of_pkg_config_file): Deleted.
3582         * gtk/generate-gtkdoc:
3583         (get_gtkdoc_module_paths): We no longer need to worry about GTK+ 2, since it
3584         was only applicable for WebKit1.
3585         (get_generator_for_config): No longer look for the WebKit1 configuration file.
3586
3587 2014-04-01  Mario Sanchez Prada  <mario.prada@samsung.com>
3588
3589         [GTK] Running minibrowser with url crashes in debug build
3590         https://bugs.webkit.org/show_bug.cgi?id=130492
3591
3592         Reviewed by Martin Robinson.
3593
3594         Update "uri-scheme" test not to use invalid URIs in it, so we
3595         don't get a mistmatch when comparing the original URI stored in
3596         the test class with the one returned by the WebKitWebView.
3597
3598         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
3599         (testWebContextURIScheme): Update the test.
3600
3601 2014-04-01  Mihai Tica  <mitica@adobe.com>
3602
3603         Unreviewed: Add myself as a commiter to the contributors list.
3604
3605         * Scripts/webkitpy/common/config/contributors.json:
3606
3607 2014-03-31  Ryuan Choi  <ryuan.choi@samsung.com>
3608
3609         [EFL][WK2] Extract the control of page background out of color_set
3610         https://bugs.webkit.org/show_bug.cgi?id=127539
3611
3612         Reviewed by Gyuyoung Kim.
3613
3614         Added an option(C) to change background color.
3615
3616         * MiniBrowser/efl/main.c:
3617         (window_create):
3618         (elm_main):
3619
3620 2014-03-31  Ryuan Choi  <ryuan.choi@samsung.com>
3621
3622         Unreviewed build fix on the EFL port with latest EFL libraries since r166149
3623
3624         * ImageDiff/PlatformEfl.cmake: Added ECORE_IMF_INCLUDE_DIRS to include dirs
3625
3626 2014-03-31  Brent Fulgham  <bfulgham@apple.com>
3627
3628         Unreviewed test correction after r166530.
3629
3630         * DumpRenderTree/mac/DumpRenderTree.mm:
3631         (setDefaultsToConsistentValuesForTesting): No need to change preference for all tests. We set the proper
3632         fine-grained setting for swipe tests. This prevents existing tests from breaking.
3633
3634 2014-03-31  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3635
3636         Remove the trigger for webkit1 tests on the gtk-linux-64-release bot
3637         https://bugs.webkit.org/show_bug.cgi?id=130987
3638
3639         r166427 removed the WebKit1 GTK+ bots, so we don't longer need to
3640         trigger the webkit1 bot tests on the gtk-linux-64-release bot.
3641
3642         Reviewed by Martin Robinson.
3643
3644         * BuildSlaveSupport/build.webkit.org-config/config.json:
3645
3646 2014-03-31  Dean Jackson  <dino@apple.com>
3647
3648         Remove WEB_ANIMATIONS
3649         https://bugs.webkit.org/show_bug.cgi?id=130989
3650
3651         Reviewed by Simon Fraser.
3652
3653         Remove this feature flag until we plan to implement.
3654
3655         * Scripts/webkitperl/FeatureList.pm:
3656
3657 2014-03-31  Brent Fulgham  <bfulgham@apple.com>
3658
3659         Reduced Latched Scroll Test Flakiness
3660         https://bugs.webkit.org/show_bug.cgi?id=130983