ebb1fa32e7381bc286f3953ce03575edb38303b2
[WebKit-https.git] / Tools / ChangeLog
1 2012-06-25  Dirk Pranke  <dpranke@chromium.org>
2
3         put vista back for chromium (non-webkit) bots ...
4         https://bugs.webkit.org/show_bug.cgi?id=89929
5
6         Unreviewed, build fix.
7
8         Turns out we've only gotten rid of vista on the webkit tests so
9         far. Put vista back for the other chromium bots ...
10
11         * TestResultServer/static-dashboards/flakiness_dashboard.js:
12         (chromiumPlatform):
13         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
14         (test):
15
16 2012-06-25  Dirk Pranke  <dpranke@chromium.org>
17
18         update flakiness dashboard after removing chromium-vista bots
19         https://bugs.webkit.org/show_bug.cgi?id=89925
20
21         Unreviewed, build fix.
22
23         More changes missed in r121194 :(.
24
25         * TestResultServer/static-dashboards/flakiness_dashboard.js:
26         (chromiumPlatform):
27         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
28         (test):
29
30 2012-06-25  Dirk Pranke  <dpranke@chromium.org>
31
32         remove support for chromium vista from tools
33         https://bugs.webkit.org/show_bug.cgi?id=89915
34
35         Reviewed by Tony Chang.
36
37         This change is all deleting code and updating tests to handle
38         the configuration being gone. All tests now pass except for a
39         few unittests for the flakiness dashboard which were failing
40         before this patch.
41
42         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
43         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
44         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
45         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
46         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
47         (BaselineOptimizerTest.test_complex_shadowing):
48         * Scripts/webkitpy/layout_tests/port/builders.py:
49         * Scripts/webkitpy/layout_tests/port/chromium.py:
50         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
51         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
52         (ChromiumWinPort):
53         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
54         (ChromiumWinTest.test_versions):
55         (ChromiumWinTest.test_baseline_path):
56         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
57         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
58         (BuildCoverageExtrapolatorTest.test_extrapolate):
59
60 2012-06-25  Scott Graham  <scottmg@chromium.org>
61
62         [Chromium] add empty impl of WebThemeEngine::getSize() for DRT
63         https://bugs.webkit.org/show_bug.cgi?id=89907
64
65         Not reviewed. Fix build in Chromium.
66
67         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
68         (WebThemeEngineDRTWin::getSize):
69         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h:
70         (WebThemeEngineDRTWin):
71
72 2012-06-25  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
73
74         [EFL] Implement Network Information API
75         https://bugs.webkit.org/show_bug.cgi?id=87067
76
77         Reviewed by Kenneth Rohde Christiansen.
78
79         * efl/jhbuild.modules: Add eeze library dependency.
80
81 2012-06-25  Simon Hausmann  <simon.hausmann@nokia.com>
82
83         [Qt] Fix Win32 debug build
84
85         Reviewed by Tor Arne Vestbø.
86
87         Consolidate use_all_in_one_files into mac/unix/win32 default_pre.prf.
88
89         * qmake/mkspecs/features/unix/default_pre.prf:
90         * qmake/mkspecs/features/win32/default_pre.prf: Added.
91
92 2012-06-24  Thiago Marcos P. Santos  <thiago.santos@intel.com>
93
94         [Qt] Enable <input type="color"> support by default
95         https://bugs.webkit.org/show_bug.cgi?id=89653
96
97         Reviewed by Kenneth Rohde Christiansen.
98
99         This feature is complete for Qt WebKit2. Enabling by default
100         will help to mature the implementation.
101
102         * Scripts/webkitperl/FeatureList.pm:
103         * qmake/mkspecs/features/features.pri:
104
105 2012-06-24  Dan Bernstein  <mitz@apple.com>
106
107         Made debug-{minibrowser,safari,test-runner} work with LLDB.
108
109         Reviewed by Sam Weinig.
110
111         * Scripts/debug-minibrowser: Pass INCLUDE_OPTIONS_FOR_DEBUGGING to
112         printHelpAndExitForRunAndDebugWebKitAppIfNeeded().
113         * Scripts/debug-safari: Ditto.
114         * Scripts/debug-test-runner: Ditto.
115         * Scripts/webkitdirs.pm:
116         (debugger): Added. Calls determineDebugger() if needed and returns the chosen debugger.
117         (determineDebugger): Added. Sets the debugger to "lldb" if the --use-lldb switch is present,
118         and to "gdb" otherwise.
119         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Changed to print help for the
120         --target-web-process and --use-lldb switches if passed INCLUDE_OPTIONS_FOR_DEBUGGING.
121         (execMacWebKitAppForDebugging): Changed to use the chosen debugger.
122
123 2012-06-24  Adam Barth  <abarth@webkit.org>
124
125         [Chromium] Release media resources after each LayoutTest on Android
126         https://bugs.webkit.org/show_bug.cgi?id=89720
127
128         Reviewed by Eric Carlson.
129
130         The LayoutTests can hang when run on Android because we sometimes run
131         out of media resources. This patch causes us to release our media
132         resources after each test in order to avoid running out of this
133         resource. In production, there are other mechanisms that manage this
134         resource.
135
136         * DumpRenderTree/chromium/TestShell.cpp:
137         (TestShell::resetTestController):
138
139 2012-06-23  Zan Dobersek  <zandobersek@gmail.com>
140
141         [Gtk] REGRESSION(r120918): Causes flaky DND tests
142         https://bugs.webkit.org/show_bug.cgi?id=89770
143
144         Reviewed by Martin Robinson.
145
146         Connect to the run-file-chooser signal of the WebKitWebView and
147         return TRUE so no file chooser dialog is run. This prevents certain
148         test failures.
149
150         * DumpRenderTree/gtk/DumpRenderTree.cpp:
151         (webViewRunFileChooser):
152         (createWebView):
153
154 2012-06-23  Dan Bernstein  <mitz@apple.com>
155
156         debug-{minibrowser,safari,test-runner} fail when gdb is not installed in /usr/bin.
157
158         Reviewed by Sam Weinig.
159
160         * Scripts/webkitdirs.pm:
161         (execMacWebKitAppForDebugging): Use xcrun to locate gdb.
162
163 2012-06-23  Carlos Garcia Campos  <cgarcia@igalia.com>
164
165         Unreviewed. Skip GTK+ unit test /webkit2/WebKitFindController/hide.
166
167         It fails always when running it in Xvfb.
168
169         * gtk/run-api-tests:
170         (TestRunner):
171
172 2012-06-23  Wajahat Siddiqui  <mdwajahatali.siddiqui@motorola.com>
173
174         [GTK][WK2]Mis-spelt defaultWindowTitle
175         https://bugs.webkit.org/show_bug.cgi?id=89808
176
177         Reviewed by Carlos Garcia Campos.
178
179         * MiniBrowser/gtk/BrowserWindow.c:
180
181 2012-06-23  Sergio Villar Senin  <svillar@igalia.com>
182
183         [GTK] Add a new webkit2 tests slave bot
184         https://bugs.webkit.org/show_bug.cgi?id=89336
185
186         Reviewed by Csaba Osztrogonác.
187
188         Slave configuration for a new GTK 64 bit release bot that will run
189         WebKit2 tests.
190
191         Also BuildAndTest now accepts the "triggers" parametter,
192         this means that apart from building and testing it can trigger
193         some other build/test sequences in other slaves.
194
195         * BuildSlaveSupport/build.webkit.org-config/config.json:
196         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
197         (BuildAndTestFactory.__init__):
198
199 2012-06-23  Kwang Yul Seo  <skyul@company100.net>
200
201         Unreviewed. Update my email.
202
203         * Scripts/webkitpy/common/config/committers.py:
204
205 2012-06-22  Adam Barth  <abarth@webkit.org>
206
207         [Chromium] DumpRenderTree on Android needs to configure fonts for testing
208         https://bugs.webkit.org/show_bug.cgi?id=89721
209
210         Reviewed by Nate Chapin.
211
212         This patch teaches DumpRenderTree to configure Skia to use the fallback
213         fonts that the LayoutTests assume. This patch reduces the number result
214         differences between chromium-android and chromium-linux.
215
216         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
217         * DumpRenderTree/chromium/TestShellAndroid.cpp:
218         (platformInit):
219         * DumpRenderTree/chromium/android_fallback_fonts.xml: Added.
220         * DumpRenderTree/chromium/android_main_fonts.xml: Added.
221         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
222
223 2012-06-22  Alexandru Chiculita  <achicu@adobe.com>
224
225         [CSS Shaders] Re-enable the CSS Shaders compile time flag on Safari Mac
226         https://bugs.webkit.org/show_bug.cgi?id=89781
227
228         Reviewed by Dean Jackson.
229
230         Added CSS Shaders as enabled by default on Safari for Mac.
231
232         * Scripts/webkitperl/FeatureList.pm:
233
234 2012-06-22  Adam Barth  <abarth@webkit.org>
235
236         Add support for test_expectations_android.txt for overriding test expecations on the chromium-android branch
237         https://bugs.webkit.org/show_bug.cgi?id=89791
238
239         Reviewed by Dirk Pranke.
240
241         Downstream, the chromium-android port maintains a test expectations
242         file to keep track of which tests pass or fail. That causes them to
243         keep a patch in chromium_android.py in their branch.
244
245         This patch teaches chromium_android.py to use test_expectations_android.txt.
246         We don't intend to use this file upstream, but having this code patch
247         upstream lets us unfork webkitpy.
248
249         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
250         (ChromiumAndroidPort.expectations_files):
251
252 2012-06-22  Dirk Pranke  <dpranke@chromium.org>
253
254         run_webkit_tests.py failed with AttributeError(''NoneType' object has no attribute 'pid'')
255         https://bugs.webkit.org/show_bug.cgi?id=89734
256
257         Reviewed by Ryosuke Niwa.
258
259         Fix a crash in ServerProcess if you called .pid() after it
260         crashed during a write(). We had a test for this case but the
261         test wasn't calling pid(), just has_crashed(). Fixed the problem
262         and the test.
263
264         * Scripts/webkitpy/layout_tests/port/server_process.py:
265         (ServerProcess.__init__):
266         (ServerProcess.pid):
267         (ServerProcess._start):
268         (ServerProcess.stop):
269         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
270         (FakeServerProcess._start):
271         (TestServerProcess.test_broken_pipe):
272
273 2012-06-22  Peter Beverloo  <peter@chromium.org>
274
275         [Chromium] Disable c++0x compatibility warnings in JavaScriptCore.gyp when building for Android
276         https://bugs.webkit.org/show_bug.cgi?id=88853
277
278         Reviewed by Steve Block.
279
280         The Android exclusions were necessary to fix a gyp generation error, as
281         the gcc_version variable wasn't being defined for Android. Remove these
282         exceptions when Chromium is able to define the gcc_version variable.
283
284         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
285
286 2012-06-22  Mario Sanchez Prada  <msanchez@igalia.com>
287
288         Unreviewed gardening. Unskipping test passing after fixing bug 88419.
289
290         * gtk/run-api-tests:
291         (TestRunner): Unskip WTF.HashMap.
292
293 2012-06-22  Zoltan Horvath  <zoltan@webkit.org>
294
295         [Qt] Allow DumpRenderTree to dump about:blank
296         https://bugs.webkit.org/show_bug.cgi?id=89685
297
298         Reviewed by Ryosuke Niwa.
299
300         We need to allow DumpRenderTree to dump about:blank page, then it will be consistent with other ports,
301         additionaly this behavior is required for running WTR performance tests.
302
303         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
304         (WebCore::DumpRenderTree::processLine):
305
306 2012-06-21  Adam Barth  <abarth@webkit.org>
307
308         [Chromium] Reset mediaPlaybackRequiresUserGesture WebSettings after each test
309         https://bugs.webkit.org/show_bug.cgi?id=89718
310
311         Reviewed by Kent Tamura.
312
313         We should reset this WebSetting to its default value so that it behaves
314         consistently across tests.
315
316         * DumpRenderTree/chromium/WebPreferences.cpp:
317         (WebPreferences::reset):
318         (WebPreferences::applyTo):
319         * DumpRenderTree/chromium/WebPreferences.h:
320         (WebPreferences):
321
322 2012-06-21  Zoltan Horvath  <zoltan@webkit.org>
323
324         DRT/WTR python interface handles about:blank incorrectly
325         https://bugs.webkit.org/show_bug.cgi?id=89563
326
327         Reviewed by Dirk Pranke.
328
329         Currently DRT/WTR python interface's _command_from_driver_input function
330         puts the test directory path before about:blank. Remove this incorrect behavior.
331
332         * Scripts/webkitpy/layout_tests/port/webkit.py:
333         (WebKitDriver._command_from_driver_input):
334
335 2012-06-21  Dirk Pranke  <dpranke@chromium.org>
336
337         reenable perf tests on win
338         https://bugs.webkit.org/show_bug.cgi?id=89690
339
340         Reviewed by Ryosuke Niwa.
341
342         Only the replay tests don't work, and those are disabled by
343         default. This change also fixes the undefined _log reference
344         that was causing a crash.
345
346         * Scripts/run-perf-tests:
347
348 2012-06-21  Sheriff Bot  <webkit.review.bot@gmail.com>
349
350         Unreviewed, rolling out r120937.
351         http://trac.webkit.org/changeset/120937
352         https://bugs.webkit.org/show_bug.cgi?id=89679
353
354         This patch brought buildbot master down (Requested by svillar
355         on #webkit).
356
357         * BuildSlaveSupport/build.webkit.org-config/config.json:
358
359 2012-06-21  Martin Robinson  <mrobinson@igalia.com>
360
361         [GTK] Combine WebKit API tests into fewer binaries
362         https://bugs.webkit.org/show_bug.cgi?id=88458
363
364         Reviewed by Carlos Garcia Campos.
365
366         Instead of creating one binary per-test file, create binaries for each
367         category of tests. Right now this includes WTF and the WebKit2 C API,
368         but later tests can be added for the GTK+ platform layer and the WebKit1
369         and WebKit2 API layers.
370
371         * TestWebKitAPI/GNUmakefile.am: Compile only two test binaries, one for the WebKit2
372           C API and one for WTF. Refresh the source list to ensure that new test are active.
373         * gtk/run-api-tests: Change the way that tests are skipped by splitting out the
374         concept of skipping a test and skipping a suite (program) of tests. Test cases are
375         skipped because of legitimate failures, but entire programs are skipped because of
376         problems in the harness. As of right now a test program is only skipped if the
377         accessibility bus cannot be started.
378         (SkippedTest.__init__): Make the test case a required argument and have one skipped
379         test case per SkippedTest instance.
380         (SkippedTest.__str__): Ditto.
381         (TestRunner): Update the directory list. We only have two gtest binaries now and they are
382         in one directory. Reformat the test list to make it slightly easier to read.
383         (TestRunner.__init__): Add the _skipped_test_program member, which handles entire
384         test programs that are skipped.
385         (TestRunner._setup_testing_environment): Use the new member.
386         (TestRunner._test_cases_to_skip): Collect all skipped test cases now instead of just
387         the first SkippedTest that matches.
388         (TestRunner._should_run_test_program): Take a look at the new member to make this
389         decision.
390         (TestRunner._run_test_command): Use the name test_program instead of test
391         to disambiguate between test cases and test suites.
392         (TestRunner._run_test_glib): ditto.
393         (TestRunner._run_test_google): Ditto.
394         (TestRunner._run_test): Ditto.
395         (TestRunner.run_tests): Ditto.
396
397 2012-06-21  Yong Li  <yoli@rim.com>
398
399         Unreviewed. Moving myself from committer to reviewer.
400
401         * Scripts/webkitpy/common/config/committers.py:
402
403 2012-06-21  Sergio Villar Senin  <svillar@igalia.com>
404
405         [GTK] Add a new webkit2 tests slave bot
406         https://bugs.webkit.org/show_bug.cgi?id=89336
407
408         Reviewed by Philippe Normand.
409
410         Slave configuration for a new GTK bot that will run WebKit2 tests.
411
412         * BuildSlaveSupport/build.webkit.org-config/config.json:
413
414 2012-06-21  Thiago Marcos P. Santos  <thiago.santos@intel.com>
415
416         [Qt] Add a custom Color Chooser widget to MiniBrowser
417         https://bugs.webkit.org/show_bug.cgi?id=87988
418
419         Reviewed by Alexis Menard.
420
421         Added custom color chooser example for the MiniBrowser.
422
423         * MiniBrowser/qt/MiniBrowser.qrc:
424         * MiniBrowser/qt/qml/BrowserWindow.qml:
425         * MiniBrowser/qt/qml/ColorChooser.qml: Added.
426
427 2012-06-21  Vivek Galatage  <vivekgalatage@gmail.com>
428
429         Remove the warning "File not found" in MiniBrowser post-build event
430         https://bugs.webkit.org/show_bug.cgi?id=89601
431
432         Reviewed by Adam Roben.
433
434         * MiniBrowser/MiniBrowserPostBuild.cmd:
435
436 2012-06-21  Balazs Kelemen  <kbalazs@webkit.org>
437
438         [Qt] DRT in standalone mode hangs after the first test
439         https://bugs.webkit.org/show_bug.cgi?id=89613
440
441         Reviewed by Csaba Osztrogonác.
442
443         Break an inline signal slot chain that ends up in setting
444         LayoutTestController::m_hasDumped too early. In LayoutTestController::maybeDump()
445         we emit done() which starts the chain that finishes in DumpRenderTree::open().
446         The next line in maybeDump sets m_hasDumped to true. We could simply reorder
447         these two lines but it seems to be wrong in general to start the next load
448         from this call chain. The server mode (when DRT is runned by the test harness)
449         also uses a queued connection to read the next test from stdin.
450
451         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
452         (WebCore::DumpRenderTree::processArgsLine):
453
454 2012-06-20  Hans Wennborg  <hans@chromium.org>
455
456         Speech JavaScript API: SpeechRecognition should hook up with ActiveDOMObject more
457         https://bugs.webkit.org/show_bug.cgi?id=89217
458
459         Reviewed by Adam Barth.
460
461         Add a method for checking whether the mock speech
462         recognition was aborted.
463
464         Also redo the way the mock posts tasks. Instead of posting them all at once,
465         maintain an internal queue of task objects, and call postTask() for them
466         once at the time. This means that for example when the page is navigated
467         away and abort() is called, that call doesn't end up after a bunch
468         of previously posted events on the event loop.
469
470         * DumpRenderTree/chromium/LayoutTestController.cpp:
471         (LayoutTestController::LayoutTestController):
472         (LayoutTestController::wasMockSpeechRecognitionAborted):
473         * DumpRenderTree/chromium/LayoutTestController.h:
474         (LayoutTestController):
475         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
476         (WebKit::ClientCallTask::ClientCallTask):
477         (WebKit::ResultTask::ResultTask):
478         (WebKit::NoMatchTask::NoMatchTask):
479         (WebKit::ErrorTask::ErrorTask):
480         (MockWebSpeechRecognizer::start):
481         (MockWebSpeechRecognizer::abort):
482         (MockWebSpeechRecognizer::setError):
483         (MockWebSpeechRecognizer::MockWebSpeechRecognizer):
484         (MockWebSpeechRecognizer::startTaskQueue):
485         (MockWebSpeechRecognizer::StepTask::runIfValid):
486         * DumpRenderTree/chromium/MockWebSpeechRecognizer.h:
487         (MockWebSpeechRecognizer::hasBeenAborted):
488         (MockWebSpeechRecognizer):
489         (MockWebSpeechRecognizer::taskList):
490         (Task):
491         (MockWebSpeechRecognizer::Task::Task):
492         (MockWebSpeechRecognizer::Task::~Task):
493         (StepTask):
494         (MockWebSpeechRecognizer::StepTask::StepTask):
495
496 2012-06-21  Mario Sanchez Prada  <msanchez@igalia.com>
497
498         [GTK] Add support for window.showModalDialog in WebKit2GTK+
499         https://bugs.webkit.org/show_bug.cgi?id=79500
500
501         Reviewed by Carlos Garcia Campos.
502
503         Add support for modal dialogs in GTK's MiniBrowser.
504
505         * MiniBrowser/gtk/BrowserWindow.c:
506         (webViewRunAsModal):
507         (webViewCreate):
508         (webViewDecidePolicy):
509         (browser_window_new):
510         * MiniBrowser/gtk/BrowserWindow.h:
511         * MiniBrowser/gtk/main.c:
512         (createBrowserWindow):
513
514 2012-06-20  Brent Fulgham  <bfulgham@webkit.org>
515
516         [WinCairo] Unreviewed build fix.
517         The wrapper script that launched new- and old-run-webkit-tests
518         was discarding the --wincairo argument needed to get the proper
519         test infrastructure to build under WinCairo.
520
521         * Scripts/run-webkit-tests: Emulate the Qt, Wx, Chromium, etc.,
522         behavior to chain the --wincairo flag through to the new build
523         and test scripts.
524
525 2012-06-20  Mark Rowe  <mrowe@apple.com>
526
527         <http://webkit.org/b/89606> Teach run-safari and debug-safari to work with a Safari.app that has entitlements
528
529         Reviewed by Dan Bernstein.
530
531         * Scripts/webkitdirs.pm:
532         (executableHasEntitlements):
533         (safariPathFromSafariBundle):
534
535 2012-06-20  Sheriff Bot  <webkit.review.bot@gmail.com>
536
537         Unreviewed, rolling out r120821.
538         http://trac.webkit.org/changeset/120821
539         https://bugs.webkit.org/show_bug.cgi?id=89605
540
541         It made duplicated reviewer entries (Requested by Ossy on
542         #webkit).
543
544         * Scripts/webkitpy/common/checkout/changelog.py:
545         (ChangeLog.set_reviewer):
546         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
547         (test_set_reviewer):
548         (test_set_short_description_and_bug_url):
549
550 2012-06-20  Dirk Pranke  <dpranke@chromium.org>
551
552         nrwt outputs empty files for wdiff output if wdiff is not installed
553         https://bugs.webkit.org/show_bug.cgi?id=88709
554
555         Reviewed by Tony Chang.
556
557         Reviewed by Tony Chang.
558
559         Don't write -wdiff or -pretty.html files if wdiff or prettypatch
560         aren't available, and clean up the handling for them in the port
561         code.
562
563         * Scripts/webkitpy/run_webkit_tests_integrationtest.py:
564         (MainTest.test_output_diffs):
565         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
566         (TestResultWriter.create_text_diff_and_write_result):
567         * Scripts/webkitpy/layout_tests/port/base.py:
568         (Port.check_pretty_patch):
569         (Port.check_wdiff):
570         (Port._wdiff_missing_message):
571         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
572         (ChromiumLinuxPort.check_build):
573         (ChromiumLinuxPort._wdiff_missing_message):
574         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
575         (ChromiumMacPort.check_build):
576         (ChromiumMacPort):
577         (ChromiumMacPort._wdiff_missing_message):
578         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
579         (ChromiumMacPortTest):
580
581 2012-06-20  Dirk Pranke  <dpranke@chromium.org>
582
583         nrwt: fix unit tests for ensuring svn revision is correct
584         https://bugs.webkit.org/show_bug.cgi?id=89498
585
586         Reviewed by Eric Seidel.
587
588         Reviewed by Eric Seidel.
589
590         Fix the unit tests for testing that we are embedding the SVN
591         revision in the results json for NRWT properly; this was broken
592         in r120646 but because the MockHost worked differently than the
593         real one (by always initializing the MockSCM object) we didn't
594         notice. Unfortunately, just changing the default breaks all
595         sorts of unit tests ...
596
597         * Scripts/webkitpy/common/host_mock.py:
598         (MockHost.__init__):
599         (MockHost._initialize_scm):
600         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
601         (ResultSummaryTest.test_no_svn_revision):
602         (ResultSummaryTest.test_svn_revision):
603
604 2012-06-20  Dirk Pranke  <dpranke@chromium.org>
605
606         new-run-webkit-tests appends "/Debug" or "/Release" to $WEBKITOUTPUTDIR
607         https://bugs.webkit.org/show_bug.cgi?id=69360
608
609         Reviewed by Eric Seidel.
610
611         Reviewed by Eric Seidel.
612
613         Propagate the 'port_implementation' part of the platform (i.e.,
614         gtk,qt,chromium) to webkit-build-directory so that we can pick
615         up the gtk-specific handling of WEBKITOUTPUTDIR ...
616
617         I didn't write any additional tests for this; testing it
618         properly is an integration test between the python code and the
619         perl code, which I verified by hand.
620
621         * Scripts/webkitpy/layout_tests/port/base.py:
622         (Port.__init__):
623         * Scripts/webkitpy/layout_tests/port/config.py:
624         (Config.__init__):
625         (Config.build_directory):
626         * Scripts/webkitpy/layout_tests/port/config_mock.py:
627         (MockConfig.__init__):
628         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
629         (ConfigTest.test_build_directory_passes_port_implementation):
630
631 2012-06-20  Dirk Pranke  <dpranke@chromium.org>
632
633         Fix import sorting missed in r120846
634
635         Reviewed by Tony Chang.
636
637         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
638
639 2012-06-20  Dirk Pranke  <dpranke@chromium.org>
640
641         Fix chromium win http servers after breakage introduced in r120846.
642
643         Unreviewed, build fix.
644
645         * Scripts/webkitpy/layout_tests/port/base.py:
646         (Port.to.start_http_server):
647         * Scripts/webkitpy/layout_tests/servers/http_server.py:
648         (Lighttpd.__init__):
649
650 2012-06-20  Dirk Pranke  <dpranke@chromium.org>
651
652         tweak output of webkit-patch print-{baselines,expectations}
653         https://bugs.webkit.org/show_bug.cgi?id=89588
654
655         Reviewed by Tony Chang.
656
657         Minor tweaks to the output to make it more readable, including
658         turning off csv by default for print-baselines with multiple ports.
659
660         * Scripts/webkitpy/layout_tests/port/test.py:
661         (TestPort):
662         * Scripts/webkitpy/tool/commands/queries.py:
663         (PrintExpectations.execute):
664         (PrintBaselines.execute):
665         * Scripts/webkitpy/tool/commands/queries_unittest.py:
666         (PrintExpectationsTest.run_test):
667         (PrintExpectationsTest.test_multiple):
668         (PrintBaselinesTest.setUp):
669         (PrintBaselinesTest.test_multiple):
670
671 2012-06-18  Dirk Pranke  <dpranke@chromium.org>
672
673         new-run-webkit-tests should spin-up enough httpd processes to avoid timeouts
674         https://bugs.webkit.org/show_bug.cgi?id=88134
675
676         Reviewed by Tony Chang.
677
678         Change NRWT to spin up 2*min(child_processes, locked_shards)
679         http servers by default so that we are less likely to get a
680         bunch of http timeouts at the beginning of a test run.
681
682         Note that I had to tweak executive_mock to support mocked stderr
683         because the apache_http_server code reads stderr when starting a
684         process to ensure it started okay.
685
686         * Scripts/webkitpy/common/system/executive_mock.py:
687         (MockProcess.__init__):
688         * Scripts/webkitpy/common/system/outputcapture.py:
689         * Scripts/webkitpy/layout_tests/controllers/manager.py:
690         (Manager._run_tests):
691         (Manager.start_servers_with_lock):
692         * Scripts/webkitpy/layout_tests/port/base.py:
693         (Port.to.start_http_server):
694         * Scripts/webkitpy/layout_tests/port/test.py:
695         (TestPort.start_http_server):
696         (TestPort._path_to_apache):
697         (TestPort):
698         (TestPort._path_to_apache_config_file):
699         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
700         (LayoutTestApacheHttpd.__init__):
701         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py: Added
702         (LayoutTestApacheHttpd.__init__):
703         * Scripts/webkitpy/layout_tests/servers/http_server.py:
704         (Lighttpd.__init__):
705         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
706         (HttpServerBase.__init__):
707
708 2012-06-20  Tom Zakrajsek  <tomz@codeaurora.org>
709
710         Unreviewed: Back out accidentally checked in debug print which broke a test
711
712         * Scripts/webkitpy/performance_tests/perftest.py:
713         (PerfTest.parse_output):
714
715 2012-06-20  Tom Zakrajsek  <tomz@codeaurora.org>
716
717         Import themaninblue.com/experiment/AnimationBenchmark/ as performance tests
718         https://bugs.webkit.org/show_bug.cgi?id=78789
719
720         Reviewed by Ryosuke Niwa.
721
722         Updated parser to include fps as a valid unit.
723
724         * Scripts/webkitpy/performance_tests/perftest.py:
725         (PerfTest):
726         (PerfTest.parse_output):
727
728 2012-06-20  Balazs Ankes  <bank@inf.u-szeged.hu>
729
730         webkit-patch should add reviewer if "Reviewed by NOBODY ..." is missing
731         https://bugs.webkit.org/show_bug.cgi?id=67935
732
733         Reviewed by Ryosuke Niwa.
734
735         * Scripts/webkitpy/common/checkout/changelog.py:
736         (ChangeLog.set_reviewer):
737         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
738         (test_set_reviewer):
739         (test_set_short_description_and_bug_url):
740
741 2012-06-20  Simon Hausmann  <simon.hausmann@nokia.com>
742
743         Unreviewed trivial permissions fix.
744
745         * qmake/mkspecs/features/features.prf: Don't mark this file as executable.
746
747 2012-06-19  Ryuan Choi  <ryuan.choi@samsung.com>
748
749         [EFL][Regression] Build break after r120786
750         https://bugs.webkit.org/show_bug.cgi?id=89549
751
752         Unreviewed build fix for Efl port.
753
754         * DumpRenderTree/efl/CMakeLists.txt: Added disassembler in includes.
755
756 2012-06-19  Dirk Pranke  <dpranke@chromium.org>
757
758         NRWT spins up and down the WebSocket server when running a single HTTP test from the command line
759         https://bugs.webkit.org/show_bug.cgi?id=64489
760
761         Reviewed by Tony Chang.
762
763         This change changes NRWT so that we don't start the websocket
764         server if we aren't running websocket tests and don't start the
765         HTTP server if we aren't running http tests.
766         
767         * Scripts/webkitpy/layout_tests/controllers/manager.py:
768         (Manager._websocket_tests):
769         (Manager.start_servers_with_lock):
770         (Manager.stop_servers_with_lock):
771         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
772         (ManagerTest.test_servers_started):
773
774 2012-06-19  Dirk Pranke  <dpranke@chromium.org>
775
776         test-webkitpy: add a -p flag to pass through captured output to enable debugging
777         https://bugs.webkit.org/show_bug.cgi?id=89158
778
779         Reviewed by Eric Seidel.
780
781         Normally when outputcapture runs it intercepts stdout/stderr,
782         which makes running under the debugger difficult and mostly
783         pointless (since you can't see any output). This change adds a
784         flag to test-webkitpy (-p) that will cause outputcapture to pass
785         through the output as well as capture it.
786
787         * Scripts/webkitpy/common/system/outputcapture.py:
788         (OutputCapture.stream_wrapper):
789         (OutputCapture._capture_output_with_name):
790         * Scripts/webkitpy/common/system/outputcapture_unittest.py:
791         (OutputCaptureTest.setUp):
792         * Scripts/webkitpy/test/main.py:
793         (Tester._parse_args):
794         (Tester._run_tests):
795         (Tester._log_exception):
796         (_CaptureAndPassThroughStream):
797         (_CaptureAndPassThroughStream.__init__):
798         (_CaptureAndPassThroughStream.write):
799         (_CaptureAndPassThroughStream._message_is_from_pdb):
800         (_CaptureAndPassThroughStream.flush):
801         (_CaptureAndPassThroughStream.getvalue):
802
803 2012-06-19  Adam Barth  <abarth@webkit.org>
804
805         garden-o-matic fails to rebaseline tests with MISSING results
806         https://bugs.webkit.org/show_bug.cgi?id=89521
807
808         Reviewed by Kenneth Russell.
809
810         If the bots report "MISSING", we should try to find PNG and TXT results on the server.
811
812         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
813
814 2012-06-19  Adam Barth  <abarth@webkit.org>
815
816         svn.delete_list fails to delete empty parent directories
817         https://bugs.webkit.org/show_bug.cgi?id=89520
818
819         Reviewed by Dirk Pranke.
820
821         These functions were calling scm.delete and scm.add, which already
822         delete the parent directory. We'd get an exception when we tried to
823         delete the parent directory again.
824
825         * Scripts/webkitpy/common/checkout/scm/svn.py:
826         (SVN._add_parent_directories):
827         (SVN._delete_parent_directories):
828
829 2012-06-19  Thiago Marcos P. Santos  <thiago.santos@intel.com>
830
831         webkitpy: Simplify fetch_bugs_matching_search()
832         https://bugs.webkit.org/show_bug.cgi?id=89497
833
834         Reviewed by Adam Barth.
835
836         Removed parameter with default value. It's not being used
837         and the handling of the parameter was wrong. Saves a check.
838
839         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
840         (BugzillaQueries.fetch_bugs_matching_search):
841         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
842         (MockBugzillaQueries.fetch_bugs_matching_search):
843
844 2012-06-19  Dirk Pranke  <dpranke@chromium.org>
845
846         webkitpy: remove unneeded imports in layout_tests/port/chromium.py
847         https://bugs.webkit.org/show_bug.cgi?id=89522
848
849         Reviewed by Eric Seidel.
850
851         They were no longer being used. No tests necessary.
852
853         * Scripts/webkitpy/layout_tests/port/chromium.py:
854
855 2012-06-19  Adam Barth  <abarth@webkit.org>
856
857         Missing results aren't shown in garden-o-matic
858
859         Reviewed by Kenneth Russell.
860
861         Previously we didn't know to look for text and image results when the
862         bot told us that results were missing.
863
864         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
865
866 2012-06-19  Dirk Pranke  <dpranke@chromium.org>
867
868         Fix regression introduced in r120646 where the svn revision isn't saved in results.json
869
870         Unreviewed, build fix.
871
872         It turns out that we store the svn revision two different ways
873         in the JSON, and I only caught one of them :(. This should fix
874         the other.
875
876         Also, this part of the code is poorly tested. I will investigate
877         adding at least a basic test for this in a separate fix.
878
879         * Scripts/webkitpy/layout_tests/controllers/manager.py:
880         (summarize_results):
881
882 2012-06-19  Dirk Pranke  <dpranke@chromium.org>
883
884         REGRESSION (NRWT): Results for new non-text-only tests are always put in the most-specific platform directory
885         https://bugs.webkit.org/show_bug.cgi?id=78127
886
887         Reviewed by Ryosuke Niwa.
888
889         Add the --add-platform-exceptions flag from ORWT, and ensure
890         that --new-baseline is equivalent to --reset-results
891         --add-platform-exceptions. Also fix the default logic for where to
892         put PNGs and render tree dumps if --new-test-results is true:
893         if --add-platform-exceptions is False, baselines should go in
894         the least-specific platform directory (e.g., platform/mac)
895         rather than the most-specific (platform/mac-snowleopard).
896
897         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
898         (SingleTestRunner):
899         (SingleTestRunner.run):
900         (SingleTestRunner._run_rebaseline):
901         (SingleTestRunner._add_missing_baselines):
902         (SingleTestRunner._location_for_new_baseline):
903         (SingleTestRunner._overwrite_baselines):
904         (SingleTestRunner._save_baseline_data):
905         * Scripts/webkitpy/layout_tests/port/base.py:
906         (Port.baseline_path):
907         (Port):
908         (Port.baseline_platform_dir):
909         (Port.baseline_version_dir):
910         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
911         (_set_up_derived_options):
912         (parse_args):
913         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
914         (RebaselineTest.assertBaselines):
915         (RebaselineTest.test_reset_results):
916         (RebaselineTest.test_missing_results):
917         (RebaselineTest.test_new_baseline):
918
919 2012-06-19  Dirk Pranke  <dpranke@chromium.org>
920
921         NRWT should not take memory used as disk cache into account when deciding how many processes to launch
922         https://bugs.webkit.org/show_bug.cgi?id=81379
923
924         Reviewed by Eric Seidel.
925
926         The 'free memory' calculation we were running on the mac seemed
927         to underestimate how many children we can run in parallel, and
928         it was complex. This patch replaces that calculation with a
929         simpler one that reserves 2GB for overhead and assumes 256MB per
930         DRT/WTR, so if we had 4GB of RAM we can run up to 8 DRTs.
931
932         Also, there was a bug where we were truncating the memory
933         installed on the machine to 4GB by casting to an int instead of
934         a long; this was probably the source of some of the earlier
935         problems when using total memory.
936
937         This patch also removes the no-longer-needed restrictions on the
938         number of workers on beefy Lion boxes for both Apple Mac and Chromium
939         Mac; we should now use all of the cores by default.
940
941         The memory calculations have only been implemented on the mac;
942         having the calculation in base.default_child_processes() was IMO
943         misleading, and so this patch also moves the computation into
944         the MacPort. I have not heard of the # of workers being an issue
945         on any other ports, so this should be fine.
946
947         * Scripts/webkitpy/common/system/platforminfo.py:
948         (PlatformInfo.total_bytes_memory):
949         * Scripts/webkitpy/common/system/platforminfo_mock.py:
950         (PlatformInfo.total_bytes_memory):
951         (PlatformInfo.total_bytes_memory):
952         (PlatformInfo._win_version_tuple_from_cmd):
953         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
954         (TestPlatformInfo.test_total_bytes_memory):
955         * Scripts/webkitpy/layout_tests/port/base.py:
956         (Port.default_child_processes):
957         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
958         (PortTest.test_default_child_processes):
959         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
960         (ChromiumMacPort.operating_system):
961         * Scripts/webkitpy/layout_tests/port/mac.py:
962         (MacPort.default_child_processes):
963         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
964         (TestMacPort.test_default_child_processes):
965
966 2012-06-19  Dirk Pranke  <dpranke@chromium.org>
967
968         new-run-webkit-tests reports unexpected pass of pixel tests when pixel testing is disabled
969         https://bugs.webkit.org/show_bug.cgi?id=85446
970
971         Reviewed by Simon Fraser.
972
973         Embed whether pixel testing was enabled into the results.json.
974
975         * Scripts/webkitpy/layout_tests/controllers/manager.py:
976         (summarize_results):
977
978 2012-06-19  Zoltan Horvath  <zoltan@webkit.org>
979
980         [Qt] Modify HTTPS port to 8443 for performance tests
981         https://bugs.webkit.org/show_bug.cgi?id=89442
982
983         Reviewed by Ryosuke Niwa.
984
985         We should be consistent with the default HTTPS port and with the changelog of r119188.
986
987         * Scripts/webkitpy/performance_tests/perftest.py:
988         (ReplayServer.__init__):
989
990 2012-06-19  Mike West  <mkwst@chromium.org>
991
992         Introduce ENABLE_CSP_NEXT configuration flag.
993         https://bugs.webkit.org/show_bug.cgi?id=89300
994
995         Reviewed by Adam Barth.
996
997         The 1.0 draft of the Content Security Policy spec is just about to
998         move to Last Call. We'll hide work on the upcoming 1.1 spec behind
999         this ENABLE flag, disabled by default.
1000
1001         Spec: https://dvcs.w3.org/hg/content-security-policy/raw-file/tip/csp-specification.dev.html
1002
1003         * Scripts/webkitperl/FeatureList.pm:
1004         * qmake/mkspecs/features/features.pri:
1005
1006 2012-06-19  Christophe Dumez  <christophe.dumez@intel.com>
1007
1008         [EFL] EFL's LayoutTestController does not support setTextDirection
1009         https://bugs.webkit.org/show_bug.cgi?id=87481
1010
1011         Reviewed by Hajime Morita.
1012
1013         Implement setTextDirection in EFL's LayoutTestController and
1014         properly reset its value between test cases to avoid flakiness.
1015
1016         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1017         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1018         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1019         (LayoutTestController::setTextDirection):
1020
1021 2012-06-19  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
1022
1023         [Qt] Temporarily disable xvfb driver in nrwt
1024         https://bugs.webkit.org/show_bug.cgi?id=88414
1025
1026         Reviewed by Csaba Osztrogonác.
1027
1028         * Scripts/webkitpy/layout_tests/port/qt.py:
1029         (QtPort._build_driver):
1030
1031 2012-06-18  Joone Hur  <joone.hur@intel.com>
1032
1033         [EFL] Fontconfig can't be linked properly
1034         https://bugs.webkit.org/show_bug.cgi?id=89418
1035
1036         Unreviewed build fix.
1037
1038         Make Fontconfig be linked correctly.
1039
1040         * MiniBrowser/efl/CMakeLists.txt: add FONTCONFIG_LIBRARIES to MiniBrowser_LIBRARIES.
1041
1042 2012-06-18  Joone Hur  <joone.hur@intel.com>
1043
1044         Unreviewed. Updating email for committers.py script.
1045
1046         * Scripts/webkitpy/common/config/committers.py:
1047
1048 2012-06-18  Simon Fraser  <simon.fraser@apple.com>
1049
1050         Fix a typo that caused TestFailures to have a syntax error.
1051         
1052         Sadly TestFailures is broken for another reason now too:
1053         https://bugs.webkit.org/show_bug.cgi?id=89419
1054
1055         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js:
1056         (ViewController.prototype._domForBuildName):
1057
1058 2012-06-18  Simon Fraser  <simon.fraser@apple.com>
1059
1060         Provide bug links for suspicious commits
1061         https://bugs.webkit.org/show_bug.cgi?id=89408
1062         
1063         Reviewed by Adam Barth.
1064
1065         Add links to bugs for the suspicious commits if we have bug data.
1066
1067         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Bugzilla.js:
1068         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
1069         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
1070         (ol.notifications>li ul.causes>li>div.description>span>span.bugID::before):
1071         (ol.notifications>li ul.causes>li>div.description>span>span.bugID>a):
1072
1073 2012-06-18  Amy Ousterhout  <aousterh@chromium.org>
1074
1075         [Chromium] DeviceOrientation Cleanup
1076         https://bugs.webkit.org/show_bug.cgi?id=89354
1077
1078         Reviewed by Kent Tamura.
1079
1080         * DumpRenderTree/chromium/WebViewHost.h: added OVERRIDE specifier for virtual function
1081         (WebViewHost):
1082
1083 2012-06-18  James Robinson  <jamesr@chromium.org>
1084
1085         [chromium] Stop passing deprecated 'direct' parameter to webkit_support::CreateGraphicsContext3D
1086         https://bugs.webkit.org/show_bug.cgi?id=89254
1087
1088         Reviewed by Adrienne Walker.
1089
1090         This parameter doesn't mean anything since this codepath is only used for onscreen contexts and is deprecated
1091         upstream.
1092
1093         * DumpRenderTree/chromium/WebViewHost.cpp:
1094         (WebViewHost::createGraphicsContext3D):
1095
1096 2012-06-18  Simon Fraser  <simon.fraser@apple.com>
1097
1098         Minor fix suggested by Adam Barth.
1099
1100         Use $(this._what).empty(); rather than removing children one at a time.
1101         For some reason removeAllChildren() is undefined on this node.
1102         
1103         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
1104
1105 2012-06-18  Simon Fraser  <simon.fraser@apple.com>
1106
1107         Show TOT revision in garden-o-matic, and make the revisions into links
1108         https://bugs.webkit.org/show_bug.cgi?id=89396
1109
1110         Reviewed by Adam Barth.
1111
1112         The "latest revision" notification now reads "Latest revision processed by every bot: NN (trunk is at NN)"
1113         where the revisions are links to trac.
1114         
1115         To avoid setting innerHTML, I made base.createLinkNode() and used it in a bunch of places, which had
1116         the knock-on effect of flipping the target and href attributes for anchors in some test output.
1117
1118         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js:
1119         (ViewController.prototype._displayTesters.updateList.list):
1120         (ViewController.prototype._displayTesters.updateList):
1121         (ViewController.prototype._domForRegressionRange.trac.commitDataForRevisionRange):
1122         (ViewController.prototype._domForRegressionRange):
1123         (ViewController.prototype._domForAuxiliaryUIElements):
1124         (ViewController.prototype._domForBuildName):
1125         (ViewController.prototype):
1126         (ViewController.prototype.):
1127         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
1128         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
1129         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
1130         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
1131         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
1132
1133 2012-06-18  Csaba Osztrogonác  <ossy@webkit.org>
1134
1135         REGRESSION(r100558): NRWT should work without SVN or GIT
1136         https://bugs.webkit.org/show_bug.cgi?id=76630
1137
1138         Reviewed by Dirk Pranke.
1139
1140         NRWT is not supposed to have a requirement that we have an
1141         actual SVN or Git checkout, and we were unnecessarily
1142         initializing the checkout. This patch removes that line :).
1143
1144         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1145         (main):
1146
1147 2012-06-18  Zan Dobersek  <zandobersek@gmail.com>
1148
1149         [garden-o-matic] Add support for the GTK builders
1150         https://bugs.webkit.org/show_bug.cgi?id=89360
1151
1152         Reviewed by Adam Barth.
1153
1154         Add the 'gtk' platform, essentially a copy of the 'apple' platform since
1155         both get their data from build.webkit.org.
1156
1157         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1158         (.):
1159
1160 2012-06-18  Nico Weber  <thakis@chromium.org>
1161
1162         [chromium/mac] Unbreak smooth scrolling.
1163         https://bugs.webkit.org/show_bug.cgi?id=89327
1164
1165         Reviewed by Dimitri Glazkov.
1166
1167         Broken by Sam in r115589 / r115591.
1168
1169         * DumpRenderTree/mac/DumpRenderTree.mm:
1170         (resetDefaultsToConsistentValues):
1171         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
1172         (TestWebKitAPI::InjectedBundleController::platformInitialize):
1173         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1174         (WTR::InjectedBundle::platformInitialize):
1175
1176 2012-06-18  Sheriff Bot  <webkit.review.bot@gmail.com>
1177
1178         Unreviewed, rolling out r120541, r120547, and r120548.
1179         http://trac.webkit.org/changeset/120541
1180         http://trac.webkit.org/changeset/120547
1181         http://trac.webkit.org/changeset/120548
1182         https://bugs.webkit.org/show_bug.cgi?id=89383
1183
1184         This approach doesn't work for WebKit2 (Requested by abarth on
1185         #webkit).
1186
1187         * DumpRenderTree/LayoutTestController.cpp:
1188         (setBackingScaleFactorCallback):
1189         (LayoutTestController::staticFunctions):
1190         * DumpRenderTree/LayoutTestController.h:
1191         (LayoutTestController):
1192         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
1193         (LayoutTestController::setBackingScaleFactor):
1194         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1195         (LayoutTestController::setBackingScaleFactor):
1196         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1197         (LayoutTestController::setBackingScaleFactor):
1198         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1199         (LayoutTestController::setBackingScaleFactor):
1200         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1201         (LayoutTestController::setBackingScaleFactor):
1202         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1203         (LayoutTestController::setBackingScaleFactor):
1204         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1205         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1206         (WTR::InjectedBundle::didReceiveMessage):
1207         (WTR::InjectedBundle::postSetBackingScaleFactor):
1208         (WTR):
1209         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1210         (InjectedBundle):
1211         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1212         (WTR::LayoutTestController::setBackingScaleFactor):
1213         (WTR):
1214         (WTR::LayoutTestController::callSetBackingScaleFactorCallback):
1215         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1216         (LayoutTestController):
1217         * WebKitTestRunner/TestInvocation.cpp:
1218         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1219
1220 2012-06-18  Zan Dobersek  <zandobersek@gmail.com>
1221
1222         REGRESSION(r120546): It made 3 webkitpy tests fail
1223         https://bugs.webkit.org/show_bug.cgi?id=89332
1224
1225         Reviewed by Adam Barth.
1226
1227         Update the BaselineOptimizer unittest after r120546.
1228
1229         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
1230         (BaselineOptimizerTest.test_no_add_mac_future):
1231         (BaselineOptimizerTest.test_mac_future):
1232         (BaselineOptimizerTest.test_complex_shadowing):
1233
1234 2012-06-18  Dirk Pranke  <dpranke@chromium.org>
1235
1236         new-run-webkit-tests output gets confused when logging
1237         https://bugs.webkit.org/show_bug.cgi?id=63793
1238
1239         Reviewed by Adam Barth.
1240
1241         Ship all of the log messages generated in the worker back
1242         to the manager; this allows the messages to be properly
1243         serialized to stderr and for the meter to flush its output correctly.
1244
1245         Note however that this will likely result in messages to be
1246         logged out of order between workers; I'm not sure that there's
1247         an easy way to fix this short of buffering a potentially
1248         unbounded amount of data. It might be better to just log through
1249         stderr unless we're in 'metering' mode, but it's also worth
1250         noting that we already get messages out of order through stderr
1251         on Windows.
1252
1253         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1254         (Manager.handle_done):
1255         (Manager.handle_finished_test):
1256         (Manager._log_messages):
1257         * Scripts/webkitpy/layout_tests/controllers/worker.py:
1258         (Worker.__init__):
1259         (Worker._set_up_logging):
1260         (Worker.run):
1261         (Worker._run_test):
1262         (Worker.cleanup):
1263         (Worker.run_single_test):
1264         (_WorkerLogHandler):
1265         (_WorkerLogHandler.__init__):
1266         (_WorkerLogHandler.emit):
1267         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
1268         (MeteredStream.write):
1269         (MeteredStream.writeln):
1270         * Scripts/webkitpy/layout_tests/views/printing.py:
1271         (Printer.writeln):
1272
1273 2012-06-18  Zan Dobersek  <zandobersek@gmail.com>
1274
1275         [garden-o-matic] Builder names without underscores cause incorrect BuildSelector behavior
1276         https://bugs.webkit.org/show_bug.cgi?id=89362
1277
1278         Reviewed by Simon Fraser.
1279
1280         Replace white spaces, braces and dots in the builder name with underscores. This
1281         way the JQuery tabs will be properly matched with the according container.
1282
1283         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1284
1285 2012-06-18  Dirk Pranke  <dpranke@chromium.org>
1286
1287         nrwt: metered output doesn't handle ^C cleanly
1288         https://bugs.webkit.org/show_bug.cgi?id=89249
1289
1290         Reviewed by Tony Chang.
1291
1292         If you ctrl-c a running nrwt (w/o --verbose), then all but
1293         two characters of the last update are erased, and then we print
1294         "interrupted, exiting" as an update, which itself then gets
1295         erased. Fix this so that we flush the meter (making the last
1296         update persistent, so that we print the ^C for a visual clue),
1297         print the interrupt message, and move on ...
1298
1299         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1300         (Manager._run_tests):
1301         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
1302         (MeteredStream.flush):
1303         * Scripts/webkitpy/layout_tests/views/printing.py:
1304         (Printer._write):
1305         (Printer):
1306         (Printer.flush):
1307
1308 2012-06-18  Xianzhu Wang  <wangxianzhu@chromium.org>
1309
1310         [Chromium] Change back "linuxish" to "linux" and include WebFontRendering.cpp on Android
1311         https://bugs.webkit.org/show_bug.cgi?id=89228
1312
1313         Reviewed by Tony Chang.
1314
1315         * DumpRenderTree/chromium/LayoutTestController.cpp:
1316         * DumpRenderTree/chromium/TestShellAndroid.cpp:
1317
1318 2012-06-18  Mario Sanchez Prada  <msanchez@igalia.com>
1319
1320         [GTK] Get rid of DumpRenderTreeSupportGtk::{in|de}crementAccessibilityValue
1321         https://bugs.webkit.org/show_bug.cgi?id=89226
1322
1323         Reviewed by Martin Robinson.
1324
1325         Implement increment() and decrement() functions in term of the AtkValue interface,
1326         instead of using DumpRenderTreeSupportGtk helper class.
1327
1328         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1329         (AccessibilityUIElement::intValue):
1330         (AccessibilityUIElement::minValue):
1331         (AccessibilityUIElement::maxValue):
1332         (alterCurrentValue):
1333         (AccessibilityUIElement::increment):
1334         (AccessibilityUIElement::decrement):
1335
1336 2012-06-17  Simon Fraser  <simon.fraser@apple.com>
1337
1338         garden-o-matic 'Results' panel is broken for the Apple platform
1339         https://bugs.webkit.org/show_bug.cgi?id=89310
1340
1341         Reviewed by Adam Barth.
1342         
1343         For platforms that don't use accumulated build directories on the server,
1344         carry along buildLocation data with buildInfo, so that we know where to
1345         look for the test results files for a given test.
1346         
1347         Renamed historicalResultsSummaryURLs to historicalResultsLocations because
1348         it now returns an array of objects with buildNumber, revision and url info.
1349         
1350         Fixed results.fetchResultsURLs() to use this data to find results.
1351         
1352         Fixed the results display to not scroll when you click on a test to see the results.
1353         Made the h3s look less ugly
1354         
1355         Don't try to show the flakiness dashboard for the Apple platform.
1356
1357         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
1358         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1359         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
1360         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1361         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1362         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
1363         (.results-view .top-panel):
1364         (.results-view h3):
1365
1366 2012-06-16  Simon Fraser  <simon.fraser@apple.com>
1367
1368         Make garden-o-matic work for the Apple Mac port
1369         https://bugs.webkit.org/show_bug.cgi?id=84642
1370
1371         Reviewed by Adam Barth.
1372         
1373         Make garden-o-matic work for the Apple, webkit.org-hosted builders and testers. This involved
1374         educating the scripts in various ways:
1375         * Wrap up platform-related differences in config.kPlatforms[]
1376         * Add a <select> to switch between platforms, and support a url parameter, ?platform=chromium/apple
1377         * The webkit.org bots don't accumulate test results into a single directory like the chromium.org ones do,
1378           so add config.haveBuilderAccumulatedResults and logic in fetchResultsByBuilder() to find the most
1379           recent build with valid results.
1380         * The webkit.org bots often generate results directories with no layout test data (e.g. when testers
1381           try to test a build that has already been deleted). Make walkHistory() more robust here.
1382         * webkit.org uses differently named test result directories, that include the SVN revision as
1383           well as the build number. That forces us to fetch more build info before we can get the
1384           result directory URL.
1385         * chromium.org serves raw directory listings for a builder's results directories. webkit.org serves
1386           those with Twisted, so rather than scrape directory listings, we use buildbot JSON to find results
1387           dirs.
1388         * Various URLs differ between webkit.org and chromium.org
1389         * Better UI for the failures info, so that some info is visible even when not hovered.
1390
1391         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1392         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/LayoutTestResultsLoader.js:
1393         (LayoutTestResultsLoader.prototype.set _fetchAndParseNRWTResults):
1394         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
1395         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1396         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
1397         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js:
1398         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
1399         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
1400         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js:
1401         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1402         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
1403         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
1404         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/perf.js:
1405         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
1406         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
1407         (ol.notifications>li table.failures):
1408         (ol.notifications>li:hover table.failures):
1409         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
1410         (#onebar #platform-picker):
1411         * Scripts/webkitpy/layout_tests/port/builders.py:
1412
1413 2012-06-16  Sheriff Bot  <webkit.review.bot@gmail.com>
1414
1415         Unreviewed, rolling out r120536.
1416         http://trac.webkit.org/changeset/120536
1417         https://bugs.webkit.org/show_bug.cgi?id=89296
1418
1419         Does not compile on chromium-linux (Requested by abarth on
1420         #webkit).
1421
1422         * DumpRenderTree/chromium/LayoutTestController.cpp:
1423         (LayoutTestController::reset):
1424         (LayoutTestController::setTextSubpixelPositioning):
1425         * DumpRenderTree/chromium/TestShellAndroid.cpp:
1426
1427 2012-06-16  Adam Barth  <abarth@webkit.org>
1428
1429         layoutTestController.setBackingScaleFactor is redundant with (and less awesome than) internals.settings.setDeviceScaleFactor
1430         https://bugs.webkit.org/show_bug.cgi?id=89274
1431
1432         Reviewed by Levi Weintraub.
1433
1434         Delete (mostly stub) implementations of layoutTestController.setBackingScaleFactor.
1435         Note: The WebKit2 API that setBackingScaleFactor exercises is still
1436         tested by API-level tests.
1437
1438         * DumpRenderTree/LayoutTestController.cpp:
1439         (LayoutTestController::staticFunctions):
1440         * DumpRenderTree/LayoutTestController.h:
1441         (LayoutTestController):
1442         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
1443         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1444         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1445         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1446         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1447         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1448         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1449         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1450         (WTR::InjectedBundle::didReceiveMessage):
1451         (WTR):
1452         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1453         (InjectedBundle):
1454         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1455         (WTR):
1456         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1457         (LayoutTestController):
1458         * WebKitTestRunner/TestInvocation.cpp:
1459         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1460
1461 2012-06-16  Xianzhu Wang  <wangxianzhu@chromium.org>
1462
1463         [Chromium] Move chromium/public/linuxish/WebFontRendering.h out of linuxish directory
1464         https://bugs.webkit.org/show_bug.cgi?id=89228
1465
1466         Reviewed by Tony Chang.
1467
1468         * DumpRenderTree/chromium/LayoutTestController.cpp:
1469         (LayoutTestController::reset):
1470         (LayoutTestController::setTextSubpixelPositioning):
1471         * DumpRenderTree/chromium/TestShellAndroid.cpp:
1472
1473 2012-06-15  Adam Barth  <abarth@webkit.org>
1474
1475         garden-o-matic's results.js should use RequestTracker
1476         https://bugs.webkit.org/show_bug.cgi?id=89257
1477
1478         Reviewed by Dimitri Glazkov.
1479
1480         We wrote results.js before we recognized the RequestTracker pattern.
1481         This patch replaces the manual implementations of RequestTracker with
1482         the real deal.
1483
1484         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
1485
1486 2012-06-15  Darin Adler  <darin@apple.com>
1487
1488         * Scripts/webkitpy/bindings: Added property svn:ignore.
1489
1490 2012-06-15  Sheriff Bot  <webkit.review.bot@gmail.com>
1491
1492         Unreviewed, rolling out r120511.
1493         http://trac.webkit.org/changeset/120511
1494         https://bugs.webkit.org/show_bug.cgi?id=89255
1495
1496         Breaks at least Android builder (Requested by wangxianzhu on
1497         #webkit).
1498
1499         * DumpRenderTree/chromium/LayoutTestController.cpp:
1500         (LayoutTestController::reset):
1501         (LayoutTestController::setTextSubpixelPositioning):
1502
1503 2012-06-15  Xianzhu Wang  <wangxianzhu@chromium.org>
1504
1505         [Chromium] Move chromium/public/linuxish/WebFontRendering.h out of linuxish directory
1506         https://bugs.webkit.org/show_bug.cgi?id=89228
1507
1508         Reviewed by Tony Chang.
1509
1510         * DumpRenderTree/chromium/LayoutTestController.cpp:
1511         (LayoutTestController::reset):
1512         (LayoutTestController::setTextSubpixelPositioning):
1513
1514 2012-06-15  Dirk Pranke  <dpranke@chromium.org>
1515
1516         webkitpy: remove DummyOptions and clean up the code in Port.get_option() and Port.set_option_default()
1517         https://bugs.webkit.org/show_bug.cgi?id=89135
1518
1519         Re-land change in r120370 with fix in
1520         PortFactory.get_from_builder_name() that changes BuilderOptions
1521         to an actual optparse.Values object.
1522
1523         * Scripts/webkitpy/layout_tests/port/base.py:
1524         (Port.__init__):
1525         (Port.get_option):
1526         (Port.set_option_default):
1527         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1528         (ChromiumWinTest.test_setup_environ_for_server_register_cygwin):
1529         * Scripts/webkitpy/layout_tests/port/factory.py:
1530         (_builder_options):
1531         (PortFactory.get_from_builder_name):
1532         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1533         (FactoryTest.test_get_from_builder_name):
1534         * Scripts/webkitpy/style/checkers/test_expectations.py:
1535         (TestExpectationsChecker._determine_port_from_expectations_path):
1536         * Scripts/webkitpy/tool/mocktool.py:
1537         (MockOptions.ensure_value):
1538
1539 2012-06-15  Bill Budge  <bbudge@chromium.org>
1540
1541         Add bbudge@chromium.org to committers.py
1542
1543         Unreviewed.
1544
1545         * Scripts/webkitpy/common/config/committers.py:
1546
1547 2012-06-15  Csaba Osztrogonác  <ossy@webkit.org>
1548
1549         Unreviewed style fix after r120351.
1550
1551         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
1552         (body.interface):
1553
1554 2012-06-15  Csaba Osztrogonác  <ossy@webkit.org>
1555
1556         master.cfg cleanup, remove unnecessary workaround
1557         https://bugs.webkit.org/show_bug.cgi?id=88994
1558
1559         Reviewed by Lucas Forschler.
1560
1561         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1562         (loadBuilderConfig):
1563
1564 2012-06-15  Dirk Pranke  <dpranke@chromium.org>
1565
1566         webkit-patch rebaseline-expectations should only rebaseline the appropriate suffixes for the failure in question
1567         https://bugs.webkit.org/show_bug.cgi?id=88581
1568
1569         Reviewed by Adam Barth.
1570
1571         Make sure we only optimize the suffixes we rebaselined during
1572         rebaseline-expectations, and not all suffixes for a test.
1573         While optimizing is somewhere between harmless and good, it's also confusing :)
1574
1575         * Scripts/webkitpy/tool/commands/rebaseline.py:
1576         (RebaselineExpectations._rebaseline_port):
1577         (RebaselineExpectations.execute):
1578         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1579
1580 2012-06-15  Csaba Osztrogonác  <ossy@webkit.org>
1581
1582         Update builder.html template for newer buildmaster
1583         https://bugs.webkit.org/show_bug.cgi?id=89207
1584
1585         Rebasing builder.html template from v0.8.3 to v0.8.6p1.
1586
1587         Reviewed by Zoltan Herczeg.
1588
1589         * BuildSlaveSupport/build.webkit.org-config/templates/builder.html:
1590
1591 2012-06-15  Csaba Osztrogonác  <ossy@webkit.org>
1592
1593         Add ForceScheduler to build.webkit.org
1594         https://bugs.webkit.org/show_bug.cgi?id=88982
1595
1596         Reviewed by Ryosuke Niwa.
1597
1598         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1599         (loadBuilderConfig):
1600
1601 2012-06-15  Christophe Dumez  <christophe.dumez@intel.com>
1602
1603         [EFL][WK2] Add title support to Ewk_View
1604         https://bugs.webkit.org/show_bug.cgi?id=89095
1605
1606         Reviewed by Kenneth Rohde Christiansen.
1607
1608         Update the MiniBrowser so it listens for the "title,change"
1609         signal on the view and keeps the browser window title
1610         up-to-date.
1611
1612         * MiniBrowser/efl/main.c:
1613         (on_title_changed):
1614         (browserCreate):
1615
1616 2012-06-15  Christophe Dumez  <christophe.dumez@intel.com>
1617
1618         [WK2][EFL] Implement navigation back/forward in Ewk_View
1619         https://bugs.webkit.org/show_bug.cgi?id=89173
1620
1621         Reviewed by Kenneth Rohde Christiansen.
1622
1623         Implement navigation back / forward in MiniBrowser. Use
1624         'F1' to navigate back and 'F2' to navigate forward.
1625
1626         * MiniBrowser/efl/main.c:
1627         (on_key_down):
1628
1629 2012-06-15  Christophe Dumez  <christophe.dumez@intel.com>
1630
1631         [EFL] EFL's LayoutTestController does not support titleTextDirection
1632         https://bugs.webkit.org/show_bug.cgi?id=86475
1633
1634         Reviewed by Hajime Morita.
1635
1636         Add titleTextDirection getter and setter to LayoutTestController and
1637         expose its value to JavaScript.
1638         Update the titleTextDirection value from EFL's "title,changed"
1639         callback in DumpRenderTree.
1640
1641         * DumpRenderTree/LayoutTestController.cpp:
1642         (LayoutTestController::LayoutTestController):
1643         (getTitleTextDirectionCallback):
1644         (LayoutTestController::staticValues):
1645         * DumpRenderTree/LayoutTestController.h:
1646         (LayoutTestController::titleTextDirection):
1647         (LayoutTestController::setTitleTextDirection):
1648         (LayoutTestController):
1649         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1650         (DumpRenderTreeChrome::onFrameTitleChanged):
1651
1652 2012-06-15  Christophe Dumez  <christophe.dumez@intel.com>
1653
1654         [EFL][WK2] Implement reload / stop in Ewk_View
1655         https://bugs.webkit.org/show_bug.cgi?id=89168
1656
1657         Reviewed by Kenneth Rohde Christiansen.
1658
1659         Implement view reload / stop loading in MiniBrowser.
1660         Use 'F5' for reload and 'F6' for stopping the load.
1661
1662         * MiniBrowser/efl/main.c:
1663         (on_key_down):
1664         (browserCreate):
1665
1666 2012-06-15  Hironori Bono  <hbono@chromium.org>
1667
1668         Allow platforms to choose whether to remove markers on editing
1669         https://bugs.webkit.org/show_bug.cgi?id=88838
1670
1671         Reviewed by Hajime Morita.
1672
1673         This change implements WebViewHost::checkTextOfParagraph so DumpRenderTree can
1674         run grammar tests.
1675
1676         * DumpRenderTree/chromium/WebViewHost.cpp:
1677         (WebViewHost::checkTextOfParagraph): Implement this function with our mock spell checker and grammar checker.
1678         * DumpRenderTree/chromium/WebViewHost.h:
1679         (WebViewHost): Override WebSpellCheckClient::checkTextOfParagraph.
1680
1681 2012-06-15  Sheriff Bot  <webkit.review.bot@gmail.com>
1682
1683         Unreviewed, rolling out r120370.
1684         http://trac.webkit.org/changeset/120370
1685         https://bugs.webkit.org/show_bug.cgi?id=89183
1686
1687         Broke webkit-patch rebaseline (Requested by zdobersek on
1688         #webkit).
1689
1690         * Scripts/webkitpy/layout_tests/port/base.py:
1691         (DummyOptions):
1692         (DummyOptions.__init__):
1693         (DummyOptions.__init__.this):
1694         (Port.__init__):
1695         (Port.get_option):
1696         (Port.set_option_default):
1697         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1698         (ChromiumWinTest.RegisterCygwinOption):
1699         (ChromiumWinTest.RegisterCygwinOption.__init__):
1700         (ChromiumWinTest.test_setup_environ_for_server_register_cygwin):
1701         * Scripts/webkitpy/style/checkers/test_expectations.py:
1702         (TestExpectationsChecker._determine_port_from_expectations_path):
1703         * Scripts/webkitpy/tool/mocktool.py:
1704         (MockOptions.update):
1705
1706 2012-06-14  Xianzhu Wang  <wangxianzhu@chromium.org>
1707
1708         [Chromium-Android] Initialize font rendering in DumpRenderTree
1709         https://bugs.webkit.org/show_bug.cgi?id=89133
1710
1711         Reviewed by Adam Barth.
1712
1713         * DumpRenderTree/chromium/LayoutTestController.cpp:
1714         (LayoutTestController::reset):
1715         (LayoutTestController::setTextSubpixelPositioning):
1716         * DumpRenderTree/chromium/TestShellAndroid.cpp:
1717         (platformInit):
1718
1719 2012-06-14  Dongwoo Im  <dw.im@samsung.com>
1720
1721         [EFL] [DRT] Reset the WebAudio setting on DumpRenderTree
1722         https://bugs.webkit.org/show_bug.cgi?id=88622
1723
1724         Reviewed by Philippe Normand.
1725
1726         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp: Reset the setting of the Web Audio feature as default.
1727         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1728
1729 2012-06-14  Xianzhu Wang  <wangxianzhu@chromium.org>
1730
1731         [Chromium-Android] Should retry a few times when failed to start DumpRenderTree
1732         https://bugs.webkit.org/show_bug.cgi?id=89124
1733
1734         Reviewed by Dirk Pranke.
1735
1736         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1737         (ChromiumAndroidDriver._start):
1738         (ChromiumAndroidDriver):
1739         (ChromiumAndroidDriver._start_once):
1740
1741 2012-06-14  Tony Gentilcore  <tonyg@chromium.org>
1742
1743         Update webpagereplay to 1.1.2
1744         https://bugs.webkit.org/show_bug.cgi?id=89118
1745
1746         This includes the following patch which avoids pkg_resources import errors:
1747         http://code.google.com/p/web-page-replay/source/detail?r=476
1748
1749         Reviewed by Dirk Pranke.
1750
1751         * Scripts/webkitpy/thirdparty/__init__.py:
1752         (AutoinstallImportHook._install_webpagereplay):
1753
1754 2012-06-14  Ryosuke Niwa  <rniwa@webkit.org>
1755
1756         Get rid of FAIL test expectation
1757         https://bugs.webkit.org/show_bug.cgi?id=89137
1758
1759         Reviewed by Dirk Pranke.
1760
1761         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1762         (ResultSummaryTest.test_summarized_results_wontfix):
1763         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
1764         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1765         (JSONLayoutResultsGenerator):
1766         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1767         (result_was_expected):
1768         (suffixes_for_expectations):
1769         (TestExpectationsModel._add_test):
1770         (TestExpectations):
1771         (TestExpectations.get_rebaselining_failures):
1772         (TestExpectations.remove_configuration_from_test):
1773         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1774         (FunctionsTest.test_result_was_expected):
1775         (FunctionsTest.test_suffixes_for_expectations):
1776         (TestExpectationSerializerTests.test_parsed_expectations_string):
1777         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1778         (test_test_expectations):
1779         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1780         (TestExpectationsTestCase.test_valid_expectations):
1781
1782 2012-06-14  Dirk Pranke  <dpranke@chromium.org>
1783
1784         webkitpy: remove DummyOptions and clean up the code in Port.get_option() and Port.set_option_default()
1785         https://bugs.webkit.org/show_bug.cgi?id=89135
1786
1787         Reviewed by Ryosuke Niwa.
1788
1789         This patch is just some minor cleanup and simplification. There
1790         should be no functional changes here.
1791
1792         * Scripts/webkitpy/layout_tests/port/base.py:
1793         (Port.__init__):
1794         (Port.get_option):
1795         (Port.set_option_default):
1796         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1797         (ChromiumWinTest.test_setup_environ_for_server_register_cygwin):
1798         * Scripts/webkitpy/style/checkers/test_expectations.py:
1799         (TestExpectationsChecker._determine_port_from_expectations_path):
1800         * Scripts/webkitpy/tool/mocktool.py:
1801         (MockOptions.ensure_value):
1802
1803 2012-06-14  Ian Vollick  <vollick@chromium.org>
1804
1805         [chromium] Certain settings in CCSettings could be global
1806         https://bugs.webkit.org/show_bug.cgi?id=88384
1807
1808         Reviewed by James Robinson.
1809
1810         * DumpRenderTree/chromium/TestShell.cpp:
1811         (TestShell::TestShell):
1812         (TestShell::resetWebSettings):
1813         (TestShell::setPerTilePaintingEnabled):
1814         * DumpRenderTree/chromium/TestShell.h:
1815         (TestShell):
1816         * DumpRenderTree/chromium/WebPreferences.cpp:
1817         (WebPreferences::reset):
1818         (WebPreferences::applyTo):
1819         * DumpRenderTree/chromium/WebPreferences.h:
1820         (WebPreferences):
1821
1822 2012-06-14  Sheriff Bot  <webkit.review.bot@gmail.com>
1823
1824         Unreviewed, rolling out r120352.
1825         http://trac.webkit.org/changeset/120352
1826         https://bugs.webkit.org/show_bug.cgi?id=89120
1827
1828         It seems something is still wrong with it :/ (Requested by
1829         Ossy on #webkit).
1830
1831         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1832         (Factory.__init__):
1833         (BuildFactory.__init__):
1834         (TestFactory.__init__):
1835         (BuildAndTestFactory.__init__):
1836         (BuildAndPerfTestFactory.__init__):
1837         (BuildAndPerfTestWebKit2Factory.__init__):
1838         (DownloadAndPerfTestFactory.__init__):
1839         (DownloadAndPerfTestWebKit2Factory.__init__):
1840
1841 2012-06-14  Jia Pu  <jpu@apple.com>
1842
1843         Mark text with text alternative with blue underline.
1844         https://bugs.webkit.org/show_bug.cgi?id=83047
1845
1846         Reviewed by NOBODY Enrica Casucci.
1847
1848         * DumpRenderTree/mac/TextInputController.m:
1849         (+[TextInputController isSelectorExcludedFromWebScript:]):
1850         (+[TextInputController webScriptNameForSelector:]):
1851         (-[TextInputController dictatedStringWithPrimaryString:alternative:alternativeOffset:alternativeLength:]):
1852
1853 2012-06-14  Sheriff Bot  <webkit.review.bot@gmail.com>
1854
1855         Unreviewed, rolling out r120353.
1856         http://trac.webkit.org/changeset/120353
1857         https://bugs.webkit.org/show_bug.cgi?id=89119
1858
1859         It seems we still need this workaround (Requested by Ossy on
1860         #webkit).
1861
1862         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1863         (loadBuilderConfig):
1864
1865 2012-06-14  Csaba Osztrogonác  <ossy@webkit.org>
1866
1867         master.cfg cleanup, remove unnecessary workaround
1868         https://bugs.webkit.org/show_bug.cgi?id=88994
1869
1870         Reviewed by Lucas Forschler.
1871
1872         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1873         (loadBuilderConfig):
1874
1875 2012-06-14  Csaba Osztrogonác  <ossy@webkit.org>
1876
1877         master.cfg cleanup, pass BuildStep instances instead of BuildStep subclasses
1878         https://bugs.webkit.org/show_bug.cgi?id=89001
1879
1880         Reviewed by Lucas Forschler.
1881
1882         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1883         (Factory.__init__):
1884         (BuildFactory.__init__):
1885         (TestFactory.__init__):
1886         (BuildAndTestFactory.__init__):
1887         (BuildAndPerfTestFactory.__init__):
1888         (BuildAndPerfTestWebKit2Factory.__init__):
1889         (DownloadAndPerfTestFactory.__init__):
1890         (DownloadAndPerfTestWebKit2Factory.__init__):
1891
1892 2012-06-14  Csaba Osztrogonác  <ossy@webkit.org>
1893
1894         Unhide login form on the build.webkit.org
1895         https://bugs.webkit.org/show_bug.cgi?id=88981
1896
1897         Reviewed by Lucas Forschler.
1898
1899         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
1900
1901 2012-06-14  Zan Dobersek  <zandobersek@gmail.com>
1902
1903         [Gtk] Add support in DumpRenderTree for tracking repaints
1904         https://bugs.webkit.org/show_bug.cgi?id=87658
1905
1906         Reviewed by Martin Robinson.
1907
1908         Reimplement the displayWebView method in DumpRenderTree - force a
1909         repaint before starting tracking repaints and resetting them.
1910
1911         When gathering pixel output from a web view, if tracking repaints,
1912         paint an overlay over the output with the overlay being clear in the
1913         areas where the repaints occurred.
1914
1915         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1916         (displayWebView):
1917         (resetDefaultsToConsistentValues):
1918         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
1919         (paintOverlay):
1920         (fillRepaintOverlayIntoContext):
1921         (createBitmapContextFromWebView):
1922
1923 2012-06-14  Dirk Pranke  <dpranke@chromium.org>
1924
1925         new-run-webkit-tests doesn't find similar platform tests for a keyword
1926         https://bugs.webkit.org/show_bug.cgi?id=37956
1927
1928         Reviewed by Ryosuke Niwa.
1929
1930         This patches adds support for NRWT so that if you type
1931         "new-run-webkit-tests foo" it will run all the tests in foo as
1932         well as platform/foo for all of the platforms that are normally
1933         searched (this only applies to directories, not to individual tests).
1934
1935         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1936         (Manager.collect_tests):
1937         * Scripts/webkitpy/layout_tests/port/base.py:
1938         (Port.tests):
1939         (Port):
1940         (Port._expanded_paths):
1941         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1942         (MainTest.test_no_http_tests):
1943         (MainTest):
1944         (MainTest.test_platform_tests_are_found):
1945
1946 2012-06-14  Dirk Pranke  <dpranke@chromium.org>
1947
1948         NRWT should honor --skipped=[default|ignore|only], like ORWT does
1949         https://bugs.webkit.org/show_bug.cgi?id=66308
1950
1951         Reviewed by Ryosuke Niwa.
1952
1953         This patch adds support for ORWT's --skipped=(default|ignore|only)
1954         flag and cleans up the interaction between that and --ignore.
1955
1956         Individual tests (but not directories) explicitly listed on the
1957         command line will always be run regardless of what is passed
1958         for --skipped and --ignore.
1959
1960         This patch also changes the "found" and "running" log messages
1961         since it wasn't clear how the skipped tests were included in those numbers.
1962
1963         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1964         (Manager.__init__):
1965         (Manager.collect_tests):
1966         (Manager.prepare_lists_and_print_output):
1967         * Scripts/webkitpy/layout_tests/port/test.py:
1968         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1969         (_set_up_derived_options):
1970         (parse_args):
1971         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1972         (MainTest.test_ignore_flag):
1973         (MainTest):
1974         (MainTest.test_skipped_flag):
1975
1976 2012-06-14  Takashi Toyoshima  <toyoshim@chromium.org>
1977
1978         new-run-webkit-websocketserver must handle TLS related arguments
1979         https://bugs.webkit.org/show_bug.cgi?id=89079
1980
1981         Reviewed by Dirk Pranke.
1982
1983         PyWebSocket class must accept private_key, certificate, and
1984         ca_certificate arguments and pass them to launching pywebsocket.
1985         Also add ca_certificate handling to new-run-webkit-websocketserver.
1986
1987         * Scripts/new-run-webkit-websocketserver:
1988         (main):
1989         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
1990         (PyWebSocket.__init__):
1991         (PyWebSocket._prepare_config):
1992
1993 2012-06-14  Qi Zhang  <qi.2.zhang@nokia.com>
1994
1995         Unreviewed. Update my email.
1996
1997         * Scripts/webkitpy/common/config/committers.py:
1998
1999 2012-06-14  Takashi Toyoshima  <toyoshim@chromium.org>
2000
2001         Update pywebsocket to 0.7.6 from 0.7.4
2002         https://bugs.webkit.org/show_bug.cgi?id=88975
2003
2004         Reviewed by Kent Tamura.
2005
2006         This new version of pywebsocket introduce following features.
2007          - Allow handlers to send a close frame with empty body in response of
2008              a client initiated closing handshake
2009          - Implement perframe compression extension
2010          - Support client certificate authentication
2011
2012         * Scripts/webkitpy/thirdparty/mod_pywebsocket/COPYING:
2013         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hybi.py:
2014         (_create_control_frame):
2015         (Stream._receive_frame):
2016         (Stream.send_message):
2017         (Stream.receive_message):
2018         (Stream._send_closing_handshake):
2019         (Stream.close_connection):
2020         * Scripts/webkitpy/thirdparty/mod_pywebsocket/common.py:
2021         (ExtensionParsingException):
2022         (ExtensionParsingException.__init__):
2023         (_parse_extension_param):
2024         (_parse_extension):
2025         (parse_extensions):
2026         (format_extension):
2027         (format_extensions):
2028         * Scripts/webkitpy/thirdparty/mod_pywebsocket/extensions.py:
2029         (_parse_compression_method):
2030         (_create_accepted_method_desc):
2031         (PerFrameCompressionExtensionProcessor):
2032         (PerFrameCompressionExtensionProcessor.__init__):
2033         (PerFrameCompressionExtensionProcessor._lookup_compression_processor):
2034         (PerFrameCompressionExtensionProcessor._get_compression_processor_response):
2035         (PerFrameCompressionExtensionProcessor.get_extension_response):
2036         (PerFrameCompressionExtensionProcessor.setup_stream_options):
2037         (PerFrameCompressionExtensionProcessor.get_compression_processor):
2038         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/_base.py:
2039         (parse_token_list):
2040         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi.py:
2041         (Handshaker._parse_extensions):
2042         (Handshaker._send_handshake):
2043         * Scripts/webkitpy/thirdparty/mod_pywebsocket/standalone.py:
2044         (WebSocketServer._create_sockets):
2045         (_get_logger_from_class):
2046         (_configure_logging):
2047         (_build_option_parser):
2048         (_main.if):
2049         * Scripts/webkitpy/thirdparty/mod_pywebsocket/util.py:
2050         (RepeatedXorMasker.mask):
2051
2052 2012-06-14  Zoltan Horvath  <zoltan@webkit.org>
2053
2054         [Qt] Remove USE(QT_IMAGE_DECODER) macro, since we don't use it anymore
2055
2056         Reviewed by Noam Rosenthal.
2057
2058         * qmake/mkspecs/features/features.prf:
2059
2060 2012-06-14  Christophe Dumez  <christophe.dumez@intel.com>
2061
2062         [WK2] Add implementation for registerIntentService in WebFrameLoaderClient
2063         https://bugs.webkit.org/show_bug.cgi?id=88399
2064
2065         Reviewed by Kenneth Rohde Christiansen.
2066
2067         Update initialization of WKPageLoaderClient.
2068
2069         * MiniBrowser/mac/BrowserWindowController.m:
2070         (-[BrowserWindowController awakeFromNib]):
2071         * WebKitTestRunner/TestController.cpp:
2072         (WTR::TestController::initialize):
2073
2074 2012-06-14  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2075
2076         [EFL] [DRT] Implement setDomainRelaxationForbiddenForURLScheme in EFL DRT
2077         https://bugs.webkit.org/show_bug.cgi?id=84577
2078
2079         Reviewed by Ryosuke Niwa.
2080
2081         Add missing implementation setDomainRelaxationForbiddenForURLScheme to EFL's
2082         LayoutTestController.
2083
2084         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2085         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
2086
2087 2012-06-13  Christophe Dumez  <christophe.dumez@intel.com>
2088
2089         [WK2] Add implementation for dispatchIntent in WebFrameLoaderClient
2090         https://bugs.webkit.org/show_bug.cgi?id=88340
2091
2092         Reviewed by Kenneth Rohde Christiansen.
2093
2094         Update initialization of WKPageLoaderClient.
2095
2096         * MiniBrowser/mac/BrowserWindowController.m:
2097         (-[BrowserWindowController awakeFromNib]):
2098         * WebKitTestRunner/TestController.cpp:
2099         (WTR::TestController::initialize):
2100
2101 2012-06-13  Sheriff Bot  <webkit.review.bot@gmail.com>
2102
2103         Unreviewed, rolling out r120268.
2104         http://trac.webkit.org/changeset/120268
2105         https://bugs.webkit.org/show_bug.cgi?id=89060
2106
2107         WebCompositor::setPerTilePaintingEnabled hits an assertion in
2108         DEBUG (Requested by dominicc|work on #webkit).
2109
2110         * DumpRenderTree/chromium/WebPreferences.cpp:
2111         (WebPreferences::applyTo):
2112
2113 2012-06-13  Tim Horton  <timothy_horton@apple.com>
2114
2115         REGRESSION (r120252): run-webkit-tests on Mac fails
2116         https://bugs.webkit.org/show_bug.cgi?id=89057
2117
2118         Reviewed by Dan Bernstein.
2119
2120         get_option will happily return None (the default only kicks in if
2121         the option is actually *not set*). We should instead check get_option's
2122         return value and default to "x86_64" architecture ourselves.
2123
2124         * Scripts/webkitpy/layout_tests/port/mac.py:
2125         (MacPort.__init__):
2126
2127 2012-06-13  Ian Vollick  <vollick@chromium.org>
2128
2129         [chromium] Certain settings in CCSettings could be global
2130         https://bugs.webkit.org/show_bug.cgi?id=88384
2131
2132         Reviewed by James Robinson.
2133
2134         * DumpRenderTree/chromium/WebPreferences.cpp:
2135         (WebPreferences::applyTo):
2136
2137 2012-06-13  Dirk Pranke  <dpranke@chromium.org>
2138
2139         new-run-webkit-tests does not support --32-bit like ORWT did
2140         https://bugs.webkit.org/show_bug.cgi?id=71634
2141
2142         Reviewed by Ojan Vafai.
2143
2144         This patch adds support for 32-bit apple mac builds, adding the
2145         --32-bit flag for compatibility with ORWT and fixing the port
2146         architecture() definition to actually return the correct values.
2147
2148         * Scripts/webkitpy/layout_tests/port/apple.py:
2149         (ApplePort._generate_all_test_configurations):
2150         * Scripts/webkitpy/layout_tests/port/factory.py:
2151         (port_options):
2152         * Scripts/webkitpy/layout_tests/port/mac.py:
2153         (MacPort):
2154         (MacPort.__init__):
2155         (MacPort._build_driver_flags):
2156         (MacPort.setup_environ_for_server):
2157         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2158         (test_sample_process_throws_exception):
2159         (test_32bit):
2160         (test_32bit.run_script):
2161         (test_64bit):
2162         (test_64bit.run_script):
2163         * Scripts/webkitpy/layout_tests/port/webkit.py:
2164         (WebKitPort._build_driver):
2165         (WebKitPort._build_driver_flags):
2166         * Scripts/webkitpy/layout_tests/port/win.py:
2167         (WinPort):
2168
2169 2012-06-13  Ryosuke Niwa  <rniwa@webkit.org>
2170
2171         Remove webkitpy code to support legacy test_expectations.txt files
2172         https://bugs.webkit.org/show_bug.cgi?id=89038
2173
2174         Reviewed by Dirk Pranke.
2175
2176         * Scripts/webkitpy/layout_tests/port/base.py:
2177         (Port.path_to_test_expectations_file):
2178         (Port.expectations_dict):
2179         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2180         (PortTest.test_uses_test_expectations_file):
2181         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2182         (WebKitPortTest.test_path_to_test_expectations_file):
2183         (test_test_expectations):
2184         * Scripts/webkitpy/style/checker.py:
2185         (CheckerDispatcher.should_skip_without_warning):
2186         (CheckerDispatcher._create_checker):
2187         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2188         (TestExpectationsTestCase._expect_port_for_expectations_path):
2189         * Scripts/webkitpy/tool/steps/commit.py:
2190         (Commit._check_test_expectations):
2191         * Scripts/webkitpy/tool/steps/commit_unittest.py:
2192         (CommitTest.test_check_test_expectations):
2193
2194 2012-06-13  Dirk Pranke  <dpranke@chromium.org>
2195
2196         nrwt: remove port.test_expectations() and port.test_expectations_overrides()
2197         https://bugs.webkit.org/show_bug.cgi?id=88948
2198
2199         Reviewed by Ojan Vafai.
2200
2201         In the final patch of this run, we remove the
2202         test_expectations() and test_expectation_overrides() methods
2203         from the Port class - callers must now use just
2204         expectations_dict().
2205
2206         Note that support for the cascade in new-run-webkit-tests is
2207         complete but only Chromium uses it; webkit-patch
2208         rebaseline-expectations still does not support updating entries
2209         in any file other than the first expectations file, however.
2210
2211         * Scripts/webkitpy/layout_tests/port/base.py:
2212         (Port.path_to_test_expectations_file):
2213         (Port.uses_test_expectations_file):
2214         (Port.expectations_files):
2215         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2216         (PortTest.test_additional_expectations):
2217         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2218         (ChromiumPortTest.test_expectations_files):
2219         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2220         (TestGoogleChromePort.test_get_google_chrome_port):
2221         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2222         (test_test_expectations):
2223         (test_legacy_test_expectations):
2224
2225 2012-06-13  Dirk Pranke  <dpranke@chromium.org>
2226
2227         nrwt: implement the actual cascade of TestExpectations
2228         https://bugs.webkit.org/show_bug.cgi?id=88947
2229
2230         Reviewed by Ojan Vafai.
2231
2232         This change implements the actual cascade by removing the
2233         concept of 'overrides' from the TestExpectations object and
2234         parsing each file separately.
2235
2236         There is an actual semantic change in this patch, in that
2237         setting an expectation on a directory in one file will override
2238         the expectations on any individual tests set in prior files. The
2239         test_overrides__directory() unit test verifies this.
2240
2241         Otherwise, this patch mostly consists of deleting code :).
2242
2243         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2244         (TestExpectationsModel.__init__):
2245         (TestExpectationsModel.add_expectation_line):
2246         (TestExpectationsModel._add_test):
2247         (TestExpectationsModel._already_seen_better_match):
2248         (TestExpectations.__init__):
2249         (TestExpectations._add_expectations):
2250         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2251         (test_overrides__directory):
2252
2253 2012-06-13  Dirk Pranke  <dpranke@chromium.org>
2254
2255         webkitpy: update callers to use port.expectation_dict() instead of test_expectations() and test_expectations_overrides()
2256         https://bugs.webkit.org/show_bug.cgi?id=88946
2257
2258         Reviewed by Ojan Vafai.
2259
2260         In preparation for fully supporting cascading expectations files
2261         and removing the 'overrides' concept.
2262
2263         There should be no functional changes in this patch.
2264
2265         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2266         (ManagerTest.test_update_summary_with_result):
2267         (ResultSummaryTest.get_result_summary):
2268         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2269         (TestExpectations.__init__):
2270         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2271         (parse_exp):
2272         (SkippedTests.check):
2273         (RemoveConfigurationsTest.test_remove):
2274         (test_remove_line):
2275         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2276         (LintTest.test_all_configurations.FakePort.__init__):
2277         (LintTest.test_all_configurations.FakePort.expectations_dict):
2278         (LintTest.test_lint_test_files__errors):
2279         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2280         (test_overrides_are_included_correctly):
2281
2282 2012-06-13  Dirk Pranke  <dpranke@chromium.org>
2283
2284         webkitpy: rework the TestExpectations style checker in preparation for the cascade
2285         https://bugs.webkit.org/show_bug.cgi?id=88945
2286
2287         Reviewed by Ojan Vafai.
2288
2289         This patch changes the style checker to call the
2290         TestExpectations parser directly and be oblivious as to what the
2291         port's actual expectations are.
2292
2293         * Scripts/webkitpy/style/checkers/test_expectations.py:
2294         (TestExpectationsChecker.__init__):
2295         (TestExpectationsChecker.check_test_expectations):
2296
2297 2012-06-13  Dirk Pranke  <dpranke@chromium.org>
2298
2299         nrwt: restructure the port classes to handle multiple expectations files
2300         https://bugs.webkit.org/show_bug.cgi?id=88944
2301
2302         Reviewed by Ojan Vafai.
2303
2304         This patch restructures the Port classes so that each port
2305         returns a list of TestExpectations files to be used (in a new, public,
2306         expectations_files() method), and the base implementation rolls them
2307         up into the ordered expectations_dict(), which becomes a public
2308         method.
2309
2310         port.path_to_test_expectations_file(), port.test_expectations(),
2311         and port.test_expectations_overrides() are then reimplemented as
2312         wrappers around port.expectations_dict().
2313         port.test_expectations() and port.test_expectations_overrides()
2314         will eventually be removed when the cascade is fully completed,
2315         and port.path_to_test_expectations_file() will be removed when
2316         the rebaselining tool supports the cascade
2317         (expectations_files() may also become private at that point).
2318
2319         There should be no functional changes in this patch, but a bunch
2320         of custom logic gets deleted!
2321
2322         * Scripts/webkitpy/layout_tests/port/base.py:
2323         (Port.expectations_dict):
2324         (Port):
2325         (Port.expectations_files):
2326         (Port.test_expectations):
2327         (Port.test_expectations_overrides):
2328         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2329         (PortTest.test_additional_expectations):
2330         (PortTest.test_uses_test_expectations_file):
2331         * Scripts/webkitpy/layout_tests/port/chromium.py:
2332         (ChromiumPort.all_baseline_variants):
2333         (ChromiumPort.expectations_files):
2334         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2335         (ChromiumPortTest.test_overrides_and_builder_names):
2336         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
2337         (_expectations_files):
2338         (GoogleChromeLinux32Port.expectations_files):
2339         (GoogleChromeLinux64Port.expectations_files):
2340         (GoogleChromeMacPort.expectations_files):
2341         (GoogleChromeWinPort.expectations_files):
2342         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2343         (TestGoogleChromePort._verify_expectations_overrides):
2344         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2345         (PortTestCase.test_expectations_ordering):
2346         * Scripts/webkitpy/layout_tests/port/webkit.py:
2347         (WebKitPort._skipped_file_search_paths):
2348         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2349         (TestRebaseline.test_rebaseline_updates_expectations_file_noop):
2350         (test_rebaseline_updates_expectations_file):
2351         (test_rebaseline_does_not_include_overrides):
2352         (test_rebaseline_expectations):
2353         (test_overrides_are_included_correctly):
2354
2355 2012-06-13  Brent Fulgham  <bfulgham@webkit.org>
2356
2357         [WinCairo] Update URL of WinCairoRequirements.zip download.
2358         https://bugs.webkit.org/show_bug.cgi?id=89009
2359
2360         Reviewed by Martin Robinson.
2361
2362         * Tools/Scripts/update-webkit-dependency: Put fallback code
2363         to download a "last update" time from servers that don't properly
2364         report Last-Modified in their HTTP header.
2365         * Tools/Scripts/update-webkit-wincairo-libs: Change download link
2366         for the WinCairo build requirements bundle.
2367
2368 2012-06-13  Dirk Pranke  <dpranke@chromium.org>
2369
2370         nrwt: preliminary cleanup before supporting cascading expectations files
2371         https://bugs.webkit.org/show_bug.cgi?id=88942
2372
2373         Reviewed by Ojan Vafai.
2374
2375         This change just prepares the TestExpectations parser to get filenames
2376         along with the expectations, and improves the warning messages so that
2377         they contain the filenames along with the line numbers.
2378
2379         There should be no functional changes in this patch.
2380
2381         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
2382         (TestExpectationEditorTests.make_parsed_expectation_lines):
2383         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2384         (TestExpectationParser.parse):
2385         (TestExpectationParser.expectation_for_skipped_test):
2386         (TestExpectationParser._tokenize):
2387         (TestExpectationParser._tokenize_list):
2388         (TestExpectationLine):
2389         (TestExpectationsModel.__init__):
2390         (TestExpectationsModel._already_seen_better_match):
2391         (TestExpectations.__init__):
2392         (TestExpectations._shorten_filename):
2393         (TestExpectations._report_warnings):
2394         (TestExpectations._add_skipped_tests):
2395         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2396         (TestExpectationParserTests._tokenize):
2397         (TestExpectationParserTests.test_tokenize_blank):
2398         (TestExpectationParserTests.test_tokenize_missing_colon):
2399         (TestExpectationParserTests.test_tokenize_extra_colon):
2400         (TestExpectationParserTests.test_tokenize_empty_comment):
2401         (TestExpectationParserTests.test_tokenize_comment):
2402         (TestExpectationParserTests.test_tokenize_missing_equal):
2403         (TestExpectationParserTests.test_tokenize_extra_equal):
2404         (TestExpectationParserTests.test_tokenize_valid):
2405         (TestExpectationParserTests.test_tokenize_valid_with_comment):
2406         (TestExpectationParserTests.test_tokenize_valid_with_multiple_modifiers):
2407         (TestExpectationParserTests.test_parse_empty_string):
2408         (TestExpectationSerializerTests._tokenize):
2409         (TestExpectationSerializerTests.assert_round_trip):
2410         (TestExpectationSerializerTests.assert_list_round_trip):
2411         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2412         (GardeningExpectationsUpdater.update_expectations):
2413
2414 2012-06-13  Zan Dobersek  <zandobersek@gmail.com>
2415
2416         [Gtk] Enable link prefetch support in the developer builds
2417         https://bugs.webkit.org/show_bug.cgi?id=89011
2418
2419         Reviewed by Martin Robinson.
2420
2421         Enable the link prefetch support for Gtk by default in developer
2422         builds.
2423
2424         * Scripts/webkitperl/FeatureList.pm:
2425
2426 2012-06-13  Csaba Osztrogonác  <ossy@webkit.org>
2427
2428         Update buildbot master in autoinstaller to match build.webkit.org
2429         https://bugs.webkit.org/show_bug.cgi?id=88992
2430
2431         Reviewed by Adam Barth.
2432
2433         * Scripts/webkitpy/thirdparty/__init__.py:
2434         (AutoinstallImportHook._install_buildbot):
2435
2436 2012-06-13  Sheriff Bot  <webkit.review.bot@gmail.com>
2437
2438         Unreviewed, rolling out r120209.
2439         http://trac.webkit.org/changeset/120209
2440         https://bugs.webkit.org/show_bug.cgi?id=89007
2441
2442         Broke the WebKit2 mac build. (Requested by andersca on
2443         #webkit).
2444
2445         * MiniBrowser/mac/BrowserWindowController.m:
2446         (-[BrowserWindowController awakeFromNib]):
2447         * WebKitTestRunner/TestController.cpp:
2448         (WTR::TestController::initialize):
2449
2450 2012-06-13  Zoltan Horvath  <zoltan@webkit.org>
2451
2452         check-webkit-style needs to respect Qt API coding style
2453         https://bugs.webkit.org/show_bug.cgi?id=88995
2454
2455         Reviewed by Csaba Osztrogonác.
2456
2457         Add -whitespace/declaration exception to Qt API files.
2458
2459         * Scripts/webkitpy/style/checker.py:
2460
2461 2012-06-13  Christophe Dumez  <christophe.dumez@intel.com>
2462
2463         [WK2] Add implementation for dispatchIntent in WebFrameLoaderClient
2464         https://bugs.webkit.org/show_bug.cgi?id=88340
2465
2466         Reviewed by Kenneth Rohde Christiansen.
2467
2468         Update initialization of WKPageLoaderClient.
2469
2470         * MiniBrowser/mac/BrowserWindowController.m:
2471         (-[BrowserWindowController awakeFromNib]):
2472         * WebKitTestRunner/TestController.cpp:
2473         (WTR::TestController::initialize):
2474
2475 2012-06-13  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
2476
2477         [Qt] Handle multiple held buttons in touch mocking.
2478         https://bugs.webkit.org/show_bug.cgi?id=88865
2479
2480         Reviewed by Kenneth Rohde Christiansen.
2481
2482         Add handling for multiple held mouse-buttons in the appropiate places.
2483         To do this last-pos and start-pos are now also read from the last recorded
2484         touch-point instead from object-global variables.
2485
2486         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2487         (MiniBrowserApplication::notify):
2488         (MiniBrowserApplication::updateTouchPoint):
2489         * MiniBrowser/qt/MiniBrowserApplication.h:
2490         (MiniBrowserApplication):
2491
2492 2012-06-13  Simon Hausmann  <simon.hausmann@nokia.com>
2493
2494         [Qt] Make it possible to disable -Werror in production builds
2495
2496         Reviewed by Tor Arne Vestbø.
2497
2498         Don't do -Werror if build-webkit is called with --qmakearg=CONFIG+=production_build,
2499         something qt5.git's qtwebkit.pri will soon do.
2500
2501         * qmake/mkspecs/features/unix/default_post.prf:
2502
2503 2012-06-13  Dominik Röttsches  <dominik.rottsches@intel.com>
2504
2505         [EFL] Store and compare md5sum of jhbuild files to trigger cleaning Dependencies
2506         https://bugs.webkit.org/show_bug.cgi?id=85790
2507
2508         Reviewed by Gustavo Noronha Silva.
2509
2510         Add md5 checks for jhbuild configuration for EFL, reusing the gtk jhbuild related
2511         code in webkitdirs.pm.
2512
2513         * Scripts/webkitdirs.pm:
2514         (jhbuildConfigurationChanged):
2515         (saveJhbuildMd5):
2516         (cleanJhbuild):
2517         (buildAutotoolsProject):
2518         (generateBuildSystemFromCMakeProject):
2519
2520 2012-06-13  Qi Zhang  <qi.2.zhang@nokia.com>
2521
2522         [Qt] Add configure test for zlib and set WTF_USE_ZLIB if found
2523         https://bugs.webkit.org/show_bug.cgi?id=88763
2524
2525         Add configure test for zlib and set WTF_USE_ZLIB if found to enable websocket
2526         extension.
2527
2528         Reviewed by Simon Hausmann.
2529
2530         * qmake/config.tests/libzlib: Added.
2531         * qmake/config.tests/libzlib/libzlib.cpp: Added.
2532         (main):
2533         * qmake/config.tests/libzlib/libzlib.pro: Added.
2534         * qmake/mkspecs/features/features.prf:
2535         * qmake/sync.profile:
2536
2537 2012-06-13  Robin Cao  <robin.cao@torchmobile.com.cn>
2538
2539         [BlackBerry] Enable MEDIA_STREAM by default
2540         https://bugs.webkit.org/show_bug.cgi?id=88849
2541
2542         Reviewed by Antonio Gomes.
2543
2544         * Scripts/webkitperl/FeatureList.pm:
2545
2546 2012-06-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2547
2548         Prevent stderr output from messing up detection of build path
2549
2550         https://bugs.webkit.org/show_bug.cgi?id=88075
2551
2552         Warnings such as 'perl: warning: Setting locale failed' will otherwise
2553         end up as the build path when calling out to webkit-build-directory.
2554
2555         Reviewed by Ojan Vafai.
2556
2557         * Scripts/webkitpy/layout_tests/port/config.py:
2558         (Config.build_directory):
2559
2560 2012-06-13  Ryosuke Niwa  <rniwa@webkit.org>
2561
2562         Update the builder name for Apple Lion builders.
2563
2564         * Scripts/webkitpy/layout_tests/port/builders.py:
2565
2566 2012-06-13  Joel Dillon  <joel.dillon@codethink.co.uk>
2567
2568         [Qt][Win]QtTestBrowser somehow picks up DumpRenderTree's main.cpp, causing a failure to link
2569         https://bugs.webkit.org/show_bug.cgi?id=88874
2570
2571         Reviewed by Simon Hausmann.
2572
2573         Rename main.cpp in QtTestBrowser because on Windows
2574         it conflicts with main.cpp from DumpRenderTree.
2575
2576         * QtTestBrowser/QtTestBrowser.pro:
2577         * QtTestBrowser/qttestbrowser.cpp: Renamed from Tools/QtTestBrowser/main.cpp.
2578         (launcherMain):
2579         (LauncherApplication):
2580         (LauncherApplication::urls):
2581         (LauncherApplication::isRobotized):
2582         (LauncherApplication::robotTimeout):
2583         (LauncherApplication::robotExtraTime):
2584         (LauncherApplication::applyDefaultSettings):
2585         (LauncherApplication::LauncherApplication):
2586         (requiresGraphicsView):
2587         (LauncherApplication::handleUserOptions):
2588         (main):
2589
2590 2012-06-12  Lucas Forschler  <lforschler@apple.com>
2591
2592         Wrap bot types inside ().
2593         https://bugs.webkit.org/show_bug.cgi?id=88893
2594         
2595         Reviewed by Stephanie Lewis.
2596
2597         * BuildSlaveSupport/build.webkit.org-config/config.json:
2598
2599 2012-06-12  Christophe Dumez  <christophe.dumez@intel.com>
2600
2601         [soup] Prevent setting or editing httpOnly cookies from JavaScript
2602         https://bugs.webkit.org/show_bug.cgi?id=88760
2603
2604         Reviewed by Gustavo Noronha Silva.
2605
2606         Update libsoup to v2.39.2, glib to v2.33.2 and glib-networking
2607         to v2.33.2 for both GTK and EFL ports.
2608
2609         * efl/jhbuild.modules:
2610         * gtk/jhbuild.modules:
2611
2612 2012-06-12  Christophe Dumez  <christophe.dumez@intel.com>
2613
2614         [EFL] Enable SHADOW_DOM flag
2615         https://bugs.webkit.org/show_bug.cgi?id=87732
2616
2617         Reviewed by Kentaro Hara.
2618
2619         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2620         (DumpRenderTreeChrome::resetDefaultsToConsistentValues): Enable
2621         SHADOW_DOM by default in DRT.
2622         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
2623         (onFocusCanCycle): Enable focus cycling in EFL DRT to behave like
2624         Chromium and Mac ports.
2625         (drtViewAdd):
2626         * Scripts/webkitperl/FeatureList.pm: Enable SHADOW_DOM flag by default
2627         at compile time for EFL port.
2628
2629 2012-06-12  Ashod Nakashian  <ashodnakashian@yahoo.com>
2630
2631         WinLauncher should show loading errors
2632         https://bugs.webkit.org/show_bug.cgi?id=80760
2633
2634         Reviewed by Brent Fulgham.
2635
2636         * WinLauncher/WinLauncher.cpp: Added load-fail handler to show messagebox with error.
2637         (WinLauncherWebHost::didFailProvisionalLoadWithError):
2638         * WinLauncher/WinLauncher.h:
2639         (WinLauncherWebHost::didFailProvisionalLoadWithError):
2640         (WinLauncherWebHost):
2641
2642 2012-06-12  Ryuan Choi  <ryuan.choi@samsung.com>
2643
2644         [EFL][WK2] Add MiniBrowserEfl.
2645         https://bugs.webkit.org/show_bug.cgi?id=61850
2646
2647         Reviewed by Chang Shu.
2648
2649         Implement MiniBrowser for EFL.
2650
2651         * CMakeLists.txt:
2652         * MiniBrowser/efl/CMakeLists.txt: Added.
2653         * MiniBrowser/efl/main.c: Added.
2654         (_MiniBrowser):
2655         (main_signal_exit):
2656         (on_ecore_evas_resize):
2657         (browserCreate):
2658         (main):
2659
2660 2012-06-12  Helder Correia  <helder.correia@nokia.com>
2661
2662         Unreviewed. Update my email address in committers.py.
2663
2664         * Scripts/webkitpy/common/config/committers.py:
2665
2666 2012-06-12  Dominik Röttsches  <dominik.rottsches@intel.com>
2667
2668         [EFL] Resolve CMake warnings on overlapping search paths for EFL jhbuild-enabled build
2669         https://bugs.webkit.org/show_bug.cgi?id=84707
2670
2671         Fixing CMAKE prefix path for 64bit systems to avoid CMAKE warnings on those.
2672         use_lib64 variable is preconfigured to True by jhbuild.
2673
2674         Reviewed by Dirk Pranke.
2675
2676         * efl/jhbuildrc:
2677
2678 2012-06-12  Dana Jansens  <danakj@chromium.org>
2679
2680         Add zlieber@chromium.org to contributors list
2681         https://bugs.webkit.org/show_bug.cgi?id=88904
2682
2683         Unreviewed.
2684
2685         * Scripts/webkitpy/common/config/committers.py:
2686
2687 2012-06-12  Lucas Forschler  <lforschler@apple.com>
2688
2689         Rename Apple bots to a standard convention.
2690         https://bugs.webkit.org/show_bug.cgi?id=88893
2691         
2692         Note: This has the side effect of grouping all of the Apple bots together in the waterfall.
2693
2694         Reviewed by Simon Fraser.
2695
2696         * BuildSlaveSupport/build.webkit.org-config/config.json:
2697
2698 2012-06-12  Mike West  <mkwst@chromium.org>
2699
2700         Make document.documentURI readonly from JavaScript
2701         https://bugs.webkit.org/show_bug.cgi?id=65187
2702
2703         Reviewed by Alexey Proskuryakov.
2704
2705         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2706         * TestWebKitAPI/Tests/mac/SetDocumentURI.html: Added.
2707         * TestWebKitAPI/Tests/mac/SetDocumentURI.mm: Added.
2708         (-[SetDocumentURITest webView:didFinishLoadForFrame:]):
2709         (TestWebKitAPI):
2710         (TestWebKitAPI::TEST):
2711
2712 2012-06-12  Christophe Dumez  <christophe.dumez@intel.com>
2713
2714         [EFL] enable LEGACY_WEBKIT_BLOB_BUILDER flag
2715         https://bugs.webkit.org/show_bug.cgi?id=88715
2716
2717         Reviewed by Noam Rosenthal.
2718
2719         Enable LEGACY_WEBKIT_BLOB_BUILDER flag by default on EFL port.
2720
2721         * Scripts/webkitperl/FeatureList.pm:
2722
2723 2012-06-12  Csaba Osztrogonác  <ossy@webkit.org>
2724
2725         [Qt] Fix -Werror for the buildbots
2726         https://bugs.webkit.org/show_bug.cgi?id=88223
2727
2728         Rubber-stamped by Tor Arne Vestbø.
2729
2730         Revert a part of r119269 to enable Werror again for non qt-developer-builds. (for bots for example)
2731
2732         * qmake/mkspecs/features/unix/default_post.prf:
2733
2734 2012-06-12  Balazs Kelemen  <kbalazs@webkit.org>
2735
2736         [REGRESSION][WTR] Build fail with werror after r120054
2737         https://bugs.webkit.org/show_bug.cgi?id=88862
2738
2739         Reviewed by Csaba Osztrogonác.
2740
2741         Some static helpers become unused after counterValueForElementById
2742         has moved to Internals. Let's remove them.
2743
2744         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2745         (WTR):
2746
2747 2012-06-12  Csaba Osztrogonác  <ossy@webkit.org>
2748
2749         [Qt] Slave losts cause build break on bots
2750         https://bugs.webkit.org/show_bug.cgi?id=38980
2751
2752         Minor fix after r59261.
2753
2754         Reviewed by Tor Arne Vestbø.
2755
2756         * Scripts/build-webkit:
2757         (unlinkZeroFiles): Don't remove 0 byte sized directories, because they are always 0 byte sized on Windows.
2758
2759 2012-06-11  Kaustubh Atrawalkar  <kaustubh@motorola.com>
2760
2761         [DRT] LTC:: counterValueForElementById() could be moved to Internals.
2762         https://bugs.webkit.org/show_bug.cgi?id=84406
2763
2764         Reviewed by Hajime Morita.
2765
2766         Move the counterValueForElementById from LayoutTestCotroller to Internals and
2767         remove the old platform specific implementations as it exclusively tests WebCore functionality.
2768
2769         * DumpRenderTree/LayoutTestController.cpp:
2770         (LayoutTestController::staticFunctions):
2771         * DumpRenderTree/LayoutTestController.h:
2772         (LayoutTestController):
2773         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
2774         * DumpRenderTree/chromium/LayoutTestController.cpp:
2775         (LayoutTestController::LayoutTestController):
2776         (LayoutTestController::setPOSIXLocale):
2777         * DumpRenderTree/chromium/LayoutTestController.h:
2778         (LayoutTestController):
2779         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2780         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2781         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2782         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2783         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2784         (LayoutTestController):
2785         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2786         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2787         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2788         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2789         (WTR):
2790         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2791         (LayoutTestController):
2792
2793 2012-06-11  Hans Wennborg  <hans@chromium.org>
2794
2795         Speech JavaScript API: Make SpeechRecognitionError an Event
2796         https://bugs.webkit.org/show_bug.cgi?id=88784
2797
2798         Reviewed by Adam Barth.
2799
2800         Make it possible to have MockWebSpeechRecognizer fire error events.
2801
2802         * DumpRenderTree/chromium/LayoutTestController.cpp:
2803         (LayoutTestController::LayoutTestController):
2804         (LayoutTestController::setMockSpeechRecognitionError):
2805         * DumpRenderTree/chromium/LayoutTestController.h:
2806         (LayoutTestController):
2807         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
2808         (WebKit):
2809         (ErrorTask):
2810         (WebKit::ErrorTask::ErrorTask):
2811         (MockWebSpeechRecognizer::addMockResult):
2812         (MockWebSpeechRecognizer::setError):
2813         * DumpRenderTree/chromium/MockWebSpeechRecognizer.h:
2814         (MockWebSpeechRecognizer):
2815
2816 2012-06-11  Ojan Vafai  <ojan@chromium.org>
2817
2818         Don't show the ASAN builders in garden-o-matic since they don't get block WebKit rolls.
2819         https://bugs.webkit.org/show_bug.cgi?id=88836
2820
2821         Reviewed by Dirk Pranke.
2822
2823         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
2824         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
2825
2826 2012-06-11  Christophe Dumez  <christophe.dumez@intel.com>
2827
2828         [EFL] Remove CMakeCache.txt before building
2829         https://bugs.webkit.org/show_bug.cgi?id=88717
2830
2831         Reviewed by Antonio Gomes.
2832
2833         Remove CMake cache file before every build to avoid using outdated
2834         build flags when new features get enabled. This will avoid unexpected
2835         failures on the bots due to outdated build flags.
2836
2837         * Scripts/webkitdirs.pm:
2838         (generateBuildSystemFromCMakeProject):
2839
2840 2012-06-11  Vincent Scheib  <scheib@chromium.org>
2841
2842         Add new Pointer Lock spec attribute webkitPointerLockElement.
2843         https://bugs.webkit.org/show_bug.cgi?id=88799
2844
2845         Reviewed by Dimitri Glazkov.
2846
2847         Part of a series of refactoring changes to update pointer lock API to
2848         the fullscreen locking style. https://bugs.webkit.org/show_bug.cgi?id=84402
2849
2850         New attribute webkitPointerLockElement added. Follow up patches
2851         will remove the previous isLocked attribute. Tests updated to use
2852         the new attribute.
2853
2854         WebViewHost logic required modification to correctly repond to
2855         a lock, unlock, pointerLockElement call series. Specifically,
2856         unlocking must be queued after a lock command is issued always
2857         as the lock state may not be set yet with a lock request in flight.
2858
2859         * DumpRenderTree/chromium/WebViewHost.cpp:
2860         (WebViewHost::requestPointerUnlock): Always post didLosePointerLock task.
2861         (WebViewHost::didLosePointerLock): Signal didLosePointerLock only if pointer was locked.
2862
2863 2012-06-11  Alexis Menard  <alexis.menard@openbossa.org>
2864
2865         [CSS3 Backgrounds and Borders] Protect box-decoration-break behind a feature flag.
2866         https://bugs.webkit.org/show_bug.cgi?id=88804
2867
2868         Reviewed by Tony Chang.
2869
2870         Protect box-decoration-break behind a feature flag enabled by default.
2871
2872         * Scripts/webkitperl/FeatureList.pm:
2873         * qmake/mkspecs/features/features.pri:
2874
2875 2012-06-11  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2876
2877         [CMAKE][EFL] Remove duplicated executable output path
2878         https://bugs.webkit.org/show_bug.cgi?id=88765
2879
2880         Reviewed by Daniel Bates.
2881
2882         CMake files for EFL port have redefined executable output path. However, EFL port doesn't
2883         need to define again because it is already defined in top-level CMake file.
2884
2885         * DumpRenderTree/efl/CMakeLists.txt:
2886         * EWebLauncher/CMakeLists.txt:
2887
2888 2012-06-11  Ojan Vafai  <ojan@chromium.org>
2889
2890         Don't consider show warnings in the garden-o-matic UI for non-layout test failures
2891         https://bugs.webkit.org/show_bug.cgi?id=88816
2892
2893         Reviewed by Dirk Pranke.
2894
2895         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
2896         Expose a way to clear AsynchronousCaches.
2897         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
2898         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
2899         Clear the buildInfo cache at the beginning of each test in order to avoid having one test affect another.
2900
2901 2012-06-11  Dirk Pranke  <dpranke@chromium.org>
2902
2903         nrwt exits early too frequently
2904         https://bugs.webkit.org/show_bug.cgi?id=73843
2905
2906         Reviewed by Ryosuke Niwa.
2907
2908         Change the defaults for new-run-webkit-tests for both
2909         --exit-after-n-failures and --exit-after-n-crashes-or-timeouts
2910         to zero (i.e., we will never exit early by default).
2911
2912         If people want their buildbots to exit early it is their
2913         responsibility to update their buildbot configs appropriately.
2914
2915         Note that we have tests that ensure that these flags work for
2916         non-zero numbers, but we don't have tests that either test the
2917         default or ensure that zero means "run all of the tests". I
2918         think that's okay but can add tests if others disagree.
2919
2920         Also note that it looks like no changes on the build.webkit.org
2921         master.cfg are necessary; all of the bots seem to be using the
2922         RunWebKitTests wrapper which is already setting the flags. There
2923         is a NewRunWebKitTests wrapper, but that looks to be unused; I
2924         will delete that in a separate patch.
2925
2926         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2927         (parse_args):
2928
2929 2012-06-11  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2930
2931         [EFL] [DRT] Reset CacheModel before running each test
2932         https://bugs.webkit.org/show_bug.cgi?id=87534
2933
2934         Reviewed by Gustavo Noronha Silva.
2935
2936         Reset cache model to default before running each test to fix some
2937         flaky tests on EFL build bots. Also fix case value in setCacheModel.
2938
2939         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2940         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2941         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2942         (LayoutTestController::setCacheModel):
2943
2944 2012-06-11  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2945
2946         [GTK] Memory leaks in DRT EventSender.cpp
2947         https://bugs.webkit.org/show_bug.cgi?id=88774
2948
2949         Reviewed by Martin Robinson.
2950
2951         Fix a few possible memory leaks in EventSender code.
2952
2953         * DumpRenderTree/gtk/EventSender.cpp:
2954         (contextClickCallback): Free the event returned by gdk_event_new().
2955         (mouseDownCallback): Ditto.
2956         (mouseUpCallback): Ditto.
2957
2958 2012-06-11  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2959
2960         [EFL] REGRESSION (r119788): tests rely on pathToLocalResource are failing after r119788
2961         https://bugs.webkit.org/show_bug.cgi?id=88661
2962
2963         Reviewed by Dirk Pranke.
2964
2965         Pass string length explicitly when creating String object from
2966         non-null-terminated UChar* returned by characters().
2967
2968         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2969         (LayoutTestController::pathToLocalResource):
2970
2971 2012-06-11  David Dorwin  <ddorwin@chromium.org>
2972
2973         [chromium] Provide access to the WebPlugin created by the helper plugin widget
2974         https://bugs.webkit.org/show_bug.cgi?id=88028
2975
2976         Reviewed by Adam Barth.
2977
2978         Added isPlaceholder() to WebPlugin.
2979
2980         * DumpRenderTree/chromium/TestWebPlugin.h:
2981         (TestWebPlugin::isPlaceholder):
2982
2983 2012-06-11  Tony Chang  <tony@chromium.org>
2984
2985         rebaseline from garden-o-matic leaves N processes each time it is run
2986         https://bugs.webkit.org/show_bug.cgi?id=88586
2987
2988         Reviewed by Dirk Pranke.
2989
2990         This appears to only be a problem on python 2.7. Maybe a bug causing
2991         pools to not be garbage collected?
2992
2993         * Scripts/webkitpy/common/system/executive.py:
2994         (Executive.run_in_parallel): close() and join() the process pool.
2995         * Scripts/webkitpy/common/system/executive_unittest.py:
2996         (ExecutiveTest.test_run_in_parallel):
2997
2998 2012-06-11  Zoltan Horvath  <zoltan@webkit.org>
2999
3000         [Qt] Add config tests for WEBP imagedecoder library, modify HAVE(decoderlibrary) to USE(...)
3001         https://bugs.webkit.org/show_bug.cgi?id=87841
3002
3003         Reviewed by Simon Hausmann.
3004
3005         * qmake/config.tests/libwebp/libwebp.cpp: Added.
3006         (main):
3007         * qmake/config.tests/libwebp/libwebp.pro: Added.
3008         * qmake/sync.profile:
3009
3010 2012-06-10  Ryosuke Niwa  <rniwa@webkit.org>
3011
3012         Expose layoutTestController as testRunner
3013         https://bugs.webkit.org/show_bug.cgi?id=88210
3014
3015         Reviewed by Darin Adler.
3016
3017         * DumpRenderTree/LayoutTestController.cpp:
3018         (LayoutTestController::makeWindowObject):
3019         * DumpRenderTree/chromium/TestShell.cpp:
3020         (TestShell::bindJSObjectsToWindow):
3021         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3022         (WebCore::DumpRenderTree::initJSObjects):
3023         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3024         (WTR::LayoutTestController::makeWindowObject):
3025
3026 2012-06-09  Dominic Cooney  <dominicc@chromium.org>
3027
3028         [Chromium] Remove JavaScriptCore dependencies from gyp
3029         https://bugs.webkit.org/show_bug.cgi?id=88510
3030
3031         Reviewed by Adam Barth.
3032
3033         Chromium doesn't support JSC any more and there doesn't seem to be
3034         a strong interest in using GYP as the common build system in other
3035         ports.
3036
3037         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3038         * Scripts/generate-project-files: Removed.
3039
3040 2012-06-09  Sukolsak Sakshuwong  <sukolsak@google.com>
3041
3042         Add UNDO_MANAGER flag
3043         https://bugs.webkit.org/show_bug.cgi?id=87908
3044
3045         Reviewed by Tony Chang.
3046
3047         * Scripts/webkitperl/FeatureList.pm:
3048         * qmake/mkspecs/features/features.pri:
3049
3050 2012-06-08  Ryosuke Niwa  <rniwa@webkit.org>
3051
3052         webkit-patch land-safely should set cq? if the patch author is not in committers.py
3053         https://bugs.webkit.org/show_bug.cgi?id=88689
3054
3055         Reviewed by Dirk Pranke.
3056
3057         When posting a patch on Bugzilla, trun cq+ into cq? if the Bugzilla login is not listed
3058         in committers.py or the contributor cannot commit. If anything, the contributor can still
3059         set cq+ on thier patches manually so I don't think this will be an issue for people who
3060         don't list their Bugzille email on committers.py.
3061
3062         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3063         (Bugzilla._commit_queue_flag):
3064         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3065         (test_commit_queue_flag):
3066         (test_commit_queue_flag.assert_commit_queue_flag):
3067
3068 2012-06-08  Dirk Pranke  <dpranke@chromium.org>
3069
3070         remove obsolete NewRunWebKitTests buildbot master factory classes
3071         https://bugs.webkit.org/show_bug.cgi?id=88693
3072
3073         Reviewed by Ryosuke Niwa.
3074
3075         I believe these aren't used any more ...
3076
3077         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3078         (RunWebKitTests.getText2):
3079         (BuildAndTestLeaksFactory):
3080
3081 2012-06-08  Xianzhu Wang  <wangxianzhu@chromium.org>
3082
3083         [Chromium-Android] Build DumpRenderTree with Android SDK
3084         https://bugs.webkit.org/show_bug.cgi?id=88598
3085
3086         Change WebKit side of DRT related code according to some recent changes at chromium side.
3087
3088         Reviewed by Adam Barth.
3089
3090         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3091         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3092         (ChromiumAndroidPort.__init__):
3093         (ChromiumAndroidPort._path_to_driver):
3094
3095 2012-06-08  Wei James  <james.wei@intel.com>
3096
3097         Add app_abi option for DumpRenderTree_apk
3098         https://bugs.webkit.org/show_bug.cgi?id=88626
3099
3100         Reviewed by Adam Barth.
3101
3102         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3103
3104 2012-06-08  Carlos Garcia Campos  <cgarcia@igalia.com>
3105
3106         [GTK] Add API to get the library version to WebKit2 GTK+
3107         https://bugs.webkit.org/show_bug.cgi?id=88426
3108
3109         Reviewed by Martin Robinson.
3110
3111         * gtk/generate-gtkdoc:
3112         (get_webkit2_options): Add built sources to the list of files, but
3113         ignore enum types and marshallers.
3114
3115 2012-06-07  Vincent Scheib  <scheib@chromium.org>
3116
3117         Layout Test pointer-lock/pointerlockchange-pointerlockerror-events.html is failing
3118         https://bugs.webkit.org/show_bug.cgi?id=88604
3119
3120         Reviewed by Kent Tamura.
3121
3122         DumpRenderTree fixed to not call didLosePointerLock if pointer is not currently locked.
3123         Fixes debug only assert crash in pointer-lock/pointerlockchange-pointerlockerror-events.html test.
3124
3125         * DumpRenderTree/chromium/WebViewHost.cpp:
3126         (WebViewHost::requestPointerUnlock):
3127
3128 2012-06-08  Hans Wennborg  <hans@chromium.org>
3129
3130         Speech JavaScript API: mock WebSpeechRecognizer for DumpRenderTree
3131         https://bugs.webkit.org/show_bug.cgi?id=87976
3132
3133         Reviewed by Kent Tamura.
3134
3135         Provide a mock implementation of WebSpeechRecognizer for
3136         DumpRenderTree. This will allow better testing of the API via layout
3137         tests.
3138
3139         * DumpRenderTree/DumpRenderTree.gypi:
3140         * DumpRenderTree/chromium/LayoutTestController.cpp:
3141         (LayoutTestController::LayoutTestController):
3142         (LayoutTestController::addMockSpeechRecognitionResult):
3143         * DumpRenderTree/chromium/LayoutTestController.h:
3144         (LayoutTestController):
3145         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp: Added.
3146         (MockWebSpeechRecognizer::create):
3147         (MockWebSpeechRecognizer::start):
3148         (MockWebSpeechRecognizer::stop):
3149         (MockWebSpeechRecognizer::abort):
3150         (MockWebSpeechRecognizer::MockWebSpeechRecognizer):
3151         (MockWebSpeechRecognizer::~MockWebSpeechRecognizer):
3152         (MockWebSpeechRecognizer::ResultTask::runIfValid):
3153         * DumpRenderTree/chromium/MockWebSpeechRecognizer.h: Added.
3154         (WebKit):
3155         (MockWebSpeechRecognizer):
3156         (MockWebSpeechRecognizer::addMockResult):
3157         (MockWebSpeechRecognizer::taskList):
3158         (ClientCallTask):
3159         (MockWebSpeechRecognizer::ClientCallTask::ClientCallTask):
3160         (ResultTask):
3161         (MockWebSpeechRecognizer::ResultTask::ResultTask):
3162         (NoMatchTask):
3163         (MockWebSpeechRecognizer::NoMatchTask::NoMatchTask):
3164         * DumpRenderTree/chromium/WebViewHost.cpp:
3165         (WebViewHost::speechRecognizer):
3166         * DumpRenderTree/chromium/WebViewHost.h:
3167         (WebViewHost):
3168         (WebViewHost::mockSpeechRecognizer):
3169
3170 2012-06-07  Kinuko Yasuda  <kinuko@chromium.org>
3171
3172         check-webkit-style needs to be taught about <public/Foo.h>
3173         https://bugs.webkit.org/show_bug.cgi?id=88524
3174
3175         Reviewed by David Levin.
3176
3177         * Scripts/webkitpy/style/checkers/cpp.py:
3178         (_classify_include):
3179         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3180         (OrderOfIncludesTest.test_public_primary_header):
3181         (OrderOfIncludesTest.test_classify_include):
3182
3183 2012-06-07  Joshua Lock  <joshua.lock@intel.com>
3184
3185         [EFL][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
3186         https://bugs.webkit.org/show_bug.cgi?id=67255
3187
3188         Reviewed by Dirk Pranke.
3189
3190         Implement pathToLocalResource to redirect file:///tmp URL's to
3191         DUMPRENDERTREE_TEMP and file:///tmp/LayoutTests to point to the
3192         LayoutTests sub-directory of the WebKit source tree.
3193
3194         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3195         (LayoutTestController::pathToLocalResource):
3196
3197 2012-06-07  Tony Payne  <tpayne@chromium.org>
3198
3199         [chromium] Allow LayoutTests under new git workflow
3200         https://bugs.webkit.org/show_bug.cgi?id=88575
3201
3202         On Windows, chromium indirects through git.bat. Adds the same hack that
3203         is currently used for discovering svn.bat to support the new git
3204         workflow.
3205
3206         Reviewed by Dirk Pranke.
3207
3208         * Scripts/webkitpy/common/checkout/scm/git.py:
3209         (Git): Replaces all hard-coded references to 'git' with the class
3210         variable executable_name.
3211         (Git._check_git_architecture):
3212         (Git.in_working_directory):
3213         (Git.find_checkout_root):
3214         (Git.read_git_config):
3215         (Git.discard_local_commits):
3216         (Git.local_commits):
3217         (Git.working_directory_is_clean):
3218         (Git.clean_working_directory):
3219         (Git.status_command):
3220         (Git.add_list):
3221         (Git.delete_list):
3222         (Git.exists):
3223         (Git._current_branch):
3224         (Git.changed_files):
3225         (Git._changes_files_for_commit):
3226         (Git.revisions_changing_file):
3227         (Git.conflicted_files):
3228         (Git.svn_revision):
3229         (Git.create_patch):
3230         (Git._run_git_svn_find_rev):
3231         (Git.contents_at_revision):
3232         (Git.diff_for_file):
3233         (Git.show_head):
3234         (Git.committer_email_for_revision):
3235         (Git.apply_reverse_diff):
3236         (Git.revert_files):
3237         (Git.commit_with_message):
3238         (Git._commit_on_branch):
3239         (Git.svn_commit_log):
3240         (Git.last_svn_commit_log):
3241         (Git.svn_blame):
3242         (Git._branch_ref_exists):
3243         (Git.delete_branch):
3244         (Git.remote_merge_base):
3245         (Git.commit_locally_with_message):
3246         (Git.push_local_commits_to_server):
3247         (Git.commit_ids_from_commitish_arguments):
3248         (Git.commit_message_for_local_commit):
3249         (Git.files_changed_summary_for_commit):
3250         * Scripts/webkitpy/common/host.py:
3251         (Host._engage_awesome_windows_hacks): Adds an awesome 'git.bat' hack
3252         that duplicates the logic in the existing 'svn.bat' hack.
3253
3254 2012-06-07  Ojan Vafai  <ojan@chromium.org>
3255
3256         Style build architectures like build versions for non-layout test failures
3257         https://bugs.webkit.org/show_bug.cgi?id=88590
3258
3259         Reviewed by Tony Chang.
3260
3261         Since we show the list of failing tests after the architecture, we want the
3262         buildtype and architecture to be grouped together visually.
3263
3264         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css:
3265         (.effects a.failing-builder>span.architecture):
3266
3267 2012-06-07  Xianzhu Wang  <wangxianzhu@chromium.org>
3268
3269         [Chromium] Remove header dependency of ImageDiff to WTF
3270         https://bugs.webkit.org/show_bug.cgi?id=88422
3271
3272         Reviewed by Ryosuke Niwa.
3273
3274         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3275         * DumpRenderTree/chromium/ImageDiff.cpp:
3276         (untestedCompareImages):
3277
3278 2012-06-07  Dongwoo Im  <dw.im@samsung.com>
3279
3280         [EFL] [DRT] DRT enables WebAudio when WebAudio feature is enabled.
3281         https://bugs.webkit.org/show_bug.cgi?id=88491
3282
3283         Reviewed by Dirk Pranke.
3284
3285         DRT should enable WebAudio when WebAudio feature is enabled,
3286         so that the WebAudio feature could be tested by the Layouttest.
3287
3288         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp: Enable WebAudio when WebAudio feature is enabled.
3289         (LayoutTestController::overridePreference):
3290
3291 2012-06-07  Dirk Pranke  <dpranke@chromium.org>
3292
3293         webkit-patch rebaseline-expectations should only rebaseline the appropriate suffixes for the failure in question
3294         https://bugs.webkit.org/show_bug.cgi?id=88581
3295
3296         Reviewed by Ojan Vafai.
3297
3298         webkit-paptch rebaseline-expectations was ignoring what the
3299         expected results for a test were and pulling down all the result
3300         files from a bot. This could lead to us pulling down old,
3301         incorrect .txt or .png files. With this patch we will now only
3302         pull down expectations of the appropriate file types (so an
3303         IMAGE failure will only pull the png and not the txt file).
3304
3305         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3306         (has_pixel_failures):
3307         (suffixes_for_expectations):
3308         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3309         (FunctionsTest.test_suffixes_for_expectations):
3310         * Scripts/webkitpy/tool/commands/rebaseline.py:
3311         (AbstractRebaseliningCommand.__init__):
3312         (RebaselineExpectations._is_supported_port):
3313         (RebaselineExpectations._update_expectations_file):
3314         (RebaselineExpectations._tests_to_rebaseline):
3315         (RebaselineExpectations._rebaseline_port):
3316         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3317         (test_overrides_are_included_correctly):
3318
3319 2012-06-07  Ojan Vafai  <ojan@chromium.org>
3320
3321         Fix recent null pointer error regression in the flakiness dashboard
3322         https://bugs.webkit.org/show_bug.cgi?id=88573
3323
3324         Reviewed by Dirk Pranke.
3325
3326         * TestResultServer/static-dashboards/builders.js:
3327         (requestBuilderList):
3328         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3329
3330 2012-06-07  Konrad Piascik  <kpiascik@rim.com>
3331
3332         Add Konrad Piascik to committers.py
3333         https://bugs.webkit.org/show_bug.cgi?id=88560
3334
3335         Unreviewed.
3336
3337         * Scripts/webkitpy/common/config/committers.py:
3338
3339 2012-06-07  Tony Chang  <tony@chromium.org>
3340
3341         [chromium] Win mock scrollbars appear to overflow by a pixel to the right and bottom
3342         https://bugs.webkit.org/show_bug.cgi?id=77368
3343
3344         Reviewed by Ojan Vafai.
3345
3346         It doesn't look like we ever get a rect with width or height of 0.
3347         I ran css1, css2.1, fast/forms, and tables without any crashes.
3348
3349         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
3350         (webRectToSkIRect): Correctly convert a WebRect to a SkIRect.
3351
3352 2012-06-07  Dirk Pranke  <dpranke@chromium.org>
3353
3354         run-webkit-tests --lint-test-files gives an error when run on linux
3355         https://bugs.webkit.org/show_bug.cgi?id=88551
3356
3357         Reviewed by Ojan Vafai.
3358
3359         We weren't mapping the expectations properly for the
3360         google-chrome ports.
3361
3362         * Scripts/webkitpy/layout_tests/port/base.py:
3363         (Port.path_to_test_expectations_file):
3364         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
3365         (TestGoogleChromePort.test_path_to_expectations):
3366
3367 2012-06-07  Daniel Erat  <derat@chromium.org>
3368
3369         [chromium] Add LayoutTestController::setTextSubpixelPositioning() for Linux.
3370         https://bugs.webkit.org/show_bug.cgi?id=88263
3371
3372         Reviewed by Tony Chang.
3373
3374         * DumpRenderTree/chromium/LayoutTestController.cpp:
3375         (LayoutTestController::LayoutTestController):
3376         (LayoutTestController::reset):
3377         (LayoutTestController::setTextSubpixelPositioning):
3378         * DumpRenderTree/chromium/LayoutTestController.h:
3379         (LayoutTestController):
3380         * DumpRenderTree/chromium/fonts.conf:
3381
3382 2012-06-07  Zan Dobersek  <zandobersek@gmail.com>
3383
3384         [Gtk] Assertions in gtk_widget_draw when acquiring pixel output
3385         https://bugs.webkit.org/show_bug.cgi?id=88060
3386
3387         Reviewed by Martin Robinson.
3388
3389         Spin the main loop before acquiring the pixel content. This ensures things
3390         like late size allocations are finished before calling gtk_widget_draw,
3391         avoiding assertions and subsequent empty pixel results.
3392
3393         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
3394         (createBitmapContextFromWebView):
3395
3396 2012-06-06  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3397
3398         [Qt] Improve the visual of the viewport info box
3399         https://bugs.webkit.org/show_bug.cgi?id=88410
3400
3401         Reviewed by Tor Arne Vestbø.
3402
3403         Improve the visual and make it possible to see the content more easy.
3404
3405         * MiniBrowser/qt/qml/ViewportInfoItem.qml:
3406
3407 2012-06-06  Mariusz Grzegorczyk  <mariusz.g@samsung.com>
3408
3409         [EFL][WK2] Compile webkit1 and webkit2 by default.
3410         https://bugs.webkit.org/show_bug.cgi?id=85041
3411
3412         Reviewed by Chang Shu.
3413
3414         Compile webkit1 and webkit2 while running Tools/Scripts/build-webkit --efl.
3415         Webkit2 build can be skipped by adding --no-webkit2 option to build-webkit script.
3416
3417         * Scripts/build-webkit:
3418
3419 2012-06-06  Sheriff Bot  <webkit.review.bot@gmail.com>
3420
3421         Unreviewed, rolling out r119662.
3422         http://trac.webkit.org/changeset/119662
3423         https://bugs.webkit.org/show_bug.cgi?id=88487
3424
3425         Broke builds (Requested by rniwa on #webkit).
3426
3427         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3428         * DumpRenderTree/chromium/ImageDiff.cpp:
3429         (untestedCompareImages):
3430
3431 2012-06-06  Xianzhu Wang  <wangxianzhu@chromium.org>
3432
3433         [Chromium] Remove header dependency of ImageDiff to WTF
3434         https://bugs.webkit.org/show_bug.cgi?id=88422
3435
3436         Reviewed by Adam Barth.
3437
3438         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3439         * DumpRenderTree/chromium/ImageDiff.cpp:
3440         (untestedCompareImages):
3441
3442 2012-06-06  Amy Ousterhout  <aousterh@chromium.org>
3443
3444         [WebKit] DeviceOrientation cleanup
3445         https://bugs.webkit.org/show_bug.cgi?id=88406
3446
3447         Reviewed by Kent Tamura.
3448
3449         Updated LayoutTestController to use new public default constructor in WebDeviceOrientation.h.
3450
3451         * DumpRenderTree/chromium/LayoutTestController.cpp:
3452         (LayoutTestController::setMockDeviceOrientation):
3453
3454 2012-05-29  Dirk Pranke  <dpranke@chromium.org>
3455
3456         webkitpy: add support for an ordered dict of test expectations
3457         https://bugs.webkit.org/show_bug.cgi?id=87802
3458
3459         Reviewed by Ojan Vafai.
3460
3461         As per https://bugs.webkit.org/show_bug.cgi?id=65834 we want to
3462         support a cascaded list of test expectations files. An easy way
3463         to think of this is as an ordered dictionary of name -> contents
3464         for files, where the name is usually a path on disk (I say
3465         usually because we want to support other kinds of expectations
3466         like the compile-time skips for unsupported features in
3467         webkit.py, and we want to continue to support "in-memory" test
3468         expectations that don't require a filesystem).
3469
3470         Conveniently there is an OrderedDict implementation in Python
3471         2.7+ and it is available as a backport, so the first step in
3472         adding this support is to use that implementation. Subsequent
3473         patches will update the test_expectations.py module (and other
3474         callers) to access the dict directly.
3475
3476         This patch just changes the base internal implementation and
3477         provides wrappers for compatibility. The derived ports
3478         (WebKitPort, TestPort, etc.) still need to be updated.
3479
3480         * Scripts/webkitpy/layout_tests/port/base.py:
3481         (Port._expectations_dict):
3482         (Port.test_expectations):
3483         (Port):
3484         (Port._expectations_overrides_dict):
3485         (Port.test_expectations_overrides):
3486         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3487         (PortTestCase.test_expectations_ordering):
3488         (PortTestCase):
3489         (PortTestCase.test_expectations_overrides_ordering):
3490         * Scripts/webkitpy/thirdparty/ordered_dict.py: Added.
3491         (OrderedDict):
3492         (OrderedDict.__init__):
3493         (OrderedDict.clear):
3494         (OrderedDict.__setitem__):
3495         (OrderedDict.__delitem__):
3496         (OrderedDict.__iter__):
3497         (OrderedDict.__reversed__):
3498         (OrderedDict.popitem):
3499         (OrderedDict.__reduce__):
3500         (OrderedDict.__repr__):
3501         (OrderedDict.copy):
3502         (OrderedDict.fromkeys):
3503
3504 2012-06-06  Mario Sanchez Prada  <msanchez@igalia.com>
3505
3506         Unreviewed gardening. Unit test fails on GTK 64bit debug bot.
3507
3508         * gtk/run-api-tests:
3509         (TestRunner): Skip TestWebKitAPI/WTF/TestHashMap.
3510
3511 2012-06-06  Dirk Pranke  <dpranke@chromium.org>
3512
3513         nrwt should look in 'out' for binaries on chromium win to support ninja
3514         https://bugs.webkit.org/show_bug.cgi?id=88273
3515
3516         Reviewed by Tony Chang.
3517
3518         This patch standardizes the search algorithm the chromium ports
3519         use to figure out which driver to run. We will look in a
3520         chromium location before a webkit location (e.g., in
3521         Source/WebKit/chromium/out before out/) and we will look in the
3522         "legacy" directory (xcodebuild) before the directory ninja uses
3523         (out).
3524
3525         Unfortunately due to the way the test code is set up testing the
3526         properly requires some duplication of test code. I will fix that
3527         in a followup patch.
3528
3529         * Scripts/webkitpy/layout_tests/port/chromium.py:
3530         (ChromiumPort):
3531         (ChromiumPort._static_build_path):
3532         (ChromiumPort._build_path):
3533         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3534         (ChromiumLinuxPort):
3535         (ChromiumLinuxPort._determine_driver_path_statically):
3536         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
3537         (ChromiumLinuxPortTest.test_build_path):
3538         (ChromiumLinuxPortTest):
3539         (ChromiumLinuxPortTest.test_driver_name_option):
3540         (ChromiumLinuxPortTest.path_to_image_diff):
3541         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3542         (ChromiumMacPort):
3543         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
3544         (ChromiumMacPortTest.test_build_path):
3545         (ChromiumMacPortTest):
3546         (ChromiumMacPortTest.test_driver_name_option):
3547         (ChromiumMacPortTest.path_to_image_diff):
3548         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3549         (ChromiumPortTest.test_overrides_and_builder_names):
3550         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3551         (ChromiumWinPort):
3552         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3553         (ChromiumWinTest.test_build_path):
3554         (ChromiumWinTest.test_operating_system):
3555         (ChromiumWinTest):
3556         (ChromiumWinTest.test_driver_name_option):
3557         (ChromiumWinPortTest.path_to_image_diff):
3558         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3559         (PortTestCase.assert_build_path):
3560
3561 2012-06-06  Jessie Berlin  <jberlin@apple.com>
3562
3563         Remove very red Windows WebKit2 testers
3564         https://bugs.webkit.org/show_bug.cgi?id=88452
3565
3566         Reviewed by Steve Falkenburg.
3567
3568         Remove the Windows 7 Release WK2 testers so that the hardware can be repurposed. We are
3569         need to focus on getting the WK1 testers green.
3570
3571         * BuildSlaveSupport/build.webkit.org-config/config.json:
3572
3573 2012-06-06  Dirk Pranke  <dpranke@chromium.org>
3574
3575         get rebaselining tools to kinda work with the skia overrides file
3576         https://bugs.webkit.org/show_bug.cgi?id=88456
3577
3578         Reviewed by Ryosuke Niwa.
3579
3580         Update rebaseline-expectations so that we read in the overrides
3581         when looking for tests to rebaseline, but don't read in the
3582         overrides when we are writing the expectations file back out.
3583         This prevents the overrides from getting written into the main
3584         file. This is kind of a hack but will have to do until we
3585         support multiple expectations files properly.
3586
3587         * Scripts/webkitpy/tool/commands/rebaseline.py:
3588         (RebaselineExpectations._expectations):
3589         (RebaselineExpectations._update_expectations_file):
3590         (RebaselineExpectations._tests_to_rebaseline):
3591         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3592         (test_overrides_are_included_correctly):
3593
3594 2012-06-06  Dirk Pranke  <dpranke@chromium.org>
3595
3596         webkitpy: two manager_worker_broker_unittest tests are broken
3597         https://bugs.webkit.org/show_bug.cgi?id=88445
3598
3599         Reviewed by Ojan Vafai.
3600
3601         These tests were never updated when we removed the
3602         --worker-model argument, and we were passing 'inline' instead of
3603         1 (for the number of workers) :(. As a result we were creating
3604         multiprocessing queues unnecessarily and that was failing on cygwin.
3605
3606         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
3607         (InterfaceTest.test_managerconnection_is_abstract):
3608         (InterfaceTest.test_workerconnection_is_abstract):
3609
3610 2012-06-06  Ryosuke Niwa  <rniwa@webkit.org>
3611
3612         REGRESSION(r117789): "webkit-patch rebaseline-expectations" copies contents in skia_test_expectations.txt into test_expectations.txt
3613         https://bugs.webkit.org/show_bug.cgi?id=87406
3614
3615         Reviewed by Dirk Pranke.
3616
3617         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3618         (TestExpectations.__init__):
3619         * Scripts/webkitpy/tool/commands/rebaseline.py:
3620         (RebaselineTest._update_expectations_file):
3621         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3622         (test_rebaseline_does_not_include_overrides):
3623
3624 2012-06-06  Dirk Pranke  <dpranke@chromium.org>
3625
3626         webkitpy: perf tests unit tests fail on chromium win
3627         https://bugs.webkit.org/show_bug.cgi?id=88279
3628
3629         Reviewed by Ryosuke Niwa.
3630
3631         I'm seeing weird failures running the unit tests in my win32
3632         checkout, and we don't really expect webpagereplay to work on
3633         win32 anyway, so I'm skipping the import of that module for now
3634         and adding a warning.
3635
3636         * Scripts/run-perf-tests:
3637         * Scripts/webkitpy/performance_tests/perftest.py:
3638
3639 2012-06-06  Yong Li <yoli@rim.com>
3640
3641         Unreviewed. Update my email address in committers.py.
3642
3643         * Scripts/webkitpy/common/config/committers.py:
3644
3645 2012-06-06  Robert Kroeger  <rjkroege@chromium.org>
3646
3647         Add Robert Kroeger  to commiters.py
3648         https://bugs.webkit.org/show_bug.cgi?id=88415
3649
3650         Unreviewed.
3651
3652         * Scripts/webkitpy/common/config/committers.py:
3653
3654 2012-06-06  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3655
3656         [EFL][DRT] http/tests/globalhistory testcases do not pass
3657         https://bugs.webkit.org/show_bug.cgi?id=82579
3658
3659         Reviewed by Csaba Osztrogonác.
3660
3661         DRT has provided callbacks for ewk_view "global history delegate" signals.
3662
3663         * DumpRenderTree/efl/DumpRenderTree.cpp:
3664         (isGlobalHistoryTest): Aux function to ident global history testcase.
3665         (createLayoutTestController):
3666         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3667         (DumpRenderTreeChrome::createView):
3668         (DumpRenderTreeChrome::onTitleChanged): Handles also some global history testcases.
3669         (DumpRenderTreeChrome::onWebViewNavigatedWithData): New callback function.
3670         (DumpRenderTreeChrome::onWebViewServerRedirect): Ditto.
3671         (DumpRenderTreeChrome::onWebViewClientRedirect): Ditto.
3672         (DumpRenderTreeChrome::onWebViewPopulateVisitedLinks): Ditto.
3673         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
3674         (DumpRenderTreeChrome):
3675
3676 2012-06-06  János Badics  <jbadics@inf.u-szeged.hu>
3677
3678         [Qt] run-qtwebkit-tests hangs with -j1
3679         run-qtwebkit-tests used to hang when wk2 API tests were run with -j1 and --timeout.
3680         This could happen due to an uncancelled timer after results were returned. This timer was
3681         started only if --timeout was set.
3682         https://bugs.webkit.org/show_bug.cgi?id=85475