[EFL] Small clean up in MiniBrowser
[WebKit-https.git] / Tools / ChangeLog
1 2016-08-31  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2
3         [EFL] Small clean up in MiniBrowser
4         https://bugs.webkit.org/show_bug.cgi?id=161428
5
6         Reviewed by Yusuke Suzuki.
7
8         This patch resizes MiniBrowser, add *char* constants for scheme,
9         does line breaking, and remove unnecessary spaces.
10
11         * MiniBrowser/efl/main.c:
12         (on_mouse_wheel):
13         (history_list_hide):
14         (script_execute_callback):
15         (on_key_down):
16         (on_url_changed):
17         (on_error):
18         (on_color_picker_request):
19         (url_from_user_input):
20         (url_load_from_user_input):
21         (on_back_button_clicked):
22         (on_search_case_option_changed):
23         (on_search_word_start_option_changed):
24         (on_list_item_select):
25         (navigation_button_longpress_process):
26         (on_navigation_policy_decision):
27         (window_create):
28         (parse_cookies_policy):
29
30 2016-08-31  Alex Christensen  <achristensen@webkit.org>
31
32         Implement IPv6 parsing in URLParser
33         https://bugs.webkit.org/show_bug.cgi?id=161390
34
35         Reviewed by Darin Adler.
36
37         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
38         (TestWebKitAPI::TEST_F):
39         (TestWebKitAPI::checkURLDifferences):
40
41 2016-08-31  Brady Eidson  <beidson@apple.com>
42
43         WK2 Gamepad provider on iOS.
44         https://bugs.webkit.org/show_bug.cgi?id=161412
45
46         Reviewed by Tim Horton.
47
48         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
49
50 2016-08-30  Ricky Mondello  <rmondello@apple.com>
51
52         YouTubePluginReplacementTest's URL transformation logic should have tests
53         https://bugs.webkit.org/show_bug.cgi?id=161406
54         <rdar://problem/28050847>
55
56         Reviewed by Eric Carlson.
57
58         Add some very basic tests. Future patches should expand on these to find and fix bugs.
59
60         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add YouTubePluginReplacement.cpp.
61         * TestWebKitAPI/Tests/WebCore/YouTubePluginReplacement.cpp: Added.
62         (TestWebKitAPI::test): Added.
63         (TestWebKitAPI::TEST_F): Added.
64
65 2016-08-30  Brady Eidson  <beidson@apple.com>
66
67         GameController.framework backend for gamepad API.
68         https://bugs.webkit.org/show_bug.cgi?id=161086
69
70         Reviewed by Alex Christensen.
71
72         * MiniBrowser/mac/AppDelegate.m:
73         (-[BrowserAppDelegate awakeFromNib]):
74
75         * MiniBrowser/mac/SettingsController.h:
76         * MiniBrowser/mac/SettingsController.m:
77         (-[SettingsController _populateMenu]):
78         (-[SettingsController validateMenuItem:]):
79         (-[SettingsController usesGameControllerFramework]):
80         (-[SettingsController toggleUsesGameControllerFramework:]):
81
82 2016-08-30  Brent Fulgham  <bfulgham@apple.com>
83
84         Use of uninitialised memory in TransformationMatrx::blend4()
85         https://bugs.webkit.org/show_bug.cgi?id=134621
86         <rdar://problem/27337539>
87
88         Reviewed by Dean Jackson.
89
90         Change is based on the Blink change (patch by <alancutter@chromium.org>):
91         <https://src.chromium.org/viewvc/blink?revision=177453&view=revision>
92
93         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
94         * TestWebKitAPI/Tests/WebCore/TransformationMatrix.cpp: Added.
95         (TestWebKitAPI::TEST):
96
97 2016-08-30  Alex Christensen  <achristensen@webkit.org>
98
99         URLParser should handle relative URLs that start with //
100         https://bugs.webkit.org/show_bug.cgi?id=161364
101
102         Reviewed by Darin Adler.
103
104         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
105         (TestWebKitAPI::checkRelativeURL):
106         (TestWebKitAPI::TEST_F):
107
108 2016-08-29  Aakash Jain  <aakash_jain@apple.com>
109
110         EWS patch status page should indicate bot corresponding to each status message
111         https://bugs.webkit.org/show_bug.cgi?id=161280
112
113         Reviewed by Alexey Proskuryakov.
114
115         * QueueStatusServer/templates/patch.html: Formatting changes.
116
117 2016-08-29  Aakash Jain  <aakash_jain@apple.com>
118
119         EWS should indicate which bot processed the patch
120         https://bugs.webkit.org/show_bug.cgi?id=161222
121
122         Reviewed by Alexey Proskuryakov.
123
124         * QueueStatusServer/handlers/statusbubble.py:
125         (StatusBubble._build_bubble): Remove the bot id from bubbles as it is confusing.
126         bot ids are now displayed in patch status page.
127
128 2016-08-29  Alex Christensen  <achristensen@webkit.org>
129
130         URLParser should parse about:blank
131         https://bugs.webkit.org/show_bug.cgi?id=161324
132
133         Reviewed by Brady Eidson.
134
135         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
136         (TestWebKitAPI::TEST_F):
137
138 2016-08-29  JF Bastien  <jfbastien@apple.com>
139
140         Bug 161165 - check-webkit-style doesn't understand macros containing `else` or labels
141         https://bugs.webkit.org/show_bug.cgi?id=161165
142
143         Reviewed by Geoffrey Garen.
144
145         Fix handling of `else` in a macro. Don't handle labels in a macro:
146         the checker is already pretty messy in that area and it should be
147         a rare thing.
148
149         * Scripts/webkitpy/style/checkers/cpp.py:
150         (check_braces):
151         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
152         (CppStyleTest.test_else_clause_not_on_same_line_as_else):
153
154 2016-08-29  Alex Christensen  <achristensen@webkit.org>
155
156         API test URLParserTest.ParserFailures failing ASSERT_NOT_REACHED
157         https://bugs.webkit.org/show_bug.cgi?id=161317
158
159         Reviewed by Brady Eidson.
160
161         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
162         (TestWebKitAPI::TEST_F):
163
164 2016-08-29  Jer Noble  <jer.noble@apple.com>
165
166         Unreviewed gardening; only build MiniBrowser against iOS SDK targets.
167
168         * Makefile:
169
170 2016-08-29  Jonathan Bedard  <jbedard@apple.com>
171
172         Sample Process on notifyDone timed out
173         https://bugs.webkit.org/show_bug.cgi?id=161063
174
175         Reviewed by Darin Adler.
176
177         * Scripts/webkitpy/port/driver.py:
178         (Driver._check_for_driver_timeout): 
179         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Call sample_process during notifyDone timeouts.
180         (WTR::TestRunner::waitToDumpWatchdogTimerFired):
181         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm: Log pid and name for testing harness.
182
183 2016-08-29  Jonathan Bedard  <jbedard@apple.com>
184
185         Check-webkit-style does not work with Objective-C blocks
186         https://bugs.webkit.org/show_bug.cgi?id=161247
187
188         Reviewed by Darin Adler.
189
190         * Scripts/webkitpy/style/checkers/cpp.py:
191         (regex_for_lambda_functions): Changed to regex_for_lambdas_and_blocks.
192         (regex_for_lambdas_and_blocks): Added check for Objective-C blocks.
193         (check_spacing_for_function_call): Pass file state for lambda check.
194         (check_spacing): Pass file state for lambda check.
195         (check_braces): Pass file state for lambda check.
196         (check_style): Pass file state for lambda check.
197         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
198         (CppStyleTest.test_cpp_lambda_functions): Changed from ‘test_lambda_functions’.
199         (CppStyleTest.test_objective_c_block): Tests Objective-C blocks.
200         (CppStyleTest.test_lambda_functions): Changed to ‘test_cpp_lambda_functions’.
201
202 2016-08-29  Aakash Jain  <aakash_jain@apple.com>
203
204         EWS patch status page should indicate bot corresponding to each status message
205         https://bugs.webkit.org/show_bug.cgi?id=161280
206
207         Reviewed by Alexey Proskuryakov.
208
209         * QueueStatusServer/templates/patch.html: Added bot_id in the template so that bot id is displayed
210         for each status message.
211         * QueueStatusServer/stylesheets/common.css:
212         (.status-bot): Added corresponding stylesheet class.
213
214 2016-08-29  Per Arne Vollan  <pvollan@apple.com>
215
216         Attempt to fix Windows build after r205090.
217
218         Unreviewed build fix.
219
220         * DumpRenderTree/win/DRTDataObject.cpp:
221         (cfFileNameWFormat):
222         (cfUrlWFormat):
223
224 2016-08-27  Alex Christensen  <achristensen@webkit.org>
225
226         URLParser should parse relative URLs
227         https://bugs.webkit.org/show_bug.cgi?id=161282
228
229         Reviewed by Darin Adler.
230
231         * TestWebKitAPI/Tests/WTF/StringView.cpp:
232         (TestWebKitAPI::TEST):
233         Added some tests for the new operator=.
234         Test saving iterators, restoring iterators, and even assigning iterators to new CodePoints objects.
235         Using the same iterator to iterate multiple objects is bad practice, but it's possible and now tested.
236         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
237         (TestWebKitAPI::checkURL):
238         (TestWebKitAPI::TEST_F):
239         (TestWebKitAPI::checkRelativeURL):
240         (TestWebKitAPI::checkURLDifferences):
241         (TestWebKitAPI::shouldFail):
242         Add some relative URL tests.
243
244 2016-08-27  Jonathan Bedard  <jbedard@apple.com>
245
246         WTR needs an implementation of setAutomaticLinkDetectionEnabled
247         https://bugs.webkit.org/show_bug.cgi?id=87162
248
249         Reviewed by Darin Adler.
250
251         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Added setAutomaticLinkDetectionEnabled binding.
252         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
253         (WTR::InjectedBundle::beginTesting): Set automatic link detection to false by default.
254         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
255         (WTR::TestRunner::setAutomaticLinkDetectionEnabled): Added setAutomaticLinkDetectionEnabled definition.
256         * WebKitTestRunner/InjectedBundle/TestRunner.h: Added setAutomaticLinkDetectionEnabled declaration.
257
258 2016-08-27  Joseph Pecoraro  <pecoraro@apple.com>
259
260         Web Inspector: Make localizedString.js diff and commit friendly (UTF16 -> UTF8)
261         https://bugs.webkit.org/show_bug.cgi?id=28685
262         <rdar://problem/16460975>
263
264         Reviewed by Darin Adler.
265
266         * Scripts/extract-localizable-js-strings:
267         * Scripts/update-webkit-localizable-strings:
268         WebInspectorUI localizedStrings.js is now UTF-8. Other clients of
269         this script still use UTF-16, so keep that the default.
270
271 2016-08-27  Alexey Proskuryakov  <ap@apple.com>
272
273         REGRESSION (r204052): Popovers on bot watcher's dashboard are broken
274         https://bugs.webkit.org/show_bug.cgi?id=161254
275
276         Reviewed by Darin Adler.
277
278         Simplify the CSS. My understanding that the CSS was correct, and the root cause
279         is tracked in bug 160478.
280
281         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Popover.css:
282
283 2016-08-27  Simon Fraser  <simon.fraser@apple.com>
284
285         Add run-webkit-tests --print-expectations to show expectations for all or a subset of tests
286         https://bugs.webkit.org/show_bug.cgi?id=161217
287
288         Reviewed by Ryosuke Niwa.
289
290         "run-webkit-tests --print-expectations" runs the same logic as running the tests, but
291         dumps out the lists of tests that would be run and skipped, and, for each, the entry
292         in TestExpectations that determines the expected outcome of the test.
293
294         This is an improved version of webkit-patch print-expectations.
295
296         See bug for sample output.
297
298         * Scripts/webkitpy/layout_tests/controllers/manager.py:
299         (Manager._print_expectations_for_subset): Print out the list of tests and expected
300         outcome for some subset of tests.
301         (Manager.print_expectations): Do the same splitting by device class that running tests
302         does, and for each subset of tests, call _print_expectations_for_subset.
303         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
304         (TestExpectationParser.expectation_for_skipped_test): Set the flag
305         expectation_line.not_applicable_to_current_platform
306         (TestExpectationLine.__init__): Init not_applicable_to_current_platform to False
307         (TestExpectationLine.expected_behavior): line.expectation is ['PASS'] by default,
308         even for skipped tests. This function returns a list relevant for display, taking the skipped
309         modifier into account.
310         (TestExpectationLine.create_passing_expectation): expectations is normally a list, not a set.
311         (TestExpectations.readable_filename_and_line_number): Return something printable for 
312         lines with and without filenames
313         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
314         (main): Handle options.print_expectations
315         (parse_args): Add support for --print-expectations
316         (_print_expectations):
317         * Scripts/webkitpy/port/ios.py:
318         (IOSSimulatorPort.default_child_processes): Make this a debug log.
319
320 2016-08-26  Dan Bernstein  <mitz@apple.com>
321
322         Keep trying to fix the build after r205057.
323
324         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
325
326 2016-08-26  Dan Bernstein  <mitz@apple.com>
327
328         Keep trying to fix the build after r205057.
329
330         * MobileMiniBrowser/MobileMiniBrowser/AppDelegate.m: Don’t try to import nonexistent
331           config.h. This file is only meant to be built with Xcode anyway.
332         * MobileMiniBrowser/MobileMiniBrowser/Base.lproj/LaunchScreen.storyboard: Make this compile
333           with Xcode 7.3 and deploy to iOS 9.0.
334         * MobileMiniBrowser/MobileMiniBrowser/Base.lproj/Main.storyboard: Ditto.
335         * MobileMiniBrowser/MobileMiniBrowser/TabViewController.m: Don’t try to import config.h.
336         * MobileMiniBrowser/MobileMiniBrowser/WebViewController.m: Ditto.
337
338 2016-08-26  Dan Bernstein  <mitz@apple.com>
339
340         Start trying to fix the build after r205057.
341
342         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
343
344 2016-08-26  Alexey Proskuryakov  <ap@apple.com>
345
346         Remove Yosemite Leaks from the flakiness dashboard
347         https://bugs.webkit.org/show_bug.cgi?id=161253
348
349         Reviewed by Anders Carlsson.
350
351         * TestResultServer/static-dashboards/builders.jsonp:
352
353 2016-08-26  Sam Weinig  <sam@webkit.org>
354
355         Remove support for ENABLE_LEGACY_WEB_AUDIO
356         https://bugs.webkit.org/show_bug.cgi?id=161262
357
358         Reviewed by Anders Carlsson.
359
360         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
361
362 2016-08-26  Jer Noble  <jer.noble@apple.com>
363
364         Add a test harness for running UI tests on the iOS Simulator
365         https://bugs.webkit.org/show_bug.cgi?id=161265
366
367         Reviewed by Simon Fraser.
368
369         Add a new iOS Simulator application which uses WKWebView to implement a basic browser, and which
370         can serve as a test harness for WebKit UI tests.
371
372         Also add a basic media playback test which verifies that a <video> element will begin playing in
373         fullscreen on an iPhone device, but will play inline on an iPad device.
374
375         * Makefile: Add MobileMiniBrowser as a Module for iOS builds.
376         * MobileMiniBrowser/Configurations/Base.xcconfig: Added.
377         * MobileMiniBrowser/Configurations/DebugRelease.xcconfig: Added.
378         * MobileMiniBrowser/Configurations/MobileMiniBrowser.xcconfig: Added.
379         * MobileMiniBrowser/Makefile: Added.
380         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj: Added.
381         * MobileMiniBrowser/MobileMiniBrowser/AppDelegate.h: Added.
382         * MobileMiniBrowser/MobileMiniBrowser/AppDelegate.m: Added.
383         (-[AppDelegate application:didFinishLaunchingWithOptions:]):
384         (-[AppDelegate applicationWillResignActive:]):
385         (-[AppDelegate applicationDidEnterBackground:]):
386         (-[AppDelegate applicationWillEnterForeground:]):
387         (-[AppDelegate applicationDidBecomeActive:]):
388         (-[AppDelegate applicationWillTerminate:]):
389         * MobileMiniBrowser/MobileMiniBrowser/Assets.xcassets/AppIcon.appiconset/Contents.json: Added.
390         * MobileMiniBrowser/MobileMiniBrowser/Base.lproj/LaunchScreen.storyboard: Added.
391         * MobileMiniBrowser/MobileMiniBrowser/Base.lproj/Main.storyboard: Added.
392         * MobileMiniBrowser/MobileMiniBrowser/Info.plist: Added.
393         * MobileMiniBrowser/MobileMiniBrowser/TabViewController.h: Added.
394         * MobileMiniBrowser/MobileMiniBrowser/TabViewController.m: Added.
395         (-[TabViewController dealloc]):
396         (-[TabViewController viewDidLoad]):
397         (-[TabViewController observeValueForKeyPath:ofObject:change:context:]):
398         (-[TabViewController tableView:cellForRowAtIndexPath:]):
399         (-[TabViewController tableView:numberOfRowsInSection:]):
400         (-[TabViewController numberOfSectionsInTableView:]):
401         (-[TabViewController tableView:canEditRowAtIndexPath:]):
402         (-[TabViewController tableView:canMoveRowAtIndexPath:]):
403         (-[TabViewController tableView:commitEditingStyle:forRowAtIndexPath:]):
404         (-[TabViewController tableView:didSelectRowAtIndexPath:]):
405         * MobileMiniBrowser/MobileMiniBrowser/WebViewController.h: Added.
406         * MobileMiniBrowser/MobileMiniBrowser/WebViewController.m: Added.
407         (-[WebViewController viewDidLoad]):
408         (-[WebViewController didReceiveMemoryWarning]):
409         (-[WebViewController reload:]):
410         (-[WebViewController goBack:]):
411         (-[WebViewController goForward:]):
412         (-[WebViewController urlFieldEditingBegan:]):
413         (-[WebViewController navigateTo:]):
414         (-[WebViewController showTabs:]):
415         (-[WebViewController selectWebViewAtIndex:]):
416         (-[WebViewController removeWebViewAtIndex:]):
417         (-[WebViewController addWebView]):
418         (-[WebViewController createWebView]):
419         (-[WebViewController removeWebView:]):
420         (-[WebViewController setCurrentWebView:]):
421         (-[WebViewController webView:didFailNavigation:withError:]):
422         (-[WebViewController observeValueForKeyPath:ofObject:change:context:]):
423         * MobileMiniBrowser/MobileMiniBrowser/main.m: Added.
424         (main):
425         * MobileMiniBrowser/MobileMiniBrowserUITests/Info.plist: Added.
426         * MobileMiniBrowser/MobileMiniBrowserUITests/MobileMiniBrowserUITests.m: Added.
427         (-[MobileMiniBrowserUITests setUp]):
428         (-[MobileMiniBrowserUITests tearDown]):
429         (-[MobileMiniBrowserUITests testBasicVideoPlayback]):
430
431 2016-08-26  Aakash Jain  <aakash_jain@apple.com>
432
433         webkit-queues queue-status page should should list more recent statuses
434         https://bugs.webkit.org/show_bug.cgi?id=161220
435
436         Reviewed by Daniel Bates.
437
438         * QueueStatusServer/handlers/queuestatus.py:
439         (QueueStatus._fetch_statuses): Increase the number of recent statuses from 15 to 50.
440
441 2016-08-26  Dan Bernstein  <mitz@apple.com>
442
443         [Cocoa] Infinite recursion calling -charValue on a WKNSNumber
444         https://bugs.webkit.org/show_bug.cgi?id=161258
445
446         Reviewed by Anders Carlsson.
447
448         * TestWebKitAPI/Tests/WebKit2Cocoa/WKNSNumber.mm:
449         (TestWebKitAPI::TEST):
450
451 2016-08-26  Csaba Osztrogonác  <ossy@webkit.org>
452
453         Fix the ENABLE(WEBASSEMBLY) build on Linux
454         https://bugs.webkit.org/show_bug.cgi?id=161197
455
456         Reviewed by Mark Lam.
457
458         * Scripts/build-jsc:
459
460 2016-08-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
461
462         [GTK] run-gtk-tests should use the driver environment for checking the accessibility bus
463         https://bugs.webkit.org/show_bug.cgi?id=161149
464
465         Reviewed by Carlos Garcia Campos.
466
467         Add a new function for waiting for the accesibility bus. It sets
468         the test environment variables before starting the GLib mainloop.
469         And restores the previous environment after it has finished.
470         It also adds a timeout (5 seconds) to abort in case it has not
471         been able to detect the accesibility bus before the timeout expires.
472
473         * Scripts/run-gtk-tests:
474         (TestRunner):
475         (TestRunner._wait_for_accessibility_bus):
476         (TestRunner._wait_for_accessibility_bus.timeout_accessibility_bus):
477         (TestRunner._start_accessibility_daemons):
478         (TestRunner._get_tests_from_google_test_suite): Run this command also with the driver test environment.
479
480 2016-08-26  Per Arne Vollan  <pvollan@apple.com>
481
482         [Win] Warning fix.
483         https://bugs.webkit.org/show_bug.cgi?id=161236
484
485         Reviewed by Brent Fulgham.
486
487         The & operator in the Test struct has no body.
488
489         * TestWebKitAPI/Tests/WTF/Vector.cpp:
490         (TestWebKitAPI::TEST):
491
492 2016-08-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
493
494         [GTK] run-gtk-tests should use webkitpy.port.gtk and webkitpy.port.xvfbdriver
495         https://bugs.webkit.org/show_bug.cgi?id=160736
496
497         Reviewed by Carlos Garcia Campos.
498
499         This plugs run-gtk-tests into the webkitpy testing infrastructure.
500         As a benefit of this, run-gtk-tests now can be executed over any of
501         the existing supported gtk test display servers (xvfb, weston-over-xvfb,
502         or native xorg). A new command line switch --wayland is added for
503         run-gtk-tests.
504
505         * Scripts/run-gtk-tests:
506         (TestRunner.__init__): Remove the --display command line switch, its not longer useful.
507         Add a --wayland command line switch.
508         (TestRunner._start_accessibility_daemons):
509         (TestRunner):
510         (TestRunner.__init__):
511         (TestRunner._run_xvfb): Deleted.
512         (TestRunner._create_driver):
513         (TestRunner._setup_testing_environment): Delete the environment variable definitions that
514         are now done by driver._setup_environ_for_test().
515         (TestRunner._tear_down_testing_environment):
516         * Scripts/webkitpy/port/driver.py:
517         (Driver.__init__): Define self._server_name in the constructor of the base class.
518         It is used by several functions, so it makes sense to store once the value here.
519         (Driver._setup_environ_for_test): Factorize setting the environment for a given test.
520         (Driver._start): Get the environment from self._setup_environ_for_test()
521         * Scripts/webkitpy/port/driver_unittest.py:
522         (DriverTest):
523         (DriverTest.test_setup_environ_for_test): Add unittest for driver._setup_environ_for_test()
524         * Scripts/webkitpy/port/gtk.py: Move the inspection of the env var USE_NATIVE_XDISPLAY to the constructor.
525         (GtkPort.__init__):
526         (GtkPort._driver_class):
527         * Scripts/webkitpy/port/westondriver.py: Define and use self._setup_environ_for_test()
528         (WestonDriver._setup_environ_for_test):
529         (WestonDriver._start):
530         * Scripts/webkitpy/port/xorgdriver.py: Define and use self._setup_environ_for_test()
531         (XorgDriver._setup_environ_for_test):
532         (XorgDriver._start):
533         * Scripts/webkitpy/port/xvfbdriver.py: Define and use self._setup_environ_for_test()
534         (XvfbDriver._setup_environ_for_test):
535         (XvfbDriver._start):
536
537 2016-08-26  Csaba Osztrogonác  <ossy@webkit.org>
538
539         [EFL][GTK] REGRESSION(204877): Fix the clean build
540         https://bugs.webkit.org/show_bug.cgi?id=161240
541
542         Reviewed by Carlos Garcia Campos.
543
544         * WebKitTestRunner/PlatformEfl.cmake:
545         * WebKitTestRunner/PlatformGTK.cmake:
546
547 2016-08-26  Aakash Jain  <aakash_jain@apple.com>
548
549         EWS should indicate which bot processed the patch
550         https://bugs.webkit.org/show_bug.cgi?id=161222
551
552         Reviewed by Daniel Bates.
553
554         * QueueStatusServer/handlers/statusbubble.py:
555         (StatusBubble._build_bubble): Display the bot id in status bubble. Also removed "Started processing" message since
556         after bug fix of 161223, bots send the "Started processing patch" message and it would be displayed in Recent messages.
557         Also added "Started processing patch" message to progress_statuses.
558         I might consider displaying bot id in other statuses as well later on.
559
560 2016-08-26  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
561
562         [EFL] Change homepage url to www.ewebkit.org on MiniBrowser
563         https://bugs.webkit.org/show_bug.cgi?id=161184
564
565         Reviewed by Carlos Garcia Campos.
566
567         * MiniBrowser/efl/main.c: Set www.ewebkit.org.
568
569 2016-08-25  Aakash Jain  <aakash_jain@apple.com>
570
571         ews queues should update status server when they start processing patch
572         https://bugs.webkit.org/show_bug.cgi?id=161223
573
574         Reviewed by Daniel Bates.
575
576         * Scripts/webkitpy/tool/commands/queues.py:
577         (AbstractReviewQueue.process_work_item): Update status server that the bot started processing the patch.
578         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
579         (EarlyWarningSystemTest._default_expected_logs): Updated the unit test accordingly.
580         * Scripts/webkitpy/tool/commands/queues_unittest.py:
581         (StyleQueueTest.test_style_queue_with_style_exception): Same.
582         (test_style_queue_with_watch_list_exception): Same.
583         (test_non_valid_patch): Same.
584
585 2016-08-25  Alex Christensen  <achristensen@webkit.org>
586
587         CMake build fix.
588
589         * DumpRenderTree/PlatformMac.cmake:
590
591 2016-08-25  Alex Christensen  <achristensen@webkit.org>
592
593         Fix URLParserTest with GuardMalloc
594         https://bugs.webkit.org/show_bug.cgi?id=161214
595         rdar://problem/28014390
596
597         Reviewed by Tim Horton.
598
599         The CString returned by String::utf8 was going out of scope before we were doing a string comparison on its data.
600         This just does the comparison of the CStrings instead to keep them in scope during the comparison.
601
602         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
603         (TestWebKitAPI::eq):
604         (TestWebKitAPI::checkURL):
605         (TestWebKitAPI::checkURLDifferences):
606         (TestWebKitAPI::s): Deleted.
607
608 2016-08-25  Wenson Hsieh  <wenson_hsieh@apple.com>
609
610         Dragging against the end of the inline media scrubber causes the media scrubber to hide
611         https://bugs.webkit.org/show_bug.cgi?id=161207
612
613         Reviewed by Eric Carlson.
614
615         Tweaks an existing WebKit API test covering this behavior change. After some discussion, rather than hide media
616         controls in this case, we should actually continue showing them. This is because seeking due to user gestures
617         similar to "scrubbing" are indistinguishable from gestures that immediately seek to the end.
618
619         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
620         (TestWebKitAPI::TEST):
621
622 2016-08-25  Daniel Bates  <dabates@apple.com>
623
624         Watch more things.
625
626         * Scripts/webkitpy/common/config/watchlist:
627
628 2016-08-25  Daniel Bates  <dabates@apple.com>
629
630         Fix test failure on GTK Linux bots after <http://trac.webkit.org/changeset/204695>
631         (https://bugs.webkit.org/show_bug.cgi?id=148437)
632
633         Remove use of module File::Slurp as it is not part of the standard Perl 5 distribution
634         and is not installed on the GTK Linux bots.
635
636         * Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl:
637         (writeFileWithContent): Added.
638
639 2016-08-25  Per Arne Vollan  <pvollan@apple.com>
640
641         [Win] run-api-tests is failing.
642         https://bugs.webkit.org/show_bug.cgi?id=161140
643
644         Reviewed by Brent Fulgham.
645
646         Since the move constructor is called 3 more times on Windows, we will have 3 more destructor calls.
647
648         * TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp:
649         (TestWebKitAPI::TEST):
650
651 2016-08-24  Per Arne Vollan  <pvollan@apple.com>
652
653         [Win] run-api-tests is failing.
654         https://bugs.webkit.org/show_bug.cgi?id=161140
655
656         Reviewed by Brent Fulgham.
657
658         The number of times the move constructor is called is different on Windows in this test. This seems
659         to be caused by differences in MSVC's implementation of lambdas or std functions like std::make_tuple.
660
661         * TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp:
662         (TestWebKitAPI::TEST):
663
664 2016-08-24  Simon Fraser  <simon.fraser@apple.com>
665
666         Fix iOS DRT build.
667
668         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
669         (WTR::UIScriptController::zoomToScale):
670
671 2016-08-24  Simon Fraser  <simon.fraser@apple.com>
672
673         [iOS DRT] Hook up uiController.zoomToScale() for DRT
674         https://bugs.webkit.org/show_bug.cgi?id=161173
675
676         Reviewed by Tim Horton.
677         
678         Make a UIWebScrollView subclass, DumpRenderTreeWebScrollView, which has an internal delegate to get
679         UIScrollView delegate callbacks. Store the zoomToScaleCompletionHandler on it.
680         
681         UIScriptController::zoomToScale() has to bounce the zoom to the main thread (no poking UIKit from
682         the WebThread!), but queue up the callback first.
683
684         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
685         * DumpRenderTree/ios/DumpRenderTreeBrowserView.mm:
686         (-[DumpRenderTreeWebScrollView initWithFrame:]):
687         (-[DumpRenderTreeWebScrollView dealloc]):
688         (-[DumpRenderTreeWebScrollView zoomToScale:animated:completionHandler:]):
689         (-[DumpRenderTreeWebScrollView completedZoomToScale]):
690         (-[DumpRenderTreeWebScrollViewDelegate initWithScrollView:]):
691         (-[DumpRenderTreeWebScrollViewDelegate viewForZoomingInScrollView:]): All UIScrollView delegates need to implement this.
692         (-[DumpRenderTreeWebScrollViewDelegate scrollViewDidEndZooming:withView:atScale:]):
693         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
694         (WTR::UIScriptController::zoomToScale):
695         * DumpRenderTree/mac/DumpRenderTree.mm:
696         (createWebViewAndOffscreenWindow):
697         * TestRunnerShared/UIScriptContext/UIScriptController.h:
698         (WTR::UIScriptController::context):
699
700 2016-08-24  Ryan Haddad  <ryanhaddad@apple.com>
701
702         Attempt to fix Windows build after r204918.
703
704         Unreviewed build fix.
705
706         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
707         (ResourceLoadDelegate::willSendRequest):
708
709 2016-08-24  Simon Fraser  <simon.fraser@apple.com>
710
711         [iOS DRT] Get basic viewport tests working in DRT
712         https://bugs.webkit.org/show_bug.cgi?id=161160
713
714         Reviewed by Tim Horton.
715         
716         Hook up enough of UIScriptController in iOS DRT to be able to read viewport
717         scale, and get the contentVisibleRect.
718         
719         Requires exposing a bit of UIWebBrowserView SPI from UIKit, which in turn
720         requires typing the gWebBrowserView as a DumpRenderTreeBrowserView * everywhere.
721         
722         One test has different results between DRT and WTR, but DRT behavior seems to differ
723         from UIWebView here, so just give it a WK1-specific result.
724
725         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
726         * DumpRenderTree/ios/DumpRenderTreeBrowserView.mm:
727         (-[DumpRenderTreeBrowserView documentVisibleRect]):
728         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
729         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
730         (WTR::UIScriptController::zoomScale):
731         (WTR::UIScriptController::minimumZoomScale):
732         (WTR::UIScriptController::maximumZoomScale):
733         (WTR::UIScriptController::contentVisibleRect):
734         * DumpRenderTree/mac/DumpRenderTree.mm:
735         (createWebViewAndOffscreenWindow):
736         * DumpRenderTree/mac/DumpRenderTreeMac.h:
737
738 2016-08-24  Simon Fraser  <simon.fraser@apple.com>
739
740         Minor project rearrangement.
741
742         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
743
744 2016-08-24  Simon Fraser  <simon.fraser@apple.com>
745
746         [iOS DRT] Make iOS DRT use the same window size as WebKitTestRunner for flexible viewport tests
747         https://bugs.webkit.org/show_bug.cgi?id=161124
748
749         Reviewed by Daniel Bates.
750         
751         Use the main UIScreen's bounds for the size of the window in flexible viewport mode,
752         and remove the 'phoneBrowserAddressBarOffset' hack, so that it matches WTR.
753         
754         Remove some unnecessary zero initializations of static variables.
755         
756         Change _setVisibleSize to use the window size, which should not be a behavior change
757         because this it just used for text autosizing, which is disabled by default,
758         and only the width is consulted.
759
760         * DumpRenderTree/mac/DumpRenderTree.mm:
761         (adjustWebDocumentForFlexibleViewport):
762         (adjustWebDocumentForStandardViewport):
763         (createWebViewAndOffscreenWindow):
764
765 2016-08-24  Jonathan Bedard  <jbedard@apple.com>
766
767         WebKit2 needs layoutTestController.setDeferMainResourceDataLoad
768         https://bugs.webkit.org/show_bug.cgi?id=42777
769
770         Reviewed by Darin Adler.
771
772         The setDeferMainResourceDataLoad method was not correctly tested in DumpRenderTree and would pass even when setDeterMainResourceDataLoad was not called.  Removed function and test.
773
774         * DumpRenderTree/TestRunner.cpp:
775         (setDeferMainResourceDataLoadCallback): Removed setDeferMainResourceDataLoad.
776         * DumpRenderTree/TestRunner.h:
777         (TestRunner::deferMainResourceDataLoad): Ditto.
778         (TestRunner::setDeferMainResourceDataLoad): Ditto.
779         * DumpRenderTree/mac/ResourceLoadDelegate.mm: Ditto.
780
781 2016-08-23  Anders Carlsson  <andersca@apple.com>
782
783         Add enum traits and use them in the IPC::Decoder
784         https://bugs.webkit.org/show_bug.cgi?id=161103
785
786         Reviewed by Sam Weinig.
787
788         Add API test.
789
790         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
791         * TestWebKitAPI/Tests/WTF/EnumTraits.cpp: Added.
792         (TestWebKitAPI::TEST):
793
794 2016-08-24  Filip Pizlo  <fpizlo@apple.com>
795
796         Unreviewed, roll out r204901, r204897, r204866, r204856, r204854.
797
798         * DumpRenderTree/TestRunner.cpp:
799         * DumpRenderTree/mac/DumpRenderTree.mm:
800         (DumpRenderTreeMain):
801         * Scripts/run-jsc-stress-tests:
802         * TestWebKitAPI/Tests/WTF/Vector.cpp:
803         (TestWebKitAPI::TEST):
804
805 2016-08-24  Simon Fraser  <simon.fraser@apple.com>
806
807         Try to fix Production builds.
808         
809         PRODUCTION_FRAMEWORKS_DIR was undefined here.
810
811         * DumpRenderTree/mac/Configurations/Base.xcconfig:
812
813 2016-08-24  Dan Bernstein  <mitz@apple.com>
814
815         Add a convenience function for creating a WKFrameHandleRef from a WKFrameRef without going through WKFrameInfoRef
816         https://bugs.webkit.org/show_bug.cgi?id=161152
817
818         Reviewed by Anders Carlsson.
819
820         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
821         * TestWebKitAPI/Tests/WebKit2/FrameHandle.cpp: Added.
822         (TestWebKitAPI::didFinishLoadForFrame):
823         (TestWebKitAPI::TEST):
824
825 2016-08-24  Nan Wang  <n_wang@apple.com>
826
827         AX: Add test for line text marker range on iOS
828         https://bugs.webkit.org/show_bug.cgi?id=161108
829         <rdar://problem/27976405>
830
831         Reviewed by Chris Fleizach.
832
833         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
834         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
835         (AccessibilityUIElement::textMarkerRangeForElement):
836         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
837         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
838         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
839
840 2016-08-24  Per Arne Vollan  <pvollan@apple.com>
841
842         [Win] Warning fixes.
843         https://bugs.webkit.org/show_bug.cgi?id=161079
844
845         Reviewed by Brent Fulgham.
846
847         * MiniBrowser/win/WebDownloadDelegate.cpp:
848         * MiniBrowser/win/WinMain.cpp:
849         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
850         (TestWebKitAPI::TEST):
851
852 2016-08-23  Simon Fraser  <simon.fraser@apple.com>
853
854         Fix Windows DRT build.
855
856         * DumpRenderTree/win/TestRunnerWin.cpp:
857         (TestRunner::mainFrameJSContext):
858
859 2016-08-23  Simon Fraser  <simon.fraser@apple.com>
860
861         Try to fix Windows build.
862         
863         Pass Tools/DumpRenderTree/Bindings as the working directory for the generate_bindings.pl
864         so that perl finds CodeGeneratorDumpRenderTree.pm.
865
866         * DumpRenderTree/CMakeLists.txt:
867
868 2016-08-23  Simon Fraser  <simon.fraser@apple.com>
869
870         Hook up UIScriptController in DumpRenderTree
871         https://bugs.webkit.org/show_bug.cgi?id=161064
872
873         Reviewed by Sam Weinig.
874
875         Add a skeleton implementation of UIScriptController to DumpRenderTree, building for both
876         Mac and iOS. Currently this is sufficient to test doAsyncTask(), enabling two tests
877         in fast/harness which test this.
878
879         Add a DerivedSources target to DumpRenderTree to invoke DerivedSources.make.
880
881         Move related code shared between WTR and DRT into Tools/TestRunnerShared, and cleanse it of
882         WK2-isms. Fix the makefiles to refer to the new location.
883
884         Hook up TestRunner::runUIScript() for DumpRenderTree, which requires keeping track of callbacks
885         by ID and firing them once they are complete.
886
887         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm: Added (copied from WTR).
888         * DumpRenderTree/CMakeLists.txt:
889         * DumpRenderTree/DerivedSources.make: Copied from Tools/WebKitTestRunner/DerivedSources.make.
890         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
891         * DumpRenderTree/TestRunner.cpp:
892         (runUIScriptCallback):
893         (TestRunner::staticFunctions):
894         (TestRunner::cacheTestRunnerCallback):
895         (TestRunner::callTestRunnerCallback):
896         (TestRunner::clearTestRunnerCallbacks):
897         (nextUIScriptCallbackID):
898         (TestRunner::runUIScript):
899         (TestRunner::callUIScriptCallback):
900         (TestRunner::uiScriptDidComplete):
901         (TestRunner::cleanup):
902         * DumpRenderTree/TestRunner.h:
903         * DumpRenderTree/ios/UIScriptControllerIOS.mm: Added.
904         * DumpRenderTree/mac/Configurations/Base.xcconfig: DerivedSources.make needs WEBCORE_PRIVATE_HEADERS_DIR to be defined.
905         * DumpRenderTree/mac/DumpRenderTree.mm:
906         (runTest):
907         * DumpRenderTree/mac/TestRunnerMac.mm:
908         (TestRunner::mainFrameJSContext):
909         * DumpRenderTree/mac/UIScriptControllerMac.mm: Copied from Tools/WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h.
910         (WTR::UIScriptController::doAsyncTask):
911         * DumpRenderTree/win/DumpRenderTree.cpp:
912         * TestRunnerShared/Bindings/JSWrappable.h: Renamed from Tools/WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h.
913         (WTR::JSWrappable::~JSWrappable):
914         (WTR::JSValueMakeStringOrNull):
915         * TestRunnerShared/Bindings/JSWrapper.cpp: Renamed from Tools/WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp.
916         (WTR::JSWrapper::wrap):
917         (WTR::JSWrapper::unwrap):
918         (WTR::unwrapObject):
919         (WTR::JSWrapper::initialize):
920         (WTR::JSWrapper::finalize):
921         * TestRunnerShared/Bindings/JSWrapper.h: Renamed from Tools/WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h.
922         (WTR::toJS):
923         (WTR::setProperty):
924         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl: Renamed from Tools/WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl.
925         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp: Renamed from Tools/WebKitTestRunner/UIScriptContext/UIScriptContext.cpp.
926         * TestRunnerShared/UIScriptContext/UIScriptContext.h: Renamed from Tools/WebKitTestRunner/UIScriptContext/UIScriptContext.h.
927         (WTR::UIScriptContext::currentParentCallbackIsPendingCompletion):
928         * TestRunnerShared/UIScriptContext/UIScriptController.cpp: Renamed from Tools/WebKitTestRunner/UIScriptContext/UIScriptController.cpp.
929         * TestRunnerShared/UIScriptContext/UIScriptController.h: Renamed from Tools/WebKitTestRunner/UIScriptContext/UIScriptController.h.
930         * WebKitTestRunner/CMakeLists.txt:
931         * WebKitTestRunner/DerivedSources.make:
932         * WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h:
933         (WTR::JSWrappable::~JSWrappable): Deleted.
934         (WTR::JSValueMakeStringOrNull): Deleted.
935         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp:
936         (WTR::JSWrapper::wrap): Deleted.
937         (WTR::JSWrapper::unwrap): Deleted.
938         (WTR::unwrapObject): Deleted.
939         (WTR::JSWrapper::initialize): Deleted.
940         (WTR::JSWrapper::finalize): Deleted.
941         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h:
942         (WTR::toJS): Deleted.
943         (WTR::setProperty): Deleted.
944         * WebKitTestRunner/TestInvocation.cpp:
945         (WTR::TestInvocation::runUISideScript):
946         (WTR::TestInvocation::uiScriptDidComplete):
947         * WebKitTestRunner/TestInvocation.h:
948         * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp: Moved
949         * WebKitTestRunner/UIScriptContext/UIScriptContext.h: Moved
950         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp: Moved
951         * WebKitTestRunner/UIScriptContext/UIScriptController.h: Moved
952         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
953         * WebKitTestRunner/config.h:
954         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
955         (WTR::UIScriptController::contentVisibleRect):
956
957 2016-08-23  Saam Barati  <sbarati@apple.com>
958
959         JSC should have a "microbenchmarks" directory instead of "regress" directory
960         https://bugs.webkit.org/show_bug.cgi?id=161096
961
962         Rubber stamped by Mark Lam.
963
964         This patch moves LayoutTests/js/regress/script-tests to the JSTests/microbenchmarks
965         directory and removes all the related html and txt files. I did this because
966         that directory was only there for microbenchmarks, and not for "regression"
967         tests. I also changed the various scripts to point to it.
968
969         * Scripts/run-javascriptcore-tests:
970         (runJSCStressTests):
971         * Scripts/run-jsc-benchmarks:
972
973 2016-08-23  Alex Christensen  <achristensen@webkit.org>
974
975         Fix EFL build.
976
977         * TestWebKitAPI/CMakeLists.txt:
978         Include new directory.
979
980 2016-08-22  Filip Pizlo  <fpizlo@apple.com>
981
982         Butterflies should be allocated in Auxiliary MarkedSpace instead of CopiedSpace and we should rewrite as much of the GC as needed to make this not a regression
983         https://bugs.webkit.org/show_bug.cgi?id=160125
984
985         Reviewed by Geoffrey Garen.
986
987         * DumpRenderTree/TestRunner.cpp: Rewire some #includes.
988         * Scripts/run-jsc-stress-tests: New test flag!
989
990 2016-08-23  Brady Eidson  <beidson@apple.com>
991
992         WK2 Gamepad layout test support.
993         https://bugs.webkit.org/show_bug.cgi?id=134671
994
995         Reviewed by Alex Christensen.
996         
997         Have the injected bundle expose the MockGamepadProvider to the UI process, which will then 
998         feed back into the UIGamepadProvider.
999         
1000         Also, fool NSApplication into treating the most recently created "isKeyWindow" of the test windows
1001         as the actual keyWindow for the test runner, which will allow the view to get gamepad updates.
1002
1003         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
1004         
1005         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1006         (WTR::TestRunner::setMockGamepadDetails):
1007         (WTR::TestRunner::setMockGamepadAxisValue):
1008         (WTR::TestRunner::setMockGamepadButtonValue):
1009         
1010         * WebKitTestRunner/PlatformWebView.h:
1011         
1012         * WebKitTestRunner/TestController.cpp:
1013         (WTR::TestController::initialize):
1014         
1015         * WebKitTestRunner/TestInvocation.cpp:
1016         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1017         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Deleted.
1018         
1019         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1020         
1021         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1022         (-[WebKitTestRunnerWindow initWithFrame:]):
1023         (-[WebKitTestRunnerWindow dealloc]):
1024         (WTR::PlatformWebView::keyWindow):
1025         
1026         * WebKitTestRunner/ios/TestControllerIOS.mm:
1027         (WTR::wtr_NSApplication_keyWindow):
1028         (WTR::TestController::platformInitialize):
1029         
1030         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1031         (+[WebKitTestRunnerWindow _WTR_keyWindow]):
1032         (-[WebKitTestRunnerWindow initWithContentRect:styleMask:backing:defer:]):
1033         (-[WebKitTestRunnerWindow dealloc]):
1034         (WTR::PlatformWebView::keyWindow):
1035         
1036         * WebKitTestRunner/mac/TestControllerMac.mm:
1037         (WTR::wtr_NSApplication_keyWindow):
1038         (WTR::TestController::platformInitialize):
1039         * WebKitTestRunner/mac/main.mm:
1040
1041 2016-08-23  Alexey Proskuryakov  <ap@apple.com>
1042
1043         REGRESSION (PHP 5.6): http/tests/misc/bad-charset-alias.html fails
1044         https://bugs.webkit.org/show_bug.cgi?id=161047
1045         rdar://problem/27434307
1046
1047         Reviewed by Lucas Forschler.
1048
1049         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py: Specify a php.ini file.
1050
1051 2016-08-23  Chris Dumez  <cdumez@apple.com>
1052
1053         Unreviewed, rolling out r204243.
1054
1055         Caused some layout test failures
1056
1057         Reverted changeset:
1058
1059         "Write API test to cover crash fix in r204135"
1060         https://bugs.webkit.org/show_bug.cgi?id=160587
1061         http://trac.webkit.org/changeset/204243
1062
1063 2016-08-23  Rawinder Singh  <rawinder.singh-webkit@cisra.canon.com.au>
1064
1065         Order feature option list in FeatureList.pm
1066         https://bugs.webkit.org/show_bug.cgi?id=161074
1067
1068         Reviewed by Michael Catanzaro.
1069
1070         Reorder features in alphabetical order based on command line option. Also, sort variables in alphabetical order.
1071
1072         * Scripts/webkitperl/FeatureList.pm:
1073
1074 2016-08-22  Dewei Zhu  <dewei_zhu@apple.com>
1075
1076         Stop python icon bouncing in the dock while running browser benchmarks.
1077         https://bugs.webkit.org/show_bug.cgi?id=161066
1078
1079         Reviewed by Ryosuke Niwa.
1080
1081         Bouncing python icon may impact browser benchmark results.
1082         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1083         (OSXBrowserDriver.prepare_env):
1084         (OSXBrowserDriver.restore_env):
1085
1086 2016-08-22  Simon Fraser  <simon.fraser@apple.com>
1087
1088         <select> menu on iPad causes shifting of hit-testing areas
1089         https://bugs.webkit.org/show_bug.cgi?id=150079
1090
1091         Reviewed by Tim Horton.
1092
1093         -isAssistingNode (aka the poorly named isEditable) is input into WebPageProxy::computeCustomFixedPositionRect(),
1094         so when it changes we have to update visible rects. We were doing this on focus, but failing
1095         to do it on blur.
1096
1097         Added the ability to test by:
1098         1. Making it possible to initiate an animated scroll in the UI process
1099         2. Adding callbacks for starting and ending interaction with a form control. Sadly
1100         the "ending interaction" for <select> popovers on iPad isn't late enough, since we
1101         have no way currently to know when the dimming view behind the popover animates out,
1102         so for now the test keeps trying to tap a button.
1103
1104         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
1105         * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
1106         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
1107         (WTR::UIScriptController::setDidStartFormControlInteractionCallback):
1108         (WTR::UIScriptController::didStartFormControlInteractionCallback):
1109         (WTR::UIScriptController::setDidEndFormControlInteractionCallback):
1110         (WTR::UIScriptController::didEndFormControlInteractionCallback):
1111         (WTR::UIScriptController::scrollToOffset):
1112         (WTR::UIScriptController::platformSetDidStartFormControlInteractionCallback):
1113         (WTR::UIScriptController::platformSetDidEndFormControlInteractionCallback):
1114         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
1115         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1116         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1117         (-[TestRunnerWKWebView dealloc]):
1118         (-[TestRunnerWKWebView didStartFormControlInteraction]):
1119         (-[TestRunnerWKWebView didEndFormControlInteraction]):
1120         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1121         (WTR::contentOffsetBoundedInValidRange):
1122         (WTR::UIScriptController::scrollToOffset):
1123         (WTR::UIScriptController::platformSetDidStartFormControlInteractionCallback):
1124         (WTR::UIScriptController::platformSetDidEndFormControlInteractionCallback):
1125
1126 2016-08-22  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1127
1128         [EFL][GTK] Script process-linux-coredump is not needed, switch back to use the kernel core dumper instead.
1129         https://bugs.webkit.org/show_bug.cgi?id=160927
1130
1131         Reviewed by Daniel Bates.
1132
1133         * Scripts/process-linux-coredump: Removed.
1134         * Scripts/webkitpy/port/efl.py:
1135         (EflPort._get_crash_log):
1136         * Scripts/webkitpy/port/gtk.py:
1137         (GtkPort._get_crash_log):
1138         * Scripts/webkitpy/port/linux_get_crash_log.py:
1139         (GDBCrashLogGenerator.__init__):
1140         (GDBCrashLogGenerator.generate_crash_log):
1141         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
1142         (GDBCrashLogGeneratorTest.test_generate_crash_log):
1143
1144 2016-08-22  Jonathan Bedard  <jbedard@apple.com>
1145
1146         check-webkit-style does not work with Lambda functions in C++
1147         https://bugs.webkit.org/show_bug.cgi?id=160910
1148
1149         Reviewed by Darin Adler.
1150
1151         This change eliminates false positives on correctly styled lambda functions and includes a few basic checks on capture list.
1152
1153         * Scripts/webkitpy/style/checkers/cpp.py:
1154         (regex_for_lambda_functions): Added function which checks if a string is the start of a lambda function.
1155         (check_for_non_standard_constructs): Added lambda function check.
1156         (check_spacing_for_function_call): Added lambda function check.
1157         (check_braces): Added lambda function check.
1158         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1159         (CppStyleTest.test_lambda_functions): Added test function for lambda function style checks.
1160
1161 2016-08-21  Alex Christensen  <achristensen@webkit.org>
1162
1163         URLParser should parse IPv4 addresses
1164         https://bugs.webkit.org/show_bug.cgi?id=161023
1165
1166         Reviewed by Darin Adler.
1167
1168         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1169         (TestWebKitAPI::TEST_F):
1170         (TestWebKitAPI::checkURLDifferences):
1171         We are already getting differences between the old URL::parse and the new URLParser.
1172         (TestWebKitAPI::shouldFail):
1173
1174 2016-08-21  Daniel Bates  <dabates@apple.com>
1175
1176         prepare-ChangeLog lists unmodified functions as modified and marks functions with few changes as deleted
1177         https://bugs.webkit.org/show_bug.cgi?id=148437
1178
1179         Reviewed by Dan Bernstein.
1180
1181         * Scripts/prepare-ChangeLog:
1182         (diffCommand): When using a Subversion checkout, generate a unified diff without any context lines.
1183         This matches our behavior when using a Git checkout. The function overlap logic in generateFunctionListsByRanges()
1184         assumes that its line ranges were from a unified diff without any context lines.
1185         (extractLineRangeAfterChange): A deleted line should be represented with a ("begin line number", "end line number") = ("new starting line number", "new starting line number").
1186         (extractLineRangeBeforeChange): An added line should be represented with a ("begin line number", "end line number") = ("original starting line number", "original starting line number").
1187         * Scripts/webkitperl/prepare-ChangeLog_unittest/extractLineRangeBeforeAndAfterChange.pl: Update expected results
1188         based on changes to extractLineRangeAfterChange() and extractLineRangeBeforeChange().
1189         * Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl: Added.
1190         (discardOutput): Convenience function invokes the specified function redirecting standard output and standard error
1191         to /dev/null for the duration of the function call.
1192
1193 2016-08-20  Gyuyoung Kim  <gyuyoung.kim@navercorp.com>
1194
1195         [EFL] Remove unnecessary a patch to mute ecore warnings
1196         https://bugs.webkit.org/show_bug.cgi?id=160997
1197
1198         Reviewed by Darin Adler.
1199
1200         There is no warning messages during the layout test and perf test
1201         after bumping efl version from 1.17 to 1.18. Remove it.
1202
1203         * efl/patches/ecore_remove_warnings.patch: Removed.
1204
1205 2016-08-20  Simon Fraser  <simon.fraser@apple.com>
1206
1207         REGRESSION (r204477): Running LayoutTests on ios-simulator became ~15 minutes slower
1208         https://bugs.webkit.org/show_bug.cgi?id=160985
1209
1210         Re-land r204672, but don't check the result of 'xcrun simctl shutdown', because
1211         device shutdown seems to happen as result of killing Simulator.apps, and we're racing
1212         with that.
1213
1214         * Scripts/webkitpy/layout_tests/views/printing.py:
1215         (Printer.print_config):
1216         * Scripts/webkitpy/port/base.py:
1217         (Port.driver_cmd_line_for_logging):
1218         (Port.driver_cmd_line): Deleted.
1219         * Scripts/webkitpy/port/driver.py:
1220         (IOSSimulatorDriver.cmd_line):
1221         * Scripts/webkitpy/port/ios.py:
1222         (IOSSimulatorPort.__init__):
1223         (IOSSimulatorPort.driver_cmd_line_for_logging):
1224         (IOSSimulatorPort._create_simulators):
1225         (IOSSimulatorPort.setup_test_run):
1226         (IOSSimulatorPort._quit_ios_simulator):
1227         (IOSSimulatorPort.clean_up_test_run):
1228         (IOSSimulatorPort._create_device):
1229         (IOSSimulatorPort):
1230         (IOSSimulatorPort._remove_device):
1231         (IOSSimulatorPort._testing_device):
1232         (IOSSimulatorPort.device_id_for_worker_number):
1233         (IOSSimulatorPort._set_device_class): Deleted.
1234         (IOSSimulatorPort.testing_device): Deleted.
1235         * Scripts/webkitpy/port/port_testcase.py:
1236         (PortTestCase.test_driver_cmd_line):
1237         * Scripts/webkitpy/xcode/simulator.py:
1238         (Device.shutdown):
1239         (Device):
1240         (Device.delete):
1241         (Device.reset):
1242         (Simulator):
1243         (Simulator.create_device):
1244         (Simulator.remove_device):
1245         (Simulator.device_number):
1246         (Simulator.device_state_description):
1247         (Simulator.wait_until_device_is_in_state):
1248
1249 2016-08-19  Ryan Haddad  <ryanhaddad@apple.com>
1250
1251         Unreviewed, rolling out r204659.
1252
1253         This change appears to have caused ios-simulator LayoutTests
1254         to fail when shutting down the simulator
1255
1256         Reverted changeset:
1257
1258         "REGRESSION (r204477): Running LayoutTests on ios-simulator
1259         became ~15 minutes slower"
1260         https://bugs.webkit.org/show_bug.cgi?id=160985
1261         http://trac.webkit.org/changeset/204659
1262
1263 2016-08-19  Alexey Proskuryakov  <ap@apple.com>
1264
1265         Build fix for non-USE_SIM_SERVICE_CONTEXT builds
1266         * LayoutTestRelay/LayoutTestRelay/main.m: (main):
1267
1268 2016-08-18  Simon Fraser  <simon.fraser@apple.com>
1269
1270         REGRESSION (r204477): Running LayoutTests on ios-simulator became ~15 minutes slower
1271         https://bugs.webkit.org/show_bug.cgi?id=160985
1272
1273         Reviewed by Alexey Proskuryakov.
1274         
1275         r204477 removed @memoized on a couple of ios.py functions, causing them to instantiate
1276         a Simulator() on every call, which causes 'xcrun simctl list' to run. The functions
1277         must not be @memoized, because their return value depends on the value of simulator_device_type().
1278         
1279         Fix by adding some global state in simulator.py that tracks the created devices 
1280         in a worker number -> Device dictionary. Explicitly create devices in _create_simulators(),
1281         and delete them in clean_up_test_run().
1282         
1283         Also explicitly called 'xcrun simctl shutdown' to shut down devices, since it seems
1284         that killing the Simulator apps isn't enough.
1285         
1286         Simulator tracks the devices in a global dictionary, since state needs to persist
1287         across different instances of IOSSimulatorPort.
1288         
1289         Annoyingly, the "Command line:" dumping tried to access a device before we'd done
1290         any setup. Rather than implicitly creating a device here (which the old code did),
1291         override the more clearly named driver_cmd_line_for_logging() in IOSSimulatorPort
1292         and set flag to say that device_id_for_worker_number() doesn't need to return a real
1293         device id.
1294
1295         * Scripts/webkitpy/layout_tests/views/printing.py:
1296         (print_options):
1297         (Printer.print_config):
1298         * Scripts/webkitpy/port/base.py:
1299         (Port.driver_cmd_line_for_logging):
1300         (Port.driver_cmd_line): Deleted.
1301         * Scripts/webkitpy/port/driver.py:
1302         (IOSSimulatorDriver.cmd_line):
1303         * Scripts/webkitpy/port/ios.py:
1304         (IOSSimulatorPort.__init__):
1305         (IOSSimulatorPort.driver_cmd_line_for_logging):
1306         (IOSSimulatorPort._create_simulators):
1307         (IOSSimulatorPort.setup_test_run):
1308         (IOSSimulatorPort.clean_up_test_run):
1309         (IOSSimulatorPort._create_device):
1310         (IOSSimulatorPort):
1311         (IOSSimulatorPort._remove_device):
1312         (IOSSimulatorPort._testing_device):
1313         (IOSSimulatorPort.device_id_for_worker_number):
1314         (IOSSimulatorPort._set_device_class): Deleted.
1315         (IOSSimulatorPort.testing_device): Deleted.
1316         * Scripts/webkitpy/port/port_testcase.py:
1317         (PortTestCase.test_driver_cmd_line):
1318         * Scripts/webkitpy/xcode/simulator.py:
1319         (Device.shutdown):
1320         (Device.delete):
1321         (Device.reset):
1322         (Simulator.create_device):
1323         (Simulator.remove_device):
1324         (Simulator.device_number):
1325         (Simulator.device_state_description):
1326         (Simulator.wait_until_device_is_in_state):
1327
1328 2016-08-19  Alexey Proskuryakov  <ap@apple.com>
1329
1330         Adopt SimServiceContext in LayoutTestRelay
1331         https://bugs.webkit.org/show_bug.cgi?id=161000
1332         <rdar://problem/25765594>
1333
1334         Reviewed by Daniel Bates.
1335
1336         * LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h:
1337         * LayoutTestRelay/LayoutTestRelay/main.m:
1338
1339 2016-08-19  Lucas Forschler  <lforschler@apple.com>
1340
1341         Remove Yosemite Leaks bot after http://trac.webkit.org/projects/webkit/changeset/204629
1342
1343         Reviewed by Kocsen Chung.
1344
1345         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1346         (WebKitBuildbot):
1347
1348 2016-08-19  Alexey Proskuryakov  <ap@apple.com>
1349
1350         Partial revert of r203811 - this key is not needed.
1351
1352         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m: (-[LTRelayController installApp]):
1353
1354 2016-08-19  Daniel Bates  <dabates@apple.com>
1355
1356         Another attempt to fix the iOS 9.3 build
1357
1358         Define WK_EMPTY_, WK_NOT_, and WK_NOT_YES.
1359
1360         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1361         * WebKitTestRunner/Configurations/Base.xcconfig:
1362
1363 2016-08-19  Lucas Forschler  <lforschler@apple.com>
1364
1365         Remove Yosemite Leaks bot from config.json
1366         
1367         Reviewed by Alexey Proskuryakov.
1368
1369         * BuildSlaveSupport/build.webkit.org-config/config.json:
1370
1371 2016-08-18  Dan Bernstein  <mitz@apple.com>
1372
1373         [Cocoa] API::Number needs to be wrapped by an NSNumber
1374         https://bugs.webkit.org/show_bug.cgi?id=160977
1375         <rdar://problem/27877735>
1376
1377         Reviewed by Anders Carlsson.
1378
1379         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1380         * TestWebKitAPI/Tests/WebKit2Cocoa/WKNSNumber.mm: Added.
1381         (TestWebKitAPI::TEST):
1382
1383 2016-08-17  Myles C. Maxfield  <mmaxfield@apple.com>
1384
1385         [Cocoa] Migrate off of deprecated CoreGraphics API CGContextSelectFont() and CGContextShowTextAtPoint()
1386         https://bugs.webkit.org/show_bug.cgi?id=160895
1387
1388         Reviewed by Dean Jackson.
1389
1390         Link to the existing CoreText framework.
1391
1392         * DumpRenderTree/PlatformWin.cmake:
1393         * TestWebKitAPI/PlatformWin.cmake:
1394
1395 2016-08-17  Brent Fulgham  <bfulgham@apple.com>
1396
1397         [Win] Remove old libraries from build inputs
1398         https://bugs.webkit.org/show_bug.cgi?id=160949
1399
1400         Reviewed by Dean Jackson.
1401
1402         Modify the download script to remove the old 'icuuc.lib' and
1403         'icuin.lib' files for Windows builds.
1404
1405         * Scripts/update-webkit-auxiliary-libs:
1406
1407 2016-08-17  Jonathan Bedard  <jbedard@apple.com>
1408
1409         Extra logging for crash reason
1410         https://bugs.webkit.org/show_bug.cgi?id=160943
1411
1412         Reviewed by Alexey Proskuryakov.
1413
1414         A number of tests have been erroneously marked as crashed, this should help diagnose these false crashes.
1415
1416         * Scripts/webkitpy/port/server_process.py:
1417         (ServerProcess.write): Add extra logging to determine why a process has been marked as crashed.
1418         (ServerProcess._wait_for_data_and_update_buffers_using_select): Ditto.
1419         (ServerProcess.has_crashed): Ditto.
1420
1421 2016-08-17  Dan Bernstein  <mitz@apple.com>
1422
1423         [Cocoa] -[NSString isEqualToString:] returns NO for any WKNSString argument
1424         https://bugs.webkit.org/show_bug.cgi?id=160938
1425         <rdar://problem/27876652>
1426
1427         Reviewed by Anders Carlsson.
1428
1429         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1430         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm: Added.
1431         (TestWebKitAPI::TEST):
1432
1433 2016-08-17  Chris Fleizach  <cfleizach@apple.com>
1434
1435         AX: Support abbreviations in iOS
1436         https://bugs.webkit.org/show_bug.cgi?id=160907
1437
1438         Reviewed by Joanmarie Diggs.
1439
1440         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1441         (AccessibilityUIElement::stringAttributeValue):
1442         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1443         (WTR::AccessibilityUIElement::stringAttributeValue):
1444
1445 2016-08-17  Gyuyoung Kim  <gyuyoung.kim@navercorp.com>
1446
1447         [EFL] Bump efl version from 1.17 to 1.18
1448         https://bugs.webkit.org/show_bug.cgi?id=160899
1449
1450         Reviewed by Antonio Gomes.
1451
1452         To use efl-1.18, EFL port needs to update install dependencies as well.
1453
1454         * efl/install-dependencies:
1455         * efl/jhbuild.modules:
1456
1457 2016-08-17  Per Arne Vollan  <pvollan@apple.com>
1458
1459         [Win] Add tests for linked fonts.
1460         https://bugs.webkit.org/show_bug.cgi?id=160898
1461
1462         Reviewed by Brent Fulgham.
1463
1464         Add tests for https://trac.webkit.org/changeset/204502.
1465
1466         * TestWebKitAPI/PlatformWin.cmake:
1467         * TestWebKitAPI/Tests/WebCore/win/LinkedFonts.cpp: Added.
1468         (TestWebKitAPI::TEST):
1469
1470 2016-08-16  Daniel Bates  <dabates@apple.com>
1471
1472         prepare-ChangeLog: Extract logic from generateFunctionLists() into a function that takes a delegate object
1473         https://bugs.webkit.org/show_bug.cgi?id=160924
1474
1475         Reviewed by Stephanie Lewis.
1476
1477         Towards adding unit tests for generateFunctionLists() we move its logic into actuallyGenerateFunctionLists()
1478         and have actuallyGenerateFunctionLists() take a delegate object to use to query the file system and SCM.
1479         We modify generateFunctionLists() to call actuallyGenerateFunctionLists(). This will make is possible to
1480         test the generate function list machinery without requiring a SCM checkout by substituting a delegate
1481         object that mocks out the file system and SCM operations.
1482
1483         * Scripts/VCSUtils.pm:
1484         (parseDiffStartLine): Parses an SVN or Git start line and returns the path to the target file.
1485         * Scripts/prepare-ChangeLog:
1486         (generateFunctionLists): Move functionality to actually generate the function lists to actuallyGenerateFunctionLists(),
1487         abstracting the logic to query the file system and SCM into functions on a delegate object that
1488         we pass to it.
1489         (actuallyGenerateFunctionLists): Extracted from generateFunctionLists().
1490         (diffHeaderFormat): Deleted.
1491
1492 2016-08-16  Alex Christensen  <achristensen@webkit.org>
1493
1494         URLParser should parse URLs without credentials
1495         https://bugs.webkit.org/show_bug.cgi?id=160913
1496
1497         Reviewed by Brady Eidson.
1498
1499         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1500         (TestWebKitAPI::s):
1501         (TestWebKitAPI::checkURL):
1502         (TestWebKitAPI::TEST_F):
1503
1504 2016-08-16  Anders Carlsson  <andersca@apple.com>
1505
1506         Add WTF::ScopeExit
1507         https://bugs.webkit.org/show_bug.cgi?id=160908
1508
1509         Reviewed by Geoffrey Garen.
1510
1511         * TestWebKitAPI/CMakeLists.txt:
1512         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1513         * TestWebKitAPI/Tests/WTF/Scope.cpp: Added.
1514         (TestWebKitAPI::TEST):
1515
1516 2016-08-16  Aakash Jain  <aakash_jain@apple.com>
1517
1518         EWS logs file are rotated too quickly
1519         https://bugs.webkit.org/show_bug.cgi?id=160724
1520
1521         Reviewed by Daniel Bates.
1522
1523         Currently we are rotating the log file after 10 iterations of queue. If the queue
1524         doesn't have any pending patches, these iterations result in very small amount of 
1525         logs (1 KB log file). Even if the queue process some patches, logs are few KBs.
1526         This results in a lot of log files in a day. This patch ensures that we rotate the
1527         log file when its file size is greater than or equal to 100 KB.
1528
1529         * EWSTools/start-queue-mac.sh: Added check for file size before rotating log file.
1530
1531 2016-08-16  Daniel Bates  <dabates@apple.com>
1532
1533         WKSI static library should be named by major iOS revision, not individual updates
1534         https://bugs.webkit.org/show_bug.cgi?id=160727
1535         <rdar://problem/22274848>
1536
1537         Reviewed by Alexey Proskuryakov.
1538
1539         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1540         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1541         * Scripts/copy-webkitlibraries-to-product-directory:
1542         * WebKitTestRunner/Configurations/Base.xcconfig:
1543         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1544
1545 2016-08-16  Simon Fraser  <simon.fraser@apple.com>
1546
1547         Make it possible to test iOS select elements, and add iPhone and iPad tests for them
1548         https://bugs.webkit.org/show_bug.cgi?id=160909
1549
1550         Reviewed by Enrica Casucci.
1551         
1552         Add functions to UIScriptController to dismiss the form accessory view for iOS,
1553         and to programmatically pick a row from a <select> picker.
1554
1555         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
1556         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
1557         (WTR::UIScriptController::dismissFormAccessoryView):
1558         (WTR::UIScriptController::selectFormAccessoryPickerRow):
1559         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
1560         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1561         (WTR::UIScriptController::dismissFormAccessoryView):
1562         (WTR::UIScriptController::selectFormAccessoryPickerRow):
1563
1564 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
1565
1566         [iOS] Add iPad viewport and form tests, and revert the iPad-testing part of r202132
1567         https://bugs.webkit.org/show_bug.cgi?id=160878
1568
1569         Reviewed by Tim Horton.
1570         
1571         Remove testing-specific "forceIPadStyleZoomOnInputFocus" behavior added in r202132
1572         now that we have the ability to run tests in the iPad simulator.
1573
1574         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
1575         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
1576         (WTR::UIScriptController::forceIPadStyleZoomOnInputFocus): Deleted.
1577         (WTR::UIScriptController::setForceIPadStyleZoomOnInputFocus): Deleted.
1578         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
1579         * WebKitTestRunner/ios/TestControllerIOS.mm:
1580         (WTR::TestController::platformResetStateToConsistentValues): Deleted.
1581         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1582         (WTR::UIScriptController::forceIPadStyleZoomOnInputFocus): Deleted.
1583         (WTR::UIScriptController::setForceIPadStyleZoomOnInputFocus): Deleted.
1584
1585 2016-08-15  Anders Carlsson  <andersca@apple.com>
1586
1587         Add an address-of operator to RetainPtr
1588         https://bugs.webkit.org/show_bug.cgi?id=160879
1589
1590         Reviewed by Tim Horton.
1591
1592         Test HashMap and HashSet with an object whose operator& is deleted.
1593
1594         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1595         Sort the Xcode project.
1596
1597         * TestWebKitAPI/Tests/WTF/DeletedAddressOfOperator.h: Added.
1598         (DeletedAddressOfOperator::DeletedAddressOfOperator):
1599         (DeletedAddressOfOperator::value):
1600         (DeletedAddressOfOperator::operator==):
1601         (WTF::HashTraits<DeletedAddressOfOperator>::constructDeletedValue):
1602         (WTF::HashTraits<DeletedAddressOfOperator>::isDeletedValue):
1603         (WTF::DefaultHash<DeletedAddressOfOperator>::Hash::hash):
1604         (WTF::DefaultHash<DeletedAddressOfOperator>::Hash::equal):
1605         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1606         (TestWebKitAPI::TEST):
1607         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
1608         (TestWebKitAPI::TEST):
1609
1610 2016-08-16  Jonathan Bedard  <jbedard@apple.com>
1611
1612         False crashes in fast/text/emoji-gender-* tests
1613         https://bugs.webkit.org/show_bug.cgi?id=160779
1614
1615         Reviewed by Alexey Proskuryakov.
1616
1617         Fix from <rdar://problem/27786762>, where timed out tests falsely report as crashed.
1618
1619         * Scripts/webkitpy/port/driver.py:
1620         (Driver._check_for_driver_crash_or_unresponsiveness): Change call to ‘write’ to disable crash flag.
1621         * Scripts/webkitpy/port/driver_unittest.py: Added 3 variable to test version of ‘write.’
1622         * Scripts/webkitpy/port/server_process.py:
1623         (ServerProcess.write): Allow caller to disable crash flag on exception.
1624
1625 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
1626
1627         webkitpy error in TestRunResults.merge()
1628         https://bugs.webkit.org/show_bug.cgi?id=160882
1629
1630         Reviewed by Daniel Bates.
1631         
1632         The argument to TestRunResults.merge() can be None if there are no device-specifc
1633         initial results or retry results in Manager.run(), so just return early in that case.
1634
1635         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1636         (TestRunResults.merge):
1637
1638 2016-08-15  Sam Weinig  <sam@webkit.org>
1639
1640         Speed up compile times by not including wtf/Variant.h so much
1641         https://bugs.webkit.org/show_bug.cgi?id=160847
1642
1643         Reviewed by Alex Christensen and Saam Barati.
1644
1645         * TestWebKitAPI/Tests/WTF/Variant.cpp:
1646         (TestWebKitAPI::TEST):
1647         Explicitly use std::experimental::variant.
1648
1649 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
1650
1651         Allow a port to run tests with a custom device setup
1652         https://bugs.webkit.org/show_bug.cgi?id=160833
1653
1654         Reviewed by Daniel Bates.
1655
1656         These changes allow the IOSSimulator port to run tests in iPad mode.
1657
1658         This is made possible by allowing a platform to define CUSTOM_DEVICE_CLASSES,
1659         in this case 'ipad'. When specified, any test in a directory with a suffix that matches
1660         a custom device will be collected into a set, and run in that device's environment after
1661         the other tests have run.
1662
1663         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1664         (Manager._custom_device_for_test): If the test contains a directory matching a
1665         custom device suffix, return that custom device.
1666         (Manager._set_up_run): Push the custom device class, if any, into options so
1667         that the Worker can get to it.
1668         (Manager.run): Go through the list of tests, and break it down into device-generic
1669         tests, and tests for each device class. _run_test_subset is then called for
1670         each collection of tests, and the results merged.
1671         (Manager._run_test_subset): Some lines unwrapped.
1672         (Manager._end_test_run):
1673         (Manager._run_tests):
1674         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1675         (SingleTestRunner.__init__): Unwrapped a line.
1676         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1677         (TestRunResults.merge): Add this function to merge TestRunResults
1678         * Scripts/webkitpy/layout_tests/views/printing.py:
1679         (Printer.print_workers_and_shards): Print the custom device, if any.
1680         * Scripts/webkitpy/port/base.py:
1681         (Port): Base port has empty array of custom devices.
1682         (Port.setup_test_run): Add device_class argument.
1683         * Scripts/webkitpy/port/driver.py:
1684         (DriverInput.__repr__):
1685         (Driver.check_driver.implementation):
1686         * Scripts/webkitpy/port/efl.py:
1687         (EflPort.setup_test_run):
1688         * Scripts/webkitpy/port/gtk.py:
1689         (GtkPort.setup_test_run):
1690         * Scripts/webkitpy/port/ios.py:
1691         (IOSSimulatorPort): Add CUSTOM_DEVICE_CLASSES for ipad.
1692         (IOSSimulatorPort.__init__):
1693         (IOSSimulatorPort.simulator_device_type): Use a device name from the DEVICE_CLASS_MAP
1694         based on the custom device class.
1695         (IOSSimulatorPort._set_device_class):
1696         (IOSSimulatorPort._create_simulators): Factor some code into this function.
1697         (IOSSimulatorPort.setup_test_run):
1698         (IOSSimulatorPort.testing_device):
1699         (IOSSimulatorPort.reset_preferences): This used to create the simulator apps, but that
1700         seemed wrong for this function. That was moved to setup_test_run().
1701         (IOSSimulatorPort.check_sys_deps): This function used to create testing devices,
1702         but this happened too early, before we knew which kind of devices to create. Devices
1703         are now created in setup_test_run().
1704         * Scripts/webkitpy/port/win.py:
1705         (WinPort.setup_test_run):
1706
1707 2016-08-15  Daniel Bates  <dabates@apple.com>
1708
1709         Cannot build WebKit for iOS device using Xcode 7.3/iOS 9.3 public SDK due to missing
1710         private frameworks and libraries
1711         https://bugs.webkit.org/show_bug.cgi?id=155931
1712         <rdar://problem/25807989>
1713
1714         Reviewed by Dan Bernstein.
1715
1716         Add directory WebKitLibraries/WebKitPrivateFrameworkStubs/iOS/X to the framework search path
1717         where X is the major version of the active iOS SDK.
1718
1719         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1720         * WebKitTestRunner/Configurations/Base.xcconfig:
1721
1722 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
1723
1724         Add a setting and preferences to enable visual viewport mode
1725         https://bugs.webkit.org/show_bug.cgi?id=160843
1726
1727         Reviewed by Sam Weinig.
1728         
1729         Pref and a menu item to toggle visualViewportEnabled for WebKits 1 and 2.
1730
1731         * MiniBrowser/mac/SettingsController.h:
1732         * MiniBrowser/mac/SettingsController.m:
1733         (-[SettingsController _populateMenu]):
1734         (-[SettingsController validateMenuItem:]):
1735         (-[SettingsController visualViewportEnabled]):
1736         (-[SettingsController toggleVisualViewportEnabled:]):
1737         * MiniBrowser/mac/WK1BrowserWindowController.m:
1738         (-[WK1BrowserWindowController didChangeSettings]):
1739         * MiniBrowser/mac/WK2BrowserWindowController.m:
1740         (-[WK2BrowserWindowController didChangeSettings]):
1741
1742 2016-08-15  Konstantin Tokarev  <annulen@yandex.ru>
1743
1744         Allow using make-dist with non-GTK ports
1745         https://bugs.webkit.org/show_bug.cgi?id=160842
1746
1747         Reviewed by Michael Catanzaro.
1748
1749         This patch adds support for setting base name of tarball and argument
1750         passed to cmake's -DPORT= via command line arguments.
1751
1752         * gtk/make-dist.py:
1753         (Distcheck.configure):
1754         (Distcheck.check):
1755         (get_tarball_root_and_output_filename_from_arguments):
1756
1757 2016-08-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1758
1759         [GTK] Install script lacks gstreamer related dependencies
1760         https://bugs.webkit.org/show_bug.cgi?id=160814
1761
1762         Reviewed by Carlos Garcia Campos.
1763
1764         * gtk/install-dependencies: Fedora case had already listed this dependencies,
1765         but both Arch and Debian/Ubuntu were missing them.
1766
1767 2016-08-13  Konstantin Tokarev  <annulen@yandex.ru>
1768
1769         make-dist.py should not allow unknown rules in manifest
1770         https://bugs.webkit.org/show_bug.cgi?id=160841
1771
1772         Reviewed by Carlos Garcia Campos.
1773
1774         * gtk/make-dist.py:
1775         (Manifest.process_line):
1776
1777 2016-08-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1778
1779         [EFL][GTK] Install script not working on Debian 9 (testing) and Ubuntu 16.10
1780         https://bugs.webkit.org/show_bug.cgi?id=160809
1781
1782         Reviewed by Carlos Garcia Campos.
1783
1784         * efl/install-dependencies: Factorize the previous logic for handling the php5/7
1785         case, and use it also for the new package names of libpng and libgeoclue.
1786         * gtk/install-dependencies: Ditto.
1787
1788 2016-08-12  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1789
1790         Skip to check directories existence in build-webkit
1791         https://bugs.webkit.org/show_bug.cgi?id=160691
1792
1793         Reviewed by Alex Christensen.
1794
1795         CMake checks if directories are there itself. So CMake ports
1796         don't need to check it in the build-webkit script.
1797
1798         * Scripts/build-webkit:
1799         * Scripts/webkitdirs.pm:
1800         (determineSourceDir):
1801         (isCMakeBuild):
1802
1803 2016-08-12  Alex Christensen  <achristensen@webkit.org>
1804
1805         Make URLParser work with URLs missing URL parts
1806         https://bugs.webkit.org/show_bug.cgi?id=160824
1807
1808         Reviewed by Brady Eidson.
1809
1810         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1811         (TestWebKitAPI::s):
1812         (TestWebKitAPI::checkURL):
1813         (TestWebKitAPI::TEST_F):
1814         (TestWebKitAPI::eq): Deleted.
1815
1816 2016-08-12  John Wilander  <wilander@apple.com>
1817
1818         Add HashCountedSet API tests to TestWTFLibrary target
1819         https://bugs.webkit.org/show_bug.cgi?id=160815
1820
1821         Reviewed by Alex Christensen.
1822
1823         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1824             Added HashCountedSet.cpp and sorted the file reference section
1825             according to UNIX sort.
1826
1827 2016-08-12  Ryosuke Niwa  <rniwa@webkit.org>
1828
1829         run-benchmark should run JetStream 1.1 instead of 1.0.1
1830         https://bugs.webkit.org/show_bug.cgi?id=160816
1831
1832         Reviewed by Filip Pizlo.
1833
1834         Use the latest JetStream 1.1 in run-benchmark.
1835
1836         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
1837         (BenchmarkBuilder.__exit__):
1838         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Updated to apply against 1.1 directory.
1839         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Updated to use r190897, which is the last
1840         change to JetStream directory.
1841
1842 2016-08-12  Alex Christensen  <achristensen@webkit.org>
1843
1844         Initial URLParser implementation
1845         https://bugs.webkit.org/show_bug.cgi?id=160811
1846
1847         Reviewed by Brady Eidson.
1848
1849         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1850         (TestWebKitAPI::eq):
1851         (TestWebKitAPI::checkURL):
1852         (TestWebKitAPI::TEST_F):
1853
1854 2016-08-12  Brady Eidson  <beidson@apple.com>
1855
1856         Fix the 32-bit Mac build after:
1857         Add WK2 ExperimentalFeature support to MiniBrowser
1858         https://bugs.webkit.org/show_bug.cgi?id=160788
1859
1860         Unreviewed.
1861
1862         Sprinkle "#if WK_API_ENABLED"s liberally.
1863         
1864         * MiniBrowser/mac/AppDelegate.m:
1865         (defaultConfiguration):
1866         * MiniBrowser/mac/SettingsController.m:
1867         (-[SettingsController _populateMenu]):
1868         (-[SettingsController validateMenuItem:]):
1869
1870 2016-08-12  Philippe Normand  <pnormand@igalia.com>
1871
1872         [GStreamer][OWR] Video rendering fixes
1873         https://bugs.webkit.org/show_bug.cgi?id=160764
1874
1875         Reviewed by Xabier Rodriguez-Calvar.
1876
1877         * gtk/jhbuild.modules: Bump to current OpenWebRTC master.
1878
1879 2016-08-12  Per Arne Vollan  <pvollan@apple.com>
1880
1881         Add missing return statement in convertFast function added in r204376.
1882
1883         Unreviewed.
1884
1885         * Scripts/webkitpy/common/system/path.py:
1886         (_CygPath.convertFast):
1887
1888 2016-08-11  Brady Eidson  <beidson@apple.com>
1889
1890         Add WK2 ExperimentalFeature support to MiniBrowser.
1891         https://bugs.webkit.org/show_bug.cgi?id=160788
1892
1893         Reviewed by Alex Christensen.
1894
1895         * MiniBrowser/mac/AppDelegate.h:
1896         * MiniBrowser/mac/AppDelegate.m:
1897         (defaultConfiguration):
1898         (defaultPreferences):
1899         
1900         * MiniBrowser/mac/SettingsController.m:
1901         (-[SettingsController _populateMenu]):
1902         (-[SettingsController validateMenuItem:]):
1903         (-[SettingsController toggleExperimentalFeature:]):
1904
1905 2016-08-11  Aakash Jain  <aakash_jain@apple.com>
1906
1907         Keep EWS logs for longer
1908         https://bugs.webkit.org/show_bug.cgi?id=160776
1909
1910         Reviewed by Daniel Bates.
1911
1912         * EWSTools/start-queue-mac.sh: Keep logs for 30 days instead of 14 days.
1913
1914 2016-08-11  Simon Fraser  <simon.fraser@apple.com>
1915
1916         iOS DRT/WTR project cleanup
1917         https://bugs.webkit.org/show_bug.cgi?id=160778
1918
1919         Reviewed by Tim Horton.
1920
1921         Move TARGETED_DEVICE_FAMILY from the project to an xcconfig file.
1922
1923         Remove AppDelegate.* which were unused.
1924
1925         Exclude ios/Launch.storyboard on more platforms.
1926
1927         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1928         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
1929         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
1930         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1931         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Removed.
1932         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Removed.
1933         (-[AppDelegate application:didFinishLaunchingWithOptions:]): Deleted.
1934
1935 2016-08-11  Alex Christensen  <achristensen@webkit.org>
1936
1937         Fix Yosemite bots' cookie accept policies after r204365.
1938         https://bugs.webkit.org/show_bug.cgi?id=160758
1939
1940         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
1941         (TEST):
1942         This makes the test fully clean up after itself.
1943
1944 2016-08-11  Alex Christensen  <achristensen@webkit.org>
1945
1946         Fix Yosemite bots' cookie accept policies after r204365.
1947         https://bugs.webkit.org/show_bug.cgi?id=160758
1948
1949         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
1950         (TEST):
1951         I didn't restore the cookieAcceptPolicy of the sharedHTTPCookieStorage after changing it with this API test.
1952         On Yosemite, this is changing the cookieAcceptPolicy that DumpRenderTree uses.
1953         On more recent Cocoa platforms, it is only changing the cookieAcceptPolicy that TestWebKitAPI uses, which isn't
1954         causing any problems because there are no other API tests that do anything with cookies.
1955         My solution will be to restore the original cookieAcceptPolicy after running this API test to clean up,
1956         but first I am committing this patch setting the cookieAcceptPolicy to NSHTTPCookieAcceptPolicyOnlyFromMainDocumentDomain
1957         to reset any bots that have run tests since r204365.  I will commit a followup that sets it to originalCookieAcceptPolicy.
1958
1959 2016-08-11  Aakash Jain  <aakash_jain@apple.com>
1960
1961         EWS should check if the patch is still valid before executing every major step
1962         https://bugs.webkit.org/show_bug.cgi?id=160739
1963         rdar://problem/27768813
1964
1965         Reviewed by Alexey Proskuryakov.
1966
1967         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1968         (CommitQueueTask.run): validate method is now executed in base class.
1969         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
1970         (EarlyWarningSystemTask.run): validate method is now executed in base class.
1971         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
1972         (StyleQueueTask.validate): Raise an PatchIsNotValid exception instead of returning False.
1973         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1974         (PatchAnalysisTask._run_command): validate the patch before executing any command. This is to ensure
1975         that we do not waste time on any patch which has become invalid (e.g.: obsolete, r-).
1976         * Scripts/webkitpy/tool/commands/perfalizer.py:
1977         (PerfalizerTask.validate): Added.
1978         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1979         (test_manual_reject_during_processing): Updated test case.
1980
1981 2016-08-11  Alex Christensen  <achristensen@webkit.org>
1982
1983         Add URLParser stub
1984         https://bugs.webkit.org/show_bug.cgi?id=160770
1985
1986         Reviewed by Sam Weinig.
1987
1988         * TestWebKitAPI/PlatformGTK.cmake:
1989         * TestWebKitAPI/PlatformWin.cmake:
1990         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1991         * TestWebKitAPI/Tests/WebCore/URLParser.cpp: Added.
1992         (TestWebKitAPI::TEST_F):
1993
1994 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
1995
1996         [iOS DRT] Allow DRT to be iPad-sized in the iPad simulator
1997         https://bugs.webkit.org/show_bug.cgi?id=160761
1998
1999         Reviewed by Tim Horton.
2000
2001         Give iOS DRT a Launch storyboard.
2002
2003         Have it use a UIViewController so future forms testing works correctly.
2004
2005         Add TARGETED_DEVICE_FAMILY = "1,2" to the build settings for the .app, so that it
2006         can run in iPad mode.
2007
2008         Remove empty InfoPlist.strings files.
2009
2010         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2011         * DumpRenderTree/ios/Info.plist:
2012         * DumpRenderTree/ios/Launch.storyboard: Added.
2013         * DumpRenderTree/mac/DumpRenderTree.mm:
2014         (createWebViewAndOffscreenWindow):
2015         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2016         * WebKitTestRunner/WebKitTestRunnerApp/en.lproj/InfoPlist.strings: Removed.
2017         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2018         (WTR::PlatformWebView::PlatformWebView): Drive-by leak fix.
2019
2020 2016-08-11  Per Arne Vollan  <pvollan@apple.com>
2021
2022         [Win] Unable to reliably run tests in parallel
2023         https://bugs.webkit.org/show_bug.cgi?id=140914
2024
2025         Reviewed by Brent Fulgham.
2026
2027         The cygpath utility function can fail badly when running with multiple DumpRenderTree
2028         processes. We can use string replacement to convert the Cygwin path to a Windows path
2029         instead.
2030
2031         * Scripts/webkitpy/common/system/path.py:
2032         (cygpathFast):
2033         * Scripts/webkitpy/port/driver.py:
2034         (Driver._command_from_driver_input):
2035
2036 2016-08-10  Alex Christensen  <achristensen@webkit.org>
2037
2038         Fix crash when changing cookie accept policy after r204327
2039         https://bugs.webkit.org/show_bug.cgi?id=160758
2040
2041         Reviewed by Simon Fraser.
2042
2043         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2044         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm: Added.
2045         (-[CookieAcceptPolicyMessageHandler userContentController:didReceiveScriptMessage:]):
2046         (TEST):
2047         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieMessage.html: Added.
2048
2049 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
2050
2051         [iOS WK2] Have WebKitTestRunnerApp.app use a UIViewController, and fix to avoid the status bar
2052         https://bugs.webkit.org/show_bug.cgi?id=160757
2053
2054         Reviewed by Tim Horton.
2055
2056         When programmatically creating the test UIWindow, make a root UIViewController and parent
2057         the WKWebView in its view. This makes the app more like a normal UIKit application.
2058         
2059         Move the WKWebView down 20px to avoid the status bar.
2060         
2061         Give the UIWindow a gray background so it's obvious where the window and view positioned.
2062
2063         Sorted the project file. Removed the link to UIKit which showed red, and wasn't necessary.
2064         
2065         Remove duplicate references to Launch.storyboard.
2066
2067         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2068         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Add license.
2069         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Add license.
2070         (-[AppDelegate applicationWillResignActive:]): Deleted.
2071         (-[AppDelegate applicationDidEnterBackground:]): Deleted.
2072         (-[AppDelegate applicationWillEnterForeground:]): Deleted.
2073         (-[AppDelegate applicationDidBecomeActive:]): Deleted.
2074         (-[AppDelegate applicationWillTerminate:]): Deleted.
2075         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2076         (WTR::viewRectForWindowRect):
2077         (WTR::PlatformWebView::PlatformWebView):
2078         (WTR::PlatformWebView::setWindowFrame):
2079
2080 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
2081
2082         [iOS WK2] Use the simulated device's screen size, rather than a harcoded size
2083         https://bugs.webkit.org/show_bug.cgi?id=160748
2084
2085         Reviewed by Tim Horton.
2086         
2087         Use the main UIScreen's bounds for the window size if we're using a flexible viewport. This
2088         opens the door for tests using other device sizes.
2089
2090         * WebKitTestRunner/ios/TestControllerIOS.mm:
2091         (WTR::TestController::platformConfigureViewForTest):
2092
2093 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
2094
2095         Sort the feature flags in the FEATURE_DEFINES lines
2096         https://bugs.webkit.org/show_bug.cgi?id=160742
2097
2098         Reviewed by Anders Carlsson.
2099         
2100         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2101
2102 2016-08-09  Simon Fraser  <simon.fraser@apple.com>
2103
2104         Logging and other minor improvements to iOS webkitpy
2105         https://bugs.webkit.org/show_bug.cgi?id=160722
2106
2107         Reviewed by Dan Bates.
2108
2109         Fix --debug-rwt-logging to log all the calls to simctl as well as device state information,
2110         to make it easier to debug launching issues.
2111
2112         Have reset_preferences() reset the device, rather than just nuking the data
2113         directory (which broke some versions of the simulator).
2114
2115         Make the Simulator.app launch in the background with open -g.
2116
2117         Wait for the simulator device to be in a known state in some more places.
2118
2119         * Scripts/webkitpy/port/ios.py:
2120         (IOSSimulatorPort.setup_test_run):
2121         (IOSSimulatorPort._quit_ios_simulator):
2122         (IOSSimulatorPort.clean_up_test_run):
2123         (IOSSimulatorPort.setup_environ_for_server):
2124         (IOSSimulatorPort.reset_preferences):
2125         * Scripts/webkitpy/xcode/simulator.py:
2126         (Device.create):
2127         (Device.delete):
2128         (Device):
2129         (Device.reset):
2130         (Simulator.wait_until_device_is_booted):
2131         (Simulator.wait_until_device_is_in_state):
2132         (Simulator):
2133         (Simulator.delete_device):
2134         (Simulator.reset_device):
2135         (Simulator.lookup_or_create_device):
2136
2137 2016-08-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2138
2139         [GTK][EFL] ALSA_CARD environment variable is not passed for layout tests.
2140         https://bugs.webkit.org/show_bug.cgi?id=160697
2141
2142         Reviewed by Antonio Gomes.
2143
2144         * Scripts/webkitpy/port/base.py:
2145         (Port.to.setup_environ_for_server): Add ALSA_CARD and sort the Linux
2146         list of environment variables to copy.
2147
2148 2016-08-09  George Ruan  <gruan@apple.com>
2149
2150         Implement functionality of media capture on iOS
2151         https://bugs.webkit.org/show_bug.cgi?id=158945
2152         <rdar://problem/26893343>
2153
2154         Reviewed by Tim Horton.
2155
2156         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Enable Media
2157         Capture feature on iOS.
2158
2159 2016-08-09  Saam Barati  <sbarati@apple.com>
2160
2161         Parser<LexerType>::parseFunctionInfo() has the wrong info about captured vars when a function is not cached.
2162         https://bugs.webkit.org/show_bug.cgi?id=160671
2163         <rdar://problem/27756112>
2164
2165         Reviewed by Mark Lam.
2166
2167         * Scripts/run-jsc-stress-tests:
2168
2169 2016-08-09  Alexey Proskuryakov  <ap@apple.com>
2170
2171         Make directory reading code in iOSSimulatorDevices() more strict
2172         https://bugs.webkit.org/show_bug.cgi?id=160702
2173
2174         Reviewed by Tim Horton.
2175
2176         * Scripts/webkitdirs.pm:
2177         (iOSSimulatorDevices):
2178
2179 2016-08-06  Sam Weinig  <sam@webkit.org>
2180
2181         Replace NodeOrString with std::variant<RefPtr<Node>, String>
2182         https://bugs.webkit.org/show_bug.cgi?id=160638
2183
2184         Reviewed by Anders Carlsson.
2185
2186         * TestWebKitAPI/CMakeLists.txt:
2187         * TestWebKitAPI/Tests/WTF/Variant.cpp:
2188         Add additional tests for the initial state of std::variant and using
2189         makeVisitor for visiting.
2190
2191 2016-08-09  Aakash Jain  <aakash_jain@apple.com>
2192
2193         EWS logging should ensure the logging to file is stopped on queue termination
2194         https://bugs.webkit.org/show_bug.cgi?id=160698
2195         rdar://problem/24464570
2196
2197         Reviewed by Daniel Bates.
2198
2199         * Scripts/webkitpy/tool/bot/queueengine.py:
2200         (QueueEngine._stopping): Stop logging to file on queue termination.
2201         (QueueEngine._begin_logging): Configure the Python logger to log to file.
2202         * Scripts/webkitpy/common/system/logutils.py:
2203         (configure_logger_to_log_to_file): Return the handler so as to enable caller to remove it later.
2204         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
2205         (QueueEngineTest._run_engine): Removed extra newline character to improve log readability.
2206         * Scripts/webkitpy/tool/commands/queues.py:
2207         (AbstractQueue._log_directory): Reverting to os.path.join as we don't have host object.
2208         (AbstractQueue.queue_log_path): Same.
2209         (AbstractQueue.begin_work_queue): Removed logging initialization, it is now being done in QueueEngine.
2210         (AbstractQueue.__init__): Removed host parameter, not required anymore, it was required by logging initialization
2211         which moved to QueueEngine now.
2212         (PatchProcessingQueue.__init__): Same.
2213         (CommitQueue.__init__): Same.
2214         (AbstractReviewQueue.__init__): Same.
2215         (StyleQueue.__init__): Same.
2216         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2217         (TestCommitQueue): Removed host parameter.
2218         (TestCommitQueue.__init__): Same.
2219         (AbstractPatchQueueTest.test_next_patch): Same.
2220         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Same.
2221         (test_commit_queue_failure): Same.
2222         (mock_run_webkit_patch):
2223         (MockCommitQueueTask.results_from_patch_test_run): Same.
2224         (test_rollout_lands): Same.
2225         (test_non_valid_patch): Same.
2226         (test_auto_retry): Same.
2227         (test_style_queue_with_watch_list_exception): Same.
2228         (TestQueue.__init__): Deleted.
2229         (TestReviewQueue.__init__): Deleted.
2230         (TestFeederQueue.__init__): Deleted.
2231
2232 2016-08-09  Konstantin Tokarev  <annulen@yandex.ru>
2233
2234         webkit-gtk tarball fails to build due to missing files
2235         https://bugs.webkit.org/show_bug.cgi?id=160684
2236
2237         Reviewed by Alex Christensen.
2238
2239         * gtk/manifest.txt.in: Added back spi directories.
2240
2241 2016-08-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2242
2243         [GTK] Build the jhbuild with -O2 optimization level by default
2244         https://bugs.webkit.org/show_bug.cgi?id=160544
2245
2246         Reviewed by Michael Catanzaro.
2247
2248         * gtk/jhbuildrc: Pass -O2 when building the JHBuild, as also -g1
2249         which don't increases the required disk space significatively and
2250         provides better debug information than no passing it.
2251
2252 2016-08-09  Csaba Osztrogonác  <ossy@webkit.org>
2253
2254         Allow more --cmakeargs option in build-jsc and build-webkit
2255         https://bugs.webkit.org/show_bug.cgi?id=160340
2256
2257         Reviewed by Michael Catanzaro.
2258
2259         * Scripts/build-jsc:
2260         * Scripts/build-webkit:
2261
2262 2016-08-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2263
2264         Do not check if WebKitLibraries folder exists on EFL and GTK
2265         https://bugs.webkit.org/show_bug.cgi?id=160659
2266
2267         Reviewed by Csaba Osztrogonác.
2268
2269         Though WebKitLibraries is only needed by mac and win ports,
2270         EFL and GTK ports have checked whether it exists.
2271
2272         * Scripts/build-webkit:
2273
2274 2016-08-08  Aakash Jain  <aakash_jain@apple.com>
2275
2276         Some EWS console logs doesn't go to log file
2277         https://bugs.webkit.org/show_bug.cgi?id=160585
2278         rdar://problem/24464570
2279
2280         Reviewed by Daniel Bates.
2281
2282         * Scripts/webkitpy/common/system/logutils.py:
2283         (FileSystemHandler._open): Ensure that we open logfile in append mode in order to avoid
2284         any possible overwriting.
2285         * Scripts/webkitpy/common/system/filesystem.py:
2286         (FileSystem.open_text_file_for_writing): Add should_append parameter to append to file.
2287         * Scripts/webkitpy/common/system/filesystem_mock.py:
2288         (MockFileSystem.open_text_file_for_writing): Same.
2289         * Scripts/webkitpy/common/system/filesystem_unittest.py:
2290         (RealFileSystemTest.test_read_and_write_text_file): Removed unused variable 'hex_equivalent'.
2291         (RealFileSystemTest.test_append_to_text_file): Added new unit test for testing append functionality.
2292         * Scripts/webkitpy/tool/commands/queues.py:
2293         (AbstractQueue.begin_work_queue): Configure the logger for overall webkitpy to log to file.
2294         This will ensure that all the sub-modules inside webkitpy will log to file.
2295
2296 2016-08-08  Simon Fraser  <simon.fraser@apple.com>
2297
2298         Have the iOS platform interit from the Apple platform in webkitpy
2299         https://bugs.webkit.org/show_bug.cgi?id=160672
2300
2301         Reviewed by Dan Bates.
2302         
2303         The IOSSimulatorPort used to inherit from Port, rather than ApplePort.
2304         Fix this, and move duplicated code from IOSSimulatorPort and MacPort into
2305         ApplePort.
2306         
2307         Since WinPort also inherits from ApplePort, it needs to stub out some things
2308         that are unavailable on Windows (leaks, sampling).
2309         
2310         Some SnowLeopard-related code and the associated test were removed.
2311
2312         * Scripts/webkitpy/port/apple.py:
2313         (ApplePort.__init__):
2314         (ApplePort):
2315         (ApplePort._make_leak_detector):
2316         (ApplePort.default_timeout_ms):
2317         (ApplePort.supports_per_test_timeout):
2318         (ApplePort.should_retry_crashes):
2319         (ApplePort._generate_all_test_configurations):
2320         (ApplePort.check_for_leaks):
2321         (ApplePort.print_leaks_summary):
2322         (ApplePort._path_to_webcore_library):
2323         (ApplePort.show_results_html_file):
2324         (ApplePort._merge_crash_logs):
2325         (ApplePort._look_for_all_crash_logs_in_log_dir):
2326         (ApplePort._get_crash_log):
2327         (ApplePort.look_for_new_crash_logs):
2328         (ApplePort.sample_process):
2329         (ApplePort.sample_file_path):
2330         (ApplePort.look_for_new_samples):
2331         (ApplePort._path_to_helper):
2332         (ApplePort.determine_full_port_name): Deleted.
2333         * Scripts/webkitpy/port/ios.py:
2334         (IOSSimulatorPort):
2335         (IOSSimulatorPort.__init__):
2336         (IOSSimulatorPort.default_timeout_ms): Deleted.
2337         (IOSSimulatorPort.supports_per_test_timeout): Deleted.
2338         (IOSSimulatorPort.should_retry_crashes): Deleted.
2339         (IOSSimulatorPort.check_for_leaks): Deleted.
2340         (IOSSimulatorPort.print_leaks_summary): Deleted.
2341         (IOSSimulatorPort._path_to_webcore_library): Deleted.
2342         (IOSSimulatorPort.show_results_html_file): Deleted.
2343         (IOSSimulatorPort.sample_file_path): Deleted.
2344         (IOSSimulatorPort._merge_crash_logs): Deleted.
2345         (IOSSimulatorPort._look_for_all_crash_logs_in_log_dir): Deleted.
2346         (IOSSimulatorPort.look_for_new_crash_logs): Deleted.
2347         (IOSSimulatorPort.look_for_new_samples): Deleted.
2348         (IOSSimulatorPort.sample_process): Deleted.
2349         (IOSSimulatorPort._path_to_helper): Deleted.
2350         (IOSSimulatorPort.make_command): Deleted.
2351         * Scripts/webkitpy/port/mac.py:
2352         (MacPort.__init__):
2353         (MacPort.make_command):
2354         (MacPort._build_java_test_support):
2355         (MacPort): Deleted.
2356         (MacPort.default_timeout_ms): Deleted.
2357         (MacPort.supports_per_test_timeout): Deleted.
2358         (MacPort.should_retry_crashes): Deleted.
2359         (MacPort.default_child_processes): Deleted.
2360         (MacPort.check_for_leaks): Deleted.
2361         (MacPort.print_leaks_summary): Deleted.
2362         (MacPort._path_to_webcore_library): Deleted.
2363         (MacPort.show_results_html_file): Deleted.
2364         (MacPort.sample_file_path): Deleted.
2365         (MacPort._merge_crash_logs): Deleted.
2366         (MacPort._look_for_all_crash_logs_in_log_dir): Deleted.
2367         (MacPort.look_for_new_crash_logs): Deleted.
2368         (MacPort.look_for_new_samples): Deleted.
2369         (MacPort.sample_process): Deleted.
2370         (MacPort._path_to_helper): Deleted.
2371         * Scripts/webkitpy/port/mac_unittest.py:
2372         (MacTest.test_default_child_processes): Deleted.
2373         * Scripts/webkitpy/port/win.py:
2374         (WinPort.look_for_new_samples):
2375         (WinPort):
2376         (WinPort.sample_process):
2377         (WinPort._make_leak_detector):
2378         (WinPort.check_for_leaks):
2379         (WinPort.print_leaks_summary):
2380         (WinPort._path_to_webcore_library):
2381
2382 2016-08-08  Matt Baker  <mattbaker@apple.com>
2383
2384         Unreviewed: moved myself to the reviewers list.
2385
2386         * Scripts/webkitpy/common/config/contributors.json:
2387
2388 2016-08-08  Chris Dumez  <cdumez@apple.com>
2389
2390         Update API tests in mac/SetDocumentURI.mm after r204247
2391         https://bugs.webkit.org/show_bug.cgi?id=160660
2392
2393         Reviewed by Alex Christensen.
2394
2395         * TestWebKitAPI/Tests/mac/SetDocumentURI.mm:
2396         (TestWebKitAPI::TEST):
2397
2398 2016-08-08  Jonathan Bedard  <jbedard@apple.com>
2399
2400         run-webkit-tests should trigger a spindump when WebContent process is unresponsive
2401         https://bugs.webkit.org/show_bug.cgi?id=159827
2402
2403         Reviewed by Daniel Bates.
2404
2405         This change was spurred by a process hang which occurred between tests and did
2406         not produce a meaningful crashlog.
2407
2408         * Scripts/webkitpy/port/driver.py:
2409         (Driver._check_for_driver_crash_or_unresponsiveness): Notify test controller when finished through stdin.
2410
2411          * Scripts/webkitpy/port/ios.py:
2412         (IOSSimulatorPort):
2413         (IOSSimulatorPort.sample_process): Attempt spindump, but use sample if spindump fails.
2414         * Scripts/webkitpy/port/mac.py:
2415         (MacPort):
2416         (MacPort.sample_process): Attempt spindump, but use sample if spindump fails.
2417
2418         * Scripts/webkitpy/port/mac_unittest.py: Changed expected values to match spindump calls, added specific spindump test.
2419         * Scripts/webkitpy/port/driver_unittest.py: Added dummy write function.
2420
2421         * WebKitTestRunner/TestController.h:
2422         (WTR::TestController::usingServerMode): Added accessor for m_usingServerMode.
2423         * WebKitTestRunner/TestInvocation.cpp:
2424         (WTR::TestInvocation::dumpWebProcessUnresponsiveness): Wait for stdin before continuing when in server mode.
2425
2426 2016-08-07  Dan Bernstein  <mitz@apple.com>
2427
2428         [Cocoa] Reply block leaks if the remote object doesn’t call it
2429         https://bugs.webkit.org/show_bug.cgi?id=160642
2430
2431         Reviewed by Sam Weinig.
2432
2433         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h: Declared a new method.
2434         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
2435         (TEST): Added a test case that checks that the reply block is released even when it’s not
2436           called.
2437         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
2438         (-[RemoteObjectRegistryPlugIn doNotCallCompletionHandler:]): Implement new method by not
2439           calling the completion handler.
2440
2441 2016-08-07  Chris Dumez  <cdumez@apple.com>
2442
2443         Write API test to cover crash fix in r204135
2444         https://bugs.webkit.org/show_bug.cgi?id=160587
2445
2446         Reviewed by Darin Adler.
2447
2448         Add API test to cover crash fix in r204135. This reproduces the crash
2449         by destroying a related WKWebView in the webViewWebContentProcessDidTerminate
2450         callback.
2451
2452         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
2453         (-[NavigationDelegate webViewWebContentProcessDidTerminate:]):
2454         (TEST):
2455
2456 2016-08-06  Chris Dumez  <cdumez@apple.com>
2457
2458         Unreviewed, rolling out r204226.
2459
2460         Broke some API tests
2461
2462         Reverted changeset:
2463
2464         "Write API test to cover crash fix in r204135"
2465         https://bugs.webkit.org/show_bug.cgi?id=160587
2466         http://trac.webkit.org/changeset/204226
2467
2468 2016-08-06  Aakash Jain  <aakash_jain@apple.com>
2469
2470         EWS Style Queue fails to process patches which fails validation
2471         https://bugs.webkit.org/show_bug.cgi?id=160632
2472
2473         Reviewed by Alexey Proskuryakov.
2474
2475         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
2476         (StyleQueueTask.validate): Add more information about validation failure.
2477         (StyleQueueTask.run): Pass the error details in the PatchIsNotValid exception.
2478         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2479         (test_non_valid_patch): Add a unit test to test the above code path.
2480
2481 2016-08-06  Sam Weinig  <sam@webkit.org>
2482
2483         WTF needs a variant implementation
2484         https://bugs.webkit.org/show_bug.cgi?id=160618
2485
2486         Reviewed by Darin Adler.
2487
2488         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2489         * TestWebKitAPI/Tests/WTF/Variant.cpp: Added.
2490         Add tests for the variant implementation.
2491
2492 2016-08-06  Chris Dumez  <cdumez@apple.com>
2493
2494         Write API test to cover crash fix in r204135
2495         https://bugs.webkit.org/show_bug.cgi?id=160587
2496
2497         Reviewed by Darin Adler.
2498
2499         Add API test to cover crash fix in r204135. This reproduces the crash
2500         by destroying a related WKWebView in the webViewWebContentProcessDidTerminate
2501         callback.
2502
2503         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
2504         (-[NavigationDelegate webViewWebContentProcessDidTerminate:]):
2505         (TEST):
2506
2507 2016-08-05  Tim Horton  <timothy_horton@apple.com>
2508
2509         run-api-tests should use a headed simulator
2510         https://bugs.webkit.org/show_bug.cgi?id=160611
2511
2512         Reviewed by Sam Weinig.
2513
2514         CADisplayLink doesn't work in a headless simulator, but is
2515         vital for the proper functioning of WebKit2 painting on iOS.
2516         So, we should not use a headless simulator.
2517
2518         * Scripts/run-api-tests:
2519         Launch a simulator app, don't just boot the simulator.
2520
2521         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
2522         Re-enable a test that works now.
2523
2524 2016-08-05  Dan Bernstein  <mitz@apple.com>
2525
2526         [Cocoa] WKRemoteObjectCoder doesn’t handle NSRange
2527         https://bugs.webkit.org/show_bug.cgi?id=160589
2528
2529         Reviewed by Tim Horton.
2530
2531         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
2532         (remoteObjectInterface): Fixed a mistake in the set of allowed classes in one of the reply
2533           blocks, which wasn’t caught because the test wasn’t run correctly.
2534         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
2535         (TEST): Fixed the -selectionAndClickInformationForClickAtPoint:completionHandler: test, and
2536           added a test that sends over an NSRange.
2537         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
2538         (-[RemoteObjectRegistryPlugIn takeRange:completionHandler:]): Added. Calls the completion
2539           handler with the range‘s location and length.
2540
2541 2016-08-05  Enrica Casucci  <enrica@apple.com>
2542
2543         Fixing tests failing after r204175.
2544
2545         Unreviewed.
2546
2547         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig:
2548
2549 2016-08-05  Enrica Casucci  <enrica@apple.com>
2550
2551         Build fix after 204053.
2552
2553         Unreviewed.
2554
2555         * TestWebKitAPI/Configurations/Base.xcconfig:
2556         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
2557         (-[MockContentFilterEnabler initWithCoder:]):
2558         (-[MockContentFilterEnabler dealloc]):
2559
2560 2016-08-05  Konstantin Tokarev  <annulen@yandex.ru>
2561
2562         Print test name in "Last character read from DRT..." error message.
2563         https://bugs.webkit.org/show_bug.cgi?id=160559
2564
2565         Reviewed by Michael Catanzaro.
2566
2567         * Scripts/webkitpy/port/driver.py:
2568         (Driver.run_test):
2569         (Driver._read_first_block):
2570         (Driver._read_optional_image_block):
2571         (Driver._read_block):
2572         * Scripts/webkitpy/port/driver_unittest.py:
2573         (DriverTest.test_read_block):
2574         (DriverTest.test_read_binary_block):
2575         (DriverTest.test_read_base64_block):
2576
2577 2016-08-05  Commit Queue  <commit-queue@webkit.org>
2578
2579         Unreviewed, rolling out r204123.
2580         https://bugs.webkit.org/show_bug.cgi?id=160597
2581
2582         Caused layout test timeouts on Windows. (Requested by perarne
2583         on #webkit).
2584
2585         Reverted changeset:
2586
2587         "[Win] Unable to reliably run tests in parallel"
2588         https://bugs.webkit.org/show_bug.cgi?id=140914
2589         http://trac.webkit.org/changeset/204123
2590
2591 2016-08-04  Saam Barati  <sbarati@apple.com>
2592
2593         Restore CodeBlock jettison code to jettison when a CodeBlock has been alive for a long time
2594         https://bugs.webkit.org/show_bug.cgi?id=151241
2595
2596         Reviewed by Benjamin Poulain.
2597
2598         * Scripts/run-jsc-stress-tests:
2599
2600 2016-08-04  Dean Johnson  <dean_johnson@apple.com>
2601
2602         UI improvements to Flakiness Dashboard.
2603         https://bugs.webkit.org/show_bug.cgi?id=153295
2604
2605         Reviewed by Alexey Proskuryakov.
2606
2607         * TestResultServer/static-dashboards/flakiness_dashboard.css:
2608         (td.options-container): Center text in most fields.
2609         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2610         (createBugHTML): Text/Grammar updates.
2611         (tableHeaders): Ditto.
2612         (htmlForSingleTestRow): Ditto.
2613         (headerForTestTableHtml): Ditto.
2614         * TestResultServer/static-dashboards/ui.js: Removed the "Group: " and "Test type: " headings.
2615         (ui.html.testTypeSwitcher): Deleted. Removes the "Group:" heading.
2616
2617 2016-08-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2618
2619         [GTK] install-dependencies script misses libxslt as build-dependency and some python libs for the run-benchmark script
2620         https://bugs.webkit.org/show_bug.cgi?id=160518
2621
2622         Reviewed by Michael Catanzaro.
2623
2624         * Scripts/webkitpy/thirdparty/__init__.py:
2625         (AutoinstallImportHook._install_twisted): Twisted requires zope.interface.
2626         * gtk/install-dependencies:
2627
2628 2016-08-04  Alexey Proskuryakov  <ap@apple.com>
2629
2630         Optimize bot watcher's dashboard a little
2631         https://bugs.webkit.org/show_bug.cgi?id=160515
2632         rdar://problem/26096900
2633
2634         Reviewed by Lucas Forschler.
2635
2636         Made re-sorting after loading an iteration more efficient.
2637
2638         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2639         (BuildbotIteration.prototype._updateWithData):
2640         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2641         (BuildbotQueue.prototype.updateIterationPosition):
2642
2643 2016-08-04  Per Arne Vollan  <pvollan@apple.com>
2644
2645         [Win] Unable to reliably run tests in parallel
2646         https://bugs.webkit.org/show_bug.cgi?id=140914
2647
2648         Reviewed by Brent Fulgham.
2649
2650         The cygpath utility function can fail badly when running with multiple DumpRenderTree
2651         processes. We can use string replacement to convert the Cygwin path to a Windows path
2652         instead.
2653  
2654         * Scripts/webkitpy/common/system/path.py:
2655         (cygpathFast):
2656         * Scripts/webkitpy/port/driver.py:
2657         (Driver._command_from_driver_input):
2658
2659 2016-08-03  Aakash Jain  <aakash_jain@apple.com>
2660
2661         Document instructions for increasing process and file limits
2662         https://bugs.webkit.org/show_bug.cgi?id=160528
2663         rdar://problem/24777576
2664
2665         Reviewed by Alexey Proskuryakov.
2666
2667         * Scripts/webkitpy/port/ios.py:
2668         (IOSSimulatorPort.default_child_processes):
2669
2670 2016-08-03  Anders Carlsson  <andersca@apple.com>
2671
2672         Remove the Objective-C bindings generator
2673         https://bugs.webkit.org/show_bug.cgi?id=160526
2674
2675         Reviewed by Sam Weinig.
2676
2677         * Scripts/run-bindings-tests:
2678         Update test.
2679
2680 2016-08-03  Tim Horton  <timothy_horton@apple.com>
2681
2682         Revise a TestWebKitAPI comment to mention the actual underlying problem
2683
2684         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
2685         Note that this is because of https://bugs.webkit.org/show_bug.cgi?id=160516
2686
2687 2016-08-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2688
2689         Benchmark test content-animation timeouts always
2690         https://bugs.webkit.org/show_bug.cgi?id=160057
2691
2692         Reviewed by Simon Fraser.
2693
2694         * Scripts/webkitpy/benchmark_runner/data/plans/Skipped: Added.
2695         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
2696         (start):
2697
2698 2016-08-02  Nan Wang  <n_wang@apple.com>
2699
2700         AX: Simulated touch events are not working on iOS
2701         https://bugs.webkit.org/show_bug.cgi?id=160395
2702         <rdar://problem/27633597>
2703
2704         Reviewed by Chris Fleizach.
2705
2706         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2707         (WTR::AccessibilityUIElement::press):
2708         (WTR::AccessibilityUIElement::setSelectedChild):
2709
2710 2016-08-02  Filip Pizlo  <fpizlo@apple.com>
2711
2712         run-javascriptcore-tests should accept multiple --extra-tests
2713         https://bugs.webkit.org/show_bug.cgi?id=160486
2714
2715         Reviewed by Saam Barati.
2716         
2717         We want to be able to pass --extra-tests multiple times, to supply an arbitrary number of extra
2718         test suites. This does it by using GetOpt::Long's array support.
2719
2720         * Scripts/run-javascriptcore-tests:
2721         (runJSCStressTests):
2722
2723 2016-08-02  Enrica Casucci  <enrica@apple.com>
2724
2725         Allow building with content filtering disabled.
2726         https://bugs.webkit.org/show_bug.cgi?id=160454
2727
2728         Reviewed by Simon Fraser.
2729
2730         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2731
2732 2016-08-02  Brady Eidson  <beidson@apple.com>
2733
2734         Removing IndexedDB WebsiteData can fail for some users.
2735         https://bugs.webkit.org/show_bug.cgi?id=160463
2736
2737         Reviewed by Alex Christensen.
2738
2739         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm:
2740
2741 2016-08-01  Alex Christensen  <achristensen@webkit.org>
2742
2743         _WKDownloadDelegate.didReceiveResponse should be called before decideDestinationWithSuggestedFilename
2744         https://bugs.webkit.org/show_bug.cgi?id=160437
2745         <rdar://problem/27578272>
2746
2747         Reviewed by Brady Eidson.
2748
2749         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2750         (-[DownloadDelegate _download:didReceiveResponse:]):
2751         (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
2752         (runTest):
2753         Add a boolean to make sure that didReceiveResponse is called before decideDestinationWithSuggestedFilename.
2754
2755 2016-08-01  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2756
2757         [Tools] The GDB backtrace report tool don't checks the gdb return code.
2758         https://bugs.webkit.org/show_bug.cgi?id=160414
2759
2760         Reviewed by Michael Catanzaro.
2761
2762         * Scripts/webkitpy/port/linux_get_crash_log.py:
2763         (GDBCrashLogGenerator._wait_for_corefile):
2764
2765 2016-08-01  Youenn Fablet  <youenn@apple.com>
2766
2767         Make wpt server generate its certificates in layout test results folder
2768         https://bugs.webkit.org/show_bug.cgi?id=160422
2769
2770         Reviewed by Chris Dumez.
2771
2772         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2773         (WebPlatformTestServer._copy_webkit_test_files): Setting certificate folder to layout tests results directory.
2774
2775 2016-08-01  Jonathan Bedard  <jbedard@apple.com>
2776
2777         Function Call on NULL Object
2778         https://bugs.webkit.org/show_bug.cgi?id=160325
2779
2780         Reviewed by Darin Adler.
2781
2782         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2783         (WTR::InjectedBundle::didReceiveMessageToPage): Changed removeAllWebNotificationPermissions() call to static function call.
2784         * WebKitTestRunner/InjectedBundle/TestRunner.h: Made all web-notification functions static.
2785
2786 2016-08-01  Keith Miller  <keith_miller@apple.com>
2787
2788         We should not keep the JavaScript tests inside the Source/JavaScriptCore/ directory.
2789         https://bugs.webkit.org/show_bug.cgi?id=160372
2790
2791         Rubber stamped by Geoffrey Garen.
2792
2793         This patch moves all the JavaScript tests from Source/JavaScriptCore/tests to
2794         a new top level directory, JSTests. Having the tests in the Source directory
2795         was both confusing an inconvenient for people that just want to checkout the
2796         source code of WebKit. Since there is no other obvious place to put all the
2797         JavaScript tests a new top level directory seemed the most sensible.
2798
2799         * Scripts/import-test262-tests:
2800         * Scripts/run-javascriptcore-tests:
2801         * Scripts/update-javascriptcore-test-res:
2802
2803 2016-07-31  Nan Wang  <n_wang@apple.com>
2804
2805         AX: Add a check for touch event listener on iOS accessibility object
2806         https://bugs.webkit.org/show_bug.cgi?id=160388
2807
2808         Reviewed by Chris Fleizach.
2809
2810         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2811         (AccessibilityUIElement::boolAttributeValue):
2812         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2813         (WTR::AccessibilityUIElement::boolAttributeValue):
2814
2815 2016-07-30  Manuel Rego Casasnovas  <rego@igalia.com>
2816
2817         Unreviewed: add myself to the reviewers list.
2818
2819         * Scripts/webkitpy/common/config/contributors.json:
2820
2821 2016-07-29  Alexey Proskuryakov  <ap@apple.com>
2822
2823         Undo r203939, and copy over a rule that clips the logos.
2824
2825         Sierra wasn't the only logo without transparency.
2826
2827         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
2828         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png:
2829         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2830
2831 2016-07-29  Alan Sien Wei Hshieh  <hshieh@apple.com>
2832
2833         The Sierra asset at build.webkit.org/dashboard/images/Sierra*.png has a white background
2834         https://bugs.webkit.org/show_bug.cgi?id=160377
2835
2836         Reviewed by Brian Weinstein.
2837
2838         Update assets to remove the white background and use a transparent background instead.
2839
2840         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
2841         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png:
2842
2843 2016-07-29  David Kilzer  <ddkilzer@apple.com>
2844
2845         Ignore most check-webkit-style checks for ANGLE project
2846         <https://webkit.org/b/160333>
2847
2848         Reviewed by Daniel Bates.
2849
2850         * Scripts/webkitpy/style/checker.py: Ignore all checkers except:
2851         - No tabs.
2852         - No spaces at the end of lines.
2853         - No carriage returns (DOS line endings).
2854
2855 2016-07-29  Wenson Hsieh  <wenson_hsieh@apple.com>
2856
2857         Media controls are not displayed for some autoplaying videos at certain browser dimensions
2858         https://bugs.webkit.org/show_bug.cgi?id=160360
2859         <rdar://problem/27179484>
2860
2861         Reviewed by Myles C. Maxfield.
2862
2863         Adds two tests verifying that videos may be considered main content as long as they
2864         are large enough and cover a majority of the mainframe's viewport.
2865
2866         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2867         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2868         (TestWebKitAPI::TEST):
2869         * TestWebKitAPI/Tests/WebKit2Cocoa/full-size-autoplaying-video-with-audio.html: Added.
2870         * TestWebKitAPI/Tests/WebKit2Cocoa/skinny-autoplaying-video-with-audio.html: Added.
2871
2872 2016-07-29  Mark Lam  <mark.lam@apple.com>
2873
2874         Gardening: removed unused variable.
2875
2876         Not reviewed.
2877
2878         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2879         (TestWebKitAPI::TEST):
2880
2881 2016-07-29  Wenson Hsieh  <wenson_hsieh@apple.com>
2882
2883         Add TestWebKitAPI support for interacting with media controls
2884         https://bugs.webkit.org/show_bug.cgi?id=160342
2885         <rdar://problem/27610246>
2886
2887         Reviewed by Beth Dakin.
2888
2889         Adds support for testing interaction with some media controls, as well as a basic test
2890         verifying that media control teardown after interaction does not result in a crash.
2891
2892         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2893         (-[WKWebView mouseDownAtPoint:]):
2894         (-[WKWebView performAfterLoading:]):
2895         (TestWebKitAPI::TEST):
2896
2897 2016-07-29  Jonathan Bedard  <jbedard@apple.com>
2898
2899         Crash Log Clobbering on Unbound Crashes
2900         https://bugs.webkit.org/show_bug.cgi?id=160198
2901         <rdar://problem/27472618>
2902
2903         Reviewed by Alexey Proskuryakov.
2904
2905         * Scripts/webkitpy/common/system/crashlogs.py:
2906         (CrashLogs): Fix header order.
2907         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2908         (TestResultWriter.output_filename): Only remove file extension if it is clearly a file extension.
2909
2910 2016-07-29  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
2911
2912         Update for contributors.json
2913         https://bugs.webkit.org/show_bug.cgi?id=160294
2914
2915         * Scripts/webkitpy/common/config/contributors.json:
2916
2917 2016-07-28  Myles C. Maxfield  <mmaxfield@apple.com>
2918
2919         Remove deprecated SPI for video inline / fullscreen controls
2920         https://bugs.webkit.org/show_bug.cgi?id=160318
2921
2922         Reviewed by Tim Horton.
2923
2924         * DumpRenderTree/mac/DumpRenderTree.mm:
2925         (setDefaultsToConsistentValuesForTesting): Deleted.
2926         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
2927         (RequiresUserActionForPlaybackTest::SetUp): Deleted.
2928         * WebKitTestRunner/TestController.cpp:
2929         (WTR::TestController::resetPreferencesToConsistentValues): Deleted.
2930         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2931         (WTR::initializeWebViewConfiguration): Deleted.
2932
2933 2016-07-28  Daniel Bates  <dabates@apple.com>
2934
2935         [iOS] TestWebKitAPI bundle targets are not code signed
2936         https://bugs.webkit.org/show_bug.cgi?id=160328
2937         <rdar://problem/27409246>
2938
2939         Reviewed by Andy Estes.
2940
2941         Workaround <rdar://problem/27459890> by explicitly defining Xcode build settings
2942         CODE_SIGNING_ALLOWED and AD_HOC_CODE_SIGNING_ALLOWED to be YES so as to allow the
2943         the TestWebKitAPI bundle targets to be code signed when building for the iOS simulator.
2944
2945         * TestWebKitAPI/Configurations/Base.xcconfig:
2946
2947 2016-07-28  Tim Horton  <timothy_horton@apple.com>
2948
2949         Disable WebKit2.ResizeWithHiddenContentDoesNotHang for now
2950
2951         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
2952         (animatedResizeWebView):
2953         (TEST):
2954         This test times out only when run in the WebKit Testing simulator environment,
2955         but not in a fresh simulator. Disabling to keep the bots green while under investigation.
2956
2957 2016-07-28  Tim Horton  <timothy_horton@apple.com>
2958
2959         Frequent animation lags when interacting with Safari (sidebar, tab switching, etc.)
2960         https://bugs.webkit.org/show_bug.cgi?id=160289
2961         <rdar://problem/27553464>
2962
2963         Reviewed by Simon Fraser.
2964
2965         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2966         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2967         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm: Added.
2968         (-[AnimatedResizeNavigationDelegate _webView:renderingProgressDidChange:]):
2969         (-[AnimatedResizeWebView _endAnimatedResize]):
2970         (animatedResizeWebView):
2971         (TEST):
2972         * TestWebKitAPI/Tests/WebKit2Cocoa/blinking-div.html: Added.
2973         Add two tests that ensure that hidden-content and animated resizes
2974         don't cause unnecessary synchronous waits. Only the hidden-content
2975         one fails before my patch, but it seemed reasonable to add both anyway.
2976
2977 2016-07-28  David Kilzer  <ddkilzer@apple.com>
2978
2979         webkit-patch upload --suggest-reviewers shouldn't break in the presence of deleted or moved files
2980         <https://webkit.org/b/83342>
2981
2982         Reviewed by Ryosuke Niwa.
2983
2984         * Scripts/webkitpy/common/checkout/scm/git.py:
2985         (Git.revisions_changing_file): Remove code to raise an exception
2986         when the file doesn't exist.  If a file was moved or renamed,
2987         then this caused the script to terminate, which was very
2988         frustrating when you wanted a list of reviewers.
2989         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2990         (SCMTest._shared_test_revisions_changing_file): Update test
2991         expectation to return an empty list of revisions.
2992         (test_create_patch_is_full_patch): Drive-by fix when running all
2993         webkitpy tests (including scm tests).
2994         * Scripts/webkitpy/common/checkout/scm/svn.py:
2995         (SVN.revisions_changing_file): Catch ScriptError exceptions and
2996         return an empty array of revisions if this occurs.
2997
2998 2016-07-28  Aakash Jain  <aakash_jain@apple.com>
2999
3000         EWS error message "Error: * did not process patch" should include explanation
3001         https://bugs.webkit.org/show_bug.cgi?id=159903
3002         <rdar://problem/27410788>
3003
3004         Reviewed by Alexey Proskuryakov.
3005
3006         * QueueStatusServer/handlers/statusbubble.py:
3007         (StatusBubble._build_bubble): Display more detailed error message on bubbles when patch
3008         is not processed.
3009         * QueueStatusServer/handlers/processingtimesjson.py:
3010         (ProcessingTimesJSON._resultFromFinalStatus): Updated error message to match with rest
3011         of the code.
3012         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3013         (CommitQueueTask.validate): Add more information about validation failure.
3014         (CommitQueueTask.run): Pass the error details in the PatchIsNotValid exception.
3015         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
3016         (EarlyWarningSystemTask.validate): Add more information about validation failure.
3017         (EarlyWarningSystemTask.run): Pass the error details in the PatchIsNotValid exception.
3018         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
3019         (PatchIsNotValid.__init__): Add the failure_message argument.
3020         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3021         (AbstractEarlyWarningSystem.review_patch): Re-word the error message and include
3022         failure details.
3023         * Scripts/webkitpy/tool/commands/queues.py:
3024         (CommitQueue.process_work_item): Same.
3025         (StyleQueue.review_patch): Same.
3026         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3027         (test_non_valid_patch): Updated test-cases messages to match the above changes.
3028
3029 2016-07-27  Alexey Proskuryakov  <ap@apple.com>
3030
3031         LayoutTestRelay should wait for WebKitTestRunnerApp installation to complete
3032         https://bugs.webkit.org/show_bug.cgi?id=160262
3033
3034         Reviewed by Daniel Bates.
3035
3036         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
3037         (-[LTRelayController installApp]):
3038
3039 2016-07-27  Ryan Haddad  <ryanhaddad@apple.com>
3040
3041         Disable WebCoreNSURLSessionTest API tests on ios-simulator
3042         https://bugs.webkit.org/show_bug.cgi?id=160225
3043
3044         Reviewed by Alexey Proskuryakov.
3045
3046         * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
3047
3048 2016-07-27  Miguel Gomez  <magomez@igalia.com>
3049
3050         [GTK] Fix some video/canvas tests that should be passing
3051         https://bugs.webkit.org/show_bug.cgi?id=160023
3052
3053         Reviewed by Carlos Garcia Campos.
3054
3055         Add a platform identifier to the TestRunner's page user agent when the tests are run on the
3056         EFL or GTK platforms.
3057
3058         * WebKitTestRunner/efl/TestControllerEfl.cpp:
3059         (WTR::TestController::platformConfigureViewForTest):
3060         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3061         (WTR::TestController::platformConfigureViewForTest):
3062
3063 2016-07-27  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3064
3065         [Tools] The built product doesn't contains the dwo files when DEBUG_FISSION is enabled.
3066         https://bugs.webkit.org/show_bug.cgi?id=160247
3067
3068         Reviewed by Michael Catanzaro.
3069
3070         * BuildSlaveSupport/built-product-archive:
3071         (createZip):
3072         (dirContainsdwo):
3073         (archiveBuiltProduct):
3074
3075 2016-07-26  Alex Christensen  <achristensen@webkit.org>
3076
3077         Fix tests after r203743.
3078         https://bugs.webkit.org/show_bug.cgi?id=156947
3079
3080         * WebKitTestRunner/TestController.cpp:
3081         (WTR::TestController::resetStateToConsistentValues):
3082         Reset the new boolean m_rejectsProtectionSpaceAndContinueForAuthenticationChallenges.
3083
3084 2016-07-26  Myles C. Maxfield  <mmaxfield@apple.com>
3085
3086         [iPhone] Playing a video on tudou.com plays only sound, no video
3087         https://bugs.webkit.org/show_bug.cgi?id=160178
3088         <rdar://problem/27535468>
3089
3090         Reviewed by Dan Bernstein.
3091
3092         * DumpRenderTree/mac/DumpRenderTree.mm:
3093         (setDefaultsToConsistentValuesForTesting):
3094         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
3095         (RequiresUserActionForPlaybackTest::SetUp):
3096         * WebKitTestRunner/TestController.cpp:
3097         (WTR::TestController::resetPreferencesToConsistentValues):
3098         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3099         (WTR::initializeWebViewConfiguration):
3100
3101 2016-07-26  Simon Fraser  <simon.fraser@apple.com>
3102
3103         Allow LOG macros to be used outside the namespace, and other logging cleanup
3104         https://bugs.webkit.org/show_bug.cgi?id=160216
3105
3106         Reviewed by Anders Carlsson.
3107         
3108         initializeLoggingChannelsIfNecessary -> initializeLogChannelsIfNecessary
3109
3110         * DumpRenderTree/TestRunner.cpp:
3111         * DumpRenderTree/mac/DumpRenderTree.mm:
3112         (resetWebViewToConsistentStateBeforeTesting):
3113
3114 2016-07-26  David Kilzer <ddkilzer@apple.com>
3115
3116         Networking process crash due to missing -[WebCoreAuthenticationClientAsChallengeSender performDefaultHandlingForAuthenticationChallenge:] implementation
3117         https://bugs.webkit.org/show_bug.cgi?id=156947
3118         <rdar://problem/23325160>
3119
3120         Reviewed by Alex Christensen.
3121
3122         * DumpRenderTree/TestRunner.cpp:
3123         (TestRunner::TestRunner):
3124         (setRejectsProtectionSpaceAndContinueForAuthenticationChallengesCallback):
3125         * DumpRenderTree/TestRunner.h:
3126         (TestRunner::rejectsProtectionSpaceAndContinueForAuthenticationChallenges):
3127         (TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
3128         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3129         (-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
3130         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3131         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3132         (WTR::TestRunner::queueNonLoadingScript):
3133         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
3134         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3135         * WebKitTestRunner/TestController.cpp:
3136         (WTR::TestController::didReceiveAuthenticationChallenge):
3137         * WebKitTestRunner/TestController.h:
3138         (WTR::TestController::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
3139         * WebKitTestRunner/TestInvocation.cpp:
3140         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3141         Add TestRunner.setRejectsProtectionSpaceAndContinueForAuthenticationChallenges to use for testing.
3142
3143 2016-07-26  David Kilzer  <ddkilzer@apple.com>
3144
3145         check-for-exit-time-destructors should be usable outside Xcode
3146         <https://webkit.org/b/160195>
3147
3148         Reviewed by Darin Adler.
3149
3150         * Scripts/check-for-exit-time-destructors: Update to parse
3151         -h|--help switch, or to take one argument to a binary to check
3152         for exit time destructors on the command-line.  The clang
3153         compiler will find these at compile-time with the
3154         -Wexit-time-destructors switch, but this script will check for
3155         them after-the-fact.
3156
3157 2016-07-26  Lucas Forschler  <lforschler@apple.com>
3158
3159         Test svn.webkit.org functionality after maintenance.
3160
3161 2016-07-25  Brady Eidson  <beidson@apple.com>
3162
3163         Modern IDB: Make sure IndexedDB works from file:// url documents by default
3164         https://bugs.webkit.org/show_bug.cgi?id=153783
3165
3166         Reviewed by Alex Christensen.
3167
3168         Previously, to grant IndexedDB access to file:// urls for testing purposes, 
3169         we had to call the SPI [WKWebViewConfiguration _setAllowUniversalAccessFromFileURLs:].
3170         
3171         As of https://trac.webkit.org/changeset/203695 this is no longer required.
3172         
3173         Change the relevant API tests to make sure this continues to be no longer required.
3174
3175         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
3176         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
3177         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
3178         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
3179         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm:
3180         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
3181
3182 2016-07-25  Wenson Hsieh  <wenson_hsieh@apple.com>
3183
3184         Media controls should not be displayed for a video until it starts playing
3185         https://bugs.webkit.org/show_bug.cgi?id=160092
3186         <rdar://problem/26986673>
3187
3188         Reviewed by Beth Dakin.
3189
3190         Verify that multiple videos do or don't show the media controller depending on whether videos
3191         are playing. Also tweaks an existing API test (VideoControlsManagerSingleLargeVideo) that was
3192         passing because we were always showing media controls for large videos with audio, even if they
3193         had not played back yet. This change ensures that large videos with audio show media controls
3194         only after they begin to play back, and not by virtue of being large enough for main content.
3195
3196         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3197         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
3198         (TestWebKitAPI::TEST):
3199         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-with-audio.html:
3200         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio-autoplay.html: Added.
3201         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio.html: Added.
3202
3203 2016-07-25  Wenson Hsieh  <wenson_hsieh@apple.com>
3204
3205         Media controls on apple.com don't disappear when movie finishes playing
3206         https://bugs.webkit.org/show_bug.cgi?id=160068
3207         <rdar://problem/26668526>
3208
3209         Reviewed by Darin Adler.
3210
3211         Adds new API tests. Please see WebCore ChangeLog for more details.
3212
3213         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3214         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
3215         (-[MediaPlaybackMessageHandler initWithWKWebView:finalMessageString:]):
3216         (-[MediaPlaybackMessageHandler userContentController:didReceiveScriptMessage:]):
3217         (TestWebKitAPI::TEST):
3218         (-[DidPlayMessageHandler initWithWKWebView:]): Deleted.
3219         (-[DidPlayMessageHandler userContentController:didReceiveScriptMessage:]): Deleted.
3220         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-hides-controls-after-seek-to-end.html: Added.
3221         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-after-ending.html: Added.
3222         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-to-beginning-and-play-after-ending.html: Added.
3223
3224 2016-07-25  Philippe Normand  <pnormand@igalia.com>
3225
3226         Unreviewed, fix test-webkitpy after r203674.
3227
3228         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
3229         (GDBCrashLogGeneratorTest.test_generate_crash_log):
3230
3231 2016-07-24  Philippe Normand  <pnormand@igalia.com>
3232
3233         Unreviewed, forgot to commit this file in r203674.
3234
3235         * Scripts/process-linux-coredump: Added.
3236         (main):
3237
3238 2016-07-25  Philippe Normand  <pnormand@igalia.com>
3239
3240         Improve GDB backtrace generation for GTK/EFL
3241         https://bugs.webkit.org/show_bug.cgi?id=128928
3242
3243         Reviewed by Carlos Garcia Campos.
3244
3245         The PID of the crashed process is now correctly supplied to the
3246         crash log reporter. The kernel core_pattern needs to be updated
3247         after this change to something like:
3248
3249         echo "|/home/phil/WebKit/Tools/Scripts/process-linux-coredump /tmp/core-pid_%p.dump" > /proc/sys/kernel/core_pattern
3250
3251         * Scripts/process-linux-coredump: Added.
3252         (main): Minimal python script reading coredump data on stdin and writing it to a file in /tmp/.
3253         * Scripts/webkitpy/port/efl.py:
3254         (EflPort._get_crash_log): Supply path of the process-linux-coredump script.
3255         * Scripts/webkitpy/port/gtk.py:
3256         (GtkPort._get_crash_log): Ditto.
3257         * Scripts/webkitpy/port/linux_get_crash_log.py:
3258         (GDBCrashLogGenerator.__init__): New argument for supplying the path of a coredump processor script.
3259         (GDBCrashLogGenerator.generate_crash_log): Update error message, the core_pattern should now be set to pipe coredumps to a script.
3260         (GDBCrashLogGenerator): Deleted.
3261         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
3262         (GDBCrashLogGeneratorTest.test_generate_crash_log): Update test expectations.
3263         * WebKitTestRunner/TestController.cpp:
3264         (WTR::TestController::networkProcessDidCrash): Supply PID of crash process.
3265         (WTR::TestController::databaseProcessDidCrash): Ditto.
3266         (WTR::TestController::processDidCrash): Ditto.
3267
3268 2016-07-23  Youenn Fablet  <youenn@apple.com>
3269
3270         WPT stash server should be kept running when launching wpt server
3271         https://bugs.webkit.org/show_bug.cgi?id=160052
3272
3273         Reviewed by Sam Weinig.
3274
3275         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
3276         (main): waiting to read stdin while stash server is started.
3277
3278 2016-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3279
3280         Media controls should be displayed for media in media documents
3281         https://bugs.webkit.org/show_bug.cgi?id=160104
3282         <rdar://problem/27438936>
3283
3284         Reviewed by Myles C. Maxfield.
3285
3286         Verifies that even a small video with audio in a media document gets media controls.
3287
3288         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
3289         (TestWebKitAPI::TEST):
3290
3291 2016-07-22  Michael Saboff  <msaboff@apple.com>
3292
3293         REGRESSION(203616): no FTL testing was inadvertently removed
3294         https://bugs.webkit.org/show_bug.cgi?id=160100
3295
3296         Rubber-stamped by Filip Pizlo.
3297
3298         Added runNoFTL back into the set of tests we run on FTL enabled platforms.
3299         Renamed runLayoutTestNoFTL to runLayoutTestDefault.  Restructured the test
3300         logic for the runLayout and runNoisy variants to match the run test logic,
3301         that is we always invoke runXXXDefault and invoke runXXXNoFTL for FTL
3302         enabled platforms.
3303
3304         * Scripts/run-jsc-stress-tests:
3305
3306 2016-07-22  Brady Eidson  <beidson@apple.com>
3307
3308         Removing IndexedDatabases that have stored blobs doesn't remove the blob files.
3309         https://bugs.webkit.org/show_bug.cgi?id=160089
3310
3311         Reviewed by Darin Adler.
3312
3313         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3314         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm: Added.
3315         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobToBeDeleted.html: Added.
3316
3317 2016-07-22  Konstantin Tokarev  <annulen@yandex.ru>
3318
3319         [GTK] Improved exclusion patterns in make-dist.py manifest.
3320         https://bugs.webkit.org/show_bug.cgi?id=160094
3321
3322         Reviewed by Michael Catanzaro.
3323
3324         * gtk/manifest.txt.in:
3325         Exclude Platform*.cmake files for more ports.
3326         Removed obsolete .gyp and .pro.user patterns.
3327         Exclude 'Configurations' and 'spi' directories.
3328         Exclude CMakeLists.txt.user (Qt Creator IDE).
3329
3330 2016-07-22  Michael Saboff  <msaboff@apple.com>
3331
3332         Don't run FTL related JSC stress tests on non-FTL platforms
3333         https://bugs.webkit.org/show_bug.cgi?id=160033
3334
3335         Reviewed by Mark Lam.
3336
3337         Added check for running tests on platforms that don't enable FTL to not run FTL tests.
3338         Refactored several of the runXXX test methods to always runXXXDefault and made those
3339         runXXXDefault to pass FTL_OPTIONS.  For platforms that don't enable the FTL, FTL_OPTIONS
3340         doesn't cause a problem.
3341
3342         * Scripts/run-jsc-stress-tests:
3343
3344 2016-07-22  Per Arne Vollan  <pvollan@apple.com>
3345
3346         IWebView::mainFrame crashes if called after IWebView::close
3347         https://bugs.webkit.org/show_bug.cgi?id=32868
3348
3349         Reviewed by Brent Fulgham.
3350
3351         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp:
3352         (TestWebKitAPI::TEST_F): Added test.
3353
3354 2016-07-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3355
3356         [GTK] Enable threaded compositor by default
3357         https://bugs.webkit.org/show_bug.cgi?id=160079
3358
3359         Reviewed by Žan Doberšek.
3360
3361         * Scripts/webkitperl/FeatureList.pm:
3362
3363 2016-07-22  Youenn Fablet  <youenn@apple.com>
3364
3365         run-builtins-generator-tests should be able to test WebCore builtins wrapper with more than one file
3366         https://bugs.webkit.org/show_bug.cgi?id=159921
3367
3368         Reviewed by Brian Burg.
3369
3370         Updated builtin generator test runner to generate WebCore wrapper files based on all WebCore valid separate files.
3371
3372         * Scripts/webkitpy/codegen/main.py:
3373         (BuiltinsGeneratorTests.generate_from_js_builtins): Passing a list of builtin files to the script.
3374         (BuiltinsGeneratorTests):
3375         (BuiltinsGeneratorTests.single_builtin_test): Added to handle the case of single builtin generation.
3376         (BuiltinsGeneratorTests.wrappers_builtin_test): Added to handle the case of WebCore wrappers builtin generation.
3377         (BuiltinsGeneratorTests.run_test): Helper routine to run a test in reset mode or normal check mode.
3378         (BuiltinsGeneratorTests.run_tests): Updated to add WebCore wrappers builtin generation test.
3379
3380 2016-07-21  Dan Bernstein  <mitz@apple.com>
3381
3382         [Mac] webkitdirs.pm contains unused code to support outdated OS X and Xcode versions
3383         https://bugs.webkit.org/show_bug.cgi?id=160072
3384
3385         Reviewed by Andy Estes.
3386
3387         * Scripts/webkitdirs.pm:
3388         (readXcodeUserDefault): Changed to take a defaults key rather than a suffix. Removed support
3389           for old Xcode versions.
3390         (determineBaseProductDir): Removed support for old Xcode versions. Updated for the change
3391           to readXcodeUserDefault.
3392         (debugger): Deleted. This was only used for Darwin, where LLDB is now the only supported
3393           debugger.
3394         (determineDebugger): Ditto.
3395         (checkRequiredSystemConfig): Updated to require at least OS X Yosemite v10.10.5 and Xcode
3396           7.0.
3397         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Removed --use-gdb and --use-lldb
3398           switches.
3399         (execMacWebKitAppForDebugging): Removed support for GDB.
3400
3401 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
3402
3403         Remove support for deprecated SPI inlineMediaPlaybackRequiresPlaysInlineAttribute
3404         https://bugs.webkit.org/show_bug.cgi?id=160066
3405
3406         Reviewed by Dean Jackson.
3407
3408         * DumpRenderTree/mac/DumpRenderTree.mm:
3409         (setDefaultsToConsistentValuesForTesting): Deleted.
3410         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
3411         (RequiresUserActionForPlaybackTest::SetUp): Deleted.
3412         * WebKitTestRunner/TestController.cpp:
3413         (WTR::TestController::resetPreferencesToConsistentValues): Deleted.
3414         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3415         (WTR::initializeWebViewConfiguration): Deleted.
3416
3417 2016-07-21  Chelsea Pugh  <cpugh@apple.com>
3418
3419         [iOS] Apps using WKWebView will crash if they set the scroll view's delegate and don't nil it out later
3420         https://bugs.webkit.org/show_bug.cgi?id=159980
3421         rdar://problem/27450825
3422
3423         Reviewed by Dan Bernstein.
3424
3425         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3426         * TestWebKitAPI/Tests/ios/WKScrollViewDelegateCrash.mm: Added.
3427         (-[TestDelegateForScrollView dealloc]): Update delegateIsDeallocated to true so that we can tell
3428         when our delegate has hit -dealloc.
3429         (TestWebKitAPI::TEST): Ensure that after an object has been set as the scroll view's delegate,
3430         and has then been deallocated, that the scroll view's delegate is nil and the deallocated delegate
3431         will not be messaged.
3432
3433 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
3434
3435         Follow-up patch to r203520
3436         https://bugs.webkit.org/show_bug.cgi?id=159967
3437         <rdar://problem/26964090>
3438
3439         Unreviewed.
3440
3441         * DumpRenderTree/mac/DumpRenderTree.mm:
3442         (setDefaultsToConsistentValuesForTesting):
3443         * WebKitTestRunner/TestController.cpp:
3444         (WTR::TestController::resetPreferencesToConsistentValues):
3445
3446 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
3447
3448         [iPhone] Playing a video on tudou.com plays only sound, no video
3449         https://bugs.webkit.org/show_bug.cgi?id=159967
3450         <rdar://problem/26964090>
3451
3452         Reviewed by Jon Lee, Jeremy Jones, and Anders Carlsson.
3453
3454         Migrate tests to use new SPI.
3455
3456         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
3457         (RequiresUserActionForPlaybackTest::SetUp):
3458         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3459         (WTR::initializeWebViewConfiguration):
3460
3461 2016-07-21  Csaba Osztrogonác  <ossy@webkit.org>
3462
3463         Clarify testing mode names in run-jsc-stress-tests
3464         https://bugs.webkit.org/show_bug.cgi?id=160021
3465
3466         Reviewed by Mark Lam.
3467
3468         Default should mean really default, not default with disabled FTL, renamed
3469         - runMozillaTestDefault to runMozillaTestNoFTL
3470         - runMozillaTestDefaultFTL to runMozillaTestDefault
3471         - runDefault to runNoFTL
3472         - runDefaultFTL to runDefault
3473         - runLayoutTestDefault to runLayoutTestNoFTL
3474         - runLayoutTestDefaultFTL to runLayoutTestDefault
3475         - runNoisyTestDefault to runNoisyTestNoFTL
3476         - runNoisyTestDefaultFTL to runNoisyTestDefault
3477
3478         * Scripts/run-jsc-stress-tests:
3479
3480 2016-07-21  Yongjun Zhang  <yongjun_zhang@apple.com>
3481
3482         WebBackForwardList's currentIndex could get out of bounds when filtering items.
3483         https://bugs.webkit.org/show_bug.cgi?id=159986
3484
3485         Add a test to verify filtering out 2 items from a 3-item list will set the currentIndex
3486         to 0.
3487
3488         Reviewed by Dan Bernstein.
3489
3490         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3491         * TestWebKitAPI/Tests/WebKit2/WKBackForwardList.mm: Added.
3492         (-[WKBackForwardListTestNavigationDelegate webView:didFinishNavigation:]):
3493         (TEST):
3494
3495 2016-07-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3496
3497         [GTK] Web view background colors don't work in accelerated compositing mode
3498         https://bugs.webkit.org/show_bug.cgi?id=159455
3499
3500         Reviewed by Michael Catanzaro.
3501
3502         Set always RGBA visual to the view widget when setting a background color.
3503
3504         * MiniBrowser/gtk/BrowserWindow.c:
3505         (browser_window_set_background_color):
3506
3507 2016-07-20  Youenn Fablet  <youenn@apple.com>
3508
3509         Bots should run built-ins generator tests
3510         https://bugs.webkit.org/show_bug.cgi?id=159971
3511
3512         Reviewed by Alexey Proskuryakov.
3513
3514         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3515         (RunBuiltinsTests): New step to run built-in generator tests.
3516         (TestFactory.__init__): Adding an additional step for bultin generator tests.
3517         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Rebasing expectations.
3518         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Adding additional step for proper display.
3519
3520 2016-07-20  Aakash Jain  <aakash_jain@apple.com>
3521
3522         Revert temporary fix r203417
3523         https://bugs.webkit.org/show_bug.cgi?id=160001
3524
3525         Reviewed by Alexey Proskuryakov.
3526
3527         * EWSTools/start-queue-mac.sh: Revert the temporary fix.
3528
3529 2016-07-20  Aakash Jain  <aakash_jain@apple.com>
3530
3531         REGRESSION(r148588): ews classes might get garbage collected
3532         https://bugs.webkit.org/show_bug.cgi?id=159990
3533
3534         Reviewed by Ryosuke Niwa.
3535
3536         * Scripts/webkitpy/tool/commands/__init__.py: Store the loaded ews classes
3537         in a variable so that they do not get garbage collected.
3538
3539 2016-07-20  Jeremy Jones  <jeremyj@apple.com>
3540
3541         Add API test for layout constraints after exit fullscreen
3542         https://bugs.webkit.org/show_bug.cgi?id=159900
3543
3544         Reviewed by Jon Lee.
3545
3546         Added Fullscreen.LaytoutConstraints API test. 
3547         Tests fix from https://bugs.webkit.org/show_bug.cgi?id=159731
3548
3549         This test compares layout constraints on the web view before and after fullscreen to make sure 
3550         they are preserved.
3551
3552         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.html: Added.
3553         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.mm: Added.
3554         (-[FullscreenStateChangeMessageHandler userContentController:didReceiveScriptMessage:]):
3555         (TestWebKitAPI::TEST):
3556
3557 2016-07-20  Ryan Haddad  <ryanhaddad@apple.com>
3558
3559         Disable two failing API tests.
3560
3561         Unreviewed test gardening.
3562
3563         * TestWebKitAPI/Tests/mac/CandidateTests.mm:
3564         (TestWebKitAPI::TEST):
3565
3566 2016-07-20  Wenson Hsieh  <wenson_hsieh@apple.com>
3567
3568         Unreviewed iOS build fix.
3569
3570         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm: Only import Carbon.h on Mac.
3571
3572 2016-07-20  Wenson Hsieh  <wenson_hsieh@apple.com>
3573
3574         Media controls don't appear when pausing a small autoplaying video
3575         https://bugs.webkit.org/show_bug.cgi?id=159972
3576         <rdar://problem/27180657>
3577
3578         Reviewed by Beth Dakin.
3579
3580         Adds a new test that verifies media controls show up when pausing a small autoplayed video. Also adds mechanisms
3581         for simulating basic user interaction in VideoControlsManager.
3582
3583         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3584         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
3585         (-[WKWebView mouseDownAtPoint:]):
3586         (-[DidPlayMessageHandler userContentController:didReceiveScriptMessage:]):
3587         (-[OnLoadMessageHandler initWithWKWebView:handler:]):
3588         (-[OnLoadMessageHandler userContentController:didReceiveScriptMessage:]):
3589         (TestWebKitAPI::TEST):
3590         * TestWebKitAPI/Tests/WebKit2Cocoa/autoplaying-video-with-audio.html: Added.
3591
3592 2016-07-20  Per Arne Vollan  <pvollan@apple.com>
3593
3594         [Win] MathML fonts are not found.
3595         https://bugs.webkit.org/show_bug.cgi?id=159920
3596
3597         Reviewed by Alex Christensen.
3598
3599         When looking up a font in the registry, use the /v option of the Windows 'reg query' command to query
3600         for a specific registry key value.
3601
3602         * Scripts/webkitdirs.pm:
3603         (fontExists):
3604
3605 2016-07-20  Joseph Pecoraro  <pecoraro@apple.com>
3606
3607         Improve prepare-ChangeLog for @media blocks
3608         https://bugs.webkit.org/show_bug.cgi?id=159907
3609
3610         Reviewed by Timothy Hatcher.
3611
3612         * Scripts/prepare-ChangeLog:
3613         (get_selector_line_ranges_for_css):
3614         Get a range for @media blocks just like a selector.
3615             Start Line = line with '{'
3616             End line = line with '}'
3617             Name = "@media ..."
3618
3619         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning-expected.txt:
3620         Improved error messages for unbalanced portions.
3621
3622         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests-expected.txt:
3623         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests.css:
3624         (.media-query::before):
3625         (@media only screen and (max-width: 980px)):
3626         (.media-query a):
3627         (@media (-webkit-min-device-pixel-ratio: 2)):
3628         (.both a):
3629         (.both b):
3630         (.media-query b):
3631         (.media-query::after):
3632
3633 2016-07-20  Csaba Osztrogonác  <ossy@webkit.org>
3634
3635         Fix expectedFailErrorHandler in run-jsc-stress-tests
3636         https://bugs.webkit.org/show_bug.cgi?id=159811
3637
3638         Reviewed by Yusuke Suzuki.