[cmake] Add testair to the build system
[WebKit-https.git] / Tools / ChangeLog
1 2016-01-18  Csaba Osztrogonác  <ossy@webkit.org>
2
3         [cmake] Add testair to the build system
4         https://bugs.webkit.org/show_bug.cgi?id=153126
5
6         Reviewed by Michael Catanzaro.
7
8         * Scripts/build-jsc:
9
10 2016-01-16  Myles C. Maxfield  <mmaxfield@apple.com>
11
12         Remove TextRun::allowsRoundingHacks()
13         https://bugs.webkit.org/show_bug.cgi?id=153185
14
15         Reviewed by Simon Fraser.
16
17         * DumpRenderTree/mac/DumpRenderTree.mm:
18         (resetWebViewToConsistentStateBeforeTesting): Deleted.
19
20 2016-01-15  Konstantin Tokarev  <annulen@yandex.ru>
21
22         [webkitdirs] Avoid list form of open because it broke WinCairo
23         https://bugs.webkit.org/show_bug.cgi?id=153106
24
25         Reviewed by Alex Christensen.
26
27         * Scripts/webkitdirs.pm:
28         (determineArchitecture):
29
30 2016-01-15  Simon Fraser  <simon.fraser@apple.com>
31
32         Add kdebug_trace signposts for a few WebCore operations
33         https://bugs.webkit.org/show_bug.cgi?id=153136
34         rdar://problem/24208487
35
36         Reviewed by Sam Weinig.
37         
38         Plist used by kdebug_trace() viewing tools.
39
40         * Tracing/SystemTracePoints.plist: Added.
41
42 2016-01-14  Konstantin Tokarev  <annulen@yandex.ru>
43
44         [webkitdirs] Replaced grep invocation with perl code
45         https://bugs.webkit.org/show_bug.cgi?id=153106
46
47         Reviewed by Alex Christensen.
48
49         * Scripts/webkitdirs.pm:
50         (determineArchitecture):
51
52 2016-01-14  Brian Burg  <bburg@apple.com>
53
54         prepare-changelog does not read paths containing spaces properly
55         https://bugs.webkit.org/show_bug.cgi?id=137982
56
57         Reviewed by Joseph Pecoraro.
58
59         Escape whitespace in filenames before passing the file path to other functions.
60
61         * Scripts/prepare-ChangeLog:
62         (generateFunctionLists): Use the more explicit 3-argument form of 'open'.
63
64 2016-01-14  Jason Marcell  <jmarcell@apple.com>
65
66         Standardize the usage of "branch" vs. "branchName".
67         https://bugs.webkit.org/show_bug.cgi?id=152982
68
69         Reviewed by Daniel Bates.
70
71         In an earlier patch we started using the name "branch" to indicate a branch object, whereas
72         "branchName" implies that the variable or property in question is simply a string.
73
74         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
75         (BuildbotQueueView.prototype._popoverLinesForCommitRange): Change branch to branchName.
76         (BuildbotQueueView.prototype._presentPopoverForRevisionRange): Change branch to branch.name.
77         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Change branch to branchName.
78         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
79         (Trac.prototype.commitsOnBranch): Change branch to branchName.
80         (Trac.prototype._convertCommitInfoElementToObject): Ditto.
81         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
82         (MockTrac): Ditto.
83
84 2016-01-14  Jason Marcell  <jmarcell@apple.com>
85
86         Add a unit test to test BuildbotQueueView._appendPendingRevisionCount.
87         https://bugs.webkit.org/show_bug.cgi?id=152910
88
89         Reviewed by Daniel Bates.
90
91         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueue.js: Added.
92         (MockBuildbotQueue): Added. Mock BuildbotQueue object that doesn't need to talk to an actual Buildbot server.
93         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueueView.js: Added.
94         (MockBuildbotQueueView): Added. Mock BuildbotQueueView object that returns a pre-specified _latestProductiveIteration without
95         the need to talk to a real Buildbot server.
96         (MockBuildbotQueueView.prototype._latestProductiveIteration): Added. Returns a pre-specified _latestProductiveIteration
97         without the need to talk to a real Buildbot server.
98         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js: Added.
99         (MockTrac): Added. Mock Trac constructor that has pre-populated "recordedCommits" and does not need to talk to a real Trac
100         server.
101         (MockTrac.prototype.get oldestRecordedRevisionNumber): Added. Returns a pre-specified revision.
102         (MockTrac.prototype.get latestRecordedRevisionNumber): Ditto.
103         (MockTrac.prototype.loadMoreHistoricalData): Added. Overrides the real loadMoreHistoricalData so that we don't waste time
104         trying to talk to Trac.
105         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index.html: Added. Web page container for
106         QUnit unit tests.
107         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added. QUnit unit tests.
108
109 2016-01-14  Nikos Andronikos  <nikos.andronikos-webkit@cisra.canon.com.au>
110
111         [CMake][GTK] CMake Error: Could not create named generator Eclipse CDT4 - Ninja
112         https://bugs.webkit.org/show_bug.cgi?id=132599
113
114         Reviewed by Michael Catanzaro.
115
116         Check if cmake Ninja generators are installed.
117
118         * Scripts/webkitdirs.pm:
119         (canUseNinjaGenerator):
120         (canUseEclipseNinjaGenerator):
121         (generateBuildSystemFromCMakeProject):
122         (canUseEclipse): Deleted.
123
124 2016-01-13  Myles C. Maxfield  <mmaxfield@apple.com>
125
126         [Cocoa] Testing with font family name "System Font" is unused
127         https://bugs.webkit.org/show_bug.cgi?id=153073
128         <rdar://problem/24091683>
129
130         Reviewed by Brent Fulgham.
131
132         * DumpRenderTree/mac/DumpRenderTree.mm:
133         (allowedFontFamilySet): Deleted.
134         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
135         (WTR::allowedFontFamilySet): Deleted.
136         * WebKitTestRunner/mac/TestControllerMac.mm:
137         (WTR::allowedFontFamilySet): Deleted.
138
139 2016-01-13  Daniel Bates  <dabates@apple.com>
140
141         [XSS Auditor] Add test when XSS payload is in the path portion of the URL
142         https://bugs.webkit.org/show_bug.cgi?id=152871
143
144         Reviewed by Brent Fulgham.
145
146         Merged from Blink (patch by Tom Sepez <tsepez@chromium.org>):
147         <https://src.chromium.org/viewvc/blink?revision=164746&view=revision>
148
149         * Scripts/webkitpy/layout_tests/servers/lighttpd.conf:
150
151 2016-01-08  Andy Estes  <aestes@apple.com>
152
153         [Content Filtering] Lazily load platform frameworks
154         https://bugs.webkit.org/show_bug.cgi?id=152881
155         rdar://problem/23270886
156
157         Reviewed by Brady Eidson.
158
159         Added an API test that verifies that the Parental Controls and Network Extension frameworks are loaded at the
160         expected times. The test verifies that they are not loaded after creating a WKWebView, loading an HTML string,
161         loading NSData, loading a file, or loading from a custom protocol. It verifies that Network Extension on Mac/iOS
162         and Parental Controls on iOS are loaded after an HTTP request. It finally verifies that Parental Controls on Mac
163         is loaded after an HTTPS request.
164
165         To accomplish this, TestProtocol was generalized to allow tests to specify the scheme they wish to use.
166         Other tests that used TestProtocol were updated to account for this change. TestProtocol was removed from
167         WebKit2.PreventImageLoadWithAutoResizingTest, which didn't actually need to use it. ContentFiltering tests were
168         also re-enabled on iOS after mistakenly being disabled by r188892.
169
170         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
171         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
172         (TestWebKitAPI::TEST):
173         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.h: Added.
174         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.html: Added.
175         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
176         (TEST):
177         (downloadTest):
178         (-[LazilyLoadPlatformFrameworksController init]):
179         (-[LazilyLoadPlatformFrameworksController webView]):
180         (-[LazilyLoadPlatformFrameworksController expectParentalControlsLoaded:networkExtensionLoaded:]):
181         (-[LazilyLoadPlatformFrameworksController webView:didFinishNavigation:]):
182         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
183         (-[ContentFilteringPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
184         (-[ContentFilteringPlugIn observeValueForKeyPath:ofObject:change:context:]):
185         (-[ContentFilteringPlugIn checkIfPlatformFrameworksAreLoaded:]):
186         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
187         (TestWebKitAPI::TEST):
188         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
189         (TestWebKitAPI::TEST): Deleted.
190         * TestWebKitAPI/cocoa/TestProtocol.h:
191         * TestWebKitAPI/cocoa/TestProtocol.mm:
192         (+[TestProtocol registerWithScheme:]):
193         (+[TestProtocol unregister]):
194
195 2016-01-12  Dewei Zhu  <dewei_zhu@apple.com>
196
197         Fix the Sunpider converage in slow device.
198         https://bugs.webkit.org/show_bug.cgi?id=152938
199         <rdar://problem/22511411>
200
201         Reviewed by Ryosuke Niwa.
202
203         Updated the patch for RunBenchmark to resume sunspider coverage by removing unused subresources in sub-tests.
204
205         * Scripts/webkitpy/benchmark_runner/data/patches/SunSpider.patch:
206
207 2016-01-12  Ryosuke Niwa  <rniwa@webkit.org>
208
209         Add a build flag for custom element
210         https://bugs.webkit.org/show_bug.cgi?id=153005
211
212         Reviewed by Alex Christensen.
213
214         Added --custom-elements option to enable custom elements support.
215
216         * Scripts/webkitperl/FeatureList.pm:
217
218 2016-01-12  Benjamin Poulain  <bpoulain@apple.com>
219
220         [JSC] Add a help message when run-jsc-stress-tests fails
221         https://bugs.webkit.org/show_bug.cgi?id=153014
222
223         Reviewed by Csaba Osztrogonác.
224
225         * Scripts/run-jsc-stress-tests:
226
227 2016-01-11  Saam barati  <sbarati@apple.com>
228
229         run-jsc-stress-tests should try to figure out a JSC path
230         https://bugs.webkit.org/show_bug.cgi?id=152971
231
232         Reviewed by Yusuke Suzuki.
233
234         This patch now allows run-jsc-stress-tests to be run
235         without a "--jsc <jsc-path>" argument. It tries
236         to take its best guess at a <jsc-path> automagically.
237         
238         This makes it much easier to just run run-jsc-stress-tests
239         with a directory or a yaml file as an argument.
240         You now just do this:
241         `run-jsc-stress-tests <path-to-yaml>`
242         or
243         `run-jsc-stress-tests <path-to-directory-of-js-files>`
244         
245         I wrote this patch because I'd often find myself hacking the 
246         run-javascriptcore-tests file just to run a particular subset of tests.
247         Because I always forget the arguments to run-jsc-stress-tests (which means
248         I always forgot to provide a --jsc argument), I always found it easier to 
249         just hack on that file instead of calling run-jsc-stress-tests directly.
250         No longer is this true!
251
252         * Scripts/run-jsc-stress-tests:
253
254 2016-01-09  Andy Estes  <aestes@apple.com>
255
256         [Cocoa] Add SPI to opt out a URL scheme from the memory cache
257         https://bugs.webkit.org/show_bug.cgi?id=152950
258         rdar://problem/24066652
259
260         Reviewed by Tim Horton.
261
262         Added an API test.
263
264         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
265         * TestWebKitAPI/Tests/WebKit2Cocoa/AlwaysRevalidatedURLSchemes.mm: Added.
266         (+[AlwaysRevalidatedURLSchemeProtocol canInitWithRequest:]):
267         (+[AlwaysRevalidatedURLSchemeProtocol canonicalRequestForRequest:]):
268         (+[AlwaysRevalidatedURLSchemeProtocol requestIsCacheEquivalent:toRequest:]):
269         (-[AlwaysRevalidatedURLSchemeProtocol startLoading]):
270         (-[AlwaysRevalidatedURLSchemeProtocol stopLoading]):
271         (-[AlwaysRevalidatedURLSchemesDelegate webView:didFinishNavigation:]):
272         (TEST):
273
274 2016-01-11  Commit Queue  <commit-queue@webkit.org>
275
276         Unreviewed, rolling out r194866.
277         https://bugs.webkit.org/show_bug.cgi?id=152986
278
279         This change broke the mac build (Requested by ryanhaddad on
280         #webkit).
281
282         Reverted changeset:
283
284         "[Cocoa] Add SPI to opt out a URL scheme from the memory
285         cache"
286         https://bugs.webkit.org/show_bug.cgi?id=152950
287         http://trac.webkit.org/changeset/194866
288
289 2016-01-11  Andy Estes  <aestes@apple.com>
290
291         [Cocoa] Add SPI to opt out a URL scheme from the memory cache
292         https://bugs.webkit.org/show_bug.cgi?id=152950
293         rdar://problem/24066652
294
295         Reviewed by Tim Horton.
296
297         Added an API test.
298
299         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
300         * TestWebKitAPI/Tests/WebKit2Cocoa/AlwaysRevalidatedURLSchemes.mm: Added.
301         (+[AlwaysRevalidatedURLSchemeProtocol canInitWithRequest:]):
302         (+[AlwaysRevalidatedURLSchemeProtocol canonicalRequestForRequest:]):
303         (+[AlwaysRevalidatedURLSchemeProtocol requestIsCacheEquivalent:toRequest:]):
304         (-[AlwaysRevalidatedURLSchemeProtocol startLoading]):
305         (-[AlwaysRevalidatedURLSchemeProtocol stopLoading]):
306         (-[AlwaysRevalidatedURLSchemesDelegate webView:didFinishNavigation:]):
307         (TEST):
308
309 2016-01-11  Konstantin Tokarev  <annulen@yandex.ru>
310
311         [webkitdirs] Use CMake to determine architecture on isCMakeBuild()
312         https://bugs.webkit.org/show_bug.cgi?id=152959
313
314         Reviewed by Brent Fulgham.
315
316         * Scripts/webkitdirs.pm:
317         (determineArchitecture):
318
319 2016-01-11  Michael Catanzaro  <mcatanzaro@igalia.com>
320
321         [GTK] W3C CSS2.1 anonymous table tests are failing
322         https://bugs.webkit.org/show_bug.cgi?id=152455
323
324         Reviewed by Mario Sanchez Prada.
325
326         Add shared-mime-info to the jhbuild environment, since it affects the results of layout
327         tests. Add upstream patches to fix detection of XHTML files.
328
329         * gtk/jhbuild.modules:
330         * gtk/patches/shared-mime-info-xht-glob.patch: Added.
331         * gtk/patches/shared-mime-info-xhtml-magic.patch: Added.
332
333 2016-01-10  Saam barati  <sbarati@apple.com>
334
335         Implement a sampling profiler
336         https://bugs.webkit.org/show_bug.cgi?id=151713
337
338         Reviewed by Filip Pizlo.
339
340         * Scripts/run-jsc-stress-tests:
341
342 2016-01-10  Konstantin Tokarev  <annulen@yandex.ru>
343
344         [webkitdirs] Try arch and uname commands on non-windows OS
345         https://bugs.webkit.org/show_bug.cgi?id=152958
346
347         Reviewed by Michael Catanzaro.
348
349         Right now, determineArchitecture()  uses `arch` and `uname -m`
350         commands to determine architecture in case of condition (isGtk() ||
351         isAppleMacWebKit() || isEfl()) is true. This should be !anyWindows()
352         instead, because this code is applicable to any non-windows OS WebKit
353         supports (even Haiku which once was supported is moderately
354         POSIX-compliant and has uname command).
355
356         * Scripts/webkitdirs.pm:
357         (determineArchitecture):
358
359 2016-01-08  Aakash Jain  <aakash_jain@apple.com>
360
361         run-webkit-tests mis-counts totals when there are other crashes
362         https://bugs.webkit.org/show_bug.cgi?id=152894
363         <rdar://problem/24098697>
364
365         Reviewed by Alexey Proskuryakov.
366
367         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
368         (TestRunResults.add): Do not update result counters for other crashes.
369
370 2016-01-08  Youenn Fablet  <youenn.fablet@crf.canon.fr>
371
372         webkit-patch build-and-test should have an option to iterate over new tests
373         https://bugs.webkit.org/show_bug.cgi?id=143093
374
375         Reviewed by Michael Catanzaro.
376
377         This patch introduces the --iterate-on-new-tests option to webkit-patch build-and-test.
378         It allows running run-webkit-tests on modified or new paths in LayoutTests.
379         Computation of new or modified tests is done by LayoutTestFinder.find_touched_tests
380         It implements the translation of -expected.* paths to their related tests.
381         It also implements the removal of skipped tests.
382
383         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
384         (LayoutTestFinder.find_touched_tests):
385         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py: Added.
386         (MockPort):
387         (MockPort.__init__):
388         (MockPort.tests):
389         (LayoutTestFinderTests):
390         (LayoutTestFinderTests.touched_files):
391         (LayoutTestFinderTests.test_touched_test):
392         (LayoutTestFinderTests.test_expected_touched_test):
393         (LayoutTestFinderTests.test_platform_expected_touched_test):
394         (LayoutTestFinderTests.test_platform_duplicate_touched_test):
395         (LayoutTestFinderTests.test_touched_but_skipped_test):
396         * Scripts/webkitpy/port/base.py:
397         (Port.potential_test_names_from_expected_file):
398         * Scripts/webkitpy/tool/commands/download_unittest.py:
399         (DownloadCommandsTest._default_options):
400         * Scripts/webkitpy/tool/steps/options.py:
401         (Options):
402         * Scripts/webkitpy/tool/steps/runtests.py:
403         (RunTests.options):
404         (RunTests.run):
405         (RunTests):
406         (RunTests._new_or_modified_tests):
407         (RunTests._run_webkit_tests):
408         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
409         (RunTestsTest.test_webkit_run_unit_tests):
410         * Scripts/webkitpy/tool/steps/steps_unittest.py:
411         (StepsTest._step_options):
412
413 2016-01-07  Joseph Pecoraro  <pecoraro@apple.com>
414
415         prepare-ChangeLog should include radar number
416         https://bugs.webkit.org/show_bug.cgi?id=152839
417         <rdar://problem/24093563>
418
419         Reviewed by Daniel Bates.
420
421         When running `prepare-ChangeLog -b ###`, check for a bugzilla comment that
422         starts with a "<rdar://problem/####>" URL. If found, include that radar URL
423         in the ChangeLog description after the bug URL.
424
425         * Scripts/prepare-ChangeLog:
426         (main): Update signatures.
427         (fetchBugXMLData): XML Data is now used for multiple reasons. Extract this to just get the data.
428         (fetchBugDescriptionFromBugXMLData): Search data for <short_desc>.
429         (fetchRadarURLFromBugXMLData): Search comment text for radar URL.
430         (generateNewChangeLogs): Include radar URL if we found one.
431
432         * Scripts/webkitperl/prepare-ChangeLog_unittest/fetchRadarURLFromBugXMLData.pl: Added.
433         Tests for the radar URL extraction.
434
435 2016-01-07  Alexey Proskuryakov  <ap@apple.com>
436
437         testRunner.runUIScript crashes while running multiple tests in a row that invokes the same UIScript
438         https://bugs.webkit.org/show_bug.cgi?id=152390
439         <rdar://problem/23948321>
440
441         Reviewed by Simon Fraser.
442
443         Fix two use-after-frees.
444
445         1. WKPageCallAfterNextPresentationUpdate's callback has a pointer to TestInvocation,
446         but we may have already progressed to another test by the time the callback fires,
447         having destroyed the TestInvocation.
448         2. UIScriptController is a RefCounted object, but it has a raw pointer to
449         UIScriptContext which has the same lifetime as a TestInvocation.
450         As a result, completion blocks of UIScriptController actions would use a destroyed
451         TestInvocation.
452
453         * WebKitTestRunner/TestInvocation.cpp:
454         (WTR::TestInvocation::~TestInvocation):
455         (WTR::TestInvocation::url):
456         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
457         (WTR::TestInvocation::runUISideScriptAfterUpdateCallback):
458         (WTR::TestInvocation::runUISideScript):
459         * WebKitTestRunner/TestInvocation.h:
460         * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
461         (UIScriptContext::UIScriptContext):
462         (UIScriptContext::~UIScriptContext):
463         (UIScriptContext::runUIScript):
464         * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
465         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
466         (WTR::UIScriptController::UIScriptController):
467         (WTR::UIScriptController::contextDestroyed):
468         (WTR::UIScriptController::makeWindowObject):
469         (WTR::UIScriptController::setWillBeginZoomingCallback):
470         (WTR::UIScriptController::willBeginZoomingCallback):
471         (WTR::UIScriptController::setDidEndZoomingCallback):
472         (WTR::UIScriptController::didEndZoomingCallback):
473         (WTR::UIScriptController::setDidEndScrollingCallback):
474         (WTR::UIScriptController::didEndScrollingCallback):
475         (WTR::UIScriptController::setDidShowKeyboardCallback):
476         (WTR::UIScriptController::didShowKeyboardCallback):
477         (WTR::UIScriptController::setDidHideKeyboardCallback):
478         (WTR::UIScriptController::didHideKeyboardCallback):
479         (WTR::UIScriptController::uiScriptComplete):
480         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
481         (WTR::UIScriptController::create):
482         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
483         (WTR::UIScriptController::doAsyncTask):
484         (WTR::UIScriptController::zoomToScale):
485         (WTR::UIScriptController::singleTapAtPoint):
486         (WTR::UIScriptController::doubleTapAtPoint):
487         (WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
488         (WTR::UIScriptController::contentVisibleRect):
489         (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
490         (WTR::UIScriptController::platformSetDidEndZoomingCallback):
491         (WTR::UIScriptController::platformSetDidShowKeyboardCallback):
492         (WTR::UIScriptController::platformSetDidHideKeyboardCallback):
493         (WTR::UIScriptController::platformSetDidEndScrollingCallback):
494         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
495         (WTR::UIScriptController::doAsyncTask):
496
497 2016-01-07  Youenn Fablet  <youenn.fablet@crf.canon.fr>
498
499         [buildbot] clean-build script should remove untracked files and revert local changes too
500         https://bugs.webkit.org/show_bug.cgi?id=142400
501
502         Reviewed by Ryosuke Niwa.
503
504         This patch cleans the WebKit folder by reverting tracked files changes and deleting SCM untracked files, including SCM ignored files.
505         A helper routine SCM.discard_untracked_files is added for that purpose.
506
507         * BuildSlaveSupport/clean-build:
508         (main): Making call to Scripts/clean-webkit
509         * Scripts/clean-webkit: Added.
510         (main): Revert changes and delete untracked files.
511         * Scripts/webkitpy/common/checkout/scm/scm.py:
512         (SCM.discard_untracked_files): Helper function to discard untracked files or folders found by SCM.
513         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
514         (SCMTest._shared_test_discard_untracked_files):
515         (test_discard_untracked_files): Tests that untracked file and untracked folder get discarded correctly.
516
517 2016-01-06  Simon Fraser  <simon.fraser@apple.com>
518
519         Add a setting and preferences to enable display-list drawing. Does nothing yet.
520         https://bugs.webkit.org/show_bug.cgi?id=152807
521
522         Reviewed by Zalan Bujtas.
523         
524         Add an item to the Settings menu to toggle display-list drawing.
525
526         * MiniBrowser/mac/SettingsController.h:
527         * MiniBrowser/mac/SettingsController.m:
528         (-[SettingsController _populateMenu]):
529         (-[SettingsController validateMenuItem:]):
530         (-[SettingsController toggleDisplayListDrawingEnabled:]):
531         (-[SettingsController displayListDrawingEnabled]):
532         * MiniBrowser/mac/WK2BrowserWindowController.m:
533         (-[WK2BrowserWindowController didChangeSettings]):
534
535 2016-01-06  Youenn Fablet  <youenn.fablet@crf.canon.fr>
536
537         Python SCM should be able to retrieve untracked files - Add GIT support
538         https://bugs.webkit.org/show_bug.cgi?id=143135
539
540         Reviewed by Michael Catanzaro.
541
542         * Scripts/webkitpy/common/checkout/scm/git.py:
543         (Git.untracked_files): Adding support for git.
544         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
545         (GitTest.setUp):
546         (GitTest.test_untracked_files): Adding test.
547
548 2016-01-05  Mark Lam  <mark.lam@apple.com>
549
550         Rename badly named JSC_timeout env var to JSCTEST_timeout.
551         https://bugs.webkit.org/show_bug.cgi?id=152748
552
553         Reviewed by Geoffrey Garen.
554
555         Now that we validate JSC options, the badly named JSC_timeout env var causes the
556         bots to have a bad time.
557
558         * Scripts/run-javascriptcore-tests:
559         * Scripts/run-jsc-stress-tests:
560
561 2016-01-04  Carlos Garcia Campos  <cgarcia@igalia.com>
562
563         [GTK] Allow to save and restore session
564         https://bugs.webkit.org/show_bug.cgi?id=115600
565
566         Reviewed by Michael Catanzaro.
567
568         Add test case to check the new session API.
569
570         * TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp:
571         (testWebKitWebViewSessionState):
572         (testWebKitWebViewSessionStateWithFormData):
573         (beforeAll):
574
575 2016-01-04  Csaba Osztrogonác  <ossy@webkit.org>
576
577         [EFL] Bump EFL version to 1.16.1
578         https://bugs.webkit.org/show_bug.cgi?id=152688
579
580         Reviewed by Gyuyoung Kim.
581
582         * efl/jhbuild.modules:
583
584 2016-01-04  Aakash Jain  <aakash_jain@apple.com>
585
586         error running layout tests on iOS simulator on latest build
587         https://bugs.webkit.org/show_bug.cgi?id=152719
588         <rdar://problem/24009549>
589
590         Reviewed by Alexey Proskuryakov.
591
592         * Scripts/webkitpy/xcode/simulator.py:
593         (Simulator.wait_until_device_is_booted): Ensure that simulator device is in booted state
594           before running simctl spawn command.
595
596 2016-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
597
598         Unreviewed, move Frédéric Wang to committers list
599
600         He seems to be on the contributors list by accident. He has been landing his own commits for
601         about two years now.
602
603         * Scripts/webkitpy/common/config/contributors.json:
604
605 2016-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
606
607         Unreviewed, move Sebastian Dröge to committers list harder
608
609         He accidentally added himself to the reviewers list because the file is confusing. Then I
610         accidentially moved him to the contributors list because the file is confusing, even though
611         I knew the contributors list existed in this file and was attempting to add him to the
612         committers list. Really move him to the committers list now.
613
614         * Scripts/webkitpy/common/config/contributors.json:
615
616 2016-01-02  Youenn Fablet  <youenn.fablet@crf.canon.fr>
617
618         Python SCM should be able to retrieve untracked files - Add SVN support
619         https://bugs.webkit.org/show_bug.cgi?id=152546
620
621         Reviewed by Michael Catanzaro.
622
623         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
624         (test_untracked_files): Activating test for SVN.
625         * Scripts/webkitpy/common/checkout/scm/svn.py:
626         (SVN.untracked_files): Implementing untracked files retrieval for SVN.
627
628 2015-12-31  Andy Estes  <aestes@apple.com>
629
630         Replace WTF::move with WTFMove
631         https://bugs.webkit.org/show_bug.cgi?id=152601
632
633         Reviewed by Brady Eidson.
634
635         * DumpRenderTree/TestRunner.h:
636         (TestRunner::setAllowedHosts):
637         * DumpRenderTree/win/DRTDataObject.cpp:
638         (DRTDataObject::SetData):
639         * TestWebKitAPI/Tests/WTF/Deque.cpp:
640         (TestWebKitAPI::TEST):
641         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
642         (TestWebKitAPI::TEST):
643         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
644         (TestWebKitAPI::TEST):
645         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
646         (TestWebKitAPI::TEST):
647         * TestWebKitAPI/Tests/WTF/Ref.cpp:
648         (TestWebKitAPI::passWithRef):
649         (TestWebKitAPI::TEST):
650         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
651         (TestWebKitAPI::TEST):
652         * TestWebKitAPI/Tests/WTF/Vector.cpp:
653         (TestWebKitAPI::TEST):
654         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
655         (TestWebKitAPI::TEST):
656         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
657         (TestWebKitAPI::TEST):
658         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
659         (TestWebKitAPI::createTestValue):
660         (TestWebKitAPI::TEST):
661         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
662         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
663         (TestWebKitAPI::InMemoryCompiledContentExtension::create):
664         (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
665         (TestWebKitAPI::createNFAs):
666         (TestWebKitAPI::TEST_F):
667         * TestWebKitAPI/Tests/WebCore/DFACombiner.cpp:
668         (TestWebKitAPI::combine):
669         * TestWebKitAPI/Tests/WebCore/DFAHelpers.h:
670         (TestWebKitAPI::createNFAs):
671         * TestWebKitAPI/Tests/WebKit2/cocoa/WeakObjCPtr.mm:
672         (TEST):
673         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
674         (WebProcessTest::add):
675
676 2016-01-01  Michael Catanzaro  <mcatanzaro@igalia.com>
677
678         [SOUP] REGRESSION(r192761): Broke resource URIs for applications that use g_resource_load in a web extension
679         https://bugs.webkit.org/show_bug.cgi?id=152634
680
681         Reviewed by Carlos Garcia Campos.
682
683         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
684         (testLoadFromGResource): Added test.
685         (beforeAll):
686         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
687         (registerGResource): Added.
688         (webkit_web_extension_initialize_with_user_data): Load the test gresource.
689         * TestWebKitAPI/Tests/WebKit2Gtk/resources/boring.html: Added.
690         * TestWebKitAPI/Tests/WebKit2Gtk/resources/webkit2gtk-tests.gresource.xml: Add an HTML file.
691
692 2015-12-31  David Kilzer  <ddkilzer@apple.com>
693
694         REGRESSION (r194470): Fix warnings uncovered by migrating to WTF_MOVE
695         <https://bugs.webkit.org/show_bug.cgi?id=152601>
696
697         Ignore unknown pragmas on older clangs.  Fixes the following
698         build failure:
699
700             Tools/TestWebKitAPI/Tests/WTF/NakedPtr.cpp:184:34: error: unknown warning group '-Wself-move', ignored [-Werror,-Wunknown-pragmas]
701             #pragma clang diagnostic ignored "-Wself-move"
702                                              ^
703             1 error generated.
704
705         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
706         (TestWebKitAPI::TEST):
707         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
708         (TestWebKitAPI::TEST):
709
710 2015-12-31  Andy Estes  <aestes@apple.com>
711
712         Update the style checker to advise using WTFMove() instead of WTF::move()
713         https://bugs.webkit.org/show_bug.cgi?id=152601
714
715         Reviewed by Daniel Bates.
716
717         * Scripts/webkitpy/style/checkers/cpp.py:
718         (check_wtf_move):
719         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
720         (WebKitStyleTest.test_wtf_move):
721
722 2015-12-31  Andy Estes  <aestes@apple.com>
723
724         Fix warnings uncovered by migrating to WTF_MOVE
725         https://bugs.webkit.org/show_bug.cgi?id=152601
726
727         Reviewed by Daniel Bates.
728
729         Ignored -Wself-move warnings in these two API tests. It's useful to test that these classes properly handle
730         self-move, even if doing so would trigger a warning.
731
732         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
733         (TestWebKitAPI::TEST):
734         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
735         (TestWebKitAPI::TEST):
736
737 2015-12-31  Martin Robinson  <mrobinson@igalia.com>
738
739         [GTK] The install-dependencies script has a syntax error
740         https://bugs.webkit.org/show_bug.cgi?id=152613
741
742         Reviewed by Michael Catanzaro.
743
744         * gtk/install-dependencies: Add the missing 'then.'
745
746 2015-12-30  Philippe Normand  <pnormand@igalia.com>
747
748         [Mac][GTK] Jhbuild support for OSX
749         https://bugs.webkit.org/show_bug.cgi?id=150799
750
751         Reviewed by Michael Catanzaro.
752
753         * gtk/install-dependencies: Install dependencies on OSX with Homebrew.
754         * gtk/jhbuild.modules: Moved platform-specific build settings in condition tags.
755         * gtk/patches/foxbntconfig-fix-osx-cache.diff: Added.
756         * gtk/jhbuildrc: GTK+ makeargs clean-up, the 3.0.12 hack is no longer needed.
757
758 2015-12-28  Michael Catanzaro  <mcatanzaro@igalia.com>
759
760         Unreviewed, move Sebastian Dröge to committers list
761
762         He accidentally added himself to the reviewers list because the file is confusing.
763
764         * Scripts/webkitpy/common/config/contributors.json:
765
766 2015-12-24  Simon Fraser  <simon.fraser@apple.com>
767
768         Remove the unused #define _USE_MATH_DEFINES
769         https://bugs.webkit.org/show_bug.cgi?id=152034
770
771         Reviewed by Tim Horton.
772         
773         Update this test to use piDouble from MathExtras.h, and
774         std::numeric_limits<>.
775
776         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
777
778 2015-12-24  Youenn Fablet  <youenn.fablet@crf.canon.fr>
779
780         Python SCM should be able to retrieve untracked files - Generic changes
781         https://bugs.webkit.org/show_bug.cgi?id=152536
782
783         Reviewed by Brent Fulgham.
784
785         This patch introduces SCM.untracked_files to retrieve a list of untracked files.
786         No support is yet added to GIT and SVN specific implementations.
787
788         * Scripts/webkitpy/common/checkout/scm/scm.py:
789         (SCM.untracked_files):
790         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
791         (SCMTest._shared_test_untracked_files):
792
793 2015-12-23  Dewei Zhu  <dewei_zhu@apple.com>
794
795         SVN checkout used by RunBenchmark should be non-interactive
796         https://bugs.webkit.org/show_bug.cgi?id=152542
797
798         Reviewed by Ryosuke Niwa.
799
800         RunBenchmark should not require user interaction while running.
801
802         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
803         (BenchmarkBuilder._checkout_with_subversion):
804
805 2015-12-23  Brent Fulgham  <bfulgham@apple.com>
806
807         Web Inspector: add support for running protocol-test.js tests on Windows
808         https://bugs.webkit.org/show_bug.cgi?id=148037
809         <rdar://problem/22292237>
810
811         Reviewed by Simon Fraser.
812
813         * DumpRenderTree/win/TestRunnerWin.cpp:
814         (TestRunner::inspectorTestStubURL): Provide implementation.
815
816 2015-12-23  Eric Carlson  <eric.carlson@apple.com>
817
818         [MediaStream] MediaDeviceInfo.label must be empty in some situations
819         https://bugs.webkit.org/show_bug.cgi?id=152000
820
821         Reviewed by Brent Fulgham.
822
823         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
824         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
825         (WTR::InjectedBundle::setUserMediaPermission):
826         (WTR::InjectedBundle::setUserMediaPermissionForOrigin): New.
827         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
828
829         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
830         (WTR::TestRunner::setUserMediaPermissionForOrigin): New.
831         * WebKitTestRunner/InjectedBundle/TestRunner.h:
832
833         * WebKitTestRunner/TestController.cpp:
834         (WTR::TestController::setUserMediaPermissionForOrigin):
835         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin): Add NULL check.
836         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Don't add 
837           persistent permission for origin, that can be done from script now.
838         * WebKitTestRunner/TestController.h:
839
840         * WebKitTestRunner/TestInvocation.cpp:
841         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Add support for
842           SetUserMediaPermissionForOrigin.
843
844 2015-12-23  Brent Fulgham  <bfulgham@apple.com>
845
846         [Win] Unreviewed build fix: Recognize Windows 10 variants.
847
848         * Scripts/webkitpy/common/system/platforminfo.py:
849         (PlatformInfo._determine_win_version):
850
851 2015-12-23  Chris Aljoudi <chris@chrismatic.io> and Alex Christensen <achristensen@webkit.org>
852
853         Content blockers should be able to promote http to https
854         https://bugs.webkit.org/show_bug.cgi?id=148966
855
856         Reviewed by Benjamin Poulain.
857
858         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
859         (WebCore::ContentExtensions::operator<<):
860         (TestWebKitAPI::TEST_F):
861
862 2015-12-22  Hunseop Jeong  <hs85.jeong@samsung.com>
863
864         [EFL] MiniBrowser should be able to choose the offline-web-application-cache option
865         https://bugs.webkit.org/show_bug.cgi?id=152516
866
867         Reviewed by Gyuyoung Kim.
868
869         * MiniBrowser/efl/main.c:
870
871 2015-12-22  Brent Fulgham  <bfulgham@apple.com>
872
873         Unreviewed: Add John Wilander as a contributor.
874
875         * Scripts/webkitpy/common/config/contributors.json:
876
877 2015-12-22  Chris Fleizach  <cfleizach@apple.com>
878
879         [WK2] Looping in testcase: fast/dom/Window/property-access-on-cached-window-after-frame-removed.html
880         https://bugs.webkit.org/show_bug.cgi?id=152482
881
882         Reviewed by Brent Fulgham.
883
884         vertical/horizontalScrollbar returns an accessibility element. That element can also be queried
885         for the same property. On WK2, the element returned will not be valid, but is still present and
886         that can lead to looping.
887
888         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
889         (AccessibilityUIElement::horizontalScrollbar):
890         (AccessibilityUIElement::verticalScrollbar):
891         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
892         (WTR::AccessibilityUIElement::horizontalScrollbar):
893         (WTR::AccessibilityUIElement::verticalScrollbar):
894
895 2015-12-22  Xabier Rodriguez Calvar  <calvaris@igalia.com>
896
897         Unreviewed.
898
899         * Scripts/webkitpy/common/config/contributors.json: Marking myself as reviewer.
900
901 2015-12-21  Hunseop Jeong  <hs85.jeong@samsung.com>
902
903         [EFL] test_ewk2_context failed after r192808
904         https://bugs.webkit.org/show_bug.cgi?id=151846
905
906         Reviewed by Gyuyoung Kim.
907
908         Used the added ewk_context_web_process_count_limit_set api
909         instead of the deprecated ewk_context_process_model_set.
910
911         * MiniBrowser/efl/main.c:
912         (elm_main):
913
914 2015-12-21  Michael Catanzaro  <mcatanzaro@igalia.com>
915
916         Unreviewed, move myself to reviewer list.
917
918         * Scripts/webkitpy/common/config/contributors.json:
919
920 2015-12-21  Aakash Jain  <aakash_jain@apple.com>
921
922         Unreviewed, add myself to the committers list.
923
924         * Scripts/webkitpy/common/config/contributors.json:
925
926 2015-12-21  Michael Catanzaro  <mcatanzaro@igalia.com>
927
928         [GTK] jquery.min.js violates DFSG
929         https://bugs.webkit.org/show_bug.cgi?id=152428
930
931         Reviewed by Joseph Pecoraro.
932
933         Stop distributing Source/WebInspectorUI/Tools. It is not needed in tarballs. This brings us
934         into compliance with DFSG by removing a bundled, minified copy of jQuery from our tarball.
935
936         * gtk/manifest.txt.in:
937
938 2015-12-19  Dan Bernstein  <mitz@apple.com>
939
940         [Mac] WebKit contains dead source code for OS X Mavericks and earlier
941         https://bugs.webkit.org/show_bug.cgi?id=152462
942
943         Reviewed by Alexey Proskuryakov.
944
945         - Removed definitions of MACOSX_DEPLOYMENT_TARGET and WEBKIT_SYSTEM_INTERFACE_LIBRARY for
946           OS X 10.9:
947
948         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
949         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
950         * MiniBrowser/Configurations/DebugRelease.xcconfig:
951         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
952         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
953
954         - Simplified expressions involving __MAC_OS_X_VERSION_MIN_REQUIRED and removed code that was
955           never getting compiled:
956
957         * DumpRenderTree/mac/TextInputController.m:
958         * MiniBrowser/mac/BrowserWindowController.m:
959         * TestWebKitAPI/Tests/mac/AttributedString.mm:
960         * WebKitTestRunner/mac/EventSenderProxy.mm:
961
962 2015-12-18  Michael Catanzaro  <mcatanzaro@igalia.com>
963
964         Unreviewed, add WebKitGTK+ Bugzilla email to committers list
965
966         This is to make it easy to CC it on Bugzilla.
967
968         * Scripts/webkitpy/common/config/contributors.json:
969
970 2015-12-18  Aakash Jain  <aakash_jain@apple.com>
971
972         Pasteboard get messed up after running kill-old-processes
973         https://bugs.webkit.org/show_bug.cgi?id=152426
974
975         Reviewed by Alexey Proskuryakov.
976
977         * BuildSlaveSupport/kill-old-processes:
978         (main): Do not kill pasteboard anymore.
979
980 2015-12-17  Aakash Jain  <aakash_jain@apple.com>
981
982         run-webkit-tests shouldn't start multiple iOS simulators while only running one test
983         https://bugs.webkit.org/show_bug.cgi?id=152157
984         <rdar://problem/23851817>
985
986         Reviewed by Alexey Proskuryakov.
987
988         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
989         (LayoutTestRunner.get_worker_count): Calculate required number of workers.
990         * Scripts/webkitpy/layout_tests/controllers/manager.py:
991         (Manager._get_test_inputs): Common method to calculate test_inputs.
992         (Manager._update_worker_count): Calculate and update required number of workers.
993
994 2015-12-16  Aakash Jain  <aakash_jain@apple.com>
995
996         run-webkit-tests fails to delete Simulator device during cleanup
997         https://bugs.webkit.org/show_bug.cgi?id=152363
998
999         Reviewed by Alexey Proskuryakov.
1000
1001         * Scripts/webkitpy/xcode/simulator.py:
1002         (Simulator.delete_device): Ensure that device is Shutdown before deleting it.
1003
1004 2015-12-16  Tim Horton  <timothy_horton@apple.com>
1005
1006         [mac-wk2] fast/events force click tests crashing
1007         https://bugs.webkit.org/show_bug.cgi?id=152339
1008
1009         Reviewed by Beth Dakin.
1010
1011         * WebKitTestRunner/mac/EventSenderProxy.mm:
1012         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
1013         Set the NSEvent's _type member in addition to overriding -type,
1014         because there are assertions in touch event handling code that depend on it.
1015
1016 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1017
1018         Enforce temporarily bots to sync WebKit and WPT testharness.js
1019         https://bugs.webkit.org/show_bug.cgi?id=152334
1020
1021         Reviewed by Darin Adler.
1022
1023         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1024         (WebPlatformTestServer._copy_webkit_test_files): Temporarily overwrite wpt testharness.js with WebKit testharness.js.
1025
1026 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1027
1028         [Fetch API] Add fetch API compile time flag
1029         https://bugs.webkit.org/show_bug.cgi?id=152254
1030
1031         Reviewed by Darin Adler.
1032
1033         * Scripts/webkitperl/FeatureList.pm:
1034
1035 2015-12-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1036
1037         Unreviewed.
1038
1039         Added files that have impact in building Streams API to the watchlist.
1040
1041         * Scripts/webkitpy/common/config/watchlist:
1042
1043 2015-12-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1044
1045         Unreviewed.
1046
1047         Added imported tests to Streams API watchlist.
1048
1049         * Scripts/webkitpy/common/config/watchlist:
1050
1051 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1052
1053         Remove default copy of wpt testharness.js when launching wpt server
1054         https://bugs.webkit.org/show_bug.cgi?id=152298
1055
1056         Reviewed by Darin Adler.
1057
1058         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1059         (WebPlatformTestServer._copy_webkit_test_files): Deleted default copy of WebKit testharness.js to WPT.
1060
1061 2015-12-15  David Kilzer  <ddkilzer@apple.com>
1062
1063         REGRESSION (r192375): DumpRenderTree.app exits immediately with no error
1064         <http://webkit.org/b/152314>
1065
1066         Reviewed by Daniel Bates.
1067
1068         The change to DumpRenderTreeMain.mm in r192375 caused the iOS
1069         code path to exit immediately when calling main().
1070         Unfortunately, DumpRenderTreeMain.mm was used for both
1071         DumpRenderTree command-line binary and DumpRenderTree.app, which
1072         meant that the app would exit immediately with no error code
1073         when run!
1074
1075         The workaround is to introduce a separate source file called
1076         DumpRenderTreeAppMain.mm, similar to what WebKitTestRunner
1077         already does.
1078
1079         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Add
1080         DumpRenderTreeAppMain.mm to the project.  Make it the only
1081         compiled source for the DumpRenderTree.app target.
1082         * DumpRenderTree/ios/DumpRenderTreeAppMain.mm: Copied from Tools/DumpRenderTree/mac/DumpRenderTreeMain.mm.
1083         (main): Call DumpRenderTreeMain() on iOS.  Assert on OS X in
1084         case someone tries mistakenly to use the app.
1085         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1086         Link to JavaScriptCore.framework on iOS for the assert.
1087         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
1088         Link to JavaScriptCore.framework on OS X for the assert.  Remove
1089         unneeded EXCLUDED_SOURCE_FILE_NAMES setting.
1090         * DumpRenderTree/mac/DumpRenderTreeMain.mm:
1091         (main): Add assert for iOS so that a crash occurs if someone
1092         tries to run the wrong command.
1093
1094 2015-12-14  Tim Horton  <timothy_horton@apple.com>
1095
1096         Frequent crash under -[WKPDFView web_setMinimumSize:]_block_invoke
1097         https://bugs.webkit.org/show_bug.cgi?id=152266
1098         <rdar://problem/22092676>
1099
1100         Reviewed by Simon Fraser.
1101
1102         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1103         * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewResizeCrash.mm: Added.
1104         Add a test that crashed before this change, and doesn't crash after.
1105
1106 2015-12-14  Chris Fleizach  <cfleizach@apple.com>
1107
1108         AX: iOS: Text field variations do not have the correct traits
1109         https://bugs.webkit.org/show_bug.cgi?id=152237
1110
1111         Reviewed by Mario Sanchez Prada.
1112
1113         Add iOS calls for determing if an object is a search field or a text area.
1114
1115         * DumpRenderTree/AccessibilityUIElement.cpp:
1116         (getIsSearchFieldCallback):
1117         (getIsTextAreaCallback):
1118         (stringForSelectionCallback):
1119         (AccessibilityUIElement::getJSClass):
1120         * DumpRenderTree/AccessibilityUIElement.h:
1121         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1122         (AccessibilityUIElement::identifier):
1123         (AccessibilityUIElement::isTextArea):
1124         (AccessibilityUIElement::isSearchField):
1125         (AccessibilityUIElement::traits):
1126         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1127         (WTR::AccessibilityUIElement::scrollPageRight):
1128         (WTR::AccessibilityUIElement::hasContainedByFieldsetTrait):
1129         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
1130         (WTR::AccessibilityUIElement::isSearchField):
1131         (WTR::AccessibilityUIElement::isTextArea):
1132         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1133         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1134         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1135         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
1136         (WTR::AccessibilityUIElement::isTextArea):
1137         (WTR::AccessibilityUIElement::isSearchField):
1138         (WTR::AccessibilityUIElement::rowCount):
1139
1140 2015-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1141
1142         [GTK] [JHBuild] package libtool-bin is now required on Debian systems.
1143         https://bugs.webkit.org/show_bug.cgi?id=152252
1144
1145         Reviewed by Sergio Villar Senin.
1146
1147         * gtk/install-dependencies: Add libtool-bin to the list of packages required
1148         for building the JHBuild on Debian systems.
1149
1150 2015-12-11  Joseph Pecoraro  <pecoraro@apple.com>
1151
1152         check-for-inappropriate-objc-class-names should check all class names, not just externally visible ones
1153         https://bugs.webkit.org/show_bug.cgi?id=152156
1154
1155         Reviewed by Dan Bernstein.
1156
1157         Our frameworks should appropriately prefix all ObjC classes,
1158         not just external symbols.
1159
1160         * Scripts/check-for-inappropriate-objc-class-names:
1161         Remove the -g switch to check all ObjC class names.
1162
1163 2015-12-10  Eric Carlson  <eric.carlson@apple.com>
1164
1165         [MediaStream] Expose media capture devices persistent permissions to WebCore
1166         https://bugs.webkit.org/show_bug.cgi?id=152087
1167
1168         Add support for the new user media permission checker page UI client method.
1169
1170         Reviewed by Chris Dumez.
1171
1172         * WebKitTestRunner/TestController.cpp:
1173         (WTR::decidePolicyForUserMediaPermissionRequest):
1174         (WTR::checkUserMediaPermissionForOrigin):
1175         (WTR::TestController::createOtherPage): Add checkUserMediaPermissionForOrigin.
1176         (WTR::TestController::createWebViewWithOptions): Ditto.
1177         (WTR::TestController::resetStateToConsistentValues): Clear m_userMediaOriginPermissions.
1178         (WTR::originUserVisibleName): New, create a string for the origin.
1179         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin): Set the WKUserMediaPermissionCheckRef
1180           according to the state of the origin permission map.
1181         (WTR::TestController::handleUserMediaPermissionRequest): Remember both the origin and the
1182           request so we can update the origin permission map in decidePolicyForUserMediaPermissionRequestIfPossible.
1183         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Update the
1184           origin permission map.
1185         * WebKitTestRunner/TestController.h:
1186
1187 2015-12-10  Alex Christensen  <achristensen@webkit.org>
1188
1189         REGRESSION (r192796) WKBundlePageResourceLoadClient should be able to setHTTPBody in willSendRequestForFrame
1190         https://bugs.webkit.org/show_bug.cgi?id=152022
1191         rdar://problem/23763584
1192
1193         Reviewed by Darin Adler.
1194
1195         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1196         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1197         (WTR::InjectedBundlePage::willSendRequestForFrame):
1198         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1199         (WTR::TestRunner::setWillSendRequestReturnsNull):
1200         (WTR::TestRunner::willSendRequestReturnsNullOnRedirect):
1201         (WTR::TestRunner::setWillSendRequestReturnsNullOnRedirect):
1202         (WTR::TestRunner::setWillSendRequestAddsHTTPBody):
1203         (WTR::TestRunner::willSendRequestHTTPBody):
1204         Added setWillSendRequestAddsHTTPBody that uses new SPI for testing.
1205
1206 2015-12-10  Aakash Jain  <aakash_jain@apple.com>
1207
1208         Remove additional simulator checks before running layout-tests
1209         https://bugs.webkit.org/show_bug.cgi?id=152146
1210
1211         Reviewed by Darin Adler.
1212
1213         * Scripts/webkitpy/port/ios.py:
1214         (IOSSimulatorPort.check_sys_deps): Removed additional simulators verifications.
1215         * Scripts/webkitpy/xcode/simulator.py:
1216         (Simulator._boot_and_shutdown_simulator_device): Deleted.
1217         (Simulator.check_simulator_device_and_erase_if_needed): Deleted.
1218
1219 2015-12-09  Aakash Jain  <aakash_jain@apple.com>
1220
1221         Run atleast one simulator even if max process limit is low
1222         https://bugs.webkit.org/show_bug.cgi?id=152081
1223         <rdar://problem/23819694>
1224
1225         Reviewed by Alexey Proskuryakov.
1226
1227 2015-12-09  Mario Sanchez Prada  <mario@endlessm.com>
1228
1229         [GTK] Crash in WebProcess when loading large content with custom URI schemes
1230         https://bugs.webkit.org/show_bug.cgi?id=144262
1231
1232         Reviewed by Carlos Garcia Campos.
1233
1234         Added new unit test to check the additional scenarios we now
1235         handle for custom URI schemes.
1236
1237         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1238         (generateHTMLContent): New helper function to generate big enough content.
1239         (testWebContextURIScheme): New unit test.
1240
1241 2015-12-09  Ryuan Choi  <ryuan.choi@navercorp.com>
1242
1243         [EFL] Fix unhandled web process message when launching MiniBrowser
1244         https://bugs.webkit.org/show_bug.cgi?id=152048
1245
1246         Reviewed by Gyuyoung Kim.
1247
1248         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
1249         (TestWebKitAPI::TEST):
1250
1251 2015-12-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1252
1253         [GTK] Add API to handle beforeunload events
1254         https://bugs.webkit.org/show_bug.cgi?id=139090
1255
1256         Reviewed by Gustavo Noronha Silva.
1257
1258         * MiniBrowser/gtk/BrowserWindow.c:
1259         (browserWindowConstructed):
1260         (browserWindowDeleteEvent):
1261         (browser_window_class_init):
1262         Handle delete-event to prevent the window from being closed when
1263         the page has beforeunload handlers. Use
1264         webkit_web_view_try_close() when the window is requested to be
1265         closed.
1266         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
1267         (testWebViewJavaScriptDialogs):
1268         Add a test case for the WEBKIT_SCRIPT_DIALOG_BEFORE_UNLOAD_CONFIRM
1269         script dialog type.
1270
1271 2015-12-09  Mario Sanchez Prada  <mario@endlessm.com>
1272
1273         Refactored initialization code in LoadTrackingTest.
1274
1275         Rubber-stamped by Carlos Garcia Campos.
1276
1277         Small refactoring to make sure that the state of a LoadTrackingTest
1278         gets properly reset before loading new web content.
1279
1280         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
1281         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
1282         (LoadTrackingTest::reset): New, refactored code from *load*() and go*()
1283         functions and reset the remaining local variables.
1284         (LoadTrackingTest::loadURI): Call reset();
1285         (LoadTrackingTest::loadHtml): Ditto.
1286         (LoadTrackingTest::loadPlainText): Ditto.
1287         (LoadTrackingTest::loadBytes): Ditto.
1288         (LoadTrackingTest::loadRequest): Ditto.
1289         (LoadTrackingTest::reload): Ditto.
1290         (LoadTrackingTest::goBack): Ditto.
1291         (LoadTrackingTest::goForward): Ditto.
1292
1293 2015-12-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1294
1295         [EFL] REGRESSION(r193616): WKPreferences test has been failed since r193616
1296         https://bugs.webkit.org/show_bug.cgi?id=151942
1297
1298         Reviewed by Darin Adler.
1299
1300         * MiniBrowser/efl/main.c:
1301         (window_create): Enable offline web application cache feature on MiniBrowser.
1302         (elm_main):
1303
1304 2015-12-08  Aakash Jain  <aakash_jain@apple.com>
1305
1306         https://bugs.webkit.org/show_bug.cgi?id=151243
1307         <rdar://problem/22955197>
1308
1309         Reviewed by Alexey Proskuryakov.
1310
1311         * LayoutTestRelay/LayoutTestRelay/main.m:
1312         (getTestingSimDevice): Use separate testing device for each worker.
1313         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1314         (Manager.run): Perform cleanup even if setup fails.
1315         * Scripts/webkitpy/port/ios.py:
1316         (IOSSimulatorPort.default_child_processes): Calculate number of simulators to use.
1317         (IOSSimulatorPort.child_processes): Gets the number of simulators from options variable.
1318         (IOSSimulatorPort.setup_test_run): Handle mulitple simulators.
1319         (IOSSimulatorPort._quit_ios_simulator): Same
1320         (IOSSimulatorPort.clean_up_test_run): Same
1321         (IOSSimulatorPort.check_sys_deps): Same
1322         (IOSSimulatorPort.testing_device): Same
1323         (IOSSimulatorPort.reset_preferences): Same
1324         (IOSSimulatorPort.get_simulator_path): Return simulator path.
1325         (IOSSimulatorPort._createSimulatorApp): Create the copy of simulator app.
1326         * Scripts/webkitpy/xcode/simulator.py:
1327         (Device.delete): Delete the simulator device.
1328         (Simulator.delete_device): Same
1329         (Simulator.wait_until_device_is_booted): Wait for device booting.
1330
1331 2015-12-08  Ryuan Choi  <ryuan.choi@navercorp.com>
1332
1333         [EFL] Add API to provide preferences before creating ewk_view
1334         https://bugs.webkit.org/show_bug.cgi?id=151587
1335
1336         Reviewed by Gyuyoung Kim.
1337
1338         * MiniBrowser/efl/main.c:
1339         (on_key_down):
1340         (quit):
1341         (window_create):
1342         Moved settings related code to configuration() not to update settings
1343         whenever ewk_view is created.
1344         (configuration):
1345         (elm_main):
1346
1347 2015-12-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1348
1349         Unreviewed. Fix GTK+ API tests after r193639.
1350
1351         The new jhbuild version needs some more variables ot be present in
1352         the builtin dict, even if they are set to None.
1353
1354         * jhbuild/jhbuildutils.py:
1355         (enter_jhbuild_environment_if_available):
1356
1357 2015-12-07  Gustavo Noronha Silva  <gns@gnome.org>
1358
1359         [GTK] Notify WebCore when notification is clicked
1360         https://bugs.webkit.org/show_bug.cgi?id=151951
1361
1362         Reviewed by Carlos Garcia Campos.
1363
1364         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1365         (testWebViewNotification): test the new API.
1366
1367 2015-12-07  Michael Catanzaro  <mcatanzaro@igalia.com>
1368
1369         'jhbuild build' should fail immediately when building any module fails
1370         https://bugs.webkit.org/show_bug.cgi?id=145697
1371
1372         Reviewed by Carlos Garcia Campos.
1373
1374         * efl/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
1375         * gtk/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
1376         Everything is placed under lib instead of lib64 now.
1377         * jhbuild/jhbuild-wrapper: Update jhbuild to the latest upstream commit, and pass
1378         --exit-on-error when running 'jhbuild build'.
1379         * jhbuild/jhbuildrc_common.py:
1380         (init): Don't override PKG_CONFIG_PATH, CMAKE_PREFIX_PATH, or CMAKE_LIBRARY_PATH. Modern
1381         jhbuild should be able to handle these for us without breaking things....
1382
1383 2015-12-07  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1384
1385         Add support to import w3c tests from a repository with a different root that the main repo dir
1386         https://bugs.webkit.org/show_bug.cgi?id=151751
1387
1388         Reviewed by Ryosuke Niwa and Youenn Fablet.
1389
1390         We should be able to import tests from repositories that are not pure test repositories and where tests are kept
1391         in a different directory than the repository root.
1392
1393         This patch introduces a new parameter tests_directory that we will use as root directory to search for
1394         tests. All paths will be flattened when copying tests to have a less complicated directory structure. This
1395         requires having the copy_path lists including tuples of origin and destination directories.
1396
1397         * Scripts/webkitpy/w3c/test_downloader.py:
1398         (TestDownloader._add_test_suite_paths): Adds the paths as a tuple of origin and destination directory.
1399         (TestDownloader.copy_tests): Uses the origin and destination tuple for the paths to copy when copying files.
1400         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1401         (TestImporterTest.test_tests_directory): Test.
1402
1403 2015-12-07  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1404
1405         Mock TestRepositories in W3C importer tests
1406         https://bugs.webkit.org/show_bug.cgi?id=151938
1407
1408         Reviewed by Youenn Fablet.
1409
1410         The test importer tests should use a fake repository instead of using the real one. The reason why this happened
1411         is because the test repository method reading the file was using the filesystem directly instead of taking the
1412         host one. This patch changes that.
1413
1414         * Scripts/webkitpy/w3c/test_downloader.py:
1415         (TestDownloader.load_test_repositories): Take a filesystem and use it. If we get no filesystem, we use the
1416         default one.
1417         (TestDownloader.__init__): When loading the repositories, pass the host filesystem.
1418         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1419         (TestImporterTest.test_harnesslinks_conversion):
1420         (TestImporterTest.test_submodules_generation): Use a fake test repository file.
1421
1422 2015-12-07  David Kilzer  <ddkilzer@apple.com>
1423
1424         TestNetscapePlugIn: Address review comment on 193607
1425         <http://webkit.org/b/151881>
1426
1427         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1428         (testSetStatus): Initializing std::unique_ptr<char[]> with
1429         nullptr is redundant.
1430
1431 2015-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1432
1433         [GTK] Add webkit_uri_request_get_http_method
1434         https://bugs.webkit.org/show_bug.cgi?id=151601
1435
1436         Reviewed by Martin Robinson.
1437
1438         Add test case to check HTTP method of WebKitURIRequest.
1439
1440         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
1441         (testURIRequestHTTPMethod):
1442         (serverCallback):
1443         (beforeAll):
1444         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1445         (sendRequestCallback):
1446
1447 2015-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1448
1449         [GTK] Add WebKitWebPage::console-message-sent signal to Web Extensions API
1450         https://bugs.webkit.org/show_bug.cgi?id=79918
1451
1452         Reviewed by Gustavo Noronha Silva.
1453
1454         Add unit tests to check the different console messages.
1455
1456         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
1457         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp: Added.
1458         (ConsoleMessageTest::ConsoleMessage::operator==):
1459         (ConsoleMessageTest::consoleMessageReceivedCallback):
1460         (ConsoleMessageTest::ConsoleMessageTest):
1461         (ConsoleMessageTest::~ConsoleMessageTest):
1462         (ConsoleMessageTest::waitUntilConsoleMessageReceived):
1463         (testWebKitConsoleMessageConsoleAPI):
1464         (testWebKitConsoleMessageJavaScriptException):
1465         (testWebKitConsoleMessageNetworkError):
1466         (testWebKitConsoleMessageSecurityError):
1467         (beforeAll):
1468         (afterAll):
1469         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1470         (consoleMessageSentCallback):
1471         (pageCreatedCallback):
1472
1473 2015-12-07  Ryuan Choi  <ryuan.choi@navercorp.com>
1474
1475         [EFL] MiniBrowser doesn't exit when called ewk_view_try_close()
1476         https://bugs.webkit.org/show_bug.cgi?id=151934
1477
1478         Reviewed by Csaba Osztrogonác.
1479
1480         * MiniBrowser/efl/main.c:
1481         (on_window_deletion): Revert the changes of r192767.
1482
1483 2015-12-07  Michael Catanzaro  <mcatanzaro@igalia.com>
1484
1485         [GTK] update-webkitgtk-libs cannot build mesa
1486         https://bugs.webkit.org/show_bug.cgi?id=151535
1487
1488         Reviewed by Martin Robinson.
1489
1490         Upgrade to newer mesa in order to build successfully against LLVM 3.7. Add missing
1491         dependency of mesa on LLVM, to ensure LLVM is built first. Build LLVM unconditionally, even
1492         on architectures where FTL is not supported, to ensure mesa is always buildable, since LLVM
1493         does not have a stable API and we cannot expect mesa to be buildable unless we control the
1494         LLVM version. Build mesa with --disable-egl since --enable-egl conflicts with
1495         --enable-xlib-glx. This fixes update-webkitgtk-libs on distros with LLVM 3.7.
1496
1497         * gtk/jhbuild.modules:
1498
1499 2015-12-07  Philippe Normand  <pnormand@igalia.com>
1500
1501         [GTK][Mac] libWebExtensionTest link error
1502         https://bugs.webkit.org/show_bug.cgi?id=150802
1503
1504         Reviewed by Carlos Garcia Campos.
1505
1506         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: add dependencies to the webextension library.
1507
1508 2015-12-06  David Kilzer  <ddkilzer@apple.com>
1509
1510         TestNetscapePlugIn: Fix leaks found by static analyzer
1511         <http://webkit.org/b/151881>
1512
1513         Reviewed by Darin Adler.
1514
1515         Fixes the following leaks found by the static analyzer:
1516             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'path'
1517                     return false;
1518                            ^~~~~
1519             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'target'
1520                     return false;
1521                            ^~~~~
1522             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'url'
1523                     return false;
1524                            ^~~~~
1525
1526         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1527         (toCString): Switch to returning std::unique_ptr<char[]>.  Add
1528         early return if allocation fails.
1529         (testPostURLFile): Switch to using std::unique_ptr<char[]>.
1530         Make sure to call fclose() on filehandle, even for an early
1531         return.
1532         (testSetStatus): Switch to using std::unique_ptr<char[]>.
1533
1534 2015-12-05  David Kilzer  <ddkilzer@apple.com>
1535
1536         prepare-ChangeLog: Fix some warning messages when using svn
1537         <http://webkit.org/b/151914>
1538
1539         Reviewed by Daniel Bates.
1540
1541         * Scripts/prepare-ChangeLog:
1542         (generateFunctionLists): Simplify logic so that we never call
1543         normalizePath() with an undefined value.
1544         (attributeCommand): Quote $subPath for the shell so that we
1545         don't try to run "svn propget" on invalid paths.
1546
1547 2015-12-04  David Kilzer  <ddkilzer@apple.com>
1548
1549         TestNetscapePlugIn: Fix remaining static analyzer warnings
1550         <http://webkit.org/b/151888>
1551
1552         Reviewed by Alexey Proskuryakov.
1553
1554         Fixes the following static analyzer warnings:
1555             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:101:9: warning: Called function pointer is null (null dereference)
1556                     CRASH();
1557                     ^~~~~~~
1558             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:46:5: note: expanded from macro 'CRASH'
1559                 ((void(*)())0)(); /* More reliable, but doesn't say BBADBEEF */ \
1560                 ^~~~~~~~~~~~~~~~
1561             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:375:12: warning: Access to field 'pluginTest' results in a dereference of a null pointer (loaded from variable 'obj')
1562                 return obj->pluginTest->NPP_SetWindow(window);
1563                        ^~~~~~~~~~~~~~~
1564             2 warnings generated.
1565
1566         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1567         (CRASH): Use __builtin_trap() for gcc/clang.
1568         (NPP_SetWindow): Add early return if obj is nullptr.
1569
1570 2015-12-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1571
1572         [GTK] Test /webkit2/WebKitWebResource/get-data is flaky
1573         https://bugs.webkit.org/show_bug.cgi?id=151797
1574
1575         Reviewed by Martin Robinson.
1576
1577         Since we switched to use the network process to run the unit tests
1578         the test /webkit2/WebKitWebResource/get-data sometimes fails and
1579         sometimes passes. We are now also getting the notification for the
1580         css image. Since we wait for 3 resources, sometimes the css image
1581         is loaded before and then checkResourceData is called for it, but
1582         not handled. When the css image is the last one loaded the test
1583         passes. So, we just need to wait for the 4 resources.
1584
1585         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1586         (testWebResourceGetData):
1587
1588 2015-12-03  David Kilzer  <ddkilzer@apple.com>
1589
1590         DumpRenderTree: Use-after-free in createBitmapContext() in PixelDumpSupportMac.mm
1591         <http://webkit.org/b/151845>
1592
1593         Reviewed by Simon Fraser.
1594
1595         Fixes the following static analyzer warning:
1596             DumpRenderTree/mac/PixelDumpSupportMac.mm:67:9: warning: Use of memory after it is freed
1597                     WTFLogAlways("DumpRenderTree: CGBitmapContextCreate(%p, %llu, %llu, 8, %llu, %p, 0x%x) failed\n", buffer, pixelsHigh, pixelsWide, rowBytes, colorSpace.get(), kCGImageAlphaPremultipliedFirst | kCGBitmapByteOrder32Host);
1598                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1599
1600         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1601         (createBitmapContext): Free 'buffer' after using it in logging
1602         to fix the use-after-free.  Assign a value of nullptr to buffer
1603         so we don't return with it set to a freed address.
1604
1605 2015-12-03  Jer Noble  <jer.noble@apple.com>
1606
1607         Expose WebCore's InvisibleAutoplayNotPermitted setting to WebKit & WebKit2
1608         https://bugs.webkit.org/show_bug.cgi?id=151830
1609
1610         Reviewed by Anders Carlsson.
1611
1612         Set invisibleAutoplayNotPermitted to NO by default both in WKTR and DRT.
1613
1614         * DumpRenderTree/mac/DumpRenderTree.mm:
1615         (resetWebPreferencesToConsistentValues):
1616         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1617         (WTR::initializeWebViewConfiguration):
1618
1619 2015-12-03  Anders Carlsson  <andersca@apple.com>
1620
1621         Remove Objective-C GC support
1622         https://bugs.webkit.org/show_bug.cgi?id=151819
1623         rdar://problem/23746991
1624
1625         Reviewed by Dan Bernstein.
1626
1627         * asan/asan.xcconfig:
1628
1629 2015-12-02  Yusuke Suzuki  <utatane.tea@gmail.com>
1630
1631         Allow nil for unspecified benchmark pathes
1632         https://bugs.webkit.org/show_bug.cgi?id=151784
1633
1634         Reviewed by Filip Pizlo.
1635
1636         `Pathname.new(nil)` will raise an error.
1637         Only generate Pathname if the benchmark path is specified.
1638
1639         * Scripts/run-jsc-benchmarks:
1640
1641 2015-12-02  Brent Fulgham  <bfulgham@apple.com>
1642
1643         [Win] Run non-http tests without Cygwin
1644         https://bugs.webkit.org/show_bug.cgi?id=151721
1645
1646         Reviewed by Andy Estes.
1647
1648         Support native 32-bit and 64-bit Python (and Perl) builds
1649         for running tests:
1650
1651         1. Use "startswith('win')", rather than "== 'win32'" to support
1652         various Windows build types.
1653         2. Supply full path for some native Windows utilities, since the
1654         path environment does not always have the specified, and they are
1655         guaranteed to exist in those specific locations.
1656         3. Make sure native Windows Python test runs pass proper environment
1657         variables to run programs.
1658         4. Append 'exe' suffix when running Windows executables.
1659         5. Use the _winreg Python module on Windows, since the Cygwin 'regtool'
1660         command doesn't exist.
1661         
1662         * Scripts/update-webkit: Use Perl $^X command to refer to the path of
1663         the current Perl executable, rather than requiring a new path search.
1664         * Scripts/webkitpy/common/find_files_unittest.py:
1665         (TestWinNormalize.test_win): Use startswith('win').
1666         * Scripts/webkitpy/common/prettypatch_unittest.py:
1667         (test_pretty_diff_encodings): Ditto.
1668         * Scripts/webkitpy/common/system/executive.py:
1669         (Executive._should_close_fds): Ditto.
1670         (Executive.shell_command_for_script): Use startswith('win').
1671         (Executive.kill_process): Use full path to killall executable.
1672         (Executive.check_running_pid): Use startswith('win').
1673         (Executive.running_pids): Ditto.
1674         (Executive.kill_all): Ditto. Also use path to 'killall' executable when
1675         running under native Windows Python.
1676         (Executive._child_process_encoding): Use startswith('win').
1677         (Executive._should_encode_child_process_arguments): Ditto.
1678         (Executive.popen): Recognize proper script engine on Windows, since it
1679         does not support the shebang syntax.
1680         (Executive.run_in_parallel): Use startswith('win').
1681         * Scripts/webkitpy/common/system/executive_unittest.py:
1682         (never_ending_command): Ditto.
1683         (ExecutiveTest.test_run_command_with_unicode): Ditto.
1684         (ExecutiveTest.serial_test_kill_process): Ditto.
1685         (ExecutiveTest.serial_test_kill_all): Ditto.
1686         (ExecutiveTest.serial_test_check_running_pid): Ditto.
1687         (ExecutiveTest.serial_test_run_in_parallel): Ditto.
1688         (main): Ditto.
1689         * Scripts/webkitpy/common/system/file_lock.py:
1690         (FileLock._create_lock): Ditto.
1691         (FileLock._remove_lock): Ditto.
1692         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1693         (RealFileSystemTest.test_chdir): Ditto.
1694         (RealFileSystemTest.test_chdir__notexists): Ditto.
1695         (RealFileSystemTest.test_maybe_make_directory__failure): Ditto.
1696         * Scripts/webkitpy/common/system/path_unittest.py:
1697         (AbspathTest.test_abspath_to_uri_win): Ditto.
1698         * Scripts/webkitpy/common/system/platforminfo.py:
1699         (PlatformInfo._determine_os_name): Ditto.
1700         * Scripts/webkitpy/common/system/user.py: Ditto.
1701         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1702         (ManagerTest.integration_test_needs_servers): Ditto.
1703         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1704         (LayoutTestApacheHttpd.__init__): Handle upper and lower-case
1705         driver letters.
1706         (LayoutTestApacheHttpd._get_apache_config_file_path): Ditto.
1707         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
1708         (TestLayoutTestApacheHttpd.test_start_cmd): Ditto.
1709         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
1710         (HttpServerBase._check_that_all_ports_are_available): Ditto.
1711         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
1712         (TestHttpServer.test_start_cmd): Ditto.
1713         * Scripts/webkitpy/port/base.py:
1714         (Port.to.setup_environ_for_server): Include 'COMSPEC', 'SYSTEMDRIVE',
1715         and 'SYSTEMROOT' in environment passed to test runners.
1716         (Port._apache_config_file_name_for_platform): Use startswith('win').
1717         (Port._build_path): Ditto.
1718         (Port._path_to_driver): Include 'exe' suffix when running under native
1719         Windows.
1720         * Scripts/webkitpy/port/driver.py:
1721         (Driver._setup_environ_for_driver): Explicitly make some environment
1722         variables strings.
1723         * Scripts/webkitpy/port/server_process.py:
1724         (ServerProcess.__init__): Use startswith('win').
1725         * Scripts/webkitpy/port/win.py:
1726         (WinPort): Use the win32 registry utilities on Windows, and appropriate
1727         registry key formats.
1728         (WinPort._ntsd_location): Revise tool search paths for Windows 10.
1729         (WinPort.read_registry_value): Revise to use _winreg library on Windows,
1730         and regtool on Cygwin.
1731         (WinPort.write_registry_value): Ditto.
1732         (WinPort.setup_crash_log_saving): Ditto.
1733         (WinPort.restore_crash_log_saving): Ditto.
1734         (WinPort.prevent_error_dialogs): Ditto.
1735         (WinPort.allow_error_dialogs): Ditto.
1736         (WinPort.find_system_pid): Revise to use Windows management
1737         infrastructure on native Windows, continue using 'ps' on Cygwin.
1738         (WinPort.read_registry_string): Deleted.
1739         (WinPort.write_registry_string): Deleted.
1740         * Scripts/webkitpy/test/main.py:
1741         (main): Use startswith('win').
1742         (Tester._parse_args): Ditto.
1743
1744 2015-12-01  Yusuke Suzuki  <utatane.tea@gmail.com>
1745
1746         [ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature
1747         https://bugs.webkit.org/show_bug.cgi?id=150792
1748
1749         Reviewed by Saam Barati.
1750
1751         * Scripts/webkitperl/FeatureList.pm:
1752
1753 2015-12-01  Commit Queue  <commit-queue@webkit.org>
1754
1755         Unreviewed, rolling out r192914.
1756         https://bugs.webkit.org/show_bug.cgi?id=151734
1757
1758         JSC tests for this change are failing on 32 and 64-bit bots
1759         (Requested by ryanhaddad on #webkit).
1760
1761         Reverted changeset:
1762
1763         "[ES6] Implement LLInt/Baseline Support for ES6 Generators and
1764         enable this feature"
1765         https://bugs.webkit.org/show_bug.cgi?id=150792
1766         http://trac.webkit.org/changeset/192914
1767
1768 2015-12-01  David Kilzer  <ddkilzer@apple.com>
1769
1770         EventSenderProxy::swipeGestureWithWheelAndMomentumPhases() leaks an EventSenderSyntheticEvent
1771         <http://webkit.org/b/151726>
1772
1773         Reviewed by Simon Fraser.
1774
1775         * WebKitTestRunner/mac/EventSenderProxy.mm:
1776         (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
1777         Deploy RetainPtr<EventSenderSyntheticEvent> to fix leak.
1778
1779 2015-12-01  Myles C. Maxfield  <mmaxfield@apple.com>
1780
1781         Give String and AtomicString an existingHash() function
1782         https://bugs.webkit.org/show_bug.cgi?id=151717
1783
1784         Reviewed by Andreas Kling.
1785
1786         * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
1787         (TestWebKitAPI::TEST):
1788         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
1789         (TestWebKitAPI::TEST):
1790
1791 2015-12-01  Yusuke Suzuki  <utatane.tea@gmail.com>
1792
1793         [ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature
1794         https://bugs.webkit.org/show_bug.cgi?id=150792
1795
1796         Reviewed by Saam Barati.
1797
1798         * Scripts/webkitperl/FeatureList.pm:
1799
1800 2015-12-01  Sam Weinig  <sam@webkit.org>
1801
1802         Need completionHandler-based WebKit C SPI for alert, confirm, and prompt
1803         <rdar://problem/23320863>
1804         https://bugs.webkit.org/show_bug.cgi?id=151708
1805
1806         Reviewed by Anders Carlsson.
1807
1808         * WebKitTestRunner/TestController.cpp:
1809         (WTR::TestController::createOtherPage):
1810         (WTR::TestController::createWebViewWithOptions):
1811         Update for new WKPageUIClient.
1812
1813 2015-12-01  Anders Carlsson  <andersca@apple.com>
1814
1815         Remove WebKit2.framework
1816         https://bugs.webkit.org/show_bug.cgi?id=151715
1817
1818         Reviewed by Dan Bernstein.
1819
1820         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp:
1821         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp:
1822         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
1823         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
1824         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
1825         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
1826         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
1827
1828 2015-12-01  Joseph Pecoraro  <pecoraro@apple.com>
1829
1830         Unreviewed common typo fix "occurance" => "occurrence".
1831
1832         * Scripts/webkitpy/tool/commands/queries.py:
1833         (FindFlakyTests._print_statistics):
1834
1835 2015-11-30  Alex Christensen  <achristensen@webkit.org>
1836
1837         Make ProcessModel always MultipleSecondaryProcesses
1838         https://bugs.webkit.org/show_bug.cgi?id=151662
1839
1840         Reviewed by Antti Koivisto.
1841
1842         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
1843         (TestWebKitAPI::TEST):
1844         * WebKitTestRunner/TestController.cpp:
1845         (WTR::TestController::generatePageConfiguration):
1846
1847 2015-11-30  Alex Christensen  <achristensen@webkit.org>
1848
1849         Make usesNetworkProcess always true
1850         https://bugs.webkit.org/show_bug.cgi?id=151580
1851
1852         Reviewed by Darin Adler.
1853
1854         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
1855         (TestWebKitAPI::TEST):
1856         * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp:
1857         (TestWebKitAPI::TEST):
1858         * WebKitTestRunner/TestController.cpp:
1859         (WTR::TestController::generatePageConfiguration):
1860
1861 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1862
1863         Unreviewed. Skip GTK+ test /webkit2/WebKitWebView/editable/editable in Debug.
1864
1865         Add a way to skip unit tests only for Debug or Release builds and
1866         skipt the test /webkit2/WebKitWebView/editable/editable only for Debug.
1867
1868         * Scripts/run-gtk-tests:
1869         (SkippedTest):
1870         (SkippedTest.__init__):
1871         (SkippedTest.__str__):
1872         (SkippedTest.skip_entire_suite):
1873         (SkippedTest.skip_for_build_type):
1874         (TestRunner):
1875         (TestRunner.__init__):
1876
1877 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1878
1879         Unreviewed. Fix a crash in GTK+ test /webkit2/WebKitWebView/custom-charset.
1880
1881         It's an assert hit because we are reloading a view loaded with
1882         HTML data which is not supported. Use loadURI instead.
1883
1884         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1885         (testWebViewCustomCharset):
1886
1887 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1888
1889         [GLIB] Remove GMainLoopSource and GThreadSafeMainLoopSource
1890         https://bugs.webkit.org/show_bug.cgi?id=151633
1891
1892         Reviewed by Csaba Osztrogonác.
1893
1894         * TestWebKitAPI/PlatformGTK.cmake:
1895         * TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp: Removed.
1896
1897 2015-11-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1898
1899         [GTK] Remove the remaining uses of GMainLoopSource
1900         https://bugs.webkit.org/show_bug.cgi?id=151632
1901
1902         Reviewed by Žan Doberšek.
1903
1904         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1905         (testWebViewSyncRequestOnMaxConns):
1906         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
1907         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1908         (WTR::TestRunner::TestRunner):
1909         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1910         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
1911         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
1912         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
1913         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1914         (WTR::timeoutSource):
1915         (WTR::TestController::notifyDone):
1916         (WTR::TestController::platformRunUntil):
1917
1918 2015-11-27  Csaba Osztrogonác  <ossy@webkit.org>
1919
1920         [cmake] Add testb3 to the build system
1921         https://bugs.webkit.org/show_bug.cgi?id=151619
1922
1923         Reviewed by Gyuyoung Kim.
1924
1925         * Scripts/build-jsc:
1926
1927 2015-11-27  Csaba Osztrogonác  <ossy@webkit.org>
1928
1929         [jhbuild] Fix pixman build with clang
1930         https://bugs.webkit.org/show_bug.cgi?id=151441
1931
1932         Reviewed by Carlos Garcia Campos.
1933
1934         * efl/jhbuild.modules:
1935         * gtk/jhbuild.modules:
1936
1937 2015-11-26  David Kilzer  <ddkilzer@apple.com>
1938
1939         Extract prependToEnvironmentVariableList
1940         <http://webkit.org/b/151536>
1941
1942         Reviewed by Daniel Bates.
1943
1944         Tests: webkitdirs_unittest/appendToEnvironmentVariableList.pl
1945                webkitdirs_unittest/prependToEnvironmentVariableList.pl
1946
1947         * Scripts/webkitdirs.pm: Export appendToEnvironmentVariableList
1948         and prependToEnvironmentVariableList.
1949         (appendToEnvironmentVariableList): Simplify variable name.
1950         Switch to use $Config{path_sep}.
1951         (prependToEnvironmentVariableList): Add new method.
1952         (setupMacWebKitEnvironment): Switch to use
1953         prependToEnvironmentVariableList().
1954         (setupIOSWebKitEnvironment): Ditto.
1955
1956         * Scripts/webkitperl/webkitdirs_unittest/appendToEnvironmentVariableList.pl: Added.
1957         * Scripts/webkitperl/webkitdirs_unittest/prependToEnvironmentVariableList.pl: Added.
1958
1959 2015-11-24  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1960
1961         REGRESSION(r192053): MiniBrowser doesn't exit when clicking on the close-window button
1962         https://bugs.webkit.org/show_bug.cgi?id=151567
1963
1964         Reviewed by Darin Adler.
1965
1966         * MiniBrowser/efl/main.c: Call window_close() instead of ewk_view_try_close().
1967         (on_window_deletion):
1968
1969 2015-11-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1970
1971         [GTK] Use the network process unconditionally
1972         https://bugs.webkit.org/show_bug.cgi?id=151541
1973
1974         Reviewed by Alex Christensen.
1975
1976         Fix TestInspectorServer test. Do not assume we already have the
1977         title we want when the page has been loaded, since the title is
1978         changed afterwards. So, check if the title has already been set,
1979         and if not wait for it.
1980
1981         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
1982         (openRemoteDebuggingSession):
1983
1984 2015-11-23  Alex Christensen  <achristensen@webkit.org>
1985
1986         Fix crash in ~WebProcessPool when using Geolocation with useNetworkProcess=true
1987         https://bugs.webkit.org/show_bug.cgi?id=151532
1988
1989         Reviewed by Benjamin Poulain.
1990
1991         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
1992         (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::eventsChanged):
1993         (TestWebKitAPI::TEST):
1994         (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::eventsChanged):
1995         (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::GeolocationTransitionToHighAccuracyStateTracker): Deleted.
1996         (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::GeolocationTransitionToLowAccuracyStateTracker): Deleted.
1997         Properly load about:blank in all WebViews to clean up.  Without this change, we had a 
1998         Geolocation provider stopping after its state tracker was destroyed with its stack frame,
1999         so it was calling a function on a test object that had gone out of scope.
2000         Also, call WKContextSetUsesNetworkProcess(context, true) to show what crash this fixed,
2001         but that will become the default soon and that call will be removed.
2002
2003 2015-11-22  David Kilzer  <ddkilzer@apple.com>
2004
2005         run-webkit-tests: http server for imported W3C tests doesn't work with --layout-tests-directory switch
2006         <http://webkit.org/b/151542>
2007
2008         Reviewed by Daniel Bates.
2009
2010         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2011         (base_url): Use the Port object (already passed in) to give us
2012         the path to the LayoutTests directory, which already checks for a
2013         --layout-tests-directory command-line switch.
2014         (WebPlatformTestServer.__init__): Remove layout_test_results_dir
2015         argument since we can get this from the Port object already
2016         passed in via Port.results_directory().  Also switch to use
2017         Port.layout_tests_dir() to get the LayoutTests directory.
2018
2019         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
2020         (TestWebPlatformTestServer.test_custom_layout_tests_directory):
2021         Add test case for custom LayoutTests directory.
2022         (TestWebPlatformTestServer.test_previously_spawned_instance):
2023         Update Port object to set mock results directory as if it was
2024         set on the command-line.  Remove unneeded argument from
2025         WebPlatformTestServer constructor.
2026         (TestWebPlatformTestServer.test_corrupted_subserver_files): Ditto.
2027
2028         * Scripts/webkitpy/port/base.py:
2029         (Port.to.start_web_platform_test_server): Remove unneeded
2030         argument from WebPlatformTestServer constuctor.
2031
2032 2015-11-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2033
2034         [GTK] Some unit tests fail when using the network process
2035         https://bugs.webkit.org/show_bug.cgi?id=151490
2036
2037         Reviewed by Martin Robinson.
2038
2039         Run the soup server in a separate thread in TestResources test to
2040         avoid deadlocks.
2041
2042         This fixes /webkit2/WebKitWebView/sync-request-on-max-conns and
2043         /webkit2/WebKitWebResource/get-data when using the network process.
2044
2045         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2046         (beforeAll): Create the WebKitTestServer with ServerRunInThread flag.
2047         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp:
2048         (WebKitTestServer::WebKitTestServer): When ServerRunInThread is
2049         present, create a WorkQueue to run the server.
2050         (WebKitTestServer::run): Run the server in the work queue if it
2051         has been created.
2052         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.h: Convert server
2053         type into server options as flags.
2054
2055 2015-11-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2056
2057         [GTK] ImageDiff should normalize the diff image
2058         https://bugs.webkit.org/show_bug.cgi?id=151261
2059
2060         Reviewed by Sergio Villar Senin.
2061
2062         * ImageDiff/gtk/ImageDiff.cpp:
2063         (readPixbufFromStdin): Fix memory leak.
2064         (differenceImageFromDifferenceBuffer): Normalize diff buffer.
2065         (calculateDifference): Pass max distance to differenceImageFromDifferenceBuffer.
2066
2067 == Rolled over to ChangeLog-2015-11-21 ==