Tools/ChangeLog

   1 2015-09-30  Daniel Bates  <dabates@apple.com>
   2
   3         Prioritize testing latest build request on iOS test bots
   4         https://bugs.webkit.org/show_bug.cgi?id=149669
   5
   6         Reviewed by Darin Adler.
   7
   8         We should prioritize testing of the latest build request on the iOS test bots
   9         as we do for Mac and Windows test bots.
  10
  11         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  12         (loadBuilderConfig):
  13
  14 2015-09-30  Daniel Bates  <dabates@apple.com>
  15
  16         Add buildbot category for iOS builders and testers
  17         https://bugs.webkit.org/show_bug.cgi?id=149667
  18
  19         Reviewed by Darin Adler.
  20
  21         Group iOS builders and testers under category iOS and add dashboard and console hyperlinks
  22         for iOS to the build.webkit.org home page.
  23
  24         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  25         (loadBuilderConfig):
  26         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
  27
  28 2015-09-30  Daniel Bates  <dabates@apple.com>
  29
  30         Actually fix the Mac builders build after <http://trac.webkit.org/changeset/190219>
  31         (https://bugs.webkit.org/show_bug.cgi?id=149539)
  32
  33         I inadvertently didn't remove the ONLY_ACTIVE_ARCH=NO flag when building on a Mac
  34         in <http://trac.webkit.org/changeset/190351>.
  35
  36         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  37         (CompileWebKit.start):
  38
  39 2015-09-30  Daniel Bates  <dabates@apple.com>
  40
  41         Attempt to fix the Mac builders build after <http://trac.webkit.org/changeset/190219>
  42         (https://bugs.webkit.org/show_bug.cgi?id=149539)
  43
  44         {32, 64}-bit Mac builders should not try to build project {Plugin.64, Plugin.32},
  45         respectively; only pass ONLY_ACTIVE_ARCH=NO when building for iOS.
  46
  47         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  48         (CompileWebKit.start):
  49
  50 2015-09-30  Lucas Forschler  <lforschler@apple.com>
  51
  52         bot210 was configured for a queue instead of bot126.
  53
  54         Unreviewed config.json fix.
  55
  56         * BuildSlaveSupport/build.webkit.org-config/config.json:
  57
  58 2015-09-30  Lucas Forschler  <lforschler@apple.com>
  59
  60         Bring El Capitan buildbot infrastructure online.
  61         https://bugs.webkit.org/show_bug.cgi?id=149605
  62
  63         Reviewed by Darin Adler.
  64
  65         * BuildSlaveSupport/build.webkit.org-config/config.json:
  66
  67 2015-09-30  Tomas Popela  <tpopela@redhat.com>
  68
  69         [GTK] Deprecation warnings in DOMNodeTest
  70         https://bugs.webkit.org/show_bug.cgi?id=149663
  71
  72         After the webkit_dom_document_get_elements_by_tag_name deprecation we
  73         need to update the tests to use webkit_dom_document_query_selector_all
  74         to avoid compilation warnings.
  75
  76         Also add a new test for webkit_dom_document_get_elements_by_tag_name_as_html_collection
  77         (the suggested replacement for the deprecated function).
  78
  79         Reviewed by Carlos Garcia Campos.
  80
  81         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
  82         (WebKitDOMNodeTest::testTagNamesNodeList):
  83         (WebKitDOMNodeTest::testTagNamesHTMLCollection):
  84         (registerTests):
  85         (WebKitDOMNodeTest::testTagNames): Deleted.
  86         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
  87         (prepareDOMForTagNamesTests):
  88         (testWebKitDOMNodeTagNamesNodeList):
  89         (testWebKitDOMNodeTagNamesHTMLCollection):
  90         (beforeAll):
  91         (testWebKitDOMNodeTagNames): Deleted.
  92
  93 2015-09-29  Simon Fraser  <simon.fraser@apple.com>
  94
  95         WebKitTestRunner fails to apply "useFlexibleViewport" when it's specified in a file comment
  96         https://bugs.webkit.org/show_bug.cgi?id=149650
  97
  98         Reviewed by Tim Horton.
  99
 100         TestInvocation::invoke() consulted shouldMakeViewportFlexible(), but that only
 101         looks at the file path, and not the custom options that come from file comments.
 102
 103         Fix by computing TestOptions before making the TestInvocation, and setting them
 104         as const TestInvocation data. This meant changing various call sites to take
 105         the std::string pathOrURL, rather than the TestInvocation itself.
 106
 107         Also initialize TestInvocation with a WKURLRef, rather than a std::string.
 108
 109         * WebKitTestRunner/CMakeLists.txt:
 110         * WebKitTestRunner/TestController.cpp:
 111         (WTR::TestController::ensureViewSupportsOptionsForTest):
 112         (WTR::testPath):
 113         (WTR::createTestURL):
 114         (WTR::updateTestOptionsFromTestHeader):
 115         (WTR::TestController::testOptionsForTest):
 116         (WTR::TestController::updateWebViewSizeForTest):
 117         (WTR::TestController::updateWindowScaleForTest):
 118         (WTR::TestController::runTest):
 119         * WebKitTestRunner/TestController.h:
 120         * WebKitTestRunner/TestInvocation.cpp:
 121         (WTR::TestInvocation::TestInvocation):
 122         (WTR::TestInvocation::invoke):
 123         (WTR::createWKURL): Deleted.
 124         (WTR::TestInvocation::shouldMakeViewportFlexible): Deleted.
 125         (WTR::TestInvocation::shouldUseFixedLayout): Deleted.
 126         * WebKitTestRunner/TestInvocation.h:
 127         (WTR::TestInvocation::options):
 128         * WebKitTestRunner/TestOptions.cpp: Copied from Tools/WebKitTestRunner/TestOptions.h.
 129         (WTR::pathContains):
 130         (WTR::shouldMakeViewportFlexible):
 131         (WTR::shouldUseFixedLayout):
 132         (WTR::isSVGTestPath):
 133         (WTR::isHiDPITestPath):
 134         (WTR::TestOptions::TestOptions):
 135         * WebKitTestRunner/TestOptions.h:
 136         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
 137         * WebKitTestRunner/efl/TestControllerEfl.cpp:
 138         (WTR::pathContains):
 139         (WTR::shouldUseFixedLayout):
 140         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
 141         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
 142         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
 143         * WebKitTestRunner/ios/TestControllerIOS.mm:
 144         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
 145         * WebKitTestRunner/mac/TestControllerMac.mm:
 146         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
 147
 148 2015-09-29  Aakash Jain  <aakash_jain@apple.com>
 149
 150         Flakiness dashboard should support OS X El Capitan
 151         https://bugs.webkit.org/show_bug.cgi?id=149648
 152
 153         Reviewed by Alexey Proskuryakov.
 154
 155         * QueueStatusServer/app.yaml: We do not need to maintain SVN revision here because of
 156         difference between new appscale and old Google App Engine implementation.
 157         * TestResultServer/app.yaml: Same.
 158         * TestResultServer/static-dashboards/builders.jsonp: Added OSX El Capitan support.
 159
 160 2015-09-29  Daniel Bates  <dabates@apple.com>
 161
 162         configure-xcode-for-ios-development does not work with Xcode 7
 163         https://bugs.webkit.org/show_bug.cgi?id=149640
 164
 165         Reviewed by Alexey Proskuryakov.
 166
 167         When Xcode 7 is installed, running configure-xcode-for-ios-development dies with an error
 168         because it cannot find the Xcode specification files for iOS simulator and device. These
 169         files have moved to a new location in Xcode 7 distribution. Moreover we must add the
 170         relevant definitions to the Xcode 7 specification files directly as opposed to creating
 171         new specification files with the added definitions (as we did in older versions of Xcode)
 172         in order for Xcode 7 to honor these definitions.
 173
 174         * Scripts/configure-xcode-for-ios-development: Sorted forward declarations.
 175         (updateXcodeSpecificationFilesForSDKIfNeeded): Added.
 176         (updateXcode7SpecificationFile): Added.
 177         (createLegacyXcodeSpecificationFilesForSDKIfNeeded): Formerly named createXcodeSpecificationFilesForSDKIfNeeded.
 178         (writeXcodeSpecification): Moved congratulations line to caller so as to write out the
 179         appropriate success message.
 180         (mergeXcodeSpecificationWithSpecificationAndId): Formerly named createXcodeSpecificationFromSpecificationAndId.
 181         (createXcodeSpecificationFilesForSDKIfNeeded): Deleted.
 182         (createXcodeSpecificationFromSpecificationAndId): Deleted.
 183
 184 2015-09-29  Brent Fulgham  <bfulgham@apple.com>
 185
 186         [Win] Allow 'prepare-ChangeLog' to be used without Cygwin
 187         https://bugs.webkit.org/show_bug.cgi?id=149639
 188
 189         Reviewed by Alex Christensen.
 190
 191         * Scripts/VCSUtils.pm:
 192         (exitStatus): Use 'isWindows()' method.
 193         (isSVNVersion16OrNewer): 'eval' is not needed here, and just causes
 194         an error. This method could probably just go away.
 195         (normalizePath): Leave Windows (or Unix) paths as platform paths, rather than
 196         always changing to Unix style.
 197         (unixPath): Added. Needed so Windows can always show a Unix path in the
 198         ChangeLog file.
 199         (changeLogName): Work around the fact that 'getpwuid' is not available on
 200         a pure Windows build of Perl.
 201         * Scripts/prepare-ChangeLog:
 202         (generateFunctionLists): Normalize path received from 'svn' in case it's a Unix
 203         path on Windows.
 204         (svnUpdateCommand): Added helper function. Needed because Windows Perl does not
 205         support using arrays for 'open' arguments.
 206         (resolveChangeLogsPath): Ditto.
 207         (resolveConflictedChangeLogs): Use new helper functions.
 208         (generateNewChangeLogs): Force Windows to use Unix paths in ChangeLog output.
 209         (diffCommand): Use double-quotes for paths, since Windows doesn't understand single
 210         quotes. Unix systems are happy either way.
 211         (statusCommand): Ditto.
 212         * Scripts/webkitdirs.pm:
 213         (launcherName): Drive-by fix. WinLauncher was renamed to MiniBrowser some time ago.
 214
 215 2015-09-29  Brent Fulgham  <bfulgham@apple.com>
 216
 217         [Win] Unreviewed 64-bit build fix after switch to CMake.
 218
 219         * Scripts/webkitdirs.pm:
 220         (determineIsWin64FromArchitecture): Added.
 221
 222 2015-09-16  Carlos Garcia Campos  <cgarcia@igalia.com>
 223
 224         printing does not use minimum page zoom factor
 225         https://bugs.webkit.org/show_bug.cgi?id=108507
 226
 227         Reviewed by Darin Adler.
 228
 229         WebKitTestRunner always takes the snapshots from the UI process
 230         (expect for IOS), so in the case of printing, the layout in the
 231         web view is not the expected one. When printing, we need to take
 232         the snapshot in the web process and ensure it's rendered with a
 233         PrintContext.
 234
 235         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
 236         (WTR::InjectedBundlePage::dump): When dumping pixels, pass
 237         kWKSnapshotOptionsPrinting option to
 238         WKBundlePageCreateSnapshotWithOptions() when printing.
 239
 240 2015-09-28  Carlos Garcia Campos  <cgarcia@igalia.com>
 241
 242         [WTR] Pixel tests generate the snapshots twice in Web and UI processes
 243         https://bugs.webkit.org/show_bug.cgi?id=149595
 244
 245         Reviewed by Tim Horton.
 246
 247         All ports except IOS implement
 248         PlatformWebView::windowSnapshotImage() to generate the snapshot
 249         for the pixel tests in the UI process. But we are still generating
 250         a snapshot for pixel tests in the Web process too, that is passed
 251         to the UI process but ignored.
 252         Whether a pixel result is needed or not, is only known by the web
 253         process depending on whether the test called dumpAsText with
 254         dumpPixels == true or not. Since the pixels are now dump in the UI
 255         process, we need to pass that information to the UI process when
 256         the test is done. For that we set a PixelResultIsPending bool
 257         parameter to the Done message, and we only add the PixelResult
 258         when UI process doesn't need to generate the pixels dump.
 259
 260         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
 261         (WTR::InjectedBundle::didReceiveMessageToPage): Set
 262         m_pixelResultIsPending to false on reset.
 263         (WTR::InjectedBundle::done): Add PixelResultIsPending parameter to the
 264         Done message, and set the PixelResult if m_pixelResultIsPending is false.
 265         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
 266         (WTR::InjectedBundle::setPixelResult): Set m_pixelResultIsPending to false.
 267         (WTR::InjectedBundle::setNeedsPixelResult): Set m_pixelResultIsPending.
 268         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
 269         (WTR::InjectedBundlePage::dump): Only create a snapshot for IOS
 270         port.
 271         * WebKitTestRunner/TestInvocation.cpp:
 272         (WTR::TestInvocation::dumpResults): Use either the pixel result
 273         from the web process or generate a pixel result from the web view
 274         if need it.
 275         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
 276         * WebKitTestRunner/TestInvocation.h: Add SnapshotResultType enum
 277         parameter to dumpPixelsAndCompareWithExpected, since the snapshot
 278         is created by the caller now, but the CG implementation needs to
 279         know if it's a Web or UI process snapshot.
 280         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
 281         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
 282         cairo surface for the given image.
 283         * WebKitTestRunner/cg/TestInvocationCG.cpp:
 284         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
 285         CGContext for the given image.
 286
 287 2015-09-28  Dean Johnson  <dean_johnson@apple.com>
 288
 289         Fix JS errors on dashboard metrics page
 290         https://bugs.webkit.org/show_bug.cgi?id=149608
 291
 292         Reviewed by Alexey Proskuryakov.
 293
 294         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Updated to use Settings.
 295         (initPlatformsByFamily):
 296         (updateHiddenPlatforms):
 297         (parsePlatformFamily): Deleted.
 298         (updateToggleButtons): Deleted.
 299         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
 300         (updateHiddenPlatforms): Added to remove errors.
 301         (initPlatformsByFamily): Added to remove errors.
 302         (unhiddenQueues): Updated to use Settings.
 303         (documentReady): Added logic to add toggle buttons to the settings menu.
 304         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
 305         (Settings.prototype.parsePlatformFamily): Moved duplicate logic from Main.js and
 306         MetricsMain.js to Settings.
 307         (Settings.prototype.updateToggleButtons): Moved duplicate logic from Main.js and
 308         MetricsMain.js to Settings.
 309         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
 310         (QueueView.prototype._updateHiddenState): Updated to use Settings.
 311
 312 2015-09-28  Aakash Jain  <aakash_jain@apple.com>
 313
 314         Appscale query fails because of missing index
 315         https://bugs.webkit.org/show_bug.cgi?id=149609
 316
 317         Reviewed by Darin Adler.
 318
 319         * QueueStatusServer/index.yaml: Added the required index.
 320
 321 2015-09-28  Brent Fulgham  <bfulgham@apple.com>
 322
 323         [Win] Fix the 64-bit build after switch to cmake.
 324
 325         Reviewed by Alex Christensen.
 326
 327         * Scripts/webkitdirs.pm:
 328         (generateBuildSystemFromCMakeProject): Use correct arguments for cmake to
 329         run a 64-bit build.
 330
 331 2015-09-28  Brent Fulgham  <bfulgham@apple.com>
 332
 333         [Win] Allow Windows to run test-webkitpy without Cygwin
 334         https://bugs.webkit.org/show_bug.cgi?id=149602
 335
 336         Reviewed by Alex Christensen.
 337
 338         These changes mostly shift from hard-coded paths using UNIX-style
 339         separators to Python's "os.path.join" syntax that uses the correct
 340         path separator for each platform.
 341
 342         * Scripts/webkitpy/common/system/path.py:
 343         (cygpath): Don't pass paths through Cygpath on native Windows.
 344         * Scripts/webkitpy/port/win.py:
 345         (WinPort._path_to_apache): Use os.path.join.
 346         (WinPort._ntsd_location): Support 64-bit environment (ProgramW6432 doesn't exist
 347         in 64-bit environments).
 348         * Scripts/webkitpy/style/checker.py: Use os.path.join.
 349         * Scripts/webkitpy/style/checker_unittest.py:
 350         (GlobalVariablesTest.test_path_rules_specifier.assertNoCheck): Use os.path.join.
 351         (GlobalVariablesTest.test_path_rules_specifier): Ditto.
 352         (GlobalVariablesTest): Ditto.
 353         (GlobalVariablesTest.test_max_reports_per_category): Ditto.
 354         (CheckerDispatcherSkipTest.test_should_skip_with_warning): Ditto.
 355         (CheckerDispatcherDispatchTest.test_js_paths): Ditto.
 356         (CheckerDispatcherDispatchTest.test_json_paths): Ditto.
 357         (CheckerDispatcherDispatchTest.test_python_paths): Ditto.
 358         (CheckerDispatcherDispatchTest.test_text_paths): Ditto.
 359         (CheckerDispatcherDispatchTest.test_xml_paths): Ditto.
 360         (StyleProcessor_CodeCoverageTest._create_carriage_checker_class): Ditto.
 361         (StyleProcessor_CodeCoverageTest): Ditto.
 362         (StyleProcessor_CodeCoverageTest.test_should_process__skip_without_warning): Ditto.
 363         (StyleProcessor_CodeCoverageTest.test_should_process__skip_with_warning): Ditto.
 364         (StyleProcessor_CodeCoverageTest.test_should_process__true_result): Ditto.
 365         * Scripts/webkitpy/w3c/test_parser_unittest.py: Uses os.path.join rather than
 366         manual string concatenation of paths.
 367
 368 2015-09-28  Csaba Osztrogonác  <ossy@webkit.org>
 369
 370         Add bugzilla addresses of committers to contributors.json
 371         https://bugs.webkit.org/show_bug.cgi?id=149520
 372
 373         Reviewed by Darin Adler.
 374
 375         * Scripts/webkitpy/common/config/contributors.json:
 376
 377 2015-09-28  Csaba Osztrogonác  <ossy@webkit.org>
 378
 379         validate-committer-lists -b shouldn't need edituser privileges
 380         https://bugs.webkit.org/show_bug.cgi?id=149519
 381
 382         Reviewed by Darin Adler.
 383
 384         * Scripts/validate-committer-lists:
 385         (CommitterListBugzillaChecker._has_invalid_bugzilla_email):
 386         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
 387         (BugzillaQueries.is_invalid_bugzilla_email):
 388         (BugzillaQueries): Deleted.
 389         (BugzillaQueries.fetch_logins_matching_substring): Deleted.
 390
 391 2015-09-26  Carlos Garcia Campos  <cgarcia@igalia.com>
 392
 393         Unreviewed. Gardening: skip media stream tests failing after r190262.
 394
 395         * Scripts/run-gtk-tests:
 396         (TestRunner):
 397
 398 2015-09-25  Alexey Proskuryakov  <ap@apple.com>
 399
 400         [Mac] USE_INTERNAL_SDK is used undefined in tools projects
 401         https://bugs.webkit.org/show_bug.cgi?id=149571
 402
 403         Reviewed by Dan Bernstein.
 404
 405         Use the same pattern as in Source directory configurations (so, also get rid of AspenFamily.xcconfig).
 406
 407         * DumpRenderTree/mac/Configurations/Base.xcconfig:
 408         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
 409         * LayoutTestRelay/Configurations/Base.xcconfig:
 410         * MiniBrowser/Configurations/Base.xcconfig:
 411         * MiniBrowser/Configurations/DebugRelease.xcconfig:
 412         * TestWebKitAPI/Configurations/Base.xcconfig:
 413         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
 414         * WebEditingTester/Configurations/Base.xcconfig:
 415         * WebEditingTester/Configurations/DebugRelease.xcconfig:
 416         * WebKitTestRunner/Configurations/Base.xcconfig:
 417         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
 418         * WebKitTestRunner/iOS.xcconfig: Removed.
 419
 420 2015-09-25  Eric Carlson  <eric.carlson@apple.com>
 421
 422         Clean up user media request internal API
 423         https://bugs.webkit.org/show_bug.cgi?id=149527
 424
 425         Reviewed by Tim Horton.
 426
 427         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
 428         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack): Update for API changes.
 429
 430         * WebKitTestRunner/TestController.cpp:
 431         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Ditto.
 432
 433 2015-09-25  Simon Fraser  <simon.fraser@apple.com>
 434
 435         [iOS WK2] Add viewport tests and fix runUIScript() timing issues
 436         https://bugs.webkit.org/show_bug.cgi?id=149577
 437
 438         Reviewed by Tim Horton.
 439
 440         When calling testRunner.runUIScript() from a page load event, the script could run
 441         in the UI process before the current remote layer tree transaction had been handled
 442         there. This meant that runUIScript() could query state which was about to change.
 443
 444         Fix by delaying the execution of the UI script until a layer tree transaction has
 445         been handled by the UI process, leveraging the existing DrawingAreaProxy::dispatchAfterEnsuringDrawing().
 446
 447         * WebKitTestRunner/TestInvocation.cpp:
 448         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
 449         (WTR::TestInvocation::runUISideScriptAfterUpdateCallback):
 450         * WebKitTestRunner/TestInvocation.h:
 451
 452 2015-09-25  Alexey Proskuryakov  <ap@apple.com>
 453
 454         [Mac] Media tests start to time out after a few days of bot uptime
 455         https://bugs.webkit.org/show_bug.cgi?id=149468
 456
 457         Reviewed by Darin Adler.
 458
 459         Delete cache directory in addition to the temporary one. Don't delete /private/tmp/MediaCache,
 460         as it's not longer used by tests. Set TMPDIR and DIRHELPER_USER_DIR_SUFFIX to make
 461         all temporary and cache files go to a custom location.
 462
 463         * Scripts/webkitpy/port/base.py:
 464         * Scripts/webkitpy/port/driver.py:
 465         * Scripts/webkitpy/port/mac.py:
 466         * Scripts/webkitpy/port/win.py:
 467         (WinPort._driver_tempdir_for_environment): Deleted unused function.
 468
 469 2015-09-25  Dan Bernstein  <mitz@apple.com>
 470
 471         Removed MiniBrowser.entitlements.
 472
 473         Rubber-stamped by Anders Carlsson.
 474
 475         The entitlements weren’t used anyway.
 476
 477         * MiniBrowser/MiniBrowser.entitlements: Removed.
 478         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
 479
 480 2015-09-24  Daniel Bates  <dabates@apple.com>
 481
 482         Add WebKitSystemInterface for iOS 9.0
 483         https://bugs.webkit.org/show_bug.cgi?id=149550
 484
 485         Rubber-stamped by Alexey Proskuryakov.
 486
 487         * Scripts/copy-webkitlibraries-to-product-directory:
 488
 489 2015-09-24  Daniel Bates  <dabates@apple.com>
 490
 491         Support building for arbitrary architectures
 492         https://bugs.webkit.org/show_bug.cgi?id=149539
 493
 494         Reviewed by Alexey Proskuryakov.
 495
 496         Teach buildbot to pass the architectures associated with the builder to build-webkit
 497         when building on OS X and iOS. As a side effect of this change we now support building
 498         universal binaries when multiples architectures are specified.
 499
 500         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
 501         (CompileWebKit.start):
 502
 503 2015-09-24  Daniel Bates  <dabates@apple.com>
 504
 505         Fix the build after <http://trac.webkit.org/changeset/190212>
 506         (http://trac.webkit.org/changeset/190212)
 507
 508         I inadvertently did not remove the fullPlatform argument from one of the callers of archiveBuiltProduct().
 509
 510         * BuildSlaveSupport/built-product-archive:
 511         (main):
 512
 513 2015-09-24  Daniel Bates  <dabates@apple.com>
 514
 515         Support running unit tests on iOS Simulator test bot
 516         https://bugs.webkit.org/show_bug.cgi?id=149536
 517
 518         Reviewed by Alexey Proskuryakov.
 519
 520         Implements support for running unit tests on a iOS test bot. At the time of writing,
 521         the script run-api-tests supports running unit tests on Mac, Windows and iOS Simulator.
 522
 523         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
 524         (RunUnitTests.start): Append appropriate command line flag when invoking script run-api-tests.
 525         (TestFactory.__init__): Add step RunUnitTests when the test bot is for the iOS Simulator platform.
 526
 527 2015-09-24  Daniel Bates  <dabates@apple.com>
 528
 529         Add support infrastructure for OpenSource iOS builders and testers
 530         https://bugs.webkit.org/show_bug.cgi?id=149534
 531
 532         Reviewed by Darin Adler.
 533
 534         Towards setting up OpenSource iOS build bots, teach buildbot and its support
 535         scripts about iOS.
 536
 537         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
 538         (appendCustomBuildFlags): Require the caller to pass parameter fullPlatform and append
 539         --ios-simulator or --device for a builder/tester whose full platform name begins with
 540         "ios-simulator" or "ios", respectively.
 541         (RunJavaScriptCoreTests.start): Pass the full platform name to appendCustomBuildFlags().
 542         * BuildSlaveSupport/built-product-archive:
 543         (main): Pass the full platform name to determineWebKitBuildDirectory().
 544         (determineWebKitBuildDirectory): Call script webkit-build-directory with the appropriate
 545         command line flag when building for iOS.
 546         (archiveBuiltProduct): Use the same logic for iOS as we do for Mac. Also, remove unused
 547         parameter fullPlatform. This parameter was originally added in r125066 to support the
 548         Chromium Android port, which has since been removed from the OpenSource WebKit Project.
 549         (extractBuiltProduct): Use the same logic for iOS as we do for Mac.
 550         * BuildSlaveSupport/clean-build:
 551         (main): Call script webkit-build-directory with the appropriate command line flag when
 552         building for iOS.
 553         * BuildSlaveSupport/delete-stale-build-files:
 554         (main): Use the same logic for iOS as we do for Mac.
 555         (webkitBuildDirectory): Call script webkit-build-directory with the appropriate command line
 556         flag when building for iOS.
 557         * BuildSlaveSupport/test-result-archive:
 558         (archiveTestResults): Use the same logic for iOS as we do for Mac.
 559
 560 2015-09-24  Daniel Bates  <dabates@apple.com>
 561
 562         Remove Chromium-specific changes to script built-product-archive
 563         https://bugs.webkit.org/show_bug.cgi?id=149530
 564
 565         Rubber-stamped by Csaba Osztrogonác.
 566
 567         Reverts changes made in r113074 and r113067 to support Chromium testers. The
 568         Chromium code has long since been removed from the OpenSource WebKit Project.
 569
 570         * BuildSlaveSupport/built-product-archive:
 571         (createZipManually):
 572         (createZip):
 573         (archiveBuiltProduct):
 574
 575 2015-09-24  Dan Bernstein  <mitz@apple.com>
 576
 577         Build fix.
 578
 579         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
 580
 581 2015-09-24  Mark Lam  <mark.lam@apple.com>
 582
 583         Unreviewed. Make Lucas Forschler a WebKit reviewer.
 584
 585         * Scripts/webkitpy/common/config/contributors.json:
 586
 587 2015-09-24  Carlos Garcia Campos  <cgarcia@igalia.com>
 588
 589         Unreviewed. Fix GObject DOM API breaks after r190120.
 590
 591         Bring back code removed in r169931 to handle documentation of
 592         deleted classes.
 593
 594         * gtk/webkitdom.py:
 595         (WebKitDOMDocGenerator):
 596         (WebKitDOMDocGenerator.write_deleted_classes):
 597         (WebKitDOMDocGenerator.generate):
 598         (write_deleted_classes):
 599         (WebKitDOMDocGeneratorSections._deleted_class):
 600         (WebKitDOMDocGeneratorSections._deleted_class.in):
 601         (WebKitDOMDocGeneratorSections.write_deleted_classes):
 602         (WebKitDOMDocGeneratorSections.write_deleted_classes.with):
 603
 604 2015-09-23  Myles C. Maxfield  <mmaxfield@apple.com>
 605
 606         [Cocoa] [Font Features] Implement font-variant-*
 607         https://bugs.webkit.org/show_bug.cgi?id=148413
 608
 609         Reviewed by Darin Adler.
 610
 611         Update test font to use "lnum" feature.
 612
 613         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
 614         (Generator::appendGSUBTable):
 615
 616 2015-09-22  Andy Estes  <aestes@apple.com>
 617
 618         ContentFiltering.AllowDownloadAfterAddData is very flaky
 619         https://bugs.webkit.org/show_bug.cgi?id=148885
 620         <rdar://problem/22729563>
 621
 622         Reviewed by Alexey Proskuryakov.
 623
 624         The AllowDownload* tests were relying on -_downloadDidStart: being called before -webView:didFinishNavigation:,
 625         but there is no guarantee of this. For tests that should allow a download, spin the runloop until
 626         -_downloadDidStart: is called. The test will now timeout on failure, but will no longer produce false failures.
 627
 628         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
 629         (downloadTest):
 630
 631 2015-09-22  Alexey Proskuryakov  <ap@apple.com>
 632
 633         Mavericks: Media tests start to time out after a few days of bot uptime
 634         https://bugs.webkit.org/show_bug.cgi?id=149468
 635
 636         Reviewed by Chris Dumez.
 637
 638         * Scripts/webkitpy/port/base.py:
 639         * Scripts/webkitpy/port/driver.py:
 640         * Scripts/webkitpy/port/mac.py:
 641
 642 2015-09-22  Nan Wang  <n_wang@apple.com>
 643
 644         Unreviewed, add myself to the committers list.
 645
 646         * Scripts/webkitpy/common/config/contributors.json:
 647
 648 2015-09-21  Simon Fraser  <simon.fraser@apple.com>
 649
 650         Remove 'nullable' to fix older iOS builds.
 651
 652         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
 653         (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]):
 654
 655 2015-09-21  Brent Fulgham  <bfulgham@apple.com>
 656
 657         [Win] Show tiled drawing debug overlay on Windows
 658         https://bugs.webkit.org/show_bug.cgi?id=149426
 659
 660         Reviewed by Dean Jackson.
 661
 662         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc: Add new menu option.
 663         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h: Ditto.
 664         * MiniBrowser/win/Common.cpp:
 665         (::ToggleMenuItem): Recognize new menu item and toggle the 'showTiledScrollingIndicator'
 666         flag if needed.
 667         * MiniBrowser/win/MiniBrowser.h: Update to use new IWebPreferencesPrivate3 class.
 668
 669 2015-09-21  Brent Fulgham  <bfulgham@apple.com>
 670
 671         [Win] Use command-line argument to launch in regular or High DPI mode.
 672         https://bugs.webkit.org/show_bug.cgi?id=149417
 673
 674         Reviewed by Dean Jackson.
 675
 676         * MiniBrowser/win/Common.cpp:
 677         (parseCommandLine): Ignore the '--highDPI' argument. It's used at the
 678         very start of execution, before the MiniBrowser.dll is loaded.
 679         * win/DLLLauncher/DLLLauncherMain.cpp:
 680         (shouldUseHighDPI): Check for '--highDPI', and use this mode if
 681         present. On WinCairo, always use High DPI.
 682
 683 2015-09-21  Ryosuke Niwa  <rniwa@webkit.org>
 684
 685         32-bit Mac build fix attempt after r190065.
 686
 687         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
 688
 689 2015-09-21  Alexey Proskuryakov  <ap@apple.com>
 690
 691         [OS X] Update for Xcode 7.0 on Yosemite
 692         https://bugs.webkit.org/show_bug.cgi?id=149389
 693
 694         Reviewed by Dan Bernstein.
 695
 696         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
 697         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
 698         Removed unneeded declarations - conforming to a protocol is sufficient.
 699
 700         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
 701         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
 702         Changed the definitions to be compiled whenever the SDK requires it (so we will have
 703         dead code compiled in when building for 10.10 with 10.11 SDK, somewhat unfortunately).
 704
 705 2015-09-21  Simon Fraser  <simon.fraser@apple.com>
 706
 707         Add the ability for tests to run script in the UI process in WebKitTestRunner
 708         https://bugs.webkit.org/show_bug.cgi?id=149356
 709
 710         Reviewed by Tim Horton.
 711
 712         This change adds testRunner.runUIScript(script, callback), which allows a test
 713         to execute script in a JSContext which runs in the UI process. That context
 714         has bindings exposed through the UIScriptController interface; currently one test
 715         function, and some iOS-specific functions are included. UIScriptController can be
 716         async with a callback, and runUIScript() itself is asynchronous. When the UI
 717         script is complete, it calls uiController.uiScriptComplete(result), where 'result'
 718         is a string passed back to the web process, and given to the runUIScript()
 719         callback function.
 720
 721         Thanks to Gyuyoung Kim for help with the Gtk/Efl build.
 722
 723         * WebKitTestRunner/DerivedSources.make: Build UIScriptController.idl.
 724         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Add runUIScript().
 725         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
 726         (WTR::InjectedBundle::didReceiveMessageToPage): When the UI-side script is
 727         complete, call back into TestRunner.
 728         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
 729         (WTR::nextUIScriptCallbackID):
 730         (WTR::TestRunner::runUIScript): Post a message to the injected bundle to run the UI script.
 731         (WTR::TestRunner::runUIScriptCallback): When the UI script is done, execute its callback function.
 732         * WebKitTestRunner/InjectedBundle/TestRunner.h:
 733         * WebKitTestRunner/PlatformWebView.h:
 734         * WebKitTestRunner/TestController.cpp:
 735         (WTR::updateTestOptionsFromTestHeader):
 736         (WTR::TestController::testOptionsForTest): Support "useFlexibleViewport" as a test argument.
 737         (WTR::shouldUseFixedLayout): Deleted. Moved to a TestInvocation function.
 738         * WebKitTestRunner/TestInvocation.cpp:
 739         (WTR::TestInvocation::shouldUseFixedLayout):
 740         (WTR::TestInvocation::shouldUseThreadedScrolling):
 741         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
 742         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
 743         (WTR::TestInvocation::runUISideScript): Run the UI-side script!
 744         (WTR::TestInvocation::uiScriptDidComplete): Send a message back to the injected bundle.
 745         * WebKitTestRunner/TestInvocation.h:
 746         * WebKitTestRunner/TestOptions.h:
 747         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
 748         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
 749         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
 750         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm: Added.
 751         (-[TestRunnerWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]):
 752         (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]):
 753         (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]):
 754         (-[TestRunnerWKWebView onDidEndZooming:]): Allow a test to hook into the end of zooming.
 755         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
 756         (WTR::PlatformWebView::PlatformWebView): Make a TestRunnerWKWebView on iOS.
 757         * WebKitTestRunner/ios/UIScriptControllerIOS.mm: Added.
 758         (WTR::UIScriptController::doAsyncTask):
 759         (WTR::UIScriptController::zoomToScale):
 760         (WTR::UIScriptController::zoomScale):
 761         (WTR::UIScriptController::minimumZoomScale):
 762         (WTR::UIScriptController::maximumZoomScale):
 763         (WTR::UIScriptController::contentVisibleRect):
 764         * WebKitTestRunner/mac/EventSenderProxy.mm:
 765         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
 766         (-[TestRunnerWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]): Deleted.
 767         * WebKitTestRunner/mac/TestControllerMac.mm:
 768         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
 769         (WTR::shouldUseThreadedScrolling): Deleted. Moved to TestInvocation.
 770         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
 771         * WebKitTestRunner/uiscriptcontext/UIScriptContext.cpp: Added. Owns the JS context in the UI process.
 772         (UIScriptContext::UIScriptContext):
 773         (UIScriptContext::~UIScriptContext):
 774         (UIScriptContext::runUIScript): Entrypoint to running the UI script. If the script didn't do anything
 775         asynchronous, call the callback.
 776         (UIScriptContext::nextTaskCallbackID):
 777         (UIScriptContext::prepareForAsyncTask): Do setup for one async task (i.e. a UIScriptController function
 778         that has a callback). Has to store the callbackID of the script, so code called from the completion
 779         callback knows which UI script invoked it.
 780         (UIScriptContext::asyncTaskComplete): Called when one task is finished.
 781         (UIScriptContext::uiScriptComplete):
 782         (UIScriptContext::objectFromRect): Make a JS object from a rect.
 783         * WebKitTestRunner/uiscriptcontext/UIScriptContext.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
 784         (WTR::UIScriptContext::hasOutstandingAsyncTasks):
 785         * WebKitTestRunner/uiscriptcontext/UIScriptController.cpp: Copied from Tools/WebKitTestRunner/TestOptions.h.
 786         (WTR::UIScriptController::UIScriptController):
 787         (WTR::UIScriptController::makeWindowObject):
 788         (WTR::UIScriptController::wrapperClass):
 789         (WTR::UIScriptController::doAsyncTask):
 790         (WTR::UIScriptController::zoomToScale):
 791         (WTR::UIScriptController::zoomScale):
 792         (WTR::UIScriptController::minimumZoomScale):
 793         (WTR::UIScriptController::maximumZoomScale):
 794         (WTR::UIScriptController::contentVisibleRect):
 795         (WTR::UIScriptController::uiScriptComplete):
 796         * WebKitTestRunner/uiscriptcontext/UIScriptController.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
 797         (WTR::UIScriptController::create):
 798         * WebKitTestRunner/uiscriptcontext/bindings/UIScriptController.idl: Copied from Tools/WebKitTestRunner/TestOptions.h.
 799
 800 2015-09-21  Tim Horton  <timothy_horton@apple.com>
 801
 802         Turn on threaded scrolling by default in the tests
 803         https://bugs.webkit.org/show_bug.cgi?id=149377
 804
 805         Reviewed by Simon Fraser.
 806
 807         * WebKitTestRunner/mac/TestControllerMac.mm:
 808         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
 809         (WTR::shouldUseThreadedScrolling): Deleted.
 810         Turn on threaded scrolling by default.
 811
 812 2015-09-21  Carlos Garcia Campos  <cgarcia@igalia.com>
 813
 814         [GTK] run-gtk-tests doesn't provide feedback about crashing google tests
 815         https://bugs.webkit.org/show_bug.cgi?id=149252
 816
 817         Reviewed by Darin Adler.
 818
 819         In case of glib tests the test runner notifies about tests
 820         crashing, but for google tests we don't get any feedback, which
 821         means that in case of a test crashing we get a list of **PASS**
 822         messages and at the summary we are notified that the test suite
 823         has failed, but it's impossible to know which test cases have failed.
 824
 825         * Scripts/run-gtk-tests:
 826         (TestRunner._run_google_test): Add a **CRASH** message if test
 827         case crashed.
 828
 829 2015-09-20  Alexey Proskuryakov  <ap@apple.com>
 830
 831         WebKitTestRunner can leak user content script results between tests
 832         https://bugs.webkit.org/show_bug.cgi?id=149391
 833
 834         Reviewed by Sam Weinig.
 835
 836         Move WKBundlePageRemoveAllUserContent call so that it's executed before loading
 837         about:blank, and thus about:blank doesn't have unintended side effects.
 838
 839         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
 840         (WTR::InjectedBundle::beginTesting):
 841         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
 842         (WTR::InjectedBundlePage::resetAfterTest):
 843
 844 2015-09-20  Alexey Proskuryakov  <ap@apple.com>
 845
 846         [Mac, iOS] AccessibilityController doesn't uninstall global notification handler
 847         https://bugs.webkit.org/show_bug.cgi?id=149384
 848
 849         Reviewed by Chris Fleizach.
 850
 851         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
 852         (AccessibilityController::addNotificationListener): Fixed a leak, and cleaned up the code.
 853         (AccessibilityController::platformResetToConsistentState): Actually remove the handler,
 854         regardless of whether someone else holds a reference (we also call -stopListening in
 855         -dealloc).
 856
 857         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
 858         (AccessibilityController::platformResetToConsistentState):
 859         (AccessibilityController::addNotificationListener):
 860         Ditto.
 861
 862 2015-09-20  Youenn Fablet  <youenn.fablet@crf.canon.fr>
 863
 864         Remove XHR_TIMEOUT compilation guard
 865         https://bugs.webkit.org/show_bug.cgi?id=149260
 866
 867         Reviewed by Benjamin Poulain.
 868
 869         * Scripts/webkitperl/FeatureList.pm:
 870
 871 2015-09-19  Dan Bernstein  <mitz@apple.com>
 872
 873         Attempted build fix.
 874
 875         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
 876
 877 2015-09-18  Commit Queue  <commit-queue@webkit.org>
 878
 879         Unreviewed, rolling out r189908.
 880         https://bugs.webkit.org/show_bug.cgi?id=149368
 881
 882         Broke run-webkit-tests --pixel (Requested by ap on #webkit).
 883
 884         Reverted changeset:
 885
 886         "printing does not use minimum page zoom factor"
 887         https://bugs.webkit.org/show_bug.cgi?id=108507
 888         http://trac.webkit.org/changeset/189908
 889
 890 2015-09-18  Andy Estes  <aestes@apple.com>
 891
 892         [iOS] did{Start,Finish}LoadForQuickLookDocumentInMainFrame is never called on WKNavigationDelegate
 893         https://bugs.webkit.org/show_bug.cgi?id=149360
 894
 895         Reviewed by Tim Horton.
 896
 897         Added an API test.
 898
 899         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 900         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm: Added.
 901         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
 902         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
 903         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]):
 904         (TEST):
 905         * TestWebKitAPI/ios/pages.pages: Added.
 906
 907 2015-09-18  Nan Wang  <n_wang@apple.com>
 908
 909         AX: Implement ARIA 1.1 @aria-current on iOS
 910         https://bugs.webkit.org/show_bug.cgi?id=149297
 911
 912         Reviewed by Chris Fleizach.
 913
 914         Added support to test aria-current on iOS.
 915
 916         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
 917         (AccessibilityUIElement::stringAttributeValue):
 918         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
 919         (WTR::AccessibilityUIElement::stringAttributeValue):
 920
 921 2015-09-18  Alexey Proskuryakov  <ap@apple.com>
 922
 923         iOS WebKitTestRunner frequently crashes in WKContextGetIconDatabase
 924         https://bugs.webkit.org/show_bug.cgi?id=149352
 925
 926         Reviewed by Simon Fraser.
 927
 928         * WebKitTestRunner/TestController.cpp: (WTR::TestController::~TestController):
 929         m_context can be null. This may indicate a bug in webkitpy too, but
 930         WebKitTestRunner should handle this situation nicely, there is nothing intrinsically
 931         wrong with opening and immediately closing it.
 932
 933 2015-09-18  Daniel Bates  <dabates@apple.com>
 934
 935         isGitSVNDirectory() returns true when Git is not installed
 936         https://bugs.webkit.org/show_bug.cgi?id=149351
 937
 938         Reviewed by Alexey Proskuryakov.
 939
 940         Fixes an issue where VCSUtils::isGitSVNDirectory() returns true for any arbitrary directory if
 941         Git is not installed on the machine.
 942
 943         * Scripts/VCSUtils.pm:
 944         (isGitSVNDirectory): Ensure that `git config --get svn-remote.svn.fetch 2>& 1` exits with
 945         status code 0 (success).
 946
 947 2015-09-18  Alex Christensen  <achristensen@webkit.org>
 948
 949         Prevent build-webkit from building four times on Windows
 950         https://bugs.webkit.org/show_bug.cgi?id=149336
 951
 952         Reviewed by Brent Fulgham.
 953
 954         * Scripts/build-webkit:
 955         Move the Windows code out of the for loop iterating over each subdirectory to be build.
 956         They're built all at once.
 957         * Scripts/webkitdirs.pm:
 958         (buildVisualStudioProject):
 959         (cmakeGeneratedBuildfile):
 960         Don't generate the Visual Studio solution if it already exists.
 961         It will run CMake again if necessary.
 962
 963 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
 964
 965         [iOS WK2] WTR fails to set the key window in the UIKit sense
 966         https://bugs.webkit.org/show_bug.cgi?id=149325
 967
 968         Reviewed by Tim Horton.
 969
 970         -[WebKitTestRunnerWindow isKeyWindow] just returned _platformWebView->windowIsKey().
 971         This causes UIKit to bypass code that actually sets the key window, resulting in
 972         [UIAppliation sharedApplication].keyWindow always being nil.
 973
 974         Fix by PlatformWebView::setWindowIsKey() actually call -makeKeyWindow, and having
 975         -[WebKitTestRunnerWindow isKeyWindow] call super.
 976
 977         * WebKitTestRunner/PlatformWebView.h:
 978         (WTR::PlatformWebView::setWindowIsKey): Deleted.
 979         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
 980         (WTR::PlatformWebView::setWindowIsKey):
 981         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
 982         (WTR::PlatformWebView::setWindowIsKey):
 983         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
 984         (-[WebKitTestRunnerWindow isKeyWindow]):
 985         (WTR::PlatformWebView::PlatformWebView):
 986         (WTR::PlatformWebView::~PlatformWebView):
 987         (WTR::PlatformWebView::setWindowIsKey):
 988         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
 989         (WTR::PlatformWebView::setWindowIsKey):
 990
 991 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
 992
 993         [iOS WK2] When loading viewport tests, use the normal web page viewport configuration
 994         https://bugs.webkit.org/show_bug.cgi?id=149321
 995
 996         Reviewed by Tim Horton.
 997
 998         InjectedBundlePage::platformDidStartProvisionalLoadForFrame() unconditionally
 999         enabled the "testing" viewport configuration, which disables page scaling.
1000
1001         If we're running viewport tests, we want the normal web page configuration.
1002         Do that by passing a flag in the dictionary sent to InjectedBundle::beginTesting(),
1003         based on whether the test is in a "viewport" directory.
1004
1005         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1006         (WTR::InjectedBundle::beginTesting):
1007         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
1008         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame): Deleted.
1009         * WebKitTestRunner/TestInvocation.cpp:
1010         (WTR::TestInvocation::shouldLogFrameLoadDelegates):
1011         (WTR::TestInvocation::shouldLogHistoryClientCallbacks):
1012         (WTR::TestInvocation::shouldMakeViewportFlexible):
1013         (WTR::TestInvocation::invoke):
1014         * WebKitTestRunner/TestInvocation.h:
1015         * WebKitTestRunner/ios/TestControllerIOS.mm:
1016         (WTR::TestController::platformConfigureViewForTest):
1017         (WTR::shouldMakeViewportFlexible): Deleted.
1018
1019 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
1020
1021         Give iOS WebKitTestRunner a launch storyboard
1022         https://bugs.webkit.org/show_bug.cgi?id=149314
1023
1024         Reviewed by Dan Bates.
1025
1026         Add a launch storyboard to iOS WebKitTestRunner so that Springboard recognizes
1027         that it's been built for specific device configurations, and puts the window
1028         at the top of the screen. This simplifies coordinate conversions in a future patch.
1029
1030         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1031         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist:
1032         * WebKitTestRunner/ios/Launch.storyboard: Added.
1033
1034 2015-09-17  Myles C. Maxfield  <mmaxfield@apple.com>
1035
1036         Update licence in r189890
1037         https://bugs.webkit.org/show_bug.cgi?id=149306
1038
1039         Reviewed by Dean Jackson.
1040
1041         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
1042         * FontWithFeatures/FontWithFeatures/FontCreator.h:
1043         * FontWithFeatures/FontWithFeatures/main.cpp:
1044
1045 2015-09-17  Mark Lam  <mark.lam@apple.com>
1046
1047         Add the ability to skip JIT stress tests in run-javascriptcore-tests.
1048         https://bugs.webkit.org/show_bug.cgi?id=149285
1049
1050         Reviewed by Saam Barati.
1051
1052         Just need to add an option to pass --no-jit to run-jsc-stress-test.
1053
1054         * Scripts/run-javascriptcore-tests:
1055         (runJSCStressTests):
1056
1057 2015-09-17  Alex Christensen  <achristensen@webkit.org>
1058
1059         Switch AppleWin build to use CMake
1060         https://bugs.webkit.org/show_bug.cgi?id=149163
1061
1062         Reviewed by Brent Fulgham.
1063
1064         * Scripts/build-webkit:
1065         * Scripts/run-api-tests:
1066         (runTest):
1067         (listAllTests):
1068         (prepareEnvironmentForRunningTestTool):
1069         (testToolPaths):
1070         (testToolPath): Deleted.
1071         Run the API tests as separate executables on Windows.
1072         It used to be TestWebKitAPI.exe, and it is now TestWTF.exe, TestWebCore.exe, and TestWebKit.exe.
1073         * Scripts/webkitdirs.pm:
1074         (checkRequiredSystemConfig):
1075         (jhbuildWrapperPrefixIfNeeded):
1076         (generateBuildSystemFromCMakeProject):
1077         Fix configuration quirks.
1078
1079 2015-09-17  Dean Johnson  <dean_johnson@apple.com>
1080
1081         Added toggle options for hiding and showing certain platform families on the dashboard.
1082         https://bugs.webkit.org/show_bug.cgi?id=148403
1083
1084         Reviewed by David Kilzer.
1085
1086         This patch removes "hiddenPlatforms" from use in the code and local storage. We also removed
1087         individual hide/show buttons for platforms because we've added toggle options to hide/show entire
1088         families. Examples of these are "mac", "ios", and "linux". "Show All Platforms" was also removed
1089         in lieu of an "all" button in the toggle menu.
1090
1091         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1092         (parsePlatformFamily): Helper function to parse out a platform family.
1093         (initPlatformsByFamily): Initializes platformsByFamily, which organizes platforms on the
1094         page by platformsByFamily[<family>] = <list of platforms belonging to that family>.
1095         (updateToggleButtons): Updates the status of the toggle buttons.
1096         (updateHiddenPlatforms): Changed to work with the new implementation of hiding/showing platforms.
1097         (documentReady): Added creation of toggle buttons.
1098         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
1099         (unhiddenQueues): Updated to search by platform family instead of the individual platform name.
1100         (documentReady): Changed hiddenPlatforms => hiddenPlatformFamilies.
1101         (updateHiddenPlatforms): Deleted. After removing the individual hide button code,
1102         this did the exact same thing as the updateHiddenPlatforms in Scripts/Main.js so it was removed.
1103         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
1104         (QueueView): Updated to use hiddenPlatformFamilies.
1105         (QueueView.prototype._updateHiddenState): Updated to use hiddenPlatformFamilies.
1106         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
1107         (Settings.prototype.toggleHiddenPlatformFamily): Renamed function and some variables.
1108         (Settings.prototype.clearHiddenPlatformFamilies): Now uses hiddenPlatformFamilies for events.
1109         (Settings.prototype.toggleHiddenPlatform): Deleted.
1110         (Settings.prototype.clearHiddenPlatforms): Deleted.
1111         (Settings.prototype.toggleShowPlatformFamily): Deleted.
1112         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1113         (div.cellButton, div.accessibilityButton, div.platformFamilyToggleButton):
1114         (div.cellButton.unhide, div.accessibilityButton.unhide, div.platformFamilyToggleButton.unhide):
1115         (.settings-visible div.settingsWrapper.hide, .settings-visible div.settingsWrapper):
1116         (table.queue-grid tr.headers th):
1117         (div.settingsWrapper.hide):
1118         (div.settingsWrapper):
1119         (div.familyToggleWrapper):
1120         (div.platformFamilyToggleButton):
1121         (div.platformFamilyShowToggleButton:not(:last-child)):
1122         (div.familyShown):
1123         (div.accessibilityButton):
1124         (div.cellButton, div.accessibilityButton): Added platformFamilyToggleButton class.
1125         (div.cellButton.unhide, div.accessibilityButton.unhide): Added platformFamilyToggleButton class.
1126         (.settings-visible div.accessibilityButton.hide, .settings-visible div.accessibilityButton.unhide): Added
1127         platformFamilyToggleButton and settingsWrapper class.
1128         (.accessibilityButton): Deleted.
1129
1130 2015-09-17  Tim Horton  <timothy_horton@apple.com>
1131
1132         Add a test ensuring that scrolling in the middle of a page can't start a swipe gesture
1133         https://bugs.webkit.org/show_bug.cgi?id=148904
1134
1135         Reviewed by Myles Maxfield.
1136
1137         * WebKitTestRunner/TestController.cpp:
1138         (WTR::parseBooleanTestHeaderValue):
1139         (WTR::updateViewOptionsFromTestHeader):
1140         Check for the key "useThreadedScrolling".
1141         Add some code to check for "true" and "false" for boolean options.
1142
1143         (WTR::TestController::viewOptionsForTest):
1144         Apply the test's overrides last, even after the platform's.
1145
1146 2015-09-16  Carlos Garcia Campos  <cgarcia@igalia.com>
1147
1148         printing does not use minimum page zoom factor
1149         https://bugs.webkit.org/show_bug.cgi?id=108507
1150
1151         Reviewed by Darin Adler.
1152
1153         WebKitTestRunner always takes the snapshots from the UI process
1154         (expect for IOS), so in the case of printing, the layout in the
1155         web view is not the expected one. When printing, we need to take
1156         the snapshot in the web process and ensure it's rendered with a
1157         PrintContext.
1158
1159         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1160         (WTR::InjectedBundlePage::dump): When dumping pixels, pass
1161         kWKSnapshotOptionsPrinting option to
1162         WKBundlePageCreateSnapshotWithOptions() when printing. When not
1163         printing, don't even create the snapshot, since it will be ignored
1164         by the UI process that always creates its own from the WebView (expect for IOS platform)
1165         * WebKitTestRunner/TestInvocation.cpp:
1166         (WTR::TestInvocation::dumpResults): Use always the snapshot image
1167         received from the web process if any when comparing pixel
1168         results. Now we only receive a snapshot from the web process in
1169         case of printing, or when platform is IOS. Otherwhise, generate
1170         the snapshot from the WebView as usual.
1171         * WebKitTestRunner/TestInvocation.h: Add SnapshotResultType enum
1172         parameter to dumpPixelsAndCompareWithExpected, since the snapshot
1173         is created by the caller now, but the CG implementation needs to
1174         know if it's a Web or UI process snapshot.
1175         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
1176         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
1177         cairo surface for the given image.
1178         * WebKitTestRunner/cg/TestInvocationCG.cpp:
1179         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
1180         CGContext for the given image.
1181
1182 2015-09-16  Myles C. Maxfield  <mmaxfield@apple.com>
1183
1184         Create a font which can be used for testing font features
1185         https://bugs.webkit.org/show_bug.cgi?id=149237
1186
1187         Reviewed by Simon Fraser.
1188
1189         This patch adds a new project in the Tools/ directory which generates a font which can
1190         be used for testing font features. This is a standalone project consisting of two files:
1191         1. A file which actually generates the byte vector representing the font. This file has
1192         a single public function: std::vector<uint8_t> generateFont(). This file is not platform
1193         specific, and only relies on the C++ STL.
1194         2. A file with a main() which calls generateFont() and writes out the font, as well as
1195         uses the font to render some demonstration text into a .png file. This file is platform
1196         specific.
1197
1198         The font itself only supports the following characters:
1199         ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz
1200         However, the shape of these letters are either an X or a check mark.
1201
1202         The letter "A" always is a check mark.
1203         The letter "B" always is an X.
1204         Without any font features turned on, the rest of the letters are shown as X.
1205
1206         Each font feature has an letter associated with it. When the font feature is enabled,
1207         that letter is shown as a check mark. For example, when "smcp" is enabled, "J" is shown
1208         as a check mark.
1209
1210         Here are the mappings of font features to letters:
1211         liga: C
1212         clig: D
1213         dlig: E
1214         hlig: F
1215         calt: G
1216         subs: H
1217         sups: I
1218         smcp: J
1219         c2sc: K
1220         pcap: L
1221         c2pc: M
1222         unic: N
1223         titl: O
1224         onum: P
1225         pnum: Q
1226         tnum: R
1227         frac: S
1228         afrc: T
1229         ordn: U
1230         zero: V
1231         hist: W
1232         jp78: X
1233         jp83: Y
1234         jp90: Z
1235         jp04: a
1236         smpl: b
1237         trad: c
1238         fwid: d
1239         pwid: e
1240         ruby: f
1241
1242         * FontWithFeatures/FontWithFeatures.xcodeproj/project.pbxproj: Added.
1243         * FontWithFeatures/FontWithFeatures/FontCreator.cpp: Added.
1244         (integralLog2):
1245         (roundDownToPowerOfTwo):
1246         (isFourByteAligned):
1247         (clampTo):
1248         (append32):
1249         (writeCFFEncodedNumber):
1250         (CFFBuilder::CFFBuilder):
1251         (CFFBuilder::takeResult):
1252         (CFFBuilder::moveTo):
1253         (CFFBuilder::lineTo):
1254         (CFFBuilder::curveToCubic):
1255         (CFFBuilder::closePath):
1256         (CFFBuilder::writePoint):
1257         (generateBoxCharString):
1258         (generateCheckCharString):
1259         (generateXCharString):
1260         (charStringForGlyph):
1261         (Generator::generate):
1262         (Generator::Placeholder::Placeholder):
1263         (Generator::Placeholder::populate):
1264         (Generator::Placeholder::~Placeholder):
1265         (Generator::placeholder):
1266         (Generator::append16):
1267         (Generator::append32):
1268         (Generator::append32BitCode):
1269         (Generator::overwrite16):
1270         (Generator::overwrite32):
1271         (Generator::appendCFFTable):
1272         (Generator::appendSubstitutionSubtable):
1273         (Generator::appendScriptSubtable):
1274         (Generator::appendGSUBTable):
1275         (Generator::appendOS2Table):
1276         (Generator::appendFormat12CMAPTable):
1277         (Generator::appendFormat4CMAPTable):
1278         (Generator::appendCMAPTable):
1279         (Generator::appendHEADTable):
1280         (Generator::appendHHEATable):
1281         (Generator::appendHMTXTable):
1282         (Generator::appendMAXPTable):
1283         (Generator::appendNAMETable):
1284         (Generator::appendPOSTTable):
1285         (Generator::calculateChecksum):
1286         (Generator::appendTable):
1287         (generateFont):
1288         * FontWithFeatures/FontWithFeatures/FontCreator.h: Added.
1289         * FontWithFeatures/FontWithFeatures/main.cpp: Added.
1290         (drawTextWithFeature):
1291         (main):
1292
1293 2015-09-16  Commit Queue  <commit-queue@webkit.org>
1294
1295         Unreviewed, rolling out r189875 and r189878.
1296         https://bugs.webkit.org/show_bug.cgi?id=149235
1297
1298         cygwin cmake build not ready yet (Requested by alexchristensen
1299         on #webkit).
1300
1301         Reverted changesets:
1302
1303         "Switch AppleWin build to use CMake"
1304         https://bugs.webkit.org/show_bug.cgi?id=149163
1305         http://trac.webkit.org/changeset/189875
1306
1307         "Cygwin build fix after r189875"
1308         http://trac.webkit.org/changeset/189878
1309
1310 2015-09-16  Alex Christensen  <achristensen@webkit.org>
1311
1312         Cygwin build fix after r189875
1313
1314         * Scripts/build-webkit:
1315         * Scripts/webkitdirs.pm:
1316         (jhbuildWrapperPrefixIfNeeded):
1317         (generateBuildSystemFromCMakeProject):
1318         Make things work with cygwin and cmake.
1319
1320 2015-09-16  Alex Christensen  <achristensen@webkit.org>
1321
1322         Switch AppleWin build to use CMake
1323         https://bugs.webkit.org/show_bug.cgi?id=149163
1324
1325         Reviewed by Brent Fulgham.
1326
1327         * Scripts/build-webkit:
1328         Build with CMake.
1329         * Scripts/run-api-tests:
1330         (runTest):
1331         (listAllTests):
1332         (prepareEnvironmentForRunningTestTool):
1333         (testToolPaths):
1334         (testToolPath): Deleted.
1335         Run the API tests as separate executables on Windows.
1336         It used to be TestWebKitAPI.exe, and it is now TestWTF.exe, TestWebCore.exe, and TestWebKit.exe.
1337
1338 2015-09-16  Alexey Proskuryakov  <ap@apple.com>
1339
1340         Add newer build.webkit.org pages to robots.txt
1341         https://bugs.webkit.org/show_bug.cgi?id=149219
1342
1343         Reviewed by Darin Adler.
1344
1345         Indexing bot watcher's dashboard can't be good.
1346
1347         * BuildSlaveSupport/build.webkit.org-config/public_html/robots.txt:
1348
1349 2015-09-16  Alex Christensen  <achristensen@webkit.org>
1350
1351         Rollout r189851 and 189853 because they didn’t actually fix the permissions issue
1352
1353         * BuildSlaveSupport/built-product-archive:
1354         (unzipArchive):
1355
1356 2015-09-16  Csaba Osztrogonác  <ossy@webkit.org>
1357
1358         [EFL] Fix the help message of separated web process option of MiniBrowser
1359         https://bugs.webkit.org/show_bug.cgi?id=149212
1360
1361         Reviewed by Gyuyoung Kim.
1362
1363         * MiniBrowser/efl/main.c:
1364
1365 2015-09-16  Alex Christensen  <achristensen@webkit.org>
1366
1367         Fix python syntax after r189851.
1368
1369         * BuildSlaveSupport/built-product-archive:
1370         (unzipArchive):
1371         For loops need a colon.
1372
1373 2015-09-15  Alex Christensen  <achristensen@webkit.org>
1374
1375         Fix Windows test bots after changing to non-cygwin build
1376         https://bugs.webkit.org/show_bug.cgi?id=149196
1377
1378         Reviewed by Daniel Bates.
1379
1380         * BuildSlaveSupport/built-product-archive:
1381         (unzipArchive):
1382         Using different versions of python makes what I think is https://bugs.python.org/issue15795
1383         prevent us from executing files from the archive on the test bots.
1384
1385 2015-09-15  Ryosuke Niwa  <rniwa@webkit.org>
1386
1387         Add ShadowRoot interface and Element.prototype.attachShadow
1388         https://bugs.webkit.org/show_bug.cgi?id=149187
1389
1390         Reviewed by Antti Koivisto.
1391
1392         * Scripts/webkitperl/FeatureList.pm:
1393
1394 2015-09-15  Aakash Jain  <aakash_jain@apple.com>
1395
1396         Appscale queue status json output lacks bots
1397         https://bugs.webkit.org/show_bug.cgi?id=149194
1398         <rdar://problem/22171089>
1399
1400         Reviewed by Alexey Proskuryakov.
1401
1402         * QueueStatusServer/handlers/queuestatusjson.py:
1403         (QueueStatusJSON._bots): Order the results by date so as to get latest events, this was default in AppEngine.
1404         * QueueStatusServer/index.yaml: Index according to appscale requirements.
1405
1406 2015-09-15  Brent Fulgham  <bfulgham@apple.com>
1407
1408         [Win] Provide a means for viewing the layer tree
1409         https://bugs.webkit.org/show_bug.cgi?id=149165
1410
1411         Reviewed by Simon Fraser.
1412
1413         Update MiniBrowser with a new Debug menu option that will
1414         dump the current layer tree to the debug console.
1415
1416         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc:
1417         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h:
1418         * MiniBrowser/win/Common.cpp:
1419         (WndProc): Add handler for 'Print Layer Tree' menu option.
1420         * MiniBrowser/win/MiniBrowser.cpp:
1421         (MiniBrowser::printLayerTree): Added Handler.
1422         * MiniBrowser/win/MiniBrowser.h:
1423
1424 2015-09-14  Myles C. Maxfield  <mmaxfield@apple.com>
1425
1426         WebKitTestRunner declarative language setting is broken for iOS
1427         https://bugs.webkit.org/show_bug.cgi?id=149119
1428
1429         Unreviewed.
1430
1431         In all of the patches on webkit.org/b/189669, my patch to get this working on iOS was
1432         lost in the final version which got committed. This simply implements the existing
1433         OS X behavior on iOS.
1434
1435         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
1436         (WTR::InjectedBundle::platformInitialize):
1437
1438 2015-09-14  Dewei Zhu  <dewei_zhu@apple.com>
1439
1440         Unreviewed, add myself to committers list.
1441
1442         * Scripts/webkitpy/common/config/contributors.json:
1443
1444 2015-09-12  Myles C. Maxfield  <mmaxfield@apple.com>
1445
1446         [Cocoa] Allow testing with the system language
1447         https://bugs.webkit.org/show_bug.cgi?id=148671
1448
1449         Reviewed by Anders Carlsson and Alexey Proskuryakov.
1450
1451         React to tests marked with language=lang1,lang2,etc in their header.
1452         Once this information is parsed, pass it to
1453         WKContextConfigurationSetOverrideLanguages().
1454
1455         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1456         (WTR::InjectedBundle::platformInitialize): Don't clobber the language
1457         list.
1458         * WebKitTestRunner/TestController.cpp:
1459         (WTR::TestController::createWebViewWithOptions): Call
1460         WKContextConfigurationSetOverrideLanguages().
1461         (WTR::updateTestOptionsFromTestHeader): Inspect the language option.
1462         * WebKitTestRunner/TestOptions.h:
1463         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1464         (WTR::PlatformWebView::viewSupportsOptions): Cause a differing language
1465         option to restart the web process.
1466         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1467         (WTR::PlatformWebView::viewSupportsOptions): Ditto.
1468
1469 2015-09-12  Myles C. Maxfield  <mmaxfield@apple.com>
1470
1471         [WKTR] Allow changing the WKContextConfiguration between successive tests
1472         https://bugs.webkit.org/show_bug.cgi?id=148833
1473
1474         Reviewed by Tim Horton.
1475
1476         Previously, we were creating a single WKContext and it lived for the life of the entire test runner.
1477         However, there are certain tests which require specifying options in this object. This patch makes
1478         our existing code for recreating the test runner web view also recreate the WKContext.
1479
1480         As such, our options to the view are now options to the WKContextConfiguration. This patch renames the
1481         class.
1482
1483         * WebKitTestRunner/ContextConfigurationOptions.h: Renamed from Tools/WebKitTestRunner/ViewOptions.h.
1484         * WebKitTestRunner/PlatformWebView.h:
1485         (WTR::PlatformWebView::options):
1486         * WebKitTestRunner/TestController.cpp:
1487         (WTR::TestController::initialize):
1488         (WTR::TestController::generateContextConfiguration):
1489         (WTR::TestController::generatePageConfiguration):
1490         (WTR::TestController::createWebViewWithOptions):
1491         (WTR::TestController::ensureViewSupportsOptionsForTest):
1492         (WTR::updateContextConfigurationOptionsFromTestHeader):
1493         (WTR::TestController::contextConfigurationOptionsForTest):
1494         (WTR::TestController::platformCreateWebView):
1495         (WTR::TestController::platformCreateOtherPage):
1496         (WTR::updateViewOptionsFromTestHeader): Deleted.
1497         (WTR::TestController::viewOptionsForTest): Deleted.
1498         * WebKitTestRunner/TestController.h:
1499         (WTR::TestController::injectedBundlePath):
1500         (WTR::TestController::testPluginDirectory):
1501         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1502         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1503         (WTR::TestController::platformCreateWebView):
1504         (WTR::TestController::platformCreateOtherPage):
1505         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1506         (WTR::PlatformWebView::PlatformWebView):
1507         (WTR::PlatformWebView::viewSupportsOptions):
1508         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1509         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
1510         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
1511         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1512         (WTR::PlatformWebView::PlatformWebView):
1513         (WTR::PlatformWebView::viewSupportsOptions):
1514         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1515         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
1516         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
1517         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1518         (WTR::PlatformWebView::PlatformWebView):
1519         (WTR::PlatformWebView::viewSupportsOptions):
1520         * WebKitTestRunner/ios/TestControllerIOS.mm:
1521         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
1522         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
1523         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1524         (WTR::PlatformWebView::PlatformWebView):
1525         (WTR::PlatformWebView::viewSupportsOptions):
1526         * WebKitTestRunner/mac/TestControllerMac.mm:
1527         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
1528         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
1529
1530 2015-09-11  Michael Saboff  <msaboff@apple.com>
1531
1532         LayoutTestHelper crashes if a color profile isn't set for a 3rd party monitor
1533         https://bugs.webkit.org/show_bug.cgi?id=149083
1534
1535         Reviewed by Alexey Proskuryakov.
1536
1537         Check to make sure that we have a valid factoryProfile CFDictionaryRef before using it.
1538
1539         * DumpRenderTree/mac/LayoutTestHelper.m:
1540         (colorProfileURLForDisplay):
1541
1542 2015-09-11  Saam barati  <sbarati@apple.com>
1543
1544         There should be a defaultSpotCheck-like mode that doesn't run the MaximalFlushInsertionPhase in run-jsc-stress-tests
1545         https://bugs.webkit.org/show_bug.cgi?id=149058
1546
1547         Reviewed by Geoffrey Garen.
1548
1549         * Scripts/run-jsc-stress-tests:
1550
1551 2015-09-10  Commit Queue  <commit-queue@webkit.org>
1552
1553         Unreviewed, rolling out r189595.
1554         https://bugs.webkit.org/show_bug.cgi?id=149052
1555
1556         The tests still fail (Requested by ap on #webkit).
1557
1558         Reverted changeset:
1559
1560         "Spurious output on Windows tests: AQMEIOManager::FindIOUnit:
1561         error -1"
1562         https://bugs.webkit.org/show_bug.cgi?id=142929
1563         http://trac.webkit.org/changeset/189595
1564
1565 2015-09-10  Alexey Proskuryakov  <ap@apple.com>
1566
1567         Spurious output on Windows tests: AQMEIOManager::FindIOUnit: error -1
1568         https://bugs.webkit.org/show_bug.cgi?id=142929
1569
1570         Reviewed by Brent Fulgham.
1571
1572         Silence the logging. We'll track fixing the root cause in Radar.
1573
1574         * Scripts/webkitpy/port/mac.py:
1575         (MacPort.stderr_patterns_to_strip): Added a FIXME.
1576
1577         * Scripts/webkitpy/port/win.py:
1578         (WinPort.logging_patterns_to_strip): Added.
1579
1580 2015-09-09  Andy Estes  <aestes@apple.com>
1581
1582         [iOS] Teach run-webkit-tests how to parse simulator runtimes when version numbers contain a revision
1583         https://bugs.webkit.org/show_bug.cgi?id=149022
1584
1585         Reviewed by Daniel Bates.
1586
1587         Simulator runtime versions can contain a revision number (e.g. 8.4.1), but the regex for matching runtimes
1588         did not account for this.
1589
1590         * Scripts/webkitpy/xcode/simulator.py:
1591         (Simulator): Optionally matched a revision at the end of a runtime version number.
1592         * Scripts/webkitpy/xcode/simulator_unittest.py: Added a test.
1593
1594 2015-09-09  Andy Estes  <aestes@apple.com>
1595
1596         [iOS] Teach run-webkit-tests how to parse `simctl list` when a tvOS SDK is installed
1597         https://bugs.webkit.org/show_bug.cgi?id=149029
1598         <rdar://problem/22432624>
1599
1600         Reviewed by Daniel Bates.
1601
1602         * Scripts/webkitpy/xcode/simulator.py:
1603         (Simulator): Taught to parse tvOS runtimes.
1604         * Scripts/webkitpy/xcode/simulator_unittest.py: Added tests.
1605
1606 2015-09-09  Alexey Proskuryakov  <ap@apple.com>
1607
1608         Fix bit rot on bot watcher's dashboard page
1609         https://bugs.webkit.org/show_bug.cgi?id=149012
1610
1611         Reviewed by Tim Horton.
1612
1613         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1614         The code path used by the metrics page was trying to add properties to an undefined.
1615
1616         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
1617         Silence an expection that would occur when the step has no logs. This should never
1618         happen, but it did (perhaps buildbot was misconfigured for a while).
1619
1620 2015-09-09  Alexey Proskuryakov  <ap@apple.com>
1621
1622         Update LayoutTestRelay xcconfig file.
1623
1624         Rubber-stamped by Dan Bernstein.
1625
1626         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
1627
1628 2015-09-09  Saam barati  <sbarati@apple.com>
1629
1630         DFG should have a debugging option that runs a phase that flushes all locals
1631         https://bugs.webkit.org/show_bug.cgi?id=148916
1632
1633         Reviewed by Filip Pizlo.
1634
1635         * Scripts/run-jsc-stress-tests:
1636
1637 2015-09-09  Commit Queue  <commit-queue@webkit.org>
1638
1639         Unreviewed, rolling out r189530 and r189534.
1640         https://bugs.webkit.org/show_bug.cgi?id=148996
1641
1642         Caused assertion failures on Yosemite (Requested by litherum
1643         on #webkit).
1644
1645         Reverted changesets:
1646
1647         "[WKTR] Allow changing the WKContextConfiguration between
1648         successive tests"
1649         https://bugs.webkit.org/show_bug.cgi?id=148833
1650         http://trac.webkit.org/changeset/189530
1651
1652         "[Cocoa] Fix the tests after r189530"
1653         http://trac.webkit.org/changeset/189534
1654
1655 2015-09-08  Myles C. Maxfield  <mmaxfield@apple.com>
1656
1657         [Cocoa] Fix the tests after r189530
1658
1659         Unreviewed.
1660
1661         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1662         (WTR::initializeWebViewConfiguration):
1663
1664 2015-09-08  Myles C. Maxfield  <mmaxfield@apple.com>
1665
1666         [WKTR] Allow changing the WKContextConfiguration between successive tests
1667         https://bugs.webkit.org/show_bug.cgi?id=148833
1668
1669         Reviewed by Tim Horton.
1670
1671         Previously, we were creating a single WKContext and it lived for the life of the entire test runner.
1672         However, there are certain tests which require specifying options in this object. This patch makes
1673         our existing code for recreating the test runner web view also recreate the WKContext.
1674
1675         As such, our options to the view are now options to the WKContextConfiguration. This patch renames the
1676         class.
1677
1678         * WebKitTestRunner/ContextConfigurationOptions.h: Renamed from Tools/WebKitTestRunner/ViewOptions.h.
1679         * WebKitTestRunner/PlatformWebView.h:
1680         (WTR::PlatformWebView::options):
1681         * WebKitTestRunner/TestController.cpp:
1682         (WTR::TestController::initialize):
1683         (WTR::TestController::generateContextConfiguration):
1684         (WTR::TestController::generatePageConfiguration):
1685         (WTR::TestController::createWebViewWithOptions):
1686         (WTR::TestController::ensureViewSupportsOptionsForTest):
1687         (WTR::updateContextConfigurationOptionsFromTestHeader):
1688         (WTR::TestController::contextConfigurationOptionsForTest):
1689         (WTR::TestController::platformCreateWebView):
1690         (WTR::TestController::platformCreateOtherPage):
1691         (WTR::updateViewOptionsFromTestHeader): Deleted.
1692         (WTR::TestController::viewOptionsForTest): Deleted.
1693         * WebKitTestRunner/TestController.h:
1694         (WTR::TestController::injectedBundlePath):
1695         (WTR::TestController::testPluginDirectory):
1696         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1697         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1698         (WTR::TestController::platformCreateWebView):
1699         (WTR::TestController::platformCreateOtherPage):
1700         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1701         (WTR::PlatformWebView::PlatformWebView):
1702         (WTR::PlatformWebView::viewSupportsOptions):
1703         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1704         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
1705         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
1706         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1707         (WTR::PlatformWebView::PlatformWebView):
1708         (WTR::PlatformWebView::viewSupportsOptions):
1709         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1710         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
1711         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
1712         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1713         (WTR::PlatformWebView::PlatformWebView):
1714         (WTR::PlatformWebView::viewSupportsOptions):
1715         * WebKitTestRunner/ios/TestControllerIOS.mm:
1716         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
1717         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
1718         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1719         (WTR::PlatformWebView::PlatformWebView):
1720         (WTR::PlatformWebView::viewSupportsOptions):
1721         * WebKitTestRunner/mac/TestControllerMac.mm:
1722         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
1723         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
1724
1725 2015-09-08  Daniel Bates  <dabates@apple.com>
1726
1727         [Mac] Expose Enable/Disable Accelerated Drawing in MiniBrowser
1728         https://bugs.webkit.org/show_bug.cgi?id=148980
1729
1730         Reviewed by Alexey Proskuryakov.
1731
1732         Add setting to enable/disable accelerated drawing so as to support testing
1733         this feature in MiniBrowser on Mac.
1734
1735         * MiniBrowser/mac/SettingsController.h:
1736         * MiniBrowser/mac/SettingsController.m:
1737         (-[SettingsController _populateMenu]): Add menu item.
1738         (-[SettingsController validateMenuItem:]): Update setting when menu item is toggled.
1739         (-[SettingsController toggleAcceleratedDrawingEnabled:]): Added.
1740         (-[SettingsController acceleratedDrawingEnabled]): Added.
1741         * MiniBrowser/mac/WK1BrowserWindowController.m:
1742         (-[WK1BrowserWindowController didChangeSettings]): Apply setting in WebKit1.
1743         * MiniBrowser/mac/WK2BrowserWindowController.m:
1744         (-[WK2BrowserWindowController didChangeSettings]): Apply setting in WebKit2.
1745
1746 2015-09-08  Jason Marcell  <jmarcell@apple.com>
1747
1748         Unreviewed. Added myself as a commiter in contributors.json.
1749
1750         * Scripts/webkitpy/common/config/contributors.json:
1751
1752 2015-09-08  Keith Miller  <keith_miller@apple.com>
1753
1754         Unreviewed, added myself to the list of contributors.
1755
1756         * Scripts/webkitpy/common/config/contributors.json:
1757
1758 2015-09-08  Daniel Bates  <dabates@apple.com>
1759
1760         Dashboard: Remove use of z-index for ring overlay; use DOM ordering
1761         https://bugs.webkit.org/show_bug.cgi?id=148921
1762
1763         Reviewed by Alexey Proskuryakov.
1764
1765         The ring image is positioned above the platform icon in markup and we specify the CSS
1766         property z-index for the ring image so that it is painted on top of the platform icon
1767         instead of below it (by DOM ordering). Instead we can take advantage of the transparency
1768         of the ring image, switch the order of these DOM elements and remove the use of the CSS
1769         property z-index to achieve a similar effect.
1770
1771         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1772         (documentReady): Create the platform icon image element before the ring image such that
1773         the ring image is painted on top of the platform icon.
1774         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1775         (table.queue-grid td.logo img.ring): Removed property z-index.
1776
1777 2015-09-08  Daniel Bates  <dabates@apple.com>
1778
1779         Dashboard: Remove duplicate gear icon data URLs
1780         https://bugs.webkit.org/show_bug.cgi?id=148920
1781
1782         Reviewed by Alexey Proskuryakov.
1783
1784         Currently we duplicate the SVG data URL for the gear icon up to its fill color in the CSS property
1785         background-image associated with each of the three gear icon states: collapsed (.settings), hover
1786         (.settings:hover), and expanded (.settings-visible .settings). Instead we should use the gear icon
1787         as a mask and make use of the CSS background-color to define the fill color for each of these three
1788         states.
1789
1790         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1791         (.settings): Use gear icon as mask and define CSS background-color for collapsed state.
1792         (.settings:hover): Override CSS background-color for hover state.
1793         (.settings-visible .settings): Override CSS background-color for expanded state.
1794
1795 2015-09-07  Andy Estes  <aestes@apple.com>
1796
1797         [Mac] DebugRelease builds should link against libWebKitSystemInterfaceElCapitan.a on 10.11
1798         https://bugs.webkit.org/show_bug.cgi?id=148946
1799         <rdar://problem/22603981>
1800
1801         Reviewed by Dan Bernstein.
1802
1803         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1804         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1805
1806 2015-09-07  Hunseop Jeong  <hs85.jeong@samsung.com>
1807
1808         [EFL] Many of the css3/device-adapt/* tests failed after r188548.
1809         https://bugs.webkit.org/show_bug.cgi?id=148927
1810
1811         Reviewed by Csaba Osztrogonác.
1812
1813         device-adapt/* tests need the fixedLayout option but useFixedLayout option is
1814         overwritten by updatePlatformSpecificViewOptionsForTest after r188548.
1815
1816         * WebKitTestRunner/TestController.cpp:
1817         (WTR::shouldUseFixedLayout): Removed the unnecessary indentations.
1818         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1819         (WTR::shouldUseFixedLayout): Return true if the test is related with 'device-adapt'.
1820
1821 2015-09-07  Andy Estes  <aestes@apple.com>
1822
1823         Fix the Production build after r189455.
1824
1825         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Somehow I added the All target using the
1826         In-App Purchase template instead of the Aggregate template. Whoops.
1827
1828 2015-09-06  Andy Estes  <aestes@apple.com>
1829
1830         WebKit.xcworkspace should be be able to build iOS platforms
1831         https://bugs.webkit.org/show_bug.cgi?id=148881
1832
1833         Reviewed by Daniel Bates.
1834
1835         Since we don't want to create platform-specific schemes, all projects in the workspace's schemes need to build
1836         for all supported platforms.
1837
1838         * MiniBrowser/Configurations/Base.xcconfig: Included iphoneos and iphonesimulator in SUPPORTED_PLATFORMS.
1839         * MiniBrowser/Configurations/MiniBrowser.xcconfig: Excluded all source files on iOS, and linked Cocoa and WebKit on Mac.
1840         * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig: Ditto.
1841         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Stopped linking frameworks in Link Binaries With Libraries.
1842
1843 2015-09-06  Andy Estes  <aestes@apple.com>
1844
1845         WebKitTestRunner should build for iOS using the default target
1846         https://bugs.webkit.org/show_bug.cgi?id=148918
1847
1848         Reviewed by Daniel Bates.
1849
1850         When WebKitTestRunner was ported to iOS, a separate target (WebKitTestRunnerApp) was created for building the
1851         iOS variant. This is annoying because (1) all tools that invoke xcodebuild need to be taught to build this
1852         non-default target, and (2) a single Xcode scheme cannot be used to build both Mac and iOS variants.
1853
1854         This change adds a new default target (All) and makes it work for both Mac and iOS. Files that were built for
1855         both WebKitTestRunner and WebKitTestRunnerApp are now built in a static library target (WebKitTestRunner (Library)),
1856         and both apps now link this library. Files that are specific to Mac or iOS are excluded on the other platform.
1857         WebKitTestRunnerApp.app (which should be renamed to WebKitTestRunner.app) is skipped when installing on Mac, and
1858         WebKitTestRunner is skipped when installing on iOS.
1859
1860         The target dependency graph now looks like this:
1861
1862             All
1863                 WebKitTestRunnerApp
1864                     WebKitTestRunner (Library)
1865                         WebKitTestRunnerInjectedBundle
1866                             Derived Sources
1867                 WebKitTestRunner
1868                     WebKitTestRunner (Library)
1869                         WebKitTestRunnerInjectedBundle
1870                             Derived Sources
1871
1872         * Scripts/build-webkit: Stopped building the WebKitTestRunnerApp target on iOS.
1873         * Scripts/build-webkittestrunner: Ditto.
1874         * WebKitTestRunner/Configurations/Base.xcconfig: Set SUPPORTED_PLATFORMS to macosx, iphoneos, and iphonesimulator.
1875         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Set INSTALL_PATH here since it is the same for all targets.
1876         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Stopped setting INSTALL_PATH.
1877         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Moved frameworks from the build phase to here,
1878         excluded iOS-only files, and skipped installing on iOS.
1879         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Moved frameworks from the build phase to here,
1880         excluded Mac-only files, and skipped installing on Mac.
1881         * WebKitTestRunner/Configurations/WebKitTestRunnerLibrary.xcconfig: Skipped installing always.
1882         * WebKitTestRunner/Makefile: Stopped building the WebKitTestRunnerApp target on iOS.
1883         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added new targets, removed frameworks from
1884         Link Binary With Libraries builds phases, moved common files to the WebKitTestRunner (Library) target, and added
1885         new configuration files.
1886
1887 2015-09-05  Joseph Pecoraro  <pecoraro@apple.com>
1888
1889         Web Inspector: Improve prepare-ChangeLog for multiple cases
1890         https://bugs.webkit.org/show_bug.cgi?id=148875
1891
1892         Reviewed by Timothy Hatcher.
1893
1894         * Scripts/prepare-ChangeLog:
1895         (get_function_line_ranges_for_javascript):
1896         - We were ignoring everything inside of an anonymous function expression,
1897           such as (function(){ ... }), which made InjectedScriptSource produce nothing.
1898           Better handle this by inserting a few tweaks.
1899         - Allow method syntax outside of classes as long as they are at the global level.
1900         - Avoid treating "get" and "set" as getter/setter functions in bad contexts.
1901
1902         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt:
1903         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests.js:
1904         (Foo.prototype.method1):
1905         (Foo.prototype.method2):
1906         (Foo.prototype.method3.innerFunction):
1907         (Foo.prototype.method3):
1908         (insideGlobalAnonymousFunctionExpression):
1909         (foo.insideGlobalFunctionExpression):
1910         (IssueWithMapGetAndSet.prototype.method1.nestedFunctionInsideMethod1):
1911         (IssueWithMapGetAndSet.prototype.method1):
1912         (IssueWithMapGetAndSet.prototype.method2):
1913         (IssueWithMapGetAndSet.prototype.method3):
1914         (IssueWithMapGetAndSet):
1915
1916 2015-09-05  Yusuke Suzuki  <utatane.tea@gmail.com>
1917
1918         [ES6] Enable ES6 Module in JSC shell by default
1919         https://bugs.webkit.org/show_bug.cgi?id=148689
1920
1921         Reviewed by Geoffrey Garen.
1922
1923         * Scripts/run-javascriptcore-tests:
1924         (runJSCStressTests):
1925         * Scripts/run-jsc-stress-tests:
1926
1927 2015-09-04  Basile Clement  <basile_clement@apple.com>
1928
1929         Unreviewed, change my email address.
1930
1931         * Scripts/webkitpy/common/config/contributors.json:
1932
1933 2015-09-04  Beth Dakin  <bdakin@apple.com>
1934
1935         Should have a test to make sure links don't navigate after a cancelled force
1936         click
1937         https://bugs.webkit.org/show_bug.cgi?id=148846
1938
1939         Reviewed by Tim Horton.
1940
1941         New EventSender function for a started then cancelled force click.
1942         * WebKitTestRunner/EventSenderProxy.h:
1943         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
1944         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1945         (WTR::EventSendingController::mouseForceClick):
1946         (WTR::EventSendingController::startAndCancelMouseForceClick):
1947         (WTR::EventSendingController::mouseForceDown):
1948         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1949         * WebKitTestRunner/TestController.cpp:
1950         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
1951         * WebKitTestRunner/mac/EventSenderProxy.mm:
1952         (WTR::EventSenderProxy::mouseForceClick):
1953         (WTR::EventSenderProxy::startAndCancelMouseForceClick):
1954         (WTR::EventSenderProxy::mouseForceDown):
1955         (WTR::EventSenderProxy::mouseMoveTo):
1956
1957 2015-09-04  Tim Horton  <timothy_horton@apple.com>
1958
1959         Add a test for r179736 (programmatic navigation during swipe causing a crash)
1960         https://bugs.webkit.org/show_bug.cgi?id=148830
1961
1962         Reviewed by Beth Dakin.
1963
1964         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1965         (WTR::InjectedBundle::beginTesting):
1966         Make sure that TestRunner callbacks don't leak between tests!
1967
1968 2015-09-04  Anders Carlsson  <andersca@apple.com>
1969
1970         It should be possible to pass relative HTTP test paths to DumpRenderTree
1971         https://bugs.webkit.org/show_bug.cgi?id=148825
1972         <rdar://problem/22583866>
1973
1974         Reviewed by Tim Horton.
1975
1976         Convert the path to an absolute path if needed.
1977
1978         * DumpRenderTree/mac/DumpRenderTree.mm:
1979         (computeTestURL):
1980
1981 2015-09-04  Jason Marcell  <jmarcell@apple.com>
1982
1983         Fix Swift unit tests for prepare-ChangeLog.
1984         https://bugs.webkit.org/show_bug.cgi?id=148817
1985
1986         Reviewed by Alexey Proskuryakov.
1987
1988         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/swift_unittests-expected.txt: Fixed
1989         Swift unit tests for prepare-ChangeLog.
1990
1991 2015-09-04  Lucas Forschler  <lforschler@apple.com>
1992
1993         Modifications to the webkit-nightly logic.
1994
1995         * WebKitLauncher/WebKitNightlyEnablerSparkle.m:
1996         (updateAlertPanel):
1997         * WebKitLauncher/main.m:
1998         (displayErrorAndQuit):
1999
2000 2015-09-04  Beth Dakin  <bdakin@apple.com>
2001
2002         Speculative build fix.
2003
2004         * WebKitTestRunner/mac/EventSenderProxy.mm:
2005
2006 2015-09-04  Brian Burg  <bburg@apple.com>
2007
2008         Web Inspector: InspectorController should support multiple frontend channels
2009         https://bugs.webkit.org/show_bug.cgi?id=148538
2010
2011         Reviewed by Joseph Pecoraro.
2012
2013         InspectorClients must explicitly disconnect their frontend channel(s) from the
2014         inspected page's InspectorController.
2015
2016         To make this possible, DumpRenderTree should not destroy non-primary views until
2017         it has tried to close any abandoned Web Inspector instances. Performing teardown
2018         in the reverse order prevents disconnection of the frontend channel because that
2019         prematurely destroys the inspector frontend client.
2020
2021         * DumpRenderTree/mac/DumpRenderTree.mm:
2022         (runTest):
2023         * DumpRenderTree/win/DumpRenderTree.cpp:
2024         (runTest):
2025
2026 2015-09-04  Beth Dakin  <bdakin@apple.com>
2027
2028         Need to be able to test default behaviors on force click
2029         https://bugs.webkit.org/show_bug.cgi?id=148758
2030
2031         Reviewed by Tim Horton.
2032
2033         This patch adds a new eventSender method to do a full, completed force click,
2034         and it re-works all of the existing force methods to dispatch their events in
2035         such a way that they will trigger the NSImmediateAction gesture recognizer.
2036         To do this, first we need to send the events to the app rather than straight
2037         to the view, and also needed to tweak some state and send the events in a
2038         delayed fashion.
2039
2040         New public function mouseForceClick() and private helper functions to make
2041         NSEvents.
2042         * WebKitTestRunner/EventSenderProxy.h:
2043
2044         New public function mouseForceClick().
2045         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2046         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2047         (WTR::EventSendingController::mouseMoveTo):
2048         (WTR::EventSendingController::mouseForceClick):
2049         (WTR::EventSendingController::mouseForceDown):
2050         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2051         * WebKitTestRunner/TestController.cpp:
2052         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2053
2054         initPressureEventAtLocation needs to take a stageTransition and a window.
2055         * WebKitTestRunner/mac/EventSenderProxy.mm:
2056         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
2057         (-[EventSenderSyntheticEvent stageTransition]):
2058         (-[EventSenderSyntheticEvent timestamp]):
2059         (-[EventSenderSyntheticEvent _cgsEventRecord]):
2060         (-[EventSenderSyntheticEvent window]):
2061
2062         In order to enter the gesture recognizer, we need to start with a mouse down
2063         that has a NSEventMaskPressure modifier.
2064         (WTR::EventSenderProxy::sendMouseDownToStartPressureEvents):
2065
2066         This ensures that the events queue properly for the force monitor in AppKit.
2067         (WTR::spinRunLoopForForce):
2068
2069          We need to start the pressure change events with a began.
2070         (WTR::EventSenderProxy::beginPressureEvent):
2071
2072         These functions can be used to create the NSEvent for a pressure change every
2073         time we need one.
2074         (WTR::EventSenderProxy::pressureChangeEvent):
2075
2076         Send the right series of events to emulate a full, completed force click.
2077         (WTR::EventSenderProxy::mouseForceClick):
2078
2079         Use all of the new things for these existing functions.
2080         (WTR::EventSenderProxy::mouseForceDown):
2081         (WTR::EventSenderProxy::mouseForceUp):
2082         (WTR::EventSenderProxy::mouseForceChanged):
2083
2084         Set NSFakeForceTouchDevice to YES.
2085         * WebKitTestRunner/mac/main.mm:
2086         (setDefaultsToConsistentValuesForTesting):
2087
2088 2015-09-04  Jason Marcell  <jmarcell@apple.com>
2089
2090         prepare-ChangeLog needs to know how to parse Swift files.
2091         https://bugs.webkit.org/show_bug.cgi?id=148784
2092         <rdar://problem/22510062>
2093
2094         Reviewed by Darin Adler.
2095
2096         * Scripts/prepare-ChangeLog:
2097         (get_function_line_ranges): Added entry for get_function_line_ranges_for_swift.
2098         (get_function_line_ranges_for_swift): Added function that knows how to parse Swift code.
2099         (parseSwiftFunctionArgs): Added function that knows how to parse Swift function arguments.
2100         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl: Added.
2101         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/swift_unittests-expected.txt: Ditto.
2102         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/swift_unittests.swift: Ditto.
2103         (freeFunction): Ditto.
2104         (MyClass.function): Ditto.
2105         (MyClass.functionWithArgument(_:)): Ditto.
2106         (MyClass.functionWithMoreArguments(_:arg2:)): Ditto.
2107         (MyClass.functionWithNamedFirstArgument(argument:)): Ditto.
2108         (MyClass.functionWithNamedFirstAndSecondArgument(first:second:)): Ditto.
2109         (MyClass.classFunction): Ditto.
2110         (MyClass.readWriteComputedVariable): Ditto.
2111         (MyClass.readOnlyComputedVariable): Ditto.
2112
2113 2015-09-04  Ryosuke Niwa  <rniwa@webkit.org>
2114
2115         Import css/css-color-3
2116         https://bugs.webkit.org/show_bug.cgi?id=148803
2117
2118         Reviewed by Chris Dumez.
2119
2120         Fixed a bug that the imported reference files used the same extention as tests.
2121         This would result in parsing errors if the tests were XML and references were HTML and vice versa.
2122
2123         * Scripts/webkitpy/w3c/test_importer.py:
2124         (TestImporter.find_importable_tests):
2125
2126 2015-09-03  Commit Queue  <commit-queue@webkit.org>
2127
2128         Unreviewed, rolling out r189338.
2129         https://bugs.webkit.org/show_bug.cgi?id=148785
2130
2131         Caused tons of crashes (Requested by cdumez on #webkit).
2132
2133         Reverted changeset:
2134
2135         "Web Inspector: InspectorController should support multiple
2136         frontend channels"
2137         https://bugs.webkit.org/show_bug.cgi?id=148538
2138         http://trac.webkit.org/changeset/189338
2139
2140 2015-09-03  Brian Burg  <bburg@apple.com>
2141
2142         Web Inspector: InspectorController should support multiple frontend channels
2143         https://bugs.webkit.org/show_bug.cgi?id=148538
2144
2145         Reviewed by Joseph Pecoraro.
2146
2147         InspectorClients must explicitly disconnect their frontend channel(s) from the
2148         inspected page's InspectorController.
2149
2150         To make this possible, DumpRenderTree should not destroy non-primary views until
2151         it has tried to close any abandoned Web Inspector instances. Performing teardown
2152         in the reverse order prevents disconnection of the frontend channel because that
2153         prematurely destroys the inspector frontend client.
2154
2155         * DumpRenderTree/mac/DumpRenderTree.mm:
2156         (runTest):
2157         * DumpRenderTree/win/DumpRenderTree.cpp:
2158         (runTest):
2159
2160 2015-09-03  Timothy Hatcher  <timothy@apple.com>
2161
2162         Update WebKit nightly icon to be more like Safari
2163         https://bugs.webkit.org/show_bug.cgi?id=148768
2164
2165         Reviewed by Joseph Pecoraro.
2166
2167         * WebKitLauncher/webkit.icns:
2168
2169 2015-09-03  Geoffrey Garen  <ggaren@apple.com>
2170
2171         JavaScriptCore should have some ES6 conformance tests
2172         https://bugs.webkit.org/show_bug.cgi?id=148771
2173
2174         Reviewed by Chris Dumez.
2175
2176         * Scripts/run-javascriptcore-tests:
2177         (runJSCStressTests): Added es6 as a test suite.
2178
2179         * Scripts/run-jsc-stress-tests: Added es6 as a test suite.
2180
2181         Some of these tests currently fail, so I also added a way to expect
2182         failure for now. We'll migrate failing tests to expected passes as we
2183         fix them.
2184
2185 2015-09-03  Tim Horton  <timothy_horton@apple.com>
2186
2187         Add a test for swipe-start hysteresis
2188         https://bugs.webkit.org/show_bug.cgi?id=148756
2189
2190         Reviewed by Anders Carlsson.
2191
2192         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2193         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2194         (WTR::cacheTestRunnerCallback):
2195         (WTR::TestRunner::clearTestRunnerCallbacks):
2196         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2197         Make sure that we log if a client tries to install a callback twice
2198         (since we use .add, the second call would not work).
2199
2200         Also, add clearTestRunnerCallbacks so tests can swap out installed
2201         callbacks.
2202
2203 2015-09-03  Anders Carlsson  <andersca@apple.com>
2204
2205         DumpRenderTree should automatically compute HTTP URLs for HTTP tests
2206         https://bugs.webkit.org/show_bug.cgi?id=148746
2207         rdar://problem/22568073
2208
2209         Reviewed by Tim Horton.
2210
2211         * DumpRenderTree/mac/DumpRenderTree.mm:
2212         (computeTestURL):
2213         Compute the test URL from the passed in path or URL. Special-case paths that contain /LayoutTests/http/tests.
2214
2215         (runTest):
2216         Call computeTestURL.
2217
2218         (testPathFromURL):
2219         Get rid of this; computeTestURL does this for us now.
2220
2221         * Scripts/webkitpy/port/driver.py:
2222         (Driver._command_from_driver_input):
2223         Don't convert HTTP test paths to URLS before passing them to DumpRenderTree on Mac. That's handled by DRT itself now.
2224
2225 2015-09-03  Tim Horton  <timothy_horton@apple.com>
2226
2227         Swipe tests fail on Mavericks
2228         https://bugs.webkit.org/show_bug.cgi?id=148752
2229
2230         Reviewed by Beth Dakin.
2231
2232         * WebKitTestRunner/mac/EventSenderProxy.mm:
2233
2234 2015-09-03  Tim Horton  <timothy_horton@apple.com>
2235
2236         Fix the 32-bit build
2237
2238         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2239         (WTR::PlatformWebView::setNavigationGesturesEnabled):
2240
2241 2015-09-03  Tim Horton  <timothy_horton@apple.com>
2242
2243         Remove some logging that wasn't meant to be in the tree
2244
2245         * WebKitTestRunner/mac/EventSenderProxy.mm:
2246         (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
2247
2248 2015-09-03  Tim Horton  <timothy_horton@apple.com>
2249
2250         [Mac] Add support for testing swipes
2251         https://bugs.webkit.org/show_bug.cgi?id=148700
2252
2253         Reviewed by Beth Dakin.
2254
2255         * WebKitTestRunner/EventSenderProxy.h:
2256         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2257         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2258         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2259         (WTR::cgEventPhaseFromString):
2260         (WTR::cgEventMomentumPhaseFromString):
2261         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
2262         (WTR::EventSendingController::swipeGestureWithWheelAndMomentumPhases):
2263         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2264         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2265         (WTR::InjectedBundle::didReceiveMessageToPage):
2266         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2267         (WTR::TestRunner::installDidBeginSwipeCallback):
2268         (WTR::TestRunner::installWillEndSwipeCallback):
2269         (WTR::TestRunner::installDidEndSwipeCallback):
2270         (WTR::TestRunner::installDidRemoveSwipeSnapshotCallback):
2271         (WTR::TestRunner::callDidBeginSwipeCallback):
2272         (WTR::TestRunner::callWillEndSwipeCallback):
2273         (WTR::TestRunner::callDidEndSwipeCallback):
2274         (WTR::TestRunner::callDidRemoveSwipeSnapshotCallback):
2275         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2276         * WebKitTestRunner/TestController.cpp:
2277         (WTR::TestController::createOtherPage):
2278         (WTR::TestController::createWebViewWithOptions):
2279         (WTR::TestController::didReceiveMessageFromInjectedBundle):
2280         (WTR::TestController::didBeginNavigationGesture):
2281         (WTR::TestController::willEndNavigationGesture):
2282         (WTR::TestController::didEndNavigationGesture):
2283         (WTR::TestController::didRemoveNavigationGestureSnapshot):
2284         * WebKitTestRunner/TestController.h:
2285         * WebKitTestRunner/TestInvocation.cpp:
2286         (WTR::TestInvocation::didBeginSwipe):
2287         (WTR::TestInvocation::willEndSwipe):
2288         (WTR::TestInvocation::didEndSwipe):
2289         (WTR::TestInvocation::didRemoveSwipeSnapshot):
2290         * WebKitTestRunner/TestInvocation.h:
2291         Add callbacks when navigation gestures didBegin/willEnd/didEnd, and
2292         when the snapshot is removed.
2293
2294         Add swipeGestureWithWheelAndMomentumPhases, just like the equivalent
2295         mouseScrollBy function.
2296
2297         * WebKitTestRunner/mac/EventSenderProxy.mm:
2298         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:phase:time:eventNumber:]):
2299         (-[EventSenderSyntheticEvent type]):
2300         (-[EventSenderSyntheticEvent subtype]):
2301         (-[EventSenderSyntheticEvent locationInWindow]):
2302         (-[EventSenderSyntheticEvent location]):
2303         (-[EventSenderSyntheticEvent momentumPhase]):
2304         (-[EventSenderSyntheticEvent _isTouchesEnded]):
2305         (-[EventSenderSyntheticEvent _cgsEventRecord]):
2306         Rename EventSenderPressureEvent to EventSenderSyntheticEvent and add some
2307         more adjustable values.
2308
2309         (WTR::EventSenderProxy::mouseForceDown):
2310         (WTR::EventSenderProxy::mouseForceUp):
2311         (WTR::EventSenderProxy::mouseForceChanged):
2312         Adopt EventSenderSyntheticEvent.
2313
2314         (WTR::nsEventPhaseFromCGEventPhase):
2315         (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
2316         Make use of EventSenderSyntheticEvent to synthesize swipe gesture events.
2317
2318         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2319         (WTR::PlatformWebView::PlatformWebView):
2320         Enable swipe.
2321
2322 2015-09-03  Myles C. Maxfield  <mmaxfield@apple.com>
2323
2324         [WK2] Allow tagging tests with metadata which needs to be known at web process creation time
2325         https://bugs.webkit.org/show_bug.cgi?id=148723
2326
2327         Reviewed by Anders Carlsson.
2328
2329         * WebKitTestRunner/TestController.cpp:
2330         (WTR::testPath):
2331         (WTR::updateViewOptionsFromTestHeader):
2332         (WTR::TestController::viewOptionsForTest):
2333
2334 2015-09-03  Lucas Forschler  <lforschler@apple.com>
2335
2336         Test commit.
2337
2338 2015-09-02  Tim Horton  <timothy_horton@apple.com>
2339
2340         Add a modern API way to know that the navigation gesture snapshot was removed, for WebKitTestRunner
2341         https://bugs.webkit.org/show_bug.cgi?id=148693
2342
2343         Reviewed by Anders Carlsson.
2344
2345         * WebKitTestRunner/TestController.cpp:
2346         (WTR::TestController::createOtherPage):
2347         (WTR::TestController::createWebViewWithOptions):
2348
2349 2015-09-02  Carlos Garcia Campos  <cgarcia@igalia.com>
2350
2351         REGRESSION(r188548): Some tests crash after r188548 because injected bundle messages are received after the test finishes
2352         https://bugs.webkit.org/show_bug.cgi?id=148529
2353
2354         Reviewed by Darin Adler.
2355
2356         When there are pending EventSender messages after a test finishes,
2357         they could be processed in the main loop started by the
2358         resetStateToConsistentValues(), but the old EventSender has been
2359         replaced by a new one at that point. The new Eventsender can crash
2360         when processing messages that were sent to the old one. To avoid
2361         this, we return early when receiving an EventSender message and
2362         the TestController state is not RunningTest.
2363
2364         * WebKitTestRunner/TestController.cpp:
2365         (WTR::TestController::didReceiveKeyDownMessageFromInjectedBundle):
2366         (WTR::TestController::didReceiveMessageFromInjectedBundle):
2367
2368 2015-09-02  Carlos Garcia Campos  <cgarcia@igalia.com>
2369
2370         REGRESSION(r188548): TestController state is Resseting while tests are running after r188548
2371         https://bugs.webkit.org/show_bug.cgi?id=148528
2372
2373         Reviewed by Darin Adler.
2374
2375         Before r188548 resetStateToConsistentValues() was called in
2376         TestController::run(), before tests are run, but now it's called
2377         for every test in TestInvocation::invoke(), after m_status has
2378         changed to RunningTest.
2379
2380         * WebKitTestRunner/TestController.cpp:
2381         (WTR::TestController::resetStateToConsistentValues): Use
2382         TemporaryChange to reset m_state ot its previous value after reset
2383         is done.
2384
2385 2015-08-31  Jason Marcell  <jmarcell@apple.com>
2386
2387         Modify prepare-Changelog to be aware of files that are marked as tests as well as files
2388         that are marked as requiring corresponding tests.
2389         https://bugs.webkit.org/show_bug.cgi?id=148498
2390         <rdar://problem/21555314>
2391
2392         Reviewed by Dan Bernstein and David Kilzer.
2393
2394         * Scripts/prepare-ChangeLog: Added "attributeCache" to cache Subversion properties in order to
2395         simulate Git's attribute behevaior.
2396         (main): Added "requiresTests" array to contain files that require tests.
2397         (generateNewChangeLogs): Checks "requiresTests" array to determine whether to inject "tests"
2398         section in ChangeLog.
2399         (attributeCommand): Queries a given file for a given Git attribute value. If using Subversion,
2400         however, we check if the file or any containing folder has the given property set to "1" and
2401         return 1 if so; return 0 otherwise.
2402         (generateFileList): Adds files to "requiresTests" array if Git attribute is set to "1". Also
2403         adds files to "addedRegressionTests" array if "test" attribute is set to "1".
2404
2405 2015-08-26  Andy Estes  <aestes@apple.com>
2406
2407         [Content Filtering] Determine navigation and content policy before continuing to filter a load
2408         https://bugs.webkit.org/show_bug.cgi?id=148506
2409
2410         Reviewed by Brady Eidson.
2411
2412         Added download API tests covering every decision and decision point.
2413         Removed _WKDownload.AsynchronousDownloadPolicy in favor of these new tests.
2414
2415         * TestWebKitAPI/Configurations/Base.xcconfig: Added $(BUILT_PRODUCTS_DIR)/WebCoreTestSupport to the header search path.
2416         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Removed it from here.
2417         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm:
2418         (-[BundleParametersPlugIn observeValueForKeyPath:ofObject:change:context:]): Called -valueForKeyPath:, which
2419         returns an id, instead of -valueForKey:, which always returns an NSString even if the object is of another type.
2420         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Added a class that can send a MockContentFilter
2421         decision and decision point as a bundle parameter.
2422         (+[MockContentFilterEnabler supportsSecureCoding]):
2423         (-[MockContentFilterEnabler copyWithZone:]):
2424         (-[MockContentFilterEnabler initWithCoder:]):
2425         (-[MockContentFilterEnabler initWithDecision:decisionPoint:]):
2426         (-[MockContentFilterEnabler encodeWithCoder:]):
2427         (configurationWithContentFilterSettings): Added a helper function to create a WKWebViewConfiguration with MockConentFilter settings.
2428         (TEST): Renamed ContentFiltering.ServerRedirect to ContentFiltering.URLAfterServerRedirect.
2429         (-[BecomeDownloadDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Decided _WKNavigationResponsePolicyBecomeDownload.
2430         (-[BecomeDownloadDelegate webView:didFailProvisionalNavigation:withError:]): Set isDone to true.
2431         (-[BecomeDownloadDelegate webView:didFinishNavigation:]): Ditto.
2432         (-[ContentFilteringDownloadDelegate _downloadDidStart:]): Set downloadDidStart to true.
2433         (downloadTest): Added a helper function to test downloads with a given decision and decision point.
2434         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm: Added a corresponding bundle class that decodes
2435         the MockContentFilter decision and decision point, and sets these values in the MockContentFilterSettings
2436         singleton. This class is duplicated in the bundle to prevent TestWebKitAPI from having to link to WebCoreTestSupport.
2437         (+[MockContentFilterEnabler supportsSecureCoding]):
2438         (-[MockContentFilterEnabler copyWithZone:]):
2439         (-[MockContentFilterEnabler initWithCoder:]):
2440         (-[MockContentFilterEnabler dealloc]):
2441         (-[MockContentFilterEnabler encodeWithCoder:]):
2442         (-[ContentFilteringPlugIn webProcessPlugIn:initializeWithObject:]): Start observing changes to the MockContentFilterEnabler key path.
2443         (-[ContentFilteringPlugIn dealloc]): Stop observing.
2444         (-[ContentFilteringPlugIn observeValueForKeyPath:ofObject:change:context:]): Store a MockContentFilterEnabler in _contentFilterEnabler.
2445         (+[ServerRedirectPlugIn initialize]): Deleted.
2446         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2447         (-[AsynchronousDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
2448         (-[AsynchronousDownloadDelegate _downloadDidStart:]): Deleted.
2449         (TEST): Deleted.
2450
2451 2015-08-31  Filip Pizlo  <fpizlo@apple.com>
2452
2453         Skip slow lock tests on Windows/debug
2454         https://bugs.webkit.org/show_bug.cgi?id=148643
2455
2456         Reviewed by Alexey Proskuryakov.
2457
2458         The lock tests simulate a critical section by doing some floating point math, and then either
2459         make those critical sections very long or invoke them many times. This appears to be
2460         particularly slow on Windows in debug mode, maybe because Visual Studio's debug build makes
2461         that kind of computation slow.
2462
2463         These tests are almost as useful in release as they are in debug, so it's probably better to
2464         just skip the in debug on platforms where this causes timeouts.
2465
2466         * TestWebKitAPI/Tests/WTF/Lock.cpp:
2467         (TestWebKitAPI::runLockTest):
2468         (TestWebKitAPI::skipSlow):
2469         (TestWebKitAPI::TEST):
2470
2471 2015-08-29  Chris Fleizach  <cfleizach@apple.com>
2472
2473         AX: When navigating the elements of a scrollable element with VoiceOver, the scrollTop() position of the element does not permanently change
2474         https://bugs.webkit.org/show_bug.cgi?id=125720
2475
2476         Reviewed by Daniel Bates.
2477
2478         Add support for scrollToMakeVisibleWithSubFocus and scrollToGlobalPoint.
2479
2480         * DumpRenderTree/AccessibilityUIElement.cpp:
2481         (pressCallback):
2482         (scrollToMakeVisibleWithSubFocusCallback):
2483         (scrollToGlobalPointCallback):
2484         (scrollToMakeVisibleCallback):
2485         (AccessibilityUIElement::getJSClass):
2486         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2487         (AccessibilityUIElement::scrollToMakeVisible):
2488         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
2489         (AccessibilityUIElement::scrollToGlobalPoint):
2490         (AccessibilityUIElement::selectedTextRange):
2491         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2492         (AccessibilityUIElement::AccessibilityUIElement):
2493         (AccessibilityUIElement::mathPrescriptsDescription):
2494         (AccessibilityUIElement::scrollToMakeVisible):
2495         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
2496         (AccessibilityUIElement::scrollToGlobalPoint):
2497         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2498         (WTR::AccessibilityUIElement::isTextMarkerValid):
2499         (WTR::AccessibilityUIElement::textMarkerForIndex):
2500         (WTR::AccessibilityUIElement::scrollToMakeVisible):
2501         (WTR::AccessibilityUIElement::scrollToGlobalPoint):
2502         (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
2503         (WTR::AccessibilityUIElement::supportedActions):
2504         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
2505         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
2506         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2507         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2508         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2509         (WTR::AccessibilityUIElement::scrollToMakeVisible):
2510         (WTR::AccessibilityUIElement::scrollToGlobalPoint):
2511         (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
2512         (WTR::AccessibilityUIElement::selectedTextRange):
2513         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2514         (WTR::AccessibilityUIElement::scrollToMakeVisible):
2515         (WTR::AccessibilityUIElement::scrollToGlobalPoint):
2516         (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
2517         (WTR::AccessibilityUIElement::selectedTextRange):
2518
2519 2015-08-28  Timothy Horton  <timothy_horton@apple.com>
2520
2521         Add a mysteriously nonproblematic missing comma.
2522
2523         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2524         (TestExpectationParser._collect_matching_tests):
2525         (TestExpectationParser):
2526
2527 2015-08-28  Timothy Horton  <timothy_horton@apple.com>
2528
2529         Remove an old temporary script that has served its purpose
2530
2531         * Scripts/convert-test-expectations: Removed.
2532
2533 2015-08-28  Jer Noble  <jer.noble@apple.com>
2534
2535         [iOS] Add WebKit/WebKit2 settings to control automatic data loading
2536         https://bugs.webkit.org/show_bug.cgi?id=148579
2537
2538         Reviewed by Anders Carlsson.
2539
2540         In DumpRenderTree, set the new mediaDataLoadsAutomatically preference to YES.
2541
2542         In WebKitTestRunner, do the same for the new _mediaDataLoadsAutomatically configuration property,
2543         and also set the existing requiresUserActionForMediaPlayback configuration property to NO.
2544
2545         * DumpRenderTree/mac/DumpRenderTree.mm:
2546         (resetWebPreferencesToConsistentValues):
2547         (resetWebViewToConsistentStateBeforeTesting):
2548         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2549         (WTR::initializeWebViewConfiguration):
2550
2551 2015-08-28  Alexey Proskuryakov  <ap@apple.com>
2552
2553         Fix run-webkit-tests --additional-env-var="DYLD_INSERT_LIBRARIES=..."
2554         https://bugs.webkit.org/show_bug.cgi?id=148592
2555
2556         Reviewed by Tim Horton.
2557
2558         * Scripts/webkitpy/port/base.py:
2559         (Port.to.setup_environ_for_server):
2560         (Port.to):
2561         (Port.to._append_value_colon_separated):
2562         (Port.to.show_results_html_file):
2563         * Scripts/webkitpy/port/ios.py:
2564         (IOSSimulatorPort.setup_environ_for_server):
2565         * Scripts/webkitpy/port/mac.py:
2566         (MacPort.setup_environ_for_server):
2567
2568 2015-08-28  Filip Pizlo  <fpizlo@apple.com>
2569
2570         LICM should be sound even if the CFG has changed
2571         https://bugs.webkit.org/show_bug.cgi?id=148259
2572
2573         Reviewed by Benjamin Poulain.
2574
2575         Add a utility for creating tests that set some uncommon option.
2576
2577         * Scripts/run-jsc-stress-tests:
2578
2579 2015-08-28  Brent Fulgham  <bfulgham@apple.com>
2580
2581         [Win] Unreviewed EWS correction.
2582
2583         * EWSTools/start-queue-win.sh: Update settings to point to VS2015.
2584
2585 2015-08-28  Jer Noble  <jer.noble@apple.com>
2586
2587         [iOS] Make the AllowsInlineMediaPlayback preference work in WebKit / WebKit2.
2588         https://bugs.webkit.org/show_bug.cgi?id=147512
2589
2590         Reviewed by Anders Carlsson.
2591
2592         Set the value of WebKitAllowsInlineMediaPlayback / WKPreferencesSetMediaPlaybackAllowsInline()
2593         to a consistent (true) value.
2594
2595         * DumpRenderTree/mac/DumpRenderTree.mm:
2596         (setDefaultsToConsistentValuesForTesting):
2597         * WebKitTestRunner/TestController.cpp:
2598         (WTR::TestController::resetPreferencesToConsistentValues):
2599
2600 2015-08-28  Tim Horton  <timothy_horton@apple.com>
2601
2602         Add navigation gesture callbacks to WKPageNavigationClient
2603         https://bugs.webkit.org/show_bug.cgi?id=148568
2604         <rdar://problem/22371346>
2605
2606         Reviewed by Anders Carlsson.
2607
2608         * WebKitTestRunner/TestController.cpp:
2609         (WTR::TestController::createOtherPage):
2610         (WTR::TestController::createWebViewWithOptions):
2611         Add some zeroes.
2612
2613 2015-08-28  Alexey Proskuryakov  <ap@apple.com>
2614
2615         [Mac] kill-old-processes should kill more processes
2616         https://bugs.webkit.org/show_bug.cgi?id=148577
2617
2618         Reviewed by Tim Horton.
2619
2620         * BuildSlaveSupport/kill-old-processes:
2621
2622 2015-08-28  Jason Marcell  <jmarcell@apple.com>
2623
2624         The status message for combined builder queues should say "all builds succeeded" if everything
2625         built correctly.
2626         https://bugs.webkit.org/show_bug.cgi?id=148535
2627
2628         Reviewed by David Kilzer and Alexey Proskuryakov.
2629
2630         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
2631         (BuildbotCombinedQueueView.prototype.update): Make status message for combined builder queues
2632         say "all builds succeeded" if everything built correctly.
2633
2634 2015-08-28  Carlos Garcia Campos  <cgarcia@igalia.com>
2635
2636         [GTK] Simplify the internal API to create a WebView
2637         https://bugs.webkit.org/show_bug.cgi?id=148570
2638
2639         Reviewed by Žan Doberšek.
2640
2641         * TestWebKitAPI/PlatformWebView.h: Add initialize method for GTK+ too.
2642         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
2643         (TestWebKitAPI::PlatformWebView::PlatformWebView): Implement all
2644         PlatformWebView constructors that end up calling initialize with a PageConfiguration.
2645         (TestWebKitAPI::PlatformWebView::initialize): Create the WebView
2646         passing the received PageConfiguration.
2647         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2648         (WTR::PlatformWebView::PlatformWebView): Create the WebView
2649         passing the received PageConfiguration.
2650
2651 2015-08-27  Aakash Jain  <aakash_jain@apple.com>
2652
2653         iOS Simulator API tests fails as Simulator is not running
2654         https://bugs.webkit.org/show_bug.cgi?id=148501
2655         rdar://problem/22447525
2656
2657         Reviewed by Daniel Bates.
2658
2659         This change is a workaround for <rdar://problem/22388812>.
2660
2661          * Scripts/run-api-tests: Launch the iOS Simulator before starting the API Tests
2662          and quit it on program termination when running tests on the iOS port.
2663          * Scripts/webkitdirs.pm: Store string "For WebKit Development" in constant
2664          SIMULATOR_DEVICE_SUFFIX_FOR_WEBKIT_DEVELOPMENT to make it consistently reusable.
2665
2666 2015-08-27  Alex Christensen  <achristensen@webkit.org>
2667
2668         Make DLLLauncherMain executables dependent on dll
2669         https://bugs.webkit.org/show_bug.cgi?id=148548
2670
2671         Reviewed by Brent Fulgham.
2672
2673         * DumpRenderTree/CMakeLists.txt:
2674         * DumpRenderTree/PlatformWin.cmake:
2675         * MiniBrowser/win/CMakeLists.txt:
2676         * TestWebKitAPI/CMakeLists.txt:
2677         * TestWebKitAPI/PlatformWin.cmake:
2678
2679 2015-08-27  Lucas Forschler  <lforschler@apple.com>
2680
2681         Remove Mac slaves 188/189 after being replaced with 400/401.
2682
2683         Unreviewed.
2684
2685         * BuildSlaveSupport/build.webkit.org-config/config.json:
2686
2687 2015-08-27  Lucas Forschler  <lforschler@apple.com>
2688
2689         Add two bots to the Mac Yosemite queue.
2690         This is to eventually replace bots188/189, which will be removed after 400/401 are vetted.
2691
2692         Unreviewed.
2693
2694         * BuildSlaveSupport/build.webkit.org-config/config.json:
2695
2696 2015-08-27  Alex Christensen  <achristensen@webkit.org>
2697
2698         [Win CMake] Fix incremental build after r188673
2699         https://bugs.webkit.org/show_bug.cgi?id=148539
2700
2701         Reviewed by Brent Fulgham.
2702
2703         * TestWebKitAPI/PlatformWin.cmake:
2704         Copy forwarding headers from WebCore before building in case that was not yet done.
2705         It used to be done when running CMake, but now it's a build step.
2706
2707 2015-08-27  Nan Wang  <n_wang@apple.com>
2708
2709         AX: Fix accessibility/select-element-at-index.html test
2710         https://bugs.webkit.org/show_bug.cgi?id=148516
2711
2712         Reviewed by Chris Fleizach.
2713
2714         Implemented setSelectedChildAtIndex and removeSelectionAtIndex for mac.
2715
2716         * DumpRenderTree/AccessibilityUIElement.cpp:
2717         (setSelectedChildCallback):
2718         (setSelectedChildAtIndexCallback):
2719         (removeSelectionAtIndexCallback):
2720         (elementAtPointCallback):
2721         (sentenceAtOffsetCallback):
2722         (stringForSelectionCallback):
2723         (AccessibilityUIElement::getJSClass):
2724         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2725         (AccessibilityUIElement::setSelectedChild):
2726         (AccessibilityUIElement::setSelectedChildAtIndex):
2727         (AccessibilityUIElement::removeSelectionAtIndex):
2728         (AccessibilityUIElement::accessibilityValue):
2729         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2730         (WTR::AccessibilityUIElement::wordAtOffset):
2731         (WTR::AccessibilityUIElement::lineAtOffset):
2732         (WTR::AccessibilityUIElement::sentenceAtOffset):
2733         (WTR::AccessibilityUIElement::isSelectable):
2734         (WTR::AccessibilityUIElement::isMultiSelectable):
2735         (WTR::AccessibilityUIElement::setSelectedChild):
2736         (WTR::AccessibilityUIElement::setSelectedChildAtIndex):
2737         (WTR::AccessibilityUIElement::removeSelectionAtIndex):
2738         (WTR::AccessibilityUIElement::selectedChildrenCount):
2739         (WTR::AccessibilityUIElement::selectedChildAtIndex):
2740         (WTR::AccessibilityUIElement::isExpanded):
2741         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2742         (WTR::AccessibilityUIElement::setSelectedChild):
2743         (WTR::AccessibilityUIElement::setSelectedChildAtIndex):
2744         (WTR::AccessibilityUIElement::removeSelectionAtIndex):
2745         (WTR::AccessibilityUIElement::accessibilityValue):
2746
2747 2015-08-27  Alex Christensen  <achristensen@webkit.org>
2748
2749         Build fix after r188982
2750
2751         * MiniBrowser/win/CMakeLists.txt:
2752         The directory structure changed in the move.
2753
2754 2015-08-27  Michael Catanzaro  <mcatanzaro@igalia.com>
2755
2756         [GTK] Unreviewed, install-dependencies should install geoclue2 on Fedora
2757
2758         geoclue-devel is for obsolete geoclue. Install geoclue2-devel instead.
2759
2760         * gtk/install-dependencies:
2761
2762 2015-08-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2763
2764         Unreviewed. Mark WTF_WordLock.ContendedShortSection as slow too.
2765
2766         * Scripts/run-gtk-tests:
2767         (TestRunner):
2768
2769 2015-08-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2770
2771         Fix GTK+ WTR crashes in initializeMainRunLoop()
2772
2773         Rubber-stamped by Žan Doberšek.
2774
2775         Initialize threading and main thread before
2776         RunLoop::initializeMainRunLoop(), since the GLib implementation of
2777         the RunLoop uses isMainThread() to decide whether to create a new
2778         GMainContext or use the default one. Also use RunLoop::run() and
2779         ::stop() instead of gtk_main/quit.
2780
2781         * WebKitTestRunner/TestController.cpp:
2782         (WTR::TestController::initialize):
2783         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2784         (WTR::TestController::notifyDone):
2785         (WTR::TestController::platformRunUntil):
2786
2787 2015-08-27  Filip Pizlo  <fpizlo@apple.com>
2788
2789         Unreviewed, further shorten a test that times out because it's very long
2790         running.
2791
2792         I've locally run these tests on repeat for 24 hours and found no genuine
2793         failures, like deadlocks. So, the timeouts are probably because the test
2794         machine is slow and debug is slow. We should just run this test for fewer
2795         iterations.
2796
2797         * TestWebKitAPI/Tests/WTF/Lock.cpp:
2798         (TestWebKitAPI::TEST):
2799
2800 2015-08-26  Ryuan Choi  <ryuan.choi@navercorp.com>
2801
2802         Unreviewed build fix attempt on EFL
2803
2804         * WebKitTestRunner/PlatformEfl.cmake:
2805
2806 2015-08-26  Alex Christensen  <achristensen@webkit.org>
2807
2808         Build fix after r188982
2809
2810         * MiniBrowser/win/CMakeLists.txt:
2811         Find .rc files in correct directory.
2812
2813 2015-08-26  Ryuan Choi  <ryuan.choi@navercorp.com>
2814
2815         [EFL] Bump cairo version to 1.14.2
2816         https://bugs.webkit.org/show_bug.cgi?id=148474
2817
2818         Reviewed by Csaba Osztrogonác.
2819
2820         * efl/jhbuild.modules:
2821
2822 2015-08-26  Andy Estes  <aestes@apple.com>
2823
2824         Crash when following a Google search link to Twitter with Limit Adult Content enabled
2825         https://bugs.webkit.org/show_bug.cgi?id=147651
2826
2827         Rubber-stamped by Brady Eidson.
2828
2829         Taught TestRunner how to decide the navigation policy after a delay.
2830
2831         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2832         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2833         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
2834         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2835         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
2836         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2837         (WTR::TestRunner::shouldDecideNavigationPolicyAfterDelay):
2838         * WebKitTestRunner/TestController.cpp:
2839         (WTR::TestController::initialize):
2840         (WTR::TestController::resetStateToConsistentValues):
2841         (WTR::TestController::decidePolicyForNavigationAction):
2842         * WebKitTestRunner/TestController.h:
2843         (WTR::TestController::setShouldDecideNavigationPolicyAfterDelay):
2844         * WebKitTestRunner/TestInvocation.cpp:
2845         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2846
2847 2015-08-26  Brent Fulgham  <bfulgham@apple.com>
2848
2849         [Win] Rename 'WinLauncher' to 'MiniBrowser'
2850         https://bugs.webkit.org/show_bug.cgi?id=148485
2851
2852         Reviewed by Alex Christensen
2853
2854         Move the WinLauncher project and source files to a subdirectory
2855         of MiniBrowser. Globally change WinLauncher -> MiniBrowser in the
2856         source code and project files.
2857
2858         * MiniBrowser/MiniBrowser.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj.
2859         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.ico: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.ico.
2860         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.rc: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.rc.
2861         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.
2862         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.vcxproj.filters: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters.
2863         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCF.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCF.props.
2864         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCFLite.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props.
2865         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCommon.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props.
2866         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserDebug.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props.
2867         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc.
2868         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.
2869         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj.filters: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters.
2870         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibCommon.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props.
2871         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibDebug.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props.
2872         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibPostBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd.
2873         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibPreBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd.
2874         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibProduction.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props.
2875         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibRelease.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props.
2876         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h.
2877         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserPostBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherPostBuild.cmd.
2878         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserPreBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherPreBuild.cmd.
2879         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserProduction.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props.
2880         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserRelease.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props.
2881         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserResource.h: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherResource.h.
2882         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.ico: Removed.
2883         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.rc: Removed.
2884         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.vcxproj: Removed.
2885         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.vcxproj.filters: Removed.
2886         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCF.props: Removed.
2887         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCFLite.props: Removed.
2888         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCommon.props: Removed.
2889         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherDebug.props: Removed.
2890         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.rc: Removed.
2891         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.vcxproj: Removed.
2892         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.vcxproj.filters: Removed.
2893         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibCommon.props: Removed.
2894         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibDebug.props: Removed.
2895         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibPostBuild.cmd: Removed.
2896         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibPreBuild.cmd: Removed.
2897         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibProduction.props: Removed.
2898         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibRelease.props: Removed.
2899         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibResource.h: Removed.
2900         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherPostBuild.cmd: Removed.
2901         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherPreBuild.cmd: Removed.
2902         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherProduction.props: Removed.
2903         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherRelease.props: Removed.
2904         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherResource.h: Removed.
2905         * MiniBrowser/win: Copied from WinLauncher.
2906         * MiniBrowser/win/Common.cpp:
2907         * MiniBrowser/win/MiniBrowser.cpp: Copied from WinLauncher/WinLauncher.cpp.
2908         * MiniBrowser/win/MiniBrowser.h: Copied from WinLauncher/WinLauncher.h.
2909         * MiniBrowser/win/MiniBrowserReplace.h: Copied from WinLauncher/WinLauncherReplace.h.
2910         * MiniBrowser/win/MiniBrowserWebHost.cpp: Copied from WinLauncher/WinLauncherWebHost.cpp.
2911         * MiniBrowser/win/MiniBrowserWebHost.h: Copied from WinLauncher/WinLauncherWebHost.h.
2912         * MiniBrowser/win/PageLoadTestClient.cpp:
2913         * MiniBrowser/win/PageLoadTestClient.h:
2914         * MiniBrowser/win/ResourceLoadDelegate.cpp:
2915         * MiniBrowser/win/ResourceLoadDelegate.h:
2916         * MiniBrowser/win/WinLauncher.cpp: Removed.
2917         * MiniBrowser/win/WinLauncher.h: Removed.
2918         * MiniBrowser/win/WinLauncher.vcxproj: Removed.
2919         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.ico: Removed.
2920         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.rc: Removed.
2921         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.vcxproj: Removed.
2922         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Removed.
2923         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCF.props: Removed.
2924         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCFLite.props: Removed.
2925         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCommon.props: Removed.
2926         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherDebug.props: Removed.
2927         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.rc: Removed.
2928         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Removed.
2929         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: Removed.
2930         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibCommon.props: Removed.
2931         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibDebug.props: Removed.
2932         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd: Removed.
2933         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd: Removed.
2934         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibProduction.props: Removed.
2935         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibRelease.props: Removed.
2936         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibResource.h: Removed.
2937         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherPostBuild.cmd: Removed.
2938         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherPreBuild.cmd: Removed.
2939         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherProduction.props: Removed.
2940         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherRelease.props: Removed.
2941         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherResource.h: Removed.
2942         * MiniBrowser/win/WinLauncher.vcxproj/small.ico: Removed.
2943         * MiniBrowser/win/WinLauncherReplace.h: Removed.
2944         * MiniBrowser/win/WinLauncherWebHost.cpp: Removed.
2945         * MiniBrowser/win/WinLauncherWebHost.h: Removed.
2946         * MiniBrowser/win/WinMain.cpp:
2947         * WinLauncher: Removed.
2948         * WinLauncher/AccessibilityDelegate.cpp: Removed.
2949         * WinLauncher/AccessibilityDelegate.h: Removed.
2950         * WinLauncher/CMakeLists.txt: Removed.
2951         * WinLauncher/Common.cpp: Removed.
2952         * WinLauncher/DOMDefaultImpl.cpp: Removed.
2953         * WinLauncher/DOMDefaultImpl.h: Removed.
2954         * WinLauncher/PageLoadTestClient.cpp: Removed.
2955         * WinLauncher/PageLoadTestClient.h: Removed.
2956         * WinLauncher/PrintWebUIDelegate.cpp: Removed.
2957         * WinLauncher/PrintWebUIDelegate.h: Removed.
2958         * WinLauncher/ResourceLoadDelegate.cpp: Removed.
2959         * WinLauncher/ResourceLoadDelegate.h: Removed.
2960         * WinLauncher/WebDownloadDelegate.cpp: Removed.
2961         * WinLauncher/WebDownloadDelegate.h: Removed.
2962         * WinLauncher/WinLauncher.cpp: Removed.
2963         * WinLauncher/WinLauncher.h: Removed.
2964         * WinLauncher/WinLauncher.vcxproj: Removed.
2965         * WinLauncher/WinLauncher.vcxproj/WinLauncher.ico: Removed.
2966         * WinLauncher/WinLauncher.vcxproj/WinLauncher.rc: Removed.
2967         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Removed.
2968         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Removed.
2969         * WinLauncher/WinLauncher.vcxproj/WinLauncherCF.props: Removed.
2970         * WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props: Removed.
2971         * WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props: Removed.
2972         * WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props: Removed.
2973         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Removed.
2974         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Removed.
2975         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: Removed.
2976         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Removed.
2977         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props: Removed.
2978         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd: Removed.
2979         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd: Removed.
2980         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props: Removed.
2981         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props: Removed.
2982         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h: Removed.
2983         * WinLauncher/WinLauncher.vcxproj/WinLauncherPostBuild.cmd: Removed.
2984         * WinLauncher/WinLauncher.vcxproj/WinLauncherPreBuild.cmd: Removed.
2985         * WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props: Removed.
2986         * WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props: Removed.
2987         * WinLauncher/WinLauncher.vcxproj/WinLauncherResource.h: Removed.
2988         * WinLauncher/WinLauncher.vcxproj/small.ico: Removed.
2989         * WinLauncher/WinLauncherReplace.h: Removed.
2990         * WinLauncher/WinLauncherWebHost.cpp: Removed.
2991         * WinLauncher/WinLauncherWebHost.h: Removed.
2992         * WinLauncher/WinMain.cpp: Removed.
2993         * WinLauncher/resource.h: Removed.
2994         * WinLauncher/stdafx.cpp: Removed.
2995         * WinLauncher/stdafx.h: Removed.
2996         * win/AssembleBuildLogs/AssembleLogs.cmd:
2997
2998 2015-08-26  Brent Fulgham  <bfulgham@apple.com>
2999
3000         [Win] Simplify menu handling code in WinLauncher
3001         https://bugs.webkit.org/show_bug.cgi?id=148461
3002
3003         Reviewed by Zalan Bujtas.
3004
3005         Revise 'ToggleMenuItem' to return a boolean value indicating if
3006         it handled the message. Revise WndProc to use this to decide if it
3007         should pass the message on to the default handler, rather than
3008         duplicating the logic in both places.
3009
3010         * WinLauncher/Common.cpp:
3011         (ToggleMenuItem): Return true if the menu item message was handled.
3012         (WndProc): If 'ToggleMenuItem' did not handle the message, pass
3013         the message tothe default handler.
3014
3015 2015-08-26  Csaba Osztrogonác  <ossy@webkit.org>
3016
3017         Remove unused code after r188948
3018         https://bugs.webkit.org/show_bug.cgi?id=148467
3019
3020         Reviewed by Gyuyoung Kim.
3021
3022         * WebKitTestRunner/TestController.cpp:
3023         (WTR::TestController::platformPreferences): Deleted.
3024
3025 2015-08-26  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3026
3027         [EFL][GTK] REGRESSION(r188828): All performance tests and almost all layout tests crash
3028         https://bugs.webkit.org/show_bug.cgi?id=148377
3029
3030         Reviewed by Carlos Garcia Campos.
3031
3032         EFL and GTK don't support TestController::platformPreferences() yet which was introduced by r188828.
3033         It caused all crashes of layout test and performance test on EFL and GTK. So this patch implements
3034         TestController::platformPreferences() using WKPageGroupGetPreferences() which was previous thing for
3035         EFL and GTK at the moment.
3036
3037         * WebKitTestRunner/TestController.cpp:
3038         (WTR::TestController::platformWillRunTest):
3039         * WebKitTestRunner/efl/TestControllerEfl.cpp:
3040         (WTR::TestController::platformPreferences):
3041         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3042         (WTR::TestController::platformPreferences):
3043
3044 2015-08-25  Nan Wang  <n_wang@apple.com>
3045
3046         AX: Enable accessibility/aria-controls.html test for mac
3047         https://bugs.webkit.org/show_bug.cgi?id=148458
3048
3049         Reviewed by Chris Fleizach.
3050
3051         Implemented ariaControlsElementAtIndex(unsigned index).
3052
3053         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3054         (AccessibilityUIElement::ariaControlsElementAtIndex):
3055         (AccessibilityUIElement::disclosedRowAtIndex):
3056         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3057         (WTR::AccessibilityUIElement::ariaControlsElementAtIndex):
3058
3059 2015-08-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3060
3061         Remove python tests for PassRefPtr
3062         https://bugs.webkit.org/show_bug.cgi?id=148463
3063
3064         Reviewed by Andy Estes.
3065
3066         As we're removing uses of PassRefPtr, we need to remove all python tests for PassRefPtr as well.
3067
3068         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3069         (PassPtrTest): Deleted.
3070         (PassPtrTest.assert_pass_ptr_check): Deleted.
3071         (PassPtrTest.test_pass_ref_ptr_in_function): Deleted.
3072         (PassPtrTest.test_pass_other_type_ptr_in_function): Deleted.
3073         (PassPtrTest.test_pass_ref_ptr_return_value): Deleted.
3074         (PassPtrTest.test_ref_ptr_parameter_value): Deleted.
3075         (PassPtrTest.test_ref_ptr_member_variable): Deleted.
3076         (PassPtrTest.test_ref_ptr_member_variable.Foo): Deleted.
3077
3078 2015-08-25  Andy Estes  <aestes@apple.com>
3079
3080         [iOS] run-webkit-tests fails if watchOS SDK is installed
3081         https://bugs.webkit.org/show_bug.cgi?id=148453
3082
3083         Reviewed by David Kilzer.
3084
3085         * Scripts/webkitpy/xcode/simulator.py:
3086         (Simulator): Taught Simulator how to parse watchOS runtimes and devices.
3087         * Scripts/webkitpy/xcode/simulator_unittest.py: Added tests.
3088
3089 2015-08-25  Aakash Jain  <aakash_jain@apple.com>
3090
3091         iOS Simulator layout-tests fail to start while cleaning a directory structure if simulator is already running
3092         https://bugs.webkit.org/show_bug.cgi?id=148197
3093         rdar://problem/22334382
3094
3095         Reviewed by Daniel Bates.
3096
3097         * BuildSlaveSupport/kill-old-processes: Add Simulator to the list of processes to kill (for iOS builders).
3098         * Scripts/webkitpy/port/ios.py:
3099         (IOSSimulatorPort): Converted bundle id com.apple.iphonesimulator to a variable SIMULATOR_BUNDLE_ID.
3100         (IOSSimulatorPort._quitIOSSimulator): Common function to quit iOS Simulator.
3101         (IOSSimulatorPort.clean_up_test_run): Quit the simulator during the cleanup.
3102         (IOSSimulatorPort.check_sys_deps): No need to quit the simulator here as its now being quit in reset_preferences().
3103         (IOSSimulatorPort.reset_preferences): Quit the simulator before trying to delete associated data directory.
3104
3105 2015-08-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3106
3107         Remove PassRefPtr style check rule
3108         https://bugs.webkit.org/show_bug.cgi?id=148432
3109
3110         Reviewed by Andreas Kling.
3111
3112         PassRefPtr is being removed. Thus style rule needs to be removed as well.
3113
3114         * Scripts/webkitpy/style/checkers/cpp.py:
3115         (_check_parameter_name_against_text): Deleted.
3116         (check_function_definition_and_pass_ptr): Deleted.
3117         (check_function_definition): Deleted.
3118         (check_pass_ptr_usage): Deleted.
3119         (process_line): Deleted.
3120         (CppChecker): Deleted.
3121
3122 2015-08-25  Brent Fulgham  <bfulgham@apple.com>
3123
3124         [Win] Expose "Inverted Colors" option in WinLauncher
3125         https://bugs.webkit.org/show_bug.cgi?id=148451
3126
3127         Reviewed by Tim Horton.
3128
3129         Add the ability to toggle the "Inverted Colors" preference
3130         in WinLauncher.
3131
3132         * WinLauncher/Common.cpp:
3133         (ToggleMenuItem): Toggle the feature when the menu item
3134         is selected.
3135         (WndProc): Recognize the new menu option.
3136         * WinLauncher/WinLauncher.cpp:
3137         (WinLauncher::setToDefaultPreferences): Launch with "Invert
3138         Colors" turned off.
3139         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Add menu
3140         entry for "Invert Colors".
3141         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h:
3142
3143 2015-08-25  Nan Wang  <n_wang@apple.com>
3144
3145         [Mac] accessibility/document-attributes.html fails
3146         https://bugs.webkit.org/show_bug.cgi?id=116636
3147
3148         Reviewed by Chris Fleizach.
3149
3150         Implemented documentURI() and documentEncoding().
3151
3152         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3153         (AccessibilityUIElement::documentEncoding):
3154         (AccessibilityUIElement::documentURI):
3155         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3156         (WTR::AccessibilityUIElement::documentEncoding):
3157         (WTR::AccessibilityUIElement::documentURI):
3158
3159 2015-08-24  Brent Fulgham  <bfulgham@apple.com>
3160
3161         [Win] Unreviewed test gardening.
3162
3163         Fix another case where the logging string is constructed using the variable 'frame',
3164         but the method argument is not given a name. This causes the global 'frame' value to
3165         be used, producing incorrect output.
3166
3167         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3168         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame): Use 'frame'
3169         argument.
3170
3171 2015-08-24  Tim Horton  <timothy_horton@apple.com>
3172
3173         (Finally...) get rid of WKViewIOS
3174         https://bugs.webkit.org/show_bug.cgi?id=148404
3175
3176         Reviewed by Anders Carlsson.
3177
3178         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
3179         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
3180         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
3181         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
3182         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
3183         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
3184         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:
3185         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
3186         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
3187         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.mm:
3188         Mark tests that use WKBrowsingContextController as Mac-only.
3189
3190         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
3191         (WTR::AccessibilityController::addNotificationListener):
3192         * WebKitTestRunner/ios/mainIOS.mm:
3193         (-[WebKitTestRunnerApp applicationDidEnterBackground:]):
3194         Import UIKit instead of depending on WKView.h to do so.
3195
3196 2015-08-24  Jason Marcell  <jmarcell@apple.com>
3197
3198         Add support to dashboard for displaying Git SHA's as revisions.
3199         https://bugs.webkit.org/show_bug.cgi?id=148387
3200
3201         Reviewed by Daniel Bates.
3202
3203         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3204         (parseRevisionProperty): Added support to dashboard for displaying Git SHA's as revisions.
3205         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3206         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Ditto.
3207         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js: Added
3208         "isSVN" property to Dashboard.Repository.(OpenSource|Internal).
3209
3210 2015-08-24  Andy Estes  <aestes@apple.com>
3211
3212         REGRESSION (r188851): WebKit2.BundleParameters fails on iOS
3213
3214         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Specify LD_RUNPATH_SEARCH_PATHS correctly for iOS.
3215
3216 2015-08-23  Andy Estes  <aestes@apple.com>
3217
3218         Addressed a missed piece of review feedback from r188851.
3219
3220         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
3221
3222 2015-08-23  Andy Estes  <aestes@apple.com>
3223
3224         [Content Filtering] REGRESSION (r182356): Provisional URL is incorrect in didReceiveServerRedirectForProvisionalLoadForFrame when Content Filtering is enabled
3225         https://bugs.webkit.org/show_bug.cgi?id=147872
3226         rdar://problem/22044000
3227
3228         Reviewed by Dan Bernstein.
3229
3230         Added an API test.
3231
3232         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Linked libWebCoreTestSupport in order to use MockContentFilter.
3233         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3234         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Added.
3235         (-[ServerRedirectNavigationDelegate webView:didStartProvisionalNavigation:]): Expect the initial request URL.
3236         (-[ServerRedirectNavigationDelegate webView:didReceiveServerRedirectForProvisionalNavigation:]): Expect the redirect URL.
3237         (-[ServerRedirectNavigationDelegate webView:didCommitNavigation:]):
3238         (TEST): Tested that -[WKWebView URL] is updated after a redirect when content filtering is enabled.
3239         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm: Added.
3240         (+[ServerRedirectPlugIn initialize]): Enable MockContentFilter.
3241         * TestWebKitAPI/cocoa/TestProtocol.h: Renamed from Tools/TestWebKitAPI/mac/TestProtocol.h.
3242         * TestWebKitAPI/cocoa/TestProtocol.mm: Renamed from Tools/TestWebKitAPI/mac/TestProtocol.mm.
3243
3244 2015-08-23  Andy Estes  <aestes@apple.com>
3245
3246         Fixed the 32-bit Mac build after r188844.
3247
3248         * TestWebKitAPI/WKWebViewConfigurationExtras.h:
3249         * TestWebKitAPI/WKWebViewConfigurationExtras.mm:
3250
3251 2015-08-22  Andy Estes  <aestes@apple.com>
3252
3253         [Cocoa] API tests using the Modern WebKit API should be able to create web process plug-ins
3254         https://bugs.webkit.org/show_bug.cgi?id=148317
3255
3256         Reviewed by Dan Bernstein.
3257
3258         Added the ability for Modern WebKit API tests to create WKWebProcessPlugIns. A test can create a plug-in by
3259         creating a class that conforms to WKWebProcessPlugIn, adding it to the WebProcessPlugIn target, and using the
3260         WKWebViewConfiguration returned by +[WKWebViewConfiguration testwebkitapi_configurationWithTestPlugInClassName:]
3261         when creating WKWebViews.
3262
3263         Since TestWebKitAPI relies on a bundle parameter to know which test class to instantiate in the plug-in, I also
3264         added a new API test for bundle parameters.
3265
3266         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Added. Named the bundle TestWebKitAPI.wkbundle and
3267         named its executable TestWebKitAPI.bundle.
3268         * TestWebKitAPI/PlatformUtilities.h: Declared TestPlugInClassNameParameter.
3269         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added the WebProcessPlugIn target.
3270         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm: Added.
3271         (TEST): Tested bundle parameters by verifying that parameter changes in the UI process are observed in the bundle.
3272         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm: Added.
3273         (-[BundleParametersPlugIn webProcessPlugIn:didCreateBrowserContextController:]): Started observing changes to a
3274         bundle parameter and asked for an initial notification.
3275         (-[BundleParametersPlugIn dealloc]): Stopped observing changes to a bundle parameter.
3276         (-[BundleParametersPlugIn observeValueForKeyPath:ofObject:change:context:]): When a bundle parameter changes,
3277         mirror its value in the main frame's JSContext.
3278         * TestWebKitAPI/WKWebViewConfigurationExtras.h: Added.
3279         * TestWebKitAPI/WKWebViewConfigurationExtras.mm: Added.
3280         (+[WKWebViewConfiguration testwebkitapi_configurationWithTestPlugInClassName:]): Created a configuration with
3281         TestWebKitAPI's bundle URL and set a bundle parameter indicating the test plug-in's class name.
3282         * TestWebKitAPI/cocoa/PlatformUtilitiesCocoa.mm: Defined TestPlugInClassNameParameter.
3283         * TestWebKitAPI/cocoa/WebProcessPlugIn/Info.plist: Added. Set the principal class to WebProcessPlugIn.
3284         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm: Added.
3285         (-[WebProcessPlugIn webProcessPlugIn:initializeWithObject:]): Forwarded to a newly-created test class instance.
3286         (-[WebProcessPlugIn respondsToSelector:]): Returned YES if the test class instance response.
3287         (-[WebProcessPlugIn forwardingTargetForSelector:]): Forwarded unimplemented methods to the test class instance.
3288
3289 2015-08-23  Csaba Osztrogonác  <ossy@webkit.org>
3290
3291         URTBF after r188828.
3292
3293         * WebKitTestRunner/PlatformWebView.h:
3294
3295 2015-08-23  Alexey Proskuryakov  <ap@apple.com>
3296
3297         build.webkit.org/dashboard: Combined queues don't turn orange on internal failure
3298         https://bugs.webkit.org/show_bug.cgi?id=148356
3299
3300         Reviewed by Darin Adler.
3301
3302         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
3303         (BuildbotCombinedQueueView.prototype.update):
3304
3305 2015-08-23  Alexey Proskuryakov  <ap@apple.com>
3306
3307         build.webkit.org/dashboard: Respect step's hidden flag
3308         https://bugs.webkit.org/show_bug.cgi?id=148357
3309
3310         Reviewed by Darin Adler.
3311
3312         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3313         (BuildbotIteration.prototype._parseData):
3314
3315 2015-08-23  Nan Wang  <n_wang@apple.com>
3316
3317         AX: Fix accessibility/deleting-iframe-destroys-axcache.html test
3318         https://bugs.webkit.org/show_bug.cgi?id=148328
3319
3320         Reviewed by Darin Adler.
3321
3322         We should only expose stringValue() when value attribute is set.
3323
3324         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3325         (AccessibilityUIElement::stringValue):
3326         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3327         (WTR::AccessibilityUIElement::stringValue):
3328
3329 2015-08-23  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3330
3331         Remove style checking rule regarding OwnPtr and PassOwnPtr
3332         https://bugs.webkit.org/show_bug.cgi?id=148360
3333
3334         Reviewed by Darin Adler.
3335
3336         OwnPtr and PassOwnPtr were totally removed though, style rule is still alive.
3337         Removed it.
3338
3339         * Scripts/do-webcore-rename:
3340         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3341         (PassPtrTest.test_pass_own_ptr_in_function): Deleted.
3342         (PassPtrTest.test_pass_ref_ptr_return_value): Deleted.
3343         (PassPtrTest.test_own_ptr_parameter_value): Deleted.
3344         (WebKitStyleTest.test_names): Deleted.
3345
3346 2015-08-22  Timothy Horton  <timothy_horton@apple.com>
3347
3348         WebKitTestRunner should use WKWebView on OS X and iOS
3349         https://bugs.webkit.org/show_bug.cgi?id=143743
3350         <rdar://problem/16947123>
3351
3352         Reviewed by Anders Carlsson.
3353         Patch by Enrica Casucci and myself.
3354
3355         * WebKitTestRunner/PlatformWebView.h:
3356         (WTR::PlatformWebView::windowSnapshotEnabled): Deleted.
3357         Add a PlatformWebView constructor that takes a WKWebViewConfiguration
3358         instead of WKContext and WKPageGroup.
3359
3360         Remove the unused, always-true windowSnapshotEnabled().
3361         While technically some platforms don't have window snapshotting,
3362         they just return null instead of implementing windowSnapshotEnabled().
3363
3364         * WebKitTestRunner/TestController.h:
3365         * WebKitTestRunner/TestController.cpp:
3366         (WTR::TestController::createOtherPage):
3367         (WTR::TestController::initialize):
3368         (WTR::TestController::createWebViewWithOptions):
3369         Delegate to the various platforms for creating PlatformWebView instances,
3370         for creating WKContexts, and for accessing WKPreferences,
3371         so that they can do special things (like, use WKWebView instead!).
3372
3373         (WTR::TestController::resetPreferencesToConsistentValues):
3374         Make explicit WebKitTestRunner's desired default for two preferences
3375         which have differing defaults between the antique and modern API,
3376         for consistency's sake.
3377
3378         (WTR::TestController::resetStateToConsistentValues):
3379         Add platformResetStateToConsistentValues.
3380
3381         * WebKitTestRunner/TestInvocation.cpp:
3382         (WTR::TestInvocation::dumpResults):
3383         Adjust to the aforementioned removal of windowSnapshotEnabled().
3384
3385         * WebKitTestRunner/ios/TestControllerCocoa.mm:
3386         (WTR::TestController::platformResetStateToConsistentValues):
3387         (WTR::TestController::platformPreferences):
3388         (WTR::TestController::platformCreateWebView):
3389         (WTR::TestController::platformCreateOtherPage):
3390         (WTR::TestController::platformInitializeConfiguration):
3391         Implement the new platform functions for the Modern WebKit2 API,
3392         in a new TestControllerCocoa file that is shared between iOS and Mac.
3393
3394         For platformMaybeCreateContext, use the trick that we know we can cast
3395         the WKProcessPool to a WKContextRef to retrieve a WKContextRef from
3396         WKWebView's configuration.
3397
3398         Ditto for WKPreferencesRef and WKPreferences.
3399
3400         Remove user content filters on the WKWebView's userContentController.
3401
3402         * WebKitTestRunner/mac/TestControllerMac.mm:
3403         * WebKitTestRunner/ios/TestControllerIOS.mm:
3404         Move code into TestControllerCocoa.
3405
3406         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3407         (WTR::InjectedBundle::beginTesting):
3408         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3409         (WTR::TestRunner::addUserScript):
3410         (WTR::TestRunner::addUserStyleSheet):
3411         Adopt WKBundlePage API for user scripts/sheets.
3412
3413         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3414         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3415         Make and keep a WKWebView instead of a WKView.
3416
3417         * WebKitTestRunner/mac/EventSenderProxy.mm:
3418         (WTR::EventSenderProxy::mouseUp):
3419         (WTR::EventSenderProxy::mouseMoveTo):
3420         Reach inside the WKWebView to the WKView when dispatching events.
3421         This is fairly ugly and we should come up with a better solution.
3422         Also, fix some flipping and style errors.
3423
3424 2015-08-22  Michael Catanzaro  <mcatanzaro@igalia.com>
3425
3426         Unreviewed, attempt to fix GTK build after r188718
3427
3428         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3429         (WTR::PlatformWebView::PlatformWebView):
3430
3431 2015-08-21  Commit Queue  <commit-queue@webkit.org>
3432
3433         Unreviewed, rolling out r188807, r188813, and r188815.
3434         https://bugs.webkit.org/show_bug.cgi?id=148349
3435
3436         lots of 32-bit build problems, better to resolve separately
3437         and try again (Requested by thorton on #webkit).
3438
3439         Reverted changesets:
3440
3441         "WebKitTestRunner should use WKWebView on OS X and iOS"
3442         https://bugs.webkit.org/show_bug.cgi?id=143743
3443         http://trac.webkit.org/changeset/188807
3444
3445         "Stop building WebKitTestRunner for 32-bit platforms"
3446         https://bugs.webkit.org/show_bug.cgi?id=143743
3447         http://trac.webkit.org/changeset/188813
3448
3449         "Stop building WebKitTestRunner for 32-bit platforms"
3450         https://bugs.webkit.org/show_bug.cgi?id=143743
3451         http://trac.webkit.org/changeset/188815
3452
3453 2015-08-21  Tim Horton  <timothy_horton@apple.com>
3454
3455         Stop building WebKitTestRunner for 32-bit platforms
3456         https://bugs.webkit.org/show_bug.cgi?id=143743
3457         <rdar://problem/16947123>
3458
3459         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3460         This is a restriction on the valid set, not the desired set.
3461
3462 2015-08-21  Jason Marcell  <jmarcell@apple.com>
3463
3464         Make Dashboard.Branches be objects of the form (repository, "branch name") and update existing code
3465         to work with these new objects.
3466         https://bugs.webkit.org/show_bug.cgi?id=148188
3467
3468         Reviewed by Daniel Bates.
3469
3470         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
3471         (Buildbot.prototype._normalizeQueueInfo): Renamed BuildbotQueue.branch to BuildbotQueue.branches.
3472         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
3473         (BuildbotCombinedQueueView): Changed to work with new branch objects which represent a
3474         (repository, "branch name")-pair.
3475         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Ditto.
3476         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3477         (BuildbotQueue): Renamed BuildbotQueue.branch to BuildbotQueue.branches.
3478         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3479         (BuildbotQueueView.prototype._appendPendingRevisionCount): Changed to work with new branch
3480         objects which represent a (repository, "branch name")-pair.
3481         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Ditto.
3482         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Ditto.
3483         (BuildbotQueueView.prototype._addDividerToPopover): Ditto.
3484         (BuildbotQueueView.prototype.revisionContentForIteration): Ditto.
3485         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Renamed
3486         BuildbotQueue.branch to BuildbotQueue.branches.
3487         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3488         (WebKitBuildbot.prototype.get defaultBranches): Changed to new (repository, "branch name") format.
3489
3490 2015-08-21  Tim Horton  <timothy_horton@apple.com>
3491
3492         Stop building WebKitTestRunner for 32-bit platforms
3493         https://bugs.webkit.org/show_bug.cgi?id=143743
3494         <rdar://problem/16947123>
3495
3496         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3497         WKWebView is not available on 32-bit OS X.
3498
3499 2015-08-21  Brent Fulgham  <bfulgham@apple.com>
3500
3501         [Win] Unreviewed test correction after r188709.
3502
3503         I removed a function argument that happened to be mirrored by a global
3504         value with the same name. This prevented a compile error, but testing
3505         showed that the wrong value was being used in the function.
3506
3507         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3508         (FrameLoadDelegate::willPerformClientRedirectToURL): Put function argument
3509         back
3510
3511 2015-08-21  Timothy Horton  <timothy_horton@apple.com>
3512
3513         WebKitTestRunner should use WKWebView on OS X and iOS
3514         https://bugs.webkit.org/show_bug.cgi?id=143743
3515         <rdar://problem/16947123>
3516
3517         Reviewed by Anders Carlsson.
3518         Patch by Enrica Casucci and myself.
3519
3520         * WebKitTestRunner/PlatformWebView.h:
3521         (WTR::PlatformWebView::windowSnapshotEnabled): Deleted.
3522         Add a PlatformWebView constructor that takes a WKWebViewConfiguration
3523         instead of WKContext and WKPageGroup.
3524
3525         Remove the unused, always-true windowSnapshotEnabled().
3526         While technically some platforms don't have window snapshotting,
3527         they just return null instead of implementing windowSnapshotEnabled().
3528
3529         * WebKitTestRunner/TestController.h:
3530         * WebKitTestRunner/TestController.cpp:
3531         (WTR::TestController::createOtherPage):
3532         (WTR::TestController::initialize):
3533         (WTR::TestController::createWebViewWithOptions):
3534         Delegate to the various platforms for creating PlatformWebView instances,
3535         for creating WKContexts, and for accessing WKPreferences,
3536         so that they can do special things (like, use WKWebView instead!).
3537
3538         (WTR::TestController::resetPreferencesToConsistentValues):
3539         Make explicit WebKitTestRunner's desired default for two preferences
3540         which have differing defaults between the antique and modern API,
3541         for consistency's sake.
3542
3543         (WTR::TestController::resetStateToConsistentValues):
3544         Add platformResetStateToConsistentValues.
3545
3546         * WebKitTestRunner/TestInvocation.cpp:
3547         (WTR::TestInvocation::dumpResults):
3548         Adjust to the aforementioned removal of windowSnapshotEnabled().
3549
3550         * WebKitTestRunner/ios/TestControllerCocoa.mm:
3551         (WTR::TestController::platformResetStateToConsistentValues):
3552         (WTR::TestController::platformPreferences):
3553         (WTR::TestController::platformCreateWebView):
3554         (WTR::TestController::platformCreateOtherPage):
3555   &n