Unreviewed, rolling out r109733.
[WebKit-https.git] / Tools / ChangeLog
1 2012-03-05  Sheriff Bot  <webkit.review.bot@gmail.com>
2
3         Unreviewed, rolling out r109733.
4         http://trac.webkit.org/changeset/109733
5         https://bugs.webkit.org/show_bug.cgi?id=80378
6
7         It broke Qt5 build system (Requested by Ossy on #webkit).
8
9         * Tools.pro:
10         * qmake/config.tests/gccdepends/empty.cpp: Removed.
11         * qmake/config.tests/gccdepends/gccdepends.pro: Removed.
12         * qmake/mkspecs/features/default_pre.prf:
13         * qmake/mkspecs/features/features.prf:
14         * qmake/mkspecs/features/unix/default_pre.prf:
15         * qmake/sync.profile:
16
17 2012-03-05  Eric Seidel  <eric@webkit.org>
18
19         Update JavaScriptCore files to use fully-qualified WTF include path
20         https://bugs.webkit.org/show_bug.cgi?id=79960
21
22         Reviewed by Adam Barth.
23
24         Build WTF/WTF.xcodeproj by default on Mac.
25
26         * Scripts/build-webkit:
27
28 2012-03-05  Dirk Pranke  <dpranke@chromium.org>
29
30         There should be a way to disable optimizer in webkit-patch rebaseline-expectations
31         https://bugs.webkit.org/show_bug.cgi?id=69590
32
33         Reviewed by Ryosuke Niwa.
34
35         Adds a --no-optimize flag to webkit-patch rebaseline-expectations
36         to skip the 'optimize-expectations' step.
37
38         * Scripts/webkitpy/tool/commands/rebaseline.py:
39         (RebaselineExpectations.__init__):
40         (RebaselineExpectations.execute):
41         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
42
43 2012-03-05  Kent Tamura  <tkent@chromium.org>
44
45         [Chromium] Add new popup type: PagePopup
46         https://bugs.webkit.org/show_bug.cgi?id=80106
47
48         Reviewed by Darin Fisher.
49
50         * DumpRenderTree/chromium/WebViewHost.cpp:
51         (WebViewHost::createPopupMenu):
52
53 2012-03-05  Jessie Berlin  <jberlin@apple.com>
54
55         Add myself as a reviewer.
56
57         * Scripts/webkitpy/common/config/committers.py:
58         Also, add my IRC nick so it is easier to find and yell at me.
59
60 2012-03-05  Robert Kroeger  <rjkroege@chromium.org>
61
62         Correctly compute the positions of GestureScroll* events on
63         Chromium.
64         https://bugs.webkit.org/show_bug.cgi?id=80075
65
66         Reviewed by Adam Barth.
67
68         * DumpRenderTree/chromium/EventSender.cpp:
69         (EventSender::reset):
70         (EventSender::gestureEvent):
71         * DumpRenderTree/chromium/EventSender.h:
72         (EventSender):
73
74 2012-03-05  Dirk Pranke  <dpranke@chromium.org>
75
76         flakiness dashboard doesn't display baselines for virtual tests correctly
77         https://bugs.webkit.org/show_bug.cgi?id=80341
78
79         Reviewed by Ojan Vafai.
80
81         If the test is part of a virtual test suite, we need to look for
82         baselines in the underlying fallback path for the actual test
83         being run, as well as baselines for the virtual version.
84
85         This patch adds code to handle both branches and also pulls the
86         mapping of the test suites up into a constant.
87
88         * TestResultServer/static-dashboards/flakiness_dashboard.html:
89         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
90         (testLookupVirtualTestSuite):
91         (testBaseTest):
92
93 2012-03-05  Sheriff Bot  <webkit.review.bot@gmail.com>
94
95         Unreviewed, rolling out r109760.
96         http://trac.webkit.org/changeset/109760
97         https://bugs.webkit.org/show_bug.cgi?id=80320
98
99         Caused many GTK+ tests to crash (Requested by mrobinson on
100         #webkit).
101
102         * gtk/jhbuild.modules:
103
104 2012-03-05  Charlie Reis  <creis@chromium.org>
105
106         [chromium] Pass WebNavigationPolicy to WebViewClient::createView
107         https://bugs.webkit.org/show_bug.cgi?id=80057
108
109         Reviewed by Darin Fisher.
110
111         * DumpRenderTree/chromium/WebViewHost.cpp:
112         (WebViewHost::createView):
113         * DumpRenderTree/chromium/WebViewHost.h:
114         (WebViewHost):
115
116 2012-03-05  Martin Robinson  <mrobinson@igalia.com>
117
118         [soup] Crash while loading http://www.jusco.cn
119         https://bugs.webkit.org/show_bug.cgi?id=68238
120
121         Reviewed by Philippe Normand.
122
123         * gtk/jhbuild.modules: Bumped the libsoup and glib dependencies
124         in the jhbuild file.
125
126 2012-03-05  Sheriff Bot  <webkit.review.bot@gmail.com>
127
128         Unreviewed, rolling out r109748.
129         http://trac.webkit.org/changeset/109748
130         https://bugs.webkit.org/show_bug.cgi?id=80296
131
132         Made some tests crash, will fix and recommit (Requested by
133         noamr on #webkit).
134
135         * MiniBrowser/qt/main.cpp:
136         (main):
137
138 2012-03-05  Zan Dobersek  <zandobersek@gmail.com>
139
140         [GTK] plugins/netscape-plugin-page-cache-works.html fails
141         https://bugs.webkit.org/show_bug.cgi?id=74409
142
143         Reviewed by Martin Robinson.
144
145         Add support for overriding the page-cache-for-plugins preference
146         through DumpRenderTreeSupport.
147
148         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
149         (booleanFromValue): A helper function to convert a string to boolean.
150         (LayoutTestController::overridePreference):
151
152 2012-03-05  Rob Buis  <rbuis@rim.com>
153
154         [BlackBerry] Update Tools/DumpRenderTree
155         https://bugs.webkit.org/show_bug.cgi?id=80287
156
157         Reviewed by Antonio Gomes.
158
159         Update so we are sure we can build our implementation of DRT.
160
161         * DumpRenderTree/DumpRenderTree.h: include DumpRenderTreeBlackBerry.h.
162         * DumpRenderTree/PixelDumpSupport.cpp: include PixelDumpSupportBlackBerry.h.
163         * DumpRenderTree/blackberry/AccessibilityControllerBlackBerry.cpp:
164         (AccessibilityController::addNotificationListener): add missing hook.
165         (AccessibilityController::removeNotificationListener): add missing hook.
166         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
167         (AccessibilityUIElement::isSelectedOptionActive): add missing hook.
168         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
169         (LayoutTestController::setMockSpeechInputDumpRect): add missing hook.
170         (LayoutTestController::simulateDesktopNotificationClick): add missing hook.
171
172 2012-03-05  No'am Rosenthal  <noam.rosenthal@nokia.com>
173
174         [Qt] [WK2] Support threaded renderer in WK2
175         https://bugs.webkit.org/show_bug.cgi?id=76661
176
177         Remove the QML_NO_THREADED_RENDERER environment variable from MiniBrowser.
178
179         Reviewed by Kenneth Rohde Christiansen.
180
181         * MiniBrowser/qt/main.cpp:
182         (main):
183
184 2012-03-05  Alexander Færøy  <alexander.faeroy@nokia.com>
185
186         Unreviewed. Add myself to committer list.
187
188         * Scripts/webkitpy/common/config/committers.py:
189
190 2012-03-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
191
192         [Qt] Use config test to determine if the compiler supports -MD
193
194         We used to assume that unix systems building against Qt5 would have
195         a compiler that supported -MD. Although this was usually the case,
196         we failed to take into account broken tools for distributed builds
197         (e.g. teambuilder or icecream) which would end up producing .d files
198         in the root of the build dir instead of along-side the object file.
199
200         Now that we use a config-test to determine the support, we'll capture
201         those cases, unless distributed builds are enabled after the initial
202         build-webkit run.
203
204         Reviewed by Csaba Osztrogonác.
205
206         * Tools.pro:
207         * qmake/config.tests/gccdepends/empty.cpp: Added.
208         * qmake/config.tests/gccdepends/gccdepends.pro: Added.
209         * qmake/mkspecs/features/default_pre.prf:
210         * qmake/mkspecs/features/features.prf:
211         * qmake/mkspecs/features/unix/default_pre.prf:
212         * qmake/sync.profile:
213
214 2012-03-05  Csaba Osztrogonác  <ossy@webkit.org>
215
216         Qt API test buildstep throws exception after buildmaster update
217         https://bugs.webkit.org/show_bug.cgi?id=80249
218
219         Reviewed by Zoltan Herczeg.
220
221         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Disable API tests on the Qt bot temporarily.
222         (BuildAndTestFactory.__init__):
223
224 2012-03-04  Martin Robinson  <mrobinson@igalia.com>
225
226         [GTK] Unit tests are noisy when run under jhbuild
227         https://bugs.webkit.org/show_bug.cgi?id=80241
228
229         Reviewed by Philippe Normand.
230
231         Force the 'memory' backend in GSettings so that each unit
232         test doesn't produce a warning when it's forced to fall back
233         to the 'memory' backend.
234
235         * Scripts/run-gtk-tests:
236         (TestRunner.run): Force the 'memory' backend.
237
238 2012-03-04  Martin Robinson  <mrobinson@igalia.com>
239
240         [GTK] "Console: undefined @0: ReferenceError: Can't find variable: WebInspector" during testwebinspector
241         https://bugs.webkit.org/show_bug.cgi?id=80235
242
243         Reviewed by Philippe Normand.
244
245         * Scripts/run-gtk-tests:
246         (TestRunner.run): Use the WEBKIT_INSPECTOR_PATH environment variable so that
247         inspector resources path determination is shared by all tests.
248
249 2012-03-04  Martin Robinson  <mrobinson@igalia.com>
250
251         [GTK] REGRESSION: r108278 broke some tests that expect focus
252         https://bugs.webkit.org/show_bug.cgi?id=79084
253
254         Reviewed by Philippe Normand.
255
256         Grab focus when dumping test results and also when sending
257         events. During the course of testing, the WebView may lose
258         focus and this seems to snap it back when tests demand it.
259
260         * DumpRenderTree/gtk/DumpRenderTree.cpp:
261         (dump): Grab focus.
262         * DumpRenderTree/gtk/EventSender.cpp:
263         (dispatchEvent): Ditto.
264
265 2012-03-04  Charles Wei  <charles.wei@torchmobile.com.cn>
266
267         Unreviewed, Add myself to committer list.
268         https://bugs.webkit.org/show_bug.cgi?id=80232
269
270         * Scripts/webkitpy/common/config/committers.py:
271
272 2012-03-04  Anders Carlsson  <andersca@apple.com>
273
274         Newer versions of clang fail to compile WebKit.
275
276         Fix build.
277
278         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
279         (descriptionOfValue):
280         (AccessibilityUIElement::rowIndexRange):
281         (AccessibilityUIElement::columnIndexRange):
282         (AccessibilityUIElement::selectedTextRange):
283         * DumpRenderTree/mac/EditingDelegate.mm:
284         (-[DOMRange dump]):
285         * DumpRenderTree/mac/PolicyDelegate.mm:
286         (-[PolicyDelegate webView:unableToImplementPolicyWithError:frame:]):
287         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
288         (-[NSError _drt_descriptionSuitableForTestResult]):
289         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
290         (WTR::descriptionOfValue):
291         (WTR::AccessibilityUIElement::rowIndexRange):
292         (WTR::AccessibilityUIElement::columnIndexRange):
293         (WTR::AccessibilityUIElement::selectedTextRange):
294
295 2012-03-03  Simon Hausmann  <simon.hausmann@nokia.com>
296
297         [Qt] Fix static_libs_as_shared build
298         https://bugs.webkit.org/show_bug.cgi?id=80214
299
300         Reviewed by Tor Arne Vestbø.
301
302         * WebKitTestRunner/qt/main.cpp:
303         (main): Set the correct environment variable for choosing the theme in the
304         web process.
305
306 2012-03-03  Hans Wennborg  <hans@chromium.org>
307
308         Implement Speech JavaScript API
309         https://bugs.webkit.org/show_bug.cgi?id=80019
310
311         Reviewed by Adam Barth.
312
313         Add ENABLE_SCRIPTED_SPEECH.
314
315         * Scripts/build-webkit:
316         * qmake/mkspecs/features/features.prf:
317
318 2012-03-02  Alexey Proskuryakov  <ap@apple.com>
319
320         Fix commit queue, remove duplicate entry.
321
322         * Scripts/webkitpy/common/config/committers.py:
323
324 2012-03-02  Stephen Chenney  <schenney@chromium.org>
325
326         Unreviewed, add myself as a committer
327
328         * Scripts/webkitpy/common/config/committers.py:
329
330 2012-03-02  Ojan Vafai  <ojan@chromium.org>
331
332         Add the Chromium Lion canary bot to the flakiness dashboard.
333         * TestResultServer/static-dashboards/builders.js:
334
335 2012-03-02  Dirk Pranke  <dpranke@chromium.org>
336
337         links for virtual tests are broken in the flakiness dashboard
338         https://bugs.webkit.org/show_bug.cgi?id=80180
339
340         Reviewed by Ojan Vafai.
341
342         * TestResultServer/static-dashboards/flakiness_dashboard.html:
343         (linkHTMLToOpenWindow):
344         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
345         (testLinkHTMLToOpenWindow): added.
346
347 2012-03-02  Philippe Normand  <pnormand@igalia.com>
348
349         [GTK] security/block-test.html baselines differ from mac
350         https://bugs.webkit.org/show_bug.cgi?id=78343
351
352         Reviewed by Martin Robinson.
353
354         Improved the FrameLoader error heuristics to match mac behavior a
355         bit more.
356
357         * DumpRenderTree/gtk/DumpRenderTree.cpp:
358         (pathFromSoupURI): Handle ftp urls the same as http urls.
359         (descriptionSuitableForTestResult): Map WebKitPolicyError to WebKitErrorDomain.
360
361 2012-03-02  Andras Becsi  <andras.becsi@nokia.com>
362
363         [Qt][WK2] Fix typo in patch committed in r109575
364
365         Unreviewed typo fix.
366
367         * MiniBrowser/qt/MiniBrowserApplication.cpp:
368         (MiniBrowserApplication::notify): Cache the position
369         in floating point coordinates.
370
371 2012-03-02  Andras Becsi  <andras.becsi@nokia.com>
372
373         [Qt][WK2] Infinite loop on history navigation, when panning
374         https://bugs.webkit.org/show_bug.cgi?id=79119
375
376         Reviewed by Simon Hausmann.
377
378         Make the touch mocking more robust by creating touch events
379         directly and sending them synchronously to the browser window.
380         If the sent touch event was not accepted we propagate the
381         original mouse event to its target.
382         This way we make sure we only send either a touch or a mouse
383         event and do not end up in an infinite loop between our mocking
384         code and the Qt5 automatic mouse event synthesizing.
385
386         * MiniBrowser/qt/BrowserWindow.cpp:
387         (BrowserWindow::updateVisualMockTouchPoints):
388         * MiniBrowser/qt/BrowserWindow.h:
389         (BrowserWindow):
390         * MiniBrowser/qt/MiniBrowserApplication.cpp:
391         (touchRectForPosition):
392         (MiniBrowserApplication::notify):
393         (MiniBrowserApplication::sendTouchEvent):
394         * MiniBrowser/qt/MiniBrowserApplication.h:
395         (MiniBrowserApplication):
396
397 2012-03-02  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
398
399         [Qt] Use 'all' as default target when debug_and_release is in effect
400
401         When debug_and_release is enabled, in combination with build_all,
402         qmake will generate an aggregate makefile that calls make on both
403         the debug and the release makefiles, but with the 'all' target.
404
405         In this case we can't use 'first' as the default target, as the
406         extra targets would then not be run, so we append extra targets
407         to 'all' instead.
408
409         Reviewed by Simon Hausmann.
410
411         * qmake/mkspecs/features/default_post.prf:
412
413 2012-03-02  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
414
415         [Qt] Make sure activeBuildConfig() returns the right config
416
417         Using isActiveConfig fails, as that only checks if the given
418         argument is in CONFIG, not the order.
419
420         Reviewed by Simon Hausmann.
421
422         * qmake/mkspecs/features/functions.prf:
423
424 2012-03-02  Simon Hausmann  <simon.hausmann@nokia.com>
425
426         [Qt] Fix tests run with WTR not using QStyle theme
427         https://bugs.webkit.org/show_bug.cgi?id=80147
428
429         Reviewed by Csaba Osztrogonác.
430
431         * WebKitTestRunner/qt/main.cpp:
432         (main): Set environment variable for web process to use QStyle theme.
433
434 2012-03-02  Philippe Normand  <pnormand@igalia.com>
435
436         Unreviewed, remove debug print call.
437
438         * DumpRenderTree/gtk/DumpRenderTree.cpp:
439         (descriptionSuitableForTestResult):
440
441 2012-03-02  Robert Kroeger  <rjkroege@chromium.org>
442
443         Updated EventSender to send complete gesture events.
444         https://bugs.webkit.org/show_bug.cgi?id=80075
445
446         Reviewed by Adam Barth.
447
448         * DumpRenderTree/chromium/EventSender.cpp:
449         (EventSender::gestureEvent): set additional parameters in sent events.
450
451 2012-03-01  Kalev Lember  <kalevlember@gmail.com>
452
453         WebKitTestRunner: Explicitly include unistd.h for gcc 4.7
454         https://bugs.webkit.org/show_bug.cgi?id=80033
455
456         Reviewed by Gustavo Noronha Silva.
457
458         GCC 4.7 no longer includes unistd.h from most of the standard C++
459         header files, so we need to explicitly include it for getcwd().
460
461         * WebKitTestRunner/TestInvocation.cpp: Make sure unistd.h gets included
462         not only on Mac, but on all Unix platforms.
463
464 2012-03-01  Dirk Pranke  <dpranke@chromium.org>
465
466         Actually look at the args in driver_input :(.
467
468         Unreviewed, build fix.
469
470         * Scripts/webkitpy/layout_tests/port/chromium.py:
471         (ChromiumDriver.run_test):
472
473 2012-03-01  Dirk Pranke  <dpranke@chromium.org>
474
475         Fix typo in flag used to run gpu virtual suites.
476
477         Unreviewed, build fix.
478
479         * Scripts/webkitpy/layout_tests/port/chromium.py:
480         (ChromiumPort.virtual_test_suites):
481
482 2012-03-01  Adam Barth  <abarth@webkit.org>
483
484         Unreviewed, rolling out r109317.
485         http://trac.webkit.org/changeset/109317
486
487         Let's try watchlists again now that we're using a pure git
488         working copy
489
490         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
491         (StyleQueueTask.run):
492         * Scripts/webkitpy/tool/commands/queues_unittest.py:
493
494 2012-03-01  Dirk Pranke  <dpranke@chromium.org>
495
496         webkitpy: test_run_test_pause_before_testing is failing after r109482
497         https://bugs.webkit.org/show_bug.cgi?id=80084
498
499         Unreviewed, build fix.
500
501         Fixes the test string compare to ignore the time spent running
502         the tests.
503
504         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
505         (test_run_test_pause_before_testing):
506
507 2012-03-01  Dirk Pranke  <dpranke@chromium.org>
508
509         nrwt: virtual tests aren't being run
510         https://bugs.webkit.org/show_bug.cgi?id=80083
511
512         Reviewed by Eric Seidel.
513
514         If we tried to run all of the tests by default (and
515         didn't specify any paths), the virtual tests weren't
516         picked up.
517
518         * Scripts/webkitpy/layout_tests/port/base.py:
519         (Port._virtual_tests):
520         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
521         (PortTest.test_tests):
522         * Scripts/webkitpy/layout_tests/port/test.py:
523         (TestPort.virtual_test_suites):
524
525 2012-03-01  Ryosuke Niwa  <rniwa@webkit.org>
526
527         run-perf-tests should report the test runtime
528         https://bugs.webkit.org/show_bug.cgi?id=80078
529
530         Reviewed by Hajime Morita.
531
532         Record and output the aggreated test run time.
533
534         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
535         (PerfTestsRunner._run_single_test):
536
537 2012-03-01  Michael Nordman  <michaeln@google.com>
538
539         [chromium] Use webkit_support to create session storage namespaces in DRT.
540         https://bugs.webkit.org/show_bug.cgi?id=79933
541
542         Reviewed by Tony Chang.
543
544         * DumpRenderTree/chromium/WebViewHost.cpp:
545         (WebViewHost::createSessionStorageNamespace):
546
547 2012-03-01  Dirk Pranke  <dpranke@chromium.org>
548
549         nrwt: test_isfile, test_isdir, and test_exists don't work for virtual tests
550         https://bugs.webkit.org/show_bug.cgi?id=80048
551
552         Reviewed by Adam Barth.
553
554         * Scripts/webkitpy/layout_tests/port/base.py:
555         (Port.test_isfile):
556         (Port.test_isdir):
557         (Port):
558         (Port.test_exists):
559         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
560         (PortTest.test_test_exists):
561         (PortTest):
562         (PortTest.test_test_isfile):
563         (PortTest.test_test_isdir):
564         * Scripts/webkitpy/layout_tests/port/test.py:
565         (TestPort.virtual_test_suites):
566         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
567         (MainTest.test_virtual):
568
569 2012-03-01  Kalev Lember  <kalevlember@gmail.com>
570
571         [GTK] Avoid building any parts of WebKitTestRunner when WK2 is disabled
572         https://bugs.webkit.org/show_bug.cgi?id=80031
573
574         Reviewed by Gustavo Noronha Silva.
575
576         Only build the libTestRunnerInjectedBundle.la convenience library when
577         ENABLE_WEBKIT2 is defined.
578
579         * WebKitTestRunner/GNUmakefile.am:
580
581 2012-03-01  Philippe Normand  <pnormand@igalia.com>
582
583         Unreviewed, second attempt to fix GTK NRWT after r109242.
584
585         * Scripts/webkitpy/layout_tests/port/gtk.py:
586         (GtkDriver._start):
587
588 2012-03-01  Philippe Normand  <pnormand@igalia.com>
589
590         Unreviewed, GTK NRWT build fix attempt after r109242.
591
592         * Scripts/webkitpy/layout_tests/port/gtk.py:
593         (GtkDriver._start):
594
595 2012-03-01  Kentaro Hara  <haraken@chromium.org>
596
597         REGRESSION(r109036): run-bindings-tests fails because resolve-supplemental.pl was renamed
598         https://bugs.webkit.org/show_bug.cgi?id=80008
599
600         Reviewed by Adam Barth.
601
602         In r109036, I forgot to rename "resolve-supplemental.pl" in run-bindings-tests
603         to "preprocess-idls.pl". This patch renames it.
604
605         Test: Confirm that run-bindings-tests runs.
606
607         * Scripts/webkitpy/bindings/main.py:
608         (BindingsTests.generate_supplemental_dependency):
609
610 2012-02-29  Simon Hausmann  <simon.hausmann@nokia.com>
611
612         [Qt][WK2] QQuickWebView::event should lookup faster which events QQuickWebPage can handle
613         https://bugs.webkit.org/show_bug.cgi?id=78047
614
615         Reviewed by Kenneth Rohde Christiansen.
616
617         Send events for the webview through the QQuickCanvas instead of directly to the item. Direct
618         sending to the item requires the QObject::event re-implementation to dispatch to the correct
619         event handling function. However QQuickItem::event doesn't do that. Instead QQuickCanvas calls
620         the event handlers directly, and with the removal of our own dispatching we need to go through
621         that code path.
622
623         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
624         (WTR::PlatformWebView::sendEvent):
625         (WTR::PlatformWebView::postEvent):
626
627 2012-02-29  Adam Barth  <abarth@webkit.org>
628
629         Disable watchlist.  It's been spamming CCs.
630
631         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
632         (StyleQueueTask.run):
633         * Scripts/webkitpy/tool/commands/queues_unittest.py:
634
635 2012-02-29  Dirk Pranke  <dpranke@chromium.org>
636
637         need to clone the gpu baselines and expectations into the new "virtual" dir
638         https://bugs.webkit.org/show_bug.cgi?id=79956
639
640         Reviewed by Adam Barth.
641
642         * Scripts/webkitpy/layout_tests/port/chromium.py:
643         (ChromiumPort.virtual_test_suites):
644
645 2012-02-29  Mark Rowe  <mrowe@apple.com>
646
647         Switch to using json rather than simplejson now that the master is using Python 2.7.
648
649         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
650         (loadBuilderConfig):
651
652 2012-02-29  David Levin  <levin@chromium.org>
653
654         [chromium] Add the ability to turn off autoresize.
655         https://bugs.webkit.org/show_bug.cgi?id=77452
656
657         Reviewed by Darin Fisher.
658
659         * DumpRenderTree/chromium/LayoutTestController.cpp:
660         (LayoutTestController::LayoutTestController): Expose a way to turn off auto-resize.
661         (LayoutTestController::enableAutoResizeMode): Ditto and adjust to new WebKit api.
662         (LayoutTestController::disableAutoResizeMode):  Ditto.
663         * DumpRenderTree/chromium/LayoutTestController.h: Ditto.
664
665 2012-02-29  Dirk Pranke  <dpranke@chromium.org>
666
667         nrwt: make --print trace work with virtual tests
668         https://bugs.webkit.org/show_bug.cgi?id=79952
669
670         Reviewed by Adam Barth.
671
672         * Scripts/webkitpy/layout_tests/views/printing.py:
673         (Printer._print_test_trace):
674         (Printer._print_baseline):
675
676 2012-02-28  Brian Weinstein  <bweinstein@apple.com>
677
678         WebKit2: didNewFirstVisuallyNonEmptyLayout should be sent to injected bundle
679         https://bugs.webkit.org/show_bug.cgi?id=79849
680
681         Reviewed by Beth Dakin.
682
683         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
684         (WTR::InjectedBundlePage::InjectedBundlePage): Add an entry to the struct.
685
686 2012-02-29  Lucas Forschler  <lforschler@apple.com>
687
688         Removed unused Apple buildslaves from the master configuration
689         https://bugs.webkit.org/show_bug.cgi?id=79925
690
691         Reviewed by Stephanie Lewis.
692
693         * BuildSlaveSupport/build.webkit.org-config/config.json:
694
695 2012-02-29  Dirk Pranke  <dpranke@chromium.org>
696
697         nrwt: implement simple 'virtual test suite' support
698         https://bugs.webkit.org/show_bug.cgi?id=79737
699
700         Reviewed by Adam Barth.
701
702         Add very basic support for 'virtual test suites' to NRWT:
703         a virtual suite is a directory that may contain new baselines,
704         contains a pointer to a "base" directory of tests, and an
705         optional list of command line arguments to pass to DRT;
706         it gives us a way to run all of the tests in a given directory
707         multiple times with multiple (potentially differing) sets of
708         results and baselines.
709
710         This patch implements the support needed for this feature, and
711         some basic tests, but no actual port will use the feature yet.
712
713         This is probably the simplest implementation possible - the
714         list of virtual suites will be hard-coded into the port's
715         implementation. One can imagine a more data-driven approach
716         where the suite instructions are stored in a manifest file
717         either in LayoutTests (all suites in one file), or per-port,
718         or per-directory. If this feature ends up being useful we
719         should probably add something like that so people don't have
720         to hunt around in the code to add suites.
721
722         * Scripts/webkitpy/layout_tests/port/base.py:
723         (Port.__init__):
724         (Port.expected_filename):
725         (Port.tests):
726         (Port):
727         (Port._real_tests):
728         (Port._driver_class):
729         (Port.virtual_test_suites):
730         (Port.virtual_suite):
731         (Port.virtual_suite.VirtualTestSuite):
732         (Port.virtual_suite.VirtualTestSuite.__init__):
733         (Port.virtual_suite.VirtualTestSuite.__repr__):
734         (Port.populated_virtual_test_suites):
735         (Port._virtual_tests):
736         (Port.lookup_virtual_test_base):
737         (Port.lookup_virtual_test_args):
738         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
739         (PortTest.test_find_with_skipped_directories):
740         * Scripts/webkitpy/layout_tests/port/driver.py:
741         (DriverInput.__init__):
742         (DriverProxy.run_test):
743         * Scripts/webkitpy/layout_tests/port/test.py:
744         (TestPort.virtual_test_suites):
745         (TestDriver.run_test):
746         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
747         (MainTest.test_all):
748         (MainTest.test_virtual):
749
750 2012-02-29  Dirk Pranke  <dpranke@chromium.org>
751
752         nrwt: support more than two drivers in DriverProxy
753         https://bugs.webkit.org/show_bug.cgi?id=79736
754
755         Reviewed by Adam Barth.
756
757         Now that we can support per-test command lines for
758         Drivers, modify DriverProxy to keep a map of running
759         drivers for each needed command-line; this will allow
760         us to transparently maintain a pool of appropriately
761         configured DRTs without having to constantly start and stop
762         them.
763
764         Note that this potentially raises a garbage collection
765         problem - the number of running DRTs will grow with the
766         number of different sets of command line args. For now
767         this is no worse than the current code - if you're running
768         with pixel tests, you will only need one DRT per worker,
769         and if you aren't, you'll need two (one for text-only tests,
770         and one for reftests).
771
772         An alternative would be to only ever have one running driver,
773         and restart the driver as the command line changes, but this
774         might (?) slow down execution in the text-only case - we
775         should benchmark this because it would be simpler and possibly
776         allow us to eliminate DriverProxy altogether.
777
778         * Scripts/webkitpy/layout_tests/port/driver.py:
779         (DriverProxy.__init__):
780         (DriverProxy):
781         (DriverProxy._make_driver):
782         (DriverProxy.run_test):
783         (DriverProxy.has_crashed):
784         (DriverProxy.stop):
785         (DriverProxy.cmd_line):
786         (DriverProxy._cmd_line_as_key):
787
788 2012-02-29  Adrienne Walker  <enne@google.com>
789
790         Unreviewed, add myself as a reviewer
791
792         * Scripts/webkitpy/common/config/committers.py:
793
794 2012-02-29  Greg Billock  <gbillock@google.com>
795
796         Add more tests for web intents
797         https://bugs.webkit.org/show_bug.cgi?id=79527
798
799         Reviewed by Adam Barth.
800
801         * DumpRenderTree/chromium/LayoutTestController.cpp:
802         (LayoutTestController::LayoutTestController):
803         (LayoutTestController::sendWebIntentResponse):
804         * DumpRenderTree/chromium/LayoutTestController.h:
805         (LayoutTestController):
806         * DumpRenderTree/chromium/WebViewHost.h:
807         (WebViewHost):
808         (WebViewHost::currentIntentRequest):
809
810 2012-02-29  Dirk Pranke  <dpranke@chromium.org>
811
812         nrwt: port/Driver needs to support per-test command line args
813         https://bugs.webkit.org/show_bug.cgi?id=79733
814
815         Reviewed by Adam Barth.
816
817         As part of removing the 'gpu' configurations and adding support
818         for 'virtual test suites', the Driver classes need to support
819         per-test command lines (since different tests will need to be
820         run with different command line options).
821
822         The per-test args are not yet used, so this change should have
823         no visible effects and need no additional testing.
824
825         * Scripts/webkitpy/layout_tests/port/base.py:
826         (Port.driver_cmd_line):
827         * Scripts/webkitpy/layout_tests/port/chromium.py:
828         (ChromiumDriver.cmd_line):
829         (ChromiumDriver._start):
830         (ChromiumDriver.start):
831         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
832         (ChromiumDriverTest.test_two_drivers.MockDriver.cmd_line):
833         (ChromiumDriverTest):
834         (ChromiumDriverTest.test_two_drivers):
835         * Scripts/webkitpy/layout_tests/port/driver.py:
836         (Driver.cmd_line):
837         (DriverProxy.__init__):
838         (DriverProxy.start):
839         (DriverProxy.cmd_line):
840         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
841         (DriverTest.test_virtual_driver_methods):
842         * Scripts/webkitpy/layout_tests/port/gtk.py:
843         (GtkDriver.cmd_line):
844         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
845         * Scripts/webkitpy/layout_tests/port/test.py:
846         (TestPort._path_to_driver):
847         (TestDriver.cmd_line):
848         (TestDriver.start):
849         * Scripts/webkitpy/layout_tests/port/webkit.py:
850         (WebKitDriver.cmd_line):
851         (WebKitDriver._start):
852         (WebKitDriver.run_test):
853         (WebKitDriver.start):
854         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
855         (WebKitDriverTest.test_no_timeout):
856         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
857         (PerfTestsRunner._run_tests_set):
858         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
859         (test_run_test_pause_before_testing):
860
861 2012-02-29  Dirk Pranke  <dpranke@chromium.org>
862
863         perftestsrunner can call printer.write() after printer.cleanup()
864         https://bugs.webkit.org/show_bug.cgi?id=79872
865
866         Reviewed by Ryosuke Niwa.
867
868         This patch fixes a unittest that was incorrectly calling
869         PerfTestsRunner.run() twice (which led to a weird state in the
870         printer object).
871
872         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
873         (MainTest.test_run_with_upload_json):
874
875 2012-02-29  Balazs Kelemen  <kbalazs@webkit.org>
876
877         [Qt][WK2] WebKitTestRunner should use 480x360 sized view for W3C SVG tests
878         https://bugs.webkit.org/show_bug.cgi?id=76546
879
880         Reviewed by Simon Hausmann.
881
882         Revert the workaround introduced in r107868 and reintroduce
883         the qml binding so we can test the code path that we are more
884         interested in. The reason that it did not work before is that
885         we don't have an active platform window which we now workaround
886         by propagating the resize through QWindowSystemInterface.
887
888         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
889         (WTR::WrapperWindow::handleStatusChanged):
890         (WTR::PlatformWebView::resizeTo):
891
892 2012-02-29  Gabor Rapcsanyi  <rgabor@webkit.org>
893
894         [GTK] Small fix for cross compilation to not generate gtkdoc.
895
896         Rubber-stamped by Csaba Osztrogonác.
897
898         * Scripts/webkitdirs.pm:
899         (isCrossCompilation):
900
901 2012-02-28  Lucas Forschler  <lforschler@apple.com>
902
903         Fix a typo in config.json
904         linx -> linux
905         
906         * BuildSlaveSupport/build.webkit.org-config/config.json:
907
908 2012-02-28  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
909
910         [Qt] Allow read/write to the WebView.url property
911         https://bugs.webkit.org/show_bug.cgi?id=77554
912
913         Reviewed by Tor Arne Vestbø.
914
915         Fix MiniBrowser to use WebView.url property and remove WebView.load usage.
916
917         * MiniBrowser/qt/qml/BrowserWindow.qml:
918
919 2012-02-28  Dan Winship  <danw@gnome.org>
920
921         [GTK] make tests explicitly request GSettingsBackendMemory
922         https://bugs.webkit.org/show_bug.cgi?id=79788
923
924         Reviewed by Martin Robinson.
925
926         Explicitly request the fallback memory-based GSettings backend; if
927         other backends are available then we don't want to use them,
928         because they would make tests depend on the user's preferences.
929         And if other backends aren't available, we don't need glib to
930         print a warning about that fact.
931
932         * Scripts/webkitpy/layout_tests/port/gtk.py:
933         (GtkPort.setup_environ_for_server):
934
935 2012-02-28  Sheriff Bot  <webkit.review.bot@gmail.com>
936
937         Unreviewed, rolling out r109110.
938         http://trac.webkit.org/changeset/109110
939         https://bugs.webkit.org/show_bug.cgi?id=79806
940
941         webkitpy makes it too easy to add wkb.ug URLs to ChangeLogs
942         (Requested by aroben on #webkit).
943
944         * Scripts/webkitpy/common/checkout/changelog.py:
945         (parse_bug_id):
946         (parse_bug_id_from_changelog):
947         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
948         * Scripts/webkitpy/common/config/urls.py:
949
950 2012-02-28  Adam Roben  <aroben@webkit.org>
951
952         Add my new email address
953
954         Fixes <http://wkb.ug/79797> Adam Roben's email address in webkitpy is soon to be incorrect
955
956         Reviewed by Anders Carlsson.
957
958         * Scripts/webkitpy/common/config/committers.py:
959
960 2012-02-28  Adam Roben  <aroben@apple.com>
961
962         Teach webkitpy about wkb.ug URLs
963
964         Fixes <http://wkb.ug/79799> webkit-patch can't find bug numbers from ChangeLog entries that
965         use wkb.ug URLs
966
967         Reviewed by Anders Carlsson.
968
969         * Scripts/webkitpy/common/checkout/changelog.py:
970         (parse_bug_id):
971         (parse_bug_id_from_changelog):
972         Fall back to the tiny URL format if neither the short nor long URL formats work.
973
974         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
975         (ChangeLogTest.test_parse_bug_id_from_changelog): Added tests for the above changes.
976
977         * Scripts/webkitpy/common/config/urls.py: Added bug_url_tiny, which can be used to match
978         wkb.ug URLs.
979
980 2012-02-28  János Badics  <dicska@gmail.com>
981
982         [Qt] build-webkit does not detect the number of CPUs
983         https://bugs.webkit.org/show_bug.cgi?id=76445
984
985         Based on Seo Sanghyeon's work (modification:
986         Automatically determine the number of CPUs for make
987         only if -j make argument haven't already been specified.)
988
989         Reviewed by Csaba Osztrogonác.
990
991         * Scripts/webkitdirs.pm:
992         (buildQMakeProjects):
993
994 2012-02-28  Kent Tamura  <tkent@chromium.org>
995
996         Update a pattern for forms files of watchlist
997         https://bugs.webkit.org/show_bug.cgi?id=79767
998
999         Reviewed by Kentaro Hara.
1000
1001         * Scripts/webkitpy/common/config/watchlist:
1002         Catches the following files with the "Forms" pattern.
1003         - HTMLDatListElement.*
1004         - HTMLKeygenElement.*
1005         - HTMLLegendElement.*
1006         - HTMLOutputElement.*
1007         - FormAssociatedElement.*
1008         - SliderThumbElement.*
1009         - TextControlInnerElements.*
1010         - RenderFileUploadControl.*
1011
1012 2012-02-27  Sheriff Bot  <webkit.review.bot@gmail.com>
1013
1014         Unreviewed, rolling out r109041.
1015         http://trac.webkit.org/changeset/109041
1016         https://bugs.webkit.org/show_bug.cgi?id=79741
1017
1018         Broke Chromium Win build (Requested by bashi on #webkit).
1019
1020         * DumpRenderTree/chromium/LayoutTestController.cpp:
1021         (LayoutTestController::LayoutTestController):
1022         * DumpRenderTree/chromium/LayoutTestController.h:
1023         (LayoutTestController):
1024         * DumpRenderTree/chromium/WebViewHost.h:
1025
1026 2012-02-27  James Robinson  <jamesr@chromium.org>
1027
1028         [chromium] Remove media tests from ChromiumGpu configurations
1029         https://bugs.webkit.org/show_bug.cgi?id=79720
1030
1031         Reviewed by Adam Barth.
1032
1033         We no longer need to run the media/ tests in both GPU and non-GPU configurations since we can exercise the GPU
1034         composited playback path via tests in the compositing/ directory.
1035
1036         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1037         (_default_tests_paths):
1038         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1039         (ChromiumGpuTest.test_default_tests_paths):
1040         (ChromiumGpuTest.test_test_files):
1041
1042 2012-02-27  Dirk Pranke  <dpranke@chromium.org>
1043
1044         nrwt: log multiline stderr/crash output properly
1045         https://bugs.webkit.org/show_bug.cgi?id=79722
1046
1047         Reviewed by Adam Barth.
1048
1049         This cleans up some nits in the log output to make things
1050         slightly easier to read (every line gets timestamped, etc.).
1051
1052         Also tweaks the log message for pixel hash mismatches.
1053
1054         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1055         (SingleTestRunner._handle_error):
1056         (SingleTestRunner._compare_image):
1057
1058 2012-02-27  Ryosuke Niwa  <rniwa@webkit.org>
1059
1060         Touch the master.cfg to force a reconfig.
1061
1062         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1063         (BuildAndTestLeaksFactory):
1064         (NewBuildAndTestFactory):
1065
1066 2012-02-27  Jacky Jiang  <zhajiang@rim.com>
1067
1068         [BlackBerry] Upstream BlackBerry API web page related files
1069         https://bugs.webkit.org/show_bug.cgi?id=74380
1070
1071         Reviewed by Antonio Gomes.
1072
1073         Adapt to the removing of WebPage::mainFrame(), use
1074         DumpRenderTreeSupport::corePage() and its mainFrame() instead.
1075
1076         No new tests as this patch doesn't change behavior.
1077
1078         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
1079         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
1080         (BlackBerry::WebKit::DumpRenderTree::runTests):
1081
1082 2012-02-27  Ryosuke Niwa  <rniwa@webkit.org>
1083
1084         Add Windows and Linux Chromium perf bots
1085         https://bugs.webkit.org/show_bug.cgi?id=79418
1086
1087         Reviewed by Tony Chang.
1088
1089         Add Chromium Win and Linux perf bots. Also replace Chromium Mac by
1090         the dedicated perf bot slave (uses the same hardware).
1091
1092         * BuildSlaveSupport/build.webkit.org-config/config.json:
1093
1094 2012-02-27  Xianzhu Wang  <wangxianzhu@chromium.org>
1095
1096         Undefined variable 'current' when running chromium_android.py
1097         https://bugs.webkit.org/show_bug.cgi?id=79696
1098
1099         Reviewed by Adam Barth.
1100
1101         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1102         (ChromiumAndroidDriver._read_prompt):
1103
1104 2012-02-27  Greg Billock  <gbillock@google.com>
1105
1106         Add more tests for web intents
1107         https://bugs.webkit.org/show_bug.cgi?id=79527
1108
1109         Reviewed by Adam Barth.
1110
1111         * DumpRenderTree/chromium/LayoutTestController.cpp:
1112         (LayoutTestController::LayoutTestController):
1113         (LayoutTestController::sendWebIntentResponse):
1114         * DumpRenderTree/chromium/LayoutTestController.h:
1115         (LayoutTestController):
1116         * DumpRenderTree/chromium/WebViewHost.h:
1117         (WebViewHost):
1118         (WebViewHost::currentIntentRequest):
1119
1120 2012-02-27  Xianzhu Wang  <wangxianzhu@chromium.org>
1121
1122         Chromium-Android layout test script: the adb shell prompt is not always '# '
1123         https://bugs.webkit.org/show_bug.cgi?id=79506
1124
1125         Reviewed by Adam Barth.
1126
1127         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1128         (ChromiumAndroidDriver._start):
1129         (ChromiumAndroidDriver._read_prompt):
1130
1131 2012-02-27  Dan Bernstein  <mitz@apple.com>
1132
1133         Added a test for <rdar://problem/9557598> REGRESSION (WebKit2): Non-activating links sometimes don’t work
1134         https://bugs.webkit.org/show_bug.cgi?id=79607
1135
1136         Reviewed by Adele Peterson.
1137
1138         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
1139         * TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm: Added.
1140         (TestWebKitAPI::AcceptsFirstMouse::url):
1141         (TestWebKitAPI::AcceptsFirstMouse::didLoadURL):
1142         (TestWebKitAPI::AcceptsFirstMouse::runTest):
1143         (TestWebKitAPI::TEST_F):
1144         * TestWebKitAPI/Tests/mac/acceptsFirstMouse.html: Added.
1145
1146 2012-02-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1147
1148         Unreviewed. Fix make distcheck.
1149
1150         * GNUmakefile.am: Fix typo.
1151
1152 2012-02-27  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1153
1154         [Qt] Use USE() macro instead of ENABLE() for using the Qt image decoder
1155
1156         Reviewed by Kenneth Rohde Christiansen..
1157
1158         * qmake/mkspecs/features/features.prf:
1159
1160 2012-02-27  Hao Zheng  <zhenghao@chromium.org>
1161
1162         Add a ChromiumGpuAndroid port.
1163         https://bugs.webkit.org/show_bug.cgi?id=79628
1164
1165         Reviewed by Adam Barth.
1166
1167         Android does have a gpu port, so revert r107697.
1168
1169         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1170         (ChromiumAndroidPort.__init__):
1171         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1172         (ChromiumGpuAndroidPort):
1173         (ChromiumGpuAndroidPort.__init__):
1174         (ChromiumGpuAndroidPort.baseline_search_path):
1175         (ChromiumGpuAndroidPort.default_child_processes):
1176         (ChromiumGpuAndroidPort.tests):
1177         * Scripts/webkitpy/layout_tests/port/factory.py:
1178         (PortFactory):
1179
1180 2012-02-25  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1181
1182         Change Build bot with BuildAndTest bot for EFL port.
1183         https://bugs.webkit.org/show_bug.cgi?id=77518
1184
1185         Reviewed by Ryosuke Niwa.
1186
1187         EFL build bot starts to support layout test.
1188
1189         * BuildSlaveSupport/build.webkit.org-config/config.json:
1190         * BuildSlaveSupport/built-product-archive:
1191         (archiveBuiltProduct):
1192         (extractBuiltProduct):
1193         * BuildSlaveSupport/test-result-archive:
1194         (archiveTestResults):
1195         * Scripts/webkitdirs.pm: Enable SHARED_CORE option when ENABLE_DRT is enable in EFL port.
1196         (generateBuildSystemFromCMakeProject):
1197
1198 2012-02-24  Darin Fisher  <darin@chromium.org>
1199
1200         Add watchlist for ChromiumPlatformApi matching Source/Platform/chromium/public/
1201
1202         Reviewed by James Robinson.
1203
1204         * Scripts/webkitpy/common/config/watchlist:
1205
1206 2012-02-24  Dirk Pranke  <dpranke@chromium.org>
1207
1208         webkitpy: changelog_unittest test_fuzzy_reviewer_match is slow
1209         https://bugs.webkit.org/show_bug.cgi?id=79258
1210
1211         Reviewed by Ryosuke Niwa.
1212
1213         Split the fuzzy matching into separate functions so that they
1214         can be sharded and run in parallel.
1215
1216         Also, fix a bug in the svn_blame_regexp that was causing us
1217         to require ChangeLog lines to have at least one space after the
1218         author, making the code require trailing whitespace in the
1219         changelog in some places (this was making my life harder because
1220         I have my text editor set to strip trailing whitespace in python
1221         files, and that was causing test_parse_log_entries_from_changelog() to fail
1222         when the whitespace on line 275 was removed).
1223
1224         * Scripts/webkitpy/common/checkout/changelog.py:
1225         (ChangeLog):
1226         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1227         (test_fuzzy_reviewer_match__none):
1228         (test_fuzzy_reviewer_match_adam_barth):
1229         (test_fuzzy_reviewer_match_darin_adler_et_al):
1230         (test_fuzzy_reviewer_match_dimitri_glazkov):
1231         (test_fuzzy_reviewer_match_george_staikos):
1232         (test_fuzzy_reviewer_match_mark_rowe):
1233
1234 2012-02-24  Dirk Pranke  <dpranke@chromium.org>
1235
1236         webkitpy: committers_unittest fuzzy matching is really slow
1237         https://bugs.webkit.org/show_bug.cgi?id=79179
1238
1239         Reviewed by Ryosuke Niwa.
1240
1241         Break the fuzzy matching tests into individual routines for
1242         each contributor so that the intent is a little clearer, so
1243         that it's easier to test individual names (and identify
1244         duplicate tests), and so that we can eventually run
1245         them in parallel.
1246
1247         Also, mark most of them as 'integration' tests so that they
1248         can be skipped if we want to go fast (we leave a few as
1249         regular tests for functional coverage).
1250
1251         * Scripts/webkitpy/common/config/committers_unittest.py:
1252         (CommittersTest):
1253         (CommittersTest.test_contributors_by_fuzzy_match):
1254         (CommittersTest.integration_test_contributors__none):
1255         (CommittersTest.integration_test_contributors__none_2):
1256         (CommittersTest.integration_test_contributors__none_3):
1257         (CommittersTest.integration_test_contributors_ada_chan):
1258         (CommittersTest.integration_test_contributors_adele_peterson):
1259         (CommittersTest.integration_test_contributors_alexey_proskuryakov):
1260         (CommittersTest.integration_test_contributors_alice_liu):
1261         (CommittersTest.integration_test_contributors_alp_toker):
1262         (CommittersTest.integration_test_contributors_anders_carlsson):
1263         (CommittersTest.integration_test_contributors_antti_koivisto):
1264         (CommittersTest.integration_test_contributors_beth_dakin):
1265         (CommittersTest.integration_test_contributors_brady_eidson):
1266         (CommittersTest.integration_test_contributors_cameron_zwarich):
1267         (CommittersTest.integration_test_contributors_chris_blumenberg):
1268         (CommittersTest.integration_test_contributors_dan_bernstein):
1269         (CommittersTest.integration_test_contributors_dan_bernstein_2):
1270         (CommittersTest.integration_test_contributors_darin_adler):
1271         (CommittersTest.integration_test_contributors_david_harrison):
1272         (CommittersTest.integration_test_contributors_david_harrison_2):
1273         (CommittersTest.integration_test_contributors_david_hyatt):
1274         (CommittersTest.integration_test_contributors_david_kilzer):
1275         (CommittersTest.integration_test_contributors_don_melton):
1276         (CommittersTest.integration_test_contributors_eric_seidel):
1277         (CommittersTest.integration_test_contributors_geoffrey_garen):
1278         (CommittersTest.integration_test_contributors_greg_bolsinga):
1279         (CommittersTest.integration_test_contributors_holger_freyther):
1280         (CommittersTest.integration_test_contributors_jon_sullivan):
1281         (CommittersTest.integration_test_contributors_jon_honeycutt):
1282         (CommittersTest.integration_test_contributors_joseph_pecoraro):
1283         (CommittersTest.integration_test_contributors_ken_kocienda):
1284         (CommittersTest.integration_test_contributors_kenneth_russell):
1285         (CommittersTest.integration_test_contributors_kevin_decker):
1286         (CommittersTest.integration_test_contributors_kevin_mccullough):
1287         (CommittersTest.integration_test_contributors_lars_knoll):
1288         (CommittersTest.integration_test_contributors_lars_weintraub):
1289         (CommittersTest.integration_test_contributors_maciej_stachowiak):
1290         (CommittersTest.integration_test_contributors_mark_rowe):
1291         (CommittersTest.integration_test_contributors_nikolas_zimmermann):
1292         (CommittersTest.integration_test_contributors_oliver_hunt):
1293         (CommittersTest.integration_test_contributors_rniwa):
1294         (CommittersTest.disabled_integration_test_contributors_simon_fraser):
1295         (CommittersTest.integration_test_contributors_steve_falkenburg):
1296         (CommittersTest.integration_test_contributors_sam_weinig):
1297         (CommittersTest.integration_test_contributors_tim_omernick):
1298         (CommittersTest.integration_test_contributors_timothy_hatcher):
1299         (CommittersTest.integration_test_contributors_tor_arne_vestbo):
1300         (CommittersTest.integration_test_contributors_vicki_murley):
1301         (CommittersTest.integration_test_contributors_zack_rusin):
1302
1303 2012-02-24  Dirk Pranke  <dpranke@chromium.org>
1304
1305         webkitpy: should autoinstall coverage
1306         https://bugs.webkit.org/show_bug.cgi?id=79535
1307
1308         Reviewed by Eric Seidel.
1309
1310         We should automatically print the coverage report after the run, too.
1311
1312         * Scripts/webkitpy/test/main.py:
1313         (Tester._run_tests):
1314         * Scripts/webkitpy/thirdparty/__init__.py:
1315         (AutoinstallImportHook.find_module):
1316         (AutoinstallImportHook._install_coverage):
1317
1318 2012-02-24  Pablo Flouret  <pablof@motorola.com>
1319
1320         Fix copypasta in build-webkit's --vibration option description
1321         https://bugs.webkit.org/show_bug.cgi?id=79528
1322
1323         Reviewed by Andreas Kling.
1324
1325         * Scripts/build-webkit:
1326
1327 2012-02-24  Antonio Gomes  <agomes@rim.com>
1328
1329         Adding myself to ScrollingCoordinator watchlist
1330         https://bugs.webkit.org/show_bug.cgi?id=79525
1331
1332         Reviewed by Rob Buis.
1333
1334         * Scripts/webkitpy/common/config/watchlist:
1335
1336 2012-02-24  Darin Fisher  <darin@chromium.org>
1337
1338         Update watchlist for ChromiumPublicApi to include Platform/chromium/public/
1339
1340         Reviewed by Adam Barth.
1341
1342         * Scripts/webkitpy/common/config/watchlist:
1343
1344 2012-02-24  Dirk Pranke  <dpranke@chromium.org>
1345
1346         webkitpy: config_unittest is sensitive to other tests that might've already run
1347         https://bugs.webkit.org/show_bug.cgi?id=79382
1348
1349         Reviewed by Adam Barth.
1350
1351         If another test runs prior to config_unittest and pokes the
1352         cached configuration, the first test in config_unittest might
1353         fail; the tearDown() will then allow subsequent tests to pass.
1354         Clearing the configuration prior to each test makes things
1355         slightly slower but safer.
1356
1357         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
1358         (ConfigTest.setUp):
1359
1360 2012-02-24  David Kilzer  <ddkilzer@apple.com>
1361
1362         Use xcrun to find compiler paths for Generate Derived Sources build phase script
1363         <http://webkit.org/b/79512>
1364
1365         Reviewed by Dan Bernstein.
1366
1367         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1368         (Generate Derived Sources): Use xcrun to find the path to the
1369         compiler since that works on both iOS and OS X.
1370
1371 2012-02-24  James Robinson  <jamesr@chromium.org>
1372
1373         Create a watchlist for ScrollingCoordinator changes
1374         https://bugs.webkit.org/show_bug.cgi?id=79511
1375
1376         Reviewed by Anders Carlsson.
1377
1378         * Scripts/webkitpy/common/config/watchlist:
1379
1380 2012-02-24  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
1381
1382         [EFL][DRT] Implement setValueForUser and setAutofilled.
1383         https://bugs.webkit.org/show_bug.cgi?id=79237
1384
1385         Reviewed by Andreas Kling.
1386
1387         Adds missing implementation setValueForUser and setAutofilled to EFL's LayoutTestController.
1388         Those implementations are related with input fields and allow to pass following tests:
1389         fast/forms/onchange-setvalueforuser.html
1390         fast/forms/input-autofilled.html
1391         fast/forms/reset-autofilled.html
1392
1393         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1394         (LayoutTestController::setValueForUser):
1395         (LayoutTestController::setAutofilled):
1396
1397 2012-02-24  Zoltan Horvath  <zoltan@webkit.org>
1398
1399         [Qt] Allow to use WebCore imagedecoders
1400         https://bugs.webkit.org/show_bug.cgi?id=32410
1401
1402         Add ENABLE_QT_IMAGE_DECODER macro, it's enabled by default.
1403
1404         Reviewed by Simon Hausmann.
1405
1406         * qmake/mkspecs/features/features.prf:
1407
1408 2012-02-24  Balazs Kelemen  <kbalazs@webkit.org>
1409
1410         [Qt] Add Qt5 way to force 96 DPI for tests
1411         https://bugs.webkit.org/show_bug.cgi?id=79364
1412
1413         Reviewed by Simon Hausmann.
1414
1415         * DumpRenderTree/qt/main.cpp:
1416         (main):
1417         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1418         (WTR::activateFonts):
1419
1420 2012-02-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1421
1422         [GTK] MiniBrowser should reload the view then the reload button is clicked
1423         https://bugs.webkit.org/show_bug.cgi?id=79472
1424
1425         Reviewed by Philippe Normand.
1426
1427         * MiniBrowser/gtk/BrowserWindow.c:
1428         (reloadCallback): Call webkit_web_view_reload().
1429         (browser_window_init): Connect reload item clicked even to
1430         reloadCallback instead of activateUriEntryCallback.
1431
1432 2012-02-24  Kentaro Hara  <haraken@chromium.org>
1433
1434         Add performance tests for DOM attribute getters and setters
1435         https://bugs.webkit.org/show_bug.cgi?id=79208
1436
1437         Reviewed by Ryosuke Niwa.
1438
1439         We want to allow perf tests to output info messages
1440         that do not affect the test results. To accomplish this,
1441         this patch modifies perftestsrunner.py so that it ignores
1442         a line that starts from "Info:".
1443
1444         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1445         (PerfTestsRunner):
1446
1447 2012-02-24  Andrew Lo  <anlo@rim.com>
1448
1449         [BlackBerry] Enable requestAnimationFrame
1450         https://bugs.webkit.org/show_bug.cgi?id=79408
1451
1452         Enable requestAnimationFrame for BlackBerry.
1453
1454         Reviewed by Rob Buis.
1455
1456         * Scripts/build-webkit:
1457
1458 2012-02-24  Adam Barth  <abarth@webkit.org>
1459
1460         style-queue tries to apply the patch twice
1461         https://bugs.webkit.org/show_bug.cgi?id=79459
1462
1463         Reviewed by Eric Seidel.
1464
1465         Previously, we applied the patch using both apply-patch and
1466         check-style.  This patch introduces a check-style-local to mirror the
1467         apply-watchlist-local, which operates on the current working diff.
1468
1469         This patch also cleans up some other bugs I found by running the queue
1470         locally for a while.  The queue still prints out a slightly
1471         less-than-ideal message on the bugs when it find an error, but it's ok
1472         for now.  We'll need to iterate a bit.
1473
1474         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
1475         (StyleQueueTask.validate):
1476         (StyleQueueTask._check_style):
1477         * Scripts/webkitpy/tool/commands/download.py:
1478         (CheckStyleLocal):
1479         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1480         (EarlyWarningSytemTest._default_expected_stderr):
1481         (EarlyWarningSytemTest._test_testing_ews):
1482         * Scripts/webkitpy/tool/commands/queues.py:
1483         (AbstractReviewQueue.handle_script_error):
1484         (StyleQueue.review_patch):
1485         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1486         * Scripts/webkitpy/tool/commands/queuestest.py:
1487         (QueuesTest.assert_queue_outputs):
1488
1489 2012-02-23  Adam Barth  <abarth@webkit.org>
1490
1491         should_proceed_with_work_item is unused and can be removed
1492         https://bugs.webkit.org/show_bug.cgi?id=79416
1493
1494         Reviewed by Eric Seidel.
1495
1496         We used to use this function to check whether the tree is red.  Now, we
1497         don't use external measures of whether to proceed with work items.
1498         Instead, we analyze them with the idea in mind that the tree might be
1499         red.
1500
1501         * Scripts/webkitpy/tool/bot/queueengine.py:
1502         (QueueEngineDelegate.next_work_item):
1503         (QueueEngine.run):
1504         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
1505         (LoggingDelegate):
1506         (LoggingDelegate.next_work_item):
1507         (RaisingDelegate.process_work_item):
1508         (QueueEngineTest.test_terminating_error):
1509         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1510         (AbstractEarlyWarningSystem.__init__):
1511         * Scripts/webkitpy/tool/commands/queues.py:
1512         (AbstractQueue.next_work_item):
1513         (FeederQueue.next_work_item):
1514         (CommitQueue.next_work_item):
1515         (AbstractReviewQueue.next_work_item):
1516         (StyleQueue.__init__):
1517         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1518         (FeederQueueTest.test_feeder_queue):
1519         (CommitQueueTest.test_commit_queue):
1520         (test_commit_queue_failure):
1521         (test_commit_queue_failure_with_failing_tests):
1522         (test_rollout):
1523         (test_rollout_lands):
1524         (StyleQueueTest.test_style_queue_with_style_exception):
1525         (test_style_queue_with_watch_list_exception):
1526         * Scripts/webkitpy/tool/commands/queuestest.py:
1527         (QueuesTest.assert_queue_outputs):
1528         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1529         (SheriffBot.next_work_item):
1530
1531 2012-02-23  Adrienne Walker  <enne@google.com>
1532
1533         Unreviewed, add Stephen Chenney to committers.py as a contributor.
1534
1535         * Scripts/webkitpy/common/config/committers.py:
1536
1537 2012-02-23  Adam Barth  <abarth@webkit.org>
1538
1539         style-queue logs bogus messages to the QueueStatusServer
1540         https://bugs.webkit.org/show_bug.cgi?id=79424
1541
1542         Reviewed by Eric Seidel.
1543
1544         Copy/paste error.
1545
1546         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
1547         (StyleQueueTask._check_style):
1548         (StyleQueueTask._apply_watch_list):
1549         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1550
1551 2012-02-23  Eric Seidel  <eric@webkit.org>
1552
1553         Use self._filesystem in more places in the SCM classes
1554         https://bugs.webkit.org/show_bug.cgi?id=79415
1555
1556         Reviewed by Adam Barth.
1557
1558         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
1559         (SCMDetectorTest.test_detect_scm_system):
1560         * Scripts/webkitpy/common/checkout/scm/git.py:
1561         (Git.find_checkout_root):
1562         (Git.to_object_name):
1563         * Scripts/webkitpy/common/checkout/scm/scm.py:
1564         (SCM.__init__):
1565         (SCM.in_working_directory):
1566         * Scripts/webkitpy/common/checkout/scm/svn.py:
1567         (SVN.find_uuid):
1568         (SVN.find_checkout_root):
1569
1570 2012-02-23  Sheriff Bot  <webkit.review.bot@gmail.com>
1571
1572         Unreviewed, rolling out r108685.
1573         http://trac.webkit.org/changeset/108685
1574         https://bugs.webkit.org/show_bug.cgi?id=79414
1575
1576         Broke Chromium builds (Requested by enne on #webkit).
1577
1578         * qmake/mkspecs/features/features.prf:
1579
1580 2012-02-23  Adam Barth  <abarth@webkit.org>
1581
1582         style-queue shouldn't spam bugs if it fails to update its working copy
1583         https://bugs.webkit.org/show_bug.cgi?id=79412
1584
1585         Reviewed by Eric Seidel.
1586
1587         This patch moves style-queue over to the new PatchAnalysisTask
1588         infrastructure, which is smarter about retrying patches when update
1589         fails.
1590
1591         * Scripts/webkitpy/common/system/executive_mock.py:
1592         (MockExecutive.run_and_throw_if_fail):
1593         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
1594         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1595         (UnableToApplyPatch):
1596         (UnableToApplyPatch.__init__):
1597         (PatchAnalysisTask.__init__):
1598         * Scripts/webkitpy/tool/bot/stylequeuetask.py: Added.
1599         (StyleQueueTaskDelegate):
1600         (StyleQueueTaskDelegate.parent_command):
1601         (StyleQueueTask):
1602         (StyleQueueTask.validate):
1603         (StyleQueueTask._check_style):
1604         (StyleQueueTask._apply_watch_list):
1605         (StyleQueueTask.run):
1606         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1607         * Scripts/webkitpy/tool/commands/queues.py:
1608         (StyleQueue):
1609         (StyleQueue.should_proceed_with_work_item):
1610         (StyleQueue.review_patch):
1611         (StyleQueue.run_command):
1612         (StyleQueue.command_passed):
1613         (StyleQueue.command_failed):
1614         (StyleQueue.expected_failures):
1615         (StyleQueue.refetch_patch):
1616         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1617         (StyleQueueTest.test_style_queue_with_style_exception):
1618         (test_style_queue_with_watch_list_exception):
1619
1620 2012-02-23  Zoltan Horvath  <zoltan@webkit.org>
1621
1622         [Qt] Allow to use WebCore imagedecoders
1623         https://bugs.webkit.org/show_bug.cgi?id=32410
1624
1625         Add ENABLE_QT_IMAGE_DECODER macro, it's enabled by default.
1626
1627         Reviewed by Simon Hausmann.
1628
1629         * qmake/mkspecs/features/features.prf:
1630
1631 2012-02-23  Eric Seidel  <eric@webkit.org>
1632
1633         Remove old broken find_checkout_root tests now that find_checkout_root is gone
1634         https://bugs.webkit.org/show_bug.cgi?id=79405
1635
1636         Reviewed by Adam Barth.
1637
1638         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py: Added.
1639         (SCMDetectorTest):
1640         (SCMDetectorTest.test_find_checkout_root):
1641         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1642         (SVNTestRepository.tear_down):
1643
1644 2012-02-23  Michael Brüning  <michael.bruning@nokia.com>
1645
1646         [Qt][WK2] Implement proxy authentication dialog.
1647         https://bugs.webkit.org/show_bug.cgi?id=79350
1648
1649         Reviewed by Simon Hausmann.
1650
1651         * MiniBrowser/qt/MiniBrowser.qrc:
1652         * MiniBrowser/qt/qml/BrowserWindow.qml:
1653         * MiniBrowser/qt/qml/ProxyAuthenticationDialog.qml: Added.
1654
1655 2012-02-23  Kevin Ollivier  <kevino@theolliviers.com>
1656
1657         [wx] Build fix, add recently added source dirs.
1658
1659         * waf/build/settings.py:
1660
1661 2012-02-23  Simon Hausmann  <simon.hausmann@nokia.com>
1662
1663         [Qt] Add support for touch cancellation
1664         https://bugs.webkit.org/show_bug.cgi?id=79348
1665
1666         Reviewed by Kenneth Rohde Christiansen.
1667
1668         Added straight-forward touch cancellation event sending to Qt WK1 DRT
1669         and WK2 WTR.
1670
1671         * DumpRenderTree/qt/EventSenderQt.cpp:
1672         (EventSender::touchCancel):
1673         (EventSender::cancelTouchPoint):
1674         * DumpRenderTree/qt/EventSenderQt.h:
1675         (EventSender):
1676         * WebKitTestRunner/EventSenderProxy.h:
1677         (EventSenderProxy):
1678         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
1679         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1680         (WTR::EventSendingController::touchCancel):
1681         (WTR):
1682         (WTR::EventSendingController::cancelTouchPoint):
1683         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1684         (EventSendingController):
1685         * WebKitTestRunner/TestController.cpp:
1686         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
1687         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
1688         (WTR::EventSenderProxy::touchCancel):
1689         (WTR):
1690         (WTR::EventSenderProxy::cancelTouchPoint):
1691
1692 2012-02-23  Sheriff Bot  <webkit.review.bot@gmail.com>
1693
1694         Unreviewed, rolling out r108626.
1695         http://trac.webkit.org/changeset/108626
1696         https://bugs.webkit.org/show_bug.cgi?id=79370
1697
1698         broke qt-wk2 bot, somehow the workaround does not work on the
1699         bot (Requested by Ossy on #webkit).
1700
1701         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1702         (WTR::WrapperWindow::handleStatusChanged):
1703         (WTR::PlatformWebView::resizeTo):
1704
1705 2012-02-23  ChangSeok Oh  <shivamidow@gmail.com>
1706
1707         [GTK] DRT doesn't support scheduleAsynchronousKeyDown.
1708         https://bugs.webkit.org/show_bug.cgi?id=78481
1709
1710         Reviewed by Gustavo Noronha Silva.
1711
1712         Extracted shareable code from keyDownCallback and then added createKeyPressEvent
1713         to create gdk press key event.
1714         Added sendKeyDown and sendAsynchronousKeyDown to evaluate keyDown event directly
1715         and asynchronously. Eventually, sendAsynchronousKeyDown calls sendKeyDown.
1716
1717         * DumpRenderTree/gtk/EventSender.cpp:
1718         (scheduleAsynchronousClickCallback):
1719         (createKeyPressEvent):
1720         (sendKeyDown):
1721         (keyDownCallback):
1722         (sendAsynchronousKeyDown):
1723         (scheduleAsynchronousKeyDownCallback):
1724
1725 2012-02-23  Balazs Kelemen  <kbalazs@webkit.org>
1726
1727         [Qt][WK2] WebKitTestRunner should use 480x360 sized view for W3C SVG tests
1728         https://bugs.webkit.org/show_bug.cgi?id=76546
1729
1730         Reviewed by Simon Hausmann.
1731
1732         Co-authored with Simon Hausmann.
1733
1734         Revert the workaround introduced in r107868 and reintroduce
1735         the qml binding so we can test the code path that we are more
1736         interested in. The reason that it did not work before is that
1737         we don't have an active platform window which we now workaround
1738         by propagating the resize through QWindowSystemInterface.
1739
1740         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1741         (WTR::WrapperWindow::handleStatusChanged):
1742         (WTR::PlatformWebView::resizeTo):
1743
1744 2012-02-23  Sheriff Bot  <webkit.review.bot@gmail.com>
1745
1746         Unreviewed, rolling out r108577.
1747         http://trac.webkit.org/changeset/108577
1748         https://bugs.webkit.org/show_bug.cgi?id=79359
1749
1750         It doesn't work as expected (Requested by Ossy on #webkit).
1751
1752         * DumpRenderTree/qt/EventSenderQt.cpp:
1753         (EventSender::postEvent):
1754         * DumpRenderTree/qt/EventSenderQt.h:
1755         (EventSender):
1756
1757 2012-02-23  Philippe Normand  <pnormand@igalia.com>
1758
1759         [GTK] FullScreen signals
1760         https://bugs.webkit.org/show_bug.cgi?id=76181
1761
1762         Reviewed by Martin Robinson.
1763
1764         Use the two new entering/leaving fullscreen signals to hide/show
1765         the tool bar, the status bar and ask the user's permission before
1766         entering fullscreen.
1767
1768         * GtkLauncher/main.c:
1769         (webViewFullscreenMessageWindowClose):
1770         (webViewWindowStateEvent):
1771         (hide_widget):
1772         (show_widget):
1773         (webViewEnteringFullScreen):
1774         (webViewLeavingFullScreen):
1775         (createBrowser):
1776         (createWindow):
1777
1778 2012-02-22  Dongwoo Im  <dw.im@samsung.com>
1779
1780         [EFL] Fix to launch the EWebLauncher using the script, run-launcher.
1781         https://bugs.webkit.org/show_bug.cgi?id=79076
1782
1783         Reviewed by Andreas Kling.
1784
1785         * Scripts/webkitdirs.pm: Fix the path of libewebkit.so.
1786         (builtDylibPathForName):
1787
1788 2012-02-22  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
1789
1790         [Qt] Add eventSender.gestureTap
1791         https://bugs.webkit.org/show_bug.cgi?id=66173
1792
1793         Reviewed by Kenneth Rohde Christiansen.
1794
1795         * DumpRenderTree/qt/EventSenderQt.cpp:
1796         (EventSender::gestureTap):
1797         * DumpRenderTree/qt/EventSenderQt.h:
1798
1799 2012-02-22  Brady Eidson  <beidson@apple.com>
1800
1801         <rdar://problem/10406044> and https://bugs.webkit.org/show_bug.cgi?id=79279
1802         Synchronous ShouldGoToBackForwardListItem causes lots of WebProcess hangs
1803
1804         Reviewed by Anders Carlsson.
1805
1806         Update our tools to the new form of the PageLoadClient.
1807
1808         * MiniBrowser/mac/BrowserWindowController.m:
1809         (-[BrowserWindowController awakeFromNib]): 
1810
1811         * WebKitTestRunner/TestController.cpp:
1812         (WTR::TestController::initialize):
1813
1814 2012-02-22  Daniel Bates  <dbates@webkit.org>
1815
1816         new-run-webkit-tests shouldn't restore Safari state on Lion when showing results
1817         https://bugs.webkit.org/show_bug.cgi?id=79277
1818
1819         Reviewed by Adam Barth.
1820
1821         Pass command line argument no-saved-state to run-safari to disable Safari
1822         state restoration for the session on OS 10.7.
1823
1824         * Scripts/webkitpy/layout_tests/port/mac.py:
1825         (MacPort.show_results_html_file):
1826         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1827         (test_show_results_html_file):
1828
1829 2012-02-22  Kalev Lember  <kalevlember@gmail.com>
1830
1831         Explicitly include unistd.h in TestNetscapePlugIn for GCC 4.7
1832         https://bugs.webkit.org/show_bug.cgi?id=77759
1833
1834         Reviewed by Tony Chang.
1835
1836         Fixes build with gcc 4.7.
1837
1838         r100432 added the include only for ANDROID; this changes the ifdef to
1839         also cover other unix platforms. On Fedora 17 the gcc 4.7 compiler no
1840         longer implicitly includes unistd.h from standard headers and other
1841         unix platforms are likely to get gcc 4.7 as well in the future.
1842
1843         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1844
1845 2012-02-22  Philippe Normand  <pnormand@igalia.com>
1846
1847         Unreviewed, rolling out r108522.
1848         http://trac.webkit.org/changeset/108522
1849         https://bugs.webkit.org/show_bug.cgi?id=76181
1850
1851         Broke 4 fullscreen tests on GTK.
1852
1853         * GtkLauncher/main.c:
1854         (createBrowser):
1855         (createWindow):
1856
1857 2012-02-20  Philippe Normand  <pnormand@igalia.com>
1858
1859         [GTK] FullScreen signals
1860         https://bugs.webkit.org/show_bug.cgi?id=76181
1861
1862         Reviewed by Martin Robinson.
1863
1864         Use the two new entering/leaving fullscreen signals to hide/show
1865         the tool bar, the status bar and ask the user's permission before
1866         entering fullscreen.
1867
1868         * GtkLauncher/main.c:
1869         (webViewFullscreenMessageWindowClose):
1870         (webViewWindowStateEvent):
1871         (hide_widget):
1872         (show_widget):
1873         (webViewEnteringFullScreen):
1874         (webViewLeavingFullScreen):
1875         (createBrowser):
1876         (createWindow):
1877
1878 2012-02-22  Rob Flack  <flackr@chromium.org>
1879
1880         Update Linux ChromiumOS builders in flakiness dashboard.
1881         https://bugs.webkit.org/show_bug.cgi?id=79238
1882
1883         Reviewed by Ojan Vafai.
1884
1885         * TestResultServer/static-dashboards/builders.js:
1886
1887 2012-02-22  Dirk Pranke  <dpranke@chromium.org>
1888
1889         webkitpy: test_function_length_check_definition_huge_lines is slow
1890         https://bugs.webkit.org/show_bug.cgi?id=79185
1891
1892         Reviewed by Adam Barth.
1893
1894         This test takes ~3 seconds to run, apparently because we're
1895         running a test on a 10,000 line function :). Dropping the
1896         function length to 640 still exercises the code path and
1897         provides a 10x speedup.
1898
1899         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1900         (CppStyleTest):
1901         (CheckForFunctionLengthsTest.test_function_length_check_definition_huge_lines):
1902
1903 2012-02-22  Dirk Pranke  <dpranke@chromium.org>
1904
1905         webkitpy: speed up FileLockTest.test_lock_lifecycle
1906         https://bugs.webkit.org/show_bug.cgi?id=79189
1907
1908         Reviewed by Adam Barth.
1909
1910         The unit test had a second lock trying to acquire a
1911         lock already held, and a hard-coded timeout of one second.
1912         I have changed the timeouts to a tenth of a second (which
1913         is probably still fine) and changed the hard-spin on
1914         the lock to a slow-spin every hundredth of a second.
1915
1916         * Scripts/webkitpy/common/system/file_lock.py:
1917         (FileLock.acquire_lock):
1918         * Scripts/webkitpy/common/system/file_lock_integrationtest.py:
1919         (FileLockTest.setUp):
1920         (FileLockTest.test_stuck_lock):
1921
1922 2012-02-22  Gabor Rapcsanyi  <rgabor@webkit.org>
1923
1924         build-webkit should use environment variable at number of CPU
1925         detection on all platform
1926         https://bugs.webkit.org/show_bug.cgi?id=79227
1927
1928         Reviewed by Martin Robinson.
1929
1930         * Scripts/webkitdirs.pm:
1931         (determineNumberOfCPUs):
1932
1933 2012-02-22  Mihnea Ovidenie  <mihnea@adobe.com>
1934
1935         [Qt] REGRESSION(r108108): It made 3 fast/repaint tests fail
1936         https://bugs.webkit.org/show_bug.cgi?id=78960
1937
1938         Reviewed by Csaba Osztrogonác.
1939
1940         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1941         (LayoutTestController::overridePreference):
1942
1943 2012-02-22  Hao Zheng  <zhenghao@chromium.org>
1944
1945         [chromium] Build WebKit with MEDIA_STREAM disabled.
1946         https://bugs.webkit.org/show_bug.cgi?id=79214
1947
1948         Reviewed by Kent Tamura.
1949
1950         * DumpRenderTree/chromium/WebUserMediaClientMock.cpp:
1951         * DumpRenderTree/chromium/WebUserMediaClientMock.h:
1952         * DumpRenderTree/chromium/WebViewHost.cpp:
1953         (WebViewHost::createMediaPlayer):
1954         * DumpRenderTree/chromium/WebViewHost.h:
1955         (WebViewHost):
1956
1957 2012-02-22  Zeno Albisser  <zeno@webkit.org>
1958
1959         [Qt][WK2][Mac] WebKitTestRunner does not build with clang.
1960         https://bugs.webkit.org/show_bug.cgi?id=79124
1961
1962         WebKitTestRunnerPrefix.h should also be included
1963         when building with clang.
1964
1965         Reviewed by Kenneth Rohde Christiansen.
1966
1967         * WebKitTestRunner/Target.pri:
1968
1969 2012-02-20  Roland Steiner  <rolandsteiner@chromium.org>
1970
1971         <style scoped>: Add runtime-flag
1972         https://bugs.webkit.org/show_bug.cgi?id=79074
1973
1974         Enable the runtime-flag for DRT. 
1975
1976         Reviewed by Dimitri Glazkov.
1977
1978         * DumpRenderTree/chromium/TestShell.cpp:
1979         (TestShell::TestShell):
1980
1981 2012-02-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1982
1983         Unreviewed, rolling out r107351.
1984         http://trac.webkit.org/changeset/107351
1985         https://bugs.webkit.org/show_bug.cgi?id=53600
1986
1987         Several issues introduced in WebKitGTK+ API
1988
1989         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1990         (createWebView):
1991         * GtkLauncher/main.c:
1992         (createWebViewCb):
1993         (createBrowser):
1994         (createWindow):
1995         (main):
1996
1997 2012-02-21  Filip Pizlo  <fpizlo@apple.com>
1998
1999         JSC should be a triple-tier VM
2000         https://bugs.webkit.org/show_bug.cgi?id=75812
2001         <rdar://problem/10079694>
2002
2003         Reviewed by Gavin Barraclough.
2004
2005         Changed EFL's build system to include a new directory in JavaScriptCore.
2006
2007         * DumpRenderTree/efl/CMakeLists.txt:
2008
2009 2012-02-21  Daniel Cheng  <dcheng@chromium.org>
2010
2011         [chromium] Fix image drag out on Chromium
2012         https://bugs.webkit.org/show_bug.cgi?id=79158
2013
2014         Reviewed by Tony Chang.
2015
2016         * DumpRenderTree/chromium/EventSender.cpp:
2017         (EventSender::dumpFilenameBeingDragged):
2018         (EventSender::beginDragWithFiles):
2019         * DumpRenderTree/chromium/WebViewHost.cpp:
2020         (addDRTFakeFileToDataObject):
2021
2022 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
2023
2024         webkitpy: speed up hot filesystem_mock functions
2025         https://bugs.webkit.org/show_bug.cgi?id=79159
2026
2027         Reviewed by Adam Barth.
2028
2029         Profiling run_webkit_tests_integrationtest.py revealed that
2030         isdir(), normpath(), and join() are called a lot and were very
2031         slow.This patch speeds them up substantially, shaving 20 seconds
2032         off of the execution time.
2033
2034         * Scripts/webkitpy/common/system/filesystem_mock.py:
2035         (MockFileSystem.isdir):
2036         (MockFileSystem._slow_but_correct_join):
2037         (MockFileSystem.join):
2038         (MockFileSystem.listdir):
2039         (MockFileSystem._slow_but_correct_normpath):
2040         (MockFileSystem.normpath):
2041         (MockFileSystem.write_binary_file):
2042         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
2043         (MockFileSystemTest.quick_check):
2044         (MockFileSystemTest):
2045         (MockFileSystemTest.test_join):
2046         (MockFileSystemTest.test_normpath):
2047         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
2048         (get_test_config): Call write_binary_file() instead of updating
2049           filesystem.files directly, so that we create directories as
2050           needed.
2051
2052 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
2053
2054         nrwt: make the delay between starting workers configurable per-port
2055         https://bugs.webkit.org/show_bug.cgi?id=79148
2056
2057         Reviewed by Eric Seidel.
2058
2059         Because of bug 79147, we have to sleep a bit in between starting
2060         DRTs; however, doing so across the board slows down the Test
2061         port. Making this configurable shaves 10 seconds off of
2062         run_webkit_tests_integrationtest.py
2063         
2064         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2065         (Manager._run_tests):
2066         * Scripts/webkitpy/layout_tests/port/base.py:
2067         (Port.worker_startup_delay_secs):
2068         * Scripts/webkitpy/layout_tests/port/test.py:
2069         (TestPort.worker_startup_delay_secs):
2070
2071 2012-02-21  Jon Lee  <jonlee@apple.com>
2072
2073         Bring notifications support to WK1 mac
2074         https://bugs.webkit.org/show_bug.cgi?id=78783
2075         <rdar://problem/10610578>
2076
2077         Reviewed by Anders Carlsson.
2078
2079         * DumpRenderTree/mac/UIDelegate.mm: Refactor WebGeolocationPolicyListener to WebAllowDenyPolicyListener.
2080         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
2081         (-[UIDelegate timerFired]):
2082
2083 2012-02-21  Kentaro Hara  <haraken@chromium.org>
2084
2085         Enable the IDL attribute checker in run-bindings-tests
2086         https://bugs.webkit.org/show_bug.cgi?id=79091
2087
2088         Reviewed by Adam Barth.
2089
2090         We have enabled the IDL attribute checker in Chromium in r108322.
2091         This patch enables the IDL attribute checker in run-bindings-tests.
2092
2093         No tests. I manually checked that [Custommm], [CallWith=],
2094         [CallWith=ScriptExecutionContext|Foo] in TestObj.idl cause
2095         run-bindings-tests failures.
2096
2097         * Scripts/webkitpy/bindings/main.py:
2098         (BindingsTests.generate_supplemental_dependency):
2099
2100 2012-02-21  Rafael Weinstein  <rafaelw@chromium.org>
2101
2102         Add rafaelw as a committer.
2103
2104         Unreviewed.
2105
2106         * Scripts/webkitpy/common/config/committers.py:
2107
2108 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
2109
2110         webkitpy: update names after deleting message_broker
2111         https://bugs.webkit.org/show_bug.cgi?id=79000
2112
2113         Reviewed by Eric Seidel.
2114
2115         Part 3 of 3 in deleting message_broker.py; this change just
2116         adjusts the names for the newly merged symbols so that they are
2117         private as appropriate.
2118
2119         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
2120         (get):
2121         (_Broker):
2122         (_BrokerConnection):
2123         (_BrokerConnection.__init__):
2124         (AbstractWorker.__init__):
2125         (_ManagerConnection):
2126         (_ManagerConnection.__init__):
2127         (_WorkerConnection):
2128         (_WorkerConnection.__init__):
2129
2130 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
2131
2132         webkitpy: merge message_broker.py into manager_worker_broker.py
2133         https://bugs.webkit.org/show_bug.cgi?id=78999
2134
2135         Reviewed by Tony Chang.
2136
2137         This is pretty much a straight cut-and-paste of one file into
2138         another (broken up so that docstrings and imports are in the
2139         right place).
2140
2141         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
2142         (BrokerClient):
2143         (BrokerClient.is_done):
2144         (BrokerClient.name):
2145         (Broker):
2146         (Broker.__init__):
2147         (Broker.add_topic):
2148         (Broker._get_queue_for_topic):
2149         (Broker.post_message):
2150         (Broker.run_message_loop):
2151         (Broker.run_all_pending):
2152         (Broker._run_loop):
2153         (Broker._dispatch_message):
2154         (_Message):
2155         (_Message.loads):
2156         (_Message.__init__):
2157         (_Message.dumps):
2158         (_Message.__repr__):
2159         (BrokerConnection):
2160         (BrokerConnection.__init__):
2161         (BrokerConnection.run_message_loop):
2162         (BrokerConnection.post_message):
2163         (BrokerConnection.raise_exception):
2164         * Scripts/webkitpy/layout_tests/controllers/message_broker.py: Removed.
2165
2166 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
2167
2168         webkitpy: prepare to delete message_broker.py
2169         https://bugs.webkit.org/show_bug.cgi?id=78997
2170
2171         Reviewed by Eric Seidel.
2172
2173         This is part 1 of 3 changes to fix bug 78187. This change
2174         prepares the code for merging message_broker.py into
2175         manager_worker_broker.py; the tests in message_broker_unittest
2176         are merged into manager_worker_broker_unittest, the symbols
2177         needed by the tests are exported from manager_worker_broker.py,
2178         and manager_worker_broker itself is updated to refer to the
2179         symbols directly (without the module prefix).
2180
2181         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
2182         (get):
2183         (AbstractWorker):
2184         (AbstractWorker.__init__):
2185         (_ManagerConnection):
2186         (_ManagerConnection.__init__):
2187         (_WorkerConnection):
2188         (_WorkerConnection.__init__):
2189         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
2190         (InterfaceTest.test_brokerclient_is_abstract):
2191         (InterfaceTest.test_brokerclient_is_abstract.methods):
2192         (MessageTest):
2193         (MessageTest.test__no_body):
2194         (MessageTest.test__body):
2195         * Scripts/webkitpy/layout_tests/controllers/message_broker_unittest.py: Removed.
2196
2197 2012-02-21  Sam Weinig  <sam@webkit.org>
2198
2199         Attempt to fix the Snow Leopard build.
2200
2201         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2202         * MiniBrowser/Configurations/Base.xcconfig:
2203         * TestWebKitAPI/Configurations/Base.xcconfig:
2204         * WebKitTestRunner/Configurations/Base.xcconfig:
2205
2206 2012-02-21  Sam Weinig  <sam@webkit.org>
2207
2208         Use libc++ when building with Clang on Mac
2209         https://bugs.webkit.org/show_bug.cgi?id=78981
2210
2211         Reviewed by Dan Bernstein.
2212
2213         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2214         * MiniBrowser/Configurations/Base.xcconfig:
2215         * TestWebKitAPI/Configurations/Base.xcconfig:
2216         * WebKitTestRunner/Configurations/Base.xcconfig:
2217
2218 2012-02-21  Adam Roben  <aroben@apple.com>
2219
2220         Roll out r108309, r108323, and r108326
2221
2222         They broke the 32-bit Lion build.
2223
2224         Original bugs is <http://webkit.org/b/75812> <rdar://problem/10079694>.
2225
2226         * DumpRenderTree/efl/CMakeLists.txt:
2227
2228 2012-02-21  Andras Becsi  <andras.becsi@nokia.com>
2229
2230         [Qt][WK2] Get rid of the dependency to QtWidgets
2231         https://bugs.webkit.org/show_bug.cgi?id=76276
2232
2233         Reviewed by Simon Hausmann.
2234
2235         * MiniBrowser/qt/MiniBrowser.pro:
2236         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2237         (MiniBrowserApplication::MiniBrowserApplication):
2238         (MiniBrowserApplication::notify):
2239         (MiniBrowserApplication::sendTouchEvent):
2240         * MiniBrowser/qt/MiniBrowserApplication.h:
2241         (MiniBrowserApplication):
2242         * QtTestBrowser/locationedit.h:
2243         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2244         (WTR::activateFonts):
2245         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2246
2247 2012-02-20  Adam Barth  <abarth@webkit.org>
2248
2249         mastercfg_unittest.py fails without simplejson
2250         https://bugs.webkit.org/show_bug.cgi?id=79070
2251
2252         Reviewed by Csaba Osztrogonác.
2253
2254         Now that we require Python 2.6 (and higher) we can import json rather
2255         than simplejson.  We still need to use the simplejson name because
2256         that's what the master.cfg script expects.
2257
2258         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2259         (BuildBotConfigLoader._add_dependant_modules_to_sys_modules):
2260
2261 2012-02-20  Filip Pizlo  <fpizlo@apple.com>
2262
2263         JSC should be a triple-tier VM
2264         https://bugs.webkit.org/show_bug.cgi?id=75812
2265         <rdar://problem/10079694>
2266
2267         Reviewed by Gavin Barraclough.
2268
2269         Changed EFL's build system to include a new directory in JavaScriptCore.
2270
2271         * DumpRenderTree/efl/CMakeLists.txt:
2272
2273 2012-02-20  Kenichi Ishibashi  <bashi@chromium.org>
2274
2275         Update pywebsocket to 0.7.2
2276         https://bugs.webkit.org/show_bug.cgi?id=79066
2277
2278         This version includes vendor-prefixed deflate-frame extension support.
2279
2280         Reviewed by Kent Tamura.
2281
2282         * Scripts/webkitpy/thirdparty/__init__.py:
2283         (AutoinstallImportHook._install_pywebsocket):
2284
2285 2012-02-20  Martin Robinson  <mrobinson@igalia.com>
2286
2287         [UNIX] Plugin information fields are not interpreted as UTF-8
2288         https://bugs.webkit.org/show_bug.cgi?id=78635
2289
2290         Reviewed by Gustavo Noronha Silva.
2291
2292         Interpret plugin metadata as UTF8 aways. This matches the behavior
2293         of Chromium and the Totem plugin.
2294
2295         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2296         (NPP_GetValue): Include a UTF-8 character in the description string for testing purposes.
2297
2298 2012-02-20  Martin Robinson  <mrobinson@igalia.com>
2299
2300         [GTK] [Qt] Move the unix forwarding headers for TestNetscapePlugin to the TestNetscapePlugin directory
2301         https://bugs.webkit.org/show_bug.cgi?id=78935
2302
2303         Reviewed by Gustavo Noronha Silva.
2304
2305         Move the TestNetscapePlugin headers to a more appropriate directory and update
2306         the build files to match.
2307
2308         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npapi.h: Renamed from Tools/DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h.
2309         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npfunctions.h: Renamed from Tools/DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h.
2310         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npruntime.h: Renamed from Tools/DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h.
2311         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Update build.
2312         * GNUmakefile.am: Ditto.
2313
2314 2012-02-20  Kihong Kwon  <kihong.kwon@samsung.com>
2315
2316         Add a new API for the Vibration API(W3C).
2317         https://bugs.webkit.org/show_bug.cgi?id=72010
2318
2319         Reviewed by Hajime Morita.
2320
2321         * Scripts/build-webkit: Enable ENABLE_VIBRATION feature.
2322
2323 2012-02-20  János Badics  <dicska@gmail.com>
2324
2325         [Qt] run-qtwebkit-tests doesn't consider timeouts as failures
2326         https://bugs.webkit.org/show_bug.cgi?id=71816
2327
2328         RunQtAPITests will notify if a timeout occurs during testing.
2329         Added unittest to the master.cfg
2330
2331         Reviewed by Csaba Osztrogonác.
2332
2333         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2334         (RunQtAPITests.evaluateCommand):
2335         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2336         (RunQtAPITestsTest):
2337         (RunQtAPITestsTest.assertResults):
2338         (RunQtAPITestsTest.test_timeout):
2339         (test_success):
2340         (test_failure):
2341         (test_timeout_and_failure):
2342
2343 2012-02-20  Andy Wingo  <wingo@igalia.com>
2344
2345         Add wingo as a committer.
2346
2347         Unreviewed.
2348
2349         * Scripts/webkitpy/common/config/committers.py: Add myself to the
2350         committers list.
2351
2352 2012-02-20  Jochen Eisinger  <jochen@chromium.org>
2353
2354         [chromium] check that we're not running multiple modal dialogs at the same time
2355         https://bugs.webkit.org/show_bug.cgi?id=78486
2356
2357         Reviewed by Kent Tamura.
2358
2359         * DumpRenderTree/chromium/TestShell.cpp:
2360         (TestShell::TestShell):
2361         * DumpRenderTree/chromium/TestShell.h:
2362         (TestShell::setIsDisplayingModalDialog):
2363         (TestShell::isDisplayingModalDialog):
2364         (TestShell):
2365         * DumpRenderTree/chromium/WebViewHost.cpp:
2366         (WebViewHost::runModal):
2367
2368 2012-02-20  Martin Robinson  <mrobinson@igalia.com>
2369
2370         Fix WebKit2GTK+ for 'make distcheck'.
2371
2372         Instead of conditionally including WebKit2 GNUmakefiles, always
2373         include them and conditionally activate the final targets.
2374
2375         * MiniBrowser/gtk/GNUmakefile.am:
2376         * WebKitTestRunner/GNUmakefile.am:
2377
2378 2012-02-20  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2379
2380         Enable video option for EFL port in build-webkit.
2381         https://bugs.webkit.org/show_bug.cgi?id=79006
2382
2383         Reviewed by Daniel Bates.
2384
2385         * Scripts/build-webkit:
2386
2387 2012-02-19  JungJik Lee  <jungjik.lee@samsung.com>
2388
2389         [EFL] Use modifier keys to execute pre-rendering.
2390         https://bugs.webkit.org/show_bug.cgi?id=77933
2391
2392         Reviewed by Chang Shu.
2393
2394         Use modifier key to execute pre-rendering instead of using reserved function keys.
2395
2396         * EWebLauncher/main.c:
2397         (on_key_down):
2398
2399 2012-02-18  Dirk Pranke  <dpranke@chromium.org>
2400
2401         Fix one more dangling reference to worker_connection.name, delete unused code.
2402
2403         Unreviewed, build fix.
2404
2405         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2406         (Manager.update):
2407         (_WorkerState.__init__):
2408
2409 2012-02-18  Dirk Pranke  <dpranke@chromium.org>
2410
2411         Add a change that should've been in r108005.
2412
2413         Unreviewed, build fix.
2414
2415         In the refactoring/cleanup in r108005 I should've changed the
2416         implementation of WorkerConnection to make it match BrokerClient
2417         (and everything else) so that objects had a name() method
2418         instead of a name property.
2419
2420         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2421         (Manager._run_tests):
2422         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
2423         (_WorkerConnection.__init__):
2424         (_WorkerConnection.name):
2425         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
2426         (_TestWorker.__init__):
2427         (_TestsMixin.name):
2428         (_TestsMixin.test_name):
2429         (_TestsMixin.test_cancel):
2430         (_TestsMixin.test_unknown_message):
2431
2432 2012-02-18  Dirk Pranke  <dpranke@chromium.org>
2433
2434         webkitpy: remove webkitpy.common.array_stream
2435         https://bugs.webkit.org/show_bug.cgi?id=78952
2436
2437         Reviewed by Eric Seidel.
2438
2439         Turns out array_stream didn't really do anything that StringIO
2440         didn't do (at least as of Python 2.6). This change removes it
2441         and updates all of the callers. Where possible, I changed the
2442         test assertions in order to capture the intent more clearly,
2443         e.g., instead of calling self.assertTrue('foo' in stream.get()),
2444         we have self.assertContainsLine(stream, 'foo'), and instead of
2445         self.assertTrue(stream.empty()), we have self.assertEmpty(stream) -
2446         the latter isn't that much more readable, but StringIO doesn't
2447         export an empty() method.
2448
2449         * Scripts/webkitpy/common/array_stream.py: Removed.
2450         * Scripts/webkitpy/common/array_stream_unittest.py: Removed.
2451         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2452         (passing_run):
2453         (run_and_capture):
2454         (StreamTestingMixin):
2455         (StreamTestingMixin.assertContains):
2456         (StreamTestingMixin.assertContainsLine):
2457         (StreamTestingMixin.assertEmpty):
2458         (StreamTestingMixin.assertNotEmpty):
2459         (LintTest):
2460         (LintTest.test_lint_test_files):
2461         (LintTest.test_lint_test_files__errors):
2462         (MainTest):
2463         (MainTest.test_child_process_1):
2464         (MainTest.test_child_processes_2):
2465         (MainTest.test_child_processes_min):
2466         (MainTest.test_help_printing):
2467         (MainTest.test_hung_thread):
2468         (MainTest.test_no_tests_found):
2469         (MainTest.test_no_tests_found_2):
2470         (MainTest.test_repeat_each_iterations_num_tests):
2471         (MainTest.test_test_list):
2472         (MainTest.test_unexpected_failures):
2473         (MainTest.test_worker_model__inline_with_child_processes):
2474         (MainTest.test_additional_platform_directory):
2475         (RebaselineTest):
2476         (RebaselineTest.assertBaselines):
2477         (RebaselineTest.test_reset_results):
2478         (RebaselineTest.test_missing_results):
2479         (RebaselineTest.test_new_baseline):
2480         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
2481         (MeteredStream.update):
2482         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
2483         (TestMeteredStream.test_regular):
2484         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
2485         (TestUtilityFunctions.assertEmpty):
2486         (TestUtilityFunctions):
2487         (TestUtilityFunctions.assertNotEmpty):
2488         (TestUtilityFunctions.assertWritten):
2489         (TestUtilityFunctions.test_configure_logging):
2490         (Testprinter.assertEmpty):
2491         (Testprinter):
2492         (Testprinter.assertNotEmpty):
2493         (Testprinter.assertWritten):
2494         (Testprinter.reset):
2495         (Testprinter.get_printer):
2496         (Testprinter.test_help_printer):
2497         (Testprinter.do_switch_tests.do_helper):
2498         (Testprinter.test_print_one_line_summary):
2499         (Testprinter.test_print_test_result):
2500         (Testprinter.test_print_progress):
2501         (Testprinter.test_write_nothing):
2502         (Testprinter.test_write_misc):
2503         (Testprinter.test_write_everything):
2504         (Testprinter.test_write_verbose):
2505         (Testprinter.test_print_unexpected_results):
2506         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2507         (MainTest.assertWritten):
2508         (create_runner):
2509         (test_run_test_set):
2510         (test_run_test_set_kills_drt_per_run):
2511         (test_run_test_set_for_parser_tests):
2512         (test_run_test_set_with_json_output):
2513         (test_run_test_set_with_json_source):
2514         (test_run_test_set_with_multiple_repositories):
2515         (test_upload_json):
2516
2517 2012-02-18  Kevin Ollivier  <kevino@theolliviers.com>
2518
2519         [wx] Add the WebCore/page/scrolling directory to the build dirs.
2520
2521         * waf/build/settings.py:
2522
2523 2012-02-18  Kevin Ollivier  <kevino@theolliviers.com>
2524
2525         [wx] Unreviewed build fix. Don't error out or hang if we have
2526         downloaded dependencies but server update check fails.
2527
2528         * waf/build/build_utils.py:
2529         (download_if_newer):
2530
2531 2012-02-17  Dirk Pranke  <dpranke@chromium.org>
2532
2533         The new run-webkit-tests needs to dump out pixel hash failures even if the pixel test passes.
2534         https://bugs.webkit.org/show_bug.cgi?id=69444
2535
2536         Reviewed by Tony Chang.
2537
2538         Currently if a test's image checksum doesn't match the checksum
2539         in the baseline, but the images themselves match according to
2540         ImageDiff, new-run-webkit-tests ignores the problem. This is
2541         probably bad, but it's not yet clear what the right thing to do
2542         is. This patch will log a warning to stderr, at least (but the
2543         test will still pass).
2544
2545         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2546         (SingleTestRunner._compare_image):
2547         (SingleTestRunner._run_reftest):
2548         * Scripts/webkitpy/layout_tests/port/test.py:
2549         (unit_test_list):
2550         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
2551
2552 2012-02-17  Dirk Pranke  <dpranke@chromium.org>
2553
2554         NRWT does not report failure for a skipped test
2555         https://bugs.webkit.org/show_bug.cgi?id=78750
2556
2557         Reviewed by Eric Seidel.
2558
2559         If a test is listed in a Skipped file and you run it anyway
2560         with --force, and the test fails, currently NRWT will print
2561         "test ran as expected"; this is confusing, because you probably
2562         expect the test to fail and yet this might lead you to think the
2563         test passed. This patch changes the expected behavior to "PASS",
2564         so tests that fail will be reported.
2565
2566         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2567         (result_was_expected):
2568         (TestExpectationParser):
2569         (TestExpectationParser.expectation_for_skipped_test):
2570         (TestExpectations):
2571         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2572         (test_add_skipped_tests):
2573         * Scripts/webkitpy/layout_tests/port/test.py:
2574         (unit_test_list): Add some tests that are expected to be in a Skipped file.
2575         (TestPort.skipped_tests): This adds actual integration test coverage of Skipped files.
2576
2577 2012-02-17  Dirk Pranke  <dpranke@chromium.org>
2578
2579         webkitpy: fix test code after bug 78181
2580         https://bugs.webkit.org/show_bug.cgi?id=78870
2581
2582         Reviewed by Adam Barth.
2583
2584         I forgot to update the test code as per Tony's suggestion in
2585         bug 78181 (r108005). This change does that, and in doing so
2586         it revealed a subtle bug in _InlineWorkerConnection.run() that
2587         I am fixing as part of this (_alive would not be cleared if an
2588         exception was thrown).
2589
2590         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
2591         (_InlineWorkerConnection.run):
2592         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
2593         (_TestWorker.__init__):
2594         (_TestWorker.handle_stop):
2595         (_TestWorker.handle_test):
2596         (_TestWorker.run):
2597         (_TestsMixin.handle_exception):
2598         (_TestsMixin.test_unknown_message):
2599
2600 2012-02-17  Adam Roben  <aroben@apple.com>
2601
2602         Mac build fix after r108119
2603
2604         * DumpRenderTree/mac/DumpRenderTree.mm:
2605         (runThread):
2606         (runPthread):
2607         (testThreadIdentifierMap):
2608         Updated to match current WTF threading APIs.
2609
2610 2012-02-17  Dirk Pranke  <dpranke@chromium.org>
2611
2612         revert r107147 - breaks webkit-patch on Mac SL
2613         https://bugs.webkit.org/show_bug.cgi?id=78866
2614
2615         Reviewed by Adam Barth.
2616
2617         It appears that zipfile.ExtractAll is broken on Python 2.6.1,
2618         which is the version that ships on Mac SL. Reverting this
2619         change until we no longer have to worry about that version.
2620
2621         * Scripts/webkitpy/common/system/autoinstall.py:
2622         (AutoInstaller):
2623         (AutoInstaller._extract_all): Added a comment about SL.
2624         (AutoInstaller._unzip):
2625
2626 2012-02-17  Mihnea Ovidenie  <mihnea@adobe.com>
2627
2628         CSS regions enabled by default
2629         https://bugs.webkit.org/show_bug.cgi?id=78525
2630
2631         Reviewed by David Hyatt.
2632
2633         Add a runtime preference to enable/disable regions functionality at runtime(WebKitCSSRegionsEnabled).
2634         CSSRegions are still enabled by default.
2635         In DRT, use layoutTestController.overridePreference("WebKitCSSRegionsEnabled", "0") to disable the css regions functionality.
2636
2637         * DumpRenderTree/chromium/LayoutTestController.cpp:
2638         (LayoutTestController::overridePreference):
2639         * DumpRenderTree/chromium/WebPreferences.cpp:
2640         (WebPreferences::reset):
2641         (WebPreferences::applyTo):
2642         * DumpRenderTree/chromium/WebPreferences.h:
2643         (WebPreferences):
2644         * DumpRenderTree/mac/DumpRenderTree.mm:
2645         (resetDefaultsToConsistentValues):
2646
2647 2012-02-17  Maciej Stachowiak  <mjs@apple.com>
2648
2649         Some API tests erroneously use = instead of == (causing build failures)
2650         https://bugs.webkit.org/show_bug.cgi?id=78915
2651
2652         Reviewed by Sam Weinig.
2653
2654         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
2655         (TestWebKitAPI::decidePolicyForNavigationAction): Replace an = with an ==
2656         (TestWebKitAPI::decidePolicyForNewWindowAction): ditto
2657
2658 2012-02-17  Peter Beverloo  <peter@chromium.org>
2659
2660         [Chromium] Include TestShellLinux.cpp in the build for Android
2661         https://bugs.webkit.org/show_bug.cgi?id=78865
2662
2663         Reviewed by Eric Seidel.
2664
2665         Android will be re-using the TestShellLinux.cpp file. I already
2666         added this r104033, but it seems to have gotten lost in the
2667         recent refactorings.
2668
2669         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2670
2671 2012-02-17  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2672
2673         Unreviewed, disable video build on EFL until it can be
2674         supported by EFL build bot.
2675
2676         * Scripts/build-webkit:
2677
2678 2012-02-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2679
2680         [GTK] Implement zoom in/out in MiniBrowser
2681         https://bugs.webkit.org/show_bug.cgi?id=75253
2682
2683         Reviewed by Gustavo Noronha Silva.
2684
2685         * MiniBrowser/gtk/BrowserWindow.c:
2686         (browserWindowCanZoomIn):
2687         (browserWindowCanZoomOut):
2688         (browserWindowUpdateZoomActions):
2689         (webViewZoomLevelChanged):
2690         (zoomInCallback):
2691         (zoomOutCallback):
2692         (browser_window_init):
2693         (browserWindowConstructed):
2694
2695 2012-02-17  Nikolas Zimmermann  <nzimmermann@rim.com>
2696
2697         layoutTestController.display() is flaky for SVG tests
2698         https://bugs.webkit.org/show_bug.cgi?id=78021
2699
2700         Reviewed by Adam Roben.
2701
2702         Apply the same fix to DRT/Win, as previously applied to DRT/Mac.
2703         Size the web view before running the test, not when dumping.
2704         All platforms handle this correctly now.
2705
2706         * DumpRenderTree/win/DumpRenderTree.cpp:
2707         (dump):
2708         (sizeWebViewForCurrentTest):
2709         (runTest):
2710
2711 2012-02-16  Carlos Garcia Campos  <cgarcia@igalia.com>
2712
2713         [GTK] Make install is broken when building without --enable-gtk-doc
2714         https://bugs.webkit.org/show_bug.cgi?id=78828
2715
2716         Reviewed by Martin Robinson.
2717
2718         * gtk/generate-gtkdoc:
2719         (rebase_installed_docs): Check documentation has been generated
2720         before trying to rebase it.
2721
2722 2012-02-16  Dirk Pranke  <dpranke@chromium.org>
2723
2724         nrwt: simplify worker interface
2725         https://bugs.webkit.org/show_bug.cgi?id=78181
2726
2727         Reviewed by Tony Chang.
2728
2729         This change moves code in name(), is_done(), run(), and cancel()
2730         from Worker to AbstractWorker, since the logic is pretty much
2731         boilerplate code that any implementation would want to use.
2732
2733         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
2734         (get.should):
2735         (AbstractWorker.__init__):
2736         (AbstractWorker):
2737         (AbstractWorker.name):
2738         (AbstractWorker.stop_handling_messages):
2739         (AbstractWorker.run):
2740         (AbstractWorker.is_done):
2741         (AbstractWorker.cancel):
2742         * Scripts/webkitpy/layout_tests/controllers/worker.py:
2743         (Worker.__init__):
2744         (Worker.run):
2745         (Worker.handle_stop):
2746
2747 2012-02-16  Michael Saboff  <msaboff@apple.com>
2748
2749         ENH: Add ability to run subset of JavaScript layout tests with JSC
2750         https://bugs.webkit.org/show_bug.cgi?id=78764
2751
2752         Reviewed by Gavin Barraclough.
2753
2754         New simple test drive shell script that runs a defined
2755         list of javascript tests using jsc and the standalone-{pre,post}.js
2756         wrappers.
2757
2758         * Scripts/run-fast-jsc: Added.
2759
2760 2012-02-16  Csaba Osztrogonác  <ossy@webkit.org>
2761
2762         Add new Qt performance tester bot to build.webkit.org
2763         https://bugs.webkit.org/show_bug.cgi?id=78795
2764
2765         Reviewed by Adam Roben.
2766
2767         * BuildSlaveSupport/build.webkit.org-config/config.json:
2768
2769 2012-02-16  Patrick Gansterer  <paroga@webkit.org>
2770
2771         Disable inspector on WinCE.
2772
2773         Avoid compiling InspectorBackendDispatcher.cpp, which causes an internal compiler error.
2774
2775         * Scripts/build-webkit:
2776
2777 2012-02-16  Patrick Gansterer  <paroga@webkit.org>
2778
2779         WinCE build fix after r107656.
2780
2781         Disable FTPDIR on WinCE, since it does not compile there.
2782
2783         * Scripts/build-webkit:
2784
2785 2012-02-15  Leo Yang  <leo.yang@torchmobile.com.cn>
2786
2787         Build fix after r107863.
2788
2789         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
2790
2791 2012-02-15  Tony Chang  <tony@chromium.org>
2792
2793         [chromium] add linux dbg back to garden-o-matic
2794         https://bugs.webkit.org/show_bug.cgi?id=78752
2795
2796         Reviewed by Adam Barth.
2797
2798         This reflects the current linux debug bot name (there's only one bot).
2799         I'm also remove the mac clang builder since it doesn't exist (mac
2800         always uses clang now).
2801
2802         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2803         * Scripts/webkitpy/layout_tests/port/builders.py:
2804
2805 2012-02-15  Sam Weinig  <sam@webkit.org>
2806
2807         Add style check for ctype functions that are generally frowned upon in WebKit
2808         https://bugs.webkit.org/show_bug.cgi?id=78748
2809
2810         Reviewed by Anders Carlsson.
2811
2812         Not every platform has DisallowCType.h to check for uses of the ctype.h
2813         functions, so add a style check for them as well.
2814
2815         * Scripts/webkitpy/style/checkers/cpp.py:
2816         (check_ctype_functions):
2817         (check_style):
2818         (CppChecker):
2819         Add check.
2820
2821         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2822         (WebKitStyleTest.test_ctype_fucntion):
2823         Add checker.
2824
2825 2012-02-15  Szilard Ledan  <Ledan-Muntean.Szilard@stud.u-szeged.hu>
2826
2827         [Qt][WK2] WebKitTestRunner should use 480x360 sized view for W3C SVG tests
2828         https://bugs.webkit.org/show_bug.cgi?id=76546
2829
2830         Reviewed by Simon Hausmann.
2831
2832         Resize the web view programatically because the declarative property binding
2833         does not work. Seems like our qml environment is not initialized fully but it
2834         needs more investigation.
2835
2836         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2837         (WTR::WrapperWindow::handleStatusChanged):
2838         (WTR::PlatformWebView::resizeTo):
2839
2840 2012-02-15  Dirk Pranke  <dpranke@chromium.org>
2841
2842         webkitpy: add a worker_args concept to start_worker()
2843         https://bugs.webkit.org/show_bug.cgi?id=78572
2844
2845         Reviewed by Tony Chang.
2846
2847         This change replaces the three NRWT-specific arguments passed
2848         through the broker to the worker with a generic WorkerArguments
2849         wrapper class and a separate set_inline_arguments() call that can
2850         be used to pass additional data to the worker when it is running
2851         in the same process as the manager (this is needed for testing).
2852         With the addition of set_inline_arguments() we also no longer
2853         need to pass an optional argument to the worker.run() call.
2854
2855         Note that this method is *only* implemented on inline workers,
2856         so calling this on a regular (child process) worker will result
2857         in a runtime error.
2858
2859         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2860         (Manager._run_tests):
2861         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
2862         (AbstractWorker.__init__):
2863         (AbstractWorker.run):
2864         (_ManagerConnection.start_worker):
2865         (_InlineManager.start_worker):
2866         (_InlineManager.set_inline_arguments):
2867         (_InlineManager.run_message_loop):
2868         (_MultiProcessManager.start_worker): Reworked signature.
2869         (_WorkerConnection.__init__):
2870         (_InlineWorkerConnection.__init__):
2871         (_InlineWorkerConnection.set_inline_arguments): New method.
2872         (_InlineWorkerConnection):
2873         (_InlineWorkerConnection.run):
2874         (_Process.run):
2875         (_MultiProcessWorkerConnection.__init__):
2876         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
2877         (_TestWorker.__init__):
2878         (_TestWorker.set_inline_arguments):
2879         (_TestWorker.handle_test):
2880         (_TestWorker.run):
2881         (_TestsMixin.test_cancel):
2882         (_TestsMixin.test_done):
2883         (_TestsMixin.test_unknown_message):
2884         (InlineBrokerTests): New class for more testing.
2885         (InlineBrokerTests.setUp):
2886         (InlineBrokerTests.test_inline_arguments): New test.
2887         (InterfaceTest.test_managerconnection_is_abstract):
2888         (InterfaceTest.test_workerconnection_is_abstract):
2889         * Scripts/webkitpy/layout_tests/controllers/worker.py:
2890         (WorkerArguments):
2891         (WorkerArguments.__init__):
2892         (Worker.__init__):
2893         (Worker.set_inline_arguments):
2894         (Worker):
2895         (Worker.run):
2896         * Scripts/webkitpy/layout_tests/controllers/worker_unittest.py:
2897         (WorkerTest.test_default_platform_in_worker):
2898
2899 2012-02-15  Adam Klein  <adamk@chromium.org>
2900
2901         Unreviewed, rolling out r107704.
2902         http://trac.webkit.org/changeset/107704
2903         https://bugs.webkit.org/show_bug.cgi?id=78486
2904
2905         Caused layout test crashes in debug builds.
2906
2907         Specific crashing tests:
2908
2909         fast/events/show-modal-dialog-onblur-onfocus.html
2910         fast/harness/show-modal-dialog.html
2911         inspector/console/console-long-eval-crash.html
2912
2913         * DumpRenderTree/chromium/TestShell.cpp:
2914         (TestShell::TestShell):
2915         * DumpRenderTree/chromium/TestShell.h:
2916         (TestShell):
2917         * DumpRenderTree/chromium/WebViewHost.cpp:
2918         (WebViewHost::runModal):
2919
2920 2012-02-15  Michael Brüning  <michael.bruning@nokia.com>
2921
2922         [Qt] Add UI for HTTP authentication in the Qt MiniBrowser
2923         https://bugs.webkit.org/show_bug.cgi?id=76347
2924
2925         Reviewed by Kenneth Rohde Christiansen.
2926
2927         * MiniBrowser/qt/MiniBrowser.qrc:
2928         * MiniBrowser/qt/qml/AuthenticationDialog.qml: Added. 
2929         * MiniBrowser/qt/qml/BrowserWindow.qml:
2930         * MiniBrowser/qt/qml/DialogLineInput.qml:
2931
2932 2012-02-15  Simon Hausmann  <simon.hausmann@nokia.com>
2933
2934         [Qt] Fix WebGL in QtTestBrowser
2935
2936         Reviewed by Tor Arne Vestbø.
2937
2938         * QtTestBrowser/QtTestBrowser.pro: Set the OpenGL define so that when passing
2939         the options for enabling GL we also pass them on properly.
2940
2941 2012-02-14  Sam Weinig  <sam@webkit.org>
2942
2943         Add #include of unistd.h on the mac for getcwd. 
2944
2945         Reviewed by Anders Carlsson.
2946
2947         This is necessary when building with libc++.
2948
2949         * WebKitTestRunner/TestInvocation.cpp:
2950
2951 2012-02-14  Sam Weinig  <sam@webkit.org>
2952
2953         In DRT, don't #define min or max on non-Windows platforms, it just isn't needed
2954         https://bugs.webkit.org/show_bug.cgi?id=78663
2955
2956         Reviewed by Anders Carlsson.
2957
2958         * DumpRenderTree/DumpRenderTreePrefix.h:
2959         * DumpRenderTree/cg/ImageDiffCG.cpp:
2960
2961 2012-02-14  Adam Barth  <abarth@webkit.org>
2962
2963         Implement an adb-based driver for the ChromiumAndroidPort
2964         https://bugs.webkit.org/show_bug.cgi?id=78627
2965
2966         Reviewed by Eric Seidel.
2967
2968         This driver mostly just wires up the ChromiumDriver through adb.  In
2969         some cases, it translates protocol elements, such as URIs, so that the
2970         rest of webkitpy is insulated from the "remoteness" of the target device.
2971
2972         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2973         (ChromiumAndroidPort.start_helper):
2974         (ChromiumAndroidPort._driver_class):
2975         (ChromiumAndroidPort._update_version):
2976         (ChromiumAndroidPort._get_stderr):
2977         (ChromiumAndroidPort):
2978         (ChromiumAndroidPort._get_last_stacktrace):
2979         (ChromiumAndroidPort._teardown_performance):
2980         (ChromiumAndroidDriver):
2981         (ChromiumAndroidDriver.__init__):
2982         (ChromiumAndroidDriver._start):
2983         (ChromiumAndroidDriver.run_test):
2984         (ChromiumAndroidDriver.stop):
2985         (ChromiumAndroidDriver._test_shell_command):
2986         (ChromiumAndroidDriver._write_command_and_read_line):
2987         (ChromiumAndroidDriver._output_image):
2988         (ChromiumAndroidDriver._has_crash_hint):
2989
2990 2012-02-14  Dirk Pranke  <dpranke@chromium.org>
2991
2992         webkitpy: the real_name() method in the Port class is no longer needed
2993         https://bugs.webkit.org/show_bug.cgi?id=78651
2994
2995         Reviewed by Eric Seidel.
2996
2997         The change in bug 78565 / r107718 made it no longer necessary
2998         (we can use options.platform instead).
2999
3000         * Scripts/webkitpy/layout_tests/port/base.py:
3001         (Port.name):
3002         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
3003         (MockDRTPort.__init__):
3004
3005 2012-02-14  Dirk Pranke  <dpranke@chromium.org>
3006
3007         webkitpy: clean up options, port handling in manager_worker_broker
3008         https://bugs.webkit.org/show_bug.cgi?id=78568
3009
3010         Reviewed by Tony Chang.
3011
3012         manager_worker_broker no longer needs options or port objects
3013         directly, so we make them only be passed in start_worker().
3014
3015         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3016         (Manager._run_tests):
3017         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
3018         (get):
3019         (_ManagerConnection.__init__):
3020         (_ManagerConnection.start_worker):
3021         (_InlineManager.__init__):
3022         (_InlineManager.start_worker):
3023         (_InlineManager.run_message_loop):
3024         (_MultiProcessManager.__init__):
3025         (_MultiProcessManager):
3026         (_MultiProcessManager.start_worker):
3027         (_InlineWorkerConnection.__init__):
3028         (_InlineWorkerConnection.run):
3029         (_Process.__init__):
3030         (_MultiProcessWorkerConnection.__init__):
3031         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
3032         (make_broker):
3033         (_TestWorker.run):
3034         (_TestsMixin.test_cancel):
3035         (_TestsMixin.test_done):
3036         (_TestsMixin.test_unknown_message):
3037         (MultiProcessBrokerTests.setUp):
3038         (InterfaceTest.test_managerconnection_is_abstract):
3039         * Scripts/webkitpy/layout_tests/controllers/message_broker.py:
3040         (Broker.__init__):
3041
3042 2012-02-14  Dirk Pranke  <dpranke@chromium.org>
3043
3044         nrwt: add a unit test for regression introduced in bug 78565
3045         https://bugs.webkit.org/show_bug.cgi?id=78646
3046
3047         Reviewed by Tony Chang.
3048
3049         * Scripts/webkitpy/layout_tests/controllers/worker_unittest.py: Added.
3050         (FakeConnection):
3051         (FakeConnection.run_message_loop):
3052         (FakeConnection.post_message):
3053         (WorkerTest):
3054         (WorkerTest.test_default_platform_in_worker):
3055
3056 2012-02-14  Dirk Pranke  <dpranke@chromium.org>
3057
3058         NRWT is broken for the default port
3059         https://bugs.webkit.org/show_bug.cgi?id=78640
3060     
3061         Reviewed by Tony Chang.
3062
3063         The change in r107718 (bug 78565) broke NRWT if you didn't
3064         specify any sort of --platform flag or equivalent. I didn't
3065         catch this because it's a full integration test (which we don't
3066         have an automated test for) and I missed this command line
3067         variant when testing interactively.
3068
3069         * Scripts/webkitpy/layout_tests/controllers/worker.py:
3070         (Worker.run):
3071
3072 2012-02-14  Ramya Chandrasekaran  <cramya@google.com>
3073
3074         Last character display for passwords in Android.
3075         https://bugs.webkit.org/show_bug.cgi?id=78532
3076
3077         Reviewed by Adam Barth.
3078
3079         * DumpRenderTree/chromium/WebPreferences.cpp:
3080         (WebPreferences::applyTo):
3081
3082 2012-02-14  Adam Barth  <abarth@webkit.org>
3083
3084         Finish implementing start_helper for ChromiumAndroidPort
3085         https://bugs.webkit.org/show_bug.cgi?id=78582
3086
3087         Reviewed by Eric Seidel.
3088
3089         This patch contains the remaining odds and ends for the start_helper function.
3090
3091         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3092         (ChromiumAndroidPort.start_helper):
3093         (ChromiumAndroidPort._synchronize_datetime):
3094         (ChromiumAndroidPort):
3095         (ChromiumAndroidPort._check_version):
3096         (ChromiumAndroidPort._run_adb_command):
3097         (ChromiumAndroidPort._copy_device_file):
3098
3099 2012-02-14  Dirk Pranke  <dpranke@chromium.org>
3100
3101         webkitpy: create ports in Workers, not in manager_worker_broker
3102         https://bugs.webkit.org/show_bug.cgi?id=78565
3103
3104         Reviewed by Tony Chang.
3105
3106         We will now create the Port object (if necessary) in the Worker
3107         directly, so that the manager_worker_broker module doesn't need
3108         all of this layout_test-specific logic. Part of the fixes for
3109         bug 78171.
3110
3111         These changes are all well-tested by the existing tests in
3112         run_webkit_tests_integrationtest.py.
3113
3114         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
3115         (_Process.run):
3116         * Scripts/webkitpy/layout_tests/controllers/worker.py:
3117         (Worker.__init__):
3118         (Worker.safe_init):
3119         (Worker.run):
3120         (Worker.cleanup):
3121         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3122         (parse_args):
3123         (main): Fix a minor bug where running the 'mock-test' port didn't work right.
3124
3125 2012-02-14  Jochen Eisinger  <jochen@chromium.org>
3126
3127         [chromium] check that we're not running multiple modal dialogs at the same time
3128         https://bugs.webkit.org/show_bug.cgi?id=78486
3129
3130         Reviewed by Kent Tamura.
3131
3132         * DumpRenderTree/chromium/TestShell.cpp:
3133         (TestShell::TestShell):
3134         * DumpRenderTree/chromium/TestShell.h:
3135         (TestShell::setIsDisplayingModalDialog):
3136         (TestShell::isDisplayingModalDialog):
3137         (TestShell):
3138         * DumpRenderTree/chromium/WebViewHost.cpp:
3139         (WebViewHost::runModal):
3140
3141 2012-02-14  Adam Barth  <abarth@webkit.org>
3142
3143         Enable the GPU codepath in the chromium-android port
3144         https://bugs.webkit.org/show_bug.cgi?id=78580
3145
3146         Reviewed by James Robinson.
3147
3148         Suprise!  There is no ChromiumGpuAndroidPort!  Instead, Chromium
3149         Android always uses the GPU codepath, so we set the GPU flags on the
3150         main chromium-android port instead.
3151
3152         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3153         (ChromiumAndroidPort.__init__):
3154
3155 2012-02-14  Adam Barth  <abarth@webkit.org>
3156
3157         NRWT should expose --adb-args flag for Android
3158         https://bugs.webkit.org/show_bug.cgi?id=78579
3159
3160         Reviewed by Eric Seidel.
3161
3162         This flag is already wired up to the ChromiumAndroidPort.
3163
3164         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3165         (parse_args):
3166
3167 2012-02-14  Alexey Proskuryakov  <ap@apple.com>
3168
3169         [Mac][Win][WK2] Switch to RFC 6455 protocol for WebSockets
3170         https://bugs.webkit.org/show_bug.cgi?id=78541
3171         <rdar://problem/10036695>
3172
3173         Reviewed by Kent Tamura.
3174
3175         * DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues):
3176         * DumpRenderTree/win/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
3177         After each test, reset to using new protocol.
3178
3179 2012-02-11  Nikolas Zimmermann  <nzimmermann@rim.com>
3180
3181         Convert svg/animations to use SMIL methods for driving the timeline
3182         https://bugs.webkit.org/show_bug.cgi?id=78422
3183
3184         Reviewed by Dirk Schulze.
3185
3186         Remove no longer needed SVG specific animation sampling functionality from DRT.
3187         Instead we switched the svg/animations tests to use SVGSVGElement.setCurrentTime.
3188
3189         * DumpRenderTree/LayoutTestController.cpp:
3190         (LayoutTestController::staticFunctions):
3191         * DumpRenderTree/LayoutTestController.h:
3192         (LayoutTestController):
3193         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
3194         * DumpRenderTree/chromium/LayoutTestController.cpp:
3195         (LayoutTestController::LayoutTestController):
3196         * DumpRenderTree/chromium/LayoutTestController.h:
3197         (LayoutTestController):
3198         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3199         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3200         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3201         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3202         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3203         (LayoutTestController):
3204         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3205         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3206
3207 2012-02-13  Rob Flack  <flackr@chromium.org>
3208
3209         Add Linux ChromiumOS test results to flakiness dashboard.
3210         https://bugs.webkit.org/show_bug.cgi?id=78495
3211
3212         Reviewed by Ojan Vafai.
3213
3214         * TestResultServer/static-dashboards/builders.js:
3215         * TestResultServer/static-dashboards/dashboard_base.js:
3216
3217 2012-02-13  ChangSeok Oh  <shivamidow@gmail.com>
3218
3219         [GTK] Mutation Observers build is broken
3220         https://bugs.webkit.org/show_bug.cgi?id=78433
3221
3222         Reviewed by Martin Robinson.
3223
3224         Enabled mutation observers as a default feature for GTK port, too.
3225
3226         * Scripts/build-webkit:
3227
3228 2012-02-13  Loïc Yhuel  <loic.yhuel_ext@softathome.com>
3229
3230         Allow to configure ENABLE_FTPDIR in build-webkit
3231         https://bugs.webkit.org/show_bug.cgi?id=65098
3232
3233         Reviewed by Eric Seidel.
3234
3235         Allow to disable ENABLE_FTPDIR by command line.
3236         Remove ENABLE_FTPDIR from --minimal build
3237
3238         * Scripts/build-webkit: Add entries for ENABLE_FTPDIR (enabled by default)
3239         * qmake/mkspecs/features/features.prf: ENABLE_FTPDIR must be set to match Platform.h,
3240         as, for Qt platform, build-webkit does not add on command line what it thinks to be default values
3241
3242 2012-02-13  Shinya Kawanaka  <shinyak@chromium.org>
3243
3244         Add shinyak as committer.
3245
3246         Unreviewed.
3247
3248         * Scripts/webkitpy/common/config/committers.py:
3249
3250 2012-02-13  Adam Barth  <abarth@webkit.org>
3251
3252         Implement start/stop_helper for ChromiumAndroidPort
3253         https://bugs.webkit.org/show_bug.cgi?id=78558
3254
3255         Reviewed by Dirk Pranke.
3256
3257         These functions (and their dependencies) set up the Android device for
3258         testing.
3259
3260         This patch also includes a few tweaks on the previous patch recommended
3261         by dpranke.
3262
3263         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3264         (ChromiumAndroidPort.__init__):
3265         (ChromiumAndroidPort.start_helper):
3266         (ChromiumAndroidPort.stop_helper):
3267         (ChromiumAndroidPort._shut_down_http_server):
3268         (ChromiumAndroidPort):
3269         (ChromiumAndroidPort._push_executable):
3270         (ChromiumAndroidPort._push_fonts):
3271         (ChromiumAndroidPort._restore_system_font):
3272         (ChromiumAndroidPort._push_test_resources):
3273         (ChromiumAndroidPort._push_to_device):
3274         (ChromiumAndroidPort._pull_from_device):
3275         (ChromiumAndroidPort._kill_device_process):
3276         (ChromiumAndroidPort._setup_performance):
3277         (ChromiumAndroidPort._teardown_performance):
3278         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
3279         (ChromiumAndroidPortTest):
3280         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3281         (PortTestCase):
3282         (PortTestCase.make_port):
3283         (PortTestCase.test_default_worker_model):
3284
3285 2012-02-13  Adam Barth  <abarth@webkit.org>
3286
3287         Implement enough of ChromiumAndroidPort to make ChromiumAndroidPortTest pass
3288         https://bugs.webkit.org/show_bug.cgi?id=78550
3289
3290         Reviewed by Eric Seidel.
3291
3292         Much of this code just forwards to the "host" port, which seems like a
3293         reasonable thing to do.
3294
3295         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3296         (ChromiumAndroidPort.__init__):
3297         (ChromiumAndroidPort.stop_helper):
3298         (ChromiumAndroidPort):
3299         (ChromiumAndroidPort._build_path):
3300         (ChromiumAndroidPort._path_to_apache):
3301         (ChromiumAndroidPort._path_to_apache_config_file):
3302         (ChromiumAndroidPort._path_to_driver):
3303         (ChromiumAndroidPort._path_to_helper):
3304         (ChromiumAndroidPort._path_to_image_diff):
3305         (ChromiumAndroidPort._path_to_lighttpd):
3306         (ChromiumAndroidPort._path_to_lighttpd_modules):
3307         (ChromiumAndroidPort._path_to_lighttpd_php):
3308         (ChromiumAndroidPort._path_to_wdiff):
3309         (ChromiumAndroidPort._shut_down_http_server):
3310         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
3311         (ChromiumAndroidPortTest):
3312         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3313         (PortTestCase):
3314         (PortTestCase.make_port):
3315         (PortTestCase.test_default_worker_model):
3316
3317 2012-02-13  Adam Barth  <abarth@webkit.org>
3318
3319         chromium_android.py should implement "virtual" methods from ChromiumPort
3320         https://bugs.webkit.org/show_bug.cgi?id=78545
3321
3322         Reviewed by Dirk Pranke.
3323
3324         This patch adds basic implementations that specialize a bunch of
3325         functions from ChromiumPort.
3326
3327         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3328         (ChromiumAndroidPort):
3329         (ChromiumAndroidPort.__init__):
3330         (ChromiumAndroidPort.default_child_processes):
3331         (ChromiumAndroidPort.baseline_search_path):
3332         (ChromiumAndroidPort.check_build):
3333         (ChromiumAndroidPort.check_sys_deps):
3334         (ChromiumAndroidPort.default_worker_model):
3335         (ChromiumAndroidPort.test_expectations):
3336         (ChromiumAndroidPort.start_http_server):
3337         (ChromiumAndroidPort.stop_http_server):
3338         (ChromiumAndroidPort.start_helper):
3339         (ChromiumAndroidPort.stop_helper):
3340
3341 2012-02-13  Adam Barth  <abarth@webkit.org>
3342
3343         Add a skeleton ChromiumAndroid port to webkitpy
3344         https://bugs.webkit.org/show_bug.cgi?id=78543
3345
3346         Reviewed by Eric Seidel.
3347
3348         This patch just adds an empty ChromiumAndroid port object to webkitpy
3349         and wires it up to the factory objects.  An actual implementation will
3350         follow.
3351
3352         * Scripts/webkitpy/layout_tests/port/chromium.py:
3353         (ChromiumPort):
3354         * Scripts/webkitpy/layout_tests/port/chromium_android.py: Added.
3355         (ChromiumAndroidPort):
3356         (ChromiumAndroidPort.__init__):
3357         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3358         (ChromiumPortTest.test_all_test_configurations):
3359         * Scripts/webkitpy/layout_tests/port/factory.py:
3360         (PortFactory):
3361
3362 2012-02-13  Adam Barth  <abarth@webkit.org>
3363
3364         NRWT's HTTP servers should support additional directories for resources
3365         https://bugs.webkit.org/show_bug.cgi?id=78528
3366
3367         Reviewed by Eric Seidel.
3368
3369         This functionality will be used by the Chromium-Android port.
3370
3371         * Scripts/webkitpy/layout_tests/port/base.py:
3372         (Port.to.start_http_server):
3373         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
3374         (LayoutTestApacheHttpd.__init__):
3375         * Scripts/webkitpy/layout_tests/servers/http_server.py:
3376         (Lighttpd.__init__):
3377         (Lighttpd._prepare_config):
3378
3379 2012-02-13  Ami Fischman  <fischman@chromium.org>
3380
3381         Add fischman as committer.
3382
3383         Unreviewed
3384
3385         * Scripts/webkitpy/common/config/committers.py:
3386
3387 2012-02-06  Raphael Kubo da Costa  <kubo@profusion.mobi>
3388
3389         [EFL] Drop support for the Curl network backend.
3390         https://bugs.webkit.org/show_bug.cgi?id=77874
3391
3392         Reviewed by Eric Seidel.
3393
3394         Nobody seems to be maintaining the Curl backend in WebCore, the
3395         EFL port developers all seem to be using the Soup backend and the
3396         port itself has many features which are only implemented for the
3397         latter.
3398
3399         * DumpRenderTree/efl/CMakeLists.txt: Always link to glib/libsoup
3400         and always add the required include directories.
3401         * EWebLauncher/CMakeLists.txt: Add the required glib/libsoup
3402         include directories and link to them.
3403
3404 2012-02-13  Kenichi Ishibashi  <bashi@chromium.org>
3405
3406         [WebSocket] Update pywebsocket to 0.7.1
3407         https://bugs.webkit.org/show_bug.cgi?id=78484
3408
3409         pywebsocket-0.7.1 follow the current draft of WebSocket deflate-frame extension.
3410
3411         Reviewed by Kent Tamura.
3412
3413         * Scripts/webkitpy/thirdparty/__init__.py:
3414         (AutoinstallImportHook._install_pywebsocket):
3415
3416 2012-02-12  Kangil Han  <kangil.han@samsung.com>
3417
3418         [EFL][DRT] Implement zoomPage{In,Out} and textZoom{In,Out} events.
3419         https://bugs.webkit.org/show_bug.cgi?id=78091
3420
3421         Reviewed by Hajime Morita.
3422
3423         Implemented zoomPageIn, zoomPageOut, textZoomIn and textZoomOut events on EFL DRT.
3424         This patch will activate around 1,900 test cases from skipped list in EFL port.
3425
3426         * DumpRenderTree/efl/EventSender.cpp:
3427         (textZoom):
3428         (pageZoom):
3429         (textZoomInCallback):
3430         (textZoomOutCallback):
3431         (zoomPageInCallback):
3432         (zoomPageOutCallback):
3433
3434 2012-02-12  Ashod Nakashian  <ashodnakashian@yahoo.com>
3435
3436         KeywordLookupGenerator.py script fails in some cases
3437         https://bugs.webkit.org/show_bug.cgi?id=77886
3438
3439         Reviewed by Benjamin Poulain.
3440
3441         * Scripts/webkitpy/style/checker.py: New rule for Keywords.table to not have CR.
3442         * Scripts/webkitpy/style/checker_unittest.py: New UT for Keywords.table rule.
3443         (GlobalVariablesTest.test_path_rules_specifier):
3444
3445 2012-02-12  Joe Thomas  <joethomas@motorola.com>
3446
3447         Add toText and isTextNode helpers in Text class.
3448         https://bugs.webkit.org/show_bug.cgi?id=78140
3449
3450         Unit test case for the new style checker introduced.
3451
3452         Reviewed by Adam Barth.
3453
3454         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3455         (CppStyleTest):
3456         (CppStyleTest.test_static_cast_readability): Added a unit test case.
3457
3458 2012-02-12  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3459
3460         Enable features supported by EFL port in build-webkit.
3461         https://bugs.webkit.org/show_bug.cgi?id=78348
3462
3463         Reviewed by Ryosuke Niwa.
3464
3465         Sync build-webkit with OptionEfl.cmake, as some features enabled in
3466         OptionEfl.cmake are not enabled in build-webkit.
3467
3468         * Scripts/build-webkit:
3469
3470 2012-02-12  Joe Thomas  <joethomas@motorola.com>
3471
3472         Add toText and isTextNode helpers in Text class.
3473         https://bugs.webkit.org/show_bug.cgi?id=78140
3474
3475         Added a style checker to use toText rather than static_cast<Text*>.
3476
3477         Reviewed by Adam Barth.
3478
3479         * Scripts/webkitpy/style/checkers/cpp.py:
3480         (check_language): Style checker for static_cast<Text*>.
3481
3482 2012-02-12  Philippe Normand  <pnormand@igalia.com>
3483
3484         Unreviewed, disable Mutation observers build on GTK until it can
3485         actually build.
3486
3487         * Scripts/build-webkit:
3488
3489 2012-02-11  Benjamin Poulain  <benjamin@webkit.org>
3490
3491         Add back WTFURL to WebKit
3492         https://bugs.webkit.org/show_bug.cgi?id=77291
3493
3494         Reviewed by Adam Barth.
3495
3496         Add a flag to build-webkit to easily build WebKit with WTFURL.
3497
3498         * Scripts/build-webkit:
3499
3500 2012-02-10  Adam Klein  <adamk@chromium.org>
3501
3502         Enable MUTATION_OBSERVERS by default on all platforms
3503         https://bugs.webkit.org/show_bug.cgi?id=78196
3504
3505         Reviewed by Ojan Vafai.
3506
3507         * Scripts/build-webkit:
3508
3509 2012-02-10  Adam Barth  <abarth@webkit.org>
3510
3511         Move garden-o-matic's All Failures out of experimental
3512         https://bugs.webkit.org/show_bug.cgi?id=78395
3513
3514         Reviewed by Dimitri Glazkov.
3515
3516         Several folks have tried this feature and found it useful.
3517
3518         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
3519
3520 2012-02-10  Tim Horton  <timothy_horton@apple.com>
3521
3522         NRWT should categorize options in --help
3523         https://bugs.webkit.org/show_bug.cgi?id=76221
3524
3525         Reviewed by Eric Seidel.
3526         
3527         Use optparse's OptionGroup mechanism to logically group NRWT's options,
3528         providing a better experience when scanning all the options.
3529
3530         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3531         (parse_args):
3532
3533 2012-02-10  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
3534
3535         [Qt][WK2] Refactor on Qt5 Layout tests' structure
3536         https://bugs.webkit.org/show_bug.cgi?id=77450
3537
3538         Reviewed by Csaba Osztrogonác.
3539
3540         Fix the scripts and related unittest due to the rename of qt-wk2 and qt-wk1
3541         to qt-5.0-wk2 and qt-5.0-wk1.
3542
3543         * Scripts/old-run-webkit-tests:
3544         (buildPlatformResultHierarchy):
3545         (readSkippedFiles):
3546         * Scripts/webkitpy/layout_tests/port/qt.py:
3547         (QtPort._wk2_port_name):
3548         (QtPort._skipped_file_search_paths):
3549         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
3550         (QtPortTest.test_baseline_search_path):
3551         * Scripts/webkitpy/layout_tests/port/webkit.py:
3552         (WebKitPort._wk2_port_name):
3553
3554 2012-02-09  Philippe Normand  <pnormand@igalia.com>
3555
3556         [GTK] EWS command-line option to run the tests
3557         https://bugs.webkit.org/show_bug.cgi?id=78211
3558
3559         Reviewed by Adam Barth.
3560
3561         New --run-tests option (defaults to False) for the EWS commands.
3562
3563         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3564         (AbstractEarlyWarningSystem):
3565         (AbstractEarlyWarningSystem.__init__):
3566         (AbstractEarlyWarningSystem.review_patch):
3567         (ChromiumLinuxEWS):
3568         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3569         (EarlyWarningSytemTest._test_builder_ews):
3570
3571 2012-02-09  Eric Seidel  <eric@webkit.org>
3572
3573         Rename compare_text and compare_audio to make it clear that they're !=
3574         https://bugs.webkit.org/show_bug.cgi?id=78301
3575
3576         Reviewed by Adam Barth.
3577
3578         I also removed the maybe_create_directory function which was redundant.
3579
3580         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3581         (Manager.set_up_run):
3582         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3583         (TestResultWriter._make_output_directory):
3584         * Scripts/webkitpy/layout_tests/port/base.py:
3585         (Port.do_text_results_differ):
3586         (Port.do_audio_results_differ):
3587         (Port.diff_text):
3588         (Port.driver_name):
3589         (Port.skips_perf_test):
3590         * Scripts/webkitpy/layout_tests/port/win.py:
3591         (WinPort.do_text_results_differ):
3592         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
3593         (WinPortTest.test_do_text_results_differ):
3594         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
3595         (LayoutTestApacheHttpd.__init__):
3596         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
3597         (HttpServerBase.__init__):
3598         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
3599         (Rebaseliner._diff_baselines):
3600
3601 2012-02-09  Zan Dobersek  <zandobersek@gmail.com>
3602
3603         [GTK] Add DRT support for modal dialogs
3604         https://bugs.webkit.org/show_bug.cgi?id=53600
3605
3606         Reviewed by Martin Robinson.
3607
3608         Implement the modal dialogs handling in DumpRenderTree and GtkLauncher.
3609         Most significantly, when creating a new web view in GtkLauncher, the window
3610         of the web view opener is passed around. In DumpRenderTree, the window of
3611         the main web view is always considered as the opener. This is required so
3612         the modal dialog's toplevel can be made transient for the opener's toplevel.
3613
3614         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3615         (webViewRunModalDialog):
3616         (createWebView):
3617         * GtkLauncher/main.c:
3618         (createWebViewCb):
3619         (runModalDialogCb):
3620         (createBrowser):
3621         (createWindow):
3622         (main):
3623
3624 2012-02-09  Zan Dobersek  <zandobersek@gmail.com>
3625
3626         [Gtk] security/set-form-autocomplete-attribute.html fails
3627         https://bugs.webkit.org/show_bug.cgi?id=78261
3628
3629         Reviewed by Martin Robinson.
3630
3631         Use the new helper in DumpRenderTreeSupportGtk to properly
3632         test whether an element performs autocompletion.
3633
3634         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3635         (LayoutTestController::elementDoesAutoCompleteForElementWithId):
3636
3637 2012-02-09  James Robinson  <jamesr@chromium.org>
3638
3639         [chromium] Enable mock scrollbars for compositing layout tests
3640         https://bugs.webkit.org/show_bug.cgi?id=78299
3641
3642         Reviewed by Dirk Pranke.
3643
3644         This enables mock scrollbars by default for compositing tests. These pixel tests are intended to test the
3645         compositor behavior, not native theming, and having real scrollbars causes us to have to maintain significantly
3646         more pngs than we should and expose weird alpha bugs in our theming that doesn't impact real users.
3647
3648         * DumpRenderTree/chromium/TestShell.cpp:
3649         (TestShell::runFileTest):
3650         * DumpRenderTree/chromium/WebPreferences.cpp:
3651         (WebPreferences::reset):
3652         (WebPreferences::applyTo):
3653         * DumpRenderTree/chromium/WebPreferences.h:
3654         (WebPreferences):
3655
3656 2012-02-09  Eric Seidel  <eric@webkit.org>
3657
3658         Remove more uses of "os" from our webkitpy code
3659         https://bugs.webkit.org/show_bug.cgi?id=78292
3660
3661         Reviewed by Adam Barth.
3662
3663         * Scripts/webkitpy/common/checkout/checkout_mock.py:
3664         (MockCheckout.__init__):
3665         (MockCheckout.is_path_to_changelog):
3666         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3667         * Scripts/webkitpy/common/system/filesystem_mock.py:
3668         (MockFileSystem._split):
3669         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
3670         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3671         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3672         * Scripts/webkitpy/layout_tests/port/webkit.py:
3673         * Scripts/webkitpy/tool/bot/queueengine.py:
3674         * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
3675         * Scripts/webkitpy/tool/commands/download.py:
3676         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3677         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
3678         * Scripts/webkitpy/tool/commands/sheriffbot.py:
3679         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
3680         * Scripts/webkitpy/tool/commands/upload.py:
3681         (CreateBug.prompt_for_bug_title_and_comment):
3682         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
3683         * Scripts/webkitpy/tool/steps/attachtobug.py:
3684         (AttachToBug.run):
3685         * Scripts/webkitpy/tool/steps/checkstyle.py:
3686         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
3687         * Scripts/webkitpy/tool/steps/commit_unittest.py:
3688         * Scripts/webkitpy/tool/steps/editchangelog.py:
3689         * Scripts/webkitpy/tool/steps/preparechangelog.py:
3690         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
3691         (PrepareChangeLogTest.test_ensure_bug_url):
3692         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
3693         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
3694         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
3695         * Scripts/webkitpy/tool/steps/validatereviewer.py:
3696
3697 2012-02-09  Eric Seidel  <eric@webkit.org>
3698
3699         Remove the cr-mac-ews (it's long been dead)
3700         https://bugs.webkit.org/show_bug.cgi?id=78267
3701
3702         Reviewed by Adam Barth.
3703
3704         * QueueStatusServer/model/queues.py:
3705         (Queue):
3706         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3707         (ChromiumWindowsEWS):
3708         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3709         (EarlyWarningSytemTest._test_builder_ews):
3710         (EarlyWarningSytemTest._test_testing_ews):
3711
3712 2012-02-09  Dirk Pranke  <dpranke@chromium.org>
3713
3714         some tests in webkitpy are being run three times
3715         https://bugs.webkit.org/show_bug.cgi?id=78283
3716
3717         Reviewed by Ryosuke Niwa.
3718
3719         It turns out that if you import a class derived from
3720         unittest.TestCase as a base name (e.g., from ... import ChangeLogTest),
3721         the unittest framework treats it as if the class was defined in
3722         the file (as well in the original file). This led us to running
3723         the tests in ChangeLogTest three times.
3724
3725         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
3726         (PrepareChangeLogTest):
3727         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
3728         (_assert_message_for_revert_output):
3729
3730 2012-02-09  Adam Barth  <abarth@webkit.org>
3731
3732         Remove extraneous line in previous patch.  I forgot to remove this
3733   &n