Partially revert http://trac.webkit.org/r200504
[WebKit-https.git] / Tools / ChangeLog
1 2016-05-05  Alexey Proskuryakov  <ap@apple.com>
2
3         Partially revert http://trac.webkit.org/r200504
4         Improve HTTP test names in WebKitTestRunner's crash report information
5         https://bugs.webkit.org/show_bug.cgi?id=157389
6
7         * WebKitTestRunner/cocoa/CrashReporterInfo.mm: Turns out that we can't have URLs
8         in crash reporter information.
9
10 2016-05-05  Alexey Proskuryakov  <ap@apple.com>
11
12         Improve HTTP test names in WebKitTestRunner's crash report information
13         https://bugs.webkit.org/show_bug.cgi?id=157389
14
15         Reviewed by Alex Christensen.
16
17         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
18         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame): Added a FIXME.
19
20         * WebKitTestRunner/cocoa/CrashReporterInfo.mm:
21         (WTR::testDescription): Don't bail out if the port is neither 8000 nor 8443; we
22         use other port numbers too. For http tests, return the complete URL string, not
23         just the path.
24
25 2016-05-04  Alex Christensen  <achristensen@webkit.org>
26
27         Blocked redirected main resource requests need descriptive errors
28         https://bugs.webkit.org/show_bug.cgi?id=156828
29         rdar://problem/25711316
30
31         Reviewed by Daniel Bates.
32
33         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
34         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
35         Print out the error type to make sure we have the most descriptive error type.
36
37 2016-05-05  Enrique Ocaña González  <eocanha@igalia.com>
38
39         [GStreamer] Bump internal jhbuild versions to 1.8.0 and patches to support MSE
40         https://bugs.webkit.org/show_bug.cgi?id=157341
41
42         Reviewed by Xabier Rodriguez-Calvar.
43
44         * gtk/jhbuild.modules:
45         * gtk/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Added.
46         * gtk/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Added.
47
48 2016-05-04  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
49
50         Add JSC test results in JSON format to a Buildbot log
51         https://bugs.webkit.org/show_bug.cgi?id=156920
52
53         Reviewed by Daniel Bates.
54
55         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
56         (RunJavaScriptCoreTests): Move command-line option for output file out
57         of WithProperties.
58
59 2016-05-04  Dean Jackson  <dino@apple.com>
60
61         TestRunner should always enable all the experimental features
62         https://bugs.webkit.org/show_bug.cgi?id=157360
63         <rdar://problem/26099748>
64
65         Reviewed by Anders Carlsson.
66
67         Call the new SPI that enables all the experimental features.
68
69         * WebKitTestRunner/TestController.cpp:
70         (WTR::TestController::resetPreferencesToConsistentValues):
71
72 2016-05-04  Mark Lam  <mark.lam@apple.com>
73
74         ES6 Function.name inferred from property names of literal objects can break some websites.
75         https://bugs.webkit.org/show_bug.cgi?id=157246
76
77         Reviewed by Geoffrey Garen.
78
79         * WebKitTestRunner/TestController.cpp:
80         (WTR::TestController::resetPreferencesToConsistentValues):
81         (WTR::updateTestOptionsFromTestHeader):
82         * WebKitTestRunner/TestOptions.h:
83
84         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
85         (WTR::PlatformWebView::viewSupportsOptions):
86         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
87         (WTR::PlatformWebView::viewSupportsOptions):
88         - Add needsSiteSpecificQuirks to WKTR options that can be set. 
89
90 2016-05-04  Joanmarie Diggs  <jdiggs@igalia.com>
91
92         AX: ARIA 'region' role is now a landmark; HTML 'section' element should be a landmark only if named
93         https://bugs.webkit.org/show_bug.cgi?id=157331
94
95         Reviewed by Chris Fleizach.
96
97         Add AXLandmarkRegion to the landmark strings handled by roleToString
98         for objects with ATK_ROLE_LANDMARK.
99
100         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
101
102 2016-05-03  Beth Dakin  <bdakin@apple.com>
103
104         Add VideoControlsManager tests
105         https://bugs.webkit.org/show_bug.cgi?id=157332
106         -and corresponding-
107         rdar://problem/24358431
108
109         Reviewed by Sam Weinig.
110
111         This patch adds three VideoControlsManager tests.
112
113         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
114         * TestWebKitAPI/Tests/WebKit/ios/video-with-audio.html:
115         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm: Added.
116         (-[DidPlayMessageHandler initWithWKWebView:]):
117         (-[DidPlayMessageHandler userContentController:didReceiveScriptMessage:]):
118         (TestWebKitAPI::TEST):
119         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-with-audio.html: Added.
120         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-with-audio.mp4: Added.
121         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-without-audio.html: Added.
122
123 2016-05-03  Joanmarie Diggs  <jdiggs@igalia.com>
124
125         [ATK] accessibility/document-attributes.html is failing
126         https://bugs.webkit.org/show_bug.cgi?id=125348
127
128         Reviewed by Chris Fleizach.
129
130         The test was failing because the WebArea is now being exposed with the role of
131         ATK_ROLE_DOCUMENT_WEB; not ATK_ROLE_DOCUMENT_FRAME. Unfortunately, when that
132         change was made, documentEncoding() and documentURI() were not updated accordingly.
133
134         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
135         (WTR::AccessibilityUIElement::documentEncoding):
136         (WTR::AccessibilityUIElement::documentURI):
137
138 2016-05-03  Brent Fulgham  <bfulgham@apple.com>
139
140         [Win] Unreviewed build fix.
141
142         * EWSTools/start-queue-win.sh: Establish proper VS2015 build
143         environment at start of queue run.
144
145 2016-05-03  Joanmarie Diggs  <jdiggs@igalia.com>
146
147         [ATK] accessibility/content-editable-as-textarea.html fails
148         https://bugs.webkit.org/show_bug.cgi?id=155353
149
150         Reviewed by Darin Adler.
151
152         The test was timing out because it expected an AXValueChanged notification.
153         In ATK, AXValueChanged notifications are made for widgets which implement
154         the AtkValue interface (sliders, progress bars, etc.). We should be listening
155         for AXTextChanged instead. AtkText's text-insert and text-remove have been
156         added to the AccessibilityNotificationHandler.
157
158         Also, ATK's AccessibilityUIElement support had a number of unimplemented
159         methods that are being used as part of the previously-failing test. Those
160         methods are now implemented so that the ATK results are much more similar
161         to those on the Mac.
162
163         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
164         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
165         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
166         (WTR::AccessibilityUIElement::stringAttributeValue):
167         (WTR::AccessibilityUIElement::rangeForLine):
168         (WTR::AccessibilityUIElement::boundsForRange):
169         (WTR::AccessibilityUIElement::attributedStringForRange):
170
171 2016-05-02  Brady Eidson  <beidson@apple.com>
172
173         Add the ability to accumulate logs for specific logging channels to help diagnose test timeouts.
174         https://bugs.webkit.org/show_bug.cgi?id=157274
175
176         Reviewed by Alex Christensen.
177
178         Add the new accumulate method to DRT's TestRunner, dump the accumulated logs if there's a timeout,
179         and reset them in between tests:
180         * DumpRenderTree/TestRunner.cpp:
181         (accummulateLogsForChannel):
182         (TestRunner::staticFunctions):
183         (TestRunner::waitToDumpWatchdogTimerFired):
184         (TestRunner::setAccummulateLogsForChannel):
185         * DumpRenderTree/TestRunner.h:
186         * DumpRenderTree/mac/DumpRenderTree.mm:
187         (resetWebViewToConsistentStateBeforeTesting):
188
189         Also add the new method to WKTR's TestRunner, but just stubbed for now:
190         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
191         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
192         (WTR::TestRunner::accummulateLogsForChannel):
193         * WebKitTestRunner/InjectedBundle/TestRunner.h:
194
195 2016-05-02  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
196
197         Add fail-fast option to run-javascriptcore-tests
198         https://bugs.webkit.org/show_bug.cgi?id=157270
199
200         Reviewed by Geoffrey Garen.
201
202         * Scripts/run-javascriptcore-tests: Add fail-fast command line option.
203         Defaults to yes, which is the current behavior.
204
205 2016-05-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
206
207         [CMake] MiniBrowser fails to build because libsoup link flags are not defined.
208         https://bugs.webkit.org/show_bug.cgi?id=157268
209
210         Reviewed by Michael Catanzaro.
211
212         * MiniBrowser/gtk/CMakeLists.txt:
213
214 2016-04-30  Darin Adler  <darin@apple.com>
215
216         Streamline and remove unused bindings generation code
217         https://bugs.webkit.org/show_bug.cgi?id=157237
218
219         Reviewed by Chris Dumez.
220
221         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
222         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
223         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
224         Replace non-standard "int" with standard "long", which means the same thing.
225
226 2016-04-30  Darin Adler  <darin@apple.com>
227
228         Next batch of conversions to use C++ enum class instead of strings for enumerations
229         https://bugs.webkit.org/show_bug.cgi?id=157232
230
231         Reviewed by Chris Dumez.
232
233         * Scripts/webkitpy/style/checker.py: Skip the bindings script tests when doing style
234         checking. We don't want to waste time trying to make our generated code match our style.
235
236 2016-04-29  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
237
238         Add JSC test results in JSON format to a Buildbot log.
239         https://bugs.webkit.org/show_bug.cgi?id=156920
240
241         Reviewed by Daniel Bates.
242
243         Generate JSON results for JSC tests and upload them to the master
244         using Buildbot's logfiles machinery.
245
246         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
247         (RunJavaScriptCoreTests): Use --json-output option when invoking the
248         run-javascriptcore-tests Perl script, and expose this JSON output as a 
249         Buildbot log.
250         * Scripts/run-javascriptcore-tests:
251         (runJSCStressTests): Change key names and remove redundant count key.
252
253 2016-04-29  Joanmarie Diggs  <jdiggs@igalia.com>
254
255         [ATK] Expose the value of aria-roledescription via an AtkObject attribute
256         https://bugs.webkit.org/show_bug.cgi?id=146719
257
258         Reviewed by Chris Fleizach.
259
260         Implement roleDescription() so that the implementation can be tested.
261
262         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
263         (WTR::AccessibilityUIElement::roleDescription):
264
265 2016-04-27  Alexey Proskuryakov  <ap@apple.com>
266
267         Don't throttle GuardMalloc on 8-core Macs
268         https://bugs.webkit.org/show_bug.cgi?id=157108
269
270         Reviewed by Alex Christensen.
271
272         This was making them slower unnecessarily.
273
274         * Scripts/webkitpy/port/mac.py: (MacPort.default_child_processes):
275
276 2016-04-26  Konstantin Tokarev  <annulen@yandex.ru>
277
278         Unreviewed: add myself to the committers list.
279
280         * Scripts/webkitpy/common/config/contributors.json:
281
282 2016-04-26  Ryosuke Niwa  <rniwa@webkit.org>
283
284         Fix text in log files autogenerated by import-w3c-tests
285         https://bugs.webkit.org/show_bug.cgi?id=157021
286
287         Unreviewed. Fixing the second typo.
288
289         * Scripts/webkitpy/w3c/test_importer.py:
290         (TestImporter.write_import_log):
291
292 2016-04-26  Filip Pizlo  <fpizlo@apple.com>
293
294         WebCore on Mac ignores the user's preferred region (country) while getting the language
295         https://bugs.webkit.org/show_bug.cgi?id=156993
296
297         Reviewed by Geoffrey Garen.
298
299         Change the test expectations for this test. If the variant is not explicitly specified in
300         the AppleLanguage, then we use the locale's country code, which this test assumes is US.
301
302         * TestWebKitAPI/Tests/mac/NavigatorLanguage.mm:
303         (TestWebKitAPI::languageForSystemLanguage):
304         (TestWebKitAPI::TEST):
305
306 2016-04-25  Ryosuke Niwa  <rniwa@webkit.org>
307
308         Remove the build flag for template elements
309         https://bugs.webkit.org/show_bug.cgi?id=157022
310
311         Reviewed by Daniel Bates.
312
313         Removed the build option.
314
315         * Scripts/webkitperl/FeatureList.pm:
316
317 2016-04-25  Ryosuke Niwa  <rniwa@webkit.org>
318
319         Fix text in log files autogenerated by import-w3c-tests
320         https://bugs.webkit.org/show_bug.cgi?id=157021
321
322         Reviewed by Chris Dumez.
323
324         s/Webkit/WebKit/ and end each sentence with a period.
325
326         * Scripts/webkitpy/w3c/test_importer.py:
327         (TestImporter.write_import_log):
328
329 2016-04-25  Myles C. Maxfield  <mmaxfield@apple.com>
330
331         [Cocoa] Guarantee FontPlatformData's m_cgFont is never nullptr
332         https://bugs.webkit.org/show_bug.cgi?id=156929
333
334         Reviewed by Darin Adler.
335
336         * TestWebKitAPI/Tests/mac/StringTruncator.mm:
337         (TestWebKitAPI::TEST):
338
339 2016-04-25  Caitlin Potter  <caitp@igalia.com>
340
341         [Tools] whitelist all-uppercase JSTokenType enum in JavaScriptCore
342         https://bugs.webkit.org/show_bug.cgi?id=156976
343
344         Reviewed by Darin Adler.
345
346         Mitigate style-checker spam on bugs which introduce new JavaScript
347         token types.
348
349         * Scripts/webkitpy/style/checkers/cpp.py:
350         (_EnumState.__init__):
351         (_EnumState.process_clean_line):
352         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
353         (NoNonVirtualDestructorsTest.test_enum_casing):
354
355 2016-04-25  Simon Fraser  <simon.fraser@apple.com>
356
357         Fix issues with content-animation performance tests
358         https://bugs.webkit.org/show_bug.cgi?id=157001
359
360         Reviewed by Sam Weinig.
361
362         Add patch content for svg-animation.html, and fix the paths in the patch so
363         it applies correctly.
364
365         Add the patch file to the .plan file.
366
367         * Scripts/webkitpy/benchmark_runner/data/patches/ContentAnimation.patch:
368         * Scripts/webkitpy/benchmark_runner/data/plans/content-animation.plan:
369
370 2016-04-25  Brady Eidson  <beidson@apple.com>
371
372         Tweaking IndexedDB watchlist and adding myself to it.
373
374         * Scripts/webkitpy/common/config/watchlist:
375
376 2016-04-25  Commit Queue  <commit-queue@webkit.org>
377
378         Unreviewed, rolling out r199916.
379         https://bugs.webkit.org/show_bug.cgi?id=156989
380
381         Might break buildbot when master is restarted (Requested by
382         Srinivasan Vijayaraghava, Guest100, on #webkit).
383
384         Reverted changeset:
385
386         "Add JSC test results in json format to a buildbot log"
387         https://bugs.webkit.org/show_bug.cgi?id=156920
388         http://trac.webkit.org/changeset/199916
389
390 2016-04-23  Chris Dumez  <cdumez@apple.com>
391
392         [WebIDL] Drop [Default] WebKit-IDL extended attribute
393         https://bugs.webkit.org/show_bug.cgi?id=156955
394
395         Reviewed by Darin Adler.
396
397         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
398
399 2016-04-23  Csaba Osztrogonác  <ossy@webkit.org>
400
401         Really enable INDEXED_DATABASE on Apple Mac cmake build
402         https://bugs.webkit.org/show_bug.cgi?id=156902
403
404         Reviewed by Michael Catanzaro.
405
406         * Scripts/webkitperl/FeatureList.pm:
407
408 2016-04-23  Andy Estes  <aestes@apple.com>
409
410         check-webkit-style: fix false-positive warnings about @synchronized
411         https://bugs.webkit.org/show_bug.cgi?id=156957
412
413         Reviewed by Dan Bernstein.
414
415         * Scripts/webkitpy/style/checkers/cpp.py:
416         (check_spacing_for_function_call): Ignore @synchronized lines.
417         (check_braces): Ditto.
418         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
419         (CppStyleTest.test_brace_at_begin_of_line): Added a test case.
420
421 2016-04-22  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
422
423         Add JSC test results in json format to a buildbot log
424         https://bugs.webkit.org/show_bug.cgi?id=156920
425
426         Reviewed by Alexey Proskuryakov.
427
428         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
429         (RunJavaScriptCoreTests):
430         Add runtime flag to output json into buildbot
431         * Scripts/run-javascriptcore-tests:
432         (runJSCStressTests):
433         Change key names and remove redundant count key
434
435 2016-04-22  Ryan Haddad  <ryanhaddad@apple.com>
436
437         Update expected result for WKPreferencesGetOfflineWebApplicationCacheEnabled after r199854
438
439         Unreviewed test gardening.
440
441         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
442         (TestWebKitAPI::TEST):
443
444 2016-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
445
446         [GTK] Enable the download attribute support
447         https://bugs.webkit.org/show_bug.cgi?id=99025
448
449         Reviewed by Žan Doberšek.
450
451         * Scripts/webkitperl/FeatureList.pm:
452
453 2016-04-21  Keith Miller  <keith_miller@apple.com>
454
455         WebScriptObject description swizzler should work in a multi-threaded world
456         https://bugs.webkit.org/show_bug.cgi?id=156808
457
458         Add a test for our NSObject swizzling TLS implementation. The test runs on
459         two threads. One in JS and another in Objective-C. We expect the JS thread
460         to use our NSObject description override and the Objective-C thread to act
461         as though it was using the original NSObject description method.
462
463         Reviewed by Geoffrey Garen.
464
465         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
466         * TestWebKitAPI/Tests/mac/WebScriptObjectDescription.html: Added.
467         * TestWebKitAPI/Tests/mac/WebScriptObjectDescription.mm: Added.
468         (nsObjectDescriptionTest):
469         (-[WebScriptDescriptionTest webView:didFinishLoadForFrame:]):
470         (TestWebKitAPI::TEST):
471
472 2016-04-21  Carlos Garcia Campos  <cgarcia@igalia.com>
473
474         [GTK] WebKitWebView should claim the contents size as its natural size
475         https://bugs.webkit.org/show_bug.cgi?id=156835
476
477         Reviewed by Žan Doberšek.
478
479         Add test case to check the WebKitWebView preferred size.
480
481         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
482         (testWebViewPreferredSize):
483         (beforeAll):
484
485 2016-04-20  Simon Fraser  <simon.fraser@apple.com>
486
487         Add content animation tests to benchmark_runner, and allow the runner to collect device data as part of the results
488         https://bugs.webkit.org/show_bug.cgi?id=156827
489         
490         Update the .plan file now that the files are present in SVN.
491
492         * Scripts/webkitpy/benchmark_runner/data/plans/content-animation.plan:
493
494 2016-04-20  Simon Fraser  <simon.fraser@apple.com>
495
496         Add content animation tests to benchmark_runner, and allow the runner to collect device data as part of the results
497         https://bugs.webkit.org/show_bug.cgi?id=156827
498         rdar://problem/24358135
499
500         Reviewed by Stephanie Lewis.
501
502         Enhance benchmark_runner so that a benchmark can load a set of tests sequentially,
503         and collate results across them. Also add the ability for the browser_driver to supply
504         additional results, allowing for tests that collect results data in native code, rather
505         than generating it in the web page.
506
507         Add a set of "content animation" tests that use this new functionality, which test
508         CSS animation and requestAnimationFrame performance.
509
510         'plan' files have two new optional keys:
511             'test_files': a list of files to run as a suite
512             'options': optional parameters. Currently supports one new option,
513                 'animation_command', which affects the way that iOS tests are run,
514                 and is passed to MobileSafari as a parameter on launch.
515
516         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
517         (BenchmarkRunner.__init__): If options is not specified in the plan file, set it to an empty dictionary.
518         (BenchmarkRunner._get_result): Allow the browser_driver to modify the test results.
519         (BenchmarkRunner):
520         (BenchmarkRunner._run_one_test): Factored out of _run_benchmark, this contains logic for
521         running a single test. It starts and stops the http_server_driver.
522         (BenchmarkRunner._run_benchmark): Run a test in the traditional way if the plan has an 'entry_point'
523         key, otherwise look for the new 'test_files' and load each in a loop.
524         (BenchmarkRunner._dump):
525         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
526         (BrowserDriver.launch_url): Pass options.
527         (BrowserDriver.add_additional_results): Allow a driver to supply additional results.
528         (BrowserDriver):
529         * Scripts/webkitpy/benchmark_runner/browser_driver/gtk_minibrowser_driver.py:
530         (GTKMiniBrowserDriver.launch_url):
531         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
532         (OSXBrowserDriver.close_browsers):
533         (OSXBrowserDriver._terminate_processes): Fix spelling mistake.
534         (OSXBrowserDriver._terminiate_processes): Deleted.
535         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
536         (OSXChromeDriver.launch_url):
537         (OSXChromeCanaryDriver.launch_url):
538         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
539         (OSXFirefoxDriver.launch_url):
540         (OSXFirefoxNightlyDriver.launch_url):
541         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
542         (OSXSafariDriver.launch_url):
543         * Scripts/webkitpy/benchmark_runner/data/patches/ContentAnimation.patch: Added.
544         * Scripts/webkitpy/benchmark_runner/data/plans/content-animation.plan: Added.
545
546 2016-04-20  Dustin Falgout  <dustin@falgout.us>
547
548         [GTK] Expose AllowUniversalAccessFromFileURLs preference now that calling localStorage.getItem() results in SecurityError: DOM Exception 18
549         https://bugs.webkit.org/show_bug.cgi?id=156651
550
551         Reviewed by Michael Catanzaro.
552
553         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
554         (testWebKitSettings):
555
556 2016-04-20  Brady Eidson  <beidson@apple.com>
557
558         Modern IDB (Workers): Enable INDEXED_DATABASE_IN_WORKERS compile time flag, but disabled in RuntimeEnabledFeatures.
559         https://bugs.webkit.org/show_bug.cgi?id=156782
560
561         Reviewed by Alex Christensen.
562
563         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
564
565 2016-04-19  Brent Fulgham  <bfulgham@apple.com>
566
567         Unreviewed build fix after r199752.
568
569         * DumpRenderTree/win/FrameLoadDelegate.cpp:
570         (FrameLoadDelegate::didChangeIcons): Remove call to removed function.
571
572 2016-04-19  Brent Fulgham  <bfulgham@apple.com>
573
574         Remove remaining bits of dynamic <link> rel='icon' loading
575         https://bugs.webkit.org/show_bug.cgi?id=156727
576
577         Reviewed by Darin Adler.
578
579         Remove unused test infrastructure. This code never existed in WebKit2
580         testing since was only used on Windows.
581
582         * DumpRenderTree/TestRunner.cpp:
583         (dumpIconChangesCallback): Deleted.
584         * DumpRenderTree/TestRunner.h:
585         (TestRunner::dumpIconChanges): Deleted.
586         (TestRunner::setDumpIconChanges): Deleted.
587
588 2016-04-19  Keith Miller  <keith_miller@apple.com>
589
590         ObjcInstance::stringValue should not call NSObject's description method
591         https://bugs.webkit.org/show_bug.cgi?id=156758
592
593         Reviewed by Geoffrey Garen.
594
595         Add new methods to ObjCController that expose two Types of WebScriptObjects. The first is
596         an NSObject and the second is an NSArray of NSObjects. These are used to test that we don't
597         call the NSObjects description method without first swizzling it.
598
599         * DumpRenderTree/mac/ObjCController.m:
600         (+[ObjCController isSelectorExcludedFromWebScript:]):
601         (+[ObjCController webScriptNameForSelector:]):
602         (-[ObjCController testArrayOfObjects]):
603         (-[ObjCController testObject]):
604
605 2016-04-18  Dan Bernstein  <mitz@apple.com>
606
607         Fixed building with old Xcode.
608
609         * TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm:
610         (TEST):
611
612 2016-04-18  Dean Jackson  <dino@apple.com>
613
614         New SPI to export a dictionary of runtime features
615         https://bugs.webkit.org/show_bug.cgi?id=156645
616         <rdar://problem/23621666>
617
618         Reviewed by Darin Adler.
619
620         Test the experimental features SPI on WKPreferences.
621
622         * TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm:
623
624 2016-04-18  Yusuke Suzuki  <utatane.tea@gmail.com>
625
626         [JSCOnly] Implement RunLoop and remove glib dependency
627         https://bugs.webkit.org/show_bug.cgi?id=155706
628
629         Reviewed by Michael Catanzaro.
630
631         Add TestWTF to JSCOnly port to test WorkQueue and RunLoop.
632         Platform specific ones locate under jsconly directory since
633         it is not `generic` (Since it includes the GLIB event loop case).
634
635         * CMakeLists.txt:
636         * TestWebKitAPI/PlatformJSCOnly.cmake: Added.
637         * TestWebKitAPI/PlatformUtilities.h:
638         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
639         (TestWebKitAPI::TEST):
640         * TestWebKitAPI/config.h:
641         * TestWebKitAPI/jsconly/PlatformUtilitiesJSCOnly.cpp: Renamed from Source/WTF/wtf/none/RunLoopNone.cpp.
642         (TestWebKitAPI::Util::run):
643         (TestWebKitAPI::Util::sleep):
644         * TestWebKitAPI/jsconly/main.cpp: Renamed from Source/WTF/wtf/none/WorkQueueNone.cpp.
645         (main):
646
647 2016-04-18  Jon Lee  <jonlee@apple.com>
648
649         Update Animometer plan.
650         https://bugs.webkit.org/show_bug.cgi?id=156652
651
652         Reviewed by Darin Adler.
653
654         * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Update to r199616.
655
656 2016-04-18  Dana Burkart  <dburkart@apple.com>
657
658         svn-apply: add option for ignoring changes to ChangeLog files
659         https://bugs.webkit.org/show_bug.cgi?id=156618
660
661         Reviewed by Darin Adler.
662
663         This change adds a new option to svn-apply, --skip-changelogs, which short-circuits out of
664         patch() if the file in question is a ChangeLog.
665
666         * Scripts/svn-apply:
667         (patch):
668
669 2016-04-18  Carlos Garcia Campos  <cgarcia@igalia.com>
670
671         Pending API Request URL is wrong after reloading
672         https://bugs.webkit.org/show_bug.cgi?id=139342
673
674         Reviewed by Darin Adler.
675
676         Update test case to check that the active URL should remain the
677         same after a reload.
678
679         * TestWebKitAPI/Tests/WebKit2/PendingAPIRequestURL.cpp:
680         (TestWebKitAPI::TEST):
681
682 2016-04-18  Carlos Garcia Campos  <cgarcia@igalia.com>
683
684         Pending API request URL no set when loading Data, Alternate HTML or plain text
685         https://bugs.webkit.org/show_bug.cgi?id=136916
686
687         Reviewed by Darin Adler.
688
689         Add new test to check that active URL is the requested one right
690         after calling WKPage load methods.
691
692         * TestWebKitAPI/PlatformEfl.cmake:
693         * TestWebKitAPI/PlatformGTK.cmake:
694         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
695         * TestWebKitAPI/Tests/WebKit2/PendingAPIRequestURL.cpp: Added.
696         (TestWebKitAPI::TEST):
697         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
698         (WebViewTest::loadPlainText): Remove FIXME.
699         (WebViewTest::loadBytes): Ditto.
700         (WebViewTest::loadAlternateHTML): Ditto.
701
702 2016-04-18  Commit Queue  <commit-queue@webkit.org>
703
704         Unreviewed, rolling out r199660.
705         https://bugs.webkit.org/show_bug.cgi?id=156691
706
707         It broke the iOS build (Requested by KaL on #webkit).
708
709         Reverted changeset:
710
711         "Pending API request URL no set when loading Data, Alternate
712         HTML or plain text"
713         https://bugs.webkit.org/show_bug.cgi?id=136916
714         http://trac.webkit.org/changeset/199660
715
716 2016-04-18  Carlos Garcia Campos  <cgarcia@igalia.com>
717
718         Pending API request URL no set when loading Data, Alternate HTML or plain text
719         https://bugs.webkit.org/show_bug.cgi?id=136916
720
721         Reviewed by Darin Adler.
722
723         Add new test to check that active URL is the requested one right
724         after calling WKPage load methods.
725
726         * TestWebKitAPI/PlatformEfl.cmake:
727         * TestWebKitAPI/PlatformGTK.cmake:
728         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
729         * TestWebKitAPI/Tests/WebKit2/PendingAPIRequestURL.cpp: Added.
730         (TestWebKitAPI::TEST):
731         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
732         (WebViewTest::loadPlainText): Remove FIXME.
733         (WebViewTest::loadBytes): Ditto.
734         (WebViewTest::loadAlternateHTML): Ditto.
735
736 2016-04-18  Jeremy Huddleston Sequoia  <jeremyhu@apple.com>
737
738         Fix incorrect assumption that APPLE implies Mac.
739         https://bugs.webkit.org/show_bug.cgi?id=156679
740
741         Addresses build failure introduced in r198947
742
743         Reviewed by Alex Christensen.
744
745         * CMakeLists.txt:
746
747 2016-04-18  Carlos Garcia Campos  <cgarcia@igalia.com>
748
749         [GTK] Test /webkit2/WebKitWebView/mouse-target fails with overlay scrollbars
750         https://bugs.webkit.org/show_bug.cgi?id=156621
751
752         Reviewed by Martin Robinson.
753
754         This is a problem of the test itself, we are using an overflow that is not actually scrollable, but that shows
755         scrollbar troughs when not using overlay scrollbars because it's marked as scrollable. It would be easier to
756         simply use the main frame scrollbars to test that and it will work no matter of scrollbars are overlay or not.
757
758         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
759         (testWebViewMouseTarget): Remove the div and move the mouse over the main frame scrollbar to test scrolbars hit test.
760
761 2016-04-17  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
762
763         [EFL] Bump gstreamer from 1.4.4 to 1.6.3
764         https://bugs.webkit.org/show_bug.cgi?id=156655
765
766         Reviewed by Antonio Gomes.
767
768         To support html5 video feature, we should bump gstreamer version.
769
770         * efl/jhbuild.modules:
771         * efl/patches/gst-libav.patch: Update against newer version.
772         * efl/patches/gst-plugins-bad-remove-gnustep-support.patch: Removed because this patch was merged.
773
774 2016-04-16  Sam Weinig  <sam@webkit.org>
775
776         More build fixing.
777
778         * MiniBrowser/mac/BrowserWindowController.m:
779         (-[BrowserWindowController share:]):
780
781 2016-04-16  Sam Weinig  <sam@webkit.org>
782
783         Another build fix.
784
785         * MiniBrowser/mac/BrowserWindowController.m:
786         (-[BrowserWindowController sharingServicePicker:sharingServicesForItems:proposedSharingServices:]):
787
788 2016-04-16  Sam Weinig  <sam@webkit.org>
789
790         Fix 32-bit build.
791
792         * MiniBrowser/mac/BrowserWindowController.m:
793         (-[BrowserWindowController share:]):
794         (-[BrowserWindowController fetch:]):
795         (-[BrowserWindowController sharingService:transitionImageForShareItem:contentRect:]):
796
797 2016-04-15  Sam Weinig  <sam@webkit.org>
798
799         Add support for NSSharingService to MiniBrowser, for no great reasons
800         https://bugs.webkit.org/show_bug.cgi?id=156658
801
802         Reviewed by Darin Adler.
803
804         * MiniBrowser/mac/BrowserWindow.xib:
805         * MiniBrowser/mac/BrowserWindowController.h:
806         Add the share button.
807
808         * MiniBrowser/mac/BrowserWindowController.m:
809         (-[BrowserWindowController windowDidLoad]):
810         Set the share button to fire it's actions on mouse down, as it is supposed to act like a menu.
811
812         (-[BrowserWindowController share:]):
813         Show the picker when the button is pressed.
814         (-[BrowserWindowController mainContentView]):
815         Add a new override to get the main content view of derived classes (either a WKWebView or the WebView).
816
817         (-[BrowserWindowController sharingServicePicker:sharingServicesForItems:proposedSharingServices:]):
818         (-[BrowserWindowController sharingServicePicker:delegateForSharingService:]):
819         (-[BrowserWindowController sharingServicePicker:didChooseSharingService:]):
820         (-[BrowserWindowController sharingService:sourceFrameOnScreenForShareItem:]):
821         (-[BrowserWindowController sharingService:transitionImageForShareItem:contentRect:]):
822         (-[BrowserWindowController sharingService:sourceWindowForShareItems:sharingContentScope:]):
823         Add delegate methods.
824
825         * MiniBrowser/mac/WK1BrowserWindowController.m:
826         (-[WK1BrowserWindowController mainContentView]):
827         * MiniBrowser/mac/WK2BrowserWindowController.m:
828         (-[WK2BrowserWindowController mainContentView]):
829         Implement to return the web view.
830
831 2016-04-16  Alexey Proskuryakov  <ap@apple.com>
832
833         Build fix.
834
835         Temporary workaround for rdar://problem/25754945.
836
837         * LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h:
838
839 2016-04-15  Commit Queue  <commit-queue@webkit.org>
840
841         Unreviewed, rolling out r199600.
842         https://bugs.webkit.org/show_bug.cgi?id=156642
843
844         It didn't help (Requested by ap_ on #webkit).
845
846         Reverted changeset:
847
848         "Build fix."
849         http://trac.webkit.org/changeset/199600
850
851 2016-04-15  Alexey Proskuryakov  <ap@apple.com>
852
853         Build fix.
854
855         * LayoutTestRelay/LayoutTestRelay/main.m: Allow some deprecated methods.
856
857 2016-04-14  Alexey Proskuryakov  <ap@apple.com>
858
859         Some GuardMalloc bots are not happy when running many parallel processes
860         https://bugs.webkit.org/show_bug.cgi?id=156614
861         rdar://problem/24711525
862
863         Reviewed by David Kilzer.
864
865         * Scripts/webkitpy/port/mac.py: (MacPort.default_child_processes):
866
867 2016-04-14  Brent Fulgham  <bfulgham@apple.com>
868
869         Make <a download> a runtime enabled option
870         https://bugs.webkit.org/show_bug.cgi?id=156583
871         <rdar://problem/25733449>
872
873         Reviewed by Alex Christensen.
874
875         * DumpRenderTree/mac/DumpRenderTree.mm:
876         (resetWebPreferencesToConsistentValues):
877         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
878         (WTR::InjectedBundle::beginTesting):
879         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
880         (WTR::TestRunner::setDownloadAttributeEnabled):
881         * WebKitTestRunner/InjectedBundle/TestRunner.h:
882
883 2016-04-14  Anders Carlsson  <andersca@apple.com>
884
885         Another build fix attempt.
886
887         * MiniBrowser/mac/WK2BrowserWindowController.m:
888
889 2016-04-14  Anders Carlsson  <andersca@apple.com>
890
891         Fix build.
892
893         * MiniBrowser/mac/WK2BrowserWindowController.m:
894         (-[WK2BrowserWindowController webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
895
896 2016-04-14  Anders Carlsson  <andersca@apple.com>
897
898         [Mac] Add API for open panel handling to WKWebView
899         https://bugs.webkit.org/show_bug.cgi?id=137759
900         rdar://problem/23278623
901
902         Reviewed by Tim Horton.
903
904         Have MiniBrowser implement the new delegate method.
905
906         * MiniBrowser/mac/WK2BrowserWindowController.m:
907         (-[WK2BrowserWindowController webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
908
909 2016-04-14  Jiewen Tan  <jiewen_tan@apple.com>
910
911         Unreviewed, rolling out r199554.
912
913         The change breaks Yosemite Release/Debug build
914
915         Reverted changeset:
916
917         "[Mac] Add API for open panel handling to WKWebView"
918         https://bugs.webkit.org/show_bug.cgi?id=137759
919         http://trac.webkit.org/changeset/199554
920
921 2016-04-14  Anders Carlsson  <andersca@apple.com>
922
923         [Mac] Add API for open panel handling to WKWebView
924         https://bugs.webkit.org/show_bug.cgi?id=137759
925         rdar://problem/23278623
926
927         Reviewed by Tim Horton.
928
929         Have MiniBrowser implement the new delegate method.
930
931         * MiniBrowser/mac/WK2BrowserWindowController.m:
932         (-[WK2BrowserWindowController webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
933
934 2016-04-14  Jon Lee  <jonlee@apple.com>
935
936         Update Animometer plan
937         https://bugs.webkit.org/show_bug.cgi?id=156569
938
939         Reviewed by Alex Christensen.
940
941         * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Update to r199328. Includes update to screen
942         resolution, starting with complexity of 1, and fixing SVG, multiply, and text tests.
943
944 2016-04-13  Alex Christensen  <achristensen@webkit.org>
945
946         CMake MiniBrowser should be an app bundle
947         https://bugs.webkit.org/show_bug.cgi?id=156521
948
949         Reviewed by Brent Fulgham.
950
951         * MiniBrowser/mac/CMakeLists.txt:
952         Make an app bundle and compile nibs.
953         * MiniBrowser/mac/Info.plist:
954         CMake doesn't know what to do with :rfc1034identifier and there's no reason to keep it.  This is just MiniBrowser.
955
956 2016-04-13  Chris Dumez  <cdumez@apple.com>
957
958         We should not speculatively revalidate cached redirects
959         https://bugs.webkit.org/show_bug.cgi?id=156548
960         <rdar://problem/25583886>
961
962         Reviewed by Darin Adler.
963
964         Re-enable speculative loading in the context of layout tests. This was
965         turned off by mistake when speculative loading was turned into a
966         setting recently.
967
968         * WebKitTestRunner/TestController.cpp:
969         (WTR::TestController::generatePageConfiguration):
970
971 2016-04-12  Alexey Proskuryakov  <ap@apple.com>
972
973         Python test webkitpy.common.system.executive_unittest.ExecutiveTest.serial_test_kill_process is flaky
974         https://bugs.webkit.org/show_bug.cgi?id=155367
975
976         Reviewed by Darin Adler.
977
978         * Scripts/webkitpy/common/system/executive.py: (Executive.kill_process):
979         Don't flakily consume the return code with waitpid, callers need to do waitpid on
980         their own. Not sure if this line of code was even intentional.
981
982 2016-04-12  Myles C. Maxfield  <mmaxfield@apple.com>
983
984         [OS X] Flakey crash after ScrollAnimatorMac destruction
985         https://bugs.webkit.org/show_bug.cgi?id=156372
986
987         Reviewed by Darin Adler.
988
989         Implement the new <!-- webkit-test-runner --> flag.
990
991         * WebKitTestRunner/TestController.cpp:
992         (WTR::TestController::createWebViewWithOptions):
993         (WTR::TestController::ensureViewSupportsOptionsForTest):
994         (WTR::TestController::resetPreferencesToConsistentValues):
995         (WTR::TestController::resetStateToConsistentValues):
996         (WTR::updateTestOptionsFromTestHeader):
997         * WebKitTestRunner/TestController.h:
998         * WebKitTestRunner/TestInvocation.cpp:
999         (WTR::TestInvocation::invoke):
1000         * WebKitTestRunner/TestOptions.h:
1001         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1002         (WKR::PlatformWebView::viewSupportsOptions):
1003
1004 2016-04-12  Tomas Popela  <tpopela@redhat.com>
1005
1006         Modify the CXXFLAGS in webkitdirs.pm just on architectures where the flags are supported
1007         https://bugs.webkit.org/show_bug.cgi?id=156338
1008
1009         Reviewed by Michael Catanzaro.
1010
1011         Add the "-march=pentium4 -msse2 -mfpmath=sse " into the CXXFLAGS just
1012         for the i686 where it is supported and not for other architectures
1013         (such as s390(x) and ppc(64)) where the build will fail with these
1014         CXXFLAGS.
1015
1016         * Scripts/webkitdirs.pm:
1017         (generateBuildSystemFromCMakeProject):
1018
1019 2016-04-11  Alex Christensen  <achristensen@webkit.org>
1020
1021         Build MiniBrowser with CMake on Mac
1022         https://bugs.webkit.org/show_bug.cgi?id=156471
1023
1024         Reviewed by Daniel Bates.
1025
1026         * CMakeLists.txt:
1027         * DumpRenderTree/CMakeLists.txt:
1028         * DumpRenderTree/PlatformWin.cmake:
1029         * MiniBrowser/mac/CMakeLists.txt: Added.
1030
1031 2016-04-11  Ryuan Choi  <ryuan.choi@navercorp.com>
1032
1033         [EFL] Do not pass context to EwkViewCreate
1034         https://bugs.webkit.org/show_bug.cgi?id=156461
1035
1036         Reviewed by Darin Adler.
1037
1038         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
1039         (TestWebKitAPI::TEST): Removed context argument from EwkViewCreate calls.
1040         * TestWebKitAPI/efl/PlatformWebView.cpp:
1041         (TestWebKitAPI::PlatformWebView::PlatformWebView): Ditto.
1042         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1043         (WTR::PlatformWebView::PlatformWebView): Ditto.
1044
1045 2016-04-11  Fujii Hironori  <Hironori.Fujii@jp.sony.com>
1046
1047         [CMake] Make FOLDER property INHERITED
1048         https://bugs.webkit.org/show_bug.cgi?id=156460
1049
1050         Reviewed by Brent Fulgham.
1051
1052         * CMakeLists.txt:
1053         * DumpRenderTree/CMakeLists.txt:
1054         * DumpRenderTree/PlatformWin.cmake:
1055         * ImageDiff/CMakeLists.txt:
1056         * MiniBrowser/efl/CMakeLists.txt:
1057         * MiniBrowser/gtk/CMakeLists.txt:
1058         * MiniBrowser/win/CMakeLists.txt:
1059         Set FOLDER property as a directory property not a target property
1060
1061 2016-04-10  Caitlin Potter  <caitp@igalia.com>
1062
1063         [Tools] correctly check for braces in multiline branches in macro definition
1064         https://bugs.webkit.org/show_bug.cgi?id=156441
1065
1066         Reviewed by Darin Adler.
1067
1068         Prevents emitting whitespace/braces warning for code like the
1069         following:
1070
1071         ```
1072         #define MACRO(x) \
1073             if (x) { \
1074                 doTheThing(); \
1075                 continue; \
1076             }
1077         ```
1078
1079         * Scripts/webkitpy/style/checkers/cpp.py:
1080         (check_braces):
1081         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1082         (WebKitStyleTest.test_line_breaking):
1083
1084 2016-04-08  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1085
1086         Testharness-based tests that time out should be able to produce a detailed output
1087         https://bugs.webkit.org/show_bug.cgi?id=145313
1088
1089         Reviewed by Xabier Rodriguez-Calvar.
1090
1091         Adding timeout readonly accessor to TestRunner for both WK1 and WK2.
1092
1093         * DumpRenderTree/TestRunner.cpp:
1094         (getTimeoutCallback): The js "timeout" property getter.
1095         (TestRunner::staticValues): Adding "timeout" property to DumpRenderTree so that testRunner.timeout called from JS returns the timeout value.
1096         * DumpRenderTree/TestRunner.h:
1097         (TestRunner::timeout): Adding access to DRT m_timeout private value.
1098         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Adding timeout readonly attribute so that testRunner.timeout can be called from JS.
1099         * WebKitTestRunner/InjectedBundle/TestRunner.h: Adding DOM timeout getter to implement timeout IDL definition.
1100         (WTR::TestRunner::timeout):
1101
1102 2016-04-07  Joseph Pecoraro  <pecoraro@apple.com>
1103
1104         stylebot should know about TestWebKitAPI FeatureDefines.xcconfig
1105         https://bugs.webkit.org/show_bug.cgi?id=156387
1106
1107         Rubber-stamped by Dan Bernstein.
1108
1109         * Scripts/webkitpy/style/checkers/featuredefines.py:
1110         (FeatureDefinesChecker.check):
1111
1112 2016-04-07  Joseph Pecoraro  <pecoraro@apple.com>
1113
1114         Remove ENABLE(ENABLE_ES6_CLASS_SYNTAX) guards
1115         https://bugs.webkit.org/show_bug.cgi?id=156384
1116
1117         Reviewed by Ryosuke Niwa.
1118
1119         * Scripts/webkitperl/FeatureList.pm:
1120         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1121
1122 2016-04-06  Dean Jackson  <dino@apple.com>
1123
1124         Watchlist modifications:
1125         - remove roger_fong
1126         - add myself to a few areas
1127         - remove graouts from WebInspectorAPI
1128
1129         * Scripts/webkitpy/common/config/watchlist:
1130
1131 2016-04-07  Simon Fraser  <simon.fraser@apple.com>
1132
1133         Make it possible to test effect of view exposed rect on tiled backing
1134         https://bugs.webkit.org/show_bug.cgi?id=156365
1135
1136         Reviewed by Tim Horton.
1137
1138         Expose testRunner.setViewSize() and internals.setViewExposedRect() to enable
1139         testing of tile coverage when setViewExposedRect() is passed a non-null rectangle.
1140
1141         testRunner.setViewSize() is used instead of using window.resizeTo(), since we
1142         can't easily resize a window to larger than the screen being tested on.
1143
1144         * DumpRenderTree/TestRunner.cpp:
1145         (setViewSizeCallback):
1146         (TestRunner::staticFunctions):
1147         * DumpRenderTree/TestRunner.h:
1148         * DumpRenderTree/mac/TestRunnerMac.mm:
1149         (TestRunner::setViewSize):
1150         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1151         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1152         (WTR::InjectedBundle::postSetViewSize):
1153         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1154         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1155         (WTR::TestRunner::setViewSize):
1156         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1157         * WebKitTestRunner/TestInvocation.cpp:
1158         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1159
1160 2016-04-07  Jason Marcell  <jmarcell@apple.com>
1161
1162         Adding layout tests for the bot watcher's dashboard QUnit tests.
1163         https://bugs.webkit.org/show_bug.cgi?id=155272
1164
1165         Reviewed by Daniel Bates.
1166
1167         Moved supporting resources into a resources folder and updated index.html accordingly
1168         to point to the new locations. Added code to tests.js to dumpAsText when QUnit is done.
1169
1170         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index-expected.txt: Added.
1171         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index.html: Updated to point to tests.js and Mock files in resources directory.
1172         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbotQueue.js: Renamed from
1173         Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueue.js.
1174         (MockBuildbotQueue):
1175         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbotQueueView.js: Renamed from
1176         Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueueView.js.
1177         (MockBuildbotQueueView):
1178         (MockBuildbotQueueView.prototype._latestProductiveIteration):
1179         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockTrac.js: Renamed from
1180         Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js.
1181         (MockTrac):
1182         (MockTrac.prototype.get oldestRecordedRevisionNumber):
1183         (MockTrac.prototype.get latestRecordedRevisionNumber):
1184         (MockTrac.prototype.loadMoreHistoricalData):
1185         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/test-fixture-git-trac-rss.xml: Renamed from
1186         Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/test-fixture-git-trac-rss.xml.
1187         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/test-fixture-trac-rss.xml: Renamed from
1188         Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/test-fixture-trac-rss.xml.
1189         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js: Renamed from
1190         Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js.
1191         Updated the unit tests for Trac._loaded() to point to the XML files that are now located in the 'resources' directory.
1192         (QUnit.done): Added. Removes machine-specific output from test results and calls testRunner.notifyDone to let the layout test harness know that all testing is done.
1193         * Scripts/run-dashboard-tests: Added.
1194
1195 2016-04-06  ChangSeok Oh  <changseok@webkit.org>
1196
1197         Unreviewed, Update my primary email address and expertise.
1198
1199         * Scripts/webkitpy/common/config/contributors.json:
1200
1201 2016-04-06  Jon Lee  <jonlee@apple.com>
1202
1203         Update the Animometer patch and plan files
1204         https://bugs.webkit.org/show_bug.cgi?id=156263
1205
1206         Reviewed by Ryosuke Niwa.
1207
1208         Measure the latest set of tests by updating the plan revision to r199134.
1209
1210         * Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch: Update to run the master suite only.
1211         * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Update to use the release page instead
1212         of the developer page.
1213
1214 2016-04-06  Saam barati  <sbarati@apple.com>
1215
1216         jsc-layout-tests.yaml/js/script-tests/regress-141098.js failing on Yosemite Debug after r198989
1217         https://bugs.webkit.org/show_bug.cgi?id=156187
1218
1219         Reviewed by Keith Miller.
1220
1221         * Scripts/run-jsc-stress-tests:
1222
1223 2016-04-06  Alex Christensen  <achristensen@webkit.org>
1224
1225         Compile WebKitTestRunner with CMake on Mac
1226         https://bugs.webkit.org/show_bug.cgi?id=156310
1227
1228         Reviewed by Daniel Bates.
1229
1230         * CMakeLists.txt:
1231         * WebKitTestRunner/CMakeLists.txt:
1232         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1233         * WebKitTestRunner/PlatformEfl.cmake:
1234         * WebKitTestRunner/PlatformGTK.cmake:
1235         * WebKitTestRunner/PlatformMac.cmake: Added.
1236
1237 2016-04-05  Simon Fraser  <simon.fraser@apple.com>
1238
1239         Implement operator== and operator!= for Optional<>
1240         https://bugs.webkit.org/show_bug.cgi?id=156266
1241
1242         Reviewed by Anders Carlsson.
1243
1244         * TestWebKitAPI/Tests/WTF/Optional.cpp:
1245         (TestWebKitAPI::TEST):
1246
1247 2016-04-05  Alex Christensen  <achristensen@webkit.org>
1248
1249         Make CMake-generated binaries on Mac able to run
1250         https://bugs.webkit.org/show_bug.cgi?id=156268
1251
1252         Reviewed by Daniel Bates.
1253
1254         * DumpRenderTree/CMakeLists.txt:
1255         * DumpRenderTree/PlatformMac.cmake:
1256         * DumpRenderTree/PlatformWin.cmake:
1257         * TestWebKitAPI/PlatformMac.cmake:
1258
1259 2016-04-05  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1260
1261         [Fetch API] Add a runtime flag to fetch API and related constructs
1262         https://bugs.webkit.org/show_bug.cgi?id=156113
1263  
1264         Reviewed by Alex Christensen.
1265
1266         * DumpRenderTree/TestRunner.h:
1267         * DumpRenderTree/mac/DumpRenderTree.mm:
1268         (resetWebPreferencesToConsistentValues):
1269         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1270         (WTR::InjectedBundle::beginTesting):
1271         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1272         (WTR::TestRunner::setWebGL2Enabled):
1273         (WTR::TestRunner::setFetchAPIEnabled):
1274         (WTR::TestRunner::setAllowUniversalAccessFromFileURLs):
1275         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1276
1277 2016-04-05  Keith Miller  <keith_miller@apple.com>
1278
1279         Make Keith a reviewer!
1280         https://bugs.webkit.org/show_bug.cgi?id=156246
1281
1282         Reviewed by Mark Lam.
1283
1284         * Scripts/webkitpy/common/config/contributors.json:
1285
1286 2016-04-05  Antoine Quint  <graouts@apple.com>
1287
1288         [WebGL2] Allow enabling WebGL2 with a runtime flag
1289         https://bugs.webkit.org/show_bug.cgi?id=156166
1290         <rdar://problem/25526929>
1291
1292         Always enable WebGL2 during testing.
1293
1294         Reviewed by Dean Jackson.
1295
1296         * DumpRenderTree/mac/DumpRenderTree.mm:
1297         (resetWebPreferencesToConsistentValues):
1298         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1299         (WTR::InjectedBundle::beginTesting):
1300         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1301         (WTR::TestRunner::setWebGL2Enabled):
1302         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1303
1304 2016-04-04  Bill Ming  <mbbill@gmail.com>
1305
1306         [win] run-webkit-tests failed to launch DumpRenderTree
1307         https://bugs.webkit.org/show_bug.cgi?id=156150
1308
1309         Reviewed by Alex Christensen.
1310
1311         * Tools/Scripts/webkitpy/port/base.py:
1312
1313 2016-04-04  Bill Ming  <mbbill@gmail.com>
1314
1315         prepare-ChangeLog set endl incorrectly.
1316         https://bugs.webkit.org/show_bug.cgi?id=156151
1317
1318         Reviewed by Alex Christensen.
1319
1320         * Tools/Scripts/prepare-ChangeLog:
1321
1322 2016-04-03  Sam Weinig  <sam@webkit.org>
1323
1324         Add SPI to allow install script message handlers in isolated worlds
1325         https://bugs.webkit.org/show_bug.cgi?id=156153
1326
1327         Reviewed by Anders Carlsson.
1328
1329         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
1330         Add new test, WKUserContentController.ScriptMessageHandlerBasicPostIsolatedWorld
1331
1332 2016-04-04  Jiewen Tan  <jiewen_tan@apple.com>
1333
1334         Build fix for r198956.
1335
1336         Unreviewed.
1337
1338         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadInvalidURLRequest.mm:
1339         (-[LoadInvalidURLNavigationActionDelegate webView:didFailProvisionalNavigation:withError:]):
1340         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm:
1341         (-[LoadInvalidURLWebFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
1342
1343 2016-04-04  Bill Ming  <mbbill@gmail.com>
1344
1345         [win] prepare-ChangeLog should treat windows path differently.
1346         https://bugs.webkit.org/show_bug.cgi?id=156120
1347
1348         Reviewed by Brent Fulgham.
1349
1350         * Scripts/prepare-ChangeLog:
1351
1352 2016-04-04  Alejandro G. Castro  <alex@igalia.com>
1353
1354         REGRESSION(r198492): [GTK] The WEB_RTC flag was not correctly added in some situations
1355         https://bugs.webkit.org/show_bug.cgi?id=156164
1356
1357         Reviewed by Philippe Normand.
1358
1359         Enable the new WEB_RTC option by default for Gtk+.
1360
1361         * Scripts/webkitperl/FeatureList.pm:
1362
1363 2016-04-03  Dan Bernstein  <mitz@apple.com>
1364
1365         Use the correct value for the first nightly build with frameworks built for OS X 10.11.
1366
1367         * Scripts/bisect-builds:
1368         (makeNightlyList):
1369
1370 2016-04-03  Dan Bernstein  <mitz@apple.com>
1371
1372         Made bisect-builds work again.
1373
1374         Rubber-stamped by Sam Weinig.
1375
1376         * Scripts/bisect-builds:
1377         Changed to use HTTPS to access nightly.webkit.org, and added a minimum revision for OS X 10.11.
1378
1379 2016-04-01  Jiewen Tan  <jiewen_tan@apple.com>
1380
1381         Build fix for r198956.
1382
1383         Unreviewed.
1384
1385         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1386         * TestWebKitAPI/Tests/WebKit2Cocoa/ProvisionalURLNotChange.mm: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Cocoa/ProvisionalURLChange.mm.
1387         (-[ProvisionalURLNotChangeController webView:didFinishNavigation:]):
1388         (-[ProvisionalURLNotChangeController webView:didFailProvisionalNavigation:withError:]):
1389         (TEST):
1390         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
1391         (-[LoadInvalidSchemeDelegate browsingContextController:didFailProvisionalLoadWithError:]):
1392         (TestWebKitAPI::TEST):
1393
1394 2016-04-01  Jiewen Tan  <jiewen_tan@apple.com>
1395
1396         WebKit should dispatchDidFailProvisionalLoad while loading invalid URLs
1397         https://bugs.webkit.org/show_bug.cgi?id=155995
1398         <rdar://problem/14967004>
1399
1400         Reviewed by Andy Estes.
1401
1402         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1403         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadAlternateHTMLString.mm:
1404         (-[LoadAlternateHTMLStringFromProvisionalLoadErrorController webView:didFailProvisionalNavigation:withError:]):
1405         (-[LoadAlternateHTMLStringFromProvisionalLoadErrorController webView:didStartProvisionalNavigation:]):
1406         (TEST):
1407         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadInvalidURLRequest.mm: Added.
1408         (literalURL):
1409         (-[LoadInvalidURLNavigationActionDelegate webView:didCommitNavigation:]):
1410         (-[LoadInvalidURLNavigationActionDelegate webView:didFailProvisionalNavigation:withError:]):
1411         (TestWebKitAPI::TEST):
1412         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.html: Added.
1413         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm: Added.
1414         (-[LoadInvalidURLWebFrameLoadDelegate webView:didCommitLoadForFrame:]):
1415         (-[LoadInvalidURLWebFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
1416         (TestWebKitAPI::TEST):
1417
1418 2016-04-01  Brent Fulgham  <bfulgham@apple.com>
1419
1420         Confirm <a download> satisfies specification criteria
1421         https://bugs.webkit.org/show_bug.cgi?id=156057
1422
1423         Reviewed by Andy Estes.
1424
1425         Revise WebKitTestRunner:
1426         (1) Provide a download client delegate.
1427         (2) Teach WKTR to wait to finish a test until a download finishes.
1428         (3) Allow WKTR to notify the current TestRunner that it can finish.
1429
1430         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1431         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1432         (WTR::InjectedBundle::didReceiveMessageToPage): Update to recognize a new
1433         message "NotifyDownloadDone".
1434         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1435         (WTR::InjectedBundlePage::decidePolicyForNavigationAction): Handle 'download'
1436         attribute case.
1437         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1438         (WTR::TestRunner::waitUntilDownload): Added.
1439         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1440         (WTR::TestRunner::shouldFinishAfterDownload): Added.
1441         * WebKitTestRunner/TestController.cpp:
1442         (WTR::TestController::createWebViewWithOptions): Set up the download client.
1443         (WTR::TestController::downloadDidStart): Added.
1444         (WTR::TestController::decideDestinationWithSuggestedFilename): Added.
1445         (WTR::TestController::downloadDidFinish): Added.
1446         (WTR::TestController::downloadDidFail): Added.
1447         (WTR::TestController::downloadDidCancel): Added.
1448         * WebKitTestRunner/TestController.h:
1449         * WebKitTestRunner/TestInvocation.cpp:
1450         (WTR::TestInvocation::notifyDownloadDone): Added.
1451         * WebKitTestRunner/TestInvocation.h:
1452
1453 2016-04-01  Alex Christensen  <achristensen@webkit.org>
1454
1455         Compile DumpRenderTree with CMake on Mac
1456         https://bugs.webkit.org/show_bug.cgi?id=156088
1457
1458         Reviewed by Brent Fulgham.
1459
1460         * CMakeLists.txt:
1461         * DumpRenderTree/CMakeLists.txt:
1462         * DumpRenderTree/DefaultPolicyDelegate.m:
1463         (-[DefaultPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
1464         * DumpRenderTree/DumpRenderTreeFileDraggingSource.m:
1465         * DumpRenderTree/PlatformMac.cmake: Added.
1466         * DumpRenderTree/PlatformWin.cmake:
1467         * DumpRenderTree/mac/AppleScriptController.m:
1468         (convertAEDescToObject):
1469         * DumpRenderTree/mac/DumpRenderTreeMain.mm:
1470         * DumpRenderTree/mac/LayoutTestHelper.m:
1471
1472 2016-03-31  Bill Ming  <mbbill@gmail.com>
1473
1474         https://bugs.webkit.org/show_bug.cgi?id=156094
1475         [Win] TestWebCore target build sometimes fail.
1476
1477         Reviewed by Alex Christensen.
1478
1479         * Tools/TestWebKitAPI/PlatformWin.cmake:
1480
1481 2016-03-31  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1482
1483         [EFL] Bump EFL version to 1.17.0
1484         https://bugs.webkit.org/show_bug.cgi?id=153008
1485
1486         Reviewed by Michael Catanzaro.
1487
1488         Original author is Csaba Osztrogonác  <ossy@webkit.org>
1489
1490         * efl/jhbuild.modules:
1491
1492 2016-03-31  Daniel Bates  <dabates@apple.com>
1493
1494         run-webkit-tests fails to create user's cache directory when System Integrity Protection is enabled
1495         https://bugs.webkit.org/show_bug.cgi?id=156071
1496         <rdar://problem/25467827>
1497
1498         Reviewed by Brent Fulgham.
1499
1500         Fixes an issue where run-webkit-tests will fail to create the suffixed user's cache directory
1501         on non-Apple Internal machines with System Integrity Protection enabled because the OS only
1502         honors the suffix, specified by the environment variable DIRHELPER_USER_DIR_SUFFIX, in
1503         privileged processes. And python(1) does not have sufficient privileges. As a workaround for
1504         systems that have System Integrity Protection enabled we compute the path to the suffixed
1505         user's cache directory by hand.
1506
1507         Additionally, fix an issue where the user's cache directory created by run-webkit-test was
1508         never deleted on cessation of the test run.
1509
1510         * Scripts/webkitpy/port/driver.py:
1511         (Driver._start): Actually store the path to the user's cache directory in self._driver_user_cache_directory
1512         so that we can delete this directory on cessation of the test run.
1513         * Scripts/webkitpy/port/mac.py:
1514         (MacPort):
1515         (MacPort._path_to_user_cache_directory): Unset the environment variable DIRHELPER_USER_DIR_SUFFIX (if set),
1516         query the OS for the path to the user's cache directory and concatenate this path with the
1517         specified suffix.
1518
1519 2016-03-31  Jiewen Tan  <jiewen_tan@apple.com>
1520
1521         WebKit should set Original URL of a download request correctly
1522         https://bugs.webkit.org/show_bug.cgi?id=155914
1523         <rdar://problem/10473811>
1524
1525         Reviewed by Anders Carlsson.
1526
1527         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1528         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1529         (-[DownloadRequestOriginalURLDelegate initWithExpectOriginalURL:]):
1530         (-[DownloadRequestOriginalURLDelegate _downloadDidStart:]):
1531         (-[DownloadRequestOriginalURLNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1532         (TEST):
1533         * TestWebKitAPI/Tests/WebKit2Cocoa/DownloadRequestOriginalURL.html: Added.
1534         * TestWebKitAPI/Tests/WebKit2Cocoa/DownloadRequestOriginalURL2.html: Added.
1535         * TestWebKitAPI/Tests/WebKit2Cocoa/DownloadRequestOriginalURLFrame.html: Added.
1536
1537 2016-03-30  Dewei Zhu  <dewei_zhu@apple.com>
1538
1539         Extend animometer timeout for slow CPUs.
1540         https://bugs.webkit.org/show_bug.cgi?id=156047
1541
1542         Reviewed by Ryosuke Niwa.
1543
1544         Extend animometer timeout to 30 minutes for slow device.
1545
1546         * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan:
1547
1548 2016-03-30  Daniel Bates  <dabates@apple.com>
1549
1550         run-webkit-tests must create parent directory of user's cache directory before running tests
1551         https://bugs.webkit.org/show_bug.cgi?id=156009
1552         <rdar://problem/25442682>
1553
1554         Reviewed by Alexey Proskuryakov.
1555
1556         The script run-webkit-tests must create the parent directory of the user's cache directory
1557         before running tests because a WebKit2 child process expects that this directory exists
1558         when it starts.
1559
1560         The script run-webkit-tests influences the path chosen by a WebKit2 child process for the
1561         user's temporary directory and user's cache directory via the environment variable
1562         DIRHELPER_USER_DIR_SUFFIX. For the user's temporary directory, run-webkit-tests creates it
1563         as part of setting up the test environment. But run-webkit-tests does not create the user's
1564         cache directory. Therefore there is race between the time AppKit creates it and when the
1565         launched WebContent and Network processes query for the path to the user's cache directory
1566         such that the OS may return the empty string to the WebContent and Network processes if
1567         queried for this directory before AppKit creates it.
1568
1569         * Scripts/webkitpy/port/base.py:
1570         (Port._path_to_user_cache_directory): Added. Base class implementation that returns the
1571         empty string. We will override this method for the OS X port to return the path to the
1572         user's cache directory with the specified suffix.
1573         (Port.remove_cache_directory): Deleted.
1574         * Scripts/webkitpy/port/driver.py:
1575         (Driver.__init__): Initialize self._driver_user_directory_suffix and self._driver_user_cache_directory
1576         to the suffix to use for the user's temporary and cache directories and the path to the
1577         user's cache directory, respectively.
1578         (Driver._setup_environ_for_driver): Modified to set the environment variable DIRHELPER_USER_DIR_SUFFIX
1579         to self._driver_user_directory_suffix.
1580         (Driver._start): Compute the user directory suffix and the path to the user's cache
1581         directory. Create the user's cache directory (if applicable).
1582         (Driver.stop): Modified to remove directory self._driver_user_cache_directory (if applicable).
1583         * Scripts/webkitpy/port/mac.py:
1584         (MacPort.user_cache_directory): Added. Overrides Port._path_to_user_cache_directory().
1585         (MacPort.remove_cache_directory): Deleted.
1586
1587 2016-03-29  Benjamin Poulain  <bpoulain@apple.com>
1588
1589         [WTF] Removing a smart pointer from HashTable issues two stores to the same location
1590         https://bugs.webkit.org/show_bug.cgi?id=155676
1591
1592         Reviewed by Darin Adler.
1593
1594         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1595         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
1596
1597 2016-03-29  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
1598
1599         Add machine-readable results for JSC stress tests
1600         https://bugs.webkit.org/show_bug.cgi?id=155771
1601
1602         Reviewed by Darin Adler and Dean Johnson
1603
1604         Add an option to output JSC stress test results to a user-specified file in JSON format.
1605
1606         * Scripts/run-javascriptcore-tests:
1607         (runJSCStressTests): Add JSON output support
1608         (readAllLines): Remove trailing newline from the end of each item
1609
1610 2016-03-29  Alex Christensen  <achristensen@webkit.org>
1611
1612         Fix Windows build.
1613
1614         * TestWebKitAPI/PlatformWin.cmake:
1615
1616 2016-03-29  Timothy Hatcher  <timothy@apple.com>
1617
1618         Update WebKit nightly to have a red needle to better match Safari
1619
1620         https://bugs.webkit.org/show_bug.cgi?id=155983
1621
1622         Reviewed by Joseph Pecoraro.
1623
1624         * WebKitLauncher/webkit.icns:
1625
1626 2016-03-28  Joanmarie Diggs  <jdiggs@igalia.com>
1627
1628         Adding myself as a reviewer.
1629
1630         Unreviewed.
1631
1632         * Scripts/webkitpy/common/config/contributors.json:
1633
1634 2016-03-25  Dewei Zhu  <dewei_zhu@apple.com>
1635
1636         Dromaeo patch used by run-benchmark should not include an invalid address.
1637         https://bugs.webkit.org/show_bug.cgi?id=155910
1638
1639         Reviewed by Ryosuke Niwa.
1640
1641         Should not use invalid 'http://127.0.0.1/Icons/w3c_home' in the patched version of test.
1642         * Scripts/webkitpy/benchmark_runner/data/patches/Dromaeo.patch:
1643
1644 2016-03-25  Daniel Bates  <dabates@apple.com>
1645
1646         Add WebKitSystemInterface for iOS 9.3
1647         https://bugs.webkit.org/show_bug.cgi?id=155893
1648
1649         Rubber-stamped by Alexey Proskuryakov.
1650
1651         * Scripts/copy-webkitlibraries-to-product-directory:
1652
1653 2016-03-25  Daniel Bates  <dabates@apple.com>
1654
1655         Use webkitdirs::determineXcodeSDK() instead of webkitdirs::willUseIOSDeviceSDK()
1656         in copy-webkitlibraries-to-product-directory
1657         https://bugs.webkit.org/show_bug.cgi?id=155869
1658
1659         Reviewed by Alexey Proskuryakov.
1660
1661         It is sufficient and more direct to call webkitdirs::determineXcodeSDK() instead of
1662         webkitdirs::willUseIOSDeviceSDK() to process the --sdk/--device/--ios-simulator command
1663         line argument.
1664
1665         * Scripts/copy-webkitlibraries-to-product-directory:
1666
1667 2016-03-25  Konstantin Tokarev  <annulen@yandex.ru>
1668
1669         Turned on ENABLE_REQUEST_ANIMATION_FRAME by default for any port.
1670         https://bugs.webkit.org/show_bug.cgi?id=155882
1671
1672         Reviewed by Michael Catanzaro.
1673
1674         It was already enabled in all trunk ports, and is required for
1675         WebInspectorUI to work.
1676
1677         * Scripts/webkitperl/FeatureList.pm:
1678
1679 2016-03-24  Jeremy Zerfas  <WebKit@JeremyZerfas.com>
1680
1681         Improve update-webkit-dependency script.
1682         https://bugs.webkit.org/show_bug.cgi?id=155576
1683
1684         Reviewed by Brent Fulgham.
1685
1686         * Scripts/update-webkit-dependency:
1687         -Updated script to also use ETags for helping to determine whether dependency is up to date.
1688         -Updated script so it usually won't need to download the entire dependency each time it is
1689          ran.
1690         -Updated script to ensure zip file contains expected directories before trying to install.
1691         -Added some more error checking and improved error messages.
1692         (lastModifiedToUnixTime): Deleted.
1693
1694         * Scripts/update-webkit-wincairo-libs:
1695         -Corrected comment about what script does.
1696
1697 2016-03-24 Bill Ming <mbbill@gmail.com>
1698
1699         Fix webkitpy tests after r198617
1700         https://bugs.webkit.org/show_bug.cgi?id=155827
1701
1702         Reviewed by Alex Christensen.
1703
1704         * Scripts/webkitpy/tool/steps/confirmdiff.py:
1705         (ConfirmDiff._show_pretty_diff):
1706
1707 2016-03-23  Bill Ming  <mbbill@gmail.com>
1708
1709         webkit-patch failed to open pretty diff on Windows
1710         https://bugs.webkit.org/show_bug.cgi?id=155827
1711
1712         Reviewed by Alex Christensen.
1713
1714         * Scripts/webkitpy/tool/steps/confirmdiff.py:
1715         (ConfirmDiff._show_pretty_diff):
1716
1717 2016-03-23  Jer Noble  <jer.noble@apple.com>
1718
1719         [ios-sim] RequiresUserActionForPlaybackTest.DoesNotRequireUserActionForMediaPlayback and RequiresUserActionForVideoButNotAudioPlayback failing
1720         https://bugs.webkit.org/show_bug.cgi?id=155764
1721
1722         Reviewed by Eric Carlson.
1723
1724         Remove the requirement for media elements to have webkit-playsinline attributes on iOS.
1725
1726         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
1727         (RequiresUserActionForPlaybackTest::SetUp):
1728
1729 2016-03-23  Anders Carlsson  <andersca@apple.com>
1730
1731         Crash when using KVO from within -[WebView initWithCoder:]
1732         https://bugs.webkit.org/show_bug.cgi?id=155816
1733         rdar://problem/17073265
1734
1735         Reviewed by Dan Bernstein.
1736
1737         Add test.
1738
1739         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1740         * TestWebKitAPI/Tests/mac/EarlyKVOCrash.mm: Added.
1741         (-[EarlyKVOCrashResponder initWithWebView:]):
1742         (-[EarlyKVOCrashResponder initWithCoder:]):
1743         (-[EarlyKVOCrashResponder dealloc]):
1744         (-[EarlyKVOCrashResponder encodeWithCoder:]):
1745         (TestWebKitAPI::TEST):
1746
1747 2016-03-23  Lucas Forschler  <lforschler@apple.com>
1748
1749         Teach kill-old-processes about perl 5.18.
1750         
1751         Reviewed by Alexey Proskuryakov
1752
1753         * BuildSlaveSupport/kill-old-processes:
1754         (main):
1755
1756 2016-03-22  Keith Rollin  <krollin@apple.com>
1757
1758         Unreviewed: add Keith Rollin to the committers list.
1759
1760         * Scripts/webkitpy/common/config/contributors.json:
1761
1762 2016-03-22  Per Arne Vollan  <peavo@outlook.com>
1763
1764         [Win] [64-bit] Remove MSVC 2013 FMA3 Bug Workaround
1765         https://bugs.webkit.org/show_bug.cgi?id=141499
1766
1767         Reviewed by Brent Fulgham.
1768
1769         As we have moved on to VS2015, this workaround is no longer needed.
1770
1771         * DumpRenderTree/cg/ImageDiffCG.cpp:
1772         (main):
1773         * DumpRenderTree/win/DumpRenderTree.cpp:
1774         (main):
1775         * DumpRenderTree/win/ImageDiffCairo.cpp:
1776         (main):
1777         * MiniBrowser/win/Common.cpp:
1778         (DllMain):
1779         * TestWebKitAPI/win/main.cpp:
1780         (main):
1781         * win/DLLLauncher/DLLLauncherMain.cpp:
1782         (wWinMain):
1783
1784 2016-03-22  Yusuke Suzuki  <utatane.tea@gmail.com>
1785
1786         [JSC] ASMBench cannot be run without JSBENCH_PATH
1787         https://bugs.webkit.org/show_bug.cgi?id=155751
1788
1789         Reviewed by Saam Barati.
1790
1791         Check ASMBENCH_PATH instead of JSBENCH_PATH for ASMBench files.
1792
1793         * Scripts/run-jsc-benchmarks:
1794
1795 2016-03-21  Brent Fulgham  <bfulgham@apple.com>
1796
1797         [Win] SharedBuffer::copy() can cause a segmentation fault.
1798         https://bugs.webkit.org/show_bug.cgi?id=155739
1799
1800         Reviewed by Ryosuke Niwa.
1801
1802         * TestWebKitAPI/PlatformWin.cmake: Build and run the
1803         SharedBuffer tests.
1804
1805 2016-03-22  Csaba Osztrogonác  <ossy@webkit.org>
1806
1807         [buildbot] Move ARM Linux bots to JSCOnly port
1808         https://bugs.webkit.org/show_bug.cgi?id=155655
1809
1810         Reviewed by Lucas Forschler.
1811
1812         * BuildSlaveSupport/build.webkit.org-config/config.json:
1813         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1814         (ConfigureBuild.__init__):
1815         (appendCustomBuildFlags):
1816         (CompileJSCOnly):
1817         (Factory.__init__):
1818         (BuildAndRemoteJSCTestsFactory):
1819         (BuildAndRemoteJSCTestsFactory.__init__):
1820         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1821         * BuildSlaveSupport/clean-build:
1822         (main):
1823
1824 2016-03-21  Brent Fulgham  <bfulgham@apple.com>
1825
1826         Improve SharedBuffer testing
1827         https://bugs.webkit.org/show_bug.cgi?id=93078
1828         <rdar://problem/25277829>
1829
1830         Reviewed by Ryosuke Niwa.
1831
1832         Based on a Blink patch by Huang Dongsung <luxtella@company100.net>.
1833         <https://src.chromium.org/viewvc/blink?revision=153850&view=revision,
1834         and a Blink patch by <tyoshino@chromium.org>
1835         <https://src.chromium.org/viewvc/blink?view=rev&revision=151617>
1836
1837         Add three test cases from the Blink project that cover various append,
1838         copy, and createArrayBuffer calls.
1839
1840         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp:
1841         (TestWebKitAPI::TEST_F):
1842
1843 2016-03-21  Hyungwook Lee  <hyungwook.lee@navercorp.com>
1844
1845         [Win] Connect layoutTestController.findString() to support testing
1846         https://bugs.webkit.org/show_bug.cgi?id=50234
1847
1848         Reviewed by Alex Christensen.
1849
1850         Implement TestRunner::findString().
1851
1852         * DumpRenderTree/win/TestRunnerWin.cpp:
1853         (TestRunner::findString):
1854
1855 2016-03-20  Dan Bernstein  <mitz@apple.com>
1856
1857         [Mac] Determine TARGET_MAC_OS_X_VERSION_MAJOR from MACOSX_DEPLOYMENT_TARGET rather than from MAC_OS_X_VERSION_MAJOR
1858         https://bugs.webkit.org/show_bug.cgi?id=155707
1859         <rdar://problem/24980691>
1860
1861         Reviewed by Darin Adler.
1862
1863         * ContentExtensionTester/Configurations/Base.xcconfig: Set TARGET_MAC_OS_X_VERSION_MAJOR
1864           based on the last component of MACOSX_DEPLOYMENT_TARGET.
1865         * ContentExtensionTester/Configurations/DebugRelease.xcconfig: For engineering builds,
1866           preserve the behavior of TARGET_MAC_OS_X_VERSION_MAJOR being the host’s OS version.
1867
1868         Similarly for these projects:
1869
1870         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1871         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1872         * LayoutTestRelay/Configurations/Base.xcconfig:
1873         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
1874         * MiniBrowser/Configurations/Base.xcconfig:
1875         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1876         * TestWebKitAPI/Configurations/Base.xcconfig:
1877         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1878         * WebEditingTester/Configurations/Base.xcconfig:
1879         * WebEditingTester/Configurations/DebugRelease.xcconfig:
1880         * WebKitTestRunner/Configurations/Base.xcconfig:
1881         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1882
1883 2016-03-20  Dan Bernstein  <mitz@apple.com>
1884
1885         Update build settings
1886
1887         Rubber-stamped by Andy Estes.
1888
1889         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
1890         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1891         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
1892         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1893         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1894         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Synced up to the ones in ../Source.
1895         * WebEditingTester/Configurations/DebugRelease.xcconfig:
1896         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1897         * asan/asan.xcconfig:
1898
1899 2016-03-18  Sam Weinig  <sam@webkit.org>
1900
1901         Add test for HashMap::ensure that shows that moving into the lambda does not incure extra cost
1902         https://bugs.webkit.org/show_bug.cgi?id=155621
1903
1904         Reviewed by Alex Christensen.
1905
1906         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1907         (TestWebKitAPI::ObjectWithRefLogger::ObjectWithRefLogger):
1908         (TestWebKitAPI::testMovingUsingEnsure):
1909         (TestWebKitAPI::testMovingUsingAdd):
1910         Add tests ensuring that objects moved into a map using ensure don't
1911         have extra ref-churn.
1912
1913 2016-03-17  Tim Horton  <timothy_horton@apple.com>
1914
1915         Fix some deprecation warnings in WebEditingTester
1916         https://bugs.webkit.org/show_bug.cgi?id=155601
1917
1918         Reviewed by Simon Fraser.
1919
1920         * WebEditingTester/AppDelegate.m:
1921         (-[WebEditingAppDelegate showOperations:]):
1922         (-[WebEditingAppDelegate _updateNewWindowKeyEquivalents]):
1923
1924 2016-03-17  Tim Horton  <timothy_horton@apple.com>
1925
1926         Find-in-page indicator in Mail viewer is the wrong scale and cut off
1927         https://bugs.webkit.org/show_bug.cgi?id=155605
1928         <rdar://problem/23948165>
1929
1930         Reviewed by Simon Fraser.
1931
1932         * TestWebKitAPI/Tests/WebKit2Cocoa/FindInPage.mm:
1933         (TEST):
1934         Add a test that ensures that the find result image is correctly @2x.
1935         The NSImage size should be in points.
1936
1937 2016-03-16  Commit Queue  <commit-queue@webkit.org>
1938
1939         Unreviewed, rolling out r198187.
1940         https://bugs.webkit.org/show_bug.cgi?id=155564
1941
1942         Potentially break testing on iOS (Requested by Guest23 on
1943         #webkit).
1944
1945         Reverted changeset:
1946
1947         "Add twisted-15.5.0 module to
1948         webkitpy.thirdparty.autoinstalled."
1949         https://bugs.webkit.org/show_bug.cgi?id=154667
1950         http://trac.webkit.org/changeset/198187
1951
1952 2016-03-16  David Kilzer  <ddkilzer@apple.com>
1953
1954         check-webkit-style: should warn about blank lines after #include "config.h" in TestWebKitAPI
1955         <http://webkit.org/b/155445>
1956
1957         Reviewed by Darin Adler.
1958
1959         * Scripts/webkitpy/style/checker.py:
1960         (_PATH_RULES_SPECIFIER): Do not ignore "build/include*" checks
1961         on TestWebKitAPI since this project uses a config.h header as of
1962         r95188.  Also remove references to WebKitAPITest, which ceased
1963         to exist in r95944.
1964
1965         * Scripts/webkitpy/style/checker_unittest.py:
1966         (GlobalVariablesTest.test_path_rules_specifier): Add tests.
1967         Remove reference to WebKitAPITest project.
1968
1969 2016-03-16  Tim Horton  <timothy_horton@apple.com>
1970
1971         [mac] Printing test snapshots are upside-down after r198242
1972         https://bugs.webkit.org/show_bug.cgi?id=155543
1973
1974         Reviewed by Simon Fraser.
1975
1976         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1977         (createPagedBitmapContext):
1978         Flip printing snapshots in DRT so that everything is right-side-up.
1979
1980 2016-03-16  Alexey Proskuryakov  <ap@apple.com>
1981
1982         Update unit test for iOS debug queues.
1983
1984         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1985
1986 2016-03-16  Jiewen Tan  <jiewen_tan@apple.com>
1987
1988         URL Parsing should signal failure for illegal IDN
1989         https://bugs.webkit.org/show_bug.cgi?id=154945
1990         <rdar://problem/8014795>
1991
1992         Reviewed by Brent Fulgham.
1993
1994         * MiniBrowser/mac/WK2BrowserWindowController.m:
1995         (-[WK2BrowserWindowController fetch:]):
1996         * TestWebKitAPI/Tests/Cocoa/URLExtras.mm:
1997         (TestWebKitAPI::TEST):
1998
1999 2016-03-15  Tim Horton  <timothy_horton@apple.com>
2000
2001         [iOS Simulator] Test result snapshots are upside down
2002         https://bugs.webkit.org/show_bug.cgi?id=154761
2003
2004         Reviewed by Simon Fraser.
2005
2006         * WebKitTestRunner/cg/TestInvocationCG.cpp:
2007         (WTR::createCGContextFromImage):
2008         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2009         In r97104, Simon added code to take WindowServer snapshots, which came
2010         in flipped, and added code to flip them back. At this point, WindowServer
2011         snapshots got flipped, and software snapshots did not.
2012
2013         In r140067, Simon noticed that WindowServer ref test images were upside-down
2014         on Mac (not sure why this changed), so turned off the flipping code (but
2015         didn't delete it!). Now, WindowServer snapshots and software snapshots both
2016         are not flipped.
2017
2018         In r190304, Carlos added an enum for the source of the snapshot ("WebView"
2019         for window server snapshots, and "WebContent" for software snapshots),
2020         and - critically - changed the flipping logic to flip software snapshots!
2021
2022         We didn't notice this on Mac because at this point we've made it so that
2023         we *always* have WindowServer snapshots, but on iOS we still don't have
2024         WindowServer snapshots, so now they're flipped.
2025
2026         And that's how we got here.
2027
2028         To restore the behavior from r140067, and correctly unflip snapshots on
2029         iOS, just delete this code.
2030
2031 2016-03-15  Alexey Proskuryakov  <ap@apple.com>
2032
2033         run-api-tests doesn't print test name when the test crashes
2034         https://bugs.webkit.org/show_bug.cgi?id=155476
2035
2036         Reviewed by Daniel Bates.
2037
2038         * Scripts/run-api-tests: Print "UNEXPECTEDLY EXITED" with a test name when output
2039         doesn't contain the test name yet. Changed test name output to always be before raw
2040         stdout for clarity.
2041
2042 2016-03-15  Chris Dumez  <cdumez@apple.com>
2043
2044         Unreviewed, rolling out r198203.
2045
2046         Favorites view is no longer loading on iOS
2047
2048         Reverted changeset:
2049
2050         "URL Parsing should signal failure for illegal IDN"
2051         https://bugs.webkit.org/show_bug.cgi?id=154945
2052         http://trac.webkit.org/changeset/198203
2053
2054 2016-03-15  Jiewen Tan  <jiewen_tan@apple.com>
2055
2056         URL Parsing should signal failure for illegal IDN
2057         https://bugs.webkit.org/show_bug.cgi?id=154945
2058         <rdar://problem/8014795>
2059
2060         Reviewed by Brent Fulgham.
2061
2062         * MiniBrowser/mac/WK2BrowserWindowController.m:
2063         (-[WK2BrowserWindowController fetch:]):
2064         * TestWebKitAPI/Tests/Cocoa/URLExtras.mm:
2065         (TestWebKitAPI::TEST):
2066
2067 2016-03-14  Chris Dumez  <cdumez@apple.com>
2068
2069         Unreviewed, rolling out r197981.
2070
2071         Caused a massive PLT regression on Mac.
2072
2073         Reverted changeset:
2074
2075         "Font antialiasing (smoothing) changes when elements are
2076         rendered into compositing layers"
2077         https://bugs.webkit.org/show_bug.cgi?id=23364
2078         http://trac.webkit.org/changeset/197981
2079
2080 2016-03-14  Dewei Zhu  <dewei_zhu@apple.com>
2081
2082         Add twisted-15.5.0 module to webkitpy.thirdparty.autoinstalled.
2083         https://bugs.webkit.org/show_bug.cgi?id=154667
2084
2085         Reviewed by Ryosuke Niwa and Simon Fraser.
2086
2087         Add twisted-15.5.0 to webkitpy.thirdparty.autoinstalled.
2088         Minor fix for twsited_http_server used by run-benchmark that we should only stop http server while recieving 'GET /shutdown'.
2089
2090         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
2091         (ServerControl.render_POST): Deleted.
2092         * Scripts/webkitpy/thirdparty/__init__.py:
2093         (AutoinstallImportHook.find_module):
2094         (AutoinstallImportHook._install_twisted_15_5_0):
2095         * Scripts/webkitpy/thirdparty/__init___unittest.py:
2096         (ThirdpartyTest.test_imports):
2097
2098 2016-03-14  Mark Lam  <mark.lam@apple.com>
2099
2100         Need to distinguish between Symbol() and Symbol("").
2101         https://bugs.webkit.org/show_bug.cgi?id=155438
2102
2103         Reviewed by Saam Barati.
2104
2105         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2106         (TestWebKitAPI::TEST):
2107         - Test that the a symbol with an empty string is not equivalent to a null symbol. 
2108
2109 2016-03-14  David Kilzer  <ddkilzer@apple.com>
2110
2111         Remove blank lines after #include "config.h"
2112
2113         Follow-up fix from review comments on Bug 155394.
2114
2115         * TestWebKitAPI/PlatformUtilities.cpp:
2116         * TestWebKitAPI/Tests/WTF/RefLogger.cpp:
2117
2118 2016-03-14  Frederic Wang  <fred.wang@free.fr>
2119
2120         Unreviewed: Add my professional email address.
2121
2122         * Scripts/webkitpy/common/config/contributors.json:
2123
2124 2016-03-14  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2125
2126         Web platform test server should not try to launch servers on already bound sockets
2127         https://bugs.webkit.org/show_bug.cgi?id=141157
2128
2129         Reviewed by Darin Adler.
2130
2131         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2132         (wpt_config_json): Load WPT config from LayoutTests/imported/w3c/resources/config.json.
2133         (base_url): Refactored to use wpt_config_json routine.
2134         (WebPlatformTestServer.__init__): Fill port mappings according WPT config.
2135
2136 2016-03-13  Joseph Pecoraro  <pecoraro@apple.com>
2137
2138         Remove ENABLE(ES6_TEMPLATE_LITERAL_SYNTAX) guards
2139         https://bugs.webkit.org/show_bug.cgi?id=155417
2140
2141         Reviewed by Yusuke Suzuki.
2142
2143         * Scripts/webkitperl/FeatureList.pm:
2144         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2145
2146 2016-03-13  Dean Jackson  <dino@apple.com>
2147
2148         DRT should enable WebGL by default on Mac
2149         https://bugs.webkit.org/show_bug.cgi?id=155419
2150         <rdar://problem/25136981>
2151
2152         Reviewed by Sam Weinig.
2153
2154         For some reason, lost in time, WebGL was enabled
2155         by default on trunk, but disabled by default
2156         in DumpRenderTree when using WebKit 1. This
2157         was very annoying, because each test had
2158         an explicit command to enable it.
2159
2160         * DumpRenderTree/mac/DumpRenderTree.mm:
2161         (resetWebPreferencesToConsistentValues): Deleted WebGL line.
2162
2163 2016-03-13  Konstantin Tokarev  <annulen@yandex.ru>
2164
2165         Added new port JSCOnly.
2166         https://bugs.webkit.org/show_bug.cgi?id=154512
2167
2168         Reviewed by Michael Catanzaro.
2169
2170         This port allows to build JavaScriptCore engine with minimal
2171         dependencies.
2172
2173         * Scripts/build-jsc:
2174         * Scripts/webkitdirs.pm:
2175         (argumentsForConfiguration):
2176         (executableProductDir):
2177         (determinePortName):
2178         (isJSCOnly):
2179         (wrapperPrefixIfNeeded):
2180         (generateBuildSystemFromCMakeProject):
2181         (buildCMakeGeneratedProject):
2182
2183 2016-03-13  David Kilzer  <ddkilzer@apple.com>
2184
2185         TestWebKitAPI: fix linker warnings
2186         <http://webkit.org/b/155394>
2187
2188         Reviewed by Darin Adler.
2189
2190         * TestWebKitAPI/CMakeLists.txt:
2191         - Add RefLogger.cpp source file.
2192         - Add other missing cross-platform source files.
2193         - Add FIXMEs about RunLoop.cpp and about missing
2194           platform-specific source files.
2195         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2196         - Add RefLogger.cpp source file.
2197
2198         * TestWebKitAPI/Counters.cpp:
2199         (DeleterCounter<ConstructorDestructorCounter>::deleterCount):
2200         Move specific declaration here to fix linker warning.
2201         * TestWebKitAPI/Counters.h:
2202         (DeleterCounter<T>::deleterCount): Remove declaration of global
2203         template variable.
2204
2205         * TestWebKitAPI/Tests/WTF/RefLogger.cpp: Added.
2206         (TestWebKitAPI::log): Added.  Move inline definition in
2207         RefLogger.h to here to fix linker warning.
2208
2209         * TestWebKitAPI/Tests/WTF/RefLogger.h:
2210         (TestWebKitAPI::log): Replace inline function with declaration.
2211
2212 2016-03-12  David Kilzer  <ddkilzer@apple.com>
2213
2214         REGRESSION (r178615): Fix incorrect case in included header for WeakPtr.cpp
2215
2216         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp: Change "test.h" to
2217         "Test.h" to fix incorrect case.  This was discovered when adding
2218         WeakPtr.cpp to CMakeLists.txt for the patch on Bug 155394.
2219
2220 2016-03-12  David Kilzer  <ddkilzer@apple.com>
2221
2222         run-webkit-tests: handle Darwin framework/library environment variables more consistently
2223         <http://webkit.org/b/155392>
2224
2225         Reviewed by Daniel Bates.
2226
2227         These changes will make it possible to pass through environment
2228         variables from the run-webkit-tests command-line.
2229
2230         * Scripts/webkitpy/port/base.py:
2231         (Port.to.setup_environ_for_server): Add DYLD_FRAMEWORK_PATH,
2232         __XPC_DYLD_FRAMEWORK_PATH and __XPC_DYLD_LIBRARY_PATH to the
2233         list of variables to keep from the run-webkit-test environment.
2234
2235         * Scripts/webkitpy/port/driver.py:
2236         (Driver._append_environment_variable_path): Add method to append
2237         a path to an environment variable, or set the path if the
2238         variable doesn't exist.
2239         (Driver._setup_environ_for_driver): Extract build_root_path into
2240         a local variable.  Use Driver._append_environment_variable_path
2241         to extend DYLD_LIBRARY_PATH, __XPC_DYLD_LIBRARY_PATH,
2242         DYLD_FRAMEWORK_PATH and __XPC_DYLD_FRAMEWORK_PATH instead of
2243         overwriting them.
2244
2245         * Scripts/webkitpy/port/driver_unittest.py:
2246         (DriverTest.test__append_environment_variable_path): Add test
2247         method to test Driver._append_environment_variable_path.
2248
2249 2016-03-11  Alexey Proskuryakov  <ap@apple.com>
2250
2251         [ios-sim debug] API test WTF_Lock.ContendedShortSection and WTF_ParkingLot.UnparkOneFifty timing out
2252         https://bugs.webkit.org/show_bug.cgi?id=155276
2253
2254         [ios-sim] API test WTF_Condition.TenProducersTenConsumersOneSlot timing out
2255         https://bugs.webkit.org/show_bug.cgi?id=155345
2256
2257         [iOS Simulator] API test timeout: WTF_ParkingLot.UnparkOneFiftyThenFiftyAll
2258         https://bugs.webkit.org/show_bug.cgi?id=153997
2259         <rdar://problem/23580034>
2260
2261         <rdar://problem/23580018> TestWebKitAPI Timeout: WTF_ParkingLot.UnparkOneFifty
2262
2263         Rubber-stamped by Filip Pizlo.
2264
2265         * Scripts/run-api-tests: These tests are pretty slow. Increase API test timeout.
2266
2267         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp: Start running WTF_ParkingLot.UnparkOneFiftyThenFiftyAll
2268         on iOS again.
2269
2270 2016-03-11  Jer Noble  <jer.noble@apple.com>
2271
2272         [ios-sim debug] API tests RequiresUserActionForPlaybackTest.DoesNotRequireUserActionForMediaPlayback and RequiresUserActionForAudioButNotVideoPlayback asserting
2273         https://bugs.webkit.org/show_bug.cgi?id=155365
2274
2275         Reviewed by Darin Adler.
2276
2277         Allow tests running on iOS simulator to play video inline, avoiding this assert.
2278
2279         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
2280         (RequiresUserActionForPlaybackTest::SetUp):
2281
2282 2016-03-11  Frederic Wang  <fwang@igalia.com>
2283
2284         [jhbuild] Disable LLVM OCaml bindings.
2285         https://bugs.webkit.org/show_bug.cgi?id=153274
2286
2287         Reviewed by Michael Catanzaro.
2288
2289         * gtk/jhbuild.modules: disable all (actually only OCaml) bindings for LLVM.
2290
2291 2016-03-11  Commit Queue  <commit-queue@webkit.org>
2292
2293         Unreviewed, rolling out r197495.
2294         https://bugs.webkit.org/show_bug.cgi?id=155369
2295
2296         LLVM is needed to run update-webkitgtk-libs reliably
2297         (Requested by mcatanzaro on #webkit).
2298
2299         Reverted changeset:
2300
2301         "[jhbuild] Remove LLVM dependency."
2302         https://bugs.webkit.org/show_bug.cgi?id=153274
2303         http://trac.webkit.org/changeset/197495
2304
2305 2016-03-11  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2306
2307         WTF should have a similar function as equalLettersIgnoringASCIICase to match beginning of strings
2308         https://bugs.webkit.org/show_bug.cgi?id=153419
2309
2310         Reviewed by Darin Adler.
2311
2312         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
2313         (TestWebKitAPI::TEST): Adding test case for startsWithLettersIgnoringASCIICase.
2314
2315
2316 2016-03-10  Simon Fraser  <simon.fraser@apple.com>
2317
2318         Font antialiasing (smoothing) changes when elements are rendered into compositing layers
2319         https://bugs.webkit.org/show_bug.cgi?id=23364
2320
2321         Reviewed by Tim Horton.
2322
2323         Turn off smoothed layer text because it affects many layout test results.
2324
2325         * DumpRenderTree/mac/DumpRenderTree.mm:
2326         (resetWebViewToConsistentStateBeforeTesting):
2327         * WebKitTestRunner/TestController.cpp:
2328         (WTR::TestController::resetStateToConsistentValues):
2329
2330 2016-03-10  Jer Noble  <jer.noble@apple.com>
2331
2332         Partial roll-out of r197953; test fails because encode/decode support of those properties were never added.
2333
2334         * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:
2335         (TEST): Deleted.
2336
2337 2016-03-10  Myles C. Maxfield  <mmaxfield@apple.com>
2338
2339         [OS X] Main frame scrollbars should appear on the left on RTL systems
2340         https://bugs.webkit.org/show_bug.cgi?id=155149
2341
2342         Reviewed by Simon Fraser.
2343
2344         Setting the volatile default needs to be done early, so it is
2345         plumbed through the injected bundle's initialization routine.
2346
2347         Control of RTL scrollbars is handled by putting the string
2348         <!-- webkit-test-runner [ rtlScrollbars=true ] -->
2349         on the first line of a test.
2350
2351         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2352         (WTR::shouldUseRTLScrollbars):
2353         (WTR::InjectedBundle::platformInitialize):
2354         * WebKitTestRunner/TestController.cpp:
2355         (WTR::TestController::generatePageConfiguration):
2356         (WTR::updateTestOptionsFromTestHeader):
2357         (WTR::TestController::getInjectedBundleInitializationUserData):
2358         * WebKitTestRunner/TestController.h:
2359         * WebKitTestRunner/TestOptions.h:
2360         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2361         (WTR::PlatformWebView::viewSupportsOptions):
2362
2363 2016-03-08  Jer Noble  <jer.noble@apple.com>
2364
2365         Add separate WK and WK2 preferences for requiring user gestures for video media, distinct from user gestures for media generally
2366         https://bugs.webkit.org/show_bug.cgi?id=155141
2367
2368         Reviewed by Beth Dakin.
2369
2370         Set the default values for media preferences unconditionally, not just on PLATFORM(IOS). Set "video requires user gesture"
2371         to sane defaults in addition to "audio requires user gesture" and (in the case of DumpREnderTree) instead of "media requires user gesture".
2372
2373         Add a new test of WK2 user gesture requirement preferences.
2374
2375         * DumpRenderTree/mac/DumpRenderTree.mm:
2376         (resetWebPreferencesToConsistentValues):
2377         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2378         * TestWebKitAPI/Tests/WebKit/ios/video-with-audio.html:
2379         * TestWebKitAPI/Tests/WebKit/ios/video-without-audio.html:
2380         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm: Added.
2381         (-[RequiresUserActionForPlaybackNavigationDelegate webView:didFinishNavigation:]):
2382         (-[RequiresUserActionForPlaybackMessageHandler userContentController:didReceiveScriptMessage:]):
2383         (RequiresUserActionForPlaybackTest::SetUp):
2384         (RequiresUserActionForPlaybackTest::createWebView):
2385         (RequiresUserActionForPlaybackTest::testVideoWithAudio):
2386         (RequiresUserActionForPlaybackTest::testVideoWithoutAudio):
2387         (RequiresUserActionForPlaybackTest::testAudioOnly):
2388         (TEST_F):
2389         * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:
2390         (TEST):
2391
2392 2016-03-10  Brian Burg  <bburg@apple.com>
2393
2394         Web Inspector: should be able to run protocol and input generator scripts from any directory
2395         https://bugs.webkit.org/show_bug.cgi?id=155307
2396
2397         Reviewed by Joseph Pecoraro.
2398
2399         * Scripts/webkitpy/inspector/main.py:
2400         (InspectorGeneratorTests.main):
2401         * Scripts/webkitpy/replay/main.py:
2402         (InputGeneratorTests.main):
2403         Compute the current SCM based on the location of the script being executed, not
2404         the $CWD which could be anything. There's rarely a good reason to use $CWD.
2405
2406 2016-03-10  David Kilzer  <ddkilzer@apple.com>
2407
2408         [iOS] DumpRenderTree crashes when accessing window.testRunner.inspectorTestStubURL
2409         <http://webkit.org/b/155295>
2410
2411         Reviewed by Brent Fulgham.
2412
2413         * DumpRenderTree/mac/TestRunnerMac.mm:
2414         (TestRunner::inspectorTestStubURL): Always return nullptr for
2415         PLATFORM(IOS).  This matches what we did in r192604 for
2416         WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm.
2417
2418 2016-03-10  Frederic Wang  <fwang@igalia.com>
2419
2420         [GTK] Add support for WOFF2
2421         https://bugs.webkit.org/show_bug.cgi?id=152616
2422
2423         Reviewed by Carlos Garcia Campos.
2424
2425         * Scripts/webkitpy/style/checker.py: Only verify basic style for third party modules brotli and woff2.
2426
2427 2016-03-09  Ryosuke Niwa  <rniwa@webkit.org>
2428
2429         Add runtime flags for shadow DOM and custom elements
2430         https://bugs.webkit.org/show_bug.cgi?id=155213
2431
2432         Reviewed by Dean Jackson.
2433
2434         Always enable shadow DOM and custom elements during testing.
2435
2436         * DumpRenderTree/mac/DumpRenderTree.mm:
2437         (resetWebPreferencesToConsistentValues):
2438         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2439         (WTR::InjectedBundle::beginTesting):
2440         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2441         (WTR::TestRunner::setShadowDOMEnabled): Added.
2442         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2443
2444 2016-03-09  Brent Fulgham  <bfulgham@apple.com>
2445
2446         Handling 'allowUniversalAccessFromFileURLs' on WKWebViewConfiguration causes test breakage
2447         https://bugs.webkit.org/show_bug.cgi?id=155265
2448         <rdar://problem/11101440>
2449
2450         Reviewed by Andy Estes.
2451
2452         WK2 localStorage tests need the 'AllowUniversalAccessFromFileURLs' preference set by default.
2453         Tests that confirm blocking localStorage manually set the flag to "False" in the test.
2454
2455         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2456         (WTR::initializeWebViewConfiguration): Set the default state to the correct value.
2457
2458 2016-03-09  David Kilzer  <ddkilzer@apple.com>
2459
2460         check-webkit-style: fix false-positive warnings about @try/@catch blocks in Objective-C++ source files
2461         <http://webkit.org/b/155273>
2462
2463         Reviewed by Andy Estes.
2464
2465         * Scripts/webkitpy/style/checkers/cpp.py:
2466         (check_spacing_for_function_call): Ignore @catch lines.
2467         (check_braces): Ditto.
2468         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2469         (CppStyleTest.test_brace_at_begin_of_line): Add test case.
2470
2471 2016-03-09  Jason Marcell  <jmarcell@apple.com>
2472
2473         Removing reference to Dashboard.Repository.Internal.trac from open source unit tests.
2474         https://bugs.webkit.org/show_bug.cgi?id=155274
2475
2476         Reviewed by Alexey Proskuryakov.
2477
2478         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js:
2479         (setup): Deleted. In bug 154180 we removed Dashboard.Repository.Internal which was causing an
2480         error in the unit tests.
2481
2482 2016-03-09  Aakash Jain  <aakash_jain@apple.com>
2483
2484         use ulimit command to check process limit in webkitpy
2485         https://bugs.webkit.org/show_bug.cgi?id=155260
2486
2487         Reviewed by Alexey Proskuryakov.
2488
2489         * Scripts/webkitpy/port/ios.py:
2490         (IOSSimulatorPort.default_child_processes): Use ulimit command output instead of 
2491         launchctl limit maxproc command.
2492
2493 2016-03-09  Alexey Proskuryakov  <ap@apple.com>
2494
2495         Stop building armv7 on iOS device builders
2496         https://bugs.webkit.org/show_bug.cgi?id=155246
2497
2498         Reviewed by David Kilzer.
2499
2500         * BuildSlaveSupport/build.webkit.org-config/config.json: Building both armv7 and
2501         armv7s makes the bots unnecessarily slow. We can catch super rare v7-only regressions
2502         elsewhere.
2503
2504         * Scripts/webkitpy/common/config/ews.json: Changed EWS to match, as we always want
2505         EWS configuration to be verified by buildbot queues.
2506
2507         * Scripts/webkitdirs.pm:
2508         * Scripts/webkitpy/port/ios.py:
2509         Changed default to arm64. I think that the default is probably not used in any
2510         practical scenarios, but it's nice to make it more sensible.
2511
2512 2016-03-09  Alexey Proskuryakov  <ap@apple.com>
2513
2514         Add iOS Simulator EWS to bot watcher's dashboard
2515         https://bugs.webkit.org/show_bug.cgi?id=155220
2516
2517         Reviewed by Lucas Forschler.
2518
2519         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2520
2521 2016-03-09  Brent Fulgham  <bfulgham@apple.com>
2522
2523         Local HTML should be blocked from localStorage access unless "Disable Local File Restrictions" is checked
2524         https://bugs.webkit.org/show_bug.cgi?id=155185
2525         <rdar://problem/11101440>
2526
2527         Reviewed by Anders Carlsson.
2528
2529         * TestWebKitAPI/Tests/WebKit2/CloseFromWithinCreatePage.cpp:
2530         (TestWebKitAPI::TEST): Allow local file accesss to run test.
2531         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
2532         (TEST): Ditto.
2533         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
2534         (TEST): Ditto.
2535
2536 2016-03-09  Tim Horton  <timothy_horton@apple.com>
2537
2538         Removing and re-adding a script message handler with the same name results in an unusable message handler
2539         https://bugs.webkit.org/show_bug.cgi?id=155223
2540
2541         Reviewed by Sam Weinig.
2542
2543         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
2544         (TEST):
2545         Add a test ensuring that it is possible to remove and re-add a script message handler
2546         with the same name and still dispatch messages to it.
2547
2548 2016-03-08  Alexey Proskuryakov  <ap@apple.com>
2549
2550         Fix iOS Simulator EWS.
2551
2552         Unreviewed build fix.
2553
2554         * Scripts/webkitpy/common/config/ports.py:
2555
2556 2016-03-08  Aakash Jain  <aakash_jain@apple.com>
2557
2558         Booting multiple iOS simulator parallely fails sometimes
2559         https://bugs.webkit.org/show_bug.cgi?id=155208
2560         <rdar://problem/25019651>
2561
2562         Reviewed by Darin Adler.
2563
2564         * Scripts/webkitpy/port/ios.py:
2565         (IOSSimulatorPort.setup_test_run): Increase the time delay between subsequent
2566         simulator boot.
2567
2568 2016-03-08  Alexey Proskuryakov  <ap@apple.com>
2569
2570         Add iOS debug testers to flakiness dashboard
2571         https://bugs.webkit.org/show_bug.cgi?id=155206
2572
2573         Reviewed by Darin Adler.
2574
2575         * TestResultServer/static-dashboards/builders.jsonp:
2576
2577 2016-03-08  Oliver Hunt  <oliver@apple.com>
2578
2579         Start moving to separated writable and executable mappings in the JIT
2580         https://bugs.webkit.org/show_bug.cgi?id=155178
2581
2582         Reviewed by Fil Pizlo.
2583
2584         Making run-jsc-benchmarks slightly happier on my machine.
2585
2586         * Scripts/run-jsc-benchmarks:
2587
2588 2016-03-08  Anders Carlsson  <andersca@apple.com>
2589
2590         Use NSUInteger instead of NSWindowStyleMask.
2591
2592         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
2593
2594 2016-03-08  Anders Carlsson  <andersca@apple.com>
2595
2596         Fix build.
2597
2598         We intentionally don't use AppKitCompatibilityDeclarations.h here, since we want
2599         MiniBrowser to build without WTF.
2600
2601         * MiniBrowser/mac/AppDelegate.m:
2602         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
2603         * MiniBrowser/mac/BrowserWindowController.m:
2604         (-[BrowserWindowController windowDidLoad]):
2605         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
2606
2607 2016-03-08  Alexey Proskuryakov  <ap@apple.com>
2608
2609         Add iOS simulator EWS that runs tests
2610         https://bugs.webkit.org/show_bug.cgi?id=155175
2611
2612         Reviewed by Lucas Forschler.
2613
2614         * QueueStatusServer/config/queues.py:
2615         * Scripts/webkitpy/common/config/ews.json:
2616         * Scripts/webkitpy/common/config/ports.py:
2617
2618 2016-03-08  Commit Queue  <commit-queue@webkit.org>
2619
2620         Unreviewed, rolling out r197793 and r197799.
2621         https://bugs.webkit.org/show_bug.cgi?id=155195
2622
2623         something weird happened while landing this and everything
2624         broke (Requested by olliej on #webkit).
2625
2626         Reverted changesets:
2627
2628         "Start moving to separated writable and executable mappings in
2629         the JIT"
2630         https://bugs.webkit.org/show_bug.cgi?id=155178
2631         http://trac.webkit.org/changeset/197793
2632
2633         "arm64 build fix after r197793."
2634         http://trac.webkit.org/changeset/197799
2635
2636 2016-03-08  Oliver Hunt  <oliver@apple.com>
2637
2638         Start moving to separated writable and executable mappings in the JIT
2639         https://bugs.webkit.org/show_bug.cgi?id=155178
2640
2641         Reviewed by Filip Pizlo.
2642
2643         Making run-jsc-benchmarks slightly happier on my machine.
2644
2645         * Scripts/run-jsc-benchmarks:
2646
2647 2016-03-08  Daniel Bates  <dabates@apple.com>
2648
2649         Support iterating over an OptionSet and checking if it is empty
2650         https://bugs.webkit.org/show_bug.cgi?id=154941
2651         <rdar://problem/24964187>
2652
2653         Reviewed by Darin Adler.
2654
2655         Add tests to ensure that we do not regression both iteration of an OptionSet and
2656         determining whether an OptionSet is empty.
2657
2658         * TestWebKitAPI/Test.h:
2659         (TestWebKitAPI::Util::assertStrongEnum): Helper function to assert two strong enum type for equality.
2660         * TestWebKitAPI/Tests/WTF/OptionSet.cpp:
2661         (TestWebKitAPI::TEST):
2662
2663 2016-03-08  Alexey Proskuryakov  <ap@apple.com>
2664
2665         Add debug iOS Simulator bots to the dashboard
2666         https://bugs.webkit.org/show_bug.cgi?id=155157
2667
2668         Reviewed by Darin Adler.
2669
2670         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2671
2672 2016-03-08  Alejandro G. Castro  <alex@igalia.com>
2673
2674         Unreviewed EFL build fix after r197752.
2675
2676         * Scripts/webkitperl/FeatureList.pm: Avoid MEDIA_STREAM
2677         compilation by default until EFL bumps gstreamer to 1.6.
2678
2679 2016-03-08  Alejandro G. Castro  <alex@igalia.com>
2680
2681         [GTK] [EFL] Avoid running mediastream tests by default until we compile by default
2682         https://bugs.webkit.org/show_bug.cgi?id=153540
2683
2684         Reviewed by Philippe Normand.
2685
2686         After bumping gstreamer to 1.6.3 in r196804 we can enable again
2687         compilation of mediastream and running the tests.
2688
2689         * Scripts/run-gtk-tests:
2690         (TestRunner): Enable again the UserMedia API test.
2691         * Scripts/webkitperl/FeatureList.pm: Enable the compilation of the
2692         mediastream by default.
2693         * gtk/jhbuild-webrtc.modules: Removed the specific jhbuild modules
2694         file.
2695         * gtk/jhbuild.modules: Bumped the openwebrtc version to the one we
2696         are currently using.
2697
2698 2016-03-07  Jon Lee  <jonlee@apple.com>
2699
2700         Update perf bot configuration for Animometer
2701         https://bugs.webkit.org/show_bug.cgi?id=155134
2702
2703         Reviewed by Ryosuke Niwa.
2704
2705         * Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch: Refactor the patch
2706         to work with the latest version of the harness.
2707         * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Bump up the timeout,
2708         and use the latest version of the harness.
2709
2710 2016-03-07  Joanmarie Diggs  <jdiggs@igalia.com>
2711
2712         [GTK][jhbuild] OpenWebRTC build fails with GCC 6.0
2713         https://bugs.webkit.org/show_bug.cgi?id=154839
2714
2715         Reviewed by Michael Catanzaro.
2716
2717         Add '-Wno-error' to jhbuildrc; remove it from the module sets for macos.
2718
2719         * gtk/jhbuild-webrtc.modules:
2720         * gtk/jhbuild.modules:
2721         * gtk/jhbuildrc:
2722
2723 2016-03-07  Aakash Jain  <aakash_jain@apple.com>
2724
2725         webkitpy should verify timestamp from CrashLogs while collecting all crash logs
2726         https://bugs.webkit.org/show_bug.cgi?id=155000
2727         <rdar://problem/24860219>
2728
2729         Reviewed by Alexey Proskuryakov.
2730
2731         * Scripts/webkitpy/common/system/crashlogs.py:
2732         (CrashLogs._find_all_logs_darwin): Make sure that crash log timestamp is within expected 
2733         time range, because file modification time is not always accurate.
2734         (CrashLogs.get_timestamp_from_logs): Parse the timestamp from logs.
2735         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
2736         (CrashLogsTest.test_get_timestamp_from_logs_darwin): Testcase for above function.
2737
2738 2016-03-06  Alexey Proskuryakov  <ap@apple.com>
2739
2740         build-webkit prints an error on iOS simulator bots
2741         https://bugs.webkit.org/show_bug.cgi?id=155078
2742
2743         Reviewed by Dan Bernstein.
2744
2745         This happens when build-layouttestrelay sets $xcodeSDK to undefined, to use host SDK.
2746
2747         * Scripts/webkitdirs.pm: (buildXCodeProject): There is no need to pass -sdk, because
2748         XcodeOptions() already passes SDKROOT as appropriate.
2749
2750         * Scripts/build-layouttestrelay: Added a FIXME. Resetting $xcodeSDK doesn't reset
2751         any other configuration variables that were derived from its initial value, like $portName.
2752
2753 2016-03-05  Tim Horton  <timothy_horton@apple.com>
2754
2755         Create a DOMHTMLVideoElement when wrapping <video> elements
2756         https://bugs.webkit.org/show_bug.cgi?id=155084
2757         <rdar://problem/24997193>
2758
2759         Reviewed by Dan Bernstein.
2760
2761         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2762         * TestWebKitAPI/Tests/mac/DOMHTMLVideoElementWrapper.mm: Added.
2763         (-[VideoWrapperFrameLoadDelegate webView:didFinishLoadForFrame:]):
2764         (TestWebKitAPI::TEST):
2765         Add an API test for this behavior.
2766
2767 2016-03-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2768
2769         [GTK] Fix logging details after r197505 (Run the run-benchmark script on the performance bot.)
2770         https://bugs.webkit.org/show_bug.cgi?id=154595
2771
2772         Unreviewed.
2773
2774         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
2775         (start): Use logging.exception when a test fails in order to get the details about the error.
2776
2777 2016-03-04  Alexey Proskuryakov  <ap@apple.com>
2778
2779         Add iOS simulator debug bots
2780         https://bugs.webkit.org/show_bug.cgi?id=155053
2781
2782         Reviewed by Lucas Forschler.
2783
2784         * BuildSlaveSupport/build.webkit.org-config/config.json:
2785
2786 2016-03-04  Brent Fulgham  <bfulgham@apple.com>
2787
2788         [WK2] Gather resource load statistics
2789         https://bugs.webkit.org/show_bug.cgi?id=154278
2790         <rdar://problem/24702892>
2791
2792         Reviewed by Andy Estes.
2793
2794         * MiniBrowser/mac/AppDelegate.m:
2795         (defaultConfiguration): Retrieve state of the ResourceLoadStatisticsEnabled setting.
2796         * MiniBrowser/mac/SettingsController.m:
2797         (-[SettingsController _populateMenu]): Move setting from WK1-only to be
2798         universally applicable.
2799         * MiniBrowser/mac/WK2BrowserWindowController.m:
2800         (-[WK2BrowserWindowController didChangeSettings]): Recognize when the
2801         Resource Load Statistics flag has changed.
2802
2803 2016-03-04  Alex Christensen  <achristensen@webkit.org>
2804
2805         Remove vcxproj build system
2806         https://bugs.webkit.org/show_bug.cgi?id=154388
2807
2808         Rubber-stamped by Brent Fulgham.
2809
2810         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree: Removed.
2811         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree.sln: Removed.
2812         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj: Removed.
2813         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj.filters: Removed.
2814         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeApple.props: Removed.
2815         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props: Removed.
2816         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebug.props: Removed.
2817         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props: Removed.
2818         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Removed.
2819         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherCommon.props: Removed.
2820         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherDebug.props: Removed.
2821         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherProduction.props: Removed.
2822         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherRelease.props: Removed.
2823         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd: Removed.
2824         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePreBuild.cmd: Removed.
2825         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeProduction.props: Removed.
2826         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeRelease.props: Removed.
2827         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props: Removed.
2828         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff: Removed.
2829         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj: Removed.
2830         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommon.props: Removed.
2831         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommonWinCairo.props: Removed.
2832         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebug.props: Removed.
2833         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props: Removed.
2834         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj: Removed.
2835         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherCommon.props: Removed.
2836         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherDebug.props: Removed.
2837         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherProduction.props: Removed.
2838         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherRelease.props: Removed.
2839         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffPostBuild.cmd: Removed.
2840         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffPreBuild.cmd: Removed.
2841         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffProduction.props: Removed.
2842         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffRelease.props: Removed.
2843         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props: Removed.
2844         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj: Removed.
2845         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters: Removed.
2846         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginCommon.props: Removed.
2847         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginDebug.props: Removed.
2848         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginPostBuild.cmd: Removed.
2849         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginPreBuild.cmd: Removed.
2850         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginProduction.props: Removed.
2851         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginRelease.props: Removed.
2852         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.vcxproj: Removed.
2853         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.vcxproj.filters: Removed.
2854         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCF.props: Removed.
2855         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCFLite.props: Removed.
2856         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCommon.props: Removed.
2857         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserDebug.props: Removed.
2858         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj: Removed.
2859         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj.filters: Removed.
2860         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibCommon.props: Removed.
2861         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibDebug.props: Removed.
2862         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibPostBuild.cmd: Removed.
2863         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibPreBuild.cmd: Removed.
2864         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibProduction.props: Removed.
2865         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibRelease.props: Removed.
2866         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserPostBuild.cmd: Removed.
2867         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserPreBuild.cmd: Removed.
2868         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserProduction.props: Removed.
2869         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserRelease.props: Removed.
2870         * TestWebKitAPI/TestWebKitAPI.vcxproj: Removed.
2871         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.sln: Removed.
2872         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Removed.
2873         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters: Removed.
2874         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props: Removed.
2875         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props: Removed.
2876         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebug.props: Removed.
2877         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props: Removed.
2878         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIPostBuild.cmd: Removed.
2879         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIPreBuild.cmd: Removed.
2880         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIProduction.props: Removed.
2881         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIRelease.props: Removed.
2882         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props: Removed.
2883         * win/AssembleBuildLogs: Removed.
2884         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj: Removed.
2885         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj.filters: Removed.
2886         * win/AssembleBuildLogs/AssembleLogs.cmd: Removed.
2887         * win/AssembleBuildLogs/README: Removed.
2888
2889 2016-03-04  Myles C. Maxfield  <mmaxfield@apple.com>
2890
2891         Whitespace causes font-variant: all-small-caps to synthesize
2892         https://bugs.webkit.org/show_bug.cgi?id=155004
2893         <rdar://problem/24630796>
2894
2895         Reviewed by Darin Adler.
2896
2897         * DumpRenderTree/mac/DumpRenderTree.mm:
2898         (allowedFontFamilySet):
2899         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
2900         (WTR::allowedFontFamilySet):
2901         * WebKitTestRunner/mac/TestControllerMac.mm:
2902         (WTR::allowedFontFamilySet):
2903
2904 2016-03-04  Myles C. Maxfield  <mmaxfield@apple.com>
2905
2906         [iOS] Crash during font loading when injected bundle cancels load
2907         https://bugs.webkit.org/show_bug.cgi?id=155001
2908
2909         Reviewed by Tim Horton.
2910
2911         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2912         * TestWebKitAPI/Tests/WebKit2/Ahem.ttf: Added.
2913         * TestWebKitAPI/Tests/WebKit2/webfont.html: Added.
2914         * TestWebKitAPI/Tests/WebKit2Cocoa/CancelFontSubresource.mm: Added.
2915         (-[Myles webView:didFinishNavigation:]):
2916         (TEST):
2917         * TestWebKitAPI/Tests/WebKit2Cocoa/CancelFontSubresourcePlugIn.mm: Added.
2918         (-[CancelFontSubresourcePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2919         (-[CancelFontSubresourcePlugIn webProcessPlugInBrowserContextController:frame:willSendRequestForResource:request:redirectResponse:]):
2920
2921 2016-03-04  Konstantin Tokarev  <annulen@yandex.ru>
2922
2923         [check-webkit-style] Added checks for redundant virtual specifiers.
2924         https://bugs.webkit.org/show_bug.cgi?id=155017
2925
2926         Reviewed by Darin Adler.
2927
2928         Added 3 new checks related to virtual, override, and final specifiers:
2929
2930         1. When "override" is present, "virtual" is redundant.
2931         2. When "final" is present, "virtual" is redundant.
2932         3. When "final" is present, "override" is redundant.
2933
2934         * Scripts/webkitpy/style/checkers/cpp.py:
2935         (_FunctionState.begin):
2936         (_FunctionState.is_virtual):
2937         (_check_parameter_name_against_text):
2938         (_error_redundant_specifier):
2939         (check_function_definition):
2940         (CppChecker):
2941         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2942         (FunctionDetectionTest.perform_function_detection):
2943         (FunctionDetectionTest.test_basic_function_detection):
2944         (FunctionDetectionTest.test_function_declaration_detection):
2945         (FunctionDetectionTest.test_pure_function_detection):
2946         (FunctionDetectionTest.test_override_and_final_function_detection):
2947         (FunctionDetectionTest.test_non_functions):
2948         (FunctionDetectionTest.test_parameter_list):
2949
2950 2016-03-03  Darin Adler  <darin@apple.com>
2951
2952         Followup to:
2953         Remove "virtual" from all lines that have both "virtual" and "override".
2954         https://bugs.webkit.org/show_bug.cgi?id=155005
2955
2956         Reviewed by Geoffrey Garen.
2957
2958         * Scripts/do-webcore-rename: Added more regular expressions to make sure we always
2959         use either override or final, not both, and to remove virtual from all lines that
2960         have both virtual and final.
2961
2962 2016-03-03  Darin Adler  <darin@apple.com>
2963
2964         Remove "virtual" from all lines that have both "virtual" and "override".
2965         https://bugs.webkit.org/show_bug.cgi?id=155005
2966
2967         Reviewed by Geoffrey Garen.
2968
2969         * Scripts/do-webcore-rename: Added a regular expression to this script to do the job.
2970
2971 2016-03-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2972
2973         [GTK] Unreviewed fix after r197505 (Run the run-benchmark script on the performance bot.)
2974         https://bugs.webkit.org/show_bug.cgi?id=154595
2975
2976         Unreviewed fix after r197505.
2977
2978         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2979         (RunBenchmarkTests.start):
2980
2981 2016-03-03  Daniel Bates  <dabates@apple.com>
2982
2983         Add unit tests for WTF::OptionSet
2984         https://bugs.webkit.org/show_bug.cgi?id=154925
2985         <rdar://problem/24964211>
2986
2987         Reviewed by Darin Adler.
2988
2989         Add tests to ensure that we do not regress the behavior of WTF::OptionSet.
2990
2991         * TestWebKitAPI/CMakeLists.txt: Add file TestWebKitAPI/Tests/WTF/OptionSet.cpp.
2992         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
2993         * TestWebKitAPI/Tests/WTF/OptionSet.cpp: Added.
2994         (TestWebKitAPI::TEST):
2995
2996 2016-03-03  Commit Queue  <commit-queue@webkit.org>
2997
2998         Unreviewed, rolling out r197442.
2999         https://bugs.webkit.org/show_bug.cgi?id=154967
3000
3001         Broke tests, and also uses a wrong approach (Requested by ap
3002         on #webkit).
3003
3004         Reverted changeset:
3005
3006         "Disable FTL JIT testing on 32-bit JSC tester bots"
3007         https://bugs.webkit.org/show_bug.cgi?id=154858
3008         http://trac.webkit.org/changeset/197442
3009
3010 2016-03-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3011
3012         [GTK] Run the run-benchmark script on the performance bot.
3013         https://bugs.webkit.org/show_bug.cgi?id=154595
3014
3015         Reviewed by Carlos Garcia Campos.
3016
3017         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add new RunBenchmarkTests step on the perf bots (only for the GTK+ port at this moment).
3018         (RunBenchmarkTests):
3019         (RunBenchmarkTests.start):
3020         (RunBenchmarkTests.getText):
3021         (RunBenchmarkTests.getText2):
3022         (BuildAndPerfTestFactory.__init__):
3023         (DownloadAndPerfTestFactory.__init__):
3024         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Add new test for RunBenchmarkTests and update expected steps of GTK+ perf bot.
3025         (RunBenchmarkTest):
3026         (RunBenchmarkTest.assertResults):
3027         (RunBenchmarkTest.test_success):
3028         (RunBenchmarkTest.test_tests_failed):
3029         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py: Log both the current iteration as also the total iterations for the current benchmark/plan.
3030         (BenchmarkRunner._run_benchmark):
3031         * Scripts/webkitpy/benchmark_runner/browser_driver/gtk_minibrowser_driver.py: Use python logging also for errors.
3032         (GTKMiniBrowserDriver.close_browsers):
3033         * Scripts/webkitpy/benchmark_runner/run_benchmark.py: Implement support for running all available benchmark plans.
3034         (parse_args):
3035         (start):
3036         (main):
3037
3038 2016-03-03  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3039
3040         [EFL] Remove u-szeged.hu SVN mirror in EFL perf bot
3041         https://bugs.webkit.org/show_bug.cgi?id=154960
3042
3043         Reviewed by Csaba Osztrogonác.
3044
3045         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove szeged univ's svn mirror.
3046         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3047
3048 2016-03-03  Frederic Wang  <fwang@igalia.com>
3049
3050         [jhbuild] Remove LLVM dependency.
3051         https://bugs.webkit.org/show_bug.cgi?id=153274
3052
3053         Reviewed by Carlos Garcia Campos.
3054
3055         * gtk/jhbuild.modules:
3056
3057 2016-03-02  Alejandro G. Castro  <alex@igalia.com>
3058
3059         Unreviewed build fix for media-stream after r197114.
3060
3061         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
3062         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack):
3063
3064 2016-03-01  Csaba Osztrogonác  <ossy@webkit.org>
3065
3066         Disable FTL JIT testing on 32-bit JSC tester bots
3067         https://bugs.webkit.org/show_bug.cgi?id=154858
3068
3069         Reviewed by Saam Barati.
3070
3071         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3072         (Run32bitJSCTests):
3073
3074 2016-03-01  Dean Johnson  <dean_johnson@apple.com>
3075
3076         Fix iOS EWS.
3077         https://bugs.webkit.org/show_bug.cgi?id=154880
3078
3079         Reviewed by Alexey Proskuryakov.
3080
3081         * Scripts/copy-webkitlibraries-to-product-directory:
3082
3083 2016-02-29  Chris Dumez  <cdumez@apple.com>
3084
3085         Have parseHTMLInteger() / parseHTMLNonNegativeInteger() use WTF::Optional
3086         https://bugs.webkit.org/show_bug.cgi?id=154845
3087
3088         Reviewed by Ryosuke Niwa.
3089
3090         Update API tests accordingly.
3091
3092         * TestWebKitAPI/Tests/WebCore/HTMLParserIdioms.cpp:
3093         (TestWebKitAPI::testParseHTMLInteger):
3094         (TestWebKitAPI::parseHTMLIntegerFails):
3095         (TestWebKitAPI::testParseHTMLNonNegativeInteger):
3096         (TestWebKitAPI::parseHTMLNonNegativeIntegerFails):
3097         (TestWebKitAPI::TEST): Deleted.
3098
3099 2016-02-29  Simon Fraser  <simon.fraser@apple.com>
3100
3101         Remove the experimental feature of antialiased font dilation
3102         https://bugs.webkit.org/show_bug.cgi?id=154843
3103
3104         Reviewed by Zalan Bujtas.
3105
3106         Remove the "antialiased font dilation" code path, and related prefs.
3107
3108         * DumpRenderTree/mac/DumpRenderTree.mm:
3109         (resetWebPreferencesToConsistentValues): Deleted.
3110         * WebKitTestRunner/TestController.cpp:
3111         (WTR::TestController::resetPreferencesToConsistentValues): Deleted.
3112
3113 2016-02-29  Brady Eidson  <beidson@apple.com>
3114
3115         Fix timing flakiness in test I added in http://trac.webkit.org/changeset/197372
3116
3117         Unreviewed.
3118
3119         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-1.html:
3120         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-2.html:
3121         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
3122         (TEST): Sometimes a third message from the first html file was leaking through. The message is expected
3123           so we should always wait for it and make sure we got it.
3124
3125 2016-02-29  Brady Eidson  <beidson@apple.com>
3126
3127         Modern IDB: WebKit 2 IPC layer easily confused about multiple web processes being connected.
3128         https://bugs.webkit.org/show_bug.cgi?id=154837
3129
3130         Reviewed by Alex Christensen.
3131
3132         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3133         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-1.html: Added.
3134         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-2.html: Added.
3135         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm: Added.
3136
3137 2016-02-29  Joanmarie Diggs  <jdiggs@igalia.com>
3138
3139         [GTK][jhbuild] GLib build fails with GCC 6.0
3140         https://bugs.webkit.org/show_bug.cgi?id=154825
3141
3142         Use the upstream work-around. https://bugzilla.gnome.org/show_bug.cgi?id=761550
3143
3144         Reviewed by Csaba Osztrogonác.
3145
3146         * gtk/jhbuild.modules: Apply upstream path.
3147         * gtk/patches/gdate-suppress-string-format-literal-warning.patch: Added.
3148
3149 2016-02-29  Filip Pizlo  <fpizlo@apple.com>
3150
3151         We've been running Octane/regexp all wrong in run-jsc-benchmarks
3152         https://bugs.webkit.org/show_bug.cgi?id=154827
3153
3154         Reviewed by Andreas Kling.
3155
3156         Octane v.2 and JetStream v.1.1 run this benchmark with warmup. This script was running
3157         it without warmup. This patches fixes this by making this script run it with warmup.
3158
3159         This fix shows that my last patch, which added FTL support for regexp, was actually a 3%
3160         speed-up on Octane/regexp, not a slow-down as the ChangeLog claimed.
3161
3162         It discovered this bug because for each Octane test that I want to debug, I usually make
3163         a standalone .js file that contains the whole test along with a miniharness - usually
3164         a plain loop - that runs it almost like it would for real but with whatever hacks I'm
3165         using for debugging. When I wrote such a thing for regexp, I used a ~20 iteration warmup
3166         to match the one second of warmup that this benchmark gets in Octane. To my surprise,
3167         this quite faithful regexp runner did not see the regression that run-jsc-benchmarks
3168         saw. That's when I found out that run-jsc-benchmarks was running it wrong.
3169
3170         The reason for the no-warmup slow-down is that the FTL is actually fairly expensive to
3171         run on some of these very large functions in the regexp benchmark. I don't think we can
3172         do anything about that, and I'd argue that the speed-up we see after the compilation is
3173         done suggests that it was worth it.
3174
3175         * Scripts/run-jsc-benchmarks:
3176
3177 2016-02-29  Gavin Barraclough  <barraclough@apple.com>
3178
3179         RefCounter<T>::Event -> RefCounterEvent
3180         https://bugs.webkit.org/show_bug.cgi?id=154767
3181
3182         Reviewed by Darin Adler.
3183
3184         RefCounter<T>::Event is kinda verbose to use, and there is no need for this
3185         to be specific to a particular typeof RefCounter. Move the enum class up to
3186         the top level & rename to RefCounterEvent.
3187
3188         * TestWebKitAPI/Tests/WTF/RefCounter.cpp:
3189         (TestWebKitAPI::TEST):
3190
3191 2016-02-29  Csaba Osztrogonác  <ossy@webkit.org>
3192
3193         Remove more LLVM related cruft
3194         https://bugs.webkit.org/show_bug.cgi?id=154821
3195
3196         Reviewed by Darin Adler.
3197
3198         * Scripts/build-jsc:
3199         * Scripts/build-webkit:
3200         * Scripts/copy-webkitlibraries-to-product-directory:
3201         * Scripts/export-llvm-build: Removed.
3202         * Scripts/run-jsc-stress-tests:
3203
3204 2016-02-28  Sam Weinig  <sam@webkit.org>
3205
3206         Reimplement WKPageGroup in terms of WKUserContentController
3207         https://bugs.webkit.org/show_bug.cgi?id=154804
3208
3209         Reviewed by Dan Bernstein.
3210
3211         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3212         * TestWebKitAPI/Tests/WebKit2/PageGroup.cpp: Added.
3213
3214 2016-02-28  Sam Weinig  <sam@webkit.org>
3215
3216         Bind _WKUserStyleSheets to WKUserContentWorlds to allow for grouping of user content by associating to a world
3217         https://bugs.webkit.org/show_bug.cgi?id=154798
3218
3219         Reviewed by Dan Bernstein.
3220
3221         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
3222         Add tests for removing _WKUserStyleSheets and WKUserScripts
3223
3224 2016-02-27  Alexey Proskuryakov  <ap@apple.com>
3225
3226         Silence leaks under TextCodecICU::registerCodecs
3227         https://bugs.webkit.org/show_bug.cgi?id=154737
3228
3229         Reviewed by Darin Adler.
3230
3231         * Scripts/webkitpy/port/leakdetector.py:
3232         (LeakDetector._callstacks_to_exclude_from_leaks):
3233
3234 2016-02-26  Michael Catanzaro  <mcatanzaro@igalia.com>
3235
3236         [GTK] Fix incorrect cast
3237
3238         Unreviewed.
3239
3240         * MiniBrowser/gtk/main.c:
3241         (createBrowserWindow):
3242
3243 2016-02-26  Chris Dumez  <cdumez@apple.com>
3244
3245         Fix the behavior of reflecting IDL attributes of type unsigned long
3246         https://bugs.webkit.org/show_bug.cgi?id=154771
3247
3248         Reviewed by Ryosuke Niwa.
3249
3250         Update API tests to cover the fixes to the parseHTMLNonNegativeInteger()
3251         implementation:
3252         - "-0" is parsed as 0.
3253         - Range boundaries are now [0; 2147483647].
3254
3255         * TestWebKitAPI/Tests/WebCore/HTMLParserIdioms.cpp:
3256         (TestWebKitAPI::TEST):
3257
3258 2016-02-26  Brady Eidson  <beidson@apple.com>
3259
3260         Modern IDB: New database versions are never committed to SQLite.
3261         <rdar://problem/24860952> and https://bugs.webkit.org/show_bug.cgi?id=154741
3262         
3263         Modern IDB: If a database handle is not open, files are not actually deleted from disk
3264         https://bugs.webkit.org/show_bug.cgi?id=154756
3265
3266         Reviewed by Alex Christensen.
3267
3268         This also happens to test the previously untested fix for http://trac.webkit.org/changeset/197190
3269
3270         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3271         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence-1.html: Added.
3272         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence-2.html: Added.
3273         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm: Added.
3274         (-[IndexedDBNavigationDelegate webView:didFinishNavigation:]):
3275         (-[IndexedDBMessageHandler userContentController:didReceiveScriptMessage:]):
3276         (TEST):
3277
3278 2016-02-26  Commit Queue  <commit-queue@webkit.org>
3279
3280         Unreviewed, rolling out r197216.
3281         https://bugs.webkit.org/show_bug.cgi?id=154766
3282
3283         Test simply needs updated result (Requested by litherum on
3284         #webkit).
3285
3286         Reverted changeset:
3287
3288         "Unreviewed, rolling out r197158."
3289         https://bugs.webkit.org/show_bug.cgi?id=154758
3290         http://trac.webkit.org/changeset/197216
3291
3292 2016-02-26  Alexey Proskuryakov  <ap@apple.com>
3293
3294         [iOS Simulator] Reftests don't work
3295         https://bugs.webkit.org/show_bug.cgi?id=154764
3296
3297         Reviewed by Daniel Bates.
3298
3299         * Scripts/webkitpy/port/image_diff.py: (IOSSimulatorImageDiffer._start):
3300         Use simctl instead of sim.
3301
3302 2016-02-26  Chris Dumez  <cdumez@apple.com>
3303
3304         Add API test coverage for parseHTMLInteger / parseHTMLNonNegativeInteger
3305         https://bugs.webkit.org/show_bug.cgi?id=154714
3306
3307         Reviewed by Darin Adler.
3308
3309         Add API test coverage for parseHTMLInteger / parseHTMLNonNegativeInteger as per:
3310         - https://html.spec.whatwg.org/multipage/infrastructure.html#signed-integers
3311         - https://html.spec.whatwg.org/multipage/infrastructure.html#non-negative-integers
3312
3313         * TestWebKitAPI/PlatformEfl.cmake:
3314         * TestWebKitAPI/PlatformGTK.cmake:
3315         * TestWebKitAPI/PlatformWin.cmake:
3316         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
3317         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
3318         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3319         * TestWebKitAPI/Tests/WebCore/HTMLParserIdioms.cpp: Added.
3320         (TestWebKitAPI::testParseHTMLInteger):
3321         (TestWebKitAPI::parseHTMLIntegerFails):
3322         (TestWebKitAPI::TEST):
3323         (TestWebKitAPI::testParseHTMLNonNegativeInteger):
3324         (TestWebKitAPI::parseHTMLNonNegativeIntegerFails):
3325
3326 2016-02-26  Commit Queue  <commit-queue@webkit.org>
3327
3328         Unreviewed, rolling out r197158.
3329         https://bugs.webkit.org/show_bug.cgi?id=154758
3330
3331         This change did not fix the failing test (Requested by
3332         ryanhaddad on #webkit).
3333
3334         Reverted changeset:
3335
3336         "REGRESSION(r195795): [WK2] fast/text/crash-complex-text-
3337         surrogate.html is flakey"
3338         https://bugs.webkit.org/show_bug.cgi?id=154709
3339         http://trac.webkit.org/changeset/197158
3340
3341 2016-02-26  Anders Carlsson  <andersca@apple.com>
3342
3343         WKWebsiteDataStore/WKWebsiteDataRecord needs to provide size information about each type of data
3344         https://bugs.webkit.org/show_bug.cgi?id=154750
3345         rdar://problem/23861395
3346
3347         Reviewed by Tim Horton.
3348
3349         * MiniBrowser/mac/WK2BrowserWindowController.m:
3350         (-[WK2BrowserWindowController fetchWebsiteData:]):
3351         Use the new WKWebsiteDataStore SPI to compute data sizes.
3352
3353 2016-02-25  Gavin Barraclough  <barraclough@apple.com>
3354
3355         RefCounter value changed callback should be called on all changes (not just zero edge).
3356         https://bugs.webkit.org/show_bug.cgi?id=154699
3357
3358         Reviewed by Geoff Garen.
3359
3360         RefCounter currently only triggers a callback when the count goes from zero
3361         to non-zero and vice-versa. Change that, to be useful to more clients.
3362
3363         * TestWebKitAPI/Tests/WTF/RefCounter.cpp:
3364         (TestWebKitAPI::TEST):
3365             - Updated for change in RefCounter callback siganture & behaviour.
3366
3367 2016-02-25  Sam Weinig  <sam@webkit.org>
3368
3369         Allow WKUserScripts to be run in isolated worlds
3370         https://bugs.webkit.org/show_bug.cgi?id=154701
3371
3372         Reviewed by Anders Carlsson.
3373
3374         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3375         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentWorld.mm: Added.
3376         (-[SimpleDelegate webView:didFinishNavigation:]):
3377         (-[UserContentWorldRemoteObject didObserveNormalWorld]):
3378         (-[UserContentWorldRemoteObject didObserveWorldWithName:]):
3379         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentWorldPlugIn.mm: Added.
3380         (-[_WKUserContentWorldPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
3381         (-[_WKUserContentWorldPlugIn webProcessPlugInBrowserContextController:globalObjectIsAvailableForFrame:inScriptWorld:]):
3382         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentWorldProtocol.h: Added.
3383
3384 2016-02-26  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3385
3386         W3C test importer should have an option to clean the destination directory
3387         https://bugs.webkit.org/show_bug.cgi?id=152685
3388
3389         Reviewed by Darin Adler.
3390
3391         Adding --clean-dest-dir option to W3C test importer.
3392         When this option is set, all files in the destination directory will be deleted
3393         except for WebKit specific files (test expectations, .gitignore...) before new tests import.
3394         Dangling test expectations are removed after tests import.'
3395
3396         Adding unit test and minor refactoring for the other tests.
3397
3398         * Scripts/webkitpy/w3c/test_importer.py:
3399         (parse_args): Add '--clean-dest-dir' option.
3400         (TestImporter.do_import):
3401         (TestImporter._is_baseline): helper routine to capture -expected.txt files.
3402         (TestImporter):
3403         (TestImporter._should_not_keep_when_importing): helper routine to filter files that should not be cleaned before importing.
3404         (TestImporter.clean_destination_directory):
3405         (TestImporter.remove_dangling_expectations):
3406         * Scripts/webkitpy/w3c/test_importer_unittest.py:
3407         (TestImporterTest._parse_options):
3408         (TestImporterTest.test_import_dir_with_no_tests_and_no_hg):
3409         (TestImporterTest.test_import_dir_with_no_tests):
3410         (TestImporterTest.test_import_dir_with_empty_init_py):
3411         (test_clean_directory_option):
3412
3413 2016-02-25  Myles C. Maxfield  <mmaxfield@apple.com>
3414
3415         REGRESSION(r195795): [WK2] fast/text/crash-complex-text-surrogate.html is flakey
3416         https://bugs.webkit.org/show_bug.cgi?id=154709
3417         <rdar://problem/24483596>
3418
3419         Reviewed by Dan Bernstein.
3420
3421         Force auto-activation rules to a consistent state.
3422
3423         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3424         (WTR::InjectedBundle::platformInitialize):
3425
3426 2016-02-25  Jiewen Tan  <jiewen_tan@apple.com>
3427
3428         Unreivewed build fix for r197150.
3429
3430         * TestWebKitAPI/Tests/mac/IsNavigationActionTrusted.mm:
3431
3432 2016-02-25  Jiewen Tan  <jiewen_tan@apple.com>
3433
3434         Restrict information passed with navigation action which is triggered by untrusted event
3435         https://bugs.webkit.org/show_bug.cgi?id=154571
3436         <rdar://problem/15967937>
3437
3438         Reviewed by Andy Estes.
3439
3440         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3441         * TestWebKitAPI/Tests/mac/IsNavigationActionTrusted.mm: Added.
3442         (-[WKNavigationActionDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3443         (TestWebKitAPI::TEST):
3444         (-[NavigationActionDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
3445         * TestWebKitAPI/Tests/mac/IsNavigationActionTrusted.html: Added.
3446
3447 2016-02-25  Gavin Barraclough  <barraclough@apple.com>
3448
3449         Should template RefCounter instead of RefCounter::Token
3450         https://bugs.webkit.org/show_bug.cgi?id=154691
3451
3452         Reviewed by Anders Carlsson.
3453
3454         Mechanical update per RefCounter interface change.
3455
3456         * TestWebKitAPI/Tests/WTF/RefCounter.cpp:
3457         (TestWebKitAPI::TEST):
3458
3459 2016-02-25  Skachkov Aleksandr  <gskachkov@gmail.com>
3460
3461         Unreviewed: Add Aleksandr Skachkov as a commiter
3462
3463         * Scripts/webkitpy/common/config/contributors.json:
3464
3465 2016-02-25  Sam Weinig  <sam@webkit.org>
3466
3467         HashMap::ensure() should return an AddResult like all the other add-like functions
3468         https://bugs.webkit.org/show_bug.cgi?id=154680
3469
3470         Reviewed by Anders Carlsson.
3471
3472         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3473         (TestWebKitAPI::TEST):
3474         Update tests to use/test the new AddResult result.
3475
3476 2016-02-25  Alexey Proskuryakov  <ap@apple.com>
3477
3478         Enable MallocScribble when detecting leaks
3479         https://bugs.webkit.org/show_bug.cgi?id=154679
3480
3481         Reviewed by Geoffrey Garen.
3482
3483         * Scripts/webkitpy/port/ios.py:
3484         (IOSSimulatorPort.setup_environ_for_server):
3485         * Scripts/webkitpy/port/mac.py:
3486         (MacPort.setup_environ_for_server):
3487         * Scripts/webkitpy/port/mac_unittest.py:
3488         (MacTest.test_setup_environ_for_server):
3489
3490 2016-02-25  Eric Carlson  <eric.carlson@apple.com>
3491
3492         Unreviewed, fix iOS builds after r197114.
3493
3494         * WebKitTestRunner/TestController.cpp:
3495         (WTR::createCanonicalUUIDString):
3496         (WTR::TestController::saltForOrigin):
3497
3498 2016-02-25  Eric Carlson  <eric.carlson@apple.com>
3499
3500         [MediaStream] MediaDeviceInfo deviceId and groupId must be unique to the page's origin
3501         https://bugs.webkit.org/show_bug.cgi?id=153163
3502         <rdar://problem/24334526>
3503
3504         Reviewed by Tim Horton.
3505
3506         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3507         (WTR::InjectedBundle::setUserMediaPermissionForOrigin): Take top level document origin.
3508         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3509
3510         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3511         (WTR::TestRunner::setUserMediaPermissionForOrigin): Ditto.
3512         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3513
3514         * WebKitTestRunner/TestController.cpp:
3515         (WTR::decidePolicyForUserMediaPermissionRequest): Pass through top level document origin.
3516         (WTR::checkUserMediaPermissionForOrigin): Ditto.
3517         (WTR::TestController::resetStateToConsistentValues): m_userMediaOriginPermissions -> m_cahcedUserMediaPermissions.
3518         (WTR::originUserVisibleName): Return a String.
3519         (WTR::userMediaOriginHash): Create a hash of the origin plus top level document origin.
3520         (WTR::TestController::saltForOrigin): Return salt for an origin.
3521         (WTR::TestController::setUserMediaPermissionForOrigin): Return permission for an origin.
3522         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin):
3523         (WTR::TestController::handleUserMediaPermissionRequest):
3524         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible):
3525         (WTR::OriginSettings::OriginSettings): New, class to cache settings for an origin.
3526         (WTR::OriginSettings::persistentPermission): Persistent permissions for origin.
3527         (WTR::OriginSettings::setPersistentPermission): Set permissions for origin.
3528         (WTR::OriginSettings::persistentSalt): Return the persistent salt for the origin, if any.
3529         (WTR::OriginSettings::setPersistentSalt): Set the persistent salt for the origin
3530         (WTR::OriginSettings::ephemeralSalts): Return hashmap used to store per-frame salts.
3531         * WebKitTestRunner/TestController.h:
3532
3533         * WebKitTestRunner/TestInvocation.cpp:
3534         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3535
3536 2016-02-24  Nikos Andronikos  <nikos.andronikos-webkit@cisra.canon.com.au>
3537
3538         [web-animations] Add AnimationTimeline, DocumentTimeline and add extensions to Document interface
3539         https://bugs.webkit.org/show_bug.cgi?id=151688
3540
3541         Reviewed by Dean Jackson.
3542
3543         Enables the WEB_ANIMATIONS compiler switch by default.
3544
3545         * Scripts/webkitperl/FeatureList.pm:
3546
3547 2016-02-24  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3548
3549         W3C importer should generate all web-platform-tests submodules descriptions
3550         https://bugs.webkit.org/show_bug.cgi?id=154587
3551
3552         Reviewed by Darin Adler.
3553
3554         Updated submodules description format (removing submodule name as it is the last string of the path really).
3555         Added git subroutines.
3556
3557         * Scripts/webkitpy/common/checkout/scm/git.py:
3558         (Git.origin_url):
3559         (Git):
3560         (Git.init_submodules):
3561         (Git.submodules_status):
3562         (Git.deinit_submodules):
3563         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3564         (WebPlatformTestServer._install_modules): Updated to submodule name removal.
3565         * Scripts/webkitpy/w3c/test_downloader.py:
3566         (TestDownloader._git_submodules_description): Updated to cope with recursive submodules (use of submodule init/deinit).
3567         * Scripts/webkitpy/w3c/test_importer_unittest.py:
3568         (TestImporterTest.test_submodules_generation): Reactivated partially this test.
3569
3570 2016-02-23  Dan Bernstein  <mitz@apple.com>
3571
3572         [Xcode] Linker errors display mangled names, but no longer should
3573         https://bugs.webkit.org/show_bug.cgi?id=154632
3574
3575         Reviewed by Sam Weinig.
3576
3577         * ContentExtensionTester/Configurations/Base.xcconfig: Stop setting LINKER_DISPLAYS_MANGLED_NAMES to YES.
3578         * DumpRenderTree/mac/Configurations/Base.xcconfig: Ditto.
3579         * LayoutTestRelay/Configurations/Base.xcconfig: Ditto.
3580         * MiniBrowser/Configurations/Base.xcconfig: Ditto.
3581         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
3582         * WebEditingTester/Configurations/Base.xcconfig: Ditto.
3583         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
3584
3585 2016-02-23  Anders Carlsson  <andersca@apple.com>
3586
3587         WKWebView should implement NSCoding
3588         https://bugs.webkit.org/show_bug.cgi?id=137160
3589
3590         Reviewed by Dan Bernstein.
3591
3592         Add tests.
3593
3594         * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:
3595         (TEST):
3596
3597 2016-02-23  Anders Carlsson  <andersca@apple.com>
3598
3599         WKProcessPool should conform to NSCoding
3600         https://bugs.webkit.org/show_bug.cgi?id=154608
3601
3602         Reviewed by Sam Weinig.
3603
3604         Add tests.
3605
3606         * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:
3607         (TEST):
3608
3609 2016-02-23  Anders Carlsson  <andersca@apple.com>
3610
3611         WKWebsiteDataStore should conform to NSCoding
3612         https://bugs.webkit.org/show_bug.cgi?id=154605
3613
3614         Reviewed by Dan Bernstein.
3615
3616         * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:
3617         (TEST):
3618
3619 2016-02-23  Anders Carlsson  <andersca@apple.com>
3620
3621         WKWebViewConfiguration should conform to NSCoding
3622         https://bugs.webkit.org/show_bug.cgi?id=154602
3623
3624         Reviewed by Beth Dakin.
3625
3626         * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:
3627         (TEST):
3628
3629 2016-02-23  Anders Carlsson  <andersca@apple.com>
3630
3631         WKPreferences should conform to NSCoding
3632         https://bugs.webkit.org/show_bug.cgi?id=154597
3633
3634         Reviewed by Sam Weinig.
3635
3636         Test encoding and decoding WKPreferences.
3637
3638         * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:
3639         (encodeAndDecode):
3640         (TEST):
3641
3642 2016-02-23  Anders Carlsson  <andersca@apple.com>
3643
3644         Fix build.
3645
3646         * TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.m:
3647         (-[SyntheticBackingScaleFactorWindow initWithContentRect:styleMask:backing:defer:]):
3648
3649 2016-02-23  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3650
3651         [GTK] Allow to run the WebKitGTK+ MiniBrowser with the run-benchmark script.
3652         https://bugs.webkit.org/show_bug.cgi?id=153993
3653
3654         Reviewed by Carlos Garcia Campos.
3655
3656         * MiniBrowser/gtk/main.c:
3657         (createBrowserWindow): Support --geometry argument for MiniBrowser.
3658         We use this on the gtk_minibrowser_driver script to start the MiniBrowser maximized.
3659         * Scripts/webkitpy/benchmark_runner/browser_driver/__init__.py: Fix loading of subclasses:
3660         The base class has to be loaded first, otherwise any subclase referencing it will give import error.
3661         In OSX the ordering of os.listdir() causes the base class (browser_driver.py) to be first on the list, but not on Linux.
3662         By specifiying the name of the base class file, we ensure it is always loaded first on any system despite the ordering of listdir.
3663         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
3664         (BrowserDriverFactory.create):
3665         * Scripts/webkitpy/benchmark_runner/browser_driver/gtk_browser_driver.py: Added.
3666         (GTKBrowserDriver):
3667         (GTKBrowserDriver.prepare_env):
3668         (GTKBrowserDriver.restore_env):
3669         (GTKBrowserDriver.close_browsers):
3670         (GTKBrowserDriver._launch_process):
3671         (GTKBrowserDriver._terminate_processes):
3672         (GTKBrowserDriver._screen_size):
3673         * Scripts/webkitpy/benchmark_runner/browser_driver/gtk_minibrowser_driver.py: Added.
3674         (GTKMiniBrowserDriver):
3675         (GTKMiniBrowserDriver.prepare_env):
3676         (GTKMiniBrowserDriver.launch_url):
3677         (GTKMiniBrowserDriver.close_browsers):
3678         * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py: Fix loading of subclasses. See description above.
3679         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
3680         (SimpleHTTPServerDriver):
3681         (SimpleHTTPServerDriver.kill_server): Check if the server is still running before trying to terminate it.