[GTK] Expose WebKitSecurityOrigin API
[WebKit-https.git] / Tools / ChangeLog
1 2017-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
2
3         [GTK] Expose WebKitSecurityOrigin API
4         https://bugs.webkit.org/show_bug.cgi?id=166632
5
6         Reviewed by Carlos Garcia Campos.
7
8         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
9         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSecurityOrigin.cpp: Added.
10         (testSecurityOriginBasicConstructor):
11         (testSecurityOriginURIConstructor):
12         (testSecurityOriginDefaultPort):
13         (testSecurityOriginFileURI):
14         (testSecurityOriginDataURI):
15         (beforeAll):
16         (afterAll):
17
18 2017-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
19
20         [GTK] HTTP auth layout tests are flaky
21         https://bugs.webkit.org/show_bug.cgi?id=158919
22
23         Reviewed by Michael Catanzaro.
24
25         * gtk/jhbuild.modules: Update libsoup to version 2.57.1.
26         * gtk/jhbuildrc: Stop passing --enable-introspection unconditionally to all modules. We don't really need
27         introspection for the dependencies in the internal build, and it makes newer libsoup build fail because of
28         missing valac in the bots.
29
30 2017-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
31
32         REGRESSION(r173753): [GTK] Source/WebKit is distributed in tarballs
33         https://bugs.webkit.org/show_bug.cgi?id=165797
34
35         Reviewed by Michael Catanzaro.
36
37         Move directory ruleset after all exclude rules of Source rulset.
38
39         * gtk/manifest.txt.in:
40
41 2017-01-02  Yusuke Suzuki  <utatane.tea@gmail.com>
42
43         Leverage Substring to create new AtomicStringImpl for StaticStringImpl and SymbolImpl
44         https://bugs.webkit.org/show_bug.cgi?id=166636
45
46         Reviewed by Darin Adler.
47
48         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
49         (TestWebKitAPI::TEST):
50
51 2017-01-02  Manuel Rego Casasnovas  <rego@igalia.com>
52
53         [GTK] WebCore/CSSParser unit test is not being built
54         https://bugs.webkit.org/show_bug.cgi?id=166492
55
56         Reviewed by Michael Catanzaro.
57
58         This test was introduced in r175930, but we were not building
59         it on GTK+ port since r176015.
60         This patch marks the test to be built again on GTK+.
61         JFTR, the test is passing right now.
62
63         * TestWebKitAPI/PlatformGTK.cmake: Add CSSParser.cpp test file and use
64         ADD_WHOLE_ARCHIVE_TO_LIBRARIES to avoid linking errors.
65
66 2017-01-02  Chris Fleizach  <cfleizach@apple.com>
67
68         AX: Expose block quote level to iOS API
69         https://bugs.webkit.org/show_bug.cgi?id=166629
70         <rdar://problem/29834793>
71
72         Reviewed by Darin Adler.
73
74         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
75         (AccessibilityUIElement::numberAttributeValue):
76         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
77         (WTR::AccessibilityUIElement::numberAttributeValue):
78
79 2016-12-31  Michael Catanzaro  <mcatanzaro@igalia.com>
80
81         SecurityOrigin::create triplet constructor does not canonicalize port
82         https://bugs.webkit.org/show_bug.cgi?id=166624
83
84         Reviewed by Daniel Bates.
85
86         * TestWebKitAPI/PlatformGTK.cmake:
87         * TestWebKitAPI/PlatformWin.cmake:
88         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
89         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp: Added.
90         (TestWebKitAPI::SecurityOriginTest::SetUp):
91         (TestWebKitAPI::TEST_F):
92
93 2016-12-30  Michael Catanzaro  <mcatanzaro@igalia.com>
94
95         [GTK] Improve user agent construction
96         https://bugs.webkit.org/show_bug.cgi?id=142074
97
98         Reviewed by Carlos Garcia Campos.
99
100         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
101         (TestWebKitAPI::assertUserAgentForURLHasChromeBrowserQuirk):
102         (TestWebKitAPI::assertUserAgentForURLHasFirefoxBrowserQuirk):
103         (TestWebKitAPI::assertUserAgentForURLHasLinuxPlatformQuirk):
104         (TestWebKitAPI::assertUserAgentForURLHasMacPlatformQuirk):
105         (TestWebKitAPI::TEST):
106
107 2016-12-27  Michael Catanzaro  <mcatanzaro@igalia.com>
108
109         [GTK] Improve user agent construction
110         https://bugs.webkit.org/show_bug.cgi?id=142074
111
112         Reviewed by Carlos Garcia Campos.
113
114         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
115         (TestWebKitAPI::TEST):
116
117 2016-12-23  Simon Fraser  <simon.fraser@apple.com>
118
119         REGRESSION (r209299): Selection is broken when you zoom in webpage using trackpad
120         https://bugs.webkit.org/show_bug.cgi?id=166472
121         rdar://problem/29675551
122
123         Reviewed by Tim Horton.
124
125         These changes are necessary to allow the mouse to leave the WTR window while
126         drag-scrolling, to test autoscroll. Previously, we were never calling -mouseDragged
127         (which DRT does); we'd always go through mouseMoved, which hits an early return
128         in WebViewImpl::mouseMoved() when the point is outside the view.
129
130         * WebKitTestRunner/mac/EventSenderProxy.mm:
131         (WTR::EventSenderProxy::mouseMoveTo):
132
133 2016-12-23  Andy Estes  <aestes@apple.com>
134
135         [iOS] Fix some crashing webarchive tests
136         https://bugs.webkit.org/show_bug.cgi?id=166470
137
138         Reviewed by Andreas Kling.
139
140         Tests that use TestRunner.dumpDOMAsWebArchive() crashed on iOS due to a stub implementation
141         of WebArchiveDumpSupport in WebKitTestRunner. The Mac implementation works fine on iOS too,
142         so this change uses that on both platforms.
143
144         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Removed
145         WebArchiveDumpSupportMac.mm from EXCLUDED_SOURCE_FILE_NAMES.
146         * WebKitTestRunner/InjectedBundle/cocoa/WebArchiveDumpSupportCocoa.mm: Renamed from
147         Tools/WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm.
148         * WebKitTestRunner/PlatformMac.cmake:
149         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
150         * WebKitTestRunner/ios/WebArchiveDumpSupportIOS.mm: Removed.
151
152 2016-12-22  Saam Barati  <sbarati@apple.com>
153
154         WebAssembly: Silence the output of the spec-tests
155         https://bugs.webkit.org/show_bug.cgi?id=166417
156
157         Reviewed by Mark Lam.
158
159         * Scripts/run-jsc-stress-tests:
160
161 2016-12-22  Zhuo Li  <zachli@apple.com>
162
163         [Cocoa] SPI for setloadsImagesAutomatically.
164         https://bugs.webkit.org/show_bug.cgi?id=166401.
165
166         Reviewed by Darin Adler.
167
168         * TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm:
169         (TEST): Test the _setLoadsImagesAutomatically SPI. By default,
170         _loadsImagesAutomatically returns YES.
171
172 2016-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
173
174         fast/events/ios/viewport-shrink-to-fit-allows-double-tap.html is flaky/order dependent
175         https://bugs.webkit.org/show_bug.cgi?id=161328
176         <rdar://problem/28475977>
177
178         Reviewed by Darin Adler.
179
180         Running a test that scales the viewport and listens to a didEndZooming callback (such as
181         viewport-shrink-to-fit-allows-double-tap.html) immediately after a test that may begin to trigger viewport
182         scaling as the test completes (such as viewport-device-width-at-initial-scale-fast-clicks.html) may result in
183         the didEndZooming callback of the latter test being fired early due to the previous test triggering a zoom
184         animation. Ideally, -[WKScrollView _stopScrollingAndZoomingAnimations], which is called when committing the page
185         load, should prevent this from happening, but from reading documentation and code inspection, this is not
186         intended to fire any associated delegate methods or notifications of the UIScrollView, instead deferring them
187         for later. Instead, what we need in this case is to clear out any started but not yet completed animations after
188         we finish running a test and before we load the next test.
189
190         One way to do this is to remove all animations from the WKScrollView's layer, and the layers of its children,
191         recursively. Doing so causes scrollViewDidEndZooming:withView:atScale: to fire at the end of the runloop if the
192         previous test started zooming and then finished before zooming completed. Since this happens before the next
193         test has a chance to run UI-side scripts, we won't end up firing this callback prematurely during the next test.
194
195         * WebKitTestRunner/ios/TestControllerIOS.mm:
196         (WTR::TestController::platformResetStateToConsistentValues):
197
198 2016-12-22  Jer Noble  <jer.noble@apple.com>
199
200         Muted media element playback should not interrupt other audio playback
201         https://bugs.webkit.org/show_bug.cgi?id=166347
202
203         Reviewed by Eric Carlson.
204
205         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
206         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
207         (TestWebKitAPI::TEST):
208         * TestWebKitAPI/Tests/WebKit/ios/video-with-muted-audio.html: Added.
209
210 2016-12-22  Alejandro G. Castro  <alex@igalia.com>
211
212         [WebRTC] Add support for runtime PeeConnection setting, required after r209757
213         https://bugs.webkit.org/show_bug.cgi?id=166346
214
215         Reviewed by Carlos Garcia Campos.
216
217         Enable WebRTC by default to simplify testing.
218
219         * MiniBrowser/gtk/main.c:
220         (main):
221
222 2016-12-21  Alexey Proskuryakov  <ap@apple.com>
223
224         REGRESSION: API test failure: WKWebView.LocalStorageClear
225         https://bugs.webkit.org/show_bug.cgi?id=166032
226         <rdar://problem/29758423>
227
228         Reviewed by Simon Fraser.
229
230         Add an @autoreleasepool around the code that allocates then clears the WKWebView, 
231         to ensure that the view is destroyed before the callback fires.
232
233         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
234         (TEST):
235
236 2016-12-21  Saam Barati  <sbarati@apple.com>
237
238         WebAssembly: Import spec tests
239         https://bugs.webkit.org/show_bug.cgi?id=166395
240
241         Rubber stamped by Keith Miller.
242
243         * Scripts/run-jsc-stress-tests:
244
245 2016-12-21  Alexey Proskuryakov  <ap@apple.com>
246
247         REGRESSION: API test failure: _WKDownload.OriginatingWebView
248         https://bugs.webkit.org/show_bug.cgi?id=166033
249         <rdar://problem/29758428>
250
251         Reviewed by Simon Fraser.
252
253         Add an @autoreleasepool around the code that allocates the WKWebView, 
254         so that it can be destroyed by removing the last reference in _downloadDidStart.
255
256         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
257         (TEST):
258
259 2016-12-21  Daniel Bates  <dabates@apple.com>
260
261         WebKitTestRunner: Add comment to TestRunner::setCanOpenWindows()
262         https://bugs.webkit.org/show_bug.cgi?id=166356
263
264         Add comment in TestRunner::setCanOpenWindows() to elaborate further on its purpose
265         as a means to allow a test to explicit allow an embedding client to open a new windows
266         such that the default behavior is for the embedding client to forbid such an action.
267         The test plugins/get-url-with-blank-target.html assumes this default behavior though
268         it is currently skipped on WebKit2 because questions were raised in the patch for
269         <https://bugs.webkit.org/show_bug.cgi?id=43389> about its correctness and usefulness.
270         We will need to implement TestRunner::setCanOpenWindows() should we decide to unskip
271         this test.
272
273         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
274         (WTR::TestRunner::setCanOpenWindows):
275
276 2016-12-20  Simon Fraser  <simon.fraser@apple.com>
277
278         REGRESSION: API test failure: WKWebView.EvaluateJavaScriptBlockCrash
279         https://bugs.webkit.org/show_bug.cgi?id=166031
280
281         Reviewed by Tim Horton.
282         
283         Add an @autoreleasepool around the code that allocates then clears the WKWebView, 
284         to ensure that the view is destroyed before the callback fires.
285
286         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm:
287
288 2016-12-20  Megan Gardner  <megan_gardner@apple.com>
289
290         Throw Exception when test doesn't clean up HID Events properly
291         https://bugs.webkit.org/show_bug.cgi?id=166271
292
293         Reviewed by Simon Fraser.
294
295         Add in a check when UIScriptController is deleted to make sure that the HID event
296         callback dictionary is empty. If it is not, and a HID event is hit, this will cause
297         the program to crash without any good information. Crashes are race-y, and will still
298         happen with malformed test, but the information will be much more helpful. 
299
300         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
301         (WTR::UIScriptController::checkForClean):
302         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
303         (UIScriptContext::~UIScriptContext):
304         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
305         (WTR::UIScriptController::checkForClean):
306         * TestRunnerShared/UIScriptContext/UIScriptController.h:
307         * WebKitTestRunner/ios/HIDEventGenerator.h:
308         * WebKitTestRunner/ios/HIDEventGenerator.mm:
309         (-[HIDEventGenerator checkHIDCallbacksClear]):
310         * WebKitTestRunner/ios/TestControllerIOS.mm:
311         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
312         (WTR::UIScriptController::checkForClean):
313
314 2016-12-20  Andy Estes  <aestes@apple.com>
315
316         [Cocoa] REGRESSION (r209558): Calling decisionHandler multiple times in webView:decidePolicyForNavigationAction:decisionHandler: leads to a crash
317         https://bugs.webkit.org/show_bug.cgi?id=165992
318
319         Reviewed by Brady Eidson.
320
321         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
322         * TestWebKitAPI/Tests/WebKit2Cocoa/DuplicateCompletionHandlerCalls.mm: Added.
323         (expectException):
324         (-[DuplicateCompletionHandlerCallsDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
325         (-[DuplicateCompletionHandlerCallsDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
326         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
327         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
328         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
329         (-[DuplicateCompletionHandlerCallsDelegate _webView:decideDatabaseQuotaForSecurityOrigin:currentQuota:currentOriginUsage:currentDatabaseUsage:expectedUsage:decisionHandler:]):
330         (-[DuplicateCompletionHandlerCallsDelegate _webView:willSubmitFormValues:userObject:submissionHandler:]):
331         (TEST):
332         * TestWebKitAPI/Tests/WebKit2Cocoa/duplicate-completion-handler-calls.html: Added.
333
334 2016-12-20  Dean Jackson  <dino@apple.com>
335
336         Remove INDIE_UI
337         https://bugs.webkit.org/show_bug.cgi?id=165881
338         <rdar://problem/29672532>
339
340         Reviewed by Simon Fraser.
341
342         The Indie UI work has been discontinued.
343
344         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
345
346 2016-12-19  Yusuke Suzuki  <utatane.tea@gmail.com>
347
348         [ES6] Enable ES6 Modules
349         https://bugs.webkit.org/show_bug.cgi?id=165849
350
351         Reviewed by Geoffrey Garen.
352
353         * DumpRenderTree/mac/DumpRenderTree.mm:
354         (resetWebPreferencesToConsistentValues):
355         * DumpRenderTree/win/DumpRenderTree.cpp:
356         (resetWebPreferencesToConsistentValues):
357         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
358         (WTR::InjectedBundle::beginTesting):
359         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
360         (WTR::TestRunner::setES6ModulesEnabled): Deleted.
361         * WebKitTestRunner/InjectedBundle/TestRunner.h:
362
363 2016-12-19  Ryan Haddad  <ryanhaddad@apple.com>
364
365         Repurpose bots and clean up dashboard.
366         https://bugs.webkit.org/show_bug.cgi?id=166045
367
368         Reviewed by Lucas Forschler.
369
370         * BuildSlaveSupport/build.webkit.org-config/config.json:
371         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
372         (BubbleQueueServer):
373         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
374         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
375         (WebKitBuildbot):
376         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
377         (table.queue-grid tr.platform.mac-os-x-yosemite img.logo): Deleted.
378
379 2016-12-19  Michael Catanzaro  <mcatanzaro@igalia.com>
380
381         [CMake] TestWebKitAPIBase links to itself
382         https://bugs.webkit.org/show_bug.cgi?id=165985
383
384         Reviewed by Alex Christensen.
385
386         Fix CMake warning about a target linking to itself, which makes no sense.
387
388         * TestWebKitAPI/CMakeLists.txt:
389
390 2016-12-19  Michael Catanzaro  <mcatanzaro@igalia.com>
391
392         [GTK] GtkDoc build should be quieter
393         https://bugs.webkit.org/show_bug.cgi?id=165994
394
395         Reviewed by Carlos Garcia Campos.
396
397         Make it not print by default.
398
399         * gtk/generate-gtkdoc:
400         (get_generator_for_config):
401         (generate_doc):
402         * gtk/gtkdoc.py:
403         (GTKDoc._run_command):
404         (GTKDoc._copy_doc_files_to_output_dir):
405
406 2016-12-18  Simon Fraser  <simon.fraser@apple.com>
407
408         Expose a way for MiniBrowser to simulate header and footer banners
409         https://bugs.webkit.org/show_bug.cgi?id=166005
410
411         Reviewed by Wenson Hsieh.
412         
413         Add a MiniBrowser menu item and setting to toggle adding space for header and footer
414         banners. This only works in WebKit2.
415         
416         We need to reset these on each navigation, since newly created FrameViews
417         don't re-fetch the header and footer height stored on Page.
418         
419         Also fix the signature of webView:didFinishNavigation: to follow API changes,
420         as well as fixing webViewWebContentProcessDidTerminate:
421
422         * MiniBrowser/mac/SettingsController.h:
423         * MiniBrowser/mac/SettingsController.m:
424         (-[SettingsController _populateMenu]):
425         (-[SettingsController validateMenuItem:]):
426         (-[SettingsController toggleReserveSpaceForBanners:]):
427         (-[SettingsController isSpaceReservedForBanners]):
428         * MiniBrowser/mac/WK2BrowserWindowController.m:
429         (-[WK2BrowserWindowController didChangeSettings]):
430         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
431         (-[WK2BrowserWindowController webViewWebContentProcessDidTerminate:]):
432         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]): Deleted.
433         (-[WK2BrowserWindowController _webViewWebProcessDidCrash:]): Deleted.
434
435 2016-12-17  Simon Fraser  <simon.fraser@apple.com>
436
437         Fix iOS test results after r209967.
438         
439         Subtracting out the status bar height was erroneously happening for all tests,
440         not just for flexible viewport tests.
441         
442         Fix by plumbing WebViewSizingMode through resizeTo() and setWindowFrame().
443
444         * WebKitTestRunner/PlatformWebView.h:
445         * WebKitTestRunner/TestController.cpp:
446         (WTR::TestController::resetStateToConsistentValues):
447         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
448         (WTR::PlatformWebView::resizeTo):
449         (WTR::PlatformWebView::setWindowFrame):
450         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
451         (WTR::PlatformWebView::resizeTo):
452         (WTR::PlatformWebView::setWindowFrame):
453         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
454         (WTR::PlatformWebView::resizeTo):
455         (WTR::PlatformWebView::setWindowFrame):
456         * WebKitTestRunner/ios/TestControllerIOS.mm:
457         (WTR::TestController::platformConfigureViewForTest):
458         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
459         (WTR::PlatformWebView::resizeTo):
460         (WTR::PlatformWebView::setWindowFrame):
461
462 2016-12-17  Joonghun Park  <jh718.park@samsung.com>
463
464         [EFL] bump EFL version to 1.18.4
465         https://bugs.webkit.org/show_bug.cgi?id=166004
466
467         Reviewed by Gyuyoung Kim.
468
469         * efl/jhbuild.modules: Use efl-1.18.4 instead of 1.18.1.
470
471 2016-12-17  Wenson Hsieh  <wenson_hsieh@apple.com>
472
473         Visual viewports: bottom fixed elements disappear behind the keyboard
474         https://bugs.webkit.org/show_bug.cgi?id=165983
475         <rdar://problem/29409852>
476
477         Reviewed by Simon Fraser.
478
479         Add support for UIScriptController.inputViewBounds, which UI-side scripts may use to fetch the bounding rect of
480         the keyboard when it is up.
481
482         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
483         (WTR::UIScriptController::inputViewBounds):
484         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
485         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
486         (WTR::UIScriptController::inputViewBounds):
487         * TestRunnerShared/UIScriptContext/UIScriptController.h:
488         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
489         (WTR::viewRectForWindowRect):
490
491         Previously, we accounted for the status bar height by translating the entire web view down by the height of the
492         status bar. However, we did not shrink the height of the web view itself, which means that for tests which
493         involve scrolling past the end of the document, the bottom strip of the web view is out of bounds of the window.
494
495         (WTR::PlatformWebView::PlatformWebView):
496         (WTR::PlatformWebView::setWindowFrame):
497         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
498         (WTR::UIScriptController::inputViewBounds):
499
500 2016-12-16  Ryosuke Niwa  <rniwa@webkit.org>
501
502         Deleting a character converted from pinyin after an image causes a Safari crash
503         https://bugs.webkit.org/show_bug.cgi?id=165839
504         <rdar://problem/27951933>
505
506         Reviewed by Wenson Hsieh.
507
508         Add a WebKit API test to call attributedSubstringForProposedRange on a WKWebView
509         while the proposed range contains an image. This should not cause a WebProcess to crash
510         or send an invalid message to the UIProcess.
511
512         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
513         * TestWebKitAPI/Tests/WebKit2/chinese-character-with-image.html: Added.
514         * TestWebKitAPI/Tests/WebKit2/mac/AttributedSubstringForProposedRangeWithImage.mm: Added.
515         (TestWebKitAPI::didFinishLoadForFrame):
516         (TestWebKitAPI::processDidCrash):
517         (TestWebKitAPI::invalidMessageFunction):
518         (TestWebKitAPI::WebKit2.AttributedSubstringForProposedRangeWithImage):
519
520 2016-12-16  Wenson Hsieh  <wenson_hsieh@apple.com>
521
522         Visual viewports: carets and selection UI are incorrectly positioned when editing fixed elements
523         https://bugs.webkit.org/show_bug.cgi?id=165767
524         <rdar://problem/29602382>
525
526         Reviewed by Simon Fraser.
527
528         Introduces two new UIScriptController methods: doAfterWebPageIsInStableState and textSelectionCaretRect. See
529         WebKit2 ChangeLog for more details.
530
531         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
532         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
533         (WTR::UIScriptController::textSelectionCaretRect):
534         * DumpRenderTree/mac/UIScriptControllerMac.mm:
535         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
536         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
537         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
538         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
539         (WTR::UIScriptController::textSelectionCaretRect):
540         * TestRunnerShared/UIScriptContext/UIScriptController.h:
541         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
542         (-[TestRunnerWKWebView _setStableStateOverride:]):
543
544         Force the WKWebView to update its visible content rects when changing the stable state override.
545
546         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
547         (WTR::toNSDictionary):
548         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
549         (WTR::UIScriptController::selectionRangeViewRects):
550         (WTR::UIScriptController::textSelectionCaretRect):
551         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
552         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
553
554 2016-12-15  Brent Fulgham  <bfulgham@apple.com>
555
556         Arguments called in wrong order
557         https://bugs.webkit.org/show_bug.cgi?id=165923
558
559         Reviewed by Simon Fraser.
560
561         The 'audioDeviceUIDs' array is being passed to the argument that expects video devices,
562         and the 'videoDeviceUIDs' array is being passed to the audo device argument. Fix this.
563
564         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
565         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack): The
566         order of arguments to WKUserMediaPermissionRequestAllow are flipped.
567
568 2016-12-16  Hunseop Jeong  <hs85.jeong@samsung.com>
569
570         [EFL] Disable non-srcdir builds for failing libraries
571         https://bugs.webkit.org/show_bug.cgi?id=165896
572
573         Reviewed by Gyuyoung Kim.
574
575         * efl/jhbuild.modules: Set non srcdir builds to no
576
577 2016-12-15  Daniel Bates  <dabates@apple.com>
578
579         check-style should not complain about code in icu directories
580         https://bugs.webkit.org/show_bug.cgi?id=53929
581
582         Reviewed by Darin Adler.
583
584         Skip style checking of imported ICU headers to avoid a deluge of style issues
585         as they do not conform to the WebKit Code Style guideline. We want to preserve
586         the formatting of these headers so as to make it straightforward to merge
587         changes to them, if necessary.
588
589         * Scripts/webkitpy/style/checker.py:
590
591 2016-12-15  Alexey Proskuryakov  <ap@apple.com>
592
593         Move JSC testers from Yosemite to Sierra
594         https://bugs.webkit.org/show_bug.cgi?id=165925
595
596         Reviewed by Lucas Forschler.
597
598         * BuildSlaveSupport/build.webkit.org-config/config.json:
599         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
600         (WebKitBuildbot):
601
602 2016-12-15  Megan Gardner  <megan_gardner@apple.com>
603
604         Add coordinate space to event streams and streamline tests
605         https://bugs.webkit.org/show_bug.cgi?id=165119
606
607         Reviewed by Simon Fraser.
608
609         Update event streams to allow for both content and global coordinate space.
610         Update example script to more accurately show all the available options.
611
612         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
613         * WebKitTestRunner/ios/HIDEventGenerator.h:
614         * WebKitTestRunner/ios/HIDEventGenerator.mm:
615         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
616         (WTR::convertCoordinates):
617         (WTR::UIScriptController::sendEventStream):
618
619 2016-12-15  Claudio Saavedra  <csaavedra@igalia.com>
620
621         [GTK] Ensure gst* docs are not built with update-webkitgtk-libs
622         https://bugs.webkit.org/show_bug.cgi?id=165855
623
624         Reviewed by Philippe Normand.
625
626         GStreamer's autogen.sh enables gtk-doc always so we end up building
627         docs even if we disable them. Use the configure script instead, since
628         we build from packages and these include it already.
629
630         * gtk/jhbuild.modules: Use shipped configure instead of autogen.sh for
631         upstream gstreamer packages.
632
633 2016-12-15  Alex Christensen  <achristensen@webkit.org>
634
635         REGRESSION (r208902) Null pointer dereference in wkIsPublicSuffix
636         https://bugs.webkit.org/show_bug.cgi?id=165885
637         <rdar://problem/29476917>
638
639         Reviewed by Darin Adler.
640
641         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
642         (TestWebKitAPI::utf16String): Deleted.
643         * TestWebKitAPI/Tests/mac/PublicSuffix.mm:
644         (TestWebKitAPI::TEST_F):
645         * TestWebKitAPI/WTFStringUtilities.h:
646         (utf16String):
647         Moved from URLParser to share with other tests.
648
649 2016-12-14  Ryosuke Niwa  <rniwa@webkit.org>
650
651         iOS: An element with tabindex is not focusable unless there is no mouse event handler
652         https://bugs.webkit.org/show_bug.cgi?id=165843
653
654         Reviewed by Antti Koivisto.
655
656         Add testRunner.isWebKit2 which is always true in WebKitTestRunner.
657         Without this, it's really hard to reliably differentiate DumpRenderTree and WebKitTestRunner,
658         and DumpRenderTree's runUIScript would hit an assertion :(
659
660         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
661         * WebKitTestRunner/InjectedBundle/TestRunner.h:
662         (WTR::TestRunner::isWebKit2):
663
664 2016-12-14  Brady Eidson  <beidson@apple.com>
665
666         IndexedDB 2.0: Massively speedup IDBIndex.get().
667         https://bugs.webkit.org/show_bug.cgi?id=165802
668
669         Reviewed by Alex Christensen.
670
671         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
672         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.html: Added.
673         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm: Added.
674         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexUpgrade.blob: Added.
675         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexUpgrade.sqlite3: Added.
676
677 2016-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
678
679         [GTK][EFL] Update the JHBuild version.
680         https://bugs.webkit.org/show_bug.cgi?id=165838
681
682         Reviewed by Michael Catanzaro.
683
684         * jhbuild/jhbuild-wrapper: This new version fixes a bug with the
685         usage of the JHBUILD_MIRROR feature with git repositories.
686
687 2016-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
688
689         [GTK] Yasm is needed for building the JHBuild after r208940
690         https://bugs.webkit.org/show_bug.cgi?id=165837
691
692         Reviewed by Alejandro G. Castro.
693
694         * gtk/install-dependencies: Yasm is needed for building libvpx.
695
696 2016-12-14  Youenn Fablet  <youenn@apple.com>
697
698         Test infrastructure should allow to filter out text output before doing a comparison with the baseline
699         https://bugs.webkit.org/show_bug.cgi?id=161310
700
701         Reviewed by Ryosuke Niwa.
702
703         Adding --dump-jsconsolelog-in-stderr test option for DRT and WTR.
704         When set, WTR and DRT output JS console log in the stderr and not the test output.
705         This allows removing potentially flaky information while still being able to read it for investigation.
706
707         Updated webkitpy infrastructure to use this test option in case of DumpJSConsoleLogInStdErr modifier.
708
709         Changes are covered by updating a fetch test to output console log and set its option to --dump-jsconsolelog-in-stderr in TestExpectations.
710         This test should have this option when fetch API will start logging resource loader errors.
711
712         * DumpRenderTree/DumpRenderTree.h:
713         (TestCommand::TestCommand): Deleted.
714         * DumpRenderTree/DumpRenderTreeCommon.cpp:
715         (parseInputLine):
716         * DumpRenderTree/TestRunner.h:
717         (TestRunner::setDumpJSConsoleLogInStdErr):
718         (TestRunner::dumpJSConsoleLogInStdErr):
719         * DumpRenderTree/mac/DumpRenderTree.mm:
720         (runTest):
721         * DumpRenderTree/mac/UIDelegate.mm:
722         (-[UIDelegate webView:addMessageToConsole:withSource:]):
723         * DumpRenderTree/win/DumpRenderTree.cpp:
724         (runTest):
725         * DumpRenderTree/win/UIDelegate.cpp:
726         (UIDelegate::webViewAddMessageToConsole):
727         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
728         (TestExpectationParser._tokenize_line):
729         * Scripts/webkitpy/port/driver.py:
730         (Driver._command_from_driver_input):
731         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
732         (WTR::InjectedBundle::didReceiveMessageToPage):
733         (WTR::InjectedBundle::dumpToStdErr):
734         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
735         (WTR::InjectedBundle::dumpJSConsoleLogInStdErr):
736         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
737         (WTR::InjectedBundlePage::willAddMessageToConsole):
738         * WebKitTestRunner/TestController.cpp:
739         (WTR::parseInputLine):
740         (WTR::TestController::runTest):
741         (WTR::TestCommand::TestCommand): Deleted.
742         * WebKitTestRunner/TestInvocation.cpp:
743         (WTR::TestInvocation::invoke):
744         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
745         * WebKitTestRunner/TestInvocation.h:
746         (WTR::TestInvocation::setDumpJSConsoleLogInStdErr):
747
748
749 2016-12-14  Enrique Ocaña González  <eocanha@igalia.com>
750
751         REGRESSION(r207879-207891): [GStreamer] Introduced many layout test failures and crashes, bots exiting early
752         https://bugs.webkit.org/show_bug.cgi?id=164022
753
754         Reviewed by Xabier Rodriguez-Calvar.
755
756         * Scripts/webkitperl/FeatureList.pm:
757           Re-enable MEDIA_SOURCE for the GTK+ port.
758
759 2016-12-13  Alex Christensen  <achristensen@webkit.org>
760
761         Fix CMake build.
762
763         * DumpRenderTree/PlatformMac.cmake:
764         Define NS_RETURNS_RETAINED as nothing for now.
765
766 2016-12-13  Jer Noble  <jer.noble@apple.com>
767
768         Fullscreen in WebKit2 does not restore topContentInset upon exiting; leaves top of page not visible
769         https://bugs.webkit.org/show_bug.cgi?id=165697
770
771         Reviewed by Tim Horton.
772
773         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.mm:
774         (TestWebKitAPI::TEST):
775
776 2016-12-13  Andy Estes  <aestes@apple.com>
777
778         [Cocoa] Implement -shouldInsertText: on WKWebProcessPlugInEditingDelegate
779         https://bugs.webkit.org/show_bug.cgi?id=165785
780         <rdar://problem/26929398>
781
782         Reviewed by Darin Adler.
783
784         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm:
785         (-[BundleEditingDelegateRemoteObject shouldInsertText:replacingRange:givenAction:]): Added
786         expectations for the text, range, and action.
787         (TEST): Set the "EditingDelegateShouldInsertText" bundle parameter to NO so that the plug-in
788         will return NO in -_webProcessPlugInBrowserContextController:willInsertText:. Added a
789         plain-text string to the pasteboard, executed a paste action, and verified that the selected
790         text in the web view did not change.
791         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegatePlugIn.mm:
792         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]): Set
793         _editingDelegateShouldInsertText according to the "EditingDelegateShouldInsertText" bundle
794         parameter.
795         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:shouldInsertText:replacingRange:givenAction:]):
796         Added. Called -shouldInsertText:replacingRange:givenAction: on the remote object proxy
797         and returned the value of _editingDelegateShouldInsertText.
798         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegateProtocol.h: Declared
799         -shouldInsertText:replacingRange:givenAction:.
800
801 2016-12-13  Chris Dumez  <cdumez@apple.com>
802
803         Unreviewed, rolling out r209544.
804
805         Looks like r209489 did not cause the performance regression
806         after all
807
808         Reverted changeset:
809
810         "Unreviewed, rolling out r209489."
811         https://bugs.webkit.org/show_bug.cgi?id=165550
812         http://trac.webkit.org/changeset/209544
813
814 2016-12-12  Sam Weinig  <sam@webkit.org>
815
816         [WebIDL] Remove use of Dictionary in ApplePaySession
817         https://bugs.webkit.org/show_bug.cgi?id=165787
818
819         Reviewed by Anders Carlsson.
820
821         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
822         (WTR::initializeWebViewConfiguration):
823         (WTR::TestController::platformCreateWebView):
824         Enable ApplePay for the tests (where supported).
825
826 2016-12-13  Eric Carlson  <eric.carlson@apple.com>
827
828         Annotate MediaStream and WebRTC idl with EnabledAtRuntime flag
829         https://bugs.webkit.org/show_bug.cgi?id=165251
830
831         Reviewed by Youenn Fablet.
832
833         * TestWebKitAPI/Tests/WebKit2/EnumerateMediaDevices.cpp:
834         (TestWebKitAPI::TEST): Enable MediaStream, create web view from the page group upon which
835         the preferences have been set.
836
837 2016-12-08  Antti Koivisto  <antti@apple.com>
838
839         Enable network cache speculative revalidation in MiniBrowser
840         https://bugs.webkit.org/show_bug.cgi?id=165616
841
842         Reviewed by Darin Adler.
843
844         Match Safari. Also add a menu item to disable it.
845
846         * MiniBrowser/mac/AppDelegate.m:
847         (defaultConfiguration):
848         * MiniBrowser/mac/SettingsController.h:
849         * MiniBrowser/mac/SettingsController.m:
850         (-[SettingsController _populateMenu]):
851         (-[SettingsController validateMenuItem:]):
852         (-[SettingsController networkCacheSpeculativeRevalidationDisabled]):
853         (-[SettingsController toggleNetworkCacheSpeculativeRevalidationDisabled:]):
854
855 2016-12-12  Alexey Proskuryakov  <ap@apple.com>
856
857         ChangeLogs become readonly after resolving a conflict
858         https://bugs.webkit.org/show_bug.cgi?id=165440
859         rdar://problem/29491002
860
861         Reviewed by Darin Adler.
862
863         * Scripts/resolve-ChangeLogs: (resolveChangeLog): Set correct permissions when
864         moving the file.
865
866 2016-12-12  Filip Pizlo  <fpizlo@apple.com>
867
868         Re-enable collectContinuously since it doesn't crash anymore
869
870         Rubber stamped by Michael Saboff.
871
872         * Scripts/run-jsc-stress-tests:
873
874 2016-12-11  Konstantin Tokarev  <annulen@yandex.ru>
875
876         Unreviewed attempt to fix EFL and Mac/cmake builds after r209665.
877         https://bugs.webkit.org/show_bug.cgi?id=165686
878
879         * DumpRenderTree/CMakeLists.txt: WebKit2 should precede other target
880         so that right config.h comes first in include path.
881
882 2016-12-11  Dave Hyatt  <hyatt@apple.com>
883
884         [CSS Parser] Make sure content extensions initialize AtomicString
885         https://bugs.webkit.org/show_bug.cgi?id=165737
886
887         Reviewed by Darin Adler.
888
889         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
890         (TestWebKitAPI::makeBackend):
891
892 2016-12-08  Dave Hyatt  <hyatt@apple.com>
893
894         [CSS Parser] Remove the old CSS Parser
895         https://bugs.webkit.org/show_bug.cgi?id=165645
896
897         Reviewed by Daniel Bates.
898
899         * TestWebKitAPI/Tests/WebCore/CSSParser.cpp:
900         (TestWebKitAPI::TEST):
901
902 2016-12-10  Konstantin Tokarev  <annulen@yandex.ru>
903
904         [cmake] Include WTF, JSC, and WebCore headers automatically to targers using them
905         https://bugs.webkit.org/show_bug.cgi?id=165686
906
907         Reviewed by Michael Catanzaro.
908
909         This change reduces duplication of include path lists between modules,
910         and reduces future need for fixes like r209605 (broken build because of
911         WebCore header suddenly becoming used in WebKit2).
912
913         * DumpRenderTree/CMakeLists.txt:
914         * DumpRenderTree/PlatformMac.cmake:
915         * ImageDiff/CMakeLists.txt:
916         * MiniBrowser/gtk/CMakeLists.txt:
917         * MiniBrowser/mac/CMakeLists.txt:
918         * MiniBrowser/win/CMakeLists.txt:
919         * TestWebKitAPI/CMakeLists.txt:
920         * TestWebKitAPI/PlatformEfl.cmake:
921         * TestWebKitAPI/PlatformJSCOnly.cmake:
922         * TestWebKitAPI/PlatformMac.cmake:
923         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
924         * WebKitTestRunner/CMakeLists.txt:
925         * WebKitTestRunner/PlatformGTK.cmake:
926         * WebKitTestRunner/PlatformMac.cmake:
927
928 2016-12-09  Csaba Osztrogonác  <ossy@webkit.org>
929
930         Unreviewed buildfix after r209630.
931
932         * Scripts/build-jsc: Remove building the non-existing testWASM.
933
934 2016-12-09  Eric Carlson  <eric.carlson@apple.com>
935
936         Annotate MediaStream and WebRTC idl with EnabledAtRuntime flag
937         https://bugs.webkit.org/show_bug.cgi?id=165251
938
939         Reviewed by Dean Jackson.
940
941         Based on a patch by Dr Alex Gouaillard <agouaillard@gmail.com>
942
943         * DumpRenderTree/mac/DumpRenderTree.mm:
944         (resetWebPreferencesToConsistentValues): Enable MediaStream and PeerConnection.
945
946         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
947         (WTR::InjectedBundle::beginTesting): Ditto.
948
949         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
950         (WTR::TestRunner::setMediaStreamEnabled): New.
951         (WTR::TestRunner::setPeerConnectionEnabled): New.
952         * WebKitTestRunner/InjectedBundle/TestRunner.h:
953
954 2016-12-09  Brady Eidson  <beidson@apple.com> 
955  
956         Re-landing:
957         Add _WKIconLoadingDelegate SPI. 
958         https://bugs.webkit.org/show_bug.cgi?id=164894 
959  
960         Reviewed by Alex Christensen. 
961         
962         Add MiniBrowser support for this new SPI, configurable with a setting. 
963  
964         * MiniBrowser/mac/SettingsController.h: 
965         * MiniBrowser/mac/SettingsController.m: 
966         (-[SettingsController _populateMenu]): 
967         (-[SettingsController validateMenuItem:]): 
968         (-[SettingsController loadsAllSiteIcons]): 
969         (-[SettingsController toggleLoadsAllSiteIcons:]): 
970         * MiniBrowser/mac/WK2BrowserWindowController.m: 
971         (-[WK2BrowserWindowController awakeFromNib]): 
972         (-[WK2BrowserWindowController webView:shouldLoadIconWithParameters:completionHandler:]): 
973
974 2016-12-09  Ryan Haddad  <ryanhaddad@apple.com>
975
976         Fix the 32-bit build.
977
978         Unreviewed build fix.
979
980         * MiniBrowser/mac/SettingsController.h:
981
982 2016-12-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
983
984         Fedora also needs a PHP7 config file alternative
985         https://bugs.webkit.org/show_bug.cgi?id=165606
986
987         Reviewed by Michael Catanzaro.
988
989         * Scripts/webkitpy/port/base.py:
990         (Port._is_fedora_php_version_7): check for the php7 library.
991         (Port._fedora_php_version): get the appropriate filename for Fedora.
992         (Port._apache_config_file_name_for_platform):
993
994 2016-12-09  Ryan Haddad  <ryanhaddad@apple.com>
995
996         Complete the revert of r208865.
997         https://bugs.webkit.org/show_bug.cgi?id=164894
998
999         Unreviewed build fix.
1000
1001         * MiniBrowser/mac/SettingsController.h:
1002         * MiniBrowser/mac/SettingsController.m:
1003         (-[SettingsController _populateMenu]):
1004         (-[SettingsController validateMenuItem:]):
1005         (-[SettingsController loadsAllSiteIcons]): Deleted.
1006         (-[SettingsController toggleLoadsAllSiteIcons:]): Deleted.
1007         * MiniBrowser/mac/WK2BrowserWindowController.m:
1008         (-[WK2BrowserWindowController awakeFromNib]):
1009         (-[WK2BrowserWindowController webView:shouldLoadIconWithParameters:completionHandler:]): Deleted.
1010
1011 2016-12-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1012
1013         [GTK] Force GDK backend to x11 when running with XvfbDriver
1014         https://bugs.webkit.org/show_bug.cgi?id=165612
1015
1016         Reviewed by Michael Catanzaro.
1017
1018         When the developer is running a Wayland session, GDK may get confused
1019         and try to use its Wayland backend (which is higher priority) instead.
1020         This ensures it will use the appropriate backend when running under
1021         Xvfb.
1022
1023         * Scripts/webkitpy/port/gtk.py:
1024         (GtkPort.setup_environ_for_server): when running with XvfbDriver,
1025         force GDK_BACKEND to x11.
1026
1027 2016-12-08  Keith Miller  <keith_miller@apple.com>
1028
1029         Add 64-bit signed LEB decode method
1030         https://bugs.webkit.org/show_bug.cgi?id=165630
1031
1032         Reviewed by Ryosuke Niwa.
1033
1034         Add tests for LEB int64 and uint64 decode since I guess
1035         I forgot to add tests before.
1036
1037         * TestWebKitAPI/Tests/WTF/LEBDecoder.cpp:
1038         (TestWebKitAPI::testUInt32LEBDecode):
1039         (TestWebKitAPI::TEST):
1040         (TestWebKitAPI::testUInt64LEBDecode):
1041         (TestWebKitAPI::testInt32LEBDecode):
1042         (TestWebKitAPI::testInt64LEBDecode):
1043         (TestWebKitAPI::testUnsignedLEBDecode): Deleted.
1044
1045 2016-12-08  Filip Pizlo  <fpizlo@apple.com>
1046
1047         Make it easy to enable --force-collectContinuously
1048         https://bugs.webkit.org/show_bug.cgi?id=165638
1049
1050         Reviewed by Keith Miller.
1051
1052         * Scripts/run-javascriptcore-tests:
1053         (runJSCStressTests):
1054
1055 2016-12-08  Filip Pizlo  <fpizlo@apple.com>
1056
1057         Disable the collectContinuously mode until I investigate failures.
1058
1059         Rubber stamped by Keith Miller.
1060         
1061         I'm seeing collectContinuously crashes on some platforms. Disabling that testing mode
1062         while I investigate.
1063
1064         * Scripts/run-jsc-stress-tests:
1065
1066 2016-12-08  Alex Christensen  <achristensen@webkit.org>
1067
1068         REGRESSION (URL parser): Relative URLs aren’t resolved correctly when the base URL is an applewebdata: URL
1069         https://bugs.webkit.org/show_bug.cgi?id=165621
1070
1071         Reviewed by Dan Bernstein.
1072
1073         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1074         (TestWebKitAPI::TEST_F):
1075
1076 2016-12-06  Filip Pizlo  <fpizlo@apple.com>
1077
1078         Concurrent GC should be stable enough to land enabled
1079         https://bugs.webkit.org/show_bug.cgi?id=164990
1080
1081         Reviewed by Geoffrey Garen.
1082         
1083         Add a new mode that runs GC continuously. Also made eager modes run GC continuously.
1084         
1085         It's clear that this works just fine in release, but I'm still trying to figure out if it's
1086         safe for debug. It might be too slow for debug.
1087
1088         * Scripts/run-jsc-stress-tests:
1089
1090 2016-12-08  Alex Christensen  <achristensen@webkit.org>
1091
1092         Add SPI for sending WebsiteSettings to WebProcess during navigation
1093         https://bugs.webkit.org/show_bug.cgi?id=165517
1094         <rdar://29341068>
1095
1096         Reviewed by Anders Carlsson.
1097
1098         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1099         * TestWebKitAPI/Tests/WebKit2/contentBlockerCheck.html: Added.
1100         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm: Added.
1101         (-[WebsitePoliciesDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1102         (-[WebsitePoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
1103         (-[WebsitePoliciesDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1104         (TEST):
1105
1106 2016-12-08  Chris Dumez  <cdumez@apple.com>
1107
1108         Unreviewed, rolling out r209489.
1109
1110         Likely caused large regressions on JetStream, Sunspider and
1111         Speedometer
1112
1113         Reverted changeset:
1114
1115         "Add system trace points for JavaScript VM entry/exit"
1116         https://bugs.webkit.org/show_bug.cgi?id=165550
1117         http://trac.webkit.org/changeset/209489
1118
1119 2016-12-08  Keith Miller  <keith_miller@apple.com>
1120
1121         Move LEB tests to API tests
1122         https://bugs.webkit.org/show_bug.cgi?id=165586
1123
1124         Reviewed by Saam Barati.
1125
1126         Move the tests from testWasm.cpp and make them functions
1127         rather than macros.
1128
1129         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1130         * TestWebKitAPI/Tests/WTF/LEBDecoder.cpp: Added.
1131         (TestWebKitAPI::testUnsignedLEBDecode):
1132         (TestWebKitAPI::TEST):
1133         (TestWebKitAPI::testInt32LEBDecode):
1134
1135 2016-12-08  Chris Dumez  <cdumez@apple.com>
1136
1137         Support running the layout tests offline
1138         https://bugs.webkit.org/show_bug.cgi?id=165534
1139
1140         Reviewed by Ryosuke Niwa.
1141
1142         * Scripts/webkitpy/common/system/autoinstall.py:
1143         (AutoInstaller._download_to_stream):
1144         getcode() returns None for file URLs so handle this.
1145
1146         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1147         (WebPlatformTestServer._install_modules):
1148         Deal with local path in the json file and resolve them into file URLs
1149         before using AutoInstall.
1150
1151 2016-12-08  Alex Christensen  <achristensen@webkit.org>
1152
1153         Fix CMake build.
1154
1155         * DumpRenderTree/PlatformMac.cmake:
1156         Remove CheckedMalloc.cpp after r209516.
1157
1158 2016-12-07  Mark Lam  <mark.lam@apple.com>
1159
1160         DumpRenderTree should stop using CheckedMalloc.
1161         https://bugs.webkit.org/show_bug.cgi?id=165563
1162         <rdar://problem/28945820>
1163
1164         Reviewed by Geoffrey Garen.
1165
1166         1. WebKitTestRunner does not have equivalent behavior to that which is implemented
1167            in CheckedMalloc.
1168         2. bmalloc does not honor the settings of CheckedMalloc.
1169
1170         The only time CheckedMalloc comes into play is when DRT uses gmalloc or system
1171         malloc.  As a result, DRT exhibits different behavior from the normal way we run
1172         our tests.  We should obsolete CheckedMalloc and make DRT behave consistently
1173         with WKTR.
1174
1175         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1176         * DumpRenderTree/mac/CheckedMalloc.cpp: Removed.
1177         * DumpRenderTree/mac/CheckedMalloc.h: Removed.
1178         * DumpRenderTree/mac/DumpRenderTree.mm:
1179         (prepareConsistentTestingEnvironment):
1180
1181 2016-12-07  Dean Jackson  <dino@apple.com>
1182
1183         Remove runtime toggle for pointer-lock
1184         https://bugs.webkit.org/show_bug.cgi?id=165577
1185         <rdar://problems/29566996>
1186
1187         Reviewed by Jon Lee.
1188
1189         Remove any runtime calls to check if pointer-lock is enabled. It's
1190         either compiled in or out.
1191
1192         * DumpRenderTree/mac/DumpRenderTree.mm:
1193         (resetWebPreferencesToConsistentValues):
1194         * WebKitTestRunner/TestController.cpp:
1195         (WTR::TestController::resetPreferencesToConsistentValues):
1196
1197 2016-12-07  Eric Carlson  <eric.carlson@apple.com>
1198
1199         [MediaStream][Mac] Revoke sandbox extensions when capture ends
1200         https://bugs.webkit.org/show_bug.cgi?id=165476
1201
1202         Reviewed by Brady Eidson.
1203         
1204         Add a test which loads a page that calls navigator.mediaDevices.enumerateDevices, kills the
1205         page, and loads the same page again to ensure that the WK2 UserMediaPermissionRequestManagerProxy
1206         is reset and recreated when a web page exits and is reloaded.
1207
1208         * TestWebKitAPI/PlatformGTK.cmake:
1209         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1210         * TestWebKitAPI/Tests/WebKit2/EnumerateMediaDevices.cpp: Added.
1211         (TestWebKitAPI::checkUserMediaPermissionCallback):
1212         (TestWebKitAPI::TEST):
1213         * TestWebKitAPI/Tests/WebKit2/enumerateMediaDevices.html: Added.
1214
1215 2016-12-07  Jeremy Jones  <jeremyj@apple.com>
1216
1217         One esc to exit fullscreen and pointer lock
1218         https://bugs.webkit.org/show_bug.cgi?id=165416
1219         rdar://problem/29430711
1220
1221         Reviewed by Jer Noble.
1222
1223         Implement WKPageUIClientV8 for pointer lock support.
1224         Add "escape" key support in EventSenderProxy.
1225
1226         * WebKitTestRunner/TestController.cpp:
1227         (WTR::requestPointerLock):
1228         (WTR::TestController::createOtherPage):
1229         (WTR::TestController::createWebViewWithOptions):
1230         * WebKitTestRunner/mac/EventSenderProxy.mm:
1231         (WTR::EventSenderProxy::keyDown):
1232
1233 2016-12-07  Simon Fraser  <simon.fraser@apple.com>
1234
1235         Add system trace points for JavaScript VM entry/exit
1236         https://bugs.webkit.org/show_bug.cgi?id=165550
1237
1238         Reviewed by Tim Horton.
1239
1240         Add trace points for entry/exit into/out of the JS VM.
1241
1242         * Tracing/SystemTracePoints.plist:
1243
1244 2016-12-07  ChangSeok Oh  <changseok@webkit.org>
1245
1246         [GTK] Cannot build GTK+ with CUPS 2.* versions
1247         https://bugs.webkit.org/show_bug.cgi?id=163591
1248
1249         Reviewed by Michael Catanzaro.
1250
1251         GTK+ build has failed on the system which CUPS 2.x is installed in. GTK+ 3.16.4
1252         does not assume to use the recent CUPS thus it fails to detect the CUPS in configuration.
1253         GTK+ upstream fixed this issue but it is not easy to apply the original patch to our
1254         old gtk+ since it requires not only bumping up glib accordingly and its consequence
1255         causes many printing test failures. So, I propose to fix the configuration issue by
1256         applying the change to the configure file directly. By doing this, we don't need to
1257         upgrade glib and worry about any test failures as a consequence of the upgraded glib.
1258
1259         * gtk/jhbuild.modules:
1260         * gtk/patches/gtk+-configure-fix-detecting-CUPS-2.x.patch: Added.
1261
1262 2016-12-07  Simon Fraser  <simon.fraser@apple.com>
1263
1264         Fix use of enum in a WK2 C SPI header.
1265         rdar://problem/28725583
1266
1267         Followup to correctly prefix the enum values.
1268
1269         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1270         (WTR::InjectedBundlePage::prepare):
1271
1272 2016-12-07  Simon Fraser  <simon.fraser@apple.com>
1273
1274         Fix use of enum in a WK2 C SPI header.
1275         rdar://problem/28725583
1276
1277         Reviewed by Dan Bernstein.
1278
1279         Use correct enum style for a C SPI header and fix the callers.
1280
1281         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1282         (WTR::InjectedBundlePage::prepare):
1283
1284 2016-12-07  Wenson Hsieh  <wenson_hsieh@apple.com>
1285
1286         Add a new project for recording and playing back editing commands in editable web content
1287         https://bugs.webkit.org/show_bug.cgi?id=165114
1288         <rdar://problem/29408135>
1289
1290         Reviewed by Beth Dakin.
1291
1292         Adds a new Xcode project containing work towards rewinding and playing back editing commands. This work is
1293         wrapped in an Xcode project to take advantage of the XCTest framework. To manually test recording, open the
1294         capture test harness, edit the contenteditable body, and then hit cmd-S. This downloads a .json file which may
1295         then be dragged into the playback test harness.
1296
1297         Also adds 3 new unit tests in EditingHistoryTests/RewindAndPlaybackTests.m. These tests carry out the following
1298         steps:
1299
1300         1. Load the capture harness and perform test-specific editing on the web view.
1301         2. Let originalState be a dump of the DOM at this point in time.
1302         3. Extract the JSON-serialized editing history data and load the playback harness with this data.
1303         4. Rewind all editing to the beginning.
1304         5. Playback all editing to the end.
1305         6. Dump the state of the DOM. This should be identical to originalState.
1306
1307         * EditingHistory/EditingHistory.xcodeproj/project.pbxproj: Added.
1308         * EditingHistory/EditingHistory/Info.plist: Added.
1309         * EditingHistory/EditingHistory/Resources/CaptureHarness.html: Added.
1310         * EditingHistory/EditingHistory/Resources/DOMTestingUtil.js: Added.
1311         * EditingHistory/EditingHistory/Resources/PlaybackHarness.html: Added.
1312         * EditingHistory/EditingHistory/TestRunner.h: Added.
1313         * EditingHistory/EditingHistory/TestRunner.m: Added.
1314         (injectedMessageEventHandlerScript):
1315         (-[TestRunner init]):
1316         (-[TestRunner deleteBackwards:]):
1317         (-[TestRunner typeString:]):
1318         (-[TestRunner bodyElementSubtree]):
1319         (-[TestRunner bodyTextContent]):
1320         (-[TestRunner editingHistoryJSON]):
1321         (-[TestRunner loadPlaybackTestHarnessWithJSON:]):
1322         (-[TestRunner numberOfUpdates]):
1323         (-[TestRunner jumpToUpdateIndex:]):
1324         (-[TestRunner expectEvents:afterPerforming:]):
1325         (-[TestRunner loadCaptureTestHarness]):
1326         (-[TestRunner setTextObfuscationEnabled:]):
1327         (-[TestRunner isDoneWaitingForPendingEvents]):
1328         (-[TestRunner userContentController:didReceiveScriptMessage:]):
1329
1330         The TestRunner provides utilities that a unit test should use to drive the test forward (e.g. loading harnesses)
1331         or inspect the state of the loaded page (e.g. extracting JSON editing history data from the capture harness).
1332
1333         * EditingHistory/EditingHistory/TestUtil.h: Added.
1334         * EditingHistory/EditingHistory/TestUtil.m: Added.
1335         (waitUntilWithTimeout):
1336         (waitUntil):
1337
1338         Provides utilities for running tests. For now, this is just spinning the runloop on a given condition.
1339
1340         * EditingHistory/EditingHistory/WKWebViewAdditions.h: Added.
1341         * EditingHistory/EditingHistory/WKWebViewAdditions.m: Added.
1342         (-[WKWebView loadPageFromBundleNamed:]):
1343         (-[WKWebView typeCharacter:]):
1344         (-[WKWebView keyPressWithCharacters:keyCode:]):
1345         (-[WKWebView stringByEvaluatingJavaScriptFromString:]):
1346
1347         Provides utilities for simulating interaction in a web view.
1348
1349         * EditingHistory/EditingHistory/main.m: Added.
1350         (main):
1351         * EditingHistory/EditingHistoryTests/Info.plist: Added.
1352         * EditingHistory/EditingHistoryTests/RewindAndPlaybackTests.m: Added.
1353         (-[RewindAndPlaybackTests setUp]):
1354         (-[RewindAndPlaybackTests tearDown]):
1355         (-[RewindAndPlaybackTests testTypingSingleLineOfText]):
1356         (-[RewindAndPlaybackTests testTypingMultipleLinesOfText]):
1357         (-[RewindAndPlaybackTests testTypingAndDeletingText]):
1358         (-[RewindAndPlaybackTests rewindAndPlaybackEditingInPlaybackTestHarness]):
1359         (-[RewindAndPlaybackTests originalBodySubtree:isEqualToFinalSubtree:]):
1360
1361 2016-12-07  Philippe Normand  <pnormand@igalia.com>
1362
1363         [GTK][jhbuild] missing dependency on libvpx in gst-plugins-good
1364         https://bugs.webkit.org/show_bug.cgi?id=165525
1365
1366         Reviewed by Carlos Garcia Campos.
1367
1368         * gtk/jhbuild.modules: gst-plugins-good should depend on the
1369         libvpx package built within jhbuild.
1370
1371 2016-12-07  Philippe Normand  <pnormand@igalia.com>
1372
1373         [GTK][jhbuild] gst-plugins-bad fails to build with OpenSSL 1.1.0
1374         https://bugs.webkit.org/show_bug.cgi?id=165520
1375
1376         Reviewed by Carlos Garcia Campos.
1377
1378         * gtk/jhbuild.modules: Added missing dependency on openh264 in
1379         gst-plugins-bad, along with 2 upstream patches fixing the build
1380         against OpenSSL 1.1.0.
1381         * gtk/patches/gst-plugins-bad-0001-dtls-port-to-OpenSSL-1.1.0.patch: Added.
1382         * gtk/patches/gst-plugins-bad-0002-dtlscertificate-Fix-error-checking-in-RSA_generate_k.patch: Added.
1383
1384 2016-12-06  Alexey Proskuryakov  <ap@apple.com>
1385
1386         Correct SDKROOT values in xcconfig files
1387         https://bugs.webkit.org/show_bug.cgi?id=165487
1388         rdar://problem/29539209
1389
1390         Reviewed by Dan Bernstein.
1391
1392         Fix suggested by Dan Bernstein.
1393
1394         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
1395         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1396         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1397         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1398         * WebEditingTester/Configurations/DebugRelease.xcconfig:
1399         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1400
1401 2016-12-06  Daniel Bates  <dabates@apple.com>
1402
1403         WebKitTestRunner: Plugins are disabled in new windows
1404         https://bugs.webkit.org/show_bug.cgi?id=165410
1405
1406         Reviewed by Alex Christensen.
1407
1408         Currently WebKitTestRunner only enables plugins in the main window. So, a test that opens
1409         a new window and loads a plugin will fail. We should enable plugins in all windows by
1410         default. Moreover toggling testRunner.setPluginsEnabled() should effect all windows.
1411
1412         Making these changes is a step towards running plugins/open-and-close-window-with-plugin.html
1413         in WebKitTestRunner (we still need to fix <https://bugs.webkit.org/show_bug.cgi?id=46714>) and
1414         will make the behavior of WebKitTestRunner more closely match the behavior DumpRenderTree.
1415
1416         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1417         (WTR::InjectedBundle::beginTesting): Call TestRunner::setPluginsEnabled() instead of
1418         WKBundleSetPluginsEnabled().
1419         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1420         (WTR::TestRunner::setPluginsEnabled): Take a similar approach as TestRunner::setXSSAuditorEnabled()
1421         and make use of WKBundleOverrideBoolPreferenceForTestRunner().
1422
1423 2016-12-05  Dean Jackson  <dino@apple.com>
1424
1425         pointer lock needs to be feature detectable
1426         https://bugs.webkit.org/show_bug.cgi?id=165426
1427         <rdar://problem/29486715>
1428
1429         Reviewed by Antoine Quint.
1430
1431         Expose the comment line to turn on/off pointer lock.
1432
1433         * DumpRenderTree/TestOptions.h:
1434         * DumpRenderTree/TestOptions.mm:
1435         (TestOptions::TestOptions):
1436         * DumpRenderTree/mac/DumpRenderTree.mm:
1437         (resetWebPreferencesToConsistentValues):
1438         * WebKitTestRunner/TestController.cpp:
1439         (WTR::TestController::resetPreferencesToConsistentValues):
1440         (WTR::updateTestOptionsFromTestHeader):
1441         * WebKitTestRunner/TestOptions.h:
1442         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1443         (WTR::PlatformWebView::viewSupportsOptions):
1444         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1445         (WTR::PlatformWebView::viewSupportsOptions):
1446
1447 2016-12-05  Jonathan Bedard  <jbedard@apple.com>
1448
1449         Make it possible to use an existing simulator instance for one-off testing
1450         https://bugs.webkit.org/show_bug.cgi?id=164568
1451         <rdar://problem/29189133>
1452
1453         Reviewed by Daniel Bates.
1454
1455         With this patch, if a simulator is currently running on the machine and
1456         '--dedicated-simulators' is not passed into the application, only one simulator
1457         instance will be used, and this instance will be the existing instance.
1458         If no simulator is running or '--dedicated-simulators' is passed to the script,
1459         previous behavior will be used.
1460
1461         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1462         (parse_args):
1463         * Scripts/webkitpy/port/ios.py:
1464         (IOSSimulatorPort.__init__): Logic for enabling usage of currently running simulator.
1465         (IOSSimulatorPort._create_simulators): Only create simulators when needed, don't reset already running simulators.
1466         (IOSSimulatorPort.setup_test_run): Don't open already running simulators.
1467         (IOSSimulatorPort._quit_ios_simulator): Only quit simulators if we manage them.
1468         (IOSSimulatorPort.clean_up_test_run): Only clean up simulators if we manage them. 
1469         (IOSSimulatorPort._using_dedicated_simulators): True if simulators need to be managed, false if using an existing instance.
1470         (IOSSimulatorPort.device_id_for_worker_number): Access currently running simulator if not managing devices.
1471         * Scripts/webkitpy/xcode/simulator.py:
1472         (Simulator.refresh): Check if xcode_simctl_list returned None instead of a generator.
1473         (Simulator.current_device): Get currently running device.
1474
1475 2016-12-05  Dan Bernstein  <mitz@apple.com>
1476
1477         Disable a crashing test on iOS.
1478
1479         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm:
1480
1481 2016-12-04  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1482
1483         Fix a build break on EFL since r209303.
1484
1485         Unreviewed build fix.
1486
1487         * Scripts/webkitperl/FeatureList.pm: Disable SS Device Adaptation temporarily.
1488
1489 2016-12-03  Yusuke Suzuki  <utatane.tea@gmail.com>
1490
1491         Refactor SymbolImpl layout
1492         https://bugs.webkit.org/show_bug.cgi?id=165247
1493
1494         Reviewed by Darin Adler.
1495
1496         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1497         (TestWebKitAPI::TEST):
1498
1499 2016-12-03  Dan Bernstein  <mitz@apple.com>
1500
1501         Fixed the build after r209307.
1502
1503         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm:
1504         (TEST):
1505
1506 2016-12-03  Dan Bernstein  <mitz@apple.com>
1507
1508         [Cocoa] Expose InjectedBundlePageEditorClient via the Objective-C bundle SPI
1509         https://bugs.webkit.org/show_bug.cgi?id=165276
1510         <rdar://problem/29467040>
1511
1512         Reviewed by Darin Adler.
1513
1514         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1515         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm: Added.
1516         (-[BundleEditingDelegateRemoteObject willWriteToPasteboard:]):
1517         (-[BundleEditingDelegateRemoteObject didWriteToPasteboard]):
1518         (TEST):
1519         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegatePlugIn.mm: Added.
1520         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1521         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:willWriteRangeToPasteboard:]):
1522         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:pasteboardDataForRange:]):
1523         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextControllerDidWriteToPasteboard:]):
1524         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegateProtocol.h: Added.
1525
1526 2016-12-02  Andy Estes  <aestes@apple.com>
1527
1528         [Cocoa] Adopt the PRODUCT_BUNDLE_IDENTIFIER build setting
1529         https://bugs.webkit.org/show_bug.cgi?id=164492
1530
1531         Reviewed by Dan Bernstein.
1532
1533         * DumpRenderTree/TestNetscapePlugIn/mac/Info.plist: Changed CFBundleIdentifier's value from
1534         com.apple.testnetscapeplugin to ${PRODUCT_BUNDLE_IDENTIFIER}.
1535         * DumpRenderTree/ios/Info.plist: Changed CFBundleIdentifier's value from
1536         org.webkit.DumpRenderTree to ${PRODUCT_BUNDLE_IDENTIFIER}.
1537         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig: Set
1538         PRODUCT_BUNDLE_IDENTIFIER to org.webkit.DumpRenderTree.
1539         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Set
1540         PRODUCT_BUNDLE_IDENTIFIER to com.apple.testnetscapeplugin.
1541         * MiniBrowser/Configurations/MiniBrowser.xcconfig: Set PRODUCT_BUNDLE_IDENTIFIER to
1542         org.webkit.$(PRODUCT_NAME:rfc1034identifier).
1543         * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig: Set PRODUCT_BUNDLE_IDENTIFIER to
1544         com.apple.$(PRODUCT_NAME:rfc1034identifier).
1545         * MiniBrowser/mac/Bundle/Info.plist: Changed CFBundleIdentifier's value from
1546         com.apple.${PRODUCT_NAME:rfc1034identifier} to ${PRODUCT_BUNDLE_IDENTIFIER}.
1547         * MiniBrowser/mac/Info.plist: Changed CFBundleIdentifier's value from
1548         org.webkit.${PRODUCT_NAME} to ${PRODUCT_BUNDLE_IDENTIFIER}.
1549         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig: Set INFOPLIST_FILE to
1550         InjectedBundle-Info.plist and set PRODUCT_BUNDLE_IDENTIFIER to
1551         com.apple.$(PRODUCT_NAME:rfc1034identifier).
1552         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Set PRODUCT_BUNDLE_IDENTIFIER to
1553         com.apple.$(PRODUCT_NAME:rfc1034identifier).
1554         * TestWebKitAPI/InjectedBundle-Info.plist: Changed CFBundleIdentifier's value from
1555         com.yourcompany.${PRODUCT_NAME:rfc1034identifier} to ${PRODUCT_BUNDLE_IDENTIFIER}.
1556         * TestWebKitAPI/cocoa/WebProcessPlugIn/Info.plist: Added a CFBundleIdentifier key with the
1557         value ${PRODUCT_BUNDLE_IDENTIFIER}.
1558         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Set INFOPLIST_FILE to
1559         InjectedBundle-Info.plist and set PRODUCT_BUNDLE_IDENTIFIER to
1560         com.apple.WebKitTestRunner.InjectedBundle.
1561         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Set
1562         PRODUCT_BUNDLE_IDENTIFIER to org.webkit.$(PRODUCT_NAME:rfc1034identifier).
1563         * WebKitTestRunner/InjectedBundle-Info.plist: Changed CFBundleIdentifier's value from
1564         com.apple.WebKitTestRunner.InjectedBundle to ${PRODUCT_BUNDLE_IDENTIFIER}.
1565         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist: Changed
1566         CFBundleIdentifier's value from org.webkit.${PRODUCT_NAME:rfc1034identifier} to
1567         ${PRODUCT_BUNDLE_IDENTIFIER}.
1568
1569 2016-12-02  Brady Eidson  <beidson@apple.com>
1570
1571         Make IndexedDB.WebProcessKillIDBCleanup even more reliable.
1572         https://bugs.webkit.org/show_bug.cgi?id=165330
1573
1574         Reviewed by Alex Christensen.
1575
1576         The test currently nulls out a RetainPtr<WKWebView> to try to destroy the view and kill the process.
1577
1578         Problem is that doesn't reliably destroy the view.
1579         We should explicitly kill the process instead.
1580
1581         Also, by relocating when we kill the process, we can better test behavior of the IndexedDB mechanism.
1582         e.g. We explicitly confirm that a second WebProcess can simultaneously attach to the same unique database as the first.
1583
1584         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
1585         (TEST):
1586
1587 2016-12-02  Commit Queue  <commit-queue@webkit.org>
1588
1589         Unreviewed, rolling out r209136.
1590         https://bugs.webkit.org/show_bug.cgi?id=165337
1591
1592         broke 36 webkitpy tests (Requested by mcatanzaro on #webkit).
1593
1594         Reverted changeset:
1595
1596         "Make it possible to use an existing simulator instance for
1597         one-off testing"
1598         https://bugs.webkit.org/show_bug.cgi?id=164568
1599         http://trac.webkit.org/changeset/209136
1600
1601 2016-12-02  Chris Dumez  <cdumez@apple.com>
1602
1603         [Mac][WK1] Implement new HTML interactive form validation user interface
1604         https://bugs.webkit.org/show_bug.cgi?id=164483
1605
1606         Reviewed by Simon Fraser.
1607
1608         Add support for UIScriptController's contentsOfUserInterfaceItem("validationBubble")
1609         on Mac DRT as this is needed by the HTML form validation layout tests.
1610
1611         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1612         (WTR::UIScriptController::contentsOfUserInterfaceItem):
1613
1614 2016-12-02  Brady Eidson  <beidson@apple.com>
1615
1616         IndexedDB.IndexedDBMultiProcess and IndexedDB.WebProcessKillIDBCleanup sometimes timeout.
1617         https://bugs.webkit.org/show_bug.cgi?id=160780 and https://bugs.webkit.org/show_bug.cgi?id=161001
1618
1619         Reviewed by Alexey Proskuryakov.
1620
1621         These tests had "run-loop races."
1622         
1623         The test spins the runloop waiting for one message.
1624         Two messages might come in from the WebProcess in short succession, and both be delivered to the
1625         UIProcess in the same spin of the runloop.
1626
1627         Therefore by the time the test stops spinning the runloop, notified that a message was received,
1628         the first message has been overwritten by the second.
1629
1630         These tests are fixed by queueing the incoming messages instead of just storing one.
1631
1632         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
1633         (-[IndexedDBMPMessageHandler userContentController:didReceiveScriptMessage:]):
1634         (getNextMessage):
1635         (TEST):
1636
1637         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
1638         (-[IndexedDBWebProcessKillMessageHandler userContentController:didReceiveScriptMessage:]):
1639         (getNextMessage):
1640         (TEST):
1641
1642 2016-12-01  Jiewen Tan  <jiewen_tan@apple.com>
1643
1644         Add a runtime flag for SubtleCrypto
1645         https://bugs.webkit.org/show_bug.cgi?id=164982
1646
1647         Reviewed by Brent Fulgham.
1648
1649         * DumpRenderTree/mac/DumpRenderTree.mm:
1650         (resetWebPreferencesToConsistentValues):
1651         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1652         (WTR::InjectedBundle::beginTesting):
1653         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1654         (WTR::TestRunner::setSubtleCryptoEnabled):
1655         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1656
1657 2016-12-01  Alexey Proskuryakov  <ap@apple.com>
1658
1659         Remove webkitpy dependency on Eliza
1660         https://bugs.webkit.org/show_bug.cgi?id=164979
1661
1662         Reviewed by Daniel Bates.
1663
1664         This module is not on pypi, so installing it is a challenge. The jokes feel pretty old too!
1665
1666         * Scripts/webkitpy/thirdparty/__init__.py:
1667         * Scripts/webkitpy/thirdparty/__init___unittest.py: Changed mock import hook to
1668         test buildbot instead of eliza.
1669         * Scripts/webkitpy/tool/bot/ircbot.py:
1670         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
1671
1672 2016-12-01  Beth Dakin  <bdakin@apple.com>
1673
1674         Force clicking tests fail on some machines
1675         https://bugs.webkit.org/show_bug.cgi?id=165263
1676
1677         Reviewed by Tim Horton.
1678
1679         Initialize com.apple.trackpad.forceClick to 1 so that we don’t have to depend on 
1680         the user account having this feature enabled. 
1681         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1682         (WTR::InjectedBundle::platformInitialize):
1683         * WebKitTestRunner/mac/main.mm:
1684         (setDefaultsToConsistentValuesForTesting):
1685
1686 2016-12-01  Yusuke Suzuki  <utatane.tea@gmail.com>
1687
1688         Introduce StringImpl::StaticStringImpl with constexpr constructor
1689         https://bugs.webkit.org/show_bug.cgi?id=165093
1690
1691         Reviewed by Darin Adler.
1692
1693         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1694         (TestWebKitAPI::TEST):
1695
1696 2016-11-30  Antoine Quint  <graouts@apple.com>
1697
1698         [Modern Media Controls] Add an HTML comment flag to turn the feature on
1699         https://bugs.webkit.org/show_bug.cgi?id=165226
1700
1701         Reviewed by Dean Jackson.
1702
1703         Add a new flag to turn Modern Media Controls on in the test runners.
1704
1705         * DumpRenderTree/TestOptions.h:
1706         * DumpRenderTree/TestOptions.mm:
1707         (TestOptions::TestOptions):
1708         * DumpRenderTree/mac/DumpRenderTree.mm:
1709         (resetWebPreferencesToConsistentValues):
1710         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1711         (WTR::InjectedBundle::beginTesting):
1712         * WebKitTestRunner/TestController.cpp:
1713         (WTR::TestController::resetPreferencesToConsistentValues):
1714         (WTR::updateTestOptionsFromTestHeader):
1715         * WebKitTestRunner/TestOptions.h:
1716         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1717         (WTR::PlatformWebView::viewSupportsOptions):
1718         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1719         (WTR::PlatformWebView::viewSupportsOptions):
1720
1721 2016-11-30  Said Abou-Hallawa  <sabouhallawa@apple.com>
1722
1723         Add separate settings and preferences to enable/disable async decoding for large images and animated images
1724         https://bugs.webkit.org/show_bug.cgi?id=165177
1725
1726         Reviewed by Simon Fraser.
1727         
1728         Pref and a menu item to toggle async image decoding settings for WebKits 1 and 2.
1729
1730         * MiniBrowser/mac/SettingsController.h:
1731         * MiniBrowser/mac/SettingsController.m:
1732         (-[SettingsController _populateMenu]):
1733         (-[SettingsController validateMenuItem:]):
1734         (-[SettingsController toggleLargeImageAsyncDecodingEnabled:]):
1735         (-[SettingsController largeImageAsyncDecodingEnabled]):
1736         (-[SettingsController toggleAnimatedImageAsyncDecodingEnabled:]):
1737         (-[SettingsController animatedImageAsyncDecodingEnabled]):
1738         (-[SettingsController toggleAsyncImageDecodingEnabled:]): Deleted.
1739         (-[SettingsController asyncImageDecodingEnabled]): Deleted.
1740         * MiniBrowser/mac/WK1BrowserWindowController.m:
1741         (-[WK1BrowserWindowController didChangeSettings]):
1742         * MiniBrowser/mac/WK2BrowserWindowController.m:
1743         (-[WK2BrowserWindowController didChangeSettings]):
1744
1745 2016-11-30  Jonathan Bedard  <jbedard@apple.com>
1746
1747         Make it possible to use an existing simulator instance for one-off testing
1748         https://bugs.webkit.org/show_bug.cgi?id=164568
1749         <rdar://problem/29189133>
1750
1751         Reviewed by Daniel Bates.
1752
1753         With this patch, if a simulator is currently running on the machine and
1754         '--dedicated-simulators' is not passed into the application, only one simulator
1755         instance will be used, and this instance will be the existing instance.
1756         If no simulator is running or '--dedicated-simulators' is passed to the script,
1757         previous behavior will be used.
1758
1759         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1760         (parse_args):
1761         * Scripts/webkitpy/port/ios.py:
1762         (IOSSimulatorPort.__init__): Logic for enabling usage of currently running simulator.
1763         (IOSSimulatorPort._create_simulators): Only create simulators when needed, don't reset already running simulators.
1764         (IOSSimulatorPort.setup_test_run): Don't open already running simulators.
1765         (IOSSimulatorPort._quit_ios_simulator): Only quit simulators if we manage them.
1766         (IOSSimulatorPort.clean_up_test_run): Only clean up simulators if we manage them. 
1767         (IOSSimulatorPort._using_dedicated_simulators): True if simulators need to be managed, false if using an existing instance.
1768         (IOSSimulatorPort.device_id_for_worker_number): Access currently running simulator if not managing devices.
1769         * Scripts/webkitpy/xcode/simulator.py:
1770         (Simulator.current_device): Get currently running device.
1771
1772 2016-11-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1773
1774         [Linux] run-benchmark should be able to execute the benchmarks with more browsers.
1775         https://bugs.webkit.org/show_bug.cgi?id=164792
1776
1777         Reviewed by Michael Catanzaro.
1778
1779         This removes the GTKBrowserDriver (and the platform 'gtk') from the run-benchmark script,
1780         and adds a new LinuxBrowserDriver with a platform 'linux'.
1781
1782         It add also drivers for Chrome (Chromium), Firefox, Epiphany and MiniBrowser-GTK (previously MiniBrowser).
1783
1784         The detection of the platform is now done automatically, so it is not longer needed to pass a "--platform" parameter.
1785
1786         The tracking of the browser process is now more robust, we track the pid of the browser process and we only try to
1787         kill the ones that were executed by this script, instead of doing a 'killall $browser' (like before).
1788         We also check for browser process childs and we kill them if they are still alive after the main browser process has been killed.
1789         This depends on psutil, so this will only be done if psutil is installed.
1790
1791         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1792         (RunBenchmarkTests.start): The platform is now autodetected and the MiniBrowser driver is renamed to MiniBrowser-GTK.
1793         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1794         (BenchmarkRunner._run_benchmark): Fix a bug that caused close_browsers to be called twice. Its already called inside BenchmarkRunner._run_one_test.
1795         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py: Added.
1796         (LinuxBrowserDriver): Implement base class that has all the needed functionality for driving the browsers.
1797         (LinuxBrowserDriver.__init__):
1798         (LinuxBrowserDriver.prepare_env):
1799         (LinuxBrowserDriver.restore_env):
1800         (LinuxBrowserDriver.close_browsers): Made the dependency on psutil optional (because it was listed as such on the README file <Tools/Scripts/webkitpy/benchmark_runner/README.md>)
1801         (LinuxBrowserDriver.launch_url):
1802         (LinuxBrowserDriver._get_first_executable_path_from_list):
1803         (LinuxBrowserDriver._screen_size):
1804         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py: Copied from Tools/Scripts/webkitpy/benchmark_runner/browser_driver/gtk_minibrowser_driver.py.
1805         (LinuxChromeDriver):
1806         (LinuxChromeDriver.launch_url):
1807         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_epiphany_driver.py: Renamed from Tools/Scripts/webkitpy/benchmark_runner/browser_driver/gtk_browser_driver.py.
1808         (EpiphanyBrowserDriver):
1809         (EpiphanyBrowserDriver.launch_url):
1810         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py: Copied from Tools/Scripts/webkitpy/benchmark_runner/browser_driver/gtk_minibrowser_driver.py.
1811         (LinuxFirefoxDriver):
1812         (LinuxFirefoxDriver.launch_url):
1813         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_minibrowsergtk_driver.py: Renamed from Tools/Scripts/webkitpy/benchmark_runner/browser_driver/gtk_minibrowser_driver.py.
1814         (GTKMiniBrowserDriver):
1815         (GTKMiniBrowserDriver.launch_url):
1816         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
1817         (SimpleHTTPServerDriver):
1818         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
1819         (getplatform):
1820         (getdefaultbrowser):
1821         (parse_args):
1822         * Scripts/webkitpy/benchmark_runner/utils.py:
1823         (load_subclasses): The loading of subclasses was still (even after r196979) sensitive to the order in which the modules are loaded.
1824         We have to ensure that the files containing subclasses of the base_class_file are loaded after the base_class_file,
1825         we can do that by matching against the base_class_file pattern when the list is created.
1826
1827 2016-11-29  Andy Estes  <aestes@apple.com>
1828
1829         [Cocoa] Enable two clang warnings recommended by Xcode
1830         https://bugs.webkit.org/show_bug.cgi?id=164498
1831
1832         Reviewed by Mark Lam.
1833
1834         * DumpRenderTree/mac/Configurations/Base.xcconfig: Enabled CLANG_WARN_INFINITE_RECURSION and CLANG_WARN_SUSPICIOUS_MOVE.
1835         * MiniBrowser/Configurations/Base.xcconfig: Ditto.
1836         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
1837         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
1838
1839 2016-11-29  Eric Carlson  <eric.carlson@apple.com>
1840
1841         [MediaStream] Don't request user permission for a device if it has already been granted in the current browsing context
1842         https://bugs.webkit.org/show_bug.cgi?id=164760
1843         <rdar://problem/29261266>
1844
1845         Reviewed by Youenn Fablet.
1846         
1847         Allow scripts to determine the number of times the user has been prompted for capture device access.
1848
1849         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1850         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1851         (WTR::InjectedBundle::setUserMediaPersistentPermissionForOrigin):
1852         (WTR::InjectedBundle::userMediaPermissionRequestCountForOrigin):
1853         (WTR::InjectedBundle::resetUserMediaPermissionRequestCountForOrigin):
1854         (WTR::InjectedBundle::setUserMediaPermissionForOrigin): Deleted.
1855         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1856         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1857         (WTR::TestRunner::setUserMediaPersistentPermissionForOrigin):
1858         (WTR::TestRunner::userMediaPermissionRequestCountForOrigin):
1859         (WTR::TestRunner::resetUserMediaPermissionRequestCountForOrigin):
1860         (WTR::TestRunner::setUserMediaPermissionForOrigin): Deleted.
1861         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1862         * WebKitTestRunner/TestController.cpp:
1863         (WTR::TestController::resetStateToConsistentValues):
1864         (WTR::OriginSettings::incrementRequestCount):
1865         (WTR::OriginSettings::resetRequestCount):
1866         (WTR::OriginSettings::requestCount):
1867         (WTR::TestController::saltForOrigin):
1868         (WTR::TestController::setUserMediaPersistentPermissionForOrigin):
1869         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin):
1870         (WTR::TestController::settingsForOrigin):
1871         (WTR::TestController::userMediaPermissionRequestCountForOrigin):
1872         (WTR::TestController::resetUserMediaPermissionRequestCountForOrigin):
1873         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible):
1874         (WTR::TestController::setUserMediaPermissionForOrigin): Deleted.
1875         * WebKitTestRunner/TestController.h:
1876         * WebKitTestRunner/TestInvocation.cpp:
1877         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1878         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1879
1880 2016-11-29  Simon Fraser  <simon.fraser@apple.com>
1881
1882         intersection-observer-entry-interface.html test fails on the bots
1883         https://bugs.webkit.org/show_bug.cgi?id=165133
1884
1885         Reviewed by Darin Adler.
1886         
1887         Tests that enabled Intersection Observer via <!-- webkit-test-runner [ enableIntersectionObserver=true ] -->
1888         would fail sometimes, because TestController::ensureViewSupportsOptionsForTest() failed to check
1889         to see if this option required creating a new web view, so would just use the old view without
1890         even resetting preferences.
1891         
1892         In general, TestController doesn't distinguish properly between options that require the creation
1893         of a new view (like mock scrollbars), and those that can be simply reset as resetPreferencesToConsistentValues()
1894         does.
1895         
1896         Do the easy fix of having viewSupportsOptions() check options.enableIntersectionObserver. We should probably
1897         just call resetPreferencesToConsistentValues() even when re-use the same view.
1898         
1899         * WebKitTestRunner/TestController.cpp:
1900         (WTR::TestController::resetPreferencesToConsistentValues):
1901         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1902         (WTR::PlatformWebView::viewSupportsOptions):
1903         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1904         (WTR::PlatformWebView::viewSupportsOptions):
1905
1906 2016-11-28  Ryan Haddad  <ryanhaddad@apple.com>
1907
1908         Unreviewed, rolling out r209008.
1909
1910         This change appears to have caused two fast/mediastrem
1911         LayoutTests to fail.
1912
1913         Reverted changeset:
1914
1915         "[MediaStream] Don't request user permission for a device if
1916         it has already been granted in the current browsing context"
1917         https://bugs.webkit.org/show_bug.cgi?id=164760
1918         http://trac.webkit.org/changeset/209008
1919
1920 2016-11-28  Daniel Bates  <dabates@apple.com>
1921
1922         Teach webkitpy how to read CSSProperties.json r209001
1923         https://bugs.webkit.org/show_bug.cgi?id=165108
1924
1925         Reviewed by Simon Fraser.
1926
1927         Fix webkitpy logic so that it can read CSS property names from CSSProperties.json following r209001.
1928
1929         Following r209001 CSSPropertyNames.in no longer exists as it was replaced with CSSProperties.json.
1930         We need to modify the webkitpy machinery that processed CSSPropertyNames.in to process CSSProperties.json.
1931
1932         * Scripts/webkitpy/w3c/test_converter.py:
1933         (_W3CTestConverter.__init__): Make self._css_property_file and self._css_property_value_file local
1934         variables as it is unnecessary for them to be instance variables. Call read_webkit_prefixed_css_property_list()
1935         to read the property names from file CSSProperties.json. Call legacy_read_webkit_prefixed_css_property_list() to
1936         read CSS keyword values from CSSValueKeywords.in.
1937         (_W3CTestConverter.read_webkit_prefixed_css_property_list): Added.
1938         (_W3CTestConverter):
1939         (_W3CTestConverter.legacy_read_webkit_prefixed_css_property_list): Renamed from read_webkit_prefixed_css_property_list.
1940         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1941         (TestImporterTest.test_harnesslinks_conversion): Substitute CSSProperties.json for CSSPropertyNames.in.
1942
1943 2016-11-28  Eric Carlson  <eric.carlson@apple.com>
1944
1945         [MediaStream] Don't request user permission for a device if it has already been granted in the current browsing context
1946         https://bugs.webkit.org/show_bug.cgi?id=164760
1947         <rdar://problem/29261266>
1948
1949         Reviewed by Youenn Fablet.
1950         
1951         Allow scripts to determine the number of times the user has been prompted for capture device access.
1952
1953         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1954         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1955         (WTR::InjectedBundle::setUserMediaPersistentPermissionForOrigin):
1956         (WTR::InjectedBundle::userMediaPermissionRequestCountForOrigin):
1957         (WTR::InjectedBundle::resetUserMediaPermissionRequestCountForOrigin):
1958         (WTR::InjectedBundle::setUserMediaPermissionForOrigin): Deleted.
1959         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1960         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1961         (WTR::TestRunner::setUserMediaPersistentPermissionForOrigin):
1962         (WTR::TestRunner::userMediaPermissionRequestCountForOrigin):
1963         (WTR::TestRunner::resetUserMediaPermissionRequestCountForOrigin):
1964         (WTR::TestRunner::setUserMediaPermissionForOrigin): Deleted.
1965         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1966         * WebKitTestRunner/TestController.cpp:
1967         (WTR::TestController::resetStateToConsistentValues):
1968         (WTR::OriginSettings::incrementRequestCount):
1969         (WTR::OriginSettings::resetRequestCount):
1970         (WTR::OriginSettings::requestCount):
1971         (WTR::TestController::saltForOrigin):
1972         (WTR::TestController::setUserMediaPersistentPermissionForOrigin):
1973         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin):
1974         (WTR::TestController::settingsForOrigin):
1975         (WTR::TestController::userMediaPermissionRequestCountForOrigin):
1976         (WTR::TestController::resetUserMediaPermissionRequestCountForOrigin):
1977         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible):
1978         (WTR::TestController::setUserMediaPermissionForOrigin): Deleted.
1979         * WebKitTestRunner/TestController.h:
1980         * WebKitTestRunner/TestInvocation.cpp:
1981         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1982         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1983
1984 2016-11-18  Jer Noble  <jer.noble@apple.com>
1985
1986         Add some performance tests for various aspects of media loading and playback.
1987         https://bugs.webkit.org/show_bug.cgi?id=164977
1988
1989         Reviewed by Darin Adler.
1990
1991         Allow callers to pass in extra alias/directory pairs to run-webkit-httpd.
1992
1993         * Scripts/run-webkit-httpd:
1994         (parse_args):
1995         (main):
1996
1997 2016-11-27  Simon Fraser  <simon.fraser@apple.com>
1998
1999         Another fix for CMake.
2000
2001         * DumpRenderTree/TestOptions.h:
2002         * DumpRenderTree/TestOptions.mm:
2003
2004 2016-11-26  Simon Fraser  <simon.fraser@apple.com>
2005
2006         Better fix for the Mac CMake build.
2007
2008         * DumpRenderTree/PlatformMac.cmake:
2009
2010 2016-11-26  Simon Fraser  <simon.fraser@apple.com>
2011
2012         Attempt to fix Mac CMake build.
2013
2014         * DumpRenderTree/PlatformMac.cmake:
2015
2016 2016-11-26  Yusuke Suzuki  <utatane.tea@gmail.com>
2017
2018         [WTF] Import std::optional reference implementation as WTF::Optional
2019         https://bugs.webkit.org/show_bug.cgi?id=164199
2020
2021         Reviewed by Saam Barati and Sam Weinig.
2022
2023         Use WTF::Optional::value_or.
2024
2025         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2026         (WTR::UIScriptController::stableStateOverride):
2027         (WTR::UIScriptController::setStableStateOverride):
2028         * TestRunnerShared/Bindings/JSWrappable.h:
2029         (WTR::JSValueMakeBooleanOrNull):
2030         (WTR::JSValueToNullableBoolean):
2031         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2032         (WTR::UIScriptController::stableStateOverride):
2033         (WTR::UIScriptController::setStableStateOverride):
2034         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2035         * TestWebKitAPI/Tests/WTF/Optional.cpp:
2036         (TestWebKitAPI::TEST):
2037         * TestWebKitAPI/Tests/WebCore/HTMLParserIdioms.cpp:
2038         (TestWebKitAPI::testParseHTMLInteger):
2039         (TestWebKitAPI::testParseHTMLNonNegativeInteger):
2040         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2041         (TestWebKitAPI::checkURL):
2042         (TestWebKitAPI::checkRelativeURL):
2043         (TestWebKitAPI::checkURLDifferences):
2044         (TestWebKitAPI::checkRelativeURLDifferences):
2045         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2046         (WTR::UIScriptController::stableStateOverride):
2047         (WTR::UIScriptController::setStableStateOverride):
2048
2049 2016-11-26  Sam Weinig  <sam@webkit.org>
2050
2051         Convert IntersectionObserver over to using RuntimeEnabledFeatures so it can be properly excluded from script
2052         https://bugs.webkit.org/show_bug.cgi?id=164965
2053
2054         Reviewed by Simon Fraser.
2055
2056         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2057         Add new files.
2058
2059         * DumpRenderTree/TestOptions.h: Added.
2060         * DumpRenderTree/TestOptions.mm: Added.
2061         (parseBooleanTestHeaderValue):
2062         (TestOptions::TestOptions):
2063         Port TestOption parsing from WKTR to DRT.
2064
2065         * DumpRenderTree/mac/DumpRenderTree.mm:
2066         (resetWebPreferencesToConsistentValues):
2067         (resetWebViewToConsistentStateBeforeTesting):
2068         (runTest):
2069         * WebKitTestRunner/TestController.cpp:
2070         Pass TestOptions down to resetWebPreferencesToConsistentValues to allow setting
2071         preferences conditionally.
2072
2073         (WTR::TestController::resetPreferencesToConsistentValues):
2074         (WTR::updateTestOptionsFromTestHeader):
2075         * WebKitTestRunner/TestOptions.h:
2076         Add a new test option header, enableIntersectionObserver, to enable IntersectionObserver.
2077
2078 2016-11-26  Simon Fraser  <simon.fraser@apple.com>
2079
2080         Migrate some layout timer-related code from std::chrono to Seconds and MonotonicTime
2081         https://bugs.webkit.org/show_bug.cgi?id=164992
2082
2083         Reviewed by Darin Adler.
2084         
2085         Use Seconds::zero().
2086
2087         * TestWebKitAPI/Tests/WTF/Condition.cpp:
2088
2089 2016-11-26  Simon Fraser  <simon.fraser@apple.com>
2090
2091         Add literals for various time units
2092         https://bugs.webkit.org/show_bug.cgi?id=165074
2093
2094         Reviewed by Filip Pizlo.
2095         
2096         Add tests for new time literals. Add new tests for units.
2097
2098         * TestWebKitAPI/Tests/WTF/Time.cpp:
2099         (TestWebKitAPI::TEST):
2100
2101 2016-11-25  Csaba Osztrogonác  <ossy@webkit.org>
2102
2103         Fix compile warnings after r208415
2104         https://bugs.webkit.org/show_bug.cgi?id=165061
2105
2106         Reviewed by Andy Estes.
2107
2108         * TestWebKitAPI/Tests/WTF/Time.cpp:
2109         (TestWebKitAPI::TEST):
2110
2111 2016-11-24  Michael Catanzaro  <mcatanzaro@igalia.com>
2112
2113         [GTK] Notifications API does not expose or respect the "tag" attribute
2114         https://bugs.webkit.org/show_bug.cgi?id=164771
2115
2116         Reviewed by Gustavo Noronha Silva.
2117
2118         Verify that showing a notification with the same tag as another notification closes the
2119         previous notification before the new notification is shown.
2120
2121         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2122         (testWebViewNotification):
2123
2124 2016-11-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2125
2126         Unreviewed. Fix GTK+ test /webkit2/WebKitWebContext/get-plugins after r208429.
2127
2128         Test plugin library was renamed as libTestNetscapePlugIn.so in r208429.
2129
2130         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2131         (testWebContextGetPlugins): Update the library name.
2132
2133 2016-11-22  Darin Adler  <darin@apple.com>
2134
2135         Make normal case fast in the input element limitString function
2136         https://bugs.webkit.org/show_bug.cgi?id=165023
2137
2138         Reviewed by Dan Bernstein.
2139
2140         * TestWebKitAPI/CMakeLists.txt: Added TextBreakIterator.cpp.
2141         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
2142         * TestWebKitAPI/Tests/WTF/TextBreakIterator.cpp: Added.
2143         Contains some tests for the numGraphemeClusters and
2144         numCharactersInGraphemeClusters functions that I used to make sure
2145         that the new fast paths I added work correctly.
2146
2147 2016-11-22  Tomas Popela  <tpopela@redhat.com>
2148
2149         Unreviewed, add myself as a WebKit committer.
2150
2151         * Scripts/webkitpy/common/config/contributors.json:
2152
2153 2016-11-21  Mark Lam  <mark.lam@apple.com>
2154
2155         Hasher::addCharacters() should be able to handle zero length strings.
2156         https://bugs.webkit.org/show_bug.cgi?id=165024
2157
2158         Reviewed by Yusuke Suzuki.
2159
2160         * TestWebKitAPI/Tests/WTF/StringHasher.cpp:
2161         (TestWebKitAPI::TEST):
2162
2163 2016-11-21  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2164
2165         [CMake] build fails after update to cmake 3.7
2166         https://bugs.webkit.org/show_bug.cgi?id=165008
2167
2168         Reviewed by Dan Bernstein.
2169
2170         When we remove the CMake cache, we should remove both the
2171         CMakeCache.txt file and the CMakeFiles directory.
2172         See: https://gitlab.kitware.com/cmake/cmake/issues/14820
2173
2174         * Scripts/webkitdirs.pm:
2175         (cmakeFilesPath):
2176         (removeCMakeCache):
2177
2178 2016-11-16  Philippe Normand  <pnormand@igalia.com>
2179
2180         [GTK][WebRTC] Switch to downstream OpenWebRTC and more recent GStreamer
2181         https://bugs.webkit.org/show_bug.cgi?id=164817
2182
2183         Reviewed by Alejandro G. Castro.
2184
2185         This is temporary, hopefully. The OpenWebRTC patches will/should
2186         be soon reviewed and upstream but meanwhile it makes sense to use
2187         the Igalia downstream fork so that the WebRTC testing is easier.
2188
2189         Recent GStreamer patches are also needed for RTP bundling support
2190         and RTP retransmission fixes.
2191
2192         * gtk/jhbuild.modules:
2193         * gtk/openwebrtc.modules: Removed.
2194         * gtk/patches/gst-plugins-good-0001-rtpbin-pipeline-gets-an-EOS-when-any-rtpsources-byes.patch: Added.
2195         * gtk/patches/gst-plugins-good-0002-rtpbin-avoid-generating-errors-when-rtcp-messages-ar.patch: Added.
2196         * gtk/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Added.
2197
2198 2016-11-20  Zan Dobersek  <zdobersek@igalia.com>
2199
2200         [EncryptedMedia] Make EME API runtime-enabled
2201         https://bugs.webkit.org/show_bug.cgi?id=164927
2202
2203         Reviewed by Jer Noble.
2204
2205         Enable the EME API via the WKTR InjectedBundle whenever testing
2206         commences. This does not have any effect unless the EME feature
2207         is enabled at compile-time, but it's still added to match other
2208         features and for future use.
2209
2210         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2211         (WTR::InjectedBundle::beginTesting):
2212         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2213         (WTR::TestRunner::setEncryptedMediaAPIEnabled):
2214         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2215
2216 2016-11-19  Simon Fraser  <simon.fraser@apple.com>
2217
2218         Fix the Mac and iOS bulds.
2219
2220         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2221         (-[TestRunnerWKWebView _stableStateOverride]):
2222         (-[TestRunnerWKWebView _setStableStateOverride:]):
2223
2224 2016-11-18  Simon Fraser  <simon.fraser@apple.com>
2225
2226         Make it possible to test non-stable-state scrolling on iOS
2227         https://bugs.webkit.org/show_bug.cgi?id=164905
2228
2229         Reviewed by Dan Bernstein.
2230
2231         Make it possible for an iOS layout test to force every visible rect update
2232         from the UI process to the web process to be in a non-stable state. This emulates
2233         what happens during panning and zooming interactions, and allows us to test the
2234         scrolling and layer trees in these transient states.
2235         
2236         This is done by adding a testing property on WKWebView, _stableStateOverride, whose
2237         getters and setters are overridden in TestRunnerWKWebView. When non-nil, we _updateVisibleContentRectAfterScrollInView
2238         consults the NSNumber's boolValue and uses it to override the stable state.
2239         
2240         To facilitate this kind of testing, also add immediateScrollToOffset() and
2241         immediateZoomToScale() to UIScriptController. Finally, add doAfterPresentationUpdate()
2242         which provides a callback that fires after one trip to the web process and back.
2243         
2244         Add code generation support for optional boolean attributes in IDL.
2245
2246         Align CodeGeneratorDumpRenderTree.pm and CodeGeneratorTestRunner.pm.
2247
2248         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
2249         (_generateImplementationFile):
2250         (_platformTypeConstructor):
2251         (_returnExpression):
2252         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2253         (WTR::UIScriptController::doAfterPresentationUpdate):
2254         (WTR::contentOffsetBoundedInValidRange):
2255         (WTR::UIScriptController::scrollToOffset):
2256         (WTR::UIScriptController::immediateScrollToOffset):
2257         (WTR::UIScriptController::immediateZoomToScale):
2258         (WTR::UIScriptController::stableStateOverride):
2259         (WTR::UIScriptController::setStableStateOverride):
2260         * DumpRenderTree/mac/UIScriptControllerMac.mm:
2261         (WTR::UIScriptController::doAfterPresentationUpdate):
2262         * TestRunnerShared/Bindings/JSWrappable.h:
2263         (WTR::JSValueMakeBooleanOrNull):
2264         (WTR::JSValueToNullableBoolean):
2265         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2266         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2267         (WTR::UIScriptController::immediateScrollToOffset):
2268         (WTR::UIScriptController::immediateZoomToScale):
2269         (WTR::UIScriptController::stableStateOverride):
2270         (WTR::UIScriptController::setStableStateOverride):
2271         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2272         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
2273         (_classRefGetter):
2274         (_platformTypeConstructor):
2275         (_returnExpression):
2276         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2277         (-[TestRunnerWKWebView dealloc]):
2278         (-[TestRunnerWKWebView _stableStateOverride]):
2279         (-[TestRunnerWKWebView _setStableStateOverride:]):
2280         * WebKitTestRunner/ios/TestControllerIOS.mm:
2281         (WTR::TestController::platformResetStateToConsistentValues):
2282         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2283         (WTR::UIScriptController::doAsyncTask):
2284         (WTR::UIScriptController::doAfterPresentationUpdate):
2285         (WTR::UIScriptController::zoomToScale):
2286         (WTR::UIScriptController::immediateScrollToOffset):
2287         (WTR::UIScriptController::immediateZoomToScale):
2288         (WTR::UIScriptController::stableStateOverride):
2289         (WTR::UIScriptController::setStableStateOverride):
2290         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2291         (WTR::UIScriptController::doAfterPresentationUpdate):
2292
2293 2016-11-19  Joanmarie Diggs  <jdiggs@igalia.com>
2294
2295         AX: [ATK] Expose aria-busy via ATK_STATE_BUSY
2296         https://bugs.webkit.org/show_bug.cgi?id=164909
2297
2298         Reviewed by Chris Fleizach.
2299
2300         Implement boolAttributeValue() for ATK so we can test AXElementBusy.
2301
2302         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2303         (WTR::AccessibilityUIElement::boolAttributeValue):
2304
2305 2016-11-18  Simon Fraser  <simon.fraser@apple.com>
2306
2307         [iOS WK2] Eliminate a source of flakiness in layout tests by forcing WebPage into "responsive" mode for all tests, with an internals override
2308         https://bugs.webkit.org/show_bug.cgi?id=164980
2309
2310         Reviewed by Chris Dumez.
2311
2312         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2313         (WTR::InjectedBundlePage::prepare):
2314
2315 2016-11-18  Dean Jackson  <dino@apple.com>
2316
2317         AX: "(inverted-colors)" media query only matches on page reload; should match on change
2318         https://bugs.webkit.org/show_bug.cgi?id=163564
2319         <rdar://problem/28807350>
2320
2321         Reviewed by Simon Fraser.
2322
2323         Add a UIScriptController method that tricks WebKit into thinking
2324         it has received a notification that accessibility settings have
2325         changed. Combined with our forced overrides, this allows us to
2326         test if a page would react to the notifications.
2327
2328         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2329         (WTR::UIScriptController::simulateAccessibilitySettingsChangeNotification):
2330         * DumpRenderTree/mac/UIScriptControllerMac.mm:
2331         (WTR::UIScriptController::simulateAccessibilitySettingsChangeNotification):
2332         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2333         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2334         (WTR::simulateAccessibilitySettingsChangeNotification):
2335         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2336         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2337         (WTR::UIScriptController::simulateAccessibilitySettingsChangeNotification):
2338         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2339         (WTR::UIScriptController::simulateAccessibilitySettingsChangeNotification):
2340
2341 2016-11-18  Alex Christensen  <achristensen@webkit.org>
2342
2343         Fix API test after r208902
2344         https://bugs.webkit.org/show_bug.cgi?id=144194
2345
2346         * TestWebKitAPI/Tests/Cocoa/URLExtras.mm:
2347         (TestWebKitAPI::TEST):
2348         The fullwidth solidus, U+FF0F, changed encoding from IDN2003 to IDN2008, probably to prevent domains from using it
2349         to spoof other domains.  https://webkit.org/blog/ and https://webkit.org\uFF0Fblog/ would otherwise look 
2350         too similar when rendered.
2351
2352 2016-11-17  Alex Christensen  <achristensen@webkit.org>
2353
2354         Support IDN2008 with UTS #46 instead of IDN2003
2355         https://bugs.webkit.org/show_bug.cgi?id=144194
2356
2357         Reviewed by Darin Adler.
2358
2359         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2360         (TestWebKitAPI::TEST_F):
2361         Add some tests from http://unicode.org/faq/idn.html verifying that we follow UTS46's deviations from IDN2008.
2362         Add some tests based on https://tools.ietf.org/html/rfc5893 verifying that we check for bidirectional text.
2363         Add a test based on https://tools.ietf.org/html/rfc5892 verifying that we do not do ContextO check.
2364         Add a test for U+321D and U+321E which have particularly interesting punycode encodings.  We match Firefox here now.
2365         Also add a test from http://www.unicode.org/reports/tr46/#IDNAComparison verifying we are not using IDN2003.
2366         We should consider importing all of http://www.unicode.org/Public/idna/9.0.0/IdnaTest.txt as URL domain tests.
2367
2368 2016-11-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2369
2370         Downloads started by context menu actions should also have a web view associated
2371         https://bugs.webkit.org/show_bug.cgi?id=164364
2372
2373         Reviewed by Michael Catanzaro.
2374
2375         Add a GTK+ unit tests to check that downloads started by the context menu have a web view associated.
2376
2377         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
2378         (downloadLocalFileSuccessfully):
2379         (testDownloadOverwriteDestinationDisallowed):
2380         (testDownloadLocalFileError):
2381         (testDownloadRemoteFile):
2382         (testDownloadRemoteFileError):
2383         (testDownloadMIMEType):
2384         (contextMenuCallback):
2385         (testContextMenuDownloadActions):
2386         (beforeAll):
2387
2388 2016-11-17  Ryosuke Niwa  <rniwa@webkit.org>
2389
2390         Add an experimental API to find elements across shadow boundaries
2391         https://bugs.webkit.org/show_bug.cgi?id=164851
2392         <rdar://problem/28220092>
2393
2394         Reviewed by Sam Weinig.
2395
2396         Added test cases for window.collectMatchingElementsInFlatTree to WebKit2.InjectedBundleMakeAllShadowRootOpen.
2397
2398         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2399         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRoot*s*Open_Bundle.cpp: Renamed
2400         from InjectedBundleMakeAllShadowRootOpen_Bundle.cpp.
2401         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize): Added test cases for
2402         window.collectMatchingElementsInFlatTree by calling alert() many times.
2403         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen.cpp:
2404         (TestWebKitAPI::runJavaScriptAlert): Added expectations for multiple test cases. Each test case
2405         finishes with a call to alert, and moves testNumber forward.
2406         (TestWebKitAPI::TEST): Use the newly added closed-shadow-tree-test.html
2407         * TestWebKitAPI/Tests/WebKit2/closed-shadow-tree-test.html: Added. Creates a shadow tree with slots
2408         and tests that window.collectMatchingElementsInFlatTree is not present when
2409         an event named "testnormalworld" is dispatched by the injected bundle.
2410
2411 2016-11-17  Brady Eidson  <beidson@apple.com>
2412
2413         Add _WKIconLoadingDelegate SPI.
2414         https://bugs.webkit.org/show_bug.cgi?id=164894
2415
2416         Reviewed by Alex Christensen.
2417
2418         Add MiniBrowser support for this new SPI, configurable with a setting.
2419
2420         * MiniBrowser/mac/SettingsController.h:
2421         * MiniBrowser/mac/SettingsController.m:
2422         (-[SettingsController _populateMenu]):
2423         (-[SettingsController validateMenuItem:]):
2424         (-[SettingsController loadsAllSiteIcons]):
2425         (-[SettingsController toggleLoadsAllSiteIcons:]):
2426         * MiniBrowser/mac/WK2BrowserWindowController.m:
2427         (-[WK2BrowserWindowController awakeFromNib]):
2428         (-[WK2BrowserWindowController webView:shouldLoadIconWithParameters:completionHandler:]):
2429
2430 2016-11-17  Caitlin Potter  <caitp@igalia.com>
2431
2432         [JSC] remove leftover references to ES2017_ASYNCFUNCTION_SYNTAX flag
2433         https://bugs.webkit.org/show_bug.cgi?id=164879
2434
2435         Reviewed by Alex Christensen.
2436
2437         The flag was referenced in FeatureList.pm and in one of the
2438         FeatureDefines.xcconfig files, despite being removed.
2439
2440         * Scripts/webkitperl/FeatureList.pm:
2441         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2442
2443 2016-11-17  Per Arne Vollan  <pvollan@apple.com>
2444
2445         [Win] run-api-tests is failing.
2446         https://bugs.webkit.org/show_bug.cgi?id=164818
2447
2448         Reviewed by Alexey Proskuryakov.
2449
2450         Make sure Visual Studio interprets string literal as utf8.
2451  
2452         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2453         (TestWebKitAPI::TEST_F):
2454
2455 2016-11-17  Yusuke Suzuki  <utatane.tea@gmail.com>
2456
2457         [JSC] WTF::TemporaryChange with WTF::SetForScope
2458         https://bugs.webkit.org/show_bug.cgi?id=164761
2459
2460         Reviewed by Saam Barati.
2461
2462         * TestWebKitAPI/CMakeLists.txt:
2463         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2464         * TestWebKitAPI/Tests/WTF/SetForScope.cpp: Renamed from Tools/TestWebKitAPI/Tests/WTF/TemporaryChange.cpp.
2465         (TestWebKitAPI::TEST):
2466         * WebKitTestRunner/TestController.cpp:
2467         (WTR::TestController::resetStateToConsistentValues):
2468
2469 2016-11-16  Alexey Proskuryakov  <ap@apple.com>
2470
2471         REGRESSION (r208455): LayoutTests swipe/pushState-cached-back-swipe.html and swipe/main-frame-pinning-requirement.html are failing
2472         https://bugs.webkit.org/show_bug.cgi?id=164572
2473
2474         Reviewed by Tim Horton.
2475
2476         * WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::platformResetStateToConsistentValues):
2477         Use the correct constant.
2478
2479 2016-11-16  Yusuke Suzuki  <utatane.tea@gmail.com>
2480
2481         [ES6][WebCore] Change ES6_MODULES compile time flag to runtime flag
2482         https://bugs.webkit.org/show_bug.cgi?id=164827
2483
2484         Reviewed by Ryosuke Niwa.
2485
2486         Enabled ES6 Modules in test runners.
2487
2488         * DumpRenderTree/mac/DumpRenderTree.mm:
2489         (resetWebPreferencesToConsistentValues):
2490         * DumpRenderTree/win/DumpRenderTree.cpp:
2491         (resetWebPreferencesToConsistentValues):
2492         * Scripts/webkitperl/FeatureList.pm:
2493         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2494         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2495         (WTR::InjectedBundle::beginTesting):
2496         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2497         (WTR::TestRunner::setES6ModulesEnabled):
2498         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2499
2500 2016-11-16  Simon Fraser  <simon.fraser@apple.com>
2501
2502         Hard to write reliable UIScriptController scrollingTreeAsText tests
2503         https://bugs.webkit.org/show_bug.cgi?id=164764
2504
2505         Reviewed by Wenson Hsieh.
2506
2507         Fix one cause of flakiness by resetting the WKWebView's UIScrollView scale
2508         and scroll position between tests.
2509
2510         * WebKitTestRunner/ios/TestControllerIOS.mm:
2511         (WTR::TestController::platformResetStateToConsistentValues):
2512
2513 2016-11-16  Simon Fraser  <simon.fraser@apple.com>
2514
2515         UIScriptController: script with no async tasks fails if an earlier script registered a callback
2516         https://bugs.webkit.org/show_bug.cgi?id=164762
2517
2518         Reviewed by Wenson Hsieh.
2519         
2520         Make TestRunner::callUIScriptCallback() async in DumpRenderTree to match WebKitTestRunner behavior.
2521         This fixes ui-side-script-with-callback.html in WK1, which failed because the second runUIScript()
2522         would occur inside the completion callback from the first. This no longer happens.
2523
2524         * DumpRenderTree/TestRunner.cpp:
2525         (TestRunner::callUIScriptCallback):
2526         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
2527         (UIScriptContext::tryToCompleteUIScriptForCurrentParentCallback):
2528
2529 2016-11-16  Ryan Haddad  <ryanhaddad@apple.com>
2530
2531         Unreviewed, rolling out r208770.
2532
2533         The test added with this change is timing out on mac-wk1.
2534
2535         Reverted changeset:
2536
2537         "UIScriptController: script with no async tasks fails if an
2538         earlier script registered a callback"
2539         https://bugs.webkit.org/show_bug.cgi?id=164762
2540         http://trac.webkit.org/changeset/208770
2541
2542 2016-11-16  Per Arne Vollan  <pvollan@apple.com>
2543
2544         [Win] WebCore test is failing.
2545         https://bugs.webkit.org/show_bug.cgi?id=164772
2546
2547         Reviewed by Brent Fulgham.
2548
2549         The value of CGRectInfinite is not the same on Windows as on Mac.
2550
2551         * TestWebKitAPI/Tests/WebCore/FloatRect.cpp:
2552         (TestWebKitAPI::TEST):
2553
2554 2016-11-15  Alexey Proskuryakov  <ap@apple.com>
2555
2556         Update Youenn's e-mail addresses.
2557
2558         * Scripts/webkitpy/common/config/contributors.json:
2559
2560 2016-11-15  Simon Fraser  <simon.fraser@apple.com>
2561
2562         UIScriptController: script with no async tasks fails if an earlier script registered a callback
2563         https://bugs.webkit.org/show_bug.cgi?id=164762
2564
2565         Reviewed by Wenson Hsieh.
2566         
2567         UIScriptContext::runUIScript() considers a script to be "immediate" if that script doesn't
2568         queue any async tasks. However, if an earlier UI script registered a callback, UIScriptContext::runUIScript()
2569         would consider that an outstanding task.
2570         
2571         Fix by unregistering any callbacks associated with the current UI script when uiScriptComplete() is called.
2572
2573         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
2574         (UIScriptContext::tryToCompleteUIScriptForCurrentParentCallback):
2575
2576 2016-11-15  Simon Fraser  <simon.fraser@apple.com>
2577
2578         UIScriptController: setting a callback to undefined should unregister it
2579         https://bugs.webkit.org/show_bug.cgi?id=164796
2580
2581         Reviewed by Dean Jackson.
2582         
2583         "Immediate" UI scripts (those that don't schedule any async tasks) should return
2584         immediately, without the need to call uiScriptComplete(). However, this is broken if
2585         an earlier UI script registered a callback (since no-one clears that callback after the
2586         first script completes).
2587
2588         Make possible the workaround of setting the callback to undefined, which previously did
2589         not clear the callback registration.
2590
2591         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
2592         (UIScriptContext::registerCallback):
2593         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
2594         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2595         (WTR::UIScriptController::platformClearAllCallbacks):
2596
2597 2016-11-14  Mark Lam  <mark.lam@apple.com>
2598
2599         Enhance run-jsc-stress-test script to allow optional test specific options to be added for all test run configurations.
2600         https://bugs.webkit.org/show_bug.cgi?id=164695
2601
2602         Reviewed by Keith Miller.
2603
2604         This gives us more flexibility when specific tests needs to enable special JSC
2605         options in order to exercise specific code paths to be tested.  It also saves us
2606         from having to create duplicate test run configurations e.g. runMiscFTLNoCJITTest.
2607         We can now just use runFTLNoCJIT in its place.
2608
2609         Also replaced the ifJSCArgIsntProvidedAreWeReleaseBuild variable with $buildType
2610         so that we have the ability to skip certain tests for release or debug builds.
2611         This will be needed in the upcoming patch for https://webkit.org/b/155145.
2612
2613         * Scripts/run-jsc-stress-tests:
2614
2615 2016-11-14  Joanmarie Diggs  <jdiggs@igalia.com>
2616
2617         AX: [ATK] Expose STATE_SINGLE_LINE and STATE_MULTI_LINE for ARIA searchbox role
2618         https://bugs.webkit.org/show_bug.cgi?id=164712
2619
2620         Reviewed by Chris Fleizach.
2621
2622         Add AccessibilityUIElement::isSingleLine, AccessibilityUIElement::isMultiLine
2623         to DRT and WKTR. Implement it for ATK.
2624
2625         * DumpRenderTree/AccessibilityUIElement.h:
2626         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2627         (AccessibilityUIElement::isSingleLine):
2628         (AccessibilityUIElement::isMultiLine):
2629         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2630         (AccessibilityUIElement::isSingleLine):
2631         (AccessibilityUIElement::isMultiLine):
2632         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2633         (AccessibilityUIElement::isSingleLine):
2634         (AccessibilityUIElement::isMultiLine):
2635         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2636         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2637         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2638         (WTR::AccessibilityUIElement::isSingleLine):
2639         (WTR::AccessibilityUIElement::isMultiLine):
2640         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2641         (WTR::AccessibilityUIElement::isSingleLine):
2642         (WTR::AccessibilityUIElement::isMultiLine):
2643         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2644         (WTR::AccessibilityUIElement::isSingleLine):
2645         (WTR::AccessibilityUIElement::isMultiLine):
2646
2647 2016-11-14  Youenn Fablet  <youenn@apple.com>
2648
2649         Support WPT templated tests
2650         https://bugs.webkit.org/show_bug.cgi?id=164707
2651
2652         Reviewed by Sam Weinig.
2653
2654         * Scripts/webkitpy/w3c/test_importer.py:
2655         (TestImporter.write_html_files_for_templated_js_tests): Generating empty HTML files for templated JS tests.
2656         (TestImporter.import_tests):
2657
2658 2016-11-13  JF Bastien  <jfbastien@apple.com>
2659
2660         Implement WTF::Expected
2661         https://bugs.webkit.org/show_bug.cgi?id=164526
2662
2663         Reviewed by Yusuke Suzuki.
2664
2665         std::expected isn't in C++17, and may be in C++20. It's a nice
2666         complement to std::any / std::optional because it's a type-tagged
2667         union which has a single expected result but could also contain an
2668         error.
2669
2670         This would be useful in the WebAssembly parser, for example.
2671
2672         Using this implementation will allow us to provide feedback to the
2673         standards committee and guide std::expected's design before it
2674         gets standardized. I've already sent a bunch of feedback to the
2675         author based on my experience implementing this.
2676
2677         This could supplement WTF::Either and WTF::ExceptionOr.
2678
2679         * TestWebKitAPI/CMakeLists.txt:
2680         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2681         * TestWebKitAPI/Tests/WTF/Expected.cpp: Added.
2682         (WTF::operator<<):
2683         (TestWebKitAPI::TEST):
2684         (TestWebKitAPI::foo::foo):
2685         (TestWebKitAPI::foo::~foo):
2686         (TestWebKitAPI::foo::operator==):
2687         (TestWebKitAPI::operator<<):
2688
2689 2016-11-12  Simon Fraser  <simon.fraser@apple.com>
2690
2691         Add a way to get the UI-side scrolling tree as text via UIScriptController
2692         https://bugs.webkit.org/show_bug.cgi?id=164697
2693
2694         Reviewed by Zalan Bujtas.
2695
2696         Add UIScriptController::scrollingTreeAsText(), which gets the state of the scrolling
2697         tree in the UI process, including the current positions of CALayers. This will be used
2698         to test UI-side scrolling and visual viewports.
2699
2700         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2701         (WTR::UIScriptController::scrollingTreeAsText):
2702         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2703         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2704         (WTR::UIScriptController::scrollingTreeAsText):
2705         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2706         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2707         (WTR::UIScriptController::scrollingTreeAsText):
2708
2709 2016-11-12  Wenson Hsieh  <wenson_hsieh@apple.com>
2710
2711         The main content heuristic should be robust when handling large media elements
2712         https://bugs.webkit.org/show_bug.cgi?id=164676
2713         <rdar://problem/29211503>
2714
2715         Reviewed by Eric Carlson.
2716
2717         Added a new test verifying that enormous video elements are handled gracefully when put through the main
2718         content heuristic.
2719
2720         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2721         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2722         (TestWebKitAPI::TEST):
2723         * TestWebKitAPI/Tests/WebKit2Cocoa/enormous-video-with-sound.html: Added.
2724
2725 2016-11-12  Dan Bernstein  <mitz@apple.com>
2726
2727         run-safari does not work for open source contributors
2728         https://bugs.webkit.org/show_bug.cgi?id=164667
2729         <rdar://problem/29229894>
2730
2731         Reviewed by Joseph Pecoraro.
2732
2733         * Scripts/run-api-tests:
2734         (archCommandLineArgumentsForRestrictedEnvironmentVariables): Moved from here…
2735         * Scripts/webkitdirs.pm:
2736         (archCommandLineArgumentsForRestrictedEnvironmentVariables): …to here
2737         (runMacWebKitApp): Have arch(1) carry the DYLD_* variables we set in our environmet over
2738           to the environment of the app being run.
2739
2740 2016-11-11  Joseph Pecoraro  <pecoraro@apple.com>
2741
2742         Removed unused INCLUDE_OPTIONS_FOR_DEBUGGING
2743         https://bugs.webkit.org/show_bug.cgi?id=164664
2744
2745         Reviewed by Dan Bernstein.
2746
2747         * Scripts/debug-minibrowser:
2748         * Scripts/debug-safari:
2749         * Scripts/debug-test-runner:
2750         * Scripts/webkitdirs.pm:
2751         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded):
2752         There are no debug specific options anymore.
2753
2754 2016-11-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2755
2756         [WK2] autocorrect and autocapitalize attributes do not work in contenteditable elements
2757         https://bugs.webkit.org/show_bug.cgi?id=164538
2758         <rdar://problem/8418711>
2759
2760         Reviewed by Ryosuke Niwa.
2761
2762         Adds support for being able to test autocorrect and autocapitalize attributes in contenteditable areas. To do
2763         this, we add removeAllDynamicDictionaries to UIScriptController in order to ensure that autocorrect suggestions
2764         are reset to their defaults prior to running contenteditable-autocorrect-off.html.
2765
2766         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2767         (WTR::UIScriptController::removeAllDynamicDictionaries):
2768         * Scripts/webkitpy/port/ios.py:
2769         (IOSSimulatorPort._createSimulatorApp):
2770         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2771         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2772         (WTR::UIScriptController::removeAllDynamicDictionaries):
2773         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2774         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2775         (-[TestRunnerWKWebView _keyboardDidShow:]):
2776         (-[TestRunnerWKWebView _keyboardDidHide:]):
2777
2778         Work around an issue where consecutive UIKeyboardDidShowNotification would cause keyboard appearance callbacks
2779         to be fired multiple times. This was causing a single key press to cause two characters to be typed. While this
2780         does not affect the correctness of existing tests, the new autocorrection test requires this workaround.
2781
2782         * WebKitTestRunner/ios/UIKitSPI.h:
2783         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2784         (WTR::UIScriptController::waitForTextPredictionsViewAndSelectCandidateAtIndex):
2785         (WTR::UIScriptController::removeAllDynamicDictionaries):
2786
2787 2016-11-11  Alex Christensen  <achristensen@webkit.org>
2788
2789         Build all Mac API tests
2790         https://bugs.webkit.org/show_bug.cgi?id=164633
2791
2792         Reviewed by Gyuyoung Kim.
2793
2794         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2795         * TestWebKitAPI/Tests/mac/NavigatorLanguage.mm:
2796
2797 2016-11-11  Alex Christensen  <achristensen@webkit.org>
2798
2799         Allow mutable lambdas in HashMap::ensure
2800         https://bugs.webkit.org/show_bug.cgi?id=164642
2801
2802         Reviewed by Sam Weinig.
2803
2804         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
2805         (TestWebKitAPI::TEST):
2806
2807 2016-11-10  Wenson Hsieh  <wenson_hsieh@apple.com>
2808
2809         Composition state should be cleared when changing focus to a non-editable element
2810         https://bugs.webkit.org/show_bug.cgi?id=164595
2811         <rdar://problem/26412551>
2812
2813         Reviewed by Enrica Casucci.
2814
2815         Adds support for window.textInputController in DumpRenderTree on iOS. So far, only the methods needed for the
2816         new layout test (editing/focus-change-with-marked-text.html) are supported. These are insertText, setMarkedText,
2817         and markedRange.
2818
2819         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2820         * DumpRenderTree/TextInputController.h: Renamed from Tools/DumpRenderTree/mac/TextInputController.h.
2821
2822         Remove the PLATFORM(MAC) guard for defining the TextInputController. Also, move the TextInputController header
2823         out of the /mac platform directory.
2824
2825         * DumpRenderTree/ios/TextInputControllerIOS.m: Added.
2826         (+[TextInputController isSelectorExcludedFromWebScript:]):
2827         (+[TextInputController webScriptNameForSelector:]):
2828         (-[TextInputController initWithWebView:]):
2829         (-[TextInputController markedRange]):
2830         (-[TextInputController insertText:]):
2831         (-[TextInputController setMarkedText:selectedFrom:length:]):
2832
2833         Introduces TextInputControllerIOS.m, which contains an iOS implementation of TextInputController. Only a subset
2834         of the methods available on the Mac version will be available on iOS for now (see above).
2835
2836         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2837
2838         Remove the PLATFORM(MAC) guard for initializing the TextInputController and binding it to the window object.
2839
2840         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
2841         * DumpRenderTree/mac/TextInputControllerMac.m: Renamed from Tools/DumpRenderTree/mac/TextInputController.m.
2842         (-[WebHTMLView interpretKeyEvents:]):
2843         (-[WebNSRange initWithNSRange:]):
2844         (-[WebNSRange location]):
2845         (-[WebNSRange length]):
2846         (+[WebNSRange isSelectorExcludedFromWebScript:]):
2847         (+[NSMutableAttributedString isSelectorExcludedFromWebScript:]):
2848         (+[NSMutableAttributedString webScriptNameForSelector:]):
2849         (-[NSMutableAttributedString getLength]):
2850         (-[NSMutableAttributedString ranges]):
2851         (-[NSMutableAttributedString attributeNamesAtIndex:]):
2852         (-[NSMutableAttributedString valueOfAttribute:atIndex:]):
2853         (-[NSMutableAttributedString addAttribute:value:]):
2854         (-[NSMutableAttributedString addAttribute:value:from:length:]):
2855         (-[NSMutableAttributedString addColorAttribute:red:green:blue:alpha:]):
2856         (-[NSMutableAttributedString addColorAttribute:red:green:blue:alpha:from:length:]):
2857         (-[NSMutableAttributedString addFontAttribute:fontName:size:]):
2858         (-[NSMutableAttributedString addFontAttribute:fontName:size:from:length:]):
2859         (+[TextInputController isSelectorExcludedFromWebScript:]):
2860         (+[TextInputController webScriptNameForSelector:]):
2861         (-[TextInputController initWithWebView:]):
2862         (-[TextInputController dealloc]):
2863         (-[TextInputController textInput]):
2864         (-[TextInputController insertText:]):
2865         (-[TextInputController doCommand:]):
2866         (-[TextInputController setMarkedText:selectedFrom:length:]):
2867         (-[TextInputController unmarkText]):
2868         (-[TextInputController hasMarkedText]):
2869         (-[TextInputController conversationIdentifier]):
2870         (-[TextInputController substringFrom:length:]):
2871         (-[TextInputController attributedSubstringFrom:length:]):
2872         (-[TextInputController legacyAttributedString:]):
2873         (-[TextInputController markedRange]):
2874         (-[TextInputController selectedRange]):
2875         (-[TextInputController firstRectForCharactersFrom:length:]):
2876         (-[TextInputController characterIndexForPointX:Y:]):
2877         (-[TextInputController validAttributesForMarkedText]):
2878         (-[TextInputController attributedStringWithString:]):
2879         (-[TextInputController stringWithUndoGroupingInsertion:]):
2880         (-[TextInputController dictatedStringWithPrimaryString:alternative:alternativeOffset:alternativeLength:]):
2881         (-[TextInputController setInputMethodHandler:]):
2882         (-[TextInputController interpretKeyEvents:withSender:]):
2883
2884         Fixes miscellaneous style issues.
2885
2886 2016-11-11  Philippe Normand  <pnormand@igalia.com>
2887
2888         [GTK][JHbuild] bump libnice version in openwebrtc.modules
2889         https://bugs.webkit.org/show_bug.cgi?id=164586
2890
2891         Reviewed by Michael Catanzaro.
2892
2893         Update to a recent libnice git snapshot and remove patches already
2894         upstream or not applying anymore. The patches not upstream yet
2895         will be reported in Phabricator.
2896
2897         * gtk/openwebrtc.modules:
2898         * gtk/patches/libnice-0001-agent-Remove-unnecessary-NULL-check.patch: Removed.
2899         * gtk/patches/libnice-0002-Do-not-update-a-remote-candidate-s-type.patch: Removed.
2900         * gtk/patches/libnice-0002-TURN-handle-437-Allocation-Mismatch-responses.patch: Removed.
2901         * gtk/patches/libnice-0003-Do-not-compare-scope-for-IPv6-address-when-scope-is-.patch: Removed.
2902         * gtk/patches/libnice-0004-Removing-no-op-assignment.patch: Removed.
2903
2904 2016-11-10  Alex Christensen  <achristensen@webkit.org>
2905
2906         Fix assertion after r208534.
2907         https://bugs.webkit.org/show_bug.cgi?id=160497
2908
2909         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2910         * TestWebKitAPI/Tests/mac/MemoryPressureHandler.mm: Added.
2911         (TestWebKitAPI::TEST):
2912         Add a regression test.
2913
2914 2016-11-10  Chris Dumez  <cdumez@apple.com>
2915
2916         REGRESSION (r208522): LayoutTest fast/loader/reload-zero-byte-plugin.html is a flaky failure
2917         https://bugs.webkit.org/show_bug.cgi?id=164570
2918
2919         Reviewed by Simon Fraser.
2920
2921         Properly reset TestController::m_shouldDownloadUndisplayableMIMETypes between tests to
2922         avoid flakiness.
2923
2924         * WebKitTestRunner/TestController.cpp:
2925         (WTR::TestController::resetStateToConsistentValues):
2926
2927 2016-11-10  Miguel Gomez  <magomez@igalia.com>
2928
2929         Unreviewed. Added myself to the list of committers.
2930
2931         * Scripts/webkitpy/common/config/contributors.json:
2932
2933 2016-10-27  Sergio Villar Senin  <svillar@igalia.com>
2934
2935         [GTK] New API to notify about dynamically added forms
2936         https://bugs.webkit.org/show_bug.cgi?id=164050
2937
2938         Reviewed by Carlos Garcia Campos.
2939
2940         Added a new test case to verify that dinamically added forms correctly trigger the
2941         "form-controls-associated" signal from WebPage.
2942
2943         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
2944         (didAssociateFormControlsCallback):
2945         (testWebExtensionFormControlsAssociated):
2946         (beforeAll):
2947         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
2948         (DelayedSignal::DelayedSignal):
2949         (emitFormControlsAssociated):
2950         (formControlsAssociatedCallback):
2951         (pageCreatedCallback):
2952
2953 2016-11-09  Ryosuke Niwa  <rniwa@webkit.org>
2954
2955         WebHTMLView's _attributeStringFromDOMRange should use HTMLConverter instead of NSAttributedString's _initWithDOMRange
2956         https://bugs.webkit.org/show_bug.cgi?id=164501
2957         <rdar://problem/29152282>
2958
2959         Reviewed by Sam Weinig.
2960
2961         * DumpRenderTree/mac/TextInputController.m:
2962         (-[TextInputController legacyAttributedString:]):
2963
2964 2016-11-09  Chris Dumez  <cdumez@apple.com>
2965
2966         [WK2][NETWORK_SESSION] Add support for downloading file backed blobs
2967         https://bugs.webkit.org/show_bug.cgi?id=164458
2968         <rdar://problem/28905514>
2969
2970         Reviewed by Darin Adler.
2971
2972         Add testRunner.setShouldDownloadUndisplayableMIMETypes(bool) API so that layout
2973         tests can request that such resources are downloaded instead of being ignored.
2974
2975         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2976         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2977         (WTR::TestRunner::setShouldDownloadUndisplayableMIMETypes):
2978         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2979         * WebKitTestRunner/TestController.cpp:
2980         (WTR::TestController::decidePolicyForNavigationResponse):
2981         * WebKitTestRunner/TestController.h:
2982         (WTR::TestController::setShouldDownloadUndisplayableMIMETypes):
2983         * WebKitTestRunner/TestInvocation.cpp:
2984         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2985
2986 2016-11-09  Carlos Garcia Campos  <cgarcia@igalia.com>
2987
2988         NetworkSession: Network process crash when converting main resource to download
2989         https://bugs.webkit.org/show_bug.cgi?id=164220
2990
2991         Reviewed by Alex Christensen.
2992
2993         Split /webkit2/Downloads/policy-decision-download in two, one to test the full load when main resource is
2994         converted to a download and another one to test the cancellation as the test was doing before. When doing the
2995         full load, delay a bit the decide destination to ensure the load is aborted before the data task has became a
2996         download.
2997
2998         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
2999         (testPolicyResponseDownload):
3000         (testPolicyResponseDownloadCancel):
3001         (beforeAll):
3002
3003 2016-11-09  KwangHyuk Kim  <hyuki.kim@samsung.com>
3004
3005         [EFL] fix error message caused by eina log
3006         https://bugs.webkit.org/show_bug.cgi?id=164546
3007
3008         Reviewed by Gyuyoung Kim.
3009
3010         Fix error message caused by eina log when MiniBrowser is working with help option.
3011
3012         * MiniBrowser/efl/main.c:
3013         (quit):
3014
3015 2016-11-09  Brent Fulgham  <bfulgham@apple.com>
3016
3017         Unreviewed build fix after r208509.
3018
3019         * DumpRenderTree/win/TestRunnerWin.cpp:
3020         (TestRunner::setNeedsStorageAccessFromFileURLsQuirk): Add missing TestRunner implementation."
3021
3022 2016-11-09  Alex Christensen  <achristensen@webkit.org>
3023
3024         Unreviewed, rolling out r208438.
3025
3026         crashes
3027
3028         Reverted changeset:
3029
3030         "[WK2][NETWORK_SESSION] Add support for downloading file
3031         backed blobs"
3032         https://bugs.webkit.org/show_bug.cgi?id=164458
3033         http://trac.webkit.org/changeset/208438
3034
3035 2016-11-04  Brent Fulgham  <bfulgham@apple.com>
3036
3037         Local HTML should be blocked from localStorage access unless "Disable Local File Restrictions" is checked
3038         https://bugs.webkit.org/show_bug.cgi?id=155185
3039         <rdar://problem/11101440>
3040
3041         Reviewed by Brady Eidson.
3042
3043         * DumpRenderTree/TestRunner.cpp:
3044         (setNeedsLocalStorageQuirkCallback): Added.
3045         (TestRunner::staticFunctions):
3046         * DumpRenderTree/TestRunner.h:
3047         * DumpRenderTree/mac/DumpRenderTree.mm:
3048         (resetWebPreferencesToConsistentValues): Update for new quirk setting.
3049         * DumpRenderTree/mac/TestRunnerMac.mm:
3050         (TestRunner::setNeedsLocalStorageQuirk):
3051         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3052         * TestWebKitAPI/Tests/WebKit2/CloseFromWithinCreatePage.cpp:
3053         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
3054         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.mm:
3055         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageQuirkEnabled.html: Added.
3056         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageQuirkTest.mm: Added.
3057         (-[LocalStorageQuirkMessageHandler userContentController:didReceiveScriptMessage:]):
3058         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3059         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3060         (WTR::InjectedBundle::beginTesting): Update for new quirk setting.
3061         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3062         (WTR::TestRunner::setNeedsLocalStorageQuirk): Added.
3063         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3064
3065 2016-11-09  Alex Christensen  <achristensen@webkit.org>
3066
3067         URLParser should not consider path of URLs with no host to start at the first slash after the colon
3068         https://bugs.webkit.org/show_bug.cgi?id=164555
3069
3070         Reviewed by Tim Horton.
3071
3072         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3073         (TestWebKitAPI::TEST_F):
3074
3075 2016-11-09  Jonathan Bedard  <jbedard@apple.com>
3076
3077         test-webkitpy failing test_create_patch_is_full_patch unit test
3078         https://bugs.webkit.org/show_bug.cgi?id=164385
3079
3080         Reviewed by Darin Adler.
3081
3082         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py: Fixed expected output to match output.
3083
3084 2016-11-09  Chris Dumez  <cdumez@apple.com>
3085
3086         [Mac] Stop using deprecated AppKit enumeration values
3087         https://bugs.webkit.org/show_bug.cgi?id=164494
3088
3089         Reviewed by Darin Adler.
3090
3091         Stop using deprecated AppKit enumeration values.
3092
3093         * DumpRenderTree/mac/EventSendingController.mm:
3094         (eventTypeForMouseButtonAndAction):
3095         (modifierFlags):
3096         (-[EventSendingController mouseMoveToX:Y:]):
3097         (-[EventSendingController contextClick]):
3098         (-[EventSendingController keyDown:withModifiers:withLocation:]):
3099         * DumpRenderTree/mac/TextInputController.m:
3100         (-[TextInputController interpretKeyEvents:withSender:]):
3101         * TestWebKitAPI/Tests/WebKit2Cocoa/CommandBackForward.mm:
3102         (simulateCommandArrow):
3103         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenDelegate.mm:
3104         (TestWebKitAPI::TEST):
3105         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.mm:
3106         (TestWebKitAPI::TEST):
3107         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.mm:
3108         (TestWebKitAPI::TEST):
3109         * TestWebKitAPI/Tests/WebKit2Cocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
3110         (TEST):
3111         * TestWebKitAPI/Tests/WebKit2Cocoa/UserInitiatedActionInNavigationAction.mm:
3112         (UserInitiatedActionTest::SetUp):
3113         (UserInitiatedActionTest::click):
3114         * TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm:
3115         (TestWebKitAPI::AcceptsFirstMouse::runTest):
3116         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:
3117         (TestWebKitAPI::contextMenuCopyLink):
3118         (TestWebKitAPI::TEST):
3119         * TestWebKitAPI/Tests/mac/ContextMenuDefaultItemsHaveTags.mm:
3120         (TestWebKitAPI::TEST):
3121         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
3122         (TestWebKitAPI::FullscreenZoomInitialFrame::runTest):
3123         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
3124         (TestWebKitAPI::TEST):
3125         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
3126         (TestWebKitAPI::Util::isKeyDown):
3127         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3128         (TestWebKitAPI::PlatformWebView::initialize):
3129         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
3130         (TestWebKitAPI::PlatformWebView::simulateRightClick):
3131         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
3132         (TestWebKitAPI::eventTypeForButton):
3133         (TestWebKitAPI::modifierFlagsForWKModifiers):
3134         * TestWebKitAPI/mac/TestWKWebViewMac.mm:
3135         (__simulated_forceClickAssociatedEventsMask):
3136         (-[TestWKWebViewHostWindow _mouseDownAtPoint:simulatePressure:]):
3137         (-[TestWKWebView _setUpTestWindow:]):
3138         (-[TestWKWebView typeCharacter:]):
3139         * WebKitTestRunner/mac/EventSenderProxy.mm:
3140         (WTR::eventTypeForMouseButtonAndAction):
3141         (WTR::buildModifierFlags):
3142         (WTR::EventSenderProxy::sendMouseDownToStartPressureEvents):
3143         (WTR::EventSenderProxy::mouseForceClick):
3144         (WTR::EventSenderProxy::startAndCancelMouseForceClick):
3145         (WTR::EventSenderProxy::mouseMoveTo):
3146         (WTR::EventSenderProxy::keyDown):
3147         (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
3148         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3149         (WTR::PlatformWebView::PlatformWebView):
3150         * WebKitTestRunner/mac/TestControllerMac.mm:
3151         (WTR::TestController::platformResetStateToConsistentValues):
3152
3153 2016-11-09  Beth Dakin  <bdakin@apple.com>
3154
3155         Support TouchBar in WebKit
3156         https://bugs.webkit.org/show_bug.cgi?id=164437
3157         -and corresponding-
3158         rdar://problem/28876524
3159
3160         Reviewed by Darin Adler.
3161
3162         This makes MiniBrowser support TouchBar customization. 
3163
3164         * MiniBrowser/mac/AppDelegate.m:
3165         (-[BrowserAppDelegate awakeFromNib]):
3166
3167 2016-11-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3168
3169         [EFL] Use libgcrypt instead of GnuTLS for CryptoDigest
3170         https://bugs.webkit.org/show_bug.cgi?id=164461
3171
3172         Reviewed by Michael Catanzaro.
3173
3174         As GTK port in r208297, EFL port starts to use libgcrypt instead of GnuTLS as well.
3175
3176         * efl/install-dependencies: Add libgcript package dependecy.
3177
3178 2016-11-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3179
3180         [EFL] Remove unused function in MiniBrowser
3181         https://bugs.webkit.org/show_bug.cgi?id=164398
3182
3183         Reviewed by Darin Adler.
3184
3185         * MiniBrowser/efl/main.c:
3186         (window_find_with_elm_window): Deleted because it is not used anywhere.
3187
3188 2016-11-09  Chris Dumez  <cdumez@apple.com>
3189
3190         [WK2][NETWORK_SESSION] Add support for downloading file backed blobs
3191         https://bugs.webkit.org/show_bug.cgi?id=164458
3192         <rdar://problem/28905514>
3193
3194         Reviewed by Darin Adler.
3195
3196         Add testRunner.setShouldDownloadUndisplayableMIMETypes(bool) API so that layout
3197         tests can request that such resources are downloaded instead of being ignored.
3198
3199         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3200         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3201         (WTR::TestRunner::setShouldDownloadUndisplayableMIMETypes):
3202         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3203         * WebKitTestRunner/TestController.cpp:
3204         (WTR::TestController::decidePolicyForNavigationResponse):
3205         * WebKitTestRunner/TestController.h:
3206         (WTR::TestController::setShouldDownloadUndisplayableMIMETypes):
3207         * WebKitTestRunner/TestInvocation.cpp:
3208         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3209
3210 2016-11-09  Jonathan Bedard  <jbedard@apple.com>
3211
3212         Make rpaths more robust for iOS Simulators
3213         https://bugs.webkit.org/show_bug.cgi?id=164521
3214
3215         Reviewed by Simon Fraser.
3216
3217         * Scripts/webkitpy/port/ios.py:
3218         (IOSSimulatorPort._createSimulatorApp): Added more robust path.
3219
3220 2016-11-09  Csaba Osztrogonác  <ossy@webkit.org>
3221
3222         Fix Tools build on case sensitive file systems
3223         https://bugs.webkit.org/show_bug.cgi?id=164474
3224
3225         Unreviewed buildfix.
3226
3227         * DumpRenderTree/CMakeLists.txt:
3228         * DumpRenderTree/PlatformMac.cmake:
3229         * DumpRenderTree/PlatformWin.cmake:
3230         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
3231         * MiniBrowser/mac/CMakeLists.txt:
3232
3233 2016-11-04  Filip Pizlo  <fpizlo@apple.com>
3234
3235         WTF::ParkingLot should stop using std::chrono because std::chrono::duration casts are prone to overflows
3236         https://bugs.webkit.org/show_bug.cgi?id=152045
3237
3238         Reviewed by Andy Estes.
3239
3240         * TestWebKitAPI/CMakeLists.txt:
3241         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3242         * TestWebKitAPI/Tests/WTF/Condition.cpp:
3243         (TestWebKitAPI::TEST):
3244         * TestWebKitAPI/Tests/WTF/SynchronizedFixedQueue.cpp:
3245         (TestWebKitAPI::ToUpperConverter::stopProducing):
3246         (TestWebKitAPI::ToUpperConverter::stopConsuming):
3247         * TestWebKitAPI/Tests/WTF/Time.cpp: Added.
3248         (WTF::operator<<):
3249         (TestWebKitAPI::TEST):
3250
3251 2016-11-04  Alex Christensen  <achristensen@webkit.org>
3252
3253         Unreviewed, rolling out r208293.
3254
3255         asserts in API tests.
3256
3257         Reverted changeset:
3258
3259         "NetworkSession: Network process crash when converting main
3260         resource to download"
3261         https://bugs.webkit.org/show_bug.cgi?id=164220
3262         http://trac.webkit.org/changeset/208293
3263
3264 2016-11-04  Said Abou-Hallawa  <sabouhallawa@apple.com>
3265
3266         Add a setting and preferences to enable/disable async image decoding
3267         https://bugs.webkit.org/show_bug.cgi?id=164417
3268
3269         Reviewed by Simon Fraser.
3270
3271         Pref and a menu item to toggle asyncImageDecodingEnabled for WebKits 1 and 2.
3272
3273         * MiniBrowser/mac/SettingsController.h:
3274         * MiniBrowser/mac/SettingsController.m:
3275         (-[SettingsController _populateMenu]):
3276         (-[SettingsController validateMenuItem:]):
3277         (-[SettingsController toggleAsyncImageDecodingEnabled:]):
3278         (-[SettingsController asyncImageDecodingEnabled]):
3279         * MiniBrowser/mac/WK1BrowserWindowController.m:
3280         (-[WK1BrowserWindowController didChangeSettings]):
3281         * MiniBrowser/mac/WK2BrowserWindowController.m:
3282         (-[WK2BrowserWindowController didChangeSettings]):
3283
3284 2016-11-04  Brady Eidson  <beidson@apple.com>
3285
3286         REGRESSION (r208349) StringHasher::hashMemory behavior changed, causing API tests to fail
3287         https://bugs.webkit.org/show_bug.cgi?id=164390
3288
3289         Reviewed by Geoffrey Garen.
3290
3291         Operating under the assumption that the behavior change is okay/desirable, this updates the test.
3292
3293         * TestWebKitAPI/Tests/WTF/StringHasher.cpp:
3294         (TestWebKitAPI::TEST):
3295
3296 2016-11-04  Joanmarie Diggs  <jdiggs@igalia.com>
3297
3298         AX: [ATK] Attempting to clear selection on ARIA listboxes results in crash
3299         https://bugs.webkit.org/show_bug.cgi?id=164331
3300
3301         Reviewed by Chris Fleizach.
3302
3303         Add AccessibilityUIElement::clearSelectedChildren() to DRT and WKTR.
3304         Implement it for ATK.
3305
3306         * DumpRenderTree/AccessibilityUIElement.h:
3307         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3308         (AccessibilityUIElement::clearSelectedChildren):
3309         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3310         (AccessibilityUIElement::clearSelectedChildren):
3311         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3312         (AccessibilityUIElement::clearSelectedChildren):
3313         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3314         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3315         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3316         (WTR::AccessibilityUIElement::clearSelectedChildren):
3317         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3318         (WTR::AccessibilityUIElement::clearSelectedChildren):
3319         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3320         (WTR::AccessibilityUIElement::clearSelectedChildren):
3321
3322 2016-11-04  Per Arne Vollan  <pvollan@apple.com>
3323
3324         [Win] Page visibility tests are timing out.
3325         https://bugs.webkit.org/show_bug.cgi?id=164363
3326
3327         Reviewed by Brent Fulgham.
3328
3329         Implement methods to set page visibility.
3330
3331         * DumpRenderTree/win/TestRunnerWin.cpp:
3332         (TestRunner::resetPageVisibility):
3333         (TestRunner::setPageVisibility):
3334
3335 2016-11-03  Simon Fraser  <simon.fraser@apple.com>
3336
3337         Give all the geometry classes a single-argument scale() function for consistency
3338         https://bugs.webkit.org/show_bug.cgi?id=164400
3339
3340         Reviewed by Zalan Bujtas.
3341         
3342         Test single-argument scale().
3343
3344         * TestWebKitAPI/Tests/WebCore/FloatPoint.cpp:
3345         (TestWebKitAPI::TEST):
3346
3347 2016-11-03  Chris Dumez  <cdumez@apple.com>
3348
3349         [WK2][Cocoa] Implement user interface for HTML form validation
3350         https://bugs.webkit.org/show_bug.cgi?id=164143
3351         <rdar://problem/28944652>
3352
3353         Reviewed by Simon Fraser.
3354
3355         Add support for UIScriptController::contentsOfUserInterfaceItem("validationBubble")
3356         on both Mac and iOS to retrieve the currently displayed validation message.
3357
3358         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3359         (WTR::UIScriptController::contentsOfUserInterfaceItem):
3360         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3361         (WTR::UIScriptController::contentsOfUserInterfaceItem):
3362         (WTR::UIScriptController::selectFormAccessoryPickerRow):
3363         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
3364         (WTR::UIScriptController::contentsOfUserInterfaceItem):
3365
3366 2016-11-03  Konstantin Tokarev  <annulen@yandex.ru>
3367
3368         Fixes to build JSCOnly on macOS
3369         https://bugs.webkit.org/show_bug.cgi?id=164379
3370
3371         Reviewed by Michael Catanzaro.
3372
3373         * TestWebKitAPI/PlatformJSCOnly.cmake: Moved BUILDING_JSCONLY__
3374         definition to OptionsJSCOnly.cmake
3375
3376 2016-11-03  Dan Bernstein  <mitz@apple.com>
3377
3378         WKWebView’s _observedRenderingProgressEvents not restored after web process crash
3379         https://bugs.webkit.org/show_bug.cgi?id=164368
3380         <rdar://problem/29091954>
3381
3382         Reviewed by Anders Carlsson.
3383
3384         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3385         * TestWebKitAPI/Tests/WebKit2Cocoa/ObservedRenderingProgressEventsAfterCrash.mm: Added.
3386         (TEST):
3387
3388 2016-11-03  Alex Christensen  <achristensen@webkit.org>
3389
3390         Purge PassRefPtr from Tools
3391         https://bugs.webkit.org/show_bug.cgi?id=164358
3392
3393         Reviewed by Michael Catanzaro.
3394
3395         * ImageDiff/efl/ImageDiff.cpp:
3396         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitAccessibility.cpp:
3397         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
3398         (WTR::AccessibilityController::create):
3399         (WTR::AccessibilityController::rootElement):
3400         (WTR::AccessibilityController::focusedElement):
3401         (WTR::AccessibilityController::elementAtPoint):
3402         (WTR::AccessibilityController::addNotificationListener): Deleted.
3403         (WTR::AccessibilityController::removeNotificationListener): Deleted.
3404         (WTR::AccessibilityController::accessibleElementById): Deleted.
3405         (WTR::AccessibilityController::logAccessibilityEvents): Deleted.
3406         (WTR::AccessibilityController::resetToConsistentState): Deleted.
3407         (WTR::AccessibilityController::platformName): Deleted.
3408         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
3409         (WTR::AccessibilityController::logAccessibilityEvents):
3410         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp:
3411         (WTR::AccessibilityTextMarker::create):
3412         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.h:
3413         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp:
3414         (WTR::AccessibilityTextMarkerRange::create):
3415         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.h:
3416         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3417         (WTR::AccessibilityUIElement::create):
3418         (WTR::AccessibilityUIElement::linkedElement):
3419         (WTR::AccessibilityUIElement::headerElementAtIndex):
3420         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
3421         (WTR::AccessibilityUIElement::characterAtOffset):
3422         (WTR::AccessibilityUIElement::wordAtOffset):
3423         (WTR::AccessibilityUIElement::lineAtOffset):
3424         (WTR::AccessibilityUIElement::sentenceAtOffset):
3425         (WTR::AccessibilityUIElement::selectedTextMarkerRange):
3426         (WTR::AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker):
3427         (WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
3428         (WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
3429         (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
3430         (WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
3431         (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
3432         (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
3433         (WTR::AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker):
3434         (WTR::AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker):
3435         (WTR::AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker):
3436         (WTR::AccessibilityUIElement::AccessibilityUIElement): Deleted.
3437         (WTR::AccessibilityUIElement::~AccessibilityUIElement): Deleted.
3438         (WTR::AccessibilityUIElement::isEqual): Deleted.
3439         (WTR::AccessibilityUIElement::elementAtPoint): Deleted.
3440         (WTR::AccessibilityUIElement::childAtIndex): Deleted.
3441         (WTR::AccessibilityUIElement::indexOfChild): Deleted.
3442         (WTR::AccessibilityUIElement::childrenCount): Deleted.
3443         (WTR::AccessibilityUIElement::titleUIElement): Deleted.
3444         (WTR::AccessibilityUIElement::parentElement): Deleted.
3445         (WTR::AccessibilityUIElement::takeFocus): Deleted.
3446         (WTR::AccessibilityUIElement::takeSelection): Deleted.
3447         (WTR::AccessibilityUIElement::addSelection): Deleted.
3448         (WTR::AccessibilityUIElement::removeSelection): Deleted.
3449         (WTR::AccessibilityUIElement::allAttributes): Deleted.
3450         (WTR::AccessibilityUIElement::attributesOfLinkedUIElements): Deleted.
3451         (WTR::AccessibilityUIElement::linkedUIElementAtIndex): Deleted.
3452         (WTR::AccessibilityUIElement::attributesOfDocumentLinks): Deleted.
3453         (WTR::AccessibilityUIElement::attributesOfChildren): Deleted.
3454         (WTR::AccessibilityUIElement::parameterizedAttributeNames): Deleted.
3455         (WTR::AccessibilityUIElement::increment): Deleted.
3456         (WTR::AccessibilityUIElement::decrement): Deleted.
3457         (WTR::AccessibilityUIElement::showMenu): Deleted.
3458         (WTR::AccessibilityUIElement::press): Deleted.
3459         (WTR::AccessibilityUIElement::stringAttributeValue): Deleted.
3460         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue): Deleted.
3461         (WTR::AccessibilityUIElement::uiElementAttributeValue): Deleted.
3462         (WTR::AccessibilityUIElement::numberAttributeValue): Deleted.
3463         (WTR::AccessibilityUIElement::boolAttributeValue): Deleted.
3464         (WTR::AccessibilityUIElement::isAttributeSupported): Deleted.
3465         (WTR::AccessibilityUIElement::isAttributeSettable): Deleted.
3466         (WTR::AccessibilityUIElement::isPressActionSupported): Deleted.
3467         (WTR::AccessibilityUIElement::isIncrementActionSupported): Deleted.
3468         (WTR::AccessibilityUIElement::isDecrementActionSupported): Deleted.
3469         (WTR::AccessibilityUIElement::role): Deleted.
3470         (WTR::AccessibilityUIElement::subrole): Deleted.
3471         (WTR::AccessibilityUIElement::roleDescription): Deleted.
3472         (WTR::AccessibilityUIElement::computedRoleString): Deleted.
3473         (WTR::AccessibilityUIElement::title): Deleted.
3474         (WTR::AccessibilityUIElement::description): Deleted.
3475         (WTR::AccessibilityUIElement::language): Deleted.
3476         (WTR::AccessibilityUIElement::stringValue): Deleted.
3477         (WTR::AccessibilityUIElement::accessibilityValue): Deleted.
3478         (WTR::AccessibilityUIElement::helpText): Deleted.
3479         (WTR::AccessibilityUIElement::orientation): Deleted.
3480         (WTR::AccessibilityUIElement::x): Deleted.
3481         (WTR::AccessibilityUIElement::y): Deleted.
3482         (WTR::AccessibilityUIElement::width): Deleted.
3483         (WTR::AccessibilityUIElement::height): Deleted.
3484         (WTR::AccessibilityUIElement::intValue): Deleted.
3485         (WTR::AccessibilityUIElement::minValue): Deleted.
3486         (WTR::AccessibilityUIElement::maxValue): Deleted.
3487         (WTR::AccessibilityUIElement::valueDescription): Deleted.
3488         (WTR::AccessibilityUIElement::insertionPointLineNumber): Deleted.
3489         (WTR::AccessibilityUIElement::selectedTextRange): Deleted.
3490         (WTR::AccessibilityUIElement::isEnabled): Deleted.
3491         (WTR::AccessibilityUIElement::isRequired): Deleted.
3492         (WTR::AccessibilityUIElement::isFocused): Deleted.
3493         (WTR::AccessibilityUIElement::isFocusable): Deleted.
3494         (WTR::AccessibilityUIElement::isSelected): Deleted.
3495         (WTR::AccessibilityUIElement::isSelectedOptionActive): Deleted.
3496         (WTR::AccessibilityUIElement::isSelectable): Deleted.
3497         (WTR::AccessibilityUIElement::isMultiSelectable): Deleted.
3498         (WTR::AccessibilityUIElement::setSelectedChild): Deleted.
3499         (WTR::AccessibilityUIElement::setSelectedChildAtIndex): Deleted.
3500         (WTR::AccessibilityUIElement::removeSelectionAtIndex): Deleted.
3501         (WTR::AccessibilityUIElement::selectedChildrenCount): Deleted.
3502         (WTR::AccessibilityUIElement::selectedChildAtIndex): Deleted.
3503         (WTR::AccessibilityUIElement::isExpanded): Deleted.
3504         (WTR::AccessibilityUIElement::isChecked): Deleted.
3505         (WTR::AccessibilityUIElement::isIndeterminate): Deleted.
3506         (WTR::AccessibilityUIElement::isVisible): Deleted.
3507         (WTR::AccessibilityUIElement::isOffScreen): Deleted.
3508         (WTR::AccessibilityUIElement::isCollapsed): Deleted.
3509         (WTR::AccessibilityUIElement::isIgnored): Deleted.
3510         (WTR::AccessibilityUIElement::hasPopup): Deleted.
3511         (WTR::AccessibilityUIElement::hierarchicalLevel): Deleted.
3512         (WTR::AccessibilityUIElement::clickPointX): Deleted.
3513         (WTR::AccessibilityUIElement::clickPointY): Deleted.
3514         (WTR::AccessibilityUIElement::documentEncoding): Deleted.
3515         (WTR::AccessibilityUIElement::documentURI): Deleted.
3516         (WTR::AccessibilityUIElement::url): Deleted.
3517         (WTR::AccessibilityUIElement::speak): Deleted.
3518         (WTR::AccessibilityUIElement::attributesOfColumnHeaders): Deleted.
3519         (WTR::AccessibilityUIElement::attributesOfRowHeaders): Deleted.
3520         (WTR::AccessibilityUIElement::attributesOfColumns): Deleted.
3521         (WTR::AccessibilityUIElement::attributesOfRows): Deleted.
3522         (WTR::AccessibilityUIElement::attributesOfVisibleCells): Deleted.
3523         (WTR::AccessibilityUIElement::attributesOfHeader): Deleted.
3524         (WTR::AccessibilityUIElement::indexInTable): Deleted.
3525         (WTR::AccessibilityUIElement::rowIndexRange): Deleted.
3526         (WTR::AccessibilityUIElement::columnIndexRange): Deleted.
3527         (WTR::AccessibilityUIElement::rowCount): Deleted.
3528         (WTR::AccessibilityUIElement::columnCount): Deleted.
3529         (WTR::AccessibilityUIElement::rowHeaders): Deleted.
3530         (WTR::AccessibilityUIElement::columnHeaders): Deleted.
3531         (WTR::AccessibilityUIElement::selectedRowAtIndex): Deleted.
3532         (WTR::AccessibilityUIElement::disclosedByRow): Deleted.
3533         (WTR::AccessibilityUIElement::disclosedRowAtIndex): Deleted.
3534         (WTR::AccessibilityUIElement::rowAtIndex): Deleted.
3535         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex): Deleted.
3536         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex): Deleted.
3537         (WTR::AccessibilityUIElement::ariaControlsElementAtIndex): Deleted.
3538         (WTR::AccessibilityUIElement::ariaIsGrabbed): Deleted.
3539         (WTR::AccessibilityUIElement::ariaDropEffects): Deleted.
3540         (WTR::AccessibilityUIElement::classList): Deleted.
3541         (WTR::AccessibilityUIElement::lineForIndex): Deleted.
3542         (WTR::AccessibilityUIElement::rangeForLine): Deleted.
3543         (WTR::AccessibilityUIElement::rangeForPosition): Deleted.
3544         (WTR::AccessibilityUIElement::boundsForRange): Deleted.
3545         (WTR::AccessibilityUIElement::setSelectedTextRange): Deleted.
3546         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange): Deleted.
3547         (WTR::AccessibilityUIElement::stringForRange): Deleted.
3548         (WTR::AccessibilityUIElement::attributedStringForRange): Deleted.
3549         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled): Deleted.
3550         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate): Deleted.
3551         (WTR::AccessibilityUIElement::uiElementForSearchPredicate): Deleted.
3552         (WTR::AccessibilityUIElement::selectTextWithCriteria): Deleted.
3553         (WTR::AccessibilityUIElement::cellForColumnAndRow): Deleted.
3554         (WTR::AccessibilityUIElement::horizontalScrollbar): Deleted.
3555         (WTR::AccessibilityUIElement::verticalScrollbar): Deleted.
3556         (WTR::AccessibilityUIElement::addNotificationListener): Deleted.
3557         (WTR::AccessibilityUIElement::removeNotificationListener): Deleted.
3558         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker): Deleted.
3559         (WTR::AccessibilityUIElement::textMarkerRangeForElement): Deleted.
3560         (WTR::AccessibilityUIElement::textMarkerRangeLength): Deleted.
3561         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers): Deleted.
3562         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange): Deleted.
3563         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange): Deleted.
3564         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker): Deleted.
3565         (WTR::AccessibilityUIElement::endTextMarkerForBounds): Deleted.
3566         (WTR::AccessibilityUIElement::startTextMarkerForBounds): Deleted.
3567         (WTR::AccessibilityUIElement::textMarkerForPoint): Deleted.
3568         (WTR::AccessibilityUIElement::previousTextMarker): Deleted.
3569         (WTR::AccessibilityUIElement::nextTextMarker): Deleted.
3570         (WTR::AccessibilityUIElement::startTextMarker): Deleted.
3571         (WTR::AccessibilityUIElement::endTextMarker): Deleted.
3572         (WTR::AccessibilityUIElement::stringForTextMarkerRange): Deleted.
3573         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute): Deleted.
3574         (WTR::AccessibilityUIElement::indexForTextMarker): Deleted.
3575         (WTR::AccessibilityUIElement::isTextMarkerValid): Deleted.
3576         (WTR::AccessibilityUIElement::textMarkerForIndex): Deleted.
3577         (WTR::AccessibilityUIElement::scrollToMakeVisible): Deleted.
3578         (WTR::AccessibilityUIElement::scrollToGlobalPoint): Deleted.
3579         (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus): Deleted.
3580         (WTR::AccessibilityUIElement::supportedActions): Deleted.
3581         (WTR::AccessibilityUIElement::mathPostscriptsDescription): Deleted.
3582         (WTR::AccessibilityUIElement::mathPrescriptsDescription): Deleted.
3583         (WTR::AccessibilityUIElement::pathDescription): Deleted.
3584         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3585         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3586         (WTR::EventSendingController::create):
3587         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
3588         * WebKitTestRunner/InjectedBundle/GCController.cpp:
3589         (WTR::GCController::create):
3590         * WebKitTestRunner/InjectedBundle/GCController.h:
3591         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3592         (WTR::InjectedBundle::beginTesting):
3593         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3594         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: