[iOS] Remove all usages of UIItemProvider, UIItemProviderReading, and related classes
[WebKit-https.git] / Tools / ChangeLog
1 2018-11-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2
3         [iOS] Remove all usages of UIItemProvider, UIItemProviderReading, and related classes
4         https://bugs.webkit.org/show_bug.cgi?id=191819
5
6         Reviewed by Dan Bernstein.
7
8         Replace UIItemProvider (and related classes) with NSItemProvider.
9
10         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
11         (platformCopyPNG):
12         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
13         (-[NSItemProvider registerDataRepresentationForTypeIdentifier:withData:]):
14
15         Replace usages of this deprecated method with `-registerDataRepresentationForTypeIdentifier:visibility:loadHandler:`.
16
17         (checkEstimatedSize):
18         (checkSuggestedNameAndEstimatedSize):
19         (TestWebKitAPI::TEST):
20         (-[UIItemProvider registerDataRepresentationForTypeIdentifier:withData:]): Deleted.
21         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
22         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
23         (-[MockDragDropSession canLoadObjectsOfClass:]):
24         (-[MockDragDropSession canLoadObjectsOfClasses:]):
25         (-[MockDropSession initWithProviders:location:window:allowMove:]):
26         (-[MockDropSession canCreateItemsOfClass:]):
27         (-[DragAndDropSimulator _advanceProgress]):
28         (-[DragAndDropSimulator _webView:dataInteractionOperationWasHandled:forSession:itemProviders:]):
29         (-[DragAndDropSimulator _webView:adjustedDataInteractionItemProvidersForItemProvider:representingObjects:additionalData:]):
30         * TestWebKitAPI/ios/UIKitSPI.h:
31
32 2018-11-17  Chris Dumez  <cdumez@apple.com>
33
34         ASSERTION FAILED: m_messageReceivers.contains(...) under ViewGestureController removeMessageReceiver
35         https://bugs.webkit.org/show_bug.cgi?id=191734
36         <rdar://problem/46151497>
37
38         Reviewed by Ryosuke Niwa.
39
40         Add API test coverage.
41
42         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
43
44 2018-11-17  Zalan Bujtas  <zalan@apple.com>
45
46         [LFC][IFC] InlineFormattingState::addDetachingRule should accumulate rules.
47         https://bugs.webkit.org/show_bug.cgi?id=191801
48
49         Reviewed by Antti Koivisto.
50
51         * LayoutReloaded/misc/LFC-passing-tests.txt:
52
53 2018-11-17  Jer Noble  <jer.noble@apple.com>
54
55         Regression(r233865): Causes synchronous IPC in the middle of layout
56         https://bugs.webkit.org/show_bug.cgi?id=188307
57         <rdar://problem/42807306>
58
59         Reviewed by Eric Carlson.
60
61         Follow-up test fix for r238322:
62
63         In ExitFullscreenOnEnterPiP.ElementFullScreen, explicitly make the video
64         element in element fullscreen the "main content" by playing the video during
65         a user gesture; only "main content" videos will cause fullscreen mode to exit
66         when that element is taken into PiP.
67
68         In FullscreenZoomInitialFrame.WebKit, the WebView is not visible, so the Page
69         is considered hidden, and fullscreen is not allowed when the WebView is hidden.
70         Make the WebView visible by ordering the test window on-screen.
71
72         * TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.html:
73         * TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm:
74         (TestWebKitAPI::TEST):
75         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
76         (TestWebKitAPI::FullscreenZoomInitialFrame::runTest):
77
78 2018-11-16  Alex Christensen  <achristensen@webkit.org>
79
80         Tweak _showSafeBrowsingWarningWithTitle SPI
81         https://bugs.webkit.org/show_bug.cgi?id=191799
82
83         Reviewed by Wenson Hsieh.
84
85         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
86         (TEST):
87
88 2018-11-16  Ryosuke Niwa  <rniwa@webkit.org>
89
90         REGRESSION (r238294): TestWebKitAPI.WKNavigation.ProcessCrashDuringCallback failing on iOS
91         https://bugs.webkit.org/show_bug.cgi?id=191783
92
93         Reviewed by Chris Dumez.
94
95         Allow either WKErrorWebContentProcessTerminated or WKErrorWebViewInvalidated since the test
96         is closing WebView, thereby invalidating the view, which is racing with the process termination.
97
98         * TestWebKitAPI/Tests/WebKitCocoa/WebContentProcessDidTerminate.mm:
99         (TEST):
100
101 2018-11-16  Chris Dumez  <cdumez@apple.com>
102
103         ProcessSwap.DisableForInspector API test is failing
104         https://bugs.webkit.org/show_bug.cgi?id=191798
105
106         Reviewed by Joseph Pecoraro.
107
108         We support process swapping when Web Inspector is shown now so update the
109         API test accordingly.
110
111         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
112
113 2018-11-16  Ryan Haddad  <ryanhaddad@apple.com>
114
115         Update buildbot dashboard after Windows 7/10 updates
116         https://bugs.webkit.org/show_bug.cgi?id=191219
117
118         Reviewed by Alexey Proskuryakov.
119
120         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
121         (BubbleQueueServer):
122         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
123         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
124         (WebKitBuildbot):
125         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
126         (table.queue-grid tr.platform td.logo::before):
127         (table.queue-grid tr.platform.windows-10 td.logo::before):
128         (table.queue-grid tr.platform.wincairo-windows-10 td.logo::before):
129         (table.queue-grid tr.platform.windows-7 td.logo::before):
130         (table.queue-grid tr.platform.wincairo-windows-10 img.logo):
131
132 2018-11-16  Chris Dumez  <cdumez@apple.com>
133
134         Regression(PSON) WebKit.GeolocationTransitionToHighAccuracy API test is timing out
135         https://bugs.webkit.org/show_bug.cgi?id=191789
136
137         Reviewed by Alex Christensen.
138
139         Relate the 2 test pages so they use the same process since WKContextSetMaximumNumberOfProcesses()
140         SPI no longer works with PSON / Process prewarming.
141
142         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
143         (TestWebKitAPI::TEST):
144
145 2018-11-16  Jonathan Bedard  <jbedard@apple.com>
146
147         webkitpy: Retry app installation on watchOS simulators
148         https://bugs.webkit.org/show_bug.cgi?id=191769
149         <rdar://problem/46139850>
150
151         Reviewed by Aakash Jain.
152
153         * Scripts/webkitpy/xcode/simulated_device.py:
154         (SimulatedDevice.install_app): Retry app installations.
155
156 2018-11-16  Zalan Bujtas  <zalan@apple.com>
157
158         Add DidFirstMeaningfulPaint milestone.
159         https://bugs.webkit.org/show_bug.cgi?id=191754
160
161         Reviewed by Simon Fraser.
162
163         * TestWebKitAPI/CMakeLists.txt:
164         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
165         * TestWebKitAPI/Tests/WebKit/FirstMeaningfulPaintMilestone.cpp: Added.
166         (TestWebKitAPI::didReachMilestone):
167         (TestWebKitAPI::setPageLoaderClient):
168         (TestWebKitAPI::TEST):
169         * TestWebKitAPI/Tests/WebKit/FirstMeaningfulPaintMilestone_Bundle.cpp: Copied from Source/WebKit/UIProcess/API/C/WKPageRenderingProgressEvents.h.
170         (TestWebKitAPI::FirstMeaningfulPaintMilestoneTest::FirstMeaningfulPaintMilestoneTest):
171         (TestWebKitAPI::FirstMeaningfulPaintMilestoneTest::didCreatePage):
172
173 2018-11-16  Takashi Komori  <Takashi.Komori@sony.com>
174
175         [WinCairo][WebKitTestRunner] Test contents window is displayed while testing.
176         https://bugs.webkit.org/show_bug.cgi?id=191593
177
178         Reviewed by Alex Christensen.
179
180         Hide TestRunner window and taskbar button.
181
182         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
183         (WTR::PlatformWebView::PlatformWebView):
184         (WTR::PlatformWebView::windowSnapshotImage):
185
186 2018-11-16  Alex Christensen  <achristensen@webkit.org>
187
188         Add API to disable safe browsing checks
189         https://bugs.webkit.org/show_bug.cgi?id=191610
190
191         Reviewed by Dean Jackson.
192
193         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
194         (resourceURL):
195         (TEST):
196         (safeBrowsingView):
197         (simpleURL): Deleted.
198
199 2018-11-16  Zalan Bujtas  <zalan@apple.com>
200
201         [LFC][IFC] Add support for out-of-flow positioned boxes
202         https://bugs.webkit.org/show_bug.cgi?id=191726
203
204         Reviewed by Antti Koivisto.
205
206         * LayoutReloaded/misc/LFC-passing-tests.txt:
207
208 2018-11-15  Myles C. Maxfield  <mmaxfield@apple.com>
209
210         WKPreferencesSetFontSmoothingLevel doesn't actually do anything
211         https://bugs.webkit.org/show_bug.cgi?id=191708
212
213         Reviewed by Simon Fraser.
214
215         Delete the symbol because no one calls it and it doesn't do anything
216
217         * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
218         (TestWebKitAPI::TEST):
219         * WebKitTestRunner/TestController.cpp:
220         (WTR::TestController::resetPreferencesToConsistentValues):
221
222 2018-11-15  Truitt Savell  <tsavell@apple.com>
223
224         Unreviewed, rolling out r238244.
225
226         Caused High Sierra test runs to fail early with 50 crashes and
227         casued 25 API failures.
228
229         Reverted changeset:
230
231         "[css-logical] Implement flow-relative margin, padding and
232         border shorthands"
233         https://bugs.webkit.org/show_bug.cgi?id=188697
234         https://trac.webkit.org/changeset/238244
235
236 2018-11-15  Aakash Jain  <aakash_jain@apple.com>
237
238         Increase EWS lock timeout to 3 hours
239         https://bugs.webkit.org/show_bug.cgi?id=191705
240
241         Reviewed by Alexey Proskuryakov.
242
243         * QueueStatusServer/config/queues.py: Increased EWS lock timeout to 3 hours.
244
245 2018-11-15  Chris Dumez  <cdumez@apple.com>
246
247         IndexedDB.IndexedDBTempFileSize API test times out with process prewarming enabled
248         https://bugs.webkit.org/show_bug.cgi?id=191671
249         <rdar://problem/46086062>
250
251         Reviewed by Alex Christensen.
252
253         Add API test coverage.
254
255         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
256         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
257         (TEST):
258
259 2018-11-15  Oriol Brufau  <obrufau@igalia.com>
260
261         [css-logical] Implement flow-relative margin, padding and border shorthands
262         https://bugs.webkit.org/show_bug.cgi?id=188697
263
264         Reviewed by Simon Fraser and Antti Koivisto.
265
266         * DumpRenderTree/TestOptions.cpp:
267         (TestOptions::TestOptions):
268         * DumpRenderTree/TestOptions.h:
269         * DumpRenderTree/mac/DumpRenderTree.mm:
270         (setWebPreferencesForTestOptions):
271         Allow tests to enable the CSSLogicalEnabled flag in WK1.
272
273         * Scripts/webkitpy/style/checkers/jsonchecker.py:
274         (JSONCSSPropertiesChecker.check_codegen_properties):
275         Allow CSS property definitions to have a 'runtime-flag' parameter which
276         disables the property when the specified runtime flag is disabled.
277
278 2018-11-15  Timothy Hatcher  <timothy@apple.com>
279
280         REGRESSION (r238212): WebKit.BackgroundColor* API test failures.
281         https://bugs.webkit.org/show_bug.cgi?id=191697
282         rdar://problem/46098570
283
284         Reviewed by Dean Jackson.
285
286         * TestWebKitAPI/Tests/mac/BackgroundColor.mm:
287         (TestWebKitAPI::TEST): Updated for new default background color.
288
289 2018-11-15  Jonathan Bedard  <jbedard@apple.com>
290
291         webkitpy: Check for specific process instead of using data migrator (Follow-up fix)
292         https://bugs.webkit.org/show_bug.cgi?id=191551
293         <rdar://problem/45993156>
294
295         Reviewed by Aakash Jain.
296
297         * Scripts/webkitpy/xcode/simulated_device.py:
298         (SimulatedDevice.is_usable): Use software_variant instead of software_version for watchOS.
299
300 2018-11-15  Daniel Bates  <dabates@apple.com>
301
302         [iOS] Shift + Tab does not focus previous field
303         https://bugs.webkit.org/show_bug.cgi?id=191596
304         <rdar://problem/45892053>
305
306         Reviewed by Wenson Hsieh.
307
308         Add infrastructure to support testing a key down event with modifiers by creating
309         and dispatching a UIEvent. This infrastructure replaces the previous mechanism in
310         Tools/WebKitTestRunner/ios/HIDEventGenerator.mm to generate a IOHIDEvent for a
311         keydown as it did not support creating an event with modifier key state that would
312         be recognized by UIKit.
313
314         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
315         (WTR::UIScriptController::keyDown):
316         (WTR::UIScriptController::keyDownUsingHardwareKeyboard): Deleted.
317         (WTR::UIScriptController::keyUpUsingHardwareKeyboard): Deleted.
318         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
319         Add function uiController.keyDown() that takes a character that represents a keyboard key
320         and an array of modifier keys. The behavior of this function is analogous to eventSender.keyDown().
321         Remove functions uiController.keyDownUsingHardwareKeyboard() and uiController.keyUpUsingHardwareKeyboard()
322         as the former is replaced by uiController.keyDown() and the latter was never used.
323
324         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
325         (WTR::UIScriptController::keyDown): Added.
326         (WTR::UIScriptController::keyUpUsingHardwareKeyboard): Deleted.
327         (WTR::UIScriptController::keyDownUsingHardwareKeyboard): Deleted.
328         * TestRunnerShared/UIScriptContext/UIScriptController.h:
329         * WebKitTestRunner/ios/HIDEventGenerator.h:
330         * WebKitTestRunner/ios/HIDEventGenerator.mm:
331         (createHIDKeyDownEvent): Added.
332         (-[HIDEventGenerator keyDown:completionBlock:]): Deleted.
333         (-[HIDEventGenerator keyUp:completionBlock:]): Deleted.
334         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
335         (WTR::arrayLength): Added.
336         (WTR::parseModifier): Added.
337         (WTR::parseModifierArray): Added.
338         (WTR::UIScriptController::keyDown):
339         (WTR::UIScriptController::keyDownUsingHardwareKeyboard): Deleted.
340         (WTR::UIScriptController::keyUpUsingHardwareKeyboard): Deleted.
341
342 2018-11-15  Keith Rollin  <krollin@apple.com>
343
344         Delete old .xcfilelist files
345         https://bugs.webkit.org/show_bug.cgi?id=191669
346         <rdar://problem/46081994>
347
348         Reviewed by Chris Dumez.
349
350         .xcfilelist files were created and added to the Xcode project files in
351         https://trac.webkit.org/changeset/238008/webkit. However, they caused
352         build issues and they were removed from the Xcode projects in
353         https://trac.webkit.org/changeset/238055/webkit. This check-in removes
354         the files from the repository altogether. They'll ultimately be
355         replaced with new files with names that indicate whether the
356         associated files are inputs to the Run Script phase or are files
357         created by the Run Script phase.
358
359         * DumpRenderTree/DerivedSources.xcfilelist: Removed.
360         * WebKitTestRunner/DerivedSources.xcfilelist: Removed.
361
362 2018-11-14  Zalan Butjas  <zalan@apple.com>
363
364         [LFC][IFC] Add support for in-flow positioned inline boxes.
365         https://bugs.webkit.org/show_bug.cgi?id=191672
366
367         Reviewed by Antti Koivisto.
368
369         * LayoutReloaded/misc/LFC-passing-tests.txt:
370
371 2018-11-14  Keith Rollin  <krollin@apple.com>
372
373         Move scripts for Derived and Unified Sources to external files
374         https://bugs.webkit.org/show_bug.cgi?id=191670
375         <rdar://problem/46082278>
376
377         Reviewed by Keith Miller.
378
379         Move the scripts in the Generate Derived Sources and Generate Unified
380         Sources Run Script phases from the Xcode projects to external shell
381         script files. Then invoke those scripts from the Run Script phases.
382         This refactoring is being performed to support later work that will
383         invoke these scripts in other contexts.
384
385         The scripts were maintained as-is when making the move. I did a little
386         reformatting and added 'set -e' to the top of each file, but that's
387         it.
388
389         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
390         * DumpRenderTree/Scripts/generate-derived-sources.sh: Added.
391         * WebKitTestRunner/Scripts/generate-derived-sources.sh: Added.
392         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
393
394 2018-11-14  Chris Dumez  <cdumez@apple.com>
395
396         WebKit.DecidePolicyForNavigationActionForHyperlinkThatRedirects API fails when PSON is enabled
397         https://bugs.webkit.org/show_bug.cgi?id=191640
398
399         Reviewed by Alex Christensen.
400
401         Add API test coverage.
402
403         * TestWebKitAPI/Tests/WebKitCocoa/DecidePolicyForNavigationAction.mm:
404         (runDecidePolicyForNavigationActionForHyperlinkThatRedirects):
405         (TEST):
406
407 2018-11-14  Chris Dumez  <cdumez@apple.com>
408
409         REGRESSION (r238115): [iOS] TestWebKitAPI.ProcessSwap.NavigateToInvalidURL is failing
410         https://bugs.webkit.org/show_bug.cgi?id=191660
411
412         Reviewed by Ryosuke Niwa.
413
414         The test tries to navigate to an invalid URL and makes sure that we do not process swap
415         for such load. The test was inherently racing because it was doing:
416         <body onload="setTimeout(() => alert('DONE'), 0); location.href = 'http://A=a%B=b'">
417
418         Its load event handler tries to navigate to 'http://A=a%B=b' and sets a 0 timer to
419         log an alert, which causes the API test to keep going and check that we did not swap
420         process. The issue is that a 0 timer may not be sufficient to trigger the load, as
421         the policy decision is asynchronous and relies on the UIProcess responding to it.
422
423         To address the issue, the test now waits for the next policy decision, spins the
424         run loop and then makes sure we did not swap process. It no longer relies on a message
425         from the page.
426
427         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
428         (-[PSONNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
429
430 2018-11-14  Chris Dumez  <cdumez@apple.com>
431
432         WebKit.WebsiteDataStoreCustomPaths API test is failing when enabling process prewarming
433         https://bugs.webkit.org/show_bug.cgi?id=191638
434
435         Reviewed by Alex Christensen.
436
437         Add API test coverage.
438
439         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
440         (runWebsiteDataStoreCustomPaths):
441         (TEST):
442
443 2018-11-14  Alex Christensen  <achristensen@webkit.org>
444
445         Add SPI to show a safe browsing warning
446         https://bugs.webkit.org/show_bug.cgi?id=191604
447
448         Reviewed by Andy Estes.
449
450         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
451         (TEST):
452
453 2018-11-14  Wenson Hsieh  <wenson_hsieh@apple.com>
454
455         [iOS] A few drag and drop tests are crashing after r238146
456         https://bugs.webkit.org/show_bug.cgi?id=191617
457
458         Reviewed by Dean Jackson.
459
460         Augment these crashing tests to verify that selection commands are suppressed during drop over editable elements
461         via more robust means. These tests currently hit an assertion when revealing the callout bar too early, because
462         TestWebKitAPI is not a UI application (see <https://webkit.org/b/190401>).
463
464         Instead of relying on this other bug, directly ask the text input whether it is suppressing selection commands
465         during a drop, and remember the answer via DragAndDropSimulator.
466
467         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
468         (TestWebKitAPI::TEST):
469
470         Add to the existing tests that started failing after r238146.
471
472         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
473         * TestWebKitAPI/cocoa/TestWKWebView.h:
474         * TestWebKitAPI/cocoa/TestWKWebView.mm:
475         (-[TestWKWebView textInputContentView]):
476         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
477         (-[DragAndDropSimulator _resetSimulatedState]):
478         (-[DragAndDropSimulator _webView:dataInteractionOperationWasHandled:forSession:itemProviders:]):
479         * TestWebKitAPI/ios/UIKitSPI.h:
480
481 2018-11-14  Wenson Hsieh  <wenson_hsieh@apple.com>
482
483         [Cocoa] [WebKit2] Hook up some more editing actions (-pasteAndMatchStyle:, -makeTextWritingDirectionNatural:)
484         https://bugs.webkit.org/show_bug.cgi?id=191605
485         <rdar://problem/45813991>
486
487         Reviewed by Dean Jackson.
488
489         Adds two new API tests to exercise -_pasteAndMatchStyle: and -makeTextWritingDirectionNatural:.
490
491         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
492         (-[TestWKWebView _synchronouslyExecuteEditCommand:argument:]): Deleted.
493         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
494         (TestWebKitAPI::TEST):
495         * TestWebKitAPI/cocoa/TestWKWebView.h:
496         * TestWebKitAPI/cocoa/TestWKWebView.mm:
497
498         Pull `-_synchronouslyExecuteEditCommand:argument:` out of WKAttachmentTests and into shared code, in a new
499         category on WKWebView declared in TestWKWebView. Also, fix an unrelated typo in a nearby category.
500
501         (-[WKWebView _synchronouslyExecuteEditCommand:argument:]):
502         * TestWebKitAPI/ios/UIKitSPI.h:
503
504 2018-11-14  Chris Dumez  <cdumez@apple.com>
505
506         WebKit.ApplicationManifestBasic API test is failing when enabling PSON
507         https://bugs.webkit.org/show_bug.cgi?id=191602
508
509         Reviewed by Alex Christensen.
510
511         Add API test coverage.
512
513         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
514
515 2018-11-14  Jonathan Bedard  <jbedard@apple.com>
516
517         webkitpy: Refactor port code for devices
518         https://bugs.webkit.org/show_bug.cgi?id=191568
519         <rdar://problem/46005821>
520
521         Reviewed by Alex Christensen.
522
523         watchOS and iOS device ports share many characteristics in testing, mostly due
524         to the fact that both are devices.
525
526         * Scripts/webkitpy/port/device_port.py: Added.
527         (DevicePort): Add base class that all simulated/physical device ports share.
528         (DevicePort.__init__):
529         (DevicePort.driver_cmd_line_for_logging): Moved from iOS port.
530         (DevicePort._generate_all_test_configurations): Ditto.
531         (DevicePort.child_processes): Ditto.
532         (DevicePort.driver_name): Ditto.
533         (DevicePort.target_host): Generalize worker access to attached devices and
534         simulated devices based on the device manager.
535         (DevicePort.devices): Return a list of all devices associated with this port.
536         (DevicePort._create_devices):
537         (DevicePort._build_driver_flags): Moved from iOSSimulatorPort/iOSDevicePort.
538         (DevicePort._install): Moved from iOS port.
539         (DevicePort.setup_test_run): Ditto.
540         (DevicePort.clean_up_test_run): Ditto.
541         (DevicePort.did_spawn_worker): Ditto.
542         (DevicePort.setup_environ_for_server): Ditto.
543         * Scripts/webkitpy/port/ios.py:
544         (IOSPort):
545         (IOSPort._device_for_worker_number_map): Replaced by DevicePort.devices().
546         (IOSPort.driver_cmd_line_for_logging): Moved to DevicePort.
547         (IOSPort.driver_name): Ditto.
548         (IOSPort._generate_all_test_configurations): Ditto.
549         (IOSPort.child_processes): Ditto.
550         (IOSPort._testing_device): Ditto.
551         (IOSPort.target_host): Ditto.
552         (IOSPort._create_devices): Ditto.
553         (IOSPort.setup_test_run): Ditto.
554         (IOSPort.clean_up_test_run): Ditto.
555         (IOSPort.did_spawn_worker): Ditto.
556         * Scripts/webkitpy/port/ios_device.py:
557         (IOSDevicePort): IOSDevicePort uses a device manager from apple_additions.
558         (IOSDevicePort._look_for_all_crash_logs_in_log_dir): Use DevicePort.devices().
559         (IOSDevicePort._get_crash_log): Ditto.
560         (IOSDevicePort.ios_version): Ditto.
561         (IOSDevicePort._create_devices): Ditto.
562         (IOSDevicePort._device_for_worker_number_map): Replaced by DevicePort.devices().
563         (IOSSimulatorPort._build_driver_flags): Moved to DevicePort.
564         * Scripts/webkitpy/port/ios_device_unittest.py:
565         (IOSDeviceTest.test_get_crash_log):
566         * Scripts/webkitpy/port/ios_simulator.py:
567         (IOSSimulatorPort): IOSSimulatorPort uses the SimulatedDeviceManager.
568         (IOSSimulatorPort._create_devices): Clean up logging statement.
569         (IOSSimulatorPort.setup_environ_for_server): Some of environment set-up is shared
570         across all devices.
571         (IOSSimulatorPort._device_for_worker_number_map): Replaced by DevicePort.devices().
572         (IOSSimulatorPort._build_driver_flags): Moved to DevicePort.
573         * Scripts/webkitpy/port/ios_simulator_unittest.py:
574         (IOSSimulatorTest.test_32bit):
575         (IOSSimulatorTest.test_64bit):
576
577 2018-11-14  Chris Dumez  <cdumez@apple.com>
578
579         WebKit.WKHTTPCookieStoreWithoutProcessPool API test is failing with process prewarming is enabled
580         https://bugs.webkit.org/show_bug.cgi?id=191624
581
582         Reviewed by Alex Christensen.
583
584         Add API test coverage.
585
586         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
587         (runWKHTTPCookieStoreWithoutProcessPool):
588         (TEST):
589
590 2018-11-13  Jiewen Tan  <jiewen_tan@apple.com>
591
592         [WebAuthN] Support CTAP HID authenticators on macOS
593         https://bugs.webkit.org/show_bug.cgi?id=188623
594         <rdar://problem/43353777>
595
596         Reviewed by Brent Fulgham and Chris Dumez.
597
598         This patch adds support for the mock testing and entitlements to allow minibrowser to talk
599         to hid devices.
600
601         * MiniBrowser/MiniBrowser.entitlements:
602         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
603         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
604
605 2018-11-13  Ryosuke Niwa  <rniwa@webkit.org>
606
607         WebKit.GeolocationTransitionToLowAccuracy API crashes when enabling PSON
608         https://bugs.webkit.org/show_bug.cgi?id=191616
609
610         Reviewed by Chris Dumez.
611
612         The crash was caused by WKView in autorelease pool invoking stopUpdatingCallback after
613         GeolocationTransitionToLowAccuracyStateTracker in the stack had been destroyed,
614         resulting in the use-after-free.
615
616         Made the tests more robust by clearing geolocation provider before exiting each test
617         since we can't really prevent WKView from entering an autorelease pool.
618
619         Also made WebKit.GeolocationTransitionToLowAccuracy wait for the success callback
620         instead of simply the end of the navigation so that the test would continue to work
621         even if a web content process was created for the second web view (lowAccuracyWebView)
622
623         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
624         (TestWebKitAPI::setupGeolocationProvider): Moved "*" to match the WebKit coding style guideline.
625         (TestWebKitAPI::clearGeolocationProvider): Added.
626         (TestWebKitAPI::runJavaScriptAlert): Added.
627         (TestWebKitAPI::didFinishNavigation): Deleted.
628         * TestWebKitAPI/Tests/WebKit/geolocationWatchPosition.html:
629
630 2018-11-13  Chris Dumez  <cdumez@apple.com>
631
632         WKProcessPool.InitialWarmedProcessUsed API is failing with PSON enabled
633         https://bugs.webkit.org/show_bug.cgi?id=191618
634
635         Reviewed by Ryosuke Niwa.
636
637         Update API test to explicitly disable automatic process prewarning since it is testing
638         manual prewarming.
639
640         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
641         (TEST):
642
643 2018-11-13  Chris Dumez  <cdumez@apple.com>
644
645         Several Service Worker API tests are failing when enabling PSON
646         https://bugs.webkit.org/show_bug.cgi?id=191619
647
648         Reviewed by Youenn Fablet.
649
650         Update tests to use _webProcessCountIgnoringPrewarmed instead of _webProcessCount so that they are
651         not impacted by process prewarming.
652
653         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
654
655 2018-11-13  Wenson Hsieh  <wenson_hsieh@apple.com>
656
657         [iOS] Do not show selection UI for editable elements with opacity near zero
658         https://bugs.webkit.org/show_bug.cgi?id=191442
659         <rdar://problem/45958625>
660
661         Reviewed by Simon Fraser.
662
663         Add a couple of new testing helpers to UIScriptController.
664
665         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
666         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
667         (WTR::UIScriptController::textSelectionRangeRects const):
668         (WTR::UIScriptController::selectionCaretViewRect const):
669         (WTR::UIScriptController::selectionRangeViewRects const):
670         * TestRunnerShared/UIScriptContext/UIScriptController.h:
671         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
672         (WTR::UIScriptController::textSelectionRangeRects const):
673
674         Rename `selectionRangeViewRects` to `textSelectionRangeRects`. This allows us to draw a distinction between
675         `textSelectionRangeRects`/`textSelectionCaretRect`, which retrieve information about selection rects known
676         to the text interaction assistant, and `selectionCaretViewRect`/`selectionRangeViewRects`, which retrieve the
677         actual frames of the selection views used to draw overlaid selection UI. This difference is important in the
678         new layout tests added in this patch, which only suppress caret rendering (i.e. selection views remain hidden).
679
680         Also, drive-by fix a leaked `NSMutableArray`.
681
682         (WTR::UIScriptController::selectionStartGrabberViewRect const):
683         (WTR::UIScriptController::selectionEndGrabberViewRect const):
684         (WTR::UIScriptController::selectionCaretViewRect const):
685         (WTR::UIScriptController::selectionRangeViewRects const):
686
687         Testing helpers to grab the frames of caret and selection views, in WKContentView's coordinate space. These
688         rects are also clamped to WKContentView bounds.
689
690 2018-11-13  Daniel Bates  <dabates@apple.com>
691
692         Consolidate WebKit UIKitSPI.h and UIKitTestSPI.h
693         https://bugs.webkit.org/show_bug.cgi?id=173341
694         <rdar://problem/32752890>
695
696         Reviewed by Simon Fraser.
697
698         There is little value to making a distinction between forward declarations
699         of UIKit SPI needed in the WebKit layer and just for testing. Moreover,
700         the contents of these two headers can conflict with each other following
701         r218275 as DumpRenderTree includes both headers. Instead we should remove
702         UIKitTestSPI.h and have WebKitTestRunner include the WebKit variant, UIKitSPI.h.
703
704         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
705         * DumpRenderTree/mac/DumpRenderTree.mm:
706         * TestRunnerShared/spi/UIKitTestSPI.h: Removed.
707         * WebKitTestRunner/Configurations/Base.xcconfig:
708         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
709         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
710         * WebKitTestRunner/ios/GeneratedTouchesDebugWindow.mm:
711         * WebKitTestRunner/ios/HIDEventGenerator.h:
712         * WebKitTestRunner/ios/HIDEventGenerator.mm:
713         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
714         * WebKitTestRunner/ios/TestControllerIOS.mm:
715         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
716         * WebKitTestRunner/ios/mainIOS.mm:
717
718 2018-11-13  Takashi Komori  <Takashi.Komori@sony.com>
719
720         Remove WebKitTestRunnerLib's build warnings.
721         https://bugs.webkit.org/show_bug.cgi?id=191580
722
723         Reviewed by Fujii Hironori.
724
725         Include cmakeconfig.h in precompiled header.
726
727         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
728
729 2018-11-12  Darshan Kadu  <darsh7807@gmail.com>
730
731         Implement Cache API support for WPE/GTK
732         https://bugs.webkit.org/show_bug.cgi?id=178316
733
734         Reviewed by Michael Catanzaro.
735
736         Called WKWebsiteDataStoreSetCacheStoragePerOriginQuota function to set the cache limit to 400 * 1200
737         on all the platforms in TestController.cpp. Also, removed the setCacheStoragePerOriginQuota call from TestControllerCocoa.mm
738
739         * WebKitTestRunner/TestController.cpp:
740         (WTR::TestController::generatePageConfiguration):
741         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
742         (WTR::initializeWebViewConfiguration):
743
744 2018-11-12  Christopher Reid  <chris.reid@sony.com>
745
746         [Curl] Reject entire cookie if the domain fails a tailmatch.
747         https://bugs.webkit.org/show_bug.cgi?id=191406
748
749         Reviewed by Youenn Fablet.
750
751         Added unittests for Curl cookie implementation.
752
753         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
754         (TestWebKitAPI::Curl::CurlCookies::RejectTailmatchFailureDomain):
755
756 2018-11-12  Alex Christensen  <achristensen@webkit.org>
757
758         [iOS] Implement safe browsing in WebKit
759         https://bugs.webkit.org/show_bug.cgi?id=191441
760
761         Reviewed by Tim Horton.
762
763         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
764         (checkTitleAndClick):
765         (TEST):
766
767 2018-11-12  Basuke Suzuki  <basuke.suzuki@sony.com>
768
769         [Curl] Add API Test for Curl cookie backend.
770         https://bugs.webkit.org/show_bug.cgi?id=191493
771
772         Reviewed by Youenn Fablet.
773
774         Add unit test to TestWebCore.
775
776         * TestWebKitAPI/PlatformWin.cmake:
777         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp: Added.
778
779 2018-11-12  Tim Horton  <timothy_horton@apple.com>
780
781         Make it possible to edit images inline
782         https://bugs.webkit.org/show_bug.cgi?id=191352
783         <rdar://problem/30107985>
784
785         Reviewed by Dean Jackson.
786
787         * WebKitTestRunner/TestController.cpp:
788         (WTR::updateTestOptionsFromTestHeader):
789         * WebKitTestRunner/TestOptions.h:
790         (WTR::TestOptions::hasSameInitializationOptions const):
791         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
792         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
793         (WTR::TestController::platformCreateWebView):
794         Add a test option to enable editable images.
795
796         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
797         (WTR::UIScriptController::drawSquareInEditableImage):
798         (WTR::UIScriptController::numberOfStrokesInEditableImage):
799         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
800         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
801         (WTR::UIScriptController::drawSquareInEditableImage):
802         (WTR::UIScriptController::numberOfStrokesInEditableImage):
803         * TestRunnerShared/UIScriptContext/UIScriptController.h:
804         * TestRunnerShared/spi/PencilKitTestSPI.h: Added.
805         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
806         (WTR::findEditableImageCanvas):
807         (WTR::UIScriptController::drawSquareInEditableImage):
808         (WTR::UIScriptController::numberOfStrokesInEditableImage):
809         Add the ability to draw on a PKCanvasView that is a subview of the WKWebView,
810         and also to retrieve the number of strokes currently on the PKCanvasView.
811         Currently this just takes the first canvas; we might need to make it
812         take an identifier or something in the future if we need tests with multiple
813         canvases. The indirect testing mechanism is required because PKCanvasView
814         can currently not actually paint its strokes in the Simulator.
815
816 2018-11-12  Ryan Haddad  <ryanhaddad@apple.com>
817
818         [MediaStream] Screen capture should be an experimental feature on OSX only
819         https://bugs.webkit.org/show_bug.cgi?id=191552
820
821         Unreviewed test gardening.
822
823         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm: Only run these tests on macOS.
824
825 2018-11-12  Don Olmstead  <don.olmstead@sony.com>
826
827         Shipped PNGs include bad profiles: iCCP: known incorrect sRGB profile
828         https://bugs.webkit.org/show_bug.cgi?id=189230
829         <rdar://problem/44050379>
830
831         Reviewed by Joseph Pecoraro.
832
833         Runs all png images through zopflipng. This results in a smaller file
834         size and takes care of this issue as a byproduct.
835
836         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-green.png:
837         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-red.png:
838         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/ElCapitan.png:
839         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/ElCapitan@2x.png:
840         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/GTK.png:
841         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/GTK@2x.png:
842         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/HighSierra.png:
843         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/HighSierra@2x.png:
844         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10.png:
845         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10@2x.png:
846         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10Simulator.png:
847         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10Simulator@2x.png:
848         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11.png:
849         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11@2x.png:
850         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11Simulator.png:
851         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11Simulator@2x.png:
852         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS12.png:
853         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS12@2x.png:
854         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS12Simulator.png:
855         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS12Simulator@2x.png:
856         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9.png:
857         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9@2x.png:
858         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9Simulator.png:
859         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9Simulator@2x.png:
860         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice.png:
861         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice@2x.png:
862         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSSimulator.png:
863         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSSimulator@2x.png:
864         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mavericks.png:
865         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mavericks@2x.png:
866         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mojave.png:
867         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mojave@2x.png:
868         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion.png:
869         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion@2x.png:
870         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/PlatformRing.png:
871         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/PlatformRing@2x.png:
872         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
873         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png:
874         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE.png:
875         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE@2x.png:
876         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows10.png:
877         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows10@2x.png:
878         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows7.png:
879         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows7@2x.png:
880         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows8.png:
881         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows8@2x.png:
882         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WindowsXP.png:
883         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WindowsXP@2x.png:
884         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Yosemite.png:
885         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Yosemite@2x.png:
886
887 2018-11-12  Tim Horton  <timothy_horton@apple.com>
888
889         Modernize WebKit Tools Xcode projects for localization's sake
890         https://bugs.webkit.org/show_bug.cgi?id=191495
891
892         Reviewed by Alexey Proskuryakov.
893
894         * ContentExtensionTester/ContentExtensionTester.xcodeproj/project.pbxproj:
895         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
896         * EditingHistory/EditingHistory.xcodeproj/project.pbxproj:
897         * FontWithFeatures/FontWithFeatures.xcodeproj/project.pbxproj:
898         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
899         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
900         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
901         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
902         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
903         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
904         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
905         * lldb/lldbWebKitTester/lldbWebKitTester.xcodeproj/project.pbxproj:
906         These are less important because they're not localized, but since
907         I made the style checker complain, it now complains any time anyone
908         touches any of these projects... so upgrade them.
909
910 2018-11-12  Jonathan Bedard  <jbedard@apple.com>
911
912         webkitpy: Check for specific process instead of using data migrator
913         https://bugs.webkit.org/show_bug.cgi?id=191551
914         <rdar://problem/45993156>
915
916         Rubber-stamped by Aakash Jain.
917
918         It's possible for the data migrator process to be stuck, but for a simulator to be
919         usable. Use device-specific processes to detect when a device is usable.
920
921         * Scripts/webkitpy/xcode/simulated_device.py:
922         (SimulatedDeviceManager._wait_until_device_is_usable):
923         (SimulatedDeviceManager):
924         (SimulatedDeviceManager.initialize_devices): Explicitly wait until a device is usable
925         since this implies that a device is booted.
926         (SimulatedDeviceManager.swap): Ditto.
927         (SimulatedDevice.is_usable): Check that a device is booted and that a device-specific
928         process indicating the device is usable can be found.
929         (SimulatedDeviceManager.wait_until_data_migration_is_done): Deleted.
930         * Scripts/webkitpy/xcode/simulated_device_unittest.py: Update simctl_json so that
931         it triggers the logic in is_usable()
932
933 2018-11-12  Takashi Komori  <Takashi.Komori@sony.com>
934
935         Resurrect WebKitTestRunner for Windows port
936         https://bugs.webkit.org/show_bug.cgi?id=189257
937
938         Reviewed by Fujii Hironori.
939
940         Implement WebKitTestRunner for WinCairo.
941
942         * PlatformWin.cmake:
943         * Scripts/build-webkittestrunner:
944         * WebKitTestRunner/CMakeLists.txt:
945         * WebKitTestRunner/EventSenderProxy.h:
946         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
947         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
948         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
949         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
950         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
951         (WTR::rangeToStr):
952         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
953         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
954         (WTR::TestRunner::TestRunner):
955         * WebKitTestRunner/InjectedBundle/TestRunner.h:
956         * WebKitTestRunner/InjectedBundle/win/AccessibilityControllerWin.cpp: Added.
957         (WTR::AccessibilityController::resetToConsistentState):
958         (WTR::AccessibilityController::accessibleElementById):
959         (WTR::AccessibilityController::platformName):
960         (WTR::AccessibilityController::rootElement):
961         (WTR::AccessibilityController::focusedElement):
962         (WTR::AccessibilityController::addNotificationListener):
963         (WTR::AccessibilityController::removeNotificationListener):
964         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp: Added.
965         (WTR::AccessibilityUIElement::AccessibilityUIElement):
966         (WTR::AccessibilityUIElement::~AccessibilityUIElement):
967         (WTR::AccessibilityUIElement::isEqual):
968         (WTR::AccessibilityUIElement::getChildren):
969         (WTR::AccessibilityUIElement::getChildrenWithRange):
970         (WTR::AccessibilityUIElement::childrenCount):
971         (WTR::AccessibilityUIElement::elementAtPoint):
972         (WTR::AccessibilityUIElement::indexOfChild):
973         (WTR::AccessibilityUIElement::childAtIndex):
974         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
975         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
976         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
977         (WTR::AccessibilityUIElement::ariaControlsElementAtIndex):
978         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
979         (WTR::AccessibilityUIElement::rowAtIndex):
980         (WTR::AccessibilityUIElement::selectedChildAtIndex const):
981         (WTR::AccessibilityUIElement::selectedChildrenCount const):
982         (WTR::AccessibilityUIElement::selectedRowAtIndex):
983         (WTR::AccessibilityUIElement::titleUIElement):
984         (WTR::AccessibilityUIElement::parentElement):
985         (WTR::AccessibilityUIElement::disclosedByRow):
986         (WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
987         (WTR::AccessibilityUIElement::attributesOfDocumentLinks):
988         (WTR::AccessibilityUIElement::attributesOfChildren):
989         (WTR::AccessibilityUIElement::allAttributes):
990         (WTR::AccessibilityUIElement::stringAttributeValue):
991         (WTR::AccessibilityUIElement::numberAttributeValue):
992         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue const):
993         (WTR::AccessibilityUIElement::rowHeaders const):
994         (WTR::AccessibilityUIElement::columnHeaders const):
995         (WTR::AccessibilityUIElement::uiElementAttributeValue const):
996         (WTR::AccessibilityUIElement::boolAttributeValue):
997         (WTR::AccessibilityUIElement::isAttributeSettable):
998         (WTR::AccessibilityUIElement::isAttributeSupported):
999         (WTR::AccessibilityUIElement::parameterizedAttributeNames):
1000         (WTR::AccessibilityUIElement::role):
1001         (WTR::AccessibilityUIElement::subrole):
1002         (WTR::AccessibilityUIElement::roleDescription):
1003         (WTR::AccessibilityUIElement::computedRoleString):
1004         (WTR::AccessibilityUIElement::title):
1005         (WTR::AccessibilityUIElement::description):
1006         (WTR::AccessibilityUIElement::orientation const):
1007         (WTR::AccessibilityUIElement::stringValue):
1008         (WTR::AccessibilityUIElement::language):
1009         (WTR::AccessibilityUIElement::helpText const):
1010         (WTR::AccessibilityUIElement::x):
1011         (WTR::AccessibilityUIElement::y):
1012         (WTR::AccessibilityUIElement::width):
1013         (WTR::AccessibilityUIElement::height):
1014         (WTR::AccessibilityUIElement::clickPointX):
1015         (WTR::AccessibilityUIElement::clickPointY):
1016         (WTR::AccessibilityUIElement::intValue const):
1017         (WTR::AccessibilityUIElement::minValue):
1018         (WTR::AccessibilityUIElement::maxValue):
1019         (WTR::AccessibilityUIElement::valueDescription):
1020         (WTR::AccessibilityUIElement::insertionPointLineNumber):
1021         (WTR::AccessibilityUIElement::isPressActionSupported):
1022         (WTR::AccessibilityUIElement::isIncrementActionSupported):
1023         (WTR::AccessibilityUIElement::isDecrementActionSupported):
1024         (WTR::AccessibilityUIElement::isEnabled):
1025         (WTR::AccessibilityUIElement::isRequired const):
1026         (WTR::AccessibilityUIElement::isFocused const):
1027         (WTR::AccessibilityUIElement::isSelected const):
1028         (WTR::AccessibilityUIElement::isSelectedOptionActive const):
1029         (WTR::AccessibilityUIElement::isExpanded const):
1030         (WTR::AccessibilityUIElement::isChecked const):
1031         (WTR::AccessibilityUIElement::isIndeterminate const):
1032         (WTR::AccessibilityUIElement::hierarchicalLevel const):
1033         (WTR::AccessibilityUIElement::speakAs):
1034         (WTR::AccessibilityUIElement::ariaIsGrabbed const):
1035         (WTR::AccessibilityUIElement::ariaDropEffects const):
1036         (WTR::AccessibilityUIElement::lineForIndex):
1037         (WTR::AccessibilityUIElement::rangeForLine):
1038         (WTR::AccessibilityUIElement::rangeForPosition):
1039         (WTR::AccessibilityUIElement::boundsForRange):
1040         (WTR::AccessibilityUIElement::stringForRange):
1041         (WTR::AccessibilityUIElement::attributedStringForRange):
1042         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
1043         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
1044         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1045         (WTR::AccessibilityUIElement::selectTextWithCriteria):
1046         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
1047         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
1048         (WTR::AccessibilityUIElement::attributesOfColumns):
1049         (WTR::AccessibilityUIElement::attributesOfRows):
1050         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
1051         (WTR::AccessibilityUIElement::attributesOfHeader):
1052         (WTR::AccessibilityUIElement::rowCount):
1053         (WTR::AccessibilityUIElement::columnCount):
1054         (WTR::AccessibilityUIElement::indexInTable):
1055         (WTR::AccessibilityUIElement::rowIndexRange):
1056         (WTR::AccessibilityUIElement::columnIndexRange):
1057         (WTR::AccessibilityUIElement::cellForColumnAndRow):
1058         (WTR::AccessibilityUIElement::horizontalScrollbar const):
1059         (WTR::AccessibilityUIElement::verticalScrollbar const):
1060         (WTR::AccessibilityUIElement::selectedTextRange):
1061         (WTR::AccessibilityUIElement::setSelectedTextRange):
1062         (WTR::AccessibilityUIElement::increment):
1063         (WTR::AccessibilityUIElement::decrement):
1064         (WTR::AccessibilityUIElement::showMenu):
1065         (WTR::AccessibilityUIElement::press):
1066         (WTR::AccessibilityUIElement::setSelectedChild const):
1067         (WTR::AccessibilityUIElement::setSelectedChildAtIndex const):
1068         (WTR::AccessibilityUIElement::removeSelectionAtIndex const):
1069         (WTR::AccessibilityUIElement::clearSelectedChildren const):
1070         (WTR::AccessibilityUIElement::accessibilityValue const):
1071         (WTR::AccessibilityUIElement::documentEncoding):
1072         (WTR::AccessibilityUIElement::documentURI):
1073         (WTR::AccessibilityUIElement::url):
1074         (WTR::AccessibilityUIElement::addNotificationListener):
1075         (WTR::AccessibilityUIElement::removeNotificationListener):
1076         (WTR::AccessibilityUIElement::isFocusable const):
1077         (WTR::AccessibilityUIElement::isSelectable const):
1078         (WTR::AccessibilityUIElement::isMultiSelectable const):
1079         (WTR::AccessibilityUIElement::isVisible const):
1080         (WTR::AccessibilityUIElement::isOffScreen const):
1081         (WTR::AccessibilityUIElement::isCollapsed const):
1082         (WTR::AccessibilityUIElement::isIgnored const):
1083         (WTR::AccessibilityUIElement::isSingleLine const):
1084         (WTR::AccessibilityUIElement::isMultiLine const):
1085         (WTR::AccessibilityUIElement::hasPopup const):
1086         (WTR::AccessibilityUIElement::takeFocus):
1087         (WTR::AccessibilityUIElement::takeSelection):
1088         (WTR::AccessibilityUIElement::addSelection):
1089         (WTR::AccessibilityUIElement::removeSelection):
1090         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
1091         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
1092         (WTR::AccessibilityUIElement::textMarkerRangeLength):
1093         (WTR::AccessibilityUIElement::previousTextMarker):
1094         (WTR::AccessibilityUIElement::nextTextMarker):
1095         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
1096         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
1097         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
1098         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
1099         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
1100         (WTR::AccessibilityUIElement::startTextMarkerForBounds):
1101         (WTR::AccessibilityUIElement::textMarkerForPoint):
1102         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
1103         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRange):
1104         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions):
1105         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
1106         (WTR::AccessibilityUIElement::indexForTextMarker):
1107         (WTR::AccessibilityUIElement::isTextMarkerValid):
1108         (WTR::AccessibilityUIElement::textMarkerForIndex):
1109         (WTR::AccessibilityUIElement::startTextMarker):
1110         (WTR::AccessibilityUIElement::endTextMarker):
1111         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
1112         (WTR::AccessibilityUIElement::scrollToMakeVisible):
1113         (WTR::AccessibilityUIElement::scrollToGlobalPoint):
1114         (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
1115         (WTR::AccessibilityUIElement::supportedActions const):
1116         (WTR::AccessibilityUIElement::pathDescription const):
1117         (WTR::AccessibilityUIElement::mathPostscriptsDescription const):
1118         (WTR::AccessibilityUIElement::mathPrescriptsDescription const):
1119         (WTR::AccessibilityUIElement::classList const):
1120         (WTR::AccessibilityUIElement::characterAtOffset):
1121         (WTR::AccessibilityUIElement::wordAtOffset):
1122         (WTR::AccessibilityUIElement::lineAtOffset):
1123         (WTR::AccessibilityUIElement::sentenceAtOffset):
1124         * WebKitTestRunner/InjectedBundle/win/ActivateFontsWin.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp.
1125         (WTR::activateFonts):
1126         (WTR::installFakeHelvetica):
1127         (WTR::uninstallFakeHelvetica):
1128         * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp.
1129         (WTR::InjectedBundle::platformInitialize):
1130         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.cpp: Added.
1131         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h: Copied from Tools/WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp.
1132         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp.
1133         (WTR::TestRunner::pathToLocalResource):
1134         (WTR::TestRunner::inspectorTestStubURL):
1135         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
1136         (WTR::TestRunner::platformInitialize):
1137         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
1138         (WTR::TestRunner::installFakeHelvetica):
1139         * WebKitTestRunner/PlatformWebView.h:
1140         * WebKitTestRunner/PlatformWin.cmake: Added.
1141         * WebKitTestRunner/TestController.cpp:
1142         (WTR::TestController::resetStateToConsistentValues):
1143         (WTR::createTestURL):
1144         * WebKitTestRunner/TestInvocation.cpp:
1145         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
1146         * WebKitTestRunner/win/EventSenderProxyWin.cpp: Added.
1147         (WTR::EventSenderProxy::EventSenderProxy):
1148         (WTR::EventSenderProxy::~EventSenderProxy):
1149         (WTR::EventSenderProxy::mouseDown):
1150         (WTR::EventSenderProxy::mouseUp):
1151         (WTR::EventSenderProxy::mouseMoveTo):
1152         (WTR::EventSenderProxy::mouseScrollBy):
1153         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
1154         (WTR::EventSenderProxy::continuousMouseScrollBy):
1155         (WTR::EventSenderProxy::leapForward):
1156         (WTR::EventSenderProxy::keyDown):
1157         * WebKitTestRunner/win/PlatformWebViewWin.cpp: Added.
1158         (WTR::registerWindowClass):
1159         (WTR::PlatformWebView::PlatformWebView):
1160         (WTR::PlatformWebView::~PlatformWebView):
1161         (WTR::PlatformWebView::resizeTo):
1162         (WTR::PlatformWebView::page):
1163         (WTR::PlatformWebView::focus):
1164         (WTR::PlatformWebView::windowFrame):
1165         (WTR::PlatformWebView::setWindowFrame):
1166         (WTR::PlatformWebView::didInitializeClients):
1167         (WTR::PlatformWebView::addChromeInputField):
1168         (WTR::PlatformWebView::removeChromeInputField):
1169         (WTR::PlatformWebView::addToWindow):
1170         (WTR::PlatformWebView::removeFromWindow):
1171         (WTR::PlatformWebView::setWindowIsKey):
1172         (WTR::PlatformWebView::makeWebViewFirstResponder):
1173         (WTR::generateCairoSurfaceFromBitmap):
1174         (WTR::PlatformWebView::windowSnapshotImage):
1175         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1176         (WTR::PlatformWebView::setNavigationGesturesEnabled):
1177         (WTR::PlatformWebView::forceWindowFramesChanged):
1178         (WTR::PlatformWebView::drawsBackground const):
1179         (WTR::PlatformWebView::setDrawsBackground):
1180         * WebKitTestRunner/win/TestControllerWin.cpp: Added.
1181         (WTR::exceptionFilter):
1182         (WTR::runRunLoopUntil):
1183         (WTR::TestController::notifyDone):
1184         (WTR::TestController::setHidden):
1185         (WTR::TestController::platformInitialize):
1186         (WTR::TestController::platformPreferences):
1187         (WTR::TestController::platformDestroy):
1188         (WTR::toWK):
1189         (WTR::TestController::platformInitializeContext):
1190         (WTR::TestController::platformRunUntil):
1191         (WTR::TestController::platformDidCommitLoadForFrame):
1192         (WTR::TestController::initializeInjectedBundlePath):
1193         (WTR::TestController::initializeTestPluginDirectory):
1194         (WTR::TestController::runModal):
1195         (WTR::TestController::platformContext):
1196         (WTR::TestController::platformLibraryPathForTesting):
1197         (WTR::TestController::platformConfigureViewForTest):
1198         (WTR::TestController::platformResetPreferencesToConsistentValues):
1199         (WTR::TestController::updatePlatformSpecificTestOptionsForTest const):
1200         * WebKitTestRunner/win/WebKitTestRunnerPrefix.cpp: Added.
1201         * WebKitTestRunner/win/main.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp.
1202         (dllLauncherEntryPoint):
1203
1204 2018-11-12  Alicia Boya García  <aboya@igalia.com>
1205
1206         [MSE][GStreamer] Introduce AbortableTaskQueue
1207         https://bugs.webkit.org/show_bug.cgi?id=190902
1208
1209         Reviewed by Xabier Rodriguez-Calvar.
1210
1211         Tests for AbortableTaskQueue are included.
1212
1213         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1214         * TestWebKitAPI/PlatformGTK.cmake:
1215         * TestWebKitAPI/Tests/WebCore/AbortableTaskQueue.cpp: Added.
1216         (TestWebKitAPI::TEST):
1217         (TestWebKitAPI::FancyResponse::FancyResponse):
1218         (TestWebKitAPI::FancyResponse::operator=):
1219         (TestWebKitAPI::DeterministicScheduler::DeterministicScheduler):
1220         (TestWebKitAPI::DeterministicScheduler::ThreadContext::ThreadContext):
1221         (TestWebKitAPI::DeterministicScheduler::ThreadContext::waitMyTurn):
1222         (TestWebKitAPI::DeterministicScheduler::ThreadContext::yieldToThread):
1223
1224 2018-11-11  Fujii Hironori  <Hironori.Fujii@sony.com>
1225
1226         run-bindings-tests is timing out in some WinCairo bots
1227         https://bugs.webkit.org/show_bug.cgi?id=191348
1228
1229         Reviewed by Alex Christensen.
1230
1231         BuildBot kills run-bindings-tests if it outputs nothing for 20
1232         minutes. run-bindings-tests runs very slowly in WinCairo Docker,
1233         and it takes more than 30 minutes to finish. And, Windows Python
1234         buffers the progress output.
1235
1236         * Scripts/webkitpy/bindings/main.py:
1237         (BindingsTests.detect_changes): Call sys.stdout.flush() after the
1238         test case result is output.
1239
1240 2018-11-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1241
1242         Implement a new edit command to change the enclosing list type
1243         https://bugs.webkit.org/show_bug.cgi?id=191487
1244         <rdar://problem/45955922>
1245
1246         Reviewed by Ryosuke Niwa.
1247
1248         Add a new API test to verify that `-[WKWebView _changeListType:]` is hooked up to the corresponding editing
1249         command in WebCore. See the new layout test for a test that exercises more nuanced corner cases.
1250
1251         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1252         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
1253         (-[TestWKWebView setPosition:offset:]):
1254         (-[TestWKWebView setBase:baseOffset:extent:extentOffset:]):
1255         (TestWebKitAPI::webViewForEditActionTestingWithPageNamed):
1256         (TestWebKitAPI::TEST):
1257         * TestWebKitAPI/Tests/WebKitCocoa/editable-nested-lists.html: Added.
1258
1259 2018-11-11  Dan Bernstein  <mitz@apple.com>
1260
1261         ProcessPoolConfiguration::copy() doesn’t copy m_customWebContentServiceBundleIdentifier
1262         https://bugs.webkit.org/show_bug.cgi?id=191514
1263
1264         Reviewed by Geoffrey Garen.
1265
1266         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1267         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm: Added.
1268         (TEST):
1269
1270 2018-11-11  Benjamin Poulain  <benjamin@webkit.org>
1271
1272         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
1273         https://bugs.webkit.org/show_bug.cgi?id=191492
1274
1275         Reviewed by Alex Christensen.
1276
1277         Update file name.
1278
1279         * DumpRenderTree/mac/DumpRenderTree.mm:
1280         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1281         * WebKitTestRunner/mac/TestControllerMac.mm:
1282
1283 2018-11-10  Benjamin Poulain  <benjamin@webkit.org>
1284
1285         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
1286         https://bugs.webkit.org/show_bug.cgi?id=191492
1287
1288         Reviewed by Alex Christensen.
1289
1290         * DumpRenderTree/mac/DumpRenderTree.mm:
1291         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1292         * WebKitTestRunner/mac/TestControllerMac.mm:
1293
1294 2018-11-10  Ryan Haddad  <ryanhaddad@apple.com>
1295
1296         Unreviewed, rolling out r238065.
1297
1298         Breaks internal builds.
1299
1300         Reverted changeset:
1301
1302         "Make it possible to edit images inline"
1303         https://bugs.webkit.org/show_bug.cgi?id=191352
1304         https://trac.webkit.org/changeset/238065
1305
1306 2018-11-10  Michael Catanzaro  <mcatanzaro@igalia.com>
1307
1308         [WPE][GTK] API test /webkit/WebKitSettings/webkit-settings is failing
1309         https://bugs.webkit.org/show_bug.cgi?id=191221
1310
1311         Unreviewed, fix a typo from the previous patch. After disabling the setting, we should test
1312         that it is disabled, but we're testing that it is enabled, because I failed to update this
1313         line.
1314
1315         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1316         (testWebKitSettings):
1317
1318 2018-11-10  Tim Horton  <timothy_horton@apple.com>
1319
1320         Make it possible to edit images inline
1321         https://bugs.webkit.org/show_bug.cgi?id=191352
1322         <rdar://problem/30107985>
1323
1324         Reviewed by Dean Jackson.
1325
1326         * WebKitTestRunner/TestController.cpp:
1327         (WTR::updateTestOptionsFromTestHeader):
1328         * WebKitTestRunner/TestOptions.h:
1329         (WTR::TestOptions::hasSameInitializationOptions const):
1330         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1331         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1332         (WTR::TestController::platformCreateWebView):
1333         Add a test option to enable editable images.
1334
1335         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1336         (WTR::UIScriptController::drawSquareInEditableImage):
1337         (WTR::UIScriptController::numberOfStrokesInEditableImage):
1338         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1339         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1340         (WTR::UIScriptController::drawSquareInEditableImage):
1341         (WTR::UIScriptController::numberOfStrokesInEditableImage):
1342         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1343         * TestRunnerShared/spi/PencilKitTestSPI.h: Added.
1344         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1345         (WTR::findEditableImageCanvas):
1346         (WTR::UIScriptController::drawSquareInEditableImage):
1347         (WTR::UIScriptController::numberOfStrokesInEditableImage):
1348         Add the ability to draw on a PKCanvasView that is a subview of the WKWebView,
1349         and also to retrieve the number of strokes currently on the PKCanvasView.
1350         Currently this just takes the first canvas; we might need to make it
1351         take an identifier or something in the future if we need tests with multiple
1352         canvases. The indirect testing mechanism is required because PKCanvasView
1353         can currently not actually paint its strokes in the Simulator.
1354
1355 2018-11-09  Chris Dumez  <cdumez@apple.com>
1356
1357         Suspended page persists even after back/forward list item is gone
1358         https://bugs.webkit.org/show_bug.cgi?id=191488
1359         <rdar://problem/45953006>
1360
1361         Reviewed by Geoffrey Garen.
1362
1363         Add API test coverage.
1364
1365         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1366
1367 2018-11-09  Wenson Hsieh  <wenson_hsieh@apple.com>
1368
1369         [Cocoa] Implement SPI on WKWebView to increase and decrease list levels
1370         https://bugs.webkit.org/show_bug.cgi?id=191471
1371         <rdar://problem/45952472>
1372
1373         Reviewed by Tim Horton.
1374
1375         Add an API test to ensure that list levels can be incremented and decremented via WKWebView SPI.
1376
1377         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
1378         (TestWebKitAPI::webViewForEditActionTesting):
1379         (TestWebKitAPI::TEST):
1380
1381 2018-11-09  Basuke Suzuki  <basuke.suzuki@sony.com>
1382
1383         [Curl][WebKit] Implement Proxy configuration API.
1384         https://bugs.webkit.org/show_bug.cgi?id=189053
1385
1386         Reviewed by Youenn Fablet.
1387
1388         Added Proxy Settings dialog to call newly added API.
1389
1390         * MiniBrowser/win/BrowserWindow.h:
1391         * MiniBrowser/win/Common.cpp:
1392         (askProxySettings):
1393         (askCredential):
1394         (authDialogProc): Deleted.
1395         * MiniBrowser/win/Common.h:
1396         * MiniBrowser/win/DialogHelper.h: Added.
1397         (Dialog::run):
1398         (Dialog::doalogProc):
1399         (Dialog::handle):
1400         (Dialog::setup):
1401         (Dialog::update):
1402         (Dialog::validate):
1403         (Dialog::updateOkButton):
1404         (Dialog::command):
1405         (Dialog::ok):
1406         (Dialog::cancel):
1407         (Dialog::close):
1408         (Dialog::hDlg):
1409         (Dialog::item):
1410         (Dialog::setEnabled):
1411         (Dialog::setText):
1412         (Dialog::getText):
1413         (Dialog::getTextLength):
1414         (Dialog::RadioGroup::RadioGroup):
1415         (Dialog::RadioGroup::set):
1416         (Dialog::RadioGroup::get):
1417         (Dialog::radioGroup):
1418         * MiniBrowser/win/MainWindow.cpp:
1419         (MainWindow::WndProc):
1420         * MiniBrowser/win/MiniBrowserLib.rc:
1421         * MiniBrowser/win/MiniBrowserLibResource.h:
1422         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1423         (createWKURL):
1424         (WebKitBrowserWindow::WebKitBrowserWindow):
1425         (WebKitBrowserWindow::updateProxySettings):
1426         (WebKitBrowserWindow::loadURL):
1427         (WebKitBrowserWindow::loadHTMLString):
1428         (WebKitBrowserWindow::openProxySettings):
1429         * MiniBrowser/win/WebKitBrowserWindow.h:
1430         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
1431         (WebKitLegacyBrowserWindow::openProxySettings):
1432         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
1433
1434 2018-11-09  Wenson Hsieh  <wenson_hsieh@apple.com>
1435
1436         [Cocoa] Introduce WKWebView SPI to insert nested ordered and unordered lists
1437         https://bugs.webkit.org/show_bug.cgi?id=191410
1438         <rdar://problem/45898610>
1439
1440         Reviewed by Dean Jackson.
1441
1442         Move WKWebViewEditActions from iOS to WebKitCocoa, and enable the relevant WKWebViewEditActions tests on macOS.
1443         Additionally, add new API tests to verify that `-_pasteAsQuotation:` and `-_insertNested(Un)OrderedList:` are
1444         hooked up to their respective editing commands.
1445
1446         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1447         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm: Renamed from Tools/TestWebKitAPI/Tests/ios/WKWebViewEditActions.mm.
1448         (-[TestWKWebView querySelectorExists:]):
1449         (-[TestWKWebView insertString:]):
1450
1451         Add a helper method to insert a piece of text. This abstracts platform differences between iOS and macOS, by
1452         invoking the WKWebView directly on macOS and calling on the content view on iOS.
1453
1454         (TestWebKitAPI::webViewForEditActionTesting):
1455         (TestWebKitAPI::TEST):
1456
1457 2018-11-09  Philippe Normand  <pnormand@igalia.com>
1458
1459         [Flatpak] Refactoring and drive-by fixes
1460         https://bugs.webkit.org/show_bug.cgi?id=191421
1461
1462         Reviewed by Michael Catanzaro.
1463
1464         * Scripts/webkitdirs.pm:
1465         (inFlatpakSandbox): Flatpak now has a /.flatpak-info file when in
1466         the sandbox, so rely on this.
1467         * flatpak/flatpakutils.py:
1468         (expand_manifest): Pass explicit keywords to load_manifest() and
1469         remove unused local variable.
1470         (WebkitFlatpak.clean_args): Move hard-coded sdk/runtime infos to the manifest file.
1471         (WebkitFlatpak.run_in_sandbox): Add support for extra environment variables.
1472         (WebkitFlatpak.setup_dev_env): Stop build at final app. Refactor
1473         build_type handling a bit.
1474         * flatpak/org.webkit.CommonModules.yaml: Added.
1475         * flatpak/org.webkit.WPE.yaml: wpebackend upstream was renamed to libwpe.
1476         * flatpak/org.webkit.WebKit.yaml: Move common dependencies
1477         declaration to CommonModules, so it can be reused later when we
1478         add support for building extra libraries depending on WPE.
1479
1480 2018-11-08  Said Abou-Hallawa  <sabouhallawa@apple.com>
1481
1482 onal supported image formats
1483         https://bugs.webkit.org/show_bug.cgi?id=190454
1484
1485         Reviewed by Simon Fraser.
1486
1487         Test opening a TGA image in WebView which is not allowed by default. The
1488         TGA format will be allowed through WKWebViewConfiguration.
1489
1490         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1491         * TestWebKitAPI/Tests/WebKitCocoa/100x100-red.tga: Added.
1492         * TestWebKitAPI/Tests/WebKitCocoa/400x400-green.png: Added.
1493         * TestWebKitAPI/Tests/WebKitCocoa/AdditionalSupportedImageTypes.mm: Added.
1494         (runTest):
1495         (TEST):
1496
1497 2018-11-08  Jiewen Tan  <jiewen_tan@apple.com>
1498
1499         Unreviewed, a proper build fix for r237983
1500
1501         Don't include header PublicKeyCredential.h in CtapResponseTest.cpp.
1502
1503         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1504         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/CtapRequestTest.cpp.
1505         (TestWebKitAPI::TEST):
1506         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/CtapResponseTest.cpp.
1507         (TestWebKitAPI::getTestCorruptedSignResponse):
1508         (TestWebKitAPI::getTestCredentialRawIdBytes):
1509         (TestWebKitAPI::convertToVector):
1510         (TestWebKitAPI::TEST):
1511
1512 2018-11-08  Keith Rollin  <krollin@apple.com>
1513
1514         Create .xcfilelist files
1515         https://bugs.webkit.org/show_bug.cgi?id=191324
1516         <rdar://problem/45852819>
1517
1518         Reviewed by Alex Christensen.
1519
1520         As part of preparing for enabling XCBuild, create and use .xcfilelist
1521         files. These files are using during Run Script build phases in an
1522         Xcode project. If a Run Script build phase produces new files that are
1523         used later as inputs to subsequent build phases, XCBuild needs to know
1524         about these files. These files can be either specified in an "output
1525         files" section of the Run Script phase editor, or in .xcfilelist files
1526         that are associated with the Run Script build phase.
1527
1528         This patch takes the second approach. It consists of three sets of changes:
1529
1530         - Modify the DerivedSources.make files to have a
1531           'print_all_generated_files" target that produces a list of the files
1532           they create.
1533
1534         - Create a shell script that produces .xcfilelist files from the
1535           output of the previous step, as well as for the files created in the
1536           Generate Unified Sources build steps.
1537
1538         - Add the new .xcfilelist files to the associated projects.
1539
1540         Note that, with these changes, the Xcode workspace and projects can no
1541         longer be fully loaded into Xcode 9. Xcode will attempt to load the
1542         projects that have .xcfilelist files associated with them, but will
1543         fail and display a placeholder for those projects instead. It's
1544         expected that all developers are using Xcode 10 by now and that not
1545         being able to load into Xcode 9 is not a practical issue. Keep in mind
1546         that this is strictly an IDE issue, and that the projects can still be
1547         built with `xcodebuild`.
1548
1549         Also note that the shell script that creates the .xcfilelist files can
1550         also be used to verify that the set of files that's currently checked
1551         in is up-to-date. This checking can be used as part of a check-in hook
1552         or part of check-webkit-style to sooner catch cases where the
1553         .xcfilelist files need to be regenerated.
1554
1555         * DumpRenderTree/DerivedSources.make:
1556         * DumpRenderTree/DerivedSources.xcfilelist: Added.
1557         * Scripts/generate-xcfilelists: Added.
1558         * WebKitTestRunner/DerivedSources.make:
1559         * WebKitTestRunner/DerivedSources.xcfilelist: Added.
1560
1561 2018-11-08  Jiewen Tan  <jiewen_tan@apple.com>
1562
1563         Unreviewed, a quick build fix for r237983
1564
1565         Temporarily make CtapRequestTest.cpp/CtapResponseTest.cpp to mac only to avoid iOS build failures.
1566
1567         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
1568         * TestWebKitAPI/Tests/WebCore/mac/CtapRequestTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp.
1569         (TestWebKitAPI::TEST):
1570         * TestWebKitAPI/Tests/WebCore/mac/CtapResponseTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp.
1571         (TestWebKitAPI::getTestCorruptedSignResponse):
1572         (TestWebKitAPI::getTestCredentialRawIdBytes):
1573         (TestWebKitAPI::convertToVector):
1574         (TestWebKitAPI::TEST):
1575
1576 2018-11-05  Ryan Haddad  <ryanhaddad@apple.com>
1577
1578         Fix steps_unittest.py failures related to recent Win10/Win7 changes
1579         https://bugs.webkit.org/show_bug.cgi?id=191290
1580
1581         Reviewed by Alexey Proskuryakov.
1582
1583         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update expected results.
1584
1585 2018-11-08  Dean Jackson  <dino@apple.com>
1586
1587         Add a String literal that returns a String
1588         https://bugs.webkit.org/show_bug.cgi?id=191425
1589         <rdar://problem/45914556>
1590
1591         Reviewed by Sam Weinig.
1592
1593         Test _str.
1594
1595         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
1596         (TestWebKitAPI::TEST):
1597
1598 2018-11-08  Jonathan Bedard  <jbedard@apple.com>
1599
1600         webkitpy: Generalize trailing SDK specifier (Part 2)
1601         https://bugs.webkit.org/show_bug.cgi?id=191275
1602         <rdar://problem/45703660>
1603
1604         Rubber-stamped by Aakash Jain.
1605
1606         Re-landing this change, configuration issues have been resolved.
1607
1608         * Scripts/webkitpy/port/ios_device.py:
1609         (IOSDevicePort): Use normalized SDK.
1610         * Scripts/webkitpy/port/ios_simulator.py:
1611         (IOSSimulatorPort): Use normalized SDK.
1612         (IOSSimulatorPort._build_driver_flags): Use platform SDK in build driver flags.
1613
1614 2018-11-08  Jiewen Tan  <jiewen_tan@apple.com>
1615
1616         [WebAuthN] Import CTAP device request/response converters from Chromium
1617         https://bugs.webkit.org/show_bug.cgi?id=190784
1618         <rdar://problem/45460333>
1619
1620         Reviewed by Brent Fulgham.
1621
1622         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1623         * TestWebKitAPI/Tests/WebCore/CBORValueTest.cpp:
1624         (TestWebKitAPI::TEST):
1625         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp: Added.
1626         (TestWebKitAPI::TEST):
1627         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp: Added.
1628         (TestWebKitAPI::getTestCorruptedSignResponse):
1629         (TestWebKitAPI::getTestCredentialRawIdBytes):
1630         (TestWebKitAPI::convertToVector):
1631         (TestWebKitAPI::TEST):
1632         * TestWebKitAPI/Tests/WebCore/FidoTestData.h: Added.
1633
1634 2018-11-07  Caio Lima  <ticaiolima@gmail.com>
1635
1636         [BigInt] Add support to BigInt into ValueAdd
1637         https://bugs.webkit.org/show_bug.cgi?id=186177
1638
1639         Reviewed by Keith Miller.
1640
1641         * Scripts/run-jsc-benchmarks:
1642
1643 2018-11-07  Sihui Liu  <sihui_liu@apple.com>
1644
1645         RELEASE_ASSERT(!m_hardClosedForUserDelete) fails in WebCore::IDBServer::UniqueIDBDatabase::invokeOperationAndTransactionTimer
1646         https://bugs.webkit.org/show_bug.cgi?id=191326
1647         <rdar://problem/45769269>
1648
1649         Reviewed by Geoffrey Garen.
1650
1651         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1652         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.html: Added.
1653         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm: Added.
1654         (-[IndexedDBUserDeleteMessageHandler userContentController:didReceiveScriptMessage:]):
1655         (TEST):
1656
1657 2018-11-07  Daniel Bates  <dabates@apple.com>
1658
1659         Override +[UIKeyboard isInHardwareKeyboardMode] in WebKitTestRunner and DumpRenderTree
1660         https://bugs.webkit.org/show_bug.cgi?id=190141
1661
1662         Reviewed by Darin Adler.
1663
1664         Override +[UIKeyboard isInHardwareKeyboardMode] to always return NO so as to make test
1665         runs deterministic regardless of whether a hardware keyboard is attached.
1666
1667         * DumpRenderTree/mac/DumpRenderTree.mm:
1668         (overrideIsInHardwareKeyboardMode): Added.
1669         (prepareConsistentTestingEnvironment):
1670         * TestRunnerShared/spi/UIKitTestSPI.h: Forward declare SPI.
1671         * WebKitTestRunner/ios/TestControllerIOS.mm:
1672         (overrideIsInHardwareKeyboardMode): Added.
1673         (WTR::TestController::platformInitialize):
1674
1675 2018-11-07  Jonathan Bedard  <jbedard@apple.com>
1676
1677         Unreviewed, rolling out r237913.
1678
1679         Breaks running tests on Mac without iOS SDK installed
1680
1681         Reverted changeset:
1682
1683         "webkitpy: Generalize trailing SDK specifier (Part 2)"
1684         https://bugs.webkit.org/show_bug.cgi?id=191275
1685         https://trac.webkit.org/changeset/237913
1686
1687 2018-11-07  Zamiul Haque  <zhaque@apple.com>
1688
1689         Force a gregorian calendar to show for credit card expiration date inputs
1690         (autocomplete='cc-exp'*) regardless of default system settings.
1691         https://bugs.webkit.org/show_bug.cgi?id=191096
1692         rdar://problem/42640256
1693
1694         Reviewed by Tim Horton.
1695
1696         Implemented simulateForeignDefaultCalendar and calendarType to be used
1697         for changing the default calendar returned by the system (ie. [NSCalendar
1698         currentCalendar]) and getting the calendar type identifier of a presented date
1699         picker.
1700
1701         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1702         (WTR::UIScriptController::isShowingDataListSuggestions const):
1703         (WTR::UIScriptController::calendarType const):
1704         (WTR::UIScriptController::setDefaultCalendarType):
1705         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1706         (WTR::UIScriptController::calendarType const):
1707         (WTR::UIScriptController::setDefaultCalendarType):
1708         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1709         (WTR::UIScriptController::selectionEndGrabberViewRect const):
1710         (WTR::UIScriptController::calendarType const): Deleted.
1711         * WebKitTestRunner/TestController.cpp:
1712         * WebKitTestRunner/TestController.h:
1713         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1714         (WTR::UIScriptController::calendarType const):
1715         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1716         (WTR::swizzledCalendar):
1717         (WTR::TestController::getOverriddenCalendarIdentifier const):
1718         (WTR::TestController::setDefaultCalendarType):
1719         (WTR::TestController::cocoaResetStateToConsistentValues):
1720         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1721         (WTR::UIScriptController::selectionEndGrabberViewRect const):
1722         (WTR::UIScriptController::calendarType const): Deleted.
1723
1724 2018-11-06  Jonathan Bedard  <jbedard@apple.com>
1725
1726         webkitpy: Boot a single worker for custom devices
1727         https://bugs.webkit.org/show_bug.cgi?id=191312
1728         <rdar://problem/45848717>
1729
1730         Rubber-stamped by Aakash Jain.
1731
1732         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1733         (Manager.run): Custom devices only run a hand-full of tests. Booting multiple
1734         simulators is expensive and unneeded for these tests.
1735         * Scripts/webkitpy/port/ios.py:
1736         (IOSPort. child_processes): No reason to memoize this call, and it prevents
1737         overriding the number of child processes when booting custom devices.
1738
1739 2018-11-06  Jonathan Bedard  <jbedard@apple.com>
1740
1741         webkitpy: Generalize trailing SDK specifier (Part 2)
1742         https://bugs.webkit.org/show_bug.cgi?id=191275
1743         <rdar://problem/45703660>
1744
1745         Reviewed by Aakash Jain.
1746
1747         * Scripts/webkitpy/port/ios_device.py:
1748         (IOSDevicePort): Use normalized SDK.
1749         * Scripts/webkitpy/port/ios_simulator.py:
1750         (IOSSimulatorPort): Use normalized SDK.
1751         (IOSSimulatorPort._build_driver_flags): Use platform SDK in build driver flags.
1752
1753 2018-11-06  Justin Fan  <justin_fan@apple.com>
1754
1755         [WebGPU] Experimental prototype for WebGPURenderPipeline and WebGPUSwapChain
1756         https://bugs.webkit.org/show_bug.cgi?id=191291
1757
1758         Reviewed by Myles Maxfield.
1759
1760         Properly disable WEBGPU on all non-Metal platforms for now.
1761
1762         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1763
1764 2018-11-06  Aakash Jain  <aakash_jain@apple.com>
1765
1766         [ews-app] Add URL configuration for OpenSource EWS Django app
1767         https://bugs.webkit.org/show_bug.cgi?id=191132
1768
1769         Rubber-stamped by Lucas Forschler.
1770
1771         * BuildSlaveSupport/ews-app/ews-app/urls.py: Added entry for ews.urls.
1772         * BuildSlaveSupport/ews-app/ews/urls.py: Added.
1773
1774 2018-11-06  Youenn Fablet  <youenn@apple.com>
1775
1776         Make mDNS ICE Candidate an experimental flag again
1777         https://bugs.webkit.org/show_bug.cgi?id=191262
1778
1779         Reviewed by Dean Jackson.
1780
1781         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1782         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1783         (WTR::TestRunner::setWebRTCMDNSICECandidatesEnabled):
1784         (WTR::TestRunner::setMDNSICECandidatesEnabled): Deleted.
1785         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1786
1787 2018-11-06  Aakash Jain  <aakash_jain@apple.com>
1788
1789         [ews-app] Add views for OpenSource EWS Django app
1790         https://bugs.webkit.org/show_bug.cgi?id=191131
1791
1792         Rubber-stamped by Lucas Forschler.
1793
1794         * BuildSlaveSupport/ews-app/ews/views/index.py: Added.
1795         * BuildSlaveSupport/ews-app/ews/views/patch.py:
1796         * BuildSlaveSupport/ews-app/ews/views/results.py: Added.
1797         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py: Added.
1798
1799 2018-11-06  Aakash Jain  <aakash_jain@apple.com>
1800
1801         [ews-app] Add models for OpenSource EWS Django app
1802         https://bugs.webkit.org/show_bug.cgi?id=191123
1803
1804         Reviewed by Lucas Forschler.
1805
1806         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
1807         * BuildSlaveSupport/ews-app/ews/models/buildermappings.py: Added.
1808         * BuildSlaveSupport/ews-app/ews/models/builds.py: Added.
1809         * BuildSlaveSupport/ews-app/ews/models/patch.py:
1810         * BuildSlaveSupport/ews-app/ews/models/steps.py: Added.
1811
1812 2018-11-06  Aakash Jain  <aakash_jain@apple.com>
1813
1814         [ews-app] Fix Invalid HTTP_HOST header
1815         https://bugs.webkit.org/show_bug.cgi?id=191325
1816
1817         Reviewed by Lucas Forschler.
1818
1819         Changing ALLOWED_HOSTS to * as the landing page should be publicly accessible.
1820
1821         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1822
1823 2018-11-06  Aakash Jain  <aakash_jain@apple.com>
1824
1825         [ews-app] Rename EWS_app to ews-app - part 2
1826         https://bugs.webkit.org/show_bug.cgi?id=191317
1827
1828         Reviewed by Lucas Forschler.
1829
1830         * BuildSlaveSupport/ews-app/EWS_app: Removed.
1831         * BuildSlaveSupport/ews-app/ews-app: Moved from BuildSlaveSupport/ews-app/EWS_app.
1832         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1833         * BuildSlaveSupport/ews-app/ews-app/urls.py:
1834         * BuildSlaveSupport/ews-app/ews-app/wsgi.py:
1835         * BuildSlaveSupport/ews-app/manage.py:
1836
1837 2018-11-06  Aakash Jain  <aakash_jain@apple.com>
1838
1839         [ews-app] Rename EWS_app to ews-app - part 1
1840         https://bugs.webkit.org/show_bug.cgi?id=191317
1841
1842         Reviewed by Lucas Forschler.
1843
1844         * BuildSlaveSupport/EWS_app: Removed.
1845         * BuildSlaveSupport/ews-app: Moved from BuildSlaveSupport/EWS_app.
1846
1847 2018-11-06  Myles C. Maxfield  <mmaxfield@apple.com>
1848
1849         Spelling dots are drawn in the wrong place
1850         https://bugs.webkit.org/show_bug.cgi?id=190764
1851
1852         Reviewed by Dean Jackson.
1853
1854         Previously, it was impossible for WebKitTestRunner to draw spelling dots. This patch adds support for a header
1855         at the top of test files, of the form <!-- webkit-test-runner [ spellCheckingDots=true ] --> which will cause
1856         dots to be drawn.
1857
1858         * WebKitTestRunner/TestController.cpp:
1859         (WTR::TestController::resetStateToConsistentValues):
1860         (WTR::updateTestOptionsFromTestHeader):
1861         (WTR::TestController::platformResetStateToConsistentValues):
1862         * WebKitTestRunner/TestController.h:
1863         * WebKitTestRunner/TestOptions.h:
1864         (WTR::TestOptions::hasSameInitializationOptions const):
1865         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1866         (WTR::TestController::cocoaResetStateToConsistentValues):
1867         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1868         * WebKitTestRunner/ios/TestControllerIOS.mm:
1869         (WTR::TestController::platformResetStateToConsistentValues):
1870         * WebKitTestRunner/mac/TestControllerMac.mm:
1871         (WTR::TestController::platformResetStateToConsistentValues):
1872
1873 2018-11-06  Don Olmstead  <don.olmstead@sony.com>
1874
1875         Feature flags not present for Visual Studio when using build-webkit
1876         https://bugs.webkit.org/show_bug.cgi?id=191288
1877
1878         Reviewed by Fujii Hironori.
1879
1880         Passes feature flags to Visual studio builds within build-webkit.
1881         Removes cmakeBasedPortArguments as it is no longer in use.
1882
1883         * Scripts/build-jsc:
1884         * Scripts/build-webkit:
1885         * Scripts/webkitdirs.pm:
1886         (cmakeBasedPortArguments): Deleted.
1887
1888 2018-11-06  Per Arne Vollan  <pvollan@apple.com>
1889
1890         REGRESSION (r230523): Caps lock indicator not shown in password field
1891         https://bugs.webkit.org/show_bug.cgi?id=190056
1892
1893         Reviewed by Ryosuke Niwa.
1894
1895         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1896         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1897         (WTR::TestRunner::toggleCapsLock):
1898         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1899         * WebKitTestRunner/TestController.h:
1900         * WebKitTestRunner/TestInvocation.cpp:
1901         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1902         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1903         (WTR::TestController::toggleCapsLock):
1904
1905 2018-11-06  Sihui Liu  <sihui_liu@apple.com>
1906
1907         IndexedDB: WAL file keeps growing
1908         https://bugs.webkit.org/show_bug.cgi?id=191294
1909         <rdar://problem/41333493>
1910
1911         Reviewed by Chris Dumez.
1912
1913         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1914         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize-1.html: Added.
1915         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize-2.html: Added.
1916         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm: Added.
1917         (-[IndexedDBFileSizeMessageHandler userContentController:didReceiveScriptMessage:]):
1918         (TEST):
1919
1920 2018-11-06  Alex Christensen  <achristensen@webkit.org>
1921
1922         Fix tests after r237863
1923         https://bugs.webkit.org/show_bug.cgi?id=191315
1924
1925         Reviewed by Chris Dumez.
1926
1927         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1928         With the timing change of r237863, the WKWebView progressed further than before when loading main.html so it completed before main2.html.
1929         This test was meant to test that main2.html does eventually load, and it doesn't matter if main.html loads before it.  I updated the test
1930         to verify that main2.html eventually loads, making this test less timing dependent.
1931
1932 2018-11-06  Ryan Haddad  <ryanhaddad@apple.com>
1933
1934         Unreviewed, rolling out r237834.
1935
1936         Tests for this change crash on iOS Simulator
1937
1938         Reverted changeset:
1939
1940         "Spelling dots are drawn in the wrong place"
1941         https://bugs.webkit.org/show_bug.cgi?id=190764
1942         https://trac.webkit.org/changeset/237834
1943
1944 2018-11-05  Alex Christensen  <achristensen@webkit.org>
1945
1946         [Mac] Implement safe browsing in WebKit
1947         https://bugs.webkit.org/show_bug.cgi?id=188871
1948
1949         Reviewed by Tim Horton.
1950
1951         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1952         (-[SafeBrowsingNavigationDelegate webView:didCommitNavigation:]):
1953         (+[TestServiceLookupResult resultWithProvider:phishing:malware:unwantedSoftware:]):
1954         (-[TestLookupContext lookUpURL:completionHandler:]):
1955         (simpleURL):
1956         (safeBrowsingView):
1957         (TEST):
1958         (-[SafeBrowsingNavigationDelegate webView:didFinishNavigation:]): Deleted.
1959         (+[TestServiceLookupResult resultWithProvider:phishing:malware:unwantedSoftware:knownToBeUnsafe:]): Deleted.
1960         (-[TestServiceLookupResult isKnownToBeUnsafe]): Deleted.
1961         * TestWebKitAPI/Utilities.h:
1962
1963 2018-11-05  Jonathan Bedard  <jbedard@apple.com>
1964
1965         webkitpy: Generalize trailing SDK specifier (Part 1)
1966         https://bugs.webkit.org/show_bug.cgi?id=191275
1967         <rdar://problem/45703660>
1968
1969         Reviewed by Lucas Forschler.
1970
1971         * Scripts/webkitpy/common/system/platforminfo.py:
1972         (PlatformInfo.available_sdks): List all installed SDKs with version numbers stripped out.
1973         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
1974         (TestPlatformInfo):
1975         (TestPlatformInfo.test_available_sdks):
1976
1977 2018-11-05  Myles C. Maxfield  <mmaxfield@apple.com>
1978
1979         Spelling dots are drawn in the wrong place
1980         https://bugs.webkit.org/show_bug.cgi?id=190764
1981
1982         Reviewed by Dean Jackson.
1983
1984         Previously, it was impossible for WebKitTestRunner to draw spelling dots. This patch adds support for a header
1985         at the top of test files, of the form <!-- webkit-test-runner [ spellCheckingDots=true ] --> which will cause
1986         dots to be drawn.
1987
1988         * WebKitTestRunner/TestController.cpp:
1989         (WTR::TestController::resetStateToConsistentValues):
1990         (WTR::updateTestOptionsFromTestHeader):
1991         (WTR::TestController::platformResetStateToConsistentValues):
1992         * WebKitTestRunner/TestController.h:
1993         * WebKitTestRunner/TestOptions.h:
1994         (WTR::TestOptions::hasSameInitializationOptions const):
1995         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1996         (WTR::TestController::cocoaResetStateToConsistentValues):
1997         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1998         * WebKitTestRunner/ios/TestControllerIOS.mm:
1999         (WTR::TestController::platformResetStateToConsistentValues):
2000         * WebKitTestRunner/mac/TestControllerMac.mm:
2001         (WTR::TestController::platformResetStateToConsistentValues):
2002
2003 2018-11-05  Chris Dumez  <cdumez@apple.com>
2004
2005         Use same limit for page cache and suspended pages
2006         https://bugs.webkit.org/show_bug.cgi?id=191266
2007
2008         Reviewed by Geoffrey Garen.
2009
2010         Update API tests accordingly.
2011
2012         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2013
2014 2018-11-05  Basuke Suzuki  <Basuke.Suzuki@sony.com>
2015
2016         [style] Exclude style check for auto generated files.
2017         https://bugs.webkit.org/show_bug.cgi?id=191118
2018
2019         Reviewed by Eric Carlson.
2020
2021         Some files checked in to the repository are generated by other tools. In this patch,
2022         "MiniBrowserLibResource.h" is the file generated and managed by resource editor of
2023         VisualStudio.
2024
2025         There's no need to check these files because it's not practical to fix the style errors
2026         or it's hard to maintain those fixes.
2027
2028         * Scripts/webkitpy/style/checkers/cpp.py:
2029         (is_generated_file):
2030         (CppChecker.check):
2031
2032 2018-11-05  Thibault Saunier  <tsaunier@igalia.com>
2033
2034         [Flatpak] Build libx264 as it is the h264 encoder we support in WebRTC
2035         https://bugs.webkit.org/show_bug.cgi?id=190680
2036
2037         Reviewed by Philippe Normand.
2038
2039         * flatpak/org.webkit.WebKit.yaml:
2040
2041 2018-11-05  Daniel Bates  <dabates@apple.com>
2042
2043         [lldb-webkit] Fix formatting nits in Document and Frame summary strings
2044         https://bugs.webkit.org/show_bug.cgi?id=191094
2045
2046         Reviewed by Andy Estes.
2047
2048         Format boolean as 1/0 when printing Frame summary to be consistent with the formatting of
2049         booleans in other summary strings, substitute "inMainFrame" for "isMainFrame" in the printed
2050         Document summary and add closing brace '}' to both Frame and Document summary strings to make
2051         them look pretty.
2052
2053         * lldb/lldb_webkit.py:
2054         (WebCoreFrame_SummaryProvider):
2055         (WebCoreDocument_SummaryProvider):
2056
2057 2018-11-05  Wenson Hsieh  <wenson_hsieh@apple.com>
2058
2059         [iOS] Allow WKWebView clients to customize bar button item groups in the accessory view when editing
2060         https://bugs.webkit.org/show_bug.cgi?id=191240
2061         <rdar://problem/44872806>
2062
2063         Reviewed by Tim Horton.
2064
2065         Add new API tests to verify that setting leading and trailing bar button groups on WKWebView sets the first
2066         responder's (i.e. WKContentView's) leading and trailing bar button groups, and that this can also be achieved by
2067         overriding `-[WKWebView inputAssistantItem]`.
2068
2069         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2070         (-[InputAssistantItemTestingWebView fakeLeadingBarButtonItemAction]):
2071         (-[InputAssistantItemTestingWebView fakeTrailingBarButtonItemAction]):
2072         (+[InputAssistantItemTestingWebView barButtonIcon]):
2073         (+[InputAssistantItemTestingWebView leadingItemsForWebView:]):
2074         (+[InputAssistantItemTestingWebView trailingItemsForWebView:]):
2075         (-[InputAssistantItemTestingWebView inputAssistantItem]):
2076         (TestWebKitAPI::TEST):
2077
2078 2018-11-05  Wenson Hsieh  <wenson_hsieh@apple.com>
2079
2080         [iOS] Changing view scale sometimes does not zoom the page to the new initial scale when the page is zoomed in when ignoring meta viewport
2081         https://bugs.webkit.org/show_bug.cgi?id=191226
2082         <rdar://problem/45781765>
2083
2084         Reviewed by Tim Horton.
2085
2086         Add a missing check for `shouldIgnoreMetaViewport` when comparing TestOptions, to ensure that "ignore meta
2087         viewport" state doesn't unexpectedly persist after running a layout test that ignores meta viewport.
2088
2089         * WebKitTestRunner/TestOptions.h:
2090         (WTR::TestOptions::hasSameInitializationOptions const):
2091
2092 2018-11-05  Commit Queue  <commit-queue@webkit.org>
2093
2094         Unreviewed, rolling out r237784 and r237788.
2095         https://bugs.webkit.org/show_bug.cgi?id=191270
2096
2097         Caused mediastream layout test failures (Requested by
2098         ryanhaddad on #webkit).
2099
2100         Reverted changesets:
2101
2102         "[MediaStream] User should not be prompted again after denying
2103         getDisplayMedia request"
2104         https://bugs.webkit.org/show_bug.cgi?id=191227
2105         https://trac.webkit.org/changeset/237784
2106
2107         "[MediaStream] User should not be prompted again after denying
2108         getDisplayMedia request"
2109         https://bugs.webkit.org/show_bug.cgi?id=191227
2110         https://trac.webkit.org/changeset/237788
2111
2112 2018-11-05  Lucas Forschler  <lforschler@apple.com>
2113
2114         https://bugs.webkit.org/show_bug.cgi?id=191268
2115         Remove unused bots.
2116
2117         rubber-stamped by Alexey Proskuryakov.
2118
2119         * BuildSlaveSupport/build.webkit.org-config/config.json:
2120         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2121         (WebKitBuildbot):
2122
2123 2018-11-05  Michael Catanzaro  <mcatanzaro@igalia.com>
2124
2125         [WPE][GTK] API test runner fails to respect default build type
2126         https://bugs.webkit.org/show_bug.cgi?id=190247
2127
2128         Reviewed by Carlos Garcia Campos.
2129
2130         Problem is it's looking for a release build, even though I've run set-webkit-configuration
2131         --debug. It should look for a debug build unless I explicitly pass --release.
2132
2133         * glib/api_test_runner.py:
2134         (TestRunner.__init__):
2135
2136 2018-11-05  Thibault Saunier  <tsaunier@igalia.com>
2137
2138         [GStreamer][WebRTC] Add webrtcencoder bin to cleanup and refactor the way we set encoders
2139         https://bugs.webkit.org/show_bug.cgi?id=190674
2140
2141         Reviewed by Philippe Normand.
2142
2143         webrtcencoder is a simple GstBin with a set of well known GStreamer encoders which
2144         it can use to implement encoding for different formats exposing a trimmed down unified API.
2145
2146         It also adds proper handling of H264 profiles.
2147
2148         The added files follow GStreamer coding style as we aim at upstreaming the element
2149         in the future.
2150
2151         Reviewed by Philippe Normand.
2152
2153         * Scripts/webkitpy/style/checker.py:
2154
2155 2018-11-05  Michael Catanzaro  <mcatanzaro@igalia.com>
2156
2157         [WPE][GTK] API test /webkit/WebKitSettings/webkit-settings is failing
2158         https://bugs.webkit.org/show_bug.cgi?id=191221
2159
2160         Reviewed by Carlos Garcia Campos.
2161
2162         This test ensures that MSE is disabled by default, but we now enable it by default, so
2163         reverse the semantics of the test.
2164
2165         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2166         (testWebKitSettings):
2167
2168 2018-11-05  Michael Catanzaro  <mcatanzaro@igalia.com>
2169
2170         REGRESSION(r237031): [GTK] Test /webkit/WebKitWebView/settings is failing
2171         https://bugs.webkit.org/show_bug.cgi?id=191225
2172
2173         Reviewed by Alejandro G. Castro.
2174
2175         Fix a memory leak causing this test to fail.
2176
2177         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
2178         (WebViewTest::initializeWebView):
2179
2180 2018-11-04  Zan Dobersek  <zdobersek@igalia.com>
2181
2182         [webkitpy] Support WPE in the run-web-platform-tests script
2183         https://bugs.webkit.org/show_bug.cgi?id=191183
2184
2185         Reviewed by Alex Christensen.
2186
2187         * Scripts/webkitpy/w3c/wpt_runner.py:
2188         (parse_args): Support `--wpe` as an argument that specifies WPE as the
2189         target port. Additionally, the `--display-server` flag now accepts
2190         `headless` as a valid value, enabling the WPE WebDriver to run in
2191         headless mode.
2192
2193 2018-11-04  Fujii Hironori  <Hironori.Fujii@sony.com>
2194
2195         [Win] Use C++14, not C++17
2196         https://bugs.webkit.org/show_bug.cgi?id=191101
2197
2198         Reviewed by Alex Christensen.
2199
2200         std::basic_string::data() returns a read-only const buffer in
2201         C++14.
2202
2203         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2204         (createString): Use std::vector instead of std::wstring.
2205         (createUTF8String): Use std::vector instead of std::string.
2206
2207 2018-11-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2208
2209         [Cocoa] Fold common UIScriptController functionality on macOS and iOS into UIScriptControllerCocoa.mm
2210         https://bugs.webkit.org/show_bug.cgi?id=191231
2211
2212         Reviewed by Simon Fraser.
2213
2214         Moves some UIScriptController method implementations specific to iOS and macOS into UIScriptControllerCocoa, so
2215         it can be shared between iOS-family and macOS platforms. See below for more details.
2216
2217         No change in behavior.
2218
2219         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2220         (WTR::UIScriptController::overridePreference):
2221
2222         Add a method stub for DumpRenderTree.
2223
2224         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2225         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2226         (WTR::UIScriptController::doAsyncTask):
2227         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution):
2228
2229         Unify these method implementations.
2230
2231         (WTR::UIScriptController::removeViewFromWindow):
2232         (WTR::UIScriptController::addViewToWindow):
2233
2234         Move the macOS implementation to UIScriptControllerCocoa. On iOS, this method currently only adds the web view
2235         to the window, and does not attempt to invoke the given completion block; additionally, invoking the completion
2236         block after a presentation update (as done on macOS) causes pageoverlay/overlay-remove-reinsert-view.html to
2237         begin failing consistently. This patch does not attempt to change behavior, but adds a FIXME describing this.
2238
2239         (WTR::UIScriptController::overridePreference):
2240         (WTR::UIScriptController::findString):
2241         (WTR::UIScriptController::contentsOfUserInterfaceItem const):
2242
2243         Move these from UIScriptControllerMac to UIScriptControllerCocoa, so that it is now implemented on iOS as well.
2244
2245         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2246         (WTR::UIScriptController::doAsyncTask): Deleted.
2247         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution): Deleted.
2248         (WTR::UIScriptController::contentsOfUserInterfaceItem const): Deleted.
2249         (WTR::UIScriptController::findString): Deleted.
2250         (WTR::UIScriptController::removeViewFromWindow): Deleted.
2251         (WTR::UIScriptController::addViewToWindow): Deleted.
2252         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2253         (WTR::UIScriptController::doAsyncTask): Deleted.
2254         (WTR::UIScriptController::contentsOfUserInterfaceItem const): Deleted.
2255         (WTR::UIScriptController::overridePreference): Deleted.
2256         (WTR::UIScriptController::findString): Deleted.
2257         (WTR::UIScriptController::removeViewFromWindow): Deleted.
2258         (WTR::UIScriptController::addViewToWindow): Deleted.
2259         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution): Deleted.
2260
2261 2018-11-04  Eric Carlson  <eric.carlson@apple.com>
2262
2263         [MediaStream] User should not be prompted again after denying getDisplayMedia request
2264         https://bugs.webkit.org/show_bug.cgi?id=191227
2265         <rdar://problem/45784512>
2266
2267         Reviewed by Youenn Fablet.
2268
2269         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
2270         (-[GetDisplayMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
2271         (TestWebKitAPI::GetDisplayMediaTest::promptForCapture):
2272         (TestWebKitAPI::TEST_F):
2273
2274 2018-11-04  Zalan Bujtas  <zalan@apple.com>
2275
2276         [LFC][BFC] Add support for percentage height in quirks mode.
2277         https://bugs.webkit.org/show_bug.cgi?id=191232
2278
2279         Reviewed by Antti Koivisto.
2280
2281         * LayoutReloaded/misc/LFC-passing-tests.txt:
2282
2283 2018-11-04  Zalan Bujtas  <zalan@apple.com>
2284
2285         [LFC][BCF] Add support for block level non-replaced inflow height percentage
2286         https://bugs.webkit.org/show_bug.cgi?id=191229
2287
2288         Reviewed by Antti Koivisto.
2289
2290         * LayoutReloaded/misc/LFC-passing-tests.txt:
2291
2292 2018-11-02  Zalan Bujtas  <zalan@apple.com>
2293
2294         [LFC][BFC] Resolve percentage height values.
2295         https://bugs.webkit.org/show_bug.cgi?id=191224
2296
2297         Reviewed by Antti Koivisto.
2298
2299         * LayoutReloaded/misc/LFC-passing-tests.txt:
2300
2301 2018-11-03  Alex Christensen  <achristensen@webkit.org>
2302
2303         Mac production builds should sign the network process xpc service with entitlements
2304         https://bugs.webkit.org/show_bug.cgi?id=191209
2305         <rdar://problem/45377609>
2306
2307         Reviewed by Geoff Garen.
2308
2309         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2310         * TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm: Added.
2311         (TEST):
2312
2313 2018-11-02  Alex Christensen  <achristensen@webkit.org>
2314
2315         Unreviewed, rolling out r237761.
2316
2317         Makes most API tests timeout and WK2 tests crash
2318
2319         Reverted changeset:
2320
2321         "Mac production builds should sign the network process xpc
2322         service with entitlements"
2323         https://bugs.webkit.org/show_bug.cgi?id=191209
2324         https://trac.webkit.org/changeset/237761
2325
2326 2018-11-02  Michael Catanzaro  <mcatanzaro@igalia.com>
2327
2328         Unreviewed API test gardening
2329
2330         * TestWebKitAPI/glib/TestExpectations.json:
2331
2332 2018-11-02  Justin Michaud  <justin_michaud@apple.com>
2333
2334         Add new global object and preliminary Worklets support for CSS painting api
2335         https://bugs.webkit.org/show_bug.cgi?id=190979
2336
2337         Reviewed by Chris Dumez.
2338
2339         * Scripts/webkitpy/bindings/main.py:
2340         (BindingsTests.generate_supplemental_dependency):
2341         (BindingsTests.main):
2342
2343 2018-11-02  Alex Christensen  <achristensen@webkit.org>
2344
2345         Mac production builds should sign the network process xpc service with entitlements
2346         https://bugs.webkit.org/show_bug.cgi?id=191209
2347         <rdar://problem/45377609>
2348
2349         Reviewed by Geoff Garen.
2350
2351         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2352         * TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm: Added.
2353         (TEST):
2354
2355 2018-11-02  Lucas Forschler  <lforschler@apple.com>
2356
2357         Add Windows 10 archive bots
2358         https://bugs.webkit.org/show_bug.cgi?id=190964
2359         
2360         This Change updates the Apple Windows Buildbot configuration.
2361         - Add Windows 10 specific builders and testers for release and debug.
2362         - Refactor Windows -> Windows 7.
2363         - Remove Windows 7 Debug.
2364
2365         Reviewed by Aakash Jain.
2366
2367         * BuildSlaveSupport/build.webkit.org-config/config.json:
2368
2369 2018-11-02  Philippe Normand  <pnormand@igalia.com>
2370
2371         [GTK][WPE] Enable GST_DEBUG_NO_COLOR environment variable pass-through
2372
2373         Rubber-stamped by Michael Catanzaro.
2374
2375         This variable is useful to get rid of shell color escapes in tests stderr files.
2376
2377         * Scripts/webkitpy/port/gtk.py:
2378         (GtkPort.setup_environ_for_server):
2379         * Scripts/webkitpy/port/wpe.py:
2380         (WPEPort.setup_environ_for_server):
2381
2382 2018-11-02  Aakash Jain  <aakash_jain@apple.com>
2383
2384         Add Basic Django web app for OpenSource EWS
2385         https://bugs.webkit.org/show_bug.cgi?id=191091
2386
2387         Reviewed by Lucas Forschler.
2388
2389         * BuildSlaveSupport/EWS_app/manage.py: Added, auto-generated by Django.
2390         * BuildSlaveSupport/EWS_app/EWS_app/__init__.py: Added, auto-generated by Django.
2391         * BuildSlaveSupport/EWS_app/EWS_app/settings.py: Added, auto-generated by Django.
2392         * BuildSlaveSupport/EWS_app/EWS_app/urls.py: Added, auto-generated by Django.
2393         * BuildSlaveSupport/EWS_app/EWS_app/wsgi.py: Added, auto-generated by Django.
2394         * BuildSlaveSupport/EWS_app/ews/__init__.py: Added.
2395         * BuildSlaveSupport/EWS_app/ews/admin.py: Added, auto-generated by Django.
2396         * BuildSlaveSupport/EWS_app/ews/apps.py: Added, auto-generated by Django.
2397         * BuildSlaveSupport/EWS_app/ews/migrations/__init__.py: Added.
2398         * BuildSlaveSupport/EWS_app/ews/tests.py: Added, auto-generated by Django.
2399         * BuildSlaveSupport/EWS_app/ews/models/__init__.py: Added.
2400         * BuildSlaveSupport/EWS_app/ews/models/patch.py: Added.
2401         * BuildSlaveSupport/EWS_app/ews/views/__init__.py: Added.
2402         * BuildSlaveSupport/EWS_app/ews/views/patch.py: Added.
2403
2404 2018-11-02  Daniel Bates  <dabates@apple.com>
2405
2406         [iOS] WebKit should dispatch DOM events when a modifier key is pressed
2407         https://bugs.webkit.org/show_bug.cgi?id=190487
2408
2409         Reviewed by Tim Horton.
2410
2411         Update the code for renamed enumerations. For WebKitTestRunner, removed comment that does not
2412         match my observations when using the simulator to simulate iOS 12 and add support for testing
2413         right-hand side modifiers.
2414
2415         * DumpRenderTree/mac/EventSendingController.mm:
2416         (modifierFlags):
2417         (-[EventSendingController keyDown:withModifiers:withLocation:]):
2418         (-[EventSendingController setTouchModifier:value:]):
2419         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2420         (hidUsageCodeForCharacter):
2421
2422 2018-11-02  Chris Dumez  <cdumez@apple.com>
2423
2424         [PSON] Reuse SuspendedPages' process when possible, for performance
2425         https://bugs.webkit.org/show_bug.cgi?id=191166
2426
2427         Reviewed by Geoffrey Garen.
2428
2429         Add API test coverage.
2430
2431         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2432
2433 2018-11-02  Zalan Bujtas  <zalan@apple.com>
2434
2435         [LFC][IFC] Add support for intrinsic width calculation
2436         https://bugs.webkit.org/show_bug.cgi?id=191144
2437
2438         Reviewed by Antti Koivisto.
2439
2440         * LayoutReloaded/misc/LFC-passing-tests.txt:
2441
2442 2018-11-01  Philippe Normand  <pnormand@igalia.com>
2443
2444         [Apache] Self-signed SSL certificate RSA key is considered too weak
2445         https://bugs.webkit.org/show_bug.cgi?id=191156
2446
2447         Reviewed by Michael Catanzaro.
2448
2449         * Scripts/webkitpy/common/system/pemfile.py:
2450
2451 2018-11-02  Zan Dobersek  <zdobersek@igalia.com>
2452
2453         Unreviewed follow-up to r237678.
2454
2455         * wpe/jhbuild.modules: The patch element apparently has to be a child
2456         of the branch in order for Jhbuild to properly detect and apply the
2457         patch file.
2458
2459 2018-11-01  Ross Kirsling  <ross.kirsling@sony.com>
2460
2461         build-jsc --wincairo should update WinCairo libraries
2462         https://bugs.webkit.org/show_bug.cgi?id=191170
2463
2464         Reviewed by Fujii Hironori.
2465
2466         * Scripts/build-jsc:
2467
2468 2018-11-01  John Wilander  <wilander@apple.com>
2469
2470         In WebCore::ResourceLoadObserver, use document.sessionID().isEphemeral() when possible and check for page existence when not
2471         https://bugs.webkit.org/show_bug.cgi?id=191119
2472         <rdar://problem/44176965>
2473
2474         Reviewed by Chris Dumez.
2475
2476         This is an API test for a WebKitLegacy WebView that is first closed and then
2477         JavaScript is handed a keyboard event.
2478
2479         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2480         * TestWebKitAPI/Tests/WebKitLegacy/mac/ClosingWebView.mm: Added.
2481         (-[ClosingWebViewThenSendingItAKeyDownEventLoadDelegate webView:didFinishLoadForFrame:]):
2482         (-[KeyboardEventListener handleEvent:]):
2483         (TestWebKitAPI::TEST):
2484
2485 2018-11-01  Sihui Liu  <sihui_liu@apple.com>
2486
2487         Add a storage limit for IndexedDB
2488         https://bugs.webkit.org/show_bug.cgi?id=190598
2489         <rdar://problem/44654715>
2490
2491         Reviewed by Chris Dumez.
2492
2493         Add API for testing.
2494
2495         * DumpRenderTree/TestRunner.cpp:
2496         (setIDBPerOriginQuotaCallback):
2497         (TestRunner::staticFunctions):
2498         * DumpRenderTree/TestRunner.h:
2499         * DumpRenderTree/mac/TestRunnerMac.mm:
2500         (TestRunner::setIDBPerOriginQuota):
2501         * DumpRenderTree/win/TestRunnerWin.cpp:
2502         (TestRunner::setIDBPerOriginQuota):
2503         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2504         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2505         (WTR::TestRunner::setIDBPerOriginQuota):
2506         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2507         * WebKitTestRunner/TestController.cpp:
2508         (WTR::TestController::setIDBPerOriginQuota):
2509         * WebKitTestRunner/TestController.h:
2510         * WebKitTestRunner/TestInvocation.cpp:
2511         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2512
2513 2018-11-01  Chris Dumez  <cdumez@apple.com>
2514
2515         [PSON] WebPageProxy::receivedNavigationPolicyDecision() should not schedule the new load asynchronously when process-swapping
2516         https://bugs.webkit.org/show_bug.cgi?id=191076
2517
2518         Reviewed by Geoffrey Garen.
2519
2520         Add API test coverage.
2521
2522         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2523         (-[PSONNavigationDelegate init]):
2524         (-[PSONNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2525
2526 2018-11-01  Adrian Perez de Castro  <aperez@igalia.com>
2527
2528         Fix build with VIDEO and WEB_AUDIO disabled
2529         https://bugs.webkit.org/show_bug.cgi?id=191147
2530         <rdar://problem/45726710>
2531
2532         Unreviewed build fix.
2533
2534         This adds the missing compilation guards in the WPE MiniBrowser.
2535
2536         * MiniBrowser/wpe/main.cpp:
2537         (main): Condition GST includes and calls.
2538
2539 2018-10-31  Zalan Bujtas  <zalan@apple.com>
2540
2541         [LFC][IFC] Add support for inline-block elements.
2542         https://bugs.webkit.org/show_bug.cgi?id=191143
2543
2544         Reviewed by Antti Koivisto.
2545
2546         * LayoutReloaded/misc/LFC-passing-tests.txt:
2547
2548 2018-11-01  Claudio Saavedra  <csaavedra@igalia.com>
2549
2550         [WPE] Add missing libsoup patch to jhbuild
2551         https://bugs.webkit.org/show_bug.cgi?id=191149
2552
2553         Reviewed by Žan Doberšek.
2554
2555         * wpe/jhbuild.modules:
2556         * wpe/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch: Added.
2557
2558 2018-11-01  Claudio Saavedra  <csaavedra@igalia.com>
2559
2560         Fix build with VIDEO and WEB_AUDIO disabled
2561         https://bugs.webkit.org/show_bug.cgi?id=191147
2562
2563         Reviewed by Philippe Normand.
2564
2565         * MiniBrowser/gtk/main.c:
2566         (main): Condition GST includes and calls
2567
2568 2018-10-31  Justin Michaud  <justin_michaud@apple.com>
2569
2570         Add Justin Michaud to the list of WebKit Committers
2571         https://bugs.webkit.org/show_bug.cgi?id=191142
2572
2573         * Scripts/webkitpy/common/config/contributors.json:
2574
2575 2018-10-31  Guillaume Emont  <guijemont@igalia.com>
2576
2577         Don't run JIT tests on 32-bit platforms
2578         https://bugs.webkit.org/show_bug.cgi?id=191074
2579
2580         Reviewed by Michael Catanzaro.
2581
2582         * Scripts/run-jsc-stress-tests:
2583
2584 2018-10-30  Wenson Hsieh  <wenson_hsieh@apple.com>
2585
2586         [Cocoa] Attachment dropped from one web view to another is missing its file wrapper
2587         https://bugs.webkit.org/show_bug.cgi?id=190530
2588         <rdar://problem/45232149>
2589
2590         Reviewed by Tim Horton.
2591
2592         Add a test to verify that copying different types of attachments and pasting in a new web view inserts
2593         attachments in the second web view that are backed by _WKAttachment objects, whose NSFileWrappers hold data that
2594         is equivalent to the original file wrappers used to insert attachments in the first web view.
2595
2596         Existing API tests verify that when copying and pasting within a single web view, the pasted attachment element
2597         is still backed by the same NSFileWrapper instance.
2598
2599         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2600         (TestWebKitAPI::TEST):
2601
2602 2018-10-30  Fujii Hironori  <Hironori.Fujii@sony.com>
2603
2604         [Win] Remove obsolete code for Visual Studio Express in webkitdirs.pm
2605         https://bugs.webkit.org/show_bug.cgi?id=190949
2606
2607         Reviewed by Alex Christensen.
2608
2609         Visual Studio 2017 Community is the alternative.
2610
2611         * Scripts/webkitdirs.pm: Remove $willUseVCExpressWhenBuilding variable.
2612         (setupCygwinEnv): Remove obsolete code for Visual Studio Express.
2613         (buildVisualStudioProject): Ditto.
2614         (dieIfWindowsPlatformSDKNotInstalled): Deleted.
2615         (usingVisualStudioExpress): Deleted.
2616
2617 2018-10-30  Fujii Hironori  <Hironori.Fujii@sony.com>
2618
2619         [Win][Direct2D] Support building DumpRenderTree for Direct2D
2620         https://bugs.webkit.org/show_bug.cgi?id=191093
2621         <rdar://problem/45685706>
2622
2623         Unreviewed build fix.
2624
2625         error C2065: 'renderTarget': undeclared identifier
2626
2627         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
2628         (createBitmapContextFromWebView): Restored the previous implementation.
2629
2630 2018-10-30  Don Olmstead  <don.olmstead@sony.com>
2631
2632         [PlayStation] Enable JavaScriptCore
2633         https://bugs.webkit.org/show_bug.cgi?id=191072
2634
2635         Reviewed by Brent Fulgham.
2636
2637         Add platform scripts for building the PlayStation port.
2638         perl Tools/Scripts/build-webkit --playstation
2639
2640         * Scripts/build-webkit:
2641         * Scripts/build-webkittestrunner:
2642         * Scripts/webkitdirs.pm:
2643         (argumentsForConfiguration):
2644         (determineConfigurationProductDir):
2645         (isPlayStation): Added.
2646         (getMSBuildPlatformArgument): Added.
2647         (buildVisualStudioProject):
2648         (wrapperPrefixIfNeeded):
2649         (generateBuildSystemFromCMakeProject):
2650         * TestWebKitAPI/PlatformPlayStation.cmake: Added.
2651
2652 2018-10-30  Brent Fulgham  <bfulgham@apple.com>
2653
2654         [Win][Direct2D] Support building DumpRenderTree for Direct2D
2655         https://bugs.webkit.org/show_bug.cgi?id=191093
2656         <rdar://problem/45685706>
2657
2658         Reviewed by Alex Christensen.
2659
2660         * DumpRenderTree/PixelDumpSupport.cpp: Update for Direct2D use.
2661         * DumpRenderTree/PlatformWin.cmake: Add support for Direct2D build.
2662         * DumpRenderTree/win/PixelDumpSupportDirect2D.cpp: Added.
2663         (pixelDumpSystemFactory): Added.
2664         (printPNG): Create stub.
2665         (computeMD5HashStringForBitmapContext): Ditto.
2666         (dumpBitmap): Ditto.
2667         * DumpRenderTree/win/PixelDumpSupportDirect2D.h: Added.
2668         (BitmapContext::createByAdoptingBitmapAndContext):
2669         (BitmapContext::~BitmapContext):
2670         (BitmapContext::platformContext const):
2671         (BitmapContext::BitmapContext):
2672         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
2673         (createBitmapContextFromWebView): Update to support Direct2D.
2674         * MiniBrowser/win/MiniBrowserReplace.h: Drive-by fix: The old WebKit
2675         logo is no longer available at this location. Switch to the new logo.
2676
2677 2018-10-30  Jonathan Bedard  <jbedard@apple.com>
2678
2679         webkitpy: Support alternate simctl list outputs
2680         https://bugs.webkit.org/show_bug.cgi?id=191090
2681         <rdar://problem/45684255>
2682
2683         Rubber-stamped by Aakash Jain.
2684
2685         * Scripts/webkitpy/xcode/simulated_device.py:
2686         (SimulatedDeviceManager._create_runtimes): Support alternative availability format.
2687         (SimulatedDeviceManager._create_device_with_runtime): Ditto.
2688         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
2689         (test_available_devices): Add iOS 12 with alternative availability format.
2690
2691 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
2692
2693         Clean up some obsolete MAX_ALLOWED macros
2694         https://bugs.webkit.org/show_bug.cgi?id=190916
2695
2696         Reviewed by Tim Horton.
2697
2698         * TestWebKitAPI/Tests/WTF/darwin/WeakLinking.cpp:
2699         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
2700         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2701
2702 2018-10-30  Claudio Saavedra  <csaavedra@igalia.com>
2703
2704         [GTK][WPE] Fixes to the PublicSuffix implementation
2705         https://bugs.webkit.org/show_bug.cgi?id=191031
2706
2707         Reviewed by Michael Catanzaro.
2708
2709         * TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp:
2710         (TestWebKitAPI::TEST_F): Remove a test for a domain
2711         that is not registrable and shouldn't be tested there.
2712
2713 2018-10-29  Tim Horton  <timothy_horton@apple.com>
2714
2715         Modernize WebKit nibs and lprojs for localization's sake
2716         https://bugs.webkit.org/show_bug.cgi?id=190911
2717         <rdar://problem/45349466>
2718
2719         Reviewed by Dan Bernstein.
2720
2721         * Scripts/check-inspector-strings:
2722         * Scripts/update-webkit-localizable-strings:
2723         * gtk/manifest.txt.in:
2724         * wpe/manifest.txt.in:
2725         English->en
2726
2727 2018-10-29  Daniel Bates  <dabates@apple.com>
2728
2729         [lldb-webkit] Last aliased enumerator in OptionSet is printed; should print first enumerator
2730         https://bugs.webkit.org/show_bug.cgi?id=191036
2731
2732         Reviewed by Andy Estes.
2733
2734         Prefer the first enumerator (in parse order) when pretty-printing an OptionSet that is parameterized
2735         by an enum that contains two or more enumerators with the same value. For example, suppose
2736         you have the following enum:
2737
2738         enum Flag {
2739             A = 1 << 0,
2740             AAlias = A,
2741         };
2742
2743         Then pretty-printing OptionSet<Flag>(Flag::A) should print A instead of AAlias. A side effect of
2744         this change is that OptionSet<Flag>(Flag::AAlias) will also print A as its only member as we cannot
2745         differentiate between A and Alias. This should be acceptable in practice as aliased enumerators
2746         tend to be used in bounds checks as opposed to code that adds to a set.
2747
2748         * lldb/lldbWebKitTester/main.cpp:
2749         (testSummaryProviders):
2750         * lldb/lldb_webkit.py:
2751         (WTFOptionSetProvider.update):
2752         * lldb/lldb_webkit_unittest.py:
2753         (TestSummaryProviders.serial_test_WTFOptionSetProvider_simple):
2754         (TestSummaryProviders):
2755         (TestSummaryProviders.serial_test_WTFOptionSetProvider_aliased_flag):
2756
2757 2018-10-29  Daniel Bates  <dabates@apple.com>
2758
2759         [llbd-webkit] Add summaries for Document, Frame, and SecurityOrigin
2760         https://bugs.webkit.org/show_bug.cgi?id=191033
2761
2762         Reviewed by Andy Estes.
2763
2764         For Documents we display its origin, URL, whether it's in the main frame, and its page cache state.
2765         We display the same details in the summary for a Frame because its Document tends to be the most
2766         interesting aspect of it. For SecurityOrigin we display its origin, domain (affects cookie access),
2767         and whether the origin has universal access.
2768
2769         * lldb/lldb_webkit.py:
2770         (__lldb_init_module):
2771         Register new summary providers.
2772
2773         (WebCoreSecurityOrigin_SummaryProvider):
2774         (WebCoreFrame_SummaryProvider):
2775         (WebCoreDocument_SummaryProvider):
2776         Add new summary providers.
2777
2778         (StdOptionalWrapper):
2779         (StdOptionalWrapper.__init__):
2780         (StdOptionalWrapper.has_value):
2781         (StdOptionalWrapper.value):
2782         Convenience data type that provides access to the fields of a std::optional<>.
2783         
2784         (WebCoreSecurityOriginProvider):
2785         (WebCoreSecurityOriginProvider.__init__):
2786         (WebCoreSecurityOriginProvider.is_unique):
2787         (WebCoreSecurityOriginProvider.scheme):
2788         (WebCoreSecurityOriginProvider.host):
2789         (WebCoreSecurityOriginProvider.port):
2790         (WebCoreSecurityOriginProvider.domain):
2791         (WebCoreSecurityOriginProvider.has_universal_access):
2792         (WebCoreSecurityOriginProvider.to_string):
2793         (WebCoreFrameProvider):
2794         (WebCoreFrameProvider.__init__):
2795         (WebCoreFrameProvider.is_main_frame):
2796         (WebCoreFrameProvider.document):
2797         (WebCoreDocumentProvider):
2798         (WebCoreDocumentProvider.__init__):
2799         (WebCoreDocumentProvider.url):
2800         (WebCoreDocumentProvider.origin):
2801         (WebCoreDocumentProvider.page_cache_state):
2802         (WebCoreDocumentProvider.frame):
2803
2804 2018-10-29  Chris Dumez  <cdumez@apple.com>
2805
2806         [PSON] When Safari restores session state after launching, going back and forward does not swap processes
2807         https://bugs.webkit.org/show_bug.cgi?id=190975
2808         <rdar://problem/45059256>
2809
2810         Reviewed by Antti Koivisto.
2811
2812         Add API test coverage.
2813
2814         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2815
2816 2018-10-29  Zalan Bujtas  <zalan@apple.com>
2817
2818         [LFC][IFC] Compute estimated margin top for inline formatting root's ancestors
2819         https://bugs.webkit.org/show_bug.cgi?id=191018
2820
2821         Reviewed by Antti Koivisto.
2822
2823         * LayoutReloaded/misc/LFC-passing-tests.txt:
2824
2825 2018-10-29  Zalan Bujtas  <zalan@apple.com>
2826
2827         [LFC] Add support for inflow non replaced content height when the box is an inline formatting root.
2828         https://bugs.webkit.org/show_bug.cgi?id=191011
2829
2830         Reviewed by Antti Koivisto.
2831
2832         * LayoutReloaded/misc/LFC-passing-tests.txt:
2833
2834 2018-10-29  Zalan Bujtas  <zalan@apple.com>
2835
2836         Missing from r237549
2837
2838         Reviewed by Antti Koivisto.
2839
2840         * LayoutReloaded/misc/LFC-passing-tests.txt:
2841
2842 2018-10-29  Zalan Bujtas  <zalan@apple.com>
2843
2844         [LFC][IFC] Add support for simple intruding floats.
2845         https://bugs.webkit.org/show_bug.cgi?id=190998
2846
2847         Reviewed by Antti Koivisto.
2848
2849         * LayoutReloaded/misc/LFC-passing-tests.txt:
2850
2851 2018-10-29  Zalan Bujtas  <zalan@apple.com>
2852
2853         [LFC][IFC] Inline layout produces separate runs when float is present.
2854         https://bugs.webkit.org/show_bug.cgi?id=190980
2855
2856         Reviewed by Antti Koivisto.
2857
2858         * LayoutReloaded/misc/LFC-passing-tests.txt:
2859
2860 2018-10-29  Tadeu Zagallo  <tzagallo@apple.com>
2861
2862         New bytecode format for JSC
2863         https://bugs.webkit.org/show_bug.cgi?id=187373
2864         <rdar://problem/44186758>
2865
2866         Reviewed by Filip Pizlo.
2867
2868         Do not force ENABLE_JIT=true when $forceCLoop is false.
2869
2870         * Scripts/build-jsc:
2871
2872 2018-10-29  Claudio Saavedra  <csaavedra@igalia.com>
2873
2874         [GTK] Try to fix the xserver-xorg build in the Ubuntu LTS bot
2875
2876         Unreviewed build fix
2877
2878         The build fails because of some array-bound check related
2879         to strcmp() macro optimizations. Disabling selective Werrors
2880         when building xserver-xorg might get past this.
2881
2882         * gtk/jhbuild.modules: Add --disable-selective-werror to xserver-xorg
2883         configuration.
2884
2885 2018-10-29  Claudio Saavedra  <csaavedra@igalia.com>
2886
2887         [GTK] Update API test expectations after r237383
2888         https://bugs.webkit.org/show_bug.cgi?id=186913
2889
2890         Unreviewed gardening.
2891
2892         * TestWebKitAPI/glib/TestExpectations.json: Remove
2893         passing TestSSL tests.
2894
2895 2018-10-28  Zan Dobersek  <zdobersek@igalia.com>
2896
2897         [WPE] Add the WebKitVersion.h header
2898         https://bugs.webkit.org/show_bug.cgi?id=191015
2899
2900         Reviewed by Michael Catanzaro.
2901
2902         * MiniBrowser/wpe/main.cpp:
2903         (automationStartedCallback): Remove the FIXME and finally enable the
2904         webkit_application_info_set_version() call.
2905         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp: Remove
2906         this FIXME as well and remove the custom WEBKIT_*_VERSION macros.
2907
2908 2018-10-28  Fujii Hironori  <Hironori.Fujii@sony.com>
2909
2910         [Win] Remove obsolete code for vcxproj builds in build-api-tests and build-jsc
2911         https://bugs.webkit.org/show_bug.cgi?id=190948
2912
2913         Reviewed by Brent Fulgham.
2914
2915         vcxproj files have been removed in Bug 154388.
2916
2917         * Scripts/build-api-tests: Removed obsolete code to build vcproj.
2918         * Scripts/build-jsc:
2919         (buildMyProject): Ditto. Removed a condition of buiding bmalloc
2920         which is not used because Windows ports are using CMake.
2921
2922 2018-10-28  Geoffrey Garen  <ggaren@apple.com>
2923
2924         HashMap should support selecting a random entry
2925         https://bugs.webkit.org/show_bug.cgi?id=190814
2926
2927         Reviewed by Ryosuke Niwa.
2928
2929         * TestWebKitAPI/Tests/WTF/HashMap.cpp: Renamed IsRandom to
2930         IsEvenlyDistributed to reflect the fact that we're only testing the
2931         distribution. Added a test case that covers more table densities and
2932         the remove() operation.
2933
2934 2018-10-27  Charlie Turner  <cturner@igalia.com>
2935
2936         [GTK] Add bubblewrap feature option
2937         https://bugs.webkit.org/show_bug.cgi?id=190981
2938
2939         Reviewed by Xabier Rodriguez-Calvar.
2940
2941         Without this, it was not possible to disable the bubblewrap sandbox
2942         from the webkit build scripts.
2943
2944         * Scripts/webkitperl/FeatureList.pm:
2945
2946 2018-10-26  Commit Queue  <commit-queue@webkit.org>
2947
2948         Unreviewed, rolling out r237479 and r237484.
2949         https://bugs.webkit.org/show_bug.cgi?id=190978
2950
2951         broke JSC on iOS (Requested by tadeuzagallo on #webkit).
2952
2953         Reverted changesets:
2954
2955         "New bytecode format for JSC"
2956         https://bugs.webkit.org/show_bug.cgi?id=187373
2957         https://trac.webkit.org/changeset/237479
2958
2959         "Gardening: Build fix after r237479."
2960         https://bugs.webkit.org/show_bug.cgi?id=187373
2961         https://trac.webkit.org/changeset/237484
2962
2963 2018-10-26  Tadeu Zagallo  <tzagallo@apple.com>
2964
2965         New bytecode format for JSC
2966         https://bugs.webkit.org/show_bug.cgi?id=187373
2967         <rdar://problem/44186758>
2968
2969         Reviewed by Filip Pizlo.
2970
2971         Do not force ENABLE_JIT=true when $forceCLoop is false.
2972
2973         * Scripts/build-jsc:
2974
2975 2018-10-26  Geoffrey Garen  <ggaren@apple.com>
2976
2977         HashMap should support selecting a random entry
2978         https://bugs.webkit.org/show_bug.cgi?id=190814
2979
2980         Reviewed by Antti Koivisto.
2981
2982         * TestWebKitAPI/Tests/WTF/HashMap.cpp: Updated the Random_IsRandom to
2983         more thoroughly test for randomness.
2984
2985 2018-10-26  Antti Koivisto  <antti@apple.com>
2986
2987         hashSet.remove(hashSet.random()) doesn't build
2988         https://bugs.webkit.org/show_bug.cgi?id=190953
2989
2990         Reviewed by Chris Dumez.
2991
2992         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
2993         (TestWebKitAPI::TEST):
2994
2995 2018-10-26  Zalan Bujtas  <zalan@apple.com>
2996
2997         [LFC][IFC] Layout floats as part of the inline content
2998         https://bugs.webkit.org/show_bug.cgi?id=190942
2999
3000         Reviewed by Antti Koivisto.
3001
3002         * LayoutReloaded/misc/LFC-passing-tests.txt:
3003
3004 2018-10-26  Alicia Boya García  <aboya@igalia.com>
3005
3006         [MSE][WTF][Media] Invalid MediaTime should be falsy
3007         https://bugs.webkit.org/show_bug.cgi?id=190893
3008
3009         Reviewed by Jer Noble.
3010
3011         This patch adds additional API tests for the conversions from
3012         MediaTime to boolean.
3013
3014         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
3015         (TestWebKitAPI::TEST):
3016
3017 2018-10-25  Chris Dumez  <cdumez@apple.com>
3018
3019         [PSON] Navigating cross-site with locked history but unlocked back/forward list fails to create a new BackForwardListItem
3020         https://bugs.webkit.org/show_bug.cgi?id=190915
3021         <rdar://problem/45059069>
3022
3023         Reviewed by Geoffrey Garen.
3024
3025         Add API test coverage.
3026
3027         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3028
3029 2018-10-25  Joseph Pecoraro  <pecoraro@apple.com>
3030
3031         Web Inspector: Add a watchlist message rule to warn about feature checking new inspector protocol changes
3032         https://bugs.webkit.org/show_bug.cgi?id=190896
3033
3034         Reviewed by Matt Baker.
3035
3036         * Scripts/webkitpy/common/config/watchlist:
3037
3038 2018-10-25  Geoffrey Garen  <ggaren@apple.com>
3039
3040         HashMap should support selecting a random entry
3041         https://bugs.webkit.org/show_bug.cgi?id=190814
3042
3043         Reviewed by Antti Koivisto.
3044
3045         Unit testing is fun and easy!
3046
3047         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3048         (TestWebKitAPI::ZeroHash::hash):
3049         (TestWebKitAPI::TEST):
3050
3051 2018-10-24  Tim Horton  <timothy_horton@apple.com>
3052
3053         REGRESSION (r237331): DismissingActionSheetShouldNotDismissPresentingViewController times out
3054         https://bugs.webkit.org/show_bug.cgi?id=190897
3055
3056         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
3057         (TestWebKitAPI::TEST):
3058         Disable the test for now.
3059
3060 2018-10-24  Alexey Proskuryakov  <ap@apple.com>
3061
3062         Clean up some obsolete macOS version guards
3063         https://bugs.webkit.org/show_bug.cgi?id=190887
3064
3065         Reviewed by Dan Bernstein.
3066
3067         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3068         (__simulated_forceClickAssociatedEventsMask):
3069         (-[TestWKWebViewHostWindow _mouseDownAtPoint:simulatePressure:clickCount:]):
3070         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3071         (WTR::initializeWebViewConfiguration):
3072         * WebKitTestRunner/mac/EventSenderProxy.mm:
3073         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
3074
3075 2018-10-24  Megan Gardner  <megan_gardner@apple.com>
3076
3077         Turn on Conic Gradients
3078         https://bugs.webkit.org/show_bug.cgi?id=190810
3079
3080         Reviewed by Tim Horton.
3081
3082         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3083
3084 2018-10-24  Pablo Saavedra  <psaavedra@igalia.com>
3085
3086         [WPE] Fix CMake rules in for TestWebKitAPIBase library building in developer mode
3087         https://bugs.webkit.org/show_bug.cgi?id=190328
3088
3089         Reviewed by Michael Catanzaro.
3090
3091         * TestWebKitAPI/CMakeLists.txt:
3092         * TestWebKitAPI/PlatformWPE.cmake:
3093
3094 2018-10-24  Chris Dumez  <cdumez@apple.com>
3095
3096         [PSON] When navigating back and forth, 'about:blank' shows up in the back/forward list
3097         https://bugs.webkit.org/show_bug.cgi?id=190846
3098         <rdar://problem/45058938>
3099
3100         Reviewed by Antti Koivisto.
3101
3102         Add API test coverage.
3103
3104         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3105
3106 2018-10-24  Claudio Saavedra  <csaavedra@igalia.com>
3107
3108         [GTK] TestSSL failing because of missing libsoup patch
3109         https://bugs.webkit.org/show_bug.cgi?id=190869
3110
3111         Reviewed by Michael Catanzaro.
3112
3113         * gtk/jhbuild.modules: Add the patch below to fix the API test TestSSL
3114         * gtk/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch: Added.
3115
3116 2018-10-23  Justin Fan  <justin_fan@apple.com>
3117
3118         [WebGPU] Rename old GPU* implementation files to GPULegacy* for WebMetal
3119         https://bugs.webkit.org/show_bug.cgi?id=190817
3120
3121         Reviewed by Dean Jackson.
3122
3123         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3124         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/GPUBuffer.mm.
3125         (TestWebKitAPI::TEST_F):
3126         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Copied from Tools/TestWebKitAPI/Tests/WebCore/mac/GPUFunction.mm.
3127         (TestWebKitAPI::TEST_F):
3128         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/GPUDevice.mm.
3129         (TestWebKitAPI::TEST_F):
3130         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/GPUFunction.mm.
3131         (TestWebKitAPI::TEST_F):
3132         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/GPULibrary.mm.
3133         (TestWebKitAPI::TEST_F):
3134         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/GPUTest.h.
3135
3136 2018-10-23  Chris Dumez  <cdumez@apple.com>
3137
3138         [PSON] Add support for cross-site client-side redirects
3139         https://bugs.webkit.org/show_bug.cgi?id=190806
3140         <rdar://problem/45047344>
3141
3142         Reviewed by Geoffrey Garen.
3143
3144         Add API test coverage.
3145
3146         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3147         (-[PSONNavigationDelegate _webView:willPerformClientRedirectToURL:delay:]):
3148         (-[PSONNavigationDelegate _webView:didPerformClientRedirectFromURL:toURL:]):
3149
3150 2018-10-23  Claudio Saavedra  <csaavedra@igalia.com>
3151
3152         [WPE][GTK] Pass full certificate chain in CertificateInfo coder
3153         https://bugs.webkit.org/show_bug.cgi?id=190789
3154
3155         Reviewed by Michael Catanzaro.
3156
3157         When the network process serializes certificate data to other
3158         processes through the argument coders, the certificate chain, if
3159         present, is lost. In practice this means that applications using
3160         the public API to process certificate info have no details on the
3161         certificate chain, other than the very basics included in the
3162         certificate. Serialize the entire chain if available in the
3163         certificate.
3164
3165         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
3166         (testSSL): Test that the self-signed certificate has no bogus
3167         issuer certificate.
3168
3169 2018-10-22  Tim Horton  <timothy_horton@apple.com>
3170
3171         REGRESSION (r237331): InteractionDeadlockAfterCrash API test fails
3172         https://bugs.webkit.org/show_bug.cgi?id=190801
3173         <rdar://problem/43674361>
3174
3175         * TestWebKitAPI/Tests/WebKitCocoa/InteractionDeadlockAfterCrash.mm:
3176         (TEST):
3177         Use a parented WKWebView for this test, otherwise none of the assertions
3178         about gesture recognizers work anymore.
3179
3180 2018-10-22  Ryan Haddad  <ryanhaddad@apple.com>
3181
3182         REGRESSION (r234081): TestWebKitAPI.VideoControlsManager.VideoControlsManagerAudioElementFollowingUserInteraction is a flaky timeout
3183         https://bugs.webkit.org/show_bug.cgi?id=187972
3184
3185         Unreviewed test gardening.
3186
3187         * TestWebKitAPI/Tests/WebKitCocoa/VideoControlsManager.mm:
3188         (TestWebKitAPI::TEST): Disable the flaky test.
3189
3190 2018-10-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3191
3192         [iOS] [Datalist] fast/forms/datalist/datalist-show-hide.html fails
3193         https://bugs.webkit.org/show_bug.cgi?id=190777
3194
3195         Reviewed by Tim Horton.
3196
3197         Implement isShowingDataListSuggestions on iOS. See below for more details.
3198
3199         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3200         (WTR::UIScriptController::isShowingDataListSuggestions const):
3201
3202         Add a stub implementation for DumpRenderTree.
3203
3204         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3205         (WTR::UIScriptController::isShowingDataListSuggestions const):
3206
3207         Move this stub implementation to !PLATFORM(COCOA).
3208
3209         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3210         (WTR::forEachViewInHierarchy):
3211
3212         Add a helper function to apply a given function to a UIView and each of its subviews, recursively.
3213
3214         (WTR::UIScriptController::isShowingDataListSuggestions const):
3215
3216         For iOS, return whether the UIRemoteKeyboardWindow contains a subview of type WKDataListSuggestionsPickerView.
3217
3218 2018-10-19  Dan Bernstein  <mitz@apple.com>
3219
3220         [macOS] MiniBrowser has an unused injected bundle
3221         https://bugs.webkit.org/show_bug.cgi?id=190770
3222
3223         Reviewed by Tim Horton.
3224
3225         * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig: Removed.
3226         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Removed the MiniBrowserBundle target,
3227           the Copy Bundle build phase in the MiniBrowser target, and references to removed files.
3228         * MiniBrowser/MiniBrowserWebProcessPlugIn.h: Removed.
3229         * MiniBrowser/MiniBrowserWebProcessPlugIn.m: Removed.
3230         * MiniBrowser/mac/Bundle: Removed.
3231
3232 2018-10-19  Wenson Hsieh  <wenson_hsieh@apple.com>
3233
3234         [iOS] [Datalist] Can't pick datalist suggestions in a stock WKWebView
3235         https://bugs.webkit.org/show_bug.cgi?id=190621
3236         <rdar://problem/45310649>
3237
3238         Reviewed by Tim Horton.
3239
3240         Add a UIScriptController hook to resign first responder on WKWebView. See LayoutTests/ChangeLog for more detail.
3241
3242         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3243         (WTR::UIScriptController::resignFirstResponder):
3244         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3245         (WTR::UIScriptController::resignFirstResponder):
3246         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3247         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3248         (WTR::UIScriptController::resignFirstResponder):
3249         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3250         * WebKitTestRunner/UIScriptControllerCocoa.mm:
3251         (WTR::UIScriptController::resignFirstResponder):
3252         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3253         (WTR::PlatformWebView::makeWebViewFirstResponder):
3254
3255         Implement this method stub on iOS, to ensure that TestController::resetStateToConsistentValues restores first
3256         responder on the WKWebView when running iOS layout tests.
3257
3258         * WebKitTestRunner/ios/TestControllerIOS.mm:
3259         (WTR::TestController::platformResetStateToConsistentValues):
3260
3261         After resigning first responder to dismiss any on-screen keyboard, ensure that we restore first responder.
3262
3263 2018-10-19  Dean Jackson  <dino@apple.com>
3264
3265         ASSERTION FAILED: !frame().animation().hasAnimations() in WebCore::FrameView::didDestroyRenderTree()
3266         https://bugs.webkit.org/show_bug.cgi?id=186946
3267         <rdar://problem/41724248>
3268
3269         Reviewed by Antoine Quint.
3270
3271         If the incoming test has different enableWebAnimationsCSSIntegration options,
3272         then we need to create a new WebView.
3273
3274         * DumpRenderTree/TestOptions.cpp:
3275         (TestOptions::webViewIsCompatibleWithOptions const):
3276
3277 2018-10-19  Charlie Turner  <cturner@igalia.com>
3278
3279         [EME] Fix crash during tracing in  gst_qtdemux_request_protection_context
3280         https://bugs.webkit.org/show_bug.cgi?id=190738
3281
3282         Reviewed by Xabier Rodriguez-Calvar.
3283
3284         Add a GStreamer patch to avoid crashing when the run-time logging
3285         level is TRACE. There was a missing null check which caused many
3286         tests to crash.
3287
3288         * gstreamer/patches/gst-plugins-good-0013-Avoid-warning-when-reporting-about-decryptors.patch: Added.
3289
3290 2018-10-18  Alicia Boya García  <aboya@igalia.com>
3291
3292         [Media] Use nanoseconds as MaximumTimeScale
3293         https://bugs.webkit.org/show_bug.cgi?id=190631
3294
3295         Rebased MediaTime tests covering timescales over the maximum.
3296
3297         Reviewed by Jer Noble.
3298
3299         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
3300         (TestWebKitAPI::TEST):
3301
3302 2018-10-18  Dean Johnson  <dean_johnson@apple.com>
3303
3304         clean-webkit pulls in many unnecessary dependencies in webkitpy
3305         https://bugs.webkit.org/show_bug.cgi?id=190732
3306
3307         Reviewed by Alexey Proskuryakov.
3308
3309         * Scripts/webkitpy/common/host.py:
3310         (Host.__init__): Split out 'bugs', 'bugzilla', and 'web' to only be created when used.
3311         (Host):
3312         (Host.bugs):
3313         (Host.bugzilla):
3314         (Host.web):
3315
3316 2018-10-18  Chris Dumez  <cdumez@apple.com>
3317
3318         [PSON] SuspendedPages do not report meaningful domains in Activity Monitor
3319         https://bugs.webkit.org/show_bug.cgi?id=190721
3320         <rdar://problem/45059699>
3321
3322         Reviewed by Alex Christensen.
3323
3324         Add API test coverage.
3325
3326         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3327
3328 2018-10-18  Alexey Proskuryakov  <ap@apple.com>
3329
3330         Switch from PLATFORM(IOS) to PLATFORM(IOS_FAMILY)
3331         https://bugs.webkit.org/show_bug.cgi?id=190729
3332
3333         Reviewed by Tim Horton.
3334
3335         * DumpRenderTree/AccessibilityController.h:
3336         * DumpRenderTree/AccessibilityTextMarker.h:
3337         * DumpRenderTree/AccessibilityUIElement.cpp:
3338         (AccessibilityUIElement::getJSClass):
3339         * DumpRenderTree/AccessibilityUIElement.h:
3340         * DumpRenderTree/DumpRenderTreeFileDraggingSource.h:
3341         * DumpRenderTree/TestRunner.cpp:
3342         (getSecureEventInputIsEnabledCallback):
3343         (TestRunner::staticFunctions):
3344         (TestRunner::callUIScriptCallback):
3345         * DumpRenderTree/TestRunner.h:
3346         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
3347         * DumpRenderTree/ios/AccessibilityTextMarkerIOS.mm:
3348         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3349         * DumpRenderTree/ios/DumpRenderTreeAppMain.mm:
3350         * DumpRenderTree/ios/DumpRenderTreeBrowserView.mm:
3351         * DumpRenderTree/ios/TextInputControllerIOS.m:
3352         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3353         * DumpRenderTree/mac/AppleScriptController.m:
3354         * DumpRenderTree/mac/DumpRenderTree.mm:
3355         (createWebViewAndOffscreenWindow):
3356         (destroyWebViewAndOffscreenWindow):
3357         (resetWebPreferencesToConsistentValues):
3358         (setDefaultsToConsistentValuesForTesting):
3359         (allocateGlobalControllers):
3360         (releaseGlobalControllers):
3361         (addTestPluginsToPluginSearchPath):
3362         (prepareConsistentTestingEnvironment):
3363         (dumpRenderTree):
3364         (DumpRenderTreeMain):
3365         (dumpFrameAsPDF):
3366         (dumpBackForwardListForAllWindows):
3367         (updateDisplay):
3368         (dump):
3369         (resetWebViewToConsistentStateBeforeTesting):
3370         (runTest):
3371         (displayWebView):
3372         (displayAndTrackRepaintsWebView):
3373         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
3374         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
3375         * DumpRenderTree/mac/DumpRenderTreeMac.h:
3376         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
3377         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
3378         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
3379         (-[DumpRenderTreeWindow close]):
3380         (-[DumpRenderTreeWindow webView]):
3381         (-[DumpRenderTreeWindow webViewStartedAcceleratedCompositing:]):
3382         * DumpRenderTree/mac/EventSendingController.h:
3383         * DumpRenderTree/mac/EventSendingController.mm:
3384         (+[EventSendingController isSelectorExcludedFromWebScript:]):
3385         (+[EventSendingController webScriptNameForSelector:]):
3386         (-[EventSendingController dealloc]):
3387         (-[EventSendingController currentEventTime]):
3388         (-[EventSendingController clearKillRing]):
3389         (modifierFlags):
3390         (-[EventSendingController mouseDown:withModifiers:]):
3391         (-[EventSendingController scalePageBy:atX:andY:]):
3392         (-[EventSendingController mouseUp:withModifiers:]):
3393         (-[EventSendingController mouseMoveToX:Y:]):
3394         (-[EventSendingController mouseScrollByX:andY:continuously:]):
3395         (-[EventSendingController keyDown:withModifiers:withLocation:]):
3396         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3397         (-[FrameLoadDelegate init]):
3398         (-[FrameLoadDelegate dealloc]):
3399         (-[FrameLoadDelegate processWork:]):
3400         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
3401         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
3402         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
3403         * DumpRenderTree/mac/LayoutTestHelper.m:
3404         * DumpRenderTree/mac/MockGeolocationProvider.mm:
3405         (-[MockGeolocationProvider timerFired]):
3406         * DumpRenderTree/mac/TestRunnerMac.mm:
3407         (TestRunner::setMainFrameIsFirstResponder):
3408         (TestRunner::setAutomaticLinkDetectionEnabled):
3409         (TestRunner::setUseDashboardCompatibilityMode):
3410         (TestRunner::isCommandEnabled):
3411         (TestRunner::inspectorTestStubURL):
3412         (TestRunner::apiTestNewWindowDataLoadBaseURL):
3413         (TestRunner::abortModal):
3414         (TestRunner::setTextDirection):
3415         (TestRunner::addChromeInputField):
3416         (TestRunner::removeChromeInputField):
3417         (TestRunner::focusWebView):
3418         (TestRunner::setBackingScaleFactor):
3419         (TestRunner::imageCountInGeneralPasteboard const):
3420         * DumpRenderTree/mac/UIDelegate.h:
3421         * DumpRenderTree/mac/UIDelegate.mm:
3422         (-[UIDelegate modalWindowWillClose:]):
3423         (-[UIDelegate webViewRunModal:]):
3424         (-[UIDelegate webView:supportsFullScreenForElement:withKeyboard:]):
3425         (-[UIDelegate dealloc]):
3426         * Scripts/check-for-inappropriate-objc-class-names:
3427         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3428         * TestRunnerShared/spi/UIKitTestSPI.h:
3429         * TestWebKitAPI/Tests/WTF/darwin/WeakLinking.cpp:
3430         * TestWebKitAPI/Tests/WebCore/MarkedText.cpp:
3431         (WebCore::operator<<):
3432         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
3433         (TestWebKitAPI::TEST):
3434         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:
3435         (TestWebKitAPI::WebCoreNSURLSessionTest::SetUp):
3436         * TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp:
3437         * TestWebKitAPI/Tests/WebKit/NoHistoryItemScrollToFragment.mm:
3438         (TestWebKitAPI::TEST):
3439         * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
3440         (TestWebKitAPI::TEST):
3441         * TestWebKitAPI/Tests/WebKitCocoa/AdditionalReadAccessAllowedURLs.mm:
3442         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
3443         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegate.mm:
3444         (TEST):
3445         * TestWebKitAPI/Tests/WebKitCocoa/BundleRangeHandle.mm:
3446         (TEST):
3447         * TestWebKitAPI/Tests/WebKitCocoa/BundleRangeHandlePlugIn.mm:
3448         (-[BundleRangeHandlePlugIn webProcessPlugInBrowserContextController:didFinishDocumentLoadForFrame:]):
3449         * TestWebKitAPI/Tests/WebKitCocoa/Coding.mm:
3450         (TEST):
3451         * TestWebKitAPI/Tests/WebKitCocoa/CopyHTML.mm:
3452         * TestWebKitAPI/Tests/WebKitCocoa/CopyURL.mm:
3453         (createWebViewWithCustomPasteboardDataEnabled):
3454         * TestWebKitAPI/Tests/WebKitCocoa/Copying.mm:
3455         (TEST):
3456         * TestWebKitAPI/Tests/WebKitCocoa/DataDetection.mm:
3457         * TestWebKitAPI/Tests/WebKitCocoa/DoAfterNextPresentationUpdateAfterCrash.mm:
3458         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
3459         * TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm:
3460         * TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm:
3461         * TestWebKitAPI/Tests/WebKitCocoa/FixedLayoutSize.mm:
3462         * TestWebKitAPI/Tests/WebKitCocoa/FontAttributes.mm:
3463         * TestWebKitAPI/Tests/WebKitCocoa/Geolocation.mm:
3464         * TestWebKitAPI/Tests/WebKitCocoa/InteractionDeadlockAfterCrash.mm:
3465         * TestWebKitAPI/Tests/WebKitCocoa/LocalStorageClear.mm:
3466         (defaultWebsiteCacheDirectory):
3467         (defaultApplicationCacheDirectory):
3468         (TEST):
3469         * TestWebKitAPI/Tests/WebKitCocoa/NSFileManagerExtras.mm:
3470         * TestWebKitAPI/Tests/WebKitCocoa/NowPlaying.mm:
3471         * TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm:
3472         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm:
3473         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
3474         * TestWebKitAPI/Tests/WebKitCocoa/PasteMixedContent.mm:
3475         (TestWebKitAPI::TEST):
3476         * TestWebKitAPI/Tests/WebKitCocoa/PasteRTFD.mm:
3477         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
3478         * TestWebKitAPI/Tests/WebKitCocoa/RenderedImageWithOptions.mm:
3479         (runTestWithWidth):
3480         * TestWebKitAPI/Tests/WebKitCocoa/RenderedImageWithOptionsPlugIn.mm:
3481         (-[RenderedImageWithOptionsPlugIn renderImageWithWidth:completionHandler:]):
3482         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3483         * TestWebKitAPI/Tests/WebKitCocoa/ShrinkToFit.mm:
3484         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
3485         * TestWebKitAPI/Tests/WebKitCocoa/VisibleContentRect.mm:
3486         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3487         (platformCopyRichTextWithMultipleAttachments):
3488         (platformCopyRichTextWithImage):
3489         (platformCopyPNG):
3490         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
3491         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewTargetForAction.mm:
3492         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
3493         * TestWebKitAPI/Tests/WebKitCocoa/WKPDFViewStablePresentationUpdateCallback.mm:
3494         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
3495         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-leaks.mm:
3496         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
3497         (TEST):
3498         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3499         (TEST):
3500         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3501         (TEST):
3502         * TestWebKitAPI/Tests/WebKitCocoa/_WKInputDelegate.mm:
3503         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
3504         * TestWebKitAPI/Tests/WebKitLegacy/ios/SnapshotViaRenderInContext.mm:
3505         * TestWebKitAPI/Tests/WebKitLegacy/mac/AccessingPastedImage.mm:
3506         * TestWebKitAPI/Tests/ios/AccessibilityTestsIOS.mm:
3507         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
3508         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3509         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
3510         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3511         * TestWebKitAPI/Tests/ios/RenderingProgressTests.mm:
3512         * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
3513         * TestWebKitAPI/Tests/ios/SetTimeoutFunction.mm:
3514         * TestWebKitAPI/Tests/ios/SynchronousTimeoutTests.mm:
3515         * TestWebKitAPI/Tests/ios/TestInputDelegate.h:
3516         * TestWebKitAPI/Tests/ios/TestInputDelegate.mm:
3517         * TestWebKitAPI/Tests/ios/TextAutosizingBoost.mm:
3518         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
3519         * TestWebKitAPI/Tests/ios/WKScrollViewDelegate.mm:
3520         * TestWebKitAPI/Tests/ios/WKScrollViewTests.mm:
3521         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
3522         * TestWebKitAPI/Tests/ios/WKWebViewEditActions.mm:
3523         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
3524         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
3525         (-[WKWebView _test_waitForDidFinishNavigation]):
3526         * TestWebKitAPI/cocoa/TestWKWebView.h:
3527         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3528         * TestWebKitAPI/config.h:
3529         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
3530         * TestWebKitAPI/ios/TestWKWebViewController.h:
3531         * TestWebKitAPI/ios/TestWKWebViewController.mm:
3532         * TestWebKitAPI/ios/UIKitSPI.h:
3533         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3534         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3535         (WTR::InjectedBundle::beginTesting):
3536         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
3537         (WTR::TestRunner::inspectorTestStubURL):
3538         * WebKitTestRunner/TestController.cpp:
3539         (WTR::TestController::webProcessName):
3540         (WTR::TestController::networkProcessName):
3541         * WebKitTestRunner/TestInvocation.cpp:
3542         (WTR::TestInvocation::invoke):
3543         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3544         * WebKitTestRunner/cg/TestInvocationCG.cpp:
3545         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3546         (WTR::initializeWebViewConfiguration):
3547         (WTR::TestController::platformCreateWebView):
3548         (WTR::TestController::imageCountInGeneralPasteboard const):
3549         (WTR::TestController::addTestKeyToKeychain):
3550         (WTR::TestController::cleanUpKeychain):
3551         (WTR::TestController::keyExistsInKeychain):
3552         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3553         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3554         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3555
3556 2018-10-18  Chris Dumez  <cdumez@apple.com>
3557
3558         [PSON] Cap number of SuspendedPageProxy objects and allow a WebPageProxy to have more than one
3559         https://bugs.webkit.org/show_bug.cgi?id=190688
3560         <rdar://problem/45354095>
3561
3562         Reviewed by Antti Koivisto.
3563
3564         Extended API test coverage to confirm that:
3565         - We do not accumulate more than 3 suspended processes.
3566         - We can navigate back 3 times and use the page cache for each of these loads.
3567
3568         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3569
3570 2018-10-17  Wenson Hsieh  <wenson_hsieh@apple.com>
3571
3572         Enable the datalist element by default on iOS and macOS
3573         https://bugs.webkit.org/show_bug.cgi?id=190594
3574         <rdar://problem/45281159>
3575
3576         Reviewed by Ryosuke Niwa and Tim Horton.
3577
3578         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3579
3580 2018-10-17  Chris Fleizach  <cfleizach@apple.com>
3581
3582         AX: Certain tags should identify their context to iOS API
3583         https://bugs.webkit.org/show_bug.cgi?id=190622
3584         <rdar://problem/45308194>
3585
3586         Reviewed by Zalan Bujtas.
3587
3588         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3589         (AccessibilityUIElement::stringAttributeValue):
3590         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3591         (WTR::AccessibilityUIElement::stringAttributeValue):
3592
3593 2018-10-16  Sihui Liu  <sihui_liu@apple.com>
3594
3595         Add a switch for Web SQL
3596         https://bugs.webkit.org/show_bug.cgi?id=190271
3597
3598         Reviewed by Ryosuke Niwa.
3599
3600         * WebKitTestRunner/TestController.cpp:
3601         (WTR::TestController::resetPreferencesToConsistentValues):
3602
3603 2018-10-16  Alex Christensen  <achristensen@webkit.org>
3604
3605         Remove InjectedBundleBackForwardList
3606         https://bugs.webkit.org/show_bug.cgi?id=190640
3607
3608         Reviewed by Chris Dumez.
3609
3610         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3611         (WTR::InjectedBundle::dumpBackForwardListsForAllPages):
3612         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3613         (WTR::InjectedBundlePage::prepare):
3614         (WTR::InjectedBundlePage::dumpHistory):
3615         (WTR::hasPrefix): Deleted.
3616         (WTR::compareByTargetName): Deleted.
3617         (WTR::dumpBackForwardListItem): Deleted.
3618         (WTR::InjectedBundlePage::dumpBackForwardList): Deleted.
3619         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3620         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3621         (WTR::TestRunner::clearBackForwardList):
3622
3623 2018-10-16  Dominik Infuehr  <dinfuehr@igalia.com>
3624
3625         Unreviewed, added myself to contributors.json.
3626
3627         * Scripts/webkitpy/common/config/contributors.json:
3628
3629 2018-10-16  Justin Michaud  <justin_michaud@apple.com>
3630
3631         Implement feature flag and bindings for CSS Painting API
3632