[WTF] Add environment variable helpers
[WebKit-https.git] / Tools / ChangeLog
1 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
2
3         [WTF] Add environment variable helpers
4         https://bugs.webkit.org/show_bug.cgi?id=192405
5
6         Reviewed by Michael Catanzaro.
7
8         * DumpRenderTree/mac/DumpRenderTree.mm:
9         (libraryPathForDumpRenderTree):
10         * DumpRenderTree/win/DumpRenderTree.cpp:
11         (libraryPathForDumpRenderTree):
12         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
13         (setUpIOSLayoutTestCommunication):
14         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
15         (beforeAll):
16         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
17         (main):
18         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
19         (WebKitTestBus::run):
20         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
21         (WTR::getOutputDir):
22         (WTR::initializeFontConfigSetting):
23         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
24         (WTR::InjectedBundle::platformInitialize):
25         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
26         (WTR::topLevelPath):
27         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
28         (WTR::topLevelPath):
29         (WTR::getOutputDir):
30         (WTR::activateFonts):
31         * WebKitTestRunner/TestController.cpp:
32         (WTR::TestController::libraryPathForTesting):
33         (WTR::TestController::generateContextConfiguration const):
34         (WTR::TestController::generatePageConfiguration):
35         (WTR::TestController::decideDestinationWithSuggestedFilename):
36         (WTR::TestController::platformAdjustContext):
37         * WebKitTestRunner/TestController.h:
38         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
39         (WTR::TestController::cocoaPlatformInitialize):
40         (WTR::TestController::platformAdjustContext):
41         * WebKitTestRunner/gtk/main.cpp:
42         (main):
43         * WebKitTestRunner/mac/TestControllerMac.mm:
44         (WTR::TestController::configureContentExtensionForTest):
45         * WebKitTestRunner/wpe/main.cpp:
46         (main):
47         Utilize WTF::Environment where possible.
48
49 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
50
51         [iOS] WKWebView callout bar is missing Change Writing Direction item
52         https://bugs.webkit.org/show_bug.cgi?id=190015
53         <rdar://problem/44810366>
54
55         Reviewed by Tim Horton.
56
57         Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
58         macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
59
60         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
61         (TestWebKitAPI::TEST):
62
63 2019-02-15  Chris Dumez  <cdumez@apple.com>
64
65         Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
66         https://bugs.webkit.org/show_bug.cgi?id=194717
67         <rdar://problem/47884404>
68
69         Reviewed by Brady Eidson.
70
71         Add API test coverage.
72
73         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
74
75 2019-02-15  Youenn Fablet  <youenn@apple.com>
76
77         Make navigator.mediaDevices SecureContext
78         https://bugs.webkit.org/show_bug.cgi?id=194666
79
80         Reviewed by Eric Carlson.
81
82         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
83         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
84         (TEST_F):
85
86 2019-02-15  Brian Burg  <bburg@apple.com>
87
88         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
89         https://bugs.webkit.org/show_bug.cgi?id=194411
90         <rdar://problem/47787614>
91
92         Reviewed by Joseph Pecoraro.
93
94         Remove unnecessary soft linking macro usage.
95
96         * DumpRenderTree/mac/TestRunnerMac.mm:
97         (TestRunner::inspectorTestStubURL):
98         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
99         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
100         (WTR::TestRunner::inspectorTestStubURL):
101
102 2019-02-15  Commit Queue  <commit-queue@webkit.org>
103
104         Unreviewed, rolling out r241559 and r241566.
105         https://bugs.webkit.org/show_bug.cgi?id=194710
106
107         Causes layout test crashes under GuardMalloc (Requested by
108         ryanhaddad on #webkit).
109
110         Reverted changesets:
111
112         "[WTF] Add environment variable helpers"
113         https://bugs.webkit.org/show_bug.cgi?id=192405
114         https://trac.webkit.org/changeset/241559
115
116         "Unreviewed build fix for WinCairo Debug after r241559."
117         https://trac.webkit.org/changeset/241566
118
119 2019-02-15  Zalan Bujtas  <zalan@apple.com>
120
121         [LFC] Out-of-flow box is never a float box
122         https://bugs.webkit.org/show_bug.cgi?id=194704
123
124         Reviewed by Antti Koivisto.
125
126         * LayoutReloaded/misc/LFC-passing-tests.txt:
127
128 2019-02-10  Darin Adler  <darin@apple.com>
129
130         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
131         https://bugs.webkit.org/show_bug.cgi?id=194487
132
133         Reviewed by Daniel Bates.
134
135         * DumpRenderTree/win/DumpRenderTree.cpp:
136         (applicationId): Use makeString instead of String::format.
137         (main): Ditto.
138         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
139         (TestWebKitAPI::Util::createURLForResource): Ditto.
140         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
141         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Ditto.
142
143         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
144         (WTR::attributeSetToString): Use StringBuilder functions directly instead of g_strconcat.
145         (WTR::attributesOfElement): Use StringBuilder functions directly instead of String::format.
146         (WTR::createStringWithAttributes): Use appendLiteral.
147         (WTR::AccessibilityUIElement::helpText const): Ditto.
148         (WTR::AccessibilityUIElement::attributedStringForRange): Use StringBuilder functions
149         directly instead of using String::format.
150         (WTR::AccessibilityUIElement::url): Use makeString instead of String::format.
151         (WTR::stringAtOffset): Use StringBuilder::appendNumber instead of String::format.
152
153 2019-02-15  Truitt Savell  <tsavell@apple.com>
154
155         Unreviewed, rolling out r241564.
156
157         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
158
159         Reverted changeset:
160
161         "[Mac] WebInspectorUI.framework does not need to be soft-
162         linked anymore"
163         https://bugs.webkit.org/show_bug.cgi?id=194411
164         https://trac.webkit.org/changeset/241564
165
166 2019-02-15  Saam barati  <sbarati@apple.com>
167
168         [WebAssembly] Write a new register allocator for Air O0 and make BBQ use it
169         https://bugs.webkit.org/show_bug.cgi?id=194036
170
171         Reviewed by Yusuke Suzuki.
172
173         * Scripts/run-jsc-stress-tests:
174
175 2019-02-14  Tim Horton  <timothy_horton@apple.com>
176
177         Fix the build.
178
179         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
180         (WTR::UIScriptController::drawSquareInEditableImage):
181         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
182         (TestWebKitAPI::drawSquareInEditableImage):
183
184 2019-02-14  Tim Horton  <timothy_horton@apple.com>
185
186         Fix the build.
187
188         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
189         (WTR::UIScriptController::drawSquareInEditableImage):
190         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
191         (TestWebKitAPI::drawSquareInEditableImage):
192
193 2019-02-14  Brian Burg  <bburg@apple.com>
194
195         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
196         https://bugs.webkit.org/show_bug.cgi?id=194411
197         <rdar://problem/47787614>
198
199         Reviewed by Joseph Pecoraro.
200
201         Remove unnecessary soft linking macro usage.
202
203         * DumpRenderTree/mac/TestRunnerMac.mm:
204         (TestRunner::inspectorTestStubURL):
205         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
206         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
207         (WTR::TestRunner::inspectorTestStubURL):
208
209 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
210
211         [ews-app] status bubble should fetch builder name info from BuilderMapping table
212         https://bugs.webkit.org/show_bug.cgi?id=194599
213
214         Reviewed by Lucas Forschler.
215
216         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
217         (StatusBubble._build_bubble):
218
219 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
220
221         [ews-app] Set Foreign Key in Django build model
222         https://bugs.webkit.org/show_bug.cgi?id=194667
223
224         Reviewed by Lucas Forschler.
225
226         * BuildSlaveSupport/ews-app/ews/models/build.py:
227         (Build):
228
229 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
230
231         [WTF] Add environment variable helpers
232         https://bugs.webkit.org/show_bug.cgi?id=192405
233
234         Reviewed by Michael Catanzaro.
235
236         * DumpRenderTree/mac/DumpRenderTree.mm:
237         (libraryPathForDumpRenderTree):
238         * DumpRenderTree/win/DumpRenderTree.cpp:
239         (libraryPathForDumpRenderTree):
240         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
241         (setUpIOSLayoutTestCommunication):
242         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
243         (TestWebKitAPI::strip):
244         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
245         (beforeAll):
246         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
247         (main):
248         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
249         (WebKitTestBus::run):
250         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
251         (WTR::getOutputDir):
252         (WTR::initializeFontConfigSetting):
253         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
254         (WTR::InjectedBundle::platformInitialize):
255         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
256         (WTR::topLevelPath):
257         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
258         (WTR::topLevelPath):
259         (WTR::getOutputDir):
260         (WTR::activateFonts):
261         * WebKitTestRunner/TestController.cpp:
262         (WTR::TestController::libraryPathForTesting):
263         (WTR::TestController::generateContextConfiguration const):
264         (WTR::TestController::generatePageConfiguration):
265         (WTR::TestController::decideDestinationWithSuggestedFilename):
266         (WTR::TestController::platformAdjustContext):
267         * WebKitTestRunner/TestController.h:
268         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
269         (WTR::TestController::cocoaPlatformInitialize):
270         (WTR::TestController::platformAdjustContext):
271         * WebKitTestRunner/gtk/main.cpp:
272         (main):
273         * WebKitTestRunner/mac/TestControllerMac.mm:
274         (WTR::TestController::configureContentExtensionForTest):
275         * WebKitTestRunner/wpe/main.cpp:
276         (main):
277         Utilize WTF::Environment where possible.
278
279 2019-02-14  Chris Dumez  <cdumez@apple.com>
280
281         [PSON] Introduce a WebContent Process cache
282         https://bugs.webkit.org/show_bug.cgi?id=194594
283         <rdar://problem/46793397>
284
285         Reviewed by Geoff Garen.
286
287         Update API tests to turn on the WebContent Process cache.
288
289         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
290
291 2019-02-14  Jiewen Tan  <jiewen_tan@apple.com>
292
293         Unreviewed, build fix after r241480
294
295         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
296         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
297         (-[DragAndDropSimulator initWithWebView:]):
298
299 2019-02-14  Chris Fleizach  <cfleizach@apple.com>
300
301         AX: ARIA Reflection was disabled in error
302         https://bugs.webkit.org/show_bug.cgi?id=194647
303         <rdar://problem/48068336>
304
305         Reviewed by Ryosuke Niwa.
306
307         Remove test override now that this feature should be enabled by default.
308
309         * WebKitTestRunner/TestController.cpp:
310         (WTR::TestController::resetPreferencesToConsistentValues):
311
312 2019-02-14  Commit Queue  <commit-queue@webkit.org>
313
314         Unreviewed, rolling out r241486.
315         https://bugs.webkit.org/show_bug.cgi?id=194655
316
317         causing API failures in builds (Requested by ShawnRoberts on
318         #webkit).
319
320         Reverted changeset:
321
322         "[Cocoa] Media elements will restart network buffering just
323         before suspending"
324         https://bugs.webkit.org/show_bug.cgi?id=193691
325         https://trac.webkit.org/changeset/241486
326
327 2019-02-14  Zalan Bujtas  <zalan@apple.com>
328
329         [LFC][BFC][MarginCollapse] Replaced boxes don't collapse through their margins
330         https://bugs.webkit.org/show_bug.cgi?id=194622
331
332         Reviewed by Antti Koivisto.
333
334         * LayoutReloaded/misc/LFC-passing-tests.txt:
335
336 2019-02-14  Zalan Bujtas  <zalan@apple.com>
337
338         [LFC] Shrink-to-fit-width should be constrained by min/max width
339         https://bugs.webkit.org/show_bug.cgi?id=194653
340
341         Reviewed by Antti Koivisto.
342
343         * LayoutReloaded/misc/LFC-passing-tests.txt:
344
345 2019-02-13  Ryosuke Niwa  <rniwa@webkit.org>
346
347         Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
348         https://bugs.webkit.org/show_bug.cgi?id=194641
349
350         Reviewed by Geoffrey Garen.
351
352         Added a call to WKBundleFrameGetParentFrame to an existing test for didRemoveFrameFromHierarchy
353         so that the test would fail without this fix.
354
355         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
356         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
357
358 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
359
360         [ews-app] Change log level for a log statement
361
362         Unreviewed minor fix.
363
364         * BuildSlaveSupport/ews-app/ews/models/patch.py:
365         (Patch.save_patch):
366
367 2019-02-13  Jer Noble  <jer.noble@apple.com>
368
369         [Cocoa] Media elements will restart network buffering just before suspending
370         https://bugs.webkit.org/show_bug.cgi?id=193691
371
372         Reviewed by Eric Carlson.
373
374         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
375         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
376         (TEST):
377
378 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
379
380         [ews-app] Fetch builder id to name mapping
381         https://bugs.webkit.org/show_bug.cgi?id=194355
382
383         Reviewed by Lucas Forschler.
384
385         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
386         (Buildbot.get_builder_id_to_name_mapping):
387         (Buildbot._get_display_name_from_builder_name):
388
389 2019-02-12  Jiewen Tan  <jiewen_tan@apple.com>
390
391         Further restricting webarchive loads
392         https://bugs.webkit.org/show_bug.cgi?id=194567
393         <rdar://problem/47610130>
394
395         Reviewed by Youenn Fablet.
396
397         Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
398         navigations on drop.
399
400         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
401         * TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.
402         (-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
403         (-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
404         (-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
405         (TestWebKitAPI::TEST):
406         * TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
407         * TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
408         * TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
409         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
410         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
411         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
412         (-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):
413
414 2019-02-13  John Wilander  <wilander@apple.com>
415
416         Store Ad Click Attribution requests in the network process
417         https://bugs.webkit.org/show_bug.cgi?id=194510
418         <rdar://problem/47650118>
419
420         Reviewed by Alex Christensen and Daniel Bates.
421
422         This patch adds two TestRunner functions:
423         - dumpAdClickAttribution()
424         - clearAdClickAttribution()
425
426         They call into the network process to dump and clear Ad Click
427         Attribution state, respectively.
428
429         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
430         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
431         (WTR::TestRunner::dumpAdClickAttribution):
432         (WTR::TestRunner::clearAdClickAttribution):
433         * WebKitTestRunner/InjectedBundle/TestRunner.h:
434         * WebKitTestRunner/TestController.cpp:
435         (WTR::TestController::resetStateToConsistentValues):
436         (WTR::AdClickAttributionStringResultCallbackContext::AdClickAttributionStringResultCallbackContext):
437         (WTR::adClickAttributionStringResultCallback):
438         (WTR::TestController::dumpAdClickAttribution):
439         (WTR::AdClickAttributionVoidCallbackContext::AdClickAttributionVoidCallbackContext):
440         (WTR::adClickAttributionVoidCallback):
441         (WTR::TestController::clearAdClickAttribution):
442         * WebKitTestRunner/TestController.h:
443         * WebKitTestRunner/TestInvocation.cpp:
444         (WTR::TestInvocation::dumpResults):
445         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
446         (WTR::TestInvocation::dumpAdClickAttribution):
447         * WebKitTestRunner/TestInvocation.h:
448
449 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
450
451         [ews-app] Generate status-bubble
452         https://bugs.webkit.org/show_bug.cgi?id=194572
453
454         Reviewed by Lucas Forschler.
455
456         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
457         (StatusBubble._build_bubble):
458         (StatusBubble._should_show_bubble_for):
459         (StatusBubble._build_bubbles_for_patch):
460
461 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
462
463         [ews-app] Add status bubble html template
464         https://bugs.webkit.org/show_bug.cgi?id=194571
465
466         Reviewed by Lucas Forschler.
467
468         * BuildSlaveSupport/ews-app/ews/templates: Added.
469         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Copied from QueueStatusServer/templates/statusbubble.html.
470
471 2019-02-12  Chris Dumez  <cdumez@apple.com>
472
473         Regression(PSON) MESSAGE_CHECK() hit under WebPageProxy::didFailProvisionalLoadForFrameShared()
474         https://bugs.webkit.org/show_bug.cgi?id=194568
475         <rdar://problem/47944490>
476
477         Reviewed by Ryosuke Niwa.
478
479         Add API test coverage.
480
481         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
482         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
483
484 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
485
486         webkitpy: Remove bug_dummy from parsed test expectations
487         https://bugs.webkit.org/show_bug.cgi?id=194562
488         <rdar://problem/47853999>
489
490         Reviewed by Lucas Forschler.
491
492         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
493         (TestExpectationParser):
494         (TestExpectationParser.expectation_for_skipped_test): Remove DUMMY_BUG_MODIFIER from
495         skipped tests.
496         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
497
498 2019-02-12  Aakash Jain  <aakash_jain@apple.com>
499
500         [ews-app] Add method to fetch patch
501         https://bugs.webkit.org/show_bug.cgi?id=194518
502
503         Reviewed by Lucas Forschler.
504
505         * BuildSlaveSupport/ews-app/ews/models/patch.py:
506         (Patch.get_patch):
507
508 2019-02-12  Zalan Bujtas  <zalan@apple.com>
509
510         [LFC] Expand tests coverage (60 new tests -> 860)
511
512         Unreviewed test gardening (run-singly, --child-processes=1).
513
514         * LayoutReloaded/misc/LFC-passing-tests.txt:
515
516 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
517
518         Allow pages to trigger programmatic paste from script on iOS
519         https://bugs.webkit.org/show_bug.cgi?id=194271
520         <rdar://problem/47808810>
521
522         Reviewed by Tim Horton.
523
524         Add support for interacting with the callout bar on iOS during layout tests. See below for more detail.
525
526         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
527         (WTR::UIScriptController::platformSetDidShowMenuCallback):
528         (WTR::UIScriptController::platformSetDidHideMenuCallback):
529         (WTR::UIScriptController::rectForMenuAction const):
530
531         Add new mechanisms to make it possible to interact with and query the state of the callout menu on iOS. This
532         includes determining the rect (in content view coordinates) of the menu's controls, and callbacks to register
533         for when the menu is shown or hidden.
534
535         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
536         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
537         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
538         (WTR::UIScriptController::setDidShowMenuCallback):
539         (WTR::UIScriptController::didShowMenuCallback const):
540         (WTR::UIScriptController::setDidHideMenuCallback):
541         (WTR::UIScriptController::didHideMenuCallback const):
542         (WTR::UIScriptController::platformSetDidShowMenuCallback):
543         (WTR::UIScriptController::platformSetDidHideMenuCallback):
544         (WTR::UIScriptController::rectForMenuAction const):
545         * TestRunnerShared/UIScriptContext/UIScriptController.h:
546         * WebKitTestRunner/TestController.cpp:
547         (WTR::TestController::resetPreferencesToConsistentValues):
548         (WTR::updateTestOptionsFromTestHeader):
549         * WebKitTestRunner/TestOptions.h:
550
551         Add a new test option to determine whether DOM paste is enabled. DOM paste is currently enabled everywhere by
552         default, but these new programmatic paste tests require it to be disabled in order for confirmation UI to show.
553
554         (WTR::TestOptions::hasSameInitializationOptions const):
555         * WebKitTestRunner/UIScriptControllerCocoa.mm:
556         (WTR::UIScriptController::calendarType const):
557         (WTR::UIScriptController::platformUndoManager const):
558         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
559         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
560         (-[TestRunnerWKWebView initWithFrame:configuration:]):
561         (-[TestRunnerWKWebView dealloc]):
562         (-[TestRunnerWKWebView _didShowMenu]):
563         (-[TestRunnerWKWebView _didHideMenu]):
564
565         Listen to when the callout bar is presented and dismissed, and invoke testing callbacks as needed.
566
567         * WebKitTestRunner/ios/TestControllerIOS.mm:
568         (WTR::handleMenuWillHideNotification):
569         (WTR::handleMenuDidHideNotification):
570         (WTR::TestController::platformInitialize):
571         (WTR::TestController::platformDestroy):
572         (WTR::TestController::platformResetStateToConsistentValues):
573
574         Additionally ensure that any callout menu presented by a previous layout test is dismissed before running the
575         next test by hiding the callout bar if necessary, and then waiting for the "DidHide" notification.
576
577         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
578         (WTR::forEachViewInHierarchy):
579         (WTR::findViewInHierarchyOfType):
580
581         Move `forEachViewInHierarchy` so that we can use it throughout the file, and then add some additional helper
582         functions that dig through a given view's hierarchy in search of a view of a given class.
583
584         (WTR::UIScriptController::selectionStartGrabberViewRect const):
585         (WTR::UIScriptController::selectionEndGrabberViewRect const):
586         (WTR::UIScriptController::selectionCaretViewRect const):
587         (WTR::UIScriptController::selectionRangeViewRects const):
588         (WTR::UIScriptController::platformSetDidShowMenuCallback):
589         (WTR::UIScriptController::platformSetDidHideMenuCallback):
590
591         Tweak these to use `platformContentView` instead of grabbing the content view from WKWebView directly.
592
593         (WTR::UIScriptController::rectForMenuAction const):
594
595         Add a new UIScriptController method to get the rect of the action in the contextual menu (on iOS, this is the
596         callout bar) whose label matches the given string.
597
598         (WTR::UIScriptController::platformContentView const):
599
600         Add a `platformContentView()` helper on UIScriptController so that we can stop grabbing the value for key
601         "_currentContentView" from various places in this file. Additionally, rewrite `platformUndoManager()` in terms
602         of this new helper, and move the code out from iOS/macOS-specific files into UIScriptControllerCocoa.
603
604         (WTR::UIScriptController::platformUndoManager const): Deleted.
605         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
606         (WTR::UIScriptController::platformContentView const):
607         (WTR::UIScriptController::platformUndoManager const): Deleted.
608
609 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
610
611         webkitpy: No option to only show unexpected failures in results.html for iPad
612         https://bugs.webkit.org/show_bug.cgi?id=194554
613         <rdar://problem/47922442>
614
615         Rubber-stamped by Aakash Jain.
616
617         Just because a TestExpecations file does not exist for a specific platform does not mean that
618         TestExpecations are not being used, given that platforms inherit test expectations.
619
620         * Scripts/webkitpy/port/base.py:
621         (Port.uses_test_expectations_file): Check all possible locations of a TestExpectations file.
622         * Scripts/webkitpy/port/base_unittest.py:
623         (PortTest.test_uses_test_expectations_file):
624
625 2019-02-12  Alex Christensen  <achristensen@webkit.org>
626
627         Remove setDefersLoading infrastructure from WebKit2
628         https://bugs.webkit.org/show_bug.cgi?id=194506
629
630         Reviewed by Brady Eidson.
631
632         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
633         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
634         (WTR::TestRunner::setDefersLoading): Deleted.
635         * WebKitTestRunner/InjectedBundle/TestRunner.h:
636
637 2019-02-12  Alex Christensen  <achristensen@webkit.org>
638
639         WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage
640         https://bugs.webkit.org/show_bug.cgi?id=194522
641         <rdar://problem/47789393>
642
643         Reviewed by Chris Dumez.
644
645         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
646         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm: Added.
647         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
648         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
649
650 2019-02-12  Andy Estes  <aestes@apple.com>
651
652         [iOSMac] Enable Parental Controls Content Filtering
653         https://bugs.webkit.org/show_bug.cgi?id=194521
654         <rdar://39732376>
655
656         Reviewed by Tim Horton.
657
658         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
659
660 2019-02-12  Zalan Bujtas  <zalan@apple.com>
661
662         [LFC][IFC] Add intrinsic width support for float boxes.
663         https://bugs.webkit.org/show_bug.cgi?id=194528
664
665         Reviewed by Antti Koivisto.
666
667         Expand tests coverage (2 new tests -> 800).
668         (This is the correct test ordering --runs-singly --child-processes=1)
669
670         * LayoutReloaded/misc/LFC-passing-tests.txt:
671
672 2019-02-12  Rob Buis  <rbuis@igalia.com>
673
674         Implement serializing in MIME type parser
675         https://bugs.webkit.org/show_bug.cgi?id=193909
676
677         Reviewed by Darin Adler.
678
679         Add various tests involving upper case, non-ASCII, control/null characters,
680         various HTTP whitespace, single quotes and an unpaired surrogate.
681
682         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
683         (TestWebKitAPI::escapeNonASCIIPrintableCharacters):
684         (TestWebKitAPI::serializeIfValid):
685         (TestWebKitAPI::TEST):
686
687 2019-02-11  Myles C. Maxfield  <mmaxfield@apple.com>
688
689         [Cocoa] Ask platform for generic font family mappings
690         https://bugs.webkit.org/show_bug.cgi?id=187723
691         <rdar://problem/41892438>
692
693         Reviewed by Brent Fulgham.
694
695         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
696
697         * DumpRenderTree/mac/DumpRenderTree.mm:
698         (allowedFontFamilySet):
699         * WebKitTestRunner/mac/TestControllerMac.mm:
700         (WTR::allowedFontFamilySet):
701
702 2019-02-11  Adrian Perez de Castro  <aperez@igalia.com>
703
704         [GTK][WPE] Add content extensions support in WKTR and unskip layout tests
705         https://bugs.webkit.org/show_bug.cgi?id=193622
706
707         Reviewed by Michael Catanzaro.
708
709         This adds support for loading content extension rule sets from the JSON files which
710         accompany the corresponding layout test, using the C API. The Cocoa specific parts
711         of WKTR for this could be removed, but that is left for a follow-up patch with
712         cleanups.
713
714         * Scripts/webkitperl/FeatureList.pm: Add an option to toggle CONTENT_EXTENSIONS.
715         * WebKitTestRunner/TestController.cpp:
716         (WTR::testPath): Subtract one from the length when constructing the result std::string to
717         avoid having the null-terminator copied into the result.
718         (WTR::TestController::configureViewForTest): Call configureContentExtensionForTest() as
719         part of the preparations to run a test.
720         (WTR::ContentExtensionStoreCallbackContext::ContentExtensionStoreCallbackContext): Added.
721         (WTR::contentExtensionStoreCallback): Added.
722         (WTR::contentExtensionJSONPath): Used to calculate the path to the JSON rule set to be
723         used for content extensions test.
724         (WTR::TestController::configureContentExtensionForTest): Added, handles enabling content
725         extensions and compiling the JSON rule set for tests involving content extensions.
726         (WTR::TestController::resetContentExtensions): Removes the content extension built for
727         testing and disables content extensions.
728         (WTR::TestController::resetPreferencesToConsistentValues): Add a call to
729         resetContentExtensions().
730         (WTR::TestController::userContentController): Added implementation for ports other than Cocoa.
731         * WebKitTestRunner/TestController.h: Add declarations for resetContentExtensions(),
732         configureContentExtensionForTest(), and userContentController().
733
734 2019-02-11  Daniel Bates  <dabates@apple.com>
735
736         [iOS] Mouse/Touch/Pointer events are missing modifier keys
737         https://bugs.webkit.org/show_bug.cgi?id=191446
738         <rdar://problem/45929460>
739
740         Reviewed by Tim Horton.
741
742         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
743
744         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
745         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
746         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
747         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
748         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
749         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
750         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
751         * TestRunnerShared/UIScriptContext/UIScriptController.h:
752         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
753         (WTR::arrayLength):
754         (WTR::parseModifierArray):
755         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
756         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
757         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
758         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
759
760 2019-02-11  Commit Queue  <commit-queue@webkit.org>
761
762         Unreviewed, rolling out r241272 and r241276.
763         https://bugs.webkit.org/show_bug.cgi?id=194514
764
765         Broke the Apple Internal build and the fix requires human
766         intervention :( (Requested by dydz on #webkit).
767
768         Reverted changesets:
769
770         "[iOS] Mouse/Touch/Pointer events are missing modifier keys"
771         https://bugs.webkit.org/show_bug.cgi?id=191446
772         https://trac.webkit.org/changeset/241272
773
774         "Fix internal iOS build after r241272"
775         https://bugs.webkit.org/show_bug.cgi?id=191446
776         https://trac.webkit.org/changeset/241276
777
778 2019-02-11  Truitt Savell  <tsavell@apple.com>
779
780         Unreviewed, rolling out r241269.
781
782         Caused 5 layout tests crashes on Mac WK1
783
784         Reverted changeset:
785
786         "DumpRenderTree should report unknown options"
787         https://bugs.webkit.org/show_bug.cgi?id=191303
788         https://trac.webkit.org/changeset/241269
789
790 2019-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
791
792         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
793         https://bugs.webkit.org/show_bug.cgi?id=194313
794
795         Reviewed by Tim Horton.
796
797         Add a helper to determine whether the web view is presenting modal UI.
798
799         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
800         (WTR::UIScriptController::isPresentingModally const):
801         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
802         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
803         (WTR::UIScriptController::isPresentingModally const):
804         * TestRunnerShared/UIScriptContext/UIScriptController.h:
805         * WebKitTestRunner/UIScriptControllerCocoa.mm:
806         (WTR::UIScriptController::calendarType const): Deleted.
807         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
808         (WTR::UIScriptController::isPresentingModally const):
809         (WTR::UIScriptController::calendarType const):
810         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
811         (WTR::UIScriptController::calendarType const):
812
813 2019-02-11  Joseph Pecoraro  <pecoraro@apple.com>
814
815         GCHeapInspector: Show the retained sizes in more places
816         https://bugs.webkit.org/show_bug.cgi?id=194464
817
818         Reviewed by Simon Fraser.
819
820         * GCHeapInspector/gc-heap-inspector.html:
821         * GCHeapInspector/script/interface.js:
822         (HeapInspectorUtils.humanReadableSize):
823         (HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
824         (HeapInspectorUtils.spanForNode.span.span):
825         (HeapSnapshotInspector.prototype.buildAllObjectsByType):
826         (HeapSnapshotInspector.prototype.buildRoots):
827
828 2019-02-11  Daniel Bates  <dabates@apple.com>
829
830         [iOS] Mouse/Touch/Pointer events are missing modifier keys
831         https://bugs.webkit.org/show_bug.cgi?id=191446
832         <rdar://problem/45929460>
833
834         Reviewed by Tim Horton.
835
836         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
837
838         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
839         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
840         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
841         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
842         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
843         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
844         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
845         * TestRunnerShared/UIScriptContext/UIScriptController.h:
846         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
847         (WTR::arrayLength):
848         (WTR::parseModifierArray):
849         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
850         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
851         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
852         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
853
854 2019-02-11  Darshan Kadu  <dkadu@igalia.com>
855
856         DumpRenderTree should report unknown options
857         https://bugs.webkit.org/show_bug.cgi?id=191303
858
859         Reviewed by Frédéric Wang.
860
861         Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
862         to report unknown options.
863         Added and assigned test options which are currently used in tests.
864
865         * DumpRenderTree/TestOptions.cpp:
866         (TestOptions::TestOptions):
867
868 2019-02-11  Truitt Savell  <tsavell@apple.com>
869
870         Unreviewed, rolling out r241229.
871
872         Revision broke internal builds for watchOS.
873
874         Reverted changeset:
875
876         "[Cocoa] Ask platform for generic font family mappings"
877         https://bugs.webkit.org/show_bug.cgi?id=187723
878         https://trac.webkit.org/changeset/241229
879
880 2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
881
882         [WinCairo][MiniBrowser] Basic authentication always fails.
883         https://bugs.webkit.org/show_bug.cgi?id=194496
884
885         Reviewed by Don Olmstead.
886
887         * MiniBrowser/win/DialogHelper.h:
888         (Dialog::getText):
889
890 2019-02-11  Philippe Normand  <pnormand@igalia.com>
891
892         [GStreamer] GstMappedBuffer testsuite build fails
893         https://bugs.webkit.org/show_bug.cgi?id=194495
894
895         Reviewed by Carlos Garcia Campos.
896
897         Fix the build by explicitely adding the gstreamer1.0-audio include
898         directories to the include path.
899
900         * TestWebKitAPI/PlatformGTK.cmake:
901         * TestWebKitAPI/PlatformWPE.cmake:
902
903 2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
904
905         [GTK][WPE] Add enable-javascript-markup setting
906         https://bugs.webkit.org/show_bug.cgi?id=193439
907
908         Reviewed by Michael Catanzaro.
909
910         Add test cases to check the new setting.
911
912         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
913         (testWebKitSettings):
914         (testWebKitSettingsJavaScriptMarkup):
915         (beforeAll):
916
917 2019-02-10  Darin Adler  <darin@apple.com>
918
919         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
920         https://bugs.webkit.org/show_bug.cgi?id=194485
921
922         Reviewed by Daniel Bates.
923
924         * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
925
926 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
927
928         Add more tests for clampTo<>()
929         https://bugs.webkit.org/show_bug.cgi?id=194462
930
931         Reviewed by Geoffrey Garen.
932
933         Darin suggested to test the very last floating point number
934         at the boundaries when truncating to integer.
935         I added test for max/min and max-1/min-1.
936
937         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
938         (TestWebKitAPI::TEST):
939
940 2019-02-09  Darin Adler  <darin@apple.com>
941
942         Eliminate unnecessary String temporaries by using StringConcatenateNumbers
943         https://bugs.webkit.org/show_bug.cgi?id=194021
944
945         Reviewed by Geoffrey Garen.
946
947         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
948         (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
949         to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
950
951 2019-02-09  Zalan Bujtas  <zalan@apple.com>
952
953         [LFC][IFC] Add intrinsic width support for basic inline containers
954         https://bugs.webkit.org/show_bug.cgi?id=194473
955
956         Reviewed by Antti Koivisto.
957
958         Expand tests coverage (11 new tests -> 798)
959
960         * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
961
962 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
963
964         Fix MiniBrowser's entitlements
965         https://bugs.webkit.org/show_bug.cgi?id=192431
966
967         Reviewed by Joseph Pecoraro.
968
969         MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
970         files, making it impossible to load any extension.
971
972         * MiniBrowser/MiniBrowser.entitlements:
973
974 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
975
976         [Cocoa] Ask platform for generic font family mappings
977         https://bugs.webkit.org/show_bug.cgi?id=187723
978         <rdar://problem/41892438>
979
980         Reviewed by Brent Fulgham.
981
982         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
983
984         * DumpRenderTree/mac/DumpRenderTree.mm:
985         (allowedFontFamilySet):
986         * WebKitTestRunner/mac/TestControllerMac.mm:
987         (WTR::allowedFontFamilySet):
988
989 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
990
991         [GTK] Implement back/forward touchpad gesture
992         https://bugs.webkit.org/show_bug.cgi?id=193919
993
994         Reviewed by Michael Catanzaro.
995
996         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
997         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
998
999 2019-02-08  Alex Christensen  <achristensen@webkit.org>
1000
1001         Add SPI to use networking daemon instead of XPC service
1002         https://bugs.webkit.org/show_bug.cgi?id=194427
1003
1004         Reviewed by Geoffrey Garen
1005
1006         * MiniBrowser/MiniBrowser.entitlements:
1007
1008 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
1009
1010         [ews-build] Ensure that every builder in config.json has short name
1011         https://bugs.webkit.org/show_bug.cgi?id=194461
1012
1013         Reviewed by Lucas Forschler.
1014
1015         * BuildSlaveSupport/ews-build/loadConfig.py:
1016         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
1017
1018 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
1019
1020         [ews-build] Add short name to config.json
1021         https://bugs.webkit.org/show_bug.cgi?id=194456
1022
1023         Reviewed by Lucas Forschler.
1024
1025         * BuildSlaveSupport/ews-build/config.json: Added short name.
1026         * BuildSlaveSupport/ews-build/loadConfig.py:
1027         (loadBuilderConfig): Set the short name as the builder description.
1028
1029 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
1030
1031         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
1032         https://bugs.webkit.org/show_bug.cgi?id=194418
1033
1034         Reviewed by Lucas Forschler.
1035
1036         Do not include errors trying when finding crashlogs at the end of
1037         a run-webkit-tests run since we don't process those errors.
1038
1039         * Scripts/webkitpy/port/darwin.py:
1040         (DarwinPort._look_for_all_crash_logs_in_log_dir):
1041         * Scripts/webkitpy/port/ios_device.py:
1042         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
1043         * Scripts/webkitpy/port/watch_device.py:
1044         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
1045
1046 2019-02-08  Beth Dakin  <bdakin@apple.com>
1047
1048         Add afterScreenUpdates to WKSnapshotConfiguration
1049         https://bugs.webkit.org/show_bug.cgi?id=194362
1050         -and corresponding-
1051         <rdar://problem/40655528> Please add an "after screen updates" property to 
1052         WKSnapshotConfiguration (to solve blank snapshots)
1053
1054         Reviewed by Tim Horton.
1055
1056         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
1057         (TEST):
1058
1059 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
1060
1061         clampTo(): do not convert the input to double when dealing with integers
1062         https://bugs.webkit.org/show_bug.cgi?id=194263
1063         <rdar://problem/47692312>
1064
1065         Reviewed by Darin Adler.
1066
1067         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1068         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
1069         (TestWebKitAPI::testClampFloatingPointToInteger):
1070         (TestWebKitAPI::testClampSameSignIntegers):
1071         (TestWebKitAPI::testClampUnsignedToSigned):
1072         (TestWebKitAPI::testClampSignedToUnsigned):
1073
1074 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
1075
1076         webkitpy: Respect --dedicated-simulators flag
1077         https://bugs.webkit.org/show_bug.cgi?id=194416
1078         <rdar://problem/47894722>
1079
1080         Reviewed by Lucas Forschler.
1081
1082         * Scripts/webkitpy/port/device_port.py:
1083         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
1084         available devices can be safely ignored.
1085
1086 2019-02-07  Keith Rollin  <krollin@apple.com>
1087
1088         Remove extra copy of 100x100-red.tga
1089         https://bugs.webkit.org/show_bug.cgi?id=194371
1090         <rdar://problem/47873465>
1091
1092         Reviewed by Said Abou-Hallawa.
1093
1094         In order to help it pass its tests, Bug 194190 added a second copy of
1095         the file 100x100-red.tga. However, it turns out that this additional
1096         file wasn't actually needed, and that that sole previous copy was
1097         sufficient. At the same time, this second copy -- which was copied to
1098         the same location in the build output as the first copy -- now caused
1099         XCBuild to complain because there were two production rules for the
1100         same output file. Address this by removing the newly-added extra copy.
1101
1102         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1103         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
1104
1105 2019-02-07  Alex Christensen  <achristensen@webkit.org>
1106
1107         Deprecate WKBundlePageSetDefersLoading
1108         https://bugs.webkit.org/show_bug.cgi?id=191394
1109
1110         Reviewed by Dean Jackson.
1111
1112         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1113         (WTR::TestRunner::setDefersLoading):
1114
1115 2019-02-07  Zalan Bujtas  <zalan@apple.com>
1116
1117         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
1118         https://bugs.webkit.org/show_bug.cgi?id=194391
1119
1120         Reviewed by Antti Koivisto.
1121
1122         * LayoutReloaded/misc/LFC-passing-tests.txt:
1123
1124 2019-02-06  Keith Rollin  <krollin@apple.com>
1125
1126         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
1127         https://bugs.webkit.org/show_bug.cgi?id=193975
1128         <rdar://problem/47643306>
1129
1130         Reviewed by Tim Horton.
1131
1132         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
1133         the Info.plist file into the bundle. This step is not necessary as the
1134         implicit "bundle up all the build products into a framework" build
1135         phase does this already. Having the Copy Bundle Resources phase do
1136         this causes a conflict under XCBuild, which objects to two build
1137         phases producing the same file (Info.plist). Address this by removing
1138         Info.plist from the Copy Bundle Resources phase.
1139
1140         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
1141
1142 2019-02-06  Keith Rollin  <krollin@apple.com>
1143
1144         Really enable the automatic checking and regenerations of .xcfilelists during builds
1145         https://bugs.webkit.org/show_bug.cgi?id=194357
1146         <rdar://problem/47861231>
1147
1148         Reviewed by Chris Dumez.
1149
1150         Bug 194124 was supposed to enable the automatic checking and
1151         regenerating of .xcfilelist files during the build. While related
1152         changes were included in that patch, the change to actually enable the
1153         operation somehow was omitted. This patch actually enables the
1154         operation. The check-xcfilelist.sh scripts now check
1155         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
1156         from the checking.
1157
1158         * DumpRenderTree/Scripts/check-xcfilelists.sh:
1159         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
1160
1161 2019-02-06  David Kilzer  <ddkilzer@apple.com>
1162
1163         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
1164         <https://webkit.org/b/194286>
1165         <rdar://problem/47815558>
1166
1167         Reviewed by Alexey Proskuryakov.
1168
1169         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1170         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
1171         WKRetainPtr<> to avoid leaking the WKDataRef.
1172
1173 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
1174
1175         Unreviewed, fix a typo
1176
1177         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
1178
1179 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
1180
1181         [GTK][WPE] force libpsl build to use ICU in jhbuild
1182         https://bugs.webkit.org/show_bug.cgi?id=194288
1183
1184         Reviewed by Carlos Garcia Campos.
1185
1186         * gtk/jhbuild.modules:
1187         Require ICU for libpsl build in jhbuild, like done in WPE.
1188
1189 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
1190
1191         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
1192         https://bugs.webkit.org/show_bug.cgi?id=194209
1193
1194         Reviewed by Carlos Garcia Campos.
1195
1196         Enhance TestCookieManager to ensure this doesn't happen again.
1197
1198         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
1199         (testCookieManagerPersistentStorage):
1200         (beforeAll):
1201
1202 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1203
1204         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
1205         https://bugs.webkit.org/show_bug.cgi?id=194324
1206
1207         Reviewed by Andy Estes.
1208
1209         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
1210         part of the name is already implicit, since this is in testing code in TestOptions.
1211
1212         * WebKitTestRunner/TestController.cpp:
1213         (WTR::TestController::generateContextConfiguration const):
1214         (WTR::updateTestOptionsFromTestHeader):
1215         * WebKitTestRunner/TestOptions.h:
1216         (WTR::TestOptions::hasSameInitializationOptions const):
1217
1218 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1219
1220         [ews-build] Allow * as platform for builders and workers
1221         https://bugs.webkit.org/show_bug.cgi?id=188533
1222
1223         Reviewed by Lucas Forschler.
1224
1225         * BuildSlaveSupport/ews-build/loadConfig.py:
1226         (checkWorkersAndBuildersForConsistency):
1227
1228 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1229
1230         [ews-build] Add few bots to config.json
1231         https://bugs.webkit.org/show_bug.cgi?id=194304
1232
1233         Reviewed by Lucas Forschler.
1234
1235         * BuildSlaveSupport/ews-build/config.json:
1236
1237 2019-02-05  Keith Rollin  <krollin@apple.com>
1238
1239         Enable the automatic checking and regenerations of .xcfilelists during builds
1240         https://bugs.webkit.org/show_bug.cgi?id=194124
1241         <rdar://problem/47721277>
1242
1243         Reviewed by Tim Horton.
1244
1245         Bug 193790 add a facility for checking -- during build time -- that
1246         any needed .xcfilelist files are up-to-date and for updating them if
1247         they are not. This facility was initially opt-in by setting
1248         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
1249         the process seemed robust. Its now time to enable this facility and
1250         make it opt-out. If there is a need to disable this facility, set and
1251         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
1252         running `make` or `build-webkit`, or before running Xcode from the
1253         command line.
1254
1255         Additionally, remove the step that generates a list of source files
1256         going into the UnifiedSources build step. It's only necessarily to
1257         specify Sources.txt and SourcesCocoa.txt as inputs.
1258
1259         * Scripts/generate-xcfilelists:
1260
1261 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
1262
1263         [GTK][WPE] force libpsl build to use ICU in jhbuild
1264         https://bugs.webkit.org/show_bug.cgi?id=194288
1265
1266         Reviewed by Philippe Normand.
1267
1268         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
1269         This can cause build failures if libidn is detected but libunistring is not available.
1270
1271         Make sure that ICU is used for runtime and builtin PSL data.
1272
1273         * gtk/jhbuild.modules:
1274         * wpe/jhbuild.modules:
1275
1276 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1277
1278         [ews-app] Modified timestamp should be updated on updating data
1279         https://bugs.webkit.org/show_bug.cgi?id=194295
1280
1281         Reviewed by Lucas Forschler.
1282
1283         * BuildSlaveSupport/ews-app/ews/models/build.py:
1284         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1285         * BuildSlaveSupport/ews-app/ews/models/step.py:
1286
1287 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
1288
1289         Unreviewed, rolling out r240742.
1290
1291         Causes crashes on iOS simulator.
1292
1293         Reverted changeset:
1294
1295         "[iOS] Keyups for non-modifier keys identified as "Dead" when
1296         not focused in a content-editable element"
1297         https://bugs.webkit.org/show_bug.cgi?id=192824
1298         https://trac.webkit.org/changeset/240742
1299
1300 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
1301
1302         run-webkit-tests emits message "...running None" when running tests
1303         https://bugs.webkit.org/show_bug.cgi?id=194133
1304         <rdar://problem/47724738>
1305
1306         Reviewed by Lucas Forschler.
1307
1308         * Scripts/webkitpy/xcode/device_type.py:
1309         (DeviceType.__str__): Use both version mapping tables and use just the variant
1310         name if no version name is available.
1311         * Scripts/webkitpy/xcode/device_type_unittest.py:
1312         (DeviceTypeTest):
1313         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
1314         an associated named.
1315
1316 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
1317
1318         [WPE] require python3-setuptools for meson build in jhbuild
1319         https://bugs.webkit.org/show_bug.cgi?id=194287
1320
1321         Reviewed by Philippe Normand.
1322
1323         python3-setuptools is needed to build meson in jhbuild.
1324         It is already required by the GTK port.
1325
1326         * wpe/install-dependencies:
1327
1328 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1329
1330         [ews-app] Add method to save BuilderMapping to database
1331         https://bugs.webkit.org/show_bug.cgi?id=194264
1332
1333         Reviewed by Lucas Forschler.
1334
1335         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1336         (BuilderMapping.__str__):
1337         (BuilderMapping):
1338         (BuilderMapping.save_mapping):
1339         (BuilderMapping.update_mapping):
1340         (BuilderMapping.get_existing_mapping):
1341         (BuilderMapping.is_valid_mapping):
1342
1343 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1344
1345         [ews-app] Add timestamp fields for BuilderMappings
1346         https://bugs.webkit.org/show_bug.cgi?id=194266
1347
1348         Reviewed by Lucas Forschler.
1349
1350         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1351         (BuilderMapping):
1352
1353 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
1354
1355         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
1356         https://bugs.webkit.org/show_bug.cgi?id=174816
1357
1358         Reviewed by Michael Catanzaro.
1359
1360         Add tests for webkit_uri_for_display().
1361
1362         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
1363         (testURIForDisplayUnaffected):
1364         (testURIForDisplayAffected):
1365         (beforeAll):
1366         (afterAll):
1367         * TestWebKitAPI/glib/CMakeLists.txt:
1368
1369 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
1370
1371         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
1372         https://bugs.webkit.org/show_bug.cgi?id=194158
1373         <rdar://problem/47737268>
1374
1375         Rubber-stamped by Aakash Jain.
1376
1377         * Scripts/webkitpy/port/device_port.py:
1378         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
1379
1380 2019-02-04  Said Abou-Hallawa  <said@apple.com>
1381
1382         [CG] Enable setAdditionalSupportedImageTypes for WK1
1383         https://bugs.webkit.org/show_bug.cgi?id=194190
1384
1385         Reviewed by Tim Horton.
1386
1387         Add a test similar to the one under WebKit Cocoa but make it create a
1388         WebView instead of a WKWebView.
1389
1390         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1391         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
1392         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
1393         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
1394         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
1395         (TestWebKitAPI::runTest):
1396         (TestWebKitAPI::TEST):
1397
1398 2019-02-04  Zalan Bujtas  <zalan@apple.com>
1399
1400         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
1401         https://bugs.webkit.org/show_bug.cgi?id=194168
1402
1403         Reviewed by Simon Fraser.
1404
1405         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
1406
1407         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1408         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
1409         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
1410         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
1411         (TEST):
1412         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
1413         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
1414
1415 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
1416
1417         REGRESSION (r237269): webkit-patch what-broke is broken 
1418         https://bugs.webkit.org/show_bug.cgi?id=193025
1419
1420         Reviewed by Aakash Jain.
1421
1422         * Scripts/webkitpy/common/host.py:
1423         (Host.buildbot):
1424         (Host.bugzilla): Renamed to 'buildbot'.
1425
1426 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1427
1428         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
1429         https://bugs.webkit.org/show_bug.cgi?id=194207
1430
1431         Reviewed by Tim Horton.
1432
1433         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
1434         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
1435         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
1436         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
1437         start and delete forwards to remove the original attachment.
1438
1439         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1440         (TestWebKitAPI::TEST):
1441
1442 2019-02-04  Youenn Fablet  <youenn@apple.com>
1443
1444         Capture state should be managed consistently when doing process swapping
1445         https://bugs.webkit.org/show_bug.cgi?id=194122
1446         <rdar://problem/47609293>
1447
1448         Reviewed by Eric Carlson.
1449
1450         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1451         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
1452         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
1453         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
1454         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1455         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1456         (WTR::TestRunner::isDoingMediaCapture const):
1457         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1458         * WebKitTestRunner/TestController.cpp:
1459         (WTR::TestController::isDoingMediaCapture const):
1460         * WebKitTestRunner/TestController.h:
1461         * WebKitTestRunner/TestInvocation.cpp:
1462         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1463         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1464         (WTR::TestController::isDoingMediaCapture const):
1465
1466 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
1467
1468         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
1469         https://bugs.webkit.org/show_bug.cgi?id=194142
1470
1471         Reviewed by Ross Kirsling.
1472
1473         There three 'separator' variables in TestController.cpp. Renamed
1474         it 'pathSeparator', and unified them.
1475
1476         * WebKitTestRunner/TestController.cpp:
1477         (WTR::TestController::generateContextConfiguration const):
1478         (WTR::createTestURL):
1479         (WTR::TestController::platformAdjustContext):
1480
1481 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
1482
1483         Make setNeedsLayout on the root more explicitly about triggering its side-effects
1484         https://bugs.webkit.org/show_bug.cgi?id=194198
1485
1486         Reviewed by Antti Koivisto.
1487
1488         No need to set the banner heights on navigation now, since Page stores them.
1489
1490         * MiniBrowser/mac/WK2BrowserWindowController.m:
1491         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
1492
1493 2019-02-03  John Wilander  <wilander@apple.com>
1494
1495         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
1496         https://bugs.webkit.org/show_bug.cgi?id=194104
1497         <rdar://problem/47649991>
1498
1499         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
1500
1501         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1502         (TestWebKitAPI::TEST):
1503             Changed numeric types from unsigned short to uint32_t.
1504
1505 2019-02-02  David Kilzer  <ddkilzer@apple.com>
1506
1507         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
1508         <https://webkit.org/b/194178>
1509         <rdar://problem/47753473>
1510
1511         Reviewed by Alexey Proskuryakov.
1512
1513         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1514         (WTR::uninstallFakeHelvetica): Pass nullptr into
1515         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
1516
1517 2019-02-02  Zalan Bujtas  <zalan@apple.com>
1518
1519         [LFC] Initialize ICB's style with fixed width/height.
1520         https://bugs.webkit.org/show_bug.cgi?id=194188
1521
1522         Reviewed by Antti Koivisto.
1523
1524         * LayoutReloaded/misc/LFC-passing-tests.txt:
1525
1526 2019-02-02  Zalan Bujtas  <zalan@apple.com>
1527
1528         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
1529         https://bugs.webkit.org/show_bug.cgi?id=194185
1530
1531         Reviewed by Antti Koivisto.
1532
1533         * LayoutReloaded/misc/LFC-passing-tests.txt:
1534
1535 2018-12-16  Darin Adler  <darin@apple.com>
1536
1537         Convert additional String::format clients to alternative approaches
1538         https://bugs.webkit.org/show_bug.cgi?id=192746
1539
1540         Reviewed by Alexey Proskuryakov.
1541
1542         * WebKitTestRunner/TestController.cpp:
1543         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
1544         as an intermediate in code that ultimately constructs a WTF::String.
1545         (WTR::userMediaOriginHash): Use makeString.
1546         (WTR::TestController::didNavigateWithNavigationData): More of the same.
1547         (WTR::TestController::didPerformClientRedirect): Ditto.
1548         (WTR::TestController::didPerformServerRedirect): Ditto.
1549         (WTR::TestController::didUpdateHistoryTitle): Ditto.
1550
1551 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
1552
1553         [ews-build] Add unit test to verify builder keys
1554         https://bugs.webkit.org/show_bug.cgi?id=194152
1555
1556         Reviewed by Lucas Forschler.
1557
1558         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
1559         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
1560
1561 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1562
1563         [LFC] Expand tests coverage (12 new tests -> 787)
1564
1565         Unreviewed test gardening.
1566
1567         * LayoutReloaded/misc/LFC-passing-tests.txt:
1568
1569 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1570
1571         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
1572         https://bugs.webkit.org/show_bug.cgi?id=194163
1573
1574         Reviewed by Simon Fraser.
1575
1576         775
1577
1578         * LayoutReloaded/misc/LFC-passing-tests.txt:
1579
1580 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1581
1582         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
1583         https://bugs.webkit.org/show_bug.cgi?id=194140
1584         <rdar://problem/47728098>
1585
1586         Reviewed by Tim Horton.
1587
1588         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1589         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1590         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
1591
1592         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
1593         test to induce an IPC deadlock when presenting a modal alert during touch start.
1594
1595         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1596         * WebKitTestRunner/TestController.cpp:
1597         (WTR::runJavaScriptAlert):
1598
1599         Add a client callback function for running JavaScript alerts.
1600
1601         (WTR::TestController::createOtherPage):
1602         (WTR::TestController::generateContextConfiguration const):
1603
1604         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
1605         the fix in this patch.
1606
1607         (WTR::TestController::createWebViewWithOptions):
1608
1609         Plumb TestOptions to generateContextConfiguration.
1610
1611         (WTR::TestController::resetPreferencesToConsistentValues):
1612         (WTR::TestController::resetStateToConsistentValues):
1613         (WTR::updateTestOptionsFromTestHeader):
1614         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
1615         (WTR::TestController::handleJavaScriptAlert):
1616         * WebKitTestRunner/TestController.h:
1617         * WebKitTestRunner/TestInvocation.cpp:
1618         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1619         * WebKitTestRunner/TestOptions.h:
1620         (WTR::TestOptions::hasSameInitializationOptions const):
1621
1622 2019-02-01  Chris Dumez  <cdumez@apple.com>
1623
1624         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
1625         https://bugs.webkit.org/show_bug.cgi?id=193740
1626         <rdar://problem/47527267>
1627
1628         Reviewed by Alex Christensen.
1629
1630         Add API test coverage.
1631
1632         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1633
1634 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
1635
1636         [ews-app] Add display name field to BuilderMapping model
1637         https://bugs.webkit.org/show_bug.cgi?id=194153
1638
1639         Reviewed by Lucas Forschler.
1640
1641         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1642         (BuilderMapping):
1643
1644 2019-02-01  Youenn Fablet  <youenn@apple.com>
1645
1646         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
1647         https://bugs.webkit.org/show_bug.cgi?id=194155
1648
1649         Reviewed by Eric Carlson.
1650
1651         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
1652         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
1653         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
1654
1655 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1656
1657         [LFC] Adjust replaced element's intrinsic ratio
1658         https://bugs.webkit.org/show_bug.cgi?id=194154
1659
1660         Reviewed by Antti Koivisto.
1661
1662         761
1663
1664         * LayoutReloaded/misc/LFC-passing-tests.txt:
1665
1666 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1667
1668         [WPE] Show test results in minibrowser
1669         https://bugs.webkit.org/show_bug.cgi?id=194150
1670
1671         Reviewed by Žan Doberšek.
1672
1673         * Scripts/webkitpy/port/wpe.py:
1674         (WPEPort.show_results_html_file):
1675
1676 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1677
1678         [WPE] MiniBrowser: add ky bindings for back/forward navigation
1679         https://bugs.webkit.org/show_bug.cgi?id=194151
1680
1681         Reviewed by Žan Doberšek.
1682
1683         ALT + <- go back
1684         ALT + -> go forward
1685
1686         * MiniBrowser/wpe/main.cpp:
1687         (main):
1688
1689 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1690
1691         [LFC] Set intrinsic size on Layout::Replaced
1692         https://bugs.webkit.org/show_bug.cgi?id=194139
1693
1694         Reviewed by Antti Koivisto.
1695
1696         744
1697
1698         * LayoutReloaded/misc/LFC-passing-tests.txt:
1699
1700 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1701
1702         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
1703         https://bugs.webkit.org/show_bug.cgi?id=194146
1704
1705         Reviewed by Xabier Rodriguez-Calvar.
1706
1707         It allows to open relative paths.
1708
1709         * MiniBrowser/wpe/main.cpp:
1710         (main):
1711
1712 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
1713
1714         Update flakiness dashboard configuration after recent queue changes
1715         https://bugs.webkit.org/show_bug.cgi?id=194127
1716
1717         Rubber-stamped by Aakash Jain.
1718
1719         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
1720
1721         * TestResultServer/static-dashboards/builders.jsonp:
1722
1723 2019-01-31  Youenn Fablet  <youenn@apple.com>
1724
1725         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
1726         https://bugs.webkit.org/show_bug.cgi?id=194106
1727         <rdar://problem/47676333>
1728
1729         Reviewed by Ryosuke Niwa.
1730
1731         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
1732         (TestWebKitAPI::didFinishNavigation):
1733         (TestWebKitAPI::TEST):
1734         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
1735
1736 2019-01-31  Chris Dumez  <cdumez@apple.com>
1737
1738         Page zoom level is lost after a process swap or a crash
1739         https://bugs.webkit.org/show_bug.cgi?id=194105
1740         <rdar://problem/47610781>
1741
1742         Reviewed by Alex Christensen.
1743
1744         Add API test coverage.
1745
1746         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1747         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
1748
1749 2019-01-31  Alex Christensen  <achristensen@webkit.org>
1750
1751         Revert r238819 which is unneeded and caused a performance regression.
1752         https://bugs.webkit.org/show_bug.cgi?id=192272
1753         <rdar://problem/46664625>
1754
1755         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
1756         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
1757         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
1758
1759 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
1760
1761         Formalize WebKitAdditions mechanism of LoadOptimizer
1762         https://bugs.webkit.org/show_bug.cgi?id=193886
1763         <rdar://problem/47696809>
1764
1765         Reviewed by Brent Fulgham.
1766
1767         * MiniBrowser/MiniBrowser.entitlements:
1768         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
1769
1770 2019-01-31  Zalan Bujtas  <zalan@apple.com>
1771
1772         [LFC] Margin before/after/start/end initial value is 0 and not auto.
1773         https://bugs.webkit.org/show_bug.cgi?id=194090
1774
1775         Reviewed by Antti Koivisto.
1776
1777         * LayoutReloaded/misc/LFC-passing-tests.txt:
1778
1779 2019-01-31  Zalan Bujtas  <zalan@apple.com>
1780
1781         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
1782         https://bugs.webkit.org/show_bug.cgi?id=194074
1783
1784         Reviewed by Antti Koivisto.
1785
1786         * LayoutReloaded/misc/LFC-passing-tests.txt:
1787
1788 2019-01-31  Zalan Bujtas  <zalan@apple.com>
1789
1790         [LFC][BFC] Add support for block level replaced box.
1791         https://bugs.webkit.org/show_bug.cgi?id=194071
1792
1793         Reviewed by Antti Koivisto.
1794
1795         * LayoutReloaded/misc/LFC-passing-tests.txt:
1796
1797 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
1798
1799         Fix WebKitTestRunner's testPath with Windows full paths
1800         https://bugs.webkit.org/show_bug.cgi?id=194012
1801
1802         Reviewed by Alex Christensen.
1803
1804         updateTestOptionsFromTestHeader failed to open test files because
1805         testPath returned wrong file paths. It returned a path "/C:/..."
1806         if a URL "file:///C:/..." was given.
1807
1808         * WebKitTestRunner/TestController.cpp:
1809         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
1810
1811 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1812
1813         [WPE] Bump font related dependencies to match the GTK+ port
1814         https://bugs.webkit.org/show_bug.cgi?id=194017
1815
1816         Reviewed by Žan Doberšek.
1817
1818         * wpe/jhbuild.modules:
1819         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
1820         * wpe/patches/icudata-stdlibs.patch: Added.
1821
1822 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
1823
1824         Enable swipe tests on iOS
1825         https://bugs.webkit.org/show_bug.cgi?id=194076
1826
1827         Reviewed by Geoffrey Garen.
1828
1829         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
1830         it causes a debug assertion failure in runUIScript.
1831
1832         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1833         (WTR::UIScriptController::beginBackSwipe):
1834         (WTR::UIScriptController::completeBackSwipe):
1835
1836 2019-01-30  Keith Rollin  <krollin@apple.com>
1837
1838         Use correct printf format specifier
1839         https://bugs.webkit.org/show_bug.cgi?id=194062
1840         <rdar://problem/47686167>
1841
1842         Reviewed by Alexey Proskuryakov.
1843
1844         LayoutTestSpellChecker.mm is trying to format a variable of type
1845         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
1846         actually an unsigned long long. Fix this by formatting with %llu.
1847
1848         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
1849         (-[LayoutTestTextCheckingResult description]):
1850
1851 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
1852
1853         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
1854         https://bugs.webkit.org/show_bug.cgi?id=193979
1855
1856         Reviewed by Wenson Hsieh.
1857
1858         Fix the test for iOS. Make the test work with iOS UA string.
1859
1860         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1861
1862 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
1863
1864         Replace High Sierra LLINT CLoop bot due to hardware failure
1865         https://bugs.webkit.org/show_bug.cgi?id=194066
1866
1867         Reviewed by Aakash Jain.
1868
1869         * BuildSlaveSupport/build.webkit.org-config/config.json:
1870
1871 2019-01-30  Keith Rollin  <krollin@apple.com>
1872
1873         [NSDragItem init] is unavailable
1874         https://bugs.webkit.org/show_bug.cgi?id=194059
1875         <rdar://problem/47685715>
1876
1877         Reviewed by Wenson Hsieh.
1878
1879         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
1880         DumpRenderTree and TestWebKitAPI, which both try to create an
1881         NSDragItem in a manner that invokes this method. Address this by using
1882         -initWithPasteboardWriter instead.
1883
1884         Note that the parameter passed to initWithPasteboardWriter is likely
1885         incorrect. In both cases, the object passed does not conform to
1886         NSPasteboardWriting. However, with this fix, we're no worse off than
1887         before, and can now perform builds with newer compilers and SDKs until
1888         a real fix can be crafted. That work is tracked in
1889         https://bugs.webkit.org/show_bug.cgi?id=194060
1890
1891         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
1892         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1893         * TestWebKitAPI/mac/TestDraggingInfo.mm:
1894         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1895
1896 2019-01-30  Daniel Bates  <dabates@apple.com>
1897
1898         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
1899         https://bugs.webkit.org/show_bug.cgi?id=192824
1900         <rdar://problem/47100332>
1901
1902         Reviewed by Wenson Hsieh.
1903
1904         Fix a bug where the wrong usage code was used for F13 thru F24.
1905
1906         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1907         (keyCodeForDOMFunctionKey):
1908
1909 2019-01-30  Chris Dumez  <cdumez@apple.com>
1910
1911         Regression(PSON) Load hang can occur on history navigation
1912         https://bugs.webkit.org/show_bug.cgi?id=194030
1913         <rdar://problem/47656939>
1914
1915         Reviewed by Antti Koivisto.
1916
1917         Add API test coverage.
1918
1919         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1920
1921 2019-01-30  Zalan Bujtas  <zalan@apple.com>
1922
1923         [LFC] Expand tests coverage.
1924
1925         Unreviewed test gardening.
1926
1927         * LayoutReloaded/misc/LFC-passing-tests.txt:
1928
1929 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
1930
1931         [Flatpak] Add openjpeg support
1932         https://bugs.webkit.org/show_bug.cgi?id=194019
1933
1934         Reviewed by Michael Catanzaro.
1935
1936         * flatpak/org.webkit.CommonModules.yaml:
1937
1938 2019-01-30  Commit Queue  <commit-queue@webkit.org>
1939
1940         Unreviewed, rolling out r240708.
1941         https://bugs.webkit.org/show_bug.cgi?id=194022
1942
1943         It broke WPE build (Requested by KaL on #webkit).
1944
1945         Reverted changeset:
1946
1947         "[WPE] Bump font related dependencies to match the GTK+ port"
1948         https://bugs.webkit.org/show_bug.cgi?id=194017
1949         https://trac.webkit.org/changeset/240708
1950
1951 2019-01-30  Zalan Bujtas  <zalan@apple.com>
1952
1953         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
1954         https://bugs.webkit.org/show_bug.cgi?id=194001
1955
1956         Reviewed by Antti Koivisto.
1957
1958         * LayoutReloaded/misc/LFC-passing-tests.txt:
1959
1960 2019-01-30  Zalan Bujtas  <zalan@apple.com>
1961
1962         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
1963         https://bugs.webkit.org/show_bug.cgi?id=194020
1964
1965         Reviewed by Antti Koivisto.
1966
1967         * LayoutReloaded/misc/LFC-passing-tests.txt:
1968
1969 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
1970
1971         AX: Support color well on iOS
1972         https://bugs.webkit.org/show_bug.cgi?id=194010
1973
1974         Reviewed by Joanmarie Diggs.
1975
1976         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1977         (WTR::AccessibilityUIElement::stringAttributeValue):
1978
1979 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1980
1981         [WPE] Bump font related dependencies to match the GTK+ port
1982         https://bugs.webkit.org/show_bug.cgi?id=194017
1983
1984         Reviewed by Žan Doberšek.
1985
1986         * wpe/jhbuild.modules:
1987         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
1988         * wpe/patches/icudata-stdlibs.patch: Added.
1989
1990 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
1991
1992         [Mac] Update window scale API usage
1993         https://bugs.webkit.org/show_bug.cgi?id=193991
1994         rdar://problem/47614795
1995
1996         Reviewed by Tim Horton.
1997
1998         * DumpRenderTree/mac/DumpRenderTree.mm:
1999         (changeWindowScaleIfNeeded):
2000         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2001         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2002         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
2003
2004 2019-01-29  Chris Dumez  <cdumez@apple.com>
2005
2006         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
2007         https://bugs.webkit.org/show_bug.cgi?id=193977
2008         <rdar://problem/47643716>
2009
2010         Reviewed by Geoff Garen.
2011
2012         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
2013         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
2014         to the previous provisional committing *before* we make the last load. 
2015
2016         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2017
2018 2019-01-29  Youenn Fablet  <youenn@apple.com>
2019
2020         Adopt new SPI to evaluate server certificate trust
2021         https://bugs.webkit.org/show_bug.cgi?id=193355
2022
2023         Reviewed by Alex Christensen.
2024
2025         Add infrastructure to handle HTTPS server trust evaluation testing.
2026
2027         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2028         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2029         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
2030         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
2031         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
2032         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2033         * WebKitTestRunner/TestController.cpp:
2034         (WTR::TestController::resetPreferencesToConsistentValues):
2035         (WTR::TestController::didReceiveAuthenticationChallenge):
2036         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
2037         * WebKitTestRunner/TestController.h:
2038         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
2039         * WebKitTestRunner/TestInvocation.cpp:
2040         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2041         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2042         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
2043
2044 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2045
2046         [ews-build] Add build step to print bot Configuration
2047         https://bugs.webkit.org/show_bug.cgi?id=193887
2048
2049         Reviewed by Lucas Forschler.
2050
2051         * BuildSlaveSupport/ews-build/steps.py:
2052         (PrintConfiguration): Build step to print configuration.
2053         * BuildSlaveSupport/ews-build/factories.py:
2054
2055 2019-01-29  Chris Dumez  <cdumez@apple.com>
2056
2057         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
2058         https://bugs.webkit.org/show_bug.cgi?id=193967
2059         <rdar://problem/47635348>
2060
2061         Reviewed by Alex Christensen.
2062
2063         Add API test coverage.
2064
2065         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2066         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
2067
2068 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2069
2070         [ews-app] Handle incoming results data
2071         https://bugs.webkit.org/show_bug.cgi?id=193973
2072
2073         Reviewed by Lucas Forschler.
2074
2075         * BuildSlaveSupport/ews-app/ews/views/results.py:
2076
2077 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2078
2079         [ews-app] Make the results url generic
2080         https://bugs.webkit.org/show_bug.cgi?id=193928
2081
2082         Reviewed by Lucas Forschler.
2083
2084         * BuildSlaveSupport/ews-app/ews/urls.py:
2085
2086 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2087
2088         [ews-build] Configure buildbot to send events to ews-app
2089         https://bugs.webkit.org/show_bug.cgi?id=193968
2090
2091         Reviewed by Lucas Forschler.
2092
2093         * BuildSlaveSupport/ews-build/events.py: Added.
2094         * BuildSlaveSupport/ews-build/master.cfg:
2095
2096 2019-01-29  Keith Rollin  <krollin@apple.com>
2097
2098         Add .xcfilelists to Run Script build phases
2099         https://bugs.webkit.org/show_bug.cgi?id=193792
2100         <rdar://problem/47201785>
2101
2102         Reviewed by Alex Christensen.
2103
2104         As part of supporting XCBuild, update the necessary Run Script build
2105         phases in their Xcode projects to refer to their associated
2106         .xcfilelist files.
2107
2108         Note that the addition of these files bumps the Xcode project version
2109         number to something that's Xcode 10 compatible. This change means that
2110         older versions of the Xcode IDE can't read these projects. Nor can it
2111         fully load workspaces that refer to these projects (the updated
2112         projects are shown as non-expandable placeholders). `xcodebuild` can
2113         still build these projects; it's just that the IDE can't open them.
2114
2115         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2116         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2117
2118 2019-01-29  John Wilander  <wilander@apple.com>
2119
2120         Add data abstraction and validation for Ad Click Attribution
2121         https://bugs.webkit.org/show_bug.cgi?id=193916
2122         <rdar://problem/47603481>
2123
2124         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
2125
2126         Ad click attribution has two steps. First, the storage of an ad
2127         campaign ID for a click that takes the user to a destination
2128         site. Second, a conversion on the destination site that can be
2129         attributed to the ad click.
2130
2131         This patch adds a class that represents a request for ad click
2132         attribution. Validation makes sure that the bits of entropy
2133         reported through this mechanism is limited.
2134
2135         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2136         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
2137         (TestWebKitAPI::TEST):
2138
2139 2019-01-29  Chris Dumez  <cdumez@apple.com>
2140
2141         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
2142         https://bugs.webkit.org/show_bug.cgi?id=193932
2143         <rdar://problem/47598947>
2144
2145         Reviewed by Brady Eidson.
2146
2147         Add API test coverage.
2148
2149         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2150
2151 2019-01-29  Zalan Bujtas  <zalan@apple.com>
2152
2153         Adding new passing LFC tests.
2154
2155         Unreviewed test gardening.
2156
2157         * LayoutReloaded/misc/LFC-passing-tests.txt:
2158
2159 2019-01-29  Zalan Bujtas  <zalan@apple.com>
2160
2161         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
2162         https://bugs.webkit.org/show_bug.cgi?id=193964
2163
2164         Reviewed by Antti Koivisto.
2165
2166         * LayoutReloaded/misc/LFC-passing-tests.txt:
2167
2168 2019-01-29  Zalan Bujtas  <zalan@apple.com>
2169
2170         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
2171         https://bugs.webkit.org/show_bug.cgi?id=193954
2172
2173         Reviewed by Antti Koivisto.
2174
2175         * LayoutReloaded/misc/LFC-passing-tests.txt:
2176
2177 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
2178
2179         WebDriver: add support for running subtests
2180         https://bugs.webkit.org/show_bug.cgi?id=193904
2181
2182         Reviewed by Michael Catanzaro.
2183
2184         pytest already supports it by passing test.py::subtest, so we can do the same.
2185
2186         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
2187         (get_item_name): Made this global.
2188         (CollectRecorder.__init__): Receive the parameter to ignore.
2189         (CollectRecorder.pytest_collectreport): Collect also the subtests.
2190         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
2191         (collect): Add parameter to ignore.
2192         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
2193         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
2194         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
2195         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
2196         (WebDriverTestRunnerSelenium.run): Ditto.
2197         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
2198         (WebDriverTestRunnerW3C.collect_tests): Ditto.
2199         (WebDriverTestRunnerW3C.run): Ditto.
2200
2201 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
2202
2203         User agent string override for navigator.userAgent should be site specific quirks
2204         https://bugs.webkit.org/show_bug.cgi?id=193950
2205
2206         Reviewed by Brent Fulgham.
2207
2208         Updated per the _WKWebsitePolicies rename.
2209
2210         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2211         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2212
2213 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
2214
2215         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
2216         https://bugs.webkit.org/show_bug.cgi?id=193941
2217
2218         Reviewed by Alex Christensen.
2219
2220         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
2221         * TestWebKitAPI/Tests/WTF/Condition.cpp:
2222         * TestWebKitAPI/Tests/WTF/Lock.cpp:
2223         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
2224         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
2225         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
2226         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
2227         * TestWebKitAPI/Tests/WTF/Time.cpp:
2228         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
2229         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
2230         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2231         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
2232
2233 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
2234
2235         Unreviewed, reorder my emails to fix autocomplete in bugzilla
2236
2237         * Scripts/webkitpy/common/config/contributors.json:
2238
2239 2019-01-28  Andy Estes  <aestes@apple.com>
2240
2241         [watchOS] Enable Parental Controls content filtering
2242         https://bugs.webkit.org/show_bug.cgi?id=193939
2243         <rdar://problem/46641912>
2244
2245         Reviewed by Ryosuke Niwa.
2246
2247         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2248
2249 2019-01-28  David Kilzer  <ddkilzer@apple.com>
2250
2251         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
2252         <https://webkit.org/b/193884>
2253
2254         Reviewed by Jiewen Tan.
2255
2256         * Scripts/webkitpy/style/checkers/cpp.py:
2257         (check_language): Add LocalAuthentication to
2258         `frameworks_with_soft_links`.
2259
2260 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
2261
2262         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
2263         https://bugs.webkit.org/show_bug.cgi?id=193891
2264
2265         Reviewed by Ross Kirsling.
2266
2267         There were three problems in window sizes of WebView and the host window.
2268         1. The sizes of pixel image output were incorrect.
2269         2. The host window is going to appear after window.resize was invoked.
2270         3. window.resize resized only the host window, not WebView.
2271
2272         This change solves them with a following approach.
2273         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
2274         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
2275            as well as DumpRenderTree in order to match the client area and the window area.
2276         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
2277         d. PlatformWebView::setWindowFrame changes both window sizes.
2278         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
2279
2280         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2281         (WTR::PlatformWebView::PlatformWebView): Create the host window
2282         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
2283         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
2284         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
2285
2286 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2287
2288         [ews-app] Add method to save Step data to database
2289         https://bugs.webkit.org/show_bug.cgi?id=193890
2290
2291         Reviewed by Lucas Forschler.
2292
2293         * BuildSlaveSupport/ews-app/ews/models/step.py:
2294         (Step.save_step): Method to save step data.
2295         (Step.update_step): Method to update step data.
2296         (Step.get_existing_step): Method to fetch existing step from database.
2297         (Step.is_valid_result): Method to validate valid step result.
2298
2299 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2300
2301         [ews-app] Add method to save Build data to database
2302         https://bugs.webkit.org/show_bug.cgi?id=193735
2303
2304         Reviewed by Lucas Forschler.
2305
2306         * BuildSlaveSupport/ews-app/ews/models/build.py:
2307         (Build.save_build): Method to save build information to database.
2308         (Build.get_existing_build): Method to fetch existing build from database.
2309         (Build.is_valid_result): Method to validate build result.
2310         * BuildSlaveSupport/ews-app/ews/common/util.py:
2311         (is_valid_int_id): Method to validate valid id.
2312
2313 2019-01-28  Chris Dumez  <cdumez@apple.com>
2314
2315         Regression(PSON) Crash under WebPageProxy::didStartProgress()
2316         https://bugs.webkit.org/show_bug.cgi?id=193915
2317         <rdar://problem/47560907>
2318
2319         Reviewed by Alex Christensen.
2320
2321         Add API test coverage.
2322
2323         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2324
2325 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2326
2327         [ews-app] Rename id variables
2328         https://bugs.webkit.org/show_bug.cgi?id=193883
2329
2330         Reviewed by Lucas Forschler.
2331
2332         * BuildSlaveSupport/ews-app/ews/models/build.py:
2333         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2334         * BuildSlaveSupport/ews-app/ews/models/step.py:
2335         * BuildSlaveSupport/ews-app/ews/urls.py:
2336         * BuildSlaveSupport/ews-app/ews/views/patch.py:
2337         * BuildSlaveSupport/ews-app/ews/views/results.py:
2338         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2339
2340 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2341
2342         [ews-app] Allow certain fields to be empty
2343         https://bugs.webkit.org/show_bug.cgi?id=193892
2344
2345         Reviewed by Lucas Forschler.
2346
2347         * BuildSlaveSupport/ews-app/ews/models/build.py:
2348         * BuildSlaveSupport/ews-app/ews/models/step.py:
2349
2350 2019-01-28  Rob Buis  <rbuis@igalia.com>
2351
2352         Update MIME type parser
2353         https://bugs.webkit.org/show_bug.cgi?id=180526
2354
2355         Reviewed by Frédéric Wang.
2356
2357         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
2358         (TestWebKitAPI::TEST):
2359
2360 2019-01-28  Zalan Bujtas  <zalan@apple.com>
2361
2362         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
2363         https://bugs.webkit.org/show_bug.cgi?id=193896
2364
2365         Reviewed by Antti Koivisto.
2366
2367         * LayoutReloaded/misc/LFC-passing-tests.txt:
2368
2369 2018-12-15  Darin Adler  <darin@apple.com>
2370
2371         Replace many uses of String::format with more type-safe alternatives
2372         https://bugs.webkit.org/show_bug.cgi?id=192742
2373
2374         Reviewed by Mark Lam.
2375
2376         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2377         (WTR::cacheTestRunnerCallback): Use makeString.
2378         * WebKitTestRunner/TestController.cpp:
2379         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
2380         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
2381
2382 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
2383
2384         Use a load optimizer for some sites
2385         https://bugs.webkit.org/show_bug.cgi?id=193881
2386         <rdar://problem/46325455>
2387
2388         Reviewed by Brent Fulgham.
2389
2390         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2391         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
2392
2393 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
2394
2395         AX: Introduce a static accessibility tree
2396         https://bugs.webkit.org/show_bug.cgi?id=193348
2397         <rdar://problem/47203295>
2398
2399         Reviewed by Ryosuke Niwa.
2400
2401         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2402
2403 2019-01-26  Zalan Bujtas  <zalan@apple.com>
2404
2405         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
2406         https://bugs.webkit.org/show_bug.cgi?id=193867
2407
2408         Reviewed by Antti Koivisto.
2409
2410         * LayoutReloaded/misc/LFC-passing-tests.txt:
2411
2412 2019-01-26  Zalan Bujtas  <zalan@apple.com>
2413
2414         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
2415         https://bugs.webkit.org/show_bug.cgi?id=193865
2416
2417         Reviewed by Antti Koivisto.
2418
2419         * LayoutReloaded/misc/LFC-passing-tests.txt:
2420
2421 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
2422
2423         Need a mechanism to override navigator.userAgent
2424         https://bugs.webkit.org/show_bug.cgi?id=193762
2425         <rdar://problem/47504939>
2426
2427         Reviewed by Brent Fulgham.
2428
2429         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
2430
2431         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2432         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2433         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
2434
2435 2019-01-25  Dean Jackson  <dino@apple.com>
2436
2437         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
2438         https://bugs.webkit.org/show_bug.cgi?id=193831
2439         <rdar://problem/47399263>
2440
2441         Reviewed by Chris Dumez.
2442
2443         Two new tests that exercise cross-origin and same-origin System
2444         Previews.
2445
2446         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2447
2448 2019-01-25  Keith Rollin  <krollin@apple.com>
2449
2450         Update Xcode projects with "Check .xcfilelists" build phase
2451         https://bugs.webkit.org/show_bug.cgi?id=193790
2452         <rdar://problem/47201374>
2453
2454         Reviewed by Alex Christensen.
2455
2456         Support for XCBuild includes specifying inputs and outputs to various
2457         Run Script build phases. These inputs and outputs are specified as
2458         .xcfilelist files. Once created, these .xcfilelist files need to be
2459         kept up-to-date. In order to check that they are up-to-date or not,
2460         add an Xcode build step that invokes an external script that performs
2461         the checking. If the .xcfilelists are found to be out-of-date, update
2462         them, halt the build, and instruct the developer to restart the build
2463         with up-to-date files.
2464
2465         At this time, the checking and regenerating is performed only if the
2466         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
2467         who want to use this facility can set this variable and test out the
2468         checking/regenerating. Once it seems like there are no egregious
2469         issues that upset a developer's workflow, we'll unconditionally enable
2470         this facility.
2471
2472         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2473         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
2474         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
2475         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2476
2477 2019-01-25  Keith Rollin  <krollin@apple.com>
2478
2479         Update Xcode projects with "Apply Configuration to XCFileLists" build target
2480         https://bugs.webkit.org/show_bug.cgi?id=193781
2481         <rdar://problem/47201153>
2482
2483         Reviewed by Alex Christensen.
2484
2485         Part of generating the .xcfilelists used as part of adopting XCBuild
2486         includes running `make DerivedSources.make` from a standalone script.
2487         It’s important for this invocation to have the same environment as
2488         when the actual build invokes `make DerivedSources.make`. If the
2489         environments are different, then the two invocations will provide
2490         different results. In order to get the same environment in the
2491         standalone script, have the script launch xcodebuild targeting the
2492         "Apply Configuration to XCFileLists" build target, which will then
2493         re-invoke our standalone script. The script is now running again, this
2494         time in an environment with all workspace, project, target, xcconfig
2495         and other environment variables established.
2496
2497         The "Apply Configuration to XCFileLists" build target accomplishes
2498         this task via a small embedded shell script that consists only of:
2499
2500             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
2501
2502         The process that invokes "Apply Configuration to XCFileLists" first
2503         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
2504         evaluated and exports it into the shell environment. When xcodebuild
2505         is invoked, it inherits the value of this variable and can `eval` the
2506         contents of that variable. Our external standalone script can then set
2507         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
2508         of command-line parameters needed to restart itself in the appropriate
2509         state.
2510
2511         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2512         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2513
2514 2019-01-25  Alex Christensen  <achristensen@webkit.org>
2515
2516         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
2517         https://bugs.webkit.org/show_bug.cgi?id=193802
2518         <rdar://problem/46010580>
2519
2520         Reviewed by Andy Estes.
2521
2522         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2523         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
2524         (TEST):
2525
2526 2019-01-25  Daniel Bates  <dabates@apple.com>
2527
2528         [iOS] uiController.keyDown() does not translate Control modified key
2529         https://bugs.webkit.org/show_bug.cgi?id=192898
2530
2531         Reviewed by Wenson Hsieh.
2532
2533         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
2534         key translation, as applicable. Among other cases, key translation occurs when performing
2535         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
2536         also makes the behavior of uiController.keyDown() more closely match the behavior of a
2537         human pressing down and releasing key(s) using a hardware keyboard.
2538
2539         * WebKitTestRunner/ios/HIDEventGenerator.h:
2540         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2541         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
2542
2543         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
2544         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
2545         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2546         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2547         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
2548         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2549         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
2550         (-[HIDEventGenerator longPress:completionBlock:]):
2551         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
2552         Update code for above renaming.
2553
2554         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
2555         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
2556
2557         (-[HIDEventGenerator keyDown:]): Added.
2558         (-[HIDEventGenerator keyUp:]): Added.
2559         (-[HIDEventGenerator keyPress:completionBlock:]):
2560         (-[HIDEventGenerator eventDispatchThreadEntry:]):
2561         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
2562         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2563         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
2564         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
2565         (WTR::parseModifier): Deleted.
2566
2567 2019-01-25  Keith Rollin  <krollin@apple.com>
2568
2569         Complete the implementation of generate-xcfilelists
2570         https://bugs.webkit.org/show_bug.cgi?id=193782
2571
2572         Reviewed by Alex Christensen.
2573
2574         A preliminary version of generate-xcfilelists was added in r238008.
2575         This patch updates that script in order to:
2576
2577         - Support checking of .xcfilelists
2578         - Perform better execution of `make DerivedSources.make` by
2579           relaunching generate-xcfilelists under xcodebuild
2580         - Support incremental generation and checking of .xcfilelists
2581         - Support supplementary .xcfilelists files from WebKitAdditions
2582         - Support being wrapped by parallel version of generate-xcfilelists in
2583           Internal that adds support for (re)generating WebKit projects in
2584           that repo.
2585         - Support builds that have been performed in WebKitBuild as well as
2586           ~/Library/Developer/code/DerivedData
2587         - Increase robustness and debugging facilities.
2588
2589         * Scripts/generate-xcfilelists:
2590
2591 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
2592
2593         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
2594         https://bugs.webkit.org/show_bug.cgi?id=193297
2595         <rdar://problem/47158841>
2596
2597         Unreviewed test case fix.
2598
2599         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
2600         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
2601
2602         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2603         (TEST):
2604
2605 2019-01-25  Keith Rollin  <krollin@apple.com>
2606
2607         Update existing .xcfilelists
2608         https://bugs.webkit.org/show_bug.cgi?id=193791
2609         <rdar://problem/47201706>
2610
2611         Reviewed by Alex Christensen.
2612
2613         Many .xcfilelist files were added in r238824 in order to support
2614         XCBuild. Update these with recent changes to the set of build files
2615         and with the current generate-xcfilelist script.
2616
2617         * DumpRenderTree/DerivedSources-input.xcfilelist:
2618         * DumpRenderTree/DerivedSources-output.xcfilelist:
2619         * WebKitTestRunner/DerivedSources-input.xcfilelist:
2620         * WebKitTestRunner/DerivedSources-output.xcfilelist:
2621
2622 2019-01-25  Keith Rollin  <krollin@apple.com>
2623
2624         Fix missing dependencies in extract-dependencies-from-makefile
2625         https://bugs.webkit.org/show_bug.cgi?id=193783
2626         <rdar://problem/47201571>
2627
2628         Reviewed by Alex Christensen.
2629
2630         The extract-dependencies-from-makefile script generates .xcfilelists
2631         for XCBuild by invoking a makefile in --debug mode, parsing the
2632         dependency information in the output, and extracting information
2633         regarding targets and dependents. However, the way `make` emits this
2634         dependency information is not rigorous, and so we need to determine
2635         what lines to look for and parse by trial and error. This approach
2636         didn't coriginally atch all the information we needed to collect, so
2637         update the script to look for the additional lines we now know to look
2638         for.
2639
2640         * Scripts/extract-dependencies-from-makefile:
2641         (Parser):
2642         (Parser.addTarget):
2643         (Parser.addPrereq):
2644         (Parser.doParse):
2645
2646 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
2647
2648         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
2649         https://bugs.webkit.org/show_bug.cgi?id=193297
2650         <rdar://problem/47158841>
2651
2652         Reviewed by Alex Christensen.
2653
2654         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
2655             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
2656         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2657         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
2658         activating the message used to trigger the callback when it is set.
2659
2660 2019-01-25  Alex Christensen  <achristensen@webkit.org>
2661
2662         WKWebView.goBack should reload if there is a safe browsing warning
2663         https://bugs.webkit.org/show_bug.cgi?id=193805
2664         <rdar://problem/46908216>
2665
2666         Reviewed by Geoff Garen.
2667
2668         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2669         (+[Simple3LookupContext sharedLookupContext]):
2670         (-[Simple3LookupContext lookUpURL:completionHandler:]):
2671         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
2672         (TEST):
2673
2674 2019-01-25  Chris Dumez  <cdumez@apple.com>
2675
2676         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
2677         https://bugs.webkit.org/show_bug.cgi?id=193788
2678         <rdar://problem/47531231>
2679
2680         Reviewed by Alex Christensen.
2681
2682         Add API test coverage.
2683
2684         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2685         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
2686
2687 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
2688
2689         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
2690         https://bugs.webkit.org/show_bug.cgi?id=193771
2691
2692         Unreviewed infrastructure fix.
2693
2694         * Scripts/webkitpy/port/darwin.py:
2695         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
2696
2697 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
2698
2699         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
2700
2701 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
2702
2703         Add contributors.json entries for Ling Ho and for a new bot watchers group.
2704
2705         * Scripts/webkitpy/common/config/contributors.json:
2706
2707 2019-01-25  Chris Dumez  <cdumez@apple.com>
2708
2709         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
2710         https://bugs.webkit.org/show_bug.cgi?id=193779
2711         <rdar://problem/46170903>
2712
2713         Reviewed by Antti Koivisto.
2714
2715         Add API test that quickly navigates forward to a previous process without waiting for it to
2716         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
2717         the process' previous page when reconnecting the it for the forward navigation.
2718
2719         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2720
2721 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2722
2723         Need a way for JavaScript (or bundle) code to participate in undo
2724         https://bugs.webkit.org/show_bug.cgi?id=190009
2725         <rdar://problem/44807048>
2726
2727         Reviewed by Ryosuke Niwa.
2728
2729         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
2730         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
2731
2732         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2733         (WTR::UIScriptController::lastUndoLabel const):
2734         (WTR::UIScriptController::firstRedoLabel const):
2735         (WTR::UIScriptController::platformUndoManager const):
2736         * DumpRenderTree/mac/UIScriptControllerMac.mm:
2737         (WTR::UIScriptController::lastUndoLabel const):
2738         (WTR::UIScriptController::firstRedoLabel const):
2739         (WTR::UIScriptController::platformUndoManager const):
2740         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2741         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2742         (WTR::UIScriptController::lastUndoLabel const):
2743         (WTR::UIScriptController::firstRedoLabel const):
2744         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2745         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2746         (WTR::UIScriptController::lastUndoLabel const):
2747         (WTR::UIScriptController::firstRedoLabel const):
2748         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2749         (WTR::UIScriptController::platformUndoManager const):
2750         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2751         (WTR::UIScriptController::platformUndoManager const):
2752
2753 2019-01-25  Zalan Bujtas  <zalan@apple.com>
2754
2755         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
2756         https://bugs.webkit.org/show_bug.cgi?id=193824
2757
2758         Reviewed by Antti Koivisto.
2759
2760         * LayoutReloaded/misc/LFC-passing-tests.txt:
2761
2762 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
2763
2764         Update macOS JSC bot configurations
2765         https://bugs.webkit.org/show_bug.cgi?id=193739
2766
2767         Reviewed by Alexey Proskuryakov.
2768
2769         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
2770         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2771         (BubbleQueueServer): Move JSC EWS to Mojave section.
2772         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2773         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
2774         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
2775
2776 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
2777
2778         [Win][WebKitTestRunner] Implement EventSenderProxy
2779         https://bugs.webkit.org/show_bug.cgi?id=193755
2780
2781         Reviewed by Don Olmstead.
2782
2783         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
2784         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
2785         (WTR::EventSenderProxy::dispatchMessage):
2786         (WTR::EventSenderProxy::EventSenderProxy):
2787         (WTR::EventSenderProxy::mouseDown):
2788         (WTR::EventSenderProxy::mouseUp):
2789         (WTR::EventSenderProxy::mouseMoveTo):
2790         (WTR::EventSenderProxy::mouseScrollBy):
2791         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
2792
2793 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
2794
2795         Unreviewed fix for API test failure after r240437.
2796
2797         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
2798
2799         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
2800
2801 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
2802
2803         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
2804         https://bugs.webkit.org/show_bug.cgi?id=193787
2805         <rdar://problem/47497634>
2806
2807         Reviewed by Alexey Proskuryakov.
2808
2809         * Scripts/webkitdirs.pm:
2810         (iosSimulatorApplicationsPath): Pick from available runtime directories.
2811
2812 2019-01-24  Truitt Savell  <tsavell@apple.com>
2813
2814         Unreviewed, rolling out r240446.
2815
2816         Casued 5 API failures
2817
2818         Reverted changeset:
2819
2820         "Activate the WebResourceLoadStatisticsStore in the
2821         NetworkProcess and deactivate it in the UIProcess."
2822         https://bugs.webkit.org/show_bug.cgi?id=193297
2823         https://trac.webkit.org/changeset/240446
2824
2825 2019-01-24  Zalan Bujtas  <zalan@apple.com>
2826
2827         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
2828         https://bugs.webkit.org/show_bug.cgi?id=193741
2829         <rdar://problem/47135030>
2830
2831         Reviewed by Antti Koivisto and Simon Fraser.
2832
2833         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2834         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
2835         (TestWebKitAPI::TEST):
2836
2837 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
2838
2839         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
2840         https://bugs.webkit.org/show_bug.cgi?id=193297
2841         <rdar://problem/47158841>
2842
2843         Reviewed by Alex Christensen.
2844
2845         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2846         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
2847         activating the message used to trigger the callback when it is set.
2848
2849 2019-01-24  John Wilander  <wilander@apple.com>
2850
2851         Add Ad Click Attribution as an internal/experimental feature
2852         https://bugs.webkit.org/show_bug.cgi?id=193685
2853         <rdar://problem/47450399>
2854
2855         Reviewed by Brent Fulgham.
2856
2857         Added test option adClickAttributionEnabled.
2858
2859         * DumpRenderTree/TestOptions.cpp:
2860         (TestOptions::TestOptions):
2861         * DumpRenderTree/TestOptions.h:
2862         * DumpRenderTree/mac/DumpRenderTree.mm:
2863         (setWebPreferencesForTestOptions):
2864
2865 2019-01-24  Antti Koivisto  <antti@apple.com>
2866
2867         [PSON] Flash on back navigation on Mac
2868         https://bugs.webkit.org/show_bug.cgi?id=193716
2869         <rdar://problem/47148458>
2870
2871         Reviewed by Chris Dumez.
2872
2873         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2874
2875         Closing of the previous page is delayed so waiting for didFinishNavigation is
2876         not sufficient to guarantee we have received all the messages. Wait for them.
2877
2878 2019-01-24  Chris Dumez  <cdumez@apple.com>
2879
2880         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
2881         https://bugs.webkit.org/show_bug.cgi?id=193761
2882         <rdar://problem/47456405>
2883
2884         Reviewed by Alex Christensen.
2885
2886         Add API test coverage.
2887
2888         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2889
2890 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
2891
2892         webkitpy: Missing PID in crashlog name should not be fatal
2893         https://bugs.webkit.org/show_bug.cgi?id=193771
2894
2895         If we can't determine the PID of a crashlog, just ignore the crashlog instead
2896         of raising an exception.
2897
2898         Reviewed by Lucas Forschler.
2899
2900         * Scripts/webkitpy/port/darwin.py:
2901         (DarwinPort._merge_crash_logs):
2902
2903 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
2904
2905         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
2906         https://bugs.webkit.org/show_bug.cgi?id=193746
2907
2908         Reviewed by Youenn Fablet.
2909
2910         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
2911         so we'd best just not call it.
2912
2913         * Scripts/webkitpy/w3c/test_exporter.py:
2914         (WebPlatformTestExporter.create_branch_with_patch):
2915
2916 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
2917
2918         Move FileSystem to WTF
2919         https://bugs.webkit.org/show_bug.cgi?id=193602
2920
2921         Reviewed by Yusuke Suzuki.
2922
2923         * DumpRenderTree/win/DumpRenderTree.cpp:
2924         * TestWebKitAPI/CMakeLists.txt:
2925         * TestWebKitAPI/PlatformGTK.cmake:
2926         * TestWebKitAPI/PlatformJSCOnly.cmake:
2927         * TestWebKitAPI/PlatformPlayStation.cmake:
2928         * TestWebKitAPI/PlatformWPE.cmake:
2929         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2930         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
2931         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
2932         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
2933         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
2934         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
2935         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
2936         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2937         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
2938         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2939
2940 2019-01-24  Philippe Normand  <pnormand@igalia.com>
2941
2942         [WPE] Remove hard dependency on subprocess32 for the API tests
2943
2944         Rubber-stamped by Carlos Garcia Campos.
2945
2946         * glib/api_test_runner.py:
2947         (TestRunner._run_test_qt): Lazily import subprocess32 and check
2948         its presence only when running WPEQt tests.
2949
2950 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2951
2952         [GLIB] Expose JavaScriptCore options in GLib public API
2953         https://bugs.webkit.org/show_bug.cgi?id=188742
2954
2955         Reviewed by Michael Catanzaro.
2956
2957         Add a test for the new API.
2958
2959         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2960         (testsJSCOptions):
2961         (main):
2962
2963 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2964
2965         [GTK][WPE] Support JPEG 2000 images
2966         https://bugs.webkit.org/show_bug.cgi?id=186272
2967
2968         Reviewed by Žan Doberšek.
2969
2970         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
2971
2972         * gtk/jhbuild.modules:
2973         * wpe/jhbuild.modules:
2974
2975 2019-01-23  David Kilzer  <ddkilzer@apple.com>
2976
2977         check-webkit-style should warn when using soft-linking macros in a header
2978         <https://webkit.org/b/193750>
2979
2980         Reviewed by Darin Adler.
2981
2982         * Scripts/webkitpy/style/checkers/cpp.py:
2983         (check_language): Add softlink/header check by refactoring the
2984         softlink/framework check.
2985         (CppChecker): Enable softlink/header check by default.
2986         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2987         (CppStyleTest.test_softlink_framework): Rename from
2988         CppStyleTest.test_softlink() and change test framework name in
2989         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
2990         files. Set file_name for macros that only appear in headers.
2991         (CppStyleTest.test_softlink_header): Add tests for using
2992         soft-link macros in headers.
2993
2994 2019-01-23  Chris Dumez  <cdumez@apple.com>
2995
2996         Deprecate API to limit the maximum number of WebProcesses
2997         https://bugs.webkit.org/show_bug.cgi?id=193725
2998         <rdar://problem/47464879>
2999
3000         Reviewed by Geoff Garen.
3001
3002         Update existing API tests to stop using deprecated API.
3003
3004         * MiniBrowser/mac/AppDelegate.m:
3005         (defaultConfiguration):
3006         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3007         (TestWebKitAPI::TEST):
3008         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
3009         (TestWebKitAPI::TEST):
3010         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3011         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
3012         (TEST):
3013         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
3014         (TEST):
3015
3016 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
3017
3018         [ews-app] Rename ews model buildermappings to buildermapping
3019         https://bugs.webkit.org/show_bug.cgi?id=193729
3020
3021         Reviewed by Lucas Forschler.
3022
3023         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
3024         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
3025         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
3026
3027 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
3028
3029         [ews-app] Rename ews model steps to step
3030         https://bugs.webkit.org/show_bug.cgi?id=193697
3031
3032         Reviewed by Lucas Forschler.
3033
3034         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
3035         (Step): Renamed Steps to Step.
3036
3037 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
3038
3039         Clean up IndexedDB files between tests
3040         https://bugs.webkit.org/show_bug.cgi?id=192796
3041         <rdar://problem/46824999>
3042
3043         Reviewed by Geoffrey Garen.
3044
3045         * DumpRenderTree/mac/DumpRenderTree.mm:
3046         (runTest):
3047         * WebKitTestRunner/TestController.cpp:
3048         (WTR::TestController::resetStateToConsistentValues):
3049         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
3050         (WTR::RemoveAllIndexedDatabasesCallback):
3051         (WTR::TestController::ClearIndexedDatabases):
3052         * WebKitTestRunner/TestController.h:
3053         * WebKitTestRunner/TestInvocation.cpp:
3054         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3055
3056 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
3057
3058         [ews-app] Rename ews model Builds to Build
3059         https://bugs.webkit.org/show_bug.cgi?id=193695
3060
3061         Reviewed by Lucas Forschler.
3062
3063         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
3064         (Build): Renamed Builds to Build.
3065
3066 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
3067
3068         webkitpy: Wait longer when launching WebKitTestRunner
3069         https://bugs.webkit.org/show_bug.cgi?id=193734
3070
3071         Reviewed by Aakash Jain.
3072
3073         * Scripts/webkitpy/port/simulator_process.py:
3074         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
3075
3076 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
3077
3078         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
3079         https://bugs.webkit.org/show_bug.cgi?id=193182
3080         <rdar://problem/47452154>
3081
3082         Reviewed by Tim Horton.
3083
3084         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
3085         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
3086         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
3087
3088         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
3089         preventing later tests from recognizing gestures.
3090
3091         * WebKitTestRunner/ios/TestControllerIOS.mm:
3092         (WTR::TestController::platformResetStateToConsistentValues):
3093
3094         Cancel all touches in the UIApplication when resetting to a consistent state between tests.
3095
3096 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
3097
3098         webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
3099         https://bugs.webkit.org/show_bug.cgi?id=193722
3100         <rdar://problem/47481475>
3101
3102         Reviewed by Lucas Forschler.
3103
3104         iPhone and iPad ports should both use the iOS config.
3105
3106         * Scripts/webkitpy/port/ios_simulator.py:
3107         (IPhoneSimulatorPort.__init__):
3108         (IPadSimulatorPort.__init__):
3109
3110 2019-01-23  Rob Buis  <rbuis@igalia.com>
3111
3112         Update MIME type parser
3113         https://bugs.webkit.org/show_bug.cgi?id=180526
3114
3115         Reviewed by Frédéric Wang.
3116
3117         Add unit tests for both parse modes of ParsedContentType.
3118
3119         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3120         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added.
3121         (TestWebKitAPI::TEST):
3122
3123 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
3124
3125         [ews-app] fetch loop should not stop on network issues
3126         https://bugs.webkit.org/show_bug.cgi?id=193666
3127
3128         Reviewed by Lucas Forschler.
3129
3130         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3131         (FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
3132
3133 2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3134
3135         [iOS] Multiple WKWebViewAutofillTests are flaky failures
3136         https://bugs.webkit.org/show_bug.cgi?id=189165
3137         <rdar://problem/47433765>
3138
3139         Reviewed by Tim Horton.
3140
3141         These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to
3142         immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular,
3143         the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI
3144         process in sufficient to ensure that any previous action that blurred the focused element in the web process
3145         would make its way to the UI process by the time the layer tree commit is finished.
3146
3147         However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread.
3148         This means that if a layer tree flush was already scheduled in the web process before the element was blurred,
3149         the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test
3150         will fail because it asks for -_autofillContext too early.
3151
3152         To fix this, we tweak these tests to actually wait until the intended input session change triggered by script
3153         is handled in the UI process.
3154
3155         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
3156
3157         Tweak some of these tests to wait for input session changes before checking for the presence of an autofill
3158         context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions
3159         by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new
3160         input session.
3161
3162         (-[AutofillTestView textInputHasAutofillContext]):
3163
3164         Remove the incorrect presentation update here. This helper now assumes that the UI process is up to date.
3165
3166         * TestWebKitAPI/cocoa/TestWKWebView.h:
3167         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3168         (nextInputSessionChangeCount):
3169
3170         Monotonically increasing identifier that's incremented whenever an input session is started in the UI process.
3171         This includes changing the focused element from one to another.
3172
3173         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
3174         (-[TestWKWebView didStartFormControlInteraction]):
3175         (-[TestWKWebView didEndFormControlInteraction]):
3176         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
3177
3178         Add a helper to evaluate JavaScript and wait for this script to cause some change in the input session. This
3179         handles three cases: (1) changing focus from an element that doesn't require an input session to one that does,
3180         (2) changing focus between elements that require input sessions, and (3) changing focus from an input session
3181         that doesn't require an input session to one that doesn't.
3182
3183 2019-01-22  David Kilzer  <ddkilzer@apple.com>
3184
3185         check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters
3186         <https://webkit.org/b/193676>
3187
3188         Reviewed by Alexey Proskuryakov.
3189
3190         * Scripts/webkitpy/style/checkers/cpp.py:
3191         (check_member_initialization_list):
3192         - Don't report missing whitespace around colon if the colon at
3193           the start of the line is formatted correctly.
3194         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3195         (WebKitStyleTest.test_member_initialization_list):
3196         - Add a test for a missing permutation of existing tests.
3197         - Add a test this false-positive.
3198         - Add blank lines between subtests to make them easier to read.
3199
3200 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
3201
3202         [build.webkit.org] Unit-test failure after r237113
3203         https://bugs.webkit.org/show_bug.cgi?id=193669
3204
3205         Reviewed by Michael Catanzaro.
3206
3207         * BuildSlaveSupport/build.webkit.org-config/factories.py:
3208         (Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has 
3209         multiple or zero flags.
3210
3211 2019-01-22  Tadeu Zagallo  <tzagallo@apple.com>
3212
3213         Cache bytecode to disk
3214         https://bugs.webkit.org/show_bug.cgi?id=192782
3215         <rdar://problem/46084932>
3216
3217         Reviewed by Keith Miller.
3218
3219         Add test helper to execute bytecode-cache tests: it executes each test
3220         twice, the first with JSC_diskCachePath set to a temporary directory
3221         and second with JSC_forceDiskCache=true (in addition to the cache path)
3222         to guarantee that only the disk cache is being used and no new
3223         UnlinkedCodeBlocks are being created.
3224
3225         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh: Added.
3226         * Scripts/run-jsc-stress-tests:
3227
3228 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
3229
3230         [css-logical] Implement flow-relative margin, padding and border shorthands
3231         https://bugs.webkit.org/show_bug.cgi?id=188697
3232
3233         Reviewed by Simon Fraser and Antti Koivisto.
3234
3235         * DumpRenderTree/TestOptions.cpp:
3236         (TestOptions::TestOptions):
3237         * DumpRenderTree/TestOptions.h:
3238         * DumpRenderTree/mac/DumpRenderTree.mm:
3239         (setWebPreferencesForTestOptions):
3240         Allow tests to enable the CSSLogicalEnabled flag in WK1.
3241
3242         * Scripts/webkitpy/style/checkers/jsonchecker.py:
3243         (JSONCSSPropertiesChecker.check_codegen_properties):
3244         Allow CSS property definitions to have a 'runtime-flag' parameter which
3245         disables the property when the specified runtime flag is disabled.
3246
3247 2019-01-21  Fujii Hironori  <Hironori.Fujii@sony.com>
3248
3249         [GTK][WPE] libgcrypt-1.7.6 can't be compiled on Ubuntu 18.10
3250         https://bugs.webkit.org/show_bug.cgi?id=193643
3251
3252         Reviewed by Michael Catanzaro.
3253
3254         * gtk/jhbuild.modules: Bumped to libgcrypt-1.8.4.
3255         * wpe/jhbuild.modules: Ditto.
3256
3257 2019-01-21  Zalan Bujtas  <zalan@apple.com>
3258
3259         [LFC][Floats] Take float top position into account when computing containing block height.
3260         https://bugs.webkit.org/show_bug.cgi?id=193655
3261
3262         Reviewed by Antti Koivisto.
3263
3264         * LayoutReloaded/misc/LFC-passing-tests.txt:
3265
3266 2019-01-21  David Kilzer  <ddkilzer@apple.com>
3267
3268         Switch remaining VideoToolbox soft-linking in WebCore over to VideoToolboxSoftLink.{cpp,h}
3269         <https://webkit.org/b/193645>
3270         <rdar://problem/47421574>
3271
3272         Reviewed by Alex Christensen.
3273
3274         - Now checks for local soft-linking of all frameworks that have
3275           their own *SoftLinking.{cpp,h,mm} files.
3276         - Changes softlink/uikit warning to softlink/framework.
3277
3278         * Scripts/webkitpy/style/checkers/cpp.py:
3279         (check_language):
3280         (CppChecker):
3281         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3282         (CppStyleTest):
3283
3284 2019-01-20  Saam Barati  <sbarati@apple.com>
3285
3286         Rollout r240210: It broke tests on iOS
3287         https://bugs.webkit.org/show_bug.cgi?id=193640
3288
3289         Unreviewed.
3290
3291         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper:
3292         * Scripts/run-jsc-stress-tests:
3293
3294 2019-01-20  chris fleizach  <cfleizach@apple.com>
3295
3296         AX: Support returning relative frames for accessibility
3297         https://bugs.webkit.org/show_bug.cgi?id=193414
3298         <rdar://problem/47268501>
3299
3300         Reviewed by Zalan Bujtas.
3301
3302         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3303         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3304         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3305         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3306         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3307         (WTR::attributesOfElement):
3308         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3309
3310 2019-01-20  Yusuke Suzuki  <ysuzuki@apple.com>
3311
3312         Unreviewed, add my new email address
3313
3314         * Scripts/webkitpy/common/config/contributors.json:
3315
3316 2019-01-19  Zalan Bujtas  <zalan@apple.com>
3317
3318         [LFC][BFC] <body>'s overflow property value is propagated to viewport
3319         https://bugs.webkit.org/show_bug.cgi?id=193617
3320
3321         Reviewed by Antti Koivisto.
3322
3323         * LayoutReloaded/misc/LFC-passing-tests.txt:
3324
3325 2019-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
3326
3327         Unreviewed, rolling out r240209.
3328
3329         Broke GTK/WPE injected bundle
3330
3331         Reverted changeset:
3332
3333         "AX: Support returning relative frames for accessibility"
3334         https://bugs.webkit.org/show_bug.cgi?id=193414
3335         https://trac.webkit.org/changeset/240209
3336
3337 2019-01-12  Dan Bernstein  <mitz@apple.com>
3338
3339         [Cocoa] Avoid importing directly from subumbrella frameworks
3340         https://bugs.webkit.org/show_bug.cgi?id=186016
3341         <rdar://problem/40591038>
3342
3343         Reviewed by Sam Weinig.
3344
3345         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
3346           LaunchServices header.
3347         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3348           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3349         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
3350           when using SDKs earlier than 10.13.
3351         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
3352           and OTHER_CPLUSPLUSFLAGS.
3353         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3354           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3355         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
3356           LaunchServices header.
3357
3358 2019-01-20  Tadeu Zagallo  <tzagallo@apple.com>
3359
3360         Cache bytecode to disk
3361         https://bugs.webkit.org/show_bug.cgi?id=192782
3362         <rdar://problem/46084932>
3363
3364         Reviewed by Keith Miller.
3365
3366         Add test helper to execute bytecode-cache tests: it executes each test
3367         twice, the first with JSC_diskCachePath set to a temporary directory
3368         and second with JSC_forceDiskCache=true (in addition to the cache path)
3369         to guarantee that only the disk cache is being used and no new
3370         UnlinkedCodeBlocks are being created.
3371
3372         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper: Added.
3373         * Scripts/run-jsc-stress-tests:
3374
3375 2019-01-20  chris fleizach  <cfleizach@apple.com>
3376
3377         AX: Support returning relative frames for accessibility
3378         https://bugs.webkit.org/show_bug.cgi?id=193414
3379         <rdar://problem/47268501>
3380
3381         Reviewed by Zalan Bujtas.
3382
3383         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3384         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3385         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3386         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3387         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3388         (WTR::attributesOfElement):
3389         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3390
3391 2019-01-20  Antoine Quint  <graouts@apple.com>
3392
3393         Add a POINTER_EVENTS feature flag
3394         https://bugs.webkit.org/show_bug.cgi?id=193577
3395         <rdar://problem/47408511>
3396
3397         Unreviewed. Also enable Pointer Events for iosmac.
3398
3399         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3400
3401 2019-01-19  Zalan Bujtas  <zalan@apple.com>
3402
3403         [LFC][Floats] Ensure that floats in FloatingContext::m_floats are always horizontally ordered.
3404         https://bugs.webkit.org/show_bug.cgi?id=193613
3405
3406         Reviewed by Antti Koivisto.
3407
3408         * LayoutReloaded/misc/LFC-passing-tests.txt:
3409
3410 2019-01-19  Antoine Quint  <graouts@apple.com>
3411
3412         Add a POINTER_EVENTS feature flag
3413         https://bugs.webkit.org/show_bug.cgi?id=193577
3414
3415         Reviewed by Dean Jackson.
3416
3417         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3418
3419 2019-01-18  Zhifei FANG  <zhifei_fang@apple.com>
3420
3421         Disable the run-jsc-stress-test remote host key check [second round].
3422         https://bugs.webkit.org/show_bug.cgi?id=192988
3423
3424         Reviewed by Dewei Zhu.
3425
3426         * Scripts/run-jsc-stress-tests:
3427
3428 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3429
3430         [build.webkit.org] unit-test failure Builder GTK Linux 32-bit Release doesn't exist
3431         https://bugs.webkit.org/show_bug.cgi?id=193597
3432
3433         Reviewed by Lucas Forschler.
3434
3435         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3436
3437 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3438
3439         [build.webkit.org] api tests failures are incorrectly named as unit test failures
3440         https://bugs.webkit.org/show_bug.cgi?id=193595
3441
3442         Reviewed by Lucas Forschler.
3443
3444         * BuildSlaveSupport/build.webkit.org-config/factories.py: Renamed RunUnitTests to RunAPITests.
3445         * BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
3446         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
3447
3448 2019-01-18  Chris Dumez  <cdumez@apple.com>
3449
3450         Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
3451         https://bugs.webkit.org/show_bug.cgi?id=193588
3452         <rdar://problem/47131566>
3453
3454         Reviewed by Alex Christensen.
3455
3456         Add layout test coverage.
3457
3458         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3459
3460 2019-01-18  Jer Noble  <jer.noble@apple.com>
3461
3462         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
3463         https://bugs.webkit.org/show_bug.cgi?id=189553
3464
3465         Reviewed by Tim Horton.
3466
3467         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
3468
3469         * ContentExtensionTester/Configurations/Base.xcconfig:
3470         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
3471         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3472         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
3473         * ImageDiff/cg/Configurations/Base.xcconfig:
3474         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
3475         * MiniBrowser/Configurations/Base.xcconfig:
3476         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3477         * MobileMiniBrowser/Configurations/Base.xcconfig:
3478         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3479         * Scripts/webkitpy/style/checker.py:
3480         (_all_categories):
3481         (FileType):
3482         (CheckerDispatcher._file_type):
3483         (CheckerDispatcher._create_checker):
3484         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
3485         (SDKVariantChecker):
3486         (SDKVariantChecker.__init__):
3487         (SDKVariantChecker.check):
3488         * TestWebKitAPI/Configurations/Base.xcconfig:
3489         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
3490         * WebEditingTester/Configurations/Base.xcconfig:
3491         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
3492         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
3493         * WebKitTestRunner/Configurations/Base.xcconfig:
3494         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
3495         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
3496         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
3497
3498 2019-01-18  David Kilzer  <ddkilzer@apple.com>
3499
3500         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
3501         <https://webkit.org/b/193568>
3502         <rdar://problem/47381130>
3503
3504         Reviewed by Alex Christensen.
3505
3506         Make sure no one re-introduces UIKit soft-linking by adding a
3507         style rule.
3508
3509         * Scripts/webkitpy/style/checkers/cpp.py:
3510         (check_language): Add softlink/uikit check.
3511         (CppChecker): Enable softlink/uikit check.
3512         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3513         (CppStyleTest): Add test for softlink/uikit.
3514
3515 2019-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
3516
3517         [GTK] install-dependencies tool looks for libunistring-dev for dnf
3518         https://bugs.webkit.org/show_bug.cgi?id=193584
3519
3520         Change "-dev" to "-devel".
3521
3522         Reviewed by Michael Catanzaro.
3523
3524         * gtk/install-dependencies:
3525
3526 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3527
3528         webkitpy: Add iPhone and iPad ports
3529         https://bugs.webkit.org/show_bug.cgi?id=193537
3530         <rdar://problem/47353390>
3531
3532         Reviewed by Lucas Forschler.
3533
3534         Add --iphone-simulator and --ipad-simulator commands to run-webkit-tests which separate iPhone and iPad into separate
3535         ports. Note that this separation is optional, the --ios-simulator command remains.
3536
3537         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3538         (RunTest.test_device_type_test_division): Drive-by fix.
3539         (RunTest.test_device_type_specific_listing): Ditto.
3540         (RunTest.test_ipad_test_division):
3541         (RunTest):
3542         (RunTest.test_ipad_listing):
3543         * Scripts/webkitpy/port/factory.py:
3544         (platform_options): Add --iphone-simulator and --ipad-simulator flags.
3545         (PortFactory):
3546         * Scripts/webkitpy/port/ios_simulator.py:
3547         (IPhoneSimulatorPort):
3548         (IPadSimulatorPort):
3549
3550 2019-01-18  Chris Dumez  <cdumez@apple.com>
3551
3552         Regression(PSON) Scroll position is not always restored properly when navigating back
3553         https://bugs.webkit.org/show_bug.cgi?id=193578
3554         <rdar://problem/47386331>
3555
3556         Reviewed by Tim Horton.
3557
3558         Add API test coverage.
3559
3560         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3561
3562 2019-01-18  Youenn Fablet  <youenn@apple.com>
3563
3564         Add a new SPI to request for cache storage quota increase
3565         https://bugs.webkit.org/show_bug.cgi?id=193323
3566
3567         Reviewed by Alex Christensen.
3568
3569         Implement WebsiteDataStore quota delegate to handle quota requests.
3570         By default, do not update quota.
3571         Update quota if test calls the new testRunner.allowCacheStorageQuotaIncrease method.
3572
3573         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3574         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3575         (WTR::TestRunner::allowCacheStorageQuotaIncrease):
3576         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3577         * WebKitTestRunner/TestController.cpp:
3578         (WTR::TestController::allowCacheStorageQuotaIncrease):
3579         * WebKitTestRunner/TestController.h:
3580         * WebKitTestRunner/TestInvocation.cpp:
3581         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3582         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3583         (-[CacheStorageQuotaManager init]):
3584         (-[CacheStorageQuotaManager _requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3585         (WTR::initializeWebViewConfiguration):
3586         (WTR::TestController::cocoaResetStateToConsistentValues):
3587         (WTR::TestController::allowCacheStorageQuotaIncrease):
3588
3589 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3590
3591         [ews-build] Pass owner to the triggered builds
3592         https://bugs.webkit.org/show_bug.cgi?id=193574
3593
3594         Reviewed by Lucas Forschler.
3595
3596         * BuildSlaveSupport/ews-build/factories.py:
3597         (BuildFactory.propertiesToPassToTriggers):
3598
3599 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3600
3601         [ews-app] Send patch author as a build property
3602         https://bugs.webkit.org/show_bug.cgi?id=193560
3603
3604         Reviewed by Lucas Forschler.
3605
3606         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3607         (BugzillaPatchFetcher.fetch):
3608
3609 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3610
3611         webkitpy: Implement device type specific expected results (Follow-up fix)
3612         https://bugs.webkit.org/show_bug.cgi?id=192162
3613         <rdar://problem/46345449>
3614
3615         Unreviewed infrastructure fix.
3616
3617         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3618         (Manager.run): Don't boot a device if no tests are available to run on it.
3619
3620 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3621
3622         webkitpy: Implement device type specific expected results (Follow-up fix)
3623         https://bugs.webkit.org/show_bug.cgi?id=192162
3624         <rdar://problem/46345449>
3625
3626         Unreviewed infrastructure fix.
3627
3628         * Scripts/webkitpy/api_tests/manager.py:
3629         (Manager._initialize_devices): Use DEVICE_TYPE when running API tests.
3630
3631 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3632
3633         webkitpy: Implement device type specific expected results (Part 2)
3634         https://bugs.webkit.org/show_bug.cgi?id=192162
3635         <rdar://problem/46345449>
3636
3637         Rubber-stamped by Aakash Jain.
3638
3639         This change uses device_type to select a different set of TestExpectation files based on the type of device running
3640         tests. This requires multiple baseline search paths to be used in a single instantiation of run-webkit-tests. Note
3641         that while multiple baseline search paths are used, any single test will only ever be run on a single device type.
3642
3643         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
3644         (LayoutTestFinder.find_tests): Pass device_type through.
3645         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py:
3646         (LayoutTestFinderTests.test_touched_but_skipped_test): Allow device_type to be passed in.
3647         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3648         (Manager.__init__): Make _expectations an OrderedDict indexed by device_type, add current_device_type.
3649         (Manager._collect_tests): Pass device type to test finder.
3650         (Manager._needs_web_platform_test):
3651         (Manager._prepare_lists): Index _expectations by device type.
3652         (Manager._test_input_for_file):
3653         (Manager._test_is_slow): Ditto.
3654         (Manager._test_should_dump_jsconsolelog_in_stderr):
3655         (Manager._test_should_dump_jsconsolelog_in_stderr): Ditto.
3656         (Manager._get_test_inputs):
3657         (Manager._update_worker_count):
3658         (Manager._set_up_run): Use current_device_type instead of passing device_type in.
3659         (Manager.run): Re-write function to gather and parse expectations from multiple baseline search paths. In the event
3660         that a test can be run on multiple device types, the first device in the device type list which is eligible will be
3661         the one which runs the test.
3662         (Manager._run_test_subset):
3663         (Manager._run_tests): Index _expectations by current_device_type.
3664         (Manager._print_expectation_line_for_test): Ditto.
3665         (Manager._print_expectations_for_subset): Ditto.
3666         (Manager.print_expectations): Re-write function to gather and parse expectations from multiple baseline search paths.
3667         Unlike run, this function will behave the same regardless of what devices are available.
3668         (Manager._custom_device_for_test): Deleted.
3669         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3670         (ManagerTest.test_uses_custom_device): Deleted.
3671         (ManagerTest.test_uses_custom_device.get_manager): Deleted.
3672         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3673         (JSONLayoutResultsGenerator.__init__): Pass expectations as a dictionary indexed by device type.
3674         (JSONLayoutResultsGenerator._insert_failure_summaries): The number of fixable tests must take into consideration
3675         all of the expectations.
3676         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
3677         (FakePort.skipped_layout_tests): Allow device_type to be passed in.
3678         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3679         (TestExpectations.__init__): Allow device_type to be passed through.
3680         (TestExpectations.parse_all_expectations): Pick expectations_dict by device type.
3681         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Allow device_type to be passed in.
3682         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
3683         (summarize_results):
3684         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py: