heap-buffer-overflow on fast/loader/reload-zero-byte-plugin.html
[WebKit-https.git] / Tools / ChangeLog
1 2015-01-05  Anders Carlsson  <andersca@apple.com>
2
3         heap-buffer-overflow on fast/loader/reload-zero-byte-plugin.html
4         https://bugs.webkit.org/show_bug.cgi?id=140096
5         rdar://problem/19368938
6
7         Reviewed by Alexey Proskuryakov.
8
9         When creating a new page, don't pass clientInfo when setting up the frame and policy clients,
10         since clientInfo points to a web view, not the test controller.
11
12         * WebKitTestRunner/TestController.cpp:
13         (WTR::TestController::createOtherPage):
14
15 2015-01-05  Hunseop Jeong  <hs85.jeong@samsung.com>
16
17         [EFL][GTK] WKPreferencesDefaults test failed after r177506 
18         https://bugs.webkit.org/show_bug.cgi?id=140077
19
20         Reviewed by Csaba Osztrogonác.
21
22         WebKit C SPI is available on EFL,GTK.
23         Changed the define order to pass the API test.
24
25         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
26         (TestWebKitAPI::TEST):
27
28 2015-01-01  Alexey Proskuryakov  <ap@apple.com>
29
30         Simplify WebKitTestRunner timeout tracking
31         https://bugs.webkit.org/show_bug.cgi?id=140036
32
33         Reviewed by Darin Adler.
34
35         The code for configuring timeouts was mostly dead, because run-webkit-tests never
36         passes the --timeout option to WebKitTestRunner.
37
38         * WebKitTestRunner/Options.h:
39         * WebKitTestRunner/Options.cpp:
40         (WTR::Options::Options):
41         (WTR::OptionsHandler::OptionsHandler):
42         (WTR::handleOptionTimeout): Deleted.
43         Removed support for --timeout. Timeouts are passed for each test individually,
44         and defaults are good enough for the rare cases where WebKitTestRunner is run
45         manually without run-webkit-tests.
46
47         * WebKitTestRunner/TestController.cpp:
48         (WTR::TestController::TestController):
49         (WTR::TestController::initialize):
50         (WTR::TestController::resetStateToConsistentValues):
51         (WTR::TestController::reattachPageToWebProcess):
52         (WTR::TestController::runUntil):
53         * WebKitTestRunner/TestController.h:
54         Simplified runUntil by passing the actual timeout, not an enum.
55         Increased short timeout for ASan enabled builds, as WebProcess launching takes
56         quite a while.
57
58         * WebKitTestRunner/TestInvocation.cpp:
59         (WTR::TestInvocation::invoke): Removed dead code that handled a timeout from NoTimeout.
60
61         * WebKitTestRunner/efl/TestControllerEfl.cpp:
62         (WTR::TestController::platformRunUntil):
63         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
64         (WTR::TestController::platformRunUntil):
65         Build fixes.
66
67 2015-01-02  Anders Carlsson  <andersca@apple.com>
68
69         Remove now unused storage tracker glue from DumpRenderTree
70         https://bugs.webkit.org/show_bug.cgi?id=140045
71
72         Reviewed by Darin Adler.
73
74         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
75         * DumpRenderTree/StorageTrackerDelegate.h: Removed.
76         * DumpRenderTree/StorageTrackerDelegate.mm: Removed.
77         * DumpRenderTree/TestRunner.cpp:
78         (TestRunner::staticFunctions):
79         (syncLocalStorageCallback): Deleted.
80         (observeStorageTrackerNotificationsCallback): Deleted.
81         (deleteAllLocalStorageCallback): Deleted.
82         (deleteLocalStorageForOriginCallback): Deleted.
83         (localStorageDiskUsageForOriginCallback): Deleted.
84         (originsWithLocalStorageCallback): Deleted.
85         * DumpRenderTree/TestRunner.h:
86         * DumpRenderTree/mac/DumpRenderTree.mm:
87         (allocateGlobalControllers):
88         (releaseGlobalControllers):
89         * DumpRenderTree/mac/DumpRenderTreeMac.h:
90         * DumpRenderTree/mac/TestRunnerMac.mm:
91         (TestRunner::syncLocalStorage): Deleted.
92         (TestRunner::localStorageDiskUsageForOrigin): Deleted.
93         (TestRunner::observeStorageTrackerNotifications): Deleted.
94         (TestRunner::deleteAllLocalStorage): Deleted.
95         (TestRunner::originsWithLocalStorage): Deleted.
96         (TestRunner::deleteLocalStorageForOrigin): Deleted.
97         * DumpRenderTree/win/TestRunnerWin.cpp:
98         (TestRunner::syncLocalStorage): Deleted.
99         (TestRunner::localStorageDiskUsageForOrigin): Deleted.
100         (TestRunner::observeStorageTrackerNotifications): Deleted.
101         (TestRunner::deleteAllLocalStorage): Deleted.
102         (TestRunner::originsWithLocalStorage): Deleted.
103         (TestRunner::deleteLocalStorageForOrigin): Deleted.
104
105 2015-01-01  Darin Adler  <darin@apple.com>
106
107         We often misspell identifier as "identifer"
108         https://bugs.webkit.org/show_bug.cgi?id=140025
109
110         Reviewed by Michael Saboff.
111
112         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
113         * Scripts/webkitdirs.pm:
114         (appIdentifierFromBundle):
115         (installAndLaunchIOSWebKitAppInSimulator):
116         Fix misspellings
117
118 2015-01-01  Zalan Bujtas  <zalan@apple.com>
119
120         Saturated arithmetics: Incorrect float/double clamping.
121         https://bugs.webkit.org/show_bug.cgi?id=139888
122         rdar://problem/19330885
123
124         Reviewed by Simon Fraser.
125
126         Clamp float and double values correctly when applying saturated arithmetics.
127
128         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
129         (TestWebKitAPI::TEST):
130
131 2014-12-30  Krzysztof Czech  <k.czech@samsung.com>
132
133         [EFL] Bump version of ATK used by jhbuild to 2.15.2
134         https://bugs.webkit.org/show_bug.cgi?id=139816
135
136         Reviewed by Gyuyoung Kim.
137
138         Bump version of ATK used by jhbuild to 2.15.2
139
140         * efl/jhbuild.modules:
141
142 2014-12-29  Fabien Vallée  <fvallee@connected-labs.com>
143
144         [jhBuild] cairo build error (-flto)
145         https://bugs.webkit.org/show_bug.cgi?id=139056
146
147         Reviewed by Philippe Normand.
148
149         cairo fails to link  with gcc 4.9 due to lto
150         related issue. This problem has been partially
151         addressed by cairo:
152         http://cgit.freedesktop.org/cairo/commit/?id=c3645d97ebd24c6f7ad850785d585aebc706a11c
153         use the cairo --disable-lto option and remove jhbuild
154         makeargs fixes the issue.
155
156         * gtk/jhbuild.modules:
157         * gtk/patches/cairo-1.12.8-add_disable-lto.patch: Added.
158
159 2014-12-27  Myles C. Maxfield  <mmaxfield@apple.com>
160         [Mac] Enable kerning, ligatures, and printer fonts 
161         https://bugs.webkit.org/show_bug.cgi?id=139970
162
163         Rubber stamped by Simon Fraser.
164
165         Flip the switch.
166
167         * DumpRenderTree/mac/DumpRenderTree.mm:
168         * WebKitTestRunner/TestController.cpp:
169         * WebKitTestRunner/mac/main.mm:
170
171 2014-12-26  Dan Bernstein  <mitz@apple.com>
172
173         <rdar://problem/19348208> REGRESSION (r177027): iOS builds use the wrong toolchain
174         https://bugs.webkit.org/show_bug.cgi?id=139950
175
176         Reviewed by David Kilzer.
177
178         * asan/asan.xcconfig: Only define TOOLCHAINS when building for OS X, doing so
179         in a manner that works with Xcode 5.1.1.
180
181 2014-12-24  Dan Bernstein  <mitz@apple.com>
182
183         Engineering builds of MiniBrowser ignore deprecated declaration warnings
184         https://bugs.webkit.org/show_bug.cgi?id=139941
185
186         Reviewed by Darin Adler.
187
188         * MiniBrowser/Configurations/Base.xcconfig: Added semicolon.
189         * MiniBrowser/Configurations/DebugRelease.xcconfig: Set GCC_WARN_ABOUT_DEPRECATED_FUNCTIONS
190         to YES.
191         * MiniBrowser/mac/AppDelegate.m:
192         (-[BrowserAppDelegate openDocument:]): Use NSFileHandlingPanelOKButton instead of
193         deprecated NSOKButton.
194
195 2014-12-24  Youenn Fablet  <youenn.fablet@crf.canon.fr>
196
197         W3C test importer should have an option to disable testharness.js/testharnessreport.js link conversion
198         https://bugs.webkit.org/show_bug.cgi?id=134763
199
200         Reviewed by Ryosuke Niwa.
201
202         Adding an option to disable test harness link conversion.
203
204         * Scripts/webkitpy/w3c/test_converter.py:
205         (convert_for_webkit):
206         (_W3CTestConverter.__init__):
207         (_W3CTestConverter.convert_attributes_if_needed):
208         * Scripts/webkitpy/w3c/test_importer.py:
209         (parse_args):
210         (TestImporter.import_tests):
211
212 2014-12-23  Alexey Proskuryakov  <ap@apple.com>
213
214         DumpRenderTree crashes are mis-reported as timeouts on Yosemite
215         https://bugs.webkit.org/show_bug.cgi?id=139933
216
217         Reviewed by Daniel Bates.
218
219         Crash logs take a very long time to be generated on Yosemite (rdar://problem/18701447),
220         and there is no way for run-webkit-tests to tell a crashed process from a frozen one
221         until ReportCrash lets it go.
222
223         Reuse existing machinery that tells run-webkit-tests about crashes. The script may
224         even get the actual crash log eventually - even when it times out waiting for the log, it
225         makes a second lookup at the very end, after all tests finish. There may be further
226         improvements needed here, but this small fix addresses most cases that happen in practice.
227
228         * DumpRenderTree/mac/DumpRenderTree.mm:
229         (writeCrashedMessageOnFatalError):
230         (dumpRenderTree):
231         Removed PLATFORM(IOS) ifdefs, this code is just as helpful on Mac.
232
233         * Scripts/webkitpy/port/driver.py: (Driver._check_for_driver_crash): Removed an
234         unhelpful comment.
235
236 2014-12-23  Alexey Proskuryakov  <ap@apple.com>
237
238         Don't force -O1 for debug ASan builds
239         https://bugs.webkit.org/show_bug.cgi?id=139926
240
241         Reviewed by Darin Adler.
242
243         * asan/asan.xcconfig:
244
245 2014-12-23  Alexey Proskuryakov  <ap@apple.com>
246
247         Simplify building with ASan
248         https://bugs.webkit.org/show_bug.cgi?id=139916
249
250         Reviewed by Mark Rowe.
251
252         * Scripts/set-webkit-configuration: Store ASan state into a new configuration file.
253         We could also update Configuration file format, but that's a little scary because
254         of how many places in code read it.
255
256         * Scripts/webkitdirs.pm:
257         (determineASanIsEnabled): Read it from ASan configuration file.
258         (argumentsForConfiguration): Added a FIXME.
259         (asanIsEnabled): A caching wrapper similar to what we have for other configuration options.
260         (XcodeOptions): Pass the options needed for ASan.
261
262         * asan/asan.xcconfig: Use the right toolchains. Made warnings fatal again, as there
263         no warnings to avoid. Removed explicit linking options, as -fsanitize=address does
264         that automatically.
265
266 2014-12-23  Alexey Proskuryakov  <ap@apple.com>
267
268         TestWebKitAPI build is broken when ASan is enabled
269         https://bugs.webkit.org/show_bug.cgi?id=139902
270
271         Reviewed by Darin Adler.
272
273         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
274         * TestWebKitAPI/Configurations/TestWebKitAPILibrary.xcconfig:
275         Inherit linker flags from DebugRelease, which respects ASAN.
276
277 2014-12-22  Simon Fraser  <simon.fraser@apple.com>
278
279         Sort the Xcode project file.
280
281         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
282
283 2014-12-22  Lucas Forschler  <lforschler@apple.com>
284
285         Update apple-mac-114 to bot629.
286         
287         Unreviewed.
288         
289         * BuildSlaveSupport/build.webkit.org-config/config.json:
290
291 2014-12-22  Lucas Forschler  <lforschler@apple.com>
292
293         Replace Apple bot104 with bot124.
294         
295         Unreviewed.
296         
297         * BuildSlaveSupport/build.webkit.org-config/config.json:
298
299 2014-12-22  Csaba Osztrogonác  <ossy@webkit.org>
300
301         URTBF after r177639.
302
303         * TestWebKitAPI/CMakeLists.txt:
304
305 2014-12-22  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
306
307         [EFL] MiniBrowser steals web view's focus
308         https://bugs.webkit.org/show_bug.cgi?id=139482
309
310         Reviewed by Gyuyoung Kim.
311
312         Although we set focus on ewk_view while MiniBrowser initialization
313         Ecore steals it in a favor of main window. As a result
314         focused element on web page is unable to receive events.
315
316         * MiniBrowser/efl/main.c:
317         (window_create):
318         Prevent window from stealing web view's focus on start up.
319
320 2014-12-19  Brent Fulgham  <bfulgham@apple.com>
321
322         [Win] Revise DRT logic to match Mac.
323
324         Rubberstamped by Anders Carlsson.
325
326         Update the Windows logic to perform initialization of preferences and WebKit
327         settings to match Mac. Also make sure that we only ever emit #EOF tokens under
328         the same circumstances as the Mac version.
329
330         * DumpRenderTree/win/DumpRenderTree.cpp:
331         (dump):
332         (resetWebPreferencesToConsistentValues):
333         (setDefaultsToConsistentValuesForTesting):
334         (resetWebViewToConsistentStateBeforeTesting):
335         (sizeWebViewForCurrentTest):
336         (runTest):
337         (createWebViewAndOffscreenWindow):
338         (allocateGlobalControllers):
339         (prepareConsistentTestingEnvironment):
340         (main):
341         (resetDefaultsToConsistentValues): Deleted.
342
343 2014-12-19  Roger Fong  <roger_fong@apple.com>
344
345         Unreviewed. Rollout r177605.
346
347         * EWSTools/start-queue-win.sh:
348
349 2014-12-19  Roger Fong  <roger_fong@apple.com>
350
351         Unreviewed. Try running EWS scripts without —no-confirm, since it defaults to true.
352
353         * EWSTools/start-queue-win.sh:
354
355 2014-12-19  Daniel Bates  <dabates@apple.com>
356
357         [iOS] Add WebKitSystemInterface for iOS 8.1
358         https://bugs.webkit.org/show_bug.cgi?id=139831
359
360         Reviewed by Alexey Proskuryakov.
361
362         Implement support in copy-webkitlibraries-to-product-directory to copy
363         WebKitSystemInterface for iOS to the product directory and have build-webkit
364         pass --wksi to copy-webkitlibraries-to-product-directory when building for iOS.
365
366         * Scripts/build-webkit:
367         * Scripts/copy-webkitlibraries-to-product-directory:
368
369 2014-12-19  Daniel Bates  <dabates@apple.com>
370
371         copy-webkitlibraries-to-product-directory uses wrong SDK when called from build-webkit
372         https://bugs.webkit.org/show_bug.cgi?id=139829
373
374         Reviewed by Alexey Proskuryakov.
375
376         The script build-webkit calls script copy-webkitlibraries-to-product-directory with
377         argument --sdk to specify the Xcode SDK to use, but copy-webkitlibraries-to-product-directory
378         expects the Xcode SDK to be specified using the --sdk-name command line argument.
379
380         Currently copy-webkitlibraries-to-product-directory has its own logic to handle
381         parsing for a specified Xcode SDK. Instead we should make use of the webkitdirs.pm
382         logic to both avoid duplicating effort and make the command line options for
383         copy-webkitlibraries-to-product-directory for specify the Xcode SDK consistent
384         with the approach used in other WebKit tools.
385
386         As a side effect of making use of the webkitdirs.pm logic for determining the Xcode SDK
387         copy-webkitlibraries-to-product-directory now recognizes --device and --simulator
388         shorthands for --sdk=iphoneos.internal and --sdk=iphonesimulator, respectively.
389
390         * Scripts/copy-webkitlibraries-to-product-directory: Also, renamed some variables to
391         improve the readability of the code.
392         (executeRanlib): Added; convenience function that calls the RANLIB(1) with the appropriate
393         Xcode SDK. We pass -no_warning_for_no_symbols to RANLIB(1) when using an Xcode SDK
394         for iOS since it's acceptable that an empty object file (say, for a Mac-specific feature)
395         be included in a library.
396         (unpackIfNecessary): Modified to call executeRanlib().
397
398 2014-12-19  Alexey Proskuryakov  <ap@apple.com>
399
400         REGRESSION (177368): Some tests started to immediately time out
401         https://bugs.webkit.org/show_bug.cgi?id=139826
402
403         Reviewed by Daniel Bates.
404
405         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::done):
406         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::dump):
407         Move invalidateWaitToDumpWatchdogTimer() call from dump() to done(). When a test
408         ends in a load failure, we don't dump, so we used to leak the timer.
409         
410         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::notifyDone):
411         Added a comment.
412
413 2014-12-19  Brent Fulgham  <bfulgham@apple.com>
414
415         [Win] Add accessor for serializing HTTP loads
416         https://bugs.webkit.org/show_bug.cgi?id=139817
417
418         Reviewed by Mark Lam.
419
420         * DumpRenderTree/win/DumpRenderTree.cpp: Reset serialized HTTP loads in our reset method.
421         * DumpRenderTree/win/TestRunnerWin.cpp: Provide implementation for serializing HTTP. Also
422         remove some redundant code from the destructor.
423
424 2014-12-19  Alexey Proskuryakov  <ap@apple.com>
425
426         Clean up a fix for performance test bot failing to build
427         https://bugs.webkit.org/show_bug.cgi?id=139818
428
429         Reviewed by Csaba Osztrogonác.
430
431         The "_1" in step name was annoying.
432
433         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
434         (CleanBuildIfScheduled.start):
435         (RunAndUploadPerfTests):
436         (DownloadAndPerfTestFactory.__init__):
437         (DownloadAndPerfTestWebKit2Factory.__init__):
438         (CleanBuildUnconditionally): Deleted.
439         (CleanBuildUnconditionally.start): Deleted.
440
441 2014-12-19  Csaba Osztrogonác  <ossy@webkit.org>
442
443         REGRESSION(r177535): It broke the GTK performance bot
444         https://bugs.webkit.org/show_bug.cgi?id=139811
445
446         Reviewed by Carlos Garcia Campos.
447
448         Trigger clean build only on mac platform.
449
450         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
451         (DownloadAndPerfTestFactory.__init__):
452         (DownloadAndPerfTestWebKit2Factory.__init__):
453
454 2014-12-18  KwangHyuk Kim  <hyuki.kim@samsung.com>
455
456         Unreviewed, moved myself to the list of committers.
457
458         * Scripts/webkitpy/common/config/contributors.json:
459
460 2014-12-18  Brent Fulgham  <bfulgham@apple.com>
461
462         [Win] Update DumpRenderTree to more closely match Mac version
463         https://bugs.webkit.org/show_bug.cgi?id=139799
464
465         Reviewed by Tim Horton.
466
467         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
468         (AccessibilityController::accessibleElementById): Correct
469         use of BSTR to avoid leak.
470         * DumpRenderTree/win/DumpRenderTree.cpp: Reorder methods and
471         update to match Mac version more closely.
472         (dumpFramesAsText):
473         (dump):
474         (resetDefaultsToConsistentValues):
475         (resetWebViewToConsistentStateBeforeTesting):
476         (sizeWebViewForCurrentTest):
477         (runTest):
478         (openWindows):
479         (windowToWebViewMap):
480         (createWebViewAndOffscreenWindow):
481         (sharedCFURLCache):
482         (initializeGlobalsFromCommandLineOptions):
483         (main):
484         * DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
485         (TestRunner::addDisallowedURL):
486         (TestRunner::applicationCacheDiskUsageForOrigin):
487         (TestRunner::syncLocalStorage):
488         (TestRunner::localStorageDiskUsageForOrigin):
489         (TestRunner::observeStorageTrackerNotifications):
490         (TestRunner::clearApplicationCacheForOrigin):
491         (TestRunner::originsWithApplicationCache):
492         (TestRunner::deleteAllLocalStorage):
493         (TestRunner::setStorageDatabaseIdleInterval):
494         (TestRunner::closeIdleLocalStorageDatabases):
495         (TestRunner::originsWithLocalStorage):
496         (TestRunner::deleteLocalStorageForOrigin):
497         (TestRunner::copyDecodedHostName):
498         (TestRunner::copyEncodedHostName):
499         (TestRunner::keepWebHistory):
500         (TestRunner::numberOfPendingGeolocationPermissionRequests):
501         (TestRunner::setAppCacheMaximumSize):
502         (TestRunner::setCustomPolicyDelegate):
503         (TestRunner::goBack):
504         (TestRunner::setDefersLoading):
505         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
506         (TestRunner::setMockDeviceOrientation):
507         (TestRunner::setMockGeolocationPosition):
508         (TestRunner::setMockGeolocationPositionUnavailableError):
509         (TestRunner::setIconDatabaseEnabled):
510         (TestRunner::setMainFrameIsFirstResponder):
511         (TestRunner::setSpatialNavigationEnabled):
512         (TestRunner::setPluginsEnabled):
513         (TestRunner::setAutomaticLinkDetectionEnabled):
514         (TestRunner::setUseDashboardCompatibilityMode):
515         (TestRunner::dispatchPendingLoadRequests):
516         (TestRunner::findString):
517         (TestRunner::setCacheModel):
518         (TestRunner::apiTestNewWindowDataLoadBaseURL):
519         (TestRunner::setWebViewEditable):
520         (TestRunner::authenticateSession):
521         (TestRunner::abortModal):
522         (TestRunner::setSerializeHTTPLoads):
523         (TestRunner::addChromeInputField):
524         (TestRunner::removeChromeInputField):
525         (TestRunner::focusWebView):
526         (TestRunner::setBackingScaleFactor):
527         (TestRunner::grantWebNotificationPermission):
528         (TestRunner::denyWebNotificationPermission):
529         (TestRunner::removeAllWebNotificationPermissions):
530         (TestRunner::simulateWebNotificationClick):
531
532 2014-12-18  Gavin Barraclough  <barraclough@apple.com>
533
534         Add strong typing to RefCounter interface, return value as a bool.
535         https://bugs.webkit.org/show_bug.cgi?id=139776
536
537         Reviewed by Geoff Garen.
538
539         Currently all token vended by a RefCounter have the same type - Ref<RefCounter::Count>.
540         This means there is no compile time type checking to prevent mistakes. Update the count()
541         method to token<>(), templated on type used to identify the token being returned.
542         Calls to token<T>() will return a result of type RefCounter::Token<T>.
543
544         There are a few problems with the fact the counter will return you an exact count of the
545         number of outstanding tokens:
546           - It is desirable to only fire the callback on zero-edge changes; it is more consistent
547             to do so if the value is only readable as a boolean.
548           - It is desirable to provide the value as an argument to the callback, however to make
549             this useful for integer values it is also necessary to indicate the direction of change
550             (0->1 is often interesting where 2->1 is not).
551           - There is a mismatch between the precision of returning a count, and the inherent
552             imprecision of a token based mechanism, where it may be difficult to guarantee
553             absolutely no unnecessary refcount churn, and thus unintentional counter values.
554
555         * TestWebKitAPI/Tests/WTF/RefCounter.cpp:
556         (TestWebKitAPI::TEST):
557             - update API test.
558
559 2014-12-18  Alexey Proskuryakov  <ap@apple.com>
560
561         Disable retries on Mac Release WK2 testers
562         https://bugs.webkit.org/show_bug.cgi?id=139798
563
564         Reviewed by Simon Fraser.
565
566         * BuildSlaveSupport/build.webkit.org-config/config.json:
567
568 2014-12-18  Alexey Proskuryakov  <ap@apple.com>
569
570         Perf tests frequently fail saying "build not up to date"
571         https://bugs.webkit.org/show_bug.cgi?id=139786
572
573         Illegitimately yet authoritatively reviewed by Lucas Forschler.
574
575         Undo the rest of the first fix, and implement the behavior differently.
576
577         is_clean isn't automatically forwarded from config.json to properties.
578
579         * BuildSlaveSupport/build.webkit.org-config/config.json:
580         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
581         (CleanBuildUnconditionally):
582         (CleanBuildUnconditionally.start):
583         (DownloadAndPerfTestFactory.__init__):
584         (DownloadAndPerfTestWebKit2Factory.__init__):
585
586 2014-12-18  Alexey Proskuryakov  <ap@apple.com>
587
588         Roll out part of the previous patch - BuildAndPerfTestWebKit2 is used by Efl.
589         I thought that it was unused because grepping for BuildAndPerfTestWebKit2Factory
590         found nothing.
591
592         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
593         (BuildAndPerfTestFactory):
594         (BuildAndPerfTestWebKit2Factory):
595
596 2014-12-18  Alexey Proskuryakov  <ap@apple.com>
597
598         Perf tests frequently fail saying "build not up to date"
599         https://bugs.webkit.org/show_bug.cgi?id=139786
600
601         Reviewed by Ryosuke Niwa.
602
603         Perf tests only build DumpRenderTree, not WebKit itself. Just clean the build
604         directory to get rid of stale precompiled headers, and let it rebuild
605         DumpRenderTree each time, that's fast.
606
607         Also, removed unused "build and perf test" code.
608
609         * BuildSlaveSupport/build.webkit.org-config/config.json:
610
611 2014-12-18  Brent Fulgham  <bfulgham@apple.com>
612
613         [Win] Unreviewed gardening. Reorder file contents to match Mac version.
614
615         Reorder the contents of the TestRunnerWin so that it matches TestRunnerMac. This makes
616         it easier to see what steps are missing when running under Windows.
617
618         * DumpRenderTree/win/TestRunnerWin.cpp:
619         (TestRunner::callShouldCloseOnWebView):
620         (TestRunner::clearAllApplicationCaches):
621         (TestRunner::applicationCacheDiskUsageForOrigin):
622         (TestRunner::syncLocalStorage):
623         (TestRunner::localStorageDiskUsageForOrigin):
624         (TestRunner::observeStorageTrackerNotifications):
625         (TestRunner::clearApplicationCacheForOrigin):
626         (TestRunner::originsWithApplicationCache):
627         (TestRunner::clearAllDatabases):
628         (TestRunner::deleteAllLocalStorage):
629         (TestRunner::setStorageDatabaseIdleInterval):
630         (TestRunner::closeIdleLocalStorageDatabases):
631         (TestRunner::originsWithLocalStorage):
632         (TestRunner::deleteLocalStorageForOrigin):
633         (TestRunner::numberOfPendingGeolocationPermissionRequests):
634         (jsStringRefToWString):
635         (TestRunner::setAppCacheMaximumSize):
636         (TestRunner::setDatabaseQuota):
637         (TestRunner::goBack):
638         (TestRunner::setDefersLoading):
639         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
640         (TestRunner::setAutomaticLinkDetectionEnabled):
641         (TestRunner::dispatchPendingLoadRequests):
642         (TestRunner::overridePreference):
643         (TestRunner::removeAllVisitedLinks):
644         (TestRunner::waitForPolicyDelegate):
645         (TestRunner::resetPageVisibility):
646         (TestRunner::setPageVisibility):
647         (TestRunner::grantWebNotificationPermission):
648         (TestRunner::denyWebNotificationPermission):
649         (TestRunner::removeAllWebNotificationPermissions):
650         (TestRunner::simulateWebNotificationClick):
651         (TestRunner::simulateLegacyWebNotificationClick):
652
653 2014-12-18  Brent Fulgham  <bfulgham@apple.com>
654
655         [Win] Correct Windows tests after Bug 139149 (edit)
656         https://bugs.webkit.org/show_bug.cgi?id=139781
657
658         Reviewed by Anders Carlsson.
659
660         * DumpRenderTree/win/TestRunnerWin.cpp:
661         (TestRunner::clearAllApplicationCaches): Use new WebApplicationCache
662         interface.
663
664 2014-12-18  Simon Fraser  <simon.fraser@apple.com>
665
666         [iOS] Remove the various aliases for --ios-simulator (--sim, --simulator, --ios-sim) in arguments for build and test scripts
667         https://bugs.webkit.org/show_bug.cgi?id=139748
668
669         Reviewed by Daniel Bates.
670         
671         Staging change to support --ios-sim and --ios-simulator temporarily until the bots
672         have all been updated.
673
674         * Scripts/webkitpy/port/factory.py:
675         (platform_options):
676
677 2014-12-18  Simon Fraser  <simon.fraser@apple.com>
678
679         Build more of TestWebKitAPI for iOS
680         https://bugs.webkit.org/show_bug.cgi?id=139747
681
682         Reviewed by Daniel Bates.
683         
684         Base.xcconfig removed many test files from the iOS build via EXCLUDED_SOURCE_FILE_NAMES,
685         which excluded some tests that should be run for iOS.
686         
687         Fix by removing some patterns from EXCLUDED_SOURCE_FILE_NAMES, and #ifdeffing
688         source files instead. config.h defines WK_HAVE_C_SPI when the WebKit C SPI is
689         available (i.e. Mac OS X), and most files use that. Some files with Mac-only
690         functionality (ActionMenus, Downloads) use #if PLATFORM(MAC).
691         
692         Added PlatformUtilitiesCocoa.mm and moved WeakObjCPtr.mm into a cocoa directory
693         to share code between Mac and iOS.
694
695         * TestWebKitAPI/Configurations/Base.xcconfig:
696         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
697         * TestWebKitAPI/InjectedBundleController.cpp:
698         * TestWebKitAPI/InjectedBundleMain.cpp:
699         * TestWebKitAPI/JavaScriptTest.cpp:
700         * TestWebKitAPI/PlatformUtilities.cpp:
701         * TestWebKitAPI/PlatformUtilities.h:
702         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
703         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
704         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
705         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
706         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
707         * TestWebKitAPI/Tests/WebKit2/CloseFromWithinCreatePage.cpp:
708         * TestWebKitAPI/Tests/WebKit2/CloseThenTerminate.cpp:
709         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
710         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
711         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
712         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache.cpp:
713         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
714         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp:
715         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp:
716         * TestWebKitAPI/Tests/WebKit2/DidNotHandleKeyDown.cpp:
717         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
718         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
719         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
720         * TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp:
721         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
722         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
723         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
724         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
725         * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
726         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
727         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
728         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
729         * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback.cpp:
730         * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback_Bundle.cpp:
731         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
732         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
733         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
734         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp:
735         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest.cpp:
736         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest_Bundle.cpp:
737         * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins.cpp:
738         * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins_Bundle.cpp:
739         * TestWebKitAPI/Tests/WebKit2/LayoutMilestonesWithAllContentInFrame.cpp:
740         * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
741         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp:
742         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp:
743         * TestWebKitAPI/Tests/WebKit2/LoadPageOnCrash.cpp:
744         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
745         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash_Bundle.cpp:
746         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:
747         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp:
748         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp:
749         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
750         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages_Bundle.cpp:
751         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
752         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp:
753         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp:
754         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
755         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
756         * TestWebKitAPI/Tests/WebKit2/ParentFrame.cpp:
757         * TestWebKitAPI/Tests/WebKit2/ParentFrame_Bundle.cpp:
758         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications.mm:
759         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications_Bundle.cpp:
760         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
761         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp:
762         * TestWebKitAPI/Tests/WebKit2/ReloadPageAfterCrash.cpp:
763         * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
764         * TestWebKitAPI/Tests/WebKit2/ResizeWindowAfterCrash.cpp:
765         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
766         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly_Bundle.cpp:
767         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
768         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
769         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp:
770         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem_Bundle.cpp:
771         * TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp:
772         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
773         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp:
774         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp:
775         * TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp:
776         * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp:
777         * TestWebKitAPI/Tests/WebKit2/UserMessage_Bundle.cpp:
778         * TestWebKitAPI/Tests/WebKit2/WKImageCreateCGImageCrash.cpp:
779         * TestWebKitAPI/Tests/WebKit2/WKPageGetScaleFactorNotZero.cpp:
780         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
781         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
782         (TestWebKitAPI::TEST):
783         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
784         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
785         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
786         * TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp:
787         * TestWebKitAPI/Tests/WebKit2/WebCoreStatisticsWithNoWebProcess.cpp:
788         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp:
789         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
790         * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent.cpp:
791         * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent_Bundle.cpp:
792         * TestWebKitAPI/Tests/WebKit2/cocoa/WeakObjCPtr.mm: Renamed from Tools/TestWebKitAPI/Tests/WebKit2/mac/WeakObjCPtr.mm.
793         (TEST):
794         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
795         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
796         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
797         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm:
798         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
799         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp:
800         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
801         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
802         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing_Bundle.cpp:
803         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
804         * TestWebKitAPI/cocoa/PlatformUtilitiesCocoa.mm: Copied from Tools/TestWebKitAPI/Tests/WebKit2/WKImageCreateCGImageCrash.cpp.
805         (TestWebKitAPI::Util::run):
806         (TestWebKitAPI::Util::sleep):
807         (TestWebKitAPI::Util::toSTD):
808         * TestWebKitAPI/config.h:
809         * TestWebKitAPI/mac/JavaScriptTestMac.mm:
810         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
811         (TestWebKitAPI::Util::run): Deleted.
812         (TestWebKitAPI::Util::sleep): Deleted.
813         (TestWebKitAPI::Util::toSTD): Deleted.
814
815 2014-12-18  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
816
817         [GTK] Add support for FTL JIT on ARM64
818         https://bugs.webkit.org/show_bug.cgi?id=139677
819
820         Reviewed by Csaba Osztrogonác.
821
822         * gtk/jhbuild-optional.modules:
823         * gtk/patches/llvm-elf-add-stackmaps-arm64.patch: Added.
824         * gtk/patches/llvm-elf-allow-fde-references-outside-the-2gb-range-arm64.patch: Added.
825
826 2014-12-18  Adrian Perez de Castro  <aperez@igalia.com>
827
828         [GTK] Implement webkit_web_view_is_playing_audio()
829         https://bugs.webkit.org/show_bug.cgi?id=138918
830
831         Reviewed by Carlos Garcia Campos.
832
833         Add test case case for webkit_web_view_is_playing_audio() and the
834         WebKitWebView::is-playing-audio property.
835
836         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
837         (urlForResource): Utility function to get URLs pointing to resources
838         under the Tools/TestWebKitAPI/Tests/WebKit2/ directory.
839         (testWebViewIsPlayingAudio): Added.
840         (beforeAll):
841         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
842         (getResourcesDir): Allow passing a flag to choose from the WebKit2 GTK
843         API tests resources directory, or the WebKit2 C API tests resources
844         directory. The default value of the flag is to use the WebKit2 GTK
845         one, to avoid having to change existing tests.
846         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
847         (isPlayingAudioChanged): Added.
848         (WebViewTest::waitUntilIsPlayingAudioChanged): Added.
849         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
850
851 2014-12-18  Carlos Alberto Lopez Perez  <clopez@igalia.com>
852
853         [GTK] [EFL] Enable per_test_timeout
854         https://bugs.webkit.org/show_bug.cgi?id=139771
855
856         Reviewed by Csaba Osztrogonác.
857
858         This is needed to make WKTR use either the default port timeout, or the
859         user supplied timeout via the "--time-out-ms" parameter of run-webkit-tests.
860         Otherwise WTR will use the default (30 seconds after r177363 and r177471).
861
862         * Scripts/webkitpy/port/efl.py:
863         (EflPort.supports_per_test_timeout): Enabled.
864         * Scripts/webkitpy/port/gtk.py:
865         (GtkPort.supports_per_test_timeout): Enabled.
866
867 2014-12-17  Lucas Forschler  <lforschler@apple.com>
868
869         Move Apple buildbot slaves to their new home.
870         
871         Reviewed by Roger Fong.
872
873         * BuildSlaveSupport/build.webkit.org-config/config.json:
874
875 2014-12-17  Alexey Proskuryakov  <ap@apple.com>
876
877         REGRESSION (r177363): Gtk and Efl testing is broken
878         https://bugs.webkit.org/show_bug.cgi?id=139734
879
880         Reviewed by Simon Fraser.
881
882         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
883         (SingleTestRunner.__init__): Remove timeout adjustment from here, because it
884         affected both script and tool timeout. This is still the right place for this logic,
885         but it would be a larger refactoring than I can do right now.
886
887         * Scripts/webkitpy/port/base.py:
888         (Port.supports_per_test_timeout): Added a FIXME.
889         (Port.default_timeout_ms): Now that the effective timeout is longer, change this
890         to avoid making tests take more time.
891
892         * Scripts/webkitpy/port/driver.py:
893         (Driver.run_test): Adjust script timeout here.
894         (Driver._check_for_driver_timeout): Fix the timeout detection.
895         (Driver._read_block): Actually use the timeout detection code.
896
897         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting):
898         Use TestRunner default timeout when there isn't a timeout passed from command line for the test.
899
900         * Scripts/webkitpy/port/port_testcase.py: (PortTestCase.test_default_timeout_ms):
901         Update results for the new default.
902
903         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
904         (RunTest.test_hung_thread): Restore a test that I previously deleted, it was
905         actually a good one.
906
907 2014-12-17  Commit Queue  <commit-queue@webkit.org>
908
909         Unreviewed, rolling out r177456.
910         https://bugs.webkit.org/show_bug.cgi?id=139749
911
912         Broke webkitpy and Mac tests (Requested by ap on #webkit).
913
914         Reverted changeset:
915
916         "REGRESSION (r177363): Gtk and Efl testing is broken"
917         https://bugs.webkit.org/show_bug.cgi?id=139734
918         http://trac.webkit.org/changeset/177456
919
920 2014-12-17  Alexey Proskuryakov  <ap@apple.com>
921
922         REGRESSION (r177363): Gtk and Efl testing is broken
923         https://bugs.webkit.org/show_bug.cgi?id=139734
924
925         Reviewed by Simon Fraser.
926
927         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
928         (SingleTestRunner.__init__): Remove timeout adjustment from here, because it
929         affected both script and tool timeout. This is still the right place for this logic,
930         but it would be a larger refactoring than I can do right now.
931
932         * Scripts/webkitpy/port/base.py:
933         (Port.supports_per_test_timeout): Added a FIXME.
934         (Port.default_timeout_ms): Now that the effective timeout is longer, change this
935         to avoid making tests take more time.
936
937         * Scripts/webkitpy/port/driver.py: (Driver.run_test): Adjust script timeout here.
938
939         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting):
940         Use TestRunner default timeout when there isn't a timeout passed from command line for the test.
941
942 2014-12-17  Carlos Garcia Campos  <cgarcia@igalia.com>
943
944         [GTK] Simplify timeout handling in TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded
945         https://bugs.webkit.org/show_bug.cgi?id=139725
946
947         Reviewed by Martin Robinson.
948
949         The timeout is already in milliseconds, so we don't need to do any conversion.
950
951         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
952         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
953
954 2014-12-17  Hunseop Jeong  <hs85.jeong@samsung.com>
955
956         [EFL]Fix build warning in MiniBrowser
957         https://bugs.webkit.org/show_bug.cgi?id=139723
958
959         Reviewed by Darin Adler.
960
961         The warning is caused by the compiler wanting the first argument to be a
962         string literal, not a dynamically created string.
963
964         * MiniBrowser/efl/main.c:
965         (quit):
966
967 2014-12-16  Sam Weinig  <sam@webkit.org>
968
969         TestWebKitAPI should use a static lib to support both Mac and iOS cleanly
970         https://bugs.webkit.org/show_bug.cgi?id=139718
971
972         Reviewed by Mark Rowe.
973
974         Change TestWebKitAPI to be more like DumpRenderTree by moving all the source
975         files into a static lib which the command line utility can link link against.
976         This will allow us to create a TestWebKitAPI.app that can run on iOS.
977
978         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
979         * TestWebKitAPI/Configurations/TestWebKitAPILibrary.xcconfig: Added.
980         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
981
982 2014-12-16  Alexey Proskuryakov  <ap@apple.com>
983
984         Sort out timeout implementations in DRT and WKTR
985         https://bugs.webkit.org/show_bug.cgi?id=139671
986
987         Remove an obsolete test that doesn't capture how run-webkit-tests interacts
988         with the tool.
989
990         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
991         (RunTest.test_hung_thread):
992
993 2014-12-15  Alexey Proskuryakov  <ap@apple.com>
994
995         Sort out timeout implementations in DRT and WKTR
996         https://bugs.webkit.org/show_bug.cgi?id=139671
997
998         Reviewed by Simon Fraser.
999
1000         Test timeout implementation had many deficiencies, please see the bug for details.
1001         Most notably, we shouldn't have the tool confused about timeouts vs. failures, and
1002         [ Slow ] modifiers should work a lot better.
1003
1004         * DumpRenderTree/TestRunner.cpp: (TestRunner::TestRunner):
1005         * DumpRenderTree/TestRunner.h: (TestRunner::setCustomTimeout):
1006         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest):
1007         * DumpRenderTree/mac/TestRunnerMac.mm: (TestRunner::setWaitToDump):
1008         DumpRenderTree already read the --timeout option from command line, and webkitpy
1009         was already configured to pass it on Mac and iOS. Let's actually use it.
1010         TestCommand already had the same 30 second default, so this doesn't change behavior
1011         when DRT is ran manually without the option.
1012         Windows DumpRenderTree will need to be fixed separately (that's easy).
1013
1014         * DumpRenderTree/TestRunner.cpp: (TestRunner::waitToDumpWatchdogTimerFired()):
1015         Don't print the timeout message to stdout to match WebKitTestRunner. It would be
1016         slightly better to use stderr in both, as this is an out of band message, but
1017         that's a larger refactoring, and the difference is minimal in practice.
1018
1019         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1020         (SingleTestRunner.__init__): Ensure that script and tool timeouts are substantially
1021         different. We want the tool to reliably detect timeouts that can be detected, and
1022         not race with the script for that.
1023
1024         * Scripts/webkitpy/port/base.py: (Port.default_timeout_ms): Don't make WebKit2
1025         timeout longer than WebKit1 one, I doubt that this is necessary. Now that the value
1026         is honored inmore cases, that could make tests run slower.
1027         * Scripts/webkitpy/port/driver.py:
1028         (Driver.__init__):
1029         (Driver.run_test):
1030         (Driver.cmd_line):
1031         (Driver._check_for_driver_timeout):
1032         Detect tests that have the timeout output, and make these have the proper Timeout result.
1033
1034         * Scripts/webkitpy/port/ios.py: (IOSSimulatorPort.default_timeout_ms): Remove an
1035         incorrect recent change - 80 * 1000 is 80 seconds, not 80 milliseconds.
1036
1037         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1038         (WTR::TestRunner::setCustomTimeout): Deleted.
1039         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1040         (WTR::TestRunner::setCustomTimeout):
1041         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
1042         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
1043         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1044         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
1045         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp:
1046         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
1047         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
1048         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
1049         Updated to use a timeout passed from UI process, which used to be ignored.
1050
1051         * WebKitTestRunner/TestController.cpp:
1052         (WTR::TestController::TestController):
1053         (WTR::TestController::runUntil):
1054         (WTR::TestController::getCustomTimeout): Deleted.
1055         * WebKitTestRunner/TestController.h:
1056         Delete unused m_timeout. First, it was always 0, and second, we don't need it at all.
1057         Changed default message timeouts to match new run-webkit-tests timeout. These don't
1058         affect ports where timeout is passed per test (shouldn't they all be like that?).
1059
1060         * WebKitTestRunner/TestInvocation.cpp:
1061         (WTR::TestInvocation::invoke):
1062         (WTR::TestInvocation::setCustomTimeout): Deleted.
1063         * WebKitTestRunner/TestInvocation.h:
1064         (WTR::TestInvocation::setCustomTimeout):
1065         (WTR::TestInvocation::customTimeout):
1066         Ditto.
1067
1068 2014-12-16  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
1069
1070         [EFL] Add logging domain for MiniBrowser
1071         https://bugs.webkit.org/show_bug.cgi?id=139642
1072
1073         Reviewed by Gyuyoung Kim.
1074
1075         Similarly to EWebKit2, provide logging facility for MiniBrowser
1076         based on Eina Log module to have a convenient way to display
1077         all/subset/none messages for EFL based libraries and MiniBrowser.
1078
1079         Usage:
1080         1. Disable all messages:
1081            EINA_LOG_LEVEL=0 ./Tools/Scripts/run-launcher --efl
1082
1083         2. Enable all messages:
1084            EINA_LOG_LEVEL=7 ./Tools/Scripts/run-launcher --efl
1085
1086         3. Enable MiniBrowser and EWebkit2 messages only:
1087            EINA_LOG_LEVELS="minibrowser:7,ewebkit2:7" ./Tools/Scripts/run-launcher --efl
1088
1089         More information and examples you can find here:
1090         http://docs.enlightenment.org/auto/eet/tutorial_log_page.html
1091
1092         * MiniBrowser/efl/main.c:
1093         (on_mouse_wheel):
1094         (on_window_resize):
1095         (save_page_contents_callback):
1096         (script_execute_callback):
1097         (on_key_down):
1098         (on_download_request):
1099         (on_download_finished):
1100         (on_download_failed):
1101         (quit):
1102         (on_refresh_button_clicked):
1103         (on_stop_button_clicked):
1104         (navigation_button_longpress_process):
1105         (on_popup_menu_item_clicked):
1106         (popup_menu_populate):
1107         (on_popup_menu_show):
1108         (on_window_create):
1109         (context_menu_item_selected_cb):
1110         (context_menu_populate):
1111         (on_context_menu_show):
1112         (on_context_menu_hide):
1113         (on_navigation_policy_decision):
1114         (window_create):
1115         (parse_cookies_policy):
1116         (elm_main):
1117         (has_scheme):
1118         (list_item_label_get):
1119         (on_popup_menu_hide):
1120         (on_window_close):
1121         (on_home_button_clicked):
1122         Replace locally info() macro with newly introduced
1123         one which uses Eina Log module. There is no logic change.
1124
1125 2014-12-15  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
1126
1127         [EFL] FTL JIT not working on ARM64
1128         https://bugs.webkit.org/show_bug.cgi?id=139295
1129
1130         Reviewed by Michael Saboff.
1131
1132         Added patches for llvm to add ARM64 support for FTL JIT
1133
1134         * efl/jhbuild.modules:
1135         * efl/patches/llvm-elf-add-stackmaps-arm64.patch: Added.
1136         * efl/patches/llvm-elf-allow-fde-references-outside-the-2gb-range-arm64.patch: Added.
1137
1138 2014-12-15  Timothy Horton  <timothy_horton@apple.com>
1139
1140         Move Said to the committers section.
1141
1142         * Scripts/webkitpy/common/config/contributors.json:
1143
1144 2014-12-15  Timothy Horton  <timothy_horton@apple.com>
1145
1146         Implement Data Detectors immediate actions for WebKit2
1147         https://bugs.webkit.org/show_bug.cgi?id=139617
1148         <rdar://problem/19198539>
1149
1150         Reviewed by Beth Dakin.
1151
1152         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
1153         (TestWebKitAPI::TEST):
1154         Temporarily disable the action menu tests while the
1155         underlying code is in flux.
1156
1157 2014-12-14  Andreas Kling  <akling@apple.com>
1158
1159         Replace PassRef with Ref/Ref&& across the board.
1160         <https://webkit.org/b/139587>
1161
1162         Reviewed by Darin Adler.
1163
1164         * TestWebKitAPI/Tests/WTF/Ref.cpp:
1165         (TestWebKitAPI::passWithRef):
1166         (TestWebKitAPI::TEST):
1167         (TestWebKitAPI::passWithPassRef): Deleted.
1168         * TestWebKitAPI/Tests/WTF/RefCounter.cpp:
1169         (TestWebKitAPI::TEST):
1170         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
1171         (TestWebKitAPI::TEST):
1172         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
1173         (TestWebKitAPI::createTestValue):
1174
1175 2014-12-13  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
1176
1177         [EFL] MiniBrowser's window_create may return NULL
1178         https://bugs.webkit.org/show_bug.cgi?id=139585
1179
1180         Reviewed by Gyuyoung Kim.
1181
1182         Move NULL checking before using object which window_create
1183         returns.
1184
1185         * MiniBrowser/efl/main.c:
1186         (elm_main):
1187
1188 2014-12-12  Alexey Proskuryakov  <ap@apple.com>
1189
1190         Layout Test http/tests/loading/307-after-303-after-post.html is flaky
1191         https://bugs.webkit.org/show_bug.cgi?id=73030
1192
1193         Reviewed by Anders Carlsson.
1194
1195         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize): Set icon
1196         database to empty to avoid having it fetch default favicons at random times.
1197         DumpRenderTree also disables it, and also it has a way for tests to temporarily
1198         enable it.
1199
1200 2014-12-12  Lucas Forschler  <lforschler@apple.com>
1201
1202         Update Apple owned build slaves after infrastructure update.
1203         
1204         Reviewed by Ryosuke Niwa.
1205
1206         * BuildSlaveSupport/build.webkit.org-config/config.json:
1207
1208 2014-12-11  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1209
1210         [GTK] REGRESSION(r175555) GTK API Tests run outside the JHBuild.
1211         https://bugs.webkit.org/show_bug.cgi?id=139537
1212
1213         Reviewed by Carlos Garcia Campos.
1214
1215         * jhbuild/jhbuild-wrapper: Pass the port name in the invocation
1216         of get_dependencies_path().
1217         * jhbuild/jhbuildutils.py:
1218         (get_dependencies_path): Fix the function to return the new
1219         dependencies path: DependenciesPORT.
1220         (enter_jhbuild_environment_if_available): Pass the port name
1221         when invoking get_dependencies_path().
1222
1223 2014-12-10  Lucas Forschler  <lforschler@apple.com>
1224
1225         Update Apple owned build slaves.
1226         
1227         Rubber-stamped by Dana Burkart.
1228         
1229         * BuildSlaveSupport/build.webkit.org-config/config.json:
1230
1231 2014-12-10  Daniel Bates  <dabates@apple.com>
1232
1233         [iOS] REGRESSION (r174642): Watchdog timer expiration reported as DumpRenderTree.app
1234         timeout instead of test failure
1235         https://bugs.webkit.org/show_bug.cgi?id=139525
1236
1237         Reviewed by Zalan Bujtas.
1238
1239         Increase the default process timeout limit in run-webkit-tests to 80ms to prevent
1240         run-webkit-tests from prematurely terminating DumpRenderTree.app before it dumps
1241         output.
1242
1243         Following <http://trac.webkit.org/changeset/174642>, DumpRenderTree.app waits
1244         for the WebThread to spin its run loop before dumping its output. A test that
1245         calls testRunner.waitUntilDone() and does not subsequently call testRunner.notifyDone()
1246         before DumpRenderTree.app's watchdog timer expires may be incorrectly reported
1247         by run-webkit-tests as a DumpRenderTree.app timeout instead of a test failure
1248         because run-webkit-tests may terminate a DumpRenderTree.app process when it
1249         exceeds its process time limit (defaults to 35ms) regardless of whether such
1250         a DumpRenderTree.app process was waiting for the WebThread to run so as to dump output.
1251
1252         * Scripts/webkitpy/port/ios.py:
1253         (IOSSimulatorPort.default_timeout_ms):
1254
1255 2014-12-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1256
1257         [GTK][WK2] Add HTML5 Notifications support
1258         https://bugs.webkit.org/show_bug.cgi?id=61140
1259
1260         Reviewed by Carlos Garcia Campos.
1261
1262         * Scripts/webkitperl/FeatureList.pm: enable notifications for GTK+.
1263         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1264         (testWebViewNotification):
1265         (beforeAll):
1266         * MiniBrowser/gtk/BrowserWindow.c: also handle notification permission requests.
1267         (permissionRequestDialogCallback):
1268         (webViewDecidePermissionRequest):
1269         (geolocationRequestDialogCallback): Deleted.
1270
1271 2014-12-09  Benjamin Poulain  <bpoulain@apple.com>
1272
1273         Fix webkitpy test expectation
1274
1275         Not sure what I messed up, but TOTAL_SKIPS was not right.
1276
1277         * Scripts/webkitpy/port/test.py:
1278
1279 2014-12-09  Benjamin Poulain  <bpoulain@apple.com>
1280
1281         Remove virtual test support from webkitpy
1282         https://bugs.webkit.org/show_bug.cgi?id=139427
1283
1284         Reviewed by Alexey Proskuryakov.
1285
1286         It seems that the only concrete client of virtual tests is the unit tests :D
1287
1288         This patch tries to clean as much useless code as possible.
1289
1290         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1291         (RunTest.test_tolerance):
1292         (RunTest.test_virtual): Deleted.
1293         * Scripts/webkitpy/layout_tests/views/printing.py:
1294         (Printer._print_test_trace):
1295         * Scripts/webkitpy/port/base.py:
1296         (Port.expected_filename):
1297         (Port.tests):
1298         (Port.test_isfile):
1299         (Port.test_isdir):
1300         (Port.sample_process):
1301         (Port.find_system_pid):
1302         (Port.test_expectations_file_position):
1303         (Port.virtual_test_suites): Deleted.
1304         (Port): Deleted.
1305         (Port.populated_virtual_test_suites): Deleted.
1306         (Port._virtual_tests): Deleted.
1307         (Port.lookup_virtual_test_base): Deleted.
1308         (Port.lookup_virtual_test_args): Deleted.
1309         (VirtualTestSuite): Deleted.
1310         (VirtualTestSuite.__init__): Deleted.
1311         (VirtualTestSuite.__repr__): Deleted.
1312         * Scripts/webkitpy/port/base_unittest.py:
1313         (PortTest.test_test_exists):
1314         (PortTest.test_test_isfile):
1315         (PortTest.test_test_isdir):
1316         (PortTest.test_tests):
1317         * Scripts/webkitpy/port/driver.py:
1318         (DriverProxy.run_test): Deleted.
1319         * Scripts/webkitpy/port/test.py:
1320         (TestPort._skipped_tests_for_unsupported_features):
1321         (TestPort.all_baseline_variants):
1322         (TestPort.virtual_test_suites): Deleted.
1323         * Scripts/webkitpy/tool/commands/queries.py:
1324         (PrintBaselines.__init__):
1325         (PrintBaselines.execute):
1326         * Scripts/webkitpy/tool/commands/queries_unittest.py:
1327         (PrintBaselinesTest.test_basic):
1328         (PrintBaselinesTest.test_multiple):
1329         (PrintBaselinesTest.test_csv):
1330
1331 2014-12-09  Csaba Osztrogonác  <ossy@webkit.org>
1332
1333         Blink Merge: Remove 'http_lock' code from webkitpy
1334         https://bugs.webkit.org/show_bug.cgi?id=136722
1335
1336         Reviewed by Alexey Proskuryakov.
1337
1338         Based on Blink commit by Dirk Pranke <dpranke@chromium.org>
1339         https://chromium.googlesource.com/chromium/blink/+/196f8146a948275c2f1594b13e30ab19a6e6fd66
1340
1341         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1342         (LayoutTestRunner.__init__):
1343         (LayoutTestRunner.run_tests):
1344         (LayoutTestRunner.start_servers): Renamed from start_servers_with_lock.
1345         (LayoutTestRunner.stop_servers): Renamed from stop_servers_with_lock.
1346         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
1347         (FakePrinter.flush):
1348         (LayoutTestRunnerTests._runner):
1349         (LayoutTestRunnerTests._run_tests):
1350         (LayoutTestRunnerTests.test_servers_started):
1351         (LockCheckingRunner): Deleted.
1352         (LockCheckingRunner.__init__): Deleted.
1353         (LockCheckingRunner.handle_finished_list): Deleted.
1354         (LayoutTestRunnerTests.test_http_locking): Deleted.
1355         * Scripts/webkitpy/port/base.py:
1356         (Port.__init__):
1357         (Port.to.http_server_supports_ipv6):
1358         (Port.to.stop_websocket_server):
1359         (Port.to.acquire_http_lock): Deleted.
1360         (Port.to.release_http_lock): Deleted.
1361         * Scripts/webkitpy/port/http_lock.py: Removed.
1362         * Scripts/webkitpy/port/http_lock_unittest.py: Removed.
1363         * Scripts/webkitpy/port/ios.py:
1364         (IOSSimulatorPort.show_results_html_file):
1365         (IOSSimulatorPort.acquire_http_lock): Deleted.
1366         (IOSSimulatorPort): Deleted.
1367         (IOSSimulatorPort.release_http_lock): Deleted.
1368         * Scripts/webkitpy/port/mac.py:
1369         (MacPort.show_results_html_file):
1370         (MacPort): Deleted.
1371         (MacPort.acquire_http_lock): Deleted.
1372         (MacPort.release_http_lock): Deleted.
1373         * Scripts/webkitpy/port/mock_drt.py:
1374         (MockDRTPort.start_websocket_server):
1375         (MockDRTPort.stop_websocket_server):
1376         (MockDRTPort.acquire_http_lock): Deleted.
1377         (MockDRTPort.release_http_lock): Deleted.
1378         * Scripts/webkitpy/port/mock_drt_unittest.py:
1379         (MockDRTPortTest.test_uses_apache):
1380         (MockDRTPortTest.integration_test_http_lock): Deleted.
1381         * Scripts/webkitpy/port/port_testcase.py:
1382         (PortTestCase.assert_servers_are_up):
1383         (PortTestCase.integration_test_http_lock): Deleted.
1384         * Scripts/webkitpy/port/test.py:
1385         (TestPort.start_websocket_server):
1386         (TestPort.stop_websocket_server):
1387         (TestPort.acquire_http_lock): Deleted.
1388         (TestPort.release_http_lock): Deleted.
1389
1390 2014-12-09  Alberto Garcia  <berto@igalia.com>
1391
1392         convertToUTF8String converts null string to empty string
1393         https://bugs.webkit.org/show_bug.cgi?id=133904
1394
1395         Reviewed by Carlos Garcia Campos.
1396
1397         Test that trying to get the value of a non-existent attribute
1398         returns 0 instead of an empty string.
1399
1400         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
1401         (WebKitDOMNodeTest::testInsertion):
1402
1403 2014-12-09  Joanmarie Diggs  <jdiggs@igalia.com>
1404
1405         [GTK] Bump minimum version of ATK used by jhbuild to at least 2.15.2
1406         https://bugs.webkit.org/show_bug.cgi?id=139070
1407
1408         Reviewed by Carlos Garcia Campos.
1409
1410         * gtk/jhbuild.modules:
1411
1412 2014-12-08  Tim Horton  <timothy_horton@apple.com>
1413
1414         Add action menu tests
1415         https://bugs.webkit.org/show_bug.cgi?id=139156
1416
1417         Reviewed by Dean Jackson.
1418
1419         * TestWebKitAPI/PlatformWebView.h:
1420         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1421         (TestWebKitAPI::PlatformWebView::PlatformWebView):
1422         Add a mechanism allowing tests to provide their own WKView subclass.
1423
1424         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1425         * TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Added.
1426         Add a file with lots of menu targets.
1427
1428         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm: Added.
1429         (-[ActionMenusTestWKView _actionMenuItemsForHitTestResult:withType:defaultActionMenuItems:userData:]):
1430         (-[ActionMenusTestWKView runMenuSequenceAtPoint:preMenuNeedsUpdateHandler:preWillOpenMenuHandler:preDidCloseMenuHandler:]):
1431         (-[ActionMenusTestWKView runMenuSequenceAtPoint:preDidCloseMenuHandler:]):
1432         Run through the normal sequence of callbacks, recording what items and type were returned, and give clients a chance to do work at various points in the process.
1433
1434         (-[ActionMenusTestWKView _setOverrideActionMenuItems:]):
1435
1436         (TestWebKitAPI::didFinishLoadForFrameCallback):
1437         (TestWebKitAPI::didFinishDownloadCallback):
1438         (TestWebKitAPI::didCreateDownloadDestinationCallback):
1439         Watch downloads and ensure that they match the content we expect.
1440
1441         (TestWebKitAPI::watchPasteboardForString):
1442         (TestWebKitAPI::watchPasteboardForImage):
1443         (TestWebKitAPI::JavaScriptStringCallbackContext::JavaScriptStringCallbackContext):
1444         (TestWebKitAPI::JavaScriptBoolCallbackContext::JavaScriptBoolCallbackContext):
1445         (TestWebKitAPI::javaScriptStringCallback):
1446         (TestWebKitAPI::javaScriptBoolCallback):
1447         (TestWebKitAPI::callJavaScriptReturningString):
1448         (TestWebKitAPI::callJavaScriptReturningBool):
1449         (TestWebKitAPI::watchEditableAreaForString):
1450         (TestWebKitAPI::waitForVideoReady):
1451         (TestWebKitAPI::retrieveSelection):
1452         (TestWebKitAPI::retrieveSelectionInElement):
1453         (TestWebKitAPI::performMenuItemAtIndexOfTypeAsync):
1454         (TestWebKitAPI::ensureMenuItemAtIndexOfTypeIsDisabled):
1455         Add many helpers for testing, especially to make asynchronous things synchronous.
1456
1457         (TestWebKitAPI::windowPointForTarget):
1458         (TestWebKitAPI::inset8):
1459         Hard-code points in action-menu-targets.html for hit testing.
1460
1461         (TestWebKitAPI::TEST):
1462         Add a suite of tests for WebKit2 action menus.
1463
1464         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm: Added.
1465         (TestWebKitAPI::createActionContextForPhoneNumber):
1466         (TestWebKitAPI::ActionMenuTest::ActionMenuTest):
1467         (TestWebKitAPI::ActionMenuTest::prepareForActionMenu):
1468         (TestWebKitAPI::ActionMenuTest::actionContextForResultAtPoint):
1469         (TestWebKitAPI::ActionMenuTest::drawRect):
1470         (TestWebKitAPI::ActionMenuTest::didCreatePage):
1471         Add a bundle with a PageOverlay and a actionContextForResultAtPoint override,
1472         so that we can test that infrastructure.
1473
1474 2014-12-08  Philippe Normand  <pnormand@igalia.com>
1475
1476         [GTK] UserMedia Permission Request API
1477         https://bugs.webkit.org/show_bug.cgi?id=136449
1478
1479         Reviewed by Carlos Garcia Campos.
1480
1481         The GTK version of the MiniBrowser has gained UserMedia permission
1482         request support.
1483
1484         * MiniBrowser/gtk/BrowserWindow.c: Show a popup when the page
1485         requires user permission to access audio/video devices.
1486         (permissionRequestDialogCallback):
1487         (webViewDecidePermissionRequest):
1488         (geolocationRequestDialogCallback): Deleted.
1489
1490 2014-12-08  Anders Carlsson  <andersca@apple.com>
1491
1492         Add a stubbed out method for clearing out the website data store
1493         https://bugs.webkit.org/show_bug.cgi?id=139404
1494
1495         Reviewed by Antti Koivisto.
1496
1497         Add a debug menu item for testing clearing of website data.
1498
1499         * MiniBrowser/mac/MainMenu.xib:
1500         * MiniBrowser/mac/WK2BrowserWindowController.m:
1501         (-[WK2BrowserWindowController clearWebsiteData:]):
1502
1503 2014-12-07  Gwang Yoon Hwang  <yoon@igalia.com>
1504
1505         Update style checker to deal with "const override"
1506         https://bugs.webkit.org/show_bug.cgi?id=139371
1507
1508         Reviewed by Csaba Osztrogonác.
1509
1510         check-webkit-style shouldn't complain about an open brace to start a
1511         line after a function definition with const override.
1512
1513         * Scripts/webkitpy/style/checkers/cpp.py:
1514         (check_braces):
1515         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1516         (CppStyleTest.test_brace_at_begin_of_line):
1517
1518 2014-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1519
1520         [GTK] Fix GObject DOM bindings API break tests after r176920
1521         https://bugs.webkit.org/show_bug.cgi?id=139368
1522
1523         Reviewed by Gustavo Noronha Silva.
1524
1525         Remove the @version from the symbol name before comparing.
1526
1527         * gtk/check-for-webkitdom-api-breaks:
1528         (read_expected_api):
1529
1530 2014-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1531
1532         Remove the option to automatically update the GObject DOM bindings symbols file
1533         https://bugs.webkit.org/show_bug.cgi?id=139366
1534
1535         Reviewed by Martin Robinson.
1536
1537         It's currently broken, because symbols now need to be in a
1538         specific order. Now that the symbols file only contains stable
1539         API, it's not a problem to manually update it every time new API
1540         is added.
1541
1542         * gtk/check-for-webkitdom-api-breaks:
1543         (read_expected_api):
1544         (check_api):
1545         (write_expected_api): Deleted.
1546
1547 2014-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1548
1549         [GTK] Use GMainLoopSource in WebKitTestRunner
1550         https://bugs.webkit.org/show_bug.cgi?id=138831
1551
1552         Reviewed by Sergio Villar Senin.
1553
1554         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1555         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
1556         (WTR::TestRunner::platformInitialize):
1557         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
1558         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
1559         (WTR::waitToDumpWatchdogTimerCallback): Deleted.
1560         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1561         (WTR::TestController::notifyDone):
1562         (WTR::TestController::platformRunUntil):
1563         (WTR::cancelTimeout): Deleted.
1564
1565 2014-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1566
1567         [GTK] Missing API detected in GObject DOM bindings after r176630
1568         https://bugs.webkit.org/show_bug.cgi?id=139201
1569
1570         Reviewed by Gustavo Noronha Silva.
1571
1572         Handle deprecated symbols again when generating the GObject DOM
1573         bindings documentation.
1574
1575         * gtk/webkitdom.py:
1576         (WebKitDOMDocGenerator):
1577         (WebKitDOMDocGenerator.is_deprecated_symbol_file):
1578         (WebKitDOMDocGenerator.generate):
1579         (WebKitDOMDocGeneratorSections.__init__):
1580         (WebKitDOMDocGeneratorSections._find_deprecated_symbols):
1581         (WebKitDOMDocGeneratorSections.write_section):
1582
1583 2014-12-07  Csaba Osztrogonác  <ossy@webkit.org>
1584
1585         [EFL][jhbuild] Fix libsoup build with clang
1586         https://bugs.webkit.org/show_bug.cgi?id=139088
1587
1588         Reviewed by Gyuyoung Kim.
1589
1590         * efl/jhbuild.modules:
1591         * efl/patches/soup-clang-warning-fix1.patch: Added.
1592         * efl/patches/soup-clang-warning-fix2.patch: Added.
1593
1594 2014-12-06  Alexey Proskuryakov  <ap@apple.com>
1595
1596         [Mac] DumpRenderTree sets storage directory incorrectly
1597         https://bugs.webkit.org/show_bug.cgi?id=139347
1598
1599         Reviewed by Dan Bernstein.
1600
1601         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
1602         Don't use user defaults to pass per-instance paths, as user defaults are shared
1603         across all instances.
1604
1605 2014-12-05  Chris Fleizach  <cfleizach@apple.com>
1606
1607         AX: I cannot activate links on the mobile version of news.google.com
1608         https://bugs.webkit.org/show_bug.cgi?id=139330
1609
1610         Reviewed by Simon Fraser.
1611
1612         Implement press for iOS.
1613
1614         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1615         (AccessibilityUIElement::press):
1616
1617 2014-12-05  Daniel Bates  <dabates@apple.com>
1618
1619         [iOS] Query -[WAKWindow screenScale] instead of using WKGetScreenScaleFactor()
1620         https://bugs.webkit.org/show_bug.cgi?id=139326
1621
1622         Reviewed by Anders Carlsson.
1623
1624         Ask the window for its screen scale factor instead of calling WKGetScreenScaleFactor()
1625         to query the OS for it. This approach will ensure DumpRenderTree takes the snapshot
1626         using the same scale factor as used in WebKit.
1627
1628         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
1629         (createBitmapContextFromWebView):
1630
1631 2014-12-05  Anders Carlsson  <andersca@apple.com>
1632
1633         REGRESSION (r176677): All tests crash on Windows
1634         https://bugs.webkit.org/show_bug.cgi?id=139321
1635
1636         Reviewed by Alexey Proskuryakov.
1637
1638         * DumpRenderTree/win/DumpRenderTree.cpp:
1639         (runTest):
1640         Don't call CFRelease on the url while we have an outstanding pointer to its string,
1641         and use the right number of bytes when allocating the testURL buffer.
1642
1643 2014-12-05  Daniel Bates  <dabates@apple.com>
1644
1645         [iOS] DumpRenderTree produces many reference test mismatches
1646         https://bugs.webkit.org/show_bug.cgi?id=139314
1647
1648         Reviewed by Simon Fraser.
1649
1650         Fixes an issue where the scale factor used to render the snapshot taken by
1651         DumpRenderTree may differ from the device scale factor. In particular, the
1652         scale factor used to render a snapshot of a test may differ from the scale
1653         factor used to render the snapshot of its expected result.
1654
1655         Currently DumpRenderTree uses SPI, -[UIView newSnapshotForRect], on iOS to
1656         snapshot the UIWebBrowserView. This SPI always render using a scale factor
1657         of one when the backing store for the LegacyTileLayer objects were out-of-
1658         date regardless of the device scale factor. Instead we should use UIImage
1659         and CALayer API to perform the snapshot with respect to the device scale
1660         factor.
1661
1662         Additionally write iOS pixel dump support logic in terms of existing
1663         DumpRenderTree abstractions so as to support generating and comparing
1664         pixel dump checksums as well as make the iOS code more consistent with
1665         the logic used by other ports.
1666
1667         * DumpRenderTree/PixelDumpSupport.cpp:
1668         (dumpWebViewAsPixelsAndCompareWithExpected): Removed !PLATFORM(IOS)-guard.
1669         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
1670         (BitmapContext::createFromUIImage): Added.
1671         (BitmapContext::pixelData): Added.
1672         (BitmapContext::BitmapContext): Added.
1673         (computeMD5HashStringForBitmapContext): Added.
1674         (dumpBitmap): Added.
1675         (createBitmapContextFromWebView): Moved logic from dumpWebViewAsPixelsAndCompareWithExpected() to here.
1676         (dumpWebViewAsPixelsAndCompareWithExpected): Deleted.
1677
1678 2014-12-05  Anders Carlsson  <andersca@apple.com>
1679
1680         Give all web pages a website data store
1681         https://bugs.webkit.org/show_bug.cgi?id=139317
1682
1683         Reviewed by Tim Horton.
1684
1685         * MiniBrowser/mac/AppDelegate.m:
1686         (-[BrowserAppDelegate newPrivateWindow:]):
1687         Don't release the controller - it's implicitly retained by the window.
1688
1689 2014-12-05  Daniel Bates  <dabates@apple.com>
1690
1691         [iOS] DumpRenderTree fails to render every other test when pixel tests are on
1692         https://bugs.webkit.org/show_bug.cgi?id=137581
1693         <rdar://problem/18642906>
1694
1695         Reviewed by Simon Fraser.
1696
1697         Fixes an issue where the DumpRenderTree snapshot may reflect the rendered content
1698         of the test that proceeded the currently running test.
1699
1700         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
1701         (dumpWebViewAsPixelsAndCompareWithExpected): Ensure that UIKit has performed a layout
1702         of the UIWebBrowserView view. Also, remove unnecessary call to -[UIWebDocumentView layoutTilesNow]
1703         as -[UIWebDocumentView newSnapshotWithRect] will layout the tiles.
1704
1705 2014-12-05  Jer Noble  <jer.noble@apple.com>
1706
1707         [WTF] MediaTime should support round-tripping from and to doubles.
1708         https://bugs.webkit.org/show_bug.cgi?id=139248
1709
1710         Reviewed by Eric Carlson.
1711
1712         Add API tests for new features of MediaTime. Update the LLDB python provider to correctly display
1713         the MediaTimes after this change.
1714
1715         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
1716         (WTF::operator<<):
1717         (TestWebKitAPI::TEST):
1718         * lldb/lldb_webkit.py:
1719         (WTFMediaTime_SummaryProvider):
1720         (WTFMediaTimeProvider.timeValueAsDouble):
1721         (WTFMediaTimeProvider.isIndefinite):
1722         (WTFMediaTimeProvider):
1723         (WTFMediaTimeProvider.hasDoubleValue):
1724
1725 2014-12-05  Anders Carlsson  <andersca@apple.com>
1726
1727         Add a private browsing mode to MiniBrowser
1728         https://bugs.webkit.org/show_bug.cgi?id=139308
1729
1730         Reviewed by Sam Weinig.
1731
1732         * MiniBrowser/mac/AppDelegate.m:
1733         (defaultConfiguration):
1734         (-[BrowserAppDelegate newWindow:]):
1735         (-[BrowserAppDelegate newPrivateWindow:]):
1736         * MiniBrowser/mac/MainMenu.xib:
1737         * MiniBrowser/mac/WK2BrowserWindowController.h:
1738         * MiniBrowser/mac/WK2BrowserWindowController.m:
1739         (-[WK2BrowserWindowController awakeFromNib]):
1740         (-[WK2BrowserWindowController initWithConfiguration:]):
1741         (-[WK2BrowserWindowController dealloc]):
1742         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
1743
1744 2014-12-04  Alexey Proskuryakov  <ap@apple.com>
1745
1746         Run http tests parallel
1747         https://bugs.webkit.org/show_bug.cgi?id=138958
1748
1749         Reviewed by Daniel Bates.
1750
1751         Remove the concept of "locked shard". Now http tests are just like any other tests.
1752         We start HTTP and WebSocket servers at the start if we need them, and terminate them
1753         when done with all the tests (not when the last http test runs, which is unnecessarily
1754         unpredictable).
1755
1756         This makes debug tests run in 8 minutes and 12 seconds on my Mac Pro. Without the
1757         patch, they used to take over 15 minutes.
1758
1759         As part of the fix, we no longer pass the number of servers to Apache. I don't
1760         think that these parameters did what we wanted them to do; Apache handles the load
1761         just fine without them.
1762
1763         The change applies to all platforms. I fixed everything I could find on Mac, and
1764         Ossy told me that he's been running http tests in parallel for a long time. If
1765         there is increased instability for some ports, it will need to be fixed - there is
1766         generally nothing special about http tests at this point, and most code is
1767         cross-platform in WebKit2.
1768
1769         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1770         (LayoutTestRunner.__init__):
1771         (LayoutTestRunner.run_tests):
1772         (LayoutTestRunner.start_servers_with_lock):
1773         (LayoutTestRunner._handle_started_test):
1774         (Worker.handle):
1775         (Sharder.__init__):
1776         (Sharder.shard_tests):
1777         (Sharder._shard_every_file):
1778         (Sharder._shard_by_directory):
1779         (LayoutTestRunner._handle_finished_test_list): Deleted.
1780         (LayoutTestRunner._handle_finished_test_list.find): Deleted.
1781         (Sharder._shard_in_two): Deleted.
1782         (Sharder): Deleted.
1783         (Sharder._resize_shards): Deleted.
1784         (Sharder._resize_shards.divide_and_round_up): Deleted.
1785         (Sharder._resize_shards.extract_and_flatten): Deleted.
1786         (Sharder._resize_shards.split_at): Deleted.
1787         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
1788         (FakePrinter.print_workers_and_shards):
1789         (LayoutTestRunnerTests.test_servers_started.start_http_server):
1790         (LayoutTestRunnerTests.test_servers_started):
1791         (SharderTests.get_shards):
1792         (SharderTests.test_shard_by_dir):
1793         (SharderTests.test_shard_every_file):
1794         (SharderTests): Deleted.
1795         (SharderTests.test_shard_in_two): Deleted.
1796         (SharderTests.test_shard_in_two_has_no_locked_shards): Deleted.
1797         (SharderTests.test_shard_in_two_has_no_unlocked_shards): Deleted.
1798         (SharderTests.test_multiple_locked_shards): Deleted.
1799         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1800         (ManagerTest.test_needs_servers.get_manager):
1801         (ManagerTest.integration_test_needs_servers.get_manager):
1802         (ManagerTest.test_look_for_new_crash_logs.get_manager):
1803         (ManagerTest):
1804         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1805         (_set_up_derived_options):
1806         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1807         (RunTest.test_batch_size):
1808         (RunTest.test_max_locked_shards): Deleted.
1809         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1810         (LayoutTestApacheHttpd.__init__):
1811         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
1812         (TestLayoutTestApacheHttpd.test_start_cmd):
1813         * Scripts/webkitpy/layout_tests/servers/http_server.py:
1814         (Lighttpd.__init__):
1815         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
1816         (HttpServerBase.__init__):
1817         * Scripts/webkitpy/layout_tests/views/printing.py:
1818         (Printer.print_workers_and_shards):
1819         * Scripts/webkitpy/port/base.py:
1820         (Port.default_child_processes):
1821         (Port.to.start_http_server):
1822         (Port.default_max_locked_shards): Deleted.
1823         * Scripts/webkitpy/port/port_testcase.py:
1824         (PortTestCase.make_port):
1825         (PortTestCase.test_default_max_locked_shards): Deleted.
1826         * Scripts/webkitpy/port/test.py:
1827         (TestPort.start_http_server):
1828
1829 2014-12-04  Alexey Proskuryakov  <ap@apple.com>
1830
1831         Don't lock perf tests in run-webkit-tests
1832         https://bugs.webkit.org/show_bug.cgi?id=139264
1833
1834         Reviewed by Daniel Bates.
1835
1836         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1837         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
1838         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1839         * Scripts/webkitpy/layout_tests/models/test_input.py:
1840         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1841
1842 2014-12-03  Alexey Proskuryakov  <ap@apple.com>
1843
1844         http/tests/security/mixedContent/about-blank-iframe-in-main-frame.html fails unless certain other tests run before it
1845         https://bugs.webkit.org/show_bug.cgi?id=139243
1846
1847         Reviewed by Anders Carlsson.
1848
1849         We didn't get WKPageLoaderClient calls in secondary windows, so we didn't have a
1850         chance to allow untrusted certificates.
1851
1852         * WebKitTestRunner/TestController.cpp: (WTR::TestController::createOtherPage):
1853         Set up more client objects for secondary windows. We may be able to share some of the
1854         code with main view creation function, but it's not exactly the same (notably, we
1855         do not focus a secondary window when it's done loading).
1856
1857 2014-12-03  Joanmarie Diggs  <jdiggs@igalia.com>
1858
1859         AX: [ATK] Inline text elements with accessible object attributes and/or event handlers are not exposed
1860         https://bugs.webkit.org/show_bug.cgi?id=139071
1861
1862         Reviewed by Chris Fleizach.
1863
1864         Add string value for ATK_ROLE_STATIC in roleToString.
1865
1866         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1867
1868 2014-12-03  Renato Nagy  <rnagy@inf.u-szeged.hu>
1869
1870         check-webkit-style is confused by ternary expression inside first member initializer
1871         https://bugs.webkit.org/show_bug.cgi?id=136442
1872
1873         Reviewed by Csaba Osztrogonác.
1874
1875         * Scripts/webkitpy/style/checkers/cpp.py:
1876         (check_member_initialization_list):
1877
1878 2014-12-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1879
1880         [GTK] [JHBuild] gst-plugins-bad fails to build if the GNUStep libraries are installed.
1881         https://bugs.webkit.org/show_bug.cgi?id=139220
1882
1883         Reviewed by Philippe Normand.
1884
1885         * gtk/jhbuild.modules:
1886         * gtk/patches/gst-plugins-bad-remove-gnustep-support.patch: Added.
1887
1888 2014-12-03  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
1889
1890         Remove unused JSC runtime options
1891         https://bugs.webkit.org/show_bug.cgi?id=133070
1892
1893         Reviewed by Csaba Osztrogonác.
1894
1895         * Scripts/run-jsc-stress-tests:
1896
1897 2014-12-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1898
1899         [EFL] Add subtle crypto to the build system
1900         https://bugs.webkit.org/show_bug.cgi?id=138612
1901
1902         Reviewed by Csaba Osztrogonác.
1903
1904         * Scripts/webkitperl/FeatureList.pm:
1905
1906 2014-12-02  Joanmarie Diggs  <jdiggs@igalia.com>
1907
1908         AX: [ATK] Table captions and table rows are missing from the accessible hierarchy
1909         https://bugs.webkit.org/show_bug.cgi?id=139005
1910
1911         Reviewed by Chris Fleizach.
1912
1913         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1914         Add mapping for ATK_ROLE_CAPTION to roleToString
1915
1916 2014-12-02  Alexey Proskuryakov  <ap@apple.com>
1917
1918         http/tests/appcache/main-resource-fallback-for-network-error-crash.html can break subsequent tests
1919         https://bugs.webkit.org/show_bug.cgi?id=139149
1920
1921         Reviewed by Anders Carlsson.
1922
1923         WebKit2 already cleared application caches between runs (although it wasn't entirely
1924         effective without WebCore changes in this patch).
1925
1926         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Clear applicaiton caches between runs.
1927
1928         * DumpRenderTree/win/DumpRenderTree.cpp: (runTest): Ditto (unfortunately, this
1929         function is not implemented on Windows, see below).
1930
1931         * DumpRenderTree/win/TestRunnerWin.cpp: (TestRunner::clearAllApplicationCaches):
1932         Ameded a FIXME.
1933
1934 2014-12-02  Gavin Barraclough  <barraclough@apple.com>
1935
1936         Generalize PageActivityAssertionToken
1937         https://bugs.webkit.org/show_bug.cgi?id=139106
1938
1939         Reviewed by Sam Weinig.
1940
1941         Add an API test for WTF::RefCounter.
1942
1943         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1944         * TestWebKitAPI/Tests/WTF/RefCounter.cpp: Added.
1945         (TestWebKitAPI::TEST):
1946             - added RefCounter test.
1947
1948 2014-12-02  Alexey Proskuryakov  <ap@apple.com>
1949
1950         [Mac, iOS] Crash log application information contains latest main frame URL instead of test URL
1951         https://bugs.webkit.org/show_bug.cgi?id=139174
1952
1953         Reviewed by Simon Fraser.
1954
1955         * DumpRenderTree/TestRunner.cpp:
1956         * DumpRenderTree/TestRunner.h:
1957         Renamed testPathOrURL to testURL, because this variable always contains a URL.
1958
1959         * DumpRenderTree/mac/DumpRenderTree.mm:
1960         (sizeWebViewForCurrentTest): Updated for testPathOrURL renaming.
1961         (testPathFromURL): Moved from FrameLoadDelegate.mm.
1962         (runTest): Set crash reporter information here, as we know the exact test URL.
1963
1964         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1965         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]): Don't set crash
1966         reporter information here.
1967
1968         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1969         * DumpRenderTree/mac/TestRunnerMac.mm:
1970         Updated for testPathOrURL renaming.
1971
1972         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1973         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame): WebProcess doesn't know
1974         test URL until load starts, so save it into TestRunner now. A new TestRunner object
1975         is created for each test.
1976
1977         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1978         (WTR::TestRunner::testURL):
1979         (WTR::TestRunner::setTestURL):
1980         Make TestRunner know the test name. For now, it's good enough to have it once load
1981         starts, but if we ever need it earlier, we can send it with BeginTest message.
1982
1983         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
1984         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
1985         Use test URL, not currently loading URL for CrashReporter.
1986
1987         * WebKitTestRunner/cocoa/CrashReporterInfo.mm:
1988         (WTR::setCrashReportApplicationSpecificInformationToURL): Added a space after colon
1989         (WebKit1 already had it right).
1990
1991         * DumpRenderTree/win/DumpRenderTree.cpp:
1992         (sizeWebViewForCurrentTest):
1993         (runTest):
1994         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1995         (ResourceLoadDelegate::willSendRequest):
1996         Changed Windows DumpRenderTree to also use URL in TestRunner.
1997
1998 2014-12-02  Daniel Bates  <dabates@apple.com>
1999
2000         [iOS] run-webkit-tests records most DumpRenderTree.app crashes as time-outs
2001         https://bugs.webkit.org/show_bug.cgi?id=139143
2002
2003         Reviewed by David Kilzer.
2004
2005         Similar to the Windows-specific fix in <https://bugs.webkit.org/show_bug.cgi?id=37859>,
2006         teach DumpRenderTree for iOS to write "#CRASHED" to the standard error stream when it
2007         crashes. Run-webkit-tests will record as crashing the test associated with the
2008         DumpRenderTree instance that wrote that string.
2009
2010         Currently almost all of the DumpRenderTree.app crashes are recorded by run-
2011         webkit-tests as a time-out because ReportCrash(8) delays delivery of the
2012         process exit notification for DumpRenderTree.app to LayoutTestRelay, which
2013         launched DumpRenderTree.app, past the time-out time limit. Notice LayoutTestRelay
2014         was launched by run-webkit-tests. So, run-webkit-tests kills LayoutTestRelay
2015         (since it exceeded the time-out time limit) before it can inform rub-webkit-tests
2016         about a crash.
2017
2018         Additionally, update the crash message format written to standard error when LayoutTestRelay
2019         detects that {WebKitTestRunner, DumpRenderTree}.app crashed so as to be similar to the
2020         crash message format used by WebKitTestRunner when it detects that the WebProcess crashed.
2021         Then run-webkit-tests will collect the crash logs for {WebKitTestRunner, DumpRenderTree}.app
2022         when they crash in their test machinery logic/UI process code.
2023
2024         * DumpRenderTree/mac/DumpRenderTree.mm:
2025         (writeCrashedMessageOnFatalError): Added.
2026         (dumpRenderTree): Register signal handler, writeCrashedMessageOnFatalError(), for signals:
2027         SIGILL, SIGFPE, SIGBUS and SIGSEGV.
2028         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2029         (-[LTRelayController didCrashWithMessage:]): Emit a crash message with a format
2030         similar to the format used by WebKitTestRunner so that run-webkit-tests will collect
2031         the crash logs for WebKitTestRunner/DumpRenderTree.app.
2032         * Scripts/webkitpy/port/driver.py:
2033         (Driver.__init__): Update comment.
2034         (Driver._check_for_driver_crash): Ditto.
2035         * Scripts/webkitpy/port/ios.py:
2036         (IOSSimulatorPort): Add class constant SUBPROCESS_CRASH_REGEX, which represents a compiled
2037         regular expression. This constant is used as an optimization to avoid compiling the same
2038         regular expression across invocations of _get_crash_log().
2039         (IOSSimulatorPort._get_crash_log): Modified to parse the WebKitTestRunner-like crash message
2040         for the subprocess name and pid. Also, moved variables crash_log, crash_logs, and now to be
2041         closer to where they are used.
2042
2043 2014-12-01  Anders Carlsson  <andersca@apple.com>
2044
2045         Remove WKBundleRemoveAllVisitedLinks
2046         https://bugs.webkit.org/show_bug.cgi?id=139163
2047
2048         Reviewed by Sam Weinig.
2049
2050         Remove the call to WKBundleRemoveAllVisitedLinks and add a FIXME instead.
2051
2052         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2053         (WTR::InjectedBundle::beginTesting):
2054         * WebKitTestRunner/TestInvocation.cpp:
2055         (WTR::TestInvocation::invoke):
2056
2057 2014-12-02  Anders Carlsson  <andersca@apple.com>
2058
2059         Fix Windows build.
2060
2061         * DumpRenderTree/win/DumpRenderTree.cpp:
2062         (setAlwaysAcceptCookies):
2063
2064 2014-12-02  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2065
2066         [EFL] Remove edbus dependency from jhbuild
2067         https://bugs.webkit.org/show_bug.cgi?id=139130
2068
2069         Reviewed by Gyuyoung Kim.
2070
2071         After http://trac.webkit.org/changeset/176555 we
2072         don't need it anymore.
2073
2074         * efl/jhbuild.modules:
2075
2076 2014-12-02  Philippe Normand  <pnormand@igalia.com>
2077
2078         [jhbuild] wrong Dependencies path
2079         https://bugs.webkit.org/show_bug.cgi?id=139176
2080
2081         Reviewed by Martin Robinson.
2082
2083         * Scripts/webkitpy/port/base.py:
2084         (Port._should_use_jhbuild):
2085
2086 2014-12-02  Philippe Normand  <pnormand@igalia.com>
2087
2088         [GStreamer] Bump internal jhbuild versions to 1.4.4
2089         https://bugs.webkit.org/show_bug.cgi?id=138866
2090
2091         Reviewed by Carlos Garcia Campos.
2092
2093         * gtk/jhbuild.modules:
2094         * gtk/patches/gst-events-arent-gstobjects.patch: Removed.
2095         * gtk/patches/gst-plugins-base-fix-build-gcc-4.9-x86.patch: Removed.
2096         * gtk/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Removed.
2097
2098 2014-12-01  Commit Queue  <commit-queue@webkit.org>
2099
2100         Unreviewed, rolling out r176566.
2101         https://bugs.webkit.org/show_bug.cgi?id=139124
2102
2103         It broke the GTK performance tests. (Requested by clopez on
2104         #webkit).
2105
2106         Reverted changeset:
2107
2108         "[GTK] Use GMainLoopSource in WebKitTestRunner"
2109         https://bugs.webkit.org/show_bug.cgi?id=138831
2110         http://trac.webkit.org/changeset/176566
2111
2112 2014-11-29  Anders Carlsson  <andersca@apple.com>
2113
2114         Crash when calling WKPageClose on the originated page from within createNewPage callback
2115         https://bugs.webkit.org/show_bug.cgi?id=139099
2116         <rdar://problem/19052564>
2117
2118         Reviewed by Sam Weinig.
2119
2120         Add a test.
2121
2122         * TestWebKitAPI/PlatformWebView.h:
2123         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2124         * TestWebKitAPI/Tests/WebKit2/CloseFromWithinCreatePage.cpp: Added.
2125         (TestWebKitAPI::runJavaScriptAlert):
2126         (TestWebKitAPI::createNewPage):
2127         (TestWebKitAPI::TEST):
2128         * TestWebKitAPI/Tests/WebKit2/close-from-within-create-page.html: Added.
2129         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2130         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2131
2132 2014-11-28  Commit Queue  <commit-queue@webkit.org>
2133
2134         Unreviewed, rolling out r176564.
2135         https://bugs.webkit.org/show_bug.cgi?id=139093
2136
2137         massive failures on release test bot (Requested by philn on
2138         #webkit).
2139
2140         Reverted changeset:
2141
2142         "[GStreamer] Bump internal jhbuild versions to 1.4.4"
2143         https://bugs.webkit.org/show_bug.cgi?id=138866
2144         http://trac.webkit.org/changeset/176564
2145
2146 2014-11-28  Carlos Garcia Campos  <cgarcia@igalia.com>
2147
2148         [GTK] Use GMainLoopSource in WebKitTestRunner
2149         https://bugs.webkit.org/show_bug.cgi?id=138831
2150
2151         Reviewed by Sergio Villar Senin.
2152
2153         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2154         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
2155         (WTR::TestRunner::platformInitialize):
2156         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
2157         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
2158         (WTR::waitToDumpWatchdogTimerCallback): Deleted.
2159         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2160         (WTR::TestController::notifyDone):
2161         (WTR::TestController::platformRunUntil):
2162         (WTR::cancelTimeout): Deleted.
2163
2164 2014-11-24  Philippe Normand  <pnormand@igalia.com>
2165
2166         [GStreamer] Bump internal jhbuild versions to 1.4.4
2167         https://bugs.webkit.org/show_bug.cgi?id=138866
2168
2169         Reviewed by Carlos Garcia Campos.
2170
2171         * gtk/jhbuild.modules:
2172         * gtk/patches/gst-events-arent-gstobjects.patch: Removed.
2173         * gtk/patches/gst-plugins-base-fix-build-gcc-4.9-x86.patch: Removed.
2174         * gtk/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Removed.
2175
2176 2014-11-28  Carlos Garcia Campos  <cgarcia@igalia.com>
2177
2178         [GTK] Use custom JavaScript instead of DBus to implement WebProcess tests
2179         https://bugs.webkit.org/show_bug.cgi?id=138834
2180
2181         Reviewed by Sergio Villar Senin.
2182
2183         It makes everyting simpler and the tests run faster too, since we
2184         don't need to spawn the private bus and wait until the DBus name
2185         is registered. The web extension registers a new JavaSCript class
2186         with a status method to run the tests, similar to the DBus
2187         method. In the UI process side, tests use webkit_web_view_run_java_script()
2188         instead of sending a DBus message.
2189
2190         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
2191         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp:
2192         (WebKitDOMNodeFilterTest::create):
2193         (WebKitDOMNodeFilterTest::testTreeWalker):
2194         (WebKitDOMNodeFilterTest::testNodeIterator):
2195         (WebKitDOMNodeFilterTest::webPageFromArgs): Deleted.
2196         (WebKitDOMNodeFilterTest::runTest): Deleted.
2197         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
2198         (WebKitDOMNodeTest::create):
2199         (WebKitDOMNodeTest::testHierarchyNavigation):
2200         (WebKitDOMNodeTest::testInsertion):
2201         (WebKitDOMNodeTest::testTagNames):
2202         (WebKitDOMNodeTest::webPageFromArgs): Deleted.
2203         (WebKitDOMNodeTest::runTest): Deleted.
2204         * TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp:
2205         (WebKitDOMXPathNSResolverTest::create):
2206         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
2207         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
2208         (WebKitDOMXPathNSResolverTest::webPageFromArgs): Deleted.
2209         (WebKitDOMXPathNSResolverTest::runTest): Deleted.
2210         * TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp:
2211         (WebKitFrameTest::create):
2212         (WebKitFrameTest::testMainFrame):
2213         (WebKitFrameTest::testURI):
2214         (WebKitFrameTest::testJavaScriptContext):
2215         (WebKitFrameTest::webPageFromArgs): Deleted.
2216         (WebKitFrameTest::runTest): Deleted.
2217         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
2218         (testWebKitDOMNodeHierarchyNavigation):
2219         (testWebKitDOMNodeInsertion):
2220         (testWebKitDOMNodeTagNames):
2221         (beforeAll):
2222         (afterAll):
2223         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNodeFilter.cpp:
2224         (runTest):
2225         (beforeAll):
2226         (afterAll):
2227         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMXPathNSResolver.cpp:
2228         (testWebKitDOMXPathNSResolverNative):
2229         (testWebKitDOMXPathNSResolverCustom):
2230         (beforeAll):
2231         (afterAll):
2232         (runTest): Deleted.
2233         * TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp:
2234         (webkitFrameTestRun):
2235         (beforeAll):
2236         (afterAll):
2237         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
2238         (testsMap):
2239         (WebProcessTest::add):
2240         (WebProcessTest::create):
2241         (runTest):
2242         (windowObjectClearedCallback):
2243         (webkit_web_extension_initialize):
2244         (methodCallCallback): Deleted.
2245         (webkit_web_extension_initialize_with_user_data): Deleted.
2246         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
2247         * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.cpp: Removed.
2248         * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.h: Removed.
2249         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2250         (WebViewTest::runWebProcessTest):
2251         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
2252
2253 2014-11-28  Csaba Osztrogonác  <ossy@webkit.org>
2254
2255         [EFL] libseccomp should pick up CC environment variable to be conform to other jhbuild modules
2256         https://bugs.webkit.org/show_bug.cgi?id=139086
2257
2258         Reviewed by Gyuyoung Kim.
2259
2260         * efl/jhbuild.modules:
2261         * efl/patches/libseccomp-pick-up-CC.patch: Added.
2262
2263 2014-11-28  Bartlomiej Gajda  <b.gajda@samsung.com>
2264
2265         [EFL] Add warning if CMake version is too old for building with ninja.
2266         https://bugs.webkit.org/show_bug.cgi?id=139055
2267
2268         Reviewed by Gyuyoung Kim.
2269
2270         CMake need to be >= 2.8.10 to build WebKit using ninja, some repos don't have
2271         that version in their repositories.
2272
2273         * efl/install-dependencies:
2274
2275 2014-11-28  Andrzej Badowski  <a.badowski@samsung.com>
2276
2277         [ATK] Allowing the use of AccessibilityUIElement::columnHeaders method for table.
2278         https://bugs.webkit.org/show_bug.cgi?id=139044
2279
2280         Reviewed by Chris Fleizach.
2281
2282         ATK method AccessibilityUIElement::columnHeaders currently focused only on the object table cell.
2283         The proposed solution will enable the use of this method for the object table.
2284         Existing test shows the result.
2285
2286         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2287         (WTR::AccessibilityUIElement::columnHeaders):
2288
2289 2014-11-27  Ryuan Choi  <ryuan.choi@navercorp.com>
2290
2291         [EFL] Remove E_Dbus dependency
2292         https://bugs.webkit.org/show_bug.cgi?id=136355
2293
2294         Reviewed by Gyuyoung Kim.
2295
2296         * MiniBrowser/efl/CMakeLists.txt: Removed E_DBUS includes.
2297
2298 2014-11-26  Akos Kiss  <akiss@inf.u-szeged.hu>
2299
2300         [EFL][GTK] Bump up FDE relocation fixing patch to version accepted to LLVM trunk.
2301         https://bugs.webkit.org/show_bug.cgi?id=139047
2302
2303         Reviewed by Carlos Garcia Campos.
2304
2305         * efl/jhbuild.modules:
2306         * efl/patches/llvm-elf-allow-fde-references-outside-the-2gb-range.patch: Added.
2307         * efl/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch: Removed.
2308         * gtk/jhbuild-optional.modules:
2309         * gtk/patches/llvm-elf-allow-fde-references-outside-the-2gb-range.patch: Added.
2310         * gtk/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch: Removed.
2311
2312 2014-11-25  Tanay C  <tanay.c@samsung.com>
2313
2314         [GTK] Minibrowser: Add support for zoom using Control Key + Mouse scroll
2315         https://bugs.webkit.org/show_bug.cgi?id=138090
2316
2317         Reviewed by Carlos Garcia Campos.
2318
2319         * MiniBrowser/gtk/BrowserWindow.c: Implementing zoom using Cntrl + Mouse scroll
2320         (browserWindowZoomIn): Added.
2321         (browserWindowZoomOut): Added.
2322         (scrollEventCallback): Added.
2323         (zoomInCallback): Modified.
2324         (zoomOutCallback): Modified.
2325         (browserWindowConstructed): Modified.
2326
2327 2014-11-25  Csaba Osztrogonác  <ossy@webkit.org>
2328
2329         [EFL] REGRESSION(r176514): It made performance tests fail
2330         https://bugs.webkit.org/show_bug.cgi?id=139037
2331
2332         Reviewed by Gyuyoung Kim.
2333
2334         * Scripts/webkitpy/port/efl.py:
2335         (EflPort.setup_environ_for_server): Pass ACCESSIBILITY_EAIL_LIBRARY_PATH environment variable to WTR.
2336         * efl/jhbuildrc: Set ACCESSIBILITY_EAIL_LIBRARY_PATH to point to DependenciesEFL/lib/libeail.so
2337         only if ACCESSIBILITY_EAIL_LIBRARY_PATH isn't already set and DependenciesEFL/lib/libeail.so exists.
2338
2339 2014-11-24  Michael Catanzaro  <mcatanzaro@igalia.com>
2340
2341         [GTK] update-webkitgtk-libs fails to build fontconfig
2342         https://bugs.webkit.org/show_bug.cgi?id=139032
2343
2344         Reviewed by Martin Robinson.
2345
2346         On Fedora, if docbook-utils is installed but docbook-utils-pdf is not,
2347         fontconfig will try to generate documentation and fail.
2348
2349         * gtk/install-dependencies:
2350
2351 2014-11-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2352
2353         Unreviewed. Fix GTK+ make distcheck.
2354
2355         * gtk/manifest.txt: Remove deleted files.
2356
2357 2014-11-24  Krzysztof Czech  <k.czech@samsung.com>
2358
2359         [EFL] Utilize Eail library to support accessibility in EFL
2360         https://bugs.webkit.org/show_bug.cgi?id=137742
2361
2362         Reviewed by Gyuyoung Kim.
2363
2364         Eail, atk-bridge, at-spi2 are not mandatory modules for webkit-efl. They are rather optional.
2365
2366         * efl/jhbuild-optional.modules: Added.
2367         * efl/jhbuild.modules:
2368
2369 2014-11-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2370
2371         [GTK] WebKitWebView is created with the wrong web context when using webkit_web_view_new_with_related_view()
2372         https://bugs.webkit.org/show_bug.cgi?id=139023
2373
2374         Reviewed by Sergio Villar Senin.
2375
2376         Rename WebKitWebView/default-context as WebKitWebView/web-context
2377         and check we are always using the right context for new web views.
2378
2379         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2380         (testWebViewWebContext):
2381         (beforeAll):
2382         (testWebViewDefaultContext): Deleted.
2383
2384 2014-11-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2385
2386         [GTK] Add API to override the default local storage directory
2387         https://bugs.webkit.org/show_bug.cgi?id=138828
2388
2389         Reviewed by Gustavo Noronha Silva.
2390
2391         Add test to check that the local storage directory is created at
2392         the path given on construction.
2393
2394         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2395         (testWebContextConfiguration):
2396         (beforeAll):
2397         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
2398         (Test::Test):
2399         (Test::~Test): Deleted.
2400
2401 2014-11-21  Zalan Bujtas  <zalan@apple.com>
2402
2403         Simple line layout: Add "show simple line layout debug borders" setting to MiniBrowser.
2404         https://bugs.webkit.org/show_bug.cgi?id=138981
2405
2406         Reviewed by Simon Fraser.
2407
2408         * MiniBrowser/mac/SettingsController.h:
2409         * MiniBrowser/mac/SettingsController.m:
2410         (-[SettingsController _populateMenu]):
2411         (-[SettingsController validateMenuItem:]):
2412         (-[SettingsController toggleSimpleLineLayoutDebugBordersEnabled:]):
2413         (-[SettingsController simpleLineLayoutDebugBordersEnabled]):
2414         * MiniBrowser/mac/WK1BrowserWindowController.m:
2415         (-[WK1BrowserWindowController didChangeSettings]):
2416         * MiniBrowser/mac/WK2BrowserWindowController.m:
2417         (-[WK2BrowserWindowController didChangeSettings]):
2418
2419 2014-11-21  Csaba Osztrogonác  <ossy@webkit.org>
2420
2421         Remove http lock code from webkitperl
2422         https://bugs.webkit.org/show_bug.cgi?id=138959
2423
2424         Reviewed by Alexey Proskuryakov.
2425
2426         * Scripts/webkitperl/httpd.pm:
2427         (cleanUp):
2428         (extractLockNumber): Deleted.
2429         (getLockFiles): Deleted.
2430         (getNextAvailableLockNumber): Deleted.
2431         (getLockNumberForCurrentRunning): Deleted.
2432         (waitForHTTPDLock): Deleted.
2433         (scheduleHttpTesting): Deleted.
2434         (getWaitTime): Deleted.
2435
2436 2014-11-20  Hunseop Jeong  <hs85.jeong@samsung.com>
2437
2438         [EFL] The option value of fixed layout is false in MiniBrowser
2439         https://bugs.webkit.org/show_bug.cgi?id=138830
2440
2441         Reviewed by Gyuyoung Kim.
2442
2443         Changed the option value of fixed layout to EINA_TRUE in MiniBrowser.
2444
2445         * MiniBrowser/efl/main.c:
2446
2447 2014-11-20  Adrian Perez de Castro  <aperez@igalia.com>
2448
2449         [GTK] Provide convenience API in DOM bindings to post messages to user message handlers
2450         https://bugs.webkit.org/show_bug.cgi?id=138871
2451
2452         Reviewed by Carlos Garcia Campos.
2453
2454         Add a test case for the convenience API for posting user messages
2455         added to the DOM bindings.
2456
2457         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
2458         (testUserContentManagerMessageFromConvenienceDOMBindings):
2459         (beforeAll):
2460         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
2461         (documentLoadedCallback):
2462
2463 2014-11-19  Dana Burkart  <dburkart@apple.com>
2464
2465         Work around the fact that different masters may have different names for their codebases.
2466         https://bugs.webkit.org/show_bug.cgi?id=138878
2467
2468         Reviewed by Mark Rowe.
2469
2470         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2471         (parseRevisionProperty): Changed.
2472         Take a "fallback key" in addition to the primary key, so we can deal with inconsistencies in
2473         opensource / internal codebase naming convention.
2474
2475 2014-11-19  Chris Fleizach  <cfleizach@apple.com>
2476
2477         AX: Screen braille input doesn't work on forms.
2478         https://bugs.webkit.org/show_bug.cgi?id=138804
2479
2480         Unreviewed build fix.
2481
2482         * DumpRenderTree/AccessibilityUIElement.cpp:
2483         (AccessibilityUIElement::setValue):
2484
2485 2014-11-19  Chris Fleizach  <cfleizach@apple.com>
2486
2487         AX: Screen braille input doesn't work on forms.
2488         https://bugs.webkit.org/show_bug.cgi?id=138804
2489
2490         Reviewed by Mario Sanchez Prada.
2491
2492         Add a method to setValue through the AX API in DRT.
2493
2494         * DumpRenderTree/AccessibilityUIElement.cpp:
2495         (setValueCallback):
2496         (AccessibilityUIElement::getJSClass):
2497         * DumpRenderTree/AccessibilityUIElement.h:
2498         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2499         (AccessibilityUIElement::setValue):
2500         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2501         (AccessibilityUIElement::setValue):
2502
2503 2014-11-18  Csaba Osztrogonác  <ossy@webkit.org>
2504
2505         Remove the WinCairo buildbot
2506         https://bugs.webkit.org/show_bug.cgi?id=138805
2507
2508         Reviewed by Alex Christensen.
2509
2510         * BuildSlaveSupport/build.webkit.org-config/config.json:
2511         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2512         (appendCustomBuildFlags):
2513         * BuildSlaveSupport/test-result-archive:
2514         (archiveTestResults):
2515
2516 2014-11-18  Daniel Bates  <dabates@apple.com>
2517
2518         [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
2519         SPI are not available in public SDK
2520         https://bugs.webkit.org/show_bug.cgi?id=138802
2521
2522         Reviewed by David Kilzer.
2523
2524         Include header MachVMSPI.h instead of including the private header mach/mach_vm.h.
2525
2526         * DumpRenderTree/mac/CheckedMalloc.cpp:
2527
2528 2014-11-18  Carlos Garcia Campos  <cgarcia@igalia.com>
2529
2530         Unreviewed. Fix after /webkit2/WebKitWebView/default-context r176256.
2531
2532         Forgot to fix this test before landing.
2533
2534         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2535         (testWebViewDefaultContext):
2536
2537 2014-11-18  Carlos Garcia Campos  <cgarcia@igalia.com>
2538
2539         [GTK] Add API to create a WebKitWebContext
2540         https://bugs.webkit.org/show_bug.cgi?id=138826
2541
2542         Reviewed by Gustavo Noronha Silva.
2543
2544         Use a different WebKitWebContext for every test to ensure test
2545         cases are independent to each other. Tests using DBus to
2546         communicate with the injected bundle extension now use a unique
2547         name for the well known DBus name.
2548
2549         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
2550         (beforeAll): Remove comment about the order of the tests and
2551         move the success test before the failed one now that tests don't
2552         depend on each others.
2553         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
2554         (beforeAll): Remove call to set the web extensions directory,
2555         since this is now done for all test in the Test constructor.
2556         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
2557         (beforeAll): Do not create a temporary directory, a temporary data
2558         directory is now created for all tests.
2559         (afterAll):
2560         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
2561         (testWebKitDOMNodeHierarchyNavigation): Pass the web extension ID
2562         to the web process test runner.
2563         (testWebKitDOMNodeInsertion): Ditto.
2564         (testWebKitDOMNodeTagNames): Ditto.
2565         (beforeAll): Remove call to set the web extensions directory.
2566         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNodeFilter.cpp:
2567         (runTest): Pass the web extension ID to the web process test runner.
2568         (beforeAll): Remove call to set the web extensions directory.
2569         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMXPathNSResolver.cpp:
2570         (runTest): Pass the web extension ID to the web process test runner.
2571         (beforeAll): Remove call to set the web extensions directory.
2572         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
2573         (createFileAtDestination): Use Test::dataDirectory() as base dir
2574         for temporary files.
2575         (beforeAll): Do not create a temporary directory.
2576         (afterAll):
2577         * TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp:
2578         (webkitFrameTestRun): Pass the web extension ID to the web process
2579         test runner.
2580         (beforeAll): Remove call to set the web extensions directory.
2581         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
2582         (beforeAll): Remove call to set the web extensions directory.
2583         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
2584         (testProcessPerWebView): Use local member instead of global variable.
2585         (testMultiprocessWebViewCreateReadyClose): Ditto.
2586         (beforeAll): Do not connect to initialize-web-extensions, Test now
2587         connects to the signal for all tests and calls a virtual method
2588         that test can override.
2589         (afterAll):
2590         (initializeWebExtensions): Deleted.
2591         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
2592         (testPrintOperationPrint): Use Test::dataDirectory() as base dir
2593         for temporary files.
2594         (beforeAll): Do not create a temporary directory.
2595         (afterAll):
2596         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2597         (beforeAll): Remove call to set the web extensions directory.
2598         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
2599         (beforeAll): Remove comment about the tests order.
2600         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
2601         (testWebExtensionGetTitle): Build the DBus service name using the
2602         web extension ID.
2603         (testDocumentLoadedSignal): Ditto.
2604         (testWebKitWebViewProcessCrashed): Ditto.
2605         (testWebExtensionIsolatedWorld): Ditto.
2606         (beforeAll): Remove initialization-user-data test, since now all
2607         tests are passing user data to the web extension.
2608         (testWebExtensionInitializationUserData): Deleted.
2609         (initializeWebExtensions): Deleted.
2610         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
2611         (testSetDirectory): Use the web context member inherited from Test.
2612         (testClearDatabase): Ditto.
2613         (testGetFaviconURI): Ditto.
2614         (beforeAll): Do not create a temporary directory.
2615         (afterAll):
2616         (webkitFaviconDatabaseFinalizedCallback): Deleted.
2617         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
2618         (UserContentManagerTest::UserContentManagerTest):
2619         (beforeAll): Remove call to set the web extensions directory.
2620         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2621         (testWebContextDefault): Check also that a newly create web
2622         context is not the default web context.
2623         (testWebContextSpellChecker): Use the web context member inherited
2624         from Test.
2625         (testWebContextLanguages): Ditto.
2626         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
2627         (methodCallCallback): Remove GetInitializationUserData method.
2628         (webkit_web_extension_initialize_with_user_data): Always create
2629         the DBus name using the user data provided.
2630         (makeBusName): Deleted.
2631         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
2632         (webkit_web_extension_initialize_with_user_data): Create the DBus
2633         name using the user data provided.
2634         (webkit_web_extension_initialize): Deleted.
2635         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.cpp:
2636         (Test::dataDirectory): Return the temporary data directory.
2637         (removeNonEmptyDirectory): Also remove directories recursively.
2638         (main): Remove the disk cache directory initialization, since this
2639         is now done in the Test constructor.
2640         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
2641         (Test::initializeWebExtensionsCallback): Call the virtual method
2642         initializeWebExtensions()
2643         (Test::Test): Create a new WebKitWebContext and initialize it.
2644         (Test::~Test): Disconnect initialize-web-extensions signal.
2645         (Test::initializeWebExtensions): Set the web extensions directory
2646         and user data.
2647         * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.cpp:
2648         (WebProcessTestRunner::~WebProcessTestRunner): Use nullptr.
2649         (WebProcessTestRunner::runTest): Build the DBus proxy using a
2650         unique name created with the Test web extension ID.
2651         (WebProcessTestRunner::proxy): Deleted.
2652         * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.h:
2653         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2654         (WebViewTest::WebViewTest): Create the web view with the Test web
2655         context.
2656         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h: Add optional user
2657         content manager parameter to the constructor.
2658
2659 2014-11-18  ChangSeok Oh  <changseok.oh@collabora.com>
2660
2661         [GTK] Mesa build fails over llvm-3.5
2662         https://bugs.webkit.org/show_bug.cgi?id=138825
2663
2664         Reviewed by Gustavo Noronha Silva.
2665
2666         OwningPtr.h have been removed in llvm-3.5. Instread we should use std::unique_ptr for mesa build.
2667
2668         * gtk/jhbuild.modules:
2669         * gtk/patches/mesa-gallivm-Fix-build-after-LLVM-commit-211259.patch: Added.
2670
2671 2014-11-17  Daniel Bates  <dabates@apple.com>
2672
2673         Unreviewed, rolling out r176232.
2674
2675         Broke the Mac build. Will investigate offline.
2676
2677         Reverted changeset:
2678
2679         "[iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions,
2680         MobileGestalt"
2681         https://bugs.webkit.org/show_bug.cgi?id=138802
2682         http://trac.webkit.org/changeset/176232
2683
2684 2014-11-17  Daniel Bates  <dabates@apple.com>
2685
2686         [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
2687         SPI are not available in public SDK
2688         https://bugs.webkit.org/show_bug.cgi?id=138802
2689
2690         Reviewed by David Kilzer.
2691
2692         Include header MachVMSPI.h instead of including the private header mach/mach_vm.h.
2693
2694         * DumpRenderTree/mac/CheckedMalloc.cpp:
2695
2696 2014-11-17  Jake Nielsen  <jacob_nielsen@apple.com>
2697
2698         Having 30+ flaky failures breaks EWS
2699         https://bugs.webkit.org/show_bug.cgi?id=138743
2700
2701         Reviewed by Alexey Proskuryakov.
2702
2703         Adds tests to ensure that the problem has been solved.
2704         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2705         (test_first_failure_limit):
2706         (test_first_failure_limit_with_some_tree_redness):
2707         (test_second_failure_limit):
2708         (test_tree_failure_limit_with_patch_that_potentially_fixes_some_redness):
2709         (test_first_and_second_failure_limit):
2710         (test_first_and_clean_failure_limit):
2711         (test_first_second_and_clean_failure_limit):
2712         (test_very_red_tree_retry): Deleted.
2713         Really this was renamed to test_first_second_and_clean_failure_limit.
2714         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2715         Makes the appropriate changes to PatchAnalysisTask to make sure that
2716         even when the first test run hits the failure limit, it will still try
2717         a second run.
2718         (PatchAnalysisTask._results_failed_different_tests):
2719         (PatchAnalysisTask._test_patch):
2720         (PatchAnalysisTask._continue_testing_patch_that_exceeded_failure_limit_on_first_or_second_try): Deleted.
2721
2722 2014-11-17  Ting-Wei Lan  <lantw44@gmail.com>
2723
2724         [GTK] Add library search paths from LDFLAGS before pkg-config --libs
2725         https://bugs.webkit.org/show_bug.cgi?id=136018
2726
2727         Reviewed by Carlos Garcia Campos.
2728
2729         It is possible that the order of -L arguments in the output of
2730         pkg-config is wrong, which causes the linker to find the wrong
2731         version (usually older version) of libraries when running
2732         gtkdoc-scangobj.
2733
2734         * gtk/gtkdoc.py:
2735         (GTKDoc._run_gtkdoc_scangobj):
2736
2737 2014-11-17  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2738
2739         Bump EFL version to 1.12.0
2740         https://bugs.webkit.org/show_bug.cgi?id=138733
2741
2742         Reviewed by Gyuyoung Kim.
2743
2744         * efl/jhbuild.modules:
2745
2746 2014-11-16  Joanmarie Diggs  <jdiggs@igalia.com>
2747
2748         AX: [ATK] Expose the blockquote element using ATK_ROLE_BLOCK_QUOTE
2749         https://bugs.webkit.org/show_bug.cgi?id=138771
2750
2751         Reviewed by Chris Fleizach.
2752
2753         Add mapping for ATK_ROLE_BLOCK_QUOTE in roleToString()
2754
2755         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2756
2757 2014-11-15  Joanmarie Diggs  <jdiggs@igalia.com>
2758
2759         AX: [ATK] Video and audio elements should be exposed using ATK's video and audio roles.
2760         https://bugs.webkit.org/show_bug.cgi?id=138767
2761
2762         Reviewed by Chris Fleizach.
2763
2764         Add mappings for ATK_ROLE_AUDIO and ATK_ROLE_VIDEO to roleToString().
2765
2766         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2767
2768 2014-11-14  Alexey Proskuryakov  <ap@apple.com>
2769
2770         Add shortcut macros to Mac TestExpectations
2771         https://bugs.webkit.org/show_bug.cgi?id=138729
2772
2773         Reviewed by Simon Fraser.
2774
2775         * Scripts/webkitpy/port/mac.py: (MacPort.configuration_specifier_macros):
2776         Add version macros for current OS versions.
2777
2778 2014-11-13  Alexey Proskuryakov  <ap@apple.com>
2779
2780         https://bugs.webkit.org/show_bug.cgi?id=138628
2781         A patch that doesn't apply is stuck in commit queue
2782
2783         Rubber-stamped by David Kilzer.
2784
2785         This also hopefully fixes other issues:
2786         - a patch that has cq+ flag set by a non-committer kills commit queue;
2787         - EWS never reports failing tests, and keeps spinning instead.
2788
2789         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2790         (Bugzilla.set_flag_on_attachment):
2791         (Bugzilla.obsolete_attachment):
2792         Apply the fix from r174797 to more places.
2793
2794 2014-11-13  Dan Bernstein  <mitz@apple.com>
2795
2796         Policy client not called for navigations through the page cache
2797         https://bugs.webkit.org/show_bug.cgi?id=138703
2798
2799         Reviewed by Alexey Proskuryakov.
2800
2801         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
2802         (-[DecidePolicyForPageCacheNavigationDelegate webView:didFinishNavigation:]):
2803         (-[DecidePolicyForPageCacheNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2804
2805 2014-11-13  Joanmarie Diggs  <jdiggs@igalia.com>
2806
2807         AX: [ATK] Do not return ATK_ROLE_UNKNOWN for null or otherwise invalid accessible objects
2808         https://bugs.webkit.org/show_bug.cgi?id=137867
2809
2810         Reviewed by Chris Fleizach.
2811
2812         Add ATK_ROLE_INVALID to roleToString. Remove the null AtkRole check in
2813         AccessibilityUIElement::role: ATK_ROLE_INVALID = 0, and we need to be
2814         able to test for the presence of ATK_ROLE_INVALID.
2815
2816         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2817         (WTR::AccessibilityUIElement::role):
2818
2819 2014-11-13  Juergen Ributzka  <juergen@apple.com>
2820
2821         Update the "combineModules" script to handel more LLVM metadata.
2822         https://bugs.webkit.org/show_bug.cgi?id=138514
2823
2824         Reviewed by Filip Pizlo.
2825
2826         * ReducedFTL/combineModules.rb:
2827
2828 2014-11-13  Myles C. Maxfield  <mmaxfield@apple.com>
2829
2830         Allow constructing a base PassRef with a derived Ref
2831         https://bugs.webkit.org/show_bug.cgi?id=138701
2832
2833         Reviewed by Andreas Kling
2834
2835         * TestWebKitAPI/Tests/WTF/Ref.cpp:
2836         (TestWebKitAPI::passWithPassRef):
2837         (TestWebKitAPI::passWithPassRefPtr):
2838         (TestWebKitAPI::TEST):
2839
2840 2014-11-05  Ada Chan  <adachan@apple.com>
2841
2842         Implement new plug-in API for muting plug-ins
2843         https://bugs.webkit.org/show_bug.cgi?id=138105
2844
2845         Reviewed by Anders Carlsson.
2846
2847         Add a new plug-in test for the mute API.
2848
2849         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2850         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SetMuted.cpp: Added.
2851         (SetMuted::SetMuted):
2852         (SetMuted::isMuted):
2853         (SetMuted::cachedIsMuted):
2854         (SetMuted::ScriptableObject::hasProperty):
2855         (SetMuted::ScriptableObject::getProperty):
2856         (SetMuted::ScriptableObject::pluginTest):
2857         (SetMuted::NPP_New):
2858         (SetMuted::NPP_GetValue):
2859         (SetMuted::NPP_SetValue):
2860
2861 2014-11-12  Philippe Normand  <pnormand@igalia.com>
2862
2863         Unreviewed, GTK gardening.
2864
2865         * Scripts/run-gtk-tests:
2866         (TestRunner): Skip the UserMediaBasic test because it depends on
2867         constraints validation which is going to be fixed in bug #136449.
2868
2869 2014-11-12  Carlos Garcia Campos  <cgarcia@igalia.com>
2870
2871         [GTK] Expose user script messages to GObject DOM bindings
2872         https://bugs.webkit.org/show_bug.cgi?id=138411
2873
2874         Reviewed by Philippe Normand.
2875
2876         Add a test case to check that user script messages sent using the
2877         DOM bindings API are also received in the UI process.
2878
2879         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
2880         (UserScriptMessageTest::waitUntilMessageReceived):
2881         (UserScriptMessageTest::postMessageAndWaitUntilReceived):
2882         (testUserContentManagerScriptMessageFromDOMBindings):
2883         (beforeAll):
2884         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
2885         (documentLoadedCallback):
2886
2887 2014-11-12  Carlos Garcia Campos  <cgarcia@igalia.com>
2888
2889         Unreviewed. Fix GTK+ clean build after r175930.
2890
2891         Partial rollout of r175930 to not build the new unit test that
2892         broke clean builds in GTK+ port.
2893
2894         * TestWebKitAPI/PlatformGTK.cmake:
2895
2896 2014-09-01  Philippe Normand  <pnormand@igalia.com>
2897
2898         [WK2] UserMediaClient support
2899         https://bugs.webkit.org/show_bug.cgi?id=123158
2900
2901         Reviewed by Benjamin Poulain.
2902
2903         Simple API test for the UserMedia permission request API. The
2904         required test infrastructure is also added, inspired by the
2905         Geolocation infrastructure.
2906
2907         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: New API test for UserMedia
2908         Permission request.
2909         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp: Added.
2910         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack):
2911         (TestWebKitAPI::TEST):
2912         * TestWebKitAPI/Tests/WebKit2/getUserMedia.html: Added.
2913         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: new
2914         helper method to set the permission request result without user interaction.
2915         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: Ditto.
2916         (WTR::InjectedBundle::setUserMediaPermission):
2917         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: Ditto.
2918         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Ditto.
2919         (WTR::TestRunner::setUserMediaPermission):
2920         * WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto.
2921         * WebKitTestRunner/TestController.cpp:
2922         (WTR::decidePolicyForUserMediaPermissionRequest): Permission
2923         request handler.
2924         (WTR::TestController::createOtherPage): Enable the new UserMedia
2925         permission request handler.
2926         (WTR::TestController::createWebViewWithOptions): Ditto.
2927         (WTR::TestController::resetPreferencesToConsistentValues): Enable
2928         MediaStream support, this is needed for getUserMedia.
2929         (WTR::TestController::resetStateToConsistentValues): clear
2930         UserMedia permissions list and flags.
2931         (WTR::TestController::setUserMediaPermission): Set permission
2932         request result and distpatch it.
2933         (WTR::TestController::handleUserMediaPermissionRequest): Save
2934         request and dispatch it.
2935         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible):
2936         Dispatch cached permission requests.
2937         * WebKitTestRunner/TestController.h:
2938         * WebKitTestRunner/TestInvocation.cpp:
2939         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2940
2941 2014-11-11  David Kilzer  <ddkilzer@apple.com>
2942
2943         webkit-patch --suggest-reviewers is broken with newer versions of git
2944         <http://webkit.org/b/138627>
2945
2946         Reviewed by Michael Saboff with feedback from Daniel Bates.
2947
2948         * Scripts/webkitpy/common/checkout/scm/git.py:
2949         (Git._changes_files_for_commit): Strip blank lines instead of
2950         assuming there is always a blank line at the beginning of the
2951         list.
2952
2953 2014-11-11  Alexey Proskuryakov  <ap@apple.com>
2954
2955         DRT and WKTR touch disk cache
2956         https://bugs.webkit.org/show_bug.cgi?id=138622
2957
2958         Reviewed by Geoffrey Garen.
2959
2960         * DumpRenderTree/mac/DumpRenderTree.mm: (prepareConsistentTestingEnvironment):
2961         Set a shared cache before calling -_switchNetworkLoaderToNewTestingSession, not after,
2962         because this function uses the shared cache.
2963
2964         * WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::platformInitializeContext):
2965         Create an empty shared cache to prevent a default one from being created on disk.
2966
2967 2014-10-07  Sergio Villar Senin  <svillar@igalia.com>
2968
2969         [CSS Grid Layout] Limit the size of explicit/implicit grid
2970         https://bugs.webkit.org/show_bug.cgi?id=136217
2971
2972         Reviewed by Andreas Kling.
2973
2974         Added a new unit test for the CSS parser. Right now it only checks
2975         that we properly clamp the maximum number of tracks on a grid to a
2976         maximum of 1 million.
2977
2978         * TestWebKitAPI/CMakeLists.txt:
2979         * TestWebKitAPI/PlatformEfl.cmake:
2980         * TestWebKitAPI/PlatformGTK.cmake:
2981         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2982         * TestWebKitAPI/Tests/WebCore/CSSParser.cpp: Added.
2983         (TestWebKitAPI::computeNumberOfTracks): Helper function.
2984         (TestWebKitAPI::TEST): Added a
2985         CSSPropertyParserTest.GridTrackLimits test case.
2986
2987 2014-11-11  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2988
2989         webkitpy test fix after r175867
2990         https://bugs.webkit.org/show_bug.cgi?id=138607
2991
2992         Reviewed by Philippe Normand.
2993
2994         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
2995         (GDBCrashLogGeneratorTest.test_generate_crash_log):
2996
2997 2014-11-10  Philippe Normand  <pnormand@igalia.com>
2998
2999         webkitpy: demangle C++ symbols from crash log stderr
3000         https://bugs.webkit.org/show_bug.cgi?id=138565
3001
3002         Reviewed by Alexey Proskuryakov.
3003
3004         * Scripts/webkitpy/port/linux_get_crash_log.py:
3005         (GDBCrashLogGenerator.generate_crash_log): Process stderr output
3006         with c++filt.
3007
3008 2014-11-10  Philippe Normand  <pnormand@igalia.com>
3009
3010         [GTK] fix up the GDB backtrace report tool
3011         https://bugs.webkit.org/show_bug.cgi?id=138564
3012
3013         Reviewed by Carlos Garcia Campos.
3014
3015         * Scripts/webkitpy/port/gtk.py:
3016         (GtkPort._get_crash_log): Match the process name reported by the
3017         driver with the GTK port WebProcess executable filename.
3018         * Scripts/webkitpy/port/linux_get_crash_log.py:
3019         (GDBCrashLogGenerator._get_gdb_output): Invoke gdb for the crashed
3020         program.
3021         (GDBCrashLogGenerator.generate_crash_log): Use %E in the core
3022         pattern to workaround the 16 characters size limit of %e.
3023
3024 2014-11-10  Conrad Shultz  <conrad_shultz@apple.com>
3025
3026         Unreviewed, moved myself to the list of committers.
3027
3028         * Scripts/webkitpy/common/config/contributors.json:
3029
3030 2014-11-10  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3031
3032         [EFL] Fix the test font path after r175555.
3033
3034         Reviewed by Csaba Osztrogonác.
3035
3036         * WebKitTestRunner/PlatformEfl.cmake: Dependencies -> DependenciesEFL
3037
3038 2014-11-10  Akos Kiss  <akiss@inf.u-szeged.hu>
3039
3040         Fix the exception fuzz helper to generate targets in the correct range
3041         https://bugs.webkit.org/show_bug.cgi?id=138544
3042
3043         Reviewed by Filip Pizlo.
3044
3045         Currently, the script generates exception fuzz targets in the range of
3046         0..($checkCount-1). However, target 0 is never hit, while target 1 is
3047         always outside of the outermost try block of the tests, which therefore
3048         prints unexpected output and results in false failures when fired at.
3049         Additionally, target $checkCount is never generated.
3050
3051         This patch fixes the script to generate targets in the range of
3052         2..$checkCount.
3053
3054         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
3055
3056 2014-11-09  Csaba Osztrogonác  <ossy@webkit.org>
3057
3058         make-passwords-json.py should generarate everything needed for testing
3059         https://bugs.webkit.org/show_bug.cgi?id=138503
3060
3061         Reviewed by Ryosuke Niwa.
3062
3063         * BuildSlaveSupport/build.webkit.org-config/make_passwords_json.py:
3064         Renamed from make-passwords-json.py to be able included from mastercfg_unittest.py.
3065         Additionally generate auth.json, credentials.cfg and committers.cfg too.
3066         (create_mock_slave_passwords_dict): Moved from mastercfg_unittest.py
3067         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3068         (BuildBotConfigLoader._mock_open): Use make_passwords_json.create_mock_slave_passwords_dict() to avoid duplication.
3069         (BuildBotConfigLoader._create_mock_passwords_dict): Deleted.
3070
3071 2014-11-09  Carlos Garcia Campos  <cgarcia@igalia.com>
3072
3073         [GTK] generate-gtkdoc should ignore invalid files
3074         https://bugs.webkit.org/show_bug.cgi?id=138542
3075
3076         Reviewed by Darin Adler.
3077
3078         * gtk/generate-gtkdoc:
3079         (files_to_ignore.file_should_be_ignored): Return True to ignore
3080         invalid files.
3081
3082 2014-11-08  Alexey Proskuryakov  <ap@apple.com>
3083
3084         Delete cookies between tests
3085         https://bugs.webkit.org/show_bug.cgi?id=138528
3086
3087         Reviewed by Sam Weinig.
3088
3089         * DumpRenderTree/mac/DumpRenderTree.mm:
3090         (resetWebPreferencesToConsistentValues):
3091         * WebKitTestRunner/TestController.cpp:
3092         (WTR::TestController::resetPreferencesToConsistentValues):
3093         Do it.
3094
3095         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3096         (WTR::InjectedBundle::beginTesting):
3097         Added a FIXME.
3098
3099 2014-11-08  Carlos Garcia Campos  <cgarcia@igalia.com>
3100
3101         [GTK] Run layout tests using the network process
3102         https://bugs.webkit.org/show_bug.cgi?id=138428
3103
3104         Reviewed by Martin Robinson.
3105
3106         Shared secondary process is the default in the GTK+ port, but we
3107         should run the tests using the network process to ensure
3108         everything works with the network process. In the future, the
3109         shared secondary process model might be a special case of multiple
3110         processes with 1 as maximum number of processes, but always using
3111         the network process.
3112
3113         * WebKitTestRunner/TestController.cpp:
3114         (WTR::TestController::initialize):
3115
3116 2014-11-08  Carlos Garcia Campos  <cgarcia@igalia.com>
3117
3118         [GTK] Allow to create a view with a related page in WTR
3119         https://bugs.webkit.org/show_bug.cgi?id=138501
3120
3121         Reviewed by Martin Robinson.
3122
3123         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
3124         (TestWebKitAPI::PlatformWebView::PlatformWebView): Pass nullptr as
3125         related page to WKViewCreate.
3126         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3127         (WTR::PlatformWebView::PlatformWebView): Pass the given related
3128         page to WKViewCreate.
3129
3130 2014-11-08  Carlos Garcia Campos  <cgarcia@igalia.com>
3131
3132         WTR crashes after running a test when NetworkProcess enabled
3133         https://bugs.webkit.org/show_bug.cgi?id=138500
3134
3135         Reviewed by Alexey Proskuryakov.
3136
3137         WebNotificationProvider destructor is calling
3138         WKNotificationManagerSetProvider, but m_notificationManager is
3139         null because removeNotificationManager was already called.
3140
3141         * WebKitTestRunner/WebNotificationProvider.cpp:
3142         (WTR::WebNotificationProvider::~WebNotificationProvider): Check
3143         m_notificationManager is not null before calling WKNotificationManagerSetProvider.
3144
3145 2014-11-06  Jake Nielsen  <jacob_nielsen@apple.com>
3146
3147         Remove duplicate code from PatchAnalysisTask._test_patch and fix bug
3148         regarding incorrect call to PatchAnalysisTask.report_failure
3149         https://bugs.webkit.org/show_bug.cgi?id=138229
3150
3151         Reviewed by Daniel Bates.
3152
3153         * Scripts/webkitpy/common/net/layouttestresults.py:
3154         Makes sure test_results returns a list.
3155         (LayoutTestResults.test_results):
3156         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3157         Makes unit tests also check to make sure
3158         task.results_from_patch_test_run() and
3159         task.results_from_test_run_without_patch return instances of
3160         LayoutTestResults.
3161         (CommitQueueTaskTest._run_and_expect_patch_analysis_result):
3162         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
3163         Condenses duplicate code into _should_defer_patch_or_throw, and
3164         removes the now-unused _clean_tree_results member.
3165         (PatchAnalysisTask.__init__):
3166         (PatchAnalysisTask._continue_testing_patch_that_exceeded_failure_limit_on_first_or_second_try):
3167         (PatchAnalysisTask._should_defer_patch_or_throw):
3168         (PatchAnalysisTask._test_patch):
3169         (PatchAnalysisTask.results_from_patch_test_run):
3170         (PatchAnalysisTask.results_from_test_run_without_patch): Deleted.
3171         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3172         Removes needless call to results_from_test_run_without_patch
3173         (AbstractEarlyWarningSystem._failing_tests_message):
3174         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3175         Changes order of test failure messages to be in the order that they
3176         appear.
3177         (AbstractEarlyWarningSystemTest.test_failing_tests_message):
3178         * Scripts/webkitpy/tool/commands/queues.py:
3179         Removes needless call to results_from_test_run_without_patch.
3180         (CommitQueue._failing_tests_message):
3181         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3182         (MockCommitQueueTask.results_from_test_run_without_patch): Deleted.
3183
3184 2014-11-06  Ryuan Choi  <ryuan.choi@navercorp.com>
3185
3186         Unreviewed. Reorder my e-mail addresses in contributors.json
3187
3188         * Scripts/webkitpy/common/config/contributors.json:
3189
3190 2014-11-06  Matthew Hanson  <matthew_hanson@apple.com>
3191
3192         Remove code that prepends a leading 'r' to the first argument of _run_git_svn_find_rev
3193         https://bugs.webkit.org/show_bug.cgi?id=138475
3194
3195         Reviewed by Ryosuke Niwa.
3196
3197         The change in https://trac.webkit.org/175603 introduced broke compatibility with svn_revision_from_git_commit.
3198         This patch reverts the part of that change that broke compatibility. In addition, this patch adds a comment to
3199         explain that SVN revisions require a leading 'r', moves an existing comment to a more appropriate location and
3200         renames the positional argument to better reflect that it can represent either an SVN revision or a Git tree-ish.
3201
3202         * Scripts/webkitpy/common/checkout/scm/git.py:
3203         (Git._run_git_svn_find_rev):
3204         Add comment mentioning that svn_revisions need to begin with 'r'.
3205         Move comment (explaining that git svn find-rev exits with code 0 when no match is found) to a more appropriate location.
3206         Rename the argument 'revision' to 'revision_or_treeish' to reflect the dual form that argument can take.
3207         Remove code that coerced the revision/treeish into a string and prepended an 'r'.
3208
3209 2014-11-06  Carlos Garcia Campos  <cgarcia@igalia.com>
3210
3211         [GTK] Add context menu API to Web Process Extensions
3212         https://bugs.webkit.org/show_bug.cgi?id=138311
3213
3214         Reviewed by Gustavo Noronha Silva.
3215
3216         Add tests cases for WebKitWebPage::context-menu signal.
3217
3218         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
3219         (testContextMenuWebExtensionMenu):
3220         (testContextMenuWebExtensionNode):
3221         (beforeAll):
3222         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
3223         (serializeContextMenu):
3224         (serializeNode):
3225         (contextMenuCallback):
3226         (pageCreatedCallback):
3227
3228 2014-11-06  Commit Queue  <commit-queue@webkit.org>
3229
3230         Unreviewed, rolling out r175690.
3231         https://bugs.webkit.org/show_bug.cgi?id=138460
3232
3233         We are not ready to run layout tests using the network process
3234         yet (Requested by KaL on #webkit).
3235
3236         Reverted changeset:
3237
3238         "[GTK] Run layout tests using the network process"
3239         https://bugs.webkit.org/show_bug.cgi?id=138428
3240         http://trac.webkit.org/changeset/175690
3241
3242 2014-11-06  Carlos Garcia Campos  <cgarcia@igalia.com>
3243
3244         [GTK] Run layout tests using the network process
3245         https://bugs.webkit.org/show_bug.cgi?id=138428
3246
3247         Reviewed by Martin Robinson.
3248
3249         Shared secondary process is the default in the GTK+ port, but we
3250         should run the tests using the network process to ensure
3251         everything works with the network process. In the future, the
3252         shared secondary process model might be a special case of multiple
3253         processes with 1 as maximum number of processes, but always using
3254         the network process.
3255
3256         * WebKitTestRunner/TestController.cpp:
3257         (WTR::TestController::initialize):
3258
3259 2014-11-05  Dan Bernstein  <mitz@apple.com>
3260
3261         Remove the unused deletion UI feature
3262         https://bugs.webkit.org/show_bug.cgi?id=138442
3263
3264         Rubber-stamped by Alexey Proskuryakov.
3265
3266         * DumpRenderTree/mac/EditingDelegate.mm:
3267         (-[EditingDelegate webView:shouldShowDeleteInterfaceForElement:]): Deleted implementation of
3268         delegate method that’s been removed.
3269
3270 2014-11-05  Alexey Proskuryakov  <ap@apple.com>
3271
3272         fast/dom/remove-body-during-body-replacement2.html fails on WK2
3273         https://bugs.webkit.org/show_bug.cgi?id=138334
3274
3275         Reviewed by Anders Carlsson.
3276
3277         Reset focus to main frame between tests. DumpRenderTree does this via -makeFirstResponder
3278         calls, which works because each frame is an NSView in WK1. WK2 makes equivalent
3279         -makeFirstResponder calls, which may or may not be needed for other reasons, but
3280         it also needs to reset internal focus explicitly.
3281
3282         It's not clear if this is the right long-term fix or a workaround for a WebKit bug.
3283         WebKit behavior appears wrong, but it matches Firefox.
3284
3285         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3286         (WTR::InjectedBundlePage::resetAfterTest):
3287
3288 2014-11-05  Carlos Garcia Campos  <cgarcia@igalia.com>
3289
3290         [GTK] Add WebKitWebResource::failed-with-tls-errors signal
3291         https://bugs.webkit.org/show_bug.cgi?id=137862
3292
3293         Reviewed by Gustavo Noronha Silva.
3294
3295         Add a test case to check that WebKitWebResource::failed-with-tls-errors
3296         is emitted when a subresource load fails due to TLS errors.
3297
3298         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
3299         (TLSSubresourceTest::resourceLoadStartedCallback):
3300         (TLSSubresourceTest::TLSSubresourceTest):
3301         (TLSSubresourceTest::subresourceFailedCallback):
3302         (TLSSubresourceTest::subresourceFailedWithTLSErrorsCallback):
3303         (TLSSubresourceTest::subresourceLoadStarted):
3304         (TLSSubresourceTest::subresourceFailedWithTLSErrors):
3305         (TLSSubresourceTest::waitUntilSubresourceLoadFail):
3306         (testSubresourceLoadFailedWithTLSErrors):
3307         (httpsServerCallback):
3308         (httpServerCallback):
3309         (beforeAll):
3310
3311 2014-11-05  Alexey Proskuryakov  <ap@apple.com>
3312
3313         Build fix for some compiler versions.
3314
3315         * TestWebKitAPI/Tests/mac/TypingStyleCrash.mm: (TestWebKitAPI::TEST): Compiler was
3316         unhappy because this is a getter, and these shouldn't have side effects.
3317
3318 2014-11-04  Matthew Hanson  <matthew_hanson@apple.com>
3319
3320         Add a method for performing cherrypick-merges.
3321         https://bugs.webkit.org/show_bug.cgi?id=138375
3322
3323         Reviewed by Ryosuke Niwa.
3324
3325         Adds support for cherrypick-merges.
3326
3327         * Scripts/webkitpy/common/checkout/scm/git.py:
3328         (Git.cherrypick_merge): Added.
3329
3330 2014-11-04  Matthew Hanson  <matthew_hanson@apple.com>
3331
3332         Add a way to ascertain the SVN URL associated with a Git branch.
3333         https://bugs.webkit.org/show_bug.cgi?id=138374
3334
3335         Reviewed by Ryosuke Niwa.
3336
3337         The svn_url method returns the SVN URL associated with the current Git branch.
3338
3339         * Scripts/webkitpy/common/checkout/scm/git.py:
3340         (Git.svn_url): Added.
3341
3342 2014-11-04  Matthew Hanson  <matthew_hanson@apple.com>
3343
3344         Add the ability to search for modifications that are staged for commit.
3345         https://bugs.webkit.org/show_bug.cgi?id=138373
3346
3347         Reviewed by Ryosuke Niwa and Daniel Bates.
3348
3349         This makes is easy to do identify files that require merge post-processing,
3350         in addition to stand-alone utility.
3351
3352         * Scripts/webkitpy/common/checkout/scm/git.py:
3353         (Git.modifications_staged_for_commit): Added.
3354
3355 2014-11-04  Matthew Hanson  <matthew_hanson@apple.com>
3356
3357         Add a branch keyword argument to _run_git_svn_find_rev.
3358         https://bugs.webkit.org/show_bug.cgi?id=138372
3359
3360         Reviewed by Ryosuke Niwa.
3361
3362         The addition of this keyword argument allows clients to determine the Git hash
3363         of commits made on an SVN branch, provided that branch has been fetched locally.
3364
3365         * Scripts/webkitpy/common/checkout/scm/git.py:
3366         (Git._run_git_svn_find_rev):
3367         Add a branch keyword argument that is added to the end of the command, if present.
3368
3369 2014-11-04  Chris Dumez  <cdumez@apple.com>
3370
3371         Add ptr() method to Ref class
3372         https://bugs.webkit.org/show_bug.cgi?id=138361
3373
3374         Reviewed by Darin Adler.
3375
3376         Use the new Ref::ptr() method.
3377
3378         * TestWebKitAPI/Tests/WTF/Ref.cpp:
3379         (TestWebKitAPI::TEST):
3380
3381 2014-11-04  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
3382
3383         [jhbuild] Make it possible to build GTK/EFL in same repository
3384         https://bugs.webkit.org/show_bug.cgi?id=137448
3385
3386         Reviewed by Martin Robinson.
3387
3388         * Scripts/webkitdirs.pm:
3389         (getJhbuildPath):
3390         * WebKitTestRunner/InjectedBundle/efl/FontManagement.cpp:
3391         (getPlatformFontsPath):
3392         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
3393         (WTR::getFontsPath):
3394         * jhbuild/jhbuild-wrapper:
3395         (determine_platform):
3396         (install_jhbuild):
3397         * jhbuild/jhbuildrc_common.py:
3398         (init):
3399
3400 2014-11-04  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
3401
3402         [EFL] Bump LLVM to version 3.5.0
3403         https://bugs.webkit.org/show_bug.cgi?id=138312
3404
3405         Reviewed by Csaba Osztrogonác.
3406
3407         * efl/jhbuild.modules:
3408         * efl/patches/llvm-elf-add-stackmaps.patch: Added.
3409         * efl/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch: Added.
3410
3411 2014-11-03  Simon Fraser  <simon.fraser@apple.com>
3412
3413         Add page overlays that show regions with mouseWheel event handlers, and the non-fast-scrollable region, and code to toggle them in MiniBrowser WK2
3414         https://bugs.webkit.org/show_bug.cgi?id=138257
3415
3416         Reviewed by Tim Horton.
3417         
3418         Add a "Debug Overlays" submenu item under "WebKit2-only Settings" which allows
3419         the user to toggle region page overlays on and off. Two overlays are available,
3420         for the non-fast scrollable region, and the region of element with wheel
3421         event handlers.
3422
3423         * MiniBrowser/mac/SettingsController.h:
3424         * MiniBrowser/mac/SettingsController.m:
3425         (-[SettingsController _populateMenu]):
3426         (-[SettingsController validateMenuItem:]):
3427         (-[SettingsController nonFastScrollableRegionOverlayVisible]):
3428         (-[SettingsController wheelEventHandlerRegionOverlayVisible]):
3429         (-[SettingsController preferenceKeyForRegionOverlayTag:]):
3430         (-[SettingsController toggleDebugOverlay:]):
3431         (-[SettingsController debugOverlayVisible:]):
3432         * MiniBrowser/mac/WK2BrowserWindowController.m:
3433         (-[WK2BrowserWindowController didChangeSettings]):
3434
3435 2014-11-03  Alexey Proskuryakov  <ap@apple.com>
3436
3437         REGRESSION (Subpixel layout): Bubbles don't fit in Bugzilla review page
3438         https://bugs.webkit.org/show_bug.cgi?id=138323
3439
3440         Reviewed by Zalan Bujtas.
3441
3442         * QueueStatusServer/templates/statusbubble.html: Round the sizes up, not down.
3443
3444 2014-11-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3445
3446         [ninja] Don't remove response files for verbose builds
3447         https://bugs.webkit.org/show_bug.cgi?id=137816
3448
3449         Reviewed by Csaba Osztrogonác.
3450
3451         * Scripts/webkitdirs.pm:
3452         (determineNinjaVersion):
3453         (buildCMakeGeneratedProject):
3454
3455 2014-11-02  Akos Kiss  <akiss@inf.u-szeged.hu>
3456
3457         [GTK] Fix the build of FTL JIT
3458         https://bugs.webkit.org/show_bug.cgi?id=138298
3459
3460         Reviewed by Carlos Garcia Campos.
3461
3462         * gtk/jhbuild-optional.modules:
3463         Bump up LLVM version to 3.5.0 release and apply patches.
3464         * gtk/patches/llvm-elf-add-stackmaps.patch:
3465         Added. Adds .llvm_stackmaps section to ELF files. Backported from LLVM
3466         trunk.
3467         * gtk/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch:
3468         Added. Ensures that PC-relative relocations in EH frames are not
3469         truncated to 32 bits on x86_64.
3470
3471 2014-10-31  Michael Saboff  <msaboff@apple.com>
3472
3473         No way to specify target os or architecture when using the --no-copy option with run-jsc-stress-tests
3474         https://bugs.webkit.org/show_bug.cgi?id=138268
3475
3476         Reviewed by Andreas Kling.
3477
3478         Added a --arch and --os option to set or override the values that are
3479         normally computed based on examining the JavaScriptCore we want to test.
3480
3481         * Scripts/run-jsc-stress-tests:
3482
3483 2014-10-31  Dan Bernstein  <mitz@apple.com>
3484
3485         llvmForJSC build emits a linker warning that it can't find usr/local/LLVMForJavaScriptCore/lib under the build directory
3486         https://bugs.webkit.org/show_bug.cgi?id=138259
3487
3488         Reviewed by Geoff Garen.
3489
3490         * Scripts/copy-webkitlibraries-to-product-directory: Create this directory even if it’s
3491         going to be empty to silence the warning.
3492
3493 2014-10-31  Adrian Perez de Castro  <aperez@igalia.com>
3494
3495         [GTK] Support script message handlers WebKitUserContentManager
3496         https://bugs.webkit.org/show_bug.cgi?id=133730
3497
3498         Reviewed by Carlos Garcia Campos.
3499
3500         Support user script message handlers in WebKitUserContentManager.
3501         This needs building with ENABLE_USER_MESSAGE_HANDLERS, for which
3502         an option is added to the CMake build files. The option is disabled
3503         globally by default, and the WebKitGTK port enables it. On the API
3504         level, two new methods to register and unregister names are provided
3505         in the "window.webkit" namespace, and on message reception the
3506         "WebKitUserContentManager::script-message-received" signal is
3507         emitted, using the registered names as signal detail.
3508
3509         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
3510         Add test case for user script message handlers.
3511         (scriptMessageReceived):
3512         (testUserContentManagerScriptMessageReceived):
3513         (beforeAll):
3514
3515 2014-10-30  Matthew Hanson  <matthew_hanson@apple.com>
3516
3517         bisect-builds should support WebKit clients other than Safari
3518         https://bugs.webkit.org/show_bug.cgi?id=138225
3519
3520         This patch adds support for bisecting WebKit nightly builds with clients other than Safari.
3521
3522         The -a / --application optional argument allows the user to specify which application (or application bundle)
3523         should be run against the WebKit nightly builds.
3524
3525         Reviewed by David Kilzer.
3526
3527         * Scripts/bisect-builds:
3528         Swap out $safariPath for the more general $applicationPath
3529         Leave --safari-path as a commandline option for backwards compatibility
3530         (mountAndRunNightly):
3531         Use File::Spec->cat correctly (one directory per argument)
3532         Use open --wait-apps instead of running the target application directly
3533
3534 2014-10-30  Dana Burkart  <dburkart@apple.com>
3535
3536         <rdar://problem/18821260> Perpare for the mysterious future
3537
3538         Reviewed by Lucas Forschler.
3539
3540         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3541         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3542         * LayoutTestRelay/Configurations/Base.xcconfig:
3543         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
3544         * MiniBrowser/Configurations/Base.xcconfig:
3545         * MiniBrowser/Configurations/DebugRelease.xcconfig:
3546         * TestWebKitAPI/Configurations/Base.xcconfig:
3547         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
3548         * WebKitLauncher/Configurations/Base.xcconfig:
3549         * WebKitTestRunner/Configurations/Base.xcconfig:
3550         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3551
3552 2014-10-30  Matthew Hanson  <matthew_hanson@apple.com>
3553
3554         Update safariVersion to safariVersionString
3555         https://bugs.webkit.org/show_bug.cgi?id=138193
3556
3557         The preceding change updated safariVersion to safariVersionString for the "4 Public Beta" check in OS X 10.5.x,
3558         but it should have also been done for the "4 Public Beta" check in OS X 10.4.x.
3559
3560         Rubber-stamped by David Kilzer.
3561
3562         * Scripts/bisect-builds:
3563         (makeNightlyList):
3564         Compare safariVersionString to a string literal, instead of safariVersion.
3565
3566 2014-10-30  Rohit Kumar  <kumar.rohit@samsung.com>
3567
3568         [GTK] Minibrowser : Add window fullscreen support for Minibrowser
3569         https://bugs.webkit.org/show_bug.cgi?id=137775
3570
3571         Reviewed by Carlos Garcia Campos.
3572
3573         * MiniBrowser/gtk/BrowserWindow.c:
3574         (toggleFullScreen): Callback to toggle window fullscreen on pressing F11 key.
3575         (browser_window_init):
3576
3577 2014-10-29  Jake Nielsen  <jacob_nielsen@apple.com>
3578
3579         CommitQueue and EWS should reject any patches that result in consistent test
3580         failures that aren't present on the tree.
3581         https://bugs.webkit.org/show_bug.cgi?id=138184
3582
3583         Reviewed by Alexey Proskuryakov.
3584
3585         * Scripts/webkitpy/layout_tests/models/test_results.py:
3586         Adds a simple hashing function to allow for set operations to handle
3587         TestResult objects properly.
3588         (TestResult.__hash__):
3589         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3590         Adds one unit test, and modifies others to agree with the notion that
3591         patches that introduce new test failures (but also have flakyness)
3592         should be rejected rather than spin.
3593         (MockCommitQueue.report_flaky_tests):
3594         (CommitQueueTaskTest._run_and_expect_patch_analysis_result):
3595         (test_double_flaky_test_failure):
3596         (test_two_flaky_tests):
3597         (test_very_flaky_patch):
3598         (test_very_flaky_patch_with_some_tree_redness):
3599         (test_different_test_failures):
3600         (test_different_test_failures_with_some_tree_redness):
3601         (test_different_test_failures_with_some_tree_redness_and_some_fixes):
3602         (test_mildly_flaky_patch):
3603         (test_mildly_flaky_patch_with_some_tree_redness):
3604         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
3605         Makes PatchAnalysisTask reject said patches.
3606         (PatchAnalysisTask._test_patch):
3607
3608 2014-10-29  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3609
3610         WinCairoRequirements.zip cannot be downloaded from dropbox
3611         https://bugs.webkit.org/show_bug.cgi?id=138113
3612
3613         Reviewed by Alexey Proskuryakov.
3614
3615         * Scripts/update-webkit-dependency: Removing --sslv3 option from curl
3616
3617 2014-10-29  Matthew Hanson  <matthew_hanson@apple.com>
3618
3619         bisect-builds should filter out nightlies that predate the introduction of an OS X operating system
3620         https://bugs.webkit.org/show_bug.cgi?id=138193
3621