2011-06-13 Chris Rogers <crogers@google.com>
[WebKit-https.git] / Tools / ChangeLog
1 2011-06-13  Chris Rogers  <crogers@google.com>
2
3         Reviewed by Dirk Pranke.
4
5         Add Web Audio support to chromium DRT
6         https://bugs.webkit.org/show_bug.cgi?id=62306
7
8         * DumpRenderTree/chromium/LayoutTestController.cpp:
9         (LayoutTestController::LayoutTestController):
10         (LayoutTestController::reset):
11         (LayoutTestController::setEncodedAudioData):
12         * DumpRenderTree/chromium/LayoutTestController.h:
13         (LayoutTestController::encodedAudioData):
14         (LayoutTestController::shouldDumpAsAudio):
15         (LayoutTestController::setShouldDumpAsAudio):
16         * DumpRenderTree/chromium/TestEventPrinter.cpp:
17         (DRTPrinter::handleAudioHeader):
18         (TestShellPrinter::handleAudioHeader):
19         * DumpRenderTree/chromium/TestEventPrinter.h:
20         * DumpRenderTree/chromium/TestShell.cpp:
21         (TestShell::TestShell):
22         (TestShell::dump):
23
24 2011-06-13  Jaehun Lim  <ljaehun.lim@samsung.com>
25
26         Reviewed by Eric Seidel.
27
28         [EFL] Add load error handler to EWebLauncher
29         https://bugs.webkit.org/show_bug.cgi?id=62347
30
31         Add a handler function of "load,error" to EWebLauncher.
32         EWebLauncher now displays a simple error page on load errors.
33
34         * EWebLauncher/main.c:
35         (on_load_error):
36         (browserCreate):
37
38 2011-06-13  Martin Robinson  <mrobinson@igalia.com>
39
40         Reviewed by Eric Seidel.
41
42         [GTK] [Qt] Eliminate duplicate TestNetscapePlugin implementation
43         https://bugs.webkit.org/show_bug.cgi?id=62385
44
45         Remove duplicate TestNetscapePlugIn implementation. Having two copies
46         of this code makes keeping it in sync much more difficult. The files are
47         almost identical and this change ports the X11 changes to main.cpp.
48
49         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
50         (NPP_New): Do not set the plugin as windowless always. Doing this breaks
51         some results on Qt and this seems to be unnecessary for the moment.
52         (keyEventToChar): Added this helper which converts a X11 keycode into a char.
53         (handleEventX11): Use the handler to properly convert the keycode. Do not print
54         adjustCursorEvent output. The tests currently do not trigger this for Cocoa and thus
55         it should not be in the results.
56         (NPP_GetValue): Properly handle NPPVpluginNeedsXEmbed and make it clearer why the
57         XP_UNIX block is first by guarding against using a null instance.
58         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Update source list add
59         the XP_UNIX define for Linux.
60         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: Removed.
61         * GNUmakefile.am: Update source list.
62
63 2011-06-13  Sheriff Bot  <webkit.review.bot@gmail.com>
64
65         Unreviewed, rolling out r88671.
66         http://trac.webkit.org/changeset/88671
67         https://bugs.webkit.org/show_bug.cgi?id=62591
68
69         "didn't work" (Requested by dpranke on #webkit).
70
71         * Scripts/new-run-webkit-httpd:
72         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
73         * Scripts/webkitpy/layout_tests/port/http_server.py:
74         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
75         * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Removed.
76         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
77         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
78
79 2011-06-13  Nate Chapin  <japhet@chromium.org>
80
81         Reviewed by Darin Fisher.
82
83         New test method on TestNetscapePlugin for https://bugs.webkit.org/show_bug.cgi?id=61482.
84
85         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
86
87 2011-06-13  Dirk Pranke  <dpranke@chromium.org>
88
89         Reviewed by Tony Chang.
90
91         webkitpy: add integration tests for new-run-webkit-httpd, stop calling shut_down_http_server
92         https://bugs.webkit.org/show_bug.cgi?id=62251
93
94         shut_down_http_server() was a total hack that was only used by
95         new-run-webkit-httpd, so I've moved the code there and switched
96         to using executive.kill_process() for the common case. The
97         method itself will be removed in the patch on bug 59993.
98
99         * Scripts/new-run-webkit-httpd:
100         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
101         * Scripts/webkitpy/layout_tests/port/http_server.py:
102         * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Added.
103         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
104
105 2011-06-13  Tony Chang  <tony@chromium.org>
106
107         Reviewed by Dimitri Glazkov.
108
109         rename ENABLE_NEW_FLEXBOX to ENABLE_CSS3_FLEXBOX
110         https://bugs.webkit.org/show_bug.cgi?id=62578
111
112         * Scripts/build-webkit:
113
114 2011-06-13  Tony Chang  <tony@chromium.org>
115
116         Reviewed by Adam Barth.
117
118         rename ENABLE_FLEXBOX to ENABLE_NEW_FLEXBOX
119         https://bugs.webkit.org/show_bug.cgi?id=62545
120
121         * Scripts/build-webkit:
122
123 2011-06-13  Carlos Garcia Campos  <cgarcia@igalia.com>
124
125         Reviewed by Martin Robinson.
126
127         [GTK] Export an API similar to WebKit1
128         https://bugs.webkit.org/show_bug.cgi?id=57820
129
130         Build GtkLauncher2 for WebKit2. It's actually the same GtkLauncher
131         code, but linking to libwebkit2gtk.
132
133         * GNUmakefile.am:
134         * GtkLauncher/main.c:
135         (createBrowser):
136         (main):
137
138 2011-06-12  MORITA Hajime  <morrita@google.com>
139
140         Unreviewed, rolling out r88625.
141         http://trac.webkit.org/changeset/88625
142         https://bugs.webkit.org/show_bug.cgi?id=61073
143
144         Breaks SL Webkit2 Tests
145
146         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops:
147         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
148         * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops:
149         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
150         (WTR::InjectedBundlePage::didClearWindowForFrame):
151         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
152
153 2011-06-12  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
154
155         Reviewed by Antonio Gomes.
156
157         [Qt] LayoutTestController needs setTextDirection implementation
158         https://bugs.webkit.org/show_bug.cgi?id=62442
159
160         Implements LayoutController.setTextDirection.
161
162         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
163         (LayoutTestController::setTextDirection):
164         * DumpRenderTree/qt/LayoutTestControllerQt.h:
165
166 2011-06-12  Dominic Cooney  <dominicc@chromium.org>
167
168         Reviewed by Hajime Morita.
169
170         Add window.internals to WebKit2's WebKitTestRunner.
171         https://bugs.webkit.org/show_bug.cgi?id=61073
172
173         Test: fast/harness/internals-object.html
174
175         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops:
176         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
177         * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops:
178         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
179         (WTR::InjectedBundlePage::didClearWindowForFrame): initialize window.internals
180         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
181
182 2011-06-12  Sheriff Bot  <webkit.review.bot@gmail.com>
183
184         Unreviewed, rolling out r88616.
185         http://trac.webkit.org/changeset/88616
186         https://bugs.webkit.org/show_bug.cgi?id=62517
187
188         It broke editing/text-iterator/findString.html (Requested by
189         tonikitoo on #webkit).
190
191         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
192         * DumpRenderTree/qt/LayoutTestControllerQt.h:
193
194 2011-06-12  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
195
196         Reviewed by Antonio Gomes.
197
198         [Qt] LayoutTestController needs setTextDirection implementation
199         https://bugs.webkit.org/show_bug.cgi?id=62442
200
201         Implements LayoutController.setTextDirection.
202
203         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
204         (LayoutTestController::setTextDirection):
205         * DumpRenderTree/qt/LayoutTestControllerQt.h:
206
207 2011-06-10  Ryosuke Niwa  <rniwa@webkit.org>
208
209         Reviewed by Ojan Vafai.
210
211         new-run-webkit-tests: 'images' links on results.html don't work
212         https://bugs.webkit.org/show_bug.cgi?id=62194
213
214         Use relative path when generating images-diffs.html
215
216         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
217         Added _output_testname.
218
219 2011-06-10  Lucas Forschler  <lforschler@apple.com>
220
221         Reviewed by Stephanie Lewis.
222
223         Script to kill old processes on Mac.
224         This matches the windows version.
225         https://bugs.webkit.org/show_bug.cgi?id=62479  
226         
227         * BuildSlaveSupport/mac: Added.
228         * BuildSlaveSupport/mac/kill-old-processes: Added.
229
230 2011-06-10  Adam Barth  <abarth@webkit.org>
231
232         Reviewed by James Robinson.
233
234         When sheriffbot reports failures on IRC instead of saying "(and more..)" it should say the number of tests that are failing
235         https://bugs.webkit.org/show_bug.cgi?id=62489
236
237         * Scripts/webkitpy/tool/bot/sheriff.py:
238         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
239
240 2011-06-10  Tony Chang  <tony@chromium.org>
241
242         Reviewed by Ojan Vafai.
243
244         add a compile guard ENABLE(FLEXBOX)
245         https://bugs.webkit.org/show_bug.cgi?id=62049
246
247         * Scripts/build-webkit:
248
249 2011-06-10  Mark Rowe  <mrowe@apple.com>
250
251         Reviewed by Dimitri Glazkov.
252
253         <rdar://problem/9562114> Fix DumpRenderTree build for production configuration.
254
255         Ensure that DumpRenderTree can find libWebCoreTestSupport.dylib and the associated
256         header file.
257
258         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
259         * DumpRenderTree/mac/Configurations/Base.xcconfig:
260
261 2011-06-09  Csaba Osztrogonác  <ossy@webkit.org>
262
263         Unreviewed rolling out r88471, because it broke plugin tests on Qt.
264
265         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
266         (handleEventX11):
267         (NPP_GetValue):
268         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
269         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: Added.
270         (webkit_test_plugin_new_instance):
271         (webkit_test_plugin_destroy_instance):
272         (webkit_test_plugin_set_window):
273         (executeScript):
274         (webkit_test_plugin_new_stream):
275         (webkit_test_plugin_destroy_stream):
276         (webkit_test_plugin_stream_as_file):
277         (webkit_test_plugin_write_ready):
278         (webkit_test_plugin_write):
279         (webkit_test_plugin_print):
280         (keyEventToChar):
281         (webkit_test_plugin_handle_event):
282         (webkit_test_plugin_url_notify):
283         (webkit_test_plugin_get_value):
284         (webkit_test_plugin_set_value):
285         (NP_GetMIMEDescription):
286         (NP_Initialize):
287         (NP_Shutdown):
288         (NP_GetValue):
289         * GNUmakefile.am:
290
291 2011-06-09  Martin Robinson  <mrobinson@igalia.com>
292
293         Reviewed by Eric Seidel.
294
295         [GTK] Implement the next bit of the TextInputController (hasMarkedText and markedRange)
296         https://bugs.webkit.org/show_bug.cgi?id=55603
297
298         Add callbacks to support hasMarkedText and markedRange and also clean up existing 
299         TextInputController support.
300
301         * DumpRenderTree/gtk/TextInputController.cpp:
302         (setMarkedTextCallback): Accept parameters in terms of start and length, instead
303         of start and end. This matches the other ports. Do not use GLib style early returns.
304         (hasMarkedTextCallback): Added.
305         (markedRangeCallback): Added.
306         (insertTextCallback): Cleanup as described above.
307         (unmarkTextCallback): Cleanup as described above.
308         (firstRectForCharacterRangeCallback): Cleanup as described above.
309         (selectedRangeCallback): Cleanup as described above.
310
311 2011-06-09  Dirk Pranke  <dpranke@chromium.org>
312
313         Reviewed by Tony Chang.
314
315         nrwt: support webaudio in chromium driver
316         https://bugs.webkit.org/show_bug.cgi?id=62226
317
318         * Scripts/webkitpy/layout_tests/port/chromium.py:
319
320 2011-06-09  Dan Bernstein  <mitz@apple.com>
321
322         Reviewed by Anders Carlsson.
323
324         Added a test for Vector::reverse()
325         https://bugs.webkit.org/show_bug.cgi?id=62393
326
327         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
328         * TestWebKitAPI/Tests/WTF/VectorReverse.cpp: Added.
329         (TestWebKitAPI::TEST):
330         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
331
332 2011-06-09  Martin Robinson  <mrobinson@igalia.com>
333
334         Reviewed by Andreas Kling.
335
336         [GTK] [Qt] Eliminate duplicate TestNetscapePlugin implementation
337         https://bugs.webkit.org/show_bug.cgi?id=62385
338
339         Remove duplicate TestNetscapePlugIn implementation. Having two copies
340         of this code makes keeping it in sync much more difficult. The files are
341         almost identical and this change ports the X11 changes to main.cpp.
342
343         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
344         (keyEventToChar): Added this helper which converts a X11 keycode into a char.
345         (handleEventX11): Use the handler to properly convert the keycode. Do not print
346         adjustCursorEvent output. The tests currently do not trigger this for Cocoa and thus
347         it should not be in the results.
348         (NPP_GetValue): Properly handle NPPVpluginNeedsXEmbed.
349         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Update source list.
350         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: Removed.
351         * GNUmakefile.am: Update source list.
352
353 2011-06-09  Noel Gordon  <noel.gordon@gmail.com>
354
355         Reviewed by Tony Chang.
356
357         Test plugin should support event logging on the windows port.
358         https://bugs.webkit.org/show_bug.cgi?id=61721
359
360         The WebKit win port interprets a 0 return from plugin NPP_HandleEvent()
361         calls to mean the plugin handled the event.
362
363         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
364         (handleEventWin): Return 0 for each event on windows.
365
366 2011-06-09  Chang Shu  <cshu@webkit.org>
367
368         Reviewed by Andreas Kling.
369
370         [Qt] [WK2] Many editing tests failed on missing shouldBeginEditingInDOMRange:range printout
371         https://bugs.webkit.org/show_bug.cgi?id=62381
372
373         Activate QGraphicsScene and setFocus on QGraphicsItem to make sure the view has the focus.
374         QWKPagePrivate::isViewFocused() will check it later.
375
376         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
377         (WTR::PlatformWebView::PlatformWebView):
378
379 2011-06-09  Robert Hogan  <robert@webkit.org>
380
381         Reviewed by Andreas Kling.
382
383         Teach Qt about window.internals
384         https://bugs.webkit.org/show_bug.cgi?id=61074
385
386         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
387         (WebCore::DumpRenderTree::initJSObjects):
388
389 2011-06-09  Eric Seidel  <eric@webkit.org>
390
391         Reviewed by Adam Barth.
392
393         Disable running layout tests on Mac EWS bots (and fix cr-linux bots to run them again)
394         https://bugs.webkit.org/show_bug.cgi?id=62362
395
396         The mac bots are failing inspector tests.  We don't know why yet.
397         So for now, turning run-webkit-tests off for the mac-ews.
398
399         Also noticed that due to the wrong variable name the cr-linux
400         bots weren't running tests!
401
402         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
403
404 2011-06-09  Zoltan Herczeg  <zherczeg@inf.u-szeged.hu>
405
406         Reviewed by Csaba Osztrogonac.
407
408         [Qt][WK2] Canvas tests make css2.1 ones failing
409         https://bugs.webkit.org/show_bug.cgi?id=53427
410
411         Adding a workaround for this issue by mimicing the behaviour of DumpRenderTree.
412         Since the Qt port should eventually go to QRawFont, this issue will be resolved
413         in the future. Both clearMemoryCaches() and removeAllApplicationFonts() are
414         needed for the workaround.
415
416         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
417         (WTR::LayoutTestController::platformInitialize):
418
419 2011-06-09  Mario Sanchez Prada  <msanchez@igalia.com>
420
421         Reviewed by Chris Fleizach.
422
423         [GTK] Provide a way in DRT to check the platform name
424         https://bugs.webkit.org/show_bug.cgi?id=56855
425
426         Patch for adding 'platformName' static property to DRT's
427         LayoutController and provide platform specific implementations.
428
429         In principle, this feature will be only of interest for writing
430         accessibility tests, so that's why it's only implemented in the
431         Mac, Gtk and Win platforms.
432
433         * DumpRenderTree/LayoutTestController.h: New method platformName().
434         * DumpRenderTree/LayoutTestController.cpp:
435         (getPlatformNameCallback): New callback for 'platformName'.
436         (LayoutTestController::staticValues): New static property.
437
438         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
439         (LayoutTestController::platformName): Implemented.
440
441         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
442         (LayoutTestController::platformName): Implemented.
443
444         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
445         (LayoutTestController::platformName): Implemented.
446
447 2011-06-08  Mike Lawther  <mikelawther@chromium.org>
448
449         Reviewed by James Robinson.
450
451         Add mikelawther to committers.py
452         https://bugs.webkit.org/show_bug.cgi?id=62354
453
454         * Scripts/webkitpy/common/config/committers.py:
455
456 2011-06-08  Kent Tamura  <tkent@chromium.org>
457
458         [Chromium] Fix a typo.
459
460         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
461         (WebThemeControlDRTWin::draw):
462
463 2011-06-08  Kent Tamura  <tkent@chromium.org>
464
465         Reviewed by Hajime Morita.
466
467         [Chromium] Support vertical sliders in Windows DRT
468         https://bugs.webkit.org/show_bug.cgi?id=62352
469
470         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
471         (WebThemeControlDRTWin::draw):
472           Paint VerticalSliderThumbType and VerticalSliderTrackType.
473         * DumpRenderTree/chromium/WebThemeControlDRTWin.h:
474           Add VerticalSliderTrackType and VerticalSliderThumbType.
475         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
476         (WebThemeEngineDRTWin::paintTrackbar):
477           Convert Windows identifiers to the internal identifiers for vertical sliders.
478
479 2011-06-08  Ojan Vafai  <ojan@chromium.org>
480
481         Reviewed by Tony Chang.
482
483         add a short-flag for --experimental-fully-parallel
484         https://bugs.webkit.org/show_bug.cgi?id=62321
485
486         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
487
488 2011-06-08  Ryosuke Niwa  <rniwa@webkit.org>
489
490         Reviewed by Tony Chang.
491
492         new-run-webkit-tests: don't turn the tree red when there are new passes
493         https://bugs.webkit.org/show_bug.cgi?id=62311
494
495         Look for "new passes" instead of "passed unexpectedly" in evaluateCommand
496         to match commandComplete.
497
498         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
499
500 2011-06-08  Tom Hudson  <tomhudson@google.com>
501
502         Reviewed by Mihai Parparita.
503
504         Allow sorting in RebaselineServer based on 'metric' field in unexpected_results.json
505         https://bugs.webkit.org/show_bug.cgi?id=60964
506
507         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
508         Add 'Sort tests by metric' link.
509         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
510         (disableSorting): Activate 'Sort tests by metric' link.
511         (enableSorting): Deactivate 'Sort tests by metric' link.
512         (selectDirectory): Call enableSorting()/disableSorting() depending
513         on currently selected failure type, and sort tests if requested.
514         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
515         New .disabled-control class for deactivated links.
516
517 2011-06-08  Tom Sepez  <tsepez@chromium.org>
518
519         Reviewed by Adam Barth.
520
521         Add web permissions callbacks for mixed content blocking.
522         https://bugs.webkit.org/show_bug.cgi?id=61946
523
524         * DumpRenderTree/chromium/LayoutTestController.cpp:
525         (LayoutTestController::setAllowDisplayOfInsecureContent):
526         (LayoutTestController::setAllowRunningOfInsecureContent):
527         (LayoutTestController::overridePreference):
528         * DumpRenderTree/chromium/WebPermissions.cpp:
529         (WebPermissions::allowDisplayingInsecureContent):
530         (WebPermissions::allowRunningInsecureContent):
531         (WebPermissions::setDisplayingInsecureContentAllowed):
532         (WebPermissions::setRunningInsecureContentAllowed):
533         (WebPermissions::reset):
534         * DumpRenderTree/chromium/WebPermissions.h:
535
536 2011-06-08  Dirk Pranke  <dpranke@chromium.org>
537
538         Reviewed by Tony Chang.
539
540         webkitpy: fix typo causing us to skip the port unit tests in chromium_linux
541         https://bugs.webkit.org/show_bug.cgi?id=62259
542
543         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
544
545 2011-06-08  Ryosuke Niwa  <rniwa@webkit.org>
546
547         Reviewed by Tony Chang.
548
549         new-run-webkit-tests: master.cfg errors when nrwt successfully runs test
550         https://bugs.webkit.org/show_bug.cgi?id=62303
551
552         Access self.incorrectLayoutLines instead of incorrectLayoutLines in evaluateCommand.
553
554         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
555
556 2011-06-08  Greg Simon  <gregsimon@chromium.org>
557
558         Reviewed by Dimitri Glazkov.
559
560         Control Indexeddb backends from LayoutTestController
561         https://bugs.webkit.org/show_bug.cgi?id=61000
562
563         * DumpRenderTree/chromium/LayoutTestController.cpp:
564         (LayoutTestController::LayoutTestController):
565         (LayoutTestController::setOverrideIndexedDBBackingStore):
566         (LayoutTestController::clearAllDatabases):
567         * DumpRenderTree/chromium/LayoutTestController.h:
568
569 2011-06-08  Andreas Kling  <kling@webkit.org>
570
571         Add Pierre Rossi to contributors list for EZ-CC.
572
573         * Scripts/webkitpy/common/config/committers.py:
574
575 2011-06-08  Ilya Sherman  <isherman@chromium.org>
576
577         Reviewed by Andreas Kling.
578
579         Add Ilya Sherman to list of committers
580         https://bugs.webkit.org/show_bug.cgi?id=62270
581
582         * Scripts/webkitpy/common/config/committers.py:
583
584 2011-06-07  Ryosuke Niwa  <rniwa@webkit.org>
585
586         Reviewed by Tony Chang.
587
588         new-run-webkit-tests: Bot master should print useful information on waterfall/console for nrwt
589         https://bugs.webkit.org/show_bug.cgi?id=62178
590
591         Added commandComplete and evaluateCommand for NewRunWebKitTests class
592         to parse new-run-webkit-tests' results.
593
594         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
595
596 2011-06-07  Dirk Pranke  <dpranke@chromium.org>
597
598         Reviewed by Eric Seidel.
599
600         webkitpy: add a popen() call to executive
601         https://bugs.webkit.org/show_bug.cgi?id=62179
602
603         This change adds a popen() wrapper call to the Executive object.
604         This will allow other webkitpy scripts that currently call
605         subprocess directly to use Executive, instead.
606
607         No additional tests are necessary (the existing tests cover the code).
608
609         * Scripts/webkitpy/common/system/executive.py:
610
611 2011-06-07  Sam Weinig  <sam@webkit.org>
612
613         Reviewed by Anders Carlsson.
614
615         Remove repeated IPC traffic from SetRenderTreeSize message
616         https://bugs.webkit.org/show_bug.cgi?id=62244
617
618         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
619         (WTR::InjectedBundlePage::InjectedBundlePage):
620         Add stub for didLayoutForFrame.
621
622 2011-06-07  Dirk Pranke  <dpranke@chromium.org>
623
624         Reviewed by Tony Chang.
625
626         rebaseline-chromium-webkit-tests: fix baselining order for linux, linux_x86_64
627         https://bugs.webkit.org/show_bug.cgi?id=62241
628
629         * Scripts/webkitpy/layout_tests/port/chromium.py:
630
631 2011-06-07  Adam Barth  <abarth@webkit.org>
632
633         Rubber-stamped by Eric Seidel.
634
635         Enable tests on the mac-ews
636
637         When we bring the mac-ews back up, we're going to try running tests!
638
639         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
640
641 2011-06-07  Dmitry Lomov  <dslomov@google.com>
642
643         Reviewed by David Levin.
644
645         https://bugs.webkit.org/show_bug.cgi?id=62215
646         Allow comparisons with 0 in LIKELY and UNLIKELY macros.
647
648         * Scripts/webkitpy/style/checkers/cpp.py:
649         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
650
651 2011-06-07  Nico Weber  <thakis@chromium.org>
652
653         Reviewed by Dimitri Glazkov.
654
655         [chromium] -Wdelete-non-virtual-dtor pass for DumpRenderTree
656         https://bugs.webkit.org/show_bug.cgi?id=62210
657
658         The change to TestEventPrinter fixes a latent bug, because
659         objects are deleted through the TestEventPrinter type, but none
660         of the subclasses have destructors or non-POD members.
661
662         The changes to NotificationPresenter and WebViewHost do _not_ to fix a
663         real bug, they just make clang's -Wdelete-non-virtual-dtor happy. As
664         discussed at http://codereview.chromium.org/7094005/, we prefer making
665         leaf class destructors virtual over making the leaf classes final.
666
667         * DumpRenderTree/chromium/NotificationPresenter.cpp:
668         (NotificationPresenter::~NotificationPresenter):
669         * DumpRenderTree/chromium/NotificationPresenter.h:
670         * DumpRenderTree/chromium/TestEventPrinter.cpp:
671         (TestEventPrinter::~TestEventPrinter):
672         * DumpRenderTree/chromium/TestEventPrinter.h:
673         * DumpRenderTree/chromium/WebViewHost.h:
674
675 2011-06-06  Ryosuke Niwa  <rniwa@webkit.org>
676
677         Reviewed by Dirk Pranke.
678
679         [chromium] Chromium bots on build.webkit.org don't upload results.html
680         https://bugs.webkit.org/show_bug.cgi?id=61961
681
682         Don't fix the path on chromium port erroneously.
683
684         * BuildSlaveSupport/test-result-archive:
685
686 2011-06-06  Martin Robinson  <mrobinson@igalia.com>
687
688         Fix the GTK+ build by ensuring that the autogenerated sources
689         necessary for libWebCoreInternals are recorded in a predeclared
690         variable before assigning to BUILT_SOURCES.
691
692         * GNUmakefile.am: Predeclare libwebcoreinternals_built_sources.
693
694 2011-06-06  Yong Li  <yoli@rim.com>
695
696         Reviewed by Eric Seidel.
697
698         https://bugs.webkit.org/show_bug.cgi?id=62097
699         Fix the problem that integral bitfield check incorrectly barked at ?: expressions.
700
701         * Scripts/webkitpy/style/checkers/cpp.py:
702         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
703
704 2011-06-06  Xan Lopez  <xlopez@igalia.com>
705
706         Reviewed by Martin Robinson.
707
708         [GTK] Enable feature/symbol detection in NWRT/GTK
709         https://bugs.webkit.org/show_bug.cgi?id=62136
710
711         Disable feature detection through DRT, since we don't support it,
712         and set the libwebcore patch correctly so that symbol detection
713         through 'nm' works.
714
715         * Scripts/webkitpy/layout_tests/port/gtk.py:
716
717 2011-06-06  Shishir Agrawal  <shishir@chromium.org>
718
719         Reviewed by Tony Gentilcore.
720
721         Add a "prerender" state for page visibility.
722         https://bugs.webkit.org/show_bug.cgi?id=62062
723
724         * DumpRenderTree/chromium/LayoutTestController.cpp:
725         (LayoutTestController::setPageVisibility):
726
727 2011-06-06  Csaba Osztrogonác  <ossy@webkit.org>
728
729         [Qt] Implement download feature for QtTestBrowser
730         https://bugs.webkit.org/show_bug.cgi?id=61865
731
732         Buildfix for --minimal and CONFIG+=qt_minimal build after r88161.
733
734         * QtTestBrowser/launcherwindow.cpp:
735         (LauncherWindow::LauncherWindow):
736         * QtTestBrowser/launcherwindow.h:
737
738 2011-06-06  Barát Tibor  <Barat.Tibor@stud.u-szeged.hu>
739
740         Reviewed by Csaba Osztrogonác.
741
742         [Qt] Implement download feature for QtTestBrowser
743         https://bugs.webkit.org/show_bug.cgi?id=61865
744
745         * QtTestBrowser/launcherwindow.cpp:
746         (LauncherWindow::LauncherWindow):
747         (LauncherWindow::downloadRequest):
748         (LauncherWindow::fileDownloadFinished):
749         * QtTestBrowser/launcherwindow.h:
750
751 2011-06-04  Dominic Cooney  <dominicc@chromium.org>
752
753         Reviewed by Dimitri Glazkov.
754
755         Make DumpRenderTree initialize window.internals.
756         https://bugs.webkit.org/show_bug.cgi?id=61076
757
758         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: link WebCoreTestSupport.
759         * DumpRenderTree/win/FrameLoadDelegate.cpp:
760         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
761
762 2011-06-06  Alexandru Chiculita  <achicu@adobe.com>
763
764         Reviewed by Kent Tamura.
765
766         Add ENABLE_CSS_EXCLUSIONS support for build-webkit script
767         https://bugs.webkit.org/show_bug.cgi?id=61628
768
769         * Scripts/build-webkit:
770
771 2011-06-06  Mihnea Ovidenie  <mihnea@adobe.com>
772
773         Reviewed by Kent Tamura.
774
775         Add ENABLE(CSS_REGIONS) guard for CSS Regions support
776         https://bugs.webkit.org/show_bug.cgi?id=61631
777
778         * Scripts/build-webkit:
779
780 2011-06-06  Carlos Garcia Campos  <cgarcia@igalia.com>
781
782         Unreviewed. Fix the GTK+ build.
783
784         * GNUmakefile.am: Use javascriptcore_cflags when building libWebCoreInternals.
785
786 2011-06-05  Alexey Proskuryakov  <ap@apple.com>
787
788         Add an e-mail address for Cameron McCormack that matches Bugzilla (so that auto-completion
789         works properly).
790
791         * Scripts/webkitpy/common/config/committers.py:
792
793 2011-06-04  Kevin Ollivier  <kevino@theolliviers.com>
794
795         [wx] Unreviewed build fix. Update git branch build dir handling to match what other
796         WebKit scripts expect, so other scripts work properly with wx.
797
798         * waf/build/build_utils.py:
799         * waf/build/settings.py:
800
801 2011-06-04  Kevin Ollivier  <kevino@theolliviers.com>
802
803         [wx] Unreviewed build fix. Restore the PPC build and allow users to specify architectures
804         to build on Mac.
805
806         * waf/build/settings.py:
807         * wx/install-unix-extras:
808
809 2011-06-04  Kevin Ollivier  <kevino@theolliviers.com>
810
811         [wx] Unreviewed build fixes for recent trunk changes.
812
813         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
814         (LayoutTestController::setTextDirection):
815         * waf/build/settings.py:
816
817 2011-06-04  Martin Robinson  <mrobinson@igalia.com>
818
819         Fix the GTK+ build.
820
821         * GNUmakefile.am: Add some missing newline escape.
822
823 2011-06-03  Martin Robinson  <mrobinson@igalia.com>
824
825         Try to fix the GTK+ bulid.
826
827         * GNUmakefile.am: Add JSDOMWrapper.cpp to the libWebCoreInternals
828         source list.
829
830 2011-06-03  Dirk Pranke  <dpranke@chromium.org>
831
832         Reviewed by Adam Barth.
833
834         nrwt: should skip chromium test expectation overrides on upstream bots
835         https://bugs.webkit.org/show_bug.cgi?id=61888
836
837         * Scripts/webkitpy/layout_tests/port/chromium.py:
838         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
839
840 2011-06-03  Dirk Pranke  <dpranke@chromium.org>
841
842         Reviewed by Ojan Vafai.
843
844         new-run-webkit-tests: minor logging, code cleanup
845         https://bugs.webkit.org/show_bug.cgi?id=62055
846
847         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
848         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
849
850 2011-06-03  Martin Robinson  <mrobinson@igalia.com>
851
852         Try to fix the build failure on the GTK+ 32-bit Release bot.
853
854         * GNUmakefile.am: Add JSInternal.{cpp,h} to the BUILT_SOURCES list.
855
856 2011-05-31  Martin Robinson  <mrobinson@igalia.com>
857
858         Reviewed by Ryosuke Niwa.
859
860         [GTK] Support smart replace for the pasteboard
861         https://bugs.webkit.org/show_bug.cgi?id=61734
862
863         Call into the DumpRenderTreeSupportGtk hooks to toggle smart replace.
864         This is required to produce consistent test results.
865
866         * DumpRenderTree/gtk/DumpRenderTree.cpp:
867         (resetDefaultsToConsistentValues): Set the smart replace setting to on by default.
868         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
869         (LayoutTestController::setSmartInsertDeleteEnabled): Added an implementation of this
870         methods which calls into DumpRenderTreeSupportGtk.
871
872 2011-06-03  Martin Robinson  <mrobinson@igalia.com>
873
874         Reviewed by Dimitri Glazkov.
875
876         Teach Gtk build about window.internals
877         https://bugs.webkit.org/show_bug.cgi?id=61071
878
879         * DumpRenderTree/gtk/DumpRenderTree.cpp:
880         (webViewWindowObjectCleared): Inject the new internals object when the
881         window object clears.
882         * GNUmakefile.am: Add new source files and includes necessary for window.internals.
883         Also do a little bit of cleanup.
884
885 2011-06-03  Dirk Pranke  <dpranke@chromium.org>
886
887         Reviewed by Tony Chang.
888
889         Worker may not be stopped after LT.
890         https://bugs.webkit.org/show_bug.cgi?id=61847
891
892         Re-submit a variant of the first fix for this bug. It's possible
893         that actually calling cleanup() in the worker threads was taking
894         too long and we triggered the assertions in the manager thread.
895
896         I've bumped up the timeout in the manager and added better
897         diagnostics. I also cleaned up the cleanup() code a bit because
898         there was some unnecessary if-checks.
899
900         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
901         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
902
903 2011-06-03  Dirk Pranke  <dpranke@chromium.org>
904
905         Reviewed by Tony Chang.
906
907         nrwt: fix duplicate logging regression
908         https://bugs.webkit.org/show_bug.cgi?id=61981
909
910         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
911
912 2011-06-03  Robert Kroeger  <rjkroege@chromium.org>
913
914         Reviewed by Adam Barth.
915
916         Modified addTouchPoint to correctly re-use touchPoint id values starting
917         from the lowest not-un-use touchPoint id as is done by the embedder
918         APIs. (Fixes BUGCR36415)
919
920         https://bugs.webkit.org/show_bug.cgi?id=62016
921
922         * DumpRenderTree/chromium/EventSender.cpp:
923         (EventSender::addTouchPoint):
924
925 2011-06-03  Cary Clark  <caryclark@google.com>
926
927         Reviewed by Eric Seidel.
928
929         Draw DRT scroll bar thumb with CG when WebKit renders with Skia
930         https://bugs.webkit.org/show_bug.cgi?id=61534
931
932         Skia on Mac uses Skia to render WebKit, and CG
933         to render UI elements. The CG elements need a
934         transcribed graphics context that preserves the
935         canvas matrix, and the canvas clip.
936
937         The SkiaBitLocker utility class sets up a CGContext
938         from the SkCanvas, locks the bitmap's bits, and
939         releases the lock when the class goes out of scope.
940
941         The SkiaBitLocker implementation is described by
942         this patch:
943         http://codereview.chromium.org/7031006/
944
945         When WebKit uses Skia for rendering, the WebCanvas
946         is an SkCanvas. Create an equivalent CGContext to
947         draw the scrollbar thumb.
948
949         As the Chrome Mac port does not yet use Skia, this
950         patch has no effect and requires no tests.
951
952         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
953         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
954
955 2011-06-03  Andras Becsi  <abecsi@webkit.org>
956
957         Unreviewed build fix.
958
959         Fix typo.
960
961         * Scripts/old-run-webkit-tests:
962
963 2011-06-03  Andras Becsi  <abecsi@webkit.org>
964
965         Reviewed by Csaba Osztrogonác.
966
967         Print error message when there is no httpd present on the system
968         https://bugs.webkit.org/show_bug.cgi?id=61939
969
970         * Scripts/old-run-webkit-tests: Propose to run with --no-httpd.
971         * Scripts/webkitperl/httpd.pm:
972
973 2011-06-03  Mikhail Naganov  <mnaganov@chromium.org>
974
975         Reviewed by Yury Semikhatsky.
976
977         Web Inspector: [Chromium] cpu-profiler-profiling layout test is flaky on Linux Debug.
978         https://bugs.webkit.org/show_bug.cgi?id=61533
979
980         Skip cpu-profiler-profiling in debug, implement a fast headless alternative.
981
982         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
983         (DRTDevToolsAgent::setJavaScriptProfilingEnabled):
984         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
985         * DumpRenderTree/chromium/LayoutTestController.cpp:
986         (LayoutTestController::LayoutTestController):
987         (LayoutTestController::setJavaScriptProfilingEnabled):
988         * DumpRenderTree/chromium/LayoutTestController.h:
989         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
990         (LayoutTestController::setJavaScriptProfilingEnabled):
991         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
992         (WTR::LayoutTestController::setJavaScriptProfilingEnabled):
993         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
994
995 2011-06-02  Dirk Pranke  <dpranke@chromium.org>
996
997         Reviewed by Tony Chang.
998
999         NRWT needs a way to log to a file without including backspaces without needing --verbose
1000         https://bugs.webkit.org/show_bug.cgi?id=60328
1001
1002         This change modifies NRWT so that if it can tell if it is
1003         writing to a terminal, it will overwrite any messages printed
1004         in the 'one-line-progress' and 'updates' print options, and if
1005         not (or if --verbose was specified) the messages will be printed
1006         without backspaces.
1007
1008         If the overwriting updates are disabled, one-line-progress will
1009         only print every 10 seconds instead of on every update. This
1010         ensures that we still get updates once in a while while the
1011         tests are running, even if we're not in --verbose mode. Note
1012         that one-line-progress will now still be printed in --verbose,
1013         since it's useful as long as you're not flooded with the
1014         updates.
1015
1016         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
1017         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1018         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1019
1020 2011-06-02  Martin Robinson  <mrobinson@igalia.com>
1021
1022         Reviewed by Gustavo Noronha Silva.
1023
1024         [GTK] autogen.sh is run twice for each buld on the bots
1025         https://bugs.webkit.org/show_bug.cgi?id=61951
1026
1027         * Scripts/webkitdirs.pm: Only check the previous autotools arguments
1028         for the WebKit project. This prevents build-jsc runs from forcing subsequent
1029         build-webkit runs to re-rerun autogen.sh.
1030
1031 2011-06-02  Sheriff Bot  <webkit.review.bot@gmail.com>
1032
1033         Unreviewed, rolling out r87946.
1034         http://trac.webkit.org/changeset/87946
1035         https://bugs.webkit.org/show_bug.cgi?id=61965
1036
1037         Cause NRWT to break (Requested by abarth|gardener on #webkit).
1038
1039         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
1040
1041 2011-06-02  Dimitri Glazkov  <dglazkov@chromium.org>
1042
1043         Reviewed by Darin Adler.
1044
1045         Add build logistics and plumbing for window.internals object.
1046         https://bugs.webkit.org/show_bug.cgi?id=60313
1047
1048         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linking new WebCoreTestSupport library.
1049         * DumpRenderTree/chromium/TestShell.cpp:
1050         (TestShell::bindJSObjectsToWindow): Added injection code.
1051         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1052         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): Ditto.
1053
1054 2011-06-02  Hao Zheng  <zhenghao@chromium.org>
1055
1056         Reviewed by Dirk Pranke.
1057
1058         Call cleanup() explicitly at the end of worker.run().
1059         https://bugs.webkit.org/show_bug.cgi?id=61847
1060
1061         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
1062
1063 2011-06-02  Dimitri Glazkov  <dglazkov@chromium.org>
1064
1065         Unreviewed, rolling out r87926.
1066         http://trac.webkit.org/changeset/87926
1067         https://bugs.webkit.org/show_bug.cgi?id=60313
1068
1069         Fails to find WebCoreTestSupport.dylib on bots.
1070
1071         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1072         * DumpRenderTree/chromium/TestShell.cpp:
1073         (TestShell::bindJSObjectsToWindow):
1074         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1075         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
1076
1077 2011-05-21  Dimitri Glazkov  <dglazkov@chromium.org>
1078
1079         Reviewed by Darin Adler.
1080
1081         Add build logistics and plumbing for window.internals object.
1082         https://bugs.webkit.org/show_bug.cgi?id=60313
1083
1084         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linking new WebCoreTestSupport library.
1085         * DumpRenderTree/chromium/TestShell.cpp:
1086         (TestShell::bindJSObjectsToWindow): Added injection code.
1087         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1088         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): Ditto.
1089
1090 2011-06-02  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1091
1092         Reviewed by Eric Seidel.
1093
1094         Adjust efl coding style to more efl directories
1095         https://bugs.webkit.org/show_bug.cgi?id=61903
1096
1097         * Scripts/webkitpy/style/checker.py: Adjust efl coding style to efl directories.
1098
1099 2011-06-01  Dirk Pranke  <dpranke@chromium.org>
1100
1101         Reviewed by Tony Chang.
1102
1103         old-run-webkit-tests: add support for audio files
1104         https://bugs.webkit.org/show_bug.cgi?id=57992
1105
1106         * Scripts/old-run-webkit-tests:
1107
1108 2011-06-01  Jochen Eisinger  <jochen@chromium.org>
1109
1110         Reviewed by Adam Barth.
1111
1112         Implement layoutTestController.setImagesAllowed for controlling the respective behavior of the WebPermissionClient
1113         https://bugs.webkit.org/show_bug.cgi?id=34314
1114
1115         * DumpRenderTree/DumpRenderTree.gypi:
1116         * DumpRenderTree/chromium/LayoutTestController.cpp:
1117         (LayoutTestController::LayoutTestController):
1118         (LayoutTestController::setImagesAllowed):
1119         (LayoutTestController::setStorageAllowed):
1120         * DumpRenderTree/chromium/LayoutTestController.h:
1121         * DumpRenderTree/chromium/WebPermissions.cpp: Copied from Tools/DumpRenderTree/chromium/WebPermissions.h.
1122         (WebPermissions::WebPermissions):
1123         (WebPermissions::~WebPermissions):
1124         (WebPermissions::allowImages):
1125         (WebPermissions::allowStorage):
1126         (WebPermissions::setImagesAllowed):
1127         (WebPermissions::setStorageAllowed):
1128         (WebPermissions::reset):
1129         * DumpRenderTree/chromium/WebPermissions.h:
1130
1131 2011-06-01  Noel Gordon  <noel.gordon@gmail.com>
1132
1133         Reviewed by Tony Chang.
1134
1135         Test plugin should support event logging on the windows port.
1136         https://bugs.webkit.org/show_bug.cgi?id=61721
1137
1138         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1139         (handleEventWin): Well, handle them.
1140
1141 2011-06-01  Daniel Cheng  <dcheng@chromium.org>
1142
1143         Reviewed by Tony Chang.
1144
1145         [chromium] Use correct file name for dragging out images.
1146         https://bugs.webkit.org/show_bug.cgi?id=24887
1147
1148         * DumpRenderTree/chromium/EventSender.cpp:
1149         (EventSender::EventSender):
1150         (EventSender::dumpFilenameBeingDragged):
1151         * DumpRenderTree/chromium/EventSender.h:
1152
1153 2011-06-01  Dirk Pranke  <dpranke@chromium.org>
1154
1155         Reviewed by Tony Chang.
1156
1157         nrwt: make webaudio work w/o content-length header
1158         https://bugs.webkit.org/show_bug.cgi?id=61819
1159
1160         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1161         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
1162         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1163         * Scripts/webkitpy/layout_tests/port/webkit.py:
1164
1165 2011-06-01  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
1166
1167         Reviewed by Andreas Kling.
1168
1169         [Qt][WK2] Add QGLWidget viewport support to MiniBrowser
1170         https://bugs.webkit.org/show_bug.cgi?id=61802
1171
1172         Add command line parameter and menu item to MiniBrowser application 
1173         enabling use of QGLWidget for browser viewport.
1174
1175         * MiniBrowser/qt/BrowserWindow.cpp:
1176         (BrowserWindow::BrowserWindow):
1177         (BrowserWindow::toggleGLViewport):
1178         * MiniBrowser/qt/BrowserWindow.h:
1179         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1180         (MiniBrowserApplication::handleUserOptions):
1181         * MiniBrowser/qt/MiniBrowserApplication.h:
1182         (WindowOptions::WindowOptions):
1183
1184 2011-06-01  Martin Robinson  <mrobinson@igalia.com>
1185
1186         Reviewed by Xan Lopez.
1187
1188         Print out autogen arguments when they differ from the last set, to help
1189         with debugging build issues.
1190
1191         * Scripts/webkitdirs.pm: Print out previous and current build arguments
1192         when they differ.
1193
1194 2011-06-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1195
1196         Reviewed by Martin Robinson.
1197
1198         [GTK] run-launcher should run MiniBrowser in WebKit2
1199         https://bugs.webkit.org/show_bug.cgi?id=61858
1200
1201         * Scripts/run-launcher: Check whether -2 command line option has
1202         been passed and run MiniBrowser instead of GtkLauncher.
1203
1204 2011-05-31  Hao Zheng  <zhenghao@chromium.org>
1205
1206         Reviewed by Dirk Pranke.
1207
1208         Fix exception in verbose printing mode.
1209         https://bugs.webkit.org/show_bug.cgi?id=61723
1210
1211         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1212
1213 2011-05-31  Yong Li  <yoli@rim.com>
1214
1215         Reviewed by Eric Seidel.
1216
1217         https://bugs.webkit.org/show_bug.cgi?id=54807
1218         We have been assuming plain bitfields (like "int a : 31") are always signed integers.
1219         However some compilers can treat them as unsigned. For example, RVCT 4.0 states plain
1220         bitfields (declared without either signed or unsigned qualifiers) are treats as unsigned.
1221         http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0348c/Babjddhe.html
1222         Although we can use "--signed-bitfields" flag to make RVCT 4.0 behave as most other compilers,
1223         always using "signed"/"unsigned" qualifier to declare integral type bitfields is still a good
1224         rule we should have in order to make our code independent from compilers and compiler flags.
1225
1226         * Scripts/webkitpy/style/checkers/cpp.py:
1227
1228 2011-05-31  Hironori Bono  <hbono@chromium.org>
1229
1230         Reviewed by Eric Seidel.
1231
1232         Add a JavaScript function layoutTestController.setTextDirection().
1233         https://bugs.webkit.org/show_bug.cgi?id=50952
1234
1235         This change adds a new JavaScript function setTextDirection() to the
1236         LayoutTestController class of Safari and Chrome to write layout tests
1237         that changes the text direction of an editable element.
1238
1239         * DumpRenderTree/LayoutTestController.cpp:
1240         (setTextDirectionCallback):
1241         (LayoutTestController::staticFunctions):
1242         * DumpRenderTree/LayoutTestController.h:
1243         * DumpRenderTree/chromium/LayoutTestController.cpp:
1244         (LayoutTestController::LayoutTestController):
1245         (LayoutTestController::setTextDirection):
1246         * DumpRenderTree/chromium/LayoutTestController.h:
1247         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1248         (LayoutTestController::setTextDirection):
1249         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1250         (LayoutTestController::setTextDirection):
1251         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1252         (LayoutTestController::setTextDirection):
1253
1254 2011-05-31  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
1255
1256         Reviewed by Simon Hausmann.
1257
1258         [Qt] User-agent list of Qt test browsers is very outdated
1259         https://bugs.webkit.org/show_bug.cgi?id=61531
1260
1261         The user can edit the user-agent manually, so there's no need to have
1262         a super complete and up to date list, but it's nice to have it
1263         minimally updated.
1264
1265         * MiniBrowser/qt/useragentlist.txt:
1266         * QtTestBrowser/useragentlist.txt:
1267
1268 2011-03-30  Martin Robinson  <mrobinson@igalia.com>
1269
1270         Reviewed by Adam Roben.
1271
1272         [GTK] [WebKit2] Implement a basic WebKitTestRunner
1273         https://bugs.webkit.org/show_bug.cgi?id=57068
1274
1275         Add an implementation of WebKitTestRunner for GTK+.
1276
1277         * Scripts/build-webkittestrunner: Added knowledge of GTK+ TestRunner.
1278         * Scripts/old-run-webkit-tests: Ditto.
1279         * Scripts/run-launcher: Ditto.
1280         * Scripts/webkitdirs.pm: Ditto.
1281         * WebKitTestRunner/GNUmakefile.am: Added.
1282         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1283         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp: Added.
1284         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
1285         * WebKitTestRunner/InjectedBundle/gtk/LayoutTestControllerGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
1286         * WebKitTestRunner/PlatformWebView.h:
1287         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp: Added.
1288         * WebKitTestRunner/gtk/TestControllerGtk.cpp: Added.
1289         * WebKitTestRunner/gtk/TestInvocationGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
1290         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1291         * WebKitTestRunner/gtk/main.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
1292         (main): Added.
1293
1294 2011-05-31  Dirk Pranke  <dpranke@chromium.org>
1295
1296         Reviewed by Tony Chang.
1297
1298         new-run-webkit-tests: doesn't wait for children if it gets a ctrl-c
1299         https://bugs.webkit.org/show_bug.cgi?id=60241
1300
1301         * Scripts/new-run-webkit-tests:
1302
1303 2011-05-31  Eric Seidel  <eric@webkit.org>
1304
1305         Reviewed by David Kilzer.
1306
1307         webkitpy should create zips with zip -9
1308         https://bugs.webkit.org/show_bug.cgi?id=61789
1309
1310         Dave Kilzer suggested we add this to make zips uploaded to bugzilla smaller.
1311
1312         * Scripts/webkitpy/common/system/workspace.py:
1313         * Scripts/webkitpy/common/system/workspace_unittest.py:
1314
1315 2011-05-31  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
1316
1317         Reviewed by Csaba Osztrogonác.
1318
1319         [Qt] Implement find feature for QtTestBrowser
1320         https://bugs.webkit.org/show_bug.cgi?id=61425
1321
1322         Buildfix for --minimal and CONFIG+=qt_minimal build.
1323
1324         * QtTestBrowser/launcherwindow.cpp:
1325         (LauncherWindow::LauncherWindow):
1326         (LauncherWindow::createChrome):
1327         * QtTestBrowser/launcherwindow.h:
1328
1329 2011-05-31  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
1330
1331         Reviewed by Csaba Osztrogonác.
1332
1333         [Qt] Implement find feature for QtTestBrowser
1334         https://bugs.webkit.org/show_bug.cgi?id=61425
1335
1336         * QtTestBrowser/launcherwindow.cpp:
1337         (LauncherWindow::LauncherWindow):
1338         (LauncherWindow::createChrome):
1339         (LauncherWindow::showFindBar):
1340         (LauncherWindow::find):
1341         * QtTestBrowser/launcherwindow.h:
1342
1343 2011-05-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1344
1345         Reviewed by Martin Robinson.
1346
1347         [GTK] Implement JavaScript dialogs in MiniBrowser
1348         https://bugs.webkit.org/show_bug.cgi?id=61725
1349
1350         * MiniBrowser/gtk/BrowserWindow.c:
1351         (WKStringGetCString): Helper function to get a UTF-8 c string from
1352         a WKStringRef.
1353         (WKURLGetCString): Helper function to get a UTF-8 c string from a
1354         WKURLRef.
1355         (browserWindowUpdateURL): Update to use WKURLGetCString.
1356         (didReceiveTitleForFrame): Update to use WKStringGetCString.
1357         (createMessageDialog): Create a GtkMessageDialog.
1358         (runJavaScriptAlert):
1359         (runJavaScriptConfirm):
1360         (runJavaScriptPrompt):
1361         (browserWindowUIClientInit):
1362
1363 2011-05-29  Yuta Kitamura  <yutak@chromium.org>
1364
1365         Reviewed by Kent Tamura.
1366
1367         WebSocket closing handshake
1368         https://bugs.webkit.org/show_bug.cgi?id=35721
1369
1370         * Scripts/webkitpy/thirdparty/__init__.py:
1371         Pull in pywebsocket 0.6b1. We need to update pywebsocket
1372         to get the right behavior of closing handshake.
1373
1374 2011-05-29  Daniel Bates  <dbates@rim.com>
1375
1376         Reviewed by David Kilzer.
1377
1378         REGRESSION (r86515): svn-apply ignores diffs that omit line count in chunk range
1379         https://bugs.webkit.org/show_bug.cgi?id=61162
1380
1381         Fixes an issue where svn-apply may ignore a diff that contains a chunk range line
1382         that omits a line count. In particular, the chunk range regular expression does
1383         not match a chunk range line that omits a line count. GNU diff(1) will omit the
1384         line count in the chunk range if the line count is exactly 1. For example, appending
1385         a new line to the end of an existing file F that contains exactly one line of text will
1386         be represented in a diff with a chunk range line that omits the line count for F.
1387
1388         * Scripts/VCSUtils.pm:
1389           (parseChunkRange): Added.
1390         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl: Added.
1391         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
1392           - Added unit test "Git: Append new line to the end of an existing file".
1393
1394 2011-05-28  Adam Barth  <abarth@webkit.org>
1395
1396         Reviewed by Eric Seidel.
1397
1398         EWS builds patches that fail to build twice, which seems useless and slows down the bots
1399         https://bugs.webkit.org/show_bug.cgi?id=55585
1400
1401         This patch switches all the early warning system bots over to the new
1402         PatchAnalysisTask-based infrastructure.  This patch makes these bots
1403         more efficient (in the case where patches fail to build) and paves the
1404         way for running tests on these bots!
1405
1406         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1407         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
1408         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1409         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1410         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1411         * Scripts/webkitpy/tool/commands/queues.py:
1412
1413 2011-05-28  Kenichi Ishibashi  <bashi@chromium.org>
1414
1415         Reviewed by Kent Tamura.
1416
1417         Add bashi as a committer.
1418
1419         https://bugs.webkit.org/show_bug.cgi?id=61685
1420
1421         * Scripts/webkitpy/common/config/committers.py:
1422
1423 2011-05-27  Adam Barth  <abarth@webkit.org>
1424
1425         Reviewed by Eric Seidel.
1426
1427         When checking whether the tree is red, the EWS posts a link to the wrong log
1428         https://bugs.webkit.org/show_bug.cgi?id=61072
1429
1430         We need to cache the original script error because that contains the
1431         failure log we want to upload.  If we don't cache that script error,
1432         self._script_error will get overwritten when we sanity check the clean
1433         tree (and it also has test failures).
1434
1435         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1436             - This testing approach is slightly goofy.  We'd like to use
1437               assertRaisesRegexp, but that's not available until Python 2.7.
1438         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1439
1440 2011-05-27  Jochen Eisinger  <jochen@chromium.org>
1441
1442         Reviewed by Adam Barth.
1443
1444         Add layoutTestController.setStorageAllowed() to control whether access
1445         to the localStorage API is enabled via the WebPermissionClient
1446         https://bugs.webkit.org/show_bug.cgi?id=61581
1447
1448         * DumpRenderTree/chromium/LayoutTestController.cpp:
1449         (LayoutTestController::LayoutTestController):
1450         (LayoutTestController::setStorageAllowed):
1451         * DumpRenderTree/chromium/LayoutTestController.h:
1452         * DumpRenderTree/chromium/TestShell.cpp:
1453         (TestShell::TestShell):
1454         (TestShell::createNewWindow):
1455         * DumpRenderTree/chromium/TestShell.h:
1456         * DumpRenderTree/chromium/WebPermissions.h: Added.
1457         (WebPermissions::WebPermissions):
1458         (WebPermissions::allowStorage):
1459         (WebPermissions::setStorageAllowed):
1460         (WebPermissions::reset):
1461
1462 2011-05-27  Dirk Pranke  <dpranke@chromium.org>
1463
1464         Reviewed by Eric Seidel.
1465
1466         NRWT: clean up metered_stream code in preparation for 'nooverwriting' patch
1467         https://bugs.webkit.org/show_bug.cgi?id=60326
1468
1469         This patch removes a lot of the complexity from the
1470         metered_stream implementation that was unnecessary since there
1471         was only one caller and the logic could be coordinated better.
1472
1473         There should be no functional changes in this patch, just code
1474         getting deleted and cleaned up.
1475
1476         * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
1477         * Scripts/webkitpy/layout_tests/layout_package/metered_stream_unittest.py:
1478         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1479         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1480
1481 2011-05-27  Dirk Pranke  <dpranke@chromium.org>
1482
1483         Reviewed by Eric Seidel.
1484
1485         NRWT: minor cleanup in printing module
1486         https://bugs.webkit.org/show_bug.cgi?id=60329
1487
1488         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1489
1490 2011-05-27  Steve Lacey  <sjl@chromium.org>
1491
1492         Reviewed by David Levin.
1493
1494         Add sjl@chromium.org as a committer.
1495
1496         https://bugs.webkit.org/show_bug.cgi?id=61672
1497
1498         * Scripts/webkitpy/common/config/committers.py:
1499
1500 2011-05-27  Dirk Pranke  <dpranke@chromium.org>
1501
1502         Reviewed by Adam Barth.
1503
1504         NRWT: remove --print detailed-progress
1505         https://bugs.webkit.org/show_bug.cgi?id=60324
1506
1507         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
1508         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1509         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1510         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1511
1512 2011-05-27  Dirk Pranke  <dpranke@chromium.org>
1513
1514         Reviewed by Ojan Vafai.
1515
1516         NRWT: debug messages from the workers are being logged twice
1517         https://bugs.webkit.org/show_bug.cgi?id=60428
1518
1519         It looks like when the workers are run in separate processes
1520         we end up getting two copies of every log message they print.
1521         This has to do with the multiprocessing module on UNIX cloning
1522         the log configuration in a way I wasn't expecting, and so two
1523         log handlers end up getting registered.
1524
1525         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
1526         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1527         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1528         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1529
1530 2011-05-27  Adam Roben  <aroben@apple.com>
1531
1532         Always decode tester names from location.hash
1533
1534         When navigating directly to a tester-specific URL (e.g.,
1535         <http://build.webkit.org/TestFailures/#/Windows%207%20Release%20(Tests)>), you could end up
1536         with a URL-encoded tester name in the page, and then the encoded name could make its way
1537         into Bugzilla bugs. Bad!
1538
1539         Reviewed by David Kilzer.
1540
1541         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1542         (ViewController.prototype.parseHash): Pass the tester name we got from location.hash through
1543         decodeURIComponent before trying to use it.
1544
1545 2011-05-27  Adam Roben  <aroben@apple.com>
1546
1547         Remove testing code that snuck into r87528
1548
1549         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1550         (ViewController.prototype._domForNewBugLink): Remove a line I was using for some testing.
1551
1552 2011-05-27  Adam Roben  <aroben@apple.com>
1553
1554         Add links to TestFailures to easily file bugs about failing tests
1555
1556         Fixes <http://webkit.org/b/61636> <rdar://problem/9514886> TestFailures page should have
1557         links to file bugs for failing tests
1558
1559         Reviewed by David Kilzer.
1560
1561         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
1562         (Builder.prototype.resultsPageURL): New helper function to return the URL to results.html
1563         for a particular build.
1564         (Builder.prototype._getFailingTests): Use resultsPageURL.
1565
1566         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1567         (ViewController.prototype._displayBuilder): Add links to file bugs about each set of
1568         failures.
1569         (ViewController.prototype._domForBuildName): Use resultsPageURL.
1570         (ViewController.prototype._domForNewBugLink): Added. Creates an element that represents the
1571         new bug link. The bug has a title, description, and URL already filled in for you!
1572
1573 2011-05-27  Sheriff Bot  <webkit.review.bot@gmail.com>
1574
1575         Unreviewed, rolling out r87464.
1576         http://trac.webkit.org/changeset/87464
1577         https://bugs.webkit.org/show_bug.cgi?id=61643
1578
1579         client-close/server-close tests are flaky on Chromium Mac and
1580         Windows (Requested by aklein on #webkit).
1581
1582         * Scripts/webkitpy/thirdparty/__init__.py:
1583
1584 2011-05-27  Alexey Proskuryakov  <ap@apple.com>
1585
1586         Added Douglas Davidson to contributors list for easier CC'ing.
1587
1588         * Scripts/webkitpy/common/config/committers.py:
1589
1590 2011-05-26  Mihai Parparita  <mihaip@chromium.org>
1591
1592         Reviewed by Adam Barth.
1593
1594         Fix worldID and destinationDomain argument names
1595         https://bugs.webkit.org/show_bug.cgi?id=61571
1596
1597         As part of working on r87423, I noticed a couple of inconsistencies in
1598         argument names:
1599         - We would use worldId in .h files but worldID in .cpp files.
1600           Standardize on the latter
1601         - SecurityOrigin::addOriginAccessWhitelistEntry would take a
1602           destinationDomains argument, even though the actual parameter was for
1603           a single domain (renamed to be singular).
1604
1605         * DumpRenderTree/LayoutTestController.h:
1606         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1607         (LayoutTestController::evaluateScriptInIsolatedWorld):
1608
1609 2011-05-26  Yuta Kitamura  <yutak@chromium.org>
1610
1611         Reviewed by Kent Tamura.
1612
1613         WebSocket closing handshake
1614         https://bugs.webkit.org/show_bug.cgi?id=35721
1615
1616         * Scripts/webkitpy/thirdparty/__init__.py:
1617         Pull in pywebsocket 0.6b1. We need to update pywebsocket
1618         to get the right behavior of closing handshake.
1619
1620 2011-05-26  Qi Zhang  <qi.2.zhang@nokia.com>
1621
1622         Reviewed by Andreas Kling.
1623
1624         WebKitTestRunner needs layoutTestController.setAuthorAndUserStylesEnabled
1625         https://bugs.webkit.org/show_bug.cgi?id=42676
1626
1627         Implemented layoutTestController.setAuthorAndUserStylesEnabled for WebKitTestRunner.
1628
1629         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1630         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1631         (WTR::InjectedBundle::beginTesting):
1632         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1633         (WTR::LayoutTestController::setAuthorAndUserStylesEnabled):
1634         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1635
1636 2011-05-26  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>
1637
1638         Reviewed by Andreas Kling.
1639
1640         [Qt] QtTestBrowser "Switch User Agent" dialog is broken
1641         https://bugs.webkit.org/show_bug.cgi?id=61527
1642
1643         The setMaximumHeight() call is unecessary and breaks the dialog at
1644         least on my setup.
1645
1646         * QtTestBrowser/launcherwindow.cpp:
1647         (LauncherWindow::showUserAgentDialog):
1648
1649 2011-05-02  Robert Hogan  <robert@webkit.org>
1650
1651         Reviewed by Adam Roben.
1652
1653         [Qt] Allow popup windows from plugins when initiated by a user gesture
1654
1655         https://bugs.webkit.org/show_bug.cgi?id=41292
1656
1657         Support parameters introduced in plugin-initiate-popup-window.html
1658
1659         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1660         (webkit_test_plugin_new_instance):
1661         (webkit_test_plugin_handle_event):
1662
1663 2011-05-26  Mihai Parparita  <mihaip@chromium.org>
1664
1665         Reviewed by Adam Barth.
1666
1667         Support cross-origin XMLHttpRequest in isolated worlds
1668         https://bugs.webkit.org/show_bug.cgi?id=59843
1669
1670         Expose setIsolatedWorldSecurityOrigin in LayoutTestController.
1671
1672         * DumpRenderTree/chromium/LayoutTestController.cpp:
1673         (LayoutTestController::LayoutTestController):
1674         (LayoutTestController::setIsolatedWorldSecurityOrigin):
1675         * DumpRenderTree/chromium/LayoutTestController.h:
1676
1677 2011-05-25  Brian Weinstein  <bweinstein@apple.com>
1678
1679         Reviewed by Adam Roben.
1680
1681         WebKit2: Status bar, toolbar, and menu bar checks should be in the injected bundle
1682         https://bugs.webkit.org/show_bug.cgi?id=61474
1683         <rdar://problem/9468337>
1684
1685         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1686         (WTR::InjectedBundlePage::InjectedBundlePage): Add empty entries in the WKBundlePageUIClient.
1687
1688 2011-05-26  Andreas Kling  <kling@webkit.org>
1689
1690         Unreviewed, correct address to webkit-committers mailing list.
1691
1692         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1693
1694 2011-05-25  Adam Roben  <aroben@apple.com>
1695
1696         Don't assume that builds finish in the order they were started
1697
1698         Fixes <http://webkit.org/b/61464> TestFailures page shows failures from a not-most-recent
1699         build when one slave is taking a long time to finish a build
1700
1701         Reviewed by Antti Koivisto.
1702
1703         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
1704         (Builder.prototype.getMostRecentCompletedBuildNumber): Don't assume that all builds that are
1705         newer than the oldest in-progress build are also themselves in progress. Just check whether
1706         each build is actually in progress (as signified by its presence in the currentBuilds set).
1707
1708 2011-05-25  Adam Roben  <aroben@apple.com>
1709
1710         Correctly detect cases where only a single test failed/crashed/timed out
1711
1712         Fixes <http://webkit.org/b/61463> TestFailures page doesn't show testers with only a single
1713         failing test
1714
1715         Reviewed by Darin Adler.
1716
1717         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
1718         (Builder.prototype.getNumberOfFailingTests): Don't require "test cases" to be plural. It
1719         will be singular when only a single test fails/crashes/times out.
1720
1721         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1722         (ViewController.prototype._displayTesters): Only pluralize "test" when more than one test
1723         failed/crashed/timed out.
1724
1725 2011-05-26  Tom Hudson  <tomhudson@google.com>
1726
1727         Reviewed by Tony Chang.
1728
1729         Add flags to Chromium ImageDiff to write image comparison metrics on
1730         stdout.
1731         https://bugs.webkit.org/show_bug.cgi?id=60569
1732
1733         * DumpRenderTree/chromium/ImageDiff.cpp:
1734         (Image::createFromStdin): Fix spelling.
1735         (maxOf3): New function to do 3-way maximum.
1736         (getRedComponent): Extract red component from ABGR packed encoding.
1737         (getGreenComponent): Extract green component from ABGR packed encoding.
1738         (getBlueComponent): Extract blue component from ABGR packed encoding.
1739         (weightedPercentageDifferent): Determine % of pixels different in two
1740         images multiplied by intensity difference of each pixel.
1741         (printHelp): Document new arguments.
1742         (compareImages): Parameterize.
1743         (untestedCompareImages): Parameterize.
1744         (diffImages): Parameterize; write results on stdout if requested.
1745         (main): Parse new arguments.
1746
1747 2011-05-25  Qi Zhang  <qi.2.zhang@nokia.com>
1748
1749         Reviewed by Simon Hausmann.
1750
1751         WebKitTestRunner needs layoutTestController.setPrivateBrowsingEnabled
1752         https://bugs.webkit.org/show_bug.cgi?id=42697
1753
1754         Implemented layoutTestController.setPrivateBrowsingEnabled for WebKitTestRunner.
1755
1756         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1757         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1758         (WTR::InjectedBundle::beginTesting):
1759         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1760         (WTR::LayoutTestController::setPrivateBrowsingEnabled):
1761         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1762
1763 2011-05-25  Jon Honeycutt  <jhoneycutt@apple.com>
1764
1765         REGRESSION (WebKit2): Crash in Flash on USA Today photo gallery
1766         https://bugs.webkit.org/show_bug.cgi?id=61428
1767         <rdar://problem/9457006>
1768
1769         Reviewed by Adam Roben.
1770
1771         The crash occurs when Flash posts a message to a window that it
1772         creates, and in processing the message, it calls NPN_Evaluate to
1773         evaluate JavaScript that removes the plug-in from the page. Flash then
1774         crashes when we return to Flash code.
1775
1776         This test emulates that behavior.
1777
1778         * DumpRenderTree/TestNetscapePlugIn/win/CallJSThatDestroysPlugin.cpp: Added.
1779         (CallJSThatDestroysPlugin::CallJSThatDestroysPlugin):
1780         Initialize member vars.
1781         (CallJSThatDestroysPlugin::~CallJSThatDestroysPlugin):
1782         Remove our custom property from the message window, and destroy it.
1783         (CallJSThatDestroysPlugin::NPP_Destroy):
1784         Set m_isDestroyed, log that the plug-in was destroyed, and notify the
1785         layout test controller that we're done.
1786         (wndProc):
1787         Get the PluginTest object, and call its runTest() function.
1788         (CallJSThatDestroysPlugin::NPP_New):
1789         Setup the test: register a class for the message-only window, create
1790         it, and post a message to it to run the test.
1791         (CallJSThatDestroysPlugin::runTest):
1792         Execute JS that removes the plug-in from the page, and if we're not
1793         destroyed, log a success message.
1794
1795         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1796         Add new test to project.
1797
1798 2011-05-25  Tony Chang  <tony@chromium.org>
1799
1800         Reviewed by Adam Barth.
1801
1802         webkitpy's NetworkTransaction shouldn't use mechanize
1803         https://bugs.webkit.org/show_bug.cgi?id=61450
1804
1805         mechanize.HTTPError is just an alias for urllib2.HTTPError, so
1806         use urllib2 directly.  Re-add NetworkTransaction to
1807         test_results_uploader.py (reverting r87124).
1808
1809         * Scripts/webkitpy/common/net/networktransaction.py:
1810         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
1811
1812 2011-05-25  Kevin Ollivier  <kevino@theolliviers.com>
1813
1814         [Chromium] Unreviewed build fix. Do not define WTF/JS_EXPORT_PRIVATE to JS_EXPORTDATA
1815         until the port begins using those export macros.
1816
1817         * DumpRenderTree/chromium/config.h:
1818
1819 2011-05-25  Sheriff Bot  <webkit.review.bot@gmail.com>
1820
1821         Unreviewed, rolling out r87257.
1822         http://trac.webkit.org/changeset/87257
1823         https://bugs.webkit.org/show_bug.cgi?id=61457
1824
1825         This broke layout tests, see bug 61431. (Requested by
1826         hwennborg on #webkit).
1827
1828         * DumpRenderTree/chromium/LayoutTestController.cpp:
1829         (LayoutTestController::LayoutTestController):
1830         (LayoutTestController::clearAllDatabases):
1831         * DumpRenderTree/chromium/LayoutTestController.h:
1832
1833 2011-05-25  Qi Zhang  <qi.2.zhang@nokia.com>
1834
1835         Reviewed by Andreas Kling.
1836
1837         [Qt] fast/css/disabled-author-styles.html failed
1838         https://bugs.webkit.org/show_bug.cgi?id=61438
1839
1840         Implemented API setAuthorAndUserStylesEnabled in LayoutTestControllerQt.
1841
1842         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1843         (WebCore::WebPage::resetSettings):
1844         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1845         (LayoutTestController::setAuthorAndUserStylesEnabled):
1846         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1847
1848 2011-05-25  Adam Roben  <aroben@apple.com>
1849
1850         Identify, rather than skip, builds where run-webkit-tests exited early due to too many failures
1851
1852         Fixes <http://webkit.org/b/61441> TestFailures page should show when run-webkit-tests
1853         started exiting early due to too many crashes, timeouts, or failures
1854
1855         Reviewed by David Kilzer.
1856
1857         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
1858         (Builder.prototype.getNumberOfFailingTests): Rather than returning -1 ("unknown") when
1859         run-webkit-tests exits early due to too many failures, pass that information in another
1860         argument to the callback.
1861         (Builder.prototype.startFetchingBuildHistory): Updated the documentation comment to reflect
1862         the new structure of the object passed to the callback.
1863         (Builder.prototype._getFailingTests): Updated to expect a tooManyFailures boolean from
1864         getNumberOfFailingTests and to pass that along to our own callbacks.
1865         (Builder.prototype._incorporateBuildHistory): Updated to expect a tooManyFailures boolean
1866         from _getFailingTests and to store that value in the history object.
1867
1868         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
1869         (.info): Added.
1870
1871         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1872         (ViewController.prototype._displayBuilder): Updated for change in structure to the history
1873         object and to add a note when run-webkit-tests exited early due to too many failures.
1874         (ViewController.prototype._displayTesters): Renamed testersAndFailureCounts to
1875         latestBuildInfos since each entry now contains more than just the tester and failure count.
1876         Now displays a message for testers where the latest build exited early due to too many
1877         failures. Updated to expect a tooManyFailures boolean from getNumberOfFailingTests and to
1878         store that value in latestBuildInfos.
1879
1880 2011-05-24  Keishi Hattori  <keishi@webkit.org>
1881
1882         Reviewed by Kent Tamura.
1883
1884         Disable textfield implementation of <input type=color>. Add INPUT_COLOR feature flag. Add input color sanitizer.
1885         https://bugs.webkit.org/show_bug.cgi?id=61273
1886
1887         * Scripts/build-webkit: Added INPUT_COLOR feature flag.
1888
1889 2011-05-24  Greg Simon  <gregsimon@chromium.org>
1890
1891         Reviewed by Dimitri Glazkov.
1892
1893         Control Indexeddb backends from LayoutTestController
1894         https://bugs.webkit.org/show_bug.cgi?id=61000
1895
1896         * DumpRenderTree/chromium/LayoutTestController.cpp:
1897         (LayoutTestController::LayoutTestController):
1898         (LayoutTestController::setOverrideIndexedDBBackingStore):
1899         (LayoutTestController::clearAllDatabases):
1900         * DumpRenderTree/chromium/LayoutTestController.h:
1901
1902 2011-05-24  Robert Hogan  <robert@webkit.org>
1903
1904         Reviewed by Ryosuke Niwa.
1905
1906         [Qt] Fix fast/events/selectstart-by-single-click-with-shift.html
1907         https://bugs.webkit.org/show_bug.cgi?id=61393
1908
1909         * DumpRenderTree/qt/EventSenderQt.h:
1910         * DumpRenderTree/qt/EventSenderQt.cpp:
1911         (getModifiers): static function for interpreting modifiers
1912         (EventSender::mouseDown): Respect keyboard modifiers
1913         (EventSender::keyDown): use new static function
1914         (EventSender::sendOrQueueEvent): whitespace fix
1915
1916 2011-05-24  Jay Civelli  <jcivelli@chromium.org>
1917
1918         Reviewed by Adam Barth.
1919
1920         Adding MHTML reading support.
1921         https://bugs.webkit.org/show_bug.cgi?id=7168
1922
1923         * Scripts/build-webkit:
1924         * Scripts/old-run-webkit-tests:
1925         * Scripts/webkitperl/features.pm:
1926         * Scripts/webkitpy/layout_tests/port/test_files.py:
1927         * Scripts/webkitpy/layout_tests/port/webkit.py:
1928
1929 2011-05-24  Stephen White  <senorblanco@chromium.org>
1930
1931         Reviewed by Kenneth Russell.
1932
1933         Remove most style checks on Source/ThirdParty/glu, since it doesn't
1934         follow WebKit style.
1935         https://bugs.webkit.org/show_bug.cgi?id=61365
1936
1937         * Scripts/webkitpy/style/checker.py:
1938
1939 2011-05-24  Adam Roben  <aroben@apple.com>
1940
1941         Don't allow forcing builds through the build.webkit.org web interface
1942
1943         Someone has been forcing bogus builds.
1944
1945         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1946
1947 2011-05-24  Qi Zhang  <qi.2.zhang@nokia.com>
1948
1949         Reviewed by Adam Roben.
1950
1951         WebKitTestRunner needs layoutTestController.setJavaScriptCanAccessClipboard
1952         https://bugs.webkit.org/show_bug.cgi?id=42669
1953
1954         Fixes the regression issue caused by patch 94265. The patch didn't intialize the setting before the 
1955         layouttest starting, it will make the test cases after editing/execCommand/clipboard-access.html failed.
1956         Because that case changed the setting.
1957
1958         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1959         (WTR::InjectedBundle::beginTesting):
1960
1961 2011-05-24  Csaba Osztrogonác  <ossy@webkit.org>
1962
1963         Reviewed by Kenneth Rohde Christiansen.
1964
1965         [ORWT]Make --skipped=only option work with parameters with LayoutTests/ prefix
1966         https://bugs.webkit.org/show_bug.cgi?id=61052
1967
1968         * Scripts/old-run-webkit-tests:
1969
1970 2011-05-24  Adam Roben  <aroben@apple.com>
1971
1972         Make TestFailures show how many tests are failing on each tester, and omit testers with no failures
1973
1974         Fixes <http://webkit.org/b/61063> <rdar://problem/9460533> TestFailures page shows testers
1975         that don't have any failing tests, which isn't useful
1976
1977         Reviewed by David Kilzer.
1978
1979         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js:
1980         (Buildbot.prototype.getTesters): Renamed from getTesterNames. Now returns Builder objects
1981         instead of name strings.
1982         (Buildbot.prototype._buildersForNames): Added. Helper function to convert an array of
1983         builder names into an array of builders.
1984
1985         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
1986         (Builder.prototype.getMostRecentCompletedBuildNumber): Added. Returns the build number of
1987         the most recently completed build, or -1 if there is no such build.
1988         (Builder.prototype.getNumberOfFailingTests): Added. Returns the number of tests that failed
1989         in the given build, or -1 if the number could not be determined. Some of this code came from
1990         _getFailingTests.
1991         (Builder.prototype._getBuildJSON): Added. Code came from _getFailingTests.
1992         (Builder.prototype._getFailingTests): Changed to use new _getBuildJSON and
1993         getNumberOfFailingTests functions.
1994
1995         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1996         (ViewController.prototype._displayTesters): Get the current number of test failures for each
1997         tester and show it in the list. Omit testers that have no failures at all. We keep the
1998         testers and failure counts in an array and sort it before displaying the current data, as
1999         the order in which data will be fetched is unpredictable.
2000
2001 2011-05-23  Tony Chang  <tony@chromium.org>
2002
2003         Reviewed by Ojan Vafai.
2004
2005         [nrwt] don't use NetworkTranslation when uploading results
2006         https://bugs.webkit.org/show_bug.cgi?id=61315
2007
2008         This avoids autoinstalling mechanize.  It didn't matter anyway
2009         because test_results_uploader.py wasn't using mechanize to make the
2010         request so NetworkTransaction::run wasn't doing anything extra
2011         (it only matters if it catches mechanize.HTTPError).
2012
2013         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
2014
2015 2011-05-23  Tony Chang  <tony@chromium.org>
2016
2017         Reviewed by Dirk Pranke.
2018
2019         [chromium] fix the rebaseline tool to work with Linux GPU failures
2020         https://bugs.webkit.org/show_bug.cgi?id=61312
2021
2022         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2023
2024 2011-05-23  Darin Adler  <darin@apple.com>
2025
2026         Ignore generated .pyc files in a directory full of python code.
2027
2028         * Scripts/webkitpy/common/checkout/scm: Added property svn:ignore.
2029
2030 2011-05-23  Adam Barth  <abarth@webkit.org>
2031
2032         Reviewed by Eric Seidel.
2033
2034         sheriffbot should give more details about the failures in IRC
2035         https://bugs.webkit.org/show_bug.cgi?id=61233
2036
2037         With this patch, sheriffbot will annonce the set of failing tests,
2038         which might help folks triage the problem.
2039
2040         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2041         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
2042
2043 2011-05-23  Sheriff Bot  <webkit.review.bot@gmail.com>
2044
2045         Unreviewed, rolling out r87078.
2046         http://trac.webkit.org/changeset/87078
2047         https://bugs.webkit.org/show_bug.cgi?id=61294
2048
2049         Patch contains errors and seems likely to break a bunch of
2050         bots (Requested by abarth on #webkit).
2051
2052         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2053         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2054         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2055
2056 2011-05-23  Alice Boxhall  <aboxhall@chromium.org>
2057
2058         Reviewed by Ojan Vafai.
2059
2060         Convert json_results_generator.py to output version 4 JSON.
2061         https://bugs.webkit.org/show_bug.cgi?id=60869
2062
2063         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2064         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2065         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2066
2067 2011-05-23  Patrick Gansterer  <paroga@webkit.org>
2068
2069         Reviewed by Adam Barth.
2070
2071         Move generation of shell_command from port to executive
2072         https://bugs.webkit.org/show_bug.cgi?id=61251
2073
2074         After move it's possible to use the code in other places too.
2075
2076         * Scripts/webkitpy/common/config/ports.py:
2077         * Scripts/webkitpy/common/system/executive.py:
2078
2079 2011-05-23  Qi Zhang  <qi.2.zhang@nokia.com>
2080
2081         Reviewed by Darin Adler.
2082
2083         WebKitTestRunner needs layoutTestController.setJavaScriptCanAccessClipboard
2084         https://bugs.webkit.org/show_bug.cgi?id=42669
2085
2086         Implement setJavaScriptCanAccessClipboard in WebKitTestRunner.
2087
2088         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2089         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2090         (WTR::LayoutTestController::setJavaScriptCanAccessClipboard):
2091         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2092
2093 2011-05-22  Robert Hogan  <robert@webkit.org>
2094
2095         Reviewed by Kenneth Rohde Christiansen.
2096
2097         Fix policyDelegate in Qt DRT
2098         https://bugs.webkit.org/show_bug.cgi?id=61247
2099
2100         Use the 'policy delegate' implemented in FrameLoaderClient
2101         for layout tests. The partial implementation in DumpRenderTreeQt
2102         is redundant, so remove it.
2103
2104         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2105         (WebCore::WebPage::acceptNavigationRequest):
2106         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2107         (LayoutTestController::waitForPolicyDelegate):
2108
2109 2011-05-22  Patrick Gansterer  <paroga@webkit.org>
2110
2111         Reviewed by Darin Adler.
2112
2113         Use double quotes for filename arguments
2114         https://bugs.webkit.org/show_bug.cgi?id=61250
2115
2116         Windows does not support single quotes on the command line,
2117         so replace them with double quotes.
2118
2119         * Scripts/prepare-ChangeLog:
2120
2121 2011-05-20  Simon Fraser  <simon.fraser@apple.com>
2122
2123         Reviewed by Sam Weinig.
2124
2125         WebKitTestRunner needs layoutTestController.pauseTransitionAtTimeOnElementWithId
2126         https://bugs.webkit.org/show_bug.cgi?id=42550
2127         
2128         Implement pauseTransitionAtTimeOnElementWithId in WebKitTestRunner.
2129
2130         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2131         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2132         Copy the code for pausing animations, FIXME comments and all.
2133         (WTR::LayoutTestController::pauseTransitionAtTimeOnElementWithId):
2134         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2135
2136 2011-05-20  Alok Priyadarshi  <alokp@chromium.org>
2137
2138         Reviewed by Stephen White.
2139
2140         Adding myself to the committers list.
2141
2142         * Scripts/webkitpy/common/config/committers.py:
2143
2144 2011-05-19  Adam Roben  <aroben@apple.com>
2145
2146         Test that the WebKit2 UI process doesn't crash when starting a download
2147
2148         Test for <http://webkit.org/b/61142> <rdar://problem/9471680> REGRESSION (r86812): Crash
2149         (preceded by assertion) in fastMalloc when downloading a file
2150
2151         Reviewed by Darin Adler.
2152
2153         * TestWebKitAPI/Tests/WebKit2/18-characters.html: Added.
2154
2155         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp: Added.
2156         (TestWebKitAPI::decidePolicyForNavigationAction): Start a download.
2157         (TestWebKitAPI::decideDestinationWithSuggestedFilename): Record that the download was
2158         started, cancel the download, and return a bogus string.
2159
2160         (TestWebKitAPI::setContextDownloadClient):
2161         (TestWebKitAPI::setPagePolicyClient):
2162         Simple helper functions.
2163
2164         (TestWebKitAPI::TEST): Load 18-characters.html, which should trigger a download thanks to
2165         our policy client, and run until we know that the download was started. If we haven't
2166         crashed, we win!
2167
2168         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2169         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2170         * TestWebKitAPI/win/copy-resources.cmd:
2171         Added new files.
2172
2173 2011-05-20  Kent Tamura  <tkent@chromium.org>
2174
2175         Reviewed by Ryosuke Niwa.
2176
2177         Fix style errors in DumpRenderTree/chromium/.
2178         https://bugs.webkit.org/show_bug.cgi?id=61172
2179
2180         * DumpRenderTree/chromium/CppBoundClass.cpp:
2181         (CppBoundClass::getAsCppVariant):
2182         (CppBoundClass::bindToJavascript):
2183         * DumpRenderTree/chromium/CppBoundClass.h:
2184         (CppBoundClass::GetterCallback::~GetterCallback):
2185         (CppBoundClass::CppBoundClass):
2186         (CppBoundClass::Callback::~Callback):
2187         (CppBoundClass::MemberCallback::MemberCallback):
2188         (CppBoundClass::MemberCallback::~MemberCallback):
2189         (CppBoundClass::MemberGetterCallback::MemberGetterCallback):
2190         (CppBoundClass::MemberGetterCallback::~MemberGetterCallback):
2191         * DumpRenderTree/chromium/CppVariant.h:
2192         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2193         (DRTDevToolsAgent::~DRTDevToolsAgent):
2194         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
2195         (DRTDevToolsClient::sendFrontendLoaded):
2196         * DumpRenderTree/chromium/DRTDevToolsClient.h:
2197         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2198         (main):
2199         * DumpRenderTree/chromium/EventSender.cpp:
2200         (SavedEvent::SavedEvent):
2201         (EventSender::EventSender):
2202         (EventSender::keyDown):
2203         * DumpRenderTree/chromium/EventSender.h:
2204         * DumpRenderTree/chromium/ImageDiff.cpp:
2205         (Image::Image):
2206         * DumpRenderTree/chromium/LayoutTestController.cpp:
2207         (LayoutTestController::LayoutTestController):
2208         (LayoutTestController::WorkQueue::reset):
2209         (WorkItemBackForward::WorkItemBackForward):
2210         (WorkItemLoadingScript::WorkItemLoadingScript):
2211         (WorkItemNonLoadingScript::WorkItemNonLoadingScript):
2212         (WorkItemLoad::WorkItemLoad):
2213         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
2214         (LayoutTestController::pathToLocalResource):
2215         * DumpRenderTree/chromium/LayoutTestController.h:
2216         (LayoutTestController::WorkItem::~WorkItem):
2217         (LayoutTestController::WorkQueue::WorkQueue):
2218         * DumpRenderTree/chromium/MockSpellCheck.cpp:
2219         (MockSpellCheck::MockSpellCheck):
2220         (MockSpellCheck::~MockSpellCheck):
2221         * DumpRenderTree/chromium/MockSpellCheck.h:
2222         * DumpRenderTree/chromium/NotificationPresenter.h:
2223         (NotificationPresenter::NotificationPresenter):
2224         * DumpRenderTree/chromium/Task.cpp:
2225         (WebTask::WebTask):
2226         * DumpRenderTree/chromium/Task.h:
2227         (TaskList::TaskList):
2228         * DumpRenderTree/chromium/TestEventPrinter.cpp:
2229         (DRTPrinter::DRTPrinter):
2230         (TestShellPrinter::TestShellPrinter):
2231         * DumpRenderTree/chromium/TestNavigationController.cpp:
2232         (TestNavigationEntry::TestNavigationEntry):
2233         (TestNavigationEntry::~TestNavigationEntry):
2234         (TestNavigationController::TestNavigationController):
2235         (TestNavigationController::reload):
2236         (TestNavigationController::loadEntry):
2237         (TestNavigationController::didNavigateToEntry):
2238         * DumpRenderTree/chromium/TestNavigationController.h:
2239         (TestShellExtraData::TestShellExtraData):
2240         * DumpRenderTree/chromium/TestShell.cpp:
2241         (dumpHistoryItem):
2242         * DumpRenderTree/chromium/TestShell.h:
2243         (TestParams::TestParams):
2244         * DumpRenderTree/chromium/TestShellWin.cpp:
2245         (TestShell::waitTestFinished):
2246         * DumpRenderTree/chromium/TestWebWorker.h:
2247         (TestWebWorker::startWorkerContext):
2248         (TestWebWorker::terminateWorkerContext):
2249         (TestWebWorker::postMessageToWorkerContext):
2250         (TestWebWorker::clientDestroyed):
2251         (TestWebWorker::postMessageToWorkerObject):
2252         (TestWebWorker::postExceptionToWorkerObject):
2253         (TestWebWorker::postConsoleMessageToWorkerObject):
2254         (TestWebWorker::confirmMessageFromWorkerObject):
2255         (TestWebWorker::reportPendingActivity):
2256         (TestWebWorker::workerContextClosed):
2257         (TestWebWorker::~TestWebWorker):
2258         * DumpRenderTree/chromium/TextInputController.cpp:
2259         * DumpRenderTree/chromium/WebThemeControlDRTWin.h:
2260         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
2261         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
2262         (WebThemeEngineDRTWin::paintButton):
2263         (WebThemeEngineDRTWin::paintMenuList):
2264         (WebThemeEngineDRTWin::paintTrackbar):
2265         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h:
2266         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
2267         * DumpRenderTree/chromium/WebViewHost.cpp:
2268         (WebViewHost::navigate):
2269         (WebViewHost::updateSessionHistory):
2270         (WebViewHost::paintInvalidatedRegion):
2271         * DumpRenderTree/chromium/WebViewHost.h:
2272
2273 2011-05-19  Dmitry Lomov  <dslomov@google.com>
2274
2275         Reviewed by Adam Roben.
2276
2277         Detect hangs in run-api-tests
2278         https://bugs.webkit.org/show_bug.cgi?id=48043
2279
2280         * Scripts/run-api-tests: Added test timeouts
2281
2282 2011-05-19  Dmitry Lomov  <dslomov@google.com>
2283
2284         Reviewed by Adam Roben.
2285
2286         run-api-tests should run one test per process
2287         https://bugs.webkit.org/show_bug.cgi?id=61088
2288
2289         * Scripts/run-api-tests: Resurrecting the previous revison of this file, with fixes to system call under Windows, 
2290         return code, and parsing GTest output format.
2291
2292 2011-05-15  Robert Hogan  <robert@webkit.org>
2293
2294         Reviewed by Antonio Gomes.
2295
2296         [Qt][GTK] plugins/get-url-with-javascript-url.html fails
2297         https://bugs.webkit.org/show_bug.cgi?id=60834
2298         Fix unix test plugin for plugins/get-url-with-javascript-url.html
2299
2300         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2301         (webkit_test_plugin_new_stream):
2302         (webkit_test_plugin_write_ready):
2303         (webkit_test_plugin_write):
2304
2305 2011-05-19  Sheriff Bot  <webkit.review.bot@gmail.com>
2306
2307         Unreviewed, rolling out r86869, r86873, r86875, and r86877.
2308         http://trac.webkit.org/changeset/86869
2309         http://trac.webkit.org/changeset/86873
2310         http://trac.webkit.org/changeset/86875
2311         http://trac.webkit.org/changeset/86877
2312         https://bugs.webkit.org/show_bug.cgi?id=61139
2313
2314         broke builds and debug DRT (Requested by rniwa on #webkit).
2315
2316         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2317         * DumpRenderTree/chromium/TestShell.cpp:
2318         (TestShell::bindJSObjectsToWindow):
2319         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2320         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
2321
2322 2011-05-18  Dimitri Glazkov  <dglazkov@chromium.org>
2323
2324         Reviewed by Darin Adler.
2325
2326         Add build logistics and plumbing for window.internals object.
2327         https://bugs.webkit.org/show_bug.cgi?id=60313
2328
2329         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linking new WebCoreTestSupport library.
2330         * DumpRenderTree/chromium/TestShell.cpp:
2331         (TestShell::bindJSObjectsToWindow): Added injection code.
2332         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2333         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): Ditto.
2334
2335 2011-05-19  Zsolt Fehér  <h490267@stud.u-szeged.hu>
2336
2337         Reviewed by Csaba Osztrogonác.
2338
2339         [Qt] Implement eventSender.scalePageBy
2340         https://bugs.webkit.org/show_bug.cgi?id=60015
2341
2342         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2343         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2344         * DumpRenderTree/qt/EventSenderQt.cpp:
2345         (EventSender::scalePageBy):
2346         * DumpRenderTree/qt/EventSenderQt.h:
2347
2348 2011-05-19  Kenichi Ishibashi  <bashi@chromium.org>
2349
2350         Reviewed by Kent Tamura.
2351
2352         [Chromium] IME candidate window appears wrong position in an iframe
2353         https://bugs.webkit.org/show_bug.cgi?id=61023
2354
2355         Call the focused frame's firstRectForCharacterRange() instead of the
2356         main frame so that DRT behaves as the same as Chromium.
2357
2358         * DumpRenderTree/chromium/TextInputController.cpp:
2359         (TextInputController::firstRectForCharacterRange):
2360
2361 2011-05-18  Adam Roben  <aroben@apple.com>
2362
2363         Add a new page to build.webkit.org to help find when tests started failing
2364
2365         The page is accessible at <http://build.webkit.org/TestFailures/>. It is pretty minimalist
2366         right now, but already shows some useful information. It's somewhat similar to webkit-patch
2367         failure-reason and sheriffbot, and perhaps can be combined with them eventually. It's a
2368         little more convenient than either of them, though, because it's all done in the browser
2369         (and thus it's easy to go directly to the relevant test results).
2370
2371         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js: Added.
2372         (Buildbot): This class represents a Buildbot server.
2373         (Buildbot.prototype.buildURL): Returns the URL for the summary page for a particular build.
2374         (Buildbot.prototype.builderNamed): Returns a Builder with the given name.
2375         (Buildbot.prototype.getTesterNames): Fetches the names of all testers and passes them to the
2376         callback.
2377         (Buildbot.prototype.parseBuildName): Breaks up a build name into its constituent parts. Must
2378         be implemented by a derived class that understands this server's build naming scheme.
2379         (Buildbot.prototype.resultsDirectoryURL): Returns the URL for the results directory for a
2380         particular build.
2381
2382         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js: Added.
2383         (Builder): This class represents one builder on the buildbot.
2384         (Builder.prototype.buildURL): Returns the URL for the summary page for a particular build.
2385         (Builder.prototype.failureDiagnosisTextAndURL): Returns data that provides a little more
2386         information about a particular test failure.
2387         (Builder.prototype.startFetchingBuildHistory): Periodically calls the callback with
2388         information about when tests started failing.
2389         (Builder.prototype.resultsDirectoryURL): Returns the URL for the results directory for a
2390         particular build.
2391         (Builder.prototype._getBuildNames): Fetches the names of all builds and passes them to the
2392         callback.
2393         (Builder.prototype._getFailingTests): Fetches the results.html page for the given build and
2394         extracts all the failing tests listed in it, passing them to the callback.
2395         (Builder.prototype._incorporateBuildHistory): Gets the failing tests for the specified
2396         build, merges them into the build history, and calls the callback telling it whether the
2397         next build should be fetched to provide more information.
2398
2399         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
2400         Added. Just some simple styles.
2401
2402         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js: Added.
2403         (createDefinitionList): Takes an array of pairs and turns them into a DL element.
2404         (getResource): Wrapper around XMLHttpRequest.
2405         (Array.prototype.findFirst): Finds the first element matching the given predicate and
2406         returns it.
2407         (Array.prototype.last): Returns the last element of the array.
2408
2409         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js: Added.
2410         (ViewController): This class contains the main logic for displaying the page.
2411         (ViewController.loaded): Just calls through to parseHash.
2412         (ViewController.parseHash): Either starts analyzing failures on a particular builder, or
2413         shows the list of all testers so one can be chosen. This function is called when the page
2414         loads and whenever we get a hashchange event.
2415         (ViewController._displayBuilder): Asks the builder to fetch build history, and displays it
2416         as it is fetched. The display ends up grouping tests by when they started failing.
2417         (ViewController._displayTesters): Gets the list of testers and displays it.
2418
2419         (ViewController._domForBuildName):
2420         (ViewController._domForFailedTest):
2421         Helper functions to create descriptions and links for a particular build or failed test.
2422
2423         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBuildbot.js: Added.
2424         (WebKitBuildbot): Calls up to the base class constructor with the correct base URL.
2425         (WebKitBuildbot.prototype.parseBuildName): Parses a build.webkit.org-style build name.
2426
2427         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Added. Just
2428         loads all the files and sets up a ViewController, which does the rest.
2429
2430         * BuildSlaveSupport/build.webkit.org-config/templates/root.html: Added a link to the new
2431         page.
2432
2433 2011-05-18  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
2434
2435         Reviewed by Csaba Osztrogonác.
2436
2437         [Qt] Implement layoutTestController.setValueForUser()
2438         https://bugs.webkit.org/show_bug.cgi?id=60956
2439
2440         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2441         (LayoutTestController::setValueForUser):
2442         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2443
2444 2011-05-16  Robert Hogan  <robert@webkit.org>
2445
2446         Reviewed by Kenneth Rohde Christiansen.
2447
2448         plugins/invalidate_rect.html fails on linux ports
2449
2450         - Make the unix test netscape plugin recognize the onPaintEvent
2451           and windowedPlugin parameters.
2452
2453         https://bugs.webkit.org/show_bug.cgi?id=54051
2454
2455         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2456         (handleEventX11):
2457         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2458         (LayoutTestController::displayInvalidatedRegion):
2459         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2460         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2461         (webkit_test_plugin_new_instance):
2462         (webkit_test_plugin_handle_event):
2463
2464 2011-05-17  Tony Chang  <tony@chromium.org>
2465
2466         Reviewed by Ojan Vafai.
2467
2468         [chromium] move Lucid 64 bit results into LayoutTests/platform/chromium-linux
2469         https://bugs.webkit.org/show_bug.cgi?id=60895
2470
2471         Update the tools to handle the move.  Lucid 32 results now go in
2472         chromium-linux-x86 and the default platform on Linux is now x86_64.
2473
2474         * Scripts/webkitpy/layout_tests/deduplicate_tests.py: Default to x86_64
2475         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
2476         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: Default to Lucid
2477         * Scripts/webkitpy/layout_tests/port/base.py: ditto
2478         * Scripts/webkitpy/layout_tests/port/chromium_linux.py: Update directory fallback and default to Lucid 64
2479         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
2480         * Scripts/webkitpy/layout_tests/port/test.py: Update tests to default to x86_64
2481         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Update bot names.
2482         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py: Whitespace cleanup.
2483
2484 2011-05-17  Adam Roben  <aroben@apple.com>
2485
2486         Make run-api-tests work on Windows when there are spaces in the path
2487
2488         Fixes <http://webkit.org/b/60954> REGRESSION (r86511): run-api-tests fails if there are
2489         spaces in the path to TestWebKitAPI.exe
2490
2491         Reviewed by David Levin.
2492
2493         * Scripts/run-api-tests:
2494         (runTestTool): Use the "direct object" form of system() to avoid having the path to
2495         TestWebKitAPI.exe be split by the shell.
2496
2497 2011-05-16  Ian Henderson  <ianh@apple.com>
2498
2499         Reviewed by Joseph Pecoraro.
2500
2501         Page::goToItem doesn't work while loading is deferred
2502         https://bugs.webkit.org/show_bug.cgi?id=60412
2503
2504         Add setDefersLoading and goBack methods to LayoutTestController.  We
2505         need to use goBack() instead of history.back() because the latter goes
2506         through NavigationScheduler, hence doesn't exhibit the bug.
2507
2508         * DumpRenderTree/LayoutTestController.cpp:
2509         (goBackCallback):
2510         (setDefersLoadingCallback):
2511         (LayoutTestController::staticFunctions):
2512         * DumpRenderTree/LayoutTestController.h:
2513         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2514         (LayoutTestController::goBack):
2515         (LayoutTestController::setDefersLoading):
2516         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2517         (LayoutTestController::goBack):
2518         (LayoutTestController::setDefersLoading):
2519         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2520         (LayoutTestController::goBack):
2521         (LayoutTestController::setDefersLoading):
2522         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2523         (LayoutTestController::goBack):
2524         (LayoutTestController::setDefersLoading):
2525
2526 2011-05-16  Sam Weinig  <sam@webkit.org>
2527
2528         Reviewed by Anders Carlsson.
2529
2530         TestWebKitAPI should build with clang if it can
2531         https://bugs.webkit.org/show_bug.cgi?id=60918
2532
2533         * TestWebKitAPI/Configurations/CompilerVersion.xcconfig:
2534         Update CompilerVersion.xcconfig to match others.
2535
2536         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2537         Add CompilerVersion.xcconfig to the project.
2538
2539         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
2540         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
2541         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2542         (TestWebKitAPI::didSameDocumentNavigationForFrame):
2543         Add some casts to quiet warnings from clang.
2544
2545 2011-05-16  Dirk Pranke  <dpranke@chromium.org>
2546
2547         Reviewed by David Levin.
2548
2549         add dpranke as a reviewer
2550         https://bugs.webkit.org/show_bug.cgi?id=60919
2551
2552         * Scripts/webkitpy/common/config/committers.py:
2553
2554 2011-05-16  Robert Hogan  <robert@webkit.org>
2555
2556         Reviewed by Anders Carlsson.
2557
2558         [Gtk] plugins/get-url-notify-with-url-that-fails-to-load.html crashes on buildbot
2559
2560         https://bugs.webkit.org/show_bug.cgi?id=60838
2561
2562         The unix test plugin needs to call the test's NPP_URLNotify
2563         rather than the browsers.
2564
2565         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2566         (webkit_test_plugin_url_notify):
2567
2568 2011-05-16  Brent Fulgham  <bfulgham@webkit.org>
2569
2570         Rubber-stamped by Adam Roben.
2571
2572         Adding myself as a reviewer.
2573         * Scripts/webkitpy/common/config/committers.py:
2574
2575 2011-05-16  Sam Weinig  <sam@webkit.org>
2576
2577         Fix typo pointed out by Dave Levin.
2578
2579         * TestWebKitAPI/PlatformUtilities.h:
2580         (TestWebKitAPI::Util::assertWKStringEqual):
2581         Strig -> String.
2582
2583 2011-05-16  Sam Weinig  <sam@webkit.org>
2584
2585         Reviewed by David Levin.
2586
2587         Convert api tester over to using gtest expectations directly
2588         https://bugs.webkit.org/show_bug.cgi?id=60862
2589
2590         * TestWebKitAPI/PlatformUtilities.cpp:
2591         (TestWebKitAPI::Util::toSTD):
2592         * TestWebKitAPI/PlatformUtilities.h:
2593         (TestWebKitAPI::Util::assertWKStrigEqual):
2594         Add convenience macro to compare WK2 strings. Add some overloads of toSTD to make
2595         the implementation of the macro simpler.
2596
2597         * TestWebKitAPI/Test.h:
2598         Remove TEST_ASSERT forwarder.
2599
2600         [Test changes elided]
2601
2602 2011-05-16  David Kilzer  <ddkilzer@apple.com>
2603
2604         <http://webkit.org/b/60913> C++ exceptions should not be enabled when building with llvm-gcc-4.2
2605         <rdar://problem/9446430>
2606
2607         Reviewed by Mark Rowe.
2608
2609         * MiniBrowser/Configurations/Base.xcconfig: Fixed typo.
2610         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
2611         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
2612
2613 2011-05-16  Jon Lee  <jonlee@apple.com>
2614
2615         Reviewed by Simon Fraser.
2616
2617         Can't horizontally scroll iframes and overflow because wheel events are always accepted
2618         https://bugs.webkit.org/show_bug.cgi?id=60779
2619
2620         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2621         (WTR::InjectedBundlePage::InjectedBundlePage): Set new default method to nil.
2622
2623 2011-05-16  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>
2624
2625         Reviewed by Csaba Osztrogonác.
2626
2627         [Qt] Tools.pro misses include(common.pri)
2628         https://bugs.webkit.org/show_bug.cgi?id=60883
2629
2630         It includes features.pri, which depends on common.pri (the build is
2631         not broken today with the default options, but this is the right
2632         thing to do).
2633
2634         * Tools.pro:
2635
2636 2011-05-15  Dominic Cooney  <dominicc@chromium.org>
2637
2638         Unreviewed: adding myself to committers.py.
2639
2640         * Scripts/webkitpy/common/config/committers.py:
2641
2642 2011-05-15  Daniel Bates  <dbates@webkit.org>
2643
2644         Reviewed by Chris Jerdonek.
2645
2646         svn-apply can't handle Git diff that only changes executable bit
2647         https://bugs.webkit.org/show_bug.cgi?id=60848
2648
2649         Fixes an issue where svn-{apply, unapply} fail to handle a Git diff for a file
2650         that only has an executable bit change.
2651
2652         * Scripts/VCSUtils.pm:
2653           - Modified regex $chunkRangeRegEx to match chunk range with ending text, say: @@ -2,6 +2,18 @@ foo().
2654         (parseDiff): Modified to count the number of text chunks in the diff. This should also help towards
2655         fixing <https://bugs.webkit.org/show_bug.cgi?id=29684>.
2656         * Scripts/svn-apply:
2657         (patch): Only use standard patch tool if the patch is non-empty and for a text file (i.e. not a binary patch).
2658         * Scripts/svn-unapply:
2659         (patch): Ditto.
2660         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
2661           - Updated expected results for test cases to account for numTextChunks.
2662           - Fixed malformed chunk range in test cases: "Git: simple", and "Git: Git diff followed by SVN diff".
2663           - Added test case "Git: file that only has an executable bit change".
2664         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
2665           - Updated expected results for test cases to account for numTextChunks.
2666
2667 2011-05-15  Sam Weinig  <sam@webkit.org>
2668
2669         Fix windows build.
2670
2671         * TestWebKitAPI/win/main.cpp:
2672         (main):
2673
2674 2011-05-15  Sam Weinig  <sam@webkit.org>
2675
2676         Reviewed by David Levin.
2677
2678         Make API tester more gtest friendly
2679         https://bugs.webkit.org/show_bug.cgi?id=60859
2680
2681         * Scripts/run-api-tests:
2682         Numerous changes:
2683         - Remove logic to run tests one at a time.
2684         - Remove logic to build up a list of tests, instead just pass --gtest_list_tests to 
2685           the test runner and allow gtest to print it for us.
2686         - Forward stdout from the test tool to stdout, even in non-verbose runs.
2687         - Run test tool from the current working directory instead of the root webkit
2688           directory.
2689
2690         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2691         Move plist to be with other bundle sources.
2692
2693         * TestWebKitAPI/TestsController.cpp:
2694         (TestWebKitAPI::TestsController::TestsController):
2695         (TestWebKitAPI::TestsController::run):
2696         * TestWebKitAPI/TestsController.h:
2697         * TestWebKitAPI/mac/main.mm:
2698         Simplify TestController down to a single run function. We should consider removing the class
2699         entirely at some point.
2700
2701 2011-05-15  Sheriff Bot  <webkit.review.bot@gmail.com>
2702
2703         Unreviewed, rolling out r86504.
2704         http://trac.webkit.org/changeset/86504
2705         https://bugs.webkit.org/show_bug.cgi?id=60853
2706
2707         "Broke Qt EventSender in editing/selection tests" (Requested
2708         by mwenge on #webkit).
2709
2710         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2711         (WebCore::WebPage::WebPage):
2712         (WebCore::DumpRenderTree::DumpRenderTree):
2713         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2714         (WebCore::DumpRenderTree::initJSObjects):
2715         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2716         (WebCore::DumpRenderTree::eventSender):
2717         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2718         (webkit_test_plugin_new_instance):
2719         (webkit_test_plugin_set_window):
2720         (webkit_test_plugin_handle_event):
2721
2722 2011-05-12  Robert Hogan  <robert@webkit.org>
2723
2724         Reviewed by Benjamin Poulain.
2725
2726         [Qt] fix http/tests/plugins/plugin-document-has-focus.html
2727
2728         The support for this test added to the unix test plugin here
2729         may allow other platforms to pass it (nearly everyone
2730         skips it). On Qt it required a bit of trickiness with
2731         the page's EventSender object to get it working fully though,
2732         so only unskipping Qt here.
2733
2734         https://bugs.webkit.org/show_bug.cgi?id=60722
2735
2736         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2737         (WebCore::WebPage::WebPage):
2738         (WebCore::WebPage::eventSender):
2739         (WebCore::DumpRenderTree::DumpRenderTree):
2740         (WebCore::DumpRenderTree::initJSObjects):
2741         (WebCore::DumpRenderTree::createWindow):
2742         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2743         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2744         (webkit_test_plugin_new_instance):
2745         (webkit_test_plugin_set_window):
2746         (webkit_test_plugin_handle_event):
2747
2748 2011-05-14  Arno Renevier  <arno@renevier.net>
2749
2750         Reviewed by Martin Robinson.
2751
2752         make run-gtk-tests executable
2753         https://bugs.webkit.org/show_bug.cgi?id=59278
2754
2755         * Scripts/run-gtk-tests:
2756
2757 2011-05-14  Anders Carlsson  <andersca@apple.com>
2758
2759         Reviewed by Kevin Decker.
2760
2761         NPP_URLNotify is not called if a URL passed to NPN_GetURLNotify fails to load
2762         https://bugs.webkit.org/show_bug.cgi?id=60823
2763         <rdar://problem/9430386>
2764
2765         Add test that calls NPN_GetURLNotify on a URL that can't be loaded, and checks if NPP_URLNotify is called.
2766
2767         * DumpRenderTree/DumpRenderTree.gypi:
2768         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2769         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLNotifyWithURLThatFailsToLoad.cpp: Added.
2770         (GetURLNotifyWithURLThatFailsToLoad::GetURLNotifyWithURLThatFailsToLoad):
2771         (GetURLNotifyWithURLThatFailsToLoad::NPP_New):
2772         (GetURLNotifyWithURLThatFailsToLoad::NPP_URLNotify):
2773         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2774         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2775         * GNUmakefile.am:
2776
2777 2011-05-14  Sheriff Bot  <webkit.review.bot@gmail.com>
2778
2779         Unreviewed, rolling out r86476.
2780         http://trac.webkit.org/changeset/86476
2781         https://bugs.webkit.org/show_bug.cgi?id=60832
2782
2783         It made plugins/get-url-notify-with-url-that-fails-to-
2784         load.html crash on GTK (Requested by Ossy on #webkit).
2785
2786         * DumpRenderTree/DumpRenderTree.gypi:
2787         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2788         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLNotifyWithURLThatFailsToLoad.cpp: Removed.
2789         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2790         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2791         * GNUmakefile.am:
2792
2793 2011-05-13  Anders Carlsson  <andersca@apple.com>
2794
2795         Reviewed by Sam Weinig.
2796
2797         NPP_URLNotify is not called if a URL passed to NPN_GetURLNotify fails to load
2798         https://bugs.webkit.org/show_bug.cgi?id=60823
2799         <rdar://problem/9430386>
2800
2801         Add test that calls NPN_GetURLNotify on a URL that can't be loaded, and checks if NPP_URLNotify is called.
2802
2803         * DumpRenderTree/DumpRenderTree.gypi:
2804         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2805         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLNotifyWithURLThatFailsToLoad.cpp: Added.
2806         (GetURLNotifyWithURLThatFailsToLoad::GetURLNotifyWithURLThatFailsToLoad):
2807         (GetURLNotifyWithURLThatFailsToLoad::NPP_New):
2808         (GetURLNotifyWithURLThatFailsToLoad::NPP_URLNotify):
2809         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2810         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2811         * GNUmakefile.am:
2812
2813 2011-05-13  Anders Carlsson  <andersca@apple.com>
2814
2815         Build fix.
2816
2817         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLWithJavaScriptURL.cpp:
2818
2819 2011-05-13  Anders Carlsson  <andersca@apple.com>
2820
2821         Reviewed by Sam Weinig.
2822
2823         NPN_GetURL with a javascript: URL doesn't send back the result in the stream
2824         https://bugs.webkit.org/show_bug.cgi?id=60810
2825
2826         Add a test that calls NPN_GetURL on a javascript: URL and checks that it gets back the expected result.
2827
2828         * DumpRenderTree/DumpRenderTree.gypi:
2829         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2830         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2831         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2832         * GNUmakefile.am:
2833         Add files.
2834
2835         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2836         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2837         Add new NPN and NPP wrappers and sort them according to the order they appear in npfunctions.h
2838
2839         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLWithJavaScriptURL.cpp: Added.
2840         (GetURLWithJavaScriptURL::GetURLWithJavaScriptURL):
2841         (GetURLWithJavaScriptURL::NPP_New):
2842         (GetURLWithJavaScriptURL::NPP_NewStream):
2843         (GetURLWithJavaScriptURL::NPP_DestroyStream):
2844         (GetURLWithJavaScriptURL::NPP_WriteReady):
2845         (GetURLWithJavaScriptURL::NPP_Write):
2846         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2847         (NPP_NewStream):
2848         (NPP_WriteReady):
2849         (NPP_Write):
2850         (NPP_URLNotify):
2851         call the PluginTest NPP wrappers.
2852
2853 2011-05-13  Sheriff Bot  <webkit.review.bot@gmail.com>
2854
2855         Unreviewed, rolling out r86447.
2856         http://trac.webkit.org/changeset/86447
2857         https://bugs.webkit.org/show_bug.cgi?id=60809
2858
2859         "Broke some uses of EventSender object on Qt" (Requested by
2860         mwenge on #webkit).
2861
2862         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2863         (WebCore::WebPage::WebPage):
2864         (WebCore::DumpRenderTree::DumpRenderTree):
2865         (WebCore::DumpRenderTree::initJSObjects):
2866         (WebCore::DumpRenderTree::createWindow):
2867         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2868         (WebCore::DumpRenderTree::eventSender):
2869         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2870         (webkit_test_plugin_new_instance):
2871         (webkit_test_plugin_set_window):
2872         (webkit_test_plugin_handle_event):
2873
2874 2011-05-13  Robert Hogan  <robert@webkit.org>
2875
2876         Reviewed by Benjamin Poulain.
2877
2878         [Qt] fix http/tests/plugins/plugin-document-has-focus.html
2879
2880         The support for this test added to the unix test plugin here
2881         may allow other platforms to pass it (nearly everyone
2882         skips it). On Qt it required a bit of trickiness with
2883         the page's EventSender object to get it working fully though,
2884         so only unskipping Qt here.
2885
2886         https://bugs.webkit.org/show_bug.cgi?id=60722
2887
2888         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2889         (WebCore::WebPage::WebPage):
2890         (WebCore::WebPage::eventSender):
2891         (WebCore::DumpRenderTree::DumpRenderTree):
2892         (WebCore::DumpRenderTree::initJSObjects):
2893         (WebCore::DumpRenderTree::createWindow):
2894         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2895         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2896         (webkit_test_plugin_new_instance):
2897         (webkit_test_plugin_set_window):
2898         (webkit_test_plugin_handle_event):
2899
2900 2011-05-13  Adam Roben  <aroben@apple.com>
2901
2902         Exclude the Leopard NRWT bot from the core builder set
2903
2904         Fixes <http://webkit.org/b/60392> Leopard Intel Release (NRWT) shouldn't be a core builder
2905
2906         Reviewed by Darin Adler.
2907
2908         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2909         (BuildBot.__init__): Tighten up the Leopard regexp to only allow the non-NRWT Leopard bots
2910         in the core builder set.
2911
2912         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2913         (BuildBotTest.test_builder_name_regexps): Updated to match the current set of builders and
2914         regexps.
2915
2916 2011-05-13  Adam Roben  <aroben@apple.com>
2917
2918         Group all the NRWT bots together
2919
2920         This also gets the new NRWT bots out of the middle of Apple's bots. Since these new NRWT
2921         bots are experimental, it seems best not to clutter up the non-experimental bots with
2922         experimental ones.
2923
2924         Fixes <http://webkit.org/b/60769> New "(NRWT)" bots are right in the middle of Apple's bots
2925         on build.webkit.org
2926
2927         Reviewed by Dan Bernstein.
2928
2929         * BuildSlaveSupport/build.webkit.org-config/config.json: Moved the "(NRWT)" bots next to the
2930         Chromium testers, which also use new-run-webkit-tests.
2931
2932 2011-05-13  Adam Roben  <aroben@apple.com>
2933
2934         Add a plugin test that dumps the plugin window's rect
2935
2936         Part of the test for <http://webkit.org/b/60194> <rdar://problem/9383760> REGRESSION
2937         (r79167): Windowed plugins in Google Reader don't move when the article list is scrolled
2938
2939         Reviewed by Dan Bernstein.
2940
2941         * DumpRenderTree/TestNetscapePlugIn/Tests/win/DumpWindowRect.cpp: Added.
2942         (DumpWindowRect::DumpWindowRect): Just call up to the base class.
2943         (DumpWindowRect::performWindowGeometryTest): Find our window rect relative to the test
2944         harness window and log it.
2945
2946         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added DumpWindowRect.
2947
2948 2011-05-13  Adam Roben  <aroben@apple.com>
2949
2950         Move code required for most tests of plugin window geometry into a base class
2951
2952         WebKit2's asynchronous plugin window positioning makes testing window geometry tricky. By
2953         having all the trickiness in a shared base class, writing new window geometry tests will be
2954         much easier.
2955
2956         Fixes <http://webkit.org/b/60776> It's hard to write tests that check plugin window geometry
2957
2958         Reviewed by Anders Carlsson.
2959
2960         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowRegionIsSetToClipRect.cpp:
2961         (WindowRegionIsSetToClipRect::WindowRegionIsSetToClipRect): Changed to inherit from the new
2962         WindowGeometryTest base class. Most of the code from this class was moved to the new base
2963         class.
2964         (WindowRegionIsSetToClipRect::performWindowGeometryTest): Renamed from checkWindowRegion.
2965         This is called by the base class when it is safe to check the window's geometry. Note that
2966         the m_didCheckWindowRegion logic was removed completely; it has never been needed and was
2967         just vestigial code from an earlier version of this test.
2968
2969         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added new
2970         WindowGeometryTest class.
2971
2972         * DumpRenderTree/TestNetscapePlugIn/win/WindowGeometryTest.cpp: Added. Code came from
2973         WindowRegionIsSetToClipRect.
2974         (WindowGeometryTest::finishTest): This is the only change from WindowRegionIsSetToClipRect.
2975         We now call the new virtual performWindowGeometryTest function instead of checkWindowRegion.
2976         Subclasses can implement that function to perform their own tests.
2977
2978         * DumpRenderTree/TestNetscapePlugIn/win/WindowGeometryTest.h: Added.
2979
2980 2011-05-13  Zoltan Herczeg  <zherczeg@webkit.org>
2981
2982         Reviewed by Csaba Osztrogonác.
2983
2984         Missing 2nd #EOF if WebProcess is killed.
2985         https://bugs.webkit.org/show_bug.cgi?id=60761
2986
2987         If the WebProcess is killed, only one #EOF is yielded
2988         by WebKitTestRunner. However, run-webkit-test wait for
2989         a second #EOF, which signals the finishing of pixel dump.
2990         Since this never happens, run-webkit-test waits forever.
2991
2992         * WebKitTestRunner/TestInvocation.cpp:
2993         (WTR::TestInvocation::dump):
2994         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2995         * WebKitTestRunner/TestInvocation.h:
2996
2997 2011-05-13  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
2998
2999         Reviewed by Csaba Osztrogonác.
3000
3001         [NRWT] chromium-linux tests shouldn't run on other platforms
3002         https://bugs.webkit.org/show_bug.cgi?id=60162
3003
3004         Remove _tests_for_other_platforms defs because r82753
3005         implemented it properly in the baseclass in webkit.py.
3006
3007         * Scripts/webkitpy/layout_tests/port/gtk.py:
3008         * Scripts/webkitpy/layout_tests/port/qt.py:
3009         * Scripts/webkitpy/layout_tests/port/win.py:
3010
3011 2011-05-12  Ryuan Choi  <ryuan.choi@samsung.com>
3012
3013         Reviewed by Antonio Gomes.
3014
3015         [EFL] Remove unused option of EWeblauncher
3016         https://bugs.webkit.org/show_bug.cgi?id=60747
3017
3018         Remove sudo-workaround option.
3019         This option is not used and make other option wrong.
3020
3021         * EWebLauncher/main.c:
3022
3023 2011-05-12  Lucas Forschler  <lforschler@apple.com>
3024
3025         Reviewed by Stephanie Lewis.
3026
3027         Fix config.json to address missing WK2 builder/tester config.
3028         Fix naming of machines (xserve not macpro)
3029
3030         * BuildSlaveSupport/build.webkit.org-config/config.json:
3031
3032 2011-05-12  Lucas Forschler  <lforschler@apple.com>
3033
3034         Reviewed by Stephanie Lewis.
3035
3036         Add SnowLeopard Debug builder and Test bot.
3037         apple-xserve-8 = SL Debug Tester.
3038         apple-xserve-9 = SL Debug Builder.
3039         
3040         * BuildSlaveSupport/build.webkit.org-config/config.json:
3041
3042 2011-05-12  Adam Barth  <abarth@webkit.org>
3043
3044         This patch disables sheriffbot's bug postings.  He's just been way too
3045         spammy recently due to test flakiness.
3046
3047         * Scripts/webkitpy/tool/commands/sheriffbot.py:
3048         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
3049
3050 2011-05-11  Brian Weinstein  <bweinstein@apple.com>
3051
3052         Reviewed by Anders Carlsson.
3053
3054         After relaunching an unresponsive web process, web page stops responding to mouse movement
3055         https://bugs.webkit.org/show_bug.cgi?id=60669
3056         <rdar://problem/9409934>
3057         
3058         This test follows the steps needed to reproduce this bug:
3059         1) Hang the web process
3060         2) While the web process is hung, move the mouse (so WebPageProxy thinks it is processing a mouse move event)
3061         3) Kill and restart the WebProcess
3062         4) Move the mouse
3063         
3064         We are testing that we receive mouse move events after the WebProcess has restarted.
3065
3066         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp: Added.
3067         (TestWebKitAPI::didFinishLoadForFrame): Set a flag that we finished loading.
3068         (TestWebKitAPI::processDidBecomeUnresponsive): Kill the web process once we become unresponsive.
3069         (TestWebKitAPI::processDidCrash): Reload the page when the process crashes, which restarts the web process.
3070         (TestWebKitAPI::setPageLoaderClient):
3071         (TestWebKitAPI::TEST):
3072         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash_Bundle.cpp: Added.
3073         (TestWebKitAPI::MouseMoveAfterCrashTest::MouseMoveAfterCrashTest):
3074         (TestWebKitAPI::MouseMoveAfterCrashTest::didReceiveMessage):
3075         * TestWebKitAPI/Tests/WebKit2/mouse-move-listener.html: Added.
3076
3077         * TestWebKitAPI/PlatformWebView.h:
3078         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3079         (TestWebKitAPI::PlatformWebView::simulateMouseMove): Sends the messages that simulate a mouse move.
3080         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
3081         (TestWebKitAPI::PlatformWebView::simulateMouseMove): Ditto.
3082
3083         Add new files.
3084         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3085         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3086         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
3087         * TestWebKitAPI/win/copy-resources.cmd:
3088
3089 2011-05-12  Tomasz Morawski  <t.morawski@samsung.com>
3090
3091         Reviewed by Antonio Gomes.
3092
3093         [EFL] Added initialization/shutdown for ecore_file library
3094         https://bugs.webkit.org/show_bug.cgi?id=60457
3095
3096         Added initialization and shuthown for ecore_file library and replaced
3097         realpath function to ecore_file_realpath.
3098
3099         * EWebLauncher/main.c:
3100         (quit):
3101         (findThemePath):
3102         (main):
3103
3104 2011-05-12  Young Han Lee  <joybro@company100.net>
3105
3106         Reviewed by Kenneth Rohde Christiansen.
3107
3108         [Qt] Implement layoutTestController.layerTreeAsText()
3109         https://bugs.webkit.org/show_bug.cgi?id=60367
3110
3111         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3112         (LayoutTestController::layerTreeAsText):
3113         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3114
3115 2011-05-11  Eric Seidel  <eric@webkit.org>
3116
3117         Reviewed by David Levin.
3118
3119         Teach validate-committer-lists how to validate committers bugzilla_email()
3120         https://bugs.webkit.org/show_bug.cgi?id=60651
3121
3122         It turns out we currently have 9 committers with invalid values for their
3123         bugzilla_email field (meaning we don't know what email is their bugzilla account).
3124         "Alexander Kellett" <lypanov@mac.com>
3125         "Andre Boule" <aboule@apple.com>
3126         "Cameron McCormack" <cam@webkit.org>
3127         "Chris Petersen" <cpetersen@apple.com>
3128         "Eli Fidler" <eli@staikos.net>
3129         "Matt Lilek" <webkit@mattlilek.com>
3130         "Pierre d'Herbemont" <pdherbemont@free.fr>
3131         "Scott Violet" <sky@chromium.org>
3132         "Adam Treat" <treat@kde.org>
3133
3134         Most of those haven't committed in a very long time, so it's not suprising
3135         that we haven't noticed that their bugzilla emails are bogus.
3136
3137         * Scripts/validate-committer-lists:
3138         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3139         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3140
3141 2011-05-11  Dmitry Lomov  <dslomov@google.com>
3142
3143         Reviewed by David Levin.
3144
3145         https://bugs.webkit.org/show_bug.cgi?id=59561
3146         Switch TestWebKitAPI to GTest
3147
3148         Fixes Makefiles and WinCairo build as well
3149
3150         * Makefile:
3151         * Scripts/build-api-tests:
3152         * Scripts/run-api-tests:
3153         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
3154         * TestWebKitAPI/Test.h:
3155         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3156         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
3157         (TestWebKitAPI::TEST):
3158         * TestWebKitAPI/TestsController.cpp:
3159         (TestWebKitAPI::TestsController::TestsController):
3160         (TestWebKitAPI::TestsController::dumpTestNames):
3161         (TestWebKitAPI::TestsController::runTestNamed):
3162         (TestWebKitAPI::TestsController::runAllTests):
3163         * TestWebKitAPI/TestsController.h:
3164         * TestWebKitAPI/mac/main.mm:
3165         (main):
3166
3167 2011-05-11  Eric Seidel  <eric@webkit.org>
3168
3169         Reviewed by Alexey Proskuryakov.
3170
3171         Add Luke Macpherson to committers.py as a Contributor
3172         https://bugs.webkit.org/show_bug.cgi?id=60639
3173
3174         * Scripts/webkitpy/common/config/committers.py:
3175
3176 2011-05-11  Noam Rosenthal  <noam.rosenthal@nokia.com>
3177
3178         Reviewed by Kenneth Rohde Christiansen.
3179
3180         [Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2 branch
3181         https://bugs.webkit.org/show_bug.cgi?id=60439
3182
3183         Patch 4/12: Update the build script to enable 3D rendering by default for Qt.
3184
3185         * Scripts/build-webkit:
3186
3187 2011-05-11  Brian Weinstein  <bweinstein@apple.com>
3188
3189         Reviewed by Adam Roben.
3190
3191         REGRESSION (r86161): WKPreferences API test failing on Windows
3192         https://bugs.webkit.org/show_bug.cgi?id=60658
3193
3194         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
3195         (TestWebKitAPI::TEST):
3196
3197 2011-05-11  Alice Boxhall  <aboxhall@chromium.org>
3198
3199         Reviewed by Ojan Vafai.
3200
3201         Modify jsonresults_unittest.py to use a dict format for its test data, and modify jsonresults.py to flatten hierarchical directory structures in input JSON.
3202         https://bugs.webkit.org/show_bug.cgi?id=60521
3203
3204         First steps towards making the results JSON all hierarchical.
3205
3206         * TestResultServer/model/jsonresults.py:
3207         * TestResultServer/model/jsonresults_unittest.py:
3208
3209 2011-05-11  Kevin Ollivier  <kevino@theolliviers.com>
3210
3211         [wx] Build fix, adding new LayoutTestController method stubs.
3212
3213         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3214         (LayoutTestController::localStorageDiskUsageForOrigin):
3215         (LayoutTestController::applicationCacheDiskUsageForOrigin):
3216
3217 2011-05-11  Jessie Berlin  <jberlin@apple.com>
3218
3219         Reviewed by Darin Adler.
3220
3221         [WebKit2] exceededDatabaseQuota function on WKPageUIClient needs to provide information
3222         about the usage for both the origin overall and the database in question.
3223         https://bugs.webkit.org/show_bug.cgi?id=60573
3224
3225         * WebKitTestRunner/TestController.cpp:
3226         (WTR::exceededDatabaseQuota):
3227
3228 2011-05-10  Stephen White  <senorblanco@chromium.org>
3229
3230         Reviewed by David Levin.
3231
3232         Adding myself as a reviewer.
3233         https://bugs.webkit.org/show_bug.cgi?id=60587
3234
3235         * Scripts/webkitpy/common/config/committers.py:
3236
3237 2011-05-11  Eric Seidel  <eric@webkit.org>
3238
3239         Reviewed by Csaba Osztrogonác.
3240
3241         queues.webkit.org should show 1000+ instead of 1000 when we hit the query limit
3242         https://bugs.webkit.org/show_bug.cgi?id=60614
3243
3244         AppEngine has a result limit of 1000.  We hit that when trying
3245         to find out how many patches the style-queue (and other queues)
3246         have passed in the last 30 days.  So lets display 1000+ instead
3247         of 1000 to avoid confusion. (Ossy was asking about this in #webkit tonight.)
3248
3249         I also made the status pages show "never" instead of just "ago" when we
3250         haven't seen a pass or boot message in the last 1000 messages.
3251
3252         * QueueStatusServer/handlers/queuestatus.py:
3253         * QueueStatusServer/templates/queuestatus.html:
3254
3255 2011-05-11  Adam Barth  <abarth@webkit.org>
3256
3257         Reviewed by Eric Seidel.
3258
3259         sheriffbot shouldn't spam bugs when it can't figure out who to blame
3260         https://bugs.webkit.org/show_bug.cgi?id=60613
3261
3262         This patch limits the number of bugs sheriffbot will spam to three.
3263         Ideally, we'd come up with some smarter huerstics, but hopefully this
3264         will cut down on the bugmail spam for slow bots.
3265
3266         * Scripts/webkitpy/tool/commands/sheriffbot.py:
3267
3268 2011-05-10  Eric Seidel  <eric@webkit.org>
3269
3270         Reviewed by Adam Barth.
3271
3272         EWS bots should be robust against test-webkitpy hangs
3273         https://bugs.webkit.org/show_bug.cgi?id=60579
3274
3275         Added a killAfterTimeout subroutine, which takes a child_pid
3276         and timeout, and will setup a watchdog process to kill that child
3277         after the timeout.  killAfterTimeout will waitpid on the child.
3278
3279         * EWSTools/start-queue.sh:
3280
3281 2011-05-10  MORITA Hajime  <morrita@google.com>
3282
3283         Unreviewed, moved myself to the reviewers list.
3284
3285         * Scripts/webkitpy/common/config/committers.py:
3286
3287 2011-05-10  Anton D'Auria  <adauria@apple.com>
3288
3289         Reviewed by David Levin.
3290
3291         StorageTracker should report actual local storage usage on disk
3292         https://bugs.webkit.org/show_bug.cgi?id=60558
3293
3294         * DumpRenderTree/LayoutTestController.cpp:
3295         (localStorageDiskUsageForOriginCallback):
3296         (LayoutTestController::staticFunctions):
3297         * DumpRenderTree/LayoutTestController.h:
3298         * DumpRenderTree/chromium/LayoutTestController.cpp:
3299         (LayoutTestController::LayoutTestController):
3300         (LayoutTestController::localStorageDiskUsageForOrigin):
3301         * DumpRenderTree/chromium/LayoutTestController.h:
3302         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3303         (LayoutTestController::localStorageDiskUsageForOrigin):
3304         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3305         (LayoutTestController::localStorageDiskUsageForOrigin):
3306         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3307         (LayoutTestController::localStorageDiskUsageForOrigin):
3308         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3309         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3310         (LayoutTestController::localStorageDiskUsageForOrigin):
3311
3312 2011-05-10  Anton D'Auria  <adauria@apple.com>
3313
3314         Reviewed by Alexey Proskuryakov.
3315
3316         Add ApplicationCache API to get disk usage per origin
3317         https://bugs.webkit.org/show_bug.cgi?id=57127
3318
3319         Added test that loads two frames with ~15Kb image, checks usage,
3320         deletes app cache, verifies usage is 0.
3321
3322         * DumpRenderTree/LayoutTestController.cpp:
3323         (applicationCacheDiskUsageForOriginCallback):
3324         (LayoutTestController::staticFunctions):
3325         * DumpRenderTree/LayoutTestController.h:
3326         * DumpRenderTree/chromium/LayoutTestController.cpp: Added stub.
3327         (LayoutTestController::LayoutTestController):
3328         (LayoutTestController::applicationCacheDiskUsageForOrigin):
3329         * DumpRenderTree/chromium/LayoutTestController.h:
3330         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added stub.
3331         (LayoutTestController::applicationCacheDiskUsageForOrigin):
3332         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3333         (LayoutTestController::applicationCacheDiskUsageForOrigin):
3334         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added stub.
3335         (LayoutTestController::applicationCacheDiskUsageForOrigin):
3336         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3337         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Added stub.
3338         (LayoutTestController::applicationCacheDiskUsageForOrigin):
3339
3340 2011-05-10  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
3341
3342         Unreviewed, adding Rafael Antognolli as a committer.
3343
3344         * Scripts/webkitpy/common/config/committers.py:
3345
3346 2011-05-10  Chris Evans  <cevans@chromium.org>
3347
3348         Reviewed by Adam Barth.
3349
3350         Add WebCore::Setting to block displaying and/or running insecure content on secure pages
3351         https://bugs.webkit.org/show_bug.cgi?id=58378
3352
3353         * DumpRenderTree/chromium/LayoutTestController.cpp:
3354         (LayoutTestController::LayoutTestController):
3355         (LayoutTestController::setAllowDisplayOfInsecureContent):
3356         (LayoutTestController::setAllowRunningOfInsecureContent):
3357         * DumpRenderTree/chromium/LayoutTestController.h:
3358         * DumpRenderTree/chromium/WebPreferences.cpp:
3359         (WebPreferences::reset):
3360         (WebPreferences::applyTo):
3361         * DumpRenderTree/chromium/WebPreferences.h:
3362         Add plumbing for new settings to Chromium DRT.
3363
3364 2011-05-10  Enrica Casucci  <enrica@apple.com>
3365
3366         Reviewed by Beth Dakin.
3367
3368         Added my name to the reviewers list and removed my name from
3369         to committer-only list.
3370
3371         * Scripts/webkitpy/common/config/committers.py:
3372
3373 2011-05-10  David Levin  <levin@chromium.org>
3374
3375         Reviewed by Shinichiro Hamaji.
3376
3377         check-webkit-style shouldn't filter the errors using the modified lines for the xml and test expectations checkers.
3378         https://bugs.webkit.org/show_bug.cgi?id=60466
3379
3380         * Scripts/webkitpy/style/checker.py: (unrelated) style fix.
3381         * Scripts/webkitpy/style/checker_unittest.py: Remove the file_path check since
3382           that property was removed.
3383         * Scripts/webkitpy/style/checkers/test_expectations.py: Turn off the line
3384           filtering for errors.
3385         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Add testing to
3386           verify that the line filtering is turned off.
3387         * Scripts/webkitpy/style/checkers/xml.py: Turn off the line filtering for errors
3388           and remove the unused file_path parameter.
3389         * Scripts/webkitpy/style/checkers/xml_unittest.py: Add testing to verify that the
3390           line filtering is turned off (and fix test_no_error).
3391         * Scripts/webkitpy/style/error_handlers.py: Added a way to turn off the filtering
3392           of errors based on the lines changed in the patch.
3393         * Scripts/webkitpy/style/error_handlers_unittest.py: Added a test for turning off
3394           the filtering.
3395
3396 2011-05-10  Adam Roben  <aroben@apple.com>
3397
3398         Update some plugin tests to work with WebKit2's asynchronous windowed plugin positioning on Windows
3399
3400         Fixes <http://webkit.org/b/60442> <rdar://problem/9403200> REGRESSION (r85795):
3401         platform/win/plugins/window-geometry-initialized-before-set-window.html and
3402         platform/win/plugins/window-region-is-set-to-clip-rect.html failing on Windows 7 Release
3403         (WebKit2 Tests)
3404
3405         Reviewed by Anders Carlsson.
3406
3407         * DumpRenderTree/TestNetscapePlugIn/Tests/win/NPNInvalidateRectInvalidatesWindow.cpp:
3408         (NPNInvalidateRectInvalidatesWindow::NPP_SetWindow): Moved some code from here to the new
3409         WindowedPluginTest::testHarnessWindow function.
3410
3411         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowGeometryInitializedBeforeSetWindow.cpp:
3412         (WindowGeometryInitializedBeforeSetWindow::NPP_SetWindow): Only check the window's size, not
3413         its position. In WebKit2, the position won't have been set yet, so we can't test it. But it
3414         turns out only the size mattered for <http://webkit.org/b/46716>, which this test was
3415         created for.
3416
3417         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowRegionIsSetToClipRect.cpp:
3418         (WindowRegionIsSetToClipRect::WindowRegionIsSetToClipRect): Converted to be a
3419         WindowedPluginTest, and initialized new members.
3420         (WindowRegionIsSetToClipRect::startTest): Make our plugin window visible, and set things up
3421         to ensure we get a WM_WINDOWPOSCHANGED message about it becoming visible.
3422         (WindowRegionIsSetToClipRect::finishTest): Check that the window region is what we expect,
3423         then clean up and tell the test harness we're done.
3424         (WindowRegionIsSetToClipRect::checkWindowRegion): Moved code to check the window region here
3425         from NPP_SetWindow. Changed to use the fancy new log() function instead of pluginLog().
3426         (WindowRegionIsSetToClipRect::showTestHarnessWindowIfNeeded): Show the test harness's window
3427         if it is hidden. This is needed to ensure we get a WM_WINDOWPOSCHANGED message when our own
3428         window becomes visible.
3429         (WindowRegionIsSetToClipRect::hideTestHarnessWindowIfNeeded): Hide the test harness's window
3430         if it was hidden at the start of the test.
3431         (WindowRegionIsSetToClipRect::wndProc): When our timer fires, tell the UI process to paint.
3432         This should cause our window to become visible and our window region to get set. When we get
3433         a WM_WINDOWPOSCHANGED message, we can finally finish the test.
3434         (WindowRegionIsSetToClipRect::NPP_GetValue): Return our script object.
3435         (WindowRegionIsSetToClipRect::ScriptObject::hasMethod): We only have one method:
3436         "startTest".
3437         (WindowRegionIsSetToClipRect::ScriptObject::invoke): Call through to the PluginTest object.
3438
3439         * DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.cpp:
3440         (WindowedPluginTest::testHarnessWindow):
3441         * DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.h:
3442         Added this helper function. Code came from NPNInvalidateRectInvalidatesWindow.
3443
3444 2011-05-10  Csaba Osztrogonác  <ossy@webkit.org>
3445
3446         Reviewed by Kenneth Rohde Christiansen.
3447
3448         [Qt] Add new qt-4.8 platform for layout testing
3449         https://bugs.webkit.org/show_bug.cgi?id=60544
3450
3451         * Scripts/old-run-webkit-tests:
3452         * Scripts/webkitdirs.pm:
3453
3454 2011-05-09  Sheriff Bot  <webkit.review.bot@gmail.com>
3455
3456         Unreviewed, rolling out r86108.
3457         http://trac.webkit.org/changeset/86108
3458         https://bugs.webkit.org/show_bug.cgi?id=60533
3459
3460         Broke makefile based builds and Cairo (Requested by weinig on
3461         #webkit).
3462
3463         * Scripts/build-api-tests:
3464         * Scripts/run-api-tests:
3465         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
3466         * TestWebKitAPI/Test.h:
3467         (TestWebKitAPI::Test::~Test):
3468         (TestWebKitAPI::Test::name):
3469         (TestWebKitAPI::Test::Register::Register):
3470         (TestWebKitAPI::Test::Register::create):
3471         (TestWebKitAPI::Test::Test):
3472         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3473         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
3474         (TestWebKitAPI::TEST):
3475         * TestWebKitAPI/TestsController.cpp:
3476         (TestWebKitAPI::TestsController::TestsController):
3477         (TestWebKitAPI::TestsController::dumpTestNames):
3478         (TestWebKitAPI::TestsController::runTestNamed):
3479         (TestWebKitAPI::TestsController::testFailed):
3480         (TestWebKitAPI::TestsController::registerCreateTestFunction):
3481         * TestWebKitAPI/TestsController.h:
3482         * TestWebKitAPI/mac/main.mm:
3483         (main):
3484
3485 2011-05-09  Hayato Ito  <hayato@chromium.org>
3486
3487         Reviewed by Ojan Vafai.
3488
3489         Skip reftests if pixel tests are disabled.
3490
3491         https://bugs.webkit.org/show_bug.cgi?id=59078
3492
3493         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
3494         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
3495         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
3496         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3497
3498 2011-05-09  Chang Shu  <cshu@webkit.org>
3499
3500         Reviewed by Kenneth Rohde Christiansen.
3501
3502         [Qt] DumpRenderTreeQt needs an implementation of unmarkText
3503         https://bugs.webkit.org/show_bug.cgi?id=60499
3504
3505         The implementation is similar to gtk.
3506
3507         * DumpRenderTree/qt/TextInputControllerQt.cpp:
3508         (TextInputController::unmarkText):
3509         * DumpRenderTree/qt/TextInputControllerQt.h:
3510
3511 2011-05-09  James Robinson  <jamesr@chromium.org>
3512
3513         Reviewed by Eric Seidel.
3514
3515         [chromium] Teach new-run-webkit-tests to follow symlinks when trying to determine the arch of DumpRenderTree on linux
3516         https://bugs.webkit.org/show_bug.cgi?id=60520
3517
3518         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3519
3520 2011-05-09  Dmitry Lomov  <dslomov@google.com>
3521
3522         Reviewed by Sam Weinig.
3523
3524         Switch TestWebKitAPI to GTest
3525         https://bugs.webkit.org/show_bug.cgi?id=59561
3526
3527         * Scripts/build-api-tests:
3528         * Scripts/run-api-tests:
3529         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
3530         * TestWebKitAPI/Test.h:
3531         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3532         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
3533         (TestWebKitAPI::TEST):
3534         * TestWebKitAPI/TestsController.cpp:
3535         (TestWebKitAPI::TestsController::TestsController):
3536         (TestWebKitAPI::TestsController::dumpTestNames):
3537         (TestWebKitAPI::TestsController::runTestNamed):
3538         (TestWebKitAPI::TestsController::runAllTests):
3539         * TestWebKitAPI/TestsController.h:
3540         * TestWebKitAPI/mac/main.mm:
3541         (main):
3542
3543 2011-05-09  Igor Oliveira  <igor.oliveira@openbossa.org>
3544
3545         Reviewed by Andreas Kling.
3546
3547         [Qt] DRT eventSender.addTouchPoint method is not setting the start position
3548         https://bugs.webkit.org/show_bug.cgi?id=60487
3549
3550         When adding a new touch point, the start position of this point needs to be set.
3551
3552         * DumpRenderTree/qt/EventSenderQt.cpp:
3553         (EventSender::addTouchPoint):
3554
3555 2011-05-09  Robert Hogan  <robert@webkit.org>
3556
3557         Reviewed by Adam Roben.
3558
3559         https://bugs.webkit.org/show_bug.cgi?id=57137
3560
3561         Unskip plugins/embed-prefers-plugins-for-images.html
3562
3563         Add image/png mime-type to test netscape plugin on Unix.
3564
3565         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3566         (NP_GetMIMEDescription):
3567
3568 2011-05-09  Alice Boxhall  <aboxhall@chromium.org>
3569
3570         Reviewed by Ojan Vafai.
3571
3572         Pull jsonresults_unittest test cases out into separate test methods.
3573         https://bugs.webkit.org/show_bug.cgi?id=60418
3574
3575         * TestResultServer/model/jsonresults_unittest.py:
3576
3577 2011-05-09  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
3578
3579         Reviewed by Andreas Kling.
3580
3581         [Qt] fix fast/dom/Geolocation/window-close-crash.html
3582         https://bugs.webkit.org/show_bug.cgi?id=60458
3583
3584         Update all pages with Mock position/error/permission.
3585
3586         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3587         (LayoutTestController::setGeolocationPermission):
3588         (LayoutTestController::setMockGeolocationError):
3589         (LayoutTestController::setMockGeolocationPosition):
3590
3591 2011-05-09  Shishir Agrawal  <shishir@chromium.org>
3592
3593         Reviewed by Tony Gentilcore.
3594
3595         Implement Page Visibility API.
3596         https://bugs.webkit.org/show_bug.cgi?id=54181
3597
3598         * DumpRenderTree/LayoutTestController.cpp:
3599         (setPageVisibilityCallback):
3600         (resetPageVisibilityCallback):
3601         (LayoutTestController::staticFunctions):
3602         * DumpRenderTree/LayoutTestController.h:
3603         (LayoutTestController::setPageVisibility):
3604         (LayoutTestController::resetPageVisibility):
3605         * DumpRenderTree/chromium/LayoutTestController.cpp:
3606         (LayoutTestController::LayoutTestController):
3607         (LayoutTestController::resetPageVisibility):
3608         (LayoutTestController::setPageVisibility):
3609         * DumpRenderTree/chromium/LayoutTestController.h:
3610
3611 2011-05-07  Adam Barth  <abarth@webkit.org>
3612
3613         Reviewed by Eric Seidel.
3614
3615         Testing EWS spins on patches with a large number of failures
3616         https://bugs.webkit.org/show_bug.cgi?id=60441
3617
3618         In cases where the tree has a small number of persistent failures but a
3619         patch has a large number of failures, we weren't believing any results.
3620         That lead to us retrying the patch forever while we waited for
3621         trustworthy results that would never come.
3622
3623         This patch loosens the semantics of unexpected_failures to return a
3624         subset (rather than the exact set) of unexpected failures.  In the case
3625         where the tree has a bounded number of failures and the patch has an
3626         unbounded number of failures, we can accurately compute such a subset
3627         and reject the patch.
3628
3629         * Scripts/webkitpy/tool/bot/expectedfailures.py:
3630         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
3631         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
3632         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3633         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3634
3635 2011-05-07  Joe Mason  <jmason@rim.com>
3636
3637         Reviewed by Daniel Bates.
3638
3639         FrameLoader::isProcessingUserGesture is wrong in dispatchWillPerformClientRedirect
3640         https://bugs.webkit.org/show_bug.cgi?id=52211
3641
3642         Dump isUserProcessingGesture in willPerformClientRedirect so that the layout tests can be extended.
3643         (For the Mac and Chromium ports - other ports don't support dumping user gestures in DRT.)
3644
3645         * DumpRenderTree/chromium/WebViewHost.cpp:
3646         (WebViewHost::willPerformClientRedirect):
3647         (WebViewHost::didStartProvisionalLoad):
3648         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3649         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
3650
3651 2011-05-07  Daniel Bates  <dbates@webkit.org>
3652
3653         Attempt to fix the build; remove some more references to isTiger(), which was removed in changeset 86007
3654         <http://trac.webkit.org/changeset/86007> (bug #60438).
3655
3656         * Scripts/old-run-webkit-tests:
3657           - Removed reference to isTiger() from openDumpTool(), captureSavedCrashLog(), and
3658             file local variable. 
3659
3660 2011-05-07  Pratik Solanki  <psolanki@apple.com>
3661
3662         Reviewed by Darin Adler.
3663
3664         Remove references to Tiger in scripts
3665         https://bugs.webkit.org/show_bug.cgi?id=60438
3666