[Win] Update DRT Accessibility implementation to better match Mac.
[WebKit-https.git] / Tools / ChangeLog
1 2015-01-23  Brent Fulgham  <bfulgham@apple.com>
2
3         [Win] Update DRT Accessibility implementation to better match Mac.
4         https://bugs.webkit.org/show_bug.cgi?id=140830
5
6         Reviewed by Dean Jackson.
7
8         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
9         (AccessibilityUIElement::titleUIElement):
10         (AccessibilityUIElement::parentElement):
11         (convertToDRTLabel):
12         (AccessibilityUIElement::role):
13         (AccessibilityUIElement::title):
14         (AccessibilityUIElement::description):
15         (AccessibilityUIElement::stringValue):
16         (AccessibilityUIElement::helpText):
17         (AccessibilityUIElement::isFocused):
18
19 2015-01-23  Sergio Villar Senin  <svillar@igalia.com>
20
21         REGRESSION: run-perf-tests --profiler= seems to have broken
22         https://bugs.webkit.org/show_bug.cgi?id=113528
23
24         Reviewed by Daniel Bates.
25
26         The problem is that "perf --record" (or the equivalent call for
27         other profilers) is never called whenever there is a wrapper
28         option in the port. We should inject the profiler call first
29         (should it exists) and then use the port wrapper.
30
31         * Scripts/webkitpy/port/driver.py:
32         (Driver._command_wrapper):
33         * Scripts/webkitpy/port/driver_unittest.py:
34         (DriverTest.test_profiler_and_wrapper): New unit test.
35
36 2015-01-22  David Kilzer  <ddkilzer@apple.com>
37
38         configure-xcode-for-ios-development needs to import webkitdirs.pm
39         <http://webkit.org/b/140704>
40
41         Fixes the following runtime error:
42
43             Undefined subroutine &main::exitStatus called at ./Tools/Scripts/configure-xcode-for-ios-development line 167.
44
45         * Scripts/configure-xcode-for-ios-development: Add back code to
46         import webkitdirs.pm for the exitStatus() method.  Not sure why
47         I removed it before patch review.
48
49 2015-01-22  Timothy Horton  <timothy_horton@apple.com>
50
51         REGRESSION (r178847): Yosemite 32-bit bot isn't doing any work
52         https://bugs.webkit.org/show_bug.cgi?id=140795
53
54         Reviewed by Jon Honeycutt.
55
56         * BuildSlaveSupport/build.webkit.org-config/config.json:
57         r178847 accidentally remove the scheduler for this bot. Re-add it to the
58         Yosemite scheduler.
59
60 2015-01-22  Brent Fulgham  <bfulgham@apple.com>
61
62         [Win] Expose missing editing features through WebView interface
63         https://bugs.webkit.org/show_bug.cgi?id=140773
64         <rdar://problem/19565421>
65
66         Reviewed by Dean Jackson.
67
68         Connect the various WebView editing delegate methods to our
69         test infrastructure. Also prefer _bstr_t to raw BSTR types
70         to simplify life cycle management.
71
72         * DumpRenderTree/win/DumpRenderTree.cpp:
73         (resetWebViewToConsistentStateBeforeTesting):
74         * DumpRenderTree/win/EditingDelegate.cpp:
75         (EditingDelegate::QueryInterface):
76         (dumpPath):
77         (dump):
78         (EditingDelegate::shouldBeginEditingInDOMRange):
79         (EditingDelegate::shouldEndEditingInDOMRange):
80         (EditingDelegate::shouldInsertNode):
81         (EditingDelegate::shouldInsertText):
82         (EditingDelegate::shouldDeleteDOMRange):
83         (EditingDelegate::shouldChangeSelectedDOMRange):
84         (EditingDelegate::shouldApplyStyle):
85         (EditingDelegate::shouldChangeTypingStyle):
86         (EditingDelegate::doPlatformCommand):
87         (EditingDelegate::webViewDidBeginEditing):
88         (EditingDelegate::webViewDidChange):
89         (EditingDelegate::webViewDidEndEditing):
90         (EditingDelegate::webViewDidChangeTypingStyle):
91         (EditingDelegate::webViewDidChangeSelection):
92         (EditingDelegate::checkSpellingOfString):
93         (EditingDelegate::onNotify):
94         * DumpRenderTree/win/EditingDelegate.h:
95
96 2015-01-22  Ryosuke Niwa  <rniwa@webkit.org>
97
98         Add a build flag for ES6 class syntax
99         https://bugs.webkit.org/show_bug.cgi?id=140760
100
101         Reviewed by Michael Saboff.
102
103         * Scripts/webkitperl/FeatureList.pm:
104
105 2015-01-22  Daniel Bates  <dabates@apple.com>
106
107         [iOS] run-webkit-tests --ios-sim dies with an error; fails to parse Apple Internal
108         runtime in simctl output
109         https://bugs.webkit.org/show_bug.cgi?id=140751
110
111         Reviewed by David Kilzer.
112
113         Following the fix for <rdar://problem/19444383>, run-webkit-tests --ios-sim dies
114         with an error because it does not know how to parse the output of the simctl tool
115         to identify an Apple Internal runtime.
116
117         * Scripts/webkitpy/xcode/simulator.py:
118         (Runtime.__init__): Add parameter is_internal_runtime (defaults to False).
119         (Runtime.__eq__): Take is_internal_runtime when comparing two Runtime objects for equality.
120         (Runtime.__repr__): Update printable representation of Runtime object to indicate whether
121         the runtime is an internal runtime.
122         (Simulator): Update regular expressions runtime_re and version_re to match an internal runtime.
123         (Simulator._parse_runtimes): Pass is_internal_runtime to the Runtime constructor with the
124         appropriate value.
125         (Simulator._parse_devices): Pass argument is_internal_runtime to Simulator.runtime() so that
126         it updates the appropriate Runtime object.
127         (Simulator.runtime): Added optional parameter, is_internal_runtime. Modified to support
128         looking up a Runtime object for an internal runtime.
129
130 2015-01-22  Alexey Proskuryakov  <ap@apple.com>
131
132         LeaksViewer doesn't show recent builds if there are less than 10
133         https://bugs.webkit.org/show_bug.cgi?id=140716
134
135         Reviewed by Tim Horton.
136
137         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
138
139 2015-01-22  Lucas Forschler  <lforschler@apple.com>
140
141         Add Apple build slaves.
142         Fixed text alignment for slave list.
143         
144         Unreviewed.
145         
146         * BuildSlaveSupport/build.webkit.org-config/config.json:
147
148 2015-01-21  Lucas Forschler  <lforschler@apple.com>
149
150         Teach build.webkit.org about bot308 and bot309.
151         
152         Unreviewed.
153         
154         * BuildSlaveSupport/build.webkit.org-config/config.json:
155
156 2015-01-21  Lucas Forschler  <lforschler@apple.com>
157
158         Add two Apple Mavericks slaves.
159         
160         Unreviewed.
161         
162         * BuildSlaveSupport/build.webkit.org-config/config.json:
163
164 2015-01-21  Daniel Bates  <dabates@apple.com>
165
166         Add iOS WebKit1 TestExpectation file
167         https://bugs.webkit.org/show_bug.cgi?id=140739
168
169         Reviewed by David Kilzer.
170
171         Teach run-webkit-tests to look for iOS WebKit1-specific test results and
172         expectations in directory LayoutTests/platform/ios-simulator-wk1.
173
174         * Scripts/webkitpy/port/ios.py:
175         (IOSSimulatorPort.default_baseline_search_path):
176
177 2015-01-21  David Kilzer  <ddkilzer@apple.com>
178
179         [iOS] Update configure-xcode-for-ios-development to copy missing headers to iphoneos SDK
180         <http://webkit.org/b/140704>
181
182         Reviewed by Daniel Bates.
183
184         * Scripts/configure-xcode-for-ios-development:
185         - Update copyright.
186         - Remove FIXME addressed by r178709.
187         - Call copyMissingHeadersToIPhoneOSSDKIfNeeded().
188         (copyMissingHeadersToIPhoneOSSDKIfNeeded): Add method to copy
189         missing headers from iphonesimulator SDK to iphoneos SDK.
190         (sdkDirectory): Add method that returns SDK directory.
191         (sdkPlatformDirectory): Extract method from
192         xcodeSDKSpecificationsPath() that returns SDK platform
193         directory.
194         (xcodeSDKSpecificationsPath): Update to use
195         sdkPlatformDirectory().
196
197 2015-01-21  Alexey Proskuryakov  <ap@apple.com>
198
199         https://build.webkit.org/dashboard/metrics.html fails because of ios-ews
200         https://bugs.webkit.org/show_bug.cgi?id=140731
201
202         Reviewed by Tim Horton.
203
204         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
205         (Analyzer.prototype._analyzeAllBubblesPerformance): Corrected a typo.
206
207 2015-01-21  Brent Fulgham  <bfulgham@apple.com>
208
209         [Win] eventSender does not support scalePageBy
210         https://bugs.webkit.org/show_bug.cgi?id=140726
211         <rdar://problem/19549865>
212
213         Reviewed by Dean Jackson.
214
215         * DumpRenderTree/win/EventSender.cpp:
216         (scalePageByCallback): Provide implementation using new WebView method.
217
218 2015-01-21  Lucas Forschler  <lforschler@apple.com>
219
220         Remove Apple Mountain Lion Build & Test slaves.
221         
222         Unreviewed.
223
224         * BuildSlaveSupport/build.webkit.org-config/config.json:
225
226 2015-01-21  Csaba Osztrogonác  <ossy@webkit.org>
227
228         Remove ENABLE(INSPECTOR) ifdef guards
229         https://bugs.webkit.org/show_bug.cgi?id=140668
230
231         Reviewed by Darin Adler.
232
233         * DumpRenderTree/mac/TestRunnerMac.mm:
234         (TestRunner::showWebInspector):
235         (TestRunner::closeWebInspector):
236         (TestRunner::evaluateInWebInspector):
237         * Scripts/webkitperl/FeatureList.pm:
238         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
239         (WTR::TestRunner::showWebInspector):
240         (WTR::TestRunner::closeWebInspector):
241         (WTR::TestRunner::evaluateInWebInspector):
242         * WebKitTestRunner/TestInvocation.cpp:
243         (WTR::TestInvocation::invoke):
244
245 2015-01-20  Alexey Proskuryakov  <ap@apple.com>
246
247         Update build.webkit.org/dashboard to match current Mac queues.
248
249         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion.png: Removed.
250         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion@2x.png: Removed.
251         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion.png: Removed.
252         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion@2x.png: Removed.
253         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
254         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
255         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
256         (table.queue-grid tr.platform.mac-os-x-mountain-lion img.logo): Deleted.
257         (table.queue-grid tr.platform.mac-os-x-lion img.logo): Deleted.
258
259 2015-01-20  Lucas Forschler  <lforschler@apple.com>
260
261         Update Apple MountainLion Leaks slave to Yosemite
262         Update Apple MountainLion Release (32-bit) Build slave to Yosemite
263         
264         Unreviewed.
265
266         * BuildSlaveSupport/build.webkit.org-config/config.json:
267
268 2015-01-20  Lucas Forschler  <lforschler@apple.com>
269
270         Update LeaksViewer from MountainLion to Yosemite
271         
272         Reviewed by Alexey Proskuryakov.
273
274         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
275         (LeaksViewer._displayURLPrompt):
276
277 2015-01-20  Jake Nielsen  <jacob_nielsen@apple.com>
278
279         Fix EWS python unit tests and address code comments as per 140476
280         https://bugs.webkit.org/show_bug.cgi?id=140637
281
282         Reviewed by David Kilzer.
283
284         * Scripts/webkitpy/port/base.py:
285         (Port):
286         (Port.__init__):
287         Adds DEFAULT_ARCHITECTURE member.
288         (Port.architecture):
289         Removes architecture member and instead uses
290         self.get_option('architecture'). Also removes redundant architecture
291         method.
292         (Port.set_architecture):
293         Adds a setter for the architecture variable to be able to set a flag
294         upon modification.
295         (Port.test_configuration):
296         Uses self.architecture() instead of self._architecture.
297         * Scripts/webkitpy/port/ios.py:
298         Overrides DEFAULT_ARCHITECTURE.
299         (IOSPort):
300         (IOSPort.determine_full_port_name):
301         Uses subprocess.check_output instead of Popen. Uses rstrip instead of
302         strip. Fixes regex to not match arbitrary characters after the
303         relevent digits are matched.
304         (IOSPort.__init__):
305         Removes old _architecture defaulting strategy.
306         (IOSPort._build_driver_flags):
307         Uses self.architecture() instead of self._architecture.
308         (IOSSimulatorPort):
309         Overrides DEFAULT_ARCHITECTURE.
310         (IOSSimulatorPort.__init__):
311         Removes old _architecture defaulting strategy.
312         * Scripts/webkitpy/port/mac.py:
313         (MacPort):
314         Overrides DEFAULT_ARCHITECTURE.
315         (MacPort.__init__):
316         Removes old _architecture defaulting strategy.
317         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
318         (AbstractEarlyWarningSystem.run_command):
319         Checks the did_override_architecture flag to determine whether to add
320         the --architecture option.
321         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
322         Uses ews.architecture rather than trying to discern the correct
323         architecture using a port object.
324         (EarlyWarningSystemTest._default_expected_logs):
325         * Scripts/webkitpy/tool/commands/queues.py:
326         Removes use of optparse, and removes the import statement.
327         (AbstractQueue.__init__):
328         (PatchProcessingQueue.begin_work_queue):
329
330 2015-01-20  Sam Weinig  <sam@webkit.org>
331
332         Attempt to fix Mountain Lion and EFL tests.
333
334         * WebKitTestRunner/TestController.cpp:
335         (WTR::TestController::initialize):
336         Disable Process-per-tab and network process on Mountain Lion and EFL.
337
338 2015-01-20  Darin Adler  <darin@apple.com>
339
340         Remove SVGElementInstanceList, m_instanceUnderMouse, DUMP_INSTANCE_TREE, DUMP_SHADOW_TREE
341         https://bugs.webkit.org/show_bug.cgi?id=140679
342
343         Reviewed by Anders Carlsson.
344
345         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
346         Removed a reference to SVGElementInstanceList.
347
348 2015-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
349
350         [GTK] WebViewTest should prohibit overriding initializeWebExtensions()
351         https://bugs.webkit.org/show_bug.cgi?id=140028
352
353         Reviewed by Carlos Garcia Campos.
354
355         This won't work as expected, since this function is called before the
356         WebViewTest constructor completes.
357
358         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
359
360 2015-01-20  David Kilzer  <ddkilzer@apple.com>
361
362         configure-xcode-for-ios-development needs to update iPhoneOS SDK
363         <http://webkit.org/b/140661>
364
365         Reviewed by Daniel Bates.
366
367         * Scripts/configure-xcode-for-ios-development: Add for() loop to
368         run createXcodeSpecificationFilesForSDKIfNeeded() for both
369         "iphoneos" and "iphonesimulator" SDKs.
370         (createXcodeSpecificationFilesForSDKIfNeeded): Extracted from
371         the main body of the script.
372
373 2015-01-20  Tomas Popela  <tpopela@redhat.com>
374
375         [GTK] Add API to set the web view editable into WebKit2 GTK+ API
376         https://bugs.webkit.org/show_bug.cgi?id=139443
377
378         Reviewed by Carlos Garcia Campos.
379
380         Create the new test cases for setting the editable property on the web
381         view and on the contenteditable enabled document. Also rework the
382         current tests that are expecting that the web view is editable.
383
384         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
385         (loadTestHtml):
386         (testWebViewEditorCutCopyPasteNonEditable):
387         (testWebViewEditorCutCopyPasteEditable):
388         (testWebViewEditorSelectAllNonEditable):
389         (testWebViewEditorSelectAllEditable):
390         (runEditorEditableCutTests):
391         (testWebViewEditorEditableOnNonEditable):
392         (testWebViewEditorEditableOnContentEditable):
393         (testWebViewEditorNonEditable):
394         (beforeAll):
395         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
396         (WebViewTest::isEditable):
397         (WebViewTest::setEditable):
398
399 2015-01-20  Carlos Garcia Campos  <cgarcia@igalia.com>
400
401         [GTK] Add an option to create WebKitWebView snapshots with transparent background
402         https://bugs.webkit.org/show_bug.cgi?id=140617
403
404         Reviewed by Gustavo Noronha Silva.
405
406         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
407         (testWebViewSnapshot): Check that the same snapshot with
408         transparent background is different than the default one filled
409         with white.
410
411 2015-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
412
413         [GTK] Add API to change the WebKitWebView background color
414         https://bugs.webkit.org/show_bug.cgi?id=140610
415
416         Reviewed by Gustavo Noronha Silva.
417
418         Add --bg-color command line option to MiniBrowser to be able to
419         manually test the API passing any RGBA color to MiniBrowser.
420         Also add a simple unit test to check that getting and setting
421         colors from the API point of view.
422
423         * MiniBrowser/gtk/BrowserWindow.c:
424         (browser_window_set_background_color):
425         * MiniBrowser/gtk/BrowserWindow.h:
426         * MiniBrowser/gtk/main.c:
427         (createBrowserWindow):
428         (parseBackgroundColor):
429         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
430         (testWebViewBackgroundColor):
431         (beforeAll):
432
433 2015-01-19  Brent Fulgham  <bfulgham@apple.com>
434
435         [Win] Layout Test fast/xmlhttprequest/xmlhttprequest-no-file-access.html is failing
436         https://bugs.webkit.org/show_bug.cgi?id=140665
437
438         Reviewed by Brian Burg.
439
440         * DumpRenderTree/win/UIDelegate.cpp:
441         (UIDelegate::webViewAddMessageToConsole): Correct string search and concatenation to
442         match expected test output.
443
444 2015-01-19  Benjamin Poulain  <bpoulain@apple.com>
445
446         Remove the support for custom suffixes on ChangeLog
447         https://bugs.webkit.org/show_bug.cgi?id=140648
448
449         Reviewed by David Kilzer.
450
451         Custom suffixes were used for the iOS branch of WebKit.
452         Now that everything is opensource, there is no need for it.
453
454         * Scripts/VCSUtils.pm:
455         (changeLogSuffix): Deleted.
456         (changeLogFileName): Deleted.
457         * Scripts/commit-log-editor:
458         * Scripts/prepare-ChangeLog:
459         (getLatestChangeLogs):
460         (generateNewChangeLogs):
461         (generateFileList):
462         * Scripts/resolve-ChangeLogs:
463         (findChangeLog):
464
465 2015-01-19  Timothy Horton  <timothy_horton@apple.com>
466
467         Adjust naming of action menu SPI
468         https://bugs.webkit.org/show_bug.cgi?id=140644
469         <rdar://problem/19448129>
470
471         Reviewed by Brian Weinstein.
472
473         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
474         (-[ActionMenusTestWKView runMenuSequenceAtPoint:preDidCloseMenuHandler:]):
475         (TestWebKitAPI::TEST):
476
477 2015-01-19  Michael Catanzaro  <mcatanzaro@igalia.com>
478
479         [GTK] Generate the make dist manifest from a CMake template file
480         https://bugs.webkit.org/show_bug.cgi?id=139387
481
482         Reviewed by Martin Robinson.
483
484         Remove the code that performs variable substitution on manifest.txt.
485         Replace the custom variables used in that file with CMake variables.
486
487         * gtk/make-dist.py:
488         (Manifest.add_directory):
489         (Manifest.get_full_source_path):
490         (Manifest.process_line):
491         (Manifest.resolve_variables): Deleted.
492         (Manifest.get_full_tarball_path): Deleted.
493         * gtk/manifest.txt.in: Renamed from Tools/gtk/manifest.txt.
494
495 2015-01-19  Brent Fulgham  <bfulgham@apple.com>
496
497         [Win] Correct merge error in last commit.
498
499         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
500         (findAccessibleObjectById): Undo accidental paste made during landing.
501
502 2015-01-19  Brent Fulgham  <bfulgham@apple.com>
503
504         [Win] Periodic failure in DumpRenderTree related to WebActionPropertyBag::Read
505         https://bugs.webkit.org/show_bug.cgi?id=139906
506
507         Reviewed by Dean Jackson.
508
509         WebKit on Windows was creating uninitialized VARIANT structures, then attempting
510         to use them. This patch fixes that.
511
512         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
513         (findAccessibleObjectById):
514         (AccessibilityController::focusedElement):
515         (logEventProc):
516         (notificationListenerProc):
517         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
518         (AccessibilityUIElement::getChildAtIndex):
519         (AccessibilityUIElement::titleUIElement):
520         (self):
521         (AccessibilityUIElement::role):
522         (AccessibilityUIElement::valueDescription):
523         (accessibilityState):
524         (AccessibilityUIElement::isChecked):
525         * DumpRenderTree/win/DumpRenderTree.cpp:
526         (dumpFrameScrollPosition):
527         (dumpFramesAsText):
528         * DumpRenderTree/win/PolicyDelegate.cpp:
529         (PolicyDelegate::decidePolicyForNavigationAction):
530         * DumpRenderTree/win/UIDelegate.cpp:
531         (UIDelegate::exceededDatabaseQuota):
532         * WinLauncher/Common.cpp:
533         (setWindowText):
534
535 2015-01-19  Dean Jackson  <dino@apple.com>
536
537         Add "override" to fix the build with newer clangs.
538
539         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
540         (TestWebKitAPI::CalculationDeletionTestNode::operator==):
541
542 2015-01-19  David Kilzer  <ddkilzer@apple.com>
543
544         [iOS] Do not hard-code iphoneos.internal SDK in buildXCodeProject()
545         <http://webkit.org/b/140623>
546
547         Reviewed by Daniel Bates.
548
549         * Scripts/build-webkit: Update help for --device switch.
550         * Scripts/webkitdirs.pm:
551         (determineXcodeSDK): When passing --device, prefer the internal
552         iOS SDK if it exists, else fall back to the external iOS SDK.
553         (buildXCodeProject): Use xcodeSDK() as -sdk argument for
554         xcodebuild instead of trying to sanitize values.
555
556 2015-01-19  Alexey Proskuryakov  <ap@apple.com>
557
558         "Unknown option: sharedworkerglobalscopeconstructorsfile" when running bindings tests.
559         https://bugs.webkit.org/show_bug.cgi?id=140606
560
561         Reviewed by Csaba Osztrogonác.
562
563         * Scripts/webkitpy/bindings/main.py:
564         (BindingsTests.generate_supplemental_dependency):
565         (BindingsTests.main):
566
567 2015-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
568
569         [GTK] [WK2] TestWebKitWebView snapshot fails
570         https://bugs.webkit.org/show_bug.cgi?id=120404
571
572         Reviewed by Žan Doberšek.
573
574         Rework the test to make sure the snapshot is always created at the
575         desired size.
576
577         * Scripts/run-gtk-tests:
578         (TestRunner): Unskip /webkit2/WebKitWebView/snapshot.
579         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
580         (testWebViewSnapshot): Use a fixed size for the document, and
581         disable scrollbars to make sure the visible area is always the
582         WebView size.
583         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
584         (WebViewTest::showInWindowAndWaitUntilMapped): Add optional width
585         and height parameters to create the window with a given size.
586         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
587
588 2015-01-18  David Kilzer  <ddkilzer@apple.com>
589
590         iOS EWS queue name should be consistent
591         <http://webkit.org/b/140585>
592
593         Reviewed by Daniel Bates.
594
595         * Scripts/webkitpy/common/config/ews.json: Rename 'ios-device'
596         to 'ios'.
597         * Scripts/webkitpy/common/config/ports.py: Ditto.
598         (DeprecatedPort.port):
599         (IOSPort):
600         * Scripts/webkitpy/port/ios.py: Ditto.
601         (IOSPort):
602
603         * Scripts/webkitpy/port/factory.py:
604         (PortFactory): Re-order PORT_CLASSES so ios.IOSSimulatorPort
605         appears before ios.IOSPort.  If this is not done,
606         `run-webkit-tests --ios-simulator` will get the wrong Port class
607         (IOSPort instead of IOSSimulatorPort) due to the way that
608         PortFactory.get() uses prefix matching of <Port>.port_name to
609         find the correct class to use.
610
611 2015-01-18  Alexey Proskuryakov  <ap@apple.com>
612
613         build.webkit.org/dashboard: OS X EWS is now on Mavericks
614         https://bugs.webkit.org/show_bug.cgi?id=140595
615
616         Reviewed by Csaba Osztrogonác.
617
618         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
619         (BubbleQueueServer):
620
621 2015-01-17  David Kilzer  <ddkilzer@apple.com>
622
623         Attempt to fix webkitpy tests on Mountain Lion, Mavericks bots
624
625         * Scripts/webkitpy/port/ios.py:
626         (IOSPort): Add 'ios-device-7' to VERSION_FALLBACK_ORDER so that
627         test-webkitpy doesn't fail since iOS 7.x SDKs are installed on
628         the Mountain Lion and Mavericks bots.
629
630 2015-01-17  David Kilzer  <ddkilzer@apple.com>
631
632         Attempt to fix webkitpy tests on GTK Linux ports
633
634         * Scripts/webkitpy/port/ios.py:
635         (IOSPort.determine_full_port_name): Set a sensible default if
636         not running on a Mac platform or if no iOS SDK is installed.
637
638 2015-01-17  Jake Nielsen  <jacob_nielsen@apple.com>
639
640         Create iOS-EWS client queue
641         https://bugs.webkit.org/show_bug.cgi?id=140476
642
643         Reviewed by Alexey Proskuryakov.
644
645         * EWSTools/start-queue-mac.sh:
646         Adds call to configure-xcode-for-ios-development for iOS EWS.
647         * Scripts/webkitpy/common/config/ews.json:
648         Adds the iOS EWS config entry.
649         * Scripts/webkitpy/common/config/ports.py:
650         (DeprecatedPort.port):
651         Adds IOSPort to the port map.
652         (IOSPort):
653         (IOSPort.build_webkit_command):
654         Adds --sdk=iphoneos to the webkit build command.
655         * Scripts/webkitpy/port/base.py:
656         (Port.architecture):
657         Adds an accessor for the architecture member variable.
658         * Scripts/webkitpy/port/factory.py:
659         (PortFactory):
660         Adds IOSPort to the port class list.
661         * Scripts/webkitpy/port/ios.py:
662         Adds the IOSPort to encapsulate iOS-specific things.
663         (IOSPort):
664         (IOSPort.determine_full_port_name):
665         (IOSPort.__init__):
666         (IOSPort._build_driver_flags):
667         (IOSPort.operating_system):
668         * Scripts/webkitpy/tool/commands/download_unittest.py:
669         Adds the archetecture option to the mock options.
670         (DownloadCommandsTest._default_options):
671         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
672         Appends the archetecture option into calls to webkit-patch.
673         (AbstractEarlyWarningSystem.review_patch):
674         (AbstractEarlyWarningSystem.run_command):
675         (AbstractEarlyWarningSystem.load_ews_classes):
676         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
677         Adds logic to soothe the unittest now that --architecture is being
678         thrown around everywhere.
679         (EarlyWarningSystemTest._default_expected_logs):
680         * Scripts/webkitpy/tool/commands/queues.py:
681         Adds glue code to ferry the --architecture option around.
682         (AbstractQueue.__init__):
683         (PatchProcessingQueue.begin_work_queue):
684         * Scripts/webkitpy/tool/steps/abstractstep.py:
685         Adds the archetecture option to all AbstractSteps so that
686         EarlyWarningSystem doesn't start shoving --architecture into
687         unsuspecting commands.
688         (AbstractStep.options):
689         * Scripts/webkitpy/tool/steps/build.py:
690         Translates the --architecture option into an ARCHS= format to pass to
691         build-webkit.
692         (Build.build):
693         * Scripts/webkitpy/tool/steps/options.py:
694         Adds a definition for the --architecture option.
695         (Options):
696
697 2015-01-16  Sam Weinig  <sam@webkit.org>
698
699         Add a basic configuration object for WKView
700         https://bugs.webkit.org/show_bug.cgi?id=140559
701
702         Reviewed by Anders Carlsson.
703
704         Add tests for WKPageConfigurationRef.
705
706         * TestWebKitAPI/PlatformWebView.h:
707         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
708         * TestWebKitAPI/Tests/WebKit2/WKPageConfiguration.cpp: Added.
709         (TestWebKitAPI::TEST):
710         (TestWebKitAPI::didFinishLoadForFrame):
711         (TestWebKitAPI::setPageLoaderClient):
712         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
713         (TestWebKitAPI::PlatformWebView::initialize):
714         (TestWebKitAPI::PlatformWebView::PlatformWebView):
715
716 2015-01-16  Myles C. Maxfield  <mmaxfield@apple.com>
717
718         WeakPtr functions crash when created with default constructor
719         https://bugs.webkit.org/show_bug.cgi?id=140479
720
721         Reviewed by Andreas Kling.
722
723         Add WeakPtr API tests.
724
725         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
726         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp: Added.
727         * TestWebKitAPI/Tests/WTF/Ref.cpp: Update to not use copy constructor.
728
729 2015-01-16  Chris Dumez  <cdumez@apple.com>
730
731         Regression(r178586): Caused webkitpy.w3c.test_converter_unittest.W3CTestConverterTest.test_convert_prefixed_properties to fail
732         https://bugs.webkit.org/show_bug.cgi?id=140568
733
734         Reviewed by Alexey Proskuryakov.
735
736         Fix the script parsing CSSPropertyNames.in to stop splitting lines
737         on '=' sign. The '=' sign is also used in StyleBuilder parameters:
738         e.g. "Longhands=background-position-x|background-position-y".
739         This would confuse the script and treat this as a CSS property:
740         "background-position-x|background-position-y".
741
742         We now split on white space and treat the first string on the line
743         to be the property name (this is the syntax in this file).
744
745         * Scripts/webkitpy/w3c/test_converter.py:
746         (_W3CTestConverter.__init__):
747         (_W3CTestConverter.read_webkit_prefixed_css_property_list):
748
749 2015-01-16  Daniel Bates  <dabates@apple.com>
750
751         REGRESSION (r171968): run-safari --simulator fails to launch Safari on iOS
752         https://bugs.webkit.org/show_bug.cgi?id=135589
753
754         Reviewed by David Kilzer.
755
756         Derived from a patch by David Farler.
757
758         Following the removal IPhoneSimulatorNotification.pm in <http://trac.webkit.org/changeset/171968>
759         run-safari --simulator fails to launch Safari on iOS. We need to implement run-safari
760         in terms of the simctl command line utility.
761
762         * Scripts/webkitdirs.pm: Added constant SIMULATOR_DEVICE_STATE_BOOTED.
763         (eraseIOSSimulatorDevice): Added.
764         (bootedIOSSimulatorDevice): Added.
765         (iosSimulatorApplicationsPath): Added.
766         (installedMobileSafariBundle): Implemented in terms of iosSimulatorApplicationsPath().
767         (openIOSSimulator): Modified to launch iOS Simulator using OPEN(1).
768         (quitIOSSimulator): Added.
769         (iosSimulatorDeviceByName): Modified to find the first simulator device that matches
770         the specified name and currently selected iOS runtime.
771         (isIOSSimulatorSystemInstalledApp): Added.
772         (runIOSWebKitAppInSimulator): Modified to use simctl launch to launch an app in the simulator.
773         (deleteiOSSimulatorDevice): Deleted.
774         (loadIPhoneSimulatorNotificationIfNeeded): Deleted.
775         (installAndLaunchIOSWebKitAppInSimulator): Deleted.
776
777 2015-01-16  Alex Christensen  <alex.christensen@flexsim.com>
778
779         Resurrect the WinCairo bot.
780         https://bugs.webkit.org/show_bug.cgi?id=139908
781
782         Reviewed by Csaba Osztrogonác.
783
784         * BuildSlaveSupport/build.webkit.org-config/config.json:
785         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
786         (appendCustomBuildFlags):
787         * BuildSlaveSupport/test-result-archive:
788         (archiveTestResults):
789         Add WinCairo buildbot.
790
791 2015-01-16  Chris Dumez  <cdumez@apple.com>
792
793         webkit-patch should auto-install the keyring python module
794         https://bugs.webkit.org/show_bug.cgi?id=140547
795
796         Reviewed by David Kilzer.
797
798         Auto-install the keyring python module. This is the module that
799         webkit-patch uses for cross-platform access to the keyring
800         service.
801
802         Without this module, if the password if not in the keychain,
803         webkit-patch will keep asking for your username / password and
804         never remember them.
805
806         * Scripts/webkitpy/common/net/credentials.py:
807         * Scripts/webkitpy/thirdparty/__init__.py:
808         (AutoinstallImportHook.find_module):
809         (AutoinstallImportHook._install_keyring):
810
811 2015-01-15  Csaba Osztrogonác  <ossy@webkit.org>
812
813         Remove ENABLE(SQL_DATABASE) guards
814         https://bugs.webkit.org/show_bug.cgi?id=140434
815
816         Reviewed by Darin Adler.
817
818         * Scripts/webkitperl/FeatureList.pm:
819
820 2015-01-15  Daniel Bates  <dabates@apple.com>
821
822         [iOS] REGRESSION (r174642): DumpRenderTree.app test may dump result twice
823         https://bugs.webkit.org/show_bug.cgi?id=139685
824         <rdar://problem/19281317>
825
826         Reviewed by Simon Fraser.
827
828         Fixes an issue where a test in DumpRenderTree.app may dump its result twice. In particular,
829         the test LayoutTests/fast/dom/gc-10.html may dump its result twice.
830
831         Following <http://trac.webkit.org/changeset/174642>, we dump the test result asynchronously
832         as opposed to synchronously. So, the WebThread or the main thread may perform other tasks
833         before DRT dumps the output of a test. In particular, the WebThread may start a new page
834         load (say, as a result of continued JavaScript execution), which will ultimately lead to
835         dumping the test result again. Instead we want DRT to dump the test result synchronously
836         such that we capture the state of the web page either when the page is loaded or when
837         window.testRunner.notifyDone() is called.
838
839         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
840         (createBitmapContextFromWebView): Moved logic to re-enable tile painting and update the
841         state of the display from here to updateDisplay(). Added call to -[CATransaction flush] to
842         flush CA transactions to the window.
843         * DumpRenderTree/mac/DumpRenderTree.mm:
844         (updateDisplay): Added iOS-specific code to update tiles and tell WebKit to flush
845         compositing changes to ensure that we have up-to-date tile content for a pixel/ref-test.
846         (dump): Renamed; formerly named dumpTestResults().
847         (displayWebView): Removed outdated FIXME comment. Added FIXME comment to investigate
848         enabling repaint support on iOS.
849         (-[DumpRenderTree _deferDumpToMainThread]): Deleted.
850         (-[DumpRenderTree _waitForWebThreadThenDump]): Deleted.
851         (dumpTestResults): Deleted.
852
853 2015-01-15  Brent Fulgham  <bfulgham@apple.com>
854
855         [Win] Miscellaneous DRT fixes
856         https://bugs.webkit.org/show_bug.cgi?id=116562
857
858         Reviewed by Tim Horton.
859
860         While investigating the cause of several Windows crashes, I found:
861         (1) Messy conversions to and from BSTR types
862         (2) Weird mixes of wide-string and narrow string conversions
863         (3) Passing nullptr to some CoreFoundation routines that do not
864             permit null arguments.
865         (4) Commands to link the executable to the VS2005 runtime.
866
867         This patch cleans up these issues to improve DRT reliability on
868         Windows.
869
870         * DumpRenderTree/cg/ImageDiffCG.cpp:
871         (main): Get rid of VS2005 runtime linking.
872         * DumpRenderTree/win/DumpRenderTree.cpp:
873         (urlSuitableForTestResult): Protect against being asked
874         to process an empty URL.
875         (dumpHistoryItem): Do BSTR string building using _bstr_t, rather
876         than converting to/from wchar_t buffers.
877         (runTest): Simplify string and BSTR handling.
878         (createWebViewAndOffscreenWindow): Ditto.
879         (main): Get rid of VS2005 runtime linking.
880         * DumpRenderTree/win/TestRunnerWin.cpp:
881         (jsStringRefToWString): Simplify code.
882         (TestRunner::pathToLocalResource):
883         (TestRunner::setUserStyleSheetLocation):
884         * TestWebKitAPI/win/main.cpp: Get rid of
885         VS2005 runtime linking.
886         * win/DLLLauncher/DLLLauncherMain.cpp:
887         (wWinMain): Ditto.
888
889 2015-01-15  Alexey Proskuryakov  <ap@apple.com>
890
891         Stop hardcoding mac-mountainlion in commit queue
892         https://bugs.webkit.org/show_bug.cgi?id=140492
893
894         Reviewed by Anders Carlsson.
895
896         Use "mac", not "mac-<platform>". This matches how EWS queues are initialized, and
897         there should be no change in behavior, because:
898         1. PatchProcessingQueue converts the name with _new_port_name_from_old() before
899         using it to create a port object.
900         2. Although it doesn't convert the name before using DeprecatedPort.port(), it
901         is actually correct to use "mac" for the name there. We only used to get the expected
902         behavior with "mac-mountainlion" accidentally, because of a fallback to "mac"
903         for unknown deprecated port names.
904
905         * Scripts/webkitpy/tool/commands/queues.py: (CommitQueue):
906
907 2015-01-14  Jake Nielsen  <jacob_nielsen@apple.com>
908
909         Create iOS-EWS server queue
910         https://bugs.webkit.org/show_bug.cgi?id=140473
911
912         Reviewed by Benjamin Poulain.
913
914         * QueueStatusServer/app.yaml: Updates the SVN version number.
915         * QueueStatusServer/config/queues.py: Add ios-ews queue.
916         * QueueStatusServer/model/queues.py:         
917         (Queue.display_name): Makes sure the display name is pretty!
918
919 2015-01-14  Daniel Bates  <dabates@apple.com>
920
921         [iOS] run-webkit-tests --ios hangs trying to launch iOS Simulator with unavailable runtime
922         https://bugs.webkit.org/show_bug.cgi?id=140301
923         <rdar://problem/19389266>
924
925         Reviewed by Jon Honeycutt.
926
927         Fixes an issue where run-webkit-tests --ios will hang when trying to launch iOS Simulator
928         with an unavailable runtime.
929
930         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
931         (_set_up_derived_options): Modified to access property Simulator.latest_available_runtime,
932         which was formerly called Simulator.latest_runtime. Additionally, raise an exception if the
933         specified runtime cannot be used because it is unavailable.
934         * Scripts/webkitpy/port/ios.py:
935         (IOSSimulatorPort.testing_device): Modified to call Simulator.lookup_or_create_device(),
936         which was formerly named testing_device.
937         * Scripts/webkitpy/xcode/simulator.py:
938         (Device.create): Modified to lookup created device by the UDID returned by simctl, which is
939         more robust than looking up the simulator device by name and runtime. This approach also
940         avoids returning the wrong device due to <rdar://problem/19444383> (simctl list shows
941         unavailable runtimes under the same iOS heading it would use to show it as available).
942         (Simulator.find_device_by_udid): Added.
943         (Simulator.device): Added optional parameter should_ignore_unavailable_devices (defaults
944         to False) to ignore devices that are unavailable (say, because their runtime is unavailable).
945         (Simulator.available_runtimes): Added.
946         (Simulator.latest_available_runtime): Renamed; formerly named latest_runtime. Take advantage
947         of the reverse=True argument to sorted() to sort the list of available runtimes such that the
948         first element of the sorted list is the runtime with the highest version number.
949         (Simulator.lookup_or_create_device): Renamed; formerly named testing_device.
950
951 2015-01-14  Csaba Osztrogonác  <ossy@webkit.org>
952
953         Remove WK2 Windows cruft
954         https://bugs.webkit.org/show_bug.cgi?id=140440
955
956         Reviewed by Anders Carlsson.
957
958         * WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp: Removed.
959         * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp: Removed.
960         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp: Removed.
961
962 2015-01-13  Hunseop Jeong  <hs85.jeong@samsung.com>
963
964         Fix TestWTF failed in TestWebKitAPI
965         https://bugs.webkit.org/show_bug.cgi?id=140333
966
967         Reviewed by Sam Weinig.
968
969         Clear the std::ostringstream before starting test.
970
971         * TestWebKitAPI/Tests/WTF/RefLogger.h:
972         (TestWebKitAPI::DerivedRefLogger::DerivedRefLogger):
973
974 2015-01-13  Michael Catanzaro  <mcatanzaro@igalia.com>
975
976         TestWebKitWebContext depends on British English spellcheck dictionary
977         https://bugs.webkit.org/show_bug.cgi?id=140403
978
979         Reviewed by Martin Robinson.
980
981         Install all English hunspell dictionaries on Fedora and Arch.
982
983         * gtk/install-dependencies:
984
985 2015-01-13  Michael Catanzaro  <mcatanzaro@igalia.com>
986
987         [GTK] install-dependencies should grok dnf
988         https://bugs.webkit.org/show_bug.cgi?id=140396
989
990         Reviewed by Martin Robinson.
991
992         Fedora: install dependencies with dnf if yum is not installed.
993
994         * gtk/install-dependencies:
995
996 2015-01-12  Hunseop Jeong  <hs85.jeong@samsung.com>
997
998         [EFL][GTK] Fix build after r178309  
999         https://bugs.webkit.org/show_bug.cgi?id=140381
1000
1001         Reviewed by Gyuyoung Kim.
1002
1003         * TestWebKitAPI/CMakeLists.txt: Added the API directory
1004
1005 2015-01-11  Sam Weinig  <sam@webkit.org>
1006
1007         Remove support for SharedWorkers
1008         https://bugs.webkit.org/show_bug.cgi?id=140344
1009
1010         Reviewed by Anders Carlsson.
1011
1012         * Scripts/webkitperl/FeatureList.pm:
1013
1014 2015-01-12  Anders Carlsson  <andersca@apple.com>
1015
1016         Make delegates conform to formal delegate protocols
1017         https://bugs.webkit.org/show_bug.cgi?id=140370
1018
1019         Reviewed by Dan Bernstein.
1020
1021         * DumpRenderTree/mac/TestRunnerMac.mm:
1022         (TestRunner::numberOfPendingGeolocationPermissionRequests):
1023         (TestRunner::setGeolocationPermission):
1024
1025 2015-01-10  Michael Catanzaro  <mcatanzaro@igalia.com>
1026
1027         build-webkit: silence output of 'which'
1028         https://bugs.webkit.org/show_bug.cgi?id=140278
1029
1030         Reviewed by Daniel Bates.
1031
1032         Use a more elegent test for the existance of ninja and eclipse.
1033
1034         * Scripts/webkitdirs.pm:
1035         (commandExists): Don't assume the command supports --version
1036         (canUseNinja): Use commandExists()
1037         (canUseEclipse): Use commandExists()
1038
1039 2015-01-09  Sam Weinig  <sam@webkit.org>
1040
1041         Update the output format for run-api-tests
1042         https://bugs.webkit.org/show_bug.cgi?id=140332
1043
1044         Reviewed by Dan Bernstein.
1045
1046         Changes the output format for run-api-tests be a bit simpler (no longer 
1047         indented based on suite, as we were not really using suite very well) but
1048         also include details in the case of failure.
1049
1050         Changes verbose mode to no longer spew out the gtest default printer output,
1051         as the custom printer now includes the failure information.
1052
1053         * Scripts/run-api-tests:
1054         (runTestsBySuite):
1055         (runTest):
1056         Augment the custom gtest printer by replacing the tokens "**PASS**" and "**FAIL**"
1057         with colorized variants and strip out leaks spew (the leaks can be added back using
1058         the new --show-leaks argument).
1059
1060         * TestWebKitAPI/TestsController.cpp:
1061         (TestWebKitAPI::Printer::OnTestPartResult):
1062         (TestWebKitAPI::Printer::OnTestEnd):
1063         (TestWebKitAPI::TestsController::run):
1064         Implement a custom result printer that just prints out the information we want.
1065
1066 2015-01-09  Sam Weinig  <sam@webkit.org>
1067
1068         TestWebKitAPI should print out the lists that fail at the end
1069         https://bugs.webkit.org/show_bug.cgi?id=140329
1070
1071         Reviewed by Tim Horton.
1072
1073         * Scripts/run-api-tests:
1074         (runTestsBySuite):
1075         Print out failures and timeouts in all modes, not just verbose.
1076
1077 2015-01-07  Geoffrey Garen  <ggaren@apple.com>
1078
1079         Make bmalloc work with ASan
1080         https://bugs.webkit.org/show_bug.cgi?id=140194
1081
1082         Reviewed by Mark Lam.
1083
1084         * asan/asan.xcconfig: No need to disable FastMalloc; bmalloc supports
1085         ASan automatically (by forwarding to system malloc at runtime).
1086
1087 2015-01-09  Daniel Bates  <dabates@apple.com>
1088
1089         [iOS] Make DumpRenderTree build with public SDK
1090         https://bugs.webkit.org/show_bug.cgi?id=140311
1091
1092         Reviewed by Sam Weinig.
1093
1094         Use CGRound() instead of the obsolete macro function _ROUNDF_ (defined in
1095         header UIKit/UIMath.h), and std::max() instead of the macro function MAX.
1096         Additionally, remove unused header CoreGraphics/CGFontDB.h.
1097
1098         * DumpRenderTree/mac/DumpRenderTree.mm:
1099         (-[ScrollViewResizerDelegate view:didSetFrame:oldFrame:asResultOfZoom:]):
1100
1101 2015-01-09  Alexey Proskuryakov  <ap@apple.com>
1102
1103         platform/mac-wk2/tiled-drawing/tiled-drawing-scroll-position-page-cache-restoration.html fails on Retina machines
1104         https://bugs.webkit.org/show_bug.cgi?id=140300
1105
1106         Reviewed by Simon Fraser.
1107
1108         * WebKitTestRunner/TestController.cpp:
1109         (WTR::TestController::createOtherPage):
1110         (WTR::TestController::updateWindowScaleForTest):
1111         (WTR::TestController::configureViewForTest):
1112         * WebKitTestRunner/TestController.h:
1113
1114 2015-01-09  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1115
1116         Unreviewed. Moving myself to the committer section.
1117
1118         * Scripts/webkitpy/common/config/contributors.json:
1119
1120 2015-01-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1121
1122         Add a script to check for platform layering violations
1123         https://bugs.webkit.org/show_bug.cgi?id=140248
1124
1125         Reviewed by Darin Adler.
1126
1127         It prints all the cases where files inside platform include
1128         headers that are not in platform directory.
1129
1130         * Scripts/check-for-platform-layering-violations: Added.
1131         (get_platform_headers):
1132         (check_source_file):
1133
1134 2015-01-08  Alexey Proskuryakov  <ap@apple.com>
1135
1136         [Mac WK2] Test snapshots are 1600x1200 on Retina devices
1137         https://bugs.webkit.org/show_bug.cgi?id=139884
1138
1139         Reviewed by Tim Horton.
1140
1141         * WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::windowSnapshotImage):
1142         Tell CGWindowListCreateImage to use the correct resolution. I don't really understand
1143         what the "nominal resolution" is, but this appears to work in practice.
1144
1145 2015-01-08  Brent Fulgham  <bfulgham@apple.com>
1146
1147         [Win] DumpRenderTree is always using 800x600 size, even if tests need other size.
1148         https://bugs.webkit.org/show_bug.cgi?id=140256
1149
1150         Reviewed by Anders Carlsson.
1151
1152         * DumpRenderTree/win/DumpRenderTree.cpp:
1153         (resetWebPreferencesToConsistentValues): Drive-by fix of a buffer overrun found while
1154         running with heap validation checks.
1155         (sizeWebViewForCurrentTest): Check both path separators ('/' and '\\') when checking for
1156         the "svg\\W3C-SVG-1.1" test directory.
1157         (removeFontFallbackIfPresent): Use nullptr instead of 0.
1158         * DumpRenderTree/win/TestRunnerWin.cpp:
1159         (TestRunner::clearPersistentUserStyleSheet): Ditto.
1160
1161 2015-01-08  Alexey Proskuryakov  <ap@apple.com>
1162
1163         Follow-up to:  When WebProcess is slow to respond to IPC, that's mistakenly reported as crash
1164         https://bugs.webkit.org/show_bug.cgi?id=140218
1165
1166         * Scripts/webkitpy/port/driver.py: (Driver._check_for_driver_crash_or_unresponsiveness):
1167         Undone an accidental change - check for self.has_crashed() again. This code path
1168         is for ports that don't have a signal handler printing #CRASHED when main process
1169         crashes.
1170
1171         * Scripts/webkitpy/port/driver_unittest.py:
1172         (DriverTest.test_check_for_driver_crash.assert_crash):
1173         (DriverTest.test_check_for_driver_crash):
1174         Updated the tests, all changes are expected.
1175
1176 2015-01-08  Alexey Proskuryakov  <ap@apple.com>
1177
1178         When WebProcess is slow to respond to IPC, that's mistakenly reported as crash
1179         https://bugs.webkit.org/show_bug.cgi?id=140218
1180
1181         Reviewed by Darin Adler.
1182
1183         * Scripts/webkitpy/port/driver.py:
1184         (Driver.__init__): Removed _subprocess_was_unresponsive that was a modifier for
1185         "process crashed" condition. These don't make sense together - it's either a crash
1186         or a timeout, and we should detect those properly at a much lower level.
1187         (Driver.run_test): Ditto.
1188         (Driver._check_for_driver_crash_or_unresponsiveness): Split crash and unresponsiveness
1189         cases.
1190
1191         * WebKitTestRunner/TestController.h:
1192         * WebKitTestRunner/TestController.cpp:
1193         (WTR::TestController::webProcessName): 
1194         (WTR::TestController::processDidCrash):
1195         Factored out hardcoded child process names, as we now use these in two places.
1196
1197         * WebKitTestRunner/TestInvocation.cpp:
1198         (WTR::TestInvocation::dumpWebProcessUnresponsiveness): Dump an accurate child
1199         process name, so that it can be sampled (fixes sampling on Mavericks and above).
1200
1201 2015-01-08  Zan Dobersek  <zdobersek@igalia.com>
1202
1203         Reorder my list of email addresses, keeping the Bugzilla address at the
1204         top since Bugzilla and other webkitpy scripts rely on that ordering.
1205
1206         * Scripts/webkitpy/common/config/contributors.json:
1207
1208 2015-01-08  Zan Dobersek  <zdobersek@igalia.com>
1209
1210         Moving myself to the reviewers section and updating
1211         the list of my email addresses.
1212
1213         * Scripts/webkitpy/common/config/contributors.json:
1214
1215 2015-01-07  Michael Catanzaro  <mcatanzaro@igalia.com>
1216
1217         [GTK] Build gtk-doc without gtkdoc-mktmpl
1218         https://bugs.webkit.org/show_bug.cgi?id=140225
1219
1220         Reviewed by Darin Adler.
1221
1222         Stop calling gtkdoc-mktmpl. It's being removed upstream, and since we
1223         don't modify the tmpl files that it generates, it's not doing anything
1224         for us.
1225
1226         * gtk/gtkdoc.py:
1227         (GTKDoc.generate):
1228         (GTKDoc._run_gtkdoc_scangobj):
1229         (GTKDoc._run_gtkdoc_mktmpl): Deleted.
1230
1231 2015-01-07  Gwang Yoon Hwang  <yoon@igalia.com>
1232
1233         [GTK][ThreadedCompositor] Add support for threaded compositor.
1234         https://bugs.webkit.org/show_bug.cgi?id=118265
1235
1236         Reviewed by Martin Robinson.
1237
1238         Added the ENABLE_THREADED_COMPOSITOR feature flag to the cmake and
1239         autotools build systems. The feature is disabled by default.
1240         And remove deprecated the WTF_USE_TILED_BACKING_STORE feature flag
1241         from the feature flags.
1242
1243         * Scripts/webkitperl/FeatureList.pm:
1244
1245 2015-01-07  Daniel Bates  <dabates@apple.com>
1246
1247         [iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT
1248         https://bugs.webkit.org/show_bug.cgi?id=137371
1249
1250         Reviewed by David Kilzer.
1251
1252         Use SPI wrapper headers instead of directly referencing private SPI headers.
1253
1254         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
1255         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
1256         * DumpRenderTree/mac/Configurations/Base.xcconfig: Append directory Source/WebKit2/Platform/spi/ios
1257         to the list of iOS header search directories so that we can include header UIKitSPI.h.
1258         * DumpRenderTree/mac/DumpRenderTree.mm:
1259         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1260         * DumpRenderTree/mac/EventSendingController.mm:
1261         * DumpRenderTree/mac/TestRunnerMac.mm:
1262
1263 2015-01-07  Commit Queue  <commit-queue@webkit.org>
1264
1265         Unreviewed, rolling out r178068.
1266         https://bugs.webkit.org/show_bug.cgi?id=140235
1267
1268         Breaks the iOS build (Requested by enrica on #webkit).
1269
1270         Reverted changeset:
1271
1272         "[iOS] Make WebKit2 build with public iOS SDK and more build
1273         fixes for DRT"
1274         https://bugs.webkit.org/show_bug.cgi?id=137371
1275         http://trac.webkit.org/changeset/178068
1276
1277 2015-01-07  Daniel Bates  <dabates@apple.com>
1278
1279         [iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT
1280         https://bugs.webkit.org/show_bug.cgi?id=137371
1281
1282         Reviewed by David Kilzer.
1283
1284         Use SPI wrapper headers instead of directly referencing private SPI headers.
1285
1286         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
1287         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
1288         * DumpRenderTree/mac/Configurations/Base.xcconfig: Append directory Source/WebKit2/Platform/spi/ios
1289         to the list of header search directories so that we can include header UIKitSPI.h.
1290         * DumpRenderTree/mac/DumpRenderTree.mm:
1291         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1292         * DumpRenderTree/mac/EventSendingController.mm:
1293         * DumpRenderTree/mac/TestRunnerMac.mm:
1294
1295 2015-01-07  Brent Fulgham  <bfulgham@apple.com>
1296
1297         [Win] Unreviewed test change to improve run reproducibility
1298
1299         * Scripts/webkitpy/port/win.py:
1300         (WinPort.default_child_processes): Run a single DRT instance to help
1301         identify failures caused by earlier test runs.
1302
1303 2015-01-07  Myles C. Maxfield  <mmaxfield@apple.com>
1304
1305         Myles C. Maxfield is a reviewer now
1306         https://bugs.webkit.org/show_bug.cgi?id=140196
1307
1308         Reviewed by Dean Jackson.
1309
1310         * Scripts/webkitpy/common/config/contributors.json:
1311
1312 2015-01-07  Myles C. Maxfield  <mmaxfield@apple.com>
1313
1314         Make webkit-patch try harder to find keychain credentials
1315         https://bugs.webkit.org/show_bug.cgi?id=140170
1316
1317         Reviewed by Ryosuke Niwa.
1318
1319         When the user manually enters a password into webkit-patch, we hand that off to the
1320         Keyring Python module. However, that module creates a generic password entry instead
1321         of an internet password entry. We should look for both kinds.
1322
1323         * Scripts/webkitpy/common/net/credentials.py:
1324         (Credentials._run_security_tool):
1325         (Credentials._credentials_from_keychain):
1326         * Scripts/webkitpy/common/net/credentials_unittest.py:
1327         (test_security_output_parse_entry_not_found):
1328         (_assert_security_call):
1329
1330 2015-01-06  Anders Carlsson  <andersca@apple.com>
1331
1332         Try to fix the Mountain Lion build.
1333
1334         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
1335         (TestWebKitAPI::didGetImageForMatchResult):
1336
1337 2015-01-06  Alexey Proskuryakov  <ap@apple.com>
1338
1339         Debug ASan builds frequently crash in Register::jsValue under DFG::prepareOSREntry
1340         https://bugs.webkit.org/show_bug.cgi?id=140095
1341
1342         Reviewed by Anders Carlsson.
1343
1344         * asan/webkit-asan-ignore.txt: Blacklist a function that gets inlined in release
1345         builds, but not in debug ones.
1346
1347 2015-01-06  Brent Fulgham  <bfulgham@apple.com>
1348
1349         [Win] Extend WinLauncher with support for Page Zoom
1350         https://bugs.webkit.org/show_bug.cgi?id=140152
1351
1352         Reviewed by Anders Carlsson.
1353
1354         * WinLauncher/Common.cpp:
1355         (WndProc):
1356         * WinLauncher/WinLauncher.cpp:
1357         (WinLauncher::resetZoom):
1358         (WinLauncher::zoomIn):
1359         (WinLauncher::zoomOut):
1360         * WinLauncher/WinLauncher.h:
1361         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc:
1362         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h:
1363         * win/DLLLauncher/DLLLauncherMain.cpp:
1364         (wWinMain):
1365
1366 2015-01-06  Anders Carlsson  <andersca@apple.com>
1367
1368         Fix API tests that are broken under HiDPI
1369         https://bugs.webkit.org/show_bug.cgi?id=140146
1370
1371         Reviewed by Tim Horton.
1372
1373         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
1374         (TestWebKitAPI::didGetImageForMatchResult):
1375         NSImages are measured in points, so grab the underlying bitmap image and get its size in pixels.
1376
1377         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
1378         (TestWebKitAPI::DeviceScaleFactorOnBack::runTest):
1379         Don't assume that a web view not in a window has a backing scale factor of 1. Instead, always have web views start
1380         out in a window that has a backing scale factor of 1.
1381  
1382         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
1383         (TestWebKitAPI::DynamicDeviceScaleFactor::runTest):
1384         Ditto.
1385
1386 2015-01-06  Alexey Proskuryakov  <ap@apple.com>
1387
1388         ADDRESS_SANITIZER macro is overloaded
1389         https://bugs.webkit.org/show_bug.cgi?id=140130
1390
1391         Reviewed by Anders Carlsson.
1392
1393         * WebKitTestRunner/TestController.cpp: Use the new macro.
1394
1395 2015-01-05  Joseph Pecoraro  <pecoraro@apple.com>
1396
1397         Remove some stale class names in check-for-inappropriate-objc-class-names
1398         https://bugs.webkit.org/show_bug.cgi?id=140104
1399
1400         Reviewed by Darin Adler.
1401
1402         * Scripts/check-for-inappropriate-objc-class-names:
1403         These UIWK* classes no longer exist.
1404
1405 2015-01-05  Anders Carlsson  <andersca@apple.com>
1406
1407         heap-buffer-overflow on fast/loader/reload-zero-byte-plugin.html
1408         https://bugs.webkit.org/show_bug.cgi?id=140096
1409         rdar://problem/19368938
1410
1411         Reviewed by Alexey Proskuryakov.
1412
1413         When creating a new page, don't pass clientInfo when setting up the frame and policy clients,
1414         since clientInfo points to a web view, not the test controller.
1415
1416         * WebKitTestRunner/TestController.cpp:
1417         (WTR::TestController::createOtherPage):
1418
1419 2015-01-05  Hunseop Jeong  <hs85.jeong@samsung.com>
1420
1421         [EFL][GTK] WKPreferencesDefaults test failed after r177506 
1422         https://bugs.webkit.org/show_bug.cgi?id=140077
1423
1424         Reviewed by Csaba Osztrogonác.
1425
1426         WebKit C SPI is available on EFL,GTK.
1427         Changed the define order to pass the API test.
1428
1429         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
1430         (TestWebKitAPI::TEST):
1431
1432 2015-01-01  Alexey Proskuryakov  <ap@apple.com>
1433
1434         Simplify WebKitTestRunner timeout tracking
1435         https://bugs.webkit.org/show_bug.cgi?id=140036
1436
1437         Reviewed by Darin Adler.
1438
1439         The code for configuring timeouts was mostly dead, because run-webkit-tests never
1440         passes the --timeout option to WebKitTestRunner.
1441
1442         * WebKitTestRunner/Options.h:
1443         * WebKitTestRunner/Options.cpp:
1444         (WTR::Options::Options):
1445         (WTR::OptionsHandler::OptionsHandler):
1446         (WTR::handleOptionTimeout): Deleted.
1447         Removed support for --timeout. Timeouts are passed for each test individually,
1448         and defaults are good enough for the rare cases where WebKitTestRunner is run
1449         manually without run-webkit-tests.
1450
1451         * WebKitTestRunner/TestController.cpp:
1452         (WTR::TestController::TestController):
1453         (WTR::TestController::initialize):
1454         (WTR::TestController::resetStateToConsistentValues):
1455         (WTR::TestController::reattachPageToWebProcess):
1456         (WTR::TestController::runUntil):
1457         * WebKitTestRunner/TestController.h:
1458         Simplified runUntil by passing the actual timeout, not an enum.
1459         Increased short timeout for ASan enabled builds, as WebProcess launching takes
1460         quite a while.
1461
1462         * WebKitTestRunner/TestInvocation.cpp:
1463         (WTR::TestInvocation::invoke): Removed dead code that handled a timeout from NoTimeout.
1464
1465         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1466         (WTR::TestController::platformRunUntil):
1467         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1468         (WTR::TestController::platformRunUntil):
1469         Build fixes.
1470
1471 2015-01-02  Anders Carlsson  <andersca@apple.com>
1472
1473         Remove now unused storage tracker glue from DumpRenderTree
1474         https://bugs.webkit.org/show_bug.cgi?id=140045
1475
1476         Reviewed by Darin Adler.
1477
1478         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1479         * DumpRenderTree/StorageTrackerDelegate.h: Removed.
1480         * DumpRenderTree/StorageTrackerDelegate.mm: Removed.
1481         * DumpRenderTree/TestRunner.cpp:
1482         (TestRunner::staticFunctions):
1483         (syncLocalStorageCallback): Deleted.
1484         (observeStorageTrackerNotificationsCallback): Deleted.
1485         (deleteAllLocalStorageCallback): Deleted.
1486         (deleteLocalStorageForOriginCallback): Deleted.
1487         (localStorageDiskUsageForOriginCallback): Deleted.
1488         (originsWithLocalStorageCallback): Deleted.
1489         * DumpRenderTree/TestRunner.h:
1490         * DumpRenderTree/mac/DumpRenderTree.mm:
1491         (allocateGlobalControllers):
1492         (releaseGlobalControllers):
1493         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1494         * DumpRenderTree/mac/TestRunnerMac.mm:
1495         (TestRunner::syncLocalStorage): Deleted.
1496         (TestRunner::localStorageDiskUsageForOrigin): Deleted.
1497         (TestRunner::observeStorageTrackerNotifications): Deleted.
1498         (TestRunner::deleteAllLocalStorage): Deleted.
1499         (TestRunner::originsWithLocalStorage): Deleted.
1500         (TestRunner::deleteLocalStorageForOrigin): Deleted.
1501         * DumpRenderTree/win/TestRunnerWin.cpp:
1502         (TestRunner::syncLocalStorage): Deleted.
1503         (TestRunner::localStorageDiskUsageForOrigin): Deleted.
1504         (TestRunner::observeStorageTrackerNotifications): Deleted.
1505         (TestRunner::deleteAllLocalStorage): Deleted.
1506         (TestRunner::originsWithLocalStorage): Deleted.
1507         (TestRunner::deleteLocalStorageForOrigin): Deleted.
1508
1509 2015-01-01  Darin Adler  <darin@apple.com>
1510
1511         We often misspell identifier as "identifer"
1512         https://bugs.webkit.org/show_bug.cgi?id=140025
1513
1514         Reviewed by Michael Saboff.
1515
1516         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
1517         * Scripts/webkitdirs.pm:
1518         (appIdentifierFromBundle):
1519         (installAndLaunchIOSWebKitAppInSimulator):
1520         Fix misspellings
1521
1522 2015-01-01  Zalan Bujtas  <zalan@apple.com>
1523
1524         Saturated arithmetics: Incorrect float/double clamping.
1525         https://bugs.webkit.org/show_bug.cgi?id=139888
1526         rdar://problem/19330885
1527
1528         Reviewed by Simon Fraser.
1529
1530         Clamp float and double values correctly when applying saturated arithmetics.
1531
1532         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
1533         (TestWebKitAPI::TEST):
1534
1535 2014-12-30  Krzysztof Czech  <k.czech@samsung.com>
1536
1537         [EFL] Bump version of ATK used by jhbuild to 2.15.2
1538         https://bugs.webkit.org/show_bug.cgi?id=139816
1539
1540         Reviewed by Gyuyoung Kim.
1541
1542         Bump version of ATK used by jhbuild to 2.15.2
1543
1544         * efl/jhbuild.modules:
1545
1546 2014-12-29  Fabien Vallée  <fvallee@connected-labs.com>
1547
1548         [jhBuild] cairo build error (-flto)
1549         https://bugs.webkit.org/show_bug.cgi?id=139056
1550
1551         Reviewed by Philippe Normand.
1552
1553         cairo fails to link  with gcc 4.9 due to lto
1554         related issue. This problem has been partially
1555         addressed by cairo:
1556         http://cgit.freedesktop.org/cairo/commit/?id=c3645d97ebd24c6f7ad850785d585aebc706a11c
1557         use the cairo --disable-lto option and remove jhbuild
1558         makeargs fixes the issue.
1559
1560         * gtk/jhbuild.modules:
1561         * gtk/patches/cairo-1.12.8-add_disable-lto.patch: Added.
1562
1563 2014-12-27  Myles C. Maxfield  <mmaxfield@apple.com>
1564         [Mac] Enable kerning, ligatures, and printer fonts 
1565         https://bugs.webkit.org/show_bug.cgi?id=139970
1566
1567         Rubber stamped by Simon Fraser.
1568
1569         Flip the switch.
1570
1571         * DumpRenderTree/mac/DumpRenderTree.mm:
1572         * WebKitTestRunner/TestController.cpp:
1573         * WebKitTestRunner/mac/main.mm:
1574
1575 2014-12-26  Dan Bernstein  <mitz@apple.com>
1576
1577         <rdar://problem/19348208> REGRESSION (r177027): iOS builds use the wrong toolchain
1578         https://bugs.webkit.org/show_bug.cgi?id=139950
1579
1580         Reviewed by David Kilzer.
1581
1582         * asan/asan.xcconfig: Only define TOOLCHAINS when building for OS X, doing so
1583         in a manner that works with Xcode 5.1.1.
1584
1585 2014-12-24  Dan Bernstein  <mitz@apple.com>
1586
1587         Engineering builds of MiniBrowser ignore deprecated declaration warnings
1588         https://bugs.webkit.org/show_bug.cgi?id=139941
1589
1590         Reviewed by Darin Adler.
1591
1592         * MiniBrowser/Configurations/Base.xcconfig: Added semicolon.
1593         * MiniBrowser/Configurations/DebugRelease.xcconfig: Set GCC_WARN_ABOUT_DEPRECATED_FUNCTIONS
1594         to YES.
1595         * MiniBrowser/mac/AppDelegate.m:
1596         (-[BrowserAppDelegate openDocument:]): Use NSFileHandlingPanelOKButton instead of
1597         deprecated NSOKButton.
1598
1599 2014-12-24  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1600
1601         W3C test importer should have an option to disable testharness.js/testharnessreport.js link conversion
1602         https://bugs.webkit.org/show_bug.cgi?id=134763
1603
1604         Reviewed by Ryosuke Niwa.
1605
1606         Adding an option to disable test harness link conversion.
1607
1608         * Scripts/webkitpy/w3c/test_converter.py:
1609         (convert_for_webkit):
1610         (_W3CTestConverter.__init__):
1611         (_W3CTestConverter.convert_attributes_if_needed):
1612         * Scripts/webkitpy/w3c/test_importer.py:
1613         (parse_args):
1614         (TestImporter.import_tests):
1615
1616 2014-12-23  Alexey Proskuryakov  <ap@apple.com>
1617
1618         DumpRenderTree crashes are mis-reported as timeouts on Yosemite
1619         https://bugs.webkit.org/show_bug.cgi?id=139933
1620
1621         Reviewed by Daniel Bates.
1622
1623         Crash logs take a very long time to be generated on Yosemite (rdar://problem/18701447),
1624         and there is no way for run-webkit-tests to tell a crashed process from a frozen one
1625         until ReportCrash lets it go.
1626
1627         Reuse existing machinery that tells run-webkit-tests about crashes. The script may
1628         even get the actual crash log eventually - even when it times out waiting for the log, it
1629         makes a second lookup at the very end, after all tests finish. There may be further
1630         improvements needed here, but this small fix addresses most cases that happen in practice.
1631
1632         * DumpRenderTree/mac/DumpRenderTree.mm:
1633         (writeCrashedMessageOnFatalError):
1634         (dumpRenderTree):
1635         Removed PLATFORM(IOS) ifdefs, this code is just as helpful on Mac.
1636
1637         * Scripts/webkitpy/port/driver.py: (Driver._check_for_driver_crash): Removed an
1638         unhelpful comment.
1639
1640 2014-12-23  Alexey Proskuryakov  <ap@apple.com>
1641
1642         Don't force -O1 for debug ASan builds
1643         https://bugs.webkit.org/show_bug.cgi?id=139926
1644
1645         Reviewed by Darin Adler.
1646
1647         * asan/asan.xcconfig:
1648
1649 2014-12-23  Alexey Proskuryakov  <ap@apple.com>
1650
1651         Simplify building with ASan
1652         https://bugs.webkit.org/show_bug.cgi?id=139916
1653
1654         Reviewed by Mark Rowe.
1655
1656         * Scripts/set-webkit-configuration: Store ASan state into a new configuration file.
1657         We could also update Configuration file format, but that's a little scary because
1658         of how many places in code read it.
1659
1660         * Scripts/webkitdirs.pm:
1661         (determineASanIsEnabled): Read it from ASan configuration file.
1662         (argumentsForConfiguration): Added a FIXME.
1663         (asanIsEnabled): A caching wrapper similar to what we have for other configuration options.
1664         (XcodeOptions): Pass the options needed for ASan.
1665
1666         * asan/asan.xcconfig: Use the right toolchains. Made warnings fatal again, as there
1667         no warnings to avoid. Removed explicit linking options, as -fsanitize=address does
1668         that automatically.
1669
1670 2014-12-23  Alexey Proskuryakov  <ap@apple.com>
1671
1672         TestWebKitAPI build is broken when ASan is enabled
1673         https://bugs.webkit.org/show_bug.cgi?id=139902
1674
1675         Reviewed by Darin Adler.
1676
1677         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
1678         * TestWebKitAPI/Configurations/TestWebKitAPILibrary.xcconfig:
1679         Inherit linker flags from DebugRelease, which respects ASAN.
1680
1681 2014-12-22  Simon Fraser  <simon.fraser@apple.com>
1682
1683         Sort the Xcode project file.
1684
1685         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1686
1687 2014-12-22  Lucas Forschler  <lforschler@apple.com>
1688
1689         Update apple-mac-114 to bot629.
1690         
1691         Unreviewed.
1692         
1693         * BuildSlaveSupport/build.webkit.org-config/config.json:
1694
1695 2014-12-22  Lucas Forschler  <lforschler@apple.com>
1696
1697         Replace Apple bot104 with bot124.
1698         
1699         Unreviewed.
1700         
1701         * BuildSlaveSupport/build.webkit.org-config/config.json:
1702
1703 2014-12-22  Csaba Osztrogonác  <ossy@webkit.org>
1704
1705         URTBF after r177639.
1706
1707         * TestWebKitAPI/CMakeLists.txt:
1708
1709 2014-12-22  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
1710
1711         [EFL] MiniBrowser steals web view's focus
1712         https://bugs.webkit.org/show_bug.cgi?id=139482
1713
1714         Reviewed by Gyuyoung Kim.
1715
1716         Although we set focus on ewk_view while MiniBrowser initialization
1717         Ecore steals it in a favor of main window. As a result
1718         focused element on web page is unable to receive events.
1719
1720         * MiniBrowser/efl/main.c:
1721         (window_create):
1722         Prevent window from stealing web view's focus on start up.
1723
1724 2014-12-19  Brent Fulgham  <bfulgham@apple.com>
1725
1726         [Win] Revise DRT logic to match Mac.
1727
1728         Rubberstamped by Anders Carlsson.
1729
1730         Update the Windows logic to perform initialization of preferences and WebKit
1731         settings to match Mac. Also make sure that we only ever emit #EOF tokens under
1732         the same circumstances as the Mac version.
1733
1734         * DumpRenderTree/win/DumpRenderTree.cpp:
1735         (dump):
1736         (resetWebPreferencesToConsistentValues):
1737         (setDefaultsToConsistentValuesForTesting):
1738         (resetWebViewToConsistentStateBeforeTesting):
1739         (sizeWebViewForCurrentTest):
1740         (runTest):
1741         (createWebViewAndOffscreenWindow):
1742         (allocateGlobalControllers):
1743         (prepareConsistentTestingEnvironment):
1744         (main):
1745         (resetDefaultsToConsistentValues): Deleted.
1746
1747 2014-12-19  Roger Fong  <roger_fong@apple.com>
1748
1749         Unreviewed. Rollout r177605.
1750
1751         * EWSTools/start-queue-win.sh:
1752
1753 2014-12-19  Roger Fong  <roger_fong@apple.com>
1754
1755         Unreviewed. Try running EWS scripts without —no-confirm, since it defaults to true.
1756
1757         * EWSTools/start-queue-win.sh:
1758
1759 2014-12-19  Daniel Bates  <dabates@apple.com>
1760
1761         [iOS] Add WebKitSystemInterface for iOS 8.1
1762         https://bugs.webkit.org/show_bug.cgi?id=139831
1763
1764         Reviewed by Alexey Proskuryakov.
1765
1766         Implement support in copy-webkitlibraries-to-product-directory to copy
1767         WebKitSystemInterface for iOS to the product directory and have build-webkit
1768         pass --wksi to copy-webkitlibraries-to-product-directory when building for iOS.
1769
1770         * Scripts/build-webkit:
1771         * Scripts/copy-webkitlibraries-to-product-directory:
1772
1773 2014-12-19  Daniel Bates  <dabates@apple.com>
1774
1775         copy-webkitlibraries-to-product-directory uses wrong SDK when called from build-webkit
1776         https://bugs.webkit.org/show_bug.cgi?id=139829
1777
1778         Reviewed by Alexey Proskuryakov.
1779
1780         The script build-webkit calls script copy-webkitlibraries-to-product-directory with
1781         argument --sdk to specify the Xcode SDK to use, but copy-webkitlibraries-to-product-directory
1782         expects the Xcode SDK to be specified using the --sdk-name command line argument.
1783
1784         Currently copy-webkitlibraries-to-product-directory has its own logic to handle
1785         parsing for a specified Xcode SDK. Instead we should make use of the webkitdirs.pm
1786         logic to both avoid duplicating effort and make the command line options for
1787         copy-webkitlibraries-to-product-directory for specify the Xcode SDK consistent
1788         with the approach used in other WebKit tools.
1789
1790         As a side effect of making use of the webkitdirs.pm logic for determining the Xcode SDK
1791         copy-webkitlibraries-to-product-directory now recognizes --device and --simulator
1792         shorthands for --sdk=iphoneos.internal and --sdk=iphonesimulator, respectively.
1793
1794         * Scripts/copy-webkitlibraries-to-product-directory: Also, renamed some variables to
1795         improve the readability of the code.
1796         (executeRanlib): Added; convenience function that calls the RANLIB(1) with the appropriate
1797         Xcode SDK. We pass -no_warning_for_no_symbols to RANLIB(1) when using an Xcode SDK
1798         for iOS since it's acceptable that an empty object file (say, for a Mac-specific feature)
1799         be included in a library.
1800         (unpackIfNecessary): Modified to call executeRanlib().
1801
1802 2014-12-19  Alexey Proskuryakov  <ap@apple.com>
1803
1804         REGRESSION (177368): Some tests started to immediately time out
1805         https://bugs.webkit.org/show_bug.cgi?id=139826
1806
1807         Reviewed by Daniel Bates.
1808
1809         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::done):
1810         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::dump):
1811         Move invalidateWaitToDumpWatchdogTimer() call from dump() to done(). When a test
1812         ends in a load failure, we don't dump, so we used to leak the timer.
1813         
1814         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::notifyDone):
1815         Added a comment.
1816
1817 2014-12-19  Brent Fulgham  <bfulgham@apple.com>
1818
1819         [Win] Add accessor for serializing HTTP loads
1820         https://bugs.webkit.org/show_bug.cgi?id=139817
1821
1822         Reviewed by Mark Lam.
1823
1824         * DumpRenderTree/win/DumpRenderTree.cpp: Reset serialized HTTP loads in our reset method.
1825         * DumpRenderTree/win/TestRunnerWin.cpp: Provide implementation for serializing HTTP. Also
1826         remove some redundant code from the destructor.
1827
1828 2014-12-19  Alexey Proskuryakov  <ap@apple.com>
1829
1830         Clean up a fix for performance test bot failing to build
1831         https://bugs.webkit.org/show_bug.cgi?id=139818
1832
1833         Reviewed by Csaba Osztrogonác.
1834
1835         The "_1" in step name was annoying.
1836
1837         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1838         (CleanBuildIfScheduled.start):
1839         (RunAndUploadPerfTests):
1840         (DownloadAndPerfTestFactory.__init__):
1841         (DownloadAndPerfTestWebKit2Factory.__init__):
1842         (CleanBuildUnconditionally): Deleted.
1843         (CleanBuildUnconditionally.start): Deleted.
1844
1845 2014-12-19  Csaba Osztrogonác  <ossy@webkit.org>
1846
1847         REGRESSION(r177535): It broke the GTK performance bot
1848         https://bugs.webkit.org/show_bug.cgi?id=139811
1849
1850         Reviewed by Carlos Garcia Campos.
1851
1852         Trigger clean build only on mac platform.
1853
1854         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1855         (DownloadAndPerfTestFactory.__init__):
1856         (DownloadAndPerfTestWebKit2Factory.__init__):
1857
1858 2014-12-18  KwangHyuk Kim  <hyuki.kim@samsung.com>
1859
1860         Unreviewed, moved myself to the list of committers.
1861
1862         * Scripts/webkitpy/common/config/contributors.json:
1863
1864 2014-12-18  Brent Fulgham  <bfulgham@apple.com>
1865
1866         [Win] Update DumpRenderTree to more closely match Mac version
1867         https://bugs.webkit.org/show_bug.cgi?id=139799
1868
1869         Reviewed by Tim Horton.
1870
1871         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1872         (AccessibilityController::accessibleElementById): Correct
1873         use of BSTR to avoid leak.
1874         * DumpRenderTree/win/DumpRenderTree.cpp: Reorder methods and
1875         update to match Mac version more closely.
1876         (dumpFramesAsText):
1877         (dump):
1878         (resetDefaultsToConsistentValues):
1879         (resetWebViewToConsistentStateBeforeTesting):
1880         (sizeWebViewForCurrentTest):
1881         (runTest):
1882         (openWindows):
1883         (windowToWebViewMap):
1884         (createWebViewAndOffscreenWindow):
1885         (sharedCFURLCache):
1886         (initializeGlobalsFromCommandLineOptions):
1887         (main):
1888         * DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
1889         (TestRunner::addDisallowedURL):
1890         (TestRunner::applicationCacheDiskUsageForOrigin):
1891         (TestRunner::syncLocalStorage):
1892         (TestRunner::localStorageDiskUsageForOrigin):
1893         (TestRunner::observeStorageTrackerNotifications):
1894         (TestRunner::clearApplicationCacheForOrigin):
1895         (TestRunner::originsWithApplicationCache):
1896         (TestRunner::deleteAllLocalStorage):
1897         (TestRunner::setStorageDatabaseIdleInterval):
1898         (TestRunner::closeIdleLocalStorageDatabases):
1899         (TestRunner::originsWithLocalStorage):
1900         (TestRunner::deleteLocalStorageForOrigin):
1901         (TestRunner::copyDecodedHostName):
1902         (TestRunner::copyEncodedHostName):
1903         (TestRunner::keepWebHistory):
1904         (TestRunner::numberOfPendingGeolocationPermissionRequests):
1905         (TestRunner::setAppCacheMaximumSize):
1906         (TestRunner::setCustomPolicyDelegate):
1907         (TestRunner::goBack):
1908         (TestRunner::setDefersLoading):
1909         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
1910         (TestRunner::setMockDeviceOrientation):
1911         (TestRunner::setMockGeolocationPosition):
1912         (TestRunner::setMockGeolocationPositionUnavailableError):
1913         (TestRunner::setIconDatabaseEnabled):
1914         (TestRunner::setMainFrameIsFirstResponder):
1915         (TestRunner::setSpatialNavigationEnabled):
1916         (TestRunner::setPluginsEnabled):
1917         (TestRunner::setAutomaticLinkDetectionEnabled):
1918         (TestRunner::setUseDashboardCompatibilityMode):
1919         (TestRunner::dispatchPendingLoadRequests):
1920         (TestRunner::findString):
1921         (TestRunner::setCacheModel):
1922         (TestRunner::apiTestNewWindowDataLoadBaseURL):
1923         (TestRunner::setWebViewEditable):
1924         (TestRunner::authenticateSession):
1925         (TestRunner::abortModal):
1926         (TestRunner::setSerializeHTTPLoads):
1927         (TestRunner::addChromeInputField):
1928         (TestRunner::removeChromeInputField):
1929         (TestRunner::focusWebView):
1930         (TestRunner::setBackingScaleFactor):
1931         (TestRunner::grantWebNotificationPermission):
1932         (TestRunner::denyWebNotificationPermission):
1933         (TestRunner::removeAllWebNotificationPermissions):
1934         (TestRunner::simulateWebNotificationClick):
1935
1936 2014-12-18  Gavin Barraclough  <barraclough@apple.com>
1937
1938         Add strong typing to RefCounter interface, return value as a bool.
1939         https://bugs.webkit.org/show_bug.cgi?id=139776
1940
1941         Reviewed by Geoff Garen.
1942
1943         Currently all token vended by a RefCounter have the same type - Ref<RefCounter::Count>.
1944         This means there is no compile time type checking to prevent mistakes. Update the count()
1945         method to token<>(), templated on type used to identify the token being returned.
1946         Calls to token<T>() will return a result of type RefCounter::Token<T>.
1947
1948         There are a few problems with the fact the counter will return you an exact count of the
1949         number of outstanding tokens:
1950           - It is desirable to only fire the callback on zero-edge changes; it is more consistent
1951             to do so if the value is only readable as a boolean.
1952           - It is desirable to provide the value as an argument to the callback, however to make
1953             this useful for integer values it is also necessary to indicate the direction of change
1954             (0->1 is often interesting where 2->1 is not).
1955           - There is a mismatch between the precision of returning a count, and the inherent
1956             imprecision of a token based mechanism, where it may be difficult to guarantee
1957             absolutely no unnecessary refcount churn, and thus unintentional counter values.
1958
1959         * TestWebKitAPI/Tests/WTF/RefCounter.cpp:
1960         (TestWebKitAPI::TEST):
1961             - update API test.
1962
1963 2014-12-18  Alexey Proskuryakov  <ap@apple.com>
1964
1965         Disable retries on Mac Release WK2 testers
1966         https://bugs.webkit.org/show_bug.cgi?id=139798
1967
1968         Reviewed by Simon Fraser.
1969
1970         * BuildSlaveSupport/build.webkit.org-config/config.json:
1971
1972 2014-12-18  Alexey Proskuryakov  <ap@apple.com>
1973
1974         Perf tests frequently fail saying "build not up to date"
1975         https://bugs.webkit.org/show_bug.cgi?id=139786
1976
1977         Illegitimately yet authoritatively reviewed by Lucas Forschler.
1978
1979         Undo the rest of the first fix, and implement the behavior differently.
1980
1981         is_clean isn't automatically forwarded from config.json to properties.
1982
1983         * BuildSlaveSupport/build.webkit.org-config/config.json:
1984         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1985         (CleanBuildUnconditionally):
1986         (CleanBuildUnconditionally.start):
1987         (DownloadAndPerfTestFactory.__init__):
1988         (DownloadAndPerfTestWebKit2Factory.__init__):
1989
1990 2014-12-18  Alexey Proskuryakov  <ap@apple.com>
1991
1992         Roll out part of the previous patch - BuildAndPerfTestWebKit2 is used by Efl.
1993         I thought that it was unused because grepping for BuildAndPerfTestWebKit2Factory
1994         found nothing.
1995
1996         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1997         (BuildAndPerfTestFactory):
1998         (BuildAndPerfTestWebKit2Factory):
1999
2000 2014-12-18  Alexey Proskuryakov  <ap@apple.com>
2001
2002         Perf tests frequently fail saying "build not up to date"
2003         https://bugs.webkit.org/show_bug.cgi?id=139786
2004
2005         Reviewed by Ryosuke Niwa.
2006
2007         Perf tests only build DumpRenderTree, not WebKit itself. Just clean the build
2008         directory to get rid of stale precompiled headers, and let it rebuild
2009         DumpRenderTree each time, that's fast.
2010
2011         Also, removed unused "build and perf test" code.
2012
2013         * BuildSlaveSupport/build.webkit.org-config/config.json:
2014
2015 2014-12-18  Brent Fulgham  <bfulgham@apple.com>
2016
2017         [Win] Unreviewed gardening. Reorder file contents to match Mac version.
2018
2019         Reorder the contents of the TestRunnerWin so that it matches TestRunnerMac. This makes
2020         it easier to see what steps are missing when running under Windows.
2021
2022         * DumpRenderTree/win/TestRunnerWin.cpp:
2023         (TestRunner::callShouldCloseOnWebView):
2024         (TestRunner::clearAllApplicationCaches):
2025         (TestRunner::applicationCacheDiskUsageForOrigin):
2026         (TestRunner::syncLocalStorage):
2027         (TestRunner::localStorageDiskUsageForOrigin):
2028         (TestRunner::observeStorageTrackerNotifications):
2029         (TestRunner::clearApplicationCacheForOrigin):
2030         (TestRunner::originsWithApplicationCache):
2031         (TestRunner::clearAllDatabases):
2032         (TestRunner::deleteAllLocalStorage):
2033         (TestRunner::setStorageDatabaseIdleInterval):
2034         (TestRunner::closeIdleLocalStorageDatabases):
2035         (TestRunner::originsWithLocalStorage):
2036         (TestRunner::deleteLocalStorageForOrigin):
2037         (TestRunner::numberOfPendingGeolocationPermissionRequests):
2038         (jsStringRefToWString):
2039         (TestRunner::setAppCacheMaximumSize):
2040         (TestRunner::setDatabaseQuota):
2041         (TestRunner::goBack):
2042         (TestRunner::setDefersLoading):
2043         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
2044         (TestRunner::setAutomaticLinkDetectionEnabled):
2045         (TestRunner::dispatchPendingLoadRequests):
2046         (TestRunner::overridePreference):
2047         (TestRunner::removeAllVisitedLinks):
2048         (TestRunner::waitForPolicyDelegate):
2049         (TestRunner::resetPageVisibility):
2050         (TestRunner::setPageVisibility):
2051         (TestRunner::grantWebNotificationPermission):
2052         (TestRunner::denyWebNotificationPermission):
2053         (TestRunner::removeAllWebNotificationPermissions):
2054         (TestRunner::simulateWebNotificationClick):
2055         (TestRunner::simulateLegacyWebNotificationClick):
2056
2057 2014-12-18  Brent Fulgham  <bfulgham@apple.com>
2058
2059         [Win] Correct Windows tests after Bug 139149 (edit)
2060         https://bugs.webkit.org/show_bug.cgi?id=139781
2061
2062         Reviewed by Anders Carlsson.
2063
2064         * DumpRenderTree/win/TestRunnerWin.cpp:
2065         (TestRunner::clearAllApplicationCaches): Use new WebApplicationCache
2066         interface.
2067
2068 2014-12-18  Simon Fraser  <simon.fraser@apple.com>
2069
2070         [iOS] Remove the various aliases for --ios-simulator (--sim, --simulator, --ios-sim) in arguments for build and test scripts
2071         https://bugs.webkit.org/show_bug.cgi?id=139748
2072
2073         Reviewed by Daniel Bates.
2074         
2075         Staging change to support --ios-sim and --ios-simulator temporarily until the bots
2076         have all been updated.
2077
2078         * Scripts/webkitpy/port/factory.py:
2079         (platform_options):
2080
2081 2014-12-18  Simon Fraser  <simon.fraser@apple.com>
2082
2083         Build more of TestWebKitAPI for iOS
2084         https://bugs.webkit.org/show_bug.cgi?id=139747
2085
2086         Reviewed by Daniel Bates.
2087         
2088         Base.xcconfig removed many test files from the iOS build via EXCLUDED_SOURCE_FILE_NAMES,
2089         which excluded some tests that should be run for iOS.
2090         
2091         Fix by removing some patterns from EXCLUDED_SOURCE_FILE_NAMES, and #ifdeffing
2092         source files instead. config.h defines WK_HAVE_C_SPI when the WebKit C SPI is
2093         available (i.e. Mac OS X), and most files use that. Some files with Mac-only
2094         functionality (ActionMenus, Downloads) use #if PLATFORM(MAC).
2095         
2096         Added PlatformUtilitiesCocoa.mm and moved WeakObjCPtr.mm into a cocoa directory
2097         to share code between Mac and iOS.
2098
2099         * TestWebKitAPI/Configurations/Base.xcconfig:
2100         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
2101         * TestWebKitAPI/InjectedBundleController.cpp:
2102         * TestWebKitAPI/InjectedBundleMain.cpp:
2103         * TestWebKitAPI/JavaScriptTest.cpp:
2104         * TestWebKitAPI/PlatformUtilities.cpp:
2105         * TestWebKitAPI/PlatformUtilities.h:
2106         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2107         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
2108         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
2109         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
2110         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
2111         * TestWebKitAPI/Tests/WebKit2/CloseFromWithinCreatePage.cpp:
2112         * TestWebKitAPI/Tests/WebKit2/CloseThenTerminate.cpp:
2113         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
2114         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
2115         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
2116         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache.cpp:
2117         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
2118         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp:
2119         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp:
2120         * TestWebKitAPI/Tests/WebKit2/DidNotHandleKeyDown.cpp:
2121         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
2122         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
2123         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
2124         * TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp:
2125         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
2126         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
2127         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
2128         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
2129         * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
2130         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
2131         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
2132         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
2133         * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback.cpp:
2134         * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback_Bundle.cpp:
2135         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
2136         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
2137         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
2138         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp:
2139         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest.cpp:
2140         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest_Bundle.cpp:
2141         * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins.cpp:
2142         * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins_Bundle.cpp:
2143         * TestWebKitAPI/Tests/WebKit2/LayoutMilestonesWithAllContentInFrame.cpp:
2144         * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
2145         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp:
2146         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp:
2147         * TestWebKitAPI/Tests/WebKit2/LoadPageOnCrash.cpp:
2148         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
2149         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash_Bundle.cpp:
2150         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:
2151         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp:
2152         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp:
2153         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
2154         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages_Bundle.cpp:
2155         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
2156         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp:
2157         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp:
2158         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
2159         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2160         * TestWebKitAPI/Tests/WebKit2/ParentFrame.cpp:
2161         * TestWebKitAPI/Tests/WebKit2/ParentFrame_Bundle.cpp:
2162         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications.mm:
2163         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications_Bundle.cpp:
2164         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
2165         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp:
2166         * TestWebKitAPI/Tests/WebKit2/ReloadPageAfterCrash.cpp:
2167         * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
2168         * TestWebKitAPI/Tests/WebKit2/ResizeWindowAfterCrash.cpp:
2169         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
2170         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly_Bundle.cpp:
2171         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
2172         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
2173         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp:
2174         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem_Bundle.cpp:
2175         * TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp:
2176         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
2177         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp:
2178         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp:
2179         * TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp:
2180         * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp:
2181         * TestWebKitAPI/Tests/WebKit2/UserMessage_Bundle.cpp:
2182         * TestWebKitAPI/Tests/WebKit2/WKImageCreateCGImageCrash.cpp:
2183         * TestWebKitAPI/Tests/WebKit2/WKPageGetScaleFactorNotZero.cpp:
2184         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
2185         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2186         (TestWebKitAPI::TEST):
2187         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
2188         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
2189         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
2190         * TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp:
2191         * TestWebKitAPI/Tests/WebKit2/WebCoreStatisticsWithNoWebProcess.cpp:
2192         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp:
2193         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
2194         * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent.cpp:
2195         * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent_Bundle.cpp:
2196         * TestWebKitAPI/Tests/WebKit2/cocoa/WeakObjCPtr.mm: Renamed from Tools/TestWebKitAPI/Tests/WebKit2/mac/WeakObjCPtr.mm.
2197         (TEST):
2198         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2199         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
2200         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
2201         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm:
2202         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
2203         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp:
2204         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
2205         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
2206         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing_Bundle.cpp:
2207         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
2208         * TestWebKitAPI/cocoa/PlatformUtilitiesCocoa.mm: Copied from Tools/TestWebKitAPI/Tests/WebKit2/WKImageCreateCGImageCrash.cpp.
2209         (TestWebKitAPI::Util::run):
2210         (TestWebKitAPI::Util::sleep):
2211         (TestWebKitAPI::Util::toSTD):
2212         * TestWebKitAPI/config.h:
2213         * TestWebKitAPI/mac/JavaScriptTestMac.mm:
2214         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
2215         (TestWebKitAPI::Util::run): Deleted.
2216         (TestWebKitAPI::Util::sleep): Deleted.
2217         (TestWebKitAPI::Util::toSTD): Deleted.
2218
2219 2014-12-18  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
2220
2221         [GTK] Add support for FTL JIT on ARM64
2222         https://bugs.webkit.org/show_bug.cgi?id=139677
2223
2224         Reviewed by Csaba Osztrogonác.
2225
2226         * gtk/jhbuild-optional.modules:
2227         * gtk/patches/llvm-elf-add-stackmaps-arm64.patch: Added.
2228         * gtk/patches/llvm-elf-allow-fde-references-outside-the-2gb-range-arm64.patch: Added.
2229
2230 2014-12-18  Adrian Perez de Castro  <aperez@igalia.com>
2231
2232         [GTK] Implement webkit_web_view_is_playing_audio()
2233         https://bugs.webkit.org/show_bug.cgi?id=138918
2234
2235         Reviewed by Carlos Garcia Campos.
2236
2237         Add test case case for webkit_web_view_is_playing_audio() and the
2238         WebKitWebView::is-playing-audio property.
2239
2240         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2241         (urlForResource): Utility function to get URLs pointing to resources
2242         under the Tools/TestWebKitAPI/Tests/WebKit2/ directory.
2243         (testWebViewIsPlayingAudio): Added.
2244         (beforeAll):
2245         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
2246         (getResourcesDir): Allow passing a flag to choose from the WebKit2 GTK
2247         API tests resources directory, or the WebKit2 C API tests resources
2248         directory. The default value of the flag is to use the WebKit2 GTK
2249         one, to avoid having to change existing tests.
2250         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2251         (isPlayingAudioChanged): Added.
2252         (WebViewTest::waitUntilIsPlayingAudioChanged): Added.
2253         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
2254
2255 2014-12-18  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2256
2257         [GTK] [EFL] Enable per_test_timeout
2258         https://bugs.webkit.org/show_bug.cgi?id=139771
2259
2260         Reviewed by Csaba Osztrogonác.
2261
2262         This is needed to make WKTR use either the default port timeout, or the
2263         user supplied timeout via the "--time-out-ms" parameter of run-webkit-tests.
2264         Otherwise WTR will use the default (30 seconds after r177363 and r177471).
2265
2266         * Scripts/webkitpy/port/efl.py:
2267         (EflPort.supports_per_test_timeout): Enabled.
2268         * Scripts/webkitpy/port/gtk.py:
2269         (GtkPort.supports_per_test_timeout): Enabled.
2270
2271 2014-12-17  Lucas Forschler  <lforschler@apple.com>
2272
2273         Move Apple buildbot slaves to their new home.
2274         
2275         Reviewed by Roger Fong.
2276
2277         * BuildSlaveSupport/build.webkit.org-config/config.json:
2278
2279 2014-12-17  Alexey Proskuryakov  <ap@apple.com>
2280
2281         REGRESSION (r177363): Gtk and Efl testing is broken
2282         https://bugs.webkit.org/show_bug.cgi?id=139734
2283
2284         Reviewed by Simon Fraser.
2285
2286         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2287         (SingleTestRunner.__init__): Remove timeout adjustment from here, because it
2288         affected both script and tool timeout. This is still the right place for this logic,
2289         but it would be a larger refactoring than I can do right now.
2290
2291         * Scripts/webkitpy/port/base.py:
2292         (Port.supports_per_test_timeout): Added a FIXME.
2293         (Port.default_timeout_ms): Now that the effective timeout is longer, change this
2294         to avoid making tests take more time.
2295
2296         * Scripts/webkitpy/port/driver.py:
2297         (Driver.run_test): Adjust script timeout here.
2298         (Driver._check_for_driver_timeout): Fix the timeout detection.
2299         (Driver._read_block): Actually use the timeout detection code.
2300
2301         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting):
2302         Use TestRunner default timeout when there isn't a timeout passed from command line for the test.
2303
2304         * Scripts/webkitpy/port/port_testcase.py: (PortTestCase.test_default_timeout_ms):
2305         Update results for the new default.
2306
2307         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2308         (RunTest.test_hung_thread): Restore a test that I previously deleted, it was
2309         actually a good one.
2310
2311 2014-12-17  Commit Queue  <commit-queue@webkit.org>
2312
2313         Unreviewed, rolling out r177456.
2314         https://bugs.webkit.org/show_bug.cgi?id=139749
2315
2316         Broke webkitpy and Mac tests (Requested by ap on #webkit).
2317
2318         Reverted changeset:
2319
2320         "REGRESSION (r177363): Gtk and Efl testing is broken"
2321         https://bugs.webkit.org/show_bug.cgi?id=139734
2322         http://trac.webkit.org/changeset/177456
2323
2324 2014-12-17  Alexey Proskuryakov  <ap@apple.com>
2325
2326         REGRESSION (r177363): Gtk and Efl testing is broken
2327         https://bugs.webkit.org/show_bug.cgi?id=139734
2328
2329         Reviewed by Simon Fraser.
2330
2331         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2332         (SingleTestRunner.__init__): Remove timeout adjustment from here, because it
2333         affected both script and tool timeout. This is still the right place for this logic,
2334         but it would be a larger refactoring than I can do right now.
2335
2336         * Scripts/webkitpy/port/base.py:
2337         (Port.supports_per_test_timeout): Added a FIXME.
2338         (Port.default_timeout_ms): Now that the effective timeout is longer, change this
2339         to avoid making tests take more time.
2340
2341         * Scripts/webkitpy/port/driver.py: (Driver.run_test): Adjust script timeout here.
2342
2343         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting):
2344         Use TestRunner default timeout when there isn't a timeout passed from command line for the test.
2345
2346 2014-12-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2347
2348         [GTK] Simplify timeout handling in TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded
2349         https://bugs.webkit.org/show_bug.cgi?id=139725
2350
2351         Reviewed by Martin Robinson.
2352
2353         The timeout is already in milliseconds, so we don't need to do any conversion.
2354
2355         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
2356         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
2357
2358 2014-12-17  Hunseop Jeong  <hs85.jeong@samsung.com>
2359
2360         [EFL]Fix build warning in MiniBrowser
2361         https://bugs.webkit.org/show_bug.cgi?id=139723
2362
2363         Reviewed by Darin Adler.
2364
2365         The warning is caused by the compiler wanting the first argument to be a
2366         string literal, not a dynamically created string.
2367
2368         * MiniBrowser/efl/main.c:
2369         (quit):
2370
2371 2014-12-16  Sam Weinig  <sam@webkit.org>
2372
2373         TestWebKitAPI should use a static lib to support both Mac and iOS cleanly
2374         https://bugs.webkit.org/show_bug.cgi?id=139718
2375
2376         Reviewed by Mark Rowe.
2377
2378         Change TestWebKitAPI to be more like DumpRenderTree by moving all the source
2379         files into a static lib which the command line utility can link link against.
2380         This will allow us to create a TestWebKitAPI.app that can run on iOS.
2381
2382         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2383         * TestWebKitAPI/Configurations/TestWebKitAPILibrary.xcconfig: Added.
2384         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2385
2386 2014-12-16  Alexey Proskuryakov  <ap@apple.com>
2387
2388         Sort out timeout implementations in DRT and WKTR
2389         https://bugs.webkit.org/show_bug.cgi?id=139671
2390
2391         Remove an obsolete test that doesn't capture how run-webkit-tests interacts
2392         with the tool.
2393
2394         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2395         (RunTest.test_hung_thread):
2396
2397 2014-12-15  Alexey Proskuryakov  <ap@apple.com>
2398
2399         Sort out timeout implementations in DRT and WKTR
2400         https://bugs.webkit.org/show_bug.cgi?id=139671
2401
2402         Reviewed by Simon Fraser.
2403
2404         Test timeout implementation had many deficiencies, please see the bug for details.
2405         Most notably, we shouldn't have the tool confused about timeouts vs. failures, and
2406         [ Slow ] modifiers should work a lot better.
2407
2408         * DumpRenderTree/TestRunner.cpp: (TestRunner::TestRunner):
2409         * DumpRenderTree/TestRunner.h: (TestRunner::setCustomTimeout):
2410         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest):
2411         * DumpRenderTree/mac/TestRunnerMac.mm: (TestRunner::setWaitToDump):
2412         DumpRenderTree already read the --timeout option from command line, and webkitpy
2413         was already configured to pass it on Mac and iOS. Let's actually use it.
2414         TestCommand already had the same 30 second default, so this doesn't change behavior
2415         when DRT is ran manually without the option.
2416         Windows DumpRenderTree will need to be fixed separately (that's easy).
2417
2418         * DumpRenderTree/TestRunner.cpp: (TestRunner::waitToDumpWatchdogTimerFired()):
2419         Don't print the timeout message to stdout to match WebKitTestRunner. It would be
2420         slightly better to use stderr in both, as this is an out of band message, but
2421         that's a larger refactoring, and the difference is minimal in practice.
2422
2423         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2424         (SingleTestRunner.__init__): Ensure that script and tool timeouts are substantially
2425         different. We want the tool to reliably detect timeouts that can be detected, and
2426         not race with the script for that.
2427
2428         * Scripts/webkitpy/port/base.py: (Port.default_timeout_ms): Don't make WebKit2
2429         timeout longer than WebKit1 one, I doubt that this is necessary. Now that the value
2430         is honored inmore cases, that could make tests run slower.
2431         * Scripts/webkitpy/port/driver.py:
2432         (Driver.__init__):
2433         (Driver.run_test):
2434         (Driver.cmd_line):
2435         (Driver._check_for_driver_timeout):
2436         Detect tests that have the timeout output, and make these have the proper Timeout result.
2437
2438         * Scripts/webkitpy/port/ios.py: (IOSSimulatorPort.default_timeout_ms): Remove an
2439         incorrect recent change - 80 * 1000 is 80 seconds, not 80 milliseconds.
2440
2441         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2442         (WTR::TestRunner::setCustomTimeout): Deleted.
2443         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2444         (WTR::TestRunner::setCustomTimeout):
2445         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
2446         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
2447         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
2448         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
2449         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp:
2450         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
2451         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
2452         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
2453         Updated to use a timeout passed from UI process, which used to be ignored.
2454
2455         * WebKitTestRunner/TestController.cpp:
2456         (WTR::TestController::TestController):
2457         (WTR::TestController::runUntil):
2458         (WTR::TestController::getCustomTimeout): Deleted.
2459         * WebKitTestRunner/TestController.h:
2460         Delete unused m_timeout. First, it was always 0, and second, we don't need it at all.
2461         Changed default message timeouts to match new run-webkit-tests timeout. These don't
2462         affect ports where timeout is passed per test (shouldn't they all be like that?).
2463
2464         * WebKitTestRunner/TestInvocation.cpp:
2465         (WTR::TestInvocation::invoke):
2466         (WTR::TestInvocation::setCustomTimeout): Deleted.
2467         * WebKitTestRunner/TestInvocation.h:
2468         (WTR::TestInvocation::setCustomTimeout):
2469         (WTR::TestInvocation::customTimeout):
2470         Ditto.
2471
2472 2014-12-16  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
2473
2474         [EFL] Add logging domain for MiniBrowser
2475         https://bugs.webkit.org/show_bug.cgi?id=139642
2476
2477         Reviewed by Gyuyoung Kim.
2478
2479         Similarly to EWebKit2, provide logging facility for MiniBrowser
2480         based on Eina Log module to have a convenient way to display
2481         all/subset/none messages for EFL based libraries and MiniBrowser.
2482
2483         Usage:
2484         1. Disable all messages:
2485            EINA_LOG_LEVEL=0 ./Tools/Scripts/run-launcher --efl
2486
2487         2. Enable all messages:
2488            EINA_LOG_LEVEL=7 ./Tools/Scripts/run-launcher --efl
2489
2490         3. Enable MiniBrowser and EWebkit2 messages only:
2491            EINA_LOG_LEVELS="minibrowser:7,ewebkit2:7" ./Tools/Scripts/run-launcher --efl
2492
2493         More information and examples you can find here:
2494         http://docs.enlightenment.org/auto/eet/tutorial_log_page.html
2495
2496         * MiniBrowser/efl/main.c:
2497         (on_mouse_wheel):
2498         (on_window_resize):
2499         (save_page_contents_callback):
2500         (script_execute_callback):
2501         (on_key_down):
2502         (on_download_request):
2503         (on_download_finished):
2504         (on_download_failed):
2505         (quit):
2506         (on_refresh_button_clicked):
2507         (on_stop_button_clicked):
2508         (navigation_button_longpress_process):
2509         (on_popup_menu_item_clicked):
2510         (popup_menu_populate):
2511         (on_popup_menu_show):
2512         (on_window_create):
2513         (context_menu_item_selected_cb):
2514         (context_menu_populate):
2515         (on_context_menu_show):
2516         (on_context_menu_hide):
2517         (on_navigation_policy_decision):
2518         (window_create):
2519         (parse_cookies_policy):
2520         (elm_main):
2521         (has_scheme):
2522         (list_item_label_get):
2523         (on_popup_menu_hide):
2524         (on_window_close):
2525         (on_home_button_clicked):
2526         Replace locally info() macro with newly introduced
2527         one which uses Eina Log module. There is no logic change.
2528
2529 2014-12-15  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
2530
2531         [EFL] FTL JIT not working on ARM64
2532         https://bugs.webkit.org/show_bug.cgi?id=139295
2533
2534         Reviewed by Michael Saboff.
2535
2536         Added patches for llvm to add ARM64 support for FTL JIT
2537
2538         * efl/jhbuild.modules:
2539         * efl/patches/llvm-elf-add-stackmaps-arm64.patch: Added.
2540         * efl/patches/llvm-elf-allow-fde-references-outside-the-2gb-range-arm64.patch: Added.
2541
2542 2014-12-15  Timothy Horton  <timothy_horton@apple.com>
2543
2544         Move Said to the committers section.
2545
2546         * Scripts/webkitpy/common/config/contributors.json:
2547
2548 2014-12-15  Timothy Horton  <timothy_horton@apple.com>
2549
2550         Implement Data Detectors immediate actions for WebKit2
2551         https://bugs.webkit.org/show_bug.cgi?id=139617
2552         <rdar://problem/19198539>
2553
2554         Reviewed by Beth Dakin.
2555
2556         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
2557         (TestWebKitAPI::TEST):
2558         Temporarily disable the action menu tests while the
2559         underlying code is in flux.
2560
2561 2014-12-14  Andreas Kling  <akling@apple.com>
2562
2563         Replace PassRef with Ref/Ref&& across the board.
2564         <https://webkit.org/b/139587>
2565
2566         Reviewed by Darin Adler.
2567
2568         * TestWebKitAPI/Tests/WTF/Ref.cpp:
2569         (TestWebKitAPI::passWithRef):
2570         (TestWebKitAPI::TEST):
2571         (TestWebKitAPI::passWithPassRef): Deleted.
2572         * TestWebKitAPI/Tests/WTF/RefCounter.cpp:
2573         (TestWebKitAPI::TEST):
2574         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
2575         (TestWebKitAPI::TEST):
2576         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
2577         (TestWebKitAPI::createTestValue):
2578
2579 2014-12-13  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
2580
2581         [EFL] MiniBrowser's window_create may return NULL
2582         https://bugs.webkit.org/show_bug.cgi?id=139585
2583
2584         Reviewed by Gyuyoung Kim.
2585
2586         Move NULL checking before using object which window_create
2587         returns.
2588
2589         * MiniBrowser/efl/main.c:
2590         (elm_main):
2591
2592 2014-12-12  Alexey Proskuryakov  <ap@apple.com>
2593
2594         Layout Test http/tests/loading/307-after-303-after-post.html is flaky
2595         https://bugs.webkit.org/show_bug.cgi?id=73030
2596
2597         Reviewed by Anders Carlsson.
2598
2599         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize): Set icon
2600         database to empty to avoid having it fetch default favicons at random times.
2601         DumpRenderTree also disables it, and also it has a way for tests to temporarily
2602         enable it.
2603
2604 2014-12-12  Lucas Forschler  <lforschler@apple.com>
2605
2606         Update Apple owned build slaves after infrastructure update.
2607         
2608         Reviewed by Ryosuke Niwa.
2609
2610         * BuildSlaveSupport/build.webkit.org-config/config.json:
2611
2612 2014-12-11  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2613
2614         [GTK] REGRESSION(r175555) GTK API Tests run outside the JHBuild.
2615         https://bugs.webkit.org/show_bug.cgi?id=139537
2616
2617         Reviewed by Carlos Garcia Campos.
2618
2619         * jhbuild/jhbuild-wrapper: Pass the port name in the invocation
2620         of get_dependencies_path().
2621         * jhbuild/jhbuildutils.py:
2622         (get_dependencies_path): Fix the function to return the new
2623         dependencies path: DependenciesPORT.
2624         (enter_jhbuild_environment_if_available): Pass the port name
2625         when invoking get_dependencies_path().
2626
2627 2014-12-10  Lucas Forschler  <lforschler@apple.com>
2628
2629         Update Apple owned build slaves.
2630         
2631         Rubber-stamped by Dana Burkart.
2632         
2633         * BuildSlaveSupport/build.webkit.org-config/config.json:
2634
2635 2014-12-10  Daniel Bates  <dabates@apple.com>
2636
2637         [iOS] REGRESSION (r174642): Watchdog timer expiration reported as DumpRenderTree.app
2638         timeout instead of test failure
2639         https://bugs.webkit.org/show_bug.cgi?id=139525
2640
2641         Reviewed by Zalan Bujtas.
2642
2643         Increase the default process timeout limit in run-webkit-tests to 80ms to prevent
2644         run-webkit-tests from prematurely terminating DumpRenderTree.app before it dumps
2645         output.
2646
2647         Following <http://trac.webkit.org/changeset/174642>, DumpRenderTree.app waits
2648         for the WebThread to spin its run loop before dumping its output. A test that
2649         calls testRunner.waitUntilDone() and does not subsequently call testRunner.notifyDone()
2650         before DumpRenderTree.app's watchdog timer expires may be incorrectly reported
2651         by run-webkit-tests as a DumpRenderTree.app timeout instead of a test failure
2652         because run-webkit-tests may terminate a DumpRenderTree.app process when it
2653         exceeds its process time limit (defaults to 35ms) regardless of whether such
2654         a DumpRenderTree.app process was waiting for the WebThread to run so as to dump output.
2655
2656         * Scripts/webkitpy/port/ios.py:
2657         (IOSSimulatorPort.default_timeout_ms):
2658
2659 2014-12-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
2660
2661         [GTK][WK2] Add HTML5 Notifications support
2662         https://bugs.webkit.org/show_bug.cgi?id=61140
2663
2664         Reviewed by Carlos Garcia Campos.
2665
2666         * Scripts/webkitperl/FeatureList.pm: enable notifications for GTK+.
2667         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2668         (testWebViewNotification):
2669         (beforeAll):
2670         * MiniBrowser/gtk/BrowserWindow.c: also handle notification permission requests.
2671         (permissionRequestDialogCallback):
2672         (webViewDecidePermissionRequest):
2673         (geolocationRequestDialogCallback): Deleted.
2674
2675 2014-12-09  Benjamin Poulain  <bpoulain@apple.com>
2676
2677         Fix webkitpy test expectation
2678
2679         Not sure what I messed up, but TOTAL_SKIPS was not right.
2680
2681         * Scripts/webkitpy/port/test.py:
2682
2683 2014-12-09  Benjamin Poulain  <bpoulain@apple.com>
2684
2685         Remove virtual test support from webkitpy
2686         https://bugs.webkit.org/show_bug.cgi?id=139427
2687
2688         Reviewed by Alexey Proskuryakov.
2689
2690         It seems that the only concrete client of virtual tests is the unit tests :D
2691
2692         This patch tries to clean as much useless code as possible.
2693
2694         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2695         (RunTest.test_tolerance):
2696         (RunTest.test_virtual): Deleted.
2697         * Scripts/webkitpy/layout_tests/views/printing.py:
2698         (Printer._print_test_trace):
2699         * Scripts/webkitpy/port/base.py:
2700         (Port.expected_filename):
2701         (Port.tests):
2702         (Port.test_isfile):
2703         (Port.test_isdir):
2704         (Port.sample_process):
2705         (Port.find_system_pid):
2706         (Port.test_expectations_file_position):
2707         (Port.virtual_test_suites): Deleted.
2708         (Port): Deleted.
2709         (Port.populated_virtual_test_suites): Deleted.
2710         (Port._virtual_tests): Deleted.
2711         (Port.lookup_virtual_test_base): Deleted.
2712         (Port.lookup_virtual_test_args): Deleted.
2713         (VirtualTestSuite): Deleted.
2714         (VirtualTestSuite.__init__): Deleted.
2715         (VirtualTestSuite.__repr__): Deleted.
2716         * Scripts/webkitpy/port/base_unittest.py:
2717         (PortTest.test_test_exists):
2718         (PortTest.test_test_isfile):
2719         (PortTest.test_test_isdir):
2720         (PortTest.test_tests):
2721         * Scripts/webkitpy/port/driver.py:
2722         (DriverProxy.run_test): Deleted.
2723         * Scripts/webkitpy/port/test.py:
2724         (TestPort._skipped_tests_for_unsupported_features):
2725         (TestPort.all_baseline_variants):
2726         (TestPort.virtual_test_suites): Deleted.
2727         * Scripts/webkitpy/tool/commands/queries.py:
2728         (PrintBaselines.__init__):
2729         (PrintBaselines.execute):
2730         * Scripts/webkitpy/tool/commands/queries_unittest.py:
2731         (PrintBaselinesTest.test_basic):
2732         (PrintBaselinesTest.test_multiple):
2733         (PrintBaselinesTest.test_csv):
2734
2735 2014-12-09  Csaba Osztrogonác  <ossy@webkit.org>
2736
2737         Blink Merge: Remove 'http_lock' code from webkitpy
2738         https://bugs.webkit.org/show_bug.cgi?id=136722
2739
2740         Reviewed by Alexey Proskuryakov.
2741
2742         Based on Blink commit by Dirk Pranke <dpranke@chromium.org>
2743         https://chromium.googlesource.com/chromium/blink/+/196f8146a948275c2f1594b13e30ab19a6e6fd66
2744
2745         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2746         (LayoutTestRunner.__init__):
2747         (LayoutTestRunner.run_tests):
2748         (LayoutTestRunner.start_servers): Renamed from start_servers_with_lock.
2749         (LayoutTestRunner.stop_servers): Renamed from stop_servers_with_lock.
2750         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
2751         (FakePrinter.flush):
2752         (LayoutTestRunnerTests._runner):
2753         (LayoutTestRunnerTests._run_tests):
2754         (LayoutTestRunnerTests.test_servers_started):
2755         (LockCheckingRunner): Deleted.
2756         (LockCheckingRunner.__init__): Deleted.
2757         (LockCheckingRunner.handle_finished_list): Deleted.
2758         (LayoutTestRunnerTests.test_http_locking): Deleted.
2759         * Scripts/webkitpy/port/base.py:
2760         (Port.__init__):
2761         (Port.to.http_server_supports_ipv6):
2762         (Port.to.stop_websocket_server):
2763         (Port.to.acquire_http_lock): Deleted.
2764         (Port.to.release_http_lock): Deleted.
2765         * Scripts/webkitpy/port/http_lock.py: Removed.
2766         * Scripts/webkitpy/port/http_lock_unittest.py: Removed.
2767         * Scripts/webkitpy/port/ios.py:
2768         (IOSSimulatorPort.show_results_html_file):
2769         (IOSSimulatorPort.acquire_http_lock): Deleted.
2770         (IOSSimulatorPort): Deleted.
2771         (IOSSimulatorPort.release_http_lock): Deleted.
2772         * Scripts/webkitpy/port/mac.py:
2773         (MacPort.show_results_html_file):
2774         (MacPort): Deleted.
2775         (MacPort.acquire_http_lock): Deleted.
2776         (MacPort.release_http_lock): Deleted.
2777         * Scripts/webkitpy/port/mock_drt.py:
2778         (MockDRTPort.start_websocket_server):
2779         (MockDRTPort.stop_websocket_server):
2780         (MockDRTPort.acquire_http_lock): Deleted.
2781         (MockDRTPort.release_http_lock): Deleted.
2782         * Scripts/webkitpy/port/mock_drt_unittest.py:
2783         (MockDRTPortTest.test_uses_apache):
2784         (MockDRTPortTest.integration_test_http_lock): Deleted.
2785         * Scripts/webkitpy/port/port_testcase.py:
2786         (PortTestCase.assert_servers_are_up):
2787         (PortTestCase.integration_test_http_lock): Deleted.
2788         * Scripts/webkitpy/port/test.py:
2789         (TestPort.start_websocket_server):
2790         (TestPort.stop_websocket_server):
2791         (TestPort.acquire_http_lock): Deleted.
2792         (TestPort.release_http_lock): Deleted.
2793
2794 2014-12-09  Alberto Garcia  <berto@igalia.com>
2795
2796         convertToUTF8String converts null string to empty string
2797         https://bugs.webkit.org/show_bug.cgi?id=133904
2798
2799         Reviewed by Carlos Garcia Campos.
2800
2801         Test that trying to get the value of a non-existent attribute
2802         returns 0 instead of an empty string.
2803
2804         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
2805         (WebKitDOMNodeTest::testInsertion):
2806
2807 2014-12-09  Joanmarie Diggs  <jdiggs@igalia.com>
2808
2809         [GTK] Bump minimum version of ATK used by jhbuild to at least 2.15.2
2810         https://bugs.webkit.org/show_bug.cgi?id=139070
2811
2812         Reviewed by Carlos Garcia Campos.
2813
2814         * gtk/jhbuild.modules:
2815
2816 2014-12-08  Tim Horton  <timothy_horton@apple.com>
2817
2818         Add action menu tests
2819         https://bugs.webkit.org/show_bug.cgi?id=139156
2820
2821         Reviewed by Dean Jackson.
2822
2823         * TestWebKitAPI/PlatformWebView.h:
2824         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2825         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2826         Add a mechanism allowing tests to provide their own WKView subclass.
2827
2828         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2829         * TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Added.
2830         Add a file with lots of menu targets.
2831
2832         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm: Added.
2833         (-[ActionMenusTestWKView _actionMenuItemsForHitTestResult:withType:defaultActionMenuItems:userData:]):
2834         (-[ActionMenusTestWKView runMenuSequenceAtPoint:preMenuNeedsUpdateHandler:preWillOpenMenuHandler:preDidCloseMenuHandler:]):
2835         (-[ActionMenusTestWKView runMenuSequenceAtPoint:preDidCloseMenuHandler:]):
2836         Run through the normal sequence of callbacks, recording what items and type were returned, and give clients a chance to do work at various points in the process.
2837
2838         (-[ActionMenusTestWKView _setOverrideActionMenuItems:]):
2839
2840         (TestWebKitAPI::didFinishLoadForFrameCallback):
2841         (TestWebKitAPI::didFinishDownloadCallback):
2842         (TestWebKitAPI::didCreateDownloadDestinationCallback):
2843         Watch downloads and ensure that they match the content we expect.
2844
2845         (TestWebKitAPI::watchPasteboardForString):
2846         (TestWebKitAPI::watchPasteboardForImage):
2847         (TestWebKitAPI::JavaScriptStringCallbackContext::JavaScriptStringCallbackContext):
2848         (TestWebKitAPI::JavaScriptBoolCallbackContext::JavaScriptBoolCallbackContext):
2849         (TestWebKitAPI::javaScriptStringCallback):
2850         (TestWebKitAPI::javaScriptBoolCallback):
2851         (TestWebKitAPI::callJavaScriptReturningString):
2852         (TestWebKitAPI::callJavaScriptReturningBool):
2853         (TestWebKitAPI::watchEditableAreaForString):
2854         (TestWebKitAPI::waitForVideoReady):
2855         (TestWebKitAPI::retrieveSelection):
2856         (TestWebKitAPI::retrieveSelectionInElement):
2857         (TestWebKitAPI::performMenuItemAtIndexOfTypeAsync):
2858         (TestWebKitAPI::ensureMenuItemAtIndexOfTypeIsDisabled):
2859         Add many helpers for testing, especially to make asynchronous things synchronous.
2860
2861         (TestWebKitAPI::windowPointForTarget):
2862         (TestWebKitAPI::inset8):
2863         Hard-code points in action-menu-targets.html for hit testing.
2864
2865         (TestWebKitAPI::TEST):
2866         Add a suite of tests for WebKit2 action menus.
2867
2868         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm: Added.
2869         (TestWebKitAPI::createActionContextForPhoneNumber):
2870         (TestWebKitAPI::ActionMenuTest::ActionMenuTest):
2871         (TestWebKitAPI::ActionMenuTest::prepareForActionMenu):
2872         (TestWebKitAPI::ActionMenuTest::actionContextForResultAtPoint):
2873         (TestWebKitAPI::ActionMenuTest::drawRect):
2874         (TestWebKitAPI::ActionMenuTest::didCreatePage):
2875         Add a bundle with a PageOverlay and a actionContextForResultAtPoint override,
2876         so that we can test that infrastructure.
2877
2878 2014-12-08  Philippe Normand  <pnormand@igalia.com>
2879
2880         [GTK] UserMedia Permission Request API
2881         https://bugs.webkit.org/show_bug.cgi?id=136449
2882
2883         Reviewed by Carlos Garcia Campos.
2884
2885         The GTK version of the MiniBrowser has gained UserMedia permission
2886         request support.
2887
2888         * MiniBrowser/gtk/BrowserWindow.c: Show a popup when the page
2889         requires user permission to access audio/video devices.
2890         (permissionRequestDialogCallback):
2891         (webViewDecidePermissionRequest):
2892         (geolocationRequestDialogCallback): Deleted.
2893
2894 2014-12-08  Anders Carlsson  <andersca@apple.com>
2895
2896         Add a stubbed out method for clearing out the website data store
2897         https://bugs.webkit.org/show_bug.cgi?id=139404
2898
2899         Reviewed by Antti Koivisto.
2900
2901         Add a debug menu item for testing clearing of website data.
2902
2903         * MiniBrowser/mac/MainMenu.xib:
2904         * MiniBrowser/mac/WK2BrowserWindowController.m:
2905         (-[WK2BrowserWindowController clearWebsiteData:]):
2906
2907 2014-12-07  Gwang Yoon Hwang  <yoon@igalia.com>
2908
2909         Update style checker to deal with "const override"
2910         https://bugs.webkit.org/show_bug.cgi?id=139371
2911
2912         Reviewed by Csaba Osztrogonác.
2913
2914         check-webkit-style shouldn't complain about an open brace to start a
2915         line after a function definition with const override.
2916
2917         * Scripts/webkitpy/style/checkers/cpp.py:
2918         (check_braces):
2919         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2920         (CppStyleTest.test_brace_at_begin_of_line):
2921
2922 2014-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
2923
2924         [GTK] Fix GObject DOM bindings API break tests after r176920
2925         https://bugs.webkit.org/show_bug.cgi?id=139368
2926
2927         Reviewed by Gustavo Noronha Silva.
2928
2929         Remove the @version from the symbol name before comparing.
2930
2931         * gtk/check-for-webkitdom-api-breaks:
2932         (read_expected_api):
2933
2934 2014-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
2935
2936         Remove the option to automatically update the GObject DOM bindings symbols file
2937         https://bugs.webkit.org/show_bug.cgi?id=139366
2938
2939         Reviewed by Martin Robinson.
2940
2941         It's currently broken, because symbols now need to be in a
2942         specific order. Now that the symbols file only contains stable
2943         API, it's not a problem to manually update it every time new API
2944         is added.
2945
2946         * gtk/check-for-webkitdom-api-breaks:
2947         (read_expected_api):
2948         (check_api):
2949         (write_expected_api): Deleted.
2950
2951 2014-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
2952
2953         [GTK] Use GMainLoopSource in WebKitTestRunner
2954         https://bugs.webkit.org/show_bug.cgi?id=138831
2955
2956         Reviewed by Sergio Villar Senin.
2957
2958         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2959         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
2960         (WTR::TestRunner::platformInitialize):
2961         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
2962         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
2963         (WTR::waitToDumpWatchdogTimerCallback): Deleted.
2964         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2965         (WTR::TestController::notifyDone):
2966         (WTR::TestController::platformRunUntil):
2967         (WTR::cancelTimeout): Deleted.
2968
2969 2014-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
2970
2971         [GTK] Missing API detected in GObject DOM bindings after r176630
2972         https://bugs.webkit.org/show_bug.cgi?id=139201
2973
2974         Reviewed by Gustavo Noronha Silva.
2975
2976         Handle deprecated symbols again when generating the GObject DOM
2977         bindings documentation.
2978
2979         * gtk/webkitdom.py:
2980         (WebKitDOMDocGenerator):
2981         (WebKitDOMDocGenerator.is_deprecated_symbol_file):
2982         (WebKitDOMDocGenerator.generate):
2983         (WebKitDOMDocGeneratorSections.__init__):
2984         (WebKitDOMDocGeneratorSections._find_deprecated_symbols):
2985         (WebKitDOMDocGeneratorSections.write_section):
2986
2987 2014-12-07  Csaba Osztrogonác  <ossy@webkit.org>
2988
2989         [EFL][jhbuild] Fix libsoup build with clang
2990         https://bugs.webkit.org/show_bug.cgi?id=139088
2991
2992         Reviewed by Gyuyoung Kim.
2993
2994         * efl/jhbuild.modules:
2995         * efl/patches/soup-clang-warning-fix1.patch: Added.
2996         * efl/patches/soup-clang-warning-fix2.patch: Added.
2997
2998 2014-12-06  Alexey Proskuryakov  <ap@apple.com>
2999
3000         [Mac] DumpRenderTree sets storage directory incorrectly
3001         https://bugs.webkit.org/show_bug.cgi?id=139347
3002
3003         Reviewed by Dan Bernstein.
3004
3005         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
3006         Don't use user defaults to pass per-instance paths, as user defaults are shared
3007         across all instances.
3008
3009 2014-12-05  Chris Fleizach  <cfleizach@apple.com>
3010
3011         AX: I cannot activate links on the mobile version of news.google.com
3012         https://bugs.webkit.org/show_bug.cgi?id=139330
3013
3014         Reviewed by Simon Fraser.
3015
3016         Implement press for iOS.
3017
3018         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3019         (AccessibilityUIElement::press):
3020
3021 2014-12-05  Daniel Bates  <dabates@apple.com>
3022
3023         [iOS] Query -[WAKWindow screenScale] instead of using WKGetScreenScaleFactor()
3024         https://bugs.webkit.org/show_bug.cgi?id=139326
3025
3026         Reviewed by Anders Carlsson.
3027
3028         Ask the window for its screen scale factor instead of calling WKGetScreenScaleFactor()
3029         to query the OS for it. This approach will ensure DumpRenderTree takes the snapshot
3030         using the same scale factor as used in WebKit.
3031
3032         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
3033         (createBitmapContextFromWebView):
3034
3035 2014-12-05  Anders Carlsson  <andersca@apple.com>
3036
3037         REGRESSION (r176677): All tests crash on Windows
3038         https://bugs.webkit.org/show_bug.cgi?id=139321
3039
3040         Reviewed by Alexey Proskuryakov.
3041
3042         * DumpRenderTree/win/DumpRenderTree.cpp:
3043         (runTest):
3044         Don't call CFRelease on the url while we have an outstanding pointer to its string,
3045         and use the right number of bytes when allocating the testURL buffer.
3046
3047 2014-12-05  Daniel Bates  <dabates@apple.com>
3048
3049         [iOS] DumpRenderTree produces many reference test mismatches
3050         https://bugs.webkit.org/show_bug.cgi?id=139314
3051
3052         Reviewed by Simon Fraser.
3053
3054         Fixes an issue where the scale factor used to render the snapshot taken by
3055         DumpRenderTree may differ from the device scale factor. In particular, the
3056         scale factor used to render a snapshot of a test may differ from the scale
3057         factor used to render the snapshot of its expected result.
3058
3059         Currently DumpRenderTree uses SPI, -[UIView newSnapshotForRect], on iOS to
3060         snapshot the UIWebBrowserView. This SPI always render using a scale factor
3061         of one when the backing store for the LegacyTileLayer objects were out-of-
3062         date regardless of the device scale factor. Instead we should use UIImage
3063         and CALayer API to perform the snapshot with respect to the device scale
3064         factor.
3065
3066         Additionally write iOS pixel dump support logic in terms of existing
3067         DumpRenderTree abstractions so as to support generating and comparing
3068         pixel dump checksums as well as make the iOS code more consistent with
3069         the logic used by other ports.
3070
3071         * DumpRenderTree/PixelDumpSupport.cpp:
3072         (dumpWebViewAsPixelsAndCompareWithExpected): Removed !PLATFORM(IOS)-guard.
3073         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
3074         (BitmapContext::createFromUIImage): Added.
3075         (BitmapContext::pixelData): Added.
3076         (BitmapContext::BitmapContext): Added.
3077         (computeMD5HashStringForBitmapContext): Added.
3078         (dumpBitmap): Added.
3079         (createBitmapContextFromWebView): Moved logic from dumpWebViewAsPixelsAndCompareWithExpected() to here.
3080         (dumpWebViewAsPixelsAndCompareWithExpected): Deleted.
3081
3082 2014-12-05  Anders Carlsson  <andersca@apple.com>
3083
3084         Give all web pages a website data store
3085         https://bugs.webkit.org/show_bug.cgi?id=139317
3086
3087         Reviewed by Tim Horton.
3088
3089         * MiniBrowser/mac/AppDelegate.m:
3090         (-[BrowserAppDelegate newPrivateWindow:]):
3091         Don't release the controller - it's implicitly retained by the window.
3092
3093 2014-12-05  Daniel Bates  <dabates@apple.com>
3094
3095         [iOS] DumpRenderTree fails to render every other test when pixel tests are on
3096         https://bugs.webkit.org/show_bug.cgi?id=137581
3097         <rdar://problem/18642906>
3098
3099         Reviewed by Simon Fraser.
3100
3101         Fixes an issue where the DumpRenderTree snapshot may reflect the rendered content
3102         of the test that proceeded the currently running test.
3103
3104         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
3105         (dumpWebViewAsPixelsAndCompareWithExpected): Ensure that UIKit has performed a layout
3106         of the UIWebBrowserView view. Also, remove unnecessary call to -[UIWebDocumentView layoutTilesNow]
3107         as -[UIWebDocumentView newSnapshotWithRect] will layout the tiles.
3108
3109 2014-12-05  Jer Noble  <jer.noble@apple.com>
3110
3111         [WTF] MediaTime should support round-tripping from and to doubles.
3112         https://bugs.webkit.org/show_bug.cgi?id=139248
3113
3114         Reviewed by Eric Carlson.
3115
3116         Add API tests for new features of MediaTime. Update the LLDB python provider to correctly display
3117         the MediaTimes after this change.
3118
3119         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
3120         (WTF::operator<<):
3121         (TestWebKitAPI::TEST):
3122         * lldb/lldb_webkit.py:
3123         (WTFMediaTime_SummaryProvider):
3124         (WTFMediaTimeProvider.timeValueAsDouble):
3125         (WTFMediaTimeProvider.isIndefinite):
3126         (WTFMediaTimeProvider):
3127         (WTFMediaTimeProvider.hasDoubleValue):
3128
3129 2014-12-05  Anders Carlsson  <andersca@apple.com>
3130
3131         Add a private browsing mode to MiniBrowser
3132         https://bugs.webkit.org/show_bug.cgi?id=139308
3133
3134         Reviewed by Sam Weinig.
3135
3136         * MiniBrowser/mac/AppDelegate.m:
3137         (defaultConfiguration):
3138         (-[BrowserAppDelegate newWindow:]):
3139         (-[BrowserAppDelegate newPrivateWindow:]):
3140         * MiniBrowser/mac/MainMenu.xib:
3141         * MiniBrowser/mac/WK2BrowserWindowController.h:
3142         * MiniBrowser/mac/WK2BrowserWindowController.m:
3143         (-[WK2BrowserWindowController awakeFromNib]):
3144         (-[WK2BrowserWindowController initWithConfiguration:]):
3145         (-[WK2BrowserWindowController dealloc]):
3146         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
3147
3148 2014-12-04  Alexey Proskuryakov  <ap@apple.com>
3149
3150         Run http tests parallel
3151         https://bugs.webkit.org/show_bug.cgi?id=138958
3152
3153         Reviewed by Daniel Bates.
3154
3155         Remove the concept of "locked shard". Now http tests are just like any other tests.
3156         We start HTTP and WebSocket servers at the start if we need them, and terminate them
3157         when done with all the tests (not when the last http test runs, which is unnecessarily
3158         unpredictable).
3159
3160         This makes debug tests run in 8 minutes and 12 seconds on my Mac Pro. Without the
3161         patch, they used to take over 15 minutes.
3162
3163         As part of the fix, we no longer pass the number of servers to Apache. I don't
3164         think that these parameters did what we wanted them to do; Apache handles the load
3165         just fine without them.
3166
3167         The change applies to all platforms. I fixed everything I could find on Mac, and
3168         Ossy told me that he's been running http tests in parallel for a long time. If
3169         there is increased instability for some ports, it will need to be fixed - there is
3170         generally nothing special about http tests at this point, and most code is
3171         cross-platform in WebKit2.
3172
3173         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3174         (LayoutTestRunner.__init__):
3175         (LayoutTestRunner.run_tests):
3176         (LayoutTestRunner.start_servers_with_lock):
3177         (LayoutTestRunner._handle_started_test):
3178         (Worker.handle):
3179         (Sharder.__init__):
3180         (Sharder.shard_tests):
3181         (Sharder._shard_every_file):
3182         (Sharder._shard_by_directory):
3183         (LayoutTestRunner._handle_finished_test_list): Deleted.
3184         (LayoutTestRunner._handle_finished_test_list.find): Deleted.
3185         (Sharder._shard_in_two): Deleted.
3186         (Sharder): Deleted.
3187         (Sharder._resize_shards): Deleted.
3188         (Sharder._resize_shards.divide_and_round_up): Deleted.
3189         (Sharder._resize_shards.extract_and_flatten): Deleted.
3190         (Sharder._resize_shards.split_at): Deleted.
3191         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
3192         (FakePrinter.print_workers_and_shards):
3193         (LayoutTestRunnerTests.test_servers_started.start_http_server):
3194         (LayoutTestRunnerTests.test_servers_started):
3195         (SharderTests.get_shards):
3196         (SharderTests.test_shard_by_dir):
3197         (SharderTests.test_shard_every_file):
3198         (SharderTests): Deleted.
3199         (SharderTests.test_shard_in_two): Deleted.
3200         (SharderTests.test_shard_in_two_has_no_locked_shards): Deleted.
3201         (SharderTests.test_shard_in_two_has_no_unlocked_shards): Deleted.
3202         (SharderTests.test_multiple_locked_shards): Deleted.
3203         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3204         (ManagerTest.test_needs_servers.get_manager):
3205         (ManagerTest.integration_test_needs_servers.get_manager):
3206         (ManagerTest.test_look_for_new_crash_logs.get_manager):
3207         (ManagerTest):
3208         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3209         (_set_up_derived_options):
3210         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3211         (RunTest.test_batch_size):
3212         (RunTest.test_max_locked_shards): Deleted.
3213         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
3214         (LayoutTestApacheHttpd.__init__):
3215         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
3216         (TestLayoutTestApacheHttpd.test_start_cmd):
3217         * Scripts/webkitpy/layout_tests/servers/http_server.py:
3218         (Lighttpd.__init__):
3219         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
3220         (HttpServerBase.__init__):
3221         * Scripts/webkitpy/layout_tests/views/printing.py:
3222         (Printer.print_workers_and_shards):
3223         * Scripts/webkitpy/port/base.py:
3224         (Port.default_child_processes):
3225         (Port.to.start_http_server):
3226         (Port.default_max_locked_shards): Deleted.
3227         * Scripts/webkitpy/port/port_testcase.py:
3228         (PortTestCase.make_port):
3229         (PortTestCase.test_default_max_locked_shards): Deleted.
3230         * Scripts/webkitpy/port/test.py:
3231         (TestPort.start_http_server):
3232
3233 2014-12-04  Alexey Proskuryakov  <ap@apple.com>
3234
3235         Don't lock perf tests in run-webkit-tests
3236         https://bugs.webkit.org/show_bug.cgi?id=139264
3237
3238         Reviewed by Daniel Bates.
3239
3240         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3241         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
3242         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3243         * Scripts/webkitpy/layout_tests/models/test_input.py:
3244         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3245
3246 2014-12-03  Alexey Proskuryakov  <ap@apple.com>
3247
3248         http/tests/security/mixedContent/about-blank-iframe-in-main-frame.html fails unless certain other tests run before it
3249         https://bugs.webkit.org/show_bug.cgi?id=139243
3250
3251         Reviewed by Anders Carlsson.
3252
3253         We didn't get WKPageLoaderClient calls in secondary windows, so we didn't have a
3254         chance to allow untrusted certificates.
3255
3256         * WebKitTestRunner/TestController.cpp: (WTR::TestController::createOtherPage):
3257         Set up more client objects for secondary windows. We may be able to share some of the
3258         code with main view creation function, but it's not exactly the same (notably, we
3259         do not focus a secondary window when it's done loading).
3260
3261 2014-12-03  Joanmarie Diggs  <jdiggs@igalia.com>
3262
3263         AX: [ATK] Inline text elements with accessible object attributes and/or event handlers are not exposed
3264         https://bugs.webkit.org/show_bug.cgi?id=139071
3265
3266         Reviewed by Chris Fleizach.
3267
3268         Add string value for ATK_ROLE_STATIC in roleToString.
3269
3270         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3271
3272 2014-12-03  Renato Nagy  <rnagy@inf.u-szeged.hu>
3273
3274         check-webkit-style is confused by ternary expression inside first member initializer
3275         https://bugs.webkit.org/show_bug.cgi?id=136442
3276
3277         Reviewed by Csaba Osztrogonác.
3278
3279         * Scripts/webkitpy/style/checkers/cpp.py:
3280         (check_member_initialization_list):
3281
3282 2014-12-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3283
3284         [GTK] [JHBuild] gst-plugins-bad fails to build if the GNUStep libraries are installed.
3285         https://bugs.webkit.org/show_bug.cgi?id=139220
3286
3287         Reviewed by Philippe Normand.
3288
3289         * gtk/jhbuild.modules:
3290         * gtk/patches/gst-plugins-bad-remove-gnustep-support.patch: Added.
3291
3292 2014-12-03  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
3293
3294         Remove unused JSC runtime options
3295         https://bugs.webkit.org/show_bug.cgi?id=133070
3296
3297         Reviewed by Csaba Osztrogonác.
3298
3299         * Scripts/run-jsc-stress-tests:
3300
3301 2014-12-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3302
3303         [EFL] Add subtle crypto to the build system
3304         https://bugs.webkit.org/show_bug.cgi?id=138612
3305
3306         Reviewed by Csaba Osztrogonác.
3307
3308         * Scripts/webkitperl/FeatureList.pm:
3309
3310 2014-12-02  Joanmarie Diggs  <jdiggs@igalia.com>
3311
3312         AX: [ATK] Table captions and table rows are missing from the accessible hierarchy
3313         https://bugs.webkit.org/show_bug.cgi?id=139005
3314
3315         Reviewed by Chris Fleizach.
3316
3317         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3318         Add mapping for ATK_ROLE_CAPTION to roleToString
3319
3320 2014-12-02  Alexey Proskuryakov  <ap@apple.com>
3321
3322         http/tests/appcache/main-resource-fallback-for-network-error-crash.html can break subsequent tests
3323         https://bugs.webkit.org/show_bug.cgi?id=139149
3324
3325         Reviewed by Anders Carlsson.
3326
3327         WebKit2 already cleared application caches between runs (although it wasn't entirely
3328         effective without WebCore changes in this patch).
3329
3330         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Clear applicaiton caches between runs.
3331
3332         * DumpRenderTree/win/DumpRenderTree.cpp: (runTest): Ditto (unfortunately, this
3333         function is not implemented on Windows, see below).
3334
3335         * DumpRenderTree/win/TestRunnerWin.cpp: (TestRunner::clearAllApplicationCaches):
3336         Ameded a FIXME.
3337
3338 2014-12-02  Gavin Barraclough  <barraclough@apple.com>
3339
3340         Generalize PageActivityAssertionToken
3341         https://bugs.webkit.org/show_bug.cgi?id=139106
3342
3343         Reviewed by Sam Weinig.
3344
3345         Add an API test for WTF::RefCounter.
3346
3347         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3348         * TestWebKitAPI/Tests/WTF/RefCounter.cpp: Added.
3349         (TestWebKitAPI::TEST):
3350             - added RefCounter test.
3351
3352 2014-12-02  Alexey Proskuryakov  <ap@apple.com>
3353
3354         [Mac, iOS] Crash log application information contains latest main frame URL instead of test URL
3355         https://bugs.webkit.org/show_bug.cgi?id=139174
3356
3357         Reviewed by Simon Fraser.
3358
3359         * DumpRenderTree/TestRunner.cpp:
3360         * DumpRenderTree/TestRunner.h:
3361         Renamed testPathOrURL to testURL, because this variable always contains a URL.
3362
3363         * DumpRenderTree/mac/DumpRenderTree.mm:
3364         (sizeWebViewForCurrentTest): Updated for testPathOrURL renaming.
3365         (testPathFromURL): Moved from FrameLoadDelegate.mm.
3366         (runTest): Set crash reporter information here, as we know the exact test URL.
3367
3368         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3369         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]): Don't set crash
3370         reporter information here.
3371
3372         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3373         * DumpRenderTree/mac/TestRunnerMac.mm:
3374         Updated for testPathOrURL renaming.
3375
3376         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3377         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame): WebProcess doesn't know
3378         test URL until load starts, so save it into TestRunner now. A new TestRunner object
3379         is created for each test.
3380
3381         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3382         (WTR::TestRunner::testURL):
3383         (WTR::TestRunner::setTestURL):
3384         Make TestRunner know the test name. For now, it's good enough to have it once load
3385         starts, but if we ever need it earlier, we can send it with BeginTest message.
3386
3387         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
3388         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
3389         Use test URL, not currently loading URL for CrashReporter.
3390
3391         * WebKitTestRunner/cocoa/CrashReporterInfo.mm:
3392         (WTR::setCrashReportApplicationSpecificInformationToURL): Added a space after colon
3393         (WebKit1 already had it right).
3394
3395         * DumpRenderTree/win/DumpRenderTree.cpp:
3396         (sizeWebViewForCurrentTest):
3397         (runTest):
3398         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3399         (ResourceLoadDelegate::willSendRequest):
3400         Changed Windows DumpRenderTree to also use URL in TestRunner.
3401
3402 2014-12-02  Daniel Bates  <dabates@apple.com>
3403
3404         [iOS] run-webkit-tests records most DumpRenderTree.app crashes as time-outs
3405         https://bugs.webkit.org/show_bug.cgi?id=139143
3406
3407         Reviewed by David Kilzer.
3408
3409         Similar to the Windows-specific fix in <https://bugs.webkit.org/show_bug.cgi?id=37859>,
3410         teach DumpRenderTree for iOS to write "#CRASHED" to the standard error stream when it
3411         crashes. Run-webkit-tests will record as crashing the test associated with the
3412         DumpRenderTree instance that wrote that string.
3413
3414         Currently almost all of the DumpRenderTree.app crashes are recorded by run-
3415         webkit-tests as a time-out because ReportCrash(8) delays delivery of the
3416         process exit notification for DumpRenderTree.app to LayoutTestRelay, which
3417         launched DumpRenderTree.app, past the time-out time limit. Notice LayoutTestRelay
3418         was launched by run-webkit-tests. So, run-webkit-tests kills LayoutTestRelay
3419         (since it exceeded the time-out time limit) before it can inform rub-webkit-tests
3420         about a crash.
3421
3422         Additionally, update the crash message format written to standard error when LayoutTestRelay
3423         detects that {WebKitTestRunner, DumpRenderTree}.app crashed so as to be similar to the
3424         crash message format used by WebKitTestRunner when it detects that the WebProcess crashed.
3425         Then run-webkit-tests will collect the crash logs for {WebKitTestRunner, DumpRenderTree}.app
3426         when they crash in their test machinery logic/UI process code.
3427
3428         * DumpRenderTree/mac/DumpRenderTree.mm:
3429         (writeCrashedMessageOnFatalError): Added.
3430         (dumpRenderTree): Register signal handler, writeCrashedMessageOnFatalError(), for signals:
3431         SIGILL, SIGFPE, SIGBUS and SIGSEGV.
3432         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
3433         (-[LTRelayController didCrashWithMessage:]): Emit a crash message with a format
3434         similar to the format used by WebKitTestRunner so that run-webkit-tests will collect
3435         the crash logs for WebKitTestRunner/DumpRenderTree.app.
3436         * Scripts/webkitpy/port/driver.py:
3437         (Driver.__init__): Update comment.
3438         (Driver._check_for_driver_crash): Ditto.
3439         * Scripts/webkitpy/port/ios.py:
3440         (IOSSimulatorPort): Add class constant SUBPROCESS_CRASH_REGEX, which represents a compiled
3441         regular expression. This constant is used as an optimization to avoid compiling the same
3442         regular expression across invocations of _get_crash_log().
3443         (IOSSimulatorPort._get_crash_log): Modified to parse the WebKitTestRunner-like crash message
3444         for the subprocess name and pid. Also, moved variables crash_log, crash_logs, and now to be
3445         closer to where they are used.
3446
3447 2014-12-01  Anders Carlsson  <andersca@apple.com>
3448
3449         Remove WKBundleRemoveAllVisitedLinks
3450         https://bugs.webkit.org/show_bug.cgi?id=139163
3451
3452         Reviewed by Sam Weinig.
3453
3454         Remove the call to WKBundleRemoveAllVisitedLinks and add a FIXME instead.
3455
3456         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3457         (WTR::InjectedBundle::beginTesting):
3458         * WebKitTestRunner/TestInvocation.cpp:
3459         (WTR::TestInvocation::invoke):
3460
3461 2014-12-02  Anders Carlsson  <andersca@apple.com>
3462
3463         Fix Windows build.
3464
3465         * DumpRenderTree/win/DumpRenderTree.cpp:
3466         (setAlwaysAcceptCookies):
3467
3468 2014-12-02  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3469
3470         [EFL] Remove edbus dependency from jhbuild
3471         https://bugs.webkit.org/show_bug.cgi?id=139130
3472
3473         Reviewed by Gyuyoung Kim.
3474
3475         After http://trac.webkit.org/changeset/176555 we
3476         don't need it anymore.
3477
3478         * efl/jhbuild.modules:
3479
3480 2014-12-02  Philippe Normand  <pnormand@igalia.com>
3481
3482         [jhbuild] wrong Dependencies path
3483         https://bugs.webkit.org/show_bug.cgi?id=139176
3484
3485         Reviewed by Martin Robinson.
3486
3487         * Scripts/webkitpy/port/base.py:
3488         (Port._should_use_jhbuild):
3489
3490 2014-12-02  Philippe Normand  <pnormand@igalia.com>
3491
3492         [GStreamer] Bump internal jhbuild versions to 1.4.4
3493         https://bugs.webkit.org/show_bug.cgi?id=138866
3494
3495         Reviewed by Carlos Garcia Campos.
3496
3497         * gtk/jhbuild.modules:
3498         * gtk/patches/gst-events-arent-gstobjects.patch: Removed.
3499         * gtk/patches/gst-plugins-base-fix-build-gcc-4.9-x86.patch: Removed.
3500         * gtk/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Removed.
3501
3502 2014-12-01  Commit Queue  <commit-queue@webkit.org>
3503
3504         Unreviewed, rolling out r176566.
3505         https://bugs.webkit.org/show_bug.cgi?id=139124
3506
3507         It broke the GTK performance tests. (Requested by clopez on
3508         #webkit).
3509
3510         Reverted changeset:
3511
3512         "[GTK] Use GMainLoopSource in WebKitTestRunner"
3513         https://bugs.webkit.org/show_bug.cgi?id=138831
3514         http://trac.webkit.org/changeset/176566
3515
3516 2014-11-29  Anders Carlsson  <andersca@apple.com>
3517
3518         Crash when calling WKPageClose on the originated page from within createNewPage callback
3519         https://bugs.webkit.org/show_bug.cgi?id=139099
3520         <rdar://problem/19052564>
3521
3522         Reviewed by Sam Weinig.
3523
3524         Add a test.
3525
3526         * TestWebKitAPI/PlatformWebView.h:
3527         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3528         * TestWebKitAPI/Tests/WebKit2/CloseFromWithinCreatePage.cpp: Added.
3529         (TestWebKitAPI::runJavaScriptAlert):
3530         (TestWebKitAPI::createNewPage):
3531         (TestWebKitAPI::TEST):
3532         * TestWebKitAPI/Tests/WebKit2/close-from-within-create-page.html: Added.
3533         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3534         (TestWebKitAPI::PlatformWebView::PlatformWebView):
3535
3536 2014-11-28  Commit Queue  <commit-queue@webkit.org>
3537
3538         Unreviewed, rolling out r176564.
3539         https://bugs.webkit.org/show_bug.cgi?id=139093
3540
3541         massive failures on release test bot (Requested by philn on
3542         #webkit).
3543
3544         Reverted changeset:
3545
3546         "[GStreamer] Bump internal jhbuild versions to 1.4.4"
3547         https://bugs.webkit.org/show_bug.cgi?id=138866
3548         http://trac.webkit.org/changeset/176564
3549
3550 2014-11-28  Carlos Garcia Campos  <cgarcia@igalia.com>
3551
3552         [GTK] Use GMainLoopSource in WebKitTestRunner
3553         https://bugs.webkit.org/show_bug.cgi?id=138831
3554
3555         Reviewed by Sergio Villar Senin.
3556
3557         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3558         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
3559         (WTR::TestRunner::platformInitialize):
3560         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
3561         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
3562         (WTR::waitToDumpWatchdogTimerCallback): Deleted.
3563         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3564         (WTR::TestController::notifyDone):
3565         (WTR::TestController::platformRunUntil):
3566         (WTR::cancelTimeout): Deleted.
3567
3568 2014-11-24  Philippe Normand  <pnormand@igalia.com>
3569
3570         [GStreamer] Bump internal jhbuild versions to 1.4.4
3571         https://bugs.webkit.org/show_bug.cgi?id=138866
3572
3573         Reviewed by Carlos Garcia Campos.
3574
3575         * gtk/jhbuild.modules:
3576         * gtk/patches/gst-events-arent-gstobjects.patch: Removed.
3577         * gtk/patches/gst-plugins-base-fix-build-gcc-4.9-x86.patch: Removed.
3578         * gtk/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Removed.
3579
3580 2014-11-28  Carlos Garcia Campos  <cgarcia@igalia.com>
3581
3582         [GTK] Use custom JavaScript instead of DBus to implement WebProcess tests
3583         https://bugs.webkit.org/show_bug.cgi?id=138834
3584
3585         Reviewed by Sergio Villar Senin.
3586
3587         It makes everyting simpler and the tests run faster too, since we
3588         don't need to spawn the private bus and wait until the DBus name
3589         is registered. The web extension registers a new JavaSCript class
3590         with a status method to run the tests, similar to the DBus
3591         method. In the UI process side, tests use webkit_web_view_run_java_script()
3592         instead of sending a DBus message.
3593
3594         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
3595         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp:
3596         (WebKitDOMNodeFilterTest::create):
3597         (WebKitDOMNodeFilterTest::testTreeWalker):
3598         (WebKitDOMNodeFilterTest::testNodeIterator):
3599         (WebKitDOMNodeFilterTest::webPageFromArgs): Deleted.
3600         (WebKitDOMNodeFilterTest::runTest): Deleted.
3601         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
3602         (WebKitDOMNodeTest::create):
3603         (WebKitDOMNodeTest::testHierarchyNavigation):
3604         (WebKitDOMNodeTest::testInsertion):
3605         (WebKitDOMNodeTest::testTagNames):
3606         (WebKitDOMNodeTest::webPageFromArgs): Deleted.
3607         (WebKitDOMNodeTest::runTest): Deleted.
3608         * TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp:
3609         (WebKitDOMXPathNSResolverTest::create):
3610         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
3611         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
3612         (WebKitDOMXPathNSResolverTest::webPageFromArgs): Deleted.
3613         (WebKitDOMXPathNSResolverTest::runTest): Deleted.
3614         * TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp:
3615         (WebKitFrameTest::create):
3616         (WebKitFrameTest::testMainFrame):
3617         (WebKitFrameTest::testURI):
3618         (WebKitFrameTest::testJavaScriptContext):
3619         (WebKitFrameTest::webPageFromArgs): Deleted.
3620         (WebKitFrameTest::runTest): Deleted.
3621         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
3622         (testWebKitDOMNodeHierarchyNavigation):
3623         (testWebKitDOMNodeInsertion):
3624         (testWebKitDOMNodeTag