Unreviewed attempt to fix API test failure after r219663.
[WebKit-https.git] / Tools / ChangeLog
1 2017-07-19  Chris Dumez  <cdumez@apple.com>
2
3         Unreviewed attempt to fix API test failure after r219663.
4
5         The test was hard-coding an exception string and the string has changed slightly
6         in r219663.
7
8         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
9         (TEST):
10
11 2017-07-19  Megan Gardner  <megan_gardner@apple.com>
12
13         Don't write file URLs to iOS Pasteboard
14         https://bugs.webkit.org/show_bug.cgi?id=174647
15         <rdar://problem/33199730>
16
17         Reviewed by Wenson Hsieh.
18
19         Updating tests to reflect the lack of file URLs for images.
20
21         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
22         (checkTypeIdentifierAndIsNotOtherTypeIdentifier):
23         (checkEstimatedSize):
24         (TestWebKitAPI::TEST):
25
26 2017-07-19  Brady Eidson  <beidson@apple.com>
27
28         iBooks sometimes crashes when closing a book.
29         <rdar://problem/31180331> and https://bugs.webkit.org/show_bug.cgi?id=174658
30
31         Reviewed by Oliver Hunt.
32
33         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
34         (-[ProcessPoolDestroyedDuringLoadingProtocol startLoading]):
35         (-[ProcessPoolDestroyedDuringLoadingProtocol finishTheLoad]):
36         (-[ProcessPoolDestroyedDuringLoadingProtocol stopLoading]):
37         (TestWebKitAPI::TEST):
38
39         Add a "spin the runloop X number of times" utility:
40         * TestWebKitAPI/Utilities.h:
41         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
42         (TestWebKitAPI::Util::spinRunLoop):
43
44 2017-07-19  Jonathan Bedard  <jbedard@apple.com>
45
46         lint-test-expectations should be run during style checking
47         https://bugs.webkit.org/show_bug.cgi?id=173559
48         <rdar://problem/32854941>
49
50         Reviewed by David Kilzer.
51
52         Running the test expectation linter requires reading both files and lines not in the
53         patch because, for example, deletion of a test can cause a lint failure even though
54         no test expectations where modified. This means that the linter will occasionally warn
55         about lines which were not changed in a given patch but whose error is related to a
56         change made in that patch.
57
58         * Scripts/webkitpy/common/system/filesystem_mock.py:
59         (MockFileSystem.open_text_file_for_reading): Add 'errors' argument to mimic filesystem.
60         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
61         (TestExpectationWarning): Added class to pass warnings as an object instead of a string.
62         (TestExpectationWarning.__init__): Construct warning with file name, line number, line
63         content, description of the error and the name of the associated test.
64         (TestExpectationWarning.__str__): Convert to string so that existing printing code works.
65         (TestExpectationParser.__init__): Pass shorten_filename function to
66         TestExpectationsParser to add a deleted file to the related_files dictionary.
67         (TestExpectationParser._check_test_exists): If the test does not exist, add the
68         missing path to the related_files dictionary.
69         (TestExpectationLine.__init__): Add related_files dictionary, which tracks
70         files and line numbers related to this test expectation line. This will allow
71         tracking linter errors in the style checker occurring across multiple files.
72         (TestExpectationsModel._already_seen_better_match): Add redundant expectation
73         lines to related_files dictionary.
74         (TestExpectations.__init__): Pass self._shorten_filename to TestExpectationParser.
75         (TestExpectations._report_warnings): Construct warning object instead of string
76         when adding to warnings list.
77         * Scripts/webkitpy/port/win.py: Changed logging level form warning to debug to
78         clean-up log.
79         * Scripts/webkitpy/style/checker.py:
80         (ProcessorBase.do_association_check): Add required function for processor classes.
81         (StyleProcessor):
82         (StyleProcessor.do_association_check): Run the TestExpectations linter when
83         checking for errors between associated files.
84         * Scripts/webkitpy/style/checkers/test_expectations.py:
85         (TestExpectationsChecker.check_test_expectations): Reflect changed import statements.
86         (TestExpectationsChecker):
87         (TestExpectationsChecker._should_log_linter_warning): Given a warning, a dictionary
88         of modified files, the current working directory and the host, determine if the linter
89         warning is associated with the changes.
90         (TestExpectationsChecker.lint_test_expectations): Lint test expectations for the
91         style checker.
92         * Scripts/webkitpy/style/filereader.py:
93         (TextFileReader):
94         (TextFileReader.__init__): Track modified files in dictionary instead of a counter.
95         (TextFileReader.file_count): Use dictionary to determine the number of modified files.
96         (TextFileReader.process_file): Track both the number of files changed and which lines
97         in those files were changed.
98         (TextFileReader.do_association_check): Run the processor's association check on all
99         modified or deleted files processed by TextFileReader.
100         (TextFileReader.delete_file): Track deleted files in _files dictionary.
101         (TextFileReader.count_delete_only_file): Deleted.
102         * Scripts/webkitpy/style/filereader_unittest.py:
103         (TextFileReaderTest.test_delete_file): Renamed function to reflect new function name.
104         (TextFileReaderTest.test_count_delete_only_file): Moved to test_delete_file.
105         * Scripts/webkitpy/style/main.py:
106         (CheckWebKitStyle.main): When running the style checker on a specific list of files,
107         explicitly run the association check on the file reader.
108         * Scripts/webkitpy/style/main_unittest.py:
109         (ExpectationLinterInStyleCheckerTest): Added to test the TestExpectationLinter now
110         embedded in the style checker.
111         (ExpectationLinterInStyleCheckerTest.setUp): Set up the style checker configuration.
112         (ExpectationLinterInStyleCheckerTest._generate_file_reader): Given a filesystem object,
113         construct the TextFileReader object with a StyleProcessor used to run style checks on
114         specific files.
115         (ExpectationLinterInStyleCheckerTest._generate_testing_host): Generate a host used for
116         testing the test expectation linter inside the style checker. This host must contain a
117         mock file system with the basic structure of test expectations.
118         (ExpectationLinterInStyleCheckerTest.test_no_linter_errors):
119         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line):
120         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_no_edit):
121         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file):
122         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file_no_edit):
123         * Scripts/webkitpy/style/patchreader.py:
124         (PatchReader.check): Specify which file was deleted, run the association check.
125         * Scripts/webkitpy/style/patchreader_unittest.py:
126         (PatchReaderTest.MockTextFileReader.delete_file): Renamed count_delete_only_file.
127         (PatchReaderTest.MockTextFileReader.do_association_check): Added.
128         (PatchReaderTest.MockTextFileReader.count_delete_only_file): Renamed delete_file.
129
130 2017-07-19  Yusuke Suzuki  <utatane.tea@gmail.com>
131
132         [WTF] Implement WTF::ThreadGroup
133         https://bugs.webkit.org/show_bug.cgi?id=174081
134
135         Reviewed by Mark Lam.
136
137         Add WTF::ThreadGroup tests.
138
139         * TestWebKitAPI/CMakeLists.txt:
140         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
141         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp: Added.
142         (TestWebKitAPI::testThreadGroup):
143         (TestWebKitAPI::TEST):
144
145 2017-07-18  Andy Estes  <aestes@apple.com>
146
147         [Xcode] Enable CLANG_WARN_RANGE_LOOP_ANALYSIS
148         https://bugs.webkit.org/show_bug.cgi?id=174631
149
150         Reviewed by Tim Horton.
151
152         * DumpRenderTree/mac/Configurations/Base.xcconfig:
153         * MiniBrowser/Configurations/Base.xcconfig:
154         * MobileMiniBrowser/Configurations/Base.xcconfig:
155         * TestWebKitAPI/Configurations/Base.xcconfig:
156         * WebKitTestRunner/Configurations/Base.xcconfig:
157
158 2017-07-18  Andy Estes  <aestes@apple.com>
159
160         [Xcode] Enable CLANG_WARN_OBJC_LITERAL_CONVERSION
161         https://bugs.webkit.org/show_bug.cgi?id=174631
162
163         Reviewed by Sam Weinig.
164
165         * DumpRenderTree/mac/Configurations/Base.xcconfig:
166         * MiniBrowser/Configurations/Base.xcconfig:
167         * MobileMiniBrowser/Configurations/Base.xcconfig:
168         * TestWebKitAPI/Configurations/Base.xcconfig:
169         * WebKitTestRunner/Configurations/Base.xcconfig:
170
171 2017-07-18  Daniel Bates  <dabates@apple.com>
172
173         lldb: Add type summary for StringView
174         https://bugs.webkit.org/show_bug.cgi?id=174637
175
176         Reviewed by Sam Weinig.
177
178         For debugging convenience, adds a pretty-print type summary for StringView. Evaluating a
179         StringView object will print output that has the form:
180
181             (WTF::StringView) $4 = { length = 2, contents = 'li' } {
182               m_characters = 0x000000011b57abb5 "eeeeeefjh0n"
183               m_length = 2
184               m_is8Bit = true
185               m_underlyingString = 0x0000614000000a90
186             }
187
188         * lldb/lldb_webkit.py:
189         (__lldb_init_module): Use WTFStringView_SummaryProvider to format StringView types.
190         (WTFStringView_SummaryProvider):
191         (WTFStringViewProvider):
192         (WTFStringViewProvider.__init__):
193         (WTFStringViewProvider.is_8bit): Access field StringView.m_is8Bit.
194         (WTFStringViewProvider.get_length): Access field StringView.m_length.
195         (WTFStringViewProvider.get_characters): Access field StringView.m_characters.
196         (WTFStringViewProvider.to_string): Returns the string represented by the StringView.
197
198 2017-07-18  Andy Estes  <aestes@apple.com>
199
200         [Xcode] Enable CLANG_WARN_NON_LITERAL_NULL_CONVERSION
201         https://bugs.webkit.org/show_bug.cgi?id=174631
202
203         Reviewed by Dan Bernstein.
204
205         * DumpRenderTree/mac/Configurations/Base.xcconfig:
206         * MiniBrowser/Configurations/Base.xcconfig:
207         * MobileMiniBrowser/Configurations/Base.xcconfig:
208         * TestWebKitAPI/Configurations/Base.xcconfig:
209         * WebKitTestRunner/Configurations/Base.xcconfig:
210
211 2017-07-18  Devin Rousso  <drousso@apple.com>
212
213         Web Inspector: Add memoryCost to Inspector Protocol objects
214         https://bugs.webkit.org/show_bug.cgi?id=174478
215
216         Reviewed by Joseph Pecoraro.
217
218         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
219         * TestWebKitAPI/Tests/JavaScriptCore/InspectorValue.cpp: Added.
220         (TestWebKitAPI::TEST(InspectorValue, MemoryCostNull)):
221         (TestWebKitAPI::TEST(InspectorValue, MemoryCostBoolean)):
222         (TestWebKitAPI::TEST(InspectorValue, MemoryCostDouble)):
223         (TestWebKitAPI::TEST(InspectorValue, MemoryCostInteger)):
224         (TestWebKitAPI::TEST(InspectorValue, MemoryCostString)):
225         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringEmpty)):
226         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringNull)):
227         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringGrowing)):
228         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringUnicode)):
229         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObject)):
230         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObjectEmpty)):
231         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObjectGrowing)):
232         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArray)):
233         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArrayEmpty)):
234         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArrayGrowing)):
235
236 2017-07-18  Andy Estes  <aestes@apple.com>
237
238         [Xcode] Enable CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING
239         https://bugs.webkit.org/show_bug.cgi?id=174631
240
241         Reviewed by Darin Adler.
242
243         * DumpRenderTree/mac/Configurations/Base.xcconfig:
244         * MiniBrowser/Configurations/Base.xcconfig:
245         * MobileMiniBrowser/Configurations/Base.xcconfig:
246         * TestWebKitAPI/Configurations/Base.xcconfig:
247         * WebKitTestRunner/Configurations/Base.xcconfig:
248
249 2017-07-17  Wenson Hsieh  <wenson_hsieh@apple.com>
250
251         Unreviewed, fix the iOS build.
252
253         I missed a spot when renaming -synchronouslyLoadHTML: to -synchronouslyLoadHTMLString:.
254
255         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
256         (TestWebKitAPI::TEST):
257
258 2017-07-17  Wenson Hsieh  <wenson_hsieh@apple.com>
259
260         [iOS DnD] Web process uses too much memory when beginning a drag on a very large image
261         https://bugs.webkit.org/show_bug.cgi?id=174585
262         <rdar://problem/33302541>
263
264         Reviewed by Tim Horton.
265
266         Adds a new test verifying that we don't try to allocate any image buffer equal to the true size of the image
267         being dragged when initiating a drag.
268
269         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
270         * TestWebKitAPI/Tests/WebKit2Cocoa/enormous.svg: Added.
271         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
272         (TestWebKitAPI::TEST):
273         * TestWebKitAPI/cocoa/TestWKWebView.h:
274
275         Add a new -synchronouslyLoadHTMLString: helper that works like -synchronouslyLoadTestPage:, but takes markup.
276
277         * TestWebKitAPI/cocoa/TestWKWebView.mm:
278         (-[TestWKWebView synchronouslyLoadHTMLString:]):
279
280 2017-07-17  Michael Catanzaro  <mcatanzaro@igalia.com>
281
282         [CMake] Macros in WebKitMacros.cmake should be prefixed with WEBKIT_ namespace
283         https://bugs.webkit.org/show_bug.cgi?id=174547
284
285         Reviewed by Alex Christensen.
286
287         * DumpRenderTree/PlatformWin.cmake:
288         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
289
290 2017-07-17  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
291
292         Update style checker to deal with "final"
293         https://bugs.webkit.org/show_bug.cgi?id=174528
294
295         Reviewed by Alex Christensen.
296         
297         check-webkit-style shouldn't complain about an open brace to start a
298         line after a function definition with "final" or "const final".
299
300         * Scripts/webkitpy/style/checkers/cpp.py:
301         (check_braces):
302         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
303         (CppStyleTest.test_brace_at_begin_of_line):
304
305 2017-07-17  Alex Christensen  <achristensen@webkit.org>
306
307         Modernize content extension code
308         https://bugs.webkit.org/show_bug.cgi?id=174588
309
310         Reviewed by Sam Weinig.
311
312         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
313         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
314         (TestWebKitAPI::testRequest):
315         (TestWebKitAPI::makeBackend):
316         (TestWebKitAPI::TEST_F):
317
318 2017-07-17  Brady Eidson  <beidson@apple.com>
319
320         WKHTTPCookieStore observing only works on the default cookie store.
321         <rdar://problem/33330724> and https://bugs.webkit.org/show_bug.cgi?id=174580
322
323         Reviewed by Sam Weinig.
324
325         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
326         (runTestWithWebsiteDataStore): Refactor the cookie observing test out so it can be
327           called for the default store, a non-persistent store, and a custom store.
328         (TEST):
329
330 2017-07-16  Sam Weinig  <sam@webkit.org>
331
332         [Scripts] Fix missing variable warnings from svn-create-patch when there are untracked files
333         https://bugs.webkit.org/show_bug.cgi?id=174575
334
335         Reviewed by Brady Eidson.
336
337         * Scripts/svn-create-patch:
338         (findModificationType):
339         Add support for more status codes. C -> conflicted, ? -> untracked, ! -> missing. Give a
340         default value of "unknown".
341
342         (generateFileList):
343         Handle all the new modification types. Abort on conflicted, missing, and unknown. Log
344         for untracked, which matches our old behavior.
345
346 2017-07-17  Charlie Turner  <cturner@igalia.com>
347
348         Add some missing build dependencies on Fedora
349         https://bugs.webkit.org/show_bug.cgi?id=174578
350
351         Unreviewed dependency update.
352
353         * gtk/install-dependencies:
354
355 2017-07-16  Brady Eidson  <beidson@apple.com>
356
357         Crash when a WKHTTPCookieStore outlives its owning WKWebsiteDataStore.
358         <rdar://problem/33341730> and https://bugs.webkit.org/show_bug.cgi?id=174574
359
360         Reviewed by Tim Horton.
361
362         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
363         (-[CookieNavigationDelegate webView:didFinishNavigation:]):
364         (TEST):
365
366 2017-07-16  Bernhard M. Wiedemann  <bwiedemann@suse.de>
367
368         [GTK] Sort inspector GResource manifest to ensure reproducible builds
369         https://bugs.webkit.org/show_bug.cgi?id=174540
370
371         Reviewed by Michael Catanzaro.
372
373         * gtk/generate-inspector-gresource-manifest.py:
374         (get_filenames): sort list of input files
375
376 2017-07-15  Brady Eidson  <beidson@apple.com>
377
378         Make sure all CFHTTPCookieStorageRefs we create are scheduled.
379         <rdar://problem/33221110> and https://bugs.webkit.org/show_bug.cgi?id=174513
380
381         Reviewed by Tim Horton.
382
383         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
384         (TEST): Make this test more reliable by clearing everything beforehand.
385
386 2017-07-15  David Kilzer  <ddkilzer@apple.com>
387
388         Make it possible to extend check-webkit-style with Apple-internal checkers
389         <https://webkit.org/b/174464>
390         <rdar://problem/25564402>
391
392         Reviewed by Darin Adler.
393
394         * Scripts/webkitpy/style/checker.py: Import apple_additions.
395         (_all_categories): Add categories from apple_additions() if it
396         exists.
397         (CheckerDispatcher._create_checker): Create python checker
398         from apple_additions() if it exists.
399
400 2017-07-15  Wenson Hsieh  <wenson_hsieh@apple.com>
401
402         [iOS WK2] Presenting an action sheet on an image map prevents selection UI from updating
403         https://bugs.webkit.org/show_bug.cgi?id=174539
404         <rdar://problem/33307395>
405
406         Reviewed by Darin Adler.
407
408         Adds a new unit test suite to cover action sheet popover presentation.
409
410         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
411         * TestWebKitAPI/Tests/WebKit2Cocoa/image-map.html: Added.
412         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm: Added.
413         (-[ActionSheetObserver waitForActionSheetAfterBlock:]):
414
415         Runs the given block and waits until the UI process has indicated that it will present an action sheet.
416
417         (-[ActionSheetObserver _webView:actionsForElement:defaultActions:]):
418         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
419
420         Helper class to alter the behavior of [[UIDevice currentDevice] userInterfaceIdiom] for testing.
421
422         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
423         (TestWebKitAPI::TEST):
424
425 2017-07-15  Sam Weinig  <sam@webkit.org>
426
427         [Scripts] Make svn-create-patch work better when called in sub directories
428         https://bugs.webkit.org/show_bug.cgi?id=174551
429
430         Reviewed by Darin Adler.
431
432         - Fixes manufacturePatchForAdditionWithHistory to use the correct path
433           by ensuring that the prefix is applied as is done in generateDiff.
434         - Silence output of explanatory lines from svn stat (" > move to ...")
435           that show up in STDERR when running svn-create-patch.
436         - Add verbose logging that I found useful while debugging this issue.
437
438         * Scripts/svn-create-patch:
439         (findBaseUrl):
440         (findMimeType):
441         (findSourceFileAndRevision):
442         (generateDiff):
443         (generateFileList):
444         (manufacturePatchForAdditionWithHistory):
445
446 2017-07-15  Jonathan Bedard  <jbedard@apple.com>
447
448         Unreviewed build fix after r219537.
449
450         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
451
452 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
453
454         Add iOS 11 SPI
455         https://bugs.webkit.org/show_bug.cgi?id=174430
456         <rdar://problem/33269288>
457
458         Reviewed by Tim Horton.
459
460         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm: Define drag-and-drop API required for testing.
461         * TestWebKitAPI/ios/DataInteractionSimulator.h: Ditto.
462         * TestWebKitAPI/ios/DataInteractionSimulator.mm: Ditto.
463
464 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
465
466         Failing to install on iPad simulators
467         https://bugs.webkit.org/show_bug.cgi?id=174532
468         <rdar://problem/33328347>
469
470         Reviewed by Stephanie Lewis.
471
472         * Scripts/webkitpy/xcode/simulated_device.py:
473         (SimulatedDevice.install_app): Place install command in retry try-except block.
474
475 2017-07-14  Jeff Miller  <jeffm@apple.com>
476
477         Add test for -[WKProcessPool _setObjectsForBundleParametersWithDictionary:].
478         https://bugs.webkit.org/show_bug.cgi?id=174524
479
480         Reviewed by Sam Weinig.
481
482         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm:
483         (TEST):
484         Renamed TestParameter to TestParameter1.
485         Add test for -[WKProcessPool _setObjectsForBundleParametersWithDictionary:].
486
487         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm:
488         (-[BundleParametersPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
489         Observe changes for two bundle parameters.
490
491         (-[BundleParametersPlugIn dealloc]):
492         Remove observers for two bundle parameters.
493
494 2017-07-14  Commit Queue  <commit-queue@webkit.org>
495
496         Unreviewed, rolling out r219510.
497         https://bugs.webkit.org/show_bug.cgi?id=174525
498
499         Need to revert length() == 0 check for null string (Requested
500         by yusukesuzuki on #webkit).
501
502         Reverted changeset:
503
504         "[WTF] Newly added AtomicStringImpl should use BufferInternal
505         static string if StringImpl is static"
506         https://bugs.webkit.org/show_bug.cgi?id=174501
507         http://trac.webkit.org/changeset/219510
508
509 2017-07-14  Jer Noble  <jer.noble@apple.com>
510
511         [MSE] Removing samples when presentation order does not match decode order can cause bad behavior.
512         https://bugs.webkit.org/show_bug.cgi?id=174514
513
514         Reviewed by Sam Weinig.
515
516         * TestWebKitAPI/Tests/WebCore/SampleMap.cpp:
517         (TestWebKitAPI::TEST_F):
518
519 2017-07-14  Yusuke Suzuki  <utatane.tea@gmail.com>
520
521         [WTF] Newly added AtomicStringImpl should use BufferInternal static string if StringImpl is static
522         https://bugs.webkit.org/show_bug.cgi?id=174501
523
524         Reviewed by Darin Adler.
525
526         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
527         (TestWebKitAPI::TEST):
528
529 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
530
531         Bring mac expectations in-line with other platforms
532         https://bugs.webkit.org/show_bug.cgi?id=174472
533         <rdar://problem/33297388>
534
535         Reviewed by David Kilzer.
536
537         The override order for Mac test expectations does not conform to the pattern used by iOS,
538         GTK, Windows and WPE. Before this change, El Capitan's baseline search path looks like this:
539
540             platform/mac-wk2
541             platform/wk2
542             platform/mac-elcapitan
543             platform/mac-sierra
544             generic
545
546         After this change, El Capitan's baseline search path looks like this:
547
548             platform/mac-sierra-wk2
549             platform/mac-sierra
550             platform/mac-wk2
551             platform/wk2
552             generic
553
554         * Scripts/webkitpy/port/mac.py:
555         (MacPort.__init__): If a specific version is specified in the port name, use that
556         as the os version.
557         (MacPort.default_baseline_search_path): Expectation search paths should work the
558         same way they do on other ports. Port + version overrides port, port overrides generic
559         and wk1/wk2 should override expectations for the two combined.
560         * Scripts/webkitpy/port/mac_unittest.py:
561         (MacTest.test_tests_for_other_platforms): Deleted.
562         (MacTest._assert_search_path): Deleted.
563         (MacTest.test_baseline_search_path): Deleted.
564         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
565         (TestRebaselineTest.test_baseline_directory): Adjust expectations for new over-ride order.
566         (test_rebaseline_test_and_print_scm_changes): Ditto.
567         (test_rebaseline_and_copy_test): Ditto.
568         (test_rebaseline_and_copy_test_no_existing_result): Ditto.
569         (test_rebaseline_and_copy_test_with_lion_result): Ditto.
570         (test_rebaseline_and_copy_no_overwrite_test): Ditto.
571
572 2017-07-13  Michael Catanzaro  <mcatanzaro@igalia.com>
573
574         Fix style checker unit test
575
576         Unreviewed WebKit2 => WebKit fixup.
577
578         * Scripts/webkitpy/style/checker_unittest.py:
579         (CheckerDispatcherSkipTest.test_should_skip_with_warning):
580
581 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
582
583         Use the old WebKit/WebKit2 targets for CMake builds. (v2)
584
585         Unreviewed build fix.
586
587         r219492 missed one hunk from its partial revert of r219489.
588         This patch reverts that hunk.
589
590         * TestWebKitAPI/CMakeLists.txt:
591
592 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
593
594         Use the old WebKit/WebKit2 targets for CMake builds.
595
596         Unreviewed build fix.
597
598         We can update the target names to match the Framework names in a future patch.
599         This is a partial revert of r219489.
600
601         * TestWebKitAPI/CMakeLists.txt:
602         WebKitLegacy => WebKit
603         WebKit => WebKit2
604
605 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
606
607         Fix TestWebKit API.
608         https://bugs.webkit.org/show_bug.cgi?id=174164
609         rdar://problem/33137595
610
611         Reviewed by Dan Bernstein.
612
613         * TestWebKitAPI/CMakeLists.txt:
614         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
615         * TestWebKitAPI/PlatformGTK.cmake:
616
617 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
618
619         Update tools and configurations after renaming Source/WebKit2 to Source/WebKit.
620         https://bugs.webkit.org/show_bug.cgi?id=174164
621         rdar://problem/33137595
622
623         Reviewed by Dan Bernstein.
624
625         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
626         (ShouldBuildTest):
627         * DumpRenderTree/mac/Configurations/Base.xcconfig:
628         * Scripts/build-webkit:
629         * Scripts/do-file-rename:
630         * Scripts/do-webcore-rename:
631         * Scripts/update-webkit-localizable-strings:
632         * Scripts/webkitpy/common/config/watchlist:
633         * Scripts/webkitpy/style/checker.py:
634         * Scripts/webkitpy/style/checkers/featuredefines.py:
635         * gtk/make-dist.py:
636         (ensure_version_if_possible):
637         * gtk/manifest.txt.in:
638
639 2017-07-05  Matthew Hanson  <matthew_hanson@apple.com>
640
641         Update tools and configurations after renaming Source/WebKit to Source/WebKitLegacy.
642         https://bugs.webkit.org/show_bug.cgi?id=174162
643         rdar://problem/33137594
644
645         Reviewed by Dan Bernstein.
646
647         Mass rename of Source/WebKit to Source/WebKitLegacy in OpenSource tooling.
648
649         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
650         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
651         * EWSTools/configure-clang-linux.sh:
652         * Scripts/build-webkit:
653         * Scripts/do-file-rename:
654         * Scripts/do-webcore-rename:
655         * Scripts/update-webkit-localizable-strings:
656         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
657         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
658         * Scripts/webkitpy/style/checkers/featuredefines.py:
659         * gtk/manifest.txt.in:
660
661 2017-07-13  Jonathan Bedard  <jbedard@apple.com>
662
663         Add script to rebase patches during the WebKit2->WebKit/WebKit->WebKitLegacy transition
664         https://bugs.webkit.org/show_bug.cgi?id=174438
665         <rdar://problem/33277112>
666
667         Reviewed by Aakash Jain.
668
669         Given a patch, this will convert the changes from the path to the new directory structure.
670
671         * Scripts/rebase-patch-after-webkit-move: Added.
672         (append_source): Append 'Source' to the provided path.
673         (is_editable_line): Return true if a line the script expects to modify.
674         (needs_rebase): Return if a line needs to be rebased based on it's content.
675         (rebase_line): Rebase the provided line.
676         (rebase): Rebase a patch given the lines of that patch and a file to output the rebased patch to.
677         (parse_arguments): Parse the command line arguments and return the patches to be rebased, if they
678         were provided.
679
680 2017-07-12  Nan Wang  <n_wang@apple.com>
681
682         AX: [iOS] Implement a way to retrieve a text marker range with desired text that is closest to a position
683         https://bugs.webkit.org/show_bug.cgi?id=174393
684         <rdar://problem/33248006>
685
686         Reviewed by Chris Fleizach.
687
688         * DumpRenderTree/AccessibilityUIElement.cpp:
689         (textMarkerRangeMatchesTextNearMarkersCallback):
690         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
691         (AccessibilityUIElement::getJSClass):
692         * DumpRenderTree/AccessibilityUIElement.h:
693         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
694         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
695         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
696         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
697         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
698         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
699         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
700         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
701
702 2017-07-12  Matt Lewis  <jlewis3@apple.com>
703
704         Unreviewed, rolling out r219409.
705
706         The revision caused the Windows builds to fail.
707
708         Reverted changeset:
709
710         "AX: [iOS] Implement a way to retrieve a text marker range
711         with desired text that is closest to a position"
712         https://bugs.webkit.org/show_bug.cgi?id=174393
713         http://trac.webkit.org/changeset/219409
714
715 2017-07-12  Nan Wang  <n_wang@apple.com>
716
717         AX: [iOS] Implement a way to retrieve a text marker range with desired text that is closest to a position
718         https://bugs.webkit.org/show_bug.cgi?id=174393
719         <rdar://problem/33248006>
720
721         Reviewed by Chris Fleizach.
722
723         * DumpRenderTree/AccessibilityUIElement.cpp:
724         (textMarkerRangeMatchesTextNearMarkersCallback):
725         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
726         (AccessibilityUIElement::getJSClass):
727         * DumpRenderTree/AccessibilityUIElement.h:
728         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
729         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
730         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
731         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
732         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
733         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
734         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
735         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
736
737 2017-07-12  Emilio Cobos Álvarez  <ecobos@igalia.com>
738
739         Make prepare-ChangeLog -g <commit> generate a more standard ChangeLog entry.
740         https://bugs.webkit.org/show_bug.cgi?id=174197
741
742         Reviewed by Darin Adler.
743
744         This bit me the first time I tried to submit a patch to WebKit, and still I have
745         to manually edit the ChangeLog every time I use the script.
746
747         This generates a more convenient and standard ChangeLog entry.
748
749         * Scripts/prepare-ChangeLog:
750         (generateNewChangeLogs):
751
752 2017-07-12  Matt Lewis  <jlewis3@apple.com>
753
754         Unreviewed, rolling out r219401.
755
756         This revision rolled out the previous patch, but after talking
757         with reviewer, a rebaseline is what was needed.Rolling back in
758         before rebaseline.
759
760         Reverted changeset:
761
762         "Unreviewed, rolling out r219379."
763         https://bugs.webkit.org/show_bug.cgi?id=174400
764         http://trac.webkit.org/changeset/219401
765
766 2017-07-12  Matt Lewis  <jlewis3@apple.com>
767
768         Unreviewed, rolling out r219379.
769
770         This revision caused a consistent failure in the test
771         fast/dom/Window/property-access-on-cached-window-after-frame-
772         removed.html.
773
774         Reverted changeset:
775
776         "Remove NAVIGATOR_HWCONCURRENCY"
777         https://bugs.webkit.org/show_bug.cgi?id=174400
778         http://trac.webkit.org/changeset/219379
779
780 2017-07-12  Zan Dobersek  <zdobersek@igalia.com>
781
782         [WPE] Use libepoxy
783         https://bugs.webkit.org/show_bug.cgi?id=172104
784
785         Reviewed by Michael Catanzaro.
786
787         * WebKitTestRunner/wpe/HeadlessViewBackend.h:
788         Include the <epoxy/egl.h> header, dropping the EGL and GLES2 inclusions.
789
790 2017-07-12  Zan Dobersek  <zdobersek@igalia.com>
791
792         [GTK][WPE] Align Jhbuild patches for GStreamer packages
793         https://bugs.webkit.org/show_bug.cgi?id=174363
794
795         Reviewed by Michael Catanzaro.
796
797         Align the patches we apply over Jhbuild-managed GStreamer dependency packages
798         between the GTK+ and WPE port. There's no reason for the two ports to apply
799         different patches over same versions of GStreamer releases.
800
801         This aligns the two ports on this specific issue. Next we'll look into
802         creating a single GStreamer-specific Jhbuild moduleset that will allow us
803         to keep these patches in a single place, avoiding duplicate files.
804
805         * gtk/jhbuild.modules:
806         * gtk/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Added.
807         * gtk/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch.
808         * gtk/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Added.
809         * wpe/patches/gstreamer-typefind-Only-push-a-CAPS-event-downstream-if-the-.patch: Removed.
810
811 2017-07-11  Dean Jackson  <dino@apple.com>
812
813         Remove NAVIGATOR_HWCONCURRENCY
814         https://bugs.webkit.org/show_bug.cgi?id=174400
815
816         Reviewed by Sam Weinig.
817
818         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
819
820 2017-07-11  Ansh Shukla  <ansh_shukla@apple.com>
821
822         WKWindowFeatures needs to expose scrollbar, fullscreen, and dialog configuration properties
823         https://bugs.webkit.org/show_bug.cgi?id=174239
824
825         Reviewed by Brady Eidson.
826
827         Create windows with specific features set and make sure those are properly reflected in the
828         WKWindowFeatures object.
829
830         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
831         (resetToConsistentState):
832         (-[CheckWindowFeaturesUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
833         (TEST):
834
835 2017-07-11  Jonathan Bedard  <jbedard@apple.com>
836
837         Do not duplicate files when deleting directories with svn 1.9
838         https://bugs.webkit.org/show_bug.cgi?id=174339
839         <rdar://problem/33226781>
840
841         Reviewed by David Kilzer.
842
843         * Scripts/svn-create-patch:
844         (diffOptionsForFile): No longer pass -N option, since this does not work in SVN 1.9.4.
845         (generateFileList): Determine which files are deleted because they are part of a
846         directory being deleted.
847
848 2017-07-11  Dean Jackson  <dino@apple.com>
849
850         Rolling out r219372.
851
852         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
853
854 2017-07-11  Dean Jackson  <dino@apple.com>
855
856         Remove NAVIGATOR_HWCONCURRENCY
857         https://bugs.webkit.org/show_bug.cgi?id=174400
858
859         Reviewed by Sam Weinig.
860
861         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
862
863 2017-07-11  Lucas Forschler  <lforschler@apple.com>
864
865         Teach build workers to fetch archives from S3.
866         https://bugs.webkit.org/show_bug.cgi?id=174384
867
868         Reviewed by Aakash Jain.
869
870         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
871         (DownloadBuiltProduct):
872
873 2017-07-11  Lucas Forschler  <lforschler@apple.com>
874
875         Configure buildbot to transfer all archives to S3.
876         Previously this was Mac only, but it's time to expand!
877         https://bugs.webkit.org/show_bug.cgi?id=174378
878         
879         Reviewed by Aakash Jain.
880
881         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
882         (BuildFactory.__init__):
883
884 2017-07-11  Zan Dobersek  <zdobersek@igalia.com>
885
886         [WPE] Bump GStreamer packages in jhbuild.modules to 1.10.5
887         https://bugs.webkit.org/show_bug.cgi?id=174350
888
889         Reviewed by Xabier Rodriguez-Calvar.
890
891         Bump the various GStreamer dependencies listed in WPE's Jhbuild modules file
892         to the 1.10.5 version. One gstreamer patch is added. The two gst-plugins-bad
893         patches are removed. The patches for gst-plugins-good are updated, removing
894         the stale ones and adding the additional changes to qtdemux, souphttpsrc and
895         rtpbin elements that will help with the EMEv3 development.
896
897         * wpe/jhbuild.modules:
898         * wpe/patches/gst-plugins-bad-0001-dtls-port-to-OpenSSL-1.1.0.patch: Removed.
899         * wpe/patches/gst-plugins-bad-0002-dtlscertificate-Fix-error-checking-in-RSA_generate_k.patch: Removed.
900         * wpe/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Added.
901         * wpe/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Added.
902         * wpe/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Added.
903         * wpe/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Added.
904         * wpe/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Removed.
905         * wpe/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Removed.
906         * wpe/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Added.
907
908 2017-07-10  John Wilander  <wilander@apple.com>
909
910         Resource Load Statistics: Prune statistics in orders of importance
911         https://bugs.webkit.org/show_bug.cgi?id=174215
912         <rdar://problem/33164403>
913
914         Reviewed by Chris Dumez.
915
916         Nest infrastructure. Adds these functions:
917         1. testRunner.setStatisticsLastSeen()
918         2. setStatisticsMaxStatisticsEntries()
919         3. setStatisticsPruneEntriesDownTo()
920
921         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
922         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
923         (WTR::TestRunner::setStatisticsLastSeen):
924         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
925         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
926         * WebKitTestRunner/InjectedBundle/TestRunner.h:
927         * WebKitTestRunner/TestController.cpp:
928         (WTR::TestController::setStatisticsLastSeen):
929         (WTR::TestController::setMaxStatisticsEntries):
930         (WTR::TestController::setPruneEntriesDownTo):
931         * WebKitTestRunner/TestController.h:
932         * WebKitTestRunner/TestInvocation.cpp:
933         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
934         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
935         (WTR::TestController::setStatisticsLastSeen):
936         (WTR::TestController::setStatisticsMaxStatisticsEntries):
937         (WTR::TestController::setStatisticsPruneEntriesDownTo):
938
939 2017-07-03  Brian Burg  <bburg@apple.com>
940
941         Web Replay: remove some unused code
942         https://bugs.webkit.org/show_bug.cgi?id=173903
943
944         Rubber-stamped by Joseph Pecoraro.
945
946         * Scripts/run-input-generator-tests: Removed.
947         * Scripts/webkitpy/replay/__init__.py: Removed.
948         * Scripts/webkitpy/replay/main.py: Removed.
949
950 2017-07-10  Zan Dobersek  <zdobersek@igalia.com>
951
952         [WPE] Fix layout test baseline and TestExpectations hierarchy
953         https://bugs.webkit.org/show_bug.cgi?id=174092
954
955         Reviewed by Michael Catanzaro.
956
957         Like for the GTK+ port, override the default_baseline_search_path() and
958         _port_specific_expectations_files() methods in the webkitpy.port.WPEPort class.
959         Both methods operate on a short list of search paths that defaults to 'wpe' and
960         'wk2', along with any other user-specified platform directory.
961
962         The test_expectations_file_position() method is overridden for testing purposes,
963         and relevant unit tests are added.
964
965         * Scripts/webkitpy/port/wpe.py:
966         (WPEPort._search_paths):
967         (WPEPort):
968         (WPEPort.default_baseline_search_path):
969         (WPEPort._port_specific_expectations_files):
970         (WPEPort.test_expectations_file_position):
971         * Scripts/webkitpy/port/wpe_unittest.py:
972         (WPEPortTest.test_default_baseline_search_path):
973         (WPEPortTest):
974         (WPEPortTest.test_port_specific_expectations_files):
975
976 2017-07-10  Chris Dumez  <cdumez@apple.com>
977
978         Further WebResourceLoadStatisticsStore / ResourceLoadStatisticsStore clean up
979         https://bugs.webkit.org/show_bug.cgi?id=174301
980
981         Reviewed by Brent Fulgham.
982
983         Rename some of the testRunner API for clarity and to better match what it calls
984         internally.
985
986         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
987         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
988         (WTR::TestRunner::statisticsUpdateCookiePartitioning):
989         (WTR::TestRunner::statisticsSetShouldPartitionCookiesForHost):
990         * WebKitTestRunner/InjectedBundle/TestRunner.h:
991         * WebKitTestRunner/TestController.cpp:
992         (WTR::TestController::statisticsUpdateCookiePartitioning):
993         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
994         * WebKitTestRunner/TestController.h:
995         * WebKitTestRunner/TestInvocation.cpp:
996         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
997         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
998         (WTR::TestController::statisticsUpdateCookiePartitioning):
999         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
1000
1001 2017-07-10  Charlie Turner  <cturner@igalia.com>
1002
1003         [GStreamer] Live twitch.tv videos do not play
1004         https://bugs.webkit.org/show_bug.cgi?id=174222
1005
1006         Reviewed by Michael Catanzaro.
1007
1008         Upgrade GStreamer to 1.10.5. It contains a change to typefind that
1009         fixes videos not playing on twitch.tv.
1010
1011         * gtk/jhbuild.modules:
1012
1013 2017-07-09  Zan Dobersek  <zdobersek@igalia.com>
1014
1015         Add WebGL2 configuration option to build-webkit
1016         https://bugs.webkit.org/show_bug.cgi?id=174251
1017
1018         Reviewed by Michael Catanzaro.
1019
1020         * Scripts/webkitperl/FeatureList.pm: Add the 'webgl2' option, making it possible
1021         to enable the ENABLE_WEBGL2 flag through the build-webkit script. The feature
1022         is marked as enabled for the Apple Cocoa ports.
1023
1024 2017-07-08  Chris Dumez  <cdumez@apple.com>
1025
1026         Simplify WebResourceLoadStatisticsStore / ResourceLoadStatisticsStore
1027         https://bugs.webkit.org/show_bug.cgi?id=174290
1028
1029         Reviewed by Brent Fulgham.
1030
1031         Rename testRunner API to match the new internal API names.
1032
1033         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1034         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1035         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
1036         (WTR::TestRunner::statisticsSubmitTelemetry):
1037         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1038         * WebKitTestRunner/TestController.cpp:
1039         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
1040         (WTR::TestController::statisticsSubmitTelemetry):
1041         * WebKitTestRunner/TestController.h:
1042         * WebKitTestRunner/TestInvocation.cpp:
1043         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1044         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1045         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
1046         (WTR::TestController::statisticsSubmitTelemetry):
1047
1048 2017-07-08  Yusuke Suzuki  <utatane.tea@gmail.com>
1049
1050         Drop NOSNIFF compile flag
1051         https://bugs.webkit.org/show_bug.cgi?id=174289
1052
1053         Reviewed by Michael Catanzaro.
1054
1055         * Scripts/webkitperl/FeatureList.pm:
1056         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1057
1058 2017-07-07  Wenson Hsieh  <wenson_hsieh@apple.com>
1059
1060         [iOS DnD] For cross-app drags, 'drop' event handlers are never invoked if dataTransfer.dropEffect is not set while dragging
1061         https://bugs.webkit.org/show_bug.cgi?id=174219
1062         <rdar://problem/32083177>
1063
1064         Reviewed by Ryosuke Niwa.
1065
1066         Add plumbing and support to mock the value of -allowsMoveOperation on the simulated UIDragDropSession objects.
1067         Setting the DataInteractionSimulator's shouldAllowMoveOperation property to NO simulates a drag operation coming
1068         in from another app out-of-process, for which move operations won't cause a drop to be performed in the first
1069         place.
1070
1071         Also tweaks 2 existing unit tests regarding file uploads via JavaScript to simulate items coming in from a
1072         different application, and adds a new test to check that if a drop area specifically requests a MOVE operation,
1073         no action is taken when dropping.
1074
1075         * TestWebKitAPI/Tests/WebKit2Cocoa/file-uploading.html:
1076         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1077         (TestWebKitAPI::TEST):
1078         * TestWebKitAPI/ios/DataInteractionSimulator.h:
1079         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1080         (-[MockDragDropSession initWithItems:location:window:allowMove:]):
1081         (-[MockDragDropSession allowsMoveOperation]):
1082         (-[MockDataOperationSession initWithProviders:location:window:allowMove:]):
1083         (-[MockDataInteractionSession initWithWindow:allowMove:]):
1084         (-[DataInteractionSimulator initWithWebView:]):
1085         (-[DataInteractionSimulator runFrom:to:]):
1086         (-[DataInteractionSimulator _advanceProgress]):
1087         (-[MockDragDropSession initWithItems:location:window:]): Deleted.
1088         (-[MockDataOperationSession initWithProviders:location:window:]): Deleted.
1089         (-[MockDataInteractionSession initWithWindow:]): Deleted.
1090
1091 2017-07-07  Commit Queue  <commit-queue@webkit.org>
1092
1093         Unreviewed, rolling out r219238, r219239, and r219241.
1094         https://bugs.webkit.org/show_bug.cgi?id=174265
1095
1096         "fast/workers/dedicated-worker-lifecycle.html is flaky"
1097         (Requested by yusukesuzuki on #webkit).
1098
1099         Reverted changesets:
1100
1101         "[WTF] Implement WTF::ThreadGroup"
1102         https://bugs.webkit.org/show_bug.cgi?id=174081
1103         http://trac.webkit.org/changeset/219238
1104
1105         "Unreviewed, build fix after r219238"
1106         https://bugs.webkit.org/show_bug.cgi?id=174081
1107         http://trac.webkit.org/changeset/219239
1108
1109         "Unreviewed, CLoop build fix after r219238"
1110         https://bugs.webkit.org/show_bug.cgi?id=174081
1111         http://trac.webkit.org/changeset/219241
1112
1113 2017-07-07  Yusuke Suzuki  <utatane.tea@gmail.com>
1114
1115         [GTK][WPE] Enable X-Content-Type-Options: nosniff
1116         https://bugs.webkit.org/show_bug.cgi?id=174250
1117
1118         Reviewed by Carlos Alberto Lopez Perez.
1119
1120         * Scripts/webkitperl/FeatureList.pm:
1121
1122 2017-07-07  Charlie Turner  <cturner@igalia.com>
1123         [GStreamer] vid.me videos do not play
1124         https://bugs.webkit.org/show_bug.cgi?id=172240
1125
1126         Reviewed by Xabier Rodriguez-Calvar.
1127
1128         Build httpsoupsrc again for use in adaptive streaming pipelines, and
1129         have the existing libsoup build against GNOME to avoid header drift
1130         against GStreamer's linked Soup library.
1131
1132         * gtk/jhbuild.modules:
1133
1134 2017-07-06  Lucas Forschler  <lforschler@apple.com>
1135
1136         Write a support script to enable buildbot to upload to S3
1137         https://bugs.webkit.org/show_bug.cgi?id=174196
1138         
1139         Reviewed by Stephanie Lewis.
1140
1141         * BuildSlaveSupport/build.webkit.org-config/transfer-archive-to-s3: Added.
1142         (uploadToS3):
1143         (archiveExists):
1144
1145 2017-07-06  Lucas Forschler  <lforschler@apple.com>
1146
1147         Enabling uploading archives to S3.
1148         https://bugs.webkit.org/show_bug.cgi?id=174198
1149         
1150         Reviewed by Stephanie Lewis.
1151
1152         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1153         (ArchiveMinifiedBuiltProduct): Create a minified archive from a full archive
1154         (UploadMinifiedBuiltProduct): Upload minified archive to build master
1155         (TransferToS3): Transfer full and minified archives to S3
1156
1157 2017-07-05  Yusuke Suzuki  <utatane.tea@gmail.com>
1158
1159         [WTF] Implement WTF::ThreadGroup
1160         https://bugs.webkit.org/show_bug.cgi?id=174081
1161
1162         Reviewed by Mark Lam.
1163
1164         Add WTF::ThreadGroup tests.
1165
1166         * TestWebKitAPI/CMakeLists.txt:
1167         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1168         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp: Added.
1169         (TestWebKitAPI::TEST):
1170
1171 2017-07-06  Yusuke Suzuki  <utatane.tea@gmail.com>
1172
1173         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
1174         https://bugs.webkit.org/show_bug.cgi?id=174150
1175
1176         Reviewed by Mark Lam.
1177
1178         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
1179         (TestWebKitAPI::TEST):
1180         * TestWebKitAPI/TestsController.cpp:
1181         (TestWebKitAPI::TestsController::TestsController):
1182
1183 2017-07-06  Lucas Forschler  <lforschler@apple.com>
1184
1185         Enabling uploading archives to S3.
1186         https://bugs.webkit.org/show_bug.cgi?id=174198
1187         
1188         Reviewed by Lucas Forschler.
1189
1190         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1191         (ArchiveMinifiedBuiltProduct): Create a minified archive from a full archive
1192         (UploadMinifiedBuiltProduct): Upload minified archive to build master
1193         (TransferToS3): Transfer full and minified archives to S3
1194
1195 2017-07-06  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1196
1197         [GTK][WPE] kill-old-process should kill more webkit related process
1198         https://bugs.webkit.org/show_bug.cgi?id=174220
1199
1200         Reviewed by Michael Catanzaro.
1201
1202         Generate list of possible webkit-related process names and add
1203         them to the list of process to kill.
1204         Also update the possible system related process for GTK+/WPE.
1205
1206         * BuildSlaveSupport/kill-old-processes:
1207         (listAllWebKitPrograms):
1208         (main):
1209
1210 2017-07-06  Chris Dumez  <cdumez@apple.com>
1211
1212         FileMonitor should not be ref counted
1213         https://bugs.webkit.org/show_bug.cgi?id=174166
1214
1215         Reviewed by Brent Fulgham.
1216
1217         Update the API tests to reflect the API change.
1218
1219         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
1220         (TestWebKitAPI::TEST_F):
1221
1222 2017-07-06  Commit Queue  <commit-queue@webkit.org>
1223
1224         Unreviewed, rolling out r219194.
1225         https://bugs.webkit.org/show_bug.cgi?id=174207
1226
1227         it broke some layout tests (Requested by clopez on #webkit).
1228
1229         Reverted changeset:
1230
1231         "[GStreamer] vid.me videos do not play"
1232         https://bugs.webkit.org/show_bug.cgi?id=172240
1233         http://trac.webkit.org/changeset/219194
1234
1235 2017-07-06  Matt Lewis  <jlewis3@apple.com>
1236
1237         Unreviewed, rolling out r219178.
1238
1239         This caused a consistent failure with the API test
1240         StringBuilderTest.ToAtomicStringOnEmpty on all Debug testers.
1241
1242         Reverted changeset:
1243
1244         "[WTF] Clean up StringStatics.cpp by using
1245         LazyNeverDestroyed<> for Atoms"
1246         https://bugs.webkit.org/show_bug.cgi?id=174150
1247         http://trac.webkit.org/changeset/219178
1248
1249 2017-07-06  Alicia Boya García  <aboya@igalia.com>
1250
1251         Add CWD to Perl library path (no longer the default since 5.26.0)
1252         https://bugs.webkit.org/show_bug.cgi?id=174200
1253
1254         Reviewed by Michael Catanzaro.
1255
1256         * Scripts/webkitpy/tool/commands/setupgitclone.py:
1257         (SetupGitClone._get_username_and_email):
1258
1259 2017-07-06  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1260
1261         Unreviewed, update my email address.
1262
1263         * Scripts/webkitpy/common/config/contributors.json:
1264
1265 2017-07-06  Charlie Turner  <cturner@igalia.com>
1266         [GStreamer] vid.me videos do not play
1267         https://bugs.webkit.org/show_bug.cgi?id=172240
1268
1269         Reviewed by Xabier Rodriguez-Calvar.
1270
1271         Build httpsoupsrc again for use in adaptive streaming pipelines, and
1272         have the existing libsoup build against GNOME to avoid header drift
1273         against GStreamer's linked Soup library.
1274
1275         * gtk/jhbuild.modules:
1276
1277 2017-07-05  Don Olmstead  <don.olmstead@sony.com>
1278
1279         [WTF] Move SoftLinking.h into WTF
1280         https://bugs.webkit.org/show_bug.cgi?id=174000
1281
1282         Reviewed by Alex Christensen.
1283
1284         * DumpRenderTree/mac/TestRunnerMac.mm:
1285         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1286         (test_primary_header):
1287         (ErrorCollector.__init__): Deleted.
1288         (ErrorCollector.__call__): Deleted.
1289         (ErrorCollector.results): Deleted.
1290         (ErrorCollector.result_list): Deleted.
1291         (ErrorCollector.verify_all_categories_are_seen): Deleted.
1292         (MockIo.open): Deleted.
1293         (CppFunctionsTest.test_convert_to_lower_with_underscores): Deleted.
1294         (CppFunctionsTest.test_create_acronym): Deleted.
1295         (CppFunctionsTest.test_is_c_or_objective_c): Deleted.
1296         (CppFunctionsTest.test_parameter): Deleted.
1297         (CppFunctionsTest.test_single_line_view): Deleted.
1298         (CppFunctionsTest.test_create_skeleton_parameters): Deleted.
1299         (CppFunctionsTest.test_find_parameter_name_index): Deleted.
1300         (CppFunctionsTest.test_parameter_list): Deleted.
1301         (CppFunctionsTest.test_check_parameter_against_text): Deleted.
1302         (CppStyleTestBase.process_file_data): Deleted.
1303         (CppStyleTestBase.perform_lint): Deleted.
1304         (CppStyleTestBase.perform_single_line_lint): Deleted.
1305         (CppStyleTestBase.perform_multi_line_lint): Deleted.
1306         (CppStyleTestBase.perform_language_rules_check): Deleted.
1307         (CppStyleTestBase.perform_function_lengths_check): Deleted.
1308         (CppStyleTestBase.perform_pass_ptr_check): Deleted.
1309         (CppStyleTestBase.perform_leaky_pattern_check): Deleted.
1310         (CppStyleTestBase.perform_include_what_you_use): Deleted.
1311         (CppStyleTestBase.perform_header_guard_check): Deleted.
1312         (CppStyleTestBase.assert_lint): Deleted.
1313         (CppStyleTestBase.assert_lint_one_of_many_errors_re): Deleted.
1314         (CppStyleTestBase.assert_multi_line_lint): Deleted.
1315         (CppStyleTestBase.assert_multi_line_lint_re): Deleted.
1316         (CppStyleTestBase.assert_language_rules_check): Deleted.
1317         (CppStyleTestBase.assert_include_what_you_use): Deleted.
1318         (CppStyleTestBase.assert_header_guard): Deleted.
1319         (CppStyleTestBase.assert_blank_lines_check): Deleted.
1320         (CppStyleTestBase.assert_positions_equal): Deleted.
1321         (FunctionDetectionTest.test_basic_function_detection): Deleted.
1322         (FunctionDetectionTest.test_function_declaration_detection): Deleted.
1323         (FunctionDetectionTest.test_pure_function_detection): Deleted.
1324         (FunctionDetectionTest.test_override_and_final_function_detection): Deleted.
1325         (FunctionDetectionTest.test_ignore_macros): Deleted.
1326         (FunctionDetectionTest.test_non_functions): Deleted.
1327         (FunctionDetectionTest.test_non_functions.Stuff): Deleted.
1328         (FunctionDetectionTest.test_parameter_list): Deleted.
1329         (Cpp11StyleTest.test_rvaule_reference_in_parameter_pack): Deleted.
1330         (CppStyleTest.test_asm_lines_ignored): Deleted.
1331         (CppStyleTest.test_get_line_width): Deleted.
1332         (CppStyleTest.test_find_next_multi_line_comment_start): Deleted.
1333         (CppStyleTest.test_find_next_multi_line_comment_end): Deleted.
1334         (CppStyleTest.test_remove_multi_line_comments_from_range): Deleted.
1335         (CppStyleTest.test_position): Deleted.
1336         (CppStyleTest.test_rfind_in_lines): Deleted.
1337         (CppStyleTest.test_close_expression): Deleted.
1338         (CppStyleTest.test_spaces_at_end_of_line): Deleted.
1339         (CppStyleTest.test_cstyle_cast): Deleted.
1340         (CppStyleTest.test_runtime_casting): Deleted.
1341         (CppStyleTest.test_runtime_selfinit): Deleted.
1342         (CppStyleTest.test_runtime_rtti): Deleted.
1343         (CppStyleTest.test_static_cast_readability): Deleted.
1344         (CppStyleTest.test_check_for_unnamed_params): Deleted.
1345         (CppStyleTest.void): Deleted.
1346         (CppStyleTest.test_deprecated_cast): Deleted.
1347         (CppStyleTest.test_mock_method): Deleted.
1348         (CppStyleTest.test_sizeof_type): Deleted.
1349         (CppStyleTest.cases): Deleted.
1350         (CppStyleTest.for): Deleted.
1351         (CppStyleTest.test_typedef_for_pointer_to_function): Deleted.
1352         (CppStyleTest.test_typedef_for_pointer_to_function.void): Deleted.
1353         (CppStyleTest.test_include_what_you_use_no_implementation_files): Deleted.
1354         (CppStyleTest.test_include_what_you_use): Deleted.
1355         (CppStyleTest.test_files_belong_to_same_module): Deleted.
1356         (CppStyleTest.test_cleanse_line): Deleted.
1357         (CppStyleTest.test_multi_line_comments): Deleted.
1358         (CppStyleTest.test_multi_line_comments.Foo): Deleted.
1359         (CppStyleTest.test_multiline_strings): Deleted.
1360         (CppStyleTest.test_platformh_comments): Deleted.
1361         (CppStyleTest.test_explicit_single_argument_constructors): Deleted.
1362         (CppStyleTest.test_explicit_single_argument_constructors.Foo): Deleted.
1363         (CppStyleTest.test_explicit_single_argument_constructors.Qualifier): Deleted.
1364         (CppStyleTest.test_explicit_single_argument_constructors.definition): Deleted.
1365         (CppStyleTest.test_slash_star_comment_on_single_line): Deleted.
1366         (CppStyleTest.test_suspicious_usage_of_if): Deleted.
1367         (CppStyleTest.test_suspicious_usage_of_memset): Deleted.
1368         (CppStyleTest.test_check_posix_threading): Deleted.
1369         (CppStyleTest.test_insecure_string_operations): Deleted.
1370         (CppStyleTest.test_format_strings): Deleted.
1371         (CppStyleTest.test_insecure_temp_file): Deleted.
1372         (CppStyleTest.test_variable_length_array_detection): Deleted.
1373         (CppStyleTest.test_braces): Deleted.
1374         (CppStyleTest.test_check_check): Deleted.
1375         (CppStyleTest.test_brace_at_begin_of_line): Deleted.
1376         (CppStyleTest.test_mismatching_spaces_in_parens): Deleted.
1377         (CppStyleTest.test_spacing_for_fncall): Deleted.
1378         (CppStyleTest.test_spacing_for_fncall.foo): Deleted.
1379         (CppStyleTest.test_spacing_before_braces): Deleted.
1380         (CppStyleTest.test_spacing_between_braces): Deleted.
1381         (CppStyleTest.test_spacing_before_brackets): Deleted.
1382         (CppStyleTest.test_cpp_lambda_functions): Deleted.
1383         (CppStyleTest.test_objective_c_block): Deleted.
1384         (CppStyleTest.test_objective_c_block_as_argument): Deleted.
1385         (CppStyleTest.test_spacing_around_else): Deleted.
1386         (CppStyleTest.test_spacing_for_binary_ops): Deleted.
1387         (CppStyleTest.test_spacing_for_binary_ops.hash_map): Deleted.
1388         (CppStyleTest.test_operator_methods): Deleted.
1389         (CppStyleTest.test_spacing_in_objective_c_properties): Deleted.
1390         (CppStyleTest.test_spacing_before_last_semicolon): Deleted.
1391         (CppStyleTest.test_static_or_global_stlstrings): Deleted.
1392         (CppStyleTest.test_no_spaces_in_function_calls): Deleted.
1393         (CppStyleTest.test_one_spaces_between_code_and_comments): Deleted.
1394         (CppStyleTest.test_one_spaces_after_punctuation_in_comments): Deleted.
1395         (CppStyleTest.test_space_after_comment_marker): Deleted.
1396         (CppStyleTest.test_newline_at_eof): Deleted.
1397         (CppStyleTest.test_newline_at_eof.do_test): Deleted.
1398         (CppStyleTest.test_extra_newlines_at_eof): Deleted.
1399         (CppStyleTest.test_extra_newlines_at_eof.do_test): Deleted.
1400         (CppStyleTest.test_invalid_utf8): Deleted.
1401         (CppStyleTest.test_invalid_utf8.do_test): Deleted.
1402         (CppStyleTest.test_is_blank_line): Deleted.
1403         (CppStyleTest.test_blank_lines_check): Deleted.
1404         (CppStyleTest.test_allow_blank_line_before_closing_namespace): Deleted.
1405         (CppStyleTest.test_allow_blank_line_before_if_else_chain): Deleted.
1406         (CppStyleTest.test_else_on_same_line_as_closing_braces): Deleted.
1407         (CppStyleTest.test_else_clause_not_on_same_line_as_else): Deleted.
1408         (CppStyleTest.test_comma): Deleted.
1409         (CppStyleTest.test_declaration): Deleted.
1410         (CppStyleTest.test_pointer_reference_marker_location): Deleted.
1411         (CppStyleTest.test_indent): Deleted.
1412         (CppStyleTest.test_indent.Foo): Deleted.
1413         (CppStyleTest.test_not_alabel): Deleted.
1414         (CppStyleTest.test_tab): Deleted.
1415         (CppStyleTest.test_unnamed_namespaces_in_headers): Deleted.
1416         (CppStyleTest.test_build_class): Deleted.
1417         (CppStyleTest.test_build_class.definitions): Deleted.
1418         (CppStyleTest.test_build_class.Foo): Deleted.
1419         (CppStyleTest.test_build_class.DERIVE_FROM_GOO): Deleted.
1420         (CppStyleTest.test_build_end_comment): Deleted.
1421         (CppStyleTest.test_build_forward_decl): Deleted.
1422         (CppStyleTest.test_build_forward_decl.Foo): Deleted.
1423         (CppStyleTest.test_build_header_guard): Deleted.
1424         (CppStyleTest.test_build_header_guard.Foo_h): Deleted.
1425         (CppStyleTest.test_build_header_guard.Foo_h.for): Deleted.
1426         (CppStyleTest.test_build_printf_format): Deleted.
1427         (CppStyleTest.test_runtime_printf_format): Deleted.
1428         (CppStyleTest.assert_lintLogCodeOnError): Deleted.
1429         (CppStyleTest.test_build_storage_class): Deleted.
1430         (CppStyleTest.test_build_storage_class.unsignedLongLong): Deleted.
1431         (CppStyleTest.test_build_storage_class.declaration): Deleted.
1432         (CppStyleTest.test_build_storage_class.after): Deleted.
1433         (CppStyleTest.test_build_storage_class.is): Deleted.
1434         (CppStyleTest.test_legal_copyright): Deleted.
1435         (CppStyleTest.test_invalid_increment): Deleted.
1436         (CppStyleTest.test_enum_bitfields): Deleted.
1437         (CppStyleTest.test_plain_integral_bitfields): Deleted.
1438         (CleansedLinesTest.test_init_empty): Deleted.
1439         (CleansedLinesTest.test_collapse_strings): Deleted.
1440         (OrderOfIncludesTest.tearDown): Deleted.
1441         (OrderOfIncludesTest.test_check_next_include_order__no_config): Deleted.
1442         (OrderOfIncludesTest.test_check_next_include_order__no_self): Deleted.
1443         (OrderOfIncludesTest.test_check_next_include_order__likely_then_config): Deleted.
1444         (OrderOfIncludesTest.test_check_next_include_order__other_then_config): Deleted.
1445         (OrderOfIncludesTest.test_check_next_include_order__config_then_other_then_likely): Deleted.
1446         (OrderOfIncludesTest.test_check_alphabetical_include_order): Deleted.
1447         (OrderOfIncludesTest.test_check_alphabetical_include_order_errors_reported_for_both_lines): Deleted.
1448         (OrderOfIncludesTest.test_check_line_break_after_own_header): Deleted.
1449         (OrderOfIncludesTest.test_check_line_break_before_own_header): Deleted.
1450         (OrderOfIncludesTest.test_check_preprocessor_in_include_section): Deleted.
1451         (OrderOfIncludesTest.test_check_preprocessor_in_include_section.BAZ): Deleted.
1452         (OrderOfIncludesTest.test_check_preprocessor_in_include_section.FOOBAR): Deleted.
1453         (OrderOfIncludesTest.test_primary_header): Deleted.
1454         (OrderOfIncludesTest.test_public_primary_header): Deleted.
1455         (OrderOfIncludesTest.test_check_wtf_includes): Deleted.
1456         (OrderOfIncludesTest.test_classify_include): Deleted.
1457         (OrderOfIncludesTest.test_try_drop_common_suffixes): Deleted.
1458         (CheckForFunctionLengthsTest.tearDown): Deleted.
1459         (CheckForFunctionLengthsTest.set_min_confidence): Deleted.
1460         (CheckForFunctionLengthsTest.assert_function_lengths_check): Deleted.
1461         (CheckForFunctionLengthsTest.trigger_lines): Deleted.
1462         (CheckForFunctionLengthsTest.trigger_test_lines): Deleted.
1463         (CheckForFunctionLengthsTest.assert_function_length_check_definition): Deleted.
1464         (CheckForFunctionLengthsTest.assert_function_length_check_definition_ok): Deleted.
1465         (CheckForFunctionLengthsTest.assert_function_length_check_at_error_level): Deleted.
1466         (CheckForFunctionLengthsTest.assert_function_length_check_below_error_level): Deleted.
1467         (CheckForFunctionLengthsTest.assert_function_length_check_above_error_level): Deleted.
1468         (CheckForFunctionLengthsTest.function_body): Deleted.
1469         (CheckForFunctionLengthsTest.function_body_with_blank_lines): Deleted.
1470         (CheckForFunctionLengthsTest.function_body_with_no_lints): Deleted.
1471         (CheckForFunctionLengthsTest.test_function_length_check_declaration): Deleted.
1472         (CheckForFunctionLengthsTest.test_function_length_check_declaration_with_block_following): Deleted.
1473         (CheckForFunctionLengthsTest.test_function_length_check_class_definition): Deleted.
1474         (CheckForFunctionLengthsTest.test_function_length_check_class_definition.Test): Deleted.
1475         (CheckForFunctionLengthsTest.test_function_length_check_trivial): Deleted.
1476         (CheckForFunctionLengthsTest.test_function_length_check_empty): Deleted.
1477         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity0): Deleted.
1478         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity0): Deleted.
1479         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity0): Deleted.
1480         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity1v0): Deleted.
1481         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity1v0): Deleted.
1482         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity1): Deleted.
1483         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity1): Deleted.
1484         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity1): Deleted.
1485         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_plus_indented): Deleted.
1486         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_plus_blanks): Deleted.
1487         (CheckForFunctionLengthsTest.test_function_length_check_complex_definition_severity1): Deleted.
1488         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_test): Deleted.
1489         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_split_line_test): Deleted.
1490         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Deleted.
1491         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_with_embedded_no_lints): Deleted.
1492         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_with_no_lint): Deleted.
1493         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity2): Deleted.
1494         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity2): Deleted.
1495         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity2): Deleted.
1496         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity3): Deleted.
1497         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity3): Deleted.
1498         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity3): Deleted.
1499         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity4): Deleted.
1500         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity4): Deleted.
1501         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity4): Deleted.
1502         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity5): Deleted.
1503         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity5): Deleted.
1504         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity5): Deleted.
1505         (CheckForFunctionLengthsTest.test_function_length_check_definition_huge_lines): Deleted.
1506         (CheckForFunctionLengthsTest.test_function_length_not_determinable): Deleted.
1507         (NoNonVirtualDestructorsTest.test_no_error): Deleted.
1508         (NoNonVirtualDestructorsTest.test_no_error.Foo): Deleted.
1509         (NoNonVirtualDestructorsTest.test_no_error.MyClass): Deleted.
1510         (NoNonVirtualDestructorsTest.test_no_error.Qualified): Deleted.
1511         (NoNonVirtualDestructorsTest.test_no_destructor_when_virtual_needed): Deleted.
1512         (NoNonVirtualDestructorsTest.test_no_destructor_when_virtual_needed.Foo): Deleted.
1513         (NoNonVirtualDestructorsTest.test_enum_casing): Deleted.
1514         (NoNonVirtualDestructorsTest.test_enum_casing.Foo): Deleted.
1515         (NoNonVirtualDestructorsTest.test_enum_casing.Enum123): Deleted.
1516         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon): Deleted.
1517         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon.CPP11EnumClass): Deleted.
1518         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon.MyEnum): Deleted.
1519         (NoNonVirtualDestructorsTest.test_destructor_non_virtual_when_virtual_needed): Deleted.
1520         (NoNonVirtualDestructorsTest.test_destructor_non_virtual_when_virtual_needed.Foo): Deleted.
1521         (NoNonVirtualDestructorsTest.test_no_warn_when_derived): Deleted.
1522         (NoNonVirtualDestructorsTest.test_no_warn_when_derived.Foo): Deleted.
1523         (NoNonVirtualDestructorsTest.test_internal_braces): Deleted.
1524         (NoNonVirtualDestructorsTest.test_internal_braces.Foo): Deleted.
1525         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor): Deleted.
1526         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Foo): Deleted.
1527         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Foo.Goo): Deleted.
1528         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Goo): Deleted.
1529         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor): Deleted.
1530         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor.Foo): Deleted.
1531         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor.Foo.Goo): Deleted.
1532         (NoNonVirtualDestructorsTest.test_qualified_class_needs_virtual_destructor): Deleted.
1533         (NoNonVirtualDestructorsTest.test_qualified_class_needs_virtual_destructor.Qualified): Deleted.
1534         (NoNonVirtualDestructorsTest.test_multi_line_declaration_no_error): Deleted.
1535         (NoNonVirtualDestructorsTest.test_multi_line_declaration_no_error.Foo): Deleted.
1536         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error): Deleted.
1537         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error.Foo): Deleted.
1538         (LeakyPatternTest.assert_leaky_pattern_check): Deleted.
1539         (LeakyPatternTest.test_get_dc): Deleted.
1540         (LeakyPatternTest.test_get_dc.HWndDC): Deleted.
1541         (LeakyPatternTest.test_own_get_dc): Deleted.
1542         (LeakyPatternTest.test_create_dc): Deleted.
1543         (LeakyPatternTest.test_create_compatible_dc): Deleted.
1544         (WebKitStyleTest.test_indentation): Deleted.
1545         (WebKitStyleTest.test_indentation.Foo): Deleted.
1546         (WebKitStyleTest.test_indentation.Document): Deleted.
1547         (WebKitStyleTest.test_spacing): Deleted.
1548         (WebKitStyleTest.test_line_breaking): Deleted.
1549         (WebKitStyleTest.test_braces): Deleted.
1550         (WebKitStyleTest.test_braces.MyClass): Deleted.
1551         (WebKitStyleTest.test_braces.NS_ENUM): Deleted.
1552         (WebKitStyleTest.test_braces.CPP11EnumClass): Deleted.
1553         (WebKitStyleTest.test_braces.SOMETHING): Deleted.
1554         (WebKitStyleTest.test_null_false_zero): Deleted.
1555         (WebKitStyleTest.test_directive_indentation): Deleted.
1556         (WebKitStyleTest.test_using_std): Deleted.
1557         (WebKitStyleTest.test_using_namespace): Deleted.
1558         (WebKitStyleTest.test_max_macro): Deleted.
1559         (WebKitStyleTest.test_min_macro): Deleted.
1560         (WebKitStyleTest.test_wtf_move): Deleted.
1561         (WebKitStyleTest.test_ctype_fucntion): Deleted.
1562         (WebKitStyleTest.test_names): Deleted.
1563         (WebKitStyleTest.test_names.HTMLDocument): Deleted.
1564         (WebKitStyleTest.test_names.WebWindowFadeAnimation): Deleted.
1565         (WebKitStyleTest.test_names.declarations): Deleted.
1566         (WebKitStyleTest.test_names.struct): Deleted.
1567         (WebKitStyleTest.test_names.VectorType): Deleted.
1568         (WebKitStyleTest.test_parameter_names): Deleted.
1569         (WebKitStyleTest.test_comments): Deleted.
1570         (WebKitStyleTest.test_webkit_export_check): Deleted.
1571         (WebKitStyleTest.test_member_initialization_list): Deleted.
1572         (WebKitStyleTest.test_member_initialization_list.MyClass): Deleted.
1573         (WebKitStyleTest.test_other): Deleted.
1574         (CppCheckerTest.mock_handle_style_error): Deleted.
1575         (CppCheckerTest._checker): Deleted.
1576         (CppCheckerTest.test_init): Deleted.
1577         (CppCheckerTest.test_eq): Deleted.
1578         (CppCheckerTest.test_eq.mock_handle_style_error2): Deleted.
1579         (CppCheckerTest.test_ne): Deleted.
1580         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
1581         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1582         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1583         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1584         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1585         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1586
1587 2017-07-05  Saam Barati  <sbarati@apple.com>
1588
1589         NewArray in FTLLowerDFGToB3 does not handle speculating on doubles when having a bad time
1590         https://bugs.webkit.org/show_bug.cgi?id=174188
1591         <rdar://problem/30581423>
1592
1593         Reviewed by Mark Lam.
1594
1595         * Scripts/run-jsc-stress-tests:
1596
1597 2017-07-05  Yusuke Suzuki  <utatane.tea@gmail.com>
1598
1599         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
1600         https://bugs.webkit.org/show_bug.cgi?id=174150
1601
1602         Reviewed by Mark Lam.
1603
1604         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
1605         (TestWebKitAPI::TEST):
1606
1607 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
1608
1609         Remove copy of ICU headers from WebKit
1610         https://bugs.webkit.org/show_bug.cgi?id=116407
1611
1612         Reviewed by Alex Christensen.
1613
1614         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1615         * TestWebKitAPI/Configurations/Base.xcconfig:
1616         * WebKitTestRunner/Configurations/Base.xcconfig:
1617
1618 2017-07-05  Chris Dumez  <cdumez@apple.com>
1619
1620         Regression(r218821): Bad cast to WebKit::DiagnosticLoggingClient in WKWebView's _setDiagnosticLoggingDelegate
1621         https://bugs.webkit.org/show_bug.cgi?id=174163
1622         <rdar://problem/33067518>
1623
1624         Reviewed by Alex Christensen.
1625
1626         Add API test coverage.
1627
1628         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1629         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDiagnosticLogging.mm: Added.
1630         (TEST):
1631
1632 2017-07-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1633
1634         When dragging a selection, clearing the selection in dragstart should not crash the web process
1635         https://bugs.webkit.org/show_bug.cgi?id=174142
1636         <rdar://problem/33067501>
1637
1638         Reviewed by Tim Horton.
1639
1640         Adds a unit test checking that the web process does not crash when the selection is cleared while a selection
1641         drag is starting up.
1642
1643         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1644         * TestWebKitAPI/Tests/WebKit2Cocoa/dragstart-clear-selection.html: Added.
1645         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1646         (TestWebKitAPI::TEST):
1647
1648 2017-07-05  Daniel Bates  <dabates@apple.com>
1649
1650         Do not pass API::FrameInfo for source frame or clear out page of target frame on
1651         API navigation
1652         https://bugs.webkit.org/show_bug.cgi?id=174170
1653         <rdar://problem/33140328>
1654
1655         Reviewed by Brady Eidson.
1656
1657         Update tests as needed for the behavior change.
1658
1659         * TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm:
1660         (TEST):
1661
1662 2017-07-05  Jonathan Bedard  <jbedard@apple.com>
1663
1664         Add WebKitPrivateFrameworkStubs for iOS 11
1665         https://bugs.webkit.org/show_bug.cgi?id=173988
1666
1667         Reviewed by David Kilzer.
1668
1669         * DumpRenderTree/mac/Configurations/Base.xcconfig: iphoneos and iphonesimulator
1670         should use the same directory for private framework stubs.
1671         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
1672
1673 2017-07-05  Eric Carlson  <eric.carlson@apple.com>
1674
1675         [MediaStream] Protect request and web view during gUM client callback
1676         https://bugs.webkit.org/show_bug.cgi?id=174096
1677         <rdar://problem/32833102>
1678
1679         Reviewed by Youenn Fablet.
1680
1681         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1682         * TestWebKitAPI/Tests/WebKit2/GetUserMediaNavigation.mm: New test.
1683
1684 2017-07-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1685
1686         Unreviewed, guard iOS 11-dependent UIPasteboardTests to be iOS 11+ only
1687
1688         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1689
1690 2017-07-05  Matt Lewis  <jlewis3@apple.com>
1691
1692         Unreviewed, rolling out r219128.
1693
1694         Spoke with engineer who originally submitted, Patch for APi
1695         test to follow.
1696
1697         Reverted changeset:
1698
1699         "Unreviewed, rolling out r219070."
1700         https://bugs.webkit.org/show_bug.cgi?id=174082
1701         http://trac.webkit.org/changeset/219128
1702
1703 2017-07-05  Matt Lewis  <jlewis3@apple.com>
1704
1705         Unreviewed, rolling out r219070.
1706
1707         This revision caused consistent failures of the API test
1708         UIPasteboardTests.DoNotPastePlainTextAsURL on iOS.
1709
1710         Reverted changeset:
1711
1712         "Pasting single words copied to UIPasteboard inserts URLs in
1713         editable areas"
1714         https://bugs.webkit.org/show_bug.cgi?id=174082
1715         http://trac.webkit.org/changeset/219070
1716
1717 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
1718
1719         Remove unused EFL logo from bot watcher dashboard
1720         https://bugs.webkit.org/show_bug.cgi?id=174136
1721
1722         Reviewed by Alexey Proskuryakov.
1723
1724         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL.png: Removed.
1725         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL@2x.png: Removed.
1726
1727 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
1728
1729         [GTK] Add more GTK bots to dashboard
1730         https://bugs.webkit.org/show_bug.cgi?id=174129
1731
1732         Reviewed by Carlos Alberto Lopez Perez.
1733
1734         We have a bunch of GTK bots that I never look at because they're not on the dashboard. Add
1735         them.
1736
1737         This also changes the sort order to put WPE above GTK so that it's not buried under all the
1738         less-essential GTK bots.
1739
1740         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1741         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1742         (WebKitBuildbot):
1743
1744 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
1745
1746         [WPE] Add WPE to bot watcher dashboard
1747         https://bugs.webkit.org/show_bug.cgi?id=174119
1748
1749         Reviewed by Alexey Proskuryakov.
1750
1751         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/CREDIT: Added.
1752         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE.png: Added.
1753         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE@2x.png: Added.
1754         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1755         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1756         (WebKitBuildbot):
1757         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1758         (table.queue-grid tr.platform.linux-wpe img.logo):
1759
1760 2017-07-03  Lucas Forschler  <lforschler@apple.com>
1761
1762         https://bugs.webkit.org/show_bug.cgi?id=174105
1763         
1764         Reviewed by Stephanie Lewis.
1765
1766         * BuildSlaveSupport/built-product-archive:
1767         (main): Add a -minify parser option
1768         (createZip): Pass along the optional Minify argument if requested
1769         (minifySource): This will trim down archives, logic limited to Mac platform.
1770
1771 2017-07-03  Matt Rajca  <mrajca@apple.com>
1772
1773         Add/remove appropriate media element behavior restrictions when updateWebsitePolicies is called
1774         https://bugs.webkit.org/show_bug.cgi?id=174103
1775
1776         Reviewed by Alex Christensen.
1777
1778         Added an API test.
1779
1780         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Expose a pause method.
1781         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1782         (TEST): Added test.
1783         * TestWebKitAPI/cocoa/TestWKWebView.h:
1784         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1785         (-[TestWKWebView stringByEvaluatingJavaScript:]): Don't simulate a user gesture when invoking the script.
1786
1787 2017-07-03  Matt Lewis  <jlewis3@apple.com>
1788
1789         Unreviewed, rolling out r219103.
1790
1791         Caused multiple build failures.
1792
1793         Reverted changeset:
1794
1795         "Remove copy of ICU headers from WebKit"
1796         https://bugs.webkit.org/show_bug.cgi?id=116407
1797         http://trac.webkit.org/changeset/219103
1798
1799 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
1800
1801         Remove copy of ICU headers from WebKit
1802         https://bugs.webkit.org/show_bug.cgi?id=116407
1803
1804         Reviewed by Alex Christensen.
1805
1806         Use WTF's copy of ICU headers.
1807
1808         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1809         * TestWebKitAPI/Configurations/Base.xcconfig:
1810         * WebKitTestRunner/Configurations/Base.xcconfig:
1811
1812 2017-07-03  Brady Eidson  <beidson@apple.com>
1813
1814         Switch all WebKit API related to favicons from WebIconDatabase over to new WebCore::IconLoader mechanism.
1815         https://bugs.webkit.org/show_bug.cgi?id=174073
1816
1817         Reviewed by Andy Estes.
1818
1819         * DumpRenderTree/mac/TestRunnerMac.mm:
1820         (TestRunner::setIconDatabaseEnabled): Call new SPI for this setting instead of WebIconDatabase stuff.
1821
1822         * TestWebKitAPI/Tests/mac/WebViewIconLoading.mm:
1823         (-[MainFrameIconKVO observeValueForKeyPath:ofObject:change:context:]):
1824
1825 2017-07-03  Matt Lewis  <jlewis3@apple.com>
1826
1827         Unreviewed, rolling out r219083.
1828
1829         The revision caused an API failure on all testing platforms.
1830
1831         Reverted changeset:
1832
1833         "[MediaStream] Protect request and web view during gUM client
1834         callback"
1835         https://bugs.webkit.org/show_bug.cgi?id=174096
1836         http://trac.webkit.org/changeset/219083
1837
1838 2017-07-03  Jonathan Bedard  <jbedard@apple.com>
1839
1840         webkitpy: Properly number duplicated crashlogs
1841         https://bugs.webkit.org/show_bug.cgi?id=172002
1842
1843         Reviewed by Aakash Jain.
1844
1845         * Scripts/webkitpy/common/system/crashlogs.py:
1846         (CrashLogs._find_all_logs_darwin): Number multiple crash logs for a single process with
1847         an increasing integer.
1848         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
1849         (CrashLogsTest.create_crash_logs_darwin): Create duplicated crashlog for testing.
1850         (CrashLogsTest.test_find_all_log_darwin): Now 7 Darwin logs instead of 5.
1851         (CrashLogsTest.test_duplicate_log_darwin): Test that duplicated logs are correctly numbered.
1852
1853 2017-07-03  Ryosuke Niwa  <rniwa@webkit.org>
1854
1855         WebContent processes crash when the network process crashes with pending connection requests
1856         https://bugs.webkit.org/show_bug.cgi?id=174065
1857         <rdar://problem/30359835>
1858
1859         Reviewed by Tim Horton.
1860
1861         Add a API to ensure UI process tries to relaunch a new network process when the network process
1862         crashes with pending network connection requests.
1863
1864         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1865         * TestWebKitAPI/Tests/WebKit2/NetworkProcessCrashWithPendingConnection.mm: Added.
1866         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
1867         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
1868         (-[TestNavigationDelegate webViewWebContentProcessDidTerminate:]): Added.
1869
1870 2017-07-03  Eric Carlson  <eric.carlson@apple.com>
1871
1872         [MediaStream] Protect request and web view during gUM client callback
1873         https://bugs.webkit.org/show_bug.cgi?id=174096
1874         <rdar://problem/32833102>
1875
1876         Reviewed by Youenn Fablet.
1877
1878         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1879         * TestWebKitAPI/Tests/WebKit2/GetUserMediaNavigation.mm: New test.
1880
1881 2017-07-03  Andy Estes  <aestes@apple.com>
1882
1883         [Xcode] Add an experimental setting to build with ccache
1884         https://bugs.webkit.org/show_bug.cgi?id=173875
1885
1886         Reviewed by Tim Horton.
1887
1888         On systems that already have ccache(1) installed, this patch adds experimental support for
1889         it to Xcode builds. It can be enabled with the WK_USE_CCACHE build setting.
1890
1891         When ccache is enabled, CC is overridden to invoke Tools/ccache/ccache-clang. This script
1892         finds the "-isysroot" argument to determine the active SDK, uses xcrun(1) and the SDK to
1893         find the toolchain from which to run clang, and then invokes ccache with the required
1894         arguments.
1895
1896         ccache is invoked with CCACHE_SLOPPINESS="pch_defines,time_macros", which is required for
1897         precompiled headers to work properly [1].
1898
1899         LDPLUSPLUS is overridden to invoke Tools/ccache/ccache-clang++. It behaves the same as
1900         ccache-clang, except it tells ccache to execute clang++ instead of clang. This is important
1901         during linking.
1902         
1903         [1] https://ccache.samba.org/manual.html#_precompiled_headers
1904
1905         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Included ccache.xcconfig.
1906         * MiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
1907         * MobileMiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
1908         * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Ditto.
1909         * WebKitTestRunner/Configurations/DebugRelease.xcconfig: Ditto.
1910         * ccache/README.md: Added.
1911         * ccache/ccache-clang: Added.
1912         * ccache/ccache-clang++: Added.
1913         * ccache/ccache.xcconfig: Added. Overrides CC and LDPLUSPLUS when WK_USE_CACHE=YES.
1914
1915 2017-07-03  Alex Christensen  <achristensen@webkit.org>
1916
1917         REGRESSION(r215096) Queries of URLs with non-special schemes should not percent-encode single quotes
1918         https://bugs.webkit.org/show_bug.cgi?id=174051
1919
1920         Reviewed by Tim Horton.
1921
1922         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1923         (TestWebKitAPI::TEST_F):
1924
1925 2017-07-03  Matt Lewis  <jlewis3@apple.com>
1926
1927         Unreviewed, rolling out r219024.
1928
1929         This patch cause 3 didferent test to fail.
1930
1931         Reverted changeset:
1932
1933         "REGRESSION(r215096) Queries of URLs with non-special schemes
1934         should not percent-encode single quotes"
1935         https://bugs.webkit.org/show_bug.cgi?id=174051
1936         http://trac.webkit.org/changeset/219024
1937
1938 2017-07-03  Chris Dumez  <cdumez@apple.com>
1939
1940         Drop ResourceLoadStatisticsStore's statisticsLock
1941         https://bugs.webkit.org/show_bug.cgi?id=174080
1942
1943         Reviewed by Brent Fulgham.
1944
1945         Port WebKitTestRunner to new Asynchronous Cocoa SPI.
1946
1947         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1948         (WTR::TestController::isStatisticsPrevalentResource):
1949         (WTR::TestController::isStatisticsHasHadUserInteraction):
1950         (WTR::TestController::isStatisticsGrandfathered):
1951
1952 2017-07-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1953
1954         Pasting single words copied to UIPasteboard inserts URLs in editable areas
1955         https://bugs.webkit.org/show_bug.cgi?id=174082
1956         <rdar://problem/33046992>
1957
1958         Reviewed by Tim Horton.
1959
1960         Adds 3 new unit tests to UIPasteboardTests to test cases of pasting plain text and URLs.
1961
1962         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1963         (TestWebKitAPI::setUpWebViewForPasteboardTests):
1964         (TestWebKitAPI::TEST):
1965
1966 2017-07-02  Brady Eidson  <beidson@apple.com>
1967
1968         Add API test for all parts of WebKit1 API related to favicons.
1969         https://bugs.webkit.org/show_bug.cgi?id=174069
1970
1971         Reviewed by Andy Estes.
1972
1973         These two API tests cover all WebKit1 API related to icons.
1974         
1975         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1976         * TestWebKitAPI/Tests/mac/WebViewIconLoading.mm: Added.
1977         (mainResourceData):
1978         (defaultFaviconData):
1979         (customFaviconData):
1980         (imageFromData):
1981         (+[IconLoadingProtocol canInitWithRequest:]):
1982         (+[IconLoadingProtocol canonicalRequestForRequest:]):
1983         (-[IconLoadingProtocol startLoading]):
1984         (-[IconLoadingProtocol stopLoading]):
1985         (-[IconLoadingFrameLoadDelegate webView:didReceiveIcon:forFrame:]):
1986         (-[MainFrameIconKVO observeValueForKeyPath:ofObject:change:context:]):
1987         (TestWebKitAPI::TEST):
1988
1989 2017-07-01  Dan Bernstein  <mitz@apple.com>
1990
1991         [iOS] Remove code only needed when building for iOS 9.x
1992         https://bugs.webkit.org/show_bug.cgi?id=174068
1993
1994         Reviewed by Tim Horton.
1995
1996         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1997         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1998         (WTR::initializeWebViewConfiguration):
1999         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2000         (-[HIDEventGenerator _createIOHIDEventType:]):
2001
2002 2017-07-01  Brady Eidson  <beidson@apple.com>
2003
2004         When setting a custom cookie storage location on a WKWebsiteDataStore, cookies aren't actually removed.
2005         <rdar://problem/32410662> and https://bugs.webkit.org/show_bug.cgi?id=174035
2006
2007         Reviewed by Alex Christensen.
2008
2009         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
2010
2011 2017-07-01  Dan Bernstein  <mitz@apple.com>
2012
2013         [macOS] Remove code only needed when building for OS X Yosemite
2014         https://bugs.webkit.org/show_bug.cgi?id=174067
2015
2016         Reviewed by Tim Horton.
2017
2018         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2019         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2020         * DumpRenderTree/mac/DumpRenderTree.mm:
2021         (setDefaultsToConsistentValuesForTesting):
2022         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
2023         (-[DumpRenderTreeDraggingInfo resetSpringLoading]):
2024         * MiniBrowser/Configurations/Base.xcconfig:
2025         * MiniBrowser/Configurations/DebugRelease.xcconfig:
2026         * TestWebKitAPI/Configurations/Base.xcconfig:
2027         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
2028         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2029         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
2030         (TestWebKitAPI::TEST_F):
2031         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:
2032         * TestWebKitAPI/Tests/mac/DragAndDropPasteboardTests.mm:
2033         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
2034         (TestWebKitAPI::TEST_F):
2035         * TestWebKitAPI/Tests/mac/StringTruncator.mm:
2036         (TestWebKitAPI::TEST):
2037         * WebKitTestRunner/Configurations/Base.xcconfig:
2038         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2039         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2040         (WTR::InjectedBundle::platformInitialize):
2041         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
2042         (-[WebKitTestRunnerDraggingInfo resetSpringLoading]):
2043
2044 2017-07-01  Chris Dumez  <cdumez@apple.com>
2045
2046         Replace ResourceLoadStatisticsStore C API with Cocoa SPI
2047         https://bugs.webkit.org/show_bug.cgi?id=174060
2048
2049         Reviewed by Brent Fulgham.
2050
2051         Port WebKitTestRunner over to the new Cocoa SPI.
2052
2053         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2054         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
2055         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
2056         Drop calls to the WKResourceLoadStatisticsStore C API here. Those were
2057         no-ops since this code runs in the WebContent process, not the
2058         UIProcess.
2059
2060         * WebKitTestRunner/TestController.cpp:
2061         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2062
2063 2017-06-30  Megan Gardner  <megan_gardner@apple.com>
2064
2065         Unreviewed mac build fix.
2066
2067         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm:
2068         (TestWebKitAPI::TEST):
2069
2070 2017-06-30  Megan Gardner  <megan_gardner@apple.com>
2071
2072         Add API to get WKActivatedElementInfo
2073         https://bugs.webkit.org/show_bug.cgi?id=174001
2074         <rdar://problem/29165518>
2075         
2076         Tests for now SPI to get activatedElementInfo.
2077
2078         Reviewed by Tim Horton.
2079
2080         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2081         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm: Added.
2082         (TestWebKitAPI::TEST):
2083
2084 2017-06-30  Chris Dumez  <cdumez@apple.com>
2085
2086         Move store logic from WebResourceLoadStatisticsManager to WebResourceLoadStatisticsStore
2087         https://bugs.webkit.org/show_bug.cgi?id=174038
2088
2089         Reviewed by Brent Fulgham.
2090
2091         Fix typo in API name.
2092
2093         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2094         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2095         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
2096         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2097         * WebKitTestRunner/TestController.cpp:
2098         (WTR::TestController::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
2099         * WebKitTestRunner/TestController.h:
2100         * WebKitTestRunner/TestInvocation.cpp:
2101         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2102
2103 2017-06-30  Alex Christensen  <achristensen@webkit.org>
2104
2105         REGRESSION(r215096) Queries of URLs with non-special schemes should not percent-encode single quotes
2106         https://bugs.webkit.org/show_bug.cgi?id=174051
2107         <rdar://problem/33002846>
2108
2109         Reviewed by Tim Horton.
2110
2111         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2112         (TestWebKitAPI::TEST_F):
2113
2114 2017-06-30  Daniel Bates  <dabates@apple.com>
2115
2116         API::FrameInfo should know the web page that contains the frame; add API property webView to WKFrameInfo
2117         https://bugs.webkit.org/show_bug.cgi?id=165160
2118         <rdar://problem/29451999>
2119
2120         Reviewed by Brady Eidson.
2121
2122         Add tests to ensure that -[WKFrameInfo webView] is computed correctly for the source and target frame
2123         for navigations and window creation.
2124
2125         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2126         * TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm: Added. Derived from file ShouldOpenExternalURLsInNewWindowActions.mm.
2127         (-[DecidePolicyForNavigationActionController webView:decidePolicyForNavigationAction:decisionHandler:]):
2128         (-[DecidePolicyForNavigationActionController webView:didFinishNavigation:]):
2129         (-[DecidePolicyForNavigationActionController webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2130         (TEST):
2131
2132 2017-06-29  Jer Noble  <jer.noble@apple.com>
2133
2134         Make Legacy EME API controlled by RuntimeEnabled setting.
2135         https://bugs.webkit.org/show_bug.cgi?id=173994
2136
2137         Reviewed by Sam Weinig.
2138
2139         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2140
2141 2017-06-30  Jonathan Bedard  <jbedard@apple.com>
2142
2143         Follow-up fix for r218996
2144
2145         Unreviewed infrastructure fix.
2146
2147         Repeated calls to 'ios_version' make the log noisy, memoize the function.
2148
2149         * Scripts/webkitpy/port/ios_simulator.py:
2150         (IOSSimulatorPort): Memoize ios_version().
2151
2152 2017-06-30  Wenson Hsieh  <wenson_hsieh@apple.com>
2153
2154         [iOS DnD] Drag caret rect is incorrectly computed when dropping in editable content in iframes
2155         https://bugs.webkit.org/show_bug.cgi?id=174017
2156         <rdar://problem/32959782>
2157
2158         Reviewed by Simon Fraser.
2159
2160         Add a new test verifying that the drag caret is visually contained within the bounds of an iframe. Before these
2161         changes, the caret would appear outside of the iframe.
2162
2163         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2164         * TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-in-iframe.html: Added.
2165         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2166         (checkDragCaretRectIsContainedInRect):
2167         (TestWebKitAPI::TEST):
2168         * TestWebKitAPI/ios/DataInteractionSimulator.h:
2169         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2170         (-[DataInteractionSimulator _resetSimulatedState]):
2171         (-[DataInteractionSimulator _concludeDataInteractionAndPerformOperationIfNecessary]):
2172         (-[DataInteractionSimulator _advanceProgress]):
2173         (-[DataInteractionSimulator lastKnownDragCaretRect]):
2174
2175 2017-06-30  Jonathan Bedard  <jbedard@apple.com>
2176
2177         Add support for different versions of iOS when loading test expectations
2178         https://bugs.webkit.org/show_bug.cgi?id=173774
2179         <rdar://problem/32951132>
2180
2181         Rubber-stamped by Aakash Jain.
2182
2183         When running layout tests, we should support multiple version of iOS the same way we do Mac.
2184
2185         * Scripts/webkitpy/port/ios.py:
2186         (IOSPort.default_baseline_search_path): Add ios-<major version> test expectation.
2187         (IOSPort.test_expectations_file_position): Added new file expectations, increment expected file position.
2188         (IOSPort.ios_version): iOS ports must define a function to retrieve the iOS version.
2189         * Scripts/webkitpy/port/ios_device.py:
2190         (IOSDevicePort.ios_version): Ask connected devices for implementation.
2191         * Scripts/webkitpy/port/ios_device_unittest.py:
2192         (IOSDeviceTest.test_additional_platform_directory): Skip test until bug 173775 is finished.
2193         (IOSDeviceTest.test_baseline_searchpath): Ditto.
2194         (IOSDeviceTest.test_expectations_ordering): Ditto.
2195         * Scripts/webkitpy/port/ios_simulator.py:
2196         (IOSSimulatorPort.ios_version): If a runtime is specified, ask the runtime for the iOS version. Otherwise,
2197         ask the platform.
2198
2199 2017-06-30  Jacobo Aragunde Pérez  <jaragunde@igalia.com>
2200
2201         Fontconfig build breaks with glibc 2.15+
2202         https://bugs.webkit.org/show_bug.cgi?id=174019
2203
2204         Reviewed by Carlos Alberto Lopez Perez.
2205
2206         Apply patch by Khem Raj adapted to fontconfig 2.11.1.
2207
2208         * wpe/jhbuild.modules:
2209         * wpe/patches/fontconfig-avoid-conflicts-with-integer-width-macros-from-TS-18.patch: Added.
2210
2211 2017-06-29  Wenson Hsieh  <wenson_hsieh@apple.com>
2212
2213         [iOS DnD] Web content process crashes when the selection is moved far offscreen in dragstart
2214         https://bugs.webkit.org/show_bug.cgi?id=174010
2215         <rdar://problem/32597802>
2216
2217         Reviewed by Tim Horton.
2218
2219         Adds a new API test to ensure that we don't crash trying to dereference a null RefPtr when the TextIndicator
2220         snapshot fails for any reason.
2221
2222         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2223         * TestWebKitAPI/Tests/WebKit2Cocoa/dragstart-change-selection-offscreen.html: Added.
2224         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2225         (TestWebKitAPI::TEST):
2226
2227 2017-06-29  Chris Fleizach  <cfleizach@apple.com>
2228
2229         AX: Cannot call setValue() on contenteditable or ARIA text controls
2230         https://bugs.webkit.org/show_bug.cgi?id=173520
2231
2232         Reviewed by Ryosuke Niwa.
2233
2234         Add setValue() method to WKTR (already existed in DRT).
2235
2236         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2237         (WTR::AccessibilityUIElement::setValue):
2238         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2239         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2240         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2241         (WTR::AccessibilityUIElement::setValue):
2242
2243 2017-06-28  Simon Fraser  <simon.fraser@apple.com>
2244
2245         getBoundingClientRect returns wrong value for combination of page zoom and scroll
2246         https://bugs.webkit.org/show_bug.cgi?id=173841
2247         rdar://problem/32983841
2248
2249         Reviewed by Dean Jackson.
2250
2251         Make "Zoom In" and "Zoom Out" work correctly in the WebKit1 window. Previously they
2252         always did text zooming.
2253
2254         * MiniBrowser/mac/WK1BrowserWindowController.m:
2255         (-[WK1BrowserWindowController zoomIn:]):
2256         (-[WK1BrowserWindowController zoomOut:]):
2257         (-[WK1BrowserWindowController canResetZoom]):
2258         (-[WK1BrowserWindowController resetZoom:]):
2259
2260 2017-06-29  John Wilander  <wilander@apple.com>
2261
2262         Fix for intermittent Layout Test fail http/tests/loading/resourceLoadStatistics/telemetry-generation.html
2263         https://bugs.webkit.org/show_bug.cgi?id=173940
2264         <rdar://problem/33018125>
2265
2266         Reviewed by Brent Fulgham.
2267
2268         This change allows the TestController to turn off
2269         regular resource load statistics telemetry submission
2270         and to manually control when telemetry is calculated
2271         and submitted.
2272
2273         * WebKitTestRunner/TestController.cpp:
2274         (WTR::TestController::initialize):
2275             Turns off automatic resource load statistics telemetry submission.
2276
2277 2017-06-29  Commit Queue  <commit-queue@webkit.org>
2278
2279         Unreviewed, rolling out r218512.
2280         https://bugs.webkit.org/show_bug.cgi?id=173981
2281
2282         "It changes the behavior of the JS API's JSEvaluateScript
2283         which breaks TurboTax" (Requested by saamyjoon on #webkit).
2284
2285         Reverted changeset:
2286
2287         "test262: Completion values for control flow do not match the
2288         spec"
2289         https://bugs.webkit.org/show_bug.cgi?id=171265
2290         http://trac.webkit.org/changeset/218512
2291
2292 2017-06-29  Jonathan Bedard  <jbedard@apple.com>
2293
2294         Add WebKitSystemInterface for iOS 11
2295         https://bugs.webkit.org/show_bug.cgi?id=173936
2296
2297         Reviewed by Lucas Forschler.
2298
2299         * Scripts/copy-webkitlibraries-to-product-directory: Copy iOS 11 WebKitSystemInterface libraries. 
2300
2301 2017-06-28  Keith Miller  <keith_miller@apple.com>
2302
2303         VMTraps has some races
2304         https://bugs.webkit.org/show_bug.cgi?id=173941
2305
2306         Reviewed by Michael Saboff.
2307
2308         Add new testing mode for testing the Watchdog with our stress
2309         tests.
2310
2311         * Scripts/run-jsc-stress-tests:
2312
2313 2017-06-29  Carlos Garcia Campos  <cgarcia@igalia.com>
2314
2315         [GTK][WPE] Implement API::IconLoadingClient and rework WebKitFaviconDatabase to use IconDatabase directly
2316         https://bugs.webkit.org/show_bug.cgi?id=173877
2317
2318         Reviewed by Brady Eidson.
2319
2320         Update favicons unit test to ensure we wait until the database is updated in testGetFavicon() before starting
2321         the next tests.
2322
2323         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
2324         (testGetFavicon):
2325
2326 2017-06-28  Tim Horton  <timothy_horton@apple.com>
2327
2328         MobileSafari was constantly using 10-15% CPU viewing a PDF
2329         https://bugs.webkit.org/show_bug.cgi?id=173944
2330         <rdar://problem/33039910>
2331
2332         Reviewed by Simon Fraser.
2333
2334         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2335         * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewStablePresentationUpdateCallback.mm:
2336         Add a test that we ever call the stable presentation update callback
2337         when we have a WKPDFView up, instead of infinitely looping.
2338
2339 2017-06-28  Alex Christensen  <achristensen@webkit.org>
2340
2341         Prevent displaying URLs with small capital letters
2342         https://bugs.webkit.org/show_bug.cgi?id=173949
2343         <rdar://problem/32952058>
2344
2345         Reviewed by Brent Fulgham.
2346
2347         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
2348         (TestWebKitAPI::TEST):
2349
2350 2017-06-28  Brent Fulgham  <bfulgham@apple.com>
2351
2352         Unreviewed test fix.
2353
2354         Disable the file monitor tests on iOS because the 'system' API is unavailable on that platform.
2355
2356         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp: 
2357
2358 2017-06-28  Brent Fulgham  <bfulgham@apple.com>
2359
2360         Teach ResourceLoadStatistics to recognize changes in the file system
2361         https://bugs.webkit.org/show_bug.cgi?id=173800
2362         <rdar://problem/32937842>
2363
2364         Reviewed by Chris Dumez.
2365
2366         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2367         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp: Added.
2368         (TestWebKitAPI::FileMonitorTest::tempFilePath):
2369         (TestWebKitAPI::handleFileModification):
2370         (TestWebKitAPI::handleFileDeletion):
2371         (TestWebKitAPI::resetTestState):
2372         (TestWebKitAPI::TEST_F):
2373
2374 2017-06-28  Brady Eidson  <beidson@apple.com>
2375
2376         DocumentLoader should always notify the client if there are pending icon loads when the load is stopped.
2377         https://bugs.webkit.org/show_bug.cgi?id=173874
2378
2379         Reviewed by Alex Christensen.
2380
2381         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm:
2382
2383 2017-06-28  Don Olmstead  <don.olmstead@sony.com>
2384
2385         Unreviewed, adding Don Olmstead to contributors.json
2386
2387         * Scripts/webkitpy/common/config/contributors.json:
2388
2389 2017-06-28  Alex Christensen  <achristensen@webkit.org>
2390
2391         WebsitePolicies given with navigation policy for redirects should apply to the provisional document
2392         https://bugs.webkit.org/show_bug.cgi?id=173886
2393         <rdar://problem/32543191>
2394
2395         Reviewed by Andy Estes.
2396
2397         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2398         (ParsedRange::ParsedRange):
2399         (-[TestSchemeHandler initWithVideoData:]):
2400         (-[TestSchemeHandler webView:startURLSchemeTask:]):
2401         (-[TestSchemeHandler webView:stopURLSchemeTask:]):
2402         (TEST):
2403
2404 2017-06-27  JF Bastien  <jfbastien@apple.com>
2405
2406         WebAssembly: running out of executable memory should throw OoM
2407         https://bugs.webkit.org/show_bug.cgi?id=171537
2408         <rdar://problem/32963338>
2409
2410         Reviewed by Saam Barati.
2411
2412         * Scripts/run-jsc-stress-tests: add a configuration which runs the
2413         tests under limited executable memory and avoids non-WebAssembly
2414         code generation so that we more reliably run out of executable
2415         memory in WebAssembly.
2416
2417 2017-06-27  Wenson Hsieh  <wenson_hsieh@apple.com>
2418
2419         [iOS DnD] Support dragging out of contenteditable areas without a prior selection
2420         https://bugs.webkit.org/show_bug.cgi?id=173854
2421         <rdar://problem/32236827>
2422
2423         Reviewed by Ryosuke Niwa and Tim Horton.
2424
2425         Adds a new test to check that an image can be dragged out of a contenteditable and dropped.
2426
2427         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2428         * TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-and-target.html: Added.
2429         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2430         (TestWebKitAPI::TEST):
2431
2432 2017-06-27  Don Olmstead  <don.olmstead@sony.com>
2433
2434         [PAL] Add symbol export macros for PAL
2435         https://bugs.webkit.org/show_bug.cgi?id=171519
2436
2437         Reviewed by Konstantin Tokarev.
2438
2439         * DumpRenderTree/config.h:
2440         * TestWebKitAPI/CMakeLists.txt:
2441         * TestWebKitAPI/config.h:
2442         * WebKitTestRunner/config.h:
2443
2444 2017-06-27  John Wilander  <wilander@apple.com>
2445
2446         Resource Load Statistics: Add telemetry
2447         https://bugs.webkit.org/show_bug.cgi?id=173499
2448         <rdar://problem/32826094>
2449
2450         Reviewed by Brent Fulgham.
2451
2452         Adds three new testRunner functions:
2453         - installStatisticsDidRunTelemetryCallback()
2454         - statisticsFireTelemetryHandler()
2455         - setStatisticsNotifyPagesWhenTelemetryWasCaptured()
2456
2457         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2458         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2459         (WTR::InjectedBundle::didReceiveMessageToPage):
2460         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2461         (WTR::TestRunner::installStatisticsDidRunTelemetryCallback):
2462         (WTR::TestRunner::statisticsDidRunTelemetryCallback):
2463         (WTR::TestRunner::statisticsFireTelemetryHandler):
2464         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
2465         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2466         * WebKitTestRunner/TestController.cpp:
2467         (WTR::TestController::resetStateToConsistentValues):
2468         (WTR::TestController::statisticsFireTelemetryHandler):
2469         (WTR::TestController::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
2470         * WebKitTestRunner/TestController.h:
2471         * WebKitTestRunner/TestInvocation.cpp:
2472         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2473
2474 2017-06-27  Ting-Wei Lan  <lantw44@gmail.com>
2475
2476         Add missing includes to fix compilation error on FreeBSD
2477         https://bugs.webkit.org/show_bug.cgi?id=172919
2478
2479         Reviewed by Mark Lam.
2480
2481         * ImageDiff/cairo/PlatformImageCairo.cpp:
2482
2483 2017-06-26  Jonathan Bedard  <jbedard@apple.com>
2484
2485         Unreviewed, rolling out r218783.
2486
2487         Causing accessibility/mac/setting-attributes-is-
2488         asynchronous.html to crash consistently on mac-wk2 Debug
2489
2490         Reverted changeset:
2491
2492         "AX: Cannot call setValue() on contenteditable or ARIA text
2493         controls"
2494         https://bugs.webkit.org/show_bug.cgi?id=173520
2495         http://trac.webkit.org/changeset/218783
2496
2497 2017-06-26  Yusuke Suzuki  <utatane.tea@gmail.com>
2498
2499         [WTF] Drop Thread::create(obsolete things) API since we can use lambda
2500         https://bugs.webkit.org/show_bug.cgi?id=173825
2501
2502         Reviewed by Saam Barati.
2503
2504         * DumpRenderTree/JavaScriptThreading.cpp:
2505         (runJavaScriptThread):
2506         (startJavaScriptThreads):
2507         * DumpRenderTree/mac/DumpRenderTree.mm:
2508         (runThread):
2509         (runPthread):
2510         (testThreadIdentifierMap):
2511
2512 2017-06-26  David Kilzer  <ddkilzer@apple.com>
2513
2514         [TestWebKitAPI] Fix false-positive bad release warnings found by clang static analyzer
2515         <https://webkit.org/b/173837>
2516
2517         Reviewed by Geoffrey Garen.
2518
2519         The clang static analyzer can't reason about objects that are
2520         assigned to a delegate as +1 retained, and then released
2521         later in a different method when the delegate is cleared.
2522
2523         Instead, use a common idiom where the object setting the
2524         delegate retains it as an instance variable on initialization.
2525         Then the same object clears the delegate and releases its
2526         instance variable during teardown.
2527
2528         Also add EXPECT_TRUE() tests to make sure the delegate objects
2529         match before teardown.
2530
2531         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
2532         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
2533         (TestWebKitAPI::FullscreenZoomInitialFrame::teardownView):
2534         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
2535         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::initializeView):
2536         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::teardownView):
2537
2538 2017-06-26  David Kilzer  <ddkilzer@apple.com>
2539
2540         [TestWebKitAPI] REGRESSION (r218750): Fix leak of NSURLResponse in WKURLSchemeHandler-1.mm
2541         <https://webkit.org/b/173836>
2542
2543         Reviewed by Brady Eidson.
2544
2545         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
2546         (-[RedirectSchemeHandler webView:startURLSchemeTask:]): Use
2547         adoptNS() to fix the leak.  Also use auto/adoptNS() for other
2548         objects in this test.
2549
2550 2017-06-26  Joanmarie Diggs  <jdiggs@igalia.com>
2551
2552         [ATK] Add support for aria-details and aria-errormessage
2553         https://bugs.webkit.org/show_bug.cgi?id=172588
2554
2555         Reviewed by Chris Fleizach.
2556
2557         Add additional methods to test ARIA properties which are exposed via
2558         AtkRelation. Also bump minimum versions of at-spi2-core and at-spi2-atk
2559         to versions which support the details and error-message relation types.
2560
2561         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2562         (WTR::AccessibilityUIElement::ariaDetailsElementAtIndex):
2563         (WTR::AccessibilityUIElement::ariaDetailsReferencingElementAtIndex):
2564         (WTR::AccessibilityUIElement::ariaErrorMessageElementAtIndex):
2565         (WTR::AccessibilityUIElement::ariaErrorMessageReferencingElementAtIndex):
2566         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2567         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2568         (WTR::AccessibilityUIElement::ariaDetailsElementAtIndex):
2569         (WTR::AccessibilityUIElement::ariaDetailsReferencingElementAtIndex):
2570         (WTR::AccessibilityUIElement::ariaErrorMessageElementAtIndex):
2571         (WTR::AccessibilityUIElement::ariaErrorMessageReferencingElementAtIndex):
2572         * gtk/jhbuild.modules:
2573
2574 2017-06-26  Carlos Garcia Campos  <cgarcia@igalia.com>
2575
2576         Unreviewed. Add libfii to GTK+ install dependencies script.
2577
2578         * gtk/install-dependencies:
2579
2580 2017-06-25  Michael Catanzaro  <mcatanzaro@igalia.com>
2581
2582         Unreviewed, rolling out r215190.
2583
2584         Broke product select element on GNOME Bugzilla
2585
2586         Reverted changeset:
2587
2588         "[GTK] Misplaced right click menu on web page due to
2589         deprecated gtk_menu_popup()"
2590         https://bugs.webkit.org/show_bug.cgi?id=170553
2591         http://trac.webkit.org/changeset/215190
2592
2593 2017-06-24  Joseph Pecoraro  <pecoraro@apple.com>
2594
2595         Remove Reflect.enumerate
2596         https://bugs.webkit.org/show_bug.cgi?id=173806
2597
2598         Reviewed by Yusuke Suzuki.
2599
2600         * Scripts/run-jsc-stress-tests:
2601
2602 2017-06-24  Chris Fleizach  <cfleizach@apple.com>
2603
2604         AX: Cannot call setValue() on contenteditable or ARIA text controls
2605         https://bugs.webkit.org/show_bug.cgi?id=173520
2606
2607         Reviewed by Ryosuke Niwa.
2608
2609         Add setValue() method to WKTR (already existed in DRT).
2610
2611         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2612         (WTR::AccessibilityUIElement::setValue):
2613         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2614         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2615         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2616         (WTR::AccessibilityUIElement::setValue):
2617
2618 2017-06-23  Keith Miller  <keith_miller@apple.com>
2619
2620         Switch VMTraps to use halt instructions rather than breakpoint instructions
2621         https://bugs.webkit.org/show_bug.cgi?id=173677
2622
2623         Reviewed by JF Bastien.
2624
2625         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
2626         (TEST):
2627
2628 2017-06-23  Youenn Fablet  <youenn@apple.com>
2629
2630         Set getUserMedia permission to true by default on WTR
2631         https://bugs.webkit.org/show_bug.cgi?id=173610
2632
2633         Reviewed by Alex Christensen.
2634
2635         Adding a way to reset the getUserMedia permission to pending.
2636
2637         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2638         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2639         (WTR::InjectedBundle::setUserMediaPermissionAsUnset):
2640         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2641         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2642         (WTR::TestRunner::setUserMediaPermissionAsUnset):
2643         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2644         * WebKitTestRunner/TestController.cpp:
2645         (WTR::TestController::resetStateToConsistentValues):
2646         (WTR::TestController::setUserMediaPermissionAsUnset):
2647         * WebKitTestRunner/TestController.h:
2648         * WebKitTestRunner/TestInvocation.cpp:
2649         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2650
2651 2017-06-23  Alex Christensen  <achristensen@webkit.org>
2652
2653         Add SPI to WKURLSchemeTask for redirection
2654         https://bugs.webkit.org/show_bug.cgi?id=173730
2655
2656         Reviewed by Brady Eidson.
2657
2658         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
2659         (-[SchemeHandler webView:startURLSchemeTask:]):
2660         (-[SchemeHandler webView:stopURLSchemeTask:]):
2661         (TEST):
2662         (-[RedirectSchemeHandler webView:startURLSchemeTask:]):
2663         (-[RedirectSchemeHandler webView:stopURLSchemeTask:]):
2664         (-[RedirectSchemeHandler webView:didReceiveServerRedirectForProvisionalNavigation:]):
2665         (-[RedirectSchemeHandler webView:decidePolicyForNavigationResponse:decisionHandler:]):
2666         (-[RedirectSchemeHandler userContentController:didReceiveScriptMessage:]):
2667
2668 2017-06-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2669
2670         [WPE] Use JSC API to send script messages from web extension in tests
2671         https://bugs.webkit.org/show_bug.cgi?id=173757
2672
2673         Reviewed by Žan Doberšek.
2674
2675         The GTK+ uses DOM bindings to send the messages. We can just build the message string and use JSEvaluateScript
2676         to run postMessage().
2677
2678         Fixes: /wpe/WebKitSecurityManager/file-xhr
2679                /wpe/WebKitConsoleMessage/console-api
2680                /wpe/WebKitConsoleMessage/js-exception
2681                /wpe/WebKitConsoleMessage/network-error
2682                /wpe/WebKitConsoleMessage/security-error
2683
2684         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
2685         (testWebKitConsoleMessageSecurityError): Remove ifdefs.
2686         (beforeAll): Ditto.
2687         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
2688         (testWebContextSecurityFileXHR): Ditto.
2689         (beforeAll): Ditto.
2690         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
2691         (consoleMessageSentCallback): Use JSEvaluateScript in WPE. We need to escape the '"' in the message string.
2692         (pageCreatedCallback): Remove ifdefs.
2693
2694 2017-06-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2695
2696         Unreviewed. Fix WPE /wpe/WebKitWebView/javascript-dialogs and /wpe/WebKitWebView/window-properties
2697
2698         Skip onbeforeunload dialog tests for now in WPE since we don't have a implemention for
2699         simulateUserInteraction(). And do not expect changes in "geometry" property of WebKitWindowProperties that
2700         doesn't exist yet in WPE.
2701
2702         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2703         (testWebViewJavaScriptDialogs):
2704         (testWebViewWindowProperties):
2705
2706 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2707
2708         [GTK] Upgrade pixman and cairo in jhbuild
2709         https://bugs.webkit.org/show_bug.cgi?id=173710
2710
2711         Reviewed by Carlos Alberto Lopez Perez.
2712
2713         * gtk/jhbuild.modules:
2714
2715 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2716
2717         REGRESSION(r218686): [GTK] Several unit tests are failing after r218686 in the bots
2718         https://bugs.webkit.org/show_bug.cgi?id=173711
2719
2720         Reviewed by Carlos Alberto Lopez Perez.
2721
2722         I can't reproduce it locally, but it's complaining about a g_setenv() and I only added one in r218686 to recover
2723         the XDG_RUNTIME_DIR, because it's required by Wayland to work. So, I guess that env var is not set in the bots.
2724
2725         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
2726         (WebKitTestBus::run): Ensure value is not nullptr before calling g_setenv().
2727
2728 2017-06-22  David Kilzer  <ddkilzer@apple.com>
2729
2730         REGRESSION (r218419): 7 leaks in PluginLoadClientPolicies.mm
2731         <https://webkit.org/b/173721>
2732
2733         Reviewed by Joseph Pecoraro.
2734
2735         Use RetainPtr<> to create NSMutableDictionary and NSNumber
2736         objects to fix leaks and to avoid the autoreleasepool.
2737
2738         * TestWebKitAPI/Tests/WebKit2Cocoa/PluginLoadClientPolicies.mm:
2739         (TEST):
2740
2741 2017-06-22  Matt Lewis  <jlewis3@apple.com>
2742
2743         Unreviewed, rolling out r218633.
2744
2745         The test is failing frequently on Sierra Debug and Windows
2746
2747         Reverted changeset:
2748
2749         "AX: Cannot call setValue() on contenteditable or ARIA text
2750         controls"
2751         https://bugs.webkit.org/show_bug.cgi?id=173520
2752         http://trac.webkit.org/changeset/218633
2753
2754 2017-06-22  David Kilzer  <ddkilzer@apple.com>
2755
2756         [TestWebKitAPI] Fix misuse of -[NSData dataWithBytesNoCopy:length:] with global variables
2757         <https://webkit.org/b/173690>
2758
2759         Reviewed by Chris Dumez.
2760
2761         Per documentation, -[NSData dataWithBytesNoCopy:length:] takes
2762         ownership of malloc()-ed memory, then frees it when it's
2763         released.  These tests were passing global variables into the
2764         method, which is not malloc()-ed memory, which violates the API
2765         contract.
2766
2767         The fix is to switch to use
2768         -[NSData dataWithBytesNoCopy:length:freeWhenDone:] and to pass
2769         NO for the last argument.
2770
2771         Caught by the clang static analyzer.
2772
2773         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm:
2774         (TEST):
2775         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
2776         (TEST):
2777
2778 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2779
2780         [GTK] Upgrade Harfbuzz to version 1.4.2
2781         https://bugs.webkit.org/show_bug.cgi?id=173592
2782
2783         Reviewed by Carlos Alberto Lopez Perez.
2784
2785         * gtk/jhbuild.modules:
2786
2787 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2788
2789         [WPE] Update WPEBackend-mesa
2790         https://bugs.webkit.org/show_bug.cgi?id=173705
2791
2792         Reviewed by Carlos Alberto Lopez Perez.
2793
2794         A crash has been fixed, needed for unit tests to work.
2795
2796         * wpe/jhbuild.modules:
2797
2798 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2799
2800         Remove unused coordinated graphics C API
2801         https://bugs.webkit.org/show_bug.cgi?id=173706
2802
2803         Reviewed by Žan Doberšek.
2804
2805         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp: Removed.
2806         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive_Bundle.cpp: Removed.
2807         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewRestoreZoomAndScrollBackForward.cpp: Removed.
2808         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp: Removed.
2809         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward1.html: Removed.
2810         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward2.html: Removed.
2811
2812 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2813
2814         [WPE] Build glib API tests
2815         https://bugs.webkit.org/show_bug.cgi?id=173702
2816
2817         Reviewed by Žan Doberšek.
2818
2819         Many of the tests pass without problems, others need to be investigated, and some others are known issues. The
2820         main difference between the GTK+ and WPE WebKitWebView is that in GTK+ it's a GtkWidget, so initially
2821         unowned. The tests assume that webkit_web_view_new methods return a floating reference. This patch adds
2822         Test::adoptView() method that returns a GRefPtr<WebKitWebView> with a different implementation in GTK+ and
2823         WPE. In the case of GTK+, it sinks the floating reference, while in WPE it simply adopts the reference. Another
2824         difference is that in GTK+ the web view is initially hidden and needs to be added to a window to make it
2825         visible. Also, some tests need the web view to be realized to work, and others need that the view is added to a
2826         toplevel window, instead of a popup window. All those things are not needed at all in WPE. I've added several
2827         #ifdefs with FIXME comments for the things that we know don't work in WPE yet, for example, because we haven't
2828         implemented the methods to send events to the web view. Those will be removed eventually when we fix the issues
2829         and implement the missing features.
2830
2831         * CMakeLists.txt:
2832         * TestWebKitAPI/Tests/WebKit2Gtk/EditorTest.cpp:
2833         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
2834         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
2835         (testAutomationSessionRequestSession):
2836         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp:
2837         (testWebKitWebViewSessionState):
2838         (testWebKitWebViewSessionStateWithFormData):
2839         (testWebKitWebViewNavigationAfterSessionRestore):
2840         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
2841         (beforeAll):
2842         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
2843         (testCookieManagerEphemeral):
2844         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
2845         (testBlobDownload):
2846         (beforeAll):
2847         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
2848         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2849         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
2850         (testProcessPerWebView):
2851         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
2852         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2853         (testWebViewCreateNavigationData):
2854         (testWebViewJavaScriptDialogs):
2855         (testWebViewWindowProperties):
2856         (testWebViewMouseTarget):
2857         (testWebViewGeolocationPermissionRequests):
2858         (testWebViewUserMediaPermissionRequests):
2859         (testWebViewAudioOnlyUserMediaPermissionRequests):
2860         (testWebViewFileChooserRequest):
2861         (beforeAll):
2862         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
2863         (beforeAll):
2864         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
2865         (testPrivateBrowsing):
2866         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp:
2867         (testFindControllerHide):
2868         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp:
2869         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2870         (testWebKitSettings):
2871         (beforeAll):
2872         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
2873         (testWebViewNewWithUserContentManager):
2874         (beforeAll):
2875         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
2876         (testWebContextEphemeral):
2877         (testWebContextProxySettings):
2878         (beforeAll):
2879         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
2880         (testWebViewWebContext):
2881         (testWebViewWebContextLifetime):
2882         (testWebViewEphemeral):
2883         (testWebViewSettings):
2884         (testWebViewCanShowMIMEType):
2885         (testWebViewPageVisibility):
2886         (testWebViewIsPlayingAudio):
2887         (beforeAll):
2888         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
2889         (testWebsiteDataEphemeral):
2890         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
2891         (documentLoadedCallback):
2892         (pageCreatedCallback):
2893         (methodCallCallback):
2894         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h:
2895         * TestWebKitAPI/glib/CMakeLists.txt:
2896         * TestWebKitAPI/glib/PlatformGTK.cmake:
2897         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
2898         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
2899         (main):
2900         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2901         (Test::adoptView):
2902         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
2903         (WebKitTestBus::run):
2904         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
2905         (WebViewTest::~WebViewTest):
2906         (WebViewTest::initializeWebView):
2907         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h:
2908         * TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp: Added.
2909         (WebViewTest::platformDestroy):
2910         (WebViewTest::platformInitializeWebView):
2911         (WebViewTest::quitMainLoopAfterProcessingPendingEvents):
2912         (WebViewTest::resizeView):
2913         (WebViewTest::hideView):
2914         (parentWindowMapped):
2915         (WebViewTest::showInWindow):
2916         (WebViewTest::showInWindowAndWaitUntilMapped):
2917         (WebViewTest::mouseMoveTo):
2918         (WebViewTest::clickMouseButton):
2919         (WebViewTest::emitPopupMenuSignal):
2920         (WebViewTest::keyStroke):
2921         (WebViewTest::doMouseButtonEvent):
2922         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp: Copied from Tools/TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h.
2923         (WebViewTest::platformDestroy):
2924         (WebViewTest::platformInitializeWebView):
2925         (WebViewTest::quitMainLoopAfterProcessingPendingEvents):
2926         (WebViewTest::resizeView):
2927         (WebViewTest::hideView):
2928         (WebViewTest::mouseMoveTo):
2929         (WebViewTest::clickMouseButton):
2930         (WebViewTest::keyStroke):
2931
2932 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2933
2934         [GTK] Move WebKit2 GLib API tests to glib directories
2935         https://bugs.webkit.org/show_bug.cgi?id=173642
2936
2937         Reviewed by Žan Doberšek.
2938
2939         * CMakeLists.txt:
2940         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Removed.
2941         * TestWebKitAPI/Tests/WebKit2Gtk/resources/webkit2gtk-tests.gresource.xml: Removed.
2942         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp.
2943         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp.
2944         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestAutomationSession.cpp.
2945         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp.
2946         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp.
2947         (testWebKitConsoleMessageNetworkError):
2948         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp.
2949         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp.
2950         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp.
2951         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp.
2952         (testLoadFromGResource):
2953         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp.
2954         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp.
2955         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp.
2956         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp.
2957         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp.
2958         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp.
2959         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFindController.cpp.
2960         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitPolicyClient.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitPolicyClient.cpp.
2961         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSecurityOrigin.cpp.
2962         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp.
2963         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp.
2964         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp.
2965         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp.
2966         (testWebViewRunJavaScript):
2967         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp.
2968         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp.
2969         (registerGResource):
2970         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp.
2971         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h.
2972         * TestWebKitAPI/Tests/WebKitGLib/resources/blank.ico: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/blank.ico.
2973         * TestWebKitAPI/Tests/WebKitGLib/resources/boring.html: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/boring.html.
2974         * TestWebKitAPI/Tests/WebKitGLib/resources/link-title.js: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/link-title.js.
2975         * TestWebKitAPI/Tests/WebKitGLib/resources/silence.mpg: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/silence.mpg.
2976         * TestWebKitAPI/Tests/WebKitGLib/resources/simple.json: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/simple.json.
2977         * TestWebKitAPI/Tests/WebKitGLib/resources/test-cert.pem: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/test-cert.pem.
2978         * TestWebKitAPI/Tests/WebKitGLib/resources/test-key.pem: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/test-key.pem.
2979         * TestWebKitAPI/Tests/WebKitGLib/resources/test.pdf: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/test.pdf.
2980         * TestWebKitAPI/Tests/WebKitGLib/resources/track.ogg: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/track.ogg.
2981         * TestWebKitAPI/Tests/WebKitGLib/resources/webkitglib-tests.gresource.xml: Added.
2982         * TestWebKitAPI/glib/CMakeLists.txt: Added.
2983         * TestWebKitAPI/glib/PlatformGTK.cmake: Added.
2984         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp.
2985         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h.
2986         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/TestMain.cpp.
2987         (registerGResource):
2988         * TestWebKitAPI/glib/WebKitGLib/TestMain.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h.
2989         (Test::getResourcesDir):
2990         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.cpp.
2991         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.h.
2992         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp.
2993         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.h.
2994         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp.
2995         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h.
2996
2997 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2998
2999         [WPE] Add initial web extensions API
3000         https://bugs.webkit.org/show_bug.cgi?id=173640
3001
3002         Reviewed by Žan Doberšek.
3003
3004         Add style checker exceptions for WPE web extensions API files.
3005
3006         * Scripts/webkitpy/style/checker.py:
3007
3008 2017-06-21  Wenson Hsieh  <wenson_hsieh@apple.com>
3009
3010         [iOS DnD] [WK2] Cancelling a drag interaction using the ObjC SPI causes subsequent dragging to fail
3011         https://bugs.webkit.org/show_bug.cgi?id=173659
3012         <rdar://problem/32879788>
3013
3014         Reviewed by Tim Horton.
3015
3016         Adds a new test to verify that a lift cancelled within the UI process does not cause subsequent dragging to fail.
3017
3018         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-target-div.html:
3019
3020         Augment this test page to log dragend and dragstart events on the drag source as well.
3021
3022         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3023         (checkStringArraysAreEqual):
3024         (TestWebKitAPI::TEST):
3025
3026 2017-06-21  Antoine Quint  <graouts@apple.com>
3027
3028         Ensure DRT always logs rAF suspension debugging code
3029         https://bugs.webkit.org/show_bug.cgi?id=173681
3030
3031         Reviewed by Tim "Mr. T" Horton.
3032
3033         * DumpRenderTree/mac/DumpRenderTree.mm:
3034         (resetWebPreferencesToConsistentValues):
3035
3036 2017-06-21  Chris Dumez  <cdumez@apple.com>
3037
3038         Allow constructing a WTF:Function from a function pointer
3039         https://bugs.webkit.org/show_bug.cgi?id=173660
3040
3041         Reviewed by Alex Christensen.
3042
3043         Add API test coverage.
3044
3045         * TestWebKitAPI/Tests/WTF/Function.cpp:
3046         (TestWebKitAPI::returnThree):
3047         (TestWebKitAPI::returnFour):
3048         (TestWebKitAPI::returnPassedValue):
3049         (TestWebKitAPI::TEST):
3050
3051 2017-06-21  Antoine Quint  <graouts@apple.com>
3052
3053         Add logging to identify when the Page suspends scripted animations
3054         https://bugs.webkit.org/show_bug.cgi?id=173626
3055
3056         Reviewed by Tim Horton.
3057
3058         Turn the new logging on for WK1/DRT since the issue we're trying to pinpoint only occurs on WK1 bots.
3059
3060         * DumpRenderTree/mac/DumpRenderTree.mm:
3061         (resetWebPreferencesToConsistentValues):
3062
3063 2017-06-21  Chris Fleizach  <cfleizach@apple.com>
3064
3065         AX: Cannot call setValue() on contenteditable or ARIA text controls
3066         https://bugs.webkit.org/show_bug.cgi?id=173520
3067
3068         Reviewed by Ryosuke Niwa.
3069
3070         Add setValue() method to WKTR (already existed in DRT).
3071
3072         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3073         (WTR::AccessibilityUIElement::setValue):
3074         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3075         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3076         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3077         (WTR::AccessibilityUIElement::setValue):
3078
3079 2017-06-21  Zan Dobersek  <zdobersek@igalia.com>
3080
3081         List libtasn1 packages in GTK+ and WPE install-dependencies scripts
3082         as one of the dependencies required to build the product.
3083
3084         Rubber-stamped by Carlos Garcia Campos.
3085
3086         * gtk/install-dependencies:
3087         * wpe/install-dependencies:
3088
3089 2017-06-20  Myles C. Maxfield  <mmaxfield@apple.com>
3090
3091         Disable font variations on macOS Sierra and iOS 10
3092         https://bugs.webkit.org/show_bug.cgi?id=173618
3093         <rdar://problem/32879164>
3094
3095         Reviewed by Jon Lee.
3096
3097         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3098
3099 2017-06-20  Wenson Hsieh  <wenson_hsieh@apple.com>
3100
3101         [iOS DnD] [WK2] Remove custom logic for disambiguating long press action sheet gestures and drag lift
3102         https://bugs.webkit.org/show_bug.cgi?id=173578
3103         <rdar://problem/32825028>
3104
3105         Reviewed by Tim Horton.
3106
3107         Slight tweak to ensure that DataInteractionTests.CustomActionSheetPopover still passes and verifies that showing
3108         a custom popover does not cause dragging to fail when the popover is presented.
3109
3110         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
3111         (-[DataInteractionSimulator _advanceProgress]):
3112
3113 2017-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
3114
3115         [WPE] Add initial implementation of glib API
3116         https://bugs.webkit.org/show_bug.cgi?id=173546
3117
3118         Reviewed by Žan Doberšek.
3119
3120         Disable geolocation because WPE doesn't implement any provider and update the style checker exceptions to
3121         include WPE glib API files.
3122
3123         * Scripts/webkitperl/FeatureList.pm:
3124         * Scripts/webkitpy/style/checker.py:
3125         * Scripts/webkitpy/style/checkers/cpp.py:
3126         (check_identifier_name_in_declaration):
3127
3128 2017-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
3129
3130         [GTK] Upgrade to ICU to version 57.1
3131         https://bugs.webkit.org/show_bug.cgi?id=173538
3132
3133         Reviewed by Žan Doberšek.
3134
3135         * gtk/jhbuild.modules:
3136
3137 2017-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
3138
3139         [GTK] Remove unneeded modules from the jhbuild
3140         https://bugs.webkit.org/show_bug.cgi?id=170540
3141
3142         Reviewed by Michael Catanzaro.
3143
3144         We are building libxslt and libffi that we don't really need to build from sources.
3145
3146         * gtk/jhbuild.modules:
3147
3148 2017-06-19  Frederic Wang  <fwang@igalia.com>
3149
3150         [Mac] Add an experimental feature setting for async frame scrolling
3151         https://bugs.webkit.org/show_bug.cgi?id=173359
3152
3153         Reviewed by Simon Fraser.
3154
3155         * DumpRenderTree/mac/DumpRenderTree.mm:
3156         (enableExperimentalFeatures): Do not enable async frame scrolling for now.
3157         (resetWebPreferencesToConsistentValues): Disable async frame scrolling by default.
3158         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3159         (WTR::InjectedBundle::beginTesting): Initalize to async frame scrolling to false.
3160
3161 2017-06-19  Guillaume Emont  <guijemont@igalia.com>
3162
3163         Unreviewed, adding myself to contributors.json
3164
3165         * Scripts/webkitpy/common/config/contributors.json:
3166
3167 2017-06-19  Joseph Pecoraro  <pecoraro@apple.com>
3168
3169         test262: Completion values for control flow do not match the spec
3170         https://bugs.webkit.org/show_bug.cgi?id=171265
3171
3172         Reviewed by Saam Barati.
3173
3174         * Scripts/run-jsc-stress-tests:
3175         Include a :failDueToOutdatedOrBadTest to mark failures with justification.
3176
3177 2017-06-19  Zalan Bujtas  <zalan@apple.com>
3178
3179         Opening certain mails brings up a mail that grows indefinitely.
3180         https://bugs.webkit.org/show_bug.cgi?id=173562
3181         <rdar://problem/32766579>
3182
3183         Reviewed by Tim Horton.
3184
3185         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
3186         (TEST):
3187
3188 2017-06-19  Wenson Hsieh  <wenson_hsieh@apple.com>
3189
3190         [iOS DnD] Support .zip archives for file uploads via drag and drop
3191         https://bugs.webkit.org/show_bug.cgi?id=173511
3192         <rdar://problem/32521025>
3193
3194         Reviewed by Tim Horton.
3195
3196         Adds tests for dropping .zip archives into a JavaScript-based file upload area, as well as into a file input.
3197         Also verifies that URLs are not handled as file drops. See WebCore ChangeLog for more details.
3198
3199         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3200         * TestWebKitAPI/Tests/WebKit2Cocoa/compressed-files.zip: Added.
3201         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3202         (testZIPArchive):
3203         (TestWebKitAPI::TEST):
3204
3205 2017-06-18  Darin Adler  <darin@apple.com>
3206
3207         Fix Ref to deref before assignment, add tests for this to RefPtr, Ref, Function
3208         https://bugs.webkit.org/show_bug.cgi?id=173526
3209
3210         Reviewed by Sam Weinig.
3211
3212         * TestWebKitAPI/CMakeLists.txt: Added Function.cpp.
3213         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
3214
3215         * TestWebKitAPI/Tests/WTF/Function.cpp: Added. Contains basic tests and some
3216         tests for assignment before destruction ones.
3217
3218         * TestWebKitAPI/Tests/WTF/MoveOnly.h: Added a () operator so this can be used
3219         as a function, so it can be used in WTF::Function tests.
3220
3221         * TestWebKitAPI/Tests/WTF/Ref.cpp: Use EXPECT macros insead of ASSERT.
3222         Added tests for swap and for assignment before deref.
3223
3224         * TestWebKitAPI/Tests/WTF/RefLogger.cpp: Stopped using inlining; no good reason
3225         to inline everything. Also removed the unnecessary clearing of the log every time
3226         the DerivedRefLogger constructor is called.
3227         * TestWebKitAPI/Tests/WTF/RefLogger.h: Ditto.
3228
3229         * TestWebKitAPI/Tests/WTF/RefPtr.cpp: Use EXPECT macros instead of ASSERT.
3230         Added tests for assignment before deref and similar for releaseNonNull.
3231
3232 2017-06-19  Sam Weinig  <sam@webkit.org>
3233
3234         [WebIDL] Properly model buffer source / typed arrays as their own IDL types
3235         https://bugs.webkit.org/show_bug.cgi?id=173513
3236
3237         Reviewed by Alex Christensen.
3238
3239         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
3240         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
3241         Replace IsNonPointerType subroutine with IsPrimitiveType so we can remove IsNonPointerType.
3242
3243 2017-06-19  Per Arne Vollan  <pvollan@apple.com>
3244
3245         [Win] fast/dom/assign-to-window-status.html is flaky.
3246         https://bugs.webkit.org/show_bug.cgi?id=173512
3247
3248         Reviewed by Alex Christensen.
3249
3250         We should not dump status callbacks when test is done.
3251
3252         * DumpRenderTree/win/UIDelegate.cpp:
3253         (UIDelegate::setStatusText):
3254
3255 2017-06-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3256
3257         [WPE][JHBuild] Update WPEBackend-mesa
3258         https://bugs.webkit.org/show_bug.cgi?id=173433
3259
3260         Unreviewed.
3261
3262         Update WPEBackend-mesa back (like it was done originally in r218344)
3263         after fixing the issue with the DISPLAY environment variables that
3264         caused the crashes.
3265
3266         * wpe/jhbuild.modules:
3267
3268 2017-06-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3269
3270         Rename unit test file after r218482
3271         https://bugs.webkit.org/show_bug.cgi?id=173483
3272
3273         Unreviewed.
3274
3275         * Scripts/webkitpy/port/waylanddriver_unittest.py: Renamed from Tools/Scripts/webkitpy/port/wayland_unittest.py.
3276
3277 2017-06-19  Carlos Garcia Campos  <cgarcia@igalia.com>
3278
3279         Unreviewed. Fix wrong style checker condition added in r218487.
3280
3281         * Scripts/webkitpy/style/checkers/cpp.py:
3282         (check_identifier_name_in_declaration):
3283
3284 2017-06-19  Adrian Perez de Castro  <aperez@igalia.com>
3285
3286         Missing <functional> includes make builds fail with GCC 7.x
3287         https://bugs.webkit.org/show_bug.cgi?id=173544
3288
3289         Unreviewed gardening.
3290
3291         Fix compilation with GCC 7.
3292
3293         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
3294         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
3295
3296 2017-06-19  Carlos Garcia Campos  <cgarcia@igalia.com>
3297
3298         [GTK] Move GTK+ API files that could be shared to glib dirs
3299         https://bugs.webkit.org/show_bug.cgi?id=173545
3300
3301         Reviewed by Žan Doberšek.
3302
3303         Update paths of GTK+ API in watchlist and style checker.
3304
3305         * Scripts/webkitpy/common/config/watchlist:
3306         * Scripts/webkitpy/style/checker.py:
3307         * Scripts/webkitpy/style/checkers/cpp.py:
3308         (check_identifier_name_in_declaration):
3309
3310 2017-06-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3311
3312         Port setup_environ_for_server should not set environment variables related with the driver.
3313         https://bugs.webkit.org/show_bug.cgi?id=173483
3314
3315         Reviewed by Carlos Garcia Campos.
3316
3317         The port setup_environ_for_server() should not set environment variables
3318         that depend on the type of driver (like DISPLAY or GDK_BACKEND).
3319         This varibles should be only set on the driver setup_environ_for_test().
3320
3321         This causes that (for example) the variable DISPLAY or XAUTHORITY leaks
3322         into the test environment even when running the tests with a driver
3323         that is not the Xorg or Xvfb one.
3324
3325         * Scripts/webkitpy/port/base.py: Stop setting XAUTHORITY and DISPLAY here.
3326         (Port.to.setup_environ_for_server):
3327         * Scripts/webkitpy/port/driver.py: Remove unneded WEBKIT_OUTPUTDIR that is already set on base.py
3328         (Driver._setup_environ_for_driver):
3329         * Scripts/webkitpy/port/driver_unittest.py:
3330         (DriverTest.test_setup_environ_for_test):
3331         (DriverTest):
3332         (DriverTest.test_setup_environ_base_vars):
3333         * Scripts/webkitpy/port/gtk.py: Stop setting GDK_BACKEND here and do that on the driver (Xvfb).
3334         (GtkPort.setup_environ_for_server):
3335         * Scripts/webkitpy/port/wayland_unittest.py: Added.
3336         (WaylandDriverTest):
3337         (WaylandDriverTest.make_driver):
3338         (WaylandDriverTest.make_environment):
3339         (WaylandDriverTest.test_checkdriver):
3340         (WaylandDriverTest.test_environment_needed_variables):
3341         (WaylandDriverTest.test_environment_forbidden_variables):
3342         (WaylandDriverTest.test_environment_optional_variables):
3343         * Scripts/webkitpy/port/waylanddriver.py: Allow the driver to run also with WAYLAND_SOCKET.
3344         (WaylandDriver.check_driver):
3345         (WaylandDriver._setup_environ_for_test):
3346         * Scripts/webkitpy/port/xorgdriver.py:
3347         (XorgDriver.check_driver):
3348         (XorgDriver._setup_environ_for_test):
3349         * Scripts/webkitpy/port/xorgdriver_unittest.py: Added.
3350         (XorgDriverTest):
3351         (XorgDriverTest.make_driver):
3352         (XorgDriverTest.make_environment):
3353         (XorgDriverTest.test_checkdriver):
3354         (XorgDriverTest.test_environment_needed_variables):
3355         (XorgDriverTest.test_environment_forbidden_variables):
3356         (XorgDriverTest.test_environment_optional_variables):
3357         * Scripts/webkitpy/port/xvfbdriver.py:
3358         (XvfbDriver._setup_environ_for_test):
3359         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
3360         (XvfbDriverTest.assertDriverStartSuccessful):
3361
3362
3363 2017-05-14 Frederic Wang  <fwang@igalia.com>
3364
3365         Add heuristic to avoid flattening "fullscreen" iframes
3366         https://bugs.webkit.org/show_bug.cgi?id=171914
3367
3368         Reviewed by Simon Fraser.
3369
3370         * DumpRenderTree/mac/DumpRenderTree.mm:
3371         (resetWebPreferencesToConsistentValues): Use WebKitFrameFlatteningDisabled.
3372
3373 2017-06-18  Chris Dumez  <cdumez@apple.com>
3374
3375         Crash when re-entering MediaDevicesEnumerationRequest::cancel()
3376         https://bugs.webkit.org/show_bug.cgi?id=173522
3377         <rdar://problem/31185739>
3378
3379         Reviewed by Darin Adler.
3380
3381         Add API test for re-entering Function's assignment operators.
3382
3383         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3384         * TestWebKitAPI/Tests/WTF/Function.cpp: Added.
3385         (TestWebKitAPI::TestObject::TestObject):
3386         (TestWebKitAPI::TestObject::~TestObject):
3387         (TestWebKitAPI::TestObject::operator()):
3388         (TestWebKitAPI::TEST):
3389
3390 2017-06-16  Dan Bernstein  <mitz@apple.com>
3391
3392         [Cocoa] Some declarations have missing or incorrect availability attributes
3393         https://bugs.webkit.org/show_bug.cgi?id=173508
3394
3395         Reviewed by Tim Horton.
3396
3397         * TestWebKitAPI/Tests/ios/PositionInformationTests.mm:
3398         (TestWebKitAPI::TEST): Updated for renames.
3399
3400 2017-06-16  Wenson Hsieh  <wenson_hsieh@apple.com>
3401
3402         [iOS DnD] Upstream iOS drag and drop implementation into OpenSource WebKit
3403         https://bugs.webkit.org/show_bug.cgi?id=173366
3404         <rdar://problem/32767014>
3405
3406         Reviewed by Tim Horton.
3407
3408         Move test pages and pieces of DataInteractionSimulator hidden behind WebKitAdditions into TestWebKitAPI. No
3409         change in behavior.
3410
3411         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3412         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3413         * TestWebKitAPI/Tests/WebKit2Cocoa/autofocus-contenteditable.html: Added.
3414         * TestWebKitAPI/Tests/WebKit2Cocoa/background-image-link-and-input.html: Added.
3415         * TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-and-textarea.html: Added.
3416         * TestWebKitAPI/Tests/WebKit2Cocoa/div-and-large-image.html: Added.
3417         * TestWebKitAPI/Tests/WebKit2Cocoa/file-uploading.html: Added.
3418         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-contenteditable.html: Added.
3419         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-textarea.html: Added.
3420         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-input.html: Added.
3421         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-target-div.html: Added.
3422         * TestWebKitAPI/Tests/WebKit2Cocoa/prevent-operation.html: Added.
3423         * TestWebKitAPI/Tests/WebKit2Cocoa/prevent-start.html: Added.
3424         * TestWebKitAPI/Tests/WebKit2Cocoa/textarea-to-input.html: Added.
3425         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
3426         (-[MockDragDropSession initWithItems:location:window:]):
3427         (-[MockDragDropSession allowsMoveOperation]):
3428         (-[MockDragDropSession isRestrictedToDraggingApplication]):
3429         (-[MockDragDropSession hasItemsConformingToTypeIdentifiers:]):
3430         (-[MockDragDropSession canLoadObjectsOfClass:]):
3431         (-[MockDragDropSession canLoadObjectsOfClasses:]):
3432         (-[MockDragDropSession items]):
3433         (-[MockDragDropSession setItems:]):
3434         (-[MockDragDropSession locationInView:]):
3435         (-[MockDataOperationSession initWithProviders:location:window:]):
3436         (-[MockDataOperationSession session]):
3437         (-[MockDataOperationSession isLocal]):
3438         (-[MockDataOperationSession progress]):
3439         (-[MockDataOperationSession setProgressIndicatorStyle:]):
3440         (-[MockDataOperationSession progressIndicatorStyle]):
3441         (-[MockDataOperationSession operationMask]):
3442         (-[MockDataOperationSession localDragSession]):
3443         (-[MockDataOperationSession hasItemsConformingToTypeIdentifier:]):
3444         (-[MockDataOperationSession canCreateItemsOfClass:]):
3445         (-[MockDataOperationSession loadObjectsOfClass:completion:]):
3446         (-[MockDataInteractionSession initWithWindow:]):
3447         (-[MockDataInteractionSession localOperationMask]):
3448         (-[MockDataInteractionSession externalOperationMask]):
3449         (-[MockDataInteractionSession session]):
3450         (-[DataInteractionSimulator _advanceProgress]):
3451
3452 2017-06-16  Alex Christensen  <achristensen@webkit.org>
3453
3454         Show punycode to user if a URL has dotless i or j followed by diacritic dot
3455         https://bugs.webkit.org/show_bug.cgi?id=173431
3456
3457         Reviewed by Darin Adler.
3458
3459         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
3460         (TestWebKitAPI::TEST):
3461
3462 2017-06-16  Chris Dumez  <cdumez@apple.com>
3463
3464         [WK2] Add WKProcessPool SPI to efficiently reset all plugin load client policies
3465         https://bugs.webkit.org/show_bug.cgi?id=173472
3466         <rdar://problem/28858817>
3467
3468         Reviewed by Brady Eidson.
3469
3470         Add API test coverage.
3471
3472         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3473         * TestWebKitAPI/Tests/WebKit2Cocoa/PluginLoadClientPolicies.mm: Added.
3474         (TEST):
3475
3476 2017-06-16  Brady Eidson  <beidson@apple.com>
3477
3478         REGRESSION (r218015) IconLoaders for already-cached resources expect to be asynchronous, no longer are.
3479         <rdar://problem/32817519> and https://bugs.webkit.org/show_bug.cgi?id=173478
3480
3481         Reviewed by Daniel Bates.
3482
3483         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm:
3484
3485 2017-06-16  Chris Dumez  <cdumez@apple.com>
3486
3487         DRT fails to reset page visibility between tests
3488         https://bugs.webkit.org/show_bug.cgi?id=173485
3489
3490         Reviewed by Alexey Proskuryakov.
3491
3492         DRT fails to reset page visibility between tests and relies on tests calling testRunner.resetPageVisibility().
3493         Fix this to address flakiness.
3494
3495         I confirmed this by commenting out the call to testRunner.resetPageVisibility() in
3496         fast/events/page-visibility-onvisibilitychange.html and running the test in a loop.
3497         The test became flaky without the DRT change and was no longer flaky with the DRT
3498         change.
3499
3500         WebKitTestRunner already does this.
3501
3502         * DumpRenderTree/mac/DumpRenderTree.mm:
3503         (resetWebViewToConsistentStateBeforeTesting):
3504
3505 2017-06-16  Alex Christensen  <achristensen@webkit.org>
3506
3507         Implement basic authentication in MiniBrowser
3508         https://bugs.webkit.org/show_bug.cgi?id=173443
3509
3510         Reviewed by Tim Horton.
3511
3512         * MiniBrowser/mac/WK2BrowserWindowController.m:
3513         (-[WK2BrowserWindowController webView:didReceiveAuthenticationChallenge:completionHandler:]):
3514
3515 2017-06-16  Jer Noble  <jer.noble@apple.com>
3516
3517         [WebRTC] Removing a MediaStreamTrack from a MediaStream reports no recording to WebKit clients
3518         https://bugs.webkit.org/show_bug.cgi?id=173398
3519         <rdar://problem/32592961>
3520
3521         Reviewed by Eric Carlson.
3522
3523         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3524         * TestWebKitAPI/Tests/WebKit2/MediaStreamTrackDetached.mm: Added.
3525         (-[MediaStreamTrackDetachedUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
3526         (-[MediaStreamTrackDetachedUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
3527         (-[MediaStreamTrackDetachedUIDelegate _webView:mediaCaptureStateDidChange:]):
3528         (TestWebKitAPI::TEST):
3529         * TestWebKitAPI/Tests/WebKit2/mediastreamtrack-detached.html: Added.
3530
3531 2017-06-16  Matt Lewis  <jlewis3@apple.com>
3532
3533         Unreviewed, rolling out r218375.
3534
3535         The API test MediaStreamTrackDetached is still timing out
3536         after the patch
3537
3538         Reverted changeset:
3539
3540         "[WebRTC] Removing a MediaStreamTrack from a MediaStream
3541         reports no recording to WebKit clients"
3542         https://bugs.webkit.org/show_bug.cgi?id=173398
3543         http://trac.webkit.org/changeset/218375
3544
3545 2017-06-15  Jer Noble  <jer.noble@apple.com>
3546
3547         [WebRTC] Removing a MediaStreamTrack from a MediaStream reports no recording to WebKit clients
3548         https://bugs.webkit.org/show_bug.cgi?id=173398
3549         <rdar://problem/32592961>
3550
3551         Reviewed by Eric Carlson.
3552
3553         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3554         * TestWebKitAPI/Tests/WebKit2/MediaStreamTrackDetached.mm: Added.
3555         (-[MediaStreamTrackDetachedUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
3556         (-[MediaStreamTrackDetachedUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
3557         (-[MediaStreamTrackDetachedUIDelegate _webView:mediaCaptureStateDidChange:]):
3558         (TestWebKitAPI::TEST):
3559         * TestWebKitAPI/Tests/WebKit2/mediastreamtrack-detached.html: Added.
3560
3561 2017-06-15  Matt Lewis  <jlewis3@apple.com>
3562
3563         Unreviewed, rolling out r218365.
3564
3565         The revision caused API timeouts on all builds.
3566
3567         Reverted changeset:
3568
3569         "[WebRTC] Removing a MediaStreamTrack from a MediaStream
3570         reports no recording to WebKit clients"
3571         https://bugs.webkit.org/show_bug.cgi?id=173398
3572         http://trac.webkit.org/changeset/218365
3573
3574 2017-06-15  Jer Noble  <jer.noble@apple.com>
3575
3576         [WebRTC] Removing a MediaStreamTrack from a MediaStream reports no recording to WebKit clients
3577         https://bugs.webkit.org/show_bug.cgi?id=173398
3578         <rdar://problem/32592961>
3579
3580         Reviewed by Eric Carlson.
3581
3582         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3583         * TestWebKitAPI/Tests/WebKit2/MediaStreamTrackDetached.mm: Added.
3584         (-[MediaStreamTrackDetachedUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
3585         (-[MediaStreamTrackDetachedUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
3586         (-[MediaStreamTrackDetachedUIDelegate _webView:mediaCaptureStateDidChange:]):
3587         (TestWebKitAPI::TEST):
3588         * TestWebKitAPI/Tests/WebKit2/mediastreamtrack-detached.html: Added.
3589
3590 2017-06-15  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3591
3592         REGRESSION(r218344): [WPE] Thousands of layout test crashes
3593         https://bugs.webkit.org/show_bug.cgi?id=173433
3594
3595         Unreviewed.
3596
3597         * wpe/jhbuild.modules: Revert the update of WPEBackend-mesa.
3598
3599 2017-06-15  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3600
3601         [WPE] The run-minibrowser script should allow to execute also a WPE launcher
3602         https://bugs.webkit.org/show_bug.cgi?id=173061
3603
3604         Reviewed by Žan Doberšek.
3605
3606         Launch dyz <https://github.com/Igalia/dyz> with the script
3607         run-minibrowser for the wpe port. It is now built as part of the
3608         WPE dependencies with JHBuild.
3609
3610         * Scripts/run-minibrowser:
3611         * Scripts/webkitdirs.pm:
3612         (launcherPath):
3613         (launcherName):
3614         * wpe/install-dependencies: Luajit is needed for building dyz.