[EFL] Add Web Inspector to EWebLauncher
[WebKit-https.git] / Tools / ChangeLog
1 2012-10-07  Seokju Kwon  <seokju.kwon@samsung.com>
2
3         [EFL] Add Web Inspector to EWebLauncher
4         https://bugs.webkit.org/show_bug.cgi?id=91718
5
6         Reviewed by Gyuyoung Kim.
7
8         Implementation of Web Inspector in EWebLauncher.
9         The Web Inspector can be opened or closed by pressing ctrl+i on web page.
10
11         * EWebLauncher/main.c:
12         (on_browser_ecore_evas_resize):
13         (on_web_inspector_ecore_evas_resize):
14         (on_key_down):
15         (on_web_inspector_view_create):
16         (on_web_inspector_view_close):
17         (on_web_inspector_view_destroyed):
18         (browserCreate):
19         (webInspectorCreate):
20         (windowCreate):
21         (closeWindow):
22         (main_signal_exit):
23         (parseUserArguments):
24
25 2012-10-07  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
26
27         Rename first/second to key/value in HashMap iterators
28         https://bugs.webkit.org/show_bug.cgi?id=82784
29
30         Reviewed by Eric Seidel.
31
32         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
33         (MockWebSpeechInputController::addMockRecognitionResult):
34         * DumpRenderTree/chromium/NotificationPresenter.cpp:
35         (NotificationPresenter::simulateClick):
36         (NotificationPresenter::show):
37         * DumpRenderTree/chromium/TestRunner/CppBoundClass.cpp:
38         (CppBoundClass::~CppBoundClass):
39         (CppBoundClass::invoke):
40         (CppBoundClass::getProperty):
41         (CppBoundClass::setProperty):
42         (CppBoundClass::bindCallback):
43         (CppBoundClass::bindProperty):
44         * DumpRenderTree/chromium/WebPreferences.cpp:
45         (applyFontMap):
46         * DumpRenderTree/chromium/WebViewHost.cpp:
47         (WebViewHost::printResourceDescription):
48         * DumpRenderTree/mac/TestRunnerMac.mm:
49         (worldIDForWorld):
50         (TestRunner::evaluateScriptInIsolatedWorld):
51         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
52         (AccessibilityController::~AccessibilityController):
53         (AccessibilityController::winNotificationReceived):
54         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
55         (ResourceLoadDelegate::descriptionSuitableForTestResult):
56         * DumpRenderTree/win/TestRunnerWin.cpp:
57         (worldIDForWorld):
58         (TestRunner::evaluateScriptInIsolatedWorld):
59         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
60         (TestWebKitAPI::DOMWindowExtensionBasic::willDestroyPage):
61         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
62         (TestWebKitAPI::DOMWindowExtensionNoCache::willDestroyPage):
63         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
64         (WTR::TestRunner::worldIDForWorld):
65         (WTR::TestRunner::evaluateScriptInIsolatedWorld):
66
67 2012-10-07  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
68
69         Unreviewed, rolling out r130596.
70         http://trac.webkit.org/changeset/130596
71         https://bugs.webkit.org/show_bug.cgi?id=98616
72
73         Broke build bots without IPV6 support
74
75         * Scripts/webkitpy/common/system/platforminfo_mock.py:
76         (MockPlatformInfo.is_cygwin):
77         * Scripts/webkitpy/layout_tests/port/base.py:
78         (Port.baseline_version_dir):
79         (Port.to.start_websocket_server):
80         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
81         (PortTest.test_operating_system):
82         (PortTest.test_build_path):
83         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
84         (LayoutTestApacheHttpd):
85         (LayoutTestApacheHttpd.__init__):
86
87 2012-10-07  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
88
89         webkitpy: Pass the `Listen' Apache directive from Apache, not the httpd.conf files.
90         https://bugs.webkit.org/show_bug.cgi?id=98602
91
92         Reviewed by Eric Seidel.
93
94         Unify all the different `Listen' directives present in the several
95         httpd.conf files we have in LayoutTests/http/conf. For one, we
96         were already passing `Listen 127.0.0.1:8000' via webkitpy before,
97         and opening the other ports from the conf files.
98
99         The configuration files differed mostly in the way they handled
100         IPV6 ports. Some of them did not listen to IPV6 ports because the
101         systems which used them sometimes did not have IPV6 support. The
102         `http_server_supports_ipv6' method has been added to Port to
103         address that. cygwin, on its turn, still seems to use Apache 1.3,
104         which does not support IPV6 at all; the newly-added method has a
105         special case for that.
106
107         * Scripts/webkitpy/common/system/platforminfo_mock.py:
108         (MockPlatformInfo.is_cygwin):
109         * Scripts/webkitpy/layout_tests/port/base.py:
110         (Port.baseline_version_dir):
111         (Port.to.start_websocket_server):
112         (Port.to):
113         (Port.to.http_server_supports_ipv6):
114         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
115         (PortTest.test_http_server_supports_ipv6):
116         (PortTest.test_build_path):
117         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
118         (LayoutTestApacheHttpd):
119         (LayoutTestApacheHttpd.__init__):
120
121 2012-10-05  Simon Fraser  <simon.fraser@apple.com>
122
123         Attempt to fix the SnowLeopard build to making the implementation of
124         -isPaginated come before its use.
125
126         * MiniBrowser/mac/WK1BrowserWindowController.m:
127         (-[WK1BrowserWindowController reload:]):
128         (-[WK1BrowserWindowController forceRepaint:]):
129         (-[WK1BrowserWindowController goBack:]):
130         (-[WK1BrowserWindowController goForward:]):
131         (-[WK1BrowserWindowController isPaginated]):
132
133 2012-10-05  Simon Fraser  <simon.fraser@apple.com>
134
135         Provide a way to run WebKit1
136         https://bugs.webkit.org/show_bug.cgi?id=98568
137
138         Reviewed by Tim Horton.
139
140         Make it possible to create both WebKit1 and WebKit2 windows in MiniBrowser.
141         
142         Turn BrowserWindowController into a base class; subclassed by
143         WK1BrowserWindowController and WK2BrowserWindowController, each of
144         which implement the BrowserController protocol.
145         
146         Use Command-N to get a WebKit1 window, and Command-Option-N to
147         get a WK2 window. Also add "Open Location" to focus the URL bar,
148         and code to add an http:// if missing.
149         
150         Hook up window title callbacks; append " [WK1/2]" to window title
151         as appropriate.
152
153         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
154         * MiniBrowser/mac/AppDelegate.m:
155         (-[BrowserAppDelegate newWindow:]):
156         (-[BrowserAppDelegate openPanelDidEnd:returnCode:contextInfo:]):
157         * MiniBrowser/mac/BrowserWindowController.h:
158         * MiniBrowser/mac/BrowserWindowController.m:
159         (-[BrowserWindowController initWithWindow:]):
160         (-[BrowserWindowController windowDidLoad]):
161         (-[BrowserWindowController openLocation:]):
162         (-[BrowserWindowController loadURLString:]):
163         (-[BrowserWindowController applicationTerminating]):
164         (-[BrowserWindowController addProtocolIfNecessary:]):
165         * MiniBrowser/mac/MainMenu.xib:
166         * MiniBrowser/mac/WK1BrowserWindowController.h: Copied from Tools/MiniBrowser/mac/BrowserWindowController.h.
167         (WebView):
168         * MiniBrowser/mac/WK1BrowserWindowController.m: Added.
169         (-[WK1BrowserWindowController awakeFromNib]):
170         (-[WK1BrowserWindowController dealloc]):
171         (-[WK1BrowserWindowController loadURLString:]):
172         (-[WK1BrowserWindowController fetch:]):
173         (-[WK1BrowserWindowController showHideWebView:]):
174         (-[WK1BrowserWindowController removeReinsertWebView:]):
175         (-[WK1BrowserWindowController validateMenuItem:]):
176         (-[WK1BrowserWindowController reload:]):
177         (-[WK1BrowserWindowController forceRepaint:]):
178         (-[WK1BrowserWindowController goBack:]):
179         (-[WK1BrowserWindowController goForward:]):
180         (-[WK1BrowserWindowController validateUserInterfaceItem:]):
181         (-[WK1BrowserWindowController validateToolbar]):
182         (-[WK1BrowserWindowController windowShouldClose:]):
183         (-[WK1BrowserWindowController windowWillClose:]):
184         (-[WK1BrowserWindowController applicationTerminating]):
185         (-[WK1BrowserWindowController currentZoomFactor]):
186         (-[WK1BrowserWindowController canZoomIn]):
187         (-[WK1BrowserWindowController zoomIn:]):
188         (-[WK1BrowserWindowController canZoomOut]):
189         (-[WK1BrowserWindowController zoomOut:]):
190         (-[WK1BrowserWindowController canResetZoom]):
191         (-[WK1BrowserWindowController resetZoom:]):
192         (-[WK1BrowserWindowController toggleZoomMode:]):
193         (-[WK1BrowserWindowController isPaginated]):
194         (-[WK1BrowserWindowController togglePaginationMode:]):
195         (-[WK1BrowserWindowController find:]):
196         (-[WK1BrowserWindowController dumpSourceToConsole:]):
197         (-[WK1BrowserWindowController webView:didStartProvisionalLoadForFrame:]):
198         (-[WK1BrowserWindowController webView:didReceiveTitle:forFrame:]):
199         * MiniBrowser/mac/WK2BrowserWindowController.h: Copied from Tools/MiniBrowser/mac/BrowserWindowController.h.
200         * MiniBrowser/mac/WK2BrowserWindowController.m: Copied from Tools/MiniBrowser/mac/BrowserWindowController.m.
201         (-[WK2BrowserWindowController initWithContext:pageGroup:]):
202         (-[WK2BrowserWindowController dealloc]):
203         (-[WK2BrowserWindowController fetch:]):
204         (-[WK2BrowserWindowController showHideWebView:]):
205         (-[WK2BrowserWindowController removeReinsertWebView:]):
206         (-[WK2BrowserWindowController validateMenuItem:]):
207         (-[WK2BrowserWindowController reload:]):
208         (-[WK2BrowserWindowController forceRepaint:]):
209         (-[WK2BrowserWindowController goBack:]):
210         (-[WK2BrowserWindowController goForward:]):
211         (-[WK2BrowserWindowController validateUserInterfaceItem:]):
212         (-[WK2BrowserWindowController validateToolbar]):
213         (-[WK2BrowserWindowController windowShouldClose:]):
214         (-[WK2BrowserWindowController windowWillClose:]):
215         (-[WK2BrowserWindowController applicationTerminating]):
216         (-[WK2BrowserWindowController currentZoomFactor]):
217         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
218         (-[WK2BrowserWindowController canZoomIn]):
219         (-[WK2BrowserWindowController zoomIn:]):
220         (-[WK2BrowserWindowController canZoomOut]):
221         (-[WK2BrowserWindowController zoomOut:]):
222         (-[WK2BrowserWindowController canResetZoom]):
223         (-[WK2BrowserWindowController resetZoom:]):
224         (-[WK2BrowserWindowController toggleZoomMode:]):
225         (-[WK2BrowserWindowController isPaginated]):
226         (-[WK2BrowserWindowController togglePaginationMode:]):
227         (-[WK2BrowserWindowController dumpSourceToConsole:]):
228         (didStartProvisionalLoadForFrame):
229         (didReceiveServerRedirectForProvisionalLoadForFrame):
230         (didFailProvisionalLoadWithErrorForFrame):
231         (didCommitLoadForFrame):
232         (didFinishDocumentLoadForFrame):
233         (didFinishLoadForFrame):
234         (didFailLoadWithErrorForFrame):
235         (didSameDocumentNavigationForFrame):
236         (didReceiveTitleForFrame):
237         (didFirstLayoutForFrame):
238         (didFirstVisuallyNonEmptyLayoutForFrame):
239         (didRemoveFrameFromHierarchy):
240         (didDisplayInsecureContentForFrame):
241         (didRunInsecureContentForFrame):
242         (didDetectXSSForFrame):
243         (didStartProgress):
244         (didChangeProgress):
245         (didFinishProgress):
246         (didBecomeUnresponsive):
247         (didBecomeResponsive):
248         (processDidExit):
249         (didChangeBackForwardList):
250         (decidePolicyForNavigationAction):
251         (decidePolicyForNewWindowAction):
252         (decidePolicyForResponse):
253         (createNewPage):
254         (showPage):
255         (closePage):
256         (runJavaScriptAlert):
257         (runJavaScriptConfirm):
258         (runJavaScriptPrompt):
259         (setStatusText):
260         (mouseDidMoveOverElement):
261         (getWindowFrame):
262         (setWindowFrame):
263         (runBeforeUnloadConfirmPanel):
264         (runOpenPanel):
265         (-[WK2BrowserWindowController awakeFromNib]):
266         (-[WK2BrowserWindowController didStartProgress]):
267         (-[WK2BrowserWindowController didChangeProgress:]):
268         (-[WK2BrowserWindowController didFinishProgress]):
269         (-[WK2BrowserWindowController updateProvisionalURLForFrame:]):
270         (-[WK2BrowserWindowController didStartProvisionalLoadForFrame:]):
271         (-[WK2BrowserWindowController didReceiveServerRedirectForProvisionalLoadForFrame:]):
272         (-[WK2BrowserWindowController didFailProvisionalLoadWithErrorForFrame:]):
273         (-[WK2BrowserWindowController didFailLoadWithErrorForFrame:]):
274         (-[WK2BrowserWindowController didSameDocumentNavigationForFrame:]):
275         (-[WK2BrowserWindowController didCommitLoadForFrame:]):
276         (-[WK2BrowserWindowController loadURLString:]):
277         (-[WK2BrowserWindowController performFindPanelAction:]):
278         (-[WK2BrowserWindowController find:]):
279
280 2012-10-05  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
281
282         [WK2][WTR] WebKitTestRunner needs testRunner.setSerializeHTTPLoads
283         https://bugs.webkit.org/show_bug.cgi?id=98524
284
285         Reviewed by Alexey Proskuryakov.
286
287         Add implementation for testRunner.setSerializeHTTPLoads in
288         WebKitTestRunner.
289
290         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
291         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
292         (WTR::InjectedBundle::beginTesting):
293         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
294         (WTR::TestRunner::setSerializeHTTPLoads):
295         (WTR):
296         * WebKitTestRunner/InjectedBundle/TestRunner.h:
297         (TestRunner):
298
299 2012-10-05  Richard Larocque  <rlarocque@chromium.org>
300
301         TestResultsServer does not display sync_integration_tests results
302         https://bugs.webkit.org/show_bug.cgi?id=98551
303
304         Reviewed by Ojan Vafai.
305
306         Allow builders whose name contains "Sync" to pass through the
307         isChromiumWebkitDepsTestRunner filter.
308
309         The test expectations in flakiness_dashboard_unittests.js have been
310         updated to match the new behaviour.
311
312         * TestResultServer/static-dashboards/builders.js:
313         (isChromiumDepsGTestRunner):
314
315 2012-10-05  Roger Fong  <roger_fong@apple.com>
316
317         Tests in webkitpy involving child processes are flaky. 
318         Skipping run_webkit_tests_integrationtest.py.
319         https://bugs.webkit.org/show_bug.cgi?id=98559
320
321         Reviewed by Dirk Pranke.
322
323         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
324         (MainTest.test_verbose_in_child_processes):
325
326 2012-10-05  Zan Dobersek  <zandobersek@gmail.com>
327
328         [Gtk] fast/xsl/xslt-missing-namespace-in-xslt.xml is failing on the 64-bit Debug builder
329         https://bugs.webkit.org/show_bug.cgi?id=91009
330
331         Reviewed by Martin Robinson.
332
333         Include libxml2 into the jhbuild module. Version 2.8.0 introduces
334         a more correct (but not completely correct) behavior in the
335         fast/xsl/xslt-missing-namespace-in-xslt.html test.
336
337         * gtk/jhbuild.modules:
338
339 2012-10-05  Rob Buis  <rbuis@rim.com>
340
341         [BlackBerry] Implement TestRunner.setMockDeviceOrientation
342         https://bugs.webkit.org/show_bug.cgi?id=98542
343
344         Reviewed by Antonio Gomes.
345
346         PR 120681
347
348         This fixes tests in fast/dom/DeviceOrientation.
349
350         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
351         (TestRunner::setMockDeviceOrientation):
352
353 2012-10-05  Christophe Dumez  <christophe.dumez@intel.com>
354
355         [WK2][WKTR] Implement UIClient focus callbacks in WebKitTestRunner
356         https://bugs.webkit.org/show_bug.cgi?id=98256
357
358         Reviewed by Kenneth Rohde Christiansen.
359
360         Implement UIClient's focus callbacks for the main page in
361         WebKitTestRunner.
362
363         * WebKitTestRunner/TestController.cpp:
364         (WTR::focus):
365         (WTR::TestController::initialize):
366
367 2012-10-05  Mark Hahnenberg  <mhahnenberg@apple.com>
368
369         JSC should have a way to gather and log Heap memory use and pause times
370         https://bugs.webkit.org/show_bug.cgi?id=98431
371
372         Reviewed by Geoffrey Garen.
373
374         * DumpRenderTree/mac/DumpRenderTree.mm:
375         (main): Added a check as to whether we should dump our JSC Heap statistics on exit.
376
377 2012-10-05  Christophe Dumez  <christophe.dumez@intel.com>
378
379         [EFL][WK2] Fix mktemp() compilation warning in Minibrowser
380         https://bugs.webkit.org/show_bug.cgi?id=98493
381
382         Reviewed by Kenneth Rohde Christiansen.
383
384         Fix wrong mktemp usage causing a compilation warning
385         in MiniBrowser.
386
387         * MiniBrowser/efl/main.c:
388         (on_download_request):
389
390 2012-10-05  Christophe Dumez  <christophe.dumez@intel.com>
391
392         [WK2][WKTR] Avoid duplication of UIClient callbacks for main page and other pages
393         https://bugs.webkit.org/show_bug.cgi?id=98503
394
395         Reviewed by Kenneth Rohde Christiansen.
396
397         Avoid the need for duplicating UIClient callbacks for main page
398         and other pages by passing the view as clientInfo
399         for those callbacks.
400
401         Previously, callbacks for the main page were passed the
402         TestController as clientInfo while the callbacks for other pages
403         were passed the PlatformWebView as clientInfo. This was error prone
404         and leads to useless code duplication.
405
406         * WebKitTestRunner/TestController.cpp:
407         (WTR::getWindowFrame):
408         (WTR::setWindowFrame):
409         (WTR::runBeforeUnloadConfirmPanel):
410         (WTR::TestController::createOtherPage):
411         (WTR::TestController::initialize):
412         (WTR::TestController::decidePolicyForNotificationPermissionRequest):
413
414 2012-10-05  Sadrul Habib Chowdhury  <sadrul@chromium.org>
415
416         [chromium] Allow dragging into plugins.
417         https://bugs.webkit.org/show_bug.cgi?id=98277
418
419         Reviewed by Tony Chang.
420
421         Update the TestWebPlugin to receive drag events and print them out.
422
423         * DumpRenderTree/chromium/TestWebPlugin.cpp:
424         (TestWebPlugin::handleDragStatusUpdate):
425         * DumpRenderTree/chromium/TestWebPlugin.h:
426         (TestWebPlugin):
427
428 2012-10-05  Jongseok Yang  <js45.yang@samsung.com>
429
430         [EFL][WK2] Remove "web" word from ewk_web_error APIs
431         https://bugs.webkit.org/show_bug.cgi?id=97886
432
433         Reviewed by Gyuyoung Kim.
434
435         Remove "web" word from ewk_web_error APIs.
436         "web" word was redundant because "ewk" means "EFL WebKit" and WK APIs for error does not have "web" word.
437
438         * MiniBrowser/efl/main.c:
439         (on_error):
440
441 2012-10-05  Csaba Osztrogonác  <ossy@webkit.org>
442
443         [Qt] Enable CSS compositing by default
444         https://bugs.webkit.org/show_bug.cgi?id=98490
445
446         Reviewed by Simon Hausmann.
447
448         * qmake/mkspecs/features/features.pri:
449
450 2012-10-05  Sheriff Bot  <webkit.review.bot@gmail.com>
451
452         Unreviewed, rolling out r130466.
453         http://trac.webkit.org/changeset/130466
454         https://bugs.webkit.org/show_bug.cgi?id=98495
455
456         It made 12 tests crash on Qt-WK2 (Requested by Ossy on
457         #webkit).
458
459         * WebKitTestRunner/TestController.cpp:
460         (WTR::focus):
461         (WTR::TestController::initialize):
462
463 2012-10-05  Christophe Dumez  <christophe.dumez@intel.com>
464
465         [EFL] Fix window resizing / moving in WK1 and WKTR
466         https://bugs.webkit.org/show_bug.cgi?id=98486
467
468         Reviewed by Gyuyoung Kim.
469
470         Fix PlatformWebView::windowFrame() and
471         PlatformWebView::setWindowFrame() in EFL's WKTR so
472         that it resizes / moves the window, not the view.
473
474         The new code matches the implementation in EwkView's
475         UIClient.
476
477         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
478         (WTR::PlatformWebView::windowFrame):
479         (WTR::PlatformWebView::setWindowFrame):
480
481 2012-10-04  KyungTae Kim  <ktf.kim@samsung.com>
482
483         [EFL][WK2] Fix destination path when download with suggested filename on the Minibrowser
484         https://bugs.webkit.org/show_bug.cgi?id=98334
485
486         Reviewed by Gyuyoung Kim.
487
488         Add callback functions for download requests to Minibrowser to set the destination path for download.
489         Set the destination path with suggested file name as (destination folder) + (suggested file name).
490         The 'destination folder' should be a specific folder user selected, but is set to '/tmp' for now.
491
492         Additionally, for printing out the download status, 
493         use the info macro and set the verbose variable to 1 to enable it.
494
495         * MiniBrowser/efl/main.c:
496         (on_download_request):
497         (on_download_finished):
498         (on_download_failed):
499         (browserCreate):
500
501 2012-10-04  Christophe Dumez  <christophe.dumez@intel.com>
502
503         [WK2][WKTR] Implement UIClient focus callbacks in WebKitTestRunner
504         https://bugs.webkit.org/show_bug.cgi?id=98256
505
506         Reviewed by Kenneth Rohde Christiansen.
507
508         Implement UIClient's focus callbacks in WebKitTestRunner.
509
510         * WebKitTestRunner/TestController.cpp:
511         (WTR::focus):
512         (WTR::TestController::initialize):
513
514 2012-10-04  Rik Cabanier  <cabanier@adobe.com>
515
516         Turn Compositing on by default in WebKit build
517         https://bugs.webkit.org/show_bug.cgi?id=98315
518
519         Reviewed by Simon Fraser.
520
521         enable -webkit-blend-mode on trunk.
522
523         * Scripts/webkitperl/FeatureList.pm:
524
525 2012-10-04  Ryuan Choi  <ryuan.choi@samsung.com>
526
527         [EFL][WK2] Add APIs to get/set the frame flattening.
528         https://bugs.webkit.org/show_bug.cgi?id=95982
529
530         Reviewed by Gyuyoung Kim.
531
532         * MiniBrowser/efl/main.c: Added frame flattening option to test.
533         (browserCreate):
534         (main):
535
536 2012-10-04  Christophe Dumez  <christophe.dumez@intel.com>
537
538         [EFL] Add libxml 2.8.0 to jhbuild
539         https://bugs.webkit.org/show_bug.cgi?id=98418
540
541         Reviewed by Laszlo Gombos.
542
543         Add libxml 2.8.0 to EFL's jhbuild for consistency.
544
545         * efl/jhbuild.modules:
546
547 2012-10-03  Benjamin Poulain  <bpoulain@apple.com>
548
549         [WK2] Support all attributes of GeolocationPosition
550         https://bugs.webkit.org/show_bug.cgi?id=98212
551
552         Reviewed by Sam Weinig.
553
554         Expand WebKitTestRunner and DumpRenderTree to test all the attributes
555         of GeolocationPosition.
556
557         * DumpRenderTree/TestRunner.cpp:
558         (setMockGeolocationPositionCallback):
559         * DumpRenderTree/TestRunner.h:
560         (TestRunner):
561         * DumpRenderTree/efl/TestRunnerEfl.cpp:
562         (TestRunner::setMockGeolocationPosition):
563         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
564         (TestRunner::setMockGeolocationPosition):
565         * DumpRenderTree/mac/TestRunnerMac.mm:
566         (TestRunner::setMockGeolocationPosition):
567         * DumpRenderTree/win/TestRunnerWin.cpp:
568         (TestRunner::setMockGeolocationPosition):
569         * DumpRenderTree/wx/TestRunnerWx.cpp:
570         (TestRunner::setMockGeolocationPosition):
571         * WebKitTestRunner/GeolocationProviderMock.cpp:
572         (WTR::GeolocationProviderMock::setPosition):
573         * WebKitTestRunner/GeolocationProviderMock.h:
574         (GeolocationProviderMock):
575         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
576         (_platformTypeVariableDeclaration):
577         Use a proper constructor for the JSValueRef, it is an opaque type, we are not supposed
578         to build the pointer outself.
579         This is necessary to support optional JSValueRef properly.
580
581         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
582         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
583         (WTR::InjectedBundle::setMockGeolocationPosition):
584         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
585         (InjectedBundle):
586         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
587         (WTR::TestRunner::setMockGeolocationPosition):
588         * WebKitTestRunner/InjectedBundle/TestRunner.h:
589         (TestRunner):
590         * WebKitTestRunner/TestController.cpp:
591         (WTR::TestController::setMockGeolocationPosition):
592         * WebKitTestRunner/TestController.h:
593         (TestController):
594         * WebKitTestRunner/TestInvocation.cpp:
595         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
596
597 2012-10-04  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
598
599         Make the Xvfb driver recognize `X' as a valid X server binary.
600         https://bugs.webkit.org/show_bug.cgi?id=98434
601
602         Reviewed by Dirk Pranke.
603
604         The X server binary can also be called `X', so account for that
605         possibility in the _next_free_display regexp.
606
607         Additionally, make the regular expression require at least one
608         space character after the `ps comm' part.
609
610         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
611         (XvfbDriver._next_free_display):
612         * Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py:
613         (XvfbDriverTest.test_next_free_display):
614
615 2012-10-04  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
616
617         webkitpy: Accept WEBKITOUTPUTDIR in Port._setup_environ_for_server.
618         https://bugs.webkit.org/show_bug.cgi?id=98436
619
620         Reviewed by Dirk Pranke.
621
622         The Xvfb driver (ab)uses Port._setup_environ_for_server() to set
623         the environment for the server process, and the WEBKITOUTPUTDIR
624         environment variable was not being passed through, causing the
625         build directory to be wrongfully set to WebKitBuild/ all the time.
626
627         * Scripts/webkitpy/layout_tests/port/base.py:
628         (Port.to.setup_environ_for_server):
629
630 2012-10-04  Christophe Dumez  <christophe.dumez@intel.com>
631
632         [EFL][WK2] Add setting to allow file access from file:// URLs
633         https://bugs.webkit.org/show_bug.cgi?id=98121
634
635         Reviewed by Laszlo Gombos.
636
637         Allow file access from file:// URLs by default in Minibrowser
638         to facilitate testing.
639
640         * MiniBrowser/efl/main.c:
641         (browserCreate):
642
643 2012-10-04  Christophe Dumez  <christophe.dumez@intel.com>
644
645         [EFL] Run unit tests with Xvfb
646         https://bugs.webkit.org/show_bug.cgi?id=98389
647
648         Reviewed by Laszlo Gombos.
649
650         Run EFL unit tests with Xvfb, similarly to GTK port.
651
652         * Scripts/run-efl-tests:
653
654 2012-10-04  Adrian Perez de Castro  <aperez@igalia.com>
655
656         [GTK] Enable inspector by default in GtkLauncher/MiniBrowser
657         https://bugs.webkit.org/show_bug.cgi?id=98333
658
659         Reviewed by Xan Lopez.
660
661         Both MiniBrowser and GtkLauncher are tools for testing, so in
662         the end every time we want to test the inspector we have to
663         manually enable enable the “developer extras” setting when using
664         them. It make sense to have this setting enabled by default.
665
666         * GtkLauncher/main.c:
667         (main):
668         * MiniBrowser/gtk/main.c:
669         (main):
670
671 2012-10-04  Harald Alvestrand  <hta@google.com>
672
673         Change RTCPeerConnection GetStats to use Date timestamp format
674         https://bugs.webkit.org/show_bug.cgi?id=98263
675
676         Reviewed by Yury Semikhatsky.
677
678         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
679         (MockWebRTCPeerConnectionHandler::getStats):
680
681 2012-10-04  Dirk Pranke  <dpranke@chromium.org>
682
683         [NRWT] --skipped option is ignored when --test-list is used
684         https://bugs.webkit.org/show_bug.cgi?id=98260
685
686         Reviewed by Ojan Vafai.
687
688         Adds a --skipped=always flag that will skip any tests listed in
689         TestExpectations even if they're listed explicitly on the
690         command line.
691
692         This is most useful if you are using --test-list to specify a
693         long list of files but you still want to skip some of them
694         depending on what's in TestExpectations.
695
696         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
697         (LayoutTestFinder.skip_tests):
698         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
699         (parse_args):
700         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
701         (MainTest.test_skipped_flag):
702
703 2012-10-04  Sheriff Bot  <webkit.review.bot@gmail.com>
704
705         Unreviewed, rolling out r130377.
706         http://trac.webkit.org/changeset/130377
707         https://bugs.webkit.org/show_bug.cgi?id=98392
708
709         Chromium Win compilation is broken (Requested by yurys on
710         #webkit).
711
712         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
713         (MockWebRTCPeerConnectionHandler::getStats):
714
715 2012-10-04  Harald Alvestrand  <hta@google.com>
716
717         Change RTCPeerConnection GetStats to use Date timestamp format
718         https://bugs.webkit.org/show_bug.cgi?id=98263
719
720         Reviewed by Adam Barth.
721
722         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
723         (MockWebRTCPeerConnectionHandler::getStats):
724
725 2012-10-04  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
726
727         Unreviewed, remove unused $legacyWebKitBlobBuilderSupport variable after r130343.
728
729         * Scripts/webkitperl/FeatureList.pm:
730
731 2012-10-03  Philip Rogers  <pdr@google.com>
732
733         Force GC between PageLoad tests.
734         https://bugs.webkit.org/show_bug.cgi?id=98203
735
736         Reviewed by Ryosuke Niwa.
737
738         Previously, our PageLoad PerfTests had multi-modal distributions,
739         typically with a small cluster at 1-2x the median. This turned out
740         to be caused by not garbage collecting between tests!
741
742         This patch adds a new file, force-gc.html, and loads this file between
743         PageLoad tests to force a GC. I manually verified that this cleans up
744         our perf test outliers.
745
746         * Scripts/webkitpy/performance_tests/perftest.py:
747         (PageLoadingPerfTest.__init__):
748         (PageLoadingPerfTest):
749         (PageLoadingPerfTest.run_single):
750
751             This function now loads two pages: one to force a gc and
752             then the test to run.
753
754         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
755
756             Modified several existing tests to show that the force-gc file
757             is loaded.
758
759         (MockPort):
760         (MockPort.__init__):
761         (MockPort.perf_tests_dir):
762         (TestPageLoadingPerfTest.MockDriver.__init__):
763         (TestPageLoadingPerfTest.MockDriver.run_test):
764         (TestPageLoadingPerfTest.test_run):
765         (TestPageLoadingPerfTest.test_run_with_bad_output):
766         (TestReplayPerfTest.ReplayTestPort):
767         (TestReplayPerfTest.ReplayTestPort.__init__):
768         (TestReplayPerfTest.test_run_single.run_test):
769         (TestReplayPerfTest.test_run_single):
770         (TestReplayPerfTest.test_run_single_fails_when_output_has_error):
771         (TestPerfTestFactory.test_regular_test):
772         (TestPerfTestFactory.test_inspector_test):
773         (TestPerfTestFactory.test_page_loading_test):
774
775 2012-10-03  Christophe Dumez  <christophe.dumez@intel.com>
776
777         [EFL] Enable use of X11 in DumpRenderTree / WebKitTestRunner
778         https://bugs.webkit.org/show_bug.cgi?id=98231
779
780         Reviewed by Gyuyoung Kim.
781
782         Enable use of X11 in DumpRenderTree / WebKitTestRunner.
783         Call ecore_evas_new() instead of ecore_evas_buffer_new()
784         in EFL's DumpRenderTree and WebKitTestRunner.
785         It is safe to do this now that we are using XvfbDriver
786         for the layout tests.
787
788         * DumpRenderTree/efl/DumpRenderTree.cpp:
789         (parseCommandLineOptions):
790         (initEcoreEvas):
791         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
792         (WTR::initEcoreEvas):
793         * WebKitTestRunner/efl/main.cpp:
794         (main):
795
796 2012-10-03  Dirk Pranke  <dpranke@chromium.org>
797
798         run-webkit-tests tests on win32 after r127302
799         https://bugs.webkit.org/show_bug.cgi?id=98323
800
801         Reviewed by Eric Seidel.
802
803         run-webkit-tests tests on win32 after r127302
804         https://bugs.webkit.org/show_bug.cgi?id=98323
805
806         Reviewed by Eric Seidel.
807
808         Looks like when we converted the json-building logic to use scm
809         to try and get the svn revision, we missed a win32-ism and
810         didn't check to make sure had initialized the scm subsystem.
811
812         This change fixes that and renames _initialize_scm to be a public method.
813
814         * Scripts/webkitpy/common/host.py:
815         (Host.initialize_scm):
816         * Scripts/webkitpy/common/host_mock.py:
817         (MockHost.__init__):
818         (MockHost.initialize_scm):
819         * Scripts/webkitpy/layout_tests/controllers/manager.py:
820         (summarize_results):
821         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
822         (JSONResultsGeneratorBase.get_json):
823         (JSONResultsGeneratorBase._get_result_char):
824         (JSONResultsGeneratorBase._get_svn_revision):
825         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
826         (PerfTestsRunner.__init__):
827         * Scripts/webkitpy/style/checkers/test_expectations.py:
828         (TestExpectationsChecker.__init__):
829         * Scripts/webkitpy/style/main.py:
830         (CheckWebKitStyle.main):
831         * Scripts/webkitpy/tool/main.py:
832         (WebKitPatch.handle_global_options):
833         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
834         (get_test_baselines):
835
836 2012-10-03  Adrian Perez de Castro  <aperez@igalia.com>
837
838         [GTK] Make inspector directly useable in GtkLauncher/MiniBrowser
839         https://bugs.webkit.org/show_bug.cgi?id=98310
840
841         Reviewed by Martin Robinson.
842
843         Make MiniBrowser/GtkLauncher define the path to the inspector
844         resources by setting the WEBKIT_INSPECTOR_PATH environment
845         variable pointing to the copy of the inspector resources in
846         the build directory. If the environment variable is already
847         defined, its value is not overwritten. The path is derived
848         from the WEBKIT_EXEC_PATH macro defined in the makefiles.
849
850         * GNUmakefile.am:
851         * GtkLauncher/main.c:
852         (main):
853         * MiniBrowser/gtk/main.c:
854         (main):
855
856 2012-10-03  Benjamin Poulain  <bpoulain@apple.com>
857
858         Fix Geolocation/window-close-crash.html and harden WebKitTestRunner for Geolocation
859         https://bugs.webkit.org/show_bug.cgi?id=97608
860
861         Reviewed by Sam Weinig.
862
863         The test fast/dom/Geolocation/window-close-crash.html was crashing because
864         handleGeolocationPermissionRequest() was executed on the wrong pointer. Depending on how
865         the page was created, the void* clientInfo can either be a PlatformWebView or
866         a TestController.
867
868         Using the global TestController fixes the issue.
869
870         * WebKitTestRunner/GeolocationProviderMock.cpp:
871         (WTR::GeolocationProviderMock::setPosition):
872         (WTR::GeolocationProviderMock::setPositionUnavailableError):
873         To be reliable, the test fast/dom/Geolocation/maximum-age.html needs the setting the position
874         to clear the error and vice versa.
875         This is the same behavior as GeolocationClientMock and MockGeolocationProvider of WebKit1.
876
877         (WTR::GeolocationProviderMock::sendPositionIfNeeded):
878         (WTR::GeolocationProviderMock::sendErrorIfNeeded):
879         Some tests expect the position/error cant be sent multiple time,
880         just keep the position after sending.
881
882         * WebKitTestRunner/TestController.cpp:
883         (WTR::decidePolicyForGeolocationPermissionRequest):
884         (WTR::TestController::decidePolicyForGeolocationPermissionRequestIfPossible):
885         * WebKitTestRunner/TestController.h:
886         Let's play as if we did not know what is in GeolocationPermissionRequestManagerProxy like a real
887         client would have to do.
888
889 2012-10-03  Otto Derek Cheung  <otcheung@rim.com>
890
891         [BlackBerry] Implementing the NetworkInfo API for BB port
892         https://bugs.webkit.org/show_bug.cgi?id=98273
893
894         Reviewed by Rob Buis.
895
896         Enabling NetworkInfo API for the BlackBerry port.
897
898         * Scripts/webkitperl/FeatureList.pm:
899
900 2012-10-03  Anders Carlsson  <andersca@apple.com>
901
902         Exception thrown when running accessibility/container-node-delete-causes-crash.html test
903         https://bugs.webkit.org/show_bug.cgi?id=98291
904
905         Reviewed by Andreas Kling.
906
907         The accessibility/container-node-delete-causes-crash.html test will cause a full accessibility tree
908         to be created by trying to look up an element with a non-existent ID. This caused an exception to be thrown
909         when trying to access the children of an element that didn't have any children. Fix this by adding
910         BEGIN_AX_OBJC_EXCEPTIONS/END_AX_OBJC_EXCEPTIONS around the call to get the children.
911
912         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
913         (findAccessibleObjectById):
914
915 2012-10-03  Ojan Vafai  <ojan@chromium.org>
916
917         Make partytime work when loading garden-o-matic from trac.webkit.org
918         https://bugs.webkit.org/show_bug.cgi?id=98283
919
920         Reviewed by Adam Barth.
921
922         CSP was blocking the reqest for partytime.gif because 'self' wasn't on the img-src directive.
923         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
924
925 2012-10-03  Roger Fong  <roger_fong@apple.com>
926
927         Unreviewed. Adding sys.platform check to skip a failing assert on the Apple Windows platform.
928         https://bugs.webkit.org/show_bug.cgi?id=98288
929
930         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
931         (ChromiumAndroidDriverTest.test_command_from_driver_input):
932
933 2012-10-03  Ojan Vafai  <ojan@chromium.org>
934
935         Get rid of warning about non-existant platform name when loading garden-o-matic
936         https://bugs.webkit.org/show_bug.cgi?id=98282
937
938         Reviewed by Adam Barth.
939
940         If you loaded without a platform query parameter we'd return "null" as the platform name
941         instead of null.
942         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
943         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
944
945 2012-10-03  Balazs Kelemen  <kbalazs@webkit.org>
946
947         [Qt] Enable mock scrollbars
948         https://bugs.webkit.org/show_bug.cgi?id=98011
949
950         Reviewed by Csaba Osztrogonác.
951
952         Enable mock scrollbars for the Qt port. This patch will require a huge rebaseline.
953
954         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
955         (WebCore::DumpRenderTree::DumpRenderTree):
956         * WebKitTestRunner/TestController.cpp:
957         (WTR::TestController::resetStateToConsistentValues):
958
959 2012-10-03  Alberto Garcia  <agarcia@igalia.com>
960
961         [GTK] [WK2] Add favicon support to the MiniBrowser
962         https://bugs.webkit.org/show_bug.cgi?id=98063
963
964         Reviewed by Carlos Garcia Campos.
965
966         Set the icon in the URI text entry using the favicon property of
967         the WebKitWebView.
968
969         * MiniBrowser/gtk/BrowserWindow.c:
970         (_BrowserWindow):
971         (updateUriEntryIcon):
972         (uriEntryTextChanged):
973         (faviconChanged):
974         (browserWindowFinalize):
975         (browser_window_init):
976         (browserWindowConstructed):
977
978 2012-10-03  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
979
980         [Qt][DRT] Add support for overriding the "WebKitDisplayImagesKey" preference.
981         https://bugs.webkit.org/show_bug.cgi?id=98200
982
983         Reviewed by Csaba Osztrogonác.
984
985         * DumpRenderTree/qt/TestRunnerQt.cpp:
986         (TestRunner::overridePreference):
987
988 2012-10-03  Zoltan Arvai  <zarvai@inf.u-szeged.hu>
989
990         [Qt][WRT] Fix build error with MSVC on Windows.
991         https://bugs.webkit.org/show_bug.cgi?id=97697
992
993         Reviewed by Simon Hausmann.
994
995         WTR build is failing when WebKit directory is located on a longer path.
996         This seems to caused by source files that has the same name in
997         WTR and DRT directories. The solution is removing referencies 
998         from Target.pri to DRT directory and adding an alternate version of
999         the required files to WTR. Those files simply include the real ones from DRT.
1000
1001         * WebKitTestRunner/InjectedBundle/Target.pri:
1002         * WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.cpp: Added.
1003         * WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.h: Added.
1004
1005 2012-10-03  Christophe Dumez  <christophe.dumez@intel.com>
1006
1007         [WK2][WKTR] TestRunner.setAlwaysAcceptCookies() causes flakiness
1008         https://bugs.webkit.org/show_bug.cgi?id=98238
1009
1010         Reviewed by Csaba Osztrogonác.
1011
1012         Reset AlwaysAcceptCookies setting between tests to avoid
1013         flakiness due to TestRunner.setAlwaysAcceptCookies().
1014
1015         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1016         (WTR::InjectedBundle::beginTesting):
1017
1018 2012-10-03  Harald Alvestrand  <hta@google.com>
1019
1020         Add data passing to the GetStats interface of RTCPeerConnection
1021         https://bugs.webkit.org/show_bug.cgi?id=98003
1022
1023         Reviewed by Adam Barth.
1024
1025         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
1026         (RTCStatsRequestSucceededTask::RTCStatsRequestSucceededTask):
1027         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
1028         (MockWebRTCPeerConnectionHandler::addStream):
1029         (MockWebRTCPeerConnectionHandler::removeStream):
1030         (MockWebRTCPeerConnectionHandler::getStats):
1031         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
1032         (MockWebRTCPeerConnectionHandler):
1033
1034 == Rolled over to ChangeLog-2012-10-02 ==