e80ecf54db14540afe2fbef62d8b6d699c3829f6
[WebKit-https.git] / Tools / ChangeLog
1 2014-11-13  Myles C. Maxfield  <mmaxfield@apple.com>
2
3         Allow constructing a base PassRef with a derived Ref
4         https://bugs.webkit.org/show_bug.cgi?id=138701
5
6         Reviewed by Andreas Kling
7
8         * TestWebKitAPI/Tests/WTF/Ref.cpp:
9         (TestWebKitAPI::passWithPassRef):
10         (TestWebKitAPI::passWithPassRefPtr):
11         (TestWebKitAPI::TEST):
12
13 2014-11-05  Ada Chan  <adachan@apple.com>
14
15         Implement new plug-in API for muting plug-ins
16         https://bugs.webkit.org/show_bug.cgi?id=138105
17
18         Reviewed by Anders Carlsson.
19
20         Add a new plug-in test for the mute API.
21
22         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
23         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SetMuted.cpp: Added.
24         (SetMuted::SetMuted):
25         (SetMuted::isMuted):
26         (SetMuted::cachedIsMuted):
27         (SetMuted::ScriptableObject::hasProperty):
28         (SetMuted::ScriptableObject::getProperty):
29         (SetMuted::ScriptableObject::pluginTest):
30         (SetMuted::NPP_New):
31         (SetMuted::NPP_GetValue):
32         (SetMuted::NPP_SetValue):
33
34 2014-11-12  Philippe Normand  <pnormand@igalia.com>
35
36         Unreviewed, GTK gardening.
37
38         * Scripts/run-gtk-tests:
39         (TestRunner): Skip the UserMediaBasic test because it depends on
40         constraints validation which is going to be fixed in bug #136449.
41
42 2014-11-12  Carlos Garcia Campos  <cgarcia@igalia.com>
43
44         [GTK] Expose user script messages to GObject DOM bindings
45         https://bugs.webkit.org/show_bug.cgi?id=138411
46
47         Reviewed by Philippe Normand.
48
49         Add a test case to check that user script messages sent using the
50         DOM bindings API are also received in the UI process.
51
52         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
53         (UserScriptMessageTest::waitUntilMessageReceived):
54         (UserScriptMessageTest::postMessageAndWaitUntilReceived):
55         (testUserContentManagerScriptMessageFromDOMBindings):
56         (beforeAll):
57         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
58         (documentLoadedCallback):
59
60 2014-11-12  Carlos Garcia Campos  <cgarcia@igalia.com>
61
62         Unreviewed. Fix GTK+ clean build after r175930.
63
64         Partial rollout of r175930 to not build the new unit test that
65         broke clean builds in GTK+ port.
66
67         * TestWebKitAPI/PlatformGTK.cmake:
68
69 2014-09-01  Philippe Normand  <pnormand@igalia.com>
70
71         [WK2] UserMediaClient support
72         https://bugs.webkit.org/show_bug.cgi?id=123158
73
74         Reviewed by Benjamin Poulain.
75
76         Simple API test for the UserMedia permission request API. The
77         required test infrastructure is also added, inspired by the
78         Geolocation infrastructure.
79
80         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: New API test for UserMedia
81         Permission request.
82         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp: Added.
83         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack):
84         (TestWebKitAPI::TEST):
85         * TestWebKitAPI/Tests/WebKit2/getUserMedia.html: Added.
86         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: new
87         helper method to set the permission request result without user interaction.
88         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: Ditto.
89         (WTR::InjectedBundle::setUserMediaPermission):
90         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: Ditto.
91         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Ditto.
92         (WTR::TestRunner::setUserMediaPermission):
93         * WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto.
94         * WebKitTestRunner/TestController.cpp:
95         (WTR::decidePolicyForUserMediaPermissionRequest): Permission
96         request handler.
97         (WTR::TestController::createOtherPage): Enable the new UserMedia
98         permission request handler.
99         (WTR::TestController::createWebViewWithOptions): Ditto.
100         (WTR::TestController::resetPreferencesToConsistentValues): Enable
101         MediaStream support, this is needed for getUserMedia.
102         (WTR::TestController::resetStateToConsistentValues): clear
103         UserMedia permissions list and flags.
104         (WTR::TestController::setUserMediaPermission): Set permission
105         request result and distpatch it.
106         (WTR::TestController::handleUserMediaPermissionRequest): Save
107         request and dispatch it.
108         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible):
109         Dispatch cached permission requests.
110         * WebKitTestRunner/TestController.h:
111         * WebKitTestRunner/TestInvocation.cpp:
112         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
113
114 2014-11-11  David Kilzer  <ddkilzer@apple.com>
115
116         webkit-patch --suggest-reviewers is broken with newer versions of git
117         <http://webkit.org/b/138627>
118
119         Reviewed by Michael Saboff with feedback from Daniel Bates.
120
121         * Scripts/webkitpy/common/checkout/scm/git.py:
122         (Git._changes_files_for_commit): Strip blank lines instead of
123         assuming there is always a blank line at the beginning of the
124         list.
125
126 2014-11-11  Alexey Proskuryakov  <ap@apple.com>
127
128         DRT and WKTR touch disk cache
129         https://bugs.webkit.org/show_bug.cgi?id=138622
130
131         Reviewed by Geoffrey Garen.
132
133         * DumpRenderTree/mac/DumpRenderTree.mm: (prepareConsistentTestingEnvironment):
134         Set a shared cache before calling -_switchNetworkLoaderToNewTestingSession, not after,
135         because this function uses the shared cache.
136
137         * WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::platformInitializeContext):
138         Create an empty shared cache to prevent a default one from being created on disk.
139
140 2014-10-07  Sergio Villar Senin  <svillar@igalia.com>
141
142         [CSS Grid Layout] Limit the size of explicit/implicit grid
143         https://bugs.webkit.org/show_bug.cgi?id=136217
144
145         Reviewed by Andreas Kling.
146
147         Added a new unit test for the CSS parser. Right now it only checks
148         that we properly clamp the maximum number of tracks on a grid to a
149         maximum of 1 million.
150
151         * TestWebKitAPI/CMakeLists.txt:
152         * TestWebKitAPI/PlatformEfl.cmake:
153         * TestWebKitAPI/PlatformGTK.cmake:
154         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
155         * TestWebKitAPI/Tests/WebCore/CSSParser.cpp: Added.
156         (TestWebKitAPI::computeNumberOfTracks): Helper function.
157         (TestWebKitAPI::TEST): Added a
158         CSSPropertyParserTest.GridTrackLimits test case.
159
160 2014-11-11  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
161
162         webkitpy test fix after r175867
163         https://bugs.webkit.org/show_bug.cgi?id=138607
164
165         Reviewed by Philippe Normand.
166
167         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
168         (GDBCrashLogGeneratorTest.test_generate_crash_log):
169
170 2014-11-10  Philippe Normand  <pnormand@igalia.com>
171
172         webkitpy: demangle C++ symbols from crash log stderr
173         https://bugs.webkit.org/show_bug.cgi?id=138565
174
175         Reviewed by Alexey Proskuryakov.
176
177         * Scripts/webkitpy/port/linux_get_crash_log.py:
178         (GDBCrashLogGenerator.generate_crash_log): Process stderr output
179         with c++filt.
180
181 2014-11-10  Philippe Normand  <pnormand@igalia.com>
182
183         [GTK] fix up the GDB backtrace report tool
184         https://bugs.webkit.org/show_bug.cgi?id=138564
185
186         Reviewed by Carlos Garcia Campos.
187
188         * Scripts/webkitpy/port/gtk.py:
189         (GtkPort._get_crash_log): Match the process name reported by the
190         driver with the GTK port WebProcess executable filename.
191         * Scripts/webkitpy/port/linux_get_crash_log.py:
192         (GDBCrashLogGenerator._get_gdb_output): Invoke gdb for the crashed
193         program.
194         (GDBCrashLogGenerator.generate_crash_log): Use %E in the core
195         pattern to workaround the 16 characters size limit of %e.
196
197 2014-11-10  Conrad Shultz  <conrad_shultz@apple.com>
198
199         Unreviewed, moved myself to the list of committers.
200
201         * Scripts/webkitpy/common/config/contributors.json:
202
203 2014-11-10  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
204
205         [EFL] Fix the test font path after r175555.
206
207         Reviewed by Csaba Osztrogonác.
208
209         * WebKitTestRunner/PlatformEfl.cmake: Dependencies -> DependenciesEFL
210
211 2014-11-10  Akos Kiss  <akiss@inf.u-szeged.hu>
212
213         Fix the exception fuzz helper to generate targets in the correct range
214         https://bugs.webkit.org/show_bug.cgi?id=138544
215
216         Reviewed by Filip Pizlo.
217
218         Currently, the script generates exception fuzz targets in the range of
219         0..($checkCount-1). However, target 0 is never hit, while target 1 is
220         always outside of the outermost try block of the tests, which therefore
221         prints unexpected output and results in false failures when fired at.
222         Additionally, target $checkCount is never generated.
223
224         This patch fixes the script to generate targets in the range of
225         2..$checkCount.
226
227         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
228
229 2014-11-09  Csaba Osztrogonác  <ossy@webkit.org>
230
231         make-passwords-json.py should generarate everything needed for testing
232         https://bugs.webkit.org/show_bug.cgi?id=138503
233
234         Reviewed by Ryosuke Niwa.
235
236         * BuildSlaveSupport/build.webkit.org-config/make_passwords_json.py:
237         Renamed from make-passwords-json.py to be able included from mastercfg_unittest.py.
238         Additionally generate auth.json, credentials.cfg and committers.cfg too.
239         (create_mock_slave_passwords_dict): Moved from mastercfg_unittest.py
240         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
241         (BuildBotConfigLoader._mock_open): Use make_passwords_json.create_mock_slave_passwords_dict() to avoid duplication.
242         (BuildBotConfigLoader._create_mock_passwords_dict): Deleted.
243
244 2014-11-09  Carlos Garcia Campos  <cgarcia@igalia.com>
245
246         [GTK] generate-gtkdoc should ignore invalid files
247         https://bugs.webkit.org/show_bug.cgi?id=138542
248
249         Reviewed by Darin Adler.
250
251         * gtk/generate-gtkdoc:
252         (files_to_ignore.file_should_be_ignored): Return True to ignore
253         invalid files.
254
255 2014-11-08  Alexey Proskuryakov  <ap@apple.com>
256
257         Delete cookies between tests
258         https://bugs.webkit.org/show_bug.cgi?id=138528
259
260         Reviewed by Sam Weinig.
261
262         * DumpRenderTree/mac/DumpRenderTree.mm:
263         (resetWebPreferencesToConsistentValues):
264         * WebKitTestRunner/TestController.cpp:
265         (WTR::TestController::resetPreferencesToConsistentValues):
266         Do it.
267
268         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
269         (WTR::InjectedBundle::beginTesting):
270         Added a FIXME.
271
272 2014-11-08  Carlos Garcia Campos  <cgarcia@igalia.com>
273
274         [GTK] Run layout tests using the network process
275         https://bugs.webkit.org/show_bug.cgi?id=138428
276
277         Reviewed by Martin Robinson.
278
279         Shared secondary process is the default in the GTK+ port, but we
280         should run the tests using the network process to ensure
281         everything works with the network process. In the future, the
282         shared secondary process model might be a special case of multiple
283         processes with 1 as maximum number of processes, but always using
284         the network process.
285
286         * WebKitTestRunner/TestController.cpp:
287         (WTR::TestController::initialize):
288
289 2014-11-08  Carlos Garcia Campos  <cgarcia@igalia.com>
290
291         [GTK] Allow to create a view with a related page in WTR
292         https://bugs.webkit.org/show_bug.cgi?id=138501
293
294         Reviewed by Martin Robinson.
295
296         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
297         (TestWebKitAPI::PlatformWebView::PlatformWebView): Pass nullptr as
298         related page to WKViewCreate.
299         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
300         (WTR::PlatformWebView::PlatformWebView): Pass the given related
301         page to WKViewCreate.
302
303 2014-11-08  Carlos Garcia Campos  <cgarcia@igalia.com>
304
305         WTR crashes after running a test when NetworkProcess enabled
306         https://bugs.webkit.org/show_bug.cgi?id=138500
307
308         Reviewed by Alexey Proskuryakov.
309
310         WebNotificationProvider destructor is calling
311         WKNotificationManagerSetProvider, but m_notificationManager is
312         null because removeNotificationManager was already called.
313
314         * WebKitTestRunner/WebNotificationProvider.cpp:
315         (WTR::WebNotificationProvider::~WebNotificationProvider): Check
316         m_notificationManager is not null before calling WKNotificationManagerSetProvider.
317
318 2014-11-06  Jake Nielsen  <jacob_nielsen@apple.com>
319
320         Remove duplicate code from PatchAnalysisTask._test_patch and fix bug
321         regarding incorrect call to PatchAnalysisTask.report_failure
322         https://bugs.webkit.org/show_bug.cgi?id=138229
323
324         Reviewed by Daniel Bates.
325
326         * Scripts/webkitpy/common/net/layouttestresults.py:
327         Makes sure test_results returns a list.
328         (LayoutTestResults.test_results):
329         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
330         Makes unit tests also check to make sure
331         task.results_from_patch_test_run() and
332         task.results_from_test_run_without_patch return instances of
333         LayoutTestResults.
334         (CommitQueueTaskTest._run_and_expect_patch_analysis_result):
335         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
336         Condenses duplicate code into _should_defer_patch_or_throw, and
337         removes the now-unused _clean_tree_results member.
338         (PatchAnalysisTask.__init__):
339         (PatchAnalysisTask._continue_testing_patch_that_exceeded_failure_limit_on_first_or_second_try):
340         (PatchAnalysisTask._should_defer_patch_or_throw):
341         (PatchAnalysisTask._test_patch):
342         (PatchAnalysisTask.results_from_patch_test_run):
343         (PatchAnalysisTask.results_from_test_run_without_patch): Deleted.
344         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
345         Removes needless call to results_from_test_run_without_patch
346         (AbstractEarlyWarningSystem._failing_tests_message):
347         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
348         Changes order of test failure messages to be in the order that they
349         appear.
350         (AbstractEarlyWarningSystemTest.test_failing_tests_message):
351         * Scripts/webkitpy/tool/commands/queues.py:
352         Removes needless call to results_from_test_run_without_patch.
353         (CommitQueue._failing_tests_message):
354         * Scripts/webkitpy/tool/commands/queues_unittest.py:
355         (MockCommitQueueTask.results_from_test_run_without_patch): Deleted.
356
357 2014-11-06  Ryuan Choi  <ryuan.choi@navercorp.com>
358
359         Unreviewed. Reorder my e-mail addresses in contributors.json
360
361         * Scripts/webkitpy/common/config/contributors.json:
362
363 2014-11-06  Matthew Hanson  <matthew_hanson@apple.com>
364
365         Remove code that prepends a leading 'r' to the first argument of _run_git_svn_find_rev
366         https://bugs.webkit.org/show_bug.cgi?id=138475
367
368         Reviewed by Ryosuke Niwa.
369
370         The change in https://trac.webkit.org/175603 introduced broke compatibility with svn_revision_from_git_commit.
371         This patch reverts the part of that change that broke compatibility. In addition, this patch adds a comment to
372         explain that SVN revisions require a leading 'r', moves an existing comment to a more appropriate location and
373         renames the positional argument to better reflect that it can represent either an SVN revision or a Git tree-ish.
374
375         * Scripts/webkitpy/common/checkout/scm/git.py:
376         (Git._run_git_svn_find_rev):
377         Add comment mentioning that svn_revisions need to begin with 'r'.
378         Move comment (explaining that git svn find-rev exits with code 0 when no match is found) to a more appropriate location.
379         Rename the argument 'revision' to 'revision_or_treeish' to reflect the dual form that argument can take.
380         Remove code that coerced the revision/treeish into a string and prepended an 'r'.
381
382 2014-11-06  Carlos Garcia Campos  <cgarcia@igalia.com>
383
384         [GTK] Add context menu API to Web Process Extensions
385         https://bugs.webkit.org/show_bug.cgi?id=138311
386
387         Reviewed by Gustavo Noronha Silva.
388
389         Add tests cases for WebKitWebPage::context-menu signal.
390
391         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
392         (testContextMenuWebExtensionMenu):
393         (testContextMenuWebExtensionNode):
394         (beforeAll):
395         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
396         (serializeContextMenu):
397         (serializeNode):
398         (contextMenuCallback):
399         (pageCreatedCallback):
400
401 2014-11-06  Commit Queue  <commit-queue@webkit.org>
402
403         Unreviewed, rolling out r175690.
404         https://bugs.webkit.org/show_bug.cgi?id=138460
405
406         We are not ready to run layout tests using the network process
407         yet (Requested by KaL on #webkit).
408
409         Reverted changeset:
410
411         "[GTK] Run layout tests using the network process"
412         https://bugs.webkit.org/show_bug.cgi?id=138428
413         http://trac.webkit.org/changeset/175690
414
415 2014-11-06  Carlos Garcia Campos  <cgarcia@igalia.com>
416
417         [GTK] Run layout tests using the network process
418         https://bugs.webkit.org/show_bug.cgi?id=138428
419
420         Reviewed by Martin Robinson.
421
422         Shared secondary process is the default in the GTK+ port, but we
423         should run the tests using the network process to ensure
424         everything works with the network process. In the future, the
425         shared secondary process model might be a special case of multiple
426         processes with 1 as maximum number of processes, but always using
427         the network process.
428
429         * WebKitTestRunner/TestController.cpp:
430         (WTR::TestController::initialize):
431
432 2014-11-05  Dan Bernstein  <mitz@apple.com>
433
434         Remove the unused deletion UI feature
435         https://bugs.webkit.org/show_bug.cgi?id=138442
436
437         Rubber-stamped by Alexey Proskuryakov.
438
439         * DumpRenderTree/mac/EditingDelegate.mm:
440         (-[EditingDelegate webView:shouldShowDeleteInterfaceForElement:]): Deleted implementation of
441         delegate method that’s been removed.
442
443 2014-11-05  Alexey Proskuryakov  <ap@apple.com>
444
445         fast/dom/remove-body-during-body-replacement2.html fails on WK2
446         https://bugs.webkit.org/show_bug.cgi?id=138334
447
448         Reviewed by Anders Carlsson.
449
450         Reset focus to main frame between tests. DumpRenderTree does this via -makeFirstResponder
451         calls, which works because each frame is an NSView in WK1. WK2 makes equivalent
452         -makeFirstResponder calls, which may or may not be needed for other reasons, but
453         it also needs to reset internal focus explicitly.
454
455         It's not clear if this is the right long-term fix or a workaround for a WebKit bug.
456         WebKit behavior appears wrong, but it matches Firefox.
457
458         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
459         (WTR::InjectedBundlePage::resetAfterTest):
460
461 2014-11-05  Carlos Garcia Campos  <cgarcia@igalia.com>
462
463         [GTK] Add WebKitWebResource::failed-with-tls-errors signal
464         https://bugs.webkit.org/show_bug.cgi?id=137862
465
466         Reviewed by Gustavo Noronha Silva.
467
468         Add a test case to check that WebKitWebResource::failed-with-tls-errors
469         is emitted when a subresource load fails due to TLS errors.
470
471         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
472         (TLSSubresourceTest::resourceLoadStartedCallback):
473         (TLSSubresourceTest::TLSSubresourceTest):
474         (TLSSubresourceTest::subresourceFailedCallback):
475         (TLSSubresourceTest::subresourceFailedWithTLSErrorsCallback):
476         (TLSSubresourceTest::subresourceLoadStarted):
477         (TLSSubresourceTest::subresourceFailedWithTLSErrors):
478         (TLSSubresourceTest::waitUntilSubresourceLoadFail):
479         (testSubresourceLoadFailedWithTLSErrors):
480         (httpsServerCallback):
481         (httpServerCallback):
482         (beforeAll):
483
484 2014-11-05  Alexey Proskuryakov  <ap@apple.com>
485
486         Build fix for some compiler versions.
487
488         * TestWebKitAPI/Tests/mac/TypingStyleCrash.mm: (TestWebKitAPI::TEST): Compiler was
489         unhappy because this is a getter, and these shouldn't have side effects.
490
491 2014-11-04  Matthew Hanson  <matthew_hanson@apple.com>
492
493         Add a method for performing cherrypick-merges.
494         https://bugs.webkit.org/show_bug.cgi?id=138375
495
496         Reviewed by Ryosuke Niwa.
497
498         Adds support for cherrypick-merges.
499
500         * Scripts/webkitpy/common/checkout/scm/git.py:
501         (Git.cherrypick_merge): Added.
502
503 2014-11-04  Matthew Hanson  <matthew_hanson@apple.com>
504
505         Add a way to ascertain the SVN URL associated with a Git branch.
506         https://bugs.webkit.org/show_bug.cgi?id=138374
507
508         Reviewed by Ryosuke Niwa.
509
510         The svn_url method returns the SVN URL associated with the current Git branch.
511
512         * Scripts/webkitpy/common/checkout/scm/git.py:
513         (Git.svn_url): Added.
514
515 2014-11-04  Matthew Hanson  <matthew_hanson@apple.com>
516
517         Add the ability to search for modifications that are staged for commit.
518         https://bugs.webkit.org/show_bug.cgi?id=138373
519
520         Reviewed by Ryosuke Niwa and Daniel Bates.
521
522         This makes is easy to do identify files that require merge post-processing,
523         in addition to stand-alone utility.
524
525         * Scripts/webkitpy/common/checkout/scm/git.py:
526         (Git.modifications_staged_for_commit): Added.
527
528 2014-11-04  Matthew Hanson  <matthew_hanson@apple.com>
529
530         Add a branch keyword argument to _run_git_svn_find_rev.
531         https://bugs.webkit.org/show_bug.cgi?id=138372
532
533         Reviewed by Ryosuke Niwa.
534
535         The addition of this keyword argument allows clients to determine the Git hash
536         of commits made on an SVN branch, provided that branch has been fetched locally.
537
538         * Scripts/webkitpy/common/checkout/scm/git.py:
539         (Git._run_git_svn_find_rev):
540         Add a branch keyword argument that is added to the end of the command, if present.
541
542 2014-11-04  Chris Dumez  <cdumez@apple.com>
543
544         Add ptr() method to Ref class
545         https://bugs.webkit.org/show_bug.cgi?id=138361
546
547         Reviewed by Darin Adler.
548
549         Use the new Ref::ptr() method.
550
551         * TestWebKitAPI/Tests/WTF/Ref.cpp:
552         (TestWebKitAPI::TEST):
553
554 2014-11-04  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
555
556         [jhbuild] Make it possible to build GTK/EFL in same repository
557         https://bugs.webkit.org/show_bug.cgi?id=137448
558
559         Reviewed by Martin Robinson.
560
561         * Scripts/webkitdirs.pm:
562         (getJhbuildPath):
563         * WebKitTestRunner/InjectedBundle/efl/FontManagement.cpp:
564         (getPlatformFontsPath):
565         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
566         (WTR::getFontsPath):
567         * jhbuild/jhbuild-wrapper:
568         (determine_platform):
569         (install_jhbuild):
570         * jhbuild/jhbuildrc_common.py:
571         (init):
572
573 2014-11-04  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
574
575         [EFL] Bump LLVM to version 3.5.0
576         https://bugs.webkit.org/show_bug.cgi?id=138312
577
578         Reviewed by Csaba Osztrogonác.
579
580         * efl/jhbuild.modules:
581         * efl/patches/llvm-elf-add-stackmaps.patch: Added.
582         * efl/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch: Added.
583
584 2014-11-03  Simon Fraser  <simon.fraser@apple.com>
585
586         Add page overlays that show regions with mouseWheel event handlers, and the non-fast-scrollable region, and code to toggle them in MiniBrowser WK2
587         https://bugs.webkit.org/show_bug.cgi?id=138257
588
589         Reviewed by Tim Horton.
590         
591         Add a "Debug Overlays" submenu item under "WebKit2-only Settings" which allows
592         the user to toggle region page overlays on and off. Two overlays are available,
593         for the non-fast scrollable region, and the region of element with wheel
594         event handlers.
595
596         * MiniBrowser/mac/SettingsController.h:
597         * MiniBrowser/mac/SettingsController.m:
598         (-[SettingsController _populateMenu]):
599         (-[SettingsController validateMenuItem:]):
600         (-[SettingsController nonFastScrollableRegionOverlayVisible]):
601         (-[SettingsController wheelEventHandlerRegionOverlayVisible]):
602         (-[SettingsController preferenceKeyForRegionOverlayTag:]):
603         (-[SettingsController toggleDebugOverlay:]):
604         (-[SettingsController debugOverlayVisible:]):
605         * MiniBrowser/mac/WK2BrowserWindowController.m:
606         (-[WK2BrowserWindowController didChangeSettings]):
607
608 2014-11-03  Alexey Proskuryakov  <ap@apple.com>
609
610         REGRESSION (Subpixel layout): Bubbles don't fit in Bugzilla review page
611         https://bugs.webkit.org/show_bug.cgi?id=138323
612
613         Reviewed by Zalan Bujtas.
614
615         * QueueStatusServer/templates/statusbubble.html: Round the sizes up, not down.
616
617 2014-11-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
618
619         [ninja] Don't remove response files for verbose builds
620         https://bugs.webkit.org/show_bug.cgi?id=137816
621
622         Reviewed by Csaba Osztrogonác.
623
624         * Scripts/webkitdirs.pm:
625         (determineNinjaVersion):
626         (buildCMakeGeneratedProject):
627
628 2014-11-02  Akos Kiss  <akiss@inf.u-szeged.hu>
629
630         [GTK] Fix the build of FTL JIT
631         https://bugs.webkit.org/show_bug.cgi?id=138298
632
633         Reviewed by Carlos Garcia Campos.
634
635         * gtk/jhbuild-optional.modules:
636         Bump up LLVM version to 3.5.0 release and apply patches.
637         * gtk/patches/llvm-elf-add-stackmaps.patch:
638         Added. Adds .llvm_stackmaps section to ELF files. Backported from LLVM
639         trunk.
640         * gtk/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch:
641         Added. Ensures that PC-relative relocations in EH frames are not
642         truncated to 32 bits on x86_64.
643
644 2014-10-31  Michael Saboff  <msaboff@apple.com>
645
646         No way to specify target os or architecture when using the --no-copy option with run-jsc-stress-tests
647         https://bugs.webkit.org/show_bug.cgi?id=138268
648
649         Reviewed by Andreas Kling.
650
651         Added a --arch and --os option to set or override the values that are
652         normally computed based on examining the JavaScriptCore we want to test.
653
654         * Scripts/run-jsc-stress-tests:
655
656 2014-10-31  Dan Bernstein  <mitz@apple.com>
657
658         llvmForJSC build emits a linker warning that it can't find usr/local/LLVMForJavaScriptCore/lib under the build directory
659         https://bugs.webkit.org/show_bug.cgi?id=138259
660
661         Reviewed by Geoff Garen.
662
663         * Scripts/copy-webkitlibraries-to-product-directory: Create this directory even if it’s
664         going to be empty to silence the warning.
665
666 2014-10-31  Adrian Perez de Castro  <aperez@igalia.com>
667
668         [GTK] Support script message handlers WebKitUserContentManager
669         https://bugs.webkit.org/show_bug.cgi?id=133730
670
671         Reviewed by Carlos Garcia Campos.
672
673         Support user script message handlers in WebKitUserContentManager.
674         This needs building with ENABLE_USER_MESSAGE_HANDLERS, for which
675         an option is added to the CMake build files. The option is disabled
676         globally by default, and the WebKitGTK port enables it. On the API
677         level, two new methods to register and unregister names are provided
678         in the "window.webkit" namespace, and on message reception the
679         "WebKitUserContentManager::script-message-received" signal is
680         emitted, using the registered names as signal detail.
681
682         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
683         Add test case for user script message handlers.
684         (scriptMessageReceived):
685         (testUserContentManagerScriptMessageReceived):
686         (beforeAll):
687
688 2014-10-30  Matthew Hanson  <matthew_hanson@apple.com>
689
690         bisect-builds should support WebKit clients other than Safari
691         https://bugs.webkit.org/show_bug.cgi?id=138225
692
693         This patch adds support for bisecting WebKit nightly builds with clients other than Safari.
694
695         The -a / --application optional argument allows the user to specify which application (or application bundle)
696         should be run against the WebKit nightly builds.
697
698         Reviewed by David Kilzer.
699
700         * Scripts/bisect-builds:
701         Swap out $safariPath for the more general $applicationPath
702         Leave --safari-path as a commandline option for backwards compatibility
703         (mountAndRunNightly):
704         Use File::Spec->cat correctly (one directory per argument)
705         Use open --wait-apps instead of running the target application directly
706
707 2014-10-30  Dana Burkart  <dburkart@apple.com>
708
709         <rdar://problem/18821260> Perpare for the mysterious future
710
711         Reviewed by Lucas Forschler.
712
713         * DumpRenderTree/mac/Configurations/Base.xcconfig:
714         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
715         * LayoutTestRelay/Configurations/Base.xcconfig:
716         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
717         * MiniBrowser/Configurations/Base.xcconfig:
718         * MiniBrowser/Configurations/DebugRelease.xcconfig:
719         * TestWebKitAPI/Configurations/Base.xcconfig:
720         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
721         * WebKitLauncher/Configurations/Base.xcconfig:
722         * WebKitTestRunner/Configurations/Base.xcconfig:
723         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
724
725 2014-10-30  Matthew Hanson  <matthew_hanson@apple.com>
726
727         Update safariVersion to safariVersionString
728         https://bugs.webkit.org/show_bug.cgi?id=138193
729
730         The preceding change updated safariVersion to safariVersionString for the "4 Public Beta" check in OS X 10.5.x,
731         but it should have also been done for the "4 Public Beta" check in OS X 10.4.x.
732
733         Rubber-stamped by David Kilzer.
734
735         * Scripts/bisect-builds:
736         (makeNightlyList):
737         Compare safariVersionString to a string literal, instead of safariVersion.
738
739 2014-10-30  Rohit Kumar  <kumar.rohit@samsung.com>
740
741         [GTK] Minibrowser : Add window fullscreen support for Minibrowser
742         https://bugs.webkit.org/show_bug.cgi?id=137775
743
744         Reviewed by Carlos Garcia Campos.
745
746         * MiniBrowser/gtk/BrowserWindow.c:
747         (toggleFullScreen): Callback to toggle window fullscreen on pressing F11 key.
748         (browser_window_init):
749
750 2014-10-29  Jake Nielsen  <jacob_nielsen@apple.com>
751
752         CommitQueue and EWS should reject any patches that result in consistent test
753         failures that aren't present on the tree.
754         https://bugs.webkit.org/show_bug.cgi?id=138184
755
756         Reviewed by Alexey Proskuryakov.
757
758         * Scripts/webkitpy/layout_tests/models/test_results.py:
759         Adds a simple hashing function to allow for set operations to handle
760         TestResult objects properly.
761         (TestResult.__hash__):
762         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
763         Adds one unit test, and modifies others to agree with the notion that
764         patches that introduce new test failures (but also have flakyness)
765         should be rejected rather than spin.
766         (MockCommitQueue.report_flaky_tests):
767         (CommitQueueTaskTest._run_and_expect_patch_analysis_result):
768         (test_double_flaky_test_failure):
769         (test_two_flaky_tests):
770         (test_very_flaky_patch):
771         (test_very_flaky_patch_with_some_tree_redness):
772         (test_different_test_failures):
773         (test_different_test_failures_with_some_tree_redness):
774         (test_different_test_failures_with_some_tree_redness_and_some_fixes):
775         (test_mildly_flaky_patch):
776         (test_mildly_flaky_patch_with_some_tree_redness):
777         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
778         Makes PatchAnalysisTask reject said patches.
779         (PatchAnalysisTask._test_patch):
780
781 2014-10-29  Youenn Fablet  <youenn.fablet@crf.canon.fr>
782
783         WinCairoRequirements.zip cannot be downloaded from dropbox
784         https://bugs.webkit.org/show_bug.cgi?id=138113
785
786         Reviewed by Alexey Proskuryakov.
787
788         * Scripts/update-webkit-dependency: Removing --sslv3 option from curl
789
790 2014-10-29  Matthew Hanson  <matthew_hanson@apple.com>
791
792         bisect-builds should filter out nightlies that predate the introduction of an OS X operating system
793         https://bugs.webkit.org/show_bug.cgi?id=138193
794
795         This patch restricts the set of nightles to bisect to only those nightlies that ship with frameworks
796         for the target OS (only support for OS X Yosemite, Mavericks and Mountain Lion was added.)
797
798         It also does a bit of refactoring, including distinguishing between versions and version strings and
799         saving versions to local variables instead of using eval in each conditional.
800
801         Reviewed by David Kilzer.
802
803         * Scripts/bisect-builds:
804         (makeNightlyList):
805         Restrict the set of nightlies to r174650 and above when running Yosemite.
806         Restrict the set of nightlies to r157846 and above when running Mavericks.
807         Restrict the set of nightlies to r122421 and above when running Mountain Lion.
808
809 2014-10-29  Csaba Osztrogonác  <ossy@webkit.org>
810
811         [EFL] build-webkit should try harder to avoid re-running cmake
812         https://bugs.webkit.org/show_bug.cgi?id=137949
813
814         Reviewed by Martin Robinson.
815
816         * Scripts/webkitdirs.pm:
817         (shouldRemoveCMakeCache): Don't remove CMakeCache unconditionally for EFL.
818         (generateBuildSystemFromCMakeProject): Comment fix after r174681.
819
820 2014-10-28  Daniel Bates  <dabates@apple.com>
821
822         Unify logic in RunTests.run() to run the Python unit tests
823         https://bugs.webkit.org/show_bug.cgi?id=138160
824
825         Reviewed by Martin Robinson.
826
827         Unify the interactive and non-interactive code path for running the Python unit tests
828         in step RunTests so as to remove duplicate code to compute the the path to the script
829         test-webkitpy and log an informative message ("Running Python unit tests") to the console.
830
831         No new tests since no functionality was changed.
832
833         * Scripts/webkitpy/port/base.py:
834         (Port.python_unittest_results_directory):
835         * Scripts/webkitpy/tool/steps/runtests.py:
836         (RunTests.run):
837
838 2014-10-28  Jake Nielsen  <jacob_nielsen@apple.com>
839
840         Make runtest.py call test-webkitpy with the --json flag when in
841         non-interactive mode.
842         https://bugs.webkit.org/show_bug.cgi?id=137667
843
844         Reviewed by Daniel Bates.
845
846         * Scripts/webkitpy/port/base.py:
847         Adds the python_unittest_results_directory method.
848         (Port.python_unittest_results_directory):
849         * Scripts/webkitpy/tool/steps/runtests.py:
850         Changes RunTests to call test-webkitpy with the --json flag if the
851         --non-interactive flag is set.
852         (RunTests):
853         (RunTests.run):
854
855 2014-10-28  Rebecca Hauck  <rhauck@adobe.com>
856
857         import-w3c-tests should use re.escape() wherever it's handling file paths
858         https://bugs.webkit.org/show_bug.cgi?id=137934
859
860         This patch adds re.escape() to a few places where we're doing string
861         conversions. This prevents errors when attribute values coincidentally
862         have character sequences that can be interpreted as regular expressions.
863
864         Reviewed by Bem Jones-Bey.
865
866         * Scripts/webkitpy/w3c/test_converter.py:
867         (_W3CTestConverter.convert_attributes_if_needed):
868
869 2014-10-28  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
870
871         [EFL] Remove an unused include from Tools/WebKitTestRunner/efl/PlatformWebViewEfl.cpp
872         https://bugs.webkit.org/show_bug.cgi?id=138130
873
874         Reviewed by Csaba Osztrogonác.
875
876         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
877
878 2014-10-25  Raniere Silva  <raniere@ime.unicamp.br>
879
880         Fix link to Arch Linux Wiki
881         https://bugs.webkit.org/show_bug.cgi?id=138010
882
883         Reviewed by Benjamin Poulain.
884
885         * gtk/install-dependencies:
886
887 2014-10-25  Alexey Proskuryakov  <ap@apple.com>
888
889         Test regressions are not detected when image result is missing
890         https://bugs.webkit.org/show_bug.cgi?id=138070
891
892         Reviewed by Simon Fraser.
893
894         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
895         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
896         Count these as regressions, not as flaky tests.
897
898         * Scripts/webkitpy/port/test.py:
899         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
900         Test it.
901
902 2014-10-24  Timothy Horton  <timothy_horton@apple.com>
903
904         Add Conrad Shultz to the contributors list.
905
906         * Scripts/webkitpy/common/config/contributors.json:
907
908 2014-10-24  Dan Bernstein  <mitz@apple.com>
909
910         build.webkit.org/dashboard immediately retries a request to buildbot when the response is 404
911         https://bugs.webkit.org/show_bug.cgi?id=138046
912
913         Reviewed by Alexey Proskuryakov.
914
915         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
916         (BuildbotQueue.prototype._load): Only consider retrying immediately if the error code was
917         401. Otherwise, we’ll retry normally in 45 seconds.
918
919 2014-10-24  Marcos Chavarría Teijeiro  <chavarria1991@gmail.com>
920
921         [GTK] Implement is_selected method on WebKitHitTestResult
922         https://bugs.webkit.org/show_bug.cgi?id=137110
923
924         Reviewed by Tim Horton.
925
926         Add tests for new context SELECTION on WebKitHitTestResult.
927
928         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
929         (testContextMenuDefaultMenu):
930         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
931         (testWebViewMouseTarget):
932
933 2014-10-23  Roger Fong  <roger_fong@apple.com>
934
935         [Win] Skip failing JSC tests following r175078
936         https://bugs.webkit.org/show_bug.cgi?id=130967.
937
938         * Scripts/run-javascriptcore-tests:
939
940 2014-10-22  Jake Nielsen  <jacob_nielsen@apple.com>
941
942         commitqueuetask_unittest.py should be made more concise.
943         https://bugs.webkit.org/show_bug.cgi?id=137985
944
945         Reviewed by Alexey Proskuryakov.
946
947         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
948         Refactors tests to use MockSimpleTestPlanCommitQueue where possible.
949         (MockCommitQueue.__init__):
950         (MockCommitQueue.report_flaky_tests):
951         (MockCommitQueue):
952         (MockCommitQueue.get_reported_flaky_tests):
953         (MockSimpleTestPlanCommitQueue.__init__):
954         (MockSimpleTestPlanCommitQueue.run_command):
955         (MockSimpleTestPlanCommitQueue.did_run_clean_tests):
956         (CommitQueueTaskTest._run_and_expect_patch_analysis_result):
957         (test_land_failure):
958         (test_failed_archive):
959         (test_double_flaky_test_failure):
960         (test_test_failure):
961         (test_red_test_failure):
962         (test_very_red_tree_retry):
963         (test_red_tree_patch_rejection):
964         (test_one_flaky_test):
965         (test_tree_more_red_than_patch):
966         (MockCommitQueue.test_results): Deleted.
967         (test_simple_flaky_test_failure): Deleted.
968         (_expect_validate): Deleted.
969         (_expect_validate.MockDelegate): Deleted.
970         (_expect_validate.MockDelegate.refetch_patch): Deleted.
971         (_expect_validate.MockDelegate.expected_failures): Deleted.
972         (_mock_patch): Deleted.
973         (test_validate): Deleted.
974         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
975         Fixes a bug that slipped through the cracks prior to this change.
976         (PatchAnalysisTask._test_patch):
977
978 2014-10-22  Alexey Proskuryakov  <ap@apple.com>
979
980         Flakiness dashboard should support OS X Yosemite
981         https://bugs.webkit.org/show_bug.cgi?id=137986
982
983         Reviewed by Ryosuke Niwa.
984
985         * TestResultServer/app.yaml:
986         * TestResultServer/static-dashboards/builders.jsonp:
987         * TestResultServer/static-dashboards/flakiness_dashboard.js:
988
989 2014-10-22  Jake Nielsen  <jacob_nielsen@apple.com>
990
991         commitqueuetask should include more tests to ensure that the behavior
992         of PatchAnalysisTask._test_patch() is well defined
993         https://bugs.webkit.org/show_bug.cgi?id=137977
994
995         Reviewed by Alexey Proskuryakov.
996
997         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
998         Adds the MockSimpleTestPlanCommitQueue class, which makes it easier
999         and more readable to define tests that are meant to test the behaviour
1000         of PatchAnalysisTask._test_patch(), and adds several unit tests.
1001         (FailingTestCommitQueue.test_results):
1002         (PatchAnalysisResult):
1003         (MockSimpleTestPlanCommitQueue):
1004         (MockSimpleTestPlanCommitQueue.__init__):
1005         (MockSimpleTestPlanCommitQueue.run_command):
1006         (MockSimpleTestPlanCommitQueue._mock_test_result):
1007         (MockSimpleTestPlanCommitQueue.test_results):
1008         (CommitQueueTaskTest._run_and_expect_patch_analysis_result):
1009         (test_flaky_test_failure):
1010         (test_failed_archive):
1011         (test_two_flaky_tests):
1012         (test_one_flaky_test):
1013         (test_very_flaky_patch):
1014         (test_very_flaky_patch_with_some_tree_redness):
1015         (test_different_test_failures):
1016         (test_different_test_failures_with_some_tree_redness):
1017         (test_mildly_flaky_patch):
1018         (test_mildly_flaky_patch_with_some_tree_redness):
1019         (test_tree_more_red_than_patch):
1020
1021 2014-10-22  Jake Nielsen  <jacob_nielsen@apple.com>
1022
1023         PatchAnalysisTask._test_patch() needs refactoring
1024         https://bugs.webkit.org/show_bug.cgi?id=137904
1025
1026         Reviewed by Alexey Proskuryakov.
1027
1028         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1029         Fixes several small bugs, and makes minor changes to accomodate the
1030         changes in PatchAnalysisTask.
1031         (MockCommitQueue.refetch_patch):
1032         (MockCommitQueue.test_results):
1033         (test_flaky_test_failure):
1034         (test_failed_archive):
1035         (test_very_red_tree_retry):
1036         (_expect_validate.MockDelegate.refetch_patch):
1037         (MockCommitQueue.expected_failures): Deleted.
1038         (_expect_validate.MockDelegate.expected_failures): Deleted.
1039         * Scripts/webkitpy/tool/bot/expectedfailures.py: Removed.
1040         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py: Removed.
1041         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1042         Removes the unexpected_failures member, adds the _clean_tree_results
1043         member, adds a helper function for _test_patch, and refactors
1044         _test_patch to be more readable.
1045         (PatchAnalysisTask.__init__):
1046         (PatchAnalysisTask._continue_testing_patch_that_exceeded_failure_limit_on_first_or_second_try):
1047         (PatchAnalysisTask._test_patch):
1048         (PatchAnalysisTask.results_from_test_run_without_patch):
1049         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1050         Removes AbstractEarlyWarningSystem's dependancy on ExpectedFailures. 
1051         (AbstractEarlyWarningSystem.begin_work_queue):
1052         (AbstractEarlyWarningSystem._failing_tests_message):
1053         (AbstractEarlyWarningSystem.command_failed):
1054         (AbstractEarlyWarningSystem.expected_failures): Deleted.
1055         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1056         Makes changes to accomodate the changes made to PatchAnalysisTask.
1057         (AbstractEarlyWarningSystemTest.test_failing_tests_message):
1058         * Scripts/webkitpy/tool/commands/perfalizer.py:
1059         Removes Perfalizer's dependancy on ExpectedFailures. 
1060         (PerfalizerTask.refetch_patch):
1061         (PerfalizerTask.expected_failures): Deleted.
1062         * Scripts/webkitpy/tool/commands/queues.py:
1063         Removes CommitQueue's dependancy on ExpectedFailures, and adds an
1064         initializer to allow for mock injection.
1065         (CommitQueue.__init__):
1066         (CommitQueue.begin_work_queue):
1067         (CommitQueue.process_work_item):
1068         (CommitQueue._failing_tests_message):
1069         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1070         Removes dependancy on ExpectedFailures, and instead uses mock
1071         injection.
1072         (MockCommitQueueTask):
1073         (MockCommitQueueTask.results_from_patch_test_run):
1074         (MockCommitQueueTask.results_from_test_run_without_patch):
1075         (mock_run_webkit_patch):
1076
1077 2014-10-22  Rohit Kumar  <kumar.rohit@samsung.com>
1078
1079         [EFL][WK2] Minibrowser : Add support for mouse middle button to open links in new window
1080         https://bugs.webkit.org/show_bug.cgi?id=136736
1081
1082         Reviewed by Gyuyoung Kim.
1083
1084         * MiniBrowser/efl/main.c:
1085         (on_navigation_policy_decision): Check whether it's a link clicked with the middle mouse button and load the request in a new window.
1086         (window_create):
1087
1088 2014-10-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1089
1090         [GTK] Move GtkInputMethodFilter from Platform to WebKit2
1091         https://bugs.webkit.org/show_bug.cgi?id=137884
1092
1093         Reviewed by Gustavo Noronha Silva.
1094
1095         Move InputMethodFilter test from WebCore tests to WebKit2 tests
1096         and adapt it to use the new InputMethodFilter WebKit class. Instead
1097         of having virtual methods just for testing, it has a testing mode
1098         that logs the events.
1099
1100         * TestWebKitAPI/PlatformGTK.cmake:
1101         * TestWebKitAPI/Tests/WebKit2/gtk/InputMethodFilter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/gtk/InputMethodFilter.cpp.
1102         (TestWebKitAPI::TestInputMethodFilter::TestInputMethodFilter):
1103         (TestWebKitAPI::TestInputMethodFilter::~TestInputMethodFilter):
1104         (TestWebKitAPI::TestInputMethodFilter::sendKeyEventToFilter):
1105         (TestWebKitAPI::TestInputMethodFilter::sendPressAndReleaseKeyEventPairToFilter):
1106         (TestWebKitAPI::TEST):
1107         (TestWebKitAPI::temporaryGetPreeditStringOverride):
1108         (TestWebKitAPI::temporaryResetOverride):
1109         (TestWebKitAPI::verifyCanceledComposition):
1110
1111 2014-10-21  Alexey Proskuryakov  <ap@apple.com>
1112
1113         build.webkit.org/dashboard: Cannot click on green tester bubbles
1114         https://bugs.webkit.org/show_bug.cgi?id=137909
1115
1116         Reviewed by Darin Adler.
1117
1118         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1119         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1120
1121 2014-10-21  Brent Fulgham  <bfulgham@apple.com>
1122
1123         [Win] Run DumpRenderTree using native controls, not SafariTheme.dll.
1124         https://bugs.webkit.org/show_bug.cgi?id=137932
1125
1126         Reviewed by Simon Fraser.
1127
1128         This is the first step in moving over to native Windows rendering for our layout tests.
1129         Once this change lands, approximately 300 tests will start failing on Windows. I will
1130         rebaseline these changes against our test hardware and update this bug with the
1131         commits related to that work.
1132
1133         * DumpRenderTree/win/DumpRenderTree.cpp:
1134         (resetDefaultsToConsistentValues): Call 'setShouldPaintNativeControls(TRUE)' so that
1135         we use native Windows drawing style.
1136
1137 2014-10-21  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
1138
1139         Fix FTL Native Inlining for EFL
1140         https://bugs.webkit.org/show_bug.cgi?id=137774
1141
1142         Reviewed by Michael Saboff.
1143
1144         Added Clang as an optional module to jhbuild.
1145
1146         * efl/jhbuild.modules:
1147
1148 2014-10-20  Michael Catanzaro  <mcatanzaro@igalia.com>
1149
1150         Change the default TLS errors policy to WEBKIT_TLS_ERRORS_POLICY_FAIL
1151         https://bugs.webkit.org/show_bug.cgi?id=137832
1152
1153         Reviewed by Carlos Garcia Campos.
1154
1155         Ensure each test sets the TLS errors policy that it really needs.
1156         Have each test except testTLSErrorsPolicy stash and restore the original
1157         TLS errors policy. Update testTLSErrorsPolicy to account for the new
1158         default policy.
1159
1160         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
1161         (testSSL):
1162         (testInsecureContent):
1163         (testTLSErrorsPolicy):
1164         (testTLSErrorsRedirect):
1165         (testTLSErrorsHTTPAuth):
1166         (testLoadFailedWithTLSErrors):
1167         (beforeAll):
1168
1169 2014-10-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1170
1171         Unreviewed. Unskip inspector server unit tests.
1172
1173         They should pass now.
1174
1175         * Scripts/run-gtk-tests:
1176         (TestRunner):
1177
1178 2014-10-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1179
1180         [GTK] Test TestWebKitAPI/WebKit2Gtk/TestInspectorServer fails
1181         https://bugs.webkit.org/show_bug.cgi?id=132044
1182
1183         Reviewed by Brian Burg.
1184
1185         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
1186         (openRemoteDebuggingSession): Remove trailing slash when
1187         concatenating base inspector URL with the page, because the
1188         inspector returns the relative paths with a leading slash.
1189
1190 2014-10-20  Tanay C  <tanay.c@samsung.com>
1191
1192         [EFL][WK2] Minibrowser : Add support for Case sensitive and word start search
1193         https://bugs.webkit.org/show_bug.cgi?id=137023
1194
1195         Reviewed by Gyuyoung Kim.
1196
1197         * MiniBrowser/efl/main.c: Added functionality to support case sensitive and word start search
1198         (search_box_show): Modified.
1199         (search_box_hide): Modified.
1200         (on_search_field_activated): Modified.
1201         (on_search_backward_button_clicked): Modified.
1202         (on_search_forward_button_clicked): Modified.
1203         (on_search_case_option_changed): Added.
1204         (on_search_word_start_option_changed): Added.
1205         (window_create): Modified.
1206
1207 2014-10-20  Tanay C  <tanay.c@samsung.com>
1208
1209         [GTK][Minibrowser] Escape key does not hide the search box
1210         https://bugs.webkit.org/show_bug.cgi?id=137734
1211
1212         Reviewed by Philippe Normand.
1213
1214         * MiniBrowser/gtk/BrowserWindow.c: Added the check to handle search box hide
1215         (stopPageLoad): Modified.
1216
1217 2014-10-18  Antti Koivisto  <antti@apple.com>
1218
1219         REGRESSION (r173356): Safari can't install a profile, gets 'Download Failed error
1220         https://bugs.webkit.org/show_bug.cgi?id=137855
1221
1222         Reviewed by Dan Bernstein.
1223
1224         Test and warn if the dumped response mime type differs from the platform response mime type.
1225
1226         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1227         (WTR::InjectedBundlePage::didReceiveResponseForResource):
1228         (WTR::InjectedBundlePage::platformResponseMimeType):
1229         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1230         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
1231         (WTR::InjectedBundlePage::platformResponseMimeType):
1232
1233 2014-10-17  Joseph Pecoraro  <pecoraro@apple.com>
1234
1235         Remove run-inspector-perf-tests.py there is no PerformanceTests/inspector anymore
1236         https://bugs.webkit.org/show_bug.cgi?id=137835
1237
1238         Reviewed by Andreas Kling.
1239
1240         * Scripts/run-inspector-perf-tests.py: Removed.
1241         This script is stale, as PerformanceTests/inspector no longer exists.
1242
1243 2014-10-17  Simon Fraser  <simon.fraser@apple.com>
1244
1245         Fix typo: should be ios-simulator-wk2, not ios-simulator_wk2.
1246
1247         * Scripts/webkitpy/port/ios.py:
1248         (IOSSimulatorPort.default_baseline_search_path):
1249
1250 2014-10-17  Simon Fraser  <simon.fraser@apple.com>
1251
1252         [iOS] Simplify test fallback paths for iOS Simulator testing
1253         https://bugs.webkit.org/show_bug.cgi?id=137830
1254
1255         Reviewed by Zalan Bujtas.
1256         
1257         Make the fallback paths be:
1258             ios-simulator -> generic
1259             ios-simulator-wk2->ios-simulator -> generic
1260         
1261         so don't include mac in the fallback path. Also remove the
1262         version handling for simplicity.
1263
1264         * Scripts/webkitpy/port/ios.py:
1265         (IOSSimulatorPort):
1266         (IOSSimulatorPort.default_baseline_search_path):
1267
1268 2014-10-17  Dana Burkart  <dburkart@apple.com>
1269
1270         Fix typos in the dashboard config file.
1271
1272         Unreviewed.
1273
1274         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1275         (WebKitBuildbot):
1276
1277 2014-10-17  Brent Fulgham  <bfulgham@apple.com>
1278
1279         [Win] Allow WinLauncher to specify Custom User Agent strings
1280         https://bugs.webkit.org/show_bug.cgi?id=137828
1281
1282         Reviewed by Dean Jackson.
1283
1284         * WinLauncher/Common.cpp: Add support for custom user agent strings.
1285         * WinLauncher/WinLauncher.cpp: Add some convenience methods to get
1286         and set the user agent strings.
1287         * WinLauncher/WinLauncher.h:
1288         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Add new menu
1289         resources and dialog for setting custom User Agent strings.
1290         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h:
1291
1292 2014-10-16  Simon Fraser  <simon.fraser@apple.com>
1293
1294         [iOS] Turn off font autosizing for iOS WebKitTestRunner
1295         https://bugs.webkit.org/show_bug.cgi?id=137806
1296
1297         Reviewed by Sam Weinig.
1298
1299         Confusingly, WKPreferencesSetTextAutosizingEnabled() does nothing on iOS.
1300         Instead, we have to add WKPreferencesSetMinimumZoomFontSize() and set it to 0
1301         to disable font autosizing.
1302         
1303         Add platformResetPreferencesToConsistentValues() and implement it in the iOS
1304         test controller to set platform-specific prefs.
1305
1306         * WebKitTestRunner/TestController.cpp:
1307         (WTR::TestController::resetPreferencesToConsistentValues):
1308         (WTR::TestController::platformResetPreferencesToConsistentValues):
1309         * WebKitTestRunner/TestController.h:
1310         * WebKitTestRunner/ios/TestControllerIOS.mm:
1311         (WTR::TestController::platformResetPreferencesToConsistentValues):
1312         * WebKitTestRunner/mac/TestControllerMac.mm:
1313         (WTR::TestController::platformResetPreferencesToConsistentValues):
1314
1315 2014-10-16  Dan Bernstein  <mitz@apple.com>
1316
1317         OSObjectPtr is missing leakRef()
1318         https://bugs.webkit.org/show_bug.cgi?id=137798
1319
1320         Reviewed by Sam Weinig.
1321
1322         * TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp:
1323         (TestWebKitAPI::TEST(OSObjectPtr, LeakRef)): Added.
1324
1325 2014-10-16  Lucas Forschler  <lforschler@apple.com>
1326
1327         Update target platform to remove Leopard, Snow Leopard, Lion.
1328         Add Yosemite. 
1329         
1330         Unreviewed.
1331
1332         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
1333         (_should_file_trigger_build):
1334
1335 2014-10-16  David Kilzer  <ddkilzer@apple.com>
1336
1337         commit-queue: fails to replace OO-PS! with reviewer name
1338         <http://webkit.org/b/137795>
1339
1340         Reviewed by Alexey Proskuryakov.
1341
1342         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1343         (Bugzilla.fetch_bug_dictionary): Bugzilla 4.2.x never gives out
1344         email addresses to unauthenticated page loads, so we must always
1345         authenticate before getting bug data so we get full email
1346         addresses.
1347
1348 2014-10-16  David Kilzer  <ddkilzer@apple.com>
1349
1350         commit-queue: fails to close bugs after successfully landing patches
1351         <http://webkit.org/b/137794>
1352
1353         Reviewed by Alexey Proskuryakov.
1354
1355         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1356         (Bugzilla.clear_attachment_flags): Change 'nr=0' to 'nr=1' to
1357         tell Mechanize to use the second <textarea> on the page with
1358         name="comment".
1359
1360 2014-10-16  Brent Fulgham  <bfulgham@apple.com>
1361
1362         [Win] Update DRT to match Mac Logic
1363         https://bugs.webkit.org/show_bug.cgi?id=137787
1364
1365         Reviewed by Dean Jackson.
1366
1367         * DumpRenderTree/win/DumpRenderTree.cpp:
1368         (initialize): 0 -> nullptr
1369         (runTest): Initialize MSG structure before using.
1370         (main): Add CRT debug flags if building DRT with debug malloc on Windows.
1371         Also, cleanly shut down COM when exiting.
1372         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1373         (FrameLoadDelegate::didChangeLocationWithinPageForFrame): Move from
1374         header and add printf to match Mac.
1375         (FrameLoadDelegate::windowScriptObjectAvailable): Ditto.
1376         * DumpRenderTree/win/FrameLoadDelegate.h:
1377         (FrameLoadDelegate::didChangeLocationWithinPageForFrame): Deleted.
1378         (FrameLoadDelegate::windowScriptObjectAvailable): Deleted.
1379         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1380         (isLocalhost): Added.
1381         (hostIsUsedBySomeTestsToGenerateError): Added.
1382         (ResourceLoadDelegate::willSendRequest): Add logic to mimic Mac's use
1383         of certain error and redirect host names.
1384         * DumpRenderTree/win/UIDelegate.cpp:
1385         (UIDelegate::runJavaScriptAlertPanelWithMessage): Use 'done' flag to decide if
1386         anything should be output to the console. This modifies behavior to match the Mac.
1387         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Ditto.
1388         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Ditto.
1389         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage): Ditto.
1390         (UIDelegate::webViewAddMessageToConsole): Ditto.
1391         * WinLauncher/PageLoadTestClient.cpp:
1392         (PageLoadTestClient::pageLoadEndedAtTime): Drive-by-fix for an assertion that I
1393         added last week.
1394
1395 2014-10-16  Commit Queue  <commit-queue@webkit.org>
1396
1397         Unreviewed, rolling out r174754.
1398         https://bugs.webkit.org/show_bug.cgi?id=137789
1399
1400         Speculative fix for Windows test was ineffective. (Requested
1401         by rfong on #webkit).
1402
1403         Reverted changeset:
1404
1405         "[Windows] Add some more logging to debug Windows test
1406         issues."
1407         http://trac.webkit.org/changeset/174754
1408
1409 2014-10-15  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1410
1411         Unreviewed, add myself to CoordinatedGraphics watchers.
1412
1413         * Scripts/webkitpy/common/config/watchlist:
1414
1415 2014-10-15  Roger Fong  <roger_fong@apple.com>
1416
1417         [Windows] Speculative Windows test fix.
1418
1419         * DumpRenderTree/win/DumpRenderTree.cpp: Make sure that OLEAUT32.dll doesn't cache BSTRs.
1420
1421 2014-10-15  Rebecca Hauck  <rhauck@adobe.com>
1422
1423         import-w3c-test rewrites relative src paths in ref files incorrectly
1424         https://bugs.webkit.org/show_bug.cgi?id=137586
1425
1426         This patch fixes a bug in test_converter.py where src paths were getting 
1427         rewritten as ../../some-path instead of <script src="../../some-path>". 
1428         It also adds support for rewriting src paths in style  elements, which was 
1429         missing before and it adds tests for this case.
1430
1431         Reviewed by Bem Jones-Bey.
1432
1433         * Scripts/webkitpy/w3c/test_converter.py:
1434         (_W3CTestConverter.convert_attributes_if_needed):
1435         * Scripts/webkitpy/w3c/test_converter_unittest.py:
1436         (test_convert_attributes_if_needed):
1437         (verify_reference_relative_paths):
1438
1439 2014-10-15  Jake Nielsen  <jacob_nielsen@apple.com>
1440
1441         Add --json flag to test-webkitpy to emit JSON formatted test results
1442         to stdout
1443         https://bugs.webkit.org/show_bug.cgi?id=137353
1444
1445         Reviewed by Daniel Bates.
1446
1447         * Scripts/webkitpy/port/server_process_unittest.py:
1448         Adds the read method to MockFile to allow the stdout of test_webkitpy
1449         to be redirected without causing erroneous test failures.
1450         In particular,
1451         webkitpy.port.server_process_unittest.TestServerProcess.test_broken_pipe
1452         and
1453         webkitpy.port.server_process_unittest.TestServerProcess.test_cleanup
1454         because when redirecting to a file, the
1455         _wait_for_data_and_update_buffers_using_select method in 
1456         server_process.py will find that there is a read file descriptor in
1457         its call to select.select, which eventually leads to it calling read()
1458         on the MockFile object.
1459         (MockFile.read):
1460         * Scripts/webkitpy/test/main.py:
1461         Adds the _print_results_as_json method and the --json flag which
1462         determines whether _print_results_as_json will get called.
1463         (Tester._parse_args):
1464         (Tester._print_results_as_json):
1465         (Tester._print_results_as_json.result_dict_from_tuple):
1466         (Tester._run_tests):
1467
1468 2014-10-13  David Farler  <dfarler@apple.com>
1469
1470         [iOS] LayoutTestRelay: Detect broken pipe when reading simulator app's stdout and stderr.
1471         https://bugs.webkit.org/show_bug.cgi?id=137662
1472
1473         Reviewed by Darin Adler.
1474
1475         The layout test harness can close LayoutTestRelay's subprocess
1476         stdout and stderr in the case of a timeout or if a run is
1477         cancelled and the FIFOs are cleaned up. If LayoutTestRelay
1478         finds that no one is listening to its stdout/stderr (broken
1479         pipe), then just exit(1), there is nothing to report.
1480
1481         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
1482         (-[LTRelayController didReceiveStdoutData:]):
1483         Add @try/@catch for NSFileHandleOperationException.
1484         (-[LTRelayController didReceiveStderrData:]):
1485         Add @try/@catch for NSFileHandleOperationException.
1486
1487 2014-10-15  Rohit Kumar  <kumar.rohit@samsung.com>
1488
1489         [GTK] Minibrowser : Add keyboard support for zoom in , zoom out and default zoom in GTK Minibrowser
1490         https://bugs.webkit.org/show_bug.cgi?id=137060
1491
1492         Reviewed by Philippe Normand.
1493
1494         Add keyboard support for zoom in , zoom out and default zoom using 'Ctrl' + '+', 'Ctrl' + '-' and 'Ctrl' + '0' respectively.
1495
1496         * MiniBrowser/gtk/BrowserWindow.c:
1497         (zoomInCallback):
1498         (zoomOutCallback):
1499         (defaultZoomCallback): Callback for default zoom keyboard support.
1500         (browser_window_init):
1501
1502 2014-10-14  Simon Fraser  <simon.fraser@apple.com>
1503
1504         [Mac] DRT stderr logging after the test completes gets attributed to the next test
1505
1506         Reviewed by Alexey Proskuryakov.
1507         
1508         DRT would send "#EOF" to stderr just after doing so to stdout, which cause any later
1509         logging to stderr to get associated with the next test.
1510         
1511         Fix by logging #EOF to stderr later, after we've completely finished with this test.
1512
1513         * DumpRenderTree/mac/DumpRenderTree.mm:
1514         (dumpTestResults):
1515         (runTest):
1516
1517 2014-10-14  Brent Fulgham  <bfulgham@apple.com>
1518
1519         [Win] Unreviewed gardening. Ignore Visual Studio *.sdf temporary files.
1520
1521         * DumpRenderTree/DumpRenderTree.vcxproj: Modified property svn:ignore.
1522
1523 2014-10-14  Csaba Osztrogonác  <ossy@webkit.org>
1524
1525         [cmake] Fix the make build after r174683
1526         https://bugs.webkit.org/show_bug.cgi?id=137703
1527
1528         Reviewed by Martin Robinson.
1529
1530         * Scripts/webkitdirs.pm:
1531         (buildCMakeGeneratedProject):
1532
1533 2014-10-14  Myles C. Maxfield  <mmaxfield@apple.com>
1534
1535         Adding myself to the watchlist to CachedFont
1536
1537         Unreviewed.
1538
1539         * Scripts/webkitpy/common/config/watchlist:
1540
1541 2014-10-14  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1542
1543         [EFL][GTK] Make it possible to get verbose output with ninja
1544         https://bugs.webkit.org/show_bug.cgi?id=137606
1545
1546         Reviewed by Csaba Osztrogonác.
1547
1548         * Scripts/webkitdirs.pm:
1549         (buildCMakeGeneratedProject):
1550
1551 2014-10-14  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1552
1553         [EFL] Make it possible to use ninja for EFL build too
1554         https://bugs.webkit.org/show_bug.cgi?id=137605
1555
1556         Reviewed by Csaba Osztrogonác.
1557
1558         * Scripts/webkitdirs.pm:
1559         (generateBuildSystemFromCMakeProject):
1560         * efl/install-dependencies:
1561
1562 2014-10-14  Rohit Kumar  <kumar.rohit@samsung.com>
1563
1564         [GTK] Minibrowser : Add home buton and keyboard support for home page load
1565         https://bugs.webkit.org/show_bug.cgi?id=137486
1566
1567         Reviewed by Philippe Normand.
1568
1569         * MiniBrowser/gtk/BrowserWindow.c:
1570         (loadHomePage): Callback for home page load.
1571         (browser_window_init):
1572         * MiniBrowser/gtk/BrowserWindow.h:
1573         * MiniBrowser/gtk/main.c:
1574         (main):
1575
1576 2014-10-14  Manuel Rego Casasnovas  <rego@igalia.com>
1577
1578         import-w3c-tests doesn't prefix property values
1579         https://bugs.webkit.org/show_bug.cgi?id=137600
1580
1581         Reviewed by Bem Jones-Bey.
1582
1583         Some property values are prefixed in WebKit. Modified the W3C import
1584         script in order to prefix property values and not only properties.
1585         The patch re-uses most of the already existent logic to prefix
1586         properties.
1587
1588         * Scripts/webkitpy/w3c/test_converter.py: Read prefixed property values
1589         from CSSValueKeywords.in and adapt converter to modify both properties
1590         and property values.
1591         (convert_for_webkit):
1592         (_W3CTestConverter.__init__):
1593         (_W3CTestConverter.output):
1594         (_W3CTestConverter.read_webkit_prefixed_css_property_list):
1595         (_W3CTestConverter):
1596         (_W3CTestConverter.add_webkit_prefix_to_unprefixed_properties_and_values):
1597         (_W3CTestConverter.add_webkit_prefix_following_regex):
1598         (_W3CTestConverter.convert_reference_relpaths):
1599         (_W3CTestConverter.convert_style_data):
1600         (_W3CTestConverter.convert_attributes_if_needed):
1601         (_W3CTestConverter.add_webkit_prefix_to_unprefixed_properties): Deleted.
1602         * Scripts/webkitpy/w3c/test_converter_unittest.py: Updated unit test to
1603         include checks for property values too.
1604         (W3CTestConverterTest.test_read_prefixed_property_list):
1605         (verify_no_conversion_happened):
1606         (verify_prefixed_properties):
1607         (verify_prefixed_property_values):
1608         (generate_test_content_properties_and_values):
1609         (generate_test_content):
1610         * Scripts/webkitpy/w3c/test_importer.py: Modified importer to manage
1611         prefixed property values and inform about them.
1612         (TestImporter.import_tests):
1613         (TestImporter.write_import_log):
1614
1615 2014-10-13  Jer Noble  <jer.noble@apple.com>
1616
1617         MediaPlayer::characteristicChanged() is not called when new tracks are found in SourceBufferPrivateAVFObjC
1618         https://bugs.webkit.org/show_bug.cgi?id=137533
1619
1620         Reviewed by Andy Estes.
1621
1622         Follow up patch; bail out of the test early (without failing) if the platform does not support MSE.
1623
1624         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
1625         (TestWebKitAPI::isMSEEnabledCallback):
1626         (TestWebKitAPI::TEST):
1627
1628 2014-10-13  Brent Fulgham  <bfulgham@apple.com>
1629
1630         [Win] Implement a page load profiling tool
1631         https://bugs.webkit.org/show_bug.cgi?id=137673
1632
1633         Reviewed by Dean Jackson.
1634
1635         Add a tool to capture and summarize page load statistics.
1636
1637         * WinLauncher/Common.cpp:
1638         (parseCommandLine): Move from WinMain.cpp so that it can
1639         be shared with internal tools.
1640         * WinLauncher/PageLoadTestClient.cpp: Added.
1641         (PageLoadTestClient::PageLoadTestClient):
1642         (PageLoadTestClient::pageLoadStartedAtTime):
1643         (PageLoadTestClient::didStartProvisionalLoad):
1644         (PageLoadTestClient::didCommitLoad):
1645         (PageLoadTestClient::didFirstLayoutForMainFrame):
1646         (PageLoadTestClient::didHandleOnLoadEvents):
1647         (PageLoadTestClient::didFinishLoad):
1648         (PageLoadTestClient::didFailLoad):
1649         (PageLoadTestClient::didInitiateResourceLoad):
1650         (PageLoadTestClient::didEndResourceLoad):
1651         (PageLoadTestClient::pageLoadEndedAtTime):
1652         (PageLoadTestClient::endPageLoad):
1653         (PageLoadTestClient::clearPageLoadState):
1654         (PageLoadTestClient::shouldConsiderPageLoadEnded):
1655         (PageLoadTestClient::maybeEndPageLoadSoon):
1656         (PageLoadTestClient::setPageURL):
1657         (PageLoadTestClient::dumpRunStatistics):
1658         * WinLauncher/PrintWebUIDelegate.cpp:
1659         (PrintWebUIDelegate::createWebViewWithRequest): Handle
1660         nullptr URL properly.
1661         * WinLauncher/ResourceLoadDelegate.cpp: Added.
1662         (ResourceLoadDelegate::QueryInterface):
1663         (ResourceLoadDelegate::AddRef):
1664         (ResourceLoadDelegate::Release):
1665         (ResourceLoadDelegate::identifierForInitialRequest):
1666         (ResourceLoadDelegate::willSendRequest):
1667         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
1668         (ResourceLoadDelegate::didCancelAuthenticationChallenge):
1669         (ResourceLoadDelegate::didReceiveResponse):
1670         (ResourceLoadDelegate::didReceiveContentLength):
1671         (ResourceLoadDelegate::didFinishLoadingFromDataSource):
1672         (ResourceLoadDelegate::didFailLoadingWithError):
1673         (ResourceLoadDelegate::plugInFailedWithError):
1674         * WinLauncher/ResourceLoadDelegate.h: Added.
1675         (ResourceLoadDelegate::ResourceLoadDelegate):
1676         * WinLauncher/WinLauncher.cpp:
1677         (WinLauncher::WinLauncher): Accept argument to indicate we want to capture
1678         page loading statistics.
1679         (WinLauncher::setFrameLoadDelegatePrivate): Get rid of stub implementation
1680         and set private load delegate state.
1681         (WinLauncher::setResourceLoadDelegate): Replace stub with a full implementation
1682         that sets the view's resource load delegate.
1683         (WinLauncher::loadURL): If no URL is passed, load the test document.
1684         * WinLauncher/WinLauncher.h:
1685         (WinLauncher::pageLoadTestClient):
1686         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Updated for new source files.
1687         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: Ditto.
1688         * WinLauncher/WinLauncherWebHost.cpp:
1689         (WinLauncherWebHost::updateAddressBar): Hook into page load statistics routine.
1690         (WinLauncherWebHost::loadURL): Moved 'SendMessage' call to its own method so that
1691         it could be used from other source files.
1692         (WinLauncherWebHost::didFinishLoadForFrame): Added overload to capture statistics.
1693         (WinLauncherWebHost::didStartProvisionalLoadForFrame): Ditto.
1694         (WinLauncherWebHost::didFailLoadWithError): Ditto.
1695         (WinLauncherWebHost::didHandleOnloadEventsForFrame): Ditto.
1696         (WinLauncherWebHost::didFirstLayoutInFrame): Ditto.
1697         (WinLauncherWebHost::didFinishDocumentLoadForFrame): Ditto.
1698         (WinLauncherWebHost::didFirstVisuallyNonEmptyLayoutInFrame): Ditto.
1699         (WinLauncherWebHost::didStartProvisionalLoadForFrame): Deleted.
1700         * WinLauncher/WinLauncherWebHost.h:
1701         * WinLauncher/WinMain.cpp:
1702         (wWinMain): Create and use new delegates for gathering page load data.
1703         * WinLauncher/stdafx.h: Need to add <wtf/Platform> include for various macros used in build.
1704
1705 2014-10-13  Simon Fraser  <simon.fraser@apple.com>
1706
1707         Improve the test image diffs page
1708         https://bugs.webkit.org/show_bug.cgi?id=137674
1709
1710         Reviewed by Alexey Proskuryakov.
1711         
1712         Don't treat the input file as a format string, otherwise we have to escape special
1713         characters. Just do a couple of replaces.
1714
1715         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1716         (TestResultWriter.write_image_diff_files):
1717
1718 2014-10-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1719
1720         [XvfbDriver] Regular expression used to match running X servers fails on Fedora 21.
1721         https://bugs.webkit.org/show_bug.cgi?id=137659
1722
1723         Reviewed by Martin Robinson.
1724
1725         * Scripts/webkitpy/port/xvfbdriver.py:
1726         (XvfbDriver._next_free_display): Update the regular expression to also match Xorg.bin
1727
1728 2014-10-13  Alexey Proskuryakov  <ap@apple.com>
1729
1730         Add more detailed wait time information to EWS metrics
1731         https://bugs.webkit.org/show_bug.cgi?id=137649
1732
1733         Reviewed by Daniel Bates.
1734
1735         Added average and worst time (we used to only have median), and also a percentage
1736         of patches that took a non-trivial time to start. Non-trivial is defined as 3 minutes.
1737
1738         There is always some wait due to the polling nature of the queues, which is well understood
1739         and doesn't need to be measured. What needs to be measured is whether there is enough
1740         bot machines to process patches as soon as they are submitted.
1741
1742         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
1743         (Analyzer.prototype._analyzeBubblePerformance):
1744         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js:
1745         (MetricsBubbleView.prototype._update):
1746
1747 2014-10-11  Jer Noble  <jer.noble@apple.com>
1748
1749         MediaPlayer::characteristicChanged() is not called when new tracks are found in SourceBufferPrivateAVFObjC
1750         https://bugs.webkit.org/show_bug.cgi?id=137533
1751
1752         Reviewed by Darin Adler.
1753
1754         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1755         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
1756         (TestWebKitAPI::TEST):
1757         * TestWebKitAPI/Tests/WebKit2/file-with-mse.html: Added.
1758         * TestWebKitAPI/Tests/WebKit2/test-mse.mp4: Added.
1759
1760 2014-10-13  Simon Fraser  <simon.fraser@apple.com>
1761
1762         iOS DRT snapshots are limited to the page visible area
1763         https://bugs.webkit.org/show_bug.cgi?id=137650
1764
1765         Reviewed by Daniel Bates.
1766         
1767         LegacyTileCache drawing was limited to the window's visible area, found by
1768         crawling up the layer hierarchy to the root layer. This caused test snapshots to
1769         be missing non-composited content outside the iPhone visible area, which hinders
1770         testing.
1771         
1772         Fix by adding a test-only mode where the window visible area is the entire window.
1773         
1774         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
1775         (dumpWebViewAsPixelsAndCompareWithExpected): Drive-by RetainPtr fix.
1776         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1777         (-[DumpRenderTreeWindow initWithLayer:]): Call setEntireWindowVisibleForTesting:YES
1778         for the DRT window.
1779         
1780
1781 2014-10-12  Simon Fraser  <simon.fraser@apple.com>
1782
1783         Page not fully rendered in iOS DRT snapshots
1784         https://bugs.webkit.org/show_bug.cgi?id=137638
1785
1786         Reviewed by Tim Horton.
1787         
1788         In iOS DumpRenderTree, we need to wait for a cycle of the WebThread runloop
1789         to ensure that the page has laid out and is rendered by the time we take
1790         the snapshot.
1791
1792         * DumpRenderTree/mac/DumpRenderTree.mm:
1793         (-[DumpRenderTree _webThreadEventLoopHasRun]): Moved.
1794         (-[DumpRenderTree _webThreadInvoked]): Moved.
1795         (-[DumpRenderTree _waitForWebThreadThenDump]):
1796         (dump): Use a performSelectorOnMainThread:withObject:waitUntilDone:NO to wait
1797         for a cycle of the WebThrewd runloop. We can't just call _waitForWebThread because
1798         that blocks on a delegate callback, and we can't dispatch_async because _waitForWebThread
1799         relies on dispatch_async too, and the inner block won't complete until the outer block
1800         has completed.
1801         (dumpTestResults): Move the guts of dump() here.
1802         (runTest): Whitespace.
1803
1804 2014-10-12  Alexey Proskuryakov  <ap@apple.com>
1805
1806         Adding svn:ignore so that .pyc files don't show up as new.
1807
1808         * Scripts/webkitpy/xcode: Added property svn:ignore.
1809
1810 2014-10-12  Ryuan Choi  <ryuan.choi@gmail.com>
1811
1812         [EFL] Introduce EWebKit_Extension
1813         https://bugs.webkit.org/show_bug.cgi?id=134921
1814
1815         Reviewed by Gyuyoung Kim.
1816
1817         * MiniBrowser/efl/main.c: Added x option to test extension path.
1818         (window_create):
1819         (elm_main):
1820         * Scripts/webkitpy/common/config/watchlist:
1821         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFLWebKit2PublicAPI.
1822         * Scripts/webkitpy/style/checker.py:
1823         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFL exceptions.
1824
1825 2014-10-11  Simon Fraser  <simon.fraser@apple.com>
1826
1827         After r174628 we send the test process a SIGTERM before the SIGKILL.
1828
1829         * Scripts/webkitpy/common/system/executive_unittest.py:
1830         (ExecutiveTest.serial_test_kill_process):
1831
1832 2014-10-11  KwangHyuk Kim  <hyuki.kim@samsung.com>
1833
1834         [EFL] Enable WebP support.
1835         https://bugs.webkit.org/show_bug.cgi?id=136156
1836
1837         Reviewed by Gyuyoung Kim.
1838
1839         Include libwebp-dev package to support WebP for WK2 Efl.
1840
1841         * efl/install-dependencies:
1842
1843 2014-10-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1844
1845         [GLIB] Split GMainLoopSource moving thread safe implementation to its own class GThreadSafeMainLoopSource
1846         https://bugs.webkit.org/show_bug.cgi?id=137485
1847
1848         Reviewed by Sergio Villar Senin.
1849
1850         Update GMainLoopSource tests. Most of the tests are now run twice,
1851         first with a GMainLoopSource and then with a
1852         GThreadSafeMainLoopSource, since both should have the same
1853         behaviour. The threading test uses GThreadSafeMainLoopSource and
1854         the delete on destroy test uses GMainLoopSource. The tests
1855         themselves haven't changed, since there's no change in behaviour.
1856
1857         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp:
1858         (TestWebKitAPI::GMainLoopSourceTest::source):
1859         (TestWebKitAPI::basicRescheduling):
1860         (TestWebKitAPI::TEST):
1861         (TestWebKitAPI::reentrantRescheduling):
1862         (TestWebKitAPI::cancelRepeatingSourceDuringDispatch):
1863         (TestWebKitAPI::basicDestroyCallbacks):
1864         (TestWebKitAPI::destroyCallbacksAfterCancellingDuringDispatch):
1865         (TestWebKitAPI::destroyCallbacksAfterReschedulingDuringDispatch):
1866
1867 2014-10-10  Dana Burkart  <dburkart@apple.com>
1868
1869         Fix fat-fingered function name in git-add-reviewer.
1870
1871         Unreviewed.
1872
1873         * Scripts/git-add-reviewer:
1874         (getConfigValue):
1875
1876 2014-10-10  David Farler  <dfarler@apple.com>
1877
1878         [iOS] LayoutTestRelay should ensure its DRT/WKTR dies when receiving kill/term signals
1879         https://bugs.webkit.org/show_bug.cgi?id=137528
1880
1881         Reviewed by Simon Fraser.
1882
1883         Catch SIGINT and SIGTERM signals in the LayoutTestRelay
1884         and SIGKILL the paired simulator app before exiting cleanly.
1885
1886         webkitpy only uses SIGKILL to kill processes which you cannot
1887         catch. Send SIGTERM to the process and give it chance to do
1888         its thing before sending SIGKILL. Sending a SIGKILL to an already
1889         dead PID is safe.
1890
1891         * LayoutTestRelay/LayoutTestRelay/LTRelayController.h:
1892         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
1893         (-[LTRelayController finish]):
1894         * LayoutTestRelay/LayoutTestRelay/main.m:
1895         (receivedSignal):
1896         (main):
1897
1898 2014-10-10  David Farler  <dfarler@apple.com>
1899
1900         [iOS] LayoutTestRelay should detect EOF and properly signal underlying DRT/WKTR
1901         https://bugs.webkit.org/show_bug.cgi?id=137527
1902
1903         Reviewed by Simon Fraser.
1904
1905         NSFileHandle doesn't notify of EOF in its readability handler.
1906         Use a dispatch_source_t and an event handler that is called when reading is possible.
1907         In the handler block, do a run-of-the-mill read(2) from standard input and
1908         detect EOF in the usual way by checking that zero bytes were read.
1909
1910         Once an EOF is received, the FIFOs are disconnected, the simulator app
1911         is killed, and the relay exits with status 0.
1912
1913         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
1914         (-[LTRelayController initWithDevice:productDir:appPath:identifierSuffix:dumpToolArguments:]):
1915         (-[LTRelayController didDisconnect]):
1916         (-[LTRelayController didConnect]):
1917         (-[LTRelayController launchApp]):
1918         Rename "dispatchSource" to "simulatorAppExitDispatchSource" to prevent any
1919         confusion with this new dispatch source, called "standardInputDispatchSource".
1920         (-[LTRelayController finish]): Added.
1921         (-[LTRelayController readFileHandle:]): Deleted.
1922
1923 2014-10-10  KwangHyuk Kim  <hyuki.kim@samsung.com>
1924
1925         [EFL] Crash on facebook.com
1926         https://bugs.webkit.org/show_bug.cgi?id=137562
1927
1928         Reviewed by Chris Dumez.
1929
1930         Crash occurs on the facebook.com when the webview is resized
1931         after the <select> item is clicked but no item is chosen.
1932         This crash is just caused by the reference of invalidated variable.
1933         From the EwkView::closePopupMenu(), ewk_menu is just invalidated.
1934         Therefore ewk_menu variable is not available anymore when on_popup_menu_hide()
1935         on MiniBrowser is called.
1936         As a result, just set ewk_menu to NULL in order to prevent crash condition.
1937
1938         * MiniBrowser/efl/main.c:
1939         (on_popup_menu_hide):
1940
1941 2014-10-10  Alexey Proskuryakov  <ap@apple.com>
1942
1943         A small wording change for clarity.
1944
1945         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js:
1946         (MetricsBubbleView.prototype._update):
1947
1948 2014-10-10  Alexey Proskuryakov  <ap@apple.com>
1949
1950         Dashboard metrics page should have EWS statistics
1951         https://bugs.webkit.org/show_bug.cgi?id=137626
1952
1953         Reviewed by Ryosuke Niwa.
1954
1955         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueue.js:
1956         (BubbleQueue): Put shortName in the object, so that it's actually useful.
1957
1958         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1959         (BubbleQueueServer): Re-ordered queues to match bubble order.
1960         (BubbleQueueServer.prototype.jsonProcessingTimesURL): Added URL for the new handler.
1961         (BubbleQueueServer.prototype.loadProcessingTimes): Load the data from webkit-queues.
1962
1963         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
1964         Added analysis for bubble queues.
1965
1966         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js: Added.
1967
1968         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
1969         (buildBubbleQueuesTable): Build the UI.
1970
1971         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/metrics.html:
1972         Added JS sources to load.
1973
1974         * QueueStatusServer/app.yaml: To update app version.
1975
1976         * QueueStatusServer/handlers/processingtimesjson.py: Added.
1977
1978         * QueueStatusServer/main.py: Added a handler for processing-times-json.
1979
1980 2014-10-10  Alexey Proskuryakov  <ap@apple.com>
1981
1982         REGRESSION: Commit queue doesn't process rollouts
1983         https://bugs.webkit.org/show_bug.cgi?id=137623
1984
1985         Reviewed by Tim Horton.
1986
1987         * QueueStatusServer/app.yaml:
1988         * QueueStatusServer/handlers/updateworkitems.py:
1989         (UpdateWorkItems._work_items_from_request):
1990
1991 2014-10-10  Simon Fraser  <simon.fraser@apple.com>
1992
1993         Fix syntax error after r174601.
1994
1995         * Scripts/run-javascriptcore-tests:
1996
1997 2014-10-10  Michael Saboff  <msaboff@apple.com>
1998
1999         Add ability to select tarfile name in run-jsc-stress-tests
2000         https://bugs.webkit.org/show_bug.cgi?id=137614
2001
2002         Reviewed by Mark Hahnenberg.
2003
2004         Added optional file name argument to the --tarball option.  
2005
2006         * Scripts/run-javascriptcore-tests: Added "--" to terminate options so the first
2007         extra test given after the options wont be used for the optional tarball file name.
2008         * Scripts/run-jsc-stress-tests:
2009
2010 2014-10-10  Chris Dumez  <cdumez@apple.com>
2011
2012         Unreviewed, update my information in contributors.json
2013
2014         Use my preferred first name and update my expertise areas.
2015
2016         * Scripts/webkitpy/common/config/contributors.json:
2017
2018 2014-10-10  Adrien Destugues  <pulkomandy@gmail.com>
2019
2020         Fix perl scripts to run with env on Linux
2021         https://bugs.webkit.org/show_bug.cgi?id=137601
2022
2023         Reviewed by Csaba Osztrogonác.
2024
2025         Use of arguments in #! is nonstandard and does not behave the same on
2026         different systems. Linux would look for an executable named "perl -w" 
2027         "use warnings;" does the same things in a more portable way.
2028
2029         * Scripts/commit-log-editor:
2030         * Scripts/num-cpus:
2031         * Scripts/prepare-ChangeLog:
2032         * Scripts/run-launcher:
2033         * Scripts/svn-create-patch:
2034
2035 2014-10-10  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
2036
2037         [jhbuild] We should be able to disable wiping on configuration change
2038         https://bugs.webkit.org/show_bug.cgi?id=137446
2039
2040         Reviewed by Csaba Osztrogonác.
2041
2042         The default behaviour isn't changed, wiping on configuration change feature can be disabled with
2043         setting JHBUILD_WIPE_ON_CHANGE=0 environment variable
2044         or passing --no-wipe-on-change command line option.
2045
2046         * Scripts/update-webkit-libs-jhbuild:
2047
2048 2014-10-09  Andy Estes  <aestes@apple.com>
2049
2050         Teach webkitpy about OS X Yosemite
2051         https://bugs.webkit.org/show_bug.cgi?id=137585
2052
2053         Reviewed by Simon Fraser.
2054
2055         * Scripts/webkitpy/common/system/platforminfo.py:
2056         (PlatformInfo._determine_mac_version):
2057         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
2058         (TestPlatformInfo.test_os_version):
2059         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2060         (TestExpectationParser):
2061         * Scripts/webkitpy/port/builders.py:
2062         * Scripts/webkitpy/port/mac.py:
2063         (MacPort):
2064         * Scripts/webkitpy/port/mac_unittest.py:
2065         (test_versions):
2066         (test_baseline_search_path):
2067         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2068         (TestRebaselineTest.test_baseline_directory):
2069         (TestRebaselineExpectations.test_rebaseline_expectations):
2070
2071 2014-10-09  Dana Burkart  <dburkart@apple.com>
2072
2073         Add Mac OS Yosemite dashboard support.
2074
2075         Rubber-stamped by Lucas Forschler.
2076
2077         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Yosemite.png: Added.
2078         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Yosemite@2x.png: Added.
2079         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2080         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2081         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2082
2083 2014-10-08  Ryosuke Niwa  <rniwa@webkit.org>
2084
2085         Add Babak to contributors.json and add historical email addresses for some contributors
2086         https://bugs.webkit.org/show_bug.cgi?id=137546
2087
2088         Reviewed by Christophe Dumez.
2089
2090         contributors.json is used to analyze historical commit data and change logs.
2091
2092         Add back historical email addresses for some contributors and also add Babak (Shafiei).
2093
2094         * Scripts/webkitpy/common/config/contributors.json:
2095
2096 2014-10-09  Lucas Forschler  <lforschler@apple.com>
2097
2098         Add Mac OS Yosemite webkit build infrastructure.
2099         
2100         This patch adds 15 bots to our build.webkit.org configuration.
2101         We are matching the current Mavericks machines 1:1.
2102         
2103         This patch includes some minor spacing changes to the buildslaves section to make everything similar.
2104         
2105         Reviewed by Matt Hanson.
2106
2107         * BuildSlaveSupport/build.webkit.org-config/config.json:
2108
2109 2014-10-09  Dana Burkart  <dburkart@apple.com>
2110
2111         Don't use backticks when running commands, as we run into sh-related
2112         interpolation issues. Also, fix our usage of system() to properly
2113         retrieve the status code.
2114         https://bugs.webkit.org/show_bug.cgi?id=137541
2115
2116         Reviewed by Darin Adler.
2117
2118         * Scripts/git-add-reviewer:
2119         (interactive):
2120         (nonInteractive):
2121         (requireCleanWorkTree):
2122         (cherryPick):
2123         (commit):
2124         (addReviewerToFile):
2125         (head):
2126         (isAncestor):
2127         (toCommit):
2128         (changeLogsForCommit):
2129         (resetToCommit):
2130         (getConfigValue):
2131         (runCommandWithOutput):
2132
2133 2014-10-09  Tim Horton  <timothy_horton@apple.com>
2134
2135         Add a WebKit1 preference for selection services
2136         https://bugs.webkit.org/show_bug.cgi?id=137498
2137         <rdar://problem/18572699>
2138
2139         Reviewed by Simon Fraser.
2140
2141         * MiniBrowser/mac/WK1BrowserWindowController.m:
2142         (-[WK1BrowserWindowController awakeFromNib]):
2143         Turn on image and selection services in the Legacy WebKit MiniBrowser.
2144
2145 2014-10-09  Adrien Destugues  <pulkomandy@gmail.com>
2146
2147         Get the patch scripts running on Haiku
2148         https://bugs.webkit.org/show_bug.cgi?id=137559
2149
2150         Reviewed by Benjamin Poulain.
2151
2152         Use /usr/bin/env instead of hardcoding path to perl.
2153         Declare haiku platform in platforminfo.py to avoid check-webkit-style
2154         failure.
2155
2156         * Scripts/commit-log-editor:
2157         * Scripts/num-cpus:
2158         * Scripts/prepare-ChangeLog:
2159         * Scripts/run-launcher:
2160         * Scripts/svn-create-patch:
2161         * Scripts/webkitpy/common/system/platforminfo.py:
2162         (PlatformInfo._determine_os_name):
2163
2164 2014-10-08  Jake Nielsen  <jacob_nielsen@apple.com>
2165
2166         StyleQueue should throw a PatchIsNotValid exception to achieve
2167         consistency with CommitQueue and EWS
2168         https://bugs.webkit.org/show_bug.cgi?id=137500
2169
2170         Reviewed by Alexey Proskuryakov.
2171
2172         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
2173         Adds a call to validate() in run().
2174         (StyleQueueTask.run):
2175         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2176         Adds a return False in the patch is not valid exception statement.
2177         (AbstractEarlyWarningSystem.review_patch):
2178         * Scripts/webkitpy/tool/commands/queues.py:
2179         Adds a return False in the patch is not valid exception statement in
2180         commit queue, and adds an except statement to catch PatchIsNotValid
2181         exceptions in style queue.
2182         (CommitQueue.process_work_item):
2183         (StyleQueue.review_patch):
2184
2185 2014-10-08  Carlos Garcia Campos  <cgarcia@igalia.com>
2186
2187         Race condition with WebKitWebView:is-loading after starting page load
2188         https://bugs.webkit.org/show_bug.cgi?id=136692
2189
2190         Reviewed by Gustavo Noronha Silva.
2191
2192         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
2193         (loadChangedCallback): Only check is-loading is false when load
2194         has finished if the load didn't fail due to a cancellation.
2195         (loadFailedCallback): Only check is-loading is false if the load
2196         didn't fail due to a cancellation.
2197         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2198         (WebViewTest::loadURI): Check is-loading is true and active URI is
2199         the requested one rigth after requesting the load.
2200         (WebViewTest::loadHtml): Ditto.
2201         (WebViewTest::loadPlainText): Ditto.
2202         (WebViewTest::loadBytes): Ditto.
2203         (WebViewTest::loadRequest): Ditto.
2204         (WebViewTest::loadAlternateHTML): Ditto.
2205         (WebViewTest::goBack): Ditto.
2206         (WebViewTest::goForward): Ditto.
2207         (WebViewTest::goToBackForwardListItem): Ditto.
2208
2209 2014-10-08  Brent Fulgham  <bfulgham@apple.com>
2210
2211         [Win] Resolve various static analyzer warnings in Tools.
2212         https://bugs.webkit.org/show_bug.cgi?id=137534
2213
2214         Reviewed by Dean Jackson.
2215
2216         * DumpRenderTree/cg/ImageDiffCG.cpp:
2217         (main): User proper printf specifiers.
2218         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2219         (AccessibilityUIElement::childrenCount): Handle possibility that
2220         gcc_accChildCount returns with an error.
2221         (accessibilityState): Ditto for gcc_accState.
2222         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
2223         (DRTDesktopNotificationPresenter::showDesktopNotification): Use proper
2224         check for return value from 'isHTML'. HRESULT is not a boolean and cannot
2225         be treated as such.
2226         * DumpRenderTree/win/DumpRenderTree.cpp:
2227         (DumpRenderTreeWndProc): Avoid possible infinite loop on teardown caused
2228         by comparing an unsigned value as being greater-than zero.
2229         * DumpRenderTree/win/EditingDelegate.cpp:
2230         (dump): Pass proper character pointer type to printf.
2231         (EditingDelegate::shouldBeginEditingInDOMRange): Ditto.
2232         (EditingDelegate::shouldEndEditingInDOMRange): Ditto.
2233         (EditingDelegate::shouldInsertNode): Ditto.
2234         (EditingDelegate::shouldInsertText): Ditto.
2235         (EditingDelegate::shouldDeleteDOMRange): Ditto.
2236         (EditingDelegate::shouldChangeSelectedDOMRange): Ditto.
2237         (EditingDelegate::shouldApplyStyle): Ditto.
2238         * DumpRenderTree/win/EventSender.cpp:
2239         (beginDragWithFilesCallback): Handle possible error case for GlobalAlloc.
2240         * DumpRenderTree/win/EventSender.h: Add proper declaration for HRESULT to match
2241         system headers.
2242         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Handle possible failure
2243         from CreateDIBSection.
2244         * DumpRenderTree/win/UIDelegate.cpp: Ensure proper type is passed to printf.
2245         * TestWebKitAPI/Tests/WTF/MediaTime.cpp: Get rid of workaround for NaN under
2246         older versions of MSVC we no longer support.
2247         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Use proper types and API
2248         for 64-bit builds.
2249         * TestWebKitAPI/TestsController.cpp: Use NeverDestroyed like a good citizen.
2250         * TestWebKitAPI/TestsController.h: Ditto.
2251         * WinLauncher/Common.cpp: Handle possible failure from GetModuleFileName.
2252         * WinLauncher/WinLauncher.cpp: Make order of operations explicit to avoid
2253         performing bitwise | before the comparison is done.
2254
2255 2014-10-08  Ada Chan  <adachan@apple.com>
2256
2257         Add a test for WKPageIsPlayingAudio().
2258         https://bugs.webkit.org/show_bug.cgi?id=137048
2259
2260         Reviewed by Darin Adler.
2261
2262         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2263         Add file-with-video.html, test.mp4, and WKPageIsPlayingAudio.cpp to the project.
2264         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp: Added.
2265         (TestWebKitAPI::nullJavaScriptCallback):
2266         (TestWebKitAPI::didFinishLoadForFrame):
2267         (TestWebKitAPI::isPlayingAudioDidChangeCallback):
2268         (TestWebKitAPI::setUpClients):
2269         (TestWebKitAPI::TEST):
2270         This test loads a page with a video in it. When the page is loaded, we first check that
2271         WKPageIsPlayingAudio() returns false for the page. Then we call a method to start the video.
2272         When the WKPageUIClient::isPlayingAudioDidChange callback gets called, check that WKPageIsPlayingAudio()
2273         now returns true for the page.
2274         * TestWebKitAPI/Tests/WebKit2/file-with-video.html: Added.
2275         * TestWebKitAPI/Tests/WebKit2/test.mp4: Added.
2276         This is a video copied from LayoutTests/media/content.
2277
2278 2014-10-08  Csaba Osztrogonác  <ossy@webkit.org>
2279
2280         [webkitpy] Use python-irclib-0.4.8.tar.gz instead of zip in AutoInstaller
2281         https://bugs.webkit.org/show_bug.cgi?id=137516
2282
2283         Reviewed by Alexey Proskuryakov.
2284
2285         * Scripts/webkitpy/thirdparty/__init__.py:
2286         (AutoinstallImportHook._install_irc):
2287
2288 2014-10-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2289
2290         [GTK] install-dependencies should install libjpeg-turbo on Debian and derivatives.
2291         https://bugs.webkit.org/show_bug.cgi?id=137520
2292
2293         Reviewed by Philippe Normand.
2294
2295         Debian is switching is default JPEG library to libjpeg-turbo <https://wiki.debian.org/LJTTransition#Text>
2296         For other distributions, we are already installing libjpeg-turbo.
2297         So, do the same for Debian and derivatives.
2298
2299         * gtk/install-dependencies: Install libjpeg-dev that depends on the default implementation of libjpeg.
2300
2301 2014-10-08  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2302
2303         [webkitpy] Add back the workaround to replace ZipFile.extractall()
2304         https://bugs.webkit.org/show_bug.cgi?id=137519
2305
2306         Reviewed by Csaba Osztrogonác.
2307
2308         It was removed by <http://trac.webkit.org/changeset/174266>,
2309         because the comment stated it is a workaround for buggy python
2310         2.6.1 which shipped on Snow Leopard. But it turned out the bug
2311         is still valid with python 2.7 shipped on the latest Ubuntu
2312         (12.04 and 14.04) and OS X 10.9.
2313
2314         * Scripts/webkitpy/common/system/autoinstall.py:
2315         (AutoInstaller):
2316         (AutoInstaller._extract_all):
2317         (AutoInstaller._unzip):
2318
2319 2014-10-08  Commit Queue  <commit-queue@webkit.org>
2320
2321         Unreviewed, rolling out r174335.
2322         https://bugs.webkit.org/show_bug.cgi?id=137515
2323
2324         It broke EFL layout test totally (Requested by gyuyoung on
2325         #webkit).
2326
2327         Reverted changeset:
2328
2329         "[EFL] Introduce EWebKit_Extension"
2330         https://bugs.webkit.org/show_bug.cgi?id=134921
2331         http://trac.webkit.org/changeset/174335
2332
2333 2014-10-08  Carlos Garcia Campos  <cgarcia@igalia.com>
2334
2335         [GTK] Make forwarding headers generation depend on source code
2336         https://bugs.webkit.org/show_bug.cgi?id=137394
2337
2338         Reviewed by Philippe Normand.
2339
2340         * TestWebKitAPI/CMakeLists.txt: Add missing dependency rule.
2341         * TestWebKitAPI/PlatformGTK.cmake: Only run
2342         generate-forwarding-headers.pl when source code changes.
2343         * WebKitTestRunner/PlatformGTK.cmake: Ditto.
2344
2345 2014-10-07  Tanay C  <tanay.c@samsung.com>
2346
2347         Remove build warnings in Hashmap API tests
2348         https://bugs.webkit.org/show_bug.cgi?id=137484
2349
2350         Reviewed by Darin Adler.
2351
2352         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
2353         (TestWebKitAPI::TEST): Changed EXPECT_EQ(false, addResult.isNewEntry) to EXPECT_FALSE(addResult.isNewEntry) 
2354
2355 2014-10-07  Jake Nielsen  <jacob_nielsen@apple.com>
2356
2357         Commit queue doesn't drop obsolete patches sometimes
2358         https://bugs.webkit.org/show_bug.cgi?id=137460
2359
2360         Reviewed by Alexey Proskuryakov.
2361
2362         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
2363         Adds another test patch for use in queues_unittest.py.
2364         courtesy of Csaba Osztrogonác <ossy@webkit.org>
2365         (MockBugzilla):
2366         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2367         Raises a PatchIsNotValid exception in the case of validate() returning
2368         false.
2369         (CommitQueueTask.run):
2370         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
2371         Raises a PatchIsNotValid exception in the case of validate() returning
2372         false.
2373         (EarlyWarningSystemTask.run):
2374         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2375         Defines PatchIsNotValid exception. 
2376         (PatchIsNotValid):
2377         (PatchIsNotValid.__init__):
2378         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2379         Remove call to validate() and instead catches the PatchIsNotValid
2380         exception.
2381         (AbstractEarlyWarningSystem.review_patch):
2382         * Scripts/webkitpy/tool/commands/queues.py:
2383         Adds logic to catch the PatchIsNotValid exception.
2384         (CommitQueue.process_work_item):
2385         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2386         Adds the test_non_valid_patch test to ensure that invalid patches are
2387         handled properly, and don't just result in indefinite spinning.
2388         courtesy of Csaba Osztrogonác <ossy@webkit.org>
2389         (test_non_valid_patch):
2390
2391 2014-10-07  Daniel Bates  <dabates@apple.com>
2392
2393         [iOS] Teach run-webkit-tests to honor TestExpectation file for iOS Simulator 64-bit builds
2394         https://bugs.webkit.org/show_bug.cgi?id=137499
2395
2396         Reviewed by Simon Fraser.
2397
2398         Fixes an issue where the TestExpectation file for the iOS Simulator platform was only
2399         honored when running run-webkit-tests with a 32-bit simulator build of iOS WebKit. We
2400         should honor the TestExpectation file for the iOS Simulator platform for both 32- and 64-
2401         bit simulator builds of iOS WebKit.
2402
2403         * Scripts/webkitpy/port/ios.py:
2404         (IOSSimulatorPort._generate_all_test_configurations):
2405
2406 2014-10-07  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2407
2408         [GTK] jhbuild modules should build xserver with the --without-dtrace option.
2409         https://bugs.webkit.org/show_bug.cgi?id=137482
2410
2411         Reviewed by Martin Robinson.
2412
2413         * gtk/jhbuild.modules: Added --without-dtrace option to xserver jhbuild.modules config.
2414
2415 2014-10-07  Carlos Garcia Campos  <cgarcia@igalia.com>
2416
2417         [SOUP] TLS errors should take precedence over HTTP authentication
2418         https://bugs.webkit.org/show_bug.cgi?id=137300
2419
2420         Reviewed by Sergio Villar Senin.
2421
2422         Add a test case to check that authenticate signal is not emitted
2423         in case of TLS errors, and the load fails instead.
2424
2425         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
2426         (webViewAuthenticationCallback):
2427         (testTLSErrorsHTTPAuth):
2428         (httpsServerCallback):
2429         (beforeAll):
2430
2431 2014-10-06  Ryosuke Niwa  <rniwa@webkit.org>
2432
2433         Make webkit-patch find-users useful
2434         https://bugs.webkit.org/show_bug.cgi?id=137475
2435
2436         Reviewed by Alexey Proskuryakov.
2437
2438         Make find-users use the CommitterList instead of accessing Bugzilla.
2439
2440         This essentially exposes the same functionality as webkitbot's whois command.
2441
2442         * Scripts/webkitpy/tool/commands/findusers.py:
2443         (FindUsers.execute):
2444
2445 2014-10-06  Chris Fleizach  <cfleizach@apple.com>
2446
2447         AX: iOS8: Crash at -[WebAccessibilityObjectWrapper accessibilityElementAtIndex:]
2448         https://bugs.webkit.org/show_bug.cgi?id=137289
2449
2450         Unreviewed build fix.
2451
2452         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2453         (AccessibilityUIElement::getChildrenWithRange):
2454
2455 2014-10-06  Alexey Proskuryakov  <ap@apple.com>
2456
2457         build.webkit.org/dashboard: Add commit queue
2458         https://bugs.webkit.org/show_bug.cgi?id=137462
2459
2460         Reviewed by Tim Horton.
2461
2462         Generalizes EWS into "bubble queue", which also includes commit queue and style queue.
2463         Style queue is still invisible, as it doesn't have an associated platform, and also
2464         we never have problems with it anyway, so it's not worth watching.
2465
2466         The UI now allows for adding more bots to the Other column (such as leaks bot).
2467         To make that actually happen, we'll need to refactor QueueView, allowing for multiple
2468         sources of data in a cell.
2469
2470         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueue.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js.
2471         (BubbleQueue):
2472         (BubbleQueue.prototype.get statusPageURL):
2473         (BubbleQueue.prototype.update):
2474         (BubbleQueue.prototype.loadDetailedStatus):
2475         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js.
2476         (BubbleQueueServer):
2477         (BubbleQueueServer.prototype.jsonQueueLengthURL):
2478         (BubbleQueueServer.prototype.jsonQueueStatusURL):
2479         (BubbleQueueServer.prototype.queueStatusURL):
2480         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueView.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js.
2481         (BubbleQueueView):
2482         (BubbleQueueView.prototype.update.appendQueue):
2483         (BubbleQueueView.prototype.update):
2484         (BubbleQueueView.prototype._addQueueHeadingToPopover):
2485         (BubbleQueueView.prototype._popoverContentForBubbleQueue):
2486         (BubbleQueueView.prototype._presentPopoverForBubbleQueue):
2487         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js: Removed.
2488         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js: Removed.
2489         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js: Removed.
2490         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
2491         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2492         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
2493         (.bubble-server-popover .popover-queue-heading .queue-charts-link):
2494         (.bubble-server-popover .latest-status-no-link):
2495         (.bubble-server-popover .bot-status-description):
2496         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
2497
2498         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
2499         (buildAggregateTable):
2500         (buildQueuesTable):
2501         Removed dysfunctional support for EWS for now. It will be different.
2502
2503 2014-10-06  Alexey Proskuryakov  <ap@apple.com>
2504
2505         One more case of incorrect comparison in recordpatchevent.py
2506         https://bugs.webkit.org/show_bug.cgi?id=137459
2507
2508         Reviewed by Tim Horton.
2509
2510         * QueueStatusServer/app.yaml:
2511         * QueueStatusServer/loggers/recordpatchevent.py:
2512         (RecordPatchEvent.started):
2513
2514 2014-10-06  Alexey Proskuryakov  <ap@apple.com>
2515
2516         webkit-queues PatchLog is incorrect for patches that took less than a second
2517         https://bugs.webkit.org/show_bug.cgi?id=137453
2518
2519         Reviewed by Tim Horton.
2520
2521         * QueueStatusServer/app.yaml: Updated app version.
2522
2523         * QueueStatusServer/loggers/recordpatchevent.py: (RecordPatchEvent.stopped):
2524         Don't bail out for patches that took 0 seconds to process (as frequently happens
2525         when a patch is obsolete).
2526
2527 2014-10-06  Csaba Osztrogonác  <ossy@webkit.org>
2528
2529         EWS bubble hover shows wrong timestamps
2530         https://bugs.webkit.org/show_bug.cgi?id=137252
2531
2532         Reviewed by Alexey Proskuryakov.
2533
2534         Add "Z" suffix to timestamps to make sure if it is handled as UTC time.
2535
2536         * QueueStatusServer/handlers/queuestatusjson.py:
2537         (QueueStatusJSON.get):
2538         * QueueStatusServer/handlers/statusbubble.py:
2539         (StatusBubble._iso_time):
2540
2541 2014-10-06  Mario Sanchez Prada  <mario@webkit.org>
2542
2543         Unreviewed, updated list of email addresses in contributors.json
2544
2545         * Scripts/webkitpy/common/config/contributors.json: Added my former
2546         email address in Igalia, for the sake of completeness.
2547
2548 2014-10-06  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
2549
2550         Unreviewed, moved myself to the list of committers.
2551
2552         * Scripts/webkitpy/common/config/contributors.json:
2553
2554 2014-10-05  Ryuan Choi  <ryuan.choi@gmail.com>
2555
2556         [EFL] Introduce EWebKit_Extension
2557         https://bugs.webkit.org/show_bug.cgi?id=134921
2558
2559         Reviewed by Gyuyoung Kim.
2560
2561         * MiniBrowser/efl/main.c: Added x option to test extension path.
2562         (window_create):
2563         (elm_main):
2564         * Scripts/webkitpy/common/config/watchlist:
2565         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFLWebKit2PublicAPI.
2566         * Scripts/webkitpy/style/checker.py:
2567         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFL exceptions.
2568
2569 2014-10-04  Csaba Osztrogonác  <ossy@webkit.org>
2570
2571         [jhbuild] Simplify platform detection in update-webkit-libs-jhbuild
2572         https://bugs.webkit.org/show_bug.cgi?id=137390
2573
2574         Reviewed by Carlos Garcia Campos.
2575
2576         * Scripts/update-webkit-libs-jhbuild:
2577
2578 2014-10-04  Carlos Garcia Campos  <cgarcia@igalia.com>
2579
2580         [GTK] Do not generate webkit2gtk-tests-resources.gresource unconditionally
2581         https://bugs.webkit.org/show_bug.cgi?id=137391
2582
2583         Reviewed by Martin Robinson.
2584
2585         Add a custom command to only re-generate
2586         webkit2gtk-tests-resources.gresource when any of its dependencies changes.
2587
2588         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
2589
2590 2014-10-04  Carlos Garcia Campos  <cgarcia@igalia.com>
2591
2592         [GTK] generate-gtkdoc crashes when generating HTML due to encoding issues
2593         https://bugs.webkit.org/show_bug.cgi?id=135502
2594
2595         Reviewed by Martin Robinson.
2596
2597         When writing to stdout/stderr fails due to a UnicodeDecodeError
2598         exception, try again without encoding the output.
2599
2600         * gtk/gtkdoc.py:
2601         (GTKDoc._run_command):
2602
2603 2014-10-03  Alexey Proskuryakov  <ap@apple.com>
2604
2605         Bugzilla status bubble displays an exception showing attachment 175738
2606         https://bugs.webkit.org/show_bug.cgi?id=137410
2607
2608         Reviewed by Tim Horton.
2609
2610         * QueueStatusServer/app.yaml: Update version.
2611
2612         * QueueStatusServer/handlers/statusbubble.py: (StatusBubble._build_bubble):
2613         Don't fail even if expected status message is missing.
2614
2615         * QueueStatusServer/model/patchlog.py: (PatchLog): Quick unrelated fix - define
2616         the field in the same way it's defined in QueueStatus table.
2617
2618 2014-10-03  Alexey Proskuryakov  <ap@apple.com>
2619
2620         Record latest message in PatchLog for quick access
2621         https://bugs.webkit.org/show_bug.cgi?id=137405
2622
2623         Fixing a typo.
2624
2625         * QueueStatusServer/app.yaml:
2626         * QueueStatusServer/handlers/releasepatch.py:
2627
2628 2014-10-03  Alexey Proskuryakov  <ap@apple.com>
2629
2630         Record latest message in PatchLog for quick access
2631         https://bugs.webkit.org/show_bug.cgi?id=137405
2632
2633         Reviewed by Ryosuke Niwa.
2634
2635         It's no SQL...
2636
2637         * QueueStatusServer/handlers/releasepatch.py:
2638         * QueueStatusServer/handlers/updatestatus.py:
2639         * QueueStatusServer/loggers/recordpatchevent.py:
2640         * QueueStatusServer/model/patchlog.py:
2641
2642 2014-10-02  David Farler  <dfarler@apple.com>
2643
2644         -asan-blacklist option also renamed to generic -fsanitize-blacklist
2645         https://bugs.webkit.org/show_bug.cgi?id=137377
2646
2647         Reviewed by Daniel Bates.
2648
2649         * asan/asan.xcconfig:
2650         -asan-blacklist -> -fsanitize-blacklist
2651
2652         http://llvm.org/viewvc/llvm-project?view=revision&revision=212505
2653
2654 2014-10-03  Roger Fong  <roger_fong@apple.com>
2655
2656         [Windows] Include batch size argument to layout tests on Windows.
2657
2658         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2659         (RunWebKitTests.start): 
2660         This is a speculative fix for the the inconsistent crashes we are seeing on Windows.
2661         These crashes seem to happen on random tests though generally in a spread out fashion.
2662         It seems possible that the DRT instance is being clobbered somehow after running too many
2663         tests in a row so we will try to mitigate this by just forcing DRT to restart periodically.
2664
2665 2014-10-03  Roger Fong  <roger_fong@apple.com>
2666
2667         [Windows] Settle for 2 chid processes running NRWT on Windows.
2668
2669         * Scripts/webkitpy/port/win.py:
2670         (WinPort.default_child_processes): 3 child processes reintroduces the sporadic crashing, will settle for 2.
2671
2672 2014-10-03  Akos Kiss  <akiss@inf.u-szeged.hu>
2673
2674         [GTK] Bump up and patch dependencies to allow building for aarch64
2675         https://bugs.webkit.org/show_bug.cgi?id=137147
2676
2677         Reviewed by Martin Robinson.
2678
2679         The currently used versions of pixman, libffi, librsvg, glib,
2680         glib-networking, fontconfig, libxml2, gst-plugins-base fail to configure
2681         and/or build for aarch64, so they are bumped up and patched where
2682         necessary. Wherever possible, the same versions and patches were used as
2683         for the EFL port bump-up
2684         (https://bugs.webkit.org/show_bug.cgi?id=135885).
2685
2686         After the bump-up, a hitherto hidden bug in gst-plugins-good caused a
2687         regression by crashing http/tests/media/video-redirect.html . A patch
2688         already in upstream fixes that bug.
2689
2690         This change does not touch xserver, which also needs bumping up, but 
2691         will be dealt with later.
2692
2693         * gtk/jhbuild.modules:
2694         Specified versions and patches necessary to correctly build for aarch64.
2695         * gtk/patches/gst-events-arent-gstobjects.patch:
2696         Added. Patches gst-plugins-good to fix a bug in .mov file demuxing.
2697         * gtk/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch:
2698         Added. Patches gst-plugins-base to configure correctly for aarch64.
2699         * gtk/patches/librsvg-2.36.1-bump-up-config.guess-to-support-aarch64.patch:
2700         Added. Bumps up config.guess and config.sub in librsvg to recognize
2701         aarch64.
2702         * gtk/patches/libxml2-2.9.0-dtd.patch:
2703         Removed. Not necessary for libxml2 v2.9.1 anymore.
2704
2705 2014-09-28  Sam Weinig  <sam@webkit.org>
2706
2707         Remove RefPtrHashMap
2708         https://bugs.webkit.org/show_bug.cgi?id=137200
2709
2710         Reviewed by Darin Adler.
2711
2712         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
2713         (TestWebKitAPI::TEST):
2714         Add tests for using a HashMap with RefPtr keys, focusing on ensuring that
2715         a minimum of refcount churn occurs.
2716
2717 2014-10-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2718
2719         Remove workarounds for versions of Python before 2.7
2720         https://bugs.webkit.org/show_bug.cgi?id=137338
2721
2722         Reviewed by Csaba Osztrogonác.
2723
2724         * Scripts/webkitpy/common/system/autoinstall.py:
2725         (AutoInstaller._extract_targz):
2726         (AutoInstaller._unzip):
2727         (AutoInstaller): Deleted.
2728         (AutoInstaller._extract_all): Deleted.
2729         * Scripts/webkitpy/common/webkitunittest.py:
2730         (TestCase.setUp): Deleted.
2731         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
2732         (TestConfigurationConverter.collapse_macros):
2733         (TestConfigurationConverter.to_specifiers_list.try_collapsing):
2734         (TestConfigurationConverter.to_specifiers_list.try_abbreviating):
2735         (TestConfigurationConverter):
2736         (TestConfigurationConverter.combinations): Deleted.
2737         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2738         * Scripts/webkitpy/port/base.py:
2739
2740 2014-10-03  Commit Queue  <commit-queue@webkit.org>
2741
2742         Unreviewed, rolling out r174264.
2743         https://bugs.webkit.org/show_bug.cgi?id=137392
2744
2745         It broke run-webkit-tests (Requested by ebalazsfalvi on
2746         #webkit).
2747
2748         Reverted changeset:
2749
2750         "Remove workarounds for versions of Python before 2.7"
2751         https://bugs.webkit.org/show_bug.cgi?id=137338
2752         http://trac.webkit.org/changeset/174264
2753
2754 2014-10-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2755
2756         Remove workarounds for versions of Python before 2.7
2757         https://bugs.webkit.org/show_bug.cgi?id=137338
2758
2759         Reviewed by Csaba Osztrogonác.
2760
2761         * Scripts/webkitpy/common/system/autoinstall.py:
2762         (AutoInstaller._extract_targz):
2763         (AutoInstaller._unzip):
2764         (AutoInstaller): Deleted.
2765         (AutoInstaller._extract_all): Deleted.
2766         * Scripts/webkitpy/common/webkitunittest.py:
2767         (TestCase.setUp): Deleted.
2768         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
2769         (TestConfigurationConverter.collapse_macros):
2770         (TestConfigurationConverter.to_specifiers_list.try_collapsing):
2771         (TestConfigurationConverter.to_specifiers_list.try_abbreviating):
2772         (TestConfigurationConverter):
2773         (TestConfigurationConverter.combinations): Deleted.
2774         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2775         * Scripts/webkitpy/port/base.py:
2776         * Scripts/webkitpy/port/driver.py:
2777         (ContentBlock.__init__):
2778         * Scripts/webkitpy/port/server_process.py:
2779         (ServerProcess._reset):
2780
2781 2014-10-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2782
2783         Remove autoinstaller workaround for python 2.6
2784         https://bugs.webkit.org/show_bug.cgi?id=137343
2785
2786         Reviewed by Daniel Bates.
2787
2788         Reverting <http://trac.webkit.org/changeset/124928>, neither Python
2789         2.6, nor Snow Leopard is supported anymore, so the workaround is not
2790         needed anymore.
2791
2792         * Scripts/webkitpy/common/system/autoinstall.py:
2793         (AutoInstaller.install):
2794         * Scripts/webkitpy/test/main.py:
2795         (Tester._run_tests):
2796         * Scripts/webkitpy/thirdparty/__init__.py:
2797         (AutoinstallImportHook._install_mechanize):
2798         (AutoinstallImportHook._install_pep8):
2799         (AutoinstallImportHook._install_pylint):
2800         (AutoinstallImportHook._install_buildbot):
2801         (AutoinstallImportHook._install_coverage):
2802         (AutoinstallImportHook._install_eliza):
2803         (AutoinstallImportHook._install_irc):
2804         (AutoinstallImportHook._install):
2805         (autoinstall_everything):
2806
2807 2014-10-02  Daniel Bates  <dabates@apple.com>
2808
2809         Use version number 101000 instead of 10100 for OS X Yosemite
2810         https://bugs.webkit.org/show_bug.cgi?id=137372
2811
2812         Reviewed by Mark Rowe.
2813
2814         The version number for OS X Yosemite is 101000.
2815
2816         * DumpRenderTree/mac/TextInputController.m:
2817
2818 2014-10-02  Alexey Proskuryakov  <ap@apple.com>
2819
2820         update-work-items should never delete items
2821         https://bugs.webkit.org/show_bug.cgi?id=137366
2822
2823         Reviewed by Ryosuke Niwa.
2824
2825         As we don't just replace the whole list any more, indicate which items are high
2826         priority, and which are not. Hight priority ones will be prepended to the queue,
2827         others will be appended.
2828
2829         This creates a bit of unfairness in that high priority item queue becomes a LIFO.
2830         But hopefully we will never have many rollouts competing like that.
2831
2832         * QueueStatusServer/app.yaml: Update version.
2833
2834         * QueueStatusServer/handlers/updateworkitems.py: Never remove items. Pass high
2835         priority and regular items separately. Removed some error handling that used to
2836         end up in returning status 500 - an uncaught exception does that automatically.
2837
2838         * QueueStatusServer/main.py: Removed unnecessary regexps from URL matching code.
2839
2840         * QueueStatusServer/model/workitems.py: Added a way to add high priority items.
2841
2842         * QueueStatusServer/templates/updateworkitems.html: Added a field for high
2843         priority items.
2844
2845         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2846         (BugzillaQueries._parse_attachment_ids_request_query): Removed an annoying log
2847         line that complicated testing.
2848
2849         * Scripts/webkitpy/common/net/statusserver.py: Pass high priority items separately.
2850
2851         * Scripts/webkitpy/tool/bot/feeders.py: For commit queue, split high and regular
2852         priority items into separate lists.
2853
2854         * Scripts/webkitpy/common/net/statusserver_mock.py:
2855         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
2856         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2857         Updated tests.
2858
2859 2014-10-02  Brendan Long  <b.long@cablelabs.com>
2860
2861         Annoying build warnings in WTFString API tests
2862         https://bugs.webkit.org/show_bug.cgi?id=137360
2863
2864         Reviewed by Darin Adler.
2865
2866         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
2867         (TestWebKitAPI::TEST): Change EXPECT_EQ(false, ok) to EXPECT_FALSE(ok) and EXPECT_EQ(true, ok) to EXPECT_TRUE(ok).
2868
2869 2014-10-02  Roger Fong  <roger_fong@apple.com>
2870
2871         [Windows] The number of processes did not affect the crash inconsistency, increase number of child processes again.
2872
2873         * Scripts/webkitpy/port/win.py:
2874         (WinPort.default_child_processes): Ambitiously try 3 processes the testers are too slow now.
2875
2876 2014-10-02  David Farler  <dfarler@apple.com>
2877
2878         Move ASan arguments from LLVM (-mllvm) to the frontend
2879         https://bugs.webkit.org/show_bug.cgi?id=137365
2880
2881         Reviewed by David Kilzer.
2882
2883         * asan/asan.xcconfig:
2884         Remove the -mllvm prefix to the asan-blacklist argument, moving it
2885         to the clang frontend.
2886
2887         http://llvm.org/viewvc/llvm-project?view=revision&revision=212505
2888
2889 2014-10-02  Commit Queue  <commit-queue@webkit.org>
2890
2891         Unreviewed, rolling out r174120.
2892         https://bugs.webkit.org/show_bug.cgi?id=137350
2893
2894         While number of failures is reasonable with 2 processes, test
2895         results seem to be inconsistent between runs (Requested by
2896         rfong on #webkit).
2897
2898         Reverted changeset:
2899
2900         "[Windows] Back to 2 child processes for NRWT on Windows."
2901         http://trac.webkit.org/changeset/174120
2902
2903 2014-10-02  Jeff Miller  <jeffm@apple.com>
2904
2905         DumpRenderTree and WebKitTestRunner should use WebKitystemInterfaceYosemite when building on Yosemite
2906         https://bugs.webkit.org/show_bug.cgi?id=137347
2907
2908         Reviewed by Dan Bernstein.
2909
2910         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2911         Use WebKitSystemInterfaceYosemite on OS X 10.10.
2912
2913         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2914         Ditto.
2915
2916 2014-10-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2917
2918         [GTK] [JHBuild] Switch sourceware.org mirror to http.
2919
2920         Unreviewed.
2921
2922         The ftp access is recently failing to work as expected, and the
2923         bots fail to download the file.
2924         The same mirror is available via http and seems to work better.
2925
2926         * gtk/jhbuild.modules:
2927
2928 2014-10-01  Commit Queue  <commit-queue@webkit.org>
2929
2930         Unreviewed, rolling out r174185.
2931         https://bugs.webkit.org/show_bug.cgi?id=137334
2932
2933         Patch that adds logging causes webkitpy failures (Requested by
2934         rfong on #webkit).
2935
2936         Reverted changeset:
2937
2938         "commitqueuetasks_unittest references a non-existent member
2939         variable"
2940         https://bugs.webkit.org/show_bug.cgi?id=137303
2941         http://trac.webkit.org/changeset/174185
2942
2943 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
2944
2945         EWS and Commit Queue should know better than to spew 500 failed
2946         results in the case of extremely red patches.
2947         https://bugs.webkit.org/show_bug.cgi?id=137324
2948
2949         Reviewed by Alexey Proskuryakov.
2950
2951         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2952         Adds a check for did_exceed_test_failure_limit.
2953         (AbstractEarlyWarningSystem._failing_tests_message):
2954         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2955         Alters the task mock to respond properly to
2956         results_from_patch_test_run(patch)
2957         (AbstractEarlyWarningSystemTest.test_failing_tests_message):
2958         * Scripts/webkitpy/tool/commands/queues.py:
2959         Adds a check for did_exceed_test_failure_limit.
2960         (CommitQueue._failing_tests_message):
2961
2962 2014-10-01  Daniel Bates  <dabates@apple.com>
2963
2964         Unreviewed, rolling out r174192.
2965
2966         Revert the unit test fix in r174192 since we reverted r174187
2967         in r174194 due to correctness issues. See
2968         <http://webkit.org/b/137329> for more details.
2969
2970         Reverted changeset:
2971
2972         "Test fix after r174187"
2973         http://trac.webkit.org/changeset/174192
2974
2975 2014-10-01  Mark Rowe  <mrowe@apple.com>
2976
2977         <https://webkit.org/b/137308> WebKit should build on OS X Yosemite for external users
2978
2979         Reviewed by Dan Bernstein.
2980
2981         * Scripts/copy-webkitlibraries-to-product-directory: Copy libWebKitSystemInterfaceYosemite.a
2982         into the build directory. Use LLVMIncludesYosemite.tar.bz2 and LLVMLibrariesYosemite.tar.bz2
2983         for the LLVM components when on Yosemite.
2984
2985 2014-10-01  Commit Queue  <commit-queue@webkit.org>
2986
2987         Unreviewed, rolling out r174187.
2988         https://bugs.webkit.org/show_bug.cgi?id=137329
2989
2990         webkitpy failures, and thorton says the patch is wrong
2991         (Requested by dethbakin on #webkit).
2992
2993         Reverted changeset:
2994
2995         "[Windows] Increase layout test timeout for Windows following
2996         r174162."
2997         http://trac.webkit.org/changeset/174187
2998
2999 2014-10-01  Brent Fulgham  <bfulgham@apple.com>
3000
3001         Test fix after r174187
3002
3003         * Scripts/webkitpy/port/win_unittest.py:
3004         (WinPortTest.test_default_timeout_ms): Expect the new 50000 ms timeout for Windows tests.
3005
3006 2014-10-01  Roger Fong  <roger_fong@apple.com>
3007
3008         [Windows] Increase layout test timeout for Windows following r174162.
3009
3010         * Scripts/webkitpy/port/win.py:
3011         (WinPort.default_timeout_ms):
3012
3013 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
3014
3015         commitqueuetasks_unittest references a non-existent member variable
3016         when mock-reporting flaky tests.
3017         https://bugs.webkit.org/show_bug.cgi?id=137303
3018
3019         Reviewed by Daniel Bates.
3020
3021         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3022         (MockCommitQueue.report_flaky_tests):
3023         Makes the appropriate name change.
3024         (test_simple_flaky_test_failure):
3025         Adds a unit test to make sure that the code is excercised.
3026
3027 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
3028
3029         EWS is inconclusively spinning forever on a patch that breaks 500+
3030         tests
3031         https://bugs.webkit.org/show_bug.cgi?id=137223
3032
3033         Reviewed by Tim Horton.
3034
3035         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
3036         Checks to see whether the tests have exceeded the failure limit, and
3037         only spins off another test if they have not exceeded the limit.
3038         (PatchAnalysisTask._test_patch):
3039
3040 2014-10-01  Brian J. Burg  <burg@cs.washington.edu>
3041
3042         Unreviewed, add Katie Madonna as a contributor.
3043
3044         * Scripts/webkitpy/common/config/contributors.json:
3045
3046 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
3047
3048         commitqueuetasks_unittest does not construct FailingTestCommitQueue
3049         objects properly in its test cases.
3050         https://bugs.webkit.org/show_bug.cgi?id=137281
3051
3052         Reviewed by Daniel Bates.
3053
3054         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3055         (FailingTestCommitQueue.test_results):
3056         Adds an assert to make FailingTestCommitQueue harder to mis-use.
3057         (test_double_flaky_test_failure):
3058         Nests the intended test failure strings into one-length lists.
3059         (test_red_test_failure):
3060         Nests the intended test failure strings into one-length lists.
3061
3062 2014-10-01  Alexey Proskuryakov  <ap@apple.com>
3063
3064         REGRESSION (r172172): Multiple regression tests fail when primary system language is Russian
3065         https://bugs.webkit.org/show_bug.cgi?id=136987
3066
3067         Reviewed by Daniel Bates.
3068
3069         * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetPreferencesToConsistentValues):
3070         Specify the default encoding for all WebKit developers to get consistent results.
3071
3072 2014-10-01  Alexey Proskuryakov  <ap@apple.com>
3073
3074         EWS is too eager to say that a patch does not apply to trunk of repository
3075         https://bugs.webkit.org/show_bug.cgi?id=137290
3076
3077         Reviewed by Ryosuke Niwa.
3078
3079         * QueueStatusServer/app.yaml: Updated app version.
3080
3081         * QueueStatusServer/handlers/statusbubble.py:
3082         (StatusBubble._build_bubble):
3083         (StatusBubble._build_bubbles_for_attachment):
3084         Rewrote to make more sense.
3085
3086 2014-09-30  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3087
3088         Remove thirdparty/unittest2 from webkitpy
3089         https://bugs.webkit.org/show_bug.cgi?id=137251
3090
3091         Reviewed by Brent Fulgham.
3092
3093         Additionally ordered imports in related webkitpy files and
3094         removed unnecessary shebangs from unittest files.
3095
3096         * BuildSlaveSupport/build.webkit.org-config/htdigestparser_unittest.py:
3097         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3098         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3099         * Scripts/webkitpy/common/checkout/commitinfo_unittest.py:
3100         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
3101         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
3102         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3103         * Scripts/webkitpy/common/config/committers_unittest.py:
3104         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
3105         * Scripts/webkitpy/common/config/contributionareas_unittest.py:
3106         * Scripts/webkitpy/common/config/ports_unittest.py:
3107         * Scripts/webkitpy/common/config/urls_unittest.py:
3108         * Scripts/webkitpy/common/editdistance_unittest.py:
3109         * Scripts/webkitpy/common/find_files_unittest.py:
3110         * Scripts/webkitpy/common/lru_cache_unittest.py:
3111         * Scripts/webkitpy/common/memoized_unittest.py:
3112         * Scripts/webkitpy/common/net/bugzilla/bug_unittest.py:
3113         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3114         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3115         * Scripts/webkitpy/common/net/credentials_unittest.py:
3116         * Scripts/webkitpy/common/net/failuremap_unittest.py:
3117         * Scripts/webkitpy/common/net/irc/ircproxy_unittest.py:
3118         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3119         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
3120         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
3121         * Scripts/webkitpy/common/net/statusserver_unittest.py:
3122         * Scripts/webkitpy/common/net/unittestresults_unittest.py:
3123         * Scripts/webkitpy/common/newstringio_unittest.py:
3124         * Scripts/webkitpy/common/prettypatch_unittest.py:
3125         * Scripts/webkitpy/common/read_checksum_from_png_unittest.py:
3126         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
3127         * Scripts/webkitpy/common/system/environment_unittest.py:
3128         * Scripts/webkitpy/common/system/executive.py: Ordered imports.
3129         * Scripts/webkitpy/common/system/executive_mock.py: Ordered imports.
3130         * Scripts/webkitpy/common/system/executive_unittest.py:
3131         * Scripts/webkitpy/common/system/file_lock_integrationtest.py:
3132         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
3133         * Scripts/webkitpy/common/system/filesystem_unittest.py:
3134         * Scripts/webkitpy/common/system/logtesting.py:
3135         * Scripts/webkitpy/common/system/logutils_unittest.py:
3136         * Scripts/webkitpy/common/system/outputcapture.py:
3137         * Scripts/webkitpy/common/system/outputcapture_unittest.py:
3138         * Scripts/webkitpy/common/system/outputtee_unittest.py:
3139         * Scripts/webkitpy/common/system/path_unittest.py:
3140         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
3141         * Scripts/webkitpy/common/system/profiler_unittest.py:
3142         * Scripts/webkitpy/common/system/stack_utils_unittest.py:
3143         * Scripts/webkitpy/common/system/user_unittest.py:
3144         * Scripts/webkitpy/common/system/workspace_unittest.py:
3145         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
3146         * Scripts/webkitpy/common/thread/messagepump_unittest.py:
3147         * Scripts/webkitpy/common/thread/threadedmessagequeue_unittest.py:
3148         * Scripts/webkitpy/common/watchlist/amountchangedpattern_unittest.py:
3149         * Scripts/webkitpy/common/watchlist/changedlinepattern_unittest.py:
3150         * Scripts/webkitpy/common/watchlist/filenamepattern_unittest.py:
3151         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py:
3152         * Scripts/webkitpy/common/watchlist/watchlistrule_unittest.py:
3153         * Scripts/webkitpy/common/webkitunittest.py:
3154         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
3155         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3156         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
3157         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3158         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
3159         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
3160         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3161         * Scripts/webkitpy/layout_tests/models/test_failures_unittest.py:
3162         * Scripts/webkitpy/layout_tests/models/test_results_unittest.py:
3163         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
3164         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3165         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
3166         * Scripts/webkitpy/layout_tests/servers/http_server_base_unittest.py:
3167         * Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py:
3168         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
3169         * Scripts/webkitpy/layout_tests/views/buildbot_results_unittest.py:
3170         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
3171         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3172         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
3173         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
3174         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3175         * Scripts/webkitpy/port/base_unittest.py:
3176         * Scripts/webkitpy/port/builders_unittest.py:
3177         * Scripts/webkitpy/port/config_unittest.py:
3178         * Scripts/webkitpy/port/driver_unittest.py:
3179         * Scripts/webkitpy/port/efl_unittest.py:
3180         * Scripts/webkitpy/port/factory_unittest.py:
3181         * Scripts/webkitpy/port/gtk_unittest.py:
3182         * Scripts/webkitpy/port/http_lock_unittest.py:
3183         * Scripts/webkitpy/port/image_diff_unittest.py:
3184         * Scripts/webkitpy/port/leakdetector_unittest.py:
3185         * Scripts/webkitpy/port/leakdetector_valgrind_unittest.py:
3186         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
3187         * Scripts/webkitpy/port/mock_drt_unittest.py:
3188         * Scripts/webkitpy/port/port_testcase.py:
3189         * Scripts/webkitpy/port/server_process_unittest.py:
3190         * Scripts/webkitpy/port/westondriver_unittest.py:
3191         * Scripts/webkitpy/port/win_unittest.py:
3192         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
3193         * Scripts/webkitpy/style/checker_unittest.py:
3194         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
3195         * Scripts/webkitpy/style/checkers/cmake_unittest.py:
3196         * Scripts/webkitpy/style/checkers/common_unittest.py:
3197         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3198         * Scripts/webkitpy/style/checkers/exportfile_unittest.py:
3199         * Scripts/webkitpy/style/checkers/js_unittest.py:
3200         * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py:
3201         * Scripts/webkitpy/style/checkers/messagesin_unittest.py:
3202         * Scripts/webkitpy/style/checkers/png_unittest.py:
3203         * Scripts/webkitpy/style/checkers/python_unittest.py:
3204         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
3205         * Scripts/webkitpy/style/checkers/text_unittest.py:
3206         * Scripts/webkitpy/style/checkers/watchlist_unittest.py:
3207         * Scripts/webkitpy/style/checkers/xcodeproj_unittest.py:
3208         * Scripts/webkitpy/style/checkers/xml_unittest.py:
3209         * Scripts/webkitpy/style/error_handlers_unittest.py:
3210         * Scripts/webkitpy/style/filereader_unittest.py:
3211         * Scripts/webkitpy/style/filter_unittest.py:
3212         * Scripts/webkitpy/style/main_unittest.py:
3213         * Scripts/webkitpy/style/optparser_unittest.py:
3214         * Scripts/webkitpy/style/patchreader_unittest.py:
3215         * Scripts/webkitpy/test/finder_unittest.py:
3216         * Scripts/webkitpy/test/main.py: Ordered imports.
3217         * Scripts/webkitpy/test/main_unittest.py:
3218         * Scripts/webkitpy/test/printer.py: Ordered imports.
3219         (Printer.configure):
3220         * Scripts/webkitpy/test/runner_unittest.py:
3221         * Scripts/webkitpy/test/skip_unittest.py:
3222         * Scripts/webkitpy/thirdparty/__init__.py:
3223         (AutoinstallImportHook._install_irc):
3224         (AutoinstallImportHook._install_unittest2): Deleted.
3225         * Scripts/webkitpy/thirdparty/__init___unittest.py:
3226         * Scripts/webkitpy/thirdparty/ordered_dict.py: Removed.
3227         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests_unittest.py:
3228         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
3229         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3230         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
3231         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
3232         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3233         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3234         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
3235         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
3236         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
3237         * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
3238         * Scripts/webkitpy/tool/commands/download_unittest.py:
3239         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
3240         * Scripts/webkitpy/tool/commands/perfalizer_unittest.py:
3241         * Scripts/webkitpy/tool/commands/queries_unittest.py:
3242         * Scripts/webkitpy/tool/commands/queuestest.py:
3243         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3244         * Scripts/webkitpy/tool/grammar_unittest.py:
3245         * Scripts/webkitpy/tool/mocktool_unittest.py:
3246         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
3247         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
3248         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
3249         * Scripts/webkitpy/tool/servers/reflectionhandler_unittest.py:
3250         * Scripts/webkitpy/tool/steps/addsvnmimetypeforpng_unittest.py:
3251         * Scripts/webkitpy/tool/steps/applywatchlist_unittest.py:
3252         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py:
3253         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
3254         * Scripts/webkitpy/tool/steps/commit_unittest.py:
3255         * Scripts/webkitpy/tool/steps/discardlocalchanges_unittest.py:
3256         * Scripts/webkitpy/tool/steps/haslanded_unittest.py:
3257         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
3258         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
3259         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
3260         * Scripts/webkitpy/tool/steps/steps_unittest.py:
3261         * Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py:
3262         * Scripts/webkitpy/tool/steps/update_unittest.py:
3263         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
3264         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
3265         * Scripts/webkitpy/w3c/test_converter_unittest.py:
3266         * Scripts/webkitpy/w3c/test_importer_unittest.py:
3267         * Scripts/webkitpy/w3c/test_parser_unittest.py:
3268
3269 2014-09-30  Jake Nielsen  <jacob_nielsen@apple.com>
3270
3271         LayoutTestResults and ExpectedFailures should know about the
3272         interrupted flag from the json results file
3273         https://bugs.webkit.org/show_bug.cgi?id=137229
3274
3275         Reviewed by Daniel Bates.
3276
3277         Changes LayoutTestResults to use the interrupted flag instead of
3278         counting failures.
3279
3280         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3281         (BuilderTest._install_fetch_build._mock_fetch_build):
3282         (BuilderTest.test_latest_layout_test_results):
3283         * Scripts/webkitpy/common/net/layouttestresults.py:
3284         Removes notion of failure_limit_count, and adds
3285         did_exceed_test_failure_limit.
3286
3287         (LayoutTestResults.results_from_string):
3288         (LayoutTestResults.__init__):
3289         (LayoutTestResults.did_exceed_test_failure_limit):
3290         (LayoutTestResults): Deleted.
3291         (LayoutTestResults.set_failure_limit_count): Deleted.
3292         (LayoutTestResults.failure_limit_count): Deleted.
3293         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3294         Removes unit test for failure_limit_count logic.
3295
3296         (LayoutTestResultsTest.test_set_failure_limit_count): Deleted.
3297         * Scripts/webkitpy/common/net/resultsjsonparser.py:
3298         Instead of providing a class method that returns a list of
3299         TestResults objects, resultsjsonparser now provides a class
3300         ParsedJSONResults that serves as an interface between the results.json
3301         file and the rest of webkitpy.
3302
3303         (ParsedJSONResults):
3304         (ParsedJSONResults.__init__):
3305         (ParsedJSONResults.did_exceed_test_failure_limit):
3306         (ParsedJSONResults.test_results):
3307         (ResultsJSONParser): Deleted.
3308         (ResultsJSONParser.parse_results_json): Deleted.
3309         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
3310         Updates the unit test so that it can test the new ResultsJSONParser
3311         class.
3312
3313         (ParsedJSONResultsTest):
3314         (test_basic):
3315         (ResultsJSONParserTest): Deleted.
3316         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3317         Updates the unit test to instantiate ResultsJSONParser objects rather
3318         than simple lists of TestResult objects.
3319
3320         (MockCommitQueue.test_results):
3321         (FailingTestCommitQueue.test_results):
3322         (test_flaky_test_failure):
3323         (test_failed_archive):
3324         * Scripts/webkitpy/tool/bot/expectedfailures.py:
3325         Updates ExpectedFailures to use the did_exceed_test_failure_limit
3326         method rather than counting the number of failed tests.
3327
3328         (ExpectedFailures._should_trust):
3329         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
3330         Updates MockResults to more closely resemble the updated
3331         LayoutTestResults class.
3332
3333         (MockResults.__init__):
3334         (MockResults.did_exceed_test_failure_limit):
3335         (ExpectedFailuresTest.test_can_trust_results):
3336         (ExpectedFailuresTest.test_unexpected_failures_observed):
3337         (ExpectedFailuresTest.test_unexpected_failures_observed_when_tree_is_hosed):
3338         (MockResults.failure_limit_count): Deleted.
3339         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
3340         Removes a FIXME regarding the use of the
3341         NON_INTERACTIVE_FAILURE_LIMIT_COUNT value.
3342
3343         (LayoutTestResultsReader.results):
3344         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
3345         Updates test to not check the now-nonexistant failure_count_limit
3346         method.
3347
3348         (test_missing_unit_test_results_path):
3349         (test_layout_test_results):
3350         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
3351         Accounts for name change: ResultsJSONParserTest ->
3352         ParsedJSONParserTest.
3353
3354         (RebaselineTestTest.test_gather_baselines):
3355
3356 2014-09-30  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3357
3358         [EFL] Rename TEST_THEME_DIR macro
3359         https://bugs.webkit.org/show_bug.cgi?id=137244
3360
3361         Reviewed by Csaba Osztrogonác.
3362
3363         TEST_THEME_DIR is to get a path for default theme though, it has used TEST_ prefix.
3364         DEFAULT_THEME_DIR is better than it.
3365
3366         * MiniBrowser/efl/main.c:
3367         (window_create):
3368         * TestWebKitAPI/efl/PlatformWebView.cpp:
3369         (TestWebKitAPI::PlatformWebView::PlatformWebView):
3370         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3371         (WTR::PlatformWebView::PlatformWebView):
3372
3373 2014-09-30  Alexey Proskuryakov  <ap@apple.com>
3374
3375         Windows EWS went purple when it failed to build
3376         https://bugs.webkit.org/show_bug.cgi?id=137267
3377
3378         Reviewed by Ryosuke Niwa.
3379
3380         * QueueStatusServer/app.yaml: Update the version.
3381
3382         * QueueStatusServer/model/attachment.py: (Attachment._calculate_queue_positions):
3383         Make it work for style and win-ews queues.
3384
3385 2014-09-29  Filip Pizlo  <fpizlo@apple.com>
3386
3387         It should be fun and easy to run every possible JavaScript benchmark from the command line
3388         https://bugs.webkit.org/show_bug.cgi?id=137245
3389
3390         Reviewed by Oliver Hunt.
3391         
3392         We previously had Tools/Scripts/bencher.  Then we stopped adding things to it because we
3393         weren't sure about the licensing of things like Kraken and Octane.  Various people ended up
3394         having their own private scripts for doing benchmark runs, and didn't share them in the open
3395         source community, because of fears about the shady licensing of the benchmarks suites that
3396         they were running. The dominant version of this was "run-jsc-benchmarks", which has a lot of
3397         excellent power - it can run benchmarks through either jsc, DumpRenferTree, or
3398         WebKitTestRunner; it can run tests on any number of remote machines; and it has inside
3399         knowledge about how to run *a lot* of test suites. Many of those test suites are not public,
3400         but some of them are. The non-public tests are exclusively those that were not made by any
3401         WebKit contributor, but which JSC/WebKit devs found useful for testing.
3402
3403         This fixes this weirdness by releasing run-jsc-benchmarks. The paths to the test suites
3404         whose licenses are incompatible with WebKit's (to the extent that they cannot be safely
3405         checked into WebKit svn at all) can be run by passing the path to them via a configuration
3406         file. The default configuration file is ~/.run-jsc-benchmarks. The most important benchmark
3407         suites are Octane version 2 and Kraken version 1.1. We should probably check Octane 2 into
3408         WebKit eventually because it seems that the license is fine. Kraken, on the other hand, will
3409         probably never be checked in because there is no license text anywhere in that benchmark.
3410         A valid ~/.run-jsc-benchmarks file will just be something like:
3411         
3412             {
3413                 "OctanePath": "/path/to/Octane2",
3414                 "KrakenPath": "/path/to/Kraken-1.1/tests/kraken-1.1"
3415             }
3416         
3417         If your ~/.run-jsc-benchmarks file omits the directory for any particular test suite, then
3418         run-jsc-benchmarks will just gracefully avoid running that test suite.
3419         
3420         Finally, a word about policy: it is understood that different organizations that do
3421         development on JSC may find themselves having internal benchmarks that they cannot share
3422         because of weird licensing. It happens - usually because the organization doing JSC
3423         development found some test in the wild that is owned by someone else and therefore cannot
3424         be shared. So, we should consider it acceptable to write patches against run-jsc-benchmarks
3425         that add support for some new kind of benchmark suite even if the suite is not made public
3426         as part of the same patch - so long as the patch isn't too invasive. An example of
3427         non-invasiveness is the DSPJS suite, which is implemented using some new classes (like
3428         DSPJSAmmoJSRegularBenchmark) and some calls to otherwise reusable functions (like
3429         emitSelfContainedBenchRunCode). It is obviously super helpful if a benchmark suite can be
3430         completely open-sourced and committed to the WebKit repo - but the reality is that this
3431         can't always be done safely.
3432
3433         * Scripts/bencher: Removed.
3434         * Scripts/run-jsc-benchmarks: Added.
3435
3436 2014-09-30  Roger Fong  <roger_fong@apple.com>
3437
3438         [Windows] Add some logging to webkitpy to debug timeout issues with running NRWT using multiple child processes.
3439
3440         * Scripts/webkitpy/port/drdiver.py:
3441         (Driver.stop):
3442         * Scripts/webkitpy/port/server_process.py:
3443         (ServerProcess.stop):
3444
3445 2014-09-30  Roger Fong  <roger_fong@apple.com>
3446
3447         [Windows] Back to 2 child processes for NRWT on Windows.
3448
3449         * Scripts/webkitpy/port/win.py:
3450         (WinPort.default_child_processes):
3451         Changing the number of processes to 1 did not have an effect on the layout test results. 
3452         It does introduce an issue with one of the workers hanging indefinitely and causing the 
3453         layout tests to timeout as a whole occasionally, but we should just fix that.
3454
3455 2014-09-30  Alexey Proskuryakov  <ap@apple.com>
3456
3457         Remove an accidentally committed line..
3458
3459         * QueueStatusServer/handlers/statusbubble.py:
3460         (StatusBubble._build_bubble):
3461
3462 2014-09-30  Alexey Proskuryakov  <ap@apple.com>
3463
3464         build.webkit.org/dashboard: Switch EWS view to using actual retry count
3465         https://bugs.webkit.org/show_bug.cgi?id=137240
3466
3467         Reviewed by Ryosuke Niwa.
3468
3469         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
3470         (EWSQueue.prototype.loadDetailedStatus):
3471         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js:
3472         (EWSQueueView.prototype._popoverContentForEWSQueue):
3473         Use the new retry_count data member from JSON.
3474
3475         * QueueStatusServer/app.yaml: Updating the version.
3476
3477         * QueueStatusServer/handlers/queuestatusjson.py: (QueueStatusJSON._rows_for_work_items):
3478         Instead of message_count, produce retry_count.
3479
3480 2014-09-30  Alexey Proskuryakov  <ap@apple.com>
3481
3482         EWS doesn't need to show all the bubbles when a patch fails to apply
3483         https://bugs.webkit.org/show_bug.cgi?id=137256
3484
3485         Reviewed by Ryosuke Niwa.
3486
3487         * QueueStatusServer/app.yaml: Updated app version.
3488
3489         * QueueStatusServer/handlers/statusbubble.py:
3490         (StatusBubble._build_bubble):
3491         (StatusBubble._build_bubbles_for_attachment):
3492         (StatusBubble.get):
3493         * QueueStatusServer/templates/statusbubble.html:
3494         When some queues fail to apply, and no queues had meaningful output (meaning that
3495         they will almost certainly fail to apply later), we can show a single bubble
3496         telling the user just that.
3497
3498 2014-09-30  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
3499
3500         [EFL] Bump EFL version to 1.11.2
3501         https://bugs.webkit.org/show_bug.cgi?id=137118
3502
3503         Reviewed by Gyuyoung Kim.
3504
3505         Disable NEON for EFL build because the build system doesn't pass the necessary -mfpu=neon flag to the compiler.
3506         Tools/efl/patches/ecore.patch: Removed, because this fix is already in EFL.
3507
3508         * efl/jhbuild.modules:
3509         * efl/patches/ecore.patch: Removed.
3510
3511 2014-09-30  Carlos Garcia Campos  <cgarcia@igalia.com>
3512
3513         REGRESSION(r173929): [GTK] TestInspector fails after r173929
3514         https://bugs.webkit.org/show_bug.cgi?id=137247
3515
3516         Reviewed by Philippe Normand.
3517
3518         Wait until can-attach property changes before trying to attach the
3519         inspector after resizing the view.
3520
3521         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspector.cpp:
3522         (testInspectorDefault):
3523
3524 2014-09-30  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3525
3526         Require Python 2.7 version
3527         https://bugs.webkit.org/show_bug.cgi?id=137112
3528
3529         Reviewed by Csaba Osztrogonác.
3530
3531         * Scripts/ensure-valid-python:
3532         (checkPythonVersion):
3533         * Scripts/webkitpy/common/version_check.py:
3534
3535 2014-09-30  Martin Hock  <mhock@apple.com>
3536
3537         Skip a JSC test after r174036.
3538         https://bugs.webkit.org/show_bug.cgi?id=137236
3539
3540         Reviewed by Csaba Osztrogonác.
3541
3542         * Scripts/run-javascriptcore-tests:
3543
3544 2014-09-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3545
3546         [GTK] [EFL] Install TestNetscapePlugin apart from the other libs.
3547         https://bugs.webkit.org/show_bug.cgi?id=137212
3548
3549         This moves TestNetscapePlugin to a new folder (lib/plugins).
3550         We should not use the same directory for TestNetscapePlugin and
3551         the other libraries, because we end up scanning all the .so in the
3552         lib dir for every test.
3553
3554         Reviewed by Carlos Garcia Campos.
3555
3556         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Set LIBRARY_OUTPUT_DIRECTORY to lib/plugins.
3557         * Scripts/webkitpy/port/efl.py:
3558         (EflPort.setup_environ_for_server): Update plugin path.
3559         * Scripts/webkitpy/port/gtk.py:
3560         (GtkPort.setup_environ_for_server): Update plugin path.
3561         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Update plugin path.
3562
3563 2014-09-29  Alexey Proskuryakov  <ap@apple.com>
3564
3565         A small change to EWS bubble text. Explain why there are messages for ineligible patches.
3566
3567         Rubber-stamped by Tim Horton.
3568
3569         * QueueStatusServer/app.yaml:
3570         * QueueStatusServer/handlers/statusbubble.py:
3571         (StatusBubble._build_bubble):
3572
3573 2014-09-29  Alexey Proskuryakov  <ap@apple.com>
3574
3575         Typo fix, suggested by Tim Horton.
3576
3577         * QueueStatusServer/handlers/statusbubble.py:
3578         (StatusBubble._build_message_for_provisional_failure):
3579
3580 2014-09-29  Alexey Proskuryakov  <ap@apple.com>
3581
3582         Improve Bugzilla status bubbles
3583         https://bugs.webkit.org/show_bug.cgi?id=137232
3584
3585         Reviewed by Ryosuke Niwa.
3586
3587         * QueueStatusServer/app.yaml: Will update again with an actual version when landing.
3588
3589         * QueueStatusServer/handlers/statusbubble.py: Eliminated yellow color, added
3590         blue and orange. Significantly extended tooltips. Made bubbles show up even for queues
3591         that are stuck, as it was only confusing that they disappeared after 99.
3592
3593         * QueueStatusServer/model/attachment.py: Removed functionality that was only used
3594         by old bubbles. We need a lot more information to determine color, so the implementation
3595         can not be here.
3596
3597         * QueueStatusServer/templates/statusbubble.html: Updated colors in CSS, made bubbles
3598         always have a link for consistency. Added code to convert timestamps in tooltips
3599         to local time zone.
3600
3601 2014-09-29  Commit Queue  <commit-queue@webkit.org>
3602
3603         Unreviewed, rolling out r174045.
3604         https://bugs.webkit.org/show_bug.cgi?id=137231
3605
3606         Introduced a crash during page loading tests on Mac (Requested
3607         by rniwa on #webkit).
3608
3609         Reverted changeset:
3610
3611         "Replace OSObjectPtr with RetainPtr/adoptOS"
3612         https://bugs.webkit.org/show_bug.cgi?id=137158
3613         http://trac.webkit.org/changeset/174045
3614
3615 2014-09-29  Tim Horton  <timothy_horton@apple.com>
3616
3617         Add Jake as a contributor.
3618
3619         * Scripts/webkitpy/common/config/contributors.json:
3620
3621 2014-09-29  Roger Fong  <roger_fong@apple.com>
3622
3623         [Windows] Skip a javascriptcore test following r174036.
3624
3625         * Scripts/run-javascriptcore-tests:
3626
3627 2014-09-29  Roger Fong  <roger_fong@apple.com>
3628
3629         [Windows] Reduce number of processes used by NRWT on Windows to 1.
3630
3631         * Scripts/webkitpy/port/win.py:
3632         (WinPort.default_child_processes):
3633         Reduce number of processes to 1 so we can get a good baseline for what failures
3634         we should be expecting to see from the Windows bots.
3635
3636 2014-09-29  Darin Adler  <darin@apple.com>
3637
3638         Tweak and tighten SVG font converter
3639         https://bugs.webkit.org/show_bug.cgi?id=136956
3640
3641         Reviewed by Myles Maxfield.
3642
3643         I was investigating behavior of String::toInt, String::toDouble, and
3644         String::toFloat for various failure cases, and decided to start some
3645         unit tests for those functions here.
3646
3647         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
3648         (TestWebKitAPI::TEST): Addded a first small bit of StringToInt and
3649         StringToDouble testing.
3650
3651 2014-09-29  Philippe Normand  <pnormand@igalia.com>
3652
3653         [GTK][CMake] TestWebCore target build sometimes fail
3654         https://bugs.webkit.org/show_bug.cgi?id=137207
3655
3656         Reviewed by Csaba Osztrogon.
3657
3658         * TestWebKitAPI/PlatformGTK.cmake: Make sure the forwarding
3659         headers are generated before the TestWebCore target is built.
3660
3661 2014-09-29  Carlos Garcia Campos  <cgarcia@igalia.com>
3662
3663         [GTK] Remove IntPointGtk.cpp and IntRectGtk.cpp
3664         https://bugs.webkit.org/show_bug.cgi?id=137209
3665
3666         Reviewed by Philippe Normand.
3667
3668         * TestWebKitAPI/PlatformGTK.cmake: Remove unneeded IntRectGtk.cpp
3669         from the WebCore test sources.
3670
3671 2014-09-28  Myles C. Maxfield  <mmaxfield@apple.com>
3672
3673         Allow webkit-patch upload to respect the --directory argument with git checkouts
3674         https://bugs.webkit.org/show_bug.cgi?id=137166
3675
3676         Reviewed by Darin Adler.
3677
3678         We simply hadn't plumbed it through.
3679
3680         * Scripts/webkitpy/common/checkout/scm/detection.py:
3681         (SCMDetector.detect_scm_system):
3682         * Scripts/webkitpy/common/checkout/scm/git.py:
3683         (Git.__init__):
3684         (Git.changed_files):
3685
3686 2014-09-26  Sam Weinig  <sam@webkit.org>
3687
3688         Replace OSObjectPtr with RetainPtr/adoptOS
3689         https://bugs.webkit.org/show_bug.cgi?id=137158
3690
3691         Reviewed by Dan Bernstein.
3692
3693         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3694         * TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp: Removed.
3695         * TestWebKitAPI/Tests/WTF/darwin/RetainPtrOSObject.cpp: Copied from Tools/TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp.
3696         Rename and change test to use RetainPtr. Remove now unneeded part testing WTF::retainOSObject/WTF::releaseOSObject.
3697
3698 2014-09-26  Filip Pizlo  <fpizlo@apple.com>
3699
3700         Disable function.arguments
3701         https://bugs.webkit.org/show_bug.cgi?id=137167
3702
3703         Rubber stamped by Geoffrey Garen
3704         
3705         Enable the feature by default during tests.
3706
3707         * Scripts/run-jsc-stress-tests:
3708
3709 2014-09-26  Beth Dakin  <bdakin@apple.com>
3710
3711         Many platform/mac-wk2/tiled-drawing/ tests fail when run on a retina device
3712         https://bugs.webkit.org/show_bug.cgi?id=137089
3713
3714         Reviewed by Tim Horton.
3715
3716         This is a little sneaky since updateWindowScaleForTest() should ensure that these 
3717         tests run at 1x, but that code does not seem to execute at the right time for 
3718         these tests, so if we just ensure we start out at 1x, that appears to fix these 
3719         tests and does not break the HiDPI tests either.
3720         * WebKitTestRunner/TestController.cpp:
3721         (WTR::TestController::createWebViewWithOptions):
3722
3723 2014-09-26  Roger Fong  <roger_fong@apple.com>
3724
3725         [Windows] Decrease default number of child processes used by Windows.
3726
3727         * Scripts/webkitpy/port/win.py:
3728         (WinPort.default_child_processes):
3729         Having too many seems to cause many tests to crash or timeout. 
3730         We may even need to make it have only 1 child process if we’re still seeing problems after this.
3731
3732 2014-09-26  Alexey Proskuryakov  <ap@apple.com>
3733
3734         Mac EWS bots do not keep logs as promised
3735         https://bugs.webkit.org/show_bug.cgi?id=137151
3736
3737         Reviewed by Ryosuke Niwa.
3738
3739         * EWSTools/start-queue-mac.sh: Actually keep the logs for 14 days.
3740
3741 2014-09-26  Alexey Proskuryakov  <ap@apple.com>
3742
3743         Get rid of webkit-queues dashboard
3744         https://bugs.webkit.org/show_bug.cgi?id=137141
3745
3746         Reviewed by Ryosuke Niwa.
3747
3748         * QueueStatusServer/app.yaml: Updated version.
3749
3750         * QueueStatusServer/templates/dashboard.html: Removed.
3751         * QueueStatusServer/handlers/dashboard.py: Removed.
3752         * QueueStatusServer/main.py:
3753         Kill it!
3754
3755         * QueueStatusServer/stylesheets/common.css: Copied from Tools/QueueStatusServer/stylesheets/dashboard.css.
3756         (.status-cell): Deleted.
3757         (.status-cell:hover): Deleted.
3758         (.status-cell.pass): Deleted.
3759         (.status-cell.fail): Deleted.
3760         (.status-cell.pending): Deleted.
3761         (.status-cell.error): Deleted.
3762         * QueueStatusServer/stylesheets/dashboard.css: Removed.
3763         * QueueStatusServer/templates/activebots.html:
3764         * QueueStatusServer/templates/patch.html:
3765         * QueueStatusServer/templates/queuestatus.html:
3766         * QueueStatusServer/templates/recentstatus.html:
3767         Renamed dashboard.css to common.css, and removed dashboard-only rules.
3768
3769 2014-09-26  Alexey Proskuryakov  <ap@apple.com>
3770
3771         Get rid of Retry status in webkit-queues
3772         https://bugs.webkit.org/show_bug.cgi?id=137135
3773
3774         Reviewed by Ryosuke Niwa.
3775
3776         * QueueStatusServer/config/messages.py: Removed Retry.
3777
3778         * QueueStatusServer/handlers/releasepatch.py: This is now straightforward, as it
3779         no longer needs to check the latest status. It just always both unlocks the patch
3780         and removes it from WorkItems.
3781
3782         * QueueStatusServer/handlers/submittoews.py: (SubmitToEWS._should_add_to_ews_queue):
3783         I don't understand why we even needed to check for retries here, but now that there
3784         are no retries, that code can go to /dev/null.
3785
3786         * QueueStatusServer/loggers/recordpatchevent.py:
3787         (RecordPatchEvent.started):
3788         (RecordPatchEvent.retrying): Deleted.
3789         Fixed retry counting, it should work for all queues now.
3790
3791         * QueueStatusServer/model/queuestatus.py:
3792         (QueueStatus.is_retry_request): Deleted. These are no more.
3793
3794         * Scripts/webkitpy/common/net/statusserver_mock.py:
3795         (MockStatusServer.release_lock):
3796         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3797         Did whatever it took to keep passing the tests. The particular test doesn't seem
3798         quite right, but whatever.
3799
3800         * Scripts/webkitpy/tool/commands/queues.py:
3801         (CommitQueue.process_work_item): Instead of posting a retry status, just unlock
3802         and let others pick up. Also, added explicit returns for clarity.
3803         (AbstractPatchQueue._did_retry): Deleted.
3804
3805 2014-09-26  Csaba Osztrogonác  <ossy@webkit.org>
3806
3807         [EFL] Fix the gst-libav build on ARM Thumb2
3808         https://bugs.webkit.org/show_bug.cgi?id=137022
3809
3810         Reviewed by Zoltan Herczeg.
3811
3812         * efl/jhbuild.modules:
3813         * efl/patches/gst-libav.patch: Added.
3814
3815 2014-09-26  Akos Kiss  <akiss@inf.u-szeged.hu>
3816
3817         [EFL] Bump up dependencies not to conflict with the GTK port.
3818         https://bugs.webkit.org/show_bug.cgi?id=137143
3819
3820         Reviewed by Gyuyoung Kim.
3821
3822         Tools/efl/install-dependencies and Tools/gtk/install-dependencies keep
3823         installing and removing different versions of libgnutls-dev, thus
3824         hindering the development for both ports on the same machine. GTK is
3825         using the newer version of the package, now bumping up EFL to use the 
3826         same.
3827
3828         * efl/install-dependencies:
3829
3830 2014-09-25  Rohit Kumar  <kumar.rohit@samsung.com>
3831
3832         [EFL][WK2] Minibrowser : Fix the 'Escape' button issue to exit fullscreen
3833         https://bugs.webkit.org/show_bug.cgi?id=136854
3834
3835         Reviewed by Gyuyoung Kim.
3836
3837         'Escape' key should exit fullscreen first and then should be used to stop page load.
3838
3839         * MiniBrowser/efl/main.c:
3840         (on_key_down):
3841
3842 2014-09-25  Dean Jackson  <dino@apple.com>
3843
3844         Add Said to the contributors list so his name completes in bugzilla.
3845
3846         * Scripts/webkitpy/common/config/contributors.json:
3847
3848 2014-09-25  Alexey Proskuryakov  <ap@apple.com>
3849
3850         EWS only repeats its cycle every two hours
3851         https://bugs.webkit.org/show_bug.cgi?id=137129
3852
3853         Reviewed by Ryosuke Niwa.
3854
3855         * QueueStatusServer/app.yaml: Updated version.
3856
3857         * QueueStatusServer/config/queues.py: Moved timeout from activeworkitems.py to configuration.
3858
3859         * QueueStatusServer/handlers/releaselock.py: Added. Releases the lock without removing
3860         the patch from work items.
3861
3862         * QueueStatusServer/index.yaml: No real change, just let AppEngine have its way with entry order.
3863
3864         * QueueStatusServer/main.py: Added release-lock.
3865
3866         * QueueStatusServer/model/activeworkitems.py:
3867         (ActiveWorkItems.deactivate_expired): Use timeout from configuration.
3868
3869         * QueueStatusServer/model/workitems.py: Added move_to_end. When we unlock a patch,
3870         we don't want it to be immediately picked up again, it's better to give other patches
3871         a chance.
3872
3873         * QueueStatusServer/templates/releaselock.html: Added. Not sure why all commands have
3874         these interactive versions, but OK.
3875
3876         * Scripts/webkitpy/tool/commands/earlywarningsystem.py: (AbstractEarlyWarningSystem.review_patch):
3877         Unlock the patch when a non-final failure occurs (e.g. can't build even without the patch,
3878         or svn is down).
3879
3880         * Scripts/webkitpy/tool/commands/queues.py:
3881         (AbstractReviewQueue.process_work_item): Do not try/catch ScriptError around review_patch.
3882         Style queue never raises these, and EWS already calls _did_fail, before re-throwing,
3883         meaning that these handlers could never do the right thing. We'd either get a duplicate
3884         _did_fail, or try to unlock an already unlocked patch.
3885         (StyleQueue.review_patch): Unlock the patch on transient failure (such as svn failure),
3886         making it eligible for retry immediately.
3887
3888         * Scripts/webkitpy/common/net/statusserver.py:
3889         (StatusServer._post_release_lock):
3890         (StatusServer.release_lock):
3891         Added a call to release-lock.
3892
3893 2014-09-25  Roger Fong  <roger_fong@apple.com>
3894
3895         [Windows] Followup to r173972. Don’t set child process to none before reading from stdout.
3896
3897         * Scripts/webkitpy/common/system/path.py:
3898         (_CygPath.convert):
3899
3900 2014-09-25  Roger Fong  <roger_fong@apple.com>
3901
3902         [Windows] Close stdin to force a flush to stdout if no test path is read during layout tests.
3903
3904         * Scripts/webkitpy/common/system/path.py:
3905         (_CygPath.convert):
3906
3907 2014-09-25  Carlos Garcia Campos  <cgarcia@igalia.com>
3908
3909         [Gtk] build.sh needs a -- before make options when the build command is cmake --build
3910         https://bugs.webkit.org/show_bug.cgi?id=136377
3911
3912         Reviewed by Philippe Normand.
3913
3914         * Scripts/webkitdirs.pm:
3915         (buildCMakeGeneratedProject): Only use the build.sh script if it exists.
3916
3917 2014-09-25  Akos Kiss  <akiss@inf.u-szeged.hu>
3918
3919         [EFL] Split the list of dependencies to make sure that at least the universally available packages get installed
3920         https://bugs.webkit.org/show_bug.cgi?id=137117
3921
3922         Tools/efl/install-dependencies relies on apt-get to install packages.
3923         Unfortunately, if a package does not exist (e.g., for a given
3924         architecture) then apt-get install is not able to ignore the missing
3925         package and install the rest but fails to run entirely (and there
3926         seems to be no intent to change this behaviour).
3927
3928         On ARM64, the luajit package is missing and currently it needs manual
3929         editing of install-dependencies to get the script install as much as it
3930         can.
3931
3932         This patch separates the installation of the universally available
3933         packages from those which might not be available for all architectures.
3934
3935         Reviewed by Gyuyoung Kim.
3936
3937         * efl/install-dependencies:
3938
3939 2014-09-25  Csaba Osztrogonác  <ossy@webkit.org>
3940
3941         Remove WinCE port from trunk
3942         https://bugs.webkit.org/show_bug.cgi?id=136951
3943
3944         Reviewed by Alex Christensen.
3945
3946         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
3947         (_should_file_trigger_build):
3948         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
3949         (ShouldBuildTest):
3950         * CMakeLists.txt:
3951         * DumpRenderTree/win/DRTDataObject.cpp:
3952         (DRTDataObject::CopyMedium):
3953         * Scripts/build-webkit:
3954         * Scripts/webkit-build-directory:
3955         * Scripts/webkitdirs.pm:
3956         (argumentsForConfiguration):
3957         (builtDylibPathForName):
3958         (isAppleWinWebKit):
3959         (launcherPath):
3960         (launcherName):
3961         (shouldRemoveCMakeCache):
3962         (cmakeBasedPortArguments):
3963         (cmakeBasedPortName):
3964         (isCMakeBuild):
3965         (isWinCE): Deleted.
3966         (determineIsWinCE): Deleted.
3967         * Scripts/webkitperl/FeatureList.pm:
3968         * Scripts/webkitpy/port/port_testcase.py:
3969         (test_apache_config_file_name_for_platform):
3970         * TestWebKitAPI/config.h:
3971         * WinCELauncher/CMakeLists.txt: Removed.
3972         * WinCELauncher/main.cpp: Removed.
3973         * gtk/manifest.txt:
3974
3975 2014-09-23  David Farler  <dfarler@apple.com>
3976
3977         [iOS] run-webkit-tests should support minor versions under devices and create a testing device under the right runtime
3978         https://bugs.webkit.org/show_bug.cgi?id=136895
3979
3980         Reviewed by David Kilzer.
3981
3982         Create Device, DeviceType, and Runtime data classes.
3983         Create Simulator class represent simctl output.
3984
3985         Wherever possible, use structured data classes anywhere a raw
3986         identifier or UDID string was used for a cleaner implementation
3987         and to encapsulate the inherent fragility of scraping simctl output.
3988
3989         Create a suitably named testing device if one doesn't exist.
3990
3991         Finally, accurately handle having multiple simulator runtimes (SDKs)
3992         installed in the active Xcode.app bundle.
3993
3994         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3995         (_set_up_derived_options):
3996         * Scripts/webkitpy/port/driver.py:
3997         (IOSSimulatorDriver.cmd_line):
3998         Construct DeviceType and Runtime objects from identifiers passed at the
3999         command line, still providing sensible defaults for 32- and 64-bit testing.
4000         * Scripts/webkitpy/port/ios.py:
4001         (IOSSimulatorPort.__init__):
4002         (IOSSimulatorPort.setup_test_run):
4003         (IOSSimulatorPort):
4004         (IOSSimulatorPort.testing_device):
4005         Cache the testing device once it is created or found.
4006         (IOSSimulatorPort.reset_preferences):
4007         Get the device path from the Device object instead of consructing it
4008         in the port class.
4009         (IOSSimulatorPort.simulator_udid): Deleted.
4010         Get the UDID from the testing_device :: Device object itself.
4011         * Scripts/webkitpy/xcode/simulator.py:
4012         Created Device, DeviceType, Runtime, and Simulator classes.
4013         (get_runtimes): Deleted.
4014         (get_devices): Deleted.
4015         (get_device_types): Deleted.
4016         (get_latest_runtime): Deleted.
4017
4018 2014-09-24  Roger Fong  <roger_fong@apple.com>
4019
4020         [Windows] Tentative fix for Windows test bots.
4021
4022         * Scripts/webkitpy/common/system/path.py:
4023         (_CygPath.convert):
4024
4025 2014-09-24  Alexey Proskuryakov  <ap@apple.com>
4026
4027         Change more build.webkit.org links to https
4028         https://bugs.webkit.org/show_bug.cgi?id=137049
4029
4030         Reviewed by Csaba Osztrogonác.
4031
4032         Fix appspot, svn.webkit.org and Trac links.
4033
4034         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4035         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html:
4036         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
4037         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js:
4038         (ViewController.prototype._domForBuildName):
4039         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
4040         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
4041         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
4042         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
4043         (.):
4044         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
4045         (EWS):
4046         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
4047         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitTestHistory.js:
4048         (TestHistory):
4049         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
4050
4051 2014-09-24  Langó László  <llango.u-szeged@partner.samsung.com>
4052
4053         Update the list of u-szeged contributors.
4054
4055         Rubber-stamped by Csaba Osztrogonác <ossy@webkit.org>.
4056
4057         * Scripts/webkitpy/common/config/contributors.json:
4058
4059 2014-09-23  Roger Fong  <roger_fong@apple.com>
4060
4061         [Windows] More debugging for the Windows bots.
4062
4063         * Scripts/webkitpy/common/system/path.py:
4064         (_CygPath):
4065
4066 2014-09-23  Roger Fong  <roger_fong@apple.com>
4067
4068         Unreviewed. Fix for r173899, those tabs should be spaces.
4069
4070         * Scripts/webkitpy/port/driver.py:
4071         (Driver._command_from_driver_input):
4072         (Driver): Deleted.
4073
4074 2014-09-23  Roger Fong  <roger_fong@apple.com>
4075
4076         [Windows] Add some logging to debug a problem with the Windows bots that causes layout tests to exit early.
4077
4078         * Scripts/webkitpy/port/driver.py:
4079         (Driver):
4080
4081 2014-09-23  Jer Noble  <jer.noble@apple.com>
4082
4083         [Tools] git-commit uses wrong ChangeLog when run from a subdirectory
4084         https://bugs.webkit.org/show_bug.cgi?id=137031
4085
4086         Reviewed by Joseph Pecoraro.
4087
4088         commit-log-editor is run from the top of the Git checkout, even when git-commit is invoked
4089         from a subdirectory, making the parsed locations of ChangeLog files incorrect. Git provides
4090         a mapping prefix in the GIT_PREFIX environment variable, so apply this prefix to the parsed
4091         ChangeLog locations before passing them to createCommitMessage().
4092
4093         * Scripts/commit-log-editor:
4094
4095 2014-09-23  Youenn Fablet  <youenn.fablet@crf.canon.fr>
4096
4097         W3C test importer should detect manual and reference tests according their filenames
4098         https://bugs.webkit.org/show_bug.cgi?id=133852
4099
4100         Reviewed by Bem Jones-Bey.
4101
4102         * Scripts/webkitpy/w3c/test_parser.py:
4103         (TestParser.analyze_test): Adding checks based on WPT filename rules.
4104         (TestParser.is_wpt_manualtest): Detecting whether the test is a manual test based on its filename.
4105         (TestParser):
4106         (TestParser.potential_ref_filename): Getting the potential reference filename of a test from its filename.
4107         (TestParser.is_wpt_reftest): Detecting whether the test is a ref test based on its filename.
4108         * Scripts/webkitpy/w3c/test_parser_unittest.py:
4109         (test_analyze_manual_wpt_test): Adding a test for a "-manual.html" file with testharness.js link in it. 
4110
4111 2014-09-23  Bem Jones-Bey  <bjonesbe@adobe.com>
4112
4113         Unreviewed, add Rebecca Hauck as a contributor.
4114
4115         * Scripts/webkitpy/common/config/contributors.json:
4116
4117 2014-09-23  David Kilzer  <ddkilzer@apple.com>
4118
4119         Switch build.webkit.org URLs to https
4120
4121         Reviewed by Lucas Forschler and Alexey Proskuryakov.
4122
4123         * TestResultServer/app.yaml: Update version to this commit
4124         revision.
4125
4126         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4127         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
4128         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
4129         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/WebKitBuildbot.js:
4130         (WebKitBuildbot):
4131         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
4132         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
4133         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
4134         (.):
4135         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
4136         (WebKitBuildbot):
4137         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
4138         * Scripts/webkitpy/common/config/urls.py:
4139         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
4140         (test_builder_with_name):
4141         * Scripts/webkitpy/tool/commands/queries.py:
4142         (TreeStatus):
4143         * TestResultServer/generate_builders_json.py:
4144         (main):
4145         * TestResultServer/generate_builders_json_unittest.py:
4146         (GenerateBuildersJsonTest.test_generate_json_data.dummy_fetch_json):
4147         (GenerateBuildersJsonTest):
4148         (GenerateBuildersJsonTest.test_generate_json_data):
4149         * TestResultServer/static-dashboards/builders.jsonp:
4150         * TestResultServer/static-dashboards/flakiness_dashboard.js:
4151         (loadExpectationsLayoutTests):
4152         * TestResultServer/static-dashboards/timeline_explorer.js:
4153
4154 2014-09-23  Youenn Fablet  <youenn.fablet@crf.canon.fr>
4155
4156         W3C test importer should copy .htaccess files
4157         https://bugs.webkit.org/show_bug.cgi?id=136850
4158
4159         Reviewed by Bem Jones-Bey.
4160
4161         * Scripts/webkitpy/w3c/test_importer.py:
4162         (TestImporter.should_skip_file): Helper function to check whether to skip file or not. Added ".htaccess" file specific check.
4163         (TestImporter):
4164         (TestImporter.find_importable_tests): Making use of new helper function.
4165
4166 2014-09-23  Alexey Proskuryakov  <ap@apple.com>
4167
4168         Trying to revive bot watcher's dashboard after HSTS.
4169
4170         Unreviewed.
4171
4172         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
4173         (WebKitBuildbot): It looks like XMLHttpRequest may not like HSTS redirects, let's try to avoid these.
4174
4175 2014-09-23  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
4176
4177         Make Tools/BuildSlaveSupport/wait-for-SVN-server.py handle server donwtime
4178         https://bugs.webkit.org/show_bug.cgi?id=137026
4179
4180         Reviewed by Csaba Osztrogonác.
4181
4182         * BuildSlaveSupport/wait-for-SVN-server.py:
4183         (getLatestSVNRevision):
4184         (waitForSVNRevision):
4185
4186 2014-09-23  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
4187
4188         Remove unlinkZeroFiles from build-webkit
4189         https://bugs.webkit.org/show_bug.cgi?id=137018
4190
4191         Reviewed by Csaba Osztrogonác.
4192
4193         * Scripts/build-webkit:
4194         (unlinkZeroFiles): Deleted.
4195
4196 2014-09-23  Rohit Kumar  <kumar.rohit@samsung.com>
4197
4198         [GTK] Minibrowser : Add keyboard support for stop page load
4199         https://bugs.webkit.org/show_bug.cgi?id=136857
4200
4201         Reviewed by Philippe Normand.
4202
4203         Keyboard support to stop page load in GTK Minibrowser using F6 and Escape keys.
4204
4205         * MiniBrowser/gtk/BrowserWindow.c:
4206         (stopPageLoad): Callback to stop page load.
4207         (browser_window_init):
4208
4209 2014-09-22  Rohit Kumar  <kumar.rohit@samsung.com>
4210
4211         [EFL][WK2] Minibrowser : Add keyboard support for page reload while ignoring cache
4212         https://bugs.webkit.org/show_bug.cgi?id=136813
4213
4214         Reviewed by Gyuyoung Kim.
4215
4216         Ctrl+r is used for page reload along with F5. Ctrl+Shift+r and Ctrl+F5 is used for page reload while ignoring cache.
4217
4218         * MiniBrowser/efl/main.c:
4219         (on_key_down):
4220
4221 2014-09-22  Daniel Bates  <dabates@apple.com>
4222
4223         [Cocoa] Add UI delegate callback when window.close() is called
4224         https://bugs.webkit.org/show_bug.cgi?id=137008
4225         <rdar://problem/17801001>
4226
4227         Reviewed by Anders Carlsson.
4228
4229         Add a test to ensure that -[WKUIDelegatePrivate _webViewClose:] is called on window.close()
4230         for window opened via JavaScript (i.e. window.open()).
4231
4232         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4233         * TestWebKitAPI/Tests/WebKit2/open-and-close-window.html: Added.
4234         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm: Added.
4235
4236 2014-09-22  Youenn Fablet  <youennf@gmail.com>
4237
4238         W3C importer should import html files within resources folders
4239         https://bugs.webkit.org/show_bug.cgi?id=127548
4240
4241         Reviewed by Ryosuke Niwa.
4242         
4243         Import HTML files in any folder named "resources" even if file is not detected as a HTML test file 
4244
4245         * Scripts/webkitpy/w3c/test_importer.py:
4246         (TestImporter.find_importable_tests):
4247
4248 2014-09-22  Carlos Garcia Campos  <cgarcia@igalia.com>
4249
4250         [GTK] Test /webkit2/WebKitWebView/can-show-mime-type fails if evince browser plugin is installed
4251         https://bugs.webkit.org/show_bug.cgi?id=136998
4252
4253         Reviewed by Philippe Normand.
4254
4255         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
4256         (testWebViewCanShowMIMEType): Remove the check of PDF as
4257         unsupported MIME type.
4258
4259 2014-09-22  Carlos Garcia Campos  <cgarcia@igalia.com>
4260
4261         Unreviewed. Fix WebKitGTKTranslations rule in watchlist.
4262
4263         In r145081 GTK+ translations were moved from Source/WebKit/gtk/po/
4264         to Source/WebCore/platform/gtk/po/ but the rule was not updated.
4265
4266         * Scripts/webkitpy/common/config/watchlist: Use
4267         Source/WebCore/platform/gtk/po/ as directory to watch for
4268         WebKitGTKTranslations rule and add berto and myself to the list of
4269         watchers.
4270
4271 2014-09-22  Ryuan Choi  <ryuan.choi@gmail.com>
4272
4273         Fix syntaxError in watchlist since r173594
4274         https://bugs.webkit.org/show_bug.cgi?id=136996
4275
4276         Reviewed by Philippe Normand.
4277
4278         * Scripts/webkitpy/common/config/watchlist: Removed unnecessary comma.
4279
4280 2014-09-20  Sam Weinig  <sam@webkit.org>
4281
4282         Make possible HashSet<std::uni