[iOS DRT] Make iOS DRT use the same window size as WebKitTestRunner for flexible...
[WebKit-https.git] / Tools / ChangeLog
1 2016-08-24  Simon Fraser  <simon.fraser@apple.com>
2
3         [iOS DRT] Make iOS DRT use the same window size as WebKitTestRunner for flexible viewport tests
4         https://bugs.webkit.org/show_bug.cgi?id=161124
5
6         Reviewed by Daniel Bates.
7         
8         Use the main UIScreen's bounds for the size of the window in flexible viewport mode,
9         and remove the 'phoneBrowserAddressBarOffset' hack, so that it matches WTR.
10         
11         Remove some unnecessary zero initializations of static variables.
12         
13         Change _setVisibleSize to use the window size, which should not be a behavior change
14         because this it just used for text autosizing, which is disabled by default,
15         and only the width is consulted.
16
17         * DumpRenderTree/mac/DumpRenderTree.mm:
18         (adjustWebDocumentForFlexibleViewport):
19         (adjustWebDocumentForStandardViewport):
20         (createWebViewAndOffscreenWindow):
21
22 2016-08-24  Jonathan Bedard  <jbedard@apple.com>
23
24         WebKit2 needs layoutTestController.setDeferMainResourceDataLoad
25         https://bugs.webkit.org/show_bug.cgi?id=42777
26
27         Reviewed by Darin Adler.
28
29         The setDeferMainResourceDataLoad method was not correctly tested in DumpRenderTree and would pass even when setDeterMainResourceDataLoad was not called.  Removed function and test.
30
31         * DumpRenderTree/TestRunner.cpp:
32         (setDeferMainResourceDataLoadCallback): Removed setDeferMainResourceDataLoad.
33         * DumpRenderTree/TestRunner.h:
34         (TestRunner::deferMainResourceDataLoad): Ditto.
35         (TestRunner::setDeferMainResourceDataLoad): Ditto.
36         * DumpRenderTree/mac/ResourceLoadDelegate.mm: Ditto.
37
38 2016-08-23  Anders Carlsson  <andersca@apple.com>
39
40         Add enum traits and use them in the IPC::Decoder
41         https://bugs.webkit.org/show_bug.cgi?id=161103
42
43         Reviewed by Sam Weinig.
44
45         Add API test.
46
47         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
48         * TestWebKitAPI/Tests/WTF/EnumTraits.cpp: Added.
49         (TestWebKitAPI::TEST):
50
51 2016-08-24  Filip Pizlo  <fpizlo@apple.com>
52
53         Unreviewed, roll out r204901, r204897, r204866, r204856, r204854.
54
55         * DumpRenderTree/TestRunner.cpp:
56         * DumpRenderTree/mac/DumpRenderTree.mm:
57         (DumpRenderTreeMain):
58         * Scripts/run-jsc-stress-tests:
59         * TestWebKitAPI/Tests/WTF/Vector.cpp:
60         (TestWebKitAPI::TEST):
61
62 2016-08-24  Simon Fraser  <simon.fraser@apple.com>
63
64         Try to fix Production builds.
65         
66         PRODUCTION_FRAMEWORKS_DIR was undefined here.
67
68         * DumpRenderTree/mac/Configurations/Base.xcconfig:
69
70 2016-08-24  Dan Bernstein  <mitz@apple.com>
71
72         Add a convenience function for creating a WKFrameHandleRef from a WKFrameRef without going through WKFrameInfoRef
73         https://bugs.webkit.org/show_bug.cgi?id=161152
74
75         Reviewed by Anders Carlsson.
76
77         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
78         * TestWebKitAPI/Tests/WebKit2/FrameHandle.cpp: Added.
79         (TestWebKitAPI::didFinishLoadForFrame):
80         (TestWebKitAPI::TEST):
81
82 2016-08-24  Nan Wang  <n_wang@apple.com>
83
84         AX: Add test for line text marker range on iOS
85         https://bugs.webkit.org/show_bug.cgi?id=161108
86         <rdar://problem/27976405>
87
88         Reviewed by Chris Fleizach.
89
90         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
91         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
92         (AccessibilityUIElement::textMarkerRangeForElement):
93         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
94         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
95         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
96
97 2016-08-24  Per Arne Vollan  <pvollan@apple.com>
98
99         [Win] Warning fixes.
100         https://bugs.webkit.org/show_bug.cgi?id=161079
101
102         Reviewed by Brent Fulgham.
103
104         * MiniBrowser/win/WebDownloadDelegate.cpp:
105         * MiniBrowser/win/WinMain.cpp:
106         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
107         (TestWebKitAPI::TEST):
108
109 2016-08-23  Simon Fraser  <simon.fraser@apple.com>
110
111         Fix Windows DRT build.
112
113         * DumpRenderTree/win/TestRunnerWin.cpp:
114         (TestRunner::mainFrameJSContext):
115
116 2016-08-23  Simon Fraser  <simon.fraser@apple.com>
117
118         Try to fix Windows build.
119         
120         Pass Tools/DumpRenderTree/Bindings as the working directory for the generate_bindings.pl
121         so that perl finds CodeGeneratorDumpRenderTree.pm.
122
123         * DumpRenderTree/CMakeLists.txt:
124
125 2016-08-23  Simon Fraser  <simon.fraser@apple.com>
126
127         Hook up UIScriptController in DumpRenderTree
128         https://bugs.webkit.org/show_bug.cgi?id=161064
129
130         Reviewed by Sam Weinig.
131
132         Add a skeleton implementation of UIScriptController to DumpRenderTree, building for both
133         Mac and iOS. Currently this is sufficient to test doAsyncTask(), enabling two tests
134         in fast/harness which test this.
135
136         Add a DerivedSources target to DumpRenderTree to invoke DerivedSources.make.
137
138         Move related code shared between WTR and DRT into Tools/TestRunnerShared, and cleanse it of
139         WK2-isms. Fix the makefiles to refer to the new location.
140
141         Hook up TestRunner::runUIScript() for DumpRenderTree, which requires keeping track of callbacks
142         by ID and firing them once they are complete.
143
144         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm: Added (copied from WTR).
145         * DumpRenderTree/CMakeLists.txt:
146         * DumpRenderTree/DerivedSources.make: Copied from Tools/WebKitTestRunner/DerivedSources.make.
147         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
148         * DumpRenderTree/TestRunner.cpp:
149         (runUIScriptCallback):
150         (TestRunner::staticFunctions):
151         (TestRunner::cacheTestRunnerCallback):
152         (TestRunner::callTestRunnerCallback):
153         (TestRunner::clearTestRunnerCallbacks):
154         (nextUIScriptCallbackID):
155         (TestRunner::runUIScript):
156         (TestRunner::callUIScriptCallback):
157         (TestRunner::uiScriptDidComplete):
158         (TestRunner::cleanup):
159         * DumpRenderTree/TestRunner.h:
160         * DumpRenderTree/ios/UIScriptControllerIOS.mm: Added.
161         * DumpRenderTree/mac/Configurations/Base.xcconfig: DerivedSources.make needs WEBCORE_PRIVATE_HEADERS_DIR to be defined.
162         * DumpRenderTree/mac/DumpRenderTree.mm:
163         (runTest):
164         * DumpRenderTree/mac/TestRunnerMac.mm:
165         (TestRunner::mainFrameJSContext):
166         * DumpRenderTree/mac/UIScriptControllerMac.mm: Copied from Tools/WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h.
167         (WTR::UIScriptController::doAsyncTask):
168         * DumpRenderTree/win/DumpRenderTree.cpp:
169         * TestRunnerShared/Bindings/JSWrappable.h: Renamed from Tools/WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h.
170         (WTR::JSWrappable::~JSWrappable):
171         (WTR::JSValueMakeStringOrNull):
172         * TestRunnerShared/Bindings/JSWrapper.cpp: Renamed from Tools/WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp.
173         (WTR::JSWrapper::wrap):
174         (WTR::JSWrapper::unwrap):
175         (WTR::unwrapObject):
176         (WTR::JSWrapper::initialize):
177         (WTR::JSWrapper::finalize):
178         * TestRunnerShared/Bindings/JSWrapper.h: Renamed from Tools/WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h.
179         (WTR::toJS):
180         (WTR::setProperty):
181         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl: Renamed from Tools/WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl.
182         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp: Renamed from Tools/WebKitTestRunner/UIScriptContext/UIScriptContext.cpp.
183         * TestRunnerShared/UIScriptContext/UIScriptContext.h: Renamed from Tools/WebKitTestRunner/UIScriptContext/UIScriptContext.h.
184         (WTR::UIScriptContext::currentParentCallbackIsPendingCompletion):
185         * TestRunnerShared/UIScriptContext/UIScriptController.cpp: Renamed from Tools/WebKitTestRunner/UIScriptContext/UIScriptController.cpp.
186         * TestRunnerShared/UIScriptContext/UIScriptController.h: Renamed from Tools/WebKitTestRunner/UIScriptContext/UIScriptController.h.
187         * WebKitTestRunner/CMakeLists.txt:
188         * WebKitTestRunner/DerivedSources.make:
189         * WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h:
190         (WTR::JSWrappable::~JSWrappable): Deleted.
191         (WTR::JSValueMakeStringOrNull): Deleted.
192         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp:
193         (WTR::JSWrapper::wrap): Deleted.
194         (WTR::JSWrapper::unwrap): Deleted.
195         (WTR::unwrapObject): Deleted.
196         (WTR::JSWrapper::initialize): Deleted.
197         (WTR::JSWrapper::finalize): Deleted.
198         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h:
199         (WTR::toJS): Deleted.
200         (WTR::setProperty): Deleted.
201         * WebKitTestRunner/TestInvocation.cpp:
202         (WTR::TestInvocation::runUISideScript):
203         (WTR::TestInvocation::uiScriptDidComplete):
204         * WebKitTestRunner/TestInvocation.h:
205         * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp: Moved
206         * WebKitTestRunner/UIScriptContext/UIScriptContext.h: Moved
207         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp: Moved
208         * WebKitTestRunner/UIScriptContext/UIScriptController.h: Moved
209         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
210         * WebKitTestRunner/config.h:
211         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
212         (WTR::UIScriptController::contentVisibleRect):
213
214 2016-08-23  Saam Barati  <sbarati@apple.com>
215
216         JSC should have a "microbenchmarks" directory instead of "regress" directory
217         https://bugs.webkit.org/show_bug.cgi?id=161096
218
219         Rubber stamped by Mark Lam.
220
221         This patch moves LayoutTests/js/regress/script-tests to the JSTests/microbenchmarks
222         directory and removes all the related html and txt files. I did this because
223         that directory was only there for microbenchmarks, and not for "regression"
224         tests. I also changed the various scripts to point to it.
225
226         * Scripts/run-javascriptcore-tests:
227         (runJSCStressTests):
228         * Scripts/run-jsc-benchmarks:
229
230 2016-08-23  Alex Christensen  <achristensen@webkit.org>
231
232         Fix EFL build.
233
234         * TestWebKitAPI/CMakeLists.txt:
235         Include new directory.
236
237 2016-08-22  Filip Pizlo  <fpizlo@apple.com>
238
239         Butterflies should be allocated in Auxiliary MarkedSpace instead of CopiedSpace and we should rewrite as much of the GC as needed to make this not a regression
240         https://bugs.webkit.org/show_bug.cgi?id=160125
241
242         Reviewed by Geoffrey Garen.
243
244         * DumpRenderTree/TestRunner.cpp: Rewire some #includes.
245         * Scripts/run-jsc-stress-tests: New test flag!
246
247 2016-08-23  Brady Eidson  <beidson@apple.com>
248
249         WK2 Gamepad layout test support.
250         https://bugs.webkit.org/show_bug.cgi?id=134671
251
252         Reviewed by Alex Christensen.
253         
254         Have the injected bundle expose the MockGamepadProvider to the UI process, which will then 
255         feed back into the UIGamepadProvider.
256         
257         Also, fool NSApplication into treating the most recently created "isKeyWindow" of the test windows
258         as the actual keyWindow for the test runner, which will allow the view to get gamepad updates.
259
260         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
261         
262         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
263         (WTR::TestRunner::setMockGamepadDetails):
264         (WTR::TestRunner::setMockGamepadAxisValue):
265         (WTR::TestRunner::setMockGamepadButtonValue):
266         
267         * WebKitTestRunner/PlatformWebView.h:
268         
269         * WebKitTestRunner/TestController.cpp:
270         (WTR::TestController::initialize):
271         
272         * WebKitTestRunner/TestInvocation.cpp:
273         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
274         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Deleted.
275         
276         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
277         
278         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
279         (-[WebKitTestRunnerWindow initWithFrame:]):
280         (-[WebKitTestRunnerWindow dealloc]):
281         (WTR::PlatformWebView::keyWindow):
282         
283         * WebKitTestRunner/ios/TestControllerIOS.mm:
284         (WTR::wtr_NSApplication_keyWindow):
285         (WTR::TestController::platformInitialize):
286         
287         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
288         (+[WebKitTestRunnerWindow _WTR_keyWindow]):
289         (-[WebKitTestRunnerWindow initWithContentRect:styleMask:backing:defer:]):
290         (-[WebKitTestRunnerWindow dealloc]):
291         (WTR::PlatformWebView::keyWindow):
292         
293         * WebKitTestRunner/mac/TestControllerMac.mm:
294         (WTR::wtr_NSApplication_keyWindow):
295         (WTR::TestController::platformInitialize):
296         * WebKitTestRunner/mac/main.mm:
297
298 2016-08-23  Alexey Proskuryakov  <ap@apple.com>
299
300         REGRESSION (PHP 5.6): http/tests/misc/bad-charset-alias.html fails
301         https://bugs.webkit.org/show_bug.cgi?id=161047
302         rdar://problem/27434307
303
304         Reviewed by Lucas Forschler.
305
306         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py: Specify a php.ini file.
307
308 2016-08-23  Chris Dumez  <cdumez@apple.com>
309
310         Unreviewed, rolling out r204243.
311
312         Caused some layout test failures
313
314         Reverted changeset:
315
316         "Write API test to cover crash fix in r204135"
317         https://bugs.webkit.org/show_bug.cgi?id=160587
318         http://trac.webkit.org/changeset/204243
319
320 2016-08-23  Rawinder Singh  <rawinder.singh-webkit@cisra.canon.com.au>
321
322         Order feature option list in FeatureList.pm
323         https://bugs.webkit.org/show_bug.cgi?id=161074
324
325         Reviewed by Michael Catanzaro.
326
327         Reorder features in alphabetical order based on command line option. Also, sort variables in alphabetical order.
328
329         * Scripts/webkitperl/FeatureList.pm:
330
331 2016-08-22  Dewei Zhu  <dewei_zhu@apple.com>
332
333         Stop python icon bouncing in the dock while running browser benchmarks.
334         https://bugs.webkit.org/show_bug.cgi?id=161066
335
336         Reviewed by Ryosuke Niwa.
337
338         Bouncing python icon may impact browser benchmark results.
339         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
340         (OSXBrowserDriver.prepare_env):
341         (OSXBrowserDriver.restore_env):
342
343 2016-08-22  Simon Fraser  <simon.fraser@apple.com>
344
345         <select> menu on iPad causes shifting of hit-testing areas
346         https://bugs.webkit.org/show_bug.cgi?id=150079
347
348         Reviewed by Tim Horton.
349
350         -isAssistingNode (aka the poorly named isEditable) is input into WebPageProxy::computeCustomFixedPositionRect(),
351         so when it changes we have to update visible rects. We were doing this on focus, but failing
352         to do it on blur.
353
354         Added the ability to test by:
355         1. Making it possible to initiate an animated scroll in the UI process
356         2. Adding callbacks for starting and ending interaction with a form control. Sadly
357         the "ending interaction" for <select> popovers on iPad isn't late enough, since we
358         have no way currently to know when the dimming view behind the popover animates out,
359         so for now the test keeps trying to tap a button.
360
361         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
362         * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
363         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
364         (WTR::UIScriptController::setDidStartFormControlInteractionCallback):
365         (WTR::UIScriptController::didStartFormControlInteractionCallback):
366         (WTR::UIScriptController::setDidEndFormControlInteractionCallback):
367         (WTR::UIScriptController::didEndFormControlInteractionCallback):
368         (WTR::UIScriptController::scrollToOffset):
369         (WTR::UIScriptController::platformSetDidStartFormControlInteractionCallback):
370         (WTR::UIScriptController::platformSetDidEndFormControlInteractionCallback):
371         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
372         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
373         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
374         (-[TestRunnerWKWebView dealloc]):
375         (-[TestRunnerWKWebView didStartFormControlInteraction]):
376         (-[TestRunnerWKWebView didEndFormControlInteraction]):
377         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
378         (WTR::contentOffsetBoundedInValidRange):
379         (WTR::UIScriptController::scrollToOffset):
380         (WTR::UIScriptController::platformSetDidStartFormControlInteractionCallback):
381         (WTR::UIScriptController::platformSetDidEndFormControlInteractionCallback):
382
383 2016-08-22  Carlos Alberto Lopez Perez  <clopez@igalia.com>
384
385         [EFL][GTK] Script process-linux-coredump is not needed, switch back to use the kernel core dumper instead.
386         https://bugs.webkit.org/show_bug.cgi?id=160927
387
388         Reviewed by Daniel Bates.
389
390         * Scripts/process-linux-coredump: Removed.
391         * Scripts/webkitpy/port/efl.py:
392         (EflPort._get_crash_log):
393         * Scripts/webkitpy/port/gtk.py:
394         (GtkPort._get_crash_log):
395         * Scripts/webkitpy/port/linux_get_crash_log.py:
396         (GDBCrashLogGenerator.__init__):
397         (GDBCrashLogGenerator.generate_crash_log):
398         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
399         (GDBCrashLogGeneratorTest.test_generate_crash_log):
400
401 2016-08-22  Jonathan Bedard  <jbedard@apple.com>
402
403         check-webkit-style does not work with Lambda functions in C++
404         https://bugs.webkit.org/show_bug.cgi?id=160910
405
406         Reviewed by Darin Adler.
407
408         This change eliminates false positives on correctly styled lambda functions and includes a few basic checks on capture list.
409
410         * Scripts/webkitpy/style/checkers/cpp.py:
411         (regex_for_lambda_functions): Added function which checks if a string is the start of a lambda function.
412         (check_for_non_standard_constructs): Added lambda function check.
413         (check_spacing_for_function_call): Added lambda function check.
414         (check_braces): Added lambda function check.
415         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
416         (CppStyleTest.test_lambda_functions): Added test function for lambda function style checks.
417
418 2016-08-21  Alex Christensen  <achristensen@webkit.org>
419
420         URLParser should parse IPv4 addresses
421         https://bugs.webkit.org/show_bug.cgi?id=161023
422
423         Reviewed by Darin Adler.
424
425         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
426         (TestWebKitAPI::TEST_F):
427         (TestWebKitAPI::checkURLDifferences):
428         We are already getting differences between the old URL::parse and the new URLParser.
429         (TestWebKitAPI::shouldFail):
430
431 2016-08-21  Daniel Bates  <dabates@apple.com>
432
433         prepare-ChangeLog lists unmodified functions as modified and marks functions with few changes as deleted
434         https://bugs.webkit.org/show_bug.cgi?id=148437
435
436         Reviewed by Dan Bernstein.
437
438         * Scripts/prepare-ChangeLog:
439         (diffCommand): When using a Subversion checkout, generate a unified diff without any context lines.
440         This matches our behavior when using a Git checkout. The function overlap logic in generateFunctionListsByRanges()
441         assumes that its line ranges were from a unified diff without any context lines.
442         (extractLineRangeAfterChange): A deleted line should be represented with a ("begin line number", "end line number") = ("new starting line number", "new starting line number").
443         (extractLineRangeBeforeChange): An added line should be represented with a ("begin line number", "end line number") = ("original starting line number", "original starting line number").
444         * Scripts/webkitperl/prepare-ChangeLog_unittest/extractLineRangeBeforeAndAfterChange.pl: Update expected results
445         based on changes to extractLineRangeAfterChange() and extractLineRangeBeforeChange().
446         * Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl: Added.
447         (discardOutput): Convenience function invokes the specified function redirecting standard output and standard error
448         to /dev/null for the duration of the function call.
449
450 2016-08-20  Gyuyoung Kim  <gyuyoung.kim@navercorp.com>
451
452         [EFL] Remove unnecessary a patch to mute ecore warnings
453         https://bugs.webkit.org/show_bug.cgi?id=160997
454
455         Reviewed by Darin Adler.
456
457         There is no warning messages during the layout test and perf test
458         after bumping efl version from 1.17 to 1.18. Remove it.
459
460         * efl/patches/ecore_remove_warnings.patch: Removed.
461
462 2016-08-20  Simon Fraser  <simon.fraser@apple.com>
463
464         REGRESSION (r204477): Running LayoutTests on ios-simulator became ~15 minutes slower
465         https://bugs.webkit.org/show_bug.cgi?id=160985
466
467         Re-land r204672, but don't check the result of 'xcrun simctl shutdown', because
468         device shutdown seems to happen as result of killing Simulator.apps, and we're racing
469         with that.
470
471         * Scripts/webkitpy/layout_tests/views/printing.py:
472         (Printer.print_config):
473         * Scripts/webkitpy/port/base.py:
474         (Port.driver_cmd_line_for_logging):
475         (Port.driver_cmd_line): Deleted.
476         * Scripts/webkitpy/port/driver.py:
477         (IOSSimulatorDriver.cmd_line):
478         * Scripts/webkitpy/port/ios.py:
479         (IOSSimulatorPort.__init__):
480         (IOSSimulatorPort.driver_cmd_line_for_logging):
481         (IOSSimulatorPort._create_simulators):
482         (IOSSimulatorPort.setup_test_run):
483         (IOSSimulatorPort._quit_ios_simulator):
484         (IOSSimulatorPort.clean_up_test_run):
485         (IOSSimulatorPort._create_device):
486         (IOSSimulatorPort):
487         (IOSSimulatorPort._remove_device):
488         (IOSSimulatorPort._testing_device):
489         (IOSSimulatorPort.device_id_for_worker_number):
490         (IOSSimulatorPort._set_device_class): Deleted.
491         (IOSSimulatorPort.testing_device): Deleted.
492         * Scripts/webkitpy/port/port_testcase.py:
493         (PortTestCase.test_driver_cmd_line):
494         * Scripts/webkitpy/xcode/simulator.py:
495         (Device.shutdown):
496         (Device):
497         (Device.delete):
498         (Device.reset):
499         (Simulator):
500         (Simulator.create_device):
501         (Simulator.remove_device):
502         (Simulator.device_number):
503         (Simulator.device_state_description):
504         (Simulator.wait_until_device_is_in_state):
505
506 2016-08-19  Ryan Haddad  <ryanhaddad@apple.com>
507
508         Unreviewed, rolling out r204659.
509
510         This change appears to have caused ios-simulator LayoutTests
511         to fail when shutting down the simulator
512
513         Reverted changeset:
514
515         "REGRESSION (r204477): Running LayoutTests on ios-simulator
516         became ~15 minutes slower"
517         https://bugs.webkit.org/show_bug.cgi?id=160985
518         http://trac.webkit.org/changeset/204659
519
520 2016-08-19  Alexey Proskuryakov  <ap@apple.com>
521
522         Build fix for non-USE_SIM_SERVICE_CONTEXT builds
523         * LayoutTestRelay/LayoutTestRelay/main.m: (main):
524
525 2016-08-18  Simon Fraser  <simon.fraser@apple.com>
526
527         REGRESSION (r204477): Running LayoutTests on ios-simulator became ~15 minutes slower
528         https://bugs.webkit.org/show_bug.cgi?id=160985
529
530         Reviewed by Alexey Proskuryakov.
531         
532         r204477 removed @memoized on a couple of ios.py functions, causing them to instantiate
533         a Simulator() on every call, which causes 'xcrun simctl list' to run. The functions
534         must not be @memoized, because their return value depends on the value of simulator_device_type().
535         
536         Fix by adding some global state in simulator.py that tracks the created devices 
537         in a worker number -> Device dictionary. Explicitly create devices in _create_simulators(),
538         and delete them in clean_up_test_run().
539         
540         Also explicitly called 'xcrun simctl shutdown' to shut down devices, since it seems
541         that killing the Simulator apps isn't enough.
542         
543         Simulator tracks the devices in a global dictionary, since state needs to persist
544         across different instances of IOSSimulatorPort.
545         
546         Annoyingly, the "Command line:" dumping tried to access a device before we'd done
547         any setup. Rather than implicitly creating a device here (which the old code did),
548         override the more clearly named driver_cmd_line_for_logging() in IOSSimulatorPort
549         and set flag to say that device_id_for_worker_number() doesn't need to return a real
550         device id.
551
552         * Scripts/webkitpy/layout_tests/views/printing.py:
553         (print_options):
554         (Printer.print_config):
555         * Scripts/webkitpy/port/base.py:
556         (Port.driver_cmd_line_for_logging):
557         (Port.driver_cmd_line): Deleted.
558         * Scripts/webkitpy/port/driver.py:
559         (IOSSimulatorDriver.cmd_line):
560         * Scripts/webkitpy/port/ios.py:
561         (IOSSimulatorPort.__init__):
562         (IOSSimulatorPort.driver_cmd_line_for_logging):
563         (IOSSimulatorPort._create_simulators):
564         (IOSSimulatorPort.setup_test_run):
565         (IOSSimulatorPort.clean_up_test_run):
566         (IOSSimulatorPort._create_device):
567         (IOSSimulatorPort):
568         (IOSSimulatorPort._remove_device):
569         (IOSSimulatorPort._testing_device):
570         (IOSSimulatorPort.device_id_for_worker_number):
571         (IOSSimulatorPort._set_device_class): Deleted.
572         (IOSSimulatorPort.testing_device): Deleted.
573         * Scripts/webkitpy/port/port_testcase.py:
574         (PortTestCase.test_driver_cmd_line):
575         * Scripts/webkitpy/xcode/simulator.py:
576         (Device.shutdown):
577         (Device.delete):
578         (Device.reset):
579         (Simulator.create_device):
580         (Simulator.remove_device):
581         (Simulator.device_number):
582         (Simulator.device_state_description):
583         (Simulator.wait_until_device_is_in_state):
584
585 2016-08-19  Alexey Proskuryakov  <ap@apple.com>
586
587         Adopt SimServiceContext in LayoutTestRelay
588         https://bugs.webkit.org/show_bug.cgi?id=161000
589         <rdar://problem/25765594>
590
591         Reviewed by Daniel Bates.
592
593         * LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h:
594         * LayoutTestRelay/LayoutTestRelay/main.m:
595
596 2016-08-19  Lucas Forschler  <lforschler@apple.com>
597
598         Remove Yosemite Leaks bot after http://trac.webkit.org/projects/webkit/changeset/204629
599
600         Reviewed by Kocsen Chung.
601
602         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
603         (WebKitBuildbot):
604
605 2016-08-19  Alexey Proskuryakov  <ap@apple.com>
606
607         Partial revert of r203811 - this key is not needed.
608
609         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m: (-[LTRelayController installApp]):
610
611 2016-08-19  Daniel Bates  <dabates@apple.com>
612
613         Another attempt to fix the iOS 9.3 build
614
615         Define WK_EMPTY_, WK_NOT_, and WK_NOT_YES.
616
617         * DumpRenderTree/mac/Configurations/Base.xcconfig:
618         * WebKitTestRunner/Configurations/Base.xcconfig:
619
620 2016-08-19  Lucas Forschler  <lforschler@apple.com>
621
622         Remove Yosemite Leaks bot from config.json
623         
624         Reviewed by Alexey Proskuryakov.
625
626         * BuildSlaveSupport/build.webkit.org-config/config.json:
627
628 2016-08-18  Dan Bernstein  <mitz@apple.com>
629
630         [Cocoa] API::Number needs to be wrapped by an NSNumber
631         https://bugs.webkit.org/show_bug.cgi?id=160977
632         <rdar://problem/27877735>
633
634         Reviewed by Anders Carlsson.
635
636         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
637         * TestWebKitAPI/Tests/WebKit2Cocoa/WKNSNumber.mm: Added.
638         (TestWebKitAPI::TEST):
639
640 2016-08-17  Myles C. Maxfield  <mmaxfield@apple.com>
641
642         [Cocoa] Migrate off of deprecated CoreGraphics API CGContextSelectFont() and CGContextShowTextAtPoint()
643         https://bugs.webkit.org/show_bug.cgi?id=160895
644
645         Reviewed by Dean Jackson.
646
647         Link to the existing CoreText framework.
648
649         * DumpRenderTree/PlatformWin.cmake:
650         * TestWebKitAPI/PlatformWin.cmake:
651
652 2016-08-17  Brent Fulgham  <bfulgham@apple.com>
653
654         [Win] Remove old libraries from build inputs
655         https://bugs.webkit.org/show_bug.cgi?id=160949
656
657         Reviewed by Dean Jackson.
658
659         Modify the download script to remove the old 'icuuc.lib' and
660         'icuin.lib' files for Windows builds.
661
662         * Scripts/update-webkit-auxiliary-libs:
663
664 2016-08-17  Jonathan Bedard  <jbedard@apple.com>
665
666         Extra logging for crash reason
667         https://bugs.webkit.org/show_bug.cgi?id=160943
668
669         Reviewed by Alexey Proskuryakov.
670
671         A number of tests have been erroneously marked as crashed, this should help diagnose these false crashes.
672
673         * Scripts/webkitpy/port/server_process.py:
674         (ServerProcess.write): Add extra logging to determine why a process has been marked as crashed.
675         (ServerProcess._wait_for_data_and_update_buffers_using_select): Ditto.
676         (ServerProcess.has_crashed): Ditto.
677
678 2016-08-17  Dan Bernstein  <mitz@apple.com>
679
680         [Cocoa] -[NSString isEqualToString:] returns NO for any WKNSString argument
681         https://bugs.webkit.org/show_bug.cgi?id=160938
682         <rdar://problem/27876652>
683
684         Reviewed by Anders Carlsson.
685
686         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
687         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm: Added.
688         (TestWebKitAPI::TEST):
689
690 2016-08-17  Chris Fleizach  <cfleizach@apple.com>
691
692         AX: Support abbreviations in iOS
693         https://bugs.webkit.org/show_bug.cgi?id=160907
694
695         Reviewed by Joanmarie Diggs.
696
697         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
698         (AccessibilityUIElement::stringAttributeValue):
699         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
700         (WTR::AccessibilityUIElement::stringAttributeValue):
701
702 2016-08-17  Gyuyoung Kim  <gyuyoung.kim@navercorp.com>
703
704         [EFL] Bump efl version from 1.17 to 1.18
705         https://bugs.webkit.org/show_bug.cgi?id=160899
706
707         Reviewed by Antonio Gomes.
708
709         To use efl-1.18, EFL port needs to update install dependencies as well.
710
711         * efl/install-dependencies:
712         * efl/jhbuild.modules:
713
714 2016-08-17  Per Arne Vollan  <pvollan@apple.com>
715
716         [Win] Add tests for linked fonts.
717         https://bugs.webkit.org/show_bug.cgi?id=160898
718
719         Reviewed by Brent Fulgham.
720
721         Add tests for https://trac.webkit.org/changeset/204502.
722
723         * TestWebKitAPI/PlatformWin.cmake:
724         * TestWebKitAPI/Tests/WebCore/win/LinkedFonts.cpp: Added.
725         (TestWebKitAPI::TEST):
726
727 2016-08-16  Daniel Bates  <dabates@apple.com>
728
729         prepare-ChangeLog: Extract logic from generateFunctionLists() into a function that takes a delegate object
730         https://bugs.webkit.org/show_bug.cgi?id=160924
731
732         Reviewed by Stephanie Lewis.
733
734         Towards adding unit tests for generateFunctionLists() we move its logic into actuallyGenerateFunctionLists()
735         and have actuallyGenerateFunctionLists() take a delegate object to use to query the file system and SCM.
736         We modify generateFunctionLists() to call actuallyGenerateFunctionLists(). This will make is possible to
737         test the generate function list machinery without requiring a SCM checkout by substituting a delegate
738         object that mocks out the file system and SCM operations.
739
740         * Scripts/VCSUtils.pm:
741         (parseDiffStartLine): Parses an SVN or Git start line and returns the path to the target file.
742         * Scripts/prepare-ChangeLog:
743         (generateFunctionLists): Move functionality to actually generate the function lists to actuallyGenerateFunctionLists(),
744         abstracting the logic to query the file system and SCM into functions on a delegate object that
745         we pass to it.
746         (actuallyGenerateFunctionLists): Extracted from generateFunctionLists().
747         (diffHeaderFormat): Deleted.
748
749 2016-08-16  Alex Christensen  <achristensen@webkit.org>
750
751         URLParser should parse URLs without credentials
752         https://bugs.webkit.org/show_bug.cgi?id=160913
753
754         Reviewed by Brady Eidson.
755
756         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
757         (TestWebKitAPI::s):
758         (TestWebKitAPI::checkURL):
759         (TestWebKitAPI::TEST_F):
760
761 2016-08-16  Anders Carlsson  <andersca@apple.com>
762
763         Add WTF::ScopeExit
764         https://bugs.webkit.org/show_bug.cgi?id=160908
765
766         Reviewed by Geoffrey Garen.
767
768         * TestWebKitAPI/CMakeLists.txt:
769         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
770         * TestWebKitAPI/Tests/WTF/Scope.cpp: Added.
771         (TestWebKitAPI::TEST):
772
773 2016-08-16  Aakash Jain  <aakash_jain@apple.com>
774
775         EWS logs file are rotated too quickly
776         https://bugs.webkit.org/show_bug.cgi?id=160724
777
778         Reviewed by Daniel Bates.
779
780         Currently we are rotating the log file after 10 iterations of queue. If the queue
781         doesn't have any pending patches, these iterations result in very small amount of 
782         logs (1 KB log file). Even if the queue process some patches, logs are few KBs.
783         This results in a lot of log files in a day. This patch ensures that we rotate the
784         log file when its file size is greater than or equal to 100 KB.
785
786         * EWSTools/start-queue-mac.sh: Added check for file size before rotating log file.
787
788 2016-08-16  Daniel Bates  <dabates@apple.com>
789
790         WKSI static library should be named by major iOS revision, not individual updates
791         https://bugs.webkit.org/show_bug.cgi?id=160727
792         <rdar://problem/22274848>
793
794         Reviewed by Alexey Proskuryakov.
795
796         * DumpRenderTree/mac/Configurations/Base.xcconfig:
797         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
798         * Scripts/copy-webkitlibraries-to-product-directory:
799         * WebKitTestRunner/Configurations/Base.xcconfig:
800         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
801
802 2016-08-16  Simon Fraser  <simon.fraser@apple.com>
803
804         Make it possible to test iOS select elements, and add iPhone and iPad tests for them
805         https://bugs.webkit.org/show_bug.cgi?id=160909
806
807         Reviewed by Enrica Casucci.
808         
809         Add functions to UIScriptController to dismiss the form accessory view for iOS,
810         and to programmatically pick a row from a <select> picker.
811
812         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
813         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
814         (WTR::UIScriptController::dismissFormAccessoryView):
815         (WTR::UIScriptController::selectFormAccessoryPickerRow):
816         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
817         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
818         (WTR::UIScriptController::dismissFormAccessoryView):
819         (WTR::UIScriptController::selectFormAccessoryPickerRow):
820
821 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
822
823         [iOS] Add iPad viewport and form tests, and revert the iPad-testing part of r202132
824         https://bugs.webkit.org/show_bug.cgi?id=160878
825
826         Reviewed by Tim Horton.
827         
828         Remove testing-specific "forceIPadStyleZoomOnInputFocus" behavior added in r202132
829         now that we have the ability to run tests in the iPad simulator.
830
831         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
832         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
833         (WTR::UIScriptController::forceIPadStyleZoomOnInputFocus): Deleted.
834         (WTR::UIScriptController::setForceIPadStyleZoomOnInputFocus): Deleted.
835         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
836         * WebKitTestRunner/ios/TestControllerIOS.mm:
837         (WTR::TestController::platformResetStateToConsistentValues): Deleted.
838         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
839         (WTR::UIScriptController::forceIPadStyleZoomOnInputFocus): Deleted.
840         (WTR::UIScriptController::setForceIPadStyleZoomOnInputFocus): Deleted.
841
842 2016-08-15  Anders Carlsson  <andersca@apple.com>
843
844         Add an address-of operator to RetainPtr
845         https://bugs.webkit.org/show_bug.cgi?id=160879
846
847         Reviewed by Tim Horton.
848
849         Test HashMap and HashSet with an object whose operator& is deleted.
850
851         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
852         Sort the Xcode project.
853
854         * TestWebKitAPI/Tests/WTF/DeletedAddressOfOperator.h: Added.
855         (DeletedAddressOfOperator::DeletedAddressOfOperator):
856         (DeletedAddressOfOperator::value):
857         (DeletedAddressOfOperator::operator==):
858         (WTF::HashTraits<DeletedAddressOfOperator>::constructDeletedValue):
859         (WTF::HashTraits<DeletedAddressOfOperator>::isDeletedValue):
860         (WTF::DefaultHash<DeletedAddressOfOperator>::Hash::hash):
861         (WTF::DefaultHash<DeletedAddressOfOperator>::Hash::equal):
862         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
863         (TestWebKitAPI::TEST):
864         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
865         (TestWebKitAPI::TEST):
866
867 2016-08-16  Jonathan Bedard  <jbedard@apple.com>
868
869         False crashes in fast/text/emoji-gender-* tests
870         https://bugs.webkit.org/show_bug.cgi?id=160779
871
872         Reviewed by Alexey Proskuryakov.
873
874         Fix from <rdar://problem/27786762>, where timed out tests falsely report as crashed.
875
876         * Scripts/webkitpy/port/driver.py:
877         (Driver._check_for_driver_crash_or_unresponsiveness): Change call to ‘write’ to disable crash flag.
878         * Scripts/webkitpy/port/driver_unittest.py: Added 3 variable to test version of ‘write.’
879         * Scripts/webkitpy/port/server_process.py:
880         (ServerProcess.write): Allow caller to disable crash flag on exception.
881
882 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
883
884         webkitpy error in TestRunResults.merge()
885         https://bugs.webkit.org/show_bug.cgi?id=160882
886
887         Reviewed by Daniel Bates.
888         
889         The argument to TestRunResults.merge() can be None if there are no device-specifc
890         initial results or retry results in Manager.run(), so just return early in that case.
891
892         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
893         (TestRunResults.merge):
894
895 2016-08-15  Sam Weinig  <sam@webkit.org>
896
897         Speed up compile times by not including wtf/Variant.h so much
898         https://bugs.webkit.org/show_bug.cgi?id=160847
899
900         Reviewed by Alex Christensen and Saam Barati.
901
902         * TestWebKitAPI/Tests/WTF/Variant.cpp:
903         (TestWebKitAPI::TEST):
904         Explicitly use std::experimental::variant.
905
906 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
907
908         Allow a port to run tests with a custom device setup
909         https://bugs.webkit.org/show_bug.cgi?id=160833
910
911         Reviewed by Daniel Bates.
912
913         These changes allow the IOSSimulator port to run tests in iPad mode.
914
915         This is made possible by allowing a platform to define CUSTOM_DEVICE_CLASSES,
916         in this case 'ipad'. When specified, any test in a directory with a suffix that matches
917         a custom device will be collected into a set, and run in that device's environment after
918         the other tests have run.
919
920         * Scripts/webkitpy/layout_tests/controllers/manager.py:
921         (Manager._custom_device_for_test): If the test contains a directory matching a
922         custom device suffix, return that custom device.
923         (Manager._set_up_run): Push the custom device class, if any, into options so
924         that the Worker can get to it.
925         (Manager.run): Go through the list of tests, and break it down into device-generic
926         tests, and tests for each device class. _run_test_subset is then called for
927         each collection of tests, and the results merged.
928         (Manager._run_test_subset): Some lines unwrapped.
929         (Manager._end_test_run):
930         (Manager._run_tests):
931         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
932         (SingleTestRunner.__init__): Unwrapped a line.
933         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
934         (TestRunResults.merge): Add this function to merge TestRunResults
935         * Scripts/webkitpy/layout_tests/views/printing.py:
936         (Printer.print_workers_and_shards): Print the custom device, if any.
937         * Scripts/webkitpy/port/base.py:
938         (Port): Base port has empty array of custom devices.
939         (Port.setup_test_run): Add device_class argument.
940         * Scripts/webkitpy/port/driver.py:
941         (DriverInput.__repr__):
942         (Driver.check_driver.implementation):
943         * Scripts/webkitpy/port/efl.py:
944         (EflPort.setup_test_run):
945         * Scripts/webkitpy/port/gtk.py:
946         (GtkPort.setup_test_run):
947         * Scripts/webkitpy/port/ios.py:
948         (IOSSimulatorPort): Add CUSTOM_DEVICE_CLASSES for ipad.
949         (IOSSimulatorPort.__init__):
950         (IOSSimulatorPort.simulator_device_type): Use a device name from the DEVICE_CLASS_MAP
951         based on the custom device class.
952         (IOSSimulatorPort._set_device_class):
953         (IOSSimulatorPort._create_simulators): Factor some code into this function.
954         (IOSSimulatorPort.setup_test_run):
955         (IOSSimulatorPort.testing_device):
956         (IOSSimulatorPort.reset_preferences): This used to create the simulator apps, but that
957         seemed wrong for this function. That was moved to setup_test_run().
958         (IOSSimulatorPort.check_sys_deps): This function used to create testing devices,
959         but this happened too early, before we knew which kind of devices to create. Devices
960         are now created in setup_test_run().
961         * Scripts/webkitpy/port/win.py:
962         (WinPort.setup_test_run):
963
964 2016-08-15  Daniel Bates  <dabates@apple.com>
965
966         Cannot build WebKit for iOS device using Xcode 7.3/iOS 9.3 public SDK due to missing
967         private frameworks and libraries
968         https://bugs.webkit.org/show_bug.cgi?id=155931
969         <rdar://problem/25807989>
970
971         Reviewed by Dan Bernstein.
972
973         Add directory WebKitLibraries/WebKitPrivateFrameworkStubs/iOS/X to the framework search path
974         where X is the major version of the active iOS SDK.
975
976         * DumpRenderTree/mac/Configurations/Base.xcconfig:
977         * WebKitTestRunner/Configurations/Base.xcconfig:
978
979 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
980
981         Add a setting and preferences to enable visual viewport mode
982         https://bugs.webkit.org/show_bug.cgi?id=160843
983
984         Reviewed by Sam Weinig.
985         
986         Pref and a menu item to toggle visualViewportEnabled for WebKits 1 and 2.
987
988         * MiniBrowser/mac/SettingsController.h:
989         * MiniBrowser/mac/SettingsController.m:
990         (-[SettingsController _populateMenu]):
991         (-[SettingsController validateMenuItem:]):
992         (-[SettingsController visualViewportEnabled]):
993         (-[SettingsController toggleVisualViewportEnabled:]):
994         * MiniBrowser/mac/WK1BrowserWindowController.m:
995         (-[WK1BrowserWindowController didChangeSettings]):
996         * MiniBrowser/mac/WK2BrowserWindowController.m:
997         (-[WK2BrowserWindowController didChangeSettings]):
998
999 2016-08-15  Konstantin Tokarev  <annulen@yandex.ru>
1000
1001         Allow using make-dist with non-GTK ports
1002         https://bugs.webkit.org/show_bug.cgi?id=160842
1003
1004         Reviewed by Michael Catanzaro.
1005
1006         This patch adds support for setting base name of tarball and argument
1007         passed to cmake's -DPORT= via command line arguments.
1008
1009         * gtk/make-dist.py:
1010         (Distcheck.configure):
1011         (Distcheck.check):
1012         (get_tarball_root_and_output_filename_from_arguments):
1013
1014 2016-08-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1015
1016         [GTK] Install script lacks gstreamer related dependencies
1017         https://bugs.webkit.org/show_bug.cgi?id=160814
1018
1019         Reviewed by Carlos Garcia Campos.
1020
1021         * gtk/install-dependencies: Fedora case had already listed this dependencies,
1022         but both Arch and Debian/Ubuntu were missing them.
1023
1024 2016-08-13  Konstantin Tokarev  <annulen@yandex.ru>
1025
1026         make-dist.py should not allow unknown rules in manifest
1027         https://bugs.webkit.org/show_bug.cgi?id=160841
1028
1029         Reviewed by Carlos Garcia Campos.
1030
1031         * gtk/make-dist.py:
1032         (Manifest.process_line):
1033
1034 2016-08-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1035
1036         [EFL][GTK] Install script not working on Debian 9 (testing) and Ubuntu 16.10
1037         https://bugs.webkit.org/show_bug.cgi?id=160809
1038
1039         Reviewed by Carlos Garcia Campos.
1040
1041         * efl/install-dependencies: Factorize the previous logic for handling the php5/7
1042         case, and use it also for the new package names of libpng and libgeoclue.
1043         * gtk/install-dependencies: Ditto.
1044
1045 2016-08-12  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1046
1047         Skip to check directories existence in build-webkit
1048         https://bugs.webkit.org/show_bug.cgi?id=160691
1049
1050         Reviewed by Alex Christensen.
1051
1052         CMake checks if directories are there itself. So CMake ports
1053         don't need to check it in the build-webkit script.
1054
1055         * Scripts/build-webkit:
1056         * Scripts/webkitdirs.pm:
1057         (determineSourceDir):
1058         (isCMakeBuild):
1059
1060 2016-08-12  Alex Christensen  <achristensen@webkit.org>
1061
1062         Make URLParser work with URLs missing URL parts
1063         https://bugs.webkit.org/show_bug.cgi?id=160824
1064
1065         Reviewed by Brady Eidson.
1066
1067         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1068         (TestWebKitAPI::s):
1069         (TestWebKitAPI::checkURL):
1070         (TestWebKitAPI::TEST_F):
1071         (TestWebKitAPI::eq): Deleted.
1072
1073 2016-08-12  John Wilander  <wilander@apple.com>
1074
1075         Add HashCountedSet API tests to TestWTFLibrary target
1076         https://bugs.webkit.org/show_bug.cgi?id=160815
1077
1078         Reviewed by Alex Christensen.
1079
1080         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1081             Added HashCountedSet.cpp and sorted the file reference section
1082             according to UNIX sort.
1083
1084 2016-08-12  Ryosuke Niwa  <rniwa@webkit.org>
1085
1086         run-benchmark should run JetStream 1.1 instead of 1.0.1
1087         https://bugs.webkit.org/show_bug.cgi?id=160816
1088
1089         Reviewed by Filip Pizlo.
1090
1091         Use the latest JetStream 1.1 in run-benchmark.
1092
1093         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
1094         (BenchmarkBuilder.__exit__):
1095         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Updated to apply against 1.1 directory.
1096         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Updated to use r190897, which is the last
1097         change to JetStream directory.
1098
1099 2016-08-12  Alex Christensen  <achristensen@webkit.org>
1100
1101         Initial URLParser implementation
1102         https://bugs.webkit.org/show_bug.cgi?id=160811
1103
1104         Reviewed by Brady Eidson.
1105
1106         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1107         (TestWebKitAPI::eq):
1108         (TestWebKitAPI::checkURL):
1109         (TestWebKitAPI::TEST_F):
1110
1111 2016-08-12  Brady Eidson  <beidson@apple.com>
1112
1113         Fix the 32-bit Mac build after:
1114         Add WK2 ExperimentalFeature support to MiniBrowser
1115         https://bugs.webkit.org/show_bug.cgi?id=160788
1116
1117         Unreviewed.
1118
1119         Sprinkle "#if WK_API_ENABLED"s liberally.
1120         
1121         * MiniBrowser/mac/AppDelegate.m:
1122         (defaultConfiguration):
1123         * MiniBrowser/mac/SettingsController.m:
1124         (-[SettingsController _populateMenu]):
1125         (-[SettingsController validateMenuItem:]):
1126
1127 2016-08-12  Philippe Normand  <pnormand@igalia.com>
1128
1129         [GStreamer][OWR] Video rendering fixes
1130         https://bugs.webkit.org/show_bug.cgi?id=160764
1131
1132         Reviewed by Xabier Rodriguez-Calvar.
1133
1134         * gtk/jhbuild.modules: Bump to current OpenWebRTC master.
1135
1136 2016-08-12  Per Arne Vollan  <pvollan@apple.com>
1137
1138         Add missing return statement in convertFast function added in r204376.
1139
1140         Unreviewed.
1141
1142         * Scripts/webkitpy/common/system/path.py:
1143         (_CygPath.convertFast):
1144
1145 2016-08-11  Brady Eidson  <beidson@apple.com>
1146
1147         Add WK2 ExperimentalFeature support to MiniBrowser.
1148         https://bugs.webkit.org/show_bug.cgi?id=160788
1149
1150         Reviewed by Alex Christensen.
1151
1152         * MiniBrowser/mac/AppDelegate.h:
1153         * MiniBrowser/mac/AppDelegate.m:
1154         (defaultConfiguration):
1155         (defaultPreferences):
1156         
1157         * MiniBrowser/mac/SettingsController.m:
1158         (-[SettingsController _populateMenu]):
1159         (-[SettingsController validateMenuItem:]):
1160         (-[SettingsController toggleExperimentalFeature:]):
1161
1162 2016-08-11  Aakash Jain  <aakash_jain@apple.com>
1163
1164         Keep EWS logs for longer
1165         https://bugs.webkit.org/show_bug.cgi?id=160776
1166
1167         Reviewed by Daniel Bates.
1168
1169         * EWSTools/start-queue-mac.sh: Keep logs for 30 days instead of 14 days.
1170
1171 2016-08-11  Simon Fraser  <simon.fraser@apple.com>
1172
1173         iOS DRT/WTR project cleanup
1174         https://bugs.webkit.org/show_bug.cgi?id=160778
1175
1176         Reviewed by Tim Horton.
1177
1178         Move TARGETED_DEVICE_FAMILY from the project to an xcconfig file.
1179
1180         Remove AppDelegate.* which were unused.
1181
1182         Exclude ios/Launch.storyboard on more platforms.
1183
1184         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1185         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
1186         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
1187         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1188         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Removed.
1189         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Removed.
1190         (-[AppDelegate application:didFinishLaunchingWithOptions:]): Deleted.
1191
1192 2016-08-11  Alex Christensen  <achristensen@webkit.org>
1193
1194         Fix Yosemite bots' cookie accept policies after r204365.
1195         https://bugs.webkit.org/show_bug.cgi?id=160758
1196
1197         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
1198         (TEST):
1199         This makes the test fully clean up after itself.
1200
1201 2016-08-11  Alex Christensen  <achristensen@webkit.org>
1202
1203         Fix Yosemite bots' cookie accept policies after r204365.
1204         https://bugs.webkit.org/show_bug.cgi?id=160758
1205
1206         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
1207         (TEST):
1208         I didn't restore the cookieAcceptPolicy of the sharedHTTPCookieStorage after changing it with this API test.
1209         On Yosemite, this is changing the cookieAcceptPolicy that DumpRenderTree uses.
1210         On more recent Cocoa platforms, it is only changing the cookieAcceptPolicy that TestWebKitAPI uses, which isn't
1211         causing any problems because there are no other API tests that do anything with cookies.
1212         My solution will be to restore the original cookieAcceptPolicy after running this API test to clean up,
1213         but first I am committing this patch setting the cookieAcceptPolicy to NSHTTPCookieAcceptPolicyOnlyFromMainDocumentDomain
1214         to reset any bots that have run tests since r204365.  I will commit a followup that sets it to originalCookieAcceptPolicy.
1215
1216 2016-08-11  Aakash Jain  <aakash_jain@apple.com>
1217
1218         EWS should check if the patch is still valid before executing every major step
1219         https://bugs.webkit.org/show_bug.cgi?id=160739
1220         rdar://problem/27768813
1221
1222         Reviewed by Alexey Proskuryakov.
1223
1224         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1225         (CommitQueueTask.run): validate method is now executed in base class.
1226         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
1227         (EarlyWarningSystemTask.run): validate method is now executed in base class.
1228         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
1229         (StyleQueueTask.validate): Raise an PatchIsNotValid exception instead of returning False.
1230         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1231         (PatchAnalysisTask._run_command): validate the patch before executing any command. This is to ensure
1232         that we do not waste time on any patch which has become invalid (e.g.: obsolete, r-).
1233         * Scripts/webkitpy/tool/commands/perfalizer.py:
1234         (PerfalizerTask.validate): Added.
1235         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1236         (test_manual_reject_during_processing): Updated test case.
1237
1238 2016-08-11  Alex Christensen  <achristensen@webkit.org>
1239
1240         Add URLParser stub
1241         https://bugs.webkit.org/show_bug.cgi?id=160770
1242
1243         Reviewed by Sam Weinig.
1244
1245         * TestWebKitAPI/PlatformGTK.cmake:
1246         * TestWebKitAPI/PlatformWin.cmake:
1247         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1248         * TestWebKitAPI/Tests/WebCore/URLParser.cpp: Added.
1249         (TestWebKitAPI::TEST_F):
1250
1251 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
1252
1253         [iOS DRT] Allow DRT to be iPad-sized in the iPad simulator
1254         https://bugs.webkit.org/show_bug.cgi?id=160761
1255
1256         Reviewed by Tim Horton.
1257
1258         Give iOS DRT a Launch storyboard.
1259
1260         Have it use a UIViewController so future forms testing works correctly.
1261
1262         Add TARGETED_DEVICE_FAMILY = "1,2" to the build settings for the .app, so that it
1263         can run in iPad mode.
1264
1265         Remove empty InfoPlist.strings files.
1266
1267         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1268         * DumpRenderTree/ios/Info.plist:
1269         * DumpRenderTree/ios/Launch.storyboard: Added.
1270         * DumpRenderTree/mac/DumpRenderTree.mm:
1271         (createWebViewAndOffscreenWindow):
1272         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1273         * WebKitTestRunner/WebKitTestRunnerApp/en.lproj/InfoPlist.strings: Removed.
1274         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1275         (WTR::PlatformWebView::PlatformWebView): Drive-by leak fix.
1276
1277 2016-08-11  Per Arne Vollan  <pvollan@apple.com>
1278
1279         [Win] Unable to reliably run tests in parallel
1280         https://bugs.webkit.org/show_bug.cgi?id=140914
1281
1282         Reviewed by Brent Fulgham.
1283
1284         The cygpath utility function can fail badly when running with multiple DumpRenderTree
1285         processes. We can use string replacement to convert the Cygwin path to a Windows path
1286         instead.
1287
1288         * Scripts/webkitpy/common/system/path.py:
1289         (cygpathFast):
1290         * Scripts/webkitpy/port/driver.py:
1291         (Driver._command_from_driver_input):
1292
1293 2016-08-10  Alex Christensen  <achristensen@webkit.org>
1294
1295         Fix crash when changing cookie accept policy after r204327
1296         https://bugs.webkit.org/show_bug.cgi?id=160758
1297
1298         Reviewed by Simon Fraser.
1299
1300         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1301         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm: Added.
1302         (-[CookieAcceptPolicyMessageHandler userContentController:didReceiveScriptMessage:]):
1303         (TEST):
1304         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieMessage.html: Added.
1305
1306 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
1307
1308         [iOS WK2] Have WebKitTestRunnerApp.app use a UIViewController, and fix to avoid the status bar
1309         https://bugs.webkit.org/show_bug.cgi?id=160757
1310
1311         Reviewed by Tim Horton.
1312
1313         When programmatically creating the test UIWindow, make a root UIViewController and parent
1314         the WKWebView in its view. This makes the app more like a normal UIKit application.
1315         
1316         Move the WKWebView down 20px to avoid the status bar.
1317         
1318         Give the UIWindow a gray background so it's obvious where the window and view positioned.
1319
1320         Sorted the project file. Removed the link to UIKit which showed red, and wasn't necessary.
1321         
1322         Remove duplicate references to Launch.storyboard.
1323
1324         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1325         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Add license.
1326         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Add license.
1327         (-[AppDelegate applicationWillResignActive:]): Deleted.
1328         (-[AppDelegate applicationDidEnterBackground:]): Deleted.
1329         (-[AppDelegate applicationWillEnterForeground:]): Deleted.
1330         (-[AppDelegate applicationDidBecomeActive:]): Deleted.
1331         (-[AppDelegate applicationWillTerminate:]): Deleted.
1332         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1333         (WTR::viewRectForWindowRect):
1334         (WTR::PlatformWebView::PlatformWebView):
1335         (WTR::PlatformWebView::setWindowFrame):
1336
1337 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
1338
1339         [iOS WK2] Use the simulated device's screen size, rather than a harcoded size
1340         https://bugs.webkit.org/show_bug.cgi?id=160748
1341
1342         Reviewed by Tim Horton.
1343         
1344         Use the main UIScreen's bounds for the window size if we're using a flexible viewport. This
1345         opens the door for tests using other device sizes.
1346
1347         * WebKitTestRunner/ios/TestControllerIOS.mm:
1348         (WTR::TestController::platformConfigureViewForTest):
1349
1350 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
1351
1352         Sort the feature flags in the FEATURE_DEFINES lines
1353         https://bugs.webkit.org/show_bug.cgi?id=160742
1354
1355         Reviewed by Anders Carlsson.
1356         
1357         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1358
1359 2016-08-09  Simon Fraser  <simon.fraser@apple.com>
1360
1361         Logging and other minor improvements to iOS webkitpy
1362         https://bugs.webkit.org/show_bug.cgi?id=160722
1363
1364         Reviewed by Dan Bates.
1365
1366         Fix --debug-rwt-logging to log all the calls to simctl as well as device state information,
1367         to make it easier to debug launching issues.
1368
1369         Have reset_preferences() reset the device, rather than just nuking the data
1370         directory (which broke some versions of the simulator).
1371
1372         Make the Simulator.app launch in the background with open -g.
1373
1374         Wait for the simulator device to be in a known state in some more places.
1375
1376         * Scripts/webkitpy/port/ios.py:
1377         (IOSSimulatorPort.setup_test_run):
1378         (IOSSimulatorPort._quit_ios_simulator):
1379         (IOSSimulatorPort.clean_up_test_run):
1380         (IOSSimulatorPort.setup_environ_for_server):
1381         (IOSSimulatorPort.reset_preferences):
1382         * Scripts/webkitpy/xcode/simulator.py:
1383         (Device.create):
1384         (Device.delete):
1385         (Device):
1386         (Device.reset):
1387         (Simulator.wait_until_device_is_booted):
1388         (Simulator.wait_until_device_is_in_state):
1389         (Simulator):
1390         (Simulator.delete_device):
1391         (Simulator.reset_device):
1392         (Simulator.lookup_or_create_device):
1393
1394 2016-08-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1395
1396         [GTK][EFL] ALSA_CARD environment variable is not passed for layout tests.
1397         https://bugs.webkit.org/show_bug.cgi?id=160697
1398
1399         Reviewed by Antonio Gomes.
1400
1401         * Scripts/webkitpy/port/base.py:
1402         (Port.to.setup_environ_for_server): Add ALSA_CARD and sort the Linux
1403         list of environment variables to copy.
1404
1405 2016-08-09  George Ruan  <gruan@apple.com>
1406
1407         Implement functionality of media capture on iOS
1408         https://bugs.webkit.org/show_bug.cgi?id=158945
1409         <rdar://problem/26893343>
1410
1411         Reviewed by Tim Horton.
1412
1413         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Enable Media
1414         Capture feature on iOS.
1415
1416 2016-08-09  Saam Barati  <sbarati@apple.com>
1417
1418         Parser<LexerType>::parseFunctionInfo() has the wrong info about captured vars when a function is not cached.
1419         https://bugs.webkit.org/show_bug.cgi?id=160671
1420         <rdar://problem/27756112>
1421
1422         Reviewed by Mark Lam.
1423
1424         * Scripts/run-jsc-stress-tests:
1425
1426 2016-08-09  Alexey Proskuryakov  <ap@apple.com>
1427
1428         Make directory reading code in iOSSimulatorDevices() more strict
1429         https://bugs.webkit.org/show_bug.cgi?id=160702
1430
1431         Reviewed by Tim Horton.
1432
1433         * Scripts/webkitdirs.pm:
1434         (iOSSimulatorDevices):
1435
1436 2016-08-06  Sam Weinig  <sam@webkit.org>
1437
1438         Replace NodeOrString with std::variant<RefPtr<Node>, String>
1439         https://bugs.webkit.org/show_bug.cgi?id=160638
1440
1441         Reviewed by Anders Carlsson.
1442
1443         * TestWebKitAPI/CMakeLists.txt:
1444         * TestWebKitAPI/Tests/WTF/Variant.cpp:
1445         Add additional tests for the initial state of std::variant and using
1446         makeVisitor for visiting.
1447
1448 2016-08-09  Aakash Jain  <aakash_jain@apple.com>
1449
1450         EWS logging should ensure the logging to file is stopped on queue termination
1451         https://bugs.webkit.org/show_bug.cgi?id=160698
1452         rdar://problem/24464570
1453
1454         Reviewed by Daniel Bates.
1455
1456         * Scripts/webkitpy/tool/bot/queueengine.py:
1457         (QueueEngine._stopping): Stop logging to file on queue termination.
1458         (QueueEngine._begin_logging): Configure the Python logger to log to file.
1459         * Scripts/webkitpy/common/system/logutils.py:
1460         (configure_logger_to_log_to_file): Return the handler so as to enable caller to remove it later.
1461         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
1462         (QueueEngineTest._run_engine): Removed extra newline character to improve log readability.
1463         * Scripts/webkitpy/tool/commands/queues.py:
1464         (AbstractQueue._log_directory): Reverting to os.path.join as we don't have host object.
1465         (AbstractQueue.queue_log_path): Same.
1466         (AbstractQueue.begin_work_queue): Removed logging initialization, it is now being done in QueueEngine.
1467         (AbstractQueue.__init__): Removed host parameter, not required anymore, it was required by logging initialization
1468         which moved to QueueEngine now.
1469         (PatchProcessingQueue.__init__): Same.
1470         (CommitQueue.__init__): Same.
1471         (AbstractReviewQueue.__init__): Same.
1472         (StyleQueue.__init__): Same.
1473         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1474         (TestCommitQueue): Removed host parameter.
1475         (TestCommitQueue.__init__): Same.
1476         (AbstractPatchQueueTest.test_next_patch): Same.
1477         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Same.
1478         (test_commit_queue_failure): Same.
1479         (mock_run_webkit_patch):
1480         (MockCommitQueueTask.results_from_patch_test_run): Same.
1481         (test_rollout_lands): Same.
1482         (test_non_valid_patch): Same.
1483         (test_auto_retry): Same.
1484         (test_style_queue_with_watch_list_exception): Same.
1485         (TestQueue.__init__): Deleted.
1486         (TestReviewQueue.__init__): Deleted.
1487         (TestFeederQueue.__init__): Deleted.
1488
1489 2016-08-09  Konstantin Tokarev  <annulen@yandex.ru>
1490
1491         webkit-gtk tarball fails to build due to missing files
1492         https://bugs.webkit.org/show_bug.cgi?id=160684
1493
1494         Reviewed by Alex Christensen.
1495
1496         * gtk/manifest.txt.in: Added back spi directories.
1497
1498 2016-08-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1499
1500         [GTK] Build the jhbuild with -O2 optimization level by default
1501         https://bugs.webkit.org/show_bug.cgi?id=160544
1502
1503         Reviewed by Michael Catanzaro.
1504
1505         * gtk/jhbuildrc: Pass -O2 when building the JHBuild, as also -g1
1506         which don't increases the required disk space significatively and
1507         provides better debug information than no passing it.
1508
1509 2016-08-09  Csaba Osztrogonác  <ossy@webkit.org>
1510
1511         Allow more --cmakeargs option in build-jsc and build-webkit
1512         https://bugs.webkit.org/show_bug.cgi?id=160340
1513
1514         Reviewed by Michael Catanzaro.
1515
1516         * Scripts/build-jsc:
1517         * Scripts/build-webkit:
1518
1519 2016-08-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1520
1521         Do not check if WebKitLibraries folder exists on EFL and GTK
1522         https://bugs.webkit.org/show_bug.cgi?id=160659
1523
1524         Reviewed by Csaba Osztrogonác.
1525
1526         Though WebKitLibraries is only needed by mac and win ports,
1527         EFL and GTK ports have checked whether it exists.
1528
1529         * Scripts/build-webkit:
1530
1531 2016-08-08  Aakash Jain  <aakash_jain@apple.com>
1532
1533         Some EWS console logs doesn't go to log file
1534         https://bugs.webkit.org/show_bug.cgi?id=160585
1535         rdar://problem/24464570
1536
1537         Reviewed by Daniel Bates.
1538
1539         * Scripts/webkitpy/common/system/logutils.py:
1540         (FileSystemHandler._open): Ensure that we open logfile in append mode in order to avoid
1541         any possible overwriting.
1542         * Scripts/webkitpy/common/system/filesystem.py:
1543         (FileSystem.open_text_file_for_writing): Add should_append parameter to append to file.
1544         * Scripts/webkitpy/common/system/filesystem_mock.py:
1545         (MockFileSystem.open_text_file_for_writing): Same.
1546         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1547         (RealFileSystemTest.test_read_and_write_text_file): Removed unused variable 'hex_equivalent'.
1548         (RealFileSystemTest.test_append_to_text_file): Added new unit test for testing append functionality.
1549         * Scripts/webkitpy/tool/commands/queues.py:
1550         (AbstractQueue.begin_work_queue): Configure the logger for overall webkitpy to log to file.
1551         This will ensure that all the sub-modules inside webkitpy will log to file.
1552
1553 2016-08-08  Simon Fraser  <simon.fraser@apple.com>
1554
1555         Have the iOS platform interit from the Apple platform in webkitpy
1556         https://bugs.webkit.org/show_bug.cgi?id=160672
1557
1558         Reviewed by Dan Bates.
1559         
1560         The IOSSimulatorPort used to inherit from Port, rather than ApplePort.
1561         Fix this, and move duplicated code from IOSSimulatorPort and MacPort into
1562         ApplePort.
1563         
1564         Since WinPort also inherits from ApplePort, it needs to stub out some things
1565         that are unavailable on Windows (leaks, sampling).
1566         
1567         Some SnowLeopard-related code and the associated test were removed.
1568
1569         * Scripts/webkitpy/port/apple.py:
1570         (ApplePort.__init__):
1571         (ApplePort):
1572         (ApplePort._make_leak_detector):
1573         (ApplePort.default_timeout_ms):
1574         (ApplePort.supports_per_test_timeout):
1575         (ApplePort.should_retry_crashes):
1576         (ApplePort._generate_all_test_configurations):
1577         (ApplePort.check_for_leaks):
1578         (ApplePort.print_leaks_summary):
1579         (ApplePort._path_to_webcore_library):
1580         (ApplePort.show_results_html_file):
1581         (ApplePort._merge_crash_logs):
1582         (ApplePort._look_for_all_crash_logs_in_log_dir):
1583         (ApplePort._get_crash_log):
1584         (ApplePort.look_for_new_crash_logs):
1585         (ApplePort.sample_process):
1586         (ApplePort.sample_file_path):
1587         (ApplePort.look_for_new_samples):
1588         (ApplePort._path_to_helper):
1589         (ApplePort.determine_full_port_name): Deleted.
1590         * Scripts/webkitpy/port/ios.py:
1591         (IOSSimulatorPort):
1592         (IOSSimulatorPort.__init__):
1593         (IOSSimulatorPort.default_timeout_ms): Deleted.
1594         (IOSSimulatorPort.supports_per_test_timeout): Deleted.
1595         (IOSSimulatorPort.should_retry_crashes): Deleted.
1596         (IOSSimulatorPort.check_for_leaks): Deleted.
1597         (IOSSimulatorPort.print_leaks_summary): Deleted.
1598         (IOSSimulatorPort._path_to_webcore_library): Deleted.
1599         (IOSSimulatorPort.show_results_html_file): Deleted.
1600         (IOSSimulatorPort.sample_file_path): Deleted.
1601         (IOSSimulatorPort._merge_crash_logs): Deleted.
1602         (IOSSimulatorPort._look_for_all_crash_logs_in_log_dir): Deleted.
1603         (IOSSimulatorPort.look_for_new_crash_logs): Deleted.
1604         (IOSSimulatorPort.look_for_new_samples): Deleted.
1605         (IOSSimulatorPort.sample_process): Deleted.
1606         (IOSSimulatorPort._path_to_helper): Deleted.
1607         (IOSSimulatorPort.make_command): Deleted.
1608         * Scripts/webkitpy/port/mac.py:
1609         (MacPort.__init__):
1610         (MacPort.make_command):
1611         (MacPort._build_java_test_support):
1612         (MacPort): Deleted.
1613         (MacPort.default_timeout_ms): Deleted.
1614         (MacPort.supports_per_test_timeout): Deleted.
1615         (MacPort.should_retry_crashes): Deleted.
1616         (MacPort.default_child_processes): Deleted.
1617         (MacPort.check_for_leaks): Deleted.
1618         (MacPort.print_leaks_summary): Deleted.
1619         (MacPort._path_to_webcore_library): Deleted.
1620         (MacPort.show_results_html_file): Deleted.
1621         (MacPort.sample_file_path): Deleted.
1622         (MacPort._merge_crash_logs): Deleted.
1623         (MacPort._look_for_all_crash_logs_in_log_dir): Deleted.
1624         (MacPort.look_for_new_crash_logs): Deleted.
1625         (MacPort.look_for_new_samples): Deleted.
1626         (MacPort.sample_process): Deleted.
1627         (MacPort._path_to_helper): Deleted.
1628         * Scripts/webkitpy/port/mac_unittest.py:
1629         (MacTest.test_default_child_processes): Deleted.
1630         * Scripts/webkitpy/port/win.py:
1631         (WinPort.look_for_new_samples):
1632         (WinPort):
1633         (WinPort.sample_process):
1634         (WinPort._make_leak_detector):
1635         (WinPort.check_for_leaks):
1636         (WinPort.print_leaks_summary):
1637         (WinPort._path_to_webcore_library):
1638
1639 2016-08-08  Matt Baker  <mattbaker@apple.com>
1640
1641         Unreviewed: moved myself to the reviewers list.
1642
1643         * Scripts/webkitpy/common/config/contributors.json:
1644
1645 2016-08-08  Chris Dumez  <cdumez@apple.com>
1646
1647         Update API tests in mac/SetDocumentURI.mm after r204247
1648         https://bugs.webkit.org/show_bug.cgi?id=160660
1649
1650         Reviewed by Alex Christensen.
1651
1652         * TestWebKitAPI/Tests/mac/SetDocumentURI.mm:
1653         (TestWebKitAPI::TEST):
1654
1655 2016-08-08  Jonathan Bedard  <jbedard@apple.com>
1656
1657         run-webkit-tests should trigger a spindump when WebContent process is unresponsive
1658         https://bugs.webkit.org/show_bug.cgi?id=159827
1659
1660         Reviewed by Daniel Bates.
1661
1662         This change was spurred by a process hang which occurred between tests and did
1663         not produce a meaningful crashlog.
1664
1665         * Scripts/webkitpy/port/driver.py:
1666         (Driver._check_for_driver_crash_or_unresponsiveness): Notify test controller when finished through stdin.
1667
1668          * Scripts/webkitpy/port/ios.py:
1669         (IOSSimulatorPort):
1670         (IOSSimulatorPort.sample_process): Attempt spindump, but use sample if spindump fails.
1671         * Scripts/webkitpy/port/mac.py:
1672         (MacPort):
1673         (MacPort.sample_process): Attempt spindump, but use sample if spindump fails.
1674
1675         * Scripts/webkitpy/port/mac_unittest.py: Changed expected values to match spindump calls, added specific spindump test.
1676         * Scripts/webkitpy/port/driver_unittest.py: Added dummy write function.
1677
1678         * WebKitTestRunner/TestController.h:
1679         (WTR::TestController::usingServerMode): Added accessor for m_usingServerMode.
1680         * WebKitTestRunner/TestInvocation.cpp:
1681         (WTR::TestInvocation::dumpWebProcessUnresponsiveness): Wait for stdin before continuing when in server mode.
1682
1683 2016-08-07  Dan Bernstein  <mitz@apple.com>
1684
1685         [Cocoa] Reply block leaks if the remote object doesn’t call it
1686         https://bugs.webkit.org/show_bug.cgi?id=160642
1687
1688         Reviewed by Sam Weinig.
1689
1690         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h: Declared a new method.
1691         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
1692         (TEST): Added a test case that checks that the reply block is released even when it’s not
1693           called.
1694         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
1695         (-[RemoteObjectRegistryPlugIn doNotCallCompletionHandler:]): Implement new method by not
1696           calling the completion handler.
1697
1698 2016-08-07  Chris Dumez  <cdumez@apple.com>
1699
1700         Write API test to cover crash fix in r204135
1701         https://bugs.webkit.org/show_bug.cgi?id=160587
1702
1703         Reviewed by Darin Adler.
1704
1705         Add API test to cover crash fix in r204135. This reproduces the crash
1706         by destroying a related WKWebView in the webViewWebContentProcessDidTerminate
1707         callback.
1708
1709         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
1710         (-[NavigationDelegate webViewWebContentProcessDidTerminate:]):
1711         (TEST):
1712
1713 2016-08-06  Chris Dumez  <cdumez@apple.com>
1714
1715         Unreviewed, rolling out r204226.
1716
1717         Broke some API tests
1718
1719         Reverted changeset:
1720
1721         "Write API test to cover crash fix in r204135"
1722         https://bugs.webkit.org/show_bug.cgi?id=160587
1723         http://trac.webkit.org/changeset/204226
1724
1725 2016-08-06  Aakash Jain  <aakash_jain@apple.com>
1726
1727         EWS Style Queue fails to process patches which fails validation
1728         https://bugs.webkit.org/show_bug.cgi?id=160632
1729
1730         Reviewed by Alexey Proskuryakov.
1731
1732         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
1733         (StyleQueueTask.validate): Add more information about validation failure.
1734         (StyleQueueTask.run): Pass the error details in the PatchIsNotValid exception.
1735         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1736         (test_non_valid_patch): Add a unit test to test the above code path.
1737
1738 2016-08-06  Sam Weinig  <sam@webkit.org>
1739
1740         WTF needs a variant implementation
1741         https://bugs.webkit.org/show_bug.cgi?id=160618
1742
1743         Reviewed by Darin Adler.
1744
1745         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1746         * TestWebKitAPI/Tests/WTF/Variant.cpp: Added.
1747         Add tests for the variant implementation.
1748
1749 2016-08-06  Chris Dumez  <cdumez@apple.com>
1750
1751         Write API test to cover crash fix in r204135
1752         https://bugs.webkit.org/show_bug.cgi?id=160587
1753
1754         Reviewed by Darin Adler.
1755
1756         Add API test to cover crash fix in r204135. This reproduces the crash
1757         by destroying a related WKWebView in the webViewWebContentProcessDidTerminate
1758         callback.
1759
1760         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
1761         (-[NavigationDelegate webViewWebContentProcessDidTerminate:]):
1762         (TEST):
1763
1764 2016-08-05  Tim Horton  <timothy_horton@apple.com>
1765
1766         run-api-tests should use a headed simulator
1767         https://bugs.webkit.org/show_bug.cgi?id=160611
1768
1769         Reviewed by Sam Weinig.
1770
1771         CADisplayLink doesn't work in a headless simulator, but is
1772         vital for the proper functioning of WebKit2 painting on iOS.
1773         So, we should not use a headless simulator.
1774
1775         * Scripts/run-api-tests:
1776         Launch a simulator app, don't just boot the simulator.
1777
1778         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
1779         Re-enable a test that works now.
1780
1781 2016-08-05  Dan Bernstein  <mitz@apple.com>
1782
1783         [Cocoa] WKRemoteObjectCoder doesn’t handle NSRange
1784         https://bugs.webkit.org/show_bug.cgi?id=160589
1785
1786         Reviewed by Tim Horton.
1787
1788         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
1789         (remoteObjectInterface): Fixed a mistake in the set of allowed classes in one of the reply
1790           blocks, which wasn’t caught because the test wasn’t run correctly.
1791         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
1792         (TEST): Fixed the -selectionAndClickInformationForClickAtPoint:completionHandler: test, and
1793           added a test that sends over an NSRange.
1794         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
1795         (-[RemoteObjectRegistryPlugIn takeRange:completionHandler:]): Added. Calls the completion
1796           handler with the range‘s location and length.
1797
1798 2016-08-05  Enrica Casucci  <enrica@apple.com>
1799
1800         Fixing tests failing after r204175.
1801
1802         Unreviewed.
1803
1804         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig:
1805
1806 2016-08-05  Enrica Casucci  <enrica@apple.com>
1807
1808         Build fix after 204053.
1809
1810         Unreviewed.
1811
1812         * TestWebKitAPI/Configurations/Base.xcconfig:
1813         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
1814         (-[MockContentFilterEnabler initWithCoder:]):
1815         (-[MockContentFilterEnabler dealloc]):
1816
1817 2016-08-05  Konstantin Tokarev  <annulen@yandex.ru>
1818
1819         Print test name in "Last character read from DRT..." error message.
1820         https://bugs.webkit.org/show_bug.cgi?id=160559
1821
1822         Reviewed by Michael Catanzaro.
1823
1824         * Scripts/webkitpy/port/driver.py:
1825         (Driver.run_test):
1826         (Driver._read_first_block):
1827         (Driver._read_optional_image_block):
1828         (Driver._read_block):
1829         * Scripts/webkitpy/port/driver_unittest.py:
1830         (DriverTest.test_read_block):
1831         (DriverTest.test_read_binary_block):
1832         (DriverTest.test_read_base64_block):
1833
1834 2016-08-05  Commit Queue  <commit-queue@webkit.org>
1835
1836         Unreviewed, rolling out r204123.
1837         https://bugs.webkit.org/show_bug.cgi?id=160597
1838
1839         Caused layout test timeouts on Windows. (Requested by perarne
1840         on #webkit).
1841
1842         Reverted changeset:
1843
1844         "[Win] Unable to reliably run tests in parallel"
1845         https://bugs.webkit.org/show_bug.cgi?id=140914
1846         http://trac.webkit.org/changeset/204123
1847
1848 2016-08-04  Saam Barati  <sbarati@apple.com>
1849
1850         Restore CodeBlock jettison code to jettison when a CodeBlock has been alive for a long time
1851         https://bugs.webkit.org/show_bug.cgi?id=151241
1852
1853         Reviewed by Benjamin Poulain.
1854
1855         * Scripts/run-jsc-stress-tests:
1856
1857 2016-08-04  Dean Johnson  <dean_johnson@apple.com>
1858
1859         UI improvements to Flakiness Dashboard.
1860         https://bugs.webkit.org/show_bug.cgi?id=153295
1861
1862         Reviewed by Alexey Proskuryakov.
1863
1864         * TestResultServer/static-dashboards/flakiness_dashboard.css:
1865         (td.options-container): Center text in most fields.
1866         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1867         (createBugHTML): Text/Grammar updates.
1868         (tableHeaders): Ditto.
1869         (htmlForSingleTestRow): Ditto.
1870         (headerForTestTableHtml): Ditto.
1871         * TestResultServer/static-dashboards/ui.js: Removed the "Group: " and "Test type: " headings.
1872         (ui.html.testTypeSwitcher): Deleted. Removes the "Group:" heading.
1873
1874 2016-08-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1875
1876         [GTK] install-dependencies script misses libxslt as build-dependency and some python libs for the run-benchmark script
1877         https://bugs.webkit.org/show_bug.cgi?id=160518
1878
1879         Reviewed by Michael Catanzaro.
1880
1881         * Scripts/webkitpy/thirdparty/__init__.py:
1882         (AutoinstallImportHook._install_twisted): Twisted requires zope.interface.
1883         * gtk/install-dependencies:
1884
1885 2016-08-04  Alexey Proskuryakov  <ap@apple.com>
1886
1887         Optimize bot watcher's dashboard a little
1888         https://bugs.webkit.org/show_bug.cgi?id=160515
1889         rdar://problem/26096900
1890
1891         Reviewed by Lucas Forschler.
1892
1893         Made re-sorting after loading an iteration more efficient.
1894
1895         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1896         (BuildbotIteration.prototype._updateWithData):
1897         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1898         (BuildbotQueue.prototype.updateIterationPosition):
1899
1900 2016-08-04  Per Arne Vollan  <pvollan@apple.com>
1901
1902         [Win] Unable to reliably run tests in parallel
1903         https://bugs.webkit.org/show_bug.cgi?id=140914
1904
1905         Reviewed by Brent Fulgham.
1906
1907         The cygpath utility function can fail badly when running with multiple DumpRenderTree
1908         processes. We can use string replacement to convert the Cygwin path to a Windows path
1909         instead.
1910  
1911         * Scripts/webkitpy/common/system/path.py:
1912         (cygpathFast):
1913         * Scripts/webkitpy/port/driver.py:
1914         (Driver._command_from_driver_input):
1915
1916 2016-08-03  Aakash Jain  <aakash_jain@apple.com>
1917
1918         Document instructions for increasing process and file limits
1919         https://bugs.webkit.org/show_bug.cgi?id=160528
1920         rdar://problem/24777576
1921
1922         Reviewed by Alexey Proskuryakov.
1923
1924         * Scripts/webkitpy/port/ios.py:
1925         (IOSSimulatorPort.default_child_processes):
1926
1927 2016-08-03  Anders Carlsson  <andersca@apple.com>
1928
1929         Remove the Objective-C bindings generator
1930         https://bugs.webkit.org/show_bug.cgi?id=160526
1931
1932         Reviewed by Sam Weinig.
1933
1934         * Scripts/run-bindings-tests:
1935         Update test.
1936
1937 2016-08-03  Tim Horton  <timothy_horton@apple.com>
1938
1939         Revise a TestWebKitAPI comment to mention the actual underlying problem
1940
1941         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
1942         Note that this is because of https://bugs.webkit.org/show_bug.cgi?id=160516
1943
1944 2016-08-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1945
1946         Benchmark test content-animation timeouts always
1947         https://bugs.webkit.org/show_bug.cgi?id=160057
1948
1949         Reviewed by Simon Fraser.
1950
1951         * Scripts/webkitpy/benchmark_runner/data/plans/Skipped: Added.
1952         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
1953         (start):
1954
1955 2016-08-02  Nan Wang  <n_wang@apple.com>
1956
1957         AX: Simulated touch events are not working on iOS
1958         https://bugs.webkit.org/show_bug.cgi?id=160395
1959         <rdar://problem/27633597>
1960
1961         Reviewed by Chris Fleizach.
1962
1963         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1964         (WTR::AccessibilityUIElement::press):
1965         (WTR::AccessibilityUIElement::setSelectedChild):
1966
1967 2016-08-02  Filip Pizlo  <fpizlo@apple.com>
1968
1969         run-javascriptcore-tests should accept multiple --extra-tests
1970         https://bugs.webkit.org/show_bug.cgi?id=160486
1971
1972         Reviewed by Saam Barati.
1973         
1974         We want to be able to pass --extra-tests multiple times, to supply an arbitrary number of extra
1975         test suites. This does it by using GetOpt::Long's array support.
1976
1977         * Scripts/run-javascriptcore-tests:
1978         (runJSCStressTests):
1979
1980 2016-08-02  Enrica Casucci  <enrica@apple.com>
1981
1982         Allow building with content filtering disabled.
1983         https://bugs.webkit.org/show_bug.cgi?id=160454
1984
1985         Reviewed by Simon Fraser.
1986
1987         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1988
1989 2016-08-02  Brady Eidson  <beidson@apple.com>
1990
1991         Removing IndexedDB WebsiteData can fail for some users.
1992         https://bugs.webkit.org/show_bug.cgi?id=160463
1993
1994         Reviewed by Alex Christensen.
1995
1996         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm:
1997
1998 2016-08-01  Alex Christensen  <achristensen@webkit.org>
1999
2000         _WKDownloadDelegate.didReceiveResponse should be called before decideDestinationWithSuggestedFilename
2001         https://bugs.webkit.org/show_bug.cgi?id=160437
2002         <rdar://problem/27578272>
2003
2004         Reviewed by Brady Eidson.
2005
2006         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2007         (-[DownloadDelegate _download:didReceiveResponse:]):
2008         (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
2009         (runTest):
2010         Add a boolean to make sure that didReceiveResponse is called before decideDestinationWithSuggestedFilename.
2011
2012 2016-08-01  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2013
2014         [Tools] The GDB backtrace report tool don't checks the gdb return code.
2015         https://bugs.webkit.org/show_bug.cgi?id=160414
2016
2017         Reviewed by Michael Catanzaro.
2018
2019         * Scripts/webkitpy/port/linux_get_crash_log.py:
2020         (GDBCrashLogGenerator._wait_for_corefile):
2021
2022 2016-08-01  Youenn Fablet  <youenn@apple.com>
2023
2024         Make wpt server generate its certificates in layout test results folder
2025         https://bugs.webkit.org/show_bug.cgi?id=160422
2026
2027         Reviewed by Chris Dumez.
2028
2029         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2030         (WebPlatformTestServer._copy_webkit_test_files): Setting certificate folder to layout tests results directory.
2031
2032 2016-08-01  Jonathan Bedard  <jbedard@apple.com>
2033
2034         Function Call on NULL Object
2035         https://bugs.webkit.org/show_bug.cgi?id=160325
2036
2037         Reviewed by Darin Adler.
2038
2039         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2040         (WTR::InjectedBundle::didReceiveMessageToPage): Changed removeAllWebNotificationPermissions() call to static function call.
2041         * WebKitTestRunner/InjectedBundle/TestRunner.h: Made all web-notification functions static.
2042
2043 2016-08-01  Keith Miller  <keith_miller@apple.com>
2044
2045         We should not keep the JavaScript tests inside the Source/JavaScriptCore/ directory.
2046         https://bugs.webkit.org/show_bug.cgi?id=160372
2047
2048         Rubber stamped by Geoffrey Garen.
2049
2050         This patch moves all the JavaScript tests from Source/JavaScriptCore/tests to
2051         a new top level directory, JSTests. Having the tests in the Source directory
2052         was both confusing an inconvenient for people that just want to checkout the
2053         source code of WebKit. Since there is no other obvious place to put all the
2054         JavaScript tests a new top level directory seemed the most sensible.
2055
2056         * Scripts/import-test262-tests:
2057         * Scripts/run-javascriptcore-tests:
2058         * Scripts/update-javascriptcore-test-res:
2059
2060 2016-07-31  Nan Wang  <n_wang@apple.com>
2061
2062         AX: Add a check for touch event listener on iOS accessibility object
2063         https://bugs.webkit.org/show_bug.cgi?id=160388
2064
2065         Reviewed by Chris Fleizach.
2066
2067         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2068         (AccessibilityUIElement::boolAttributeValue):
2069         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2070         (WTR::AccessibilityUIElement::boolAttributeValue):
2071
2072 2016-07-30  Manuel Rego Casasnovas  <rego@igalia.com>
2073
2074         Unreviewed: add myself to the reviewers list.
2075
2076         * Scripts/webkitpy/common/config/contributors.json:
2077
2078 2016-07-29  Alexey Proskuryakov  <ap@apple.com>
2079
2080         Undo r203939, and copy over a rule that clips the logos.
2081
2082         Sierra wasn't the only logo without transparency.
2083
2084         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
2085         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png:
2086         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2087
2088 2016-07-29  Alan Sien Wei Hshieh  <hshieh@apple.com>
2089
2090         The Sierra asset at build.webkit.org/dashboard/images/Sierra*.png has a white background
2091         https://bugs.webkit.org/show_bug.cgi?id=160377
2092
2093         Reviewed by Brian Weinstein.
2094
2095         Update assets to remove the white background and use a transparent background instead.
2096
2097         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
2098         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png:
2099
2100 2016-07-29  David Kilzer  <ddkilzer@apple.com>
2101
2102         Ignore most check-webkit-style checks for ANGLE project
2103         <https://webkit.org/b/160333>
2104
2105         Reviewed by Daniel Bates.
2106
2107         * Scripts/webkitpy/style/checker.py: Ignore all checkers except:
2108         - No tabs.
2109         - No spaces at the end of lines.
2110         - No carriage returns (DOS line endings).
2111
2112 2016-07-29  Wenson Hsieh  <wenson_hsieh@apple.com>
2113
2114         Media controls are not displayed for some autoplaying videos at certain browser dimensions
2115         https://bugs.webkit.org/show_bug.cgi?id=160360
2116         <rdar://problem/27179484>
2117
2118         Reviewed by Myles C. Maxfield.
2119
2120         Adds two tests verifying that videos may be considered main content as long as they
2121         are large enough and cover a majority of the mainframe's viewport.
2122
2123         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2124         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2125         (TestWebKitAPI::TEST):
2126         * TestWebKitAPI/Tests/WebKit2Cocoa/full-size-autoplaying-video-with-audio.html: Added.
2127         * TestWebKitAPI/Tests/WebKit2Cocoa/skinny-autoplaying-video-with-audio.html: Added.
2128
2129 2016-07-29  Mark Lam  <mark.lam@apple.com>
2130
2131         Gardening: removed unused variable.
2132
2133         Not reviewed.
2134
2135         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2136         (TestWebKitAPI::TEST):
2137
2138 2016-07-29  Wenson Hsieh  <wenson_hsieh@apple.com>
2139
2140         Add TestWebKitAPI support for interacting with media controls
2141         https://bugs.webkit.org/show_bug.cgi?id=160342
2142         <rdar://problem/27610246>
2143
2144         Reviewed by Beth Dakin.
2145
2146         Adds support for testing interaction with some media controls, as well as a basic test
2147         verifying that media control teardown after interaction does not result in a crash.
2148
2149         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2150         (-[WKWebView mouseDownAtPoint:]):
2151         (-[WKWebView performAfterLoading:]):
2152         (TestWebKitAPI::TEST):
2153
2154 2016-07-29  Jonathan Bedard  <jbedard@apple.com>
2155
2156         Crash Log Clobbering on Unbound Crashes
2157         https://bugs.webkit.org/show_bug.cgi?id=160198
2158         <rdar://problem/27472618>
2159
2160         Reviewed by Alexey Proskuryakov.
2161
2162         * Scripts/webkitpy/common/system/crashlogs.py:
2163         (CrashLogs): Fix header order.
2164         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2165         (TestResultWriter.output_filename): Only remove file extension if it is clearly a file extension.
2166
2167 2016-07-29  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
2168
2169         Update for contributors.json
2170         https://bugs.webkit.org/show_bug.cgi?id=160294
2171
2172         * Scripts/webkitpy/common/config/contributors.json:
2173
2174 2016-07-28  Myles C. Maxfield  <mmaxfield@apple.com>
2175
2176         Remove deprecated SPI for video inline / fullscreen controls
2177         https://bugs.webkit.org/show_bug.cgi?id=160318
2178
2179         Reviewed by Tim Horton.
2180
2181         * DumpRenderTree/mac/DumpRenderTree.mm:
2182         (setDefaultsToConsistentValuesForTesting): Deleted.
2183         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
2184         (RequiresUserActionForPlaybackTest::SetUp): Deleted.
2185         * WebKitTestRunner/TestController.cpp:
2186         (WTR::TestController::resetPreferencesToConsistentValues): Deleted.
2187         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2188         (WTR::initializeWebViewConfiguration): Deleted.
2189
2190 2016-07-28  Daniel Bates  <dabates@apple.com>
2191
2192         [iOS] TestWebKitAPI bundle targets are not code signed
2193         https://bugs.webkit.org/show_bug.cgi?id=160328
2194         <rdar://problem/27409246>
2195
2196         Reviewed by Andy Estes.
2197
2198         Workaround <rdar://problem/27459890> by explicitly defining Xcode build settings
2199         CODE_SIGNING_ALLOWED and AD_HOC_CODE_SIGNING_ALLOWED to be YES so as to allow the
2200         the TestWebKitAPI bundle targets to be code signed when building for the iOS simulator.
2201
2202         * TestWebKitAPI/Configurations/Base.xcconfig:
2203
2204 2016-07-28  Tim Horton  <timothy_horton@apple.com>
2205
2206         Disable WebKit2.ResizeWithHiddenContentDoesNotHang for now
2207
2208         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
2209         (animatedResizeWebView):
2210         (TEST):
2211         This test times out only when run in the WebKit Testing simulator environment,
2212         but not in a fresh simulator. Disabling to keep the bots green while under investigation.
2213
2214 2016-07-28  Tim Horton  <timothy_horton@apple.com>
2215
2216         Frequent animation lags when interacting with Safari (sidebar, tab switching, etc.)
2217         https://bugs.webkit.org/show_bug.cgi?id=160289
2218         <rdar://problem/27553464>
2219
2220         Reviewed by Simon Fraser.
2221
2222         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2223         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2224         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm: Added.
2225         (-[AnimatedResizeNavigationDelegate _webView:renderingProgressDidChange:]):
2226         (-[AnimatedResizeWebView _endAnimatedResize]):
2227         (animatedResizeWebView):
2228         (TEST):
2229         * TestWebKitAPI/Tests/WebKit2Cocoa/blinking-div.html: Added.
2230         Add two tests that ensure that hidden-content and animated resizes
2231         don't cause unnecessary synchronous waits. Only the hidden-content
2232         one fails before my patch, but it seemed reasonable to add both anyway.
2233
2234 2016-07-28  David Kilzer  <ddkilzer@apple.com>
2235
2236         webkit-patch upload --suggest-reviewers shouldn't break in the presence of deleted or moved files
2237         <https://webkit.org/b/83342>
2238
2239         Reviewed by Ryosuke Niwa.
2240
2241         * Scripts/webkitpy/common/checkout/scm/git.py:
2242         (Git.revisions_changing_file): Remove code to raise an exception
2243         when the file doesn't exist.  If a file was moved or renamed,
2244         then this caused the script to terminate, which was very
2245         frustrating when you wanted a list of reviewers.
2246         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2247         (SCMTest._shared_test_revisions_changing_file): Update test
2248         expectation to return an empty list of revisions.
2249         (test_create_patch_is_full_patch): Drive-by fix when running all
2250         webkitpy tests (including scm tests).
2251         * Scripts/webkitpy/common/checkout/scm/svn.py:
2252         (SVN.revisions_changing_file): Catch ScriptError exceptions and
2253         return an empty array of revisions if this occurs.
2254
2255 2016-07-28  Aakash Jain  <aakash_jain@apple.com>
2256
2257         EWS error message "Error: * did not process patch" should include explanation
2258         https://bugs.webkit.org/show_bug.cgi?id=159903
2259         <rdar://problem/27410788>
2260
2261         Reviewed by Alexey Proskuryakov.
2262
2263         * QueueStatusServer/handlers/statusbubble.py:
2264         (StatusBubble._build_bubble): Display more detailed error message on bubbles when patch
2265         is not processed.
2266         * QueueStatusServer/handlers/processingtimesjson.py:
2267         (ProcessingTimesJSON._resultFromFinalStatus): Updated error message to match with rest
2268         of the code.
2269         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2270         (CommitQueueTask.validate): Add more information about validation failure.
2271         (CommitQueueTask.run): Pass the error details in the PatchIsNotValid exception.
2272         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
2273         (EarlyWarningSystemTask.validate): Add more information about validation failure.
2274         (EarlyWarningSystemTask.run): Pass the error details in the PatchIsNotValid exception.
2275         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2276         (PatchIsNotValid.__init__): Add the failure_message argument.
2277         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2278         (AbstractEarlyWarningSystem.review_patch): Re-word the error message and include
2279         failure details.
2280         * Scripts/webkitpy/tool/commands/queues.py:
2281         (CommitQueue.process_work_item): Same.
2282         (StyleQueue.review_patch): Same.
2283         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2284         (test_non_valid_patch): Updated test-cases messages to match the above changes.
2285
2286 2016-07-27  Alexey Proskuryakov  <ap@apple.com>
2287
2288         LayoutTestRelay should wait for WebKitTestRunnerApp installation to complete
2289         https://bugs.webkit.org/show_bug.cgi?id=160262
2290
2291         Reviewed by Daniel Bates.
2292
2293         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2294         (-[LTRelayController installApp]):
2295
2296 2016-07-27  Ryan Haddad  <ryanhaddad@apple.com>
2297
2298         Disable WebCoreNSURLSessionTest API tests on ios-simulator
2299         https://bugs.webkit.org/show_bug.cgi?id=160225
2300
2301         Reviewed by Alexey Proskuryakov.
2302
2303         * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
2304
2305 2016-07-27  Miguel Gomez  <magomez@igalia.com>
2306
2307         [GTK] Fix some video/canvas tests that should be passing
2308         https://bugs.webkit.org/show_bug.cgi?id=160023
2309
2310         Reviewed by Carlos Garcia Campos.
2311
2312         Add a platform identifier to the TestRunner's page user agent when the tests are run on the
2313         EFL or GTK platforms.
2314
2315         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2316         (WTR::TestController::platformConfigureViewForTest):
2317         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2318         (WTR::TestController::platformConfigureViewForTest):
2319
2320 2016-07-27  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2321
2322         [Tools] The built product doesn't contains the dwo files when DEBUG_FISSION is enabled.
2323         https://bugs.webkit.org/show_bug.cgi?id=160247
2324
2325         Reviewed by Michael Catanzaro.
2326
2327         * BuildSlaveSupport/built-product-archive:
2328         (createZip):
2329         (dirContainsdwo):
2330         (archiveBuiltProduct):
2331
2332 2016-07-26  Alex Christensen  <achristensen@webkit.org>
2333
2334         Fix tests after r203743.
2335         https://bugs.webkit.org/show_bug.cgi?id=156947
2336
2337         * WebKitTestRunner/TestController.cpp:
2338         (WTR::TestController::resetStateToConsistentValues):
2339         Reset the new boolean m_rejectsProtectionSpaceAndContinueForAuthenticationChallenges.
2340
2341 2016-07-26  Myles C. Maxfield  <mmaxfield@apple.com>
2342
2343         [iPhone] Playing a video on tudou.com plays only sound, no video
2344         https://bugs.webkit.org/show_bug.cgi?id=160178
2345         <rdar://problem/27535468>
2346
2347         Reviewed by Dan Bernstein.
2348
2349         * DumpRenderTree/mac/DumpRenderTree.mm:
2350         (setDefaultsToConsistentValuesForTesting):
2351         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
2352         (RequiresUserActionForPlaybackTest::SetUp):
2353         * WebKitTestRunner/TestController.cpp:
2354         (WTR::TestController::resetPreferencesToConsistentValues):
2355         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2356         (WTR::initializeWebViewConfiguration):
2357
2358 2016-07-26  Simon Fraser  <simon.fraser@apple.com>
2359
2360         Allow LOG macros to be used outside the namespace, and other logging cleanup
2361         https://bugs.webkit.org/show_bug.cgi?id=160216
2362
2363         Reviewed by Anders Carlsson.
2364         
2365         initializeLoggingChannelsIfNecessary -> initializeLogChannelsIfNecessary
2366
2367         * DumpRenderTree/TestRunner.cpp:
2368         * DumpRenderTree/mac/DumpRenderTree.mm:
2369         (resetWebViewToConsistentStateBeforeTesting):
2370
2371 2016-07-26  David Kilzer <ddkilzer@apple.com>
2372
2373         Networking process crash due to missing -[WebCoreAuthenticationClientAsChallengeSender performDefaultHandlingForAuthenticationChallenge:] implementation
2374         https://bugs.webkit.org/show_bug.cgi?id=156947
2375         <rdar://problem/23325160>
2376
2377         Reviewed by Alex Christensen.
2378
2379         * DumpRenderTree/TestRunner.cpp:
2380         (TestRunner::TestRunner):
2381         (setRejectsProtectionSpaceAndContinueForAuthenticationChallengesCallback):
2382         * DumpRenderTree/TestRunner.h:
2383         (TestRunner::rejectsProtectionSpaceAndContinueForAuthenticationChallenges):
2384         (TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
2385         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2386         (-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
2387         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2388         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2389         (WTR::TestRunner::queueNonLoadingScript):
2390         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
2391         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2392         * WebKitTestRunner/TestController.cpp:
2393         (WTR::TestController::didReceiveAuthenticationChallenge):
2394         * WebKitTestRunner/TestController.h:
2395         (WTR::TestController::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
2396         * WebKitTestRunner/TestInvocation.cpp:
2397         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2398         Add TestRunner.setRejectsProtectionSpaceAndContinueForAuthenticationChallenges to use for testing.
2399
2400 2016-07-26  David Kilzer  <ddkilzer@apple.com>
2401
2402         check-for-exit-time-destructors should be usable outside Xcode
2403         <https://webkit.org/b/160195>
2404
2405         Reviewed by Darin Adler.
2406
2407         * Scripts/check-for-exit-time-destructors: Update to parse
2408         -h|--help switch, or to take one argument to a binary to check
2409         for exit time destructors on the command-line.  The clang
2410         compiler will find these at compile-time with the
2411         -Wexit-time-destructors switch, but this script will check for
2412         them after-the-fact.
2413
2414 2016-07-26  Lucas Forschler  <lforschler@apple.com>
2415
2416         Test svn.webkit.org functionality after maintenance.
2417
2418 2016-07-25  Brady Eidson  <beidson@apple.com>
2419
2420         Modern IDB: Make sure IndexedDB works from file:// url documents by default
2421         https://bugs.webkit.org/show_bug.cgi?id=153783
2422
2423         Reviewed by Alex Christensen.
2424
2425         Previously, to grant IndexedDB access to file:// urls for testing purposes, 
2426         we had to call the SPI [WKWebViewConfiguration _setAllowUniversalAccessFromFileURLs:].
2427         
2428         As of https://trac.webkit.org/changeset/203695 this is no longer required.
2429         
2430         Change the relevant API tests to make sure this continues to be no longer required.
2431
2432         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
2433         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
2434         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
2435         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
2436         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm:
2437         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
2438
2439 2016-07-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2440
2441         Media controls should not be displayed for a video until it starts playing
2442         https://bugs.webkit.org/show_bug.cgi?id=160092
2443         <rdar://problem/26986673>
2444
2445         Reviewed by Beth Dakin.
2446
2447         Verify that multiple videos do or don't show the media controller depending on whether videos
2448         are playing. Also tweaks an existing API test (VideoControlsManagerSingleLargeVideo) that was
2449         passing because we were always showing media controls for large videos with audio, even if they
2450         had not played back yet. This change ensures that large videos with audio show media controls
2451         only after they begin to play back, and not by virtue of being large enough for main content.
2452
2453         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2454         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2455         (TestWebKitAPI::TEST):
2456         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-with-audio.html:
2457         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio-autoplay.html: Added.
2458         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio.html: Added.
2459
2460 2016-07-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2461
2462         Media controls on apple.com don't disappear when movie finishes playing
2463         https://bugs.webkit.org/show_bug.cgi?id=160068
2464         <rdar://problem/26668526>
2465
2466         Reviewed by Darin Adler.
2467
2468         Adds new API tests. Please see WebCore ChangeLog for more details.
2469
2470         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2471         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2472         (-[MediaPlaybackMessageHandler initWithWKWebView:finalMessageString:]):
2473         (-[MediaPlaybackMessageHandler userContentController:didReceiveScriptMessage:]):
2474         (TestWebKitAPI::TEST):
2475         (-[DidPlayMessageHandler initWithWKWebView:]): Deleted.
2476         (-[DidPlayMessageHandler userContentController:didReceiveScriptMessage:]): Deleted.
2477         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-hides-controls-after-seek-to-end.html: Added.
2478         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-after-ending.html: Added.
2479         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-to-beginning-and-play-after-ending.html: Added.
2480
2481 2016-07-25  Philippe Normand  <pnormand@igalia.com>
2482
2483         Unreviewed, fix test-webkitpy after r203674.
2484
2485         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
2486         (GDBCrashLogGeneratorTest.test_generate_crash_log):
2487
2488 2016-07-24  Philippe Normand  <pnormand@igalia.com>
2489
2490         Unreviewed, forgot to commit this file in r203674.
2491
2492         * Scripts/process-linux-coredump: Added.
2493         (main):
2494
2495 2016-07-25  Philippe Normand  <pnormand@igalia.com>
2496
2497         Improve GDB backtrace generation for GTK/EFL
2498         https://bugs.webkit.org/show_bug.cgi?id=128928
2499
2500         Reviewed by Carlos Garcia Campos.
2501
2502         The PID of the crashed process is now correctly supplied to the
2503         crash log reporter. The kernel core_pattern needs to be updated
2504         after this change to something like:
2505
2506         echo "|/home/phil/WebKit/Tools/Scripts/process-linux-coredump /tmp/core-pid_%p.dump" > /proc/sys/kernel/core_pattern
2507
2508         * Scripts/process-linux-coredump: Added.
2509         (main): Minimal python script reading coredump data on stdin and writing it to a file in /tmp/.
2510         * Scripts/webkitpy/port/efl.py:
2511         (EflPort._get_crash_log): Supply path of the process-linux-coredump script.
2512         * Scripts/webkitpy/port/gtk.py:
2513         (GtkPort._get_crash_log): Ditto.
2514         * Scripts/webkitpy/port/linux_get_crash_log.py:
2515         (GDBCrashLogGenerator.__init__): New argument for supplying the path of a coredump processor script.
2516         (GDBCrashLogGenerator.generate_crash_log): Update error message, the core_pattern should now be set to pipe coredumps to a script.
2517         (GDBCrashLogGenerator): Deleted.
2518         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
2519         (GDBCrashLogGeneratorTest.test_generate_crash_log): Update test expectations.
2520         * WebKitTestRunner/TestController.cpp:
2521         (WTR::TestController::networkProcessDidCrash): Supply PID of crash process.
2522         (WTR::TestController::databaseProcessDidCrash): Ditto.
2523         (WTR::TestController::processDidCrash): Ditto.
2524
2525 2016-07-23  Youenn Fablet  <youenn@apple.com>
2526
2527         WPT stash server should be kept running when launching wpt server
2528         https://bugs.webkit.org/show_bug.cgi?id=160052
2529
2530         Reviewed by Sam Weinig.
2531
2532         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
2533         (main): waiting to read stdin while stash server is started.
2534
2535 2016-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2536
2537         Media controls should be displayed for media in media documents
2538         https://bugs.webkit.org/show_bug.cgi?id=160104
2539         <rdar://problem/27438936>
2540
2541         Reviewed by Myles C. Maxfield.
2542
2543         Verifies that even a small video with audio in a media document gets media controls.
2544
2545         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2546         (TestWebKitAPI::TEST):
2547
2548 2016-07-22  Michael Saboff  <msaboff@apple.com>
2549
2550         REGRESSION(203616): no FTL testing was inadvertently removed
2551         https://bugs.webkit.org/show_bug.cgi?id=160100
2552
2553         Rubber-stamped by Filip Pizlo.
2554
2555         Added runNoFTL back into the set of tests we run on FTL enabled platforms.
2556         Renamed runLayoutTestNoFTL to runLayoutTestDefault.  Restructured the test
2557         logic for the runLayout and runNoisy variants to match the run test logic,
2558         that is we always invoke runXXXDefault and invoke runXXXNoFTL for FTL
2559         enabled platforms.
2560
2561         * Scripts/run-jsc-stress-tests:
2562
2563 2016-07-22  Brady Eidson  <beidson@apple.com>
2564
2565         Removing IndexedDatabases that have stored blobs doesn't remove the blob files.
2566         https://bugs.webkit.org/show_bug.cgi?id=160089
2567
2568         Reviewed by Darin Adler.
2569
2570         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2571         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm: Added.
2572         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobToBeDeleted.html: Added.
2573
2574 2016-07-22  Konstantin Tokarev  <annulen@yandex.ru>
2575
2576         [GTK] Improved exclusion patterns in make-dist.py manifest.
2577         https://bugs.webkit.org/show_bug.cgi?id=160094
2578
2579         Reviewed by Michael Catanzaro.
2580
2581         * gtk/manifest.txt.in:
2582         Exclude Platform*.cmake files for more ports.
2583         Removed obsolete .gyp and .pro.user patterns.
2584         Exclude 'Configurations' and 'spi' directories.
2585         Exclude CMakeLists.txt.user (Qt Creator IDE).
2586
2587 2016-07-22  Michael Saboff  <msaboff@apple.com>
2588
2589         Don't run FTL related JSC stress tests on non-FTL platforms
2590         https://bugs.webkit.org/show_bug.cgi?id=160033
2591
2592         Reviewed by Mark Lam.
2593
2594         Added check for running tests on platforms that don't enable FTL to not run FTL tests.
2595         Refactored several of the runXXX test methods to always runXXXDefault and made those
2596         runXXXDefault to pass FTL_OPTIONS.  For platforms that don't enable the FTL, FTL_OPTIONS
2597         doesn't cause a problem.
2598
2599         * Scripts/run-jsc-stress-tests:
2600
2601 2016-07-22  Per Arne Vollan  <pvollan@apple.com>
2602
2603         IWebView::mainFrame crashes if called after IWebView::close
2604         https://bugs.webkit.org/show_bug.cgi?id=32868
2605
2606         Reviewed by Brent Fulgham.
2607
2608         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp:
2609         (TestWebKitAPI::TEST_F): Added test.
2610
2611 2016-07-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2612
2613         [GTK] Enable threaded compositor by default
2614         https://bugs.webkit.org/show_bug.cgi?id=160079
2615
2616         Reviewed by Žan Doberšek.
2617
2618         * Scripts/webkitperl/FeatureList.pm:
2619
2620 2016-07-22  Youenn Fablet  <youenn@apple.com>
2621
2622         run-builtins-generator-tests should be able to test WebCore builtins wrapper with more than one file
2623         https://bugs.webkit.org/show_bug.cgi?id=159921
2624
2625         Reviewed by Brian Burg.
2626
2627         Updated builtin generator test runner to generate WebCore wrapper files based on all WebCore valid separate files.
2628
2629         * Scripts/webkitpy/codegen/main.py:
2630         (BuiltinsGeneratorTests.generate_from_js_builtins): Passing a list of builtin files to the script.
2631         (BuiltinsGeneratorTests):
2632         (BuiltinsGeneratorTests.single_builtin_test): Added to handle the case of single builtin generation.
2633         (BuiltinsGeneratorTests.wrappers_builtin_test): Added to handle the case of WebCore wrappers builtin generation.
2634         (BuiltinsGeneratorTests.run_test): Helper routine to run a test in reset mode or normal check mode.
2635         (BuiltinsGeneratorTests.run_tests): Updated to add WebCore wrappers builtin generation test.
2636
2637 2016-07-21  Dan Bernstein  <mitz@apple.com>
2638
2639         [Mac] webkitdirs.pm contains unused code to support outdated OS X and Xcode versions
2640         https://bugs.webkit.org/show_bug.cgi?id=160072
2641
2642         Reviewed by Andy Estes.
2643
2644         * Scripts/webkitdirs.pm:
2645         (readXcodeUserDefault): Changed to take a defaults key rather than a suffix. Removed support
2646           for old Xcode versions.
2647         (determineBaseProductDir): Removed support for old Xcode versions. Updated for the change
2648           to readXcodeUserDefault.
2649         (debugger): Deleted. This was only used for Darwin, where LLDB is now the only supported
2650           debugger.
2651         (determineDebugger): Ditto.
2652         (checkRequiredSystemConfig): Updated to require at least OS X Yosemite v10.10.5 and Xcode
2653           7.0.
2654         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Removed --use-gdb and --use-lldb
2655           switches.
2656         (execMacWebKitAppForDebugging): Removed support for GDB.
2657
2658 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
2659
2660         Remove support for deprecated SPI inlineMediaPlaybackRequiresPlaysInlineAttribute
2661         https://bugs.webkit.org/show_bug.cgi?id=160066
2662
2663         Reviewed by Dean Jackson.
2664
2665         * DumpRenderTree/mac/DumpRenderTree.mm:
2666         (setDefaultsToConsistentValuesForTesting): Deleted.
2667         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
2668         (RequiresUserActionForPlaybackTest::SetUp): Deleted.
2669         * WebKitTestRunner/TestController.cpp:
2670         (WTR::TestController::resetPreferencesToConsistentValues): Deleted.
2671         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2672         (WTR::initializeWebViewConfiguration): Deleted.
2673
2674 2016-07-21  Chelsea Pugh  <cpugh@apple.com>
2675
2676         [iOS] Apps using WKWebView will crash if they set the scroll view's delegate and don't nil it out later
2677         https://bugs.webkit.org/show_bug.cgi?id=159980
2678         rdar://problem/27450825
2679
2680         Reviewed by Dan Bernstein.
2681
2682         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2683         * TestWebKitAPI/Tests/ios/WKScrollViewDelegateCrash.mm: Added.
2684         (-[TestDelegateForScrollView dealloc]): Update delegateIsDeallocated to true so that we can tell
2685         when our delegate has hit -dealloc.
2686         (TestWebKitAPI::TEST): Ensure that after an object has been set as the scroll view's delegate,
2687         and has then been deallocated, that the scroll view's delegate is nil and the deallocated delegate
2688         will not be messaged.
2689
2690 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
2691
2692         Follow-up patch to r203520
2693         https://bugs.webkit.org/show_bug.cgi?id=159967
2694         <rdar://problem/26964090>
2695
2696         Unreviewed.
2697
2698         * DumpRenderTree/mac/DumpRenderTree.mm:
2699         (setDefaultsToConsistentValuesForTesting):
2700         * WebKitTestRunner/TestController.cpp:
2701         (WTR::TestController::resetPreferencesToConsistentValues):
2702
2703 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
2704
2705         [iPhone] Playing a video on tudou.com plays only sound, no video
2706         https://bugs.webkit.org/show_bug.cgi?id=159967
2707         <rdar://problem/26964090>
2708
2709         Reviewed by Jon Lee, Jeremy Jones, and Anders Carlsson.
2710
2711         Migrate tests to use new SPI.
2712
2713         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
2714         (RequiresUserActionForPlaybackTest::SetUp):
2715         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2716         (WTR::initializeWebViewConfiguration):
2717
2718 2016-07-21  Csaba Osztrogonác  <ossy@webkit.org>
2719
2720         Clarify testing mode names in run-jsc-stress-tests
2721         https://bugs.webkit.org/show_bug.cgi?id=160021
2722
2723         Reviewed by Mark Lam.
2724
2725         Default should mean really default, not default with disabled FTL, renamed
2726         - runMozillaTestDefault to runMozillaTestNoFTL
2727         - runMozillaTestDefaultFTL to runMozillaTestDefault
2728         - runDefault to runNoFTL
2729         - runDefaultFTL to runDefault
2730         - runLayoutTestDefault to runLayoutTestNoFTL
2731         - runLayoutTestDefaultFTL to runLayoutTestDefault
2732         - runNoisyTestDefault to runNoisyTestNoFTL
2733         - runNoisyTestDefaultFTL to runNoisyTestDefault
2734
2735         * Scripts/run-jsc-stress-tests:
2736
2737 2016-07-21  Yongjun Zhang  <yongjun_zhang@apple.com>
2738
2739         WebBackForwardList's currentIndex could get out of bounds when filtering items.
2740         https://bugs.webkit.org/show_bug.cgi?id=159986
2741
2742         Add a test to verify filtering out 2 items from a 3-item list will set the currentIndex
2743         to 0.
2744
2745         Reviewed by Dan Bernstein.
2746
2747         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2748         * TestWebKitAPI/Tests/WebKit2/WKBackForwardList.mm: Added.
2749         (-[WKBackForwardListTestNavigationDelegate webView:didFinishNavigation:]):
2750         (TEST):
2751
2752 2016-07-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2753
2754         [GTK] Web view background colors don't work in accelerated compositing mode
2755         https://bugs.webkit.org/show_bug.cgi?id=159455
2756
2757         Reviewed by Michael Catanzaro.
2758
2759         Set always RGBA visual to the view widget when setting a background color.
2760
2761         * MiniBrowser/gtk/BrowserWindow.c:
2762         (browser_window_set_background_color):
2763
2764 2016-07-20  Youenn Fablet  <youenn@apple.com>
2765
2766         Bots should run built-ins generator tests
2767         https://bugs.webkit.org/show_bug.cgi?id=159971
2768
2769         Reviewed by Alexey Proskuryakov.
2770
2771         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2772         (RunBuiltinsTests): New step to run built-in generator tests.
2773         (TestFactory.__init__): Adding an additional step for bultin generator tests.
2774         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Rebasing expectations.
2775         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Adding additional step for proper display.
2776
2777 2016-07-20  Aakash Jain  <aakash_jain@apple.com>
2778
2779         Revert temporary fix r203417
2780         https://bugs.webkit.org/show_bug.cgi?id=160001
2781
2782         Reviewed by Alexey Proskuryakov.
2783
2784         * EWSTools/start-queue-mac.sh: Revert the temporary fix.
2785
2786 2016-07-20  Aakash Jain  <aakash_jain@apple.com>
2787
2788         REGRESSION(r148588): ews classes might get garbage collected
2789         https://bugs.webkit.org/show_bug.cgi?id=159990
2790
2791         Reviewed by Ryosuke Niwa.
2792
2793         * Scripts/webkitpy/tool/commands/__init__.py: Store the loaded ews classes
2794         in a variable so that they do not get garbage collected.
2795
2796 2016-07-20  Jeremy Jones  <jeremyj@apple.com>
2797
2798         Add API test for layout constraints after exit fullscreen
2799         https://bugs.webkit.org/show_bug.cgi?id=159900
2800
2801         Reviewed by Jon Lee.
2802
2803         Added Fullscreen.LaytoutConstraints API test. 
2804         Tests fix from https://bugs.webkit.org/show_bug.cgi?id=159731
2805
2806         This test compares layout constraints on the web view before and after fullscreen to make sure 
2807         they are preserved.
2808
2809         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.html: Added.
2810         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.mm: Added.
2811         (-[FullscreenStateChangeMessageHandler userContentController:didReceiveScriptMessage:]):
2812         (TestWebKitAPI::TEST):
2813
2814 2016-07-20  Ryan Haddad  <ryanhaddad@apple.com>
2815
2816         Disable two failing API tests.
2817
2818         Unreviewed test gardening.
2819
2820         * TestWebKitAPI/Tests/mac/CandidateTests.mm:
2821         (TestWebKitAPI::TEST):
2822
2823 2016-07-20  Wenson Hsieh  <wenson_hsieh@apple.com>
2824
2825         Unreviewed iOS build fix.
2826
2827         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm: Only import Carbon.h on Mac.
2828
2829 2016-07-20  Wenson Hsieh  <wenson_hsieh@apple.com>
2830
2831         Media controls don't appear when pausing a small autoplaying video
2832         https://bugs.webkit.org/show_bug.cgi?id=159972
2833         <rdar://problem/27180657>
2834
2835         Reviewed by Beth Dakin.
2836
2837         Adds a new test that verifies media controls show up when pausing a small autoplayed video. Also adds mechanisms
2838         for simulating basic user interaction in VideoControlsManager.
2839
2840         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2841         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2842         (-[WKWebView mouseDownAtPoint:]):
2843         (-[DidPlayMessageHandler userContentController:didReceiveScriptMessage:]):
2844         (-[OnLoadMessageHandler initWithWKWebView:handler:]):
2845         (-[OnLoadMessageHandler userContentController:didReceiveScriptMessage:]):
2846         (TestWebKitAPI::TEST):
2847         * TestWebKitAPI/Tests/WebKit2Cocoa/autoplaying-video-with-audio.html: Added.
2848
2849 2016-07-20  Per Arne Vollan  <pvollan@apple.com>
2850
2851         [Win] MathML fonts are not found.
2852         https://bugs.webkit.org/show_bug.cgi?id=159920
2853
2854         Reviewed by Alex Christensen.
2855
2856         When looking up a font in the registry, use the /v option of the Windows 'reg query' command to query
2857         for a specific registry key value.
2858
2859         * Scripts/webkitdirs.pm:
2860         (fontExists):
2861
2862 2016-07-20  Joseph Pecoraro  <pecoraro@apple.com>
2863
2864         Improve prepare-ChangeLog for @media blocks
2865         https://bugs.webkit.org/show_bug.cgi?id=159907
2866
2867         Reviewed by Timothy Hatcher.
2868
2869         * Scripts/prepare-ChangeLog:
2870         (get_selector_line_ranges_for_css):
2871         Get a range for @media blocks just like a selector.
2872             Start Line = line with '{'
2873             End line = line with '}'
2874             Name = "@media ..."
2875
2876         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning-expected.txt:
2877         Improved error messages for unbalanced portions.
2878
2879         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests-expected.txt:
2880         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests.css:
2881         (.media-query::before):
2882         (@media only screen and (max-width: 980px)):
2883         (.media-query a):
2884         (@media (-webkit-min-device-pixel-ratio: 2)):
2885         (.both a):
2886         (.both b):
2887         (.media-query b):
2888         (.media-query::after):
2889
2890 2016-07-20  Csaba Osztrogonác  <ossy@webkit.org>
2891
2892         Fix expectedFailErrorHandler in run-jsc-stress-tests
2893         https://bugs.webkit.org/show_bug.cgi?id=159811
2894
2895         Reviewed by Yusuke Suzuki.
2896
2897         * Scripts/run-jsc-stress-tests:
2898
2899 2016-07-20  Csaba Osztrogonác  <ossy@webkit.org>
2900
2901         Unreviewed Mac cmake buildfix after r203426. Just for fun.
2902
2903         * TestWebKitAPI/PlatformMac.cmake:
2904
2905 2016-07-19  Filip Pizlo  <fpizlo@apple.com>
2906
2907         The default testing mode should not involve disabling the FTL JIT
2908         https://bugs.webkit.org/show_bug.cgi?id=159929
2909
2910         Rubber stamped by Mark Lam and Saam Barati.
2911         
2912         It used to be the case that most actively maintained ports did not have the FTL JIT enabled.
2913         Heck, for most of the FTL's initial development, it wasn't enabled anywhere. So, testing the
2914         FTL was not the default. You had to enable it with an option.
2915         
2916         For some reason we have kept this arrangement even though the FTL JIT is now the default on
2917         all of the major ports. This has become a serious pain. For example, it's useful to be able
2918         to say that a test should only run in the default config that is representative of what a
2919         normal user would see if they ran JSC. Clearly, this would be a config that does not
2920         explicitly disable the FTL JIT on the command line. However, if you try to specify this then
2921         your test won't run at all if the --ftl-jit option is not passed. That's dangerous!
2922         
2923         So, this change gets rid of all of this logic. I think it's better to get rid of it then to
2924         try to fix it, because:
2925         
2926         - I don't know what the fix would look like. Presumably it would ensure that ports that don't
2927           have the FTL enabled never run any tests that explicitly disable the FTL, since that
2928           doesn't do anything. The code is not really structured to allow this.
2929         
2930         - It benefits a minority of clients. Three build bots run tests in a config that has the FTL
2931           disabled in testing. On the other hand there are already build bots that do FTL tests
2932           despite having the FTL disabled by virtue of being a 32-bit platform. So, maybe rather than
2933           preserving this broken feature, we should create something that (a) acknowledges the fact
2934           that the FTL is the default on those platforms that support it and (b) avoids running
2935           no-ftl tests on precisely those platforms that don't have FTL.
2936         
2937         - To the extent that some bots benefited from disabling FTL tests, they were doing it by
2938           relying on a feature that was never meant to stick around. The FTL JIT is meant to be the
2939           default configuration. Disabling the FTL JIT is the non-default. So, we shouldn't be
2940           pretending that the FTL JIT is not the default just because some bots used that as an
2941           optimization.
2942         
2943         This change allows me to speed up some debug tests and paint some bots green.
2944
2945         * Scripts/run-javascriptcore-tests:
2946         (runJSCStressTests):
2947         * Scripts/run-jsc-stress-tests:
2948
2949 2016-07-19  Alex Christensen  <achristensen@webkit.org>
2950
2951         Fix API test after r203426.
2952         https://bugs.webkit.org/show_bug.cgi?id=159949
2953
2954         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
2955         (TEST):
2956         If there is website data already on disk, the initial count after putting the AppCache data in place will not be exactly 1.
2957         This is no problem.  We want to verify that it is a nonzero number and that it decrements by one when we remove the 1 AppCache data.
2958
2959 2016-07-19  Andy Estes  <aestes@apple.com>
2960
2961         Move WebKitErrorFrameLoadBlockedByContentFilter from WebKitErrors.h to WebKitErrorsPrivate.h
2962         https://bugs.webkit.org/show_bug.cgi?id=159956
2963
2964         Reviewed by Dan Bernstein.
2965
2966         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Included WKErrorRef.h.
2967         (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
2968         Used kWKErrorCodeFrameLoadBlockedByContentFilter instead of WebKitErrorFrameLoadBlockedByContentFilter.
2969         * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Included WebKitErrorsPrivate.h instead of WebKitErrors.h.
2970
2971 2016-07-19  Alex Christensen  <achristensen@webkit.org>
2972
2973         Add regression test for r203392
2974         https://bugs.webkit.org/show_bug.cgi?id=159949
2975
2976         Reviewed by Brady Eidson.
2977
2978         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
2979         (fileSize):
2980         (swizzledBundleIdentifierWebBookmarksD):
2981         (defaultApplicationCacheDirectory):
2982         (TEST):
2983         (swizzledBundleIdentifierMobileSafari): Deleted.
2984         This actually tests that webbookmarksd uses the path quirk in WebsiteDataStore::defaultApplicationCacheDirectory.
2985         I wanted to verify that it uses the same path as MobileSafari, but swizzling out the bundleIdentifier twice caused
2986         problems with the static bools that are set once in RuntimeApplicationChecks.mm.
2987
2988 2016-07-19  Alex Christensen  <achristensen@webkit.org>
2989
2990         Add regression test for r203392
2991         https://bugs.webkit.org/show_bug.cgi?id=159949
2992
2993         Reviewed by Brady Eidson.
2994
2995         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2996         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db: Added.
2997         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db-shm: Added.
2998         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db-wal: Added.
2999         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
3000         (TEST):
3001         (fileSize):
3002         (swizzledBundleIdentifierMobileSafari):
3003         (swizzledBundleIdentifierWebBookmarksD):
3004         (defaultApplicationCacheDirectory):
3005         * TestWebKitAPI/cocoa/InstanceMethodSwizzler.h: Copied from TestWebKitAPI/mac/InstanceMethodSwizzler.h.
3006         * TestWebKitAPI/cocoa/InstanceMethodSwizzler.mm: Copied from TestWebKitAPI/mac/InstanceMethodSwizzler.mm.
3007         * TestWebKitAPI/mac/InstanceMethodSwizzler.h: Removed.
3008         * TestWebKitAPI/mac/InstanceMethodSwizzler.mm: Removed.
3009
3010 2016-07-19  Keith Miller  <keith_miller@apple.com>
3011
3012         Test262 should have a file with the revision and url
3013         https://bugs.webkit.org/show_bug.cgi?id=159937
3014
3015         Reviewed by Mark Lam.
3016
3017         The import script should update the information from
3018         the path to the test262 repository it gets.
3019
3020         * Scripts/import-test262-tests:
3021
3022 2016-07-19  Alexey Proskuryakov  <ap@apple.com>
3023
3024         Temporary workaround for iOS EWS failing after the fix for bug 159539.
3025         To be deleted once the root cause is found and addressed.
3026
3027         * EWSTools/start-queue-mac.sh:
3028
3029 2016-07-19  Frederic Wang  <fwang@igalia.com>
3030
3031         [win] Fixup the register name for STIX Math and Latin Modern Math
3032
3033         Unreviewed follow-up of r203406
3034
3035         * Scripts/webkitdirs.pm:
3036         (checkInstalledTools):
3037
3038 2016-07-19  Frederic Wang  <fwang@igalia.com>
3039
3040         [win] Update the list of MathML fonts
3041         https://bugs.webkit.org/show_bug.cgi?id=156838
3042
3043         The set of recommended math fonts is now described at
3044         https://trac.webkit.org/wiki/MathML/Fonts
3045         We update the Perl script to use the latest list of fonts.
3046
3047         Reviewed by Brent Fulgham.
3048
3049         * Scripts/webkitdirs.pm:
3050         (checkInstalledTools):
3051
3052 2016-07-19  Per Arne Vollan  <pvollan@apple.com>
3053
3054         [Win] The test fast/scrolling/overflow-scroll-past-max.html is timing out.
3055         https://bugs.webkit.org/show_bug.cgi?id=159342
3056
3057         Reviewed by Darin Adler.
3058
3059         Implement required functions in event sender.
3060
3061         * DumpRenderTree/PlatformWin.cmake:
3062         * DumpRenderTree/win/EventSender.cpp:
3063         (monitorWheelEvents): Added.
3064         (callAfterScrollingCompletes): Added.
3065
3066 2016-07-19  Youenn Fablet  <youenn@apple.com>
3067
3068         Add new aliases to http test server
3069         https://bugs.webkit.org/show_bug.cgi?id=159878
3070
3071         Reviewed by Darin Adler.
3072
3073         Adding testharness.css, testharness.js and testharnessreport.js new aliases to http test servers.
3074         Adding explicitly these links to perl script.
3075         Extracting default alias in an aliases.json file.
3076         Reading that file from python scripts to initialize aliases from that file.
3077
3078         Python script changes covered by unit tests and changed layout test.
3079
3080         * Scripts/webkitperl/httpd.pm:
3081         (getDefaultConfigForTestDirectory): Adding 3 new aliases
3082         * Scripts/webkitpy/layout_tests/servers/aliases.json: Added.
3083         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
3084         (LayoutTestApacheHttpd.__init__): Setting upper class tests_dir member if needed and according constructor parameter.
3085         Adding -c directives for each alias.
3086         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
3087         (TestLayoutTestApacheHttpd.test_start_cmd): Adding aliases.json mock-up file.
3088         * Scripts/webkitpy/layout_tests/servers/http_server.py:
3089         (Lighttpd.__init__): Setting upper class tests_dir member if needed and according constructor parameter.
3090         Adding alias directive for each alias.
3091         (Lighttpd._prepare_config):
3092         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
3093         (HttpServerBase.__init__): Adding tests_dir member with a default value being layout tests directory.
3094         (HttpServerBase.aliases): Computing of alias from the json file, paths to the real files being relative to
3095         layout tests directory.
3096         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
3097         (TestHttpServer.test_start_cmd): Adding aliases.json mock-up file and updating test expectation.
3098         (TestHttpServer.test_win32_start_and_stop): Adding aliases.json mock-up file.
3099
3100 2016-07-18  Aakash Jain  <aakash_jain@apple.com>
3101
3102         EWS console logs doesn't go to log file
3103         https://bugs.webkit.org/show_bug.cgi?id=159539
3104         <rdar://problem/24464570>
3105
3106         Reviewed by David Kilzer.
3107
3108         * Scripts/webkitpy/common/system/logutils.py:
3109         (configure_logger_to_log_to_file): Added method to configure the logger to log to file.
3110         (FileSystemHandler): Added class which uses logging.FileHandler as base class and supports writing
3111         to filesystem. It also supports passing MockFilesystem.
3112         (FileSystemHandler.__init__): Initialize the class and calls base class __init__.
3113         (FileSystemHandler._open): Overrides the base class _open method to use filesystem object.
3114         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3115         (AbstractEarlyWarningSystemTest.test_failing_tests_message): Added MockHost() parameter.
3116         (_test_ews): Same.
3117         * Scripts/webkitpy/tool/commands/queues.py:
3118         (AbstractQueue.begin_work_queue): Configure the logger to log to file.
3119         (AbstractQueue._log_directory): Using filesystem object instead of os.
3120         (AbstractQueue.queue_log_path): Same.
3121         (AbstractQueue.__init__): Passed host parameter.
3122         (PatchProcessingQueue.__init__): Same.
3123         (CommitQueue.__init__): Same.
3124         (AbstractReviewQueue.__init__): Same.
3125         (StyleQueue.__init__): Same.
3126         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3127         (TestCommitQueue): Passed MockHost() as host.
3128         (TestCommitQueue.__init__): Same.
3129         (TestQueue.__init__): Same.
3130         (TestReviewQueue.__init__): Same.
3131         (TestFeederQueue.__init__): Same.
3132         (AbstractPatchQueueTest.test_next_patch): Same.
3133         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Same.
3134         (test_commit_queue_failure): Same.
3135         (MockCommitQueueTask.results_from_patch_test_run): Same.
3136         (test_rollout_lands): Same.
3137         (test_non_valid_patch): Same.
3138         (test_auto_retry): Same.
3139         (test_style_queue_with_watch_list_exception): Same.
3140
3141 2016-07-02  Filip Pizlo  <fpizlo@apple.com>
3142
3143         WTF::Lock should be fair eventually
3144         https://bugs.webkit.org/show_bug.cgi?id=159384
3145
3146         Reviewed by Geoffrey Garen.
3147
3148         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
3149
3150 2016-07-17  Sam Weinig  <sam@webkit.org>
3151
3152         [WebKit API] Add SPI to track multiple navigations caused by a single user gesture
3153         <rdar://problem/26554137>
3154         https://bugs.webkit.org/show_bug.cgi?id=159856
3155
3156         Reviewed by Dan Bernstein.
3157
3158         * MiniBrowser/mac/WK2BrowserWindowController.m:
3159         (-[WK2BrowserWindowController webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3160         Add basic window.open implementation.
3161
3162         (-[WK2BrowserWindowController webView:decidePolicyForNavigationAction:decisionHandler:]):
3163         Add basic navigation policy implementation which implements a rule where a user gesture is only allowed
3164         to open a single non-web URL, all others are dropped.
3165
3166         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3167         * TestWebKitAPI/Tests/WebKit2Cocoa/UserInitiatedActionInNavigationAction.mm: Added.
3168         * TestWebKitAPI/Tests/WebKit2Cocoa/open-multiple-external-url.html: Added.
3169         Add API for the new SPI.
3170
3171 2016-07-17  Yusuke Suzuki  <utatane.tea@gmail.com>
3172
3173         [JSC] Enable test262 module tests
3174         https://bugs.webkit.org/show_bug.cgi?id=159854
3175
3176         Reviewed by Saam Barati.
3177
3178         Use --module-file instead.
3179
3180         * Scripts/run-jsc-stress-tests:
3181
3182 2016-07-16  Chris Dumez  <cdumez@apple.com>
3183
3184         Unreviewed, rolling out r203318.
3185
3186         Regressed most JS Benchmarks on MacBook Air by ~2% (7% on
3187         SunSpider)
3188
3189         Reverted changeset:
3190
3191         "[JSC] Change some parameters based on a random search"
3192         https://bugs.webkit.org/show_bug.cgi?id=158514
3193         http://trac.webkit.org/changeset/203318
3194
3195 2016-07-16  Chris Dumez  <cdumez@apple.com>
3196
3197         Add move constructor / assignment operator to ListHashSet
3198         https://bugs.webkit.org/show_bug.cgi?id=159837
3199
3200         Reviewed by Darin Adler.
3201
3202         Add API tests.
3203
3204         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
3205         (TestWebKitAPI::TEST):
3206
3207 2016-07-15  Benjamin Poulain  <bpoulain@apple.com>
3208
3209         [JSC] Change some parameters based on a random search
3210         https://bugs.webkit.org/show_bug.cgi?id=158514
3211
3212         Reviewed by Saam Barati.
3213
3214         * Scripts/run-jsc-stress-tests:
3215
3216 2016-07-15  Jon Davis  <jond@apple.com>
3217
3218         Changed the start page URL for WebKit Nightly builds.
3219         https://bugs.webkit.org/show_bug.cgi?id=159816
3220
3221         Reviewed by Timothy Hatcher.
3222
3223         * WebKitLauncher/start.html:
3224
3225 2016-07-15  Per Arne Vollan  <pvollan@apple.com>
3226
3227         Uninitialized variable in DIBPixelData can cause a dangerous memory write
3228         https://bugs.webkit.org/show_bug.cgi?id=159414
3229
3230         Reviewed by Brent Fulgham.
3231
3232         Add test to check that DIBPixelData::setRGBABitmapAlpha does not cause a crash
3233         when the HDC parameter is invalid.
3234
3235         * TestWebKitAPI/PlatformWin.cmake:
3236         * TestWebKitAPI/Tests/WebCore/win/DIBPixelData.cpp: Added.
3237         (TestWebKitAPI::TEST):
3238
3239 2016-07-15  Carlos Garcia Campos  <cgarcia@igalia.com>
3240
3241         [GTK] Add basic tabs support to MiniBrowser
3242         https://bugs.webkit.org/show_bug.cgi?id=159803
3243
3244         Reviewed by Sergio Villar Senin.
3245
3246         It's quite common to have issues with web views loaded in secondary tabs, and we need to use an external browser
3247         like epiphany to debug those issues. It would be a lot easier to work on those bugs if we could use the MiniBrowser.
3248
3249         * MiniBrowser/gtk/BrowserTab.c: Added.
3250         (titleChanged):
3251         (isLoadingChanged):
3252         (decidePolicy):
3253         (removeChildIfInfoBar):
3254         (loadChanged):
3255         (createInfoBarQuestionMessage):
3256         (tlsErrorsDialogResponse):
3257         (loadFailedWithTLSerrors):
3258         (permissionRequestDialogResponse):
3259         (decidePermissionRequest):
3260         (colorChooserRGBAChanged):
3261         (popoverColorClosed):
3262         (colorChooserRequestFinished):
3263         (runColorChooserCallback):
3264         (inspectorOpenedInWindow):
3265         (inspectorClosed):
3266         (browserTabSetProperty):
3267         (browserTabFinalize):
3268         (browser_tab_init):
3269         (browserTabConstructed):
3270         (browser_tab_class_init):
3271         (getInternalURI):
3272         (browser_tab_new):
3273         (browser_tab_get_web_view):
3274         (browser_tab_load_uri):
3275         (browser_tab_get_title_widget):
3276         (browser_tab_set_status_text):
3277         (browser_tab_toggle_inspector):
3278         (browser_tab_start_search):
3279         (browser_tab_stop_search):
3280         (browser_tab_add_accelerators):
3281         (fullScreenMessageTimeoutCallback):
3282         (browser_tab_enter_fullscreen):
3283         (browser_tab_leave_fullscreen):
3284         * MiniBrowser/gtk/BrowserTab.h: Added.
3285         * MiniBrowser/gtk/BrowserWindow.c:
3286         (getExternalURI):
3287         (browserWindowSetStatusText):
3288         (reloadOrStopCallback):
3289         (goBackCallback):
3290         (goForwardCallback):
3291         (settingsCallback):
3292         (webViewURIChanged):
3293         (browserWindowHistoryItemActivated):
3294         (browserWindowUpdateNavigationActions):
3295         (webViewCreate):
3296         (webViewEnterFullScreen):
3297         (webViewLeaveFullScreen):
3298         (webViewDecidePolicy):
3299         (browserWindowCanZoomIn):
3300         (browserWindowCanZoomOut):
3301         (browserWindowZoomIn):
3302         (browserWindowZoomOut):
3303         (scrollEventCallback):
3304         (faviconChanged):
3305         (webViewIsLoadingChanged):
3306         (defaultZoomCallback):
3307         (searchCallback):
3308         (newTabCallback):
3309         (toggleWebInspector):
3310         (reloadPage):
3311         (reloadPageIgnoringCache):
3312         (stopPageLoad):
3313         (loadHomePage):
3314         (editingCommandCallback):
3315         (insertImageCommandCallback):
3316         (insertLinkCommandCallback):
3317         (browserWindowSetupEditorToolbar):
3318         (browserWindowSwitchTab):
3319         (browserWindowTabAddedOrRemoved):
3320         (browser_window_init):
3321         (browserWindowConstructed):
3322         (browserWindowSaveSession):
3323         (browserWindowDeleteEvent):
3324         (browser_window_new):
3325         (browser_window_append_view):
3326         (browser_window_load_uri):
3327         (browser_window_load_session):
3328         (browser_window_set_background_color):
3329         (resetStatusText): Deleted.
3330         (activateUriEntryCallback): Deleted.
3331         (webViewTitleChanged): Deleted.
3332         (resetEntryProgress): Deleted.
3333         (browserWindowCreateBackForwardMenu): Deleted.
3334         (webViewReadyToShow): Deleted.
3335         (webViewLoadFailed): Deleted.
3336         (webViewMouseTargetChanged): Deleted.
3337         (browserWindowUpdateZoomActions): Deleted.
3338         (webViewZoomLevelChanged): Deleted.
3339         (updateUriEntryIcon): Deleted.
3340         (zoomInCallback): Deleted.
3341         (zoomOutCallback): Deleted.
3342         (toggleFullScreen): Deleted.
3343         (browserWindowEditingCommandToggleButtonSetActive): Deleted.
3344         (browserWindowFinalize): Deleted.
3345         (browser_window_class_init): Deleted.
3346         * MiniBrowser/gtk/BrowserWindow.h:
3347         * MiniBrowser/gtk/CMakeLists.txt:
3348         * MiniBrowser/gtk/main.c:
3349         (createBrowserTab):
3350         (aboutURISchemeRequestCallback):
3351         (main):
3352         (parseBackgroundColor): Deleted.
3353
3354 2016-07-14  Alex Christensen  <achristensen@webkit.org>
3355
3356         Allow RefPtrs of const RefCounted types
3357         https://bugs.webkit.org/show_bug.cgi?id=158269
3358
3359         Reviewed by Anders Carlsson.
3360
3361         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
3362         (TestWebKitAPI::TEST):
3363         (TestWebKitAPI::ConstRefCounted::create):
3364         (TestWebKitAPI::returnConstRefCountedRef):
3365         (TestWebKitAPI::returnRefCountedRef):
3366
3367 2016-07-13  Carlos Garcia Campos  <cgarcia@igalia.com>
3368
3369         Test WTF.StringViewIterators is crashing since r203119
3370         https://bugs.webkit.org/show_bug.cgi?id=159710
3371
3372         Reviewed by Darin Adler.
3373
3374         There are two problems in the test case added in r203119. First is that it's testing
3375         StringView::CodeUnits::Iterator instead of StringView::CodePoints::Iterator, and second is that
3376         StringView::codePoints() returns a temporary, so the iterator created from the temporary ends up pointing to a
3377         const reference to the string view member of the deleted CodePoints object.
3378
3379         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3380         (TestWebKitAPI::TEST):
3381
3382 2016-07-13  Daniel Bates  <dabates@apple.com>
3383
3384         [iOS] Copy WebKitTestRunnerInjectedBundle.bundle into PlugIns subdirectory and code sign it
3385         https://bugs.webkit.org/show_bug.cgi?id=159738
3386         <rdar://problem/27304649>
3387
3388         Reviewed by Dan Bernstein.
3389
3390         The bundle WebKitTestRunnerInjectedBundle.bundle contains executable code and should be
3391         code signed if applicable. We should also copy this bundle into the PlugIns subdirectory
3392         of the WebKitTestRunnerApp.app bundle instead of the top-level bundle directory as the
3393         PlugIns subdirectory is the directory where loadable bundles of an app are expected to live.
3394
3395         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3396         * WebKitTestRunner/ios/TestControllerIOS.mm:
3397         (WTR::TestController::initializeInjectedBundlePath): Modified code to look for the
3398         bundle WebKitTestRunnerInjectedBundle.bundle in the plugin directory of the main bundle.
3399
3400 2016-07-13  Beth Dakin  <bdakin@apple.com>
3401
3402         Attempted build fix.
3403
3404         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3405
3406 2016-07-12  Ryosuke Niwa  <rniwa@webkit.org>
3407
3408         REGRESSION(r202953): Clicking on input[type=file] doesn't open a file picker
3409         https://bugs.webkit.org/show_bug.cgi?id=159686
3410
3411         Reviewed by Chris Dumez.
3412
3413         Added a code to print "OPEN FILE PANEL" in the text when runOpenPanel is called in the UI delegate.
3414
3415         * WebKitTestRunner/TestController.cpp:
3416         (WTR::runOpenPanel):
3417         (WTR::TestController::createOtherPage):
3418         (WTR::TestController::createWebViewWithOptions):
3419
3420 2016-07-13  Beth Dakin  <bdakin@apple.com>
3421
3422         Add more candidate tests
3423         https://bugs.webkit.org/show_bug.cgi?id=159730
3424
3425         Reviewed by Tim Horton.
3426
3427         This patch re-names ViewWithEditableAreaLeak.mm to CandidateTests.mm and adds 
3428         two new tests to that file.
3429         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3430         * TestWebKitAPI/Tests/WebKit2Cocoa/focus-inputs.html: Added.
3431         * TestWebKitAPI/Tests/mac/CandidateTests.mm: Copied from TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm.
3432         (-[CandidateRequestFrameLoadDelegate webView:didFinishLoadForFrame:]):
3433         (TestWebKitAPI::TEST):
3434         * TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm: Removed.
3435
3436 2016-07-13  Joanmarie Diggs  <jdiggs@igalia.com>
3437
3438         AX: [ATK] spinbutton-crash.html fails
3439         https://bugs.webkit.org/show_bug.cgi?id=159723
3440
3441         Reviewed by Chris Fleizach.
3442
3443         Implement support for AXDecrementButton and AXIncrementButton in
3444         ATK's AccessibilityUIElement::uiElementAttributeValue().
3445
3446         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3447         (WTR::AccessibilityUIElement::uiElementAttributeValue):
3448
3449 2016-07-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3450
3451         [EFL] [GTK] Enable back crypto subtle on development builds.
3452         https://bugs.webkit.org/show_bug.cgi?id=159260
3453
3454         Reviewed by Carlos Garcia Campos.
3455
3456         * Scripts/webkitperl/FeatureList.pm:
3457
3458 2016-07-12  Mark Lam  <mark.lam@apple.com>
3459
3460         We should use different stack limits for stack checks from JS and host code.
3461         https://bugs.webkit.org/show_bug.cgi?id=159442
3462         <rdar://problem/26889188>
3463
3464         Reviewed by Geoffrey Garen.
3465
3466         In http://trac.webkit.org/r203067, we limited the amount of stack that tests will
3467         run with to keep stack overflow tests sane.  Turns out, we also need to teach the
3468         LayoutTestRelay to pass env vars over to the iOS simulator.  This is needed in
3469         order to keep the js/regress-139548.html test happy with this patch.
3470
3471         Also fixed up run_webkit_tests.py to explicitly pass an int size value for the
3472         JSC_maxPerThreadStackUsage option.  Otherwise, it will pass a float value.
3473
3474         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
3475         (-[LTRelayController _environmentVariables]):
3476         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3477         (main):
3478
3479 2016-07-12  Filip Pizlo  <fpizlo@apple.com>
3480
3481         platformUserPreferredLanguages on Mac should not try to put the region into the language
3482         https://bugs.webkit.org/show_bug.cgi?id=159693
3483
3484         Rubber stamped by Alexey Proskuryakov.
3485         
3486         Revert the test change in r200105.
3487
3488         * TestWebKitAPI/Tests/mac/NavigatorLanguage.mm:
3489         (TestWebKitAPI::languageForSystemLanguage):
3490
3491 2016-07-12  Chris Dumez  <cdumez@apple.com>
3492
3493         [WK2] Protect against bad database data in LocalStorageDatabase::importItems()
3494         https://bugs.webkit.org/show_bug.cgi?id=159663
3495         <rdar://problem/18995873>
3496
3497         Reviewed by Benjamin Poulain.
3498
3499         Add API test coverage.
3500
3501         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3502         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.html: Added.
3503         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.localstorage: Added.
3504         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.localstorage-shm: Added.
3505         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.mm: Added.
3506         (-[LocalStorageNullEntriesMessageHandler userContentController:didReceiveScriptMessage:]):
3507         (TEST):
3508
3509 2016-07-12  Myles C. Maxfield  <mmaxfield@apple.com>
3510
3511         Relax ordering requirements on StringView::CodePoints iterator
3512         https://bugs.webkit.org/show_bug.cgi?id=159609
3513
3514         Reviewed by Darin Adler.
3515
3516         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3517         (TestWebKitAPI::TEST):
3518
3519 2016-07-12  Youenn Fablet  <youenn@apple.com>
3520
3521         Fixing Tools/Scripts/run-builtins-generator-tests after https://trac.webkit.org/changeset/202975
3522         https://bugs.webkit.org/show_bug.cgi?id=159564
3523
3524         Reviewed by Brian Burg.
3525
3526         * Scripts/webkitpy/codegen/main.py:
3527         (BuiltinsGeneratorTests.generate_from_js_builtins): Changing --with-wrapper-files option to --wrappers.
3528
3529 2016-07-12  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3530
3531         Remove ENABLE_CSS3_TEXT_LINE_BREAK flag
3532         https://bugs.webkit.org/show_bug.cgi?id=159671
3533
3534         Reviewed by Csaba Osztrogonác.
3535
3536         ENABLE_CSS3_TEXT_LINE_BREAK feature was implemented without guards.
3537         https://bugs.webkit.org/show_bug.cgi?id=89235
3538
3539         So this guard can be removed in build scripts.
3540
3541         * Scripts/webkitperl/FeatureList.pm:
3542         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3543
3544 2016-07-11  Jason Marcell  <jmarcell@apple.com>
3545
3546         SVN.create_patch should find svn-create-patch relative to the WebKit root.
3547         https://bugs.webkit.org/show_bug.cgi?id=159652
3548
3549         Reviewed by Daniel Bates.
3550
3551         * Scripts/webkitpy/common/checkout/scm/svn.py:
3552         (SVN.create_patch): Use WebKitFinder to find the WebKit checkout so that we can find svn-create-patch relative to it.
3553
3554 2016-07-11  Myles C. Maxfield  <mmaxfield@apple.com>
3555
3556         Implement grapheme cluster iterator on StringView
3557         https://bugs.webkit.org/show_bug.cgi?id=159598
3558
3559         Reviewed by Anders Carlsson.
3560
3561         This is in preparation for honoring the second argument to FontFaceSet.load().
3562
3563         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3564         (TestWebKitAPI::compareLoopIterations):
3565         (TestWebKitAPI::TEST):
3566
3567 2016-07-11  Nan Wang  <n_wang@apple.com>
3568
3569         AX: WKWebView should have API to prevent pinch-to-zoom always being allowed
3570         https://bugs.webkit.org/show_bug.cgi?id=158364
3571
3572         Reviewed by Anders Carlsson.
3573
3574         Added a function in TestRunner so that we can toggle the ignoring viewport
3575         scale limits setting. Also added a test option for that in order to change the 
3576         configuration of the webview in test.
3577
3578         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3579         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3580         (WTR::TestRunner::setNavigationGesturesEnabled):
3581         (WTR::TestRunner::setIgnoresViewportScaleLimits):
3582         (WTR::nextUIScriptCallbackID):
3583         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3584         (WTR::TestRunner::shouldDecideNavigationPolicyAfterDelay):
3585         * WebKitTestRunner/TestController.cpp:
3586         (WTR::TestController::resetStateToConsistentValues):
3587         (WTR::updateTestOptionsFromTestHeader):
3588         (WTR::TestController::setNavigationGesturesEnabled):
3589         (WTR::TestController::setIgnoresViewportScaleLimits):
3590         (WTR::TestController::platformWillRunTest):
3591         * WebKitTestRunner/TestController.h:
3592         (WTR::TestController::setShouldDecideNavigationPolicyAfterDelay):
3593         * WebKitTestRunner/TestInvocation.cpp:
3594         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3595         * WebKitTestRunner/TestOptions.h:
3596         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3597         (WTR::TestController::platformCreateWebView):
3598
3599 2016-07-11  Konstantin Tokarev  <annulen@yandex.ru>
3600
3601         [GTK] install-dependencies should not install packages built by jhbuild.
3602         https://bugs.webkit.org/show_bug.cgi?id=159628
3603
3604         Reviewed by Michael Catanzaro.
3605
3606         * gtk/install-dependencies:
3607         Don't install icu, harfbuzz, orc, llvm, freetype, fontconfig.
3608
3609 2016-07-11  Olivier Blin  <olivier.blin@softathome.com>
3610
3611         System proxy settings not used when building deps with jhbuild
3612         https://bugs.webkit.org/show_bug.cgi?id=159567
3613
3614         Reviewed by Michael Catanzaro.
3615
3616         This adds the gsettings-desktop-schemas-devel build dep to enable
3617         the libgiognomeproxy.so gio module in glib-networking, which uses
3618         GSettings on org.gnome.system.proxy.
3619         This is needed to query system proxy settings for Gnome desktops.
3620
3621         dconf can be manually added to jhbuild to build the
3622         libdconfsettings.so gio module for GSettings, so that
3623         libgiognomeproxy.so can access system settings.
3624           https://trac.webkit.org/wiki/WebKitGTK/StartHacking#Workingbehindaproxy
3625
3626         As an alternative to dconf settings, this commit also adds the
3627         libproxy-devel build dep to enable the libgiolibproxy.so module in
3628         glib-networking (suggested by Fujii Hironori).
3629
3630         It is useful to read proxy settings from environment variables.
3631         From a Gnome desktop, one may unset the GNOME_DESKTOP_SESSION_ID
3632         environment variable to force using the envvar module in libproxy.