2011-04-01 Sam Weinig <sam@webkit.org>
[WebKit-https.git] / Tools / ChangeLog
1 2011-04-01  Sam Weinig  <sam@webkit.org>
2
3         Reviewed by Adam Roben.
4
5         Add adoptWK to WKRetainPtr.h
6         https://bugs.webkit.org/show_bug.cgi?id=57670
7
8         * TestWebKitAPI/PlatformUtilities.h:
9         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
10         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
11         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
12         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
13         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
14         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
15         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
16         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
17         (TestWebKitAPI::createSessionStateContainingFormData):
18         * WebKitTestRunner/StringFunctions.h:
19         Replace custom versions of adoptWK with the API on in WebKit2/WKRetainPtr.h.
20
21 2011-04-01  Sam Weinig  <sam@webkit.org>
22
23         Reviewed by Adam Roben.
24
25         Fix leak noticed by Adam Roben in LayoutTestController::shadowRoot.
26
27         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
28         (WTR::LayoutTestController::shadowRoot):
29         Make judicious use of adoptWK().
30
31 2011-04-01  Sam Weinig  <sam@webkit.org>
32
33         Reviewed by Timothy Hatcher.
34
35         Fix extract-localizable-strings for macro change from UI_STRING -> WEB_UI_STRING.
36
37         * Scripts/extract-localizable-strings:
38
39 2011-04-01  Anders Carlsson  <andersca@apple.com>
40
41         Reviewed by Sam Weinig.
42
43         Shockwave plug-in doesn't accept mouse events
44         https://bugs.webkit.org/show_bug.cgi?id=57653
45         <rdar://problem/8483273>
46
47         Add a plug-in test.
48
49         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
50         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
51         (PluginTest::indicateTestFailure):
52         Move code from NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject here.
53
54         (PluginTest::NPN_ConvertPoint):
55         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
56         * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp:
57         (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject):
58         Call indicateTestFailure.
59
60         * DumpRenderTree/TestNetscapePlugIn/Tests/mac: Added.
61         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/ConvertPoint.cpp: Added.
62         (ConvertPoint::ConvertPoint):
63         (ConvertPoint::testConvert):
64         (ConvertPoint::NPP_New):
65
66 2011-04-01  Dominic Cooney  <dominicc@google.com>
67
68         Reviewed by Martin Robinson.
69
70         Add layoutTestController.shadowRoot to GTK DumpRenderTree.
71         https://bugs.webkit.org/show_bug.cgi?id=57551
72
73         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
74         (LayoutTestController::shadowRoot):
75
76 2011-04-01  Sam Weinig  <sam@webkit.org>
77
78         Reviewed by Anders Carlsson.
79
80         WebKitTestRunner needs layoutTestController.shadowRoot
81         https://bugs.webkit.org/show_bug.cgi?id=57661
82
83         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
84         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
85         (WTR::LayoutTestController::shadowRoot):
86         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
87         Implement layoutTestController.shadowRoot for WebKit2.
88
89 2011-04-01  Chang Shu  <cshu@webkit.org>
90
91         Reviewed by Darin Adler.
92
93         WebKitTestRunner needs layoutTestController.setDatabaseQuota
94         https://bugs.webkit.org/show_bug.cgi?id=57568
95
96         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
97         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
98         (WTR::LayoutTestController::setDatabaseQuota):
99         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
100
101 2011-04-01  Dirk Pranke  <dpranke@chromium.org>
102
103         Reviewed by Tony Chang.
104
105         This patch completes the cleanup of
106         rebaseline-chromium-webkit-tests to work with all of the
107         variants of a platform (we can now rebaseline gpu- and non-gpu
108         files at the same time).
109
110         When the rebaselining is complete, any lines declared as
111         REBASELINE in the expectations file that matches a test that was
112         actually rebaselined will be deleted, even if only one of the
113         variants was actually rebaselined. This may cause odd problems,
114         but is better than where we're at today.
115
116         This change removes the -g flag and deprecates -w. The -g flag is gone
117         because GPU baselines are handled just like any other variant.
118         The -w flag is deprecated because this tool now only works
119         against the canaries, since that's the only place we have a full
120         set of bots. It will be trivial to change this to
121         build.webkit.org if we decide that's where we want them to be.
122
123         Also, this patch deletes a lot of cruft that is no longer needed
124         in the test_expectations code and the port-specific code.
125
126         https://bugs.webkit.org/show_bug.cgi?id=55191
127
128         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
129         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
130         * Scripts/webkitpy/layout_tests/port/base.py:
131         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
132         * Scripts/webkitpy/layout_tests/port/chromium.py:
133         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
134         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
135         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
136         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
137         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
138         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
139         * Scripts/webkitpy/layout_tests/port/mac.py:
140         * Scripts/webkitpy/layout_tests/port/test.py:
141         * Scripts/webkitpy/layout_tests/port/webkit.py:
142         * Scripts/webkitpy/layout_tests/port/win.py:
143         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
144         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
145
146 2011-04-01  Dirk Pranke  <dpranke@chromium.org>
147
148         Reviewed by Adam Barth.
149
150         rebaseline-chromium-webkit-tests does not work correctly with
151         version-specific baselines. This patch updates the tool to use
152         all of the version-specific bots on the canaries, and will now
153         attempt to rebaseline all of the versions by default, although
154         it will not update both GPU and CPU versions.
155         
156         Also, it will no longer modify the test_expectations.txt file
157         *at all*. You will have to manually delete the REBASELINE lines
158         after running the tool and determining that it did what you
159         wanted it to do. This should be fixed in a separate bug - see
160         webkit bug #55191.
161
162         https://bugs.webkit.org/show_bug.cgi?id=55608
163
164         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
165         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
166         * Scripts/webkitpy/layout_tests/port/chromium.py:
167         * Scripts/webkitpy/layout_tests/port/test.py:
168         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
169         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
170
171 2011-03-31  Tony Chang  <tony@chromium.org>
172
173         Reviewed by Ojan Vafai.
174
175         [chromium] update the rebaseline tool to know about pngs with checksums
176         https://bugs.webkit.org/show_bug.cgi?id=57481
177
178         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Skip over .checksum files if the checksum is already in the png
179         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
180
181 2011-04-01  Adam Roben  <aroben@apple.com>
182
183         Retrieve revision numbers from the build's got_revision property in Leaks Viewer
184
185         Previously, we were getting the revision of the first revision that triggered a build.
186         Choosing the last revision would have been more accurate. But got_revision is what is used
187         everywhere else on build.webkit.org, and should work even when there were no changes that
188         triggered a build (e.g., if someone clicked the Force Build button).
189
190         Fixes <http://webkit.org/b/57630> Leaks viewer gets some revision numbers wrong in the
191         recent builds list
192
193         Reviewed by Anders Carlsson.
194
195         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
196         (RecentBuildsLoader.prototype.start): Pull the revision number out of the got_revision
197         property, rather than out of the first (i.e., earliest) change in the sourceStamp object.
198
199         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js:
200         (Array.prototype.first): Added this helper function to return the first element in an array
201         that matches the given predicate, or null if no such element exists.
202
203 2011-03-31  Adam Roben  <aroben@apple.com>
204
205         Prefer (but don't require) bug URLs to be on their own line when parsing bug numbers from ChangeLogs
206
207         Fixes <http://webkit.org/b/57579> webkit-patch is too strict about bug URL formatting
208
209         Reviewed by Darin Adler.
210
211         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
212         (parse_bug_id_from_changelog): Fall back to parse_bug_id if we weren't able to find a bug
213         URL on its own line.
214
215         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
216         (BugzillaTest.test_parse_bug_id_from_changelog): Updated expected results for test
217         progression, and added a new test that uses a short bug URL while I was at it.
218
219 2011-04-01  Adam Roben  <aroben@apple.com>
220
221         Mark .vcproj/.vsprops/.sln files as being Windows-only
222
223         Fixes <http://webkit.org/b/57489> Mac builders built 82512, but shouldn't have
224
225         Reviewed by Anders Carlsson.
226
227         * Scripts/webkitpy/common/config/build.py:
228         (_should_file_trigger_build): Added patterns to mark .vcproj/.vsprops/.sln files and .vcproj
229         directories as Windows-only.
230
231         * Scripts/webkitpy/common/config/build_unittest.py:
232         (ShoulBuildTest): Added test cases for the above.
233
234 2011-04-01  Keith Kyzivat  <keith.kyzivat@nokia.com>
235
236         Reviewed by Laszlo Gombos.
237
238         [Qt] Build MiniBrowser for Symbian
239         https://bugs.webkit.org/show_bug.cgi?id=56319
240
241         Have MiniBrowser reference it's own copy of useragentlist.txt instead
242         of copying QtTestBrowser's.
243         Remove Tools/MiniBrowser/DerivedSources.pro
244         This reduces complexity in the Tools scripts due to Symbian limitations.
245
246         * DerivedSources.pro:
247         * MiniBrowser/DerivedSources.pro: Removed.
248         * MiniBrowser/MiniBrowser.qrc:
249         * MiniBrowser/qt/MiniBrowser.pro:
250         * Scripts/webkitdirs.pm:
251
252 2011-03-31  Chang Shu  <cshu@webkit.org>
253
254         Reviewed by Darin Adler.
255
256         WebKitTestRunner needs layoutTestController.clearAllDatabases
257         https://bugs.webkit.org/show_bug.cgi?id=42540
258
259         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
260         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
261         (WTR::InjectedBundle::beginTesting):
262         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
263         (WTR::LayoutTestController::clearAllDatabases):
264         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
265
266 2011-03-31  Chang Shu  <cshu@webkit.org>
267
268         Reviewed by Darin Adler.
269
270         WebKitTestRunner needs layoutTestController.setAllowUniversalAccessFromFileURLs
271         https://bugs.webkit.org/show_bug.cgi?id=42692
272
273         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
274
275 2011-03-31  Darin Adler  <darin@apple.com>
276
277         Reviewed by Sam Weinig.
278
279         Implement mouseDown, mouseUp, and mouseMoveTo in WebKitTestRunner
280         https://bugs.webkit.org/show_bug.cgi?id=57573
281
282         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
283         Added real definitions for mouseDown, mouseUp, mouseMoveTo and leapForward.
284         Removed fake definitions of keyDown and contextClick.
285
286         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
287         (WTR::operator==): Added. So we can compare two WKPoint structs.
288         (WTR::parseModifier): Added.
289         (WTR::parseModifierArray): Added.
290         (WTR::EventSendingController::EventSendingController): Initialize the
291         new data members.
292         (WTR::EventSendingController::mouseDown): Added. Calls
293         WKBundlePageSimulateMouseDown.
294         (WTR::EventSendingController::mouseUp): Added. Calls
295         WKBundlePageSimulateMouseUp.
296         (WTR::EventSendingController::mouseMoveTo): Added. Calls
297         WKBundlePageSimulateMouseMotion.
298         (WTR::EventSendingController::leapForward): Added.
299         (WTR::EventSendingController::updateClickCount): Added. Used by the
300         mouseDown/Up functions to create a click count.
301
302         * WebKitTestRunner/InjectedBundle/EventSendingController.h: Updated
303         for the changes above.
304
305 2011-03-31  Sergio Villar Senin  <svillar@igalia.com>
306
307         Reviewed by Martin Robinson.
308
309         [GTK] implement LayoutTestController::setWillSendRequestReturnsNull
310         https://bugs.webkit.org/show_bug.cgi?id=57362
311
312         Do not generate DRT output if willSendRequestReturnsNull is set.
313
314         * DumpRenderTree/gtk/DumpRenderTree.cpp:
315         (willSendRequestCallback):
316
317 2011-03-31  Vamshikrishna.Yellenki  <vamshi@motorola.com> and Alejandro G. Castro  <alex@igalia.com>
318
319         Reviewed by Martin Robinson.
320
321         Implement MiniBrowser for Gtk port.
322         https://bugs.webkit.org/show_bug.cgi?id=48512
323
324         Initial implementation of the Gtk MiniBrowser.
325
326         * MiniBrowser/gtk/GNUmakefile.am: Added.
327         * MiniBrowser/gtk/main.c: Added.
328         (activateUriEntryCallback):
329         (destroyCallback):
330         (goBackCallback):
331         (goForwardCallback):
332         (createToolbar):
333         (createWebView):
334         (createWindow):
335         (argumentToURL):
336         (main):
337
338 2011-03-30  Dominic Cooney  <dominicc@google.com>
339
340         Reviewed by Dimitri Glazkov.
341
342         Adds layoutTestController.shadowRoot accessor to Mac DRT.
343         https://bugs.webkit.org/show_bug.cgi?id=57415
344
345         * DumpRenderTree/LayoutTestController.cpp:
346         (shadowRootCallback):
347         (LayoutTestController::staticFunctions):
348         * DumpRenderTree/LayoutTestController.h:
349         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
350         (LayoutTestController::shadowRoot):
351         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
352         (LayoutTestController::shadowRoot):
353
354 2011-03-30  Matthew Delaney  <mdelaney@apple.com>
355
356         Reviewed by Chris Marrin.
357
358         Update fast/canvas tests to avoid dumping the render tree when possible
359         https://bugs.webkit.org/show_bug.cgi?id=57493
360
361         * DumpRenderTree/mac/DumpRenderTree.mm: Make DRT aware of new default values for
362           accelerated drawing and accelerated drawing for canvas
363
364 2011-03-30  Adam Roben  <aroben@apple.com>
365
366         Stop ignoring leaks in CGGradientCreateWithColorStops
367
368         Fixes <rdar://problem/7888547>.
369
370         Rubber-stamped by John Sullivan.
371
372         * Scripts/old-run-webkit-tests:
373         (countAndPrintLeaks): Removed some code to ignore those leaks.
374
375 2011-03-30  Timur Iskhodzhanov  <timurrrr@google.com>
376
377         Reviewed by Alexey Proskuryakov.
378
379         Add some dynamic annotations to JavaScriptCore/wtf
380         https://bugs.webkit.org/show_bug.cgi?id=53747
381
382         By using these annotations we can improve the precision of finding
383         WebKit errors using dynamic analysis tools like ThreadSanitizer and Valgrind.
384         These annotations don't affect the compiled binaries unless USE(DYNAMIC_ANNOTATIONS) is "1".
385
386         These files don't add new functionality, so don't need extra tests.
387
388         * DumpRenderTree/ForwardingHeaders/wtf/DynamicAnnotations.h: Added.
389
390 2011-03-30  Steve Falkenburg  <sfalken@apple.com>
391
392         Reviewed by Adam Roben.
393
394         Share most vsprops between Release and Production builds in releaseproduction.vsprops
395         https://bugs.webkit.org/show_bug.cgi?id=57508
396
397         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops:
398         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops:
399         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops:
400         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops:
401         * DumpRenderTree/win/DumpRenderTreeRelease.vsprops:
402         * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops:
403         * DumpRenderTree/win/ImageDiffProduction.vsprops:
404         * DumpRenderTree/win/ImageDiffRelease.vsprops:
405         * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops:
406         * FindSafari/FindSafariProduction.vsprops:
407         * FindSafari/FindSafariRelease.vsprops:
408         * FindSafari/FindSafariReleaseCairoCFLite.vsprops:
409         * FindSafari/FindSafariReleasePGO.vsprops:
410         * MiniBrowser/Configurations/MiniBrowserProduction.vsprops:
411         * MiniBrowser/Configurations/MiniBrowserRelease.vsprops:
412         * MiniBrowser/Configurations/MiniBrowserReleaseCairoCFLite.vsprops:
413         * TestWebKitAPI/Configurations/TestWebKitAPIRelease.vsprops:
414         * TestWebKitAPI/Configurations/TestWebKitAPIReleaseCairoCFLite.vsprops:
415         * WebKitAPITest/WebKitAPITestProduction.vsprops:
416         * WebKitAPITest/WebKitAPITestRelease.vsprops:
417         * WebKitAPITest/WebKitAPITestReleaseCairoCFLite.vsprops:
418         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops:
419         * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops:
420         * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops:
421         * WebKitTestRunner/win/InjectedBundleProduction.vsprops:
422         * WebKitTestRunner/win/InjectedBundleRelease.vsprops:
423         * WebKitTestRunner/win/InjectedBundleReleaseCairoCFLite.vsprops:
424         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops:
425         * WebKitTestRunner/win/WebKitTestRunnerRelease.vsprops:
426         * WebKitTestRunner/win/WebKitTestRunnerReleaseCairoCFLite.vsprops:
427         * WinLauncher/WinLauncherProduction.vsprops:
428         * WinLauncher/WinLauncherRelease.vsprops:
429         * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops:
430         * record-memory-win/record-memory-winProduction.vsprops:
431         * record-memory-win/record-memory-winRelease.vsprops:
432         * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops:
433
434 2011-03-30  Steve Falkenburg  <sfalken@apple.com>
435
436         Reviewed by Adam Roben.
437
438         Update Windows production build logic for new production configurations
439         https://bugs.webkit.org/show_bug.cgi?id=57494
440
441         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops:
442         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops:
443         * DumpRenderTree/win/ImageDiffProduction.vsprops:
444         * FindSafari/FindSafariProduction.vsprops:
445         * FindSafari/FindSafariReleasePGO.vsprops:
446         * MiniBrowser/Configurations/MiniBrowserProduction.vsprops:
447         * WebKitAPITest/WebKitAPITestProduction.vsprops:
448         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops:
449         * WebKitTestRunner/win/InjectedBundleProduction.vsprops:
450         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops:
451         * WinLauncher/WinLauncherProduction.vsprops:
452         * record-memory-win/record-memory-winProduction.vsprops:
453
454 2011-03-30  Robert Hogan  <robert@webkit.org>
455
456         Reviewed by Antonio Gomes.
457
458         [Qt] Fix LoadHTMLStringItem::invoke() after r75966
459         Unskip http/tests/navigation/go-back-to-error-page.html
460
461         Also add the location of DumpRenderTreeSupportQt.h
462         to DRT's include paths.
463
464         https://bugs.webkit.org/show_bug.cgi?id=52614
465
466         * DumpRenderTree/qt/DumpRenderTree.pro:
467         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
468         * DumpRenderTree/qt/DumpRenderTreeQt.h:
469         * DumpRenderTree/qt/GCControllerQt.cpp:
470         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
471         (LayoutTestController::queueLoadHTMLString):
472         * DumpRenderTree/qt/LayoutTestControllerQt.h:
473         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
474         * DumpRenderTree/qt/TextInputControllerQt.cpp:
475         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
476         (LoadAlternateHTMLStringItem::invoke):
477         * DumpRenderTree/qt/WorkQueueItemQt.h:
478         (LoadAlternateHTMLStringItem::LoadAlternateHTMLStringItem):
479         * QtTestBrowser/QtTestBrowser.pro:
480         * QtTestBrowser/launcherwindow.h:
481
482 2011-03-30  Adam Barth  <abarth@webkit.org>
483
484         Reviewed by Adam Roben.
485
486         SheriffBot rollouts take too long
487         https://bugs.webkit.org/show_bug.cgi?id=57498
488
489         We used to build before landing rollouts via the commit-queue to
490         prevent further breakage, but now that our individual commit-queue
491         machines are slower, building takes too long.  I can't remember the
492         last time a rollout broke compile.  It seems like just landing the
493         patch is the better trade-off.
494
495         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
496         * Scripts/webkitpy/tool/commands/queues_unittest.py:
497
498 2011-03-30  Adam Barth  <abarth@webkit.org>
499
500         Remove platform/chromium-mac-snowleopard
501         https://bugs.webkit.org/show_bug.cgi?id=57486
502
503         This directory no longer exists, so we can remove it from the fallback
504         chain.
505
506         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
507
508 2011-03-30  Steve Falkenburg  <sfalken@apple.com>
509
510         Reviewed by Adam Roben.
511
512         Rename Windows configuration Release_LTCG to Production for clarity
513         https://bugs.webkit.org/show_bug.cgi?id=57465
514
515         * DumpRenderTree/DumpRenderTree.sln:
516         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
517         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops: Copied from Tools/DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops.
518         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops: Removed.
519         * DumpRenderTree/win/DumpRenderTree.vcproj:
520         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops: Copied from Tools/DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops.
521         * DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops: Removed.
522         * DumpRenderTree/win/ImageDiff.vcproj:
523         * DumpRenderTree/win/ImageDiffProduction.vsprops: Copied from Tools/DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops.
524         * DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops: Removed.
525         * FindSafari/FindSafari.vcproj:
526         * FindSafari/FindSafariProduction.vsprops: Copied from Tools/FindSafari/FindSafariReleaseLTCG.vsprops.
527         * FindSafari/FindSafariReleaseLTCG.vsprops: Removed.
528         * MiniBrowser/Configurations/MiniBrowserProduction.vsprops: Copied from Tools/MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops.
529         * MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops: Removed.
530         * MiniBrowser/MiniBrowser.vcproj:
531         * Scripts/webkitdirs.pm:
532         * TestWebKitAPI/win/TestWebKitAPI.sln:
533         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
534         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
535         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
536         * WebKitAPITest/WebKitAPITest.vcproj:
537         * WebKitAPITest/WebKitAPITestProduction.vsprops: Copied from Tools/WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops.
538         * WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops: Removed.
539         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
540         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops: Copied from Tools/WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops.
541         * WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops: Removed.
542         * WebKitTestRunner/WebKitTestRunner.sln:
543         * WebKitTestRunner/win/InjectedBundle.vcproj:
544         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj:
545         * WebKitTestRunner/win/InjectedBundleProduction.vsprops: Copied from Tools/WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops.
546         * WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops: Removed.
547         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
548         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops: Copied from Tools/WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops.
549         * WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops: Removed.
550         * WinLauncher/WinLauncher.vcproj:
551         * WinLauncher/WinLauncherProduction.vsprops: Copied from Tools/WinLauncher/WinLauncherReleaseLTCG.vsprops.
552         * WinLauncher/WinLauncherReleaseLTCG.vsprops: Removed.
553         * record-memory-win/record-memory-win.vcproj:
554         * record-memory-win/record-memory-winProduction.vsprops: Copied from Tools/record-memory-win/record-memory-winReleaseLTCG.vsprops.
555         * record-memory-win/record-memory-winReleaseLTCG.vsprops: Removed.
556
557 2011-03-30  MORITA Hajime  <morrita@google.com>
558
559         Reviewed by Dimitri Glazkov.
560
561         [Chromium] Expose the shadow DOM to DumpRenderTree JS tests.
562         https://bugs.webkit.org/show_bug.cgi?id=56573
563
564         Added LayoutTestController.shadowRoot() to Chromium DRT.
565
566         * DumpRenderTree/chromium/LayoutTestController.cpp:
567         (LayoutTestController::LayoutTestController):
568         (LayoutTestController::shadowRoot):
569         * DumpRenderTree/chromium/LayoutTestController.h:
570
571 2011-03-30  Yuta Kitamura  <yutak@chromium.org>
572
573         Reviewed by Kent Tamura.
574
575         [Chromium] DumpRenderTree: Implement LayoutTestController::setPluginsEnabled
576         https://bugs.webkit.org/show_bug.cgi?id=57430
577
578         * DumpRenderTree/chromium/LayoutTestController.cpp:
579         (LayoutTestController::LayoutTestController):
580         (LayoutTestController::setPluginsEnabled):
581         * DumpRenderTree/chromium/LayoutTestController.h:
582
583 2011-03-30  Maciej Stachowiak  <mjs@apple.com>
584
585         Reviewed by Adam Barth.
586
587         make webkit-patch upload respect -d
588         https://bugs.webkit.org/show_bug.cgi?id=57425
589
590         * Scripts/webkitpy/common/checkout/scm.py:
591         * Scripts/webkitpy/tool/steps/commit.py:
592
593 2011-03-30  Maciej Stachowiak  <mjs@apple.com>
594
595         Reviewed by Adam Barth.
596
597         Make "webkit-patch --dry-run --verbose land" log the SVN command it's going to use
598         https://bugs.webkit.org/show_bug.cgi?id=57429
599
600         * Scripts/webkitpy/common/checkout/scm.py:
601
602 2011-03-29  Sheriff Bot  <webkit.review.bot@gmail.com>
603
604         Unreviewed, rolling out r82383.
605         http://trac.webkit.org/changeset/82383
606         https://bugs.webkit.org/show_bug.cgi?id=57417
607
608         "nrwt isn't shutting down cleanly" (Requested by dpranke on
609         #webkit).
610
611         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
612         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
613         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
614
615 2011-03-29  Kent Tamura  <tkent@chromium.org>
616
617         Reviewed by Dimitri Glazkov.
618
619         Make validation message bubble testable
620         https://bugs.webkit.org/show_bug.cgi?id=57290
621
622         * DumpRenderTree/mac/DumpRenderTree.mm:
623         (createWebViewAndOffscreenWindow): Change a setting so that validation
624           bubbles isn't hidden automatically.
625
626 2011-03-29  Dirk Pranke  <dpranke@chromium.org>
627
628         Reviewed by Ojan Vafai.
629
630         new-run-webkit-tests: use 'threads' on win instead of 'old-threads'
631
632         It's a bit unclear whether multiple threads or multiple
633         processes will be a better model on windows. This change will
634         test threads for now while we're still working out the bugs in
635         multiple-processes.
636
637         https://bugs.webkit.org/show_bug.cgi?id=57410
638
639         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
640         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
641         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
642
643 2011-03-29  David Levin  <levin@chromium.org>
644
645         Reviewed by Shinichiro Hamaji.
646
647         check-webkit-style confused by two ChangeLog entries in a row from same user
648         https://bugs.webkit.org/show_bug.cgi?id=57250
649
650         * Scripts/webkitpy/style/checker.py: Add the line should be checked function to ChangeLogChecker.
651         * Scripts/webkitpy/style/checker_unittest.py: Fix test due to that new function.
652         * Scripts/webkitpy/style/checkers/changelog.py: Made this code aware of what lines were being checked.
653           It basically assumes only one ChangeLog entry is being processed because that is the standard case and
654           checking more than that would be very messey.
655         * Scripts/webkitpy/style/checkers/changelog_unittest.py: Add testing to catch the broken case.
656         * Scripts/webkitpy/style/error_handlers.py: Added should_line_be_checked.
657
658 2011-03-29  Kent Tamura  <tkent@chromium.org>
659
660         Reviewed by Dimitri Glazkov.
661
662         [Mac] Enable interactive-validation tests on Mac DRT
663         https://bugs.webkit.org/show_bug.cgi?id=57308
664
665         * DumpRenderTree/mac/DumpRenderTree.mm:
666         (createWebViewAndOffscreenWindow): Enable the form interactive validation feature.
667
668 2011-03-29  Chang Shu  <cshu@webkit.org>
669
670         Reviewed by Kenneth Rohde Christiansen.
671
672         WebKitTestRunner needs layoutTestController.setAllowUniversalAccessFromFileURLs
673         https://bugs.webkit.org/show_bug.cgi?id=42692
674
675         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
676         (WTR::InjectedBundle::beginTesting):
677         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
678         (WTR::LayoutTestController::setAllowUniversalAccessFromFileURLs):
679         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
680
681 2011-03-24  Martin Robinson  <mrobinson@igalia.com>
682
683         Reviewed by Xan Lopez.
684
685         [GTK] [DRT] GtkScrolledWindow adds three pixels of padding between the WebView and the scrollbar
686         https://bugs.webkit.org/show_bug.cgi?id=57067
687
688         Eliminate extra spacing between the DRT GtkScrolledWindow and the DRT WebView. This
689         will allow WebKit1GTK+ and WebKit2GTK+ to share test results. Followup commits will
690         update DRT and pixel results as hundreds of results will need to be updated.
691
692         * DumpRenderTree/gtk/DumpRenderTree.cpp:
693         (setDefaultsToConsistentStateValuesForTesting): Eliminate spacing on the GtkScrolledWindow
694         by overriding the theme RC/CSS files.
695
696 2011-03-29  Steve Falkenburg  <sfalken@apple.com>
697
698         Reviewed by Adam Roben.
699
700         Use per-configuration vsprops in tools projects to avoid WebKitVSPropsRedirectionDir removal by MSVC IDE
701         https://bugs.webkit.org/show_bug.cgi?id=57394
702
703         Visual Studio's IDE was removing instances of $(WebKitVSPropsRedirectionDir) from
704         InheritedPropertySheet rules in our vcproj files when the vcproj was edited from within
705         the IDE. To avoid this, add a separate vsprops file for each project configuration that
706         contains the required inherited property sheets.
707
708         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
709         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebug.vsprops: Added.
710         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugAll.vsprops: Added.
711         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugCairoCFLite.vsprops: Added.
712         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops: Added.
713         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops: Added.
714         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops: Added.
715         * DumpRenderTree/win/DumpRenderTree.vcproj:
716         * DumpRenderTree/win/DumpRenderTreeDebug.vsprops: Added.
717         * DumpRenderTree/win/DumpRenderTreeDebugAll.vsprops: Added.
718         * DumpRenderTree/win/DumpRenderTreeDebugCairoCFLite.vsprops: Added.
719         * DumpRenderTree/win/DumpRenderTreeRelease.vsprops: Added.
720         * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops: Added.
721         * DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops: Added.
722         * DumpRenderTree/win/ImageDiff.vcproj:
723         * DumpRenderTree/win/ImageDiffDebug.vsprops: Added.
724         * DumpRenderTree/win/ImageDiffDebugAll.vsprops: Added.
725         * DumpRenderTree/win/ImageDiffDebugCairoCFLite.vsprops: Added.
726         * DumpRenderTree/win/ImageDiffRelease.vsprops: Added.
727         * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops: Added.
728         * DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops: Added.
729         * FindSafari/FindSafari.vcproj:
730         * FindSafari/FindSafariDebug.vsprops: Added.
731         * FindSafari/FindSafariDebugAll.vsprops: Added.
732         * FindSafari/FindSafariDebugCairoCFLite.vsprops: Added.
733         * FindSafari/FindSafariRelease.vsprops: Added.
734         * FindSafari/FindSafariReleaseCairoCFLite.vsprops: Added.
735         * FindSafari/FindSafariReleaseLTCG.vsprops: Added.
736         * FindSafari/FindSafariReleasePGO.vsprops: Added.
737         * MiniBrowser/Configurations/MiniBrowserDebug.vsprops: Added.
738         * MiniBrowser/Configurations/MiniBrowserDebugAll.vsprops: Added.
739         * MiniBrowser/Configurations/MiniBrowserDebugCairoCFLite.vsprops: Added.
740         * MiniBrowser/Configurations/MiniBrowserRelease.vsprops: Added.
741         * MiniBrowser/Configurations/MiniBrowserReleaseCairoCFLite.vsprops: Added.
742         * MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops: Added.
743         * MiniBrowser/MiniBrowser.vcproj:
744         * WebKitAPITest/WebKitAPITest.vcproj:
745         * WebKitAPITest/WebKitAPITestDebug.vsprops: Added.
746         * WebKitAPITest/WebKitAPITestDebugAll.vsprops: Added.
747         * WebKitAPITest/WebKitAPITestDebugCairoCFLite.vsprops: Added.
748         * WebKitAPITest/WebKitAPITestRelease.vsprops: Added.
749         * WebKitAPITest/WebKitAPITestReleaseCairoCFLite.vsprops: Added.
750         * WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops: Added.
751         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
752         * WebKitLauncherWin/WebKitLauncherWinDebug.vsprops: Added.
753         * WebKitLauncherWin/WebKitLauncherWinDebugAll.vsprops: Added.
754         * WebKitLauncherWin/WebKitLauncherWinDebugCairoCFLite.vsprops: Added.
755         * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops: Added.
756         * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops: Added.
757         * WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops: Added.
758         * WebKitTestRunner/win/InjectedBundle.vcproj:
759         * WebKitTestRunner/win/InjectedBundleDebug.vsprops: Added.
760         * WebKitTestRunner/win/InjectedBundleDebugAll.vsprops: Added.
761         * WebKitTestRunner/win/InjectedBundleDebugCairoCFLite.vsprops: Added.
762         * WebKitTestRunner/win/InjectedBundleRelease.vsprops: Added.
763         * WebKitTestRunner/win/InjectedBundleReleaseCairoCFLite.vsprops: Added.
764         * WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops: Added.
765         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
766         * WebKitTestRunner/win/WebKitTestRunnerDebug.vsprops: Added.
767         * WebKitTestRunner/win/WebKitTestRunnerDebugAll.vsprops: Added.
768         * WebKitTestRunner/win/WebKitTestRunnerDebugCairoCFLite.vsprops: Added.
769         * WebKitTestRunner/win/WebKitTestRunnerRelease.vsprops: Added.
770         * WebKitTestRunner/win/WebKitTestRunnerReleaseCairoCFLite.vsprops: Added.
771         * WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops: Added.
772         * WinLauncher/WinLauncher.vcproj:
773         * WinLauncher/WinLauncherDebug.vsprops: Added.
774         * WinLauncher/WinLauncherDebugAll.vsprops: Added.
775         * WinLauncher/WinLauncherDebugCairoCFLite.vsprops: Added.
776         * WinLauncher/WinLauncherRelease.vsprops: Added.
777         * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops: Added.
778         * WinLauncher/WinLauncherReleaseLTCG.vsprops: Added.
779         * record-memory-win/record-memory-win.vcproj:
780         * record-memory-win/record-memory-winDebug.vsprops: Added.
781         * record-memory-win/record-memory-winDebugAll.vsprops: Added.
782         * record-memory-win/record-memory-winDebugCairoCFLite.vsprops: Added.
783         * record-memory-win/record-memory-winRelease.vsprops: Added.
784         * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops: Added.
785         * record-memory-win/record-memory-winReleaseLTCG.vsprops: Added.
786
787 2011-03-29  Adam Barth  <abarth@webkit.org>
788
789         Reviewed by Darin Adler.
790
791         test_runner2.py can crash due to undefined variable
792         https://bugs.webkit.org/show_bug.cgi?id=57356
793
794         Replace reference to undefined variable with a variable that's actually
795         defined.  AFAICT, there's no way to test this code.
796
797         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
798
799 2011-03-29  Tony Chang  <tony@chromium.org>
800
801         Reviewed by Eric Seidel.
802
803         cleanup rebaseline-chromium-webkit-tests
804         https://bugs.webkit.org/show_bug.cgi?id=57375
805
806         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
807             - Split _extract_and_add_new_baselines into 3 functions
808             - Reduce the amount of line wrapping (the file already has lines
809               over 80 col, so may as well try to make the file consistent)
810             - Remove unnecessary ()s
811
812 2011-03-29  Brent Fulgham  <bfulgham@webkit.org>
813
814         Reviewed by Adam Roben.
815
816         Make WinCairo a core builder.
817         https://bugs.webkit.org/show_bug.cgi?id=57373
818
819         * Scripts/webkitpy/common/net/buildbot/buildbot.py: Add WinCairo.
820         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: Add WinCairo.
821
822 2011-03-29  Timothy Hatcher  <timothy@apple.com>
823
824         Update update-webkit-localizable-strings to understand that WebKit and
825         WebKit2 strings go in WebCore.
826
827         Also make extract-localizable-strings optionally use an exclude file. No individual
828         warnings are produced about unlocalized strings when there is no exclude file. This
829         is needed for WebCore, since there are too many bare strings.
830
831         https://webkit.org/b/57354
832
833         Reviewed by Sam Weinig.
834
835         * Scripts/extract-localizable-strings: Support "-" to mean no exclude file.
836         * Scripts/update-webkit-localizable-strings: Update paths to scan WebCore and WebKit2.
837
838 2011-03-29  Darin Adler  <darin@apple.com>
839
840         Reviewed by Adam Roben.
841
842         WebKit2 bundle page needs to offer generated file hooks
843         https://bugs.webkit.org/show_bug.cgi?id=57279
844
845         (Land missing part of the original patch after r82289.)
846
847         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
848         (WTR::InjectedBundlePage::InjectedBundlePage): Added new callbacks.
849
850 2011-03-29  Tony Chang  <tony@chromium.org>
851
852         Reviewed by Ojan Vafai.
853
854         [chromium] NRWT should be able to read checksums from png comments
855         https://bugs.webkit.org/show_bug.cgi?id=57280
856
857         * Scripts/read-checksum-from-png: Added. Utility script to read the checksum
858             from a file.
859         * Scripts/webkitpy/common/system/filesystem.py: Add open_binary_file_for_reading
860         * Scripts/webkitpy/common/system/filesystem_mock.py:
861         * Scripts/webkitpy/layout_tests/port/base.py: When loading a checksum,
862             if the -checksum.txt file doesn't exist, try looking in the png.
863         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
864         * Scripts/webkitpy/layout_tests/port/test.py:
865         * Scripts/webkitpy/layout_tests/read_checksum_from_png.py: Added. Scan the first
866             2k for a png comment with the checksum
867         * Scripts/webkitpy/layout_tests/read_checksum_from_png_unittest.py: Added.
868
869 2011-03-29  Philippe Normand  <pnormand@igalia.com>
870
871         Rubber-stamped by Gustavo Noronha Silva.
872
873         [GTK] http/tests/uri/username-with-no-hostname.html fails
874         https://bugs.webkit.org/show_bug.cgi?id=57325
875
876         * DumpRenderTree/gtk/DumpRenderTree.cpp:
877         (willSendRequestCallback): URI host value check done case-insensitively.
878
879 2011-03-29  Philippe Normand  <pnormand@igalia.com>
880
881         Reviewed by Martin Robinson.
882
883         [GTK] http/tests/uri/username-with-no-hostname.html fails
884         https://bugs.webkit.org/show_bug.cgi?id=57325
885
886         * DumpRenderTree/gtk/DumpRenderTree.cpp:
887         (willSendRequestCallback): Check URI before submitting the request
888         to WebCore.
889
890 2011-03-29  Noel Gordon  <noel.gordon@gmail.com>
891
892         Reviewed by Ojan Vafai.
893
894         [chromium] DRT EventSender: remove identity from dragTargetDragEnter() calls
895         https://bugs.webkit.org/show_bug.cgi?id=57303
896
897         * DumpRenderTree/chromium/EventSender.cpp:
898         (EventSender::doDragDrop):
899         (EventSender::beginDragWithFiles):
900
901 2011-03-29  Zoltan Horvath  <zoltan@webkit.org>
902
903         Reviewed by Andreas Kling.
904
905         [Qt] Add -print-loaded-urls option to Qt's MiniBrowser and to QtTestBrowser
906         https://bugs.webkit.org/show_bug.cgi?id=57314
907
908         Provide possibility to print loaded urls to the standard output.
909
910         * MiniBrowser/qt/BrowserWindow.cpp:
911         (BrowserWindow::BrowserWindow):
912         (BrowserWindow::printURL):
913         * MiniBrowser/qt/BrowserWindow.h:
914         * MiniBrowser/qt/MiniBrowserApplication.cpp:
915         (MiniBrowserApplication::handleUserOptions):
916         * MiniBrowser/qt/MiniBrowserApplication.h:
917         (WindowOptions::WindowOptions):
918         * QtTestBrowser/launcherwindow.cpp:
919         (LauncherWindow::initializeView):
920         (LauncherWindow::printURL):
921         (LauncherWindow::cloneWindow):
922         * QtTestBrowser/launcherwindow.h:
923         (WindowOptions::WindowOptions):
924         * QtTestBrowser/main.cpp:
925         (LauncherApplication::handleUserOptions):
926
927 2011-03-29  Gabor Loki  <loki@webkit.org>
928
929         Rubber-stamped by Csaba Osztrogonác.
930
931         [Qt] Teach build-jsc how to build JavaScriptCore on Qt
932         https://bugs.webkit.org/show_bug.cgi?id=56918
933
934         * Scripts/build-jsc: Remove duplicated --qt options to avoid passing them to qmake.
935
936 2011-03-28  Gabor Loki  <loki@webkit.org>
937
938         Reviewed by Csaba Osztrogonác.
939
940         [Qt] Teach build-jsc how to build JavaScriptCore on Qt
941         https://bugs.webkit.org/show_bug.cgi?id=56918
942
943         * Scripts/build-jsc:
944         * Scripts/webkitdirs.pm:
945
946 2011-03-28  Andrew Foster  <andrewf@chromium.org>
947
948         Reviewed by Ojan Vafai.
949
950         webkit-patch should be more intelligent about whether a bug applies to a patch
951         Create a new function, parse_bug_id_from_changelog() which determines
952         that a bug is related to a patch by parsing the output generated from
953         prepare-ChangeLog, rather than arbitrarily matching a URL to a bug in
954         the description of a patch.
955         https://bugs.webkit.org/show_bug.cgi?id=56989
956
957         * Scripts/webkitpy/common/checkout/api.py:
958         * Scripts/webkitpy/common/checkout/changelog.py:
959         * Scripts/webkitpy/common/net/bugzilla/__init__.py:
960         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
961         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
962         * Scripts/webkitpy/style/checkers/changelog.py:
963         * Scripts/webkitpy/tool/commands/upload.py:
964
965 2011-03-28  Maciej Stachowiak  <mjs@apple.com>
966
967         Revert accidentally commited change.
968
969         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
970         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
971
972 2011-03-28  Tony Chang  <tony@chromium.org>
973
974         Reviewed by Adam Barth.
975
976         [chromium] have DRT write the png checksum into a png comment
977         https://bugs.webkit.org/show_bug.cgi?id=57255
978
979         * DumpRenderTree/chromium/TestShell.cpp:
980         (TestShell::dumpImage):
981
982 2011-03-28  Adele Peterson  <adele@apple.com>
983
984         Removing Qt stub, since it doesn't use the same header as the others.
985
986         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
987
988 2011-03-28  Adele Peterson  <adele@apple.com>
989
990         Added a few more stubs.
991
992         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
993         (LayoutTestController::hasGrammarMarker):
994         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
995         (LayoutTestController::hasGrammarMarker):
996         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
997         (LayoutTestController::hasGrammarMarker):
998
999 2011-03-28  Adele Peterson  <adele@apple.com>
1000
1001         Build fix.
1002
1003         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1004         (LayoutTestController::hasGrammarMarker):
1005
1006 2011-03-28  Adele Peterson  <adele@apple.com>
1007
1008         Reviewed by Eric Seidel.
1009
1010         Testing support for <rdar://problem/9112694> REGRESSION (r79411): "Check grammar with spelling" context menu doesn't check as you type
1011         https://bugs.webkit.org/show_bug.cgi?id=57173
1012
1013         * DumpRenderTree/LayoutTestController.cpp:
1014         (hasGrammarMarkerCallback): Added.
1015         (LayoutTestController::staticFunctions): Added case for hasGrammarMarker.
1016         * DumpRenderTree/LayoutTestController.h:
1017         * DumpRenderTree/mac/DumpRenderTree.mm: (createWebViewAndOffscreenWindow): Call setGrammarCheckingEnabled.
1018         * DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::hasGrammarMarker): Added. Call new hasGrammarMarker method.
1019
1020 2011-03-28  Csaba Osztrogonác  <ossy@webkit.org>
1021
1022         Reviewed by Benjamin Poulain.
1023
1024         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
1025         https://bugs.webkit.org/show_bug.cgi?id=57087
1026
1027         Trivial typo fix after r82082.
1028
1029         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1030         (WTR::activateFonts):
1031
1032 2011-03-28  Alexis Menard  <alexis.menard@openbossa.org>
1033
1034         Reviewed by Andreas Kling.
1035
1036         Add myself to the committers list.
1037
1038         * Scripts/webkitpy/common/config/committers.py:
1039
1040 2011-03-28  Simon Fraser  <simon.fraser@apple.com>
1041
1042         Reviewed by Sam Weinig.
1043
1044         WebKit2 unfortunately uses code from WebKit, so MiniBrowser needs
1045         to link against WebKit.framework for now.
1046
1047         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1048
1049 2011-03-28  Benjamin Poulain  <benjamin.poulain@nokia.com>
1050
1051         Reviewed by Andreas Kling.
1052
1053         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
1054         https://bugs.webkit.org/show_bug.cgi?id=57087
1055
1056         Disable QT_ASCII_CAST_WARNINGS for applications.
1057
1058         * DumpRenderTree/qt/DumpRenderTree.pro:
1059         * DumpRenderTree/qt/ImageDiff.pro:
1060         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1061         * MiniBrowser/qt/MiniBrowser.pro:
1062         * QtTestBrowser/QtTestBrowser.pro:
1063         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1064
1065 2011-03-28  Andreas Kling  <kling@webkit.org>
1066
1067         Reviewed by Kenneth Rohde Christiansen.
1068
1069         [Qt] QtTestBrowser doesn't reset its window title when opening about:blank
1070         https://bugs.webkit.org/show_bug.cgi?id=57224
1071
1072         * QtTestBrowser/mainwindow.cpp:
1073         (MainWindow::buildUI):
1074         (MainWindow::onTitleChanged):
1075         * QtTestBrowser/mainwindow.h:
1076
1077 2011-03-27  Jer Noble  <jer.noble@apple.com>
1078
1079         Reviewed by Maciej Stachowiak.
1080
1081         Full Screen: disable keyboard access by default
1082         https://bugs.webkit.org/show_bug.cgi?id=56684
1083
1084         Accept the withKeyboard parameter to supportsFullScreenForElement.
1085
1086         * DumpRenderTree/mac/UIDelegate.mm:
1087         (-[UIDelegate webView:supportsFullScreenForElement:withKeyboard:]):
1088
1089 2011-03-27  Patrick Gansterer  <paroga@webkit.org>
1090
1091         Reviewed by David Levin.
1092
1093         check-webkit-style should check ChangeLog for a valid bug number
1094         https://bugs.webkit.org/show_bug.cgi?id=57184
1095
1096         * Scripts/webkitpy/style/checker.py:
1097         * Scripts/webkitpy/style/checker_unittest.py:
1098         * Scripts/webkitpy/style/checkers/changelog.py: Added.
1099         * Scripts/webkitpy/style/checkers/changelog_unittest.py: Added.
1100
1101 2011-03-27  Benjamin Poulain  <benjamin.poulain@nokia.com>
1102
1103         Reviewed by Andreas Kling.
1104
1105         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
1106         https://bugs.webkit.org/show_bug.cgi?id=57087
1107
1108         Use explicit conversion for string to avoid depending on the default codec
1109         installed by the user code.
1110
1111         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1112         (WTR::activateFonts):
1113
1114 2011-03-26  Maciej Stachowiak  <mjs@apple.com>
1115
1116         Revert inadvertantly committed changes.
1117
1118         * Scripts/old-run-webkit-tests:
1119         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1120
1121 2011-03-26  Andreas Kling  <kling@webkit.org>
1122
1123         Reviewed by Kenneth Rohde Christiansen.
1124
1125         [Qt] Show page icons (favicons) in QtTestBrowser location bar.
1126         https://bugs.webkit.org/show_bug.cgi?id=57162
1127
1128         * QtTestBrowser/QtTestBrowser.qrc:
1129         * QtTestBrowser/favicon.png: Added.
1130         * QtTestBrowser/locationedit.cpp:
1131         (defaultPageIcon):
1132         (LocationEdit::LocationEdit):
1133         (LocationEdit::setPageIcon):
1134         (LocationEdit::resizeEvent):
1135         (LocationEdit::updateInternalGeometry):
1136         * QtTestBrowser/locationedit.h:
1137         * QtTestBrowser/mainwindow.cpp:
1138         (MainWindow::buildUI):
1139         (MainWindow::onIconChanged):
1140         (MainWindow::onLoadStarted):
1141         * QtTestBrowser/mainwindow.h:
1142
1143 2011-03-23  Martin Robinson  <mrobinson@igalia.com>
1144
1145         Reviewed by Xan Lopez.
1146
1147         [GTK] Force DumpRenderTree to use 96 DPI
1148         https://bugs.webkit.org/show_bug.cgi?id=56866
1149
1150         Make sure that GTK+ is set to use 96 DPI when running tests. This ensures
1151         broader compatibility with WebKit2 and makes setting font sizes more straightforward.
1152
1153         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1154         (initializeGtkFontSettings): Set the screen resolution and GTK+ xft property to 96 DPI.
1155         (resetDefaultsToConsistentValues):Remove the call which repeatedly set the GDK screen resolution.
1156         (setDefaultsToConsistentStateValuesForTesting): Update the font sizes to reflect the new DPI.
1157
1158 2011-03-25  Andy Estes  <aestes@apple.com>
1159
1160         Reviewed by Adele Peterson.
1161
1162         REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
1163         https://bugs.webkit.org/show_bug.cgi?id=49016
1164
1165         TestNetscapePlugIn needs to register support for an image MIME type so
1166         we can test that the embed tag prefers plug-ins to render image MIME
1167         types.
1168
1169         * DumpRenderTree/TestNetscapePlugIn/mac/Info.plist: Register image/png.
1170         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1171         (NP_GetMIMEDescription): Ditto.
1172         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Ditto.
1173
1174 2011-03-25  Jessie Berlin  <jberlin@apple.com>
1175
1176         Reviewed by Sam Weinig.
1177
1178         WebKit2: Need to be able to set and get the Cookie Storage Policy.
1179         https://bugs.webkit.org/show_bug.cgi?id=50780
1180
1181         Add a test for getting and setting the HTTP Cookie Accept Policy in WebKit2.
1182
1183         The test is named "CookieManager" so that we can eventually exercise more of the
1184         CookieManager functionality in the test.
1185
1186         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp: Added.
1187         (TestWebKitAPI::didGetTestHTTPCookieAcceptPolicy):
1188         Assert that the policy returned is equal to the policy set in
1189         didGetUserHTTPCookieAcceptPolicy, and then restore the user's policy.
1190         (TestWebKitAPI::didGetUserHTTPCookieAcceptPolicy):
1191         Set the policy to something different than the user's policy and get the policy again.
1192         (TestWebKitAPI::didFinishLoadForFrame):
1193         Get the user's policy so that it can be restored at the end of the test.
1194         (TestWebKitAPI::TEST):
1195         Load about:blank so that the Web Process gets instatiated (needed to get the
1196         CookieManager).
1197
1198         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1199         Add CookieManager.cpp.
1200
1201 2011-03-24  Kevin Ollivier  <kevino@theolliviers.com>
1202
1203         [wx] Fix the build so that gcc-4.1 and up can be used to build on SnowLeopard.
1204
1205         * wx/build/settings.py:
1206
1207 2011-03-24  Ilya Sherman  <isherman@chromium.org>
1208
1209         Reviewed by Adam Roben.
1210
1211         Implement layoutTestController.setAutoFilled in DRT on Windows
1212         https://bugs.webkit.org/show_bug.cgi?id=56828
1213
1214         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1215         (LayoutTestController::setAutofilled): Implemented.
1216
1217 2011-03-24  Brent Fulgham  <bfulgham@webkit.org>
1218
1219         Unreviewed build correction.
1220
1221         Correct vsprops file for Debug variant of the CFLite build.
1222         Disable a CFNETWORK-specific test when building for CFLite.
1223
1224         * TestWebKitAPI/Configurations/TestWebKitAPIDebugCairoCFLite.vsprops:
1225         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1226
1227 2011-03-24  Dirk Pranke  <dpranke@chromium.org>
1228
1229         Reviewed by Adam Barth.
1230
1231         fix regressions introduced in 81908 - there were a couple of
1232         code paths that only fired under python 2.5 that I missed.
1233
1234         Also change a couple of 'python' references to sys.executable
1235         in order to handle runing test-webkitpy with a binary other than
1236         something called 'python'.
1237
1238         https://bugs.webkit.org/show_bug.cgi?id=57063
1239
1240         * Scripts/webkitpy/layout_tests/port/mac.py:
1241         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1242         * Scripts/webkitpy/test/cat.py:
1243         * Scripts/webkitpy/test/echo.py:
1244
1245 2011-03-24  Brent Fulgham  <bfulgham@webkit.org>
1246
1247         Unreviewed build correction.
1248
1249         Add a stub implementation of the TestInvocation dumping logic.
1250         Update project files to reflect new file.
1251
1252         * WebKitTestRunner/cairo: Added.
1253         * WebKitTestRunner/cairo/TestInvocationCairo.cpp: Added.
1254         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1255         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1256
1257 2011-03-24  Dirk Pranke  <dpranke@chromium.org>
1258
1259         Reviewed by Tony Chang.
1260
1261         new-run-webkit-tests: clean up worker model defaults. This
1262         changes the default behavior to 'threads' instead of
1263         'old-threads', and clarifies that chromium-win-* and
1264         chromium-mac-leopard are exceptions.
1265
1266         https://bugs.webkit.org/show_bug.cgi?id=56971
1267
1268         * Scripts/webkitpy/layout_tests/port/base.py:
1269         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1270         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1271         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1272         * Scripts/webkitpy/layout_tests/port/test.py:
1273         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1274
1275 2011-03-23  Leandro Gracia Gil  <leandrogracia@chromium.org>
1276
1277         Reviewed by Darin Adler.
1278
1279         Media Stream API: fix the order of the options in build-webkit.
1280         https://bugs.webkit.org/show_bug.cgi?id=56949
1281
1282         Fix the order of the options in build-webkit.
1283
1284         * Scripts/build-webkit:
1285
1286 2011-03-23  Adam Klein  <adamk@chromium.org>
1287
1288         Reviewed by Mihai Parparita.
1289
1290         Add an option to new-run-webkit-httpd to allow overriding the location of LayoutTests directory
1291         https://bugs.webkit.org/show_bug.cgi?id=56884
1292
1293         This option will be utilized by Chromium's ui_tests to allow
1294         referencing js-test-resources from a layout test over HTTP.
1295
1296         * Scripts/new-run-webkit-httpd:
1297         Added --layout_tests_dir option.
1298         * Scripts/webkitpy/layout_tests/port/http_server.py:
1299         Plumbed through as layout_tests_dir param.
1300
1301 2011-03-23  Dirk Pranke  <dpranke@chromium.org>
1302
1303         Reviewed by Mihai Parparita.
1304
1305         new-run-webkit-tests: run tests in ascending alphabetical order per
1306         dir. This is a second attempt at the fix; the first attempt, in 
1307         r81597, broke the behavior on the old-inline and old-threads
1308         worker models.
1309
1310         https://bugs.webkit.org/show_bug.cgi?id=56760
1311
1312         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1313         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1314         * Scripts/webkitpy/layout_tests/port/test.py:
1315         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1316
1317 2011-03-23  Mario Sanchez Prada  <msanchez@igalia.com>
1318
1319         Reviewed by Martin Robinson.
1320
1321         [GTK] GTK's DRT to ouput detail's string for the 'property-change' signal
1322         https://bugs.webkit.org/show_bug.cgi?id=56953
1323
1324         Print the string for the detail of 'property-change' signal.
1325
1326         * DumpRenderTree/gtk/AccessibilityCallbacks.cpp:
1327         (axObjectEventListener): Print the detail string.
1328
1329 2011-03-23  Yury Semikhatsky  <yurys@chromium.org>
1330
1331         Reviewed by Pavel Feldman.
1332
1333         [V8] Web Inspector: compile DebuggerScript.js into DebuggerScriptSource.h
1334         https://bugs.webkit.org/show_bug.cgi?id=56843
1335
1336         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
1337         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
1338
1339 2011-03-22  Eric Seidel  <eric@webkit.org>
1340
1341         Reviewed by Adam Barth.
1342
1343         Teach update-webkit about gyp
1344         https://bugs.webkit.org/show_bug.cgi?id=56881
1345
1346         This makes it possible for someone who builds from Xcode
1347         to just run update-webkit --gyp and have the project files
1348         generated after update automatically.
1349
1350         I also added a stand-alone "generate-project-files" script
1351         wrapping Source/gyp/configure.  This makes running gyp simpler
1352         since most people will not have gyp or Source/gyp in their path.
1353
1354         * Scripts/build-webkit:
1355         * Scripts/generate-project-files: Added.
1356         * Scripts/update-webkit:
1357
1358 2011-03-22  Anton D'Auria  <adauria@apple.com>
1359
1360         Reviewed by Alexey Proskuryakov.
1361
1362         Add +[WebApplicationCache getOriginsWithCache]
1363         https://bugs.webkit.org/show_bug.cgi?id=56722
1364
1365         * DumpRenderTree/LayoutTestController.cpp:
1366         (originsWithApplicationCacheCallback):
1367         (LayoutTestController::staticFunctions):
1368         * DumpRenderTree/LayoutTestController.h:
1369         * DumpRenderTree/chromium/LayoutTestController.cpp: Added stub.
1370         (LayoutTestController::originsWithApplicationCache):
1371         * DumpRenderTree/chromium/LayoutTestController.h:
1372         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added stub.
1373         (LayoutTestController::originsWithApplicationCache):
1374         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Pass array of origin's database identifiers.
1375         (originsArrayToJS): Helper function for converting array of WebSecurityOrigins to a JS array of origin identifiers.
1376         (LayoutTestController::originsWithApplicationCache):
1377         (LayoutTestController::originsWithLocalStorage):
1378         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added stub.
1379         (LayoutTestController::originsWithApplicationCache):
1380         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1381         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Added stub.
1382         (LayoutTestController::originsWithApplicationCache):
1383         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: Added stub.
1384         (LayoutTestController::originsWithApplicationCache):
1385
1386 2011-03-22  Eric Seidel  <eric@webkit.org>
1387
1388         Reviewed by Adam Barth.
1389
1390         Add support to build-webkit for building with gyp-generated project files
1391         https://bugs.webkit.org/show_bug.cgi?id=56877
1392
1393         build-webkit is a cesspool.  This change just hacks in --gyp support for Mac.
1394         Eventually we'll want to support gyp-generated projects in a more general manner.
1395
1396         * Scripts/build-webkit:
1397
1398 2011-03-22  David Kilzer  <ddkilzer@apple.com>
1399
1400         <http://webkit.org/b/56781> Add --dsym switch to enable dsym generation when building with Xcode
1401
1402         Reviewed by Joseph Pecoraro.
1403
1404         * Scripts/build-webkit: Updated usage statement to include
1405         --dsym.
1406         * Scripts/webkitdirs.pm: Added $generateDsym variable.
1407         (generateDsym): Added. Call determineGenerateDsym() and
1408         return $generateDsym.
1409         (determineGenerateDsym): Added.  Parse @ARGV for --dsym and set
1410         $generateDsym.
1411         (argumentsForXcode): Added.  Returns additional arguments for
1412         xcodebuild based on command-line switches.
1413         (XcodeOptions): Updated to include argumentsForXcode() in the
1414         array returned.
1415
1416 2011-03-22  Adam Roben  <aroben@apple.com>
1417
1418         Make Leopard Debug bots and Windows XP Debug (Tests) core builders
1419
1420         These bots are consistently green again.
1421
1422         Fixes <http://webkit.org/b/56830> Leopard Debug bots and Windows XP Debug (Tests) should be
1423         core builders
1424
1425         Rubber-stamped by Antti Koivisto.
1426
1427         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1428         (BuildBot.__init__): Loosened the regexps for Leopard and Windows.
1429
1430         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1431         (BuildBotTest.test_builder_name_regexps): Updated expectations.
1432
1433 2011-03-21  Sheriff Bot  <webkit.review.bot@gmail.com>
1434
1435         Unreviewed, rolling out r81597.
1436         http://trac.webkit.org/changeset/81597
1437         https://bugs.webkit.org/show_bug.cgi?id=56801
1438
1439         Change results in lots of unexpected flaky on the dashboard.
1440         (Requested by pfeldman on #webkit).
1441
1442         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1443         * Scripts/webkitpy/layout_tests/port/test.py:
1444         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1445
1446 2011-03-21  Sam Weinig  <sam@webkit.org>
1447
1448         Fix failing tests on the WebKit2 bots.
1449
1450         * WebKitTestRunner/TestController.cpp:
1451         (WTR::TestController::resetStateToConsistentValues):
1452
1453 2011-03-21  Daniel Sievers  <sievers@google.com>
1454
1455         Reviewed by Simon Fraser.
1456
1457         [Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
1458         https://bugs.webkit.org/show_bug.cgi?id=56139
1459
1460         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1461         (main):
1462         * DumpRenderTree/chromium/LayoutTestController.cpp:
1463         (LayoutTestController::LayoutTestController):
1464         (LayoutTestController::layerTreeAsText):
1465         * DumpRenderTree/chromium/LayoutTestController.h:
1466         (LayoutTestController::setShowDebugLayerTree):
1467         * DumpRenderTree/chromium/TestShell.cpp:
1468         (TestShell::runFileTest):
1469         (TestShell::dump):
1470         * DumpRenderTree/chromium/TestShell.h:
1471         (TestParams::TestParams):
1472
1473 2011-03-21  Adam Roben  <aroben@apple.com>
1474
1475         Try again to get buildbot to show run-javascriptcore-tests's actual.html as an HTML file
1476
1477         Fixes <http://webkit.org/b/56746> build.webkit.org shows run-javascriptcore-tests's HTML
1478         output as plain text
1479
1480         Reviewed by David Kilzer.
1481
1482         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1483         (RunJavaScriptCoreTests): List actual.html as one of our log files so it will get uploaded
1484         to the master.
1485         (RunJavaScriptCoreTests.commandComplete): Reading the actual.html file here won't work,
1486         since we're running on the build master, not the slave. Instead, turn the raw source of
1487         actual.html which the build slave uploaded into an HTML log.
1488
1489 2011-03-21  Dirk Pranke  <dpranke@chromium.org>
1490
1491         Reviewed by Mihai Parparita.
1492
1493         new-run-webkit-tests: run tests in ascending alphabetical order per dir
1494         https://bugs.webkit.org/show_bug.cgi?id=56760
1495
1496         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1497         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1498         * Scripts/webkitpy/layout_tests/port/test.py:
1499
1500 2011-03-21  Leandro Gracia Gil  <leandrogracia@chromium.org>
1501
1502         Reviewed by Steve Block.
1503
1504         Media Stream API patch 0: adding compilation guards.
1505         https://bugs.webkit.org/show_bug.cgi?id=56458
1506
1507         Adding options to enable the media stream API feature in Chromium.
1508
1509         * Scripts/build-webkit:
1510
1511 2011-03-21  Qi Zhang  <qi.2.zhang@nokia.com>
1512
1513         Reviewed by Laszlo Gombos.
1514
1515         [Qt] Add a command line option to capture stdout and stderr for DumpRenderTree
1516         https://bugs.webkit.org/show_bug.cgi?id=56323
1517
1518         Using freopen to redirect STDOUT and STDERR when DumpRenderTree command line provide 
1519         "--stdout" or "--stderr" option.
1520
1521         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1522         (WebCore::DumpRenderTree::~DumpRenderTree):
1523         (WebCore::DumpRenderTree::processArgsLine):
1524         (WebCore::DumpRenderTree::loadNextTestInStandAloneMode):
1525         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1526         (WebCore::DumpRenderTree::setRedirectOutputFileName):
1527         (WebCore::DumpRenderTree::setRedirectErrorFileName):
1528         * DumpRenderTree/qt/main.cpp:
1529         (isOption):
1530         (takeOptionValue):
1531         (printUsage):
1532         (main):
1533
1534 2011-03-21  Adam Roben  <aroben@apple.com>
1535
1536         Fix exceptions on the buildbot due to my last change
1537
1538         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1539         (RunJavaScriptCoreTests.commandComplete): Catch exceptions due to actual.html not existing.
1540
1541 2011-03-21  Adam Roben  <aroben@apple.com>
1542
1543         Teach buildbot to treat run-javascriptcore-tests's actual.html as an HTML file
1544
1545         Fixes <http://webkit.org/b/56746> build.webkit.org shows run-javascriptcore-tests's HTML
1546         output as plain text
1547
1548         Reviewed by Darin Adler.
1549
1550         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1551         (RunJavaScriptCoreTests): Removed the logfiles variable, which can only handle plaintext
1552         logs.
1553         (RunJavaScriptCoreTests.commandComplete): Use the addHTMLLog method to upload actual.html to
1554         the build master. This will correctly treat it as HTML.
1555
1556 2011-03-20  Bill Budge  <bbudge@chromium.org>
1557
1558         Reviewed by Adam Barth.
1559
1560         Rename ThreadSafeShared to ThreadSafeRefCounted
1561         https://bugs.webkit.org/show_bug.cgi?id=56714
1562
1563         No new tests. Exposes no new functionality.
1564
1565         * DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeRefCounted.h: Copied from DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h.
1566         * DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h: Removed.
1567         * Scripts/do-webcore-rename:
1568
1569 2011-03-19  Anton D'Auria  <adauria@apple.com>
1570
1571         Reviewed by Dan Bernstein.
1572
1573         Add stub to LayoutTestControllerGtk.cpp to fix GTK build
1574         https://bugs.webkit.org/show_bug.cgi?id=56719
1575
1576         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Adding stub.
1577         (LayoutTestController::clearApplicationCacheForOrigin):
1578
1579 2011-03-19  Anton D'Auria  <adauria@apple.com>
1580
1581         Reviewed by Alexey Proskuryakov.
1582
1583         ApplicationCacheGroup is not obsolete after being deleted via ApplicationCacheStorage::deleteEntriesForOrigin
1584         https://bugs.webkit.org/show_bug.cgi?id=56415
1585
1586         * DumpRenderTree/LayoutTestController.cpp:
1587         (clearApplicationCacheForOriginCallback):
1588         (LayoutTestController::staticFunctions):
1589         * DumpRenderTree/LayoutTestController.h:
1590         * DumpRenderTree/chromium/LayoutTestController.cpp: Adding stubs.
1591         (LayoutTestController::LayoutTestController):
1592         (LayoutTestController::clearAllApplicationCaches):
1593         (LayoutTestController::clearApplicationCacheForOrigin): 
1594         * DumpRenderTree/chromium/LayoutTestController.h:
1595         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Adding stub.
1596         (LayoutTestController::clearApplicationCacheForOrigin):
1597         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Adding stub.
1598         (LayoutTestController::clearApplicationCacheForOrigin):
1599         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1600         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Adding stub.
1601         (LayoutTestController::clearApplicationCacheForOrigin):
1602         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: Adding stub.
1603         (LayoutTestController::clearApplicationCacheForOrigin):
1604
1605 2011-03-18  Dan Bernstein  <mitz@apple.com>
1606
1607         Revised build fix for r81135.
1608
1609         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
1610         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1611
1612 2011-03-18  Adam Roben  <aroben@apple.com>
1613
1614         Windows build fix
1615
1616         * WebKitTestRunner/config.h: Add a missing #endif.
1617
1618 2011-03-18  Andreas Kling  <kling@webkit.org>
1619
1620         Unbreak Qt build after r81494.
1621
1622         * WebKitTestRunner/qt/TestInvocationQt.cpp:
1623         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1624
1625 2011-03-18  Sam Weinig  <sam@webkit.org>
1626
1627         Fix windows build. This was really Adam Roben's fault. I swear!
1628
1629         * WebKitTestRunner/config.h:
1630
1631 2011-03-18  Sam Weinig  <sam@webkit.org>
1632
1633         Reviewed by Adam Roben.
1634
1635         Pixel tests don't work in WebKitTestRunner on Windows
1636         https://bugs.webkit.org/show_bug.cgi?id=56630
1637
1638         Cross-platformize (Mac and Windows CG) the pixel dumping code in WebKitTestRunner to use WebKit2
1639         built-in snapshotting instead of using the window server on the Mac.
1640
1641         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1642         (WTR::InjectedBundle::InjectedBundle):
1643         (WTR::InjectedBundle::didReceiveMessage):
1644         (WTR::InjectedBundle::beginTesting):
1645         (WTR::InjectedBundle::done):
1646         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1647         (WTR::InjectedBundle::setPixelResult):
1648         (WTR::InjectedBundle::shouldDumpPixels):
1649         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1650         (WTR::InjectedBundlePage::dump):
1651         Take the snapshot in the bundle and send it to the UIProcess for dumping.
1652
1653         * WebKitTestRunner/TestInvocation.cpp:
1654         (WTR::TestInvocation::invoke):
1655         (WTR::TestInvocation::dump):
1656         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1657         * WebKitTestRunner/TestInvocation.h:
1658         * WebKitTestRunner/cg: Added.
1659         * WebKitTestRunner/cg/TestInvocationCG.cpp: Copied from WebKitTestRunner/mac/TestInvocationMac.mm.
1660         (WTR::createCGContextFromImage):
1661         (WTR::computeMD5HashStringForContext):
1662         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1663         * WebKitTestRunner/mac/TestInvocationMac.mm: Removed.
1664         Making pixel dumping code shared for CG ports. Also use the WTF/MD5 instead of platform specific code.
1665
1666         * WebKitTestRunner/win/TestInvocationWin.cpp:
1667         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1668         Keep stub for Cairo build.
1669
1670         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreGraphics.vsprops: Added.
1671         Add CG configuration.
1672
1673         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1674         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1675         Add new files.
1676
1677 2011-03-18  Adam Roben  <aroben@apple.com>
1678
1679         Don't allow Leaks Viewer's vertical scrollbar to cover up long function names
1680
1681         Rubber-stamped by Simon Fraser.
1682
1683         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
1684         (.data-grid .data-container): Use overflow-y:auto instead of the Inspector's default
1685         overflow-y:overlay so that the scrollbar doesn't overlay the content.
1686
1687 2011-03-18  Adam Roben  <aroben@apple.com>
1688
1689         Don't ellipsize long or indented function names in Leaks Viewer
1690
1691         Fixes <http://webkit.org/b/56037> Leaks viewer needs horizontal
1692         scrollbar
1693
1694         Reviewed by Simon Fraser.
1695
1696         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
1697         (.data-grid .data-container):
1698         (.data-grid td > div, .data-grid th > div):
1699         Allow the contents to extend to the right.
1700
1701 2011-03-18  Adam Roben  <aroben@apple.com>
1702
1703         Fix some leaks in DRT seen on the leaks bot
1704
1705         Fixes <http://webkit.org/b/56638> addURLToRedirectCallback and
1706         setWillSendRequestClearHeaderCallback in DRT are leaky
1707
1708         Reviewed by Alexey Proskuryakov.
1709
1710         * DumpRenderTree/ForwardingHeaders/wtf/OwnArrayPtr.h: Added.
1711
1712         * DumpRenderTree/LayoutTestController.cpp:
1713         (addURLToRedirectCallback):
1714         (setWillSendRequestClearHeaderCallback):
1715         Use OwnArrayPtr to cause the strings to be deleted.
1716
1717 2011-03-18  Adam Roben  <aroben@apple.com>
1718
1719         Fix a NSURLCredential leak seen on the leaks bot
1720
1721         Fixes <http://webkit.org/b/56637> -[SynchronousLoader
1722         connection:didReceiveAuthenticationChallenge:] is leaky
1723
1724         Reviewed by John Sullivan.
1725
1726         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1727         (-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]): Use a RetainPtr to
1728         cause the NSURLCredential to be released.
1729
1730 2011-03-18  John Knottenbelt  <jknotten@chromium.org>
1731
1732         Unreviewed.
1733
1734         Remove unnecessary brackets around my email address.
1735
1736         * Scripts/webkitpy/common/config/committers.py:
1737
1738 2011-03-18  Adam Roben  <aroben@apple.com>
1739         
1740         Remove some files I accidentally added in r81454
1741
1742         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreGraphics.vsprops: Removed.
1743         * WebKitTestRunner/cg/TestInvocationCG.cpp: Removed.
1744
1745 2011-03-18  Adam Roben  <aroben@apple.com>
1746
1747         Ignore an NSNumberFormatter leak on SnowLeopard
1748
1749         * Scripts/old-run-webkit-tests:
1750         (countAndPrintLeaks): Ignore leaks in -[NSNumberFormatter
1751         getObjectValue:forString:errorDescription:].
1752
1753 2011-03-18  Adam Roben  <aroben@apple.com>
1754
1755         Fix a leak beneath LayoutTestController::authenticateSession seen on the bots
1756
1757         Rubber-stamped by Mark Rowe.
1758
1759         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1760         (LayoutTestController::authenticateSession): Use a RetainPtr to cause the NSURLRequest to be
1761         released.
1762
1763 2011-03-17  Adam Roben  <aroben@apple.com>
1764
1765         Address a review comment I missed in r81445
1766
1767         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
1768         (LeaksParserWorker.prototype._parseLeaks): Anchor the RegExp used to find the number of
1769         leaked bytes to speed up searching on long lines.
1770
1771 2011-03-17  Adam Roben  <aroben@apple.com>
1772
1773         Mark leaky builds orange, even if all regression tests passed
1774
1775         Fixes <http://webkit.org/b/56609> SnowLeopard Intel Leaks bot appears green on
1776         build.webkit.org when all tests pass even though there are still leaks
1777
1778         Reviewed by Dan Bernstein.
1779
1780         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1781         (RunWebKitLeakTests): Set the warnOnWarnings property to True so that the entire build will
1782         be marked orange if this build step generates warnings.
1783
1784 2011-03-17  Adam Roben  <aroben@apple.com>
1785
1786         Allow values in Leaks Viewer to be shown as percentages
1787
1788         Double-clicking on a column will toggle between showing percentages and showing real values.
1789
1790         Fixes <http://webkit.org/b/56628> Would like to view values as percentages of the total
1791         number of leaked bytes in Leaks Viewer
1792
1793         Reviewed by Joe Pecoraro.
1794
1795         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
1796         (LeaksParserWorker.prototype._incorporateLeaks): Calculate the (never-shown) top-level
1797         node's totalTime, which is used in calculating percentages.
1798
1799         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
1800         (monkeyPatchInspectorObjects): Only format values as bytes if we aren't supposed to be
1801         showing them as percentages.
1802
1803 2011-03-17  Adam Roben  <aroben@apple.com>
1804
1805         Show the number of leaked bytes, not just leaked allocations, in Leaks Viewer
1806
1807         The Self and Total columns now report the number of leaked bytes. The new Calls column shows
1808         the number of leaked allocations. And the new Average column shows the average number of
1809         leaked bytes per call.
1810
1811         Fixes <http://webkit.org/b/56344> Leaks Viewer should show how many bytes were leaked, not
1812         just how many allocations
1813
1814         Reviewed by Joe Pecoraro.
1815
1816         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
1817         (LeaksParserWorker.prototype._parseLeaks): Parse the number of leaked bytes from the "Leak:"
1818         line and store it with the leak stack.
1819         (LeaksParserWorker.prototype._createNode): Initialize the averageTime and numberOfCalls
1820         properties.
1821         (LeaksParserWorker.prototype._incorporateLeaks): Updated to get the stack from the .stack
1822         property, and changed to store the number of leaked bytes in .selfTime/.totalTime.
1823         .numberOfCalls now holds the number of leaked allocations.
1824
1825         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
1826         (Preferences): Set samplingCPUProfiler to false so that the Average and Calls columns will
1827         appear.
1828         (monkeyPatchInspectorObjects): Format the values as bytes.
1829
1830 2011-03-17  Adam Roben  <aroben@apple.com>
1831
1832         Make Leaks Viewer able to count leaks in builds that didn't fail any regression tests
1833
1834         Fixes <http://webkit.org/b/56626> Leaks Viewer omits recent builds which didn't fail any
1835         regression tests
1836
1837         Reviewed by James Robinson.
1838
1839         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
1840         (RecentBuildsLoader.prototype.start): Get the number of leaks out of the "text" array, which
1841         is always populated, even when all regression tests pass.
1842
1843 2011-03-10  Hayato Ito  <hayato@chromium.org>
1844
1845         Reviewed by Tony Chang.
1846
1847         Add a check logic for reftests in case that a reftest is marked AS REBASELINE.
1848
1849         https://bugs.webkit.org/show_bug.cgi?id=56076
1850
1851         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1852
1853 2011-03-17  Adam Roben  <aroben@apple.com>
1854
1855         Skip a compositing-sensitive test when accelerated compositing is disabled
1856
1857         Reviewed by Sam Weinig.
1858
1859         * Scripts/old-run-webkit-tests: Skip media/media-document-audio-repaint.html when
1860         accelerated compositing is disabled.
1861
1862 2011-03-17  Adam Roben  <aroben@apple.com>
1863
1864         Start using PlatformSpecificScheduler for the Mac builders
1865
1866         The current set of file/directory patterns should work for Mac builders. We may discover
1867         that there are more files and directories we can exclude from the Mac builds, but they can
1868         be added later.
1869
1870         Fixes <http://webkit.org/b/56593> Mac builders do lots of unnecessary builds
1871
1872         Reviewed by Mark Rowe.
1873
1874         * BuildSlaveSupport/build.webkit.org-config/config.json: Moved the Mac builders into two
1875         PlatformSpecificSchedulers: one for Leopard, and one for SnowLeopard.
1876
1877         * Scripts/webkitpy/common/config/build.py:
1878         (_should_file_trigger_build): Allow "mac-leopard" and "mac-snowleopard" platforms, and
1879         cleaned up patterns a little bit.
1880
1881         * Scripts/webkitpy/common/config/build_unittest.py:
1882         (ShouldBuildTest): Fixed some expected results.
1883         (ShouldBuildTest.test_should_build): Start testing "mac-leopard" and "mac-snowleopard"
1884         platforms.
1885
1886 2011-03-17  Jeff Miller  <jeffm@apple.com>
1887
1888         Use a consistent set of file patterns in the svn:ignore property for all .xcodeproj directories, specifically:
1889         
1890         *.mode*
1891         *.pbxuser
1892         *.perspective*
1893         project.xcworkspace
1894         xcuserdata
1895
1896         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
1897         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
1898         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
1899         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
1900         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
1901
1902 2011-03-17  Adam Roben  <aroben@apple.com>
1903
1904         Make old-run-webkit-tests pick up mac-wk2 results when running in WebKit2 mode on Windows
1905
1906         Fixes <http://webkit.org/b/56563> Running WebKit2 tests on Windows should use results from
1907         mac-wk2
1908
1909         Reviewed by Anders Carlsson.
1910
1911         * Scripts/old-run-webkit-tests:
1912         (expectedDirectoryForTest): Clean up the code to search in extra Mac platform result
1913         directories on Windows. Add mac-wk2 to the set of extra platforms we look in on Windows when
1914         we're running in WebKit2 mode.
1915
1916 2011-03-17  Mikhail Naganov  <mnaganov@chromium.org>
1917
1918         Reviewed by Yury Semikhatsky.
1919
1920         Web Inspector: Clean up Inspector strings.
1921         https://bugs.webkit.org/show_bug.cgi?id=56557
1922
1923         Modify the script to deal correctly with "\xNN" escapes, and to
1924         check strings in Chromium's DevTools.js.
1925
1926         * Scripts/check-inspector-strings:
1927
1928 2011-03-17  Keith Kyzivat  <keith.kyzivat@nokia.com>
1929
1930         Reviewed by Benjamin Poulain.
1931
1932         Update autoinstall to install mechanize 0.2.4
1933         https://bugs.webkit.org/show_bug.cgi?id=56499
1934
1935         Newer versions of mechanize support HTTPS proxies, which is necessary
1936         for people using webkit-patch behind firewalls.
1937
1938         * Scripts/webkitpy/common/system/autoinstall.py:
1939         * Scripts/webkitpy/thirdparty/__init__.py:
1940
1941 2011-03-16  Sam Weinig  <sam@webkit.org>
1942
1943         Reviewed by Adam Roben.
1944
1945         REGRESSION (r81084): media/invalid-media-url-crash.html and editing/execCommand/indent-paragraphs.html failing on WebKit2
1946         https://bugs.webkit.org/show_bug.cgi?id=56541
1947
1948         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1949         (WTR::InjectedBundlePage::willSendRequestForFrame):
1950         Check for an empty host in addition to a null host.  This bug was introduced
1951         when porting off of the KURL code and onto the WKURLRef version.
1952
1953 2011-03-16  Sam Weinig  <sam@webkit.org>
1954
1955         Reviewed by Adam Roben.
1956
1957         Add Lucas Forschler to the list of WebKit committers.
1958
1959         * Scripts/webkitpy/common/config/committers.py:
1960
1961 2011-03-16  Sam Weinig  <sam@webkit.org>
1962
1963         Reviewed upon and dictated through Adam Roben.
1964
1965         Escape crashing function names in results.html. This fixes an issue
1966         when a crash involves a type with templates.
1967
1968         * Scripts/old-run-webkit-tests:
1969
1970 2011-03-16  Daniel Sievers  <sievers@google.com>
1971
1972         Reviewed by James Robinson.
1973
1974         Add setting to always force compositing mode
1975         https://bugs.webkit.org/show_bug.cgi?id=56156
1976
1977         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1978         (main):
1979         * DumpRenderTree/chromium/TestShell.cpp:
1980         (TestShell::TestShell):
1981         (TestShell::resetWebSettings):
1982         * DumpRenderTree/chromium/TestShell.h:
1983         (TestShell::setForceCompositingMode):
1984         * DumpRenderTree/chromium/WebPreferences.cpp:
1985         (WebPreferences::reset):
1986         (WebPreferences::applyTo):
1987         * DumpRenderTree/chromium/WebPreferences.h:
1988
1989 2011-03-15  Hayato Ito  <hayato@chromium.org>
1990
1991         Reviewed by Ojan Vafai.
1992
1993         Ignore files that will be used by reftests in old-run-webkit-tests.
1994
1995         https://bugs.webkit.org/show_bug.cgi?id=55936
1996
1997         * Scripts/old-run-webkit-tests:
1998
1999 2011-03-15  Felipe Oliveira da Silva Netto  <f.dachshund@gmail.com>
2000
2001         Reviewed by Adam Roben.
2002
2003         Function relativeScriptsDir doesn't return the correct relative
2004         Scripts directory.
2005
2006         * Scripts/webkitdirs.pm:
2007         (relativeScriptsDir): Ensure we use the directory that contains
2008         webkitdirs.pm, not the one that contains the original script that
2009         was invoked.
2010
2011 2011-03-15  Kevin Ollivier  <kevino@theolliviers.com>
2012
2013         [wx] Build fixes for long linker commands on Win and method return error, plus a Mac
2014         fix to link against the Security framework after recent WebKitSystemInterface changes.
2015
2016         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2017         (LayoutTestController::originsWithLocalStorage):
2018         * wx/build/settings.py:
2019         * wx/build/waf_extensions.py:
2020
2021 2011-03-15  Sam Weinig  <sam@webkit.org>
2022
2023         Reviewed by Darin Adler.
2024
2025         Add script to convert a patch to a prettypatch and show in the default browser
2026         https://bugs.webkit.org/show_bug.cgi?id=56416
2027
2028         This can be used either like
2029             $ svn-create-patch | show-pretty-diff
2030         or
2031             $ show-pretty-diff patch.diff
2032
2033         * Scripts/show-pretty-diff: Added.
2034
2035 2011-03-15  Brian Weinstein  <bweinstein@apple.com>
2036
2037         Rubber-stamped by Adam Roben.
2038
2039         Adding myself as a reviewer.
2040
2041         * Scripts/webkitpy/common/config/committers.py:
2042
2043 2011-03-15  Anders Carlsson  <andersca@apple.com>
2044
2045         Try to fix the Windows build.
2046
2047         * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp:
2048         (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject):
2049
2050 2011-03-15  Anders Carlsson  <andersca@apple.com>
2051
2052         Reviewed by Sam Weinig.
2053
2054         Make sure that NP_Shutdown is always the last NPP function called
2055         https://bugs.webkit.org/show_bug.cgi?id=56391
2056
2057         Add a test that times out if an NP_Deallocate object is called after NP_Shutdown.
2058
2059         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2060         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2061         (PluginTest::PluginTest):
2062         (PluginTest::NP_Shutdown):
2063         (PluginTest::registerNPShutdownFunction):
2064         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2065         * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp: Added.
2066         (NPDeallocateCalledBeforeNPShutdown::NPDeallocateCalledBeforeNPShutdown):
2067         (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject):
2068         (NPDeallocateCalledBeforeNPShutdown::ScriptableObject::hasProperty):
2069         (NPDeallocateCalledBeforeNPShutdown::ScriptableObject::getProperty):
2070         (NPDeallocateCalledBeforeNPShutdown::NPP_New):
2071         (NPDeallocateCalledBeforeNPShutdown::NPP_GetValue):
2072         (NPDeallocateCalledBeforeNPShutdown::shutdown):
2073         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2074         (NP_Shutdown):
2075         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2076         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2077         * GNUmakefile.am:
2078
2079 2011-03-15  Ilya Sherman  <isherman@chromium.org>
2080
2081         Reviewed by Tony Chang.
2082
2083         Autofilled form elements are assigned fixed background color but not text color
2084         https://bugs.webkit.org/show_bug.cgi?id=48382
2085
2086         * DumpRenderTree/LayoutTestController.cpp:
2087         (setAutofilledCallback): Added.
2088         (LayoutTestController::staticFunctions):
2089         * DumpRenderTree/LayoutTestController.h:
2090         * DumpRenderTree/chromium/LayoutTestController.cpp:
2091         (LayoutTestController::LayoutTestController):
2092         (LayoutTestController::setAutofilled): Added.
2093         * DumpRenderTree/chromium/LayoutTestController.h:
2094         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2095         (LayoutTestController::setAutofilled): Added.
2096         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2097         (LayoutTestController::setAutofilled): Added.
2098         (LayoutTestController::setValueForUser): Style tweak.
2099         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2100         (LayoutTestController::setAutofilled): Added (stub).
2101         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2102         (LayoutTestController::setAutofilled): Added (stub).
2103
2104 2011-03-15  Dan Bernstein  <mitz@apple.com>
2105
2106         Build fix after r81135.
2107
2108         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
2109
2110 2011-03-15  Dan Bernstein  <mitz@apple.com>
2111
2112         Build fix after r81135.
2113
2114         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
2115         * WebKitTestRunner/mac/TestControllerMac.mm:
2116         * WebKitTestRunner/mac/TestInvocationMac.mm:
2117         * WebKitTestRunner/mac/main.mm:
2118
2119 2011-03-15  Balazs Kelemen  <kbalazs@webkit.org>
2120
2121         Reviewed by Adam Barth.
2122
2123         REGRESSION(80977): breaks Qt ARMv7 Linux Release bot
2124         https://bugs.webkit.org/show_bug.cgi?id=56349
2125
2126         * QtTestBrowser/QtTestBrowser.pro: Link against fontconfig
2127         on platforms where we use it. Copied from DumpRenderTree.pro.
2128
2129 2011-03-15  Dan Bernstein  <mitz@apple.com>
2130
2131         Build fix after r81135.
2132
2133         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
2134         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm:
2135
2136 2011-03-15  Kevin Ollivier  <kevino@theolliviers.com>
2137
2138         Reviewed by Darin Adler.
2139
2140         Introduce WTF_USE_EXPORT_MACROS, which will allow us to put shared library import/export
2141         info into the headers rather than in export symbol definition files, but disable it on 
2142         all platforms initially so we can deal with port build issues one port at a time.
2143         
2144         https://bugs.webkit.org/show_bug.cgi?id=27551
2145
2146         * DumpRenderTree/cg/ImageDiffCG.cpp:
2147         * DumpRenderTree/chromium/config.h:
2148         * DumpRenderTree/config.h:
2149         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2150         * TestWebKitAPI/TestWebKitAPIPrefix.h:
2151         * WebKitAPITest/HostWindow.cpp:
2152         * WebKitAPITest/TestsController.cpp:
2153         * WebKitAPITest/config.h: Added.
2154         * WebKitAPITest/main.cpp:
2155         * WebKitAPITest/tests/WebViewDestruction.cpp:
2156         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp:
2157         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2158         * WebKitTestRunner/InjectedBundle/GCController.cpp:
2159         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2160         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
2161         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2162         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2163         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2164         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
2165         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
2166         * WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp:
2167         * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp:
2168         * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:
2169         * WebKitTestRunner/TestController.cpp:
2170         * WebKitTestRunner/TestInvocation.cpp:
2171         * WebKitTestRunner/config.h: Added.
2172         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2173         * WebKitTestRunner/qt/TestControllerQt.cpp:
2174         * WebKitTestRunner/qt/TestInvocationQt.cpp:
2175         * WebKitTestRunner/qt/main.cpp:
2176         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2177         * WebKitTestRunner/win/TestControllerWin.cpp:
2178         * WebKitTestRunner/win/TestInvocationWin.cpp:
2179         * WebKitTestRunner/win/main.cpp:
2180         * wx/build/settings.py:
2181
2182 2011-03-15  Hayato Ito  <hayato@chromium.org>
2183
2184         Reviewed by Shinichiro Hamaji.
2185
2186         [NRWT] Add support for reftests to new-run-webkit-tests.
2187
2188         https://bugs.webkit.org/show_bug.cgi?id=55457
2189
2190         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
2191         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2192         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
2193         * Scripts/webkitpy/layout_tests/port/base.py:
2194         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2195         * Scripts/webkitpy/layout_tests/port/test.py:
2196         * Scripts/webkitpy/layout_tests/port/test_files.py:
2197         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2198
2199 2011-03-15  Alejandro G. Castro  <alex@igalia.com>
2200
2201         Reviewed by Martin Robinson.
2202
2203         [GTK] Fix compilation warning after r80892
2204         https://bugs.webkit.org/show_bug.cgi?id=56302
2205
2206         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2207         (LayoutTestController::originsWithLocalStorage):
2208
2209 2011-03-15  Robert Hogan  <robert@webkit.org>
2210
2211         Reviewed by Adam Barth.
2212
2213         Document the qmakearg argument, and hint how to build webkit2 on Qt
2214         https://bugs.webkit.org/show_bug.cgi?id=56326
2215
2216         * Scripts/build-webkit: add --qmakearg to build-webkit --help
2217
2218 2011-03-15  Adam Roben  <aroben@apple.com>
2219
2220         Make Windows 7 Release (Tests) a core builder
2221
2222         We can probably make Windows XP Debug (Tests) a core builder, too, but we should probably
2223         give it a few more days of greenness first.
2224
2225         Fixes <http://webkit.org/b/55665> Windows 7 Release (Tests) should be a core builder
2226
2227         Reviewed by Sam Weinig.
2228
2229         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2230         (BuildBot): Added a regexp to match Windows 7 Release (Tests).
2231
2232         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2233         (BuildBotTest): Updated the list of builders to match the current list on build.webkit.org.
2234         Updated the core regexps to match the buildbot module. Updated the expected results to match
2235         the current set of core builders.
2236
2237 2011-03-14  Adam Roben  <aroben@apple.com>
2238
2239         Add forgotten file from r81116
2240
2241         * TestWebKitAPI/Configurations/TestWebKitAPICFNetwork.vsprops: Added.
2242
2243 2011-03-14  Sam Weinig  <sam@webkit.org>
2244
2245         Reviewed by Adam Roben.
2246
2247         about:blank fake responses don't get serialized when sent the UIProcess
2248         <rdar://problem/9108119>
2249         https://bugs.webkit.org/show_bug.cgi?id=56357
2250
2251         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp: Added.
2252         (TestWebKitAPI::decidePolicyForResponse):
2253         (TestWebKitAPI::TEST):
2254         Add test that loads of about:blank have a response with a MIMEType of text/html.
2255
2256         * TestWebKitAPI/PlatformUtilities.h:
2257         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
2258         (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
2259         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2260         (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
2261         Add helper to get the MIMEType from a WKURLResponse.
2262
2263         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2264         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2265         Add new files.
2266
2267 2011-03-14  Jarkko Sakkinen  <jarkko.j.sakkinen@gmail.com>
2268
2269         Reviewed by Kenneth Rohde Christiansen.
2270
2271         [Qt] Command-line options for QGLWidget and WebGL to QtTestBrowser
2272         https://bugs.webkit.org/show_bug.cgi?id=56006
2273
2274         * QtTestBrowser/launcherwindow.cpp:
2275         (LauncherWindow::initializeView):
2276         * QtTestBrowser/main.cpp:
2277         (LauncherApplication::handleUserOptions):
2278
2279 2011-03-14  James Kozianski  <koz@chromium.org>
2280
2281         Reviewed by Ojan Vafai.
2282
2283         Add method to make BuildBot return test outputs
2284         https://bugs.webkit.org/show_bug.cgi?id=54374
2285
2286         The Builder.latest_cached_build will be used by the new rebaseline
2287         script to determine the build to use baselines from.
2288
2289         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2290         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2291
2292 2011-03-14  Adam Roben  <aroben@apple.com>
2293
2294         Test that WKBundlePageCanHandleRequest returns true for empty document URLs
2295
2296         Reviewed by Sam Weinig.
2297
2298         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp: Added.
2299         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Store the result of the test.
2300         (TestWebKitAPI::setInjectedBundleClient): Hook up our callback.
2301         (TestWebKitAPI::TEST): Register "emptyscheme" as an empty document scheme, load a page to
2302         ensure the web process is initialized, then ask the bundle to run the test and assert that
2303         it succeeded.
2304
2305         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp: Added.
2306         (TestWebKitAPI::CanHandleRequestTest::CanHandleRequestTest): Just call up to the base class.
2307         (TestWebKitAPI::canHandleURL): Helper function to test whether WebKit2 claims to be able to
2308         handle a given URL.
2309         (TestWebKitAPI::runTest): Check that empty document URLs can be handled (and that an unknown
2310         URL type cannot be handled).
2311         (TestWebKitAPI::CanHandleRequestTest::didReceiveMessage): Run the test and return the
2312         result.
2313
2314         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2315         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2316         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
2317         Added new files to the project.
2318
2319 2011-03-14  Sheriff Bot  <webkit.review.bot@gmail.com>
2320
2321         Unreviewed, rolling out r81094.
2322         http://trac.webkit.org/changeset/81094
2323         https://bugs.webkit.org/show_bug.cgi?id=56355
2324
2325         Broke the chromium DRT related build. (Requested by dave_levin
2326         on #webkit).
2327
2328         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2329         (main):
2330         * DumpRenderTree/chromium/LayoutTestController.cpp:
2331         (LayoutTestController::LayoutTestController):
2332         (LayoutTestController::layerTreeAsText):
2333         * DumpRenderTree/chromium/LayoutTestController.h:
2334         * DumpRenderTree/chromium/TestShell.cpp:
2335         (TestShell::runFileTest):
2336         (TestShell::dump):
2337         * DumpRenderTree/chromium/TestShell.h:
2338         (TestParams::TestParams):
2339
2340 2011-03-14  Daniel Sievers  <sievers@google.com>
2341
2342         Reviewed by Simon Fraser.
2343
2344         [Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
2345         https://bugs.webkit.org/show_bug.cgi?id=56139
2346
2347         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2348         (main):
2349         * DumpRenderTree/chromium/LayoutTestController.cpp:
2350         (LayoutTestController::LayoutTestController):
2351         (LayoutTestController::layerTreeAsText):
2352         * DumpRenderTree/chromium/LayoutTestController.h:
2353         (LayoutTestController::setShowDebugLayerTree):
2354         * DumpRenderTree/chromium/TestShell.cpp:
2355         (TestShell::runFileTest):
2356         (TestShell::dump):
2357         * DumpRenderTree/chromium/TestShell.h:
2358         (TestParams::TestParams):
2359
2360 2011-03-14  Balazs Kelemen  <kbalazs@webkit.org>
2361
2362         Reviewed by Adam Roben.
2363
2364         [Qt][WK2]Unbreak InjectedBundle on Qt
2365         https://bugs.webkit.org/show_bug.cgi?id=54109
2366
2367         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2368         (WTR::InjectedBundlePage::willSendRequestForFrame): Use new WebKit2
2369         API's instead of KURL to analyze the URL.
2370         * WebKitTestRunner/StringFunctions.h:
2371         (WTR::adoptWK): Moved from InjectedBundlePage.cpp to make it available globally
2372         in the WebKitTestRunner project.
2373         (WTR::toWK): Use adoptWK.
2374         (WTR::operator<<): Added helper for printing a WKURL.
2375         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Do not link
2376         against WebCore.
2377
2378 2011-03-14  Balazs Kelemen  <kbalazs@webkit.org>
2379
2380         Reviewed by Kenneth Rohde Christiansen.
2381
2382         check-webkit-style falsely should not complain about WebKit2 API headers in the Shared directory
2383         https://bugs.webkit.org/show_bug.cgi?id=56321
2384
2385         * Scripts/webkitpy/style/checker.py: Add the patch "Source/WebKit2/Shared/API/c"
2386         to the list of exceptions for WebKit2 C API headers.
2387
2388 2011-03-14  Adam Roben  <aroben@apple.com>
2389
2390         Show the list of recent leaky builds in reverse chronological order
2391
2392         Previously they were being shown in a deterministic but surprising order based on
2393         lexicographically sorting the build offsets (-1, -10, -2, -3...).
2394
2395         Fixes <http://webkit.org/b/56342> Leaks Viewer shows recent builds in a strange order
2396
2397         Reviewed by Darin Adler.
2398
2399         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
2400         (RecentBuildsLoader.prototype.start): Sort the builds by revision before passing them to our
2401         callback.
2402
2403 2011-03-14  Adam Roben  <aroben@apple.com>
2404
2405         Show a list of up to 10 recent leaky builds when Leaks Viewer loads
2406
2407         Fixes <http://webkit.org/b/56043> Leaks Viewer should present a list of recent builds to
2408         analyze
2409
2410         Reviewed by David Kilzer and Joe Pecoraro.
2411
2412         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
2413         (#url-prompt): Made this a bit taller to make room for the list of builds.
2414
2415         (#recent-builds-loading-indicator):
2416         (#recent-builds-list):
2417         Added styles for the build list and loading indicator.
2418
2419         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
2420         (LeaksViewer.loaded): Pass the URL from the query through decodeURIComponent before loading
2421         it. This will unescape it.
2422         (LeaksViewer.urlPromptButtonClicked): Moved code from here to _urlChosenFromPrompt.
2423         (LeaksViewer._didLoadRecentBuilds): Added. Stores the builds and updates the prompt.
2424         (LeaksViewer._displayURLPrompt): Start loading the recent leaky builds.
2425         (LeaksViewer._updateURLPrompt): Create a list of the recent leaky builds and add them to the
2426         prompt UI.
2427         (LeaksViewer._urlChosenFromPrompt): Added. Code came from urlPromptButtonClicked. This is
2428         now also used when a recent build is clicked.
2429
2430         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js: Added.
2431         (RecentBuildsLoader): Store the callback.
2432         (RecentBuildsLoader.prototype.start): Load the N most recent builds from the specified
2433         builder. Find the revision number, leak count, and results URL for each one. Pass the
2434         resulting info to our callback.
2435
2436         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js:
2437         (range): Added this helper function to return an array containing the integers [0, n).
2438
2439         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added
2440         RecentBuildsLoader.js and added text to the prompt UI to show the recent builds.
2441
2442 2011-03-14  Mark Rowe  <mrowe@apple.com>
2443
2444         Reviewed by Adam Roben.
2445
2446         Fix two memory leaks within LayoutTestController's storage support.
2447
2448         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2449         (LayoutTestController::originsWithLocalStorage): Don't leak the JSStringRef that is returned
2450         by JSStringCreateWithCFString.
2451         (LayoutTestController::deleteLocalStorageForOrigin): Don't leak the WebSecurityOrigin that we
2452         allocate.
2453
2454 2011-03-14  Mark Rowe  <mrowe@apple.com>
2455
2456         Reviewed by Oliver Hunt.
2457
2458         <http://webkit.org/b/56304> REGRESSION(r80892): 100,000+ leaks seen on the build bot
2459
2460         * DumpRenderTree/LayoutTestController.cpp:
2461         (LayoutTestController::staticFunctions): Remove duplicate entries.
2462
2463 2011-03-14  Alice Liu  <alice.liu@apple.com>
2464
2465         Reviewed by Dan Bernstein.
2466
2467         DumpRenderTree Perl Support fails to build with ARCHS="i386 x86_64"
2468
2469         * DumpRenderTree/mac/PerlSupport/Makefile:
2470         Add whitespace when joining "-arch" with the architectures passed in as arguments.
2471
2472 2011-03-14  Daniel Bates  <dbates@rim.com>
2473
2474         https://bugs.webkit.org/show_bug.cgi?id=55438
2475         Add double quotes around value of -DCMAKE_WINCE_SDK that I inadvertently did not add
2476         when landing changeset 81041 <http://trac.webkit.org/changeset/81041>.
2477
2478         * Scripts/build-webkit:
2479
2480 2011-03-14  Daniel Bates  <dbates@rim.com>
2481
2482         Reviewed by David Kilzer.
2483
2484         Cleanup: Separate port-specific implementation details from webkitdirs::buildCMakeProject()
2485         https://bugs.webkit.org/show_bug.cgi?id=55438
2486
2487         Separate out the EFL- and WinCE-specific logic from the port-independent logic in
2488         webkitdirs::buildCMakeProject(). Also, remove redundant code for generating the
2489         CMake arguments for feature defines.
2490
2491         * Scripts/build-webkit:
2492           - Added cMakeArgsFromFeatures() to convert the @features array to CMake arguments.
2493           - Modified EFL and WinCE-specific building logic to call buildCMakeProjectOrExit().
2494           - Sorted forward declarations.
2495           - Initialize $makeArgs with the empty string so as to simplify its use in string operations;
2496             Modified call sites as needed.
2497         * Scripts/webkitdirs.pm:
2498           - Added cleanCMakeGeneratedProject() to clean a CMake build.
2499           - Added buildCMakeGeneratedProject() to build using generated build system.
2500           - Added buildCMakeProjectOrExit() which is a facade for building a CMake project.
2501           - Added generateBuildSystemFromCMakeProject() to generate the build system from
2502             a CMake project.
2503           - Removed buildCMakeProject(). This functionality is in buildCMakeProjectOrExit().
2504
2505 2011-03-14  John Knottenbelt  <jknotten@chromium.org>
2506
2507         Reviewed by Steve Block.
2508
2509         Detach Geolocation from Frame when Page destroyed.
2510         https://bugs.webkit.org/show_bug.cgi?id=52877
2511
2512         Extend the layout test controller to expose the number of pending
2513         geolocation requests, so that we can test that the requests have
2514         been cancelled on page close.
2515
2516         * DumpRenderTree/LayoutTestController.cpp:
2517         (numberOfPendingGeolocationPermissionRequestsCallback):
2518         (LayoutTestController::staticFunctions):
2519         * DumpRenderTree/LayoutTestController.h:
2520         * DumpRenderTree/chromium/LayoutTestController.cpp:
2521         (LayoutTestController::LayoutTestController):
2522         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2523         * DumpRenderTree/chromium/LayoutTestController.h:
2524         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2525         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2526         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2527         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2528         * DumpRenderTree/mac/UIDelegate.h:
2529         * DumpRenderTree/mac/UIDelegate.mm:
2530         (-[UIDelegate numberOfPendingGeolocationPermissionRequests]):
2531         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2532         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2533         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2534         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2535         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2536         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2537         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2538
2539
2540 2011-03-14  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2541
2542         Unreviewed. Modify my email address in committers.py.
2543
2544         * Scripts/webkitpy/common/config/committers.py:
2545
2546 2011-03-13  Joe Wild  <joseph.wild@nokia.com>
2547
2548         Reviewed by Kenneth Rohde Christiansen.
2549
2550         [Qt] QtLauncher does not load the same set of fonts as the DRT
2551         https://bugs.webkit.org/show_bug.cgi?id=34959
2552
2553         This patch adds the option "-use-test-fonts" to the QtTestBrowser.
2554         When this option is used the webkit fonts are loaded the same
2555         as they are in DumpRenderTree.  This option can be used on
2556         QtTestBrowser and run-launcher.  It can only be used
2557         on Linux systems with FcInit and is configured as such.
2558
2559         * QtTestBrowser/launcherwindow.h:
2560         (WindowOptions::WindowOptions):
2561         * QtTestBrowser/main.cpp:
2562         (initWebKitTestFonts):
2563         (launcherMain):
2564         (LauncherApplication::handleUserOptions):
2565
2566 2011-03-12  Dan Bernstein  <mitz@apple.com>
2567
2568         Reviewed by Mark Rowe.
2569
2570         <rdar://problem/8995822> Build DumpRenderTree perl support only for the architectures
2571         DumpRenderTree is being built for.
2572
2573         * DumpRenderTree/mac/PerlSupport/Makefile:
2574
2575 2011-03-12  Dan Bernstein  <mitz@apple.com>
2576
2577         Suggested by Mark Rowe.
2578
2579         * DumpRenderTree/mac/Configurations/Base.xcconfig: Leave C++ exceptions enabled
2580         as they were before r80915.
2581
2582 2011-03-12  Anders Carlsson  <andersca@apple.com>
2583
2584         Reviewed by Sam Weinig.
2585
2586         Should be able to download a PDF to the Downloads folder
2587         https://bugs.webkit.org/show_bug.cgi?id=56256
2588
2589         * MiniBrowser/mac/BrowserWindowController.m:
2590         (-[BrowserWindowController awakeFromNib]):
2591         * WebKitTestRunner/TestController.cpp:
2592         (WTR::TestController::createOtherPage):
2593         (WTR::TestController::initialize):
2594         Update for API changes.
2595
2596 2011-03-11  Anton D'Auria  <adauria@apple.com>
2597
2598         Reviewed and landed by Brady Eidson.
2599
2600         https://bugs.webkit.org/show_bug.cgi?id=51878
2601         Add WebKit1 API to view and delete local storage
2602
2603         Added tests that write to LocalStorage, delete one origin, get list of origins with local storage, delete all origins.
2604
2605         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2606         * DumpRenderTree/LayoutTestController.cpp:
2607         (syncLocalStorageCallback):
2608         (observeStorageTrackerNotificationsCallback):
2609         (deleteAllLocalStorageCallback):
2610         (deleteLocalStorageForOriginCallback):
2611         (originsWithLocalStorageCallback):
2612         (LayoutTestController::staticFunctions):
2613         * DumpRenderTree/LayoutTestController.h:
2614         * DumpRenderTree/StorageTrackerDelegate.h: Added.
2615         * DumpRenderTree/StorageTrackerDelegate.mm: Added.
2616         (-[StorageTrackerDelegate init]):
2617         (-[StorageTrackerDelegate logNotifications:controller:]):
2618         (-[StorageTrackerDelegate originModified:]):
2619         (-[StorageTrackerDelegate dealloc]):
2620         (-[StorageTrackerDelegate setControllerToNotifyDone:]):
2621         * DumpRenderTree/chromium/LayoutTestController.cpp:
2622         (LayoutTestController::LayoutTestController):
2623         (LayoutTestController::deleteAllLocalStorage):
2624         (LayoutTestController::originsWithLocalStorage):
2625         (LayoutTestController::deleteLocalStorageForOrigin):
2626         (observeStorageTrackerNotifications):
2627         (syncLocalStorage):
2628         * DumpRenderTree/chromium/LayoutTestController.h:
2629         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2630         (LayoutTestController::originsWithLocalStorage):
2631         (LayoutTestController::deleteAllLocalStorage):
2632         (LayoutTestController::deleteLocalStorageForOrigin):
2633         (LayoutTestController::observeStorageTrackerNotifications):
2634         (LayoutTestController::syncLocalStorage):
2635         * DumpRenderTree/mac/DumpRenderTree.mm:
2636         (resetDefaultsToConsistentValues):
2637         (allocateGlobalControllers):
2638         (releaseGlobalControllers):
2639         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2640         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2641         (LayoutTestController::syncLocalStorage):
2642         (LayoutTestController::observeStorageTrackerNotifications):
2643         (LayoutTestController::deleteAllLocalStorage):
2644         (LayoutTestController::originsWithLocalStorage):
2645         (LayoutTestController::deleteLocalStorageForOrigin):
2646         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2647         (LayoutTestController::originsWithLocalStorage):
2648         (LayoutTestController::deleteAllLocalStorage):
2649         (LayoutTestController::deleteLocalStorageForOrigin):
2650         (LayoutTestController::observeStorageTrackerNotifications):
2651         (LayoutTestController::syncLocalStorage):
2652         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2653         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2654         (LayoutTestController::clearAllApplicationCaches):
2655         (LayoutTestController::syncLocalStorage):
2656         (LayoutTestController::observeStorageTrackerNotifications):
2657         (LayoutTestController::clearAllDatabases):
2658         (LayoutTestController::deleteAllLocalStorage):
2659         (LayoutTestController::originsWithLocalStorage):
2660         (LayoutTestController::deleteLocalStorageForOrigin):
2661         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2662         (LayoutTestController::syncLocalStorage):
2663         (LayoutTestController::observeStorageTrackerNotifications):
2664         (LayoutTestController::clearAllDatabases):
2665         (LayoutTestController::deleteAllLocalStorage):
2666         (LayoutTestController::originsWithLocalStorage):
2667         (LayoutTestController::deleteLocalStorageForOrigin):
2668
2669 2011-03-11  Jessie Berlin  <jberlin@apple.com>
2670
2671         Reviewed by Adam Roben.
2672
2673         Crash calling WebContext::clearResourceCaches(InMemoryResourceCachesOnly) before the Web
2674         Process has finished launching.
2675         https://bugs.webkit.org/show_bug.cgi?id=56208
2676
2677         * TestWebKitAPI/Tests/WebKit2/SendingMessagesToTheWebProcessBeforeItIsValid.cpp: Added.
2678         (TestWebKitAPI::TEST):
2679         Test that calling WKContextClearResourceCaches works with both options when called before
2680         the Web Process is valid.
2681
2682         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2683         Add the new test.
2684         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2685         Ditto.
2686
2687 2011-03-11  Adam Roben  <aroben@apple.com>
2688
2689         Make it possible to view all leaks from a build at once in Leaks Viewer
2690
2691         You can now give Leaks Viewer the URL of a build results page (e.g.,
2692         <http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r80847%20(15493)/>), and it
2693         will load all the leaks files from that build.
2694
2695         Fixes <http://webkit.org/b/56030> Leaks Viewer: Would like to be able to look at all leaks
2696         files from a particular build at once, rather than one at a time
2697
2698         Reviewed by David Kilzer.
2699
2700         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksLoader.js: Added.
2701         (LeaksLoader): Initialize our properties.
2702         (LeaksLoader.prototype.start): If the URL ends in .txt, assume it's a single leaks file and
2703         load it. Otherwise assume it's a build results page URL and start fetching the leaks files
2704         from that page.
2705         (LeaksLoader.prototype._loadLeaksFiles): Tell our client how many leaks files we're loading
2706         so it can provide feedback. Then load each one and pass it to the client.
2707         (LeaksLoader.prototype._loadLeaksFromResultsPage): Load the HTML of the results page, parse
2708         it into a DOM, pull out all the links to leaks files, and load each one.
2709
2710         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParser.js: Added.
2711         (LeaksParser): Initialize our worker.
2712         (LeaksParser.prototype.addLeaksFile): Tell the worker about the leaks file's contents.
2713
2714         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js: Added.
2715         This code mostly came from Worker.js.
2716         (LeaksParserWorker): Initialize our profile.
2717         (LeaksParserWorker.prototype.addLeaksFile): Parse the leaks file and incorporate it into our
2718         profile.
2719         (LeaksParserWorker.prototype._parseLeaks):
2720         (LeaksParserWorker.prototype._createNode):
2721         (LeaksParserWorker.prototype._incorporateLeaks):
2722         Moved these functions here from LeaksViewer. _incorporateLeaks is essentially just a renamed
2723         version of createProfile which adds to this.profile instead of making a new profile each
2724         time.
2725         (onmessage): Parse the file and send back the new profile.
2726
2727         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
2728         (#loading-indicator):
2729         (#spinner):
2730         (#loading-indicator-label):
2731         Tweaked styles to accomodate a longer label.
2732
2733         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
2734         (LeaksViewer.loaded): Set up a loader and parser.
2735
2736         (LeaksViewer.get filesLeftToParse):
2737         (LeaksViewer.set filesLeftToParse):
2738         Added these simple accessors.
2739
2740         (LeaksViewer._didCountLeaksFiles): Callback from LeaksLoader. Stores the count.
2741         (LeaksViewer._didLoadLeaksFile): Callback from LeaksLoader. Passes the file contents off to
2742         the parser.
2743         (LeaksViewer._didParseLeaksFile): Callback from LeaksParser. If all files have been parsed,
2744         tell the ProfilerAgent and mark that we're done loading. (Code came from the old
2745         _loadLeaksFromURL function).
2746         (LeaksViewer._loadLeaksFromURL): Now just calls through to the loader.
2747         (LeaksViewer._loadingIndicatorText): Added. Returns the text that should show up in the
2748         loading indicator, including the number of files being loaded.
2749         (LeaksViewer._loadingStatusChanged): Update the loading indicator's label, too.
2750         (LeaksViewer._updateLoadingIndicatorLabel): Added. Just updates the label!
2751         (LeaksViewer._updateTitle): Moved code to compute the "Loading" text to
2752         _loadingIndicatorText.
2753
2754         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js: Added.
2755         (getResource): Moved here from LeaksViewer.js.
2756
2757         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Worker.js: Subsumed by
2758         LeaksParserWorker.js.
2759
2760         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added new JS
2761         files, added a #loading-indicator-label element, and tweaked the prompt wording.
2762
2763 2011-03-11  Adam Roben  <aroben@apple.com>
2764
2765         Don't trigger a build when build.webkit.org's HTML files are modified
2766
2767         Fixes <http://webkit.org/b/56190> Windows bots shouldn't have built r80848/r80851, but did
2768
2769         Reviewed by Dan Bernstein.
2770
2771         * Scripts/webkitpy/common/config/build.py:
2772         (_should_file_trigger_build): Added build.webkit.org's public_html directory to the list of
2773         directories that shouldn't trigger builds. Re-sorted the list.
2774
2775         * Scripts/webkitpy/common/config/build_unittest.py:
2776         (ShouldBuildTest): Added a test to cover the above change.
2777
2778 2011-03-11  Adam Roben  <aroben@apple.com>
2779
2780         Roll out r80848
2781
2782         It was accidentally committed.
2783
2784         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
2785         (LeaksViewer._loadLeaksFromURL):
2786
2787 2011-03-11  Tony Chang  <tony@chromium.org>
2788
2789         Reviewed by Ojan Vafai.
2790
2791         kill hung lighttpd processes on the chromium win bot
2792         https://bugs.webkit.org/show_bug.cgi?id=56152
2793
2794         Sometimes this process doesn't exit and it holds on to
2795         a log file that we can't delete or copy, causing the tests
2796         to go red.
2797
2798         * BuildSlaveSupport/win/kill-old-processes:
2799
2800 2011-03-11  Ilya Sherman  <isherman@chromium.org>
2801
2802         Reviewed by Kent Tamura.
2803
2804         [Chromium] missing HTMLInputElement::setValueForUser() to tests
2805         https://bugs.webkit.org/show_bug.cgi?id=55854
2806
2807         * DumpRenderTree/chromium/LayoutTestController.cpp:
2808         (LayoutTestController::LayoutTestController):
2809         (LayoutTestController::setValueForUser): Added.
2810         * DumpRenderTree/chromium/LayoutTestController.h:
2811
2812 2011-03-10  Peter Kasting  <pkasting@google.com>
2813
2814         Reviewed by Dimitri Glazkov.
2815
2816         Clean up some gross code in TestShellWin.cpp.  No functional change.
2817         https://bugs.webkit.org/show_bug.cgi?id=56048
2818
2819         * DumpRenderTree/chromium/TestShellWin.cpp:
2820         (checkLayoutTestSystemDependencies):
2821
2822 2011-03-10  Keith Kyzivat  <keith.kyzivat@nokia.com>
2823
2824         Reviewed by Laszlo Gombos.
2825
2826         [Qt] Buildfix for platforms where X11 is not available (e.g. Symbian)
2827
2828         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2829         (WTR::activateFonts): Guard X11-specific code with Q_WS_X11.
2830
2831 2011-03-10  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2832
2833         Reviewed by Kenneth Rohde Christiansen.
2834
2835         [EFL] Make single backing store the default for EWebLauncher
2836         https://bugs.webkit.org/show_bug.cgi?id=55753
2837
2838         Set single backing store the default for EWebLauncher.
2839
2840         * EWebLauncher/main.c:
2841         (main):
2842
2843 2011-03-10  Adam Roben  <aroben@apple.com>
2844
2845         Ignore errors from files being held open when creating a test result archive
2846
2847         Fixes <http://webkit.org/b/55581> Test results don't get uploaded if test-result-archive
2848         fails to delete the results directory
2849
2850         Reviewed by Mark Rowe.
2851
2852         * BuildSlaveSupport/test-result-archive:
2853         (archiveTestResults): Ignore errno 2 when deleting the results directory, since it can be
2854         thrown when a process is holding a file open.
2855
2856 2011-03-10  Sheriff Bot  <webkit.review.bot@gmail.com>
2857
2858         Unreviewed, rolling out r80701.
2859         http://trac.webkit.org/changeset/80701
2860         https://bugs.webkit.org/show_bug.cgi?id=56126
2861
2862         fast/dom/Geolocation/window-close-crash.html fails on Snow
2863         Leopard release builds (Requested by mihaip on #webkit).
2864
2865         * DumpRenderTree/LayoutTestController.cpp:
2866         (LayoutTestController::staticFunctions):
2867         * DumpRenderTree/LayoutTestController.h:
2868         * DumpRenderTree/chromium/LayoutTestController.cpp:
2869         (LayoutTestController::LayoutTestController):
2870         * DumpRenderTree/chromium/LayoutTestController.h:
2871         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2872         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2873         * DumpRenderTree/mac/UIDelegate.h:
2874         * DumpRenderTree/mac/UIDelegate.mm:
2875         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2876         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2877         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2878         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2879
2880 2011-03-10  Philippe Normand  <pnormand@igalia.com>
2881
2882         Reviewed by Gustavo Noronha Silva.
2883
2884         [GTK] run-gtk-tests doesn't fail if a test crashes
2885         https://bugs.webkit.org/show_bug.cgi?id=56089
2886
2887         * Scripts/run-gtk-tests: gtester -k exits with a 0 exit status
2888         even if a test crashes. So run the tests individually and if a
2889         test fails remember its exit code so run-gtk-test fails too, if
2890         required.
2891
2892 2011-01-26  John Knottenbelt  <jknotten@chromium.org>
2893
2894         Reviewed by Dmitry Titov.
2895
2896         Detach Geolocation from Frame when Page destroyed.
2897         https://bugs.webkit.org/show_bug.cgi?id=52877
2898
2899         Extend the layout test controller to expose the number of pending
2900         geolocation requests, so that we can test that the requests have
2901         been cancelled on page close.
2902
2903         * DumpRenderTree/LayoutTestController.cpp:
2904         (numberOfPendingGeolocationPermissionRequestsCallback):
2905         (LayoutTestController::staticFunctions):
2906         * DumpRenderTree/LayoutTestController.h:
2907         * DumpRenderTree/chromium/LayoutTestController.cpp:
2908         (LayoutTestController::LayoutTestController):
2909         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2910         * DumpRenderTree/chromium/LayoutTestController.h:
2911         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2912         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2913         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2914         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2915         * DumpRenderTree/mac/UIDelegate.h:
2916         * DumpRenderTree/mac/UIDelegate.mm:
2917         (-[UIDelegate numberOfPendingGeolocationPermissionRequests]):
2918         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2919         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2920         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2921         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2922         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2923         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2924         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2925
2926
2927 2011-03-09  Adam Roben  <aroben@apple.com>
2928
2929         Hide Leaks Viewer's URL prompt by default
2930
2931         We will show it as needed. I think I left it visible by default by accident after doing some
2932         testing.
2933
2934         Fixes <http://webkit.org/b/56031> Leaks Viewer: URL prompt overlay shouldn't appear when a
2935         URL is passed as a query parameter, but does
2936
2937         Reviewed by Simon Fraser.
2938
2939         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html:
2940
2941 2011-03-09  Adam Roben  <aroben@apple.com>
2942
2943         Don't use Element.classList or box-shadow in Leaks Viewer
2944
2945         They aren't supported by Safari 5. Luckily we have substitutes for them!
2946
2947         Fixes <http://webkit.org/b/56035> Leaks viewer doesn't work in Safari 5
2948
2949         Reviewed by Simon Fraser.
2950
2951         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
2952         (#url-prompt): Use -webkit-box-shadow instead of box-shadow.
2953
2954         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
2955         (LeaksViewer.urlPromptButtonClicked):
2956         (LeaksViewer._displayURLPrompt):
2957         (LeaksViewer._setLoadingIndicatorHidden):
2958         Use add/removeStyleClass (from utilities.js) instead of Element.classList.
2959
2960 2011-03-09  Adam Roben  <aroben@apple.com>
2961
2962         Add a link to the Leaks Viewer tool on the build.webkit.org homepage
2963
2964         Rubber-stamped by David Kilzer.
2965
2966         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2967
2968 2011-03-09  Adam Roben  <aroben@apple.com>
2969
2970         Add a Leaks Viewer tool to build.webkit.org
2971
2972         This tool parses leaks from the files generated by the leaks bot and displays them in a
2973         view similar to the Web Inspector's Profiles pane (in fact, it uses the Web Inspector's
2974         code).
2975
2976         The URL of the leaks file can be entered in a prompt when the tools is first shown, or can
2977         be passed to the tool via the "url" query parameter.
2978
2979         Only one leaks file can be viewed at a time for now. Only the number of leaks, as opposed to
2980         the number of leaked bytes, is shown. And this tool has made apparent some bugs in the Web
2981         Inspector's Heavy profile view. But it's still pretty useful as-is.
2982
2983         Fixes <http://webkit.org/b/56028> Would like a Shark-like tool for viewing leaks from leak bots
2984
2985         Reviewed by Darin Adler.
2986
2987         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css: Added.
2988         (#url-prompt-container): This is the dark overlay that is shown behind the URL prompt.
2989         (#url-prompt): This is the prompt itself.
2990
2991         (#loading-indicator):
2992         (#loading-indicator > img):
2993         These show a spinner in the bottom-right when we're loading a leaks file.
2994
2995         (.percent-time-status-bar-item): Hide the Percent button since we never want to show leaks
2996         as percentages.
2997
2998         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js: Added.
2999         (LeaksViewer.loaded): Initialize ourselves and start loading the leaks file (or prompt for a
3000         URL if one wasn't given to us as a query parameter).
3001
3002         (LeaksViewer.get loading):
3003         (LeaksViewer.set loading):
3004         (LeaksViewer.get url):
3005         (LeaksViewer.set url):
3006         Pretty simple accessors.
3007
3008         (LeaksViewer.urlPromptButtonClicked): Start loading the URL from the prompt and hide the
3009         prompt.
3010         (LeaksViewer._displayURLPrompt): Show the prompt and focus the URL input.
3011         (LeaksViewer._loadLeaksFromURL): Start fetching the leaks file. When we've retrieved the
3012         file, hand it off to a Web Worker that will parse it into a fake "profile", then hand off
3013         the profile to the Web Inspector code once it's been created.
3014         (LeaksViewer._loadingStatusChanged): Update our loading indicator and title.
3015         (LeaksViewer._setLoadingIndicatorHidden): Simply hide or show the indicator.
3016         (LeaksViewer._updateTitle): Set our title based on our URL and loading status.
3017         (getResource): Helper function to fetch a resource via XHR and pass it to a callback.
3018
3019         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js: Added.
3020         (WebInspector.UIString): Just a simple implementation since this tool isn't localized.
3021         (ProfilerAgent.getProfile): Store the callback.
3022         (ProfilerAgent.profileReady): Call the callback.
3023         (monkeyPatchInspectorObjects): Fix up WebInspector.ProfileDataGridNode to show the self leak
3024         count and total leak counts as real values, not percentages or milliseconds.
3025
3026         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Worker.js: Added.
3027         (onmessage): Create a profile based on the leaks file and pass it back to our caller.
3028         (parseLeaks): Extract call stacks out of a leaks file.
3029         (createNode): Helper function to create a new empty profile node.
3030         (createProfile): Take the leak stacks and turn them into a fake "profile" for consumption by
3031         WebInspector.ProfileView.
3032
3033         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added.
3034
3035 2011-03-09  Dan Bernstein  <mitz@apple.com>
3036
3037         Reviewed by Adam Roben.
3038
3039         Combine multiple --ignore-tests values
3040         https://bugs.webkit.org/show_bug.cgi?id=56016
3041
3042         * Scripts/old-run-webkit-tests:
3043
3044 2011-03-08  Kenji Imasaki  <imasaki@chromium.org>
3045
3046         Reviewed by David Levin.
3047
3048         Adding myself to the committer file.
3049
3050         * Scripts/webkitpy/common/config/committers.py:
3051
3052 2011-03-08  Jessie Berlin  <jberlin@apple.com>
3053
3054         Rubber-stamped by Adam Roben.
3055
3056         Fix two leaks I introduced into the API tests.
3057
3058         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
3059         (TestWebKitAPI::TEST):
3060
3061 2011-03-08  Jessie Berlin  <jberlin@apple.com>
3062
3063         Reviewed by Anders Carlsson.
3064
3065         Crash in CFNetwork visiting google.com
3066         https://bugs.webkit.org/show_bug.cgi?id=55958
3067
3068         Add a test for not trying to copy a null CFURLResponse.
3069
3070         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp: Added.
3071         (TestWebKitAPI::TEST):
3072         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3073
3074 2011-03-08  Hayato Ito  <hayato@chromium.org>
3075
3076         Reviewed by Ojan Vafai.
3077
3078         [NRWT] Renamed a FailureWithType class to a ComparisonTestFailure class.
3079
3080         FailureWithType is a confusing naming because we have removed test_type/* classes in r79840.
3081
3082         https://bugs.webkit.org/show_bug.cgi?id=55450
3083
3084         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3085
3086 2011-03-08  Carlos Garcia Campos  <cgarcia@igalia.com>
3087
3088         Reviewed by Martin Robinson.
3089
3090         [GTK] Add layoutTestController.setValueForUser() after r80412
3091         https://bugs.webkit.org/show_bug.cgi?id=55862
3092
3093         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3094         (LayoutTestController::setValueForUser): Implement setValueForUser()
3095
3096 2011-03-08  Patrick Gansterer  <paroga@webkit.org>
3097
3098         Reviewed by Adam Barth.
3099
3100         Add script_shell_command to WebKitPort
3101         https://bugs.webkit.org/show_bug.cgi?id=55925
3102
3103         Add a central place where we generate the shell command from the script name.
3104         This function will be used later to detect the correct script interpreter on Win32.
3105
3106         * Scripts/webkitpy/common/config/ports.py:
3107         * Scripts/webkitpy/layout_tests/port/base.py:
3108         * Scripts/webkitpy/tool/steps/abstractstep.py:
3109         * Scripts/webkitpy/tool/steps/preparechangelog.py:
3110
3111 2011-03-07  Ojan Vafai  <ojan@chromium.org>
3112
3113         Reviewed by Adam Barth.
3114
3115         add webkit-patch attach-to-bug for posting to bugzilla from the commandline
3116         https://bugs.webkit.org/show_bug.cgi?id=55749
3117
3118         * Scripts/webkitpy/tool/commands/upload.py:
3119         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3120         * Scripts/webkitpy/tool/steps/__init__.py:
3121         * Scripts/webkitpy/tool/steps/attachtobug.py: Added.
3122         * Scripts/webkitpy/tool/steps/options.py:
3123
3124 2011-03-07  Daniel Cheng  <dcheng@chromium.org>
3125
3126         Reviewed by David Levin.
3127
3128         Add support for DataTransferItems
3129         https://bugs.webkit.org/show_bug.cgi?id=55115
3130
3131         Enable data transfer items in DRT.
3132
3133         * DumpRenderTree/chromium/TestShell.cpp:
3134         (TestShell::TestShell):
3135
3136 2011-03-06  Ojan Vafai  <ojan@chromium.org>
3137
3138         Reviewed by Tony Chang.
3139
3140         [test dashboard] pull treemap files
3141         https://bugs.webkit.org/show_bug.cgi?id=55852
3142
3143         * TestResultServer/handlers/dashboardhandler.py:
3144
3145 2011-03-03  Hayato Ito  <hayato@chromium.org>
3146
3147         Reviewed by Mihai Parparita.
3148
3149         [NRWT] Clear output image file used by DumpRenderTree to make sure the
3150         previous image should not be used in the ChromiumDriver.
3151
3152         Also make sure that output image from the ChromiumDriver should be ''
3153         (empty string) if a test crashes for consistency with the WebKitDriver
3154         implementation.
3155
3156         https://bugs.webkit.org/show_bug.cgi?id=55746
3157
3158         * Scripts/webkitpy/layout_tests/port/chromium.py:
3159
3160 2011-03-07  Zan Dobersek  <zandobersek@gmail.com>
3161
3162         Reviewed by Martin Robinson.
3163
3164         [Gtk] fast/js/navigator-language.html fails locally
3165         https://bugs.webkit.org/show_bug.cgi?id=55880
3166
3167         Add LANG variable to the clean environment when running
3168         old-run-webkit-tests script.
3169
3170         * Scripts/old-run-webkit-tests:
3171
3172 2011-03-07  Tony Chang  <tony@chromium.org>
3173
3174         Reviewed by Mihai Parparita.
3175
3176         [Chromium] Find .checksum files without .pngs and vice-versa
3177         https://bugs.webkit.org/show_bug.cgi?id=55236
3178
3179         * Scripts/find-mismatched-layout-test-results: Added. A script for finding
3180             mismatched results.
3181
3182 2011-03-07  Chris Fleizach  <cfleizach@apple.com>
3183
3184         Reviewed by Beth Dakin.
3185
3186         AX: WK1 needs to use the ScrollView attachment for AXScrollArea, WK2 should not use this element.
3187         https://bugs.webkit.org/show_bug.cgi?id=55706
3188
3189         The rootElement in DRT should point to the scroll view. In WK1, that will be the parent of the rootObject.
3190
3191         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3192         (AccessibilityController::focusedElement):
3193            Remove FIXME comment about caching the focusedElement. In fact, we shouldn't cache this 
3194            because it could change at any time.
3195         (AccessibilityController::rootElement):
3196
3197 2011-03-07  Sam Weinig  <sam@webkit.org>
3198
3199         Reviewed by Anders Carlsson.
3200
3201         Add unableToImplementPolicy callback for WebKit2 policy client
3202         <rdar://problem/9071902>
3203         https://bugs.webkit.org/show_bug.cgi?id=55884
3204
3205         * MiniBrowser/mac/BrowserWindowController.m:
3206         (-[BrowserWindowController awakeFromNib]):
3207         Update policy client initialization struct for new member.
3208
3209 2011-03-07  Sam Weinig  <sam@webkit.org>
3210
3211         Reviewed by Anders Carlsson.
3212
3213         Replace WebKit2's decidePolicyForMIMEType with decidePolicyForResponse
3214         https://bugs.webkit.org/show_bug.cgi?id=55827
3215
3216         * MiniBrowser/mac/BrowserWindowController.m:
3217         (decidePolicyForResponse):
3218         (-[BrowserWindowController awakeFromNib]):
3219         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
3220         (TestWebKitAPI::decidePolicyForResponse):
3221         (TestWebKitAPI::TEST):
3222         Update tools for new name.
3223
3224 2011-03-06  Daniel Bates  <dbates@rim.com>
3225
3226         Reviewed by Eric Seidel and David Kilzer.
3227
3228         Fix misspelled word in build-webkit's checkForJavaSDK() and sort forward declarations
3229         https://bugs.webkit.org/show_bug.cgi?id=55503
3230
3231         Fix misspelled word "Dowloads" [sic] in the message printed to standard output
3232         in checkForJavaSDK().
3233
3234         Also, remove extraneous space in function prototype for unlinkZeroFiles.
3235
3236         * Scripts/build-webkit:
3237
3238 2011-03-05  Brian Weinstein  <bweinstein@apple.com>
3239
3240         Reviewed by Sam Weinig.
3241
3242         Fix Web Process crashes caused by https://bugs.webkit.org/show_bug.cgi?id=53919.
3243
3244         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3245         (WTR::InjectedBundlePage::willSendRequestForFrame): Retain the WKURLRequestRef returned
3246             by willSendRequestForFrame. The API expects a retained reference to the URL request.
3247
3248 2011-03-05  Ilya Sherman  <isherman@chromium.org>
3249
3250         Reviewed by Darin Adler.
3251
3252         HTMLInputElement::setValue() should schedule change event when the element is focused
3253         In service of https://code.google.com/p/chromium/issues/detail?id=42716
3254         https://bugs.webkit.org/show_bug.cgi?id=53160
3255
3256         * DumpRenderTree/LayoutTestController.cpp:
3257         (setValueForUserCallback):
3258         (LayoutTestController::staticFunctions):
3259         * DumpRenderTree/LayoutTestController.h:
3260         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3261         (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
3262         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3263         (LayoutTestController::setValueForUser): Expose HTMLInputElement::setValueForUser() to tests
3264         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3265         (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
3266         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3267         (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
3268         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3269         (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
3270
3271 2011-03-04  Mark Rowe  <mrowe@apple.com>
3272
3273         Reviewed by Alexey Proskuryakov.
3274
3275         <rdar://problem/9055252> DumpRenderTree is crashing with GuardMalloc
3276
3277         GuardMalloc does not expect the memory containing its malloc_zone_t to ever be read-only.
3278         
3279         * DumpRenderTree/mac/CheckedMalloc.cpp:
3280         (protectionOfRegion): Retrieve the protection flags for the VM region containing the given address.
3281         (makeLargeMallocFailSilently): Save the initial protection flags, temporarily make the region writeable,
3282         and then restore the initial protection flags when we're done.
3283
3284 2011-03-04  Evan Martin  <evan@chromium.org>
3285
3286         Reviewed by Tony Chang.
3287
3288         [gdb] pretty-print KURL in gdb
3289         https://bugs.webkit.org/show_bug.cgi?id=55788
3290
3291         * gdb/webkit.py: extend the pretty-printers to print WTF::CString
3292         and KURLGooglePrivate.  As always, "p/r" can be used to sidestep
3293         pretty-printing.
3294
3295 2011-03-03  Timothy Hatcher  <timothy@apple.com>
3296
3297         Update the tests that use WKPageRunJavaScriptInMainFrame use the WKSerializedScriptValueRef.
3298
3299         Reviewed by Darin Adler.
3300
3301         * TestWebKitAPI/JavaScriptTest.cpp:
3302         (TestWebKitAPI::javaScriptCallback):
3303         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
3304         (TestWebKitAPI::didRunJavaScript):
3305         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
3306         (TestWebKitAPI::nullJavaScriptCallback):
3307         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
3308         (TestWebKitAPI::didRunJavaScript):
3309
3310 2011-03-03  Timothy Hatcher  <timothy@apple.com>
3311
3312         Make run-api-tests show failed if a test fails.
3313
3314         https://webkit.org/b/55725
3315
3316         Reviewed by Sam Weinig.
3317
3318         * Scripts/run-api-tests:
3319         (runTest): Remove "my" from the nested $result assignment so the
3320         check outside the condition sees the real result.
3321
3322 2011-03-02  MORITA Hajime  <morrita@google.com>
3323
3324         Reviewed by Kent Tamura.
3325
3326         [Chromium][DRT] WebTask should use webkit_support::TaskAdaptor
3327         https://bugs.webkit.org/show_bug.cgi?id=55434
3328
3329         Changed WebTask to be a subclass of webkit_support::TaskAdaptor
3330         and passed the object webkit_support::PostDelayedTask directly.
3331
3332         Note that the change keeps postTask() as is because it has a
3333         semantics taht webkit_support::PostDelayedTask() has; It jumps to
3334         the main thread.
3335
3336         * DumpRenderTree/chromium/Task.cpp:
3337         (postDelayedTask):
3338         * DumpRenderTree/chromium/Task.h:
3339         (WebTask::Run):
3340
3341 2011-03-03  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
3342
3343         Reviewed by Kenneth Rohde Christiansen.
3344
3345         [QT] Implement mock client-based geolocation for layout testing
3346         https://bugs.webkit.org/show_bug.cgi?id=54334
3347
3348         Implement testing for Client-Based geolocation for QtWebkit.
3349
3350         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3351         (WebCore::DumpRenderTree::DumpRenderTree):
3352         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3353         (LayoutTestController::reset):
3354         (LayoutTestController::setGeolocationPermission):
3355         (LayoutTestController::setMockGeolocationError):
3356         (LayoutTestController::setMockGeolocationPosition):
3357
3358 2011-03-03  Sheriff Bot  <webkit.review.bot@gmail.com>
3359
3360         Unreviewed, rolling out r80237.
3361         http://trac.webkit.org/changeset/80237
3362         https://bugs.webkit.org/show_bug.cgi?id=55714
3363
3364         Windows bots aren't ready to be core (Requested by aroben on
3365         #webkit).
3366
3367         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3368         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3369
3370 2011-03-03  Mihai Parparita  <mihaip@chromium.org>
3371
3372         Reviewed by Tony Chang.
3373
3374         NRWT: AttributeError: TestRunner2 instance has no attribute '_cancel_workers'
3375         https://bugs.webkit.org/show_bug.cgi?id=55694
3376         
3377         Fixes for interruptions in NRWT:
3378         - Make TestRunInterruptedException be pickleable correctly (the base
3379           Exception class defines a __reduce__ that does not include the reason)
3380         - Fix ordering of returned arguments from TestRunner2._run_tests
3381           (interrupted and keyboard_interrupted were reversed)
3382         - Fix cancel_workers callsites (was using old name).
3383         - In handle_exception re-raise actual exception instance that was thrown
3384
3385         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3386         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
3387         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
3388         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3389
3390 2011-03-03  Qi Zhang  <qi.2.zhang@nokia.com>
3391
3392         Unreviewed.
3393
3394         Adding myself as a committer.
3395
3396         * Scripts/webkitpy/common/config/committers.py:
3397
3398 2011-03-03  Tony Gentilcore  <tonyg@chromium.org>
3399
3400         Reviewed by Mihai Parparita.
3401
3402         Teach sheriffbot to answer whois commands
3403         https://bugs.webkit.org/show_bug.cgi?id=55687
3404
3405         * Scripts/webkitpy/tool/bot/irc_command.py:
3406         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3407         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
3408
3409 2011-03-03  Victoria Kirst  <vrk@google.com>
3410
3411         Reviewed by Eric Carlson.
3412
3413         Enable media tests in chromium-gpu/test_expectations
3414         https://bugs.webkit.org/show_bug.cgi?id=53608
3415
3416         Add media folder to the list of GPU test paths.
3417
3418         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3419
3420 2011-03-03  Adam Roben  <aroben@apple.com>
3421
3422         Work around a bug in KURL's parsing of Windows-style absolute file: URLs
3423
3424         Fixes <http://webkit.org/b/55674> Many tests fail in WebKit2 mode on Windows due to
3425         incorrect parsing of absolute Windows-style file: URLs
3426
3427         Reviewed by Tim Hatcher.
3428
3429         * WebKitTestRunner/TestInvocation.cpp:
3430         (WTR::createWKURL): Add a "localhost" host to file: URLs we create to work around
3431         <http://webkit.org/b/55683>.
3432
3433 2011-03-03  Tony Chang  <tony@chromium.org>
3434
3435         Reviewed by Dimitri Glazkov.
3436
3437         [chromium] Run kill-old-processes on the chromium-win bot too
3438         https://bugs.webkit.org/show_bug.cgi?id=55630
3439
3440         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3441         * BuildSlaveSupport/win/kill-old-processes: Add wdiff.exe to the kill list.
3442
3443 2011-03-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3444
3445         Reviewed by Martin Robinson.
3446
3447         [GTK] DRT needs implementation of EventSender.scheduleAsynchronousClick
3448         https://bugs.webkit.org/show_bug.cgi?id=53960
3449
3450         * DumpRenderTree/gtk/EventSender.cpp:
3451         (sendClick):
3452         (scheduleAsynchronousClickCallback):
3453
3454 2011-03-03  Adam Roben  <aroben@apple.com>
3455
3456         Look for Windows-style paths when checking whether a test is an Inspector test
3457
3458         WTR part of <http://webkit.org/b/55672> <rdar://problem/9080867> All inspector tests time
3459         out or crash on Windows 7 Release (WebKit2 Tests)
3460
3461         Reviewed by Darin Adler.
3462
3463         * WebKitTestRunner/TestInvocation.cpp:
3464         (WTR::shouldOpenWebInspector): Also look for backslashes, since that's what we'll get on
3465         Windows.
3466
3467 2011-03-03  Adam Roben  <aroben@apple.com>
3468
3469         Make Windows 7 Release (Tests) a core builder
3470
3471         We can probably make Windows XP Debug (Tests) a core builder, too, but we should probably
3472         give it a few more days of greenness first.
3473
3474         Fixes <http://webkit.org/b/55665> Windows 7 Release (Tests) should be a core builder
3475
3476         Reviewed by Andreas Kling.
3477
3478         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3479         (BuildBot): Added a regexp to match Windows 7 Release (Tests).
3480
3481         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3482         (BuildBotTest): Updated the list of builders to match the current list on build.webkit.org.
3483         Updated the core regexps to match the buildbot module. Updated the expected results to match
3484         the current set of core builders.
3485
3486 2011-03-03  Benjamin Poulain  <benjamin.poulain@nokia.com>
3487
3488         Reviewed by Andreas Kling.
3489
3490         Adding myself as a reviewer.
3491
3492         * Scripts/webkitpy/common/config/committers.py:
3493
3494 2011-03-03  Lukasz Slachciak  <l.slachciak@samsung.com>
3495
3496         Reviewed by Xan Lopez.
3497
3498         [GTK] Extended application cache database API and added unit tests file.
3499         https://bugs.webkit.org/show_bug.cgi?id=55335
3500
3501         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: removed external declaration
3502         of webkit_application_cache_set_maximum_size due to API exposal.
3503
3504 2011-03-02  Ojan Vafai  <ojan@chromium.org>
3505
3506         Reviewed by Adam Barth.
3507
3508         make webkit-patch upload work for security bugs
3509         https://bugs.webkit.org/show_bug.cgi?id=55655
3510
3511         The problem is that we shell out to prepare-ChangeLog,
3512         which does not authenticate with bugzilla. All it needs from
3513         bugzilla is the bug title though. We just pass it through from
3514         webkit-patch instead.
3515
3516         * Scripts/prepare-ChangeLog:
3517         * Scripts/webkitpy/common/net/bugzilla/bug.py:
3518         * Scripts/webkitpy/tool/steps/preparechangelog.py:
3519
3520 2011-03-01  Ojan Vafai  <ojan@chromium.org>
3521
3522         Reviewed by Tony Chang.
3523
3524         [test-dashboard] make gtest JSON match layout-tests JSON
3525         https://bugs.webkit.org/show_bug.cgi?id=55556
3526
3527         http://trac.webkit.org/changeset/80090 stopped converting time_ms to t.
3528         Make this code match.
3529
3530         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3531
3532 2011-03-02  Dirk Pranke  <dpranke@chromium.org>
3533
3534         Reviewed by Tony Chang.
3535
3536         NRWT - implement Linux Hardy 64-bit port support. This involves
3537         adding support for non-'x86' architectures and updating the
3538         "deduplicate_tests" script to correctly understand that
3539         port.name() is not always equal to basename(port.baseline_path()).
3540
3541         This change introduces two new port names: 'chromium-linux-x86'
3542         and 'chromium-linux-x86_64'. Using the prior 'chromium-linux'
3543         flag will cause the code to determine which one to use at
3544         runtime, just like we currently do with 'chromium-win'.
3545
3546         https://bugs.webkit.org/show_bug.cgi?id=55535
3547
3548         * Scripts/webkitpy/common/system/executive_mock.py:
3549           Handle 'return_stderr' keyword arg to run_command()
3550         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
3551         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
3552         * Scripts/webkitpy/layout_tests/port/base.py:
3553         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3554         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
3555         * Scripts/webkitpy/layout_tests/port/factory.py:
3556         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
3557
3558 2011-03-02  Kevin Ollivier  <kevino@theolliviers.com>
3559
3560         [wx] Build fix, make sure we put the wxWebKit dylib in the right directory and
3561         update symlinks accordingly.
3562
3563         * wx/packaging/build-mac-installer.py:
3564
3565 2011-03-02  Sheriff Bot  <webkit.review.bot@gmail.com>
3566
3567         Unreviewed, rolling out r80139.
3568         http://trac.webkit.org/changeset/80139
3569         https://bugs.webkit.org/show_bug.cgi?id=55620
3570
3571         failing and crashing tests on Snow Leopard bot (Requested by
3572         mihaip1 on #webkit).
3573
3574         * DumpRenderTree/LayoutTestController.cpp:
3575         (LayoutTestController::staticFunctions):
3576         * DumpRenderTree/LayoutTestController.h:
3577         * DumpRenderTree/chromium/LayoutTestController.cpp:
3578         (LayoutTestController::LayoutTestController):
3579         * DumpRenderTree/chromium/LayoutTestController.h:
3580         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3581         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3582         * DumpRenderTree/mac/UIDelegate.h:
3583         * DumpRenderTree/mac/UIDelegate.mm:
3584         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3585         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3586         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3587         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3588
3589 2011-03-02  Adam Roben  <aroben@apple.com>
3590
3591         Wait for force a paint in WebKitTestRunner until we're actually ready to dump the output
3592
3593         This matches DumpRenderTree on Windows.
3594
3595         Fixes <http://webkit.org/b/55469> <rdar://problem/9068539> REGRESSION (r79863): Lots of
3596         dom/html/level2/html/HTMLFrameElement*.html tests crashing in FrameView::paintOverhangAreas
3597         in WebKit2
3598
3599         Reviewed by Beth Dakin.
3600
3601         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3602         (WTR::InjectedBundlePage::dump): Moved code to force a paint here...
3603         (WTR::InjectedBundlePage::didFinishLoadForFrame): ...from here.
3604
3605 2011-03-02  Daniel Cheng  <dcheng@chromium.org>
3606
3607         Reviewed by David Levin.
3608
3609         Add feature define for data transfer items
3610         https://bugs.webkit.org/show_bug.cgi?id=55510
3611
3612         * Scripts/build-webkit:
3613
3614 2011-03-02  Adam Roben  <aroben@apple.com>
3615
3616         Look in the new-to-SnowLeopard location for crash logs on SnowLeopard and newer
3617
3618         ReportCrash saves logs to ~/Library/Logs/CrashReporter on Leopard, but to
3619         ~/Library/Logs/DiagnosticReports on SnowLeopard. old-run-webkit-tests was only looking in
3620         the former location, but was getting lucky on some SnowLeopard machines because symlinks
3621         were being created there pointing into DiagnosticReports. For machines without these
3622         symlinks, crash logs were not getting captured.
3623
3624         Fixes <http://webkit.org/b/55607> old-run-webkit-tests doesn't capture crash logs on some
3625         SnowLeopard machines
3626
3627         Reviewed by Eric Seidel.
3628
3629         * Scripts/old-run-webkit-tests:
3630         (captureSavedCrashLog): Look in ~/Library/Logs/DiagnosticReports on SnowLeopard and newer.
3631
3632 2011-03-02  Adam Roben  <aroben@apple.com>
3633
3634         Don't try to capture crash logs on platforms that haven't implemented that feature
3635
3636         Fixes <http://webkit.org/b/55504> Use of uninitialized value in numeric lt (<) at
3637         Tools/Scripts/old-run-webkit-tests line 1778 seen on Qt bots after a crash
3638
3639         Reviewed by Joseph Pecoraro.
3640
3641         * Scripts/old-run-webkit-tests:
3642         (captureSavedCrashLog): Bail if we don't have a crash log glob.