REGRESSION(r244162) Clearing website data from ephemeral WKWebsiteDataStore should...
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-16  Alex Christensen  <achristensen@webkit.org>
2
3         REGRESSION(r244162) Clearing website data from ephemeral WKWebsiteDataStore should finish instead of asserting or hanging
4         https://bugs.webkit.org/show_bug.cgi?id=196995
5
6         Reviewed by Brady Eidson.
7
8         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
9         (TEST):
10
11 2019-04-16  Chris Dumez  <cdumez@apple.com>
12
13         URL set by document.open() is not communicated to the UIProcess
14         https://bugs.webkit.org/show_bug.cgi?id=196941
15         <rdar://problem/49237544>
16
17         Reviewed by Geoff Garen.
18
19         Add API test coverage.
20
21         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
22         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
23         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
24         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
25         (TEST):
26
27 2019-04-16  Commit Queue  <commit-queue@webkit.org>
28
29         Unreviewed, rolling out r244321.
30         https://bugs.webkit.org/show_bug.cgi?id=196968
31
32         Causing all WK2 Debug builds to exit early after Assertion
33         failures. (Requested by ShawnRoberts on #webkit).
34
35         Reverted changeset:
36
37         "URL set by document.open() is not communicated to the
38         UIProcess"
39         https://bugs.webkit.org/show_bug.cgi?id=196941
40         https://trac.webkit.org/changeset/244321
41
42 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
43
44         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
45         https://bugs.webkit.org/show_bug.cgi?id=196948
46
47         Reviewed by Zalan Bujtas.
48
49         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
50         (TEST): Disabling the test for now to keep infrastructure happy, while the root-cause is being investigated.
51
52 2019-04-15  Chris Dumez  <cdumez@apple.com>
53
54         URL set by document.open() is not communicated to the UIProcess
55         https://bugs.webkit.org/show_bug.cgi?id=196941
56         <rdar://problem/49237544>
57
58         Reviewed by Geoffrey Garen.
59
60         Add API test coverage.
61
62         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
63         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
64         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
65         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
66         (TEST):
67
68 2019-04-15  Dean Johnson  <dean_johnson@apple.com>
69
70         Using Tools/Scripts/clean-webkit should not install requests
71         https://bugs.webkit.org/show_bug.cgi?id=196940
72
73         Reviewed by Lucas Forschler.
74
75         * Scripts/webkitpy/common/system/autoinstall.py: Drive-by fix for no logging handlers
76         existing, depending on the path autoinstalled is run through.
77         * Scripts/webkitpy/port/base.py: Import webkitpy.results.upload.Upload only where it's
78         needed.
79         (Port.configuration_for_upload):
80         (Port.commits_for_upload):
81
82 2019-04-15  Alex Christensen  <achristensen@webkit.org>
83
84         Add a DiagnosticLogging method taking an arbitrary dictionary of values.
85         https://bugs.webkit.org/show_bug.cgi?id=196773
86
87         Reviewed by Jer Noble.
88
89         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDiagnosticLogging.mm:
90         (-[TestLoggingDelegate _webView:logDiagnosticMessage:description:valueDictionary:]):
91         (TEST):
92
93 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
94
95         ews-build should clearly indicate flaky test failures
96         https://bugs.webkit.org/show_bug.cgi?id=196947
97
98         Reviewed by Lucas Forschler.
99
100         * BuildSlaveSupport/ews-build/steps.py:
101         (AnalyzeAPITestsResults.analyzeResults):
102
103 2019-04-15  Brent Fulgham  <bfulgham@apple.com>
104
105         InjectedBundle parameters often need initialization function called before unarchiving
106         https://bugs.webkit.org/show_bug.cgi?id=189709
107         <rdar://problem/44573653>
108
109         Reviewed by Ryosuke Niwa.
110
111         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
112         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
113
114 2019-04-12  Ryosuke Niwa  <rniwa@webkit.org>
115
116         HashTable::removeIf always shrinks the hash table by half even if there is nothing left
117         https://bugs.webkit.org/show_bug.cgi?id=196681
118
119         Reviewed by Darin Adler.
120
121         Added tests.
122
123         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
124         (WTF_HashSet.RemoveIf):
125         (WTF_HashSet.RemoveIfShrinkToBestSize):
126
127 2019-04-15  John Wilander  <wilander@apple.com>
128
129         Send delayed Ad Click Attribution conversion requests to the click source
130         https://bugs.webkit.org/show_bug.cgi?id=196838
131         <rdar://problem/47650157>
132
133         Reviewed by Chris Dumez and Youenn Fablet.
134
135         This patch adds test infrastructure to override the default behavior in
136         WebKit::NetworkAdClickAttribution.
137
138         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
139         (TestWebKitAPI::TEST):
140         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
141         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
142         (WTR::TestRunner::dumpAdClickAttribution):
143         (WTR::TestRunner::clearAdClickAttribution):
144         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
145         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
146         * WebKitTestRunner/InjectedBundle/TestRunner.h:
147         * WebKitTestRunner/TestController.cpp:
148         (WTR::TestController::setAdClickAttributionOverrideTimerForTesting):
149         (WTR::TestController::setAdClickAttributionConversionURLForTesting):
150         * WebKitTestRunner/TestController.h:
151         * WebKitTestRunner/TestInvocation.cpp:
152         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
153
154 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
155
156         [ews-app] status-bubble should display position in queue
157         https://bugs.webkit.org/show_bug.cgi?id=196607
158
159         Reviewed by Lucas Forschler.
160
161         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
162         (StatusBubble._build_bubble):
163         (StatusBubble._queue_position): Method to calculate patch's position in queue.
164
165 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
166
167         [ews-build] Do not run clean build by default on EWS builders
168         https://bugs.webkit.org/show_bug.cgi?id=196897
169
170         Reviewed by Lucas Forschler.
171
172         * BuildSlaveSupport/ews-build/steps.py:
173         (ApplyPatch.start): Do not create .buildbot-patched file. This is a special file for Buildbot and if this
174         file is present, during the Source checkout, Buildbot cleans the working directory completely (including removing 
175         untracked directories like WebKitBuild).
176         (CheckOutSource.__init__): Pass method=clean so that Buildbot clean the working directory. This does not remove
177         untracked files/directories (like WebKitBuild).
178
179 2019-04-15  Per Arne Vollan  <pvollan@apple.com>
180
181         TestRunner::notifyDone() should be safely reentrant
182         https://bugs.webkit.org/show_bug.cgi?id=196898
183
184         Reviewed by Darin Adler.
185
186         It is currently possible that TestRunner::notifyDone() will call itself, since
187         notifyDone() will force a repaint, which can start executing JavaScript, which
188         may call notifyDone() again. This can lead to test failures and flakiness.
189         Fix this by setting the m_waitToDump flag before calling the dump() method.
190
191         * DumpRenderTree/mac/TestRunnerMac.mm:
192         (TestRunner::notifyDone):
193         (TestRunner::forceImmediateCompletion):
194         * DumpRenderTree/win/TestRunnerWin.cpp:
195         (TestRunner::notifyDone):
196         (TestRunner::forceImmediateCompletion):
197
198 2019-04-15  Philippe Normand  <pnormand@igalia.com>
199
200         [GTK][WPE] Add enable-media websetting
201         https://bugs.webkit.org/show_bug.cgi?id=196863
202
203         Reviewed by Michael Catanzaro.
204
205         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
206         (testWebKitSettings): Add test for the enable-media web-setting.
207
208 2019-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
209
210         API test WKAttachmentTests.AddAttachmentToConnectedImageElement is a flaky failure on Mac Release builds
211         https://bugs.webkit.org/show_bug.cgi?id=196905
212         <rdar://problem/49886096>
213
214         Reviewed by Tim Horton.
215
216         This flaky test exercises a race condition between when attachment insertion updates are dispatched from the web
217         process to the UI process, and when script is executed via -[WKWebView evaluateJavaScript:completionHandler:].
218         Since attachment insertion and removal updates from the web process to the UI process are scheduled on a zero-
219         delay timer, we end up with this sequence of events in the problematic (failure) case:
220
221         (a) [UI]    Run script #1 (which calls `HTMLAttachmentElement.getAttachmentIdentifier`)
222             ...IPC from UI to web process...
223         (b) [Web]   Evaluate script #1 in the web process, which schedules attachment updates on a zero-delay timer
224             ...IPC from web to UI process...
225         (c) [UI]    Invoke completion handler for script #1
226         (d) [UI]    Run script #2 (which calls `document.querySelector('img').attachmentIdentifier`)
227             ...IPC from UI to web process...
228         (e) [Web]   Evaluate script #2 in the web process
229         (f) [Web]   Zero-delay timer fires and dispatches attachment updates to the UI process
230
231         ...which means that script #2 will complete before the UI process has received the attachment updates sent in
232         step (f). However, in the case where the flaky test succeeds, the zero-delay timer in (f) fires *before* script
233         #2 is run in step (e).
234
235         This patch fixes the flaky test by waiting until attachment insertion updates are guaranteed to be received in
236         the UI process by waiting on a script message posted by the web process, after attachment updates are
237         dispatched.
238
239         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
240         (TestWebKitAPI::TEST):
241
242 2019-04-14  Aakash Jain  <aakash_jain@apple.com>
243
244         Disable Flaky API Test WKAttachmentTests.AddAttachmentToConnectedImageElement
245         https://bugs.webkit.org/show_bug.cgi?id=196909
246
247         Reviewed by Wenson Hsieh.
248
249         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
250         (TestWebKitAPI::TEST):
251
252 2019-04-13  Tadeu Zagallo  <tzagallo@apple.com>
253
254         CodeCache should check that the UnlinkedCodeBlock was successfully created before caching it
255         https://bugs.webkit.org/show_bug.cgi?id=196880
256
257         Reviewed by Yusuke Suzuki.
258
259         Add a new function for bytecode cache tests that does not forceDiskCache
260         for the second run: runBytecodeCacheNoAssetion. This is necessary for the
261         test added in this patch, since the code is invalid and therefore won't be
262         cached. It should also be useful for tests that evaluate dynamically
263         generated code.
264
265         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
266         * Scripts/run-jsc-stress-tests:
267
268 2019-04-12  Eric Carlson  <eric.carlson@apple.com>
269
270         Update AudioSession route sharing policy
271         https://bugs.webkit.org/show_bug.cgi?id=196776
272         <rdar://problem/46501611>
273
274         Reviewed by Jer Noble.
275
276         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
277         (TestWebKitAPI::routeSharingPolicyLongFormVideo):
278         (TestWebKitAPI::routeSharingPolicyLongFormAudio):
279         (TestWebKitAPI::TEST):
280
281 2019-04-12  Wenson Hsieh  <wenson_hsieh@apple.com>
282
283         [iOS] Software keyboard is shown too frequently on some websites
284         https://bugs.webkit.org/show_bug.cgi?id=195856
285         <rdar://problem/49191395>
286
287         Reviewed by Darin Adler.
288
289         Add support for attaching or detaching the hardware keyboard on iOS in layout tests.
290
291         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
292         (WTR::UIScriptController::setHardwareKeyboardAttached):
293         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
294         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
295         (WTR::UIScriptController::setHardwareKeyboardAttached):
296         * TestRunnerShared/UIScriptContext/UIScriptController.h:
297         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
298
299         Additionally link against GraphicsServices in WebKitTestRunner.
300
301         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
302         (WTR::TestController::platformResetStateToConsistentValues):
303         (WTR::UIScriptController::setHardwareKeyboardAttached):
304
305 2019-04-12  Ludovico de Nittis  <ludovico.denittis@collabora.com>
306
307         [GTK][WPE] Fix pacman install-dependencies packages
308         https://bugs.webkit.org/show_bug.cgi?id=196817
309
310         Reviewed by Žan Doberšek.
311         
312         python3-setuptools is called python-setuptools
313         ruby-highline is only available on AUR
314         libv4l-devel is incorporated in v4l-utils
315
316         * gtk/install-dependencies:
317         * wpe/install-dependencies:
318
319 2019-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
320
321         [GTK] REGRESSION(r243860): Many tests failing
322         https://bugs.webkit.org/show_bug.cgi?id=196791
323
324         Reviewed by Joanmarie Diggs.
325
326         Rework the accessibility unit test to use DBus for the communication with the server. This way we can load
327         multiple documents and check that accessibility hierarchy is updated after a navigation.
328
329         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
330         (loadChangedCallback):
331         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
332         (AccessibilityTest::AccessibilityTest):
333         (AccessibilityTest::~AccessibilityTest):
334         (AccessibilityTest::loadHTMLAndWaitUntilFinished):
335         (AccessibilityTest::findTestServerApplication):
336         (AccessibilityTest::findDocumentWeb):
337         (AccessibilityTest::findRootObject):
338         (AccessibilityTest::waitUntilChildrenRemoved):
339         (AccessibilityTest::ensureProxy):
340         (testAtspiBasicHierarchy):
341         (beforeAll):
342         (afterAll):
343
344 2019-04-11  Aakash Jain  <aakash_jain@apple.com>
345
346         [ews-build] Handle bug titles with unicode characters
347         https://bugs.webkit.org/show_bug.cgi?id=196802
348
349         Reviewed by Dewei Zhu.
350
351         * BuildSlaveSupport/ews-build/steps.py:
352         (ValidatePatch._is_bug_closed):
353
354 2019-04-11  Michael Saboff  <msaboff@apple.com>
355
356         Improve the Inline Cache Stats code
357         https://bugs.webkit.org/show_bug.cgi?id=196836
358
359         Reviewed by Saam Barati.
360
361         Added a new script to consolidate and arrange the output of --useICStats option.
362
363         This script merges the output from every group into one large table and sorts it from most common to
364         least common.  It also counts the slow path GetById and PutById variants and then calculates the
365         percentage of gets or puts for each unique base,property pair compared to all the gets and puts.
366         Put together, this is useful to see what property accesses are not getting cached.
367
368         * Scripts/ic-stats.py: Added.
369         (ICStats):
370         (ICStats.__init__):
371         (ICStats.parse):
372         (ICStats.dumpStats):
373         (usage):
374
375 2019-04-10  Alex Christensen  <achristensen@webkit.org>
376
377         WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
378         https://bugs.webkit.org/show_bug.cgi?id=196809
379         <rdar://49800762>
380
381         Reviewed by Brady Eidson.
382
383         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
384         (TEST):
385
386 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
387
388         requestAnimationFrame should execute before the next frame
389         https://bugs.webkit.org/show_bug.cgi?id=177484
390
391         Reviewed by Simon Fraser.
392
393         Add trace points for the page RenderingUpdate.
394
395         * Tracing/SystemTracePoints.plist:
396
397 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
398
399         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
400         https://bugs.webkit.org/show_bug.cgi?id=196760
401
402         Reviewed by Don Olmstead.
403
404         vswhere.exe has been bundled since Visual Studio 2017 version
405         15.2. We shouldn't download vswhere.exe.
406
407         * Scripts/build-jsc: Do not call update-vswhere.py.
408         * Scripts/build-webkit: Ditto.
409         * Scripts/update-vswhere.py: Removed.
410         * Scripts/webkitdirs.pm:
411         (requireModulesForVSWhere): Deleted.
412         (pickCurrentVisualStudioInstallation): Deleted.
413         (visualStudioInstallDirVSWhere): Return the latest installed VS
414         installation path by using the bundled vswhere.exe.
415         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
416         (visualStudioInstallDirFallback): Removed.
417
418 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
419
420         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
421         https://bugs.webkit.org/show_bug.cgi?id=196780
422
423         Reviewed by Alexey Proskuryakov.
424
425         * BuildSlaveSupport/ews-build/steps.py:
426         * BuildSlaveSupport/ews-build/steps_unittest.py:
427
428 2019-04-10  Alex Christensen  <achristensen@webkit.org>
429
430         Add SPI WKNavigationResponse._downloadAttribute
431         https://bugs.webkit.org/show_bug.cgi?id=196755
432         <rdar://49587365>
433
434         Reviewed by Brady Eidson.
435
436         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
437         (-[NavigationResponseTestDelegate navigationResponse]):
438         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
439         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
440         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
441         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
442         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
443         (readRequest):
444         (writeResponse):
445         (TEST):
446
447 2019-04-10  Tim Horton  <timothy_horton@apple.com>
448
449         Add modern API for overriding the page's specified viewport configuration
450         https://bugs.webkit.org/show_bug.cgi?id=167734
451         <rdar://problem/30331795>
452
453         Reviewed by Simon Fraser.
454
455         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
456         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
457
458 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
459
460         Add support for incremental bytecode cache updates
461         https://bugs.webkit.org/show_bug.cgi?id=195000
462
463         Reviewed by Filip Pizlo.
464
465         Exit when the initial run to generate bytecode fails.
466
467         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
468
469 2019-04-10  Alex Christensen  <achristensen@webkit.org>
470
471         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
472         https://bugs.webkit.org/show_bug.cgi?id=196744
473         <rdar://49415309>
474
475         Reviewed by Chris Dumez.
476
477         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
478         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
479
480 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
481
482         Add a way to opt into modern compatibility mode in layout tests
483         https://bugs.webkit.org/show_bug.cgi?id=196770
484         <rdar://problem/49777550>
485
486         Reviewed by Antoine Quint.
487
488         Add a new test option to enable modern compatibility mode in layout tests.
489
490         * WebKitTestRunner/TestController.cpp:
491         (WTR::updateTestOptionsFromTestHeader):
492         * WebKitTestRunner/TestController.h:
493         * WebKitTestRunner/TestOptions.h:
494         (WTR::TestOptions::hasSameInitializationOptions const):
495         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
496         (WTR::TestController::platformCreateWebView):
497         (WTR::TestController::enableModernCompatibilityMode):
498
499 2019-04-10  Andy Estes  <aestes@apple.com>
500
501         Try to fix the 32-bit watchOS build.
502
503         * TestWebKitAPI/cocoa/TestWKWebView.mm:
504         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
505
506 2019-04-10  Antoine Quint  <graouts@apple.com>
507
508         Enable Pointer Events on watchOS
509         https://bugs.webkit.org/show_bug.cgi?id=196771
510         <rdar://problem/49040909>
511
512         Reviewed by Dean Jackson.
513
514         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
515
516 2019-04-10  Philippe Normand  <pnormand@igalia.com>
517
518         Unreviewed. Fix WPE accessibility tests after r244059.
519
520         We are failing to load the injected bundle due to undefined symbol
521         AccessibilityUIElement::replaceTextInRange().
522
523         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
524         (WTR::AccessibilityUIElement::replaceTextInRange):
525
526 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
527
528         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
529         https://bugs.webkit.org/show_bug.cgi?id=196727
530
531         Reviewed by Fujii Hironori.
532
533         * MiniBrowser/win/WebKitBrowserWindow.cpp:
534         (WebKitBrowserWindow::create):
535
536 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
537
538         [ews-build] Add unit tests for PrintConfiguration
539         https://bugs.webkit.org/show_bug.cgi?id=196752
540
541         Reviewed by Dewei Zhu.
542
543         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
544
545 2019-04-09  Keith Rollin  <krollin@apple.com>
546
547         Unreviewed build maintenance -- update .xcfilelists.
548
549         * DumpRenderTree/DerivedSources-input.xcfilelist:
550         * DumpRenderTree/DerivedSources-output.xcfilelist:
551
552 2019-04-09  Zalan Bujtas  <zalan@apple.com>
553
554         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
555         https://bugs.webkit.org/show_bug.cgi?id=196743
556         <rdar://problem/43897551>
557
558         Reviewed by Tim Horton.
559
560         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
561         (TEST):
562
563 2019-04-09  Youenn Fablet  <youenn@apple.com>
564
565         Close service worker database on network process suspension
566         https://bugs.webkit.org/show_bug.cgi?id=196623
567         <rdar://problem/48930869>
568
569         Reviewed by Alex Christensen.
570
571         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
572
573 2019-04-09  Daniel Bates  <dabates@apple.com>
574
575         [iPad] Should open popover when the spacebar is pressed
576         https://bugs.webkit.org/show_bug.cgi?id=196360
577         <rdar://problem/49389129>
578
579         Reviewed by Brent Fulgham.
580
581         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
582
583         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
584         (WTR::UIScriptController::isShowingPopover const): Added.
585         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
586         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
587         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
588         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
589         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
590         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
591         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
592         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
593         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
594         (WTR::UIScriptController::isShowingPopover const): Added.
595         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
596         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
597         * TestRunnerShared/UIScriptContext/UIScriptController.h:
598         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
599         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
600         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
601         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
602         (-[TestRunnerWKWebView _willPresentPopover]): Added.
603         (-[TestRunnerWKWebView _didDismissPopover]): Added.
604         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
605         (WTR::UIScriptController::isShowingPopover const): Added.
606         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
607         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
608
609 2019-04-09  Alex Christensen  <achristensen@webkit.org>
610
611         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
612         https://bugs.webkit.org/show_bug.cgi?id=196665
613         <rdar://45115669>
614
615         Reviewed by Geoff Garen.
616
617         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
618         (goBack):
619         (+[SimpleLookupContext sharedLookupContext]):
620         (-[SimpleLookupContext lookUpURL:completionHandler:]):
621         (TEST):
622         (+[Simple3LookupContext sharedLookupContext]): Deleted.
623         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
624
625 2019-04-09  John Wilander  <wilander@apple.com>
626
627         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
628         https://bugs.webkit.org/show_bug.cgi?id=196558
629         <rdar://problem/47650245>
630
631         Reviewed by Youenn Fablet.
632
633         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
634         (TestWebKitAPI::TEST):
635             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
636
637 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
638
639         [CMake] Apple builds should use ICU_INCLUDE_DIRS
640         https://bugs.webkit.org/show_bug.cgi?id=196720
641
642         Reviewed by Konstantin Tokarev.
643
644         * TestWebKitAPI/PlatformMac.cmake:
645
646 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
647
648         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
649         https://bugs.webkit.org/show_bug.cgi?id=196694
650         <rdar://problem/48388734>
651
652         Rubber-stamped by Aakash Jain.
653
654         * Scripts/webkitpy/port/image_diff.py:
655         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
656         * Scripts/webkitpy/port/server_process.py:
657         (ServerProcess.has_available_stdout): Check if stdout has data in it.
658         (ServerProcess._wait_for_data_and_update_buffers_using_select):
659         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
660         * Scripts/webkitpy/port/server_process_mock.py:
661         (MockServerProcess.has_available_stdout):
662         * Scripts/webkitpy/port/server_process_unittest.py:
663         (TestServerProcess.serial_test_basic):
664
665 2019-04-09  Jer Noble  <jer.noble@apple.com>
666
667         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
668         https://bugs.webkit.org/show_bug.cgi?id=196097
669
670         Reviewed by Eric Carlson.
671
672         Drive-by bug fix: allow tests to play audio without a user gesture by default.
673
674         * DumpRenderTree/mac/DumpRenderTree.mm:
675         (resetWebPreferencesToConsistentValues):
676         * WebKitTestRunner/TestController.cpp:
677         (WTR::TestController::resetPreferencesToConsistentValues):
678
679 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
680
681         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
682         https://bugs.webkit.org/show_bug.cgi?id=196690
683
684         Reviewed by Michael Catanzaro.
685
686         * QueueStatusServer/config/queues.py:
687         * Scripts/webkitpy/common/config/ews.json:
688         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
689         (test_ews_name):
690
691 2019-04-09  Chris Dumez  <cdumez@apple.com>
692
693         Loads using loadHTMLString() cause flashing when process-swapping
694         https://bugs.webkit.org/show_bug.cgi?id=196714
695         <rdar://problem/49637354>
696
697         Reviewed by Antti Koivisto.
698
699         Add API test coverage.
700
701         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
702
703 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
704
705         Unreviewed. Fix ATK accessibility tests after r244059.
706
707         We are failing to load the injected bundle due to undefined symbol
708         AccessibilityUIElement::replaceTextInRange().
709
710         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
711         (WTR::AccessibilityUIElement::replaceTextInRange):
712
713 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
714
715         AX: Support API: accessibilityReplaceRange:withText
716         https://bugs.webkit.org/show_bug.cgi?id=196636
717
718         Unreviewed build fix for Windows port.
719
720         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
721         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
722
723 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
724
725         [CMake][WinCairo] Separate copied headers into different directories
726         https://bugs.webkit.org/show_bug.cgi?id=196655
727
728         Reviewed by Michael Catanzaro.
729
730         * DumpRenderTree/CMakeLists.txt:
731         * MiniBrowser/win/CMakeLists.txt:
732         * TestWebKitAPI/CMakeLists.txt:
733         * TestWebKitAPI/PlatformWin.cmake:
734
735 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
736
737         Log stack-trace for run-webkit-tests when interrupted
738         https://bugs.webkit.org/show_bug.cgi?id=176393
739         <rdar://problem/34262310>
740
741         Reviewed by Lucas Forschler.
742
743         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
744         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
745         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
746         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
747         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
748         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
749         (main): Set handlers to log stack trace on interruption.
750
751 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
752
753         AX: Support API: accessibilityReplaceRange:withText
754         https://bugs.webkit.org/show_bug.cgi?id=196636
755
756         Unreviewed build fix for Windows port.
757
758         * DumpRenderTree/AccessibilityUIElement.cpp:
759         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
760
761 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
762
763         [ews-build] Scripts using Buildbot API have CORS error
764         https://bugs.webkit.org/show_bug.cgi?id=196709
765
766         Reviewed by Alexey Proskuryakov.
767
768         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
769
770 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
771
772         AX: Support API: accessibilityReplaceRange:withText
773         https://bugs.webkit.org/show_bug.cgi?id=196636
774
775         Reviewed by Daniel Bates.
776
777         * DumpRenderTree/AccessibilityUIElement.cpp:
778         (replaceTextInRangeCallback):
779         (AccessibilityUIElement::replaceTextInRange):
780         (AccessibilityUIElement::getJSClass):
781         * DumpRenderTree/AccessibilityUIElement.h:
782         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
783         (AccessibilityUIElement::replaceTextInRange):
784         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
785         (AccessibilityUIElement::replaceTextInRange):
786         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
787         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
788         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
789         (WTR::AccessibilityUIElement::replaceTextInRange):
790         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
791         (WTR::AccessibilityUIElement::replaceTextInRange):
792
793 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
794
795         [iOS] Do not allow starting selection drags when selection views are not visible
796         https://bugs.webkit.org/show_bug.cgi?id=196686
797         <rdar://problem/49399192>
798
799         Reviewed by Tim Horton.
800
801         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
802         also add some new API tests to cover scenarios where the web view is not first responder.
803
804         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
805         (TestWebKitAPI::TEST):
806         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
807
808         Add a switch to optionally make the web view first responder when starting the simulated drag.
809
810         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
811         (-[DragAndDropSimulator initWithWebView:]):
812         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
813
814 2019-04-08  Justin Fan  <justin_fan@apple.com>
815
816         [Web GPU] Fix Web GPU experimental feature on iOS
817         https://bugs.webkit.org/show_bug.cgi?id=196632
818
819         Reviewed by Myles C. Maxfield.
820
821         Properly make Web GPU available on iOS 11+.
822
823         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
824
825 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
826
827         [ews-build] Do not upload archive when Compile Fails
828         https://bugs.webkit.org/show_bug.cgi?id=196674
829
830         Reviewed by Alexey Proskuryakov.
831
832         * BuildSlaveSupport/ews-build/factories.py:
833         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
834         * BuildSlaveSupport/ews-build/steps.py:
835         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
836         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
837         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
838
839 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
840
841         Enable DFG on MIPS
842         https://bugs.webkit.org/show_bug.cgi?id=196689
843
844         Reviewed by Žan Doberšek.
845
846         Since the bytecode change, we enabled the baseline JIT on mips in
847         r240432, but DFG is still missing. With this change, all tests are
848         passing on a ci20 board.
849
850         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
851
852 2019-04-08  Philippe Normand  <pnormand@igalia.com>
853
854         [Flatpak] Second run update-webkitwpe-flatpak fails
855         https://bugs.webkit.org/show_bug.cgi?id=192702
856
857         Reviewed by Carlos Garcia Campos.
858
859         * flatpak/flatpakutils.py:
860         (FlatpakObject.flatpak): Fix typo.
861         (FlatpakPackage.install): When installing, also update to the configured remote commit.
862         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
863
864 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
865
866         [GTK][WPE] outlook.live.com displays old-fashioned UI
867         https://bugs.webkit.org/show_bug.cgi?id=196642
868
869         Reviewed by Carlos Garcia Campos.
870
871         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
872         (TestWebKitAPI::TEST): New Mac platform quirk test.
873
874 2019-04-07  Commit Queue  <commit-queue@webkit.org>
875
876         Unreviewed, rolling out r243956.
877         https://bugs.webkit.org/show_bug.cgi?id=196688
878
879         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
880         by aakashjain on #webkit).
881
882         Reverted changeset:
883
884         "Clicking "Go Back" from a safe browsing warning from an
885         iframe should navigate the WKWebView back to the previous
886         page"
887         https://bugs.webkit.org/show_bug.cgi?id=196665
888         https://trac.webkit.org/changeset/243956
889
890 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
891
892         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
893         https://bugs.webkit.org/show_bug.cgi?id=196669
894
895         Reviewed by Geoffrey Garen.
896
897         Added three new unit tests for WeakHashSet.
898
899         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
900         (WTF_WeakPtr.WeakHashSetConstObjects):
901         (WTF_WeakPtr.WeakHashSetComputesEmpty):
902         (WTF_WeakPtr.WeakHashSetComputeSize):
903
904 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
905
906         Hide next and previous form control buttons when WKWebView is editable
907         https://bugs.webkit.org/show_bug.cgi?id=196672
908         <rdar://problem/35625321>
909
910         Reviewed by Tim Horton.
911
912         Add a new API test.
913
914         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
915         (-[TestWKWebView lastTrailingBarButtonGroup]):
916         (TestWebKitAPI::TEST):
917         * TestWebKitAPI/ios/UIKitSPI.h:
918
919 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
920
921         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
922         https://bugs.webkit.org/show_bug.cgi?id=196077
923         <rdar://problem/49108202>
924
925         Reviewed by Chris Dumez.
926
927         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
928         on new web view.
929
930         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
931
932 2019-04-05  Saam Barati  <sbarati@apple.com>
933
934         Make compare-results understand MotionMark
935         https://bugs.webkit.org/show_bug.cgi?id=196666
936
937         Reviewed by Yusuke Suzuki.
938
939         * Scripts/compare-results:
940         (PLT5Results):
941         (detectMotionMark):
942         (detectMotionMark1_1):
943         (motionMarkResults):
944         (motionMark1_1Results):
945         (detectBenchmark):
946         (biggerIsBetter):
947         (main):
948
949 2019-04-05  Alex Christensen  <achristensen@webkit.org>
950
951         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
952         https://bugs.webkit.org/show_bug.cgi?id=196665
953         <rdar://45115669>
954
955         Reviewed by Geoff Garen.
956
957         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
958         (goBack):
959         (+[SimpleLookupContext sharedLookupContext]):
960         (-[SimpleLookupContext lookUpURL:completionHandler:]):
961         (TEST):
962         (+[Simple3LookupContext sharedLookupContext]): Deleted.
963         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
964
965 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
966
967         [ews-build] Add configuration and architecture for windows builders
968         https://bugs.webkit.org/show_bug.cgi?id=196660
969
970         Reviewed by Lucas Forschler.
971
972         * BuildSlaveSupport/ews-build/config.json:
973
974 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
975
976         webkitpy: Don't run subsequent rounds if interrupted
977         https://bugs.webkit.org/show_bug.cgi?id=196646
978
979         Reviewed by Aakash Jain.
980
981         * Scripts/webkitpy/layout_tests/controllers/manager.py:
982         (Manager.run): Bail out if interrupted.
983
984 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
985
986         Test sessionStorage in PSON private browsing mode
987         https://bugs.webkit.org/show_bug.cgi?id=196561
988
989         Reviewed by Alex Christensen.
990
991         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
992
993 2019-04-05  Commit Queue  <commit-queue@webkit.org>
994
995         Unreviewed, rolling out r243833.
996         https://bugs.webkit.org/show_bug.cgi?id=196645
997
998         This change breaks build of WPE and GTK ports (Requested by
999         annulen on #webkit).
1000
1001         Reverted changeset:
1002
1003         "[CMake][WTF] Mirror XCode header directories"
1004         https://bugs.webkit.org/show_bug.cgi?id=191662
1005         https://trac.webkit.org/changeset/243833
1006
1007 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
1008
1009         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
1010         https://bugs.webkit.org/show_bug.cgi?id=196635
1011
1012         Reviewed by Antti Koivisto.
1013         
1014         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
1015         for a test to enable async frame scrolling via:
1016             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
1017         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
1018         
1019         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
1020
1021         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1022         (WTR::InjectedBundle::beginTesting):
1023         * WebKitTestRunner/TestController.cpp:
1024         (WTR::TestController::resetPreferencesToConsistentValues):
1025
1026 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
1027
1028         Use a correct LC_RPATH when building with ASan
1029         https://bugs.webkit.org/show_bug.cgi?id=196576
1030
1031         Reviewed by David Kilzer.
1032
1033         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
1034         so that ../Frameworks is checked. This is simpler and more reliable than updating
1035         each SPC service xcconfig.
1036
1037 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1038
1039         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
1040         https://bugs.webkit.org/show_bug.cgi?id=196629
1041
1042         Reviewed by Lucas Forschler.
1043
1044         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
1045
1046 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1047
1048         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
1049         https://bugs.webkit.org/show_bug.cgi?id=196618
1050
1051         Reviewed by Lucas Forschler.
1052
1053         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1054         (StatusBubble): Added QUEUE_TRIGGERS.
1055         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
1056         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
1057         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
1058         its parent(builder).
1059
1060 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1061
1062         [ews-app] Status-bubble steps are sometimes displayed in reverse order
1063         https://bugs.webkit.org/show_bug.cgi?id=196625
1064
1065         Reviewed by Lucas Forschler.
1066
1067         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1068         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
1069
1070 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1071
1072         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
1073         https://bugs.webkit.org/show_bug.cgi?id=196630
1074
1075         Reviewed by Wenson Hsieh.
1076
1077         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1078
1079 2019-04-04  Youenn Fablet  <youenn@apple.com>
1080
1081         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
1082         https://bugs.webkit.org/show_bug.cgi?id=196543
1083
1084         Reviewed by Alex Christensen.
1085
1086         * WebKitTestRunner/TestController.cpp:
1087         (WTR::TestController::generatePageConfiguration):
1088
1089 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1090
1091         [ews-app] Status bubble should not display skipped buildbot steps
1092         https://bugs.webkit.org/show_bug.cgi?id=196584
1093
1094         Reviewed by Lucas Forschler.
1095
1096         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1097
1098 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1099
1100         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
1101         https://bugs.webkit.org/show_bug.cgi?id=196620
1102
1103         Reviewed by Lucas Forschler.
1104
1105         * BuildSlaveSupport/ews-app/ews/config.py:
1106
1107 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
1108
1109         [Win] DumpRenderTreeWatchDog.py is not checked into source
1110         https://bugs.webkit.org/show_bug.cgi?id=196567
1111         <rdar://problem/49525901>
1112
1113         Reviewed by Lucas Forschler.
1114
1115         This script is used on Win EWS bots to terminate hanging DRT processes.
1116
1117         * EWSTools/dumprendertreewatchdog.py: Added.
1118
1119 2019-04-04  Chris Dumez  <cdumez@apple.com>
1120
1121         Unreviewed, roll out r243858 which made tests time out.
1122
1123         Disable new API tests on Windows instead.
1124
1125         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1126         (TestWebKitAPI::TEST):
1127
1128 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1129
1130         [ATK] Cleanup WebPageAccessibilityObjectAtk
1131         https://bugs.webkit.org/show_bug.cgi?id=196537
1132
1133         Reviewed by Michael Catanzaro.
1134
1135         Also consider files under atk directories as exceptions for GObject conventions.
1136
1137         * Scripts/webkitpy/style/checkers/cpp.py:
1138         (check_identifier_name_in_declaration):
1139
1140 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
1141
1142         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
1143         https://bugs.webkit.org/show_bug.cgi?id=196588
1144         <rdar://problem/49365787>
1145
1146         Unreviewed build fix for Windows port.
1147
1148         error C3861: 'kill': identifier not found
1149
1150         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1151         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
1152
1153 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1154
1155         [ews-build] Cancel build and similar operations should have authentication
1156         https://bugs.webkit.org/show_bug.cgi?id=196520
1157
1158         Reviewed by Dewei Zhu.
1159
1160         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
1161         environment variables.
1162
1163 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1164
1165         [ews-build] Do not trigger queues which are not in production yet
1166         https://bugs.webkit.org/show_bug.cgi?id=196581
1167
1168         Reviewed by Dewei Zhu.
1169
1170         * BuildSlaveSupport/ews-build/config.json:
1171
1172 2019-04-03  Chris Dumez  <cdumez@apple.com>
1173
1174         Unreviewed, fix typo in the name of API test added in r243848.
1175
1176         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1177         (TestWebKitAPI::TEST):
1178
1179 2019-04-03  Chris Dumez  <cdumez@apple.com>
1180
1181         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
1182         https://bugs.webkit.org/show_bug.cgi?id=196588
1183         <rdar://problem/49365787>
1184
1185         Reviewed by Ryosuke Niwa.
1186
1187         Add API test coverage.
1188
1189         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1190         (TestWebKitAPI::nullJavaScriptCallback):
1191         (TestWebKitAPI::didCrashCheckFrames):
1192         (TestWebKitAPI::TEST):
1193
1194 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
1195
1196         run-webkit-tests: Upload test results (new results database)
1197         https://bugs.webkit.org/show_bug.cgi?id=196577
1198         <rdar://problem/34841155>
1199
1200         Reviewed by Lucas Forschler.
1201
1202         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1203         (Manager.run): Upload results after each device shard, since the configuration will be
1204         different for each device.
1205         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
1206         uploaded to a results database.
1207         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1208         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
1209
1210 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
1211
1212         -apple-trailing-word is needed for browser detection
1213         https://bugs.webkit.org/show_bug.cgi?id=196575
1214
1215         Unreviewed.
1216
1217         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1218
1219 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
1220
1221         [CMake][WTF] Mirror XCode header directories
1222         https://bugs.webkit.org/show_bug.cgi?id=191662
1223
1224         Reviewed by Konstantin Tokarev.
1225
1226         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
1227         builds.
1228
1229         * CMakeLists.txt:
1230         * DumpRenderTree/CMakeLists.txt:
1231         * DumpRenderTree/PlatformWin.cmake:
1232         * MiniBrowser/win/CMakeLists.txt:
1233         * TestWebKitAPI/CMakeLists.txt:
1234         * TestWebKitAPI/PlatformWin.cmake:
1235         * WebKitTestRunner/PlatformGTK.cmake:
1236         * WebKitTestRunner/PlatformWin.cmake:
1237
1238 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1239
1240         [ews-app] Status bubble should not display certain infrastructure status messages
1241         https://bugs.webkit.org/show_bug.cgi?id=196550
1242
1243         Reviewed by Lucas Forschler.
1244
1245         Do not display the steps which are un-needed for end-user. This information is still avaiable
1246         if the user click on the bubble and look at the Buildbot build.
1247         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1248         (StatusBubble._steps_messages):
1249         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
1250
1251 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1252
1253         [ews-build] Use https for sending data to ews-app
1254         https://bugs.webkit.org/show_bug.cgi?id=196492
1255
1256         Reviewed by Lucas Forschler.
1257
1258         * BuildSlaveSupport/ews-build/events.py:
1259
1260 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
1261
1262         Remove support for -apple-trailing-word
1263         https://bugs.webkit.org/show_bug.cgi?id=196525
1264
1265         Reviewed by Zalan Bujtas.
1266
1267         This CSS property is nonstandard and not used.
1268
1269         * Scripts/webkitperl/FeatureList.pm:
1270         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1271
1272 2019-04-03  Youenn Fablet  <youenn@apple.com>
1273
1274         Add a test for DOMCache on multiple browsing in case of private browsing
1275         https://bugs.webkit.org/show_bug.cgi?id=196524
1276
1277         Reviewed by Alex Christensen.
1278
1279         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1280         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
1281
1282 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
1283
1284         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
1285         https://bugs.webkit.org/show_bug.cgi?id=196540
1286
1287         Reviewed by Aakash Jain.
1288
1289         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
1290
1291 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1292
1293         Add plumbing for a compatibility mode preference in WebKit
1294         https://bugs.webkit.org/show_bug.cgi?id=196005
1295
1296         Reviewed by Tim Horton.
1297
1298         Add new API tests.
1299
1300         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1301         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
1302
1303 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
1304
1305         [WPE][GTK] Update libsrtp dependency package for Debian
1306         https://bugs.webkit.org/show_bug.cgi?id=196528
1307
1308         Reviewed by Frédéric Wang.
1309
1310         * gtk/install-dependencies:
1311         * wpe/install-dependencies:
1312
1313 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
1314
1315         [WK2] Add support for Window's beforeprint / afterprint events
1316         https://bugs.webkit.org/show_bug.cgi?id=196478
1317         <rdar://problem/49535124>
1318
1319         Unreviewed build fix for MSVC.
1320
1321         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
1322
1323         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
1324
1325         * WebKitTestRunner/TestController.cpp:
1326         (WTR::printFrame): Use int and float literals.
1327
1328 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1329
1330         [ews-build] Reassign bots to queues
1331
1332         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
1333
1334 2019-04-02  Chris Dumez  <cdumez@apple.com>
1335
1336         [WK2] Add support for Window's beforeprint / afterprint events
1337         https://bugs.webkit.org/show_bug.cgi?id=196478
1338
1339         Reviewed by Alex Christensen.
1340
1341         Add minimal implementation for printFrame in WebKitTestRunner.
1342
1343         * WebKitTestRunner/TestController.cpp:
1344         (WTR::printFrame):
1345         (WTR::TestController::createOtherPage):
1346         (WTR::TestController::createWebViewWithOptions):
1347
1348 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1349
1350         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
1351         https://bugs.webkit.org/show_bug.cgi?id=196491
1352
1353         Reviewed by Lucas Forschler.
1354
1355         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1356
1357 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1358
1359         [ews-build] Configure buildbot try credentials in environment variables
1360         https://bugs.webkit.org/show_bug.cgi?id=196501
1361
1362         Reviewed by Lucas Forschler.
1363
1364         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
1365         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
1366         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
1367
1368 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
1369
1370         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
1371         https://bugs.webkit.org/show_bug.cgi?id=196496
1372         <rdar://problem/49521634>
1373
1374         Reviewed by Chris Dumez.
1375
1376         Add new API tests (see WebKit ChangeLog for more detail).
1377
1378         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1379         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1380         (TEST):
1381
1382 2019-04-02  David Kilzer  <ddkilzer@apple.com>
1383
1384         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
1385         <https://webkit.org/b/196499>
1386
1387         Reviewed by Alexey Proskuryakov.
1388
1389         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
1390         ENABLE_ADDRESS_SANITIZER.
1391
1392 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
1393
1394         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
1395         https://bugs.webkit.org/show_bug.cgi?id=182757
1396
1397         Reviewed by Don Olmstead.
1398
1399         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
1400         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
1401
1402 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
1403
1404         run-api-tests: Upload test results
1405         https://bugs.webkit.org/show_bug.cgi?id=196323
1406         <rdar://problem/49356714>
1407
1408         Reviewed by Lucas Forschler.
1409
1410         * Scripts/webkitpy/api_tests/manager.py:
1411         (Manager):
1412         (Manager.run): Upload results to a results database.
1413         * Scripts/webkitpy/api_tests/run_api_tests.py:
1414         (parse_args): Add upload arguments.
1415         * Scripts/webkitpy/port/base.py:
1416         (Port):
1417         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
1418         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
1419         with commits from any other associated repositories.
1420         * Scripts/webkitpy/port/device.py:
1421         (Device):
1422         (Device.build_version): Access build_versoin of underlying platform device.
1423         * Scripts/webkitpy/port/ios_simulator_unittest.py:
1424         (IOSSimulatorTest):
1425         (IOSSimulatorTest.test_configuration_for_upload):
1426         * Scripts/webkitpy/port/device_port.py:
1427         (DevicePort):
1428         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
1429         the same as the machine uploading results.
1430         * Scripts/webkitpy/port/mac.py:
1431         (MacPort):
1432         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
1433         * Scripts/webkitpy/port/mac_unittest.py:
1434         (MacTest):
1435         (MacTest.test_configuration_for_upload):
1436         * Scripts/webkitpy/xcode/simulated_device.py:
1437         (SimulatedDeviceManager._create_device_with_runtime):
1438         (SimulatedDevice.__init__): Create simulated device with a build_version.
1439         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
1440         (test_existing_simulator):
1441
1442 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1443
1444         Remove extra newline characters (Follow-up fix to r243707)
1445
1446         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1447
1448 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1449
1450         [ews-app] Use API_KEY to accept results data
1451         https://bugs.webkit.org/show_bug.cgi?id=196461
1452
1453         Reviewed by Dewei Zhu.
1454
1455         * BuildSlaveSupport/ews-app/ews/views/results.py:
1456         (Results.post): Validate EWS_API_KEY before accepting any data.
1457         * BuildSlaveSupport/ews-build/events.py:
1458         (Events.sendData): Send EWS_API_KEY if available along with event data.
1459
1460 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1461
1462         Unable to copy and paste a PDF from Notes into Mail compose body
1463         https://bugs.webkit.org/show_bug.cgi?id=196442
1464         <rdar://problem/48573098>
1465
1466         Reviewed by Tim Horton.
1467
1468         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
1469         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
1470         to be specified on the item providers.
1471
1472         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1473         (TestWebKitAPI::mapItemForTesting):
1474         (TestWebKitAPI::contactItemForTesting):
1475
1476 2019-04-01  Tim Horton  <timothy_horton@apple.com>
1477
1478         Make UIWKDocumentContext rects per-character instead of per-word
1479         https://bugs.webkit.org/show_bug.cgi?id=196459
1480
1481         Reviewed by Wenson Hsieh.
1482
1483         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1484         (TEST):
1485         Adjust test results due to switching to per-character rects.
1486
1487 2019-04-01  Chris Dumez  <cdumez@apple.com>
1488
1489         UIProcess crash when a prewarmed process is terminated
1490         https://bugs.webkit.org/show_bug.cgi?id=196451
1491         <rdar://problem/49245471>
1492
1493         Reviewed by Geoffrey Garen.
1494
1495         Add API test coverage.
1496
1497         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1498         (TEST):
1499
1500 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1501
1502         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
1503         https://bugs.webkit.org/show_bug.cgi?id=196449
1504
1505         Reviewed by Lucas Forschler.
1506
1507         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1508         (StatusBubble.get_os_details): Method to get OS and Xcode details.
1509         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
1510         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
1511
1512 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1513
1514         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
1515         https://bugs.webkit.org/show_bug.cgi?id=196444
1516
1517         Reviewed by Lucas Forschler.
1518
1519         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
1520
1521 2019-04-01  Alex Christensen  <achristensen@webkit.org>
1522
1523         Add SPI to canonicalize NSURLs with WTF::URL
1524         https://bugs.webkit.org/show_bug.cgi?id=196415
1525         <rdar://problem/44980271>
1526
1527         Reviewed by Darin Adler.
1528
1529         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1530         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
1531         (TestWebKitAPI::TEST):
1532
1533 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
1534
1535         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
1536         https://bugs.webkit.org/show_bug.cgi?id=196441
1537
1538         Reviewed by Carlos Garcia Campos.
1539
1540         Don't cache the wpe_view_backend object that might not exist yet at the
1541         time of EventSenderProxy constructor invocation, but instead retrieve
1542         that object whenever it's required for event dispatching. This should
1543         avoid crashes in this constructor now that it's invoked before any
1544         PlatformWindow has been set up (as changed in r243496).
1545
1546         * WebKitTestRunner/EventSenderProxy.h:
1547         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
1548         (WTR::viewBackend):
1549         (WTR::EventSenderProxy::EventSenderProxy):
1550         (WTR::EventSenderProxy::mouseDown):
1551         (WTR::EventSenderProxy::mouseUp):
1552         (WTR::EventSenderProxy::mouseMoveTo):
1553         (WTR::EventSenderProxy::mouseScrollBy):
1554         (WTR::EventSenderProxy::keyDown):
1555         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
1556
1557 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
1558
1559         [Win][WebKit] MiniBrowser should support high DPI display
1560         https://bugs.webkit.org/show_bug.cgi?id=196391
1561
1562         Reviewed by Alex Christensen.
1563
1564         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1565         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
1566         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
1567         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
1568
1569 2019-03-31  Sam Weinig  <weinig@apple.com>
1570
1571         Remove more i386 specific configurations
1572         https://bugs.webkit.org/show_bug.cgi?id=196430
1573
1574         Reviewed by Alexey Proskuryakov.
1575
1576         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1577         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
1578
1579 2019-03-31  Andy Estes  <aestes@apple.com>
1580
1581         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
1582         https://bugs.webkit.org/show_bug.cgi?id=196433
1583         <rdar://problem/49293305>
1584
1585         Reviewed by Tim Horton.
1586
1587         Enhanced API test coverage to include all navigation response policy decisions in both
1588         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
1589
1590         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1591         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
1592         (TestWebKitAPI::TEST):
1593         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
1594         (readFile):
1595         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
1596         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
1597         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1598         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1599         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1600         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
1601         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
1602         (-[QuickLookDelegate _downloadDidStart:]):
1603         (-[QuickLookDelegate _download:didReceiveResponse:]):
1604         (-[QuickLookDelegate _download:didReceiveData:]):
1605         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1606         (-[QuickLookDelegate _downloadDidFinish:]):
1607         (-[QuickLookDelegate _download:didFailWithError:]):
1608         (-[QuickLookDelegate _downloadDidCancel:]):
1609         (-[QuickLookDelegate verifyDownload]):
1610         (runTest):
1611         (runTestDecideBeforeLoading):
1612         (runTestDecideAfterLoading):
1613         (TEST):
1614         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1615         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
1616         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
1617         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1618         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1619         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
1620         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1621         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1622         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1623         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
1624         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1625         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
1626         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
1627         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
1628
1629 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
1630
1631         [CMake] add testdfg as target with build-jsc
1632         https://bugs.webkit.org/show_bug.cgi?id=196393
1633
1634         Reviewed by Saam Barati.
1635
1636         Added testdfg as one of the targets to build when
1637         using CMake.
1638
1639         * Scripts/build-jsc:
1640
1641 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
1642
1643         Delete WebMetal implementation in favor of WebGPU
1644         https://bugs.webkit.org/show_bug.cgi?id=195418
1645
1646         Reviewed by Dean Jackson.
1647
1648         * DumpRenderTree/mac/DumpRenderTree.mm:
1649         (enableExperimentalFeatures):
1650         (resetWebPreferencesToConsistentValues):
1651         * Scripts/webkitperl/FeatureList.pm:
1652         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1653         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1654         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
1655         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
1656         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
1657         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
1658         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
1659         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
1660         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
1661         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1662         (WTR::InjectedBundle::beginTesting):
1663         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1664         (WTR::TestRunner::setWebMetalEnabled): Deleted.
1665         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1666
1667 2019-03-29  Chris Dumez  <cdumez@apple.com>
1668
1669         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
1670         https://bugs.webkit.org/show_bug.cgi?id=196405
1671         <rdar://problem/49428130>
1672
1673         Reviewed by Wenson Hsieh.
1674
1675         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
1676         the popover presentation methods to be no-ops. Use this in the new test added in
1677         r243523 so that we do not swizzle those methods for all tests. This is needed because
1678         those WatchOS tests rely on the popover getting presented and interactive.
1679
1680         * WebKitTestRunner/TestController.cpp:
1681         (WTR::updateTestOptionsFromTestHeader):
1682         * WebKitTestRunner/TestController.h:
1683         * WebKitTestRunner/TestOptions.h:
1684         (WTR::TestOptions::hasSameInitializationOptions const):
1685         * WebKitTestRunner/ios/TestControllerIOS.mm:
1686         (WTR::TestController::platformInitialize):
1687         (WTR::TestController::platformResetStateToConsistentValues):
1688
1689 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
1690
1691         [Curl] Add Server Trust Evaluation Support.
1692         https://bugs.webkit.org/show_bug.cgi?id=191646
1693
1694         Reviewed by Fujii Hironori.
1695
1696         Implemented MiniBrowser UI for asking if user trusts the server.
1697
1698         * MiniBrowser/win/Common.cpp:
1699         (askServerTrustEvaluation):
1700         (replaceString):
1701         * MiniBrowser/win/Common.h:
1702         * MiniBrowser/win/MiniBrowserLib.rc:
1703         * MiniBrowser/win/MiniBrowserLibResource.h:
1704         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1705         (createPEMString):
1706         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
1707         (WebKitBrowserWindow::canTrustServerCertificate):
1708         * MiniBrowser/win/WebKitBrowserWindow.h:
1709
1710 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
1711
1712         Implement ResizeObserver.
1713         https://bugs.webkit.org/show_bug.cgi?id=157743
1714
1715         Reviewed by Simon Fraser.
1716
1717         Support resizeObserverEnabled webPreferences.
1718
1719         * DumpRenderTree/TestOptions.cpp:
1720         (TestOptions::TestOptions):
1721         * DumpRenderTree/TestOptions.h:
1722         * DumpRenderTree/mac/DumpRenderTree.mm:
1723         (setWebPreferencesForTestOptions):
1724         * DumpRenderTree/win/DumpRenderTree.cpp:
1725         (enableExperimentalFeatures):
1726         * Scripts/webkitperl/FeatureList.pm:
1727         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1728
1729 2019-03-28  John Wilander  <wilander@apple.com>
1730
1731         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
1732         https://bugs.webkit.org/show_bug.cgi?id=196281
1733         <rdar://problem/48938748>
1734
1735         Reviewed by Alex Christensen.
1736
1737         This patch adds the function isStatisticsHasLocalStorage() to the
1738         TestRunner. With it, the page can query the WebsiteDataStore in the
1739         UI process to make sure that it sees LocalStorage.
1740
1741         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1742         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1743         (WTR::TestRunner::isStatisticsHasLocalStorage):
1744         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1745         * WebKitTestRunner/TestController.cpp:
1746         (WTR::TestController::isStatisticsHasLocalStorage):
1747         * WebKitTestRunner/TestController.h:
1748         * WebKitTestRunner/TestInvocation.cpp:
1749         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1750
1751 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
1752
1753         API::Data::createWithoutCopying should do a null check before calling CFRelease
1754         https://bugs.webkit.org/show_bug.cgi?id=196276
1755         <rdar://problem/48059859>
1756
1757         Reviewed by Alex Christensen.
1758
1759         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
1760
1761         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1762         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
1763         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
1764         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
1765         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1766         (TestWebKitAPI::TEST):
1767
1768 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
1769
1770         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
1771         https://bugs.webkit.org/show_bug.cgi?id=186276
1772
1773         Reviewed by Carlos Garcia Campos.
1774
1775         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
1776         (webViewLoadChanged):
1777         (testWebResourceGetDataError):
1778         (testWebResourceGetDataEmpty):
1779         (beforeAll):
1780         (webViewloadChanged): Deleted.
1781
1782 2019-03-27  Andy Estes  <aestes@apple.com>
1783
1784         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
1785         https://bugs.webkit.org/show_bug.cgi?id=196317
1786
1787         Reviewed by Dan Bernstein.
1788
1789         package-root copies built products into a staging directory using ditto(1), which does not
1790         follow symbolic links as it traverses a directory. Now that the files in
1791         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
1792         itself, these become broken links when ditto'd into the staging directory.
1793
1794         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
1795
1796         * Scripts/package-root:
1797
1798 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
1799
1800         [ews-app] Update display text of Submit for ews analysis
1801         https://bugs.webkit.org/show_bug.cgi?id=196309
1802
1803         Reviewed by Dewei Zhu.
1804
1805         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1806
1807 2019-03-27  David Kilzer  <ddkilzer@apple.com>
1808
1809         run-webkit-tests should check for leaks in WebKit processes
1810         <https://webkit.org/b/193772>
1811         <rdar://problem/46526680>
1812
1813         Reviewed by Ryosuke Niwa.
1814
1815         This works by doing the following:
1816         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
1817           The list of child processes are returned one per line:
1818           process.name: pid
1819         - Run the "#LIST CHILD PROCESSES" command just before the
1820           "#CHECK FOR WORLD LEAKS" command, and store the list of child
1821           processes on the ServerProcess object.
1822         - When the `--leaks` switch is handled, run check_for_leaks() on
1823           each child process after the main test harness.
1824
1825         * DumpRenderTree/mac/DumpRenderTree.mm:
1826         (handleControlCommand):
1827         - Use strncmp() instead of strcmp().
1828         - Add support for handling "#LIST CHILD PROCESSES" command.
1829
1830         * Scripts/webkitpy/port/base.py:
1831         (Port.check_for_leaks):
1832         * Scripts/webkitpy/port/darwin.py:
1833         (DarwinPort.check_for_leaks):
1834         - Rename redundant 'process_pid' argument to 'process_id'.
1835
1836         * Scripts/webkitpy/port/driver.py:
1837         (Driver.do_post_tests_work):
1838         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
1839           longer the only command this sends to WebKitTestRunner.
1840         - If the `--leaks` switch is present, send the
1841           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
1842           result using Port.set_webkit_processes().
1843         (Driver._parse_child_processes_output):
1844         - Add helper method to parse list of child process names and
1845           process IDs returned from WebKitTestRunner.
1846
1847         * Scripts/webkitpy/port/ios_device.py:
1848         (IOSDevicePort.check_for_leaks):
1849         - Rename redundant 'process_pid' argument to 'process_id'.
1850
1851         * Scripts/webkitpy/port/leakdetector.py:
1852         (LeakDetector._parse_leaks_output):
1853         - Return early if there is no leaks_output.
1854         (LeakDetector.check_for_leaks):
1855         - Rename redundant 'process_pid' argument to 'process_id'.
1856
1857         * Scripts/webkitpy/port/server_process.py:
1858         (ServerProcess.__init__):
1859         (ServerProcess.child_processes):
1860         (ServerProcess.set_child_processes):
1861         - Add instance variable to Port to store list of child process
1862           names and process IDs returned from WebKitTestRunner.
1863         (ServerProcess._start):
1864         - Clear self._child_processes.
1865         (ServerProcess.stop):
1866         - If self._child_processes is set, call
1867           self._port.check_for_leaks() for each child process.
1868
1869         * Scripts/webkitpy/port/server_process_unittest.py:
1870         (TrivialMockPort.check_for_leaks):
1871         - Rename redundant 'process_pid' argument to 'process_id'.
1872
1873         * Scripts/webkitpy/port/simulator_process.py:
1874         (SimulatorProcess.stop):
1875         - If self._child_processes is set, call
1876           self._port.check_for_leaks() for each child process.
1877
1878         * Scripts/webkitpy/port/watch_device.py:
1879         (WatchDevicePort.check_for_leaks):
1880         - Rename redundant 'process_pid' argument to 'process_id'.
1881
1882         * WebKitTestRunner/TestController.cpp:
1883         (WTR::TestController::dumpResponse):
1884         - Extract method from findAndDumpWorldLeaks() so that it may be
1885           reused by findAndDumpWebKitProcessIdentifiers().
1886         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1887         - Add method to output process name and process ID of both the
1888           WebContent and Networking processes.
1889         (WTR::TestController::findAndDumpWorldLeaks):
1890         - Fix missing newline in output when there were no abandoned
1891           documents.
1892         - Call dumpResponse() for extracted code.
1893         (WTR::TestController::handleControlCommand):
1894         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
1895         - Use strncmp() instead of strcmp().
1896         - Call findAndDumpWebKitProcessIdentifiers() when
1897           "#LIST CHILD PROCESSES" command is sent.
1898         * WebKitTestRunner/TestController.h:
1899         (WTR::TestController::dumpResponse):
1900         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1901         - Declare methods.
1902
1903 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1904
1905         Unreviewed. Add GLib API test cases after r243434.
1906
1907         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1908         (testWebViewActiveURI):
1909         (serverCallback):
1910         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1911         (sendRequestCallback):
1912
1913 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1914
1915         Geolocation request not complete when watch request was started in a different web process
1916         https://bugs.webkit.org/show_bug.cgi?id=195996
1917
1918         Reviewed by Alex Christensen.
1919
1920         Add a test case.
1921
1922         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1923         (TestWebKitAPI::runJavaScriptAlert):
1924         (TestWebKitAPI::TEST):
1925
1926 2019-03-26  Keith Rollin  <krollin@apple.com>
1927
1928         Update the way generate-xcfilelists returns strings from functions
1929         https://bugs.webkit.org/show_bug.cgi?id=195975
1930         <rdar://problem/49040807>
1931
1932         Reviewed by Dean Jackson.
1933
1934         There are places where generate-xcfilelists executes assignments with
1935         statements like:
1936
1937             FOO=$(some_function)
1938
1939         where "some_function" return a string by echoing it. E.g.
1940
1941             some_function()
1942             {
1943                 echo "Hello, World"
1944             }
1945
1946         This is a common idiom, but it has a problem if "some_function" needs
1947         to call "exit" in an attempt to halt the entire script right then and
1948         there. Since "some_function" is called inside of $(), it's being
1949         executed in a sub-shell. Calling exit in that sub-shell simply exits
1950         that shell; it doesn't not exit the outer shell in which the main part
1951         of the script is still running. As such, the main script keeps
1952         executing when the intent was for the script to halt.
1953
1954         The solution to this is to use a different idiom for returning
1955         strings. The one we now is to pass in the name of the variable to
1956         receive the string result:
1957
1958             some_function()
1959             {
1960                 variable_name=$1
1961                 eval $variable_name ="Hello, World"
1962             }
1963
1964         The call site now looks like
1965
1966             some_function FOO
1967
1968         Because there's no invocation of a sub-shell, some_function can now
1969         call "exit" if it wants to, and the entire script will exit at that
1970         point.
1971
1972         * Scripts/generate-xcfilelists:
1973
1974 2019-03-26  Chris Dumez  <cdumez@apple.com>
1975
1976         Add basic layout test coverage for File Picker on iOS
1977         https://bugs.webkit.org/show_bug.cgi?id=196265
1978
1979         Reviewed by Wenson Hsieh.
1980
1981         Add layout test infrastructure to test the file picker on iOS.
1982
1983         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1984         (WTR::UIScriptController::dismissFilePicker):
1985         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1986         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1987         (WTR::UIScriptController::dismissFilePicker):
1988         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1989         * WebKitTestRunner/TestController.cpp:
1990         (WTR::TestController::createWebViewWithOptions):
1991         (WTR::updateTestOptionsFromTestHeader):
1992         * WebKitTestRunner/TestOptions.h:
1993         (WTR::TestOptions::hasSameInitializationOptions const):
1994         * WebKitTestRunner/ios/TestControllerIOS.mm:
1995         (overridePresentViewController):
1996         (WTR::TestController::platformInitialize):
1997         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1998         (WTR::UIScriptController::dismissFilePicker):
1999
2000 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
2001
2002         Implement async paste method on UIWKInteractionViewProtocol
2003         https://bugs.webkit.org/show_bug.cgi?id=196267
2004         <rdar://problem/49236346>
2005
2006         Reviewed by Tim Horton.
2007
2008         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
2009         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
2010         are now a part of all iOS 12 internal SDKs.
2011
2012         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
2013
2014         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
2015         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
2016
2017         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
2018         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2019         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
2020         * TestWebKitAPI/ios/UIKitSPI.h:
2021
2022 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2023
2024         [ews-build] Use PostgreSQL for ews.webkit.org database
2025         https://bugs.webkit.org/show_bug.cgi?id=196270
2026
2027         Reviewed by Lucas Forschler.
2028
2029         * BuildSlaveSupport/ews-app/ews-app/settings.py:
2030
2031 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
2032
2033         [ews] Reset simctl states on reboot
2034         https://bugs.webkit.org/show_bug.cgi?id=196260
2035
2036         Rubber-stamped by Aakash Jain.
2037
2038         * EWSTools/start-queue-mac.sh:
2039
2040 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2041
2042         [ews-build] Use PostgreSQL for ews-build database
2043         https://bugs.webkit.org/show_bug.cgi?id=196229
2044
2045         Reviewed by Lucas Forschler.
2046
2047         * BuildSlaveSupport/ews-build/master.cfg:
2048
2049 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2050
2051         [ews-build] Get master_hostname dynamically in master.cfg
2052         https://bugs.webkit.org/show_bug.cgi?id=196255
2053
2054         Reviewed by Lucas Forschler.
2055
2056         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
2057         send events data in test mode.
2058
2059 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2060
2061         [ews-app] Set db_constraint to False for Foreign Keys
2062         https://bugs.webkit.org/show_bug.cgi?id=196252
2063
2064         Reviewed by Lucas Forschler.
2065
2066         * BuildSlaveSupport/ews-app/ews/models/build.py:
2067         * BuildSlaveSupport/ews-app/ews/models/step.py:
2068
2069 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2070
2071         [ews-build] is_test_mode_enabled should default to True
2072         https://bugs.webkit.org/show_bug.cgi?id=196248
2073
2074         Reviewed by Lucas Forschler.
2075
2076         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
2077
2078 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2079
2080         [ews-app] Add webkitperl to ENABLED_QUEUES
2081         https://bugs.webkit.org/show_bug.cgi?id=196253
2082
2083         Reviewed by Lucas Forschler.
2084
2085         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2086
2087 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
2088
2089         Address NSWindow sometimes using WebKitTestRunnerEvent too early
2090         https://bugs.webkit.org/show_bug.cgi?id=196211
2091         rdar://problem/49110552
2092
2093         Reviewed by Tim Horton.
2094
2095         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
2096         Make sure that EventSenderProxy always exists when running tests. We used to create
2097         it when resetting before the first test, which is a bit too late.
2098
2099         * WebKitTestRunner/TestController.h:
2100         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2101         (WTR::TestController::platformCreateWebView):
2102         (WTR::TestController::platformCreateOtherPage):
2103         (WTR::TestController::finishCreatingPlatformWebView):
2104         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2105         (WTR::PlatformWebView::PlatformWebView):
2106         Moved some code that made NSWindow use NSEvent during web view creation. We may
2107         need to move more if some other case us found, but this is enough for now.
2108
2109 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
2110
2111         Unreviewed. Fix typo in GLib geolocation API after r243285.
2112
2113         gelocation -> geolocation.
2114
2115         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
2116         (testGeolocationManagerWatchPosition):
2117
2118 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2119
2120         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
2121         https://bugs.webkit.org/show_bug.cgi?id=196213
2122
2123         Reviewed by Geoff Garen.
2124
2125         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2126         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
2127         (credentialWithIdentityAndKeychainPath):
2128         (-[ChallengeDelegate webView:didFinishNavigation:]):
2129         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2130         (TestWebKitAPI::TEST):
2131
2132 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2133
2134         Expected shouldn't assume its contained types are copyable
2135         https://bugs.webkit.org/show_bug.cgi?id=195986
2136
2137         Reviewed by JF Bastien.
2138
2139         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2140         (TestWebKitAPI::NonCopyable::operator== const):
2141         (TestWebKitAPI::NonCopyable::operator!= const):
2142         (TestWebKitAPI::TEST):
2143
2144 2019-03-25  Tim Horton  <timothy_horton@apple.com>
2145
2146         Remove some now-unnecessary dynamic class lookup
2147         https://bugs.webkit.org/show_bug.cgi?id=196237
2148
2149         Reviewed by Simon Fraser.
2150
2151         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2152         (makeRequest):
2153         (TEST):
2154
2155 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
2156
2157         Unreviewed, rolling out r243450.
2158
2159         AppleWin and WinCairo port builds get broken.
2160
2161         Reverted changeset:
2162
2163         "Add test for fix of #196095"
2164         https://bugs.webkit.org/show_bug.cgi?id=196097
2165         https://trac.webkit.org/changeset/243450
2166
2167 2019-03-25  Commit Queue  <commit-queue@webkit.org>
2168
2169         Unreviewed, rolling out r243465.
2170         https://bugs.webkit.org/show_bug.cgi?id=196226
2171
2172         the test doesn't build (Requested by thorton on #webkit).
2173
2174         Reverted changeset:
2175
2176         "Do not terminate the NetworkProcess if a third party
2177         application sends a NSCredential with a SecIdentityRef"
2178         https://bugs.webkit.org/show_bug.cgi?id=196213
2179         https://trac.webkit.org/changeset/243465
2180
2181 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2182
2183         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
2184         https://bugs.webkit.org/show_bug.cgi?id=196213
2185
2186         Reviewed by Geoff Garen.
2187
2188         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2189         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
2190         (credentialWithIdentityAndKeychainPath):
2191         (-[ChallengeDelegate webView:didFinishNavigation:]):
2192         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2193         (TestWebKitAPI::TEST):
2194
2195 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
2196
2197         [ews-build] Gracefully handle missing patch_id in events
2198         https://bugs.webkit.org/show_bug.cgi?id=196216
2199
2200         Reviewed by Lucas Forschler.
2201
2202         * BuildSlaveSupport/ews-build/events.py:
2203
2204 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
2205
2206         [ews-build] use lz4 compression for improving buildbot performance
2207         https://bugs.webkit.org/show_bug.cgi?id=196155
2208
2209         Reviewed by Lucas Forschler.
2210
2211         * BuildSlaveSupport/ews-build/master.cfg:
2212
2213 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2214
2215         Pull some API testing helper methods out of TestWKWebView
2216         https://bugs.webkit.org/show_bug.cgi?id=196212
2217
2218         Reviewed by Tim Horton.
2219
2220         Refactor some more API testing utility methods, so that they can be used in
2221         tests that do not use TestWKWebView.
2222
2223         * TestWebKitAPI/cocoa/TestWKWebView.h:
2224         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2225         (-[WKWebView loadTestPageNamed:]):
2226         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
2227         (-[WKWebView synchronouslyLoadHTMLString:]):
2228         (-[WKWebView synchronouslyLoadTestPageNamed:]):
2229         (-[TestWKWebView loadTestPageNamed:]): Deleted.
2230         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
2231         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
2232         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
2233
2234 2019-03-25  Jer Noble  <jer.noble@apple.com>
2235
2236         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
2237         https://bugs.webkit.org/show_bug.cgi?id=196097
2238
2239         Reviewed by Eric Carlson.
2240
2241         Drive-by bug fix: allow tests to play audio without a user gesture by default.
2242
2243         * DumpRenderTree/mac/DumpRenderTree.mm:
2244         (resetWebPreferencesToConsistentValues):
2245         * WebKitTestRunner/TestController.cpp:
2246         (WTR::TestController::resetPreferencesToConsistentValues):
2247
2248 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2249
2250         Pull IPadUserInterfaceSwizzler out into a separate header file
2251         https://bugs.webkit.org/show_bug.cgi?id=196193
2252
2253         Reviewed by Anders Carlsson.
2254
2255         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
2256         be used in other API tests.
2257
2258         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2259         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
2260         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
2261         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
2262         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
2263         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
2264         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
2265
2266 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2267
2268         Remove NavigatorContentUtils in WebCore/Modules
2269         https://bugs.webkit.org/show_bug.cgi?id=196070
2270
2271         Reviewed by Alex Christensen.
2272
2273         NavigatorContentUtils was to support the custom scheme spec [1].
2274         However, in WebKit side, no port has supported the feature in
2275         WebKit layer after EFL port was removed. So there has been the
2276         only IDL implementation of the NavigatorContentUtils in WebCore.
2277         So we don't need to keep the implementation in WebCore anymore.
2278
2279         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
2280
2281         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2282
2283 2019-03-24  Andy Estes  <aestes@apple.com>
2284
2285         [watchOS] Remove unused Proximity Networking code
2286         https://bugs.webkit.org/show_bug.cgi?id=196188
2287
2288         Reviewed by Tim Horton.
2289
2290         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
2291         (TEST):
2292
2293 2019-03-23  Keith Miller  <keith_miller@apple.com>
2294
2295         Refactor clz/ctz and fix getLSBSet.
2296         https://bugs.webkit.org/show_bug.cgi?id=196162
2297
2298         Reviewed by Saam Barati.
2299
2300         Add tests for clz, ctz, getLSBSet, and getMSBSet.
2301
2302         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2303         (TestWebKitAPI::TEST):
2304
2305 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2306
2307         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
2308         https://bugs.webkit.org/show_bug.cgi?id=196143
2309
2310         Reviewed by Michael Catanzaro.
2311
2312         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
2313         directories.
2314
2315         * Scripts/webkitpy/style/checkers/cpp.py:
2316         (check_identifier_name_in_declaration):
2317         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2318         (WebKitStyleTest.test_names):
2319
2320 2019-03-22  Philippe Normand  <pnormand@igalia.com>
2321
2322         [Flatpak] Manifest expanding fails for qt WPE extension
2323         https://bugs.webkit.org/show_bug.cgi?id=196148
2324
2325         Reviewed by Alex Christensen.
2326
2327         * flatpak/flatpakutils.py:
2328         (expand_submodules_recurse): The last recurse manifest expand
2329         iteration might lead to a single module so take it into account
2330         and don't try to recurse further.
2331
2332 2019-03-22  Chris Dumez  <cdumez@apple.com>
2333
2334         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
2335         https://bugs.webkit.org/show_bug.cgi?id=195348
2336         <rdar://problem/48622090>
2337
2338         Reviewed by Alex Christensen.
2339
2340         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
2341         to NO when test.options().shouldIgnoreMetaViewport is false.
2342
2343         * WebKitTestRunner/ios/TestControllerIOS.mm:
2344         (WTR::TestController::platformConfigureViewForTest):
2345
2346 2019-03-22  Chris Dumez  <cdumez@apple.com>
2347
2348         Prewarmed processes should be usable with any website data store
2349         https://bugs.webkit.org/show_bug.cgi?id=196104
2350
2351         Reviewed by Alex Christensen.
2352
2353         Add API test coverage.
2354
2355         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2356         (runInitialWarmedProcessUsedTest):
2357         (TEST):
2358
2359 2019-03-22  David Kilzer  <ddkilzer@apple.com>
2360
2361         Back out local changes to Alex's Subversion working directory
2362
2363         They were accidentally committed.
2364
2365         * Scripts/webkitpy/common/system/abstractexecutive.py:
2366         (AbstractExecutive.wait_newest):
2367         * Scripts/webkitpy/common/system/executive.py:
2368         (Executive.running_pids):
2369         * Scripts/webkitpy/common/system/executive_mock.py:
2370         (MockExecutive.running_pids):
2371         * Scripts/webkitpy/common/system/executive_unittest.py:
2372         (ExecutiveTest.serial_test_running_pids):
2373         * Scripts/webkitpy/port/darwin.py:
2374         (DarwinPort.check_for_leaks):
2375         * Scripts/webkitpy/port/leakdetector.py:
2376         (LeakDetector.check_for_leaks):
2377         - This was the hack attached to Bug 193772.
2378
2379         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
2380         (+[WebKitTestRunnerEvent mouseLocation]):
2381         - This works around a crash on an internal build.
2382
2383 2019-03-22  Tim Horton  <timothy_horton@apple.com>
2384
2385         Fix the build after r243354
2386         https://bugs.webkit.org/show_bug.cgi?id=196138
2387         <rdar://problem/49145951>
2388
2389         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2390         (TEST):
2391         * TestWebKitAPI/ios/UIKitSPI.h:
2392
2393 2019-03-21  Tim Horton  <timothy_horton@apple.com>
2394
2395         Adopt UIWKDocumentContext
2396         https://bugs.webkit.org/show_bug.cgi?id=196040
2397         <rdar://problem/48642440>
2398
2399         Reviewed by Ryosuke Niwa.
2400
2401         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2402         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
2403         (makeRequest):
2404         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
2405         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
2406         (applyStyle):
2407         (TEST):
2408         Add tests for UIWKDocumentContext.
2409
2410         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
2411         (TEST):
2412         (recursiveFindWKContentView): Deleted.
2413         * TestWebKitAPI/cocoa/TestWKWebView.h:
2414         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2415         (recursiveFindWKContentView):
2416         (-[TestWKWebView wkContentView]):
2417         * TestWebKitAPI/ios/UIKitSPI.h:
2418         Share the WKContentView finding code between tests.
2419
2420 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
2421
2422         [iOS WK2] Turn on async overflow scrolling by default
2423         https://bugs.webkit.org/show_bug.cgi?id=196011
2424         rdar://problem/48453859
2425
2426         Reviewed by Antti Koivisto.
2427         
2428         Explicitly turn off the async overflow scrolling internal feature for tests by default,
2429         since so many basic layout tests have different results when compositing is triggered for
2430         overflow.
2431         
2432         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
2433
2434         * WebKitTestRunner/TestController.cpp:
2435         (WTR::TestController::resetPreferencesToConsistentValues):
2436
2437 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2438
2439         [ews-build] Retry API test in case of failures
2440         https://bugs.webkit.org/show_bug.cgi?id=196004
2441
2442         Reviewed by Lucas Forschler.
2443
2444         * BuildSlaveSupport/ews-build/steps.py:
2445         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
2446         (CompileWebKitToT.doStepIf): Ditto.
2447         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
2448         (ReRunAPITests): Re-run API tests.
2449         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
2450         (RunAPITestsWithoutPatch): Run API tests without patch.
2451         (RunAPITestsWithoutPatch.doStepIf):
2452         (RunAPITestsWithoutPatch.hideStepIf):
2453         (RunAPITestsWithoutPatch.evaluateCommand):
2454         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
2455         (AnalyzeAPITestsResults.start):
2456         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
2457         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
2458         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
2459         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
2460
2461 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2462
2463         [ews-build] Update queues configurations
2464         https://bugs.webkit.org/show_bug.cgi?id=196074
2465
2466         Reviewed by Dewei Zhu.
2467
2468         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
2469         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
2470
2471 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2472
2473         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
2474         https://bugs.webkit.org/show_bug.cgi?id=195680
2475         <rdar://problem/48903534>
2476
2477         Unreviewed infrastructure fix.
2478
2479         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2480         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
2481
2482 2019-03-21  Andy Estes  <aestes@apple.com>
2483
2484         [iOS] Apple Pay should be available in documents with no user agent scripts
2485         https://bugs.webkit.org/show_bug.cgi?id=196061
2486         <rdar://problem/48649391>
2487
2488         Reviewed by Brady Eidson.
2489
2490         Added API tests and related infrastructure.
2491
2492         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2493         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
2494         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
2495         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
2496         (TestWebKitAPI::TEST):
2497         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
2498         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
2499         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
2500         * TestWebKitAPI/cocoa/TestProtocol.mm:
2501         (-[TestProtocol startLoading]):
2502         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
2503         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
2504         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
2505         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
2506
2507 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
2508
2509         REGRESSSION (r243297): webkitpy tests broken
2510         https://bugs.webkit.org/show_bug.cgi?id=196108
2511
2512         Reviewed by Aakash Jain.
2513
2514         r243297 updated contributors.json, which broke a few unit tests.
2515
2516         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2517         (IRCCommandTest.test_whois):
2518         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
2519
2520 2019-03-21  Chris Dumez  <cdumez@apple.com>
2521
2522         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
2523         https://bugs.webkit.org/show_bug.cgi?id=196041
2524         <rdar://problem/49083230>
2525
2526         Reviewed by Alex Christensen.
2527
2528         Add API test coverage.
2529
2530         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
2531         (TEST):
2532
2533 2019-03-21  Alex Christensen  <achristensen@webkit.org>
2534
2535         Add SPI to inform applications of WKContentRuleList actions
2536         https://bugs.webkit.org/show_bug.cgi?id=195965
2537         <rdar://problem/42664365>
2538
2539         Reviewed by Geoff Garen.
2540
2541         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2542         (TestWebKitAPI::allActionsForResourceLoad):
2543         (TestWebKitAPI::testRequest):
2544         (TestWebKitAPI::TEST_F):
2545         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
2546         (Notification::description):
2547         (Notification::operator== const):
2548         (toVector):
2549         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
2550         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
2551         (makeContentRuleList):
2552         (TEST):
2553         (makeWarnContentRuleList): Deleted.
2554
2555 2019-03-21  Timothy Hatcher  <timothy@apple.com>
2556
2557         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
2558         https://bugs.webkit.org/show_bug.cgi?id=196088
2559
2560         Reviewed by Brian Burg.
2561
2562         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
2563         Support checks when only one platform is specified. Also deprecate macosx() and
2564         force the use of macos() instead.
2565
2566         * Scripts/webkitpy/style/checkers/cpp.py:
2567         (check_min_versions_of_wk_api_available):
2568         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2569         (WebKitStyleTest.test_min_versions_of_wk_api_available):
2570
2571 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
2572
2573         Update status inactive committers' status to 'contributor'.
2574
2575         * Scripts/webkitpy/common/config/contributors.json:
2576
2577 2019-03-21  Xan Lopez  <xan@igalia.com>
2578
2579         [JSC][x86] Drop support for x87 floating point
2580         https://bugs.webkit.org/show_bug.cgi?id=194853
2581
2582         Reviewed by Don Olmstead.
2583
2584         Force SSE2 on x86/32bit builds.
2585
2586         * Scripts/webkitdirs.pm:
2587         (generateBuildSystemFromCMakeProject):
2588
2589 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2590
2591         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
2592         https://bugs.webkit.org/show_bug.cgi?id=196073
2593
2594         Reviewed by Michael Catanzaro.
2595
2596         Add test cases to check functions and constructors with no arguments but receiving user data.
2597
2598         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2599         (checkUserData):
2600         (testJSCFunction):
2601         (fooCreateWithUserData):
2602         (testJSCClass):
2603
2604 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2605
2606         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
2607
2608         Add g_assert_cmpfloat_with_epsilon macro if not defined.
2609
2610         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2611
2612 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2613
2614         [GTK][WPE] Add API to provide geolocation information
2615         https://bugs.webkit.org/show_bug.cgi?id=195940
2616
2617         Reviewed by Michael Catanzaro.
2618
2619         Add a new test to check the new API.
2620
2621         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
2622         (testGeolocationManagerCurrentPosition):
2623         (testGeolocationManagerWatchPosition):
2624         (beforeAll):
2625         (afterAll):
2626         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2627         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
2628         (beforeAll): Ditto.
2629         * TestWebKitAPI/glib/CMakeLists.txt:
2630
2631 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2632
2633         [GLib] Returning G_TYPE_OBJECT from a method does not work
2634         https://bugs.webkit.org/show_bug.cgi?id=195574
2635
2636         Reviewed by Michael Catanzaro.
2637
2638         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
2639
2640         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2641         (getGFile):
2642         (getParent):
2643         (createGString):
2644         (getGString):
2645         (getGStringCopyWillRaise):
2646         (getGStringCopy):
2647         (getGStringStr):
2648         (getGStringLen):
2649         (freeGString):
2650         (testJSCClass):
2651
2652 2019-03-20  Saam Barati  <sbarati@apple.com>
2653
2654         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
2655         https://bugs.webkit.org/show_bug.cgi?id=195721
2656
2657         Reviewed by Filip Pizlo.
2658
2659         * Scripts/run-javascriptcore-tests:
2660
2661 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
2662
2663         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
2664         https://bugs.webkit.org/show_bug.cgi?id=196049
2665
2666         Reviewed by Tim Horton.
2667
2668         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
2669         overflow scrolling in general, so rename it.
2670
2671         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2672
2673 2019-03-20  Daniel Bates  <dabates@apple.com>
2674
2675         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
2676         https://bugs.webkit.org/show_bug.cgi?id=196031
2677         <rdar://problem/49078172>
2678
2679         Reviewed by Tim Horton.
2680
2681         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
2682         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
2683         same code path used when the Done button is pressed to dismiss the <select> picker.
2684
2685         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
2686         (TestWebKitAPI::TEST):
2687
2688 2019-03-20  Chris Dumez  <cdumez@apple.com>
2689
2690         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
2691         https://bugs.webkit.org/show_bug.cgi?id=196029
2692         <rdar://problem/48954651>
2693
2694         Reviewed by Tim Horton.
2695
2696         Add API test coverage.
2697
2698         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2699
2700 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
2701
2702         [ews-build] Improve failure summary string for ApplyPatch step
2703         https://bugs.webkit.org/show_bug.cgi?id=195995
2704
2705         Reviewed by Alexey Proskuryakov.
2706
2707         * BuildSlaveSupport/ews-build/steps.py:
2708         (ApplyPatch.getResultSummary): Override getResultSummary.
2709
2710 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
2711
2712         AX: Implement support for new meter ARIA role
2713         https://bugs.webkit.org/show_bug.cgi?id=195966
2714
2715         Reviewed by Chris Fleizach.
2716
2717         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
2718         to AXLevelIndicator.
2719
2720         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2721
2722 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
2723
2724         [WebAuthN] Implement FIDO AppID extension
2725         https://bugs.webkit.org/show_bug.cgi?id=143491
2726         <rdar://problem/48298273>
2727
2728         Reviewed by Brent Fulgham.
2729
2730         Add a test that covers the new flag of convertToU2fSignCommand.
2731
2732         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
2733         (TestWebKitAPI::TEST):
2734         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2735         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
2736         (TestWebKitAPI::TEST):
2737
2738 2019-03-19  Keith Rollin  <krollin@apple.com>
2739
2740         Add support for more platforms to generate-xcfilelists
2741         https://bugs.webkit.org/show_bug.cgi?id=195977
2742
2743         Reviewed by Alexey Proskuryakov.
2744
2745         generate-xcfilelists incorrectly complains when involved with building
2746         WebKit for iphonesimulator:
2747
2748             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
2749             …
2750             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
2751
2752         Address this by teaching generate-xcfilelists about more platforms.
2753
2754         * Scripts/generate-xcfilelists:
2755
2756 2019-03-19  John Wilander  <wilander@apple.com>
2757
2758         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
2759         https://bugs.webkit.org/show_bug.cgi?id=195923
2760         <rdar://problem/49001272>
2761
2762         Reviewed by Alex Christensen.
2763
2764         This patch does the following to the TestRunner:
2765         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
2766         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
2767         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
2768
2769         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2770         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2771         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
2772         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2773         * WebKitTestRunner/TestController.cpp:
2774         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
2775         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
2776         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2777         * WebKitTestRunner/TestController.h:
2778         * WebKitTestRunner/TestInvocation.cpp:
2779         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2780
2781 2019-03-19  Christopher Reid  <chris.reid@sony.com>
2782
2783         [CMake] Support more clang and gcc sanitizers
2784         https://bugs.webkit.org/show_bug.cgi?id=195956
2785
2786         Reviewed by Michael Catanzaro.
2787
2788         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
2789
2790 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2791
2792         [ews-build] Improve summary for PrintConfiguration step
2793         https://bugs.webkit.org/show_bug.cgi?id=195945
2794
2795         Reviewed by Lucas Forschler.
2796
2797         * BuildSlaveSupport/ews-build/steps.py:
2798         (PrintConfiguration.getResultSummary): Override getResultSummary.
2799
2800 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2801
2802         [ews-build] Improve summary for CheckOutSource step
2803         https://bugs.webkit.org/show_bug.cgi?id=195963
2804
2805         Reviewed by Lucas Forschler.
2806
2807         * BuildSlaveSupport/ews-build/steps.py:
2808         (CheckOutSource.getResultSummary):
2809
2810 2019-03-19  Daniel Bates  <dabates@apple.com>
2811
2812         [iOS] Focus not preserved when switching between tabs
2813         https://bugs.webkit.org/show_bug.cgi?id=195820
2814         <rdar://problem/43614450>
2815
2816         Reviewed by Brent Fulgham.
2817
2818         Add tests to ensure that we restore focus when resigning and becoming first responder.
2819
2820         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2821         (TestWebKitAPI::TEST):
2822
2823 2019-03-19  Alex Christensen  <achristensen@webkit.org>
2824
2825         Make WTFLogChannelState and WTFLogLevel enum classes
2826         https://bugs.webkit.org/show_bug.cgi?id=195904
2827
2828         Reviewed by Eric Carlson.
2829
2830         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2831         (TestWebKitAPI::TEST_F):
2832
2833 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2834
2835         [GStreamer][EME] Backported mssdemux protection data crash fix
2836         https://bugs.webkit.org/show_bug.cgi?id=195918
2837
2838         Reviewed by Philippe Normand.
2839
2840         * gstreamer/jhbuild.modules:
2841         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
2842
2843 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2844
2845         Unreviewed, rolling out r243132.
2846
2847         Broke GTK build
2848
2849         Reverted changeset:
2850
2851         "Make WTFLogChannelState and WTFLogLevel enum classes"
2852         https://bugs.webkit.org/show_bug.cgi?id=195904
2853         https://trac.webkit.org/changeset/243132
2854
2855 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
2856
2857         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
2858
2859         * Scripts/webkitdirs.pm:
2860         (builtDylibPathForName): Adjust the shared library name that's changed
2861         with the API version bump in r243073.
2862
2863 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2864
2865         Make WTFLogChannelState and WTFLogLevel enum classes
2866         https://bugs.webkit.org/show_bug.cgi?id=195904
2867
2868         Reviewed by Eric Carlson.
2869
2870         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2871         (TestWebKitAPI::TEST_F):
2872
2873 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2874
2875         Disable flaky test added in r2431100
2876         https://webkit.org/b/195785
2877
2878         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2879         (TestWebKitAPI::TEST):
2880         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
2881
2882 2019-03-18  Timothy Hatcher  <timothy@apple.com>
2883
2884         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
2885         https://bugs.webkit.org/show_bug.cgi?id=195916
2886
2887         Reviewed by Tim Horton.
2888
2889         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2890         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
2891
2892 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
2893
2894         Add a secondary e-mail address for Fujii Hironori to make tools happier.
2895
2896         * Scripts/webkitpy/common/config/contributors.json:
2897
2898 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2899
2900         Implement DownloadMonitor to prevent long-running slow downloads from background apps
2901         https://bugs.webkit.org/show_bug.cgi?id=195785
2902
2903         Reviewed by Geoffrey Garen.
2904
2905         * TestWebKitAPI/TCPServer.cpp: Added.
2906         (TestWebKitAPI::TCPServer::TCPServer):
2907         (TestWebKitAPI::TCPServer::~TCPServer):
2908         (TestWebKitAPI::TCPServer::socketBindListen):
2909         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
2910         * TestWebKitAPI/TCPServer.h: Added.
2911         (TestWebKitAPI::TCPServer::port const):
2912         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2913         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2914         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
2915         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
2916         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2917         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
2918         (TestWebKitAPI::respondSlowly):
2919         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
2920         (TestWebKitAPI::downloadAtRate):
2921         (TestWebKitAPI::TEST):
2922
2923 2019-03-18  Saam Barati  <sbarati@apple.com>
2924
2925         Add a plan file for JetStream 2
2926         https://bugs.webkit.org/show_bug.cgi?id=190734
2927
2928         Reviewed by Mark Lam.
2929
2930         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
2931
2932 2019-03-18  Chris Dumez  <cdumez@apple.com>
2933
2934         Delay WebProcess launch until a load is triggered in a Web view
2935         https://bugs.webkit.org/show_bug.cgi?id=195758
2936         <rdar://problem/48126013>
2937
2938         Reviewed by Geoff Garen.
2939
2940         Add API test coverage. Also update some existing API tests to not expect
2941         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
2942
2943         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
2944         (TestWebKitAPI::TEST):
2945         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
2946         (TestWebKitAPI::TEST):
2947         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2948         (TEST):
2949         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2950         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2951         (TEST):
2952         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2953         (TEST):
2954         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
2955
2956 2019-03-18  Xan Lopez  <xan@igalia.com>
2957
2958         [CMake] Prevent potential warning when determining $architecture
2959         https://bugs.webkit.org/show_bug.cgi?id=195891
2960
2961         Reviewed by Michael Catanzaro.
2962
2963         It's possible for generateBuildSystemForCMakeProject to be called
2964         before determineArchitecture() is ever called. This will make the
2965         first eq check with $architecture to be bogus (and print a
2966         warning). Change that to an eq check with architecture(), which
2967         implicitly calls determineArchitecture() if needed, and change all
2968         the other similar cases in the method in the same way to prevent
2969         future bugs like this one.
2970
2971         * Scripts/webkitdirs.pm:
2972         (generateBuildSystemFromCMakeProject):
2973
2974 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2975
2976         [WPE] Tarballs generated with “make dist” cannot build documentation
2977         https://bugs.webkit.org/show_bug.cgi?id=195885
2978
2979         Reviewed by Carlos Garcia Campos.
2980
2981         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
2982
2983 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2984
2985         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
2986         https://bugs.webkit.org/show_bug.cgi?id=195883
2987
2988         Reviewed by Carlos Garcia Campos.
2989
2990         * gtkdoc/gtkdoc.py:
2991         (GTKDoc._run_command): When commands fail to run, include the full command line for
2992         the program invocation and the output it has generated on the standard error stream.
2993
2994 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2995
2996         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
2997         https://bugs.webkit.org/show_bug.cgi?id=195786
2998
2999         Reviewed by Philippe Normand.
3000
3001         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
3002         * wpe/jhbuild.modules: Ditto.
3003
3004 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
3005
3006         [ews-build] Don't run clean builds on EWS builders
3007         https://bugs.webkit.org/show_bug.cgi?id=195851
3008
3009         Reviewed by Geoffrey Garen.
3010
3011         * BuildSlaveSupport/ews-build/factories.py:
3012
3013 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
3014
3015         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
3016         https://bugs.webkit.org/show_bug.cgi?id=195849
3017
3018         Reviewed by Chris Dumez.
3019
3020         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
3021
3022         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3023         (runWebsiteDataStoreCustomPaths):
3024
3025 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
3026
3027         webkitpy: Upload test results
3028         https://bugs.webkit.org/show_bug.cgi?id=195755
3029         <rdar://problem/48896182>
3030
3031         Reviewed by Aakash Jain.
3032
3033         Establish a new format for uploading results that is not tied to layout tests, apply
3034         that format to webkitpy tests.
3035
3036         * Scripts/webkitpy/common/checkout/scm/git.py:
3037         (Git.native_branch): Return what branch the current checkout is on.
3038         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
3039         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3040         * Scripts/webkitpy/common/checkout/scm/svn.py:
3041         (SVN.native_branch): Ditto.
3042         * Scripts/webkitpy/common/system/platforminfo.py:
3043         (PlatformInfo.build_version): Return a build version for Mac.
3044         * Scripts/webkitpy/common/system/platforminfo_mock.py:
3045         (MockPlatformInfo.__init__):
3046         (MockPlatformInfo.build_version):
3047         * Scripts/webkitpy/results: Added.
3048         * Scripts/webkitpy/results/__init__.py: Added.
3049         * Scripts/webkitpy/results/options.py: Added.
3050         (upload_options): OptParse list for upload options.
3051         * Scripts/webkitpy/results/upload.py: Added.
3052         (Upload): Class which enforces the upload format expected by the results server.
3053         (Upload.Expectations):
3054         (Upload.create_configuration):
3055         (Upload.create_commit):
3056         (Upload.create_details):
3057         (Upload.create_run_stats):
3058         (Upload.create_test_result):
3059         (Upload.__init__):
3060         (Upload.Encoder): Encode Upload object as json.
3061         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
3062         * Scripts/webkitpy/results/upload_unittest.py: Added.
3063         * Scripts/webkitpy/test/main.py:
3064         (Tester._parse_args): Add upload arguments.
3065         (Tester._run_tests): Allow results to be uploaded.
3066         * Scripts/webkitpy/test/runner.py:
3067         (Runner.__init__): Record which tests were run, rather than just counting them.
3068         (Runner.handle):
3069         * Scripts/webkitpy/test/runner_unittest.py:
3070         (RunnerTest.test_run):
3071         * Scripts/webkitpy/thirdparty/__init__.py:
3072         (AutoinstallImportHook.find_module): Add requests auto-install.
3073         (AutoinstallImportHook._install_requests):
3074         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3075         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
3076
3077 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
3078
3079         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
3080         https://bugs.webkit.org/show_bug.cgi?id=195810
3081
3082         Reviewed by Tim Horton.
3083
3084         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
3085         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
3086         ending certain layout tests.
3087
3088         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3089         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3090         (-[TestRunnerWKWebView dealloc]):
3091         (-[TestRunnerWKWebView resetInteractionCallbacks]):
3092
3093         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
3094         helper method when destroying the web view, and when resetting state between tests.
3095
3096         * WebKitTestRunner/ios/TestControllerIOS.mm:
3097         (WTR::TestController::platformResetStateToConsistentValues):
3098
3099         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
3100
3101 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
3102
3103         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
3104         https://bugs.webkit.org/show_bug.cgi?id=190350
3105         <rdar://problem/45089503>
3106
3107         Reviewed by Geoffrey Garen.
3108
3109         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3110         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
3111         (TEST):
3112         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
3113         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
3114         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
3115         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
3116         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
3117         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
3118         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
3119         (runTest):
3120         (createDirectories):
3121         (TEST):
3122         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
3123         (TEST):
3124         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
3125         (TEST):
3126
3127 2019-03-15  Timothy Hatcher  <timothy@apple.com>
3128
3129         Add support to WebPage for getting the contents as an attributed string.
3130         https://bugs.webkit.org/show_bug.cgi?id=195636
3131         rdar://problem/45055697
3132
3133         Reviewed by Tim Horton.
3134
3135         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
3136         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
3137
3138 2019-03-15  Chris Dumez  <cdumez@apple.com>
3139
3140         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
3141         https://bugs.webkit.org/show_bug.cgi?id=195747
3142
3143         Reviewed by Geoff Garen.
3144
3145         Add API test coverage.
3146
3147         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3148
3149 2019-03-15  Shawn Roberts  <sroberts@apple.com>
3150
3151         Unreviewed, rolling out r242952.
3152
3153         Causing API failures on iOS Simulator
3154
3155         Reverted changeset:
3156
3157         "[PSON] Make sure the WebProcessCache is leverage when
3158         relaunching a process after termination"
3159         https://bugs.webkit.org/show_bug.cgi?id=195747
3160         https://trac.webkit.org/changeset/242952
3161
3162 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
3163
3164         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
3165         https://bugs.webkit.org/show_bug.cgi?id=195740
3166
3167         Reviewed by Ross Kirsling.
3168
3169         window.open doesn't work for WebKitBrowserWindow because it is not
3170         implemented yet.
3171
3172         1. Implemented createNewPage callback of WKPageUIClient.
3173         2. Changed MainWindow to take a BrowserWindow factory function
3174           instead of BrowserWindowType to be flexible to create
3175           BrowserWindow with extra settings.
3176         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
3177           because it is not relevant with MainWindow anymore.
3178
3179         * MiniBrowser/win/Common.cpp:
3180         (parseCommandLine):
3181         * MiniBrowser/win/Common.h:
3182         (CommandLineOptions::CommandLineOptions):
3183         * MiniBrowser/win/MainWindow.cpp:
3184         (MainWindow::MainWindow):
3185         (MainWindow::create):
3186         (MainWindow::init):
3187         (MainWindow::WndProc):
3188         * MiniBrowser/win/MainWindow.h:
3189         * MiniBrowser/win/PrintWebUIDelegate.cpp:
3190         (PrintWebUIDelegate::createWebViewWithRequest):
3191         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3192         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
3193         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
3194         (WebKitBrowserWindow::updateProxySettings):
3195         (WebKitBrowserWindow::createNewPage):
3196         * MiniBrowser/win/WebKitBrowserWindow.h:
3197         * MiniBrowser/win/WinMain.cpp:
3198         (wWinMain):
3199
3200 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
3201
3202         Make it possible to test scrolling tree layer manipulation more easily
3203         https://bugs.webkit.org/show_bug.cgi?id=195780
3204
3205         Reviewed by Tim Horton.
3206         
3207         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
3208         cuts off communication of scrolling tree scrolls back to the web process
3209         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
3210         allows tests to trigger scrolls which run the scrolling tree layer positioning
3211         logic, but never get another commit from the web process that might mask
3212         scrolling tree bugs.
3213         
3214         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
3215         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
3216         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
3217
3218         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3219         (WTR::UIScriptController::scrollUpdatesDisabled const):
3220         (WTR::UIScriptController::setScrollUpdatesDisabled):
3221         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3222         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3223         (WTR::UIScriptController::scrollUpdatesDisabled const):
3224         (WTR::UIScriptController::setScrollUpdatesDisabled):
3225         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3226         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3227         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3228         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
3229         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
3230         * WebKitTestRunner/ios/TestControllerIOS.mm:
3231         (WTR::TestController::platformResetStateToConsistentValues):
3232         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3233         (WTR::UIScriptController::scrollUpdatesDisabled const):
3234         (WTR::UIScriptController::setScrollUpdatesDisabled):
3235
3236 2019-03-14  Youenn Fablet  <youenn@apple.com>
3237
3238         Move IDB storage in private browsing mode to NetworkProcess
3239         https://bugs.webkit.org/show_bug.cgi?id=195602
3240
3241         Reviewed by Brady Eidson.
3242
3243         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
3244         (TEST):
3245
3246 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3247
3248         [ews-build] Make descriptionDone messages more readable
3249         https://bugs.webkit.org/show_bug.cgi?id=195760
3250
3251         Reviewed by Lucas Forschler.
3252
3253         * BuildSlaveSupport/ews-build/steps.py:
3254         * BuildSlaveSupport/ews-build/steps_unittest.py:
3255
3256 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3257
3258         [ews-build] Generate status-bubble hover-over messages
3259         https://bugs.webkit.org/show_bug.cgi?id=195680
3260
3261         Reviewed by Lucas Forschler.
3262
3263         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3264         (StatusBubble):
3265         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
3266         on hover-over.
3267         (StatusBubble._iso_time):
3268         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
3269         hover-over message.
3270         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
3271
3272 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3273
3274         [ews-app] Gracefully handle the case when state_string is None
3275         https://bugs.webkit.org/show_bug.cgi?id=195753
3276
3277         Reviewed by Lucas Forschler.
3278
3279         * BuildSlaveSupport/ews-app/ews/models/build.py:
3280         * BuildSlaveSupport/ews-app/ews/models/step.py:
3281
3282 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3283
3284         [ews-app] Status bubble display pending for currently running build step
3285         https://bugs.webkit.org/show_bug.cgi?id=195744
3286
3287         Reviewed by Lucas Forschler.
3288
3289         * BuildSlaveSupport/ews-build/events.py:
3290         (Events.stepStarted): If state_string is pending, replace it with step name.
3291
3292 2019-03-14  Chris Dumez  <cdumez@apple.com>
3293
3294         Add WebsitePolicy for the client to specify the device orientation & motion access policy
3295         https://bugs.webkit.org/show_bug.cgi?id=195750
3296
3297         Reviewed by Geoffrey Garen.
3298
3299         Add API test coverage.
3300
3301         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3302         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
3303         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3304         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3305
3306 2019-03-14  Chris Dumez  <cdumez@apple.com>
3307
3308         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
3309         https://bugs.webkit.org/show_bug.cgi?id=195747
3310
3311         Reviewed by Geoff Garen.
3312
3313         Add API test coverage.
3314
3315         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3316
3317 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
3318
3319         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
3320         https://bugs.webkit.org/show_bug.cgi?id=195725
3321         <rdar://problem/48545062>
3322
3323         Reviewed by Tim Horton.
3324
3325         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
3326         handler is nil.
3327
3328         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3329         (TestWebKitAPI::TEST):
3330
3331 2019-03-13  Sam Weinig  <sam@webkit.org>
3332
3333         Add utility function to allow easy reverse range-based iteration of a container
3334         https://bugs.webkit.org/show_bug.cgi?id=195542
3335
3336         Reviewed by Antti Koivisto.
3337
3338         * TestWebKitAPI/CMakeLists.txt:
3339         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3340         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3341         (TestWebKitAPI::TEST):
3342         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3343
3344 2019-03-13  Chris Dumez  <cdumez@apple.com>
3345
3346         Use a ServiceWorker process per registrable domain
3347         https://bugs.webkit.org/show_bug.cgi?id=195649
3348
3349         Reviewed by Youenn Fablet.
3350
3351         Update API test coverage.
3352
3353         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3354
3355 2019-03-13  Chris Dumez  <cdumez@apple.com>
3356
3357         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
3358         https://bugs.webkit.org/show_bug.cgi?id=195684
3359         <rdar://problem/48294714>
3360
3361         Reviewed by Antti Koivisto.
3362
3363         Add API test coverage.
3364
3365         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3366
3367 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3368
3369         [ews-app] Remove unused patch view
3370         https://bugs.webkit.org/show_bug.cgi?id=195669
3371
3372         Reviewed by Lucas Forschler.
3373
3374         * BuildSlaveSupport/ews-app/ews/urls.py:
3375         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
3376
3377 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3378
3379         [ews-app] Use Buildbot result code variables
3380         https://bugs.webkit.org/show_bug.cgi?id=195668
3381
3382         Reviewed by Alexey Proskuryakov.
3383
3384         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
3385         (Buildbot): Added Buildbot result code variables.
3386         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3387         (StatusBubble._build_bubble): Used Buildbot result code variables.
3388
3389 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
3390
3391         [Flatpak] Expand submodule recursively
3392         https://bugs.webkit.org/show_bug.cgi?id=195672
3393
3394         Building WPE with flatpak was impossible without that as it was raising an exception.
3395         Also update wpebackend-fdo to match what is built in jhbuild
3396
3397         Reviewed by Philippe Normand.
3398
3399         * flatpak/flatpakutils.py:
3400         (expand_submodules_recurse):
3401         (expand_manifest):
3402         * flatpak/org.webkit.WPEModules.yaml:
3403
3404 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3405
3406         [ews-app] status bubble should be hidden for certain builds
3407         https://bugs.webkit.org/show_bug.cgi?id=194597
3408
3409         Reviewed by Dewei Zhu.
3410
3411         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3412         (StatusBubble._build_bubble):
3413         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
3414         because the patch didn't have relevant changes.
3415         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
3416         in production yet.
3417
3418 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
3419
3420         [Win] Fix a slew of simple clang-cl warnings.
3421         https://bugs.webkit.org/show_bug.cgi?id=195652
3422
3423         Reviewed by Don Olmstead.
3424
3425         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3426         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
3427
3428 2019-03-12  Justin Fan  <justin_fan@apple.com>
3429
3430         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
3431         https://bugs.webkit.org/show_bug.cgi?id=195518
3432         <rdar://problem/46322356>
3433
3434         Reviewed by Myles C. Maxfield.
3435
3436         * DumpRenderTree/DerivedSources-input.xcfilelist:
3437         * DumpRenderTree/DerivedSources-output.xcfilelist:
3438
3439 2019-03-12  Commit Queue  <commit-queue@webkit.org>
3440
3441         Unreviewed, rolling out r242825.
3442         https://bugs.webkit.org/show_bug.cgi?id=195648
3443
3444         "Broke webkitpy tests with my change to
3445         lldb_dump_class_layout.py" (Requested by rmorisset on
3446         #webkit).
3447
3448         Reverted changeset:
3449
3450         "Alter Tools/Scripts/dump-class-layout to be able to dump all
3451         classes with suspicious padding"
3452         https://bugs.webkit.org/show_bug.cgi?id=195573
3453         https://trac.webkit.org/changeset/242825
3454
3455 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3456
3457         [ews-build] Show status bubbles while the patch is waiting in queue
3458         https://bugs.webkit.org/show_bug.cgi?id=195618
3459
3460         Reviewed by Lucas Forschler.
3461
3462         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3463         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
3464         enabled in initial deployment.
3465         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
3466         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
3467         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
3468         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
3469         (StatusBubble._build_bubbles_for_patch):
3470
3471 2019-03-12  Robin Morisset  <rmorisset@apple.com>
3472
3473         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
3474         https://bugs.webkit.org/show_bug.cgi?id=195573
3475
3476         Reviewed by Simon Fraser.
3477
3478         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
3479
3480         * Scripts/dump-class-layout:
3481         (main):
3482         * lldb/lldb_dump_class_layout.py:
3483         (ClassLayout.__init__):
3484         (ClassLayout._compute_padding_recursive):
3485         (LLDBDebuggerInstance.dump_layout_for_classname):
3486         (LLDBDebuggerInstance):
3487         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
3488         (LLDBDebuggerInstance.layout_for_classname): Deleted.
3489
3490 2019-03-12  Chris Dumez  <cdumez@apple.com>
3491
3492         Device Orientation access permission should be denied unless explicitly granted by the client
3493         https://bugs.webkit.org/show_bug.cgi?id=195625
3494
3495         Reviewed by Youenn Fablet.
3496
3497         add API test coverage.
3498
3499         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3500         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
3501         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
3502         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
3503         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3504         (runDeviceOrientationTest):
3505         (TEST):
3506         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3507         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3508
3509 2019-03-12  Jer Noble  <jer.noble@apple.com>
3510
3511         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
3512         https://bugs.webkit.org/show_bug.cgi?id=195137
3513         <rdar://problem/48810307>
3514
3515         Reviewed by Eric Carlson.
3516
3517         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
3518         (TestWebKitAPI::TEST):
3519
3520 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3521
3522         [ews-build] Change urls from uat to production
3523         https://bugs.webkit.org/show_bug.cgi?id=195566
3524
3525         Reviewed by Lucas Forschler.
3526
3527         * BuildSlaveSupport/ews-app/ews/config.py:
3528         * BuildSlaveSupport/ews-build/events.py:
3529         * BuildSlaveSupport/ews-build/steps.py:
3530
3531 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3532
3533         [ews-build] change max_builds for local-worker to 1
3534         https://bugs.webkit.org/show_bug.cgi?id=195568
3535
3536         Reviewed by Lucas Forschler.
3537
3538         * BuildSlaveSupport/ews-build/loadConfig.py:
3539
3540 2019-03-12  Tim Horton  <timothy_horton@apple.com>
3541
3542         Fix the build
3543
3544         * TestRunnerShared/spi/PencilKitTestSPI.h:
3545         * TestWebKitAPI/ios/PencilKitTestSPI.h:
3546
3547 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
3548
3549         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
3550         https://bugs.webkit.org/show_bug.cgi?id=194131
3551
3552         Reviewed by Michael Catanzaro.
3553
3554         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
3555         (uriChanged):
3556         (testUnfinishedSubresourceLoad):
3557         (serverCallback):
3558         (beforeAll):
3559
3560 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3561
3562         WTF::Expected should use std::addressof instead of operator&
3563         https://bugs.webkit.org/show_bug.cgi?id=195604
3564
3565         Reviewed by Myles Maxfield.
3566
3567         * TestWebKitAPI/Tests/WTF/Expected.cpp:
3568         (TestWebKitAPI::Unique::Unique):
3569         (TestWebKitAPI::Unique::operator&):
3570         (TestWebKitAPI::TEST):
3571
3572 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
3573
3574         Add Optional to Forward.h.
3575         https://bugs.webkit.org/show_bug.cgi?id=195586
3576
3577         Reviewed by Darin Adler.
3578
3579         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
3580         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
3581         Remove unnecessary includes from headers.
3582
3583 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
3584
3585         Add testing API to hit-test and scroll overflow scrollers
3586         https://bugs.webkit.org/show_bug.cgi?id=195278
3587
3588         Reviewed by Antti Koivisto.
3589         
3590         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
3591         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
3592         
3593         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
3594
3595         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3596         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3597         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3598         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3599         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3600         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3601         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3602         (WTR::enclosingScrollViewIncludingSelf):
3603         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3604
3605 2019-03-11  Tim Horton  <timothy_horton@apple.com>
3606
3607         API test WebKit.RequestTextInputContext fails on iOS
3608         https://bugs.webkit.org/show_bug.cgi?id=195585
3609
3610         Reviewed by Wenson Hsieh and Simon Fraser.
3611
3612         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
3613         (applyStyle):
3614         (TEST):
3615         Add a viewport, so that the coordinates match up on iOS.
3616         Scroll by moving the UIScrollView's contentOffset.
3617
3618 2019-03-11  Chris Dumez  <cdumez@apple.com>
3619
3620         Assert in WebPageProxy::suspendCurrentPageIfPossible()
3621         https://bugs.webkit.org/show_bug.cgi?id=195506
3622         <rdar://problem/48733477>
3623
3624         Reviewed by Alex Christensen.
3625
3626         Add API test coverage.
3627
3628         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3629
3630 2019-03-11  Shawn Roberts  <sroberts@apple.com>
3631
3632         Adding myself to contributors.json
3633
3634         Unreviewed, addming myself to contributors.json .
3635
3636         * Scripts/webkitpy/common/config/contributors.json:
3637
3638 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3639
3640         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3641         https://bugs.webkit.org/show_bug.cgi?id=195511
3642         <rdar://problem/44873269>
3643
3644         Reviewed by Darin Adler.
3645
3646         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3647         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3648         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3649         (TEST_F):
3650
3651 2019-03-11  Chris Dumez  <cdumez@apple.com>
3652
3653         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
3654         https://bugs.webkit.org/show_bug.cgi?id=195561
3655
3656         Reviewed by Youenn Fablet.
3657
3658         Make sure the JS in the test requests for permission to receive device orientation events.
3659
3660         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3661
3662 2019-03-11  Youenn Fablet  <youenn@apple.com>
3663
3664         Allow storage quota increase by default in WTR
3665         https://bugs.webkit.org/show_bug.cgi?id=195541
3666
3667         Reviewed by Geoffrey Garen.
3668
3669         Allow storage quota increase by default in WTR.
3670         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
3671         Use this for tests that explicitly need cache increase.
3672
3673         Instead of increasing quota by 2, make sure the next request is
3674         granted by adding all given parameters.
3675
3676         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3677         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3678         (WTR::TestRunner::setAllowStorageQuotaIncrease):
3679         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
3680         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3681         * WebKitTestRunner/TestController.cpp:
3682         (WTR::TestController::setAllowStorageQuotaIncrease):
3683         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3684         * WebKitTestRunner/TestController.h:
3685         * WebKitTestRunner/TestInvocation.cpp:
3686         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3687         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3688         (WTR::TestController::cocoaResetStateToConsistentValues):
3689         (WTR::TestController::setAllowStorageQuotaIncrease):
3690         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3691         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3692         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3693
3694 2019-03-11  Xan Lopez  <xan@igalia.com>
3695
3696         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
3697        &