[GTK] Combine WebKit API tests into fewer binaries
[WebKit-https.git] / Tools / ChangeLog
1 2012-06-21  Martin Robinson  <mrobinson@igalia.com>
2
3         [GTK] Combine WebKit API tests into fewer binaries
4         https://bugs.webkit.org/show_bug.cgi?id=88458
5
6         Reviewed by Carlos Garcia Campos.
7
8         Instead of creating one binary per-test file, create binaries for each
9         category of tests. Right now this includes WTF and the WebKit2 C API,
10         but later tests can be added for the GTK+ platform layer and the WebKit1
11         and WebKit2 API layers.
12
13         * TestWebKitAPI/GNUmakefile.am: Compile only two test binaries, one for the WebKit2
14           C API and one for WTF. Refresh the source list to ensure that new test are active.
15         * gtk/run-api-tests: Change the way that tests are skipped by splitting out the
16         concept of skipping a test and skipping a suite (program) of tests. Test cases are
17         skipped because of legitimate failures, but entire programs are skipped because of
18         problems in the harness. As of right now a test program is only skipped if the
19         accessibility bus cannot be started.
20         (SkippedTest.__init__): Make the test case a required argument and have one skipped
21         test case per SkippedTest instance.
22         (SkippedTest.__str__): Ditto.
23         (TestRunner): Update the directory list. We only have two gtest binaries now and they are
24         in one directory. Reformat the test list to make it slightly easier to read.
25         (TestRunner.__init__): Add the _skipped_test_program member, which handles entire
26         test programs that are skipped.
27         (TestRunner._setup_testing_environment): Use the new member.
28         (TestRunner._test_cases_to_skip): Collect all skipped test cases now instead of just
29         the first SkippedTest that matches.
30         (TestRunner._should_run_test_program): Take a look at the new member to make this
31         decision.
32         (TestRunner._run_test_command): Use the name test_program instead of test
33         to disambiguate between test cases and test suites.
34         (TestRunner._run_test_glib): ditto.
35         (TestRunner._run_test_google): Ditto.
36         (TestRunner._run_test): Ditto.
37         (TestRunner.run_tests): Ditto.
38
39 2012-06-21  Yong Li  <yoli@rim.com>
40
41         Unreviewed. Moving myself from committer to reviewer.
42
43         * Scripts/webkitpy/common/config/committers.py:
44
45 2012-06-21  Sergio Villar Senin  <svillar@igalia.com>
46
47         [GTK] Add a new webkit2 tests slave bot
48         https://bugs.webkit.org/show_bug.cgi?id=89336
49
50         Reviewed by Philippe Normand.
51
52         Slave configuration for a new GTK bot that will run WebKit2 tests.
53
54         * BuildSlaveSupport/build.webkit.org-config/config.json:
55
56 2012-06-21  Thiago Marcos P. Santos  <thiago.santos@intel.com>
57
58         [Qt] Add a custom Color Chooser widget to MiniBrowser
59         https://bugs.webkit.org/show_bug.cgi?id=87988
60
61         Reviewed by Alexis Menard.
62
63         Added custom color chooser example for the MiniBrowser.
64
65         * MiniBrowser/qt/MiniBrowser.qrc:
66         * MiniBrowser/qt/qml/BrowserWindow.qml:
67         * MiniBrowser/qt/qml/ColorChooser.qml: Added.
68
69 2012-06-21  Vivek Galatage  <vivekgalatage@gmail.com>
70
71         Remove the warning "File not found" in MiniBrowser post-build event
72         https://bugs.webkit.org/show_bug.cgi?id=89601
73
74         Reviewed by Adam Roben.
75
76         * MiniBrowser/MiniBrowserPostBuild.cmd:
77
78 2012-06-21  Balazs Kelemen  <kbalazs@webkit.org>
79
80         [Qt] DRT in standalone mode hangs after the first test
81         https://bugs.webkit.org/show_bug.cgi?id=89613
82
83         Reviewed by Csaba Osztrogonác.
84
85         Break an inline signal slot chain that ends up in setting
86         LayoutTestController::m_hasDumped too early. In LayoutTestController::maybeDump()
87         we emit done() which starts the chain that finishes in DumpRenderTree::open().
88         The next line in maybeDump sets m_hasDumped to true. We could simply reorder
89         these two lines but it seems to be wrong in general to start the next load
90         from this call chain. The server mode (when DRT is runned by the test harness)
91         also uses a queued connection to read the next test from stdin.
92
93         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
94         (WebCore::DumpRenderTree::processArgsLine):
95
96 2012-06-20  Hans Wennborg  <hans@chromium.org>
97
98         Speech JavaScript API: SpeechRecognition should hook up with ActiveDOMObject more
99         https://bugs.webkit.org/show_bug.cgi?id=89217
100
101         Reviewed by Adam Barth.
102
103         Add a method for checking whether the mock speech
104         recognition was aborted.
105
106         Also redo the way the mock posts tasks. Instead of posting them all at once,
107         maintain an internal queue of task objects, and call postTask() for them
108         once at the time. This means that for example when the page is navigated
109         away and abort() is called, that call doesn't end up after a bunch
110         of previously posted events on the event loop.
111
112         * DumpRenderTree/chromium/LayoutTestController.cpp:
113         (LayoutTestController::LayoutTestController):
114         (LayoutTestController::wasMockSpeechRecognitionAborted):
115         * DumpRenderTree/chromium/LayoutTestController.h:
116         (LayoutTestController):
117         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
118         (WebKit::ClientCallTask::ClientCallTask):
119         (WebKit::ResultTask::ResultTask):
120         (WebKit::NoMatchTask::NoMatchTask):
121         (WebKit::ErrorTask::ErrorTask):
122         (MockWebSpeechRecognizer::start):
123         (MockWebSpeechRecognizer::abort):
124         (MockWebSpeechRecognizer::setError):
125         (MockWebSpeechRecognizer::MockWebSpeechRecognizer):
126         (MockWebSpeechRecognizer::startTaskQueue):
127         (MockWebSpeechRecognizer::StepTask::runIfValid):
128         * DumpRenderTree/chromium/MockWebSpeechRecognizer.h:
129         (MockWebSpeechRecognizer::hasBeenAborted):
130         (MockWebSpeechRecognizer):
131         (MockWebSpeechRecognizer::taskList):
132         (Task):
133         (MockWebSpeechRecognizer::Task::Task):
134         (MockWebSpeechRecognizer::Task::~Task):
135         (StepTask):
136         (MockWebSpeechRecognizer::StepTask::StepTask):
137
138 2012-06-21  Mario Sanchez Prada  <msanchez@igalia.com>
139
140         [GTK] Add support for window.showModalDialog in WebKit2GTK+
141         https://bugs.webkit.org/show_bug.cgi?id=79500
142
143         Reviewed by Carlos Garcia Campos.
144
145         Add support for modal dialogs in GTK's MiniBrowser.
146
147         * MiniBrowser/gtk/BrowserWindow.c:
148         (webViewRunAsModal):
149         (webViewCreate):
150         (webViewDecidePolicy):
151         (browser_window_new):
152         * MiniBrowser/gtk/BrowserWindow.h:
153         * MiniBrowser/gtk/main.c:
154         (createBrowserWindow):
155
156 2012-06-20  Brent Fulgham  <bfulgham@webkit.org>
157
158         [WinCairo] Unreviewed build fix.
159         The wrapper script that launched new- and old-run-webkit-tests
160         was discarding the --wincairo argument needed to get the proper
161         test infrastructure to build under WinCairo.
162
163         * Scripts/run-webkit-tests: Emulate the Qt, Wx, Chromium, etc.,
164         behavior to chain the --wincairo flag through to the new build
165         and test scripts.
166
167 2012-06-20  Mark Rowe  <mrowe@apple.com>
168
169         <http://webkit.org/b/89606> Teach run-safari and debug-safari to work with a Safari.app that has entitlements
170
171         Reviewed by Dan Bernstein.
172
173         * Scripts/webkitdirs.pm:
174         (executableHasEntitlements):
175         (safariPathFromSafariBundle):
176
177 2012-06-20  Sheriff Bot  <webkit.review.bot@gmail.com>
178
179         Unreviewed, rolling out r120821.
180         http://trac.webkit.org/changeset/120821
181         https://bugs.webkit.org/show_bug.cgi?id=89605
182
183         It made duplicated reviewer entries (Requested by Ossy on
184         #webkit).
185
186         * Scripts/webkitpy/common/checkout/changelog.py:
187         (ChangeLog.set_reviewer):
188         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
189         (test_set_reviewer):
190         (test_set_short_description_and_bug_url):
191
192 2012-06-20  Dirk Pranke  <dpranke@chromium.org>
193
194         nrwt outputs empty files for wdiff output if wdiff is not installed
195         https://bugs.webkit.org/show_bug.cgi?id=88709
196
197         Reviewed by Tony Chang.
198
199         Reviewed by Tony Chang.
200
201         Don't write -wdiff or -pretty.html files if wdiff or prettypatch
202         aren't available, and clean up the handling for them in the port
203         code.
204
205         * Scripts/webkitpy/run_webkit_tests_integrationtest.py:
206         (MainTest.test_output_diffs):
207         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
208         (TestResultWriter.create_text_diff_and_write_result):
209         * Scripts/webkitpy/layout_tests/port/base.py:
210         (Port.check_pretty_patch):
211         (Port.check_wdiff):
212         (Port._wdiff_missing_message):
213         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
214         (ChromiumLinuxPort.check_build):
215         (ChromiumLinuxPort._wdiff_missing_message):
216         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
217         (ChromiumMacPort.check_build):
218         (ChromiumMacPort):
219         (ChromiumMacPort._wdiff_missing_message):
220         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
221         (ChromiumMacPortTest):
222
223 2012-06-20  Dirk Pranke  <dpranke@chromium.org>
224
225         nrwt: fix unit tests for ensuring svn revision is correct
226         https://bugs.webkit.org/show_bug.cgi?id=89498
227
228         Reviewed by Eric Seidel.
229
230         Reviewed by Eric Seidel.
231
232         Fix the unit tests for testing that we are embedding the SVN
233         revision in the results json for NRWT properly; this was broken
234         in r120646 but because the MockHost worked differently than the
235         real one (by always initializing the MockSCM object) we didn't
236         notice. Unfortunately, just changing the default breaks all
237         sorts of unit tests ...
238
239         * Scripts/webkitpy/common/host_mock.py:
240         (MockHost.__init__):
241         (MockHost._initialize_scm):
242         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
243         (ResultSummaryTest.test_no_svn_revision):
244         (ResultSummaryTest.test_svn_revision):
245
246 2012-06-20  Dirk Pranke  <dpranke@chromium.org>
247
248         new-run-webkit-tests appends "/Debug" or "/Release" to $WEBKITOUTPUTDIR
249         https://bugs.webkit.org/show_bug.cgi?id=69360
250
251         Reviewed by Eric Seidel.
252
253         Reviewed by Eric Seidel.
254
255         Propagate the 'port_implementation' part of the platform (i.e.,
256         gtk,qt,chromium) to webkit-build-directory so that we can pick
257         up the gtk-specific handling of WEBKITOUTPUTDIR ...
258
259         I didn't write any additional tests for this; testing it
260         properly is an integration test between the python code and the
261         perl code, which I verified by hand.
262
263         * Scripts/webkitpy/layout_tests/port/base.py:
264         (Port.__init__):
265         * Scripts/webkitpy/layout_tests/port/config.py:
266         (Config.__init__):
267         (Config.build_directory):
268         * Scripts/webkitpy/layout_tests/port/config_mock.py:
269         (MockConfig.__init__):
270         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
271         (ConfigTest.test_build_directory_passes_port_implementation):
272
273 2012-06-20  Dirk Pranke  <dpranke@chromium.org>
274
275         Fix import sorting missed in r120846
276
277         Reviewed by Tony Chang.
278
279         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
280
281 2012-06-20  Dirk Pranke  <dpranke@chromium.org>
282
283         Fix chromium win http servers after breakage introduced in r120846.
284
285         Unreviewed, build fix.
286
287         * Scripts/webkitpy/layout_tests/port/base.py:
288         (Port.to.start_http_server):
289         * Scripts/webkitpy/layout_tests/servers/http_server.py:
290         (Lighttpd.__init__):
291
292 2012-06-20  Dirk Pranke  <dpranke@chromium.org>
293
294         tweak output of webkit-patch print-{baselines,expectations}
295         https://bugs.webkit.org/show_bug.cgi?id=89588
296
297         Reviewed by Tony Chang.
298
299         Minor tweaks to the output to make it more readable, including
300         turning off csv by default for print-baselines with multiple ports.
301
302         * Scripts/webkitpy/layout_tests/port/test.py:
303         (TestPort):
304         * Scripts/webkitpy/tool/commands/queries.py:
305         (PrintExpectations.execute):
306         (PrintBaselines.execute):
307         * Scripts/webkitpy/tool/commands/queries_unittest.py:
308         (PrintExpectationsTest.run_test):
309         (PrintExpectationsTest.test_multiple):
310         (PrintBaselinesTest.setUp):
311         (PrintBaselinesTest.test_multiple):
312
313 2012-06-18  Dirk Pranke  <dpranke@chromium.org>
314
315         new-run-webkit-tests should spin-up enough httpd processes to avoid timeouts
316         https://bugs.webkit.org/show_bug.cgi?id=88134
317
318         Reviewed by Tony Chang.
319
320         Change NRWT to spin up 2*min(child_processes, locked_shards)
321         http servers by default so that we are less likely to get a
322         bunch of http timeouts at the beginning of a test run.
323
324         Note that I had to tweak executive_mock to support mocked stderr
325         because the apache_http_server code reads stderr when starting a
326         process to ensure it started okay.
327
328         * Scripts/webkitpy/common/system/executive_mock.py:
329         (MockProcess.__init__):
330         * Scripts/webkitpy/common/system/outputcapture.py:
331         * Scripts/webkitpy/layout_tests/controllers/manager.py:
332         (Manager._run_tests):
333         (Manager.start_servers_with_lock):
334         * Scripts/webkitpy/layout_tests/port/base.py:
335         (Port.to.start_http_server):
336         * Scripts/webkitpy/layout_tests/port/test.py:
337         (TestPort.start_http_server):
338         (TestPort._path_to_apache):
339         (TestPort):
340         (TestPort._path_to_apache_config_file):
341         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
342         (LayoutTestApacheHttpd.__init__):
343         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py: Added
344         (LayoutTestApacheHttpd.__init__):
345         * Scripts/webkitpy/layout_tests/servers/http_server.py:
346         (Lighttpd.__init__):
347         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
348         (HttpServerBase.__init__):
349
350 2012-06-20  Tom Zakrajsek  <tomz@codeaurora.org>
351
352         Unreviewed: Back out accidentally checked in debug print which broke a test
353
354         * Scripts/webkitpy/performance_tests/perftest.py:
355         (PerfTest.parse_output):
356
357 2012-06-20  Tom Zakrajsek  <tomz@codeaurora.org>
358
359         Import themaninblue.com/experiment/AnimationBenchmark/ as performance tests
360         https://bugs.webkit.org/show_bug.cgi?id=78789
361
362         Reviewed by Ryosuke Niwa.
363
364         Updated parser to include fps as a valid unit.
365
366         * Scripts/webkitpy/performance_tests/perftest.py:
367         (PerfTest):
368         (PerfTest.parse_output):
369
370 2012-06-20  Balazs Ankes  <bank@inf.u-szeged.hu>
371
372         webkit-patch should add reviewer if "Reviewed by NOBODY ..." is missing
373         https://bugs.webkit.org/show_bug.cgi?id=67935
374
375         Reviewed by Ryosuke Niwa.
376
377         * Scripts/webkitpy/common/checkout/changelog.py:
378         (ChangeLog.set_reviewer):
379         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
380         (test_set_reviewer):
381         (test_set_short_description_and_bug_url):
382
383 2012-06-20  Simon Hausmann  <simon.hausmann@nokia.com>
384
385         Unreviewed trivial permissions fix.
386
387         * qmake/mkspecs/features/features.prf: Don't mark this file as executable.
388
389 2012-06-19  Ryuan Choi  <ryuan.choi@samsung.com>
390
391         [EFL][Regression] Build break after r120786
392         https://bugs.webkit.org/show_bug.cgi?id=89549
393
394         Unreviewed build fix for Efl port.
395
396         * DumpRenderTree/efl/CMakeLists.txt: Added disassembler in includes.
397
398 2012-06-19  Dirk Pranke  <dpranke@chromium.org>
399
400         NRWT spins up and down the WebSocket server when running a single HTTP test from the command line
401         https://bugs.webkit.org/show_bug.cgi?id=64489
402
403         Reviewed by Tony Chang.
404
405         This change changes NRWT so that we don't start the websocket
406         server if we aren't running websocket tests and don't start the
407         HTTP server if we aren't running http tests.
408         
409         * Scripts/webkitpy/layout_tests/controllers/manager.py:
410         (Manager._websocket_tests):
411         (Manager.start_servers_with_lock):
412         (Manager.stop_servers_with_lock):
413         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
414         (ManagerTest.test_servers_started):
415
416 2012-06-19  Dirk Pranke  <dpranke@chromium.org>
417
418         test-webkitpy: add a -p flag to pass through captured output to enable debugging
419         https://bugs.webkit.org/show_bug.cgi?id=89158
420
421         Reviewed by Eric Seidel.
422
423         Normally when outputcapture runs it intercepts stdout/stderr,
424         which makes running under the debugger difficult and mostly
425         pointless (since you can't see any output). This change adds a
426         flag to test-webkitpy (-p) that will cause outputcapture to pass
427         through the output as well as capture it.
428
429         * Scripts/webkitpy/common/system/outputcapture.py:
430         (OutputCapture.stream_wrapper):
431         (OutputCapture._capture_output_with_name):
432         * Scripts/webkitpy/common/system/outputcapture_unittest.py:
433         (OutputCaptureTest.setUp):
434         * Scripts/webkitpy/test/main.py:
435         (Tester._parse_args):
436         (Tester._run_tests):
437         (Tester._log_exception):
438         (_CaptureAndPassThroughStream):
439         (_CaptureAndPassThroughStream.__init__):
440         (_CaptureAndPassThroughStream.write):
441         (_CaptureAndPassThroughStream._message_is_from_pdb):
442         (_CaptureAndPassThroughStream.flush):
443         (_CaptureAndPassThroughStream.getvalue):
444
445 2012-06-19  Adam Barth  <abarth@webkit.org>
446
447         garden-o-matic fails to rebaseline tests with MISSING results
448         https://bugs.webkit.org/show_bug.cgi?id=89521
449
450         Reviewed by Kenneth Russell.
451
452         If the bots report "MISSING", we should try to find PNG and TXT results on the server.
453
454         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
455
456 2012-06-19  Adam Barth  <abarth@webkit.org>
457
458         svn.delete_list fails to delete empty parent directories
459         https://bugs.webkit.org/show_bug.cgi?id=89520
460
461         Reviewed by Dirk Pranke.
462
463         These functions were calling scm.delete and scm.add, which already
464         delete the parent directory. We'd get an exception when we tried to
465         delete the parent directory again.
466
467         * Scripts/webkitpy/common/checkout/scm/svn.py:
468         (SVN._add_parent_directories):
469         (SVN._delete_parent_directories):
470
471 2012-06-19  Thiago Marcos P. Santos  <thiago.santos@intel.com>
472
473         webkitpy: Simplify fetch_bugs_matching_search()
474         https://bugs.webkit.org/show_bug.cgi?id=89497
475
476         Reviewed by Adam Barth.
477
478         Removed parameter with default value. It's not being used
479         and the handling of the parameter was wrong. Saves a check.
480
481         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
482         (BugzillaQueries.fetch_bugs_matching_search):
483         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
484         (MockBugzillaQueries.fetch_bugs_matching_search):
485
486 2012-06-19  Dirk Pranke  <dpranke@chromium.org>
487
488         webkitpy: remove unneeded imports in layout_tests/port/chromium.py
489         https://bugs.webkit.org/show_bug.cgi?id=89522
490
491         Reviewed by Eric Seidel.
492
493         They were no longer being used. No tests necessary.
494
495         * Scripts/webkitpy/layout_tests/port/chromium.py:
496
497 2012-06-19  Adam Barth  <abarth@webkit.org>
498
499         Missing results aren't shown in garden-o-matic
500
501         Reviewed by Kenneth Russell.
502
503         Previously we didn't know to look for text and image results when the
504         bot told us that results were missing.
505
506         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
507
508 2012-06-19  Dirk Pranke  <dpranke@chromium.org>
509
510         Fix regression introduced in r120646 where the svn revision isn't saved in results.json
511
512         Unreviewed, build fix.
513
514         It turns out that we store the svn revision two different ways
515         in the JSON, and I only caught one of them :(. This should fix
516         the other.
517
518         Also, this part of the code is poorly tested. I will investigate
519         adding at least a basic test for this in a separate fix.
520
521         * Scripts/webkitpy/layout_tests/controllers/manager.py:
522         (summarize_results):
523
524 2012-06-19  Dirk Pranke  <dpranke@chromium.org>
525
526         REGRESSION (NRWT): Results for new non-text-only tests are always put in the most-specific platform directory
527         https://bugs.webkit.org/show_bug.cgi?id=78127
528
529         Reviewed by Ryosuke Niwa.
530
531         Add the --add-platform-exceptions flag from ORWT, and ensure
532         that --new-baseline is equivalent to --reset-results
533         --add-platform-exceptions. Also fix the default logic for where to
534         put PNGs and render tree dumps if --new-test-results is true:
535         if --add-platform-exceptions is False, baselines should go in
536         the least-specific platform directory (e.g., platform/mac)
537         rather than the most-specific (platform/mac-snowleopard).
538
539         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
540         (SingleTestRunner):
541         (SingleTestRunner.run):
542         (SingleTestRunner._run_rebaseline):
543         (SingleTestRunner._add_missing_baselines):
544         (SingleTestRunner._location_for_new_baseline):
545         (SingleTestRunner._overwrite_baselines):
546         (SingleTestRunner._save_baseline_data):
547         * Scripts/webkitpy/layout_tests/port/base.py:
548         (Port.baseline_path):
549         (Port):
550         (Port.baseline_platform_dir):
551         (Port.baseline_version_dir):
552         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
553         (_set_up_derived_options):
554         (parse_args):
555         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
556         (RebaselineTest.assertBaselines):
557         (RebaselineTest.test_reset_results):
558         (RebaselineTest.test_missing_results):
559         (RebaselineTest.test_new_baseline):
560
561 2012-06-19  Dirk Pranke  <dpranke@chromium.org>
562
563         NRWT should not take memory used as disk cache into account when deciding how many processes to launch
564         https://bugs.webkit.org/show_bug.cgi?id=81379
565
566         Reviewed by Eric Seidel.
567
568         The 'free memory' calculation we were running on the mac seemed
569         to underestimate how many children we can run in parallel, and
570         it was complex. This patch replaces that calculation with a
571         simpler one that reserves 2GB for overhead and assumes 256MB per
572         DRT/WTR, so if we had 4GB of RAM we can run up to 8 DRTs.
573
574         Also, there was a bug where we were truncating the memory
575         installed on the machine to 4GB by casting to an int instead of
576         a long; this was probably the source of some of the earlier
577         problems when using total memory.
578
579         This patch also removes the no-longer-needed restrictions on the
580         number of workers on beefy Lion boxes for both Apple Mac and Chromium
581         Mac; we should now use all of the cores by default.
582
583         The memory calculations have only been implemented on the mac;
584         having the calculation in base.default_child_processes() was IMO
585         misleading, and so this patch also moves the computation into
586         the MacPort. I have not heard of the # of workers being an issue
587         on any other ports, so this should be fine.
588
589         * Scripts/webkitpy/common/system/platforminfo.py:
590         (PlatformInfo.total_bytes_memory):
591         * Scripts/webkitpy/common/system/platforminfo_mock.py:
592         (PlatformInfo.total_bytes_memory):
593         (PlatformInfo.total_bytes_memory):
594         (PlatformInfo._win_version_tuple_from_cmd):
595         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
596         (TestPlatformInfo.test_total_bytes_memory):
597         * Scripts/webkitpy/layout_tests/port/base.py:
598         (Port.default_child_processes):
599         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
600         (PortTest.test_default_child_processes):
601         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
602         (ChromiumMacPort.operating_system):
603         * Scripts/webkitpy/layout_tests/port/mac.py:
604         (MacPort.default_child_processes):
605         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
606         (TestMacPort.test_default_child_processes):
607
608 2012-06-19  Dirk Pranke  <dpranke@chromium.org>
609
610         new-run-webkit-tests reports unexpected pass of pixel tests when pixel testing is disabled
611         https://bugs.webkit.org/show_bug.cgi?id=85446
612
613         Reviewed by Simon Fraser.
614
615         Embed whether pixel testing was enabled into the results.json.
616
617         * Scripts/webkitpy/layout_tests/controllers/manager.py:
618         (summarize_results):
619
620 2012-06-19  Zoltan Horvath  <zoltan@webkit.org>
621
622         [Qt] Modify HTTPS port to 8443 for performance tests
623         https://bugs.webkit.org/show_bug.cgi?id=89442
624
625         Reviewed by Ryosuke Niwa.
626
627         We should be consistent with the default HTTPS port and with the changelog of r119188.
628
629         * Scripts/webkitpy/performance_tests/perftest.py:
630         (ReplayServer.__init__):
631
632 2012-06-19  Mike West  <mkwst@chromium.org>
633
634         Introduce ENABLE_CSP_NEXT configuration flag.
635         https://bugs.webkit.org/show_bug.cgi?id=89300
636
637         Reviewed by Adam Barth.
638
639         The 1.0 draft of the Content Security Policy spec is just about to
640         move to Last Call. We'll hide work on the upcoming 1.1 spec behind
641         this ENABLE flag, disabled by default.
642
643         Spec: https://dvcs.w3.org/hg/content-security-policy/raw-file/tip/csp-specification.dev.html
644
645         * Scripts/webkitperl/FeatureList.pm:
646         * qmake/mkspecs/features/features.pri:
647
648 2012-06-19  Christophe Dumez  <christophe.dumez@intel.com>
649
650         [EFL] EFL's LayoutTestController does not support setTextDirection
651         https://bugs.webkit.org/show_bug.cgi?id=87481
652
653         Reviewed by Hajime Morita.
654
655         Implement setTextDirection in EFL's LayoutTestController and
656         properly reset its value between test cases to avoid flakiness.
657
658         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
659         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
660         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
661         (LayoutTestController::setTextDirection):
662
663 2012-06-19  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
664
665         [Qt] Temporarily disable xvfb driver in nrwt
666         https://bugs.webkit.org/show_bug.cgi?id=88414
667
668         Reviewed by Csaba Osztrogonác.
669
670         * Scripts/webkitpy/layout_tests/port/qt.py:
671         (QtPort._build_driver):
672
673 2012-06-18  Joone Hur  <joone.hur@intel.com>
674
675         [EFL] Fontconfig can't be linked properly
676         https://bugs.webkit.org/show_bug.cgi?id=89418
677
678         Unreviewed build fix.
679
680         Make Fontconfig be linked correctly.
681
682         * MiniBrowser/efl/CMakeLists.txt: add FONTCONFIG_LIBRARIES to MiniBrowser_LIBRARIES.
683
684 2012-06-18  Joone Hur  <joone.hur@intel.com>
685
686         Unreviewed. Updating email for committers.py script.
687
688         * Scripts/webkitpy/common/config/committers.py:
689
690 2012-06-18  Simon Fraser  <simon.fraser@apple.com>
691
692         Fix a typo that caused TestFailures to have a syntax error.
693         
694         Sadly TestFailures is broken for another reason now too:
695         https://bugs.webkit.org/show_bug.cgi?id=89419
696
697         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js:
698         (ViewController.prototype._domForBuildName):
699
700 2012-06-18  Simon Fraser  <simon.fraser@apple.com>
701
702         Provide bug links for suspicious commits
703         https://bugs.webkit.org/show_bug.cgi?id=89408
704         
705         Reviewed by Adam Barth.
706
707         Add links to bugs for the suspicious commits if we have bug data.
708
709         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Bugzilla.js:
710         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
711         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
712         (ol.notifications>li ul.causes>li>div.description>span>span.bugID::before):
713         (ol.notifications>li ul.causes>li>div.description>span>span.bugID>a):
714
715 2012-06-18  Amy Ousterhout  <aousterh@chromium.org>
716
717         [Chromium] DeviceOrientation Cleanup
718         https://bugs.webkit.org/show_bug.cgi?id=89354
719
720         Reviewed by Kent Tamura.
721
722         * DumpRenderTree/chromium/WebViewHost.h: added OVERRIDE specifier for virtual function
723         (WebViewHost):
724
725 2012-06-18  James Robinson  <jamesr@chromium.org>
726
727         [chromium] Stop passing deprecated 'direct' parameter to webkit_support::CreateGraphicsContext3D
728         https://bugs.webkit.org/show_bug.cgi?id=89254
729
730         Reviewed by Adrienne Walker.
731
732         This parameter doesn't mean anything since this codepath is only used for onscreen contexts and is deprecated
733         upstream.
734
735         * DumpRenderTree/chromium/WebViewHost.cpp:
736         (WebViewHost::createGraphicsContext3D):
737
738 2012-06-18  Simon Fraser  <simon.fraser@apple.com>
739
740         Minor fix suggested by Adam Barth.
741
742         Use $(this._what).empty(); rather than removing children one at a time.
743         For some reason removeAllChildren() is undefined on this node.
744         
745         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
746
747 2012-06-18  Simon Fraser  <simon.fraser@apple.com>
748
749         Show TOT revision in garden-o-matic, and make the revisions into links
750         https://bugs.webkit.org/show_bug.cgi?id=89396
751
752         Reviewed by Adam Barth.
753
754         The "latest revision" notification now reads "Latest revision processed by every bot: NN (trunk is at NN)"
755         where the revisions are links to trac.
756         
757         To avoid setting innerHTML, I made base.createLinkNode() and used it in a bunch of places, which had
758         the knock-on effect of flipping the target and href attributes for anchors in some test output.
759
760         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js:
761         (ViewController.prototype._displayTesters.updateList.list):
762         (ViewController.prototype._displayTesters.updateList):
763         (ViewController.prototype._domForRegressionRange.trac.commitDataForRevisionRange):
764         (ViewController.prototype._domForRegressionRange):
765         (ViewController.prototype._domForAuxiliaryUIElements):
766         (ViewController.prototype._domForBuildName):
767         (ViewController.prototype):
768         (ViewController.prototype.):
769         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
770         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
771         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
772         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
773         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
774
775 2012-06-18  Csaba Osztrogonác  <ossy@webkit.org>
776
777         REGRESSION(r100558): NRWT should work without SVN or GIT
778         https://bugs.webkit.org/show_bug.cgi?id=76630
779
780         Reviewed by Dirk Pranke.
781
782         NRWT is not supposed to have a requirement that we have an
783         actual SVN or Git checkout, and we were unnecessarily
784         initializing the checkout. This patch removes that line :).
785
786         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
787         (main):
788
789 2012-06-18  Zan Dobersek  <zandobersek@gmail.com>
790
791         [garden-o-matic] Add support for the GTK builders
792         https://bugs.webkit.org/show_bug.cgi?id=89360
793
794         Reviewed by Adam Barth.
795
796         Add the 'gtk' platform, essentially a copy of the 'apple' platform since
797         both get their data from build.webkit.org.
798
799         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
800         (.):
801
802 2012-06-18  Nico Weber  <thakis@chromium.org>
803
804         [chromium/mac] Unbreak smooth scrolling.
805         https://bugs.webkit.org/show_bug.cgi?id=89327
806
807         Reviewed by Dimitri Glazkov.
808
809         Broken by Sam in r115589 / r115591.
810
811         * DumpRenderTree/mac/DumpRenderTree.mm:
812         (resetDefaultsToConsistentValues):
813         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
814         (TestWebKitAPI::InjectedBundleController::platformInitialize):
815         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
816         (WTR::InjectedBundle::platformInitialize):
817
818 2012-06-18  Sheriff Bot  <webkit.review.bot@gmail.com>
819
820         Unreviewed, rolling out r120541, r120547, and r120548.
821         http://trac.webkit.org/changeset/120541
822         http://trac.webkit.org/changeset/120547
823         http://trac.webkit.org/changeset/120548
824         https://bugs.webkit.org/show_bug.cgi?id=89383
825
826         This approach doesn't work for WebKit2 (Requested by abarth on
827         #webkit).
828
829         * DumpRenderTree/LayoutTestController.cpp:
830         (setBackingScaleFactorCallback):
831         (LayoutTestController::staticFunctions):
832         * DumpRenderTree/LayoutTestController.h:
833         (LayoutTestController):
834         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
835         (LayoutTestController::setBackingScaleFactor):
836         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
837         (LayoutTestController::setBackingScaleFactor):
838         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
839         (LayoutTestController::setBackingScaleFactor):
840         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
841         (LayoutTestController::setBackingScaleFactor):
842         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
843         (LayoutTestController::setBackingScaleFactor):
844         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
845         (LayoutTestController::setBackingScaleFactor):
846         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
847         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
848         (WTR::InjectedBundle::didReceiveMessage):
849         (WTR::InjectedBundle::postSetBackingScaleFactor):
850         (WTR):
851         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
852         (InjectedBundle):
853         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
854         (WTR::LayoutTestController::setBackingScaleFactor):
855         (WTR):
856         (WTR::LayoutTestController::callSetBackingScaleFactorCallback):
857         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
858         (LayoutTestController):
859         * WebKitTestRunner/TestInvocation.cpp:
860         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
861
862 2012-06-18  Zan Dobersek  <zandobersek@gmail.com>
863
864         REGRESSION(r120546): It made 3 webkitpy tests fail
865         https://bugs.webkit.org/show_bug.cgi?id=89332
866
867         Reviewed by Adam Barth.
868
869         Update the BaselineOptimizer unittest after r120546.
870
871         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
872         (BaselineOptimizerTest.test_no_add_mac_future):
873         (BaselineOptimizerTest.test_mac_future):
874         (BaselineOptimizerTest.test_complex_shadowing):
875
876 2012-06-18  Dirk Pranke  <dpranke@chromium.org>
877
878         new-run-webkit-tests output gets confused when logging
879         https://bugs.webkit.org/show_bug.cgi?id=63793
880
881         Reviewed by Adam Barth.
882
883         Ship all of the log messages generated in the worker back
884         to the manager; this allows the messages to be properly
885         serialized to stderr and for the meter to flush its output correctly.
886
887         Note however that this will likely result in messages to be
888         logged out of order between workers; I'm not sure that there's
889         an easy way to fix this short of buffering a potentially
890         unbounded amount of data. It might be better to just log through
891         stderr unless we're in 'metering' mode, but it's also worth
892         noting that we already get messages out of order through stderr
893         on Windows.
894
895         * Scripts/webkitpy/layout_tests/controllers/manager.py:
896         (Manager.handle_done):
897         (Manager.handle_finished_test):
898         (Manager._log_messages):
899         * Scripts/webkitpy/layout_tests/controllers/worker.py:
900         (Worker.__init__):
901         (Worker._set_up_logging):
902         (Worker.run):
903         (Worker._run_test):
904         (Worker.cleanup):
905         (Worker.run_single_test):
906         (_WorkerLogHandler):
907         (_WorkerLogHandler.__init__):
908         (_WorkerLogHandler.emit):
909         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
910         (MeteredStream.write):
911         (MeteredStream.writeln):
912         * Scripts/webkitpy/layout_tests/views/printing.py:
913         (Printer.writeln):
914
915 2012-06-18  Zan Dobersek  <zandobersek@gmail.com>
916
917         [garden-o-matic] Builder names without underscores cause incorrect BuildSelector behavior
918         https://bugs.webkit.org/show_bug.cgi?id=89362
919
920         Reviewed by Simon Fraser.
921
922         Replace white spaces, braces and dots in the builder name with underscores. This
923         way the JQuery tabs will be properly matched with the according container.
924
925         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
926
927 2012-06-18  Dirk Pranke  <dpranke@chromium.org>
928
929         nrwt: metered output doesn't handle ^C cleanly
930         https://bugs.webkit.org/show_bug.cgi?id=89249
931
932         Reviewed by Tony Chang.
933
934         If you ctrl-c a running nrwt (w/o --verbose), then all but
935         two characters of the last update are erased, and then we print
936         "interrupted, exiting" as an update, which itself then gets
937         erased. Fix this so that we flush the meter (making the last
938         update persistent, so that we print the ^C for a visual clue),
939         print the interrupt message, and move on ...
940
941         * Scripts/webkitpy/layout_tests/controllers/manager.py:
942         (Manager._run_tests):
943         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
944         (MeteredStream.flush):
945         * Scripts/webkitpy/layout_tests/views/printing.py:
946         (Printer._write):
947         (Printer):
948         (Printer.flush):
949
950 2012-06-18  Xianzhu Wang  <wangxianzhu@chromium.org>
951
952         [Chromium] Change back "linuxish" to "linux" and include WebFontRendering.cpp on Android
953         https://bugs.webkit.org/show_bug.cgi?id=89228
954
955         Reviewed by Tony Chang.
956
957         * DumpRenderTree/chromium/LayoutTestController.cpp:
958         * DumpRenderTree/chromium/TestShellAndroid.cpp:
959
960 2012-06-18  Mario Sanchez Prada  <msanchez@igalia.com>
961
962         [GTK] Get rid of DumpRenderTreeSupportGtk::{in|de}crementAccessibilityValue
963         https://bugs.webkit.org/show_bug.cgi?id=89226
964
965         Reviewed by Martin Robinson.
966
967         Implement increment() and decrement() functions in term of the AtkValue interface,
968         instead of using DumpRenderTreeSupportGtk helper class.
969
970         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
971         (AccessibilityUIElement::intValue):
972         (AccessibilityUIElement::minValue):
973         (AccessibilityUIElement::maxValue):
974         (alterCurrentValue):
975         (AccessibilityUIElement::increment):
976         (AccessibilityUIElement::decrement):
977
978 2012-06-17  Simon Fraser  <simon.fraser@apple.com>
979
980         garden-o-matic 'Results' panel is broken for the Apple platform
981         https://bugs.webkit.org/show_bug.cgi?id=89310
982
983         Reviewed by Adam Barth.
984         
985         For platforms that don't use accumulated build directories on the server,
986         carry along buildLocation data with buildInfo, so that we know where to
987         look for the test results files for a given test.
988         
989         Renamed historicalResultsSummaryURLs to historicalResultsLocations because
990         it now returns an array of objects with buildNumber, revision and url info.
991         
992         Fixed results.fetchResultsURLs() to use this data to find results.
993         
994         Fixed the results display to not scroll when you click on a test to see the results.
995         Made the h3s look less ugly
996         
997         Don't try to show the flakiness dashboard for the Apple platform.
998
999         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
1000         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1001         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
1002         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1003         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1004         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
1005         (.results-view .top-panel):
1006         (.results-view h3):
1007
1008 2012-06-16  Simon Fraser  <simon.fraser@apple.com>
1009
1010         Make garden-o-matic work for the Apple Mac port
1011         https://bugs.webkit.org/show_bug.cgi?id=84642
1012
1013         Reviewed by Adam Barth.
1014         
1015         Make garden-o-matic work for the Apple, webkit.org-hosted builders and testers. This involved
1016         educating the scripts in various ways:
1017         * Wrap up platform-related differences in config.kPlatforms[]
1018         * Add a <select> to switch between platforms, and support a url parameter, ?platform=chromium/apple
1019         * The webkit.org bots don't accumulate test results into a single directory like the chromium.org ones do,
1020           so add config.haveBuilderAccumulatedResults and logic in fetchResultsByBuilder() to find the most
1021           recent build with valid results.
1022         * The webkit.org bots often generate results directories with no layout test data (e.g. when testers
1023           try to test a build that has already been deleted). Make walkHistory() more robust here.
1024         * webkit.org uses differently named test result directories, that include the SVN revision as
1025           well as the build number. That forces us to fetch more build info before we can get the
1026           result directory URL.
1027         * chromium.org serves raw directory listings for a builder's results directories. webkit.org serves
1028           those with Twisted, so rather than scrape directory listings, we use buildbot JSON to find results
1029           dirs.
1030         * Various URLs differ between webkit.org and chromium.org
1031         * Better UI for the failures info, so that some info is visible even when not hovered.
1032
1033         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1034         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/LayoutTestResultsLoader.js:
1035         (LayoutTestResultsLoader.prototype.set _fetchAndParseNRWTResults):
1036         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
1037         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1038         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
1039         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js:
1040         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
1041         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
1042         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js:
1043         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1044         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
1045         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
1046         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/perf.js:
1047         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
1048         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
1049         (ol.notifications>li table.failures):
1050         (ol.notifications>li:hover table.failures):
1051         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
1052         (#onebar #platform-picker):
1053         * Scripts/webkitpy/layout_tests/port/builders.py:
1054
1055 2012-06-16  Sheriff Bot  <webkit.review.bot@gmail.com>
1056
1057         Unreviewed, rolling out r120536.
1058         http://trac.webkit.org/changeset/120536
1059         https://bugs.webkit.org/show_bug.cgi?id=89296
1060
1061         Does not compile on chromium-linux (Requested by abarth on
1062         #webkit).
1063
1064         * DumpRenderTree/chromium/LayoutTestController.cpp:
1065         (LayoutTestController::reset):
1066         (LayoutTestController::setTextSubpixelPositioning):
1067         * DumpRenderTree/chromium/TestShellAndroid.cpp:
1068
1069 2012-06-16  Adam Barth  <abarth@webkit.org>
1070
1071         layoutTestController.setBackingScaleFactor is redundant with (and less awesome than) internals.settings.setDeviceScaleFactor
1072         https://bugs.webkit.org/show_bug.cgi?id=89274
1073
1074         Reviewed by Levi Weintraub.
1075
1076         Delete (mostly stub) implementations of layoutTestController.setBackingScaleFactor.
1077         Note: The WebKit2 API that setBackingScaleFactor exercises is still
1078         tested by API-level tests.
1079
1080         * DumpRenderTree/LayoutTestController.cpp:
1081         (LayoutTestController::staticFunctions):
1082         * DumpRenderTree/LayoutTestController.h:
1083         (LayoutTestController):
1084         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
1085         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1086         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1087         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1088         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1089         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1090         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1091         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1092         (WTR::InjectedBundle::didReceiveMessage):
1093         (WTR):
1094         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1095         (InjectedBundle):
1096         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1097         (WTR):
1098         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1099         (LayoutTestController):
1100         * WebKitTestRunner/TestInvocation.cpp:
1101         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1102
1103 2012-06-16  Xianzhu Wang  <wangxianzhu@chromium.org>
1104
1105         [Chromium] Move chromium/public/linuxish/WebFontRendering.h out of linuxish directory
1106         https://bugs.webkit.org/show_bug.cgi?id=89228
1107
1108         Reviewed by Tony Chang.
1109
1110         * DumpRenderTree/chromium/LayoutTestController.cpp:
1111         (LayoutTestController::reset):
1112         (LayoutTestController::setTextSubpixelPositioning):
1113         * DumpRenderTree/chromium/TestShellAndroid.cpp:
1114
1115 2012-06-15  Adam Barth  <abarth@webkit.org>
1116
1117         garden-o-matic's results.js should use RequestTracker
1118         https://bugs.webkit.org/show_bug.cgi?id=89257
1119
1120         Reviewed by Dimitri Glazkov.
1121
1122         We wrote results.js before we recognized the RequestTracker pattern.
1123         This patch replaces the manual implementations of RequestTracker with
1124         the real deal.
1125
1126         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
1127
1128 2012-06-15  Darin Adler  <darin@apple.com>
1129
1130         * Scripts/webkitpy/bindings: Added property svn:ignore.
1131
1132 2012-06-15  Sheriff Bot  <webkit.review.bot@gmail.com>
1133
1134         Unreviewed, rolling out r120511.
1135         http://trac.webkit.org/changeset/120511
1136         https://bugs.webkit.org/show_bug.cgi?id=89255
1137
1138         Breaks at least Android builder (Requested by wangxianzhu on
1139         #webkit).
1140
1141         * DumpRenderTree/chromium/LayoutTestController.cpp:
1142         (LayoutTestController::reset):
1143         (LayoutTestController::setTextSubpixelPositioning):
1144
1145 2012-06-15  Xianzhu Wang  <wangxianzhu@chromium.org>
1146
1147         [Chromium] Move chromium/public/linuxish/WebFontRendering.h out of linuxish directory
1148         https://bugs.webkit.org/show_bug.cgi?id=89228
1149
1150         Reviewed by Tony Chang.
1151
1152         * DumpRenderTree/chromium/LayoutTestController.cpp:
1153         (LayoutTestController::reset):
1154         (LayoutTestController::setTextSubpixelPositioning):
1155
1156 2012-06-15  Dirk Pranke  <dpranke@chromium.org>
1157
1158         webkitpy: remove DummyOptions and clean up the code in Port.get_option() and Port.set_option_default()
1159         https://bugs.webkit.org/show_bug.cgi?id=89135
1160
1161         Re-land change in r120370 with fix in
1162         PortFactory.get_from_builder_name() that changes BuilderOptions
1163         to an actual optparse.Values object.
1164
1165         * Scripts/webkitpy/layout_tests/port/base.py:
1166         (Port.__init__):
1167         (Port.get_option):
1168         (Port.set_option_default):
1169         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1170         (ChromiumWinTest.test_setup_environ_for_server_register_cygwin):
1171         * Scripts/webkitpy/layout_tests/port/factory.py:
1172         (_builder_options):
1173         (PortFactory.get_from_builder_name):
1174         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1175         (FactoryTest.test_get_from_builder_name):
1176         * Scripts/webkitpy/style/checkers/test_expectations.py:
1177         (TestExpectationsChecker._determine_port_from_expectations_path):
1178         * Scripts/webkitpy/tool/mocktool.py:
1179         (MockOptions.ensure_value):
1180
1181 2012-06-15  Bill Budge  <bbudge@chromium.org>
1182
1183         Add bbudge@chromium.org to committers.py
1184
1185         Unreviewed.
1186
1187         * Scripts/webkitpy/common/config/committers.py:
1188
1189 2012-06-15  Csaba Osztrogonác  <ossy@webkit.org>
1190
1191         Unreviewed style fix after r120351.
1192
1193         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
1194         (body.interface):
1195
1196 2012-06-15  Csaba Osztrogonác  <ossy@webkit.org>
1197
1198         master.cfg cleanup, remove unnecessary workaround
1199         https://bugs.webkit.org/show_bug.cgi?id=88994
1200
1201         Reviewed by Lucas Forschler.
1202
1203         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1204         (loadBuilderConfig):
1205
1206 2012-06-15  Dirk Pranke  <dpranke@chromium.org>
1207
1208         webkit-patch rebaseline-expectations should only rebaseline the appropriate suffixes for the failure in question
1209         https://bugs.webkit.org/show_bug.cgi?id=88581
1210
1211         Reviewed by Adam Barth.
1212
1213         Make sure we only optimize the suffixes we rebaselined during
1214         rebaseline-expectations, and not all suffixes for a test.
1215         While optimizing is somewhere between harmless and good, it's also confusing :)
1216
1217         * Scripts/webkitpy/tool/commands/rebaseline.py:
1218         (RebaselineExpectations._rebaseline_port):
1219         (RebaselineExpectations.execute):
1220         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1221
1222 2012-06-15  Csaba Osztrogonác  <ossy@webkit.org>
1223
1224         Update builder.html template for newer buildmaster
1225         https://bugs.webkit.org/show_bug.cgi?id=89207
1226
1227         Rebasing builder.html template from v0.8.3 to v0.8.6p1.
1228
1229         Reviewed by Zoltan Herczeg.
1230
1231         * BuildSlaveSupport/build.webkit.org-config/templates/builder.html:
1232
1233 2012-06-15  Csaba Osztrogonác  <ossy@webkit.org>
1234
1235         Add ForceScheduler to build.webkit.org
1236         https://bugs.webkit.org/show_bug.cgi?id=88982
1237
1238         Reviewed by Ryosuke Niwa.
1239
1240         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1241         (loadBuilderConfig):
1242
1243 2012-06-15  Christophe Dumez  <christophe.dumez@intel.com>
1244
1245         [EFL][WK2] Add title support to Ewk_View
1246         https://bugs.webkit.org/show_bug.cgi?id=89095
1247
1248         Reviewed by Kenneth Rohde Christiansen.
1249
1250         Update the MiniBrowser so it listens for the "title,change"
1251         signal on the view and keeps the browser window title
1252         up-to-date.
1253
1254         * MiniBrowser/efl/main.c:
1255         (on_title_changed):
1256         (browserCreate):
1257
1258 2012-06-15  Christophe Dumez  <christophe.dumez@intel.com>
1259
1260         [WK2][EFL] Implement navigation back/forward in Ewk_View
1261         https://bugs.webkit.org/show_bug.cgi?id=89173
1262
1263         Reviewed by Kenneth Rohde Christiansen.
1264
1265         Implement navigation back / forward in MiniBrowser. Use
1266         'F1' to navigate back and 'F2' to navigate forward.
1267
1268         * MiniBrowser/efl/main.c:
1269         (on_key_down):
1270
1271 2012-06-15  Christophe Dumez  <christophe.dumez@intel.com>
1272
1273         [EFL] EFL's LayoutTestController does not support titleTextDirection
1274         https://bugs.webkit.org/show_bug.cgi?id=86475
1275
1276         Reviewed by Hajime Morita.
1277
1278         Add titleTextDirection getter and setter to LayoutTestController and
1279         expose its value to JavaScript.
1280         Update the titleTextDirection value from EFL's "title,changed"
1281         callback in DumpRenderTree.
1282
1283         * DumpRenderTree/LayoutTestController.cpp:
1284         (LayoutTestController::LayoutTestController):
1285         (getTitleTextDirectionCallback):
1286         (LayoutTestController::staticValues):
1287         * DumpRenderTree/LayoutTestController.h:
1288         (LayoutTestController::titleTextDirection):
1289         (LayoutTestController::setTitleTextDirection):
1290         (LayoutTestController):
1291         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1292         (DumpRenderTreeChrome::onFrameTitleChanged):
1293
1294 2012-06-15  Christophe Dumez  <christophe.dumez@intel.com>
1295
1296         [EFL][WK2] Implement reload / stop in Ewk_View
1297         https://bugs.webkit.org/show_bug.cgi?id=89168
1298
1299         Reviewed by Kenneth Rohde Christiansen.
1300
1301         Implement view reload / stop loading in MiniBrowser.
1302         Use 'F5' for reload and 'F6' for stopping the load.
1303
1304         * MiniBrowser/efl/main.c:
1305         (on_key_down):
1306         (browserCreate):
1307
1308 2012-06-15  Hironori Bono  <hbono@chromium.org>
1309
1310         Allow platforms to choose whether to remove markers on editing
1311         https://bugs.webkit.org/show_bug.cgi?id=88838
1312
1313         Reviewed by Hajime Morita.
1314
1315         This change implements WebViewHost::checkTextOfParagraph so DumpRenderTree can
1316         run grammar tests.
1317
1318         * DumpRenderTree/chromium/WebViewHost.cpp:
1319         (WebViewHost::checkTextOfParagraph): Implement this function with our mock spell checker and grammar checker.
1320         * DumpRenderTree/chromium/WebViewHost.h:
1321         (WebViewHost): Override WebSpellCheckClient::checkTextOfParagraph.
1322
1323 2012-06-15  Sheriff Bot  <webkit.review.bot@gmail.com>
1324
1325         Unreviewed, rolling out r120370.
1326         http://trac.webkit.org/changeset/120370
1327         https://bugs.webkit.org/show_bug.cgi?id=89183
1328
1329         Broke webkit-patch rebaseline (Requested by zdobersek on
1330         #webkit).
1331
1332         * Scripts/webkitpy/layout_tests/port/base.py:
1333         (DummyOptions):
1334         (DummyOptions.__init__):
1335         (DummyOptions.__init__.this):
1336         (Port.__init__):
1337         (Port.get_option):
1338         (Port.set_option_default):
1339         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1340         (ChromiumWinTest.RegisterCygwinOption):
1341         (ChromiumWinTest.RegisterCygwinOption.__init__):
1342         (ChromiumWinTest.test_setup_environ_for_server_register_cygwin):
1343         * Scripts/webkitpy/style/checkers/test_expectations.py:
1344         (TestExpectationsChecker._determine_port_from_expectations_path):
1345         * Scripts/webkitpy/tool/mocktool.py:
1346         (MockOptions.update):
1347
1348 2012-06-14  Xianzhu Wang  <wangxianzhu@chromium.org>
1349
1350         [Chromium-Android] Initialize font rendering in DumpRenderTree
1351         https://bugs.webkit.org/show_bug.cgi?id=89133
1352
1353         Reviewed by Adam Barth.
1354
1355         * DumpRenderTree/chromium/LayoutTestController.cpp:
1356         (LayoutTestController::reset):
1357         (LayoutTestController::setTextSubpixelPositioning):
1358         * DumpRenderTree/chromium/TestShellAndroid.cpp:
1359         (platformInit):
1360
1361 2012-06-14  Dongwoo Im  <dw.im@samsung.com>
1362
1363         [EFL] [DRT] Reset the WebAudio setting on DumpRenderTree
1364         https://bugs.webkit.org/show_bug.cgi?id=88622
1365
1366         Reviewed by Philippe Normand.
1367
1368         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp: Reset the setting of the Web Audio feature as default.
1369         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1370
1371 2012-06-14  Xianzhu Wang  <wangxianzhu@chromium.org>
1372
1373         [Chromium-Android] Should retry a few times when failed to start DumpRenderTree
1374         https://bugs.webkit.org/show_bug.cgi?id=89124
1375
1376         Reviewed by Dirk Pranke.
1377
1378         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1379         (ChromiumAndroidDriver._start):
1380         (ChromiumAndroidDriver):
1381         (ChromiumAndroidDriver._start_once):
1382
1383 2012-06-14  Tony Gentilcore  <tonyg@chromium.org>
1384
1385         Update webpagereplay to 1.1.2
1386         https://bugs.webkit.org/show_bug.cgi?id=89118
1387
1388         This includes the following patch which avoids pkg_resources import errors:
1389         http://code.google.com/p/web-page-replay/source/detail?r=476
1390
1391         Reviewed by Dirk Pranke.
1392
1393         * Scripts/webkitpy/thirdparty/__init__.py:
1394         (AutoinstallImportHook._install_webpagereplay):
1395
1396 2012-06-14  Ryosuke Niwa  <rniwa@webkit.org>
1397
1398         Get rid of FAIL test expectation
1399         https://bugs.webkit.org/show_bug.cgi?id=89137
1400
1401         Reviewed by Dirk Pranke.
1402
1403         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1404         (ResultSummaryTest.test_summarized_results_wontfix):
1405         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
1406         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1407         (JSONLayoutResultsGenerator):
1408         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1409         (result_was_expected):
1410         (suffixes_for_expectations):
1411         (TestExpectationsModel._add_test):
1412         (TestExpectations):
1413         (TestExpectations.get_rebaselining_failures):
1414         (TestExpectations.remove_configuration_from_test):
1415         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1416         (FunctionsTest.test_result_was_expected):
1417         (FunctionsTest.test_suffixes_for_expectations):
1418         (TestExpectationSerializerTests.test_parsed_expectations_string):
1419         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1420         (test_test_expectations):
1421         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1422         (TestExpectationsTestCase.test_valid_expectations):
1423
1424 2012-06-14  Dirk Pranke  <dpranke@chromium.org>
1425
1426         webkitpy: remove DummyOptions and clean up the code in Port.get_option() and Port.set_option_default()
1427         https://bugs.webkit.org/show_bug.cgi?id=89135
1428
1429         Reviewed by Ryosuke Niwa.
1430
1431         This patch is just some minor cleanup and simplification. There
1432         should be no functional changes here.
1433
1434         * Scripts/webkitpy/layout_tests/port/base.py:
1435         (Port.__init__):
1436         (Port.get_option):
1437         (Port.set_option_default):
1438         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1439         (ChromiumWinTest.test_setup_environ_for_server_register_cygwin):
1440         * Scripts/webkitpy/style/checkers/test_expectations.py:
1441         (TestExpectationsChecker._determine_port_from_expectations_path):
1442         * Scripts/webkitpy/tool/mocktool.py:
1443         (MockOptions.ensure_value):
1444
1445 2012-06-14  Ian Vollick  <vollick@chromium.org>
1446
1447         [chromium] Certain settings in CCSettings could be global
1448         https://bugs.webkit.org/show_bug.cgi?id=88384
1449
1450         Reviewed by James Robinson.
1451
1452         * DumpRenderTree/chromium/TestShell.cpp:
1453         (TestShell::TestShell):
1454         (TestShell::resetWebSettings):
1455         (TestShell::setPerTilePaintingEnabled):
1456         * DumpRenderTree/chromium/TestShell.h:
1457         (TestShell):
1458         * DumpRenderTree/chromium/WebPreferences.cpp:
1459         (WebPreferences::reset):
1460         (WebPreferences::applyTo):
1461         * DumpRenderTree/chromium/WebPreferences.h:
1462         (WebPreferences):
1463
1464 2012-06-14  Sheriff Bot  <webkit.review.bot@gmail.com>
1465
1466         Unreviewed, rolling out r120352.
1467         http://trac.webkit.org/changeset/120352
1468         https://bugs.webkit.org/show_bug.cgi?id=89120
1469
1470         It seems something is still wrong with it :/ (Requested by
1471         Ossy on #webkit).
1472
1473         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1474         (Factory.__init__):
1475         (BuildFactory.__init__):
1476         (TestFactory.__init__):
1477         (BuildAndTestFactory.__init__):
1478         (BuildAndPerfTestFactory.__init__):
1479         (BuildAndPerfTestWebKit2Factory.__init__):
1480         (DownloadAndPerfTestFactory.__init__):
1481         (DownloadAndPerfTestWebKit2Factory.__init__):
1482
1483 2012-06-14  Jia Pu  <jpu@apple.com>
1484
1485         Mark text with text alternative with blue underline.
1486         https://bugs.webkit.org/show_bug.cgi?id=83047
1487
1488         Reviewed by NOBODY Enrica Casucci.
1489
1490         * DumpRenderTree/mac/TextInputController.m:
1491         (+[TextInputController isSelectorExcludedFromWebScript:]):
1492         (+[TextInputController webScriptNameForSelector:]):
1493         (-[TextInputController dictatedStringWithPrimaryString:alternative:alternativeOffset:alternativeLength:]):
1494
1495 2012-06-14  Sheriff Bot  <webkit.review.bot@gmail.com>
1496
1497         Unreviewed, rolling out r120353.
1498         http://trac.webkit.org/changeset/120353
1499         https://bugs.webkit.org/show_bug.cgi?id=89119
1500
1501         It seems we still need this workaround (Requested by Ossy on
1502         #webkit).
1503
1504         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1505         (loadBuilderConfig):
1506
1507 2012-06-14  Csaba Osztrogonác  <ossy@webkit.org>
1508
1509         master.cfg cleanup, remove unnecessary workaround
1510         https://bugs.webkit.org/show_bug.cgi?id=88994
1511
1512         Reviewed by Lucas Forschler.
1513
1514         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1515         (loadBuilderConfig):
1516
1517 2012-06-14  Csaba Osztrogonác  <ossy@webkit.org>
1518
1519         master.cfg cleanup, pass BuildStep instances instead of BuildStep subclasses
1520         https://bugs.webkit.org/show_bug.cgi?id=89001
1521
1522         Reviewed by Lucas Forschler.
1523
1524         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1525         (Factory.__init__):
1526         (BuildFactory.__init__):
1527         (TestFactory.__init__):
1528         (BuildAndTestFactory.__init__):
1529         (BuildAndPerfTestFactory.__init__):
1530         (BuildAndPerfTestWebKit2Factory.__init__):
1531         (DownloadAndPerfTestFactory.__init__):
1532         (DownloadAndPerfTestWebKit2Factory.__init__):
1533
1534 2012-06-14  Csaba Osztrogonác  <ossy@webkit.org>
1535
1536         Unhide login form on the build.webkit.org
1537         https://bugs.webkit.org/show_bug.cgi?id=88981
1538
1539         Reviewed by Lucas Forschler.
1540
1541         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
1542
1543 2012-06-14  Zan Dobersek  <zandobersek@gmail.com>
1544
1545         [Gtk] Add support in DumpRenderTree for tracking repaints
1546         https://bugs.webkit.org/show_bug.cgi?id=87658
1547
1548         Reviewed by Martin Robinson.
1549
1550         Reimplement the displayWebView method in DumpRenderTree - force a
1551         repaint before starting tracking repaints and resetting them.
1552
1553         When gathering pixel output from a web view, if tracking repaints,
1554         paint an overlay over the output with the overlay being clear in the
1555         areas where the repaints occurred.
1556
1557         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1558         (displayWebView):
1559         (resetDefaultsToConsistentValues):
1560         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
1561         (paintOverlay):
1562         (fillRepaintOverlayIntoContext):
1563         (createBitmapContextFromWebView):
1564
1565 2012-06-14  Dirk Pranke  <dpranke@chromium.org>
1566
1567         new-run-webkit-tests doesn't find similar platform tests for a keyword
1568         https://bugs.webkit.org/show_bug.cgi?id=37956
1569
1570         Reviewed by Ryosuke Niwa.
1571
1572         This patches adds support for NRWT so that if you type
1573         "new-run-webkit-tests foo" it will run all the tests in foo as
1574         well as platform/foo for all of the platforms that are normally
1575         searched (this only applies to directories, not to individual tests).
1576
1577         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1578         (Manager.collect_tests):
1579         * Scripts/webkitpy/layout_tests/port/base.py:
1580         (Port.tests):
1581         (Port):
1582         (Port._expanded_paths):
1583         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1584         (MainTest.test_no_http_tests):
1585         (MainTest):
1586         (MainTest.test_platform_tests_are_found):
1587
1588 2012-06-14  Dirk Pranke  <dpranke@chromium.org>
1589
1590         NRWT should honor --skipped=[default|ignore|only], like ORWT does
1591         https://bugs.webkit.org/show_bug.cgi?id=66308
1592
1593         Reviewed by Ryosuke Niwa.
1594
1595         This patch adds support for ORWT's --skipped=(default|ignore|only)
1596         flag and cleans up the interaction between that and --ignore.
1597
1598         Individual tests (but not directories) explicitly listed on the
1599         command line will always be run regardless of what is passed
1600         for --skipped and --ignore.
1601
1602         This patch also changes the "found" and "running" log messages
1603         since it wasn't clear how the skipped tests were included in those numbers.
1604
1605         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1606         (Manager.__init__):
1607         (Manager.collect_tests):
1608         (Manager.prepare_lists_and_print_output):
1609         * Scripts/webkitpy/layout_tests/port/test.py:
1610         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1611         (_set_up_derived_options):
1612         (parse_args):
1613         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1614         (MainTest.test_ignore_flag):
1615         (MainTest):
1616         (MainTest.test_skipped_flag):
1617
1618 2012-06-14  Takashi Toyoshima  <toyoshim@chromium.org>
1619
1620         new-run-webkit-websocketserver must handle TLS related arguments
1621         https://bugs.webkit.org/show_bug.cgi?id=89079
1622
1623         Reviewed by Dirk Pranke.
1624
1625         PyWebSocket class must accept private_key, certificate, and
1626         ca_certificate arguments and pass them to launching pywebsocket.
1627         Also add ca_certificate handling to new-run-webkit-websocketserver.
1628
1629         * Scripts/new-run-webkit-websocketserver:
1630         (main):
1631         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
1632         (PyWebSocket.__init__):
1633         (PyWebSocket._prepare_config):
1634
1635 2012-06-14  Qi Zhang  <qi.2.zhang@nokia.com>
1636
1637         Unreviewed. Update my email.
1638
1639         * Scripts/webkitpy/common/config/committers.py:
1640
1641 2012-06-14  Takashi Toyoshima  <toyoshim@chromium.org>
1642
1643         Update pywebsocket to 0.7.6 from 0.7.4
1644         https://bugs.webkit.org/show_bug.cgi?id=88975
1645
1646         Reviewed by Kent Tamura.
1647
1648         This new version of pywebsocket introduce following features.
1649          - Allow handlers to send a close frame with empty body in response of
1650              a client initiated closing handshake
1651          - Implement perframe compression extension
1652          - Support client certificate authentication
1653
1654         * Scripts/webkitpy/thirdparty/mod_pywebsocket/COPYING:
1655         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hybi.py:
1656         (_create_control_frame):
1657         (Stream._receive_frame):
1658         (Stream.send_message):
1659         (Stream.receive_message):
1660         (Stream._send_closing_handshake):
1661         (Stream.close_connection):
1662         * Scripts/webkitpy/thirdparty/mod_pywebsocket/common.py:
1663         (ExtensionParsingException):
1664         (ExtensionParsingException.__init__):
1665         (_parse_extension_param):
1666         (_parse_extension):
1667         (parse_extensions):
1668         (format_extension):
1669         (format_extensions):
1670         * Scripts/webkitpy/thirdparty/mod_pywebsocket/extensions.py:
1671         (_parse_compression_method):
1672         (_create_accepted_method_desc):
1673         (PerFrameCompressionExtensionProcessor):
1674         (PerFrameCompressionExtensionProcessor.__init__):
1675         (PerFrameCompressionExtensionProcessor._lookup_compression_processor):
1676         (PerFrameCompressionExtensionProcessor._get_compression_processor_response):
1677         (PerFrameCompressionExtensionProcessor.get_extension_response):
1678         (PerFrameCompressionExtensionProcessor.setup_stream_options):
1679         (PerFrameCompressionExtensionProcessor.get_compression_processor):
1680         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/_base.py:
1681         (parse_token_list):
1682         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi.py:
1683         (Handshaker._parse_extensions):
1684         (Handshaker._send_handshake):
1685         * Scripts/webkitpy/thirdparty/mod_pywebsocket/standalone.py:
1686         (WebSocketServer._create_sockets):
1687         (_get_logger_from_class):
1688         (_configure_logging):
1689         (_build_option_parser):
1690         (_main.if):
1691         * Scripts/webkitpy/thirdparty/mod_pywebsocket/util.py:
1692         (RepeatedXorMasker.mask):
1693
1694 2012-06-14  Zoltan Horvath  <zoltan@webkit.org>
1695
1696         [Qt] Remove USE(QT_IMAGE_DECODER) macro, since we don't use it anymore
1697
1698         Reviewed by Noam Rosenthal.
1699
1700         * qmake/mkspecs/features/features.prf:
1701
1702 2012-06-14  Christophe Dumez  <christophe.dumez@intel.com>
1703
1704         [WK2] Add implementation for registerIntentService in WebFrameLoaderClient
1705         https://bugs.webkit.org/show_bug.cgi?id=88399
1706
1707         Reviewed by Kenneth Rohde Christiansen.
1708
1709         Update initialization of WKPageLoaderClient.
1710
1711         * MiniBrowser/mac/BrowserWindowController.m:
1712         (-[BrowserWindowController awakeFromNib]):
1713         * WebKitTestRunner/TestController.cpp:
1714         (WTR::TestController::initialize):
1715
1716 2012-06-14  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1717
1718         [EFL] [DRT] Implement setDomainRelaxationForbiddenForURLScheme in EFL DRT
1719         https://bugs.webkit.org/show_bug.cgi?id=84577
1720
1721         Reviewed by Ryosuke Niwa.
1722
1723         Add missing implementation setDomainRelaxationForbiddenForURLScheme to EFL's
1724         LayoutTestController.
1725
1726         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1727         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
1728
1729 2012-06-13  Christophe Dumez  <christophe.dumez@intel.com>
1730
1731         [WK2] Add implementation for dispatchIntent in WebFrameLoaderClient
1732         https://bugs.webkit.org/show_bug.cgi?id=88340
1733
1734         Reviewed by Kenneth Rohde Christiansen.
1735
1736         Update initialization of WKPageLoaderClient.
1737
1738         * MiniBrowser/mac/BrowserWindowController.m:
1739         (-[BrowserWindowController awakeFromNib]):
1740         * WebKitTestRunner/TestController.cpp:
1741         (WTR::TestController::initialize):
1742
1743 2012-06-13  Sheriff Bot  <webkit.review.bot@gmail.com>
1744
1745         Unreviewed, rolling out r120268.
1746         http://trac.webkit.org/changeset/120268
1747         https://bugs.webkit.org/show_bug.cgi?id=89060
1748
1749         WebCompositor::setPerTilePaintingEnabled hits an assertion in
1750         DEBUG (Requested by dominicc|work on #webkit).
1751
1752         * DumpRenderTree/chromium/WebPreferences.cpp:
1753         (WebPreferences::applyTo):
1754
1755 2012-06-13  Tim Horton  <timothy_horton@apple.com>
1756
1757         REGRESSION (r120252): run-webkit-tests on Mac fails
1758         https://bugs.webkit.org/show_bug.cgi?id=89057
1759
1760         Reviewed by Dan Bernstein.
1761
1762         get_option will happily return None (the default only kicks in if
1763         the option is actually *not set*). We should instead check get_option's
1764         return value and default to "x86_64" architecture ourselves.
1765
1766         * Scripts/webkitpy/layout_tests/port/mac.py:
1767         (MacPort.__init__):
1768
1769 2012-06-13  Ian Vollick  <vollick@chromium.org>
1770
1771         [chromium] Certain settings in CCSettings could be global
1772         https://bugs.webkit.org/show_bug.cgi?id=88384
1773
1774         Reviewed by James Robinson.
1775
1776         * DumpRenderTree/chromium/WebPreferences.cpp:
1777         (WebPreferences::applyTo):
1778
1779 2012-06-13  Dirk Pranke  <dpranke@chromium.org>
1780
1781         new-run-webkit-tests does not support --32-bit like ORWT did
1782         https://bugs.webkit.org/show_bug.cgi?id=71634
1783
1784         Reviewed by Ojan Vafai.
1785
1786         This patch adds support for 32-bit apple mac builds, adding the
1787         --32-bit flag for compatibility with ORWT and fixing the port
1788         architecture() definition to actually return the correct values.
1789
1790         * Scripts/webkitpy/layout_tests/port/apple.py:
1791         (ApplePort._generate_all_test_configurations):
1792         * Scripts/webkitpy/layout_tests/port/factory.py:
1793         (port_options):
1794         * Scripts/webkitpy/layout_tests/port/mac.py:
1795         (MacPort):
1796         (MacPort.__init__):
1797         (MacPort._build_driver_flags):
1798         (MacPort.setup_environ_for_server):
1799         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1800         (test_sample_process_throws_exception):
1801         (test_32bit):
1802         (test_32bit.run_script):
1803         (test_64bit):
1804         (test_64bit.run_script):
1805         * Scripts/webkitpy/layout_tests/port/webkit.py:
1806         (WebKitPort._build_driver):
1807         (WebKitPort._build_driver_flags):
1808         * Scripts/webkitpy/layout_tests/port/win.py:
1809         (WinPort):
1810
1811 2012-06-13  Ryosuke Niwa  <rniwa@webkit.org>
1812
1813         Remove webkitpy code to support legacy test_expectations.txt files
1814         https://bugs.webkit.org/show_bug.cgi?id=89038
1815
1816         Reviewed by Dirk Pranke.
1817
1818         * Scripts/webkitpy/layout_tests/port/base.py:
1819         (Port.path_to_test_expectations_file):
1820         (Port.expectations_dict):
1821         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1822         (PortTest.test_uses_test_expectations_file):
1823         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1824         (WebKitPortTest.test_path_to_test_expectations_file):
1825         (test_test_expectations):
1826         * Scripts/webkitpy/style/checker.py:
1827         (CheckerDispatcher.should_skip_without_warning):
1828         (CheckerDispatcher._create_checker):
1829         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1830         (TestExpectationsTestCase._expect_port_for_expectations_path):
1831         * Scripts/webkitpy/tool/steps/commit.py:
1832         (Commit._check_test_expectations):
1833         * Scripts/webkitpy/tool/steps/commit_unittest.py:
1834         (CommitTest.test_check_test_expectations):
1835
1836 2012-06-13  Dirk Pranke  <dpranke@chromium.org>
1837
1838         nrwt: remove port.test_expectations() and port.test_expectations_overrides()
1839         https://bugs.webkit.org/show_bug.cgi?id=88948
1840
1841         Reviewed by Ojan Vafai.
1842
1843         In the final patch of this run, we remove the
1844         test_expectations() and test_expectation_overrides() methods
1845         from the Port class - callers must now use just
1846         expectations_dict().
1847
1848         Note that support for the cascade in new-run-webkit-tests is
1849         complete but only Chromium uses it; webkit-patch
1850         rebaseline-expectations still does not support updating entries
1851         in any file other than the first expectations file, however.
1852
1853         * Scripts/webkitpy/layout_tests/port/base.py:
1854         (Port.path_to_test_expectations_file):
1855         (Port.uses_test_expectations_file):
1856         (Port.expectations_files):
1857         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1858         (PortTest.test_additional_expectations):
1859         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1860         (ChromiumPortTest.test_expectations_files):
1861         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1862         (TestGoogleChromePort.test_get_google_chrome_port):
1863         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1864         (test_test_expectations):
1865         (test_legacy_test_expectations):
1866
1867 2012-06-13  Dirk Pranke  <dpranke@chromium.org>
1868
1869         nrwt: implement the actual cascade of TestExpectations
1870         https://bugs.webkit.org/show_bug.cgi?id=88947
1871
1872         Reviewed by Ojan Vafai.
1873
1874         This change implements the actual cascade by removing the
1875         concept of 'overrides' from the TestExpectations object and
1876         parsing each file separately.
1877
1878         There is an actual semantic change in this patch, in that
1879         setting an expectation on a directory in one file will override
1880         the expectations on any individual tests set in prior files. The
1881         test_overrides__directory() unit test verifies this.
1882
1883         Otherwise, this patch mostly consists of deleting code :).
1884
1885         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1886         (TestExpectationsModel.__init__):
1887         (TestExpectationsModel.add_expectation_line):
1888         (TestExpectationsModel._add_test):
1889         (TestExpectationsModel._already_seen_better_match):
1890         (TestExpectations.__init__):
1891         (TestExpectations._add_expectations):
1892         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1893         (test_overrides__directory):
1894
1895 2012-06-13  Dirk Pranke  <dpranke@chromium.org>
1896
1897         webkitpy: update callers to use port.expectation_dict() instead of test_expectations() and test_expectations_overrides()
1898         https://bugs.webkit.org/show_bug.cgi?id=88946
1899
1900         Reviewed by Ojan Vafai.
1901
1902         In preparation for fully supporting cascading expectations files
1903         and removing the 'overrides' concept.
1904
1905         There should be no functional changes in this patch.
1906
1907         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1908         (ManagerTest.test_update_summary_with_result):
1909         (ResultSummaryTest.get_result_summary):
1910         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1911         (TestExpectations.__init__):
1912         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1913         (parse_exp):
1914         (SkippedTests.check):
1915         (RemoveConfigurationsTest.test_remove):
1916         (test_remove_line):
1917         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1918         (LintTest.test_all_configurations.FakePort.__init__):
1919         (LintTest.test_all_configurations.FakePort.expectations_dict):
1920         (LintTest.test_lint_test_files__errors):
1921         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1922         (test_overrides_are_included_correctly):
1923
1924 2012-06-13  Dirk Pranke  <dpranke@chromium.org>
1925
1926         webkitpy: rework the TestExpectations style checker in preparation for the cascade
1927         https://bugs.webkit.org/show_bug.cgi?id=88945
1928
1929         Reviewed by Ojan Vafai.
1930
1931         This patch changes the style checker to call the
1932         TestExpectations parser directly and be oblivious as to what the
1933         port's actual expectations are.
1934
1935         * Scripts/webkitpy/style/checkers/test_expectations.py:
1936         (TestExpectationsChecker.__init__):
1937         (TestExpectationsChecker.check_test_expectations):
1938
1939 2012-06-13  Dirk Pranke  <dpranke@chromium.org>
1940
1941         nrwt: restructure the port classes to handle multiple expectations files
1942         https://bugs.webkit.org/show_bug.cgi?id=88944
1943
1944         Reviewed by Ojan Vafai.
1945
1946         This patch restructures the Port classes so that each port
1947         returns a list of TestExpectations files to be used (in a new, public,
1948         expectations_files() method), and the base implementation rolls them
1949         up into the ordered expectations_dict(), which becomes a public
1950         method.
1951
1952         port.path_to_test_expectations_file(), port.test_expectations(),
1953         and port.test_expectations_overrides() are then reimplemented as
1954         wrappers around port.expectations_dict().
1955         port.test_expectations() and port.test_expectations_overrides()
1956         will eventually be removed when the cascade is fully completed,
1957         and port.path_to_test_expectations_file() will be removed when
1958         the rebaselining tool supports the cascade
1959         (expectations_files() may also become private at that point).
1960
1961         There should be no functional changes in this patch, but a bunch
1962         of custom logic gets deleted!
1963
1964         * Scripts/webkitpy/layout_tests/port/base.py:
1965         (Port.expectations_dict):
1966         (Port):
1967         (Port.expectations_files):
1968         (Port.test_expectations):
1969         (Port.test_expectations_overrides):
1970         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1971         (PortTest.test_additional_expectations):
1972         (PortTest.test_uses_test_expectations_file):
1973         * Scripts/webkitpy/layout_tests/port/chromium.py:
1974         (ChromiumPort.all_baseline_variants):
1975         (ChromiumPort.expectations_files):
1976         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1977         (ChromiumPortTest.test_overrides_and_builder_names):
1978         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
1979         (_expectations_files):
1980         (GoogleChromeLinux32Port.expectations_files):
1981         (GoogleChromeLinux64Port.expectations_files):
1982         (GoogleChromeMacPort.expectations_files):
1983         (GoogleChromeWinPort.expectations_files):
1984         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1985         (TestGoogleChromePort._verify_expectations_overrides):
1986         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1987         (PortTestCase.test_expectations_ordering):
1988         * Scripts/webkitpy/layout_tests/port/webkit.py:
1989         (WebKitPort._skipped_file_search_paths):
1990         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1991         (TestRebaseline.test_rebaseline_updates_expectations_file_noop):
1992         (test_rebaseline_updates_expectations_file):
1993         (test_rebaseline_does_not_include_overrides):
1994         (test_rebaseline_expectations):
1995         (test_overrides_are_included_correctly):
1996
1997 2012-06-13  Brent Fulgham  <bfulgham@webkit.org>
1998
1999         [WinCairo] Update URL of WinCairoRequirements.zip download.
2000         https://bugs.webkit.org/show_bug.cgi?id=89009
2001
2002         Reviewed by Martin Robinson.
2003
2004         * Tools/Scripts/update-webkit-dependency: Put fallback code
2005         to download a "last update" time from servers that don't properly
2006         report Last-Modified in their HTTP header.
2007         * Tools/Scripts/update-webkit-wincairo-libs: Change download link
2008         for the WinCairo build requirements bundle.
2009
2010 2012-06-13  Dirk Pranke  <dpranke@chromium.org>
2011
2012         nrwt: preliminary cleanup before supporting cascading expectations files
2013         https://bugs.webkit.org/show_bug.cgi?id=88942
2014
2015         Reviewed by Ojan Vafai.
2016
2017         This change just prepares the TestExpectations parser to get filenames
2018         along with the expectations, and improves the warning messages so that
2019         they contain the filenames along with the line numbers.
2020
2021         There should be no functional changes in this patch.
2022
2023         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
2024         (TestExpectationEditorTests.make_parsed_expectation_lines):
2025         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2026         (TestExpectationParser.parse):
2027         (TestExpectationParser.expectation_for_skipped_test):
2028         (TestExpectationParser._tokenize):
2029         (TestExpectationParser._tokenize_list):
2030         (TestExpectationLine):
2031         (TestExpectationsModel.__init__):
2032         (TestExpectationsModel._already_seen_better_match):
2033         (TestExpectations.__init__):
2034         (TestExpectations._shorten_filename):
2035         (TestExpectations._report_warnings):
2036         (TestExpectations._add_skipped_tests):
2037         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2038         (TestExpectationParserTests._tokenize):
2039         (TestExpectationParserTests.test_tokenize_blank):
2040         (TestExpectationParserTests.test_tokenize_missing_colon):
2041         (TestExpectationParserTests.test_tokenize_extra_colon):
2042         (TestExpectationParserTests.test_tokenize_empty_comment):
2043         (TestExpectationParserTests.test_tokenize_comment):
2044         (TestExpectationParserTests.test_tokenize_missing_equal):
2045         (TestExpectationParserTests.test_tokenize_extra_equal):
2046         (TestExpectationParserTests.test_tokenize_valid):
2047         (TestExpectationParserTests.test_tokenize_valid_with_comment):
2048         (TestExpectationParserTests.test_tokenize_valid_with_multiple_modifiers):
2049         (TestExpectationParserTests.test_parse_empty_string):
2050         (TestExpectationSerializerTests._tokenize):
2051         (TestExpectationSerializerTests.assert_round_trip):
2052         (TestExpectationSerializerTests.assert_list_round_trip):
2053         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2054         (GardeningExpectationsUpdater.update_expectations):
2055
2056 2012-06-13  Zan Dobersek  <zandobersek@gmail.com>
2057
2058         [Gtk] Enable link prefetch support in the developer builds
2059         https://bugs.webkit.org/show_bug.cgi?id=89011
2060
2061         Reviewed by Martin Robinson.
2062
2063         Enable the link prefetch support for Gtk by default in developer
2064         builds.
2065
2066         * Scripts/webkitperl/FeatureList.pm:
2067
2068 2012-06-13  Csaba Osztrogonác  <ossy@webkit.org>
2069
2070         Update buildbot master in autoinstaller to match build.webkit.org
2071         https://bugs.webkit.org/show_bug.cgi?id=88992
2072
2073         Reviewed by Adam Barth.
2074
2075         * Scripts/webkitpy/thirdparty/__init__.py:
2076         (AutoinstallImportHook._install_buildbot):
2077
2078 2012-06-13  Sheriff Bot  <webkit.review.bot@gmail.com>
2079
2080         Unreviewed, rolling out r120209.
2081         http://trac.webkit.org/changeset/120209
2082         https://bugs.webkit.org/show_bug.cgi?id=89007
2083
2084         Broke the WebKit2 mac build. (Requested by andersca on
2085         #webkit).
2086
2087         * MiniBrowser/mac/BrowserWindowController.m:
2088         (-[BrowserWindowController awakeFromNib]):
2089         * WebKitTestRunner/TestController.cpp:
2090         (WTR::TestController::initialize):
2091
2092 2012-06-13  Zoltan Horvath  <zoltan@webkit.org>
2093
2094         check-webkit-style needs to respect Qt API coding style
2095         https://bugs.webkit.org/show_bug.cgi?id=88995
2096
2097         Reviewed by Csaba Osztrogonác.
2098
2099         Add -whitespace/declaration exception to Qt API files.
2100
2101         * Scripts/webkitpy/style/checker.py:
2102
2103 2012-06-13  Christophe Dumez  <christophe.dumez@intel.com>
2104
2105         [WK2] Add implementation for dispatchIntent in WebFrameLoaderClient
2106         https://bugs.webkit.org/show_bug.cgi?id=88340
2107
2108         Reviewed by Kenneth Rohde Christiansen.
2109
2110         Update initialization of WKPageLoaderClient.
2111
2112         * MiniBrowser/mac/BrowserWindowController.m:
2113         (-[BrowserWindowController awakeFromNib]):
2114         * WebKitTestRunner/TestController.cpp:
2115         (WTR::TestController::initialize):
2116
2117 2012-06-13  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
2118
2119         [Qt] Handle multiple held buttons in touch mocking.
2120         https://bugs.webkit.org/show_bug.cgi?id=88865
2121
2122         Reviewed by Kenneth Rohde Christiansen.
2123
2124         Add handling for multiple held mouse-buttons in the appropiate places.
2125         To do this last-pos and start-pos are now also read from the last recorded
2126         touch-point instead from object-global variables.
2127
2128         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2129         (MiniBrowserApplication::notify):
2130         (MiniBrowserApplication::updateTouchPoint):
2131         * MiniBrowser/qt/MiniBrowserApplication.h:
2132         (MiniBrowserApplication):
2133
2134 2012-06-13  Simon Hausmann  <simon.hausmann@nokia.com>
2135
2136         [Qt] Make it possible to disable -Werror in production builds
2137
2138         Reviewed by Tor Arne Vestbø.
2139
2140         Don't do -Werror if build-webkit is called with --qmakearg=CONFIG+=production_build,
2141         something qt5.git's qtwebkit.pri will soon do.
2142
2143         * qmake/mkspecs/features/unix/default_post.prf:
2144
2145 2012-06-13  Dominik Röttsches  <dominik.rottsches@intel.com>
2146
2147         [EFL] Store and compare md5sum of jhbuild files to trigger cleaning Dependencies
2148         https://bugs.webkit.org/show_bug.cgi?id=85790
2149
2150         Reviewed by Gustavo Noronha Silva.
2151
2152         Add md5 checks for jhbuild configuration for EFL, reusing the gtk jhbuild related
2153         code in webkitdirs.pm.
2154
2155         * Scripts/webkitdirs.pm:
2156         (jhbuildConfigurationChanged):
2157         (saveJhbuildMd5):
2158         (cleanJhbuild):
2159         (buildAutotoolsProject):
2160         (generateBuildSystemFromCMakeProject):
2161
2162 2012-06-13  Qi Zhang  <qi.2.zhang@nokia.com>
2163
2164         [Qt] Add configure test for zlib and set WTF_USE_ZLIB if found
2165         https://bugs.webkit.org/show_bug.cgi?id=88763
2166
2167         Add configure test for zlib and set WTF_USE_ZLIB if found to enable websocket
2168         extension.
2169
2170         Reviewed by Simon Hausmann.
2171
2172         * qmake/config.tests/libzlib: Added.
2173         * qmake/config.tests/libzlib/libzlib.cpp: Added.
2174         (main):
2175         * qmake/config.tests/libzlib/libzlib.pro: Added.
2176         * qmake/mkspecs/features/features.prf:
2177         * qmake/sync.profile:
2178
2179 2012-06-13  Robin Cao  <robin.cao@torchmobile.com.cn>
2180
2181         [BlackBerry] Enable MEDIA_STREAM by default
2182         https://bugs.webkit.org/show_bug.cgi?id=88849
2183
2184         Reviewed by Antonio Gomes.
2185
2186         * Scripts/webkitperl/FeatureList.pm:
2187
2188 2012-06-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2189
2190         Prevent stderr output from messing up detection of build path
2191
2192         https://bugs.webkit.org/show_bug.cgi?id=88075
2193
2194         Warnings such as 'perl: warning: Setting locale failed' will otherwise
2195         end up as the build path when calling out to webkit-build-directory.
2196
2197         Reviewed by Ojan Vafai.
2198
2199         * Scripts/webkitpy/layout_tests/port/config.py:
2200         (Config.build_directory):
2201
2202 2012-06-13  Ryosuke Niwa  <rniwa@webkit.org>
2203
2204         Update the builder name for Apple Lion builders.
2205
2206         * Scripts/webkitpy/layout_tests/port/builders.py:
2207
2208 2012-06-13  Joel Dillon  <joel.dillon@codethink.co.uk>
2209
2210         [Qt][Win]QtTestBrowser somehow picks up DumpRenderTree's main.cpp, causing a failure to link
2211         https://bugs.webkit.org/show_bug.cgi?id=88874
2212
2213         Reviewed by Simon Hausmann.
2214
2215         Rename main.cpp in QtTestBrowser because on Windows
2216         it conflicts with main.cpp from DumpRenderTree.
2217
2218         * QtTestBrowser/QtTestBrowser.pro:
2219         * QtTestBrowser/qttestbrowser.cpp: Renamed from Tools/QtTestBrowser/main.cpp.
2220         (launcherMain):
2221         (LauncherApplication):
2222         (LauncherApplication::urls):
2223         (LauncherApplication::isRobotized):
2224         (LauncherApplication::robotTimeout):
2225         (LauncherApplication::robotExtraTime):
2226         (LauncherApplication::applyDefaultSettings):
2227         (LauncherApplication::LauncherApplication):
2228         (requiresGraphicsView):
2229         (LauncherApplication::handleUserOptions):
2230         (main):
2231
2232 2012-06-12  Lucas Forschler  <lforschler@apple.com>
2233
2234         Wrap bot types inside ().
2235         https://bugs.webkit.org/show_bug.cgi?id=88893
2236         
2237         Reviewed by Stephanie Lewis.
2238
2239         * BuildSlaveSupport/build.webkit.org-config/config.json:
2240
2241 2012-06-12  Christophe Dumez  <christophe.dumez@intel.com>
2242
2243         [soup] Prevent setting or editing httpOnly cookies from JavaScript
2244         https://bugs.webkit.org/show_bug.cgi?id=88760
2245
2246         Reviewed by Gustavo Noronha Silva.
2247
2248         Update libsoup to v2.39.2, glib to v2.33.2 and glib-networking
2249         to v2.33.2 for both GTK and EFL ports.
2250
2251         * efl/jhbuild.modules:
2252         * gtk/jhbuild.modules:
2253
2254 2012-06-12  Christophe Dumez  <christophe.dumez@intel.com>
2255
2256         [EFL] Enable SHADOW_DOM flag
2257         https://bugs.webkit.org/show_bug.cgi?id=87732
2258
2259         Reviewed by Kentaro Hara.
2260
2261         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2262         (DumpRenderTreeChrome::resetDefaultsToConsistentValues): Enable
2263         SHADOW_DOM by default in DRT.
2264         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
2265         (onFocusCanCycle): Enable focus cycling in EFL DRT to behave like
2266         Chromium and Mac ports.
2267         (drtViewAdd):
2268         * Scripts/webkitperl/FeatureList.pm: Enable SHADOW_DOM flag by default
2269         at compile time for EFL port.
2270
2271 2012-06-12  Ashod Nakashian  <ashodnakashian@yahoo.com>
2272
2273         WinLauncher should show loading errors
2274         https://bugs.webkit.org/show_bug.cgi?id=80760
2275
2276         Reviewed by Brent Fulgham.
2277
2278         * WinLauncher/WinLauncher.cpp: Added load-fail handler to show messagebox with error.
2279         (WinLauncherWebHost::didFailProvisionalLoadWithError):
2280         * WinLauncher/WinLauncher.h:
2281         (WinLauncherWebHost::didFailProvisionalLoadWithError):
2282         (WinLauncherWebHost):
2283
2284 2012-06-12  Ryuan Choi  <ryuan.choi@samsung.com>
2285
2286         [EFL][WK2] Add MiniBrowserEfl.
2287         https://bugs.webkit.org/show_bug.cgi?id=61850
2288
2289         Reviewed by Chang Shu.
2290
2291         Implement MiniBrowser for EFL.
2292
2293         * CMakeLists.txt:
2294         * MiniBrowser/efl/CMakeLists.txt: Added.
2295         * MiniBrowser/efl/main.c: Added.
2296         (_MiniBrowser):
2297         (main_signal_exit):
2298         (on_ecore_evas_resize):
2299         (browserCreate):
2300         (main):
2301
2302 2012-06-12  Helder Correia  <helder.correia@nokia.com>
2303
2304         Unreviewed. Update my email address in committers.py.
2305
2306         * Scripts/webkitpy/common/config/committers.py:
2307
2308 2012-06-12  Dominik Röttsches  <dominik.rottsches@intel.com>
2309
2310         [EFL] Resolve CMake warnings on overlapping search paths for EFL jhbuild-enabled build
2311         https://bugs.webkit.org/show_bug.cgi?id=84707
2312
2313         Fixing CMAKE prefix path for 64bit systems to avoid CMAKE warnings on those.
2314         use_lib64 variable is preconfigured to True by jhbuild.
2315
2316         Reviewed by Dirk Pranke.
2317
2318         * efl/jhbuildrc:
2319
2320 2012-06-12  Dana Jansens  <danakj@chromium.org>
2321
2322         Add zlieber@chromium.org to contributors list
2323         https://bugs.webkit.org/show_bug.cgi?id=88904
2324
2325         Unreviewed.
2326
2327         * Scripts/webkitpy/common/config/committers.py:
2328
2329 2012-06-12  Lucas Forschler  <lforschler@apple.com>
2330
2331         Rename Apple bots to a standard convention.
2332         https://bugs.webkit.org/show_bug.cgi?id=88893
2333         
2334         Note: This has the side effect of grouping all of the Apple bots together in the waterfall.
2335
2336         Reviewed by Simon Fraser.
2337
2338         * BuildSlaveSupport/build.webkit.org-config/config.json:
2339
2340 2012-06-12  Mike West  <mkwst@chromium.org>
2341
2342         Make document.documentURI readonly from JavaScript
2343         https://bugs.webkit.org/show_bug.cgi?id=65187
2344
2345         Reviewed by Alexey Proskuryakov.
2346
2347         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2348         * TestWebKitAPI/Tests/mac/SetDocumentURI.html: Added.
2349         * TestWebKitAPI/Tests/mac/SetDocumentURI.mm: Added.
2350         (-[SetDocumentURITest webView:didFinishLoadForFrame:]):
2351         (TestWebKitAPI):
2352         (TestWebKitAPI::TEST):
2353
2354 2012-06-12  Christophe Dumez  <christophe.dumez@intel.com>
2355
2356         [EFL] enable LEGACY_WEBKIT_BLOB_BUILDER flag
2357         https://bugs.webkit.org/show_bug.cgi?id=88715
2358
2359         Reviewed by Noam Rosenthal.
2360
2361         Enable LEGACY_WEBKIT_BLOB_BUILDER flag by default on EFL port.
2362
2363         * Scripts/webkitperl/FeatureList.pm:
2364
2365 2012-06-12  Csaba Osztrogonác  <ossy@webkit.org>
2366
2367         [Qt] Fix -Werror for the buildbots
2368         https://bugs.webkit.org/show_bug.cgi?id=88223
2369
2370         Rubber-stamped by Tor Arne Vestbø.
2371
2372         Revert a part of r119269 to enable Werror again for non qt-developer-builds. (for bots for example)
2373
2374         * qmake/mkspecs/features/unix/default_post.prf:
2375
2376 2012-06-12  Balazs Kelemen  <kbalazs@webkit.org>
2377
2378         [REGRESSION][WTR] Build fail with werror after r120054
2379         https://bugs.webkit.org/show_bug.cgi?id=88862
2380
2381         Reviewed by Csaba Osztrogonác.
2382
2383         Some static helpers become unused after counterValueForElementById
2384         has moved to Internals. Let's remove them.
2385
2386         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2387         (WTR):
2388
2389 2012-06-12  Csaba Osztrogonác  <ossy@webkit.org>
2390
2391         [Qt] Slave losts cause build break on bots
2392         https://bugs.webkit.org/show_bug.cgi?id=38980
2393
2394         Minor fix after r59261.
2395
2396         Reviewed by Tor Arne Vestbø.
2397
2398         * Scripts/build-webkit:
2399         (unlinkZeroFiles): Don't remove 0 byte sized directories, because they are always 0 byte sized on Windows.
2400
2401 2012-06-11  Kaustubh Atrawalkar  <kaustubh@motorola.com>
2402
2403         [DRT] LTC:: counterValueForElementById() could be moved to Internals.
2404         https://bugs.webkit.org/show_bug.cgi?id=84406
2405
2406         Reviewed by Hajime Morita.
2407
2408         Move the counterValueForElementById from LayoutTestCotroller to Internals and
2409         remove the old platform specific implementations as it exclusively tests WebCore functionality.
2410
2411         * DumpRenderTree/LayoutTestController.cpp:
2412         (LayoutTestController::staticFunctions):
2413         * DumpRenderTree/LayoutTestController.h:
2414         (LayoutTestController):
2415         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
2416         * DumpRenderTree/chromium/LayoutTestController.cpp:
2417         (LayoutTestController::LayoutTestController):
2418         (LayoutTestController::setPOSIXLocale):
2419         * DumpRenderTree/chromium/LayoutTestController.h:
2420         (LayoutTestController):
2421         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2422         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2423         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2424         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2425         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2426         (LayoutTestController):
2427         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2428         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2429         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2430         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2431         (WTR):
2432         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2433         (LayoutTestController):
2434
2435 2012-06-11  Hans Wennborg  <hans@chromium.org>
2436
2437         Speech JavaScript API: Make SpeechRecognitionError an Event
2438         https://bugs.webkit.org/show_bug.cgi?id=88784
2439
2440         Reviewed by Adam Barth.
2441
2442         Make it possible to have MockWebSpeechRecognizer fire error events.
2443
2444         * DumpRenderTree/chromium/LayoutTestController.cpp:
2445         (LayoutTestController::LayoutTestController):
2446         (LayoutTestController::setMockSpeechRecognitionError):
2447         * DumpRenderTree/chromium/LayoutTestController.h:
2448         (LayoutTestController):
2449         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
2450         (WebKit):
2451         (ErrorTask):
2452         (WebKit::ErrorTask::ErrorTask):
2453         (MockWebSpeechRecognizer::addMockResult):
2454         (MockWebSpeechRecognizer::setError):
2455         * DumpRenderTree/chromium/MockWebSpeechRecognizer.h:
2456         (MockWebSpeechRecognizer):
2457
2458 2012-06-11  Ojan Vafai  <ojan@chromium.org>
2459
2460         Don't show the ASAN builders in garden-o-matic since they don't get block WebKit rolls.
2461         https://bugs.webkit.org/show_bug.cgi?id=88836
2462
2463         Reviewed by Dirk Pranke.
2464
2465         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
2466         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
2467
2468 2012-06-11  Christophe Dumez  <christophe.dumez@intel.com>
2469
2470         [EFL] Remove CMakeCache.txt before building
2471         https://bugs.webkit.org/show_bug.cgi?id=88717
2472
2473         Reviewed by Antonio Gomes.
2474
2475         Remove CMake cache file before every build to avoid using outdated
2476         build flags when new features get enabled. This will avoid unexpected
2477         failures on the bots due to outdated build flags.
2478
2479         * Scripts/webkitdirs.pm:
2480         (generateBuildSystemFromCMakeProject):
2481
2482 2012-06-11  Vincent Scheib  <scheib@chromium.org>
2483
2484         Add new Pointer Lock spec attribute webkitPointerLockElement.
2485         https://bugs.webkit.org/show_bug.cgi?id=88799
2486
2487         Reviewed by Dimitri Glazkov.
2488
2489         Part of a series of refactoring changes to update pointer lock API to
2490         the fullscreen locking style. https://bugs.webkit.org/show_bug.cgi?id=84402
2491
2492         New attribute webkitPointerLockElement added. Follow up patches
2493         will remove the previous isLocked attribute. Tests updated to use
2494         the new attribute.
2495
2496         WebViewHost logic required modification to correctly repond to
2497         a lock, unlock, pointerLockElement call series. Specifically,
2498         unlocking must be queued after a lock command is issued always
2499         as the lock state may not be set yet with a lock request in flight.
2500
2501         * DumpRenderTree/chromium/WebViewHost.cpp:
2502         (WebViewHost::requestPointerUnlock): Always post didLosePointerLock task.
2503         (WebViewHost::didLosePointerLock): Signal didLosePointerLock only if pointer was locked.
2504
2505 2012-06-11  Alexis Menard  <alexis.menard@openbossa.org>
2506
2507         [CSS3 Backgrounds and Borders] Protect box-decoration-break behind a feature flag.
2508         https://bugs.webkit.org/show_bug.cgi?id=88804
2509
2510         Reviewed by Tony Chang.
2511
2512         Protect box-decoration-break behind a feature flag enabled by default.
2513
2514         * Scripts/webkitperl/FeatureList.pm:
2515         * qmake/mkspecs/features/features.pri:
2516
2517 2012-06-11  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2518
2519         [CMAKE][EFL] Remove duplicated executable output path
2520         https://bugs.webkit.org/show_bug.cgi?id=88765
2521
2522         Reviewed by Daniel Bates.
2523
2524         CMake files for EFL port have redefined executable output path. However, EFL port doesn't
2525         need to define again because it is already defined in top-level CMake file.
2526
2527         * DumpRenderTree/efl/CMakeLists.txt:
2528         * EWebLauncher/CMakeLists.txt:
2529
2530 2012-06-11  Ojan Vafai  <ojan@chromium.org>
2531
2532         Don't consider show warnings in the garden-o-matic UI for non-layout test failures
2533         https://bugs.webkit.org/show_bug.cgi?id=88816
2534
2535         Reviewed by Dirk Pranke.
2536
2537         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
2538         Expose a way to clear AsynchronousCaches.
2539         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
2540         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
2541         Clear the buildInfo cache at the beginning of each test in order to avoid having one test affect another.
2542
2543 2012-06-11  Dirk Pranke  <dpranke@chromium.org>
2544
2545         nrwt exits early too frequently
2546         https://bugs.webkit.org/show_bug.cgi?id=73843
2547
2548         Reviewed by Ryosuke Niwa.
2549
2550         Change the defaults for new-run-webkit-tests for both
2551         --exit-after-n-failures and --exit-after-n-crashes-or-timeouts
2552         to zero (i.e., we will never exit early by default).
2553
2554         If people want their buildbots to exit early it is their
2555         responsibility to update their buildbot configs appropriately.
2556
2557         Note that we have tests that ensure that these flags work for
2558         non-zero numbers, but we don't have tests that either test the
2559         default or ensure that zero means "run all of the tests". I
2560         think that's okay but can add tests if others disagree.
2561
2562         Also note that it looks like no changes on the build.webkit.org
2563         master.cfg are necessary; all of the bots seem to be using the
2564         RunWebKitTests wrapper which is already setting the flags. There
2565         is a NewRunWebKitTests wrapper, but that looks to be unused; I
2566         will delete that in a separate patch.
2567
2568         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2569         (parse_args):
2570
2571 2012-06-11  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2572
2573         [EFL] [DRT] Reset CacheModel before running each test
2574         https://bugs.webkit.org/show_bug.cgi?id=87534
2575
2576         Reviewed by Gustavo Noronha Silva.
2577
2578         Reset cache model to default before running each test to fix some
2579         flaky tests on EFL build bots. Also fix case value in setCacheModel.
2580
2581         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2582         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2583         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2584         (LayoutTestController::setCacheModel):
2585
2586 2012-06-11  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2587
2588         [GTK] Memory leaks in DRT EventSender.cpp
2589         https://bugs.webkit.org/show_bug.cgi?id=88774
2590
2591         Reviewed by Martin Robinson.
2592
2593         Fix a few possible memory leaks in EventSender code.
2594
2595         * DumpRenderTree/gtk/EventSender.cpp:
2596         (contextClickCallback): Free the event returned by gdk_event_new().
2597         (mouseDownCallback): Ditto.
2598         (mouseUpCallback): Ditto.
2599
2600 2012-06-11  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2601
2602         [EFL] REGRESSION (r119788): tests rely on pathToLocalResource are failing after r119788
2603         https://bugs.webkit.org/show_bug.cgi?id=88661
2604
2605         Reviewed by Dirk Pranke.
2606
2607         Pass string length explicitly when creating String object from
2608         non-null-terminated UChar* returned by characters().
2609
2610         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2611         (LayoutTestController::pathToLocalResource):
2612
2613 2012-06-11  David Dorwin  <ddorwin@chromium.org>
2614
2615         [chromium] Provide access to the WebPlugin created by the helper plugin widget
2616         https://bugs.webkit.org/show_bug.cgi?id=88028
2617
2618         Reviewed by Adam Barth.
2619
2620         Added isPlaceholder() to WebPlugin.
2621
2622         * DumpRenderTree/chromium/TestWebPlugin.h:
2623         (TestWebPlugin::isPlaceholder):
2624
2625 2012-06-11  Tony Chang  <tony@chromium.org>
2626
2627         rebaseline from garden-o-matic leaves N processes each time it is run
2628         https://bugs.webkit.org/show_bug.cgi?id=88586
2629
2630         Reviewed by Dirk Pranke.
2631
2632         This appears to only be a problem on python 2.7. Maybe a bug causing
2633         pools to not be garbage collected?
2634
2635         * Scripts/webkitpy/common/system/executive.py:
2636         (Executive.run_in_parallel): close() and join() the process pool.
2637         * Scripts/webkitpy/common/system/executive_unittest.py:
2638         (ExecutiveTest.test_run_in_parallel):
2639
2640 2012-06-11  Zoltan Horvath  <zoltan@webkit.org>
2641
2642         [Qt] Add config tests for WEBP imagedecoder library, modify HAVE(decoderlibrary) to USE(...)
2643         https://bugs.webkit.org/show_bug.cgi?id=87841
2644
2645         Reviewed by Simon Hausmann.
2646
2647         * qmake/config.tests/libwebp/libwebp.cpp: Added.
2648         (main):
2649         * qmake/config.tests/libwebp/libwebp.pro: Added.
2650         * qmake/sync.profile:
2651
2652 2012-06-10  Ryosuke Niwa  <rniwa@webkit.org>
2653
2654         Expose layoutTestController as testRunner
2655         https://bugs.webkit.org/show_bug.cgi?id=88210
2656
2657         Reviewed by Darin Adler.
2658
2659         * DumpRenderTree/LayoutTestController.cpp:
2660         (LayoutTestController::makeWindowObject):
2661         * DumpRenderTree/chromium/TestShell.cpp:
2662         (TestShell::bindJSObjectsToWindow):
2663         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2664         (WebCore::DumpRenderTree::initJSObjects):
2665         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2666         (WTR::LayoutTestController::makeWindowObject):
2667
2668 2012-06-09  Dominic Cooney  <dominicc@chromium.org>
2669
2670         [Chromium] Remove JavaScriptCore dependencies from gyp
2671         https://bugs.webkit.org/show_bug.cgi?id=88510
2672
2673         Reviewed by Adam Barth.
2674
2675         Chromium doesn't support JSC any more and there doesn't seem to be
2676         a strong interest in using GYP as the common build system in other
2677         ports.
2678
2679         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2680         * Scripts/generate-project-files: Removed.
2681
2682 2012-06-09  Sukolsak Sakshuwong  <sukolsak@google.com>
2683
2684         Add UNDO_MANAGER flag
2685         https://bugs.webkit.org/show_bug.cgi?id=87908
2686
2687         Reviewed by Tony Chang.
2688
2689         * Scripts/webkitperl/FeatureList.pm:
2690         * qmake/mkspecs/features/features.pri:
2691
2692 2012-06-08  Ryosuke Niwa  <rniwa@webkit.org>
2693
2694         webkit-patch land-safely should set cq? if the patch author is not in committers.py
2695         https://bugs.webkit.org/show_bug.cgi?id=88689
2696
2697         Reviewed by Dirk Pranke.
2698
2699         When posting a patch on Bugzilla, trun cq+ into cq? if the Bugzilla login is not listed
2700         in committers.py or the contributor cannot commit. If anything, the contributor can still
2701         set cq+ on thier patches manually so I don't think this will be an issue for people who
2702         don't list their Bugzille email on committers.py.
2703
2704         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2705         (Bugzilla._commit_queue_flag):
2706         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
2707         (test_commit_queue_flag):
2708         (test_commit_queue_flag.assert_commit_queue_flag):
2709
2710 2012-06-08  Dirk Pranke  <dpranke@chromium.org>
2711
2712         remove obsolete NewRunWebKitTests buildbot master factory classes
2713         https://bugs.webkit.org/show_bug.cgi?id=88693
2714
2715         Reviewed by Ryosuke Niwa.
2716
2717         I believe these aren't used any more ...
2718
2719         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2720         (RunWebKitTests.getText2):
2721         (BuildAndTestLeaksFactory):
2722
2723 2012-06-08  Xianzhu Wang  <wangxianzhu@chromium.org>
2724
2725         [Chromium-Android] Build DumpRenderTree with Android SDK
2726         https://bugs.webkit.org/show_bug.cgi?id=88598
2727
2728         Change WebKit side of DRT related code according to some recent changes at chromium side.
2729
2730         Reviewed by Adam Barth.
2731
2732         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2733         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2734         (ChromiumAndroidPort.__init__):
2735         (ChromiumAndroidPort._path_to_driver):
2736
2737 2012-06-08  Wei James  <james.wei@intel.com>
2738
2739         Add app_abi option for DumpRenderTree_apk
2740         https://bugs.webkit.org/show_bug.cgi?id=88626
2741
2742         Reviewed by Adam Barth.
2743
2744         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2745
2746 2012-06-08  Carlos Garcia Campos  <cgarcia@igalia.com>
2747
2748         [GTK] Add API to get the library version to WebKit2 GTK+
2749         https://bugs.webkit.org/show_bug.cgi?id=88426
2750
2751         Reviewed by Martin Robinson.
2752
2753         * gtk/generate-gtkdoc:
2754         (get_webkit2_options): Add built sources to the list of files, but
2755         ignore enum types and marshallers.
2756
2757 2012-06-07  Vincent Scheib  <scheib@chromium.org>
2758
2759         Layout Test pointer-lock/pointerlockchange-pointerlockerror-events.html is failing
2760         https://bugs.webkit.org/show_bug.cgi?id=88604
2761
2762         Reviewed by Kent Tamura.
2763
2764         DumpRenderTree fixed to not call didLosePointerLock if pointer is not currently locked.
2765         Fixes debug only assert crash in pointer-lock/pointerlockchange-pointerlockerror-events.html test.
2766
2767         * DumpRenderTree/chromium/WebViewHost.cpp:
2768         (WebViewHost::requestPointerUnlock):
2769
2770 2012-06-08  Hans Wennborg  <hans@chromium.org>
2771
2772         Speech JavaScript API: mock WebSpeechRecognizer for DumpRenderTree
2773         https://bugs.webkit.org/show_bug.cgi?id=87976
2774
2775         Reviewed by Kent Tamura.
2776
2777         Provide a mock implementation of WebSpeechRecognizer for
2778         DumpRenderTree. This will allow better testing of the API via layout
2779         tests.
2780
2781         * DumpRenderTree/DumpRenderTree.gypi:
2782         * DumpRenderTree/chromium/LayoutTestController.cpp:
2783         (LayoutTestController::LayoutTestController):
2784         (LayoutTestController::addMockSpeechRecognitionResult):
2785         * DumpRenderTree/chromium/LayoutTestController.h:
2786         (LayoutTestController):
2787         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp: Added.
2788         (MockWebSpeechRecognizer::create):
2789         (MockWebSpeechRecognizer::start):
2790         (MockWebSpeechRecognizer::stop):
2791         (MockWebSpeechRecognizer::abort):
2792         (MockWebSpeechRecognizer::MockWebSpeechRecognizer):
2793         (MockWebSpeechRecognizer::~MockWebSpeechRecognizer):
2794         (MockWebSpeechRecognizer::ResultTask::runIfValid):
2795         * DumpRenderTree/chromium/MockWebSpeechRecognizer.h: Added.
2796         (WebKit):
2797         (MockWebSpeechRecognizer):
2798         (MockWebSpeechRecognizer::addMockResult):
2799         (MockWebSpeechRecognizer::taskList):
2800         (ClientCallTask):
2801         (MockWebSpeechRecognizer::ClientCallTask::ClientCallTask):
2802         (ResultTask):
2803         (MockWebSpeechRecognizer::ResultTask::ResultTask):
2804         (NoMatchTask):
2805         (MockWebSpeechRecognizer::NoMatchTask::NoMatchTask):
2806         * DumpRenderTree/chromium/WebViewHost.cpp:
2807         (WebViewHost::speechRecognizer):
2808         * DumpRenderTree/chromium/WebViewHost.h:
2809         (WebViewHost):
2810         (WebViewHost::mockSpeechRecognizer):
2811
2812 2012-06-07  Kinuko Yasuda  <kinuko@chromium.org>
2813
2814         check-webkit-style needs to be taught about <public/Foo.h>
2815         https://bugs.webkit.org/show_bug.cgi?id=88524
2816
2817         Reviewed by David Levin.
2818
2819         * Scripts/webkitpy/style/checkers/cpp.py:
2820         (_classify_include):
2821         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2822         (OrderOfIncludesTest.test_public_primary_header):
2823         (OrderOfIncludesTest.test_classify_include):
2824
2825 2012-06-07  Joshua Lock  <joshua.lock@intel.com>
2826
2827         [EFL][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
2828         https://bugs.webkit.org/show_bug.cgi?id=67255
2829
2830         Reviewed by Dirk Pranke.
2831
2832         Implement pathToLocalResource to redirect file:///tmp URL's to
2833         DUMPRENDERTREE_TEMP and file:///tmp/LayoutTests to point to the
2834         LayoutTests sub-directory of the WebKit source tree.
2835
2836         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2837         (LayoutTestController::pathToLocalResource):
2838
2839 2012-06-07  Tony Payne  <tpayne@chromium.org>
2840
2841         [chromium] Allow LayoutTests under new git workflow
2842         https://bugs.webkit.org/show_bug.cgi?id=88575
2843
2844         On Windows, chromium indirects through git.bat. Adds the same hack that
2845         is currently used for discovering svn.bat to support the new git
2846         workflow.
2847
2848         Reviewed by Dirk Pranke.
2849
2850         * Scripts/webkitpy/common/checkout/scm/git.py:
2851         (Git): Replaces all hard-coded references to 'git' with the class
2852         variable executable_name.
2853         (Git._check_git_architecture):
2854         (Git.in_working_directory):
2855         (Git.find_checkout_root):
2856         (Git.read_git_config):
2857         (Git.discard_local_commits):
2858         (Git.local_commits):
2859         (Git.working_directory_is_clean):
2860         (Git.clean_working_directory):
2861         (Git.status_command):
2862         (Git.add_list):
2863         (Git.delete_list):
2864         (Git.exists):
2865         (Git._current_branch):
2866         (Git.changed_files):
2867         (Git._changes_files_for_commit):
2868         (Git.revisions_changing_file):
2869         (Git.conflicted_files):
2870         (Git.svn_revision):
2871         (Git.create_patch):
2872         (Git._run_git_svn_find_rev):
2873         (Git.contents_at_revision):
2874         (Git.diff_for_file):
2875         (Git.show_head):
2876         (Git.committer_email_for_revision):
2877         (Git.apply_reverse_diff):
2878         (Git.revert_files):
2879         (Git.commit_with_message):
2880         (Git._commit_on_branch):
2881         (Git.svn_commit_log):
2882         (Git.last_svn_commit_log):
2883         (Git.svn_blame):
2884         (Git._branch_ref_exists):
2885         (Git.delete_branch):
2886         (Git.remote_merge_base):
2887         (Git.commit_locally_with_message):
2888         (Git.push_local_commits_to_server):
2889         (Git.commit_ids_from_commitish_arguments):
2890         (Git.commit_message_for_local_commit):
2891         (Git.files_changed_summary_for_commit):
2892         * Scripts/webkitpy/common/host.py:
2893         (Host._engage_awesome_windows_hacks): Adds an awesome 'git.bat' hack
2894         that duplicates the logic in the existing 'svn.bat' hack.
2895
2896 2012-06-07  Ojan Vafai  <ojan@chromium.org>
2897
2898         Style build architectures like build versions for non-layout test failures
2899         https://bugs.webkit.org/show_bug.cgi?id=88590
2900
2901         Reviewed by Tony Chang.
2902
2903         Since we show the list of failing tests after the architecture, we want the
2904         buildtype and architecture to be grouped together visually.
2905
2906         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css:
2907         (.effects a.failing-builder>span.architecture):
2908
2909 2012-06-07  Xianzhu Wang  <wangxianzhu@chromium.org>
2910
2911         [Chromium] Remove header dependency of ImageDiff to WTF
2912         https://bugs.webkit.org/show_bug.cgi?id=88422
2913
2914         Reviewed by Ryosuke Niwa.
2915
2916         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2917         * DumpRenderTree/chromium/ImageDiff.cpp:
2918         (untestedCompareImages):
2919
2920 2012-06-07  Dongwoo Im  <dw.im@samsung.com>
2921
2922         [EFL] [DRT] DRT enables WebAudio when WebAudio feature is enabled.
2923         https://bugs.webkit.org/show_bug.cgi?id=88491
2924
2925         Reviewed by Dirk Pranke.
2926
2927         DRT should enable WebAudio when WebAudio feature is enabled,
2928         so that the WebAudio feature could be tested by the Layouttest.
2929
2930         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp: Enable WebAudio when WebAudio feature is enabled.
2931         (LayoutTestController::overridePreference):
2932
2933 2012-06-07  Dirk Pranke  <dpranke@chromium.org>
2934
2935         webkit-patch rebaseline-expectations should only rebaseline the appropriate suffixes for the failure in question
2936         https://bugs.webkit.org/show_bug.cgi?id=88581
2937
2938         Reviewed by Ojan Vafai.
2939
2940         webkit-paptch rebaseline-expectations was ignoring what the
2941         expected results for a test were and pulling down all the result
2942         files from a bot. This could lead to us pulling down old,
2943         incorrect .txt or .png files. With this patch we will now only
2944         pull down expectations of the appropriate file types (so an
2945         IMAGE failure will only pull the png and not the txt file).
2946
2947         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2948         (has_pixel_failures):
2949         (suffixes_for_expectations):
2950         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2951         (FunctionsTest.test_suffixes_for_expectations):
2952         * Scripts/webkitpy/tool/commands/rebaseline.py:
2953         (AbstractRebaseliningCommand.__init__):
2954         (RebaselineExpectations._is_supported_port):
2955         (RebaselineExpectations._update_expectations_file):
2956         (RebaselineExpectations._tests_to_rebaseline):
2957         (RebaselineExpectations._rebaseline_port):
2958         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2959         (test_overrides_are_included_correctly):
2960
2961 2012-06-07  Ojan Vafai  <ojan@chromium.org>
2962
2963         Fix recent null pointer error regression in the flakiness dashboard
2964         https://bugs.webkit.org/show_bug.cgi?id=88573
2965
2966         Reviewed by Dirk Pranke.
2967
2968         * TestResultServer/static-dashboards/builders.js:
2969         (requestBuilderList):
2970         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2971
2972 2012-06-07  Konrad Piascik  <kpiascik@rim.com>
2973
2974         Add Konrad Piascik to committers.py
2975         https://bugs.webkit.org/show_bug.cgi?id=88560
2976
2977         Unreviewed.
2978
2979         * Scripts/webkitpy/common/config/committers.py:
2980
2981 2012-06-07  Tony Chang  <tony@chromium.org>
2982
2983         [chromium] Win mock scrollbars appear to overflow by a pixel to the right and bottom
2984         https://bugs.webkit.org/show_bug.cgi?id=77368
2985
2986         Reviewed by Ojan Vafai.
2987
2988         It doesn't look like we ever get a rect with width or height of 0.
2989         I ran css1, css2.1, fast/forms, and tables without any crashes.
2990
2991         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
2992         (webRectToSkIRect): Correctly convert a WebRect to a SkIRect.
2993
2994 2012-06-07  Dirk Pranke  <dpranke@chromium.org>
2995
2996         run-webkit-tests --lint-test-files gives an error when run on linux
2997         https://bugs.webkit.org/show_bug.cgi?id=88551
2998
2999         Reviewed by Ojan Vafai.
3000
3001         We weren't mapping the expectations properly for the
3002         google-chrome ports.
3003
3004         * Scripts/webkitpy/layout_tests/port/base.py:
3005         (Port.path_to_test_expectations_file):
3006         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
3007         (TestGoogleChromePort.test_path_to_expectations):
3008
3009 2012-06-07  Daniel Erat  <derat@chromium.org>
3010
3011         [chromium] Add LayoutTestController::setTextSubpixelPositioning() for Linux.
3012         https://bugs.webkit.org/show_bug.cgi?id=88263
3013
3014         Reviewed by Tony Chang.
3015
3016         * DumpRenderTree/chromium/LayoutTestController.cpp:
3017         (LayoutTestController::LayoutTestController):
3018         (LayoutTestController::reset):
3019         (LayoutTestController::setTextSubpixelPositioning):
3020         * DumpRenderTree/chromium/LayoutTestController.h:
3021         (LayoutTestController):
3022         * DumpRenderTree/chromium/fonts.conf:
3023
3024 2012-06-07  Zan Dobersek  <zandobersek@gmail.com>
3025
3026         [Gtk] Assertions in gtk_widget_draw when acquiring pixel output
3027         https://bugs.webkit.org/show_bug.cgi?id=88060
3028
3029         Reviewed by Martin Robinson.
3030
3031         Spin the main loop before acquiring the pixel content. This ensures things
3032         like late size allocations are finished before calling gtk_widget_draw,
3033         avoiding assertions and subsequent empty pixel results.
3034
3035         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
3036         (createBitmapContextFromWebView):
3037
3038 2012-06-06  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3039
3040         [Qt] Improve the visual of the viewport info box
3041         https://bugs.webkit.org/show_bug.cgi?id=88410
3042
3043         Reviewed by Tor Arne Vestbø.
3044
3045         Improve the visual and make it possible to see the content more easy.
3046
3047         * MiniBrowser/qt/qml/ViewportInfoItem.qml:
3048
3049 2012-06-06  Mariusz Grzegorczyk  <mariusz.g@samsung.com>
3050
3051         [EFL][WK2] Compile webkit1 and webkit2 by default.
3052         https://bugs.webkit.org/show_bug.cgi?id=85041
3053
3054         Reviewed by Chang Shu.
3055
3056         Compile webkit1 and webkit2 while running Tools/Scripts/build-webkit --efl.
3057         Webkit2 build can be skipped by adding --no-webkit2 option to build-webkit script.
3058
3059         * Scripts/build-webkit:
3060
3061 2012-06-06  Sheriff Bot  <webkit.review.bot@gmail.com>
3062
3063         Unreviewed, rolling out r119662.
3064         http://trac.webkit.org/changeset/119662
3065         https://bugs.webkit.org/show_bug.cgi?id=88487
3066
3067         Broke builds (Requested by rniwa on #webkit).
3068
3069         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3070         * DumpRenderTree/chromium/ImageDiff.cpp:
3071         (untestedCompareImages):
3072
3073 2012-06-06  Xianzhu Wang  <wangxianzhu@chromium.org>
3074
3075         [Chromium] Remove header dependency of ImageDiff to WTF
3076         https://bugs.webkit.org/show_bug.cgi?id=88422
3077
3078         Reviewed by Adam Barth.
3079
3080         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3081         * DumpRenderTree/chromium/ImageDiff.cpp:
3082         (untestedCompareImages):
3083
3084 2012-06-06  Amy Ousterhout  <aousterh@chromium.org>
3085
3086         [WebKit] DeviceOrientation cleanup
3087         https://bugs.webkit.org/show_bug.cgi?id=88406
3088
3089         Reviewed by Kent Tamura.
3090
3091         Updated LayoutTestController to use new public default constructor in WebDeviceOrientation.h.
3092
3093         * DumpRenderTree/chromium/LayoutTestController.cpp:
3094         (LayoutTestController::setMockDeviceOrientation):
3095
3096 2012-05-29  Dirk Pranke  <dpranke@chromium.org>
3097
3098         webkitpy: add support for an ordered dict of test expectations
3099         https://bugs.webkit.org/show_bug.cgi?id=87802
3100
3101         Reviewed by Ojan Vafai.
3102
3103         As per https://bugs.webkit.org/show_bug.cgi?id=65834 we want to
3104         support a cascaded list of test expectations files. An easy way
3105         to think of this is as an ordered dictionary of name -> contents
3106         for files, where the name is usually a path on disk (I say
3107         usually because we want to support other kinds of expectations
3108         like the compile-time skips for unsupported features in
3109         webkit.py, and we want to continue to support "in-memory" test
3110         expectations that don't require a filesystem).
3111
3112         Conveniently there is an OrderedDict implementation in Python
3113         2.7+ and it is available as a backport, so the first step in
3114         adding this support is to use that implementation. Subsequent
3115         patches will update the test_expectations.py module (and other
3116         callers) to access the dict directly.
3117
3118         This patch just changes the base internal implementation and
3119         provides wrappers for compatibility. The derived ports
3120         (WebKitPort, TestPort, etc.) still need to be updated.
3121
3122         * Scripts/webkitpy/layout_tests/port/base.py:
3123         (Port._expectations_dict):
3124         (Port.test_expectations):
3125         (Port):
3126         (Port._expectations_overrides_dict):
3127         (Port.test_expectations_overrides):
3128         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3129         (PortTestCase.test_expectations_ordering):
3130         (PortTestCase):
3131         (PortTestCase.test_expectations_overrides_ordering):
3132         * Scripts/webkitpy/thirdparty/ordered_dict.py: Added.
3133         (OrderedDict):
3134         (OrderedDict.__init__):
3135         (OrderedDict.clear):
3136         (OrderedDict.__setitem__):
3137         (OrderedDict.__delitem__):
3138         (OrderedDict.__iter__):
3139         (OrderedDict.__reversed__):
3140         (OrderedDict.popitem):
3141         (OrderedDict.__reduce__):
3142         (OrderedDict.__repr__):
3143         (OrderedDict.copy):
3144         (OrderedDict.fromkeys):
3145
3146 2012-06-06  Mario Sanchez Prada  <msanchez@igalia.com>
3147
3148         Unreviewed gardening. Unit test fails on GTK 64bit debug bot.
3149
3150         * gtk/run-api-tests:
3151         (TestRunner): Skip TestWebKitAPI/WTF/TestHashMap.
3152
3153 2012-06-06  Dirk Pranke  <dpranke@chromium.org>
3154
3155         nrwt should look in 'out' for binaries on chromium win to support ninja
3156         https://bugs.webkit.org/show_bug.cgi?id=88273
3157
3158         Reviewed by Tony Chang.
3159
3160         This patch standardizes the search algorithm the chromium ports
3161         use to figure out which driver to run. We will look in a
3162         chromium location before a webkit location (e.g., in
3163         Source/WebKit/chromium/out before out/) and we will look in the
3164         "legacy" directory (xcodebuild) before the directory ninja uses
3165         (out).
3166
3167         Unfortunately due to the way the test code is set up testing the
3168         properly requires some duplication of test code. I will fix that
3169         in a followup patch.
3170
3171         * Scripts/webkitpy/layout_tests/port/chromium.py:
3172         (ChromiumPort):
3173         (ChromiumPort._static_build_path):
3174         (ChromiumPort._build_path):
3175         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3176         (ChromiumLinuxPort):
3177         (ChromiumLinuxPort._determine_driver_path_statically):
3178         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
3179         (ChromiumLinuxPortTest.test_build_path):
3180         (ChromiumLinuxPortTest):
3181         (ChromiumLinuxPortTest.test_driver_name_option):
3182         (ChromiumLinuxPortTest.path_to_image_diff):
3183         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3184         (ChromiumMacPort):
3185         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
3186         (ChromiumMacPortTest.test_build_path):
3187         (ChromiumMacPortTest):
3188         (ChromiumMacPortTest.test_driver_name_option):
3189         (ChromiumMacPortTest.path_to_image_diff):
3190         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3191         (ChromiumPortTest.test_overrides_and_builder_names):
3192         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3193         (ChromiumWinPort):
3194         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3195         (ChromiumWinTest.test_build_path):
3196         (ChromiumWinTest.test_operating_system):
3197         (ChromiumWinTest):
3198         (ChromiumWinTest.test_driver_name_option):
3199         (ChromiumWinPortTest.path_to_image_diff):
3200         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3201         (PortTestCase.assert_build_path):
3202
3203 2012-06-06  Jessie Berlin  <jberlin@apple.com>
3204
3205         Remove very red Windows WebKit2 testers
3206         https://bugs.webkit.org/show_bug.cgi?id=88452
3207
3208         Reviewed by Steve Falkenburg.
3209
3210         Remove the Windows 7 Release WK2 testers so that the hardware can be repurposed. We are
3211         need to focus on getting the WK1 testers green.
3212
3213         * BuildSlaveSupport/build.webkit.org-config/config.json:
3214
3215 2012-06-06  Dirk Pranke  <dpranke@chromium.org>
3216
3217         get rebaselining tools to kinda work with the skia overrides file
3218         https://bugs.webkit.org/show_bug.cgi?id=88456
3219
3220         Reviewed by Ryosuke Niwa.
3221
3222         Update rebaseline-expectations so that we read in the overrides
3223         when looking for tests to rebaseline, but don't read in the
3224         overrides when we are writing the expectations file back out.
3225         This prevents the overrides from getting written into the main
3226         file. This is kind of a hack but will have to do until we
3227         support multiple expectations files properly.
3228
3229         * Scripts/webkitpy/tool/commands/rebaseline.py:
3230         (RebaselineExpectations._expectations):
3231         (RebaselineExpectations._update_expectations_file):
3232         (RebaselineExpectations._tests_to_rebaseline):
3233         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3234         (test_overrides_are_included_correctly):
3235
3236 2012-06-06  Dirk Pranke  <dpranke@chromium.org>
3237
3238         webkitpy: two manager_worker_broker_unittest tests are broken
3239         https://bugs.webkit.org/show_bug.cgi?id=88445
3240
3241         Reviewed by Ojan Vafai.
3242
3243         These tests were never updated when we removed the
3244         --worker-model argument, and we were passing 'inline' instead of
3245         1 (for the number of workers) :(. As a result we were creating
3246         multiprocessing queues unnecessarily and that was failing on cygwin.
3247
3248         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
3249         (InterfaceTest.test_managerconnection_is_abstract):
3250         (InterfaceTest.test_workerconnection_is_abstract):
3251
3252 2012-06-06  Ryosuke Niwa  <rniwa@webkit.org>
3253
3254         REGRESSION(r117789): "webkit-patch rebaseline-expectations" copies contents in skia_test_expectations.txt into test_expectations.txt
3255         https://bugs.webkit.org/show_bug.cgi?id=87406
3256
3257         Reviewed by Dirk Pranke.
3258
3259         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3260         (TestExpectations.__init__):
3261         * Scripts/webkitpy/tool/commands/rebaseline.py:
3262         (RebaselineTest._update_expectations_file):
3263         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3264         (test_rebaseline_does_not_include_overrides):
3265
3266 2012-06-06  Dirk Pranke  <dpranke@chromium.org>
3267
3268         webkitpy: perf tests unit tests fail on chromium win
3269         https://bugs.webkit.org/show_bug.cgi?id=88279
3270
3271         Reviewed by Ryosuke Niwa.
3272
3273         I'm seeing weird failures running the unit tests in my win32
3274         checkout, and we don't really expect webpagereplay to work on
3275         win32 anyway, so I'm skipping the import of that module for now
3276         and adding a warning.
3277
3278         * Scripts/run-perf-tests:
3279         * Scripts/webkitpy/performance_tests/perftest.py:
3280
3281 2012-06-06  Yong Li <yoli@rim.com>
3282
3283         Unreviewed. Update my email address in committers.py.
3284
3285         * Scripts/webkitpy/common/config/committers.py:
3286
3287 2012-06-06  Robert Kroeger  <rjkroege@chromium.org>
3288
3289         Add Robert Kroeger  to commiters.py
3290         https://bugs.webkit.org/show_bug.cgi?id=88415
3291
3292         Unreviewed.
3293
3294         * Scripts/webkitpy/common/config/committers.py:
3295
3296 2012-06-06  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3297
3298         [EFL][DRT] http/tests/globalhistory testcases do not pass
3299         https://bugs.webkit.org/show_bug.cgi?id=82579
3300
3301         Reviewed by Csaba Osztrogonác.
3302
3303         DRT has provided callbacks for ewk_view "global history delegate" signals.
3304
3305         * DumpRenderTree/efl/DumpRenderTree.cpp:
3306         (isGlobalHistoryTest): Aux function to ident global history testcase.
3307         (createLayoutTestController):
3308         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3309         (DumpRenderTreeChrome::createView):
3310         (DumpRenderTreeChrome::onTitleChanged): Handles also some global history testcases.
3311         (DumpRenderTreeChrome::onWebViewNavigatedWithData): New callback function.
3312         (DumpRenderTreeChrome::onWebViewServerRedirect): Ditto.
3313         (DumpRenderTreeChrome::onWebViewClientRedirect): Ditto.
3314         (DumpRenderTreeChrome::onWebViewPopulateVisitedLinks): Ditto.
3315         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
3316         (DumpRenderTreeChrome):
3317
3318 2012-06-06  János Badics  <jbadics@inf.u-szeged.hu>
3319
3320         [Qt] run-qtwebkit-tests hangs with -j1
3321         run-qtwebkit-tests used to hang when wk2 API tests were run with -j1 and --timeout.
3322         This could happen due to an uncancelled timer after results were returned. This timer was
3323         started only if --timeout was set.
3324         https://bugs.webkit.org/show_bug.cgi?id=85475
3325
3326         Reviewed by Csaba Osztrogonác.
3327
3328         * Scripts/run-qtwebkit-tests:
3329         (run_test):
3330
3331 2012-06-06  Michael Brüning  <michael.bruning@nokia.com>
3332
3333         [Qt][WK2] Add preferredMinimumContentsWidth to the viewport info in MiniBrowser.
3334         https://bugs.webkit.org/show_bug.cgi?id=88327
3335
3336         Reviewed by Kenneth Rohde Christiansen.
3337
3338         * MiniBrowser/qt/MiniBrowser.qrc: Added contents_width.png.
3339         * MiniBrowser/qt/icons/contents_width.png: Added.
3340         * MiniBrowser/qt/qml/BrowserWindow.qml: Added button for toggling preferredMinimumContentsWidth.
3341         * MiniBrowser/qt/qml/ViewportInfoItem.qml: Added display of preferredMinimumContentsWidth.
3342
3343 2012-06-05  Jon Lee  <jonlee@apple.com>
3344
3345         Buildbot fix.
3346
3347         * BuildSlaveSupport/build.webkit.org-config/master.cfg: We lose the type attribute earlier
3348         in the function. Store in a local variable.
3349         (loadBuilderConfig):
3350
3351 2012-06-05  Jon Lee  <jonlee@apple.com>
3352
3353         Buildbot fix.
3354
3355         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3356         (loadBuilderConfig):
3357
3358 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
3359
3360         webkitpy: clean up win-specific path handling and tests
3361         https://bugs.webkit.org/show_bug.cgi?id=88281
3362
3363         Reviewed by Adam Barth.
3364
3365         There was a bunch of inconsistent logic for handling path
3366         conversions for win32 and cygwin paths due to us sometimes
3367         looking at sys.platform and sometimes using mock hosts. This
3368         patch cleans everything up so that we are required to pass
3369         PlatformInfo objects to the path module and stop trying to do
3370         different things when running on cygwin or win32 hosts (except
3371         in the path_unittest module itself).
3372
3373         This may slightly reduce test coverage for the win32 code paths
3374         but will be a lot easier to follow and maintain.
3375
3376         * Scripts/webkitpy/common/system/path.py:
3377         (abspath_to_uri):
3378         (_convert_path):
3379         * Scripts/webkitpy/common/system/path_unittest.py:
3380         (AbspathTest.platforminfo):
3381         (AbspathTest.test_abspath_to_uri_cygwin):
3382         (AbspathTest.test_abspath_to_uri_unixy):
3383         (AbspathTest.test_abspath_to_uri_win):
3384         (AbspathTest.test_abspath_to_uri_escaping_unixy):
3385         (AbspathTest.test_abspath_to_uri_escaping_cygwin):
3386         (AbspathTest.test_stop_cygpath_subprocess):
3387         * Scripts/webkitpy/common/system/platforminfo.py:
3388         (PlatformInfo.__init__):
3389         (PlatformInfo.is_cygwin):
3390         * Scripts/webkitpy/common/system/platforminfo_mock.py:
3391         (MockPlatformInfo.is_cygwin):
3392         * Scripts/webkitpy/layout_tests/port/base.py:
3393         (Port.to.show_results_html_file):
3394         * Scripts/webkitpy/layout_tests/port/driver.py:
3395         (Driver.test_to_uri):
3396         (Driver.uri_to_test):
3397         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
3398         (DriverTest.test_test_to_uri):
3399         (DriverTest.test_uri_to_test):
3400         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
3401         (MockDRTPortTest.make_port):
3402         (MockDRTTest.input_line):
3403         (MockChromiumDRTTest.test_pixeltest__fails):
3404         * Scripts/webkitpy/layout_tests/port/test.py:
3405         * Scripts/webkitpy/layout_tests/port/win.py:
3406         (WinPort.show_results_html_file):
3407         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3408         (MainTest.test_unexpected_failures):
3409         (MainTest.test_results_directory_absolute):
3410         (MainTest.test_results_directory_default):
3411         (MainTest.test_results_directory_relative):
3412
3413 2012-06-05  Jon Lee  <jonlee@apple.com>
3414
3415         Workaround buildbot bug when merging build requests.
3416         https://bugs.webkit.org/show_bug.cgi?id=88158
3417
3418         Reviewed by Mark Rowe.
3419
3420         For expediency, we still want testers to pick the latest build to test, but to ensure
3421         that the builders are reporting the correct revision number, we should let the building bots
3422         run as they normally would. That is, the builder picks the oldest revision, and merges
3423         subsequent requests. Because merged requests get appended to the list of changes for a given
3424         build, the last change in that list is also the latest change. When we used pickLatestBuild
3425         for the builders, this was not the case (it would always report the penultimate change).
3426
3427         http://trac.buildbot.net/ticket/2309 is tracking the buildbot bug.
3428
3429         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove the mergeRequests override
3430         for all Apple builders.
3431         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Have only non-building bots pick
3432         the latest build to run.
3433         (loadBuilderConfig):
3434
3435 2012-06-05  Jessie Berlin  <jberlin@apple.com>
3436
3437         [Win] DumpRenderTree should call resetInternalsObject
3438         https://bugs.webkit.org/show_bug.cgi?id=88346
3439
3440         Reviewed by Simon Fraser.
3441
3442         Invoke it on Windows in the same place it is invoked on Mac.
3443
3444         * DumpRenderTree/win/DumpRenderTree.cpp:
3445         (resetWebViewToConsistentStateBeforeTesting):
3446
3447 2012-06-05  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
3448
3449         [GTK] Fix two more memory leaks in DRT
3450         https://bugs.webkit.org/show_bug.cgi?id=88255
3451
3452         Reviewed by Martin Robinson.
3453
3454         Fixed memory leaks in GTK's DRT code.
3455
3456         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3457         (dumpHistoryItem): webkit_web_history_item_get_target() returns a
3458         g_strdup()'d string. So, use GOwnPtr to manage memory automatically.
3459         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
3460         (createBitmapContextFromWebView): Free the cairo surface.
3461
3462 2012-06-05  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
3463
3464         [Qt] Building when a top directory is named Source
3465         https://bugs.webkit.org/show_bug.cgi?id=77727
3466
3467         Reviewed by Tor Arne Vestbø.
3468
3469         Change regex to only replace the last instance of OUT_PWD.
3470
3471         * qmake/mkspecs/features/default_pre.prf:
3472
3473 2012-06-05  Dongwoo Im  <dw.im@samsung.com>
3474
3475         Add 'isProtocolHandlerRegistered' and 'unregisterProtocolHandler'.
3476         https://bugs.webkit.org/show_bug.cgi?id=73176
3477
3478         Reviewed by Adam Barth.
3479
3480         Two more APIs are added in Custom Scheme Handler specification.
3481         http://dev.w3.org/html5/spec/Overview.html#custom-handlers
3482         One is 'isProtocolHandlerRegistered' to query whether the specific URL
3483         is registered or not.
3484         The other is 'unregisterProtocolHandler' to remove the registered URL.
3485
3486         * Scripts/webkitperl/FeatureList.pm: Add a macro 'ENABLE_CUSTOM_SCHEME_HANDLER'.
3487
3488 2012-06-05  Mario Sanchez Prada  <msanchez@igalia.com>
3489
3490         [GTK][WK2] Implement API for Geolocation permission requests in the GTK port
3491         https://bugs.webkit.org/show_bug.cgi?id=83879
3492
3493         Reviewed by Carlos Garcia Campos.
3494
3495         Make minibrowser connect to the new 'permission requests' signal
3496         to allow users handle the Geolocation permission requests.
3497
3498         * MiniBrowser/gtk/BrowserWindow.c:
3499         (geolocationRequestDialogCallback): Callback for the dialog asking
3500         the user for allowing or not geolocation permission requests.
3501         (webViewDecidePermissionRequest): Launch a dialog to ask the user
3502         whether to allow or deny geolocation permission requests.
3503         (browserWindowConstructed): Connect to 'permission-request' signal.
3504
3505 2012-06-04  Chase Phillips  <cmp@google.com>
3506
3507         Make a builder group support+expect multiple loads.
3508         https://bugs.webkit.org/show_bug.cgi?id=88260
3509
3510         Change BuilderGroup to allow expecting multiple
3511         loads.  This allows merging results for a given set
3512         of builders into one group.
3513
3514         Add a test that verifies that the group count
3515         increments correctly based on successful and failed
3516         list loads.
3517
3518         Reviewed by Ojan Vafai.
3519
3520         * TestResultServer/static-dashboards/builders.js:
3521         (BuilderGroup):
3522         (BuilderGroup.prototype.setbuilder):
3523         (BuilderGroup.prototype.append):
3524         (BuilderGroup.prototype.loaded):
3525         (requestBuilderList.xhr.onload):
3526         (requestBuilderList.xhr.onerror):
3527         (onErrorLoadingBuilderList):
3528         (loadBuildersList):
3529         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3530         (test):
3531         * TestResultServer/static-dashboards/run-unittests.html:
3532
3533 2012-06-04  Ryosuke Niwa  <rniwa@webkit.org>
3534
3535         Python test fix attempt for Chromium Windows.
3536
3537         * Scripts/webkitpy/layout_tests/port/driver.py:
3538         (Driver.uri_to_test):
3539
3540 2012-06-04  Hugo Parente Lima  <hugo.lima@openbossa.org>
3541
3542         Turn LEGACY_VIEWPORT_ADAPTION USE flag into an ENABLE flag.
3543         https://bugs.webkit.org/show_bug.cgi?id=88243
3544
3545         Reviewed by Adam Barth.
3546
3547         * qmake/mkspecs/features/features.prf:
3548
3549 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
3550
3551         webkitpy.layout_tests.port.server_process_unittest.TestServerProcess.test_basic is flaky
3552         https://bugs.webkit.org/show_bug.cgi?id=88280
3553
3554         Unreviewed, build fix.
3555
3556         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
3557         (TestServerProcess.test_basic):
3558
3559 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
3560
3561         test-webkitpy is hanging under cygwin
3562         https://bugs.webkit.org/show_bug.cgi?id=88269
3563
3564         Reviewed by Ryosuke Niwa.
3565
3566         The 'multiprocessing' module doesn't work correctly under Cygwin yet,
3567         so we need to skip any tests that use it.
3568
3569         * Scripts/webkitpy/common/system/executive.py:
3570         (Executive.run_in_parallel):
3571         * Scripts/webkitpy/common/system/executive_unittest.py:
3572         (ExecutiveTest.test_run_in_parallel):
3573
3574 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
3575
3576         test-webkitpy is failing on win32 after r115054
3577         https://bugs.webkit.org/show_bug.cgi?id=88264
3578
3579         Reviewed by Ryosuke Niwa.
3580
3581         The failing http_server test was improperly suppressed (the
3582         tuple was missing a comma, and so wasn't a tuple at all, just a
3583         string) and so we were skipping *all* tests on win32. The right
3584         way to skip a single test is to disable it inside the test
3585         itself.
3586
3587         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
3588         (TestHttpServer.test_start_cmd):
3589         * Scripts/webkitpy/test/test_finder.py:
3590         (TestFinder._default_names):
3591         * Scripts/webkitpy/test/main.py:
3592         (Tester.run): Add error message if we don't find any tests to run.
3593         * Scripts/webkitpy/test/main_unittest.py:
3594             
3595
3596 2012-06-04  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
3597
3598         [GTK] Memory leaks in AccessibilityUIElementGtk.cpp
3599         https://bugs.webkit.org/show_bug.cgi?id=88215
3600
3601         Reviewed by Martin Robinson.
3602
3603         Fixed memory leaks in AccessibilityUIElement by using GOwnPtr
3604         for newly allocated strings.
3605
3606         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3607         (attributeSetToString):
3608         (AccessibilityUIElement::allAttributes):
3609
3610 2012-06-04  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
3611
3612         [GTK] Memory leaks in DumpRenderTree.cpp
3613         https://bugs.webkit.org/show_bug.cgi?id=88213
3614
3615         Reviewed by Martin Robinson.
3616
3617         Fixed memory leaks in DumpRenderTree.
3618
3619         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3620         (appendString): Accepts const gchar* as the second argument.
3621         (dumpFramesAsText): Free the string returned by g_strdup_printf().
3622         (dumpHistoryItem): Free the string returned by g_uri_parse_scheme().
3623
3624 2012-06-04  David Dorwin  <ddorwin@chromium.org>
3625
3626         Enable Chromium media player to instantiate a plugin
3627         https://bugs.webkit.org/show_bug.cgi?id=87399
3628
3629         Reviewed by Kent Tamura.
3630
3631         Adds WebHelperPlugin, an off-screen widget that contains an <object> tag.
3632
3633         * DumpRenderTree/chromium/WebViewHost.cpp:
3634         (WebViewHost::createPopupMenu):
3635
3636 2012-06-04  Mario Sanchez Prada  <msanchez@igalia.com>
3637
3638         [GTK][WK2] Implement geolocation provider for the GTK port
3639         https://bugs.webkit.org/show_bug.cgi?id=83877
3640
3641         Reviewed by Carlos Garcia Campos.
3642
3643         * gtk/generate-gtkdoc:
3644         (get_webkit2_options): Ignore WebKitGeolocationProvider files.
3645
3646 2012-06-04  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3647
3648         [EFL] Reset "WebKitTabToLinksPreferenceKey" in DumpRenderTreeChrome::resetDefaultsToConsistentValues
3649         https://bugs.webkit.org/show_bug.cgi?id=87668
3650
3651         Reviewed by Ryosuke Niwa.
3652
3653         Layout test controller "WebKitTabToLinksPreferenceKey" setting should be reset to false
3654         otherwise LayoutTests/fast/html/tab-order.html is failing as it has a link inside the test description which might 
3655         be included in focus chain (if "WebKitTabToLinksPreferenceKey" setting is set to true). 
3656
3657         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3658         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3659
3660 2012-06-04  Tomasz Morawski  <t.morawski@samsung.com>
3661
3662         [EFL] Refactor ewk_view_context_paint code.
3663         https://bugs.webkit.org/show_bug.cgi?id=85588
3664
3665         Reviewed by Hajime Morita.
3666
3667         * DumpRenderTree/efl/CMakeLists.txt: Added include directory.
3668
3669 2012-06-04  Christophe Dumez  <christophe.dumez@intel.com>
3670
3671         [EFL] Compilation warning in DumpRenderTreeView.cpp on 64-Bit
3672         https://bugs.webkit.org/show_bug.cgi?id=87869
3673
3674         Reviewed by Andreas Kling.
3675