e6c1e5ea0c2a5955e4e40ecc5bc9b65ecf10fc2f
[WebKit-https.git] / Tools / ChangeLog
1 2019-08-17  Sam Weinig  <weinig@apple.com>
2
3         Rename StringBuilder::flexibleAppend(...) to StringBuilder::append(...)
4         https://bugs.webkit.org/show_bug.cgi?id=200756
5
6         Reviewed by Darin Adler.
7
8         Update call sites for rename from StringBuilder::flexibleAppend(...) to 
9         StringBuilder::append(...).
10
11         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
12         (TestWebKitAPI::TEST):
13
14 2019-08-17  Simon Fraser  <simon.fraser@apple.com>
15
16         [iOS WK2] Scroll indicators disappear sometimes
17         https://bugs.webkit.org/show_bug.cgi?id=200791
18
19         Reviewed by Tim Horton.
20
21         Tests that test that scroll indicators survive subview replacement, and that
22         a custom view also survives subview replacement.
23
24         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
25         * TestWebKitAPI/Tests/ios/OverflowScrollViewTests.mm: Added.
26         (TestWebKitAPI::TEST):
27         * TestWebKitAPI/cocoa/TestWKWebView.h:
28         * TestWebKitAPI/cocoa/TestWKWebView.mm:
29         (-[TestWKWebView performAfterLoading:]):
30         (-[UIView wkFirstSubviewWithClass:]):
31         (-[UIView wkFirstSubviewWithBoundsSize:]):
32         * TestWebKitAPI/ios/composited.html: Added.
33         * TestWebKitAPI/ios/overflow-scroll.html: Added.
34
35 2019-08-16  John Wilander  <wilander@apple.com>
36
37         Add John Wilander as WebKit Reviewer
38         https://bugs.webkit.org/show_bug.cgi?id=200837
39
40         Unreviewed update to contributors.json to change my status to reviewer.
41         See email on reviewers mailing list for proof of granted privileges.
42
43         * Scripts/webkitpy/common/config/contributors.json:
44
45 2019-08-16  Timothy Hatcher  <timothy@apple.com>
46
47         REGRESSION (r248436): WKWebView doesn’t respect isOpaque setting in NIB.
48         https://bugs.webkit.org/show_bug.cgi?id=200802
49         rdar://problem/54357818
50
51         Reviewed by Tim Horton.
52
53         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added WKWebViewOpaque.mm.
54         * TestWebKitAPI/Tests/ios/WKWebViewOpaque.mm: Added.
55         (-[OpaqueTestWKWebView isOpaque]): Added.
56         (-[NonOpaqueTestWKWebView isOpaque]): Added.
57         (isOpaque): Added.
58         (TEST): Added WKWebView.IsOpaqueDefault, WKWebView.SetOpaqueYes, WKWebView.SetOpaqueNo, WKWebView.IsOpaqueYesSubclassOverridden,
59         WKWebView.IsOpaqueNoSubclassOverridden, WKWebView.IsOpaqueYesDecodedFromArchive, WKWebView.IsOpaqueNoDecodedFromArchive,
60         WKWebView.IsOpaqueDrawsBackgroundYesConfiguration, WKWebView.IsOpaqueDrawsBackgroundNoConfiguration.
61
62 2019-08-16  Aakash Jain  <aakash_jain@apple.com>
63
64         [ews] Add build steps for Windows Factory
65         https://bugs.webkit.org/show_bug.cgi?id=200813
66
67         Reviewed by Jonathan Bedard.
68
69         * BuildSlaveSupport/ews-build/factories.py:
70         (WindowsFactory.__init__):
71
72 2019-08-16  Aakash Jain  <aakash_jain@apple.com>
73
74         [ews] Report machine uptime in PrintConfiguration
75         https://bugs.webkit.org/show_bug.cgi?id=200812
76
77         Reviewed by Jonathan Bedard.
78
79         * BuildSlaveSupport/ews-build/steps.py:
80         (PrintConfiguration): Added uptime command.
81         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
82
83 2019-08-16  Chris Lord  <clord@igalia.com>
84
85         Add shared-mime-info to WPE WebKit jhbuild
86         https://bugs.webkit.org/show_bug.cgi?id=200768
87
88         Reviewed by Carlos Alberto Lopez Perez.
89
90         * wpe/jhbuild.modules:
91
92 2019-08-15  Yusuke Suzuki  <ysuzuki@apple.com>
93
94         [WTF] Add makeUnique<T>, which ensures T is fast-allocated, WTF_MAKE_FAST_ALLOCATED annotation part
95         https://bugs.webkit.org/show_bug.cgi?id=200620
96
97         Reviewed by Geoffrey Garen.
98
99         * DumpRenderTree/AccessibilityController.h:
100         * DumpRenderTree/GCController.h:
101         * DumpRenderTree/win/DRTDataObject.cpp:
102         * DumpRenderTree/win/DRTDataObject.h:
103         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
104         * DumpRenderTree/win/DRTDropSource.h:
105         * DumpRenderTree/win/DraggingInfo.h:
106         * DumpRenderTree/win/EditingDelegate.h:
107         * DumpRenderTree/win/EventSender.cpp:
108         * DumpRenderTree/win/FrameLoadDelegate.h:
109         * DumpRenderTree/win/HistoryDelegate.h:
110         * DumpRenderTree/win/MD5.h:
111         * DumpRenderTree/win/PolicyDelegate.h:
112         * DumpRenderTree/win/ResourceLoadDelegate.h:
113         * DumpRenderTree/win/TextInputController.h:
114         * DumpRenderTree/win/UIDelegate.cpp:
115         * DumpRenderTree/win/UIDelegate.h:
116         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
117         * TestRunnerShared/cocoa/ClassMethodSwizzler.h:
118         * TestRunnerShared/cocoa/InstanceMethodSwizzler.h:
119         * TestWebKitAPI/Counters.h:
120         * TestWebKitAPI/PlatformWebView.h:
121         * TestWebKitAPI/Tests/WTF/Expected.cpp:
122         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
123         (TestWebKitAPI::DerefObserver::ref):
124         (TestWebKitAPI::DerefObserver::deref):
125         (TestWebKitAPI::TEST):
126         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
127         (TestWebKitAPI::DerefObserver::ref):
128         (TestWebKitAPI::DerefObserver::deref):
129         (TestWebKitAPI::TEST):
130         * TestWebKitAPI/Tests/WTF/UniqueRef.cpp:
131         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
132         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
133         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
134         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h:
135         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.h:
136         * WebKitTestRunner/EventSenderProxy.h:
137         * WebKitTestRunner/GeolocationProviderMock.h:
138         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
139         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
140         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
141         * WebKitTestRunner/PlatformWebView.h:
142         * WebKitTestRunner/TestInvocation.h:
143
144 2019-08-15  Sihui Liu  <sihui_liu@apple.com>
145
146         Some improvements on web storage
147         https://bugs.webkit.org/show_bug.cgi?id=200373
148
149         Reviewed by Geoffrey Garen.
150
151         * TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm:
152         (TEST): update expectation for behavior change.
153
154         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: new SPI to synchronously flush localStorage to 
155         database file.
156         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
157         (WTR::TestRunner::syncLocalStorage):
158         * WebKitTestRunner/InjectedBundle/TestRunner.h:
159
160         * WebKitTestRunner/TestController.cpp: clear local storage between test runs to make each test isolated.
161         (WTR::TestController::resetStateToConsistentValues):
162         (WTR::StorageVoidCallbackContext::StorageVoidCallbackContext):
163         (WTR::StorageVoidCallback):
164         (WTR::TestController::clearIndexedDatabases):
165         (WTR::TestController::clearLocalStorage):
166         (WTR::TestController::syncLocalStorage):
167         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext): Deleted. Replaced
168         with StorageVoidCallbackContext for general usage.
169         (WTR::RemoveAllIndexedDatabasesCallback): Deleted. Replaced with StorageVoidCallback.
170         (WTR::TestController::ClearIndexedDatabases): Deleted. Use lowercase for consistent style.
171         * WebKitTestRunner/TestController.h:
172
173         * WebKitTestRunner/TestInvocation.cpp:
174         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle): add handler for new message 
175         SyncLocalStorage.
176
177 2019-08-15  Jonathan Bedard  <jbedard@apple.com>
178
179         results.webkit.org: Add content hook to FlaskRequestsResponse
180         https://bugs.webkit.org/show_bug.cgi?id=200721
181
182         Rubber-stamped by Aakash Jain.
183
184         * resultsdbpy/resultsdbpy/flask_support/flask_testcase.py:
185         (FlaskRequestsResponse):
186         (FlaskRequestsResponse.content): Return the encoded raw bytes value of the
187         Response, conforming to request's API.
188
189 2019-08-15  Alex Christensen  <achristensen@webkit.org>
190
191         WKUIDelegate's webView:contextMenuDidEndForElement: should be called when context menus end
192         https://bugs.webkit.org/show_bug.cgi?id=200750
193         <rdar://problem/54232261> and <rdar://problem/52355829>
194
195         Reviewed by Tim Horton.
196
197         * TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm:
198         (-[TestContextMenuUIDelegate webView:contextMenuConfigurationForElement:completionHandler:]):
199         (-[TestContextMenuUIDelegate webView:contextMenuForElement:willCommitWithAnimator:]):
200         (-[TestContextMenuUIDelegate webView:contextMenuDidEndForElement:]):
201         (contextMenuWebViewDriver):
202         (TEST):
203
204 2019-08-14  Said Abou-Hallawa  <sabouhallawa@apple.com>
205
206         [iOS](REGRESSION: r200487): WebKit.RequestActivatedElementInfoForRotatedImage fails on iOS 13
207         https://bugs.webkit.org/show_bug.cgi?id=200726
208
209         Reviewed by Simon Fraser.
210
211         To get the pixels as an array of colors, draw the image into a memory
212         context. The backing memory buffer can then be accessed to get the image
213         pixels' colors.
214
215         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
216         (TestWebKitAPI::TEST):
217
218 2019-08-14  Ryan Haddad  <ryanhaddad@apple.com>
219
220         Unreviewed, rolling out r248526.
221
222         Caused two IndexedDB perf tests to fail
223
224         Reverted changeset:
225
226         "Remove IDB-specific quota"
227         https://bugs.webkit.org/show_bug.cgi?id=196545
228         https://trac.webkit.org/changeset/248526
229
230 2019-08-14  Keith Rollin  <krollin@apple.com>
231
232         Remove support for macOS < 10.13
233         https://bugs.webkit.org/show_bug.cgi?id=200694
234         <rdar://problem/54278851>
235
236         Reviewed by Youenn Fablet.
237
238         Update conditionals that reference __MAC_OS_X_VERSION_MIN_REQUIRED and
239         __MAC_OS_X_VERSION_MAX_ALLOWED, assuming that they both have values >=
240         101300. This means that expressions like
241         "__MAC_OS_X_VERSION_MIN_REQUIRED < 101300" are always False and
242         "__MAC_OS_X_VERSION_MIN_REQUIRED >= 101300" are always True.
243
244         * MiniBrowser/AppKitCompatibilityDeclarations.h:
245         * MiniBrowser/mac/SettingsController.m:
246         (-[SettingsController init]):
247         * TestWebKitAPI/Tests/WebCore/FontCache.cpp:
248         (TestWebKitAPI::FontCacheTest::SetUp): Deleted.
249         (TestWebKitAPI::createPlatformFont): Deleted.
250         (TestWebKitAPI::compareFonts): Deleted.
251         (TestWebKitAPI::TEST_F): Deleted.
252         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm:
253         (TestWebKitAPI::TEST):
254         * TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm:
255         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
256         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
257         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
258         (runWebsiteDataStoreCustomPaths):
259         * TestWebKitAPI/mac/NSFontPanelTesting.mm:
260
261 2019-08-14  Yusuke Suzuki  <ysuzuki@apple.com>
262
263         [JSC] Less contended MetaAllocator
264         https://bugs.webkit.org/show_bug.cgi?id=200278
265
266         Reviewed by Mark Lam.
267
268         Update the interface.
269
270         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
271
272 2019-08-14  Jonathan Bedard  <jbedard@apple.com>
273
274         results.webkit.org: 500 errors on API endpoints don't return JSON
275         https://bugs.webkit.org/show_bug.cgi?id=200722
276
277         Reviewed by Aakash Jain.
278
279         * resultsdbpy/resultsdbpy/controller/api_routes.py:
280         (APIRoutes.response_500): We should return the response, instead of abort.
281
282 2019-08-14  Jonathan Bedard  <jbedard@apple.com>
283
284         results.webkit.org: Don't save configuration multiple times in upload
285         https://bugs.webkit.org/show_bug.cgi?id=200719
286
287         Reviewed by Aakash Jain.
288
289         * resultsdbpy/resultsdbpy/model/upload_context.py:
290         (UploadContext.upload_test_results): Move registering of the configuration out
291         of the branch loop.
292
293 2019-08-14  Youenn Fablet  <youenn@apple.com>
294
295         Reenable Update ContentFiltering.LazilyLoadPlatformFrameworks test for NetworkExtension
296         https://bugs.webkit.org/show_bug.cgi?id=200706
297
298         Reviewed by Alex Christensen.
299
300         Libwebrtc is now soft-linked so we can reenable this test.
301
302         * TestWebKitAPI/Tests/WebKitCocoa/ContentFiltering.mm:
303         (-[LazilyLoadPlatformFrameworksController expectParentalControlsLoaded:networkExtensionLoaded:]):
304
305 2019-08-13  Sam Weinig  <weinig@apple.com>
306
307         Rename StringBuilder::append(UChar32) to StringBuilder::appendCharacter(UChar32) to avoid accidental change in behavior when replacing append with flexibleAppend
308         https://bugs.webkit.org/show_bug.cgi?id=200675
309
310         Reviewed by Darin Adler.
311
312         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
313         (TestWebKitAPI::TEST):
314         Update for rename from StringBuilder::append(UChar32) to StringBuilder::appendCharacter(UChar32).
315
316 2019-08-13  Zhifei Fang  <zhifei_fang@apple.com>
317
318         [results.webkit.org Timeline] Performance improvement - Skip render offscreen canvas
319         https://bugs.webkit.org/show_bug.cgi?id=200456
320
321         Reviewed by Jonathan Bedard.
322
323         This patch disable use the new batch draw method to render canvas directly without any caches, this will save a lot of memory, so that we won't go into the "low memory mode".
324
325         This patch also change the axis label collision detact box from a rect to polygon, so that we can dectact click more accurate.
326
327         * resultsdbpy/resultsdbpy/view/static/library/js/Utils.js:
328         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
329         (pointPolygonCollisionDetect): Detact
330         (pointRightRayLineSegmentCollisionDetect):
331         (ColorBatchRender):
332         (ColorBatchRender.prototype.lazyCreateColorSeqs):
333         (ColorBatchRender.prototype.addSeq):
334         (ColorBatchRender.prototype.batchRender):
335         (ColorBatchRender.prototype.clear):
336         (xScrollStreamRenderFactory):
337         (Timeline.CanvasSeriesComponent):
338         (offscreenCachedRenderFactory): Deleted.
339
340 2019-08-13  John Wilander  <wilander@apple.com>
341
342         Resource Load Statistics: Switch NSURLSession on top navigation to prevalent resource with user interaction
343         https://bugs.webkit.org/show_bug.cgi?id=200642
344         <rdar://problem/53962073>
345
346         Reviewed by Alex Christensen.
347
348         This patch adds test infrastructure to query whether an origin has an
349         isolated NSURLSession or not.
350
351         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
352         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
353         (WTR::TestRunner::hasStatisticsIsolatedSession):
354         * WebKitTestRunner/InjectedBundle/TestRunner.h:
355         * WebKitTestRunner/TestController.cpp:
356         (WTR::TestController::hasStatisticsIsolatedSession):
357         * WebKitTestRunner/TestController.h:
358         * WebKitTestRunner/TestInvocation.cpp:
359         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
360
361 2019-08-13  Zhifei Fang  <zhifei_fang@apple.com>
362
363         Update my status in contributors.json to committer.
364
365         Reviewed by Unreviewed
366
367         * Scripts/webkitpy/common/config/contributors.json:
368
369 2019-08-12  Jiewen Tan  <jiewen_tan@apple.com>
370
371         Adds WebAuthn and AppSSO into watchlist
372         https://bugs.webkit.org/show_bug.cgi?id=200647
373
374         Reviewed by Dewei Zhu.
375
376         * Scripts/webkitpy/common/config/watchlist:
377
378 2019-08-13  Chris Dumez  <cdumez@apple.com>
379
380         Crash under IPC::Connection::markCurrentlyDispatchedMessageAsInvalid()
381         https://bugs.webkit.org/show_bug.cgi?id=200674
382         <rdar://problem/50692748>
383
384         Reviewed by Geoff Garen.
385
386         Add API test coverage.
387
388         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
389
390 2019-08-12  Takashi Komori  <Takashi.Komori@sony.com>
391
392         [WTF] Thread::removeFromThreadGroup leaks weak pointers.
393         https://bugs.webkit.org/show_bug.cgi?id=199857
394
395         Reviewed by Yusuke Suzuki.
396
397         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp:
398         (TestWebKitAPI::countThreadGroups):
399         (TestWebKitAPI::TEST):
400
401 2019-08-12  Alexey Shvayka  <shvaikalesh@gmail.com>
402
403         AX: Homebrew is not allowed to run any script under sudo.
404         https://bugs.webkit.org/show_bug.cgi?id=173801
405
406         Reviewed by Carlos Alberto Lopez Perez.
407
408         Latest versions of Homebrew throw an error when run as root.
409         Dependencies are successfully installed w/o `sudo` on macOS, so skip it.
410
411         * gtk/install-dependencies:
412
413 2019-08-12  Jonathan Bedard  <jbedard@apple.com>
414
415         [REGRESSION] run-webkit-tests: No PID defined when searching for simulator crashlogs
416         https://bugs.webkit.org/show_bug.cgi?id=200644
417
418         Reviewed by Aakash Jain.
419
420         * Scripts/webkitpy/port/simulator_process.py:
421         (SimulatorProcess._start): Define system PID after launching app.
422
423 2019-08-12  Sam Weinig  <weinig@apple.com>
424
425         Replace multiparameter overloads of append() in StringBuilder as a first step toward standardizinging on the flexibleAppend() implementation
426         https://bugs.webkit.org/show_bug.cgi?id=200614
427
428         Reviewed by Darin Adler.
429
430         Renames StringBuilder::append(const LChar*, unsigned), StringBuilder::append(const UChar*, unsigned) and 
431         StringBuilder::append(const char*, unsigned) to StringBuilder::appendCharacters(...).
432         
433         Renames StringBuilder::append(const String& string, unsigned offset, unsigned length) to 
434         StringBuilder::appendSubstring(...).
435
436         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
437         (TestWebKitAPI::TEST):
438         Update for renames.
439
440 2019-08-12  Megan Gardner  <megan_gardner@apple.com>
441
442         Fix Crash in Mail Search
443         https://bugs.webkit.org/show_bug.cgi?id=200589
444
445         Reviewed by Tim Horton.
446
447         If you search backwards first in mail, we would crash,
448         this tests that codepath.
449
450         * TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm:
451         (TEST):
452
453 2019-08-12  Wenson Hsieh  <wenson_hsieh@apple.com>
454
455         [iPadOS] Web pages sometimes load at half width in Safari
456         https://bugs.webkit.org/show_bug.cgi?id=200624
457         <rdar://problem/52694257>
458
459         Reviewed by Simon Fraser.
460
461         Add an API test to verify that after performing an animated resize and killing the web process, the subsequent
462         web page is created using the post-animated-resize web view dimensions, rather than the original layout
463         dimensions.
464
465         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
466
467 2019-08-12  Daniel Bates  <dabates@apple.com>
468
469         Add a test to ensure that we dispatch keydown and keyup events when multiple keys are pressed at the same time
470         https://bugs.webkit.org/show_bug.cgi?id=200548
471
472         Reviewed by Darin Adler.
473
474         Expose infrastructure to simulate a literal raw key down and a literal key up event.
475
476         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
477         * TestRunnerShared/UIScriptContext/UIScriptController.h:
478         (WTR::UIScriptController::rawKeyDown):
479         (WTR::UIScriptController::rawKeyUp):
480         * WebKitTestRunner/ios/UIScriptControllerIOS.h:
481         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
482         (WTR::UIScriptControllerIOS::rawKeyDown):
483         (WTR::UIScriptControllerIOS::rawKeyUp):
484
485 2019-08-12  Thibault Saunier  <tsaunier@igalia.com>
486
487         [GStreamer][WebRTC] Handle broken data in the libwebrtc GStreamer decoders
488         https://bugs.webkit.org/show_bug.cgi?id=200584
489
490         Reviewed by Philippe Normand.
491
492         Added a h264parse patch to post WARNING on the bus when a broken frame is detected.
493         Ignore style libwebrtc optionnal 'style issue'
494
495         * Scripts/webkitpy/style/checker.py:
496         * gstreamer/jhbuild.modules:
497         * gstreamer/patches/gst-plugins-bad-0001-h264parse-Post-a-WARNING-when-data-is-broken.patch: Added.
498
499 2019-08-12  Youenn Fablet  <youenn@apple.com>
500
501         Remove IDB-specific quota
502         https://bugs.webkit.org/show_bug.cgi?id=196545
503
504         Reviewed by Alex Christensen.
505
506         * DumpRenderTree/TestRunner.cpp:
507         (TestRunner::staticFunctions):
508         (setIDBPerOriginQuotaCallback): Deleted.
509         * DumpRenderTree/TestRunner.h:
510         * DumpRenderTree/mac/DumpRenderTree.mm:
511         (runTest):
512         * DumpRenderTree/mac/TestRunnerMac.mm:
513         (TestRunner::setIDBPerOriginQuota): Deleted.
514         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
515         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
516         (WTR::TestRunner::setIDBPerOriginQuota): Deleted.
517         * WebKitTestRunner/InjectedBundle/TestRunner.h:
518         * WebKitTestRunner/TestController.cpp:
519         (WTR::TestController::resetStateToConsistentValues):
520         (WTR::TestController::setIDBPerOriginQuota): Deleted.
521         * WebKitTestRunner/TestController.h:
522         * WebKitTestRunner/TestInvocation.cpp:
523         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
524
525 2019-08-10  Alexey Proskuryakov  <ap@apple.com>
526
527         WebKitTestRunner's InjectedBundle has too aggressive stripping, resulting in non-symbolicated crash logs
528         https://bugs.webkit.org/show_bug.cgi?id=200621
529
530         Reviewed by Dan Bernstein.
531
532         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
533
534 2019-08-09  Wenson Hsieh  <wenson_hsieh@apple.com>
535
536         KeyboardInputTests.CaretSelectionRectAfterRestoringFirstResponder API tests time out on iPad
537         https://bugs.webkit.org/show_bug.cgi?id=200604
538         <rdar://problem/51273130>
539
540         Reviewed by Megan Gardner.
541
542         Tweak some API tests so that they work on iPad simulator. These tests checked that the final caret rect was
543         {{16, 13}, {2, 15}}; however, this is only correct behavior on iPhone, where we will scale the page so that the
544         focused element's font size is legible. Note that when the page is scaled, we scale the height but not the
545         width of the caret, which is why the width of the caret (in content coordinates) decreases while the height
546         remains the same.
547
548         We don't have the same behavior on iPad, so the expected caret rect is {{16, 13}, {3, 15}}, which is equal to
549         the caret rect at initial scale 1.
550
551         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
552
553 2019-08-09  Ali Juma  <ajuma@chromium.org>
554
555         Don't allow cross-origin iframes to autofocus
556         https://bugs.webkit.org/show_bug.cgi?id=200515
557         <rdar://problem/54092988>
558
559         Reviewed by Ryosuke Niwa.
560
561         Make WebKit.FocusedFrameAfterCrash use same-origin iframes instead
562         of cross-origin iframes, since it depends on focusing one of the
563         frames.
564
565         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
566         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
567         (TestWebKitAPI::TEST):
568         * TestWebKitAPI/Tests/WebKit/many-same-origin-iframes.html: Added.
569
570 2019-08-09  Wenson Hsieh  <wenson_hsieh@apple.com>
571
572         [iOS 13] Google Docs/Slides/Sheets: paste often doesn't work and sometimes produces an error
573         https://bugs.webkit.org/show_bug.cgi?id=200591
574         <rdar://problem/54102238>
575
576         Reviewed by Ryosuke Niwa and Tim Horton.
577
578         Add a new API test to exercise -supportsImagePaste.
579
580         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
581         (TestWebKitAPI::TEST):
582         * TestWebKitAPI/ios/UIKitSPI.h:
583
584 2019-08-09  Aakash Jain  <aakash_jain@apple.com>
585
586         Follow-up commit to r248474 as webkit-patch did not commit the svn property changes.
587         [ews-build] Set svn:ignore to various EWS Buildbot files
588         https://bugs.webkit.org/show_bug.cgi?id=200581
589
590         Reviewed by Jonathan Bedard.
591
592         * BuildSlaveSupport/ews-build: Added property svn:ignore.
593
594 2019-08-09  Aakash Jain  <aakash_jain@apple.com>
595
596         [ews-build] Set svn:ignore to various EWS Buildbot files
597         https://bugs.webkit.org/show_bug.cgi?id=200581
598
599         Reviewed by Jonathan Bedard.
600
601         * BuildSlaveSupport/ews-build: Added property svn:ignore.
602
603 2019-08-09  Aakash Jain  <aakash_jain@apple.com>
604
605         [ews] Add buildbot.tac to repository
606         https://bugs.webkit.org/show_bug.cgi?id=200580
607
608         Reviewed by Jonathan Bedard.
609
610         * BuildSlaveSupport/ews-build/buildbot.tac: Added.
611
612 2019-08-09  Claudio Saavedra  <csaavedra@igalia.com>
613
614         [GTK] Add missing spellchecking packages to dependencies script
615         https://bugs.webkit.org/show_bug.cgi?id=200574
616
617         Reviewed by Philippe Normand.
618
619         These are needed for the spellchecking test in WebContext API tests.
620
621         * gtk/install-dependencies:
622
623 2019-08-08  Jon Lee  <jonlee@apple.com>
624
625         Unreviewed. Get rid of extraneous whitespace in ChangeLog.
626
627 2019-08-08  Jonathan Bedard  <jbedard@apple.com>
628
629         webkitpy: Disable shared clipboard between Simulators
630         https://bugs.webkit.org/show_bug.cgi?id=200546
631
632         Reviewed by Aakash Jain.
633
634         * Scripts/webkitpy/xcode/simulated_device.py:
635         (SimulatedDeviceManager.initialize_devices): Disable PasteboardAutomaticSync in Simulator.app
636         managed by run-webkit-tests.
637
638 2019-08-08  Brent Fulgham  <bfulgham@apple.com>
639
640         [FTW] Get WebKit, WebKit2, and MiniBrowser building and executing
641         https://bugs.webkit.org/show_bug.cgi?id=200539
642         <rdar://problem/54082550>
643
644         Reviewed by Dean Jackson.
645
646         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
647         * PlatformFTW.cmake: Added.
648
649 2019-08-08  Said Abou-Hallawa  <sabouhallawa@apple.com>
650
651         [iOS] Position image information should respect the image orientation
652         https://bugs.webkit.org/show_bug.cgi?id=200487
653
654         Reviewed by Simon Fraser.
655
656         Add an API test to verify the position image information is drawn rotated
657         because of respecting its image orientation.
658
659         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
660         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
661         (TestWebKitAPI::TEST):
662         * TestWebKitAPI/Tests/WebKitCocoa/exif-orientation-8-llo.jpg: Added.
663         * TestWebKitAPI/Tests/WebKitCocoa/img-with-rotated-image.html: Added.
664
665 2019-08-08  Claudio Saavedra  <csaavedra@igalia.com>
666
667         [GTK] Fix WebContext languages test
668         https://bugs.webkit.org/show_bug.cgi?id=200538
669
670         Reviewed by Alex Christensen.
671
672         This test broke after the format of Accepted-Languages
673         was changed in r238236, update.
674
675         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
676         (testWebContextLanguages):
677
678 2019-08-08  Claudio Saavedra  <csaavedra@igalia.com>
679
680         [GTK] Fix /webkit/WebKitWebsiteData/databases failure
681         https://bugs.webkit.org/show_bug.cgi?id=200536
682
683         Reviewed by Carlos Alberto Lopez Perez.
684
685         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
686         (testWebsiteDataDatabases): Databases take a moment to be written,
687         wait before fetching the data as it's done in other tests.
688
689 2019-08-08  Jonathan Bedard  <jbedard@apple.com>
690
691         results.webkit.org: Use canvas for timeline
692         https://bugs.webkit.org/show_bug.cgi?id=200172
693
694         Rubber-stamped by Aakash Jain.
695
696         * resultsdbpy/resultsdbpy/view/static/js/commit.js:
697         (Commit.constructor): Make uuid a member variable instead of a member function for efficiency.
698         (Commit.compare): Ditto.
699         (_CommitBank.commitByUuid): Ditto.
700         (_CommitBank._loadSiblings): Ditto.
701         (_CommitBank._load): Ditto.
702         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
703         (tickForCommit): Deleted.
704         (minimumUuidForResults): Given a dictionary of result lists, determine the minimum UUID
705         which encompasses all results. Crucially, this function must exclude an UUIDs which may
706         refer to results excluded because of the limit argument.
707         (renderTimeline): Deleted.
708         (commitsForResults): Given a dictionary of result lists, return a list of commits associated
709         with those results.
710         (scaleForCommits): Given a list of commits, generate a scale to be consumed by the canvas Timeline.
711         (repositoriesForCommits): Given a list of commits, return a sorted list of associated repository ids.
712         (xAxisFromScale): Create a canvas-based x-axis based on the provided scale and a repository id.
713         (inPlaceCombine): Combine result objects together.
714         (statsForSingleResult): Turn a single result into a stat object.
715         (combineResults): Given lists of results, combine these lists while keeping the original lists unchanged.
716         (Dot): Deleted.
717         (TimelineFromEndpoint): Renamed from Timeline.
718         (TimelineFromEndpoint.constructor): Canvas Timeline manages expansion and collapsing of nested timelines.
719         (TimelineFromEndpoint.teardown): Detach callbacks from CommitBank.
720         (TimelineFromEndpoint.update): Update with any new commit information, force a re-draw of the current
721         cache contents.
722         (TimelineFromEndpoint.reload): Remove management of nested timelines.
723         (TimelineFromEndpoint.render): Use canvas Timeline instead of html timeline to visualize results.
724         * resultsdbpy/resultsdbpy/view/templates/search.html: Use TimelineFromEndpoint class.
725         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Ditto.
726
727 2019-08-08  Brady Eidson  <beidson@apple.com>
728
729         Do not allow navigations of frames about to get replaced by the result of evaluating javascript: URLs
730         <rdar://problem/53788893> and https://bugs.webkit.org/show_bug.cgi?id=198786
731
732         Reviewed by Geoff Garen.
733
734         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
735         * TestWebKitAPI/Tests/mac/JavascriptURLNavigation.mm: Added.
736
737 2019-08-08  Rob Buis  <rbuis@igalia.com>
738
739         Add runtime flag for lazy image loading
740         https://bugs.webkit.org/show_bug.cgi?id=199794
741
742         Reviewed by Darin Adler.
743
744         Set lazyImageLoading preference as part of experimental features. Add
745         TestOption for lazy image loading.
746
747         * DumpRenderTree/TestOptions.cpp:
748         (TestOptions::TestOptions):
749         * DumpRenderTree/TestOptions.h:
750         * DumpRenderTree/mac/DumpRenderTree.mm:
751         (enableExperimentalFeatures):
752         (setWebPreferencesForTestOptions):
753         * DumpRenderTree/win/DumpRenderTree.cpp:
754         (enableExperimentalFeatures):
755
756 2019-08-08  Rob Buis  <rbuis@igalia.com>
757
758         Import lazy loading WPT tests
759         https://bugs.webkit.org/show_bug.cgi?id=199795
760
761         Reviewed by Darin Adler.
762
763         Only do loading/ exception for WebKit specific, non WPT tests.
764
765         * DumpRenderTree/mac/DumpRenderTree.mm:
766         (shouldLogFrameLoadDelegates):
767         * WebKitTestRunner/TestInvocation.cpp:
768         (WTR::TestInvocation::TestInvocation):
769
770 2019-08-07  Fujii Hironori  <Hironori.Fujii@sony.com>
771
772         [Win][MiniBrowser] Add key accelerators for reload and close window
773         https://bugs.webkit.org/show_bug.cgi?id=200497
774
775         Reviewed by Brent Fulgham.
776
777         Added short cuts Ctrl-W to close window, Ctrl-R to reload.
778
779         * MiniBrowser/win/MainWindow.cpp:
780         (MainWindow::WndProc): Added IDM_CLOSE_WINDOW case.
781         * MiniBrowser/win/MiniBrowserLib.rc: Added "Close" menu item. Added accelerators.
782         * MiniBrowser/win/MiniBrowserLibResource.h: Added IDM_CLOSE_WINDOW.
783
784 2019-08-07  Myles C. Maxfield  <mmaxfield@apple.com>
785
786         Add WHLSL and WebGPU to the watchlist file
787         https://bugs.webkit.org/show_bug.cgi?id=200509
788
789         Reviewed by Robin Morisset.
790
791         * Scripts/webkitpy/common/config/watchlist:
792
793 2019-08-07  Keith Rollin  <krollin@apple.com>
794
795         Unreviewed build fix after r248317 -- disable XCBuild because it
796         breaks incremental builds.
797
798         * Scripts/webkitdirs.pm:
799         (canUseXCBuild):
800
801 2019-08-06  Fujii Hironori  <Hironori.Fujii@sony.com>
802
803         ASSERTION FAILED: m_observers.isEmpty() if WKPageSetPageStateClient is used
804         https://bugs.webkit.org/show_bug.cgi?id=200465
805
806         Reviewed by Alex Christensen.
807
808         * TestWebKitAPI/Tests/WebKit/PageLoadState.cpp:
809         (TestWebKitAPI::WebKit.PageLoadState): Set PageStateClient before
810         finishing the test.
811         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
812         (TestWebKitAPI::PlatformWebView::~PlatformWebView): Release m_view.
813
814 2019-08-06  Jiewen Tan  <jiewen_tan@apple.com>
815
816         Unreviewed, a build fix after r248308
817
818         Don't use WK_ENGINEERING_CODE_SIGN_IDENTITY for Production build.
819
820         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
821
822 2019-08-06  Jiewen Tan  <jiewen_tan@apple.com>
823
824         Unreviewed, a build fix after r248319
825
826         Use HAVE(DATA_PROTECTION_KEYCHAIN) instead of HAVE_DATA_PROTECTION_KEYCHAIN.
827
828         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
829         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
830         (WTR::TestController::addTestKeyToKeychain):
831         (WTR::TestController::cleanUpKeychain):
832         (WTR::TestController::keyExistsInKeychain):
833
834 2019-08-06  Jiewen Tan  <jiewen_tan@apple.com>
835
836         Unreviewed, a build fix after r248308
837
838         Use kSecUseDataProtectionKeychain for iOS 13 and macOS Catalina or newer.
839
840         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
841         (WTR::TestController::addTestKeyToKeychain):
842         (WTR::TestController::cleanUpKeychain):
843         (WTR::TestController::keyExistsInKeychain):
844
845 2019-08-06  Keith Rollin  <krollin@apple.com>
846
847         Enable XCBuild for `make` and `build-webkit` builds
848         https://bugs.webkit.org/show_bug.cgi?id=200476
849         <rdar://problem/50771065>
850
851         Reviewed by Jonathan Bedard.
852
853         All projects have now been tested under XCBuild and successfully
854         build. Enable the use of XCBuild when performing builds with `make` or
855         `build-webkit` and when using a sufficient version of Xcode. We set
856         this version to Xcode 11 since Xcode 10 -- even though it supports
857         XCBuild -- does not support a build facility needed to build WebKit
858         (Bug 197072, Bug 197116, Bug 197340).
859
860         Do not enable XCBuild in the Xcode projects themselves since these
861         projects may need to be used under older versions of Xcode and there's
862         no way to make those project changes sensitive to the version of Xcode
863         being used. This means that builds performed in the Xcode IDE will not
864         use XCBuild.
865
866         * Scripts/webkitdirs.pm:
867         (canUseXCBuild):
868
869 2019-08-06  Chris Dumez  <cdumez@apple.com>
870
871         Fix inefficiency in HTTPHeaderMap::set(CFStringRef, const String&)
872         https://bugs.webkit.org/show_bug.cgi?id=200475
873
874         Reviewed by Darin Adler.
875
876         * TestWebKitAPI/Tests/WTF/StringView.cpp:
877         (TestWebKitAPI::stringViewFromLiteral):
878         (TestWebKitAPI::stringViewFromUTF8):
879
880 2019-08-06  Carlos Alberto Lopez Perez  <clopez@igalia.com>
881
882         Update my status in contributors.json to reviewer.
883
884         Regained the status after following the procedure for inactive contributors.
885         See r247136 for further explanation.
886
887         * Scripts/webkitpy/common/config/contributors.json:
888
889 2019-08-06  Jiewen Tan  <jiewen_tan@apple.com>
890
891         [WebAuthN] Enable LocalAuthenticator for macOS
892         https://bugs.webkit.org/show_bug.cgi?id=182772
893         <rdar://problem/43347920>
894
895         Reviewed by Brent Fulgham.
896
897         Add an entitlement file to WebKitTestRunner such that it can access
898         the modern macOS keychain.
899
900         * WebKitTestRunner/Configurations/WebKitTestRunner.entitlements: Added.
901         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
902         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
903         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
904         (WTR::TestController::addTestKeyToKeychain):
905         (WTR::TestController::cleanUpKeychain):
906         (WTR::TestController::keyExistsInKeychain):
907
908 2019-08-06  Zhifei Fang  <zhifei_fang@apple.com>
909
910         [results.webkit.org Timeline] Performance improvements
911         https://bugs.webkit.org/show_bug.cgi?id=200406
912
913         Reviewed by Jonathan Bedard.
914
915         1. Unhook the scroll event when a series/axis have been removed from the container
916         2. Fix the axis's cache data structure out of sync.
917         3. Use position:sticky to reduce the scrolling blink when update the presenter's transform
918         4. Use intersection observer to detect if the canvas on screen or not, if a canvas is not on the screen, we do nothing, this will eliminate render requests we send out.
919
920
921         * resultsdbpy/resultsdbpy/view/static/library/js/Ref.js:
922         (Signal.prototype.removeListener):
923         (prototype.stopAction): Unregsiter an action handler
924         (Ref):
925         (Ref.prototype.apply):
926         (Ref.prototype.destory):
927         * resultsdbpy/resultsdbpy/view/static/library/js/components/BaseComponents.js:
928         (ApplyNewChildren):
929         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
930         (Timeline.CanvasSeriesComponent):
931
932 2019-08-06  Jer Noble  <jer.noble@apple.com>
933
934         Add test for behavior introduced in r248174
935         https://bugs.webkit.org/show_bug.cgi?id=200446
936
937         Reviewed by Eric Carlson.
938
939         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
940         * TestWebKitAPI/Tests/ios/FullscreenTouchSecheuristicTests.cpp: Added.
941         (WebKit::configureSecheuristic):
942         (WebKit::TEST):
943
944 2019-08-05  Fujii Hironori  <Hironori.Fujii@sony.com>
945
946         [MiniBrowser][WK2] Unhandled key events should be bubbled up to the parent window
947         https://bugs.webkit.org/show_bug.cgi?id=200464
948
949         Reviewed by Ross Kirsling.
950
951         When WK2 WebView is focused, short cut keys (e.g. Alt-F to open File
952         menu, Alt-F4 to close window, and etc) don't work.
953
954         WK1 WebView doesn't have this issue because it processes key events
955         properly.
956
957         * MiniBrowser/win/WebKitBrowserWindow.cpp:
958         (WebKitBrowserWindow::WebKitBrowserWindow):
959         (WebKitBrowserWindow::didNotHandleKeyEvent): Added. Send the
960         unhandled key events to the main window.
961         * MiniBrowser/win/WebKitBrowserWindow.h:
962
963 2019-08-05  Simon Fraser  <simon.fraser@apple.com>
964
965         iOS 13: Overflow:hidden on body prevents PDF scroll
966         https://bugs.webkit.org/show_bug.cgi?id=200435
967         rdar://problem/53942888
968
969         Reviewed by Tim Horton.
970
971         When we navigate from an overflow:hidden HTML page to a custom view (like PDF), we need
972         to make sure that the scroll view is scrollable.
973
974         * TestWebKitAPI/Tests/ios/ScrollViewScrollabilityTests.mm:
975         (TestWebKitAPI::TEST):
976
977 2019-08-05  Aakash Jain  <aakash_jain@apple.com>
978
979         New EWS:mac-wk2 status-bubble shows waiting to run tests for all recent bugs
980         https://bugs.webkit.org/show_bug.cgi?id=200400
981
982         Reviewed by Jonathan Bedard.
983
984         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
985         (StatusBubble._build_bubble):
986         (StatusBubble._queue_position):
987
988 2019-08-05  Jonathan Bedard  <jbedard@apple.com>
989
990         run-webkit-tests asserts when the iPhone XR simulator is running
991         https://bugs.webkit.org/show_bug.cgi?id=200404
992         <rdar://problem/53878739>
993
994         Reviewed by Dean Jackson.
995
996         Support unicode in all logging statements tied to device model.
997
998         * Scripts/webkitpy/layout_tests/controllers/manager.py:
999         (Manager.run):
1000         * Scripts/webkitpy/layout_tests/views/printing.py:
1001         (Printer.print_baseline_search_path):
1002         * Scripts/webkitpy/port/device.py:
1003         (Device.__repr__):
1004         * Scripts/webkitpy/port/device_port.py:
1005         (DevicePort._install):
1006         (DevicePort.setup_test_run):
1007         (DevicePort.clean_up_test_run):
1008         (DevicePort.configuration_for_upload):
1009         * Scripts/webkitpy/port/ios.py:
1010         (IOSPort.default_baseline_search_path):
1011         * Scripts/webkitpy/xcode/device_type.py:
1012         (DeviceType.__str__):
1013         * Scripts/webkitpy/xcode/simulated_device.py:
1014         (SimulatedDeviceManager.populate_available_devices):
1015         (SimulatedDeviceManager._find_available_name):
1016         (SimulatedDeviceManager._get_device_identifier_for_type):
1017         (SimulatedDeviceManager._create_or_find_device_for_request):
1018         (SimulatedDeviceManager._does_fulfill_request):
1019         (SimulatedDeviceManager._wait_until_device_in_state):
1020         (SimulatedDeviceManager._wait_until_device_is_usable):
1021         (SimulatedDeviceManager._boot_device):
1022         (SimulatedDeviceManager.initialize_devices):
1023         (SimulatedDeviceManager.max_supported_simulators):
1024         (SimulatedDeviceManager.swap):
1025         (SimulatedDevice.is_usable):
1026         (SimulatedDevice._shut_down):
1027         (SimulatedDevice._delete):
1028         (SimulatedDevice.launch_app):
1029         (SimulatedDevice.__repr__):
1030
1031 2019-08-04  Chris Dumez  <cdumez@apple.com>
1032
1033         Ping loads should not prevent page caching
1034         https://bugs.webkit.org/show_bug.cgi?id=200418
1035         <rdar://problem/53901632>
1036
1037         Reviewed by Darin Adler.
1038
1039         Add TestOption to enable PageCache at UIProcess-level so that we can test
1040         page caching when navigating cross-origin with PSON enabled.
1041
1042         * WebKitTestRunner/TestController.cpp:
1043         (WTR::TestController::resetPreferencesToConsistentValues):
1044         (WTR::updateTestOptionsFromTestHeader):
1045         * WebKitTestRunner/TestOptions.h:
1046         (WTR::TestOptions::hasSameInitializationOptions const):
1047
1048 2019-08-02  Keith Rollin  <krollin@apple.com>
1049
1050         Consistently use Obj-C boolean literals
1051         https://bugs.webkit.org/show_bug.cgi?id=200405
1052         <rdar://problem/53880043>
1053
1054         Reviewed by Simon Fraser, Joseph Pecoraro.
1055
1056         There are places where we use equivalent but different expressions for
1057         Obj-C boolean objects. For example, we use both [NSNumber
1058         numberWithBool:YES] and @YES. There are places where both are used in
1059         the same function, such as -[WebPreferences initialize]. The boolean
1060         literal is in greater use and is more succinct, so standardize on
1061         that. Also, change @(YES/NO) to @YES/NO.
1062
1063         * DumpRenderTree/mac/ObjCController.m:
1064         (-[ObjCController objectOfClass:]):
1065         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegate.mm:
1066         (TEST):
1067         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
1068         (overrideAddObserverForName):
1069         * TestWebKitAPI/ios/mainIOS.mm:
1070         (main):
1071         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
1072         (TestWebKitAPI::InjectedBundleController::platformInitialize):
1073         * TestWebKitAPI/mac/mainMac.mm:
1074         (main):
1075         * WebKitLauncher/WebKitNightlyEnabler.m:
1076         (enableWebKitNightlyBehaviour):
1077
1078 2019-08-02  Wenson Hsieh  <wenson_hsieh@apple.com>
1079
1080         TextAutosizingBoost.ChangeAutosizingBoostAtRuntime fails on iPad Simulator
1081         https://bugs.webkit.org/show_bug.cgi?id=200402
1082         <rdar://problem/53823368>
1083
1084         Reviewed by Tim Horton.
1085
1086         Make it possible to run this test using the iPad simulator.
1087
1088         * TestWebKitAPI/Tests/ios/TextAutosizingBoost.mm:
1089
1090         Two adjustments: (1) override the screen size to be 320 by 568 (so that the legacy text autosizing heuristic
1091         doesn't avoid boosting this text), and (2) force text autosizing on, but disable idempotent text autosizing,
1092         since this would result in differently sized text.
1093
1094         (mainScreenReferenceBoundsOverride):
1095         * TestWebKitAPI/ios/UIKitSPI.h:
1096
1097 2019-08-02  Sihui Liu  <sihui_liu@apple.com>
1098
1099         API tests using permanent credentials should clear credentials left by previous tests
1100         https://bugs.webkit.org/show_bug.cgi?id=199729
1101
1102         Reviewed by Alex Christensen.
1103
1104         We used to clear the permanent credentials created by API tests at the end of the API tests, to ensure those
1105         credentials will not affect tests running after. There is a case where permanent credentials were left on the
1106         system, so those API tests were timing out themselves before reaching to the cleanup, which caused cascading
1107         failure. To prevent this from happening again, add cleanup at the begining of the tests.
1108
1109         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1110         (TEST):
1111         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
1112         (TestWebKitAPI::TEST):
1113
1114 2019-08-02  Andres Gonzalez  <andresg_22@apple.com>
1115
1116         Add accessibility object method to determine whether an element is inside a table cell. Needed for iOS accessibility client.
1117         https://bugs.webkit.org/show_bug.cgi?id=200394
1118         <rdar://problem/52914964>
1119
1120         Reviewed by Chris Fleizach.
1121
1122         Glue code to exercise new method [WebAccessibilityObjectWrapper _accessibilityIsInTableCell].
1123
1124         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1125         (WTR::AccessibilityUIElement::isInTableCell const):
1126         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1127         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1128         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1129         (WTR::AccessibilityUIElement::isInTableCell const):
1130
1131 2019-08-02  Zhifei Fang  <zhifei_fang@apple.com>
1132
1133         [results.webkit.org Timeline] Using transform matrix to calculate the tag rotation position
1134         https://bugs.webkit.org/show_bug.cgi?id=200397
1135
1136         Reviewed by Jonathan Bedard.
1137
1138         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
1139
1140 2019-08-02  Wenson Hsieh  <wenson_hsieh@apple.com>
1141
1142         [macOS 10.15] Image dragged from Safari does not appear in Notes
1143         https://bugs.webkit.org/show_bug.cgi?id=188490
1144         <rdar://problem/39462717>
1145
1146         Reviewed by Andy Estes.
1147
1148         Add a test to verify that promised image data can be delivered to multiple pasteboards when performing a drop.
1149
1150         * TestWebKitAPI/Tests/mac/DragAndDropTestsMac.mm:
1151
1152 2019-08-02  Alex Christensen  <achristensen@webkit.org>
1153
1154         Fix API test after r248139
1155         https://bugs.webkit.org/show_bug.cgi?id=200102
1156
1157         * TestWebKitAPI/Tests/WebKitCocoa/AdditionalReadAccessAllowedURLsPlugin.mm:
1158         (-[AdditionalReadAccessAllowedURLsPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1159         This was supposed to be removed as part of reverting r245322.
1160
1161 2019-08-01  Zhifei Fang  <zhifei_fang@apple.com>
1162
1163         results.webkit.org: Force update cache when timeline updated
1164         https://bugs.webkit.org/show_bug.cgi?id=200363
1165
1166         Reviewed by Jonathan Bedard.
1167
1168         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
1169         (offscreenCachedRenderFactory): Add ability to force the redraw.
1170         (Timeline.CanvasSeriesComponent): Force redraw when scales or dots are updated.
1171         (Timeline.CanvasXAxisComponent): Force redraw when scales are updated. Add missing exporter for export scales update API
1172
1173 2019-08-01  Alex Christensen  <achristensen@webkit.org>
1174
1175         Do not send NetworkProcessProxy::LogTestingEvent message if we are not testing
1176         https://bugs.webkit.org/show_bug.cgi?id=200360
1177
1178         Reviewed by Tim Horton.
1179
1180         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1181         (cleanupITPDatabase):
1182         (TEST):
1183
1184 2019-08-01  Alex Christensen  <achristensen@webkit.org>
1185
1186         Move FormData zip file generation to NetworkProcess and enable it for all WebKit clients for uploading directories
1187         https://bugs.webkit.org/show_bug.cgi?id=200102
1188         <rdar://problem/53275114>
1189
1190         Reviewed by Darin Adler.
1191
1192         Add an API test that is Mac-only right now because runOpenPanelWithParameters is only supported on Mac for some reason
1193         and because clicking on a TestWKWebView only works on Mac.
1194
1195         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1196         * TestWebKitAPI/Tests/WebKitCocoa/UploadDirectory.mm: Added.
1197         (-[UploadDelegate initWithDirectory:]):
1198         (-[UploadDelegate webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
1199         (-[UploadDelegate sentDirectory]):
1200         (TEST):
1201         * TestWebKitAPI/cocoa/TestWKWebView.h:
1202         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1203         (-[TestWKWebView sendClickAtPoint:]):
1204
1205 2019-08-01  Zhifei Fang  <zhifei_fang@apple.com>
1206
1207         [results.webkit.org] Timeline.CanvasXAxisComponent height should be defined by option
1208         https://bugs.webkit.org/show_bug.cgi?id=200321
1209
1210         Reviewed by Jonathan Bedard.
1211
1212         *resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
1213         Let the axis' height be defined in the option. Timeine component will use this value as
1214         padding-top for headers which allows headers start in the right position, even with multiple
1215         top axises.
1216         (Timeline.CanvasSeriesComponent):
1217         (prototype.Timeline.CanvasContainer):
1218
1219 2019-08-01  Zhifei Fang  <zhifei_fang@apple.com>
1220
1221         results.webkit.org: Collision detection for dots is off by 2 * dotMargin
1222         https://bugs.webkit.org/show_bug.cgi?id=200347
1223
1224         Reviewed by Jonathan Bedard.
1225
1226         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
1227         (Timeline.CanvasSeriesComponent): Need to change it to dotMargin + radius other than use a fixed 3 * radius, which is for the old wide timeline
1228
1229 2019-08-01  Jiewen Tan  <jiewen_tan@apple.com>
1230
1231         Improve flakiness of SOAuthorizationRedirect tests
1232         https://bugs.webkit.org/show_bug.cgi?id=200320
1233         <rdar://problem/53767057>
1234
1235         Reviewed by Alex Christensen.
1236
1237         This patch replaces Util::sleep(0.5) in tests that expect a SOAuthorization session to wait when the corresponding WKWebView
1238         is out of the window with a more precise boolean indicator: navigationPolicyDecided. The new boolean indicator is working and
1239         better because the authorizationPerformed should be set in the same runloop when NavigationState::decidePolicyForNavigationAction
1240         is executed.
1241
1242         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
1243         (-[TestSOAuthorizationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1244         (resetState):
1245         (TestWebKitAPI::TEST):
1246
1247 2019-08-01  Keith Rollin  <krollin@apple.com>
1248
1249         Update TestWebKitAPI for XCBuild
1250         https://bugs.webkit.org/show_bug.cgi?id=200311
1251         <rdar://problem/53773804>
1252
1253         Reviewed by Alex Christensen.
1254
1255         Bug 199728 (svn 247402) updated TestWebKitAPI to use the unified-build
1256         technique. Now update WebKitLegacy to build under XCBuild after those
1257         changes. This work involves adding an "Apply Configuration to
1258         XCFileLists" build target, adding a check-xcfilelists.sh script,
1259         adding a "Check xcfilelists" build phase that calls that script,
1260         adding knowledge of the project to the generate-xcfilelists script,
1261         creating new .xcfilelist files, and adding those to the project.
1262
1263         * Scripts/webkitpy/generate_xcfilelists_lib/application.py:
1264         (Application.__init__):
1265         * Scripts/webkitpy/generate_xcfilelists_lib/generators.py:
1266         (WebKitTestRunnerGenerator._get_generate_derived_sources_script):
1267         (TestWebKitAPIGenerator):
1268         (TestWebKitAPIGenerator._get_project_file_path):
1269         (TestWebKitAPIGenerator._get_generate_unified_sources_script):
1270         * TestWebKitAPI/Scripts/check-xcfilelists.sh: Added.
1271         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1272         * TestWebKitAPI/UnifiedSources-output.xcfilelist: Added.
1273
1274 2019-08-01  Youenn Fablet  <youenn@apple.com>
1275
1276         UserMediaPermissionRequestManagerProxy should not use audio+video denied requests to deny audio-only or video-only requests
1277         https://bugs.webkit.org/show_bug.cgi?id=200317
1278
1279         Reviewed by Eric Carlson.
1280
1281         * TestWebKitAPI/Tests/WebKit/getUserMediaAudioVideoCapture.html: Added
1282         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1283         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
1284         (-[GetUserMediaOnlyAudioUIDelegate _webView:requestMediaCaptureAuthorization:decisionHandler:]):
1285         (-[GetUserMediaOnlyAudioUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
1286         (TestWebKitAPI::TEST):
1287
1288 2019-08-01  Aakash Jain  <aakash_jain@apple.com>
1289
1290         New EWS: Cannot see build status page when patch is waiting for tester
1291         https://bugs.webkit.org/show_bug.cgi?id=200333
1292
1293         Reviewed by Jonathan Bedard.
1294
1295         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1296         (StatusBubble): While patch hasn't started processing on tester queue, display build information from builder queue.
1297
1298 2019-08-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1299
1300         [SOUP] Switch to use libsoup WebSockets API
1301         https://bugs.webkit.org/show_bug.cgi?id=200162
1302
1303         Reviewed by Michael Catanzaro.
1304
1305         Update libsoup version to 2.67.90.
1306
1307         * gtk/jhbuild.modules:
1308         * wpe/jhbuild.modules:
1309
1310 2019-07-31  Andy Estes  <aestes@apple.com>
1311
1312         REGRESSION (r240942): first visually non-empty layout milestone is not reached in media documents until after the video finishes loading
1313         https://bugs.webkit.org/show_bug.cgi?id=200293
1314         <rdar://problem/52937749>
1315
1316         Reviewed by Alex Christensen.
1317
1318         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1319         * TestWebKitAPI/Tests/WebKitCocoa/FirstVisuallyNonEmptyMilestone.mm: Renamed from Tools/TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm.
1320         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
1321         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
1322         (-[RenderingProgressNavigationDelegate webView:didFinishNavigation:]):
1323         (TEST):
1324
1325 2019-07-31  Aakash Jain  <aakash_jain@apple.com>
1326
1327         [ews-build] Enable all macOS queues on new EWS
1328         https://bugs.webkit.org/show_bug.cgi?id=199944
1329
1330         Reviewed by Jonathan Bedard.
1331
1332         * BuildSlaveSupport/ews-build/config.json: Enabled the triggers for macOS queues.
1333         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1334         (StatusBubble): Enabled status-bubbles for mac queues, separated builders and testers bubbles in separate lines. Also
1335         removed mac-32bit and mac-32bit-wk2 bubbles, these queues were removed from Buildbot configuration previously.
1336         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js: Removed mac queues from bot-watcher's dashboard.
1337         * QueueStatusServer/config/queues.py: Removed mac queues from old EWS.
1338
1339 2019-07-31  Ryan Haddad  <ryanhaddad@apple.com>
1340
1341         Unreviewed test gardening, disable failing test for rdar://51752593.
1342
1343         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1344
1345 2019-07-31  Jonathan Bedard  <jbedard@apple.com>
1346
1347         results.webkit.og: Timeline in canvas painting with wrong colors, cannot customize scale
1348         https://bugs.webkit.org/show_bug.cgi?id=200318
1349
1350         Reviewed by Aakash Jain.
1351
1352         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
1353         (Timeline.CanvasSeriesComponent): Reset draw context between dots.
1354         (Timeline.CanvasXAxisComponent): Use getLabel function.
1355
1356 2019-07-31  Loïc Yhuel  <loic.yhuel@softathome.com>
1357
1358         [GTK][WPE] Fix gtkdoc build with "build-webkit --32-bit" on 64-bit hosts
1359         https://bugs.webkit.org/show_bug.cgi?id=200306
1360
1361         Reviewed by Michael Catanzaro.
1362
1363         gtkdoc-scangobj calls scangobj.py, which only uses LDFLAGS on link (when producing
1364         jsc-glib-4.0-scan for example).
1365
1366         * Scripts/webkitdirs.pm:
1367         (generateBuildSystemFromCMakeProject):
1368
1369 2019-07-31  Ryan Haddad  <ryanhaddad@apple.com>
1370
1371         Unreviewed test gardening, disable failing test for rdar://52355829.
1372
1373         * TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm:
1374         (TEST):
1375
1376 2019-07-31  Keith Rollin  <krollin@apple.com>
1377
1378         Update WebKitLegacy for XCBuild
1379         https://bugs.webkit.org/show_bug.cgi?id=200310
1380         <rdar://problem/53773708>
1381
1382         Reviewed by Alex Christensen.
1383
1384         Bug 199771 (svn r247570) updated WebKitLegacy to use the unified-build
1385         technique. Now update WebKitLegacy to build under XCBuild after those
1386         changes. This work involves adding an "Apply Configuration to
1387         XCFileLists" build target, adding a check-xcfilelists.sh script,
1388         adding a "Check xcfilelists" build phase that calls that script,
1389         adding knowledge of the project to the generate-xcfilelists script,
1390         creating new .xcfilelist files, and adding those to the project.
1391
1392         * Scripts/webkitpy/generate_xcfilelists_lib/application.py:
1393         (Application.__init__):
1394         * Scripts/webkitpy/generate_xcfilelists_lib/generators.py:
1395         (JavaScriptCoreGenerator):
1396         (WebCoreGenerator):
1397         (WebKitGenerator):
1398         (WebKitGenerator._get_generate_unified_sources_script):
1399         (WebKitLegacyGenerator):
1400         (WebKitLegacyGenerator._get_project_file_path):
1401         (WebKitLegacyGenerator._get_generate_unified_sources_script):
1402
1403 2019-07-31  Chris Dumez  <cdumez@apple.com>
1404
1405         REGRESSION (r247486?): Flaky API Test TestWebKitAPI.WKWebView.LocalStorageProcessSuspends
1406         https://bugs.webkit.org/show_bug.cgi?id=200086
1407         <rdar://problem/53501721>
1408
1409         Reviewed by Alex Christensen.
1410
1411         re-enable the API test.
1412
1413         * TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm:
1414         (TEST):
1415
1416 2019-07-31  Wenson Hsieh  <wenson_hsieh@apple.com>
1417
1418         [iOS 13] Safari crashes when closing a tab with a focused element if the unified field has focus
1419         https://bugs.webkit.org/show_bug.cgi?id=200291
1420         <rdar://problem/53717946>
1421
1422         Reviewed by Megan Gardner.
1423
1424         Add an API test to exercise the scenario of synchronously requesting the autocorrection context immediately
1425         after closing the web view, while the web view's content view isn't the first responder.
1426
1427         * TestWebKitAPI/Tests/ios/AutocorrectionTestsIOS.mm:
1428         * TestWebKitAPI/ios/UIKitSPI.h:
1429
1430 2019-07-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1431
1432         [GTK] Datalist element support for TextFieldInputType
1433         https://bugs.webkit.org/show_bug.cgi?id=98934
1434
1435         Reviewed by Michael Catanzaro.
1436
1437         Implement UIScriptControllerGtk::isShowingDataListSuggestions.
1438
1439         * WebKitTestRunner/gtk/UIScriptControllerGtk.cpp:
1440         (WTR::UIScriptControllerGtk::isShowingDataListSuggestions const):
1441         * WebKitTestRunner/gtk/UIScriptControllerGtk.h:
1442
1443 2019-07-30  Tim Horton  <timothy_horton@apple.com>
1444
1445         Remove some needless comments that snuck into the tree
1446
1447         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1448         (WTR::UIScriptController::setHardwareKeyboardAttached):
1449         (WTR::UIScriptController::playBackEventStream):
1450
1451 2019-07-30  Fujii Hironori  <Hironori.Fujii@sony.com>
1452
1453         [WebKit] Add PageLoadState::Observer C API
1454         https://bugs.webkit.org/show_bug.cgi?id=199848
1455
1456         Reviewed by Alex Christensen.
1457
1458         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1459         (WebKitBrowserWindow::WebKitBrowserWindow):
1460         (WebKitBrowserWindow::didChangeTitle):
1461         (WebKitBrowserWindow::didFinishNavigation): Deleted.
1462         * MiniBrowser/win/WebKitBrowserWindow.h:
1463         * TestWebKitAPI/CMakeLists.txt:
1464         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1465         * TestWebKitAPI/Tests/WebKit/PageLoadState.cpp: Added.
1466         (TestWebKitAPI::PageLoadTestState::PageLoadTestState):
1467         (TestWebKitAPI::didChangeActiveURL):
1468         (TestWebKitAPI::didChangeCanGoBack):
1469         (TestWebKitAPI::didChangeCanGoForward):
1470         (TestWebKitAPI::didChangeCertificateInfo):
1471         (TestWebKitAPI::didChangeEstimatedProgress):
1472         (TestWebKitAPI::didChangeHasOnlySecureContent):
1473         (TestWebKitAPI::didChangeIsLoading):
1474         (TestWebKitAPI::didChangeNetworkRequestsInProgress):
1475         (TestWebKitAPI::didChangeTitle):
1476         (TestWebKitAPI::didChangeWebProcessIsResponsive):
1477         (TestWebKitAPI::didSwapWebProcesses):
1478         (TestWebKitAPI::willChangeActiveURL):
1479         (TestWebKitAPI::willChangeCanGoBack):
1480         (TestWebKitAPI::willChangeCanGoForward):
1481         (TestWebKitAPI::willChangeCertificateInfo):
1482         (TestWebKitAPI::willChangeEstimatedProgress):
1483         (TestWebKitAPI::willChangeHasOnlySecureContent):
1484         (TestWebKitAPI::willChangeIsLoading):
1485         (TestWebKitAPI::willChangeNetworkRequestsInProgress):
1486         (TestWebKitAPI::willChangeTitle):
1487         (TestWebKitAPI::willChangeWebProcessIsResponsive):
1488         (TestWebKitAPI::didFinishNavigation):
1489         (TestWebKitAPI::TEST):
1490
1491 2019-07-30  Jonathan Bedard  <jbedard@apple.com>
1492
1493         DumpRenderTree.app: Add CFBundleShortVersionString
1494         https://bugs.webkit.org/show_bug.cgi?id=200269
1495         <rdar://problem/53412596>
1496
1497         Rubber-stamped by Aakash Jain.
1498
1499         * DumpRenderTree/ios/Info.plist:
1500
1501 2019-07-29  Wenson Hsieh  <wenson_hsieh@apple.com>
1502
1503         Add layout test coverage for <https://webkit.org/b/200215>
1504         https://bugs.webkit.org/show_bug.cgi?id=200245
1505         <rdar://problem/52976965>
1506
1507         Reviewed by Tim Horton.
1508
1509         Add new testing infrastructure. See below for more details.
1510
1511         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1512         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
1513         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1514         (WTR::UIScriptController::setWillCreateNewPageCallback):
1515         (WTR::UIScriptController::willCreateNewPageCallback const):
1516
1517         Add platform-agnostic UIScriptController callback hooks to notify a test when a new page is being created. The
1518         new test in this patch uses this opportunity to remove and reinsert the web view into the window's hierarchy.
1519
1520         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1521         (WTR::UIScriptController::becomeFirstResponder):
1522
1523         Add and implement a Cocoa platform hook to make the web view first responder.
1524
1525         * WebKitTestRunner/TestController.cpp:
1526         (WTR::TestController::createOtherPage):
1527         * WebKitTestRunner/TestInvocation.cpp:
1528         (WTR::TestInvocation::willCreateNewPage):
1529         * WebKitTestRunner/TestInvocation.h:
1530         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.h:
1531         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.mm:
1532         (WTR::UIScriptControllerCocoa::becomeFirstResponder):
1533
1534 2019-07-29  Fujii Hironori  <Hironori.Fujii@sony.com>
1535
1536         [Win][MiniBrowser] Add 'reload' menu item and 'reload' toolbar button
1537         https://bugs.webkit.org/show_bug.cgi?id=200217
1538
1539         Reviewed by Alex Christensen.
1540
1541         * MiniBrowser/win/BrowserWindow.h:
1542         * MiniBrowser/win/MainWindow.cpp:
1543         (MainWindow::init):
1544         (MainWindow::resizeSubViews):
1545         (MainWindow::WndProc):
1546         * MiniBrowser/win/MainWindow.h: Added m_hReloadButtonWnd.
1547         * MiniBrowser/win/MiniBrowserLib.rc:
1548         * MiniBrowser/win/MiniBrowserLibResource.h: Added IDM_RELOAD.
1549         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1550         (WebKitBrowserWindow::reload):
1551         * MiniBrowser/win/WebKitBrowserWindow.h: Added reload() interface.
1552         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
1553         (WebKitLegacyBrowserWindow::reload):
1554         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
1555
1556 2019-07-29  Fujii Hironori  <Hironori.Fujii@sony.com>
1557
1558         [Win][MiniBrowser][WK2] Automatically supplement "file://" or "http://" for an input URL as well as WK1 browser window
1559         https://bugs.webkit.org/show_bug.cgi?id=200218
1560
1561         Reviewed by Alex Christensen.
1562
1563         Moved the scheme supplementing logic from
1564         WebKitLegacyBrowserWindow::loadURL to MainWindow::loadURL.
1565
1566         * MiniBrowser/win/MainWindow.cpp:
1567         (MainWindow::loadURL):
1568         (MainWindow::onURLBarEnter):
1569         * MiniBrowser/win/MainWindow.h:
1570         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
1571         (WebKitLegacyBrowserWindow::loadURL):
1572
1573 2019-07-29  Aakash Jain  <aakash_jain@apple.com>
1574
1575         Disable Flaky API Test TestWebKitAPI.WKWebView.LocalStorageProcessSuspends
1576         https://bugs.webkit.org/show_bug.cgi?id=200254
1577
1578         Unreviewed infrastructure fix.
1579
1580         * TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm: Disabled the test.
1581
1582 2019-07-29  Zhifei Fang  <zhifei_fang@apple.com>
1583
1584         [Canvas Timeline] Compact canvas timeline
1585         https://bugs.webkit.org/show_bug.cgi?id=200177
1586
1587         Reviewed by Jonathan Bedard.
1588
1589         * resultsdbpy/resultsdbpy/view/static/library/js/components/BaseComponents.js:
1590         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
1591         (Timeline.CanvasSeriesComponent):
1592
1593 2019-07-29  Carlos Garcia Campos  <cgarcia@igalia.com>
1594
1595         Multiple context menu actions broken for YouTube videos
1596         https://bugs.webkit.org/show_bug.cgi?id=199999
1597
1598         Reviewed by Eric Carlson.
1599
1600         Add a test case to check copy link address, open in new window and download options are not included in the
1601         context menu for non-downloadable media.
1602
1603         * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
1604         (writeNextChunk):
1605         (serverCallback):
1606         (testContextMenuLiveStream):
1607         (beforeAll):
1608         (afterAll):
1609
1610 2019-07-28  Tim Horton  <timothy_horton@apple.com>
1611
1612         Reorganize UIScriptController into platform-specific subclasses
1613         https://bugs.webkit.org/show_bug.cgi?id=200027
1614
1615         Reviewed by Simon Fraser.
1616
1617         Instead of a mishmash of #ifdefs and extraneous empty functions,
1618         reorganize UIScriptController so that we have a base class
1619         with functions that assert if called (to make it harder to
1620         accidentally write a test that depends on unimplemented
1621         functionality), and override them in platform specific subclasses
1622         as functionality is added.
1623
1624         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1625         * DumpRenderTree/ios/UIScriptControllerIOS.h: Added.
1626         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1627         * DumpRenderTree/mac/UIScriptControllerMac.h: Added.
1628         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1629         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1630         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1631         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1632         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.h: Added.
1633         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.mm: Added.
1634         * WebKitTestRunner/gtk/UIScriptControllerGtk.cpp:
1635         * WebKitTestRunner/gtk/UIScriptControllerGtk.h: Added.
1636         * WebKitTestRunner/ios/UIScriptControllerIOS.h: Added.
1637         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1638         * WebKitTestRunner/mac/UIScriptControllerMac.h: Added.
1639         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1640
1641 2019-07-28  Fujii Hironori  <Hironori.Fujii@sony.com>
1642
1643         [Win][MiniBrowser] Remove PageLoadTestClient
1644         https://bugs.webkit.org/show_bug.cgi?id=200155
1645
1646         Reviewed by Brent Fulgham.
1647
1648         It is not used nowadays.
1649
1650         * MiniBrowser/win/CMakeLists.txt:
1651         * MiniBrowser/win/Common.cpp:
1652         (parseCommandLine):
1653         * MiniBrowser/win/Common.h:
1654         * MiniBrowser/win/MainWindow.cpp:
1655         (MainWindow::init):
1656         * MiniBrowser/win/MainWindow.h:
1657         * MiniBrowser/win/MiniBrowserWebHost.cpp:
1658         (MiniBrowserWebHost::updateAddressBar):
1659         (MiniBrowserWebHost::didFinishLoadForFrame):
1660         (MiniBrowserWebHost::didStartProvisionalLoadForFrame):
1661         (MiniBrowserWebHost::didFailLoadWithError):
1662         (MiniBrowserWebHost::didHandleOnloadEventsForFrame):
1663         (MiniBrowserWebHost::didFirstLayoutInFrame):
1664         * MiniBrowser/win/PageLoadTestClient.cpp: Removed.
1665         * MiniBrowser/win/PageLoadTestClient.h: Removed.
1666         * MiniBrowser/win/ResourceLoadDelegate.cpp:
1667         (ResourceLoadDelegate::identifierForInitialRequest):
1668         (ResourceLoadDelegate::willSendRequest):
1669         (ResourceLoadDelegate::didFinishLoadingFromDataSource):
1670         (ResourceLoadDelegate::didFailLoadingWithError):
1671         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1672         (WebKitBrowserWindow::create):
1673         (WebKitBrowserWindow::createNewPage):
1674         * MiniBrowser/win/WebKitBrowserWindow.h:
1675         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
1676         (WebKitLegacyBrowserWindow::create):
1677         (WebKitLegacyBrowserWindow::WebKitLegacyBrowserWindow):
1678         (WebKitLegacyBrowserWindow::exitProgram): Deleted.
1679         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
1680         (WebKitLegacyBrowserWindow::pageLoadTestClient): Deleted.
1681         * MiniBrowser/win/WinMain.cpp:
1682         (wWinMain):
1683
1684 2019-07-26  Jiewen Tan  <jiewen_tan@apple.com>
1685
1686         NavigationSOAuthorizationSession should check the active URL of the responding page after waking up from waiting
1687         https://bugs.webkit.org/show_bug.cgi?id=200150
1688         <rdar://problem/53280170>
1689
1690         Reviewed by Brent Fulgham.
1691
1692         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
1693         (TestWebKitAPI::TEST):
1694
1695 2019-07-26  Jonathan Bedard  <jbedard@apple.com>
1696
1697         Follow-up fix: results.webkit.org: Suite results shouldn't be the landing page
1698         https://bugs.webkit.org/show_bug.cgi?id=200090
1699
1700         Unreviewed follow-up fix.
1701
1702         * resultsdbpy/resultsdbpy/view/view_routes.py:
1703         (ViewRoutes.__init__): Keep /search endpoint for existing links
1704
1705 2019-07-26  Jonathan Bedard  <jbedard@apple.com>
1706
1707         results.webkit.org: Add switch to filter results by expectation
1708         https://bugs.webkit.org/show_bug.cgi?id=200134
1709
1710         Rubber-stamped by Aakash Jain.
1711
1712         Users of the results database should be able to easily differentiate tests which are expected
1713         to fail verse tests which are unexpectedly failing.
1714
1715         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
1716         (Timeline.render): Respect the willFilterExpected variable.
1717         (LegendLabel): Generates html for label in the legend.
1718         (Legend): Add switch for filter results.
1719         * resultsdbpy/resultsdbpy/view/templates/search.html: GIve Legend callback to re-render timelines.
1720         * resultsdbpy/resultsdbpy/view/templates/suite_results.html:
1721
1722 2019-07-26  Aakash Jain  <aakash_jain@apple.com>
1723
1724         [ews-build] Use update-webkit script in Style EWS
1725         https://bugs.webkit.org/show_bug.cgi?id=193196
1726
1727         Reviewed by Jonathan Bedard.
1728
1729         * BuildSlaveSupport/ews-build/factories.py:
1730         (StyleFactory): Updated to use CheckOutSource step as well.
1731         * BuildSlaveSupport/ews-build/steps.py: Added build-step to UpdateWorkingDirectory.
1732         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1733
1734 2019-07-26  Jonathan Bedard  <jbedard@apple.com>
1735
1736         results.webkit.org: Support buildbot 0.8 CI links
1737         https://bugs.webkit.org/show_bug.cgi?id=200146
1738
1739         Reviewed by Aakash Jain.
1740
1741         * resultsdbpy/resultsdbpy/model/ci_context.py:
1742         (BuildbotEightURLFactory): Buildbot 0.8 link factory.
1743         (BuildbotEightURLFactory.__init__):
1744         (BuildbotEightURLFactory.url):
1745         * resultsdbpy/resultsdbpy/model/ci_context_unittest.py:
1746         (URLFactoryTest.test_old_builder_url):
1747         (URLFactoryTest):
1748         (URLFactoryTest.test_old_worker_url):
1749
1750 2019-07-26  Jonathan Bedard  <jbedard@apple.com>
1751
1752         results.webkit.org: Suite results shouldn't be the landing page
1753         https://bugs.webkit.org/show_bug.cgi?id=200090
1754
1755         Reviewed by Aakash Jain.
1756
1757         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Remove search bar.
1758         * resultsdbpy/resultsdbpy/view/view_routes.py:
1759         (ViewRoutes.__init__): Make search the landing page instead of suite results.
1760         * resultsdbpy/resultsdbpy/view/view_routes_unittest.py:
1761         (WebSiteUnittest.test_main):
1762
1763 2019-07-26  Jonathan Bedard  <jbedard@apple.com>
1764
1765         Follow-up fix: results.webkit.org: Color should be the worst result, count should include all results
1766         https://bugs.webkit.org/show_bug.cgi?id=200127
1767
1768         Unreviewed follow-up fix.
1769
1770         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
1771         (Dot.toString): Use self instead of this in render callback.
1772
1773 2019-07-24  Jiewen Tan  <jiewen_tan@apple.com>
1774
1775         WebPageProxy::receivedPolicyDecision should check navigation ID before clear pendingAPIRequest
1776         https://bugs.webkit.org/show_bug.cgi?id=200108
1777         <rdar://problem/53521238>
1778
1779         Reviewed by Chris Dumez.
1780
1781         Added an API test.
1782
1783         * TestWebKitAPI/Tests/WebKitCocoa/DecidePolicyForNavigationAction.mm:
1784         (-[DecidePolicyForNavigationActionController webView:decidePolicyForNavigationAction:decisionHandler:]):
1785         (TEST):
1786
1787 2019-07-25  Jonathan Bedard  <jbedard@apple.com>
1788
1789         results.webkit.org: Color should be the worst result, count should include all results
1790         https://bugs.webkit.org/show_bug.cgi?id=200127
1791
1792         Rubber-stamped by Aakash Jain.
1793
1794         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
1795         (Dot.prototype.toString): Do not differentiate the count based on the prevailing failure type.
1796
1797 2019-07-25  Zhifei Fang  <zhifei_fang@apple.com>
1798
1799         [Timeline]: Make timeline header width automatic, instead of fixed width
1800         https://bugs.webkit.org/show_bug.cgi?id=200059
1801
1802         Reviewed by Jonathan Bedard.
1803
1804         * resultsdbpy/resultsdbpy/view/static/css/timeline.css:
1805         (.dot.crash):
1806         (.timeline>.header): Deleted.
1807         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
1808         (.timeline>.content):
1809         (.timeline>.header):
1810
1811 2019-07-25  Ross Kirsling  <ross.kirsling@sony.com>
1812
1813         [ESNext] Implement nullish coalescing
1814         https://bugs.webkit.org/show_bug.cgi?id=200072
1815
1816         Reviewed by Darin Adler.
1817
1818         * Scripts/run-jsc-stress-tests:
1819
1820 2019-07-24  Fujii Hironori  <Hironori.Fujii@sony.com>
1821
1822         Add Takashi Komori and Tomoki Imai as contributors
1823
1824         Unreviewed.
1825
1826         * Scripts/webkitpy/common/config/contributors.json:
1827
1828 2019-07-24  Yusuke Suzuki  <ysuzuki@apple.com>
1829
1830         [bmalloc] Add IsoHeap test to ensure that IsoHeap pages are not allocating too large VA
1831         https://bugs.webkit.org/show_bug.cgi?id=200103
1832
1833         Reviewed by Mark Lam.
1834
1835         This patch adds tests to TestWTF IsoHeap tests to ensure that IsoHeap's component is not leaking pages or not allocating too large VAs for memory allocation.
1836         We use VMTag to get the system view of the allocated VAs and check whether it is not incredibly large.
1837
1838         While the tests are white-box tests (it means that this is a bit flaky to the implementation changes of IsoHeap), I adjusted some threshold to make this less-flaky
1839         to the future implementation changes while it catches the severe issues we had.
1840
1841         * TestWebKitAPI/Tests/WTF/bmalloc/IsoHeap.cpp:
1842         (assertEmptyPointerSet):
1843         (assertHasOnlyObjects):
1844         (assertClean):
1845         (TEST):
1846         (allocateAndDeallocate):
1847
1848 2019-07-24  Fujii Hironori  <fujii.hironori@gmail.com>
1849
1850         [CMake] CMAKE_SHARED_LINKER_FLAGS drops "-Wl,--no-undefined"
1851         https://bugs.webkit.org/show_bug.cgi?id=200074
1852
1853         Reviewed by Michael Catanzaro.
1854
1855         There was a latent issue. PluginTest::indicateTestFailure was
1856         using WTF::sleep without linking WTF.
1857
1858         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
1859         Added WebKit::WTF to WebKitTestNetscapePlugIn_LIBRARIES.
1860
1861 2019-07-24  Fujii Hironori  <fujii.hironori@gmail.com>
1862
1863         [GTK][WPE][CMake] failing to build TestWebKitAPIInjectedBundle due to missing forwarding headers
1864         https://bugs.webkit.org/show_bug.cgi?id=200073
1865
1866         Reviewed by Michael Catanzaro.
1867
1868         * TestWebKitAPI/PlatformGTK.cmake:
1869         * TestWebKitAPI/PlatformWPE.cmake:
1870         Added add_dependencies(TestWebKitAPIInjectedBundle TestWebKitAPI-forwarding-headers).
1871
1872 2019-07-24  Fujii Hironori  <Hironori.Fujii@sony.com>
1873
1874         [webkitperl] runCommand doesn't work in Windows Perl
1875         https://bugs.webkit.org/show_bug.cgi?id=199900
1876
1877         Reviewed by Don Olmstead.
1878
1879         runCommand was always failing implicit fork by using 'open' with
1880         '-|' in Windows Perl. Explicitly specify the command to 'open' not
1881         to do the implicit fork.
1882
1883         There is one more difference between Windows and Unix. 'open'
1884         successes on Windows even for non existent command while it fails
1885         on Unix. So, return the same error code on Unix as well as
1886         Windows.
1887
1888         * Scripts/VCSUtils.pm: Specified the command to 'open'.
1889         * Scripts/webkitperl/VCSUtils_unittest/runCommand.pl: 'echo'
1890         command is not available on Windows. Use Perl ($^X) instead.
1891
1892 2019-07-24  Priyanka Agarwal  <pagarwal999@apple.com>
1893
1894         Allow Clients to Add Fields to the AutoFillContext Dictionary.
1895         https://bugs.webkit.org/show_bug.cgi?id=199326
1896         rdar://problem/42816957
1897
1898         Reviewed by Wenson Hsieh.
1899
1900         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1901         (TestWebKitAPI::TEST): Created a test to check that the auto fill context
1902         is being properly populated with additional context dictionary.
1903
1904         * TestWebKitAPI/Tests/ios/TestInputDelegate.h:
1905         * TestWebKitAPI/Tests/ios/TestInputDelegate.mm:
1906         (-[TestInputDelegate setWebViewAdditionalContextForStrongPasswordAssistanceHandler:]): Setting the handler for the function
1907         which will populate the additional autofill context dictionary.
1908
1909         (-[TestInputDelegate webViewAdditionalContextForStrongPasswordAssistanceHandler]): Returns the handler for the function which
1910         populates the additional autofill context dictionary.
1911
1912         (-[TestInputDelegate _webViewAdditionalContextForStrongPasswordAssistance:]): Function which populates the additional autofill
1913         context dictionary.
1914
1915         (-[TestInputDelegate setFocusRequiresStrongPasswordAssistanceHandler:]): Setting the handler for the function which checks if the
1916         input field requires strong password work.
1917
1918         (-[TestInputDelegate focusRequiresStrongPasswordAssistanceHandler]): Returns the handler for the function which checks if the
1919         input field requires strong password work.
1920
1921         (-[TestInputDelegate _webView:focusRequiresStrongPasswordAssistance:]): Function which checks if the input field requires strong
1922         password work.
1923
1924 2019-07-24  Zhifei Fang  <zhifei_fang@apple.com>
1925
1926         run-javascriptcore-tests won't report test results for testmasm, testair, testb3, testdfg and test api
1927         https://bugs.webkit.org/show_bug.cgi?id=199489
1928
1929         Reviewed by Aakash Jain.
1930
1931         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1932         (RunJavaScriptCoreTests.start): Skip run jsc test binaries for mips, armv7, aarch64.
1933         (RunJavaScriptCoreTests.countFailures): Pick up the test binaires failure to total failures count
1934         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1935         * Scripts/run-javascriptcore-tests: The script now failed wether the run-jsc-stress-tests failed or test binaries failed.
1936         (runTest): Record test binary failure
1937         (reportTestFailures): Report test binary failure
1938         (runJSCStressTests):
1939         * Scripts/webkitpy/common/config/ports.py: Skip run jsc test binaries for those need to run remotely
1940         (JscOnlyPort.build_jsc_command):
1941         (JscOnlyPort):
1942         (JscOnlyPort.run_javascriptcore_tests_command):
1943         * Scripts/webkitpy/common/config/ports_unittest.py:
1944         (DeprecatedPortTest.test_jsconly_port):
1945
1946 2019-07-24  Zalan Bujtas  <zalan@apple.com>
1947
1948         ASSERTION FAILED: settings().textAutosizingEnabled() && settings().textAutosizingUsesIdempotentMode() in WebCore::Page::recomputeTextAutoSizingInAllFrames()
1949         https://bugs.webkit.org/show_bug.cgi?id=200079
1950         <rdar://problem/53474325>
1951
1952         Reviewed by Wenson Hsieh.
1953
1954         Reset textAutosizingUsesIdempotentMode when transitioning to a new test.
1955
1956         * WebKitTestRunner/ios/TestControllerIOS.mm:
1957         (WTR::TestController::platformResetPreferencesToConsistentValues):
1958
1959 2019-07-23  Fujii Hironori  <Hironori.Fujii@sony.com>
1960
1961         [webkitperl] prepare-ChangeLog_unittest/parser_unittests.pl is failing on Windows Perl
1962         https://bugs.webkit.org/show_bug.cgi?id=199927
1963
1964         Reviewed by Alex Christensen.
1965
1966         convertAbsolutepathToWebKitPath was failing to convert paths on
1967         Windows Perl due to path separators mismatch.
1968
1969         Renamed convertAbsolutepathToWebKitPath to
1970         convertAbsolutePathToRelativeUnixPath, and changed it to replace
1971         paths to relative Unix paths.
1972
1973         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
1974         (convertAbsolutePathToRelativeUnixPath): Added.
1975         (convertAbsolutepathToWebKitPath): Deleted.
1976
1977 2019-07-23  Alex Christensen  <achristensen@webkit.org>
1978
1979         Fix iOS API test after r247759
1980         https://bugs.webkit.org/show_bug.cgi?id=200045
1981
1982         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1983         (TEST):
1984         In the iOS simulator, the WebProcess was being started before we were setting the value on the WKProcessPool.
1985         To fix this, set the value on the WKProcessPool before making the WKWebView.  This makes the test always pass on Mac and iOS.
1986
1987 2019-07-23  Keith Rollin  <krollin@apple.com>
1988
1989         Remove rest of NavigatorContentUtils support
1990         https://bugs.webkit.org/show_bug.cgi?id=200052
1991         <rdar://problem/53467357>
1992
1993         Reviewed by Alex Christensen.
1994
1995         Bug 196070 removes most of the support for the never-used
1996         NavigatorContentUtils facility. However, there were still a couple of
1997         left-over references after that change. This patch sweeps those up.
1998
1999         * Scripts/webkitperl/FeatureList.pm:
2000
2001 2019-07-23  Alex Christensen  <achristensen@webkit.org>
2002
2003         Move javaScriptConfigurationDirectory SPI from _WKProcessPoolConfiguration to WKProcessPoolPrivate to make it runtime switchable
2004         https://bugs.webkit.org/show_bug.cgi?id=200045
2005
2006         Reviewed by Mark Lam.
2007
2008         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
2009         (TEST):
2010
2011 2019-07-23  Russell Epstein  <repstein@apple.com>
2012
2013         Unreviewed, rolling out r247745.
2014
2015         This broke API test
2016         TestWebKitAPI.WKProcessPool.JavaScriptConfiguration as
2017         indicated by EWS
2018
2019         Reverted changeset:
2020
2021         "Move javaScriptConfigurationDirectory SPI from
2022         _WKProcessPoolConfiguration to WKProcessPoolPrivate to make it
2023         runtime switchable"
2024         https://bugs.webkit.org/show_bug.cgi?id=200045
2025         https://trac.webkit.org/changeset/247745
2026
2027 2019-07-23  Alex Christensen  <achristensen@webkit.org>
2028
2029         Move javaScriptConfigurationDirectory SPI from _WKProcessPoolConfiguration to WKProcessPoolPrivate to make it runtime switchable
2030         https://bugs.webkit.org/show_bug.cgi?id=200045
2031
2032         Reviewed by Mark Lam.
2033
2034         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
2035         (TEST):
2036
2037 2019-07-23  Alex Christensen  <achristensen@webkit.org>
2038
2039         Add SPI for setting media cache and key location on _WKWebsiteDataStoreConfiguration
2040         https://bugs.webkit.org/show_bug.cgi?id=199972
2041
2042         Reviewed by Jer Noble.
2043
2044         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2045         (TEST):
2046
2047 2019-07-23  Alicia Boya García  <aboya@igalia.com>
2048
2049         [WTF] Add DataMutex and MainThreadData wrappers
2050         https://bugs.webkit.org/show_bug.cgi?id=199831
2051
2052         Reviewed by Alex Christensen.
2053
2054         Added a very simple test that checks that DataMutex<T> indeed takes
2055         the lock and indeed holds data.
2056
2057         * TestWebKitAPI/CMakeLists.txt:
2058         * TestWebKitAPI/Tests/WTF/DataMutex.cpp: Added.
2059         (TestWebKitAPI::TEST):
2060
2061 2019-07-23  Wenson Hsieh  <wenson_hsieh@apple.com>
2062
2063         [macOS 10.15] Web process crashes when attempting to show the font panel via Font > Show Fonts
2064         https://bugs.webkit.org/show_bug.cgi?id=200021
2065         <rdar://problem/53301325>
2066
2067         Reviewed by Ryosuke Niwa.
2068
2069         Add support for grabbing the child menu items of a context menu item.
2070
2071         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2072         (WTR::getMenuItemChildrenCallback):
2073
2074 2019-07-23  Ryosuke Niwa  <rniwa@webkit.org>
2075
2076         WebKit should strip away system font names from the pasted content
2077         https://bugs.webkit.org/show_bug.cgi?id=199975
2078         <rdar://problem/53336353>
2079
2080         Reviewed by Darin Adler.
2081
2082         Added a test to strip away system font names such as ".AppleSystemUIFont", ".SFUI-Regular", and ".SF UI Mono".
2083
2084         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2085         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm:
2086         * TestWebKitAPI/Tests/WebKitCocoa/cocoa-writer-markup-with-system-fonts.html: Added.
2087
2088 2019-07-22  Aakash Jain  <aakash_jain@apple.com>
2089
2090         [ews-build] EWS fails to parse multi-line full_results.json
2091         https://bugs.webkit.org/show_bug.cgi?id=199992
2092
2093         Reviewed by Alexey Proskuryakov.
2094
2095         * BuildSlaveSupport/ews-build/layout_test_failures.py:
2096         (LayoutTestFailures.results_from_string): Concatenate content into single line.
2097         * BuildSlaveSupport/ews-build/steps_unittest.py:
2098         (test_parse_results_json_with_newlines): Unit-test to cover this scenario.
2099
2100 2019-07-22  Jonathan Bedard  <jbedard@apple.com>
2101
2102         resultsdbpy: Handle case where the previous commit doesn't have the changelog
2103         https://bugs.webkit.org/show_bug.cgi?id=200015
2104
2105         Reviewed by Aakash Jain.
2106
2107         * resultsdbpy/resultsdbpy/model/repository.py:
2108         (WebKitRepository.commit_for_id.diff_changelogs): Allow the previous_response to be None.
2109
2110 2019-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2111
2112         [iOS] [WK1] UIWebView always jumps to the top left corner when scrolling to reveal the selection
2113         https://bugs.webkit.org/show_bug.cgi?id=200013
2114         <rdar://problem/52526901>
2115
2116         Reviewed by Simon Fraser.
2117
2118         Add a new API test to verify that inserting text in UIWebView causes the document to scroll.
2119
2120         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2121         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollToRevealSelection.mm: Added.
2122         (-[LegacyLoadingDelegate webViewDidFinishLoad:]):
2123         (-[LegacyLoadingDelegate waitForDidFinishLoad]):
2124         * TestWebKitAPI/ios/UIKitSPI.h:
2125
2126 2019-07-22  Jer Noble  <jer.noble@apple.com>
2127
2128         REGRESSION(rUnknown): YouTube playback pauses when switching to a new tab
2129         https://bugs.webkit.org/show_bug.cgi?id=199971
2130         <rdar://problem/51951218>
2131
2132         Reviewed by Alex Christensen.
2133
2134         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2135         * TestWebKitAPI/Tests/WebKitCocoa/NoPauseWhenSwitchingTabs.mm: Added.
2136         (TestWebKitAPI::TEST):
2137
2138 2019-07-22  Aakash Jain  <aakash_jain@apple.com>
2139
2140         [ews-build] Add an EWS to run services tests
2141         https://bugs.webkit.org/show_bug.cgi?id=199994
2142
2143         Reviewed by Jonathan Bedard.
2144
2145         * BuildSlaveSupport/ews-build/config.json: Added Services-EWS configuration.
2146         * BuildSlaveSupport/ews-build/factories.py: Added ServicesFactory.
2147         * BuildSlaveSupport/ews-build/steps.py:
2148         (CheckPatchRelevance): Run this EWS only for patches with changes in relevant files.
2149         (RunEWSUnitTests): Build step to run EWS unit-tests.
2150         (RunEWSBuildbotCheckConfig): Build step to run buildbot checkconfig command.
2151         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
2152         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py: Added services status-bubble.
2153
2154 2019-07-22  Youenn Fablet  <youenn@apple.com>
2155
2156         Disable MediaRecorder for legacy WebKit
2157         https://bugs.webkit.org/show_bug.cgi?id=200001
2158         <rdar://problem/53400030>
2159
2160         Reviewed by Eric Carlson.
2161
2162         Enable MediaRecorder for testing purposes.
2163
2164         * DumpRenderTree/mac/DumpRenderTree.mm:
2165         (createWebViewAndOffscreenWindow):
2166
2167 2019-07-22  Jonathan Bedard  <jbedard@apple.com>
2168
2169         results.webkit.org: Timeline header is too small
2170         https://bugs.webkit.org/show_bug.cgi?id=199955
2171
2172         Reviewed by Aakash Jain.
2173
2174         * resultsdbpy/resultsdbpy/view/static/css/timeline.css:
2175         (.timeline>.header): Make timeline header larder to fit configuration names.
2176
2177 2019-07-22  Alex Christensen  <achristensen@webkit.org>
2178
2179         Add SPI to _WKWebsiteDataStoreConfiguration for configuring application cache storage location
2180         https://bugs.webkit.org/show_bug.cgi?id=199954
2181
2182         Reviewed by Geoff Garen.
2183
2184         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2185         (TEST):
2186
2187 2019-07-22  Alex Christensen  <achristensen@webkit.org>
2188
2189         Add SPI _WKProcessPoolConfiguration.javaScriptConfigurationDirectory
2190         https://bugs.webkit.org/show_bug.cgi?id=199917
2191
2192         Reviewed by Sam Weinig.
2193
2194         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
2195         (TEST):
2196
2197 2019-07-22  Aakash Jain  <aakash_jain@apple.com>
2198
2199         [ews-build] ReRunWebKitTests should use similar logic for evaluateCommand as RunWebKitTests
2200         https://bugs.webkit.org/show_bug.cgi?id=199980
2201
2202         Reviewed by Jonathan Bedard.
2203
2204         * BuildSlaveSupport/ews-build/steps.py:
2205         (ReRunWebKitTests.evaluateCommand): Updatd to use similar logic as RunWebKitTests.
2206         * BuildSlaveSupport/ews-build/steps_unittest.py:
2207         (TestRunWebKitTests): Modified to make it generic so as to re-use tests.
2208         (TestReRunWebKitTests): Run all TestRunWebKitTests unit-tests for ReRunWebKitTests as well.
2209
2210 2019-07-22  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2211
2212         [webkitpy] Add an unit test for setting up the driver environment without starting it.
2213         https://bugs.webkit.org/show_bug.cgi?id=199945
2214
2215         Reviewed by Michael Catanzaro.
2216
2217         This adds an unit test for the change implemented in r247663.
2218
2219         * Scripts/webkitpy/port/driver_unittest.py:
2220         (DriverTest.test_setup_environ_base_vars):
2221         (DriverTest):
2222         (DriverTest.test_setup_environ_without_starting_driver):
2223
2224 2019-07-21  Wenson Hsieh  <wenson_hsieh@apple.com>
2225
2226         [iOS] [WebKit2] Add limited support for -isPosition:atBoundary:inDirection: in WKContentView
2227         https://bugs.webkit.org/show_bug.cgi?id=199993
2228         <rdar://problem/49523528>
2229
2230         Reviewed by Beth Dakin.
2231
2232         Add a new API test to verify the behavior of -isPosition:atBoundary:inDirection:.
2233
2234         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
2235         (TestWebKitAPI::TEST):
2236         * TestWebKitAPI/cocoa/TestWKWebView.h:
2237
2238 2019-07-21  Andres Gonzalez  <andresg_22@apple.com>
2239
2240         Add accessibilityInsertText for text insertion in edit fields.
2241         https://bugs.webkit.org/show_bug.cgi?id=199973
2242
2243         Reviewed by Chris Fleizach.
2244
2245         Renamed accessibilityInsertText to _accessibilityInsertText.
2246
2247         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2248         (AccessibilityUIElement::insertText):
2249         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2250         (AccessibilityUIElement::insertText):
2251         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2252         (WTR::AccessibilityUIElement::insertText):
2253         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2254         (WTR::AccessibilityUIElement::insertText):
2255
2256 2019-07-20  Chris Dumez  <cdumez@apple.com>
2257
2258         Speed up HashTable decoding by reserving capacity and avoiding rehashing
2259         https://bugs.webkit.org/show_bug.cgi?id=199982
2260
2261         Reviewed by Saam Barati.
2262
2263         Add API test coverage.
2264
2265         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
2266         (TestWebKitAPI::TEST):
2267
2268 2019-07-20  Andres Gonzalez  <andresg_22@apple.com>
2269
2270         Add accessibilityInsertText for text insertion in edit fields.
2271         https://bugs.webkit.org/show_bug.cgi?id=199973
2272
2273         Reviewed by Chris Fleizach.
2274
2275         Glue code to run new LayoutTests.
2276         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2277         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2278         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2279         (WTR::AccessibilityUIElement::insertText):
2280         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2281         (WTR::AccessibilityUIElement::insertText):
2282         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2283         (WTR::AccessibilityUIElement::insertText):
2284         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
2285         (WTR::AccessibilityUIElement::insertText):
2286
2287 2019-07-19  Zhifei Fang  <zhifei_fang@apple.com>
2288
2289         Move webkit.css to opensource to support resultsdbpy's frontend
2290         https://bugs.webkit.org/show_bug.cgi?id=199957
2291
2292         Reviewed by Jonathan Bedard.
2293
2294         * resultsdbpy/resultsdbpy/view/static/library/css/docs.yaml: Added.
2295         * resultsdbpy/resultsdbpy/view/static/library/css/generate-webkit-css-docs: Added.
2296         * resultsdbpy/resultsdbpy/view/static/library/css/index.html: Added.
2297         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css: Added.
2298
2299 2019-07-19  Zhifei Fang  <zhifei_fang@apple.com>
2300
2301         Move Ref.js to WebKit to support resultsdbpy's frontend
2302         https://bugs.webkit.org/show_bug.cgi?id=199956
2303
2304         Reviewed by Jonathan Bedard.
2305
2306         * resultsdbpy/resultsdbpy/view/static/js/drawer.js:
2307         * resultsdbpy/resultsdbpy/view/static/js/search.js:
2308         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
2309         * resultsdbpy/resultsdbpy/view/static/library/js/Ref.js: Added.
2310         * resultsdbpy/resultsdbpy/view/static/library/js/Utils.js: Added.
2311         * resultsdbpy/resultsdbpy/view/static/library/js/components/BaseComponents.js: Added.
2312         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js: Added.
2313         * resultsdbpy/resultsdbpy/view/templates/base.html:
2314         * resultsdbpy/resultsdbpy/view/templates/commits.html:
2315         * resultsdbpy/resultsdbpy/view/templates/documentation.html:
2316         * resultsdbpy/resultsdbpy/view/templates/search.html:
2317         * resultsdbpy/resultsdbpy/view/templates/suite_results.html:
2318         * resultsdbpy/resultsdbpy/view/view_routes.py:
2319
2320 2019-07-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2321
2322         [webkitpy] Allow the testrunner driver to setup the environment completely without needing to start the server process.
2323         https://bugs.webkit.org/show_bug.cgi?id=199945
2324
2325         Reviewed by Michael Catanzaro.
2326
2327         Refactor the code to create the Driver temporal directories inside Driver._setup_environ_for_driver().
2328         This allows external callers to setup the environment for running tests by calling that method without needing to start the server process.
2329         When this callers finish testing, it is enough with calling either Driver.stop() or Driver._delete_temporal_directories().
2330
2331         * Scripts/webkitpy/port/driver.py:
2332         (Driver._setup_environ_for_driver):
2333         (Driver._create_temporal_directories):
2334         (Driver):
2335         (Driver._start):
2336         (Driver._delete_temporal_directories):
2337         (Driver.stop):
2338         * Scripts/webkitpy/w3c/wpt_runner.py: Not needed anymore to start the driver since this doesnt need the server process running.
2339         (main):
2340         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py: Ditto.
2341         (WebDriverTestRunner.__init__):
2342         * glib/api_test_runner.py:
2343         (TestRunner._setup_testing_environment): Ditto.
2344
2345 2019-07-19  Aakash Jain  <aakash_jain@apple.com>
2346
2347         [ews-build] Display pre-existing Layout test failure names in the build summary
2348         https://bugs.webkit.org/show_bug.cgi?id=199941
2349
2350         Reviewed by Jonathan Bedard.
2351
2352         * BuildSlaveSupport/ews-build/steps.py:
2353         (AnalyzeLayoutTestsResults.report_pre_existing_failures):
2354
2355 2019-07-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2356
2357         [GTK][WPE] run-webkit-tests should run with a temporal homedir
2358         https://bugs.webkit.org/show_bug.cgi?id=199738
2359
2360         Reviewed by Michael Catanzaro.
2361
2362         Run the tests with an empty homedir that is created inside the driver tmpdir.
2363         The driver tmpdir is a random directory created for each test runner that is purged after the run.
2364
2365         This is done to ensure that the test results are not affected by the user settings of any library.
2366
2367         * Scripts/webkitpy/port/driver.py:
2368         (Driver._setup_environ_for_driver):
2369         * Scripts/webkitpy/port/driver_unittest.py:
2370         (DriverTest.test_setup_environ_base_vars):
2371         (DriverTest):
2372         (DriverTest.test_create_temporal_home_dir):
2373
2374 2019-07-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2375
2376         Remove pywebsockets from thirdparty
2377         https://bugs.webkit.org/show_bug.cgi?id=199710
2378
2379         Reviewed by Jonathan Bedard.
2380
2381         We have a very old version of pywebsocket in webkitpy thirdparty, but we are also importing pywebsocket as part
2382         of wpt tools. We can simply use the wpt one for all websocket tests and remove the old copy from sources.
2383
2384         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
2385         (PyWebSocket._prepare_config): Use pywebsocket from imported w3c tools directory.
2386         * Scripts/webkitpy/thirdparty/mod_pywebsocket/COPYING: Removed.
2387         * Scripts/webkitpy/thirdparty/mod_pywebsocket/__init__.py: Removed.
2388         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_base.py: Removed.
2389         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hixie75.py: Removed.
2390         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hybi.py: Removed.
2391         * Scripts/webkitpy/thirdparty/mod_pywebsocket/common.py: Removed.
2392         * Scripts/webkitpy/thirdparty/mod_pywebsocket/dispatch.py: Removed.
2393         * Scripts/webkitpy/thirdparty/mod_pywebsocket/extensions.py: Removed.
2394         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/__init__.py: Removed.
2395         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/_base.py: Removed.
2396         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi.py: Removed.
2397         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi00.py: Removed.
2398         * Scripts/webkitpy/thirdparty/mod_pywebsocket/headerparserhandler.py: Removed.
2399         * Scripts/webkitpy/thirdparty/mod_pywebsocket/http_header_util.py: Removed.
2400         * Scripts/webkitpy/thirdparty/mod_pywebsocket/memorizingfile.py: Removed.
2401         * Scripts/webkitpy/thirdparty/mod_pywebsocket/msgutil.py: Removed.
2402         * Scripts/webkitpy/thirdparty/mod_pywebsocket/mux.py: Removed.
2403         * Scripts/webkitpy/thirdparty/mod_pywebsocket/standalone.py: Removed.
2404         * Scripts/webkitpy/thirdparty/mod_pywebsocket/stream.py: Removed.
2405         * Scripts/webkitpy/thirdparty/mod_pywebsocket/util.py: Removed.
2406
2407 2019-07-18  Jonathan Bedard  <jbedard@apple.com>
2408
2409         results.webkit.org: Move resultsdbpy to WebKit
2410         https://bugs.webkit.org/show_bug.cgi?id=199837
2411         <rdar://problem/53172130>
2412
2413         Rubber-stamped by Aakash Jain.
2414
2415         Moving the entirety of the resultsdbpy library, which provides utilities to build
2416         a database designed to store, visualize and organize test results, into WebKit.
2417
2418         * Scripts/webkitpy/style/checker.py:
2419         (CheckerDispatcher._create_checker): resulltsdbpy is a Python 3 library.
2420         * resultsdbpy: Added.
2421         * resultsdbpy/MANIFEST.in: Added.
2422         * resultsdbpy/README.md: Added.
2423         * resultsdbpy/resultsdbpy: Added.
2424         * resultsdbpy/resultsdbpy/__init__.py: Added.
2425         * resultsdbpy/resultsdbpy/controller: Added.
2426         * resultsdbpy/resultsdbpy/controller/__init__.py: Added.
2427         * resultsdbpy/resultsdbpy/controller/api_routes.py: Added.
2428         * resultsdbpy/resultsdbpy/controller/ci_controller.py: Added.
2429         * resultsdbpy/resultsdbpy/controller/ci_controller_unittest.py: Added.
2430         * resultsdbpy/resultsdbpy/controller/commit.py: Added.
2431         * resultsdbpy/resultsdbpy/controller/commit_controller.py: Added.
2432         * resultsdbpy/resultsdbpy/controller/commit_controller_unittest.py: Added.
2433         * resultsdbpy/resultsdbpy/controller/commit_unittest.py: Added.
2434         * resultsdbpy/resultsdbpy/controller/configuration.py: Added.
2435         * resultsdbpy/resultsdbpy/controller/configuration_controller.py: Added.
2436         * resultsdbpy/resultsdbpy/controller/configuration_controller_unittest.py: Added.
2437         * resultsdbpy/resultsdbpy/controller/configuration_unittest.py: Added.
2438         * resultsdbpy/resultsdbpy/controller/suite_controller.py: Added.
2439         * resultsdbpy/resultsdbpy/controller/suite_controller_unittest.py: Added.
2440         * resultsdbpy/resultsdbpy/controller/test_controller.py: Added.
2441         * resultsdbpy/resultsdbpy/controller/test_controller_unittest.py: Added.
2442         * resultsdbpy/resultsdbpy/controller/upload_controller.py: Added.
2443         * resultsdbpy/resultsdbpy/controller/upload_controller_unittest.py: Added.
2444         * resultsdbpy/resultsdbpy/flask_support: Added.
2445         * resultsdbpy/resultsdbpy/flask_support/__init__.py: Added.
2446         * resultsdbpy/resultsdbpy/flask_support/authed_blueprint.py: Added.
2447         * resultsdbpy/resultsdbpy/flask_support/flask_test_context.py: Added.
2448         * resultsdbpy/resultsdbpy/flask_support/flask_testcase.py: Added.
2449         * resultsdbpy/resultsdbpy/flask_support/util.py: Added.
2450         * resultsdbpy/resultsdbpy/flask_support/util_unittest.py: Added.
2451         * resultsdbpy/resultsdbpy/model: Added.
2452         * resultsdbpy/resultsdbpy/model/__init__.py: Added.
2453         * resultsdbpy/resultsdbpy/model/cassandra_context.py: Added.
2454         * resultsdbpy/resultsdbpy/model/cassandra_context_unittest.py: Added.
2455         * resultsdbpy/resultsdbpy/model/casserole.py: Added.
2456         * resultsdbpy/resultsdbpy/model/casserole_unittest.py: Added.
2457         * resultsdbpy/resultsdbpy/model/ci_context.py: Added.
2458         * resultsdbpy/resultsdbpy/model/ci_context_unittest.py: Added.
2459         * resultsdbpy/resultsdbpy/model/commit_context.py: Added.
2460         * resultsdbpy/resultsdbpy/model/commit_context_unittest.py: Added.
2461         * resultsdbpy/resultsdbpy/model/configuration_context.py: Added.
2462         * resultsdbpy/resultsdbpy/model/configuration_context_unittest.py: Added.
2463         * resultsdbpy/resultsdbpy/model/docker-compose.yml: Added.
2464         * resultsdbpy/resultsdbpy/model/docker.py: Added.
2465         * resultsdbpy/resultsdbpy/model/docker_unittest.py: Added.
2466         * resultsdbpy/resultsdbpy/model/mock_cassandra_context.py: Added.
2467         * resultsdbpy/resultsdbpy/model/mock_model_factory.py: Added.
2468         * resultsdbpy/resultsdbpy/model/mock_repository.py: Added.
2469         * resultsdbpy/resultsdbpy/model/model.py: Added.
2470         * resultsdbpy/resultsdbpy/model/partitioned_redis.py: Added.
2471         * resultsdbpy/resultsdbpy/model/partitioned_redis_unittest.py: Added.
2472         * resultsdbpy/resultsdbpy/model/redis_unittest.py: Added.
2473         * resultsdbpy/resultsdbpy/model/repository.py: Added.
2474         * resultsdbpy/resultsdbpy/model/repository_unittest.py: Added.
2475         * resultsdbpy/resultsdbpy/model/suite_context.py: Added.
2476         * resultsdbpy/resultsdbpy/model/suite_context_unittest.py: Added.
2477         * resultsdbpy/resultsdbpy/model/test_context.py: Added.
2478         * resultsdbpy/resultsdbpy/model/test_context_unittest.py: Added.
2479         * resultsdbpy/resultsdbpy/model/upload_context.py: Added.
2480         * resultsdbpy/resultsdbpy/model/upload_context_unittest.py: Added.
2481         * resultsdbpy/resultsdbpy/model/wait_for_docker_test_case.py: Added.
2482         * resultsdbpy/resultsdbpy/run-tests: Added.
2483         * resultsdbpy/resultsdbpy/view: Added.
2484         * resultsdbpy/resultsdbpy/view/__init__.py: Added.
2485         * resultsdbpy/resultsdbpy/view/ci_view.py: Added.
2486         * resultsdbpy/resultsdbpy/view/commit_view.py: Added.
2487         * resultsdbpy/resultsdbpy/view/commit_view_unittest.py: Added.
2488         * resultsdbpy/resultsdbpy/view/site_menu.py: Added.
2489         * resultsdbpy/resultsdbpy/view/static: Added.
2490         * resultsdbpy/resultsdbpy/view/static/css: Added.
2491         * resultsdbpy/resultsdbpy/view/static/css/commit.css: Added.
2492         * resultsdbpy/resultsdbpy/view/static/css/drawer.css: Added.
2493         * resultsdbpy/resultsdbpy/view/static/css/search.css: Added.
2494         * resultsdbpy/resultsdbpy/view/static/css/timeline.css: Added.
2495         * resultsdbpy/resultsdbpy/view/static/js: Added.
2496         * resultsdbpy/resultsdbpy/view/static/js/commit.js: Added.
2497         * resultsdbpy/resultsdbpy/view/static/js/common.js: Added.
2498         * resultsdbpy/resultsdbpy/view/static/js/configuration.js: Added.
2499         * resultsdbpy/resultsdbpy/view/static/js/drawer.js: Added.
2500         * resultsdbpy/resultsdbpy/view/static/js/search.js: Added.
2501         * resultsdbpy/resultsdbpy/view/static/js/timeline.js: Added.
2502         * resultsdbpy/resultsdbpy/view/suite_view.py: Added.
2503         * resultsdbpy/resultsdbpy/view/templates: Added.
2504         * resultsdbpy/resultsdbpy/view/templates/base.html: Added.
2505         * resultsdbpy/resultsdbpy/view/templates/commit.html: Added.
2506         * resultsdbpy/resultsdbpy/view/templates/commits.html: Added.
2507         * resultsdbpy/resultsdbpy/view/templates/documentation.html: Added.
2508         * resultsdbpy/resultsdbpy/view/templates/error.html: Added.
2509         * resultsdbpy/resultsdbpy/view/templates/search.html: Added.
2510         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Added.
2511         * resultsdbpy/resultsdbpy/view/view_routes.py: Added.
2512         * resultsdbpy/resultsdbpy/view/view_routes_unittest.py: Added.
2513         * resultsdbpy/setup.py: Added.
2514
2515 2019-07-18  Alex Christensen  <achristensen@webkit.org>
2516
2517         Add and test _WKWebsiteDataStoreConfiguration.deviceIdHashSaltsStorageDirectory SPI
2518         https://bugs.webkit.org/show_bug.cgi?id=199923
2519
2520         Reviewed by Youenn Fablet.
2521
2522         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
2523         (TestWebKitAPI::TEST):
2524
2525 2019-07-18  Aakash Jain  <aakash_jain@apple.com>
2526
2527         [ews-build] Enable iOS WK2 tester queue on new EWS
2528         https://bugs.webkit.org/show_bug.cgi?id=199867
2529
2530         Reviewed by Jonathan Bedard.
2531
2532         * BuildSlaveSupport/ews-build/config.json: Enabled the triggers for ios-wk2 queue.
2533         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py: Enabled ios-sim (builder) and ios-wk2 (tester) bubbles.
2534         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js: Removed ios-sim queue from bot-watcher's dashboard.
2535         * QueueStatusServer/config/queues.py: Removed ios-sim queue from old EWS.
2536
2537 2019-07-18  Aakash Jain  <aakash_jain@apple.com>
2538
2539         [ews-build] Add build step to AnalyzeLayoutTestsResults
2540         https://bugs.webkit.org/show_bug.cgi?id=199877
2541
2542         Reviewed by Jonathan Bedard.
2543
2544         Logic is ported from webkitpy/tool/bot/patchanalysistask.py::_retry_layout_tests()
2545
2546         * BuildSlaveSupport/ews-build/steps.py:
2547         (RunWebKitTestsWithoutPatch.evaluateCommand): invoke AnalyzeLayoutTestsResults step.
2548         (AnalyzeLayoutTestsResults): Build step to analyze layout-test results.
2549         (AnalyzeLayoutTestsResults.report_failure):
2550         (AnalyzeLayoutTestsResults.report_pre_existing_failures):
2551         (AnalyzeLayoutTestsResults.retry_build):
2552         (AnalyzeLayoutTestsResults._results_failed_different_tests):
2553         (AnalyzeLayoutTestsResults._report_flaky_tests):
2554         (AnalyzeLayoutTestsResults.start):
2555         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
2556
2557 2019-07-18  Alex Christensen  <achristensen@webkit.org>
2558
2559         Move NetworkCache ownership from NetworkProcess to NetworkSession
2560         https://bugs.webkit.org/show_bug.cgi?id=199817
2561
2562         Reviewed by Geoff Garen.
2563
2564         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2565         (TEST):
2566         * TestWebKitAPI/cocoa/TestWKWebView.h:
2567         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2568         (-[WKWebView synchronouslyLoadRequest:]):
2569
2570 2019-07-18  Youenn Fablet  <youenn@apple.com>
2571
2572         Make sure to set kCTFontFallbackOptionAttribute to kCTFontFallbackOptionSystem for system fonts
2573         https://bugs.webkit.org/show_bug.cgi?id=199769
2574         <rdar://problem/49390297>
2575
2576         Reviewed by Myles C. Maxfield.
2577
2578         Add a font containing one extended character not found in system fonts.
2579
2580         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2581         * WebKitTestRunner/fonts/FakeHelvetica-SingleExtendedCharacter.ttf: Added.
2582
2583 2019-07-18  Konstantin Tokarev  <annulen@yandex.ru>
2584
2585         Unreviewed, Add Olivier Blin as contributor
2586
2587         * Scripts/webkitpy/common/config/contributors.json:
2588
2589 2019-07-17  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2590
2591         [GTK][WPE][webkitpy] Refactor drivers to use the base driver for setting up the environment and start the drivers.
2592         https://bugs.webkit.org/show_bug.cgi?id=199855
2593
2594         Reviewed by Michael Catanzaro.
2595
2596         The webkitpy drivers for GTK and WPE use their own versions for setting
2597         up the environment and starting/stopping the drivers.
2598         This refactors those drivers to use the base class driver functions.
2599         As a benefit we get some fixes like support for setting the profiler
2600         environment variables, and a simpler code.
2601
2602         * Scripts/webkitpy/port/driver.py:
2603         (Driver._setup_environ_for_driver): This already correctly setups LOCAL_RESOURCE_ROOT and DUMPRENDERTREE_TEMP.
2604         Add the remaining environment variable XDG_CACHE_HOME that is needed for Linux.
2605         * Scripts/webkitpy/port/headlessdriver.py:
2606         (HeadlessDriver._setup_environ_for_test):
2607         * Scripts/webkitpy/port/waylanddriver.py:
2608         (WaylandDriver._setup_environ_for_test):
2609         * Scripts/webkitpy/port/westondriver.py:
2610         (WestonDriver._setup_environ_for_test):
2611         (WestonDriver.stop):
2612         * Scripts/webkitpy/port/westondriver_unittest.py: now mock _test_runner_process_constructor as base driver does.
2613         (WestonDriverTest.make_driver):
2614         * Scripts/webkitpy/port/xorgdriver.py:
2615         (XorgDriver._setup_environ_for_test):
2616         * Scripts/webkitpy/port/xvfbdriver.py: the xvfb binary is started with the port server env
2617         (XvfbDriver._setup_environ_for_test):
2618         * Scripts/webkitpy/port/xvfbdriver_unittest.py: rename the variable to make clearer that it uses the port server env.
2619         (XvfbDriverTest.make_driver):
2620         (XvfbDriverTest.test_start):
2621         (XvfbDriverTest.test_start_arbitrary_worker_number):
2622         * Scripts/webkitpy/w3c/wpt_runner.py:
2623         (main): Start the driver before trying to get its environment to define all the environment variables.
2624         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
2625         (WebDriverTestRunner.__init__): Ditto.
2626         * glib/api_test_runner.py:
2627         (TestRunner._setup_testing_environment): Ditto.
2628
2629 2019-07-17  Antoine Quint  <graouts@apple.com>
2630
2631         Disable Pointer Events prior to watchOS 6
2632         https://bugs.webkit.org/show_bug.cgi?id=199890
2633         <rdar://problem/53206113>
2634
2635         Reviewed by Dean Jackson.
2636
2637         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2638
2639 2019-07-17  Christopher Reid  <chris.reid@sony.com>
2640
2641         Bytecode cache should use FileSystem
2642         https://bugs.webkit.org/show_bug.cgi?id=199759
2643
2644         Reviewed by Yusuke Suzuki.
2645
2646         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
2647
2648 2019-07-17  Jonathan Bedard  <jbedard@apple.com>
2649
2650         check-webkit-style: Add limited Python3 support
2651         https://bugs.webkit.org/show_bug.cgi?id=199870
2652
2653         Rubber-stamped by Aakash Jain.
2654
2655         Since new services will be added in the near future which are Python 3, we
2656         need to support Python 3 style checks. For now, assume all Python files are
2657         Python 2 unless otherwise specified.
2658
2659         * Scripts/webkitpy/style/checker.py:
2660         (_all_categories): Add pycodestyle to valid categories for testing.
2661         (CheckerDispatcher._create_checker): Check that the provided Python file is in
2662         one of the declared Python 3 directories.
2663         * Scripts/webkitpy/style/checkers/python.py:
2664         (Python3Checker): Add Python 3 checker, which doesn't lint and uses pycodestyle
2665         instead of pep8.
2666         (Python3Checker.__init__):
2667         (Python3Checker.check):
2668         * Scripts/webkitpy/thirdparty/__init__.py:
2669         (AutoinstallImportHook.find_module): Support auto-installing pycodestyle.
2670         (AutoinstallImportHook._install_pycodestyle):
2671
2672 2019-07-17  Sam Weinig  <weinig@apple.com>
2673
2674         Add StringBuilder member function which allows makeString() style variadic argument construction
2675         https://bugs.webkit.org/show_bug.cgi?id=198997
2676
2677         Reviewed by Darin Adler.
2678
2679         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2680         Add basic test showing that StringBuilder::flexibleAppend can be used to
2681         append one or more string adaptable types.
2682
2683         * TestWebKitAPI/CMakeLists.txt:
2684         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2685         Add WTFStringUtilities.cpp
2686
2687         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2688         Add basic test showing that StringBuilder::flexibleAppend can be used to
2689         append one or more string adaptable types.
2690
2691         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
2692         * TestWebKitAPI/WTFStringUtilities.cpp: Added.
2693         * TestWebKitAPI/WTFStringUtilities.h:
2694         Move WTF_STRINGTYPEADAPTER_COPIED_WTF_STRING() and wtfStringCopyCount to WTFStringUtilities.h/cpp
2695         to allow for a single definition of StringTypeAdapter<String, void> which is required for ODR.
2696
2697 2019-07-17  Ryosuke Niwa  <rniwa@webkit.org>
2698
2699         Remove the file superfluously added in r247535.
2700
2701         * TestWebKitAPI/Tests/ios/SelectionModifyByParagraphBoundary.h: Removed.
2702         * TestWebKitAPI/Tests/ios/SelectionModifyByParagraphBoundary.mm:
2703
2704 2019-07-17  Alex Christensen  <achristensen@webkit.org>
2705
2706         Add a runtime-disabled dialog element skeleton
2707         https://bugs.webkit.org/show_bug.cgi?id=199839
2708
2709         Reviewed by Ryosuke Niwa.
2710
2711         * DumpRenderTree/mac/DumpRenderTree.mm:
2712         (resetWebPreferencesToConsistentValues):
2713         * WebKitTestRunner/TestController.cpp:
2714         (WTR::TestController::resetPreferencesToConsistentValues):
2715         Enable the dialog element for layout tests.
2716
2717 2019-07-17  Ryosuke Niwa  <rniwa@webkit.org>
2718
2719         [iOS] Option + Up or Down Arrow key doesn’t move cursor past paragraph boundaries in WebKit2
2720         https://bugs.webkit.org/show_bug.cgi?id=199851
2721
2722         Reviewed by Wenson Hsieh.
2723
2724         Added a regression test for iOS. Unfortunately, event sender, etc... doesn't work because
2725         this code is getting directly triggered from UIKeyboard's code.
2726
2727         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2728         * TestWebKitAPI/Tests/ios/SelectionModifyByParagraphBoundary.h: Added.
2729         * TestWebKitAPI/Tests/ios/SelectionModifyByParagraphBoundary.mm: Added.
2730         * TestWebKitAPI/ios/UIKitSPI.h:
2731
2732 2019-07-17  Commit Queue  <commit-queue@webkit.org>
2733
2734         Unreviewed, rolling out r247505.
2735         https://bugs.webkit.org/show_bug.cgi?id=199871
2736
2737         "Caused failed ASSERT in stress test" (Requested by creid on
2738         #webkit).
2739
2740         Reverted changeset:
2741
2742         "Bytecode cache should use FileSystem"
2743         https://bugs.webkit.org/show_bug.cgi?id=199759
2744         https://trac.webkit.org/changeset/247505
2745
2746 2019-07-17  Russell Epstein  <russell_e@apple.com>
2747
2748         Adding self to contributors.json
2749
2750         Unreviewed.
2751
2752         * Scripts/webkitpy/common/config/contributors.json:
2753
2754 2019-07-17  Aakash Jain  <aakash_jain@apple.com>
2755
2756         [ews-build] Parse full_results.json for layout-tests
2757         https://bugs.webkit.org/show_bug.cgi?id=199804
2758
2759         Reviewed by Jonathan Bedard.
2760
2761         * BuildSlaveSupport/ews-build/steps.py:
2762         (RunWebKitTests.start): Monitor json output.
2763         (RunWebKitTests.commandComplete): Read json output, parse the results and set Buildbot properties accordingly. These
2764         properties would be used in subsequent AnalyzeLayoutTests build step to determine whether the failures are introduced
2765         by the patch or are pre-existing.
2766         (ReRunWebKitTests.commandComplete): Ditto.
2767         (RunWebKitTestsWithoutPatch.commandComplete): Ditto.
2768         * BuildSlaveSupport/ews-build/steps_unittest.py:
2769         (BuildStepMixinAdditions.getProperty): Added.
2770         (TestRunWebKitTests.test_parse_results_json): Added unit-tests.
2771         * BuildSlaveSupport/ews-build/layout_test_failures.py: Parse full_results.json and generate list of failing tests.
2772
2773 2019-07-17  Michael Catanzaro  <mcatanzaro@igalia.com>
2774
2775         Unreviewed, rolling out r247512.
2776
2777         Broke API test runners
2778
2779         Reverted changeset:
2780
2781         "[GTK][WPE][webkitpy] Refactor drivers to use the base driver
2782         for setting up the environment and start the drivers."
2783         https://bugs.webkit.org/show_bug.cgi?id=199855
2784         https://trac.webkit.org/changeset/247512
2785
2786 2019-07-17  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2787
2788         [GTK][WPE][webkitpy] Refactor drivers to use the base driver for setting up the environment and start the drivers.
2789         https://bugs.webkit.org/show_bug.cgi?id=199855
2790
2791         Reviewed by Carlos Garcia Campos.
2792
2793         The webkitpy drivers for GTK and WPE use their own versions for setting
2794         up the environment and starting/stopping the drivers.
2795         This refactors those drivers to use the base class driver functions.
2796         As a benefit we get some fixes like support for setting the profiler
2797         environment variables, and a simpler code.
2798
2799         * Scripts/webkitpy/port/driver.py:
2800         (Driver._setup_environ_for_driver): This already correctly setups LOCAL_RESOURCE_ROOT and DUMPRENDERTREE_TEMP.
2801         Add the remaining environment variable XDG_CACHE_HOME that is needed for Linux.
2802         * Scripts/webkitpy/port/headlessdriver.py:
2803         (HeadlessDriver._setup_environ_for_test):
2804         * Scripts/webkitpy/port/waylanddriver.py:
2805         (WaylandDriver._setup_environ_for_test):
2806         * Scripts/webkitpy/port/westondriver.py:
2807         (WestonDriver._setup_environ_for_test):
2808         (WestonDriver.stop):
2809         * Scripts/webkitpy/port/westondriver_unittest.py: now mock _test_runner_process_constructor as base driver does.
2810         (WestonDriverTest.make_driver):
2811         * Scripts/webkitpy/port/xorgdriver.py:
2812         (XorgDriver._setup_environ_for_test):
2813         * Scripts/webkitpy/port/xvfbdriver.py: the xvfb binary is started with the port server env
2814         (XvfbDriver._setup_environ_for_test):
2815         * Scripts/webkitpy/port/xvfbdriver_unittest.py: rename the variable to make clearer that it uses the port server env.
2816         (XvfbDriverTest.make_driver):
2817         (XvfbDriverTest.test_start):
2818         (XvfbDriverTest.test_start_arbitrary_worker_number):
2819
2820 2019-07-16  Christopher Reid  <chris.reid@sony.com>
2821
2822         Bytecode cache should use FileSystem
2823         https://bugs.webkit.org/show_bug.cgi?id=199759
2824
2825         Reviewed by Yusuke Suzuki.
2826
2827         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
2828
2829 2019-07-16  Jonathan Bedard  <jbedard@apple.com>
2830
2831         svn-create-patch duplicates diffs when adding directories
2832         https://bugs.webkit.org/show_bug.cgi?id=199842
2833
2834         Reviewed by Dewei Zhu.
2835
2836         * Scripts/svn-create-patch:
2837         (findKind): Add function which returns what 'kind' of file the provided path is.
2838         (generateFileList): If the path is a directory and being added, don't add it.
2839         Instead, rely on the fact that its children will be added.
2840
2841 2019-07-16  Tim Horton  <timothy_horton@apple.com>
2842
2843         NSTextFinder holes don't scroll with the page
2844         https://bugs.webkit.org/show_bug.cgi?id=199815
2845         <rdar://problem/52280514>
2846
2847         Reviewed by Simon Fraser.
2848
2849         * MiniBrowser/mac/WK2BrowserWindowController.m:
2850         (-[MiniBrowserNSTextFinder performAction:]):
2851         (-[WK2BrowserWindowController awakeFromNib]):
2852         Adopt the WebKit UI in MiniBrowser. Also, override NSTextFinder's
2853         -performAction: so that we can intercept the close action and
2854         hide our own find UI, since there is no delegate for that action yet.
2855
2856         * TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm:
2857         (TEST):
2858
2859 2019-07-15  Keith Miller  <keith_miller@apple.com>
2860
2861         JSGlobalObject type macros should support feature flags and WeakRef should have one
2862         https://bugs.webkit.org/show_bug.cgi?id=199601
2863
2864         Reviewed by Mark Lam.
2865
2866         JSC options need to be set before the window is created for the test.
2867
2868         * DumpRenderTree/mac/DumpRenderTree.mm:
2869         (resetWebViewToConsistentStateBeforeTesting):
2870         * DumpRenderTree/win/DumpRenderTree.cpp:
2871         (setJSCOptions):
2872         (resetWebViewToConsistentStateBeforeTesting):
2873
2874 2019-07-15  Said Abou-Hallawa  <sabouhallawa@apple.com>
2875
2876         [ Mojave WK1 ] Some Image tests are flakey failures and are failing in tandem with zoomed in or blank image results
2877         https://bugs.webkit.org/show_bug.cgi?id=193108
2878
2879         Reviewed by Simon Fraser.
2880
2881         Add a workaround for <rdar://problem/17084993> in createBitmapContextFromWebView().
2882         Re-request the snapshot at kCGWindowImageNominalResolution if it was captured
2883         at the wrong scale.
2884
2885         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2886         (takeWindowSnapshot):
2887         (createBitmapContextFromWebView):
2888
2889 2019-07-15  Brady Eidson  <beidson@apple.com>
2890
2891         Make WKURLSchemeTask thread safe.
2892         <rdar://problem/50471863> and https://bugs.webkit.org/show_bug.cgi?id=199764
2893
2894         Reviewed by Alex Christensen.
2895
2896         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
2897
2898 2019-07-15  Jiewen Tan  <jiewen_tan@apple.com>
2899
2900         Unreviewed, a build fix after r247437
2901
2902         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
2903         Added platform guard towards -[WKUIDelegate _presentingViewControllerForWebView:].
2904
2905 2019-07-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2906
2907         [macOS 10.15] Cannot unbold selected text when the system font is used
2908         https://bugs.webkit.org/show_bug.cgi?id=199788
2909         <rdar://problem/52142570>
2910
2911         Reviewed by Tim Horton.
2912
2913         Add a new API test to verify that bolding and unbolding updates the
2914         shared font manager's selected font.
2915
2916         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
2917         (TestWebKitAPI::TEST):
2918
2919 2019-07-15  Jiewen Tan  <jiewen_tan@apple.com>
2920
2921         [iOS] SOAuthorizationSession should tell AppSSO whether the UIClient is capable of showing the extension UI
2922         https://bugs.webkit.org/show_bug.cgi?id=199790
2923         <rdar://problem/52790112>
2924
2925         Reviewed by Brent Fulgham.
2926
2927         Add tests to check SOAuthorization.enableEmbeddedAuthorizationViewController accordingly.
2928
2929         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
2930         (-[TestSOAuthorizationDelegate _presentingViewControllerForWebView:]):
2931         (configureSOAuthorizationWebView):
2932         (TestWebKitAPI::TEST):
2933         (-[TestSOAuthorizationNavigationDelegate init]): Deleted.
2934         (-[TestSOAuthorizationNavigationDelegate webView:didFinishNavigation:]): Deleted.
2935         (-[TestSOAuthorizationNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
2936         (-[TestSOAuthorizationNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]): Deleted.
2937         (-[TestSOAuthorizationNavigationDelegate _webView:decidePolicyForSOAuthorizationLoadWithCurrentPolicy:forExtension:completionHandler:]): Deleted.
2938
2939 2019-07-15  Sihui Liu  <sihui_liu@apple.com>
2940
2941         window.openDatabase is not writable
2942         https://bugs.webkit.org/show_bug.cgi?id=199737
2943         <rdar://problem/52551332>
2944
2945         Reviewed by Chris Dumez.
2946
2947         * TestWebKitAPI/Tests/WebKitCocoa/WebSQLBasics.mm:
2948         (TEST):
2949         * TestWebKitAPI/Tests/WebKitCocoa/opendatabase-always-exists.html:
2950
2951 2019-07-15  Aakash Jain  <aakash_jain@apple.com>
2952
2953         [ews-build] Parse and display layout test failures
2954         https://bugs.webkit.org/show_bug.cgi?id=199709
2955
2956         Rubber-stamped by Jonathan Bedard.
2957
2958         * BuildSlaveSupport/ews-build/steps.py:
2959         (RunWebKitTests.start): Initialize log_observer.
2960         (RunWebKitTests._strip_python_logging_prefix): Copied from similar code in build.webkit.org buildbot config.
2961         (RunWebKitTests._parseRunWebKitTestsOutput): Ditto.
2962         (RunWebKitTests.commandComplete): Gather and parse the stdout and stderr logs.
2963         (RunWebKitTests.evaluateResult): Analyze the results and decide build status.
2964         (RunWebKitTests.getResultSummary): Update build and step summary.
2965         * BuildSlaveSupport/ews-build/steps_unittest.py: Added and updated unit-tests.
2966
2967 2019-07-15  Commit Queue  <commit-queue@webkit.org>
2968
2969         Unreviewed, rolling out r247393.
2970         https://bugs.webkit.org/show_bug.cgi?id=199797
2971
2972         broke mips and arm EWS (Requested by guijemont on #webkit).
2973
2974         Reverted changeset:
2975
2976         "run-javascriptcore-tests won't report test results for
2977         testmasm, testair, testb3, testdfg and test api"
2978         https://bugs.webkit.org/show_bug.cgi?id=199489
2979         https://trac.webkit.org/changeset/247393
2980
2981 2019-07-12  Andy Estes  <aestes@apple.com>
2982
2983         [Cocoa] -loadFileURL:allowingReadAccessToURL: should fully resolve file URLs
2984         https://bugs.webkit.org/show_bug.cgi?id=199768
2985         <rdar://problem/52002206>
2986
2987         Reviewed by Geoffrey Garen.
2988
2989         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm:
2990         (TEST):
2991
2992 2019-07-12  Aakash Jain  <aakash_jain@apple.com>
2993
2994         [ews-build] Remove wincairo queue from old EWS and dashboard
2995         https://bugs.webkit.org/show_bug.cgi?id=199776
2996
2997         Reviewed by Don Olmstead.
2998
2999         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3000         * QueueStatusServer/config/queues.py:
3001
3002 2019-07-12  Aakash Jain  <aakash_jain@apple.com>
3003
3004         [ews-build] Enable wincairo queue on new EWS
3005         https://bugs.webkit.org/show_bug.cgi?id=199593
3006
3007         Reviewed by Don Olmstead.
3008
3009         * BuildSlaveSupport/ews-build/config.json: Enabled the triggers for wincairo builder.
3010         * BuildSlaveSupport/ews-build/factories.py: Added required build steps for wincairo factory.
3011         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3012         (StatusBubble): Enable wincairo status-bubble.
3013
3014 2019-07-12  Aakash Jain  <aakash_jain@apple.com>
3015
3016         [ews-app] Enable logging for clicking SubmitToEWS button
3017         https://bugs.webkit.org/show_bug.cgi?id=199757
3018
3019         Unreviewed minor infrastructure fix.
3020
3021         * BuildSlaveSupport/ews-app/ews/views/submittoews.py:
3022         (SubmitToEWS.post): Change logging level from debug to info.
3023
3024 2019-07-12  Alex Christensen  <achristensen@webkit.org>
3025
3026         Enable client certificate authentication unit test
3027         https://bugs.webkit.org/show_bug.cgi?id=199735
3028
3029         Reviewed by Chris Dumez.
3030
3031         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
3032         (TEST):
3033         I originally wrote this in https://bugs.webkit.org/show_bug.cgi?id=197800 but it was disabled because it crashed.
3034         I found what was crashing.  I was reading out of bounds on my vector of 2 strings :(
3035
3036 2019-07-12  Alex Christensen  <achristensen@webkit.org>
3037
3038         Begin unifying TestWebKitAPI build
3039         https://bugs.webkit.org/show_bug.cgi?id=199728
3040
3041         Reviewed by Keith Miller.
3042
3043         * TestWebKitAPI/Configurations/Base.xcconfig:
3044         * TestWebKitAPI/Scripts/generate-unified-sources.sh: Added.
3045         * TestWebKitAPI/Sources.txt: Added.
3046         * TestWebKitAPI/SourcesCocoa.txt: Added.
3047         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3048
3049 2019-07-12  Zhifei Fang  <zhifei_fang@apple.com>
3050
3051         run-javascriptcore-tests won't report test results for testmasm, testair, testb3, testdfg and test api
3052         https://bugs.webkit.org/show_bug.cgi?id=199489
3053         <rdar://problem/47891081>
3054
3055         Reviewed by Aakash Jain.
3056
3057         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3058         (RunJavaScriptCoreTests.countFailures):
3059         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3060         * Scripts/run-javascriptcore-tests:
3061         (runTest):
3062         (reportTestFailures):
3063         (runJSCStressTests):
3064
3065 2019-07-12  Aakash Jain  <aakash_jain@apple.com>
3066
3067         [ews-build] Make layout-tests' full_results.json accessible in Buildbot
3068         https://bugs.webkit.org/show_bug.cgi?id=199743
3069
3070         Reviewed by Jonathan Bedard.
3071
3072         * BuildSlaveSupport/ews-build/steps.py:
3073         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
3074
3075 2019-07-11  Aakash Jain  <aakash_jain@apple.com>
3076
3077         Unreviewed follow-up fix to r247364.
3078         [ews-build] Add build step to clean up .git/index.lock file
3079         https://bugs.webkit.org/show_bug.cgi?id=199722
3080
3081         * BuildSlaveSupport/ews-build/steps.py:
3082         (CheckOutSource): CheckOutSource should not haltOnFailure since CleanUpGitIndexLock step needs
3083         to be run after this step.
3084
3085 2019-07-11  Yusuke Suzuki  <ysuzuki@apple.com>
3086
3087         Flaky API Test TestWTF.bmalloc.ScavengedMemoryShouldBeReused
3088         https://bugs.webkit.org/show_bug.cgi?id=199524
3089         <rdar://problem/52783816>
3090
3091         Reviewed by Saam Barati.
3092
3093         This test is white-box one and it has strong assumption how IsoHeap allocates pages.
3094         But this test has several problems.
3095
3096         1. IsoPage::numObjects is not the exact number of how many we allocate objects. This
3097            number is calculated by pageSize / sizeof(T), and this does not account the header
3098            size of IsoPage. So, # of objects per IsoPage is less than numObjects. Since sizeof(double)
3099            is very small, we can have many objects in one IsoPage. As a result, we need a large
3100            bitmap in IsoPage. This reduces # of objects in IsoPage largely. So, `ptrs.size()` becomes
3101            less than numObjects.
3102
3103         2. We now have lower tier of allocation in IsoHeap. It means that we allocate 8 objects in
3104            shared page (page is shared, but memory is pinned for a specific type) before using IsoHeap's
3105            page. This also makes the intention of this test wrong.
3106
3107         Due to (1), we access OoB of ptrs vector, passing a garbage to IsoHeap::deallocate, and crashing.
3108
3109         We make this test robust while we still keep this test white-box one to test the critical feature
3110         of IsoHeap. We first exhaust lower tier of IsoHeap, and after that, start testing the memory. We
3111         allocate many pointers, deallocate them, allocate one pointer while keeping pointers in the lower
3112         tier live, and check whether the deallocated memory is reused.
3113
3114         * TestWebKitAPI/Tests/WTF/bmalloc/IsoHeap.cpp:
3115         (TEST):
3116
3117 2019-07-11  Pablo Saavedra  <psaavedra@igalia.com>
3118
3119         [WPE][GTK] Build failure with ENABLE_ACCESSIBILITY=OFF
3120         https://bugs.webkit.org/show_bug.cgi?id=199625
3121
3122         Added ENABLE(ACCESSIBILITY) and replaced HAVE(ACCESSIBILITY)
3123         with ENABLE(ACCESSIBILITY) in the code.
3124
3125         Additionally, the TestRunner code generator now honors the
3126         Conditional IDL format.
3127
3128         Reviewed by Konstantin Tokarev.
3129
3130         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
3131         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp:
3132         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp:
3133         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3134         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
3135         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarker.idl:
3136         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarkerRange.idl:
3137         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3138         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
3139         (_generateImplementationFile):
3140
3141 2019-07-11  Aakash Jain  <aakash_jain@apple.com>
3142
3143         [ews-build] Add build step to clean up .git/index.lock file
3144         https://bugs.webkit.org/show_bug.cgi?id=199722
3145
3146         Reviewed by Jonathan Bedard.
3147
3148         * BuildSlaveSupport/ews-build/steps.py:
3149         (CheckOutSource.getResultSummary): Run CleanUpGitIndexLock step when CheckOutSource fails.
3150         (CleanUpGitIndexLock.__init__): Configure timeout and logEnviron.
3151         (CleanUpGitIndexLock.evaluateCommand): Always RETRY the build after this step is run.
3152         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
3153
3154 2019-07-11  Jonathan Bedard  <jbedard@apple.com>
3155
3156         [iOS 13] Enable WebKit build
3157         https://bugs.webkit.org/show_bug.cgi?id=199481
3158         <rdar://problem/52619048>
3159
3160         Reviewed by Tim Horton.
3161
3162         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig: Add iOS framework stubs.
3163
3164 2019-07-11  Ryan Haddad  <ryanhaddad@apple.com>
3165
3166         Add test expectations and baselines for iOS 13
3167         https://bugs.webkit.org/show_bug.cgi?id=199329
3168
3169         Reviewed by Jonathan Bedard.
3170
3171         * Scripts/webkitpy/port/ios.py:
3172         (IOSPort): Increment current version to 13.
3173         * Scripts/webkitpy/port/ios_device_unittest.py: Update unit tests.
3174         (IOSDeviceTest.test_layout_test_searchpath_with_apple_additions):
3175         (IOSDeviceTest.test_layout_test_searchpath_without_apple_additions):
3176         (IOSDeviceTest.test_layout_searchpath_wih_device_type):
3177         * Scripts/webkitpy/port/ios_simulator_unittest.py: Ditto.
3178         (IOSSimulatorTest.make_port):
3179         (IOSSimulatorTest.test_layout_test_searchpath_with_apple_additions):
3180         (IOSSimulatorTest.test_layout_test_searchpath_without_apple_additions):
3181         (IOSSimulatorTest.test_layout_searchpath_wih_device_type):
3182         * Scripts/webkitpy/port/ios_testcase.py: Ditto.
3183         (IOSTest.make_port):
3184
3185 2019-07-11  Joanmarie Diggs  <jdiggs@igalia.com>
3186
3187         AX: Implement support for ARIA roles insertion, deletion, subscript, superscript, and time
3188         https://bugs.webkit.org/show_bug.cgi?id=199692
3189
3190         Reviewed by Chris Fleizach.
3191
3192         Add support for output of AXDeletion and AXInsertion roles for tests.
3193         Update GTK and WPE jhbuild modules to use version of ATK and AT-SPI2
3194         which include ROLE_CONTENT_DELETION and ROLE_CONTENT_INSERTION.
3195
3196         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3197         * gtk/jhbuild.modules:
3198         * wpe/jhbuild.modules:
3199
3200 2019-07-11  Adrian Perez de Castro  <aperez@igalia.com>
3201
3202         [ews-build] Remove workers {ltilve,tanty}-gtk-wk2-ews from configuration
3203         https://bugs.webkit.org/show_bug.cgi?id=199707
3204
3205         Reviewed by Aakash Jain.
3206
3207         * BuildSlaveSupport/ews-build/config.json: Remove old unused workers.
3208
3209 2019-07-10  Simon Fraser  <simon.fraser@apple.com>
3210
3211         [iOS WK2] With modal overlay and body overflow:hidden, can't access all the content
3212         https://bugs.webkit.org/show_bug.cgi?id=199693
3213         rdar://problem/51930364
3214
3215         Reviewed by Tim Horton.
3216
3217         New API tests that test scrollability with various combinations of content, insets,
3218         input accessory bars etc.
3219
3220         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3221         * TestWebKitAPI/Tests/ios/ScrollViewScrollabilityTests.mm: Added.
3222         (TestWebKitAPI::webViewWithAutofocusedInput):
3223         (TestWebKitAPI::TEST):
3224
3225 2019-07-10  Tim Horton  <timothy_horton@apple.com>
3226
3227         Long pressing on attachments will crash the WebContent process
3228         https://bugs.webkit.org/show_bug.cgi?id=199696
3229         <rdar://problem/52920241>
3230
3231         Reviewed by Dean Jackson.
3232
3233         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
3234         (TestWebKitAPI::TEST):
3235         Add a test that previously crashed.
3236
3237 2019-07-10  Dean Jackson  <dino@apple.com>
3238
3239         Support MacCatalyst in run-webkit-app
3240         https://bugs.webkit.org/show_bug.cgi?id=199690
3241
3242         Reviewed by Tim Horton.
3243
3244         Add a --maccatalyst option to run-webkit-app that
3245         can launch MacCatalyst applications with a built WebKit.
3246
3247         * Scripts/webkitdirs.pm:
3248         (argumentsForConfiguration):
3249         (determineXcodeSDK):
3250         (xcodeSDKPlatformName):
3251         (determineConfigurationProductDir):
3252         (determinePortName):
3253         (isCatalystWebKit):
3254         (isAppleCocoaWebKit):
3255         (willUseCatalystSDK):
3256
3257 2019-07-10  Ryan Haddad  <ryanhaddad@apple.com>
3258
3259         [MacOS] Filter VPA info logged to stdout
3260         https://bugs.webkit.org/show_bug.cgi?id=199673
3261
3262         Reviewed by Eric Carlson.
3263
3264         * Scripts/webkitpy/port/mac.py:
3265         (MacPort.logging_patterns_to_strip):
3266
3267 2019-07-10  Ryan Haddad  <ryanhaddad@apple.com>
3268
3269         Unreviewed, rolling out r247286.
3270
3271         Caused TestWTF.WTF.StringOperators to fail on debug bots
3272
3273         Reverted changeset:
3274
3275         "Add StringBuilder member function which allows makeString()
3276         style variadic argument construction"
3277         https://bugs.webkit.org/show_bug.cgi?id=198997
3278         https://trac.webkit.org/changeset/247286
3279
3280 2019-07-10  Aakash Jain  <aakash_jain@apple.com>
3281
3282         [ews-build] Explicitly use perl or python while invoking scripts
3283         https://bugs.webkit.org/show_bug.cgi?id=199669
3284
3285         Reviewed by Jonathan Bedard.
3286
3287         * BuildSlaveSupport/ews-build/steps.py: Explicitly added perl or python while invoking scripts.
3288         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests accordingly.
3289
3290 2019-07-10  Guillaume Emont  <guijemont@igalia.com>
3291
3292         Run tests on mips EWS
3293         https://bugs.webkit.org/show_bug.cgi?id=196854
3294
3295         Reviewed by Carlos Garcia Campos.
3296
3297         * Scripts/webkitpy/common/config/ews.json:
3298
3299 2019-07-09  Michael Catanzaro  <mcatanzaro@igalia.com>
3300
3301         [WPE][GTK] GUniqueOutPtr::release should return a raw pointer
3302         https://bugs.webkit.org/show_bug.cgi?id=199579
3303
3304         Reviewed by Carlos Garcia Campos.
3305
3306         * TestWebKitAPI/Tests/WTF/glib/GUniquePtr.cpp:
3307         (TestWebKitAPI::TEST):
3308
3309 2019-07-09  Chris Dumez  <cdumez@apple.com>
3310
3311         Fix integer type encoding / decoding in WKRemoteObjectCoder
3312         https://bugs.webkit.org/show_bug.cgi?id=199643
3313         <rdar://problem/52732342>
3314
3315         Reviewed by Anders Carlsson.
3316
3317         Update API test coverage.
3318
3319         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.h:
3320         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.mm:
3321         (TEST):
3322         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistryPlugIn.mm:
3323         (-[RemoteObjectRegistryPlugIn takeUnsignedLongLong:completionHandler:]):
3324         (-[RemoteObjectRegistryPlugIn takeLongLong:completionHandler:]):
3325         (-[RemoteObjectRegistryPlugIn takeUnsignedLong:completionHandler:]):
3326         (-[RemoteObjectRegistryPlugIn takeLong:completionHandler:]):
3327
3328 2019-07-09  Sam Weinig  <weinig@apple.com>
3329
3330         Add StringBuilder member function which allows makeString() style variadic argument construction
3331         https://bugs.webkit.org/show_bug.cgi?id=198997
3332
3333         Reviewed by Darin Adler.
3334
3335         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
3336         Add basic test showing that StringBuilder::flexibleAppend can be used to
3337         append one or more string adaptable types.
3338
3339 2019-07-09  Sihui Liu  <sihui_liu@apple.com>
3340
3341         Only allow fetching and removing session credentials from WebsiteDataStore
3342         https://bugs.webkit.org/show_bug.cgi?id=199385
3343         <rdar://problem/52622080>
3344
3345         Reviewed by Alex Christensen.
3346
3347         removeDataOfTypes will no longer remove persistent credentials. We should clear persistent credentials using
3348         the new SPI after each test that creates persistent credentials, otherwise the later tests may use credentials
3349         left by previous tests and didReceiveAuthenticationChallenge will not be invoked.
3350
3351         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
3352         (TEST):
3353         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
3354         (TestWebKitAPI::TEST):
3355
3356 2019-07-09  Alex Christensen  <achristensen@webkit.org>
3357
3358         When parsing an IPv4 address, wait until after deciding it is indeed an IPv4 address before reporting syntax violations
3359         https://bugs.webkit.org/show_bug.cgi?id=199628
3360
3361         Reviewed by Brady Eidson.
3362
3363         * TestWebKitAPI/Tests/WTF/URLParser.cpp:
3364         (TestWebKitAPI::TEST_F):
3365
3366 2019-07-09  Alex Christensen  <achristensen@webkit.org>
3367
3368         Remove invalid assertion in URLParser::domainToASCII
3369         https://bugs.webkit.org/show_bug.cgi?id=199624
3370
3371         Reviewed by Brady Eidson.
3372
3373         * TestWebKitAPI/Tests/WTF/URLParser.cpp:
3374         (TestWebKitAPI::TEST_F):
3375
3376 2019-07-09  Alex Christensen  <achristensen@webkit.org>
3377
3378         URLParser should reserialize IPv6 addresses that end with a colon
3379         https://bugs.webkit.org/show_bug.cgi?id=199627
3380
3381         Reviewed by Brady Eidson.
3382
3383         * TestWebKitAPI/Tests/WTF/URLParser.cpp:
3384         (TestWebKitAPI::TEST_F):
3385
3386 2019-07-08  Aakash Jain  <aakash_jain@apple.com>
3387
3388         [ews-build] Do not run unix commands for windows in PrintConfiguration
3389         https://bugs.webkit.org/show_bug.cgi?id=199605
3390
3391         Reviewed by Jonathan Bedard.
3392
3393         * BuildSlaveSupport/ews-build/steps.py:
3394
3395 2019-07-08  Fujii Hironori  <Hironori.Fujii@sony.com>
3396
3397         JSTestGlobalObject.cpp of bindings-generation-tests is failing for Windows Python
3398         https://bugs.webkit.org/show_bug.cgi?id=199487
3399
3400         Reviewed by Ross Kirsling.
3401
3402         In Windows Python, preprocessor.pm is using cl.exe. cl.exe was
3403         failing to open testglobalscope_constructors_file which was
3404         created by using tempfile.mkstemp() because it keeps the file
3405         open. Use tempfile.mkdtemp() to create temporary files in the
3406         temporary directory instead of tempfile.mkstemp().
3407
3408         * Scripts/webkitpy/bindings/main.py:
3409         (BindingsTests.run_tests):
3410         (BindingsTests.main):
3411         (BindingsTests.close_and_remove): Deleted.
3412
3413 2019-07-08  Aakash Jain  <aakash_jain@apple.com>
3414
3415         [ews-build] Add KillOldProcesses step before running API or Layout tests
3416         https://bugs.webkit.org/show_bug.cgi?id=199592
3417
3418         Reviewed by Jonathan Bedard.
3419
3420         * BuildSlaveSupport/ews-build/factories.py:
3421
3422 2019-07-08  Jonathan Bedard  <jbedard@apple.com>
3423
3424         test-webkitpy: Explicitly use Python 2.7 lldb library
3425         https://bugs.webkit.org/show_bug.cgi?id=199578
3426         <rdar://problem/51853557>
3427
3428         Reviewed by Aakash Jain.
3429
3430         * Scripts/webkitpy/common/system/systemhost.py:
3431         (SystemHost.path_to_lldb_python_directory): Explicitly use Python 2.7 lldb libary.
3432         * Scripts/webkitpy/test/main.py:
3433         (_supports_building_and_running_lldb_tests): Run lldb tests on Catalina again.
3434
3435 2019-07-08  Ryan Haddad  <ryanhaddad@apple.com>
3436
3437         Add test expectations and baselines for Catalina
3438         https://bugs.webkit.org/show_bug.cgi?id=199328
3439
3440         Reviewed by Jonathan Bedard.
3441
3442         * Scripts/webkitpy/port/mac.py:
3443         (MacPort): Increment current version to 10.15 so that baseline search paths are correctly constructed for High Sierra.
3444
3445 2019-07-08  Christopher Reid  <chris.reid@sony.com>
3446
3447         Implement MappedFileData for Windows
3448         https://bugs.webkit.org/show_bug.cgi?id=198269
3449
3450         Reviewed by Darin Adler.
3451
3452         * TestWebKitAPI/PlatformWin.cmake:
3453
3454 2019-07-08  Charlie Turner  <cturner@igalia.com>
3455
3456         REGRESSION(r243197): [GStreamer] Web process hangs when scrolling twitter timeline which contains HLS videos
3457         https://bugs.webkit.org/show_bug.cgi?id=197558
3458
3459         Reviewed by Xabier Rodriguez-Calvar.
3460
3461         On shutdown we can easily deadlock the web process if we don't
3462         ensure all network operations are completed before comitting state
3463         changes. In HLS, make sure the network operations are cancelled,
3464         and also prevent hlsdemux's retry logic from scuppering our
3465         efforts.
3466
3467         * gstreamer/jhbuild.modules: Include the patch.
3468         * gstreamer/patches/gst-plugins-bad-do-not-retry-downloads-during-shutdown.patch: Added.
3469
3470 2019-07-08  Antoine Quint  <graouts@apple.com>
3471
3472         [Pointer Events] Enable only on the most recent version of the supported iOS family
3473         https://bugs.webkit.org/show_bug.cgi?id=199562
3474         <rdar://problem/52766511>
3475
3476         Reviewed by Dean Jackson.
3477
3478         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3479
3480 2019-07-06  Simon Fraser  <simon.fraser@apple.com>
3481
3482         Long hang when loading a cnn.com page on iOS
3483         https://bugs.webkit.org/show_bug.cgi?id=199556
3484
3485         Reviewed by Zalan Bujtas.
3486
3487         Add code to load a page by default in MobileMiniBrowser so it's easy to hack it
3488         to load a test page of your choice.
3489
3490         * MobileMiniBrowser/MobileMiniBrowserFramework/WebViewController.m:
3491         (-[WebViewController viewDidLoad]):
3492
3493 2019-07-05  Ryosuke Niwa  <rniwa@webkit.org>
3494
3495         [iOS] Crash in WebKit::WebPage::positionInformation via Range::startPosition
3496         https://bugs.webkit.org/show_bug.cgi?id=199503
3497
3498         Reviewed by Wenson Hsieh.
3499
3500         Added UIScriptController.ensurePositionInformationIsUpToDateAt using the existing WKWebView SPI:
3501         _requestActivatedElementAtPosition
3502
3503         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3504         (WTR::UIScriptController::ensurePositionInformationIsUpToDateAt):
3505         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3506         (WTR::UIScriptController::ensurePositionInformationIsUpToDateAt):
3507         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3508         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3509         (WTR::UIScriptController::ensurePositionInformationIsUpToDateAt):
3510         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3511         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3512         (WTR::UIScriptController::ensurePositionInformationIsUpToDateAt):
3513         * WebKitTestRunner/ios/UIScriptControllerMac.mm:
3514         (WTR::UIScriptController::ensurePositionInformationIsUpToDateAt):
3515
3516 2019-07-05  Ryan Haddad  <ryanhaddad@apple.com>
3517
3518         Unreviewed, rolling out r247115.
3519
3520         Breaks lldbWebKitTester (and by extension, test-webkitpy)
3521
3522         Reverted changeset:
3523
3524         "[WHLSL] Standard library is too big to directly include in
3525         WebCore"
3526         https://bugs.webkit.org/show_bug.cgi?id=198186
3527         https://trac.webkit.org/changeset/247115
3528
3529 2019-07-05  Ryan Haddad  <ryanhaddad@apple.com>
3530
3531         Unreviewed, rolling out r247123.
3532
3533         Caused TestWebKitAPI.Challenge.BasicProposedCredential to
3534         fail.
3535
3536         Reverted changeset:
3537
3538         "Only allow fetching and removing session credentials from
3539         WebsiteDataStore"
3540         https://bugs.webkit.org/show_bug.cgi?id=199385
3541         https://trac.webkit.org/changeset/247123
3542
3543 2019-07-05  Wenson Hsieh  <wenson_hsieh@apple.com>
3544
3545         Touching media controls sometimes shows software keyboard
3546         https://bugs.webkit.org/show_bug.cgi?id=199490
3547         <rdar://problem/52076270>
3548
3549         Reviewed by Eric Carlson.
3550
3551         Adds plumbing for a new testing hook to check whether or not there is an active input session. See other
3552         ChangeLog entries for more detail.
3553
3554         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3555         (WTR::UIScriptController::hasInputSession const):
3556         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3557         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3558         (WTR::UIScriptController::hasInputSession const):
3559         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3560         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3561         (WTR::UIScriptController::hasInputSession const):
3562
3563 2019-07-04  Aakash Jain  <aakash_jain@apple.com>
3564
3565         [ews-build] Remove GTK and WPE queue from old EWS and dashboard
3566         https://bugs.webkit.org/show_bug.cgi?id=199458
3567
3568         Reviewed by Michael Catanzaro.
3569
3570         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3571         * QueueStatusServer/config/queues.py:
3572
3573 2019-07-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3574
3575         [GTK] Fix browserperfdash script after r239522
3576         https://bugs.webkit.org/show_bug.cgi?id=199496
3577
3578         Reviewed by Michael Catanzaro.
3579
3580         * Scripts/webkitpy/browserperfdash/browserperfdash_runner.py:
3581         (BrowserPerfDashRunner.run): Pass None for the new required BenchmarkRunner constructor.
3582
3583 2019-07-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3584
3585         [webkitpy] test-webkitpy is broken on Linux since r246662
3586         https://bugs.webkit.org/show_bug.cgi?id=199493
3587
3588         Reviewed by Michael Catanzaro.
3589
3590         * Scripts/webkitpy/test/main.py:
3591         (_supports_building_and_running_lldb_tests): Add a check for None before calling startswith().
3592
3593 2019-07-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3594
3595         [GTK][WPE] Not longer needed to build woff2 on the JHBuild
3596         https://bugs.webkit.org/show_bug.cgi?id=199406
3597
3598         Reviewed by Michael Catanzaro.
3599
3600         Install the Woff2 libraries and headers from the system package
3601         and stop building them on the JHBuild.
3602
3603         * gtk/install-dependencies:
3604         * gtk/jhbuild.modules:
3605         * wpe/install-dependencies:
3606         * wpe/jhbuild.modules:
3607
3608 2019-07-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3609
3610         [GTK][WPE][CMake] The CMake cache should be clean when the JHBuild is rebuilt
3611         https://bugs.webkit.org/show_bug.cgi?id=199449
3612
3613         Reviewed by Michael Catanzaro.
3614
3615         * Scripts/webkitdirs.pm:
3616         (shouldRemoveCMakeCache): Clean the CMake cache if we detect that the JHBuild has been rebuilt.
3617
3618 2019-07-01  Philippe Normand  <pnormand@igalia.com>
3619
3620         Unreviewed, GTK a11y tests fix after r247071
3621
3622         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3623         (WTR::AccessibilityUIElement::popupValue const):
3624
3625 2019-07-03  Aakash Jain  <aakash_jain@apple.com>
3626
3627         [ews-build] Enable WPE and GTK queues on new EWS
3628         https://bugs.webkit.org/show_bug.cgi?id=199234
3629
3630         Reviewed by Jonathan Bedard.
3631
3632         * BuildSlaveSupport/ews-build/config.json: Enabled the triggers for GTK and WPE builders.
3633         * BuildSlaveSupport/ews-build/factories.py: Added required build steps for GTKFactory and WPEFactory.
3634         * BuildSlaveSupport/ews-build/steps.py:
3635         (CompileWebKit.evaluateCommand): Added InstallGtkDependencies/InstallWpeDependencies step before Compiling WebKit without patch.
3636         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
3637         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3638         (StatusBubble): Enable gtk and wpe status-bubbles.
3639
3640 2019-07-03  Sihui Liu  <sihui_liu@apple.com>
3641
3642         Only allow fetching and removing session credentials from WebsiteDataStore
3643         https://bugs.webkit.org/show_bug.cgi?id=199385
3644
3645         Reviewed by Alex Christensen.
3646
3647         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
3648         (TestWebKitAPI::TEST):
3649
3650 2019-07-03  Tim Horton  <timothy_horton@apple.com>
3651
3652         UI process exception when dragging an <attachment> with no content type
3653         https://bugs.webkit.org/show_bug.cgi?id=199480
3654         <rdar://problem/44351353>
3655
3656         Reviewed by Wenson Hsieh.
3657
3658         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3659         (TestWebKitAPI::TEST):
3660         Add a test; before the change, it crashes.
3661
3662 2019-07-03  Jonathan Bedard  <jbedard@apple.com>
3663
3664         [Catalina] Enable WebKit build
3665         https://bugs.webkit.org/show_bug.cgi?id=199209
3666
3667         Reviewed by Darin Adler.
3668
3669         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig: Add Mac framework stubs.
3670
3671 2019-07-03  Sam Weinig  <weinig@apple.com>
3672
3673         Adopt simple structured bindings in more places
3674         https://bugs.webkit.org/show_bug.cgi?id=199247
3675
3676         Reviewed by Alex Christensen.
3677
3678         Replaces simple uses of std::tie() with structured bindings. Does not touch
3679         uses of std::tie() that are not initial declarations, use std::ignore or in
3680         case where the binding is captured by a lambda, as structured bindings don't
3681         work for those cases yet.
3682
3683         * TestWebKitAPI/ios/PreferredContentMode.mm:
3684         (TestWebKitAPI::TEST):
3685
3686 2019-07-03  Aakash Jain  <aakash_jain@apple.com>
3687
3688         Unreviewed follow-up fix to r247049, default the platform to '*' when platform property is not set.
3689
3690         * BuildSlaveSupport/ews-build/steps.py:
3691         (PrintConfiguration.run):
3692
3693 2019-07-02  Aakash Jain  <aakash_jain@apple.com>
3694
3695         [ews-build] Add build steps to Install Wpe and Gtk dependencies
3696         https://bugs.webkit.org/show_bug.cgi?id=199408
3697
3698         Reviewed by Michael Catanzaro.
3699
3700         * BuildSlaveSupport/ews-build/steps.py:
3701         (InstallGtkDependencies): Build step to install dependencies for GTK. Set haltOnFailure=False so that in case of failure, build isn't
3702         marked as failed (which would indicated patch failed EWS), instead subsequent steps would be run and the build would be marked as RETRY.
3703         (InstallWpeDependencies): Ditto for WPE.
3704         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
3705
3706 2019-07-02  Aakash Jain  <aakash_jain@apple.com>
3707
3708         [ews-build] Allow skipping uploading built product for few builders
3709         https://bugs.webkit.org/show_bug.cgi?id=199422
3710
3711         Reviewed by Michael Catanzaro.
3712
3713         * BuildSlaveSupport/ews-build/steps.py:
3714         (CompileWebKit.__init__): Added optional skipUpload parameter.
3715         (CompileWebKit.evaluateCommand): Allow to skip upload if there are no triggers and skipUpload is True.
3716
3717 2019-07-02  Tim Horton  <timothy_horton@apple.com>
3718
3719         REGRESSION (r243240): Unable to swipe back in Safari
3720         https://bugs.webkit.org/show_bug.cgi?id=199394
3721         <rdar://problem/51137447>
3722
3723         Reviewed by Wenson Hsieh.
3724
3725         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3726         Make sure that we actually end up with swipe gesture recognizers installed
3727         after process swap and crash.
3728
3729 2019-07-02  Andres Gonzalez  <andresg_22@apple.com>
3730
3731         Enhance support of aria-haspopup per ARIA 1.1 specification.
3732         https://bugs.webkit.org/show_bug.cgi?id=199216
3733         <rdar://problem/46221342>
3734
3735         Reviewed by Chris Fleizach.
3736
3737         * DumpRenderTree/AccessibilityUIElement.cpp:
3738         (getPopupValueCallback):
3739         (AccessibilityUIElement::getJSClass):
3740         * DumpRenderTree/AccessibilityUIElement.h:
3741         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3742         (AccessibilityUIElement::popupValue const):
3743         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3744         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3745         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3746         (WTR::AccessibilityUIElement::popupValue const):
3747         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3748         (WTR::AccessibilityUIElement::popupValue const):
3749
3750 2019-07-02  Aakash Jain  <aakash_jain@apple.com>
3751
3752         [ews-build] Do not print worker environment variables in each build step [part 2]
3753         https://bugs.webkit.org/show_bug.cgi?id=199405
3754
3755         Reviewed by Jonathan Bedard.
3756
3757         * BuildSlaveSupport/ews-build/steps.py:
3758         (CheckOutSpecificRevision.__init__): Disabled logging of environment variables.
3759         (CleanWorkingDirectory.__init__): Ditto.
3760         (RunBindingsTests.__init__): Ditto.
3761         (RunWebKitPerlTests.__init__): Ditto.
3762         (RunWebKitPyTests.__init__): Ditto.
3763         (CompileWebKit.__init__): Ditto.
3764         (ArchiveTestResults.__init__): Ditto.
3765         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
3766
3767 2019-07-02  Jer Noble  <jer.noble@apple.com>
3768
3769         Pipe suport for 'cenc' init data type into CDMFairPlayStreaming
3770         https://bugs.webkit.org/show_bug.cgi?id=199381
3771         <rdar://problem/52483103>
3772
3773         Reviewed by Eric Carlson.
3774
3775         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp:
3776
3777 2019-07-02  Aakash Jain  <aakash_jain@apple.com>
3778
3779         [ews-build] Update bot configuration for WPE and GTK
3780         https://bugs.webkit.org/show_bug.cgi?id=199238
3781
3782         Reviewed by Michael Catanzaro.
3783
3784         * BuildSlaveSupport/ews-build/config.json:
3785
3786 2019-07-02  Aakash Jain  <aakash_jain@apple.com>
3787
3788         [ews-build] Make PrintConfiguration platform aware
3789         https://bugs.webkit.org/show_bug.cgi?id=196657
3790
3791         Reviewed by Lucas Forschler.
3792
3793         * BuildSlaveSupport/ews-build/steps.py:
3794         (PrintConfiguration): Specified platform-specific command lists.
3795         (PrintConfiguration.run): Override run method and specify platform specific commands.
3796         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
3797
3798 2019-07-01  Justin Michaud  <justin_michaud@apple.com>
3799
3800         [Wasm-References] Disable references by default
3801         https://bugs.webkit.org/show_bug.cgi?id=199390
3802
3803         Reviewed by Saam Barati.
3804
3805         * Scripts/run-jsc-stress-tests:
3806
3807 2019-07-01  Joonghun Park  <pjh0718@gmail.com>
3808
3809         Unreviewed. Revert r246965 to fix build break
3810         since r247019 reverted its related changes.
3811
3812         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3813         (WTR::AccessibilityUIElement::popupValue const): Deleted.
3814
3815 2019-07-01  Alex Christensen  <achristensen@webkit.org>
3816
3817         Add new decidePolicyForNavigationAction SPI with preferences and userInfo
3818         https://bugs.webkit.org/show_bug.cgi?id=199371
3819         <rdar://problem/52352905>
3820
3821         Reviewed by Tim Horton.
3822
3823         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
3824         (-[NavigationActionSPIDelegate webView:didFinishNavigation:]):
3825         (-[NavigationActionSPIDelegate _webView:decidePolicyForNavigationAction:preferences:userInfo:decisionHandler:]):
3826         (-[NavigationActionSPIDelegate spiCalled]):
3827         (TEST):
3828
3829 2019-07-01  Alex Christensen  <achristensen@webkit.org>
3830
3831         Deprecate _webView:showCustomSheetForElement: after transition to UIContextMenuInteraction
3832         https://bugs.webkit.org/show_bug.cgi?id=199296
3833         <rdar://problem/51041960>
3834
3835         Reviewed by Darin Adler.
3836
3837         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
3838         (-[DragAndDropSimulator _webView:showCustomSheetForElement:]):
3839
3840 2019-07-01  Truitt Savell  <tsavell@apple.com>
3841
3842         Unreviewed, rolling out r246958.
3843
3844         Broke inspector/dom/getAccessibilityPropertiesForNode.html
3845
3846         Reverted changeset:
3847
3848         "Enhance support of aria-haspopup per ARIA 1.1 specification."
3849         https://bugs.webkit.org/show_bug.cgi?id=199216
3850         https://trac.webkit.org/changeset/246958
3851
3852 2019-07-01  Philippe Normand  <pnormand@igalia.com>
3853
3854         Unreviewed, GTK a11y tests fix after r246958
3855
3856         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3857         (WTR::AccessibilityUIElement::popupValue const):
3858
3859 2019-06-30  Andres Gonzalez  <andresg_22@apple.com>
3860
3861         Enhance support of aria-haspopup per ARIA 1.1 specification.
3862         https://bugs.webkit.org/show_bug.cgi?id=199216
3863         <rdar://problem/46221342>
3864
3865         Reviewed by Chris Fleizach.
3866
3867         * DumpRenderTree/AccessibilityUIElement.cpp:
3868         (getPopupValueCallback):
3869         (AccessibilityUIElement::getJSClass):
3870         * DumpRenderTree/AccessibilityUIElement.h:
3871         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3872         (AccessibilityUIElement::popupValue const):
3873         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3874         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3875         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3876         (WTR::AccessibilityUIElement::popupValue const):
3877         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3878         (WTR::AccessibilityUIElement::popupValue const):
3879
3880 2019-06-28  Robin Morisset  <rmorisset@apple.com>
3881
3882         Adding myself as a reviewer to contributors.json.
3883
3884         Unreviewed.
3885
3886         * Scripts/webkitpy/common/config/contributors.json:
3887
3888 2019-06-28  Jer Noble  <jer.noble@apple.com>
3889
3890         Add new -[WKWebView _closeAllMediaPresentations] SPI
3891         https://bugs.webkit.org/show_bug.cgi?id=199294
3892         <rdar://problem/51965958>
3893
3894         Reviewed by Alex Christensen.
3895
3896         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3897         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewCloseAllMediaPresentations.mm: Added.
3898         (TEST):
3899
3900 2019-06-28  Sihui Liu  <sihui_liu@apple.com>
3901
3902         Add a regression test for change r246901
3903         https://bugs.webkit.org/show_bug.cgi?id=199290
3904
3905         Reviewed by Geoffrey Garen.
3906
3907         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3908         * TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm:
3909         (-[LocalStorageNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3910         (TEST):
3911         * TestWebKitAPI/Tests/WebKitCocoa/localstorage-open-window-private.html: Added.
3912
3913 2019-06-28  Konstantin Tokarev  <annulen@yandex.ru>
3914
3915         Remove traces of ENABLE_ICONDATABASE remaining after its removal in 219733
3916         https://bugs.webkit.org/show_bug.cgi?id=199317
3917
3918         Reviewed by Michael Catanzaro.
3919
3920         While IconDatabase and all code using it was removed,
3921         ENABLE_ICONDATABASE still exists as build option and C++ macro.
3922
3923         * Scripts/webkitperl/FeatureList.pm:
3924         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3925         * gtk/manifest.txt.in: Remove reference to unused urlIcon.png file.
3926         * wpe/manifest.txt.in: Remove reference to unused urlIcon.png file.
3927
3928 2019-06-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3929
3930         -[WKContentView _selectionClipRects] returns a bogus value in -reloadInputViews when focusing an element
3931         https://bugs.webkit.org/show_bug.cgi?id=199310
3932         <rdar://problem/52292137>
3933
3934         Reviewed by Megan Gardner.
3935
3936         Add a new API test to verify that _selectionClipRects returns the correct value when invoked under the scope of
3937         _elementDidFocus.
3938
3939         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3940         (TestWebKitAPI::TEST):
3941         * TestWebKitAPI/Tests/ios/TestInputDelegate.h:
3942         * TestWebKitAPI/Tests/ios/TestInputDelegate.mm:
3943         (-[TestInputDelegate setDidStartInputSessionHandler:]):
3944         (-[TestInputDelegate didStartInputSessionHandler]):
3945
3946         Add plumbing for a handler block in TestInputDelegate.
3947
3948         (-[TestInputDelegate setWillStartInputSessionHandler:]):
3949
3950         Drive-by style fixes to add a space between id and < for Objective-C protocols.
3951
3952         (-[TestInputDelegate willStartInputSessionHandler]):
3953         (-[TestInputDelegate _webView:willStartInputSession:]):
3954         (-[TestInputDelegate _webView:didStartInputSession:]):
3955         * TestWebKitAPI/cocoa/TestWKWebView.h:
3956         * TestWebKitAPI/ios/UIKitSPI.h:
3957
3958         Add a declaration for _selectionClipRects.
3959
3960 2019-06-27  Zalan Bujtas  <zalan@apple.com>
3961
3962         REGRESSION(r244633): e-mail with "height: 100%" causes unstable layout.
3963         https://bugs.webkit.org/show_bug.cgi?id=199303
3964         <rdar://problem/51340927>
3965
3966         Reviewed by Tim Horton.
3967
3968         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
3969         (TEST):
3970
3971 2019-06-27  Beth Dakin  <bdakin@apple.com>
3972
3973         Upstream use of MACCATALYST
3974         https://bugs.webkit.org/show_bug.cgi?id=199245
3975         rdar://problem/51687723
3976
3977         Reviewed by Tim Horton.
3978
3979         * ContentExtensionTester/Configurations/SDKVariant.xcconfig:
3980         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig:
3981         * ImageDiff/cg/Configurations/SDKVariant.xcconfig:
3982         * MiniBrowser/Configurations/SDKVariant.xcconfig:
3983         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig:
3984         * Scripts/webkitpy/generate_xcfilelists_lib/generators.py:
3985         (JavaScriptCoreGenerator):
3986         (WebCoreGenerator):
3987         (WebKitGenerator):
3988         * TestWebKitAPI/Configurations/Base.xcconfig:
3989         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3990         * TestWebKitAPI/Configurations/SDKVariant.xcconfig:
3991         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3992         * WebEditingTester/Configurations/SDKVariant.xcconfig:
3993         * WebKitLauncher/Configurations/SDKVariant.xcconfig:
3994         * WebKitTestRunner/Configurations/SDKVariant.xcconfig:
3995         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig:
3996
3997 2019-06-27  Saam Barati  <sbarati@apple.com>
3998
3999         Make WEBGPU enabled only on Mojave and later.
4000
4001         Rubber-stamped by Myles C. Maxfield.
4002
4003         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4004
4005 2019-06-27  Aakash Jain  <aakash_jain@apple.com>
4006
4007         [ews-build] Do not print worker environment variables in each build step
4008         https://bugs.webkit.org/show_bug.cgi?id=197319
4009
4010         Reviewed by Lucas Forschler.
4011
4012         * BuildSlaveSupport/ews-build/steps.py:
4013         (CheckOutSource.__init__): Disabled logging of environment variables.
4014         (ApplyPatch.__init__): Ditto.
4015         (KillOldProcesses.__init__): Ditto.
4016         (ArchiveBuiltProduct.__init__): Ditto.
4017         (DownloadBuiltProduct.__init__): Ditto.
4018         (ExtractBuiltProduct.__init__): Ditto.
4019         (RunAPITests.__init__): Ditto.
4020         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests accordingly.
4021
4022 2019-06-26  Jiewen Tan  <jiewen_tan@apple.com>
4023
4024         SubFrameSOAuthorizationSession should preserve the referrer header when fall back to web path
4025         https://bugs.webkit.org/show_bug.cgi?id=199232
4026         <rdar://problem/51718328>
4027
4028         Reviewed by Youenn Fablet.
4029
4030         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
4031         (TestWebKitAPI::TEST):
4032         Add a test that utilizes TCPServer as local files always omit referrer.
4033
4034 2019-06-26  Aakash Jain  <aakash_jain@apple.com>
4035
4036         [ews-build] Add configuration and architecture for WPE and GTK builders
4037         https://bugs.webkit.org/show_bug.cgi?id=199249
4038
4039         Reviewed by Jonathan Bedard.
4040
4041         * BuildSlaveSupport/ews-build/config.json:
4042
4043 2019-06-26  Aakash Jain  <aakash_jain@apple.com>
4044
4045         [ews-build] Add check for duplicate workers in config.json
4046         https://bugs.webkit.org/show_bug.cgi?id=199240
4047
4048         Reviewed by Jonathan Bedard.
4049
4050         * BuildSlaveSupport/ews-build/loadConfig.py:
4051         (checkWorkersAndBuildersForConsistency._find_worker_with_name): Check for duplicate worker entry.
4052         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
4053         (TestcheckWorkersAndBuildersForConsistency.test_duplicate_worker): Added unit-test.
4054
4055 2019-06-26  Ross Kirsling  <ross.kirsling@sony.com>
4056
4057         [Win] MiniBrowser should make better font choices
4058         https://bugs.webkit.org/show_bug.cgi?id=199244
4059
4060         Reviewed by Brent Fulgham.
4061
4062         * MiniBrowser/win/MainWindow.cpp:
4063         (MainWindow::updateDeviceScaleFactor):
4064         * MiniBrowser/win/MiniBrowserLib.rc:
4065
4066 2019-06-26  Alex Christensen  <achristensen@webkit.org>
4067
4068         testRunner.setAlwaysAcceptCookies should wait for cookie accept policy to be set
4069         https://bugs.webkit.org/show_bug.cgi?id=199230
4070         <rdar://51757107>
4071
4072         Reviewed by Andy Estes.
4073
4074         * TestWebKitAPI/Tests/WebKit/CookieManager.cpp:
4075         (TestWebKitAPI::didGetTestHTTPCookieAcceptPolicy):
4076         (TestWebKitAPI::didGetUserHTTPCookieAcceptPolicy):
4077         * WebKitTestRunner/TestController.cpp:
4078         (WTR::TestController::generatePageConfiguration):
4079         (WTR::TestController::createWebViewWithOptions):
4080         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundleWithListener):
4081         (WTR::TestController::didReceiveSynchronousPageMessageFromInjectedBundleWithListener):
4082         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
4083         (WTR::TestController::didReceiveSynchronousPageMessageFromInjectedBundle): Deleted.
4084         * WebKitTestRunner/TestController.h:
4085         * WebKitTestRunner/TestInvocation.cpp:
4086         (WTR::TestInvocation::invoke):
4087         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
4088
4089 2019-06-26  Ross Kirsling  <ross.kirsling@sony.com>
4090
4091         [Win][MiniBrowser] Remove obsolete code after r246814.
4092         https://bugs.webkit.org/show_bug.cgi?id=199233
4093
4094         Reviewed by Fujii Hironori.
4095
4096         * MiniBrowser/win/MiniBrowserWebHost.cpp:
4097         (MiniBrowserWebHost::didFinishLoadForFrame):
4098         (SimpleEventListener::SimpleEventListener): Deleted.
4099         (SimpleEventListener::handleEvent): Deleted.
4100
4101 2019-06-25  Jiewen Tan  <jiewen_tan@apple.com>
4102
4103         Implement a new SPI to inform clients about AppSSO
4104         https://bugs.webkit.org/show_bug.cgi?id=199085
4105         <rdar://problem/50028246>
4106
4107         Reviewed by Geoffrey Garen.
4108
4109         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
4110         (-[TestSOAuthorizationBasicDelegate webView:didFinishNavigation:]):
4111         (-[TestSOAuthorizationNavigationDelegate init]):
4112         (-[TestSOAuthorizationNavigationDelegate _webView:decidePolicyForSOAuthorizationLoadWithCurrentPolicy:forExtension:completionHandler:]):
4113         (TestWebKitAPI::TEST):
4114
4115 2019-06-25  Aakash Jain  <aakash_jain@apple.com>
4116
4117         [ews-build] Retry Layout test in case of failures
4118         https://bugs.webkit.org/show_bug.cgi?id=199194
4119
4120         Reviewed by Jonathan Bedard.
4121
4122         * BuildSlaveSupport/ews-build/steps.py:
4123         (RunWebKitTests.evaluateCommand): Check if tests failed and retry them if required.
4124         (ReRunWebKitTests): Build step to re-run layout tests.
4125         (ReRunWebKitTests.evaluateCommand): Check if tests failed and retry on clean build if required.
4126         (RunWebKitTestsWithoutPatch): Build step to run tests without patch.
4127         (RunWebKitTestsWithoutPatch.evaluateCommand):
4128
4129 2019-06-25  Aakash Jain  <aakash_jain@apple.com>
4130
4131         [ews-build] Combine various patchFailed*Tests properties
4132         https://bugs.webkit.org/show_bug.cgi?id=199193
4133
4134         Reviewed by Jonathan Bedard.
4135
4136         * BuildSlaveSupport/ews-build/steps.py: Renamed patchFailedJSCTests and patchFailedAPITests to patchFailedTests. This property
4137         can also be used for layout-tests later on.
4138         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
4139
4140 2019-06-25  Ross Kirsling  <ross.kirsling@sony.com>
4141
4142         [Win] MiniBrowser should default to webkit.org
4143         https://bugs.webkit.org/show_bug.cgi?id=199201
4144
4145         Reviewed by Don Olmstead.
4146
4147         * MiniBrowser/win/BrowserWindow.h:
4148         * MiniBrowser/win/MiniBrowserReplace.h:
4149         * MiniBrowser/win/WebKitBrowserWindow.cpp:
4150         (WebKitBrowserWindow::loadHTMLString): Deleted.
4151         * MiniBrowser/win/WebKitBrowserWindow.h:
4152         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
4153         (WebKitLegacyBrowserWindow::loadHTMLString): Deleted.
4154         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
4155         * MiniBrowser/win/WinMain.cpp:
4156         (wWinMain):
4157
4158 2019-06-25  Wenson Hsieh  <wenson_hsieh@apple.com>
4159
4160         [iOS] Occasional crash under -[UIPreviewTarget initWithContainer:center:transform:] when generating a drag preview
4161         https://bugs.webkit.org/show_bug.cgi?id=199192
4162         <rdar://problem/51554509>
4163
4164         Reviewed by Tim Horton.
4165
4166         Tweak the drag and drop simulator to ask for drag cancellation previews, and use this to write a couple tests to
4167         verify that we gracefully handle web process termination and web view unparenting mid-drag.
4168
4169         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
4170         (TestWebKitAPI::TEST):
4171         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
4172         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
4173         (-[DragAndDropSimulator _resetSimulatedState]):
4174         (-[DragAndDropSimulator _concludeDropAndPerformOperationIfNecessary]):
4175         (-[DragAndDropSimulator _advanceProgress]):
4176         (-[DragAndDropSimulator liftPreviews]):
4177         (-[DragAndDropSimulator cancellationPreviews]):
4178         (-[DragAndDropSimulator setSessionWillBeginBlock:]):
4179         (-[DragAndDropSimulator sessionWillBeginBlock]):
4180         (-[DragAndDropSimulator _webView:dataInteraction:sessionWillBegin:]):
4181
4182 2019-06-25  Aakash Jain  <aakash_jain@apple.com>
4183
4184         [ews-build] UploadTestResults and ExtractTestResults clobber results in case of multiple layout test runs in a build
4185         https://bugs.webkit.org/show_bug.cgi?id=199178
4186
4187         Reviewed by Jonathan Bedard.
4188
4189         * BuildSlaveSupport/ews-build/steps.py:
4190         (UploadTestResults.__init__): Add an optional identifier and append the identifier to the file name.
4191         (ExtractTestResults.__init__): Ditto.
4192         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit tests.
4193
4194 2019-06-25  Michael Catanzaro  <mcatanzaro@igalia.com>
4195
4196         Add user agent quirk for bankofamerica.com
4197         https://bugs.webkit.org/show_bug.cgi?id=199154
4198
4199         Reviewed by Carlos Garcia Campos.
4200
4201         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
4202         (TestWebKitAPI::TEST):
4203
4204 2019-06-25  Michael Catanzaro  <mcatanzaro@igalia.com>
4205
4206         Fully rename WebKitGTK+ -> WebKitGTK everywhere
4207         https://bugs.webkit.org/show_bug.cgi?id=199159
4208
4209         Reviewed by Carlos Garcia Campos.
4210
4211         * BuildSlaveSupport/gtk/README:
4212         * MiniBrowser/gtk/BrowserWindow.c:
4213         * MiniBrowser/gtk/main.c:
4214         (aboutURISchemeRequestCallback):
4215         * Scripts/webkitpy/common/config/contributionareas.py:
4216         * Scripts/webkitpy/common/config/contributors.json:
4217         * Scripts/webkitpy/tool/commands/analyzechangelog_unittest.py:
4218         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
4219         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
4220         (testWebViewResources):
4221         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
4222         (testWebViewMouseTarget):
4223         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
4224         (testWebExtensionGetTitle):
4225         (testDocumentLoadedSignal):
4226         (testWebExtensionFormControlsAssociated):
4227         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
4228         (testWebKitSettingsUserAgent):
4229         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
4230         (testWebViewRunJavaScript):
4231         * TestWebKitAPI/Tests/WebKitGtk/InspectorTestServer.cpp:
4232         (main):
4233         * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
4234         (prepareContextMenuTestView):
4235         (testContextMenuPopulateMenu):
4236         (testContextMenuCustomMenu):
4237         (testContextMenuDisableMenu):
4238         (testContextMenuSubMenu):
4239         (testContextMenuDismissed):
4240         (testContextMenuWebExtensionMenu):
4241         (testContextMenuWebExtensionNode):
4242         * TestWebKitAPI/Tests/WebKitGtk/TestInspector.cpp:
4243         (testInspectorDefault):
4244         (testInspectorManualAttachDetach):
4245         (testInspectorCustomContainerDestroyed):
4246         * TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp:
4247         (testWebViewPrint):
4248         (testPrintOperationPrint):
4249         (testPrintOperationErrors):
4250         * gtk/install-dependencies:
4251         * gtk/jhbuild.modules:
4252         * gtkdoc/generate-gtkdoc:
4253         * wpe/install-dependencies:
4254
4255 2019-06-24  Michael Catanzaro  <mcatanzaro@igalia.com>
4256
4257         contributors.json not canonicalized since r243297
4258         https://bugs.webkit.org/show_bug.cgi?id=199161
4259
4260         Reviewed by Alexey Proskuryakov.
4261
4262         Canonicalize it using 'validate-committer-lists --canonicalize'
4263
4264         * Scripts/webkitpy/common/config/contributors.json:
4265
4266 2019-06-24  Jonathan Bedard  <jbedard@apple.com>
4267
4268         webkitpy: Build style should be lower-case
4269         https://bugs.webkit.org/show_bug.cgi?id=199158
4270
4271         Reviewed by Aakash Jain.
4272
4273         * Scripts/webkitpy/test/main.py:
4274         (Tester._run_tests): Make all styles lower-case.
4275
4276 2019-06-24  Aakash Jain  <aakash_jain@apple.com>
4277
4278         [ews-build] Remove iOS queue from old EWS and dashboard
4279         https://bugs.webkit.org/show_bug.cgi?id=199150
4280
4281         Reviewed by Jonathan Bedard.
4282
4283         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
4284         * QueueStatusServer/config/queues.py:
4285
4286 2019-06-21  Ryan Haddad  <ryanhaddad@apple.com>
4287
4288         API Test [Mojave+ WK2 Debug ] TestWebKitAPI.WKAttachmentTestsMac.InsertDroppedFilePromisesAsAttachments is a flaky crash
4289         https://bugs.webkit.org/show_bug.cgi?id=198795
4290
4291         Unreviewed test gardening.
4292
4293         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
4294         (TestWebKitAPI::TEST): Disable flaky test.
4295
4296 2019-06-24  Aakash Jain  <aakash_jain@apple.com>
4297
4298         [ews-build] Enable iOS-12-Build queue on new EWS
4299         https://bugs.webkit.org/show_bug.cgi?id=199149
4300
4301         Reviewed by Jonathan Bedard.
4302
4303         * BuildSlaveSupport/ews-build/config.json: Enable iOS-12-Build-EWS trigger. Also temporarily share ews152 and ews154 with
4304         this queue.
4305         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4306         (StatusBubble): Enable ios status-bubble. Also display the ios bubble first (left). Going forward
4307         will keep the builders to the left and testers to the right.
4308
4309 2019-06-24  Aakash Jain  <aakash_jain@apple.com>
4310
4311         [ews-build] Upload test results after running layout-tests
4312         https://bugs.webkit.org/show_bug.cgi?id=199120
4313
4314         Reviewed by Jonathan Bedard.
4315
4316         * BuildSlaveSupport/ews-build/steps.py:
4317         (RunWebKitTests.evaluateCommand):
4318         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
4319
4320 2019-06-24  Aakash Jain  <aakash_jain@apple.com>
4321
4322         [ews-build] EWS should provide option to download layout test results zip file
4323         https://bugs.webkit.org/show_bug.cgi?id=199121
4324
4325         Reviewed by Jonathan Bedard.
4326
4327         * BuildSlaveSupport/ews-build/steps.py:
4328         (ExtractTestResults.resultsDownloadURL): Method to return layout test result zip file url.
4329         (ExtractTestResults.addCustomURLs): Add url to download layout test results zip file.
4330
4331 2019-06-24  Michael Catanzaro  <mcatanzaro@igalia.com>