Complete fix for enabling modern EME by default
[WebKit-https.git] / Tools / ChangeLog
1 2018-05-18  Jer Noble  <jer.noble@apple.com>
2
3         Complete fix for enabling modern EME by default
4         https://bugs.webkit.org/show_bug.cgi?id=185770
5         <rdar://problem/40368220>
6
7         Reviewed by Eric Carlson.
8
9         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
10
11 2018-05-18  Eric Carlson  <eric.carlson@apple.com>
12
13         Handle failure to extend sandbox gracefully
14         https://bugs.webkit.org/show_bug.cgi?id=185779
15         <rdar://problem/40316349>
16
17         Reviewed by Brent Fulgham.
18
19         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
20         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm: Added.
21         (-[SimulateFailedSandboxMessageHandler userContentController:didReceiveScriptMessage:]):
22         (-[SimulateFailedSandboxUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
23         (-[SimulateFailedSandboxUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
24         (MediaCaptureSimulateFailedSandbox::SetUp):
25         (MediaCaptureSimulateFailedSandbox::loadTestAndWaitForMessage):
26         (TEST_F):
27         * TestWebKitAPI/Tests/WebKitCocoa/disableGetUserMedia.html:
28
29 2018-05-18  Daniel Bates  <dabates@apple.com>
30
31         "debug-safari --ios-simulator" creates lldb target to launch Mac Safari
32         https://bugs.webkit.org/show_bug.cgi?id=185774
33
34         Reviewed by Andy Estes.
35
36         For now, the script debug-safari is not supported for WebKit for iOS. To
37         fix this we differentiate between the Apple Mac port and Apple embedded
38         ports.
39
40         * Scripts/webkitdirs.pm:
41         (safariPath): Substitute isAppleMacWebKit() for isAppleCocoaWebKit().
42         (isAppleMacWebKit): Added.
43         (isAppleCocoaWebKit): Write in terms of isAppleMacWebKit() and isEmbeddedWebKit().
44         (launcherName): Substitute isAppleMacWebKit() for isAppleCocoaWebKit().
45         (mobileSafariBundle): Substitute isIOSWebKit() for isAppleCocoaWebKit().
46         (debugSafari): Substitute isAppleMacWebKit() for isAppleCocoaWebKit().
47         (runSafari): Ditto.
48         (runMiniBrowser): Ditto.
49         (debugMiniBrowser): Ditto.
50         (runWebKitTestRunner): Ditto.
51         (debugWebKitTestRunner): Ditto.
52
53 2018-05-18  Antoine Quint  <graouts@apple.com>
54
55         [Web Animations] Turn Web Animations with CSS integration on for test runners
56         https://bugs.webkit.org/show_bug.cgi?id=184819
57         <rdar://problem/39597337>
58
59         Unreviewed. Rolling out the patch for this bug, it caused some flaky timeouts for animation suspension tests.
60
61         * DumpRenderTree/TestOptions.cpp:
62         (TestOptions::TestOptions):
63         * DumpRenderTree/TestOptions.h:
64         * DumpRenderTree/mac/DumpRenderTree.mm:
65         (runTest):
66         (shouldOverrideAndDisableWebAnimationsCSSIntegrationPreference): Deleted.
67         * WebKitTestRunner/TestController.cpp:
68         (WTR::TestController::resetPreferencesToConsistentValues):
69         (WTR::updateTestOptionsFromTestHeader):
70         * WebKitTestRunner/TestOptions.cpp:
71         (WTR::TestOptions::TestOptions):
72         (WTR::isLegacyAnimationEngineTestPath): Deleted.
73         * WebKitTestRunner/TestOptions.h:
74
75 2018-05-18  Fujii Hironori  <Hironori.Fujii@sony.com>
76
77         [Win][MiniBrowser] Create MainWindow even in transparent mode
78         https://bugs.webkit.org/show_bug.cgi?id=185597
79
80         Reviewed by Per Arne Vollan.
81
82         The current implementations doesn't create the MainWindow in
83         transparent mode. The screenshot is in Bug 58300.
84
85         There were three problems:
86         - Can't control the WebView. ie. going backward and forward.
87         - Can't quit the program.
88         - It makes implementation complicated.
89
90         * MiniBrowser/win/Common.cpp (resizeSubViews): Resize sub views
91         even in the transparent mode.
92         * MiniBrowser/win/WinMain.cpp:
93         (wWinMain): Create the main window even in the transparent mode.
94
95 2018-05-18  Antoine Quint  <graouts@apple.com>
96
97         [Web Animations] Turn Web Animations with CSS integration on for test runners
98         https://bugs.webkit.org/show_bug.cgi?id=184819
99         <rdar://problem/39597337>
100
101         Reviewed by Jon Lee.
102
103         Make the test runners turn both the main Web Animations flag and the Web Animations CSS
104         integration flag on.
105
106         We also remove the ability to toggle the Web Animations CSS integration flag using an HTML
107         comment directly at the top of the file since test runners now set the flag on by default
108         and a dedicated directory exists for tests that need to run with this flag off.
109
110         * DumpRenderTree/TestOptions.cpp:
111         (TestOptions::TestOptions):
112         * DumpRenderTree/TestOptions.h:
113         * DumpRenderTree/mac/DumpRenderTree.mm:
114         (shouldOverrideAndDisableWebAnimationsCSSIntegrationPreference):
115         (runTest):
116         * WebKitTestRunner/TestController.cpp:
117         (WTR::TestController::resetPreferencesToConsistentValues):
118         (WTR::updateTestOptionsFromTestHeader):
119         * WebKitTestRunner/TestOptions.cpp:
120         (WTR::isLegacyAnimationEngineTestPath):
121         (WTR::TestOptions::TestOptions):
122         * WebKitTestRunner/TestOptions.h:
123
124 2018-05-17  Nan Wang  <n_wang@apple.com>
125
126         AX: [macOS] Expose the primary screen height through AX API
127         https://bugs.webkit.org/show_bug.cgi?id=185742
128
129         Reviewed by Chris Fleizach.
130
131         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
132         (attributesOfElement):
133         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
134         (WTR::attributesOfElement):
135
136 2018-05-17  Commit Queue  <commit-queue@webkit.org>
137
138         Unreviewed, rolling out r231912.
139         https://bugs.webkit.org/show_bug.cgi?id=185750
140
141         It is prompting the user when there is no WPT changes
142         (Requested by bmac on #webkit).
143
144         Reverted changeset:
145
146         "Export changes to web-platform-test as part of the webkit-
147         patch upload workflow"
148         https://bugs.webkit.org/show_bug.cgi?id=184914
149         https://trac.webkit.org/changeset/231912
150
151 2018-05-17  Valerie R Young  <valerie@bocoup.com>
152
153         test262/Runner.pm: expand $INC to find webkitdirs.pm
154         https://bugs.webkit.org/show_bug.cgi?id=185739
155
156         Reviewed by Michael Saboff.
157
158         * Scripts/test262/Runner.pm:
159         (getBuildPath):
160
161 2018-05-17  Carlos Alberto Lopez Perez  <clopez@igalia.com>
162
163         [WPE] Implement and enable FULLSCREEN_API
164         https://bugs.webkit.org/show_bug.cgi?id=185676
165
166         Reviewed by Žan Doberšek.
167
168         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
169         (testWebViewFullScreen):
170
171 2018-05-17  Brendan McLoughlin  <brendan@bocoup.com>
172
173         Export changes to web-platform-test as part of the webkit-patch upload workflow
174         https://bugs.webkit.org/show_bug.cgi?id=184914
175
176         Reviewed by Youenn Fablet.
177
178         * Scripts/webkitpy/tool/commands/upload.py:
179         (Upload):
180         (CreateBug.execute):
181         (WPTChangeExport):
182         * Scripts/webkitpy/tool/steps/__init__.py:
183         * Scripts/webkitpy/tool/steps/wptchangeexport.py: Added.
184         (WPTChangeExport):
185         (WPTChangeExport.options):
186         (WPTChangeExport.run):
187         * Scripts/webkitpy/w3c/common.py:
188         * Scripts/webkitpy/w3c/test_exporter.py:
189         (WebPlatformTestExporter):
190         (WebPlatformTestExporter.__init__):
191         (WebPlatformTestExporter.username):
192         (WebPlatformTestExporter.token):
193         (WebPlatformTestExporter._github):
194         (WebPlatformTestExporter._wpt_fork_branch_github_url):
195         (WebPlatformTestExporter._wpt_fork_remote):
196         (WebPlatformTestExporter._wpt_fork_push_url):
197         (WebPlatformTestExporter._git):
198         (WebPlatformTestExporter._branch_name):
199         (WebPlatformTestExporter._public_branch_name):
200         (WebPlatformTestExporter.has_wpt_changes):
201         (WebPlatformTestExporter._create_patch):
202         (WebPlatformTestExporter.create_git_patch):
203         (WebPlatformTestExporter._prompt_for_token):
204         (WebPlatformTestExporter._prompt_for_username):
205         (WebPlatformTestExporter._ensure_username_and_token):
206         (WebPlatformTestExporter._validate_and_save_token):
207         (WebPlatformTestExporter.push_to_wpt_fork):
208         (WebPlatformTestExporter.make_pull_request):
209         (WebPlatformTestExporter.delete_local_branch):
210         (parse_args):
211         (TestExporter): Deleted.
212         (TestExporter.__init__): Deleted.
213         (TestExporter._ensure_wpt_repository): Deleted.
214         (TestExporter._fetch_wpt_repository): Deleted.
215         (TestExporter._ensure_new_branch_name): Deleted.
216         (TestExporter.download_and_commit_patch): Deleted.
217         (TestExporter.clean): Deleted.
218         (TestExporter.create_branch_with_patch): Deleted.
219         (TestExporter.push_to_wpt_fork): Deleted.
220         (TestExporter.make_pull_request): Deleted.
221         (TestExporter.create_wpt_pull_request): Deleted.
222         (TestExporter.delete_local_branch): Deleted.
223         (TestExporter.create_git_patch): Deleted.
224         (TestExporter.create_upload_remote_if_needed): Deleted.
225         (TestExporter.do_export): Deleted.
226         * Scripts/webkitpy/w3c/test_exporter_unittest.py:
227         (TestExporterTest.test_export):
228         (TestExporterTest.test_export_with_specific_branch):
229         (TestExporterTest):
230         (TestExporterTest.test_export_interactive_mode):
231         (TestExporterTest.test_export_invalid_token):
232         (TestExporterTest.test_export_wrong_token):
233
234 2018-05-17  Valerie R Young  <valerie@bocoup.com>
235
236         test262/Runner.pm: look for jsc in path if cannot call webkit-build-directory
237         https://bugs.webkit.org/show_bug.cgi?id=185650
238
239         Reviewed by Michael Saboff.
240
241         First, use jsc from CLI arg, then try to use webkit-build-directory,
242         if that doesn't work, look for jsc in the $PATH
243
244         * Scripts/test262/Runner.pm:
245         (processCLI):
246         (getBuildPath):
247         (runTest):
248
249 2018-05-16  Leo Balter  <leonardo.balter@gmail.com>
250
251         Test262-Runner: Adds a --timeout option
252         https://bugs.webkit.org/show_bug.cgi?id=185696
253
254         Reviewed by Michael Saboff.
255
256         The timeout option is used to set a timeout execution in ms for each test run in JSC.
257         The passed value - if defined - will be used as the value for the JSC --watchdog arg.
258         * Scripts/test262/Runner.pm:
259         (processCLI):
260         (runTest):
261
262 2018-05-16  Leo Balter  <leonardo.balter@gmail.com>
263
264         Test262-Runner: Set timer for each test run
265         https://bugs.webkit.org/show_bug.cgi?id=185692
266
267         Reviewed by Michael Saboff.
268
269         Sets a high resolution timer for each execution call of JSC, reporting
270         the time in the results report to allow identifying slow tests.
271         * Scripts/test262/Runner.pm:
272         (main):
273         (processFile):
274         (runTest):
275         (processResult):
276
277 2018-05-16  Andy VanWagoner  <andy@vanwagoner.family>
278
279         Add support for Intl NumberFormat formatToParts
280         https://bugs.webkit.org/show_bug.cgi?id=185375
281
282         Reviewed by Yusuke Suzuki.
283
284         Add flag for NumberFormat formatToParts.
285
286         * Scripts/webkitperl/FeatureList.pm:
287         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
288
289 2018-05-14  Yusuke Suzuki  <utatane.tea@gmail.com>
290
291         [Win] Use C++17 in MSVC
292         https://bugs.webkit.org/show_bug.cgi?id=185232
293
294         Reviewed by Alex Christensen.
295
296         Do not use `using namespace std;`. In C++17, we have std::byte. This "byte"
297         conflicts with ::byte defined in Windows' header.
298
299         * DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.cpp:
300         (WindowedPluginTest::WindowedPluginTest):
301         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
302         (logEventProc):
303         (stringEvent):
304         (AccessibilityController::winNotificationReceived):
305         * DumpRenderTree/win/TextInputController.cpp:
306         (markedRangeCallback):
307         (firstRectForCharacterRangeCallback):
308         (selectedRangeCallback):
309         * DumpRenderTree/win/TextInputController.h:
310         * DumpRenderTree/win/TextInputControllerWin.cpp:
311         (TextInputController::markedRange):
312         (TextInputController::firstRectForCharacterRange):
313         (TextInputController::selectedRange):
314
315 2018-05-16  Sihui Liu  <sihui_liu@apple.com>
316
317         Session cookies aren't reliably set when using default WKWebSiteDataStore
318         https://bugs.webkit.org/show_bug.cgi?id=185624
319         <rdar://problem/39111626>
320
321         Reviewed by Geoffrey Garen.
322
323         Modified and enabled WebKit.WKHTTPCookieStoreWithoutProcessPool.
324
325         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
326         (-[CookieUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
327         (TEST):
328
329 2018-05-16  Valerie R Young  <valerie@bocoup.com>
330
331         test262/Runner.pm: save to supplied expectation file if supplied
332         https://bugs.webkit.org/show_bug.cgi?id=185660
333
334         Reviewed by Michael Saboff.
335
336         * Scripts/test262/Runner.pm:
337         (processCLI):
338         (main):
339
340 2018-05-15  Ryan Haddad  <ryanhaddad@apple.com>
341
342         Unreviewed, rolling out r231763.
343
344         The test added with this change is failing an assertion.
345
346         Reverted changeset:
347
348         "NSEvent event trackers don't work from WebKitTestRunner"
349         https://bugs.webkit.org/show_bug.cgi?id=185383
350         https://trac.webkit.org/changeset/231763
351
352 2018-05-15  David Kilzer  <ddkilzer@apple.com>
353
354         TestWebKitAPI: Fix warnings found by new clang compiler
355         <https://webkit.org/b/185631>
356
357         Reviewed by Michael Catanzaro.
358
359         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
360         (TestWebKitAPI::TEST):
361         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
362         (TestWebKitAPI::TEST):
363         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp:
364         (TestWebKitAPI::TEST):
365         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
366         (TestWebKitAPI::TEST):
367         - Add #pragma statements to ignore the new
368           -Wself-assign-overloaded warning and to ignore
369           this as an unknown warning on older clang versions.  We want
370           to keep these self assigments as this code is designed to test
371           that use case.
372
373         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
374         (TestWebKitAPI::didFindStringMatches):
375         - Replace the "rect = rect;" statement that was used to avoid an
376           unused variable warning with two expectations.
377
378         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
379         (-[PinnedStateObserver observeValueForKeyPath:ofObject:change:context:]):
380         - Switch from -integerValue to -unsignedIntegerValue when
381           comparing against _WKRectEdgeAll since it's an enum declared
382           as an NSUInteger.
383
384 2018-05-15  Michael Catanzaro  <mcatanzaro@igalia.com>
385
386         Unreviewed, rolling out r230749
387
388         This did not work as desired.
389
390         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
391         (TestWebKitAPI::TEST):
392
393 2018-05-15  Antoine Quint  <graouts@apple.com>
394
395         [Web Animations] Expose Web Animations CSS integration as an experimental feature
396         https://bugs.webkit.org/show_bug.cgi?id=185647
397
398         Reviewed by Dean Jackson.
399
400         Rename the Web Animations CSS integration flag.
401
402         * DumpRenderTree/TestOptions.cpp:
403         (TestOptions::TestOptions):
404         * DumpRenderTree/TestOptions.h:
405         * DumpRenderTree/mac/DumpRenderTree.mm:
406         (setWebPreferencesForTestOptions):
407         * WebKitTestRunner/TestController.cpp:
408         (WTR::TestController::resetPreferencesToConsistentValues):
409         (WTR::updateTestOptionsFromTestHeader):
410         * WebKitTestRunner/TestOptions.h:
411         (WTR::TestOptions::hasSameInitializationOptions const):
412
413 2018-05-14  Brady Eidson  <beidson@apple.com>
414
415         Add an API test to guard against regressions while re-entering setDefersLoading:.
416         <rdar://problem/37033737> and https://bugs.webkit.org/show_bug.cgi?id=185630
417
418         Reviewed by Chris Dumez.
419
420         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
421         * TestWebKitAPI/Tests/WebKitCocoa/DoubleDefersLoading.mm: Added.
422         (-[DoubleDefersNavigationDelegate _webView:navigation:didSameDocumentNavigation:]):
423         (-[DoubleDefersNavigationDelegate webView:didFinishNavigation:]):
424         (-[DefersScheme initWithBytes:]):
425         (-[DefersScheme webView:startURLSchemeTask:]):
426         (-[DefersScheme webView:stopURLSchemeTask:]):
427         * TestWebKitAPI/Tests/WebKitCocoa/DoubleDefersLoadingPlugin.mm: Added.
428         (-[DoubleDefersLoadingPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
429         (-[DoubleDefersLoadingPlugIn webProcessPlugInBrowserContextController:didSameDocumentNavigation:forFrame:]):
430         (-[DoubleDefersLoadingPlugIn dealloc]):
431
432 2018-05-14  Daniel Bates  <dabates@apple.com>
433
434         [iOS] Add a test to ensure that setTimeout() does not fire more than expected when using UIWebView
435         https://bugs.webkit.org/show_bug.cgi?id=185599
436         <rdar://problem/22493890>
437
438         Reviewed by Simon Fraser.
439
440         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
441         * TestWebKitAPI/Tests/ios/SetTimeoutFunction.mm: Added.
442         (-[SetTimeoutFunctionWebViewDelegate webViewDidFinishLoad:]):
443         (-[SetTimeoutFunctionWebViewDelegate webView:didFailLoadWithError:]):
444         (-[SetTimeoutFunctionWebViewDelegate webView:shouldStartLoadWithRequest:navigationType:]):
445         (TestWebKitAPI::TEST):
446         * TestWebKitAPI/ios/set-timeout-function.html: Added.
447
448 2018-05-14  Valerie R Young  <valerie@bocoup.com>
449
450         test262/Runner.pm: small bugs in CLI and error codes
451         https://bugs.webkit.org/show_bug.cgi?id=185629
452
453         Reviewed by Michael Saboff.
454
455         Fix two commandline args with use '-f', correct
456         error code of failures.
457
458         * Scripts/test262/Runner.pm:
459         (processCLI):
460         (main):
461
462 2018-05-14  Ryan Haddad  <ryanhaddad@apple.com>
463
464         Disable API tests that time out after pointer poisioning was disabled.
465         https://bugs.webkit.org/show_bug.cgi?id=185586
466
467         Unreviewed test gardening.
468
469         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
470         (TestWebKitAPI::TEST):
471         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
472         (TestWebKitAPI::TEST):
473         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp:
474         (TestWebKitAPI::TEST):
475         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
476         (TestWebKitAPI::TEST):
477
478 2018-05-14  Leo Balter  <leonardo.balter@gmail.com>
479
480         Test262-Runner: Fix RegExp for capturing tests metadata"
481         https://bugs.webkit.org/show_bug.cgi?id=185622
482
483         Reviewed by Michael Saboff.
484
485         This patch fixes the RegExp used to capture each test metadata regarding their EOL characters for
486         both LF and CRLF forms.
487
488         The fix also allows the runner to capture the proper results from two specific files using CR and
489         CRLF line terminators. They are updated in the expectations file.
490         * Scripts/test262/Runner.pm:
491         (parseData):
492
493 2018-05-14  Jeremy Jones  <jeremyj@apple.com>
494
495         NSEvent event trackers don't work from WebKitTestRunner
496         https://bugs.webkit.org/show_bug.cgi?id=185383
497         rdar://problem/40025045
498
499         Reviewed by Simon Fraser.
500
501         Post simulated wheel events to _sendEventToObservers: so they can be handled by NSEvent observers.
502         NSEvent swipe tracking is used for webkit swipe navigation.
503
504         * WebKitTestRunner/mac/EventSenderProxy.mm:
505         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
506
507 2018-05-11  Leo Balter  <leonardo.balter@gmail.com>
508
509         Test262 Runner should search for the Debug JSC by default
510         https://bugs.webkit.org/show_bug.cgi?id=185562
511
512         Reviewed by Michael Saboff.
513
514         The Test262 Runner is now searching for the Debug build of JSC by
515         default, not the Release build.
516
517         This fix allows a similar call from the previous runner, making
518         it compatible with the current build bot configuration parameters.
519
520         This patch also adds some minor improvements the verbose mode output.
521
522         * Scripts/test262/Runner.pm:
523         (processCLI):
524         (main):
525         (getBuildPath):
526         (processResult):
527
528 2018-05-11  Charles Vazac  <cvazac@gmail.com>
529
530         Runtime feature flag for Server-Timing
531         https://bugs.webkit.org/show_bug.cgi?id=184758
532
533         Reviewed by Youenn Fablet.
534
535         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: added ENABLE_SERVER_TIMING.
536         * DumpRenderTree/win/DumpRenderTree.cpp: enable Server Timing
537
538 2018-05-11  Fujii Hironori  <Hironori.Fujii@sony.com>
539
540         [Win][MiniBrowser] Move WK1 related code into MiniBrowser
541         https://bugs.webkit.org/show_bug.cgi?id=185418
542
543         Reviewed by Alex Christensen.
544
545         All WK1 related code should be moved into MiniBrowser for the preparation
546         of Bug 184770.
547
548         This change moves the initilization code of MiniBrowse into MiniBrowser::init().
549
550         * MiniBrowser/win/Common.cpp:
551         (getAppDataFolder): Removed `static` keyword to be called from MiniBrowser.cpp.
552         (setCacheFolder): This is only for WK1. Moved into MiniBrowser.cpp.
553         * MiniBrowser/win/Common.h: Added.
554         * MiniBrowser/win/MiniBrowser.cpp:
555         (MiniBrowser::init): Moved the initilization code from wWinMain.
556         (MiniBrowser::setCacheFolder): Moved from Common.cpp and made it a method.
557         * MiniBrowser/win/MiniBrowser.h:
558         (MiniBrowser::setCacheFolder): Changed to a private method.
559         (MiniBrowser::subclassForLayeredWindow): Changed to a private method.
560         * MiniBrowser/win/WinMain.cpp:
561         (wWinMain): Moved MiniBrowse initilization code into MiniBrowser.cpp.
562
563 2018-05-11  Brady Eidson  <beidson@apple.com>
564
565         Make sure history navigations reuse the existing process when necessary.
566         <rdar://problem/39746516> and https://bugs.webkit.org/show_bug.cgi?id=185532
567
568         Reviewed by Ryosuke Niwa.
569
570         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
571
572 2018-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
573
574         [JSC][GLIB] Add introspectable alternatives to functions using vargars
575         https://bugs.webkit.org/show_bug.cgi?id=185508
576
577         Reviewed by Michael Catanzaro.
578
579         Add test cases for the new API.
580
581         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
582         (testJSCFunction):
583         (testJSCObject):
584
585 2018-05-10  Leo Balter  <leonardo.balter@gmail.com>
586
587         [Build Bot] Restore configuration options to the Test262 Runner
588
589         During the switch from the previous Test262 runner to the new one,
590         a call for an extra configurations options got removed.
591
592         This call is important to inform the script to find the debug or
593         release build of JSC. It's being restored in this patch.
594
595         https://bugs.webkit.org/show_bug.cgi?id=185513
596
597         Reviewed by Yusuke Suzuki.
598
599         * BuildSlaveSupport/build.webkit.org-config/steps.py:
600         (RunTest262Tests):
601
602 2018-05-10  Jonathan Bedard  <jbedard@apple.com>
603
604         REGRESSION (r230998): Cannot stream API test output
605         https://bugs.webkit.org/show_bug.cgi?id=185090
606
607         Reviewed by Ryosuke Niwa.
608
609         Change run-api-tests so that the stdout and stderr of a test will be printed
610         before it's result. If -v is passed, the output of single test runs will be
611         streamed. 
612
613         * Scripts/webkitpy/api_tests/run_api_tests.py:
614         (run): Use print_timestamps flag.
615         (parse_args): Add timestamps option to print timestamps in the log.
616         * Scripts/webkitpy/api_tests/runner.py:
617         (Runner): Add running status.
618         (Runner.__init__): Add number of workers and a flag to detect if a newline
619         is needed at the beginning of a log line.
620         (Runner.run): Turn off most logging coming from server process since it is
621         not constructive for API tests.
622         (Runner.handle): Add new log message to stream stdout and stderr instead of
623         caching values until the test run finished.
624         (_Worker._run_single_test): Log stdout and stderr in real time.
625         (_Worker._run_shard_with_binary): Log stderr and stdout buffer before ending
626         the test.
627         (_Worker.post): Provide a post with explicitly enumerated argument names.
628         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
629         (MeteredStream.__init__): Differentiate verbose logging and logging with timestamps.
630         (MeteredStream.write): Allow for verbose logging without timestamps.
631         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
632         (RegularTest): Add print_timestamps flag.
633         (RegularTest.setUp):
634         (RegularTest.test_logging_not_included):
635         (VerboseTest.test_log_args):
636         (VerboseWithOutTimestamp):
637         (VerboseWithOutTimestamp.test_basic): Add test for verbose logging without timestamps.
638
639 2018-05-10  Ryosuke Niwa  <rniwa@webkit.org>
640
641         build-webkit can erroneously warn about Xcode being too old
642         https://bugs.webkit.org/show_bug.cgi?id=185533
643
644         Reviewed by Dan Bernstein.
645
646         Don't assume the version number is always a single digit.
647
648         * Scripts/webkitdirs.pm:
649         (determineXcodeVersion):
650
651 2018-05-10  Ross Kirsling  <ross.kirsling@sony.com>
652
653         [WinCairo][Buildbot] Test bots need to acquire WinCairoRequirements.
654         https://bugs.webkit.org/show_bug.cgi?id=185528
655
656         Reviewed by Lucas Forschler.
657
658         * BuildSlaveSupport/build.webkit.org-config/factories.py:
659         (TestFactory.__init__):
660         * BuildSlaveSupport/build.webkit.org-config/steps.py:
661         (InstallWinCairoDependencies):
662
663 2018-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
664
665         Fix some -Wstring-op-truncation warnings
666         https://bugs.webkit.org/show_bug.cgi?id=185496
667
668         Reviewed by Alex Christensen.
669
670         We have an off-by-one in the use of strncpy. The strings would not be null-terminated if
671         the input was too long. Ensure the buffers are zero-initialized so we don't need to manually
672         set the last bucket to NUL.
673
674         * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
675         (TestWebKitAPI::testAtomicStringNumber):
676         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
677         (TestWebKitAPI::testStringNumberFixedPrecision):
678         (TestWebKitAPI::testStringNumberFixedWidth):
679         (TestWebKitAPI::testStringNumber):
680
681 2018-05-10  Fujii Hironori  <Hironori.Fujii@sony.com>
682
683         [Win][MiniBrowser] Add a separate WndProc for the layered window
684         https://bugs.webkit.org/show_bug.cgi?id=185460
685
686         Reviewed by Brent Fulgham.
687
688         All WK1 related code should be moved into MiniBrowser for the
689         preparation of Bug 184770.
690
691         The layered window was using WndProc of the main window. The
692         layered window is specific only for WK1. the main window will be
693         shared among WK1 and WK2.
694
695         This change add a new WndProc for the layer window.
696
697         * MiniBrowser/win/Common.cpp:
698         (WndProc): Removed code for the layered windows.
699         (subclassForLayeredWindow): Moved into MiniBrowser.cpp.
700         * MiniBrowser/win/MiniBrowser.cpp:
701         (MiniBrowser::prepareViews): Removed the fourth argument `viewHwnd`.
702         (viewWndProc): New WndProc for the layered windows.
703         (MiniBrowser::subclassForLayeredWindow): Moved from Common.cpp.
704         * MiniBrowser/win/MiniBrowser.h:
705         (MiniBrowser::hwnd):
706         * MiniBrowser/win/WinMain.cpp:
707         (wWinMain): Added m_viewWnd.
708
709 2018-05-10  Stephan Szabo  <stephan.szabo@sony.com>
710
711         Support --verbose in run-javascriptcore-tests
712         https://bugs.webkit.org/show_bug.cgi?id=185492
713
714         Reviewed by Daniel Bates.
715
716         * Scripts/run-javascriptcore-tests:
717         (runJSCStressTests):
718
719 2018-05-10  Valerie R Young  <valerie@bocoup.com>
720
721         test262/Runner.pm: --failing-files uses results file not expectations
722         https://bugs.webkit.org/show_bug.cgi?id=185395
723
724         Reviewed by Michael Saboff.
725
726         --failing-files arg now uses results file to find failing tests
727         to rerun. It will look in the test262-results directory from whereever
728         the script is run, or a results.yaml file can be supplied via command
729         line argument.
730         --expectations arg added for suppling expectation file.
731
732         * Scripts/test262/Runner.pm:
733         (processCLI):
734         (main):
735         (loadImportFile):
736         (findAllFailing):
737
738 2018-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
739
740         [GTK] Add support for settings cookies policy and storage type in MiniBrowser
741         https://bugs.webkit.org/show_bug.cgi?id=185506
742
743         Reviewed by Philippe Normand.
744
745         Useful for testing and debugging.
746
747         * MiniBrowser/gtk/main.c:
748         (main):
749
750 2018-05-09  Chris Dumez  <cdumez@apple.com>
751
752         Unreviewed Windows build fix after r231622.
753
754         * DumpRenderTree/win/DumpRenderTree.cpp:
755         (enableExperimentalFeatures):
756
757 2018-05-09  Sihui Liu  <sihui_liu@apple.com>
758
759         Update WebKit.WebsiteDataStoreCustomPaths after r231536
760         https://bugs.webkit.org/show_bug.cgi?id=185486
761         <rdar://problem/37214391>
762
763         Reviewed by Chris Dumez.
764
765         Update WebKit.WebsiteDataStoreCustomPaths as _syncNetworkProcessCookies is async now.
766
767         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
768         (TEST):
769
770 2018-05-09  Leo Balter  <leonardo.balter@gmail.com>
771
772         Test262-Runner: Improve the verbose output
773         https://bugs.webkit.org/show_bug.cgi?id=185491
774
775         Reviewed by Michael Saboff.
776
777         * Scripts/test262/Import.pm:
778         (transferFiles):
779         * Scripts/test262/Runner.pm:
780         (processResult):
781
782 2018-05-09  Leo Balter  <leonardo.balter@gmail.com>
783
784         Fix Test262 Runner to have DYLD_FRAMEWORK_PATH always set
785         https://bugs.webkit.org/show_bug.cgi?id=185488
786
787         Reviewed by Michael Saboff.
788
789         * Scripts/test262/Runner.pm:
790         (processCLI):
791         (getBuildPath):
792         (runTest):
793
794 2018-05-09  Richard Houle  <rhoule@apple.com>
795
796         [Cocoa] Some fields are not identified as [WKWebProcessPlugInNodeHandle isTextField]
797         https://bugs.webkit.org/show_bug.cgi?id=185260
798         <rdar://problem/39290394>
799
800         Reviewed by Tim Horton.
801
802         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
803         * TestWebKitAPI/Tests/WebKitCocoa/InjectedBundleNodeHandleIsTextField.mm: Added.
804         (-[InjectedBundleNodeHandleIsTextField isTextFieldForHTMLInputType:document:jsContext:]):
805         (-[InjectedBundleNodeHandleIsTextField webProcessPlugIn:didCreateBrowserContextController:]):
806         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
807         (-[InjectedBundleNodeHandleIsTextFieldDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
808
809 2018-05-09  Thibault Saunier  <tsaunier@igalia.com>
810
811         [tests][GStreamer]: Pass USE_PLAYBIN3 to the tests subprocess
812         https://bugs.webkit.org/show_bug.cgi?id=185481
813
814         Reviewed by Philippe Normand.
815
816         [tests][GStreamer]: Pass USE_PLAYBIN3 to the tests subprocess
817
818         * Scripts/webkitpy/port/gtk.py:
819         (GtkPort.setup_environ_for_server):
820
821 2018-05-09  Leo Balter  <leonardo.balter@gmail.com>
822
823         Set build.webkit.org to use the new Test262-runner
824         https://bugs.webkit.org/show_bug.cgi?id=184933
825
826         Reviewed by Aakash Jain.
827
828         * BuildSlaveSupport/build.webkit.org-config/steps.py:
829         (RunTest262Tests):
830         (RunTest262Tests.countFailures):
831         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
832
833 2018-05-09  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
834
835         [GTK][JHBuild] LLVM 3.7.0 build is broken with GCC 8.1
836         https://bugs.webkit.org/show_bug.cgi?id=185461
837
838         Reviewed by Michael Catanzaro.
839
840         JHBuild now compiles LLVM 6 and Mesa 18.0.3.
841
842         * gtk/jhbuild.modules:
843
844 2018-05-09  Michael Catanzaro  <mcatanzaro@igalia.com>
845
846         Unreviewed. Update OptionsWPE.cmake and NEWS for 2.21.1 release.
847
848         * wpe/manifest.txt.in: Distribute the NEWS.
849
850 2018-05-09  Michael Catanzaro  <mcatanzaro@igalia.com>
851
852         [WPE] Build cleanly with GCC 8 and ICU 60
853         https://bugs.webkit.org/show_bug.cgi?id=185462
854
855         Reviewed by Carlos Alberto Lopez Perez.
856
857         * TestWebKitAPI/CMakeLists.txt: Fix weird build failure, we were missing a directory. Not
858         sure why this was never noticed until now or why the bots are OK.
859         * gtk/jhbuild.modules: Add upstream patch to avoid warnings inside G_DEFINE_TYPE.
860         * gtk/patches/glib-cast-function-type.patch: Added.
861         * wpe/jhbuild.modules: Add upstream patch to avoid warnings inside G_DEFINE_TYPE.
862         * wpe/patches/glib-cast-function-type.patch: Added.
863
864 2018-05-06  Yusuke Suzuki  <utatane.tea@gmail.com>
865
866         [JSC][GTK][JSCONLY] Use capstone disassembler
867         https://bugs.webkit.org/show_bug.cgi?id=185283
868
869         Reviewed by Michael Catanzaro.
870
871         * gtk/manifest.txt.in:
872         * wpe/manifest.txt.in:
873
874 2018-05-09  Antti Koivisto  <antti@apple.com>
875
876         Add OptionSet::operator& and operator bool
877         https://bugs.webkit.org/show_bug.cgi?id=185306
878
879         Reviewed by Anders Carlsson.
880
881         * TestWebKitAPI/Tests/WTF/OptionSet.cpp:
882         (TestWebKitAPI::TEST):
883
884 2018-05-08  Wenson Hsieh  <wenson_hsieh@apple.com>
885
886         Consolidate WebContentReaderIOS and WebContentReaderMac into WebContentReaderCocoa
887         https://bugs.webkit.org/show_bug.cgi?id=185340
888
889         Reviewed by Tim Horton.
890
891         Adds a new API test to verify that URLs written using -[NSPasteboard writeObjects:] are pasted as anchors with
892         non-empty text in a contenteditable.
893
894         * TestWebKitAPI/Tests/WebKitCocoa/PasteMixedContent.mm:
895         (TestWebKitAPI::TEST):
896
897 2018-05-08  Valerie R Young  <valerie@bocoup.com>
898
899         test262/Runner.pm: create results dir for results of test262 run
900         https://bugs.webkit.org/show_bug.cgi?id=185392
901
902         Reviewed by Michael Saboff.
903
904         New directory test262-results created from where ever script is
905         called.
906
907         * Scripts/test262/Runner.pm:
908         (processCLI):
909
910 2018-05-08  Valerie R Young  <valerie@bocoup.com>
911
912         test262/Runner.pm: lower number of processes per core
913         https://bugs.webkit.org/show_bug.cgi?id=185426
914
915         Reviewed by Michael Saboff.
916
917         * Scripts/test262/Runner.pm:
918         (getProcesses):
919
920 2018-05-08  Leo Balter  <leonardo.balter@gmail.com>
921
922         Test262-Runner: Add base Perl UnicodeData
923         https://bugs.webkit.org/show_bug.cgi?id=185444
924
925         Reviewed by Michael Saboff.
926
927         * Scripts/test262/local/lib/perl5/unicore/lib/gc_sc/SpacePer.pl: Added.
928         * Scripts/test262/local/lib/perl5/unicore/lib/gc_sc/Word.pl: Added.
929
930 2018-05-08  Daniel Bates  <dabates@apple.com>
931
932         Add tests to ensure that the Strong Password appearance is removed on form reset
933         https://bugs.webkit.org/show_bug.cgi?id=185440
934
935         Reviewed by Ryosuke Niwa.
936
937         * TestWebKitAPI/Tests/WebKitCocoa/DidResignInputElementStrongPasswordAppearance.mm:
938         (-[DidResignInputElementStrongPasswordAppearance webProcessPlugIn:didCreateBrowserContextController:]):
939         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
940         (TEST):
941
942 2018-05-08  Daniel Bates  <dabates@apple.com>
943
944         Resign Strong Password appearance when text field value changes
945         https://bugs.webkit.org/show_bug.cgi?id=185433
946         <rdar://problem/39958508>
947
948         Reviewed by Ryosuke Niwa.
949
950         Add a unit test to ensure the injected bundle API and WebKit UI delegate SPI is invoked
951         when the field has the Strong Password button and its value changes.
952
953         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
954         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
955         (TEST):
956
957 2018-05-06  Filip Pizlo  <fpizlo@apple.com>
958
959         InPlaceAbstractState::beginBasicBlock shouldn't have to clear any abstract values
960         https://bugs.webkit.org/show_bug.cgi?id=185365
961
962         Reviewed by Saam Barati.
963         
964         Make it possible to measure compile times.
965         
966         Rolling back in after fixing cloop builds.
967
968         * Scripts/run-jsc-benchmarks:
969
970 2018-05-08  Wenson Hsieh  <wenson_hsieh@apple.com>
971
972         [iOS] WKAttachmentTestsIOS.InsertDroppedItemProvidersInOrder fails after r231396
973         https://bugs.webkit.org/show_bug.cgi?id=185414
974
975         Reviewed by Tim Horton.
976
977         Adjust a test expectation to check that the resulting DOM contains an attachment element,
978         anchor element, and another attachment element in that order. This ensures that the test
979         still passes, even after the anchor element is followed by a line break.
980
981         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
982         (TestWebKitAPI::TEST):
983
984 2018-05-08  Commit Queue  <commit-queue@webkit.org>
985
986         Unreviewed, rolling out r231491.
987         https://bugs.webkit.org/show_bug.cgi?id=185434
988
989         Setting the Created key on a cookie does not work yet, due a
990         bug in CFNetwork (Requested by ggaren on #webkit).
991
992         Reverted changeset:
993
994         "[WKHTTPCookieStore getAllCookies] returns inconsistent
995         creation time"
996         https://bugs.webkit.org/show_bug.cgi?id=185041
997         https://trac.webkit.org/changeset/231491
998
999 2018-05-08  Valerie R Young  <valerie@bocoup.com>
1000
1001         test262/Runner.pm: move input files to JSTests/test262
1002         https://bugs.webkit.org/show_bug.cgi?id=185389
1003
1004         Reviewed by Michael Saboff.
1005
1006         * Scripts/test262/Runner.pm:
1007         (processCLI):
1008
1009 2018-05-08  Chris Dumez  <cdumez@apple.com>
1010
1011         Unreviewed, simplify Speedometer fixes landed in r231489, r231483 & r231474.
1012
1013         * Scripts/webkitpy/performance_tests/perftest.py:
1014         (PerfTest):
1015
1016 2018-05-08  Ryan Haddad  <ryanhaddad@apple.com>
1017
1018         Unreviewed, rolling out r231468.
1019
1020         Broke the CLoop build
1021
1022         Reverted changeset:
1023
1024         "InPlaceAbstractState::beginBasicBlock shouldn't have to clear
1025         any abstract values"
1026         https://bugs.webkit.org/show_bug.cgi?id=185365
1027         https://trac.webkit.org/changeset/231468
1028
1029 2018-05-08  Sihui Liu  <sihui_liu@apple.com>
1030
1031         [WKHTTPCookieStore getAllCookies] returns inconsistent creation time
1032         https://bugs.webkit.org/show_bug.cgi?id=185041
1033         <rdar://problem/34684214>
1034
1035         Reviewed by Geoffrey Garen.
1036
1037         Add API test Coverage.
1038
1039         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
1040         (TEST):
1041
1042 2018-05-08  Chris Dumez  <cdumez@apple.com>
1043
1044         Unreviewed, fix issue with running Speedometer PerfTest after r231450.
1045
1046         * Scripts/webkitpy/performance_tests/perftest.py:
1047         (PerfTest):
1048
1049 2018-05-08  Chris Dumez  <cdumez@apple.com>
1050
1051         Unreviewed, fix issue with running Speedometer PerfTest after r231450.
1052
1053         * Scripts/webkitpy/performance_tests/perftest.py:
1054         (PerfTest):
1055
1056 2018-05-07  Chris Dumez  <cdumez@apple.com>
1057
1058         Unreviewed, fix issue with running Speedometer PerfTest after r231450.
1059
1060         * Scripts/webkitpy/performance_tests/perftest.py:
1061         (PerfTest):
1062
1063 2018-05-06  Filip Pizlo  <fpizlo@apple.com>
1064
1065         InPlaceAbstractState::beginBasicBlock shouldn't have to clear any abstract values
1066         https://bugs.webkit.org/show_bug.cgi?id=185365
1067
1068         Reviewed by Saam Barati.
1069         
1070         Make it possible to measure compile times.
1071
1072         * Scripts/run-jsc-benchmarks:
1073
1074 2018-05-07  Leo Balter  <leonardo.balter@gmail.com>
1075
1076         Test262-Runner: Add base module to the local deps - unicore/Exact.pl
1077         https://bugs.webkit.org/show_bug.cgi?id=185390
1078
1079         Reviewed by Michael Saboff.
1080
1081         * Scripts/test262/local/lib/perl5/unicore/Exact.pl: Added.
1082
1083 2018-05-07  Jonathan Bedard  <jbedard@apple.com>
1084
1085         Check for com.apple.datamigrator before declaring simulators booted
1086         https://bugs.webkit.org/show_bug.cgi?id=185315
1087         <rdar://problem/39986261>
1088
1089         Reviewed by David Kilzer.
1090
1091         * Scripts/webkitdirs.pm:
1092         (waitUntilProcessNotRunning): Wait until a process is not found.
1093         (relaunchIOSSimulator): Wait until com.apple.datamigrator stops running to declare
1094         a simulator booted.
1095         * Scripts/webkitpy/common/system/executive_mock.py:
1096         (MockExecutive2.__init__): Define _running_pids.
1097         * Scripts/webkitpy/xcode/simulated_device.py:
1098         (SimulatedDeviceManager.initialize_devices): Call wait_until_data_migration_is_done before
1099         declaring that devices have been booted, increase the timeout since data migration will frequently
1100         take longer than 60 seconds, especially with multiple simulators booting.
1101         (SimulatedDeviceManager.swap): Ditto.
1102         (SimulatedDeviceManager):
1103         (SimulatedDeviceManager.wait_until_data_migration_is_done): Wait until there are no com.apple.datamigrator
1104         processes running.
1105
1106 2018-05-07  Daniel Bates  <dabates@apple.com>
1107
1108         REGRESSION (r229955): run-webkit-tests runs tests in skipped directories and subdirectories of directory given on command line
1109         https://bugs.webkit.org/show_bug.cgi?id=185054
1110         <rdar://problem/39773209>
1111
1112         Reviewed by Ryosuke Niwa.
1113
1114         Fallback to MacPort.CURRENT_VERSION if we are not using a known named macOS and do not have Apple Additions.
1115
1116         Darwin-based ports have OS version-specific test expectations and are certified to support running tests using
1117         the currently shipping OS by way of a hardcoded class variable CURRENT_VERSION. The run-webkit-tests script
1118         depends on the OS version to find the applicable TestExpectations files to parse to compute the list of skipped
1119         tests for the port.
1120
1121         * Scripts/webkitpy/port/mac.py:
1122         (MacPort.__init__): Fall back to MacPort.CURRENT_VERSION if we are not using a known named macOS and do not
1123         have Apple Additions.
1124         * Scripts/webkitpy/port/mac_unittest.py:
1125         (MacTest.test_factory_with_future_version): Added.
1126         (MacTest.test_factory_with_future_version_and_apple_additions): Renamed from MacTest.test_factory_with_future_version()
1127         and added code to use the mock Apple Additions so that running this code with- and without- the real Apple Additions
1128         produces consistent results now that the Mac port's OS version falls back to MacPort.CURRENT_VERSION when Apple Additions
1129         is absent.
1130
1131 2018-05-07  Brian Burg  <bburg@apple.com>
1132
1133         Web Inspector: opt out of process swap on navigation if a Web Inspector frontend is connected
1134         https://bugs.webkit.org/show_bug.cgi?id=184861
1135         <rdar://problem/39153768>
1136
1137         Reviewed by Timothy Hatcher.
1138
1139         Add a new test that checks whether a new process is used for navigation when
1140         an Inspector is shown. Also check that the behavior reverts to normal after
1141         the Inspector has been closed.
1142
1143         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1144
1145 2018-05-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1146
1147         [iOS] Multiple links in Mail are dropped in a single line, and are difficult to tell apart
1148         https://bugs.webkit.org/show_bug.cgi?id=185289
1149         <rdar://problem/35756912>
1150
1151         Reviewed by Tim Horton and Darin Adler.
1152
1153         Augment and rebaseline some iOS drag-and-drop API tests that handle dropping URLs as a part of multi-item drop
1154         sessions.
1155
1156         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1157         (TestWebKitAPI::TEST):
1158
1159 2018-05-04  Timothy Hatcher  <timothy@apple.com>
1160
1161         Deprecate legacy WebView and friends
1162         https://bugs.webkit.org/show_bug.cgi?id=185279
1163         rdar://problem/33268700
1164
1165         Reviewed by Tim Horton.
1166
1167         * MiniBrowser/Configurations/Base.xcconfig: Added GCC_PREPROCESSOR_DEFINITIONS
1168         to define DISABLE_LEGACY_WEBKIT_DEPRECATIONS.
1169
1170 2018-05-04  Leo Balter  <leonardo.balter@gmail.com>
1171
1172         Test262-Runner: Add base module to the local deps - unicore/PVA.pl
1173         https://bugs.webkit.org/show_bug.cgi?id=185314
1174
1175         Reviewed by Michael Saboff.
1176
1177         * Scripts/test262/local/lib/perl5/unicore/PVA.pl: Added.
1178
1179 2018-05-04  Wenson Hsieh  <whsieh@berkeley.edu>
1180
1181         REGRESSION: [ios-simulator] 3 WKWebViewAutofillTests API test failures seen with 11.3 SDK
1182         https://bugs.webkit.org/show_bug.cgi?id=184196
1183         <rdar://problem/39054481>
1184
1185         Reviewed by Tim Horton.
1186
1187         Removes some unnecessary workarounds to enable running app autofill tests against iOS versions
1188         earlier than 11.3. Also re-enables these tests.
1189
1190         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1191         (TestWebKitAPI::TEST):
1192         (-[UITextAutofillSuggestion initWithUsername:password:]): Deleted.
1193         (+[UITextAutofillSuggestion autofillSuggestionWithUsername:password:]): Deleted.
1194
1195 2018-05-04  Myles C. Maxfield  <mmaxfield@apple.com>
1196
1197         Text shaping in the simple path is flipped in the y direction
1198         https://bugs.webkit.org/show_bug.cgi?id=185062
1199         <rdar://problem/39778678>
1200
1201         Reviewed by Simon Fraser.
1202
1203         Huge thanks to Ulrike Rausch of LiebeFonts for contributing the test fonts!!!
1204
1205         * Scripts/webkitpy/common/config/contributors.json:
1206
1207 2018-05-04  Leo Balter  <leonardo.balter@gmail.com>
1208
1209         Test262-Runner: place the processCLI inside the main call
1210         https://bugs.webkit.org/show_bug.cgi?id=185304
1211
1212         Reviewed by Michael Saboff.
1213
1214         * Scripts/test262/Runner.pm:
1215         (main):
1216
1217 2018-05-04  Carlos Garcia Campos  <cgarcia@igalia.com>
1218
1219         [GTK] Epiphany (GNOME Web) says "Error downloading: Service Unavailable." when trying to download an image from discogs.com
1220         https://bugs.webkit.org/show_bug.cgi?id=174730
1221
1222         Reviewed by Michael Catanzaro.
1223
1224         Update unit tests to check that User-Agent header is included in HTTP download requests.
1225
1226         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
1227         (testDownloadRemoteFile):
1228         (testWebViewDownloadURI):
1229         (testPolicyResponseDownload):
1230         (testPolicyResponseDownloadCancel):
1231         (testDownloadMIMEType):
1232         (testContextMenuDownloadActions):
1233
1234 2018-05-03  Ross Kirsling  <ross.kirsling@sony.com>
1235
1236         [WinCairo] Test archive must use Python zipfile, just like build product.
1237         https://bugs.webkit.org/show_bug.cgi?id=185265
1238
1239         Reviewed by Per Arne Vollan.
1240
1241         * BuildSlaveSupport/test-result-archive:
1242         (archive_test_results):
1243         Copy over Win32-oriented archiving logic from built-product-archive.
1244
1245 2018-05-03  Leo Balter  <leonardo.balter@gmail.com>
1246
1247         cleanup modules usage for the Test262-Runner
1248         https://bugs.webkit.org/show_bug.cgi?id=185263
1249
1250         Reviewed by Michael Saboff.
1251
1252         * Scripts/test262-runner:
1253         * Scripts/test262/Runner.pm:
1254         (processCLI):
1255
1256 2018-05-03  Valerie R Young  <valerie@bocoup.com>
1257
1258         test262/Runner.pm: minor fixes
1259         https://bugs.webkit.org/show_bug.cgi?id=185250
1260
1261         Reviewed by Michael Saboff.
1262
1263         Add comments, change output and fix bug: unintended interpolation
1264         of filename when running jsc.
1265
1266         * Scripts/test262/Runner.pm:
1267         (processCLI):
1268         (main):
1269         (runTest):
1270
1271 2018-05-03  Chris Dumez  <cdumez@apple.com>
1272
1273         Load hangs if the WebProcess fails to launch
1274         https://bugs.webkit.org/show_bug.cgi?id=185225
1275         <rdar://problem/38249058>
1276
1277         Reviewed by Geoff Garen.
1278
1279         Add API test coverage.
1280
1281         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1282         * TestWebKitAPI/Tests/WebKitCocoa/WebContentProcessDidTerminate.mm: Added.
1283         (-[CrashOnStartNavigationDelegate _webView:webContentProcessDidTerminateWithReason:]):
1284         (-[CrashOnStartNavigationDelegate webView:didFinishNavigation:]):
1285         (-[CrashRecoveryScriptMessageHandler userContentController:didReceiveScriptMessage:]):
1286         (TEST):
1287
1288 2018-05-03  Don Olmstead  <don.olmstead@sony.com>
1289
1290         [WinCairo] Add JSC test bots
1291         https://bugs.webkit.org/show_bug.cgi?id=185234
1292
1293         Reviewed by Per Arne Vollan.
1294
1295         * BuildSlaveSupport/build.webkit.org-config/config.json:
1296         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1297         (RunJavaScriptCoreTests.start):
1298
1299 2018-05-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1300
1301         WebKit should send fake macOS user agent to docs.google.com
1302         https://bugs.webkit.org/show_bug.cgi?id=185165
1303
1304         Reviewed by Carlos Garcia Campos.
1305
1306         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1307         (TestWebKitAPI::TEST):
1308
1309 2018-05-03  Valerie R Young  <valerie@bocoup.com>
1310
1311         test262/Runner.pm: performance improvements
1312         https://bugs.webkit.org/show_bug.cgi?id=185202
1313
1314         Reviewed by Michael Saboff.
1315
1316         Batch the tests by the number of processes, and give each process
1317         a file to save results to to avoid threading. Do not parallelize
1318         when running small sets of tests.
1319
1320         * Scripts/test262/Runner.pm:
1321         (processCLI):
1322         (main):
1323         (processFile):
1324         (processResult):
1325
1326 2018-05-03  Ryan Haddad  <ryanhaddad@apple.com>
1327
1328         Unreviewed, rolling out r231253.
1329
1330         The API test added with this change is crashing on the bots.
1331
1332         Reverted changeset:
1333
1334         "Web Inspector: opt out of process swap on navigation if a Web
1335         Inspector frontend is connected"
1336         https://bugs.webkit.org/show_bug.cgi?id=184861
1337         https://trac.webkit.org/changeset/231253
1338
1339 2018-05-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1340
1341         REGRESSION(r222772): [GTK][WPE] WebProcess from WebKitGtk+ 2.19.9x SIGSEVs in WebKit::WebProcess::ensureNetworkProcessConnection() at Source/WebKit/WebProcess/WebProcess.cpp:1127
1342         https://bugs.webkit.org/show_bug.cgi?id=183348
1343
1344         Reviewed by Michael Catanzaro.
1345
1346         Add a test case to reproduce the crash.
1347
1348         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
1349         (testWebViewCloseQuickly):
1350         (beforeAll):
1351
1352 2018-05-02  Aditya Keerthi  <akeerthi@apple.com>
1353
1354         Can't copy and paste URLs that have no title into Mail (macOS)
1355         https://bugs.webkit.org/show_bug.cgi?id=185205
1356         <rdar://problem/36352406>
1357
1358         Reviewed by Tim Horton.
1359
1360         Added test to verify behavior when copying and pasting a URL without a title.
1361
1362         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.html:
1363         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:
1364         (TestWebKitAPI::TEST):
1365
1366 2018-05-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1367
1368         [GTK] Generate a JSC bundle on the 64 and 32 bit release bots and upload it to webkitgtk.org (follow-up fix)
1369         https://bugs.webkit.org/show_bug.cgi?id=184699
1370
1371         Unreviewed follow-up fix after r231230.
1372
1373         * Scripts/generate-jsc-bundle:
1374         (generate_wrapper_script): Quote the arguments passed to jsc.
1375
1376 2018-05-02  Brian Burg  <bburg@apple.com>
1377
1378         Web Inspector: opt out of process swap on navigation if a Web Inspector frontend is connected
1379         https://bugs.webkit.org/show_bug.cgi?id=184861
1380         <rdar://problem/39153768>
1381
1382         Reviewed by Ryosuke Niwa.
1383
1384         Add a new test that checks whether a new process is used for navigation when
1385         an Inspector is shown. Also check that the behavior reverts to normal after
1386         the Inspector has been closed.
1387
1388         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1389
1390 2018-05-02  Valerie R Young  <valerie@bocoup.com>
1391
1392         test262/Runner.pm: save summary to file
1393         https://bugs.webkit.org/show_bug.cgi?id=185200
1394
1395         Reviewed by Michael Saboff.
1396
1397         * Scripts/test262/Runner.pm:
1398         (processCLI):
1399         (main):
1400         (summarizeResults):
1401
1402 2018-05-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1403
1404         [GTK] Generate a JSC bundle on the 64 and 32 bit release bots and upload it to webkitgtk.org
1405         https://bugs.webkit.org/show_bug.cgi?id=184699
1406
1407         Reviewed by Gustavo Noronha Silva.
1408
1409         This adds a new step for the GTK 64-bit release build bot and the
1410         GTK 32-bit release build&test bot.
1411
1412         This step will be run as one of the lasts ones (after the product
1413         is built) and will execute the script generate-jsc-bundle.
1414         This script will take care of creating a JSC bundle and uploading
1415         it to a server defined on a configuration file that has to be
1416         deployed on the bots with the required server data and credentials
1417         for this upload.
1418
1419         In this case, the built products should then be accessible at
1420         <https://webkitgtk.org/jsc-built-products>. But the implementation
1421         is not tied to any specific server. All the details about where
1422         to upload the file is done in configuration file that is kept
1423         private on each bot outside of the WebKit source tree.
1424
1425         The script also supports generating a JSC bundle locally and not
1426         uploading it anywhere. This is the default mode of running.
1427         The remote upload will only be activated if a --remote-config-file
1428         parameter is passed (which is done from the buildbot config)
1429
1430         * BuildSlaveSupport/build.webkit.org-config/config.json:
1431         * BuildSlaveSupport/build.webkit.org-config/factories.py:
1432         (BuildFactory):
1433         (BuildFactory.__init__):
1434         (TestFactory):
1435         (TestFactory.__init__):
1436         (BuildAndGenerateJSCBundleFactory):
1437         (BuildAndNonLayoutTestAndGenerateJSCBundleFactory):
1438         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1439         (GenerateJSCBundle):
1440         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1441         * Scripts/generate-jsc-bundle: Added.
1442         (ldd_get_libs_and_interpreter):
1443         (generate_readme):
1444         (generate_wrapper_script):
1445         (copy_and_remove_rpath):
1446         (createJSCBundle):
1447         (sha256sum):
1448         (uploadJSCBundle):
1449         (main):
1450
1451 2018-05-01  Ryosuke Niwa  <rniwa@webkit.org>
1452
1453         PSON: Make WebKitTestRunner work with process swap on navigation turned on
1454         https://bugs.webkit.org/show_bug.cgi?id=185111
1455
1456         Reviewed by Chris Dumez.
1457
1458         Add the basic support for running layout tests with process-swap-on-navigation turned on.
1459
1460         First, move m_whatToDump, m_dumpPixels, m_waitToDump, and m_dumpFrameLoadCallbacks from WebContent process
1461         to UI process so that calls to waitUntilDone, dumpAsText, etc... persist across process swaps.
1462
1463         In addition, initialize the injected bundle inside a new WebContent process when the first page is created.
1464         This instantiates objects such as TestRunner, GCController, etc... in the new process. The initialization
1465         can't be done in InjectedBundle::beginTesting because some steps in InjectedBundle::initialize require
1466         the current PageGroup and Page objects. We avoid clearing databases and app cache in this case.
1467
1468         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1469         (WTR::InjectedBundle::didCreatePage): Send "Initialization" message to UI process. This message returns
1470         all the dictionary values usually present in "BeginTest" message from UI process as well as "ResumeTesting"
1471         boolean which is set when this process was created as a result of a process swap on navgation. Invoke
1472         beginTesting with BegingTestingMode::Resume when this boolean is set.
1473         (WTR::InjectedBundle::didReceiveMessageToPage):
1474         (WTR::InjectedBundle::beginTesting): Don't clear database, app cache, etc... when initializing an injected
1475         bundle after a process swap on navigation.
1476         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1477         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1478         (WTR::InjectedBundlePage::dump):
1479         (WTR::InjectedBundlePage::frameDidChangeLocation):
1480         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1481         (WTR::TestRunner::TestRunner):
1482         (WTR::TestRunner::shouldDumpPixels const): Added.
1483         (WTR::TestRunner::setDumpPixels): Added.
1484         (WTR::TestRunner::dumpAsText):
1485         (WTR::TestRunner::whatToDump const): Added.
1486         (WTR::TestRunner::setWhatToDump): Added.
1487         (WTR::TestRunner::waitUntilDone):
1488         (WTR::TestRunner::setWaitUntilDone): Added.
1489         (WTR::TestRunner::shouldWaitUntilDone): Added.
1490         (WTR::TestRunner::notifyDone):
1491         (WTR::TestRunner::forceImmediateCompletion):
1492         (WTR::TestRunner::setShouldDumpFrameLoadCallbacks): Added.
1493         (WTR::TestRunner::shouldDumpFrameLoadCallbacks): Added.
1494         (WTR::TestRunner::setAudioResult):
1495         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1496         (WTR::TestRunner::dumpChildFramesAsText):
1497         (WTR::TestRunner::dumpDOMAsWebArchive):
1498         (WTR::TestRunner::setShouldDumpFrameLoadCallbacks): Moved to cpp.
1499         (WTR::TestRunner::whatToDump const): Moved to cpp.
1500         (WTR::TestRunner::shouldDumpMainFrameScrollPosition const):
1501         (WTR::TestRunner::shouldDumpPixels const): Moved to cpp.
1502         (WTR::TestRunner::shouldDumpFrameLoadCallbacks const): Moved to cpp.
1503         (WTR::TestRunner::waitToDump const): Renamed to shouldWaitUntilDone and moved to cpp.
1504         * WebKitTestRunner/TestInvocation.cpp:
1505         (WTR::TestInvocation::TestInvocation): Initialize m_dumpFrameLoadCallbacks here.
1506         (WTR::TestInvocation::shouldLogFrameLoadDelegates const): Deleted.
1507         (WTR::TestInvocation::createTestSettingsDictionary): Extracted from invoke().
1508         (WTR::TestInvocation::invoke): Sets m_startedTesting to true immediately afte sending "BeginTest" message.
1509         m_startedTesting is later used in didReceiveSynchronousMessageFromInjectedBundle to detect whether a given
1510         "Initialization" message is sent from a regular WebContent process (m_startedTesting is false) or the one
1511         started as a result of a process swap on navigation (m_startedTesting is true).
1512         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle): Added a bunch of new messgaes to
1513         support initializing the injected bundle in a process swapped after navigation and set/get messages for
1514         the states which must persist across process swaps within a test.
1515         * WebKitTestRunner/TestInvocation.h:
1516         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1517         * Tools/WebKitTestRunner/WhatToDump.h:
1518         (WTR::WhatToDump): Added.
1519
1520 2018-05-01  Leo Balter  <leonardo.balter@gmail.com>
1521
1522         Auto save the results for Test262
1523         https://bugs.webkit.org/show_bug.cgi?id=184926
1524
1525         Reviewed by Michael Saboff.
1526
1527         * Scripts/test262/Runner.pm:
1528         (processCLI):
1529         (main):
1530         (parseError):
1531         (processResult):
1532         (summarizeResults):
1533         * Scripts/test262/config.yaml: Renamed from Tools/Scripts/test262/test262-config.yaml.
1534
1535 2018-05-01  Jonathan Bedard  <jbedard@apple.com>
1536
1537         webkitpy: SIGKILL right after SIGTERM causes orphaned processes with 'xcrun simctl spawn'
1538         https://bugs.webkit.org/show_bug.cgi?id=185164
1539
1540         Reviewed by David Kilzer.
1541
1542         * Scripts/webkitpy/common/system/executive.py:
1543         (Executive.kill_process): First attempt will always send a SIGTERM, all subsequent attempts will
1544         send a SIGKILL. A SIGKILL with not be sent if the process is not running to avoid orphaning childen.
1545
1546 2018-05-01  Chris Dumez  <cdumez@apple.com>
1547
1548         REGRESSION (r230919): API test WebKit.AutoLayoutIntegration is a flaky failure
1549         https://bugs.webkit.org/show_bug.cgi?id=184918
1550         <rdar://problem/39705516>
1551
1552         Reviewed by Wenson Hsieh.
1553
1554         Make sure provisional load has started before calling beginLayoutAtMinimumWidth
1555         on the AutoLayoutWKWebView to restore pre-r230919 behavior. The load now starts
1556         asynchronously because we ask the client if it is OK to do the load and the policy
1557         delegates are asynchronous nowadays.
1558
1559         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
1560         (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:resettingWidth:]):
1561         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
1562         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
1563         (-[TestNavigationDelegate webView:didStartProvisionalNavigation:]):
1564         (-[TestNavigationDelegate waitForDidStartProvisionalNavigation]):
1565         (-[WKWebView _test_waitForDidStartProvisionalNavigation]):
1566
1567 2018-05-01  Ross Kirsling  <ross.kirsling@sony.com>
1568
1569         [WinCairo] Align buildbot test stages with AppleWin.
1570         https://bugs.webkit.org/show_bug.cgi?id=185094
1571
1572         Reviewed by Brent Fulgham.
1573
1574         * BuildSlaveSupport/build.webkit.org-config/factories.py:
1575         (TestFactory.__init__):
1576         Do run API tests, don't run dashboard tests.
1577
1578         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1579         (RunUnitTests):
1580         Call run-api-tests with Python, not Perl (bugfix for r230998).
1581
1582         * Scripts/webkitpy/port/win.py:
1583         (WinPort.environment_for_api_tests):
1584         Retrieve necessary Windows environment variables.
1585
1586 2018-05-01  Eric Carlson  <eric.carlson@apple.com>
1587
1588         [MediaStream] remove WK1 support
1589         https://bugs.webkit.org/show_bug.cgi?id=185136
1590
1591         Reviewed by Youenn Fablet.
1592
1593         * DumpRenderTree/mac/UIDelegate.mm:
1594         (-[UIDelegate webView:decidePolicyForUserMediaRequestFromOrigin:listener:]): Deleted.
1595
1596 2018-05-01  Chris Dumez  <cdumez@apple.com>
1597
1598         [WKTR] Move navigation policy for response decision from InjectedBundle to UIProcess
1599         https://bugs.webkit.org/show_bug.cgi?id=185157
1600
1601         Reviewed by Geoffrey Garen.
1602
1603         Move navigation policy for response decision from InjectedBundle to UIProcess. This is a more
1604         common configuration and should therefore be the configuration we test by default.
1605
1606         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1607         (WTR::InjectedBundlePage::decidePolicyForResponse):
1608
1609 2018-05-01  Oleksandr Skachkov  <gskachkov@gmail.com>
1610
1611         WebAssembly: add support for stream APIs - JavaScript API
1612         https://bugs.webkit.org/show_bug.cgi?id=183442
1613
1614         Reviewed by Yusuke Suzuki and JF Bastien.
1615
1616         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1617
1618 2018-04-30  Mark Lam  <mark.lam@apple.com>
1619
1620         Apply PtrTags to the MetaAllocator and friends.
1621         https://bugs.webkit.org/show_bug.cgi?id=185110
1622         <rdar://problem/39533895>
1623
1624         Reviewed by Saam Barati.
1625
1626         Update the test to match MetaAllocator changes in WTF.
1627
1628         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
1629         (TestWebKitAPI::TEST_F):
1630         (WTF::tagForPtr):
1631         (WTF::ptrTagName):
1632
1633 2018-04-30  Alex Christensen  <achristensen@webkit.org>
1634
1635         Add WKUIDelegatePrivate equivalent of WKPageContextMenuClient getContextMenuFromProposedMenuAsync
1636         https://bugs.webkit.org/show_bug.cgi?id=180955
1637
1638         Reviewed by Andy Estes.
1639
1640         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuImgWithVideo.mm:
1641         (-[ContextMenuImgWithVideoDelegate _webView:contextMenu:forElement:]):
1642         (-[ContextMenuImgWithVideoDelegate _webView:getContextMenuFromProposedMenu:forElement:userInfo:completionHandler:]):
1643
1644 2018-04-30  JF Bastien  <jfbastien@apple.com>
1645
1646         Use some C++17 features
1647         https://bugs.webkit.org/show_bug.cgi?id=185135
1648
1649         Reviewed by Alex Christensen.
1650
1651         * DumpRenderTree/PlatformMac.cmake:
1652         * gtk/ycm_extra_conf.py:
1653         (FlagsForFile):
1654
1655 2018-04-30  Yusuke Suzuki  <utatane.tea@gmail.com>
1656
1657         Use WordLock instead of std::mutex for Threading
1658         https://bugs.webkit.org/show_bug.cgi?id=185121
1659
1660         Reviewed by Geoffrey Garen.
1661
1662         * TestWebKitAPI/Tests/WTF/Signals.cpp:
1663         (TEST):
1664
1665 2018-04-30  Michael Catanzaro  <mcatanzaro@igalia.com>
1666
1667         [GTK] Webkit should spoof as Safari on a Mac when on Chase.com
1668         https://bugs.webkit.org/show_bug.cgi?id=185103
1669
1670         Reviewed by Carlos Garcia Campos.
1671
1672         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1673         (TestWebKitAPI::TEST):
1674
1675 2018-04-28  Sihui Liu  <sihui_liu@apple.com>
1676
1677         [Cocoa] Set HTTPOnly flag when converting Cookie to NSHTTPCookie
1678         https://bugs.webkit.org/show_bug.cgi?id=185052
1679
1680         Reviewed by Geoffrey Garen.
1681
1682         Modified API test to provide correct test cases for HTTPOnly flag.
1683
1684         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
1685         (TEST):
1686
1687 2018-04-28  Rick Waldron  <waldron.rick@gmail.com>
1688
1689         Token misspelled "tocken" in error message string
1690         https://bugs.webkit.org/show_bug.cgi?id=185030
1691
1692         Reviewed by Saam Barati.
1693
1694         * Scripts/test262/test262-expectations.yaml: Fix typo "tocken" => "token"
1695
1696 2018-04-27  Stephan Szabo  <stephan.szabo@sony.com>
1697
1698         [WinCairo] Support --no-copy for jsc tests in wincairo tests, add copying of dlls for copy case
1699         https://bugs.webkit.org/show_bug.cgi?id=185049
1700
1701         Reviewed by Keith Miller.
1702
1703         * Scripts/run-javascriptcore-tests:
1704         (runJSCStressTests):
1705         * Scripts/run-jsc-stress-tests:
1706
1707 2018-04-26  Ryosuke Niwa  <rniwa@webkit.org>
1708
1709         PSON: Triggering a navigation to an invalid URL creates a new WebContent process
1710         https://bugs.webkit.org/show_bug.cgi?id=185066
1711
1712         Reviewed by Youenn Fablet.
1713
1714         Added a new test case (ProcessSwap.NavigateToInvalidURL) for navigating to an invalid URL.
1715         WebKit should not swap WebContent process in this case.
1716
1717         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1718         (-[PSONNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
1719         (-[PSONUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1720
1721 2018-04-27  Nan Wang  <n_wang@apple.com>
1722
1723         AX: Accessibility needs to know which part of the content view is visible on iOS
1724         https://bugs.webkit.org/show_bug.cgi?id=185085
1725         <rdar://problem/39801363>
1726
1727         Reviewed by Chris Fleizach.
1728
1729         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1730         (WTR::AccessibilityUIElement::stringAttributeValue):
1731
1732 2018-04-27  Wenson Hsieh  <wenson_hsieh@apple.com>
1733
1734         [Extra zoom mode] Add a mechanism to override default viewport behaviors in extra zoom mode
1735         https://bugs.webkit.org/show_bug.cgi?id=185050
1736         <rdar://problem/39624038>
1737
1738         Reviewed by Tim Horton.
1739
1740         Remove a test that's no longer useful, now that the SPI it was testing is gone. This functionality is now
1741         tested by the layout test added in this patch.
1742
1743         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1744         * TestWebKitAPI/Tests/ios/ViewportSizingTests.mm: Removed.
1745
1746 2018-04-26  Ryan Haddad  <ryanhaddad@apple.com>
1747
1748         REGRESSION (r231039): RunUnitTests step reports disabled tests as failures
1749         https://bugs.webkit.org/show_bug.cgi?id=185061
1750
1751         Reviewed by Aakash Jain.
1752
1753         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1754         (RunUnitTests.countFailures): Return the difference between the total number of tests run and the number that passed.
1755         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Add a test.
1756
1757 2018-04-26  Ross Kirsling  <ross.kirsling@sony.com>
1758
1759         Add release bots for WinCairo.
1760         https://bugs.webkit.org/show_bug.cgi?id=185042
1761
1762         Reviewed by Lucas Forschler.
1763
1764         * BuildSlaveSupport/build.webkit.org-config/config.json:
1765         Add a release build bot and two test bots, replacing the outdated WinCairo release bots.
1766
1767 2018-04-26  Sihui Liu  <sihui_liu@apple.com>
1768
1769         -[WKHTTPCookieStore deleteCookie:completionHandler:] doesn't delete cookies
1770         https://bugs.webkit.org/show_bug.cgi?id=184938
1771         <rdar://problem/34737395>
1772
1773         Reviewed by Geoffrey Garen.
1774
1775         Add API test coverage.
1776
1777         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
1778         (TEST):
1779
1780 2018-04-26  Ross Kirsling  <ross.kirsling@sony.com>
1781
1782         WinCairo test bots should run JSC tests with options for Windows command prompt.
1783         https://bugs.webkit.org/show_bug.cgi?id=185019
1784
1785         Reviewed by Per Arne Vollan.
1786
1787         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1788         (RunJavaScriptCoreTests.start):
1789
1790 2018-04-26  Ross Kirsling  <ross.kirsling@sony.com>
1791
1792         WinCairo WKL Debug Test bot is not using DRT.
1793         https://bugs.webkit.org/show_bug.cgi?id=185009
1794
1795         Reviewed by Per Arne Vollan.
1796
1797         * BuildSlaveSupport/build.webkit.org-config/config.json:
1798
1799 2018-04-26  Per Arne Vollan  <pvollan@apple.com>
1800
1801         Disable content filtering in minimal simulator mode
1802         https://bugs.webkit.org/show_bug.cgi?id=185027
1803         <rdar://problem/39736091>
1804
1805         Reviewed by Jer Noble.
1806
1807         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1808
1809 2018-04-26  Brady Eidson  <beidson@apple.com>
1810
1811         Add a setting for keeping around all processes and always reusing them per-origin.
1812         <rdar://problem/39695798> and https://bugs.webkit.org/show_bug.cgi?id=185020
1813
1814         Reviewed by Andy Estes.
1815
1816         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1817
1818 2018-04-26  Andy VanWagoner  <thetalecrafter@gmail.com>
1819
1820         [INTL] Implement Intl.PluralRules
1821         https://bugs.webkit.org/show_bug.cgi?id=184312
1822
1823         Reviewed by JF Bastien.
1824
1825         Added Intl.PluralRules feature flag.
1826
1827         * Scripts/webkitperl/FeatureList.pm:
1828         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1829
1830 2018-04-25  Michael Catanzaro  <mcatanzaro@igalia.com>
1831
1832         [WPE] Build and link against latest WPEBackend and WPEBackend-fdo
1833         https://bugs.webkit.org/show_bug.cgi?id=184643
1834
1835         Reviewed by Žan Doberšek.
1836
1837         Add missing INCLUDE_DIRS in many places.
1838
1839         Adapt to single-header WPE includes.
1840
1841         Null-initialize padding to silence -Wmissing-field-initializers. (Yuck.)
1842
1843         * TestWebKitAPI/PlatformWPE.cmake:
1844         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
1845         (testWebViewWebBackend):
1846         * TestWebKitAPI/glib/PlatformWPE.cmake:
1847         * WebKitTestRunner/EventSenderProxy.h:
1848         * WebKitTestRunner/PlatformWPE.cmake:
1849         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
1850         * wpe/HeadlessViewBackend/CMakeLists.txt:
1851         * wpe/HeadlessViewBackend/HeadlessViewBackend.cpp:
1852         * wpe/HeadlessViewBackend/HeadlessViewBackend.h:
1853         * wpe/jhbuild.modules:
1854
1855 2018-04-25  Jonathan Bedard  <jbedard@apple.com>
1856
1857         REGRESSION (r230998): Bot watcher's dashboard doesn't display number of API test failures
1858         https://bugs.webkit.org/show_bug.cgi?id=184982
1859
1860         Rubber-stamped by Aakash Jain.
1861
1862         Correctly count the number of API test failures.
1863
1864         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1865         (RunUnitTests.countFailures): Count the number of test failures for the new run-api-tests.
1866         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1867         * Scripts/webkitpy/api_tests/manager.py:
1868         (Manager.run): Disabled tests are not run.
1869
1870 2018-04-25  Jiewen Tan  <jiewen_tan@apple.com>
1871
1872         Remove access to keychain from the WebContent process
1873         https://bugs.webkit.org/show_bug.cgi?id=184428
1874         <rdar://problem/13150903>
1875
1876         Reviewed by Brent Fulgham.
1877
1878         This patch does the followings:
1879         1. Added an API test for this patch.
1880         2. Instrument DumpRenderTree and WebKitTestRunner to take advantages of new SPIs.
1881
1882         * DumpRenderTree/mac/UIDelegate.mm:
1883         (-[UIDelegate signedPublicKeyAndChallengeStringForWebView:]):
1884         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1885         * TestWebKitAPI/Tests/mac/SSLKeyGenerator.mm: Added.
1886         (TestWebKitAPI::SSLKeyGeneratorTest::SetUp):
1887         (TestWebKitAPI::SSLKeyGeneratorTest::TearDown):
1888         (TestWebKitAPI::TEST_F):
1889         * WebKitTestRunner/TestController.cpp:
1890         (WTR::copySignedPublicKeyAndChallengeString):
1891         (WTR::TestController::createOtherPage):
1892         (WTR::TestController::createWebViewWithOptions):
1893
1894 2018-04-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1895
1896         [Extra zoom mode] The search field on www.bing.com is missing label text
1897         https://bugs.webkit.org/show_bug.cgi?id=184975
1898         <rdar://problem/39723081>
1899
1900         Reviewed by Tim Horton.
1901
1902         Adds UIScriptController.formInputLabel, which asynchronously requests the input label text for the currently
1903         focused element in extra zoom mode.
1904
1905         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1906         (WTR::UIScriptController::formInputLabel const):
1907         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1908         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1909         (WTR::UIScriptController::formInputLabel const):
1910         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1911         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1912         (WTR::UIScriptController::formInputLabel const):
1913
1914 2018-04-25  Michael Catanzaro  <mcatanzaro@igalia.com>
1915
1916         [WPE] Should load injected bundle from builddir in developer builds
1917         https://bugs.webkit.org/show_bug.cgi?id=184983
1918
1919         Reviewed by Carlos Alberto Lopez Perez.
1920
1921         Set WEBKIT_INJECTED_BUNDLE_PATH when running WPE MiniBrowser.
1922
1923         * Scripts/run-minibrowser:
1924
1925 2018-04-25  Michael Catanzaro  <mcatanzaro@igalia.com>
1926
1927         [WPE] libgstggtk.so broken in jhbuild environment
1928         https://bugs.webkit.org/show_bug.cgi?id=184984
1929
1930         Reviewed by Carlos Alberto Lopez Perez.
1931
1932         Don't pass --enable-glx=no when building libepoxy, to ensure it's compatible with
1933         gst-plugins-good.
1934
1935         * wpe/jhbuild.modules:
1936
1937 2018-04-25  Ryosuke Niwa  <rniwa@webkit.org>
1938
1939         PSON: Don't create a new process when navigating to a blob URL, data URL, and about:blank
1940         https://bugs.webkit.org/show_bug.cgi?id=184962
1941
1942         Reviewed by Youenn Fablet.
1943
1944         Added four test cases for navigating to a blob URL, data URL, and about:blank with process-swap-on-navigation turned on.
1945
1946         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1947         (ProcessSwap.SameOriginBlobNavigation): Added.
1948         (ProcessSwap.CrossOriginBlobNavigation): Added.
1949         (ProcessSwap.NavigateToAboutBlank): Added.
1950         (ProcessSwap.NavigateToDataURL): Added.
1951
1952 2018-04-25  Michael Catanzaro  <mcatanzaro@igalia.com>
1953
1954         [WPE] Remove deprecated functions and properties from the API
1955         https://bugs.webkit.org/show_bug.cgi?id=179295
1956
1957         Reviewed by Žan Doberšek.
1958
1959         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
1960         (testWebViewAuthenticationStorage): Disable this test for now. It will require some effort
1961         to rewrite LoadTrackingTest to not require the web view at construction time.
1962         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1963         (testWebKitSettings): Don't test private browsing setting, which is gone.
1964         * TestWebKitAPI/glib/CMakeLists.txt: Disable TestCookieManager for now.
1965
1966 2018-04-25  Andy Estes  <aestes@apple.com>
1967
1968         [Mac] Number of drop items is always 0 when performing a DHTML drag
1969         https://bugs.webkit.org/show_bug.cgi?id=184943
1970
1971         Reviewed by Ryosuke Niwa.
1972
1973         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1974         * TestWebKitAPI/Tests/mac/DragAndDropPasteboardTests.mm:
1975         (-[DragInfo numberOfValidItemsForDrop]):
1976         (-[DragInfo setNumberOfValidItemsForDrop:]):
1977         (TestWebKitAPI::TEST):
1978         * TestWebKitAPI/Tests/mac/full-page-dropzone.html: Added.
1979
1980 2018-04-25  Jonathan Bedard  <jbedard@apple.com>
1981
1982         API test harness should be Python
1983         https://bugs.webkit.org/show_bug.cgi?id=181043
1984         <rdar://problem/36164410>
1985
1986         Reviewed by David Kilzer.
1987
1988         Run API tests from a Python script rather than Perl. The Python API tests have
1989         the same structure as the layout tests.
1990
1991         * Scripts/run-api-tests: Changed from Perl to Python.
1992         * Scripts/webkitpy/api_tests: Added.
1993         * Scripts/webkitpy/api_tests/__init__.py: Added.
1994         * Scripts/webkitpy/api_tests/manager.py: Added.
1995         (Manager):
1996         (Manager.__init__):
1997         (Manager._test_list_from_output): Construct a list of tests from the output of
1998         TestWTF and TestWebKitAPI.
1999         (Manager._find_test_subset): Given a list of all possible tests and command line
2000         arguments, return a list of tests which match the provided arguments.
2001         (Manager._collect_tests): Run TestWTF and TestWebKitAPI with --gtest_list_tests
2002         to determine which tests will be run.
2003         (Manager._print_test_result): Formatted print of a test with it's output.
2004         (Manager._print_tests_result_with_status): Print all tests and output for tests
2005         which ran with a specified exit status.
2006         (Manager.run): Collect all tests, run them and then print results from the run.
2007         * Scripts/webkitpy/api_tests/run_api_tests.py: Added.
2008         (main): Parse arguments, construct a port, early exit for illegal ports and
2009         then run tests.
2010         (run): Setup logging and printing before using the Manager to run tests.
2011         (parse_args): Use argparse to define all options used by run-api-tests.
2012         * Scripts/webkitpy/api_tests/runner.py: Added.
2013         (Runner):
2014         (Runner.__init__):
2015         (Runner._shard_tests): Split tests so that each suite runs together.
2016         (Runner.command_for_port): Run a command on the device specified by the given
2017         port object. Once <https://bugs.webkit.org/show_bug.cgi?id=175204> is completed,
2018         this function would be entirely replaced by the server_process factory owned
2019         by the port object.
2020         (Runner.run): Run all shards in the message_pool.
2021         (Runner.handle): Handle reports from child processes.
2022         (Runner.result_map_by_status): Return a mapping of tests to output for tests
2023         which exit with a specific status.
2024         (_Worker):
2025         (_Worker.__init__):
2026         (_Worker._filter_noisy_output): Filter out objc warnings since these polite the log.
2027         (_Worker._run_single_test): Runs a single test in a single child process.
2028         (_Worker._run_shard_with_binary): Attempts to run a group of tests in the same
2029         child process. If this technique fails, the remaining tests are run singly.
2030         (_Worker.handle): Run the specified shard.
2031         * Scripts/webkitpy/port/base.py:
2032         (Port):
2033         (Port.check_api_test_build): Check if TestWTF and TestWebKitAPI are built.
2034         (Port.environment_for_api_tests): Return the environment needed to run
2035         the TestWebKitAPI binary.
2036         (Port. path_to_api_test_binaries): Return a list of the path to all binaries
2037         used when running API tests.
2038         (Port._build_api_tests): Build TestWTF and TestWebKitAPI if required.
2039         * Scripts/webkitpy/port/mac.py:
2040         (MacPort.environment_for_api_tests): Enable GuardMalloc for API tests.
2041         * Scripts/webkitpy/port/server_process.py: 
2042         (ServerProcess.pop_all_buffered_stdout):
2043
2044 2018-04-25  Carlos Garcia Campos  <cgarcia@igalia.com>
2045
2046         Incorrect number of WebDriver test failures shown in the bots
2047         https://bugs.webkit.org/show_bug.cgi?id=184959
2048
2049         Reviewed by Michael Catanzaro.
2050
2051         The regular expression we are using to get the number of failures from the log is matching a particular test
2052         error output. Improve the regular expression to avoid matching other strings in the log. Ensure that only
2053         matches at the beginning of lines and add spaces after Unexpected and before the (<failures>).
2054
2055         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2056         (RunWebDriverTests.commandComplete):
2057
2058 2018-04-25  Carlos Garcia Campos  <cgarcia@igalia.com>
2059
2060         [GTK] Implement MouseEvent.buttons
2061         https://bugs.webkit.org/show_bug.cgi?id=184913
2062
2063         Reviewed by Žan Doberšek.
2064
2065         Include the mouse buttons state in WTR synthesized events.
2066
2067         * WebKitTestRunner/EventSenderProxy.h:
2068         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
2069         (WTR::EventSenderProxy::EventSenderProxy):
2070         (WTR::EventSenderProxy::createMouseButtonEvent):
2071         (WTR::EventSenderProxy::mouseDown):
2072         (WTR::EventSenderProxy::mouseUp):
2073         (WTR::EventSenderProxy::mouseMoveTo):
2074
2075 2018-04-24  Pablo Saavedra  <psaavedra@igalia.com>
2076
2077         [GTK][WPE] Fix triggered bot name on the WPE Debug Build bot
2078         https://bugs.webkit.org/show_bug.cgi?id=184954
2079
2080         Reviewed by Michael Catanzaro.
2081
2082         * BuildSlaveSupport/build.webkit.org-config/config.json:
2083
2084 2018-04-24  Saam Barati  <sbarati@apple.com>
2085
2086         Keep around a pre-warmed process when doing process swap on navigation
2087         https://bugs.webkit.org/show_bug.cgi?id=184765
2088         <rdar://problem/39685099>
2089
2090         Reviewed by Ryosuke Niwa and Brady Eidson.
2091
2092         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2093
2094 2018-04-24  Aakash Jain  <aakash_jain@apple.com>
2095
2096         [build.webkit.org] unit-tests fail when passwords.json is missing
2097         https://bugs.webkit.org/show_bug.cgi?id=180390
2098
2099         Reviewed by Carlos Alberto Lopez Perez.
2100
2101         * BuildSlaveSupport/build.webkit.org-config/loadConfig.py:
2102         (loadBuilderConfig): Add support for test_mode. Load mock passwords in test_mode.
2103         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2104         (BuildBotConfigLoader._add_dependant_modules_to_sys_modules): Call _add_webkitpy_to_sys_path as well.
2105         (BuildBotConfigLoader._mock_open): Deleted.
2106         (BuildBotConfigLoader.load_config): Deleted.
2107
2108 2018-04-24  John Wilander  <wilander@apple.com>
2109
2110         From-Origin: Support for 'same' and 'same-site' response header, nested frame origin check
2111         https://bugs.webkit.org/show_bug.cgi?id=184560
2112         <rdar://problem/38901344>
2113
2114         Reviewed by Youenn Fablet and Daniel Bates.
2115
2116         This patch implements significant parts of https://github.com/whatwg/fetch/issues/687.
2117         We consume the From-Origin response header and only load the resource if:
2118         - The header is non-existent, empty, or invalid.
2119         - The header specifies 'same' and the resource's origin matches the originating
2120           document's origin and the origins up the frame tree.
2121         - The header specifies 'same-site' and the resource's eTLD+1 matches the originating
2122           document's eTLD+1 and the eTLD+1 of the documents up the frame tree.
2123
2124         This feature is experimental and off by default.
2125
2126         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2127         * TestWebKitAPI/Tests/WebCore/HTTPParsers.cpp: Added.
2128         (TestWebKitAPI::TEST):
2129             Tests for From-Origin header parsing.
2130
2131 2018-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2132
2133         Unreviewed. Update W3C WebDriver imported tests.
2134
2135         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
2136         (WebDriverW3CExecutor.__init__):
2137
2138 2018-04-24  Zan Dobersek  <zdobersek@igalia.com>
2139
2140         [WPE] Remove libgbm dependency
2141         https://bugs.webkit.org/show_bug.cgi?id=184906
2142
2143         Reviewed by Carlos Garcia Campos.
2144
2145         Stop searching for libgbm, using its compiler flags for the
2146         HeadlessViewBackend compilation and linking against the .so object.
2147         This is not necessary anymore after r230562 switched to a different
2148         backend implementation for testing.
2149
2150         * wpe/HeadlessViewBackend/CMakeLists.txt:
2151         * wpe/install-dependencies:
2152
2153 2018-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2154
2155         [GLIB] Make it possible to use a different timeout for slow test cases in GLib tests
2156         https://bugs.webkit.org/show_bug.cgi?id=184816
2157
2158         Reviewed by Michael Catanzaro.
2159
2160         Pass a function from api test runner to glib test runner to check if a test is slow and use the given slow
2161         timeout.
2162
2163         * TestWebKitAPI/glib/TestExpectations.json:
2164         * glib/api_test_runner.py:
2165         (TestRunner._run_test_glib.is_slow_test):
2166         (TestRunner._run_test_glib):
2167         * glib/glib_test_runner.py:
2168         (GLibTestRunner.__init__):
2169         (GLibTestRunner._stop_timeout):
2170         (GLibTestRunner._subtest_start):
2171         (GLibTestRunner._subtest_end):
2172
2173 2018-04-23  Wenson Hsieh  <wenson_hsieh@apple.com>
2174
2175         [Extra zoom mode] REGRESSION(230860) Unable to change time input values using UI
2176         https://bugs.webkit.org/show_bug.cgi?id=184901
2177         <rdar://problem/39664797>
2178
2179         Reviewed by Tim Horton.
2180
2181         Introduce a new UIScriptController method to set the value of a currently focused input of type time, by
2182         interacting with the UI. See WebKit ChangeLogs for more detail.
2183
2184         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2185         (WTR::UIScriptController::setTimePickerValue):
2186         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2187         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2188         (WTR::UIScriptController::setTimePickerValue):
2189         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2190         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2191         (WTR::UIScriptController::setTimePickerValue):
2192
2193 2018-04-23  Zalan Bujtas  <zalan@apple.com>
2194
2195         [LayoutFormattingContext] Initial commit.
2196         https://bugs.webkit.org/show_bug.cgi?id=184896
2197
2198         Reviewed by Antti Koivisto.
2199
2200         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2201
2202 2018-04-23  Chris Dumez  <cdumez@apple.com>
2203
2204         [WKTR] Move navigation policy decision from the injected bundle to the UIProcess
2205         https://bugs.webkit.org/show_bug.cgi?id=184801
2206
2207         Reviewed by Geoffrey Garen.
2208
2209         Move navigation policy decision from the injected bundle to the UIProcess in WebKitTestRunner.
2210         This is a more common configuration and therefore should be the default testing configuration.
2211
2212         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2213         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
2214         Always respond with 'PassThrough' in the InjectedBundle so the UIProcess
2215         is now asked for the policy decision.
2216
2217 2018-04-23  Pablo Saavedra  <psaavedra@igalia.com>
2218
2219         [GTK][WPE] Add Debug bots (build and tests) for WPE
2220         https://bugs.webkit.org/show_bug.cgi?id=184887
2221
2222         Reviewed by Carlos Alberto Lopez Perez.
2223
2224         Deployed 2 new bots for WPE Debug: wpe-linux-bot-3 and
2225         wpe-linux-bot-4
2226
2227         Both bots have already the credentials ready to authenticated against
2228         build.webkit.org. They provides the bots for the "debug" configuration over
2229         the "WPE" platform and building for the "x86_64" architecture:
2230         WPE Linux 64-bit Debug (Build) and WPE Linux 64-bit Debug (Tests) 
2231
2232         * BuildSlaveSupport/build.webkit.org-config/config.json:
2233         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2234
2235 2018-04-23  Chris Dumez  <cdumez@apple.com>
2236
2237         HTML String load cannot be prevented by responding 'Cancel' asynchronously in decidePolicyForNavigationAction
2238         https://bugs.webkit.org/show_bug.cgi?id=184848
2239         <rdar://problem/39145306>
2240
2241         Reviewed by Brady Eidson.
2242
2243         Add API test coverage.
2244
2245         * TestWebKitAPI/Tests/WebKitCocoa/DecidePolicyForNavigationAction.mm:
2246         (-[DecidePolicyForNavigationActionController webView:decidePolicyForNavigationAction:decisionHandler:]):
2247         (TEST):
2248
2249 2018-04-23  Michael Catanzaro  <mcatanzaro@igalia.com>
2250
2251         [GTK][WPE] TestSSL fails due to additional TLS errors returned
2252         https://bugs.webkit.org/show_bug.cgi?id=184860
2253
2254         Reviewed by Carlos Garcia Campos.
2255
2256         Add script and config file for regenerating the test certificate.
2257         Regenerate it. TestSSL no longer fails on my machine.
2258
2259         I do see a ton of network process crashes and JavaScript errors, none of
2260         which prevent the test from passing, but this commit only claims to fix
2261         the certificate validation portion of the test.
2262
2263         * TestWebKitAPI/Tests/WebKitGLib/resources/generate-test-cert.sh: Added.
2264         * TestWebKitAPI/Tests/WebKitGLib/resources/test-cert.conf: Added.
2265         * TestWebKitAPI/Tests/WebKitGLib/resources/test-cert.pem:
2266
2267 2018-04-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2268
2269         [GLIB] ERROR: Thread was unable to be detached when running /jsc/vm test in debug
2270         https://bugs.webkit.org/show_bug.cgi?id=184815
2271
2272         Reviewed by Michael Catanzaro.
2273
2274         This is because in the test we are calling both join and detach. We should only call join.
2275
2276         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2277         (testsJSCVirtualMachine):
2278
2279 2018-04-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2280
2281         [GLIB] Test /jsc/prototypes crashes in debug
2282         https://bugs.webkit.org/show_bug.cgi?id=184814
2283
2284         Reviewed by Michael Catanzaro.
2285
2286         We should also call the constructor/destructor of Bar struct to ensure Foo is constructed.
2287
2288         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2289         (barCreate):
2290         (barFree):
2291
2292 2018-04-20  Michael Catanzaro  <mcatanzaro@igalia.com>
2293
2294         REGRESSION(r228088): [SOUP] Check TLS errors for WebSockets on GTlsConnection::accept-certificate
2295         https://bugs.webkit.org/show_bug.cgi?id=184804
2296
2297         Reviewed by Carlos Garcia Campos.
2298
2299         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
2300         (WebSocketTest::WebSocketTest):
2301         (WebSocketTest::~WebSocketTest):
2302         (WebSocketTest::serverWebSocketCallback):
2303         (WebSocketTest::webSocketTestResultCallback):
2304         (WebSocketTest::connectToServerAndWaitForEvents):
2305         (testWebSocketTLSErrors):
2306         (beforeAll):
2307
2308 2018-04-20  Chris Dumez  <cdumez@apple.com>
2309
2310         Unreviewed, update 2 more API tests after r230876.
2311
2312         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
2313         (TEST):
2314         * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
2315         (TestWebKitAPI::TEST):
2316
2317 2018-04-20  Tim Horton  <timothy_horton@apple.com>
2318
2319         Adjust geolocation feature flag
2320         https://bugs.webkit.org/show_bug.cgi?id=184856
2321
2322         Reviewed by Wenson Hsieh.
2323
2324         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2325
2326 2018-04-20  Chris Dumez  <cdumez@apple.com>
2327
2328         REGRESSION (r229828): web view doesn’t update or respond to resizing until client calls policy decision handler
2329         https://bugs.webkit.org/show_bug.cgi?id=184210
2330         <rdar://problem/39072354>
2331
2332         Reviewed by Wenson Hsieh.
2333
2334         * TestWebKitAPI/Tests/WebKit/large-red-square-image.html:
2335         * TestWebKitAPI/Tests/WebKitCocoa/dragstart-change-selection-offscreen.html:
2336         Add viewport meta tags.
2337
2338         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
2339         (-[WKWebView _test_waitForDidFinishNavigation]):
2340         Update _test_waitForDidFinishNavigation to wait for the next presentation update
2341         to make iOS API tests happy without having to modify each of them.
2342
2343 2018-04-20  Timothy Hatcher  <timothy@apple.com>
2344
2345         REGRESSION: API test WebKit.BackgroundColorSystemColor is failing
2346
2347         https://bugs.webkit.org/show_bug.cgi?id=184849
2348         rdar://problem/39386405
2349
2350         Reviewed by Brian Burg.
2351
2352         * TestWebKitAPI/Tests/mac/BackgroundColor.mm:
2353         (TestWebKitAPI::TEST): Use CGColorEqualToColor since we might get a different
2354         CGColor pointer from NSColor each time.
2355
2356 2018-04-20  Wenson Hsieh  <wenson_hsieh@apple.com>
2357
2358         [Extra zoom mode] Injected bundle form client should be notified when editing text fields
2359         https://bugs.webkit.org/show_bug.cgi?id=184822
2360         <rdar://problem/38807319>
2361
2362         Reviewed by Tim Horton.
2363
2364         Add WebKitTestRunner support for listening to form editing SPI hooks in the injected bundle. The new layout test
2365         installs callbacks that listen for "begin editing", "end editing", and "text changed" calls to injected bundle
2366         SPI. See other ChangeLogs for more detail.
2367
2368         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2369         (WTR::UIScriptController::enterText):
2370         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2371
2372         Add UIScriptController support for simulating text entry in the currently focused element.
2373
2374         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2375         (WTR::UIScriptController::enterText):
2376         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2377         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2378
2379         Add TestRunner bindings for registering injected bundle form client callbacks.
2380
2381         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2382         (WTR::handleTextDidChangeInTextField):
2383         (WTR::handleTextFieldDidBeginEditing):
2384         (WTR::handleTextFieldDidEndEditing):
2385         (WTR::InjectedBundle::didCreatePage):
2386
2387         Set the injected bundle form editor client.
2388
2389         (WTR::InjectedBundle::setUpInjectedBundleClients):
2390         (WTR::InjectedBundle::textDidChangeInTextField):
2391         (WTR::InjectedBundle::textFieldDidBeginEditing):
2392         (WTR::InjectedBundle::textFieldDidEndEditing):
2393         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2394         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2395         (WTR::TestRunner::installTextDidChangeInTextFieldCallback):
2396         (WTR::TestRunner::textDidChangeInTextFieldCallback):
2397         (WTR::TestRunner::installTextFieldDidBeginEditingCallback):
2398         (WTR::TestRunner::textFieldDidBeginEditingCallback):
2399         (WTR::TestRunner::installTextFieldDidEndEditingCallback):
2400         (WTR::TestRunner::textFieldDidEndEditingCallback):
2401         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2402         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2403         (WTR::UIScriptController::enterText):
2404
2405 2018-04-20  Youenn Fablet  <youenn@apple.com>
2406
2407         WebPage sometimes incorrectly rules out PDF as a mime type that can be showed
2408         https://bugs.webkit.org/show_bug.cgi?id=184369
2409
2410         Reviewed by Chris Dumez.
2411
2412         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
2413         (TEST):
2414
2415 2018-04-20  Daniel Bates  <dabates@apple.com>
2416
2417         Remove Strong Password decoration when text field type changes
2418         https://bugs.webkit.org/show_bug.cgi?id=184795
2419         <rdar://problem/38325108>
2420
2421         Reviewed by Antti Koivisto.
2422
2423         Add a unit test to ensure the injected bundle API and WebKit UI delegate SPI is invoked
2424         when the field has the Strong Password button and its type changes.
2425
2426         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2427         * TestWebKitAPI/Tests/WebKitCocoa/DidResignInputElementStrongPasswordAppearance.mm: Added.
2428         (didResignInputElementStrongPasswordAppearance):
2429         (-[DidResignInputElementStrongPasswordAppearance webProcessPlugIn:didCreateBrowserContextController:]):
2430         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2431         (-[DidResignInputElementStrongPasswordAppearanceDelegate _webView:didResignInputElementStrongPasswordAppearanceWithUserInfo:]):
2432         (-[DidResignInputElementStrongPasswordAppearanceDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2433         (TEST):
2434
2435 2018-04-20  Brady Eidson  <beidson@apple.com>
2436
2437         Add a test to verify load/unload/pageshow/pagehide all work with process swapping.
2438         https://bugs.webkit.org/show_bug.cgi?id=184807
2439
2440         Reviewed by Chris Dumez.
2441
2442         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2443         (-[PSONMessageHandler userContentController:didReceiveScriptMessage:]):
2444
2445 2018-04-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2446
2447         Unreviewed. Mark TestJSC as slow in debug.
2448
2449         Only /jsc/vm is slow, but GLib API test runner only checks the test binary for GLib tests.
2450
2451         * TestWebKitAPI/glib/TestExpectations.json:
2452
2453 2018-04-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2454
2455         [GTK] Local cross references are broken in API documentation
2456         https://bugs.webkit.org/show_bug.cgi?id=184771
2457
2458         Reviewed by Michael Catanzaro.
2459
2460         The problem is that gtkdoc-fixxref expects the links to be in the form html/modulename (like the installed
2461         ones), but we generate the documentation as modulename/html. So, links to WebKitDOM or JSC are generated as
2462         ../html/Foo. The rebase command considers html to be the module name in this case, creating broken links in all
2463         the cases.
2464
2465         * gtk/gtkdoc.py:
2466         (GTKDoc._copy_doc_files_to_output_dir): We don't have any html dir in the source tree so, we are not copying
2467         anything here.
2468         (GTKDoc._run_gtkdoc_mkhtml): Create the html dir here using html/modulename instead now.
2469         (GTKDoc._run_gtkdoc_fixxref): Pass the new directory as module dir to gtkdoc-fixxref and fix several links for
2470         which gtkdoc-fixxref always uses absolute paths.
2471         * gtk/manifest.txt.in: Update the documentation html paths and include the JSC GLib API in the tarball too.
2472
2473 2018-04-19  Brady Eidson  <beidson@apple.com>
2474
2475         Make back forward cache work with process swapping.
2476         <rdar://problem/38676604> and https://bugs.webkit.org/show_bug.cgi?id=184793
2477
2478         Reviewed by Chris Dumez.
2479
2480         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2481
2482 2018-04-19  David Kilzer  <ddkilzer@apple.com>
2483
2484         Enable Objective-C weak references
2485         <https://webkit.org/b/184789>
2486         <rdar://problem/39571716>
2487
2488         Reviewed by Dan Bernstein.
2489
2490         * ContentExtensionTester/Configurations/Base.xcconfig:
2491         (CLANG_ENABLE_OBJC_WEAK): Enable.
2492         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2493         (CLANG_ENABLE_OBJC_WEAK): Enable.
2494         * ImageDiff/cg/Configurations/Base.xcconfig:
2495         (CLANG_ENABLE_OBJC_WEAK): Enable.
2496         * MiniBrowser/Configurations/Base.xcconfig:
2497         (CLANG_ENABLE_OBJC_WEAK): Enable.
2498         * TestWebKitAPI/Configurations/Base.xcconfig:
2499         (CLANG_ENABLE_OBJC_WEAK): Enable.
2500         * WebEditingTester/Configurations/Base.xcconfig:
2501         (CLANG_ENABLE_OBJC_ARC): Re-order.
2502         * WebKitLauncher/Configurations/Base.xcconfig: Add newline at
2503         end of file.
2504         (CLANG_ENABLE_OBJC_WEAK): Enable.
2505         * WebKitTestRunner/Configurations/Base.xcconfig:
2506         (CLANG_ENABLE_OBJC_WEAK): Enable.
2507
2508 2018-04-19  Chris Dumez  <cdumez@apple.com>
2509
2510         REGRESSION (r229133): decidePolicyForNavigationAction not called for loading an HTML string
2511         https://bugs.webkit.org/show_bug.cgi?id=184209
2512         <rdar://problem/39145306>
2513
2514         Reviewed by Ryosuke Niwa.
2515
2516         Add API test coverage.
2517
2518         * TestWebKitAPI/Tests/WebKitCocoa/DecidePolicyForNavigationAction.mm:
2519         (TEST):
2520
2521 2018-04-18  Ross Kirsling  <ross.kirsling@sony.com>
2522
2523         [WinCairo][EWS] Build bot should clean user temp directory each time.
2524         https://bugs.webkit.org/show_bug.cgi?id=184761
2525
2526         Reviewed by Lucas Forschler.
2527
2528         * EWSTools/Start-Queue.ps1:
2529         Clean user's temp directory before each build, so that Windows git doesn't fill it up over time.
2530
2531 2018-04-18  Ross Kirsling  <ross.kirsling@sony.com>
2532
2533         Buildbots using Python zipfile should enable compression
2534         https://bugs.webkit.org/show_bug.cgi?id=184759
2535
2536         Reviewed by Lucas Forschler.
2537
2538         * BuildSlaveSupport/built-product-archive:
2539         (createZipManually):
2540         Default is to archive without compressing, so tell it to compress as well. 
2541
2542 2018-04-18  Nan Wang  <n_wang@apple.com>
2543
2544         AX: [macOS] WebKit hangs when triggering an alert from an AOM increment event
2545         https://bugs.webkit.org/show_bug.cgi?id=184742
2546
2547         Reviewed by Chris Fleizach.
2548
2549         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2550         (AccessibilityUIElement::increment):
2551         (AccessibilityUIElement::decrement):
2552         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2553         (WTR::AccessibilityUIElement::asyncIncrement):
2554         (WTR::AccessibilityUIElement::asyncDecrement):
2555         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2556         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2557         (WTR::AccessibilityUIElement::increment):
2558         (WTR::AccessibilityUIElement::decrement):
2559         (WTR::AccessibilityUIElement::asyncIncrement):
2560         (WTR::AccessibilityUIElement::asyncDecrement):
2561
2562 2018-04-18  Ross Kirsling  <ross.kirsling@sony.com>
2563
2564         Fix archive step for WinCairo build bot.
2565         https://bugs.webkit.org/show_bug.cgi?id=184715
2566
2567         Reviewed by Lucas Forschler.
2568
2569         * BuildSlaveSupport/built-product-archive:
2570         (archiveBuiltProduct):
2571         (extractBuiltProduct):
2572
2573 2018-04-18  Sihui Liu  <sihui_liu@apple.com>
2574
2575         REGRESSION: Using the reload button while offline pushes identical pages onto the back/forward list
2576         https://bugs.webkit.org/show_bug.cgi?id=184570
2577         <rdar://problem/34807323>
2578
2579         Reviewed by Chris Dumez.
2580
2581         Add API test coverage.
2582
2583         * TestWebKitAPI/Tests/WebKitCocoa/LoadAlternateHTMLString.mm:
2584         (TEST):
2585
2586 2018-04-18  Chris Dumez  <cdumez@apple.com>
2587
2588         Add support for converting a local window to a remote window
2589         https://bugs.webkit.org/show_bug.cgi?id=184515
2590         <rdar://problem/39011318>
2591
2592         Reviewed by Ryosuke Niwa.
2593
2594         * MiniBrowser/mac/AppDelegate.m:
2595         (defaultConfiguration):
2596         * MiniBrowser/mac/SettingsController.h:
2597         * MiniBrowser/mac/SettingsController.m:
2598         (-[SettingsController _populateMenu]):
2599         (-[SettingsController validateMenuItem:]):
2600         (-[SettingsController processSwapOnWindowOpenWithOpenerEnabled]):
2601         (-[SettingsController toggleProcessSwapOnWindowOpenWithOpener:]):
2602         Add menu entry in minibrowser to turn on process swap on cross-origin window.open().
2603
2604         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2605         Turn on process swap on cross-origin window.open() for corresponding test and update
2606         test to expect that a new WebProcess is created.
2607
2608         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2609         (WTR::InjectedBundlePage::decidePolicyForResponse):
2610         Add null checks for injectedBundle.testRunner(). When we swap process on navigation,
2611         the InjectedBundlePage::decidePolicyForResponse() gets called in the new process.
2612         In this new process, we have constructed a InjectedBundlePage for the page but we
2613         have not initialized the InjectedBundle members such as testRunner.
2614
2615         * WebKitTestRunner/TestController.cpp:
2616         (WTR::TestController::createWebViewWithOptions):
2617         (WTR::updateTestOptionsFromTestHeader):
2618         * WebKitTestRunner/TestOptions.h:
2619         (WTR::TestOptions::hasSameInitializationOptions const):
2620         Add a way for layout tests to turn on process swap on navigation via a test header.
2621
2622 2018-04-18  Yusuke Suzuki  <utatane.tea@gmail.com>
2623
2624         Unreviewed, reland r230697, r230720, and r230724.
2625         https://bugs.webkit.org/show_bug.cgi?id=184600
2626
2627         * Scripts/run-jsc-stress-tests:
2628
2629 2018-04-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2630
2631         [GLIB] Make it possible to handle JSCClass external properties not added to the prototype
2632         https://bugs.webkit.org/show_bug.cgi?id=184687
2633
2634         Reviewed by Michael Catanzaro.
2635
2636         Add test cases for the new API.
2637
2638         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2639         (fooCreate):
2640         (fooFree):
2641         (fooGetProperty):
2642         (fooSetProperty):
2643         (testJSCPromises):
2644         (testJSCGarbageCollector):
2645         (testsJSCVirtualMachine):
2646         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.cpp:
2647         (windowObjectClearedCallback):
2648
2649 2018-04-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2650
2651         [Extra zoom mode] Programmatically changing focus when an element already has focus is a confusing experience
2652         https://bugs.webkit.org/show_bug.cgi?id=184635
2653         <rdar://problem/39440642>
2654
2655         Reviewed by Tim Horton.
2656
2657         Add plumbing to support invoking `didHideKeyboardCallback` and `didShowKeyboardCallback` when (respectively)
2658         dismissing or presenting fullscreen input view controllers in extra zoom mode.
2659
2660         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2661         (-[TestRunnerWKWebView initWithFrame:configuration:]):
2662         (-[TestRunnerWKWebView dealloc]):
2663         (-[TestRunnerWKWebView _invokeShowKeyboardCallbackIfNecessary]):
2664         (-[TestRunnerWKWebView _invokeHideKeyboardCallbackIfNecessary]):
2665         (-[TestRunnerWKWebView _keyboardDidShow:]):
2666         (-[TestRunnerWKWebView _keyboardDidHide:]):
2667         (-[TestRunnerWKWebView _webView:didPresentFocusedElementViewController:]):
2668         (-[TestRunnerWKWebView _webView:didDismissFocusedElementViewController:]):
2669
2670 2018-04-17  Michael Catanzaro  <mcatanzaro@igalia.com>
2671
2672         [GTK] Webkit should spoof as Safari on a Mac for Outlook.com
2673         https://bugs.webkit.org/show_bug.cgi?id=184573
2674
2675         Reviewed by Carlos Alberto Lopez Perez.
2676
2677         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2678         (TestWebKitAPI::TEST):
2679
2680 2018-04-17  Fujii Hironori  <Hironori.Fujii@sony.com>
2681
2682         [WinCairo][TestWebKitAPI] Implement PlatformWebView for TestWebKit
2683         https://bugs.webkit.org/show_bug.cgi?id=184524
2684
2685         Reviewed by Alex Christensen.
2686
2687         Resurrect PlatformWebView for Windows port which was removed in Bug 104607.
2688
2689         * TestWebKitAPI/PlatformWebView.h:
2690         * TestWebKitAPI/PlatformWin.cmake:
2691         * TestWebKitAPI/win/InjectedBundleControllerWin.cpp: Added.
2692         (TestWebKitAPI::InjectedBundleController::platformInitialize):
2693         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp: Added.
2694         (TestWebKitAPI::Util::moduleDirectory):
2695         (TestWebKitAPI::Util::createInjectedBundlePath):
2696         (TestWebKitAPI::Util::createURLForResource):
2697         (TestWebKitAPI::Util::URLForNonExistentResource):
2698         (TestWebKitAPI::Util::isKeyDown):
2699         * TestWebKitAPI/win/PlatformWebViewWin.cpp: Added.
2700         (TestWebKitAPI::PlatformWebView::registerWindowClass):
2701         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2702         (TestWebKitAPI::PlatformWebView::initialize):
2703         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
2704         (TestWebKitAPI::PlatformWebView::page const):
2705         (TestWebKitAPI::PlatformWebView::resizeTo):
2706         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
2707         (TestWebKitAPI::PlatformWebView::simulateAltKeyPress):
2708         (TestWebKitAPI::PlatformWebView::simulateRightClick):
2709         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
2710         (TestWebKitAPI::PlatformWebView::wndProc):
2711         * TestWebKitAPI/win/UtilitiesWin.cpp: Added.
2712         (TestWebKitAPI::Util::run):
2713         (TestWebKitAPI::Util::spinRunLoop):
2714         (TestWebKitAPI::Util::sleep):
2715
2716 2018-04-17  Jonathan Bedard  <jbedard@apple.com>
2717
2718         Fix hasher tests for system with 32 bit longs
2719         https://bugs.webkit.org/show_bug.cgi?id=184708
2720         <rdar://problem/39459977>
2721
2722         Reviewed by Mark Lam.
2723
2724         Some systems have 32 bit longs. The Hasher WTF tests should handle this case.
2725
2726         * TestWebKitAPI/Tests/WTF/Hasher.cpp:
2727         (TestWebKitAPI::TEST):
2728
2729 2018-04-17  Commit Queue  <commit-queue@webkit.org>
2730
2731         Unreviewed, rolling out r230697, r230720, and r230724.
2732         https://bugs.webkit.org/show_bug.cgi?id=184717
2733
2734         These caused multiple failures on the Test262 testers.
2735         (Requested by mlewis13 on #webkit).
2736
2737         Reverted changesets:
2738
2739         "[WebAssembly][Modules] Prototype wasm import"
2740         https://bugs.webkit.org/show_bug.cgi?id=184600
2741         https://trac.webkit.org/changeset/230697
2742
2743         "[WebAssembly][Modules] Implement function import from wasm
2744         modules"
2745         https://bugs.webkit.org/show_bug.cgi?id=184689
2746         https://trac.webkit.org/changeset/230720
2747
2748         "[JSC] Rename runWebAssembly to runWebAssemblySuite"
2749         https://bugs.webkit.org/show_bug.cgi?id=184703
2750         https://trac.webkit.org/changeset/230724
2751
2752 2018-04-17  Jonathan Bedard  <jbedard@apple.com>
2753
2754         Unreviewed rollout of r230632. Regression in memory usage.
2755
2756         That bug tracked in https://bugs.webkit.org/show_bug.cgi?id=184569.
2757
2758         * DumpRenderTree/TestOptions.h:
2759         * DumpRenderTree/mac/DumpRenderTree.mm:
2760         (runTest):
2761         (shouldOverrideAndDisableCSSAnimationsAndCSSTransitionsBackedByWebAnimationsPreference): Deleted.
2762         * WebKitTestRunner/TestController.cpp:
2763         (WTR::TestController::resetPreferencesToConsistentValues):
2764         * WebKitTestRunner/TestOptions.cpp:
2765         (WTR::TestOptions::TestOptions):
2766         (WTR::isLegacyAnimationEngineTestPath): Deleted.
2767         * WebKitTestRunner/TestOptions.h:
2768
2769 2018-04-17  Yusuke Suzuki  <utatane.tea@gmail.com>
2770
2771         [JSC] Rename runWebAssembly to runWebAssemblySuite
2772         https://bugs.webkit.org/show_bug.cgi?id=184703
2773
2774         Reviewed by JF Bastien.
2775
2776         * Scripts/run-jsc-stress-tests:
2777
2778 2018-04-17  Yusuke Suzuki  <utatane.tea@gmail.com>
2779
2780         [WebAssembly][Modules] Implement function import from wasm modules
2781         https://bugs.webkit.org/show_bug.cgi?id=184689
2782
2783         Reviewed by JF Bastien.
2784
2785         Add runWebAssemblyDirect, which runs wasm file directly.
2786
2787         * Scripts/run-jsc-stress-tests:
2788
2789 2018-04-17  Saam Barati  <sbarati@apple.com>
2790
2791         Add system trace points for process launch and for initializeWebProcess
2792         https://bugs.webkit.org/show_bug.cgi?id=184669
2793
2794         Reviewed by Simon Fraser.
2795
2796         * Tracing/SystemTracePoints.plist:
2797
2798 2018-04-17  Ross Kirsling  <ross.kirsling@sony.com>
2799
2800         Add debug bots for WinCairo.
2801         https://bugs.webkit.org/show_bug.cgi?id=184663
2802
2803         Reviewed by Lucas Forschler.
2804
2805         * BuildSlaveSupport/build.webkit.org-config/config.json:
2806         Add a debug build bot and two debug test bots.
2807
2808         * BuildSlaveSupport/build.webkit.org-config/loadConfig.py:
2809         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2810         Add a WinCairo category to build.webkit.org.
2811
2812 2018-04-17  Zalan Bujtas  <zalan@apple.com>
2813
2814         [LayoutReloaded] Set inline-block box position.
2815         https://bugs.webkit.org/show_bug.cgi?id=184690
2816
2817         Reviewed by Antti Koivisto.
2818
2819         * LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
2820         (InlineFormattingContext.prototype._handleInlineBlock):
2821         * LayoutReloaded/Utils.js:
2822         (Utils._dumpBox):
2823         * LayoutReloaded/test/inline-block-with-fixed-width-height.html:
2824
2825 2018-04-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2826
2827         [GLIB] Add API to clear JSCContext uncaught exception
2828         https://bugs.webkit.org/show_bug.cgi?id=184685
2829
2830         Reviewed by Žan Doberšek.
2831
2832         Add test cases for the new API.
2833
2834         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2835         (testJSCExceptions):
2836
2837 2018-04-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2838
2839         [GLIB] Add API to query, delete and enumerate properties
2840         https://bugs.webkit.org/show_bug.cgi?id=184647
2841
2842         Reviewed by Michael Catanzaro.
2843
2844         Add test cases for the new API.
2845
2846         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2847         (testJSCObject):
2848         (testJSCClass):
2849         (testJSCPrototypes):
2850
2851 2018-04-16  Zalan Bujtas  <zalan@apple.com>
2852
2853         [LayoutReloaded] Add support for replaced box.
2854         https://bugs.webkit.org/show_bug.cgi?id=184680
2855
2856         Reviewed by Antti Koivisto.
2857
2858         Basic support for inline replaced.
2859
2860         * LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
2861         (InlineFormattingContext.prototype._handleInlineBox):
2862         (InlineFormattingContext.prototype._handleInlineBlock):
2863         (InlineFormattingContext.prototype._handleReplaced):
2864         * LayoutReloaded/FormattingContext/InlineFormatting/Line.js:
2865         (Line.prototype.lastLineBox):
2866         (Line.prototype.addInlineBox):
2867         (Line.prototype.addInlineContainerBox): Deleted.
2868         * LayoutReloaded/TreeBuilder.js:
2869         (TreeBuilder.prototype._createAndAttachBox):
2870         * LayoutReloaded/Utils.js:
2871         (Utils._dumpBox):
2872         * LayoutReloaded/test/index.html:
2873         * LayoutReloaded/test/inline-simple-replaced.html: Added.
2874
2875 2018-04-16  Zalan Bujtas  <zalan@apple.com>
2876
2877         [LayoutReloaded] Minor InlineFormattingContext::layout() cleanup.
2878         https://bugs.webkit.org/show_bug.cgi?id=184679
2879
2880         Reviewed by Antti Koivisto.
2881
2882         * LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
2883         (InlineFormattingContext):
2884         (InlineFormattingContext.prototype.layout):
2885         (InlineFormattingContext.prototype._handleInlineContainer):
2886         (InlineFormattingContext.prototype._handleInlineContent):
2887         (InlineFormattingContext.prototype._handleInlineBlock):
2888         (InlineFormattingContext.prototype._handleReplacedBox):
2889         (InlineFormattingContext.prototype._clearNeedsLayoutAndMoveToNextSibling):
2890         (InlineFormattingContext.prototype._handleInlineBlockContainer): Deleted.
2891         (InlineFormattingContext.prototype._clearAndMoveToNext): Deleted.
2892
2893 2018-04-16  Zalan Bujtas  <zalan@apple.com>
2894
2895         [LayoutReloaded] Introduce fragmentation state/context.
2896         https://bugs.webkit.org/show_bug.cgi?id=184677
2897
2898         Reviewed by Antti Koivisto.
2899
2900         State/context for fragmented content (multicol, regions, pagination etc).
2901
2902         * LayoutReloaded/FormattingContext/FragmentationContext.js: Added.
2903         (FragmentationContext):
2904         * LayoutReloaded/FormattingState/FragmentationState.js: Added.
2905         (FragmentationState):
2906         (FragmentationState.prototype.formattingState):
2907
2908 2018-04-16  Andy Estes  <aestes@apple.com>
2909
2910         [iOS] Enable WKPDFView by default
2911         https://bugs.webkit.org/show_bug.cgi?id=184675
2912         <rdar://problem/27885452>
2913
2914         Reviewed by Darin Adler.
2915
2916         * TestWebKitAPI/Tests/WebKitCocoa/WKPDFView.mm:
2917
2918 2018-04-16  Leo Balter  <leonardo.balter@gmail.com>
2919
2920         Perl-based Test262 runner
2921         https://bugs.webkit.org/show_bug.cgi?id=183343
2922
2923         Reviewed by Michael Saboff.
2924
2925         * Scripts/test262-helpers/README.md: Added.
2926         * Scripts/test262-helpers/agent.js: Added.
2927         (262.getGlobal):
2928         (262.setGlobal):
2929         (262.destroy):
2930         (262.IsHTMLDDA):
2931         * Scripts/test262-helpers/cpanfile: Added.
2932         * Scripts/test262-helpers/cpanfile.snapshot: Added.
2933         * Scripts/test262-helpers/test262-runner.pl: Added.
2934         (main):
2935         (processFile):
2936         (getScenarios):
2937         (addScenario):
2938         (compileTest):
2939         (runTest):
2940         (processResult):
2941         (getTempFile):
2942         (getContents):
2943         (parseData):
2944         (getHarness):
2945         * Scripts/test262-helpers/tests.log: Added.
2946
2947 2018-04-15  Andy Estes  <aestes@apple.com>
2948
2949         [iOS] Add API tests for PDF find-in-page
2950         https://bugs.webkit.org/show_bug.cgi?id=184634
2951
2952         Reviewed by Dan Bernstein.
2953
2954         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2955         * TestWebKitAPI/Tests/WebKit/find.pdf: Added.
2956         * TestWebKitAPI/Tests/WebKitCocoa/WKPDFView.mm:
2957         (-[TestFindDelegate findString]):
2958         (-[TestFindDelegate _webView:didCountMatches:forString:]):
2959         (-[TestFindDelegate _webView:didFindMatches:forString:withMatchIndex:]):
2960         (-[TestFindDelegate _webView:didFailToFindString:]):
2961         (loadWebView):
2962         (TEST):
2963
2964 2018-04-13  Zalan Bujtas  <zalan@apple.com>
2965
2966         [LayoutReloaded] Update class documentation
2967         https://bugs.webkit.org/show_bug.cgi?id=184625
2968
2969         Reviewed by Antti Koivisto.
2970
2971         * LayoutReloaded/DisplayTree/Box.js:
2972         * LayoutReloaded/FormattingContext/BlockFormatting/BlockFormattingContext.js:
2973         * LayoutReloaded/FormattingContext/BlockFormatting/BlockMarginCollapse.js:
2974         * LayoutReloaded/FormattingContext/FloatingContext.js:
2975         * LayoutReloaded/FormattingContext/FormattingContext.js:
2976         * LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
2977         * LayoutReloaded/FormattingContext/InlineFormatting/Line.js:
2978         * LayoutReloaded/FormattingState/BlockFormattingState.js:
2979         * LayoutReloaded/FormattingState/FloatingState.js:
2980         * LayoutReloaded/FormattingState/FormattingState.js:
2981         * LayoutReloaded/FormattingState/InlineFormattingState.js:
2982         * LayoutReloaded/LayoutState.js:
2983         * LayoutReloaded/LayoutTree/BlockContainer.js:
2984         * LayoutReloaded/LayoutTree/Box.js:
2985         * LayoutReloaded/LayoutTree/Container.js:
2986         * LayoutReloaded/LayoutTree/InlineBox.js:
2987         * LayoutReloaded/LayoutTree/InlineContainer.js:
2988         * LayoutReloaded/LayoutTree/Text.js:
2989         * LayoutReloaded/misc/headers/BlockContainer.h: Removed.
2990         * LayoutReloaded/misc/headers/BlockFormattingContext.h: Removed.
2991         * LayoutReloaded/misc/headers/BlockMarginCollapse.h: Removed.
2992         * LayoutReloaded/misc/headers/Box.h: Removed.
2993         * LayoutReloaded/misc/headers/Container.h: Removed.
2994         * LayoutReloaded/misc/headers/FloatingContext.h: Removed.
2995         * LayoutReloaded/misc/headers/FormattingContext.h: Removed.
2996         * LayoutReloaded/misc/headers/InitialBlockContainer.h: Removed.
2997         * LayoutReloaded/misc/headers/InlineBox.h: Removed.
2998         * LayoutReloaded/misc/headers/LayoutContext.h: Removed.
2999         * LayoutReloaded/misc/headers/Line.h: Removed.
3000         * LayoutReloaded/misc/headers/Text.h: Removed.
3001
3002 2018-04-13  Zalan Bujtas  <zalan@apple.com>
3003
3004         [LayoutReloaded] Add simple implementation for FormattingState::markNeedsLayout()
3005         https://bugs.webkit.org/show_bug.cgi?id=184621
3006
3007         Reviewed by Antti Koivisto.
3008
3009         This is just a simple, mark ancestors dirty implementation.
3010
3011         * LayoutReloaded/FormattingState/FormattingState.js:
3012         (FormattingState.prototype.markNeedsLayout):
3013         * LayoutReloaded/LayoutState.js:
3014         (LayoutState.prototype.markNeedsLayout):
3015         (LayoutState.prototype.setNeedsLayoutById): Deleted.
3016         (LayoutState.prototype.setNeedsLayout): Deleted.
3017         * LayoutReloaded/TreeBuilder.js:
3018         (TreeBuilder.prototype._createAndAttachBox):
3019         (TreeBuilder.prototype._findBox): Deleted.
3020         * LayoutReloaded/Utils.js:
3021         (Utils.layoutBoxById):
3022         * LayoutReloaded/test/index.html:
3023         * LayoutReloaded/test/simple-incremental-layout-with-static-content.html:
3024
3025 2018-04-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3026
3027         [WPE] [webkitpy] The driver requirements should be checked before starting the tests
3028         https://bugs.webkit.org/show_bug.cgi?id=184595
3029
3030         Reviewed by Michael Catanzaro.
3031
3032         Ensure Driver.check_driver() is checked at check_sys_deps() time.
3033
3034         * Scripts/webkitpy/port/wpe.py:
3035         (WPEPort.check_sys_deps):
3036
3037 2018-04-13  Zalan Bujtas  <zalan@apple.com>
3038
3039         Rebaseline LayoutReloaded patch file (collectRenderersWithNeedsLayout).
3040
3041         * LayoutReloaded/misc/LayoutReloadedWebKit.patch:
3042
3043 2018-04-13  Jonathan Bedard  <jbedard@apple.com>
3044
3045         Boot fewer simulators in CI/EWS machines
3046         https://bugs.webkit.org/show_bug.cgi?id=184594
3047         <rdar://problem/39188082>
3048
3049         Reviewed by Alexey Proskuryakov.
3050
3051         This is a temporary workaround fro <rdar://problem/39393590>.
3052
3053         * Scripts/webkitpy/xcode/simulated_device.py:
3054         (SimulatedDeviceManager): Treat simulators as taking 6 gigs instead of 2.
3055
3056 2018-04-13  Brady Eidson  <beidson@apple.com>
3057
3058         Introduce SuspendedPageProxy to keep old web processes around after their WebPageProxy has been swapped to a new one.
3059         https://bugs.webkit.org/show_bug.cgi?id=184559
3060
3061         Reviewed by Alex Christensen.
3062
3063         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3064
3065 2018-04-13  Chris Dumez  <cdumez@apple.com>
3066
3067         input.webkitEntries does not work as expected when folder contains accented chars
3068         https://bugs.webkit.org/show_bug.cgi?id=184517
3069         <rdar://problem/39265537>
3070
3071         Reviewed by Alex Christensen.
3072
3073         Add API test coverage.
3074
3075         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp:
3076         (TestWebKitAPI::TEST_F):
3077
3078 2018-04-13  Thibault Saunier  <tsaunier@igalia.com>
3079
3080         Update my emails ordering in contributors.json
3081         https://bugs.webkit.org/show_bug.cgi?id=184587
3082
3083         Rubber-stamped by Philippe Normand.
3084
3085         Bugzilla seems to pick up tsaunier@igalia.com which is not the one I use there.
3086
3087         * Scripts/webkitpy/common/config/contributors.json:
3088
3089 2018-04-13  Michael Catanzaro  <mcatanzaro@igalia.com>
3090
3091         [WPE] xkbcommon: ERROR: failed to add default include path /home/mcatanzaro/Projects/WebKit/WebKitBuild/DependenciesWPE/Root/share/X11/xkb
3092         https://bugs.webkit.org/show_bug.cgi?id=184388
3093
3094         Reviewed by Carlos Alberto Lopez Perez.
3095
3096         Remove libxkbcommon from the JHBuild environment. We could alternatively add
3097         xkeyboard-config, but there doesn't seem to be any need to build libxkbcommon because I do
3098         not believe it depends on anything else in the JHBuild environment.
3099
3100         * wpe/install-dependencies:
3101         * wpe/jhbuild.modules:
3102
3103 2018-04-12  Antoine Quint  <graouts@apple.com>
3104
3105         [Web Animations] Turn CSS Animations and CSS Transitions as Web Animations on by default
3106         https://bugs.webkit.org/show_bug.cgi?id=184569
3107         <rdar://problem/38671301>
3108
3109         Reviewed by Jon Lee.
3110
3111         We set the default value for the CSS Animations and CSS Transitions as Web Animations flag to true
3112         but override it to be false always in the LayoutTests/legacy-animation-engine directory.
3113
3114         * DumpRenderTree/TestOptions.h:
3115         * DumpRenderTree/mac/DumpRenderTree.mm:
3116         (shouldOverrideAndDisableCSSAnimationsAndCSSTransitionsBackedByWebAnimationsPreference):
3117         (runTest):
3118         * WebKitTestRunner/TestController.cpp:
3119         (WTR::TestController::resetPreferencesToConsistentValues):
3120         * WebKitTestRunner/TestOptions.cpp:
3121         (WTR::isLegacyAnimationEngineTestPath):
3122         (WTR::TestOptions::TestOptions):
3123         * WebKitTestRunner/TestOptions.h:
3124
3125 2018-04-13  Carlos Garcia Campos  <cgarcia@igalia.com>
3126
3127         [GLIB] Tests WTF_RefPtr.ReleaseInNonMainThread and WTF_RefPtr.ReleaseInNonMainThreadDestroyInMainThread are crashing since they were added
3128         https://bugs.webkit.org/show_bug.cgi?id=184531
3129
3130         Reviewed by Michael Catanzaro.
3131
3132         It's not a bug in WebKit, but in the tests. The problem is that those tests are using RunLoop::main() but main
3133         run loop hasn't been initialized. ReleaseInNonMainThread doesn't really need to initialize the main run loop if
3134         we change Util::run() to always use RunLop::current() instead of RunLoop::main(). But
3135         ReleaseInNonMainThreadDestroyInMainThread ends up scheduling a task to the main thread, and the generic
3136         implementation fo that uses RunLoop::main(), so we need to initialize the main loop in this case.
3137
3138         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
3139         (TestWebKitAPI::TEST): Call RunLoop::initializeMainRunLoop().
3140         * TestWebKitAPI/glib/UtilitiesGLib.cpp:
3141         (TestWebKitAPI::Util::run): Use RunLop::current() to stop the current run loop.
3142         (TestWebKitAPI::Util::sleep): Ditto.
3143
3144 2018-04-12  Zalan Bujtas  <zalan@apple.com>
3145
3146         [LayoutReloaded] Add support for incremental layout
3147         https://bugs.webkit.org/show_bug.cgi?id=184578
3148
3149         Reviewed by Antti Koivisto.
3150
3151         * LayoutReloaded/Layout.js:
3152         (layout):
3153         * LayoutReloaded/LayoutState.js:
3154         (LayoutState.prototype.rootContainer):
3155         (LayoutState.prototype.setNeedsLayoutById):
3156         * LayoutReloaded/Utils.js:
3157         (Utils.layoutTreeDump):
3158         * LayoutReloaded/test/TestHarness.js:
3159         (verifyLayout):
3160         (runLayout):
3161         (verifyLayoutTreeDump): Deleted.
3162         * LayoutReloaded/test/index.html:
3163         * LayoutReloaded/test/simple-incremental-layout-with-static-content.html: Added.
3164
3165 2018-04-12  Zalan Bujtas  <zalan@apple.com>
3166
3167         [LayoutReloaded] Move root container ownership to layout state
3168         https://bugs.webkit.org/show_bug.cgi?id=184575
3169
3170         Reviewed by Antti Koivisto.
3171
3172         Now the root container is on the associated layout state (ICB only at this point though).
3173
3174         * LayoutReloaded/FormattingContext/BlockFormatting/BlockFormattingContext.js:
3175         (BlockFormattingContext.prototype.layout):
3176         * LayoutReloaded/FormattingContext/FormattingContext.js:
3177         (FormattingContext.prototype._layoutOutOfFlowDescendants):
3178         * LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
3179         (InlineFormattingContext.prototype._handleInlineBlockContainer):
3180         (InlineFormattingContext.prototype._handleFloatingBox):
3181         * LayoutReloaded/Layout.js:
3182         (layout):
3183         * LayoutReloaded/LayoutState.js:
3184         (LayoutState):
3185         (LayoutState.prototype.formattingContext):
3186         (LayoutState.prototype.establishedFormattingState):
3187         (LayoutState.prototype.formattingStateForBox):
3188         (LayoutState.prototype.needsLayout):
3189         (LayoutState.prototype.displayBox):
3190         (LayoutState.prototype._formattingContext):
3191         (LayoutState.prototype.layout): Deleted.
3192         (LayoutState.prototype.formattingStates): Deleted.
3193         (LayoutState.prototype.initialDisplayBox): Deleted.
3194         * LayoutReloaded/Utils.js:
3195         (Utils._dumpBox):
3196         (Utils._findDisplayBox): Deleted.
3197
3198 2018-04-12  Jonathan Bedard  <jbedard@apple.com>
3199
3200         Fix --build-directory flag for run-webkit-tests
3201         https://bugs.webkit.org/show_bug.cgi?id=184545
3202         <rdar://problem/39385080>
3203
3204         Rubber-stamped by Aakash Jain.
3205
3206         The --build-directory path does not work with iOS-Simulator.
3207
3208         * Scripts/webkitpy/port/base.py:
3209         (Port._build_path): Use the port configuration to calculate the root directory.
3210         * Scripts/webkitpy/port/base_unittest.py:
3211         (PortTest.test_build_path): Test build directories for embedded configurations.
3212
3213 2018-04-12  Ross Kirsling  <ross.kirsling@sony.com>
3214
3215         pemfile.py should not assume POSIX line endings
3216         https://bugs.webkit.org/show_bug.cgi?id=184507
3217
3218         Reviewed by Daniel Bates.
3219
3220         * Scripts/webkitpy/common/system/pemfile.py:
3221         (_parse_pem_format):
3222         * Scripts/webkitpy/common/system/pemfile_unittest.py:
3223         (PemFileTest.test_parse_crlf):
3224         (PemFileTest.test_parse_cr):
3225
3226 2018-04-12  Zalan Bujtas  <zalan@apple.com>
3227
3228         [LayoutReloaded] Minor cleanup in LayoutSate
3229         https://bugs.webkit.org/show_bug.cgi?id=184546
3230
3231         Reviewed by Antti Koivisto.
3232
3233         * LayoutReloaded/FormattingContext/FormattingContext.js:
3234         (FormattingContext.isInFormattingContext):
3235         * LayoutReloaded/FormattingState/FormattingState.js:
3236         (FormattingState.prototype.displayBoxes):
3237         (FormattingState.prototype.displayBox):
3238         (FormattingState.prototype._markSubTreeNeedsLayout):
3239         (FormattingState):
3240         (FormattingState.prototype.displayBoxMap): Deleted.
3241         * LayoutReloaded/LayoutState.js:
3242         (LayoutState.prototype.formattingStateForBox):
3243         (LayoutState.prototype.needsLayout):
3244         (LayoutState.prototype.displayBox):
3245         (LayoutState.prototype._createFormattingState):
3246         (LayoutState):
3247         * LayoutReloaded/LayoutTree/Box.js:
3248         (Layout.Box.prototype.isFormattingContextDescendant): Deleted.
3249         * LayoutReloaded/LayoutTree/Container.js:
3250         (Layout.Container.prototype.isContainingBlockDescendant): Deleted.
3251         * LayoutReloaded/Utils.js:
3252         (Utils._findDisplayBox):
3253
3254 2018-04-12  Zalan Bujtas  <zalan@apple.com>
3255
3256         [LayoutReloaded] Introduce needsLayout to InlineFormattingContext
3257         https://bugs.webkit.org/show_bug.cgi?id=184538
3258
3259         Reviewed by Antti Koivisto.
3260
3261         * LayoutReloaded/FormattingContext/BlockFormatting/BlockFormattingContext.js:
3262         (BlockFormattingContext.prototype._adjustBottomWithFIXME):
3263         (BlockFormattingContext):
3264         (BlockFormattingContext.prototype._firstInFlowChildWithNeedsLayout): Deleted.
3265         (BlockFormattingContext.prototype._nextInFlowSiblingWithNeedsLayout): Deleted.
3266         * LayoutReloaded/FormattingContext/FormattingContext.js:
3267         (FormattingContext.prototype._firstInFlowChildWithNeedsLayout):
3268         (FormattingContext.prototype._nextInFlowSiblingWithNeedsLayout):
3269         (FormattingContext):
3270         * LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
3271         (InlineFormattingContext.prototype.layout):
3272         (InlineFormattingContext.prototype._handleInlineContainer):
3273         (InlineFormattingContext.prototype._handleInlineBlockContainer):
3274         (InlineFormattingContext.prototype._handleInlineContent):
3275         (InlineFormattingContext.prototype._clearAndMoveToNext):
3276         (InlineFormattingContext):
3277
3278 2018-04-12  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3279
3280         [GStreamer] Speed up GStreamer dependency build by removing examples compilation
3281         https://bugs.webkit.org/show_bug.cgi?id=184528
3282
3283         Reviewed by Philippe Normand.
3284
3285         * gstreamer/jhbuild.modules: Added --disable-examples for GStreamer package.
3286
3287 2018-04-12  Zan Dobersek  <zdobersek@igalia.com>
3288
3289         [WPE] Switch testing process to using WPEBackend-fdo
3290         https://bugs.webkit.org/show_bug.cgi?id=184357
3291
3292         Reviewed by Carlos Alberto Lopez Perez.
3293
3294         Switch WPE testing to using the WPEBackend-fdo implementation that
3295         depends on the WL_bind_wayland_display EGL extension, as defined under
3296         the freedesktop.org project.
3297         https://cgit.freedesktop.org/mesa/mesa/tree/docs/specs/WL_bind_wayland_display.spec
3298
3299         HeadlessViewBackend is refactored to use the WPEBackend-fdo API, but
3300         otherwise is not changed in functionality.
3301
3302         Unit tests now have to unconditionally use HeadlessViewBackend as a
3303         wpe_view_backend provider, since WPEBackend-fdo does not provide a
3304         default wpe_view_backend implementation. Unit tests covering that are
3305         adjusted to instead use a mock wpe_view_backend interface.
3306
3307         * Scripts/webkitdirs.pm:
3308         (builtDylibPathForName): Fix the libWPEWebKit.so name to also include
3309         the API version that was added in r230449.
3310         * Scripts/webkitpy/port/waylanddriver.py:
3311         (WaylandDriver._setup_environ_for_test): Export EGL_PLATFORM=wayland.
3312         * Scripts/webkitpy/port/wpe.py:
3313         (WPEPort._driver_class): Use WaylandDriver by default.
3314         * TestWebKitAPI/PlatformWebView.h:
3315         (): Deleted.
3316         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3317         (testWebViewWebBackend):
3318         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3319         (Test::createWebViewBackend):
3320         * TestWebKitAPI/wpe/PlatformWebViewWPE.cpp:
3321         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
3322         (TestWebKitAPI::PlatformWebView::initialize):
3323         * wpe/HeadlessViewBackend/CMakeLists.txt:
3324         * wpe/HeadlessViewBackend/HeadlessViewBackend.cpp:
3325         (getEGLDisplay):
3326         (HeadlessViewBackend::HeadlessViewBackend):
3327         (HeadlessViewBackend::~HeadlessViewBackend):
3328         (HeadlessViewBackend::backend const):
3329         (HeadlessViewBackend::createSnapshot):
3330         (HeadlessViewBackend::performUpdate):
3331         (HeadlessViewBackend::makeCurrent): Deleted.
3332         * wpe/HeadlessViewBackend/HeadlessViewBackend.h:
3333         * wpe/jhbuild.modules: Module name cleanup. Dyz version is bumped.
3334
3335 2018-04-12  Carlos Garcia Campos  <cgarcia@igalia.com>
3336
3337         [GTK] Switch to use always complex text code path
3338         https://bugs.webkit.org/show_bug.cgi?id=183285
3339
3340         Reviewed by Michael Catanzaro.
3341
3342         Keep the auto mode for the layout tests to avoid having to rebaseline a lot of tests.
3343
3344         * WebKitTestRunner/gtk/main.cpp:
3345         (main): Set WEBKIT_FORCE_COMPLEX_TEXT to 0 unless it's already present in the environment.
3346
3347 2018-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
3348
3349         [GLIB] Handle strings containing null characters
3350         https://bugs.webkit.org/show_bug.cgi?id=184450
3351
3352         Reviewed by Michael Catanzaro.
3353
3354         Add test case for strings with null characters and update all calls to evaluate to pass the script length.
3355
3356         * TestWebKitAPI/PlatformGTK.cmake:
3357         * TestWebKitAPI/PlatformWPE.cmake:
3358         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3359         (testJSCBasic):
3360         (testJSCFunction):
3361         (testJSCObject):
3362         (testJSCClass):
3363         (testJSCPrototypes):
3364         (testJSCExceptions):
3365         (testJSCPromises):
3366         (testJSCGarbageCollector):
3367         (testJSCWeakValue):
3368         (testsJSCVirtualMachine):
3369         (testsJSCAutocleanups):
3370         * TestWebKitAPI/Tests/JavaScriptCore/glib/script.js: Added.
3371         * TestWebKitAPI/Tests/WebKitGLib/DOMElementTest.cpp:
3372         (DOMElementTest::testAutoFill):
3373         * TestWebKitAPI/Tests/WebKitGLib/EditorTest.cpp:
3374         (WebKitWebEditorTest::testSelectionChanged):
3375         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
3376         (WebKitFrameTest::testJavaScriptValues):
3377         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
3378         (consoleMessageSentCallback):
3379         (methodCallCallback):
3380
3381 2018-04-11  Zan Dobersek  <zdobersek@igalia.com>
3382
3383         [WPE] Make WebKitWebViewBackend object mandatory for webkit_web_view_new*() constructors
3384         https://bugs.webkit.org/show_bug.cgi?id=184513
3385
3386         Reviewed by Michael Catanzaro.
3387
3388         Update the WPE-specific testWebViewWebBackend() test case, removing the
3389         test that passes a null WebKitWebViewBackend object to the
3390         webkit_web_view_new() call.
3391
3392         Helper createWebViewBackend() that's called via Test::createWebView()
3393         variations is updated to, in case of not using the headless backend,
3394         return a WebKitWebViewBackend instance that wraps around a
3395         default wpe_view_backend object.
3396
3397         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3398         (testWebViewWebBackend):
3399         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3400         (Test::createWebViewBackend):
3401
3402 2018-04-11  Zalan Bujtas  <zalan@apple.com>
3403
3404         [LayoutReloaded] Introduce needsLayout flag
3405         https://bugs.webkit.org/show_bug.cgi?id=184527
3406
3407         Reviewed by Antti Koivisto.
3408
3409         Use the formatting state to mark boxes dirty.
3410
3411         * LayoutReloaded/FormattingContext/BlockFormatting/BlockFormattingContext.js:
3412         (BlockFormattingContext.prototype.layout):
3413         (BlockFormattingContext.prototype._firstInFlowChildWithNeedsLayout):
3414         (BlockFormattingContext.prototype._nextInFlowSiblingWithNeedsLayout):
3415         (BlockFormattingContext):
3416         * LayoutReloaded/FormattingContext/FormattingContext.js:
3417         (FormattingContext.prototype._layoutOutOfFlowDescendants):
3418         * LayoutReloaded/FormattingState/FormattingState.js:
3419         (FormattingState):
3420         (FormattingState.prototype.markNeedsLayout):
3421         (FormattingState.prototype.clearNeedsLayout):
3422         (FormattingState.prototype.needsLayout):
3423         (FormattingState.prototype.layoutNeeded):
3424         (FormattingState.prototype._markSubTreeNeedsLayout):
3425         * LayoutReloaded/LayoutState.js:
3426         (LayoutState.prototype.formattingStateForBox):
3427         (LayoutState.prototype.setNeedsLayout):
3428         (LayoutState.prototype.needsLayout):
3429         * LayoutReloaded/LayoutTree/Box.js:
3430         (Layout.Box.prototype.isFormattingContextDescendant):
3431         * LayoutReloaded/LayoutTree/Container.js:
3432         (Layout.Container.prototype.isContainingBlockDescendant):
3433
3434 2018-04-11  Jonathan Bedard  <jbedard@apple.com>
3435
3436         Fix TestInvocation class for newer versions of clang.
3437         https://bugs.webkit.org/show_bug.cgi?id=184508
3438         <rdar://problem/39328648>
3439
3440         Reviewed by Alexey Proskuryakov.
3441
3442         Declare TestInvocation to be final so it does not require a virtual destructor.
3443
3444         * WebKitTestRunner/TestInvocation.h:
3445
3446 2018-04-10  Alex Christensen  <achristensen@webkit.org>
3447
3448         IDN spoofing with Hebrew combining characters
3449         https://bugs.webkit.org/show_bug.cgi?id=184472
3450         <rdar://problem/39148687>
3451
3452         Reviewed by Brent Fulgham.
3453
3454         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
3455         (TestWebKitAPI::TEST):
3456
3457 2018-04-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3458
3459         [Extra zoom mode] Missing label when focusing a <select> with a title attribute but no associated <label>
3460         https://bugs.webkit.org/show_bug.cgi?id=184352
3461         <rdar://problem/39237683>
3462
3463         Reviewed by Andy Estes.
3464
3465         Add support for UIScriptController::selectFormPopoverTitle, which returns the title of the current select
3466         popover's UITableViewController (for testing purposes).
3467
3468         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3469         (WTR::UIScriptController::selectFormPopoverTitle const):
3470         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3471         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3472         (WTR::UIScriptController::selectFormPopoverTitle const):
3473         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3474         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3475         (WTR::UIScriptController::selectFormPopoverTitle const):
3476
3477 2018-04-10  Nan Wang  <n_wang@apple.com>
3478
3479         AX: Expose strong password fields on iOS
3480         https://bugs.webkit.org/show_bug.cgi?id=184465
3481         <rdar://problem/39325104>
3482
3483         Reviewed by Chris Fleizach.
3484
3485         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3486         (AccessibilityUIElement::boolAttributeValue):
3487         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3488         (WTR::AccessibilityUIElement::boolAttributeValue):
3489
3490 2018-04-10  Zalan Bujtas  <zalan@apple.com>
3491
3492         [LayoutReloaded] Add support for out-of-flow descendants in inline formatting context.
3493         https://bugs.webkit.org/show_bug.cgi?id=184454
3494
3495         Reviewed by Antti Koivisto.
3496
3497         When the containing block of an out-of-flow positioned element establishes an inline formatting context.
3498         This is mostly about moving out-of-flow logic from BlockFormattingContext to the base class.
3499
3500         * LayoutReloaded/FormattingContext/BlockFormatting/BlockFormattingContext.js:
3501         (BlockFormattingContext.prototype._adjustBottomWithFIXME):
3502         (BlockFormattingContext):
3503         (BlockFormattingContext.prototype._layoutOutOfFlowDescendants): Deleted.
3504         (BlockFormattingContext.prototype._computeOutOfFlowWidth): Deleted.
3505         (BlockFormattingContext.prototype._computeInFlowWidth): Deleted.
3506         (BlockFormattingContext.prototype._computeOutOfFlowHeight): Deleted.
3507         (BlockFormattingContext.prototype._computeOutOfFlowPosition): Deleted.
3508         (BlockFormattingContext.prototype._shrinkToFitWidth): Deleted.
3509         * LayoutReloaded/FormattingContext/FormattingContext.js:
3510         (FormattingContext.prototype._placeInFlowPositionedChildren):
3511         (FormattingContext.prototype._computeInFlowWidth):
3512         (FormattingContext.prototype._layoutOutOfFlowDescendants):
3513         (FormattingContext.prototype._computeOutOfFlowWidth):
3514         (FormattingContext.prototype._computeOutOfFlowHeight):
3515         (FormattingContext.prototype._computeOutOfFlowPosition):
3516         (FormattingContext.prototype._shrinkToFitWidth):
3517         * LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
3518         (InlineFormattingContext.prototype.layout):
3519         (InlineFormattingContext.prototype._handleInlineContainer):
3520         (InlineFormattingContext.prototype._handleInlineBlockContainer):
3521         (InlineFormattingContext.prototype._placeOutOfFlowDescendants): Deleted.
3522         * LayoutReloaded/test/index.html:
3523         * LayoutReloaded/test/inline-with-out-of-flow-descendant.html: Added.
3524
3525 2018-04-09  Zan Dobersek  <zdobersek@igalia.com>
3526
3527         WKTR: Enable DOM cache, SW registration directory cleanup on non-Cocoa platforms
3528         https://bugs.webkit.org/show_bug.cgi?id=184414
3529
3530         Reviewed by Michael Catanzaro.
3531
3532         Enable clearServiceWorkerRegistrations(), clearDOMCache() and
3533         clearDOMCaches() implementations in WebKitTestRunner's TestController
3534         class for non-Cocoa platforms. Implementations depend on the generic
3535         WK2 C API that other ports can leverage as well.
3536
3537         The clearDOMCache() and clearDOMCaches() calls are now operational for
3538         tests that invoke them. clearServiceWorkerRegistrations() and
3539         clearDOMCaches() are also called between each test, cleaning up relevant
3540         resources.
3541
3542         The TestController::getAllStorageAccessEntries() stub for non-Cocoa
3543         platforms is moved into the main !PLATFORM(COCOA) block.
3544
3545         * WebKitTestRunner/TestController.cpp:
3546         (WTR::TestController::getAllStorageAccessEntries):
3547         (WTR::clearServiceWorkerRegistrationsCallback):
3548         (WTR::TestController::clearServiceWorkerRegistrations):
3549         (WTR::clearDOMCacheCallback):
3550         (WTR::TestController::clearDOMCache):
3551         (WTR::TestController::clearDOMCaches):
3552
3553 2018-04-09  Zalan Bujtas  <zalan@apple.com>
3554
3555         [LayoutReloaded] Add support for relatively positioned containers in inline formatting context.
3556         https://bugs.webkit.org/show_bug.cgi?id=184439
3557
3558         Reviewed by Antti Koivisto.
3559
3560         * LayoutReloaded/FormattingContext/BlockFormatting/BlockFormattingContext.js:
3561         (BlockFormattingContext.prototype._placeInFlowPositionedChildren): Deleted.
3562         (BlockFormattingContext.prototype._computeInFlowPositionedPosition): Deleted.
3563         * LayoutReloaded/FormattingContext/FormattingContext.js:
3564         (FormattingContext.prototype._computeInFlowPositionedPosition):
3565         (FormattingContext.prototype._placeInFlowPositionedChildren):
3566         * LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
3567         (InlineFormattingContext.prototype._placeInFlowPositionedChildren): Deleted.
3568         * LayoutReloaded/Utils.js:
3569         (Utils._dumpBox):
3570         (Utils._dumpLines.):
3571         (Utils._dumpLines):
3572         (Utils.precisionRoundWithDecimals):
3573         (Utils.precisionRound):
3574         (Utils):
3575         * LayoutReloaded/test/index.html:
3576         * LayoutReloaded/test/inline-with-relative-positioning.html: Added.
3577
3578 2018-04-09  Zalan Bujtas  <zalan@apple.com>
3579
3580         [LayoutReloaded] Remove Layout.InitialContainingBlock class
3581         https://bugs.webkit.org/show_bug.cgi?id=184436
3582
3583         Reviewed by Antti Koivisto.
3584
3585         * LayoutReloaded/LayoutTree/Box.js:
3586         (Layout.Box.prototype.establishesBlockFormattingContext):
3587         * LayoutReloaded/LayoutTree/InitialBlockContainer.js: Removed.
3588         * LayoutReloaded/TreeBuilder.js:
3589         (TreeBuilder.prototype.createTree):
3590         * LayoutReloaded/test/index.html:
3591
3592 2018-04-09  Zalan Bujtas  <zalan@apple.com>
3593
3594         [LayoutReloaded] Add support for inline-block.
3595         https://bugs.webkit.org/show_bug.cgi?id=184434
3596
3597         Reviewed by Antti Koivisto.
3598
3599         * LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
3600         (InlineFormattingContext):
3601         (InlineFormattingContext.prototype.layout):
3602         (InlineFormattingContext.prototype._handleInlineContainer):
3603         (InlineFormattingContext.prototype._handleInlineBlockContainer):
3604         (InlineFormattingContext.prototype._handleInlineContent):
3605         * LayoutReloaded/FormattingContext/InlineFormatting/Line.js:
3606         (Line.prototype.addInlineContainerBox):
3607         (Line.prototype.addTextLineBox):
3608         (Line):
3609         * LayoutReloaded/LayoutTree/Box.js:
3610         (Layout.Box.prototype.isInlineBlockBox):
3611         * LayoutReloaded/Utils.js:
3612         (LayoutRect.prototype.growHorizontally):
3613         (Utils.isBlockContainerElement):
3614         (Utils.isInlineBlockElement):
3615         (Utils._dumpLines.):
3616         (Utils._dumpLines):
3617         * LayoutReloaded/test/index.html:
3618         * LayoutReloaded/test/inline-block-with-fixed-width-height.html: Added.
3619
3620 2018-04-09  Timothy Hatcher  <timothy@apple.com>
3621
3622         Add support for setting a background color on WKWebView and WKView
3623         https://bugs.webkit.org/show_bug.cgi?id=184426
3624
3625         Reviewed by Wenson Hsieh.
3626
3627         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3628         * TestWebKitAPI/Tests/mac/BackgroundColor.mm: Added.
3629
3630 2018-04-09  Charlie Turner  <cturner@igalia.com>
3631
3632         [WPE] Add some missing install dependencies
3633         https://bugs.webkit.org/show_bug.cgi?id=184383
3634
3635         Reviewed by Michael Catanzaro.
3636
3637         * wpe/install-dependencies:
3638
3639 2018-04-09  Sihui Liu  <sihui_liu@apple.com>
3640
3641         REGRESSION(r229929): localStorage is broken for WebInspector
3642         https://bugs.webkit.org/show_bug.cgi?id=184382
3643         <rdar://problem/39257355>
3644
3645         Reviewed by Chris Dumez.
3646
3647         * TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm:
3648         (TEST):
3649         * TestWebKitAPI/Tests/WebKitCocoa/localstorage-empty-string-value.html:
3650
3651 2018-04-09  Zan Dobersek  <zdobersek@igalia.com>
3652
3653         Unreviewed follow-up to r230389.
3654
3655         * WebKitTestRunner/TestController.cpp:
3656         (WTR::TestController::platformAdjustContext): Use the 'ServiceWorkers'
3657         subdirectory for the temporary testing-purpose SW registration directory
3658         like it's used in Cocoa's TestController, addressing the review comment
3659         that I forgot about.
3660
3661 2018-04-08  Zan Dobersek  <zdobersek@igalia.com>
3662
3663         Non-Cocoa ports use default directory for ServiceWorker data during testing
3664         https://bugs.webkit.org/show_bug.cgi?id=183784
3665
3666         Reviewed by Youenn Fablet.
3667
3668         * WebKitTestRunner/TestController.cpp:
3669         (WTR::TestController::platformAdjustContext): Set the service worker registration
3670         directory through the new WKWebsiteDataStore API for non-Cocoa ports.
3671
3672 2018-04-08  Zalan Bujtas  <zalan@apple.com>
3673
3674         [LayoutReloaded] Adjust line with inline container's margin border and padding
3675      &