REGRESSION (r225789): API tests WKProcessPool.InitialWarmedProcessUsed and WebKit...
[WebKit-https.git] / Tools / ChangeLog
1 2017-12-14  Brady Eidson  <beidson@apple.com>
2
3         REGRESSION (r225789): API tests WKProcessPool.InitialWarmedProcessUsed and WebKit.WebsiteDataStoreCustomPaths are failing.
4         https://bugs.webkit.org/show_bug.cgi?id=180722
5
6         Reviewed by Chris Dumez.
7
8         * TestWebKitAPI/Tests/WebKitCocoa/InitialWarmedProcessUsed.mm:
9         (TEST):
10
11 2017-12-14  Alex Christensen  <achristensen@webkit.org>
12
13         Fix Mac CMake build
14         https://bugs.webkit.org/show_bug.cgi?id=180835
15
16         Reviewed by Andy Estes.
17
18         * DumpRenderTree/mac/DumpRenderTree.mm:
19         * MiniBrowser/mac/WK1BrowserWindowController.m:
20
21 2017-12-14  Jonathan Bedard  <jbedard@apple.com>
22
23         webkitpy: Better name-version mapping (Follow-up fix)
24         https://bugs.webkit.org/show_bug.cgi?id=179621
25         <rdar://problem/35589585>
26
27         Unreviewed infrastructure fix.
28
29         r225856 caused some undesired logging on Linux and Windows.
30
31         * Scripts/webkitpy/port/mac.py:
32         (MacPort.__init__): Use most recent OS release if not on a Mac.
33         (MacPort.default_baseline_search_path): Make platform explicit.
34         (MacPort.configuration_specifier_macros): Ditto.
35
36 2017-12-14  Carlos Garcia Campos  <cgarcia@igalia.com>
37
38         WebDriver: add a common way to run tests with pytest
39         https://bugs.webkit.org/show_bug.cgi?id=180800
40
41         Reviewed by Carlos Alberto Lopez Perez.
42
43         We currently use pytestrunner from wpt for w3c tests and our own code for selenium tests. Using the same code
44         for both would simplify everything, but also allows us to have a custom results recorder to support other test
45         expectations like TIMEOUT. The code to run selenium tests with pytest has been moved to a new file
46         pytest_runner.py and made generic to be used also for w3c tests.
47
48         * Scripts/webkitpy/webdriver_tests/pytest_runner.py: Added.
49         (TemporaryDirectory):
50         (TemporaryDirectory.__enter__):
51         (TemporaryDirectory.__exit__):
52         (CollectRecorder):
53         (CollectRecorder.__init__):
54         (CollectRecorder.pytest_collectreport):
55         (HarnessResultRecorder):
56         (HarnessResultRecorder.__init__):
57         (HarnessResultRecorder.pytest_collectreport):
58         (SubtestResultRecorder):
59         (SubtestResultRecorder.__init__):
60         (SubtestResultRecorder.pytest_runtest_logreport):
61         (SubtestResultRecorder._was_timeout):
62         (SubtestResultRecorder.record_pass):
63         (SubtestResultRecorder.record_fail):
64         (SubtestResultRecorder.record_error):
65         (SubtestResultRecorder.record_skip):
66         (SubtestResultRecorder.record):
67         (collect):
68         (run):
69         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
70         (do_delayed_imports): Import pytest_runner here to avoid cycles.
71         (WebDriverSeleniumExecutor.__init__): Save the driver parameter as args member and call do_delayed_imports() if
72         needed.
73         (WebDriverSeleniumExecutor.collect): Use pytest_runner.
74         (WebDriverSeleniumExecutor.run): Ditto.
75         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
76         (WebDriverTestRunner.print_results): Handle all possible tests results.
77         (WebDriverTestRunner.print_results.report): Helper to dump test results.
78         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
79         (WebDriverTestRunnerSelenium.run):
80         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
81         (WebDriverTestRunnerW3C.__init__): Do not set PYTEST_TIMEOUT env var.
82         (WebDriverTestRunnerW3C._is_test): Fix check for support files.
83         (WebDriverTestRunnerW3C.run): Pass the timeout as parameter to WebDriverW3CExecutor.run().
84         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
85         (do_delayed_imports): Import pytest_runner here to avoid cycles.
86         (WebDriverW3CExecutor.__init__): Call do_delayed_imports() if needed.
87         (WebDriverW3CExecutor.run): Use pytest_runner.
88
89 2017-12-13  Matt Lewis  <jlewis3@apple.com>
90
91         Unreviewed, rolling out r225864.
92
93         This caused the Layout test step to crash out on Debug testers
94
95         Reverted changeset:
96
97         "REGRESSION (r225789): API tests
98         WKProcessPool.InitialWarmedProcessUsed and
99         WebKit.WebsiteDataStoreCustomPaths are failing."
100         https://bugs.webkit.org/show_bug.cgi?id=180722
101         https://trac.webkit.org/changeset/225864
102
103 2017-12-13  Youenn Fablet  <youenn@apple.com>
104
105         Update ContentFiltering.LazilyLoadPlatformFrameworks test to account for libwebrtc using VideoProcessing framework
106         https://bugs.webkit.org/show_bug.cgi?id=180713
107         <rdar://problem/36003031>
108
109         Reviewed by Andy Estes.
110
111         Reenable the check for non High Sierra builds.
112
113         * TestWebKitAPI/Tests/WebKitCocoa/ContentFiltering.mm:
114         (-[LazilyLoadPlatformFrameworksController expectParentalControlsLoaded:networkExtensionLoaded:]):
115
116 2017-12-13  Brady Eidson  <beidson@apple.com>
117
118         REGRESSION (r225789): API tests WKProcessPool.InitialWarmedProcessUsed and WebKit.WebsiteDataStoreCustomPaths are failing.
119         https://bugs.webkit.org/show_bug.cgi?id=180722
120
121         Reviewed by Chris Dumez.
122
123         * TestWebKitAPI/Tests/WebKitCocoa/InitialWarmedProcessUsed.mm:
124         (TEST): Call a new SPI to get the count of WebProcesses hosting WebPages.
125
126 2017-12-13  Mark Lam  <mark.lam@apple.com>
127
128         Fill out some Poisoned APIs, fix some bugs, and add some tests.
129         https://bugs.webkit.org/show_bug.cgi?id=180724
130         <rdar://problem/36006884>
131
132         Reviewed by JF Bastien.
133
134         * TestWebKitAPI/CMakeLists.txt:
135         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
136         * TestWebKitAPI/Tests/WTF/ConstExprPoisoned.cpp: Added.
137         (TestWebKitAPI::TEST):
138         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Added.
139         (TestWebKitAPI::initializeTestPoison):
140         (TestWebKitAPI::TEST):
141
142 2017-12-13  Jonathan Bedard  <jbedard@apple.com>
143
144         webkitpy: Better name-version mapping (Part 2)
145         https://bugs.webkit.org/show_bug.cgi?id=179621
146         <rdar://problem/35589585>
147
148         Reviewed by David Kilzer.
149
150         Now that we have a central mapping of version numbers to version names, this
151         mapping should be used to compute version names. This patch treats passes versions
152         as objects, only mapping them to names when strings are needed.
153
154         * Scripts/webkitpy/common/system/platforminfo.py:
155         (PlatformInfo.__init__): Store os_version as a version object instead of a string.
156         (PlatformInfo.os_version_name): Convert os_version to a string through the VersionNameMap.
157         * Scripts/webkitpy/common/system/platforminfo_mock.py:
158         (MockPlatformInfo.__init__): Store os_version as a version object.
159         (MockPlatformInfo.os_version_name): Mirror PlatformInfo.
160         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
161         (TestPlatformInfo.test_real_code): Only Mac and Windows have defined version objects.
162         (TestPlatformInfo.test_os_version): Deleted, this behavior is now managed by VersionNameMap.
163         * Scripts/webkitpy/common/version.py:
164         (Version.__cmp__): Allow a version object to be compared with 'None'.
165         * Scripts/webkitpy/common/version_name_map.py:
166         (VersionNameMap.map): Check for the apple_additions VersionNameMap.
167         (VersionNameMap.__init__): Add a wincairo mapping, the same as the win mapping.
168         * Scripts/webkitpy/common/version_unittest.py:
169         (VersionTestCase.test_compare_versions): Test comparing a version object to 'None'.
170         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
171         (TestConfiguration.__init__): Strip formatting from version name. Note that this object still
172         accepts a string because the version string implicitly contains the platform as well.
173         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Win7 should be 7SP0 as
174         it is in the VersionNameMap.
175         * Scripts/webkitpy/port/apple.py:
176         (ApplePort): Replace VERSION_FALLBACK_ORDER with a minimum and maximum version. This is required
177         because it may be the case that scripts are aware of more versions than the port actually supports.
178         (ApplePort.determine_full_port_name): Use the host operating system to compute the full port name.
179         (ApplePort._allowed_versions): Return a list of valid port versions by iterating through the
180         VersionNameMap.
181         (ApplePort._generate_all_test_configurations): Compute a list of configurations by iterating through
182         _allowed_versions and converting each version to a string.
183         (ApplePort._apple_baseline_path): Return a layout test expectation directory inside apple_additions.
184         (ApplePort._skipped_file_search_paths): Deleted.
185         (ApplePort._allowed_port_names): Deleted.
186         (ApplePort._future_port_name): Deleted.
187         * Scripts/webkitpy/port/base.py:
188         (Port.__init__): Replace _version string with _os_version object.
189         (Port.version_name): Convert version object to string.
190         (Port.test_configuration): Pass version string to TestConfiguration.
191         (Port.version): Deleted.
192         * Scripts/webkitpy/port/darwin_testcase.py:
193         (DarwinTest.assert_name): Convert an os_version_string to a version object and construct a port.
194         * Scripts/webkitpy/port/factory_unittest.py:
195         (FactoryTest.test_mac): Replace version strings with version objects.
196         (FactoryTest.test_win): Ditto.
197         * Scripts/webkitpy/port/gtk.py:
198         (GtkPort._generate_all_test_configurations): Replace _version with version_name().
199         * Scripts/webkitpy/port/ios.py:
200         (IOSPort.version_name): Both Simulator and device share the same version-name convention.
201         (IOSPort._generate_all_test_configurations): Replace _version with version_name().
202         (IOSPort.default_baseline_search_path): Use the internal mapping of version names to construct
203         apple_additions expectations.
204         (IOSPort._apple_additions_path): Deleted.
205         * Scripts/webkitpy/port/ios_device.py:
206         (IOSDevicePort.ios_version): Return None if no version is defined.
207         * Scripts/webkitpy/port/ios_device_unittest.py:
208         (IOSDeviceTest):
209         (IOSDeviceTest.test_layout_test_searchpath_with_apple_additions): Conform with the new mock
210         apple_additions.
211         (IOSDeviceTest.make_port): Deleted.
212         * Scripts/webkitpy/port/ios_simulator.py:
213         (IOSSimulatorPort._create_devices): Use Version object over list of version strings.
214         * Scripts/webkitpy/port/ios_simulator_unittest.py:
215         (IOSSimulatorTest):
216         (IOSSimulatorTest.make_port): Use iOS 11 as the default version for testing.
217         (IOSSimulatorTest.test_layout_test_searchpath_with_apple_additions): Conform with the new
218         mock apple_additions.
219         * Scripts/webkitpy/port/ios_testcase.py:
220         (IOSTest.make_port): Use iOS 11 as the default version for testing.
221         * Scripts/webkitpy/port/mac.py:
222         (MacPort):
223         (MacPort.__init__): Use Version object for _os_version.
224         (MacPort.default_baseline_search_path): Use the internal mapping of version names to construct
225         apple_additions expectations.
226         (MacPort.configuration_specifier_macros): Automatically construct macros based on VersionNameMap.
227         (MacPort._apple_additions_path): Deleted.
228         * Scripts/webkitpy/port/mac_unittest.py:
229         (MacTest): Use Version object instead of version string.
230         (MacTest.test_version):
231         * Scripts/webkitpy/port/port_testcase.py:
232         (bind_mock_apple_additions): Add a mock VersionNameMap to mock apple_additions.
233         (bind_mock_apple_additions.MockAppleAdditions):
234         (bind_mock_apple_additions.MockAppleAdditions.version_name_mapping):
235         * Scripts/webkitpy/port/test.py:
236         (TestPort):
237         (TestPort.__init__): Use VersionNameMap to compute the correct Version from a port name.
238         (TestPort.version_name): Mirror Port object.
239         (TestPort.baseline_search_path): Replace win7 with 7sp0.
240         (TestPort._all_systems): Ditto.
241         (TestPort.configuration_specifier_macros): Ditto.
242         * Scripts/webkitpy/port/win.py:
243         (WinPort):
244         (WinPort.__init__): Construct Version object from port name.
245         (WinPort.default_baseline_search_path): Use the internal mapping of version names to construct
246         apple_additions expectations.
247         (WinCairoPort):
248         (WinCairoPort.default_baseline_search_path): Use MIN/MAX instead of the VERSION_FALLBACK_ORDER.
249         (WinCairoPort._future_port_name): Deleted.
250         * Scripts/webkitpy/port/win_unittest.py:
251         (WinPortTest.test_baseline_search_path): Add new Windows versions not previously included.
252         (WinPortTest._assert_version): Handle expected_version as a Version object.
253         (WinPortTest.test_versions): Pass Version objects instead of version strings.
254         * Scripts/webkitpy/port/wpe.py:
255         (WPEPort._generate_all_test_configurations): Replace _version with version_name().
256         * Scripts/webkitpy/tool/commands/queries_unittest.py:
257         (PrintExpectationsTest.test_multiple): Replace win7 with 7sp0.
258         (PrintBaselinesTest.test_multiple): Ditto.
259         * Scripts/webkitpy/tool/commands/queues.py:
260         (PatchProcessingQueue._new_port_name_from_old): Use os_version_name() instead of Version object.
261
262 2017-12-12  Daniel Bates  <dabates@apple.com>
263
264         [WK] Add modern WebKit SPI to set auto fill button type and query if the auto fill button is enabled
265         https://bugs.webkit.org/show_bug.cgi?id=180686
266
267         Reviewed by Alex Christensen.
268
269         * TestWebKitAPI/Tests/WebKitCocoa/ClickAutoFillButton.mm:
270         (-[ClickAutoFillButton webProcessPlugIn:didCreateBrowserContextController:]):
271
272 2017-12-12  Alex Christensen  <achristensen@webkit.org>
273
274         Fix possible out-of-bounds read in protocolIsInHTTPFamily
275         https://bugs.webkit.org/show_bug.cgi?id=180688
276
277         Reviewed by Daniel Bates.
278
279         * TestWebKitAPI/Tests/WebCore/URL.cpp:
280         (TestWebKitAPI::TEST_F):
281
282 2017-12-12  JF Bastien  <jfbastien@apple.com>
283
284         makeString: support more integral types
285         https://bugs.webkit.org/show_bug.cgi?id=180720
286
287         Reviewed by Sam Weinig.
288
289         Test a few more types can be made string'd.
290
291         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
292         (TestWebKitAPI::TEST):
293
294 2017-12-12  Alicia Boya García  <aboya@igalia.com>
295
296         Flakiness dashboard: Make GTK and WPE builds inherit expectations from WK2
297         https://bugs.webkit.org/show_bug.cgi?id=178782
298
299         Reviewed by Michael Catanzaro.
300
301         * TestResultServer/static-dashboards/flakiness_dashboard.js:
302
303 2017-12-12  Jonathan Bedard  <jbedard@apple.com>
304
305         MobileMiniBrowser using the wrong toolchain
306         https://bugs.webkit.org/show_bug.cgi?id=180716
307         <rdar://problem/36002951>
308
309         Reviewed by Tim Horton.
310
311         Move Debug/Release configurations from xcodeproj into Base.xcconfig.
312
313         * MobileMiniBrowser/Configurations/Base.xcconfig:
314         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
315
316 2017-12-12  Youenn Fablet  <youenn@apple.com>
317
318         Update ContentFiltering.LazilyLoadPlatformFrameworks test to account for libwebrtc using VideoProcessing framework
319         https://bugs.webkit.org/show_bug.cgi?id=180713
320
321         Reviewed by Andy Estes.
322
323         Temporarily disabling a subcheck until we make the test more robust and/or libwebrtc weak linking VideoProcessing framework.
324
325         * TestWebKitAPI/Tests/WebKitCocoa/ContentFiltering.mm:
326         (-[LazilyLoadPlatformFrameworksController expectParentalControlsLoaded:networkExtensionLoaded:]):
327
328 2017-12-12  Caio Lima  <ticaiolima@gmail.com>
329
330         [ESNext][BigInt] Implement BigInt literals and JSBigInt
331         https://bugs.webkit.org/show_bug.cgi?id=179000
332
333         Reviewed by Darin Adler and Yusuke Suzuki.
334
335         * Scripts/run-jsc-stress-tests:
336
337 2017-12-12  Carlos Alberto Lopez Perez  <clopez@igalia.com>
338
339         [GTK][WPE] Bump GStreamer version to 1.12 in jhbuild
340         https://bugs.webkit.org/show_bug.cgi?id=171677
341
342         Reviewed by Carlos Garcia Campos.
343
344         Bump gstreamer related modules and rebase patches still needed and not merged
345
346         * gstreamer/jhbuild.modules:
347         * gstreamer/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Removed. This was needed for OpenWebRTC. Not longer supported.
348         * gstreamer/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Rebased.
349         * gstreamer/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Rebased.
350         * gstreamer/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Rebased.
351         * gstreamer/patches/gst-plugins-good-0009-qtdemux-fix-assert-when-moof-contains-one-sample.patch: Added a note about merge commit not still in 1.12.4.
352
353 2017-12-12  Yusuke Suzuki  <utatane.tea@gmail.com>
354
355         [WTF] Thread::create should have Thread::tryCreate
356         https://bugs.webkit.org/show_bug.cgi?id=180333
357
358         Reviewed by Darin Adler.
359
360         * TestWebKitAPI/Tests/WTF/Condition.cpp:
361         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
362         * TestWebKitAPI/Tests/WTF/Signals.cpp:
363         (TEST):
364         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp:
365         (TestWebKitAPI::testThreadGroup):
366         (TestWebKitAPI::TEST):
367
368 2017-12-11  Basuke Suzuki  <Basuke.Suzuki@sony.com>
369
370         [WinCairo] Enable running sharded tests
371         https://bugs.webkit.org/show_bug.cgi?id=180660
372
373         Reviewed by Alex Christensen.
374
375         The sharder splits the test inputs into groups of test based on the directory, 
376         but separation of base name and directory name was wrong because of this bug.
377         Once sharded correctly, the execution of layout test on native Windows environment
378         is in parallel and much less time to run.
379
380         * Scripts/webkitpy/port/win.py:
381         (WinCairoPort):
382
383 2017-12-11  Fujii Hironori  <Hironori.Fujii@sony.com>
384
385         [WinCairo] DLLLauncherMain should use SetDllDirectory
386         https://bugs.webkit.org/show_bug.cgi?id=180642
387
388         Reviewed by Alex Christensen.
389
390         Windows have icuuc.dll in the system directory. WebKit should find
391         one in WebKitLibraries directory, not one in the system directory.
392
393         * win/DLLLauncher/DLLLauncherMain.cpp:
394         (modifyPath): Use SetDllDirectory for WebKitLibraries directory instead of modifying path.
395         Do not add a path for GStreamer because nobody is using now.
396
397 2017-12-11  David Quesada  <david_quesada@apple.com>
398
399         Turn on ENABLE_APPLICATION_MANIFEST
400         https://bugs.webkit.org/show_bug.cgi?id=180562
401         rdar://problem/35924737
402
403         Reviewed by Geoffrey Garen.
404
405         * Configurations/FeatureDefines.xcconfig:
406
407 2017-12-11  Zan Dobersek  <zdobersek@igalia.com>
408
409         Unreviewed, rolling out r225737.
410
411         Breaks Git clones of the repository, including EWSs and webkitbot.
412
413         Reverted changeset:
414
415         "Add a script to automate W3c web-platform-tests pull request
416         creations from WebKit commits"
417         https://bugs.webkit.org/show_bug.cgi?id=169462
418         https://trac.webkit.org/changeset/225737
419
420 2017-12-11  Carlos Garcia Campos  <cgarcia@igalia.com>
421
422         [GTK] WebDriver: run-webdriver-tests is leaking a DumpRenderTree directory in tmp
423         https://bugs.webkit.org/show_bug.cgi?id=180426
424
425         Reviewed by Michael Catanzaro.
426
427         This happens when running the tests with Xvfb driver, because _setup_environ_for_test() is called twice and the
428         DTR temp directory is created there every time. Only the last directory created is cleaned up by the driver
429         destructor. The DRT temp directory is only needed for layout tests, so we could even avoid its creation by
430         moving it to the start() method like other drivers do (included the base driver implementation). Since API and
431         WebDriver tests don't call start(), the directory is not even created, and the required env vars are not set
432         either in that case. Weston driver was behaving differently for some reason, it's now consistent with all other
433         drivers.
434
435         * Scripts/webkitpy/port/headlessdriver.py:
436         (HeadlessDriver._setup_environ_for_test): Do not set DUMPRENDERTREE_TEMP and XDG_CACHE_HOME if _driver_tempdir is None.
437         (HeadlessDriver._start): Use Port._driver_tempdir() to create the driver temp directory.
438         * Scripts/webkitpy/port/waylanddriver.py:
439         (WaylandDriver._setup_environ_for_test): Do not set DUMPRENDERTREE_TEMP and XDG_CACHE_HOME if _driver_tempdir is None.
440         (WaylandDriver._start): Use Port._driver_tempdir() to create the driver temp directory.
441         * Scripts/webkitpy/port/westondriver.py:
442         (WestonDriver._setup_environ_for_test): Do not set DUMPRENDERTREE_TEMP and XDG_CACHE_HOME if _driver_tempdir is None.
443         (WestonDriver._start): Use Port._driver_tempdir() to create the driver temp directory.
444         (WestonDriver.stop): Do not delete the temp directory, it's done by the parent class.
445         (WestonDriver._ensure_driver_tmpdir_subdirectory): Deleted.
446         * Scripts/webkitpy/port/westondriver_unittest.py:
447         (WestonDriverTest.make_driver):
448         (WestonDriverTest.test_stop):
449         * Scripts/webkitpy/port/xorgdriver.py:
450         (XorgDriver._setup_environ_for_test): Do not set DUMPRENDERTREE_TEMP and XDG_CACHE_HOME if _driver_tempdir is None.
451         (XorgDriver._start): Use Port._driver_tempdir() to create the driver temp directory.
452         * Scripts/webkitpy/port/xvfbdriver.py:
453         (XvfbDriver._setup_environ_for_test): Do not set DUMPRENDERTREE_TEMP and XDG_CACHE_HOME if _driver_tempdir is None.
454         (XvfbDriver._start): Use Port._driver_tempdir() to create the driver temp directory.
455
456 2017-12-10  Zan Dobersek  <zdobersek@igalia.com>
457
458         Unreviewed webkitpy fix on Linux platforms after r225721.
459
460         Add an empty 'linux' entry to the PUBLIC_TABLE mapping in the
461         VersionNameMap class. This avoids asserting in this class's
462         mapping_for_platform() method when the code is evaluated on a Linux
463         system, which happens when the static VERSION_FALLBACK_ORDER member in
464         the WinCairoPort class is constructed. This can occur during a
465         test-webkitpy run or when trying to construct a WPEPort instance in
466         PortFactory, which isn't possible because again the WinCairoPort
467         instance is constructed first, leading to the same assert in both cases.
468
469         * Scripts/webkitpy/common/version_name_map.py:
470         (VersionNameMap.__init__):
471
472 2017-12-10  Youenn Fablet  <youenn@apple.com>
473
474         Add a script to automate W3c web-platform-tests pull request creations from WebKit commits
475         https://bugs.webkit.org/show_bug.cgi?id=169462
476
477         Reviewed by Darin Adler.
478
479         Adding some git helper routines used by WPT exporter.
480         Copying WPT github utility files from Chromium.
481         Updating web.py/web_mock.py to cope with these new files.
482
483         Implementing test exporter in test_exporter.py.
484         This script takes a WebKit commit as input and will create a WPT commit in a local WPT clone.
485         It will then push the commit to a public GitHub repository identified by a username parameter.
486         This parameter is passed through the command line or searched through git config/environment variables.
487
488         The script can optionally create a pull request to the official WPT GitHub repository.
489         User must provide a GitHub token to allow the script to make the PR on behalf of the user.
490         In that case, a comment is added to the corresponding bugzilla if a bug ID is given or can be found from the change log,
491         to easily link the pull request with the bugzilla bug.
492
493         * Scripts/export-w3c-test-changes: Added.
494         * Scripts/webkitpy/common/checkout/scm/git.py:
495         (Git.reset_hard):
496         (Git):
497         (Git.am):
498         (Git.commit):
499         (Git.format_patch):
500         (Git.request_pull):
501         (Git.remote):
502         (Git.push):
503         (Git.checkout_new_branch):
504         * Scripts/webkitpy/common/net/web.py:
505         (Web.request): Copied from Chromium.
506         * Scripts/webkitpy/common/net/web_mock.py: Copied needed code from Chromium.
507         * Scripts/webkitpy/w3c/test_exporter.py: Added.
508         (TestExporter):
509         (TestExporter.__init__):
510         (TestExporter._init_repository):
511         (TestExporter.download_and_commit_patch):
512         (TestExporter.clean):
513         (TestExporter.create_branch_with_patch):
514         (TestExporter.push_to_public_repository):
515         (TestExporter.make_pull_request):
516         (TestExporter.delete_local_branch):
517         (TestExporter.create_git_patch):
518         (TestExporter.create_upload_remote_if_needed):
519         (TestExporter.do_export):
520         (parse_args):
521         (configure_logging):
522         (configure_logging.LogHandler):
523         (configure_logging.LogHandler.format):
524         (main):
525         * Scripts/webkitpy/w3c/test_exporter_unittest.py: Added.
526         (TestExporterTest):
527         (TestExporterTest.MockBugzilla):
528         (TestExporterTest.MockBugzilla.__init__):
529         (TestExporterTest.MockBugzilla.fetch_bug_dictionary):
530         (TestExporterTest.MockBugzilla.post_comment_to_bug):
531         (TestExporterTest.MockGit):
532         (TestExporterTest.MockGit.clone):
533         (TestExporterTest.MockGit.__init__):
534         (TestExporterTest.MockGit.fetch):
535         (TestExporterTest.MockGit.checkout):
536         (TestExporterTest.MockGit.reset_hard):
537         (TestExporterTest.MockGit.push):
538         (TestExporterTest.MockGit.format_patch):
539         (TestExporterTest.MockGit.delete_branch):
540         (TestExporterTest.MockGit.checkout_new_branch):
541         (TestExporterTest.MockGit.am):
542         (TestExporterTest.MockGit.commit):
543         (TestExporterTest.MockGit.remote):
544         (TestExporterTest.test_export):
545         * Scripts/webkitpy/w3c/common.py: Copied from chromium.
546         * Scripts/webkitpy/w3c/wpt_github.py: Copied from chromium.
547         * Scripts/webkitpy/w3c/wpt_github_mock.py: Copied from chromium.
548         * Scripts/webkitpy/w3c/wpt_github_unittest.py: Copied from chromium.
549
550 2017-12-10  Konstantin Tokarev  <annulen@yandex.ru>
551
552         [python] Modernize "except" usage for python3 compatibility
553         https://bugs.webkit.org/show_bug.cgi?id=180612
554
555         Reviewed by Michael Catanzaro.
556
557         * BuildSlaveSupport/build.webkit.org-config/committer_auth.py:
558         (CommitterAuth.auth_json):
559         (CommitterAuth.authenticate):
560         (CommitterAuth.is_webkit_committer):
561         (CommitterAuth.is_webkit_trac_user):
562         * BuildSlaveSupport/wait-for-SVN-server.py:
563         (getLatestSVNRevision):
564         * QueueStatusServer/handlers/updatebase.py:
565         (UpdateBase._int_from_request):
566         * Scripts/webkitpy/bindings/main.py:
567         (BindingsTests.generate_from_idl):
568         (BindingsTests.generate_supplemental_dependency):
569         (BindingsTests.detect_changes):
570         * Scripts/webkitpy/codegen/main.py:
571         (BuiltinsGeneratorTests.generate_from_js_builtins):
572         (BuiltinsGeneratorTests.detect_changes):
573         * Scripts/webkitpy/common/checkout/changelog.py:
574         (ChangeLog.parse_latest_entry_from_file):
575         * Scripts/webkitpy/common/checkout/checkout.py:
576         (Checkout.bug_id_for_this_commit):
577         * Scripts/webkitpy/common/checkout/scm/git.py:
578         (Git.in_working_directory):
579         (Git.clone):
580         (Git._string_to_int_or_none):
581         (Git._commit_on_branch):
582         * Scripts/webkitpy/common/checkout/scm/svn.py:
583         (SVN.revisions_changing_file):
584         * Scripts/webkitpy/common/config/committers.py:
585         (CommitterList.load_json):
586         * Scripts/webkitpy/common/message_pool.py:
587         (_Worker.run):
588         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
589         (Builder.force_build.predicate):
590         (Builder._fetch_revision_to_build_map):
591         (BuildBot._fetch_build_dictionary):
592         * Scripts/webkitpy/common/net/credentials.py:
593         (Credentials._credentials_from_git):
594         * Scripts/webkitpy/common/net/networktransaction.py:
595         (NetworkTransaction.run):
596         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
597         (NetworkTransactionTest.test_exception):
598         (NetworkTransactionTest.test_timeout):
599         * Scripts/webkitpy/common/net/statusserver.py:
600         (StatusServer._fetch_url):
601         * Scripts/webkitpy/common/net/unittestresults.py:
602         (UnitTestResults.results_from_string):
603         * Scripts/webkitpy/common/prettypatch.py:
604         (PrettyPatch.check_pretty_patch):
605         (PrettyPatch.pretty_patch_text):
606         * Scripts/webkitpy/common/prettypatch_unittest.py:
607         (PrettyPatchTest.check_ruby):
608         * Scripts/webkitpy/common/system/autoinstall.py:
609         (AutoInstaller._extract_tar):
610         (AutoInstaller._unzip):
611         (AutoInstaller._replace_domain_with_next_mirror):
612         (AutoInstaller._download_to_stream):
613         (AutoInstaller.install):
614         * Scripts/webkitpy/common/system/crashlogs.py:
615         (CrashLogs._find_newest_log_darwin):
616         (CrashLogs._find_newest_log_win):
617         (CrashLogs._find_all_logs_darwin):
618         * Scripts/webkitpy/common/system/executive.py:
619         (Executive.kill_process):
620         (Executive.running_pids):
621         * Scripts/webkitpy/common/system/filesystem.py:
622         (FileSystem.maybe_make_directory):
623         (FileSystem.remove):
624         * Scripts/webkitpy/common/system/user.py:
625         (User._wait_on_list_response):
626         (User.edit):
627         (User.page):
628         (User.can_open_url):
629         * Scripts/webkitpy/common/system/workspace.py:
630         (Workspace.create_zip):
631         * Scripts/webkitpy/common/watchlist/watchlistparser.py:
632         (WatchListParser._parse_definition_section):
633         * Scripts/webkitpy/common/webkitunittest.py:
634         (TestCase._assertRaisesRegexp):
635         * Scripts/webkitpy/inspector/main.py:
636         (InspectorGeneratorTests.generate_from_json):
637         (InspectorGeneratorTests.detect_changes):
638         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
639         (LayoutTestFinder._read_test_names_from_file):
640         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
641         (LayoutTestRunner.run_tests):
642         * Scripts/webkitpy/layout_tests/controllers/manager.py:
643         (Manager.upload_results):
644         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
645         (JSONResultsGenerator.upload_json_files):
646         (JSONResultsGenerator._get_archived_json_results):
647         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
648         (MiscTests.test_parse_warning):
649         (SemanticTests.test_bad_bugid):
650         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
651         (summarize_results):
652         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
653         (main):
654         * Scripts/webkitpy/layout_tests/servers/http_server.py:
655         (Lighttpd._remove_stale_logs):
656         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
657         (HttpServerBase._is_running_on_port):
658         (HttpServerBase._check_that_all_ports_are_available):
659         * Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py:
660         (BaseTest.assert_servers_are_down):
661         (BaseTest.assert_servers_are_up):
662         (BaseTest.integration_test_server__fails):
663         (BaseTest.maybe_make_dir):
664         * Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py:
665         (run_server):
666         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
667         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
668         (PyWebSocket.is_running):
669         (PyWebSocket._remove_stale_logs):
670         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
671         (_merge_slave_config_json):
672         (_merge_outputs_if_needed):
673         (_upload_json):
674         * Scripts/webkitpy/port/base.py:
675         (Port._build_driver):
676         (Port._build_image_diff):
677         (Port._symbols_string):
678         * Scripts/webkitpy/port/leakdetector.py:
679         (LeakDetector.count_total_bytes_and_unique_leaks):
680         (LeakDetector.check_for_leaks):
681         * Scripts/webkitpy/port/leakdetector_valgrind.py:
682         (LeakDetectorValgrind._parse_leaks_output):
683         * Scripts/webkitpy/port/mac.py:
684         (MacPort.reset_preferences):
685         (MacPort.stop_helper):
686         * Scripts/webkitpy/port/port_testcase.py:
687         (PortTestCase.assert_servers_are_down):
688         (PortTestCase.assert_servers_are_up):
689         (PortTestCase.integration_test_http_server__fails):
690         (PortTestCase.integration_test_websocket_server__fails):
691         * Scripts/webkitpy/port/server_process.py:
692         (ServerProcess.write):
693         (ServerProcess._wait_for_data_and_update_buffers_using_select):
694         (ServerProcess._non_blocking_read_win32):
695         * Scripts/webkitpy/port/win.py:
696         (WinPort._runtime_feature_list):
697         * Scripts/webkitpy/port/xvfbdriver.py:
698         (XvfbDriver._xvfb_read_display_id):
699         * Scripts/webkitpy/style/checkers/jsonchecker.py:
700         (JSONChecker.check):
701         * Scripts/webkitpy/style/checkers/xml.py:
702         (XMLChecker.check):
703         * Scripts/webkitpy/style/filereader.py:
704         (TextFileReader.process_file):
705         * Scripts/webkitpy/style/filereader_unittest.py:
706         (TextFileReaderTest.test_process_file__does_not_exist):
707         * Scripts/webkitpy/style/optparser.py:
708         (ArgumentParser.parse):
709         * Scripts/webkitpy/tool/bot/irc_command.py:
710         (CreateBug.execute):
711         (Rollout.execute):
712         * Scripts/webkitpy/tool/bot/ircbot.py:
713         (IRCBot.process_message):
714         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
715         (LayoutTestResultsReader._read_file_contents):
716         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
717         (PatchAnalysisTask._run_command):
718         * Scripts/webkitpy/tool/bot/queueengine.py:
719         (QueueEngine.run):
720         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
721         (AbstractSequencedCommand.execute):
722         * Scripts/webkitpy/tool/commands/download.py:
723         (AbstractPatchSequencingCommand._prepare_to_process):
724         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
725         (AbstractEarlyWarningSystem.review_patch):
726         * Scripts/webkitpy/tool/commands/queries.py:
727         (FailureReason._blame_line_for_revision):
728         * Scripts/webkitpy/tool/commands/queues.py:
729         (AbstractQueue._cc_watchers):
730         (AbstractQueue.run_webkit_patch):
731         (CommitQueue.process_work_item):
732         (StyleQueue.review_patch):
733         * Scripts/webkitpy/tool/commands/rebaseline.py:
734         (AbstractParallelRebaselineCommand._run_webkit_patch):
735         * Scripts/webkitpy/tool/commands/stepsequence.py:
736         (StepSequence.run_and_handle_errors):
737         * Scripts/webkitpy/tool/commands/suggestnominations.py:
738         (SuggestNominations._count_recent_patches):
739         * Scripts/webkitpy/tool/multicommandtool.py:
740         (MultiCommandTool.main):
741         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
742         (_rebaseline_test):
743         (_move_test_baselines):
744         * Scripts/webkitpy/tool/steps/addsvnmimetypeforpng_unittest.py:
745         (AddSvnMimetypeForPngTest.test_run):
746         * Scripts/webkitpy/tool/steps/checkstyle.py:
747         (CheckStyle.run):
748         * Scripts/webkitpy/tool/steps/commit.py:
749         (Commit._check_test_expectations):
750         (Commit.run):
751         * Scripts/webkitpy/tool/steps/confirmdiff.py:
752         (ConfirmDiff._show_pretty_diff):
753         * Scripts/webkitpy/tool/steps/haslanded.py:
754         (HasLanded.diff_diff):
755         * Scripts/webkitpy/tool/steps/preparechangelog.py:
756         (PrepareChangeLog.run):
757         * Scripts/webkitpy/tool/steps/promptforbugortitle.py:
758         (PromptForBugOrTitle.run):
759         * Scripts/webkitpy/tool/steps/sortxcodeprojectfiles.py:
760         (SortXcodeProjectFiles.run):
761         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:
762         (WebDriverW3CWebServer._wait_for_server.check_port):
763         * TestResultServer/model/datastorefile.py:
764         (DataStoreFile.save_data):
765         * jhbuild/jhbuildutils.py:
766         (enter_jhbuild_environment_if_available):
767
768 2017-12-09  Yusuke Suzuki  <utatane.tea@gmail.com>
769
770         Fix WTF::Hasher tuple expansion with variadic args
771         https://bugs.webkit.org/show_bug.cgi?id=180623
772
773         Reviewed by JF Bastien.
774
775         * TestWebKitAPI/Tests/WTF/Hasher.cpp:
776         (TestWebKitAPI::TEST):
777
778 2017-12-09  Konstantin Tokarev  <annulen@yandex.ru>
779
780         [python] Replace print >> operator with print() function for python3 compatibility
781         https://bugs.webkit.org/show_bug.cgi?id=180611
782
783         Reviewed by Michael Catanzaro.
784
785         * CygwinDownloader/cygwin-downloader.py:
786         (download_url_to_file):
787         * Scripts/webkitpy/common/system/profiler.py:
788         (Perf.profile_after_exit):
789         * Scripts/webkitpy/common/version_check.py:
790         * Scripts/webkitpy/layout_tests/lint_test_expectations.py:
791         (main):
792         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
793         (main):
794         * Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py:
795         (run_server):
796         * Scripts/webkitpy/tool/commands/analyzechangelog.py:
797         (ChangeLogAnalyzer._print_status):
798         * Scripts/webkitpy/tool/commands/queries.py:
799         (BugsToCommit.execute):
800         (PatchesInCommitQueue.execute):
801         (PatchesToCommitQueue.execute):
802         (PatchesToReview._print_report):
803         (WhatBroke._print_builder_line):
804         (WhatBroke._print_blame_information_for_builder):
805         (WhatBroke.execute):
806         (ResultsFor._print_layout_test_results):
807         (ResultsFor.execute):
808         (FailureReason._print_blame_information_for_transition):
809         (FailureReason._explain_failures_for_builder):
810         (FailureReason._builder_to_explain):
811         (FailureReason.execute):
812         (FindFlakyTests._find_failures):
813         (FindFlakyTests._print_statistics):
814         (FindFlakyTests._walk_backwards_from):
815         (execute):
816         (PrintExpectations.execute):
817         (PrintBaselines.execute):
818         (PrintBaselines._print_baselines):
819         (FindResolvedBugs.execute):
820         * Scripts/webkitpy/tool/commands/rebaseline.py:
821         (AbstractParallelRebaselineCommand._run_webkit_patch):
822         (AbstractParallelRebaselineCommand._rebaseline):
823         * Scripts/webkitpy/tool/servers/gardeningserver.py:
824         (GardeningHTTPRequestHandler.rebaselineall):
825         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
826         (GardeningServerTest.disabled_test_rebaselineall.run_command):
827         (GardeningServerTest):
828
829 2017-12-08  Basuke Suzuki  <Basuke.Suzuki@sony.com>
830
831         [Win] The way to detect Windows 10 is wrong
832         https://bugs.webkit.org/show_bug.cgi?id=179344
833         <rdar://problem/35562264>
834
835         Reviewed by Alex Christensen.
836
837         Python2.7 doesn't return correct information on Windows 10.
838         Use platform.win32_ver() instead of sys.getwindowsversion().
839
840         * Scripts/webkitpy/common/system/platforminfo.py:
841         (PlatformInfo._win_version):
842         (PlatformInfo._win_version_str):
843         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
844         (fake_sys):
845         (fake_sys.FakeSysModule):
846         (fake_platform):
847         (fake_platform.FakePlatformModule.win32_ver):
848         (TestPlatformInfo.test_os_name_and_wrappers):
849         (TestPlatformInfo.test_os_version):
850         (TestPlatformInfo.test_display_name):
851         (TestPlatformInfo.test_total_bytes_memory):
852
853 2017-12-08  Basuke Suzuki  <Basuke.Suzuki@sony.com>
854
855         [WinCairo] Fix runtime error after r225229
856         https://bugs.webkit.org/show_bug.cgi?id=180614
857
858         Reviewed by Alex Christensen.
859
860         The list of fallback versions doesn't match with version name mapping introduced recently.
861         It should be safe by creating the list automatically from the name map for consistency.
862  
863         * Scripts/webkitpy/common/version_name_map.py:
864         (VersionNameMap.__init__):
865         (VersionNameMap.to_name):
866         (VersionNameMap.from_name):
867         (VersionNameMap):
868         (VersionNameMap.names):
869         (VersionNameMap.mapping_for_platform):
870         * Scripts/webkitpy/port/win.py:
871         (WinCairoPort):
872         (WinCairoPort.default_baseline_search_path):
873
874 2017-12-08  David Quesada  <david_quesada@apple.com>
875
876         ApplicationManifestParser should strip whitespace from the raw input
877         https://bugs.webkit.org/show_bug.cgi?id=180539
878         rdar://problem/35915075
879
880         Reviewed by Joseph Pecoraro.
881
882         Added an API test for parsing manifests with surrounding whitespace.
883
884         Also drive-by fix ApplicationManifestParserTest.Display. Earlier versions of the
885         manifest spec explicitly stated that the "display" value should be treated as if
886         it were run through String.prototype.trim(), which allowed for the really weird
887         edge case of an array containing one string. This behavior was lost when I changed
888         ApplicationManifestParser's JSON parsing from using JavaScriptCore to WTF's JSON
889         parsing. Update the unit test accordingly.
890
891         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
892         (TEST_F):
893
894 2017-12-08  Konstantin Tokarev  <annulen@yandex.ru>
895
896         [python] Replace print operator with print() function for python3 compatibility
897         https://bugs.webkit.org/show_bug.cgi?id=180592
898
899         Reviewed by Michael Catanzaro.
900
901         * BuildSlaveSupport/wait-for-SVN-server.py:
902         (getLatestSVNRevision):
903         (waitForSVNRevision):
904         * Scripts/download-latest-github-release.py:
905         (find_latest_release):
906         (main):
907         * Scripts/update-wasm-gcc-torture.py:
908         (update_lkgr):
909         (untar_torture):
910         (list_js_files):
911         (waterfall_known_failures):
912         * Scripts/update-webkit-wincairo-libs.py:
913         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
914         (BenchmarkRunner.show_results):
915         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
916         (SimpleHTTPServerDriver.fetch_result):
917         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
918         (list_benchmark_plans):
919         * Scripts/webkitpy/bindings/main.py:
920         (BindingsTests.generate_from_idl):
921         (BindingsTests.generate_supplemental_dependency):
922         (BindingsTests.detect_changes):
923         (BindingsTests.run_tests):
924         (BindingsTests.main):
925         * Scripts/webkitpy/codegen/main.py:
926         (BuiltinsGeneratorTests.generate_from_js_builtins):
927         (BuiltinsGeneratorTests.detect_changes):
928         (BuiltinsGeneratorTests.single_builtin_test):
929         (BuiltinsGeneratorTests.run_test):
930         (BuiltinsGeneratorTests.run_tests):
931         (BuiltinsGeneratorTests.main):
932         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
933         (MockBugzilla.fetch_attachment):
934         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
935         (Builder._fetch_revision_to_build_map):
936         * Scripts/webkitpy/common/system/crashlogs.py:
937         (CrashLogs._find_newest_log_win):
938         * Scripts/webkitpy/common/system/outputcapture_unittest.py:
939         (OutputCaptureTest.test_output_capture_scope):
940         * Scripts/webkitpy/common/system/profiler.py:
941         (GooglePProf.profile_after_exit):
942         (Perf.profile_after_exit):
943         * Scripts/webkitpy/common/system/user.py:
944         (User.prompt_with_multiple_lists):
945         (User.prompt_with_list):
946         (User._warn_if_application_is_xcode):
947         (User.edit_changelog):
948         * Scripts/webkitpy/inspector/main.py:
949         (InspectorGeneratorTests.generate_from_json):
950         (InspectorGeneratorTests.detect_changes):
951         (InspectorGeneratorTests.run_tests):
952         (InspectorGeneratorTests.main):
953         * Scripts/webkitpy/layout_tests/controllers/manager.py:
954         (Manager._print_expectation_line_for_test):
955         (Manager._print_expectations_for_subset):
956         (Manager._print_expectations_for_subset.if):
957         * Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py:
958         (run_server):
959         * Scripts/webkitpy/port/config_standalone.py:
960         (main):
961         * Scripts/webkitpy/port/darwin_testcase.py:
962         (DarwinTest.test_spindump.logging_run_command):
963         (DarwinTest.test_sample_process.logging_run_command):
964         * Scripts/webkitpy/port/ios.py:
965         (IOSPort.clean_up_test_run):
966         * Scripts/webkitpy/port/ios_device_unittest.py:
967         (IOSDeviceTest.test_spindump.logging_run_command):
968         (IOSDeviceTest.test_sample_process.logging_run_command):
969         * Scripts/webkitpy/port/ios_simulator_unittest.py:
970         (IOSSimulatorTest.test_xcrun.throwing_run_command):
971         * Scripts/webkitpy/port/leakdetector_unittest.py:
972         (test_count_total_bytes_and_unique_leaks.mock_run_script):
973         * Scripts/webkitpy/port/mac_unittest.py:
974         (MacTest.test_xcrun.throwing_run_command):
975         * Scripts/webkitpy/style/checkers/contributors.py:
976         (ContributorsChecker.check):
977         * Scripts/webkitpy/tool/commands/abstractlocalservercommand.py:
978         (AbstractLocalServerCommand.execute):
979         * Scripts/webkitpy/tool/commands/adduserstogroups.py:
980         (AddUsersToGroups.execute):
981         * Scripts/webkitpy/tool/commands/analyzechangelog.py:
982         (AnalyzeChangeLog._generate_jsons):
983         (AnalyzeChangeLog.execute):
984         (ChangeLogAnalyzer._set_filename):
985         (ChangeLogAnalyzer.analyze):
986         * Scripts/webkitpy/tool/commands/bugfortest.py:
987         (BugForTest.execute):
988         * Scripts/webkitpy/tool/commands/bugsearch.py:
989         (execute):
990         * Scripts/webkitpy/tool/commands/findusers.py:
991         (FindUsers.execute):
992         * Scripts/webkitpy/tool/commands/gardenomatic.py:
993         (GardenOMatic.execute):
994         * Scripts/webkitpy/tool/commands/rebaseline.py:
995         (RebaselineTest.execute):
996         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
997         (RebaselineServer._prepare_config):
998         * Scripts/webkitpy/tool/commands/setupgitclone.py:
999         (SetupGitClone.execute):
1000         (SetupGitClone._get_username_and_email):
1001         * Scripts/webkitpy/tool/commands/suggestnominations.py:
1002         (SuggestNominations._print_nominations):
1003         (SuggestNominations._print_counts):
1004         * Scripts/webkitpy/tool/commands/upload.py:
1005         (CommitMessageForCurrentDiff.execute):
1006         (CreateBug.prompt_for_bug_title_and_comment):
1007         * Scripts/webkitpy/tool/multicommandtool.py:
1008         (HelpCommand.execute):
1009         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1010         (TestGardeningHTTPRequestHandler._serve_text):
1011         (TestGardeningHTTPRequestHandler._serve_json):
1012         * Scripts/webkitpy/tool/steps/addsvnmimetypeforpng.py:
1013         (AddSvnMimetypeForPng.run):
1014         * Scripts/webkitpy/tool/steps/suggestreviewers.py:
1015         (SuggestReviewers.run):
1016         * Scripts/webkitpy/w3c/test_importer.py:
1017         (TestImporter.update_tests_options):
1018         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
1019         (WebDriverTestRunnerSelenium.run):
1020         * TestResultServer/model/jsonresults_unittest.py:
1021         * gtk/ycm_extra_conf.py:
1022         (FlagsForFile):
1023         * lldb/lldb_webkit.py:
1024         (btjs):
1025
1026 2017-12-08  Eric Carlson  <eric.carlson@apple.com>
1027
1028         Move Logger from PAL to WTF so it can be used outside of WebCore
1029         https://bugs.webkit.org/show_bug.cgi?id=180561
1030
1031         Reviewed by Alex Christensen.
1032
1033         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1034         (TestWebKitAPI::TEST_F):
1035
1036 2017-12-08  Chris Dumez  <cdumez@apple.com>
1037
1038         Different WebKitTestRunner instances should use different service worker registrations databases
1039         https://bugs.webkit.org/show_bug.cgi?id=180589
1040
1041         Reviewed by Brady Eidson.
1042
1043         * WebKitTestRunner/TestController.cpp:
1044         (WTR::TestController::generateContextConfiguration const):
1045
1046 2017-12-08  Fujii Hironori  <Hironori.Fujii@sony.com>
1047
1048         Tools/ImageDiff/cg/PlatformImageCG.cpp doesn't need to include <wtf/MathExtras.h>
1049         https://bugs.webkit.org/show_bug.cgi?id=180578
1050
1051         Reviewed by Konstantin Tokarev.
1052
1053         * ImageDiff/cg/PlatformImageCG.cpp: Removed unnecessary #include <wtf/MathExtras.h>.
1054
1055 2017-12-08  Zan Dobersek  <zdobersek@igalia.com>
1056
1057         Unreviewed WPE build fix after r225671.
1058
1059         * WebKitTestRunner/InjectedBundle/wpe/TestRunnerWPE.cpp:
1060         Include the ActivateFonts.h header to have a usable
1061         WTR::installFakeHelvetica() function declaration.
1062
1063 2017-12-07  Zan Dobersek  <zdobersek@igalia.com>
1064
1065         Unreviewed GTK+ and WPE build fix.
1066
1067         Add TestRunner::installFakeHelvetica(), WTR::installFakeHelvetica()
1068         and WTF::uninstallFakeHelvetica() definitions, filling out the
1069         declarations added in r225641. This fills up missing symbols in the
1070         WKTR's InjectedBundle library, unbreaking layout tests for both
1071         configurations.
1072
1073         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1074         (WTR::installFakeHelvetica):
1075         (WTR::uninstallFakeHelvetica):
1076         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
1077         (WTR::TestRunner::inspectorTestStubURL):
1078         (WTR::TestRunner::installFakeHelvetica):
1079         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
1080         (WTR::installFakeHelvetica):
1081         (WTR::uninstallFakeHelvetica):
1082         * WebKitTestRunner/InjectedBundle/wpe/TestRunnerWPE.cpp:
1083         (WTR::TestRunner::installFakeHelvetica):
1084
1085 2017-12-07  Yusuke Suzuki  <utatane.tea@gmail.com>
1086
1087         Use StaticLock instead of NeverDestroyed<Lock>
1088         https://bugs.webkit.org/show_bug.cgi?id=180507
1089
1090         Reviewed by Saam Barati.
1091
1092         * DumpRenderTree/JavaScriptThreading.cpp:
1093         (javaScriptThreads):
1094         (runJavaScriptThread):
1095         (startJavaScriptThreads):
1096         (stopJavaScriptThreads):
1097         (javaScriptThreadsMutex): Deleted.
1098
1099 2017-12-07  Alex Christensen  <achristensen@webkit.org>
1100
1101         Always synchronously continue with fragment navigations
1102         https://bugs.webkit.org/show_bug.cgi?id=180544
1103         <rdar://problem/34815986> and <rdar://problem/35126690>
1104
1105         Reviewed by Geoffrey Garen.
1106
1107         * TestWebKitAPI/Tests/WebKitCocoa/DecidePolicyForNavigationAction.mm:
1108         (-[DecidePolicyForNavigationActionFragmentDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1109         (TEST):
1110         Add a test that verifies that decidePolicyForNavigationAction is called for fragment navigations.
1111
1112 2017-12-07  Myles C. Maxfield  <mmaxfield@apple.com>
1113
1114         [Cocoa] Add SPI to disallow user-installed fonts
1115         https://bugs.webkit.org/show_bug.cgi?id=180062
1116         <rdar://problem/35042408>
1117
1118         Reviewed by Simon Fraser.
1119
1120         * WebKitTestRunner/InjectedBundle/ActivateFonts.h:
1121         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1122         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1123         (WTR::InjectedBundlePage::resetAfterTest):
1124         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1125         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1126         (WTR::resourcesDirectoryURL):
1127         (WTR::activateFonts):
1128         (WTR::installFakeHelvetica):
1129         (WTR::uninstallFakeHelvetica):
1130         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1131         (WTR::TestRunner::installFakeHelvetica):
1132         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1133         * WebKitTestRunner/fonts/FakeHelvetica-Helvetica-400.ttf: Added.
1134         * WebKitTestRunner/fonts/FakeHelvetica-Helvetica-500.ttf: Added.
1135         * WebKitTestRunner/fonts/FakeHelvetica-Helvetica2-400.ttf: Added.
1136         * WebKitTestRunner/fonts/FakeHelvetica-Helvetica2-500.ttf: Added.
1137
1138 2017-12-07  David Quesada  <david_quesada@apple.com>
1139
1140         [Web App Manifest] Support display-mode media feature
1141         https://bugs.webkit.org/show_bug.cgi?id=180376
1142         rdar://problem/35837993
1143
1144         Reviewed by Geoffrey Garen.
1145
1146         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1147         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
1148         (WebCore::operator<<):
1149         (ApplicationManifestParserTest::testDisplay):
1150         (TEST_F):
1151             Add unit tests for the parsing of the 'display' manifest property.
1152
1153         * TestWebKitAPI/Tests/WebKitCocoa/ApplicationManifest.mm:
1154         (TestWebKitAPI::TEST):
1155         * TestWebKitAPI/Tests/WebKitCocoa/display-mode.html: Added.
1156             Update API tests to include _WKApplicationManifest.displayMode.
1157
1158         * WebKitTestRunner/TestController.cpp:
1159         (WTR::parseStringTestHeaderValueAsRelativePath):
1160         (WTR::updateTestOptionsFromTestHeader):
1161         * WebKitTestRunner/TestOptions.h:
1162         (WTR::TestOptions::hasSameInitializationOptions const):
1163         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1164         (WTR::TestController::platformCreateWebView):
1165             Teach WKTR to look for and apply an app manifest. A new <!--webkit-test-runner-->
1166             directive 'applicationManifest' can specify a path (relative to the test file itself)
1167             to a JSON app manifest to be applied to the web view before running the test.
1168
1169 2017-12-07  Eric Carlson  <eric.carlson@apple.com>
1170
1171         Add WebRTC watchlist rule, update MediaStream rule
1172         https://bugs.webkit.org/show_bug.cgi?id=180536
1173         <rdar://problem/35914066>
1174
1175         Reviewed by Youenn Fablet.
1176
1177         * Scripts/webkitpy/common/config/watchlist:
1178
1179 2017-12-06  Chris Dumez  <cdumez@apple.com>
1180
1181         We should be able to recover after a Service Worker process crash
1182         https://bugs.webkit.org/show_bug.cgi?id=180477
1183
1184         Reviewed by Brady Eidson and Youenn Fablet.
1185
1186         Add testRunner API to terminate the Service Worker process.
1187
1188         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1189         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1190         (WTR::TestRunner::terminateServiceWorkerProcess):
1191         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1192         * WebKitTestRunner/TestController.cpp:
1193         (WTR::TestController::terminateServiceWorkerProcess):
1194         * WebKitTestRunner/TestController.h:
1195         * WebKitTestRunner/TestInvocation.cpp:
1196         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1197
1198 2017-12-02  Darin Adler  <darin@apple.com>
1199
1200         Modernize some aspects of text codecs, eliminate WebKit use of strcasecmp
1201         https://bugs.webkit.org/show_bug.cgi?id=180009
1202
1203         Reviewed by Alex Christensen.
1204
1205         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Removed include of StringExtras.h.
1206
1207         * TestWebKitAPI/CMakeLists.txt: Added LineEnding.cpp.
1208         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
1209         * TestWebKitAPI/Tests/WTF/LineEnding.cpp: Added. Has tests for the LineEnding
1210         functions rewritten in this patch.
1211
1212         * TestWebKitAPI/Tests/WebCore/TextCodec.cpp: Updated test now that the decode
1213         function doesn't have defaults for as many arguments any more. Also changed so
1214         that the tests log the fact that the decode function returns an error and updated
1215         expected results to expect all the errors.
1216
1217         * WebKitTestRunner/cg/TestInvocationCG.cpp: Ditto.
1218
1219 2017-12-06  Alexey Proskuryakov  <ap@apple.com>
1220
1221         Exclude another leak callstack.
1222
1223         * Scripts/webkitpy/port/leakdetector.py: (LeakDetector._callstacks_to_exclude_from_leaks):
1224
1225 2017-12-06  Jeff Miller  <jeffm@apple.com>
1226
1227         -[WKWebViewConfiguration copyWithZone] doesn't copy _groupIdentifier
1228         https://bugs.webkit.org/show_bug.cgi?id=180504
1229
1230         Reviewed by Geoffrey Garen.
1231
1232         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
1233         Add a test to verify that the _groupIdentifier is copied.
1234
1235 2017-12-06  David Quesada  <david_quesada@apple.com>
1236
1237         [Web App Manifest] Add SPI for fetching the manifest
1238         https://bugs.webkit.org/show_bug.cgi?id=180294
1239         rdar://problem/34747968
1240
1241         Reviewed by Geoffrey Garen.
1242
1243         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1244         * TestWebKitAPI/Tests/WebKitCocoa/ApplicationManifest.mm: Added.
1245             Added two API tests for _WKApplicationManifest:
1246             - Testing _WKApplicationManifest's conformance to NSCoding.
1247             - Testing -[WKWebView _getApplicationManifestWithCompletionHandler:], verifying the
1248               values of the resulting _WKApplicationManifest.
1249         (TestWebKitAPI::TEST):
1250
1251         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1252             Added a new testRunner method getApplicationManifestThen(), used by the LayoutTests
1253             to request the document load its associated manifest. The layout tests formerly called
1254             an unimplemented function getManifestThen(), but I added 'Application' to somewhat
1255             differentiate this from the app cache manifest.
1256
1257         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1258         (WTR::InjectedBundle::didReceiveMessageToPage):
1259         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1260         (WTR::TestRunner::getApplicationManifestThen):
1261         (WTR::TestRunner::didGetApplicationManifest):
1262         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1263         * WebKitTestRunner/TestInvocation.cpp:
1264         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1265
1266 2017-12-05  Stephan Szabo  <stephan.szabo@sony.com>
1267
1268         Switch windows build to Visual Studio 2017
1269         https://bugs.webkit.org/show_bug.cgi?id=172412
1270
1271         Reviewed by Per Arne Vollan.
1272
1273         * Scripts/build-webkit:
1274         * Scripts/webkitdirs.pm:
1275         (visualStudioInstallDir):
1276         (visualStudioInstallDirFallback):
1277         (msBuildInstallDir):
1278         (setupAppleWinEnv):
1279         (setupCygwinEnv):
1280         (generateBuildSystemFromCMakeProject):
1281         (pickLegacyVisualStudioInstallation): Deleted.
1282         (visualStudioInstallDirLegacy): Deleted.
1283         (visualStudioVersion): Deleted.
1284         (visualStudioVersionFromInstallDir): Deleted.
1285
1286 2017-12-05  Alex Christensen  <achristensen@webkit.org>
1287
1288         Fix crash when loading a file URL that does not have a fileSystemPath representation
1289         https://bugs.webkit.org/show_bug.cgi?id=180448
1290         <rdar://problem/22805921>
1291
1292         Reviewed by Chris Dumez.
1293
1294         * TestWebKitAPI/Tests/WebKitCocoa/LoadAlternateHTMLString.mm:
1295         (TEST):
1296         Test opening a URL that used to crash WebKit.
1297
1298 2017-12-05  Michael Saboff  <msaboff@apple.com>
1299
1300         Make WebKit build for ARM64_32
1301         https://bugs.webkit.org/show_bug.cgi?id=180447
1302
1303         Reviewed by Mark Lam.
1304
1305         Add an instance of the _TestWTFAlwaysMissing for arm64_32 architecture.
1306
1307         * TestWebKitAPI/Tests/WTF/darwin/libTestWTFAlwaysMissing-iOS-v2.tbd:
1308
1309 2017-12-05  Aakash Jain  <aakash_jain@apple.com>
1310
1311         [build.webkit.org] Rename mastercfg_unittest to steps_unittest
1312         https://bugs.webkit.org/show_bug.cgi?id=180432
1313
1314         Rubber-stamped by Alexey Proskuryakov.
1315
1316         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Removed.
1317         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Copied from BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py.
1318
1319 2017-12-05  Aakash Jain  <aakash_jain@apple.com>
1320
1321         [build.webkit.org] Fix style issues in mastercfg_unittest.py
1322         https://bugs.webkit.org/show_bug.cgi?id=180439
1323
1324         Reviewed by Alexey Proskuryakov.
1325
1326         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Added imports directly instead of relying
1327         on imports from other files. We will try to import minimum required modules. Currently we are importing
1328         everything from master.cfg, loadConfig.py, factories.py and steps.py
1329
1330 2017-12-05  Aakash Jain  <aakash_jain@apple.com>
1331
1332         [build.webkit.org] Rename MasterCfgTest to RunWebKitTestsTest
1333         https://bugs.webkit.org/show_bug.cgi?id=180391
1334
1335         Rubber-stamped by Alexey Proskuryakov.
1336
1337         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1338         (RunWebKitTestsTest): Renamed from MasterCfgTest.
1339
1340 2017-12-01  Filip Pizlo  <fpizlo@apple.com>
1341
1342         GC constraint solving should be parallel
1343         https://bugs.webkit.org/show_bug.cgi?id=179934
1344
1345         Reviewed by JF Bastien.
1346
1347         * Scripts/run-jsc-benchmarks: Add splay-latency test, since this change needed to be carefully validated with that benchmark.
1348         * TestWebKitAPI/CMakeLists.txt:
1349         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1350         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp: Added. This has unit tests of the new concurrent data structure. The tests focus on correctness under serial execution, which appears to be enough for now (it's so easy to catch a concurrency bug by just running the GC).
1351         (TestWebKitAPI::TEST):
1352
1353 2017-12-04  Nan Wang  <n_wang@apple.com>
1354
1355         AX: AOM: Implement relation type properties
1356         https://bugs.webkit.org/show_bug.cgi?id=179500
1357
1358         Reviewed by Ryosuke Niwa.
1359
1360         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1361         (WTR::AccessibilityUIElement::ariaDetailsElementAtIndex):
1362         (WTR::AccessibilityUIElement::ariaErrorMessageElementAtIndex):
1363         (WTR::AccessibilityUIElement::ariaDescribedByReferencingElementAtIndex):
1364         (WTR::AccessibilityUIElement::ariaDetailsReferencingElementAtIndex):
1365         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1366         (WTR::AccessibilityUIElement::ariaDetailsElementAtIndex):
1367         (WTR::AccessibilityUIElement::ariaErrorMessageElementAtIndex):
1368
1369 2017-12-04  Simon Fraser  <simon.fraser@apple.com>
1370
1371         Minor DisplayRefreshMonitor-related cleanup
1372         https://bugs.webkit.org/show_bug.cgi?id=179802
1373
1374         Reviewed by Sam Weinig.
1375
1376         New trace point for when the CVDisplayLink fires on its own thread.
1377
1378         * Tracing/SystemTracePoints.plist:
1379
1380 2017-12-04  David Quesada  <david_quesada@apple.com>
1381
1382         Add a class for parsing application manifests
1383         https://bugs.webkit.org/show_bug.cgi?id=177973
1384         rdar://problem/34747949
1385
1386         Reviewed by Geoffrey Garen.
1387
1388         Add basic unit tests for ApplicationManifestParser. For each of the implemented top-level properties,
1389         attempt to parse manifests with varying types of valid and invalid data to ensure the resulting
1390         ApplicationManifest is configured with the appropriate values per the spec.
1391
1392         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Add ENABLE_APPLICATION_MANIFEST feature flag.
1393         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1394         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp: Added.
1395         (ApplicationManifestParserTest::SetUp):
1396         (ApplicationManifestParserTest::parseString):
1397         (ApplicationManifestParserTest::parseTopLevelProperty):
1398         (ApplicationManifestParserTest::testStartURL):
1399         (ApplicationManifestParserTest::testName):
1400         (ApplicationManifestParserTest::testDescription):
1401         (ApplicationManifestParserTest::testShortName):
1402         (ApplicationManifestParserTest::testScope):
1403         (assertManifestHasDefaultValues):
1404         (TEST_F):
1405
1406 2017-12-04  Aakash Jain  <aakash_jain@apple.com>
1407
1408         Add docstring in EarlyWarningSystemTask to explain return values
1409         https://bugs.webkit.org/show_bug.cgi?id=180303
1410
1411         Reviewed by Daniel Bates.
1412
1413         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
1414         (EarlyWarningSystemTask.run): Added docstring to explain return values.
1415         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1416         (AbstractEarlyWarningSystem.review_patch): Added comment to explain the result of unlocking a patch.
1417
1418 2017-12-04  JF Bastien  <jfbastien@apple.com>
1419
1420         Update std::expected to match libc++ coding style
1421         https://bugs.webkit.org/show_bug.cgi?id=180264
1422
1423         Reviewed by Alex Christensen.
1424
1425         Update tests according to name changes as well as removal of
1426         now-gone APIs.
1427
1428         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1429         (std::experimental::fundamentals_v3::operator<<):
1430         (TestWebKitAPI::TEST):
1431         (WTF::operator<<): Deleted.
1432         * TestWebKitAPI/Tests/WebCore/HTMLParserIdioms.cpp:
1433         (TestWebKitAPI::testParseHTMLInteger):
1434         (TestWebKitAPI::testParseHTMLNonNegativeInteger):
1435
1436 2017-12-04  Ross Kirsling  <ross.kirsling@sony.com>
1437
1438         download-latest-github-release.py should use existing release ANY time latest is not found
1439         https://bugs.webkit.org/show_bug.cgi?id=180293
1440
1441         Reviewed by Per Arne Vollan.
1442
1443         * Scripts/download-latest-github-release.py:
1444         (find_latest_release):
1445         Handle all URLErrors, not just HTTPErrors. Stop special-casing 404s.
1446
1447         (main):
1448         Rearrange logic so any failure to detect a latest release falls back to an existing release. Improve logging.
1449
1450         (Status):
1451         (download_release):
1452         (load_version_info): Renamed from existing_version info.
1453         (has_latest_release): Deleted.
1454         Cleanup.
1455
1456 2017-12-04  Joseph Pecoraro  <pecoraro@apple.com>
1457
1458         Exclude some more leak callstacks
1459         https://bugs.webkit.org/show_bug.cgi?id=180379
1460
1461         Reviewed by Alexey Proskuryakov.
1462
1463         * Scripts/webkitpy/port/leakdetector.py:
1464         (LeakDetector._types_to_exclude_from_leaks):
1465         (LeakDetector._callstacks_to_exclude_from_leaks):
1466         (LeakDetector._leaks_args):
1467         (LeakDetector._types_to_exlude_from_leaks): Deleted.
1468         * Scripts/webkitpy/port/leakdetector_unittest.py:
1469         (LeakDetectorTest.test_leaks_args):
1470
1471 2017-12-03  Yusuke Suzuki  <utatane.tea@gmail.com>
1472
1473         WTF shouldn't have both Thread and ThreadIdentifier
1474         https://bugs.webkit.org/show_bug.cgi?id=180308
1475
1476         Reviewed by Darin Adler.
1477
1478         * DumpRenderTree/mac/DumpRenderTree.mm:
1479         (dumpRenderTree):
1480         (runThread): Deleted.
1481         (runPthread): Deleted.
1482         (testThreadIdentifierMap): Deleted.
1483         * TestWebKitAPI/CMakeLists.txt:
1484         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1485         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1486         * TestWebKitAPI/Tests/WTF/Threading.cpp: Added.
1487         (TestWebKitAPI::TEST):
1488
1489 2017-12-03  Aakash Jain  <aakash_jain@apple.com>
1490
1491         webkitpy EWS keeps retrying a failing patch
1492         https://bugs.webkit.org/show_bug.cgi?id=180302
1493
1494         Reviewed by Alexey Proskuryakov.
1495
1496         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1497         (PatchAnalysisTask._test_patch): Instead of returning false, call report_failure() 
1498         which raises an exception, this exception is catched by earlywarningsystem.py and
1499         it posts a comment on bugzilla. Returning false simply unlocks the patch and returns
1500         it to the queue.
1501
1502 2017-12-03  Darin Adler  <darin@apple.com>
1503
1504         Add WTF::Hasher, an easier to use replacement for WTF::IntegerHasher
1505         https://bugs.webkit.org/show_bug.cgi?id=180318
1506
1507         Reviewed by JF Bastien.
1508
1509         * TestWebKitAPI/CMakeLists.txt: Added Hasher.cpp.
1510         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
1511
1512         * TestWebKitAPI/Tests/WTF/Hasher.cpp: Added. Contains tests of the new
1513         WTF::Hasher class.
1514
1515         * TestWebKitAPI/Tests/WTF/StringHasher.cpp: Include StringHasher.h instead of
1516         Hasher.h.
1517
1518 2017-12-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1519
1520         WebDriver: auto-install pytest instead of importing it from wpt tools directory
1521         https://bugs.webkit.org/show_bug.cgi?id=180243
1522
1523         Reviewed by Brian Burg.
1524
1525         We don't really need the (old) version included in wpt tools dir, so we can simply remove it and use autoinstall
1526         instead.
1527
1528         * Scripts/webkitpy/thirdparty/__init__.py:
1529         (AutoinstallImportHook.find_module): Check pytest.
1530         (AutoinstallImportHook._install_pytest): Install pytest.
1531         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py: Import autoinstalled pytest.
1532         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
1533         (WebDriverTestRunnerW3C.run): Update the subtest path since the new pytest uses a different strategy for
1534         rootdir.
1535         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py: Import autoinstalled pytest.
1536
1537 2017-12-01  Dewei Zhu  <dewei_zhu@apple.com>
1538
1539         Hardcoded python path is not compatible with virtual environment.
1540         https://bugs.webkit.org/show_bug.cgi?id=180300
1541
1542         Reviewed by Stephanie Lewis.
1543
1544         Hardcoding '/usr/bin/python' does not work with python virtual environment.
1545         Use 'python' instead.
1546
1547         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
1548         (SimpleHTTPServerDriver.serve):
1549
1550 2017-12-01  Aakash Jain  <aakash_jain@apple.com>
1551
1552         [build.webkit.org] Move python code to load config from master.cfg in separate file
1553         https://bugs.webkit.org/show_bug.cgi?id=180278
1554
1555         Reviewed by Daniel Bates.
1556
1557         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Moved appropriate code to loadConfig.py
1558         * BuildSlaveSupport/build.webkit.org-config/loadConfig.py: Ditto.
1559         * BuildSlaveSupport/build.webkit.org-config/steps.py: Removed extra import.
1560
1561 2017-12-01  Brian Burg  <bburg@apple.com>
1562
1563         Web Inspector: move Inspector::Protocol::Array<T> to JSON namespace
1564         https://bugs.webkit.org/show_bug.cgi?id=173662
1565
1566         Reviewed by Joseph Pecoraro.
1567
1568         Add duplicate test cases for JSON::ArrayOf<T> based on JSON::Array.
1569
1570         * TestWebKitAPI/Tests/WTF/JSONValue.cpp:
1571         (TestWebKitAPI::TEST):
1572
1573 2017-12-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1574
1575         [Attachment Support] Implement SPI for clients to update a given attachment's data
1576         https://bugs.webkit.org/show_bug.cgi?id=180184
1577         <rdar://problem/35355731>
1578
1579         Reviewed by Tim Horton.
1580
1581         Adds two new API tests to exercise the attachment data update flow.
1582
1583         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1584         (TestWebKitAPI::ObserveAttachmentUpdatesForScope::ObserveAttachmentUpdatesForScope):
1585         (-[_WKAttachment synchronouslySetDisplayOptions:error:]):
1586         (-[_WKAttachment synchronouslyRequestData:]):
1587         (-[_WKAttachment synchronouslySetData:newContentType:newFilename:error:]):
1588         (TestWebKitAPI::TEST):
1589
1590 2017-12-01  Alicia Boya García  <aboya@igalia.com>
1591
1592         [GTK] Add SampleMap.cpp API tests to CMake
1593         https://bugs.webkit.org/show_bug.cgi?id=180252
1594
1595         Reviewed by Žan Doberšek.
1596
1597         * TestWebKitAPI/PlatformGTK.cmake:
1598
1599 2017-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1600
1601         WebDriver: add support for importing and running selenium tests
1602         https://bugs.webkit.org/show_bug.cgi?id=180145
1603
1604         Reviewed by Brian Burg.
1605
1606         We currently import and run W3C tests, which are the best ones to ensure our implementation is spec
1607         compliant. However, the selenium API is what user will actually use in the end, so it's important to ensure that
1608         we don't break the selenium support. This patch adds webdriver_test_runner_selenium.py and
1609         webdriver_selenium_executor.py to run selenium tests. The script import-w3c-webdriver-tests has been renamed as
1610         import-webdriver-tests and it can now import selenium tests too.
1611
1612         * Scripts/import-w3c-webdriver-tests: Removed.
1613         * Scripts/import-webdriver-tests: Added.
1614         (Importer):
1615         (Importer.__init__):
1616         (Importer.download_tests):
1617         (Importer.import_tests):
1618         (Importer.import_tests.should_skip_file):
1619         * Scripts/webkitpy/webdriver_tests/webdriver_driver.py:
1620         (WebDriver.browser_path):
1621         (WebDriver):
1622         (WebDriver.browser_args):
1623         (WebDriver.selenium_name):
1624         * Scripts/webkitpy/webdriver_tests/webdriver_driver_gtk.py:
1625         (WebDriverGtk.browser_path):
1626         (WebDriverGtk):
1627         (WebDriverGtk.browser_args):
1628         (WebDriverGtk.capabilities):
1629         (WebDriverGtk.selenium_name):
1630         * Scripts/webkitpy/webdriver_tests/webdriver_driver_wpe.py:
1631         (WebDriverWPE.browser_args):
1632         (WebDriverWPE.capabilities):
1633         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py: Added.
1634         (_ensure_directory_in_path):
1635         (CollectRecorder):
1636         (CollectRecorder.__init__):
1637         (CollectRecorder.pytest_collectreport):
1638         (WebDriverSeleniumExecutor):
1639         (WebDriverSeleniumExecutor.__init__):
1640         (WebDriverSeleniumExecutor.collect):
1641         (WebDriverSeleniumExecutor.run):
1642         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
1643         (WebDriverTestRunner):
1644         (WebDriverTestRunner.__init__):
1645         (WebDriverTestRunner.run):
1646         (WebDriverTestRunner.print_results):
1647         (WebDriverTestRunner.dump_results_to_json_file):
1648         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py: Added.
1649         (WebDriverTestRunnerSelenium):
1650         (WebDriverTestRunnerSelenium.__init__):
1651         (WebDriverTestRunnerSelenium._tests_dir):
1652         (WebDriverTestRunnerSelenium.collect_tests):
1653         (WebDriverTestRunnerSelenium.run):
1654         (WebDriverTestRunnerSelenium.results):
1655         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
1656         (WebDriverTestRunnerW3C.__init__):
1657         (WebDriverTestRunnerW3C.run):
1658         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
1659
1660 2017-11-30  Alex Christensen  <achristensen@webkit.org>
1661
1662         REGRESSION (r224791): cookies are shared between ephemeral sessions in the same process pool
1663         https://bugs.webkit.org/show_bug.cgi?id=180235
1664
1665         Reviewed by Joseph Pecoraro.
1666
1667         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1668         * TestWebKitAPI/Tests/WebKitCocoa/CookiePrivateBrowsing.mm: Added.
1669         (-[CookiePrivateBrowsingDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1670         (TEST):
1671
1672 2017-11-30  Stephan Szabo  <stephan.szabo@sony.com>
1673
1674         Make LegacyCustomProtocolManager optional for network process
1675         https://bugs.webkit.org/show_bug.cgi?id=176230
1676
1677         Reviewed by Alex Christensen.
1678
1679         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1680
1681 2017-11-30  Dewei Zhu  <dewei_zhu@apple.com>
1682
1683         HTTP server driver is responsible for ensuring the dependencies of HTTP server.
1684         https://bugs.webkit.org/show_bug.cgi?id=180231
1685
1686         Reviewed by Stephanie Lewis.
1687
1688         Added the logic to ensure system environment meet the requirments of launching the http server.
1689
1690         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
1691         (SimpleHTTPServerDriver.serve):
1692         (SimpleHTTPServerDriver.set_device_id):
1693         (SimpleHTTPServerDriver):
1694         (SimpleHTTPServerDriver._ensure_http_server_dependencies):
1695
1696 2017-11-30  Basuke Suzuki  <Basuke.Suzuki@sony.com>
1697
1698         [WinCairo] Cannot build without Internet connection
1699         https://bugs.webkit.org/show_bug.cgi?id=180068
1700
1701         Reviewed by Alex Christensen
1702
1703         With no Internet connection, if libraries has been downloaded
1704         before, trust that version and keep building.
1705
1706         * Scripts/download-latest-github-release.py:
1707         (Status):
1708         (current_release):
1709         (has_latest_release):
1710         (main):
1711
1712 2017-11-30  Alex Christensen  <achristensen@webkit.org>
1713
1714         WKURLSchemeHandler.request should include HTTPBody
1715         https://bugs.webkit.org/show_bug.cgi?id=180220
1716
1717         Reviewed by Brady Eidson.
1718
1719         * TestWebKitAPI/Tests/WebKitCocoa/_WKInputDelegate.mm:
1720         (-[FormSubmissionDelegate webView:startURLSchemeTask:]):
1721
1722 2017-11-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1723
1724         Add a script for automatically running the buildbot configurations on a test environment.
1725         https://bugs.webkit.org/show_bug.cgi?id=169084
1726
1727         Reviewed by Michael Catanzaro.
1728
1729         This new script does the following:
1730         - Creates a temporal workingdir.
1731         - Installs buildbot and its dependencies there (very same version used by the webkit.org buildbot master https://build.webkit.org/about ).
1732           This is important as there are problems that that may not be detected if you don't test with the same version that will be used on production.
1733         - Copies the buildmaster config files to the temporal workingdir.
1734         - Performs the required steps to start a buildmaster.
1735         - Creates the required config for each slave and starts all of them.
1736
1737         The test buildmaster should be accessible at http://localhost:8710/ allowing to trigger manual builds.
1738         This allows to test any configuration changes on this test environment that is pretty much identical to the production one.
1739
1740         * BuildSlaveSupport/build.webkit.org-config/run-buildbot-test.py: Added.
1741         (check_tcp_port_open):
1742         (upgrade_db_needed):
1743         (create_tempdir):
1744         (print_if_error_stdout_stderr):
1745         (setup_master_workdir):
1746         (wait_for_master_ready):
1747         (start_master):
1748         (get_list_workers):
1749         (start_worker):
1750         (clean):
1751         (cmd_exists):
1752         (check_buildbot_installed):
1753         (setup_virtualenv):
1754         (configdir_is_valid):
1755         (main):
1756
1757 2017-11-30  Aakash Jain  <aakash_jain@apple.com>
1758
1759         [build.webkit.org] Move python code from master.cfg in separate files
1760         https://bugs.webkit.org/show_bug.cgi?id=180180
1761
1762         Reviewed by Alexey Proskuryakov.
1763
1764         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Moved code to steps.py and master.cfg appropriately.
1765         * BuildSlaveSupport/build.webkit.org-config/factories.py: Moved all factory related code from master.cfg.
1766         * BuildSlaveSupport/build.webkit.org-config/steps.py: Moved all steps related code from master.cfg
1767
1768 2017-11-30  Wenson Hsieh  <wenson_hsieh@apple.com>
1769
1770         WKAttachmentTests.InPlaceImageAttachmentToggleDisplayMode times out on macOS bots
1771         https://bugs.webkit.org/show_bug.cgi?id=180200
1772
1773         Reviewed by Alexey Proskuryakov.
1774
1775         Rewrites an API test to avoid checking against the hard-coded platform-dependent size of an attachment element.
1776         Instead, first insert the attachment element as an icon and compute its size, and then check that the size of
1777         the element is restored to this original value after toggling the display mode to in-place mode and back.
1778
1779         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1780         (-[TestWKWebView attachmentElementSize]):
1781         (-[TestWKWebView waitForAttachmentElementSizeToBecome:]):
1782         (TestWebKitAPI::TEST):
1783         (platformAttachmentIconElementSize): Deleted.
1784
1785 2017-11-30  Michael Catanzaro  <mcatanzaro@igalia.com>
1786
1787         [WPE] Stop building Wayland in JHBuild moduleset
1788         https://bugs.webkit.org/show_bug.cgi?id=179951
1789
1790         Reviewed by Žan Doberšek.
1791
1792         Since Wayland is not used for running tests, and since it does not seem to depend on
1793         anything in the JHBuild moduleset, I think we can remove it safely without having to worry
1794         that the system version of Wayland might use libraries in the JHBuild environment (which
1795         would be unsafe).
1796
1797         * wpe/install-dependencies: Install Wayland.
1798         * wpe/jhbuild.modules: Stop building Wayland.
1799
1800 2017-11-30  Alexey Proskuryakov  <ap@apple.com>
1801
1802         Silence the BitVector leak for
1803         https://bugs.webkit.org/show_bug.cgi?id=121662
1804
1805         The out of line data pointer isn't stored directly, so the leaks tool cannot see it.
1806
1807         * Scripts/webkitpy/port/leakdetector.py:
1808         (LeakDetector._callstacks_to_exclude_from_leaks):
1809
1810 2017-11-29  Aakash Jain  <aakash_jain@apple.com>
1811
1812         Fix build.webkit.org broken unit-test after r225080
1813         https://bugs.webkit.org/show_bug.cgi?id=180176
1814
1815         Reviewed by Carlos Garcia Campos.
1816
1817         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Updated expected_build_steps.
1818
1819 2017-11-29  Wenson Hsieh  <wenson_hsieh@apple.com>
1820
1821         [Attachment Support] Implement SPI for clients to make an attachment element display in-place
1822         https://bugs.webkit.org/show_bug.cgi?id=180153
1823         <rdar://problem/35735252>
1824
1825         Reviewed by Tim Horton.
1826
1827         Adds new API tests to cover inserting in-place attachments and updating the display mode of existing attachments,
1828         as well as performing a few editing operations (paragraph insertion, cut/paste, list insertion) on attachment
1829         elements.
1830
1831         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1832         (platformAttachmentIconElementSize):
1833         (testVideoData):
1834         (testPDFData):
1835         (displayOptionsWithMode):
1836         (-[TestWKWebView waitForAttachmentElementSizeToBecome:]):
1837         (-[_WKAttachment synchronouslySetDisplayOptions:error:]):
1838         (TestWebKitAPI::TEST):
1839
1840 2017-11-29  Simon Fraser  <simon.fraser@apple.com>
1841
1842         API test fix after r225288.
1843
1844         Make the test work on iOS.
1845
1846         * TestWebKitAPI/Tests/WebKit/NoHistoryItemScrollToFragment.mm:
1847         (-[DidScrollToFragmentScrollViewDelegate scrollViewDidScroll:]):
1848         (TestWebKitAPI::TEST):
1849
1850 2017-11-29  Simon Fraser  <simon.fraser@apple.com>
1851
1852         REGRESSION (r213590): Scrolling to anchors broken in web views when content loaded via HTML string
1853         https://bugs.webkit.org/show_bug.cgi?id=180155
1854         rdar://problem/34220827
1855
1856         Reviewed by Zalan Bujtas.
1857
1858         API test that loads a page with a relative anchor, and simulates a click to scroll to it.
1859
1860         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1861         * TestWebKitAPI/Tests/WebKit/MediaStreamTrackDetached.mm:
1862         (TestWebKitAPI::TEST):
1863         * TestWebKitAPI/Tests/WebKit/NoHistoryItemScrollToFragment.mm: Added.
1864         (-[DidScrollToFragmentDelegate _webViewDidScroll:]):
1865         (TestWebKitAPI::TEST):
1866         * TestWebKitAPI/Tests/WebKit/scroll-to-anchor.html: Added.
1867
1868 2017-11-29  Ryan Haddad  <ryanhaddad@apple.com>
1869
1870         webkitpy EWS should be present on the dashboard.
1871         https://bugs.webkit.org/show_bug.cgi?id=179801
1872
1873         Reviewed by Aakash Jain.
1874
1875         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1876         (BubbleQueueServer): Add Webkitpy EWS.
1877
1878 2017-11-29  Simon Fraser  <simon.fraser@apple.com>
1879
1880         Viewport unit values affected by Comand-+ zoom
1881         https://bugs.webkit.org/show_bug.cgi?id=145614
1882
1883         Reviewed by Zalan Bujtas.
1884         
1885         Fix Command+ and Command- in MiniBrowser to do zooming, rather than being tied
1886         to editing commands.
1887
1888         * MiniBrowser/mac/MainMenu.xib:
1889
1890 2017-11-29  Alex Christensen  <achristensen@webkit.org>
1891
1892         Add test for _WKVisitedLinkStore.addVisitedLinkWithString
1893         https://bugs.webkit.org/show_bug.cgi?id=180152
1894
1895         Reviewed by Chris Dumez.
1896
1897         * TestWebKitAPI/Tests/WebKitCocoa/VisitedLinkStore.mm:
1898         (TestWebKitAPI::TEST):
1899
1900 2017-11-29  Jonathan Bedard  <jbedard@apple.com>
1901
1902         webkitpy: Trying to use iOS versions from machines without iOS SDKs doesn't make sense
1903         https://bugs.webkit.org/show_bug.cgi?id=179534
1904         <rdar://problem/35469509>
1905
1906         Reviewed by Brent Fulgham.
1907
1908         Provide more specific information in builders.py so that machines do not try and calculate
1909         an iOS SDK version while running tests.
1910
1911         * Scripts/webkitpy/port/builders.py: Explicitly specify a version for iOS Simulator.
1912         * Scripts/webkitpy/port/ios_simulator.py:
1913         (IOSSimulatorPort._version_from_name): Attempt to extract the iOS version from the name
1914         of the port.
1915         (IOSSimulatorPort.ios_version): Use specified iOS version if a version is detected in
1916         in the provided name string (just like Mac).
1917
1918 2017-11-29  Robin Morisset  <rmorisset@apple.com>
1919
1920         The recursive tail call optimisation is wrong on closures
1921         https://bugs.webkit.org/show_bug.cgi?id=179835
1922
1923         Reviewed by Saam Barati.
1924
1925         This just includes merge-sort-cps.js to the list of benchmarks ran by run-jsc-benchmarks --tail-bench
1926
1927         * Scripts/run-jsc-benchmarks:
1928
1929 2017-11-28  Carlos Garcia Campos  <cgarcia@igalia.com>
1930
1931         WebDriver: add an option to dump test results to a json file
1932         https://bugs.webkit.org/show_bug.cgi?id=180082
1933
1934         Reviewed by Brian Burg.
1935
1936         Add --json-output command line option to run-webdriver-tests to dump test results to a json file in a format
1937         compatible with the W3C report. WebDriverTestResult now represents a test file and contains a list of
1938         subtests, instead of having one WebDriverTestResult per subtest. This way we can store also the harness result
1939         and dump the results to different formats.
1940
1941         * Scripts/run-webdriver-tests:
1942         * Scripts/webkitpy/webdriver_tests/webdriver_test_result.py:
1943         (WebDriverTestResult.__init__):
1944         (WebDriverTestResult):
1945         (WebDriverTestResult.add_subtest_results):
1946         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
1947         (WebDriverTestRunner.print_results):
1948         (WebDriverTestRunner):
1949         (WebDriverTestRunner.dump_results_to_json_file):
1950         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
1951         (WebDriverTestRunnerW3C.run):
1952
1953 2017-11-28  Alexey Proskuryakov  <ap@apple.com>
1954
1955         Stop silencing leaks in TextCodecICU::registerCodecs, as the problem was fixed a while ago.
1956         https://bugs.webkit.org/show_bug.cgi?id=118505
1957
1958         Reviewed by Joseph Pecoraro.
1959
1960         * Scripts/valgrind/suppressions.txt:
1961         * Scripts/webkitpy/port/leakdetector.py:
1962         (LeakDetector._callstacks_to_exclude_from_leaks):
1963
1964 2017-11-28  Ms2ger  <Ms2ger@igalia.com>
1965
1966         Stop modifying self.expectations in TestExpectationLine.expected_behavior.
1967         https://bugs.webkit.org/show_bug.cgi?id=180074
1968
1969         Reviewed by Simon Fraser.
1970
1971         In particular, getting the property multiple times on a skipped test
1972         expectation line (which happens when using
1973         `Tools/Scripts/run-webkit-tests --print-expectations` if a directory
1974         containing multiple tests is skipped) would yield [pass, skip], then
1975         [pass, skip, skip], then [pass, skip, skip, skip], and so on.
1976
1977         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1978         (TestExpectationLine.expected_behavior): copy self.expectations before modifying it.
1979
1980 2017-11-14  Carlos Garcia Campos  <cgarcia@igalia.com>
1981
1982         Move JSONValues to WTF and convert uses of InspectorValues.h to JSONValues.h
1983         https://bugs.webkit.org/show_bug.cgi?id=173793
1984
1985         Reviewed by Joseph Pecoraro.
1986
1987         * TestWebKitAPI/CMakeLists.txt:
1988         * TestWebKitAPI/PlatformGTK.cmake:
1989         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1990         * TestWebKitAPI/Tests/WTF/JSONValue.cpp: Renamed from Tools/TestWebKitAPI/Tests/JavaScriptCore/InspectorValue.cpp.
1991         (TestWebKitAPI::TEST):
1992
1993 2017-11-28  Ryan Haddad  <ryanhaddad@apple.com>
1994
1995         Bugs filed from the flakiness dashboard should include a link to the dashboard
1996         https://bugs.webkit.org/show_bug.cgi?id=180090
1997
1998         Reviewed by Aakash Jain.
1999
2000         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2001         (createBugHTML):
2002         Open the bug compose page in a new tab and include a link
2003         to the flakiness dashboard results for the selected test.
2004
2005 2017-11-28  Jonathan Bedard  <jbedard@apple.com>
2006
2007         webkitpy: Standardize Version representation
2008         https://bugs.webkit.org/show_bug.cgi?id=179677
2009         <rdar://problem/35711277>
2010
2011         Reviewed by Alex Christensen.
2012
2013         Standardize a single method of representing versions in the Version object
2014         constructor. Provide static methods for converting string and lists/tuples
2015         to Version objects.
2016
2017         * Scripts/webkitpy/common/system/platforminfo.py:
2018         (PlatformInfo.__init__): Parse Version object from string instead of using
2019         the constructor.
2020         (PlatformInfo.xcode_sdk_version): Ditto.
2021         (PlatformInfo.xcode_version): Ditto.
2022         (PlatformInfo._win_version): Construct Version object from list.
2023         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2024         (MockPlatformInfo.xcode_sdk_version):
2025         (MockPlatformInfo.xcode_version):
2026         * Scripts/webkitpy/common/version.py:
2027         (Version):
2028         (Version.from_string): Parse string of the form 'x.x.x'.
2029         (Version.from_iterable): Construct a version object from a list, tuple or
2030         other indexable object.
2031         (Version.__init__): Construct a Version object from integers.
2032         * Scripts/webkitpy/common/version_name_map.py:
2033         (VersionNameMap.__init__): Use integer Version constructor.
2034         (VersionNameMap._automap_to_major_version): Ditto.
2035         (VersionNameMap.to_name):
2036         (VersionNameMap.strip_name_formatting): Construct Version from string.
2037         * Scripts/webkitpy/common/version_name_map_unittest.py:
2038         (VersionMapTestCase.test_mac_version_by_name): Use integer Version constructor.
2039         (VersionMapTestCase.test_mac_name_by_version): Ditto.
2040         (VersionMapTestCase.test_ios_name_by_version): Ditto.
2041         * Scripts/webkitpy/common/version_unittest.py:
2042         (VersionTestCase.test_string_constructor):
2043         (VersionTestCase.test_from_list):
2044         (VersionTestCase.test_from_tuple):
2045         (VersionTestCase.test_int_constructor):
2046         (VersionTestCase.test_len):
2047         (VersionTestCase.test_set_by_int):
2048         (VersionTestCase.test_set_by_string):
2049         (VersionTestCase.test_get_by_int):
2050         (VersionTestCase.test_get_by_string):
2051         (VersionTestCase.test_string):
2052         (VersionTestCase.test_contained_in):
2053         (VersionTestCase.test_compare_versions):
2054         (VersionTestCase.test_list_constructor): Deleted.
2055         (VersionTestCase.test_tuple_constructor): Deleted.
2056         (VersionTestCase.test_copy_constructor): Deleted.
2057         (VersionTestCase.test_none_constructor): Deleted.
2058         * Scripts/webkitpy/port/ios.py:
2059         (IOSPort.default_baseline_search_path): Handle case where ios_version is None.
2060         * Scripts/webkitpy/port/ios_device.py:
2061         (IOSDevicePort.ios_version): Return None rather than an empty version.
2062         * Scripts/webkitpy/port/ios_simulator.py:
2063         (IOSSimulatorPort.simulator_runtime): Parse Version object from string instead
2064         of using the constructor.
2065         (IOSSimulatorPort.ios_version): Return None rather than an empty version.
2066         * Scripts/webkitpy/xcode/simulator.py:
2067         (Simulator._parse_runtimes): Parse Version object from string instead of using
2068         the constructor.
2069         (Simulator._parse_devices): Ditto.
2070         * Scripts/webkitpy/xcode/simulator_unittest.py:
2071
2072 2017-11-28  Daniel Bates  <dabates@apple.com>
2073
2074         [Cocoa] First pass at implementing alternative presentation button element
2075         https://bugs.webkit.org/show_bug.cgi?id=179785
2076         Part of <rdar://problem/34917108>
2077
2078         Reviewed by Brent Fulgham.
2079
2080         Add a test that substitutes the alternative presentation button for an element in
2081         the page and clicks it.
2082
2083         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add test.
2084         * TestWebKitAPI/Tests/WebKitCocoa/ClickAlternativePresentationButton.mm: Added.
2085         (didClickAlternativePresentationButton):
2086         (-[ClickAlternativePresentationButton webProcessPlugIn:didCreateBrowserContextController:]):
2087         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2088         (TEST):
2089         (-[AlternativePresentationButtonDelegate _webView:didClickAlternativePresentationButtonWithUserInfo:]):
2090         (-[AlternativePresentationButtonDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2091
2092 2017-11-28  Carlos Garcia Campos  <cgarcia@igalia.com>
2093
2094         REGRESSION(r225166): [GTK] Skipped unit tests are considered failures after glib upgrade
2095         https://bugs.webkit.org/show_bug.cgi?id=180072
2096
2097         Reviewed by Michael Catanzaro.
2098
2099         This is a bug in GLib that has already been fixed. Backport the patch to fix it until there's a new GLib release
2100         we can depend on.
2101
2102         * gtk/jhbuild.modules:
2103         * gtk/patches/glib-gtester-do-not-consider-skipped-tests-as-failures.patch: Added.
2104
2105 2017-11-28  Fujii Hironori  <Hironori.Fujii@sony.com>
2106
2107         webkitpy: PlatformInfo raises AssertionError "assert self.os_version is not None" in Cygwin since Bug 179621
2108         https://bugs.webkit.org/show_bug.cgi?id=180069
2109
2110         Reviewed by Daniel Bates.
2111
2112         "Version 10.0.16299" was interpreted as 0.0.16299. Fix the wrong
2113         regexp for 'ver' command.
2114
2115         * Scripts/webkitpy/common/system/platforminfo.py:
2116         (PlatformInfo._win_version_from_cmd): Replace \d with \d+.
2117
2118 2017-11-28  Carlos Garcia Campos  <cgarcia@igalia.com>
2119
2120         [GTK] WebDriver: disable XSS auditor when running WebDriver tests
2121         https://bugs.webkit.org/show_bug.cgi?id=180075
2122
2123         Reviewed by Carlos Alberto Lopez Perez.
2124
2125         Some tests are now doing inline('<script>window.alert()</script>') which is rejected by the XSS auditor because
2126         the script source is part of the request URL.
2127
2128         * Scripts/webkitpy/webdriver_tests/webdriver_driver_gtk.py:
2129         (WebDriverGtk.capabilities): Disable XSS auditor.
2130
2131 2017-11-28  Carlos Garcia Campos  <cgarcia@igalia.com>
2132
2133         WebDriver: add timeout option to run-webdriver-tests script
2134         https://bugs.webkit.org/show_bug.cgi?id=179940
2135
2136         Reviewed by Carlos Alberto Lopez Perez.
2137
2138         We need to handle timeouts to be able to run the tests in the bots. pytest doesn't support timeouts, but there's
2139         a plugin pytest_timeout that can be used for that.
2140
2141         * Scripts/run-webdriver-tests: Add --timeout command line option.
2142         * Scripts/webkitpy/thirdparty/__init__.py:
2143         (AutoinstallImportHook.find_module): Check if pytest_timeout is imported to install it.
2144         (AutoinstallImportHook._install_pytest_timeout): Install pytest_timeout from pypi.
2145         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
2146         (WebDriverTestRunnerW3C.__init__): Set PYTEST_TIMEOUT env var with the timeout given.
2147         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
2148         (WebDriverW3CExecutor.run): Clarify that the timeout received by do_wdspec() is ignored, and pass 0 instead of 25.
2149
2150 2017-11-27  Aakash Jain  <aakash_jain@apple.com>
2151
2152         Do not run webkitpy tests on multiple EWSes
2153         https://bugs.webkit.org/show_bug.cgi?id=179834
2154
2155         Reviewed by Alexey Proskuryakov.
2156
2157         Do not run webkitpy tests in every EWS. We now have
2158         a dedicated webkitpy test EWS.
2159
2160         * Scripts/webkitpy/tool/steps/runtests.py:
2161         (RunTests.run): Do not run webkitpy tests in EWSes. These tests will still run
2162         when --non-interactive option is not passed. 
2163
2164 2017-11-27  Jonathan Bedard  <jbedard@apple.com>
2165
2166         webkitpy: Better name-version mapping (Part 1)
2167         https://bugs.webkit.org/show_bug.cgi?id=179621
2168         <rdar://problem/35589585>
2169
2170         Reviewed by David Kilzer.
2171
2172         Mapping version numbers to version names should occur in a central location.
2173         This has a few advantages. First, it makes iterating through versions easier.
2174         Second, it allows for apple_additions to define an additional set of name
2175         mappings. Lastly, it will allow, in a future patch, for us to track version
2176         instead of version name, only mapping version to version name when required.
2177
2178         * Scripts/webkitpy/common/system/platforminfo.py:
2179         (PlatformInfo.__init__):
2180         (PlatformInfo._determine_os_name): Use VersionNameMap instead of custom functions
2181         mapping version to name.
2182         (PlatformInfo._determine_linux_version): Deleted.
2183         (PlatformInfo._determine_mac_version): Deleted.
2184         (PlatformInfo._determine_win_version): Deleted.
2185         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
2186         (TestPlatformInfo.test_os_name_and_wrappers):
2187         (TestPlatformInfo.test_os_version):
2188         (TestPlatformInfo.test_display_name):
2189         (TestPlatformInfo.test_total_bytes_memory):
2190         * Scripts/webkitpy/common/version.py:
2191         (Version.contained_in): Add partial version mapping.
2192         * Scripts/webkitpy/common/version_name_map.py: Added.
2193         (VersionNameMap): Holds a mapping of version name to version object.
2194         (VersionNameMap.map): Don't re-create VersionNameMap every time.
2195         (VersionNameMap.__init__): Initialize mapping, use platform to
2196         define the default system platform.
2197         (VersionNameMap._automap_to_major_version): Some operating systems, such
2198         as iOS, have a naming scheme based on their major version and os name.
2199         Automatically generate such mappings.
2200         (VersionNameMap.to_name): Given a version object, platform name and
2201         table, find the closest matching version name.
2202         (VersionNameMap.strip_name_formatting): Remove spaces and extract the major version,
2203         if a version string is included in the name.
2204         (VersionNameMap.from_name): Return an os name and version given a version name.
2205         * Scripts/webkitpy/common/version_name_map_unittest.py: Added.
2206         (VersionMapTestCase):
2207         (VersionMapTestCase.test_default_system_platform):
2208         (VersionMapTestCase.test_mac_version_by_name):
2209         (VersionMapTestCase.test_ios_version_by_name):
2210         (VersionMapTestCase.test_mac_name_by_version):
2211         (VersionMapTestCase.test_ios_name_by_version):
2212         * Scripts/webkitpy/common/version_unittest.py:
2213         (VersionTestCase.test_contained_in):
2214         * Scripts/webkitpy/port/ios_device.py:
2215         (IOSDevicePort.ios_version): Map os_version name to version number.
2216
2217 2017-11-27  Don Olmstead  <don.olmstead@sony.com>
2218
2219         [CMake][Win] Conditionally select DLL CRT or static CRT
2220         https://bugs.webkit.org/show_bug.cgi?id=170594
2221
2222         Reviewed by Alex Christensen.
2223
2224         * DumpRenderTree/PlatformWin.cmake:
2225         * MiniBrowser/win/CMakeLists.txt:
2226
2227 2017-11-27  Yacine Bandou  <yacine.bandou_ext@softathome.com>
2228
2229         [GTK][WPE] Add "enable-encrypted-media" property to WebKitWebSettings
2230         https://bugs.webkit.org/show_bug.cgi?id=18005
2231
2232         Reviewed by Michael Catanzaro.
2233
2234         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2235         (testWebKitSettings):
2236
2237 2017-11-27  Tim Horton  <timothy_horton@apple.com>
2238
2239         One too many zeroes in macOS version number in FeatureDefines
2240         https://bugs.webkit.org/show_bug.cgi?id=180011
2241
2242         Reviewed by Dan Bernstein.
2243
2244         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2245
2246 2017-11-27  Per Arne Vollan  <pvollan@apple.com>
2247
2248         [Win] The number of webkit-patch iterations on EWS should be configurable.
2249         https://bugs.webkit.org/show_bug.cgi?id=178517
2250
2251         Reviewed by Darin Adler.
2252
2253         Add a new RESET_AFTER_ITERATION argument to the EWS shell script.
2254
2255         * EWSTools/start-queue-win.sh:
2256
2257 2017-11-27  Per Arne Vollan  <pvollan@apple.com>
2258
2259         [Win] Switch to VS2017 on EWS bots.
2260         https://bugs.webkit.org/show_bug.cgi?id=178516
2261
2262         Reviewed by Darin Adler.
2263
2264         * EWSTools/start-queue-win.sh:
2265
2266 2017-11-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2267
2268         [SOUP] Layout test media/track/track-text-track-cue-list.html crash with g_source_set_ready_time: assertion 'source->ref_count > 0' failed
2269         https://bugs.webkit.org/show_bug.cgi?id=176806
2270
2271         Reviewed by Carlos Alberto Lopez Perez.
2272
2273         This was caused by a GLib bug that has already been fixed. Upgrade glib to 2.54.2.
2274
2275         * gtk/jhbuild.modules:
2276         * gtk/patches/gdate-suppress-string-format-literal-warning.patch: Removed.
2277
2278 2017-11-24  Darin Adler  <darin@apple.com>
2279
2280         * TestWebKitAPI/Tests/WTF/OptionSet.cpp:
2281         (TestWebKitAPI::TEST): Added a test for OptionSet operator|.
2282
2283 2017-11-24  Mark Lam  <mark.lam@apple.com>
2284
2285         Move unsafe jsc shell test functions to the $vm object.
2286         https://bugs.webkit.org/show_bug.cgi?id=179980
2287
2288         Reviewed by Yusuke Suzuki.
2289
2290         Always set --useDollarVM=true for jsc runs of benchmarks.  This is needed because
2291         some microbenchmarks relies on createBuiltin().
2292
2293         Also set --useDollarVM=true for runExceptionFuzz and runExecutableAllocationFuzz.
2294
2295         * Scripts/run-jsc-benchmarks:
2296         * Scripts/run-jsc-stress-tests:
2297
2298 2017-11-23  Darin Adler  <darin@apple.com>
2299
2300         Reduce WTF::String operations that do unnecessary Unicode operations instead of ASCII
2301         https://bugs.webkit.org/show_bug.cgi?id=179907
2302
2303         Reviewed by Sam Weinig.
2304
2305         * DumpRenderTree/mac/DumpRenderTree.mm:
2306         (changeWindowScaleIfNeeded): Use containsIgnoringASCIICase.
2307         * WebKitTestRunner/TestInvocation.cpp:
2308         (WTR::TestInvocation::urlContains const): Ditto.
2309
2310 2017-11-22  Ali Juma  <ajuma@chromium.org>
2311
2312         Implement VisualViewport API attributes
2313         https://bugs.webkit.org/show_bug.cgi?id=179385
2314
2315         Reviewed by Frédéric Wang.
2316
2317         Enable the VisualViewportAPI in layout tests.
2318
2319         * DumpRenderTree/mac/DumpRenderTree.mm:
2320         (enableExperimentalFeatures):
2321         * DumpRenderTree/win/DumpRenderTree.cpp:
2322         (enableExperimentalFeatures):
2323
2324 2017-11-22  Tim Horton <timothy_horton@apple.com> and Michael Catanzaro <mcatanzaro@igalia.com>
2325
2326         Remove build-webkit's notion of feature flags having a default value
2327         https://bugs.webkit.org/show_bug.cgi?id=177338
2328
2329         Reviewed by Carlos Alberto Lopez Perez.
2330
2331         Delegate feature flag default values to the build system.
2332         (FeatureDefines.xcconfig for Xcode, WebKitFeatures.cmake and Options*.cmake for CMake, and FeatureDefines.h for everyone)
2333
2334         * BuildSlaveSupport/build.webkit.org-config/config.json:
2335         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2336         (Factory.__init__):
2337         Update GTK and WPE buildbot configuration to use --no-experimental-features on old stable
2338         bots instead of --default-cmake-features.
2339  
2340         * Scripts/build-webkit:
2341         (cMakeArgsFromFeatures): Deleted.
2342         Default feature values to 'undef'.
2343         Remove the --default-cmake-features argument; it is now the default.
2344         Add --no-experimental-features to replace it.
2345         Stop printing the default feature flag value in the help.
2346         Avoid propagating undefined values to the build system;
2347         only mention flags that are overridden on the command line.
2348
2349         This has the nice side effect of using the default CMake features
2350         for CMake builds, but still allowing toggling of them using the
2351         prettier --FEATURE and --no-FEATURE arguments.
2352
2353         * Scripts/webkitdirs.pm:
2354         (generateBuildSystemFromCMakeProject):
2355         No longer need to suppress CMake warnings about unused arguments.
2356
2357         * Scripts/webkitperl/FeatureList.pm:
2358         Remove the default values from the feature list.
2359
2360 2017-11-22  Mark Lam  <mark.lam@apple.com>
2361
2362         [Re-landing] Pass --useDollarVM=true to all JSC tests.
2363         https://bugs.webkit.org/show_bug.cgi?id=179647
2364
2365         Reviewed by Saam Barati.
2366
2367         * Scripts/run-jsc-stress-tests:
2368
2369 2017-11-22  Commit Queue  <commit-queue@webkit.org>
2370
2371         Unreviewed, rolling out r225093.
2372         https://bugs.webkit.org/show_bug.cgi?id=179938
2373
2374         Compilation failed on WinCairo 64-bit Release (Requested by
2375         fredw on #webkit).
2376
2377         Reverted changeset:
2378
2379         "Implement VisualViewport API attributes"
2380         https://bugs.webkit.org/show_bug.cgi?id=179385
2381         https://trac.webkit.org/changeset/225093
2382
2383 2017-11-21  Ali Juma  <ajuma@chromium.org>
2384
2385         Implement VisualViewport API attributes
2386         https://bugs.webkit.org/show_bug.cgi?id=179385
2387
2388         Reviewed by Frédéric Wang.
2389
2390         Enable the VisualViewportAPI in layout tests.
2391
2392         * DumpRenderTree/mac/DumpRenderTree.mm:
2393         (enableExperimentalFeatures):
2394         * DumpRenderTree/win/DumpRenderTree.cpp:
2395         (enableExperimentalFeatures):
2396
2397 2017-11-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2398
2399         [WPE] Run unit tests in the bots
2400         https://bugs.webkit.org/show_bug.cgi?id=179910
2401
2402         Reviewed by Michael Catanzaro.
2403
2404         Add a step to run unit tests in WPE test bots.
2405
2406         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2407         (RunGLibAPITests):
2408         (RunGtkAPITests):
2409         (RunWPEAPITests):
2410         (TestFactory.__init__):
2411         (RunGtkAPITests.start): Deleted.
2412         (RunGtkAPITests.commandComplete): Deleted.
2413         (RunGtkAPITests.evaluateCommand): Deleted.
2414         (RunGtkAPITests.getText): Deleted.
2415         (RunGtkAPITests.getText2): Deleted.
2416         * wpe/jhbuild.modules: Upgrade WPEBackend-mesa to fix crashes when running unit tests.
2417
2418 2017-11-21  Tomas Popela  <tpopela@redhat.com>
2419
2420         Fix WebKitGTK+ compilation
2421
2422         Reviewed by Carlos Garcia Campos.
2423
2424         File "/builddir/build/BUILD/webkitgtk-2.19.2/Tools/gtk/generate-gtkdoc", line 31, in <module>
2425         import common
2426         ImportError: No module named common
2427
2428         * gtk/manifest.txt.in:
2429         Add Tools/glib/common.py to the tarball.
2430
2431 2017-11-21  Ms2ger  <Ms2ger@igalia.com>
2432
2433         [GTK] Avoid warning in jhbuildrc.
2434         https://bugs.webkit.org/show_bug.cgi?id=179913
2435
2436         Reviewed by Carlos Garcia Campos.
2437
2438         Apparently this is not quite a real python file; this declaration causes
2439         warnings like
2440           I: unknown keys defined in configuration file: top_level_directory
2441         which break run-webkit-tests.
2442
2443         * gtk/jhbuildrc:
2444
2445 2017-11-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2446
2447         Unreviewed. Fix WPE make distcheck.
2448
2449         * wpe/manifest.txt.in: Add generate-inspector-gresource-manifest.py to the tarball.
2450
2451 2017-11-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2452
2453         Unreviewed. Fix GTK+ make distcheck.
2454
2455         * gtk/manifest.txt.in: Add generate-inspector-gresource-manifest.py to the tarball.
2456
2457 2017-11-20  Michael Catanzaro  <mcatanzaro@igalia.com>
2458
2459         [WPE] Disable ACCELERATED_2D_CANVAS in FeatureList.pm
2460         https://bugs.webkit.org/show_bug.cgi?id=179889
2461
2462         Reviewed by Darin Adler.
2463
2464         * Scripts/webkitperl/FeatureList.pm:
2465
2466 2017-11-20  Michael Catanzaro  <mcatanzaro@igalia.com>
2467
2468         Unreviewed, speculative attempt to fix run-gtk-tests after r225047
2469         https://bugs.webkit.org/show_bug.cgi?id=173772
2470
2471         * jhbuild/jhbuildutils.py:
2472         (enter_jhbuild_environment_if_available):
2473
2474 2017-11-20  Mario Sanchez Prada  <mario@endlessm.com>
2475
2476         [GTK] New API to add, retrieve and delete cookies via WebKitCookieManager
2477         https://bugs.webkit.org/show_bug.cgi?id=177932
2478
2479         Reviewed by Carlos Garcia Campos.
2480
2481         Added new test cases to cover the newly added API for WebKitCookieManager:
2482         webkit_cookie_manager_add_cookie, webkit_cookie_manager_get_cookies and
2483         webkit_cookie_manager_delete_cookie.
2484
2485         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
2486         (testCookieManagerAddCookie): Added.
2487         (testCookieManagerGetCookies): Added.
2488         (testCookieManagerDeleteCookie): Added.
2489         (serverCallback): Small update to avoid hardcoding strings we reuse.
2490         (beforeAll): Added the new test cases to the test suite.
2491
2492 2017-11-20  Stephan Szabo  <stephan.szabo@sony.com>
2493
2494         [Win] Update ruby JSC test writer for gigacage changes
2495         https://bugs.webkit.org/show_bug.cgi?id=178757
2496
2497         Reviewed by Keith Miller.
2498
2499         * Scripts/webkitruby/jsc-stress-test-writer-ruby.rb:
2500         Add additionalEnv to ruby test writer Plan
2501
2502 2017-11-20  Michael Catanzaro  <mcatanzaro@igalia.com>
2503
2504         Remove ENABLE_ALLINONE_BUILD option
2505         https://bugs.webkit.org/show_bug.cgi?id=179823
2506
2507         Reviewed by Darin Adler.
2508
2509         * Scripts/webkitperl/FeatureList.pm:
2510
2511 2017-11-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2512
2513         Unreviewed. Fix WPE build after r225047.
2514
2515         Remove changes from an old patch committed by mistake in r225047.
2516
2517         * WebKitTestRunner/PlatformWebView.h:
2518         * WebKitTestRunner/wpe/PlatformWebViewWPE.cpp:
2519         (WTR::PlatformWebView::windowSnapshotImage):
2520
2521 2017-11-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2522
2523         [WPE] Add run-wpe-tests script to run WPE glib API tests
2524         https://bugs.webkit.org/show_bug.cgi?id=173772
2525
2526         Reviewed by Michael Catanzaro.
2527
2528         Move common code from run-gtk-tests to api_test_runner.py, to be shared by both run-gtk-tests and un-wpe-tests.
2529
2530         * Scripts/run-gtk-tests:
2531         (GtkTestRunner):
2532         (GtkTestRunner.__init__):
2533         (GtkTestRunner._start_accessibility_daemons):
2534         (GtkTestRunner._setup_testing_environment):
2535         (GtkTestRunner._tear_down_testing_environment):
2536         (GtkTestRunner.is_glib_test):
2537         (GtkTestRunner.is_google_test):
2538         * Scripts/run-wpe-tests: Added.
2539         (WPETestRunner):
2540         (WPETestRunner.__init__):
2541         (WPETestRunner.is_glib_test):
2542         (WPETestRunner.is_google_test):
2543         * Scripts/webkitpy/port/headlessdriver.py: Added.
2544         (HeadlessDriver):
2545         (HeadlessDriver._setup_environ_for_test):
2546         (HeadlessDriver._start):
2547         * Scripts/webkitpy/port/headlessdriver_unittest.py: Added.
2548         (HeadlessDriverTest):
2549         (HeadlessDriverTest.make_driver):
2550         (HeadlessDriverTest.make_environment):
2551         (HeadlessDriverTest.test_environment_needed_variables):
2552         (HeadlessDriverTest.test_environment_forbidden_variables):
2553         * Scripts/webkitpy/port/wpe.py:
2554         (WPEPort._driver_class):
2555         * WebKitTestRunner/PlatformWebView.h:
2556         * WebKitTestRunner/wpe/PlatformWebViewWPE.cpp:
2557         (WTR::PlatformWebView::windowSnapshotImage):
2558         * glib/api_test_runner.py: Copied from Tools/Scripts/run-gtk-tests.
2559         (SkippedTest):
2560         (SkippedTest.__init__):
2561         (SkippedTest.__str__):
2562         (SkippedTest.skip_entire_suite):
2563         (SkippedTest.skip_for_build_type):
2564         (TestTimeout):
2565         (TestRunner):
2566         (TestRunner.__init__):
2567         (TestRunner._test_programs_base_dir):
2568         (TestRunner._get_tests_from_dir):
2569         (TestRunner._get_tests):
2570         (TestRunner._create_driver):
2571         (TestRunner._setup_testing_environment):
2572         (TestRunner._tear_down_testing_environment):
2573         (TestRunner._test_cases_to_skip):
2574         (TestRunner._should_run_test_program):
2575         (TestRunner._kill_process):
2576         (TestRunner._start_timeout):
2577         (TestRunner._start_timeout._alarm_handler):
2578         (TestRunner._stop_timeout):
2579         (TestRunner._waitpid):
2580         (TestRunner._run_test_glib):
2581         (TestRunner._run_test_glib.parse_line):
2582         (TestRunner._run_test_glib.parse_line.set_test_result):
2583         (TestRunner._get_tests_from_google_test_suite):
2584         (TestRunner._run_google_test):
2585         (TestRunner._run_google_test_suite):
2586         (TestRunner.is_glib_test):
2587         (TestRunner.is_google_test):
2588         (TestRunner._run_test):
2589         (TestRunner.run_tests):
2590         (add_options):
2591         * glib/common.py: Renamed from Tools/gtk/common.py.
2592         (get_build_path.is_valid_build_directory):
2593         * gtk/generate-gtkdoc:
2594         * gtk/jhbuildrc:
2595         * gtk/ycm_extra_conf.py:
2596
2597 2017-11-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2598
2599         [WPE] Build C API tests
2600         https://bugs.webkit.org/show_bug.cgi?id=179817
2601
2602         Reviewed by Michael Catanzaro.
2603
2604         * TestWebKitAPI/CMakeLists.txt:
2605         * TestWebKitAPI/PlatformGTK.cmake:
2606         * TestWebKitAPI/PlatformWPE.cmake:
2607         * TestWebKitAPI/PlatformWebView.h:
2608         * TestWebKitAPI/wpe/PlatformUtilitiesWPE.cpp:
2609         (TestWebKitAPI::Util::URLForNonExistentResource):
2610         (TestWebKitAPI::Util::isKeyDown):
2611         * TestWebKitAPI/wpe/PlatformWebViewWPE.cpp: Added.
2612         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2613         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
2614         (TestWebKitAPI::PlatformWebView::initialize):
2615         (TestWebKitAPI::PlatformWebView::page const):
2616         (TestWebKitAPI::PlatformWebView::resizeTo):
2617         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
2618         (TestWebKitAPI::PlatformWebView::simulateAltKeyPress):
2619         (TestWebKitAPI::PlatformWebView::simulateRightClick):
2620         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
2621
2622 2017-11-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2623
2624         [WPE] Add env var WPE_USE_HEADLESS_VIEW_BACKEND
2625         https://bugs.webkit.org/show_bug.cgi?id=173770
2626
2627         Reviewed by Michael Catanzaro.
2628
2629         Move HeadlessViewBackend implementation to a common place and build it as a private static library to be used by
2630         WTR, GLib API tests and eventually C API tests too. WTR uses the HeadlessViewBackend unconditionally, but GLib
2631         API tests use it only when WPE_USE_HEADLESS_VIEW_BACKEND environment variable is present and not "0".
2632
2633         * CMakeLists.txt: Include wpe/HeadlessViewBackend directory for developer builds.
2634         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
2635         (testAutomationSessionRequestSession):
2636         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
2637         (testCookieManagerEphemeral):
2638         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
2639         (testPrivateBrowsing):
2640         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
2641         (testWebContextProxySettings):
2642         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
2643         (testWebViewWebContext):
2644         (testWebViewEphemeral):
2645         * TestWebKitAPI/glib/PlatformWPE.cmake:
2646         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2647         (Test::createWebViewBackend):
2648         (Test::createWebView):
2649         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
2650         (WebViewTest::initializeWebView):
2651         * WebKitTestRunner/PlatformWPE.cmake:
2652         * wpe/HeadlessViewBackend/CMakeLists.txt: Added.
2653         * wpe/HeadlessViewBackend/HeadlessViewBackend.cpp: Renamed from Tools/WebKitTestRunner/wpe/HeadlessViewBackend.cpp.
2654         (HeadlessViewBackend::HeadlessViewBackend):
2655         * wpe/HeadlessViewBackend/HeadlessViewBackend.h: Renamed from Tools/WebKitTestRunner/wpe/HeadlessViewBackend.h.
2656
2657 2017-11-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2658
2659         [WPE] webkit_web_view_new() should enable specifying wpe_view_backend object
2660         https://bugs.webkit.org/show_bug.cgi?id=178655
2661
2662         Reviewed by Michael Catanzaro.
2663
2664         Update unit tests to create web views using helper methods that have a different implementation for GTK and
2665         WPE. Also add a new test case to check the new API to create a WebKitWebView with a WPE backend. Use
2666         WKViewCreate in WTR and fix a memory leak in HeadlessViewBackend.
2667
2668         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
2669         (testAutomationSessionRequestSession):
2670         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp:
2671         (testWebKitWebViewSessionState):
2672         (testWebKitWebViewSessionStateWithFormData):
2673         (testWebKitWebViewNavigationAfterSessionRestore):
2674         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
2675         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
2676         (testWebResourceGetDataError):
2677         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2678         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
2679         (testWebViewNewWithUserContentManager):
2680         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
2681         (testWebContextEphemeral):
2682         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
2683         (testWebViewWebContext):
2684         (testWebViewWebContextLifetime):
2685         (testWebViewWebBackend):
2686         (testWebViewSettings):
2687         (beforeAll):
2688         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
2689         (testWebsiteDataEphemeral):
2690         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2691         (Test::createWebView):
2692         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp:
2693         (HeadlessViewBackend::~HeadlessViewBackend):
2694         * WebKitTestRunner/wpe/PlatformWebViewWPE.cpp:
2695         (WTR::PlatformWebView::PlatformWebView):
2696
2697 2017-11-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2698
2699         [GTK][WPE] webkit_cookie_manager_delete_all_cookies doesn't delete the cookies if called before a web process is running
2700         https://bugs.webkit.org/show_bug.cgi?id=175265
2701
2702         Reviewed by Michael Catanzaro.
2703
2704         Add test case.
2705
2706         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
2707         (testCookieManagerPersistentStorageDeleteAll):
2708         (serverCallback):
2709         (beforeAll):
2710
2711 2017-11-19  Tim Horton  <timothy_horton@apple.com>
2712
2713         Remove unused TOUCH_ICON_LOADING feature flag
2714         https://bugs.webkit.org/show_bug.cgi?id=179873
2715
2716         Reviewed by Simon Fraser.
2717
2718         * Scripts/webkitperl/FeatureList.pm:
2719         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2720
2721 2017-11-19  Tim Horton  <timothy_horton@apple.com>
2722
2723         Remove unused LEGACY_VENDOR_PREFIXES feature flag
2724         https://bugs.webkit.org/show_bug.cgi?id=179872
2725
2726         Reviewed by Darin Adler.
2727
2728         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2729
2730 2017-11-19  Yusuke Suzuki  <utatane.tea@gmail.com>
2731
2732         Unreviewed, rolling out r225016.
2733
2734         Break webkit-patch on Ubuntu and Debian Linux
2735
2736         Reverted changeset:
2737
2738         "webkitpy: Better name-version mapping (Part 1)"
2739         https://bugs.webkit.org/show_bug.cgi?id=179621
2740         https://trac.webkit.org/changeset/225016
2741
2742 2017-11-18  Jonathan Bedard  <jbedard@apple.com>
2743
2744         webkitpy: Better name-version mapping (Part 1)
2745         https://bugs.webkit.org/show_bug.cgi?id=179621
2746         <rdar://problem/35589585>
2747
2748         Reviewed by David Kilzer.
2749
2750         Mapping version numbers to version names should occur in a central location.
2751         This has a few advantages. First, it makes iterating through versions easier.
2752         Second, it allows for apple_additions to define an additional set of name
2753         mappings. Lastly, it will allow, in a future patch, for us to track version
2754         instead of version name, only mapping version to version name when required.
2755
2756         * Scripts/webkitpy/common/system/platforminfo.py:
2757         (PlatformInfo.__init__):
2758         (PlatformInfo._determine_os_name): Use VersionNameMap instead of custom functions
2759         mapping version to name.
2760         (PlatformInfo._determine_linux_version): Deleted.
2761         (PlatformInfo._determine_mac_version): Deleted.
2762         (PlatformInfo._determine_win_version): Deleted.
2763         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
2764         (TestPlatformInfo.test_os_name_and_wrappers):
2765         (TestPlatformInfo.test_os_version):
2766         (TestPlatformInfo.test_display_name):
2767         (TestPlatformInfo.test_total_bytes_memory):
2768         * Scripts/webkitpy/common/version.py:
2769         (Version.contained_in): Add partial version mapping.
2770         * Scripts/webkitpy/common/version_name_map.py: Added.
2771         (VersionNameMap): Holds a mapping of version name to version object.
2772         (VersionNameMap.map): Don't re-create VersionNameMap every time.
2773         (VersionNameMap.__init__): Initialize mapping, use platform to
2774         define the default system platform.
2775         (VersionNameMap._automap_to_major_version): Some operating systems, such
2776         as iOS, have a naming scheme based on their major version and os name.
2777         Automatically generate such mappings.
2778         (VersionNameMap.to_name): Given a version object, platform name and
2779         table, find the closest matching version name.
2780         (VersionNameMap.strip_name_formatting): Remove spaces and extract the major version,
2781         if a version string is included in the name.
2782         (VersionNameMap.from_name): Return an os name and version given a version name.
2783         * Scripts/webkitpy/common/version_name_map_unittest.py: Added.
2784         (VersionMapTestCase):
2785         (VersionMapTestCase.test_default_system_platform):
2786         (VersionMapTestCase.test_mac_version_by_name):
2787         (VersionMapTestCase.test_ios_version_by_name):
2788         (VersionMapTestCase.test_mac_name_by_version):
2789         (VersionMapTestCase.test_ios_name_by_version):
2790         * Scripts/webkitpy/common/version_unittest.py:
2791         (VersionTestCase.test_contained_in):
2792
2793 2017-11-17  John Wilander  <wilander@apple.com>
2794
2795         Storage Access API: UI process should update network process about granted access
2796         https://bugs.webkit.org/show_bug.cgi?id=176943
2797         <rdar://problem/34440612>
2798
2799         Reviewed by Alex Christensen.
2800
2801         This adds the TestRunner function setStatisticsHasHadNonRecentUserInteraction()
2802         which enables testing of prevalent resources with user interaction outside the
2803         24 hour window.
2804
2805         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2806         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2807         (WTR::TestRunner::setStorageAccessAPIEnabled):
2808         (WTR::TestRunner::setStatisticsHasHadNonRecentUserInteraction):
2809         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2810         * WebKitTestRunner/TestController.cpp:
2811         (WTR::TestController::setStatisticsHasHadNonRecentUserInteraction):
2812         * WebKitTestRunner/TestController.h:
2813         * WebKitTestRunner/TestInvocation.cpp:
2814         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2815         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2816         (WTR::initializeWebViewConfiguration):
2817         (WTR::TestController::setStatisticsHasHadNonRecentUserInteraction):
2818
2819 2017-11-17  Ryan Haddad  <ryanhaddad@apple.com>
2820
2821         Disable failing API tests for rdar://problem/35344202.
2822
2823         Unreviewed test gardening.
2824
2825         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
2826
2827 2017-11-17  Joanmarie Diggs  <jdiggs@igalia.com>
2828
2829         AX: [ATK] Fix WKTR's methods for testing row header and column header presence and count
2830         https://bugs.webkit.org/show_bug.cgi?id=179837
2831
2832         Reviewed by Chris Fleizach.
2833
2834         Add support to rowHeaders() for tables. Return an empty array in rowHeaders()
2835         and columnHeaders() upon failure. Rename getRowHeaders() and getColumnHeaders()
2836         to getTableRowHeaders() and getTableColumnHeaders() respectively.
2837
2838         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2839         (WTR::AccessibilityUIElement::rowHeaders const):
2840         (WTR::AccessibilityUIElement::columnHeaders const):
2841         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
2842         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
2843
2844 2017-11-16  Don Olmstead  <don.olmstead@sony.com>
2845
2846         [WinCairo] Update WinCairoRequirements
2847         https://bugs.webkit.org/show_bug.cgi?id=179790
2848
2849         Reviewed by Alex Christensen.
2850
2851         * TestWebKitAPI/PlatformWin.cmake:
2852
2853 2017-11-16  Daniel Bates  <dabates@apple.com>
2854
2855         Add feature define for alternative presentation button element
2856         https://bugs.webkit.org/show_bug.cgi?id=179692
2857         Part of <rdar://problem/34917108>
2858
2859         Reviewed by Andy Estes.
2860
2861         Only enabled on Cocoa platforms by default.
2862
2863         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2864
2865 2017-11-16  Per Arne Vollan  <pvollan@apple.com>
2866
2867         Win EWS bots should reboot after N webkit-patch iterations.
2868         https://bugs.webkit.org/show_bug.cgi?id=177970
2869
2870         Reviewed by Brent Fulgham.
2871
2872         * EWSTools/start-queue-win.sh:
2873
2874 2017-11-15  Carlos Garcia Campos  <cgarcia@igalia.com>
2875
2876         [WPE] Add initial support for WebDriver
2877         https://bugs.webkit.org/show_bug.cgi?id=179727
2878
2879         Reviewed by Michael Catanzaro.
2880
2881         Make it possible to run WebDriver tests with WPE.
2882
2883         * Scripts/run-webdriver-tests: Add --wpe alias for --platform=wpe.
2884         * Scripts/webkitpy/port/wpe.py:
2885         (WPEPort.__init__): Initialize _display_server from options.
2886         (WPEPort._driver_class): Use WaylandDriver when wayland is passed as display server option.
2887         * Scripts/webkitpy/webdriver_tests/webdriver_driver.py:
2888         (WebDriver.browser_env): Add virtual method to get the environment that should be used.
2889         * Scripts/webkitpy/webdriver_tests/webdriver_driver_wpe.py: Copied from Tools/Scripts/webkitpy/webdriver_tests/webdriver_driver.py.
2890         (WebDriverWPE):
2891         (WebDriverWPE.__init__):
2892         (WebDriverWPE.binary_path):
2893         (WebDriverWPE.browser_name):
2894         (WebDriverWPE.capabilities):
2895         (WebDriverWPE.browser_env):
2896         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
2897         (WebDriverW3CExecutor.__init__): Update the environment with the one provided by the driver.
2898         * wpe/jhbuild.modules: Upgrade dyz to newer version that supports automation.
2899
2900 2017-11-15  Alex Christensen  <achristensen@webkit.org>
2901
2902         WebViews scheduled in custom run loop modes should be able to do more than 50ms of work at a time
2903         https://bugs.webkit.org/show_bug.cgi?id=179742
2904         <rdar://problem/35519421>
2905
2906         Reviewed by Jer Noble.
2907
2908         * TestWebKitAPI/Tests/mac/WebViewScheduleInRunLoop.mm:
2909         (-[ScheduleInRunLoopDelegate webView:didFinishLoadForFrame:]):
2910         (TestWebKitAPI::TEST):
2911         Load more than one scheduled WebView to test work that typically takes more than 50 ms.
2912
2913 2017-11-15  Ryan Haddad  <ryanhaddad@apple.com>
2914
2915         Unreviewed, rolling out r223781.
2916
2917         The test is now returning false, so the FIXME is not needed
2918         anymore.
2919
2920         Reverted changeset:
2921
2922         "WebsiteDataStoreCustomPaths.mm is failing after r223718"
2923         https://bugs.webkit.org/show_bug.cgi?id=178596
2924         https://trac.webkit.org/changeset/223781
2925
2926 2017-11-15  Ryan Haddad  <ryanhaddad@apple.com>
2927
2928         Unreviewed, rolling out r224863.
2929
2930         Introduced LayoutTest crashes on iOS Simulator.
2931
2932         Reverted changeset:
2933
2934         "Move JSONValues to WTF and convert uses of InspectorValues.h
2935         to JSONValues.h"
2936         https://bugs.webkit.org/show_bug.cgi?id=173793
2937         https://trac.webkit.org/changeset/224863
2938
2939 2017-11-15  Michael Catanzaro  <mcatanzaro@igalia.com>
2940
2941         Remove GTK web inspector images
2942         https://bugs.webkit.org/show_bug.cgi?id=179716
2943
2944         Reviewed by Carlos Garcia Campos.
2945
2946         * Scripts/webkitdirs.pm:
2947         (shouldRemoveCMakeCache):
2948         * glib/generate-inspector-gresource-manifest.py:
2949         (get_filenames.should_ignore_resource):
2950         * gtk/manifest.txt.in:
2951         * wpe/manifest.txt.in:
2952
2953 2017-11-15  Jonathan Bedard  <jbedard@apple.com>
2954
2955         REGRESSION(r221877): 'future' handled incorrectly for mac
2956         https://bugs.webkit.org/show_bug.cgi?id=179711
2957         <rdar://problem/35546604>
2958
2959         Reviewed by Alex Christensen.
2960
2961         * Scripts/webkitpy/port/mac.py:
2962         (MacPort.default_baseline_search_path): Use platform/mac-<version> instead of
2963         platform/<version> as the baseline search path.
2964
2965 2017-11-14  Nan Wang  <n_wang@apple.com>
2966
2967         AX: AOM: Implement AccessibleNode class and support label and role attributes
2968         https://bugs.webkit.org/show_bug.cgi?id=179494
2969
2970         Reviewed by Ryosuke Niwa.
2971
2972         * DumpRenderTree/mac/DumpRenderTree.mm:
2973         (enableExperimentalFeatures):
2974         * WebKitTestRunner/TestController.cpp:
2975         (WTR::TestController::resetPreferencesToConsistentValues):
2976
2977 2017-11-14  Basuke Suzuki  <Basuke.Suzuki@sony.com>
2978
2979         [Windows] Fix error while launching subprocess on Windows Python
2980         https://bugs.webkit.org/show_bug.cgi?id=179637
2981
2982         Reviewed by Alex Christensen.
2983
2984         To pass environment variables to subprocess.popen on Windows Python 2,
2985         the dict values must be str not unicode.
2986         Also is_native_win() method is added to port.
2987
2988         * Scripts/webkitpy/common/system/platforminfo.py:
2989         (PlatformInfo.is_native_win):
2990         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2991         (MockPlatformInfo.is_native_win):
2992         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
2993         (TestPlatformInfo.test_os_name_and_wrappers):
2994         * Scripts/webkitpy/port/server_process.py:
2995         (ServerProcess.__init__):
2996
2997 2017-11-14  Carlos Garcia Campos  <cgarcia@igalia.com>
2998
2999         Move JSONValues to WTF and convert uses of InspectorValues.h to JSONValues.h
3000         https://bugs.webkit.org/show_bug.cgi?id=173793
3001
3002         Reviewed by Brian Burg.
3003
3004         * TestWebKitAPI/CMakeLists.txt:
3005         * TestWebKitAPI/PlatformGTK.cmake:
3006         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3007         * TestWebKitAPI/Tests/WTF/JSONValue.cpp: Renamed from Tools/TestWebKitAPI/Tests/JavaScriptCore/InspectorValue.cpp.
3008         (TestWebKitAPI::TEST):
3009
3010 2017-11-14  Jonathan Bedard  <jbedard@apple.com>
3011
3012         webkitpy: Use more verbose version info from simctl
3013         https://bugs.webkit.org/show_bug.cgi?id=179687
3014         <rdar://problem/35539392>
3015
3016         Reviewed by Tim Horton.
3017
3018         * Scripts/webkitpy/xcode/simulator.py:
3019         (Simulator): Address FIXME, use more verbose version.
3020         (Simulator._parse_runtimes): 'Internal' no longer stands along, check os for this
3021         string instead.
3022         * Scripts/webkitpy/xcode/simulator_unittest.py: Mock simctl output specifies iOS
3023         8.4.1, not iOS 8.4.
3024
3025 2017-11-14  Daniel Bates  <dabates@apple.com>
3026
3027         Update comment in FeatureDefines.xcconfig to reflect location of Visual Studio property files
3028         for feature defines
3029
3030         Following r195498 and r201917 the Visual Studio property files for feature defines have
3031         moved from directory WebKitLibraries/win/tools/vsprops to directory Source/cmake/tools/vsprops.
3032         Update the comment in FeatureDefines.xcconfig to reflect the new location and names of these
3033         files.
3034
3035         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3036
3037 2017-11-14  Jer Noble  <jer.noble@apple.com>
3038
3039         Enable Modern EME tests in DumpRenderTree
3040         https://bugs.webkit.org/show_bug.cgi?id=179544
3041
3042         Reviewed by Alex Christensen.
3043
3044         * DumpRenderTree/mac/DumpRenderTree.mm:
3045         (enableExperimentalFeatures):
3046
3047 2017-11-14  Commit Queue  <commit-queue@webkit.org>
3048
3049         Unreviewed, rolling out r224800.
3050         https://bugs.webkit.org/show_bug.cgi?id=179684
3051
3052         "Broke CLoop test mozilla/js1_6/Array/regress-304828.js"
3053         (Requested by mlam on #webkit).
3054
3055         Reverted changeset:
3056
3057         "Pass --useDollarVM=true to all JSC tests."
3058         https://bugs.webkit.org/show_bug.cgi?id=179647
3059         https://trac.webkit.org/changeset/224800
3060
3061 2017-11-14  Antti Koivisto  <antti@apple.com>
3062
3063         Enable display:contents by default
3064         https://bugs.webkit.org/show_bug.cgi?id=179655
3065
3066         Reviewed by Sam Weinig.
3067
3068         No need to enable this specifically for tests anymore.
3069
3070         * DumpRenderTree/mac/DumpRenderTree.mm:
3071         (enableExperimentalFeatures):
3072         * WebKitTestRunner/TestController.cpp:
3073         (WTR::TestController::resetPreferencesToConsistentValues):
3074
3075 2017-11-14  Tim Horton  <timothy_horton@apple.com>
3076
3077         Long pressing a phone number with spaces in it results in a link sheet instead of a data detectors sheet
3078         https://bugs.webkit.org/show_bug.cgi?id=179646
3079         <rdar://problem/35337288>
3080
3081         Reviewed by Simon Fraser.
3082
3083         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
3084         (-[ActionSheetObserver _dataDetectionContextForWebView:]):
3085         (TestWebKitAPI::TEST):
3086         Add a test that ensures that a phone number with spaces in it
3087         invokes a data detectors sheet, not a normal link sheet.
3088
3089 2017-11-14  Emilio Cobos Álvarez  <emilio@crisal.io>
3090
3091         Add committer status for Emilio Cobos Álvarez.
3092         https://bugs.webkit.org/show_bug.cgi?id=179667
3093
3094         Unreviewed.
3095
3096         * Scripts/webkitpy/common/config/contributors.json:
3097
3098 2017-11-13  Mark Lam  <mark.lam@apple.com>
3099
3100         Pass --useDollarVM=true to all JSC tests.
3101         https://bugs.webkit.org/show_bug.cgi?id=179647
3102
3103         Reviewed by Saam Barati.
3104
3105         * Scripts/run-jsc-stress-tests:
3106
3107 2017-11-13  Simon Fraser  <simon.fraser@apple.com>
3108
3109         When navigating back to a page, compositing layers may not use accelerated drawing
3110         https://bugs.webkit.org/show_bug.cgi?id=178749
3111         rdar://problem/35158946
3112
3113         Reviewed by Dean Jackson.
3114
3115         Fix WTR and DRT to parse "useAcceleratedDrawing" out of "webkit-test-runner" options
3116         and use it to set the state of the web view.
3117
3118         * DumpRenderTree/TestOptions.h:
3119         * DumpRenderTree/TestOptions.mm:
3120         (TestOptions::TestOptions):
3121         * DumpRenderTree/mac/DumpRenderTree.mm:
3122         (setWebPreferencesForTestOptions):
3123         * WebKitTestRunner/TestController.cpp:
3124         (WTR::TestController::resetPreferencesToConsistentValues):
3125         (WTR::updateTestOptionsFromTestHeader):
3126         * WebKitTestRunner/TestOptions.h:
3127         (WTR::TestOptions::hasSameInitializationOptions const):
3128
3129 2017-11-13  Basuke Suzuki  <Basuke.Suzuki@sony.com>
3130
3131         [Windows] Fix Python error for subprocess.popen with close_fds
3132         https://bugs.webkit.org/show_bug.cgi?id=179553
3133
3134         Reviewed by Per Arne Vollan.
3135
3136         * Scripts/webkitpy/port/server_process.py:
3137         (ServerProcess._start):
3138         (ServerProcess._should_close_fds):
3139
3140 2017-11-13  Michael Catanzaro  <mcatanzaro@igalia.com>
3141
3142         [GTK] Require woff2 1.0.2 and drop direct brotli dependency
3143         https://bugs.webkit.org/show_bug.cgi?id=179630
3144
3145         Reviewed by Frédéric Wang.
3146
3147         * gtk/jhbuild.modules:
3148
3149 2017-11-08  Keith Miller  <keith_miller@apple.com>
3150
3151         Async iteration should only fetch the next method once and add feature flag
3152         https://bugs.webkit.org/show_bug.cgi?id=179451
3153
3154         Reviewed by Geoffrey Garen.
3155
3156         Add feature flag for Async iteration.
3157
3158         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3159
3160 2017-11-13  Gabriel Ivascu  <givascu@igalia.com>
3161
3162         [GTK] Automatically adjust font size when gtk-xft-dpi changes
3163         https://bugs.webkit.org/show_bug.cgi?id=142673
3164
3165         Reviewed by Michael Catanzaro.
3166
3167         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
3168         (testWebKitSettings):
3169
3170 2017-11-13  Jonathan Bedard  <jbedard@apple.com>
3171
3172         check-webkit-style cannot construct valid iOS version without an iOS SDK
3173         https://bugs.webkit.org/show_bug.cgi?id=179616
3174         <rdar://problem/35507018>
3175
3176         Reviewed by David Kilzer.
3177
3178         Instead of throwing an exception when we ask for an unavailable SDK on Mac,
3179         we should return None.
3180
3181         * Scripts/webkitpy/common/system/platforminfo.py:
3182         (PlatformInfo.xcode_sdk_version): Return 'None' version if the machine does not
3183         have the requested SDK.
3184
3185 2017-11-13  Keith Miller  <keith_miller@apple.com>
3186
3187         Uninitialized variable in sort-Xcode-project-file
3188         https://bugs.webkit.org/show_bug.cgi?id=179581
3189
3190         Reviewed by Simon Fraser.
3191
3192         Previously all the unified source files were named
3193         UnifiedSource<some-number>.mm. This was changed to
3194         UnifiedSource<some-number>-mm.mm to stop Xcode from creating
3195         hashes for mm and cpp unified source files with the same
3196         number. This broke the expectations in sort-Xcode-project-file.
3197
3198         * Scripts/sort-Xcode-project-file:
3199         (sortChildrenByFileName):
3200         (sortFilesByFileName):
3201
3202 2017-11-13  JF Bastien  <jfbastien@apple.com>
3203
3204         std::expected: fix and test move
3205         https://bugs.webkit.org/show_bug.cgi?id=179617
3206
3207         Reviewed by Alex Christensen.
3208
3209         Test that unique_ptr can be moved around properly, both has a
3210         value and an error (and in a <void, unique> specialization).
3211
3212         * TestWebKitAPI/Tests/WTF/Expected.cpp:
3213         (TestWebKitAPI::snowflake::reset):
3214         (TestWebKitAPI::snowflake::snowflake):
3215         (TestWebKitAPI::snowflake::~snowflake):
3216         (TestWebKitAPI::TEST):
3217
3218 2017-11-13  Basuke Suzuki  <Basuke.Suzuki@sony.com>
3219
3220         [Windows] Make the port's normalize_test_name() method platform independent.
3221         https://bugs.webkit.org/show_bug.cgi?id=179572
3222
3223         Reviewed by Alexey Proskuryakov.
3224
3225         * Scripts/webkitpy/port/base.py:
3226         (Port.normalize_test_name):
3227
3228 2017-11-13  Wenson Hsieh  <wenson_hsieh@apple.com>
3229
3230         [Attachment Support] Implement SPI for clients to request data for a given attachment
3231         https://bugs.webkit.org/show_bug.cgi?id=179586
3232         <rdar://problem/35355720>
3233
3234         Reviewed by Darin Adler.
3235
3236         Augments existing API tests in WKAttachmentTests to additionally check that -requestData: yields the correct
3237         result when performing various editing operations. Also adds a new API test that cuts and pastes an attachment
3238         inserted using WKWebView attachment SPI, and expects that the data of the attachment can still be fetched using
3239         the _WKAttachment SPI, as well as another test that inserts an empty NSData and expects that requestData: also
3240         yields an empty NSData result.
3241
3242         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3243         (-[NSData shortDescription]):
3244         (-[_WKAttachment synchronouslyRequestData:]):
3245         (-[_WKAttachment expectRequestedDataToBe:]):
3246         (TestWebKitAPI::TEST):
3247
3248 2017-11-12  Gabriel Ivascu  <givascu@igalia.com>
3249
3250         [GTK] Add functionality to handle font sizes in points
3251         https://bugs.webkit.org/show_bug.cgi?id=179285
3252
3253         Reviewed by Carlos Garcia Campos and Michael Catanzaro.
3254
3255         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
3256         (testWebKitSettings):
3257
3258 2017-11-10  Fujii Hironori  <Hironori.Fujii@sony.com>
3259
3260         check-webkit-style: AttributeError: 'NoneType' object has no attribute 'major'
3261         https://bugs.webkit.org/show_bug.cgi?id=179522
3262
3263         Reviewed by Aakash Jain.
3264
3265         IOSSimulatorPort.ios_version should return a Version object.
3266
3267         * Scripts/webkitpy/port/ios_simulator.py:
3268         (IOSSimulatorPort.ios_version): Return a Version object.
3269
3270 2017-11-10  Basuke Suzuki  <Basuke.Suzuki@sony.com>
3271
3272         [Win] The way to detect Windows 10 is wrong
3273         https://bugs.webkit.org/show_bug.cgi?id=179344
3274
3275         Reviewed by Alex Christensen.
3276
3277         * Scripts/webkitpy/common/system/platforminfo.py:
3278         (PlatformInfo._determine_win_version):
3279
3280 2017-11-10  Basuke Suzuki  <Basuke.Suzuki@sony.com>
3281
3282         [WinCairo] LayoutTests doesn't read TextExpectations files correctly
3283         https://bugs.webkit.org/show_bug.cgi?id=179219
3284
3285         Reviewed by Alex Christensen.
3286
3287         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3288         (TestExpectationParser._parse_line):
3289         * Scripts/webkitpy/port/apple.py:
3290         (ApplePort.__init__):
3291         (ApplePort._allowed_port_names):
3292         (ApplePort):
3293         (ApplePort._future_port_name):
3294         (ApplePort._generate_all_test_configurations):
3295         * Scripts/webkitpy/port/win.py:
3296         (WinCairoPort.default_baseline_search_path):
3297         (WinCairoPort):
3298         (WinCairoPort._future_port_name):
3299
3300 2017-11-10  Basuke Suzuki  <Basuke.Suzuki@sony.com>
3301
3302         [WinCairo] Treat 'future' version correctly
3303         https://bugs.webkit.org/show_bug.cgi?id=179345
3304
3305         Reviewed by Alex Christensen.
3306
3307         * Scripts/webkitpy/port/win.py:
3308         (WinCairoPort.default_baseline_search_path):
3309
3310 2017-11-10  Wenson Hsieh  <wenson_hsieh@apple.com>
3311
3312         Finish rolling out r224544
3313
3314         Rubber-stamped by Tim Horton.
3315
3316         Now that https://bugs.webkit.org/show_bug.cgi?id=179431 has been fixed, we can once again allow one of the API
3317         tests added in r224512 (WKAttachmentTests.AttachmentUpdatesWhenChangingFontStyles) to test toggling underline
3318         style with a selected attachment element.
3319
3320         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3321         (TestWebKitAPI::TEST):
3322
3323 2017-11-10  Alex Christensen  <achristensen@webkit.org>
3324
3325         _WKThumbnailView initialization with WKWebView needs to call correct initWithFrame
3326         https://bugs.webkit.org/show_bug.cgi?id=179537
3327         <rdar://problem/35275219>
3328
3329         Reviewed by Darin Adler.
3330
3331         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
3332         (-[WKThumbnailViewDelegate webView:didFinishNavigation:]):
3333         (TestWebKitAPI::TEST):
3334
3335 2017-11-10  Jonathan Bedard  <jbedard@apple.com>
3336
3337         webkitpy: Remove find_system_pid from port classes
3338         https://bugs.webkit.org/show_bug.cgi?id=179514
3339         <rdar://problem/35456900>
3340
3341         Reviewed by David Kilzer.
3342
3343         Removing dead code.
3344
3345         * Scripts/webkitpy/port/base.py:
3346         (Port.find_system_pid): Deleted.
3347         * Scripts/webkitpy/port/server_process.py:
3348         (ServerProcess._start):
3349         * Scripts/webkitpy/port/win.py:
3350         (WinPort.find_system_pid): Deleted.
3351
3352 2017-11-10  Aakash Jain  <aakash_jain@apple.com>
3353
3354         fix style failures in webkitpy: multiple statements on one line (semicolon)
3355         https://bugs.webkit.org/show_bug.cgi?id=179530
3356
3357         Reviewed by Alex Christensen.
3358
3359         * Scripts/webkitpy/common/net/buildbot/buildbot.py: Removed semicolon.
3360         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py: Ditto.
3361         * Scripts/webkitpy/tool/steps/runtests.py: Ditto.
3362
3363 2017-11-10  Aakash Jain  <aakash_jain@apple.com>
3364
3365         fix style failures in webkitpy: expected 2 blank lines found 1
3366         https://bugs.webkit.org/show_bug.cgi?id=179529
3367
3368         Reviewed by Alex Christensen.
3369
3370         * Scripts/webkitpy/benchmark_runner/run_benchmark.py: Added a blank line to follow style guidelines.
3371         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: Ditto.
3372         * Scripts/webkitpy/common/system/platforminfo_mock.py: Ditto.
3373         * Scripts/webkitpy/common/version.py: Ditto.
3374         * Scripts/webkitpy/layout_tests/models/test_failures.py: Ditto.
3375         * Scripts/webkitpy/port/mac_unittest.py: Ditto.
3376         * Scripts/webkitpy/port/simulator_process.py: Ditto.
3377
3378 2017-11-10  Alex Christensen  <achristensen@webkit.org>
3379
3380         REGRESSION(r224267): WebViews scheduled with custom run loop modes don't load
3381         https://bugs.webkit.org/show_bug.cgi?id=179515
3382
3383         Reviewed by Andy Estes.
3384
3385         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3386         * TestWebKitAPI/Tests/mac/WebViewScheduleInRunLoop.mm: Added.
3387         (-[ScheduleInRunLoopDelegate webView:didFinishLoadForFrame:]):
3388         (TestWebKitAPI::TEST):
3389
3390 2017-11-10  Fujii Hironori  <Hironori.Fujii@sony.com>
3391
3392         [webkitpy] Fix PlatformInfo._win_version since r224657
3393         https://bugs.webkit.org/show_bug.cgi?id=179520
3394
3395         Reviewed by Aakash Jain.
3396
3397         There are two problems.
3398
3399         The return value of sys.getwindowsversion() doesn't match with
3400         Version.__init__ expects. Truncate the 4th and 5th of it.
3401
3402         _win_version_tuple_from_cmd was deleted in r224657. But, it is
3403         still needed for Cygwin Python.
3404
3405         * Scripts/webkitpy/common/system/platforminfo.py:
3406         (PlatformInfo._win_version): Return [0:3] of getwindowsversion().
3407         Call _win_version_from_cmd for Cygwin Python.
3408         (PlatformInfo._win_version_from_cmd): Restored.
3409
3410 2017-11-10  Guillaume Emont  <guijemont@igalia.com>
3411
3412         build-jsc: build testmasm for all platforms using cmake
3413         https://bugs.webkit.org/show_bug.cgi?id=179512
3414
3415         Reviewed by Michael Catanzaro.
3416
3417         * Scripts/build-jsc:
3418
3419 2017-11-09  Jonathan Bedard  <jbedard@apple.com>
3420
3421         webkitpy: Unify version parsing code
3422         https://bugs.webkit.org/show_bug.cgi?id=179426
3423         <rdar://problem/35415191>
3424
3425         Unreviewed fix to r224657.
3426
3427         * Scripts/webkitpy/common/version.py:
3428         (Version.__init__): Check if an object is iterable.
3429
3430 2017-11-09  Jonathan Bedard  <jbedard@apple.com>
3431
3432         webkitpy: Unify version parsing code
3433         https://bugs.webkit.org/show_bug.cgi?id=179426
3434         <rdar://problem/35415191>
3435
3436         Reviewed by David Kilzer.
3437
3438         webkitpy needs to parse version strings or version lists frequently. Rather than
3439         duplicate this code each time it's needed, unify it in a Version class.
3440
3441         * Scripts/webkitpy/common/system/platforminfo.py:
3442         (PlatformInfo.__init__): Convert mac version string to version object and
3443         use _win_version instead of _win_version_tuple.
3444         (PlatformInfo.xcode_sdk_version): Convert SDK version string to Version object
3445         before returning it.
3446         (PlatformInfo.xcode_version): Return Version object instead of version string.
3447         (PlatformInfo._determine_mac_version): Accept Version object instead of string,
3448         eliminate parsing.
3449         (PlatformInfo._determine_win_version): Accept Version object instead of tuple.
3450         (PlatformInfo._win_version): Return Version object instead of tuple, have Version
3451         object own version string parsing.
3452         (PlatformInfo._win_version_tuple): Renamed to _win_version().
3453         (PlatformInfo._win_version_tuple_from_cmd): Deleted.
3454         * Scripts/webkitpy/common/system/platforminfo_mock.py:
3455         (MockPlatformInfo.xcode_sdk_version): Return Version object instead of string.
3456         (MockPlatformInfo.xcode_version): Dittio.
3457         * Scripts/webkitpy/common/version.py: Added.
3458         (Version): Version object.
3459         (Version.__init__): Initialize the Version object with a string, integer,
3460         tuple of integers, list of integers or another Version object.
3461         (Version.__len__): Return 5 so that the Version object can be treated as
3462         a list or tuple.
3463         (Version.__getitem__): Get item in Version object by index or string.
3464         (Version.__setitem__): Set item in Version object by index or string.
3465         (Version.__str__): Convert version to printable string, omitting trailing 0's.
3466         (Version.__cmp__): Compare two version strings, major taking precedence over
3467         minor, minor taking precedence over build.
3468         * Scripts/webkitpy/common/version_unittest.py: Added.
3469         (VersionTestCase): Test behavior of Version object.
3470         * Scripts/webkitpy/port/ios.py:
3471         (IOSPort.default_baseline_search_path): ios_version now returns a Version object.
3472         (IOSPort._is_valid_ios_version): Deleted.
3473         (IOSPort.get_option): Deleted.
3474         * Scripts/webkitpy/port/ios_device.py:
3475         (IOSDevicePort.determine_full_port_name): Use Version object instead of owning parsing.
3476         (IOSDevicePort.ios_version): Return Version object instead of string.
3477         * Scripts/webkitpy/port/ios_simulator.py:
3478         (IOSSimulatorPort.simulator_runtime): Use from_version instead of from_version_string.
3479         (IOSSimulatorPort.ios_version): Return Version object instead of string.
3480         (IOSSimulatorPort.use_multiple_simulator_apps): Use Version object instead of string.
3481         * Scripts/webkitpy/xcode/simulator.py:
3482         (Runtime.from_version): Accept Version object instead of string.
3483         (Runtime.from_version_string): Replaced by from_version.
3484         (Runtime.__repr__): When printing, a runtime's version will be a Version object instead
3485         of a tuple.
3486         (Simulator._parse_runtimes): Use Version object instead of tuple.
3487         (Simulator._parse_devices): Ditto.
3488         * Scripts/webkitpy/xcode/simulator_unittest.py: Use Version object instead of tuples.
3489
3490 2017-11-09  Basuke Suzuki  <Basuke.Suzuki@sony.com>
3491
3492         [WinCairo] Cannot find ImageDiff executable
3493         https://bugs.webkit.org/show_bug.cgi?id=179508
3494
3495         Reviewed by Per Arne Vollan.
3496
3497         * Scripts/webkitpy/port/win.py:
3498         (WinPort.is_cygwin):
3499         (WinPort._path_to_image_diff):
3500         (WinPort.find_system_pid):
3501
3502 2017-11-09  Fujii Hironori  <Hironori.Fujii@sony.com>
3503
3504         [WinCairo EWS] svn-apply: 'cp' is not recognized as an internal or external command
3505         https://bugs.webkit.org/show_bug.cgi?id=179469
3506
3507         Reviewed by Per Arne Vollan.
3508
3509         WinCairo EWS bots haven't installed Cygwin.
3510
3511         * Scripts/svn-apply:
3512         (scmCopy): Use 'copy' function instead of 'cp' command.
3513
3514 2017-11-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3515
3516         [WPE] Update dyz (WPE MiniBrowser)
3517         https://bugs.webkit.org/show_bug.cgi?id=179492
3518
3519         Reviewed by Michael Catanzaro.
3520
3521         Update it to the last version as of today.
3522         This version not longer uses the C API.
3523
3524         * wpe/jhbuild.modules:
3525
3526 2017-11-09  Christopher Reid  <chris.reid@sony.com>
3527
3528         Use enum classes within FileSystem
3529         https://bugs.webkit.org/show_bug.cgi?id=175172
3530
3531         Reviewed by Darin Adler.
3532
3533         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
3534         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
3535
3536 2017-11-09  Brent Fulgham  <bfulgham@apple.com>
3537
3538         Test fix after r224609
3539         https://bugs.webkit.org/show_bug.cgi?id=178565
3540         <rdar://problem/11115901>
3541
3542         Unreviewed test fix after r224609.
3543
3544         Correct two test cases that attempt to push local file URLs in violation of our
3545         same origin policies. The fix is to grant universal file access, as we do for similar
3546         LayoutTests.
3547
3548         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
3549         (TestWebKitAPI::TEST):
3550         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
3551         (TestWebKitAPI::TEST):
3552
3553 2017-11-09  Michael Catanzaro  <mcatanzaro@igalia.com>
3554
3555         Unreviewed, remove Dan from the soup network watchlist
3556
3557         Per his request. It's not Hotel California; we should probably let him leave.
3558
3559         * Scripts/webkitpy/common/config/watchlist:
3560
3561 2017-11-08  Don Olmstead  <don.olmstead@sony.com>
3562
3563         Add Windows powershell EWS script
3564         https://bugs.webkit.org/show_bug.cgi?id=179453
3565
3566         Reviewed by Brent Fulgham.
3567
3568         * EWSTools/Start-Queue.ps1: Added.
3569
3570 2017-11-08  Jeremy Jones  <jeremyj@apple.com>
3571
3572         HTMLMediaElement should not use element fullscreen on iOS
3573         https://bugs.webkit.org/show_bug.cgi?id=179418
3574         rdar://problem/35409277
3575
3576         Reviewed by Eric Carlson.
3577
3578         Add ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN to determine if HTMLMediaElement should use element full screen or not.
3579
3580         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3581
3582 2017-11-08  Tim Horton  <timothy_horton@apple.com>
3583
3584         [ios-simulator] API test WebKit.BundleParameters is a flaky failure
3585         https://bugs.webkit.org/show_bug.cgi?id=178363
3586         <rdar://problem/35043144>
3587
3588         Reviewed by Brent Fulgham.
3589
3590         * TestWebKitAPI/Tests/WTF/RefCounter.cpp:
3591         (TestWebKitAPI::TEST):
3592         Add a test.
3593
3594 2017-11-08  Wenson Hsieh  <wenson_hsieh@apple.com>
3595
3596         [Attachment Support] Implement delegate hooks for attachment element insertion and removal
3597         https://bugs.webkit.org/show_bug.cgi?id=179016
3598         <rdar://problem/35250890>
3599
3600         Reviewed by Tim Horton.
3601
3602         See WebCore/ChangeLog for more details.
3603
3604         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3605         (-[AttachmentUpdateObserver init]):
3606         (-[AttachmentUpdateObserver inserted]):
3607         (-[AttachmentUpdateObserver removed]):
3608         (-[AttachmentUpdateObserver _webView:didInsertAttachment:]):
3609         (-[AttachmentUpdateObserver _webView:didRemoveAttachment:]):
3610         (TestWebKitAPI::ObserveAttachmentUpdatesForScope::ObserveAttachmentUpdatesForScope):
3611         (TestWebKitAPI::ObserveAttachmentUpdatesForScope::~ObserveAttachmentUpdatesForScope):
3612         (TestWebKitAPI::ObserveAttachmentUpdatesForScope::observer const):
3613         (TestWebKitAPI::ObserveAttachmentUpdatesForScope::expectAttachmentUpdates):
3614         (-[TestWKWebView _synchronouslyExecuteEditCommand:argument:]):
3615         (-[TestWKWebView expectUpdatesAfterCommand:withArgument:expectedRemovals:expectedInsertions:]):
3616         (TestWebKitAPI::TEST):
3617
3618 2017-11-08  Carlos Garcia Campos  <cgarcia@igalia.com>
3619
3620         Web Inspector: use JSON::{Array,Object,Value} instead of Inspector{Array,Object,Value}
3621         https://bugs.webkit.org/show_bug.cgi?id=173619
3622
3623         Reviewed by Brian Burg.