Unreviewed. Remove unused verbose mode from GLib API tests runner.
[WebKit-https.git] / Tools / ChangeLog
1 2018-01-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2
3         Unreviewed. Remove unused verbose mode from GLib API tests runner.
4
5         * glib/api_test_runner.py:
6         (add_options):
7
8 2018-01-21  Wenson Hsieh  <wenson_hsieh@apple.com>
9
10         Add a new feature flag for EXTRA_ZOOM_MODE and reintroduce AdditionalFeatureDefines.h
11         https://bugs.webkit.org/show_bug.cgi?id=181918
12
13         Reviewed by Tim Horton.
14
15         Add EXTRA_ZOOM_MODE to FeatureDefines.xconfig (off by default).
16
17         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
18
19 2018-01-21  Eric Carlson  <eric.carlson@apple.com>
20
21         Resign NowPlaying status when no media element is eligible
22         https://bugs.webkit.org/show_bug.cgi?id=181914
23         <rdar://problem/35294116>
24
25         Reviewed by Jer Noble.
26
27         * TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm:
28         (-[NowPlayingTestWebView hasActiveNowPlayingSession]):
29         (TestWebKitAPI::TEST):
30         * TestWebKitAPI/Tests/WebKitCocoa/large-video-test-now-playing.html:
31
32 2018-01-21  Aakash Jain  <aakash_jain@apple.com>
33
34         Fix broken unit-tests after r227192
35         https://bugs.webkit.org/show_bug.cgi?id=181909
36
37         Reviewed by Carlos Garcia Campos.
38
39         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
40
41 2018-01-20  Chris Dumez  <cdumez@apple.com>
42
43         API test URLSchemeHandler.Leaks1 is timing out on iOS simulator debug
44         https://bugs.webkit.org/show_bug.cgi?id=174984
45         <rdar://problem/33665676>
46
47         Reviewed by Alexey Proskuryakov.
48
49         Disable URLSchemeHandler.Leaks1 API test on iOS as it sometimes times out.
50
51         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-leaks.mm:
52         (TEST):
53
54 2018-01-20  Brian Burg  <bburg@apple.com>
55
56         WebDriver: fix some nits that prevent running W3C tests on Mac
57         https://bugs.webkit.org/show_bug.cgi?id=181864
58
59         Reviewed by Carlos Garcia Campos.
60
61         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:
62         (WebDriverW3CWebServer.__init__): _wsout needs to always be defined,
63         as we assume that the property exists later.
64
65         (WebDriverW3CWebServer.stop): If the temporary file doesn't
66         exist for some reason, the remove call will raise and exception.
67         Gracefully handle the case where the file isn't created due to
68         a problem/exception that happened elsewhere.
69
70 2018-01-19  Ling Ho  <lingcherd_ho@apple.com>
71
72         Move Bingdings EWS and Webkitpy EWS queues to High Sierra on buildbot dashboard.
73         https://bugs.webkit.org/show_bug.cgi?id=181881
74
75         Reviewed by Alexey Proskuryakov.
76
77         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
78         (BubbleQueueServer):
79         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
80         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
81         (table.queue-grid tr.platform.mac-os-x-elcapitan img.logo): Deleted.
82
83 2018-01-19  Youenn Fablet  <youenn@apple.com>
84
85         Do not go to the storage process when registering a service worker client if there is no service worker registered
86         https://bugs.webkit.org/show_bug.cgi?id=181740
87         <rdar://problem/36650400>
88
89         Reviewed by Chris Dumez.
90
91         Add support for internals inside API tests.
92
93         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
94         * TestWebKitAPI/Tests/InjectInternals_Bundle.cpp: Added.
95         (TestWebKitAPI::InternalsInjectedBundleTest::InternalsInjectedBundleTest):
96         (TestWebKitAPI::InternalsInjectedBundleTest::initialize):
97         (TestWebKitAPI::InternalsInjectedBundleTest::didCreatePage):
98         (TestWebKitAPI::InternalsInjectedBundleTest::didClearWindowForFrame):
99         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
100         (setConfigurationInjectedBundlePath):
101         (-[RegularPageMessageHandler userContentController:didReceiveScriptMessage:]):
102
103 2018-01-19  John Wilander  <wilander@apple.com>
104
105         Resource Load Statistics: Implement callback support for removal of WebsiteDataType::ResourceLoadStatistics
106         https://bugs.webkit.org/show_bug.cgi?id=181822
107         https://bugs.webkit.org/show_bug.cgi?id=175263
108         https://bugs.webkit.org/show_bug.cgi?id=178536
109         https://bugs.webkit.org/show_bug.cgi?id=181223
110         https://bugs.webkit.org/show_bug.cgi?id=181482
111         <rdar://problem/33491222>
112         <rdar://problem/33805293>
113         <rdar://problem/36332683>
114         <rdar://problem/36549026>
115
116         Reviewed by Alex Christensen.
117
118         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
119         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
120         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
121         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
122         * WebKitTestRunner/InjectedBundle/TestRunner.h:
123         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
124         (WTR::TestController::statisticsClearInMemoryAndPersistentStore):
125         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
126
127 2018-01-19  Jonathan Bedard  <jbedard@apple.com>
128
129         run-webkit-tests fails when there is a curly brace in Xcode build output
130         https://bugs.webkit.org/show_bug.cgi?id=181254
131         <rdar://problem/36453374>
132
133         Reviewed by Daniel Bates.
134
135         * Scripts/webkitpy/port/base.py:
136         (Port._run_script): Encode script output before logging it.
137
138 2018-01-19  Chris Dumez  <cdumez@apple.com>
139
140         Service worker registrations restored from disk may not be reused when the JS calls register() again
141         https://bugs.webkit.org/show_bug.cgi?id=181810
142         <rdar://problem/36591711>
143
144         Reviewed by Youenn Fablet.
145
146         Add API test coverage.
147
148         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
149         (-[SWMessageHandlerForRestoreFromDiskTest initWithExpectedMessage:]):
150         (-[SWMessageHandlerForRestoreFromDiskTest userContentController:didReceiveScriptMessage:]):
151
152 2018-01-19  Ryan Haddad  <ryanhaddad@apple.com>
153
154         Remove El Capitan queues from flakiness dashboard
155         https://bugs.webkit.org/show_bug.cgi?id=181860
156
157         Reviewed by Aakash Jain.
158
159         * TestResultServer/static-dashboards/builders.jsonp:
160
161 2018-01-19  Keith Miller  <keith_miller@apple.com>
162
163         HaveInternalSDK includes should be "#include?"
164         https://bugs.webkit.org/show_bug.cgi?id=179670
165
166         Reviewed by Dan Bernstein.
167
168         * MiniBrowser/Configurations/Base.xcconfig:
169         * MobileMiniBrowser/Configurations/Base.xcconfig:
170         * TestWebKitAPI/Configurations/Base.xcconfig:
171         * WebKitTestRunner/Configurations/Base.xcconfig:
172
173 2018-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
174
175         WebDriver: driver environment not passed to pytest when running w3c tests
176         https://bugs.webkit.org/show_bug.cgi?id=181852
177
178         Reviewed by Carlos Alberto Lopez Perez.
179
180         That's why color codes are not used in the bots log for selenium tests but they appear in w3c tests.
181
182         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
183         (WebDriverW3CExecutor.run):
184
185 2018-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
186
187         [GTK] WebDriver: wayland display no used in wayland bot
188         https://bugs.webkit.org/show_bug.cgi?id=181851
189
190         Reviewed by Carlos Alberto Lopez Perez.
191
192         We need to handle the additionalArguments property in the WebDriverTests step.
193
194         * BuildSlaveSupport/build.webkit.org-config/steps.py:
195         (RunWebDriverTests.start):
196
197 2018-01-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
198
199         [GTK] TERM environment variable is not passed to the test driver.
200         https://bugs.webkit.org/show_bug.cgi?id=181847
201
202         Rubber-stamped by by Carlos Garcia Campos.
203
204         * Scripts/webkitpy/port/base.py:
205         (Port.to.setup_environ_for_server):
206
207 2018-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
208
209         WebDriver: run-webdriver-tests is crashing in the bots when creating results json file
210         https://bugs.webkit.org/show_bug.cgi?id=181844
211
212         Reviewed by Carlos Alberto Lopez Perez.
213
214         We always try to create the directory where to store the json file, but when the filename is given directly,
215         like in the bots, the current dir is used.
216
217         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
218         (WebDriverTestRunner.dump_results_to_json_file): Do not try to create the directory if dirname() returns an
219         empty string.
220
221 2018-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
222
223         [GTK] WebDriver tests are running outside the jhbuild env
224         https://bugs.webkit.org/show_bug.cgi?id=181842
225
226         Reviewed by Žan Doberšek.
227
228         We need to enter jhbuild env in run-webdriver-tests.
229
230         * Scripts/run-webdriver-tests:
231
232 2018-01-18  Carlos Garcia Campos  <cgarcia@igalia.com>
233
234         [GTK] Run WebDriver tests in the bots
235         https://bugs.webkit.org/show_bug.cgi?id=181787
236
237         Reviewed by Michael Catanzaro.
238
239         Add a step to run WebDriver tests in the GTK test bots. The new step is not GTK specific, but only added to the
240         factory for the GTK port for now.
241
242         * BuildSlaveSupport/build.webkit.org-config/factories.py:
243         (TestFactory.__init__):
244         * BuildSlaveSupport/build.webkit.org-config/steps.py:
245         (RunWebDriverTests):
246         (RunWebDriverTests.start):
247         (RunWebDriverTests.commandComplete):
248         (RunWebDriverTests.evaluateCommand):
249         (RunWebDriverTests.getText):
250         (RunWebDriverTests.getText2):
251
252 2018-01-18  Basuke Suzuki  <Basuke.Suzuki@sony.com>
253
254         [WinCairo] Pass correct url for http test to test driver.
255         https://bugs.webkit.org/show_bug.cgi?id=181814
256
257         Reviewed by Alex Christensen.
258
259         * Scripts/webkitpy/port/driver.py:
260         (Driver):
261         (Driver.http_test_path_to_uri):
262         (Driver.is_secure_path):
263         (Driver.http_base_url):
264         (Driver.uri_to_test):
265
266 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
267
268         Unreviewed, update the triggerable name for 'sierra-release-perf-tests'
269
270         * BuildSlaveSupport/build.webkit.org-config/config.json:
271
272 2018-01-18  Dan Bernstein  <mitz@apple.com>
273
274         [Xcode] Streamline and future-proof target-macOS-version-dependent build setting definitions
275         https://bugs.webkit.org/show_bug.cgi?id=181803
276
277         Reviewed by Tim Horton.
278
279         * DumpRenderTree/mac/Configurations/Base.xcconfig: Updated.
280         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Ditto.
281         * ImageDiff/cg/Configurations/Base.xcconfig: Ditto.
282         * ImageDiff/cg/Configurations/DebugRelease.xcconfig: Ditto.
283         * MiniBrowser/Configurations/Base.xcconfig: Ditto.
284         * MiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
285         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
286         * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Ditto.
287         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Adopted macOSTargetConditionals
288           helpers.
289         * TestWebKitAPI/Configurations/macOSTargetConditionals.xcconfig: Added. Defines helper build
290           settings useful for defining settings that depend on the target macOS version.
291         * WebKitTestRunner/Configurations/Base.xcconfig: Updated.
292         * WebKitTestRunner/Configurations/DebugRelease.xcconfig: Updated.
293
294 2018-01-18  Ling Ho  <lingcherd_ho@apple.com>
295
296         Remove Opensource El Capitan queues from buildbot
297         https://bugs.webkit.org/show_bug.cgi?id=181712
298
299         Reviewed by Aakash Jain.
300
301         * BuildSlaveSupport/build.webkit.org-config/config.json:
302         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
303         (WebKitBuildbot):
304         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
305
306 2018-01-18  Chris Dumez  <cdumez@apple.com>
307
308         Service Workers restored from persistent storage have 'redundant' state
309         https://bugs.webkit.org/show_bug.cgi?id=181749
310         <rdar://problem/36556486>
311
312         Reviewed by Youenn Fablet.
313
314         Add API test coverage.
315
316         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
317         (-[SWMessageHandlerForFetchTest userContentController:didReceiveScriptMessage:]):
318
319 2018-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
320
321         [GTK] AX: Two layout tests crash with error 'g_strstr_len: assertion 'haystack != NULL' failed' in Accessibility::UIElement::url
322         https://bugs.webkit.org/show_bug.cgi?id=176796
323
324         Reviewed by Chris Fleizach.
325
326         Add sanity check that we have a URL before calling g_strstr_len().
327
328         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
329         (WTR::AccessibilityUIElement::url):
330
331 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
332
333         Add triggers for Sierra test262 and perf queues
334         https://bugs.webkit.org/show_bug.cgi?id=181799
335
336         Reviewed by Aakash Jain.
337
338         * BuildSlaveSupport/build.webkit.org-config/config.json:
339
340 2018-01-18  Wenson Hsieh  <wenson_hsieh@apple.com>
341
342         [iOS] Specify -[NSURL _title] for the associated URL when copying an image element
343         https://bugs.webkit.org/show_bug.cgi?id=181783
344         <rdar://problem/35785445>
345
346         Reviewed by Ryosuke Niwa.
347
348         Augments an existing API test and adds a new test to make sure that the resulting NSItemProvider's NSURL when
349         copying an image contains a relevant title.
350
351         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
352         (TestWebKitAPI::TEST):
353         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
354         * TestWebKitAPI/ios/UIKitSPI.h:
355
356 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
357
358         WebDriver: ignore the driver in selenium test names when getting expectations
359         https://bugs.webkit.org/show_bug.cgi?id=181738
360
361         Reviewed by Carlos Alberto Lopez Perez.
362
363         In selenium tests, the driver is added as a parameter to every test which results in tests names like
364         foo[DriverName] or foo[DriverName-param2] in case of tests using more parameters. We don't want to include the
365         driver name in the test expectations file, so we need to remove it when querying the expectations.
366
367         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
368         (TestExpectationsMarker.__init__): Save the param to ignore.
369         (TestExpectationsMarker._item_name): Return the name of the test without the para to ignore.
370         (TestExpectationsMarker.pytest_collection_modifyitems): Use _item_name().
371         (run): Pass param to ignore to TestExpectationsMarker().
372         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
373         (WebDriverSeleniumExecutor.__init__): Save the driver name.
374         (WebDriverSeleniumExecutor.run): Pass the driver name as param to ignore.
375
376 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
377
378         [GTK][WPE] Show unit tests unexpectedly passing in the bots
379         https://bugs.webkit.org/show_bug.cgi?id=181726
380
381         Reviewed by Michael Catanzaro.
382
383         Now that we have the info, let's show it also in the bots.
384
385         * BuildSlaveSupport/build.webkit.org-config/steps.py:
386         (RunGLibAPITests.commandComplete):
387
388 2018-01-17  Ling Ho  <lingcherd_ho@apple.com>
389
390         Fix broken unittest after r227048
391         https://bugs.webkit.org/show_bug.cgi?id=181760
392
393         Reviewed by Aakash Jain.
394
395
396 2018-01-17  Michael Catanzaro  <mcatanzaro@igalia.com>
397
398         WEBKIT_FRAMEWORK should not modify file-global include directories
399         https://bugs.webkit.org/show_bug.cgi?id=181656
400
401         Reviewed by Konstantin Tokarev.
402
403         * TestWebKitAPI/PlatformWPE.cmake:
404         * TestWebKitAPI/glib/CMakeLists.txt:
405
406 2018-01-17  Alicia Boya García  <aboya@igalia.com>
407
408         Unreviewed, mark Alicia as committer in contributors.json
409
410         * Scripts/webkitpy/common/config/contributors.json:
411
412 2018-01-17  Youenn Fablet  <youenn@apple.com>
413
414         Put fetch Request.keepalive behind a runtime flag
415         https://bugs.webkit.org/show_bug.cgi?id=181592
416
417         Reviewed by Chris Dumez.
418
419         * DumpRenderTree/mac/DumpRenderTree.mm:
420         (enableExperimentalFeatures):
421         * DumpRenderTree/win/DumpRenderTree.cpp:
422         (enableExperimentalFeatures):
423         * WebKitTestRunner/TestController.cpp:
424         (WTR::TestController::resetPreferencesToConsistentValues):
425
426 2018-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
427
428         Add injected bundle SPI to replace subresource URLs when dropping or pasting rich content
429         https://bugs.webkit.org/show_bug.cgi?id=181637
430         <rdar://problem/36508471>
431
432         Reviewed by Tim Horton.
433
434         Add 2 new API tests to exercise injected bundle SPI for supplying replacement URLs when pasting an image, and an
435         attributed string containing multiple NSTextAttachments. See WebKit and WebCore ChangeLogs for more detail.
436
437         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
438         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
439         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]):
440
441         Implement the new Objective-C bundle SPI to look up the incoming MIME type in the dictionary supplied via the
442         "MIMETypeToReplacementURLMap" bundle initialization parameter, and return it.
443
444         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
445         (webViewForTestingAttachments):
446         (-[TestWKWebView tagsInBody]):
447         (-[TestWKWebView expectElementTagsInOrder:]):
448         (-[TestWKWebView expectElementTag:toComeBefore:]):
449
450         Add a test helper to check that the given list of element tags appears in the document body. Also, reimplement
451         the existing -expectElementTag:toComeBefore: as a special case of -expectElementTagsInOrder:.
452
453         (TestWebKitAPI::TEST):
454         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
455         (WTR::InjectedBundlePage::InjectedBundlePage):
456
457 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
458
459         WebDriver: add support for test expectations
460         https://bugs.webkit.org/show_bug.cgi?id=180420
461
462         Reviewed by Carlos Alberto Lopez Perez.
463
464         Add support for parsing test expectations from a JSON file and mark tests on collection accordingly.
465
466         * Scripts/run-webdriver-tests: Get the retval from process_results().
467         * Scripts/webkitpy/thirdparty/__init__.py:
468         (AutoinstallImportHook._install_pytest): Install also py because pytest needs it.
469         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
470         (TestExpectationsMarker): Plugin to mark tests based on given expectations.
471         (TestExpectationsMarker.__init__): Initialize expectations.
472         (TestExpectationsMarker.pytest_collection_modifyitems): Mark tests if needed,
473         (run): Create and use TestExpectationsMarker plugin.
474         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
475         (WebDriverSeleniumExecutor.run): Pass expectations to pytest_runner.
476         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
477         (WebDriverTestRunner.__init__): Create a TestExpectations and pass it to the runners.
478         (WebDriverTestRunner.run): Do not count results here.
479         (WebDriverTestRunner.process_results): Rename print_results() as process_results() since it now returns the
480         amount of failures. Printing the test summary while processing results will be made optional in a follow up
481         patch.
482         (WebDriverTestRunner.process_results.report): Return the amount of failures.
483         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
484         (WebDriverTestRunnerSelenium.__init__): Initialize _expectations.
485         (WebDriverTestRunnerSelenium.collect_tests): Do not include skipped tests.
486         (WebDriverTestRunnerSelenium.run): Stop returning the tests count.
487         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
488         (WebDriverTestRunnerW3C.__init__): Initialize _expectations.
489         (WebDriverTestRunnerW3C.collect_tests): Do not include skipped tests.
490         (WebDriverTestRunnerW3C._scan_directory): Ditto.
491         (WebDriverTestRunnerW3C.run): Stop returning the tests count.
492         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
493         (WebDriverW3CExecutor.run): Pass expectations to pytest_runner.
494
495 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
496
497         Unreviewed WPE gardening. Mark some known unit test failures.
498
499         * TestWebKitAPI/glib/TestExpectations.json:
500
501 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
502
503         [GTK][WPE] Use the same subtest names in GTK and WPE unit tests
504         https://bugs.webkit.org/show_bug.cgi?id=181724
505
506         Reviewed by Philippe Normand.
507
508         We currently use /webkit2/foo/bar for GTK and /wpe/foo/bar for WPE. Many of the tests are common, so there's no
509         reason to use different names. This way we can refer to the same test names for both and we can share the
510         expectations in the TestExpectations.json file.
511
512         * TestWebKitAPI/glib/TestExpectations.json:
513         * TestWebKitAPI/glib/WebKitGLib/TestMain.h: Use /webkit/foo/bar in GTK and WPE.
514
515 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
516
517         Unreviewed. Increase the slow timeout of GTK and WPE unit tests.
518
519         We are using now a lower default timeout, so multiplying by 5 is no longer enough for some of the WTF
520         tests. Multiply by 10 so that we get the same slow timeout as before, 50.
521
522         * glib/api_test_runner.py:
523         (TestRunner._run_test_glib):
524         (TestRunner._run_google_test):
525
526 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
527
528         [GTK] Duplicated symbols in libjavascriptcoregtk and libwebkit2gtk can cause crashes in production builds
529         https://bugs.webkit.org/show_bug.cgi?id=179914
530
531         Reviewed by Žan Doberšek.
532
533         Add two scripts to be run by dist-check step when releasing. One is to detect symbols duplicated in
534         libjavascriptcoregtk and libwebkit2gtk that should be included to the version script. The other one is to ensure
535         all symbols listed in the script are present in the library.
536
537         * Scripts/check-for-global-bss-symbols-in-webkigtk-libs: Added.
538         (bss_symbols):
539         * Scripts/check-for-invalid-symbols-in-version-script: Added.
540         (script_symbols):
541         * Scripts/make-dist:
542         (Distcheck.build):
543         (Distcheck):
544         (Distcheck.check_symbols):
545         (Distcheck.check):
546
547 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
548
549         [GTK][WPE] Propagate the parameters when restarting glib api tests after a crash
550         https://bugs.webkit.org/show_bug.cgi?id=181722
551
552         Reviewed by Žan Doberšek.
553
554         I forgot to pass the parameters to run() when restarting.
555
556         * glib/glib_test_runner.py:
557         (GLibTestRunner.run):
558
559 2018-01-16  Fujii Hironori  <Hironori.Fujii@sony.com>
560
561         [CMake] Remove WebCoreDerivedSources library target
562         https://bugs.webkit.org/show_bug.cgi?id=181664
563
564         Reviewed by Carlos Garcia Campos.
565
566         * TestWebKitAPI/PlatformWPE.cmake: Do not link WebCoreDerivedSources.
567         * TestWebKitAPI/PlatformWin.cmake: Ditto.
568
569 2018-01-16  Ling Ho  <lingcherd_ho@apple.com>
570
571         Move Debug Test262, Release Test262 and Performance queues to Sierra
572         https://bugs.webkit.org/show_bug.cgi?id=181692
573
574         Unreviewed
575
576 2018-01-16  Zach Li  <zachli@apple.com>
577
578         Add pop-up policy support in website policies.
579         https://bugs.webkit.org/show_bug.cgi?id=181544.
580         rdar://problem/30521400.
581
582         Reviewed by Alex Christensen.
583
584         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
585         Added pop-up-check.html.
586
587         * TestWebKitAPI/Tests/WebKit/pop-up-check.html: Added.
588
589         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
590         (-[PopUpPoliciesDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
591         (-[PopUpPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
592         (-[PopUpPoliciesDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
593         (TEST):
594
595 2018-01-16  Wenson Hsieh  <wenson_hsieh@apple.com>
596
597         [Attachment Support] Provide the `src` of an attachment to the UI delegate when an attachment is inserted
598         https://bugs.webkit.org/show_bug.cgi?id=181638
599         <rdar://problem/36508702>
600
601         Reviewed by Dan Bernstein.
602
603         Tweak an existing API test to check that the `src` of an attachment element inserted via script matches the
604         `source` provided to the UI delegate via -[WKUIDelegate _webView:didInsertAttachment:withSource:].
605
606         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
607         (-[AttachmentUpdateObserver init]):
608         (-[AttachmentUpdateObserver sourceForIdentifier:]):
609         (-[AttachmentUpdateObserver _webView:didInsertAttachment:withSource:]):
610         (TestWebKitAPI::ObserveAttachmentUpdatesForScope::expectSourceForIdentifier):
611         (TestWebKitAPI::TEST):
612         (-[AttachmentUpdateObserver _webView:didInsertAttachment:]): Deleted.
613
614 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
615
616         Unreviewed. Fix GTK unit tests execution in the bots after r226967.
617
618         I forgot to pass the environment to the GLibTestRunner and Xvfb was not used in the bots.
619
620         * glib/api_test_runner.py:
621         (TestRunner._run_test_glib): Pass env to GLibTestRunner.
622         * glib/glib_test_runner.py:
623         (GLibTestRunner.run): Use given env.
624
625 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
626
627         [GTK][WPE] Stop passing --verbose to run-api-tests from the bots
628         https://bugs.webkit.org/show_bug.cgi?id=181676
629
630         Reviewed by Carlos Alberto Lopez Perez.
631
632         The option was removed in r226967.
633
634         * BuildSlaveSupport/build.webkit.org-config/steps.py:
635         (RunGtkAPITests):
636         (RunWPEAPITests):
637
638 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
639
640         Unreviewed. Temporarily bring back --verbose option of api_test_runner.py.
641
642         The bots are still passing that option and the step is failing because it was removed in r226967.
643
644         * glib/api_test_runner.py:
645         (add_options):
646
647 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
648
649         [GTK][WPE] Improve the way glib tests are run
650         https://bugs.webkit.org/show_bug.cgi?id=181674
651
652         Reviewed by Žan Doberšek.
653
654         Stop using gtester external program and use our own tester from python directly. This way we no longer need to
655         parse the tests output to get the results which is causing problems in WPE bot. We can now differentiate between
656         tests failing due to an expected assert in the test and unexpected crashes.
657         This also fixes a bug in previous code where we failed to properly detect tests timing out, because gtester was
658         not showing the subtest name in stdout in case of timeouts.
659         I've lowered the default timeout from 10 to 5, since we are now properly handling the timeout for every test
660         case. I've also removed the verbose option, since it was only used by gtester and we now always show the result
661         of every test case.
662
663         * glib/api_test_runner.py:
664         (TestRunner._run_test_glib): Use GLibTestRunner.
665         (TestRunner._run_google_test): Wrote tests timing out to stdout too.
666         (add_options):
667         * glib/glib_test_runner.py: Added.
668         (TestTimeout):
669         (Message):
670         (Message.__init__):
671         (Message.create):
672         (Message.create.read_unsigned):
673         (Message.create.read_double):
674         (Message.create.read_string):
675         (GLibTestRunner):
676         (GLibTestRunner.__init__):
677         (GLibTestRunner._process_data):
678         (GLibTestRunner._process_message):
679         (GLibTestRunner._read_from_pipe):
680         (GLibTestRunner._read_from_stderr):
681         (GLibTestRunner._start_timeout):
682         (GLibTestRunner._start_timeout._alarm_handler):
683         (GLibTestRunner._stop_timeout):
684         (GLibTestRunner._subtest_start):
685         (GLibTestRunner._subtest_message):
686         (GLibTestRunner._subtest_stderr):
687         (GLibTestRunner._subtest_end):
688         (GLibTestRunner.run):
689
690 2018-01-15  Michael Catanzaro  <mcatanzaro@igalia.com>
691
692         Unreviewed, add Thibault to contributors.json
693
694         It's a bit weird to add someone here before their first contribution, but this affects
695         Bugzilla autocomplete, and that is serious business.
696
697         * Scripts/webkitpy/common/config/contributors.json:
698
699 2018-01-15  JF Bastien  <jfbastien@apple.com>
700
701         Remove makePoisonedUnique
702         https://bugs.webkit.org/show_bug.cgi?id=181630
703         <rdar://problem/36498623>
704
705         Reviewed by Mark Lam.
706
707         Update tests.
708
709         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
710         (TestWebKitAPI::TEST):
711         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp:
712         (TestWebKitAPI::TEST):
713
714 2018-01-15  Adrian Perez de Castro  <aperez@igalia.com>
715
716         [GTK][JHBuild] Tools/gtk/install-dependencies: Package libxfont does not exist anymore in Arch Linux
717         https://bugs.webkit.org/show_bug.cgi?id=181476
718
719         Reviewed by Michael Catanzaro.
720
721         Update to xorg-server 1.19.6 which depends on libxfont2, and change
722         the lists of packages to install libxfont2-devel (or equivalent).
723
724         * gtk/install-dependencies:
725         * gtk/jhbuild.modules:
726
727 2018-01-15  Carlos Garcia Campos  <cgarcia@igalia.com>
728
729         [GTK][WPE] Add support for unit test expectations
730         https://bugs.webkit.org/show_bug.cgi?id=181589
731
732         Reviewed by Michael Catanzaro.
733
734         We currently have a way to skip tests by annotating them in the api test runner script. The main problem of this
735         approach is that we skip tests when they fail in the bots and we never notice if they stop failing, keeping the
736         tests skipped forever. This is indeed the case of several WebKit2 C API tests. Annotating skipped tests in the
737         script itself is not a good idea either.
738
739         This patch adds a generic TestExpectations class for simple tests based on tests with subtests, like our unit
740         tests, but also WebDriver tests. It parses a json file with the tests and subtests expectations and provides
741         convenient methods to query them.
742
743         * Scripts/run-gtk-tests:
744         (GtkTestRunner): Remove all Skipped and Slow tests marked here.
745         * Scripts/run-wpe-tests:
746         (WPETestRunner): Ditto.
747         * Scripts/webkitpy/common/test_expectations.py: Added.
748         (TestExpectations):
749         (TestExpectations.__init__):
750         (TestExpectations._port_name_for_expected):
751         (TestExpectations._expected_value):
752         (TestExpectations.skipped_tests):
753         (TestExpectations.skipped_subtests):
754         (TestExpectations._expectation_value):
755         (TestExpectations.is_slow):
756         (TestExpectations.get_expectation):
757         * Scripts/webkitpy/common/test_expectations_unittest.py: Added.
758         (MockTestExpectations):
759         (MockTestExpectations.__init__):
760         (MockTestExpectations.is_skip):
761         (ExpectationsTest):
762         (assert_exp):
763         (assert_not_exp):
764         (assert_bad_exp):
765         (assert_skip):
766         (test_basic):
767         (test_skip):
768         (test_flaky):
769         (test_build_type):
770         * TestWebKitAPI/glib/TestExpectations.json: Added.
771         * glib/api_test_runner.py:
772         (TestRunner): Remove SkippedTest implementation.
773         (TestRunner.__init__): Create a TestExpectations.
774         (TestRunner._test_cases_to_skip): Use TestExpectations to check skipped tests.
775         (TestRunner._should_run_test_program): Ditto.
776         (TestRunner._run_test_glib): Use TestExpectations to check if test suite is slow.
777         (TestRunner._run_test_glib.parse_line.set_test_result): Register also tests passing.
778         (TestRunner._run_google_test): Use TestExpectations to check if test cases is slow and register tests passing.
779         (TestRunner.run_tests): Check if actual result is the expected one and register also unexpected passes.
780         (TestRunner.run_tests.report): Helper to write report to stdout.
781
782 2018-01-13  Mark Lam  <mark.lam@apple.com>
783
784         Replace all use of ConstExprPoisoned with Poisoned.
785         https://bugs.webkit.org/show_bug.cgi?id=181542
786         <rdar://problem/36442138>
787
788         Reviewed by JF Bastien.
789
790         1. Converted tests to using new uintptr_t& poison type.
791         2. Added tests for Poisoned comparison operators.
792
793         * TestWebKitAPI/CMakeLists.txt:
794         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
795         * TestWebKitAPI/Tests/WTF/ConstExprPoisoned.cpp: Removed.
796         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
797         (TestWebKitAPI::TEST):
798         (TestWebKitAPI::initializeTestPoison): Deleted.
799         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp:
800         (TestWebKitAPI::TEST):
801         (TestWebKitAPI::passWithRef):
802         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp:
803         (TestWebKitAPI::TEST):
804         (TestWebKitAPI::f1):
805         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
806         (TestWebKitAPI::TEST):
807         (TestWebKitAPI::poisonedPtrFoo):
808         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp:
809         (TestWebKitAPI::TEST):
810         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
811         (TestWebKitAPI::TEST):
812
813 2018-01-13  David Kilzer  <ddkilzer@apple.com>
814
815         check-webkit-style: false positive for [whitespace/braces] with os_log format string
816         <https://webkit.org/b/181606>
817
818         Reviewed by Darin Adler.
819
820         * Scripts/webkitpy/style/checkers/cpp.py:
821         (check_spacing): Modify regular expression to ignore
822         os_log format strings like '%{public}'.
823         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
824         (CppStyleTest.test_spacing_before_braces): Add os_log
825         format string test.
826
827 2018-01-12  Wenson Hsieh  <wenson_hsieh@apple.com>
828
829         [macOS] API tests ChangeAttachmentDataUpdatesWithInPlaceDisplay and InPlaceVideoAttachmentInsertionWithinList are failing
830         https://bugs.webkit.org/show_bug.cgi?id=181626
831
832         Reviewed by Joseph Pecoraro.
833
834         Make the web view for WKAttachmentTests slightly bigger to avoid size clamping behavior introduced in r226915.
835         Additionally, write a new API test covering the change in r226915.
836
837         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
838         (webViewForTestingAttachments):
839         (TestWebKitAPI::TEST):
840
841 2018-01-12  Alex Christensen  <achristensen@webkit.org>
842
843         History state should be updated during client redirects with asynchronous policy decisions
844         https://bugs.webkit.org/show_bug.cgi?id=181358
845         <rdar://problem/35547689>
846
847         Reviewed by Andy Estes.
848
849         * TestWebKitAPI/Tests/WebKit/WKBackForwardList.mm:
850         (-[AsyncPolicyDecisionDelegate webView:didFinishNavigation:]):
851         (-[AsyncPolicyDecisionDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
852         (TEST):
853
854 2018-01-12  Jonathan Bedard  <jbedard@apple.com>
855
856         webkitpy: Refactor simulator code (Part 4)
857         https://bugs.webkit.org/show_bug.cgi?id=180555
858         <rdar://problem/36131381>
859
860         Reviewed by Aakash Jain.
861
862         Move new_simulated_device.py to simulated_device.py.
863
864         * Scripts/webkitpy/port/ios_simulator.py: Update import statement.
865         * Scripts/webkitpy/xcode/new_simulated_device.py: Removed.
866         * Scripts/webkitpy/xcode/new_simulated_device_unittest.py: Removed.
867         * Scripts/webkitpy/xcode/simulated_device.py: Copied from Tools/Scripts/webkitpy/xcode/new_simulated_device.py.
868         * Scripts/webkitpy/xcode/simulated_device_unittest.py: Copied from Tools/Scripts/webkitpy/xcode/new_simulated_device_unittest.py.
869
870 2018-01-12  Alex Christensen  <achristensen@webkit.org>
871
872         REGRESSION (r226818): API test WebKitLegacy.LoadInvalidURLRequest is failing
873         https://bugs.webkit.org/show_bug.cgi?id=181595
874
875         This test was testing behavior of an invalid URL that WebCore parses but NSURL does not.
876         It was using example.com<> but after r226479 < and > are considered invalid by WebCore.
877         I change the < and > to $ to make this test pass and continue to test what it used to.
878
879         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.html:
880         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm:
881         (-[LoadInvalidURLWebFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
882
883 2018-01-11  Keith Miller  <keith_miller@apple.com>
884
885         Rename ENABLE_ASYNC_ITERATION to ENABLE_JS_ASYNC_ITERATION
886         https://bugs.webkit.org/show_bug.cgi?id=181573
887
888         Reviewed by Simon Fraser.
889
890         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
891
892 2018-01-11  Jiewen Tan  <jiewen_tan@apple.com>
893
894         [WebAuthN] Import a CBOR coder from Chromium
895         https://bugs.webkit.org/show_bug.cgi?id=181522
896         <rdar://problem/36055729>
897
898         Reviewed by Brent Fulgham.
899
900         This patch also imports all unit tests into our API tests to ensure all
901         workarounds and modification against the original codebase doesn't change
902         any original functionalities.
903
904         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
905         * TestWebKitAPI/Tests/WebCore/CBORReaderTest.cpp: Added.
906         (TestWebKitAPI::TEST):
907         * TestWebKitAPI/Tests/WebCore/CBORValueTest.cpp: Added.
908         (TestWebKitAPI::TEST):
909         * TestWebKitAPI/Tests/WebCore/CBORWriterTest.cpp: Added.
910         (TestWebKitAPI::eq):
911         Workarounds applied.
912         (TestWebKitAPI::TEST):
913
914 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
915
916         webkitpy: Use partially disambiguated type in SimulatedDeviceManager._disambiguate_device_type
917         https://bugs.webkit.org/show_bug.cgi?id=181538
918         <rdar://problem/36440580>
919
920         Reviewed by Aakash Jain.
921
922         When disambiguating a device type, it is possible that the provided device type is sufficiently
923         ambiguous that the comparisons against complete device types without a disambiguated hardware_family
924         will result in a failure to disambiguate the type.
925
926         * Scripts/webkitpy/xcode/new_simulated_device.py:
927         (SimulatedDeviceManager._disambiguate_device_type):
928
929 2018-01-11  Brent Fulgham  <bfulgham@apple.com>
930
931         REGRESSION(r219530): ResourceLoadStatisticsPersistentStorage should be read-only in ephemeral sessions
932         https://bugs.webkit.org/show_bug.cgi?id=181136
933         <rdar://problem/36116604>
934
935         Reviewed by Chris Dumez.
936
937         Add a new API test to confirm that ResourceLoadStatistics can be turned on safely for ephemeral
938         browsing sessions.
939
940         * Scripts/run-gtk-tests:
941         (GtkTestRunner): Unskip test now that it passes.
942         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
943         (TEST): Add new WebsiteDataStoreEphemeral test.
944
945 2018-01-11  Ryan Haddad  <ryanhaddad@apple.com>
946
947         Unreviewed, rolling out r226816.
948
949         This change broke LayoutTests on the bots.
950
951         Reverted changeset:
952
953         "run-webkit-tests fails when there is a curly brace in Xcode
954         build output"
955         https://bugs.webkit.org/show_bug.cgi?id=181254
956         https://trac.webkit.org/changeset/226816
957
958 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
959
960         webkitpy: Fix flakey webserver tests
961         https://bugs.webkit.org/show_bug.cgi?id=181555
962         <rdar://problem/36448273>
963
964         Reviewed by Aakash Jain.
965
966         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
967         (LayoutTestRunnerTests.test_servers_started): Add and bind custom checks to
968         determine if a specific server is running.
969
970 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
971
972         Commit queue failed to land a bug, 'NoneType' object has no attribute 'strip'
973         https://bugs.webkit.org/show_bug.cgi?id=181561
974         <rdar://problem/36452652>
975
976         Reviewed by Aakash Jain.
977
978         BeautifulSoup.find may return None, this case should be gracefully handled.
979
980         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
981         (BugzillaQueries._parse_result_count):
982         (BugzillaQueries._fetch_bugs_from_advanced_query): Added logging.
983
984 2018-01-11  Alexey Proskuryakov  <ap@apple.com>
985
986         run-webkit-tests fails when there is a curly brace in Xcode build output
987         https://bugs.webkit.org/show_bug.cgi?id=181254
988
989         Reviewed by Daniel Bates.
990
991         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
992         (MeteredStream.write):
993
994 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
995
996         webkitpy: Reimplement simulator code (Part 3)
997         https://bugs.webkit.org/show_bug.cgi?id=180555
998         <rdar://problem/36131381>
999
1000         Reviewed by Aakash Jain.
1001
1002         Remove old simulator code.
1003
1004         * Scripts/webkitpy/xcode/__init__.py: Remove import statement.
1005         * Scripts/webkitpy/xcode/simulated_device.py: Removed.
1006         * Scripts/webkitpy/xcode/simulator.py: Removed.
1007         * Scripts/webkitpy/xcode/simulator_unittest.py: Removed.
1008
1009 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1010
1011         [Attachment Support] Support moving attachment elements in editable areas using drag and drop
1012         https://bugs.webkit.org/show_bug.cgi?id=181337
1013         <rdar://problem/36324813>
1014
1015         Reviewed by Tim Horton.
1016
1017         Add 3 new API tests for attachment element dragging.
1018
1019         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1020         (-[TestWKWebView expectElementTag:toComeBefore:]):
1021         (-[NSItemProvider expectType:withData:]):
1022         (TestWebKitAPI::TEST):
1023
1024 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
1025
1026         REGRESSION(r225856): Incorrectly managing 'future' baseline_search_paths. 
1027         https://bugs.webkit.org/show_bug.cgi?id=179621
1028         <rdar://problem/35589585>
1029
1030         Unreviewed infrastructure fix.
1031
1032         * Scripts/webkitpy/port/mac.py:
1033         (MacPort.default_baseline_search_path): Include 'future' in the version_fallback
1034         list if we are the VERSION_MAX, which usually corresponds with future.
1035
1036 2018-01-11  Filip Pizlo  <fpizlo@apple.com>
1037
1038         CodeBlocks should be in IsoSubspaces
1039         https://bugs.webkit.org/show_bug.cgi?id=180884
1040
1041         Reviewed by Saam Barati.
1042         
1043         Remove some less important benchmarks from the default run. Doing run-jsc-benchmarks
1044         shouldn't take a long time due to benchmarks we don't optimize for.
1045         
1046         * Scripts/run-jsc-benchmarks:
1047
1048 2018-01-11  Ms2ger  <Ms2ger@igalia.com>
1049
1050         Test gardening for GTK.
1051         https://bugs.webkit.org/show_bug.cgi?id=181477
1052
1053         Unreviewed test gardening.
1054
1055         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp: Correct the file name.
1056         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp: Adjust the expected console message.
1057
1058 2018-01-11  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1059
1060         Add the new JSCOnly bot to the scheduler.
1061         https://bugs.webkit.org/show_bug.cgi?id=181487
1062
1063         Unreviewed follow-up patch after r226729
1064
1065         On r226729 I missed to add the new JSCOnly bot the default scheduler.
1066         This is needed to make the bot automatically pick each commit for testing.
1067
1068         * BuildSlaveSupport/build.webkit.org-config/config.json:
1069
1070 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1071
1072         [Attachment Support] Support dragging attachment elements out as files on iOS
1073         https://bugs.webkit.org/show_bug.cgi?id=181199
1074         <rdar://problem/36299316>
1075
1076         Reviewed by Tim Horton, Andy Estes and Joseph Pecoraro.
1077
1078         Add support in the drag and drop simulator for testing blob-backed attachment element dragging, and also add new
1079         attachment API tests.
1080
1081         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1082         (-[NSItemProvider expectType:withData:]):
1083         (TestWebKitAPI::TEST):
1084
1085         Add two new WKAttachmentTests to exercise dragging data- and file-backed blobs via attachment elements. These
1086         tests first insert attachments via drop or WKWebView SPI, and then drag these attachments out and use the
1087         -expectType:withData: helper to inspect the item providers created from the drag source.
1088
1089         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1090         (TestWebKitAPI::TEST):
1091         * TestWebKitAPI/ios/DataInteractionSimulator.h:
1092         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1093         (-[MockDragSession localContext]):
1094         (-[MockDragSession setLocalContext:]):
1095         (-[DataInteractionSimulator _resetSimulatedState]):
1096         (-[DataInteractionSimulator simulateAllTouchesCanceled:]):
1097         (-[DataInteractionSimulator _concludeDataInteractionAndPerformOperationIfNecessary]):
1098         (-[DataInteractionSimulator _advanceProgress]):
1099         (-[DataInteractionSimulator endDataTransfer]):
1100
1101         Make some tweaks to the iOS drag and drop simulator. In particular, this patch (1) adds a new hook to tell
1102         WebKit that data transfers have been completed, (2) fixes incorrect drop proposal handling when returning
1103         UIDropOperationForbidden by replacing _shouldPerformOperation with a UIDropProposal, and (3) teach the
1104         MockDragSession to hold on to a localContext.
1105
1106 2018-01-11  Ali Juma  <ajuma@chromium.org>
1107
1108         Unreviewed. Add Ali Juma as contributor
1109
1110         * Scripts/webkitpy/common/config/contributors.json:
1111
1112 2018-01-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1113
1114         Unreviewed. Update Selenium WebDriver imported tests.
1115
1116         New version of selenium uses command line options to pass driver and browser binaries to pytest instead of
1117         environment variables.
1118
1119         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
1120         (collect): Reorder the arguments to make pytest happy.
1121         (run): Ditto.
1122         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
1123         (WebDriverSeleniumExecutor.__init__): Add driver binary, browser binary and browser args as arguments.
1124
1125 2018-01-11  Ling Ho  <lingcherd_ho@apple.com>
1126
1127         Move Commit Queue and EWS Queues to Sierra on Bot Watcher's Dasboard
1128         https://bugs.webkit.org/show_bug.cgi?id=181492
1129         <rdar://problem/36359679>
1130
1131         Reviewed by Alexey Proskuryakov. 
1132
1133 2018-01-10  Adrian Perez de Castro  <aperez@igalia.com>
1134
1135         [GTK] Tools/gtk/install-dependencies: Packages geoclue, ruby-highline, xorg-utils do not exist in Arch Linux
1136         https://bugs.webkit.org/show_bug.cgi?id=181475
1137
1138         Reviewed by Michael Catanzaro.
1139
1140         * gtk/install-dependencies: Update package list for Arch Linux, extend
1141         message shown at end of installation with additional tips.
1142
1143 2018-01-10  Wenson Hsieh  <wenson_hsieh@apple.com>
1144
1145         REGRESSION(r222507): Composition highlight doesn't render when using IME
1146         https://bugs.webkit.org/show_bug.cgi?id=181485
1147         <rdar://problem/35896516>
1148
1149         Reviewed by Ryosuke Niwa.
1150
1151         Add a `suppressUnderline` argument to TextInputController.setMarkedText. This suppresses the custom underlines
1152         rendered when testing IME on iOS in WebKit2. In this new test, suppressing underline rendering is needed to
1153         allow rendering composition backgrounds (see InlineTextBox::paint).
1154
1155         * DumpRenderTree/ios/TextInputControllerIOS.m:
1156         (+[TextInputController isSelectorExcludedFromWebScript:]):
1157         (+[TextInputController webScriptNameForSelector:]):
1158         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:]):
1159         (-[TextInputController setMarkedText:selectedFrom:length:]): Deleted.
1160         * DumpRenderTree/mac/TextInputControllerMac.m:
1161         (+[TextInputController isSelectorExcludedFromWebScript:]):
1162         (+[TextInputController webScriptNameForSelector:]):
1163         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:]):
1164         (-[TextInputController setMarkedText:selectedFrom:length:]): Deleted.
1165         * WebKitTestRunner/InjectedBundle/Bindings/TextInputController.idl:
1166         * WebKitTestRunner/InjectedBundle/TextInputController.cpp:
1167         (WTR::TextInputController::setMarkedText):
1168         * WebKitTestRunner/InjectedBundle/TextInputController.h:
1169
1170 2018-01-10  JF Bastien  <jfbastien@apple.com>
1171
1172         Poison small JSObject derivatives which only contain pointers
1173         https://bugs.webkit.org/show_bug.cgi?id=181483
1174         <rdar://problem/36407127>
1175
1176         Reviewed by Mark Lam.
1177
1178         Test the new move-assign and move-copy from unique_ptr, as well as
1179         nullptr_t ctors.
1180
1181         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
1182         (TestWebKitAPI::TEST):
1183         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
1184         (TestWebKitAPI::TEST):
1185         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
1186         (TestWebKitAPI::TEST):
1187
1188 2018-01-10  Chris Dumez  <cdumez@apple.com>
1189
1190         Multiple http/wpt/beacon/contentextensions/ test are flaky.
1191         https://bugs.webkit.org/show_bug.cgi?id=179256
1192         <rdar://problem/35401978>
1193
1194         Reviewed by Alex Christensen.
1195
1196         Update WebKitTestRunner to set a temporary path for content extensions so that its WKTR
1197         instance gets its own folder to avoid conflicts and flakiness.
1198
1199         * WebKitTestRunner/mac/TestControllerMac.mm:
1200         (WTR::TestController::platformConfigureViewForTest):
1201
1202 2018-01-10  Tim Horton  <timothy_horton@apple.com>
1203
1204         REGRESSION (r213590): Swipe from edge to go to previous page is significantly slower than tapping back button on Twitter
1205         https://bugs.webkit.org/show_bug.cgi?id=181269
1206         <rdar://problem/35110344>
1207
1208         Reviewed by Simon Fraser.
1209
1210         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1211         (WTR::UIScriptController::beginBackSwipe):
1212         (WTR::UIScriptController::completeBackSwipe):
1213         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1214         (WTR::UIScriptController::beginBackSwipe):
1215         (WTR::UIScriptController::completeBackSwipe):
1216         (WTR::UIScriptController::overridePreference):
1217         (WTR::UIScriptController::replaceTextAtRange):
1218         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1219         (WTR::PlatformWebView::setNavigationGesturesEnabled):
1220         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1221         (WTR::UIScriptController::beginBackSwipe):
1222         (WTR::UIScriptController::completeBackSwipe):
1223         Implement beginBackSwipe and completeBackSwipe on iOS (they already
1224         exist on Mac) in terms of the new WKWebView testing SPI.
1225
1226 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
1227
1228         REGRESSION (r226715): ignore WARNING output in linter tests
1229         https://bugs.webkit.org/show_bug.cgi?id=181486
1230         <rdar://problem/36408847>
1231
1232         Reviewed by Aakash Jain.
1233
1234         Linter unit tests should not be interested in logs at the the INFO or WARNING levels.
1235
1236         * Scripts/webkitpy/common/system/outputcapture.py:
1237         (OutputCapture.__init__): Pass logging level to be captured.
1238         * Scripts/webkitpy/style/main_unittest.py:
1239         (ExpectationLinterInStyleCheckerTest.test_no_linter_errors): Capture logging at the ERROR level.
1240         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line): Ditto.
1241         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_no_edit): Ditto.
1242         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_edit_in_file): Ditto.
1243         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_only_deletes): Ditto.
1244         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Ditto.
1245         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file): Ditto.
1246         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file_no_edit): Ditto.
1247
1248 2018-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1249
1250         Add a JSCOnly MIPS buildbot
1251         https://bugs.webkit.org/show_bug.cgi?id=181487
1252
1253         Reviewed by Michael Catanzaro.
1254
1255         Add the new bot configs definitions for the master and update the unit tests.
1256
1257         * BuildSlaveSupport/build.webkit.org-config/config.json:
1258         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1259
1260 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
1261
1262         REGRESSION (r226715): don't re-check number of simulators in child processes
1263         https://bugs.webkit.org/show_bug.cgi?id=181484
1264         <rdar://problem/36407151>
1265
1266         Reviewed by Aakash Jain.
1267
1268         * Scripts/webkitpy/port/ios_simulator.py:
1269         (IOSSimulatorPort.__init__): Skip the number of simulators check if simulators
1270         are already initialized.
1271
1272 2018-01-10  Commit Queue  <commit-queue@webkit.org>
1273
1274         Unreviewed, rolling out r226667 and r226673.
1275         https://bugs.webkit.org/show_bug.cgi?id=181488
1276
1277         This caused a flaky crash. (Requested by mlewis13 on #webkit).
1278
1279         Reverted changesets:
1280
1281         "CodeBlocks should be in IsoSubspaces"
1282         https://bugs.webkit.org/show_bug.cgi?id=180884
1283         https://trac.webkit.org/changeset/226667
1284
1285         "REGRESSION (r226667): CodeBlocks should be in IsoSubspaces"
1286         https://bugs.webkit.org/show_bug.cgi?id=180884
1287         https://trac.webkit.org/changeset/226673
1288
1289 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
1290
1291         Follow-up fix to r226715
1292         https://bugs.webkit.org/show_bug.cgi?id=180555
1293         <rdar://problem/36131381>
1294
1295         Unreviewed infrastructure fix.
1296
1297         * Scripts/webkitpy/xcode/new_simulated_device.py:
1298         (SimulatedDeviceManager._create_or_find_device_for_request): Use _delete instead
1299         of delete.
1300
1301 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
1302
1303         webkitpy: Refactor simulator code (Part 2)
1304         https://bugs.webkit.org/show_bug.cgi?id=180555
1305         <rdar://problem/36131381>
1306
1307         Reviewed by Aakash Jain.
1308
1309         The patch leverages the SimulatedDeviceManager when running layout tests.
1310         This patch is primarily code removal, since much of the IOSSimulatorPort
1311         was dedicated to managing simulators. The removed code is either now owned by the
1312         SimulatedDeviceManager (and committed in Part 1) or supported a technique to
1313         boot multiple simulators which was made obsolete in Xcode 9.
1314
1315         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1316         (Manager._custom_device_for_test.in): Device names now have spaces in them,
1317         strip those spaces.
1318         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1319         (parse_args): Remove '--runtime' flag, this is achieved with the --version flag.
1320         * Scripts/webkitpy/port/ios.py:
1321         (IOSPort.__init__): The _current_device idiom is no longer required since the
1322         SimulatedDeviceManager keeps track of any previously booted devices.
1323         (IOSPort.target_host): Even when only a single device is used, it will be accessed
1324         through the array of managed devices.
1325         (IOSPort.using_multiple_devices): Deleted.
1326         * Scripts/webkitpy/port/ios_device.py:
1327         (IOSDevicePort.using_multiple_devices): Deleted.
1328         * Scripts/webkitpy/port/ios_simulator.py:
1329         (IOSSimulatorPort): Remove constants required to manage simulators, change device
1330         class strings so they can be parsed by the DeviceType class.
1331         (IOSSimulatorPort.__init__): Determine the number of processes to use by checking
1332         the number of simulators currently booted, the number of child processes specified
1333         and the maximum number of simulators supported by this system.
1334         (IOSSimulatorPort._device_for_worker_number_map):Return the array of initialized
1335         devices owned by the SimulatedDeviceManager.
1336         (IOSSimulatorPort.ios_version): Remove support for the --runtime option.
1337         (IOSSimulatorPort.default_child_processes): Use the SimulatedDeviceManager to check
1338         the maximum number of supported simulators on this system.
1339         (IOSSimulatorPort._create_devices): Construct a list of device requests with a
1340         request for each child process and send this list to the SimulatedDeviceManager to
1341         initialize the devices.
1342         (IOSSimulatorPort.clean_up_test_run):
1343         (IOSSimulatorPort.check_sys_deps): Check that there are simulators running the
1344         specified version of iOS.
1345         (IOSSimulatorPort.reset_preferences):
1346         (IOSSimulatorPort.simulator_runtime): Deleted.
1347         (IOSSimulatorPort.simulator_device_type): Deleted.
1348         (IOSSimulatorPort._teardown_managed_simulators): Deleted.
1349         (IOSSimulatorPort.use_multiple_simulator_apps): Deleted.
1350         (IOSSimulatorPort._create_simulators): Deleted.
1351         (IOSSimulatorPort._quit_ios_simulator): Deleted.
1352         (IOSSimulatorPort._using_dedicated_simulators): Deleted.
1353         (IOSSimulatorPort.using_multiple_devices): Deleted.
1354         (IOSSimulatorPort._create_device): Deleted.
1355         (IOSSimulatorPort.get_simulator_path): Deleted.
1356         (IOSSimulatorPort._createSimulatorApps): Deleted.
1357         (IOSSimulatorPort._createSimulatorApp): Deleted.
1358         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1359         (TestRebaseline.test_rebaseline): Filter out commands run when determining the
1360         maximum number of simulators run on this system.
1361         (TestRebaselineExpectations.test_rebaseline_expectations): Ditto.
1362         * Scripts/webkitpy/xcode/new_simulated_device.py:
1363         (SimulatedDeviceManager._does_fulfill_request): Fixed log statement.
1364
1365 2018-01-10  Carlos Garcia Campos  <cgarcia@igalia.com>
1366
1367         WebDriver: run-webdriver-tests doesn't handle test names with a '/' correctly
1368         https://bugs.webkit.org/show_bug.cgi?id=181474
1369
1370         Reviewed by Carlos Alberto Lopez Perez.
1371
1372         We use os.path.basename() to get the subtest name. If the test name contains a slash we get part of the subtest
1373         name as the name.
1374
1375         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
1376         (WebDriverTestRunnerW3C._subtest_name): Helper function to get the subtest name.
1377         (WebDriverTestRunnerW3C.run): Use _subtest_name() instead of os.path.basename().
1378
1379 2018-01-09  Andy Estes  <aestes@apple.com>
1380
1381         [Xcode] Use the Apple Internal SDK if available when building ImageDiff
1382         https://bugs.webkit.org/show_bug.cgi?id=181459
1383
1384         Reviewed by Dan Bernstein.
1385
1386         * ImageDiff/cg/Configurations/Base.xcconfig:
1387
1388 2018-01-09  Myles C. Maxfield  <mmaxfield@apple.com>
1389
1390         font-display:fallback can cause a visual flash (which is supposed to be impossible)
1391         https://bugs.webkit.org/show_bug.cgi?id=181374
1392
1393         Reviewed by Simon Fraser.
1394
1395         The test requires Palatino.
1396
1397         * DumpRenderTree/mac/DumpRenderTree.mm:
1398         (allowedFontFamilySet):
1399         * WebKitTestRunner/mac/TestControllerMac.mm:
1400         (WTR::allowedFontFamilySet):
1401
1402 2018-01-09  Saam Barati  <sbarati@apple.com>
1403
1404         Give some slack in display-profiler-outputs computation of the terminal window's number of columns
1405         https://bugs.webkit.org/show_bug.cgi?id=181449
1406
1407         Reviewed by JF Bastien.
1408
1409         This allows me to Cmd+f in my terminal to search for things without
1410         having the results become misaligned.
1411
1412         * Scripts/display-profiler-output:
1413
1414 2018-01-09  Basuke Suzuki  <Basuke.Suzuki@sony.com>
1415
1416         [webkitpy] PlatformInfo should have default argument for casual use
1417         https://bugs.webkit.org/show_bug.cgi?id=180827
1418
1419         Reviewed by David Kilzer.
1420
1421         PlatformInfo should be the only way to check platform specific thing instead
1422         of sys.platform or other various checks. If there is something you want to check,
1423         it should be placed in PlatformInfo.
1424
1425         Currently to instantiate PlatformInfo, it requires arguments, which is usually
1426         sys, platform and Executive(). They are straight forward and should be handled
1427         by default arguments. Then we can instantiate PlatformInfo more casual.
1428
1429         * Scripts/webkitpy/common/system/platforminfo.py:
1430         (PlatformInfo): Use relative module path import
1431         (PlatformInfo.__init__):
1432         (PlatformInfo.executive): Lazy instantiation of Executive()
1433         (PlatformInfo.total_bytes_memory): Accessing via above property
1434         (PlatformInfo.xcode_sdk_version): Ditto
1435         (PlatformInfo.xcode_simctl_list): Ditto
1436         (PlatformInfo.xcode_version): Ditto
1437         (PlatformInfo._win_version_str): Ditto
1438         * Scripts/webkitpy/common/system/systemhost.py:
1439         (SystemHost.__init__):
1440         * Scripts/webkitpy/common/system/user.py:
1441         (User.__init__):
1442
1443 2018-01-09  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
1444
1445         [Win] Remove workaround for Bug 176442 after stopping MSVC 2015 support
1446         https://bugs.webkit.org/show_bug.cgi?id=176443
1447
1448         Reviewed by Darin Adler.
1449
1450         * TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:
1451         (TEST):
1452
1453 2018-01-09  Frederic Wang  <fwang@igalia.com.fr>
1454
1455         check-webkit-style: Verify syntax for WK_API_AVAILABLE
1456         https://bugs.webkit.org/show_bug.cgi?id=181394
1457
1458         Reviewed by Darin Adler.
1459
1460         A common syntax error for WK_API_AVAILABLE is to write ios(WK_MAC_TBA)
1461         as the second parameter instead of ios(WK_IOS_TBA). This generally
1462         builds for iOS on EWS but not when using the public SDK. See r224057,
1463         r223207 and r226211 for example. This patch adds a basic style check
1464         for that macro to prevent this kind of mistake.
1465
1466         * Scripts/webkitpy/style/checkers/cpp.py:
1467         (check_min_versions_of_wk_api_available): New function to verify the parameters of WX_API_AVAILABLE.
1468         (check_style): Run new style check.
1469         (CppChecker): Add build type for the new style check.
1470         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1471         (WebKitStyleTest.test_min_versions_of_wk_api_available): Add tests for the new style check.
1472
1473 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1474
1475         [Attachment Support] Expose HTMLAttachmentElement.uniqueIdentifier to bindings
1476         https://bugs.webkit.org/show_bug.cgi?id=181420
1477         <rdar://problem/36365827>
1478
1479         Reviewed by Alex Christensen.
1480
1481         Adjusts some existing API tests to verify that attachment elements' uniqueIdentifiers match the uniqueIdentifier
1482         of corresponding _WKAttachments.
1483
1484         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1485         (TestWebKitAPI::TEST):
1486
1487 2018-01-08  Alex Christensen  <achristensen@webkit.org>
1488
1489         Add WKNavigationDelegate SPI exposing WebProcess crash reason
1490         https://bugs.webkit.org/show_bug.cgi?id=181410
1491         <rdar://problem/36167199>
1492
1493         Reviewed by Wenson Hsieh.
1494
1495         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
1496         (-[CrashReasonDelegate _webView:webContentProcessDidTerminateWithReason:]):
1497         (TEST):
1498
1499 2018-01-08  Alex Christensen  <achristensen@webkit.org>
1500
1501         Add SPI for WKOpenPanelParameters._acceptedMIMETypes and _acceptedFileExtensions
1502         https://bugs.webkit.org/show_bug.cgi?id=181408
1503         <rdar://problem/35884960>
1504
1505         Reviewed by Tim Horton.
1506
1507         * TestWebKitAPI/Tests/WebKitCocoa/RunOpenPanel.mm:
1508         (-[RunOpenPanelUIDelegate webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
1509
1510 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1511
1512         [Attachment Support] Expose file name and content type of WKAttachment
1513         https://bugs.webkit.org/show_bug.cgi?id=181390
1514         <rdar://problem/36336837>
1515
1516         Reviewed by Tim Horton.
1517
1518         Adjusts some existing tests in WKAttachmentTests to exercise -requestInfo:.
1519
1520         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1521         (-[_WKAttachment synchronouslyRequestInfo:]):
1522         (-[_WKAttachment synchronouslyRequestData:]):
1523
1524         Reimplement this in terms of -synchronouslyRequestInfo:.
1525
1526         (-[_WKAttachment expectRequestedDataToBe:]):
1527         (TestWebKitAPI::TEST):
1528
1529 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1530
1531         Copying, pasting, and then deleting an attachment element breaks attachment data requests
1532         https://bugs.webkit.org/show_bug.cgi?id=181365
1533         <rdar://problem/36340647>
1534
1535         Reviewed by Tim Horton.
1536
1537         Adds two new attachment API tests to verify that copying and pasting an existing attachment inserts an
1538         attachment element that may be edited independently of the original attachment. See WebCore/ChangeLog for more
1539         detail.
1540
1541         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1542         (TestWebKitAPI::TEST):
1543
1544 2018-01-08  Youenn Fablet  <youenn@apple.com>
1545
1546         navigator.onLine does not work inside service workers
1547         https://bugs.webkit.org/show_bug.cgi?id=181079
1548         <rdar://problem/36178606>
1549
1550         Reviewed by Darin Adler.
1551
1552         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1553         (WTR::InjectedBundle::initialize): Setting service worker creation callback to inject ServiceWorkerInternals object.
1554
1555 2018-01-07  Saam Barati  <sbarati@apple.com>
1556
1557         Add total exits and total compilations sorting mode to the "full" command in display-profiler-output
1558         https://bugs.webkit.org/show_bug.cgi?id=181372
1559
1560         Reviewed by Filip Pizlo.
1561
1562         Adding these sorting modes makes it easier to analyze functions
1563         that recompile a lot and exit a lot.
1564
1565         * Scripts/display-profiler-output:
1566
1567 2018-01-06  Julien Brianceau  <julien.brianceau@gmail.com>
1568
1569         Unreviewed, remove my Cisco email from contributors.json
1570
1571         * Scripts/webkitpy/common/config/contributors.json:
1572
1573 2018-01-05  JF Bastien  <jfbastien@apple.com>
1574
1575         WebAssembly: poison JS object's secrets
1576         https://bugs.webkit.org/show_bug.cgi?id=181339
1577         <rdar://problem/36325001>
1578
1579         Reviewed by Mark Lam.
1580
1581         Update tests for swap(Poisoned<k, T>, T*)
1582
1583         * TestWebKitAPI/Tests/WTF/ConstExprPoisoned.cpp:
1584         (TestWebKitAPI::TEST):
1585         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
1586         (TestWebKitAPI::TEST):
1587         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp:
1588         (TestWebKitAPI::TEST):
1589
1590 2018-01-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1591
1592         REGRESSION(r226396) DataInteractionTests: ContentEditableToContentEditable and ContentEditableToTextarea are failing
1593         https://bugs.webkit.org/show_bug.cgi?id=181359
1594
1595         Reviewed by Tim Horton.
1596
1597         Ensure that these tests still pass using older SDKs.
1598
1599         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1600         (TestWebKitAPI::TEST):
1601
1602 2018-01-05  Alex Christensen  <achristensen@webkit.org>
1603
1604         Rebase API test after r226469
1605         https://bugs.webkit.org/show_bug.cgi?id=181308
1606
1607         * TestWebKitAPI/Tests/WebKitCocoa/LoadInvalidURLRequest.mm:
1608         (-[LoadInvalidURLNavigationActionDelegate webView:didFailProvisionalNavigation:withError:]):
1609         A URL with < or > in it is now recognized as invalid by WebKit.  This is intentional, and matches our behavior before enabling the new URLParser.
1610
1611 2018-01-05  Alex Christensen  <achristensen@webkit.org>
1612
1613         Restrict navigation-time WKWebsiteDataStore swapping to main frame navigations
1614         https://bugs.webkit.org/show_bug.cgi?id=181217
1615
1616         Reviewed by Tim Horton.
1617
1618         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1619         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
1620         (TEST):
1621
1622 2018-01-05  Alex Christensen  <achristensen@webkit.org>
1623
1624         Add WKBundleFrameCreateFrameHandle
1625         https://bugs.webkit.org/show_bug.cgi?id=181232
1626         <rdar://problem/35926696>
1627
1628         Reviewed by Tim Horton.
1629
1630         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1631         * TestWebKitAPI/Tests/WebKitCocoa/FrameHandleSerialization.mm: Added.
1632         (mouseDidMoveOverElement):
1633         (-[FrameHandleSerialization webProcessPlugIn:didCreateBrowserContextController:]):
1634         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
1635         (-[MouseMoveOverElementDelegate _webView:mouseDidMoveOverElement:withFlags:userInfo:]):
1636         (TEST):
1637
1638 2018-01-05  Chris Fleizach  <cfleizach@apple.com>
1639
1640         iOS: Build fix after r226432.
1641         
1642         Unreviewed. Stop duplicating speakAs symbols for iOS.
1643
1644         * DumpRenderTree/AccessibilityUIElement.cpp:
1645         (AccessibilityUIElement::speakAs):
1646
1647 2018-01-05  Javier Fernandez  <jfernandez@igalia.com>
1648
1649         Unreviewed, added myself as WebKit reviewer
1650
1651         * Scripts/webkitpy/common/config/contributors.json:
1652
1653 2018-01-05  Claudio Saavedra  <csaavedra@igalia.com>
1654
1655         WPE: Build fix after r226432.
1656
1657         Unreviewed. Rename ::speak() to ::speakAs().
1658         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
1659         (WTR::AccessibilityUIElement::speakAs):
1660         (WTR::AccessibilityUIElement::speak): Deleted.
1661
1662 2018-01-04  Chris Fleizach  <cfleizach@apple.com>
1663
1664         AX: Implement updated CSS3 Speech for 'speak' and 'speak-as' properties
1665         https://bugs.webkit.org/show_bug.cgi?id=180361
1666
1667         Reviewed by Zalan Bujtas.
1668
1669         * DumpRenderTree/AccessibilityUIElement.cpp:
1670         (speakAsCallback):
1671         (AccessibilityUIElement::speakAs):
1672         (AccessibilityUIElement::getJSClass):
1673         (speakCallback): Deleted.
1674         (AccessibilityUIElement::speak): Deleted.
1675         * DumpRenderTree/AccessibilityUIElement.h:
1676         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1677         (AccessibilityUIElement::speakAs):
1678         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1679         (AccessibilityUIElement::speakAs):
1680         (AccessibilityUIElement::speak): Deleted.
1681         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1682         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1683         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1684         (WTR::AccessibilityUIElement::speakAs):
1685         (WTR::AccessibilityUIElement::speak): Deleted.
1686         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1687         (WTR::AccessibilityUIElement::speakAs):
1688         (WTR::AccessibilityUIElement::speak): Deleted.
1689
1690 2018-01-04  Jonathan Bedard  <jbedard@apple.com>
1691
1692         REGRESSION (r226395): test-webkitperl test expectations incorrect
1693         https://bugs.webkit.org/show_bug.cgi?id=181307
1694         <rdar://problem/36306558>
1695
1696         Rubber-stamped by Aakash Jain.
1697
1698         r226395 added two lines towards the beginning of
1699         Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl, the line
1700         numbers in the test expectations need to update.
1701
1702         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt:
1703
1704 2018-01-04  Tim Horton  <timothy_horton@apple.com>
1705
1706         WKWebView loses minimum layout size overrides that happen while the process is terminated
1707         https://bugs.webkit.org/show_bug.cgi?id=181306
1708         <rdar://problem/34398288>
1709
1710         Reviewed by Dan Bernstein.
1711
1712         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
1713         (TEST):
1714         Add a test that calling _overrideLayoutParametersWithMinimumLayoutSize
1715         while the process is terminated results in the page getting the correct
1716         minimum layout size.
1717
1718 2018-01-04  Eric Carlson  <eric.carlson@apple.com>
1719
1720         [MediaStream] Add Mock screen capture source
1721         https://bugs.webkit.org/show_bug.cgi?id=181291
1722         <rdar://problem/36298164>
1723
1724         Reviewed by Dean Jackson.
1725
1726         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new test.
1727         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
1728         * TestWebKitAPI/Tests/WebKit/getDisplayMedia.html:
1729
1730 2018-01-04  Lucas Forschler  <lforschler@apple.com>
1731
1732         <rdar://problem/36300930> Change proxy server setting on master config to reach s3 servers
1733
1734         Reviewed by Ling Ho.
1735
1736         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1737
1738 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1739
1740         [Attachment Support] Create attachment elements when dropping files on iOS
1741         https://bugs.webkit.org/show_bug.cgi?id=181192
1742         <rdar://problem/36280945>
1743
1744         Reviewed by Tim Horton.
1745
1746         Adds 3 new API tests to exercise different use cases of dropping content as attachment elements when the runtime
1747         switch is enabled. See below for more details.
1748
1749         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1750         (-[NSItemProvider registerData:type:]):
1751         (platformCopyPNG):
1752         (TestWebKitAPI::TEST):
1753         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1754
1755         Fix some currently failing iOS drag and drop tests. In this case, there's no reason RTFD should appear in the
1756         source item provider when dragging rich text *without* attachments, so this should have been a check for just
1757         kUTTypeRTF instead.
1758
1759         (TestWebKitAPI::TEST):
1760
1761         Tests a few cases of inserting attachment elements via drop:
1762         1.  We should distinguish between drops containing rich/plain text files from just dropping rich/plain text.
1763             Instead of inserting the contents as inline web content, this should generate attachment elements.
1764         2.  Test the fallback mechanism for inserting attachment elements. If the preferred presentation style is not
1765             explicitly set, but there's nothing WebKit would otherwise do with the dropped content, then we should fall
1766             back to inserting the content as an attachment.
1767         3.  Test that if multiple attachments and inline item providers are present, WebKit will respect the order in
1768             which they were inserted by the source (as opposed to, for instance, putting all of the attachments in front
1769             or at the end).
1770
1771         * TestWebKitAPI/cocoa/TestWKWebView.h:
1772         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1773         (-[TestWKWebView objectByEvaluatingJavaScript:]):
1774
1775         Add a helper method to return an object that represents the result of evaluating some given script, and rewrite
1776         -stringByEvaluatingJavaScript to just turn around and call this.
1777
1778         (-[TestWKWebView stringByEvaluatingJavaScript:]):
1779
1780 2018-01-03  Ting-Wei Lan  <lantw44@gmail.com>
1781
1782         Replace hard-coded paths in shebangs with #!/usr/bin/env
1783         https://bugs.webkit.org/show_bug.cgi?id=181040
1784
1785         Reviewed by Alex Christensen.
1786
1787         * BuildSlaveSupport/build-launcher-app:
1788         * BuildSlaveSupport/build-launcher-dmg:
1789         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1790         * BuildSlaveSupport/built-product-archive:
1791         * BuildSlaveSupport/clean-build:
1792         * BuildSlaveSupport/delete-stale-build-files:
1793         * BuildSlaveSupport/download-built-product:
1794         * BuildSlaveSupport/gtk/buildbot/log/run:
1795         * BuildSlaveSupport/gtk/buildbot/run:
1796         * BuildSlaveSupport/gtk/pulseaudio/run:
1797         * BuildSlaveSupport/kill-old-processes:
1798         * BuildSlaveSupport/test-result-archive:
1799         * BuildSlaveSupport/win/kill-old-processes:
1800         * Scripts/SpacingHeuristics.pm:
1801         * Scripts/add-include:
1802         * Scripts/build-api-tests:
1803         * Scripts/build-dumprendertree:
1804         * Scripts/build-imagediff:
1805         * Scripts/build-jsc:
1806         * Scripts/build-webkit:
1807         * Scripts/build-webkittestrunner:
1808         * Scripts/check-Xcode-source-file-types:
1809         * Scripts/check-dom-results:
1810         * Scripts/check-for-exit-time-destructors:
1811         * Scripts/check-for-global-initializers:
1812         * Scripts/check-for-inappropriate-objc-class-names:
1813         * Scripts/check-for-weak-vtables-and-externals:
1814         * Scripts/clean-header-guards:
1815         * Scripts/compare-timing-files:
1816         * Scripts/configure-xcode-for-ios-development:
1817         * Scripts/copy-webkitlibraries-to-product-directory:
1818         * Scripts/create-exports:
1819         * Scripts/debug-minibrowser:
1820         * Scripts/debug-safari:
1821         * Scripts/debug-test-runner:
1822         * Scripts/do-file-rename:
1823         * Scripts/do-webcore-rename:
1824         * Scripts/dump-webkit-tests-run:
1825         * Scripts/ensure-valid-python:
1826         * Scripts/execAppWithEnv:
1827         * Scripts/extract-localizable-js-strings:
1828         * Scripts/filter-build-webkit:
1829         * Scripts/find-extra-includes:
1830         * Scripts/fix-blink-patch:
1831         * Scripts/generate-coverage-data:
1832         * Scripts/git-add-reviewer:
1833         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
1834         * Scripts/jsc-stress-test-helpers/js-executable-allocation-fuzz:
1835         * Scripts/jsc-stress-test-helpers/js-osr-exit-fuzz:
1836         * Scripts/make-new-script-test:
1837         * Scripts/make-script-test-wrappers:
1838         * Scripts/package-root:
1839         * Scripts/parse-malloc-history:
1840         * Scripts/report-include-statistics:
1841         * Scripts/resolve-ChangeLogs:
1842         * Scripts/run-api-tests:
1843         * Scripts/run-bindings-tests:
1844         * Scripts/run-content-extension-tester:
1845         * Scripts/run-iexploder-tests:
1846         * Scripts/run-javascriptcore-tests:
1847         * Scripts/run-jsc:
1848         * Scripts/run-leaks:
1849         * Scripts/run-mangleme-tests:
1850         * Scripts/run-minibrowser:
1851         * Scripts/run-pageloadtest:
1852         * Scripts/run-regexp-tests:
1853         * Scripts/run-safari:
1854         * Scripts/run-sunspider:
1855         * Scripts/run-test-runner:
1856         * Scripts/run-webkit-app:
1857         * Scripts/run-webkit-httpd:
1858         * Scripts/run-webkit-websocketserver:
1859         * Scripts/set-webkit-configuration:
1860         * Scripts/show-pretty-diff:
1861         * Scripts/sort-Xcode-project-file:
1862         * Scripts/split-file-by-class:
1863         * Scripts/sunspider-compare-results:
1864         * Scripts/svn-apply:
1865         * Scripts/svn-unapply:
1866         * Scripts/test-webkit-scripts:
1867         * Scripts/test-webkitperl:
1868         * Scripts/update-iexploder-cssproperties:
1869         * Scripts/update-javascriptcore-test-results:
1870         * Scripts/update-webkit:
1871         * Scripts/update-webkit-auxiliary-libs:
1872         * Scripts/update-webkit-dependency:
1873         * Scripts/update-webkit-libs-jhbuild:
1874         * Scripts/update-webkit-localizable-strings:
1875         * Scripts/update-webkit-support-libs:
1876         * Scripts/update-webkitgtk-libs:
1877         * Scripts/update-webkitwpe-libs:
1878         * Scripts/webkit-build-directory:
1879         * Scripts/webkitperl/LoadAsModule.pm:
1880         * Scripts/webkitperl/VCSUtils_unittest/decodeGitBinaryPatch.pl:
1881         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
1882         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl:
1883         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl:
1884         * Scripts/webkitperl/VCSUtils_unittest/generatePatchCommand.pl:
1885         * Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl:
1886         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl:
1887         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
1888         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
1889         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
1890         * Scripts/webkitperl/VCSUtils_unittest/parseFirstEOL.pl:
1891         * Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl:
1892         * Scripts/webkitperl/VCSUtils_unittest/parsePatch.pl:
1893         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
1894         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
1895         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
1896         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
1897         * Scripts/webkitperl/VCSUtils_unittest/parseUnifiedDiffHeader.pl:
1898         * Scripts/webkitperl/VCSUtils_unittest/prepareParsedPatch.pl:
1899         * Scripts/webkitperl/VCSUtils_unittest/removeEOL.pl:
1900         * Scripts/webkitperl/VCSUtils_unittest/runCommand.pl:
1901         * Scripts/webkitperl/VCSUtils_unittest/runPatchCommand.pl:
1902         * Scripts/webkitperl/VCSUtils_unittest/setChangeLogDateAndReviewer.pl:
1903         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl:
1904         * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl:
1905         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
1906         * Scripts/webkitperl/prepare-ChangeLog_unittest/extractLineRangeBeforeAndAfterChange.pl:
1907         * Scripts/webkitperl/prepare-ChangeLog_unittest/fetchRadarURLFromBugXMLData.pl:
1908         * Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl:
1909         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
1910         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl:
1911         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl:
1912         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl:
1913         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl:
1914         * Scripts/webkitperl/webkitdirs_unittest/appendToEnvironmentVariableList.pl:
1915         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRef.pl:
1916         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRefGettingValue.pl:
1917         * Scripts/webkitperl/webkitdirs_unittest/extractNonMacOSHostConfiguration.pl:
1918         * Scripts/webkitperl/webkitdirs_unittest/prependToEnvironmentVariableList.pl:
1919         * Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py:
1920         * ccache/ccache-clang:
1921         * ccache/ccache-clang++:
1922         * ccache/ccache-wrapper:
1923         * gtk/install-dependencies:
1924         * iExploder/iexploder-1.3.2/htdocs/iexploder.cgi:
1925         * iExploder/iexploder-1.3.2/htdocs/webserver.rb:
1926         * iExploder/iexploder-1.3.2/tools/lasthit.rb:
1927         * iExploder/iexploder-1.3.2/tools/osx_last_crash.rb:
1928         * iExploder/iexploder-1.3.2/tools/showtest.rb:
1929         * iExploder/iexploder-1.7.2/src/browser_harness.rb:
1930         * iExploder/iexploder-1.7.2/src/iexploder.cgi:
1931         * iExploder/iexploder-1.7.2/src/webserver.rb:
1932         * iExploder/iexploder-1.7.2/tools/lasthit.rb:
1933         * iExploder/iexploder-1.7.2/tools/osx_last_crash.rb:
1934         * wpe/install-dependencies:
1935
1936 2018-01-03  Simon Fraser  <simon.fraser@apple.com>
1937
1938         filter-build-webkit filters out useful compiler error lines
1939         https://bugs.webkit.org/show_bug.cgi?id=179864
1940
1941         Reviewed by Tim Horton.
1942
1943         Don't filter out lines that contain information about build errors by always showing lines
1944         after a line that contains "note:" or "error:".
1945
1946         * Scripts/filter-build-webkit:
1947         (shouldShowSubsequentLine):
1948         (shouldIgnoreLine):
1949
1950 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1951
1952         REGRESSION(r226366): [GTK] Broke TestBackForwardList and TestWebKitWebView
1953         https://bugs.webkit.org/show_bug.cgi?id=173915
1954
1955         Unreviewed follow-up. Fix /webkit2/WebKitWebView/session-state-with-form-data and
1956         /webkit2/WebKitWebView/submit-form. The form ID may be NULL, but we can't put NULL into a
1957         GVariant unless we use maybe types, and maybe types are incompatible with D-Bus. So use an
1958         empty string in this case.
1959
1960         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1961         (emitFormSubmissionEvent):
1962
1963 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1964
1965         [GTK] Add web process API to detect when form is submitted via JavaScript
1966         https://bugs.webkit.org/show_bug.cgi?id=173915
1967
1968         Reviewed by Carlos Garcia Campos.
1969
1970         Test it.
1971
1972         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
1973         (FormSubmissionTest::FormSubmissionTest):
1974         (FormSubmissionTest::~FormSubmissionTest):
1975         (FormSubmissionTest::testFormSubmissionResult):
1976         (FormSubmissionTest::willSendDOMEventCallback):
1977         (FormSubmissionTest::willCompleteCallback):
1978         (FormSubmissionTest::runJavaScriptAndWaitUntilFormSubmitted):
1979         (testWebExtensionFormSubmissionSteps):
1980         (beforeAll):
1981         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1982         (DelayedSignal::DelayedSignal):
1983         (emitFormSubmissionEvent):
1984         (handleFormSubmissionCallback):
1985         (willSubmitFormCallback):
1986         (pageCreatedCallback):
1987
1988 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1989
1990         Unreviewed, skip broken API test /webkit2/WebKitWebsiteData/databases
1991         https://bugs.webkit.org/show_bug.cgi?id=181251
1992
1993         * Scripts/run-gtk-tests:
1994         (GtkTestRunner):
1995
1996 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1997
1998         Unreviewed, skip broken API test /webkit2/WebKitWebsiteData/ephemeral
1999         https://bugs.webkit.org/show_bug.cgi?id=181136
2000
2001         * Scripts/run-gtk-tests:
2002         (GtkTestRunner):
2003
2004 2018-01-02  Brent Fulgham  <bfulgham@apple.com>
2005
2006         [macOS, iOS] Adopt new secure coding APIs in WebKit
2007         https://bugs.webkit.org/show_bug.cgi?id=181085
2008         <rdar://problem/34837397>
2009
2010         Reviewed by Tim Horton.
2011
2012         Update API tests to use secure coding wherever possible. Currently, NSView/UIView-based classes are not
2013         capable of supporting NSSecureCoding, so pass through the current coding routines.
2014
2015         * TestWebKitAPI/Tests/WebKitCocoa/ApplicationManifest.mm: Updated for NSSecureCoding.
2016         * TestWebKitAPI/Tests/WebKitCocoa/Coding.mm:
2017         (encodeAndDecode): Check if class supports the NSSecureCoding protocol and use non-secure coding
2018         routines if necessary.
2019         (TEST): Updated for NSSecureCoding.
2020         * TestWebKitAPI/Tests/mac/EarlyKVOCrash.mm:
2021         (TestWebKitAPI::TEST): Updated for NSSecureCoding.
2022
2023 2017-12-28  Yusuke Suzuki  <utatane.tea@gmail.com>
2024
2025         Remove std::chrono completely
2026         https://bugs.webkit.org/show_bug.cgi?id=181186
2027
2028         Reviewed by Alex Christensen.
2029
2030         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2031         (WTR::TestController::platformRunUntil):
2032
2033 2018-01-02  Michael Catanzaro  <mcatanzaro@igalia.com>
2034
2035         REGRESSION(r223253): Broke ResourceLoadStatistics layout tests for non-Cocoa ports
2036         https://bugs.webkit.org/show_bug.cgi?id=181231
2037
2038         Reviewed by Alex Christensen.
2039
2040         Implement TestController APIs needed by ResourceLoadStatistics tests.
2041
2042         * WebKitTestRunner/TestController.cpp:
2043         (WTR::TestController::isStatisticsRegisteredAsSubFrameUnder):
2044         (WTR::TestController::isStatisticsRegisteredAsRedirectingTo):
2045
2046 2018-01-02  Tim Horton  <timothy_horton@apple.com>
2047
2048         Disable WKAttachmentTests if UIPasteboard.itemProviders is not available
2049         https://bugs.webkit.org/show_bug.cgi?id=181219
2050
2051         Reviewed by Wenson Hsieh.
2052
2053         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2054
2055 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
2056
2057         Add a WebAuthentication runtime feature flag
2058         https://bugs.webkit.org/show_bug.cgi?id=181220
2059         <rdar://problem/36055305>
2060
2061         Reviewed by Brent Fulgham.
2062
2063         Renames the CredentialManagement runtime feature flag into WebAuthentication.
2064
2065         * DumpRenderTree/TestOptions.h:
2066         * DumpRenderTree/TestOptions.mm:
2067         (TestOptions::TestOptions):
2068         * DumpRenderTree/mac/DumpRenderTree.mm:
2069         (enableExperimentalFeatures):
2070         (setWebPreferencesForTestOptions):
2071         * WebKitTestRunner/TestController.cpp:
2072         (WTR::TestController::resetPreferencesToConsistentValues):
2073         (WTR::updateTestOptionsFromTestHeader):
2074         * WebKitTestRunner/TestOptions.h:
2075         (WTR::TestOptions::hasSameInitializationOptions const):
2076
2077 2018-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
2078
2079         [Attachment Support] Don't Blob-convert images and attachments with https:, http: or data: urls
2080         https://bugs.webkit.org/show_bug.cgi?id=181143
2081         <rdar://problem/36200381>
2082
2083         Reviewed by Tim Horton.
2084
2085         Add a new API test to ensure that a copied image with a data URL does not get pasted as an attachment when
2086         attachment elements are enabled.
2087
2088         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2089         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2090         (TestWebKitAPI::TEST):
2091
2092 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
2093
2094         Update Credential Management API for WebAuthentication
2095         https://bugs.webkit.org/show_bug.cgi?id=181082
2096         <rdar://problem/36055239>
2097
2098         Reviewed by Brent Fulgham.
2099
2100         Enable Credential Management API for testing.
2101
2102         * DumpRenderTree/TestOptions.h:
2103         * WebKitTestRunner/TestOptions.h:
2104
2105 2018-01-02  Michael Catanzaro  <mcatanzaro@igalia.com>
2106
2107         [GTK] Test /webkit2/WebKitWebExtension/form-controls-associated-signal is flaky
2108         https://bugs.webkit.org/show_bug.cgi?id=168194
2109
2110         Reviewed by Carlos Garcia Campos.
2111
2112         Fix an assertion and unskip the test. The order that form controls are associated is not
2113         guaranteed.
2114
2115         * Scripts/run-gtk-tests:
2116         (GtkTestRunner):
2117         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
2118         (didAssociateFormControlsCallback):
2119
2120 2018-01-02  Alex Christensen  <achristensen@webkit.org>
2121
2122         Use new WebsiteDataStore passed in through decidePolicyForNavigation SPI
2123         https://bugs.webkit.org/show_bug.cgi?id=180897
2124         <rdar://problem/35535328>
2125
2126         Reviewed by Brent Fulgham.
2127
2128         Test two forms of storage to be sure we are using a different WebsiteDataStore: cookies and sessionStorage.
2129
2130         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2131         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
2132         (-[WebsitePoliciesWebsiteDataStoreDelegate webView:startURLSchemeTask:]):
2133         (-[WebsitePoliciesWebsiteDataStoreDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2134         (websiteDataStoreTestWebView):
2135         (TEST):
2136
2137 == Rolled over to ChangeLog-2018-01-01 ==