e56049a33c3395285763f0a586ef1319dff4dd3f
[WebKit-https.git] / Tools / ChangeLog
1 2015-09-21  Brent Fulgham  <bfulgham@apple.com>
2
3         [Win] Use command-line argument to launch in regular or High DPI mode.
4         https://bugs.webkit.org/show_bug.cgi?id=149417
5
6         Reviewed by Dean Jackson.
7
8         * MiniBrowser/win/Common.cpp:
9         (parseCommandLine): Ignore the '--highDPI' argument. It's used at the
10         very start of execution, before the MiniBrowser.dll is loaded.
11         * win/DLLLauncher/DLLLauncherMain.cpp:
12         (shouldUseHighDPI): Check for '--highDPI', and use this mode if
13         present. On WinCairo, always use High DPI.
14
15 2015-09-21  Ryosuke Niwa  <rniwa@webkit.org>
16
17         32-bit Mac build fix attempt after r190065.
18
19         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
20
21 2015-09-21  Alexey Proskuryakov  <ap@apple.com>
22
23         [OS X] Update for Xcode 7.0 on Yosemite
24         https://bugs.webkit.org/show_bug.cgi?id=149389
25
26         Reviewed by Dan Bernstein.
27
28         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
29         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
30         Removed unneeded declarations - conforming to a protocol is sufficient.
31
32         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
33         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
34         Changed the definitions to be compiled whenever the SDK requires it (so we will have
35         dead code compiled in when building for 10.10 with 10.11 SDK, somewhat unfortunately).
36
37 2015-09-21  Simon Fraser  <simon.fraser@apple.com>
38
39         Add the ability for tests to run script in the UI process in WebKitTestRunner
40         https://bugs.webkit.org/show_bug.cgi?id=149356
41
42         Reviewed by Tim Horton.
43
44         This change adds testRunner.runUIScript(script, callback), which allows a test
45         to execute script in a JSContext which runs in the UI process. That context
46         has bindings exposed through the UIScriptController interface; currently one test
47         function, and some iOS-specific functions are included. UIScriptController can be
48         async with a callback, and runUIScript() itself is asynchronous. When the UI 
49         script is complete, it calls uiController.uiScriptComplete(result), where 'result'
50         is a string passed back to the web process, and given to the runUIScript()
51         callback function.
52         
53         Thanks to Gyuyoung Kim for help with the Gtk/Efl build.
54
55         * WebKitTestRunner/DerivedSources.make: Build UIScriptController.idl.
56         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Add runUIScript().
57         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
58         (WTR::InjectedBundle::didReceiveMessageToPage): When the UI-side script is
59         complete, call back into TestRunner.
60         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
61         (WTR::nextUIScriptCallbackID):
62         (WTR::TestRunner::runUIScript): Post a message to the injected bundle to run the UI script.
63         (WTR::TestRunner::runUIScriptCallback): When the UI script is done, execute its callback function.
64         * WebKitTestRunner/InjectedBundle/TestRunner.h:
65         * WebKitTestRunner/PlatformWebView.h:
66         * WebKitTestRunner/TestController.cpp:
67         (WTR::updateTestOptionsFromTestHeader):
68         (WTR::TestController::testOptionsForTest): Support "useFlexibleViewport" as a test argument.
69         (WTR::shouldUseFixedLayout): Deleted. Moved to a TestInvocation function.
70         * WebKitTestRunner/TestInvocation.cpp:
71         (WTR::TestInvocation::shouldUseFixedLayout):
72         (WTR::TestInvocation::shouldUseThreadedScrolling):
73         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
74         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
75         (WTR::TestInvocation::runUISideScript): Run the UI-side script!
76         (WTR::TestInvocation::uiScriptDidComplete): Send a message back to the injected bundle.
77         * WebKitTestRunner/TestInvocation.h:
78         * WebKitTestRunner/TestOptions.h:
79         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
80         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
81         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
82         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm: Added.
83         (-[TestRunnerWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]):
84         (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]):
85         (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]):
86         (-[TestRunnerWKWebView onDidEndZooming:]): Allow a test to hook into the end of zooming.
87         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
88         (WTR::PlatformWebView::PlatformWebView): Make a TestRunnerWKWebView on iOS.
89         * WebKitTestRunner/ios/UIScriptControllerIOS.mm: Added.
90         (WTR::UIScriptController::doAsyncTask):
91         (WTR::UIScriptController::zoomToScale):
92         (WTR::UIScriptController::zoomScale):
93         (WTR::UIScriptController::minimumZoomScale):
94         (WTR::UIScriptController::maximumZoomScale):
95         (WTR::UIScriptController::contentVisibleRect):
96         * WebKitTestRunner/mac/EventSenderProxy.mm:
97         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
98         (-[TestRunnerWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]): Deleted.
99         * WebKitTestRunner/mac/TestControllerMac.mm:
100         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
101         (WTR::shouldUseThreadedScrolling): Deleted. Moved to TestInvocation.
102         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
103         * WebKitTestRunner/uiscriptcontext/UIScriptContext.cpp: Added. Owns the JS context in the UI process.
104         (UIScriptContext::UIScriptContext):
105         (UIScriptContext::~UIScriptContext):
106         (UIScriptContext::runUIScript): Entrypoint to running the UI script. If the script didn't do anything
107         asynchronous, call the callback.
108         (UIScriptContext::nextTaskCallbackID):
109         (UIScriptContext::prepareForAsyncTask): Do setup for one async task (i.e. a UIScriptController function
110         that has a callback). Has to store the callbackID of the script, so code called from the completion
111         callback knows which UI script invoked it.
112         (UIScriptContext::asyncTaskComplete): Called when one task is finished.
113         (UIScriptContext::uiScriptComplete):
114         (UIScriptContext::objectFromRect): Make a JS object from a rect.
115         * WebKitTestRunner/uiscriptcontext/UIScriptContext.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
116         (WTR::UIScriptContext::hasOutstandingAsyncTasks):
117         * WebKitTestRunner/uiscriptcontext/UIScriptController.cpp: Copied from Tools/WebKitTestRunner/TestOptions.h.
118         (WTR::UIScriptController::UIScriptController):
119         (WTR::UIScriptController::makeWindowObject):
120         (WTR::UIScriptController::wrapperClass):
121         (WTR::UIScriptController::doAsyncTask):
122         (WTR::UIScriptController::zoomToScale):
123         (WTR::UIScriptController::zoomScale):
124         (WTR::UIScriptController::minimumZoomScale):
125         (WTR::UIScriptController::maximumZoomScale):
126         (WTR::UIScriptController::contentVisibleRect):
127         (WTR::UIScriptController::uiScriptComplete):
128         * WebKitTestRunner/uiscriptcontext/UIScriptController.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
129         (WTR::UIScriptController::create):
130         * WebKitTestRunner/uiscriptcontext/bindings/UIScriptController.idl: Copied from Tools/WebKitTestRunner/TestOptions.h.
131
132 2015-09-21  Tim Horton  <timothy_horton@apple.com>
133
134         Turn on threaded scrolling by default in the tests
135         https://bugs.webkit.org/show_bug.cgi?id=149377
136
137         Reviewed by Simon Fraser.
138
139         * WebKitTestRunner/mac/TestControllerMac.mm:
140         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
141         (WTR::shouldUseThreadedScrolling): Deleted.
142         Turn on threaded scrolling by default.
143
144 2015-09-21  Carlos Garcia Campos  <cgarcia@igalia.com>
145
146         [GTK] run-gtk-tests doesn't provide feedback about crashing google tests
147         https://bugs.webkit.org/show_bug.cgi?id=149252
148
149         Reviewed by Darin Adler.
150
151         In case of glib tests the test runner notifies about tests
152         crashing, but for google tests we don't get any feedback, which
153         means that in case of a test crashing we get a list of **PASS**
154         messages and at the summary we are notified that the test suite
155         has failed, but it's impossible to know which test cases have failed.
156
157         * Scripts/run-gtk-tests:
158         (TestRunner._run_google_test): Add a **CRASH** message if test
159         case crashed.
160
161 2015-09-20  Alexey Proskuryakov  <ap@apple.com>
162
163         WebKitTestRunner can leak user content script results between tests
164         https://bugs.webkit.org/show_bug.cgi?id=149391
165
166         Reviewed by Sam Weinig.
167
168         Move WKBundlePageRemoveAllUserContent call so that it's executed before loading
169         about:blank, and thus about:blank doesn't have unintended side effects.
170
171         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
172         (WTR::InjectedBundle::beginTesting):
173         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
174         (WTR::InjectedBundlePage::resetAfterTest):
175
176 2015-09-20  Alexey Proskuryakov  <ap@apple.com>
177
178         [Mac, iOS] AccessibilityController doesn't uninstall global notification handler
179         https://bugs.webkit.org/show_bug.cgi?id=149384
180
181         Reviewed by Chris Fleizach.
182
183         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
184         (AccessibilityController::addNotificationListener): Fixed a leak, and cleaned up the code.
185         (AccessibilityController::platformResetToConsistentState): Actually remove the handler,
186         regardless of whether someone else holds a reference (we also call -stopListening in
187         -dealloc).
188
189         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
190         (AccessibilityController::platformResetToConsistentState):
191         (AccessibilityController::addNotificationListener):
192         Ditto.
193
194 2015-09-20  Youenn Fablet  <youenn.fablet@crf.canon.fr>
195
196         Remove XHR_TIMEOUT compilation guard
197         https://bugs.webkit.org/show_bug.cgi?id=149260
198
199         Reviewed by Benjamin Poulain.
200
201         * Scripts/webkitperl/FeatureList.pm:
202
203 2015-09-19  Dan Bernstein  <mitz@apple.com>
204
205         Attempted build fix.
206
207         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
208
209 2015-09-18  Commit Queue  <commit-queue@webkit.org>
210
211         Unreviewed, rolling out r189908.
212         https://bugs.webkit.org/show_bug.cgi?id=149368
213
214         Broke run-webkit-tests --pixel (Requested by ap on #webkit).
215
216         Reverted changeset:
217
218         "printing does not use minimum page zoom factor"
219         https://bugs.webkit.org/show_bug.cgi?id=108507
220         http://trac.webkit.org/changeset/189908
221
222 2015-09-18  Andy Estes  <aestes@apple.com>
223
224         [iOS] did{Start,Finish}LoadForQuickLookDocumentInMainFrame is never called on WKNavigationDelegate
225         https://bugs.webkit.org/show_bug.cgi?id=149360
226
227         Reviewed by Tim Horton.
228
229         Added an API test.
230
231         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
232         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm: Added.
233         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
234         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
235         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]):
236         (TEST):
237         * TestWebKitAPI/ios/pages.pages: Added.
238
239 2015-09-18  Nan Wang  <n_wang@apple.com>
240
241         AX: Implement ARIA 1.1 @aria-current on iOS
242         https://bugs.webkit.org/show_bug.cgi?id=149297
243
244         Reviewed by Chris Fleizach.
245
246         Added support to test aria-current on iOS.
247
248         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
249         (AccessibilityUIElement::stringAttributeValue):
250         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
251         (WTR::AccessibilityUIElement::stringAttributeValue):
252
253 2015-09-18  Alexey Proskuryakov  <ap@apple.com>
254
255         iOS WebKitTestRunner frequently crashes in WKContextGetIconDatabase
256         https://bugs.webkit.org/show_bug.cgi?id=149352
257
258         Reviewed by Simon Fraser.
259
260         * WebKitTestRunner/TestController.cpp: (WTR::TestController::~TestController):
261         m_context can be null. This may indicate a bug in webkitpy too, but
262         WebKitTestRunner should handle this situation nicely, there is nothing intrinsically
263         wrong with opening and immediately closing it.
264
265 2015-09-18  Daniel Bates  <dabates@apple.com>
266
267         isGitSVNDirectory() returns true when Git is not installed
268         https://bugs.webkit.org/show_bug.cgi?id=149351
269
270         Reviewed by Alexey Proskuryakov.
271
272         Fixes an issue where VCSUtils::isGitSVNDirectory() returns true for any arbitrary directory if
273         Git is not installed on the machine.
274
275         * Scripts/VCSUtils.pm:
276         (isGitSVNDirectory): Ensure that `git config --get svn-remote.svn.fetch 2>& 1` exits with
277         status code 0 (success).
278
279 2015-09-18  Alex Christensen  <achristensen@webkit.org>
280
281         Prevent build-webkit from building four times on Windows 
282         https://bugs.webkit.org/show_bug.cgi?id=149336
283
284         Reviewed by Brent Fulgham.
285
286         * Scripts/build-webkit:
287         Move the Windows code out of the for loop iterating over each subdirectory to be build.
288         They're built all at once.
289         * Scripts/webkitdirs.pm:
290         (buildVisualStudioProject):
291         (cmakeGeneratedBuildfile):
292         Don't generate the Visual Studio solution if it already exists.
293         It will run CMake again if necessary.
294
295 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
296
297         [iOS WK2] WTR fails to set the key window in the UIKit sense
298         https://bugs.webkit.org/show_bug.cgi?id=149325
299
300         Reviewed by Tim Horton.
301
302         -[WebKitTestRunnerWindow isKeyWindow] just returned _platformWebView->windowIsKey().
303         This causes UIKit to bypass code that actually sets the key window, resulting in
304         [UIAppliation sharedApplication].keyWindow always being nil.
305
306         Fix by PlatformWebView::setWindowIsKey() actually call -makeKeyWindow, and having
307         -[WebKitTestRunnerWindow isKeyWindow] call super.
308
309         * WebKitTestRunner/PlatformWebView.h:
310         (WTR::PlatformWebView::setWindowIsKey): Deleted.
311         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
312         (WTR::PlatformWebView::setWindowIsKey):
313         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
314         (WTR::PlatformWebView::setWindowIsKey):
315         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
316         (-[WebKitTestRunnerWindow isKeyWindow]):
317         (WTR::PlatformWebView::PlatformWebView):
318         (WTR::PlatformWebView::~PlatformWebView):
319         (WTR::PlatformWebView::setWindowIsKey):
320         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
321         (WTR::PlatformWebView::setWindowIsKey):
322
323 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
324
325         [iOS WK2] When loading viewport tests, use the normal web page viewport configuration
326         https://bugs.webkit.org/show_bug.cgi?id=149321
327
328         Reviewed by Tim Horton.
329         
330         InjectedBundlePage::platformDidStartProvisionalLoadForFrame() unconditionally 
331         enabled the "testing" viewport configuration, which disables page scaling.
332         
333         If we're running viewport tests, we want the normal web page configuration.
334         Do that by passing a flag in the dictionary sent to InjectedBundle::beginTesting(),
335         based on whether the test is in a "viewport" directory.
336
337         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
338         (WTR::InjectedBundle::beginTesting):
339         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
340         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame): Deleted.
341         * WebKitTestRunner/TestInvocation.cpp:
342         (WTR::TestInvocation::shouldLogFrameLoadDelegates):
343         (WTR::TestInvocation::shouldLogHistoryClientCallbacks):
344         (WTR::TestInvocation::shouldMakeViewportFlexible):
345         (WTR::TestInvocation::invoke):
346         * WebKitTestRunner/TestInvocation.h:
347         * WebKitTestRunner/ios/TestControllerIOS.mm:
348         (WTR::TestController::platformConfigureViewForTest):
349         (WTR::shouldMakeViewportFlexible): Deleted.
350
351 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
352
353         Give iOS WebKitTestRunner a launch storyboard
354         https://bugs.webkit.org/show_bug.cgi?id=149314
355
356         Reviewed by Dan Bates.
357         
358         Add a launch storyboard to iOS WebKitTestRunner so that Springboard recognizes
359         that it's been built for specific device configurations, and puts the window
360         at the top of the screen. This simplifies coordinate conversions in a future patch.
361
362         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
363         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist:
364         * WebKitTestRunner/ios/Launch.storyboard: Added.
365
366 2015-09-17  Myles C. Maxfield  <mmaxfield@apple.com>
367
368         Update licence in r189890
369         https://bugs.webkit.org/show_bug.cgi?id=149306
370
371         Reviewed by Dean Jackson.
372
373         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
374         * FontWithFeatures/FontWithFeatures/FontCreator.h:
375         * FontWithFeatures/FontWithFeatures/main.cpp:
376
377 2015-09-17  Mark Lam  <mark.lam@apple.com>
378
379         Add the ability to skip JIT stress tests in run-javascriptcore-tests.
380         https://bugs.webkit.org/show_bug.cgi?id=149285
381
382         Reviewed by Saam Barati.
383
384         Just need to add an option to pass --no-jit to run-jsc-stress-test.
385
386         * Scripts/run-javascriptcore-tests:
387         (runJSCStressTests):
388
389 2015-09-17  Alex Christensen  <achristensen@webkit.org>
390
391         Switch AppleWin build to use CMake
392         https://bugs.webkit.org/show_bug.cgi?id=149163
393
394         Reviewed by Brent Fulgham.
395
396         * Scripts/build-webkit:
397         * Scripts/run-api-tests:
398         (runTest):
399         (listAllTests):
400         (prepareEnvironmentForRunningTestTool):
401         (testToolPaths):
402         (testToolPath): Deleted.
403         Run the API tests as separate executables on Windows.
404         It used to be TestWebKitAPI.exe, and it is now TestWTF.exe, TestWebCore.exe, and TestWebKit.exe.
405         * Scripts/webkitdirs.pm:
406         (checkRequiredSystemConfig):
407         (jhbuildWrapperPrefixIfNeeded):
408         (generateBuildSystemFromCMakeProject):
409         Fix configuration quirks.
410
411 2015-09-17  Dean Johnson  <dean_johnson@apple.com>
412
413         Added toggle options for hiding and showing certain platform families on the dashboard.
414         https://bugs.webkit.org/show_bug.cgi?id=148403
415
416         Reviewed by David Kilzer.
417
418         This patch removes "hiddenPlatforms" from use in the code and local storage. We also removed
419         individual hide/show buttons for platforms because we've added toggle options to hide/show entire
420         families. Examples of these are "mac", "ios", and "linux". "Show All Platforms" was also removed
421         in lieu of an "all" button in the toggle menu.
422
423         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
424         (parsePlatformFamily): Helper function to parse out a platform family.
425         (initPlatformsByFamily): Initializes platformsByFamily, which organizes platforms on the
426         page by platformsByFamily[<family>] = <list of platforms belonging to that family>.
427         (updateToggleButtons): Updates the status of the toggle buttons.
428         (updateHiddenPlatforms): Changed to work with the new implementation of hiding/showing platforms.
429         (documentReady): Added creation of toggle buttons.
430         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
431         (unhiddenQueues): Updated to search by platform family instead of the individual platform name.
432         (documentReady): Changed hiddenPlatforms => hiddenPlatformFamilies.
433         (updateHiddenPlatforms): Deleted. After removing the individual hide button code, 
434         this did the exact same thing as the updateHiddenPlatforms in Scripts/Main.js so it was removed.
435         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
436         (QueueView): Updated to use hiddenPlatformFamilies.
437         (QueueView.prototype._updateHiddenState): Updated to use hiddenPlatformFamilies.
438         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
439         (Settings.prototype.toggleHiddenPlatformFamily): Renamed function and some variables.
440         (Settings.prototype.clearHiddenPlatformFamilies): Now uses hiddenPlatformFamilies for events.
441         (Settings.prototype.toggleHiddenPlatform): Deleted.
442         (Settings.prototype.clearHiddenPlatforms): Deleted.
443         (Settings.prototype.toggleShowPlatformFamily): Deleted.
444         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
445         (div.cellButton, div.accessibilityButton, div.platformFamilyToggleButton):
446         (div.cellButton.unhide, div.accessibilityButton.unhide, div.platformFamilyToggleButton.unhide):
447         (.settings-visible div.settingsWrapper.hide, .settings-visible div.settingsWrapper):
448         (table.queue-grid tr.headers th):
449         (div.settingsWrapper.hide):
450         (div.settingsWrapper):
451         (div.familyToggleWrapper):
452         (div.platformFamilyToggleButton):
453         (div.platformFamilyShowToggleButton:not(:last-child)):
454         (div.familyShown):
455         (div.accessibilityButton):
456         (div.cellButton, div.accessibilityButton): Added platformFamilyToggleButton class.
457         (div.cellButton.unhide, div.accessibilityButton.unhide): Added platformFamilyToggleButton class.
458         (.settings-visible div.accessibilityButton.hide, .settings-visible div.accessibilityButton.unhide): Added
459         platformFamilyToggleButton and settingsWrapper class.
460         (.accessibilityButton): Deleted.
461
462 2015-09-17  Tim Horton  <timothy_horton@apple.com>
463
464         Add a test ensuring that scrolling in the middle of a page can't start a swipe gesture
465         https://bugs.webkit.org/show_bug.cgi?id=148904
466
467         Reviewed by Myles Maxfield.
468
469         * WebKitTestRunner/TestController.cpp:
470         (WTR::parseBooleanTestHeaderValue):
471         (WTR::updateViewOptionsFromTestHeader):
472         Check for the key "useThreadedScrolling".
473         Add some code to check for "true" and "false" for boolean options.
474
475         (WTR::TestController::viewOptionsForTest):
476         Apply the test's overrides last, even after the platform's.
477
478 2015-09-16  Carlos Garcia Campos  <cgarcia@igalia.com>
479
480         printing does not use minimum page zoom factor
481         https://bugs.webkit.org/show_bug.cgi?id=108507
482
483         Reviewed by Darin Adler.
484
485         WebKitTestRunner always takes the snapshots from the UI process
486         (expect for IOS), so in the case of printing, the layout in the
487         web view is not the expected one. When printing, we need to take
488         the snapshot in the web process and ensure it's rendered with a
489         PrintContext.
490
491         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
492         (WTR::InjectedBundlePage::dump): When dumping pixels, pass
493         kWKSnapshotOptionsPrinting option to
494         WKBundlePageCreateSnapshotWithOptions() when printing. When not
495         printing, don't even create the snapshot, since it will be ignored
496         by the UI process that always creates its own from the WebView (expect for IOS platform)
497         * WebKitTestRunner/TestInvocation.cpp:
498         (WTR::TestInvocation::dumpResults): Use always the snapshot image
499         received from the web process if any when comparing pixel
500         results. Now we only receive a snapshot from the web process in
501         case of printing, or when platform is IOS. Otherwhise, generate
502         the snapshot from the WebView as usual.
503         * WebKitTestRunner/TestInvocation.h: Add SnapshotResultType enum
504         parameter to dumpPixelsAndCompareWithExpected, since the snapshot
505         is created by the caller now, but the CG implementation needs to
506         know if it's a Web or UI process snapshot.
507         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
508         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
509         cairo surface for the given image.
510         * WebKitTestRunner/cg/TestInvocationCG.cpp:
511         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
512         CGContext for the given image.
513
514 2015-09-16  Myles C. Maxfield  <mmaxfield@apple.com>
515
516         Create a font which can be used for testing font features
517         https://bugs.webkit.org/show_bug.cgi?id=149237
518
519         Reviewed by Simon Fraser.
520
521         This patch adds a new project in the Tools/ directory which generates a font which can
522         be used for testing font features. This is a standalone project consisting of two files:
523         1. A file which actually generates the byte vector representing the font. This file has
524         a single public function: std::vector<uint8_t> generateFont(). This file is not platform
525         specific, and only relies on the C++ STL.
526         2. A file with a main() which calls generateFont() and writes out the font, as well as
527         uses the font to render some demonstration text into a .png file. This file is platform
528         specific.
529
530         The font itself only supports the following characters:
531         ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz
532         However, the shape of these letters are either an X or a check mark.
533
534         The letter "A" always is a check mark.
535         The letter "B" always is an X.
536         Without any font features turned on, the rest of the letters are shown as X.
537
538         Each font feature has an letter associated with it. When the font feature is enabled,
539         that letter is shown as a check mark. For example, when "smcp" is enabled, "J" is shown
540         as a check mark.
541
542         Here are the mappings of font features to letters:
543         liga: C
544         clig: D
545         dlig: E
546         hlig: F
547         calt: G
548         subs: H
549         sups: I
550         smcp: J
551         c2sc: K
552         pcap: L
553         c2pc: M
554         unic: N
555         titl: O
556         onum: P
557         pnum: Q
558         tnum: R
559         frac: S
560         afrc: T
561         ordn: U
562         zero: V
563         hist: W
564         jp78: X
565         jp83: Y
566         jp90: Z
567         jp04: a
568         smpl: b
569         trad: c
570         fwid: d
571         pwid: e
572         ruby: f
573
574         * FontWithFeatures/FontWithFeatures.xcodeproj/project.pbxproj: Added.
575         * FontWithFeatures/FontWithFeatures/FontCreator.cpp: Added.
576         (integralLog2):
577         (roundDownToPowerOfTwo):
578         (isFourByteAligned):
579         (clampTo):
580         (append32):
581         (writeCFFEncodedNumber):
582         (CFFBuilder::CFFBuilder):
583         (CFFBuilder::takeResult):
584         (CFFBuilder::moveTo):
585         (CFFBuilder::lineTo):
586         (CFFBuilder::curveToCubic):
587         (CFFBuilder::closePath):
588         (CFFBuilder::writePoint):
589         (generateBoxCharString):
590         (generateCheckCharString):
591         (generateXCharString):
592         (charStringForGlyph):
593         (Generator::generate):
594         (Generator::Placeholder::Placeholder):
595         (Generator::Placeholder::populate):
596         (Generator::Placeholder::~Placeholder):
597         (Generator::placeholder):
598         (Generator::append16):
599         (Generator::append32):
600         (Generator::append32BitCode):
601         (Generator::overwrite16):
602         (Generator::overwrite32):
603         (Generator::appendCFFTable):
604         (Generator::appendSubstitutionSubtable):
605         (Generator::appendScriptSubtable):
606         (Generator::appendGSUBTable):
607         (Generator::appendOS2Table):
608         (Generator::appendFormat12CMAPTable):
609         (Generator::appendFormat4CMAPTable):
610         (Generator::appendCMAPTable):
611         (Generator::appendHEADTable):
612         (Generator::appendHHEATable):
613         (Generator::appendHMTXTable):
614         (Generator::appendMAXPTable):
615         (Generator::appendNAMETable):
616         (Generator::appendPOSTTable):
617         (Generator::calculateChecksum):
618         (Generator::appendTable):
619         (generateFont):
620         * FontWithFeatures/FontWithFeatures/FontCreator.h: Added.
621         * FontWithFeatures/FontWithFeatures/main.cpp: Added.
622         (drawTextWithFeature):
623         (main):
624
625 2015-09-16  Commit Queue  <commit-queue@webkit.org>
626
627         Unreviewed, rolling out r189875 and r189878.
628         https://bugs.webkit.org/show_bug.cgi?id=149235
629
630         cygwin cmake build not ready yet (Requested by alexchristensen
631         on #webkit).
632
633         Reverted changesets:
634
635         "Switch AppleWin build to use CMake"
636         https://bugs.webkit.org/show_bug.cgi?id=149163
637         http://trac.webkit.org/changeset/189875
638
639         "Cygwin build fix after r189875"
640         http://trac.webkit.org/changeset/189878
641
642 2015-09-16  Alex Christensen  <achristensen@webkit.org>
643
644         Cygwin build fix after r189875
645
646         * Scripts/build-webkit:
647         * Scripts/webkitdirs.pm:
648         (jhbuildWrapperPrefixIfNeeded):
649         (generateBuildSystemFromCMakeProject):
650         Make things work with cygwin and cmake.
651
652 2015-09-16  Alex Christensen  <achristensen@webkit.org>
653
654         Switch AppleWin build to use CMake
655         https://bugs.webkit.org/show_bug.cgi?id=149163
656
657         Reviewed by Brent Fulgham.
658
659         * Scripts/build-webkit:
660         Build with CMake.
661         * Scripts/run-api-tests:
662         (runTest):
663         (listAllTests):
664         (prepareEnvironmentForRunningTestTool):
665         (testToolPaths):
666         (testToolPath): Deleted.
667         Run the API tests as separate executables on Windows.
668         It used to be TestWebKitAPI.exe, and it is now TestWTF.exe, TestWebCore.exe, and TestWebKit.exe.
669
670 2015-09-16  Alexey Proskuryakov  <ap@apple.com>
671
672         Add newer build.webkit.org pages to robots.txt
673         https://bugs.webkit.org/show_bug.cgi?id=149219
674
675         Reviewed by Darin Adler.
676
677         Indexing bot watcher's dashboard can't be good.
678
679         * BuildSlaveSupport/build.webkit.org-config/public_html/robots.txt:
680
681 2015-09-16  Alex Christensen  <achristensen@webkit.org>
682
683         Rollout r189851 and 189853 because they didn’t actually fix the permissions issue
684
685         * BuildSlaveSupport/built-product-archive:
686         (unzipArchive):
687
688 2015-09-16  Csaba Osztrogonác  <ossy@webkit.org>
689
690         [EFL] Fix the help message of separated web process option of MiniBrowser
691         https://bugs.webkit.org/show_bug.cgi?id=149212
692
693         Reviewed by Gyuyoung Kim.
694
695         * MiniBrowser/efl/main.c:
696
697 2015-09-16  Alex Christensen  <achristensen@webkit.org>
698
699         Fix python syntax after r189851.
700
701         * BuildSlaveSupport/built-product-archive:
702         (unzipArchive):
703         For loops need a colon.
704
705 2015-09-15  Alex Christensen  <achristensen@webkit.org>
706
707         Fix Windows test bots after changing to non-cygwin build
708         https://bugs.webkit.org/show_bug.cgi?id=149196
709
710         Reviewed by Daniel Bates.
711
712         * BuildSlaveSupport/built-product-archive:
713         (unzipArchive):
714         Using different versions of python makes what I think is https://bugs.python.org/issue15795
715         prevent us from executing files from the archive on the test bots.
716
717 2015-09-15  Ryosuke Niwa  <rniwa@webkit.org>
718
719         Add ShadowRoot interface and Element.prototype.attachShadow
720         https://bugs.webkit.org/show_bug.cgi?id=149187
721
722         Reviewed by Antti Koivisto.
723
724         * Scripts/webkitperl/FeatureList.pm:
725
726 2015-09-15  Aakash Jain  <aakash_jain@apple.com>
727
728         Appscale queue status json output lacks bots
729         https://bugs.webkit.org/show_bug.cgi?id=149194
730         <rdar://problem/22171089>
731
732         Reviewed by Alexey Proskuryakov.
733
734         * QueueStatusServer/handlers/queuestatusjson.py:
735         (QueueStatusJSON._bots): Order the results by date so as to get latest events, this was default in AppEngine.
736         * QueueStatusServer/index.yaml: Index according to appscale requirements.
737
738 2015-09-15  Brent Fulgham  <bfulgham@apple.com>
739
740         [Win] Provide a means for viewing the layer tree
741         https://bugs.webkit.org/show_bug.cgi?id=149165
742
743         Reviewed by Simon Fraser.
744
745         Update MiniBrowser with a new Debug menu option that will
746         dump the current layer tree to the debug console.
747         
748         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc:
749         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h:
750         * MiniBrowser/win/Common.cpp:
751         (WndProc): Add handler for 'Print Layer Tree' menu option.
752         * MiniBrowser/win/MiniBrowser.cpp:
753         (MiniBrowser::printLayerTree): Added Handler.
754         * MiniBrowser/win/MiniBrowser.h:
755
756 2015-09-14  Myles C. Maxfield  <mmaxfield@apple.com>
757
758         WebKitTestRunner declarative language setting is broken for iOS
759         https://bugs.webkit.org/show_bug.cgi?id=149119
760
761         Unreviewed.
762
763         In all of the patches on webkit.org/b/189669, my patch to get this working on iOS was
764         lost in the final version which got committed. This simply implements the existing
765         OS X behavior on iOS.
766
767         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
768         (WTR::InjectedBundle::platformInitialize):
769
770 2015-09-14  Dewei Zhu  <dewei_zhu@apple.com>
771
772         Unreviewed, add myself to committers list.
773
774         * Scripts/webkitpy/common/config/contributors.json:
775
776 2015-09-12  Myles C. Maxfield  <mmaxfield@apple.com>
777
778         [Cocoa] Allow testing with the system language
779         https://bugs.webkit.org/show_bug.cgi?id=148671
780
781         Reviewed by Anders Carlsson and Alexey Proskuryakov.
782
783         React to tests marked with language=lang1,lang2,etc in their header.
784         Once this information is parsed, pass it to
785         WKContextConfigurationSetOverrideLanguages().
786
787         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
788         (WTR::InjectedBundle::platformInitialize): Don't clobber the language
789         list.
790         * WebKitTestRunner/TestController.cpp:
791         (WTR::TestController::createWebViewWithOptions): Call
792         WKContextConfigurationSetOverrideLanguages().
793         (WTR::updateTestOptionsFromTestHeader): Inspect the language option.
794         * WebKitTestRunner/TestOptions.h:
795         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
796         (WTR::PlatformWebView::viewSupportsOptions): Cause a differing language
797         option to restart the web process.
798         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
799         (WTR::PlatformWebView::viewSupportsOptions): Ditto.
800
801 2015-09-12  Myles C. Maxfield  <mmaxfield@apple.com>
802
803         [WKTR] Allow changing the WKContextConfiguration between successive tests
804         https://bugs.webkit.org/show_bug.cgi?id=148833
805
806         Reviewed by Tim Horton.
807
808         Previously, we were creating a single WKContext and it lived for the life of the entire test runner.
809         However, there are certain tests which require specifying options in this object. This patch makes
810         our existing code for recreating the test runner web view also recreate the WKContext.
811
812         As such, our options to the view are now options to the WKContextConfiguration. This patch renames the
813         class.
814
815         * WebKitTestRunner/ContextConfigurationOptions.h: Renamed from Tools/WebKitTestRunner/ViewOptions.h.
816         * WebKitTestRunner/PlatformWebView.h:
817         (WTR::PlatformWebView::options):
818         * WebKitTestRunner/TestController.cpp:
819         (WTR::TestController::initialize):
820         (WTR::TestController::generateContextConfiguration):
821         (WTR::TestController::generatePageConfiguration):
822         (WTR::TestController::createWebViewWithOptions):
823         (WTR::TestController::ensureViewSupportsOptionsForTest):
824         (WTR::updateContextConfigurationOptionsFromTestHeader):
825         (WTR::TestController::contextConfigurationOptionsForTest):
826         (WTR::TestController::platformCreateWebView):
827         (WTR::TestController::platformCreateOtherPage):
828         (WTR::updateViewOptionsFromTestHeader): Deleted.
829         (WTR::TestController::viewOptionsForTest): Deleted.
830         * WebKitTestRunner/TestController.h:
831         (WTR::TestController::injectedBundlePath):
832         (WTR::TestController::testPluginDirectory):
833         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
834         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
835         (WTR::TestController::platformCreateWebView):
836         (WTR::TestController::platformCreateOtherPage):
837         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
838         (WTR::PlatformWebView::PlatformWebView):
839         (WTR::PlatformWebView::viewSupportsOptions):
840         * WebKitTestRunner/efl/TestControllerEfl.cpp:
841         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
842         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
843         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
844         (WTR::PlatformWebView::PlatformWebView):
845         (WTR::PlatformWebView::viewSupportsOptions):
846         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
847         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
848         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
849         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
850         (WTR::PlatformWebView::PlatformWebView):
851         (WTR::PlatformWebView::viewSupportsOptions):
852         * WebKitTestRunner/ios/TestControllerIOS.mm:
853         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
854         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
855         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
856         (WTR::PlatformWebView::PlatformWebView):
857         (WTR::PlatformWebView::viewSupportsOptions):
858         * WebKitTestRunner/mac/TestControllerMac.mm:
859         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
860         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
861
862 2015-09-11  Michael Saboff  <msaboff@apple.com>
863
864         LayoutTestHelper crashes if a color profile isn't set for a 3rd party monitor
865         https://bugs.webkit.org/show_bug.cgi?id=149083
866
867         Reviewed by Alexey Proskuryakov.
868
869         Check to make sure that we have a valid factoryProfile CFDictionaryRef before using it.
870
871         * DumpRenderTree/mac/LayoutTestHelper.m:
872         (colorProfileURLForDisplay):
873
874 2015-09-11  Saam barati  <sbarati@apple.com>
875
876         There should be a defaultSpotCheck-like mode that doesn't run the MaximalFlushInsertionPhase in run-jsc-stress-tests
877         https://bugs.webkit.org/show_bug.cgi?id=149058
878
879         Reviewed by Geoffrey Garen.
880
881         * Scripts/run-jsc-stress-tests:
882
883 2015-09-10  Commit Queue  <commit-queue@webkit.org>
884
885         Unreviewed, rolling out r189595.
886         https://bugs.webkit.org/show_bug.cgi?id=149052
887
888         The tests still fail (Requested by ap on #webkit).
889
890         Reverted changeset:
891
892         "Spurious output on Windows tests: AQMEIOManager::FindIOUnit:
893         error -1"
894         https://bugs.webkit.org/show_bug.cgi?id=142929
895         http://trac.webkit.org/changeset/189595
896
897 2015-09-10  Alexey Proskuryakov  <ap@apple.com>
898
899         Spurious output on Windows tests: AQMEIOManager::FindIOUnit: error -1
900         https://bugs.webkit.org/show_bug.cgi?id=142929
901
902         Reviewed by Brent Fulgham.
903
904         Silence the logging. We'll track fixing the root cause in Radar.
905
906         * Scripts/webkitpy/port/mac.py:
907         (MacPort.stderr_patterns_to_strip): Added a FIXME.
908
909         * Scripts/webkitpy/port/win.py:
910         (WinPort.logging_patterns_to_strip): Added.
911
912 2015-09-09  Andy Estes  <aestes@apple.com>
913
914         [iOS] Teach run-webkit-tests how to parse simulator runtimes when version numbers contain a revision
915         https://bugs.webkit.org/show_bug.cgi?id=149022
916
917         Reviewed by Daniel Bates.
918
919         Simulator runtime versions can contain a revision number (e.g. 8.4.1), but the regex for matching runtimes
920         did not account for this.
921
922         * Scripts/webkitpy/xcode/simulator.py:
923         (Simulator): Optionally matched a revision at the end of a runtime version number.
924         * Scripts/webkitpy/xcode/simulator_unittest.py: Added a test.
925
926 2015-09-09  Andy Estes  <aestes@apple.com>
927
928         [iOS] Teach run-webkit-tests how to parse `simctl list` when a tvOS SDK is installed
929         https://bugs.webkit.org/show_bug.cgi?id=149029
930         <rdar://problem/22432624>
931
932         Reviewed by Daniel Bates.
933
934         * Scripts/webkitpy/xcode/simulator.py:
935         (Simulator): Taught to parse tvOS runtimes.
936         * Scripts/webkitpy/xcode/simulator_unittest.py: Added tests.
937
938 2015-09-09  Alexey Proskuryakov  <ap@apple.com>
939
940         Fix bit rot on bot watcher's dashboard page
941         https://bugs.webkit.org/show_bug.cgi?id=149012
942
943         Reviewed by Tim Horton.
944
945         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
946         The code path used by the metrics page was trying to add properties to an undefined.
947
948         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
949         Silence an expection that would occur when the step has no logs. This should never
950         happen, but it did (perhaps buildbot was misconfigured for a while).
951
952 2015-09-09  Alexey Proskuryakov  <ap@apple.com>
953
954         Update LayoutTestRelay xcconfig file.
955
956         Rubber-stamped by Dan Bernstein.
957
958         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
959
960 2015-09-09  Saam barati  <sbarati@apple.com>
961
962         DFG should have a debugging option that runs a phase that flushes all locals
963         https://bugs.webkit.org/show_bug.cgi?id=148916
964
965         Reviewed by Filip Pizlo.
966
967         * Scripts/run-jsc-stress-tests:
968
969 2015-09-09  Commit Queue  <commit-queue@webkit.org>
970
971         Unreviewed, rolling out r189530 and r189534.
972         https://bugs.webkit.org/show_bug.cgi?id=148996
973
974         Caused assertion failures on Yosemite (Requested by litherum
975         on #webkit).
976
977         Reverted changesets:
978
979         "[WKTR] Allow changing the WKContextConfiguration between
980         successive tests"
981         https://bugs.webkit.org/show_bug.cgi?id=148833
982         http://trac.webkit.org/changeset/189530
983
984         "[Cocoa] Fix the tests after r189530"
985         http://trac.webkit.org/changeset/189534
986
987 2015-09-08  Myles C. Maxfield  <mmaxfield@apple.com>
988
989         [Cocoa] Fix the tests after r189530
990
991         Unreviewed.
992
993         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
994         (WTR::initializeWebViewConfiguration):
995
996 2015-09-08  Myles C. Maxfield  <mmaxfield@apple.com>
997
998         [WKTR] Allow changing the WKContextConfiguration between successive tests
999         https://bugs.webkit.org/show_bug.cgi?id=148833
1000
1001         Reviewed by Tim Horton.
1002
1003         Previously, we were creating a single WKContext and it lived for the life of the entire test runner.
1004         However, there are certain tests which require specifying options in this object. This patch makes
1005         our existing code for recreating the test runner web view also recreate the WKContext.
1006
1007         As such, our options to the view are now options to the WKContextConfiguration. This patch renames the
1008         class.
1009
1010         * WebKitTestRunner/ContextConfigurationOptions.h: Renamed from Tools/WebKitTestRunner/ViewOptions.h.
1011         * WebKitTestRunner/PlatformWebView.h:
1012         (WTR::PlatformWebView::options):
1013         * WebKitTestRunner/TestController.cpp:
1014         (WTR::TestController::initialize):
1015         (WTR::TestController::generateContextConfiguration):
1016         (WTR::TestController::generatePageConfiguration):
1017         (WTR::TestController::createWebViewWithOptions):
1018         (WTR::TestController::ensureViewSupportsOptionsForTest):
1019         (WTR::updateContextConfigurationOptionsFromTestHeader):
1020         (WTR::TestController::contextConfigurationOptionsForTest):
1021         (WTR::TestController::platformCreateWebView):
1022         (WTR::TestController::platformCreateOtherPage):
1023         (WTR::updateViewOptionsFromTestHeader): Deleted.
1024         (WTR::TestController::viewOptionsForTest): Deleted.
1025         * WebKitTestRunner/TestController.h:
1026         (WTR::TestController::injectedBundlePath):
1027         (WTR::TestController::testPluginDirectory):
1028         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1029         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1030         (WTR::TestController::platformCreateWebView):
1031         (WTR::TestController::platformCreateOtherPage):
1032         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1033         (WTR::PlatformWebView::PlatformWebView):
1034         (WTR::PlatformWebView::viewSupportsOptions):
1035         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1036         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
1037         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
1038         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1039         (WTR::PlatformWebView::PlatformWebView):
1040         (WTR::PlatformWebView::viewSupportsOptions):
1041         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1042         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
1043         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
1044         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1045         (WTR::PlatformWebView::PlatformWebView):
1046         (WTR::PlatformWebView::viewSupportsOptions):
1047         * WebKitTestRunner/ios/TestControllerIOS.mm:
1048         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
1049         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
1050         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1051         (WTR::PlatformWebView::PlatformWebView):
1052         (WTR::PlatformWebView::viewSupportsOptions):
1053         * WebKitTestRunner/mac/TestControllerMac.mm:
1054         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
1055         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
1056
1057 2015-09-08  Daniel Bates  <dabates@apple.com>
1058
1059         [Mac] Expose Enable/Disable Accelerated Drawing in MiniBrowser
1060         https://bugs.webkit.org/show_bug.cgi?id=148980
1061
1062         Reviewed by Alexey Proskuryakov.
1063
1064         Add setting to enable/disable accelerated drawing so as to support testing
1065         this feature in MiniBrowser on Mac.
1066
1067         * MiniBrowser/mac/SettingsController.h:
1068         * MiniBrowser/mac/SettingsController.m:
1069         (-[SettingsController _populateMenu]): Add menu item.
1070         (-[SettingsController validateMenuItem:]): Update setting when menu item is toggled.
1071         (-[SettingsController toggleAcceleratedDrawingEnabled:]): Added.
1072         (-[SettingsController acceleratedDrawingEnabled]): Added.
1073         * MiniBrowser/mac/WK1BrowserWindowController.m:
1074         (-[WK1BrowserWindowController didChangeSettings]): Apply setting in WebKit1.
1075         * MiniBrowser/mac/WK2BrowserWindowController.m:
1076         (-[WK2BrowserWindowController didChangeSettings]): Apply setting in WebKit2.
1077
1078 2015-09-08  Jason Marcell  <jmarcell@apple.com>
1079
1080         Unreviewed. Added myself as a commiter in contributors.json.
1081
1082         * Scripts/webkitpy/common/config/contributors.json:
1083
1084 2015-09-08  Keith Miller  <keith_miller@apple.com>
1085
1086         Unreviewed, added myself to the list of contributors.
1087
1088         * Scripts/webkitpy/common/config/contributors.json:
1089
1090 2015-09-08  Daniel Bates  <dabates@apple.com>
1091
1092         Dashboard: Remove use of z-index for ring overlay; use DOM ordering
1093         https://bugs.webkit.org/show_bug.cgi?id=148921
1094
1095         Reviewed by Alexey Proskuryakov.
1096
1097         The ring image is positioned above the platform icon in markup and we specify the CSS
1098         property z-index for the ring image so that it is painted on top of the platform icon
1099         instead of below it (by DOM ordering). Instead we can take advantage of the transparency
1100         of the ring image, switch the order of these DOM elements and remove the use of the CSS
1101         property z-index to achieve a similar effect.
1102
1103         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1104         (documentReady): Create the platform icon image element before the ring image such that
1105         the ring image is painted on top of the platform icon.
1106         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1107         (table.queue-grid td.logo img.ring): Removed property z-index.
1108
1109 2015-09-08  Daniel Bates  <dabates@apple.com>
1110
1111         Dashboard: Remove duplicate gear icon data URLs
1112         https://bugs.webkit.org/show_bug.cgi?id=148920
1113
1114         Reviewed by Alexey Proskuryakov.
1115
1116         Currently we duplicate the SVG data URL for the gear icon up to its fill color in the CSS property
1117         background-image associated with each of the three gear icon states: collapsed (.settings), hover
1118         (.settings:hover), and expanded (.settings-visible .settings). Instead we should use the gear icon
1119         as a mask and make use of the CSS background-color to define the fill color for each of these three
1120         states.
1121
1122         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1123         (.settings): Use gear icon as mask and define CSS background-color for collapsed state. 
1124         (.settings:hover): Override CSS background-color for hover state.
1125         (.settings-visible .settings): Override CSS background-color for expanded state.
1126
1127 2015-09-07  Andy Estes  <aestes@apple.com>
1128
1129         [Mac] DebugRelease builds should link against libWebKitSystemInterfaceElCapitan.a on 10.11
1130         https://bugs.webkit.org/show_bug.cgi?id=148946
1131         <rdar://problem/22603981>
1132
1133         Reviewed by Dan Bernstein.
1134
1135         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1136         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1137
1138 2015-09-07  Hunseop Jeong  <hs85.jeong@samsung.com>
1139
1140         [EFL] Many of the css3/device-adapt/* tests failed after r188548.
1141         https://bugs.webkit.org/show_bug.cgi?id=148927
1142
1143         Reviewed by Csaba Osztrogonác.
1144
1145         device-adapt/* tests need the fixedLayout option but useFixedLayout option is
1146         overwritten by updatePlatformSpecificViewOptionsForTest after r188548.
1147
1148         * WebKitTestRunner/TestController.cpp:
1149         (WTR::shouldUseFixedLayout): Removed the unnecessary indentations.
1150         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1151         (WTR::shouldUseFixedLayout): Return true if the test is related with 'device-adapt'.
1152
1153 2015-09-07  Andy Estes  <aestes@apple.com>
1154
1155         Fix the Production build after r189455.
1156
1157         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Somehow I added the All target using the
1158         In-App Purchase template instead of the Aggregate template. Whoops.
1159
1160 2015-09-06  Andy Estes  <aestes@apple.com>
1161
1162         WebKit.xcworkspace should be be able to build iOS platforms
1163         https://bugs.webkit.org/show_bug.cgi?id=148881
1164
1165         Reviewed by Daniel Bates.
1166
1167         Since we don't want to create platform-specific schemes, all projects in the workspace's schemes need to build
1168         for all supported platforms.
1169
1170         * MiniBrowser/Configurations/Base.xcconfig: Included iphoneos and iphonesimulator in SUPPORTED_PLATFORMS.
1171         * MiniBrowser/Configurations/MiniBrowser.xcconfig: Excluded all source files on iOS, and linked Cocoa and WebKit on Mac.
1172         * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig: Ditto.
1173         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Stopped linking frameworks in Link Binaries With Libraries.
1174
1175 2015-09-06  Andy Estes  <aestes@apple.com>
1176
1177         WebKitTestRunner should build for iOS using the default target
1178         https://bugs.webkit.org/show_bug.cgi?id=148918
1179
1180         Reviewed by Daniel Bates.
1181
1182         When WebKitTestRunner was ported to iOS, a separate target (WebKitTestRunnerApp) was created for building the
1183         iOS variant. This is annoying because (1) all tools that invoke xcodebuild need to be taught to build this
1184         non-default target, and (2) a single Xcode scheme cannot be used to build both Mac and iOS variants.
1185
1186         This change adds a new default target (All) and makes it work for both Mac and iOS. Files that were built for
1187         both WebKitTestRunner and WebKitTestRunnerApp are now built in a static library target (WebKitTestRunner (Library)),
1188         and both apps now link this library. Files that are specific to Mac or iOS are excluded on the other platform.
1189         WebKitTestRunnerApp.app (which should be renamed to WebKitTestRunner.app) is skipped when installing on Mac, and
1190         WebKitTestRunner is skipped when installing on iOS.
1191
1192         The target dependency graph now looks like this:
1193
1194             All
1195                 WebKitTestRunnerApp
1196                     WebKitTestRunner (Library)
1197                         WebKitTestRunnerInjectedBundle
1198                             Derived Sources
1199                 WebKitTestRunner
1200                     WebKitTestRunner (Library)
1201                         WebKitTestRunnerInjectedBundle
1202                             Derived Sources
1203
1204         * Scripts/build-webkit: Stopped building the WebKitTestRunnerApp target on iOS.
1205         * Scripts/build-webkittestrunner: Ditto.
1206         * WebKitTestRunner/Configurations/Base.xcconfig: Set SUPPORTED_PLATFORMS to macosx, iphoneos, and iphonesimulator.
1207         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Set INSTALL_PATH here since it is the same for all targets.
1208         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Stopped setting INSTALL_PATH.
1209         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Moved frameworks from the build phase to here,
1210         excluded iOS-only files, and skipped installing on iOS.
1211         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Moved frameworks from the build phase to here,
1212         excluded Mac-only files, and skipped installing on Mac.
1213         * WebKitTestRunner/Configurations/WebKitTestRunnerLibrary.xcconfig: Skipped installing always.
1214         * WebKitTestRunner/Makefile: Stopped building the WebKitTestRunnerApp target on iOS.
1215         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added new targets, removed frameworks from
1216         Link Binary With Libraries builds phases, moved common files to the WebKitTestRunner (Library) target, and added
1217         new configuration files.
1218
1219 2015-09-05  Joseph Pecoraro  <pecoraro@apple.com>
1220
1221         Web Inspector: Improve prepare-ChangeLog for multiple cases
1222         https://bugs.webkit.org/show_bug.cgi?id=148875
1223
1224         Reviewed by Timothy Hatcher.
1225
1226         * Scripts/prepare-ChangeLog:
1227         (get_function_line_ranges_for_javascript):
1228         - We were ignoring everything inside of an anonymous function expression,
1229           such as (function(){ ... }), which made InjectedScriptSource produce nothing.
1230           Better handle this by inserting a few tweaks.
1231         - Allow method syntax outside of classes as long as they are at the global level.
1232         - Avoid treating "get" and "set" as getter/setter functions in bad contexts.
1233
1234         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt:
1235         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests.js:
1236         (Foo.prototype.method1):
1237         (Foo.prototype.method2):
1238         (Foo.prototype.method3.innerFunction):
1239         (Foo.prototype.method3):
1240         (insideGlobalAnonymousFunctionExpression):
1241         (foo.insideGlobalFunctionExpression):
1242         (IssueWithMapGetAndSet.prototype.method1.nestedFunctionInsideMethod1):
1243         (IssueWithMapGetAndSet.prototype.method1):
1244         (IssueWithMapGetAndSet.prototype.method2):
1245         (IssueWithMapGetAndSet.prototype.method3):
1246         (IssueWithMapGetAndSet):
1247
1248 2015-09-05  Yusuke Suzuki  <utatane.tea@gmail.com>
1249
1250         [ES6] Enable ES6 Module in JSC shell by default
1251         https://bugs.webkit.org/show_bug.cgi?id=148689
1252
1253         Reviewed by Geoffrey Garen.
1254
1255         * Scripts/run-javascriptcore-tests:
1256         (runJSCStressTests):
1257         * Scripts/run-jsc-stress-tests:
1258
1259 2015-09-04  Basile Clement  <basile_clement@apple.com>
1260
1261         Unreviewed, change my email address.
1262
1263         * Scripts/webkitpy/common/config/contributors.json:
1264
1265 2015-09-04  Beth Dakin  <bdakin@apple.com>
1266
1267         Should have a test to make sure links don't navigate after a cancelled force 
1268         click
1269         https://bugs.webkit.org/show_bug.cgi?id=148846
1270
1271         Reviewed by Tim Horton.
1272
1273         New EventSender function for a started then cancelled force click.
1274         * WebKitTestRunner/EventSenderProxy.h:
1275         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
1276         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1277         (WTR::EventSendingController::mouseForceClick):
1278         (WTR::EventSendingController::startAndCancelMouseForceClick):
1279         (WTR::EventSendingController::mouseForceDown):
1280         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1281         * WebKitTestRunner/TestController.cpp:
1282         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
1283         * WebKitTestRunner/mac/EventSenderProxy.mm:
1284         (WTR::EventSenderProxy::mouseForceClick):
1285         (WTR::EventSenderProxy::startAndCancelMouseForceClick):
1286         (WTR::EventSenderProxy::mouseForceDown):
1287         (WTR::EventSenderProxy::mouseMoveTo):
1288
1289 2015-09-04  Tim Horton  <timothy_horton@apple.com>
1290
1291         Add a test for r179736 (programmatic navigation during swipe causing a crash)
1292         https://bugs.webkit.org/show_bug.cgi?id=148830
1293
1294         Reviewed by Beth Dakin.
1295
1296         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1297         (WTR::InjectedBundle::beginTesting):
1298         Make sure that TestRunner callbacks don't leak between tests!
1299
1300 2015-09-04  Anders Carlsson  <andersca@apple.com>
1301
1302         It should be possible to pass relative HTTP test paths to DumpRenderTree
1303         https://bugs.webkit.org/show_bug.cgi?id=148825
1304         <rdar://problem/22583866>
1305
1306         Reviewed by Tim Horton.
1307
1308         Convert the path to an absolute path if needed.
1309
1310         * DumpRenderTree/mac/DumpRenderTree.mm:
1311         (computeTestURL):
1312
1313 2015-09-04  Jason Marcell  <jmarcell@apple.com>
1314
1315         Fix Swift unit tests for prepare-ChangeLog.
1316         https://bugs.webkit.org/show_bug.cgi?id=148817
1317
1318         Reviewed by Alexey Proskuryakov.
1319
1320         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/swift_unittests-expected.txt: Fixed
1321         Swift unit tests for prepare-ChangeLog.
1322
1323 2015-09-04  Lucas Forschler  <lforschler@apple.com>
1324
1325         Modifications to the webkit-nightly logic.
1326         
1327         * WebKitLauncher/WebKitNightlyEnablerSparkle.m:
1328         (updateAlertPanel):
1329         * WebKitLauncher/main.m:
1330         (displayErrorAndQuit):
1331
1332 2015-09-04  Beth Dakin  <bdakin@apple.com>
1333
1334         Speculative build fix.
1335
1336         * WebKitTestRunner/mac/EventSenderProxy.mm:
1337
1338 2015-09-04  Brian Burg  <bburg@apple.com>
1339
1340         Web Inspector: InspectorController should support multiple frontend channels
1341         https://bugs.webkit.org/show_bug.cgi?id=148538
1342
1343         Reviewed by Joseph Pecoraro.
1344
1345         InspectorClients must explicitly disconnect their frontend channel(s) from the
1346         inspected page's InspectorController.
1347
1348         To make this possible, DumpRenderTree should not destroy non-primary views until
1349         it has tried to close any abandoned Web Inspector instances. Performing teardown
1350         in the reverse order prevents disconnection of the frontend channel because that
1351         prematurely destroys the inspector frontend client.
1352
1353         * DumpRenderTree/mac/DumpRenderTree.mm:
1354         (runTest):
1355         * DumpRenderTree/win/DumpRenderTree.cpp:
1356         (runTest):
1357
1358 2015-09-04  Beth Dakin  <bdakin@apple.com>
1359
1360         Need to be able to test default behaviors on force click
1361         https://bugs.webkit.org/show_bug.cgi?id=148758
1362
1363         Reviewed by Tim Horton.
1364
1365         This patch adds a new eventSender method to do a full, completed force click, 
1366         and it re-works all of the existing force methods to dispatch their events in 
1367         such a way that they will trigger the NSImmediateAction gesture recognizer. 
1368         To do this, first we need to send the events to the app rather than straight 
1369         to the view, and also needed to tweak some state and send the events in a 
1370         delayed fashion.
1371
1372         New public function mouseForceClick() and private helper functions to make 
1373         NSEvents.
1374         * WebKitTestRunner/EventSenderProxy.h:
1375
1376         New public function mouseForceClick().
1377         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
1378         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1379         (WTR::EventSendingController::mouseMoveTo):
1380         (WTR::EventSendingController::mouseForceClick):
1381         (WTR::EventSendingController::mouseForceDown):
1382         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1383         * WebKitTestRunner/TestController.cpp:
1384         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
1385
1386         initPressureEventAtLocation needs to take a stageTransition and a window.
1387         * WebKitTestRunner/mac/EventSenderProxy.mm:
1388         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
1389         (-[EventSenderSyntheticEvent stageTransition]):
1390         (-[EventSenderSyntheticEvent timestamp]):
1391         (-[EventSenderSyntheticEvent _cgsEventRecord]):
1392         (-[EventSenderSyntheticEvent window]):
1393
1394         In order to enter the gesture recognizer, we need to start with a mouse down 
1395         that has a NSEventMaskPressure modifier.
1396         (WTR::EventSenderProxy::sendMouseDownToStartPressureEvents):
1397
1398         This ensures that the events queue properly for the force monitor in AppKit.
1399         (WTR::spinRunLoopForForce):
1400
1401          We need to start the pressure change events with a began.
1402         (WTR::EventSenderProxy::beginPressureEvent):
1403
1404         These functions can be used to create the NSEvent for a pressure change every 
1405         time we need one.
1406         (WTR::EventSenderProxy::pressureChangeEvent):
1407
1408         Send the right series of events to emulate a full, completed force click.
1409         (WTR::EventSenderProxy::mouseForceClick):
1410
1411         Use all of the new things for these existing functions.
1412         (WTR::EventSenderProxy::mouseForceDown):
1413         (WTR::EventSenderProxy::mouseForceUp):
1414         (WTR::EventSenderProxy::mouseForceChanged):
1415
1416         Set NSFakeForceTouchDevice to YES.
1417         * WebKitTestRunner/mac/main.mm:
1418         (setDefaultsToConsistentValuesForTesting):
1419
1420 2015-09-04  Jason Marcell  <jmarcell@apple.com>
1421
1422         prepare-ChangeLog needs to know how to parse Swift files.
1423         https://bugs.webkit.org/show_bug.cgi?id=148784
1424         <rdar://problem/22510062>
1425
1426         Reviewed by Darin Adler.
1427
1428         * Scripts/prepare-ChangeLog:
1429         (get_function_line_ranges): Added entry for get_function_line_ranges_for_swift.
1430         (get_function_line_ranges_for_swift): Added function that knows how to parse Swift code.
1431         (parseSwiftFunctionArgs): Added function that knows how to parse Swift function arguments.
1432         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl: Added.
1433         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/swift_unittests-expected.txt: Ditto.
1434         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/swift_unittests.swift: Ditto.
1435         (freeFunction): Ditto.
1436         (MyClass.function): Ditto.
1437         (MyClass.functionWithArgument(_:)): Ditto.
1438         (MyClass.functionWithMoreArguments(_:arg2:)): Ditto.
1439         (MyClass.functionWithNamedFirstArgument(argument:)): Ditto.
1440         (MyClass.functionWithNamedFirstAndSecondArgument(first:second:)): Ditto.
1441         (MyClass.classFunction): Ditto.
1442         (MyClass.readWriteComputedVariable): Ditto.
1443         (MyClass.readOnlyComputedVariable): Ditto.
1444
1445 2015-09-04  Ryosuke Niwa  <rniwa@webkit.org>
1446
1447         Import css/css-color-3
1448         https://bugs.webkit.org/show_bug.cgi?id=148803
1449
1450         Reviewed by Chris Dumez.
1451
1452         Fixed a bug that the imported reference files used the same extention as tests.
1453         This would result in parsing errors if the tests were XML and references were HTML and vice versa.
1454
1455         * Scripts/webkitpy/w3c/test_importer.py:
1456         (TestImporter.find_importable_tests):
1457
1458 2015-09-03  Commit Queue  <commit-queue@webkit.org>
1459
1460         Unreviewed, rolling out r189338.
1461         https://bugs.webkit.org/show_bug.cgi?id=148785
1462
1463         Caused tons of crashes (Requested by cdumez on #webkit).
1464
1465         Reverted changeset:
1466
1467         "Web Inspector: InspectorController should support multiple
1468         frontend channels"
1469         https://bugs.webkit.org/show_bug.cgi?id=148538
1470         http://trac.webkit.org/changeset/189338
1471
1472 2015-09-03  Brian Burg  <bburg@apple.com>
1473
1474         Web Inspector: InspectorController should support multiple frontend channels
1475         https://bugs.webkit.org/show_bug.cgi?id=148538
1476
1477         Reviewed by Joseph Pecoraro.
1478
1479         InspectorClients must explicitly disconnect their frontend channel(s) from the
1480         inspected page's InspectorController.
1481
1482         To make this possible, DumpRenderTree should not destroy non-primary views until
1483         it has tried to close any abandoned Web Inspector instances. Performing teardown
1484         in the reverse order prevents disconnection of the frontend channel because that
1485         prematurely destroys the inspector frontend client.
1486
1487         * DumpRenderTree/mac/DumpRenderTree.mm:
1488         (runTest):
1489         * DumpRenderTree/win/DumpRenderTree.cpp:
1490         (runTest):
1491
1492 2015-09-03  Timothy Hatcher  <timothy@apple.com>
1493
1494         Update WebKit nightly icon to be more like Safari
1495         https://bugs.webkit.org/show_bug.cgi?id=148768
1496
1497         Reviewed by Joseph Pecoraro.
1498
1499         * WebKitLauncher/webkit.icns:
1500
1501 2015-09-03  Geoffrey Garen  <ggaren@apple.com>
1502
1503         JavaScriptCore should have some ES6 conformance tests
1504         https://bugs.webkit.org/show_bug.cgi?id=148771
1505
1506         Reviewed by Chris Dumez.
1507
1508         * Scripts/run-javascriptcore-tests:
1509         (runJSCStressTests): Added es6 as a test suite.
1510
1511         * Scripts/run-jsc-stress-tests: Added es6 as a test suite.
1512
1513         Some of these tests currently fail, so I also added a way to expect
1514         failure for now. We'll migrate failing tests to expected passes as we
1515         fix them.
1516
1517 2015-09-03  Tim Horton  <timothy_horton@apple.com>
1518
1519         Add a test for swipe-start hysteresis
1520         https://bugs.webkit.org/show_bug.cgi?id=148756
1521
1522         Reviewed by Anders Carlsson.
1523
1524         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1525         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1526         (WTR::cacheTestRunnerCallback):
1527         (WTR::TestRunner::clearTestRunnerCallbacks):
1528         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1529         Make sure that we log if a client tries to install a callback twice
1530         (since we use .add, the second call would not work).
1531
1532         Also, add clearTestRunnerCallbacks so tests can swap out installed
1533         callbacks.
1534
1535 2015-09-03  Anders Carlsson  <andersca@apple.com>
1536
1537         DumpRenderTree should automatically compute HTTP URLs for HTTP tests
1538         https://bugs.webkit.org/show_bug.cgi?id=148746
1539         rdar://problem/22568073
1540
1541         Reviewed by Tim Horton.
1542
1543         * DumpRenderTree/mac/DumpRenderTree.mm:
1544         (computeTestURL):
1545         Compute the test URL from the passed in path or URL. Special-case paths that contain /LayoutTests/http/tests. 
1546
1547         (runTest):
1548         Call computeTestURL.
1549
1550         (testPathFromURL):
1551         Get rid of this; computeTestURL does this for us now.
1552
1553         * Scripts/webkitpy/port/driver.py:
1554         (Driver._command_from_driver_input):
1555         Don't convert HTTP test paths to URLS before passing them to DumpRenderTree on Mac. That's handled by DRT itself now.
1556
1557 2015-09-03  Tim Horton  <timothy_horton@apple.com>
1558
1559         Swipe tests fail on Mavericks
1560         https://bugs.webkit.org/show_bug.cgi?id=148752
1561
1562         Reviewed by Beth Dakin.
1563
1564         * WebKitTestRunner/mac/EventSenderProxy.mm:
1565
1566 2015-09-03  Tim Horton  <timothy_horton@apple.com>
1567
1568         Fix the 32-bit build
1569
1570         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1571         (WTR::PlatformWebView::setNavigationGesturesEnabled):
1572
1573 2015-09-03  Tim Horton  <timothy_horton@apple.com>
1574
1575         Remove some logging that wasn't meant to be in the tree
1576
1577         * WebKitTestRunner/mac/EventSenderProxy.mm:
1578         (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
1579
1580 2015-09-03  Tim Horton  <timothy_horton@apple.com>
1581
1582         [Mac] Add support for testing swipes
1583         https://bugs.webkit.org/show_bug.cgi?id=148700
1584
1585         Reviewed by Beth Dakin.
1586
1587         * WebKitTestRunner/EventSenderProxy.h:
1588         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
1589         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1590         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1591         (WTR::cgEventPhaseFromString):
1592         (WTR::cgEventMomentumPhaseFromString):
1593         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
1594         (WTR::EventSendingController::swipeGestureWithWheelAndMomentumPhases):
1595         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1596         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1597         (WTR::InjectedBundle::didReceiveMessageToPage):
1598         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1599         (WTR::TestRunner::installDidBeginSwipeCallback):
1600         (WTR::TestRunner::installWillEndSwipeCallback):
1601         (WTR::TestRunner::installDidEndSwipeCallback):
1602         (WTR::TestRunner::installDidRemoveSwipeSnapshotCallback):
1603         (WTR::TestRunner::callDidBeginSwipeCallback):
1604         (WTR::TestRunner::callWillEndSwipeCallback):
1605         (WTR::TestRunner::callDidEndSwipeCallback):
1606         (WTR::TestRunner::callDidRemoveSwipeSnapshotCallback):
1607         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1608         * WebKitTestRunner/TestController.cpp:
1609         (WTR::TestController::createOtherPage):
1610         (WTR::TestController::createWebViewWithOptions):
1611         (WTR::TestController::didReceiveMessageFromInjectedBundle):
1612         (WTR::TestController::didBeginNavigationGesture):
1613         (WTR::TestController::willEndNavigationGesture):
1614         (WTR::TestController::didEndNavigationGesture):
1615         (WTR::TestController::didRemoveNavigationGestureSnapshot):
1616         * WebKitTestRunner/TestController.h:
1617         * WebKitTestRunner/TestInvocation.cpp:
1618         (WTR::TestInvocation::didBeginSwipe):
1619         (WTR::TestInvocation::willEndSwipe):
1620         (WTR::TestInvocation::didEndSwipe):
1621         (WTR::TestInvocation::didRemoveSwipeSnapshot):
1622         * WebKitTestRunner/TestInvocation.h:
1623         Add callbacks when navigation gestures didBegin/willEnd/didEnd, and
1624         when the snapshot is removed.
1625
1626         Add swipeGestureWithWheelAndMomentumPhases, just like the equivalent
1627         mouseScrollBy function.
1628
1629         * WebKitTestRunner/mac/EventSenderProxy.mm:
1630         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:phase:time:eventNumber:]):
1631         (-[EventSenderSyntheticEvent type]):
1632         (-[EventSenderSyntheticEvent subtype]):
1633         (-[EventSenderSyntheticEvent locationInWindow]):
1634         (-[EventSenderSyntheticEvent location]):
1635         (-[EventSenderSyntheticEvent momentumPhase]):
1636         (-[EventSenderSyntheticEvent _isTouchesEnded]):
1637         (-[EventSenderSyntheticEvent _cgsEventRecord]):
1638         Rename EventSenderPressureEvent to EventSenderSyntheticEvent and add some
1639         more adjustable values.
1640
1641         (WTR::EventSenderProxy::mouseForceDown):
1642         (WTR::EventSenderProxy::mouseForceUp):
1643         (WTR::EventSenderProxy::mouseForceChanged):
1644         Adopt EventSenderSyntheticEvent.
1645
1646         (WTR::nsEventPhaseFromCGEventPhase):
1647         (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
1648         Make use of EventSenderSyntheticEvent to synthesize swipe gesture events.
1649
1650         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1651         (WTR::PlatformWebView::PlatformWebView):
1652         Enable swipe.
1653
1654 2015-09-03  Myles C. Maxfield  <mmaxfield@apple.com>
1655
1656         [WK2] Allow tagging tests with metadata which needs to be known at web process creation time
1657         https://bugs.webkit.org/show_bug.cgi?id=148723
1658
1659         Reviewed by Anders Carlsson.
1660
1661         * WebKitTestRunner/TestController.cpp:
1662         (WTR::testPath):
1663         (WTR::updateViewOptionsFromTestHeader):
1664         (WTR::TestController::viewOptionsForTest):
1665
1666 2015-09-03  Lucas Forschler  <lforschler@apple.com>
1667
1668         Test commit.
1669
1670 2015-09-02  Tim Horton  <timothy_horton@apple.com>
1671
1672         Add a modern API way to know that the navigation gesture snapshot was removed, for WebKitTestRunner
1673         https://bugs.webkit.org/show_bug.cgi?id=148693
1674
1675         Reviewed by Anders Carlsson.
1676
1677         * WebKitTestRunner/TestController.cpp:
1678         (WTR::TestController::createOtherPage):
1679         (WTR::TestController::createWebViewWithOptions):
1680
1681 2015-09-02  Carlos Garcia Campos  <cgarcia@igalia.com>
1682
1683         REGRESSION(r188548): Some tests crash after r188548 because injected bundle messages are received after the test finishes
1684         https://bugs.webkit.org/show_bug.cgi?id=148529
1685
1686         Reviewed by Darin Adler.
1687
1688         When there are pending EventSender messages after a test finishes,
1689         they could be processed in the main loop started by the
1690         resetStateToConsistentValues(), but the old EventSender has been
1691         replaced by a new one at that point. The new Eventsender can crash
1692         when processing messages that were sent to the old one. To avoid
1693         this, we return early when receiving an EventSender message and
1694         the TestController state is not RunningTest.
1695
1696         * WebKitTestRunner/TestController.cpp:
1697         (WTR::TestController::didReceiveKeyDownMessageFromInjectedBundle):
1698         (WTR::TestController::didReceiveMessageFromInjectedBundle):
1699
1700 2015-09-02  Carlos Garcia Campos  <cgarcia@igalia.com>
1701
1702         REGRESSION(r188548): TestController state is Resseting while tests are running after r188548
1703         https://bugs.webkit.org/show_bug.cgi?id=148528
1704
1705         Reviewed by Darin Adler.
1706
1707         Before r188548 resetStateToConsistentValues() was called in
1708         TestController::run(), before tests are run, but now it's called
1709         for every test in TestInvocation::invoke(), after m_status has
1710         changed to RunningTest.
1711
1712         * WebKitTestRunner/TestController.cpp:
1713         (WTR::TestController::resetStateToConsistentValues): Use
1714         TemporaryChange to reset m_state ot its previous value after reset
1715         is done.
1716
1717 2015-08-31  Jason Marcell  <jmarcell@apple.com>
1718
1719         Modify prepare-Changelog to be aware of files that are marked as tests as well as files
1720         that are marked as requiring corresponding tests.
1721         https://bugs.webkit.org/show_bug.cgi?id=148498
1722         <rdar://problem/21555314>
1723
1724         Reviewed by Dan Bernstein and David Kilzer.
1725
1726         * Scripts/prepare-ChangeLog: Added "attributeCache" to cache Subversion properties in order to
1727         simulate Git's attribute behevaior.
1728         (main): Added "requiresTests" array to contain files that require tests.
1729         (generateNewChangeLogs): Checks "requiresTests" array to determine whether to inject "tests"
1730         section in ChangeLog.
1731         (attributeCommand): Queries a given file for a given Git attribute value. If using Subversion,
1732         however, we check if the file or any containing folder has the given property set to "1" and
1733         return 1 if so; return 0 otherwise.
1734         (generateFileList): Adds files to "requiresTests" array if Git attribute is set to "1". Also
1735         adds files to "addedRegressionTests" array if "test" attribute is set to "1".
1736
1737 2015-08-26  Andy Estes  <aestes@apple.com>
1738
1739         [Content Filtering] Determine navigation and content policy before continuing to filter a load
1740         https://bugs.webkit.org/show_bug.cgi?id=148506
1741
1742         Reviewed by Brady Eidson.
1743
1744         Added download API tests covering every decision and decision point.
1745         Removed _WKDownload.AsynchronousDownloadPolicy in favor of these new tests.
1746
1747         * TestWebKitAPI/Configurations/Base.xcconfig: Added $(BUILT_PRODUCTS_DIR)/WebCoreTestSupport to the header search path.
1748         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Removed it from here.
1749         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm:
1750         (-[BundleParametersPlugIn observeValueForKeyPath:ofObject:change:context:]): Called -valueForKeyPath:, which
1751         returns an id, instead of -valueForKey:, which always returns an NSString even if the object is of another type.
1752         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Added a class that can send a MockContentFilter
1753         decision and decision point as a bundle parameter.
1754         (+[MockContentFilterEnabler supportsSecureCoding]):
1755         (-[MockContentFilterEnabler copyWithZone:]):
1756         (-[MockContentFilterEnabler initWithCoder:]):
1757         (-[MockContentFilterEnabler initWithDecision:decisionPoint:]):
1758         (-[MockContentFilterEnabler encodeWithCoder:]):
1759         (configurationWithContentFilterSettings): Added a helper function to create a WKWebViewConfiguration with MockConentFilter settings.
1760         (TEST): Renamed ContentFiltering.ServerRedirect to ContentFiltering.URLAfterServerRedirect.
1761         (-[BecomeDownloadDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Decided _WKNavigationResponsePolicyBecomeDownload.
1762         (-[BecomeDownloadDelegate webView:didFailProvisionalNavigation:withError:]): Set isDone to true.
1763         (-[BecomeDownloadDelegate webView:didFinishNavigation:]): Ditto.
1764         (-[ContentFilteringDownloadDelegate _downloadDidStart:]): Set downloadDidStart to true.
1765         (downloadTest): Added a helper function to test downloads with a given decision and decision point.
1766         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm: Added a corresponding bundle class that decodes
1767         the MockContentFilter decision and decision point, and sets these values in the MockContentFilterSettings
1768         singleton. This class is duplicated in the bundle to prevent TestWebKitAPI from having to link to WebCoreTestSupport.
1769         (+[MockContentFilterEnabler supportsSecureCoding]):
1770         (-[MockContentFilterEnabler copyWithZone:]):
1771         (-[MockContentFilterEnabler initWithCoder:]):
1772         (-[MockContentFilterEnabler dealloc]):
1773         (-[MockContentFilterEnabler encodeWithCoder:]):
1774         (-[ContentFilteringPlugIn webProcessPlugIn:initializeWithObject:]): Start observing changes to the MockContentFilterEnabler key path.
1775         (-[ContentFilteringPlugIn dealloc]): Stop observing.
1776         (-[ContentFilteringPlugIn observeValueForKeyPath:ofObject:change:context:]): Store a MockContentFilterEnabler in _contentFilterEnabler.
1777         (+[ServerRedirectPlugIn initialize]): Deleted.
1778         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1779         (-[AsynchronousDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1780         (-[AsynchronousDownloadDelegate _downloadDidStart:]): Deleted.
1781         (TEST): Deleted.
1782
1783 2015-08-31  Filip Pizlo  <fpizlo@apple.com>
1784
1785         Skip slow lock tests on Windows/debug
1786         https://bugs.webkit.org/show_bug.cgi?id=148643
1787
1788         Reviewed by Alexey Proskuryakov.
1789
1790         The lock tests simulate a critical section by doing some floating point math, and then either
1791         make those critical sections very long or invoke them many times. This appears to be
1792         particularly slow on Windows in debug mode, maybe because Visual Studio's debug build makes
1793         that kind of computation slow.
1794
1795         These tests are almost as useful in release as they are in debug, so it's probably better to
1796         just skip the in debug on platforms where this causes timeouts.
1797
1798         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1799         (TestWebKitAPI::runLockTest):
1800         (TestWebKitAPI::skipSlow):
1801         (TestWebKitAPI::TEST):
1802
1803 2015-08-29  Chris Fleizach  <cfleizach@apple.com>
1804
1805         AX: When navigating the elements of a scrollable element with VoiceOver, the scrollTop() position of the element does not permanently change
1806         https://bugs.webkit.org/show_bug.cgi?id=125720
1807
1808         Reviewed by Daniel Bates.
1809
1810         Add support for scrollToMakeVisibleWithSubFocus and scrollToGlobalPoint.
1811
1812         * DumpRenderTree/AccessibilityUIElement.cpp:
1813         (pressCallback):
1814         (scrollToMakeVisibleWithSubFocusCallback):
1815         (scrollToGlobalPointCallback):
1816         (scrollToMakeVisibleCallback):
1817         (AccessibilityUIElement::getJSClass):
1818         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1819         (AccessibilityUIElement::scrollToMakeVisible):
1820         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
1821         (AccessibilityUIElement::scrollToGlobalPoint):
1822         (AccessibilityUIElement::selectedTextRange):
1823         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1824         (AccessibilityUIElement::AccessibilityUIElement):
1825         (AccessibilityUIElement::mathPrescriptsDescription):
1826         (AccessibilityUIElement::scrollToMakeVisible):
1827         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
1828         (AccessibilityUIElement::scrollToGlobalPoint):
1829         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1830         (WTR::AccessibilityUIElement::isTextMarkerValid):
1831         (WTR::AccessibilityUIElement::textMarkerForIndex):
1832         (WTR::AccessibilityUIElement::scrollToMakeVisible):
1833         (WTR::AccessibilityUIElement::scrollToGlobalPoint):
1834         (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
1835         (WTR::AccessibilityUIElement::supportedActions):
1836         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
1837         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
1838         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1839         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1840         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1841         (WTR::AccessibilityUIElement::scrollToMakeVisible):
1842         (WTR::AccessibilityUIElement::scrollToGlobalPoint):
1843         (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
1844         (WTR::AccessibilityUIElement::selectedTextRange):
1845         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1846         (WTR::AccessibilityUIElement::scrollToMakeVisible):
1847         (WTR::AccessibilityUIElement::scrollToGlobalPoint):
1848         (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
1849         (WTR::AccessibilityUIElement::selectedTextRange):
1850
1851 2015-08-28  Timothy Horton  <timothy_horton@apple.com>
1852
1853         Add a mysteriously nonproblematic missing comma.
1854
1855         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1856         (TestExpectationParser._collect_matching_tests):
1857         (TestExpectationParser):
1858
1859 2015-08-28  Timothy Horton  <timothy_horton@apple.com>
1860
1861         Remove an old temporary script that has served its purpose
1862
1863         * Scripts/convert-test-expectations: Removed.
1864
1865 2015-08-28  Jer Noble  <jer.noble@apple.com>
1866
1867         [iOS] Add WebKit/WebKit2 settings to control automatic data loading
1868         https://bugs.webkit.org/show_bug.cgi?id=148579
1869
1870         Reviewed by Anders Carlsson.
1871
1872         In DumpRenderTree, set the new mediaDataLoadsAutomatically preference to YES.
1873
1874         In WebKitTestRunner, do the same for the new _mediaDataLoadsAutomatically configuration property,
1875         and also set the existing requiresUserActionForMediaPlayback configuration property to NO.
1876
1877         * DumpRenderTree/mac/DumpRenderTree.mm:
1878         (resetWebPreferencesToConsistentValues):
1879         (resetWebViewToConsistentStateBeforeTesting): 
1880         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1881         (WTR::initializeWebViewConfiguration):
1882
1883 2015-08-28  Alexey Proskuryakov  <ap@apple.com>
1884
1885         Fix run-webkit-tests --additional-env-var="DYLD_INSERT_LIBRARIES=..."
1886         https://bugs.webkit.org/show_bug.cgi?id=148592
1887
1888         Reviewed by Tim Horton.
1889
1890         * Scripts/webkitpy/port/base.py:
1891         (Port.to.setup_environ_for_server):
1892         (Port.to):
1893         (Port.to._append_value_colon_separated):
1894         (Port.to.show_results_html_file):
1895         * Scripts/webkitpy/port/ios.py:
1896         (IOSSimulatorPort.setup_environ_for_server):
1897         * Scripts/webkitpy/port/mac.py:
1898         (MacPort.setup_environ_for_server):
1899
1900 2015-08-28  Filip Pizlo  <fpizlo@apple.com>
1901
1902         LICM should be sound even if the CFG has changed
1903         https://bugs.webkit.org/show_bug.cgi?id=148259
1904
1905         Reviewed by Benjamin Poulain.
1906
1907         Add a utility for creating tests that set some uncommon option.
1908
1909         * Scripts/run-jsc-stress-tests:
1910
1911 2015-08-28  Brent Fulgham  <bfulgham@apple.com>
1912
1913         [Win] Unreviewed EWS correction.
1914
1915         * EWSTools/start-queue-win.sh: Update settings to point to VS2015.
1916
1917 2015-08-28  Jer Noble  <jer.noble@apple.com>
1918
1919         [iOS] Make the AllowsInlineMediaPlayback preference work in WebKit / WebKit2.
1920         https://bugs.webkit.org/show_bug.cgi?id=147512
1921
1922         Reviewed by Anders Carlsson.
1923
1924         Set the value of WebKitAllowsInlineMediaPlayback / WKPreferencesSetMediaPlaybackAllowsInline()
1925         to a consistent (true) value.
1926
1927         * DumpRenderTree/mac/DumpRenderTree.mm:
1928         (setDefaultsToConsistentValuesForTesting):
1929         * WebKitTestRunner/TestController.cpp:
1930         (WTR::TestController::resetPreferencesToConsistentValues):
1931
1932 2015-08-28  Tim Horton  <timothy_horton@apple.com>
1933
1934         Add navigation gesture callbacks to WKPageNavigationClient
1935         https://bugs.webkit.org/show_bug.cgi?id=148568
1936         <rdar://problem/22371346>
1937
1938         Reviewed by Anders Carlsson.
1939
1940         * WebKitTestRunner/TestController.cpp:
1941         (WTR::TestController::createOtherPage):
1942         (WTR::TestController::createWebViewWithOptions):
1943         Add some zeroes.
1944
1945 2015-08-28  Alexey Proskuryakov  <ap@apple.com>
1946
1947         [Mac] kill-old-processes should kill more processes
1948         https://bugs.webkit.org/show_bug.cgi?id=148577
1949
1950         Reviewed by Tim Horton.
1951
1952         * BuildSlaveSupport/kill-old-processes:
1953
1954 2015-08-28  Jason Marcell  <jmarcell@apple.com>
1955
1956         The status message for combined builder queues should say "all builds succeeded" if everything
1957         built correctly.
1958         https://bugs.webkit.org/show_bug.cgi?id=148535
1959
1960         Reviewed by David Kilzer and Alexey Proskuryakov.
1961
1962         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
1963         (BuildbotCombinedQueueView.prototype.update): Make status message for combined builder queues
1964         say "all builds succeeded" if everything built correctly.
1965
1966 2015-08-28  Carlos Garcia Campos  <cgarcia@igalia.com>
1967
1968         [GTK] Simplify the internal API to create a WebView
1969         https://bugs.webkit.org/show_bug.cgi?id=148570
1970
1971         Reviewed by Žan Doberšek.
1972
1973         * TestWebKitAPI/PlatformWebView.h: Add initialize method for GTK+ too.
1974         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
1975         (TestWebKitAPI::PlatformWebView::PlatformWebView): Implement all
1976         PlatformWebView constructors that end up calling initialize with a PageConfiguration.
1977         (TestWebKitAPI::PlatformWebView::initialize): Create the WebView
1978         passing the received PageConfiguration.
1979         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1980         (WTR::PlatformWebView::PlatformWebView): Create the WebView
1981         passing the received PageConfiguration.
1982
1983 2015-08-27  Aakash Jain  <aakash_jain@apple.com>
1984
1985         iOS Simulator API tests fails as Simulator is not running
1986         https://bugs.webkit.org/show_bug.cgi?id=148501
1987         rdar://problem/22447525
1988
1989         Reviewed by Daniel Bates.
1990
1991         This change is a workaround for <rdar://problem/22388812>.
1992
1993          * Scripts/run-api-tests: Launch the iOS Simulator before starting the API Tests
1994          and quit it on program termination when running tests on the iOS port.
1995          * Scripts/webkitdirs.pm: Store string "For WebKit Development" in constant
1996          SIMULATOR_DEVICE_SUFFIX_FOR_WEBKIT_DEVELOPMENT to make it consistently reusable.
1997
1998 2015-08-27  Alex Christensen  <achristensen@webkit.org>
1999
2000         Make DLLLauncherMain executables dependent on dll
2001         https://bugs.webkit.org/show_bug.cgi?id=148548
2002
2003         Reviewed by Brent Fulgham.
2004
2005         * DumpRenderTree/CMakeLists.txt:
2006         * DumpRenderTree/PlatformWin.cmake:
2007         * MiniBrowser/win/CMakeLists.txt:
2008         * TestWebKitAPI/CMakeLists.txt:
2009         * TestWebKitAPI/PlatformWin.cmake:
2010
2011 2015-08-27  Lucas Forschler  <lforschler@apple.com>
2012
2013         Remove Mac slaves 188/189 after being replaced with 400/401.
2014         
2015         Unreviewed.
2016         
2017         * BuildSlaveSupport/build.webkit.org-config/config.json:
2018
2019 2015-08-27  Lucas Forschler  <lforschler@apple.com>
2020
2021         Add two bots to the Mac Yosemite queue.
2022         This is to eventually replace bots188/189, which will be removed after 400/401 are vetted.
2023         
2024         Unreviewed.
2025         
2026         * BuildSlaveSupport/build.webkit.org-config/config.json:
2027
2028 2015-08-27  Alex Christensen  <achristensen@webkit.org>
2029
2030         [Win CMake] Fix incremental build after r188673
2031         https://bugs.webkit.org/show_bug.cgi?id=148539
2032
2033         Reviewed by Brent Fulgham.
2034
2035         * TestWebKitAPI/PlatformWin.cmake:
2036         Copy forwarding headers from WebCore before building in case that was not yet done.
2037         It used to be done when running CMake, but now it's a build step.
2038
2039 2015-08-27  Nan Wang  <n_wang@apple.com>
2040
2041         AX: Fix accessibility/select-element-at-index.html test
2042         https://bugs.webkit.org/show_bug.cgi?id=148516
2043
2044         Reviewed by Chris Fleizach.
2045
2046         Implemented setSelectedChildAtIndex and removeSelectionAtIndex for mac.
2047
2048         * DumpRenderTree/AccessibilityUIElement.cpp:
2049         (setSelectedChildCallback):
2050         (setSelectedChildAtIndexCallback):
2051         (removeSelectionAtIndexCallback):
2052         (elementAtPointCallback):
2053         (sentenceAtOffsetCallback):
2054         (stringForSelectionCallback):
2055         (AccessibilityUIElement::getJSClass):
2056         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2057         (AccessibilityUIElement::setSelectedChild):
2058         (AccessibilityUIElement::setSelectedChildAtIndex):
2059         (AccessibilityUIElement::removeSelectionAtIndex):
2060         (AccessibilityUIElement::accessibilityValue):
2061         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2062         (WTR::AccessibilityUIElement::wordAtOffset):
2063         (WTR::AccessibilityUIElement::lineAtOffset):
2064         (WTR::AccessibilityUIElement::sentenceAtOffset):
2065         (WTR::AccessibilityUIElement::isSelectable):
2066         (WTR::AccessibilityUIElement::isMultiSelectable):
2067         (WTR::AccessibilityUIElement::setSelectedChild):
2068         (WTR::AccessibilityUIElement::setSelectedChildAtIndex):
2069         (WTR::AccessibilityUIElement::removeSelectionAtIndex):
2070         (WTR::AccessibilityUIElement::selectedChildrenCount):
2071         (WTR::AccessibilityUIElement::selectedChildAtIndex):
2072         (WTR::AccessibilityUIElement::isExpanded):
2073         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2074         (WTR::AccessibilityUIElement::setSelectedChild):
2075         (WTR::AccessibilityUIElement::setSelectedChildAtIndex):
2076         (WTR::AccessibilityUIElement::removeSelectionAtIndex):
2077         (WTR::AccessibilityUIElement::accessibilityValue):
2078
2079 2015-08-27  Alex Christensen  <achristensen@webkit.org>
2080
2081         Build fix after r188982
2082
2083         * MiniBrowser/win/CMakeLists.txt:
2084         The directory structure changed in the move.
2085
2086 2015-08-27  Michael Catanzaro  <mcatanzaro@igalia.com>
2087
2088         [GTK] Unreviewed, install-dependencies should install geoclue2 on Fedora
2089
2090         geoclue-devel is for obsolete geoclue. Install geoclue2-devel instead.
2091
2092         * gtk/install-dependencies:
2093
2094 2015-08-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2095
2096         Unreviewed. Mark WTF_WordLock.ContendedShortSection as slow too.
2097
2098         * Scripts/run-gtk-tests:
2099         (TestRunner):
2100
2101 2015-08-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2102
2103         Fix GTK+ WTR crashes in initializeMainRunLoop()
2104
2105         Rubber-stamped by Žan Doberšek.
2106
2107         Initialize threading and main thread before
2108         RunLoop::initializeMainRunLoop(), since the GLib implementation of
2109         the RunLoop uses isMainThread() to decide whether to create a new
2110         GMainContext or use the default one. Also use RunLoop::run() and
2111         ::stop() instead of gtk_main/quit.
2112
2113         * WebKitTestRunner/TestController.cpp:
2114         (WTR::TestController::initialize):
2115         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2116         (WTR::TestController::notifyDone):
2117         (WTR::TestController::platformRunUntil):
2118
2119 2015-08-27  Filip Pizlo  <fpizlo@apple.com>
2120
2121         Unreviewed, further shorten a test that times out because it's very long
2122         running.
2123
2124         I've locally run these tests on repeat for 24 hours and found no genuine
2125         failures, like deadlocks. So, the timeouts are probably because the test
2126         machine is slow and debug is slow. We should just run this test for fewer
2127         iterations.
2128
2129         * TestWebKitAPI/Tests/WTF/Lock.cpp:
2130         (TestWebKitAPI::TEST):
2131
2132 2015-08-26  Ryuan Choi  <ryuan.choi@navercorp.com>
2133
2134         Unreviewed build fix attempt on EFL
2135
2136         * WebKitTestRunner/PlatformEfl.cmake:
2137
2138 2015-08-26  Alex Christensen  <achristensen@webkit.org>
2139
2140         Build fix after r188982
2141
2142         * MiniBrowser/win/CMakeLists.txt:
2143         Find .rc files in correct directory.
2144
2145 2015-08-26  Ryuan Choi  <ryuan.choi@navercorp.com>
2146
2147         [EFL] Bump cairo version to 1.14.2
2148         https://bugs.webkit.org/show_bug.cgi?id=148474
2149
2150         Reviewed by Csaba Osztrogonác.
2151
2152         * efl/jhbuild.modules:
2153
2154 2015-08-26  Andy Estes  <aestes@apple.com>
2155
2156         Crash when following a Google search link to Twitter with Limit Adult Content enabled
2157         https://bugs.webkit.org/show_bug.cgi?id=147651
2158
2159         Rubber-stamped by Brady Eidson.
2160
2161         Taught TestRunner how to decide the navigation policy after a delay.
2162
2163         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2164         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2165         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
2166         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2167         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
2168         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2169         (WTR::TestRunner::shouldDecideNavigationPolicyAfterDelay):
2170         * WebKitTestRunner/TestController.cpp:
2171         (WTR::TestController::initialize):
2172         (WTR::TestController::resetStateToConsistentValues):
2173         (WTR::TestController::decidePolicyForNavigationAction):
2174         * WebKitTestRunner/TestController.h:
2175         (WTR::TestController::setShouldDecideNavigationPolicyAfterDelay):
2176         * WebKitTestRunner/TestInvocation.cpp:
2177         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2178
2179 2015-08-26  Brent Fulgham  <bfulgham@apple.com>
2180
2181         [Win] Rename 'WinLauncher' to 'MiniBrowser'
2182         https://bugs.webkit.org/show_bug.cgi?id=148485
2183
2184         Reviewed by Alex Christensen
2185
2186         Move the WinLauncher project and source files to a subdirectory
2187         of MiniBrowser. Globally change WinLauncher -> MiniBrowser in the
2188         source code and project files.
2189         
2190         * MiniBrowser/MiniBrowser.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj.
2191         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.ico: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.ico.
2192         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.rc: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.rc.
2193         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.
2194         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.vcxproj.filters: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters.
2195         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCF.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCF.props.
2196         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCFLite.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props.
2197         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCommon.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props.
2198         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserDebug.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props.
2199         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc.
2200         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.
2201         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj.filters: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters.
2202         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibCommon.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props.
2203         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibDebug.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props.
2204         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibPostBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd.
2205         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibPreBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd.
2206         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibProduction.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props.
2207         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibRelease.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props.
2208         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h.
2209         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserPostBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherPostBuild.cmd.
2210         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserPreBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherPreBuild.cmd.
2211         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserProduction.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props.
2212         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserRelease.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props.
2213         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserResource.h: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherResource.h.
2214         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.ico: Removed.
2215         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.rc: Removed.
2216         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.vcxproj: Removed.
2217         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.vcxproj.filters: Removed.
2218         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCF.props: Removed.
2219         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCFLite.props: Removed.
2220         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCommon.props: Removed.
2221         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherDebug.props: Removed.
2222         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.rc: Removed.
2223         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.vcxproj: Removed.
2224         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.vcxproj.filters: Removed.
2225         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibCommon.props: Removed.
2226         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibDebug.props: Removed.
2227         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibPostBuild.cmd: Removed.
2228         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibPreBuild.cmd: Removed.
2229         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibProduction.props: Removed.
2230         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibRelease.props: Removed.
2231         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibResource.h: Removed.
2232         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherPostBuild.cmd: Removed.
2233         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherPreBuild.cmd: Removed.
2234         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherProduction.props: Removed.
2235         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherRelease.props: Removed.
2236         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherResource.h: Removed.
2237         * MiniBrowser/win: Copied from WinLauncher.
2238         * MiniBrowser/win/Common.cpp:
2239         * MiniBrowser/win/MiniBrowser.cpp: Copied from WinLauncher/WinLauncher.cpp.
2240         * MiniBrowser/win/MiniBrowser.h: Copied from WinLauncher/WinLauncher.h.
2241         * MiniBrowser/win/MiniBrowserReplace.h: Copied from WinLauncher/WinLauncherReplace.h.
2242         * MiniBrowser/win/MiniBrowserWebHost.cpp: Copied from WinLauncher/WinLauncherWebHost.cpp.
2243         * MiniBrowser/win/MiniBrowserWebHost.h: Copied from WinLauncher/WinLauncherWebHost.h.
2244         * MiniBrowser/win/PageLoadTestClient.cpp:
2245         * MiniBrowser/win/PageLoadTestClient.h:
2246         * MiniBrowser/win/ResourceLoadDelegate.cpp:
2247         * MiniBrowser/win/ResourceLoadDelegate.h:
2248         * MiniBrowser/win/WinLauncher.cpp: Removed.
2249         * MiniBrowser/win/WinLauncher.h: Removed.
2250         * MiniBrowser/win/WinLauncher.vcxproj: Removed.
2251         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.ico: Removed.
2252         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.rc: Removed.
2253         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.vcxproj: Removed.
2254         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Removed.
2255         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCF.props: Removed.
2256         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCFLite.props: Removed.
2257         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCommon.props: Removed.
2258         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherDebug.props: Removed.
2259         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.rc: Removed.
2260         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Removed.
2261         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: Removed.
2262         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibCommon.props: Removed.
2263         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibDebug.props: Removed.
2264         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd: Removed.
2265         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd: Removed.
2266         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibProduction.props: Removed.
2267         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibRelease.props: Removed.
2268         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibResource.h: Removed.
2269         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherPostBuild.cmd: Removed.
2270         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherPreBuild.cmd: Removed.
2271         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherProduction.props: Removed.
2272         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherRelease.props: Removed.
2273         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherResource.h: Removed.
2274         * MiniBrowser/win/WinLauncher.vcxproj/small.ico: Removed.
2275         * MiniBrowser/win/WinLauncherReplace.h: Removed.
2276         * MiniBrowser/win/WinLauncherWebHost.cpp: Removed.
2277         * MiniBrowser/win/WinLauncherWebHost.h: Removed.
2278         * MiniBrowser/win/WinMain.cpp:
2279         * WinLauncher: Removed.
2280         * WinLauncher/AccessibilityDelegate.cpp: Removed.
2281         * WinLauncher/AccessibilityDelegate.h: Removed.
2282         * WinLauncher/CMakeLists.txt: Removed.
2283         * WinLauncher/Common.cpp: Removed.
2284         * WinLauncher/DOMDefaultImpl.cpp: Removed.
2285         * WinLauncher/DOMDefaultImpl.h: Removed.
2286         * WinLauncher/PageLoadTestClient.cpp: Removed.
2287         * WinLauncher/PageLoadTestClient.h: Removed.
2288         * WinLauncher/PrintWebUIDelegate.cpp: Removed.
2289         * WinLauncher/PrintWebUIDelegate.h: Removed.
2290         * WinLauncher/ResourceLoadDelegate.cpp: Removed.
2291         * WinLauncher/ResourceLoadDelegate.h: Removed.
2292         * WinLauncher/WebDownloadDelegate.cpp: Removed.
2293         * WinLauncher/WebDownloadDelegate.h: Removed.
2294         * WinLauncher/WinLauncher.cpp: Removed.
2295         * WinLauncher/WinLauncher.h: Removed.
2296         * WinLauncher/WinLauncher.vcxproj: Removed.
2297         * WinLauncher/WinLauncher.vcxproj/WinLauncher.ico: Removed.
2298         * WinLauncher/WinLauncher.vcxproj/WinLauncher.rc: Removed.
2299         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Removed.
2300         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Removed.
2301         * WinLauncher/WinLauncher.vcxproj/WinLauncherCF.props: Removed.
2302         * WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props: Removed.
2303         * WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props: Removed.
2304         * WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props: Removed.
2305         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Removed.
2306         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Removed.
2307         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: Removed.
2308         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Removed.
2309         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props: Removed.
2310         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd: Removed.
2311         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd: Removed.
2312         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props: Removed.
2313         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props: Removed.
2314         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h: Removed.
2315         * WinLauncher/WinLauncher.vcxproj/WinLauncherPostBuild.cmd: Removed.
2316         * WinLauncher/WinLauncher.vcxproj/WinLauncherPreBuild.cmd: Removed.
2317         * WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props: Removed.
2318         * WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props: Removed.
2319         * WinLauncher/WinLauncher.vcxproj/WinLauncherResource.h: Removed.
2320         * WinLauncher/WinLauncher.vcxproj/small.ico: Removed.
2321         * WinLauncher/WinLauncherReplace.h: Removed.
2322         * WinLauncher/WinLauncherWebHost.cpp: Removed.
2323         * WinLauncher/WinLauncherWebHost.h: Removed.
2324         * WinLauncher/WinMain.cpp: Removed.
2325         * WinLauncher/resource.h: Removed.
2326         * WinLauncher/stdafx.cpp: Removed.
2327         * WinLauncher/stdafx.h: Removed.
2328         * win/AssembleBuildLogs/AssembleLogs.cmd:
2329
2330 2015-08-26  Brent Fulgham  <bfulgham@apple.com>
2331
2332         [Win] Simplify menu handling code in WinLauncher
2333         https://bugs.webkit.org/show_bug.cgi?id=148461
2334
2335         Reviewed by Zalan Bujtas.
2336
2337         Revise 'ToggleMenuItem' to return a boolean value indicating if
2338         it handled the message. Revise WndProc to use this to decide if it
2339         should pass the message on to the default handler, rather than
2340         duplicating the logic in both places.
2341         
2342         * WinLauncher/Common.cpp:
2343         (ToggleMenuItem): Return true if the menu item message was handled.
2344         (WndProc): If 'ToggleMenuItem' did not handle the message, pass
2345         the message tothe default handler.
2346
2347 2015-08-26  Csaba Osztrogonác  <ossy@webkit.org>
2348
2349         Remove unused code after r188948
2350         https://bugs.webkit.org/show_bug.cgi?id=148467
2351
2352         Reviewed by Gyuyoung Kim.
2353
2354         * WebKitTestRunner/TestController.cpp:
2355         (WTR::TestController::platformPreferences): Deleted.
2356
2357 2015-08-26  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2358
2359         [EFL][GTK] REGRESSION(r188828): All performance tests and almost all layout tests crash
2360         https://bugs.webkit.org/show_bug.cgi?id=148377
2361
2362         Reviewed by Carlos Garcia Campos.
2363
2364         EFL and GTK don't support TestController::platformPreferences() yet which was introduced by r188828.
2365         It caused all crashes of layout test and performance test on EFL and GTK. So this patch implements
2366         TestController::platformPreferences() using WKPageGroupGetPreferences() which was previous thing for
2367         EFL and GTK at the moment.
2368
2369         * WebKitTestRunner/TestController.cpp:
2370         (WTR::TestController::platformWillRunTest):
2371         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2372         (WTR::TestController::platformPreferences):
2373         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2374         (WTR::TestController::platformPreferences):
2375
2376 2015-08-25  Nan Wang  <n_wang@apple.com>
2377
2378         AX: Enable accessibility/aria-controls.html test for mac
2379         https://bugs.webkit.org/show_bug.cgi?id=148458
2380
2381         Reviewed by Chris Fleizach.
2382
2383         Implemented ariaControlsElementAtIndex(unsigned index).
2384
2385         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2386         (AccessibilityUIElement::ariaControlsElementAtIndex):
2387         (AccessibilityUIElement::disclosedRowAtIndex):
2388         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2389         (WTR::AccessibilityUIElement::ariaControlsElementAtIndex):
2390
2391 2015-08-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2392
2393         Remove python tests for PassRefPtr 
2394         https://bugs.webkit.org/show_bug.cgi?id=148463
2395
2396         Reviewed by Andy Estes.
2397
2398         As we're removing uses of PassRefPtr, we need to remove all python tests for PassRefPtr as well.
2399
2400         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2401         (PassPtrTest): Deleted.
2402         (PassPtrTest.assert_pass_ptr_check): Deleted.
2403         (PassPtrTest.test_pass_ref_ptr_in_function): Deleted.
2404         (PassPtrTest.test_pass_other_type_ptr_in_function): Deleted.
2405         (PassPtrTest.test_pass_ref_ptr_return_value): Deleted.
2406         (PassPtrTest.test_ref_ptr_parameter_value): Deleted.
2407         (PassPtrTest.test_ref_ptr_member_variable): Deleted.
2408         (PassPtrTest.test_ref_ptr_member_variable.Foo): Deleted.
2409
2410 2015-08-25  Andy Estes  <aestes@apple.com>
2411
2412         [iOS] run-webkit-tests fails if watchOS SDK is installed
2413         https://bugs.webkit.org/show_bug.cgi?id=148453
2414
2415         Reviewed by David Kilzer.
2416
2417         * Scripts/webkitpy/xcode/simulator.py:
2418         (Simulator): Taught Simulator how to parse watchOS runtimes and devices.
2419         * Scripts/webkitpy/xcode/simulator_unittest.py: Added tests.
2420
2421 2015-08-25  Aakash Jain  <aakash_jain@apple.com>
2422
2423         iOS Simulator layout-tests fail to start while cleaning a directory structure if simulator is already running
2424         https://bugs.webkit.org/show_bug.cgi?id=148197
2425         rdar://problem/22334382
2426
2427         Reviewed by Daniel Bates.
2428
2429         * BuildSlaveSupport/kill-old-processes: Add Simulator to the list of processes to kill (for iOS builders).
2430         * Scripts/webkitpy/port/ios.py:
2431         (IOSSimulatorPort): Converted bundle id com.apple.iphonesimulator to a variable SIMULATOR_BUNDLE_ID.
2432         (IOSSimulatorPort._quitIOSSimulator): Common function to quit iOS Simulator.
2433         (IOSSimulatorPort.clean_up_test_run): Quit the simulator during the cleanup.
2434         (IOSSimulatorPort.check_sys_deps): No need to quit the simulator here as its now being quit in reset_preferences().
2435         (IOSSimulatorPort.reset_preferences): Quit the simulator before trying to delete associated data directory.
2436
2437 2015-08-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2438
2439         Remove PassRefPtr style check rule
2440         https://bugs.webkit.org/show_bug.cgi?id=148432
2441
2442         Reviewed by Andreas Kling.
2443
2444         PassRefPtr is being removed. Thus style rule needs to be removed as well.
2445
2446         * Scripts/webkitpy/style/checkers/cpp.py:
2447         (_check_parameter_name_against_text): Deleted.
2448         (check_function_definition_and_pass_ptr): Deleted.
2449         (check_function_definition): Deleted.
2450         (check_pass_ptr_usage): Deleted.
2451         (process_line): Deleted.
2452         (CppChecker): Deleted.
2453
2454 2015-08-25  Brent Fulgham  <bfulgham@apple.com>
2455
2456         [Win] Expose "Inverted Colors" option in WinLauncher
2457         https://bugs.webkit.org/show_bug.cgi?id=148451
2458
2459         Reviewed by Tim Horton.
2460
2461         Add the ability to toggle the "Inverted Colors" preference
2462         in WinLauncher.
2463         
2464         * WinLauncher/Common.cpp:
2465         (ToggleMenuItem): Toggle the feature when the menu item
2466         is selected.
2467         (WndProc): Recognize the new menu option.
2468         * WinLauncher/WinLauncher.cpp:
2469         (WinLauncher::setToDefaultPreferences): Launch with "Invert
2470         Colors" turned off.
2471         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Add menu
2472         entry for "Invert Colors".
2473         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h:
2474
2475 2015-08-25  Nan Wang  <n_wang@apple.com>
2476
2477         [Mac] accessibility/document-attributes.html fails
2478         https://bugs.webkit.org/show_bug.cgi?id=116636
2479
2480         Reviewed by Chris Fleizach.
2481
2482         Implemented documentURI() and documentEncoding().
2483
2484         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2485         (AccessibilityUIElement::documentEncoding):
2486         (AccessibilityUIElement::documentURI):
2487         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2488         (WTR::AccessibilityUIElement::documentEncoding):
2489         (WTR::AccessibilityUIElement::documentURI):
2490
2491 2015-08-24  Brent Fulgham  <bfulgham@apple.com>
2492
2493         [Win] Unreviewed test gardening.
2494
2495         Fix another case where the logging string is constructed using the variable 'frame',
2496         but the method argument is not given a name. This causes the global 'frame' value to
2497         be used, producing incorrect output.
2498
2499         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2500         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame): Use 'frame'
2501         argument.
2502
2503 2015-08-24  Tim Horton  <timothy_horton@apple.com>
2504
2505         (Finally...) get rid of WKViewIOS
2506         https://bugs.webkit.org/show_bug.cgi?id=148404
2507
2508         Reviewed by Anders Carlsson.
2509
2510         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
2511         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
2512         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
2513         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
2514         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
2515         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
2516         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:
2517         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
2518         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
2519         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.mm:
2520         Mark tests that use WKBrowsingContextController as Mac-only.
2521
2522         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
2523         (WTR::AccessibilityController::addNotificationListener):
2524         * WebKitTestRunner/ios/mainIOS.mm:
2525         (-[WebKitTestRunnerApp applicationDidEnterBackground:]):
2526         Import UIKit instead of depending on WKView.h to do so.
2527
2528 2015-08-24  Jason Marcell  <jmarcell@apple.com>
2529
2530         Add support to dashboard for displaying Git SHA's as revisions.
2531         https://bugs.webkit.org/show_bug.cgi?id=148387
2532
2533         Reviewed by Daniel Bates.
2534
2535         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2536         (parseRevisionProperty): Added support to dashboard for displaying Git SHA's as revisions.
2537         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2538         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Ditto.
2539         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js: Added
2540         "isSVN" property to Dashboard.Repository.(OpenSource|Internal).
2541
2542 2015-08-24  Andy Estes  <aestes@apple.com>
2543
2544         REGRESSION (r188851): WebKit2.BundleParameters fails on iOS
2545
2546         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Specify LD_RUNPATH_SEARCH_PATHS correctly for iOS.
2547
2548 2015-08-23  Andy Estes  <aestes@apple.com>
2549
2550         Addressed a missed piece of review feedback from r188851.
2551
2552         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
2553
2554 2015-08-23  Andy Estes  <aestes@apple.com>
2555
2556         [Content Filtering] REGRESSION (r182356): Provisional URL is incorrect in didReceiveServerRedirectForProvisionalLoadForFrame when Content Filtering is enabled
2557         https://bugs.webkit.org/show_bug.cgi?id=147872
2558         rdar://problem/22044000
2559
2560         Reviewed by Dan Bernstein.
2561         
2562         Added an API test.
2563
2564         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Linked libWebCoreTestSupport in order to use MockContentFilter.
2565         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2566         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Added.
2567         (-[ServerRedirectNavigationDelegate webView:didStartProvisionalNavigation:]): Expect the initial request URL.
2568         (-[ServerRedirectNavigationDelegate webView:didReceiveServerRedirectForProvisionalNavigation:]): Expect the redirect URL.
2569         (-[ServerRedirectNavigationDelegate webView:didCommitNavigation:]):
2570         (TEST): Tested that -[WKWebView URL] is updated after a redirect when content filtering is enabled.
2571         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm: Added.
2572         (+[ServerRedirectPlugIn initialize]): Enable MockContentFilter.
2573         * TestWebKitAPI/cocoa/TestProtocol.h: Renamed from Tools/TestWebKitAPI/mac/TestProtocol.h.
2574         * TestWebKitAPI/cocoa/TestProtocol.mm: Renamed from Tools/TestWebKitAPI/mac/TestProtocol.mm.
2575
2576 2015-08-23  Andy Estes  <aestes@apple.com>
2577
2578         Fixed the 32-bit Mac build after r188844.
2579
2580         * TestWebKitAPI/WKWebViewConfigurationExtras.h:
2581         * TestWebKitAPI/WKWebViewConfigurationExtras.mm:
2582
2583 2015-08-22  Andy Estes  <aestes@apple.com>
2584
2585         [Cocoa] API tests using the Modern WebKit API should be able to create web process plug-ins
2586         https://bugs.webkit.org/show_bug.cgi?id=148317
2587
2588         Reviewed by Dan Bernstein.
2589
2590         Added the ability for Modern WebKit API tests to create WKWebProcessPlugIns. A test can create a plug-in by
2591         creating a class that conforms to WKWebProcessPlugIn, adding it to the WebProcessPlugIn target, and using the
2592         WKWebViewConfiguration returned by +[WKWebViewConfiguration testwebkitapi_configurationWithTestPlugInClassName:]
2593         when creating WKWebViews.
2594
2595         Since TestWebKitAPI relies on a bundle parameter to know which test class to instantiate in the plug-in, I also
2596         added a new API test for bundle parameters.
2597
2598         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Added. Named the bundle TestWebKitAPI.wkbundle and
2599         named its executable TestWebKitAPI.bundle.
2600         * TestWebKitAPI/PlatformUtilities.h: Declared TestPlugInClassNameParameter.
2601         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added the WebProcessPlugIn target.
2602         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm: Added.
2603         (TEST): Tested bundle parameters by verifying that parameter changes in the UI process are observed in the bundle.
2604         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm: Added.
2605         (-[BundleParametersPlugIn webProcessPlugIn:didCreateBrowserContextController:]): Started observing changes to a
2606         bundle parameter and asked for an initial notification.
2607         (-[BundleParametersPlugIn dealloc]): Stopped observing changes to a bundle parameter.
2608         (-[BundleParametersPlugIn observeValueForKeyPath:ofObject:change:context:]): When a bundle parameter changes,
2609         mirror its value in the main frame's JSContext.
2610         * TestWebKitAPI/WKWebViewConfigurationExtras.h: Added.
2611         * TestWebKitAPI/WKWebViewConfigurationExtras.mm: Added.
2612         (+[WKWebViewConfiguration testwebkitapi_configurationWithTestPlugInClassName:]): Created a configuration with
2613         TestWebKitAPI's bundle URL and set a bundle parameter indicating the test plug-in's class name.
2614         * TestWebKitAPI/cocoa/PlatformUtilitiesCocoa.mm: Defined TestPlugInClassNameParameter.
2615         * TestWebKitAPI/cocoa/WebProcessPlugIn/Info.plist: Added. Set the principal class to WebProcessPlugIn.
2616         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm: Added.
2617         (-[WebProcessPlugIn webProcessPlugIn:initializeWithObject:]): Forwarded to a newly-created test class instance.
2618         (-[WebProcessPlugIn respondsToSelector:]): Returned YES if the test class instance response.
2619         (-[WebProcessPlugIn forwardingTargetForSelector:]): Forwarded unimplemented methods to the test class instance.
2620
2621 2015-08-23  Csaba Osztrogonác  <ossy@webkit.org>
2622
2623         URTBF after r188828.
2624
2625         * WebKitTestRunner/PlatformWebView.h:
2626
2627 2015-08-23  Alexey Proskuryakov  <ap@apple.com>
2628
2629         build.webkit.org/dashboard: Combined queues don't turn orange on internal failure
2630         https://bugs.webkit.org/show_bug.cgi?id=148356
2631
2632         Reviewed by Darin Adler.
2633
2634         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
2635         (BuildbotCombinedQueueView.prototype.update):
2636
2637 2015-08-23  Alexey Proskuryakov  <ap@apple.com>
2638
2639         build.webkit.org/dashboard: Respect step's hidden flag
2640         https://bugs.webkit.org/show_bug.cgi?id=148357
2641
2642         Reviewed by Darin Adler.
2643
2644         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2645         (BuildbotIteration.prototype._parseData):
2646
2647 2015-08-23  Nan Wang  <n_wang@apple.com>
2648
2649         AX: Fix accessibility/deleting-iframe-destroys-axcache.html test
2650         https://bugs.webkit.org/show_bug.cgi?id=148328
2651
2652         Reviewed by Darin Adler.
2653
2654         We should only expose stringValue() when value attribute is set.
2655
2656         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2657         (AccessibilityUIElement::stringValue):
2658         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2659         (WTR::AccessibilityUIElement::stringValue):
2660
2661 2015-08-23  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2662
2663         Remove style checking rule regarding OwnPtr and PassOwnPtr
2664         https://bugs.webkit.org/show_bug.cgi?id=148360
2665
2666         Reviewed by Darin Adler.
2667
2668         OwnPtr and PassOwnPtr were totally removed though, style rule is still alive.
2669         Removed it.
2670
2671         * Scripts/do-webcore-rename:
2672         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2673         (PassPtrTest.test_pass_own_ptr_in_function): Deleted.
2674         (PassPtrTest.test_pass_ref_ptr_return_value): Deleted.
2675         (PassPtrTest.test_own_ptr_parameter_value): Deleted.
2676         (WebKitStyleTest.test_names): Deleted.
2677
2678 2015-08-22  Timothy Horton  <timothy_horton@apple.com>
2679
2680         WebKitTestRunner should use WKWebView on OS X and iOS
2681         https://bugs.webkit.org/show_bug.cgi?id=143743
2682         <rdar://problem/16947123>
2683
2684         Reviewed by Anders Carlsson.
2685         Patch by Enrica Casucci and myself.
2686
2687         * WebKitTestRunner/PlatformWebView.h:
2688         (WTR::PlatformWebView::windowSnapshotEnabled): Deleted.
2689         Add a PlatformWebView constructor that takes a WKWebViewConfiguration
2690         instead of WKContext and WKPageGroup.
2691
2692         Remove the unused, always-true windowSnapshotEnabled().
2693         While technically some platforms don't have window snapshotting,
2694         they just return null instead of implementing windowSnapshotEnabled().
2695
2696         * WebKitTestRunner/TestController.h:
2697         * WebKitTestRunner/TestController.cpp:
2698         (WTR::TestController::createOtherPage):
2699         (WTR::TestController::initialize):
2700         (WTR::TestController::createWebViewWithOptions):
2701         Delegate to the various platforms for creating PlatformWebView instances,
2702         for creating WKContexts, and for accessing WKPreferences,
2703         so that they can do special things (like, use WKWebView instead!).
2704
2705         (WTR::TestController::resetPreferencesToConsistentValues):
2706         Make explicit WebKitTestRunner's desired default for two preferences
2707         which have differing defaults between the antique and modern API,
2708         for consistency's sake.
2709
2710         (WTR::TestController::resetStateToConsistentValues):
2711         Add platformResetStateToConsistentValues.
2712
2713         * WebKitTestRunner/TestInvocation.cpp:
2714         (WTR::TestInvocation::dumpResults):
2715         Adjust to the aforementioned removal of windowSnapshotEnabled().
2716
2717         * WebKitTestRunner/ios/TestControllerCocoa.mm:
2718         (WTR::TestController::platformResetStateToConsistentValues):
2719         (WTR::TestController::platformPreferences):
2720         (WTR::TestController::platformCreateWebView):
2721         (WTR::TestController::platformCreateOtherPage):
2722         (WTR::TestController::platformInitializeConfiguration):
2723         Implement the new platform functions for the Modern WebKit2 API,
2724         in a new TestControllerCocoa file that is shared between iOS and Mac.
2725         
2726         For platformMaybeCreateContext, use the trick that we know we can cast
2727         the WKProcessPool to a WKContextRef to retrieve a WKContextRef from
2728         WKWebView's configuration.
2729
2730         Ditto for WKPreferencesRef and WKPreferences.
2731
2732         Remove user content filters on the WKWebView's userContentController.
2733
2734         * WebKitTestRunner/mac/TestControllerMac.mm:
2735         * WebKitTestRunner/ios/TestControllerIOS.mm:
2736         Move code into TestControllerCocoa.
2737
2738         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2739         (WTR::InjectedBundle::beginTesting):
2740         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2741         (WTR::TestRunner::addUserScript):
2742         (WTR::TestRunner::addUserStyleSheet):
2743         Adopt WKBundlePage API for user scripts/sheets.
2744
2745         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2746         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2747         Make and keep a WKWebView instead of a WKView.
2748         
2749         * WebKitTestRunner/mac/EventSenderProxy.mm:
2750         (WTR::EventSenderProxy::mouseUp):
2751         (WTR::EventSenderProxy::mouseMoveTo):
2752         Reach inside the WKWebView to the WKView when dispatching events.
2753         This is fairly ugly and we should come up with a better solution.
2754         Also, fix some flipping and style errors.
2755
2756 2015-08-22  Michael Catanzaro  <mcatanzaro@igalia.com>
2757
2758         Unreviewed, attempt to fix GTK build after r188718
2759
2760         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2761         (WTR::PlatformWebView::PlatformWebView):
2762
2763 2015-08-21  Commit Queue  <commit-queue@webkit.org>
2764
2765         Unreviewed, rolling out r188807, r188813, and r188815.
2766         https://bugs.webkit.org/show_bug.cgi?id=148349
2767
2768         lots of 32-bit build problems, better to resolve separately
2769         and try again (Requested by thorton on #webkit).
2770
2771         Reverted changesets:
2772
2773         "WebKitTestRunner should use WKWebView on OS X and iOS"
2774         https://bugs.webkit.org/show_bug.cgi?id=143743
2775         http://trac.webkit.org/changeset/188807
2776
2777         "Stop building WebKitTestRunner for 32-bit platforms"
2778         https://bugs.webkit.org/show_bug.cgi?id=143743
2779         http://trac.webkit.org/changeset/188813
2780
2781         "Stop building WebKitTestRunner for 32-bit platforms"
2782         https://bugs.webkit.org/show_bug.cgi?id=143743
2783         http://trac.webkit.org/changeset/188815
2784
2785 2015-08-21  Tim Horton  <timothy_horton@apple.com>
2786
2787         Stop building WebKitTestRunner for 32-bit platforms
2788         https://bugs.webkit.org/show_bug.cgi?id=143743
2789         <rdar://problem/16947123>
2790
2791         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2792         This is a restriction on the valid set, not the desired set.
2793
2794 2015-08-21  Jason Marcell  <jmarcell@apple.com>
2795
2796         Make Dashboard.Branches be objects of the form (repository, "branch name") and update existing code
2797         to work with these new objects.
2798         https://bugs.webkit.org/show_bug.cgi?id=148188
2799
2800         Reviewed by Daniel Bates.
2801
2802         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
2803         (Buildbot.prototype._normalizeQueueInfo): Renamed BuildbotQueue.branch to BuildbotQueue.branches.
2804         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
2805         (BuildbotCombinedQueueView): Changed to work with new branch objects which represent a
2806         (repository, "branch name")-pair.
2807         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Ditto.
2808         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2809         (BuildbotQueue): Renamed BuildbotQueue.branch to BuildbotQueue.branches.
2810         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2811         (BuildbotQueueView.prototype._appendPendingRevisionCount): Changed to work with new branch
2812         objects which represent a (repository, "branch name")-pair.
2813         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Ditto.
2814         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Ditto.
2815         (BuildbotQueueView.prototype._addDividerToPopover): Ditto.
2816         (BuildbotQueueView.prototype.revisionContentForIteration): Ditto.
2817         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Renamed
2818         BuildbotQueue.branch to BuildbotQueue.branches.
2819         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2820         (WebKitBuildbot.prototype.get defaultBranches): Changed to new (repository, "branch name") format.
2821
2822 2015-08-21  Tim Horton  <timothy_horton@apple.com>
2823
2824         Stop building WebKitTestRunner for 32-bit platforms
2825         https://bugs.webkit.org/show_bug.cgi?id=143743
2826         <rdar://problem/16947123>
2827
2828         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2829         WKWebView is not available on 32-bit OS X.
2830
2831 2015-08-21  Brent Fulgham  <bfulgham@apple.com>
2832
2833         [Win] Unreviewed test correction after r188709.
2834
2835         I removed a function argument that happened to be mirrored by a global
2836         value with the same name. This prevented a compile error, but testing
2837         showed that the wrong value was being used in the function.
2838
2839         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2840         (FrameLoadDelegate::willPerformClientRedirectToURL): Put function argument
2841         back
2842
2843 2015-08-21  Timothy Horton  <timothy_horton@apple.com>
2844
2845         WebKitTestRunner should use WKWebView on OS X and iOS
2846         https://bugs.webkit.org/show_bug.cgi?id=143743
2847         <rdar://problem/16947123>
2848
2849         Reviewed by Anders Carlsson.
2850         Patch by Enrica Casucci and myself.
2851
2852         * WebKitTestRunner/PlatformWebView.h:
2853         (WTR::PlatformWebView::windowSnapshotEnabled): Deleted.
2854         Add a PlatformWebView constructor that takes a WKWebViewConfiguration
2855         instead of WKContext and WKPageGroup.
2856
2857         Remove the unused, always-true windowSnapshotEnabled().
2858         While technically some platforms don't have window snapshotting,
2859         they just return null instead of implementing windowSnapshotEnabled().
2860
2861         * WebKitTestRunner/TestController.h:
2862         * WebKitTestRunner/TestController.cpp:
2863         (WTR::TestController::createOtherPage):
2864         (WTR::TestController::initialize):
2865         (WTR::TestController::createWebViewWithOptions):
2866         Delegate to the various platforms for creating PlatformWebView instances,
2867         for creating WKContexts, and for accessing WKPreferences,
2868         so that they can do special things (like, use WKWebView instead!).
2869
2870         (WTR::TestController::resetPreferencesToConsistentValues):
2871         Make explicit WebKitTestRunner's desired default for two preferences
2872         which have differing defaults between the antique and modern API,
2873         for consistency's sake.
2874
2875         (WTR::TestController::resetStateToConsistentValues):
2876         Add platformResetStateToConsistentValues.
2877
2878         * WebKitTestRunner/TestInvocation.cpp:
2879         (WTR::TestInvocation::dumpResults):
2880         Adjust to the aforementioned removal of windowSnapshotEnabled().
2881
2882         * WebKitTestRunner/ios/TestControllerCocoa.mm:
2883         (WTR::TestController::platformResetStateToConsistentValues):
2884         (WTR::TestController::platformPreferences):
2885         (WTR::TestController::platformCreateWebView):
2886         (WTR::TestController::platformCreateOtherPage):
2887         (WTR::TestController::platformInitializeConfiguration):
2888         Implement the new platform functions for the Modern WebKit2 API,
2889         in a new TestControllerCocoa file that is shared between iOS and Mac.
2890         
2891         For platformMaybeCreateContext, use the trick that we know we can cast
2892         the WKProcessPool to a WKContextRef to retrieve a WKContextRef from
2893         WKWebView's configuration.
2894
2895         Ditto for WKPreferencesRef and WKPreferences.
2896
2897         Remove user content filters on the WKWebView's userContentController.
2898
2899         * WebKitTestRunner/mac/TestControllerMac.mm:
2900         * WebKitTestRunner/ios/TestControllerIOS.mm:
2901         Move code into TestControllerCocoa.
2902
2903         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2904         (WTR::InjectedBundle::beginTesting):
2905         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2906         (WTR::TestRunner::addUserScript):
2907         (WTR::TestRunner::addUserStyleSheet):
2908         Adopt WKBundlePage API for user scripts/sheets.
2909
2910         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2911         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2912         Make and keep a WKWebView instead of a WKView.
2913         
2914         * WebKitTestRunner/mac/EventSenderProxy.mm:
2915         (WTR::EventSenderProxy::mouseUp):
2916         (WTR::EventSenderProxy::mouseMoveTo):
2917         Reach inside the WKWebView to the WKView when dispatching events.
2918         This is fairly ugly and we should come up with a better solution.
2919         Also, fix some flipping and style errors.
2920
2921 2015-08-21  Alexey Proskuryakov  <ap@apple.com>
2922
2923         Improve how UI events are dispatched by WebKitTestRunner
2924         https://bugs.webkit.org/show_bug.cgi?id=148326
2925
2926         Reviewed by Anders Carlsson.
2927
2928         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2929         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2930         Removed asyncScrolling from mouseScrollByWithWheelAndMomentumPhases, it's now always
2931         asynchronous (and really, it has always been for the most part).
2932
2933         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2934         (WTR::EventSendingController::mouseDown): Updated for WKBundlePagePostSynchronousMessage renaming.
2935         (WTR::EventSendingController::mouseUp): Ditto.
2936         (WTR::EventSendingController::mouseMoveTo): Ditto.
2937         (WTR::EventSendingController::mouseForceDown): Ditto.
2938         (WTR::EventSendingController::mouseForceUp): Ditto.
2939         (WTR::EventSendingController::mouseForceChanged): Ditto.
2940         (WTR::EventSendingController::leapForward): Ditto.
2941         (WTR::EventSendingController::scheduleAsynchronousClick): Ditto.
2942         (WTR::EventSendingController::keyDown): Ditto.
2943         (WTR::EventSendingController::scheduleAsynchronousKeyDown): Ditto.
2944         (WTR::EventSendingController::mouseScrollBy): Force a scrolling tree commit. It used
2945         to be done in custom WebKit2 code for test wheel event handling.
2946         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases): Got rid of sync version.
2947         (WTR::EventSendingController::continuousMouseScrollBy): Added a FIXME. This one is weird.
2948         (WTR::EventSendingController::contextClick): Updated for WKBundlePagePostSynchronousMessage renaming.
2949         (WTR::EventSendingController::addTouchPoint): Ditto.
2950         (WTR::EventSendingController::updateTouchPoint): Ditto.
2951         (WTR::EventSendingController::setTouchModifier): Ditto.
2952         (WTR::EventSendingController::setTouchPointRadius): Ditto.
2953         (WTR::EventSendingController::touchStart): Ditto.
2954         (WTR::EventSendingController::touchMove): Ditto.
2955         (WTR::EventSendingController::touchEnd): Ditto.
2956         (WTR::EventSendingController::touchCancel): Ditto.
2957         (WTR::EventSendingController::clearTouchPoints): Ditto.
2958         (WTR::EventSendingController::releaseTouchPoint): Ditto.
2959         (WTR::EventSendingController::cancelTouchPoint): Ditto.
2960
2961         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2962         (WTR::InjectedBundle::postSetWindowIsKey):
2963         (WTR::InjectedBundle::postSimulateWebNotificationClick):
2964         (WTR::InjectedBundle::isGeolocationProviderActive):
2965         (WTR::InjectedBundle::shouldProcessWorkQueue):
2966         Updated for WKBundlePagePostSynchronousMessage renaming.
2967
2968         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2969         (WTR::TestRunner::secureEventInputIsEnabled): Ditto.
2970
2971         * WebKitTestRunner/TestController.cpp:
2972         (WTR::TestController::initialize): Allow handling the new test style messages.
2973         (WTR::TestController::didReceiveKeyDownMessageFromInjectedBundle): Removed calls
2974         to WKPageSetShouldSendEventsSynchronously, which we no longer need.
2975         (WTR::TestController::didReceiveMessageFromInjectedBundle):
2976         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle): Moved
2977         "MouseScrollBy" to async section, and got rid of WKPageSetShouldSendEventsSynchronously.
2978
2979         * WebKitTestRunner/mac/EventSenderProxy.mm:
2980         (WTR::EventSenderProxy::mouseMoveTo): Got rid of WKPageSetShouldSendEventsSynchronously.
2981         (WTR::EventSenderProxy::keyDown): Ditto.
2982         (WTR::EventSenderProxy::mouseScrollBy): Ditto.
2983         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases): Ditto.
2984
2985 2015-08-21  Yusuke Suzuki  <utatane.tea@gmail.com>
2986
2987         Skip no-llint tests that fail due to running out of executable memory after r188969
2988         https://bugs.webkit.org/show_bug.cgi?id=148273
2989
2990         Reviewed by Michael Saboff.
2991
2992         * Scripts/run-jsc-stress-tests:
2993
2994 2015-08-21  Nan Wang  <n_wang@apple.com>
2995
2996         [Mac] accessibility/selection-states.html fails
2997         https://bugs.webkit.org/show_bug.cgi?id=116637
2998
2999         Reviewed by Chris Fleizach.
3000
3001         Implemented isSelectable() and isMultiSelectable().
3002
3003         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3004         (AccessibilityUIElement::isSelectable):
3005         (AccessibilityUIElement::isMultiSelectable):
3006         (AccessibilityUIElement::isSelectedOptionActive):
3007         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3008         (WTR::AccessibilityUIElement::isSelectable):
3009         (WTR::AccessibilityUIElement::isMultiSelectable):
3010         (WTR::AccessibilityUIElement::isVisible):
3011
3012 2015-08-21  Jason Marcell  <jmarcell@apple.com>
3013
3014         Fix iteration over repositories on bot watcher's dashboard.
3015
3016         Reviewed by Alexey Proskuryakov.
3017
3018         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3019         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Don't reuse the same index variable.
3020
3021 2015-08-20  Joonghun Park  <jh718.park@samsung.com>
3022
3023         [EFL] Revise PlatformWebView ctor according to r188718
3024         https://bugs.webkit.org/show_bug.cgi?id=148282
3025
3026         This patch change PlatformWebView ctor's argument to use WKPageConfigurationRef
3027         instead of WKContextRef and WKPageGroupRef respectively.
3028
3029         Reviewed by Gyuyoung Kim.
3030
3031         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3032         (WTR::PlatformWebView::PlatformWebView):
3033
3034 2015-08-20  Devin Rousso  <dcrousso+webkit@gmail.com>
3035
3036         Unreviewed, changed Devin Rousso's email.
3037
3038         * Scripts/webkitpy/common/config/contributors.json:
3039
3040 2015-08-20  Anders Carlsson  <andersca@apple.com>
3041
3042         Use WKPageConfigurationRef in WebKitTestRunner
3043         https://bugs.webkit.org/show_bug.cgi?id=147996
3044
3045         Reviewed by Tim Horton.
3046
3047         * WebKitTestRunner/TestController.cpp:
3048         (WTR::TestController::createOtherPage):
3049         (WTR::TestController::initialize):
3050         (WTR::TestController::createWebViewWithOptions):
3051         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3052         (-[TestRunnerWKView initWithFrame:configurationRef:useThreadedScrolling:]):
3053         (WTR::PlatformWebView::PlatformWebView):
3054         (-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:relatedToPage:useThreadedScrolling:]): Deleted.
3055
3056 2015-08-20  Brent Fulgham  <bfulgham@apple.com>
3057
3058         [Win] Update Windows tools for revised MIDL interfaces
3059         https://bugs.webkit.org/show_bug.cgi?id=148249
3060
3061         Reviewed by Dean Jackson.
3062
3063         This is a follow-up to Bug 148001.
3064
3065         Revise the testing software to use compatible signatures and
3066         implementations to match the requirements of the IDL generated
3067         with the SAL annotations.
3068
3069         * DumpRenderTree/win/DRTDataObject.cpp:
3070         * DumpRenderTree/win/DRTDataObject.h:
3071         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
3072         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
3073         * DumpRenderTree/win/DRTDropSource.cpp:
3074         * DumpRenderTree/win/DRTDropSource.h:
3075         * DumpRenderTree/win/DumpRenderTree.cpp:
3076         * DumpRenderTree/win/EditingDelegate.cpp:
3077         * DumpRenderTree/win/EditingDelegate.h:
3078         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3079         * DumpRenderTree/win/FrameLoadDelegate.h:
3080         * DumpRenderTree/win/HistoryDelegate.cpp:
3081         * DumpRenderTree/win/HistoryDelegate.h:
3082         * DumpRenderTree/win/PolicyDelegate.cpp:
3083         * DumpRenderTree/win/PolicyDelegate.h:
3084         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3085         * DumpRenderTree/win/ResourceLoadDelegate.h:
3086         * DumpRenderTree/win/TestRunnerWin.cpp:
3087         * DumpRenderTree/win/UIDelegate.cpp:
3088         * DumpRenderTree/win/UIDelegate.h:
3089         * WinLauncher/AccessibilityDelegate.cpp:
3090         * WinLauncher/AccessibilityDelegate.h:
3091         * WinLauncher/Common.cpp:
3092         * WinLauncher/DOMDefaultImpl.cpp:
3093         * WinLauncher/DOMDefaultImpl.h:
3094         * WinLauncher/PageLoadTestClient.cpp:
3095         * WinLauncher/PageLoadTestClient.h:
3096         * WinLauncher/PrintWebUIDelegate.cpp:
3097         * WinLauncher/PrintWebUIDelegate.h:
3098         * WinLauncher/ResourceLoadDelegate.cpp:
3099         * WinLauncher/ResourceLoadDelegate.h:
3100         * WinLauncher/WebDownloadDelegate.cpp:
3101         * WinLauncher/WebDownloadDelegate.h:
3102         * WinLauncher/WinLauncherWebHost.cpp:
3103         * WinLauncher/WinLauncherWebHost.h:
3104         * WinLauncher/WinMain.cpp:
3105         * win/DLLLauncher/DLLLauncherMain.cpp:
3106
3107 2015-08-20  Filip Pizlo  <fpizlo@apple.com>
3108
3109         Unreviewed, shorten a test that runs too long and times out.
3110
3111         * TestWebKitAPI/Tests/WTF/Lock.cpp:
3112         (TestWebKitAPI::TEST):
3113
3114 2015-08-20  Alex Christensen  <achristensen@webkit.org>
3115
3116         Clean up CMake build after r188673
3117         https://bugs.webkit.org/show_bug.cgi?id=148234
3118
3119         Reviewed by Tim Horton.
3120
3121         * DumpRenderTree/PlatformWin.cmake:
3122         * TestWebKitAPI/CMakeLists.txt:
3123         * TestWebKitAPI/PlatformWin.cmake:
3124         Define WIN_CAIRO so WinCairo executables can find the correct dlls in WebKitLibraries.
3125         gtest needs to be a static library on Windows to not crash.
3126
3127 2015-08-19  Alex Christensen  <achristensen@webkit.org>
3128
3129         CMake Windows build should not include files directly from other Source directories
3130         https://bugs.webkit.org/show_bug.cgi?id=148198
3131
3132         Reviewed by Brent Fulgham.
3133
3134         * DumpRenderTree/DumpRenderTreePrefix.h:
3135         Include cmakeconfig.h to properly define all enabled features.
3136         * DumpRenderTree/PlatformWin.cmake:
3137         * TestWebKitAPI/PlatformWin.cmake:
3138
3139 2015-08-19  Alex Christensen  <achristensen@webkit.org>
3140
3141         Build TestWTF on Mac with CMake.
3142         https://bugs.webkit.org/show_bug.cgi?id=147972
3143
3144         Reviewed by Tim Horton.
3145
3146         TestWTF only depends on gtest and WTF instead of TestWebKitAPi depending on all of WebKit.
3147         Now I can run the WTF API tests after a few seconds of building instead of waiting for all of WebKit to build.
3148
3149         * TestWebKitAPI/CMakeLists.txt:
3150         Added WTF as a dependency for platforms that do not have ForwardingHeadersForTestWebKitAPI_NAME.
3151         WTF was already a library that was linked, but having at least one item makes the syntax of add_dependencies work.
3152         * TestWebKitAPI/PlatformMac.cmake: Added.
3153         * TestWebKitAPI/config.h:
3154         Postpone some build fixes until WebKit builds completely on Mac with CMake.
3155
3156 2015-08-19  Brian Burg  <bburg@apple.com>
3157
3158         Unreviewed, add Aleksandr Skachkov to the list of contributors.
3159
3160         * Scripts/webkitpy/common/config/contributors.json:
3161
3162 2015-08-18  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3163
3164         REGRESSION(r188548): [GTK] Build broken.
3165         https://bugs.webkit.org/show_bug.cgi?id=148154
3166
3167         Reviewed by Martin Robinson.
3168
3169         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3170         (WTR::TestController::updatePlatformSpecificViewOptionsForTest):
3171         Even if we don't need to add/override any settings in ViewOptions,
3172         we need to define this as an empty function to make it build.
3173
3174 2015-08-18  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3175
3176         Fix conversion-null warning in conversion.cpp of TestWebKitAPI
3177         https://bugs.webkit.org/show_bug.cgi?id=148073
3178
3179         Reviewed by Alexey Proskuryakov.
3180
3181         * TestWebKitAPI/Tests/WTF/Condition.cpp: Use EXPECT_FALSE instead of EXPECT_EQ.
3182         (TestWebKitAPI::TEST):
3183
3184 2015-08-18  Anders Carlsson  <andersca@apple.com>
3185
3186         Fix test failure fallout from r188602 by using a V5 page ui client struct.
3187
3188         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
3189         (TestWebKitAPI::setUpClients):
3190
3191 2015-08-18  Brian Burg  <bburg@apple.com>
3192
3193         Web Inspector: load ProtocolTestStub from the WebInspectorUI bundle
3194         https://bugs.webkit.org/show_bug.cgi?id=147955
3195
3196         Reviewed by Timothy Hatcher.
3197
3198         To enable sharing of common test code between protocol and model tests,
3199         start loading the protocol TestStub.js through the WebInspectorUI bundle.
3200
3201         This patch adds the read-only getter TestRunner.inspectorTestStubURL, which
3202         protocol-test.js uses to load the inspector frontend stub into its iframe
3203         from an arbitrary local file URL.
3204
3205         * DumpRenderTree/TestRunner.cpp:
3206         (getInspectorTestStubURLCallback):
3207         (TestRunner::staticValues):
3208         * DumpRenderTree/TestRunner.h:
3209         * DumpRenderTree/mac/TestRunnerMac.mm:
3210         (SOFT_LINK_STAGED_FRAMEWORK):
3211         (TestRunner::inspectorTestStubURL):
3212         * DumpRenderTree/win/TestRunnerWin.cpp:
3213         (TestRunner::inspectorTestStubURL):
3214         * WebKitTestRunner/Configurations/Base.xcconfig:
3215         Since WebKitTestRunner now includes WebCore private headers, also search
3216         for the WebCore framework inside the WebKit umbrella framework.
3217
3218         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3219         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3220         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
3221         (WTR::TestRunner::inspectorTestStubURL):
3222         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
3223         (WTR::TestRunner::inspectorTestStubURL):
3224         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
3225         (WTR::TestRunner::inspectorTestStubURL):
3226
3227 2015-08-18  Filip Pizlo  <fpizlo@apple.com>
3228
3229         Unreviewed, fix GTK build.
3230
3231         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp:
3232         (TestWebKitAPI::TEST):
3233
3234 2015-08-17  Filip Pizlo  <fpizlo@apple.com>
3235
3236         Replace all remaining uses of WTF::Mutex with WTF::Lock
3237         https://bugs.webkit.org/show_bug.cgi?id=148089
3238
3239         Reviewed by Geoffrey Garen.
3240
3241         * DumpRenderTree/JavaScriptThreading.cpp:
3242         (javaScriptThreadsMutex):
3243         (runJavaScriptThread):
3244         (startJavaScriptThreads):
3245         (stopJavaScriptThreads):
3246         * TestWebKitAPI/Tests/WTF/Condition.cpp: Fixed a bug in the test that I found from turning the test into a benchmark.
3247         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
3248         (TestWebKitAPI::TEST):
3249         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp:
3250         (TestWebKitAPI::TEST):
3251
3252 2015-08-17  Commit Queue  <commit-queue@webkit.org>
3253
3254         Unreviewed, rolling out r188539, r188544, r188552, and
3255         r188564.
3256         https://bugs.webkit.org/show_bug.cgi?id=148122
3257
3258         Broke tests and some build styles (Requested by ap on
3259         #webkit).
3260
3261         Reverted changesets:
3262
3263         "Web Inspector: load ProtocolTestStub from the WebInspectorUI
3264         bundle"
3265         https://bugs.webkit.org/show_bug.cgi?id=147955
3266         http://trac.webkit.org/changeset/188539
3267
3268         "Web Inspector: split TestStub.js into multiple files and
3269         modernize it"
3270         https://bugs.webkit.org/show_bug.cgi?id=148077
3271         http://trac.webkit.org/changeset/188544
3272
3273         "Web Inspector: InspectorTest should be a subclass of
3274         TestHarness"
3275         https://bugs.webkit.org/show_bug.cgi?id=148079
3276         http://trac.webkit.org/changeset/188552
3277
3278         "Unreviewed internal build fix attempt after r188539."
3279         http://trac.webkit.org/changeset/188564
3280
3281 2015-08-17  Myles C. Maxfield  <mmaxfield@apple.com>
3282
3283         [OS X] Remove support for composite fonts
3284         https://bugs.webkit.org/show_bug.cgi?id=147920
3285
3286         Reviewed by Dan Bernstein.
3287
3288         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3289         * DumpRenderTree/fonts/SampleFont.sfont: Removed.
3290         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
3291         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
3292         * DumpRenderTree/mac/DumpRenderTree.mm:
3293         (allowedFontFamilySet): Deleted.
3294         (activateTestingFonts): Deleted.
3295         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
3296         (WTR::allowedFontFamilySet): Deleted.
3297         (WTR::activateFonts): Deleted.
3298         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3299         * WebKitTestRunner/fonts/SampleFont.sfont: Removed.
3300         * WebKitTestRunner/mac/TestControllerMac.mm:
3301         (WTR::allowedFontFamilySet): Deleted.
3302
3303 2015-08-17  Jon Honeycutt  <jhoneycutt@apple.com>
3304
3305         Unreviewed internal build fix attempt after r188539.
3306
3307         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
3308
3309 2015-08-17  Myles C. Maxfield  <mmaxfield@apple.com>
3310
3311         Fix the build
3312
3313         Unreviewed.
3314
3315         * TestWebKitAPI/Tests/WTF/StringHasher.cpp:
3316
3317 2015-08-17  Alex Christensen  <achristensen@webkit.org>
3318
3319         Build Debug Suffix on Windows with CMake
3320         https://bugs.webkit.org/show_bug.cgi?id=148083
3321
3322         Reviewed by Brent Fulgham.
3323
3324         * TestWebKitAPI/CMakeLists.txt:
3325         * TestWebKitAPI/PlatformWin.cmake:
3326         Add DEBUG_SUFFIX
3327
3328 2015-08-17  Anders Carlsson  <andersca@apple.com>
3329
3330         Simplify how PlatformWebViews are created when view options change
3331         https://bugs.webkit.org/show_bug.cgi?id=148093
3332
3333         Reviewed by Sam Weinig.
3334
3335         Instead of letting each port dictate when the PlatformWebView should be recreated we now do the following:
3336
3337         TestController::ensureViewSupportsOptionsForTest gets the view options for a test by calling
3338         TestController::viewOptionsForTest, which returns a filled in ViewOptions struct for a given test. It also allows
3339         ports to add/override settings by calling TestController::updatePlatformSpecificViewOptionsForTest.
3340
3341         If the current PlatformWebView doesn't support the given view options, delete the web view and create a new one.
3342
3343         Also, get rid of the first call to TestController::createWebViewWithOptions in TestController::initialize and
3344         always rely on TestController::ensureViewSupportsOptionsForTest creating a PlatformWebView for us.
3345
3346         * WebKitTestRunner/TestController.cpp:
3347         (WTR::TestController::ensureViewSupportsOptionsForTest):
3348         (WTR::shouldUseFixedLayout):
3349         (WTR::TestController::viewOptionsForTest):
3350         (WTR::TestController::updateWebViewSizeForTest):
3351         (WTR::TestController::updateWindowScaleForTest):
3352         (WTR::TestController::configureViewForTest):
3353         (WTR::TestController::initialize): Deleted.
3354         (WTR::TestController::ensureViewSupportsOptions): Deleted.
3355         (WTR::TestController::updateLayoutTypeForTest): Deleted.
3356         (WTR::TestController::platformConfigureViewForTest): Deleted.
3357         (WTR::TestController::platformResetPreferencesToConsistentValues): Deleted.
3358         (WTR::TestController::run): Deleted.
3359         * WebKitTestRunner/TestController.h:
3360         * WebKitTestRunner/efl/TestControllerEfl.cpp:
3361         (WTR::shouldUseFixedLayout):
3362         (WTR::TestController::updatePlatformSpecificViewOptionsForTest):
3363         (WTR::TestController::platformConfigureViewForTest):
3364         (WTR::TestController::platformResetPreferencesToConsistentValues):
3365         * WebKitTestRunner/ios/TestControllerIOS.mm:
3366         (WTR::TestController::updatePlatformSpecificViewOptionsForTest):
3367         * WebKitTestRunner/mac/TestControllerMac.mm:
3368         (WTR::TestController::updatePlatformSpecificViewOptionsForTest):
3369         (WTR::TestController::platformConfigureViewForTest):
3370
3371 2015-08-17  Sam Weinig  <sam@webkit.org>
3372
3373         API::PageConfiguration's sessionID needs to be set whenever the API::WebsiteDataStore is set
3374         https://bugs.webkit.org/show_bug.cgi?id=148097
3375
3376         Reviewed by Anders Carlsson.
3377
3378         * TestWebKitAPI/Tests/WebKit2/WKPageConfiguration.cpp:
3379         Add tests for WebsiteDataStores in the WKPageConfiguration.
3380
3381 2015-08-17  Brian Burg  <bburg@apple.com>
3382
3383         Web Inspector: load ProtocolTestStub from the WebInspectorUI bundle
3384         https://bugs.webkit.org/show_bug.cgi?id=147955
3385
3386         Reviewed by Timothy Hatcher.
3387
3388         To enable sharing of common test code between protocol and model tests,
3389         start loading the protocol TestStub.js through the WebInspectorUI bundle.
3390
3391         This patch adds the read-only getter TestRunner.inspectorTestStubURL, which
3392         protocol-test.js uses to load the inspector frontend stub into its iframe
3393         from an arbitrary local file URL.
3394
3395         * DumpRenderTree/TestRunner.cpp:
3396         (getInspectorTestStubURLCallback):
3397         (TestRunner::staticValues):
3398         * DumpRenderTree/TestRunner.h:
3399         * DumpRenderTree/mac/TestRunnerMac.mm:
3400         (SOFT_LINK_STAGED_FRAMEWORK):
3401         (TestRunner::inspectorTestStubURL):
3402         * DumpRenderTree/win/TestRunnerWin.cpp:
3403         (TestRunner::inspectorTestStubURL):
3404         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3405         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3406         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
3407         (WTR::TestRunner::inspectorTestStubURL):
3408         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
3409         (WTR::TestRunner::inspectorTestStubURL):
3410         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
3411         (WTR::TestRunner::inspectorTestStubURL):
3412
3413 2015-08-17  Saam barati  <sbarati@apple.com>
3414
3415         Change email address from saambarati1@gmail.com to sbarati@apple.com
3416
3417         * Scripts/webkitpy/common/config/contributors.json:
3418
3419 2015-08-17  Jason Marcell  <jmarcell@apple.com>
3420
3421         Refactor BuildbotQueueView._presentPopoverForPendingCommits to work more generically with
3422         repositories other than "openSource" and "internal".
3423         https://bugs.webkit.org/show_bug.cgi?id=147961
3424
3425         Reviewed by Daniel Bates.
3426
3427         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3428         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Refactored to work more
3429         generically with repositories other than "openSource" and "internal".
3430
3431 2015-08-17  Alexey Proskuryakov  <ap@apple.com>
3432
3433         build.webkit.org/dashboard shows yellow when crash-only queues have too many failures
3434         https://bugs.webkit.org/show_bug.cgi?id=148081
3435
3436         Reviewed by Tim Horton.
3437
3438         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3439         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
3440
3441 2015-08-11  Andy Estes  <aestes@apple.com>
3442
3443         [Cocoa] Add redirect support to CustomProtocolManager
3444         https://bugs.webkit.org/show_bug.cgi?id=147871
3445
3446         Reviewed by Dan Bernstein.
3447
3448         Updated WebKit2CustomProtocolsTest.MainResource to generate a redirect response.
3449
3450         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
3451         (TestWebKitAPI::TEST): Unregesitered TestProtocol.
3452         * TestWebKitAPI/Tests/WebKit2/custom-protocol-sync-xhr.html: Changed scheme to http.
3453         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
3454         (-[CustomProtocolsLoadDelegate browsingContextControllerDidStartProvisionalLoad:]): Expected a certain provisional URL.
3455         (-[CustomProtocolsLoadDelegate browsingContextControllerDidReceiveServerRedirectForProvisionalLoad:]): Ditto.
3456         (-[CustomProtocolsLoadDelegate browsingContextControllerDidCommitLoad:]): Expected a certain committed URL.
3457         (-[CustomProtocolsLoadDelegate browsingContextControllerDidFinishLoad:]): Expected isLoading to be false.
3458         (TestWebKitAPI::TEST): Used the new load delegate and unregistered TestProtocol.
3459         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
3460         (TestWebKitAPI::TEST): Unregistered TestProtocol.
3461         * TestWebKitAPI/mac/TestProtocol.mm: Changed scheme to http.
3462         (+[TestProtocol canInitWithRequest:]): Changed to use property syntax.
3463         (-[TestProtocol startLoading]): Taught to handle redirect responses.
3464
3465 2015-08-13  Andy Estes  <aestes@apple.com>
3466
3467         [Cocoa] Downloads do not start if policy decision is made asynchronously
3468         https://bugs.webkit.org/show_bug.cgi?id=147985
3469
3470         Reviewed by Brady Eidson.
3471
3472         Added a new API test.
3473
3474         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3475         (-[AsynchronousDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3476         (-[AsynchronousDownloadDelegate _downloadDidStart:]):
3477         (TEST):
3478
3479 2015-08-14  Commit Queue  <commit-queue@webkit.org>
3480
3481         Unreviewed, rolling out r187357.
3482         https://bugs.webkit.org/show_bug.cgi?id=148032
3483
3484         webkit-patch generates incorrect patches that cannot be
3485         applied (Requested by dydz on #webkit).
3486
3487         Reverted changeset:
3488
3489         "Call fixChangeLogPatch when generating patches from webkit-
3490         patch"
3491         https://bugs.webkit.org/show_bug.cgi?id=147248
3492         http://trac.webkit.org/changeset/187357
3493
3494 2015-08-14  Jason Marcell  <jmarcell@apple.com>
3495
3496         Refactor BuildbotQueueView._appendPendingRevisionCount to work more generically with repositories
3497         other than "openSource" and "internal".
3498         https://bugs.webkit.org/show_bug.cgi?id=147938
3499
3500         Reviewed by Daniel Bates.
3501
3502         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3503         (BuildbotQueueView.prototype._appendPendingRevisionCount): Refactored to work more generically with
3504         repositories other than "openSource" and "internal".
3505
3506 2015-08-14  Filip Pizlo  <fpizlo@apple.com>
3507
3508         Unreviewed, shorten another test that is timing out.
3509
3510         * TestWebKitAPI/Tests/WTF/Lock.cpp:
3511         (TestWebKitAPI::TEST):
3512
3513 2015-08-13  Aakash Jain  <aakash_jain@apple.com>
3514
3515         AppScale: Assertion hit when hovering a webkit-queue bubble
3516         https://bugs.webkit.org/show_bug.cgi?id=147997
3517
3518         Reviewed by Alexey Proskuryakov.
3519
3520         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueue.js:
3521         (BubbleQueue.prototype.loadDetailedStatus): Strip off http(s) before asserting.
3522
3523 2015-08-13  Lucas Forschler  <lforschler@apple.com>
3524
3525         Teach Scripts/copy-webkitlibraries-to-product-directory to copy the El Capitan Library.
3526         
3527         Unreviewed.
3528         
3529         * Scripts/copy-webkitlibraries-to-product-directory:
3530
3531 2015-08-13  Dewei Zhu  <dewei_zhu@apple.com>
3532
3533         Run benchmark customized Dromaeo should not assume there is an internet connection.
3534         https://bugs.webkit.org/show_bug.cgi?id=147995
3535
3536         Reviewed by Ryosuke Niwa.
3537
3538         Add several dependency js libs to local.
3539
3540         * Scripts/webkitpy/benchmark_runner/data/patches/Dromaeo.patch:
3541
3542 2015-08-13  Filip Pizlo  <fpizlo@apple.com>
3543
3544         WTF should have a compact Condition object to use with Lock
3545         https://bugs.webkit.org/show_bug.cgi?id=147986
3546
3547         Reviewed by Geoffrey Garen.
3548
3549         Add a test for WTF::Condition.
3550
3551         * TestWebKitAPI/CMakeLists.txt:
3552         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
3553         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3554         * TestWebKitAPI/Tests/WTF/Condition.cpp: Added.
3555         (TestWebKitAPI::TEST):
3556         * TestWebKitAPI/Tests/WTF/Lock.cpp:
3557         (TestWebKitAPI::runLockTest): Change the name of the thread.
3558
3559 2015-08-13  Filip Pizlo  <fpizlo@apple.com>
3560
3561         Unreviewed, shorten another test. It's timing out in debug on some bot.
3562
3563         * TestWebKitAPI/Tests/WTF/Lock.cpp:
3564         (TestWebKitAPI::TEST):
3565
3566 2015-08-12  Filip Pizlo  <fpizlo@apple.com>
3567
3568         WTF::Lock should not suffer from the thundering herd
3569         https://bugs.webkit.org/show_bug.cgi?id=147947
3570
3571         Reviewed by Geoffrey Garen.
3572
3573         Add testing that checks that locks return to a pristine state after contention is over.
3574
3575         * TestWebKitAPI/Tests/WTF/Lock.cpp:
3576         (TestWebKitAPI::LockInspector::isFullyReset):
3577         (TestWebKitAPI::runLockTest):
3578         (TestWebKitAPI::TEST):
3579
3580 2015-08-12  Dewei Zhu  <dewei_zhu@apple.com>
3581
3582         Benchmarks supported by run_benchmark script should not assume we have internet access.
3583         https://bugs.webkit.org/show_bug.cgi?id=147959
3584
3585         Reviewed by Ryosuke Niwa.
3586
3587         For JSBench we should not request jquery.min.js from google through the internet.
3588
3589         * Scripts/webkitpy/benchmark_runner/data/patches/JSBench.patch:
3590
3591 2015-08-12  Jason Marcell  <jmarcell@apple.com>
3592
3593         Refactor BuildbotQueueView.revisionContentForIteration to work more generically with repositories
3594         other than "openSource" and "internal".
3595         https://bugs.webkit.org/show_bug.cgi?id=147796
3596
3597         Reviewed by Daniel Bates.
3598
3599         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3600         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): The "repository" parameter
3601         is now a repository object instead of the repository name, thus we don't have to pass the "trac"
3602         object in separately. Also added an assertion to see if the given repository is in iteration.revision,
3603         and another assertion that, if the previousIteration is non-null, the given repository is in
3604         previousIteration.revision.
3605         (BuildbotQueueView.prototype.revisionContentForIteration): Refactored to work more generically
3606         with repositories other than "openSource" and "internal". Also added an assertion that the returned
3607         fragment has at least one child node.
3608
3609 2015-08-12  Simon Fraser  <simon.fraser@apple.com>
3610
3611         Add a tool that dumps class and struct member layout, showing padding
3612         https://bugs.webkit.org/show_bug.cgi?id=147898
3613
3614         Reviewed by Zalan Bujtas.
3615         
3616         This 'dump-class-layout' script uses the lldb Python bindings to collect data
3617         about data member layout, and displays it.
3618         
3619         Sample output:
3620
3621               +0 { 72} WTF::ListHashSet<WebCore::URL, WebCore::URLHash>::Node
3622               +0 < 56>     WebCore::URL m_value;
3623               +0 <  8>         WTF::String m_string;
3624               +0 <  8>             WTF::RefPtr<WTF::StringImpl> m_impl;
3625               +0 <  8>                 WTF::StringImpl * m_ptr;
3626               +8 <  1>         bool:1 m_isValid;
3627               +8 <  1>         bool:1 m_protocolIsInHTTPFamily;
3628               +9 <  3>         <PADDING>
3629              +12 <  4>         int m_schemeEnd;
3630              +16 <  4>         int m_userStart;
3631              +20 <  4>         int m_userEnd;
3632              +24 <  4>         int m_passwordEnd;
3633              +28 <  4>         int m_hostEnd;
3634              +32 <  4>         int m_portEnd;
3635              +36 <  4>         int m_pathAfterLastSlash;
3636              +40 <  4>         int m_pathEnd;
3637              +44 <  4>         int m_queryEnd;
3638              +48 <  4>         int m_fragmentEnd;
3639              +52 <  4>         <PADDING>
3640              +52 <  4>     <PADDING>
3641              +56 <  8>     WTF::ListHashSetNode<WebCore::URL> * m_prev;
3642              +64 <  8>     WTF::ListHashSetNode<WebCore::URL> * m_next;
3643             Total byte size: 72
3644             Total pad bytes: 11
3645             Padding percentage: 15.28 %
3646
3647         * Scripts/dump-class-layout: Added.
3648         (webkit_build_dir):
3649         (developer_dir):
3650         (import_lldb):
3651         (find_build_directory):
3652         (verify_type):
3653         (verify_type_recursive):
3654         (dump_class):
3655         (main):
3656         (main.or):
3657
3658 2015-08-12  Alex Christensen  <achristensen@webkit.org>
3659
3660         Fix Debug CMake builds on Windows
3661         https://bugs.webkit.org/show_bug.cgi?id=147940
3662
3663         Reviewed by Chris Dumez.
3664
3665         * DumpRenderTree/PlatformWin.cmake:
3666         * TestWebKitAPI/PlatformWin.cmake:
3667         The BitmapImage test is not enabled on the AppleWin port.
3668         * WinLauncher/CMakeLists.txt:
3669         Debug builds need /NODEFAULTLIB:MSVCRTD, too.
3670
3671 2015-08-12  Carlos Garcia Campos  <cgarcia@igalia.com>
3672
3673         Unreviewed. run-gtk-tests: Use a longer timeout for slow tests.
3674
3675         In r188125 I added a way to mark tests as slow to use a longer
3676         timeout. But it seems it was not enough for
3677         WTF_Lock.ContendedShortSection, so let's try again with a longer
3678         timeout now.
3679
3680         * Scripts/run-gtk-tests:
3681         (TestRunner._run_google_test):
3682
3683 2015-08-12  Yusuke Suzuki  <utatane.tea@gmail.com>
3684
3685         Allow --debug option in run-jsc
3686         https://bugs.webkit.org/show_bug.cgi?id=147923
3687
3688         Reviewed by Csaba Osztrogonác.
3689
3690         When `--debug` option is specified in run-jsc, it runs the JSC shell built in the debug mode.
3691
3692         * Scripts/run-jsc:
3693
3694 2015-08-11  Alex Christensen  <achristensen@webkit.org>
3695
3696         Fix test after build fix in r188286.
3697         https://bugs.webkit.org/show_bug.cgi?id=147907
3698
3699         Reviewed by Anders Carlsson.
3700
3701         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
3702         sleep_for can now be used, but we need to include <thread>
3703
3704 2015-08-11  Filip Pizlo  <fpizlo@apple.com>
3705
3706         Always use a byte-sized lock implementation
3707         https://bugs.webkit.org/show_bug.cgi?id=147908
3708
3709         Reviewed by Geoffrey Garen.
3710
3711         All previous tests of Lock are now tests of WordLock. All previous tests of ByteLock are
3712         now tests of Lock.
3713
3714         * TestWebKitAPI/Tests/WTF/Lock.cpp:
3715         (TestWebKitAPI::runLockTest):
3716         (TestWebKitAPI::TEST):
3717
3718 2015-08-11  Alexey Proskuryakov  <ap@apple.com>
3719
3720         Make ASan build not depend on asan.xcconfig
3721         https://bugs.webkit.org/show_bug.cgi?id=147840
3722         rdar://problem/21093702
3723
3724         Reviewed by Daniel Bates.
3725
3726         * asan/asan.xcconfig:
3727         * asan/webkit-asan-ignore.txt: Removed. It's no longer needed, as unsafe functions
3728         are now marked in source code.
3729
3730 2015-08-11  Filip Pizlo  <fpizlo@apple.com>
3731
3732         Unreviewed, shorten another test since it timed out.
3733
3734         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
3735         (TestWebKitAPI::TEST):
3736
3737 2015-08-11  Mark Lam  <mark.lam@apple.com>
3738
3739         Fix names of Lock tests: should be "Contended", not "Contented".
3740         https://bugs.webkit.org/show_bug.cgi?id=147905
3741
3742         Reviewed by Saam Barati.
3743
3744         We're testing the behavior of lock contention (i.e. when threads contend), not
3745         whether the locks are happy (contented).
3746
3747         * Scripts/run-gtk-tests:
3748         (TestRunner):
3749         (TestRunner.__init__): Deleted.
3750         * TestWebKitAPI/Tests/WTF/Lock.cpp:
3751         (TestWebKitAPI::runLockTest):
3752         (TestWebKitAPI::TEST):
3753
3754 2015-08-11  Alex Christensen  <achristensen@webkit.org>
3755
3756         Update WinCairoRequirements to VS2015.
3757
3758         * Scripts/update-webkit-wincairo-libs:
3759         Update WinCairoRequirements location.
3760
3761 2015-08-11  Jason Marcell  <jmarcell@apple.com>
3762
3763         Substituted Dashboard.Repository.OpenSource.trac for webkitTrac and Dashboard.Repository.Internal.trac
3764         for internalTrac.
3765         https://bugs.webkit.org/show_bug.cgi?id=147805
3766
3767         Reviewed by Daniel Bates.
3768
3769         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3770         (BuildbotQueueView): Substituted Dashboard.Repository.OpenSource.trac for webkitTrac and
3771         Dashboard.Repository.Internal.trac for internalTrac.
3772         (BuildbotQueueView.prototype._appendPendingRevisionCount): Added local variables webkitTrac
3773         and internalTrac for Dashboard.Repository.OpenSource.trac and Dashboard.Repository.Internal.trac,
3774         respectively.
3775         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Ditto.
3776         (BuildbotQueueView.prototype.revisionContentForIteration): Substituted
3777         Dashboard.Repository.OpenSource.trac for webkitTrac and Dashboard.Repository.Internal.trac for
3778         internalTrac.
3779         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js: Ditto.
3780         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Ditto.
3781         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
3782         (Analyzer): Ditto.
3783         (Analyzer.prototype.analyze): Ditto.
3784
3785 2015-08-11  Filip Pizlo  <fpizlo@apple.com>
3786
3787         Unreviewed, gardening these tests to run faster so that they don't timeout on slower OSes.
3788
3789         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
3790         (TestWebKitAPI::TEST):
3791
3792 2015-08-11  Brent Fulgham  <bfulgham@apple.com>
3793
3794         [Win] Switch Windows build to Visual Studio 2015
3795         https://bugs.webkit.org/show_bug.cgi?id=147887
3796         <rdar://problem/22235098>
3797
3798         Reviewed by Alex Christensen.
3799
3800         Update Visual Studio project file settings to use the current Visual
3801         Studio and compiler. Continue targeting binaries to run on our minimum
3802         supported configuration of Windows 7.
3803
3804         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
3805         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
3806         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
3807         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
3808         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
3809         * Scripts/webkitdirs.pm: Modify our Visual Studio search routines to
3810         prefer the newer MSBuild included in Visual Studio 2015.
3811         (visualStudioInstallDir):
3812         (msBuildInstallDir):
3813         (visualStudioVersion):
3814         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
3815         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
3816         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
3817         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
3818         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
3819         * win/record-memory/record-memory.vcxproj:
3820
3821 2015-08-11  Alex Christensen  <achristensen@webkit.org>
3822
3823         Another speculative build fix after r188280.
3824
3825         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
3826         std::this_thread is too modern c++ for VS2013 and supported GCC versions, 
3827         so let's go back to usleep and I made something close to usleep, but with much lower resolution.
3828
3829 2015-08-11  Alex Christensen  <achristensen@webkit.org>
3830
3831         Unreviewed build fix after r188280.
3832
3833         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
3834         Include DataLog.h, and usleep is not available on Windows, so I used what I think is the c++11 equivalent.
3835
3836 2015-08-10  Filip Pizlo  <fpizlo@apple.com>
3837
3838         WTF should have a ParkingLot for parking sleeping threads, so that locks can fit in 1.6 bits
3839         https://bugs.webkit.org/show_bug.cgi?id=147665
3840
3841         Reviewed by Mark Lam.
3842
3843         * TestWebKitAPI/CMakeLists.txt:
3844         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
3845         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3846         * TestWebKitAPI/Tests/WTF/Lock.cpp:
3847         (TestWebKitAPI::TEST):
3848         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp: Added.
3849         (TestWebKitAPI::TEST):
3850
3851 2015-08-11  Brian Burg  <bburg@apple.com>
3852
3853         webkit-patch should not explode when $EDITOR is set incorrectly
3854         https://bugs.webkit.org/show_bug.cgi?id=147884
3855
3856         Reviewed by Darin Adler.
3857
3858         If $EDITOR doesn't exist, log a warning and continue.
3859
3860         * Scripts/webkitpy/common/system/user.py: 
3861         (User.edit):
3862         (User.edit_changelog):
3863
3864 2015-08-11  Dan Bernstein  <mitz@apple.com>
3865
3866         Reverted r188255, because it turned out that delegates do nonot need this information.
3867
3868         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3869         * TestWebKitAPI/Tests/WebKit2Cocoa/PrintFrame.mm: Removed.
3870
3871 2015-08-11  Dan Bernstein  <mitz@apple.com>
3872
3873         [Cocoa] The UI delegate can't tell if printing was user-initiated
3874         https://bugs.webkit.org/show_bug.cgi?id=147869
3875
3876         Reviewed by Sam Weinig.
3877
3878         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3879         * TestWebKitAPI/Tests/WebKit2Cocoa/PrintFrame.mm: Added.
3880         (-[PrintFrameController webView:didFinishNavigation:]):
3881         (-[PrintFrameController _webView:printFrame:userInitiated:]):
3882         (TEST):
3883
3884 2015-08-10  Alex Christensen  <achristensen@webkit.org>
3885
3886         Another build fix after r188239.
3887
3888         * TestWebKitAPI/PlatformWin.cmake:
3889         Link with more libraries.
3890         * WinLauncher/CMakeLists.txt:
3891         /NODEFAULTLIB:MSVCRT is not just needed for AppleWin.
3892
3893 2015-08-10  Ryosuke Niwa  <rniwa@webkit.org>
3894
3895         Build fix after r188237.
3896
3897         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
3898         (BenchmarkBuilder.__enter__):
3899
3900 2015-08-10  Dewei Zhu  <dewei_zhu@apple.com>
3901
3902         Update ReadMe and correct the way to use abstract abstract class.
3903         https://bugs.webkit.org/show_bug.cgi?id=147860
3904
3905         Reviewed by Ryosuke Niwa.
3906
3907         Update ReadMe according to recent changes. And set ABCMeta to be the __metaclass__ of BrowserDriver and HTTPServerDriver,
3908         so that all methods annotated by 'abstractmethod' will check whether they are implememnt by subclasses.
3909
3910         * Scripts/webkitpy/benchmark_runner/README.md:
3911         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
3912         (BrowserDriver):
3913         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3914         (OSXBrowserDriver.restore_env):
3915         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
3916         (HTTPServerDriver):
3917         (HTTPServerDriver.set_device_id):
3918         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
3919         (SimpleHTTPServerDriver.get_return_code):
3920         (SimpleHTTPServerDriver):
3921         (SimpleHTTPServerDriver.set_device_id):
3922
3923 2015-08-10  Alex Christensen  <achristensen@webkit.org>
3924
3925         Build TestWebKitAPI with CMake on Windows
3926         https://bugs.webkit.org/show_bug.cgi?id=147851
3927
3928         Reviewed by Chris Dumez.
3929
3930         * CMakeLists.txt:
3931         * TestWebKitAPI/CMakeLists.txt:
3932         Removed TestJavaScriptCore because JavaScriptCore's API tests are elsewhere and this was just making an empty binary.
3933         Surrounded WebKit2-specific features with ENABLE_WEBKIT2 checks.
3934         Include directories after the Platform*.cmake is included because HostWindow.h needs to be found in Tools/TestWebKitAPI/win 
3935         before we look in Source/WebCore/platform, where another file named HostWindow.h exists.
3936         * TestWebKitAPI/PlatformEfl.cmake:
3937         * TestWebKitAPI/PlatformGTK.cmake:
3938         Windows needs all the binaries to be in the same directory to find gtest.dll and the other dlls.
3939         I did this without changing the directory structure of the existing EFL and GTK builds.
3940         * TestWebKitAPI/PlatformWin.cmake: Added.
3941         * TestWebKitAPI/win/main.cpp:
3942         (main):
3943         (dllLauncherEntryPoint):
3944         Added so we can launch TestWebKitAPI executables after finding the AAS directory.
3945         * WinLauncher/CMakeLists.txt:
3946         AppleWin port needs /NODEFAULTLIB:MSVCRT.
3947
3948 2015-08-10  Dewei Zhu  <dewei_zhu@apple.com>
3949
3950         Make cleanup more robust and minor code cleaning in run benchmark script.
3951         https://bugs.webkit.org/show_bug.cgi?id=147800
3952
3953         Reviewed by Ryosuke Niwa.
3954
3955         Use 'finnaly' block to make sure cleanup code is always executed.
3956
3957         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
3958         (built_benchmark):
3959         (built_benchmark.__init__):
3960         (built_benchmark.__enter__):
3961         (built_benchmark.__exit__):
3962         (test_environment):
3963         (test_environment.__init__):
3964         (test_environment.__enter__):
3965         (test_environment.__exit__):
3966         (BenchmarkRunner.__init__):
3967         (BenchmarkRunner.execute):
3968         (BenchmarkRunner._dump):
3969         (BenchmarkRunner._wrap):
3970         (BenchmarkRunner): Deleted.
3971         (BenchmarkRunner._cleanup): Deleted.
3972         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
3973         (BrowserDriver.close_browsers):
3974         (BrowserDriver):
3975         (BrowserDriver.restore_env):
3976         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
3977         (SimpleHTTPServerDriver.__init__): We do not actually need to know external ip address for now.
3978
3979 2015-08-10  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3980
3981         Compile warning (-Wsign-compare) on 32-bits at WebCore/platform/FileSystem.cpp
3982         https://bugs.webkit.org/show_bug.cgi?id=146414
3983
3984         Reviewed by Darin Adler.
3985
3986         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
3987         (TestWebKitAPI::TEST): Improving testing of WTF::isInBounds.
3988
3989 2015-08-10  Carlos Garcia Campos  <cgarcia@igalia.com>
3990
3991         [GTK] Test  /webkit2/WebKitWebView/submit-form is flaky
3992         https://bugs.webkit.org/show_bug.cgi?id=147727
3993
3994         Reviewed by Sergio Villar Senin.
3995
3996         I think it was not this test in particular, but
3997         /webkit2/WebKitWebView/custom-charset that is affecting the
3998         others. This is because changing the encoding reloads the page,
3999         but we don't wait for the page to be reloaded, so when the test
4000         finishes and other test starts the web process is still reloading
4001         the page.
4002
4003         * Scripts/run-gtk-tests:
4004         (TestRunner): Unskip /webkit2/WebKitWebView/submit-form.
4005         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
4006         (testWebViewCustomCharset): Wait until page is reloaded after
4007         changing the charset.
4008
4009 2015-08-09  Carlos Garcia Campos  <cgarcia@igalia.com>
4010
4011         Unreviewed. Skip GTK+ test /webkit2/WebKitWebView/install-missing-plugins-permission-request.
4012
4013         It's timing out in the bots. My guess is that there's no installer
4014         installed in the bots and gst_install_plugins_supported() returns
4015         false, so we don't even get a permission request because no
4016         installer will be launched.
4017
4018         * Scripts/run-gtk-tests:
4019         (TestRunner):
4020
4021 2015-08-07  Alex Christensen  <achristensen@webkit.org>
4022
4023         [GTK] Another build fix after r188157.
4024
4025         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
4026         (WTR::PlatformWebView::viewSupportsOptions):
4027         Name all the things correctly!
4028
4029 2015-08-07  Alex Christensen  <achristensen@webkit.org>
4030
4031         [EFL, GTK] Build fix after r188176.
4032
4033         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
4034         I moved forwarding headers out of a unix subdirectory because I am using them on Windows now.
4035
4036 2015-08-07  Alex Christensen  <achristensen@webkit.org>
4037
4038         [GTK] Speculative build fix after r188157.
4039
4040         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
4041         (WTR::PlatformWebView::PlatformWebView):
4042         Update parameter list.
4043
4044 2015-08-07  Alex Christensen  <achristensen@webkit.org>
4045
4046         Build more testing binaries with CMake on Windows
4047         https://bugs.webkit.org/show_bug.cgi?id=147799
4048
4049         Reviewed by Brent Fulgham.
4050
4051         * DumpRenderTree/CMakeLists.txt:
4052         Build TestNetscapePlugin.
4053         * DumpRenderTree/PlatformWin.cmake:
4054         Build ImageDiff and add files necessary for TestNetscapePlugin on Windows.
4055         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders: Added.
4056         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit: Added.
4057         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Copied from DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npapi.h.
4058         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Copied from DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npfunctions.h.
4059         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Copied from DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npruntime.h.
4060         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npapi.h: Removed.
4061         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npfunctions.h: Removed.
4062         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npruntime.h: Removed.
4063
4064 2015-08-07  Jason Marcell  <jmarcell@apple.com>
4065
4066         Refactor BuildbotQueue.compareIterations and BuildbotQueue.compareIterationsByRevisions to be more generic
4067         https://bugs.webkit.org/show_bug.cgi?id=147667
4068
4069         Reviewed by Daniel Bates.
4070
4071         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
4072         (BuildbotQueue.prototype.compareIterations): Refactored to work more generically with repositories
4073         other than "openSource" and "internal".
4074         (BuildbotQueue.prototype.compareIterationsByRevisions): Ditto.
4075         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
4076         (Dashboard.get sortedPlatforms): Added. Returns a sorted array of platforms.
4077         (Dashboard.get sortedRepositories): Added. Returns a sorted array of repositories.
4078         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
4079         (documentReady): Using Dashboard.sortedPlatforms instead of sortedPlatforms.
4080         (sortedPlatforms): Deleted.
4081         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
4082         (buildQueuesTable): Using Dashboard.sortedPlatforms instead of sortedPlatforms.
4083         (sortedPlatforms): Deleted.
4084         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
4085         (sortDictionariesByOrder): Added. Takes an array of dictionaries that have an "order" property
4086         and sorts them by this property returning the new sorted array.
4087
4088 2015-08-07  Filip Pizlo  <fpizlo@apple.com>
4089
4090         Lightweight locks should be adaptive
4091         https://bugs.webkit.org/show_bug.cgi?id=147545
4092
4093         Reviewed by Geoffrey Garen.
4094
4095         * TestWebKitAPI/CMakeLists.txt:
4096         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
4097         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4098         * TestWebKitAPI/Tests/WTF/Lock.cpp: Added.
4099         (TestWebKitAPI::runLockTest):
4100         (TestWebKitAPI::TEST):
4101
4102 2015-08-07  Anders Carlsson  <andersca@apple.com>
4103
4104         Fix a tyop.
4105
4106         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
4107         (WTR::PlatformWebView::viewSupportsOptions):
4108
4109 2015-08-07  Alexey Proskuryakov  <ap@apple.com>
4110
4111         Update AppEngine app version numbers to the latest commit.
4112
4113         * QueueStatusServer/app.yaml:
4114         * TestResultServer/app.yaml:
4115
4116 2015-08-07  Anders Carlsson  <andersca@apple.com>
4117
4118         Simplify WKTR's view options
4119         https://bugs.webkit.org/show_bug.cgi?id=147791
4120
4121         Reviewed by Sam Weinig.
4122
4123         Instead of using a WKDictionaryRef, just use a struct for the options.
4124
4125         * WebKitTestRunner/PlatformWebView.h:
4126         (WTR::PlatformWebView::options):
4127         (WTR::PlatformWebView::viewSupportsOptions): Deleted.
4128         * WebKitTestRunner/TestController.cpp:
4129         (WTR::TestController::initialize):
4130         (WTR::TestController::createWebViewWithOptions):
4131         (WTR::TestController::ensureViewSupportsOptions):
4132         (WTR::TestController::updateLayoutTypeForTest):
4133         * WebKitTestRunner/TestController.h:
4134         * WebKitTestRunner/ViewOptions.h: Added.
4135         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
4136         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
4137         (WTR::PlatformWebView::PlatformWebView):
4138         (WTR::PlatformWebView::viewSupportsOptions):
4139         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
4140         (WTR::PlatformWebView::viewSupportsOptions):
4141         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
4142         (WTR::PlatformWebView::viewSupportsOptions):
4143         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
4144         (WTR::PlatformWebView::PlatformWebView):
4145         (WTR::PlatformWebView::viewSupportsOptions):
4146         * WebKitTestRunner/mac/TestControllerMac.mm:
4147         (WTR::TestController::platformConfigureViewForTest):
4148
4149 2015-08-07  Joseph Pecoraro  <pecoraro@apple.com>
4150
4151         Running tests for a long time results in some tests running very slowly (throttling)
4152         https://bugs.webkit.org/show_bug.cgi?id=147718
4153
4154         Reviewed by Chris Dumez.
4155
4156         Follow-up, make DumpRenderTree consistent with WebKitTestRunner.
4157         Although COCOA ports default this setting to be disabled in WebKit1,
4158         we should make both test harnesses disable the setting for consistency.
4159
4160         * DumpRenderTree/mac/DumpRenderTree.mm:
4161         (resetWebPreferencesToConsistentValues):
4162
4163 2015-08-07  Ryosuke Niwa  <rniwa@webkit.org>
4164
4165         Use a specific version of Speedometer in run-benchmark
4166         https://bugs.webkit.org/show_bug.cgi?id=147769
4167
4168         Reviewed by Chris Dumez.
4169
4170         Use the current latest revision as we work towards the bug 147768 (Update frameworks in Speedometer).
4171
4172         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan:
4173
4174 2015-08-07  Ryosuke Niwa  <rniwa@webkit.org>
4175
4176         twisted_http_server.py should support --port
4177         https://bugs.webkit.org/show_bug.cgi?id=147771
4178
4179         Reviewed by Chris Dumez.
4180
4181         Added the option. This makes the script more useful on its own.
4182
4183         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
4184
4185 2015-08-07  Carlos Garcia Campos  <cgarcia@igalia.com>
4186
4187         [GTK] WTF unit tests are timing out in the bots
4188         https://bugs.webkit.org/show_bug.cgi?id=147777
4189
4190         Reviewed by Filip Pizlo.
4191
4192         Add a way to mark google unit tests as slow and add
4193         WTF_Lock.ContentedShortSection to the list. In case of slow test
4194         we use the double of the given timeout for that particular test.
4195
4196         * Scripts/run-gtk-tests:
4197         (TestRunner):
4198         (TestRunner._run_google_test):
4199
4200 2015-08-07  Carlos Garcia Campos  <cgarcia@igalia.com>
4201
4202         [GTK] run-gtk-tests should not stop when a google test case fails
4203         https://bugs.webkit.org/show_bug.cgi?id=147778