AX: Need to implement ColorWellRole
[WebKit-https.git] / Tools / ChangeLog
1 2013-01-14  Dominic Mazzoni  <dmazzoni@google.com>
2
3         AX: Need to implement ColorWellRole
4         https://bugs.webkit.org/show_bug.cgi?id=106756
5
6         Reviewed by Chris Fleizach.
7
8         Returns a string representation of the value of a color
9         when the role is Color Well, to make it easy to write layout
10         tests for color controls.
11
12         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
13
14 2013-01-14  Dominic Mazzoni  <dmazzoni@google.com>
15
16         Chromium: Error in AccessibilityUIElement::intValueGetterCallback
17         https://bugs.webkit.org/show_bug.cgi?id=106682
18
19         Reviewed by Chris Fleizach.
20
21         Modify Chromium's DRT implementation of intValue to return a
22         different value depending on the role.
23
24         There are actually platform-specific differences in what should
25         be returned in the "value" of an object, so Chromium normally keeps
26         these separate (i.e. valueForRange, headingLevel, hierarchicalLevel, etc.)
27         but this is a fine simplification to make cross-platform tests easier.
28
29         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
30         (WebTestRunner::AccessibilityUIElement::intValueGetterCallback):
31
32 2013-01-14  Jochen Eisinger  <jochen@chromium.org>
33
34         [chromium] move remaining methods to dump WebViewClient callbacks to TestRunner library
35         https://bugs.webkit.org/show_bug.cgi?id=106785
36
37         Reviewed by Adam Barth.
38
39         * DumpRenderTree/chromium/DRTTestRunner.cpp:
40         (DRTTestRunner::DRTTestRunner):
41         (DRTTestRunner::reset):
42         * DumpRenderTree/chromium/DRTTestRunner.h:
43         (DRTTestRunner):
44         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
45         (WebTestProxyBase):
46         (WebTestRunner::WebTestProxy::setStatusText):
47         (WebTestRunner::WebTestProxy::didStopLoading):
48         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
49         (WebTestRunner::WebTestRunner::shouldDumpStatusCallbacks):
50         (WebTestRunner::WebTestRunner::shouldDumpProgressFinishedCallback):
51         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
52         (WebTestRunner::TestRunner::TestRunner):
53         (WebTestRunner::TestRunner::reset):
54         (WebTestRunner::TestRunner::shouldDumpStatusCallbacks):
55         (WebTestRunner):
56         (WebTestRunner::TestRunner::shouldDumpProgressFinishedCallback):
57         (WebTestRunner::TestRunner::dumpWindowStatusChanges):
58         (WebTestRunner::TestRunner::dumpProgressFinishedCallback):
59         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
60         (TestRunner):
61         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
62         (WebTestRunner::WebTestProxyBase::setStatusText):
63         (WebTestRunner):
64         (WebTestRunner::WebTestProxyBase::didStopLoading):
65         * DumpRenderTree/chromium/WebViewHost.cpp:
66         (WebViewHost::didStopLoading):
67         * DumpRenderTree/chromium/WebViewHost.h:
68         (WebViewHost):
69
70 2013-01-14  Andrey Lushnikov  <lushnikov@chromium.org>
71
72         Web Inspector: devtools front-end doesn't have focus in TestShell
73         https://bugs.webkit.org/show_bug.cgi?id=106778
74
75         Reviewed by Pavel Feldman.
76
77         Focus devTools window after loadURL method.
78
79         * DumpRenderTree/chromium/TestShell.cpp:
80         (TestShell::runFileTest):
81
82 2013-01-14  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
83
84         [EFL][jhbuild] Build the GStreamer-related dependencies with the "configure" script
85         https://bugs.webkit.org/show_bug.cgi?id=106573
86
87         Reviewed by Philippe Normand.
88
89         Similarly to what's been described in bug 106569, we're building
90         from release tarballs, so there's no reason to regenerate the
91         autoconf-related stuff with autogen.sh, especially since we might
92         run into trouble with automake 1.13 and deprecated macros.
93
94         * efl/jhbuild.modules:
95
96 2013-01-14  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
97
98         [Qt] The Qt's configuration isn't honoured regarding the use of the system libpng and libjpeg
99         https://bugs.webkit.org/show_bug.cgi?id=104909
100
101         Reviewed by Simon Hausmann.
102
103         To be able to build redistribuable binary packages, Qt's configure switches
104         -qt-libpng and -qt-libjpeg are used to avoid having the binaries trying to
105         dynamically link to optional system libraries.
106         QtWebKit is doing its own configure checks for those libraries, thus adding a
107         runtime dependency that might not be fulfilled if the packager's machine had
108         those libraries while the user's machine won't.
109
110         Since in most cases where WebKit will want to use those system libraries, Qt will
111         also be using them, remove these configure tests from WebKit.
112
113         * qmake/config.tests/libjpeg/libjpeg.cpp: Removed.
114         * qmake/config.tests/libjpeg/libjpeg.pro: Removed.
115         * qmake/config.tests/libpng/libpng.cpp: Removed.
116         * qmake/config.tests/libpng/libpng.pro: Removed.
117         * qmake/mkspecs/features/features.prf:
118
119 2013-01-09  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
120
121         [EFL][jhbuild] Bump the EFL dependencies in jhbuild to 1.7.5.
122         https://bugs.webkit.org/show_bug.cgi?id=106574
123
124         Reviewed by Laszlo Gombos.
125
126         Rely on a more recent stable release, which includes support for
127         Lua 5.2 in Edje and other assorted minor fixes.
128
129         While here, also use the "configure" script to build the libraries
130         instead of relying on autogen.sh, which is not really needed with
131         a release tarball and may have problems with automake 1.13.
132
133         * efl/jhbuild.modules:
134
135 2013-01-14  Andrey Lushnikov  <lushnikov@chromium.org>
136
137         Web Inspector: fix DRT to deliver simulated events to devtools front-end
138         https://bugs.webkit.org/show_bug.cgi?id=106650
139
140         Reviewed by Pavel Feldman.
141
142         Add separated m_devToolsTestInterfaces object to testShell which is
143         bind to devTools webview.
144
145         * DumpRenderTree/chromium/TestShell.cpp:
146         (TestShell::initialize):
147         (TestShell::createMainWindow):
148         (TestShell::~TestShell):
149         (TestShell::showDevTools):
150         (TestShell::resetTestController):
151         (TestShell::bindJSObjectsToWindow):
152         (TestShell::createNewWindow):
153         * DumpRenderTree/chromium/TestShell.h:
154         (TestShell):
155
156 2013-01-14  Alan Cutter  <alancutter@chromium.org>
157
158         Sheriffbot command aliases need test cases
159         https://bugs.webkit.org/show_bug.cgi?id=106754
160
161         Reviewed by Eric Seidel.
162
163         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
164         (SheriffBotTest.test_command_aliases):
165
166 2013-01-13  Alan Cutter  <alancutter@chromium.org>
167
168         Allow users to misspell the "sheriffs" command in sheriffbot
169         https://bugs.webkit.org/show_bug.cgi?id=106628
170
171         Reviewed by Steve Block.
172
173         * Scripts/webkitpy/tool/bot/irc_command.py:
174
175 2013-01-13  Alan Cutter  <alancutter@chromium.org>
176
177         Make "gardeners" an alias for "sheriffs" in sherrifbot
178         https://bugs.webkit.org/show_bug.cgi?id=106627
179
180         Reviewed by Eric Seidel.
181
182         * Scripts/webkitpy/tool/bot/irc_command.py:
183
184 2013-01-13  Dirk Pranke  <dpranke@chromium.org>
185
186         [chromium] webkitpy-test: executive.py stringify_args error on the release test bot
187         https://bugs.webkit.org/show_bug.cgi?id=105380
188
189         Reviewed by Eric Seidel.
190
191         Fix a regression introduced in r137692 where we were double-encoding
192         the arguments to popen(); this was only an issue on windows, where
193         we would try to encode something to mbcs, then try to encode it
194         to unicode as if the input as ascii.
195
196         * Scripts/webkitpy/common/system/executive.py:
197         (Executive.run_command):
198
199 2013-01-13  Alan Cutter  <alancutter@chromium.org>
200
201         State who told sheriffbot to roll the Chromium deps and to what revision
202         https://bugs.webkit.org/show_bug.cgi?id=106626
203
204         Reviewed by Eric Seidel.
205
206         Added optional argument to post-chromium-deps-roll so Sheriffbot can specify ChangeLog message.
207
208         * Scripts/webkitpy/tool/bot/irc_command.py:
209         (RollChromiumDEPS._expand_irc_nickname):
210         (RollChromiumDEPS.execute):
211         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
212         (IRCCommandTest.test_roll_chromium_deps):
213         * Scripts/webkitpy/tool/bot/sheriff.py:
214         (Sheriff.post_chromium_deps_roll):
215         * Scripts/webkitpy/tool/commands/roll.py:
216         (RollChromiumDEPS._prepare_state):
217         (PostChromiumDEPSRoll):
218         (PostChromiumDEPSRoll._prepare_state):
219         * Scripts/webkitpy/tool/commands/roll_unittest.py:
220         (PostRollCommandsTest.test_prepare_state):
221         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
222         (PrepareChangeLogForDEPSRoll.run):
223
224 2013-01-13  Alan Cutter  <alancutter@chromium.org>
225
226         Add Alan Cutter as contributor
227         https://bugs.webkit.org/show_bug.cgi?id=106747
228
229         Reviewed by Eric Seidel.
230
231         * Scripts/webkitpy/common/config/committers.py:
232
233 2013-01-13  Jonathan Liu  <net147@gmail.com>
234
235         Fix CONFIG missing link_pkgconfig on Windows
236         https://bugs.webkit.org/show_bug.cgi?id=106647
237
238         Some libraries (e.g. libxslt, libxml2 and sqlite3) fail to link
239         properly on Windows because they are added to PKGCONFIG but
240         CONFIG does not contain link_pkgconfig.
241
242         This is because link_pkgconfig is added in unix/default_pre.prf
243         which is only used for UNIX platforms. To fix this, move it to
244         the general default_pre.prf.
245
246         Reviewed by Simon Hausmann.
247
248         * qmake/mkspecs/features/default_pre.prf:
249         * qmake/mkspecs/features/unix/default_pre.prf:
250
251 2013-01-12  Nico Weber  <thakis@chromium.org>
252
253         nrwt/chromium: Don't prefer chromium over webkit build directories
254         https://bugs.webkit.org/show_bug.cgi?id=105597
255
256         Reviewed by Dirk Pranke.
257
258         Rely on the new timestamp logic instead. Requested by dpranke in
259         https://bugs.webkit.org/show_bug.cgi?id=105498
260
261         * Scripts/webkitpy/layout_tests/port/chromium.py:
262         (ChromiumPort._static_build_path):
263         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
264         (ChromiumLinuxPortTest.test_build_path):
265         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
266         (ChromiumMacPortTest.test_build_path):
267         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
268         (ChromiumWinTest.test_build_path):
269
270 2013-01-12  Nico Weber  <thakis@chromium.org>
271
272         Use ninja by default on Linux for build-webkit --chromium, bot edition
273         https://bugs.webkit.org/show_bug.cgi?id=104434
274
275         Reviewed by Eric Seidel.
276
277         r139557 changed update-webkit to pick ninja by default on linux, but
278         the bots run update-webkit-chromium directly so they didn't see this.
279         Move the default for ninja into update-webkit-chromium so that it's
280         picked up by the bots, and let update-webkit forward non-default
281         options to there.
282
283         This way, the default is in one place only and both developers (who
284         usually use update-webkit which then shells out to
285         updat-webkit-chromium) and bots (which use update-webkit-chromium
286         directly) see the same behavior.
287
288         * Scripts/update-webkit:
289         * Scripts/update-webkit-chromium:
290
291 2013-01-12  Nico Weber  <thakis@chromium.org>
292
293         Make ninja the default build system on Linux for build-webkit --chromium
294         https://bugs.webkit.org/show_bug.cgi?id=104434
295
296         Reviewed by Eric Seidel.
297
298         * Scripts/update-webkit:
299
300 2013-01-12  Alan Cutter  <alancutter@chromium.org>
301
302         Migrate the remaining bots in EC2 to Google Compute Engine
303         https://bugs.webkit.org/show_bug.cgi?id=106005
304
305         Reviewed by Eric Seidel.
306
307         Updated bot scripts for launching feeder-queue, style-queue and sheriffbot on GCE.
308
309         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh: Copied from Tools/EWSTools/build-repo.sh.
310         * EWSTools/boot.sh:
311         * EWSTools/build-repo.sh:
312         * EWSTools/start-queue.sh:
313
314 2013-01-12  Jochen Eisinger  <jochen@chromium.org>
315
316         [chromium] move inspector related methods to TestRunner library
317         https://bugs.webkit.org/show_bug.cgi?id=106654
318
319         Reviewed by Adam Barth.
320
321         * DumpRenderTree/chromium/DRTTestRunner.cpp:
322         (DRTTestRunner::DRTTestRunner):
323         * DumpRenderTree/chromium/DRTTestRunner.h:
324         (DRTTestRunner):
325         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
326         (WebTestRunner::WebTestDelegate::showDevTools):
327         (WebTestRunner::WebTestDelegate::closeDevTools):
328         (WebTestRunner::WebTestDelegate::evaluateInWebInspector):
329         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
330         (WebTestRunner::TestRunner::TestRunner):
331         (WebTestRunner::TestRunner::showWebInspector):
332         (WebTestRunner):
333         (WebTestRunner::TestRunner::closeWebInspector):
334         (WebTestRunner::TestRunner::evaluateInWebInspector):
335         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
336         (TestRunner):
337         * DumpRenderTree/chromium/WebViewHost.cpp:
338         (WebViewHost::showDevTools):
339         (WebViewHost::closeDevTools):
340         (WebViewHost::evaluateInWebInspector):
341         * DumpRenderTree/chromium/WebViewHost.h:
342         (WebViewHost):
343
344 2013-01-11  Julie Parent  <jparent@chromium.org>
345
346         Builder should not be a valid parameter for stats dashboard
347         https://bugs.webkit.org/show_bug.cgi?id=106698
348
349         Reviewed by Dirk Pranke.
350         
351         Since builder is a dashboard specific parameter, dashboard_base
352         should not be handling it in handleValidHashParameterWrapper, rather,
353         each specific dashboard should in its handleValidHashParameter function.
354     
355         Note that the FIXME in dashboard_base about this was actually wrong -
356         we don't want to move it to g_crossDashboardState, because it isn't
357         actually cross dashboard state.
358         
359         In fact, flakiness and treemap have the code in 
360         handleValidHashParameter, but it is currently dead code because 
361         dashboard_base gets to it first.
362         
363         Added the proper handling to timeline_explorer, since builder is
364         valid there.
365
366         * TestResultServer/static-dashboards/dashboard_base.js:
367         * TestResultServer/static-dashboards/timeline_explorer.html:
368
369 2013-01-11  Ryosuke Niwa  <rniwa@webkit.org>
370
371         REGRESSION: buildbot mangles error messages with timestamps run-webkit-tests outputs
372         https://bugs.webkit.org/show_bug.cgi?id=106688
373
374         Reviewed by Eric Seidel.
375
376         Update the regular expression used to strip the garbage at the beginning.
377
378         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
379         (RunWebKitTests.nrwt_log_message_regexp):
380
381 2013-01-11  Pratik Solanki  <psolanki@apple.com>
382
383         TestRunner leaks when running tests
384         https://bugs.webkit.org/show_bug.cgi?id=106683
385
386         Reviewed by Simon Fraser.
387
388         Remove extra ref() that we missed out on deleting when refactoring window.layoutTestController
389         to window.testRunner in r124705. This caused the TestRunner object to be leaked when running
390         tests.
391
392         * DumpRenderTree/TestRunner.cpp:
393         (TestRunner::makeWindowObject):
394
395 2013-01-11  Julie Parent  <jparent@chromium.org>
396
397         Dashboard Cleanup: Add isLoadingComplete to the loader.Loader object.
398         https://bugs.webkit.org/show_bug.cgi?id=106247
399
400         Old code nulled out the loader instance when it completed loading and
401         then later used the fact that it was null to determine if it had loaded
402         or not.  This is not only unintuitive, but it also prevents using the
403         loader object later on.
404         
405         Added new method, used it, added unit test for it.
406         
407         Reviewed by Dirk Pranke.
408
409         * TestResultServer/static-dashboards/dashboard_base.js:
410         (resourceLoadingComplete):
411         (handleLocationChange):
412         * TestResultServer/static-dashboards/loader.js:
413         (.):
414         * TestResultServer/static-dashboards/loader_unittests.js:
415
416 2013-01-11  Ryosuke Niwa  <rniwa@webkit.org>
417
418         Try CRLF to LF change in r139407 again.
419
420         * BuildSlaveSupport/delete-stale-build-files:
421         (main):
422         (webkitBuildDirectory):
423         * BuildSlaveSupport/kill-old-processes:
424         (main):
425
426 2013-01-11  Carlos Garcia Campos  <cgarcia@igalia.com>
427
428         [GTK] Disable the unit tests timeout when running from make check
429         https://bugs.webkit.org/show_bug.cgi?id=106670
430
431         Reviewed by Philippe Normand.
432
433         * GNUmakefile.am: Pass --timeout=-1 to run-gtk-test.
434
435 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
436
437         Yet another unreviewed fix after r139431.
438
439         * Scripts/run-launcher: Pass the arguments to `jhbuild-wrapper' in
440         the correct order.
441
442 2013-01-11  Dan Carney  <dcarney@google.com>
443
444         [chromium] move some whitespace and resize related methods to TestRunner library
445         https://bugs.webkit.org/show_bug.cgi?id=106655
446
447         Reviewed by Jochen Eisinger.
448
449         * DumpRenderTree/chromium/DRTTestRunner.cpp:
450         (DRTTestRunner::DRTTestRunner):
451         * DumpRenderTree/chromium/DRTTestRunner.h:
452         (DRTTestRunner):
453         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
454         (WebKit):
455         (WebTestRunner::WebTestDelegate::setClientWindowRect):
456         (WebTestRunner::WebTestDelegate::setSelectTrailingWhitespaceEnabled):
457         (WebTestRunner::WebTestDelegate::setSmartInsertDeleteEnabled):
458         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
459         (WebTestRunner::TestRunner::TestRunner):
460         (WebTestRunner::TestRunner::setSmartInsertDeleteEnabled):
461         (WebTestRunner):
462         (WebTestRunner::TestRunner::setSelectTrailingWhitespaceEnabled):
463         (WebTestRunner::TestRunner::enableAutoResizeMode):
464         (WebTestRunner::TestRunner::disableAutoResizeMode):
465         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
466         (TestRunner):
467         * DumpRenderTree/chromium/WebViewHost.cpp:
468         (WebViewHost::setClientWindowRect):
469         * DumpRenderTree/chromium/WebViewHost.h:
470         (WebViewHost):
471
472 2013-01-11  Mario Sanchez Prada  <mario.prada@samsung.com>
473
474         Unreviewed. Update my e-mail addresses.
475
476         * Scripts/webkitpy/common/config/committers.py:
477
478 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
479
480         Another unreviewed fix after r139431.
481
482         In a way, this is also a generic bug fix, since previously isEfl()
483         would fail when called from run-efl-tests and we thus did not use
484         jhbuild to run our tests. This now resulted in us calling
485         "jhbuild-wrapper run" without specifying a platform.
486
487         * Scripts/run-efl-tests: Pass "--efl" to ARGV manually for isEfl()
488         to work.
489
490 2013-01-11  Allan Sandfeld Jensen  <allan.jensen@digia.com>
491
492         [Qt][WK1] Web Audio support
493         https://bugs.webkit.org/show_bug.cgi?id=106651
494
495         Reviewed by Jocelyn Turcotte.
496
497         Implements support for dumping audio data in DumpRenderTree.
498
499         Adds WebAudio to toggleable features in QtTestBrowser.
500
501         Enables LEGACY_WEB_AUDIO. This feature is required for 2/3 of the web audio regression tests. It is enabled by default
502         because it has no effect when WEB_AUDIO is not enabled. This combination matches the settings in FeatureList.pm.
503
504         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
505         (WebCore::DumpRenderTree::dump):
506         * DumpRenderTree/qt/TestRunnerQt.cpp:
507         (TestRunner::reset):
508         (TestRunner::overridePreference):
509         (TestRunner::setAudioData):
510         * DumpRenderTree/qt/TestRunnerQt.h:
511         (TestRunner::shouldDumpAsAudio):
512         (TestRunner::audioData):
513         (TestRunner):
514         * QtTestBrowser/launcherwindow.cpp:
515         (LauncherWindow::applyPrefs):
516         (LauncherWindow::createChrome):
517         (LauncherWindow::toggleWebAudio):
518         * QtTestBrowser/launcherwindow.h:
519         (WindowOptions::WindowOptions):
520         (WindowOptions):
521         (LauncherWindow):
522         * qmake/mkspecs/features/features.prf:
523         * qmake/mkspecs/features/features.pri:
524
525 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
526
527         Unreviewed jhbuild-related fix after r139431.
528
529         * Scripts/webkitpy/layout_tests/port/efl.py:
530         (EflPort.__init__): Pass a string to set_option_default(), since
531         shlex.split() will be called on it later.
532
533 2013-01-11  Csaba Osztrogonác  <ossy@webkit.org>
534
535         Unreviewed typo fixes after r139431.
536
537         * Scripts/run-javascriptcore-tests:
538
539 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
540
541         [jhbuild] Remove the "run-with-jhbuild" scripts.
542         https://bugs.webkit.org/show_bug.cgi?id=106572
543
544         Reviewed by Martin Robinson.
545
546         Both ports which use jhbuild were mostly duplicating the
547         `run-with-jhbuild' script in their own directories for no clear reason.
548
549         The script itself was just a thin wrapper around the `jhbuild-wrapper',
550         so just start using that directly and get rid of a useless middle man.
551
552         Adjust scripts which called run-with-jhbuild to call jhbuild-wrapper
553         instead.
554
555         * Scripts/run-javascriptcore-tests:
556         * Scripts/run-launcher:
557         * Scripts/webkitdirs.pm:
558         (runAutogenForAutotoolsProjectIfNecessary):
559         (buildAutotoolsProject):
560         (jhbuildWrapperPrefixIfNeeded):
561         (generateBuildSystemFromCMakeProject):
562         (buildCMakeGeneratedProject):
563         * Scripts/webkitpy/common/multiprocessing_bootstrap.py:
564         (run):
565         * Scripts/webkitpy/layout_tests/port/efl.py:
566         (EflPort.__init__):
567         (EflPort._image_diff_command):
568         * efl/run-with-jhbuild: Removed.
569         * gtk/run-with-jhbuild: Removed.
570
571 2013-01-11  Alan Cutter  <alancutter@chromium.org>
572
573         Allow arbitrary queue launch parameters in EWSTools/start-queue.sh
574         https://bugs.webkit.org/show_bug.cgi?id=106636
575
576         Reviewed by Adam Barth.
577
578         This parameter will allow the bot boot script to use start-queue.sh and provide an IRC password for sheriffbot.
579
580         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
581         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
582         * EWSTools/screen-config:
583         * EWSTools/start-queue.sh:
584
585 2013-01-10  Ryosuke Niwa  <rniwa@webkit.org>
586
587         kill-old-processes and delete-stale-build-files use CRLF linebreaks
588         https://bugs.webkit.org/show_bug.cgi?id=106622
589
590         Reviewed by Simon Fraser.
591
592         Use LF instead of CRLF in kill-old-processes and delete-stale-build-files.
593         Also escape clang\+\+ correctly in kill-old-processes.
594
595         * BuildSlaveSupport/delete-stale-build-files:
596         * BuildSlaveSupport/kill-old-processes:
597
598 2013-01-10  Ryosuke Niwa  <rniwa@webkit.org>
599
600         Build fix after r139357. It was missing a comma.
601
602         * QueueStatusServer/model/queues.py:
603         (Queue):
604
605 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
606
607         Fixing AuthenticationError when running test-webkitpy as a non-committer.
608         https://bugs.webkit.org/show_bug.cgi?id=106420
609
610         Reviewed by Eric Seidel.
611
612         * Scripts/webkitpy/common/checkout/scm/git.py:
613         (Git.push_local_commits_to_server):
614         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
615         * Scripts/webkitpy/common/checkout/scm/svn.py:
616         (SVNRepository):
617         (SVNRepository.has_authorization_for_realm):
618
619 2013-01-10  Christophe Dumez  <christophe.dumez@intel.com>
620
621         [EFL][jhbuild] Use tarballs for gstreamer instead of git
622         https://bugs.webkit.org/show_bug.cgi?id=106552
623
624         Reviewed by Laszlo Gombos.
625
626         Use tarballs for gstreamer instead of git in EFL's jhbuild
627         to work around intermittent network issues on our build
628         bots. Tarballs are fully cached and require no network
629         operation if their checksum matches.
630
631         * efl/jhbuild.modules:
632
633 2013-01-10  Ryosuke Niwa  <rniwa@webkit.org>
634
635         Add Mac WK2 EWS bots
636         https://bugs.webkit.org/show_bug.cgi?id=106590
637
638         Reviewed by Adam Barth.
639
640         Added MacWK2EWS, and made myself a watcher for MacEWS and MacWK2EWS.
641         Also add a deprecated MacWK2Port class.
642
643         * QueueStatusServer/model/queues.py:
644         (Queue):
645         * Scripts/webkitpy/common/config/ports.py:
646         (DeprecatedPort.port):
647         (MacWK2Port):
648         (MacWK2Port.run_webkit_tests_command):
649         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
650         (MacEWS):
651         (MacWK2EWS):
652         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
653         (_test_ewses):
654
655 2013-01-10  Dan Carney  <dcarney@google.com>
656
657         [chromium] move webpermissionclient related methods to TestRunner library
658         https://bugs.webkit.org/show_bug.cgi?id=106548
659
660         Reviewed by Jochen Eisinger.
661
662         * DumpRenderTree/DumpRenderTree.gypi:
663         * DumpRenderTree/chromium/DRTTestRunner.cpp:
664         (DRTTestRunner::DRTTestRunner):
665         (DRTTestRunner::reset):
666         * DumpRenderTree/chromium/DRTTestRunner.h:
667         (DRTTestRunner):
668         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
669         (WebTestRunner::WebTestDelegate::normalizeLayoutTestURL):
670         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
671         (WebKit):
672         (WebTestRunner::WebTestRunner::webPermissions):
673         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
674         (WebTestRunner::TestRunner::TestRunner):
675         (WebTestRunner::TestRunner::setDelegate):
676         (WebTestRunner):
677         (WebTestRunner::TestRunner::reset):
678         (WebTestRunner::TestRunner::webPermissions):
679         (WebTestRunner::TestRunner::dumpPermissionClientCallbacks):
680         (WebTestRunner::TestRunner::setImagesAllowed):
681         (WebTestRunner::TestRunner::setScriptsAllowed):
682         (WebTestRunner::TestRunner::setStorageAllowed):
683         (WebTestRunner::TestRunner::setPluginsAllowed):
684         (WebTestRunner::TestRunner::setAllowDisplayOfInsecureContent):
685         (WebTestRunner::TestRunner::setAllowRunningOfInsecureContent):
686         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
687         (WebTestRunner):
688         (TestRunner):
689         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp: Renamed from Tools/DumpRenderTree/chromium/WebPermissions.cpp.
690         (WebTestRunner):
691         (WebTestRunner::WebPermissions::WebPermissions):
692         (WebTestRunner::WebPermissions::~WebPermissions):
693         (WebTestRunner::WebPermissions::allowImage):
694         (WebTestRunner::WebPermissions::allowScriptFromSource):
695         (WebTestRunner::WebPermissions::allowStorage):
696         (WebTestRunner::WebPermissions::allowPlugins):
697         (WebTestRunner::WebPermissions::allowDisplayingInsecureContent):
698         (WebTestRunner::WebPermissions::allowRunningInsecureContent):
699         (WebTestRunner::WebPermissions::setImagesAllowed):
700         (WebTestRunner::WebPermissions::setScriptsAllowed):
701         (WebTestRunner::WebPermissions::setStorageAllowed):
702         (WebTestRunner::WebPermissions::setPluginsAllowed):
703         (WebTestRunner::WebPermissions::setDisplayingInsecureContentAllowed):
704         (WebTestRunner::WebPermissions::setRunningInsecureContentAllowed):
705         (WebTestRunner::WebPermissions::setDelegate):
706         (WebTestRunner::WebPermissions::setDumpCallbacks):
707         (WebTestRunner::WebPermissions::reset):
708         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.h: Renamed from Tools/DumpRenderTree/chromium/WebPermissions.h.
709         (WebTestRunner):
710         (WebPermissions):
711         * DumpRenderTree/chromium/TestShell.cpp:
712         (TestShell::initialize):
713         (TestShell::resetTestController):
714         (TestShell::createNewWindow):
715         * DumpRenderTree/chromium/TestShell.h:
716         (TestShell):
717         * DumpRenderTree/chromium/WebViewHost.cpp:
718         (WebViewHost::normalizeLayoutTestURL):
719         * DumpRenderTree/chromium/WebViewHost.h:
720         (WebViewHost):
721
722 2013-01-10  Alan Cutter  <alancutter@chromium.org>
723
724         Split EWS tool cold-boot.sh into modular components
725         https://bugs.webkit.org/show_bug.cgi?id=106527
726
727         Reviewed by Adam Barth.
728
729         Split cold-boot.sh script up into build-vm.sh, build-repo.sh and build-boot-cmd.sh.
730         Updated GCE bot build scripts to match.
731         Unable to test scripts directly as they depend on being in the repository to work!
732
733         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
734         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
735         * EWSTools/build-boot-cmd.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-chromium-ews.sh.
736         * EWSTools/build-repo.sh: Copied from Tools/EWSTools/cold-boot.sh.
737         * EWSTools/build-vm.sh: Renamed from Tools/EWSTools/cold-boot.sh.
738
739 2013-01-10  Julie Parent  <jparent@chromium.org>
740
741         Dashboard Cleanup: Do not generate the page if we are about to reload.
742         https://bugs.webkit.org/show_bug.cgi?id=106584
743
744         Reviewed by Dirk Pranke.
745
746         Move the logic to determine if we should generate the page into
747         parseParameters() since that is where we have the knowledge to
748         determine it, and return that value to handleLocationChange, 
749         rather than passing the changed parameters back to handleLocationChange
750         and having it make the decision.
751         
752         This is logically equivalent, save one case: when we are about to do
753         a reload, we know that there is no reason to generate the page.  Old
754         code was causing an extra page generation in this case.
755         
756         * TestResultServer/static-dashboards/dashboard_base.js:
757         (parseParameters):
758         (handleLocationChange):
759
760 2013-01-10  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
761
762         [jhbuild] Use the "configure" script to build glib
763         https://bugs.webkit.org/show_bug.cgi?id=106569
764
765         Reviewed by Martin Robinson.
766
767         So far both EFL and GTK have been using autogen.sh to build glib.
768         While that does work most of the time, it's not really needed since
769         we are downloading and building stable releases from tarballs.
770         Additionally, autogen.sh fails to work with automake 1.13 due to the
771         usage of some macros that have been removed (this has already been
772         fixed in glib master).
773
774         * efl/jhbuild.modules:
775         * gtk/jhbuild.modules:
776
777 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
778
779         Changing tests to be consistent and use self.scm rather then recreating the scm object.
780         (Missed a couple)
781         https://bugs.webkit.org/show_bug.cgi?id=106536
782
783         Reviewed by Eric Seidel.
784
785         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
786
787 2013-01-10  Tony Chang  <tony@chromium.org>
788
789         Speed up supplemental dependency computation
790         https://bugs.webkit.org/show_bug.cgi?id=106503
791
792         Reviewed by Adam Barth.
793
794         Pass the IDL attributes file for generating the bindings in WebKitTestRunner.
795
796         * WebKitTestRunner/CMakeLists.txt:
797
798 2013-01-10  Zan Dobersek  <zandobersek@gmail.com>
799
800         Remove the ENABLE_ANIMATION_API feature define occurences
801         https://bugs.webkit.org/show_bug.cgi?id=106544
802
803         Reviewed by Simon Fraser.
804
805         The Animation API code was removed in r137243. The ENABLE_ANIMATION_API
806         feature define handling still lingers in various build systems and configurations
807         but is of no use, so it should be removed.
808
809         * Scripts/webkitperl/FeatureList.pm:
810         * qmake/mkspecs/features/features.pri:
811
812 2013-01-10  Carlos Garcia Campos  <cgarcia@igalia.com>
813
814         [GTK] Add support for loading web process extensions
815         https://bugs.webkit.org/show_bug.cgi?id=105631
816
817         Reviewed by Gustavo Noronha Silva.
818
819         * MiniBrowser/gtk/GNUmakefile.am:
820         * MiniBrowser/gtk/main.c:
821         (main): Set WEBKIT_INJECTED_BUNDLE env var to use the injected
822         bundle lib from build dir.
823         * Scripts/webkitpy/style/checker.py: Add exceptions for GTK+ API
824         located in WebProcess/InjectedBundle/API/gtk.
825         * gtk/generate-gtkdoc:
826         (get_webkit2_options): Scan also files in
827         WebProcess/InjectedBundle/API/gtk to generate API docs.
828         (get_webkit2_options.injected_bundle_src_path): Helper function to
829         build paths in WebProcess/InjectedBundle/API/gtk.
830
831 2013-01-10  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
832
833         [EFL][WK2] Writing immediately to created windows (open) fails
834         https://bugs.webkit.org/show_bug.cgi?id=105276
835
836         Reviewed by Kenneth Rohde Christiansen.
837
838         Do not reset 'about:blank' url for the new pages in mini browser.
839
840         * MiniBrowser/efl/main.c:
841         (window_create):
842
843 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
844
845         Changing tests to be consistent and use self.scm rather then recreating the scm object.
846         https://bugs.webkit.org/show_bug.cgi?id=106536
847
848         Reviewed by Eric Seidel.
849
850         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
851
852 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
853
854         Converting to unittest2 so we can use assertItemsEqual, making tests
855         not dependent on order of items.
856         https://bugs.webkit.org/show_bug.cgi?id=106532
857
858         Before:
859         Ran 1733 tests in 38.385s
860         FAILED (failures=1, errors=22)
861
862         After:
863         Ran 1733 tests in 32.298s
864         FAILED (failures=0, errors=22)
865
866         Reviewed by Eric Seidel.
867
868         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
869         * Scripts/webkitpy/thirdparty/__init__.py:
870         (AutoinstallImportHook._install_unittest2):
871
872 2013-01-10  Christophe Dumez  <christophe.dumez@intel.com>
873
874         [EFL] Add gstreamer 1.0.5 to jhbuild
875         https://bugs.webkit.org/show_bug.cgi?id=106178
876
877         Reviewed by Laszlo Gombos.
878
879         Add gstreamer 1.0.5 to EFL's jhbuild configuration.
880
881         * efl/jhbuild.modules:
882
883 2013-01-09  Alan Cutter  <alancutter@chromium.org>
884
885         Updated parameters in GCE build scripts so they now work.
886         https://bugs.webkit.org/show_bug.cgi?id=106523
887
888         Reviewed by Adam Barth.
889
890         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
891         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
892         * EWSTools/cold-boot.sh:
893
894 2013-01-09  Mark Pilgrim  <pilgrim@chromium.org>
895
896         [Chromium] Remove some stray references to WebKitPlatformSupport.h in DumpRenderTree
897         https://bugs.webkit.org/show_bug.cgi?id=106520
898
899         Reviewed by James Robinson.
900
901         Part of a larger refactoring series. See tracking bug 82948.
902
903         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
904         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
905
906 2013-01-09  Julie Parent  <jparent@chromium.org>
907
908         Dashboard cleanup: Remove code for currentState and window.location.hash getting out of state
909         https://bugs.webkit.org/show_bug.cgi?id=106514
910
911         This is old code, as these can no longer get out of sync.
912         permmaLinkURLHash is generated from currentState, which is set only
913         from the location.  The commment about how these can get out of sync
914         refers to a function that no longer exists.
915         
916         Reviewed by Dirk Pranke.
917
918         * TestResultServer/static-dashboards/dashboard_base.js:
919         (handleLocationChange):
920
921 2013-01-09  Julie Parent  <jparent@chromium.org>
922
923         Dashboard Cleanup: Reload the page as soon as we know we need to.
924         https://bugs.webkit.org/show_bug.cgi?id=106515
925
926         No need to continue parsing all of the data once we know that
927         we need to do a reload.
928         
929         Reviewed by Dirk Pranke.
930
931         * TestResultServer/static-dashboards/dashboard_base.js:
932         (parseParameters):
933
934 2013-01-09  Eric Seidel  <eric@webkit.org>
935
936         run-perf-tests --chromium-android --profile should show symbols for the kernel
937         https://bugs.webkit.org/show_bug.cgi?id=106498
938
939         Reviewed by Adam Barth.
940
941         Turns out this was easy, once I finally read the output from "perf report".
942         It appears there may be a bug in "perf record" on android, as it complains
943         about not being able to read from /proc/kallsyms even when
944         /proc/sys/kernel/kptr_restrict is 0.  For now I've not bothered
945         to keep /proc/sys/kernel/kptr_restrict as 0 during the actual record
946         but rather just flip it to 0 long enough to grab the /proc/kallsyms
947         and then flip it back to whatever the device had.
948
949         /proc/sys/kernel/kptr_restrict controls what /proc/kallsyms returns
950         on Linux.  /proc/kallsyms contains a mapping of kernel addresses
951         to symbol names.  Its world-readable, but will return all 0s if you
952         don't have permission to see the kernel symbols.  kptr_restrict
953         supports values 0, 1, 2.  Where 0 means "everyone can see the real symbols"
954         1 is only a specific group, and 2 is "no one, not even root".
955         By default kptr_restrict is 2 on Android it seems.
956         More kptr_restrict docs: http://lwn.net/Articles/420403/
957
958         I also took this opportunity to clean up how the perf record command
959         was built for use/display in AndroidPerf.profile_after_exit and
960         change to always using long-form names for the arguments (to hopefully help readability).
961
962         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
963         (AndroidPerf.__init__):
964         (profile_after_exit):
965         (ChromiumAndroidDriver.__init__):
966         (ChromiumAndroidDriver._update_kallsyms_cache):
967         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
968
969 2013-01-09  Julie Parent  <jparent@chromium.org>
970
971         Dashboard cleanup: remove dead code.
972         https://bugs.webkit.org/show_bug.cgi?id=106509
973
974         Reviewed by Dirk Pranke.
975
976         * TestResultServer/static-dashboards/dashboard_base.js:
977         (parseParameters):
978
979 2013-01-09  Joanmarie Diggs  <jdiggs@igalia.com>
980
981         [GTK] accessibility/aria-labelledby-overrides-label.html requires a proper baseline
982         https://bugs.webkit.org/show_bug.cgi?id=105638
983
984         Reviewed by Martin Robinson.
985
986         The test was failing for two reasons:
987         - AccessibilityRenderObject::correspondingLabelForControlElement() was
988           not ignoring the ARIA labelled-by property
989         - AccessibilityController::accessibleElementById() was not implemented
990
991         Because getting an element by ID cannot be done in the UIProcess, the
992         decision was made to expose the element's ID as an accessible attribute
993         of the object.
994
995         In addition, fixing the bug in AccessibilityRenderObject made it possible
996         to eliminate the Gtk platform-specific expectations for another test.
997
998         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
999         (childElementById): Added. Walks the tree looking for the AtkObject
1000         Attribute which exposes the HTML element's ID.
1001         (AccessibilityController::accessibleElementById): Implemented.
1002         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1003         (AccessibilityUIElement::title): Modified to print out "AXTitle: " even
1004         when there is no title, as is done with the Mac port.
1005         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1006         (WTR):
1007         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
1008         (WTR::childElementById): Added. Walks the tree looking for the AtkObject
1009         Attribute which exposes the HTML element's ID.
1010         (WTR):
1011         (WTR::AccessibilityController::accessibleElementById): Implemented.
1012         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1013         (WTR::AccessibilityUIElement::title): Modified to print out "AXTitle: "
1014         even when there is no title, as is done with the Mac port.
1015
1016 2013-01-09  Gregg Tavares  <gman@google.com>
1017
1018         Add Gregg Tavares as a committer
1019         https://bugs.webkit.org/show_bug.cgi?id=106492
1020
1021         Unreviewed.
1022
1023         * Scripts/webkitpy/common/config/committers.py:
1024
1025 2013-01-09  Roger Fong  <roger_fong@apple.com>
1026
1027         Enable seamless iFrames for Windows DRT.
1028         https://bugs.webkit.org/show_bug.cgi?id=106468.
1029
1030         Rubberstamped by Timothy Horton.
1031
1032         * DumpRenderTree/win/DumpRenderTree.cpp:
1033         (resetDefaultsToConsistentValues):
1034
1035 2013-01-09  Christophe Dumez  <christophe.dumez@intel.com>
1036
1037         [WK2] Implement eventSender.scheduleAsynchronousKeyDown
1038         https://bugs.webkit.org/show_bug.cgi?id=93979
1039
1040         Reviewed by Benjamin Poulain.
1041
1042         Implement eventSender.scheduleAsynchronousKeyDown() in
1043         WebKitTestRunner.
1044
1045         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
1046         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1047         (WTR::createKeyDownMessageBody):
1048         (WTR::EventSendingController::keyDown):
1049         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
1050         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1051         (EventSendingController):
1052         * WebKitTestRunner/TestController.cpp:
1053         (WTR::TestController::didReceiveKeyDownMessageFromInjectedBundle):
1054         (WTR::TestController::didReceiveMessageFromInjectedBundle):
1055         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
1056         * WebKitTestRunner/TestController.h:
1057         (TestController):
1058
1059 2013-01-09  Jochen Eisinger  <jochen@chromium.org>
1060
1061         [chromium] move resource load callback dumping to TestRunner library
1062         https://bugs.webkit.org/show_bug.cgi?id=106449
1063
1064         Reviewed by Adam Barth.
1065
1066         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1067         (DRTTestRunner::DRTTestRunner):
1068         (DRTTestRunner::reset):
1069         * DumpRenderTree/chromium/DRTTestRunner.h:
1070         (DRTTestRunner):
1071         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1072         (WebKit):
1073         (WebTestRunner::WebTestDelegate::makeURLErrorDescription):
1074         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
1075         (WebKit):
1076         (WebTestProxyBase):
1077         (WebTestRunner::WebTestProxy::assignIdentifierToRequest):
1078         (WebTestRunner::WebTestProxy::willRequestResource):
1079         (WebTestRunner::WebTestProxy::willSendRequest):
1080         (WebTestRunner::WebTestProxy::didReceiveResponse):
1081         (WebTestRunner::WebTestProxy::didFinishResourceLoad):
1082         (WebTestRunner::WebTestProxy::didFailResourceLoad):
1083         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1084         (WebTestRunner::WebTestRunner::shouldDumpResourceLoadCallbacks):
1085         (WebTestRunner::WebTestRunner::shouldDumpResourceRequestCallbacks):
1086         (WebTestRunner::WebTestRunner::shouldDumpResourceResponseMIMETypes):
1087         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1088         (WebTestRunner::TestRunner::TestRunner):
1089         (WebTestRunner::TestRunner::reset):
1090         (WebTestRunner::TestRunner::shouldDumpResourceLoadCallbacks):
1091         (WebTestRunner::TestRunner::shouldDumpResourceRequestCallbacks):
1092         (WebTestRunner::TestRunner::shouldDumpResourceResponseMIMETypes):
1093         (WebTestRunner):
1094         (WebTestRunner::TestRunner::dumpResourceLoadCallbacks):
1095         (WebTestRunner::TestRunner::dumpResourceRequestCallbacks):
1096         (WebTestRunner::TestRunner::dumpResourceResponseMIMETypes):
1097         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1098         (TestRunner):
1099         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
1100         (WebTestRunner::WebTestProxyBase::reset):
1101         (WebTestRunner):
1102         (WebTestRunner::WebTestProxyBase::assignIdentifierToRequest):
1103         (WebTestRunner::WebTestProxyBase::willRequestResource):
1104         (WebTestRunner::WebTestProxyBase::willSendRequest):
1105         (WebTestRunner::WebTestProxyBase::didReceiveResponse):
1106         (WebTestRunner::WebTestProxyBase::didFinishResourceLoad):
1107         (WebTestRunner::WebTestProxyBase::didFailResourceLoad):
1108         * DumpRenderTree/chromium/WebViewHost.cpp:
1109         (WebViewHost::willSendRequest):
1110         (WebViewHost::makeURLErrorDescription):
1111         (WebViewHost::reset):
1112         * DumpRenderTree/chromium/WebViewHost.h:
1113         (WebViewHost):
1114
1115 2013-01-09  Dan Carney  <dcarney@google.com>
1116
1117         [chromium] move dumpcreateview methods to testrunner library
1118         https://bugs.webkit.org/show_bug.cgi?id=106434
1119
1120         Reviewed by Adam Barth.
1121
1122         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1123         (DRTTestRunner::DRTTestRunner):
1124         (DRTTestRunner::reset):
1125         * DumpRenderTree/chromium/DRTTestRunner.h:
1126         (DRTTestRunner):
1127         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1128         (WebTestRunner::WebTestRunner::shouldDumpCreateView):
1129         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1130         (WebTestRunner::TestRunner::TestRunner):
1131         (WebTestRunner::TestRunner::reset):
1132         (WebTestRunner::TestRunner::shouldDumpCreateView):
1133         (WebTestRunner):
1134         (WebTestRunner::TestRunner::dumpCreateView):
1135         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1136         (TestRunner):
1137
1138 2013-01-09  Csaba Osztrogonác  <ossy@webkit.org>
1139
1140         webkitpy cleanup: Merge additional_comment_text into comment_text
1141         https://bugs.webkit.org/show_bug.cgi?id=106421
1142
1143         Reviewed by Adam Barth.
1144
1145         * Scripts/webkitpy/common/config/committervalidator.py:
1146         (CommitterValidator.reject_patch_from_commit_queue):
1147         (CommitterValidator.reject_patch_from_review_queue):
1148         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1149         (Bugzilla.set_flag_on_attachment):
1150         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
1151         (MockBugzilla.set_flag_on_attachment):
1152         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
1153         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1154         (AbstractEarlyWarningSystem._post_reject_message_on_bug):
1155         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1156
1157 2013-01-09  Mario Sanchez Prada  <mario.prada@samsung.com>
1158
1159         [GTK] Raise version of gdk-pixbuf in jhbuild up to 2.26.5
1160         https://bugs.webkit.org/show_bug.cgi?id=106464
1161
1162         Reviewed by Martin Robinson.
1163
1164         Current version in jhbuild.modules (2.26.0) is giving trouble to
1165         when trying to build WebKitGTK from scratch, due to a segmentation
1166         fault error in gdk-pixbuf-query-loader during the 'make'
1167         phase. Raising the version to 2.26.5 fixes this issue.
1168
1169         * gtk/jhbuild.modules: Version raised, checksums updated.
1170
1171 2013-01-09  János Badics  <jbadics@inf.u-szeged.hu>
1172
1173         [Qt][NRWT] Pass --timeout to DRT/WTR if a test is marked as SLOW.
1174         https://bugs.webkit.org/show_bug.cgi?id=90968.
1175
1176         Reviewed by Csaba Osztrogonác.
1177
1178         Added functionality in DRT and WTR to use any timeout value while running
1179         slow tests (eventually, any test). Now NRWT --time-out-ms determines the
1180         timeout value for the test. Added a flag in NRWT (supports_per_test_timeout)
1181         to indicate whether the current port supports setting timeout value
1182         per test (it's False by default; I enabled it only on Qt).
1183         Also corrected a typo in driver.py
1184
1185         * DumpRenderTree/DumpRenderTree.h:
1186         (TestCommand::TestCommand):
1187         (TestCommand):
1188         * DumpRenderTree/DumpRenderTreeCommon.cpp:
1189         (parseInputLine):
1190         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1191         (WebCore::DumpRenderTree::processLine):
1192         * Scripts/webkitpy/layout_tests/port/base.py:
1193         (Port.supports_per_test_timeout):
1194         * Scripts/webkitpy/layout_tests/port/driver.py:
1195         (Driver.run_test):
1196         (Driver._command_from_driver_input):
1197         * Scripts/webkitpy/layout_tests/port/qt.py:
1198         (QtPort.supports_per_test_timeout):
1199         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1200         (WTR::InjectedBundle::InjectedBundle):
1201         (WTR::InjectedBundle::didReceiveMessage):
1202         (WTR::InjectedBundle::beginTesting):
1203         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1204         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1205         (WTR::TestRunner::setCustomTimeout):
1206         (WTR):
1207         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1208         (TestRunner):
1209         * WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp:
1210         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
1211         * WebKitTestRunner/TestController.cpp:
1212         (WTR::TestController::TestController):
1213         (WTR::TestController::getCustomTimeout):
1214         (WTR):
1215         (WTR::TestCommand::TestCommand):
1216         (TestCommand):
1217         (WTR::parseInputLine):
1218         (WTR::TestController::runTest):
1219         (WTR::TestController::runUntil):
1220         * WebKitTestRunner/TestController.h:
1221         (TestController):
1222         * WebKitTestRunner/TestInvocation.cpp:
1223         (WTR::TestInvocation::TestInvocation):
1224         (WTR::TestInvocation::setCustomTimeout):
1225         (WTR):
1226         (WTR::TestInvocation::invoke):
1227         * WebKitTestRunner/TestInvocation.h:
1228         (TestInvocation):
1229
1230 2013-01-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1231
1232         Regression(r138681): Add HAVE(ACCESSIBILITY) guard to atk files
1233         https://bugs.webkit.org/show_bug.cgi?id=106290
1234
1235         Reviewed by Martin Robinson.
1236
1237         Some atk files don't use HAVE(ACCESSIBILITY). It might make build errors when
1238         the macro isn't enabled.
1239
1240         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1241
1242 2013-01-08  Martin Robinson  <mrobinson@igalia.com>
1243
1244         WebKitTestRunner needs support for setHandlesAuthenticationChallenges
1245         https://bugs.webkit.org/show_bug.cgi?id=103653
1246
1247         Reviewed by Anders Carlsson.
1248
1249         Implement setHandlesAuthenticationChallenges in the UIProcess by sending credentials
1250         and the enabled boolean to the UIProcess and then implementing the didReceiveAuthenticationChallengeInFrame
1251         client callback.
1252
1253         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Exposed the new TestRunner
1254         methods to the JavaScript API.
1255         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1256         (WTR::TestRunner::setHandlesAuthenticationChallenges): Added this callback for the JavaScript API.
1257         (WTR::TestRunner::setAuthenticationUsername): Ditto.
1258         (WTR::TestRunner::setAuthenticationPassword): Ditto.
1259         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1260         (TestRunner): Added new declarations for the above.
1261         * WebKitTestRunner/TestController.cpp:
1262         (WTR::TestController::createWebViewWithOptions): Hook up the new didReceiveSynchronousMessageFromInjectedBundle
1263         callback.
1264         (WTR::TestController::resetStateToConsistentValues): Reset the credentials and enabled boolean between tests.
1265         (WTR::TestController::didReceiveAuthenticationChallengeInFrame): Handle the callback by using
1266         the authentication information passed from the InjectedBundle.
1267         * WebKitTestRunner/TestController.h:
1268         (WTR::TestController::setHandlesAuthenticationChallenges): Added setter to allow TestInvocation
1269         to communicate with the TestController.
1270         (WTR::TestController::setAuthenticationUsername): Ditto.
1271         (WTR::TestController::setAuthenticationPassword): Ditto.
1272         (TestController):
1273         * WebKitTestRunner/TestInvocation.cpp:
1274         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Handle the messages sending authentication
1275         information from the InjectedBundle.
1276         (WTR::TestInvocation::outputText): Added this method so that the TestController can output
1277         text to the TestInvocation text output.
1278         * WebKitTestRunner/TestInvocation.h:
1279         (TestInvocation): Added declaration for new method.
1280
1281 2013-01-08  Benjamin Poulain  <benjamin@webkit.org>
1282
1283         Add myself as a watcher for Web Geolocation
1284
1285         Unreviewed.
1286
1287         * Scripts/webkitpy/common/config/watchlist:
1288
1289 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
1290
1291         [webkitpy] Call setup_test_run method of the parent Port interface when method is called on subclasses
1292         https://bugs.webkit.org/show_bug.cgi?id=106364
1293
1294         Reviewed by Eric Seidel.
1295
1296         When the setup_test_run method is called on the subclasses of the base Port
1297         interface, the parent method should also be called via super(), despite the
1298         parent method not doing anything at the moment.
1299
1300         The according calls to super() are required in the ChromiumPort, EflPort
1301         and GtkPort implementations.
1302
1303         * Scripts/webkitpy/layout_tests/port/chromium.py:
1304         (ChromiumPort.setup_test_run):
1305         * Scripts/webkitpy/layout_tests/port/efl.py:
1306         (EflPort.setup_test_run):
1307         * Scripts/webkitpy/layout_tests/port/gtk.py:
1308         (GtkPort.setup_test_run):
1309
1310 2013-01-08  Julie Parent  <jparent@chromium.org>
1311
1312         Dashboard cleanup: Remove globals g_buildersThatFailedToLoad and g_staleBuilders
1313         https://bugs.webkit.org/show_bug.cgi?id=106356
1314
1315         g_buildersThatFailedToLoad and g_staleBuilders were globals defined in
1316         dashboard_base, assigned by Loader, and used only by dashboard_base to
1317         create error messages.  Moved the variables to be privates on the Loader
1318         object, moved error message creation to _getLoadingErrorMessages on the
1319         Loader object, and now pass the errors back to dashboard base via the
1320         resourceLoadingComplete callback.
1321         
1322         Also removed the now unused clearError function, it was only being used
1323         by unit tests to clean up global state.
1324         
1325         Reviewed by Dirk Pranke.
1326
1327         * TestResultServer/static-dashboards/dashboard_base.js:
1328         (resourceLoadingComplete):
1329         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1330         * TestResultServer/static-dashboards/loader.js:
1331         (.):
1332         * TestResultServer/static-dashboards/loader_unittests.js:
1333
1334 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
1335
1336         [EFL][GTK] Make the PulseAudioSanitizer an object on the EflPort, GtkPort
1337         https://bugs.webkit.org/show_bug.cgi?id=106354
1338
1339         Reviewed by Eric Seidel.
1340
1341         Put the PulseAudioSanitizer object on the EflPort and GtkPort interfaces
1342         instead of those two inheriting from it. Also add a mock object of the
1343         sanitizer that's used in unit tests.
1344
1345         * Scripts/webkitpy/layout_tests/port/efl.py:
1346         (EflPort):
1347         (EflPort.__init__):
1348         (EflPort.setup_test_run):
1349         (EflPort.clean_up_test_run):
1350         * Scripts/webkitpy/layout_tests/port/efl_unittest.py: Also correct the
1351         importing order.
1352         (EflPortTest.make_port): Put a mock PulseAudioSanitizer on the instance.
1353         * Scripts/webkitpy/layout_tests/port/gtk.py:
1354         (GtkPort):
1355         (GtkPort.__init__):
1356         (GtkPort.setup_test_run):
1357         (GtkPort.clean_up_test_run):
1358         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py: Also correct the
1359         importing order.
1360         (GtkPortTest.make_port): Put a mock PulseAudioSanitizer on the instance.
1361         * Scripts/webkitpy/layout_tests/port/pulseaudio_sanitizer.py:
1362         (PulseAudioSanitizer.unload_pulseaudio_module): Stylize the method as public.
1363         (PulseAudioSanitizer.restore_pulseaudio_module): Ditto.
1364         * Scripts/webkitpy/layout_tests/port/pulseaudio_sanitizer_mock.py: Added.
1365         (PulseAudioSanitizerMock): A simple mock interface for PulseAudioSanitizer.
1366         (PulseAudioSanitizerMock.unload_pulseaudio_module):
1367         (PulseAudioSanitizerMock.restore_pulseaudio_module):
1368
1369 2013-01-08  Jochen Eisinger  <jochen@chromium.org>
1370
1371         [chromium] move dumpFrameLoadCallbacks and friends to the TestRunner library
1372         https://bugs.webkit.org/show_bug.cgi?id=106324
1373
1374         Reviewed by Adam Barth.
1375
1376         Since the frame load callbacks are part of the WebFrameClient, the
1377         WebTestProxy is now intercepting both WebViewClient and WebFrameClient
1378         methods.
1379
1380         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1381         (DRTTestRunner::DRTTestRunner):
1382         (DRTTestRunner::reset):
1383         * DumpRenderTree/chromium/DRTTestRunner.h:
1384         (DRTTestRunner):
1385         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
1386         (WebTestInterfaces):
1387         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
1388         (WebKit):
1389         (WebTestProxyBase):
1390         (WebTestRunner):
1391         (WebTestRunner::WebTestProxy::WebTestProxy):
1392         (WebTestProxy):
1393         (WebTestRunner::WebTestProxy::didInvalidateRect):
1394         (WebTestRunner::WebTestProxy::didScrollRect):
1395         (WebTestRunner::WebTestProxy::scheduleComposite):
1396         (WebTestRunner::WebTestProxy::scheduleAnimation):
1397         (WebTestRunner::WebTestProxy::setWindowRect):
1398         (WebTestRunner::WebTestProxy::show):
1399         (WebTestRunner::WebTestProxy::didAutoResize):
1400         (WebTestRunner::WebTestProxy::postAccessibilityNotification):
1401         (WebTestRunner::WebTestProxy::startDragging):
1402         (WebTestRunner::WebTestProxy::shouldBeginEditing):
1403         (WebTestRunner::WebTestProxy::shouldEndEditing):
1404         (WebTestRunner::WebTestProxy::shouldInsertNode):
1405         (WebTestRunner::WebTestProxy::shouldInsertText):
1406         (WebTestRunner::WebTestProxy::shouldChangeSelectedRange):
1407         (WebTestRunner::WebTestProxy::shouldDeleteRange):
1408         (WebTestRunner::WebTestProxy::shouldApplyStyle):
1409         (WebTestRunner::WebTestProxy::didBeginEditing):
1410         (WebTestRunner::WebTestProxy::didChangeSelection):
1411         (WebTestRunner::WebTestProxy::didChangeContents):
1412         (WebTestRunner::WebTestProxy::didEndEditing):
1413         (WebTestRunner::WebTestProxy::registerIntentService):
1414         (WebTestRunner::WebTestProxy::dispatchIntent):
1415         (WebTestRunner::WebTestProxy::willPerformClientRedirect):
1416         (WebTestRunner::WebTestProxy::didCancelClientRedirect):
1417         (WebTestRunner::WebTestProxy::didStartProvisionalLoad):
1418         (WebTestRunner::WebTestProxy::didReceiveServerRedirectForProvisionalLoad):
1419         (WebTestRunner::WebTestProxy::didFailProvisionalLoad):
1420         (WebTestRunner::WebTestProxy::didCommitProvisionalLoad):
1421         (WebTestRunner::WebTestProxy::didReceiveTitle):
1422         (WebTestRunner::WebTestProxy::didFinishDocumentLoad):
1423         (WebTestRunner::WebTestProxy::didHandleOnloadEvents):
1424         (WebTestRunner::WebTestProxy::didFailLoad):
1425         (WebTestRunner::WebTestProxy::didFinishLoad):
1426         (WebTestRunner::WebTestProxy::didChangeLocationWithinPage):
1427         (WebTestRunner::WebTestProxy::didDisplayInsecureContent):
1428         (WebTestRunner::WebTestProxy::didRunInsecureContent):
1429         (WebTestRunner::WebTestProxy::didDetectXSS):
1430         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1431         (WebTestRunner::WebTestRunner::setTestIsRunning):
1432         (WebTestRunner::WebTestRunner::shouldDumpFrameLoadCallbacks):
1433         (WebTestRunner::WebTestRunner::setShouldDumpFrameLoadCallbacks):
1434         (WebTestRunner::WebTestRunner::shouldDumpUserGestureInFrameLoadCallbacks):
1435         (WebTestRunner::WebTestRunner::stopProvisionalFrameLoads):
1436         (WebTestRunner::WebTestRunner::shouldDumpTitleChanges):
1437         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1438         (WebTestRunner::TestRunner::TestRunner):
1439         (WebTestRunner::TestRunner::reset):
1440         (WebTestRunner::TestRunner::setTestIsRunning):
1441         (WebTestRunner):
1442         (WebTestRunner::TestRunner::shouldDumpFrameLoadCallbacks):
1443         (WebTestRunner::TestRunner::setShouldDumpFrameLoadCallbacks):
1444         (WebTestRunner::TestRunner::shouldDumpUserGestureInFrameLoadCallbacks):
1445         (WebTestRunner::TestRunner::stopProvisionalFrameLoads):
1446         (WebTestRunner::TestRunner::shouldDumpTitleChanges):
1447         (WebTestRunner::TestRunner::dumpFrameLoadCallbacks):
1448         (WebTestRunner::TestRunner::dumpUserGestureInFrameLoadCallbacks):
1449         (WebTestRunner::TestRunner::setStopProvisionalFrameLoads):
1450         (WebTestRunner::TestRunner::dumpTitleChanges):
1451         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1452         (TestRunner):
1453         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
1454         (WebTestInterfaces::Internal):
1455         (WebTestRunner::WebTestInterfaces::Internal::webView):
1456         (WebTestRunner::WebTestInterfaces::Internal::Internal):
1457         (WebTestRunner::WebTestInterfaces::Internal::setWebView):
1458         (WebTestRunner):
1459         (WebTestRunner::WebTestInterfaces::Internal::setTestIsRunning):
1460         (WebTestRunner::WebTestInterfaces::setWebView):
1461         (WebTestRunner::WebTestInterfaces::setTestIsRunning):
1462         (WebTestRunner::WebTestInterfaces::webView):
1463         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
1464         (WebTestRunner::WebTestProxyBase::willPerformClientRedirect):
1465         (WebTestRunner):
1466         (WebTestRunner::WebTestProxyBase::didCancelClientRedirect):
1467         (WebTestRunner::WebTestProxyBase::didStartProvisionalLoad):
1468         (WebTestRunner::WebTestProxyBase::didReceiveServerRedirectForProvisionalLoad):
1469         (WebTestRunner::WebTestProxyBase::didFailProvisionalLoad):
1470         (WebTestRunner::WebTestProxyBase::didCommitProvisionalLoad):
1471         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
1472         (WebTestRunner::WebTestProxyBase::didFinishDocumentLoad):
1473         (WebTestRunner::WebTestProxyBase::didHandleOnloadEvents):
1474         (WebTestRunner::WebTestProxyBase::didFailLoad):
1475         (WebTestRunner::WebTestProxyBase::didFinishLoad):
1476         (WebTestRunner::WebTestProxyBase::didChangeLocationWithinPage):
1477         (WebTestRunner::WebTestProxyBase::didDisplayInsecureContent):
1478         (WebTestRunner::WebTestProxyBase::didRunInsecureContent):
1479         (WebTestRunner::WebTestProxyBase::didDetectXSS):
1480         * DumpRenderTree/chromium/TestShell.cpp:
1481         (TestShell::runFileTest):
1482         (TestShell::testFinished):
1483         * DumpRenderTree/chromium/TestShell.h:
1484         (TestShell):
1485         * DumpRenderTree/chromium/WebViewHost.cpp:
1486         (WebViewHost::didStartProvisionalLoad):
1487         (WebViewHost::didReceiveServerRedirectForProvisionalLoad):
1488         (WebViewHost::didFailProvisionalLoad):
1489         (WebViewHost::didCommitProvisionalLoad):
1490         (WebViewHost::didReceiveTitle):
1491         (WebViewHost::didFailLoad):
1492         (WebViewHost::didFinishLoad):
1493         * DumpRenderTree/chromium/WebViewHost.h:
1494         (WebViewHost):
1495
1496 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
1497
1498         [GTK] Lower the default timeout value for WebKitTestRunner
1499         https://bugs.webkit.org/show_bug.cgi?id=106353
1500
1501         Reviewed by Dirk Pranke.
1502
1503         The default timeout value for WebKitTestRunner should be lowered.
1504         The current value (80 seconds) is irrational and just leads to producing
1505         text failures for layout tests that genuinely time out. This just leads
1506         to more deviation from the GTK WK1 port in terms of test expectations.
1507
1508         The value used is the same as when running the DumpRenderTree, that's
1509         6 seconds in release builds and 12 seconds in debug builds.
1510
1511         * Scripts/webkitpy/layout_tests/port/gtk.py:
1512         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
1513         (GtkPortTest.test_default_timeout_ms):
1514
1515 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
1516
1517         test-webkitpy shows failure output on my linux box
1518         https://bugs.webkit.org/show_bug.cgi?id=101261
1519
1520         Reviewed by Eric Seidel.
1521
1522         Mock out the PulseAudioSanitizer methods when creating testing instances
1523         of EflPort and GtkPort interfaces in unit tests. This stops throwing up
1524         PulseAudio output when the sanitizer was trying to unload modules which
1525         were already unloaded by another unit test that was being run in parallel.
1526
1527         * Scripts/webkitpy/layout_tests/port/efl_unittest.py:
1528         (EflPortTest):
1529         (EflPortTest.make_port):
1530         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
1531         (GtkPortTest):
1532         (GtkPortTest.make_port):
1533
1534 2013-01-08  Julie Parent  <jparent@chromium.org>
1535
1536         Dashboard Cleanup: Remove g_hasDoneInitialPageGeneration
1537         https://bugs.webkit.org/show_bug.cgi?id=106254
1538
1539         Remove the global variable g_hasDoneInitialPageGeneration.  It was used
1540         only to figure out if we should call addBuilderLoadErrors during
1541         handleLocationChange, which was called when the loader completed and on
1542         any hash change, but we only ever wanted to call addBuilderLoadErrors
1543         on the initial loader load.  Moved the call of addBuilderLoadErrors to
1544         resourceLoadingComplete rather than handleLocationChange, so now we
1545         only call it when we want to, and the check can go away completely.
1546
1547         Reviewed by Dirk Pranke.
1548
1549         * TestResultServer/static-dashboards/dashboard_base.js:
1550         (addBuilderLoadErrors):
1551         (resourceLoadingComplete):
1552         (handleLocationChange):
1553         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1554
1555 2013-01-08  Dominic Mazzoni  <dmazzoni@google.com>
1556
1557         Add aboxhall@chromium.org to accessibility watchlist.
1558
1559         Unreviewed.
1560
1561         * Scripts/webkitpy/common/config/watchlist:
1562
1563 2013-01-08  Dan Winship  <danw@gnome.org>
1564
1565         Add Apache 2.4 support for Fedora 18
1566         https://bugs.webkit.org/show_bug.cgi?id=104478
1567
1568         Reviewed by Martin Robinson.
1569
1570         Apache 2.4's httpd.conf is slightly incompatible with 2.2's, so we
1571         need a separate config.
1572
1573         * Scripts/webkitpy/layout_tests/port/base.py:
1574         (Port._apache_version):
1575         (Port._apache_config_file_name_for_platform):
1576         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1577         * Scripts/run-webkit-httpd:
1578         * Scripts/webkitperl/httpd.pm:
1579         (getApacheVersion):
1580         (getDefaultConfigForTestDirectory):
1581         (getHTTPDConfigPathForTestDirectory):
1582
1583 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
1584
1585         Make the override-feature-defines script compatible with Python v3
1586         https://bugs.webkit.org/show_bug.cgi?id=105742
1587
1588         Reviewed by Martin Robinson.
1589
1590         Instead of printing output through a statement, use the print function and format
1591         the output using the str.format method. This makes the script runnable with Python v3.
1592
1593         * gtk/override-feature-defines:
1594         (adjust_feature_defines_makefile):
1595
1596 2013-01-08  Heikki Paajanen  <heikki.paajanen@palm.com>
1597
1598         [Qt] Fix libxml2 config test
1599         https://bugs.webkit.org/show_bug.cgi?id=106317
1600
1601         Reviewed by Simon Hausmann.
1602
1603         Don't assume standard include/libxml2, libxml-2.0.pc should know
1604         where it's headers are.
1605
1606         * qmake/config.tests/libxml2/libxml2.cpp: Fix include
1607
1608 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
1609
1610         [GTK] Make Tools/gtk/generate-gtkdoc compatible with Python 3
1611         https://bugs.webkit.org/show_bug.cgi?id=106195
1612
1613         Reviewed by Philippe Normand.
1614
1615         Perform changes in the generate-gtkdoc script and common and gtkdoc modules
1616         to make the Python code compatible with Python 3. This includes modifying
1617         print statements, exception handling, dictionary iteration and
1618         byte-sequence-to-string conversion.
1619
1620         * gtk/common.py:
1621         (get_build_path):
1622         (pkg_config_file_variable):
1623         (gtk_version_of_pkg_config_file):
1624         * gtk/generate-gtkdoc:
1625         (print_missing_api):
1626         * gtk/gtkdoc.py:
1627         (GTKDoc.__init__):
1628         (GTKDoc._run_command):
1629
1630 2013-01-02  Steve Block  <steveblock@chromium.org>
1631
1632         Add chromium.org email address for Steve Block.
1633
1634         Unreviewed.
1635
1636         * Scripts/webkitpy/common/config/committers.py:
1637
1638 2013-01-07  Filip Pizlo  <fpizlo@apple.com>
1639
1640         Rationalize closure call heuristics and profiling
1641         https://bugs.webkit.org/show_bug.cgi?id=106270
1642
1643         Reviewed by Oliver Hunt.
1644         
1645         Add ability to use display-profiler-output via a pipe, and add the ability to dump
1646         all generated code ('display *' or 'd *').
1647
1648         * Scripts/display-profiler-output:
1649
1650 2013-01-07  Ryosuke Niwa  <rniwa@webkit.org>
1651
1652         Sorted more xcodeproj files.
1653
1654         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1655         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1656         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
1657
1658 2013-01-07  Ryosuke Niwa  <rniwa@webkit.org>
1659
1660         Sorted xcodeproj files.
1661
1662         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1663         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1664
1665 2013-01-07  Dan Bernstein  <mitz@apple.com>
1666
1667         [mac] WebKit1 clients can’t tell when a frame has been removed from the hierarchy
1668         https://bugs.webkit.org/show_bug.cgi?id=106261
1669
1670         Reviewed by Simon Fraser.
1671
1672         Added a test for -[WebFrameLoadDelegate webView:didRemoveFrameFromHierarchy:].
1673
1674         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1675         * TestWebKitAPI/Tests/mac/WebViewDidRemoveFrameFromHierarchy.mm: Added.
1676         (-[DidRemoveFrameFromHierarchyFrameLoadDelegate webView:didFinishLoadForFrame:]):
1677         (-[DidRemoveFrameFromHierarchyFrameLoadDelegate webView:didRemoveFrameFromHierarchy:]):
1678         (TestWebKitAPI):
1679         (TestWebKitAPI::TEST):
1680
1681 2013-01-07  Ojan Vafai  <ojan@chromium.org>
1682
1683         Add the Apple MountainLion bots to garden-o-matic.
1684         Eventually, we really should move away from hardcoding
1685         the list of bots.
1686
1687         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1688
1689 2013-01-07  Jochen Eisinger  <jochen@chromium.org>
1690
1691         [chromium] move web audio related methods to testrunner library
1692         https://bugs.webkit.org/show_bug.cgi?id=106211
1693
1694         Reviewed by Adam Barth.
1695
1696         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1697         (DRTTestRunner::DRTTestRunner):
1698         (DRTTestRunner::reset):
1699         * DumpRenderTree/chromium/DRTTestRunner.h:
1700         (DRTTestRunner):
1701         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1702         (WebKit):
1703         (WebTestRunner::WebTestRunner::shouldDumpAsAudio):
1704         (WebTestRunner::WebTestRunner::audioData):
1705         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1706         (WebTestRunner::TestRunner::TestRunner):
1707         (WebTestRunner::TestRunner::reset):
1708         (WebTestRunner::TestRunner::shouldDumpAsAudio):
1709         (WebTestRunner):
1710         (WebTestRunner::TestRunner::audioData):
1711         (WebTestRunner::TestRunner::setAudioData):
1712         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1713         (TestRunner):
1714         * DumpRenderTree/chromium/TestShell.cpp:
1715         (TestShell::dump):
1716
1717 2013-01-07  Mike West  <mkwst@chromium.org>
1718
1719         Make the IFRAME_SEAMLESS flag runtime-enabled.
1720         https://bugs.webkit.org/show_bug.cgi?id=106213
1721
1722         Reviewed by Ojan Vafai.
1723
1724         * DumpRenderTree/chromium/TestShell.cpp:
1725         (TestShell::TestShell):
1726         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1727         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1728         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1729         (resetDefaultsToConsistentValues):
1730         * DumpRenderTree/mac/DumpRenderTree.mm:
1731         (resetDefaultsToConsistentValues):
1732         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1733         (WebCore::WebPage::resetSettings):
1734         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1735         (WTR::InjectedBundle::beginTesting):
1736             Ensure that seamless IFrames are enabled for layout tests in each of
1737             the ports that support seamless IFrames.
1738
1739 2013-01-07  Jochen Eisinger  <jochen@chromium.org>
1740
1741         [chromium] move dumpAsText and friends to the TestRunner library
1742         https://bugs.webkit.org/show_bug.cgi?id=106222
1743
1744         Reviewed by Adam Barth.
1745
1746         This moves dumpAsText, dumpChildFramesAsText, and dumpChildFrameScrollPositions to the TestRunner library.
1747
1748         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1749         (DRTTestRunner::DRTTestRunner):
1750         (DRTTestRunner::reset):
1751         * DumpRenderTree/chromium/DRTTestRunner.h:
1752         (DRTTestRunner):
1753         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1754         (WebTestRunner::WebTestRunner::shouldDumpAsText):
1755         (WebTestRunner::WebTestRunner::setShouldDumpAsText):
1756         (WebTestRunner::WebTestRunner::shouldGeneratePixelResults):
1757         (WebTestRunner::WebTestRunner::setShouldGeneratePixelResults):
1758         (WebTestRunner::WebTestRunner::shouldDumpChildFrameScrollPositions):
1759         (WebTestRunner::WebTestRunner::shouldDumpChildFramesAsText):
1760         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1761         (WebTestRunner::TestRunner::TestRunner):
1762         (WebTestRunner::TestRunner::reset):
1763         (WebTestRunner::TestRunner::shouldDumpAsText):
1764         (WebTestRunner):
1765         (WebTestRunner::TestRunner::setShouldDumpAsText):
1766         (WebTestRunner::TestRunner::shouldGeneratePixelResults):
1767         (WebTestRunner::TestRunner::setShouldGeneratePixelResults):
1768         (WebTestRunner::TestRunner::shouldDumpChildFrameScrollPositions):
1769         (WebTestRunner::TestRunner::shouldDumpChildFramesAsText):
1770         (WebTestRunner::TestRunner::dumpAsText):
1771         (WebTestRunner::TestRunner::dumpChildFrameScrollPositions):
1772         (WebTestRunner::TestRunner::dumpChildFramesAsText):
1773         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1774         (TestRunner):
1775
1776 2013-01-07  Ryosuke Niwa  <rniwa@webkit.org>
1777
1778         Build fix attempt after r138810.
1779
1780         Apparently python 2.6 is really bad at floating point computation.
1781
1782         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
1783         (MainTest.test_run_memory_test):
1784
1785 2013-01-07  Ryosuke Niwa  <rniwa@webkit.org>
1786
1787         Extract a class to represent a test result to simplify PerfTest.parse_output and PageLoadPerfTest._run_with_driver
1788         https://bugs.webkit.org/show_bug.cgi?id=106172
1789
1790         Reviewed by Tony Chang.
1791
1792         Extracted PerfTestMetric, which represents a test result and knows how to compute statistics and convert itself
1793         to a dictionary. A metric is a type of measurement each test makes such as "Time", "Malloc", and "JSHeap".
1794         A single test (e.g. html5-full-render.html) may have multiple metrics, each of which is reported as a separate
1795         test on perf-o-matic and perf. test's results page.
1796
1797         Also, use python's compute_statistics instead of reading statistics off of DriverOutput to simplify the code.
1798
1799         * Scripts/webkitpy/performance_tests/perftest.py:
1800         (PerfTestMetric): Added.
1801         (PerfTestMetric.__init__): Added.
1802         (PerfTestMetric.metric): Added.
1803         (PerfTestMetric.has_values): Added.
1804         (PerfTestMetric.legacy_chromium_bot_compatible_test_name): Added. Following the legacy convention, "Malloc" and
1805         "JSHeap" will use "test_name:Malloc" whereas "Time" uses "test_name" itself. We should eventually move these
1806         conversions to be done on the client side (perf-o-matic and results page).
1807         (PerfTestMetric.append): Added.
1808         (PerfTestMetric.to_dict): Added. Computes the statistics and generates the dictionary object that represents
1809         a result for this metric.
1810         (PerfTestMetric.metric_to_unit): Added. Each metric maps to exactly one unit (it's not one-to-one).
1811         (PerfTestMetric.compute_statistics): Moved from PerfTest.
1812
1813         (PerfTest._create_driver): Extracted from PerfTest.run.
1814         (PerfTest.run): Given an array of PerfTestMetric, generate the results dictionary. Also print out results
1815         as needed.
1816         (PerfTest._run_with_driver):
1817         (PerfTest): Removed _result_classes and _result_class_regex. "result class" is the old name for "metric".
1818         (PerfTest.parse_output): Dramatically simplified. We now just return an array of PerfTestMetric's. Also ignore
1819         all keys except "values". We rely on PerfTestMetric to compute the statistics for us.
1820
1821         (ChromiumStylePerfTest.run): Added and merged _run_with_driver. Since chromium style perf tests are so different
1822         from other perf tests, there isn't much point in sharing the code here.
1823
1824         (PageLoadingPerfTest._run_with_driver): Simplified. Just create an array of PerfTestMetric's without computing
1825         statistics for the measured values.
1826
1827         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1828         (TestPerfTestMetric): Added.
1829         (TestPerfTestMetric.test_init_set_missing_unit): Added.
1830         (TestPerfTestMetric.test_legacy_chromium_bot_compatible_test_name): Added.
1831         (TestPerfTestMetric.test_has_values): Added.
1832         (TestPerfTestMetric.test_append): Added.
1833         (TestPerfTestMetric.test_compute_statistics.compute_statistics):
1834         (TestPerfTestMetric.test_compute_statistics): Added a trivial test case.
1835
1836         (TestPerfTest._assert_results_are_correct): Updated as needed.
1837         (TestPageLoadingPerfTest.test_run): Ditto. Notice that we no longer log anything in _run_with_driver. It's done
1838         in PerfTest.run now after generating the results dictionary.
1839         (TestPageLoadingPerfTest.test_run_with_memory_output): Ditto.
1840
1841 2013-01-07  Julien Chaffraix  <jchaffraix@webkit.org>
1842
1843         Support size_t multiplication and division operators on LayoutUnit
1844         https://bugs.webkit.org/show_bug.cgi?id=83848
1845
1846         Reviewed by Emil A Eklund.
1847
1848         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
1849         Added some simple tests for the new operators using size_t.
1850
1851 2013-01-07  Csaba Osztrogonác  <ossy@webkit.org>
1852
1853         [Qt] run-webkit-tests cleanup for parallel NRWT
1854         https://bugs.webkit.org/show_bug.cgi?id=106220
1855
1856         Reviewed by Dirk Pranke.
1857
1858         * Scripts/run-webkit-tests:
1859         (useNewRunWebKitTests):
1860         * Scripts/webkitpy/layout_tests/port/qt.py:
1861         (QtPort):
1862         (QtPort.default_child_processes):
1863
1864 2013-01-07  Philippe Normand  <pnormand@igalia.com>
1865
1866         Create a GStreamerAudio watchlist and add myself to it.
1867
1868         Unreviewed.
1869
1870         * Scripts/webkitpy/common/config/watchlist:
1871
1872 2013-01-05  Ryosuke Niwa  <rniwa@webkit.org>
1873
1874         Add svn:executable to a bunch of scripts in BuildSlaveSupport.
1875         Also removed the empty mac directory.
1876
1877         * BuildSlaveSupport/built-product-archive: Added property svn:executable.
1878         * BuildSlaveSupport/download-built-product: Added property svn:executable.
1879         * BuildSlaveSupport/mac: Removed.
1880         * BuildSlaveSupport/test-result-archive: Added property svn:executable.
1881
1882 2013-01-04  Ryosuke Niwa  <rniwa@webkit.org>
1883
1884         Add a script to delete stale zero-byte build files
1885         https://bugs.webkit.org/show_bug.cgi?id=106131
1886
1887         Reviewed by Tony Chang.
1888
1889         Delete zero-byte build files on Mac port for now. It doesn't do anything on other ports.
1890
1891         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1892         (DeleteStaleBuildFiles): Added.
1893         (Factory.__init__): Add DeleteStaleBuildFiles step.
1894         * BuildSlaveSupport/delete-stale-build-files: Added.
1895         (main): Delete zero-byte files except ones intentionally generated by our build process.
1896         (webkitBuildDirectory): Copied from build-product-archive.
1897
1898 2013-01-04  Michael Pruett  <michael@68k.org>
1899
1900         [GTK] Fix build error on GTK due to r138836
1901         https://bugs.webkit.org/show_bug.cgi?id=106154
1902
1903         Reviewed by Kentaro Hara.
1904
1905         * GNUmakefile.am:
1906
1907 2013-01-04  Dan Bernstein  <mitz@apple.com>
1908
1909         [mac] WebKit1 has no equivalent of WKBundleNodeHandleCopyHTMLTableCellElementCellAbove
1910         https://bugs.webkit.org/show_bug.cgi?id=106121
1911
1912         Reviewed by Adele Peterson.
1913
1914         Added test for -[DOMTHMLTableCellElement _cellAbove].
1915
1916         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1917         * TestWebKitAPI/Tests/mac/DOMHTMLTableCellCellAbove.mm: Added.
1918         (-[HTMLTableCellElementCellAboveTest webView:didFinishLoadForFrame:]):
1919         (TestWebKitAPI):
1920         (TestWebKitAPI::expectCellAboveCell):
1921         (TestWebKitAPI::TEST):
1922         * TestWebKitAPI/Tests/mac/DOMHTMLTableCellElementCellAbove.html: Added.
1923
1924 2013-01-04  Eric Seidel  <eric@webkit.org>
1925
1926         FlakyTestReporter should be re-enabled and taught how to post patches
1927         https://bugs.webkit.org/show_bug.cgi?id=103839
1928
1929         Reviewed by Adam Barth.
1930
1931         This moves LayoutTestResultsReader off of the DeprecatedPort object.
1932         It also adds a real Port object to the EWS and CommitQueue objects
1933         using a new PatchProcessingQueue superclass.
1934         PatchProcessingQueue doesn't seem to be the cleanest insertion point
1935         but works for this purpose.
1936         I also moved _upload_results_archive_for_patch into PatchProcessingQueue
1937         to resolve a FIXME.
1938
1939         This required some hacks/shiming between the non-specific "old"
1940         port names which the EWS system is currently using, and the new
1941         port objects.  This shimming is done in PatchProcessingQueue._new_port_name_from_old.
1942
1943         Hopefully this will fix the flaky test reporter and results uploading.
1944         Certainly it's another small step towards getting rid of the old ports.py
1945         infrastructure and making the NRWT Port class common webkitpy infrastructure.
1946
1947         Now that DeprecatedPort is no longer used for the results directory
1948         I removed all the explicit results-dir code which webkit-patch was using
1949         in --non-interactive mode to tell NRWT to use a results-dir it understood. :)
1950
1951         * Scripts/webkitpy/common/config/ports.py:
1952         (DeprecatedPort.run_perl_unittests_command):
1953         * Scripts/webkitpy/common/config/ports_mock.py:
1954         (MockPort.name):
1955         * Scripts/webkitpy/common/system/outputcapture.py:
1956         (OutputCapture.assert_outputs):
1957         * Scripts/webkitpy/layout_tests/port/apple.py:
1958         (ApplePort.determine_full_port_name):
1959         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
1960         (LayoutTestResultsReader.__init__):
1961         (LayoutTestResultsReader):
1962         (LayoutTestResultsReader._read_file_contents):
1963         (LayoutTestResultsReader._create_layout_test_results):
1964         (LayoutTestResultsReader._create_unit_test_results):
1965         (LayoutTestResultsReader.results):
1966         (LayoutTestResultsReader.archive):
1967         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
1968         (LayoutTestResultsReaderTest.test_missing_layout_test_results):
1969         (LayoutTestResultsReaderTest.test_create_unit_test_results):
1970         (test_missing_unit_test_results_path):
1971         (test_layout_test_results):
1972         (test_archive_last_layout_test_results):
1973         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1974         (AbstractEarlyWarningSystem):
1975         (AbstractEarlyWarningSystem.__init__):
1976         (AbstractEarlyWarningSystem.begin_work_queue):
1977         (AbstractEarlyWarningSystem.run_command):
1978         * Scripts/webkitpy/tool/commands/queues.py:
1979         (AbstractPatchQueue.work_item_log_path):
1980         (PatchProcessingQueue):
1981         (PatchProcessingQueue._new_port_name_from_old):
1982         (PatchProcessingQueue.begin_work_queue):
1983         (PatchProcessingQueue._upload_results_archive_for_patch):
1984         (CommitQueue):
1985         (CommitQueue.begin_work_queue):
1986         (CommitQueue.run_command):
1987         (AbstractReviewQueue):
1988         (AbstractReviewQueue.__init__):
1989         (AbstractReviewQueue.begin_work_queue):
1990         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1991         (AbstractPatchQueueTest.test_next_patch):
1992         (PatchProcessingQueueTest):
1993         (PatchProcessingQueueTest.test_upload_results_archive_for_patch):
1994         * Scripts/webkitpy/tool/steps/runtests.py:
1995         (RunTests.run):
1996         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
1997
1998 2013-01-04  Dana Jansens  <danakj@chromium.org>
1999
2000         [chromium] Remove lost-compositor-context layout tests
2001         https://bugs.webkit.org/show_bug.cgi?id=106089
2002
2003         Reviewed by James Robinson.
2004
2005         Remove the loseCompositorContext() test function.
2006
2007         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2008         (WebTestRunner::TestRunner::TestRunner):
2009         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2010         (TestRunner):
2011
2012 2013-01-04  Adam Klein  <adamk@chromium.org>
2013
2014         Remove ENABLE_MUTATION_OBSERVERS #define
2015         https://bugs.webkit.org/show_bug.cgi?id=105459
2016
2017         Reviewed by Ryosuke Niwa.
2018
2019         * Scripts/webkitperl/FeatureList.pm:
2020         * qmake/mkspecs/features/features.pri:
2021
2022 2013-01-04  Ryosuke Niwa  <rniwa@webkit.org>
2023
2024         Statistics used in perftest_unittest.py and perftest_integrationtest.py are bogus
2025         https://bugs.webkit.org/show_bug.cgi?id=106078
2026
2027         Reviewed by Tony Chang.
2028
2029         This patch updates values for individual iterations in dummy performance tests used in
2030         perftest_unittest.py and perftest_integrationtest.py so that they match up with
2031         statistics such as stdev and median reported in those tests. This change is required
2032         to resolve the bug 97510.
2033
2034         This patch also refactors integration tests by extracting *TestData classes that
2035         centralizes the definitions of each dummy performance test's text (DRT output),
2036         runner output, and parsed results (JSON) so that we may share more data between
2037         python tests.
2038
2039         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2040         (MainTest._assert_results_are_correct): Extracted from test_parse_output.
2041         Use self.assertAlmostEqual when comparing the standard deviation.
2042         (MainTest.test_parse_output):
2043         (test_parse_output_with_failing_line):
2044         (test_parse_output_with_description): Use _assert_results_are_correct.
2045         (test_parse_output_with_subtests): Ditto.
2046
2047         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
2048         (InspectorPassTestData): Extracted from tests below.
2049         (EventTargetWrapperTestData): Ditto.
2050         (SomeParserTestData): Ditto.
2051         (MemoryTestData): Ditto.
2052         (TestDriver.run_test): Moved test definitions out of the method.
2053         (MainTest._normalize_output): Truncate standard deviations at 5th decimal point.
2054         (MainTest._load_output_json): Extracted from create_runner.
2055         (MainTest.create_runner):
2056         (MainTest.test_run_test_set_for_parser_tests):
2057         (MainTest.test_run_memory_test):
2058         (MainTest._test_run_with_json_output):
2059         (MainTest.test_run_with_json_output):
2060         (MainTest.test_run_with_description):
2061         (MainTest.test_run_generates_json_by_default):
2062         (MainTest.test_run_merges_output_by_default):
2063         (MainTest.test_run_respects_reset_results):
2064         (MainTest.test_run_generates_and_show_results_page):
2065         (MainTest.test_run_with_slave_config_json):
2066         (MainTest.test_run_with_multiple_repositories):
2067
2068 2013-01-04  Martin Robinson  <mrobinson@igalia.com>
2069
2070         [GTK] [WebKit2] Clicking on a word that is selected in an editable area deletes it
2071         https://bugs.webkit.org/show_bug.cgi?id=106045
2072
2073         Reviewed by Carlos Garcia Campos.
2074
2075         Update test results to confirm that compositions without preedits do not trigger
2076         a composition confirmation.
2077
2078         * TestWebKitAPI/Tests/gtk/InputMethodFilter.cpp:
2079         (TestWebKitAPI::verifyCanceledComposition):
2080
2081 2013-01-04  Sailesh Agrawal  <sail@chromium.org>
2082
2083         [Mac] [WK2] platform/mac/fast/events/numpad-keycode-mapping.html fails
2084         https://bugs.webkit.org/show_bug.cgi?id=105958
2085
2086         Reviewed by Alexey Proskuryakov.
2087
2088         Ported code from DumpRenderTree to WebKitTestRunner to map all numpad keys.
2089
2090         * WebKitTestRunner/mac/EventSenderProxy.mm:
2091         (KeyMappingEntry):
2092         (WTR):
2093         (WTR::EventSenderProxy::keyDown): Added all numpad keys.
2094
2095 2013-01-03  Chris Fleizach  <cfleizach@apple.com>
2096
2097         REGRESSION: [Mac] Intermittent crash in WTR::AccessibilityUIElement::isEqual
2098         https://bugs.webkit.org/show_bug.cgi?id=106073
2099
2100         Reviewed by Ryosuke Niwa.
2101
2102         Check that the element being compared to is not nil. 
2103         This crash is happening because one of the accessibility tests does an isEqual comparison within a callback function.
2104         It looks like occasionally, one of the elements passed in to the isEqual is nil because the notification handler is on the accessibility
2105         controller, and the notification is being delivered after the document objects are cleared. This shouldn't happen but I've seen it 
2106         sometimes before on parallel WebKitTestRunner runs.
2107
2108         * DumpRenderTree/AccessibilityUIElement.cpp:
2109         (AccessibilityUIElement::isEqual):
2110         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2111         (WTR::AccessibilityUIElement::isEqual):
2112
2113 2013-01-03  Tim 'mithro' Ansell  <mithro@mithis.com>
2114
2115         Downloads can be flaky, so try downloading multiple times.
2116         https://bugs.webkit.org/show_bug.cgi?id=105976
2117
2118         Reviewed by Eric Seidel.
2119
2120         * Scripts/webkitpy/common/system/autoinstall.py:
2121         (AutoInstaller._download_to_stream):
2122
2123 2013-01-03  Eric Seidel  <eric@webkit.org>
2124
2125         Rename Tool.port to deprecated_port in preparation for removing more callers
2126         https://bugs.webkit.org/show_bug.cgi?id=106076
2127
2128         Reviewed by Ryosuke Niwa.
2129
2130         This resolves a long-standing FIXME to rename this method. :)
2131
2132         * Scripts/webkitpy/tool/bot/botinfo.py:
2133         (BotInfo.summary_text):
2134         * Scripts/webkitpy/tool/bot/irc_command.py:
2135         (Rollout._update_working_copy):
2136         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
2137         (LayoutTestResultsReader._create_layout_test_results):
2138         (LayoutTestResultsReader._create_unit_test_results):
2139         (LayoutTestResultsReader._results_directory):
2140         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
2141         (test_missing_unit_test_results_path):
2142         * Scripts/webkitpy/tool/main.py:
2143         (WebKitPatch.deprecated_port):
2144         * Scripts/webkitpy/tool/mocktool.py:
2145         (MockTool.deprecated_port):
2146         * Scripts/webkitpy/tool/steps/build.py:
2147         (Build.build):
2148         * Scripts/webkitpy/tool/steps/checkstyle.py:
2149         (CheckStyle.run):
2150         * Scripts/webkitpy/tool/steps/commit.py:
2151         (Commit._check_test_expectations):
2152         * Scripts/webkitpy/tool/steps/preparechangelog.py:
2153         (PrepareChangeLog.run):
2154         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
2155         (PrepareChangeLogForDEPSRoll.run):
2156         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
2157         (PrepareChangeLogForRevert.run):
2158         * Scripts/webkitpy/tool/steps/runtests.py:
2159         (RunTests.run):
2160         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2161         (StepsTest.test_runtests_args):
2162         * Scripts/webkitpy/tool/steps/update.py:
2163         (Update._update_command):
2164
2165 2013-01-03  Eric Seidel  <eric@webkit.org>
2166
2167         Add myself to the webkitpy watchlist.
2168
2169         Unreviewed.
2170
2171         * Scripts/webkitpy/common/config/watchlist:
2172
2173 2013-01-03  Ryosuke Niwa  <rniwa@webkit.org>
2174
2175         Cleanup perftest* tests and add a test for computing statistics
2176         https://bugs.webkit.org/show_bug.cgi?id=105685
2177
2178         Reviewed by Eric Seidel.
2179
2180         Add a test for PerfTest.compute_statistics (moved and renamed from PageLoadingPerfTest.calculate_statistics) and
2181         extracted perftestsrunner_itegrationtests.py from perftestsrunner_unittests.py.
2182
2183         Also fixed a bug in compute_statistics that the mean ('avg') value can have a large rounding errors in some cases.
2184
2185         * Scripts/webkitpy/performance_tests/perftest.py:
2186         (PerfTest.compute_statistics): Moved from PageLoadingPerfTest to prepare for the bug 97510. Also compute the mean
2187         directly from sorted_values instead of using the one from Knuth's online algorithm. This approach gives more
2188         accurate result for the mean.
2189         (PageLoadingPerfTest.run_single):
2190         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2191         (MainTest.test_compute_statistics):
2192         (MainTest.test_compute_statistics.compute_statistics): Added.
2193         (TestPageLoadingPerfTest.test_run): floatify values.
2194         (TestPageLoadingPerfTest.test_run_with_memory_output): Ditto. Also got rid of ".0" from mean values now that Python
2195         correctly recognizes them as integers.
2196
2197         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py: Copied from
2198         Tools/Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py.
2199         (TestDriver): Moved out of MainTest.
2200         (MainTest): Got rid of assertWritten and all unit tests.
2201         (MainTest._normalize_output): Renamed from normalizeFinishedTime to match the PEP8 naming convention.
2202         (MainTest.test_run_test_set_kills_drt_per_run.TestDriverWithStopCount):
2203         (MainTest.test_run_test_set_for_parser_tests):
2204         (MainTest.test_run_memory_test):
2205         (MainTest._test_run_with_json_output):
2206         (MainTest.test_run_generates_json_by_default):
2207         (MainTest.test_run_merges_output_by_default):
2208         (MainTest.test_run_respects_reset_results):
2209         (MainTest.test_run_generates_and_show_results_page): Use runner.load_output_json() instead of manually loading and
2210         parsing output JSON files. Just verify that the output path is correct instead.
2211         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2212         (MainTest): Removed all integration tests.
2213         (MainTest.create_runner): Simplified.
2214
2215 2013-01-03  Julie Parent  <jparent@chromium.org>
2216
2217         Dashboard cleanup: remove usage of global g_defaultBuilderName
2218         https://bugs.webkit.org/show_bug.cgi?id=106043
2219
2220         Use now public defaultBuilder() from the BuilderGroup, rather
2221         than global variable.
2222
2223         Also eliminates the setup() and initBuilders() functions since we
2224         no longer need to track the global.
2225
2226         Reviewed by Adam Barth.
2227
2228         * TestResultServer/static-dashboards/builders.js:
2229         (BuilderGroup.prototype.defaultBuilder):
2230         (BuilderGroup.prototype.master):
2231         * TestResultServer/static-dashboards/dashboard_base.js:
2232         (parseParameters):
2233         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2234         (updateDefaultBuilderState):
2235         * TestResultServer/static-dashboards/loader.js:
2236         (.):
2237         * TestResultServer/static-dashboards/loader_unittests.js:
2238
2239 2013-01-03  Ryosuke Niwa  <rniwa@webkit.org>
2240
2241         Disable an intermittently failing unit test for now.
2242         The failure is tracked by the bug 106051.
2243
2244         * TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.mm:
2245         (TestWebKitAPI::TEST):
2246
2247 2013-01-03  Dan Bernstein  <mitz@apple.com>
2248
2249         No way to obtain a DOMNode given a JS wrapper for a Node
2250         https://bugs.webkit.org/show_bug.cgi?id=106033
2251
2252         Added a test for +[DOMNode _nodeFromJSWrapper:].
2253
2254         Reviewed by Sam Weinig.
2255
2256         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2257         * TestWebKitAPI/Tests/mac/DOMNodeFromJSObject.mm: Added.
2258         (TestWebKitAPI):
2259         (TestWebKitAPI::TEST):
2260
2261 2013-01-03  Emil A Eklund  <eae@chromium.org>
2262
2263         Fix overflow in LayoutUnit::ceil and floor for SATURATED_LAYOUT_ARITHMETIC
2264         https://bugs.webkit.org/show_bug.cgi?id=105961
2265
2266         Reviewed by Levi Weintraub.
2267         
2268         Add tests for LayoutUnit::ceil and floor.
2269
2270         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
2271         (TestWebKitAPI::TEST):
2272         (TestWebKitAPI):
2273
2274 2013-01-03  Julie Parent  <jparent@chromium.org>
2275
2276         Add unit test for default builder for the dashboards.
2277         https://bugs.webkit.org/show_bug.cgi?id=105972
2278
2279         Reviewed by Dirk Pranke.
2280
2281         * TestResultServer/static-dashboards/loader_unittests.js:
2282
2283 2013-01-03  Tony Chang  <tony@chromium.org>
2284
2285         Generate internal.settings from Settings.in
2286         https://bugs.webkit.org/show_bug.cgi?id=104740
2287
2288         Reviewed by Adam Barth.
2289
2290         * GNUmakefile.am: Compile new generated files on GTK+.
2291         * qmake/mkspecs/features/default_post.prf: Qt: Make it so an action
2292         with both extra_sources and add_output_to_sources=false will still
2293         compile the files in extra_sources. This makes it possible to compile
2294         InternalSettingsGenerated.cpp and not be confused by
2295         InternalSettingsGenerated.idl.
2296
2297 2013-01-03  Zan Dobersek  <zandobersek@gmail.com>
2298
2299         [style] WebIDL-reflecting uppercase enums reported as style violation
2300         https://bugs.webkit.org/show_bug.cgi?id=105832
2301
2302         Reviewed by Tony Chang.
2303
2304         Recognize the enum as WebIDL-reflecting one if there's a comment present that
2305         indicates this. In enums spanning over multiple lines, the comment is expected
2306         on the first line. In enums placed in one line, the comment is expected at the
2307         end of that line.
2308
2309         WebIDL-reflecting enum values are required to be written in uppercase and as such
2310         violate the common rule of these values being written in InterCaps. Annotating
2311         enums this way makes it possible to avoid false style violation reports.
2312
2313         The comment is of form '// Web(?:Kit)?IDL enum'.
2314
2315         * Scripts/webkitpy/style/checkers/cpp.py:
2316         (_EnumState.__init__):
2317         (_EnumState.process_clean_line):
2318         (check_enum_casing):
2319         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2320         (NoNonVirtualDestructorsTest.test_enum_casing):
2321
2322 2013-01-03  Tim 'mithro' Ansell  <mithro@mithis.com>
2323
2324         Adding favicon.ico to the garden-o-matic.
2325         https://bugs.webkit.org/show_bug.cgi?id=105982
2326
2327         Reviewed by Adam Barth.
2328
2329         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2330         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon.ico:
2331
2332 2013-01-03  Jonathan Liu  <net147@gmail.com>
2333
2334         [Qt] Fix library linking order
2335         https://bugs.webkit.org/show_bug.cgi?id=105818
2336
2337         Some Qt libraries are linked before the private static libraries
2338         that depend on them which results in QtWebKit failing to link.
2339
2340         Copy Qt module dependencies from QT to QT_PRIVATE when creating
2341         module to ensure the Qt libraries are linked after the private
2342         static libraries that depend on them.
2343
2344         Reviewed by Tor Arne Vestbø.
2345
2346         * qmake/mkspecs/features/default_post.prf:
2347
2348 2013-01-02  Byungwoo Lee  <bw80.lee@samsung.com>
2349
2350         [EFL][WK2] Fix tooltip bugs in MiniBrowser.
2351         https://bugs.webkit.org/show_bug.cgi?id=102209
2352
2353         Reviewed by Gyuyoung Kim.
2354
2355         Set tooltip on the elm_window instead of ewk_view, and add delay to
2356         show the tooltip window.
2357
2358         Setting tooltip on the ewk_view makes elementary error message because
2359         ewk_view is not an elementary widget. To remove the error message,
2360         tooltip should be set on the elm_window.
2361
2362         Most browsers show the tooltip after a mouse pointer stays on an
2363         element object that has tooltip text.
2364         But elm_tooltip widget itself doesn't have delay or handle mouse
2365         events to show/hide.
2366
2367         So additional codes are added to show/hide tooltip widget along with
2368         mouse events.
2369           1) When a mouse pointer stays for a second on an element which has
2370              tooltip text, then tooltip widget is displayed.
2371           2) When a mouse pointer is moved or out of ewk_view, hide the tooltip
2372              widget.
2373
2374         * MiniBrowser/efl/main.c:
2375         (_Tooltip_Information):
2376         (_Browser_Window):
2377         (on_tooltip_show):
2378         (window_tooltip_hide):
2379         (window_tooltip_update):
2380         (on_mouse_in):
2381         (on_mouse_move):
2382         (on_mouse_out):
2383         (window_free):
2384         (on_tooltip_text_set):
2385         (on_tooltip_text_unset):
2386         (window_create):
2387
2388 2013-01-02  Tony Chang  <tony@chromium.org>
2389
2390         Unreviewed, rolling out r138661.
2391         http://trac.webkit.org/changeset/138661
2392         https://bugs.webkit.org/show_bug.cgi?id=104740
2393
2394         Compile problems on EFL
2395
2396         * GNUmakefile.am:
2397         * qmake/mkspecs/features/default_post.prf:
2398
2399 2013-01-02  Tony Chang  <tony@chromium.org>
2400
2401         Generate internal.settings from Settings.in
2402         https://bugs.webkit.org/show_bug.cgi?id=104740
2403
2404         Reviewed by Adam Barth.
2405
2406         * GNUmakefile.am: Compile new generated files on GTK+.
2407         * qmake/mkspecs/features/default_post.prf: Qt: Make it so an action
2408         with both extra_sources and add_output_to_sources=false will still
2409         compile the files in extra_sources. This makes it possible to compile
2410         InternalSettingsGenerated.cpp and not be confused by
2411         InternalSettingsGenerated.idl.
2412
2413 2013-01-02  Adam Barth  <abarth@webkit.org>
2414
2415         Remove old-run-webkit-tests support from webkitpy
2416         https://bugs.webkit.org/show_bug.cgi?id=105619
2417
2418         Reviewed by Eric Seidel.
2419
2420         This patch removes support for webkitpy parsing the
2421         old-run-webkit-tests results format. There doesn't seem to be any
2422         reason to keep this code around anymore now that most bots have
2423         switched to new-run-webkit-tests.
2424
2425         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2426         (Builder.fetch_layout_test_results):
2427         * Scripts/webkitpy/common/net/layouttestresults.py:
2428         (path_for_layout_test):
2429         (LayoutTestResults.results_from_string):
2430         (LayoutTestResults):
2431         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2432         (LayoutTestResultsTest.test_results_from_string):
2433         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2434         (test_flaky_test_failure):
2435         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
2436         (LayoutTestResultsReaderTest.test_missing_layout_test_results):
2437         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2438         (PatchAnalysisTask._test_patch):
2439         * Scripts/webkitpy/tool/commands/queuestest.py:
2440         (QueuesTest.assert_queue_outputs):
2441
2442 2013-01-02  Heikki Paajanen  <heikki.paajanen@palm.com>
2443
2444         [Qt][WK2] Add simple UI to find text from page
2445         https://bugs.webkit.org/show_bug.cgi?id=96481
2446
2447         Reviewed by Jocelyn Turcotte.
2448
2449         Find bar that slides between navigation bar and WebView.
2450
2451         * MiniBrowser/qt/BrowserWindow.cpp:
2452         (BrowserWindow::toggleFind):
2453         * MiniBrowser/qt/BrowserWindow.h:
2454         (BrowserWindow):
2455         * MiniBrowser/qt/MiniBrowser.qrc:
2456         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2457         (MiniBrowserApplication::notify):
2458         * MiniBrowser/qt/icons/find.png: Added.
2459         * MiniBrowser/qt/qml/BrowserWindow.qml:
2460
2461 2013-01-02  Christophe Dumez  <christophe.dumez@intel.com>
2462
2463         Regression(r138603): Caused 2 webkitpy tests to fail
2464         https://bugs.webkit.org/show_bug.cgi?id=105913
2465
2466         Reviewed by Kentaro Hara.
2467
2468         Fix 2 webkitpy tests that started to fail after
2469         r138603.
2470
2471         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2472         (IRCCommandTest._sheriff_test_data_url): Make sure the
2473         returned test file URL is valid no matter what the
2474         current working directory is.
2475         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
2476         (IRCBotTest.test_help): Add "sheriffs" command to the
2477         list of available commands.
2478
2479 2013-01-01  Christophe Dumez  <christophe.dumez@intel.com>
2480
2481         [WK2] plugins/clicking-missing-plugin-fires-delegate.html is failing
2482         https://bugs.webkit.org/show_bug.cgi?id=105897
2483
2484         Reviewed by Alexey Proskuryakov.
2485
2486         Dump in WebKitTestRunner the message that is expected by layout tests
2487         when the missing plugin button is clicked.
2488
2489         * WebKitTestRunner/TestController.cpp:
2490         (WTR::TestController::createWebViewWithOptions):
2491         (WTR::TestController::unavailablePluginButtonClicked):
2492         (WTR):
2493         * WebKitTestRunner/TestController.h:
2494         (TestController):
2495
2496 2013-01-01  KwangYong Choi  <ky0.choi@samsung.com>
2497
2498         [EFL] Enable MHTML feature
2499         https://bugs.webkit.org/show_bug.cgi?id=105815
2500
2501         Reviewed by Laszlo Gombos.
2502
2503         Enable MHTML feature for EFL port by default.
2504
2505         * Scripts/webkitperl/FeatureList.pm:
2506
2507 2013-01-01  Alan Cutter  <alancutter@chromium.org>
2508
2509         sheriff-bot should know who the gardeners/sheriffs are
2510         https://bugs.webkit.org/show_bug.cgi?id=105698
2511
2512         Reviewed by Eric Seidel.
2513
2514         Added a "sheriffs" command to sheriffbot to fetch the current Chromium Webkit sheriffs.
2515
2516         * Scripts/webkitpy/tool/bot/irc_command.py:
2517         (Current):
2518         (Current._retrieve_webkit_sheriffs):
2519         (Current.execute):
2520         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2521         (IRCCommandTest.test_current):
2522         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_0.js: Added.
2523         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_1.js: Added.
2524         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_2.js: Added.
2525         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_malformed.js: Added.
2526         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_zero.js: Added.
2527
2528 2012-12-31  Carlos Garcia Campos  <cgarcia@igalia.com>
2529
2530         [GTK] Move ImageDiff to the Tools directory root
2531         https://bugs.webkit.org/show_bug.cgi?id=105421
2532
2533         Reviewed by Kenneth Rohde Christiansen.
2534
2535         * DumpRenderTree/gtk/GNUmakefile.ImageDiff.am: Removed.
2536         * GNUmakefile.am:
2537         * ImageDiff/gtk/ImageDiff.cpp: Renamed from Tools/DumpRenderTree/gtk/ImageDiff.cpp.
2538
2539 2012-12-30  Mike West  <mkwst@chromium.org>
2540
2541         Add myself to watchlists for CSP and console logs.
2542         https://bugs.webkit.org/show_bug.cgi?id=105874
2543
2544         Reviewed by Dirk Pranke.
2545
2546         Because I really, really, really need more email.
2547
2548         * Scripts/webkitpy/common/config/committers.py:
2549             Add mkwst+watchlist@chromium.org as a contributor.
2550         * Scripts/webkitpy/common/config/watchlist:
2551             Create watchlist categories for 1) the various mechanisms used to
2552             generate console messages, and 2) CSP usage and files.
2553
2554 2012-12-30  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2555
2556         [EFL] Enable TEMPLATE_ELEMENT feature
2557         https://bugs.webkit.org/show_bug.cgi?id=105865
2558         
2559         Reviewed by Laszlo Gombos.
2560
2561         * Scripts/webkitperl/FeatureList.pm: Enable template element feature for EFL port.
2562
2563 2012-12-30  Zan Dobersek  <zandobersek@gmail.com>
2564
2565         Unreviewed GTK gardening of the unit tests.
2566
2567         Skip the TestInspectorServer unit test that's timing out completely.
2568
2569         * Scripts/run-gtk-tests:
2570         (TestRunner):
2571
2572 2012-12-29  Ilya Tikhonovsky  <loislo@chromium.org>
2573
2574         Web Inspector: Native Memory Instrumentation plugin: do not generate 'not instrumented' warning for instrumented mutable members.
2575         https://bugs.webkit.org/show_bug.cgi?id=105855
2576
2577         Reviewed by Vsevolod Vlasov.
2578
2579         Extract MemberExpr from ImplicitCastExpr. It happens when we instrument a mutable member because
2580         addMember expects const T& and the mutable ref to member implicitly converts into const ref to member.
2581
2582         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp:
2583         (ReportMemoryUsageVisitor):
2584         (clang::AddMemberCallVisitor::VisitCallExpr):
2585         (clang::ReportMemoryUsageVisitor::VisitCXXMethodDecl):
2586         (clang::ReportMemoryUsageVisitor::checkMembersCoverage):
2587
2588 2012-12-29  Ilya Tikhonovsky  <loislo@chromium.org>
2589
2590         Web Inspector: Native Memory Instrumentation plugin: move function bodies out of class declarations.
2591         https://bugs.webkit.org/show_bug.cgi?id=105852
2592
2593         Reviewed by Alexander Pavlov.
2594
2595         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp:
2596         (clang):
2597         (AddMemberCallVisitor):
2598         (ReportMemoryUsageVisitor):
2599         (clang::ReportMemoryUsageAction::ParseArgs):
2600         (clang::AddMemberCallVisitor::VisitCallExpr):
2601         (clang::ReportMemoryUsageVisitor::VisitCXXMethodDecl):
2602         (clang::ReportMemoryUsageVisitor::emitWarning):
2603         (clang::ReportMemoryUsageVisitor::findInstrumentationMethod):
2604         (clang::ReportMemoryUsageVisitor::needsToBeInstrumented):
2605         (clang::ReportMemoryUsageVisitor::CheckMembersCoverage):
2606
2607 2012-12-29  Zan Dobersek  <zandobersek@gmail.com>
2608
2609         [webkitpy] Omit webkitpy/thirdparty/BeautifulSoup.py from code coverage checking
2610         https://bugs.webkit.org/show_bug.cgi?id=105835
2611
2612         Reviewed by Dirk Pranke.
2613
2614         The BeautifulSoup module is a third-party import and as such we don't have much control
2615         over its testing. Because of that it should be omitted from code coverage checking.
2616
2617         * Scripts/webkitpy/test/main.py:
2618         (Tester._run_tests):
2619
2620 2012-12-28  Martin Robinson  <mrobinson@igalia.com>
2621
2622         [GTK][WK2] Add support for IME Composition
2623         https://bugs.webkit.org/show_bug.cgi?id=65093
2624
2625         Reviewed by Carlos Garcia Campos.
2626
2627         Update unit tests for GtkInputMethodFilter to note whether or not an event
2628         was a fake event synthesized for composition purposes. This is now used
2629         for WebKit2.
2630
2631         * TestWebKitAPI/Tests/gtk/InputMethodFilter.cpp:
2632         (TestWebKitAPI::TestInputMethodFilter::sendSimpleKeyEvent):
2633         (TestWebKitAPI::TestInputMethodFilter::sendKeyEventWithCompositionResults):
2634         (TestWebKitAPI::TEST):
2635         * gtk/generate-gtkdoc:
2636         (get_webkit2_options): Skip new files in the WebKit2 source directory for documentation
2637         generation.
2638
2639 2012-12-27  Ilya Tikhonovsky  <loislo@chromium.org>
2640
2641         Web Inspector: Native Memory Instrumentation. Update clang plugin according to the current state of memory instrumentation code.
2642         https://bugs.webkit.org/show_bug.cgi?id=105800
2643
2644         Reviewed by Yury Semikhatsky.
2645
2646         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp:
2647         (clang::ReportMemoryUsageConsumer::ReportMemoryUsageConsumer):
2648         (clang):
2649
2650 2012-12-27  Zan Dobersek  <zandobersek@gmail.com>
2651
2652         Create a GTK build system watchlist and add myself to it
2653         https://bugs.webkit.org/show_bug.cgi?id=105769
2654
2655         Reviewed by Dirk Pranke.
2656
2657         Add a GTK build system watchlist, watching the configure.ac, GNUmakefile.am files
2658         and the input GNUmakefile.features.am.in file. The GNUmakefile.list.am files are
2659         omitted on purpose due to relatively high change rate they are exposed to.
2660
2661         The new watchlist would be of use to me as the GTK build system recently went
2662         through a series of changes that included a changed policy on adding configuration
2663         flags to configure.ac and subsequent additions to GNUmakefile.am files. A PSA on the
2664         mailing list about this change will be published later, but I'd also like to be
2665         notified of any pending changes to these files just so I can check the changes are
2666         in compliance with the new policy.
2667
2668         * Scripts/webkitpy/common/config/watchlist:
2669
2670 2012-12-26  Ilya Tikhonovsky  <loislo@chromium.org>
2671
2672         Unreviewed. Replace find("Tools") with rfind("Tools") because base dir of WebKit may have Tools word.
2673         As example ..../DevTools/src/third_party/WebKit
2674
2675         * Scripts/webkitpy/common/webkit_finder.py:
2676         (WebKitFinder.webkit_base):
2677
2678 2012-12-25  Christophe Dumez  <christophe.dumez@intel.com>
2679
2680         [EFL][WK2] Refactor snapshot taking code
2681         https://bugs.webkit.org/show_bug.cgi?id=105687
2682
2683         Reviewed by Kenneth Rohde Christiansen.
2684
2685         Call WKViewCreateSnapshot() instead of WKViewGetSnapshot()
2686         since the function was renamed to follow naming style.
2687
2688         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2689         (WTR::PlatformWebView::windowSnapshotImage):
2690
2691 2012-12-24  Ilya Tikhonovsky  <loislo@chromium.org>
2692
2693         Web Inspector: Native Memory Instrumentation: propagate member type as edge type to the serialized heap graph.
2694         https://bugs.webkit.org/show_bug.cgi?id=105725
2695
2696         Reviewed by Yury Semikhatsky.
2697
2698         MemberType value names were adjusted according to Style Guide.
2699         Existing tests were extended with link type validation.
2700
2701         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
2702
2703 2012-12-24  Xiaobo Wang  <xbwang@torchmobile.com.cn>
2704
2705         [BlackBerry] DRT - Crashed when running pixels tests
2706         https://bugs.webkit.org/show_bug.cgi?id=105711
2707
2708         RIM PR 270003
2709
2710         Reviewed by George Staikos.
2711
2712         Calling window->post() here will result in buffer swapping which is
2713         only allowed in UI thread now, and I found we don't need to call it
2714         for GL renderer.
2715
2716         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
2717         (createBitmapContextFromWebView):
2718
2719 2012-12-22  Dan Winship  <danw@gnome.org>
2720
2721         Add a patch to fix libxml2 2.9.0 regression
2722         https://bugs.webkit.org/show_bug.cgi?id=104494
2723
2724         Reviewed by Martin Robinson.
2725
2726         * gtk/jhbuild.modules:
2727         * gtk/patches/libxml2-2.9.0-dtd.patch: patch from upstream
2728
2729 2012-12-23  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2730
2731         Unreviewed update of status to reviewer.
2732
2733         * Scripts/webkitpy/common/config/committers.py:
2734
2735 2012-12-23  Philippe Normand  <pnormand@igalia.com>
2736
2737         [GTK][jhbuild] Bump GStreamer to 1.0.4
2738         https://bugs.webkit.org/show_bug.cgi?id=105640
2739
2740         Reviewed by Martin Robinson.
2741
2742         * gtk/jhbuild.modules: Update GStreamer modules to 1.0.4.
2743
2744 2012-12-21  Nico Weber  <thakis@chromium.org>
2745
2746         chromium: webkit-build-directory doesn't handle ninja output dirs
2747         https://bugs.webkit.org/show_bug.cgi?id=105671
2748
2749         Reviewed by Daniel Bates.
2750
2751         Teach webkit-build-directory to detect the ninja build directory.
2752
2753         * Scripts/webkitdirs.pm:
2754         (determineBaseProductDir):
2755         (determineIsChromiumNinja):
2756
2757 2012-12-21  Ryosuke Niwa  <rniwa@webkit.org>
2758
2759         [Mountain Lion] platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation.html failing
2760         https://bugs.webkit.org/show_bug.cgi?id=95477
2761
2762         Reviewed by Sam Weinig.
2763
2764         Co-authored by Jia Pu.
2765
2766         Specify a fixed autocorrection dictionary in resetDefaultsToConsistentValues() so that
2767         we can have consistent autocorrection behavior when running tests.
2768
2769         * DumpRenderTree/mac/DumpRenderTree.mm:
2770         (resetDefaultsToConsistentValues):
2771         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2772         (WTR::InjectedBundle::platformInitialize):
2773
2774 2012-12-21  Zan Dobersek  <zandobersek@gmail.com>
2775
2776         [GTK] Add WebKit1-specific TestExpectations file
2777         https://bugs.webkit.org/show_bug.cgi?id=97562
2778
2779         Reviewed by Dirk Pranke.
2780
2781         Implement the expectations_files method inside the GtkPort class that
2782         returns the list of the TestExpectations files the current test configuration
2783         requires. The method is implemented in a similar way as on the EFL port.
2784         A unit test is also added.
2785
2786         * Scripts/webkitpy/layout_tests/port/gtk.py:
2787         (GtkPort._search_paths):
2788         (GtkPort):
2789         (GtkPort.expectations_files):
2790         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
2791         (GtkPortTest.test_expectations_files):
2792
2793 2012-12-21  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2794
2795         [EFL] Enable feature option for the CSS sticky position
2796         https://bugs.webkit.org/show_bug.cgi?id=105630
2797
2798         Reviewed by Kenneth Rohde Christiansen.
2799
2800         Enable CSS sticky position feature by default for the
2801         EFL port. This feature option was added in r138252.
2802
2803         No new tests. Existing layout tests pass.
2804
2805         * Scripts/webkitperl/FeatureList.pm:
2806
2807 2012-12-21  Jussi Kukkonen  <jussi.kukkonen@intel.com>
2808
2809         [WK2] REGRESSION(r138232): It made 4 tests timeout
2810         https://bugs.webkit.org/show_bug.cgi?id=105623
2811
2812         Reviewed by Kenneth Rohde Christiansen.
2813
2814         r138232 changed functionality so that empty text output
2815         no longer leads to a dump() call, which leads to a timeout.
2816         Instead do a text dump if there is text output or if there
2817         is no audio output.
2818
2819         * WebKitTestRunner/TestInvocation.cpp:
2820         (WTR::TestInvocation::dumpResults):
2821
2822 2012-12-21  Zeno Albisser  <zeno@webkit.org>
2823
2824         [Qt][Mac] run-launcher cannot find Qt5WebKitWidgets.
2825         https://bugs.webkit.org/show_bug.cgi?id=105309
2826
2827         On Windows the library name is Qt5WebKitWidgets as well.
2828         So r138136 should not have adjusted the library name for Windows.
2829
2830         Reviewed by Simon Hausmann.
2831
2832         * Scripts/webkitdirs.pm:
2833         (builtDylibPathForName):
2834
2835 2012-12-21  Zeno Albisser  <zeno@webkit.org>
2836
2837         [Qt] Add new TestExpectations for qt-5.0-mac-wk2.
2838         https://bugs.webkit.org/show_bug.cgi?id=105424
2839
2840         This change will allow us to run a very specific
2841         subset of the available LayoutTests on a mac buildbot.
2842         The new baseline search path for mac will look as follows:
2843         qt-5.0-mac-wk2 -> qt-5.0-wk2 -> qt-5.0 -> qt-mac -> qt
2844
2845         Reviewed by Dirk Pranke.
2846
2847         * Scripts/webkitpy/layout_tests/port/qt.py:
2848         (QtPort._search_paths):
2849         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2850         (QtPortTest):
2851
2852 2012-12-20  Ryuan Choi  <ryuan.choi@samsung.com>
2853
2854         [EFL] Build break with latest EFL libraries.
2855         https://bugs.webkit.org/show_bug.cgi?id=104827
2856
2857         Reviewed by Laszlo Gombos.
2858
2859         The eo EFL package is introduced and evas and ecore use it since 1.8.
2860         While introducing Eo, EFL changed several structures of Evas and Ecore
2861         from own specific class to Eo.
2862
2863         So, this patch adds FindEo and changes declaration of Evas, Evas_Object,
2864         Ecore_Timer to build with latest EFL libraries.
2865
2866         * DumpRenderTree/efl/CMakeLists.txt: Includes eo EFL library.
2867         * EWebLauncher/CMakeLists.txt: Ditto.
2868         * MiniBrowser/efl/CMakeLists.txt: Ditto.
2869         * ImageDiff/PlatformEfl.cmake: Ditto.
2870         * TestWebKitAPI/PlatformEfl.cmake: Ditto.
2871         * TestWebKitAPI/PlatformWebView.h: Modified declaration of Evas_Object.
2872         * WebKitTestRunner/InjectedBundle/TestRunner.h: Modified declaration of Ecore_Timer.
2873         * WebKitTestRunner/PlatformEfl.cmake: Includes eo EFL library.
2874         * WebKitTestRunner/PlatformWebView.h: Modified declaration of Evas_Object.
2875
2876 2012-12-20  Dirk Pranke  <dpranke@chromium.org>
2877
2878         TestExpectation fallback is broken
2879         https://bugs.webkit.org/show_bug.cgi?id=105583
2880
2881         Reviewed by Ryosuke Niwa.
2882
2883         When I added support for the -wk2 in port names, it looks
2884         like I broke the way we computed the list of TestExpectations
2885         files so that the implementation-version directory was left out :(.
2886         Fixed and cleaned up the tests.
2887
2888         * Scripts/webkitpy/layout_tests/port/base.py:
2889         (Port.expectations_files):
2890         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2891         (TestWebKitPort.__init__):
2892         (PortTestCase.test_skipped_directories_for_symbols):
2893         (test_skipped_directories_for_features):
2894         (test_skipped_directories_for_features_no_matching_tests_in_test_list):
2895         (test_skipped_tests_for_unsupported_features_empty_test_list):
2896         (test_skipped_layout_tests):
2897         (test_expectations_files):
2898
2899 2012-12-20  Anders Carlsson  <andersca@apple.com>
2900
2901         Don't include WebKit2 headers when building TestWebKitAPI on windows
2902         https://bugs.webkit.org/show_bug.cgi?id=105582
2903
2904         Reviewed by Tim Horton.
2905
2906         * TestWebKitAPI/config.h:
2907         * TestWebKitAPI/win/main.cpp:
2908
2909 2012-12-20  Ryosuke Niwa  <rniwa@webkit.org>
2910
2911         REGRESSION(r133820?): SimplifyMarkupTest API test asserts
2912         https://bugs.webkit.org/show_bug.cgi?id=105370
2913
2914         Reviewed by Simon Fraser.
2915
2916         Re-enable the test.
2917
2918         * TestWebKitAPI/Tests/mac/SimplifyMarkup.mm:
2919         (TestWebKitAPI::TEST):
2920
2921 2012-12-20  Nico Weber  <thakis@chromium.org>
2922
2923         chromium nrwt: Pick the newest binary found in DEFAULT_BUILD_DIRECTORIES, not the first
2924         https://bugs.webkit.org/show_bug.cgi?id=105498
2925
2926         Reviewed by Dirk Pranke.
2927
2928         Use the newest binary available rather than an than always picking one
2929         build directory over another based on iteration order.
2930
2931         * Scripts/webkitpy/layout_tests/port/chromium.py:
2932         (ChromiumPort._static_build_path):
2933         Check for timestamps.
2934         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2935         (ChromiumMacPortTest.test_build_path_timestamps):
2936         Test that out / xcodebuild selection happens based on timestamps
2937         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2938         (ChromiumWinPortTest.test_build_path_timestamps):
2939         Test that out / build selection happens based on timestamps
2940
2941 2012-12-19  Simon Fraser  <simon.fraser@apple.com>
2942
2943         Lots of sticky tests failing in WK2
2944         https://bugs.webkit.org/show_bug.cgi?id=105464
2945
2946         Reviewed by Beth Dakin.
2947
2948         WebKitTestRunner had a race between snapshotting in the UI process,
2949         and resettting after the test in the web process. InjectedBundle::done()
2950         was a bad place to call page()->resetAfterTest(), because of this race;
2951         it could reset the scroll position before the UI snapshot had been obtained.
2952         
2953         Fix by moving the call to page()->resetAfterTest() into didReceiveMessage(),
2954         for the "Reset" message which will come in before the next test.
2955
2956         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2957         (WTR::InjectedBundle::didReceiveMessage):
2958         (WTR::InjectedBundle::done):
2959
2960 2012-12-19  Filip Pizlo  <fpizlo@apple.com>
2961
2962         DFG speculation checks that take JumpList should consolidate OSRExits
2963         https://bugs.webkit.org/show_bug.cgi?id=105401
2964
2965         Reviewed by Oliver Hunt.
2966
2967         Update the profiler to understand that an OSR exit may have multiple
2968         candidate exit sites.
2969
2970         * Scripts/display-profiler-output:
2971
2972 2012-12-20  Eric Seidel  <eric@webkit.org>
2973
2974         EWSes do not need to dump build/test logs when things pass
2975         https://bugs.webkit.org/show_bug.cgi?id=105402
2976
2977         Reviewed by Dirk Pranke.
2978
2979         When we were first writing the commit-queue and EWS system
2980         and running them locally, we thought it was important to see the
2981         build/test output as it happened.  Now these queues have been running
2982         for years, and we don't use this feature anymore.  So this patch
2983         makes us stop tee-ing the output directly to stdout, and instead
2984         only print any output from commands when they fail.
2985
2986         I also added some logging when we execute each command
2987         since we are no longer printing the command output itself.
2988         This should make it much easier to see errors with the EWS
2989         system itself, now that all the passing-build output is removed.
2990
2991         This required updating a zillion unittests, since we have a bunch of
2992         "integration" style testing of the queue-bots.  Many of the unittests for the bots were
2993         already approximating this behavior by using a "logging" Executive.
2994         I disabled logging in those cases to avoid redundant logging in those tests.
2995
2996         * Scripts/webkitpy/common/system/executive.py:
2997         (Executive.command_for_printing):
2998         (Executive.run_command):
2999         * Scripts/webkitpy/common/system/executive_mock.py:
3000         (MockExecutive.command_for_printing):
3001         (MockExecutive.run_command):
3002         * Scripts/webkitpy/common/system/executive_unittest.py:
3003         (ExecutiveTest.test_auto_stringify_args):
3004         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3005         (EarlyWarningSytemTest._default_expected_logs):
3006         (_test_ews):
3007         (_test_ewses):
3008         * Scripts/webkitpy/tool/commands/queues.py:
3009         (AbstractQueue.run_webkit_patch):
3010         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3011         (AbstractQueueTest._assert_run_webkit_patch):
3012         (CommitQueueTest.test_commit_queue):
3013         (test_rollout):
3014         (test_rollout_lands):
3015         (test_manual_reject_during_processing):
3016         (StyleQueueTest.test_style_queue_with_style_exception):
3017         (test_style_queue_with_watch_list_exception):
3018
3019 2012-12-20  Dominic Mazzoni  <dmazzoni@google.com>
3020
3021         AX: support clickPoint in DRT for chromium
3022         https://bugs.webkit.org/show_bug.cgi?id=97359
3023
3024         Reviewed by Chris Fleizach.
3025
3026         Implement clickPointX, clickPointY, and elementAtPoint for Chromium, so that
3027         several more tests can pass.
3028
3029         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
3030         (WebTestRunner::AccessibilityUIElement::AccessibilityUIElement):
3031         (WebTestRunner::AccessibilityUIElement::clickPointXGetterCallback):
3032         (WebTestRunner):
3033         (WebTestRunner::AccessibilityUIElement::clickPointYGetterCallback):
3034         (WebTestRunner::AccessibilityUIElement::elementAtPointCallback):
3035         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h:
3036         (AccessibilityUIElement):
3037
3038 2012-12-20  Dan Bernstein  <mitz@apple.com>
3039
3040         prepare-ChangeLog adds "Additional information of the change such as approach, rationale" where it doesn't make sense
3041         https://bugs.webkit.org/show_bug.cgi?id=99268
3042
3043         Reviewed by Alexey Proskuryakov.
3044
3045         * Scripts/prepare-ChangeLog:
3046         (generateNewChangeLogs): Removed the "Additional information of the change" line.
3047
3048 2012-12-20  Carlos Garcia Campos  <cgarcia@igalia.com>
3049
3050         Unreviewed. Skip unit test /webkit/atk/getTextInParagraphAndBodyModerate
3051
3052         * Scripts/run-gtk-tests:
3053         (TestRunner):
3054
3055 2012-12-20  Thiago Marcos P. Santos  <thiago.santos@intel.com>
3056
3057         [Qt] Move ImageDiff to the Tools directory root
3058         https://bugs.webkit.org/show_bug.cgi?id=105420
3059
3060         Reviewed by Tor Arne Vestbø.
3061
3062         Moved ImageDiff from outside DumpRenderTree because it is also a
3063         dependency when running pixel tests for WebKit2.
3064
3065         * ImageDiff/ImageDiff.pro: Renamed from Tools/DumpRenderTree/qt/ImageDiff.pro.
3066         * ImageDiff/qt/ImageDiff.cpp: Renamed from Tools/DumpRenderTree/qt/ImageDiff.cpp.
3067         * Tools.pro:
3068
3069 2012-12-20  Zan Dobersek  <zandobersek@gmail.com>
3070
3071         [GTK] Remove the --enable-unstable-features configuration option
3072         https://bugs.webkit.org/show_bug.cgi?id=105327
3073
3074         Reviewed by Martin Robinson.
3075
3076         Add a missing feature option for the CSS sticky position feature.
3077
3078         * Scripts/webkitperl/FeatureList.pm:
3079
3080 2012-12-20  Carlos Garcia Campos  <cgarcia@igalia.com>
3081
3082         Unreviewed. Skip unit test WebKit2.ForceRepaint that times out
3083
3084         * Scripts/run-gtk-tests:
3085         (TestRunner):
3086
3087 2012-12-20  Dominik Röttsches  <dominik.rottsches@intel.com>
3088
3089         [EFL] MiniBrowser does not play Infinite Gangnam Style
3090         https://bugs.webkit.org/show_bug.cgi?id=103531
3091
3092         Reviewed by Kenneth Rohde Christiansen.
3093
3094         For EFL we would like this feature to be built by default.
3095
3096         * Scripts/webkitperl/FeatureList.pm:
3097
3098 2012-12-20  Csaba Osztrogonác  <ossy@webkit.org>
3099
3100         [Qt] EWS bots should call qmake always
3101         https://bugs.webkit.org/show_bug.cgi?id=90049
3102
3103         Reviewed by Simon Hausmann.
3104
3105         * Scripts/webkitdirs.pm:
3106         (buildQMakeProjects):
3107
3108 2012-12-20  Jochen Eisinger  <jochen@chromium.org>
3109
3110         [chromium] fix stray printf in TestRunner's WebTestProxy
3111         https://bugs.webkit.org/show_bug.cgi?id=105515
3112
3113         Reviewed by Ryosuke Niwa.
3114
3115         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3116         (WebTestRunner::WebTestProxyBase::shouldInsertNode):
3117
3118 2012-12-20  Dominik Röttsches  <dominik.rottsches@intel.com>
3119
3120         [WK2] WebAudio WKTR support
3121         https://bugs.webkit.org/show_bug.cgi?id=95084
3122
3123         Reviewed by Kenneth Rohde Christiansen.
3124
3125         Implementing audio data dump support for WebKitTestRunner,
3126         by adding the API to the IDL, enabling IPC for transferring
3127         the audio data as bytebuffer and dumping it according
3128         to run-webkit-tests script's expectations.
3129         This enables audio testing on WebKit2 ports.
3130         Based on initial wip-patch from Philippe Normand - thanks.
3131
3132         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Adding setAudioData API.
3133         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Assign audio buffer data to a local WKDataRef after extracting it from WK2 using WKBundleDataFromUint8Array bundle API.
3134         (WTR::TestRunner::setAudioData):
3135         (WTR):
3136         * WebKitTestRunner/InjectedBundle/TestRunner.h: Add a whatToDump state for dumping Audio.
3137         (TestRunner):
3138         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: Add audio to the message that's transferred to the WKTR process.
3139         (WTR::InjectedBundle::done):
3140         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: Allow setting and audio result handle to be transferred.
3141         (WTR::InjectedBundle::setAudioResult):
3142         (InjectedBundle):
3143         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3144         (WTR::InjectedBundlePage::dump): Dummy handling the Audio case in the switch, build fix for Mac.
3145         * WebKitTestRunner/TestInvocation.cpp: Audio dump support, dump audio if we haven't received a text dump from the web process.
3146         (WTR::TestInvocation::dumpResults):
3147         (WTR):
3148         (WTR::TestInvocation::dumpAudio):
3149         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Storing received audio data before dumping.
3150         * WebKitTestRunner/TestInvocation.h:
3151         (TestInvocation):
3152
3153 2012-12-20  Alberto Garcia  <agarcia@igalia.com>
3154
3155         [GTK] Count failed and timed out tests separately
3156         https://bugs.webkit.org/show_bug.cgi?id=105448
3157
3158         Reviewed by Carlos Garcia Campos.
3159
3160         Display the number of tests that fail, time out and are skipped
3161         separately in the buildbot page.
3162
3163         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3164         (RunGtkAPITests.commandComplete):
3165         (RunGtkAPITests.evaluateCommand):
3166         (RunGtkAPITests.getText2):
3167         * Scripts/run-gtk-tests:
3168         (TestRunner.run_tests):
3169
3170 2012-12-19  Ryosuke Niwa  <rniwa@webkit.org>
3171
3172         PerfTest.parse_output does too much
3173         https://bugs.webkit.org/show_bug.cgi?id=105391
3174
3175         Reviewed by Tony Chang.
3176
3177         Moved the code to filter lines into PerfTest._filter_output, which has been renamed from _filter_stderr.
3178         Also moved the code to output test results into PerfTest._run_with_driver.
3179
3180         * Scripts/webkitpy/performance_tests/perftest.py:
3181         (PerfTest.__init__): Added _description.
3182         (PerfTest.description): Added.
3183         (PerfTest._run_with_driver): Moved the code to output test description and test results.
3184         (PerfTest._filter_output): Moved and renamed from PerfTest._filter_stderr.
3185         (PerfTest.parse_output): Removed the code to output test results. Return test results and description
3186         respectively. Also removed the code that allowed some tests to omit values since all tests report each
3187         iteration now since r136492.
3188         (PerfTest.output_statistics): Removed the code to print test description, now done in _run_with_driver.
3189         (ChromiumStylePerfTest._run_with_driver): Added. Chromium style tests are sufficiently different from
3190         regular PerfTest that it doesn't make much sense to share _run_with_driver. But really, we should just
3191         get rid of this type of test altogether in favor of regular performance tests that uses runner.js.
3192         (ChromiumStylePerfTest.parse_and_log_output): Renamed from parse_output.
3193         (PageLoadingPerfTest._run_with_driver): Removed the explicit '' for the test description.
3194         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
3195         (MainTest.test_parse_output): Removed the expected logs since parse_output no longer prints out results.
3196         Also added a call to _filter_output since parse_output doesn't filter the output text anymore.
3197         (MainTest.test_parse_output_with_failing_line): Added a call to _filter_output. Also added ',' after 'Time:'
3198         so that it's not string-concatenated with the next line.
3199         (MainTest.test_parse_output_with_description): Added; a test for PerfTest.description().
3200         (MainTest.test_parse_output_with_subtests): Removed the expected logs, and added a call to _filter_output.
3201
3202 2012-12-19  Alexis Menard  <alexis@webkit.org>
3203
3204         Implement CSS parsing for CSS transitions unprefixed.
3205         https://bugs.webkit.org/show_bug.cgi?id=104804
3206
3207         Reviewed by Dean Jackson.
3208
3209         Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
3210         to cover the work of unprefixing Transforms, Animations and 
3211         Transitions. It will let the possibility of each ports to turn it off 
3212         in their release branches until we're confident that these CSS 
3213         properties are ready to be unprefixed.
3214
3215         * Scripts/webkitperl/FeatureList.pm:
3216         * qmake/mkspecs/features/features.pri:
3217
3218 2012-12-19  Julien Chaffraix  <jchaffraix@webkit.org>
3219
3220         2 clampTo unit tests are failing
3221         https://bugs.webkit.org/show_bug.cgi?id=105253
3222
3223         Reviewed by Emil A Eklund.
3224
3225         Removed clampToUnsigned as it was actually testing exactly what
3226         clampToUnsignedLong was doing. Also made clampToIntFloat more robust
3227         to precision loss (fix suggested by Emil).
3228
3229         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
3230
3231 2012-12-19  Thiago Marcos P. Santos  <thiago.santos@intel.com>
3232
3233         [EFL] Move ImageDiff to the Tools directory root
3234         https://bugs.webkit.org/show_bug.cgi?id=105305
3235
3236         Reviewed by Laszlo Gombos.
3237
3238         We previously moved this directory from the DRT directory to
3239         efl/ImageDiff. The major reason for doing so was because ImageDiff does
3240         not depend on DumpRenderTree but for legacy reasons was living inside the
3241         DRT folder, even though it is needed when running pixel tests for WK2.
3242
3243         Now we are moving to Tool directory root as other ports agreed to do the same.
3244
3245         * CMakeLists.txt:
3246         * ImageDiff/CMakeLists.txt: Added.
3247         * ImageDiff/PlatformEfl.cmake: Added.
3248         * ImageDiff/efl/ImageDiff.cpp: Renamed from Tools/efl/ImageDiff/ImageDiff.cpp.
3249         * efl/ImageDiff/CMakeLists.txt: Removed.
3250
3251 2012-12-19  Zeno Albisser  <zeno@webkit.org>
3252
3253         [Qt][Mac] run-launcher cannot find Qt5WebKitWidgets.
3254         https://bugs.webkit.org/show_bug.cgi?id=105309
3255
3256         The version number is only used as a part
3257         of the library name on Linux.
3258
3259         Reviewed by Kenneth Rohde Christiansen.
3260
3261         * Scripts/webkitdirs.pm:
3262         (builtDylibPathForName):
3263
3264 2012-12-19  Alberto Garcia  <agarcia@igalia.com>
3265
3266         [GTK] Tests that time out are not considered as failures.
3267         https://bugs.webkit.org/show_bug.cgi?id=105318
3268
3269         Reviewed by Martin Robinson.
3270
3271         Fix parsing of the GTK API tests log files.
3272
3273         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3274         (RunGtkAPITests.commandComplete):
3275
3276 2012-12-18  Ilya Tikhonovsky  <loislo@chromium.org>
3277
3278         Unreviewed, rolling out r138061.
3279         https://bugs.webkit.org/show_bug.cgi?id=105396
3280
3281         Original patch:
3282         http://trac.webkit.org/changeset/138061
3283         https://bugs.webkit.org/show_bug.cgi?id=97359
3284
3285         It is crashing on Debug bots
3286
3287         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
3288         (WebTestRunner::AccessibilityUIElement::AccessibilityUIElement):
3289         (WebTestRunner::AccessibilityUIElement::elementAtPointCallback):
3290         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h:
3291         (AccessibilityUIElement):
3292
3293 2012-12-18  Alice Liu  <alice.liu@apple.com>
3294
3295         Test for https://bugs.webkit.org/show_bug.cgi?id=105106
3296         Add SPI to WebKit1 WebFrame for hit testing
3297
3298         Reviewed by Dan Bernstein.
3299
3300         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added file Tests/mac/ElementAtPointInWebFrame.mm
3301         * TestWebKitAPI/Tests/mac/ElementAtPointInWebFrame.mm: Added.
3302         (TestWebKitAPI::TEST): Loads html with two divs positioned in the 2nd and 4th quadrants of the webview.
3303         Then hit-tests at three points, expecting to hit the two divs and body element. 
3304
3305 2012-12-18  Alice Liu  <alice.liu@apple.com>
3306
3307         Test for https://bugs.webkit.org/show_bug.cgi?id=105262
3308         Add SPI to WebKit1 WebFrame for node conversion to JSValueRef
3309
3310         Reviewed by Anders Carlsson.
3311
3312         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added file Tests/mac/JSWrapperForNodeInWebFrame.mm.mm
3313         * TestWebKitAPI/Tests/mac/JSWrapperForNodeInWebFrame.mm.mm: Added.
3314         (TestWebKitAPI::TEST): Tests for the correct JS wrapper for a DOMNode, provided a WebScriptWorld.
3315         Loads html with a single div element. In an isolated world, creates a property on that node.
3316         Also, in the standard world, creates a different property on that node.  Then tests for 4 things:
3317             - Existence of the isolated property in the isolated world.
3318             - Existence of the standard property in the standard world.
3319             - Non-existence of the isolated property in the standard world.
3320             - Non-existence of the standard property in the isolated world.
3321
3322 2012-12-18  Simon Fraser  <simon.fraser@apple.com>
3323
3324         Disable the SimplifyMarkup API test, wich asserts in debug builds.
3325         Tracked by https://bugs.webkit.org/show_bug.cgi?id=105370.
3326         
3327         * TestWebKitAPI/Tests/mac/SimplifyMarkup.mm:
3328         (TestWebKitAPI::TEST):
3329
3330 2012-12-18  Joseph Pecoraro  <pecoraro@apple.com>
3331
3332         [Mac] Add Build Phase to Check Headers for Inappropriate Macros (Platform.h macros)
3333         https://bugs.webkit.org/show_bug.cgi?id=104279
3334
3335         Reviewed by David Kilzer.
3336
3337         Add a build phase script that checks a framework's header files for
3338         Platform.h and Compiler.h macros. Also add some tests for the script.
3339
3340         * Scripts/check-for-inappropriate-macros-in-external-headers: Added.
3341         Script to be used in build phases to check for inappropriate macros in headers.
3342
3343         * Scripts/test-webkitruby: Added.
3344         Script that can be used to run all webkitruby tests.
3345
3346         * Scripts/test-webkit-scripts:
3347         Also run the ruby tests.
3348
3349         * Scripts/webkitruby/check-for-inappropriate-macros-in-external-headers-tests/fake-data-failing-expected.txt: Added.
3350         * Scripts/webkitruby/check-for-inappropriate-macros-in-external-headers-tests/pass-expected.txt: Added.
3351         * Scripts/webkitruby/check-for-inappropriate-macros-in-external-headers-tests/resources/Fake.framework/Headers/Fail.h: Added.
3352         * Scripts/webkitruby/check-for-inappropriate-macros-in-external-headers-tests/resources/Fake.framework/Headers/Pass.h: Added.
3353         * Scripts/webkitruby/check-for-inappropriate-macros-in-external-headers-tests/run-test.rb: Added.
3354         Tests for the new script.
3355
3356 2012-12-18  Dominic Mazzoni  <dmazzoni@google.com>
3357
3358         AX: support clickPoint in DRT for chromium
3359         https://bugs.webkit.org/show_bug.cgi?id=97359
3360
3361         Reviewed by Chris Fleizach.
3362
3363         Implement clickPointX, clickPointY, and elementAtPoint for Chromium, so that
3364         several more tests can pass.
3365
3366         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
3367         (WebTestRunner::AccessibilityUIElement::AccessibilityUIElement):
3368         (WebTestRunner::AccessibilityUIElement::clickPointXGetterCallback):
3369         (WebTestRunner):
3370         (WebTestRunner::AccessibilityUIElement::clickPointYGetterCallback):
3371         (WebTestRunner::AccessibilityUIElement::elementAtPointCallback):
3372         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h:
3373         (AccessibilityUIElement):
3374
3375 2012-12-18  Ryosuke Niwa  <rniwa@webkit.org>
3376
3377         Build fix after r138045.
3378
3379         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3380         (PerfTestsRunner._collect_tests): Use relative_path. We skip only when this path
3381         is not explicitly specified. The condition was backwards but never matched so we
3382         always ran the test regardless of whether it's listed in the skipped list or not.
3383         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3384         (test_collect_tests_with_ignored_skipped_list): Renamed so that it actually runs.
3385
3386 2012-12-18  Emil A Eklund  <eae@chromium.org>
3387
3388         TestWebKitAPI/Tests/WebCore/LayoutUnit fails on mac
3389         https://bugs.webkit.org/show_bug.cgi?id=105332
3390         
3391         Reviewed by Levi Weintraub.
3392         
3393         Create new test suite for LayoutUnit tests as the KURL tests are
3394         of the incompatible TEST_F type.
3395
3396         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
3397         (TestWebKitAPI):
3398         (TestWebKitAPI::TEST_F):
3399
3400 2012-12-18  Ryosuke Niwa  <rniwa@webkit.org>
3401
3402         Running a skipped test with run-perf-tests could alert the user
3403         https://bugs.webkit.org/show_bug.cgi?id=105219
3404
3405         Reviewed by Eric Seidel.
3406
3407         Force run skipped performance tests explicitly specified in the command line.
3408         Also warn the user when the specified paths don't exist.
3409
3410         * Scripts/webkitpy/layout_tests/port/base.py:
3411         (Port.relative_test_filename):
3412         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3413         (PerfTestsRunner._parse_args):
3414         (PerfTestsRunner._collect_tests):
3415         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3416         (test_collect_tests_with_skipped_list_and_files):
3417
3418 2012-12-18  Yaron Friedman  <yfriedman@chromium.org>
3419
3420         Chrome Android java output is too verbose
3421         https://bugs.webkit.org/show_bug.cgi?id=105247
3422
3423         Reviewed by Tony Chang.
3424
3425         Pass -quiet to ant to suppress extraneous output.
3426
3427         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3428         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
3429
3430 2012-12-18  Ryosuke Niwa  <rniwa@webkit.org>
3431
3432         Consider removing --pause-before-testing option
3433         https://bugs.webkit.org/show_bug.cgi?id=105248
3434
3435         Reviewed by Eric Seidel.
3436
3437         Remove --pause-before-testing option.
3438
3439         * Tools/Scripts/webkitpy/layout_tests/port/driver.py:
3440         (DriverProxy.start): Removed.
3441         * Scripts/webkitpy/performance_tests/perftest.py:
3442         (PerfTest.__init__):
3443         (PerfTest.test_path): Renamed from path_or_url.
3444         (PerfTest.run):
3445         (PerfTest): Removed "driver" argument.
3446         (PerfTest._run_with_driver):
3447         (PerfTest.run_single):
3448         (ChromiumStylePerfTest.__init__):
3449         (PageLoadingPerfTest.__init__):
3450         (PageLoadingPerfTest.run_single):
3451         (PageLoadingPerfTest._run_with_driver): Renamed from run so that PerfTest.run can create a driver for us.
3452         (ReplayPerfTest.__init__):
3453         (ReplayPerfTest.prepare):
3454         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
3455         (TestPageLoadingPerfTest.test_run):
3456         (TestPageLoadingPerfTest.test_run_with_memory_output):
3457         (TestPageLoadingPerfTest.test_run_with_bad_output):
3458         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3459         (PerfTestsRunner._parse_args):
3460         (PerfTestsRunner._run_tests_set): Removed the code to create a driver and pause before running the test.
3461         (PerfTestsRunner._run_single_test): Removed "driver" argument.
3462         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3463         (run_test):
3464         (test_run_test_pause_before_testing): Removed.
3465
3466 2012-12-18  Alberto Garcia  <agarcia@igalia.com>
3467
3468         [GTK] Tests that time out are not considered as failures.
3469         https://bugs.webkit.org/show_bug.cgi?id=105318
3470
3471         Reviewed by Martin Robinson.
3472
3473         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3474         (RunGtkAPITests.commandComplete):
3475         Consider log lines that end with TIMEOUT as errors.
3476
3477         * Scripts/run-gtk-tests:
3478         (TestRunner.run_tests):
3479         Consider timeouts as failures when returning the number of failed
3480         tests.
3481
3482 2012-12-18  Pravin D  <pravin.d@samsung.com>
3483
3484         Unreviewed, adding secondary email.
3485
3486         * Scripts/webkitpy/common/config/committers.py:
3487
3488 2012-12-18  Pravin D  <pravin.d@samsung.com>
3489
3490         Unreviewed, promoting myself to committer's list.
3491
3492         * Scripts/webkitpy/common/config/committers.py:
3493
3494 2012-12-18  Thiago Marcos P. Santos  <thiago.santos@intel.com>
3495
3496         [EFL] ImageDiff does not build on WebKit2 only builds
3497         https://bugs.webkit.org/show_bug.cgi?id=105288
3498
3499         Reviewed by Kenneth Rohde Christiansen.
3500
3501         Moved ImageDiff to the efl/ folder inside Tools/ (so we don't pollute
3502         the folder with things which are EFL-specific.
3503
3504         ImageDiff will be built by default now regardless of WebKit API flavor
3505         you choose.
3506
3507         * CMakeLists.txt:
3508         * DumpRenderTree/efl/CMakeLists.txt:
3509         * efl/ImageDiff/CMakeLists.txt: Added.
3510         * efl/ImageDiff/ImageDiff.cpp: Renamed from Tools/DumpRenderTree/efl/ImageDiff.cpp.
3511
3512 2012-12-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3513
3514         [EFL][WK2] When creating new windows, use the opener's context
3515         https://bugs.webkit.org/show_bug.cgi?id=105283
3516
3517         Reviewed by Laszlo Gombos.
3518
3519         Use the context of the opener if exists.
3520
3521         * MiniBrowser/efl/main.c:
3522         (on_key_down):
3523         (on_window_create):
3524         (window_create):
3525         (elm_main):
3526
3527 2012-12-18  Thiago Marcos P. Santos  <thiago.santos@intel.com>
3528
3529         [EFL][WK2] Gardening of TestWebKitAPI tests
3530         https://bugs.webkit.org/show_bug.cgi?id=105268
3531
3532         Reviewed by Kenneth Rohde Christiansen.
3533
3534         Some tests were marked as failing but are passing and the newly added
3535         LayoutUnit should have it's own binary because it conflicts with the
3536         fixture used by KURL and is failing on the bots because of that.
3537
3538         * TestWebKitAPI/CMakeLists.txt:
3539         * TestWebKitAPI/PlatformEfl.cmake:
3540
3541 2012-12-18  Jochen Eisinger  <jochen@chromium.org>
3542
3543         [chromium] move webintent related methods to TestRunner library
3544         https://bugs.webkit.org/show_bug.cgi?id=105164
3545
3546         Reviewed by Darin Fisher.
3547
3548         Also deleted the unused deliveredIntentFailure and
3549         deliveredIntentResult methods.
3550
3551         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3552         (DRTTestRunner::DRTTestRunner):
3553         * DumpRenderTree/chromium/DRTTestRunner.h:
3554         (DRTTestRunner):
3555         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
3556         (WebKit):
3557         (WebTestRunner::WebTestDelegate::setCurrentWebIntentRequest):
3558         (WebTestRunner::WebTestDelegate::currentWebIntentRequest):
3559         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3560         (WebKit):
3561         (WebTestProxyBase):
3562         (WebTestRunner::WebTestProxy::registerIntentService):
3563         (WebTestRunner::WebTestProxy::dispatchIntent):
3564         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3565         (WebTestRunner::TestRunner::TestRunner):
3566         (WebTestRunner::TestRunner::sendWebIntentResponse):
3567         (WebTestRunner):
3568         (WebTestRunner::TestRunner::deliverWebIntent):
3569         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3570         (TestRunner):
3571         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3572         (WebTestRunner::WebTestProxyBase::postAccessibilityNotification):
3573         (WebTestRunner::WebTestProxyBase::registerIntentService):
3574         (WebTestRunner):
3575         (WebTestRunner::WebTestProxyBase::dispatchIntent):
3576         * DumpRenderTree/chromium/WebViewHost.cpp:
3577         (WebViewHost::setCurrentWebIntentRequest):
3578         (WebViewHost::currentWebIntentRequest):
3579         * DumpRenderTree/chromium/WebViewHost.h:
3580         (WebKit):
3581         (WebViewHost):
3582
3583 2012-12-18  Jochen Eisinger  <jochen@chromium.org>
3584
3585         [chromium] move editing callback dumping to the WebTestProxy
3586         https://bugs.webkit.org/show_bug.cgi?id=105013
3587
3588         Reviewed by Darin Fisher.
3589
3590         To decide whether or not to dump the editing callbacks, the WebTestProxy
3591         needs to query the TestRunner. For this purpose, I introduce a
3592         WebTestRunner class that just exposes the shouldDumpEditingCallbacks
3593         method. In contrast to e.g. WebEventSender, the WebTestRunner is just
3594         an interface, and it is not owned by the WebTestInterfaces, but the
3595         embedder of the TestRunner library must provide it. This will change
3596         once all TestRunner methods are in the library.
3597
3598         * DumpRenderTree/DumpRenderTree.gypi:
3599         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3600         (DRTTestRunner::DRTTestRunner):
3601         (DRTTestRunner::reset):
3602         * DumpRenderTree/chromium/DRTTestRunner.h:
3603         (DRTTestRunner):
3604         (DRTTestRunner::taskList):
3605         (DRTTestRunner::WorkQueue::taskList):
3606         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
3607         (WebTestRunner):
3608         (WebTestInterfaces):
3609         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3610         (WebKit):
3611         (WebTestRunner):
3612         (WebTestProxyBase):
3613         (WebTestRunner::WebTestProxy::shouldBeginEditing):
3614         (WebTestRunner::WebTestProxy::shouldEndEditing):
3615         (WebTestRunner::WebTestProxy::shouldInsertNode):
3616         (WebTestRunner::WebTestProxy::shouldInsertText):
3617         (WebTestRunner::WebTestProxy::shouldChangeSelectedRange):
3618         (WebTestRunner::WebTestProxy::shouldDeleteRange):
3619         (WebTestRunner::WebTestProxy::shouldApplyStyle):
3620         (WebTestRunner::WebTestProxy::didBeginEditing):
3621         (WebTestRunner::WebTestProxy::didChangeSelection):
3622         (WebTestRunner::WebTestProxy::didChangeContents):
3623         (WebTestRunner::WebTestProxy::didEndEditing):
3624         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h.
3625         (WebTestRunner):
3626         (WebTestRunner::WebTestRunner::shouldDumpEditingCallbacks):