e4a79899d899586708cbb2acc9bede8c7854dc64
[WebKit-https.git] / Tools / ChangeLog
1 2017-08-23  Jonathan Bedard  <jbedard@apple.com>
2
3         Access expectations path through apple_additions
4         https://bugs.webkit.org/show_bug.cgi?id=174800
5         <rdar://problem/33498899>
6
7         Reviewed by Alexey Proskuryakov.
8
9         When external test expectations are imported through additional-platform-directory, they will
10         over-write any WebKit expectations. Access some expectations from apple_additions to correct
11         these precedence issues.
12
13         * Scripts/webkitpy/port/ios.py:
14         (IOSPort._apple_additions_path): Convert test expectation directory to a path
15         coming from apple_additions.
16         (IOSPort.default_baseline_search_path): Alternate between WebKit path and apple_additions
17         path for layout test expectations.
18         * Scripts/webkitpy/port/ios_device_unittest.py:
19         (IOSDeviceTest.test_layout_test_searchpath_with_apple_additions): Added to test layout-test search paths.
20         * Scripts/webkitpy/port/ios_simulator_unittest.py:
21         (IOSSimulatorTest.test_layout_test_searchpath_with_apple_additions): Added to test layout-test search paths.
22         * Scripts/webkitpy/port/mac.py:
23         (MacPort._apple_additions_path): Convert test expectation directory to a path
24         coming from apple_additions.
25         (MacPort.default_baseline_search_path): Alternate between WebKit path and apple_additions
26         path for layout test expectations.
27         * Scripts/webkitpy/port/mac_unittest.py:
28         (MacTest.test_layout_test_searchpath_with_apple_additions): Added to test layout-test search paths.
29         * Scripts/webkitpy/port/port_testcase.py:
30         (bind_mock_apple_additions): Added to create mock apple_additions for a block.
31         (bind_mock_apple_additions.MockAppleAdditions): Contains apple_addition stubs for testing.
32         * Scripts/webkitpy/port/win.py:
33         (WinPort.default_baseline_search_path): Include apple_additions test expectation for Windows.
34
35 2017-08-22  Zan Dobersek  <zdobersek@igalia.com>
36
37         Unreviewed. The WPE port should build TestWebKitAPI with the same
38         compiler flags as the GTK+ port, disabling a few flags that are
39         sprouting a lot of warning output.
40
41         * TestWebKitAPI/PlatformWPE.cmake:
42
43 2017-08-20  Wenson Hsieh  <wenson_hsieh@apple.com>
44
45         [iOS WK2] WKWebView schedules nonstop layout after pressing cmb+b,i,u inside a contenteditable div
46         https://bugs.webkit.org/show_bug.cgi?id=175116
47         <rdar://problem/28279301>
48
49         Reviewed by Darin Adler and Ryosuke Niwa.
50
51         Introduces new testing infrastructure and API tests to test EditorState updates in the UI process. The new
52         EditorStateTests run on both iOS and Mac.
53
54         * TestWebKitAPI/EditingTestHarness.h: Added.
55         * TestWebKitAPI/EditingTestHarness.mm: Added.
56
57         EditingTestHarness is a helper object that API tests may use to apply editing commands and store EditorState
58         history. This test harness adds sugaring around various editing commands, and simplifies the process of checking
59         the state of the latest observed EditorState.
60
61         (-[EditingTestHarness initWithWebView:]):
62         (-[EditingTestHarness dealloc]):
63         (-[EditingTestHarness webView]):
64         (-[EditingTestHarness latestEditorState]):
65         (-[EditingTestHarness editorStateHistory]):
66         (-[EditingTestHarness insertText:andExpectEditorStateWith:]):
67         (-[EditingTestHarness insertHTML:andExpectEditorStateWith:]):
68         (-[EditingTestHarness selectAllAndExpectEditorStateWith:]):
69         (-[EditingTestHarness moveBackwardAndExpectEditorStateWith:]):
70         (-[EditingTestHarness moveWordBackwardAndExpectEditorStateWith:]):
71         (-[EditingTestHarness toggleBold]):
72         (-[EditingTestHarness toggleItalic]):
73         (-[EditingTestHarness toggleUnderline]):
74         (-[EditingTestHarness setForegroundColor:]):
75         (-[EditingTestHarness alignJustifiedAndExpectEditorStateWith:]):
76         (-[EditingTestHarness alignLeftAndExpectEditorStateWith:]):
77         (-[EditingTestHarness alignCenterAndExpectEditorStateWith:]):
78         (-[EditingTestHarness alignRightAndExpectEditorStateWith:]):
79         (-[EditingTestHarness insertParagraphAndExpectEditorStateWith:]):
80         (-[EditingTestHarness deleteBackwardAndExpectEditorStateWith:]):
81         (-[EditingTestHarness _execCommand:argument:expectEntries:]):
82
83         Dispatches an editing command to the web process, and blocks until a response is received. If an expected
84         entries dictionary is given, this will additionally verify that the latest EditorState contains all the expected
85         keys and values.
86
87         (-[EditingTestHarness latestEditorStateContains:]):
88         (-[EditingTestHarness _webView:editorStateDidChange:]):
89         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
90         * TestWebKitAPI/Tests/WebKit2Cocoa/EditorStateTests.mm: Added.
91         (TestWebKitAPI::setUpEditorStateTestHarness):
92         (TestWebKitAPI::TEST):
93         * TestWebKitAPI/Tests/WebKit2Cocoa/editor-state-test-harness.html: Added.
94
95 2017-08-22  Wenson Hsieh  <wenson_hsieh@apple.com>
96
97         [WK2] EditorState updates should be rolled into the layer update lifecycle when possible
98         https://bugs.webkit.org/show_bug.cgi?id=175370
99         <rdar://problem/33799806>
100
101         Reviewed by Ryosuke Niwa.
102
103         Tweaks API tests that involve editing to wait for a presentation update before checking against UI process-side
104         information sent via EditorState updates. This allows any EditorState update scheduled by the test to propagate
105         to the UI process.
106
107         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm:
108         (-[CandidateTestWebView typeString:inputMessage:]):
109         (+[CandidateTestWebView setUpWithFrame:testPage:]):
110         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewTextInput.mm:
111         * TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm:
112         (TestWebKitAPI::AcceptsFirstMouse::runTest):
113         * TestWebKitAPI/Tests/mac/WKWebViewMacEditingTests.mm:
114         * TestWebKitAPI/cocoa/TestWKWebView.h:
115         * TestWebKitAPI/cocoa/TestWKWebView.mm:
116         (-[TestWKWebView waitForNextPresentationUpdate]):
117
118         Add a new helper method to spin until the next presentation update.
119
120         * TestWebKitAPI/mac/WebKitAgnosticTest.h:
121         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
122         (TestWebKitAPI::WebKitAgnosticTest::waitForNextPresentationUpdate):
123
124 2017-08-22  Alex Christensen  <achristensen@webkit.org>
125
126         Add UIDelegatePrivate SPI corresponding to WKPageUIClient.showPage
127         https://bugs.webkit.org/show_bug.cgi?id=175797
128         <rdar://problem/29270035>
129
130         Reviewed by Geoffrey Garen.
131
132         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
133         * TestWebKitAPI/Tests/WebKit2Cocoa/UIDelegate.mm: Added.
134         (-[UITestDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
135         (-[UITestDelegate _showPage:]):
136         (-[UITestDelegate webView:startURLSchemeTask:]):
137         (-[UITestDelegate webView:stopURLSchemeTask:]):
138         (TEST):
139
140 2017-08-22  Devin Rousso  <webkit@devinrousso.com>
141
142         Unreviewed, change my IRC nick.
143
144         * Scripts/webkitpy/common/config/contributors.json:
145
146 2017-08-22  Matt Lewis  <jlewis3@apple.com>
147
148         Unreviewed, rolling out r221026.
149
150         This caused a consistent API failure on iOS Simulator.
151
152         Reverted changeset:
153
154         "Add UIDelegatePrivate SPI corresponding to
155         WKPageUIClient.showPage"
156         https://bugs.webkit.org/show_bug.cgi?id=175797
157         http://trac.webkit.org/changeset/221026
158
159 2017-08-22  Alex Christensen  <achristensen@webkit.org>
160
161         Add UIDelegatePrivate SPI corresponding to WKPageUIClient.showPage
162         https://bugs.webkit.org/show_bug.cgi?id=175797
163         <rdar://problem/29270035>
164
165         Reviewed by Geoffrey Garen.
166
167         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
168         * TestWebKitAPI/Tests/WebKit2Cocoa/UIDelegate.mm: Added.
169         (-[UITestDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
170         (-[UITestDelegate _showPage:]):
171         (-[UITestDelegate webView:startURLSchemeTask:]):
172         (-[UITestDelegate webView:stopURLSchemeTask:]):
173         (TEST):
174
175 2017-08-22  Jonathan Bedard  <jbedard@apple.com>
176
177         Fix leak-checking for iOS Simulators
178         https://bugs.webkit.org/show_bug.cgi?id=175735
179
180         Reviewed by David Kilzer.
181
182         Follow-up fix to r220942. _proc may be undefined.
183
184         * Scripts/webkitpy/port/server_process.py:
185         (ServerProcess._wait_for_stop): Handle case where _proc is undefined.
186
187 2017-08-22  Carlos Alberto Lopez Perez  <clopez@igalia.com>
188
189         [GTK][WPE] install-dependencies should install the required gstreamer packages needed for production builds.
190         https://bugs.webkit.org/show_bug.cgi?id=175822
191
192         Reviewed by Xabier Rodriguez-Calvar.
193
194         * gtk/install-dependencies: Add the bad plugins to the list.
195         * wpe/install-dependencies: Add all the gst related packages (copied from GTK listing).
196
197 2017-08-21  Myles C. Maxfield  <mmaxfield@apple.com>
198
199         DataInteractionTests.ExternalSourceAttributedStringToContentEditable hits a debug assertion
200         https://bugs.webkit.org/show_bug.cgi?id=175787
201         <rdar://problem/33996612>
202
203         Reviewed by Wenson Hsieh.
204
205         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
206         (TestWebKitAPI::TEST):
207
208 2017-08-21  Myles C. Maxfield  <mmaxfield@apple.com>
209
210         Typo in "webkit-patch land"
211         https://bugs.webkit.org/show_bug.cgi?id=175788
212
213         Reviewed by Tim Horton.
214
215         * Scripts/webkitpy/tool/steps/commit.py:
216         (Commit._commit_warning):
217
218 2017-08-20  Sam Weinig  <sam@webkit.org>
219
220         StringView could use a function to strip leading/trailing characters without allocation
221         https://bugs.webkit.org/show_bug.cgi?id=175757
222
223         Reviewed by Darin Adler.
224
225         * TestWebKitAPI/Tests/WTF/StringView.cpp:
226         Add tests for StringView::stripLeadingAndTrailingMatchedCharacters().
227
228 2017-08-21  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
229
230         [PAL] Move spi/mac directory into PAL
231         https://bugs.webkit.org/show_bug.cgi?id=175649
232
233         Reviewed by Myles C. Maxfield.
234
235         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
236
237 2017-08-21  Per Arne Vollan  <pvollan@apple.com>
238
239         [Win] DRT should only allow any https certificate for localhost.
240         https://bugs.webkit.org/show_bug.cgi?id=175147
241
242         Reviewed by Brent Fulgham.
243
244         Add check to make sure only localhost requests allow any https certificate.
245
246         * DumpRenderTree/win/DumpRenderTree.cpp:
247         (runTest):
248
249 2017-08-21  Eric Carlson  <eric.carlson@apple.com>
250
251         Add WTFLogChannel level to allow runtime log filtering
252         https://bugs.webkit.org/show_bug.cgi?id=175731
253         <rdar://problem/33967234>
254
255         Unreviewed build fix.
256
257         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
258         (TestWebKitAPI::LoggingTest::output): Disable testing output by default because it 
259         fails on some of the bots.
260
261 2017-08-21  Eric Carlson  <eric.carlson@apple.com>
262
263         Add WTFLogChannel level to allow runtime log filtering
264         https://bugs.webkit.org/show_bug.cgi?id=175731
265         <rdar://problem/33967234>
266
267         Reviewed by Jer Noble.
268
269         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
270         * TestWebKitAPI/Tests/WebCore/Logging.cpp: Added.
271         (TestWebKitAPI::LoggingTest::output):
272         (TestWebKitAPI::TEST_F):
273
274 2017-08-19  Wenson Hsieh  <wenson_hsieh@apple.com>
275
276         [iOS WK2] Add a version of DataInteractionTests.ExternalSourceAttributedStringToContentEditable that doesn't hit a debug assertion
277         https://bugs.webkit.org/show_bug.cgi?id=175509
278         <rdar://problem/33728169>
279
280         Reviewed by Ryosuke Niwa.
281
282         Removes ExternalSourceAttributedStringToContentEditable and adds
283         ExternalSourceColoredAttributedStringToContentEditable, which tests dropping an attributed string with colored
284         text instead of a bold attributed string of system font. Due to a recent change in behavior in UIKit, the
285         original test (which this patch renames to ExternalSourceBoldSystemAttributedStringToContentEditable) hits a
286         debug assertion when dropping text of system bold font. Since the original intent of this test was to verify
287         that the attributed string UTI can be accepted in richly contenteditable areas, it suffices to check that some
288         other style attribute, such as color, carries over from the NSAttributedString to the DOM.
289
290         Also marks ExternalSourceBoldSystemAttributedStringToContentEditable as disabled for the time being.
291
292         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
293         (TestWebKitAPI::TEST):
294
295 2017-08-18  Ryan Haddad  <ryanhaddad@apple.com>
296
297         Unreviewed, rolling out r220938.
298
299         The API tests added with this change are failing.
300
301         Reverted changeset:
302
303         "Add WTFLogChannel level to allow runtime log filtering"
304         https://bugs.webkit.org/show_bug.cgi?id=175731
305         http://trac.webkit.org/changeset/220938
306
307 2017-08-18  Devin Rousso  <webkit@devinrousso.com>
308
309         Unreviewed, change my email.
310
311         * Scripts/webkitpy/common/config/contributors.json:
312
313 2017-08-18  Jonathan Bedard  <jbedard@apple.com>
314
315         Fix leak-checking for iOS Simulators
316         https://bugs.webkit.org/show_bug.cgi?id=175735
317
318         Reviewed by Darin Adler.
319
320         If the leak checking currently occurs in ServerProcess, we can’t check leaks on an iOS
321         Simulator (or device) because the process will have already been killed by the time we
322         check for leaks. Duplicate leak-checking code and share code waiting on a process to stop.
323
324         * Scripts/webkitpy/port/server_process.py:
325         (ServerProcess.stop): Move code waiting for the process to close to _wait_for_stop(...).
326         (ServerProcess._wait_for_stop): Share code shutting down a process between ServerProcess
327         and SimulatorProcess.
328         * Scripts/webkitpy/port/simulator_process.py:
329         (SimulatorProcess.stop): Before closing the process, check for leaks.
330
331 2017-08-18  Eric Carlson  <eric.carlson@apple.com>
332
333         Add WTFLogChannel level to allow runtime log filtering
334         https://bugs.webkit.org/show_bug.cgi?id=175731
335         <rdar://problem/33967234>
336
337         Reviewed by Jer Noble.
338
339         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
340         * TestWebKitAPI/Tests/WebCore/Logging.cpp: Added.
341         (TestWebKitAPI::LoggingTest::output):
342         (TestWebKitAPI::TEST_F):
343
344 2017-08-18  Alexey Proskuryakov  <ap@apple.com>
345
346         Add Dean Johnson to contributors.json for Bugzilla autocomplete.
347
348         * Scripts/webkitpy/common/config/contributors.json:
349
350 2017-08-18  Ross Kirsling  <ross.kirsling@sony.com>
351
352         [Tools] Add script to download a GitHub release
353         https://bugs.webkit.org/show_bug.cgi?id=175279
354
355         Reviewed by Brent Fulgham.
356
357         * Scripts/download-latest-github-release.py: Added.
358
359 2017-08-18  Commit Queue  <commit-queue@webkit.org>
360
361         Unreviewed, rolling out r220854.
362         https://bugs.webkit.org/show_bug.cgi?id=175716
363
364         I'm not sure we really need this (Requested by KaL on
365         #webkit).
366
367         Reverted changeset:
368
369         "[GTK][WPE] Add NTLM authentication enabled API"
370         https://bugs.webkit.org/show_bug.cgi?id=122952
371         http://trac.webkit.org/changeset/220854
372
373 2017-08-17  Michael Catanzaro  <mcatanzaro@igalia.com>
374
375         [GTK] Make TestContextMenu work on Fedora
376         https://bugs.webkit.org/show_bug.cgi?id=175708
377
378         Reviewed by Carlos Garcia Campos.
379
380         TestContextMenu has been broken for as long as I remember, but not on the bots, only for me
381         and my student last summer who was trying to work on a context menu API. It's trying to load
382         an MPEG-2 video file and confirm that right-clicking on it shows media element context menu
383         entries. Doesn't work on Fedora. Dunno why, since Fedora actually can play MPEG-2, but I
384         don't care to investigate. Let's switch it to WebM so I can move on.
385
386         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
387         (prepareContextMenuTestView):
388         * TestWebKitAPI/Tests/WebKitGLib/resources/silence.mpg: Removed.
389         * TestWebKitAPI/Tests/WebKitGLib/resources/silence.webm: Added.
390
391 2017-08-17  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
392
393         check-webkit-style shouldn't check spacing in #elif preprocessor lines
394         https://bugs.webkit.org/show_bug.cgi?id=175652
395
396         Reviewed by Alex Christensen.
397
398         * Scripts/webkitpy/style/checkers/cpp.py:
399         (check_spacing):
400         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
401         (CppStyleTest.test_spacing_for_binary_ops):
402
403 2017-08-17  Wenson Hsieh  <wenson_hsieh@apple.com>
404
405         Fix the build on other platforms after r220865
406         https://bugs.webkit.org/show_bug.cgi?id=175683
407
408         Reviewed by Tim Horton.
409
410         Check __IPHONE_OS_VERSION_MAX_ALLOWED instead of __IPHONE_OS_VERSION_MIN_REQUIRED in an SPI header. SPI
411         availability is determined by SDK version rather than deployment version.
412
413         * TestWebKitAPI/ios/UIKitSPI.h:
414
415 2017-08-17  Andreas Kling  <akling@apple.com>
416
417         Disable CSS regions at compile time
418         https://bugs.webkit.org/show_bug.cgi?id=175630
419
420         Reviewed by Antti Koivisto.
421
422         * Scripts/webkitperl/FeatureList.pm:
423         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
424
425 2017-08-17  Wenson Hsieh  <wenson_hsieh@apple.com>
426
427         Unreviewed, try to fix the internal iOS 10 build after r220865.
428
429         * TestWebKitAPI/ios/UIKitSPI.h:
430
431         On the iOS 10 SDK, UIApplication_Private.h cannot be imported in the simulator. Simply fall back to using the
432         extern declaration when building for pre-iOS 11; once the bots stop building for iOS 10, we can safely remove
433         this compiler guard.
434
435 2017-08-17  Wenson Hsieh  <wenson_hsieh@apple.com>
436
437         [iOS] Respect type fidelities when copying image elements to the pasteboard
438         https://bugs.webkit.org/show_bug.cgi?id=175638
439         <rdar://problem/26556043>
440
441         Reviewed by Ryosuke Niwa.
442
443         Add API tests that simulate copying an image element using the action sheet, and verifying that the pasteboard
444         contains UTIs in order of fidelity (image type before URL). Also pulls out UIKit SPI (UIApplicationInitialize)
445         used in UIPasteboardTests and ActionSheetTests into a common UIKitSPI header.
446
447         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
448         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
449         (-[ActionSheetObserver _webView:actionsForElement:defaultActions:]):
450         (TestWebKitAPI::TEST):
451         (TestWebKitAPI::presentActionSheetAndChooseAction):
452         (-[ActionSheetObserver waitForActionSheetAfterBlock:]): Deleted.
453         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
454         (checkEstimatedSize):
455         (checkSuggestedNameAndEstimatedSize):
456
457         Replace -estimatedDisplayedSize with its non-deprecated counterpart, -preferredPresentationSize.
458
459         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
460         (TestWebKitAPI::TEST):
461         * TestWebKitAPI/ios/DataInteractionSimulator.h:
462         * TestWebKitAPI/ios/UIKitSPI.h: Added.
463
464 2017-08-17  Jonathan Bedard  <jbedard@apple.com>
465
466         Recursively create resource load statistics folder for testing
467         https://bugs.webkit.org/show_bug.cgi?id=175676
468
469         Reviewed by Brady Eidson.
470
471         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
472         (WTR::TestController::cocoaPlatformInitialize): Recursively create resourceLoadStatisticsFolder.
473
474 2017-08-17  Carlos Garcia Campos  <cgarcia@igalia.com>
475
476         [GTK][WPE] Add NTLM authentication enabled API
477         https://bugs.webkit.org/show_bug.cgi?id=122952
478
479         Reviewed by Michael Catanzaro.
480
481         Add a test case to check we can enable/disable NTLM.
482
483         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
484         (testWebViewAuthenticationNTLM):
485         (beforeAll):
486
487 2017-08-16  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
488
489         [PAL] Move spi/ios and spi/win directories into PAL
490         https://bugs.webkit.org/show_bug.cgi?id=175171
491
492         Reviewed by Antti Koivisto.
493
494         * DumpRenderTree/mac/EventSendingController.mm:
495
496 2017-08-16  Andy Estes  <aestes@apple.com>
497
498         [Payment Request] Add an ENABLE flag and an experimental feature preference
499         https://bugs.webkit.org/show_bug.cgi?id=175622
500
501         Reviewed by Tim Horton.
502
503         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
504         * WebKitTestRunner/TestController.cpp:
505         (WTR::TestController::resetPreferencesToConsistentValues):
506
507 2017-08-15  Aakash Jain  <aakash_jain@apple.com>
508
509         undefined URL in PopoverTracker for failed step
510         https://bugs.webkit.org/show_bug.cgi?id=175593
511         <rdar://problem/33898769>
512
513         Reviewed by Daniel Bates.
514
515         This fix is a workaround for Buildbot 0.9 bug <https://github.com/buildbot/buildbot/issues/3529> where it
516         does not provide a URL to stdio for a build step. Buildbot 0.8 always included a URL to the stdio of the step.
517
518         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
519         (BuildbotIteration.prototype._parseData): Pass the URL while instantiating BuildbotTestResults.
520         (BuildbotIteration.prototype._urlForStep): Method to get the URL for a step.
521         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
522         (BuildbotTestResults): Accept URL in constructor.
523
524 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
525
526         Remove Proximity Events and related code
527         https://bugs.webkit.org/show_bug.cgi?id=175545
528
529         Reviewed by Daniel Bates.
530
531         No platform enables Proximity Events, so remove code inside ENABLE(PROXIMITY_EVENTS)
532         and other related code.
533
534         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
535
536 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
537
538         Remove ENABLE(REQUEST_AUTOCOMPLETE) code, which was disabled everywhere
539         https://bugs.webkit.org/show_bug.cgi?id=175504
540
541         Reviewed by Sam Weinig.
542
543         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
544
545 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
546
547         Remove ENABLE_VIEW_MODE_CSS_MEDIA and related code
548         https://bugs.webkit.org/show_bug.cgi?id=175557
549
550         Reviewed by Jon Lee.
551         
552         No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.
553
554         * DumpRenderTree/TestRunner.cpp:
555         (TestRunner::staticFunctions):
556         (setViewModeMediaFeatureCallback): Deleted.
557         * DumpRenderTree/TestRunner.h:
558         * DumpRenderTree/mac/TestRunnerMac.mm:
559         (TestRunner::setViewModeMediaFeature): Deleted.
560         * DumpRenderTree/win/TestRunnerWin.cpp:
561         (TestRunner::setViewModeMediaFeature): Deleted.
562         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
563
564 2017-08-14  Andy Estes  <aestes@apple.com>
565
566         REGRESSION (r220456): Crash in PreviewLoader::shouldCreateForMIMEType() when a ResourceResponse has a null MIME type
567         https://bugs.webkit.org/show_bug.cgi?id=175548
568         <rdar://problem/33866206>
569
570         Reviewed by Brady Eidson.
571
572         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
573         * TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp: Added.
574         (TestWebKitAPI::TEST): Added an API test for PreviewLoader::shouldCreateForMIMEType().
575
576 2017-08-14  Youenn Fablet  <youenn@apple.com>
577
578         WPT server should be able to do logging even if its output folder is not created at launch time
579         https://bugs.webkit.org/show_bug.cgi?id=175543
580
581         Reviewed by Alexey Proskuryakov.
582
583         Removing no longer used stdout/stderr member variables.
584         Creating if needed the output folder so that we can create WPT server output log folder at WPT server launch time.
585
586         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
587         (WebPlatformTestServer.__init__):
588         (WebPlatformTestServer._prepare_config):
589         (WebPlatformTestServer._spawn_process):
590         (WebPlatformTestServer._stop_running_server):
591
592 2017-08-14  Daniel Bates  <dabates@apple.com>
593
594         webkit-patch: Passing --no-review should submit patch to EWS by default
595         https://bugs.webkit.org/show_bug.cgi?id=148899
596
597         Reviewed by David Kilzer.
598
599         Make "webkit-patch upload --no-review" and "webkit-patch post-commits --no-review" submit
600         the patch(es) for EWS analysis by default. Add a new optional command line argument, --no-ews,
601         to these commands to not submit a non-reviewed patch(es) for EWS analysis.
602
603         Frequently I want to post a draft of a patch without review to have the EWS bots process
604         it to catch build and test breakage before I clean it up and post it for formal review.
605         Currently this requires using "webkit-patch upload --no-review --open-bug" to upload the
606         patch and open the bug in Safari so that I can click the Submit for EWS analysis button.
607         We should teach "webkit-patch upload" and "webkit-patch post-commits" how to do this.
608
609         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
610         (Bugzilla._parse_attachment_id_from_add_patch_to_bug_response): Add helper function to
611         parse the attachment id from the response page after adding an attachment to the bug.
612         (Bugzilla.add_patch_to_bug): Modified to parse and return the attachment id from the
613         HTTP response after uploading the patch.
614         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
615         (MockBugzilla.add_patch_to_bug): Return a dummy attachment id for testing purposes.
616         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
617         (test__parse_attachment_id_from_add_patch_to_bug_response): Added.
618         * Scripts/webkitpy/tool/commands/upload.py:
619         (Upload): Add step SubmitToEWS to the list of steps when uploading a patch. 
620         (PostCommits.__init__): Add --no-ews option to the list of applicable option flags for
621         this command.
622         (PostCommits.execute): Submit the patch to EWS, if applicable.
623         * Scripts/webkitpy/tool/commands/upload_unittest.py:
624         (test_upload): Set options.ews to False as the upload command expects this option
625         to be specified.
626         (test_upload_with_no_review_and_ews): Added.
627         * Scripts/webkitpy/tool/steps/__init__.py: Import module SubmitToEWS.
628         * Scripts/webkitpy/tool/steps/options.py:
629         (Options): Added command line option --no-ews (defaults: False - submit to EWS).
630         * Scripts/webkitpy/tool/steps/postdiff.py:
631         (PostDiff.options): Add --no-ews option to the list of applicable option flags for
632         this command.
633         (PostDiff.run): Submit the patch to EWS, if applicable.
634         * Scripts/webkitpy/tool/steps/submittoews.py: Added.
635         (SubmitToEWS):
636         (SubmitToEWS.options): Return an empty array as we this step does not have any command line options.
637         (SubmitToEWS.run): Submit the specified attachment ids for EWS analysis.
638
639 2017-08-14  Ryan Haddad  <ryanhaddad@apple.com>
640
641         Disable two flaky VideoControlsManager API tests.
642
643         Unreviewed test gardening.
644
645         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
646         (TestWebKitAPI::TEST):
647
648 2017-08-14  Tim Horton  <timothy_horton@apple.com>
649
650         Only create directory and sandbox extension handle for storage directories if they are set
651         https://bugs.webkit.org/show_bug.cgi?id=175522
652
653         Reviewed by Brady Eidson.
654
655         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
656         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDoesNotLogDuringInitialization.mm: Added.
657         (TEST):
658         Add a test that making a WKWebView with an ephemeral WKWebsiteDataStore
659         doesn't log anything to stderr.
660
661 2017-08-14  Jonathan Bedard  <jbedard@apple.com>
662
663         sub-categorize Sandbox violation logs
664         https://bugs.webkit.org/show_bug.cgi?id=175536
665         <rdar://problem/33834416>
666
667         Reviewed by David Kilzer.
668
669         * Scripts/webkitpy/common/system/crashlogs.py:
670         (CrashLogs._parse_darwin_crash_log): Add 'Sandbox-' to the log name if the log is
671         a Sandbox violation.
672         (CrashLogs._find_all_logs_darwin): Update comment.
673         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
674         (make_mock_sandbox_report_darwin): Create a Sandbox violation log for testing. 
675         (CrashLogsTest.create_crash_logs_darwin): Add Sandbox violation to list of crashes.
676         (CrashLogsTest.test_find_all_log_darwin): 8 logs in testing instead of 7.
677         (CrashLogsTest.test_duplicate_log_darwin): Check for Sandbox violation log.
678         * Scripts/webkitpy/port/darwin.py:
679         (DarwinPort._merge_crash_logs): Handle Sandbox violation case.
680
681 2017-08-14  Daniel Bates  <dabates@apple.com>
682
683         Add Automator service to copy permalink to Clipboard
684         https://bugs.webkit.org/show_bug.cgi?id=170978
685
686         Reviewed by Joseph Pecoraro.
687
688         It is helpful to reference using a hyperlink a particular line of code when having
689         a discussion on IRC or in a bug. You can get such a link by navigating to the file
690         in the Trac Browse Source viewer and selecting the line your are interested in.
691         I found myself doing this often enough that I wrote an Automator service to do it
692         for me.
693
694         This Automator service works with Xcode 8 and Xcode 9 beta 5 (9M202q) or later.
695
696         * CopyPermalink/Copy WebKit Permalink.workflow/Contents/Info.plist: Added.
697         * CopyPermalink/Copy WebKit Permalink.workflow/Contents/document.wflow: Added.
698         * CopyPermalink/README: Added.
699
700 2017-08-14  Chris Dumez  <cdumez@apple.com>
701
702         Address flakiness related to download tests
703         https://bugs.webkit.org/show_bug.cgi?id=175338
704         <rdar://problem/33865119>
705
706         Unreviewed, forgot in r220626 to reset m_shouldLogDownloadCallbacks to false
707         between tests.
708
709         * WebKitTestRunner/TestController.cpp:
710         (WTR::TestController::resetStateToConsistentValues):
711
712 2017-08-11  Ryosuke Niwa  <rniwa@webkit.org>
713
714         Replace DATA_TRANSFER_ITEMS by a runtime flag and add a stub implementation
715         https://bugs.webkit.org/show_bug.cgi?id=175474
716         <rdar://problem/33844628>
717
718         Reviewed by Wenson Hsieh.
719
720         Enable dataTransfer.items by default in DumpRenderTree and WebKitTestRunner for testing purposes.
721
722         * DumpRenderTree/mac/DumpRenderTree.mm:
723         (resetWebPreferencesToConsistentValues):
724         * WebKitTestRunner/TestController.cpp:
725         (WTR::TestController::resetPreferencesToConsistentValues):
726
727 2017-08-12  Chris Dumez  <cdumez@apple.com>
728
729         Address flakiness related to download tests
730         https://bugs.webkit.org/show_bug.cgi?id=175338
731
732         Reviewed by Ryosuke Niwa.
733
734         - Update WKTR so that the flag set by testRunner.waitUntilDownloadFinished()
735           is actually queried when a download completes. Previously, this would be
736           identical to a call to testRunner.waitUntilDone() because any download
737           completion would call testRunner.notifyDone().
738         - Disable logging of download callbacks by default and add a
739           testRunner.setShouldLogDownloadCallbacks(true) API to allow tests to
740           enable such logging.
741
742         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
743         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
744         (WTR::InjectedBundle::didReceiveMessageToPage):
745         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
746         (WTR::TestRunner::setShouldLogDownloadCallbacks):
747         * WebKitTestRunner/InjectedBundle/TestRunner.h:
748         * WebKitTestRunner/TestController.cpp:
749         (WTR::TestController::downloadDidStart):
750         (WTR::TestController::decideDestinationWithSuggestedFilename):
751         (WTR::TestController::downloadDidFinish):
752         (WTR::TestController::downloadDidFail):
753         (WTR::TestController::downloadDidCancel):
754         * WebKitTestRunner/TestController.h:
755         (WTR::TestController::setShouldLogDownloadCallbacks):
756         * WebKitTestRunner/TestInvocation.cpp:
757         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
758
759 2017-08-11  Jonathan Bedard  <jbedard@apple.com>
760
761         Create mock ITP data in testing to prevent grandfathering
762         https://bugs.webkit.org/show_bug.cgi?id=174720
763
764         Unreviewed follow-up fix for r220604.
765
766         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
767         (WTR::TestController::cocoaPlatformInitialize): Release resourceLogPlist.
768
769 2017-08-11  Jonathan Bedard  <jbedard@apple.com>
770
771         Create mock ITP data in testing to prevent grandfathering
772         https://bugs.webkit.org/show_bug.cgi?id=174720
773         <rdar://problem/33457779>
774
775         Reviewed by Brent Fulgham.
776
777         We don't need to be triggering grandfathering when each test runner starts. On Mac,
778         this may launch plugins which can cause layout tests to fail later if the test
779         runner does not shut-down before the plugins unload.
780
781         * WebKitTestRunner/TestController.h: Add declaration of cocoaPlatformInitialize.
782         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
783         (WTR::TestController::cocoaPlatformInitialize): Write the minimum data required to
784         prevent grandfathering from being triggered.
785         * WebKitTestRunner/ios/TestControllerIOS.mm:
786         (WTR::TestController::platformInitialize): Call cocoaPlatformInitialize.
787         * WebKitTestRunner/mac/TestControllerMac.mm:
788         (WTR::TestController::platformInitialize): Ditto.
789
790 2017-08-11  Sam Weinig  <sam@webkit.org>
791
792         WTF::Function does not allow for reference / non-default constructible return types
793         https://bugs.webkit.org/show_bug.cgi?id=175244
794         <rdar://problem/33801582>
795
796         Reviewed by Chris Dumez.
797
798         * TestWebKitAPI/Tests/WTF/Function.cpp:
799         (TestWebKitAPI::TEST):
800
801 2017-08-11  Carlos Garcia Campos  <cgarcia@igalia.com>
802
803         [Soup] Cannot access HTTPS sites using a HTTP proxy that requires authentication
804         https://bugs.webkit.org/show_bug.cgi?id=175378
805
806         Reviewed by Sergio Villar Senin.
807
808         Add two test cases to check proxy authentication.
809
810         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
811         (Tunnel::Tunnel):
812         (Tunnel::~Tunnel):
813         (Tunnel::connect):
814         (Tunnel::connected):
815         (serverCallback):
816         (ProxyAuthenticationTest::ProxyAuthenticationTest):
817         (ProxyAuthenticationTest::~ProxyAuthenticationTest):
818         (ProxyAuthenticationTest::proxyServerPortAsString):
819         (testWebViewAuthenticationProxy):
820         (testWebViewAuthenticationProxyHTTPS):
821         (beforeAll):
822
823 2017-08-11  Xabier Rodriguez Calvar  <calvaris@igalia.com>
824
825         [GStreamer][GTK][WPE] Unify GStreamer JHBuild moduleset for both GTK+ and WPE
826         https://bugs.webkit.org/show_bug.cgi?id=175428
827
828         Both ports share the GStreamer code as multimedia backend and till
829         not so long they were using different versions. Now they do use
830         the same versions and it does not make any sense anymore (and
831         neither had sense before) to have differences in the modulesets.
832
833         In this patch I created a GStreamer moduleset and referenced it
834         from both GTK+'s and WPE's. GStreamer patches were also moved there.
835
836         Reviewed by Žan Doberšek.
837
838         * gstreamer/jhbuild.modules: Added.
839         * gstreamer/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch.
840         * gstreamer/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch.
841         * gstreamer/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch.
842         * gstreamer/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch.
843         * gstreamer/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Renamed from Tools/gtk/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch.
844         * gstreamer/patches/openh264-configure.patch: Renamed from Tools/gtk/patches/openh264-configure.patch.
845         * gtk/jhbuild.modules:
846         * wpe/jhbuild.modules:
847         * wpe/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Removed.
848         * wpe/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Removed.
849         * wpe/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Removed.
850         * wpe/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Removed.
851         * wpe/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Removed.
852
853 2017-08-10  Don Olmstead  <don.olmstead@sony.com>
854
855         Unreviewed, adding Ross Kirsling to contributors.json
856
857         * Scripts/webkitpy/common/config/contributors.json:
858
859 2017-08-10  Yusuke Suzuki  <utatane.tea@gmail.com>
860
861         Unreviewed, attempt to fix build failure with VC2017
862
863         * TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:
864         (TEST):
865
866 2017-08-10  Yusuke Suzuki  <utatane.tea@gmail.com>
867
868         Unreviewed, suppress warnings on GCC
869
870         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
871         (TestWebKitAPI::CheckedArithmeticTester::run):
872
873 2017-08-10  Dan Bernstein  <mitz@apple.com>
874
875         [Xcode] With Xcode 9 developer beta, everything rebuilds when switching between command-line and IDE
876         https://bugs.webkit.org/show_bug.cgi?id=173223
877
878         Reviewed by Tim Horton.
879
880         The rebuilds were happening due to a difference in the compiler options that the IDE and
881         xcodebuild were specifying. Only the IDE was passing the -index-store-path option. To make
882         xcodebuild pass that option, too, set INDEX_ENABLE_DATA_STORE to YES and
883         INDEX_DATA_STORE_DIR to the Index Datastore path specified in Xcode Locations preferences >
884         Advanced when a Custom Absolute path is selected.
885
886         * Scripts/webkitdirs.pm:
887         (determineBaseProductDir):
888
889 2017-08-10  Yusuke Suzuki  <utatane.tea@gmail.com>
890
891         Run more WTF tests
892         https://bugs.webkit.org/show_bug.cgi?id=174970
893
894         Reviewed by Michael Catanzaro.
895
896         Some of WTF tests are not executed in non Apple ports while they are generic ones.
897         This patch adds these tests to non-Apple port TestWebKitAPI.
898         Currently, we do not add Signals.cpp since it depends on signal functionality.
899
900         * TestWebKitAPI/CMakeLists.txt:
901         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
902         * TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:
903         (isHigherPriority):
904         (TEST):
905         * TestWebKitAPI/Tests/WTF/Signals.cpp: Copied from Tools/TestWebKitAPI/Tests/WTF/ThreadMessages.cpp.
906         (TEST):
907         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
908         (TEST):
909
910 2017-08-10  obinna obike  <oobike@apple.com>
911
912         Remove obsolete link from webkit-queues status page
913         https://bugs.webkit.org/show_bug.cgi?id=175337
914
915         Reviewed by Aakash Jain.
916
917         * QueueStatusServer/templates/recentstatus.html:
918         Removed the link to the ews-watcher server.
919
920 2017-08-10  Brian Burg  <bburg@apple.com>
921
922         WKPreferences should conform to NSCopying
923         https://bugs.webkit.org/show_bug.cgi?id=175303
924         <rdar://problem/33764939>
925
926         Reviewed by Dan Bernstein.
927
928         Add unit test to make sure a WKPreference and its copy are
929         not aliased to each other or affect each other's properties.
930
931         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
932         * TestWebKitAPI/Tests/WebKit2Cocoa/Copying.mm: Added.
933         (TEST):
934
935 2017-08-10  Tim Horton  <timothy_horton@apple.com>
936
937         Remove some unused lambda captures so that WebKit builds with -Wunused-lambda-capture
938         https://bugs.webkit.org/show_bug.cgi?id=175436
939         <rdar://problem/33667497>
940
941         Reviewed by Simon Fraser.
942
943         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
944         (TestWebKitAPI::TEST_F):
945
946 2017-08-10  Lucas Forschler  <lforschler@apple.com>
947
948         Fix duplicated code in r220534.
949
950         Unreviewed cleanup.
951
952         * Scripts/bisect-builds:
953
954 2017-08-08  Jiewen Tan  <jiewen_tan@apple.com>
955
956         [WebCrypto] Enable SerializedCryptoKeyWrapTest in iOS
957         https://bugs.webkit.org/show_bug.cgi?id=175344
958         <rdar://problem/28507240>
959
960         Reviewed by Alexey Proskuryakov.
961
962         Add entitlements to TestWebKitAPI project for iOS. Then add Keychain Access entitlement to the project.
963         Finally enable the existing tests for iOS.
964
965         * TestWebKitAPI/Configurations/TestWebKitAPI-iOS.entitlements: Added.
966         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
967         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
968         * TestWebKitAPI/Tests/WebCore/cocoa/SerializedCryptoKeyWrap.mm:
969
970 2017-08-10  Lucas Forschler  <lforschler@apple.com>
971
972         Write a tool to bisect WebKit builds
973         https://bugs.webkit.org/show_bug.cgi?id=174596
974
975         Reviewed by Dean Johnson and Kocsen Chung.
976
977         * Scripts/bisect-builds: Added.
978         (bisect_builds): main bisection algorithm
979         (download_archive):download an archive from S3 using existing tools
980         (extract_archive):extract an archive using existing tools
981         (find_le):Find rightmost value less than or equal to x
982         (find_ge):Find leftmost item greater than or equal to x
983         (get_api_url):generate url for the rest api/database
984         (get_indices_from_revisions):convert revisions to list indexes for bisection
985         (get_sorted_revisions):retrieve sorted revision list
986         (get_s3_location_for_revision):calculate the S3 archive storage location
987         (parse_args):parse command line arguments
988         (pick_next_build):compute the next build to bisect
989         (prompt_did_reproduce):prompt user for direction for bisection
990         (set_webkit_output_dir):set the folder for bisected builds to avoid overwriting engineering build output
991         (test_archive):Platform specific logic to test downloaded archive
992         (minified_platforms):return a list of minified platforms in the database
993         (unminified_platforms):return a list of full platforms in the database
994         (is_supported_platform):check if platform is supported
995         (validate_options):validate command line options
996         (main):
997
998 2017-08-10  Lucas Forschler  <lforschler@apple.com>
999
1000         Remove bisect-builds script.
1001         https://bugs.webkit.org/show_bug.cgi?id=175433
1002         
1003         Reviewed by Aakash Jain.
1004
1005         * Scripts/bisect-builds: Removed.
1006
1007 2017-08-10  Michael Catanzaro  <mcatanzaro@igalia.com>
1008
1009         Remove ENABLE_GAMEPAD_DEPRECATED
1010         https://bugs.webkit.org/show_bug.cgi?id=175361
1011
1012         Reviewed by Carlos Garcia Campos.
1013
1014         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1015
1016 2017-08-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1017
1018         REGRESSION(r220515) [GTK][CMake] Build with ENABLE_GEOLOCATION fails on Debian Jessie
1019         https://bugs.webkit.org/show_bug.cgi?id=175426
1020
1021         Reviewed by Carlos Garcia Campos.
1022
1023         * gtk/install-dependencies: libgeoclue-dev packages not really needed on Debian/Ubuntu.
1024
1025 2017-08-10  Ms2ger  <Ms2ger@igalia.com>
1026
1027         Add Ms2ger as contributor.
1028         https://bugs.webkit.org/show_bug.cgi?id=175325
1029
1030         Reviewed by Carlos Alberto Lopez Perez.
1031
1032         * Scripts/webkitpy/common/config/contributors.json:
1033
1034 2017-08-09  Dewei Zhu  <dewei_zhu@apple.com>
1035
1036         Fix run-benchmark after r220483.
1037         https://bugs.webkit.org/show_bug.cgi?id=175415
1038         <rdar://problem/33803003>
1039
1040         Reviewed by Ryosuke Niwa.
1041
1042         Update run-benchmark script to adapt new Timeout implementation introduced in r220483.
1043
1044         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py:
1045         (WebServerBenchmarkRunner._run_one_test):
1046
1047 2017-08-09  Chris Dumez  <cdumez@apple.com>
1048
1049         Disable Beacon API on WK1 DRT and WK2 when not using NETWORK_SESSION
1050         https://bugs.webkit.org/show_bug.cgi?id=175401
1051
1052         Reviewed by Brady Eidson.
1053
1054         * DumpRenderTree/mac/DumpRenderTree.mm:
1055         (enableExperimentalFeatures):
1056
1057 2017-08-09  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
1058
1059         [PAL] Move spi/cocoa and spi/cg directories into PAL
1060         https://bugs.webkit.org/show_bug.cgi?id=175175
1061
1062         Reviewed by Myles C. Maxfield.
1063
1064         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
1065         * DumpRenderTree/mac/DumpRenderTree.mm:
1066         * TestWebKitAPI/Tests/WebKit2Cocoa/NSFileManagerExtras.mm:
1067         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1068
1069         * Scripts/webkitpy/style/checker.py:
1070         * Scripts/webkitpy/style/checker_unittest.py:
1071         (GlobalVariablesTest.test_path_rules_specifier):
1072
1073         Add path rules specifiers for PassKitSPI.h and DataDetectorsCoreSPI.h
1074
1075         * Scripts/webkitpy/style/checkers/cpp.py:
1076         (check_braces):
1077         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1078         (WebKitStyleTest.test_braces.CF_OPTIONS):
1079         (WebKitStyleTest.test_braces):
1080
1081         Prevent CF_OPTIONS() from being handled as funtion definition.
1082
1083 2017-08-09  Don Olmstead  <don.olmstead@sony.com>
1084
1085         [WTF] Move TextStream into WTF
1086         https://bugs.webkit.org/show_bug.cgi?id=175211
1087
1088         Reviewed by Myles C. Maxfield.
1089
1090         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
1091
1092 2017-08-09  Andy Estes  <aestes@apple.com>
1093
1094         Part 3 of: Rename DatabaseProcess to StorageProcess
1095         https://bugs.webkit.org/show_bug.cgi?id=175034
1096
1097         Reviewed by Brady Eidson.
1098
1099         * WebKitTestRunner/TestController.cpp:
1100         (WTR::TestController::databaseProcessName): Updated to return
1101         "com.apple.WebKit.Storage.Development" on macOS and iOS Simulator.
1102
1103 2017-08-09  Commit Queue  <commit-queue@webkit.org>
1104
1105         Unreviewed, rolling out r220466, r220477, and r220487.
1106         https://bugs.webkit.org/show_bug.cgi?id=175411
1107
1108         This change broke existing API tests and follow up fixes did
1109         not resolve all the issues. (Requested by ryanhaddad on
1110         #webkit).
1111
1112         Reverted changesets:
1113
1114         https://bugs.webkit.org/show_bug.cgi?id=175244
1115         http://trac.webkit.org/changeset/220466
1116
1117         "WTF::Function does not allow for reference / non-default
1118         constructible return types"
1119         https://bugs.webkit.org/show_bug.cgi?id=175244
1120         http://trac.webkit.org/changeset/220477
1121
1122         https://bugs.webkit.org/show_bug.cgi?id=175244
1123         http://trac.webkit.org/changeset/220487
1124
1125 2017-08-09  Sam Weinig  <sam@webkit.org>
1126
1127         Update for https://bugs.webkit.org/show_bug.cgi?id=175244.
1128
1129         Remove one addition of null Function test.
1130
1131 2017-08-09  Jonathan Bedard  <jbedard@apple.com>
1132
1133         Allow nested timeouts in webkitpy
1134         https://bugs.webkit.org/show_bug.cgi?id=175390
1135         <rdar://problem/33803003>
1136
1137         Reviewed by David Kilzer.
1138
1139         We need to be able to nest timeouts in webkitpy. In particular, we have a few cases where functions
1140         which use timeouts also call the executive. For on-device testing, we need to have timeouts inside
1141         the executive to detect and recover from any issues connecting with devices.
1142
1143         * Scripts/webkitpy/benchmark_runner/utils.py:
1144         (TimeoutError): Deleted.
1145         (timeout): Deleted.
1146         * Scripts/webkitpy/common/timeout_context.py: Added.
1147         (Timeout): A timeout context designed to be nested.
1148         (Timeout.TimeoutData): The data required to construct an alarm for a given timeout.
1149         (Timeout.TimeoutData.__init__):
1150         (Timeout.default_handler): Timeout handler used if none is specified.
1151         (Timeout.current): Access data about the most urgent timeout.
1152         (Timeout.__init__): Construct a Timeout object with seconds and an optional handler.
1153         (Timeout._bind_timeout_data_to_alarm): Given data about a timeout, initialize an alarm for that timeout.
1154         (Timeout.__enter__): Un-bind all alarms. Add data for this timeout to the ordered list and bind the most
1155         urgent timeout data.
1156         (Timeout.__exit__): Un-bind all alarms. Remove data for this timeout from the ordered list and bind the
1157         most urgent timeout data, if such data exists.
1158         * Scripts/webkitpy/common/timeout_context_unittest.py: Added.
1159         (TimeoutContextTests):
1160         (TimeoutContextTests.test_current_timeout): Test that accessing the nearest timeout works as expected.
1161         (TimeoutContextTests.test_invalid_timeout): Test a timeout of 0.
1162         (TimeoutContextTests.test_timeout_data): Confirm that timeouts are constructed correctly.
1163         (TimeoutContextTests.test_nested_inner_precedence): Check that a more urgent inner timeout takes precedence
1164         over a less urgent outer timeout.
1165         (TimeoutContextTests.test_nested_outer_precedence): Check that a more urgent outer timeout takes precedence
1166         over a less urgent inner timeout.
1167         (TimeoutContextTests.test_no_timeout): Test a block of code without a timeout.
1168         (TimeoutContextTests.test_basic_timeout): Test a block of code expected to timeout.
1169         (TimeoutContextTests.test_exception_constructor_timeout): Test a timeout where the handler is an exception.
1170         (TimeoutContextTests.test_nested_inner_timeout): Confirm that a more urgent inner timeout is triggered.
1171         (TimeoutContextTests.test_nested_outer_timeout): Confirm that a more urgent outer timeout is triggered.
1172         * Scripts/webkitpy/port/simulator_process.py:
1173         (SimulatorProcess._start): Use Timeout class.
1174         * Scripts/webkitpy/xcode/simulated_device.py:
1175         (SimulatedDevice.launch_app._log_debug_error): Use Timeout class.
1176         (SimulatedDevice.launch_app): Ditto.
1177         (SimulatedDevice.launch_app._install_timeout): Deleted.
1178         * Scripts/webkitpy/xcode/simulator.py:
1179         (Simulator.wait_until_device_is_booted):Use Timeout class.
1180         (Simulator.wait_until_device_is_in_state): Ditto.
1181
1182 2017-08-09  Wenson Hsieh  <wenson_hsieh@apple.com>
1183
1184         [iOS DnD] ENABLE_DRAG_SUPPORT should be turned off for iOS 10 and enabled by default
1185         https://bugs.webkit.org/show_bug.cgi?id=175392
1186         <rdar://problem/33783207>
1187
1188         Reviewed by Tim Horton and Megan Gardner.
1189
1190         Tweak FeatureDefines to enable drag and drop by default, and disable only on unsupported platforms (i.e. iOS 10).
1191
1192         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1193
1194 2017-08-09  Sam Weinig  <sam@webkit.org>
1195
1196         Update for https://bugs.webkit.org/show_bug.cgi?id=175244.
1197
1198         * TestWebKitAPI/Tests/WTF/Function.cpp:
1199         Remove tests of null Functions, as they are no longer supported.
1200
1201 2017-08-09  Daniel Bates  <dabates@apple.com>
1202
1203         REGRESSION (r219013): OAuth flows are broken when redirecting back to application after authentication
1204         https://bugs.webkit.org/show_bug.cgi?id=175247
1205         <rdar://problem/33679804>
1206
1207         Reviewed by Brady Eidson.
1208
1209         Add tests for redirects.
1210
1211         * TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm:
1212         (TEST):
1213         * TestWebKitAPI/cocoa/TestProtocol.mm:
1214         (createRedirectURL):
1215         (-[TestProtocol startLoading]):
1216
1217 2017-08-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1218
1219         Unreviewed, rolling out r220393.
1220
1221         This patch regresses the performance of WebPage::editorState.
1222
1223         Reverted changeset:
1224
1225         "[iOS WK2] WKWebView schedules nonstop layout after pressing
1226         cmb+b,i,u inside a contenteditable div"
1227         https://bugs.webkit.org/show_bug.cgi?id=175116
1228         http://trac.webkit.org/changeset/220393
1229
1230 2017-08-08  obinna obike  <oobike@apple.com>
1231
1232         Created Individual EWS Pages
1233         https://bugs.webkit.org/show_bug.cgi?id=174477
1234
1235         Reviewed by Aakash Jain.
1236
1237         Created individual pages for each EWS. Changed the link within each status bubble
1238         to go directly to the individual EWS page. Also added a link to original status page showing all EWSes.
1239
1240         * QueueStatusServer/handlers/patch.py:
1241         (Patch.get): Handles the case for individual ews queue as well as for all EWS queues.
1242         * QueueStatusServer/handlers/statusbubble.py:
1243         (StatusBubble._build_bubble): Updated url for specific EWS.
1244         * QueueStatusServer/main.py: Added a link to the individual ews in the routes dictionary.
1245         * QueueStatusServer/templates/patch.html: Added a link to go directly to the page with
1246         all ews queues.
1247         * QueueStatusServer/templates/statusbubble.html: If you click on a statusbubble it
1248         takes you directly to the individual ews page.
1249
1250 2017-08-08  Stephan Szabo  <stephan.szabo@sony.com>
1251
1252         Separate jsc stress test script writer from run-jsc-stress-tests
1253         https://bugs.webkit.org/show_bug.cgi?id=175216
1254
1255         Reviewed by Mark Lam.
1256
1257         * Scripts/run-jsc-stress-tests:
1258         * Scripts/webkitruby/jsc-stress-test-writer-default.rb: Added.
1259
1260 2017-08-08  Michael Catanzaro  <mcatanzaro@igalia.com>
1261
1262         Unreviewed, fix Ubuntu LTS build
1263         https://bugs.webkit.org/show_bug.cgi?id=174490
1264
1265         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1266
1267 2017-08-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1268
1269         [Mac WK2] WebViewImpl should hold a weak pointer to its WKWebView or WKView
1270         https://bugs.webkit.org/show_bug.cgi?id=175302
1271         <rdar://problem/33762116>
1272
1273         Reviewed by Tim Horton.
1274
1275         Adds a new unit test checking that delayed event processing in text input context does not cause unwanted behaviors.
1276         See WebKit ChangeLog for more details.
1277
1278         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1279         * TestWebKitAPI/Tests/TestWebKitAPI/mac/AppKitSPI.h: Renamed from Tools/TestWebKitAPI/Tests/TestWebKitAPI/mac/NSTextInputClientSPI.h.
1280         * TestWebKitAPI/Tests/mac/WKWebViewMacEditingTests.mm: Renamed from Tools/TestWebKitAPI/Tests/mac/WKWebViewSelectionTests.mm.
1281         (-[SlowTextInputContext handleEventByInputMethod:completionHandler:]):
1282         (-[SlowTextInputContext handleEvent:completionHandler:]):
1283         (-[SlowInputWebView inputContext]):
1284         (-[SlowInputWebView _web_superInputContext]):
1285         (TEST):
1286
1287 2017-08-08  John Wilander  <wilander@apple.com>
1288
1289         Resource Load Statistics: Clear web processes' state on history removal
1290         https://bugs.webkit.org/show_bug.cgi?id=175271
1291         <rdar://problem/33756560>
1292
1293         Reviewed by Chris Dumez.
1294
1295         Test infrastructure for asynchronous tests of website data
1296         removal for _WKWebsiteDataTypeResourceLoadStatistics.
1297
1298         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1299         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1300         (WTR::InjectedBundle::didReceiveMessageToPage):
1301         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1302         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
1303         (WTR::TestRunner::statisticsCallClearThroughWebsiteDataRemovalCallback):
1304         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1305         * WebKitTestRunner/TestController.cpp:
1306         (WTR::TestController::statisticsClearThroughWebsiteDataRemoval):
1307         * WebKitTestRunner/TestController.h:
1308         * WebKitTestRunner/TestInvocation.cpp:
1309         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1310         (WTR::TestInvocation::didClearStatisticsThroughWebsiteDataRemoval):
1311         * WebKitTestRunner/TestInvocation.h:
1312         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1313         (WTR::TestController::statisticsClearThroughWebsiteDataRemoval):
1314
1315 2017-08-08  Alicia Boya García  <aboya@igalia.com>
1316
1317         Add Alicia Boya García as contributor
1318         https://bugs.webkit.org/show_bug.cgi?id=175326
1319
1320         Reviewed by Michael Catanzaro.
1321
1322         * Scripts/webkitpy/common/config/contributors.json:
1323
1324 2017-08-08  Michael Catanzaro  <mcatanzaro@igalia.com>
1325
1326         [CMake] Properly test if compiler supports compiler flags
1327         https://bugs.webkit.org/show_bug.cgi?id=174490
1328
1329         Reviewed by Konstantin Tokarev.
1330
1331         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
1332         * MiniBrowser/gtk/CMakeLists.txt:
1333         * TestRunnerShared/Bindings/JSWrapper.cpp:
1334         (WTR::JSWrapper::initialize):
1335         * TestWebKitAPI/CMakeLists.txt:
1336         * TestWebKitAPI/PlatformGTK.cmake:
1337         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
1338         (TestWebKitAPI::CheckedArithmeticTester::run):
1339         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1340         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
1341         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1342         (formControlsAssociatedCallback):
1343         * TestWebKitAPI/glib/CMakeLists.txt:
1344         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1345         (Test::getResourcesDir):
1346         * WebKitTestRunner/CMakeLists.txt:
1347         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1348         (WTR::menuItemClickCallback):
1349         (WTR::staticConvertMenuItemToType):
1350         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1351         (WTR::TestRunner::setUseDashboardCompatibilityMode):
1352         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1353         (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
1354         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1355         (WTR::AccessibilityUIElement::helpText const):
1356         (WTR::AccessibilityUIElement::attributedStringForRange):
1357         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1358         (WTR::EventSenderProxy::updateTouchPoint):
1359         (WTR::EventSenderProxy::releaseTouchPoint):
1360
1361 2017-08-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1362
1363         [iOS WK2] WKWebView schedules nonstop layout after pressing cmb+b,i,u inside a contenteditable div
1364         https://bugs.webkit.org/show_bug.cgi?id=175116
1365         <rdar://problem/28279301>
1366
1367         Reviewed by Darin Adler and Ryosuke Niwa.
1368
1369         Introduces new testing infrastructure and API tests to test EditorState updates in the UI process. The new
1370         EditorStateTests run on both iOS and Mac.
1371
1372         * TestWebKitAPI/EditingTestHarness.h: Added.
1373         * TestWebKitAPI/EditingTestHarness.mm: Added.
1374
1375         EditingTestHarness is a helper object that API tests may use to apply editing commands and store EditorState
1376         history. This test harness adds sugaring around various editing commands, and simplifies the process of checking
1377         the state of the latest observed EditorState.
1378
1379         (-[EditingTestHarness initWithWebView:]):
1380         (-[EditingTestHarness dealloc]):
1381         (-[EditingTestHarness webView]):
1382         (-[EditingTestHarness latestEditorState]):
1383         (-[EditingTestHarness editorStateHistory]):
1384         (-[EditingTestHarness insertText:andExpectEditorStateWith:]):
1385         (-[EditingTestHarness insertHTML:andExpectEditorStateWith:]):
1386         (-[EditingTestHarness selectAllAndExpectEditorStateWith:]):
1387         (-[EditingTestHarness moveBackwardAndExpectEditorStateWith:]):
1388         (-[EditingTestHarness moveWordBackwardAndExpectEditorStateWith:]):
1389         (-[EditingTestHarness toggleBold]):
1390         (-[EditingTestHarness toggleItalic]):
1391         (-[EditingTestHarness toggleUnderline]):
1392         (-[EditingTestHarness setForegroundColor:]):
1393         (-[EditingTestHarness alignJustifiedAndExpectEditorStateWith:]):
1394         (-[EditingTestHarness alignLeftAndExpectEditorStateWith:]):
1395         (-[EditingTestHarness alignCenterAndExpectEditorStateWith:]):
1396         (-[EditingTestHarness alignRightAndExpectEditorStateWith:]):
1397         (-[EditingTestHarness insertParagraphAndExpectEditorStateWith:]):
1398         (-[EditingTestHarness deleteBackwardAndExpectEditorStateWith:]):
1399         (-[EditingTestHarness _execCommand:argument:expectEntries:]):
1400
1401         Dispatches an editing command to the web process, and blocks until a response is received. If an expected
1402         entries dictionary is given, this will additionally verify that the latest EditorState contains all the expected
1403         keys and values.
1404
1405         (-[EditingTestHarness latestEditorStateContains:]):
1406         (-[EditingTestHarness _webView:editorStateDidChange:]):
1407         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1408         * TestWebKitAPI/Tests/WebKit2Cocoa/EditorStateTests.mm: Added.
1409         (TestWebKitAPI::setUpEditorStateTestHarness):
1410         (TestWebKitAPI::TEST):
1411         * TestWebKitAPI/Tests/WebKit2Cocoa/editor-state-test-harness.html: Added.
1412
1413 2017-08-04  Brent Fulgham  <bfulgham@apple.com>
1414
1415         Prevent domain from being set to a TLD
1416         https://bugs.webkit.org/show_bug.cgi?id=175226
1417         <rdar://problem/11079948>
1418
1419         Reviewed by Chris Dumez.
1420
1421         Extend the public suffix tests to include cases used by the
1422         Public Domain 'Public Suffix List'.
1423
1424         * TestWebKitAPI/Tests/mac/PublicSuffix.cpp: 
1425         (TestWebKitAPI::TEST):
1426
1427 2017-08-07  Stephan Szabo  <stephan.szabo@sony.com>
1428
1429         [XCode] webkit-patch should run sort-Xcode-project-file
1430         https://bugs.webkit.org/show_bug.cgi?id=174036
1431         <rdar://problem/33732709>
1432
1433         Reviewed by Simon Fraser.
1434
1435         * Scripts/webkitpy/common/config/ports.py:
1436         * Scripts/webkitpy/tool/commands/download.py:
1437         * Scripts/webkitpy/tool/commands/download_unittest.py:
1438         * Scripts/webkitpy/tool/commands/upload.py:
1439         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1440         * Scripts/webkitpy/tool/steps/__init__.py:
1441         * Scripts/webkitpy/tool/steps/options.py:
1442         * Scripts/webkitpy/tool/steps/sortxcodeprojectfiles.py: Added.
1443
1444 2017-08-07  Devin Rousso  <drousso@apple.com>
1445
1446         Web Inspector: Preview Canvas path when viewing a recording
1447         https://bugs.webkit.org/show_bug.cgi?id=174967
1448
1449         Reviewed by Brian Burg.
1450
1451         * DumpRenderTree/TestOptions.h:
1452         * DumpRenderTree/TestOptions.mm:
1453         (TestOptions::TestOptions):
1454         * DumpRenderTree/mac/DumpRenderTree.mm:
1455         (setWebPreferencesForTestOptions):
1456         * WebKitTestRunner/TestController.cpp:
1457         (WTR::TestController::resetPreferencesToConsistentValues):
1458         (WTR::updateTestOptionsFromTestHeader):
1459         * WebKitTestRunner/TestOptions.h:
1460         (WTR::TestOptions::hasSameInitializationOptions const):
1461         Add plumbing for new InspectorAdditions runtime flag.
1462
1463 2017-08-07  obinna obike  <oobike@apple.com>
1464
1465         Sorted EWS Queues on Patch page
1466         https://bugs.webkit.org/show_bug.cgi?id=173667
1467
1468         Reviewed by Aakash Jain.
1469
1470         * QueueStatusServer/handlers/patch.py:
1471         (Patch.get): Sorted queue_status.
1472         * QueueStatusServer/templates/patch.html:
1473         Changed queue_status.items to queue_status because it's a list.
1474
1475 2017-08-07  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
1476
1477         check-webkit-style: NS_ERROR_ENUM and NS_OPTIONS should not be handled as function definitions.
1478         https://bugs.webkit.org/show_bug.cgi?id=175286
1479
1480         Reviewed by Myles C. Maxfield.
1481
1482         * Scripts/webkitpy/style/checkers/cpp.py:
1483         (check_braces):
1484         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1485         (WebKitStyleTest.test_braces.NS_ERROR_ENUM):
1486         (WebKitStyleTest.test_braces):
1487         (WebKitStyleTest.test_braces.NS_OPTIONS):
1488
1489 2017-08-07  Brian Burg  <bburg@apple.com>
1490
1491         Remove CANVAS_PATH compilation guard
1492         https://bugs.webkit.org/show_bug.cgi?id=175207
1493
1494         Reviewed by Sam Weinig.
1495
1496         * Scripts/webkitperl/FeatureList.pm:
1497         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1498
1499 2017-08-07  Per Arne Vollan  <pvollan@apple.com>
1500
1501         [Win] Use Visual Studio 2017 if installed.
1502         https://bugs.webkit.org/show_bug.cgi?id=175188
1503
1504         Reviewed by Sam Weinig.
1505
1506         If installed, use VS2017 to build WebKit. If not, fall back to VS2015.
1507
1508         * Scripts/webkitdirs.pm:
1509         (visualStudioInstallDir):
1510         (msBuildInstallDir):
1511
1512 2017-08-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1513
1514         [GTK][WPE] Add API to provide browser information required by automation
1515         https://bugs.webkit.org/show_bug.cgi?id=175130
1516
1517         Reviewed by Michael Catanzaro.
1518
1519         * MiniBrowser/gtk/main.c:
1520         (automationStartedCallback): Set browser information when a new automation session is started.
1521         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1522         (testAutomationSessionApplicationInfo):
1523         (beforeAll):
1524
1525 2017-08-06  Ryan Haddad  <ryanhaddad@apple.com>
1526
1527         Unreviewed, rolling out r220295.
1528
1529         This change introduced 4 errors in webkitpy tests.
1530
1531         Reverted changeset:
1532
1533         "[XCode] webkit-patch should run sort-Xcode-project-file"
1534         https://bugs.webkit.org/show_bug.cgi?id=174036
1535         http://trac.webkit.org/changeset/220295
1536
1537 2017-08-04  Ryan Haddad  <ryanhaddad@apple.com>
1538
1539         Disable API test NowPlayingControlsTests.NowPlayingControlsIOS.
1540
1541         Unreviewed test gardening.
1542
1543         * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm:
1544         (TestWebKitAPI::TEST):
1545
1546 2017-08-05  Filip Pizlo  <fpizlo@apple.com>
1547
1548         REGRESSION (r219895-219897): Number of leaks on Open Source went from 9240 to 235983 and is now at 302372
1549         https://bugs.webkit.org/show_bug.cgi?id=175083
1550
1551         Reviewed by Oliver Hunt.
1552         
1553         Leaks results are super confusing if leaks runs while some VMs are destructing. This calls a new SPI
1554         to wait for VM destructions to finish before running the next test. This makes it easier to 
1555         understand leaks results from workers tests, and leads to fewer reported leaks.
1556
1557         * DumpRenderTree/mac/DumpRenderTree.mm:
1558         (runTest):
1559
1560 2017-08-05  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
1561
1562         check-webkit-style: fix path-specific rules for WebKit2 rename
1563         https://bugs.webkit.org/show_bug.cgi?id=175182
1564
1565         Reviewed by David Kilzer.
1566
1567         * Scripts/webkitpy/style/checker.py:
1568
1569 2017-08-04  Youenn Fablet  <youenn@apple.com>
1570
1571         [Cache API] Add Cache and CacheStorage IDL definitions
1572         https://bugs.webkit.org/show_bug.cgi?id=175201
1573
1574         Reviewed by Brady Eidson.
1575
1576         * DumpRenderTree/mac/DumpRenderTree.mm:
1577         (enableExperimentalFeatures):
1578         (resetWebPreferencesToConsistentValues):
1579         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1580         (WTR::InjectedBundle::beginTesting):
1581         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1582         (WTR::TestRunner::setCacheAPIEnabled):
1583         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1584
1585 2017-08-04  John Wilander  <wilander@apple.com>
1586
1587         Resource Load Statistics: Report user interaction immediately, but only when needed
1588         https://bugs.webkit.org/show_bug.cgi?id=175090
1589         <rdar://problem/33685546>
1590
1591         Reviewed by Chris Dumez.
1592
1593         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1594         (WTR::InjectedBundle::beginTesting):
1595             Now calls WebCore::ResourceLoadObserver::clearState().
1596
1597 2017-08-04  Tim Horton  <timothy_horton@apple.com>
1598
1599         Add an API test for r220286
1600         https://bugs.webkit.org/show_bug.cgi?id=175206
1601
1602         Reviewed by Simon Fraser.
1603
1604         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
1605         (-[AnimatedResizeWebView _webView:didChangeSafeAreaShouldAffectObscuredInsets:]):
1606         (createAnimatedResizeWebView):
1607         (TEST):
1608         Add a test to ensure that we don't call
1609         _webView:didChangeSafeAreaShouldAffectObscuredInsets: during an
1610         animated resize.
1611
1612 2017-08-04  Stephan Szabo  <stephan.szabo@sony.com>
1613
1614         [XCode] webkit-patch should run sort-Xcode-project-file
1615         https://bugs.webkit.org/show_bug.cgi?id=174036
1616
1617         Reviewed by Simon Fraser.
1618
1619         * Scripts/webkitpy/common/config/ports.py:
1620         * Scripts/webkitpy/tool/commands/download.py:
1621         * Scripts/webkitpy/tool/commands/upload.py:
1622         * Scripts/webkitpy/tool/steps/__init__.py:
1623         * Scripts/webkitpy/tool/steps/options.py:
1624         * Scripts/webkitpy/tool/steps/sortxcodeprojectfiles.py: Added.
1625
1626 2017-08-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1627
1628         REGRESSION(r219857): run-benchmark --allplans broken
1629         https://bugs.webkit.org/show_bug.cgi?id=175186
1630
1631         Reviewed by Saam Barati.
1632
1633         r219857 forgot to update also the calls to BenchmarkRunner() that
1634         is done when the script is run with --allplans.
1635
1636         To fix this (and avoid future issues like this), let's factorize
1637         the calls to the benchhmark runner in a run_benchmark_plan()
1638         function.
1639
1640         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
1641         (run_benchmark_plan):
1642         (start):
1643
1644 2017-08-04  Aakash Jain  <aakash_jain@apple.com>
1645
1646         Dashboard bubbles sometimes show failure count instead of crash count
1647         https://bugs.webkit.org/show_bug.cgi?id=175157
1648         <rdar://problem/33709009>
1649
1650         Reviewed by Alexey Proskuryakov.
1651
1652         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
1653         (BuildbotTestResults.prototype.resultSummarizer): Use the regex for the precise match first.
1654
1655 2017-08-04  Joseph Pecoraro  <pecoraro@apple.com>
1656
1657         Add tests for NeverDestroyed
1658         https://bugs.webkit.org/show_bug.cgi?id=175146
1659
1660         Reviewed by Darin Adler.
1661
1662         * CMakeLists.txt:
1663         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1664         New files and sort.
1665
1666         * TestWebKitAPI/Tests/WTF/Logger.h:
1667         * TestWebKitAPI/Tests/WTF/Logger.cpp:
1668         (TestWebKitAPI::log):
1669         (TestWebKitAPI::takeLogStr):
1670         * TestWebKitAPI/Tests/WTF/RefLogger.h:
1671         * TestWebKitAPI/Tests/WTF/RefLogger.cpp:
1672         (TestWebKitAPI::log): Deleted.
1673         (TestWebKitAPI::takeLogStr): Deleted.
1674         Extract log() / takeLogStr() from RefLogger to a general Logger.h/cpp.
1675
1676         * TestWebKitAPI/Tests/WTF/LifecycleLogger.h:
1677         * TestWebKitAPI/Tests/WTF/LifecycleLogger.cpp: Added.
1678         (TestWebKitAPI::LifecycleLogger::LifecycleLogger):
1679         (TestWebKitAPI::LifecycleLogger::operator=):
1680         (TestWebKitAPI::LifecycleLogger::~LifecycleLogger):
1681         (TestWebKitAPI::LifecycleLogger::setName):
1682         (TestWebKitAPI::TEST):
1683         Add a class that logs construction / assignment / modifications.
1684
1685         * TestWebKitAPI/Tests/WTF/NeverDestroyed.cpp: Added.
1686         (TestWebKitAPI::TEST):
1687         (TestWebKitAPI::list):
1688         Test construction behavior is as expected both directly and using makeNeverDestroyed.
1689
1690 2017-08-04  Lucas Forschler  <lforschler@apple.com>
1691
1692         minification logic is not implemented for ios builds
1693         <rdar://problem/33726561>
1694
1695         Reviewed by Dean Johnson
1696
1697         * BuildSlaveSupport/built-product-archive:
1698         (minifyDirectory): refactor minifySource -> minifyDirectory
1699         (archiveBuiltProduct): add ios minification logic
1700         (minifySource): Deleted.
1701
1702 2017-08-04  Matt Lewis  <jlewis3@apple.com>
1703
1704         Unreviewed, rolling out r220271.
1705
1706         Rolling out due to Layout Test failing on iOS Simulator.
1707
1708         Reverted changeset:
1709
1710         "Remove STREAMS_API compilation guard"
1711         https://bugs.webkit.org/show_bug.cgi?id=175165
1712         http://trac.webkit.org/changeset/220271
1713
1714 2017-08-04  Ryan Haddad  <ryanhaddad@apple.com>
1715
1716         Unreviewed, rolling out r220268.
1717
1718         This change caused assertion failures on macOS and iOS Debug
1719         WK2.
1720
1721         Reverted changeset:
1722
1723         "Resource Load Statistics: Report user interaction
1724         immediately, but only when needed"
1725         https://bugs.webkit.org/show_bug.cgi?id=175090
1726         http://trac.webkit.org/changeset/220268
1727
1728 2017-08-04  Youenn Fablet  <youenn@apple.com>
1729
1730         Remove STREAMS_API compilation guard
1731         https://bugs.webkit.org/show_bug.cgi?id=175165
1732
1733         Reviewed by Darin Adler.
1734
1735         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1736
1737 2017-08-04  John Wilander  <wilander@apple.com>
1738
1739         Resource Load Statistics: Report user interaction immediately, but only when needed
1740         https://bugs.webkit.org/show_bug.cgi?id=175090
1741         <rdar://problem/33685546>
1742
1743         Reviewed by Chris Dumez.
1744
1745         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1746         (WTR::InjectedBundle::beginTesting):
1747             Now calls WebCore::ResourceLoadObserver::clearState().
1748
1749 2017-08-03  Brian Burg  <bburg@apple.com>
1750
1751         Remove ENABLE(WEB_SOCKET) guards
1752         https://bugs.webkit.org/show_bug.cgi?id=167044
1753
1754         Reviewed by Joseph Pecoraro.
1755
1756         * Scripts/webkitperl/FeatureList.pm:
1757         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1758
1759 2017-08-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1760
1761         REGRESSION(r219850): run-benchmark script broken on Linux
1762         https://bugs.webkit.org/show_bug.cgi?id=175126
1763
1764         Reviewed by Stephanie Lewis.
1765
1766         The run-benchmark script dynamically generates the list of supported
1767         browsers and platforms (currently Linux and OSX) by loading all
1768         python files from Tools/Scripts/webkitpy/benchmark_runner/browser_driver
1769         and getting the browser_name and platform variables from the
1770         classes defined there.
1771
1772         This means that this classes should not raise an exception when
1773         loaded on other platforms or otherwise they will broke the whole
1774         script. Its fine if they raise an exception when executing any of
1775         the methods they implement, but not when just loading/importing
1776         the class.
1777
1778         Move the argument variable definitions that call on the platform
1779         specific OSXBrowserDriver._screen_size() function from beeing
1780         variables that are evaluated when loading the file, to be functions
1781         that are only evaluated when the actual functionality needs to be
1782         executed.
1783
1784         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
1785         (OSXChromeDriver.launch_url):
1786         (OSXChromeCanaryDriver.launch_url):
1787         (create_args):
1788         (create_chrome_options):
1789         (create_window_size_arg):
1790         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
1791         (OSXFirefoxDriver.launch_url):
1792         (OSXFirefoxNightlyDriver.launch_url):
1793         (OSXFirefoxNightlyDriver.launch_driver):
1794         (create_args):
1795
1796 2017-08-03  Yoshiaki Jitsukawa  <jitsu@rd.scei.sony.co.jp>
1797
1798         [PAL] Move spi/cf directory into PAL
1799         https://bugs.webkit.org/show_bug.cgi?id=175057
1800
1801         Reviewed by Antti Koivisto.
1802
1803         * Scripts/webkitpy/style/checker.py:
1804         * Scripts/webkitpy/style/checker_unittest.py:
1805         (GlobalVariablesTest.test_path_rules_specifier):
1806
1807         Ignore "readability/naming/underscores" style errors for sources
1808         under the WebCore/PAL/pal/spi directory.
1809
1810         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
1811
1812 2017-08-03  Youenn Fablet  <youenn@apple.com>
1813
1814         Remove FETCH_API compilation guard
1815         https://bugs.webkit.org/show_bug.cgi?id=175154
1816
1817         Reviewed by Chris Dumez.
1818
1819         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1820
1821 2017-08-03  Lucas Forschler  <lforschler@apple.com>
1822
1823         Enable archive minification on iOS builds
1824         https://bugs.webkit.org/show_bug.cgi?id=174718
1825         
1826         Reviewed by Aakash Jain.
1827
1828         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1829         (BuildFactory.__init__):
1830
1831 2017-08-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1832
1833         [GTK][WKE] Pass the --memory-limited option on the GTK and WPE buildbots for the JSC tests.
1834         https://bugs.webkit.org/show_bug.cgi?id=175140
1835
1836         Reviewed by Alexey Proskuryakov.
1837
1838         We are having lately issues with JSC tests causing problems on
1839         the GTK+ and WPE bots due to the high amount of memory some tests
1840         need to run.
1841
1842         The best thing we can do now is to workaround this by disabling
1843         all the tests marked as memoryLimited on the GTK and WPE bots.
1844         We may revise this on the future.
1845
1846         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1847         (RunJavaScriptCoreTests.start):
1848
1849 2017-08-03  Brady Eidson  <beidson@apple.com>
1850
1851         Add SW IDLs and stub out basic functionality.
1852         https://bugs.webkit.org/show_bug.cgi?id=175115
1853
1854         Reviewed by Chris Dumez.
1855
1856         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1857
1858         * Scripts/webkitpy/bindings/main.py:
1859
1860 2017-08-03  Per Arne Vollan  <pvollan@apple.com>
1861
1862         [Win] The test http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/basic-upgrade.https.html is failing.
1863         https://bugs.webkit.org/show_bug.cgi?id=159510
1864
1865         Reviewed by Daniel Bates.
1866
1867         Allow any https certificate when running tests.
1868
1869         * DumpRenderTree/win/DumpRenderTree.cpp:
1870         (runTest):
1871
1872 2017-08-02  Youenn Fablet  <youenn@apple.com>
1873
1874         HTTP tests with 'https' suffix are only run over HTTPS for WK2, not WK1
1875         https://bugs.webkit.org/show_bug.cgi?id=175089
1876
1877         Reviewed by Chris Dumez.
1878
1879         * DumpRenderTree/TestOptions.mm:
1880         (TestOptions::TestOptions): Using absolutePath if available.
1881         * DumpRenderTree/mac/DumpRenderTree.mm:
1882         (computeTestURL): Removing http/tests/ specific URL computation.
1883         * Scripts/webkitpy/port/driver.py:
1884         (Driver._command_from_driver_input): Making webkitpy passing HTTP urls for HTTP served tests to all test runners, including WK1.
1885
1886 2017-08-02  Lucas Forschler  <lforschler@apple.com>
1887
1888         download-built-product should allow for a proxy option
1889         https://bugs.webkit.org/show_bug.cgi?id=174875
1890
1891         Reviewed by Aakash Jain, Alexey Proskuryakov, Dean Johnson
1892
1893         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1894         (DownloadBuiltProduct.start): Teach buildbot to pass along proxy for Apple bots
1895         
1896
1897 2017-08-02  Jonathan Bedard  <jbedard@apple.com>
1898
1899         check-webkit-style: deleting lines in a file runs the linter on the whole file
1900         https://bugs.webkit.org/show_bug.cgi?id=175078
1901
1902         Reviewed by David Kilzer.
1903
1904         Deleting lines in a file should not cause linter errors to be blamed on the patch.
1905         <https://bugs.webkit.org/show_bug.cgi?id=86142> is an example of this happening.
1906
1907         * Scripts/webkitpy/style/checkers/test_expectations.py:
1908         (TestExpectationsChecker._should_log_linter_warning): Do not log a linter error if the file it is associated with only has deleted lines
1909         * Scripts/webkitpy/style/main_unittest.py:
1910         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line): Added files should have every line number in the file when processing.
1911         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_only_deletes): Test case where the file with the linter errors only contained deletes.
1912         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Added files should have every line number in the file when processing.
1913
1914 2017-08-02  Jonathan Bedard  <jbedard@apple.com>
1915
1916         webkitpy: Allow caller to specify response to unicode encode/decode error in filesystem
1917         https://bugs.webkit.org/show_bug.cgi?id=175075
1918
1919         Reviewed by David Kilzer.
1920
1921         We have no way of handling text files with illegal unicode characters. Allow the callers of
1922         filesystem.read_text_file to specify one of Python 2.7's supported responses ('strict', 'ignore', or
1923         'replace'). See https://docs.python.org/2/howto/unicode.html for details on these responses.
1924
1925         * Scripts/webkitpy/common/system/filesystem.py:
1926         (FileSystem.read_text_file): Allow caller to specify unicode error handling.
1927         (FileSystem.write_text_file): Ditto.
1928         * Scripts/webkitpy/common/system/filesystem_mock.py:
1929         (MockFileSystem.read_text_file): Allow caller to specify unicode error handling.
1930         (MockFileSystem.write_text_file): Ditto.
1931         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1932         (RealFileSystemTest.test_read_text_file_unicode_decode_error): Test reading a file with illegal unicode content.
1933         (RealFileSystemTest.test_write_text_file_unicode_encode_error): Test writing illegal unicode content to a file.
1934
1935 2017-08-02  Aakash Jain  <aakash_jain@apple.com>
1936
1937         Intermittent exception in buildPageURLForIteration for Buildbot 0.9 dashboard
1938         https://bugs.webkit.org/show_bug.cgi?id=175072
1939
1940         Reviewed by Alexey Proskuryakov.
1941
1942         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1943         (Buildbot): Make sure this._builderNameToIDMap is always defined for Buildbot 0.9.
1944
1945 2017-08-02  Michael Catanzaro  <mcatanzaro@igalia.com>
1946
1947         [CMake] Remove obsolete code in TestWebKitAPI/CMakeLists.txt
1948         https://bugs.webkit.org/show_bug.cgi?id=175019
1949
1950         Reviewed by Darin Adler.
1951
1952         * TestWebKitAPI/CMakeLists.txt:
1953
1954 2017-08-01  Csaba Osztrogonác  <ossy@webkit.org>
1955
1956         Enabling uploading archives to S3
1957         https://bugs.webkit.org/show_bug.cgi?id=174198
1958
1959         Unreviewed unit test fix after r219235.
1960
1961         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1962
1963 2017-08-01  Csaba Osztrogonác  <ossy@webkit.org>
1964
1965         Fix JSCOnly ARM buildbots after r220047
1966         https://bugs.webkit.org/show_bug.cgi?id=174993
1967
1968         Unreviewed fix after r220087.
1969
1970         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1971         (BuildAndRemoteJSCTestsFactory.__init__):
1972
1973 2017-08-01  Chris Dumez  <cdumez@apple.com>
1974
1975         Add initial support for navigator.sendBeacon
1976         https://bugs.webkit.org/show_bug.cgi?id=175007
1977         <rdar://problem/33547728>
1978
1979         Reviewed by Sam Weinig.
1980
1981         Enable the Beacon API at runtime in the context of layout tests since the
1982         feature is currently disabled by default.
1983
1984         * DumpRenderTree/mac/DumpRenderTree.mm:
1985         (enableExperimentalFeatures):
1986         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1987         (WTR::InjectedBundle::beginTesting):
1988         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1989         (WTR::TestRunner::setModernMediaControlsEnabled):
1990         (WTR::TestRunner::setBeaconAPIEnabled):
1991         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1992
1993 2017-08-01  Aakash Jain  <aakash_jain@apple.com>
1994
1995         Update Bot Watcher's Dashboard for Buildbot 0.9
1996         https://bugs.webkit.org/show_bug.cgi?id=174777
1997
1998         Reviewed by Daniel Bates.
1999
2000         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
2001         (Buildbot): Check if USE_BUILDBOT_VERSION_LESS_THAN_09 is passed.
2002         (Buildbot.prototype._computeBuilderNameToIDMap): Fetch the builder name to ID mapping from buidbot and store
2003         in a dictionary.
2004         (Buildbot.prototype.buildPageURLForIteration): Updated URL as per Buildbot 0.9 format. Buildbot 0.9 currently does not support
2005         builder name in the build url. See <https://github.com/buildbot/buildbot/issues/3465>.
2006         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2007         (isMultiCodebaseGotRevisionProperty): Adapting to new data format.
2008         (parseRevisionProperty): Ditto.
2009         (BuildbotIteration.prototype.failureLogURL): Return the URL to build page if precise failure url is not available. For
2010         Buildbot 0.9, build page URL would be appropriate in most cases as per the new UI.
2011         (BuildbotIteration.prototype._parseData): Parsing the data as per new data format. Many variable names and data types
2012         have changed in Buildbot 0.9.
2013         (BuildbotIteration.prototype._adjustBuildDataForBuildbot09): Adjust the Buildbot 0.8 data to new format.
2014         (BuildbotIteration.prototype._updateIfDataAvailable): Update method for Buildbot 0.9 data. We are performing two API calls, 
2015         one for build information, another for step information of that build. We need to wait until data from both REST API calls are available.
2016         (BuildbotIteration.prototype._deprecatedUpdateWithData): Renamed from _updateWithData, used for Buildbot 0.8 data.
2017         (BuildbotIteration.prototype.get buildURL): URL to fetch build information from Buildbot. Also fetches got_revision property.
2018         (BuildbotIteration.prototype.get buildStepsURL): URL to fetch the steps information from Buildbot.
2019         (BuildbotIteration.prototype.urlFailedToLoad): Callback method to be used when URL fails to load. Made it a separate function now.
2020         (BuildbotIteration.prototype.update): Modified to support both Buildbot 0.9 and 0.8 data format.
2021         (BuildbotIteration.prototype.actualUpdate): Update method for Buildbot 0.9 data.
2022         (BuildbotIteration.prototype.deprecatedUpdate): Update method for Buildbot 0.8 data.
2023         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2024         (BuildbotQueue.prototype.get baseURL): Updated URL as per Buildbot 0.9 format.
2025         (BuildbotQueue.prototype.get allIterationsURL): Ditto.
2026         (BuildbotQueue.prototype.get overviewURL): Ditto.
2027         (BuildbotQueue.prototype.get buildsURL): URL to fetch builds data in Buildbot 0.9.
2028         (BuildbotQueue.prototype.get buildsInfoURL): Returns the appropriate URL to use to fetch builds information from
2029         Buildbot 0.8 or 0.9.
2030         (BuildbotQueue.prototype.getBuilds): Method compatible with both Buildbot 0.8 and 0.9 to get build information from data
2031         fetched from Buildbot. Also, reversing the Buildbot 0.8 data to make it similar to 0.9 data format.
2032         (BuildbotQueue.prototype.isBuildComplete): Method compatible with both Buildbot 0.8 and 0.9 to check if the build has completed.
2033         (BuildbotQueue.prototype.getIterationID):  Method compatible with both Buildbot 0.8 and 0.9 to get the Iteration ID.
2034         (BuildbotQueue.prototype.update): Supports both Buildbot 0.8 and 0.9. Buildbot 0.9 REST API doesn't have cachedBuilds and currentBuilds. 
2035         Therefore we are fetching information for fixed number of build. 
2036         Also iterating the loop incrementally since the build data is already reverse sorted.
2037         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
2038         (BuildbotTestResults.prototype._parseResults): Updated as per Buildbot 0.9 format. Note that we do not
2039         need to worry about 0.8 or 0.9 data format here, since the data is already converted to 0.9 format.
2040         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2041         (WebKitBuildbot): Pass the USE_BUILDBOT_VERSION_LESS_THAN_09 flag.
2042
2043 2017-08-01  Devin Rousso  <drousso@apple.com>
2044
2045         Web Inspector: simplify WebInspector with WI
2046         https://bugs.webkit.org/show_bug.cgi?id=175058
2047
2048         Reviewed by Joseph Pecoraro.
2049
2050         * Scripts/check-inspector-strings:
2051         (extract_ui_strings):
2052         * Scripts/extract-localizable-js-strings:
2053
2054 2017-08-01  Youenn Fablet  <youenn@apple.com>
2055
2056         Layout tests with 'https' suffix should be run over HTTPS
2057         https://bugs.webkit.org/show_bug.cgi?id=174992
2058
2059         Reviewed by Chris Dumez.
2060
2061         Updating the test-name <-> uri conversion routines to use https when test names contain ".https." in them.
2062         This covers WPT tests, WPT WebKit tests and HTTP layout tests.
2063         Covered by corresponding unit tests.
2064
2065         * Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py:
2066         (run_server):
2067         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2068         (base_http_url):
2069         (base_https_url):
2070         (base_url): Deleted.
2071         * Scripts/webkitpy/port/base.py:
2072         (Port.to.web_platform_test_server_base_http_url):
2073         (Port.to):
2074         (Port.to.web_platform_test_server_base_https_url):
2075         (Port.to.web_platform_test_server_base_url): Deleted.
2076         * Scripts/webkitpy/port/driver.py:
2077         (Driver.__init__):
2078         (Driver.wpt_test_path_to_uri):
2079         (Driver):
2080         (Driver.http_test_path_to_uri):
2081         (Driver.test_to_uri):
2082         (Driver.uri_to_test):
2083         * Scripts/webkitpy/port/driver_unittest.py:
2084         (DriverTest.test_test_to_uri):
2085         (DriverTest.test_uri_to_test):
2086
2087 2017-07-26  Jiewen Tan  <jiewen_tan@apple.com>
2088
2089         Add tests to detect mistakes in backward compatibility when the structured clone algorithm is changed in the future
2090         https://bugs.webkit.org/show_bug.cgi?id=173998
2091
2092         Reviewed by Darin Adler.
2093
2094         Since the structured clone algorithm is used for data stored in persistent databases, we need tests to help us
2095         detect mistakes in backward compatibility in the future when we change it.
2096
2097         The way it works is to read from a pre-baked database and see if all the values are matched with the expectations.
2098         Surprisedly, some of structured clonable objects cannot be stored into the indexedDB. Those are FileList,
2099         ObjectReference, MessagePortReference, ArrayBufferView, ArrayBufferTransfer, NonMapProperties, NonSetProperties,
2100         SharedArrayBuffer, WasmModule, DOMPointReadOnly, DOMPoint, DOMRectReadOnly, DOMRect, DOMMatrixReadOnly, DOMMatrix,
2101         DOMQuad and Error. CryptoKey objects are not included as well as they need new API for encrypting/decrypting the
2102         internal key data slot.
2103
2104         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2105         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.mm: Added.
2106         (-[IndexedDBStructuredCloneBackwardCompatibilityMessageHandler userContentController:didReceiveScriptMessage:]):
2107         (getNextMessage):
2108         (TEST):
2109         Here is the API test that moves the pre-baked database to the location where TestWebKitAPI can read from.
2110         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3: Added.
2111         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3-shm: Added.
2112         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3-wal: Added.
2113         These are the pre-baked databases.
2114         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibilityRead.html: Added.
2115         This is the actual test that do all the reads and comparisons.
2116         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibilityWrite.html: Added.
2117         This is the page that bakes the database. It never runs automatically. It is for someone who needs to teach
2118         IndexedDB new stuffs. Then it can be used to bake the database again.
2119
2120 2017-08-01  Brady Eidson  <beidson@apple.com>
2121
2122         API test URLSchemeHandler.Exceptions is Exiting out early on macOS Debug..
2123         https://bugs.webkit.org/show_bug.cgi?id=175030
2124
2125         Reviewed by Andy Estes.
2126
2127         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
2128         (-[TaskSchemeHandler webView:startURLSchemeTask:]): Stop calling an invalid NSError constructor.
2129
2130 2017-08-01  Brady Eidson  <beidson@apple.com>
2131
2132         Part 2 of: Rename DatabaseProcess to StorageProcess.
2133         https://bugs.webkit.org/show_bug.cgi?id=174880
2134
2135         Reviewed by Andy Estes.
2136
2137         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
2138         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm:
2139         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
2140         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
2141         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
2142         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
2143         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
2144         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
2145
2146 2017-07-31  Csaba Osztrogonác  <ossy@webkit.org>
2147
2148         Fix JSCOnly ARM buildbots after r220047
2149         https://bugs.webkit.org/show_bug.cgi?id=174993
2150
2151         Reviewed by Saam Barati.
2152
2153         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2154         (BuildAndRemoteJSCTestsFactory.__init__):
2155
2156 2017-07-30  Yusuke Suzuki  <utatane.tea@gmail.com>
2157
2158         [WTF] Introduce Private Symbols
2159         https://bugs.webkit.org/show_bug.cgi?id=174935
2160
2161         Reviewed by Darin Adler.
2162
2163         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2164         (TestWebKitAPI::TEST):
2165
2166 2017-07-30  Darin Adler  <darin@apple.com>
2167
2168         Remove code in HTMLObjectElement attribute parsing that forces style resolution and layout
2169         https://bugs.webkit.org/show_bug.cgi?id=130653
2170
2171         Reviewed by Antti Koivisto.
2172
2173         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2174         (WTR::InjectedBundlePage::didFinishLoadForFrame): Omit now-unneeded "shouldDump" argument
2175         when calling frameDidChangeLocation.
2176         (WTR::InjectedBundlePage::frameDidChangeLocation): Removed "shouldDump" argument. This was
2177         causing WebKitTestRunner to not dump anything in cases where DumpRenderTree will dump, and
2178         thus causing mysterious failures of a couple of tests. There are two remaining issues:
2179         1) WebKitTestRunner won't run its dump code if there is no "page", and there is no such
2180         consideration in DumpRenderTree and 2) Both DumpRenderTree and WebKitTestRunner share the
2181         same logic flaw that causes "top loading frame" to get set to one of the subframes in
2182         tests where  the following sequence occurs: test calls waitUntilDone, main frame finishes
2183         loading, subframe starts loading. It would be good to clean that up some day, but for now
2184         this patch makes the two work identically rather than changing both.
2185         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Updated for change above.
2186
2187 2017-07-30  Wenson Hsieh  <wenson_hsieh@apple.com>
2188
2189         [WK2] Replace RetainPtr<> with auto when adopting allocated ObjC objects in DataInteractionTests
2190         https://bugs.webkit.org/show_bug.cgi?id=174963
2191
2192         Reviewed by Darin Adler.
2193
2194         Replaces several uses of RetainPtr<>s with auto. Some test cases in this file use auto, while other test cases declare using
2195         RetainPtr<>. This patch changes them to all use auto.
2196
2197         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2198         (TestWebKitAPI::TEST):
2199
2200 2017-07-30  Brady Eidson  <beidson@apple.com>
2201
2202         Add URLSchemeHandler API tests that verify the lack of URLSchemeTask object leaks.
2203         https://bugs.webkit.org/show_bug.cgi?id=174958
2204
2205         Reviewed by Darin Adler.
2206
2207         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2208         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-leaks.mm: Added.
2209         (-[LeakSchemeHandler webView:startURLSchemeTask:]):
2210         (-[LeakSchemeHandler webView:stopURLSchemeTask:]):
2211         (runUntilTasksInFlight):
2212         (TEST):
2213
2214 2017-07-28  Commit Queue  <commit-queue@webkit.org>
2215
2216         Unreviewed, rolling out r219990.
2217         https://bugs.webkit.org/show_bug.cgi?id=174961
2218
2219         "broke PLT on iOS (rdar://problem/33602751)" (Requested by
2220         estes on #webkit).
2221
2222         Reverted changeset:
2223
2224         "Part 2 of: Rename DatabaseProcess to StorageProcess."
2225         https://bugs.webkit.org/show_bug.cgi?id=174880
2226         http://trac.webkit.org/changeset/219990
2227
2228 2017-07-28  Brady Eidson  <beidson@apple.com>
2229
2230         API tests that use URLSchemeHandler are failing.
2231         https://bugs.webkit.org/show_bug.cgi?id=174950
2232
2233         Reviewed by Alex Christensen.
2234
2235         Fix the NoMIMEType test to be correct.
2236
2237         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
2238         (-[SchemeHandler initWithData:mimeType:]):
2239         (-[SchemeHandler webView:startURLSchemeTask:]):
2240         (TEST):
2241
2242 2017-07-28  Daniel Bates  <dabates@apple.com>
2243
2244         prepare-ChangeLog should not list added layout tests in PAL ChangeLog
2245         https://bugs.webkit.org/show_bug.cgi?id=174876
2246
2247         Reviewed by Alex Christensen.
2248
2249         Do not list added layout tests in the PAL ChangeLog as such tests are unlikely to be related
2250         to a PAL change. Unit tests are more appropriate for PAL changes than layout tests because
2251         they provide a more direct way to test the platform abstraction.
2252
2253         As a side effect of this change we no longer list added layout tests in WebCore/platform/gtk/po/ChangeLog.
2254
2255         * Scripts/prepare-ChangeLog:
2256         (generateNewChangeLogs): Only list added layout tests in the WebCore ChangeLog regardless
2257         of the current working directory.
2258
2259 2017-07-28  Jonathan Bedard  <jbedard@apple.com>
2260
2261         Using "auto <function()> -> returnType" breaks prepare-ChangeLog
2262         https://bugs.webkit.org/show_bug.cgi?id=174930
2263
2264         Unreviewed test fix.
2265
2266         We need to check parentheses before printing 'const' or 'volatile' in the ChangeLog. 
2267
2268         * Scripts/prepare-ChangeLog:
2269         (get_function_line_ranges_for_cpp):
2270
2271 2017-07-28  JF Bastien  <jfbastien@apple.com>
2272
2273         Using "auto <function()> -> returnType" breaks prepare-ChangeLog
2274         https://bugs.webkit.org/show_bug.cgi?id=174930
2275
2276         Reviewed by Daniel Bates.
2277
2278         Teach prepare-ChangeLog about C++ auto arrow return, and while I'm
2279         here also teach it about const and volatile overloads. I didn't do
2280         reference and rvalue reference overloads because we don't really
2281         use them, and the current parser throws away those characters and
2282         it doesn't seem worth making it more complex.
2283
2284         * Scripts/prepare-ChangeLog:
2285         (get_function_line_ranges_for_cpp):
2286         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
2287         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp:
2288         (Foo::Arrow::arrow):
2289         (Foo::Arrow::otherArrow):
2290         (Foo::Arrow::otherArrow const):
2291         (Foo::Arrow::otherArrow volatile):
2292         (Foo::Arrow::otherArrow const volatile):
2293
2294 2017-07-28  Adrian Perez de Castro  <aperez@igalia.com>
2295
2296         [GTK] Building with ENABLE_VIDEO=OFF fails
2297         https://bugs.webkit.org/show_bug.cgi?id=174940
2298
2299         Reviewed by Alex Christensen.
2300
2301         When GStreamer usage is completely disabled at build time, CMake does not query pkg-config for the GStreamer.
2302         This adds missing USE(GSTREAMER) guards in order to make testing code buildable when GStreamer usage is disabled.
2303
2304         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
2305         (methodCallCallback): Add missing USE(GSTREAMER) guard.
2306
2307 2017-07-28  Claudio Saavedra  <csaavedra@igalia.com>
2308
2309         [WPE] Implement EventSenderProxy in WTR
2310         https://bugs.webkit.org/show_bug.cgi?id=173419
2311
2312         Reviewed by Žan Doberšek.
2313
2314         Add the implementation of EventSenderProxy to the WTR. This
2315         allows us to extend the coverage of the test suite in WKWPE.
2316
2317         * WebKitTestRunner/EventSenderProxy.h:
2318         * WebKitTestRunner/PlatformWPE.cmake: Add dependency on
2319         libxkbcommon needed to deal with key events.
2320         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
2321         (WTR::EventSenderProxy::EventSenderProxy):
2322         (WTR::senderButtonToWPEButton):
2323         (WTR::EventSenderProxy::mouseDown):
2324         (WTR::EventSenderProxy::mouseUp):
2325         (WTR::EventSenderProxy::mouseMoveTo):
2326         (WTR::EventSenderProxy::mouseScrollBy):
2327         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
2328         (WTR::EventSenderProxy::leapForward):
2329         (WTR::wkEventModifiersToWPE):
2330         (WTR::getXKBKeySymForKeyRef):
2331         (WTR::EventSenderProxy::keyDown):
2332         (WTR::EventSenderProxy::addTouchPoint):
2333         (WTR::EventSenderProxy::updateTouchPoint):
2334         (WTR::EventSenderProxy::setTouchModifier):
2335         (WTR::EventSenderProxy::setTouchPointRadius):
2336         (WTR::EventSenderProxy::getUpdatedTouchEvents):
2337         (WTR::EventSenderProxy::removeUpdatedTouchEvents):
2338         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
2339         (WTR::EventSenderProxy::touchStart):
2340         (WTR::EventSenderProxy::touchMove):
2341         (WTR::EventSenderProxy::touchEnd):
2342         (WTR::EventSenderProxy::touchCancel):
2343         (WTR::EventSenderProxy::clearTouchPoints):
2344         (WTR::EventSenderProxy::releaseTouchPoint):
2345         (WTR::EventSenderProxy::cancelTouchPoint):
2346
2347 2017-07-27  Brady Eidson  <beidson@apple.com>
2348
2349         Part 2 of: Rename DatabaseProcess to StorageProcess.
2350         https://bugs.webkit.org/show_bug.cgi?id=174880
2351
2352         Reviewed by Andy Estes.
2353
2354         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
2355         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm:
2356         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
2357         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
2358         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
2359         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
2360         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
2361         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
2362
2363 2017-07-26  Mark Lam  <mark.lam@apple.com>
2364
2365         Add ability to only run specific tests in run-javascriptcore-tests.
2366         https://bugs.webkit.org/show_bug.cgi?id=174884
2367
2368         Reviewed by Saam Barati.
2369
2370         For example, if we only want to run testapi, we can do so as follows:
2371             $ run-javascriptcore-tests --testapi
2372
2373         Previously, specifying --testapi effectively does nothing because we run all tests
2374         by default.  Only --no-testapi had the effect of disabling the test set.  This
2375         old behavior for --testapi is not very useful or meaningful.  We're now changing
2376         it to mean that we will only run that test.
2377
2378         With this change, we can also run more than one set of tests.  For example, if we
2379         only want to run testmasm and testair, we can do so as follows:
2380             $ run-javascriptcore-tests --testmasm --testair
2381
2382         By default, if no specific test option is specified, run-javascriptcore-tests will
2383         run all tests.
2384
2385         Note that the jsc stress tests (--jsc-stress) are a different set of tests than
2386         the mozilla tests (--mozilla-tests) even though both are run via the lower level
2387         run-jsc-stress-tests test harness.  Hence, if you only specify one of the tests,
2388         the other set will not run.  For example, the following only runs the mozilla tests:
2389             $ run-javascriptcore-tests --mozilla-tests
2390
2391         Note also that --jit-stress-tests is not for choosing a different set of tests.
2392         Instead, it is used for determining whether we run JIT'ed test configurations
2393         on the jsc stress tests and mozilla tests.  As a result, specifying
2394         --jit-stress-tests will not omit other tests.  For example, the following still
2395         runs all tests:
2396             $ run-javascriptcore-tests --jit-stress-tests
2397
2398         * Scripts/run-javascriptcore-tests:
2399         (defaultStringForTestState):
2400         (enableTestOrNot):
2401         (runJSCStressTests):
2402
2403 2017-07-26  Mark Lam  <mark.lam@apple.com>
2404
2405         Make run-javascriptcore-test run testair, testb3, and testmasm.
2406         https://bugs.webkit.org/show_bug.cgi?id=174837
2407         <rdar://problem/33522927>
2408
2409         Reviewed by Saam Barati and Filip Pizlo.
2410
2411         1. Refactors code for running testapi so that we can use it to run other tests.
2412         2. Added running of testmasm, testair, testb3.
2413
2414         Note: the existing testapi invocation code does not support remote invocation of
2415         the tests (e.g. on a ARM device).  Hence, the new additions of testmasm, testair,
2416         and testb3 also do not support remote invocation.  If we wish to add remote
2417         invocation support, we should do that in a separate patch.
2418
2419         * Scripts/run-javascriptcore-tests:
2420         (testPath):
2421         (runTest):
2422         (testapiPath): Deleted.
2423
2424 2017-07-26  Aakash Jain  <aakash_jain@apple.com>
2425
2426         Remove duplicate code from Buildbot.js in dashboard
2427         https://bugs.webkit.org/show_bug.cgi?id=174870
2428
2429         Reviewed by Daniel Bates.
2430
2431         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
2432         (Buildbot.prototype.javaScriptCoreTestFailuresURLForIteration): Remove duplicate code and reuse buildPageURLForIteration() to construct URL.
2433         (Buildbot.prototype.javaScriptCoreTestStdioUrlForIteration): Ditto.
2434         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbot.js:
2435         (MockBuildbot.prototype.javaScriptCoreTestStdioUrlForIteration): Ditto for tests.
2436
2437 2017-07-26  Brady Eidson  <beidson@apple.com>
2438
2439         Add test to verify certain child processes are not launched as a side effect of enabling ResourceLoadStatistics.
2440         https://bugs.webkit.org/show_bug.cgi?id=174851
2441
2442         Reviewed by Chris Dumez.
2443
2444         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
2445         (TEST):
2446
2447 2017-07-26  Brian Burg  <bburg@apple.com>
2448
2449         Remove WEB_TIMING feature flag
2450         https://bugs.webkit.org/show_bug.cgi?id=174795
2451
2452         Reviewed by Alex Christensen.
2453
2454         * Scripts/webkitperl/FeatureList.pm:
2455         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2456
2457 2017-07-26  Chris Dumez  <cdumez@apple.com>
2458
2459         Pressing the Escape key should not be a valid user gesture to enter fullscreen
2460         https://bugs.webkit.org/show_bug.cgi?id=174864
2461         <rdar://problem/33009088>
2462
2463         Reviewed by Geoffrey Garen.
2464
2465         Add support for eventSender.keyDown('escape') in DRT to match the behavior of
2466         WKTR.
2467
2468         * DumpRenderTree/mac/EventSendingController.mm:
2469         (-[EventSendingController keyDown:withModifiers:withLocation:]):
2470
2471 2017-07-26  Romain Bellessort  <romain.bellessort@crf.canon.fr>
2472
2473         Unreviewed, added Romain Bellessort to contributors.json.
2474
2475         * Scripts/webkitpy/common/config/contributors.json:
2476
2477 2017-07-26  Zan Dobersek  <zdobersek@igalia.com>
2478
2479         [WPE] WebGL2 support
2480         https://bugs.webkit.org/show_bug.cgi?id=174249
2481
2482         Reviewed by Alex Christensen.
2483
2484         * Scripts/webkitperl/FeatureList.pm:
2485         Enable WebGL2 for WPE when building through build-webkit.
2486
2487 2017-07-26  Carlos Garcia Campos  <cgarcia@igalia.com>
2488
2489         Unreviewed. Fix GTK distcheck.
2490
2491         * gtk/make-dist.py:
2492         (ensure_version_if_possible): Use the right pkg-config filename, it's webkit2gtk not webkitgtk.
2493
2494 2017-07-25  Brady Eidson  <beidson@apple.com>
2495
2496         ResourceLoadStatistics grandfathering happens much too often.
2497         <rdar://problem/32655834> and https://bugs.webkit.org/show_bug.cgi?id=174825
2498
2499         Reviewed by Chris Dumez.
2500
2501         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2502         * TestWebKitAPI/Tests/WebKit2Cocoa/EmptyGrandfatheredResourceLoadStatistics.plist: Added.
2503         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm: Added.
2504         (TEST):
2505
2506 2017-07-25  Matthew Stewart  <matthew_r_stewart@apple.com>
2507
2508         Fix autoinstaller failing on autoinstall_everything
2509         https://bugs.webkit.org/show_bug.cgi?id=174830
2510
2511         Reviewed by Joseph Pecoraro.
2512
2513         * Scripts/webkitpy/thirdparty/__init__.py:
2514         (AutoinstallImportHook.find_module):
2515         (AutoinstallImportHook.install_chromedriver):
2516         (AutoinstallImportHook.install_geckodriver):
2517         (AutoinstallImportHook._install_chromedriver): Deleted.
2518         (AutoinstallImportHook._install_geckodriver): Deleted.
2519
2520 2017-07-25  Jonathan Bedard  <jbedard@apple.com>
2521
2522         Replace --runtime with something for both ios-simulator and ios-device
2523         https://bugs.webkit.org/show_bug.cgi?id=173775
2524         <rdar://problem/32952164>
2525
2526         Reviewed by Aakash Jain.
2527
2528         Add --version flag for both iOS simulator and iOS device.
2529
2530         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2531         (parse_args): Add --version flag and move --no-install.
2532         * Scripts/webkitpy/port/factory.py:
2533         (platform_options): Move --no-intall to run_webkit_tests.py.
2534         * Scripts/webkitpy/port/ios.py:
2535         (IOSPort):
2536         (IOSPort._is_valid_ios_version): Check that the provided version string is legal.
2537         (IOSPort.get_option): If accessing the iOS version, check that it is a valid version string.
2538         * Scripts/webkitpy/port/ios_device.py:
2539         (IOSDevicePort.ios_version): Consult --version flag before checking connected
2540         devices for iOS version.
2541         * Scripts/webkitpy/port/ios_device_unittest.py:
2542         (IOSDeviceTest.make_port): Set --version option so that we can generate test
2543         expectation paths without devices connected.
2544         (IOSDeviceTest.test_additional_platform_directory): Deleted.
2545         (IOSDeviceTest.test_baseline_searchpath): Deleted.
2546         (IOSDeviceTest.test_expectations_ordering): Deleted.
2547         * Scripts/webkitpy/port/ios_simulator.py:
2548         (IOSSimulatorPort.simulator_runtime): If no runtime is specified, use the --version
2549         flag to specify a runtime.
2550         (IOSSimulatorPort.ios_version): First check the --version flag, then the --runtime
2551         flag and then use the default runtime.
2552
2553 2017-07-25  Carlos Garcia Campos  <cgarcia@igalia.com>
2554
2555         [GTK] TestWebKitAPI tests are no longer built since the WebKit2 rename
2556         https://bugs.webkit.org/show_bug.cgi?id=174815
2557
2558         Reviewed by Carlos Alberto Lopez Perez.
2559
2560         Only WebKitGTK specific tests are built, but not WebKit2, WTF nor WebCore ones. We are still checking
2561         ENABLE_WEBKIT2 in the makefile, that was renamed to ENABLE_WEBKIT. Also, all WebKit2 test paths were updated to
2562         use WebKit dir, while the tests are still in WebKit2 directory. This patch also removes
2563         TestWebKitAPIInjectedBundle_PATH that is unused and now makes the configure to fail (it used to be a warning, I
2564         think), probably because of a newer CMake version.
2565
2566         * CMakeLists.txt:
2567         * TestWebKitAPI/CMakeLists.txt:
2568         * TestWebKitAPI/PlatformGTK.cmake:
2569
2570 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
2571
2572         Fix BenchmarkRunner to only import selenium when needed
2573         https://bugs.webkit.org/show_bug.cgi?id=174808
2574
2575         Reviewed by Stephanie Lewis.
2576
2577         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
2578         (LinuxChromeDriver.launch_driver):
2579         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
2580         (LinuxFirefoxDriver.launch_driver):
2581         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
2582         (OSXChromeDriver.launch_driver):
2583         (OSXChromeCanaryDriver.launch_driver):
2584         (create_chrome_options):
2585         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
2586         (OSXFirefoxDriver.launch_driver):
2587         (OSXFirefoxNightlyDriver.launch_driver):
2588         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2589         (OSXSafariDriver.launch_driver):
2590         * Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py:
2591         (WebDriverBenchmarkRunner._run_one_test):
2592
2593 2017-07-23  Darin Adler  <darin@apple.com>
2594
2595         More NeverDestroyed and related cleanup
2596         https://bugs.webkit.org/show_bug.cgi?id=174745
2597
2598         Reviewed by Alex Christensen.
2599
2600         * DumpRenderTree/JavaScriptThreading.cpp:
2601         (javaScriptThreadsMutex): Use NeverDestroyed instead of
2602         DEPRECATED_DEFINE_STATIC_LOCAL.
2603         (javaScriptThreads): Ditto.
2604
2605 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
2606
2607         Subclass Benchmark Runner script for WebDriver support
2608         https://bugs.webkit.org/show_bug.cgi?id=174390
2609
2610         Reviewed by Dewei Zhu, Stephanie Lewis.
2611
2612         Add WebServerBenchmarkRunner and WebDriverBenchmarkRunner subclasses.
2613
2614         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
2615         (BenchmarkBuilder.__init__):
2616         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2617         (BenchmarkRunner.__init__):
2618         (BenchmarkRunner._find_plan_file):
2619         (BenchmarkRunner._run_one_test.and):
2620         (BenchmarkRunner.execute):
2621         (BenchmarkRunner._get_result): Deleted.
2622         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
2623         (parse_args):
2624         (start):
2625         * Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py: Added.
2626         (WebDriverBenchmarkRunner):
2627         (WebDriverBenchmarkRunner._get_result):
2628         (WebDriverBenchmarkRunner._run_one_test):
2629         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py: Added.
2630         (WebServerBenchmarkRunner):
2631         (WebServerBenchmarkRunner.__init__):
2632         (WebServerBenchmarkRunner._get_result):
2633         (WebServerBenchmarkRunner._run_one_test):
2634
2635 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
2636
2637         Add BenchmarkRunner patches with WebDriver support for each testing plan
2638         https://bugs.webkit.org/show_bug.cgi?id=174443
2639
2640         Reviewed by Dewei Zhu, Stephanie Lewis.
2641
2642         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
2643         (BenchmarkBuilder.__enter__):
2644         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/ARES-6.patch:
2645         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/ContentAnimation.patch:
2646         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Dromaeo.patch:
2647         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/JSBench.patch:
2648         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/JetStream.patch:
2649         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Kraken.patch:
2650         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/MotionMark.patch:
2651         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Octane.patch:
2652         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Speedometer.patch:
2653         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/SunSpider.patch:
2654         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/ARES-6.patch:
2655         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Animometer.patch:
2656         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/ContentAnimation.patch:
2657         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Dromaeo.patch:
2658         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/JSBench.patch:
2659         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/JetStream.patch:
2660         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Kraken.patch:
2661         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/MotionMark.patch:
2662         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Octane.patch:
2663         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Speedometer.patch:
2664         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/SunSpider.patch:
2665         * Scripts/webkitpy/benchmark_runner/data/plans/ares6.plan:
2666         * Scripts/webkitpy/benchmark_runner/data/plans/content-animation.plan:
2667         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan:
2668         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan:
2669         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan:
2670         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
2671         * Scripts/webkitpy/benchmark_runner/data/plans/jsbench.plan:
2672         * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan:
2673         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan:
2674         * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan:
2675         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan:
2676         * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan:
2677
2678 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
2679
2680         Add functions to autoinstaller needed for Benchmark Runner script
2681         https://bugs.webkit.org/show_bug.cgi?id=174331
2682
2683         Reviewed by Dean Johnson, Dewei Zhu, Stephanie Lewis.
2684
2685         Adds autoinstaller functions to install selenium and webdriver binaries
2686         which will be used by the browser driver part of Benchmark Runner.
2687
2688         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
2689         (BrowserDriver.restore_env):
2690         (BrowserDriver):
2691         (BrowserDriver.get_webdriver_binary_path):
2692         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
2693         (LinuxChromeDriver.launch_driver):
2694         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
2695         (LinuxFirefoxDriver.launch_driver):
2696         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
2697         (OSXChromeDriver.launch_driver):
2698         (OSXChromeCanaryDriver.launch_driver):
2699         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
2700         (OSXFirefoxDriver.launch_driver):
2701         (OSXFirefoxNightlyDriver.launch_driver):
2702         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2703         * Scripts/webkitpy/benchmark_runner/utils.py:
2704         (get_driver_binary_path):
2705         * Scripts/webkitpy/common/system/autoinstall.py:
2706         (AutoInstaller._unzip):
2707         * Scripts/webkitpy/thirdparty/__init__.py:
2708         (AutoinstallImportHook.find_module):
2709         (AutoinstallImportHook._install_selenium):
2710         (AutoinstallImportHook):
2711         (AutoinstallImportHook._install_chromedriver):
2712         (AutoinstallImportHook._install_geckodriver):
2713         (AutoinstallImportHook.get_latest_pypi_url):
2714         (AutoinstallImportHook.install_binary):
2715         (autoinstall_everything):
2716         (get_driver_filename):
2717         (get_os_info):
2718
2719 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
2720
2721         Add WebDriver support in browser driver part of BenchmarkRunner
2722         https://bugs.webkit.org/show_bug.cgi?id=174445
2723
2724         Reviewed by Stephanie Lewis.
2725
2726         Adds a launch_driver function to each BrowserDriver subclass. This
2727         function sets up the arguments for the webdriver and launches the
2728         webdriver specific to that browser.
2729
2730         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
2731         (BrowserDriver.launch_webdriver):
2732         (BrowserDriver):
2733         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
2734         (LinuxBrowserDriver.launch_webdriver):
2735         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
2736         (LinuxChromeDriver.launch_url):
2737         (LinuxChromeDriver):
2738         (LinuxChromeDriver.launch_driver):
2739         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_epiphany_driver.py:
2740         (EpiphanyBrowserDriver.launch_url):
2741         (EpiphanyBrowserDriver):
2742         (EpiphanyBrowserDriver.launch_driver):
2743         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
2744         (LinuxFirefoxDriver):
2745         (LinuxFirefoxDriver.launch_url):
2746         (LinuxFirefoxDriver.launch_driver):
2747         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_minibrowsergtk_driver.py:
2748         (GTKMiniBrowserDriver.launch_url):
2749         (GTKMiniBrowserDriver):
2750         (GTKMiniBrowserDriver.launch_driver):
2751         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
2752         (OSXBrowserDriver._launch_webdriver):
2753         (OSXBrowserDriver):
2754         (OSXBrowserDriver._screen_size):
2755         (OSXBrowserDriver._insert_url):
2756         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
2757         (OSXChromeDriver):
2758         (OSXChromeDriver.launch_url):
2759         (OSXChromeDriver.launch_driver):
2760         (OSXChromeCanaryDriver):
2761         (OSXChromeCanaryDriver.launch_url):
2762         (OSXChromeCanaryDriver.launch_driver):
2763         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
2764         (OSXFirefoxDriver):
2765         (OSXFirefoxDriver.launch_url):
2766         (OSXFirefoxDriver.launch_driver):
2767         (OSXFirefoxNightlyDriver):
2768         (OSXFirefoxNightlyDriver.launch_url):
2769         (OSXFirefoxNightlyDriver.launch_driver):
2770         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2771         (OSXSafariDriver.launch_driver):
2772
2773 2017-07-24  Wenson Hsieh  <wenson_hsieh@apple.com>
2774
2775         [Mac WK2] Add an API test to cover r219765 (null dereference in [WKWebView dealloc])
2776         https://bugs.webkit.org/show_bug.cgi?id=174793
2777
2778         Reviewed by Tim Horton.
2779
2780         Adds a new unit test that invokes some asynchronous NSTextInputClient SPI methods as the web view is tearing
2781         down. Without r219765, this test will dereference null and crash.
2782
2783         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2784         * TestWebKitAPI/Tests/TestWebKitAPI/mac/NSTextInputClientSPI.h: Added.
2785         * TestWebKitAPI/Tests/mac/WKWebViewSelectionTests.mm:
2786         (TEST):
2787
2788 2017-07-24  Basuke Suzuki  <Basuke.Suzuki@sony.com>
2789
2790         [Win] Implement Authentication dialog in MiniBrowser
2791         https://bugs.webkit.org/show_bug.cgi?id=174662
2792
2793         Reviewed by Alex Christensen.
2794
2795         * MiniBrowser/win/Common.cpp:
2796         (CustomUserAgent):
2797         (DisplayAuthDialog):
2798         (AuthDialogProc):
2799         * MiniBrowser/win/MiniBrowserLib.rc:
2800         * MiniBrowser/win/MiniBrowserLibResource.h:
2801         * MiniBrowser/win/ResourceLoadDelegate.cpp:
2802         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
2803
2804 2017-07-24  Jonathan Bedard  <jbedard@apple.com>
2805
2806         Handle case where line_numbers is None instead of an array of line numbers
2807         https://bugs.webkit.org/show_bug.cgi?id=174775
2808
2809         Reviewed by Aakash Jain.
2810
2811         Added files set line_numbers to None in process_file.
2812
2813         * Scripts/webkitpy/style/filereader.py:
2814         (TextFileReader.process_file): Handle case where line_number is set to None.
2815         * Scripts/webkitpy/style/main_unittest.py:
2816         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Test case of an added file.
2817
2818 2017-07-24  Zan Dobersek  <zdobersek@igalia.com>
2819
2820         [WPE] Add libepoxy to the Jhbuild moduleset
2821         https://bugs.webkit.org/show_bug.cgi?id=174711
2822
2823         Reviewed by Carlos Alberto Lopez Perez.
2824
2825         * wpe/jhbuild.modules: Add libepoxy 1.4.3 to WPE's Jhbuild moduleset.
2826
2827 2017-07-24  Zan Dobersek  <zdobersek@igalia.com>
2828
2829         [WPE] libepoxy headers can use EGL_CAST, which might not be defined by eglplatform.h
2830         https://bugs.webkit.org/show_bug.cgi?id=174780
2831
2832         Reviewed by Carlos Garcia Campos.
2833
2834         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp:
2835         Manually define the EGL_CAST macro to the C++ version that uses static_cast<>
2836         in case the eglplatform.h header doesn't provide that macro. This replicates
2837         the work in WebCore's EpoxyEGL.h header, but we can't include that header here.
2838
2839 2017-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2840
2841         [iOS WK2] Remove _WKDraggableElementInfo and fold PositionInformationTests into WKRequestActivatedElementInfo
2842         https://bugs.webkit.org/show_bug.cgi?id=174758
2843
2844         Reviewed by Dan Bernstein.
2845
2846         Migrate position-information-related unit tests from the PositionInformationTests suite to
2847         WKRequestActivatedElementInfo as 2 new unit tests. See WebKit2 ChangeLog for more details.
2848
2849         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2850         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm:
2851         (TestWebKitAPI::checkElementTypeAndBoundingRect):
2852         (TestWebKitAPI::TEST):
2853         * TestWebKitAPI/Tests/ios/PositionInformationTests.mm: Removed.
2854         * TestWebKitAPI/cocoa/TestWKWebView.h:
2855         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2856         (-[TestWKWebView activatedElementAtPosition:]):
2857
2858 2017-07-22  Chris Dumez  <cdumez@apple.com>
2859
2860         REGRESSION(r204565): WKObject is broken
2861         https://bugs.webkit.org/show_bug.cgi?id=174736
2862         <rdar://problem/33246169>
2863
2864         Reviewed by Dan Bernstein.
2865
2866         Add API test that used to crash.
2867
2868         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
2869         (TestWebKitAPI::TEST):
2870
2871 2017-07-22  Yusuke Suzuki  <utatane.tea@gmail.com>
2872
2873         [WTF] Extend ThreadGroup::add results from bool to ThreadGroupAddResult
2874         https://bugs.webkit.org/show_bug.cgi?id=174705
2875
2876         Reviewed by Mark Lam.
2877
2878         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp:
2879         (TestWebKitAPI::testThreadGroup):
2880         (TestWebKitAPI::TEST):
2881
2882 2017-07-21  Jonathan Bedard  <jbedard@apple.com>
2883
2884         Fail gracefully when xcrun fails in IOSSimulatorPort constructor
2885         https://bugs.webkit.org/show_bug.cgi?id=174724
2886
2887         Reviewed by Aakash Jain.
2888
2889         * Scripts/webkitpy/port/ios_simulator.py:
2890         (IOSSimulatorPort.__init__): Ignore any errors when attempting to find a running
2891         simulator. Errors here should be treated the same as no simulators found.
2892
2893 2017-07-21  Yousuke Kimoto  <Yousuke.Kimoto@sony.com>
2894
2895         [CMake] Add an option to stop build after generating project files
2896         https://bugs.webkit.org/show_bug.cgi?id=174664
2897
2898         Reviewed by Konstantin Tokarev.
2899
2900         Add "--generate-project-only" to stop build after generating project files.
2901
2902         * Scripts/build-webkit: Add '--generate-project-only' option and a checker to stop build.
2903         * Scripts/webkitdirs.pm: Add a function to check '--generate-project-only' option and the same checker as the above
2904         (buildCMakeProjectOrExit): Add a cheker to stop build stop build after generating project files.
2905         (determineIsGenerateProjectOnly): Check if '--generate-project-only' option is specified
2906         (isGenerateProjectOnly): ditto
2907
2908 2017-07-21  Yusuke Suzuki  <utatane.tea@gmail.com>
2909
2910         [WTF] Newly added AtomicStringImpl should use BufferInternal static string if StringImpl is static
2911         https://bugs.webkit.org/show_bug.cgi?id=174501
2912
2913         Reviewed by Darin Adler.
2914
2915         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2916         (TestWebKitAPI::TEST):
2917
2918 2017-07-20  David Quesada  <david_quesada@apple.com>
2919
2920         Add SPI to notify WKNavigationDelegate about client redirects
2921         https://bugs.webkit.org/show_bug.cgi?id=174680
2922         rdar://problem/33184886
2923
2924         Reviewed by Brady Eidson.
2925
2926         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
2927         (-[DidPerformClientRedirectNavigationDelegate _webView:didPerformClientRedirectForNavigation:]):
2928         (TEST):
2929         Add API test for -[id<WKNavigationDelegatePrivate> _webView:didPerformClientRedirectForNavigation:].
2930
2931 2017-07-20  Brady Eidson  <beidson@apple.com>
2932
2933         Test WebKit2CustomProtocolsTest.ProcessPoolDestroyedDuringLoading added in r219664 fails on El Capitan.
2934         https://bugs.webkit.org/show_bug.cgi?id=174685
2935
2936         Reviewed by Andy Estes.
2937
2938         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
2939         (TestWebKitAPI::TEST): Use a scoped AutodrainedPool instead of a RetainPtr<NSAutoreleasePool>.
2940
2941 2017-07-20  Brady Eidson  <beidson@apple.com>
2942
2943         Deprecate WebIconDatabase in WebKitLegacy/mac.
2944         https://bugs.webkit.org/show_bug.cgi?id=174607
2945
2946         Reviewed by Alex Christensen.
2947
2948         * DumpRenderTree/mac/TestRunnerMac.mm:
2949
2950 2017-07-20  Jonathan Bedard  <jbedard@apple.com>
2951
2952         lint-test-expectations should be run during style checking
2953         https://bugs.webkit.org/show_bug.cgi?id=173559
2954         <rdar://problem/32854941>
2955
2956         Reviewed by Aakash Jain.
2957
2958         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2959         (TestExpectationsModel._already_seen_better_match): Append returns 'None' when successful,
2960         prevents identifying errors on specific lines in a file.
2961         * Scripts/webkitpy/style/main_unittest.py:
2962         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_edit_in_file): Test for the
2963         case where a linter error is in the file modified, but the line modified is not related to
2964         the linter error.
2965
2966 2017-07-20  Brady Eidson  <beidson@apple.com>
2967
2968         Remove WebIconDatabase from WebKitLegacy/win.
2969         https://bugs.webkit.org/show_bug.cgi?id=174608
2970
2971         Reviewed by Alex Christensen.
2972
2973         * DumpRenderTree/win/DumpRenderTree.cpp:
2974         (main):
2975         * DumpRenderTree/win/TestRunnerWin.cpp:
2976         (TestRunner::setIconDatabaseEnabled):
2977
2978 2017-07-20  Zan Dobersek  <zdobersek@igalia.com>
2979
2980         [WPE] Adjust priority of GSource used in WKTR's HeadlessViewBackend
2981         https://bugs.webkit.org/show_bug.cgi?id=174671
2982
2983         Reviewed by Carlos Garcia Campos.
2984
2985         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp:
2986         (HeadlessViewBackend::HeadlessViewBackend): Use the RunLoopDispatcher
2987         priority for this source in order to have it dispatched on the same
2988         priority as the other WebKit-controlled GSource objects.
2989
2990 2017-07-19  Jonathan Bedard  <jbedard@apple.com>
2991
2992         lint-test-expectations should be run during style checking
2993         https://bugs.webkit.org/show_bug.cgi?id=173559
2994         <rdar://problem/32854941>
2995
2996         Reviewed by Daniel Bates.
2997
2998         Follow up fix addressing style and a few minor bugs.
2999
3000         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3001         (TestExpectationParser.__init__): Use lambda x: x instead of str
3002         (TestExpectationsModel.__init__): Make lambda x: x the default argument.
3003         (TestExpectationsModel._already_seen_better_match): Use a temporary variable to
3004         reduce the calls of _shorten_filename, fix minor bug in appending the current
3005         expectation's line number instead of the previous ones, clarify treatment of None
3006         in file-to-line-number mapping.
3007         (TestExpectations._report_warnings): Collapse call.
3008         * Scripts/webkitpy/style/checkers/test_expectations.py:
3009         (TestExpectationsChecker.lint_test_expectations):
3010         * Scripts/webkitpy/style/filereader.py: Re-write comment.
3011         (TextFileReader.process_file): Add comment explaining treatment of None in
3012         file-to-line-number mapping.
3013         (TextFileReader.delete_file): Collapse call.
3014
3015 2017-07-19  Chris Dumez  <cdumez@apple.com>
3016
3017         Unreviewed attempt to fix API test failure after r219663.
3018
3019         The test was hard-coding an exception string and the string has changed slightly
3020         in r219663.
3021
3022         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
3023         (TEST):
3024
3025 2017-07-19  Megan Gardner  <megan_gardner@apple.com>
3026
3027         Don't write file URLs to iOS Pasteboard
3028         https://bugs.webkit.org/show_bug.cgi?id=174647
3029         <rdar://problem/33199730>
3030
3031         Reviewed by Wenson Hsieh.
3032
3033         Updating tests to reflect the lack of file URLs for images.
3034
3035         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3036         (checkTypeIdentifierAndIsNotOtherTypeIdentifier):
3037         (checkEstimatedSize):
3038         (TestWebKitAPI::TEST):
3039
3040 2017-07-19  Brady Eidson  <beidson@apple.com>
3041
3042         iBooks sometimes crashes when closing a book.
3043         <rdar://problem/31180331> and https://bugs.webkit.org/show_bug.cgi?id=174658
3044
3045         Reviewed by Oliver Hunt.
3046
3047         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
3048         (-[ProcessPoolDestroyedDuringLoadingProtocol startLoading]):
3049         (-[ProcessPoolDestroyedDuringLoadingProtocol finishTheLoad]):
3050         (-[ProcessPoolDestroyedDuringLoadingProtocol stopLoading]):
3051         (TestWebKitAPI::TEST):
3052
3053         Add a "spin the runloop X number of times" utility:
3054         * TestWebKitAPI/Utilities.h:
3055         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
3056         (TestWebKitAPI::Util::spinRunLoop):
3057
3058 2017-07-19  Jonathan Bedard  <jbedard@apple.com>
3059
3060         lint-test-expectations should be run during style checking
3061         https://bugs.webkit.org/show_bug.cgi?id=173559
3062         <rdar://problem/32854941>
3063
3064         Reviewed by David Kilzer.
3065
3066         Running the test expectation linter requires reading both files and lines not in the
3067         patch because, for example, deletion of a test can cause a lint failure even though
3068         no test expectations where modified. This means that the linter will occasionally warn
3069         about lines which were not changed in a given patch but whose error is related to a
3070         change made in that patch.
3071
3072         * Scripts/webkitpy/common/system/filesystem_mock.py:
3073         (MockFileSystem.open_text_file_for_reading): Add 'errors' argument to mimic filesystem.
3074         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3075         (TestExpectationWarning): Added class to pass warnings as an object instead of a string.
3076         (TestExpectationWarning.__init__): Construct warning with file name, line number, line
3077         content, description of the error and the name of the associated test.
3078         (TestExpectationWarning.__str__): Convert to string so that existing printing code works.
3079         (TestExpectationParser.__init__): Pass shorten_filename function to
3080         TestExpectationsParser to add a deleted file to the related_files dictionary.
3081         (TestExpectationParser._check_test_exists): If the test does not exist, add the
3082         missing path to the related_files dictionary.
3083         (TestExpectationLine.__init__): Add related_files dictionary, which tracks
3084         files and line numbers related to this test expectation line. This will allow
3085         tracking linter errors in the style checker occurring across multiple files.
3086         (TestExpectationsModel._already_seen_better_match): Add redundant expectation
3087         lines to related_files dictionary.
3088         (TestExpectations.__init__): Pass self._shorten_filename to TestExpectationParser.
3089         (TestExpectations._report_warnings): Construct warning object instead of string
3090         when adding to warnings list.
3091         * Scripts/webkitpy/port/win.py: Changed logging level form warning to debug to
3092         clean-up log.
3093         * Scripts/webkitpy/style/checker.py:
3094         (ProcessorBase.do_association_check): Add required function for processor classes.
3095         (StyleProcessor):
3096         (StyleProcessor.do_association_check): Run the TestExpectations linter when
3097         checking for errors between associated files.
3098         * Scripts/webkitpy/style/checkers/test_expectations.py:
3099         (TestExpectationsChecker.check_test_expectations): Reflect changed import statements.
3100         (TestExpectationsChecker):
3101         (TestExpectationsChecker._should_log_linter_warning): Given a warning, a dictionary
3102         of modified files, the current working directory and the host, determine if the linter
3103         warning is associated with the changes.
3104         (TestExpectationsChecker.lint_test_expectations): Lint test expectations for the
3105         style checker.
3106         * Scripts/webkitpy/style/filereader.py:
3107         (TextFileReader):
3108         (TextFileReader.__init__): Track modified files in dictionary instead of a counter.
3109         (TextFileReader.file_count): Use dictionary to determine the number of modified files.
3110         (TextFileReader.process_file): Track both the number of files changed and which lines
3111         in those files were changed.
3112         (TextFileReader.do_association_check): Run the processor's association check on all
3113         modified or deleted files processed by TextFileReader.
3114         (TextFileReader.delete_file): Track deleted files in _files dictionary.
3115         (TextFileReader.count_delete_only_file): Deleted.
3116         * Scripts/webkitpy/style/filereader_unittest.py:
3117         (TextFileReaderTest.test_delete_file): Renamed function to reflect new function name.
3118         (TextFileReaderTest.test_count_delete_only_file): Moved to test_delete_file.
3119         * Scripts/webkitpy/style/main.py:
3120         (CheckWebKitStyle.main): When running the style checker on a specific list of files,
3121         explicitly run the association check on the file reader.
3122         * Scripts/webkitpy/style/main_unittest.py:
3123         (ExpectationLinterInStyleCheckerTest): Added to test the TestExpectationLinter now
3124         embedded in the style checker.
3125         (ExpectationLinterInStyleCheckerTest.setUp): Set up the style checker configuration.
3126         (ExpectationLinterInStyleCheckerTest._generate_file_reader): Given a filesystem object,
3127         construct the TextFileReader object with a StyleProcessor used to run style checks on
3128         specific files.
3129         (ExpectationLinterInStyleCheckerTest._generate_testing_host): Generate a host used for
3130         testing the test expectation linter inside the style checker. This host must contain a
3131         mock file system with the basic structure of test expectations.
3132         (ExpectationLinterInStyleCheckerTest.test_no_linter_errors):
3133         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line):
3134         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_no_edit):
3135         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file):
3136         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file_no_edit):
3137         * Scripts/webkitpy/style/patchreader.py:
3138         (PatchReader.check): Specify which file was deleted, run the association check.
3139         * Scripts/webkitpy/style/patchreader_unittest.py:
3140         (PatchReaderTest.MockTextFileReader.delete_file): Renamed count_delete_only_file.
3141         (PatchReaderTest.MockTextFileReader.do_association_check): Added.
3142         (PatchReaderTest.MockTextFileReader.count_delete_only_file): Renamed delete_file.
3143
3144 2017-07-19  Yusuke Suzuki  <utatane.tea@gmail.com>
3145
3146         [WTF] Implement WTF::ThreadGroup
3147         https://bugs.webkit.org/show_bug.cgi?id=174081
3148
3149         Reviewed by Mark Lam.
3150
3151         Add WTF::ThreadGroup tests.
3152
3153         * TestWebKitAPI/CMakeLists.txt:
3154         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3155         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp: Added.
3156         (TestWebKitAPI::testThreadGroup):
3157         (TestWebKitAPI::TEST):
3158
3159 2017-07-18  Andy Estes  <aestes@apple.com>
3160
3161         [Xcode] Enable CLANG_WARN_RANGE_LOOP_ANALYSIS
3162         https://bugs.webkit.org/show_bug.cgi?id=174631
3163
3164         Reviewed by Tim Horton.
3165
3166         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3167         * MiniBrowser/Configurations/Base.xcconfig:
3168         * MobileMiniBrowser/Configurations/Base.xcconfig:
3169         * TestWebKitAPI/Configurations/Base.xcconfig:
3170         * WebKitTestRunner/Configurations/Base.xcconfig:
3171
3172 2017-07-18  Andy Estes  <aestes@apple.com>
3173
3174         [Xcode] Enable CLANG_WARN_OBJC_LITERAL_CONVERSION
3175         https://bugs.webkit.org/show_bug.cgi?id=174631
3176
3177         Reviewed by Sam Weinig.
3178
3179         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3180         * MiniBrowser/Configurations/Base.xcconfig:
3181         * MobileMiniBrowser/Configurations/Base.xcconfig:
3182         * TestWebKitAPI/Configurations/Base.xcconfig:
3183         * WebKitTestRunner/Configurations/Base.xcconfig:
3184
3185 2017-07-18  Daniel Bates  <dabates@apple.com>
3186
3187         lldb: Add type summary for StringView
3188         https://bugs.webkit.org/show_bug.cgi?id=174637
3189
3190         Reviewed by Sam Weinig.
3191
3192         For debugging convenience, adds a pretty-print type summary for StringView. Evaluating a
3193         StringView object will print output that has the form:
3194
3195             (WTF::StringView) $4 = { length = 2, contents = 'li' } {
3196               m_characters = 0x000000011b57abb5 "eeeeeefjh0n"
3197               m_length = 2
3198               m_is8Bit = true
3199               m_underlyingString = 0x0000614000000a90
3200             }
3201
3202         * lldb/lldb_webkit.py:
3203         (__lldb_init_module): Use WTFStringView_SummaryProvider to format StringView types.
3204         (WTFStringView_SummaryProvider):
3205         (WTFStringViewProvider):
3206         (WTFStringViewProvider.__init__):
3207         (WTFStringViewProvider.is_8bit): Access field StringView.m_is8Bit.
3208         (WTFStringViewProvider.get_length): Access field StringView.m_length.
3209         (WTFStringViewProvider.get_characters): Access field StringView.m_characters.
3210         (WTFStringViewProvider.to_string): Returns the string represented by the StringView.
3211
3212 2017-07-18  Andy Estes  <aestes@apple.com>
3213
3214         [Xcode] Enable CLANG_WARN_NON_LITERAL_NULL_CONVERSION
3215         https://bugs.webkit.org/show_bug.cgi?id=174631
3216
3217         Reviewed by Dan Bernstein.
3218
3219         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3220         * MiniBrowser/Configurations/Base.xcconfig:
3221         * MobileMiniBrowser/Configurations/Base.xcconfig:
3222         * TestWebKitAPI/Configurations/Base.xcconfig:
3223         * WebKitTestRunner/Configurations/Base.xcconfig:
3224
3225 2017-07-18  Devin Rousso  <drousso@apple.com>
3226
3227         Web Inspector: Add memoryCost to Inspector Protocol objects
3228         https://bugs.webkit.org/show_bug.cgi?id=174478
3229
3230         Reviewed by Joseph Pecoraro.
3231
3232         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3233         * TestWebKitAPI/Tests/JavaScriptCore/InspectorValue.cpp: Added.
3234         (TestWebKitAPI::TEST(InspectorValue, MemoryCostNull)):
3235         (TestWebKitAPI::TEST(InspectorValue, MemoryCostBoolean)):
3236         (TestWebKitAPI::TEST(InspectorValue, MemoryCostDouble)):
3237         (TestWebKitAPI::TEST(InspectorValue, MemoryCostInteger)):
3238         (TestWebKitAPI::TEST(InspectorValue, MemoryCostString)):
3239         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringEmpty)):
3240         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringNull)):
3241         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringGrowing)):
3242         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringUnicode)):
3243         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObject)):
3244         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObjectEmpty)):
3245         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObjectGrowing)):
3246         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArray)):
3247         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArrayEmpty)):
3248         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArrayGrowing)):
3249
3250 2017-07-18  Andy Estes  <aestes@apple.com>
3251
3252         [Xcode] Enable CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING
3253         https://bugs.webkit.org/show_bug.cgi?id=174631
3254
3255         Reviewed by Darin Adler.
3256
3257         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3258         * MiniBrowser/Configurations/Base.xcconfig:
3259         * MobileMiniBrowser/Configurations/Base.xcconfig:
3260         * TestWebKitAPI/Configurations/Base.xcconfig:
3261         * WebKitTestRunner/Configurations/Base.xcconfig:
3262
3263 2017-07-17  Wenson Hsieh  <wenson_hsieh@apple.com>
3264
3265         Unreviewed, fix the iOS build.
3266
3267         I missed a spot when renaming -synchronouslyLoadHTML: to -synchronouslyLoadHTMLString:.
3268
3269         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3270         (TestWebKitAPI::TEST):
3271
3272 2017-07-17  Wenson Hsieh  <wenson_hsieh@apple.com>
3273
3274         [iOS DnD] Web process uses too much memory when beginning a drag on a very large image
3275         https://bugs.webkit.org/show_bug.cgi?id=174585
3276         <rdar://problem/33302541>
3277
3278         Reviewed by Tim Horton.
3279
3280         Adds a new test verifying that we don't try to allocate any image buffer equal to the true size of the image
3281         being dragged when initiating a drag.
3282
3283         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3284         * TestWebKitAPI/Tests/WebKit2Cocoa/enormous.svg: Added.
3285         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3286         (TestWebKitAPI::TEST):
3287         * TestWebKitAPI/cocoa/TestWKWebView.h:
3288
3289         Add a new -synchronouslyLoadHTMLString: helper that works like -synchronouslyLoadTestPage:, but takes markup.
3290
3291         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3292         (-[TestWKWebView synchronouslyLoadHTMLString:]):
3293
3294 2017-07-17  Michael Catanzaro  <mcatanzaro@igalia.com>
3295
3296         [CMake] Macros in WebKitMacros.cmake should be prefixed with WEBKIT_ namespace
3297         https://bugs.webkit.org/show_bug.cgi?id=174547
3298
3299         Reviewed by Alex Christensen.
3300
3301         * DumpRenderTree/PlatformWin.cmake:
3302         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
3303
3304 2017-07-17  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
3305
3306         Update style checker to deal with "final"
3307         https://bugs.webkit.org/show_bug.cgi?id=174528
3308
3309         Reviewed by Alex Christensen.
3310         
3311         check-webkit-style shouldn't complain about an open brace to start a
3312         line after a function definition with "final" or "const final".
3313
3314         * Scripts/webkitpy/style/checkers/cpp.py:
3315         (check_braces):
3316         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3317         (CppStyleTest.test_brace_at_begin_of_line):
3318
3319 2017-07-17  Alex Christensen  <achristensen@webkit.org>
3320
3321         Modernize content extension code
3322         https://bugs.webkit.org/show_bug.cgi?id=174588
3323
3324         Reviewed by Sam Weinig.
3325
3326         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3327         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
3328         (TestWebKitAPI::testRequest):
3329         (TestWebKitAPI::makeBackend):
3330         (TestWebKitAPI::TEST_F):
3331
3332 2017-07-17  Brady Eidson  <beidson@apple.com>
3333
3334         WKHTTPCookieStore observing only works on the default cookie store.
3335         <rdar://problem/33330724> and https://bugs.webkit.org/show_bug.cgi?id=174580
3336
3337         Reviewed by Sam Weinig.
3338
3339         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
3340         (runTestWithWebsiteDataStore): Refactor the cookie observing test out so it can be
3341           called for the default store, a non-persistent store, and a custom store.
3342         (TEST):
3343
3344 2017-07-16  Sam Weinig  <sam@webkit.org>
3345
3346         [Scripts] Fix missing variable warnings from svn-create-patch when there are untracked files
3347         https://bugs.webkit.org/show_bug.cgi?id=174575
3348
3349         Reviewed by Brady Eidson.
3350
3351         * Scripts/svn-create-patch:
3352         (findModificationType):
3353         Add support for more status codes. C -> conflicted, ? -> untracked, ! -> missing. Give a
3354         default value of "unknown".
3355
3356         (generateFileList):
3357         Handle all the new modification types. Abort on conflicted, missing, and unknown. Log
3358         for untracked, which matches our old behavior.
3359
3360 2017-07-17  Charlie Turner  <cturner@igalia.com>
3361
3362         Add some missing build dependencies on Fedora
3363         https://bugs.webkit.org/show_bug.cgi?id=174578
3364
3365         Unreviewed dependency update.
3366
3367         * gtk/install-dependencies:
3368
3369 2017-07-16  Brady Eidson  <beidson@apple.com>
3370
3371         Crash when a WKHTTPCookieStore outlives its owning WKWebsiteDataStore.
3372         <rdar://problem/33341730> and https://bugs.webkit.org/show_bug.cgi?id=174574
3373
3374         Reviewed by Tim Horton.
3375
3376         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
3377         (-[CookieNavigationDelegate webView:didFinishNavigation:]):
3378         (TEST):
3379
3380 2017-07-16  Bernhard M. Wiedemann  <bwiedemann@suse.de>
3381
3382         [GTK] Sort inspector GResource manifest to ensure reproducible builds
3383         https://bugs.webkit.org/show_bug.cgi?id=174540
3384
3385         Reviewed by Michael Catanzaro.
3386
3387         * gtk/generate-inspector-gresource-manifest.py:
3388         (get_filenames): sort list of input files
3389
3390 2017-07-15  Brady Eidson  <beidson@apple.com>
3391
3392         Make sure all CFHTTPCookieStorageRefs we create are scheduled.
3393         <rdar://problem/33221110> and https://bugs.webkit.org/show_bug.cgi?id=174513
3394
3395         Reviewed by Tim Horton.
3396
3397         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
3398         (TEST): Make this test more reliable by clearing everything beforehand.
3399
3400 2017-07-15  David Kilzer  <ddkilzer@apple.com>
3401
3402         Make it possible to extend check-webkit-style with Apple-internal checkers
3403         <https://webkit.org/b/174464>
3404         <rdar://problem/25564402>
3405
3406         Reviewed by Darin Adler.
3407
3408         * Scripts/webkitpy/style/checker.py: Import apple_additions.
3409         (_all_categories): Add categories from apple_additions() if it
3410         exists.
3411         (CheckerDispatcher._create_checker): Create python checker
3412         from apple_additions() if it exists.
3413
3414 2017-07-15  Wenson Hsieh  <wenson_hsieh@apple.com>
3415
3416         [iOS WK2] Presenting an action sheet on an image map prevents selection UI from updating
3417         https://bugs.webkit.org/show_bug.cgi?id=174539
3418         <rdar://problem/33307395>
3419
3420         Reviewed by Darin Adler.
3421
3422         Adds a new unit test suite to cover action sheet popover presentation.
3423
3424         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3425         * TestWebKitAPI/Tests/WebKit2Cocoa/image-map.html: Added.
3426         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm: Added.
3427         (-[ActionSheetObserver waitForActionSheetAfterBlock:]):
3428
3429         Runs the given block and waits until the UI process has indicated that it will present an action sheet.
3430
3431         (-[ActionSheetObserver _webView:actionsForElement:defaultActions:]):
3432         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
3433
3434         Helper class to alter the behavior of [[UIDevice currentDevice] userInterfaceIdiom] for testing.
3435
3436         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
3437         (TestWebKitAPI::TEST):
3438
3439 2017-07-15  Sam Weinig  <sam@webkit.org>
3440
3441         [Scripts] Make svn-create-patch work better when called in sub directories
3442         https://bugs.webkit.org/show_bug.cgi?id=174551
3443
3444         Reviewed by Darin Adler.
3445
3446         - Fixes manufacturePatchForAdditionWithHistory to use the correct path
3447           by ensuring that the prefix is applied as is done in generateDiff.
3448         - Silence output of explanatory lines from svn stat (" > move to ...")
3449           that show up in STDERR when running svn-create-patch.
3450         - Add verbose logging that I found useful while debugging this issue.
3451
3452         * Scripts/svn-create-patch:
3453         (findBaseUrl):
3454         (findMimeType):
3455         (findSourceFileAndRevision):
3456         (generateDiff):
3457         (generateFileList):
3458         (manufacturePatchForAdditionWithHistory):
3459
3460 2017-07-15  Jonathan Bedard  <jbedard@apple.com>
3461
3462         Unreviewed build fix after r219537.
3463
3464         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3465
3466 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
3467
3468         Add iOS 11 SPI
3469         https://bugs.webkit.org/show_bug.cgi?id=174430
3470         <rdar://problem/33269288>
3471
3472         Reviewed by Tim Horton.
3473
3474         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm: Define drag-and-drop API required for testing.
3475         * TestWebKitAPI/ios/DataInteractionSimulator.h: Ditto.
3476         * TestWebKitAPI/ios/DataInteractionSimulator.mm: Ditto.
3477
3478 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
3479
3480         Failing to install on iPad simulators
3481         https://bugs.webkit.org/show_bug.cgi?id=174532
3482         <rdar://problem/33328347>
3483
3484         Reviewed by Stephanie Lewis.
3485
3486         * Scripts/webkitpy/xcode/simulated_device.py:
3487         (SimulatedDevice.install_app): Place install command in retry try-except block.
3488
3489 2017-07-14  Jeff Miller  <jeffm@apple.com>
3490
3491         Add test for -[WKProcessPool _setObjectsForBundleParametersWithDictionary:].
3492         https://bugs.webkit.org/show_bug.cgi?id=174524
3493
3494         Reviewed by Sam Weinig.
3495
3496         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm:
3497         (TEST):
3498         Renamed TestParameter to TestParameter1.
3499         Add test for -[WKProcessPool _setObjectsForBundleParametersWithDictionary:].
3500
3501         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm:
3502         (-[BundleParametersPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
3503         Observe changes for two bundle parameters.
3504
3505         (-[BundleParametersPlugIn dealloc]):
3506         Remove observers for two bundle parameters.
3507
3508 2017-07-14  Commit Queue  <commit-queue@webkit.org>
3509
3510         Unreviewed, rolling out r219510.
3511         https://bugs.webkit.org/show_bug.cgi?id=174525
3512
3513         Need to revert length() == 0 check for null string (Requested
3514         by yusukesuzuki on #webkit).
3515
3516         Reverted changeset:
3517
3518         "[WTF] Newly added AtomicStringImpl should use BufferInternal
3519         static string if StringImpl is static"
3520         https://bugs.webkit.org/show_bug.cgi?id=174501
3521         http://trac.webkit.org/changeset/219510
3522
3523 2017-07-14  Jer Noble  <jer.noble@apple.com>
3524
3525         [MSE] Removing samples when presentation order does not match decode order can cause bad behavior.
3526         https://bugs.webkit.org/show_bug.cgi?id=174514
3527
3528         Reviewed by Sam Weinig.
3529
3530         * TestWebKitAPI/Tests/WebCore/SampleMap.cpp:
3531         (TestWebKitAPI::TEST_F):
3532
3533 2017-07-14  Yusuke Suzuki  <utatane.tea@gmail.com>
3534
3535         [WTF] Newly added AtomicStringImpl should use BufferInternal static string if StringImpl is static
3536         https://bugs.webkit.org/show_bug.cgi?id=174501
3537
3538         Reviewed by Darin Adler.
3539
3540         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3541         (TestWebKitAPI::TEST):
3542
3543 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
3544
3545         Bring mac expectations in-line with other platforms
3546         https://bugs.webkit.org/show_bug.cgi?id=174472
3547         <rdar://problem/33297388>
3548
3549         Reviewed by David Kilzer.
3550
3551         The override order for Mac test expectations does not conform to the pattern used by iOS,
3552         GTK, Windows and WPE. Before this change, El Capitan's baseline search path looks like this:
3553
3554             platform/mac-wk2
3555             platform/wk2
3556             platform/mac-elcapitan
3557             platform/mac-sierra
3558             generic
3559
3560         After this change, El Capitan's baseline search path looks like this:
3561
3562             platform/mac-sierra-wk2
3563             platform/mac-sierra
3564             platform/mac-wk2
3565             platform/wk2
3566             generic
3567
3568         * Scripts/webkitpy/port/mac.py:
3569         (MacPort.__init__): If a specific version is specified in the port name, use that
3570         as the os version.
3571         (MacPort.default_baseline_search_path): Expectation search paths should work the
3572         same way they do on other ports. Port + version overrides port, port overrides generic
3573         and wk1/wk2 should override expectations for the two combined.
3574         * Scripts/webkitpy/port/mac_unittest.py:
3575         (MacTest.test_tests_for_other_platforms): Deleted.
3576         (MacTest._assert_search_path): Deleted.
3577         (MacTest.test_baseline_search_path): Deleted.
3578         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3579         (TestRebaselineTest.test_baseline_directory): Adjust expectations for new over-ride order.
3580         (test_rebaseline_test_and_print_scm_changes): Ditto.
3581         (test_rebaseline_and_copy_test): Ditto.
3582         (test_rebaseline_and_copy_test_no_existing_result): Ditto.
3583         (test_rebaseline_and_copy_test_with_lion_result): Ditto.
3584         (test_rebaseline_and_copy_no_overwrite_test): Ditto.
3585
3586 2017-07-13  Michael Catanzaro  <mcatanzaro@igalia.com>
3587
3588         Fix style checker unit test
3589
3590         Unreviewed WebKit2 => WebKit fixup.
3591
3592         * Scripts/webkitpy/style/checker_unittest.py:
3593         (CheckerDispatcherSkipTest.test_should_skip_with_warning):
3594
3595 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
3596
3597         Use the old WebKit/WebKit2 targets for CMake builds. (v2)
3598
3599         Unreviewed build fix.
3600
3601         r219492 missed one hunk from its partial revert of r219489.
3602         This patch reverts that hunk.
3603
3604         * TestWebKitAPI/CMakeLists.txt:
3605
3606 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
3607
3608         Use the old WebKit/WebKit2 targets for CMake builds.
3609
3610         Unreviewed build fix.
3611
3612         We can update the target names to match the Framework names in a future patch.
3613         This is a partial revert of r219489.
3614
3615         * TestWebKitAPI/CMakeLists.txt:
3616         WebKitLegacy => WebKit
3617         WebKit => WebKit2
3618
3619 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
3620
3621         Fix TestWebKit API.
3622         https://bugs.webkit.org/show_bug.cgi?id=174164
3623         rdar://problem/33137595
3624
3625         Reviewed by Dan Bernstein.
3626
3627         * TestWebKitAPI/CMakeLists.txt:
3628         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3629         * TestWebKitAPI/PlatformGTK.cmake:
3630
3631 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
3632
3633         Update tools and configurations after renaming Source/WebKit2 to Source/WebKit.
3634         https://bugs.webkit.org/show_bug.cgi?id=174164
3635         rdar://problem/33137595
3636
3637         Reviewed by Dan Bernstein.
3638
3639         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
3640         (ShouldBuildTest):
3641         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3642         * Scripts/build-webkit:
3643         * Scripts/do-file-rename:
3644         * Scripts/do-webcore-rename:
3645         * Scripts/update-webkit-localizable-strings:
3646         * Scripts/webkitpy/common/config/watchlist:
3647         * Scripts/webkitpy/style/checker.py:
3648         * Scripts/webkitpy/style/checkers/featuredefines.py:
3649         * gtk/make-dist.py:
3650         (ensure_version_if_possible):
3651         * gtk/manifest.txt.in:
3652
3653 2017-07-05  Matthew Hanson  <matthew_hanson@apple.com>
3654
3655         Update tools and configurations after renaming Source/WebKit to Source/WebKitLegacy.
3656         https://bugs.webkit.org/show_bug.cgi?id=174162
3657         rdar://problem/33137594
3658
3659         Reviewed by Dan Bernstein.
3660
3661         Mass rename of Source/WebKit to Source/WebKitLegacy in OpenSource tooling.
3662
3663         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
3664         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
3665         * EWSTools/configure-clang-linux.sh:
3666         * Scripts/build-webkit:
3667         * Scripts/do-file-rename:
3668         * Scripts/do-webcore-rename:
3669         * Scripts/update-webkit-localizable-strings:
3670         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3671         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
3672         * Scripts/webkitpy/style/checkers/featuredefines.py:
3673         * gtk/manifest.txt.in:
3674
3675 2017-07-13  Jonathan Bedard  <jbedard@apple.com>
3676
3677         Add script to rebase patches during the WebKit2->WebKit/WebKit->WebKitLegacy transition
3678         https://bugs.webkit.org/show_bug.cgi?id=174438
3679         <rdar://problem/33277112>
3680
3681         Reviewed by Aakash Jain.
3682
3683         Given a patch, this will convert the changes from the path to the new directory structure.
3684
3685         * Scripts/rebase-patch-after-webkit-move: Added.
3686         (append_source): Append 'Source' to the provided path.
3687         (is_editable_line): Return true if a line the script expects to modify.
3688         (needs_rebase): Return if a line needs to be rebased based on it's content.
3689         (rebase_line): Rebase the provided line.
3690         (rebase): Rebase a patch given the lines of that patch and a file to output the rebased patch to.
3691         (parse_arguments): Parse the command line arguments and return the patches to be rebased, if they
3692         were provided.
3693
3694 2017-07-12  Nan Wang  <n_wang@apple.com>
3695
3696         AX: [iOS] Implement a way to retrieve a text marker range with desired text that is closest to a position
3697         https://bugs.webkit.org/show_bug.cgi?id=174393
3698         <rdar://problem/33248006>
3699
3700         Reviewed by Chris Fleizach.
3701
3702         * DumpRenderTree/AccessibilityUIElement.cpp:
3703         (textMarkerRangeMatchesTextNearMarkersCallback):
3704         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3705         (AccessibilityUIElement::getJSClass):
3706         * DumpRenderTree/AccessibilityUIElement.h:
3707         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3708         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3709         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3710         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3711         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3712         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3713         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3714         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3715
3716 2017-07-12  Matt Lewis  <jlewis3@apple.com>
3717
3718         Unreviewed, rolling out r219409.
3719
3720         The revision caused the Windows builds to fail.
3721
3722         Reverted changeset:
3723
3724         "AX: [iOS] Implement a way to retrieve a text marker range
3725         with desired text that is closest to a position"
3726         https://bugs.webkit.org/show_bug.cgi?id=174393
3727         http://trac.webkit.org/changeset/219409
3728
3729 2017-07-12  Nan Wang  <n_wang@apple.com>
3730
3731         AX: [iOS] Implement a way to retrieve a text marker range with desired text that is closest to a position
3732         https://bugs.webkit.org/show_bug.cgi?id=174393
3733         <rdar://problem/33248006>
3734
3735         Reviewed by Chris Fleizach.
3736
3737         * DumpRenderTree/AccessibilityUIElement.cpp:
3738         (textMarkerRangeMatchesTextNearMarkersCallback):
3739         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3740         (AccessibilityUIElement::getJSClass):
3741         * DumpRenderTree/AccessibilityUIElement.h:
3742         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3743         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3744         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3745         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3746         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3747         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3748         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3749         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3750
3751 2017-07-12  Emilio Cobos Álvarez  <ecobos@igalia.com>
3752
3753         Make prepare-ChangeLog -g <commit> generate a more standard ChangeLog entry.
3754         https://bugs.webkit.org/show_bug.cgi?id=174197
3755
3756         Reviewed by Darin Adler.
3757
3758         This bit me the first time I tried to submit a patch to WebKit, and still I have
3759         to manually edit the ChangeLog every time I use the script.
3760
3761         This generates a more convenient and standard ChangeLog entry.
3762
3763         * Scripts/prepare-ChangeLog:
3764         (generateNewChangeLogs):
3765
3766 2017-07-12  Matt Lewis  <jlewis3@apple.com>
3767
3768         Unreviewed, rolling out r219401.
3769
3770         This revision rolled out the previous patch, but after talking
3771         with reviewer, a rebaseline is what was needed.Rolling back in
3772         before rebaseline.
3773
3774         Reverted changeset:
3775
3776         "Unreviewed, rolling out r219379."
3777         https://bugs.webkit.org/show_bug.cgi?id=174400
3778         http://trac.webkit.org/changeset/219401
3779
3780 2017-07-12  Matt Lewis  <jlewis3@apple.com>
3781
3782         Unreviewed, rolling out r219379.
3783
3784         This revision caused a consistent failure in the test
3785         fast/dom/Window/property-access-on-cached-window-after-frame-
3786         removed.html.
3787
3788         Reverted changeset:
3789
3790         "Remove NAVIGATOR_HWCONCURRENCY"
3791         https://bugs.webkit.org/show_bug.cgi?id=174400
3792         http://trac.webkit.org/changeset/219379
3793
3794 2017-07-12  Zan Dobersek  <zdobersek@igalia.com>
3795
3796         [WPE] Use libepoxy
3797         https://bugs.webkit.org/show_bug.cgi?id=172104
3798
3799         Reviewed by Michael Catanzaro.
3800
3801         * WebKitTestRunner/wpe/HeadlessViewBackend.h:
3802         Include the <epoxy/egl.h> header, dropping the EGL and GLES2 inclusions.
3803
3804 2017-07-12  Zan Dobersek  <zdobersek@igalia.com>
3805
3806         [GTK][WPE] Align Jhbuild patches for GStreamer packages
3807         https://bugs.webkit.org/show_bug.cgi?id=174363
3808
3809         Reviewed by Michael Catanzaro.
3810
3811         Align the patches we apply over Jhbuild-managed GStreamer dependency packages
3812         between the GTK+ and WPE port. There's no reason for the two ports to apply
3813         different patches over same versions of GStreamer releases.
3814
3815         This aligns the two ports on this specific issue. Next we'll look into
3816         creating a single GStreamer-specific Jhbuild moduleset that will allow us
3817         to keep these patches in a single place, avoiding duplicate files.
3818
3819         * gtk/jhbuild.modules:
3820         * gtk/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Added.
3821         * gtk/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch.
3822         * gtk/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Added.
3823         * wpe/patches/gstreamer-typefind-Only-push-a-CAPS-event-downstream-if-the-.patch: Removed.
3824
3825 2017-07-11  Dean Jackson  <dino@apple.com>
3826
3827         Remove NAVIGATOR_HWCONCURRENCY
3828         https://bugs.webkit.org/show_bug.cgi?id=174400
3829
3830         Reviewed by Sam Weinig.
3831
3832         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3833
3834 2017-07-11  Ansh Shukla  <ansh_shukla@apple.com>
3835
3836         WKWindowFeatures needs to expose scrollbar, fullscreen, and dialog configuration properties
3837         https://bugs.webkit.org/show_bug.cgi?id=174239
3838
3839         Reviewed by Brady Eidson.
3840
3841         Create windows with specific features set and make sure those are properly reflected in the
3842         WKWindowFeatures object.
3843
3844         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
3845         (resetToConsistentState):
3846         (-[CheckWindowFeaturesUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3847         (TEST):
3848
3849 2017-07-11  Jonathan Bedard  <jbedard@apple.com>
3850
3851         Do not duplicate files when deleting directories with svn 1.9
3852         https://bugs.webkit.org/show_bug.cgi?id=174339
3853         <rdar://problem/33226781>
3854
3855         Reviewed by David Kilzer.
3856
3857         * Scripts/svn-create-patch:
3858         (diffOptionsForFile): No longer pass -N option, since this does not work in SVN 1.9.4.
3859         (generateFileList): Determine which files are deleted because they are part of a
3860         directory being deleted.
3861
3862 2017-07-11  Dean Jackson  <dino@apple.com>
3863
3864         Rolling out r219372.
3865
3866         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3867
3868 2017-07-11  Dean Jackson  <dino@apple.com>
3869
3870         Remove NAVIGATOR_HWCONCURRENCY
3871         https://bugs.webkit.org/show_bug.cgi?id=174400
3872
3873         Reviewed by Sam Weinig.
3874
3875         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3876
3877 2017-07-11  Lucas Forschler  <lforschler@apple.com>
3878
3879         Teach build workers to fetch archives from S3.
3880         https://bugs.webkit.org/show_bug.cgi?id=174384
3881
3882         Reviewed by Aakash Jain.
3883
3884         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3885         (DownloadBuiltProduct):
3886
3887 2017-07-11  Lucas Forschler  <lforschler@apple.com>
3888
3889         Configure buildbot to transfer all archives to S3.
3890         Previously this was Mac only, but it's time to expand!
3891         https://bugs.webkit.org/show_bug.cgi?id=174378
3892         
3893         Reviewed by Aakash Jain.
3894
3895         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3896         (BuildFactory.__init__):
3897
3898 2017-07-11  Zan Dobersek  <zdobersek@igalia.com>
3899
3900         [WPE] Bump GStreamer packages in jhbuild.modules to 1.10.5
3901         https://bugs.webkit.org/show_bug.cgi?id=174350
3902
3903         Reviewed by Xabier Rodriguez-Calvar.
3904
3905         Bump the various GStreamer dependencies listed in WPE's Jhbuild modules file
3906         to the 1.10.5 version. One gstreamer patch is added. The two gst-plugins-bad
3907         patches are removed. The patches for gst-plugins-good are updated, removing
3908         the stale ones and adding the additional changes to qtdemux, souphttpsrc and
3909         rtpbin elements that will help with the EMEv3 development.
3910
3911         * wpe/jhbuild.modules:
3912         * wpe/patches/gst-plugins-bad-0001-dtls-port-to-OpenSSL-1.1.0.patch: Removed.
3913         * wpe/patches/gst-plugins-bad-0002-dtlscertificate-Fix-error-checking-in-RSA_generate_k.patch: Removed.
3914         * wpe/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Added.
3915         * wpe/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Added.
3916         * wpe/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Added.
3917         * wpe/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Added.
3918         * wpe/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Removed.
3919         * wpe/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Removed.
3920         * wpe/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Added.
3921
3922 2017-07-10  John Wilander  <wilander@apple.com>
3923
3924         Resource Load Statistics: Prune statistics in orders of importance
3925         https://bugs.webkit.org/show_bug.cgi?id=174215
3926         <rdar://problem/33164403>
3927
3928         Reviewed by Chris Dumez.
3929
3930         Nest infrastructure. Adds these functions:
3931         1. testRunner.setStatisticsLastSeen()
3932         2. setStatisticsMaxStatisticsEntries()
3933         3. setStatisticsPruneEntriesDownTo()
3934
3935         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3936         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3937         (WTR::TestRunner::setStatisticsLastSeen):
3938         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
3939         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
3940         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3941         * WebKitTestRunner/TestController.cpp:
3942         (WTR::TestController::setStatisticsLastSeen):
3943         (WTR::TestController::setMaxStatisticsEntries):
3944         (WTR::TestController::setPruneEntriesDownTo):
3945         * WebKitTestRunner/TestController.h:
3946         * WebKitTestRunner/TestInvocation.cpp:
3947         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3948         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3949         (WTR::TestController::setStatisticsLastSeen):
3950         (WTR::TestController::setStatisticsMaxStatisticsEntries):
3951         (WTR::TestController::setStatisticsPruneEntriesDownTo):
3952
3953 2017-07-03  Brian Burg  <bburg@apple.com>
3954
3955         Web Replay: remove some unused code
3956         https://bugs.webkit.org/show_bug.cgi?id=173903
3957
3958         Rubber-stamped by Joseph Pecoraro.
3959
3960         * Scripts/run-input-generator-tests: Removed.
3961         * Scripts/webkitpy/replay/__init__.py: Removed.
3962         * Scripts/webkitpy/replay/main.py: Removed.
3963
3964 2017-07-10  Zan Dobersek  <zdobersek@igalia.com>
3965
3966         [WPE] Fix layout test baseline and TestExpectations hierarchy
3967         https://bugs.webkit.org/show_bug.cgi?id=174092
3968
3969         Reviewed by Michael Catanzaro.
3970
3971         Like for the GTK+ port, override the default_baseline_search_path() and
3972         _port_specific_expectations_files() methods in the webkitpy.port.WPEPort class.
3973         Both methods operate on a short list of search paths that defaults to 'wpe' and
3974         'wk2', along with any other user-specified platform directory.
3975
3976         The test_expectations_file_position() method is overridden for testing purposes,
3977         and relevant unit tests are added.
3978
3979         * Scripts/webkitpy/port/wpe.py:
3980         (WPEPort._search_paths):
3981         (WPEPort):
3982         (WPEPort.default_baseline_search_path):
3983         (WPEPort._port_specific_expectations_files):
3984         (WPEPort.test_expectations_file_position):
3985         * Scripts/webkitpy/port/wpe_unittest.py:
3986         (WPEPortTest.test_default_baseline_search_path):
3987         (WPEPortTest):
3988         (WPEPortTest.test_port_specific_expectations_files):
3989
3990 2017-07-10  Chris Dumez  <cdumez@apple.com>
3991
3992         Further WebResourceLoadStatisticsStore / ResourceLoadStatisticsStore clean up
3993         https://bugs.webkit.org/show_bug.cgi?id=174301
3994
3995         Reviewed by Brent Fulgham.
3996
3997         Rename some of the testRunner API for clarity and to better match what it calls
3998         internally.
3999
4000         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4001         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4002         (WTR::TestRunner::statisticsUpdateCookiePartitioning):
4003         (WTR::TestRunner::statisticsSetShouldPartitionCookiesForHost):
4004         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4005         * WebKitTestRunner/TestController.cpp:
4006         (WTR::TestController::statisticsUpdateCookiePartitioning):
4007         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
4008         * WebKitTestRunner/TestController.h:
4009         * WebKitTestRunner/TestInvocation.cpp:
4010         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
4011         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4012         (WTR::TestController::statisticsUpdateCookiePartitioning):
4013         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
4014
4015 2017-07-10  Charlie Turner  <cturner@igalia.com>
4016
4017         [GStreamer] Live twitch.tv videos do not play
4018         https://bugs.webkit.org/show_bug.cgi?id=174222
4019
4020         Reviewed by Michael Catanzaro.
4021
4022         Upgrade GStreamer to 1.10.5. It contains a change to typefind that
4023         fixes videos not playing on twitch.tv.
4024
4025         * gtk/jhbuild.modules:
4026
4027 2017-07-09  Zan Dobersek  <zdobersek@igalia.com>
4028
4029         Add WebGL2 configuration option to build-webkit
4030         https://bugs.webkit.org/show_bug.cgi?id=174251
4031
4032         Reviewed by Michael Catanzaro.
4033
4034         * Scripts/webkitperl/FeatureList.pm: Add the 'webgl2' option, making it possible
4035         to enable the ENABLE_WEBGL2 flag through the build-webkit script. The feature
4036         is marked as enabled for the Apple Cocoa ports.
4037
4038 2017-07-08  Chris Dumez  <cdumez@apple.com>
4039
4040         Simplify WebResourceLoadStatisticsStore / ResourceLoadStatisticsStore
4041         https://bugs.webkit.org/show_bug.cgi?id=174290
4042
4043         Reviewed by Brent Fulgham.
4044
4045         Rename testRunner API to match the new internal API names.
4046
4047         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4048         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4049         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
4050         (WTR::TestRunner::statisticsSubmitTelemetry):
4051         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4052         * WebKitTestRunner/TestController.cpp:
4053         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
4054         (WTR::TestController::statisticsSubmitTelemetry):
4055         * WebKitTestRunner/TestController.h:
4056         * WebKitTestRunner/TestInvocation.cpp:
4057         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
4058         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4059         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
4060         (WTR::TestController::statisticsSubmitTelemetry):
4061
4062 2017-07-08  Yusuke Suzuki  <utatane.tea@gmail.com>
4063
4064         Drop NOSNIFF compile flag
4065         https://bugs.webkit.org/show_bug.cgi?id=174289
4066
4067         Reviewed by Michael Catanzaro.
4068
4069         * Scripts/webkitperl/FeatureList.pm:
4070         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4071
4072 2017-07-07  Wenson Hsieh  <wenson_hsieh@apple.com>
4073
4074         [iOS DnD] For cross-app drags, 'drop' event handlers are never invoked if dataTransfer.dropEffect is not set while dragging
4075         https://bugs.webkit.org/show_bug.cgi?id=174219
4076         <rdar://problem/32083177>
4077
4078         Reviewed by Ryosuke Niwa.
4079
4080         Add plumbing and support to mock the value of -allowsMoveOperation on the simulated UIDragDropSession objects.
4081         Setting the DataInteractionSimulator's shouldAllowMoveOperation property to NO simulates a drag operation coming
4082         in from another app out-of-process, for which move operations won't cause a drop to be performed in the first
4083         place.
4084
4085         Also tweaks 2 existing unit tests regarding file uploads via JavaScript to simulate items coming in from a
4086         different application, and adds a new test to check that if a drop area specifically requests a MOVE operation,
4087         no action is taken when dropping.
4088
4089         * TestWebKitAPI/Tests/WebKit2Cocoa/file-uploading.html:
4090         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
4091         (TestWebKitAPI::TEST):
4092         * TestWebKitAPI/ios/DataInteractionSimulator.h:
4093         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
4094         (-[MockDragDropSession initWithItems:location:window:allowMove:]):
4095         (-[MockDragDropSession allowsMoveOperation]):
4096         (-[MockDataOperationSession initWithProviders:location:window:allowMove:]):
4097         (-[MockDataInteractionSession initWithWindow:allowMove:]):
4098         (-[DataInteractionSimulator initWithWebView:]):
4099         (-[DataInteractionSimulator runFrom:to:]):
4100         (-[DataInteractionSimulator _advanceProgress]):
4101         (-[MockDragDropSession initWithItems:location:window:]): Deleted.
4102         (-[MockDataOperationSession initWithProviders:location:window:]): Deleted.
4103         (-[MockDataInteractionSession initWithWindow:]): Deleted.
4104
4105 2017-07-07  Commit Queue  <commit-queue@webkit.org>
4106
4107         Unreviewed, rolling out r219238, r219239, and r219241.
4108         https://bugs.webkit.org/show_bug.cgi?id=174265
4109
4110         "fast/workers/dedicated-worker-lifecycle.html is flaky"
4111         (Requested by yusukesuzuki on #webkit).
4112
4113         Reverted changesets:
4114
4115         "[WTF] Implement WTF::ThreadGroup"
4116         https://bugs.webkit.org/show_bug.cgi?id=174081
4117         http://trac.webkit.org/changeset/219238
4118
4119         "Unreviewed, build fix after r219238"
4120         https://bugs.webkit.org/show_bug.cgi?id=174081
4121         http://trac.webkit.org/changeset/219239
4122
4123         "Unreviewed, CLoop build fix after r219238"
4124         https://bugs.webkit.org/show_bug.cgi?id=174081
4125         http://trac.webkit.org/changeset/219241
4126
4127 2017-07-07  Yusuke Suzuki  <utatane.tea@gmail.com>
4128
4129         [GTK][WPE] Enable X-Content-Type-Options: nosniff
4130         https://bugs.webkit.org/show_bug.cgi?id=174250
4131
4132         Reviewed by Carlos Alberto Lopez Perez.
4133
4134         * Scripts/webkitperl/FeatureList.pm:
4135
4136 2017-07-07  Charlie Turner  <cturner@igalia.com>
4137         [GStreamer] vid.me videos do not play
4138         https://bugs.webkit.org/show_bug.cgi?id=172240
4139
4140         Reviewed by Xabier Rodriguez-Calvar.
4141
4142         Build httpsoupsrc again for use in adaptive streaming pipelines, and
4143         have the existing libsoup build against GNOME to avoid header drift
4144         against GStreamer's linked Soup library.
4145
4146         * gtk/jhbuild.modules:
4147
4148 2017-07-06  Lucas Forschler  <lforschler@apple.com>
4149
4150         Write a support script to enable buildbot to upload to S3
4151         https://bugs.webkit.org/show_bug.cgi?id=174196
4152         
4153         Reviewed by Stephanie Lewis.
4154
4155         * BuildSlaveSupport/build.webkit.org-config/transfer-archive-to-s3: Added.
4156         (uploadToS3):
4157         (archiveExists):
4158
4159 2017-07-06  Lucas Forschler  <lforschler@apple.com>
4160
4161         Enabling uploading archives to S3.
4162         https://bugs.webkit.org/show_bug.cgi?id=174198
4163         
4164         Reviewed by Stephanie Lewis.
4165
4166         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4167         (ArchiveMinifiedBuiltProduct): Create a minified archive from a full archive
4168         (UploadMinifiedBuiltProduct): Upload minified archive to build master
4169         (TransferToS3): Transfer full and minified archives to S3
4170
4171 2017-07-05  Yusuke Suzuki  <utatane.tea@gmail.com>
4172
4173         [WTF] Implement WTF::ThreadGroup
4174         https://bugs.webkit.org/show_bug.cgi?id=174081
4175
4176         Reviewed by Mark Lam.
4177
4178         Add WTF::ThreadGroup tests.
4179
4180         * TestWebKitAPI/CMakeLists.txt:
4181         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4182         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp: Added.
4183         (TestWebKitAPI::TEST):
4184
4185 2017-07-06  Yusuke Suzuki  <utatane.tea@gmail.com>
4186
4187         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
4188         https://bugs.webkit.org/show_bug.cgi?id=174150
4189
4190         Reviewed by Mark Lam.
4191
4192         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
4193         (TestWebKitAPI::TEST):
4194         * TestWebKitAPI/TestsController.cpp:
4195         (TestWebKitAPI::TestsController::TestsController):
4196
4197 2017-07-06  Lucas Forschler  <lforschler@apple.com>
4198
4199         Enabling uploading archives to S3.
4200         https://bugs.webkit.org/show_bug.cgi?id=174198
4201         
4202         Reviewed by Lucas Forschler.
4203
4204         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4205         (ArchiveMinifiedBuiltProduct): Create a minified archive from a full archive
4206         (UploadMinifiedBuiltProduct): Upload minified archive to build master
4207         (TransferToS3): Transfer full and minified archives to S3
4208
4209 2017-07-06  Carlos Alberto Lopez Perez  <clopez@igalia.com>
4210
4211         [GTK][WPE] kill-old-process should kill more webkit related process
4212         https://bugs.webkit.org/show_bug.cgi?id=174220
4213
4214         Reviewed by Michael Catanzaro.
4215
4216         Generate list of possible webkit-related process names and add
4217         them to the list of process to kill.
4218         Also update the possible system related process for GTK+/WPE.
4219
4220         * BuildSlaveSupport/kill-old-processes:
4221         (listAllWebKitPrograms):
4222         (main):
4223
4224 2017-07-06  Chris Dumez  <cdumez@apple.com>
4225
4226         FileMonitor should not be ref counted
4227         https://bugs.webkit.org/show_bug.cgi?id=174166
4228
4229         Reviewed by Brent Fulgham.
4230
4231         Update the API tests to reflect the API change.
4232
4233         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
4234         (TestWebKitAPI::TEST_F):
4235
4236 2017-07-06  Commit Queue  <commit-queue@webkit.org>
4237
4238         Unreviewed, rolling out r219194.
4239         https://bugs.webkit.org/show_bug.cgi?id=174207
4240
4241         it broke some layout tests (Requested by clopez on #webkit).
4242
4243         Reverted changeset:
4244
4245         "[GStreamer] vid.me videos do not play"
4246         https://bugs.webkit.org/show_bug.cgi?id=172240
4247         http://trac.webkit.org/changeset/219194
4248
4249 2017-07-06  Matt Lewis  <jlewis3@apple.com>
4250
4251         Unreviewed, rolling out r219178.
4252
4253         This caused a consistent failure with the API test
4254         StringBuilderTest.ToAtomicStringOnEmpty on all Debug testers.
4255
4256         Reverted changeset:
4257
4258         "[WTF] Clean up StringStatics.cpp by using
4259         LazyNeverDestroyed<> for Atoms"
4260         https://bugs.webkit.org/show_bug.cgi?id=174150
4261         http://trac.webkit.org/changeset/219178
4262
4263 2017-07-06  Alicia Boya García  <aboya@igalia.com>
4264
4265         Add CWD to Perl library path (no longer the default since 5.26.0)
4266         https://bugs.webkit.org/show_bug.cgi?id=174200
4267