e4841e2133549857d723ca905f80472938926b92
[WebKit-https.git] / Tools / ChangeLog
1 2020-03-23  Daniel Bates  <dabates@apple.com>
2
3         Support inserting text or dictation alternative by simulating keyboard input
4         https://bugs.webkit.org/show_bug.cgi?id=209380
5         <rdar://problem/59445102>
6
7         Reviewed by Darin Adler.
8
9         Add tests to ensure that DOM events are dispatched on insertion when shouldSimulateKeyboardInput
10         is enabled.
11
12         I also added a convenience assertion function, EXPECT_NS_EQUAL, that can
13         compare NSObjects so long as they implement -isEqual and -description. I
14         make use of this to compare the actual array of fired DOM events types to
15         an expected array.
16
17         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
18         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
19         (TestWebKitAPI::shouldSimulateKeyboardInputOnTextInsertionOverride):
20         (TestWebKitAPI::TEST):
21         * TestWebKitAPI/cocoa/TestCocoa.h:
22         (TestWebKitAPI::Util::assertNSObjectsAreEqual): Added.
23         (EXPECT_NS_EQUAL): Added.
24         * TestWebKitAPI/ios/insert-text.html: Added.
25
26 2020-03-23  Kate Cheney  <katherine_cheney@apple.com>
27
28         Add checks for app-bound navigations when evaluating user style sheets
29         https://bugs.webkit.org/show_bug.cgi?id=209368
30         <rdar://problem/60204230>
31
32         Reviewed by Brent Fulgham.
33
34         Tested cases based on those in UserContentController.mm.
35
36         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
37         (-[InAppBrowserSchemeHandler webView:startURLSchemeTask:]):
38         (expectScriptEvaluatesToColor):
39         (TEST):
40
41
42 2020-03-23  Alex Christensen  <achristensen@webkit.org>
43
44         Add SPI to move localStorage to a different domain
45         https://bugs.webkit.org/show_bug.cgi?id=209260
46         <rdar://problem/60285683>
47
48         Reviewed by Brady Eidson.
49
50         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
51         (TEST):
52
53 2020-03-23  youenn fablet  <youenn@apple.com>
54
55         Disable TestWebKitAPI.ProcessSwap.GetUserMediaCaptureState if getUserMedia is not supported
56         https://bugs.webkit.org/show_bug.cgi?id=209428
57
58         Reviewed by Jonathan Bedard.
59
60         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
61
62 2020-03-23  Chris Lord  <clord@igalia.com>
63
64         Add missing committer status to Chris Lord in contributors.json
65
66         Unreviewed
67
68         * Scripts/webkitpy/common/config/contributors.json:
69
70 2020-03-23  youenn fablet  <youenn@apple.com>
71
72         StringView::startsWith and String::startsWith do not treat null strings the same
73         https://bugs.webkit.org/show_bug.cgi?id=209273
74
75         Reviewed by Darin Adler.
76
77         * TestWebKitAPI/Tests/WTF/StringView.cpp:
78         (TestWebKitAPI::TEST):
79         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
80         (TestWebKitAPI::TEST):
81
82 2020-03-22  Antoine Quint  <graouts@apple.com>
83
84         DocumentTimeline / CSSTransition objects are leaking on CNN.com
85         https://bugs.webkit.org/show_bug.cgi?id=208069
86         <rdar://problem/59680143>
87
88         Reviewed by Simon Fraser, Geoffrey Garen and Darin Adler.
89
90         Add a test that checks that a ListHashSet containing RefPtr<> types correctly calls the destructor for those items when the assignment operator is used.
91
92         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
93         (TestWebKitAPI::ListHashSetReferencedItem::create):
94         (TestWebKitAPI::ListHashSetReferencedItem::ListHashSetReferencedItem):
95         (TestWebKitAPI::ListHashSetReferencedItem::~ListHashSetReferencedItem):
96         (TestWebKitAPI::FakeElementAnimationRareData::FakeElementAnimationRareData):
97         (TestWebKitAPI::FakeElementAnimationRareData::~FakeElementAnimationRareData):
98         (TestWebKitAPI::FakeElementAnimationRareData::collection):
99         (TestWebKitAPI::FakeElementAnimationRareData::setCollection):
100         (TestWebKitAPI::TEST):
101
102 2020-03-21  Michael Catanzaro  <mcatanzaro@gnome.org>
103
104         [GTK] Use ${PYTHON_EXECUTABLE} to run generate-gtkdoc
105         https://bugs.webkit.org/show_bug.cgi?id=208970
106
107         Reviewed by Konstantin Tokarev.
108
109         We are allowed to use /usr/bin/env in this script because it's not installed (so not
110         packaged). Therefore we can make the shebang compatible with FreeBSD in this particularl
111         case.
112
113         * gtkdoc/generate-gtkdoc:
114
115 2020-03-20  Jonathan Bedard  <jbedard@apple.com>
116
117         run-webkit-tests: Report MacCatalyst as a unique platform
118         https://bugs.webkit.org/show_bug.cgi?id=209361
119
120         Rubber-stamped by Aakash Jain.
121
122         * Scripts/webkitpy/port/mac.py:
123         (MacCatalystPort):
124         (MacCatalystPort.configuration_for_upload): Treat MacCatalyst as a separate platform from Mac.
125
126 2020-03-20  Alex Christensen  <achristensen@webkit.org>
127
128         CORS-disabling SPI introduced in r253978 should make responses non-opaque
129         https://bugs.webkit.org/show_bug.cgi?id=209351
130         <rdar://problem/60024850>
131
132         Reviewed by Chris Dumez.
133
134         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
135
136 2020-03-20  Aakash Jain  <aakash_jain@apple.com>
137
138         commit-queue should skip building and testing if patch already passed tests on mac-wk2 queue
139         https://bugs.webkit.org/show_bug.cgi?id=208938
140
141         Reviewed by Jonathan Bedard.
142
143         * BuildSlaveSupport/ews-build/steps.py:
144         (RunWebKitTests.doStepIf): Skip testing if patch already passed mac-wk2 tests.
145         (CheckPatchStatusOnEWSQueues): Build-step to check patch status on other queues.
146         (CheckPatchStatusOnEWSQueues.get_patch_status):
147         (CheckPatchStatusOnEWSQueues.start):
148         * BuildSlaveSupport/ews-build/steps_unittest.py:
149         (test_skip_for_mac_wk2_passed_patch_on_commit_queue): Added unit-tests.
150         * BuildSlaveSupport/ews-build/factories.py: Added build-step to check the patch status on other queues.
151         * BuildSlaveSupport/ews-build/factories_unittest.py: Updated unit-test.
152         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py: Added the new step status to STEPS_TO_HIDE.
153
154 2020-03-20  Aakash Jain  <aakash_jain@apple.com>
155
156         [ews] Better organize patch status api data
157         https://bugs.webkit.org/show_bug.cgi?id=209342
158
159         Reviewed by Jonathan Bedard.
160
161         * BuildSlaveSupport/ews-app/ews/views/status.py:
162         (Status._build_status):
163         (Status._build_statuses_for_patch): Updated to return dictionary instead of list.
164         (Status.get): Remove safe=false now that we are returning a dictionary.
165
166 2020-03-20  Tim Horton  <timothy_horton@apple.com>
167
168         Upstream a variety of Cocoa-platform HAVE and ENABLE macros
169         https://bugs.webkit.org/show_bug.cgi?id=209307
170
171         Reviewed by Andy Estes.
172
173         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
174
175 2020-03-20  Jacob Uphoff  <jacob_uphoff@apple.com>
176
177         Unreviewed, reverting r258748.
178
179         This commit broke the Catalina build
180
181         Reverted changeset:
182
183         "Upstream a variety of Cocoa-platform HAVE and ENABLE macros"
184         https://bugs.webkit.org/show_bug.cgi?id=209307
185         https://trac.webkit.org/changeset/258748
186
187 2020-03-20  Aakash Jain  <aakash_jain@apple.com>
188
189         [ews] commit-queue should comment on bug if patch fails to apply
190         https://bugs.webkit.org/show_bug.cgi?id=209334
191
192         Reviewed by Jonathan Bedard.
193
194         * BuildSlaveSupport/ews-build/steps.py:
195         (ApplyPatch):
196         (ApplyPatch.evaluateCommand): Overridden to check build status and queue name and comment on bug accordingly.
197         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
198         (TestApplyPatch):
199         (TestApplyPatch.setUp):
200         (TestApplyPatch.setUp.mock_start):
201         (TestApplyPatch.tearDown):
202         (TestApplyPatch.test_success):
203         (TestApplyPatch.test_failure):
204         (TestApplyPatch.test_failure_on_commit_queue):
205
206 2020-03-20  Aakash Jain  <aakash_jain@apple.com>
207
208         [EWS] Limit number of builds to display in status-bubble hover over message in case of lot of retried builds
209         https://bugs.webkit.org/show_bug.cgi?id=209122
210
211         Reviewed by Jonathan Bedard.
212
213         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
214         (StatusBubble._build_bubble):
215
216 2020-03-19  Tim Horton  <timothy_horton@apple.com>
217
218         Upstream a variety of Cocoa-platform HAVE and ENABLE macros
219         https://bugs.webkit.org/show_bug.cgi?id=209307
220
221         Reviewed by Andy Estes.
222
223         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
224
225 2020-03-19  Alex Christensen  <achristensen@webkit.org>
226
227         Remove test failing after r258734
228         https://bugs.webkit.org/show_bug.cgi?id=209303
229
230         We removed the functionality it was testing because it did nothing useful except call the callback.
231         I'm about to remove the only user of WKContextGetStatistics.
232
233         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
234         * TestWebKitAPI/Tests/WebKit/WebCoreStatisticsWithNoWebProcess.cpp: Removed.
235
236 2020-03-19  Aakash Jain  <aakash_jain@apple.com>
237
238         commit-queue status-bubble shows incorrect position in queue
239         https://bugs.webkit.org/show_bug.cgi?id=209313
240
241         Reviewed by Jonathan Bedard.
242
243         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
244         (StatusBubble._queue_position):
245
246 2020-03-19  Takashi Komori  <Takashi.Komori@sony.com>
247
248         [Curl] Add an API returns description of verification errors.
249         https://bugs.webkit.org/show_bug.cgi?id=208913
250
251         Reviewed by Fujii Hironori.
252
253         WKCertificateInfoCopyVerificationErrorDescription returns the description of SSL verification error as human readable string.
254         Browser can display more precise error information with this API.
255
256         API Test: Curl.CertificateAPI
257
258         * MiniBrowser/win/Common.cpp:
259         (askServerTrustEvaluation):
260         * MiniBrowser/win/Common.h:
261         * MiniBrowser/win/WebKitBrowserWindow.cpp:
262         (createPEMString):
263         (WebKitBrowserWindow::canTrustServerCertificate):
264         * TestWebKitAPI/Tests/WebKit/curl/Certificates.cpp:
265         (TestWebKitAPI::Curl::TEST):
266
267 2020-03-19  Aakash Jain  <aakash_jain@apple.com>
268
269         Update build.webkit.org link for EWS
270         https://bugs.webkit.org/show_bug.cgi?id=209280
271
272         Reviewed by Alexey Proskuryakov.
273
274         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
275
276 2020-03-19  Stephan Szabo  <stephan.szabo@sony.com>
277
278         [WinCairo] extract-built-product fails after r258612
279         https://bugs.webkit.org/show_bug.cgi?id=209285
280
281         extractBuiltProduct also references the old name for the
282         requirements on wincairo.
283
284         Reviewed by Ross Kirsling.
285
286         * BuildSlaveSupport/built-product-archive:
287
288 2020-03-19  Philippe Normand  <pnormand@igalia.com>
289
290         [Flatpak SDK] Release logs not sent to journald when running within the SDK runtime
291         https://bugs.webkit.org/show_bug.cgi?id=209223
292
293         Reviewed by Carlos Alberto Lopez Perez.
294
295         flatpak build doesn't expose a --socket option for white-listing
296         the systemd journal socket. So white-list everything in /run. 🤷
297
298         * flatpak/flatpakutils.py:
299         (WebkitFlatpak.run_in_sandbox):
300
301 2020-03-19  Charlie Turner  <cturner@igalia.com>
302
303         Fix many warnings with Clang 7.0 on GTK x86-64 in Debug.
304         https://bugs.webkit.org/show_bug.cgi?id=209146
305
306         Reviewed by Darin Adler.
307
308         * TestWebKitAPI/Tests/WebCore/TransformationMatrix.cpp:
309         (TestWebKitAPI::TEST):
310         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
311         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
312         (testDownloadMIMEType):
313         (testContextMenuDownloadActions):
314         * TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp:
315
316 2020-03-19  Carlos Garcia Campos  <cgarcia@igalia.com>
317
318         [GTK][WPE] REGRESSION(r258626): flatpak is used even when WEBKIT_JHBUILD is set
319         https://bugs.webkit.org/show_bug.cgi?id=209278
320
321         Reviewed by Philippe Normand.
322
323         This happens when using an external jhbuild, because shouldUseFlatpak() assumes that no command prefix always
324         means flatpak.
325
326         * Scripts/webkitdirs.pm:
327         (shouldUseFlatpak): Return early if WEBKIT_JHBUILD is set.
328
329 2020-03-19  Philippe Normand  <pnormand@igalia.com>
330
331         [CMake] cache not cleared when build-webkit options change
332         https://bugs.webkit.org/show_bug.cgi?id=209277
333
334         Reviewed by Adrian Perez de Castro.
335
336         * Scripts/webkitdirs.pm:
337         (shouldRemoveCMakeCache): The expected function signature never
338         included the cache file path. Remove it.
339
340 2020-03-18  Philippe Normand  <pnormand@igalia.com>
341
342         REGRESSION(r258626): webkit-dirs warning
343         https://bugs.webkit.org/show_bug.cgi?id=209221
344
345         Reviewed by Adrian Perez de Castro.
346
347         * Scripts/webkitdirs.pm:
348         (buildCMakeProjectOrExit): Fix Perl Warning. 😎
349
350 2020-03-19  Chris Lord  <clord@igalia.com>
351
352         Add Chris Lord (clord@igalia.com) to the list of contributors
353         https://bugs.webkit.org/show_bug.cgi?id=209274
354
355         Unreviewed
356
357         * Scripts/webkitpy/common/config/contributors.json:
358
359 2020-03-19  Ryan Haddad  <ryanhaddad@apple.com>
360
361         Remove commit queue bubble from bot watchers dashboard
362         https://bugs.webkit.org/show_bug.cgi?id=209271
363
364         Reviewed by Alexey Proskuryakov.
365
366         Remove commit queue bubble from bot watchers dashboard now that it has moved to the new EWS.
367
368         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
369         (BubbleQueueServer): 
370
371 2020-03-18  Simon Fraser  <simon.fraser@apple.com>
372
373         eventSender.monitorWheelEvents() is very fragile
374         https://bugs.webkit.org/show_bug.cgi?id=197819
375         <rdar://problem/51319456>
376
377         Reviewed by Tim Horton.
378
379         Deflake tests using eventSender.monitorWheelEvents() by fixing several causes of flakiness,
380         adding back changes from r257844 that were reverted in r258558.
381         
382         First, have EventSendingController keep track of whether it's seen then "end" event
383         for the scrolling and momentum phases, and pass this down to WheelEventTestMonitor, which
384         now waits until it sees these, which prevents premature triggering which was a common cause of
385         failure before.
386         
387         Second, remove WheelEventTestMonitor's 1/60s timer and instead have WheelEventTestMonitor test
388         for completion in a callout from the end of Page::updateRendering(), which makes it test
389         and fire at a more consistent time.
390         
391         Third, push WheelEventTestMonitor to the ScrollingTree, so that reasons for deferral
392         can be added on the scrolling thread. This fixes an issue where the RunLoop::main().dispatch()
393         used to send the "ScrollingThreadSyncNeeded" reason to the main thread would get delayed,
394         also resulting in a premature trigger.
395
396         * DumpRenderTree/mac/EventSendingController.h:
397         * DumpRenderTree/mac/EventSendingController.mm:
398         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
399         (-[EventSendingController monitorWheelEvents]):
400         (-[EventSendingController callAfterScrollingCompletes:]):
401         * DumpRenderTree/win/EventSender.cpp:
402         (mouseScrollBy):
403         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
404         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
405         (WTR::EventSendingController::monitorWheelEvents):
406         (WTR::EventSendingController::callAfterScrollingCompletes):
407         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
408
409 2020-03-18  John Wilander  <wilander@apple.com>
410
411         WebResourceLoadStatisticsStore::requestStorageAccessUnderOpener() should call its ephemeral counterpart when appropriate
412         https://bugs.webkit.org/show_bug.cgi?id=209245
413         <rdar://problem/60511121>
414
415         Reviewed by Chris Dumez.
416
417         These changes to the TestRunner makes sure that
418         - statisticsClearInMemoryAndPersistentStore()
419         - statisticsClearInMemoryAndPersistentStoreModifiedSinceHours()
420         ... use their own StatisticsDidClearInMemoryAndPersistentStoreCallbackID
421         and adds the infrastructure for that.
422
423         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
424         (WTR::InjectedBundle::didReceiveMessageToPage):
425         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
426         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
427         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
428         (WTR::TestRunner::statisticsCallClearInMemoryAndPersistentStoreCallback):
429         * WebKitTestRunner/InjectedBundle/TestRunner.h:
430         * WebKitTestRunner/TestController.cpp:
431         (WTR::TestController::statisticsClearInMemoryAndPersistentStore):
432         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
433         * WebKitTestRunner/TestInvocation.cpp:
434         (WTR::TestInvocation::didClearStatisticsInMemoryAndPersistentStore):
435         * WebKitTestRunner/TestInvocation.h:
436
437 2020-03-18  Wenson Hsieh  <wenson_hsieh@apple.com>
438
439         REGRESSION (r257214): Targeted preview animates to the wrong place when dropping in editable content
440         https://bugs.webkit.org/show_bug.cgi?id=209218
441         <rdar://problem/60560831>
442
443         Reviewed by Tim Horton.
444
445         Augment the drag and drop test harness to verify that for all targeted previews, if they have container views,
446         those views must be parented (i.e. they must be connected to a UIWindow).
447
448         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
449         (-[DragAndDropSimulator _concludeDropAndPerformOperationIfNecessary]):
450         (-[DragAndDropSimulator _expectNoDropPreviewsWithUnparentedContainerViews]):
451         (-[DragAndDropSimulator _invokeDropAnimationCompletionBlocksAndConcludeDrop]):
452
453 2020-03-18  Aakash Jain  <aakash_jain@apple.com>
454
455         [ews] commit-queue should comment on bug in case of test failures
456         https://bugs.webkit.org/show_bug.cgi?id=209226
457
458         Reviewed by Jonathan Bedard.
459
460         * BuildSlaveSupport/ews-build/steps.py:
461         (AnalyzeLayoutTestsResults.report_failure): Comment on bug and set cq- in case of test failure on commit-queue.
462         (BuildLogLineObserver.outLineReceived): Drive-by fix to use single quotes instead of double quotes.
463         (SetBuildSummary): Ditto.
464         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-test.
465
466 2020-03-18  Philippe Normand  <pnormand@igalia.com>
467
468         REGRESSION (r258626): test262 tests failing to run on macOS with error 'Undefined subroutine &Test262::Runner::setConfiguration'
469         https://bugs.webkit.org/show_bug.cgi?id=209238
470
471         Reviewed by Jonathan Bedard.
472
473         * Scripts/test262-runner: Perform the flatpak check on Linux only.
474
475 2020-03-18  Stephan Szabo  <stephan.szabo@sony.com>
476
477         [WinCairo] archive-built-product fails after r258612
478         https://bugs.webkit.org/show_bug.cgi?id=209237
479
480         Reviewed by Alex Christensen.
481
482         * BuildSlaveSupport/built-product-archive:
483         Update name of version file for requirements version
484         file for wincairo.
485
486 2020-03-18  Aakash Jain  <aakash_jain@apple.com>
487
488         commit-queue should allow patches which are reviewed by patch author
489         https://bugs.webkit.org/show_bug.cgi?id=209231
490
491         Reviewed by Jonathan Bedard.
492
493         * BuildSlaveSupport/ews-build/steps.py:
494         (BugzillaMixin._does_patch_have_acceptable_review_flag):
495
496 2020-03-18  Philippe Normand  <pnormand@igalia.com>
497
498         [JHBuild] Flatpak used for run-minibrowser even when forcing jhbuild
499         https://bugs.webkit.org/show_bug.cgi?id=209222
500
501         Reviewed by Carlos Alberto Lopez Perez.
502
503         * Scripts/webkitdirs.pm:
504         (runInFlatpakIfAvailable): If a command wrapper is required it
505         means Flatpak shouldn't be used.
506
507 2020-03-18  Aakash Jain  <aakash_jain@apple.com>
508
509         [ews] commit-queue should comment on bug in case patch fails to build
510         https://bugs.webkit.org/show_bug.cgi?id=209227
511
512         Reviewed by Jonathan Bedard.
513
514         * BuildSlaveSupport/ews-build/steps.py:
515         (AnalyzeCompileWebKitResults.start):
516         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-test.
517
518 2020-03-18  Philippe Normand  <pnormand@igalia.com>
519
520         [GTK][WPE] Migrate to Flatpak-based dev SDK
521         https://bugs.webkit.org/show_bug.cgi?id=205658
522
523         Reviewed by Carlos Alberto Lopez Perez.
524
525         JHBuild will now be used only if the WEBKIT_JHBUILD environment
526         variable is set to 1, which is the case for the time being on the
527         GTK and WPE EWS/build bots.
528
529         By default the build dependencies are now locally installed from a
530         Flatpak repository hosted at https://software.igalia.com. The
531         repository can be regenerated with the scripts from the
532         webkit-flatpak-sdk Github project
533         (https://github.com/Igalia/webkit-flatpak-sdk). This is done
534         transparently with the update-webkit{gtk,wpe}-libs scripts. As
535         there is no need to rebuild the dependencies from scratch, the
536         developer user-experience should now be much more friendly and
537         overall build times reduced.
538
539         As an additional commodity, the new environment supports the
540         GStreamer gst-build-based workflow. Just set the GST_BUILD_PATH
541         environment variable to your gst-build path. This feature was
542         contributed by Thibault Saunier.
543
544         The JHBuild infrastructure will be removed once all the bots have
545         been switched over to Flatpak.
546
547         * BuildSlaveSupport/ews-build/steps.py:
548         (InstallGtkDependencies):
549         (InstallWpeDependencies):
550         (CompileWebKit.start):
551         * BuildSlaveSupport/gtk/buildbot/run:
552         * Scripts/build-webkit:
553         * Scripts/run-bindings-tests:
554         * Scripts/run-builtins-generator-tests:
555         * Scripts/run-gtk-tests:
556         * Scripts/run-javascriptcore-tests:
557         * Scripts/run-minibrowser:
558         * Scripts/run-qt-wpe-minibrowser:
559         * Scripts/run-webdriver-tests:
560         * Scripts/run-wpe-tests:
561         * Scripts/test-webkitperl:
562         * Scripts/test-webkitpy:
563         * Scripts/test262-runner:
564         * Scripts/update-webkit-flatpak: Renamed from Tools/Scripts/update-webkitgtk-flatpak.
565         * Scripts/update-webkitgtk-libs:
566         * Scripts/update-webkitwpe-flatpak: Removed.
567         * Scripts/update-webkitwpe-libs:
568         * Scripts/webkitdirs.pm:
569         (getUserFlatpakPath):
570         (inFlatpakSandbox):
571         (runInFlatpakIfAvailable):
572         (wrapperPrefixIfNeeded):
573         (shouldUseJhbuild):
574         (shouldUseFlatpak):
575         (shouldRemoveCMakeCache):
576         * Scripts/webkitpy/common/system/executive.py:
577         (Executive.kill_all):
578         * Scripts/webkitpy/port/base.py:
579         (Port._path_to_apache):
580         (Port._should_run_as_pixel_test):
581         (Port._in_flatpak_sandbox):
582         * Scripts/webkitpy/port/gtk.py:
583         (GtkPort.setup_environ_for_server):
584         (GtkPort._get_crash_log):
585         * Scripts/webkitpy/port/linux_get_crash_log.py:
586         (GDBCrashLogGenerator):
587         (GDBCrashLogGenerator.__init__):
588         (GDBCrashLogGenerator.generate_crash_log):
589         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
590         (GDBCrashLogGeneratorTest.test_generate_crash_log):
591         * Scripts/webkitpy/port/wpe.py:
592         (WPEPort.setup_environ_for_server):
593         (WPEPort._get_crash_log):
594         * Scripts/webkitpy/port/xvfbdriver.py:
595         (XvfbDriver._setup_environ_for_test):
596         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
597         (WTR::getFontsPath):
598         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
599         (WTR::getFontsPath):
600         * flatpak/files/default.xkm: Removed.
601         * flatpak/files/httpd-autogen.sh: Removed.
602         * flatpak/flatpakutils.py:
603         (check_flatpak):
604         (FlatpakRepos.update):
605         (FlatpakPackage.__repr__):
606         (FlatpakPackage.__str__):
607         (WebkitFlatpak.load_from_args):
608         (WebkitFlatpak.__init__):
609         (WebkitFlatpak.clean_args):
610         (WebkitFlatpak.setup_builddir):
611         (WebkitFlatpak):
612         (WebkitFlatpak.setup_gstbuild):
613         (WebkitFlatpak.run_in_sandbox):
614         (WebkitFlatpak.run):
615         (WebkitFlatpak.has_environment):
616         (WebkitFlatpak.save_config):
617         (WebkitFlatpak.setup_dev_env):
618         (WebkitFlatpak.install_all):
619         (WebkitFlatpak.run_gdb):
620         * flatpak/org.webkit.CommonModules.yaml: Removed.
621         * flatpak/org.webkit.GTK.yaml: Removed.
622         * flatpak/org.webkit.WPE.yaml: Removed.
623         * flatpak/org.webkit.WPEModules.yaml: Removed.
624         * flatpak/org.webkit.WPEQT.yaml: Removed.
625         * flatpak/org.webkit.WebKit.yaml: Removed.
626         * flatpak/patches/httpd-0001-configure-use-pkg-config-for-PCRE-detection.patch: Removed.
627         * flatpak/patches/libgcrypt-0001-Use-pkg-config-to-detect-gpg-error.patch: Removed.
628         * flatpak/patches/xvfb-0001-HACK-Avoid-compiling-a-kbm-file.patch: Removed.
629
630 2020-03-17  Kate Cheney  <katherine_cheney@apple.com>
631
632         Expand In-App-Browser-Privacy testing
633         https://bugs.webkit.org/show_bug.cgi?id=209142
634         <rdar://problem/60496618>
635
636         Reviewed by Darin Adler.
637
638         Expanded test coverage by adding new tests and creating a custom url
639         scheme handler to get around the fact that local file loads are
640         always classified as app-bound.
641
642         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
643         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
644         (-[InAppBrowserSchemeHandler webView:startURLSchemeTask:]):
645         If the path indicates testing user scripts on load, notify the script message
646         handler that the navigation has finished. If the path indicates
647         testing user-agent scripts, set the window.wkUserScriptInjected
648         variable to true. A user agent script will attempt to read this
649         variable and should fail.
650
651         (-[InAppBrowserSchemeHandler webView:stopURLSchemeTask:]):
652         (initializeInAppBrowserPrivacyTestSettings):
653         Basic test setup. Initialize the main run loop and make sure we are
654         starting with a clean state.
655
656         (TEST):
657         Add tests for all protocols checked in shouldBeTreatedAsAppBound,
658         except for blob files which must be generated within the web content.
659
660         * TestWebKitAPI/Tests/WebKitCocoa/in-app-browser-privacy-local-file.html: Added.
661         Basic html document to test local file loads are classified as
662         app-bound.
663
664         * TestWebKitAPI/Tests/WebKitCocoa/in-app-browser-privacy-test-user-agent-script.html: Removed.
665         * TestWebKitAPI/Tests/WebKitCocoa/in-app-browser-privacy-test-user-script.html: Removed.
666         These files are no longer needed as their content is directly copied
667         into the URL scheme handler.
668
669 2020-03-17  Chris Dumez  <cdumez@apple.com>
670
671         REGRESSION: [ macOS wk1 ] ASSERTION FAILED: _notifications.contains(notificationID) imported/w3c/web-platform-tests/notifications/constructor-basic.html is flaky crashing
672         https://bugs.webkit.org/show_bug.cgi?id=207307
673         <rdar://problem/59206964>
674
675         Reviewed by Alex Christensen.
676
677         When [MockWebNotificationProvider reset] was called at the end of the test, it would remove all
678         notifications from the map but not tell WebCore that the notification were discarded. As a result,
679         WebCore would later tell the MockWebNotificationProvider to cancel the notification but this
680         notification would no longer be in the map, causing us to hit an assertion in debug.
681
682         To address the issue, we now call Notification::finalize() in [MockWebNotificationProvider reset]
683         to let WebCore know the notification was discarded. This is similar to what is already done for
684         WebKit2 in WebNotificationManager::clearNotifications().
685
686         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
687         (-[MockWebNotificationProvider reset]):
688
689 2020-03-17  Don Olmstead  <don.olmstead@sony.com>
690
691         [WinCairo][FTW] Update path to requirements download
692         https://bugs.webkit.org/show_bug.cgi?id=209202
693
694         Reviewed by Ross Kirsling.
695
696         Repository was renamed from WinCairoRequirements to WebKitRequirements in the
697         WebKitForWindows org on GitHub. Additionally the .zip file was renamed to
698         WebKitRequirementsWin64.zip.
699
700         * Scripts/update-webkit-wincairo-libs.py:
701
702 2020-03-17  Aakash Jain  <aakash_jain@apple.com>
703
704         [ews] Resubmit patches to commit-queue which were cq- by commit-queue and later cq+
705         https://bugs.webkit.org/show_bug.cgi?id=208920
706
707         Reviewed by Jonathan Bedard.
708
709         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
710         (Buildbot.update_builder_name_to_id_mapping): Method to generate builder name to id mapping.
711         (Buildbot.fetch_pending_and_inprogress_builds): Method to fetch pendign and in-progress builds from buildbot.
712         (Buildbot.get_patches_in_queue): Method to fetch list of patches which are pending or are in-progress on buildbot.
713         * BuildSlaveSupport/ews-app/ews/common/bugzilla.py:
714         (Bugzilla.get_cq_plus_timestamp): Get UTC timestamp when cq+ flag was set.
715         * BuildSlaveSupport/ews-app/ews/fetcher.py:
716         (FetchLoop.run): Update builder name to id mapping. We just need to update it one-time, since we need the id only
717         for commit-queue which isn't expected to change.
718         (BugzillaPatchFetcher.fetch_commit_queue_patches):
719         (BugzillaPatchFetcher.send_patches_to_buildbot): Allow sending the patch again to commit-queue.
720         (BugzillaPatchFetcher.patches_to_send_to_commit_queue): Find patches which needs to be sent to commit-queue. Filter
721         out patches which are already waiting or in-progress on commit-queue, or whose recent build was completed after
722         setting cq+ flag on bugzilla.
723
724 2020-03-17  Chris Dumez  <cdumez@apple.com>
725
726         [WKTR] testRunner API that takes in a completion handler should use async IPC
727         https://bugs.webkit.org/show_bug.cgi?id=209187
728
729         Reviewed by John Wilander.
730
731         testRunner API that takes in a completion handler should use async IPC. This hangs
732         the WebProcess for no reason and can cause deadlocks if the UIProcess then tries
733         to IPC the WebProcess as a result of this testRunner call.
734
735         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
736         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
737         (WTR::TestRunner::statisticsUpdateCookieBlocking):
738         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
739         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
740         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
741         (WTR::TestRunner::setStatisticsShouldDowngradeReferrer):
742         (WTR::TestRunner::setStatisticsFirstPartyWebsiteDataRemovalMode):
743         (WTR::TestRunner::statisticsResetToConsistentState):
744         (WTR::TestRunner::getAllStorageAccessEntries):
745         (WTR::TestRunner::removeAllSessionCredentials):
746         (WTR::TestRunner::getApplicationManifestThen):
747         * WebKitTestRunner/TestInvocation.cpp:
748         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
749         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
750
751 2020-03-17  Aakash Jain  <aakash_jain@apple.com>
752
753         [ews-app] Timestamp shown in status-bubble hover-over message is in future
754         https://bugs.webkit.org/show_bug.cgi?id=196628
755
756         Reviewed by Jonathan Bedard.
757
758         * BuildSlaveSupport/ews-build/events.py:
759         (JSONProducer.json_serialize_datetime): Keep the timestamp in UTC, instead of converting it to local time zone.
760         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
761         (StatusBubble.get_all_builds_for_queue): Sort the queues based on build number instead of start time, since the 
762         timestamps for new builds might be less than timestamps for old builds which completed immediately prior to this change.
763
764 2020-03-17  Alex Christensen  <achristensen@webkit.org>
765
766         Add WKUIDelegatePrivate SPI _webView:printFrame:completionHandler:
767         https://bugs.webkit.org/show_bug.cgi?id=209192
768         <rdar://problem/51313336>
769
770         Reviewed by Geoff Garen.
771
772         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
773         (-[PrintDelegateWithCompletionHandler _webView:printFrame:completionHandler:]):
774         (-[PrintDelegateWithCompletionHandler waitForPrintFrameCall]):
775         (TEST):
776
777 2020-03-17  Chris Dumez  <cdumez@apple.com>
778
779         Use less sync IPC for ITP testRunner methods
780         https://bugs.webkit.org/show_bug.cgi?id=209184
781
782         Reviewed by Alex Christensen.
783
784         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
785         (WTR::TestRunner::setStatisticsDebugMode):
786         (WTR::TestRunner::setStatisticsPrevalentResourceForDebugMode):
787         (WTR::TestRunner::setStatisticsLastSeen):
788         (WTR::TestRunner::setStatisticsMergeStatistic):
789         (WTR::TestRunner::setStatisticsPrevalentResource):
790         (WTR::TestRunner::setStatisticsVeryPrevalentResource):
791         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
792         * WebKitTestRunner/TestInvocation.cpp:
793         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
794         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
795
796 2020-03-17  Chris Dumez  <cdumez@apple.com>
797
798         [WKTR] Crash when trying to open a new window in an ephemeral session test
799         https://bugs.webkit.org/show_bug.cgi?id=209181
800
801         Reviewed by Geoffrey Garen.
802
803         Make sure that the new WKWebView is using the same data store as its related WKWebView.
804
805         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
806         (WTR::TestController::platformCreateOtherPage):
807
808 2020-03-17  Jacob Uphoff  <jacob_uphoff@apple.com>
809
810         Unreviewed, reverting r257844.
811
812         this revision caused a test to start timing out
813
814         Reverted changeset:
815
816         "(r256513) [ Mac ] fast/scrolling/programmatic-scroll-to-zero-
817         zero.html is a flaky failure"
818         https://bugs.webkit.org/show_bug.cgi?id=207948
819         https://trac.webkit.org/changeset/257844
820
821 2020-03-16  Justin Michaud  <justin_michaud@apple.com>
822
823         Add personal email to Tools/Scripts/webkitpy/common/config/contributors.json
824         https://bugs.webkit.org/show_bug.cgi?id=209151
825
826         Reviewed by Yusuke Suzuki.
827
828         * Scripts/webkitpy/common/config/contributors.json:
829
830 2020-03-16  Chris Dumez  <cdumez@apple.com>
831
832         Crash under WebCookieCache::clearForHost()
833         https://bugs.webkit.org/show_bug.cgi?id=209149
834         <rdar://problem/60453086>
835
836         Reviewed by Alex Christensen.
837
838         Add API test coverage.
839
840         * TestWebKitAPI/Tests/WebKitCocoa/CookiePrivateBrowsing.mm:
841         (TEST):
842
843 2020-03-16  Keith Rollin  <krollin@apple.com>
844
845         Remove support for WebKitSystemInterface
846         https://bugs.webkit.org/show_bug.cgi?id=208894
847         <rdar://problem/60297590>
848
849         Reviewed by Brent Fulgham.
850
851         This project provided support for facilities that are now handled
852         elsewhere and is no longer needed.
853
854         * Scripts/copy-webkitlibraries-to-product-directory:
855
856 2020-03-16  Per Arne Vollan  <pvollan@apple.com>
857
858         [macOS] Accessibility sandbox regressions
859         https://bugs.webkit.org/show_bug.cgi?id=209065
860
861         Reviewed by Brent Fulgham.
862
863         * TestWebKitAPI/Tests/WebKit/EnableAccessibility.mm:
864         (TEST):
865         * TestWebKitAPI/Tests/WebKit/GrantAccessToPreferencesService.mm:
866         (TEST):
867
868 2020-03-16  Ryan Haddad  <ryanhaddad@apple.com>
869
870         Unreviewed infrastructure fix.
871
872         * BuildSlaveSupport/ews-build/config.json: Temporarily remove ews114
873         while the hardware is out for repair.
874
875 2020-03-13  Sergio Villar Senin  <svillar@igalia.com>
876
877         [WebXR] IDLs, stubs and build configuration for WPE
878         https://bugs.webkit.org/show_bug.cgi?id=208702
879
880         Reviewed by Dean Jackson.
881
882         * Scripts/webkitperl/FeatureList.pm: Added WebXR.
883         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Added ENABLE_WEBXR, off by default.
884
885 2020-03-16  Per Arne Vollan  <pvollan@apple.com>
886
887         [Cocoa] Limit set of classes that can be decoded when a preference has changed
888         https://bugs.webkit.org/show_bug.cgi?id=208012
889
890         Reviewed by Brent Fulgham.
891
892         * TestWebKitAPI/Tests/WebKit/PreferenceChanges.mm:
893         (TEST):
894
895 2020-03-16  youenn fablet  <youenn@apple.com>
896
897         Unique origins should not be Potentially Trustworthy
898         https://bugs.webkit.org/show_bug.cgi?id=209049
899
900         Reviewed by Darin Adler.
901
902         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
903         (TestWebKitAPI::TEST_F):
904
905 2020-03-15  Fujii Hironori  <Hironori.Fujii@sony.com>
906
907         KeyedDecoderGeneric fails to allocate Vector while decoding broken data
908         https://bugs.webkit.org/show_bug.cgi?id=207324
909
910         Reviewed by Darin Adler.
911
912         * TestWebKitAPI/Tests/WebCore/KeyedCoding.cpp:
913         (TestWebKitAPI::generateRandomData): Added.
914         (TestWebKitAPI::KeyedCoding.DecodeRandomData): Added a new test decoding random data.
915
916 2020-03-15  Yusuke Suzuki  <ysuzuki@apple.com>
917
918         Should not use variable-length-array (VLA)
919         https://bugs.webkit.org/show_bug.cgi?id=209043
920
921         Reviewed by Mark Lam.
922
923         * ContentExtensionTester/Configurations/Base.xcconfig:
924         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
925
926 2020-03-13  Alex Christensen  <achristensen@webkit.org>
927
928         WKWebView._negotiatedLegacyTLS should be correct after back/forward navigations
929         https://bugs.webkit.org/show_bug.cgi?id=209011
930         <rdar://problem/59370588>
931
932         Reviewed by Youenn Fablet.
933
934         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
935         (TestWebKitAPI::TEST):
936
937 2020-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
938
939         [watchOS] Don’t display empty text suggestions in Quickboard when editing input fields
940         https://bugs.webkit.org/show_bug.cgi?id=209089
941
942         Reviewed by Tim Horton.
943
944         Add an API test for watchOS. Also rename a few occurrences of "Autofill" to "AutoFill", to reflect the official
945         marketing name for the feature.
946
947         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
948         (runUntilReceivesAutoplayEvent):
949
950         Additionally fix the watchOS engineering build for arm64_32, which was failing due to comparisons between 64-bit
951         and 32-bit integers. This is because this function took a `WKAutoplayEvent` (a 32-bit integer), but compared
952         against the `_WKAutoplayEvent` type (an NSInteger that is 64 bits on this architecture). There didn't seem to
953         be any compelling reason to compare against different types here (especially since we only set
954         `receivedAutoplayEvent` under the Objective-C delegate method that provides a `_WKAutoplayEvent`), so I changed
955         these all to be `_WKAutoplayEvent`.
956
957         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
958         (-[AutoFillTestView _autofillInputView]):
959         (-[AutoFillTestView textInputHasAutoFillContext]):
960         (TestWebKitAPI::TEST):
961         (-[AutofillTestView initWithFrame:]): Deleted.
962         (-[AutofillTestView _autofillInputView]): Deleted.
963         (-[AutofillTestView textInputHasAutofillContext]): Deleted.
964         * TestWebKitAPI/ios/UIKitSPI.h:
965
966 2020-03-13  Chris Dumez  <cdumez@apple.com>
967
968         Unreviewed, reverting r256232.
969
970         Caused ResizeObserver tests to become flaky
971
972         Reverted changeset:
973
974         "[DRT] InternalSettingsGenerated::resetToConsistentState() may
975         override TestOptions"
976         https://bugs.webkit.org/show_bug.cgi?id=207481
977         https://trac.webkit.org/changeset/256232
978
979 2020-03-13  Kate Cheney  <katherine_cheney@apple.com>
980
981         [ iOS and Mac wk2 ] http/tests/in-app-browser-privacy/ tests failing
982         https://bugs.webkit.org/show_bug.cgi?id=209016
983         <rdar://problem/60329530> 
984
985         Reviewed by Chris Dumez.
986
987         Re-initialize the app-bound domains when the correct
988         TestOptions parameter is set.
989
990         * WebKitTestRunner/TestController.cpp:
991         (WTR::TestController::createWebViewWithOptions):
992         (WTR::TestController::reinitializeAppBoundDomains):
993         * WebKitTestRunner/TestController.h:
994
995 2020-03-13  Kate Cheney  <katherine_cheney@apple.com>
996
997         Report all third party loads on a per-page basis
998         https://bugs.webkit.org/show_bug.cgi?id=209032
999         <rdar://problem/60397323>
1000
1001         Reviewed by Chris Dumez.
1002
1003         Mostly naming updates to reflect the change in use for this SPI call.
1004         It now returns all loaded third party domains, not just prevalent ones.
1005
1006         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1007         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1008         (WTR::InjectedBundle::didReceiveMessageToPage):
1009         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1010         (WTR::TestRunner::getLoadedThirdPartyDomains):
1011         (WTR::TestRunner::callDidReceiveLoadedThirdPartyDomainsCallback):
1012         (WTR::TestRunner::getPrevalentDomains): Deleted.
1013         (WTR::TestRunner::callDidReceivePrevalentDomainsCallback): Deleted.
1014         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1015         * WebKitTestRunner/TestController.cpp:
1016         (WTR::TestController::resetStateToConsistentValues):
1017         (WTR::TestController::getLoadedThirdPartyDomains):
1018         (WTR::TestController::clearLoadedThirdPartyDomains):
1019         (WTR::TestController::getPrevalentDomains): Deleted.
1020         (WTR::TestController::clearPrevalentDomains): Deleted.
1021         * WebKitTestRunner/TestController.h:
1022         * WebKitTestRunner/TestInvocation.cpp:
1023         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1024         (WTR::TestInvocation::didReceiveLoadedThirdPartyDomains):
1025         (WTR::TestInvocation::didReceivePrevalentDomains): Deleted.
1026         * WebKitTestRunner/TestInvocation.h:
1027         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1028         (WTR::TestController::getLoadedThirdPartyDomains):
1029         (WTR::TestController::clearLoadedThirdPartyDomains):
1030         (WTR::TestController::getPrevalentDomains): Deleted.
1031         (WTR::TestController::clearPrevalentDomains): Deleted.
1032
1033 2020-03-13  Aakash Jain  <aakash_jain@apple.com>
1034
1035         [ews] run FindModifiedChangeLogs early in the build
1036         https://bugs.webkit.org/show_bug.cgi?id=209060
1037
1038         Reviewed by Jonathan Bedard.
1039
1040         * BuildSlaveSupport/ews-build/factories.py:
1041         * BuildSlaveSupport/ews-build/factories_unittest.py: Updated unit-test.
1042
1043 2020-03-13  Diego Pino Garcia  <dpino@igalia.com>
1044
1045         [GTK] Add EWS testers to run GTK layout tests
1046         https://bugs.webkit.org/show_bug.cgi?id=207648
1047
1048         Reviewed by Carlos Alberto Lopez Perez and Aakash Jain.
1049
1050         Queue 'GTK-Webkit2-EWS' was renamed to 'GTK-Build-EWS'.
1051         A new queue, named 'GTK-WK2-Tests-EWS', was added for WK2
1052         tests (layout tests).
1053
1054         * BuildSlaveSupport/ews-build/config.json: Added new queue for
1055         WK2 tests.
1056         * BuildSlaveSupport/ews-build/factories.py:
1057         (GTKTestsFactory):
1058         * BuildSlaveSupport/ews-build/factories_unittest.py:
1059         (TestCommitQueueFactory.test_commit_queue_factory):
1060         (TestGTKFactory): Added unit-test.
1061         (TestGTKFactory.test_gtk_factory):
1062         * BuildSlaveSupport/ews-build/loadConfig.py:
1063         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
1064         (TagsForBuilderTest.test_getTagsForBuilder):
1065
1066 2020-03-13  Aakash Jain  <aakash_jain@apple.com>
1067
1068         Add API endpoint in EWS django app to provide patch status in json format
1069         https://bugs.webkit.org/show_bug.cgi?id=208940
1070
1071         Reviewed by Jonathan Bedard.
1072
1073         * BuildSlaveSupport/ews-app/ews/urls.py: Added url for new api endpoint.
1074         * BuildSlaveSupport/ews-app/ews/views/status.py: Added.
1075
1076 2020-03-13  Kate Cheney  <katherine_cheney@apple.com>
1077
1078         WebKit2UseRemoteLayerTreeDrawingArea should be reset to NO between layout tests
1079         https://bugs.webkit.org/show_bug.cgi?id=209055
1080         <rdar://problem/60272692>
1081
1082         Reviewed by Simon Fraser.
1083
1084         Now that WebKitTestRunner has a bundleID, its' user default values
1085         persist between tests. This patch resets WebKit2UseRemoteLayerTreeDrawingArea
1086         to NO before running tests. It will be set to YES in PlatformWebView
1087         if specified by the test.
1088
1089         * WebKitTestRunner/mac/main.mm:
1090         (setDefaultsToConsistentValuesForTesting):
1091
1092 2020-03-13  Konstantin Tokarev  <annulen@yandex.ru>
1093
1094         [CMake] Eleminate mismatches between Find* module names and variables they set
1095         https://bugs.webkit.org/show_bug.cgi?id=208948
1096
1097         Reviewed by Michael Catanzaro.
1098
1099         * wpe/backends/CMakeLists.txt:
1100
1101 2020-03-13  Aakash Jain  <aakash_jain@apple.com>
1102
1103         [ews-app] reduce logging
1104         https://bugs.webkit.org/show_bug.cgi?id=209062
1105
1106         Reviewed by Jonathan Bedard.
1107
1108         * BuildSlaveSupport/ews-app/ews/common/bugzilla.py:
1109         (BugzillaBeautifulSoup.authenticate):
1110         (BugzillaBeautifulSoup._load_query):
1111
1112 2020-03-13  Ryosuke Niwa  <rniwa@webkit.org>
1113
1114         Crash in TextIterator::node via TextManipulationController::replace
1115         https://bugs.webkit.org/show_bug.cgi?id=209048
1116
1117         Reviewed by Wenson Hsieh.
1118
1119         Added a regression test.
1120
1121         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
1122         (TextManipulation.CompleteTextManipulationShouldReplaceContentsAroundParagraphWithJustImage):
1123
1124 2020-03-13  Saam Barati  <sbarati@apple.com>
1125
1126         Pull in JS tests from "Internal" when there are "Internal" tests in an adjacent directory
1127         https://bugs.webkit.org/show_bug.cgi?id=209038
1128
1129         Reviewed by Keith Miller.
1130
1131         This allows us to automatically pull in some tests that are in non open sourced Apple
1132         checkouts.
1133
1134         * Scripts/run-javascriptcore-tests:
1135         (runJSCStressTests):
1136
1137 2020-03-12  Ryosuke Niwa  <rniwa@webkit.org>
1138
1139         Crash in TextManipulationController::replace
1140         https://bugs.webkit.org/show_bug.cgi?id=209021
1141
1142         Reviewed by Wenson Hsieh.
1143
1144         Added a regression test.
1145
1146         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
1147         (TextManipulation.CompleteTextManipulationShouldReplaceContentFollowedAfterImageInCSSTable):
1148
1149 2020-03-12  Per Arne Vollan  <pvollan@apple.com>
1150
1151         [macOS] _AXSApplicationAccessibilityEnabled should not be called
1152         https://bugs.webkit.org/show_bug.cgi?id=208953
1153
1154         Reviewed by Brent Fulgham.
1155
1156         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1157
1158 2020-03-12  Kate Cheney  <katherine_cheney@apple.com>
1159
1160         Resource load statistics data summary should return all third party data
1161         https://bugs.webkit.org/show_bug.cgi?id=209000
1162         <rdar://problem/60348306>
1163
1164         Reviewed by John Wilander.
1165
1166         Marked only 2 of 3 domains prevalent in data summary tests to ensure
1167         the call returns all third parties, not just prevalent ones.
1168         Added a more aggressive check for the size of the array at the
1169         beginning of the test to ensure the array is still returning 3 values. 
1170         Also removed the ASSERT statements as they seem to cause timeouts (not
1171         clear crashes) when they are not true, which is hard to debug.
1172         If these values are nil, the test will fail in the EXPECT_WK_STREQ
1173         checks, we don't need ASSERT statements.
1174
1175         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1176         (TEST):
1177
1178 2020-03-12  Jonathan Bedard  <jbedard@apple.com>
1179
1180         resultsdpy: Add script to run local instance
1181         https://bugs.webkit.org/show_bug.cgi?id=208746
1182
1183         Rubber-stamped by Aakash Jain.
1184
1185         * resultsdbpy/resultsdbpy/example: Added.
1186         * resultsdbpy/resultsdbpy/example/__init__.py: Added.
1187         * resultsdbpy/resultsdbpy/example/environment.py: Added.
1188         (Environment): Organize environment variables used by results database.
1189         (ModelFromEnvironment): Construct the database model from the environment.
1190         (main): Create and drop tables, if required.
1191         * resultsdbpy/resultsdbpy/example/main.py: Added.
1192         (health): Web-server health check.
1193         (handle_errors):
1194         (main): Run results database web-server.
1195         * resultsdbpy/resultsdbpy/example/worker.py: Added.
1196         (main): Asynchronously process uploaded results.
1197         * resultsdbpy/resultsdbpy/run: Added.
1198
1199 2020-03-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1200
1201         run-webkit-tests --use-gpu-process should enable GPU Process for canvas
1202         https://bugs.webkit.org/show_bug.cgi?id=209004
1203
1204         Reviewed by Tim Horton.
1205
1206         Add "RenderCanvasInGPUProcessEnabled" to the list of internal features that should be enabled when
1207         `use_gpu_process` is specified.
1208
1209         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1210         (parse_args):
1211
1212 2020-03-12  Matt Lewis  <jlewis3@apple.com>
1213
1214         Make flatpack import for run-webkit-tests only happen on linux systems
1215         https://bugs.webkit.org/show_bug.cgi?id=208954
1216
1217         Reviewed by Philippe Normand.
1218
1219         * Scripts/run-webkit-tests: Added an if statement to find the system platform
1220         to determine if we need the flatpackutils import. 
1221
1222 2020-03-12  Alex Christensen  <achristensen@webkit.org>
1223
1224         WKWebView.hasOnlySecureContent should be correct after back/forward navigations
1225         https://bugs.webkit.org/show_bug.cgi?id=207609
1226
1227         Reviewed by Ryosuke Niwa.
1228
1229         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
1230         (TestWebKitAPI::TEST):
1231
1232 2020-03-12  Daniel Bates  <dabates@apple.com>
1233
1234         FocusController::setFocusedElement() should tell client of refocused element
1235         https://bugs.webkit.org/show_bug.cgi?id=208880
1236
1237         Reviewed by Wenson Hsieh.
1238
1239         Adds a test to ensure that calling -selectPositionAtPoint on an already focused element tries
1240         to start an input session. Currently, it does not even try.
1241
1242         * TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm:
1243         (TEST):
1244
1245 2020-03-12  Michael Catanzaro  <mcatanzaro@gnome.org>
1246
1247         [GTK] Use #!/usr/bin/python3 shebang to run generate-gtkdoc
1248         https://bugs.webkit.org/show_bug.cgi?id=208970
1249
1250         Reviewed by Daniel Bates.
1251
1252         Fedora and Ubuntu are both patching generate-gtkdoc to use #!/usr/bin/python3 rather than
1253         #!/usr/bin/env python.
1254
1255         #!/usr/bin/env and /usr/bin/python are both banned in Fedora packages. I guess Ubuntu
1256         probably has similar rules.
1257
1258         Note this is the only script that attempts to use /usr/bin/python in tarball builds.
1259         Everything else that does so is probably only used by webkit-build.
1260
1261         https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_multiple_python_runtimes
1262
1263         * gtkdoc/generate-gtkdoc:
1264
1265 2020-03-11  Jiewen Tan  <jiewen_tan@apple.com>
1266
1267         [WebAuthn] Formalize the Keychain schema
1268         https://bugs.webkit.org/show_bug.cgi?id=183533
1269         <rdar://problem/43347926>
1270
1271         Reviewed by Brent Fulgham.
1272
1273         Modifies the test infra to use Credential ID as the unique identifier for a credential instead of
1274         the original combination of RP ID and user handle.
1275
1276         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1277         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1278         (WTR::TestRunner::cleanUpKeychain):
1279         (WTR::TestRunner::keyExistsInKeychain):
1280         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1281         * WebKitTestRunner/TestController.h:
1282         * WebKitTestRunner/TestInvocation.cpp:
1283         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1284         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1285         (WTR::TestController::cleanUpKeychain):
1286         (WTR::TestController::keyExistsInKeychain):
1287
1288 2020-03-11  Keith Miller  <keith_miller@apple.com>
1289
1290         Test262-runner should always consider crashes as new failures
1291         https://bugs.webkit.org/show_bug.cgi?id=208943
1292
1293         Reviewed by Yusuke Suzuki.
1294
1295         Right now the runner will consider crashes with no output as passes, which is obviously bad.
1296         Since we should never crash on a conformance test we should consider a crash as a new failure
1297         100% of the time.
1298
1299         * Scripts/test262/Runner.pm:
1300         (processFile):
1301         (runTest):
1302         (processResult):
1303
1304 2020-03-11  Chris Dumez  <cdumez@apple.com>
1305
1306         Assertion hit under WebPageProxy::suspendCurrentPageIfPossible() when bypassing certificate warning page
1307         https://bugs.webkit.org/show_bug.cgi?id=208927
1308         <rdar://problem/55448331>
1309
1310         Reviewed by Alex Christensen.
1311
1312         Add API test coverage.
1313
1314         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1315
1316 2020-03-11  Diego Pino Garcia  <dpino@igalia.com>
1317
1318         [GTK] Switch EWS api-gtk bot from buildAndTest to testOnly
1319         https://bugs.webkit.org/show_bug.cgi?id=208860
1320
1321         Reviewed by Carlos Alberto Lopez Perez.
1322
1323         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1324         (StatusBubble): Added 'api-gtk'.
1325         * BuildSlaveSupport/ews-build/config.json:
1326         * BuildSlaveSupport/ews-build/factories.py:
1327         (BuildFactory.__init__): Call InstallGTKDependencies() if platform is
1328         GTK.
1329         (TestFactory.__init__): Call InstallGTKDependencies() if platform is
1330         GTK.
1331         (GTKBuildFactory):
1332         (GTKBuildFactory.__init__): Deleted.
1333         (GTKBuildAndTestFactory): Deleted.
1334         (GTKBuildAndTestFactory.__init__): Deleted.
1335         (GTKAPIBuildAndTestFactory): Deleted.
1336         * BuildSlaveSupport/ews-build/loadConfig.py:
1337
1338 2020-03-11  Aakash Jain  <aakash_jain@apple.com>
1339
1340         [ews] Add unit test to prevent multiple schedulers for a builder.
1341         https://bugs.webkit.org/show_bug.cgi?id=208917
1342
1343         Reviewed by Carlos Alberto Lopez Perez.
1344
1345         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
1346         (ConfigDotJSONTest.test_multiple_scheduers_for_builder): Added unit test.
1347         (TagsForBuilderTest): Fixed a typo.
1348
1349 2020-03-11 Philippe Normand  <pnormand@igalia.com>
1350
1351         [GTK] Failing API tests under the Flatpak SDK environment
1352         https://bugs.webkit.org/show_bug.cgi?id=208871
1353
1354         Reviewed by Michael Catanzaro.
1355
1356         The load-failed signal callback should return a boolean result,
1357         otherwise we enter in unknown territory depending on how the
1358         toolchain compiles this, possibly triggering bad behavior (with
1359         GCC 9.2 from the Flatpak SDK) or not caring at all (with current
1360         GCC toolchain on buildbots).
1361
1362         Patch suggested by Michael Catanzaro.
1363
1364         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
1365         (loadFailedCallback):
1366
1367 2020-03-10  Don Olmstead  <don.olmstead@sony.com>
1368
1369         Sync FeatureList.pm with CMake definitions
1370         https://bugs.webkit.org/show_bug.cgi?id=208866
1371
1372         Reviewed by Michael Catanzaro.
1373
1374         * Scripts/webkitperl/FeatureList.pm:
1375
1376 2020-03-10  Aakash Jain  <aakash_jain@apple.com>
1377
1378         [ews] Add unit tests for commit queue factory
1379         https://bugs.webkit.org/show_bug.cgi?id=208862
1380
1381         Reviewed by Jonathan Bedard.
1382
1383         * BuildSlaveSupport/ews-build/factories_unittest.py:
1384         (TestCommitQueueFactory):
1385         (TestCommitQueueFactory.test_commit_queue_factory): Added unit-test for commit-queue factory.
1386
1387 2020-03-10  Aakash Jain  <aakash_jain@apple.com>
1388
1389         [ews-app] Status bubble should only display important messages in pop-over - part 3
1390         https://bugs.webkit.org/show_bug.cgi?id=208865
1391
1392         Reviewed by Jonathan Bedard.
1393
1394         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1395         (StatusBubble): Added more strings to STEPS_TO_HIDE.
1396
1397 2020-03-10  Lauro Moura  <lmoura@igalia.com>
1398
1399         [WPE] MiniBrowser: Close child WebViews when exiting
1400         https://bugs.webkit.org/show_bug.cgi?id=208689
1401
1402         Reviewed by Carlos Garcia Campos.
1403
1404         Store created views so we can release them before exiting.
1405
1406         * MiniBrowser/wpe/main.cpp:
1407         (webViewClose):
1408         (createWebView):
1409         (main):
1410
1411 2020-03-10  Aakash Jain  <aakash_jain@apple.com>
1412
1413         Add ValidateCommiterAndReviewer and ValidateChangeLogAndReviewer build steps in commit-queue
1414         https://bugs.webkit.org/show_bug.cgi?id=208861
1415
1416         Reviewed by Jonathan Bedard.
1417
1418         * BuildSlaveSupport/ews-build/factories.py:
1419         (Factory.__init__): Remove verifycqplus parameter.
1420         (CommitQueueFactory): Inherit from factory.BuildFactory base class instead of custom Factory class.
1421         (CommitQueueFactory.__init__): Add required build steps, especially ValidateCommiterAndReviewer, 
1422         UpdateWorkingDirectory and ValidateChangeLogAndReviewer.
1423
1424 2020-03-10  Philippe Normand  <pnormand@igalia.com>
1425
1426         [GTK] API favicon test flaky timeouts
1427         https://bugs.webkit.org/show_bug.cgi?id=208189
1428
1429         Reviewed by Carlos Garcia Campos.
1430
1431         Sometimes the favicon changes already during the load. Keeping
1432         track of it in the WebView favicon property notification handler
1433         gets us rid of the race.
1434
1435         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
1436         (testFaviconDatabaseGetFavicon):
1437
1438 2020-03-10  Aakash Jain  <aakash_jain@apple.com>
1439
1440         Generate commit-queue status bubble from new EWS
1441         https://bugs.webkit.org/show_bug.cgi?id=208811
1442
1443         Reviewed by Jonathan Bedard.
1444
1445         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1446         (StatusBubble._build_bubbles_for_patch):
1447
1448 2020-03-09  Don Olmstead  <don.olmstead@sony.com>
1449
1450         Remove obsolete feature flags
1451         https://bugs.webkit.org/show_bug.cgi?id=208830
1452
1453         Reviewed by Alex Christensen.
1454
1455         Remove ENABLE_CUSTOM_SCHEME_HANDLER and ENABLE_MAC_VIDEO_TOOLBOX since they
1456         are no longer used.
1457
1458         Also remove ENABLE_POINTER_EVENTS since the FeaturesDefines.xcconfig was not modified
1459         when the compilation flag was removed in r258148.
1460
1461         Remove ENABLE_ACCELERATED_OVERFLOW_SCROLLING, ENABLE_CSS_IMAGE_ORIENTATION,
1462         ENABLE_CUSTOM_SCHEME_HANDLER, and ENABLE_FETCH_API from FeatureList.pm.
1463
1464         * Scripts/webkitperl/FeatureList.pm:
1465         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1466
1467 2020-03-09  Kate Cheney  <katherine_cheney@apple.com>
1468
1469         WebKitTestRunner bundleID should not be cleared before every test
1470         https://bugs.webkit.org/show_bug.cgi?id=208823
1471         <rdar://problem/60204539>
1472
1473         Reviewed by Per Arne Vollan.
1474
1475         This is causing test failures for layout tests which rely on the Info.plist 
1476         bundle identifier (not the one set via the override method).
1477
1478         * WebKitTestRunner/TestController.cpp:
1479         (WTR::TestController::createWebViewWithOptions):
1480         (WTR::TestController::ensureViewSupportsOptionsForTest):
1481         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1482
1483 2020-03-09  Per Arne Vollan  <pvollan@apple.com>
1484
1485         [macOS] Notification observer is not removed
1486         https://bugs.webkit.org/show_bug.cgi?id=208834
1487
1488         Reviewed by Tim Horton.
1489
1490         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1491         * TestWebKitAPI/Tests/WebKit/EnableAccessibility.mm: Added.
1492         (TEST):
1493
1494 2020-03-06  Brian Burg  <bburg@apple.com>
1495
1496         upload.py gets confused by git-svn checkouts, unable to upload test results from my desk build
1497         https://bugs.webkit.org/show_bug.cgi?id=208729
1498         <rdar://problem/60105447>
1499
1500         Reviewed by Jonathan Bedard.
1501
1502         Improve upload.py to look for the svn branch and revision for the 'webkit'
1503         project and prefer those to the git equivalents (eg, prefer trunk/rNNNNN to master/<hash>).
1504
1505         * Scripts/webkitpy/common/checkout/scm/git.py:
1506         (Git):
1507         (Git.git_svn_id_regexp):
1508         (Git._field_from_git_svn_id):
1509         (Git.svn_revision):
1510         (Git.svn_branch):
1511         (Git.svn_url):
1512         (Git.native_branch):
1513         Refactor svn revision, branch, url to use the same regexp and helper code.
1514
1515         * Scripts/webkitpy/common/checkout/scm/stub_repository.py:
1516         (StubRepository.svn_branch):
1517         Expose a stub since this is used unconditionally by Port.commits_for_upload.
1518
1519         * Scripts/webkitpy/common/checkout/scm/svn.py:
1520         (SVN.svn_branch):
1521         (SVN.native_revision):
1522         (SVN):
1523         (SVN.native_branch):
1524         Refactor so the actual implementation is contained in svn_revision / svn_branch.
1525         The native_* methods call out to the SVN equivalents since this is an SVN repository.
1526
1527         * Scripts/webkitpy/port/base.py:
1528         (Port.commits_for_upload):
1529         Add special git-svn handling for the WebKit repository so that SVN branch and revision
1530         is preferred over the git equivalents.
1531
1532 2020-03-09  Antoine Quint  <graouts@apple.com>
1533
1534         TestWebKitAPI fails to build on watchOS
1535         https://bugs.webkit.org/show_bug.cgi?id=208820
1536
1537         Reviewed by Tim Horton.
1538
1539         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
1540
1541 2020-03-09  Jonathan Bedard  <jbedard@apple.com>
1542
1543         resultsdbpy: Add tool to manage resultsdbpy container
1544         https://bugs.webkit.org/show_bug.cgi?id=208743
1545
1546         Rubber-stamped by Aakash Jain.
1547
1548         Add tool to start, stop and restart the resultsdbpy Docker container.
1549
1550         * resultsdbpy/resultsdbpy/container: Added.
1551
1552 2020-03-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1553
1554         [GTK][WPE] Surrounding text for input methods should not be limited to the current paragraph
1555         https://bugs.webkit.org/show_bug.cgi?id=208706
1556
1557         Reviewed by Žan Doberšek.
1558
1559         Add test case to check surrounding text in multiline context.
1560
1561         * TestWebKitAPI/Tests/WebKitGLib/TestInputMethodContext.cpp:
1562         (testWebKitInputMethodContextSurrounding):
1563
1564 2020-03-08  Per Arne Vollan  <pvollan@apple.com>
1565
1566         [iOS] Mapping to UTI from tag and tag class should be performed in the UI process
1567         https://bugs.webkit.org/show_bug.cgi?id=208783
1568
1569         Reviewed by Brent Fulgham.
1570
1571         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1572
1573 2020-03-07  Ross Kirsling  <ross.kirsling@sony.com>
1574
1575         Replace the use of term "rollout" to "revert" in various tools
1576         https://bugs.webkit.org/show_bug.cgi?id=208775
1577
1578         Reviewed by Ryosuke Niwa.
1579
1580         See this webkit-dev thread for the originating discussion:
1581         https://lists.webkit.org/pipermail/webkit-dev/2020-March/031132.html
1582
1583         'rollout' is a confusing term to anyone unacquainted with WebKit;
1584         consensus seems to be that 'revert' would be the best replacement (as opposed to 'rollback').
1585
1586         Given the long legacy of this term within WebKit, it's important to deprecate and not remove 'rollout' commands.
1587         As such, this patch aims to make 'revert' the preferred term everywhere without making 'rollout' fail.
1588
1589         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Trac.js:
1590         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
1591         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1592         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js:
1593         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/trac_unittests.js:
1594         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1595         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
1596         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js:
1597         * BuildSlaveSupport/ews-build/steps.py:
1598         * BuildSlaveSupport/ews-build/steps_unittest.py:
1599         * Scripts/webkit-tools-completion.sh:
1600         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1601         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1602         * Scripts/webkitpy/common/checkout/scm/svn.py:
1603         * Scripts/webkitpy/common/net/bugzilla/attachment.py:
1604         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
1605         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1606         * Scripts/webkitpy/tool/bot/feeders.py:
1607         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
1608         * Scripts/webkitpy/tool/bot/irc_command.py:
1609         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1610         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
1611         * Scripts/webkitpy/tool/bot/sheriff.py:
1612         * Scripts/webkitpy/tool/commands/download.py:
1613         * Scripts/webkitpy/tool/commands/download_unittest.py:
1614         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1615         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
1616         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1617         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
1618         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1619         * Scripts/webkitpy/tool/steps/__init__.py:
1620         * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
1621         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
1622         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
1623         * Scripts/webkitpy/tool/steps/reopenbugafterrevert.py: Renamed from Tools/Scripts/webkitpy/tool/steps/reopenbugafterrollout.py.
1624
1625 2020-03-07  David Quesada  <david_quesada@apple.com>
1626
1627         Crash in -[_WKRemoteObjectRegistry _invokeMethod:] block when calling a reply block after the web view has deallocated
1628         https://bugs.webkit.org/show_bug.cgi?id=208781
1629         rdar://problem/60061016
1630
1631         Reviewed by Alex Christensen.
1632
1633         Add a test that recreates the conditions of this crash:
1634         - Send a message from the injected bundle to the UI process that contains a reply block.
1635         - Hold a reference to the reply block.
1636         - Let the web view deallocate.
1637         - Call the block, and expect not to crash.
1638
1639         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.h:
1640         (localObjectInterface):
1641         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.mm:
1642         (-[LocalObject doSomethingWithCompletionHandler:]):
1643         (TEST):
1644         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistryPlugIn.mm:
1645         (-[RemoteObjectRegistryPlugIn callUIProcessMethodWithReplyBlock]):
1646
1647 2020-03-07  Ryosuke Niwa  <rniwa@webkit.org>
1648
1649         TextManipulationController should work with ARIA labels
1650         https://bugs.webkit.org/show_bug.cgi?id=208759
1651
1652         Reviewed by Wenson Hsieh.
1653
1654         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
1655         (TextManipulation.StartTextManipulationFindAttributeContent): Added.
1656         (TextManipulation.CompleteTextManipulationShouldPreserveOrderOfBlockImage): Updated
1657         the expected number of tokens for the first item as the very first image is correctly
1658         detected per the code change. 
1659         (TextManipulation.CompleteTextManipulationShouldReplaceAttributeContent): Added.
1660
1661 2020-03-07  Alex Christensen  <achristensen@webkit.org>
1662
1663         Regression r258042: Failing API test TestWebKitAPI.URLSchemeHandler.Frames
1664         https://bugs.webkit.org/show_bug.cgi?id=208767
1665
1666         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
1667         The frameID of the main frame before loading is only 0 on Mac right now.
1668         The test is still good because it validates that execution works in the main frame before loading.
1669
1670 2020-03-06  Aakash Jain  <aakash_jain@apple.com>
1671
1672         [ews] commit queue is not skipping layout tests for rollout patches
1673         https://bugs.webkit.org/show_bug.cgi?id=208716
1674
1675         Unreviewed minor fix.
1676
1677         * BuildSlaveSupport/ews-build/steps.py:
1678         (RunWebKitTests.doStepIf):
1679         (RunWebKit1Tests.doStepIf): Moved to base class RunWebKitTests.
1680         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-test.
1681
1682 2020-03-05  Sam Weinig  <weinig@apple.com>
1683
1684         Move JavaScriptCore related feature defines from FeatureDefines.xcconfig to PlatformEnableCocoa.h
1685         https://bugs.webkit.org/show_bug.cgi?id=207436
1686         <rdar://problem/59296762>
1687
1688         Reviewed by Darin Adler.
1689
1690         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1691         Remove JSC related defines.
1692
1693 2020-03-07  Chris Fleizach  <cfleizach@apple.com>
1694
1695         AX: Provide a way to run tests in isolated tree mode
1696         https://bugs.webkit.org/show_bug.cgi?id=208629
1697         <rdar://problem/60075583>
1698
1699         Reviewed by Ryosuke Niwa.
1700
1701         Provide the ability to run tests for accessibility in the isolated tree mode.
1702         This sends a flag over to the injected bundle which calls the right HIServices override so that
1703         the system thinks it is in isolated mode.
1704
1705         * Scripts/compare-webkit-configurations:
1706         (flag_for_comparison):
1707         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1708         (parse_args):
1709         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1710         (parse_args):
1711         * Scripts/webkitpy/port/driver.py:
1712         (Driver.cmd_line):
1713         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1714         (WTR::AccessibilityController::AccessibilityController):
1715         (WTR::AccessibilityController::setAccessibilityIsolatedTreeMode):
1716         (WTR::AccessibilityController::updateIsolatedTreeMode):
1717         (WTR::AccessibilityController::executeOnAXThreadIfPossible):
1718         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
1719         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1720         (WTR::InjectedBundle::didReceiveMessageToPage):
1721         (WTR::InjectedBundle::beginTesting):
1722         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1723         * WebKitTestRunner/Options.cpp:
1724         (WTR::handleOptionAccessibilityIsolatedTreeMode):
1725         (WTR::OptionsHandler::OptionsHandler):
1726         * WebKitTestRunner/Options.h:
1727         * WebKitTestRunner/TestController.cpp:
1728         (WTR::TestController::initialize):
1729         (WTR::TestController::resetPreferencesToConsistentValues):
1730         (WTR::TestController::resetStateToConsistentValues):
1731         * WebKitTestRunner/TestController.h:
1732         (WTR::TestController::accessibilityIsolatedTreeMode const):
1733
1734 2020-03-06  Per Arne Vollan  <pvollan@apple.com>
1735
1736         [Cocoa] Re-enable CFPrefs direct mode
1737         https://bugs.webkit.org/show_bug.cgi?id=208690
1738
1739         Reviewed by Brent Fulgham.
1740
1741         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1742         * TestWebKitAPI/Tests/WebKit/GrantAccessToPreferencesService.mm: Added.
1743         (TEST):
1744         * TestWebKitAPI/Tests/ios/AccessibilityTestsIOS.mm:
1745         (TestWebKitAPI::TEST):
1746
1747 2020-03-06  Kate Cheney  <katherine_cheney@apple.com>
1748
1749         UIProcess needs mechanism to specify AppBound domains
1750         https://bugs.webkit.org/show_bug.cgi?id=208528
1751         <rdar://problem/59980340>
1752
1753         Reviewed by Brent Fulgham.
1754
1755         Added test app-bound domains to the plist and tested that the domains
1756         are properly stored in the website data store after a navigation.
1757
1758         * TestWebKitAPI/Info.plist:
1759         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
1760         (TEST):
1761
1762 2020-03-06  Alex Christensen  <achristensen@webkit.org>
1763
1764         Add SPI to disable cross origin access control checks
1765         https://bugs.webkit.org/show_bug.cgi?id=208748
1766
1767         Reviewed by Tim Hatcher.
1768
1769         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
1770         Add a test that verifies this SPI allows Access-Control-Allow-Origin: * with credentials.
1771
1772 2020-03-06  Basuke Suzuki  <basuke.suzuki@sony.com>
1773
1774         [webkitpy] Fix executive on Windows to run wpt server correctly
1775         https://bugs.webkit.org/show_bug.cgi?id=208693
1776
1777         Reviewed by Jonathan Bedard.
1778
1779         Bug fix for Windows environment a) fixing a typo. b) fixing path
1780         c) fix how to kill subprocesses.
1781
1782         * Scripts/webkitpy/common/system/executive.py:
1783         (Executive._windows_kill_command):
1784         (Executive.interrupt):
1785         (Executive.kill_all):
1786         * Scripts/webkitpy/port/base.py:
1787         (Port.web_platform_test_server_doc_root):
1788
1789 2020-03-06  Alex Christensen  <achristensen@webkit.org>
1790
1791         Evaluating JavaScript in main frame before loading should succeed
1792         https://bugs.webkit.org/show_bug.cgi?id=208733
1793
1794         Reviewed by Tim Horton.
1795
1796         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
1797
1798 2020-03-06  Ryosuke Niwa  <rniwa@webkit.org>
1799
1800         TextManipulationController should preserve images
1801         https://bugs.webkit.org/show_bug.cgi?id=208692
1802
1803         Reviewed by Wenson Hsieh.
1804
1805         Added tests for preserving images and their ordering.
1806
1807         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
1808         (TextManipulation.CompleteTextManipulationShouldPreserveImagesAsExcludedTokens):
1809         (TextManipulation.CompleteTextManipulationShouldPreserveSVGAsExcludedTokens):
1810         (TextManipulation.CompleteTextManipulationShouldPreserveOrderOfBlockImage):
1811
1812 2020-03-06  David Quesada  <david_quesada@apple.com>
1813
1814         Add _WKResourceLoadInfo.resourceType SPI
1815         https://bugs.webkit.org/show_bug.cgi?id=208723
1816
1817         Reviewed by Alex Christensen.
1818
1819         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
1820         (TEST):
1821
1822 2020-03-06  Jonathan Bedard  <jbedard@apple.com>
1823
1824         Stop reporting to webkit-test-results.webkit.org
1825         https://bugs.webkit.org/show_bug.cgi?id=207218
1826
1827         Reviewed by Alexey Proskuryakov.
1828
1829         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1830         (RunWebKitTests):
1831
1832 2020-03-06  Sihui Liu  <sihui_liu@apple.com>
1833
1834         UIProcess crash after using _prepareForMoveToWindow, then deallocating the WKWebView before moving to the window
1835         https://bugs.webkit.org/show_bug.cgi?id=208365
1836         <rdar://problem/59877296>
1837
1838         Reviewed by Geoffrey Garen.
1839
1840         * TestWebKitAPI/Tests/WebKitCocoa/PrepareForMoveToWindow.mm:
1841         (TEST):
1842
1843 2020-03-06  Aakash Jain  <aakash_jain@apple.com>
1844
1845         EWS should be able to fetch patch status for security bugs while processing them
1846         https://bugs.webkit.org/show_bug.cgi?id=206511
1847
1848         Reviewed by Alexey Proskuryakov.
1849
1850         * BuildSlaveSupport/ews-build/steps.py:
1851         (BugzillaMixin.fetch_data_from_url_with_authentication): Method to fetch data from bugzilla using api key.
1852         (BugzillaMixin.get_patch_json): 
1853         (BugzillaMixin.get_bug_json):
1854         (BugzillaMixin._is_bug_closed):
1855         (ApplyPatch.hideStepIf): Use 'sensitive' build property instead of 'validated'.
1856         (TransferToS3.hideStepIf): Ditto.
1857
1858 2020-03-06  Aakash Jain  <aakash_jain@apple.com>
1859
1860         [ews] commit-queue should show the trac url for the commit on the build page
1861         https://bugs.webkit.org/show_bug.cgi?id=208715
1862
1863         Reviewed by Jonathan Bedard.
1864
1865         * BuildSlaveSupport/ews-build/steps.py:
1866         (PushCommitToWebKitRepo.evaluateCommand):
1867
1868 2020-03-06  Alex Christensen  <achristensen@webkit.org>
1869
1870         Fix ResourceLoadDelegate.LoadInfo API test after r257816
1871         https://bugs.webkit.org/show_bug.cgi?id=208550
1872
1873         * TestWebKitAPI/cocoa/HTTPServer.mm:
1874         (TestWebKitAPI::HTTPServer::respondToRequests):
1875         Sometimes we need a separate read to read the HTTP body after a request header, sometimes it comes in the same read.
1876         If it comes in the same read, send the response immediately.  Otherwise read the HTTP body then send the response.
1877
1878 2020-03-06  Lauro Moura <lmoura@igalia.com>
1879
1880         [WPE][WebDriver] MiniBrowser should react to close session commands
1881         https://bugs.webkit.org/show_bug.cgi?id=207529
1882
1883         Reviewed by Carlos Garcia Campos.
1884
1885         Do not call g_object_unref on the first created view if it has already
1886         been disposed in the "close" signal handler.
1887
1888         Based on original patch by Yury Semikhatsky.
1889
1890         * MiniBrowser/wpe/main.cpp:
1891         (main):
1892
1893 2020-03-06  Michael Catanzaro  <mcatanzaro@gnome.org>
1894
1895         [WPE][GTK] Use Firefox user agent quirk more aggressively on Google Docs
1896         https://bugs.webkit.org/show_bug.cgi?id=208647
1897
1898         Reviewed by Carlos Garcia Campos.
1899
1900         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1901         (TestWebKitAPI::TEST):
1902
1903 2020-03-05  Alex Christensen  <achristensen@webkit.org>
1904
1905         Add WKNavigationDelegatePrivate SPI to inform application of subframe navigations
1906         https://bugs.webkit.org/show_bug.cgi?id=208670
1907
1908         Reviewed by Brady Eidson.
1909
1910         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
1911         (-[FrameNavigationDelegate waitForNavigations:]):
1912         (-[FrameNavigationDelegate requests]):
1913         (-[FrameNavigationDelegate frames]):
1914         (-[FrameNavigationDelegate callbacks]):
1915         (-[FrameNavigationDelegate _webView:didStartProvisionalLoadWithRequest:inFrame:]):
1916         (-[FrameNavigationDelegate _webView:didFailProvisionalLoadWithRequest:inFrame:withError:]):
1917         (-[FrameNavigationDelegate _webView:didCommitLoadWithRequest:inFrame:]):
1918         (-[FrameNavigationDelegate _webView:didFailLoadWithRequest:inFrame:withError:]):
1919         (-[FrameNavigationDelegate _webView:didFinishLoadWithRequest:inFrame:]):
1920         (TEST):
1921
1922 2020-03-05  Alex Christensen  <achristensen@webkit.org>
1923
1924         Add WKFrameInfo._parentFrameHandle SPI
1925         https://bugs.webkit.org/show_bug.cgi?id=208674
1926
1927         Reviewed by Brady Eidson.
1928
1929         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
1930
1931 2020-03-05  Jiewen Tan  <jiewen_tan@apple.com>
1932
1933         [WebAuthn] Implement SPI -[_WKWebAuthenticationPanelDelegate panel:selectAssertionResponse:source:completionHandler:]
1934         https://bugs.webkit.org/show_bug.cgi?id=208626
1935         <rdar://problem/60074148>
1936
1937         Reviewed by Brent Fulgham.
1938
1939         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1940         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
1941         (-[TestWebAuthenticationPanelDelegate panel:selectAssertionResponse:source:completionHandler:]):
1942         (TestWebKitAPI::TEST):
1943         (-[TestWebAuthenticationPanelDelegate panel:selectAssertionResponse:completionHandler:]): Deleted.
1944         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-hid-multiple-accounts.html:
1945         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-la.html: Added.
1946
1947 2020-03-05  Antoine Quint  <graouts@apple.com>
1948
1949         Page-specific UserStyleSheets should wait until the initial empty document has been removed to be injected
1950         https://bugs.webkit.org/show_bug.cgi?id=208644
1951         <rdar://problem/60042429>
1952
1953         Reviewed by Brady Eidson.
1954
1955         Add new tests for -[_WKUserStyleSheet initWithSource:forWKWebView:forMainFrameOnly:userContentWorld:]) that check:
1956         
1957         1. that a _WKUserStyleSheet can be added immediately after a WKWebView's creation and will be injected once the initial
1958            empty document has been removed in favor of the document for the requested URL,
1959         2. that removing a _WKUserStyleSheet immediately after it was added but before the initial empty document was removed
1960            correctly does not injected the style sheet.
1961
1962         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
1963
1964 2020-03-05  Aakash Jain  <aakash_jain@apple.com>
1965
1966         [ews] Add build step to push commit to WebKit repository
1967         https://bugs.webkit.org/show_bug.cgi?id=208589
1968
1969         Reviewed by Jonathan Bedard.
1970
1971         * BuildSlaveSupport/ews-build/steps.py:
1972         (PushCommitToWebKitRepo): Build step to push the local commit to WebKit repository.
1973         (PushCommitToWebKitRepo.start): Initialize log observer.
1974         (PushCommitToWebKitRepo.evaluateCommand): Check command return status and comment on bug accordingly.
1975         (PushCommitToWebKitRepo.comment_text_for_bug): Generate comment text for commenting on bug.
1976         (PushCommitToWebKitRepo.svn_revision_from_commit_text): Extract the svn revision from commit text.
1977         (PushCommitToWebKitRepo.getResultSummary): Set custom failure message.
1978         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1979         * BuildSlaveSupport/ews-build/factories.py:
1980
1981 2020-03-05  Aakash Jain  <aakash_jain@apple.com>
1982
1983         [ews] Add unit tests for ValidateCommiterAndReviewer build step
1984         https://bugs.webkit.org/show_bug.cgi?id=208262
1985
1986         Reviewed by Jonathan Bedard.
1987
1988         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests for ValidateCommiterAndReviewer.
1989
1990 2020-03-05  Aakash Jain  <aakash_jain@apple.com>
1991
1992         commit-queue should run WK2 tests instead of WK1 tests
1993         https://bugs.webkit.org/show_bug.cgi?id=208544
1994
1995         Reviewed by Jonathan Bedard.
1996
1997         * BuildSlaveSupport/ews-build/factories.py:
1998
1999 2020-03-05  Aakash Jain  <aakash_jain@apple.com>
2000
2001         [ews] ValidateCommiterAndReviewer should validate emails in case insensitive manner
2002         https://bugs.webkit.org/show_bug.cgi?id=208645
2003
2004         Reviewed by Alexey Proskuryakov.
2005
2006         * BuildSlaveSupport/ews-build/steps.py:
2007         (ValidateCommiterAndReviewer.load_contributors):
2008         (ValidateCommiterAndReviewer.start):
2009
2010 2020-03-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2011
2012         style-checker: Add UAF to the list of security words to warn about.
2013         https://bugs.webkit.org/show_bug.cgi?id=208643
2014
2015         Reviewed by Jonathan Bedard.
2016
2017         UAF is a common acronym used for use after free.
2018
2019         * Scripts/webkitpy/style/checkers/changelog.py:
2020         (ChangeLogChecker.check_for_unwanted_security_phrases):
2021
2022 2020-03-04  Basuke Suzuki  <basuke.suzuki@sony.com>
2023
2024         [MSVC] Add .natvis support of WebKit types
2025         https://bugs.webkit.org/show_bug.cgi?id=193119
2026
2027         Reviewed by Don Olmstead.
2028
2029         To help the WebKit developer while debugging, this file defines how
2030         WebKit types are displayed in debugger of Visual Studio.
2031         Very limited set of WebKit types, but it changes the world.
2032
2033         * VisualStudio/WebKit.natvis: Added.
2034
2035 2020-03-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2036
2037         Add system trace points around display list replay
2038         https://bugs.webkit.org/show_bug.cgi?id=208616
2039
2040         Reviewed by Simon Fraser.
2041
2042         Add a new "Display list replay" trace point.
2043
2044         * Tracing/SystemTracePoints.plist:
2045
2046 2020-03-04  Alex Christensen  <achristensen@webkit.org>
2047
2048         Call globalObjectIsAvailableForFrame before evaluating JavaScript in newly created worlds
2049         https://bugs.webkit.org/show_bug.cgi?id=208615
2050         <rdar://problem/59406743>
2051
2052         Reviewed by Alex Christensen.
2053
2054         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2055         * TestWebKitAPI/Tests/WebKitCocoa/ContentWorldPlugIn.mm: Added.
2056         (-[ContentWorldPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2057         (-[ContentWorldPlugIn webProcessPlugInBrowserContextController:globalObjectIsAvailableForFrame:inScriptWorld:]):
2058         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
2059         (TEST):
2060         Also make a test written in bug 206310 actually run code.
2061
2062 2020-03-04  Aakash Jain  <aakash_jain@apple.com>
2063
2064         [build.webkit.org] Remove leaks queue
2065         https://bugs.webkit.org/show_bug.cgi?id=208580
2066
2067         Reviewed by Jonathan Bedard.
2068
2069         * BuildSlaveSupport/build.webkit.org-config/config.json:
2070         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2071         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2072
2073 2020-03-04  Alex Christensen  <achristensen@webkit.org>
2074
2075         Add SPI to evaluate JavaScript in an iframe
2076         https://bugs.webkit.org/show_bug.cgi?id=208605
2077
2078         Reviewed by Brady Eidson.
2079
2080         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
2081
2082 2020-03-03  Jiewen Tan  <jiewen_tan@apple.com>
2083
2084         [WebAuthn] Implement -[_WKWebAuthenticationPanelDelegate panel:decidePolicyForLocalAuthenticatorWithCompletionHandler:] SPI
2085         https://bugs.webkit.org/show_bug.cgi?id=208533
2086         <rdar://problem/60010184>
2087
2088         Reviewed by Alex Christensen.
2089
2090         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2091         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
2092         (-[TestWebAuthenticationPanelDelegate panel:decidePolicyForLocalAuthenticatorWithCompletionHandler:]):
2093         (TestWebKitAPI::TEST):
2094         (-[TestWebAuthenticationPanelDelegate panel:verifyUserWithAccessControl:completionHandler:]): Deleted.
2095         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-la.html: Removed.
2096
2097 2020-03-04  Alex Christensen  <achristensen@webkit.org>
2098
2099         callAsyncJavaScript with an invalid parameter and no completionHandler should not crash
2100         https://bugs.webkit.org/show_bug.cgi?id=208593
2101
2102         Reviewed by Brady Eidson.
2103
2104         * TestWebKitAPI/Tests/WebKitCocoa/AsyncFunction.mm:
2105         (TestWebKitAPI::TEST):
2106
2107 2020-03-04  Alex Christensen  <achristensen@webkit.org>
2108
2109         WKWebView's frames accessor should return a traversable type
2110         https://bugs.webkit.org/show_bug.cgi?id=208591
2111
2112         Reviewed by Brady Eidson.
2113
2114         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
2115
2116 2020-03-04  Antoine Quint  <graouts@apple.com>
2117
2118         Add an SPI to allow UserStyleSheet injection to target a specific WKWebView
2119         https://bugs.webkit.org/show_bug.cgi?id=208575
2120         <rdar://problem/59773690>
2121
2122         Reviewed by Brady Eidson.
2123
2124         Add new tests for the new SPI which check:
2125         
2126         1. that specifying forWKWebView: when initializing a _WKUserStyleSheet will inject the provided CSS source in the
2127            specified WKWebView alone,
2128         2. that the same test works with two WKWebViews with a shared WKWebKitConfiguration,
2129         3. that a WKWebView-specific _WKUserStyleSheet can be removed,
2130         4. that a WKWebView-specific _WKUserStyleSheet can be added twice and removed once and be removed as expected,
2131         5. and that a WKWebView-specific _WKUserStyleSheet is automatically removed when navigating to a new page,
2132         6. and that the same test also works with PSON enabled.
2133
2134         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
2135
2136 2020-03-04  Ryan Haddad  <ryanhaddad@apple.com>
2137
2138         [macOS] test-lldb-webkit failing on debug bots
2139         https://bugs.webkit.org/show_bug.cgi?id=208545
2140
2141         Reviewed by Jonathan Bedard.
2142
2143         The lldb-webkit-test step must pass in the build configuration as an
2144         argument to the test-lldb-webkit script so that it uses the lldbWebKitTester
2145         binary that is downloaded with the rest of the build products. Without this
2146         argument, the bots expect to find the binary in the 'WebKitBuild/Release' directory
2147         regardless of their actual build configuration.
2148
2149         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2150         (RunLLDBWebKitTests): Pass in the build configuration to the test-lldb-webkit script.
2151         * Scripts/test-lldb-webkit:
2152         (LldbTester.parse_args): Capitalize the constants for Debug / Release since that is what webkitpy expects.
2153
2154 2020-03-04  Aakash Jain  <aakash_jain@apple.com>
2155
2156         [ews] Add build step to create local git commit for commit-queue (follow-up fix)
2157         https://bugs.webkit.org/show_bug.cgi?id=208539
2158
2159         Unreviewed follow-up fix.
2160
2161         * BuildSlaveSupport/ews-build/steps.py:
2162
2163 2020-03-04  Daniel Bates  <dabates@apple.com>
2164
2165         Should use -bounds instead of -frame in RequestTextInputContext.mm tests
2166         https://bugs.webkit.org/show_bug.cgi?id=208565
2167
2168         Reviewed by Wenson Hsieh.
2169
2170         Pass the bounds of the web view to -synchronouslyRequestTextInputContextsInRect: instead
2171         of its frame as a means to find all the editable elements in the visible content area
2172         of the web view.
2173
2174         Coincidentally this makes no difference to the test results right now because the web view
2175         happens to be located at the origin (0, 0) in the window. However if in the future the
2176         web view would be located at some other point then the tests may fail because the rectangle
2177         passed to -synchronouslyRequestTextInputContextsInRect: would no longer represent the
2178         rectangle for the visible content area.
2179
2180         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2181         (TEST):
2182
2183 2020-03-04  Daniel Bates  <dabates@apple.com>
2184
2185         Organize tests in RequestTextInputContext.mm tests under test name RequestTextInputContext
2186         https://bugs.webkit.org/show_bug.cgi?id=208564
2187
2188         Reviewed by Alex Christensen.
2189
2190         Group the tests in RequestTextInputContext.mm under the test case name RequestTextInputContext
2191         to make it easy to run just these tests.
2192
2193         Currently, the tests are organized under the test case name WebKit. This means you need to
2194         pass run-api-tests the name of each sub-test as there is no easy way to run them all without
2195         also running all the TestWebKitAPI.WebKit sub-tests. Instead organize them under RequestTextInputContext
2196         so that a person can run just these test using:
2197         
2198                 run-api-tests --debug TestWebKitAPI.RequestTextInputContext
2199
2200         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2201         (TEST):
2202
2203 2020-03-04  Aakash Jain  <aakash_jain@apple.com>
2204
2205         [ews] Add build step to create local git commit for commit-queue
2206         https://bugs.webkit.org/show_bug.cgi?id=208539
2207
2208         Reviewed by Jonathan Bedard.
2209
2210         * BuildSlaveSupport/ews-build/steps.py:
2211         (CreateLocalGITCommit): Build step to create local git commit.
2212         (CreateLocalGITCommit.start):
2213         (CreateLocalGITCommit.getResultSummary): Set custom failure message.
2214         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests and restructured imports.
2215         * BuildSlaveSupport/ews-build/factories.py:
2216
2217 2020-03-04  Simon Fraser  <simon.fraser@apple.com>
2218
2219         (r256513) [ Mac ] fast/scrolling/programmatic-scroll-to-zero-zero.html is a flaky failure
2220         https://bugs.webkit.org/show_bug.cgi?id=207948
2221
2222         Reviewed by Zalan Bujtas.
2223
2224         EventSendingController needs to trigger layout so that the WebHTMLView is not 0x0,
2225         so that it receives the wheel events.
2226
2227         * DumpRenderTree/mac/EventSendingController.mm:
2228         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
2229         * DumpRenderTree/win/EventSender.cpp:
2230         (mouseScrollBy):
2231
2232 2020-03-04  Andres Gonzalez  <andresg_22@apple.com>
2233
2234         REGRESSION (r257739): two fast/events/autoscroll test have started to fail
2235         https://bugs.webkit.org/show_bug.cgi?id=208520
2236         <rdar://problem/60000214>
2237
2238         Reviewed by Chris Fleizach.
2239
2240         Calling InjectedBundle::singleton().page()->page() in the constructor
2241         of the AccessibilityController is having this side effect on iOS.
2242         So #if to MAC where it's actually being used.
2243
2244         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2245         (WTR::AccessibilityController::AccessibilityController):
2246
2247 2020-03-03  Alex Christensen  <achristensen@webkit.org>
2248
2249         Add SPI _WKResourceLoadInfo.loadedFromCache
2250         https://bugs.webkit.org/show_bug.cgi?id=208554
2251
2252         Reviewed by Wenson Hsieh.
2253
2254         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
2255         (TEST):
2256
2257 2020-03-03  Ryosuke Niwa  <rniwa@webkit.org>
2258
2259         Batch observations and completions of text manipulations
2260         https://bugs.webkit.org/show_bug.cgi?id=208406
2261
2262         Reviewed by Wenson Hsieh.
2263
2264         Updated the existing tests to use new APIs, and added new tests for batching finding & replacing
2265         multiple paragraphs at once.
2266
2267         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
2268         (-[TextManipulationDelegate _webView:didFindTextManipulationItems:]):
2269         (-[TextManipulationDelegate items]):
2270         (-[LegacyTextManipulationDelegate init]):
2271         (-[LegacyTextManipulationDelegate _webView:didFindTextManipulationItem:]):
2272         (TextManipulation.StartTextManipulationSupportsLegacyDelegateCallback): Added.
2273         (TextManipulation.LegacyCompleteTextManipulationReplaceSimpleSingleParagraph): Added.
2274         (TextManipulation.CompleteTextManipulationReplaceMultipleSimpleParagraphsAtOnce): Added.
2275         (TextManipulation.CompleteTextManipulationShouldBatchItemCallback): Added.
2276         (TextManipulation.CompleteTextManipulationFailWhenItemIdentifierIsDuplicated): Added.
2277         (TextManipulation.CompleteTextManipulationCanHandleSubsetOfItemsToFail): Added.
2278
2279 2020-03-03  Per Arne Vollan  <pvollan@apple.com>
2280
2281         [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
2282         https://bugs.webkit.org/show_bug.cgi?id=208415
2283
2284         Reviewed by Brent Fulgham.
2285
2286         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2287         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
2288         (TEST):
2289
2290 2020-03-03  Alex Christensen  <achristensen@webkit.org>
2291
2292         Add response to _WKResourceLoadDelegate didCompleteWithError callback
2293         https://bugs.webkit.org/show_bug.cgi?id=208553
2294
2295         Reviewed by Simon Fraser.
2296
2297         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
2298         (-[TestResourceLoadDelegate webView:resourceLoad:didCompleteWithError:response:]):
2299         (TEST):
2300         (-[TestResourceLoadDelegate webView:resourceLoad:didCompleteWithError:]): Deleted.
2301
2302 2020-03-03  Brady Eidson  <beidson@apple.com>
2303
2304         API Test [Mojave+ WK2 Debug ] TestWebKitAPI.WKAttachmentTestsMac.InsertDroppedFilePromisesAsAttachments is a flaky crash.
2305         https://bugs.webkit.org/show_bug.cgi?id=198795
2306
2307         Reviewed by Chris Dumez.
2308
2309         This test appears to no longer be flaky.
2310         
2311         Let's re-enable it.
2312         
2313         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2314         (TestWebKitAPI::TEST):
2315
2316 2020-03-03  Alex Christensen  <achristensen@webkit.org>
2317
2318         Requests sent to _WKResourceLoadDelegate should include HTTPBody
2319         https://bugs.webkit.org/show_bug.cgi?id=208550
2320
2321         Reviewed by Tim Hatcher.
2322
2323         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
2324         (TEST):
2325         * TestWebKitAPI/cocoa/HTTPServer.mm:
2326         (TestWebKitAPI::HTTPServer::respondToRequests):
2327         HTTPServer now looks for Content-Length in its request.
2328         If it finds this header, that means that the HTTP body is going to be received in another read, then the response should be sent after receiving that.
2329
2330 2020-03-03  Alex Christensen  <achristensen@webkit.org>
2331
2332         Expose originalURL and originalHTTPMethod on _WKResourceLoadInfo
2333         https://bugs.webkit.org/show_bug.cgi?id=208522
2334
2335         Reviewed by Brian Weinstein.
2336
2337         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
2338         (TEST):
2339
2340 2020-03-03  Aakash Jain  <aakash_jain@apple.com>
2341
2342         commit-queue should update working directory and reapply patch just before commiting
2343         https://bugs.webkit.org/show_bug.cgi?id=208521
2344
2345         Reviewed by Jonathan Bedard.
2346
2347         * BuildSlaveSupport/ews-build/factories.py:
2348
2349 2020-03-03  Matt Lewis  <jlewis3@apple.com>
2350
2351         Add Unittest to commits_for_upload() and fix multiple unittests for several test suites.
2352         https://bugs.webkit.org/show_bug.cgi?id=208485
2353
2354         Reviewed by Jonathan Bedard.
2355
2356         * Scripts/webkitpy/common/checkout/scm/stub_repository.py:
2357         (StubRepository.__init__): Fixing the constructor to call upon the parent class as we were not doing this before. It also means
2358         that we don't have to recreate the variables that are already created.
2359         * Scripts/webkitpy/common/checkout/scm/stub_repository_unittest.py: High level changed the imports to better reflect what we are using
2360         from each module, rather than making extra imports that we don't need.
2361         (StubRepositoryTest.mock_host_for_stub_repository): Since we are calling both an executive and a filesystem mock for most of the
2362         tests. it makes more sense to create a mock host with the files needed, than it does to instantiate each of these as separate objects
2363         and not part of the host.
2364         (StubRepositoryTest.test_in_working_directory): Changed the filesystem call to the host call.
2365         (StubRepositoryTest.test_native_revision): Changed the filesystem call to the host call.
2366         (StubRepositoryTest.test_native_branch): Changed the filesystem call to the host call.
2367         (StubRepositoryTest.test_svn_revision): Changed the filesystem call to the host call.
2368         (StubRepositoryTest.test_find_checkout_root): Changed the filesystem call to the host call.
2369         (StubRepositoryTest.test_find_checkout_root_failure): Changed the filesystem call to the host call.
2370         (StubRepositoryTest.test_find_parent_path_matching_callback_condition_with_file_system): Changed the filesystem call to the host call.
2371         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py: 
2372         (SummarizedResultsTest.test_svn_revision_exists): Changed the name to original test to better reflect that it was just looking to see
2373         if we were geting any value at all
2374         (SummarizedResultsTest.test_svn_revision): Added a test to make sure that the revision we are getting is what we expect to get and make
2375         sure we aren't gabking the wrong key:value pair
2376         * Scripts/webkitpy/port/base_unittest.py: Changed from MockSystemHost to MockHost as we want the extras that
2377         come with the MockHosts and MockHost inherits from MockSystemHost.
2378         (PortTest.make_port): Changed the port to call MockHost that will creat the required stub_repository files.
2379         (test_commits_for_upload): Added amissing test for commits_for_upload as this has been an issue when trying to make changes
2380         to the various upload steps.
2381
2382 2020-03-03  Aakash Jain  <aakash_jain@apple.com>
2383
2384         [ews] Add build step to find list of modified changelogs
2385         https://bugs.webkit.org/show_bug.cgi?id=208514
2386
2387         Reviewed by Jonathan Bedard.
2388
2389         * BuildSlaveSupport/ews-build/factories.py:
2390         * BuildSlaveSupport/ews-build/steps.py:
2391         (FindModifiedChangeLogs): Build step to find modified ChangeLogs.
2392         (FindModifiedChangeLogs.start): Initialize log observer.
2393         (FindModifiedChangeLogs.getResultSummary): Set custom failure message.
2394         (FindModifiedChangeLogs.evaluateCommand):
2395         (FindModifiedChangeLogs.is_path_to_changelog): Check if the file is a ChangeLog.
2396         (FindModifiedChangeLogs._status_regexp): Regex to match files from git output.
2397         (FindModifiedChangeLogs.extract_changelogs): Method to get list of ChangeLogs from git output.
2398         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
2399
2400 2020-03-03  Ryan Haddad  <ryanhaddad@apple.com>
2401
2402         [iOS EWS] TestWebKitAPI.WKWebsiteDataStore.RemoveAndFetchData is failing
2403         https://bugs.webkit.org/show_bug.cgi?id=208451
2404
2405         Unreviewed test gardening.
2406
2407         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm: Disable the test for iOS since it is slowing down EWS.
2408
2409 2020-03-03  Jiten Mehta  <jmehta@apple.com>
2410
2411         Adopt HTTP Alternative Services Storage
2412         https://bugs.webkit.org/show_bug.cgi?id=208387
2413
2414         Reviewed by Alex Christensen.
2415
2416         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2417         (checkUntilEntryFound):
2418         (TEST):
2419
2420 2020-03-03  Kate Cheney  <katherine_cheney@apple.com>
2421
2422         Check for navigation to app-bound domain during script evaluation
2423         https://bugs.webkit.org/show_bug.cgi?id=208319
2424         <rdar://problem/57569321>
2425
2426         Reviewed by Brent Fulgham.
2427
2428         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2429         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm: Added.
2430         (-[TestInAppBrowserScriptMessageHandler userContentController:didReceiveScriptMessage:]):
2431         (TEST):
2432         * TestWebKitAPI/Tests/WebKitCocoa/in-app-browser-privacy-test-user-agent-script.html: Added.
2433         * TestWebKitAPI/Tests/WebKitCocoa/in-app-browser-privacy-test-user-script.html: Added.
2434
2435 2020-03-03  Commit Queue  <commit-queue@webkit.org>
2436
2437         Unreviewed, rolling out r257754.
2438         https://bugs.webkit.org/show_bug.cgi?id=208513
2439
2440         Introduced API test failure (Requested by perarne on #webkit).
2441
2442         Reverted changeset:
2443
2444         "[Cocoa] Mapping from MIME type to UTI type should be done in
2445         the UI process"
2446         https://bugs.webkit.org/show_bug.cgi?id=208415
2447         https://trac.webkit.org/changeset/257754
2448
2449 2020-03-03  Diego Pino Garcia  <dpino@igalia.com>
2450
2451         REGRESSION(r257726): [GTK] LayoutTests crashing after r257726
2452         https://bugs.webkit.org/show_bug.cgi?id=208506
2453
2454         Reviewed by Carlos Garcia Campos.
2455
2456         * WebKitTestRunner/TestController.cpp:
2457         (WTR::TestController::platformAdjustContext): Remove unnecessary code.
2458
2459 2020-03-02  Ben Nham  <nham@apple.com>
2460
2461         Add performance probes for HTML parsing
2462         https://bugs.webkit.org/show_bug.cgi?id=208271
2463
2464         Reviewed by Daniel Bates.
2465
2466         This adds probes that show which lines of HTML are have been parsed.
2467
2468         * Tracing/SystemTracePoints.plist:
2469
2470 2020-03-02  Per Arne Vollan  <pvollan@apple.com>
2471
2472         [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
2473         https://bugs.webkit.org/show_bug.cgi?id=208415
2474
2475         Reviewed by Brent Fulgham.
2476
2477         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2478         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
2479         (TEST):
2480
2481 2020-03-02  Jacob Uphoff  <jacob_uphoff@apple.com>
2482
2483         Unreviewed, rolling out r257725.
2484
2485         This commit caused 10 API tests to fail
2486
2487         Reverted changeset:
2488
2489         "[Cocoa] Mapping from MIME type to UTI type should be done in
2490         the UI process"
2491         https://bugs.webkit.org/show_bug.cgi?id=208415
2492         https://trac.webkit.org/changeset/257725
2493
2494 2020-03-02  Saam Barati  <sbarati@apple.com>
2495
2496         Don't skip tests unnecessarily on arm64
2497         https://bugs.webkit.org/show_bug.cgi?id=208470
2498         <rdar://problem/59968869>
2499
2500         Reviewed by Tadeu Zagallo.
2501
2502         * Scripts/run-jsc-stress-tests:
2503
2504 2020-03-02  Andres Gonzalez  <andresg_22@apple.com>
2505
2506         Fix for LayoutTests/accessibility/mac/search-text/search-text.html in IsolatedTree mode.
2507         https://bugs.webkit.org/show_bug.cgi?id=208434
2508
2509         Reviewed by Chris Fleizach.
2510
2511         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2512         (WTR::AccessibilityController::AccessibilityController): Initializes m_useAXThread.
2513         (WTR::AccessibilityController::rootElement): No need to set m_useAXThread here since it is initialize in the constructor.
2514         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
2515         (WTR::AccessibilityController::accessibleElementById): Same as above.
2516
2517 2020-03-02  John Wilander  <wilander@apple.com>
2518
2519         ResourceLoadStatistics: Enable cookie blocking and the Storage Access API in ephemeral sessions
2520         https://bugs.webkit.org/show_bug.cgi?id=208399
2521         <rdar://problem/24731650>
2522
2523         Reviewed by Brent Fulgham.
2524
2525         The majority of the changes in WTR::TestController is (partially) fixing a bug
2526         where the TestRunner would statically use the default website datastore instead
2527         of the website data store configure for the page. This worked for persistent
2528         storage testing but not for ephemeral sessions which is what this patch is all
2529         about. The previous TestController::websiteDataStore() is now called
2530         TestController::defaultWebsiteDataStore() and the new
2531         TestController::websiteDataStore() returns the configured website data store.
2532         Most of the use of the default website data store should probably change but
2533         that's not really for this patch to deal with. I did however move all of
2534         resource load statistics' use to the new TestController::websiteDataStore().
2535
2536         A new TestRunner function was added: isStatisticsEphemeral()
2537         It allows test cases to query the ephemeral status of resource load statistics.
2538
2539         One problem that is mitigated in this patch but not fully fixed is that for
2540         Cocoa platforms, the TestRunner sets up two ephemeral sessions, once in
2541         TestController::generatePageConfiguration() via C API 
2542         WKPageConfigurationSetWebsiteDataStore(), and then again in 
2543         TestControllerCocoa's initializeWebViewConfiguration() via Cocoa API
2544         [copiedConfiguration setWebsiteDataStore:ephemeralWebsiteDataStore].
2545         I tried removing the latter since one session for all platforms should be
2546         Enough but got broken behavior as a result. So now both are still there
2547         and both enable resource load statistics.
2548
2549         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2550         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2551         (WTR::TestRunner::isStatisticsEphemeral):
2552         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2553         * WebKitTestRunner/TestController.cpp:
2554         (WTR::TestController::defaultWebsiteDataStore):
2555         (WTR::TestController::websiteDataStore):
2556         (WTR::TestController::generatePageConfiguration):
2557         (WTR::TestController::resetPreferencesToConsistentValues):
2558         (WTR::TestController::resetStateToConsistentValues):
2559         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2560         (WTR::TestController::decidePolicyForNavigationAction):
2561         (WTR::TestController::platformAdjustContext):
2562         (WTR::TestController::clearServiceWorkerRegistrations):
2563         (WTR::TestController::clearDOMCache):
2564         (WTR::TestController::clearDOMCaches):
2565         (WTR::TestController::clearIndexedDatabases):
2566         (WTR::TestController::clearLocalStorage):
2567         (WTR::TestController::hasDOMCache):
2568         (WTR::TestController::domCacheSize):
2569         (WTR::TestController::setStatisticsEnabled):
2570         (WTR::TestController::isStatisticsEphemeral):
2571         (WTR::TestController::setStatisticsDebugMode):
2572         (WTR::TestController::setStatisticsPrevalentResourceForDebugMode):
2573         (WTR::TestController::setStatisticsLastSeen):
2574         (WTR::TestController::setStatisticsMergeStatistic):
2575         (WTR::TestController::setStatisticsPrevalentResource):
2576         (WTR::TestController::setStatisticsVeryPrevalentResource):
2577         (WTR::TestController::dumpResourceLoadStatistics):
2578         (WTR::TestController::isStatisticsPrevalentResource):
2579         (WTR::TestController::isStatisticsVeryPrevalentResource):
2580         (WTR::TestController::isStatisticsRegisteredAsSubresourceUnder):
2581         (WTR::TestController::isStatisticsRegisteredAsSubFrameUnder):
2582         (WTR::TestController::isStatisticsRegisteredAsRedirectingTo):
2583         (WTR::TestController::setStatisticsHasHadUserInteraction):
2584         (WTR::TestController::isStatisticsHasHadUserInteraction):
2585         (WTR::TestController::isStatisticsOnlyInDatabaseOnce):
2586         (WTR::TestController::setStatisticsGrandfathered):
2587         (WTR::TestController::isStatisticsGrandfathered):
2588         (WTR::TestController::setUseITPDatabase):
2589         (WTR::TestController::setStatisticsSubframeUnderTopFrameOrigin):
2590         (WTR::TestController::setStatisticsSubresourceUnderTopFrameOrigin):
2591         (WTR::TestController::setStatisticsSubresourceUniqueRedirectTo):
2592         (WTR::TestController::setStatisticsSubresourceUniqueRedirectFrom):
2593         (WTR::TestController::setStatisticsTopFrameUniqueRedirectTo):
2594         (WTR::TestController::setStatisticsTopFrameUniqueRedirectFrom):
2595         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
2596         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
2597         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2598         (WTR::TestController::statisticsUpdateCookieBlocking):
2599         (WTR::TestController::statisticsSubmitTelemetry):
2600         (WTR::TestController::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
2601         (WTR::TestController::setStatisticsIsRunningTest):
2602         (WTR::TestController::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
2603         (WTR::TestController::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
2604         (WTR::TestController::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
2605         (WTR::TestController::setStatisticsGrandfatheringTime):
2606         (WTR::TestController::setStatisticsMaxStatisticsEntries):
2607         (WTR::TestController::setStatisticsPruneEntriesDownTo):
2608         (WTR::TestController::statisticsClearInMemoryAndPersistentStore):
2609         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
2610         (WTR::TestController::statisticsClearThroughWebsiteDataRemoval):
2611         (WTR::TestController::statisticsDeleteCookiesForHost):
2612         (WTR::TestController::isStatisticsHasLocalStorage):
2613         (WTR::TestController::setStatisticsCacheMaxAgeCap):
2614         (WTR::TestController::hasStatisticsIsolatedSession):
2615         (WTR::TestController::setStatisticsShouldDowngradeReferrer):
2616         (WTR::TestController::setStatisticsShouldBlockThirdPartyCookies):
2617         (WTR::TestController::setStatisticsFirstPartyWebsiteDataRemovalMode):
2618         (WTR::TestController::statisticsResetToConsistentState):
2619         (WTR::TestController::clearAdClickAttributionsThroughWebsiteDataRemoval):
2620         * WebKitTestRunner/TestController.h:
2621         * WebKitTestRunner/TestInvocation.cpp:
2622         (WTR::TestInvocation::invoke):
2623         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2624         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2625         (WTR::initializeWebViewConfiguration):
2626         (WTR::TestController::platformCreateWebView):
2627
2628 2020-03-02  Per Arne Vollan  <pvollan@apple.com>
2629
2630         [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
2631         https://bugs.webkit.org/show_bug.cgi?id=208415
2632
2633         Reviewed by Brent Fulgham.
2634
2635         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2636         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
2637         (TEST):
2638
2639 2020-03-02  Daniel Bates  <dabates@apple.com>
2640
2641         Page::editableElementsInRect() should find nested editable elements and return found elements in paint order
2642         https://bugs.webkit.org/show_bug.cgi?id=208352
2643         <rdar://problem/59867815>
2644
2645         Reviewed by Wenson Hsieh.
2646
2647         Update test results to reflect the new behavior. To do this I also need to fix up the test code
2648         to actually scroll the web content. This also means we now execute the same code on both Mac and
2649         iOS to do the scrolling: window.scrollTo(0, 5000). Also fixed up sub-test "Inputs scrolled outside
2650         the requested rect; should not be included." to use a 10000px height <div> so that you can scroll
2651         to a y position of 5000. Otherwise, it's impossible to do because the page height is < 5000px.
2652
2653         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2654         (TEST):
2655
2656 2020-03-02  Jacob Uphoff  <jacob_uphoff@apple.com>
2657
2658         Unreviewed, rolling out r257687.
2659
2660         This commit caused debug tests to crash for macOS & iOS
2661
2662         Reverted changeset:
2663
2664         "[Cocoa] Mapping from MIME type to UTI type should be done in
2665         the UI process"
2666         https://bugs.webkit.org/show_bug.cgi?id=208415
2667         https://trac.webkit.org/changeset/257687
2668
2669 2020-03-01  Wenson Hsieh  <wenson_hsieh@apple.com>
2670
2671         Unreviewed, rolling out r257618.
2672
2673         This allegedly causes Safari to crash when closing a window
2674         (see rdar://problem/59922725).
2675
2676         Reverted changeset:
2677
2678         "UIProcess crash after using _prepareForMoveToWindow, then
2679         deallocating the WKWebView before moving to the window"
2680         https://bugs.webkit.org/show_bug.cgi?id=208365
2681         https://trac.webkit.org/changeset/257618
2682
2683 2020-02-29  Yusuke Suzuki  <ysuzuki@apple.com>
2684
2685         Remove std::lock_guard
2686         https://bugs.webkit.org/show_bug.cgi?id=206451
2687
2688         Reviewed by Anders Carlsson.
2689
2690         Add std::lock_guard lint rule to prevent from using it.
2691
2692         * Scripts/webkitpy/style/checkers/cpp.py:
2693         (check_lock_guard):
2694         (check_style):
2695         (CppChecker):
2696         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2697         (WebKitStyleTest.test_lock_guard):
2698         * TestWebKitAPI/Tests/WTF/Condition.cpp:
2699         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
2700         * TestWebKitAPI/Tests/WTF/bmalloc/IsoHeap.cpp:
2701         (assertHasObjects):
2702         (assertHasOnlyObjects):
2703         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2704         (WTR::AXThread::dispatch):
2705         (WTR::AXThread::dispatchFunctionsFromAXThread):
2706         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
2707         (WTR::AXThread::initializeRunLoop):
2708
2709 2020-02-29  Per Arne Vollan  <pvollan@apple.com>
2710
2711         [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
2712         https://bugs.webkit.org/show_bug.cgi?id=208415
2713
2714         Reviewed by Brent Fulgham.
2715
2716         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2717         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
2718         (TEST):
2719
2720 2020-02-28  Fujii Hironori  <Hironori.Fujii@sony.com>
2721
2722         Unreviewed, rolling out r257565.
2723
2724         It broke WinCairo MiniBrowser
2725
2726         Reverted changeset:
2727
2728         "[CMake] Use WEBKIT_EXECUTABLE in MiniBrowser"
2729         https://bugs.webkit.org/show_bug.cgi?id=206894
2730         https://trac.webkit.org/changeset/257565
2731
2732 2020-02-28  Aakash Jain  <aakash_jain@apple.com>
2733
2734         EWS fails to retry build in case of kill-old-processes exception
2735         https://bugs.webkit.org/show_bug.cgi?id=208003
2736
2737         Reviewed by Jonathan Bedard.
2738
2739         * BuildSlaveSupport/ews-build/steps.py:
2740         (KillOldProcesses.evaluateCommand):
2741         (KillOldProcesses.getResultSummary):
2742
2743 2020-02-28  Aakash Jain  <aakash_jain@apple.com>
2744
2745         [ews] commit-queue should update the ChangeLog with Reviewer name
2746         https://bugs.webkit.org/show_bug.cgi?id=206535
2747
2748         Reviewed by Jonathan Bedard.
2749
2750         * BuildSlaveSupport/ews-build/steps.py:
2751         (ApplyPatch.start): Update the patch with the patch reviewer name if available.
2752
2753 2020-02-28  Jonathan Bedard  <jbedard@apple.com>
2754
2755         run-javascriptcore-tests: Make upload format valid
2756         https://bugs.webkit.org/show_bug.cgi?id=208341
2757
2758         Rubber-stamped by Aakash Jain.
2759
2760         * Scripts/run-javascriptcore-tests:
2761         (uploadResults): Remove. FIXME.
2762         * Scripts/webkitdirs.pm:
2763         (splitVersionString): Handle case where the subminor version number has a - in it.
2764         * Scripts/webkitperl/webkitdirs_unittest/splitVersion.pl: Add unit tests.
2765
2766 2020-02-28  youenn fablet  <youenn@apple.com>
2767
2768         [MacOS/iOS] Enable audio/video capture in GPUProcess by default
2769         https://bugs.webkit.org/show_bug.cgi?id=208130
2770
2771         Reviewed by Eric Carlson.
2772
2773         * WebKitTestRunner/TestOptions.h:
2774         Use GPU process to capture by default.
2775         We will remove this option once done verifying that every test works smoothly.
2776
2777 2020-02-28  Aakash Jain  <aakash_jain@apple.com>
2778
2779         [ews] commit queue should skip building and testing for rollout patches
2780         https://bugs.webkit.org/show_bug.cgi?id=208329
2781
2782         Reviewed by Jonathan Bedard.
2783
2784         * BuildSlaveSupport/ews-build/steps.py:
2785         (BugzillaMixin._is_patch_obsolete): Set rollout property appropriately.
2786         (CompileWebKit.doStepIf): Skip tests for rollout patches on commit-queue.
2787         (RunWebKit1Tests.doStepIf): Ditto.
2788         * BuildSlaveSupport/ews-build/steps_unittest.py:
2789         (TestCompileWebKit.test_skip_for_rollout_patches_on_commit_queue): Added unit-test.
2790         (TestRunWebKit1Tests.test_skip_for_rollout_patches_on_commit_queue): Ditto.
2791
2792 2020-02-28  Daniel Bates  <dabates@apple.com>
2793
2794         Update my watch list preferences and contributor's entry.
2795
2796         * Scripts/webkitpy/common/config/contributors.json:
2797         * Scripts/webkitpy/common/config/watchlist:
2798
2799 2020-02-27  Don Olmstead  <don.olmstead@sony.com>
2800
2801         Fix WebCore export macros for declspec
2802         https://bugs.webkit.org/show_bug.cgi?id=208363
2803
2804         Reviewed by Konstantin Tokarev.
2805
2806         Remove setting of WEBCORE_EXPORT and WEBCORE_TESTSUPPORT_EXPORT from the header
2807         files. Removed precompiled headers that were empty.
2808
2809         * DumpRenderTree/DumpRenderTreePrefix.h:
2810         * DumpRenderTree/win/DefaultPolicyDelegate.cpp: Added a missing config.h.
2811         * MiniBrowser/win/stdafx.h:
2812         * TestWebKitAPI/win/TestWebKitAPIPrefix.cpp: Removed.
2813         * TestWebKitAPI/win/TestWebKitAPIPrefix.h: Removed.
2814         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.cpp: Removed.
2815         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h: Removed.
2816         * WebKitTestRunner/PlatformFTW.cmake:
2817         * WebKitTestRunner/PlatformWin.cmake:
2818         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
2819
2820 2020-02-27  Tim Horton  <timothy_horton@apple.com>
2821
2822         UIProcess crash after using _prepareForMoveToWindow, then deallocating the WKWebView before moving to the window
2823         https://bugs.webkit.org/show_bug.cgi?id=208365
2824
2825         Reviewed by Alex Christensen.
2826
2827         * TestWebKitAPI/Tests/WebKitCocoa/PrepareForMoveToWindow.mm:
2828         (TEST):
2829         Add a test! It was a 100% repro crash before this change.
2830
2831 2020-02-27  Kate Cheney  <katherine_cheney@apple.com>
2832
2833         TestWebKitAPI and WebKitTestRunner should have bundle identifiers
2834         https://bugs.webkit.org/show_bug.cgi?id=208260
2835         <rdar://problem/59820107>
2836
2837         Reviewed by Tim Horton.
2838
2839         Followed instructions for adding an Info.plist for Single-File Tools
2840         found on https://developer.apple.com/library/archive/documentation/Security/Conceptual/CodeSigningGuide/Procedures/Procedures.html
2841
2842         The default WebsiteDataStore file path will change with this test to
2843         reflect the new bundleID so we must change expectations for any api
2844         tests which rely on knowing the path.
2845
2846         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2847         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2848         * TestWebKitAPI/Tests/WebKitCocoa/IDBDeleteRecovery.mm:
2849         (TEST):
2850         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
2851         (TEST):
2852         * TestWebKitAPI/Tests/WebKitCocoa/IDBObjectStoreInfoUpgradeToV2.mm:
2853         (TEST):
2854         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBStructuredCloneBackwardCompatibility.mm:
2855         (TEST):
2856         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
2857         (TEST):
2858         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm:
2859         (TEST):
2860         * TestWebKitAPI/Tests/WebKitCocoa/LocalStorageClear.mm:
2861         (TEST):
2862         (defaultWebsiteCacheDirectory):
2863         * TestWebKitAPI/Tests/WebKitCocoa/LocalStorageNullEntries.mm:
2864         (TEST):
2865         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2866         (TEST):
2867         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2868         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
2869         (TEST):
2870         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
2871         (TEST):
2872         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2873         (runWebsiteDataStoreCustomPaths):
2874         (TEST):
2875         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
2876         (TestWebKitAPI::resetTestState):
2877         Now that we set a bundleID, we have to reset the cache model between
2878         tests, otherwise it gets stored between tests.
2879
2880         (TestWebKitAPI::TEST):
2881         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
2882         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2883
2884 2020-02-27  Ryosuke Niwa  <rniwa@webkit.org>
2885
2886         TextManipulationController should not generate a new item for content in manipulated paragraphs
2887         https://bugs.webkit.org/show_bug.cgi?id=208286
2888
2889         Reviewed by Wenson Hsieh.
2890
2891         Added a regression test.
2892
2893         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
2894         (TextManipulation.InsertingContentIntoAlreadyManipulatedContentDoesNotCreateTextManipulationItem):
2895
2896 2020-02-27  Jonathan Bedard  <jbedard@apple.com>
2897
2898         run-javascriptcore-tests: Make upload format valid
2899         https://bugs.webkit.org/show_bug.cgi?id=208341
2900
2901         Reviewed by Aakash Jain.
2902
2903         * Scripts/run-javascriptcore-tests:
2904         (uploadResults): Print json blob for upload after failure for debugging.
2905
2906 2020-02-27  Don Olmstead  <don.olmstead@sony.com>
2907
2908         [CMake] Add WebKit::PAL target
2909         https://bugs.webkit.org/show_bug.cgi?id=198493
2910
2911         Reviewed by Michael Catanzaro.
2912
2913         Add workaround for Windows where PAL_FRAMEWORK_HEADERS_DIR is not propagating.
2914
2915         * DumpRenderTree/PlatformWin.cmake:
2916
2917 2020-02-27  Alex Christensen  <achristensen@webkit.org>
2918
2919         Add SPI to query WKFrameInfos in a WKWebView
2920         https://bugs.webkit.org/show_bug.cgi?id=208212
2921
2922         Reviewed by Brady Eidson.
2923
2924         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2925         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp: Removed.
2926         * WebKitTestRunner/TestController.cpp:
2927         (WTR::TestController::saltForOrigin):
2928
2929 2020-02-27  Jacob Uphoff  <jacob_uphoff@apple.com>
2930
2931         Unreviewed, rolling out r257530.
2932
2933         This commit seems to have broke the build internally for
2934         watchOS
2935
2936         Reverted changeset:
2937
2938         "Add SPI to query WKFrameInfos in a WKWebView"
2939         https://bugs.webkit.org/show_bug.cgi?id=208212
2940         https://trac.webkit.org/changeset/257530
2941
2942 2020-02-27  Don Olmstead  <don.olmstead@sony.com>
2943
2944         [CMake] Use WEBKIT_EXECUTABLE in MiniBrowser
2945         https://bugs.webkit.org/show_bug.cgi?id=206894
2946
2947         Reviewed by Adrian Perez de Castro.
2948
2949         Modify CMake ports to use WEBKIT_EXECUTABLE when creating their respective
2950         MiniBrowsers.
2951
2952         * MiniBrowser/gtk/CMakeLists.txt:
2953         * MiniBrowser/win/CMakeLists.txt:
2954         * MiniBrowser/wpe/CMakeLists.txt:
2955
2956 2020-02-26  Alex Christensen  <achristensen@webkit.org>
2957
2958         Remove unused WebsiteDataStore::setSourceApplicationBundleIdentifier
2959         https://bugs.webkit.org/show_bug.cgi?id=206456
2960
2961         Reviewed by Brady Eidson.
2962
2963         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2964         (TEST):
2965
2966 2020-02-26  Alex Christensen  <achristensen@webkit.org>
2967
2968         _WKUserContentWorld should be a wrapper around WKContentWorld
2969         https://bugs.webkit.org/show_bug.cgi?id=208274
2970
2971         Reviewed by Brady Eidson.
2972
2973         * TestWebKitAPI/Tests/WebKitCocoa/UserContentWorld.mm:
2974         (TEST):
2975         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
2976         (TEST):
2977
2978 2020-02-26  Ryan Haddad  <ryanhaddad@apple.com>
2979
2980         Unreviewed, rolling out r257522.
2981
2982         Caused 16 API test failures on the bots
2983
2984         Reverted changeset:
2985
2986         "TestWebKitAPI and WebKitTestRunner should have bundle
2987         identifiers"
2988         https://bugs.webkit.org/show_bug.cgi?id=208260
2989         https://trac.webkit.org/changeset/257522
2990
2991 2020-02-26  Alex Christensen  <achristensen@webkit.org>
2992
2993         Add SPI to query WKFrameInfos in a WKWebView
2994         https://bugs.webkit.org/show_bug.cgi?id=208212
2995
2996         Reviewed by Brady Eidson.
2997
2998         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2999         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp: Removed.
3000         * WebKitTestRunner/TestController.cpp:
3001         (WTR::TestController::saltForOrigin):
3002
3003 2020-02-26  Kate Cheney  <katherine_cheney@apple.com>
3004
3005         TestWebKitAPI and WebKitTestRunner should have bundle identifiers
3006         https://bugs.webkit.org/show_bug.cgi?id=208260
3007         <rdar://problem/59820107>
3008
3009         Reviewed by Tim Horton.
3010
3011         Followed instructions for adding an Info.plist for Single-File Tools
3012         found on https://developer.apple.com/library/archive/documentation/Security/Conceptual/CodeSigningGuide/Procedures/Procedures.html
3013
3014         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
3015         * TestWebKitAPI/Info.plist: Added.
3016         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3017         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
3018         * WebKitTestRunner/Info.plist: Added.
3019         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3020
3021 2020-02-26  Kate Cheney  <katherine_cheney@apple.com>
3022
3023         Tests should each use a unique ResourceLoadStatistics file path for its database store
3024         https://bugs.webkit.org/show_bug.cgi?id=208206
3025         <rdar://problem/59690272>
3026
3027         Reviewed by Brady Eidson.
3028
3029         Initialize a default website data store before checking for the ITP
3030         store to ensure the directory exists after the file has been deleted.
3031
3032         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3033         (TEST):
3034
3035 2020-02-26  Christopher Reid  <chris.reid@sony.com>
3036
3037         [Win] Implement NetworkCache::Data by using FileSystem::MappedFileData
3038         https://bugs.webkit.org/show_bug.cgi?id=197684
3039         <rdar://problem/59467397>
3040
3041         Reviewed by Yusuke Suzuki.
3042
3043         Add test for FileSystem::createFile
3044
3045         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
3046
3047 2020-02-26  Aakash Jain  <aakash_jain@apple.com>
3048
3049         [ews] commit-queue should verify patch committer and reviewer
3050         https://bugs.webkit.org/show_bug.cgi?id=206532
3051
3052         Reviewed by Jonathan Bedard.
3053
3054         * BuildSlaveSupport/ews-build/steps.py:
3055         (ValidateCommiterAndReviewer): Build step to validate patch commiter and reviewer.
3056         (ValidateCommiterAndReviewer._addToLog):
3057         (ValidateCommiterAndReviewer.getResultSummary):
3058         (ValidateCommiterAndReviewer.fail_build):
3059         (ValidateCommiterAndReviewer.load_contributors): Load contributors information.
3060         (ValidateCommiterAndReviewer.is_reviewer):
3061         (ValidateCommiterAndReviewer.is_committer):
3062         (ValidateCommiterAndReviewer.full_name_from_email):
3063         (ValidateCommiterAndReviewer.start):
3064
3065 2020-02-26  Daniel Bates  <dabates@apple.com>
3066
3067         [iOS] Send focus update immediately on becoming or resigning first responder
3068         https://bugs.webkit.org/show_bug.cgi?id=208082
3069         <rdar://problem/59688413>
3070
3071         Rubber-stamped by Jer Noble.
3072
3073         Add a test to ensure that selecting a position at a point after the web view
3074         becomes first responder is allowed. Such an operation is only allowed if the
3075         web view is focused.
3076
3077         * TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm:
3078         (-[TestWKWebView selectPositionAtPoint:]):
3079         (TEST):
3080         * TestWebKitAPI/ios/UIKitSPI.h: Forward declare SPI.
3081
3082 2020-02-26  Chris Dumez  <cdumez@apple.com>
3083
3084         Unreviewed, disable new DragAndDropTests.DragAndDropOnEmptyView API test on iOS.
3085
3086         The test was added for macOS and times out on iOS.
3087
3088         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
3089         (TEST):
3090
3091 2020-02-26  Youenn Fablet  <youenn@apple.com>
3092
3093         Use WebPageProxy preferences for capture instead of WebProcessPool configuration parameters
3094         https://bugs.webkit.org/show_bug.cgi?id=208238
3095
3096         Reviewed by Eric Carlson.
3097
3098         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
3099         (TEST):
3100         Remove use of deleted parameter.
3101
3102 2020-02-25  Devin Rousso  <drousso@apple.com>
3103
3104         Web Inspector: safari app extension isolated worlds and injected files use the extension's identifier instead of its name
3105         https://bugs.webkit.org/show_bug.cgi?id=206911
3106         <rdar://problem/58026635>
3107
3108         Reviewed by Brian Burg.
3109
3110         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
3111         (TestWebKitAPI::TEST):
3112         Add test for `WTF::HashSet::reserveInitialCapacity`.
3113
3114         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3115         (TestWebKitAPI::TEST):
3116         Actually check the value of `WTF::HashMap::capacity`.
3117
3118         * TestWebKitAPI/Tests/WebKitCocoa/_WKInspectorDelegate.mm: Added.
3119         (-[InspectorDelegate _webView:didAttachInspector:])
3120         (-[InspectorDelegate _webView:browserDomainEnabledForInspector:])
3121         (-[InspectorDelegate _webView:browserDomainDisabledForInspector:])
3122         (TestWebKitAPI::TEST):
3123         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
3124         (-[InspectorDelegate _webView:didAttachInspector:]): Deleted.
3125         (TestWebKitAPI::TEST): Deleted.
3126
3127 2020-02-25  Matt Lewis  <jlewis3@apple.com>
3128
3129         Add checkout_root to stubrepository.py
3130         https://bugs.webkit.org/show_bug.cgi?id=208213
3131
3132         Reviewed by Jonathan Bedard.
3133
3134         * Scripts/webkitpy/common/checkout/scm/stub_repository.py:
3135         (StubRepository.__init__):
3136
3137         We are creating our own class variable for checkout_root rather than calling the parent SCM variable
3138         because when initially we left out the parent constructor due to trying to override the fact that we don't actually have a SCM.
3139
3140 2020-02-25  Daniel Bates  <dabates@apple.com>
3141
3142         TestWebKitAPI.PasteMixedContent.CopyAndPasteWithCustomPasteboardDataOnly should wait until copy operation completes
3143         https://bugs.webkit.org/show_bug.cgi?id=208214
3144
3145         Reviewed by Wenson Hsieh.
3146
3147         Wait until the copy operation completes before loading the second web view and testing paste
3148         to ensure that something was actually copied to the clipboard.
3149
3150         * TestWebKitAPI/TestWebKitAPI.xcodeproj/xcshareddata/xcschemes/TestWebKitAPI.xcscheme:
3151         * TestWebKitAPI/Tests/WebKitCocoa/PasteMixedContent.mm:
3152         (TestWebKitAPI::TEST): Substitute -_synchronouslyExecuteEditCommand for -_executeEditCommand
3153         so that we wait until the command completes.
3154
3155 2020-02-25  Chris Dumez  <cdumez@apple.com>
3156
3157         REGRESSION (r256882): Can't drag an HTML file into a new (empty) Safari tab
3158         https://bugs.webkit.org/show_bug.cgi?id=208199
3159         <rdar://problem/59746887>
3160
3161         Reviewed by Alex Christensen.
3162
3163         Add API test coverage.
3164
3165         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
3166         (TEST):
3167
3168 2020-02-25  Sihui Liu  <sihui_liu@apple.com>
3169
3170         spinRunLoop should take a non-zero integer as parameter
3171         https://bugs.webkit.org/show_bug.cgi?id=208148
3172         <rdar://problem/59766682>
3173
3174         Unreviewed iOS build fix.
3175
3176         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
3177         (TestWebKitAPI::Util::spinRunLoop):
3178
3179 2020-02-25  Sihui Liu  <sihui_liu@apple.com>
3180
3181         spinRunLoop should take a non-zero integer as parameter
3182         https://bugs.webkit.org/show_bug.cgi?id=208148
3183
3184         Reviewed by Darin Adler.
3185
3186         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3187         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3188         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
3189         (TestWebKitAPI::Util::spinRunLoop):
3190
3191 2020-02-24  Yusuke Suzuki  <ysuzuki@apple.com>
3192
3193         [WTF] Add tests for CompactRefPtrTuple
3194         https://bugs.webkit.org/show_bug.cgi?id=208172
3195
3196         Reviewed by Darin Adler.
3197
3198         We copy tests from RefPtr for CompactRefPtrTuple to ensure that it is working correctly.
3199         Many of tests are not necessary since currently CompactRefPtrTuple is non-copyable / non-movable.
3200
3201         * TestWebKitAPI/CMakeLists.txt:
3202         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3203         * TestWebKitAPI/Tests/WTF/CompactRefPtrTuple.cpp: Added.
3204         (TestWebKitAPI::TEST):
3205
3206 2020-02-24  Aakash Jain  <aakash_jain@apple.com>
3207
3208         [ews] commit-queue should check that patch have appropriate review flag
3209         https://bugs.webkit.org/show_bug.cgi?id=208138
3210
3211         Reviewed by Jonathan Bedard.
3212
3213         * BuildSlaveSupport/ews-build/steps.py:
3214         (BugzillaMixin._is_patch_obsolete): Drive-by fix to set build properties for patch author, commiter and reviewer.
3215         (BugzillaMixin._is_patch_cq_plus):
3216         (BugzillaMixin._does_patch_have_acceptable_review_flag): Method to check if patch have r? or r- flag.
3217         (ValidatePatch.start):
3218
3219 2020-02-24  Jiewen Tan  <jiewen_tan@apple.com>
3220
3221         [WebAuthn] Implement SPI for the platform authenticator
3222         https://bugs.webkit.org/show_bug.cgi?id=208087
3223         <rdar://problem/59369305>
3224
3225         Reviewed by Brent Fulgham.
3226
3227         Besides adding API tests, this patch also teaches TestWebKitAPI to use restricted entitlements.
3228
3229         * TestWebKitAPI/Configurations/TestWebKitAPI-macOS.entitlements:
3230         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
3231         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3232         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
3233         (-[TestWebAuthenticationPanelDelegate panel:updateWebAuthenticationPanel:]):
3234         (-[TestWebAuthenticationPanelDelegate panel:selectAssertionResponse:completionHandler:]):
3235         (-[TestWebAuthenticationPanelDelegate panel:verifyUserWithAccessControl:completionHandler:]):
3236         (TestWebKitAPI::TEST):
3237         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-la.html: Copied from Tools/TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion.html.
3238         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-la-duplicate-credential.html: Added.
3239         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-la-error.html: Added.
3240         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-la.html: Added.
3241
3242 2020-02-24  Yusuke Suzuki  <ysuzuki@apple.com>
3243
3244         Unreviewed, updating LLDB test for CompactPointerTuple.
3245         https://bugs.webkit.org/show_bug.cgi?id=207827
3246
3247         * lldb/lldb_webkit.py:
3248         (WTFCompactPointerTupleProvider):
3249         (WTFCompactPointerTupleProvider.update):
3250
3251 2020-02-24  Ellie Epskamp-Hunt  <eepskamphunt@apple.com>
3252
3253         Provide alternate way to name Web Content process
3254         https://bugs.webkit.org/show_bug.cgi?id=205224
3255         rdar://57038084
3256
3257         Reviewed by Alex Christensen.
3258
3259         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3260         * TestWebKitAPI/Tests/WebKitCocoa/DisplayName.mm: Added.
3261         (TestWebKitAPI::TEST):
3262
3263 2020-02-24  Jonathan Bedard  <jbedard@apple.com>
3264
3265         results.webkit.org: Link to result archives
3266         https://bugs.webkit.org/show_bug.cgi?id=207646
3267         <rdar://problem/59395807>
3268
3269         Rubber-stamped by Aakash Jain.
3270
3271         * resultsdbpy/resultsdbpy/view/static/js/archiveRouter.js: Added.
3272         (_ArchiveRouter): Retrieve json from archive-router endpoint.
3273         (_ArchiveRouter.prototype._determineArgumentFromAncestry): Given an argument, default and ancestry values,
3274         return the most specific value.
3275         (_ArchiveRouter.prototype.hasArchive): Check if a suite and mode have an archive link.
3276         (_ArchiveRouter.prototype.pathFor): Construct the path for archive access.
3277         (_ArchiveRouter.prototype.labelFor): Return a label for an archive link.
3278         * resultsdbpy/resultsdbpy/view/static/js/investigate.js:
3279         (parametersForInstance): Extract from lambda function.
3280         (testRunLink): Use parametersForInstance instead of a lambda function.
3281         (archiveLink): Return an archive link for data. 
3282         (contentForData): Add archive link to view.
3283         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
3284         (TimelineFromEndpoint): Accept both suite and test.
3285         (TimelineFromEndpoint.prototype.render.onDotEnterFactory): Add archive link to pop-over.
3286         * resultsdbpy/resultsdbpy/view/templates/search.html: Pass suite and test to TimelineEndpoint.
3287         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Pass suite to TimelineEndpoint.
3288         * resultsdbpy/resultsdbpy/view/view_routes.py:
3289         (ViewRoutes.__init__): Add archive_route dictionary.
3290
3291 2020-02-24  Alex Christensen  <achristensen@webkit.org>
3292
3293         WKWebViewConfiguration._corsDisablingPatterns should also disable CORS for non-DocumentThreadableLoader loading
3294         https://bugs.webkit.org/show_bug.cgi?id=208035
3295         <rdar://problem/58011337>
3296
3297         Reviewed by Tim Hatcher.
3298
3299         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
3300
3301 2020-02-22  Darin Adler  <darin@apple.com>
3302
3303         Fix some include mistakes and make some coding style tweaks to WebKit and WebKitTestRunner
3304         https://bugs.webkit.org/show_bug.cgi?id=208099
3305
3306         Reviewed by Antti Koivisto.
3307
3308         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
3309         Sorted includes the traditional way. Added an include of AccessibilityCommonMac.h
3310         so we can use the -[NSString createJSStringRef] method.
3311         (-[NSString createJSStringRef]): Deleted. This is a duplicate of the method
3312         defined in AccessibilityCommonMac.mm, and was causing a linker warning.
3313
3314 2020-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3315
3316         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html is failing in iOS 13.4 beta
3317         https://bugs.webkit.org/show_bug.cgi?id=208096
3318         <rdar://problem/59632008>
3319
3320         Reviewed by Alexey Proskuryakov.
3321
3322         In the iOS 13.4 beta, the fix for <rdar://problem/56422337> changed -[UIDatePicker setCalendar:], such that
3323         if the new calendar locale matches that of the current calendar's locale (and several other properties of the
3324         new NSCalendar are also unchanged), then the UIDatePicker's calendar will also avoid changing.
3325
3326         In our layout tests, the mechanism we use to simulate the user changing their preferred calendar is no longer
3327         compatible with the above change since the swizzled NSCalendar instance does not have a locale set, so it will
3328         default to the same locale as the one used in the original NSCalendar. This means the call to -setCalendar: ends
3329         up being a no-op, so the test fails to override the simulated Japanese calendar type with a Gregorian calendar
3330         in the credit card expiry field.
3331
3332         To fix this, additionally specify a calendar locale identifier when generating the mock NSCalendar.
3333
3334         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3335         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3336         (WTR::UIScriptController::setDefaultCalendarType):
3337         * WebKitTestRunner/TestController.h:
3338
3339         Change m_overriddenCalendarIdentifier to m_overriddenCalendarAndLocaleIdentifiers, a pair of calendar
3340         identifier and calendar locale identifier.
3341
3342         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3343         (WTR::swizzledCalendar):
3344         (WTR::TestController::overriddenCalendarIdentifier const):
3345         (WTR::TestController::overriddenCalendarLocaleIdentifier const):
3346
3347         Clean these up by returning the `NSString *` instead of making another `RetainPtr`.
3348
3349         (WTR::TestController::setDefaultCalendarType):
3350
3351         Plumb the new calendar's locale identifier through this method.
3352
3353         (WTR::TestController::cocoaResetStateToConsistentValues):
3354         (WTR::TestController::getOverriddenCalendarIdentifier const): Deleted.
3355         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.h:
3356         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.mm:
3357         (WTR::UIScriptControllerCocoa::setDefaultCalendarType):
3358
3359 2020-02-21  Kate Cheney  <katherine_cheney@apple.com>
3360
3361         App-bound domains should have separate Network Sessions
3362         https://bugs.webkit.org/show_bug.cgi?id=208026
3363         <rdar://problem/59434006>
3364
3365         Reviewed by Brent Fulgham.
3366
3367         This patch is mostly test infrastructure involving 3 functions.
3368         One sets in-app browser privacy as enabled in the network process
3369         manually for the test. One ensures that setting the WebView category
3370         works properly, and the last one checks for an app-bound session for
3371         an app-bound navigation.
3372
3373         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3374         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3375         (WTR::InjectedBundle::didReceiveMessageToPage):
3376         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3377         (WTR::TestRunner::getWebViewCategory):
3378         (WTR::TestRunner::callDidReceiveWebViewCategoryCallback):
3379         (WTR::TestRunner::hasAppBoundSession):
3380         (WTR::TestRunner::setInAppBrowserPrivacyEnabled):
3381         (WTR::TestRunner::callDidSetInAppBrowserPrivacyEnabledCallback):
3382         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3383         * WebKitTestRunner/TestController.cpp:
3384         (WTR::TestController::ensureViewSupportsOptionsForTest):
3385         Clearing the bundleID should happen right before setting a new one, 
3386         otherwise it clears the ID after it is set and returns a null ID.
3387
3388         (WTR::TestController::resetStateToConsistentValues):
3389         (WTR::TestController::getWebViewCategory):
3390         (WTR::InAppBrowserPrivacyCallbackContext::InAppBrowserPrivacyCallbackContext):
3391         (WTR::inAppBrowserPrivacyBooleanResultCallback):
3392         (WTR::inAppBrowserPrivacyVoidResultCallback):
3393         (WTR::TestController::hasAppBoundSession):
3394         (WTR::TestController::setInAppBrowserPrivacyEnabled):
3395         * WebKitTestRunner/TestController.h:
3396         * WebKitTestRunner/TestInvocation.cpp:
3397         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3398         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3399         (WTR::TestInvocation::didSetInAppBrowserPrivacyEnabled):
3400         (WTR::TestInvocation::didReceivePrevalentDomains):
3401         (WTR::TestInvocation::didReceiveWebViewCategory):
3402         * WebKitTestRunner/TestInvocation.h:
3403         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3404         (WTR::TestController::getWebViewCategory):
3405
3406 2020-02-21  Jonathan Bedard  <jbedard@apple.com>
3407
3408         Build DumpRenderTree and WebKitTestRunner for macCatalyst
3409         https://bugs.webkit.org/show_bug.cgi?id=208068
3410         <rdar://problem/59676596>
3411
3412         Reviewed by Tim Horton.
3413
3414         * DumpRenderTree/ios/TextInputControllerIOS.m: Import WebKitLegacy explicitly.
3415         * DumpRenderTree/mac/Configurations/Base.xcconfig: Use cocoatouch instead of SDK.
3416         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Ditto.
3417         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig: Ditto.
3418         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig: Ditto.
3419         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Ditto.
3420         * DumpRenderTree/mac/EditingDelegate.mm: Import WebKitLegacy explicitly.
3421         * DumpRenderTree/mac/EventSendingController.h: Ditto.
3422         * DumpRenderTree/mac/ObjCPlugin.m: Ditto.
3423         * DumpRenderTree/mac/ResourceLoadDelegate.mm: Ditto.
3424         * Makefile: Add DumpRenderTree and WebKitTestRunner.
3425         * WebKitTestRunner/Configurations/Base.xcconfig: Use cocoatouch instead of SDK.
3426         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Ditto.
3427         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Ditto.
3428
3429 2020-02-21  Aakash Jain  <aakash_jain@apple.com>
3430
3431         [ews] Add build step to Validate ChangeLog for commit-queue
3432         https://bugs.webkit.org/show_bug.cgi?id=208064
3433
3434         Reviewed by Jonathan Bedard.
3435
3436         * BuildSlaveSupport/ews-build/steps.py:
3437         (ValidateChangeLogAndReviewer): Build step to validate ChangeLog.
3438         (ValidateChangeLogAndReviewer.start):
3439         (ValidateChangeLogAndReviewer.evaluateCommand): If the validation fails, comment on bug and mark patch as cq-.
3440         (SetCommitQueueMinusFlagOnPatch.start): End the build (after marking the patch cq-) if build_finish_summary property is set.
3441
3442 2020-02-21  Aakash Jain  <aakash_jain@apple.com>
3443
3444         [ews] Add build step to set cq- flag on bugzilla patch
3445         https://bugs.webkit.org/show_bug.cgi?id=208021
3446
3447         Reviewed by Jonathan Bedard.
3448
3449         * BuildSlaveSupport/ews-build/steps.py:
3450         (BugzillaMixin.set_cq_minus_flag_on_patch):
3451         (SetCommitQueueMinusFlagOnPatch):
3452         (SetCommitQueueMinusFlagOnPatch.start):
3453         (SetCommitQueueMinusFlagOnPatch.getResultSummary):
3454
3455 2020-02-20  Matt Lewis  <jlewis3@apple.com>
3456
3457         Stub repositories fail to upload some results due to missing head svn revision
3458         https://bugs.webkit.org/show_bug.cgi?id=207684
3459
3460         Reviewed by Jonathan Bedard.
3461
3462         * Scripts/webkitpy/common/host_mock.py: Added in call for creating stub repo checkout information for upload tests.
3463         (MockHost.__init__):
3464         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
3465         (summarize_results): Changed call to head_svn_revision to port.commits_for_upload() to bring
3466         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
3467         (SummarizedResultsTest.setUp): Added in new required parameter for testing.
3468         * Scripts/webkitpy/port/base.py:
3469         (Port.commits_for_upload): Removed the forced movement up the systems tree that prevented us 
3470         from using mock SCMs and more
3471         * Scripts/webkitpy/port/test.py: Added function to make the checkout_information.json for upload testing.
3472
3473 2020-02-21  Diego Pino Garcia  <dpino@igalia.com>
3474
3475         [JSCOnly] Add --verbose flag when running JavaScriptCore tests
3476         https://bugs.webkit.org/show_bug.cgi?id=208051
3477
3478         Reviewed by Carlos Alberto Lopez Perez.
3479
3480         Verbose flag prints out each test name executed. Without this flag
3481         stdout prints out one or two periods.
3482
3483         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3484         (RunJavaScriptCoreTests.start):
3485
3486 2020-02-21  Michael Catanzaro  <mcatanzaro@gnome.org>
3487
3488         [WPE][GTK] googleapis.com is a public suffix, defeating isGoogle() check in UserAgentQuirks.cpp
3489         https://bugs.webkit.org/show_bug.cgi?id=207984
3490
3491         Reviewed by Daniel Bates.
3492
3493         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3494         (TestWebKitAPI::TEST):
3495
3496 2020-02-20  Michael Catanzaro  <mcatanzaro@gnome.org>
3497
3498         [GTK] Improve user agent quirk for Google Docs and Google Drive
3499         https://bugs.webkit.org/show_bug.cgi?id=206506
3500
3501         Reviewed by Carlos Garcia Campos.
3502
3503         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3504         (TestWebKitAPI::assertUserAgentForURLHasFirefoxBrowserQuirk):
3505         (TestWebKitAPI::TEST):
3506
3507 2020-02-20  Fujii Hironori  <Hironori.Fujii@sony.com>
3508
3509         check-webkit-style: Check if *_EXPORT and *_EXPORT_PRIVATE macros are used under corresponding directories
3510         https://bugs.webkit.org/show_bug.cgi?id=207380
3511
3512         Reviewed by Jonathan Bedard.
3513
3514         Added a new rule 'build/export_macro'.
3515
3516         Removed a obsolete rule 'readability/webkit_export' which was used
3517         only by Chromium port (r148185).
3518
3519         * Scripts/webkitpy/style/checkers/cpp.py:
3520         (_FunctionState.export_macro):
3521         (check_function_definition):
3522         (_unix_path): Added.
3523         (is_generated_file): Use _unix_path.
3524         (check_has_config_header): Ditto.
3525         (CppChecker):
3526         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3527         (WebKitStyleTest.test_export_macro_check):
3528         (WebKitStyleTest.test_webkit_export_check): Deleted.
3529
3530 2020-02-20  Fujii Hironori  <Hironori.Fujii@sony.com>
3531
3532         [Win][MiniBrowser] Add prettier toolbar button icons
3533         https://bugs.webkit.org/show_bug.cgi?id=207999
3534
3535         Reviewed by Ross Kirsling.
3536
3537         Use a custom toolbar button icons instead of system stock icons.
3538
3539         Fixed a bug toolbar button dropdown arrows always looked being
3540         hovered. TBSTYLE_FLAT should be given.
3541
3542         Removed the window border line of Progress Indicator.
3543
3544         * MiniBrowser/win/MainWindow.cpp:
3545         (MainWindow::createToolbar):
3546         * MiniBrowser/win/MiniBrowserLib.rc:
3547         * MiniBrowser/win/MiniBrowserLibResource.h:
3548         * MiniBrowser/win/toolbar.bmp: Added.
3549
3550 2020-02-20  Aakash Jain  <aakash_jain@apple.com>
3551
3552         Update run-webkit-tests help description for skip-failing-tests
3553         https://bugs.webkit.org/show_bug.cgi?id=208031
3554
3555         Reviewed by Alexey Proskuryakov.
3556
3557         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3558
3559 2020-02-20  Chris Dumez  <cdumez@apple.com>
3560
3561         REGRESSION (r255677): Reloading tab with beforeunload prompt closes tab when asking to stay on page
3562         https://bugs.webkit.org/show_bug.cgi?id=208015
3563         <rdar://problem/59591630>
3564
3565         Reviewed by Geoffrey Garen.
3566
3567         Add API test coverage.
3568
3569         * TestWebKitAPI/Tests/WebKitCocoa/ModalAlerts.mm:
3570         (TEST):
3571
3572 2020-02-20  Tim Horton  <timothy_horton@apple.com>
3573
3574         WKWebView with non-zero origin has the wrong top content inset with NSWindowStyleMaskFullSizeContentView
3575         https://bugs.webkit.org/show_bug.cgi?id=207998
3576         <rdar://problem/40942425>
3577
3578         Reviewed by Sam Weinig.
3579
3580         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3581         * TestWebKitAPI/Tests/WebKitCocoa/TopContentInset.mm: Renamed from Tools/TestWebKitAPI/Tests/WebKitCocoa/FullscreenTopContentInset.mm.
3582         (-[FullscreenChangeMessageHandler userContentController:didReceiveScriptMessage:]):
3583         (TestWebKitAPI::TEST):
3584         Add some tests for top content insets.
3585
3586 2020-02-20  Jonathan Bedard  <jbedard@apple.com>
3587
3588         results.webkit.org: Correctly report JSC tests for windows (Follow-up fix)
3589         https://bugs.webkit.org/show_bug.cgi?id=207910
3590
3591         Unreviewed infrastructure fix.
3592
3593         * Scripts/run-javascriptcore-tests:
3594         (configurationForUpload): Use the major version instead of the sub-minor version
3595         for version name.
3596
3597 2020-02-20  Don Olmstead  <don.olmstead@sony.com>
3598
3599         [CMake] Add WPE::libwpe target
3600         https://bugs.webkit.org/show_bug.cgi?id=207970
3601
3602         Reviewed by Adrian Perez de Castro.
3603
3604         Use the WPE::libwpe target.
3605
3606         * MiniBrowser/wpe/CMakeLists.txt:
3607         * TestWebKitAPI/PlatformWPE.cmake:
3608         * TestWebKitAPI/glib/PlatformWPE.cmake:
3609         * wpe/backends/CMakeLists.txt:
3610
3611 2020-02-19  Fujii Hironori  <Hironori.Fujii@sony.com>
3612
3613         [Win][MiniBrowser] Add 'Go Home' menu item and toolbar button
3614         https://bugs.webkit.org/show_bug.cgi?id=207749
3615
3616         Reviewed by Ross Kirsling.
3617
3618         Added "Set Default URL to Current URL" menu item like Mac MiniBrowser.
3619
3620         * MiniBrowser/win/MainWindow.cpp:
3621         (MainWindow::createToolbar):
3622         (MainWindow::WndProc):
3623         (MainWindow::setDefaultURLToCurrentURL):
3624         (MainWindow::goHome): Added.
3625         (MainWindow::onURLBarEnter):
3626         * MiniBrowser/win/MainWindow.h:
3627         * MiniBrowser/win/MiniBrowserLib.rc:
3628         * MiniBrowser/win/MiniBrowserLibResource.h:
3629         * MiniBrowser/win/MiniBrowserReplace.h:
3630         * MiniBrowser/win/WinMain.cpp:
3631         (wWinMain):
3632
3633 2020-02-19  Peng Liu  <peng.liu6@apple.com>
3634
3635         Fix check-webkit-style errors related to AVFoundationSPI.h
3636         https://bugs.webkit.org/show_bug.cgi?id=207834
3637
3638         Reviewed by Daniel Bates.
3639
3640         Revert the change in r256770 regarding the headers ordering.
3641         Headers in the same category should be in sorted order (case sensitive, as done by the command-line sort tool or the Xcode sort selection command).
3642
3643         * Scripts/webkitpy/style/checkers/cpp.py:
3644         (check_include_line):
3645
3646 2020-02-19  Jonathan Bedard  <jbedard@apple.com>
3647
3648         results.webkit.org: Correctly report JSC tests for windows
3649         https://bugs.webkit.org/show_bug.cgi?id=207910
3650
3651         Rubber-stamped by Aakash Jain.
3652
3653         * Scripts/run-javascriptcore-tests:
3654         (configurationForUpload): Give Windows a version name.
3655         * Scripts/webkitdirs.pm:
3656         (determineWinVersion): Correctly parse Windows 10 version numbers, conform to
3657         Version dictionary.
3658
3659 2020-02-19  Chris Dumez  <cdumez@apple.com>
3660
3661         Unreviewed, fix assertions in storage access API layout tests after r256882.
3662
3663         Drop dead testRunner code to toggle storage access API feature.
3664
3665         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3666         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3667         (WTR::TestRunner::setStorageAccessAPIEnabled): Deleted.
3668         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3669         * WebKitTestRunner/TestInvocation.cpp:
3670         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3671
3672 2020-02-18  Zan Dobersek  <zdobersek@igalia.com>
3673
3674         [WPE] Support 2D axis, smooth-motion events
3675         https://bugs.webkit.org/show_bug.cgi?id=207881
3676
3677         Reviewed by Carlos Garcia Campos.
3678
3679         * wpe/jhbuild.modules: Bump to a newer libwpe commit.
3680
3681 2020-02-18  Ryan Haddad  <ryanhaddad@apple.com>
3682
3683         Unreviewed, rolling out r256851.
3684
3685         Broke internal bots
3686
3687         Reverted changeset:
3688
3689         "Stub repositories fail to upload some results due to missing
3690         head svn revision"
3691         https://bugs.webkit.org/show_bug.cgi?id=207684
3692         https://trac.webkit.org/changeset/256851
3693
3694 2020-02-18  Fujii Hironori  <Hironori.Fujii@sony.com>
3695
3696         [Win][MiniBrowser] Support back/forward mouse buttons by handing APPCOMMAND_BROWSER_BACKWARD and APPCOMMAND_BROWSER_FORWARD
3697         https://bugs.webkit.org/show_bug.cgi?id=207883
3698
3699         Reviewed by Ross Kirsling.
3700
3701         Unlike other mouse buttons, 4th and 5th mouse buttons are
3702         processed differently. Clicking them dispatches WM_XBUTTONDOWN and
3703         WM_XBUTTONUP events to the window under the mouse cursor.
3704         Unhandled WM_XBUTTONUP events are automatically converted to
3705         WM_APPCOMMAND. And, unhandle WM_APPCOMMAND are propagated to the
3706         parent window.
3707         <https://docs.microsoft.com/en-us/windows/win32/inputdev/wm-appcommand>
3708
3709         Unlike other WM_* commands, WM_APPCOMMAND should return 1 if it is
3710         handled.
3711
3712         * MiniBrowser/win/BrowserWindow.h:
3713         * MiniBrowser/win/MainWindow.cpp:
3714         (MainWindow::WndProc):
3715         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3716         (WebKitBrowserWindow::navigateForwardOrBackward):
3717         * MiniBrowser/win/WebKitBrowserWindow.h:
3718         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
3719         (WebKitLegacyBrowserWindow::navigateForwardOrBackward):
3720         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
3721
3722 2020-02-18  Alex Christensen  <achristensen@webkit.org>
3723
3724         Expand WKRemoteObjectCoder supported POD types to encode NSURLResponse types
3725         https://bugs.webkit.org/show_bug.cgi?id=207912
3726         <rdar://problem/59556922>
3727
3728         Reviewed by Brian Weinstein.
3729
3730         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.h:
3731         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.mm:
3732         (TEST):
3733         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistryPlugIn.mm:
3734         (-[RemoteObjectRegistryPlugIn sendRequest:response:challenge:error:completionHandler:]):
3735
3736 2020-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
3737
3738         [macOS] Web process may crash under ServicesOverlayController::buildPotentialHighlightsIfNeeded
3739         https://bugs.webkit.org/show_bug.cgi?id=207899
3740         <rdar://problem/55658207>
3741
3742         Reviewed by Tim Horton and Simon Fraser.
3743
3744         Make it possible to run tests on macOS with services controls enabled, via a new TestOptions flag.
3745
3746         * WebKitTestRunner/TestController.cpp:
3747         (WTR::updateTestOptionsFromTestHeader):
3748         * WebKitTestRunner/TestOptions.h:
3749         (WTR::TestOptions::hasSameInitializationOptions const):
3750         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3751         (WTR::TestController::platformCreateWebView):
3752
3753 2020-02-18  Matt Lewis  <jlewis3@apple.com>
3754
3755         Stub repositories fail to upload some results due to missing head svn revision
3756         https://bugs.webkit.org/show_bug.cgi?id=207684
3757
3758         Reviewed by Jonathan Bedard.
3759
3760         * Scripts/webkitpy/api_tests/run_api_tests.py:
3761         (main): Added initializing the scm to the host object.
3762         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
3763         (summarize_results): Changed call to head_svn_revision to port.commits_for_upload() to bring
3764         it in line with modern code.
3765         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3766         (main): Added inializing the scm to the host object.
3767         * Scripts/webkitpy/port/base.py:
3768         (Port.commits_for_upload): Removed the forced movement up the systems tree that prevented us
3769         from using mock SCMs and more
3770         * Scripts/webkitpy/test/main.py:
3771         (main):  Removed the forced movement up the systems tree, initialized the SCM on the host object,
3772         and converted the webkit_root variable to the SCM checkout root.
3773         (Tester._run_tests):
3774
3775 2020-02-18  Per Arne Vollan  <pvollan@apple.com>
3776
3777         Move [UIDevice currentDevice] calls to UI process
3778         https://bugs.webkit.org/show_bug.cgi?id=204320
3779
3780         Reviewed by Darin Adler.
3781
3782         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3783         * TestWebKitAPI/Tests/WebKit/LocalizedDeviceModel.mm: Added.
3784         (TEST):
3785
3786 2020-02-18  Simon Fraser  <simon.fraser@apple.com>
3787
3788         Move from "layer flush" terminology to "rendering update"
3789         https://bugs.webkit.org/show_bug.cgi?id=207870
3790
3791         Reviewed by Tim Horton.
3792
3793         Rename various functions and member variables to move away from the legacy "layer flush"
3794         terminology and instead use "rendering update", matching Page::updateRendering(). The fact
3795         that we have layers is an implementation detail.
3796         
3797         Change LayerFlushThrottlingState to be an OptionSet<>.
3798
3799         * Tracing/SystemTracePoints.plist:
3800
3801 2020-02-17  Zhifei Fang  <zhifei_fang@apple.com>
3802
3803         [Webkit.css] Adding popover style element
3804         This help to prevent us reinventing the wheel ever again
3805         https://bugs.webkit.org/show_bug.cgi?id=207787
3806
3807         Reviewed by Dean Jackson.
3808
3809         * resultsdbpy/resultsdbpy/view/static/library/css/docs.yaml:
3810         * resultsdbpy/resultsdbpy/view/static/library/css/index.html:
3811         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
3812         (.popover):
3813         (.popover>.content):
3814         (.popover.display):
3815         (.popover .arrow):
3816         (.popover .arrow.point-top):
3817         (.popover .arrow.point-bottom):
3818         (.popover .arrow.point-left):
3819         (.popover .arrow.point-right):
3820         (@media (prefers-color-scheme: dark) .popover>.content):
3821         (@media (prefers-color-scheme: dark) .popover.display):
3822         (@media (prefers-color-scheme: dark) .popover .arrow):
3823         (.popover>.content>.section): Deleted.
3824         (.popover:focus>.content, .popover:hover>.content): Deleted.
3825         (.popover.right>.content): Deleted.
3826         (.popover.right :focus>.content, .popover.right:hover>.content): Deleted.
3827         (.popover.left>.content): Deleted.
3828         (.popover.left :focus>.content, .popover.left:hover>.content): Deleted.
3829         (.popover.bottom>.content): Deleted.
3830         (.popover.bottom :focus>.content, .popover.bottom:hover>.content): Deleted.
3831
3832 2020-02-17  Brent Fulgham  <bfulgham@apple.com>
3833
3834         Update WebKit Tools to issue mach extensions as needed
3835         https://bugs.webkit.org/show_bug.cgi?id=207850
3836         <rdar://problem/59521019>
3837
3838         Reviewed by Per Arne Vollan.
3839
3840         Revise the codesign settings for our testing tools to allow the process to vend mach extensions
3841         to its child processes (WebContent, GPU, Network, etc.) as needed.
3842
3843         * MiniBrowser/MiniBrowser.entitlements:
3844         * TestWebKitAPI/Configurations/TestWebKitAPI-macOS.entitlements: Added.
3845         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
3846         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3847         * WebKitTestRunner/Configurations/WebKitTestRunner.entitlements:
3848
3849 2020-02-17  Peng Liu  <peng.liu6@apple.com>
3850
3851         Fix check-webkit-style errors related to AVFoundationSPI.h
3852         https://bugs.webkit.org/show_bug.cgi?id=207834
3853
3854         Reviewed by Eric Carlson.
3855
3856         We need to use case-insensitive comparison to check whether the headers are alphabetically sorted in each header section.
3857         Soft-link headers can be included as either "file.h" or <file.h>.
3858
3859         * Scripts/webkitpy/style/checkers/cpp.py:
3860         (_classify_include):
3861         (check_include_line):
3862
3863 2020-02-17  Keith Rollin  <krollin@apple.com>
3864
3865         Unreviewed build fix after r256715.
3866
3867         Fix tvOS and watchOS builds.
3868
3869         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
3870
3871 2020-02-17  Per Arne Vollan  <pvollan@apple.com>
3872
3873         Use CF prefs direct mode in the WebContent process
3874         https://bugs.webkit.org/show_bug.cgi?id=203420
3875
3876         Reviewed by Brent Fulgham.
3877
3878         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3879         * TestWebKitAPI/Tests/WebKit/PreferenceChanges.mm: Added.
3880         (TEST):
3881
3882 2020-02-17  Aakash Jain  <aakash_jain@apple.com>
3883
3884         EWS should be able to file Bugzilla bugs
3885         https://bugs.webkit.org/show_bug.cgi?id=207845
3886
3887         Reviewed by Alexey Proskuryakov.
3888
3889         * BuildSlaveSupport/ews-build/steps.py:
3890         (BugzillaMixin.create_bug): Method to file bugzilla bug using bugzilla REST API.
3891
3892 2020-02-17  Aakash Jain  <aakash_jain@apple.com>
3893
3894         EWS should be able to comment on Bugzilla
3895         https://bugs.webkit.org/show_bug.cgi?id=201927
3896
3897         Reviewed by Jonathan Bedard.
3898
3899         * BuildSlaveSupport/ews-build/steps.py:
3900         (BugzillaMixin.comment_on_bug): Method to comment on bugzilla bug.
3901         (BugzillaMixin.remove_flags_on_patch): Drive-by fix to correctly identify failure based on status code.
3902         (BugzillaMixin.close_bug): Ditto.
3903         (CommentOnBug): Build step to comment on bugzilla bug.
3904
3905 2020-02-17  Antti Koivisto  <antti@apple.com>
3906
3907         [macOS] Add trace points for layer flush runloop observer
3908         https://bugs.webkit.org/show_bug.cgi?id=207837
3909
3910         Reviewed by Sam Weinig.
3911
3912         * Tracing/SystemTracePoints.plist:
3913
3914 2020-02-17  Don Olmstead  <don.olmstead@sony.com>
3915
3916         [CMake] Use builtin targets
3917         https://bugs.webkit.org/show_bug.cgi?id=205166
3918
3919         Reviewed by Darin Adler.
3920
3921         * TestWebKitAPI/PlatformWin.cmake:
3922
3923 2020-02-17  Aakash Jain  <aakash_jain@apple.com>
3924
3925         [ews] add SetBuildSummary step for Windows EWS
3926         https://bugs.webkit.org/show_bug.cgi?id=207556
3927
3928         Reviewed by Jonathan Bedard.
3929
3930         * BuildSlaveSupport/ews-build/factories.py:
3931         (WindowsFactory.__init__):
3932         (GTKBuildAndTestFactory.__init__):
3933         * BuildSlaveSupport/ews-build/factories_unittest.py:
3934         (TestBuildAndTestsFactory.test_windows_factory): Added unit-test.
3935
3936 2020-02-17  Alberto Garcia  <berto@igalia.com>
3937
3938         [WPE] Change the QML plugin install path
3939         https://bugs.webkit.org/show_bug.cgi?id=207761
3940
3941         Reviewed by Philippe Normand.
3942
3943         * Scripts/run-qt-wpe-minibrowser:
3944         * glib/api_test_runner.py:
3945         (TestRunner._run_test_qt):
3946
3947 2020-02-16  Fujii Hironori  <Hironori.Fujii@sony.com>
3948
3949         Remove remaining WTF_EXPORT and WTF_IMPORT by replacing them with WTF_EXPORT_DECLARATION and WTF_IMPORT_DECLARATION
3950         https://bugs.webkit.org/show_bug.cgi?id=207746
3951
3952         Reviewed by Don Olmstead.
3953
3954         * MiniBrowser/win/stdafx.h:
3955
3956 2020-02-16  Brady Eidson  <beidson@apple.com>
3957
3958         Expose "allowsContentJavaScript" on WKWebpagePreferences
3959         <rdar://problem/51534967> and https://bugs.webkit.org/show_bug.cgi?id=207427
3960
3961         Reviewed by Darin Adler.
3962
3963         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
3964         (TEST):
3965         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3966         (-[WebsitePoliciesNavigationDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
3967         (TEST):
3968         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:preferences:userInfo:decisionHandler:]): Deleted.
3969         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
3970         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
3971         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
3972         (-[TestNavigationDelegate waitForDidFinishNavigationWithPreferences:]):
3973         (-[WKWebView _test_waitForDidFinishNavigationWithPreferences:]):
3974         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
3975         * TestWebKitAPI/cocoa/TestWKWebView.h:
3976         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3977         (-[WKWebView synchronouslyLoadHTMLString:preferences:]):
3978
3979 2020-02-14  Yusuke Suzuki  <ysuzuki@apple.com>
3980
3981         NetworkLoadMetrics should be shared by multiple ResourceResponse instances
3982         https://bugs.webkit.org/show_bug.cgi?id=207747
3983
3984         Reviewed by Keith Miller.
3985
3986         * TestWebKitAPI/Tests/WebCore/ParsedContentRange.cpp:
3987         (TestWebKitAPI::TEST):
3988
3989 2020-02-14  Alex Christensen  <achristensen@webkit.org>
3990
3991         Allow UIDNAInfo.errors from uidna_nameToUnicode that would not cause URL parsing failures
3992         https://bugs.webkit.org/show_bug.cgi?id=207360
3993         <rdar://problem/57825317>
3994
3995         Reviewed by Ryosuke Niwa.
3996
3997         * TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
3998         (TestWebKitAPI::TEST):
3999
4000 2020-02-14  Don Olmstead  <don.olmstead@sony.com>
4001
4002         [CMake] Add Fontconfig::Fontconfig target
4003         https://bugs.webkit.org/show_bug.cgi?id=207730
4004
4005         Reviewed by Adrian Perez de Castro.
4006
4007         Use the Fontconfig::Fontconfig target.
4008
4009         * WebKitTestRunner/PlatformGTK.cmake:
4010
4011 2020-02-13  Kate Cheney  <katherine_cheney@apple.com>
4012
4013          Expose prevalent domains on a per-page basis
4014          https://bugs.webkit.org/show_bug.cgi?id=207523
4015          <rdar://problem/59270758>
4016
4017         Reviewed by Chris Dumez.
4018
4019         Added WebKitTestRunner functions so this functionality can be tested.
4020         clearPrevalentDomains should be called between tests to reset the
4021         state.
4022
4023         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4024         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4025         (WTR::InjectedBundle::didReceiveMessageToPage):
4026         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4027         (WTR::TestRunner::getPrevalentDomains):
4028         (WTR::TestRunner::callDidReceivePrevalentDomainsCallback):
4029         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4030         * WebKitTestRunner/TestController.cpp:
4031         (WTR::TestController::resetStateToConsistentValues):
4032         (WTR::TestController::getPrevalentDomains):
4033         (WTR::TestController::clearPrevalentDomains):
4034         * WebKitTestRunner/TestController.h:
4035         * WebKitTestRunner/TestInvocation.cpp:
4036         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
4037         (WTR::TestInvocation::didReceivePrevalentDomains):
4038         * WebKitTestRunner/TestInvocation.h:
4039         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4040         (WTR::TestController::getPrevalentDomains):
4041         (WTR::TestController::clearPrevalentDomains):
4042
4043 2020-02-13  Fujii Hironori  <Hironori.Fujii@sony.com>
4044
4045         [Win][MiniBrowser] Reimplement the toolbar by using toolbar common control
4046         https://bugs.webkit.org/show_bug.cgi?id=207682
4047
4048         Reviewed by Ross Kirsling.
4049
4050         The toolbar placed button common controls as the toolbar buttons.
4051         However, because these buttons are focusable, shortcut keys don't
4052         work after clicking them.
4053
4054         Added Home button, Add to Bookmarks button, dropdown buttons of
4055         back and forward buttons, but they aren't implemented yet. Just
4056         placeholders at the moment.
4057
4058         * MiniBrowser/win/MainWindow.cpp:
4059         (MainWindow::createToolbar): Added.
4060         (MainWindow::resizeToolbar): Added.
4061         (MainWindow::rescaleToolbar): Added.
4062         (MainWindow::init):
4063         (MainWindow::resizeSubViews):
4064         (MainWindow::updateDeviceScaleFactor):
4065         * MiniBrowser/win/MainWindow.h: Added m_toolbarItemsWidth.
4066
4067 2020-02-13  Ryosuke Niwa  <rniwa@webkit.org>
4068
4069         Dark Mode: In Notes, list item becomes invisible in dark mode after outdenting
4070         https://bugs.webkit.org/show_bug.cgi?id=207676
4071
4072         Reviewed by Wenson Hsieh and Timothy Hatcher.
4073
4074         Added regression tests for pasting content with -apple-system-label and outdenting content.
4075
4076         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm:
4077         (PasteHTML.TransformColorsOfDarkContentButNotSemanticColor):
4078         (PasteHTML.DoesNotTransformColorsOfLightContentDuringOutdent):
4079
4080 2020-02-13  Alex Christensen  <achristensen@webkit.org>
4081
4082         _WKResourceLoadInfo should conform to NSSecureCoding
4083         https://bugs.webkit.org/show_bug.cgi?id=207667
4084
4085         Reviewed by Brady Eidson.
4086
4087         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
4088         (TEST):
4089
4090 2020-02-13  Stephan Szabo  <stephan.szabo@sony.com>
4091
4092         [PlayStation] Add Buildbots for Debug/Release builds
4093         https://bugs.webkit.org/show_bug.cgi?id=199454
4094
4095         Reviewed by Aakash Jain.
4096
4097         * BuildSlaveSupport/build.webkit.org-config/config.json:
4098         Add PlayStation slaves, builders
4099         * BuildSlaveSupport/build.webkit.org-config/factories.py:
4100         Use higher timeout for playstation as with win bot
4101         * BuildSlaveSupport/build.webkit.org-config/loadConfig.py:
4102         Set PlayStation category for playstation platform
4103         * BuildSlaveSupport/build.webkit.org-config/steps.py:
4104         Use same path as gtk, wincairo, etc for appendCustomBuildFlags
4105         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
4106         Add PlayStation expectations
4107
4108 2020-02-13  Per Arne Vollan  <pvollan@apple.com>
4109
4110         [iOS] Check if PIP is supported in the UI process
4111         https://bugs.webkit.org/show_bug.cgi?id=207406
4112
4113         Reviewed by Brent Fulgham.
4114
4115         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4116         * TestWebKitAPI/Tests/WebKit/PictureInPictureSupport.mm: Added.
4117         (TEST):
4118
4119 2020-02-13  Jonathan Bedard  <jbedard@apple.com>
4120
4121         TestWebKitAPI: Conditionalize fullscreen tests on fullscreen API
4122         https://bugs.webkit.org/show_bug.cgi?id=207397
4123         <rdar://problem/59268128>
4124
4125         Reviewed by Jer Noble.
4126
4127         * TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm:
4128         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewCloseAllMediaPresentations.mm:
4129
4130 2020-02-13  Jonathan Bedard  <jbedard@apple.com>
4131
4132         TestWebKitAPI: Re-baseline DocumentEditingContext for Catalyst
4133         https://bugs.webkit.org/show_bug.cgi?id=207696
4134
4135         Reviewed by Tim Horton.
4136
4137         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
4138
4139 2020-02-13  Wenson Hsieh  <wenson_hsieh@apple.com>
4140
4141         [iOS] -updateSelectionWithExtentPoint:completionHandler: should work without requiring floating cursor
4142         https://bugs.webkit.org/show_bug.cgi?id=207680
4143         <rdar://problem/59340940>
4144
4145         Reviewed by Tim Horton.
4146
4147         Add a new API test to verify that calling -updateSelectionWithExtentPoint:completionHandler: with a point behind
4148         the current selection works.
4149
4150         * TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm:
4151         (-[TestWKWebView updateSelectionWithExtentPoint:]):
4152         * TestWebKitAPI/ios/UIKitSPI.h:
4153
4154 2020-02-13  Said Abou-Hallawa  <said@apple.com>
4155
4156         Unreviewed, rolling out r255158, 255405 and r255486
4157
4158         Caused test flakiness and PLT regression.
4159
4160         * DumpRenderTree/mac/DumpRenderTree.mm:
4161         (resetWebPreferencesToConsistentValues):
4162         * DumpRenderTree/win/DumpRenderTree.cpp:
4163         (enableExperimentalFeatures):
4164         * WebKitTestRunner/TestController.cpp:
4165         (WTR::TestController::resetPreferencesToConsistentValues):
4166
4167 2020-02-12  Jonathan Bedard  <jbedard@apple.com>
4168
4169         run-javascriptcore-tests: Allow insecure requests on upload
4170         https://bugs.webkit.org/show_bug.cgi?id=207662
4171
4172         Rubber-stamped by Aakash Jain.
4173
4174         * Scripts/run-javascriptcore-tests:
4175         (uploadResults): Allow insecure curl request when posting results.
4176
4177 2020-02-12  Truitt Savell  <tsavell@apple.com>
4178
4179         Unreviewed, rolling out r256463.
4180
4181         Caused major flakiness on Mac wk2
4182
4183         Reverted changeset:
4184
4185         "REGRESSION (r255158): http/tests/frame-throttling/raf-
4186         throttle-in-cross-origin-subframe.html is a flaky failure"
4187         https://bugs.webkit.org/show_bug.cgi?id=206839
4188         https://trac.webkit.org/changeset/256463
4189
4190 2020-02-12  Jonathan Bedard  <jbedard@apple.com>
4191
4192         results.webkit.org: Remove debug JS logging
4193         https://bugs.webkit.org/show_bug.cgi?id=207663
4194
4195         Reviewed by Aakash Jain.
4196
4197         * resultsdbpy/resultsdbpy/view/static/js/investigate.js:
4198         (elapsed):
4199         * resultsdbpy/resultsdbpy/view/static/js/tooltip.js:
4200         (_ToolTip.prototype.toString):
4201         * resultsdbpy/resultsdbpy/view/static/library/js/Ref.js:
4202         (prototype.addWithDelay):
4203         * resultsdbpy/resultsdbpy/view/templates/archive_list.html:
4204
4205 2020-02-12  Simon Fraser  <simon.fraser@apple.com>
4206
4207         Remove CSS_DEVICE_ADAPTATION
4208         https://bugs.webkit.org/show_bug.cgi?id=203479
4209
4210         Reviewed by Tim Horton.
4211         
4212         CSS Working Group resolved to remove @viewport <https://github.com/w3c/csswg-drafts/issues/4766>,
4213         so remove the code.
4214
4215         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4216
4217 2020-02-12  Said Abou-Hallawa  <said@apple.com>
4218
4219         REGRESSION (r255158): http/tests/frame-throttling/raf-throttle-in-cross-origin-subframe.html is a flaky failure
4220         https://bugs.webkit.org/show_bug.cgi?id=206839
4221
4222         Reviewed by Simon Fraser.
4223
4224         Remove the WKPreference key 'RenderingUpdateThrottlingEnabled'.
4225
4226         * DumpRenderTree/mac/DumpRenderTree.mm:
4227         (resetWebPreferencesToConsistentValues):
4228         * DumpRenderTree/win/DumpRenderTree.cpp:
4229         (enableExperimentalFeatures):
4230         * WebKitTestRunner/TestController.cpp:
4231         (WTR::TestController::resetPreferencesToConsistentValues):
4232
4233 2020-02-12  Jonathan Bedard  <jbedard@apple.com>
4234
4235         results.webkit.org: Cache archive content
4236         https://bugs.webkit.org/show_bug.cgi?id=207589
4237
4238         Reviewed by Aakash Jain.
4239
4240         * resultsdbpy/resultsdbpy/flask_support/util.py:
4241         (cache_for): Add decorator function which sets the cache values on the returned response.
4242         * resultsdbpy/resultsdbpy/view/archive_view.py:
4243         (ArchiveView): Cache archive content client-side for 12 hours.
4244         * resultsdbpy/resultsdbpy/view/archive_view_unittest.py:
4245         (ArchiveViewUnittest.test_file): Verify that archived content is cached.
4246
4247 2020-02-12  Youenn Fablet  <youenn@apple.com>
4248
4249         WebSWServerConnection::registerServiceWorkerClient is not sending IPC message to UIProcess when it should
4250         https://bugs.webkit.org/show_bug.cgi?id=207537
4251
4252         Reviewed by Chris Dumez.
4253
4254         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
4255
4256 2020-02-11  Rob Buis  <rbuis@igalia.com>
4257
4258         Bug 207424: Crash in WebCore::ParsedContentType::parseContentType when parsing invalid MIME type
4259         <https://webkit.org/b/207424>
4260         <rdar://problem/59250384>
4261
4262         Reviewed by Rob Buis.
4263
4264         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
4265         (TestWebKitAPI::TEST): Add more tests.
4266
4267 2020-02-11  Commit Queue  <commit-queue@webkit.org>
4268
4269         Unreviewed, rolling out r256314.
4270         https://bugs.webkit.org/show_bug.cgi?id=207594
4271
4272         It is breaking an API test (Requested by youenn on #webkit).
4273
4274         Reverted changeset:
4275
4276         "WebSWServerConnection::registerServiceWorkerClient is not
4277         sending IPC message to UIProcess when it should"
4278         https://bugs.webkit.org/show_bug.cgi?id=207537
4279         https://trac.webkit.org/changeset/256314
4280
4281 2020-02-11  Jonathan Bedard  <jbedard@apple.com>
4282
4283         results.webkit.org: Configuration documentation should include architecture
4284         https://bugs.webkit.org/show_bug.cgi?id=207584
4285
4286         Reviewed by Aakash Jain.
4287
4288         * resultsdbpy/resultsdbpy/view/templates/documentation.html: Add architecture documentation.
4289
4290 2020-02-11  Youenn Fablet  <youenn@apple.com>
4291
4292         Regression: RTCRtpSender.getCapabilities("video") returns null on iOS 13.4 (17E5223h)
4293         https://bugs.webkit.org/show_bug.cgi?id=207325
4294         <rdar://problem/59224810>
4295
4296         Reviewed by Eric Carlson.
4297
4298         * TestWebKitAPI/Tests/WebKit/GetUserMedia.mm:
4299         (TestWebKitAPI::TEST):
4300         Add a test validating that RTCRtpSender.getCapabilities does not return null.
4301         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
4302
4303 2020-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
4304
4305         KeyboardInputTests.SupportsImagePaste fails on recent versions of UIKit
4306         https://bugs.webkit.org/show_bug.cgi?id=207557
4307
4308         Reviewed by Jonathan Bedard.
4309
4310         The exception occurs because UIKit attempts to create a QoS interval upon setting the initially selected row in
4311         a UITableView when we focus a date picker. This fails because TestWebKitAPI isn't actually an app, so the call
4312         to `work_interval_create` with `WORK_INTERVAL_TYPE_CA_CLIENT` as the option flag fails. For the time being, work
4313         around this by focusing an empty select element instead (for which we won't attempt to create and select any
4314         table view cells).
4315
4316         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
4317
4318 2020-02-11  Alex Christensen  <achristensen@webkit.org>
4319
4320         Add WKHTTPCookieStore._getCookiesForURL SPI
4321         https://bugs.webkit.org/show_bug.cgi?id=207527
4322
4323         Reviewed by Brady Eidson.
4324
4325         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
4326         (TEST):
4327