e41385ea9216f58c89b12ef77e3ac385a5905812
[WebKit-https.git] / Tools / ChangeLog
1 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
2
3         [ews-build] Pass bug_id to the triggered builds
4         https://bugs.webkit.org/show_bug.cgi?id=193548
5
6         Reviewed by Lucas Forschler.
7
8         * BuildSlaveSupport/ews-build/factories.py:
9         (BuildFactory.propertiesToPassToTriggers):
10
11 2019-01-17  Jer Noble  <jer.noble@apple.com>
12
13         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
14         https://bugs.webkit.org/show_bug.cgi?id=189553
15
16         Reviewed by Tim Horton.
17
18         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
19
20         * ContentExtensionTester/Configurations/Base.xcconfig:
21         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
22         * DumpRenderTree/mac/Configurations/Base.xcconfig:
23         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
24         * ImageDiff/cg/Configurations/Base.xcconfig:
25         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
26         * MiniBrowser/Configurations/Base.xcconfig:
27         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
28         * MobileMiniBrowser/Configurations/Base.xcconfig:
29         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
30         * Scripts/webkitpy/style/checker.py:
31         (_all_categories):
32         (FileType):
33         (CheckerDispatcher._file_type):
34         (CheckerDispatcher._create_checker):
35         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
36         (SDKVariantChecker):
37         (SDKVariantChecker.__init__):
38         (SDKVariantChecker.check):
39         * TestWebKitAPI/Configurations/Base.xcconfig:
40         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
41         * WebEditingTester/Configurations/Base.xcconfig:
42         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
43         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
44         * WebKitTestRunner/Configurations/Base.xcconfig:
45         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
46         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
47         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
48
49 2019-01-17  Zalan Bujtas  <zalan@apple.com>
50
51         [LFC][BFC] An element with transform is a containing block for positioned descendants.
52         https://bugs.webkit.org/show_bug.cgi?id=193534
53
54         Reviewed by Antti Koivisto.
55
56         * LayoutReloaded/misc/LFC-passing-tests.txt:
57
58 2019-01-17  Zalan Bujtas  <zalan@apple.com>
59
60         [LFC][BFC][Quirk] Take body padding and border into account when stretching height.
61         https://bugs.webkit.org/show_bug.cgi?id=193528
62
63         Reviewed by Antti Koivisto.
64
65         * LayoutReloaded/misc/LFC-passing-tests.txt:
66
67 2019-01-17  Zalan Bujtas  <zalan@apple.com>
68
69         [LFC][BFC] For height computation, the bottom edge of the last line box value should include top border/padding
70         https://bugs.webkit.org/show_bug.cgi?id=193520
71
72         Reviewed by Antti Koivisto.
73
74         * LayoutReloaded/misc/LFC-passing-tests.txt:
75
76 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
77
78         [ews-build] unapply-patch step should not update source
79         https://bugs.webkit.org/show_bug.cgi?id=193234
80
81         Reviewed by Lucas Forschler.
82
83         * BuildSlaveSupport/ews-build/steps.py:
84         (CleanWorkingDirectory): Use clean-webkit script to clean the working directory.
85         (UnApplyPatchIfRequired): Use CleanWorkingDirectory as base class.
86
87 2019-01-16  Youenn Fablet  <youenn@apple.com>
88
89         Add a new SPI for controlling getUserMedia
90         https://bugs.webkit.org/show_bug.cgi?id=192793
91
92         Reviewed by Eric Carlson.
93
94         * MiniBrowser/mac/WK2BrowserWindowController.m:
95         (-[WK2BrowserWindowController _webView:requestUserMediaAuthorizationForFrame:devices:decisionHandler:]):
96         (-[WK2BrowserWindowController _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
97         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
98         (-[NavigationWhileGetUserMediaPromptDisplayedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
99         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
100         (-[GetUserMediaRepromptUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
101         * TestWebKitAPI/Tests/WebKit/MediaStreamTrackDetached.mm:
102         (-[MediaStreamTrackDetachedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
103         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
104         (-[UserMediaUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
105         (-[UserMediaUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
106         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
107         (-[SimulateFailedSandboxUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
108         (-[SimulateFailedSandboxUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
109
110 2019-01-16  Zalan Bujtas  <zalan@apple.com>
111
112         [LFC][BFC] Inflow non-replaced used width should not be negative.
113         https://bugs.webkit.org/show_bug.cgi?id=193495
114
115         Reviewed by Antti Koivisto.
116
117         * LayoutReloaded/misc/LFC-passing-tests.txt:
118
119 2019-01-16  Chris Dumez  <cdumez@apple.com>
120
121         Regression(PSON) View becomes blank after click a cross-site download link
122         https://bugs.webkit.org/show_bug.cgi?id=193361
123         <rdar://problem/47099573>
124
125         Reviewed by Geoffrey Garen.
126
127         Add API test coverage.
128
129         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
130         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
131
132 2019-01-16  Zalan Bujtas  <zalan@apple.com>
133
134         [LFC][Out-of-flow] Set used vertical margin values when top/height/bottom are non-auto.
135         https://bugs.webkit.org/show_bug.cgi?id=193470
136
137         Reviewed by Antti Koivisto.
138
139         * LayoutReloaded/misc/LFC-passing-tests.txt:
140
141 2019-01-16  Zalan Bujtas  <zalan@apple.com>
142
143         [LFC] Adjust margin box verification.
144         https://bugs.webkit.org/show_bug.cgi?id=193482
145
146         Reviewed by Antti Koivisto.
147
148         * LayoutReloaded/misc/LFC-passing-tests.txt:
149
150 2019-01-15  Sihui Liu  <sihui_liu@apple.com>
151
152         Fix API test WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming after 193354
153         https://bugs.webkit.org/show_bug.cgi?id=193451
154
155         Reviewed by Geoffrey Garen.
156
157         * TestWebKitAPI/Tests/WebKitCocoa/DuplicateCompletionHandlerCalls.mm:
158         (TEST):
159         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
160         (runWebsiteDataStoreCustomPaths):
161
162 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
163
164         webkitpy: Support boolean simctl isAvailable
165         https://bugs.webkit.org/show_bug.cgi?id=193472
166         <rdar://problem/47296150>
167
168         Reviewed by Ryosuke Niwa.
169
170         * Scripts/webkitpy/xcode/simulated_device.py:
171         (SimulatedDeviceManager._create_runtimes):
172         (SimulatedDeviceManager._create_device_with_runtime):
173
174 2019-01-15  Chris Dumez  <cdumez@apple.com>
175
176         Unreviewed, rolling out r239993, r239995, r239997, and
177         r239999.
178
179         Caused assertions under
180         ViewGestureController::disconnectFromProcess()
181
182         Reverted changesets:
183
184         "Regression(PSON) View becomes blank after click a cross-site
185         download link"
186         https://bugs.webkit.org/show_bug.cgi?id=193361
187         https://trac.webkit.org/changeset/239993
188
189         "Unreviewed iOS build fix after r239993."
190         https://trac.webkit.org/changeset/239995
191
192         "Fix iOS build after r239993"
193         https://bugs.webkit.org/show_bug.cgi?id=193361
194         https://trac.webkit.org/changeset/239997
195
196         "Unreviewed, revert part of r239997 as it is not needed to fix
197         the build."
198         https://trac.webkit.org/changeset/239999
199
200 2019-01-15  Tim Horton  <timothy_horton@apple.com>
201
202         Cannot tab out of WKWebView on macOS
203         https://bugs.webkit.org/show_bug.cgi?id=161448
204         <rdar://problem/28100085>
205
206         Reviewed by Dean Jackson.
207
208         Add a test that tabbing into and out of WKWebView works correctly.
209
210         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
211         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
212         (WebKit2_CommandBackForwardTest::SetUp):
213         (-[CommandBackForwardOffscreenWindow isKeyWindow]): Deleted.
214         (-[CommandBackForwardOffscreenWindow isVisible]): Deleted.
215         * TestWebKitAPI/Tests/WebKitCocoa/TabOutOfWebView.mm: Added.
216         (-[FocusableView canBecomeKeyView]):
217         (TEST):
218         * TestWebKitAPI/mac/OffscreenWindow.h: Added.
219         * TestWebKitAPI/mac/OffscreenWindow.mm: Added.
220         (-[OffscreenWindow initWithSize:]):
221         (-[OffscreenWindow isKeyWindow]):
222         (-[OffscreenWindow isVisible]):
223         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
224         (TestWebKitAPI::PlatformWebView::initialize):
225         (-[ActiveOffscreenWindow isKeyWindow]): Deleted.
226         (-[ActiveOffscreenWindow isVisible]): Deleted.
227         Factor ActiveOffscreenWindow out into OffscreenWindow and share it.
228
229 2019-01-15  Ryan Haddad  <ryanhaddad@apple.com>
230
231         Adjust the arguments passed to run-javascriptcore-tests for the 32-bit JSC bot
232         https://bugs.webkit.org/show_bug.cgi?id=193459
233
234         Reviewed by Mark Lam.
235
236         * BuildSlaveSupport/build.webkit.org-config/steps.py:
237         (Run32bitJSCTests): This queue should not run JIT, testair, testb3, or testmasm.
238
239 2019-01-15  Chris Dumez  <cdumez@apple.com>
240
241         Regression(PSON) View becomes blank after click a cross-site download link
242         https://bugs.webkit.org/show_bug.cgi?id=193361
243         <rdar://problem/47099573>
244
245         Reviewed by Geoff Garen.
246
247         Add API test coverage.
248
249         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
250         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
251
252 2019-01-15  Zalan Bujtas  <zalan@apple.com>
253
254         [LFC][Out-of-flow] Ignore bottom when the vertical values are over-constrained
255         https://bugs.webkit.org/show_bug.cgi?id=193448
256
257         Reviewed by Antti Koivisto.
258
259         * LayoutReloaded/misc/LFC-passing-tests.txt:
260
261 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
262
263         webkitpy: Implement device type specific expected results (Part 1)
264         https://bugs.webkit.org/show_bug.cgi?id=192162
265
266         Reviewed by Lucas Forschler.
267
268         Device type specific expected results covers two related ideas. The first (covered by this change)
269         is where to search for -expected.* files. The second is which tests to run based on the
270         TestExpectations.txt file.
271
272         After this change, the baseline search path will be determined by the type of device running a
273         test. Device type will be passed into any function which picks a file based on the baseline search
274         path.
275
276         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
277         (Worker._update_test_input): Pass device_type to self._port.reference_files(...).
278         * Scripts/webkitpy/layout_tests/controllers/manager.py:
279         (Manager.run): Print baseline search path for each round of devices.
280         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
281         (SingleTestRunner.__init__): Pass device_type into expected_*(...).
282         (SingleTestRunner._expected_driver_output): Ditto.
283         (SingleTestRunner._driver_input): Ditto.
284         * Scripts/webkitpy/layout_tests/views/printing.py:
285         (Printer.print_config): Move printing of baseline search path to a separate function.
286         (Printer.print_baseline_search_path): Moved from Printer.print_config.
287         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
288         (Testprinter.test_print_config):
289         (Testprinter.test_print_baseline_search_path):
290         * Scripts/webkitpy/port/base.py:
291         (Port.baseline_search_path): Pass device_type through.
292         (Port._expected_baselines_for_suffixes): Ditto.
293         (Port.expected_baselines): Ditto.
294         (Port.expected_filename): Ditto.
295         (Port.expected_checksum): Ditto.
296         (Port.expected_image): Ditto.
297         (Port.expected_audio): Ditto.
298         (Port.expected_text): Ditto.
299         (Port.reference_files): Ditto.
300         (Port.tests): Ditto.
301         (Port._expanded_paths): Ditto.
302         (Port.skipped_layout_tests): Ditto.
303         (Port.expectations_dict): Ditto.
304         (Port._port_specific_expectations_files): Ditto.
305         (Port.expectations_files): Ditto.
306         (Port.test_search_path): Ditto.
307         (Port._tests_for_other_platforms): Ditto.
308         * Scripts/webkitpy/port/base_unittest.py:
309         (PortTest.test_additional_platform_directory): Accept, but do not use, device_type.
310         (PortTest.test_nonexistant_expectations): Ditto.
311         (test_ref_tests_platform_directory): Ditto.
312         * Scripts/webkitpy/port/darwin.py:
313         (DarwinPort._port_specific_expectations_files): Accept device_type.
314         * Scripts/webkitpy/port/driver.py:
315         (DriverProxy):
316         (DriverProxy.host): Expose _target_host for device_type information.
317         * Scripts/webkitpy/port/gtk.py:
318         (GtkPort._port_specific_expectations_files): Accept, but do not use, device_type.
319         * Scripts/webkitpy/port/ios.py:
320         (IOSPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
321         * Scripts/webkitpy/port/mac.py:
322         (MacPort. default_baseline_search_path): Ditto.
323         * Scripts/webkitpy/port/port_testcase.py:
324         (TestWebKitPort._tests_for_other_platforms): Accept, but do not use, device_type.
325         * Scripts/webkitpy/port/test.py:
326         * Scripts/webkitpy/port/watch.py:
327         (WatchPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
328         * Scripts/webkitpy/port/win.py:
329         (WinPort.test_search_path): Accept, but do not use, device_type.
330         * Scripts/webkitpy/port/wpe.py:
331         (WPEPort._port_specific_expectations_files): Ditto.
332         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
333         (get_test_baselines.AllPlatformsPort.baseline_search_path): Ditto.
334
335 2019-01-15  Zalan Bujtas  <zalan@apple.com>
336
337         [LFC] Use the containing block's padding box to position out-of-flow elements.
338         https://bugs.webkit.org/show_bug.cgi?id=193431
339
340         Reviewed by Antti Koivisto.
341
342         * LayoutReloaded/misc/LFC-passing-tests.txt:
343
344 2019-01-14  Tim Horton  <timothy_horton@apple.com>
345
346         Move a test implementation file that got misplaced in the Xcode project
347
348         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
349
350 2019-01-14  Commit Queue  <commit-queue@webkit.org>
351
352         Unreviewed, rolling out r239901, r239909, r239910, r239912,
353         r239913, and r239914.
354         https://bugs.webkit.org/show_bug.cgi?id=193407
355
356         These revisions caused an internal failure (Requested by
357         Truitt on #webkit).
358
359         Reverted changesets:
360
361         "[Cocoa] Avoid importing directly from subumbrella frameworks"
362         https://bugs.webkit.org/show_bug.cgi?id=186016
363         https://trac.webkit.org/changeset/239901
364
365         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
366         https://trac.webkit.org/changeset/239909
367
368         "Tried to fix the build."
369         https://trac.webkit.org/changeset/239910
370
371         "Fixed iOS builds after r239910."
372         https://trac.webkit.org/changeset/239912
373
374         "More build fixing."
375         https://trac.webkit.org/changeset/239913
376
377         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
378         https://trac.webkit.org/changeset/239914
379
380 2019-01-14  Mark Lam  <mark.lam@apple.com>
381
382         Re-enable ability to build --cloop builds.
383         https://bugs.webkit.org/show_bug.cgi?id=192955
384         <rdar://problem/46882363>
385
386         Reviewed by Saam barati and Keith Miller.
387
388         The --cloop build option was being ignored this whole time since r236381.
389         This patch makes it possible to build CLoop builds again.
390
391         * Scripts/build-jsc:
392         * Scripts/webkitperl/FeatureList.pm:
393         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
394
395 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
396
397         webkitpy: Expose device_type from host-like objects
398         https://bugs.webkit.org/show_bug.cgi?id=193406
399         <rdar://problem/47262305>
400
401         Reviewed by Lucas Forschler.
402
403         Devices should expose device_type. As a result, all host objects should
404         provide a device_type property, even if they do not yet define a device_type.
405
406         * Scripts/webkitpy/common/system/systemhost.py:
407         (SystemHost):
408         (SystemHost.device_type):
409         * Scripts/webkitpy/common/system/systemhost_mock.py:
410         (MockSystemHost):
411         (MockSystemHost.device_type):
412         * Scripts/webkitpy/port/device.py:
413         (Device):
414         (Device.device_type):
415         * Scripts/webkitpy/xcode/simulated_device.py:
416         (SimulatedDeviceManager._find_exisiting_device_for_request):
417         (SimulatedDeviceManager._disambiguate_device_type):
418         (SimulatedDeviceManager._does_fulfill_request):
419         (SimulatedDeviceManager.device_count_for_type):
420         (SimulatedDeviceManager.initialize_devices):
421         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
422         (test_available_devices):
423         (test_swapping_devices):
424
425 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
426
427         webkitpy: Support alternate simctl device list output (Follow-up fix)
428         https://bugs.webkit.org/show_bug.cgi?id=193362
429         <rdar://problem/47122965>
430
431         Rubber-stamped by Lucas Forschler.
432
433         * Scripts/webkitpy/xcode/simulated_device.py:
434         (SimulatedDeviceManager.populate_available_devices):
435
436 2019-01-14  Wenson Hsieh  <wenson_hsieh@apple.com>
437
438         [iOS] Expose SPI to access the current sentence boundary and selection state
439         https://bugs.webkit.org/show_bug.cgi?id=193398
440         <rdar://problem/45893108>
441
442         Reviewed by Dean Jackson.
443
444         Add an API test to verify that an SPI client can observe changes in the `@"_selectionAttributes"` key path on
445         WKWebView, and that inserting text, deleting, and changing the selection cause selection attributes to change as
446         expected.
447
448         * TestWebKitAPI/EditingTestHarness.h:
449         * TestWebKitAPI/EditingTestHarness.mm:
450         (-[EditingTestHarness moveBackward]):
451         (-[EditingTestHarness moveForward]):
452         (-[EditingTestHarness moveForwardAndExpectEditorStateWith:]):
453
454         Add a couple of new helper methods on EditingTestHarness.
455
456         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
457         (-[SelectionChangeObserver initWithWebView:]):
458         (-[SelectionChangeObserver webView]):
459         (-[SelectionChangeObserver observeValueForKeyPath:ofObject:change:context:]):
460         (-[SelectionChangeObserver currentSelectionAttributes]):
461
462 2019-01-14  Zalan Bujtas  <zalan@apple.com>
463
464         [LFC][BFC] Add basic box-sizing support.
465         https://bugs.webkit.org/show_bug.cgi?id=193392
466
467         Reviewed by Antti Koivisto.
468
469         * LayoutReloaded/misc/LFC-passing-tests.txt:
470
471 2019-01-14  Charlie Turner  <cturner@igalia.com>
472
473         [WPE] API test gardening
474         https://bugs.webkit.org/show_bug.cgi?id=193319
475
476         Reviewed by Michael Catanzaro.
477
478         * TestWebKitAPI/glib/TestExpectations.json: Remove some now
479         passing tests.
480
481 2019-01-14  Charlie Turner  <cturner@igalia.com>
482
483         [GStreamer] Add sharedBuffer utility to GstMappedBuffer, and a testsuite
484         https://bugs.webkit.org/show_bug.cgi?id=192977
485
486         Reviewed by Carlos Garcia Campos.
487
488         * TestWebKitAPI/PlatformGTK.cmake: Build the new GStreamer test harness
489         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
490         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp: Added.
491         (TestWebKitAPI::GStreamerTest::SetUp):
492         (TestWebKitAPI::GStreamerTest::TearDown):
493         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.h: Added.
494         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp: Added.
495         (TestWebKitAPI::TEST_F):
496
497 2019-01-14  Charlie Turner  <cturner@igalia.com>
498
499         [WPE] Workaround for incorrect template specialization being selected when UChar=char16_t
500         https://bugs.webkit.org/show_bug.cgi?id=193332
501
502         Reviewed by Michael Catanzaro.
503
504         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: When UChar is
505         defined as a char16_t, which changed in ICU 59, the
506         StringTypeAdapter<UnsignedInt, ...> overload catches casts to
507         unsigned short. This test is relying on the behaviour that
508         UChar=unsigned short, which doesn't hold across platforms and ICU
509         library versions. The full fix would be a special syntax for
510         literal characters so that these ambiguities do not arise. That
511         work is proposed in https://bugs.webkit.org/show_bug.cgi?id=193101.
512         (TestWebKitAPI::TEST):
513
514 2019-01-14  Carlos Garcia Campos  <cgarcia@igalia.com>
515
516         Unreviewed. [GTK][WPE] Run distcheck with gtkdoc and MiniBrowser enabled
517
518         * Scripts/make-dist:
519         (Distcheck.configure):
520
521 2019-01-13  Aakash Jain  <aakash_jain@apple.com>
522
523         [ews-build] Update macOS queue configurations
524         https://bugs.webkit.org/show_bug.cgi?id=193365
525         <rdar://problem/47221073>
526
527         Unreviewed, renamed mac-high-sierra to mac-highsierra to match with build.webkit.org configuration.
528
529         * BuildSlaveSupport/ews-build/config.json:
530
531 2019-01-13  Zalan Bujtas  <zalan@apple.com>
532
533         [LFC] Adjust assert for statically positioned fixed elements
534         https://bugs.webkit.org/show_bug.cgi?id=193385
535
536         Reviewed by Antti Koivisto.
537
538         * LayoutReloaded/misc/LFC-passing-tests.txt:
539
540 2019-01-13  Philippe Normand  <pnormand@igalia.com>
541
542         [WPE][MiniBrowser] Ephemeral WebContext leaks in automation mode
543         https://bugs.webkit.org/show_bug.cgi?id=193387
544
545         Reviewed by Carlos Garcia Campos.
546
547         * MiniBrowser/wpe/main.cpp:
548         (main):
549
550 2019-01-12  Timothy Hatcher  <timothy@apple.com>
551
552         Have prefers-color-scheme: light always match on macOS versions before Mojave.
553         https://bugs.webkit.org/show_bug.cgi?id=191655
554         rdar://problem/46074680
555
556         Reviewed by Megan Gardner.
557
558         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
559         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
560
561 2019-01-12  Dan Bernstein  <mitz@apple.com>
562
563         [Cocoa] Avoid importing directly from subumbrella frameworks
564         https://bugs.webkit.org/show_bug.cgi?id=186016
565         <rdar://problem/40591038>
566
567         Reviewed by Sam Weinig.
568
569         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
570           LaunchServices header.
571         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
572           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
573         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
574           when using SDKs earlier than 10.13.
575         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
576           and OTHER_CPLUSPLUSFLAGS.
577         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
578           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
579         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
580           LaunchServices header.
581
582 2019-01-11  John Wilander  <wilander@apple.com>
583
584         Compile out Web API Statistics Collection
585         https://bugs.webkit.org/show_bug.cgi?id=193370
586         <rdar://problem/45388584>
587
588         Reviewed by Brent Fulgham.
589
590         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
591             Defined ENABLE_WEB_API_STATISTICS, off by default.
592
593 2019-01-11  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
594
595         [WPE] Add gtk-doc
596         https://bugs.webkit.org/show_bug.cgi?id=178900
597
598         Reviewed by Michael Catanzaro.
599
600         Add Tools/gtkdoc to manifest.txt.in files.
601         This should have been done in r238853 and caused failure in building WebKitGTK+ unstable release 2.23.2.
602
603         * gtk/manifest.txt.in: Add Tools/gtkdoc directory.
604         * wpe/manifest.txt.in: Add Tools/gtkdoc directory and uncomment lines to move documentation artifacts.
605
606 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
607
608         [iOS] Precision drop state thrashes when dragging near the top edge of an editable element
609         https://bugs.webkit.org/show_bug.cgi?id=193364
610         <rdar://problem/47214117>
611
612         Reviewed by Tim Horton.
613
614         Add a test to verify that dragging near the top of a textarea element does not flag the drop proposal as
615         precise, whereas dragging near the middle of the textarea does.
616
617         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
618         (TestWebKitAPI::TEST):
619
620 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
621
622         webkitpy: Support alternate simctl device list output
623         https://bugs.webkit.org/show_bug.cgi?id=193362
624         <rdar://problem/47122965>
625
626         Reviewed by Lucas Forschler.
627
628         * Scripts/webkitpy/xcode/simulated_device.py:
629         (SimulatedDeviceManager.populate_available_devices):
630
631 2019-01-11  Aakash Jain  <aakash_jain@apple.com>
632
633         [ews-build] Update macOS queue configurations
634         https://bugs.webkit.org/show_bug.cgi?id=193365
635
636         Reviewed by Lucas Forschler.
637
638         * BuildSlaveSupport/ews-build/config.json:
639
640 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
641
642         webkitpy: Incorporate device type into baseline search path
643         https://bugs.webkit.org/show_bug.cgi?id=193356
644         <rdar://problem/47215515>
645
646         Reviewed by Lucas Forschler.
647
648         We need a way to include device type in the baseline search path for iOS to support device specific test expectations.
649
650         * Scripts/webkitpy/port/base.py:
651         (Port.default_baseline_search_path): Allow device type to be passed in.
652         * Scripts/webkitpy/port/gtk.py:
653         (GtkPort.default_baseline_search_path): Ignore device type.
654         * Scripts/webkitpy/port/ios.py:
655         (IOSPort.default_baseline_search_path): Optionally allow device type to be incorporated into the baseline search path.
656         (IOSPort.test_expectations_file_position): Update index for the additional device-type specific baseline search path.
657         * Scripts/webkitpy/port/ios_device_unittest.py:
658         (IOSDeviceTest):
659         * Scripts/webkitpy/port/ios_simulator_unittest.py:
660         (IOSSimulatorTest):
661         * Scripts/webkitpy/port/mac.py:
662         (MacPort.default_baseline_search_path): Ignore device type.
663         * Scripts/webkitpy/port/watch.py:
664         (WatchPort.default_baseline_search_path): Ditto.
665         * Scripts/webkitpy/port/win.py:
666         (WinPort.default_baseline_search_path): Ditto.
667         (WinCairoPort.default_baseline_search_path): Ditto.
668         * Scripts/webkitpy/port/wpe.py:
669         (WPEPort.default_baseline_search_path): Ditto.
670
671 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
672
673         webkitpy: Print abbreviated baseline search path that includes only folders that exist
674         https://bugs.webkit.org/show_bug.cgi?id=193352
675         <rdar://problem/47210736>
676
677         Reviewed by Lucas Forschler.
678
679         * Scripts/webkitpy/layout_tests/views/printing.py:
680         (Printer.print_config): Print list on only baseline search paths which exist. 
681         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
682         (Testprinter.test_print_config):
683
684 2019-01-11  Joseph Pecoraro  <pecoraro@apple.com>
685
686         Cleanup possible WK*Copy/Create leaks in WebKitTestRunner
687         https://bugs.webkit.org/show_bug.cgi?id=193340
688
689         Reviewed by David Kilzer.
690
691         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
692         (WTR::InjectedBundle::didReceiveMessageToPage):
693         Pull the strings out into a WKRetainPtr.
694
695         * WebKitTestRunner/WebNotificationProvider.cpp:
696         (WTR::WebNotificationProvider::closeWebNotification):
697         Adopt the created value into the WKRetainPtr.
698
699         * WebKitTestRunner/mac/TestControllerMac.mm:
700         (WTR::generateWhitelist):
701         Immediately adopt a created value to avoid potential mistakes.
702
703 2019-01-11  Dominik Infuehr  <dinfuehr@igalia.com>
704
705         Enable DFG on ARM/Linux again
706         https://bugs.webkit.org/show_bug.cgi?id=192496
707
708         Reviewed by Yusuke Suzuki.
709
710         After changing the bytecode format DFG was disabled on all 32-bit
711         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
712         on ARM by default.
713
714         * Scripts/run-jsc-stress-tests:
715
716 2019-01-11  Timothy Hatcher  <timothy@apple.com>
717
718         Unreviewed, fix #ifdef in API test added in r239851.
719         https://bugs.webkit.org/show_bug.cgi?id=193327
720         rdar://problem/47093222
721
722         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm:
723
724 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
725
726         Introduce IDL files for runtime-enabled UndoManager and UndoItem JavaScript API
727         https://bugs.webkit.org/show_bug.cgi?id=193109
728         <rdar://problem/44807048>
729
730         Reviewed by Ryosuke Niwa.
731
732         Introduce and respect a test option to enable the UndoManager API.
733
734         * WebKitTestRunner/TestController.cpp:
735         (WTR::updateTestOptionsFromTestHeader):
736         * WebKitTestRunner/TestOptions.h:
737         (WTR::TestOptions::hasSameInitializationOptions const):
738         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
739         (WTR::TestController::platformCreateWebView):
740
741 2019-01-11  Zalan Bujtas  <zalan@apple.com>
742
743         [LFC][BFC][MarginCollapsing] Adjust vertical position when box margin collapses through.
744         https://bugs.webkit.org/show_bug.cgi?id=193346
745
746         Reviewed by Antti Koivisto.
747
748         * LayoutReloaded/misc/LFC-passing-tests.txt:
749
750 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
751
752         Unreviewed, fix typo that breaks dashboard link.
753
754         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
755         (WebKitBuildbot):
756
757 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
758
759         Update macOS queue configurations
760         https://bugs.webkit.org/show_bug.cgi?id=193329
761
762         Reviewed by Alexey Proskuryakov.
763
764         * BuildSlaveSupport/build.webkit.org-config/config.json:
765         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
766         (BubbleQueueServer):
767         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
768         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
769         (WebKitBuildbot):
770         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
771         (table.queue-grid tr.platform.macos-sierra img.logo): Deleted.
772         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
773
774 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
775
776         MiniBrowser should be able to navigate to about:blank
777         https://bugs.webkit.org/show_bug.cgi?id=193345
778
779         Reviewed by Simon Fraser.
780
781         * MiniBrowser/mac/BrowserWindowController.m:
782         (-[BrowserWindowController addProtocolIfNecessary:]):
783         Don't prepend "http://" to "about:" prefixed URLs like "about:blank".
784
785         * MiniBrowser/mac/WK1BrowserWindowController.m:
786         (-[WK1BrowserWindowController fetch:]):
787         * MiniBrowser/mac/WK2BrowserWindowController.m:
788         (-[WK2BrowserWindowController fetch:]):
789         Clean up the code that uses this to match style.
790
791 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
792
793         Remove MiniBrowser custom "Process Swap" menu item which does not work
794         https://bugs.webkit.org/show_bug.cgi?id=193344
795
796         Reviewed by Simon Fraser.
797
798         There is a menu item under the Experimental menu that does work.
799
800         * MiniBrowser/mac/AppDelegate.m:
801         (defaultConfiguration):
802         * MiniBrowser/mac/SettingsController.h:
803         * MiniBrowser/mac/SettingsController.m:
804         (-[SettingsController _populateMenu]):
805         (-[SettingsController validateMenuItem:]):
806         (-[SettingsController processSwapOnNavigationEnabled]): Deleted.
807         (-[SettingsController toggleProcessSwapOnNavigation:]): Deleted.
808
809 2019-01-10  Timothy Hatcher  <timothy@apple.com>
810
811         Add WKBundlePage SPI to temporarily force light or dark appearance on a page.
812         https://bugs.webkit.org/show_bug.cgi?id=193327
813         rdar://problem/47093222
814
815         Reviewed by Tim Horton.
816
817         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
818         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm: Added.
819         (TestWebKitAPI::didFinishNavigation):
820         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
821         (TestWebKitAPI::TEST):
822         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm: Added.
823         (TestWebKitAPI::ForceLightAppearanceInBundleTest::ForceLightAppearanceInBundleTest):
824         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didCreatePage):
825         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didReceiveMessage):
826         * TestWebKitAPI/Tests/WebKit/mac/dark-mode.html: Added.
827
828 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
829
830         Leak of WKWebProcessPlugInHitTestResult (160 bytes) in com.apple.WebKit.WebContent running layout tests
831         https://bugs.webkit.org/show_bug.cgi?id=193338
832         <rdar://problem/46664774>
833
834         Reviewed by David Kilzer.
835
836         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
837         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
838
839 2019-01-10  Commit Queue  <commit-queue@webkit.org>
840
841         Unreviewed, rolling out r239825.
842         https://bugs.webkit.org/show_bug.cgi?id=193330
843
844         Broke tests on armv7/linux bots (Requested by guijemont on
845         #webkit).
846
847         Reverted changeset:
848
849         "Enable DFG on ARM/Linux again"
850         https://bugs.webkit.org/show_bug.cgi?id=192496
851         https://trac.webkit.org/changeset/239825
852
853 2019-01-10  Zhifei Fang  <zhifei_fang@apple.com>
854
855         Disable the run-jsc-stress-test remote host key check.
856         https://bugs.webkit.org/show_bug.cgi?id=192988
857
858         Reviewed by Alexey Proskuryakov.
859
860         * Scripts/run-jsc-stress-tests:
861
862 2019-01-10  John Wilander  <wilander@apple.com>
863
864         Override the session configuration for cookieAcceptPolicy
865         https://bugs.webkit.org/show_bug.cgi?id=190925
866         <rdar://problem/45497382>
867
868         Reviewed by Alexey Proskuryakov and Alex Christensen.
869
870         Test infrastructure for setting a first-party-only cookie policy.
871
872         * DumpRenderTree/TestRunner.cpp:
873         (setOnlyAcceptFirstPartyCookiesCallback):
874         (TestRunner::staticFunctions):
875         * DumpRenderTree/TestRunner.h:
876         * DumpRenderTree/mac/TestRunnerMac.mm:
877         (TestRunner::setOnlyAcceptFirstPartyCookies):
878         * DumpRenderTree/win/TestRunnerWin.cpp:
879         (TestRunner::setOnlyAcceptFirstPartyCookies):
880         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
881         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
882         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
883         * WebKitTestRunner/InjectedBundle/TestRunner.h:
884         * WebKitTestRunner/TestInvocation.cpp:
885         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
886
887 2019-01-09  Matt Rajca  <mrajca@apple.com>
888
889         Put per-document autoplay behavior behind runtime website policies quirk instead of a compile time flag
890         https://bugs.webkit.org/show_bug.cgi?id=193301
891
892         Reviewed by Jer Noble.
893         
894         Added API tests.
895
896         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
897         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
898         (TEST):
899         * TestWebKitAPI/Tests/WebKitCocoa/autoplaying-multiple-media-elements.html: Added.
900
901 2019-01-10  Zalan Bujtas  <zalan@apple.com>
902
903         [LFC][BFC][MarginCollapsing] Take collapsed through siblings into account when computing vertical position
904         https://bugs.webkit.org/show_bug.cgi?id=193310
905
906         Reviewed by Antti Koivisto.
907
908         * LayoutReloaded/misc/LFC-passing-tests.txt:
909
910 2019-01-10  Dominik Infuehr  <dinfuehr@igalia.com>
911
912         Enable DFG on ARM/Linux again
913         https://bugs.webkit.org/show_bug.cgi?id=192496
914
915         Reviewed by Yusuke Suzuki.
916
917         After changing the bytecode format DFG was disabled on all 32-bit
918         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
919         on ARM by default.
920
921         * Scripts/run-jsc-stress-tests:
922
923 2019-01-09  Fujii Hironori  <Hironori.Fujii@sony.com>
924
925         [Win][MiniBrowser] wchar_t strings shouldn't be treated as BSTR
926         https://bugs.webkit.org/show_bug.cgi?id=193271
927
928         Reviewed by Brent Fulgham.
929
930         BSTR is a special data structure created by SysAllocString, not a
931         wchar_t null-terminated string.
932
933         * DumpRenderTree/win/TestRunnerWin.cpp:
934         (TestRunner::setDatabaseQuota): Use L"" instead of "" for _bstr_t.
935         * MiniBrowser/win/MiniBrowserWebHost.cpp:
936         (MiniBrowserWebHost::didFinishLoadForFrame): Use _bstr_t to create
937         BSTR from wide string literals.
938
939 2019-01-09  Alexey Proskuryakov  <ap@apple.com>
940
941         Tweak wording for build/version_check style checker error
942         https://bugs.webkit.org/show_bug.cgi?id=193256
943
944         Reviewed by Tim Horton.
945
946         * Scripts/webkitpy/style/checkers/cpp.py:
947         (check_os_version_checks):
948         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
949         (WebKitStyleTest.test_os_version_checks):
950
951 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
952
953         [ews-build] Add link to bug along with bug title
954         https://bugs.webkit.org/show_bug.cgi?id=193293
955
956         Reviewed by Lucas Forschler.
957
958         * BuildSlaveSupport/ews-build/steps.py:
959         (ValidatePatch._is_bug_closed): Fetch bug title from Bugzilla and add it to the build.
960         (ConfigureBuild.add_bug_id_url): Deleted.
961         (ConfigureBuild.getBugURL): Deleted.
962
963 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
964
965         [ews-build] Use https for ews-build server
966         https://bugs.webkit.org/show_bug.cgi?id=193193
967
968         Reviewed by Lucas Forschler.
969
970         * BuildSlaveSupport/ews-build/steps.py:
971
972 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
973
974         [ews-build] Parse and display number of style failures
975         https://bugs.webkit.org/show_bug.cgi?id=193280
976
977         Reviewed by Lucas Forschler.
978
979         * BuildSlaveSupport/ews-build/steps.py:
980         (CheckStyle): Use TestWithFailureCount as base class.
981         (CheckStyle.countFailures): Count the number of style failures.
982
983 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
984
985         [ews-build] use patch_id instead of ewspatchid
986         https://bugs.webkit.org/show_bug.cgi?id=193235
987
988         Reviewed by Lucas Forschler.
989
990         * BuildSlaveSupport/ews-build/factories.py: Replaced ewspatchid with patch_id.
991         * BuildSlaveSupport/ews-build/steps.py: Ditto.
992         * BuildSlaveSupport/ews-build/steps_unittest.py: Ditto.
993
994 2019-01-09  Zalan Bujtas  <zalan@apple.com>
995
996         [LFC][BFC][MarginCollapsing] Add support for peculiar cases.
997         https://bugs.webkit.org/show_bug.cgi?id=192625
998
999         Reviewed by Antti Koivisto.
1000
1001         * LayoutReloaded/misc/LFC-passing-tests.txt:
1002
1003 2019-01-09  Michael Catanzaro  <mcatanzaro@igalia.com>
1004
1005         [WPE][GTK] Purge use of g_assert() under TestWebKitAPI
1006         https://bugs.webkit.org/show_bug.cgi?id=192841
1007
1008         Reviewed by Carlos Garcia Campos.
1009
1010         There are separate g_assert_*() macros for use in tests, which we use inconsistently
1011         currently. Use them always. We'll get nicer error messages now when tests fail, and the
1012         assertions will now run during tests even if G_DISABLE_ASSERT is used when building.
1013
1014         Note that the documentation of g_assert() says that it is not to be used when writing tests.
1015
1016         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1017         * TestWebKitAPI/Tests/WebKitGLib/EditorTest.cpp:
1018         (WebKitWebEditorTest::testSelectionChanged):
1019         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
1020         (WebKitFrameTest::testMainFrame):
1021         (WebKitFrameTest::testURI):
1022         (WebKitFrameTest::testJavaScriptContext):
1023         (WebKitFrameTest::testJavaScriptValues):
1024         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
1025         (testWebViewAuthenticationRequest):
1026         (testWebViewAuthenticationLoadCancelled):
1027         (testWebViewAuthenticationFailure):
1028         (testWebViewAuthenticationStorage):
1029         (ProxyAuthenticationTest::ProxyAuthenticationTest):
1030         (testWebViewAuthenticationProxy):
1031         (testWebViewAuthenticationProxyHTTPS):
1032         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1033         (testAutomationSessionRequestSession):
1034         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp:
1035         (testBackForwardListNavigation):
1036         (testWebKitWebViewSessionState):
1037         (testWebKitWebViewSessionStateWithFormData):
1038         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
1039         (ConsoleMessageTest::consoleMessageReceivedCallback):
1040         (testWebKitConsoleMessageConsoleAPI):
1041         (testWebKitConsoleMessageJavaScriptException):
1042         (testWebKitConsoleMessageNetworkError):
1043         (testWebKitConsoleMessageSecurityError):
1044         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
1045         (testCookieManagerAcceptPolicy):
1046         (testCookieManagerCookiesChanged):
1047         (testCookieManagerPersistentStorage):
1048         (testCookieManagerPersistentStorageDeleteAll):
1049         (testCookieManagerEphemeral):
1050         * TestWebKitAPI/Tests/WebKitGLib/TestDOMElement.cpp:
1051         (testWebKitDOMElementAutoFill):
1052         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
1053         (downloadLocalFileSuccessfully):
1054         (createFileAtDestination):
1055         (testDownloadOverwriteDestinationDisallowed):
1056         (testDownloadLocalFileError):
1057         (testDownloadRemoteFile):
1058         (testDownloadRemoteFileError):
1059         (testWebViewDownloadURI):
1060         (testPolicyResponseDownload):
1061         (testPolicyResponseDownloadCancel):
1062         (testDownloadMIMEType):
1063         (contextMenuCallback):
1064         (testContextMenuDownloadActions):
1065         (testBlobDownload):
1066         * TestWebKitAPI/Tests/WebKitGLib/TestEditor.cpp:
1067         (testWebKitWebEditorSelectionChanged):
1068         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
1069         (testWebKitFrameMainFrame):
1070         (testWebKitFrameURI):
1071         (testWebKitFrameJavaScriptContext):
1072         (testWebKitFrameJavaScriptValues):
1073         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1074         (LoadStopTrackingTest::loadFailed):
1075         (testWebViewTitle):
1076         (testURIRequestHTTPHeaders):
1077         (testURIRequestHTTPMethod):
1078         (testURIResponseHTTPHeaders):
1079         (testRedirectToDataURI):
1080         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
1081         (testProcessPerWebView):
1082         (testWebProcessLimit):
1083         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
1084         (testWebViewResources):
1085         (testWebResourceLoading):
1086         (testWebResourceSuggestedFilename):
1087         (testWebResourceGetData):
1088         (testWebResourceGetDataError):
1089         (testWebViewResourcesHistoryCache):
1090         (testWebResourceSendRequest):
1091         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
1092         (testSSL):
1093         (testInsecureContent):
1094         (testTLSErrorsPolicy):
1095         (testTLSErrorsRedirect):
1096         (testTLSErrorsHTTPAuth):
1097         (testLoadFailedWithTLSErrors):
1098         (testSubresourceLoadFailedWithTLSErrors):
1099         (httpsServerCallback):
1100         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
1101         (testWebViewCreateNavigationData):
1102         (testWebViewJavaScriptDialogs):
1103         (testWebViewWindowProperties):
1104         (testWebViewMouseTarget):
1105         (testWebViewFileChooserRequest):
1106         (testWebViewColorChooserRequest):
1107         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
1108         (testWebExtensionGetTitle):
1109         (testDocumentLoadedSignal):
1110         (testWebKitWebViewProcessCrashed):
1111         (testWebExtensionWindowObjectCleared):
1112         (testWebExtensionIsolatedWorld):
1113         (permissionRequestCallback):
1114         (didAssociateFormControlsCallback):
1115         (testWebExtensionFormControlsAssociated):
1116         (FormSubmissionTest::FormSubmissionTest):
1117         (FormSubmissionTest::testFormSubmissionResult):
1118         (testWebExtensionFormSubmissionSteps):
1119         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
1120         (testNotInitialized):
1121         (testClearDatabase):
1122         (testPrivateBrowsing):
1123         (testGetFavicon):
1124         (testWebViewFavicon):
1125         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp:
1126         (testFindControllerTextFound):
1127         (testFindControllerTextNotFound):
1128         (testFindControllerMatchCount):
1129         (testFindControllerMaxMatchCount):
1130         (testFindControllerNext):
1131         (testFindControllerPrevious):
1132         (testFindControllerCountedMatches):
1133         (testFindControllerOptions):
1134         (testFindControllerHide):
1135         (testFindControllerInstance):
1136         (testFindControllerGetters):
1137         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitPolicyClient.cpp:
1138         (testNavigationPolicy):
1139         (testResponsePolicy):
1140         (testNewWindowPolicy):
1141         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp:
1142         (testSecurityOriginBasicConstructor):
1143         (testSecurityOriginURIConstructor):
1144         (testSecurityOriginDefaultPort):
1145         (testSecurityOriginFileURI):
1146         (testOpaqueSecurityOrigin):
1147         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1148         (testWebKitSettings):
1149         (testWebKitSettingsNewWithSettings):
1150         (testWebKitSettingsUserAgent):
1151         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
1152         (testWebViewNewWithUserContentManager):
1153         (isStyleSheetInjectedForURLAtPath):
1154         (isScriptInjectedForURLAtPath):
1155         (testUserContentManagerInjectedStyleSheet):
1156         (testUserContentManagerInjectedScript):
1157         (UserScriptMessageTest::scriptMessageReceived):
1158         (UserScriptMessageTest::waitUntilMessageReceived):
1159         (UserScriptMessageTest::runJavaScriptFinished):
1160         (testUserContentManagerScriptMessageReceived):
1161         (testUserContentManagerScriptMessageInWorldReceived):
1162         (testUserContentManagerScriptMessageFromDOMBindings):
1163         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
1164         (testWebContextDefault):
1165         (testWebContextEphemeral):
1166         (testWebContextGetPlugins):
1167         (testWebContextURIScheme):
1168         (testWebContextSpellChecker):
1169         (testWebContextLanguages):
1170         (consoleMessageReceivedCallback):
1171         (testWebContextSecurityFileXHR):
1172         (ProxyTest::ProxyTest):
1173         (testWebContextProxySettings):
1174         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
1175         (testWebViewWebContext):
1176         (testWebViewWebBackend):
1177         (testWebViewEphemeral):
1178         (testWebViewCustomCharset):
1179         (testWebViewSettings):
1180         (testWebViewRunJavaScript):
1181         (testWebViewCanShowMIMEType):
1182         (testWebViewSubmitForm):
1183         (testWebViewSave):
1184         (testWebViewPageVisibility):
1185         (testWebViewSnapshot):
1186         (testWebViewNotification):
1187         (testWebViewNotificationInitialPermissionAllowed):
1188         (testWebViewNotificationInitialPermissionDisallowed):
1189         (testWebViewIsPlayingAudio):
1190         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
1191         (WebsiteDataTest::WebsiteDataTest):
1192         (WebsiteDataTest::remove):
1193         (WebsiteDataTest::clear):
1194         (testWebsiteDataConfiguration):
1195         (testWebsiteDataEphemeral):
1196         (testWebsiteDataCache):
1197         (testWebsiteDataStorage):
1198         (testWebsiteDataDatabases):
1199         (testWebsiteDataAppcache):
1200         (testWebsiteDataCookies):
1201         (testWebsiteDataDeviceIdHashSalt):
1202         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1203         (emitDocumentLoaded):
1204         (emitURIChanged):
1205         (sendRequestCallback):
1206         (contextMenuCallback):
1207         (consoleMessageSentCallback):
1208         (emitFormControlsAssociated):
1209         (formControlsAssociatedCallback):
1210         (emitFormSubmissionEvent):
1211         (willSubmitFormCallback):
1212         (windowObjectCleared):
1213         (methodCallCallback):
1214         (registerGResource):
1215         (webkit_web_extension_initialize_with_user_data):
1216         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.cpp:
1217         (checkLeaks):
1218         (WebProcessTest::create):
1219         (runTest):
1220         * TestWebKitAPI/Tests/WebKitGtk/AutocleanupsTest.cpp:
1221         (AutocleanupsTest::testWebProcessAutocleanups):
1222         * TestWebKitAPI/Tests/WebKitGtk/DOMClientRectTest.cpp:
1223         (WebKitDOMClientRectTest::testDivBoundingClientRectPosition):
1224         (WebKitDOMClientRectTest::testDivClientRectsPositionAndLength):
1225         * TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp:
1226         (WebKitDOMDOMWindowTest::testSignals):
1227         (WebKitDOMDOMWindowTest::testDispatchEvent):
1228         (WebKitDOMDOMWindowTest::testGetComputedStyle):
1229         * TestWebKitAPI/Tests/WebKitGtk/DOMNodeFilterTest.cpp:
1230         (WebKitDOMNodeFilterTest::testTreeWalker):
1231         (WebKitDOMNodeFilterTest::testNodeIterator):
1232         * TestWebKitAPI/Tests/WebKitGtk/DOMNodeTest.cpp:
1233         (WebKitDOMNodeTest::testHierarchyNavigation):
1234         (WebKitDOMNodeTest::testInsertion):
1235         (WebKitDOMNodeTest::testTagNamesNodeList):
1236         (WebKitDOMNodeTest::testTagNamesHTMLCollection):
1237         (WebKitDOMNodeTest::testDOMCache):
1238         * TestWebKitAPI/Tests/WebKitGtk/DOMXPathNSResolverTest.cpp:
1239         (WebKitDOMXPathNSResolverTest::evaluateFooChildTextAndCheckResult):
1240         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
1241         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
1242         * TestWebKitAPI/Tests/WebKitGtk/TestAutocleanups.cpp:
1243         (testUIProcessAutocleanups):
1244         (testWebProcessAutocleanups):
1245         * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
1246         (testContextMenuPopulateMenu):
1247         (testContextMenuDismissed):
1248         * TestWebKitAPI/Tests/WebKitGtk/TestDOMClientRect.cpp:
1249         (testWebKitDOMClientRectDivBoundingClientRectPosition):
1250         (testWebKitDOMClientRectDivClientRectsPositionAndLength):
1251         * TestWebKitAPI/Tests/WebKitGtk/TestDOMDOMWindow.cpp:
1252         (testWebKitDOMDOMWindowSignals):
1253         (testWebKitDOMDOMWindowDispatchEvent):
1254         (testWebKitDOMDOMWindowGetComputedStyle):
1255         * TestWebKitAPI/Tests/WebKitGtk/TestDOMNode.cpp:
1256         (testWebKitDOMNodeHierarchyNavigation):
1257         (testWebKitDOMNodeInsertion):
1258         (testWebKitDOMNodeTagNamesNodeList):
1259         (testWebKitDOMNodeTagNamesHTMLCollection):
1260         (testWebKitDOMObjectCache):
1261         * TestWebKitAPI/Tests/WebKitGtk/TestDOMNodeFilter.cpp:
1262         (testWebKitDOMNodeFilterTreeWalker):
1263         (testWebKitDOMNodeFilterNodeIterator):
1264         * TestWebKitAPI/Tests/WebKitGtk/TestDOMXPathNSResolver.cpp:
1265         (testWebKitDOMXPathNSResolverNative):
1266         (testWebKitDOMXPathNSResolverCustom):
1267         * TestWebKitAPI/Tests/WebKitGtk/TestInspector.cpp:
1268         (testInspectorDefault):
1269         (testInspectorManualAttachDetach):
1270         (testInspectorCustomContainerDestroyed):
1271         * TestWebKitAPI/Tests/WebKitGtk/TestInspectorServer.cpp:
1272         (startTestServer):
1273         (testInspectorServerPageList):
1274         * TestWebKitAPI/Tests/WebKitGtk/TestOptionMenu.cpp:
1275         (OptionMenuTest::showOptionMenuCallback):
1276         (OptionMenuTest::menuCloseCallback):
1277         (OptionMenuTest::close):
1278         (OptionMenuTest::activateItem):
1279         (OptionMenuTest::selectItem):
1280         (testOptionMenuSimple):
1281         (testOptionMenuGroups):
1282         (testOptionMenuActivate):
1283         (testOptionMenuSelect):
1284         * TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp:
1285         (testPrintOperationPrintSettings):
1286         (webViewPrintCallback):
1287         (testPrintOperationPrint):
1288         (testPrintCustomWidget):
1289         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
1290         (checkAtspiAccessible):
1291         (testAtspiBasicHierarchy):
1292         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitVersion.cpp:
1293         (testWebKitCheckVersion):
1294         * TestWebKitAPI/Tests/WebKitGtk/TestWebViewEditor.cpp:
1295         (testWebViewEditorCutCopyPasteNonEditable):
1296         (testWebViewEditorCutCopyPasteEditable):
1297         (testWebViewEditorSelectAllNonEditable):
1298         (testWebViewEditorSelectAllEditable):
1299         (loadContentsAndTryToCutSelection):
1300         (testWebViewEditorNonEditable):
1301         (testWebViewEditorEditable):
1302         (testWebViewEditorEditorStateTypingAttributes):
1303         (testWebViewEditorInsertImage):
1304         (testWebViewEditorCreateLink):
1305         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
1306         (loadChangedCallback):
1307         (loadFailedCallback):
1308         (loadFailedWithTLSErrorsCallback):
1309         (LoadTrackingTest::LoadTrackingTest):
1310         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
1311         (registerGResource):
1312         (removeNonEmptyDirectory):
1313         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1314         (Test::adoptView):
1315         (Test::~Test):
1316         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
1317         (WebKitTestBus::getOrCreateConnection):
1318         (WebKitTestBus::createProxy):
1319         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp:
1320         (WebKitTestServer::getWebSocketURIForPath const):
1321         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
1322         (WebViewTest::initializeWebView):
1323         (WebViewTest::loadURI):
1324         (WebViewTest::loadHtml):
1325         (WebViewTest::loadPlainText):
1326         (WebViewTest::loadBytes):
1327         (WebViewTest::loadRequest):
1328         (WebViewTest::loadAlternateHTML):
1329         (WebViewTest::goBack):
1330         (WebViewTest::goForward):
1331         (WebViewTest::goToBackForwardListItem):
1332         (resourceGetDataCallback):
1333         (WebViewTest::mainResourceData):
1334         (WebViewTest::javascriptResultToCString):
1335         (WebViewTest::javascriptResultToNumber):
1336         (WebViewTest::javascriptResultToBoolean):
1337         (WebViewTest::javascriptResultIsNull):
1338         (WebViewTest::javascriptResultIsUndefined):
1339         (onSnapshotReady):
1340         (WebViewTest::runWebProcessTest):
1341         * TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp:
1342         (WebViewTest::platformInitializeWebView):
1343         (WebViewTest::showInWindow):
1344         (WebViewTest::showInWindowAndWaitUntilMapped):
1345         (WebViewTest::mouseMoveTo):
1346         (WebViewTest::emitPopupMenuSignal):
1347         (WebViewTest::keyStroke):
1348         (WebViewTest::doMouseButtonEvent):
1349
1350 2019-01-09  Philippe Normand  <pnormand@igalia.com>
1351
1352         [WPE] API tests can't run in flatpak environment
1353         https://bugs.webkit.org/show_bug.cgi?id=193242
1354
1355         Reviewed by Michael Catanzaro.
1356
1357         * Scripts/run-wpe-tests: Add --wpe to arguments passed to
1358         flatpakutils so that it knows which port it's dealing with.
1359         * glib/common.py: Remove build_dir globals so that subsequent
1360         calls actually take args into account.
1361         (library_build_path):
1362         (binary_build_path):
1363
1364 2019-01-08  Dean Jackson  <dino@apple.com>
1365
1366         Blob references for System Previews don't get a correct file extension
1367         https://bugs.webkit.org/show_bug.cgi?id=193268
1368         <rdar://problem/47133037>
1369
1370         Reviewed by Tim Horton.
1371
1372         New test that a Blob download of a USDZ file gets named correctly.
1373
1374         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1375         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1376         (-[BlobWithUSDZExtensionDownloadDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1377         (-[BlobWithUSDZExtensionDownloadDelegate _downloadDidFinish:]):
1378         (TEST):
1379         * TestWebKitAPI/Tests/WebKitCocoa/SystemPreviewBlobNaming.html: Added.
1380
1381 2019-01-08  Jiewen Tan  <jiewen_tan@apple.com>
1382
1383         [WebAuthN] Support U2F HID Authenticators on macOS
1384         https://bugs.webkit.org/show_bug.cgi?id=191535
1385         <rdar://problem/47102027>
1386
1387         Reviewed by Brent Fulgham.
1388
1389         This patch:
1390         1) adds support for U2F mocking mechanism;
1391         2) updates tests to reflect U2fCommandConstructor changes.
1392
1393         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp:
1394         (TestWebKitAPI::TEST):
1395         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
1396         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1397         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
1398
1399 2019-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1400
1401         [iOS] Dispatch a synthetic mousedown event prior to starting drags
1402         https://bugs.webkit.org/show_bug.cgi?id=193229
1403         <rdar://problem/46717097>
1404
1405         Reviewed by Tim Horton.
1406
1407         Add a cross-platform drag and drop test to verify that calling `preventDefault()` on the mousedown event
1408         prevents a drag from starting.
1409
1410         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
1411         * TestWebKitAPI/Tests/WebKitCocoa/link-and-target-div.html:
1412
1413         Tweak this test to make it robust when dragging the link to the target element multiple times in a single test.
1414
1415 2019-01-08  Zhifei Fang  <zhifei_fang@apple.com>
1416   
1417         Layout test will generate a perf metric file to results dir.
1418         https://bugs.webkit.org/show_bug.cgi?id=192030
1419         <rdar://problem/32779516>
1420
1421         Reviewed by Aakash Jain.
1422
1423         Layout test running time will be collected to a perf metric file.
1424         For now, instead of outputing running time of all tests (which is huge),
1425         we aggregate them by test directories which are at most two level deep. 
1426
1427         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1428         (Manager._end_test_run):
1429         (Manager._output_perf_metrics):
1430         (Manager._print_expectation_line_for_test):
1431         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1432         (add_test_perf_metric):
1433         (test_perf_metrics):
1434         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1435         (JSONGeneratorTest.test_test_timings_trie):
1436         (JSONGeneratorTest):
1437         (JSONGeneratorTest.test_test_perf_metrics):
1438         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1439         (RebaselineTest.test_reset_results):
1440         (RebaselineTest.test_missing_results):
1441         (RebaselineTest.test_new_baseline):
1442
1443 2019-01-08  Patrick Griffis  <pgriffis@igalia.com>
1444
1445         [WPE][GTK] Add php-json to install-dependencies
1446         https://bugs.webkit.org/show_bug.cgi?id=193233
1447
1448         Reviewed by Michael Catanzaro.
1449
1450         * gtk/install-dependencies:
1451         * wpe/install-dependencies:
1452
1453 2019-01-08  Chris Dumez  <cdumez@apple.com>
1454
1455         Regression(PSON-r239182): Blank view when navigating back and forth between google.com and stack overflow
1456         https://bugs.webkit.org/show_bug.cgi?id=193224
1457         <rdar://problem/47097726>
1458
1459         Reviewed by Alex Christensen.
1460
1461         Add API test coverage.
1462
1463         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1464
1465 2019-01-07  David Kilzer  <ddkilzer@apple.com>
1466
1467         Leak of ScrollCompletionCallbackData (16 bytes) in com.apple.WebKit.WebContent running WebKit layout tests
1468         <https://webkit.org/b/193222>
1469         <rdar://problem/46862309>
1470
1471         Reviewed by Joseph Pecoraro.
1472
1473         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1474         (WTR::executeCallback): Fix camel case of variable name.
1475         (WTR::EventSendingController::callAfterScrollingCompletes): If
1476         WKBundlePageRegisterScrollOperationCompletionCallback() returns
1477         false, make sure to release the ScrollCompletionCallbackData
1478         object.  This fixes the leak.
1479
1480 2019-01-07  Fujii Hironori  <Hironori.Fujii@sony.com>
1481
1482         [Win] EWS: wincairo-ews cannot apply a patch with *.png
1483         https://bugs.webkit.org/show_bug.cgi?id=193044
1484
1485         Reviewed by Daniel Bates.
1486
1487         WinCairo EWS bots are using Windows Perl. Binary files should be
1488         opened as binary mode.
1489
1490         * Scripts/svn-apply:
1491         (handleGitBinaryChange): Use 'binmode' for binary file handles.
1492
1493 2019-01-07  Don Olmstead  <don.olmstead@sony.com>
1494
1495         [CMake] Add ENABLE_CSS_TYPED_OM option
1496         https://bugs.webkit.org/show_bug.cgi?id=193216
1497
1498         Reviewed by Michael Catanzaro.
1499
1500         * Scripts/webkitperl/FeatureList.pm:
1501
1502 2019-01-07  David Kilzer  <ddkilzer@apple.com>
1503
1504         Prefer RetainPtr<NSObject> to RetainPtr<NSObject *>
1505         <https://webkit.org/b/193056>
1506
1507         Reviewed by Alex Christensen.
1508
1509         * Scripts/webkitpy/style/checker.py:
1510         - Ignore use of new runtime/retainptr check in
1511           Tools/TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm since it
1512           contains tests to ensure RetainPtr<NSObject *> is compatible
1513           with RetainPtr<NSObject>.
1514
1515         * Scripts/webkitpy/style/checkers/cpp.py:
1516         (check_language):
1517         (CppChecker):
1518         - Add checker for use of '*' in RetainPtr<> type.  A for loop
1519           was used instead of a single regex so that angle brackets
1520           could be matched up when checking the type contained within
1521           the RetainPtr<> type.
1522
1523         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1524         (CppStyleTest):
1525         - Add unit test for new runtime/retainptr check.
1526
1527         * TestRunnerShared/EventSerialization/mac/EventSerializerMac.h:
1528         * TestWebKitAPI/EditingTestHarness.h:
1529         - Remove '*' from RetainPtr<> type.
1530
1531         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1532         - Add cf/RetainPtr.cpp back to TestWTFLibrary target!  This
1533           regressed in r201938.
1534
1535         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
1536         (TestWebKitAPI::TEST):
1537         - Update tests to match RetainPtr.mm tests (except for the
1538           `*SimilarNSType` tests since there is no CF equivalent of
1539           RetainPtr<NSString> and RetainPtr<NSString *>).
1540
1541         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
1542         (TestWebKitAPI::TEST):
1543         - Update tests to:
1544           - Not conflict by name with equivalent CF tests in
1545             RetainPtr.cpp.
1546           - Add test cases for RetainPtr<NSObject>,
1547             RetainPtr<NSObject *> and RetainPtr<id> were appropriate.
1548           - Add `*SimilarNSType` tests for converting between
1549             RetainPtr<NSObject> and RetainPtr<NSObject *>.
1550           - Change `0` to `nil` as appropriate.
1551           - Re-alphabetize the tests by name.
1552           - Add Optional<RetainPtr<>> tests.
1553           - Add retainPtr() tests.
1554
1555         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
1556         (-[DownloadProgressTestRunner _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1557         * TestWebKitAPI/Tests/WebKitCocoa/IconLoadingDelegate.mm:
1558         (TEST):
1559         - Remove '*' from RetainPtr<> type.
1560
1561         * TestWebKitAPI/Tests/WebKitCocoa/JITEnabled.mm:
1562         (TEST(WebKit, JITEnabled)):
1563         - Add missing WTFMove().  Apparently a temporary was being
1564           created before in the argument list due to mismatched
1565           RetainPtr<> types.
1566
1567         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1568         * TestWebKitAPI/Tests/WebKitCocoa/VideoControlsManager.mm:
1569         (TestWebKitAPI::setUpWebViewForTestingVideoControlsManager):
1570         (TestWebKitAPI::TEST):
1571         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1572         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1573         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1574         (WTR::resourcesDirectoryURL):
1575         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
1576         (WTR::InjectedBundle::platformInitialize):
1577         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1578         - Remove '*' from RetainPtr<> type.
1579
1580 2019-01-07  Eric Carlson  <eric.carlson@apple.com>
1581
1582         A MediaTime timescale must never be zero
1583         https://bugs.webkit.org/show_bug.cgi?id=193156
1584         <rdar://problem/32504501>
1585
1586         Reviewed by Jer Noble.
1587
1588         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
1589         (TestWebKitAPI::TEST): Add tests for zero timescale.
1590
1591 2019-01-07  Youenn Fablet  <youenn@apple.com>
1592
1593         API test broken: TestWebKitAPI.WebKit.CustomDataStorePathsVersusCompletionHandlers
1594         https://bugs.webkit.org/show_bug.cgi?id=193175
1595
1596         Reviewed by Chris Dumez.
1597
1598         Updated API test as we bumped the SW schema to version 4.
1599
1600         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1601         * TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-4.sqlite3: Renamed from Tools/TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-3.sqlite3.
1602         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1603         (TEST):
1604
1605 2019-01-06  Fujii Hironori  <Hironori.Fujii@sony.com>
1606
1607         [Win][Clang] Fix compilation warnings of MiniBrowser
1608         https://bugs.webkit.org/show_bug.cgi?id=193029
1609
1610         Reviewed by Ross Kirsling.
1611
1612         * MiniBrowser/win/MiniBrowserWebHost.h: Removed unused m_oldFont
1613         and m_URLBarFont. Reorder member variables to fix -Wreorder
1614         warning.
1615         * MiniBrowser/win/PageLoadTestClient.cpp:
1616         (PageLoadTestClient::PageLoadTestClient): Reorder the member initializer list.
1617         * MiniBrowser/win/PageLoadTestClient.h: Removed 'virtual' of
1618         pageLoadStartedAtTime and pageLoadEndedAtTime. Removed unused
1619         m_currentURLIndex.
1620         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1621         (WebKitBrowserWindow::WebKitBrowserWindow): Initialize
1622         navigationClient with '{ }' to fix the missing field warning.
1623         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
1624         (initDocStruct): Changed the argument type docname to const.
1625
1626 2019-01-06  Jiewen Tan  <jiewen_tan@apple.com>
1627
1628         [WebAuthN] Import U2F command/response converters from Chromium
1629         https://bugs.webkit.org/show_bug.cgi?id=193150
1630         <rdar://problem/47054028>
1631
1632         Reviewed by Brent Fulgham.
1633
1634         Adds API tests.
1635
1636         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1637         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp:
1638         (TestWebKitAPI::getTestAttestedCredentialDataBytes):
1639         (TestWebKitAPI::getTestAuthenticatorDataBytes):
1640         (TestWebKitAPI::getTestAttestationObjectBytes):
1641         (TestWebKitAPI::getTestSignResponse):
1642         (TestWebKitAPI::getTestU2fRegisterResponse):
1643         (TestWebKitAPI::TEST):
1644         (TestWebKitAPI::convertToVector): Deleted.
1645         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
1646         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp: Added.
1647         (TestWebKitAPI::constructMakeCredentialRequest):
1648         (TestWebKitAPI::constructGetAssertionRequest):
1649         (TestWebKitAPI::TEST):
1650
1651 2019-01-05  Oriol Brufau  <obrufau@igalia.com>
1652
1653         [GTK] Add python3-setuptools, libunistring-dev, bison and flex dependencies
1654         https://bugs.webkit.org/show_bug.cgi?id=193136
1655
1656         Reviewed by Michael Catanzaro.
1657
1658         * gtk/install-dependencies:
1659         Add python3-setuptools, libunistring-dev, bison and flex to install-dependencies,
1660         they are needed by update-webkitgtk-libs.
1661
1662 2019-01-05  Aakash Jain  <aakash_jain@apple.com>
1663
1664         Unreviewed follow-up fix to r239650
1665         https://bugs.webkit.org/show_bug.cgi?id=193140
1666         <rdar://problem/47063037>
1667
1668         Typecast patch_id to string.
1669
1670         * BuildSlaveSupport/ews-build/steps.py:
1671         (ValidatePatch._is_patch_obsolete):
1672
1673 2019-01-04  Daniel Bates  <dabates@apple.com>
1674
1675         [lldb-webkit]: Add support for pretty-printing raw bitmask types
1676         https://bugs.webkit.org/show_bug.cgi?id=193024
1677
1678         Reviewed by Jer Noble.
1679
1680         Add support infrastructure to pretty-print a raw bitmask type. Included is a pretty-printer
1681         for the bitmask type WebEventFlags as an example.
1682
1683         Exposed a new function lldb_webkit.addSummaryAndSyntheticFormattersForRawBitmaskType()
1684         that can be used to register summary and synthetic child formatters for a bitmask type.
1685         For example, consider the following enum and bitmask typedefs:
1686
1687         typedef enum {
1688             A = 1 << 0,
1689             B = 1 << 1,
1690             C = 1 << 2,
1691         } SpecialFlagValues;
1692         typedef unsigned SpecialFlags;
1693
1694         To teach lldb-webkit how to pretty print SpecialFlags types, add the following code inside
1695         __lldb_init_module():
1696
1697             addSummaryAndSyntheticFormattersForRawBitmaskType(debugger, "SpecialFlags", {
1698                     1 << 0: "A",
1699                     1 << 1: "B",
1700                     1 << 2: "C",
1701             })
1702
1703         * lldb/lldb_webkit.py:
1704         (addSummaryAndSyntheticFormattersForRawBitmaskType):
1705         (addSummaryAndSyntheticFormattersForRawBitmaskType.GeneratedRawBitmaskProvider):
1706         (addSummaryAndSyntheticFormattersForRawBitmaskType.raw_bitmask_summary_provider):
1707         (addSummaryAndSyntheticFormattersForRawBitmaskType.lldb_webkit):
1708         A convenience function to dynamically creaste a synthetic formatter class and summary
1709         string function for the specified bitmask type and enumerator value to name map. This
1710         function register the dynamically created class and function with LLDB.
1711
1712         (__lldb_init_module):
1713         (FlagEnumerationProvider):
1714         (FlagEnumerationProvider._enumerator_value_to_name_map):
1715         (FlagEnumerationProvider._bitmask):
1716         (FlagEnumerationProvider._update):
1717         (FlagEnumerationProvider.has_children):
1718         (FlagEnumerationProvider.num_children):
1719         (FlagEnumerationProvider.get_child_index):
1720         (FlagEnumerationProvider.get_child_at_index):
1721         (FlagEnumerationProvider.update):
1722         Extract out provider logic from WTFOptionSetProvider into a base class that can be shared.
1723
1724         (WTFOptionSetProvider):
1725         (WTFOptionSetProvider._enumerator_value_to_name_map):
1726         (WTFOptionSetProvider._bitmask):
1727         (WTFOptionSetProvider._update):
1728         Write in terms of the base class.
1729
1730         (RawBitmaskProviderBase):
1731         (RawBitmaskProviderBase._enumerator_value_to_name_map):
1732         (RawBitmaskProviderBase._bitmask):
1733         Added. Base synthetic formatter class for a raw bitmask type. Derived classes are expected to
1734         override the class variable ENUMERATOR_VALUE_TO_NAME_MAP with a dictionary of the form:
1735         {
1736             1 << 0: "A",
1737             1 << 1: "B",
1738             1 << 2: "C",
1739         }
1740         It is not necessary to instantiate such a derived class directory. Instead use the convenience
1741         function addSummaryAndSyntheticFormattersForRawBitmaskType.
1742
1743         (WTFOptionSetProvider.has_children): Deleted.
1744         (WTFOptionSetProvider.num_children): Deleted.
1745         (WTFOptionSetProvider.get_child_index): Deleted.
1746         (WTFOptionSetProvider.get_child_at_index): Deleted.
1747         (WTFOptionSetProvider.update): Deleted.
1748
1749 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
1750
1751         [ews-build] Add build step to validate the patch before processing it
1752         https://bugs.webkit.org/show_bug.cgi?id=193140
1753
1754         Reviewed by Lucas Forschler.
1755
1756         * BuildSlaveSupport/ews-build/factories.py:
1757         (Factory.__init__): Added ValidatePatch step.
1758         * BuildSlaveSupport/ews-build/steps.py:
1759         (ValidatePatch):
1760         (ValidatePatch.fetch_data_from_url): Fetch data from a url.
1761         (ValidatePatch.get_patch_json): Get patch json data.
1762         (ValidatePatch.get_bug_json): Get bug json data.
1763         (ValidatePatch.get_bug_id_from_patch): Get bug id from a patch id.
1764         (ValidatePatch._is_patch_obsolete): Check if the patch is obsolete.
1765         (ValidatePatch._is_patch_review_denied): Check if the patch is marked r-.
1766         (ValidatePatch._is_bug_closed): Check if the bug is already closed.
1767         (ValidatePatch.skip_build): Skip the build.
1768         (ValidatePatch.start):
1769
1770 2019-01-04  Alex Christensen  <achristensen@webkit.org>
1771
1772         Progress towards fixing Mac CMake build
1773         https://bugs.webkit.org/show_bug.cgi?id=193105
1774
1775         Reviewed by Don Olmstead.
1776
1777         * TestWebKitAPI/PlatformMac.cmake:
1778
1779 2019-01-04  Alex Christensen  <achristensen@webkit.org>
1780
1781         Fix API test after r239631
1782         https://bugs.webkit.org/show_bug.cgi?id=193118
1783
1784         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
1785         (TestWebKitAPI::TEST):
1786         This test relied on m_maximumProcessCount being set to 1 in ProcessPoolConfiguration::createWithLegacyOptions.
1787         Do the same thing via the API to fix the test.
1788
1789 2019-01-04  Jer Noble  <jer.noble@apple.com>
1790
1791         [WebKitLegacy] Media playback pauses on scroll
1792         https://bugs.webkit.org/show_bug.cgi?id=192829
1793
1794         Reviewed by Eric Carlson.
1795
1796         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1797         * TestWebKitAPI/Tests/WebKitCocoa/StopSuspendResumeAllMedia.mm: Added.
1798         (TestWebKitAPI::TEST):
1799         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm: Added.
1800         (-[ScrollingDoesNotPauseMediaDelegate webViewDidFinishLoad:]):
1801         (-[ScrollingDoesNotPauseMediaDelegate uiWebView:didCommitLoadForFrame:]):
1802         (-[ScrollingDoesNotPauseMediaDelegate handleEvent:]):
1803         (TestWebKitAPI::TEST):
1804
1805 2019-01-04  Chris Dumez  <cdumez@apple.com>
1806
1807         Add support for toggling device orientation API support per site
1808         https://bugs.webkit.org/show_bug.cgi?id=193143
1809         <rdar://problem/46605724>
1810
1811         Reviewed by Alex Christensen.
1812
1813         Add API test coverage.
1814
1815         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1816         (-[DataMappingSchemeHandler setTaskHandler:]):
1817         (-[DataMappingSchemeHandler webView:startURLSchemeTask:]):
1818         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationEventEnabled:]):
1819         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1820         (-[WebsitePoliciesDeviceOrientationDelegate webView:didFinishNavigation:]):
1821
1822 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
1823
1824         [ews-build] use svn-apply script to apply the patches
1825         https://bugs.webkit.org/show_bug.cgi?id=193138
1826
1827         Reviewed by Lucas Forschler.
1828
1829         * BuildSlaveSupport/ews-build/factories.py:
1830         (Factory.__init__): Add the ApplyPatch step.
1831         * BuildSlaveSupport/ews-build/steps.py:
1832         (CheckOutSource): Added step name.
1833         (CheckOutSource.__init__): Used alwaysUseLatest so that it doesn't apply patch.
1834         (ApplyPatch): Build step to apply patch using svn-apply script.
1835         (UnApplyPatchIfRequired):
1836         (UnApplyPatchIfRequired.__init__): Deleted, since the alwaysUseLatest parameter is now in base class.
1837
1838 2019-01-04  Alex Christensen  <achristensen@webkit.org>
1839
1840         Deprecate WKContextCreate
1841         https://bugs.webkit.org/show_bug.cgi?id=193118
1842
1843         Reviewed by Brady Eidson.
1844
1845         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1846         (WebKitBrowserWindow::WebKitBrowserWindow):
1847         * TestWebKitAPI/Tests/WebKit/AboutBlankLoad.cpp:
1848         (TestWebKitAPI::TEST):
1849         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
1850         (TestWebKitAPI::TEST):
1851         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
1852         (TestWebKitAPI::TEST):
1853         * TestWebKitAPI/Tests/WebKit/CookieManager.cpp:
1854         (TestWebKitAPI::TEST):
1855         * TestWebKitAPI/Tests/WebKit/DownloadDecideDestinationCrash.cpp:
1856         (TestWebKitAPI::TEST):
1857         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
1858         (TestWebKitAPI::TEST):
1859         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
1860         (TestWebKitAPI::TEST):
1861         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
1862         (TestWebKitAPI::TEST):
1863         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
1864         (TestWebKitAPI::TEST):
1865         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
1866         (TestWebKitAPI::TEST):
1867         * TestWebKitAPI/Tests/WebKit/Find.cpp:
1868         (TestWebKitAPI::TEST):
1869         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
1870         (TestWebKitAPI::TEST):
1871         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
1872         (TestWebKitAPI::TEST):
1873         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
1874         (TestWebKitAPI::TEST):
1875         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
1876         (TestWebKitAPI::TEST):
1877         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
1878         (TestWebKitAPI::TEST):
1879         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1880         (TestWebKitAPI::TEST):
1881         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
1882         (TestWebKitAPI::TEST):
1883         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
1884         (TestWebKitAPI::loadAlternateHTMLString):
1885         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
1886         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
1887         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
1888         (TestWebKitAPI::buildAndPerformTest):
1889         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
1890         (TestWebKitAPI::TEST):
1891         * TestWebKitAPI/Tests/WebKit/NavigationClientDefaultCrypto.cpp:
1892         (TestWebKitAPI::TEST):
1893         * TestWebKitAPI/Tests/WebKit/PageGroup.cpp:
1894         (TestWebKitAPI::TEST):
1895         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
1896         (TestWebKitAPI::TEST):
1897         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1898         (TestWebKitAPI::TEST):
1899         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
1900         (TestWebKitAPI::TEST):
1901         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
1902         (TestWebKitAPI::TEST):
1903         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
1904         (TestWebKitAPI::TEST):
1905         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
1906         (TestWebKitAPI::TEST):
1907         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1908         (TestWebKitAPI::TEST):
1909         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
1910         (TestWebKitAPI::TEST):
1911         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
1912         (TestWebKitAPI::TEST):
1913         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
1914         (TestWebKitAPI::TEST):
1915         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
1916         (TestWebKitAPI::TEST):
1917         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
1918         (TestWebKitAPI::TEST):
1919         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
1920         (TestWebKitAPI::TEST):
1921         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
1922         (TestWebKitAPI::TEST):
1923         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
1924         (TestWebKitAPI::TEST):
1925         * TestWebKitAPI/Tests/WebKit/WKPageConfiguration.cpp:
1926         (TestWebKitAPI::TEST):
1927         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
1928         (TestWebKitAPI::TEST):
1929         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
1930         (TestWebKitAPI::TEST):
1931         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
1932         (TestWebKitAPI::TEST):
1933         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
1934         (TestWebKitAPI::TEST):
1935         * TestWebKitAPI/Tests/WebKit/WebCoreStatisticsWithNoWebProcess.cpp:
1936         (TestWebKitAPI::TEST):
1937         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
1938         (TestWebKitAPI::TEST):
1939         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
1940         (TestWebKitAPI::TEST):
1941         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
1942         (WebKit2_CommandBackForwardTestWKView::SetUp):
1943         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
1944         (TestWebKitAPI::TEST):
1945         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
1946         (TestWebKitAPI::TEST):
1947         * TestWebKitAPI/Tests/WebKitCocoa/SchemeRegistry.mm:
1948         (TestWebKitAPI::TEST):
1949         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
1950         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
1951
1952 2019-01-03  Matt Rajca  <mrajca@apple.com>
1953
1954         Make DidPlayMediaPreventedFromPlaying autoplay event more generic.
1955         https://bugs.webkit.org/show_bug.cgi?id=193128
1956         rdar://34554231
1957
1958         Reviewed by Jer Noble.
1959
1960         Today, the "DidPlayMediaPreventedFromPlaying" autoplay event is only sent for
1961         media prevented from autoplaying. It could be generalized to a "DidPlayMediaWithUserGesture"
1962         event along with a flag that indicates whether or not autoplay was actually prevented.
1963
1964         Tests: existing API tests were updated to reflect the new names. New API tests
1965         were added for the new case in which the "DidPlayMediaWithUserGesture" event is sent.
1966
1967         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1968         * TestWebKitAPI/Tests/WebKit/long-test.mp4: Added.
1969         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1970         (TEST):
1971         * TestWebKitAPI/Tests/WebKitCocoa/audio-with-play-button.html: Added.
1972         * TestWebKitAPI/Tests/WebKitCocoa/video-with-play-button.html: Added.
1973
1974 2019-01-04  Chris Dumez  <cdumez@apple.com>
1975
1976         [PSON] Calling history.back() from inside the load event handler prevents process-swapping
1977         https://bugs.webkit.org/show_bug.cgi?id=193120
1978
1979         Reviewed by Alex Christensen.
1980
1981         Add API test coverage.
1982
1983         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1984
1985 2019-01-04  Chris Dumez  <cdumez@apple.com>
1986
1987         Crash under WebProcessPool::addSuspendedPage()
1988         https://bugs.webkit.org/show_bug.cgi?id=193110
1989
1990         Reviewed by Youenn Fablet.
1991
1992         Add API test coverage.
1993
1994         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1995
1996 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
1997
1998         [ews-build] Check patch relevance before applying the patch
1999         https://bugs.webkit.org/show_bug.cgi?id=193102
2000
2001         Reviewed by Lucas Forschler.
2002
2003         * BuildSlaveSupport/ews-build/factories.py:
2004         (Factory.__init__): Moved CheckPatchRelevance step to base class.
2005
2006 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
2007
2008         [ews-build] Check patch relevance step should print patch id
2009         https://bugs.webkit.org/show_bug.cgi?id=193137
2010
2011         Reviewed by Lucas Forschler.
2012
2013         * BuildSlaveSupport/ews-build/steps.py:
2014         (CheckPatchRelevance.start): Update the status to include patch id.
2015
2016 2019-01-04  Jonathan Bedard  <jbedard@apple.com>
2017
2018         webkitpy: Increase simulator teardown timeout
2019         https://bugs.webkit.org/show_bug.cgi?id=193141
2020         <rdar://problem/46174217>
2021
2022         Rubber-stamped by Aakash Jain.
2023
2024         * Scripts/webkitpy/xcode/simulated_device.py:
2025         (SimulatedDeviceManager.tear_down): Use SIMULATOR_BOOT_TIMEOUT.
2026
2027 2019-01-03  Ross Kirsling  <ross.kirsling@sony.com>
2028
2029         test262-runner misbehaves when test file YAML has a trailing space
2030         https://bugs.webkit.org/show_bug.cgi?id=193053
2031
2032         Reviewed by Yusuke Suzuki.
2033
2034         * Scripts/test262/Runner.pm:
2035         (parseData):
2036         Accept trailing space when parsing a test file's YAML block.
2037
2038 2019-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
2039
2040         UserMedia test should use WKPageNavigationClient
2041         https://bugs.webkit.org/show_bug.cgi?id=192913
2042
2043         Reviewed by Youenn Fablet.
2044
2045         The test currently uses the deprecated WKPageLoaderClient. It should use
2046         WKPageNavigationClient instead, which provides the same callback under a similar name.
2047
2048         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2049         (TestWebKitAPI::TEST):
2050
2051 2019-01-02  Alex Christensen  <achristensen@webkit.org>
2052
2053         Homograph with LATIN SMALL LETTER R WITH FISHHOOK
2054         https://bugs.webkit.org/show_bug.cgi?id=192944
2055
2056         Reviewed by Tim Horton.
2057
2058         * TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
2059         (TestWebKitAPI::TEST):
2060
2061 2019-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
2062
2063         Add support for using the current text selection as the find string on iOS
2064         https://bugs.webkit.org/show_bug.cgi?id=193034
2065         <rdar://problem/45138739>
2066
2067         Reviewed by Tim Horton.
2068
2069         Add a new API test to verify that the new WebKit SPI (_stringForFind, _takeFindStringFromSelection:, and
2070         _setStringForFind) works as expected.
2071
2072         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2073         * TestWebKitAPI/Tests/WebKitCocoa/UseSelectionAsFindString.mm: Added.
2074
2075 2019-01-02  Aakash Jain  <aakash_jain@apple.com>
2076
2077         [ews-build] Use git on OpenSource EWS bots
2078         https://bugs.webkit.org/show_bug.cgi?id=193092
2079
2080         Reviewed by Lucas Forschler.
2081
2082         * BuildSlaveSupport/ews-build/steps.py:
2083         (CheckOutSource): Use git instead of svn.
2084         (CheckOutSource.__init__): Use timeout of 2 hours since the initial checkout might take a long time.
2085
2086 2019-01-02  Daniel Bates  <dabates@apple.com>
2087
2088         [lldb-webkit] Remove broken code to print WTF::OptionSet::m_storage
2089         https://bugs.webkit.org/show_bug.cgi?id=193023
2090
2091         Reviewed by Simon Fraser.
2092
2093         The code to print WTF::OptionSet::m_storage as an item in the set never worked and does
2094         not seem meaningful to fix because WTF::OptionSet::m_storage is just the sum of the printed
2095         enumerator values. We should just remove this code.
2096
2097         * lldb/lldb_webkit.py:
2098         (WTFOptionSetProvider.has_children):
2099         (WTFOptionSetProvider.num_children):
2100         (WTFOptionSetProvider.get_child_index):
2101         (WTFOptionSetProvider.get_child_at_index):
2102
2103 2018-12-29  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
2104
2105         .ycm_extra_conf.py should handle XXXInlines.h
2106         https://bugs.webkit.org/show_bug.cgi?id=193055
2107
2108         Reviewed by Carlos Garcia Campos.
2109
2110         compile_commands.json database only records flags and options for cpp source files.
2111         So, when we open headers, this database does not have any information for that.
2112         Our .ycm_extra_conf.py alleviates this by using XXX.cpp's configuration for XXX.h.
2113         But this mitigation does not handle XXXInlines.h well since we do not have XXXInlines.cpp.
2114         This patch adds support for XXXInlines.h in .ycm_extra_conf.py. When XXXInlines.h is queried,
2115         we attempt to find XXX.cpp and use the configuration if it exists.
2116
2117         * gtk/ycm_extra_conf.py:
2118         (getImplementationFilename):
2119         (FlagsForFile):
2120
2121 2018-12-31  Carlos Garcia Campos  <cgarcia@igalia.com>
2122
2123         Unreviewed. Support PHP 7.3 in Debian.
2124
2125         Add 7.3 to the list of php versions supported in Debian.
2126
2127         * Scripts/webkitpy/port/base.py:
2128         (Port._debian_php_version):
2129
2130 2018-12-27  Alex Christensen  <achristensen@webkit.org>
2131
2132         Resurrect Mac CMake build
2133         https://bugs.webkit.org/show_bug.cgi?id=192658
2134
2135         Reviewed by Yusuke Suzuki.
2136
2137         * DumpRenderTree/PlatformMac.cmake:
2138         * MiniBrowser/mac/CMakeLists.txt:
2139         * TestWebKitAPI/PlatformMac.cmake:
2140
2141 2018-12-26  Adrian Perez de Castro  <aperez@igalia.com>
2142
2143         [Tools] Remove references to Bison and Flex
2144         https://bugs.webkit.org/show_bug.cgi?id=193033
2145
2146         Reviewed by Michael Catanzaro.
2147
2148         The Bison and Flex tools are not needed anymore since r209883.
2149
2150         * CygwinDownloader/cygwin-downloader.py:
2151         * EWSTools/ubuntu-ews-packages:
2152         * Scripts/filter-build-webkit:
2153         (shouldIgnoreLine):
2154         * gtk/install-dependencies:
2155         * wpe/install-dependencies:
2156
2157 2018-12-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2158
2159         WebDriver: warn about non existing tests when parsing expectations
2160         https://bugs.webkit.org/show_bug.cgi?id=192979
2161
2162         Reviewed by Michael Catanzaro.
2163
2164         It's common to update web driver tests and forget updating the test expectations in case of tests removed or
2165         renamed.
2166
2167         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
2168         (WebDriverTestRunner.__init__):
2169
2170 2018-12-21  Chris Dumez  <cdumez@apple.com>
2171
2172         navigator.userAgent in service workers does not reflect customUserAgent set by client
2173         https://bugs.webkit.org/show_bug.cgi?id=192951
2174
2175         Reviewed by Youenn Fablet.
2176
2177         Extend API test coverage.
2178
2179         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2180         (-[SWCustomUserAgentDelegate initWithUserAgent:]):
2181         (-[SWCustomUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2182         (-[SWUserAgentMessageHandler initWithExpectedMessage:]):
2183         (-[SWUserAgentMessageHandler userContentController:didReceiveScriptMessage:]):
2184
2185 2018-12-21  Jiewen Tan  <jiewen_tan@apple.com>
2186
2187         [WebAuthN] userPresence should always be true
2188         https://bugs.webkit.org/show_bug.cgi?id=192835
2189         <rdar://problem/46538788>
2190
2191         Reviewed by Brent Fulgham.
2192
2193         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
2194         (TestWebKitAPI::TEST):
2195
2196 2018-12-19  Simon Fraser  <simon.fraser@apple.com>
2197
2198         Add support to run-benchmark to use non-default copies of the browser apps
2199         https://bugs.webkit.org/show_bug.cgi?id=192905
2200         rdar://problem/46845840
2201
2202         Reviewed by Dewei Zhu.
2203         
2204         Add support for a --browser-path argument to run-benchmark, which allows you to use
2205         a custom app bundle for a given browser (only implemented for Safari at present).
2206
2207         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2208         (BenchmarkRunner.__init__):
2209         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
2210         (BrowserDriver.__init__):
2211         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
2212         (BrowserDriverFactory.create):
2213         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
2214         (OSXBrowserDriver._launch_process):
2215         (OSXBrowserDriver._launch_process_with_caffeinate): Fix spelling.
2216         (OSXBrowserDriver._launch_process_with_caffinate): Deleted.
2217         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
2218         (OSXChromeCanaryDriver.launch_url):
2219         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
2220         (OSXFirefoxNightlyDriver.launch_url):
2221         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2222         (OSXSafariDriver.__init__):
2223         (OSXSafariDriver.launch_url):
2224         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
2225         (parse_args):
2226         (run_benchmark_plan):
2227         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py:
2228         (WebServerBenchmarkRunner.__init__):
2229         * Scripts/webkitpy/browserperfdash/browserperfdash_unittest.py:
2230         (FakeBenchmarkRunner.__init__):
2231
2232 2018-12-21  Jiewen Tan  <jiewen_tan@apple.com>
2233
2234         [WebAuthN] Import an APDU coder from Chromium
2235         https://bugs.webkit.org/show_bug.cgi?id=192949
2236         <rdar://problem/46879933>
2237
2238         Reviewed by Brent Fulgham.
2239
2240         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2241         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp: Added.
2242         (TestWebKitAPI::TEST):
2243
2244 2018-12-21  Wenson Hsieh  <wenson_hsieh@apple.com>
2245
2246         Setting the file wrapper and content type of an attachment to a PDF should update its image
2247         https://bugs.webkit.org/show_bug.cgi?id=192984
2248         <rdar://problem/46798028>
2249
2250         Reviewed by Tim Horton.
2251
2252         Add an API test to verify that setting the file wrapper for a _WKAttachment with an enclosing image element with
2253         PDF data correctly updates the image element.
2254
2255         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2256
2257 2018-12-21  Michael Catanzaro  <mcatanzaro@igalia.com>
2258
2259         Add JSCOnly to bot dashboard
2260         https://bugs.webkit.org/show_bug.cgi?id=192964
2261
2262         Reviewed by Alexey Proskuryakov.
2263
2264         Apparently we have five JSCOnly test bots and multiple developers working on keeping them in
2265         good shape. Sadly, they are hidden bots not exposed in the dashboard. They would be more
2266         useful if they were not so secret, so add them.
2267
2268         There appear to be no build-only bots, so the first column is blank. And of course there are
2269         no WebKit1 or WebKit2 bots, because this is JSCOnly, so the second and third columns are
2270         blank too. That's OK. This will be the last bot on the dashboard, so it won't look too bad,
2271         and there's plenty of room in the final column for all the bots.
2272
2273         I had a hard time picking a logo to use, because the JavaScript language does not have an
2274         official logo. But I believe I've found one that will be satisfactory.
2275
2276         I will sneak in one bonus change: WPE's EWS queue was missing, and has been added.
2277
2278         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/SquirrelFish.png: Added.
2279         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/SquirrelFish@2x.png: Added.
2280         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2281         (BubbleQueueServer):
2282         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2283         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2284         (WebKitBuildbot):
2285         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2286         (table.queue-grid tr.platform.linux-jsconly img.logo):
2287
2288 2018-12-21  Benjamin Poulain  <benjamin@webkit.org>
2289
2290         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
2291         https://bugs.webkit.org/show_bug.cgi?id=192821
2292
2293         Reviewed by Chris Dumez.
2294
2295         * DumpRenderTree/mac/DumpRenderTree.mm:
2296         (createWebViewAndOffscreenWindow):
2297         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
2298
2299 2018-12-20  Fujii Hironori  <Hironori.Fujii@sony.com>
2300
2301         [Win][Clang] Fix compilation warnings of DumpRenderTree
2302         https://bugs.webkit.org/show_bug.cgi?id=192924
2303
2304         Reviewed by Alex Christensen.
2305
2306         * DumpRenderTree/AccessibilityController.h: Added member variable initializations in the class definition.
2307         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2308         (AccessibilityController::AccessibilityController): Moved member variable initializations to the class definition.
2309         * DumpRenderTree/win/DumpRenderTree.cpp:
2310         (dumpHistoryItem): String literals can't be converted non-const type. Use auto for them.
2311         (resetWebPreferencesToConsistentValues): Pass a temporal _bstr_t
2312         object to the argument of setDefaultTextEncodingName instead of a
2313         const string literal.
2314         (createWebViewAndOffscreenWindow): Use %lx for HRESULT (aka 'long').
2315         (main): Exit if _dup2 fails. Use %lu for'DWORD'(aka 'unsigned long').
2316         (setCacheFolder): Deleted.
2317         * DumpRenderTree/win/DumpRenderTreeWin.h: Fix class/struct mismatch of FrameLoadDelegate and PolicyDelegate declarations.
2318         * DumpRenderTree/win/EditingDelegate.cpp:
2319         (dump): Use %d for int.
2320         * DumpRenderTree/win/FrameLoadDelegate.cpp: Removed unused variable g_delegateWaitingOnTimer.
2321         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2322         (BSTRFromString): Deleted unused function.
2323         * DumpRenderTree/win/TestRunnerWin.cpp:
2324         (TestRunner::setDatabaseQuota): Pass a temporal _bstr_t object to
2325         the arguemnt of setQuota instead of const string literal.
2326         * DumpRenderTree/win/WorkQueueItemWin.cpp:
2327         (jsStringRefToWString): Deleted unused function.
2328
2329 2018-12-20  Chris Dumez  <cdumez@apple.com>
2330
2331         Add API test coverage for customUserAgent client setting and service workers
2332         https://bugs.webkit.org/show_bug.cgi?id=192952
2333
2334         Reviewed by Alex Christensen.
2335
2336         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2337         (-[SWMessageHandler userContentController:didReceiveScriptMessage:]):
2338         (-[SWSchemes webView:startURLSchemeTask:]):
2339         (-[SWCustomUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2340         (-[SWUserAgentMessageHandler userContentController:didReceiveScriptMessage:]):
2341
2342 2018-12-20  Chris Dumez  <cdumez@apple.com>
2343
2344         Use Optional::hasValue() instead of Optional::has_value()
2345         https://bugs.webkit.org/show_bug.cgi?id=192948
2346
2347         Reviewed by Tim Horton.
2348
2349         * TestWebKitAPI/Tests/WebCore/CBORReaderTest.cpp:
2350         (TestWebKitAPI::TEST):
2351         * TestWebKitAPI/Tests/WebCore/CBORWriterTest.cpp:
2352         (TestWebKitAPI::TEST):
2353         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp:
2354         (TestWebKitAPI::TEST_F):
2355
2356 2018-12-20  Chris Dumez  <cdumez@apple.com>
2357
2358         Add style script rule to check for uses of std::optional<>
2359         https://bugs.webkit.org/show_bug.cgi?id=192931
2360
2361         Reviewed by Tim Horton.
2362
2363         * Scripts/webkitpy/style/checkers/cpp.py:
2364         (check_wtf_optional):
2365         (check_style):
2366
2367 2018-12-20  Jiewen Tan  <jiewen_tan@apple.com>
2368
2369         [WebAuthN] Add a runtime flag for local authenticator
2370         https://bugs.webkit.org/show_bug.cgi?id=192792
2371         <rdar://problem/46798738>
2372
2373         Reviewed by Brent Fulgham.
2374
2375         * DumpRenderTree/TestOptions.cpp:
2376         (TestOptions::TestOptions):
2377         * DumpRenderTree/TestOptions.h:
2378         * DumpRenderTree/mac/DumpRenderTree.mm:
2379         (enableExperimentalFeatures):
2380         (setWebPreferencesForTestOptions):
2381         * WebKitTestRunner/TestController.cpp:
2382         (WTR::TestController::resetPreferencesToConsistentValues):
2383         (WTR::updateTestOptionsFromTestHeader):
2384         * WebKitTestRunner/TestOptions.h:
2385         (WTR::TestOptions::hasSameInitializationOptions const):
2386
2387 2018-12-20  Jonathan Bedard  <jbedard@apple.com>
2388
2389         webkitpy: Autoinstall package URLs have changed
2390         https://bugs.webkit.org/show_bug.cgi?id=192909
2391         <rdar://problem/46860359>
2392
2393         Rubber-stamped by Alexey Proskuryakov.
2394
2395         PyPi urls have been moved around, we need to update our auto-installed packages.
2396
2397         We should check for Selenium before asking PyPi for the latest version.
2398
2399         * Scripts/webkitpy/thirdparty/__init__.py:
2400         (AutoinstallImportHook._install_mechanize): Update with new pypi url.
2401         (AutoinstallImportHook._install_keyring): Ditto.
2402         (AutoinstallImportHook._install_pep8): Ditto.
2403         (AutoinstallImportHook._install_mozlog): Ditto.
2404         (AutoinstallImportHook._install_mozprocess): Ditto.
2405         (AutoinstallImportHook._install_pytest_timeout): Ditto.
2406         (AutoinstallImportHook._install_pytest): Ditto.
2407         (AutoinstallImportHook._install_pylint): Ditto.
2408         (AutoinstallImportHook._install_buildbot): Ditto.
2409         (AutoinstallImportHook._install_coverage): Ditto.
2410         (AutoinstallImportHook._install_twisted_15_5_0): Ditto.
2411         (AutoinstallImportHook._install_selenium): Update with new pypi url, only check
2412         for new Selenium if the installed version isn't sufficient.
2413         (AutoinstallImportHook.get_latest_pypi_url): Update with new pypi url.
2414
2415 2018-12-20  Chris Dumez  <cdumez@apple.com>
2416
2417         Use Optional::valueOr() instead of Optional::value_or()
2418         https://bugs.webkit.org/show_bug.cgi?id=192933
2419
2420         Reviewed by Geoffrey Garen.
2421
2422         * TestWebKitAPI/Tests/WTF/URLParser.cpp:
2423         (TestWebKitAPI::checkURL):
2424         (TestWebKitAPI::checkRelativeURL):
2425         (TestWebKitAPI::checkURLDifferences):
2426         (TestWebKitAPI::checkRelativeURLDifferences):
2427         * TestWebKitAPI/Tests/WebCore/URLParserTextEncoding.cpp:
2428         (TestWebKitAPI::checkURL):
2429
2430 2018-12-20  Ryan Haddad  <ryanhaddad@apple.com>
2431
2432         Unreviewed, rolling out r239417.
2433
2434         Introduced two API test failures on macOS.
2435
2436         Reverted changeset:
2437
2438         "<rdar://problem/46194315> macOS: WebKit1 does not handle
2439         occlusion changes"
2440         https://bugs.webkit.org/show_bug.cgi?id=192821
2441         https://trac.webkit.org/changeset/239417
2442
2443 2018-12-20  Devin Rousso  <drousso@apple.com>
2444
2445         Web Inspector: UIString should take an optional key and description to aid localization
2446         https://bugs.webkit.org/show_bug.cgi?id=153962
2447         <rdar://problem/24542505>
2448
2449         Reviewed by Brian Burg.
2450
2451         * Scripts/extract-localizable-js-strings:
2452
2453 2018-12-20  Tim Horton  <timothy_horton@apple.com>
2454
2455         Unparented WKWebView can't retrieve main resource data for a main frame plugin
2456         https://bugs.webkit.org/show_bug.cgi?id=192923
2457         <rdar://problem/46859068>
2458
2459         Reviewed by Wenson Hsieh.
2460
2461         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2462         * TestWebKitAPI/WebKitCocoa/GetResourceData.mm:
2463         Add a test ensuring that both parented and unparented WKWebViews can
2464         retrieve main resource data when loading a PDF.
2465
2466 2018-12-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2467
2468         [GTK][WPE] Bump webkitgtk-test-fonts to 0.0.8
2469         https://bugs.webkit.org/show_bug.cgi?id=192852
2470
2471         Reviewed by Michael Catanzaro.
2472
2473         EmojiOne font was replaced by Noto Color Emoji.
2474
2475         * WebKitTestRunner/gtk/fonts/fonts.conf: Use Noto Color Emoji when Apple Color Emoji font family is used in tests.
2476         * gtk/jhbuild.modules:
2477         * wpe/jhbuild.modules:
2478
2479 2018-12-19  Chris Dumez  <cdumez@apple.com>
2480
2481         wtf/Optional.h: move-constructor and move-assignment operator should disengage the value being moved from
2482         https://bugs.webkit.org/show_bug.cgi?id=192728
2483         <rdar://problem/46746779>
2484
2485         Reviewed by Geoff Garen.
2486
2487         * DumpRenderTree/*:
2488         * MiniBrowser/*:
2489         * TestRunnerShared/*:
2490         * TestWebKitAPI/*:
2491         * WebGPUAPIStructure/*:
2492         * WebKitTestRunner/*:
2493
2494 2018-12-19  Benjamin Poulain  <benjamin@webkit.org>
2495
2496         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
2497         https://bugs.webkit.org/show_bug.cgi?id=192821
2498
2499         Reviewed by Chris Dumez.
2500
2501         * DumpRenderTree/mac/DumpRenderTree.mm:
2502         (createWebViewAndOffscreenWindow):
2503
2504 2018-12-19  Alex Christensen  <achristensen@webkit.org>
2505
2506         Navigations away from the SafeBrowsing interstitial show a flash of old content
2507         https://bugs.webkit.org/show_bug.cgi?id=192676
2508
2509         Reviewed by Chris Dumez.
2510
2511         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2512         (safeBrowsingView):
2513         (TEST):
2514         (-[SafeBrowsingHelper webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]): Deleted.
2515
2516 2018-12-19  Adrian Perez de Castro  <aperez@igalia.com>
2517
2518         [GTK][WPE] Unify TestController::platformRunUntil() and honor condition flag
2519         https://bugs.webkit.org/show_bug.cgi?id=192855
2520
2521         Reviewed by Michael Catanzaro.
2522
2523         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2524         (WTR::TestController::notifyDone): Use the WPE implementation.
2525         (WTR::TestController::platformRunUntil): Use the WPE implementation.
2526         * WebKitTestRunner/wpe/TestControllerWPE.cpp:
2527         (WTR::TestController::platformRunUntil): Honor the condition flag.
2528
2529 2018-12-19  Megan Gardner  <megan_gardner@apple.com>
2530
2531         Allow clients to set the navigator platform
2532         https://bugs.webkit.org/show_bug.cgi?id=192735
2533
2534         Reviewed by Tim Horton.
2535
2536         Add a test for setting a custom navigator platform.
2537
2538         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2539         (-[CustomNavigatorPlatformDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2540         (-[CustomNavigatorPlatformDelegate webView:didFinishNavigation:]):
2541
2542 2018-12-19  Truitt Savell  <tsavell@apple.com>
2543
2544         Unreviewed, rolling out r239358.
2545
2546         Revision caused imported/w3c/web-platform-tests/IndexedDB/ to
2547         crash on Debug bots
2548
2549         Reverted changeset:
2550
2551         "Clean up IndexedDB files between tests"
2552         https://bugs.webkit.org/show_bug.cgi?id=192796
2553         https://trac.webkit.org/changeset/239358
2554
2555 2018-12-18  Wenson Hsieh  <wenson_hsieh@apple.com>
2556
2557         [iOS] A copied text selection is pasted as a web archive attachment in the entry view in Messages
2558         https://bugs.webkit.org/show_bug.cgi?id=192842
2559         <rdar://problem/46823586>
2560
2561         Reviewed by Tim Horton.
2562
2563         Adjusts an existing API test to verify that "com.apple.webarchive" is not one of the types registered to the
2564         item provider when dragging a rich text selection.
2565
2566         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2567
2568 2018-12-18  David Quesada  <david_quesada@apple.com>
2569
2570         REGRESSION: [iOS] API test TestWebKitAPI._WKDownload.OriginatingWebView is a flaky failure
2571         https://bugs.webkit.org/show_bug.cgi?id=192810
2572         <rdar://problem/46812536>
2573
2574         Reviewed by Alex Christensen.
2575
2576         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2577         (-[OriginatingWebViewDownloadDelegate _downloadDidStart:]):
2578             After releasing our reference to the web view, wait until the next turn of the runloop
2579             before checking that the originatingWebView has been zeroed, since the web view might
2580             still be referenced in the autorelease pool. This _WKDownload unit test isn't about
2581             testing general memory management of WKWebViews, only that _WKDownload does not retain
2582             its web view via the 'originatingWebView' property.
2583
2584 2018-12-18  Sihui Liu  <sihui_liu@apple.com>
2585
2586         Clean up IndexedDB files between tests
2587         https://bugs.webkit.org/show_bug.cgi?id=192796
2588
2589         Reviewed by Geoffrey Garen.
2590
2591         * DumpRenderTree/mac/DumpRenderTree.mm:
2592         (runTest):
2593         * WebKitTestRunner/TestController.cpp:
2594         (WTR::TestController::resetStateToConsistentValues):
2595         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
2596         (WTR::RemoveAllIndexedDatabasesCallback):
2597         (WTR::TestController::ClearIndexedDatabases):
2598         * WebKitTestRunner/TestController.h:
2599
2600 2018-12-18  Alex Christensen  <achristensen@webkit.org>
2601
2602         Fix API test introduced in r239339 on iOS.
2603         https://bugs.webkit.org/show_bug.cgi?id=192675
2604
2605         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2606         (TEST):
2607         The iOS implementation of the safe browsing warning is a little different.
2608         It does some element creation when it is added to the window so it knows how big it is.
2609         To test these elements, we need to simulate adding it to the window.
2610         A similar technique is done in other iOS API tests, such as SafeBrowsing.ShowWarningSPI.
2611
2612 2018-12-18  Jonathan Bedard  <jbedard@apple.com>
2613
2614         webkitpy: Ignore device type for test when using --force
2615         https://bugs.webkit.org/show_bug.cgi?id=192786
2616         <rdar://problem/46794894>
2617
2618         Reviewed by Daniel Bates.
2619
2620         It is sometimes the case that a contributor will wish to run a test on a specific device,
2621         despite expectations which indicate a test should not be run on that device.
2622
2623         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2624         (parse_args):
2625         * Scripts/webkitpy/port/device_port.py:
2626         (DevicePort.default_child_processes): Strip device type information when using --force.
2627         (DevicePort.setup_test_run): Only allow incomplete match when using --force.
2628
2629 2018-12-18  Alex Christensen  <achristensen@webkit.org>
2630
2631         WKWebView has old URL while displaying SafeBrowsing interstitial, for link-click navigations
2632         https://bugs.webkit.org/show_bug.cgi?id=192675
2633
2634         Reviewed by Geoffrey Garen.
2635
2636         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2637         (goBack):
2638         (TEST):
2639         (visitUnsafeSite):
2640         (-[SafeBrowsingHelper observeValueForKeyPath:ofObject:change:context:]):
2641         (-[SafeBrowsingHelper webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2642
2643 2018-12-18  Chris Dumez  <cdumez@apple.com>
2644
2645         Regression(r239182) SuspendedPage's process reuse for link navigation optimization sometimes broken
2646         https://bugs.webkit.org/show_bug.cgi?id=192772
2647
2648         Reviewed by Antti Koivisto.
2649
2650         Add API test coverage.
2651
2652         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2653
2654 2018-12-18  Philippe Normand  <pnormand@igalia.com>
2655
2656         Unreviewed, JHBuild GTK build fix attempt
2657
2658         * gtk/jhbuild.modules: There's no libffi in this moduleset anymore.
2659         There's no ninja module either, it should be provided by the
2660         host system.
2661
2662 2018-12-17  Chris Dumez  <cdumez@apple.com>
2663
2664         Allow passing nil as session state to [WKWebView _restoreSessionState:]
2665         https://bugs.webkit.org/show_bug.cgi?id=192789
2666         <rdar://problem/46755277>
2667
2668         Reviewed by Alex Christensen.
2669
2670         Add API test coverage.
2671
2672         * TestWebKitAPI/Tests/WebKit/WKBackForwardList.mm:
2673         (TEST):
2674
2675 2018-12-17  Simon Fraser  <simon.fraser@apple.com>
2676
2677         Don't use more expensive layer backing store formats when subpixel text antialiasing is not enabled
2678         https://bugs.webkit.org/show_bug.cgi?id=192780
2679         rdar://problem/43394387
2680
2681         Reviewed by Tim Horton.
2682
2683         No need to set "AppleFontSmoothing" defaults for WK2.
2684
2685         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2686         (WTR::InjectedBundle::platformInitialize):
2687
2688 2018-12-17  Jonathan Bedard  <jbedard@apple.com>
2689
2690         webkitpy: Handle case where stdout and stderr don't accept unicode
2691         https://bugs.webkit.org/show_bug.cgi?id=192775
2692         <rdar://problem/46497303>
2693
2694         Reviewed by Stephanie Lewis.
2695
2696         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
2697         (MeteredStream.write): If unicode cannot be written to the stream, replace unicode
2698         characters with '?'.
2699         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
2700         (RegularTest.test_stream_with_encoding):
2701
2702 2018-12-17  Daniel Bates  <dabates@apple.com>
2703
2704         Support concatenating StringView with other string types
2705         https://bugs.webkit.org/show_bug.cgi?id=177566
2706
2707         Reviewed by Darin Adler.
2708
2709         Add some tests to ensure we do not regress the number of allocations needed when performing
2710         string concatenation with string views.
2711
2712         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
2713         (TestWebKitAPI::TEST):
2714
2715 2018-12-17  Commit Queue  <commit-queue@webkit.org>
2716
2717         Unreviewed, rolling out r239265 and r239274.
2718         https://bugs.webkit.org/show_bug.cgi?id=192765
2719
2720         unorm_normalize is deprecated, and broke an internal build
2721         (Requested by Truitt on #webkit).
2722
2723         Reverted changesets:
2724
2725         "[GTK][WPE] Need a function to convert internal URI to display
2726         ("pretty") URI"
2727         https://bugs.webkit.org/show_bug.cgi?id=174816
2728         https://trac.webkit.org/changeset/239265
2729
2730         "Fix the Apple Internal Mac build with a newer SDK"
2731         https://trac.webkit.org/changeset/239274
2732
2733 2018-12-17  Daniel Bates  <dabates@apple.com>
2734
2735         Implement UIScriptController::toggleCapsLock() for iOS
2736         https://bugs.webkit.org/show_bug.cgi?id=191815
2737
2738         Reviewed by Andy Estes.
2739
2740         Add support for toggling the caps lock state in WebKitTestRunner on iOS.
2741
2742         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2743         * WebKitTestRunner/TestController.cpp:
2744         (WTR::TestController::resetStateToConsistentValues): Clear the current modifier state
2745         before running a test. This ensures that the caps lock state does not persist between
2746         tests should a test enable caps lock and not disable it.
2747         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2748         (hidUsageCodeForCharacter): Map "capsLock" to the Caps Lock key usage code.
2749         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2750         (WTR::createUIPhysicalKeyboardEvent): Modified to take the keyboard input flags to use to
2751         create the event. Also substituted NSString* for const String& as the data type for the first
2752         two parameters to avoid conversions in the implementation of UIScriptController::toggleCapsLock()
2753         below.
2754         (WTR::UIScriptController::keyDown): Update as needed due to changes to prototype of createUIPhysicalKeyboardEvent().
2755         (WTR::UIScriptController::toggleCapsLock): Dispatch a UIEvent to toggle caps lock.
2756
2757 2018-12-17  Daniel Bates  <dabates@apple.com>
2758
2759         [iOS] Remove -[WebEvent initWithKeyEventType:...:characterSet:]
2760         https://bugs.webkit.org/show_bug.cgi?id=192633
2761
2762         Reviewed by Wenson Hsieh.
2763
2764         Update code to use the modern initializer.
2765
2766         * DumpRenderTree/mac/EventSendingController.mm:
2767         (-[EventSendingController keyDown:withModifiers:withLocation:]):
2768
2769 2018-12-17  Matt Lewis  <jlewis3@apple.com>
2770
2771         Unreviewed, rolling out r239254.
2772
2773         This broke the Windows 10 Debug build
2774
2775         Reverted changeset:
2776
2777         "Replace many uses of String::format with more type-safe
2778         alternatives"
2779         https://bugs.webkit.org/show_bug.cgi?id=192742
2780         https://trac.webkit.org/changeset/239254
2781
2782 2018-12-17  David Kilzer  <ddkilzer@apple.com>
2783
2784         clang-tidy: loop variable is copied but only used as const reference in WebCore, WebKit, Tools
2785         <https://webkit.org/b/192751>
2786         <rdar://problem/46771623>
2787
2788         Reviewed by Daniel Bates.
2789
2790         Change loop variables to const references to avoid unnecessary
2791         copies.
2792
2793         * DumpRenderTree/mac/DumpRenderTreePasteboard.mm:
2794         (-[LocalPasteboard pasteboardItems]):
2795
2796 2018-12-17  Ms2ger  <Ms2ger@igalia.com>
2797
2798         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
2799         https://bugs.webkit.org/show_bug.cgi?id=174816
2800
2801         Reviewed by Michael Catanzaro.
2802
2803         Add tests for userVisibleString() and (for GTK and WPE) webkit_uri_for_display().
2804
2805         * TestWebKitAPI/CMakeLists.txt:
2806         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2807         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Added.
2808         (TestWebKitAPI::TEST):
2809         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
2810         (testURIForDisplayUnaffected):
2811         (testURIForDisplayAffected):
2812         (beforeAll):
2813         (afterAll):
2814         * TestWebKitAPI/glib/CMakeLists.txt:
2815
2816 2018-12-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2817
2818         [WPE] Add API to notify about frame displayed view backend callback
2819         https://bugs.webkit.org/show_bug.cgi?id=192224
2820
2821         Reviewed by Michael Catanzaro.
2822
2823         Add a test case to check the new API.
2824
2825         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
2826         (testWebViewFrameDisplayed):
2827         (beforeAll):
2828         * wpe/jhbuild.modules: Bump WPEBackend-fdo to 1.1.0.
2829
2830 2018-12-16  Adrian Perez de Castro  <aperez@igalia.com>
2831
2832         Unreviewed build fix after r239253
2833
2834         * gtk/jhbuild.modules: Fix typo in libpsl dependency name.
2835
2836 2018-12-15  Darin Adler  <darin@apple.com>
2837
2838         Use warning-ignoring macros more consistently and simply
2839         https://bugs.webkit.org/show_bug.cgi?id=192743
2840
2841         Reviewed by Mark Lam.
2842
2843         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2844         (handleEventCarbon): Use ALLOW_DEPRECATED_DECLARATIONS_BEGIN/END.
2845         * DumpRenderTree/mac/TextInputControllerMac.m:
2846         (-[TextInputController interpretKeyEvents:withSender:]): Use
2847         IGNORE_WARNINGS_BEGIN/END.
2848         * WebKitTestRunner/mac/EventSenderProxy.mm:
2849         (WTR::EventSenderProxy::mouseForceClick): Use
2850         IGNORE_NULL_CHECK_WARNINGS_BEGIN/END.
2851         (WTR::EventSenderProxy::startAndCancelMouseForceClick): Ditto.
2852         (WTR::EventSenderProxy::mouseForceDown): Ditto.
2853         (WTR::EventSenderProxy::mouseForceUp): Ditto.
2854         (WTR::EventSenderProxy::mouseForceChanged): Ditto.
2855
2856 2018-12-15  Darin Adler  <darin@apple.com>
2857
2858         Replace many uses of String::format with more type-safe alternatives
2859         https://bugs.webkit.org/show_bug.cgi?id=192742
2860
2861         Reviewed by Mark Lam.
2862
2863         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2864         (WTR::cacheTestRunnerCallback): Use makeString.
2865         * WebKitTestRunner/TestController.cpp:
2866         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
2867         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
2868
2869 2018-12-15  Adrian Perez de Castro  <aperez@igalia.com>
2870
2871         [WPE][GTK] Add libpsl to JHBuild module sets
2872         https://bugs.webkit.org/show_bug.cgi?id=192740
2873
2874         Reviewed by Michael Catanzaro.
2875
2876         * gtk/jhbuild.modules: Add libpsl module.
2877         * wpe/jhbuild.modules: Ditto.
2878
2879 2018-12-14  Alexey Proskuryakov  <ap@apple.com>
2880
2881         Add a style checker rule for Xcode version macros use
2882         https://bugs.webkit.org/show_bug.cgi?id=192703
2883
2884         Reviewed by Alex Christensen.
2885
2886         * Scripts/webkitpy/style/checkers/cpp.py:
2887         (check_os_version_checks):
2888         (process_line):
2889         (CppChecker):
2890         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2891         (WebKitStyleTest.test_os_version_checks):
2892
2893 2018-12-14  Chris Dumez  <cdumez@apple.com>
2894
2895         [PSON] Process-swapping on a loadHTMLString causes duplicate decidePolicyForNavigationAction delegate calls
2896         https://bugs.webkit.org/show_bug.cgi?id=192704
2897
2898         Reviewed by Geoffrey Garen.
2899
2900         Extend existing API test to reproduce the problem.
2901
2902         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2903
2904 2018-12-14  Chris Dumez  <cdumez@apple.com>
2905
2906         [PSON] WebsitePolicies are lost on process-swap
2907         https://bugs.webkit.org/show_bug.cgi?id=192694
2908         <rdar://problem/46715748>
2909
2910         Reviewed by Brady Eidson.
2911
2912         Extend existing API test to reproduce the issue.
2913
2914         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2915
2916 2018-12-14  Michael Catanzaro  <mcatanzaro@igalia.com>
2917
2918         [GTK] Error writing data to TLS socket in some sites when using the jhbuild
2919         https://bugs.webkit.org/show_bug.cgi?id=192678
2920
2921         Reviewed by Carlos Garcia Campos.
2922
2923         Update our ancient versions of libsoup and glib-networking.
2924
2925         * gtk/install-dependencies:
2926         * gtk/jhbuild.modules:
2927         * gtk/patches/libsoup-auth-Fix-async-authentication-when-flag-SOUP_MESSAGE.patch: Removed.
2928         * gtk/patches/libsoup-auth-do-not-use-cached-credentials-in-lookup-method-.patch: Removed.
2929         * gtk/patches/libsoup-soup-message-io-Do-not-fail-when-there-s-no-empty-li.patch: Removed.
2930         * gtk/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch: Removed.
2931         * wpe/install-dependencies:
2932         * wpe/jhbuild.modules:
2933         * wpe/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch: Removed.
2934
2935 2018-12-14  Carlos Garcia Campos  <cgarcia@igalia.com>
2936
2937         [WPE] Use new view state API from libwpe
2938         https://bugs.webkit.org/show_bug.cgi?id=191906
2939
2940         Reviewed by Žan Doberšek.
2941
2942         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
2943         (beforeAll): Enable /webkit/WebKitWebView/page-visibility in WPE.
2944         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2945         (Test::createWebViewBackend): Make the view initially hidden for consistency with GTK+ tests.
2946         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h:
2947         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
2948         (WebViewTest::showInWindow): Add wpe_view_activity_state_visible, wpe_view_activity_state_in_window and
2949         wpe_view_activity_state_focused state flags.
2950         (WebViewTest::hideView): Remove wpe_view_activity_state_visible and wpe_view_activity_state_focused state flags.
2951         * wpe/backends/HeadlessViewBackend.cpp:
2952         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Assume view is always visible, focused and in window.
2953         * wpe/backends/WindowViewBackend.cpp:
2954         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Update the view state flags depending on state
2955         received in configure callback.
2956         * wpe/jhbuild.modules: Bump libwpe to 1.1.0
2957
2958 2018-12-13  Fujii Hironori  <Hironori.Fujii@sony.com>
2959
2960         [WinCairo][Clang] DLLLauncherMain.cpp: warning: unused function 'prependPath' and 'appleApplicationSupportDirectory'
2961         https://bugs.webkit.org/show_bug.cgi?id=192688
2962
2963         Reviewed by Ross Kirsling.
2964
2965         * win/DLLLauncher/DLLLauncherMain.cpp:
2966         (copyEnvironmentVariable): Moved.
2967         (getStringValue): Enclosed with #if !defined(WIN_CAIRO).
2968         (applePathFromRegistry): Ditto.
2969         (appleApplicationSupportDirectory): Ditto.
2970         (prependPath): Ditto.
2971
2972 2018-12-13  Don Olmstead  <don.olmstead@sony.com>
2973
2974         Unreviewed. Changed my status to a reviewer.
2975
2976         * Scripts/webkitpy/common/config/contributors.json:
2977
2978 2018-12-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2979
2980         [iOS] Support dropping contact card data (public.vcard) in editable content
2981         https://bugs.webkit.org/show_bug.cgi?id=192570
2982         <rdar://problem/35626913>
2983
2984         Reviewed by Tim Horton.
2985
2986         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2987
2988         Add API tests to verify that registering `MKMapItem`s and `CNContact`s to item providers and dropping them in
2989         attachment-enabled rich text editable areas inserts attachment elements (and in the case of `MKMapItem`,
2990         additionally inserts a link).
2991
2992         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2993         (TestWebKitAPI::createMapItemForTesting):
2994         (TestWebKitAPI::createContactItemForTesting):
2995
2996         Add API tests to verify that dropping map items and contact items into rich and plain editable areas behaves as
2997         expected (in the case where a URL is present, e.g. dropping a map item, we insert the URL as an anchor, and when
2998         there is no other suitable representation in the item provider, we do nothing at all, which is the case for the
2999         dropped `CNContact`). Also, add a test to verify that drag and drop can be used to upload these items as .vcf
3000         files.
3001
3002 2018-12-13  Ross Kirsling  <ross.kirsling@sony.com>
3003
3004         Unreviewed -- update my status to "reviewer".
3005
3006         * Scripts/webkitpy/common/config/contributors.json:
3007
3008 2018-12-13  Youenn Fablet  <youenn@apple.com>
3009
3010         On page close, WebPage::m_userMediaPermissionRequestManager is nullified too early
3011         https://bugs.webkit.org/show_bug.cgi?id=192657
3012
3013         Reviewed by Eric Carlson.
3014
3015         Add a test that loads a page registering ondevicechange,
3016         load another page in the same process, closes the first page.
3017         Ensure that the process does not crash in that case.
3018
3019         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3020         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3021         (TestWebKitAPI::TEST):
3022         (TestWebKitAPI::didCrashCallback):
3023         * TestWebKitAPI/Tests/WebKit/ondevicechange.html: Added.
3024
3025 2018-12-13  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
3026
3027         [GStreamer][JHBuild] update-webkit{gtk,wpe}-libs fails with libfdk-2.0.0
3028         https://bugs.webkit.org/show_bug.cgi?id=192643
3029
3030         Reviewed by Philippe Normand.
3031
3032         This problem happens with Arch Linux users which have libfdk-2.0.0
3033         installed (which is anybody with gst-plugins-bad 1.14.4 installed).
3034
3035         The problem has already been solved upstream at
3036         https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/merge_requests/77.
3037
3038         Adding patches while this problem is not in a release yet.
3039
3040         * gstreamer/jhbuild.modules: Add patches to fix build of gst-plugins-bad with libfdk-2.0.0.
3041         * gstreamer/patches/gst-plugins-bad-0003-fdkaacenc-Remove-MODE_2_1.patch: Added.
3042         * gstreamer/patches/gst-plugins-bad-0004-fdkaacdec-Use-WAV-channel-mapping-instead-of-interleave-setting.patch: Added.
3043
3044 2018-12-12  Carlos Garcia Campos  <cgarcia@igalia.com>
3045
3046         [FreeType] Add initial implementation of variation fonts
3047         https://bugs.webkit.org/show_bug.cgi?id=192151
3048
3049         Reviewed by Michael Catanzaro.
3050
3051         Add cairo patch to avoid crashes.
3052
3053         * gtk/jhbuild.modules:
3054         * gtk/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
3055
3056 2018-12-12  Fujii Hironori  <Hironori.Fujii@sony.com>
3057
3058         [Win][Clang][WebKitLegacy] WebFrame.cpp: warning: delete called on non-final 'WebFrame' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
3059         https://bugs.webkit.org/show_bug.cgi?id=192618
3060
3061         Reviewed by Alex Christensen.
3062
3063         * DumpRenderTree/win/DRTDataObject.cpp:
3064         * DumpRenderTree/win/DRTDataObject.h:
3065         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
3066         * DumpRenderTree/win/DRTDropSource.h:
3067         * DumpRenderTree/win/EditingDelegate.h:
3068         * DumpRenderTree/win/PolicyDelegate.h:
3069         * DumpRenderTree/win/UIDelegate.h:
3070
3071 2018-12-12  Ryosuke Niwa  <rniwa@webkit.org>
3072
3073         Make TextInputController.legacyAttributedString take DOM nodes and offsets
3074         https://bugs.webkit.org/show_bug.cgi?id=192653
3075
3076         Reviewed by Wenson Hsieh.
3077
3078         Updated TextInputController.legacyAttributedString to take DOM nodes and offsets instead of
3079         a DOM Range object in preparation to add layout tests for HTMLConverter which crosses
3080         shadow boundaries.
3081
3082         * DumpRenderTree/mac/TextInputControllerMac.m:
3083         (+[TextInputController isSelectorExcludedFromWebScript:]): Updated the selector signature.
3084         (+[TextInputController webScriptNameForSelector:]): Ditto.
3085         (-[TextInputController legacyAttributedString:offset:to:offset:]): Made this function take
3086         start node and offset then end node and offset pairs.
3087
3088 2018-12-12  Alex Christensen  <achristensen@webkit.org>
3089
3090         Implement safe browsing in WebKit on WatchOS
3091         https://bugs.webkit.org/show_bug.cgi?id=192641
3092         <rdar://problem/46376188>
3093
3094         Reviewed by Geoff Garen.
3095
3096         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3097         (-[SafeBrowsingNavigationDelegate _webViewDidShowSafeBrowsingWarning:]):
3098         (safeBrowsingView):
3099         Add a test that the new delegate callback is called.
3100
3101 2018-12-12  Michael Catanzaro  <mcatanzaro@igalia.com>
3102
3103         Unreviewed manual rollout of r239100-r239102 and r239116
3104         https://bugs.webkit.org/show_bug.cgi?id=192151
3105         <rdar://problem/46655586>
3106
3107         * gtk/jhbuild.modules:
3108         * gtk/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Removed.
3109
3110 2018-12-12  Commit Queue  <commit-queue@webkit.org>
3111
3112         Unreviewed, rolling out r239103.
3113         https://bugs.webkit.org/show_bug.cgi?id=192627
3114
3115         It broke the built because it depends on another patch that
3116         didn't land yet (Requested by KaL on #webkit).
3117
3118         Reverted changeset:
3119
3120         "[WPE] Add API to notify about frame displayed view backend
3121         callback"
3122         https://bugs.webkit.org/show_bug.cgi?id=192224
3123         https://trac.webkit.org/changeset/239103
3124
3125 2018-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
3126
3127         [WPE] Add API to notify about frame displayed view backend callback
3128         https://bugs.webkit.org/show_bug.cgi?id=192224
3129
3130         Reviewed by Michael Catanzaro.
3131
3132         Add a test case to check the new API.
3133
3134         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3135         (testWebViewFrameDisplayed):
3136         (beforeAll):
3137
3138 2018-12-12  Carlos Garcia Campos  <cgarcia@igalia.com>
3139
3140         [FreeType] Add initial implementation of variation fonts
3141         https://bugs.webkit.org/show_bug.cgi?id=192151
3142
3143         Reviewed by Michael Catanzaro.
3144
3145         Add cairo patch to avoid crashes.
3146
3147         * gtk/jhbuild.modules:
3148         * gtk/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
3149
3150 2018-12-11  Justin Michaud  <justin_michaud@apple.com>
3151
3152         Implement feature flag for CSS Typed OM
3153         https://bugs.webkit.org/show_bug.cgi?id=192610
3154
3155         Reviewed by Ryosuke Niwa.
3156
3157         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3158
3159 2018-12-11  Chris Dumez  <cdumez@apple.com>
3160
3161         Unreviewed, fix bad check in API test added in r239080.
3162
3163         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3164
3165 2018-12-11  Fujii Hironori  <Hironori.Fujii@sony.com>
3166
3167         [Win][Clang] Fix warning -Wmissing-field-initializers
3168         https://bugs.webkit.org/show_bug.cgi?id=192584
3169
3170         Reviewed by Yusuke Suzuki.
3171
3172         Initialize a struct with '{ }' instead of '= {0}'.
3173
3174         * DumpRenderTree/win/DumpRenderTree.cpp:
3175         (runTest):
3176         * DumpRenderTree/win/EventSender.cpp:
3177         (makeMsg):
3178         (replaySavedEvents):
3179         (beginDragWithFilesCallback):
3180         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
3181         (createBitmapContextFromWebView):
3182         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
3183         (updateMenuItemForHistoryItem):
3184         * MiniBrowser/win/WinMain.cpp:
3185         (wWinMain):
3186         * TestWebKitAPI/win/HostWindow.cpp:
3187         (TestWebKitAPI::HostWindow::clientRect const):
3188         (TestWebKitAPI::HostWindow::registerWindowClass):
3189         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
3190         (TestWebKitAPI::PlatformWebView::registerWindowClass):
3191         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3192         (WTR::registerWindowClass):
3193         (WTR::PlatformWebView::windowFrame):
3194         (WTR::PlatformWebView::windowSnapshotImage):
3195
3196 2018-12-11  Chris Dumez  <cdumez@apple.com>
3197
3198         PSON logic gets confused by concurrent decidePolicyForNavigationAction requests
3199         https://bugs.webkit.org/show_bug.cgi?id=192482
3200         <rdar://problem/46470145>
3201
3202         Reviewed by Antti Koivisto.
3203
3204         Add API test coverage.
3205
3206         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3207
3208 2018-12-11  Andy Estes  <aestes@apple.com>
3209
3210         Introduce makeBlockPtr for lambdas
3211         https://bugs.webkit.org/show_bug.cgi?id=192594
3212
3213         Reviewed by Alex Christensen.
3214
3215         Adopted makeBlockPtr and added API tests.
3216
3217         * DumpRenderTree/TestRunner.cpp:
3218         (TestRunner::callUIScriptCallback):
3219         * TestWebKitAPI/Tests/WTF/BlockPtr.mm:
3220         (TestWebKitAPI::TEST):
3221         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
3222         (-[DownloadProgressTestRunner init]):
3223         (-[DownloadProgressTestRunner subscribeAndWaitForProgress]):
3224
3225 2018-12-11  Chris Dumez  <cdumez@apple.com>
3226
3227         REGRESSION (r238764-238783): TestWTF.WTF.StringOperators is failing
3228         https://bugs.webkit.org/show_bug.cgi?id=192361
3229         <rdar://problem/46524903>
3230
3231         Reviewed by Alex Christensen.
3232
3233         Compile StringOperators.cpp with -O1 optimization level instead of -Os. This
3234         fixes the failures for me locally.
3235
3236         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3237
3238 2018-12-11  Philippe Normand  <pnormand@igalia.com>
3239
3240         Unreviewed, WPE build fix after r239028
3241
3242         The FLATPAK_USER_DIR env var is not set early enough, leading to:
3243
3244         Traceback (most recent call last):
3245         File "/home/phil/WebKit/Tools/Scripts/webkit-flatpak", line 28, in <module>
3246           sys.exit(WebkitFlatpak.load_from_args().run())
3247         File "/home/phil/WebKit/Tools/flatpak/flatpakutils.py", line 761, in run
3248           if not self.clean_args():
3249         File "/home/phil/WebKit/Tools/flatpak/flatpakutils.py", line 574, in clean_args
3250           _log.debug("Using flatpak user dir: %s" % os.environ["FLATPAK_USER_DIR"])
3251         File "/usr/lib/python2.7/UserDict.py", line 40, in __getitem__
3252           raise KeyError(key)
3253         KeyError: 'FLATPAK_USER_DIR'
3254
3255         * flatpak/flatpakutils.py:
3256         (WebkitFlatpak.clean_args):
3257
3258 2018-12-10  Don Olmstead  <don.olmstead@sony.com>
3259
3260         Move ENABLE_RESOURCE_LOAD_STATISTICS to FeatureDefines.xcconfig
3261         https://bugs.webkit.org/show_bug.cgi?id=192573
3262
3263         Reviewed by Simon Fraser.
3264
3265         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3266
3267 2018-12-10  Don Olmstead  <don.olmstead@sony.com>
3268
3269         [CMake] Add ENABLE_RESOURCE_LOAD_STATISTICS to WebKitFeatures.cmake
3270         https://bugs.webkit.org/show_bug.cgi?id=192574
3271
3272         Reviewed by Michael Catanzaro.
3273
3274         * Scripts/webkitperl/FeatureList.pm:
3275
3276 2018-12-10  Don Olmstead  <don.olmstead@sony.com>
3277
3278         Sync FeatureList.pm
3279         https://bugs.webkit.org/show_bug.cgi?id=192565
3280
3281         Reviewed by Michael Catanzaro.
3282
3283         * Scripts/webkitperl/FeatureList.pm:
3284
3285 2018-12-10  Wenson Hsieh  <wenson_hsieh@apple.com>
3286
3287         [iOS] Unable to upload data that conforms to "public.item" but not "public.content"
3288         https://bugs.webkit.org/show_bug.cgi?id=192555
3289         <rdar://problem/35204990>
3290
3291         Reviewed by Tim Horton.
3292
3293         Add a test to verify that `.p12` files may be uploaded as files via drag and drop. "com.rsa.pkcs-12" is an
3294         example of a data type that conforms to "public.item", but not "public.content"; before this patch, we would
3295         only support uploading "public.content", so files such as these would not be accepted when dropping into file
3296         inputs, or be exposed as files on DataTransfer.
3297
3298         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3299         (TestWebKitAPI::TEST):
3300
3301 2018-12-10  David Kilzer  <ddkilzer@apple.com>
3302
3303         Injected bundle for WebKitTestRunner leaks WKTypeRef objects
3304         <https://webkit.org/b/192481>
3305         <rdar://problem/46539059>
3306
3307         Follow-up to address Darin's feedback.
3308
3309         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3310         (WTR::TestRunner::shouldDumpPixels const):
3311         (WTR::TestRunner::whatToDump const):
3312         (WTR::TestRunner::shouldWaitUntilDone const):
3313         (WTR::TestRunner::shouldDumpFrameLoadCallbacks):
3314         (WTR::TestRunner::didReceiveServerRedirectForProvisionalNavigation const):
3315         (WTR::TestRunner::secureEventInputIsEnabled const):
3316         (WTR::TestRunner::isStatisticsPrevalentResource):
3317         (WTR::TestRunner::isStatisticsVeryPrevalentResource):
3318         (WTR::TestRunner::isStatisticsRegisteredAsSubresourceUnder):
3319         (WTR::TestRunner::isStatisticsRegisteredAsSubFrameUnder):
3320         (WTR::TestRunner::isStatisticsRegisteredAsRedirectingTo):
3321         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
3322         (WTR::TestRunner::isStatisticsGrandfathered):
3323         (WTR::TestRunner::hasDOMCache):
3324         (WTR::TestRunner::keyExistsInKeychain):
3325
3326 2018-12-10  Jonathan Bedard  <jbedard@apple.com>
3327
3328         webkitpy: Ref tests don't respect platform specific expectations
3329         https://bugs.webkit.org/show_bug.cgi?id=192515
3330         <rdar://problem/46564839>
3331
3332         Reviewed by Lucas Forschler.
3333
3334         * Scripts/webkitpy/port/base.py:
3335         (Port._expected_baselines_for_suffixes): Accept multiple suffixes so ref tests can use this function.
3336         (Port.expected_baselines): Move implementation to _expected_baselines_for_suffixes.
3337         (Port.expected_filename): Remove irrelevant FIXME, code clean-up.
3338         (Port.reference_files): Instead of just searching a single directory, use _expected_baselines_for_suffixes to
3339         search all platform expectations as well.
3340         * Scripts/webkitpy/port/base_unittest.py:
3341         (test_ref_tests_platform_directory):
3342
3343 2018-12-10  Chris Dumez  <cdumez@apple.com>
3344
3345         Add SPI to allow the client to set the user-agent at main frame level, from the UIProcess
3346         https://bugs.webkit.org/show_bug.cgi?id=192509
3347         <rdar://problem/46500832>
3348
3349         Reviewed by Alex Christensen.
3350
3351         Add API test coverage.
3352
3353         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3354         (-[DataMappingSchemeHandler addMappingFromURLString:toData:]):
3355         (-[DataMappingSchemeHandler webView:startURLSchemeTask:]):
3356         (-[DataMappingSchemeHandler webView:stopURLSchemeTask:]):
3357         (-[CustomUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3358         (-[CustomUserAgentDelegate webView:didFinishNavigation:]):
3359
3360 2018-12-10  Wenson Hsieh  <wenson_hsieh@apple.com>
3361
3362         [iOS] Caret is obscured by finger when dragging over an editable element
3363         https://bugs.webkit.org/show_bug.cgi?id=192499
3364         <rdar://problem/46570101>
3365
3366         Reviewed by Tim Horton.
3367
3368         Augment some existing API tests to check that the `precise` flag is either on or off on `UIDropProposal`.
3369
3370         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3371         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
3372         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
3373         (-[DragAndDropSimulator _resetSimulatedState]):
3374         (-[DragAndDropSimulator lastKnownDropProposal]):
3375
3376         Rename `currentDropProposal` to `lastKnownDropProposal`, and expose it as a readonly property.
3377
3378         (-[DragAndDropSimulator _concludeDropAndPerformOperationIfNecessary]):
3379         (-[DragAndDropSimulator _advanceProgress]):
3380         (-[DragAndDropSimulator setShowCustomActionSheetBlock:]):
3381         (-[DragAndDropSimulator showCustomActionSheetBlock]):
3382         (-[DragAndDropSimulator setConvertItemProvidersBlock:]):
3383         (-[DragAndDropSimulator convertItemProvidersBlock]):
3384         (-[DragAndDropSimulator setOverridePerformDropBlock:]):
3385         (-[DragAndDropSimulator overridePerformDropBlock]):
3386         (-[DragAndDropSimulator setOverrideDragUpdateBlock:]):
3387         (-[DragAndDropSimulator overrideDragUpdateBlock]):
3388         (-[DragAndDropSimulator setDropCompletionBlock:]):
3389         (-[DragAndDropSimulator dropCompletionBlock]):
3390
3391         Refactor these properties to return and take normal Objective-C blocks, rather than `BlockPtr`s. However, use
3392         `BlockPtr` instance variables to manage the lifetimes of these blocks.
3393
3394         (-[DragAndDropSimulator _webView:willUpdateDropProposalToProposal:forSession:]):
3395         (-[DragAndDropSimulator _webView:willUpdateDataInteractionOperationToOperation:forSession:]): Deleted.
3396
3397         Update this to use the new WebKit delegate hook for overriding the drop proposal.
3398
3399 2018-12-10  Michael Catanzaro  <mcatanzaro@igalia.com>
3400
3401         [WPE][GTK] run-minibrowser improperly creates webkit-flatpak environment
3402         https://bugs.webkit.org/show_bug.cgi?id=190241
3403
3404         Reviewed by Carlos Garcia Campos.
3405
3406         run-minibrowser calls into webkit-flatpak to check if a flatpak environment is available.
3407         Currently this actually creates the directories needed for the flatpak environment. Fix it.
3408
3409         * flatpak/flatpakutils.py:
3410         (WebkitFlatpak.clean_args):
3411         (WebkitFlatpak.run):
3412
3413 2018-12-10  Michael Catanzaro  <mcatanzaro@igalia.com>
3414
3415         [GTK] Don't use the slice allocator
3416         https://bugs.webkit.org/show_bug.cgi?id=192360
3417
3418         Reviewed by Carlos Garcia Campos.
3419
3420         * MiniBrowser/gtk/main.c:
3421         (aboutDataRequestFree):
3422         (aboutDataRequestNew):
3423
3424 2018-12-10  Tim Horton  <timothy_horton@apple.com>
3425
3426         WKWebView should support custom tintColor
3427         https://bugs.webkit.org/show_bug.cgi?id=192518
3428         <rdar://problem/37243261>
3429
3430         Reviewed by Wenson Hsieh.
3431
3432         * TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm:
3433         (TestWebKitAPI::TEST):
3434         Add a test that tintColor affects UITextInputTraits' interaction colors.
3435
3436 2018-12-09  Wenson Hsieh  <wenson_hsieh@apple.com>
3437
3438         [iOS] DragAndDropTests.RespectsExternalSourceFidelityRankings is flaky
3439         https://bugs.webkit.org/show_bug.cgi?id=192524
3440
3441         Reviewed by Ryosuke Niwa.
3442
3443         This test started failing on certain builds of iOS where UIKit now attempts to reveal the selection by scrolling
3444         (see <rdar://problem/28300343>). This API test simulates two drops from external sources, both from the point
3445         (300, 400) to (100, 300) in window coordinates. On these aforementioned builds of iOS, what happens is that the
3446         first drop inserts text that overflows the editable region by an enormous amount, which creates an extremely
3447         wide selection rect and increases the width of the document; revealing this selection causes the web view to
3448         scroll horizontally, such that the second attempt to simulate a drag from (300, 400) to (100, 300) fails, since
3449         these window coordinates no longer correspond to the drop destination element in the document.
3450
3451         To fix this test, we simply mark the drop destination as `overflow: hidden` to ensure that we don't try and
3452         scroll horizontally after the first drop.
3453
3454         * TestWebKitAPI/Tests/WebKitCocoa/autofocus-contenteditable.html:
3455
3456 2018-12-08  Daniel Bates  <dabates@apple.com>
3457
3458         Fix lldb_webkit.py following r238771
3459         (https://bugs.webkit.org/show_bug.cgi?id=190234)
3460
3461         Substitute WTFURLProvider for WebCoreURLProvider in one call site that was inadvertently
3462         missed in r238771.
3463
3464         * lldb/lldb_webkit.py:
3465         (WebCoreDocumentProvider.url):
3466
3467 2018-12-07  Aakash Jain  <aakash_jain@apple.com>
3468
3469         [ews-build] check-patch-relevance failure should not mark the overall build as failure
3470         https://bugs.webkit.org/show_bug.cgi?id=192510
3471
3472         Reviewed by Lucas Forschler.
3473
3474         * BuildSlaveSupport/ews-build/steps.py:
3475         (CheckPatchRelevance.start):
3476
3477 2018-12-07  Chris Dumez  <cdumez@apple.com>
3478
3479         ProcessSwap.UseSessionCookiesAfterProcessSwapInPrivateBrowsing API test is failing
3480         https://bugs.webkit.org/show_bug.cgi?id=192362
3481         <rdar://problem/46460360>
3482
3483         Reviewed by Ryosuke Niwa.
3484
3485         Move the call to _setCookieAcceptPolicy *after* we've constructed a WKWebView and thus
3486         *after* we know for sure we have a network process to communicate the policy to.
3487         This should address the failures on iOS.
3488
3489         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3490
3491 2018-12-07  Jiewen Tan  <jiewen_tan@apple.com>
3492
3493         Add keychain access entitlement to WebKitTestRunnerApp
3494         https://bugs.webkit.org/show_bug.cgi?id=192489
3495         <rdar://problem/45057952>
3496
3497         Reviewed by Alexey Proskuryakov.
3498
3499         * WebKitTestRunner/Configurations/WebKitTestRunnerApp-iOS.entitlements:
3500
3501 2018-12-07  Saam Barati  <sbarati@apple.com>
3502
3503         WKWebProcessPlugInLoadDelegate should have API for saying which rendering events it wants to listen for
3504         https://bugs.webkit.org/show_bug.cgi?id=192473
3505
3506         Reviewed by Andy Estes.
3507
3508         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3509         * TestWebKitAPI/Tests/WebKitCocoa/RenderingProgress.mm: Added.
3510         (-[DidFirstMeaningfulPaintRemoteObject didFirstMeaningfulPaint]):
3511         (TEST):
3512         * TestWebKitAPI/Tests/WebKitCocoa/RenderingProgressPlugIn.mm: Added.
3513         (-[RenderingProgressPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
3514         (-[RenderingProgressPlugIn webProcessPlugInBrowserContextControllerRenderingProgressEvents:]):
3515         (-[RenderingProgressPlugIn webProcessPlugInBrowserContextController:renderingProgressDidChange:]):
3516         * TestWebKitAPI/Tests/WebKitCocoa/RenderingProgressProtocol.h: Added.
3517
3518 2018-12-07  Jonathan Bedard  <jbedard@apple.com>
3519
3520         REGRESSION: run-webkit-tests may fail when using booted simulators (Follow-up fix)
3521         https://bugs.webkit.org/show_bug.cgi?id=192470
3522         <rdar://problem/46532001>
3523
3524         Unreviewed infrastructure fix.
3525
3526         * Scripts/webkitpy/port/device_port.py:
3527         (DevicePort.setup_test_run): Check that the number of initialized devices matches the
3528         number of child processes.
3529
3530 2018-12-07  Aakash Jain  <aakash_jain@apple.com>
3531
3532         [ews-app] Send bug id as a build property
3533         https://bugs.webkit.org/show_bug.cgi?id=192494
3534
3535         Reviewed by Lucas Forschler.
3536
3537         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3538         (BugzillaPatchFetcher.fetch):
3539
3540 2018-12-07  Aakash Jain  <aakash_jain@apple.com>
3541
3542         [ews-build] Builds should have a link to patch and bug
3543         https://bugs.webkit.org/show_bug.cgi?id=192492
3544
3545         Reviewed by Lucas Forschler.
3546
3547         * BuildSlaveSupport/ews-build/steps.py:
3548         (ConfigureBuild.add_patch_id_url): Method to add Patch URL.
3549         (ConfigureBuild.add_bug_id_url): Method to add Bug URL.
3550         (ConfigureBuild.getPatchURL): Method to get Patch URL.
3551         (ConfigureBuild.getBugURL): Method to get Bug URL.
3552
3553 2018-12-07  Aakash Jain  <aakash_jain@apple.com>
3554
3555         [ews-app] Configure logfile for ews-app logs
3556         https://bugs.webkit.org/show_bug.cgi?id=192493
3557
3558         Reviewed by Lucas Forschler.
3559
3560         * BuildSlaveSupport/ews-app/ews/__init__.py:
3561
3562 2018-12-07  Aakash Jain  <aakash_jain@apple.com>
3563
3564         Style queue exception on some security bugs
3565         https://bugs.webkit.org/show_bug.cgi?id=190793
3566
3567         Reviewed by Lucas Forschler.
3568
3569         * Scripts/webkitpy/tool/steps/applywatchlist.py:
3570         (ApplyWatchList.run):
3571
3572 2018-12-07  Wenson Hsieh  <wenson_hsieh@apple.com>
3573
3574         [Attachment Support] Cloned attachment elements lose their unique identifiers
3575         https://bugs.webkit.org/show_bug.cgi?id=192483
3576
3577         Reviewed by Tim Horton.
3578
3579         Introduce a new API test.
3580
3581         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3582         (TestWebKitAPI::TEST):
3583
3584 2018-12-06  Jonathan Bedard  <jbedard@apple.com>
3585
3586         Consecutive DumpRenderTree crashes are happening again on WinCairo BuildBots since r238903
3587         https://bugs.webkit.org/show_bug.cgi?id=192486
3588
3589         Unreviewed infrastructure fix.
3590
3591         WinCairo bots define WEBKIT_TEST_CHILD_PROCESSES to run less processes due to RAM restrictions.
3592
3593         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3594         (_set_up_derived_options):
3595
3596 2018-12-06  David Kilzer  <ddkilzer@apple.com>
3597
3598         Injected bundle for WebKitTestRunner leaks WKTypeRef objects
3599         <https://webkit.org/b/192481>
3600         <rdar://problem/46539059>
3601
3602         Reviewed by Simon Fraser.
3603
3604         This patch:
3605         - Fixes leaks in various injected bundle methods that return +1
3606           retained WKTypeRef objects via pointer.
3607         - Asserts the returned object is the expected WKTypeRef.
3608         - Replaces 0 with nullptr in many places.
3609
3610         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3611         (WTR::InjectedBundle::didCreatePage):
3612         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3613         (WTR::TestRunner::shouldDumpPixels const):
3614         (WTR::TestRunner::whatToDump const):
3615         (WTR::TestRunner::shouldWaitUntilDone const):
3616         (WTR::TestRunner::shouldDumpFrameLoadCallbacks):
3617         (WTR::TestRunner::didReceiveServerRedirectForProvisionalNavigation const):
3618         (WTR::TestRunner::clearDidReceiveServerRedirectForProvisionalNavigation):
3619         (WTR::TestRunner::secureEventInputIsEnabled const):
3620         (WTR::TestRunner::isStatisticsPrevalentResource):
3621         (WTR::TestRunner::isStatisticsVeryPrevalentResource):
3622         (WTR::TestRunner::isStatisticsRegisteredAsSubresourceUnder):
3623         (WTR::TestRunner::isStatisticsRegisteredAsSubFrameUnder):
3624         (WTR::TestRunner::isStatisticsRegisteredAsRedirectingTo):
3625         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
3626         (WTR::TestRunner::isStatisticsGrandfathered):
3627         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
3628         (WTR::TestRunner::statisticsUpdateCookieBlocking):
3629         (WTR::TestRunner::statisticsSubmitTelemetry):
3630         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
3631         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
3632         (WTR::TestRunner::statisticsResetToConsistentState):
3633         (WTR::TestRunner::getAllStorageAccessEntries):
3634         (WTR::TestRunner::hasDOMCache):
3635         (WTR::TestRunner::domCacheSize):
3636         (WTR::TestRunner::injectUserScript):
3637         (WTR::TestRunner::keyExistsInKeychain):
3638
3639 2018-12-06  Jonathan Bedard  <jbedard@apple.com>
3640
3641         REGRESSION: run-webkit-tests may fail when using booted simulators
3642         https://bugs.webkit.org/show_bug.cgi?id=192470
3643         <rdar://problem/46532001>
3644
3645         Reviewed by Lucas Forschler.
3646
3647         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3648         (Manager.run): Logging uses the number of child processes to print out information about how efficiently tests
3649         were sharded after the fact. This number is the most meaningful if it is the maximum number of child processes used.
3650         * Scripts/webkitpy/port/base.py:
3651         (Port.max_child_processes): By default, Ports do not support running on any specific kind of device.
3652         * Scripts/webkitpy/port/device_port.py:
3653         (DevicePort.default_child_processes): Rather than using the currently initialized devices as a proxy for how many
3654         child processes are being used, check the device manager every time. Regardless of which devices are attached or
3655         available, iOS cannot boot watchOS devices and vice-versa. dedicated_simulators is not a known argument to
3656         device_count_for_type, use use_booted_simulator instead.
3657         (DevicePort.max_child_processes): Simulators can boot more devices than what is specified by device_count_for_type,
3658         but, if no devices are available, then max_child_processes should return 0 even for simulators.
3659         * Scripts/webkitpy/port/ios_device_unittest.py:
3660         (IOSDeviceTest):
3661         (IOSDeviceTest.test_max_child_processes):
3662         * Scripts/webkitpy/port/ios_simulator_unittest.py:
3663         (IOSSimulatorTest):
3664         (IOSSimulatorTest.test_max_child_processes):
3665         * Scripts/webkitpy/port/port_testcase.py:
3666         (PortTestCase):
3667         (PortTestCase.test_max_child_processes):
3668         * Scripts/webkitpy/port/watch_simulator_unittest.py:
3669         (WatchSimulatorTest):
3670         (WatchSimulatorTest.test_max_child_processes):
3671
3672 2018-12-06  Jonathan Bedard  <jbedard@apple.com>
3673
3674         webkitpy: Ignore case when comparing device types (Follow-up fix)
3675         https://bugs.webkit.org/show_bug.cgi?id=192409
3676         <rdar://problem/46491558>
3677
3678         Unreviewed typo fix.
3679
3680         * Scripts/webkitpy/xcode/device_type_unittest.py:
3681         (DeviceTypeTest.test_comparison_lower_case):
3682         (DeviceTypeTest.test_comparsion_lower_case): Deleted.
3683
3684 2018-12-06  Jonathan Bedard  <jbedard@apple.com>
3685
3686         webkitpy: Create device given lower-case DeviceType
3687         <https://bugs.webkit.org/show_bug.cgi?id=192472>
3688         <rdar://problem/46532650>
3689
3690         Reviewed by Lucas Forschler.
3691
3692         * Scripts/webkitpy/xcode/simulated_device.py:
3693         (SimulatedDeviceManager._get_device_identifier_for_type): Comparing simctl device identifiers with DeviceTypes
3694         should be letter-case agnostic.
3695         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
3696         (test_lower_case_device_type):
3697
3698 2018-12-06  Wenson Hsieh  <wenson_hsieh@apple.com>
3699
3700         [iOS] WKWebView should match UITextView behavior when editing text with an RTL keyboard
3701         https://bugs.webkit.org/show_bug.cgi?id=187554
3702         <rdar://problem/42075638>
3703
3704         Reviewed by Tim Horton.
3705
3706         Add support for simulating the keyboard input mode in layout tests using UIScriptController, as well as a new
3707         `TestOption` to make the web view editable.
3708
3709         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3710         (WTR::UIScriptController::setKeyboardInputModeIdentifier):
3711         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3712         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3713         (WTR::UIScriptController::setKeyboardInputModeIdentifier):
3714         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3715         * WebKitTestRunner/PlatformWebView.h:
3716         * WebKitTestRunner/TestController.cpp:
3717         (WTR::updateTestOptionsFromTestHeader):
3718         * WebKitTestRunner/TestController.h:
3719         (WTR::TestController::overriddenKeyboardInputMode const):
3720         * WebKitTestRunner/TestOptions.h:
3721         (WTR::TestOptions::hasSameInitializationOptions const):
3722         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3723         (WTR::TestController::platformCreateWebView):
3724         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3725         (WTR::PlatformWebView::setEditable):
3726         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3727         (WTR::PlatformWebView::setEditable):
3728         * WebKitTestRunner/ios/TestControllerIOS.mm:
3729         (WTR::TestController::platformResetStateToConsistentValues):
3730         (WTR::swizzleCurrentInputMode):
3731         (WTR::TestController::setKeyboardInputModeIdentifier):
3732
3733         Swizzle out several `UIKeyboardInputModeController` methods in order to convince UIKit that the user has
3734         selected a `UIKeyboardInputMode` corresponding to the given identifier. The call to
3735         `-prepareKeyboardInputModeFromPreferences:` is also necessary on iOS 12 in order to update cached writing
3736         direction state in UIKit.
3737
3738         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3739         (WTR::UIScriptController::setKeyboardInputModeIdentifier):
3740         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3741         (WTR::PlatformWebView::setEditable):
3742         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3743         (WTR::PlatformWebView::setEditable):
3744         * WebKitTestRunner/wpe/PlatformWebViewWPE.cpp:
3745         (WTR::PlatformWebView::setEditable):
3746
3747 2018-12-05  Wenson Hsieh  <wenson_hsieh@apple.com>
3748
3749         [Cocoa] Share ClassMethodSwizzler and InstanceMethodSwizzler between TestWebKitAPI and WebKitTestRunner
3750         https://bugs.webkit.org/show_bug.cgi?id=192437
3751
3752         Reviewed by Tim Horton.
3753
3754         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3755         * TestRunnerShared/cocoa/ClassMethodSwizzler.h: Renamed from Tools/TestWebKitAPI/ClassMethodSwizzler.h.
3756         * TestRunnerShared/cocoa/ClassMethodSwizzler.mm: Renamed from Tools/TestWebKitAPI/ClassMethodSwizzler.mm.
3757         (ClassMethodSwizzler::ClassMethodSwizzler):
3758         (ClassMethodSwizzler::~ClassMethodSwizzler):
3759         * TestRunnerShared/cocoa/InstanceMethodSwizzler.h: Renamed from Tools/TestWebKitAPI/cocoa/InstanceMethodSwizzler.h.
3760         * TestRunnerShared/cocoa/InstanceMethodSwizzler.mm: Renamed from Tools/TestWebKitAPI/cocoa/InstanceMethodSwizzler.mm.
3761         (InstanceMethodSwizzler::InstanceMethodSwizzler):
3762         (InstanceMethodSwizzler::~InstanceMethodSwizzler):
3763
3764         Move these swizzling helper classes into TestRunnerShared.
3765
3766         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3767         * TestWebKitAPI/Tests/WebKitCocoa/LocalStorageClear.mm:
3768         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3769         (safeBrowsingView):
3770         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDefaultNavigationDelegate.mm:
3771         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3772         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
3773
3774         Remove namespacing around ClassMethodSwizzler and InstanceMethodSwizzler in a few API tests.
3775
3776         * TestWebKitAPI/mac/TestFontOptions.mm:
3777         * WebKitTestRunner/TestController.h:
3778         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3779         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3780         (WTR::ClassMethodSwizzler::ClassMethodSwizzler): Deleted.
3781         (WTR::ClassMethodSwizzler::~ClassMethodSwizzler): Deleted.
3782
3783         Remove this duplicate implementation of ClassMethodSwizzler in WebKitTestRunner.
3784
3785 2018-12-05  Jonathan Bedard  <jbedard@apple.com>
3786
3787         webkitpy: Clean-up apple_additions
3788         https://bugs.webkit.org/show_bug.cgi?id=192413
3789         <rdar://problem/46493491>
3790
3791         Reviewed by Lucas Forschler.
3792
3793         After the addition of watchOS, some functions which were originally iOS specific were
3794         generalized to include all devices.
3795
3796         * Scripts/webkitpy/port/ios_device.py:
3797         (IOSDevicePort._driver_class): Replace iOS specific call with generalized device call.
3798         (IOSDevicePort.path_to_crash_logs): Ditto.
3799         (IOSDevicePort.clean_up_test_run): Ditto.
3800
3801 2018-12-05  Jonathan Bedard  <jbedard@apple.com>
3802
3803         webkitpy: Ignore case when comparing device types
3804         https://bugs.webkit.org/show_bug.cgi?id=192409
3805         <rdar://problem/46491558>
3806
3807         Reviewed by Lucas Forschler.
3808
3809         This allows DeviceTypes constructed with lowercase strings to correctly compare
3810         against DeviceTypes coming from the simulator runtime.
3811
3812         * Scripts/webkitpy/xcode/device_type.py:
3813         (DeviceType.__eq__):
3814         (DeviceType.__contains__):
3815         * Scripts/webkitpy/xcode/device_type_unittest.py:
3816         (DeviceTypeTest):
3817         (DeviceTypeTest.test_comparsion_lower_case):
3818
3819 2018-12-05  Jonathan Bedard  <jbedard@apple.com>
3820
3821         webkitpy: Sort tests by associated device type
3822         https://bugs.webkit.org/show_bug.cgi?id=192161
3823         <rdar://problem/46345392>
3824
3825         Reviewed by Lucas Forschler.
3826
3827         Sort tests by device type and make an effort to run each specified device type.
3828         Do not run tests if their specified device is not available.
3829
3830         * Scripts/webkitpy/common/system/platforminfo.py:
3831         (PlatformInfo.is_watchos): Add watchos bits to platform info.
3832         (PlatformInfo._determine_os_name): Ditto.
3833         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3834         (Manager.run): Assign each test a device type. Then, generate a list of
3835         device types to sequentially iterate through. Note that a test will run
3836         on the first device which matches.
3837         (Manager._end_test_run): Handle the case where no devices are available and no
3838         tests are run.
3839         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3840         (_set_up_derived_options): Manage child processes in manager.
3841         * Scripts/webkitpy/port/base.py:
3842         (Port):
3843         (Port.default_child_processes): Accept additional arguments.
3844         (Port.max_child_processes): Add upper limit for number of child processes.
3845         * Scripts/webkitpy/port/device_port.py:
3846         (DevicePort):
3847         (DevicePort._device_type_with_version): Adds version to the DeviceType.
3848         (DevicePort.default_child_processes): Allows default_child_processes to be
3849         attached to a device type.
3850         (DevicePort.max_child_processes): Add upper limit to the maximum number of child processes.
3851         (DevicePort.setup_test_run): Use _device_type_with_version.
3852         * Scripts/webkitpy/port/ios_device.py:
3853         (IOSDevicePort):
3854         (IOSDevicePort.default_child_processes): Deleted.
3855         * Scripts/webkitpy/port/ios_simulator.py:
3856         (IOSSimulatorPort.default_child_processes): Deleted.
3857         (IOSSimulatorPort.check_sys_deps): Deleted.
3858         * Scripts/webkitpy/port/mac.py:
3859         (MacPort.default_child_processes): Accept additional arguments.
3860         * Scripts/webkitpy/port/test.py:
3861         * Scripts/webkitpy/port/watch_device.py:
3862         (WatchDevicePort):
3863         (WatchDevicePort.default_child_processes): Deleted.
3864         * Scripts/webkitpy/port/watch_simulator.py:
3865         (WatchSimulatorPort.default_child_processes): Deleted.
3866         (WatchSimulatorPort.check_sys_deps): Deleted.
3867         * Scripts/webkitpy/xcode/simulated_device.py:
3868         (SimulatedDeviceManager):
3869         (SimulatedDeviceManager.device_count_for_type): Count the number of devices
3870         available for a specific device type.
3871
3872 2018-12-05  Devin Rousso  <drousso@apple.com>
3873
3874         Unreviewed, add myself to some watch lists.
3875
3876         * Scripts/webkitpy/common/config/watchlist:
3877
3878 2018-12-05  Alicia Boya García  <aboya@igalia.com>
3879
3880         [MSE][GStreamer] Remove the AppendPipeline state machine
3881         https://bugs.webkit.org/show_bug.cgi?id=192204
3882
3883         Reviewed by Xabier Rodriguez-Calvar.
3884
3885         Updated AbortableTaskQueue tests:
3886
3887         Added test: AbortedBySyncTaskHandler.
3888
3889         Renamed test: AbortDuringSyncTask -> AbortBeforeSyncTaskRun (in
3890         order to avoid confusion with the new test).
3891
3892         Added checks for the correct destruction of response objects.
3893
3894         * TestWebKitAPI/Tests/WebCore/AbortableTaskQueue.cpp:
3895         (TestWebKitAPI::FancyResponse::FancyResponse):
3896         (TestWebKitAPI::FancyResponse::~FancyResponse):
3897         (TestWebKitAPI::TEST):
3898
3899 2018-12-04  Chris Dumez  <cdumez@apple.com>
3900
3901         ProcessSwap.UseSessionCookiesAfterProcessSwapInPrivateBrowsing API test is failing
3902         https://bugs.webkit.org/show_bug.cgi?id=192362
3903
3904         Reviewed by Alex Christensen.
3905
3906         Set the cookie policy to Accept to make sure the cookies are saved.
3907
3908         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3909
3910 2018-12-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3911
3912         [WPE][GTK] Update GLib
3913         https://bugs.webkit.org/show_bug.cgi?id=191222
3914
3915         Reviewed by Žan Doberšek.
3916
3917         When I try running API tests locally, they crash with:
3918
3919         GLib-GIO-WARNING **: unknown schema extension 'd'
3920
3921         We need to update our old glib to support the 'd' value type, otherwise schemas that may
3922         exist on the host using this type will cause instant crashes.
3923
3924         Also, switch the GLib build to use meson. This requires updating meson as well.
3925
3926         * gtk/jhbuild.modules:
3927         * gtk/patches/glib-cast-function-type.patch: Removed.
3928         * gtk/patches/glib-gtester-do-not-consider-skipped-tests-as-failures.patch: Removed.
3929         * wpe/jhbuild.modules:
3930         * wpe/patches/glib-cast-function-type.patch: Removed.
3931         * wpe/patches/glib-revert-wakeup-changes.patch: Removed.
3932
3933 2018-12-04  Aakash Jain  <aakash_jain@apple.com>
3934
3935         [ews-app] Run BugzillaPatchFetcher periodically
3936         https://bugs.webkit.org/show_bug.cgi?id=192241
3937
3938         Reviewed by Lucas Forschler.
3939
3940         * BuildSlaveSupport/ews-app/ews/__init__.py:
3941         * BuildSlaveSupport/ews-app/ews/apps.py:
3942         (EwsConfig.ready): This method is called by Django on startup.
3943         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3944         (FetchLoop): Class which invokes BugzillaPatchFetcher every 60s.
3945
3946 2018-12-04  Jonathan Bedard  <jbedard@apple.com>
3947
3948         webkitpy: Support unicode in MeteredStream
3949         https://bugs.webkit.org/show_bug.cgi?id=192260
3950
3951         Reviewed by Aakash Jain.
3952
3953         It's possible that the test runner returns unicode characters to be logged when
3954         running layout tests.
3955
3956         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
3957         (MeteredStream.write): Print message without attempting to encode/decode it.
3958         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
3959         (RegularTest.test_unicode):
3960
3961 2018-12-04  Keith Rollin  <krollin@apple.com>
3962
3963         Update scripts for generating .xcfilelist files
3964         https://bugs.webkit.org/show_bug.cgi?id=192081
3965         <rdar://problem/46312290>
3966
3967         Reviewed by Brent Fulgham.
3968
3969         The initial pass at generate-xcfilelists (a script for
3970         creating/updating the .xcfilelist files needed for various Generate
3971         Foo Source build phases in Xcode) only generated the .xcfilelist files
3972         that held the output files; it did not generate the list of input
3973         files. As well, for the sources generated by DerivedSources.make
3974         makefiles, the script accomplished this via the implementation of a
3975         convention in the makefile that allowed the printing of these output
3976         files when invoked with the 'print_all_generated_files' target. Use of
3977         this convention is inconvenient and error-prone.
3978
3979         The script is now updated to address both of these issues. First, it
3980         generates for the input and output sets of files. Second, it does away
3981         with the convention in the DerivedSources.make makefiles and instead
3982         works from the dependency output information printed when `make` is
3983         invoked with --debug. This second part is implemented in the new
3984         script extract-dependencies-from-makefile.
3985
3986         * Scripts/extract-dependencies-from-makefile: Added.
3987         (Parser):
3988         (Parser.__init__):
3989         (Parser.nextLine):
3990         (Parser.addTarget):
3991         (Parser.addPrereq):
3992         (Parser.doParse):
3993         (Parser.printInputs):
3994         (Parser.printOutputs):
3995         (parseArgs):
3996         (main):
3997         * Scripts/generate-xcfilelists:
3998
3999 2018-12-04  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
4000
4001         [WPE] Add gtk-doc
4002         https://bugs.webkit.org/show_bug.cgi?id=178900
4003
4004         Reviewed by Michael Catanzaro.
4005
4006         Add gtk-doc to WPE port. This patch tries to reuse as much code from
4007         WebKitGTK+ as possible.
4008
4009         * gtkdoc/generate-gtkdoc: Renamed from Tools/gtk/generate-gtkdoc.
4010         (get_gtkdoc_module_paths): Add GDK and GTK only if building for GTK.
4011         (prepare_environment_for_gtkdoc_generation):
4012         (build_gtkdoc_for_wpe): Code to generate doc for WPE.
4013         (build_gtkdoc_for_wkgtk): Code to generate doc for WebKitGTK+. Moved from main.
4014         * gtkdoc/gtkdoc.py: Renamed from Tools/gtk/gtkdoc.py.
4015         (GTKDoc.__init__): Initialized required variables according to pylint.
4016         (GTKDoc.api_missing_documentation):
4017         * wpe/install-dependencies: Add gtkdoc dependency.
4018
4019 2018-12-04  Carlos Garcia Campos  <cgarcia@igalia.com>
4020
4021         [SOUP] Move URLSoup back to WebCore after r238771
4022         https://bugs.webkit.org/show_bug.cgi?id=192306
4023
4024         Reviewed by Michael Catanzaro.
4025
4026         Include GUniquePtrSoup from WebCore again.
4027
4028         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
4029
4030 2018-12-03  Carlos Garcia Campos  <cgarcia@igalia.com>
4031
4032         [GTK] Bump freetype, fontconfig, harfbuzz, cairo and icu in jhbuild
4033         https://bugs.webkit.org/show_bug.cgi?id=192310
4034
4035         Reviewed by Michael Catanzaro.
4036
4037         Update those dependencies to their latest stable versions.
4038
4039         * gtk/jhbuild.modules:
4040
4041 2018-12-03  Tomas Popela  <tpopela@redhat.com>
4042
4043         [GTK] Can't run MiniBrowser due to missing python2-yaml
4044         https://bugs.webkit.org/show_bug.cgi?id=192308
4045
4046         Reviewed by Michael Catanzaro.
4047
4048         * gtk/install-dependencies:
4049
4050 2018-12-03  Chris Dumez  <cdumez@apple.com>
4051
4052         Regression(PSON) Google OAuth is broken in private sessions
4053         https://bugs.webkit.org/show_bug.cgi?id=192337
4054         <rdar://problem/46353558>
4055
4056         Reviewed by Alex Christensen.
4057
4058         Add API test coverage.
4059
4060         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4061         * TestWebKitAPI/Tests/WebKitCocoa/GetSessionCookie.html: Added.
4062         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4063         * TestWebKitAPI/Tests/WebKitCocoa/SetSessionCookie.html: Added.
4064
4065 2018-12-03  Chris Dumez  <cdumez@apple.com>
4066
4067         [PSON] Request by the client to process-swap is ignored if the window has an opener
4068         https://bugs.webkit.org/show_bug.cgi?id=192267
4069         <rdar://problem/46386886>
4070
4071         Reviewed by Brady Eidson.
4072
4073         Add API test coverage.
4074
4075         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4076
4077 2018-12-03  Keith Rollin  <krollin@apple.com>
4078
4079         Add .xcfilelist files
4080         https://bugs.webkit.org/show_bug.cgi?id=192082
4081         <rdar://problem/46312533>
4082
4083         Reviewed by Brent Fulgham.
4084
4085         Add .xcfilelist files for Generate Derived Sources and Generate
4086         Unified Sources build phases in Xcode. These are just being staged for
4087         now; they'll be added to the Xcode projects later.
4088
4089         * DumpRenderTree/DerivedSources-input.xcfilelist: Added.
4090         * DumpRenderTree/DerivedSources-output.xcfilelist: Added.
4091         * WebKitTestRunner/DerivedSources-input.xcfilelist: Added.
4092         * WebKitTestRunner/DerivedSources-output.xcfilelist: Added.
4093
4094 2018-12-03  Alex Christensen  <achristensen@webkit.org>
4095
4096         Add WKWebProcessPlugInLoadDelegate SPI willStartProvisionalLoadForFrame with a completion handler
4097         https://bugs.webkit.org/show_bug.cgi?id=192272
4098
4099         Reviewed by Brady Eidson.
4100
4101         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
4102         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]):
4103         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
4104
4105 2018-12-03  Wenson Hsieh  <wenson_hsieh@apple.com>
4106
4107         [iOSMac] Unable to upload non-image files using drag and drop in WKWebView
4108         https://bugs.webkit.org/show_bug.cgi?id=192283
4109         <rdar://problem/46399461>
4110
4111         Reviewed by Ryosuke Niwa.
4112
4113         Add a new API test to check that an item provider which contains plain text data and a file URL (but is not
4114         marked as an attachment) is still treated as an attachment upon drop. Furthermore, verify that "text/uri-list"
4115         does not expose the actual file URL written to the item provider.
4116
4117         Additionally, rebaseline an existing API test to remove an extraneous "text/uri-list" type that appears in
4118         `DataTransfer.types`, but whose data is inaccessible via `getData` anyways.
4119
4120         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
4121
4122 2018-12-01  Don Olmstead  <don.olmstead@sony.com>
4123
4124         Cleanup WebKit Features
4125         https://bugs.webkit.org/show_bug.cgi?id=192262
4126
4127         Reviewed by Michael Catanzaro.
4128
4129         Removes obsolete ENABLE options and variable names. Syncs the option's
4130         descriptions with what is present in WebKitFeatures.cmake. Sorts the
4131         options based on the associated define.
4132
4133         * Scripts/webkitperl/FeatureList.pm:
4134
4135 2018-12-01  Chris Dumez  <cdumez@apple.com>
4136
4137         [PSON] process-swapping may occur even though opener has handle to openee
4138         https://bugs.webkit.org/show_bug.cgi?id=192277
4139
4140         Reviewed by Antti Koivisto.
4141
4142         Add API test coverage.
4143
4144         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4145
4146 2018-12-01  Jonathan Bedard  <jbedard@apple.com>
4147
4148         Unreviewed, rolling out r238764.
4149
4150         Breaks existing layout tests
4151
4152         Reverted changeset:
4153
4154         "webkitpy: Support unicode in MeteredStream"
4155         https://bugs.webkit.org/show_bug.cgi?id=192260
4156         https://trac.webkit.org/changeset/238764
4157
4158 2018-12-01  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
4159
4160         Move URL tests from TestWebKitAPI to TestWTF
4161         https://bugs.webkit.org/show_bug.cgi?id=192275
4162
4163         Reviewed by Keith Miller.
4164
4165         Since URL is moved from WebCore to WTF, we also move tests for them from TestWebKitAPI (TestWebCore) to TestWTF.
4166         But we still have some tests in TestWebCore since only WebCore implements TextEncoding. That part is now decoupled
4167         from URLParser tests and new URLParserTextEncoding.cpp is created.
4168
4169         * TestWebKitAPI/CMakeLists.txt:
4170         * TestWebKitAPI/PlatformGTK.cmake:
4171         * TestWebKitAPI/PlatformWPE.cmake:
4172         * TestWebKitAPI/PlatformWin.cmake:
4173         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4174         * TestWebKitAPI/Tests/WTF/URL.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/URL.cpp.
4175         (TestWebKitAPI::TEST_F):
4176         * TestWebKitAPI/Tests/WTF/URLParser.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp.
4177         (TestWebKitAPI::TEST_F):
4178         * TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm.
4179         (TestWebKitAPI::TEST):
4180         * TestWebKitAPI/Tests/WebCore/URLParserTextEncoding.cpp: Added.
4181         (TestWebKitAPI::ExpectedParts::isInvalid const):
4182         (TestWebKitAPI::eq):
4183         (TestWebKitAPI::insertTabAtLocation):
4184         (TestWebKitAPI::invalidParts):
4185         (TestWebKitAPI::checkURL):
4186         (TestWebKitAPI::TEST_F):
4187
4188 2018-11-30  Zalan Bujtas  <zalan@apple.com>
4189
4190         Unreviewed LFC passing test list update.
4191
4192         * LayoutReloaded/misc/LFC-passing-tests.txt:
4193
4194 2018-11-30  Alex Christensen  <achristensen@webkit.org>
4195
4196         Move URL from WebCore to WTF
4197         https://bugs.webkit.org/show_bug.cgi?id=190234
4198
4199         Reviewed by Keith Miller.
4200
4201         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
4202         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
4203         * TestWebKitAPI/Tests/WebCore/URL.cpp:
4204         (TestWebKitAPI::createURL):
4205         (TestWebKitAPI::TEST_F):
4206         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
4207         (TestWebKitAPI::checkURL):
4208         (TestWebKitAPI::checkRelativeURL):
4209         (TestWebKitAPI::checkURLDifferences):
4210         (TestWebKitAPI::checkRelativeURLDifferences):
4211         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
4212         * TestWebKitAPI/Tests/WebCore/YouTubePluginReplacement.cpp:
4213         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
4214         (TestWebKitAPI::originalDataAsString):
4215         (TestWebKitAPI::userVisibleString):
4216         (TestWebKitAPI::literalURL):
4217         (TestWebKitAPI::TEST):
4218         * TestWebKitAPI/Tests/WebKitCocoa/LoadAlternateHTMLString.mm:
4219         (TEST):
4220         * TestWebKitAPI/Tests/WebKitCocoa/LoadInvalidURLRequest.mm:
4221         (literalURL):
4222         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
4223         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm:
4224         (-[LoadInvalidURLWebFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
4225         * TestWebKitAPI/Tests/mac/SSLKeyGenerator.mm:
4226         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
4227         (TestWebKitAPI::Util::createURLForResource):
4228         * lldb/lldb_webkit.py:
4229         (__lldb_init_module):
4230         (WTFURL_SummaryProvider):
4231         (WTFURLProvider):
4232         (WebCoreURL_SummaryProvider): Deleted.
4233         (WebCoreURLProvider): Deleted.
4234         (WebCoreURLProvider.__init__): Deleted.
4235         (WebCoreURLProvider.to_string): Deleted.
4236
4237 2018-11-30  Jonathan Bedard  <jbedard@apple.com>
4238
4239         webkitpy: Support unicode in MeteredStream
4240         https://bugs.webkit.org/show_bug.cgi?id=192260
4241
4242         Reviewed by Stephanie Lewis.
4243
4244         It's possible that the test runner returns unicode characters to be logged when
4245         running layout tests.
4246
4247         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
4248         (MeteredStream.write): Message written to metered stream should be unicode.
4249         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
4250         (RegularTest.test_unicode):
4251
4252 2018-11-30  Jonathan Bedard  <jbedard@apple.com>
4253
4254         REGRESSION (r238749): run-api-tests dies with AttributeError: 'IOSSimulatorPort' object has no attribute 'DEFAULT_DEVICE_CLASS'
4255         https://bugs.webkit.org/show_bug.cgi?id=192257
4256         <rdar://problem/46384671>
4257
4258         Reviewed by Stephanie Lewis.
4259
4260         Follow-up fix for r238749.
4261
4262         * Scripts/webkitpy/api_tests/manager.py:
4263         (Manager._initialize_devices): Use DEFAULT_DEVICE_TYPE instead of DEFAULT_DEVICE_CLASS.
4264
4265 2018-11-30  Chris Dumez  <cdumez@apple.com>
4266
4267         [PSON] We are sometimes swapping processes even though there is an opened window with an opener link to us
4268         https://bugs.webkit.org/show_bug.cgi?id=192242
4269
4270         Reviewed by Geoffrey Garen.
4271
4272         Add API test coverage.
4273
4274         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4275
4276 2018-11-30  Don Olmstead  <don.olmstead@sony.com>
4277
4278         Rename ENABLE_SUBTLE_CRYPTO to ENABLE_WEB_CRYPTO
4279         https://bugs.webkit.org/show_bug.cgi?id=192197
4280
4281         Reviewed by Jiewen Tan.
4282
4283         * Scripts/webkitperl/FeatureList.pm:
4284         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4285
4286 2018-11-30  Dean Jackson  <dino@apple.com>
4287
4288         Add first-class support for .mjs files in jsc binary
4289         https://bugs.webkit.org/show_bug.cgi?id=192190
4290         <rdar://problem/46375715>
4291
4292         Reviewed by Keith Miller.
4293
4294         Add .mjs files to the regexp looking for all JS files.
4295
4296         * Scripts/run-jsc-stress-tests:
4297
4298 2018-11-30  Jonathan Bedard  <jbedard@apple.com>
4299
4300         webkitpy: Use DeviceType instead of str to represent device class
4301         https://bugs.webkit.org/show_bug.cgi?id=192160
4302         <rdar://problem/46344845>
4303
4304         Rubber-stamped by Aakash Jain.
4305
4306         * Scripts/webkitpy/layout_tests/controllers/manager.py:
4307         (Manager._custom_device_for_test): Use DeviceTypes instead of strings to represent device type.
4308         (Manager._set_up_run): Do not set _options.device_class, use device_type instead of device_class.
4309         (Manager.run): Use device_type instead of device_class.
4310         (Manager._print_expectations_for_subset): Ditto.
4311         (Manager.print_expectations): Ditto.
4312         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
4313         (ManagerTest.test_uses_custom_device): Use DeviceType and actual device definition.
4314         * Scripts/webkitpy/layout_tests/views/printing.py:
4315         (Printer.print_workers_and_shards): Outputting the device suffix doesn't really help, and means
4316         device type needs to be passed around.
4317         * Scripts/webkitpy/port/apple.py:
4318         (ApplePort.setup_test_run): Use device_type instead of device_class.
4319         * Scripts/webkitpy/port/base.py:
4320