[chromium] Need a way to test lost compositor context recovery
[WebKit-https.git] / Tools / ChangeLog
1 2011-08-23  James Robinson  <jamesr@chromium.org>
2
3         [chromium] Need a way to test lost compositor context recovery
4         https://bugs.webkit.org/show_bug.cgi?id=66820
5
6         Reviewed by Kenneth Russell.
7
8         Exposes a LayoutTestController interface in chromium to simulate a
9         lost compositor context.
10
11         * DumpRenderTree/chromium/LayoutTestController.cpp:
12         (LayoutTestController::LayoutTestController):
13         (LayoutTestController::loseCompositorContext):
14         * DumpRenderTree/chromium/LayoutTestController.h:
15
16 2011-08-23  Dimitri Glazkov  <dglazkov@chromium.org>
17
18         Change garden-o-matic frontend builder array to be a configuration map.
19         https://bugs.webkit.org/show_bug.cgi?id=66816
20
21         Reviewed by Adam Barth.
22
23         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js: Made kBuilders a map, with value being a configuration object.
24         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: Adjusted callsites to expect a map.
25         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/main.js: Ditto.
26         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js: Ditto.
27         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Ditto.
28
29 2011-08-23  Cary Clark  <caryclark@google.com>
30
31         Turn WebCanvas into CGContext before drawing scrollbar (DRT using Skia on Mac)
32         https://bugs.webkit.org/show_bug.cgi?id=66803
33
34         This fixes the WebKit Canaries, in particular avoids a crash on tests
35         like css1/basic/comments.html.
36
37         Reviewed by James Robinson.
38
39         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
40         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
41         The NSGraphicsContext call graphicsContextWithGraphicsPort takes a void*
42         parameter, so it took a WebCanvas* (mapped to SkCanvas* in Skia-land)
43         and treated it as if it were a CGContextRef.
44
45 2011-08-23  Patrick Gansterer  <paroga@webkit.org>
46
47         Fix mergeChangeLogs test on native windows
48         https://bugs.webkit.org/show_bug.cgi?id=66797
49
50         Reviewed by Adam Roben.
51
52         Windows has no /tmp/ directory and the "TMPDIR" environment variable isn't set in the default setup.
53         Add the "TEMP" environment variable as additional source for the temporary directory used in writeTempFile.
54
55         * Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl:
56         (writeTempFile):
57
58 2011-08-23  Dimitri Glazkov  <dglazkov@chromium.org>
59
60         garden-o-matic relative time is wrong and updates too frequently.
61         https://bugs.webkit.org/show_bug.cgi?id=66802
62
63         Reviewed by Adam Barth.
64
65         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js: Changed to account for rounding correctly.
66         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js: Updated tests.
67         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: Upped the interval to 1 minute.
68
69 2011-08-23  Patrick Gansterer  <paroga@webkit.org>
70
71         Add missing quotes around filenames in mergeChangeLogs
72         https://bugs.webkit.org/show_bug.cgi?id=66794
73
74         Reviewed by Adam Roben.
75
76         * Scripts/VCSUtils.pm:
77         (mergeChangeLogs):
78
79 2011-08-23  Patrick Gansterer  <paroga@webkit.org>
80
81         webkit-perl tests fail on win32 Perl due to lack of list form of pipe open implementation
82         https://bugs.webkit.org/show_bug.cgi?id=49080
83
84         Reviewed by Adam Roben.
85
86         Use the string form of pipe open instead (like we do at all other places).
87
88         * Scripts/VCSUtils.pm:
89         (mergeChangeLogs):
90
91 2011-08-23  Adam Barth  <abarth@webkit.org>
92
93         garden-o-matic summary should be able to examine failures
94         https://bugs.webkit.org/show_bug.cgi?id=66748
95
96         Reviewed by Dimitri Glazkov.
97
98         This patch refactors a bunch of code from summary.js to independent
99         controllers in controllers.js.  This patch also contains the first
100         iteration of binding the "examine" event to a the behavior showing the
101         details view for the tests.  There's more work to do here to make this
102         work properly (and elegantly), but this patch is a start.
103
104         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
105         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
106         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
107         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers/rebaseline.js:
108         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
109         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
110         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
111         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
112         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
113
114 2011-08-23  Adam Barth  <abarth@webkit.org>
115
116         webkitpy/common/config/build.py shouldn't mention non-existant Android directory
117         https://bugs.webkit.org/show_bug.cgi?id=66737
118
119         Reviewed by Steve Block.
120
121         This directory doesn't exist anymore now that the Android port shares
122         more code with Chromium.
123
124         * Scripts/webkitpy/common/config/build.py:
125
126 2011-08-22  Eric Seidel  <eric@webkit.org>
127
128         Hack start-queue.sh in an attempt to resurrect the cr-jail-1 cr-mac-ews bot.
129         I won't have ssh access to the bot again for a couple days, so
130         attempting to fix by changing this script.  If this doesn't
131         work we'll just live with the it hung for now.
132
133         Unreviewed.
134
135         * EWSTools/start-queue.sh:
136
137 2011-08-22  Dimitri Glazkov  <dglazkov@chromium.org>
138
139         webkit-patch rebaseline-expectations command should not rearrange the entire test_expectations.txt file.
140         https://bugs.webkit.org/show_bug.cgi?id=66727
141
142         Reviewed by Adam Barth.
143
144         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Made it possible to run TestExpectationSerializer without a TestConfigurationConverter,
145             in which case the serializer treats all expectations as unparsed.
146         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added unit tests.
147
148 2011-08-22  Dimitri Glazkov  <dglazkov@chromium.org>
149
150         Update unit test expectations after r93530.
151
152         * Scripts/webkitpy/layout_tests/port/factory_unittest.py: Updated.
153         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: Ditto.
154
155 2011-08-22  Dimitri Glazkov  <dglazkov@chromium.org>
156
157         [Chromium] Expand CPU/GPU/Skia/CG into a matrix in graphics_type.
158         https://bugs.webkit.org/show_bug.cgi?id=66705
159
160         Reviewed by Adam Barth.
161
162         * Scripts/webkitpy/layout_tests/port/chromium.py: Added plumbing for CG graphics types.
163         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Adjusted unit test.
164
165 2011-08-22  James Robinson  <jamesr@chromium.org>
166
167         [chromium] Update builder names for chromium gpu bots due to CG switchover
168         https://bugs.webkit.org/show_bug.cgi?id=66693
169
170         Reviewed by Dirk Pranke.
171
172         Update the port and builder names for the chromium mac gpu bots to
173         account for the CG transition.
174
175         * Scripts/webkitpy/layout_tests/port/builders.py:
176
177 2011-08-22  Dirk Pranke  <dpranke@chromium.org>
178
179         fix the GPU bot names on the layout test dashboard
180         https://bugs.webkit.org/show_bug.cgi?id=66697
181
182         Reviewed by Dimitri Glazkov.
183
184         * TestResultServer/static-dashboards/builders.js:
185
186 2011-08-22  Dimitri Glazkov  <dglazkov@chromium.org>
187
188         garden-o-matic's relative time display should be updated regularly.
189         https://bugs.webkit.org/show_bug.cgi?id=66682
190
191         Reviewed by Adam Barth.
192
193         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Moved Time to ui.Time, added code for regular updates.
194         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Changed to use ui.Time.
195         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js: Added tests.
196
197 2011-08-22  Xianzhu Wang  <wangxianzhu@chromium.org>
198
199         Pass --makeargs of build-webkit to chromium linux builder
200         https://bugs.webkit.org/show_bug.cgi?id=66361
201
202         Reviewed by Tony Chang.
203
204         * Scripts/build-webkit:
205         * Scripts/webkitdirs.pm:
206         (buildChromiumMakefile):
207         (buildChromium):
208
209 2011-08-22  Peter Beverloo  <peter@chromium.org>
210
211         Add myself to the contributor list.
212         https://bugs.webkit.org/show_bug.cgi?id=66674
213
214         Reviewed by Tony Gentilcore.
215
216         * Scripts/webkitpy/common/config/committers.py:
217
218 2011-08-22  Balazs Kelemen  <kbalazs@webkit.org>
219
220         [Qt] ImageDiff does not consider --tolerance
221         https://bugs.webkit.org/show_bug.cgi?id=66299
222
223         Reviewed by Csaba Osztrogonác.
224
225         * DumpRenderTree/qt/ImageDiff.cpp:
226         (main):
227
228 2011-08-22  Csaba Osztrogonác  <ossy@webkit.org>
229
230         Update contributor list.
231
232         Reviewed by Zoltan Herczeg.
233
234         * Scripts/webkitpy/common/config/committers.py:
235
236 2011-08-22  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
237
238         [ORWT] Fix --reset-results --add-platform-exceptions combo
239         https://bugs.webkit.org/show_bug.cgi?id=65464
240
241         Reviewed by Csaba Osztrogonác.
242
243         * Scripts/old-run-webkit-tests:
244
245 2011-08-20  Adam Barth  <abarth@webkit.org>
246
247         garden-o-matic summary.html should have UI for examining failures
248         https://bugs.webkit.org/show_bug.cgi?id=66625
249
250         Reviewed by Dimitri Glazkov.
251
252         This patch introduces the notion of UI actions and converts our
253         existing manual <button> manipulation with this new abstraction.  The
254         patch also adds an Examine button to failure notifications.  In a
255         future patch, I'll add a controller that wires this button up to
256         something useful.
257
258         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
259         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
260         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js: Added.
261         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js: Added.
262         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
263         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
264         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
265         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
266
267 2011-08-20  Adam Barth  <abarth@webkit.org>
268
269         garden-o-matic summary page should indiciate compile failures
270         https://bugs.webkit.org/show_bug.cgi?id=66624
271
272         Reviewed by Dimitri Glazkov.
273
274         This patch creates a notification-based UI for build failures.  The new
275         UI displays the same information that used to be displayed in the
276         infobar.  There's lots of room for improvement in surfacing more
277         information, but this is a start.
278
279         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
280         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
281         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
282
283 2011-08-19  James Robinson  <jamesr@chromium.org>
284
285         [chromium] Default to experimental-fully-parallel mode for chromium gpu port
286         https://bugs.webkit.org/show_bug.cgi?id=66606
287
288         Reviewed by Dirk Pranke.
289
290         The chromium GPU configuration does not (currently) contain any tests
291         incompatible with --experimental-fully-parallel, and this flag is a
292         significan speedup because of the directory canvas/philip/tests which
293         contains 802 tests in the same directory. Setting this option by
294         default on this configuration is a 2x speed in release, 44s to 22s,
295         and a 3x speedup in debug, 223s to 77s, on linux on a 16 core machine.
296
297         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
298         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
299         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
300
301 2011-08-19  Sheriff Bot  <webkit.review.bot@gmail.com>
302
303         Unreviewed, rolling out r93426.
304         http://trac.webkit.org/changeset/93426
305         https://bugs.webkit.org/show_bug.cgi?id=66607
306
307         Broke the Mac build by not building gtest.framework anymore
308         (Requested by andersca on #webkit).
309
310         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
311
312 2011-08-19  James Robinson  <jamesr@chromium.org>
313
314         [chromium] Chromium GPU layout tests should use the normal process number selection, not force 1 worker
315         https://bugs.webkit.org/show_bug.cgi?id=66603
316
317         Reviewed by Dirk Pranke.
318
319         The various ChromiumGpu ports should use the same child worker
320         selection logic as other ports so they can run with full
321         parallelization on multicore systems.
322
323         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
324         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
325
326 2011-08-19  Alok Priyadarshi  <alokp@chromium.org>
327
328         [chromium] Remove dependency of WebThemeControlDRTWin on skia::PlatformCanvas
329         https://bugs.webkit.org/show_bug.cgi?id=66570
330
331         Reviewed by Mihai Parparita.
332
333         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
334         (WebThemeControlDRTWin::draw):
335         (WebThemeControlDRTWin::drawTextField):
336         (WebThemeControlDRTWin::drawProgressBar):
337         * DumpRenderTree/chromium/WebThemeControlDRTWin.h:
338
339 2011-08-18  Dmitry Lomov  <dslomov@google.com>
340
341         TestWebKitAPI breaks on Windows due to fast malloc incompatibility.
342         https://bugs.webkit.org/show_bug.cgi?id=66521
343
344         This patch ensures that gtest uses new and delete operators that are defined in JavaScriptCore.
345
346         Reviewed by David Levin.
347
348         * TestWebKitAPI/Tests/WTF/StringOperators.cpp: Removed redefinition of JS_EXPORTDATA.
349
350 2011-08-19  Adam Roben  <aroben@apple.com>
351
352         Add project file changes I left out in r93417
353
354         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
355
356 2011-08-19  Adam Roben  <aroben@apple.com>
357
358         Add a helper class for swizzling ObjC instance methods to TestWebKitAPI
359
360         Fixes <http://webkit.org/b/66565> TestWebKitAPI needs a way to override instance methods of
361         NSScreen
362
363         Reviewed by Anders Carlsson.
364
365         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
366
367         * TestWebKitAPI/Tests/TestWebKitAPI/mac/InstanceMethodSwizzler.mm: Added.
368         (-[SimpleObject setValue:]): Original implementation.
369
370         (TestWebKitAPI::setValue2):
371         (TestWebKitAPI::setValue3):
372         Swizzled implementations.
373
374         (TestWebKitAPI::TEST): Test that we can swizzle and re-swizzle and un-swizzle an ObjC
375         instance method.
376
377         * TestWebKitAPI/mac/InstanceMethodSwizzler.h: Added.
378         * TestWebKitAPI/mac/InstanceMethodSwizzler.mm: Added.
379         (TestWebKitAPI::InstanceMethodSwizzler::InstanceMethodSwizzler): Swizzle the method.
380         (TestWebKitAPI::InstanceMethodSwizzler::~InstanceMethodSwizzler): Unswizzle the method.
381
382 2011-08-19  Tom Zakrajsek  <tomz@codeaurora.org>
383
384         Fix _path_to_apache() error reporting
385         https://bugs.webkit.org/show_bug.cgi?id=66486
386
387         Reviewed by Ryosuke Niwa.
388
389         * Scripts/webkitpy/layout_tests/port/webkit.py:
390
391 2011-08-19  Adam Roben  <aroben@apple.com>
392
393         Windows build fix after r93404
394
395         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp: Added missing #include.
396
397 2011-08-19  Tony Gentilcore  <tonyg@chromium.org>
398
399         Add leandrogracia to the committers list
400         https://bugs.webkit.org/show_bug.cgi?id=66552
401
402         Also fix line endings in file.
403
404         No reviewed required.
405
406         * Scripts/webkitpy/common/config/committers.py:
407
408 2011-08-19  Amruth Raj  <amruthraj@motorola.com>
409
410         Fix compilation issue in WebKitTestRunner
411         https://bugs.webkit.org/show_bug.cgi?id=66554
412
413         Reviewed by Martin Robinson.
414
415         * WebKitTestRunner/PixelDumpSupport.cpp:
416
417 2011-08-19  Adam Roben  <aroben@apple.com>
418
419         Pull some of DynamicDeviceScaleFactor's code up into a shareable base class
420
421         This will make it easier to write other WebKit-agnostic tests
422
423         Fixes <http://webkit.org/b/66558> Would like to be able to reuse DynamicDeviceScaleFactor's
424         code in other WebKit-agnostic tests
425
426         Reviewed by Anders Carlsson.
427
428         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
429
430         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm: Fixed copyright. Moved a bunch of
431         code to WebKitAgnosticTest.h/mm. Changed to inherit from WebKitAgnosticTest.
432         (TestWebKitAPI::DynamicDeviceScaleFactor::url): Simple getter.
433         (TestWebKitAPI::DynamicDeviceScaleFactor::didLoadURL): Calls through to runTest.
434         (TestWebKitAPI::DynamicDeviceScaleFactor::runTest): Removed loading code which
435         WebKitAgnosticTest handles for us.
436         (TestWebKitAPI::TEST_F): Removed view-creation code which WebKitAgnosticTest handles for us.
437
438         * TestWebKitAPI/mac/WebKitAgnosticTest.h: Added. Code came from DynamicDeviceScaleFactor.
439         (TestWebKitAPI::WebKitAgnosticTest::loadAndWaitUntilDone): Code came from
440         DynamicDeviceScaleFactor::runTest.
441
442         * TestWebKitAPI/mac/WebKitAgnosticTest.mm: Copied from Tools/TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm.
443         (TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test): Code came from
444         DynamicDeviceScaleFactor.WebKit.
445         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test): Code came from
446         DynamicDeviceScaleFactor.WebKit2.
447
448 2011-08-19  Adam Roben  <aroben@apple.com>
449
450         Clean up #includes in TestWebKitAPI
451
452         Fixes <http://webkit.org/b/66556> TestWebKitAPI's prefix header isn't very helpful
453
454         Reviewed by Anders Carlsson.
455
456         * TestWebKitAPI/TestWebKitAPIPrefix.h: Added wtf/Platform.h. Added gtest/gtest.h for C++
457         files and WebKit/WebKit.h for ObjC files.
458
459         * TestWebKitAPI/InjectedBundleController.cpp:
460         * TestWebKitAPI/JavaScriptTest.h:
461         * TestWebKitAPI/PlatformUtilities.h:
462         * TestWebKitAPI/PlatformWebView.h:
463         * TestWebKitAPI/Test.h:
464         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
465         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
466         * TestWebKitAPI/Tests/WTF/VectorReverse.cpp:
467         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
468         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
469         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
470         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
471         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
472         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
473         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
474         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
475         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
476         * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
477         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
478         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
479         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
480         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
481         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
482         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp:
483         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
484         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
485         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
486         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
487         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
488         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
489         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
490         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
491         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
492         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
493         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
494         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
495         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp:
496         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
497         * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp:
498         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
499         * TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp:
500         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
501         * TestWebKitAPI/TestsController.cpp:
502         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
503         Removed now-unnecessary #includes. Moved #includes of Test.h in with the rest of the
504         #includes since it is no longer a special header.
505
506 2011-08-18  Dirk Pranke  <dpranke@chromium.org>
507
508         new-run-webkit-tests hung while acquiring http lock on snow leopard bots
509         https://bugs.webkit.org/show_bug.cgi?id=64886
510
511         Temporarily disable the http locking to work around the issue.
512         I'm not actually sure if this is going to work or improve things
513         much.
514
515         Reviewed by Ryosuke Niwa.
516
517         * Scripts/webkitpy/layout_tests/port/mac.py:
518
519 2011-08-18  Tony Chang  <tony@chromium.org>
520
521         add embedded png checksums to WebKitTestRunner
522         https://bugs.webkit.org/show_bug.cgi?id=66494
523
524         Looks like WebKitTestRunner has never supported embedded checksums.  This copies
525         some code from DRT and adds it to the WebKitTestRunner.
526
527         Reviewed by Darin Adler.
528
529         * WebKitTestRunner/CyclicRedundancyCheck.cpp: Copied from Tools/DumpRenderTree
530         * WebKitTestRunner/CyclicRedundancyCheck.h: Copied from Tools/DumpRenderTree
531         * WebKitTestRunner/GNUmakefile.am: Add new files
532         * WebKitTestRunner/PixelDumpSupport.cpp: Copied from Tools/DumpRenderTree
533         * WebKitTestRunner/PixelDumpSupport.h: Copied from Tools/DumpRenderTree
534         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Add new files
535         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
536         (WTR::dumpBitmap): Refactor to use PixelDumpSupport.
537         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
538         * WebKitTestRunner/cg/TestInvocationCG.cpp:
539         (WTR::dumpBitmap): Refactor to use PixelDumpSupport.
540         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
541         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Add new files
542
543 2011-08-18  Shawn Singh  <shawnsingh@chromium.org>
544
545         https://bugs.webkit.org/show_bug.cgi?id=47240
546
547         Fixed a cygwin path problem in the chromium port of diff_image;
548         Also made the return values of the diff_image function more consistent.
549
550         Reviewed by Dirk Pranke.
551
552         * Scripts/webkitpy/layout_tests/port/chromium.py:
553
554 2011-08-17  Alejandro G. Castro  <alex@igalia.com>
555
556         [GTK] Fix compilation problems with deprecations in gtk+
557         https://bugs.webkit.org/show_bug.cgi?id=66073
558
559         Reviewed by Martin Robinson.
560
561         * DumpRenderTree/gtk/DumpRenderTree.cpp:
562         (main): G_CONST_RETURN was deprecated
563         * GtkLauncher/main.c:
564         (createWindow): Added gtk_box_new conditional compilation for
565         gtk+-3.
566         * MiniBrowser/gtk/BrowserWindow.c:
567         (browser_window_init): Replaced gtk_vbox_new with gtk_box_new, we
568         are just supporting gtk+-3 for WebKit2.
569
570 2011-08-18  Anders Carlsson  <andersca@apple.com>
571
572         Fix libc++ C++0x build
573         https://bugs.webkit.org/show_bug.cgi?id=66479
574
575         Reviewed by Adam Roben.
576
577         Add missing includes.
578
579         * DumpRenderTree/LayoutTestController.cpp:
580         * DumpRenderTree/mac/CheckedMalloc.cpp:
581
582 2011-08-18  Adam Roben  <aroben@apple.com>
583
584         Test that WebKit updates style when a WebView is moved between differently-scaled windows
585
586         Test for <http://webkit.org/b/66412> <rdar://problem/9971958> WebKit doesn't react when a
587         WebView is moved between windows with different backing scale factors
588
589         Reviewed by Anders Carlsson.
590
591         * TestWebKitAPI/JavaScriptTest.cpp:
592         (TestWebKitAPI::runJSTest): Moved a little bit of code from here...
593         (TestWebKitAPI::compareJSResult): ...to here. Also made the error message more similar to
594         gtest's built-in error messages.
595
596         * TestWebKitAPI/JavaScriptTest.h: Added overloads of runJSTest that take a WebView * and
597         WKView * for convenience on Mac. Added compareJSResult helper function for implementing
598         those overloads.
599
600         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
601
602         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm: Added.
603         (-[FrameLoadDelegate initWithDidFinishLoadBoolean:]): Simple initializer.
604         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]): Record that the load finished.
605         (TestWebKitAPI::didFinishLoadForFrame): Record that the load finished.
606         (TestWebKitAPI::setPageLoaderClient): Set up the client.
607         (TestWebKitAPI::DynamicDeviceScaleFactor::DynamicDeviceScaleFactor): Simple constructor.
608         (TestWebKitAPI::DynamicDeviceScaleFactor::createWindow): Creates a
609         SyntheticBackingScaleFactorWindow and returns it.
610         (TestWebKitAPI::DynamicDeviceScaleFactor::runTest): Loads devicePixelRatio.html and checks
611         that WebKit uses the correct scale factor when the WebView is not in a window, is put in a
612         window, is moved to a differently-scaled window, and is taken out of the window.
613         (TestWebKitAPI::DynamicDeviceScaleFactor::loadURL): Helper function with overloads for
614         WebKit1 and WebKit2.
615         (TestWebKitAPI::TEST_F): Runs the test, with overloads for WebKit1 and WebKit2.
616
617         * TestWebKitAPI/Tests/mac/devicePixelRatio.html: Added.
618
619         * TestWebKitAPI/mac/JavaScriptTestMac.mm: Added.
620         (TestWebKitAPI::runJSTest): Fairly simple overloads for WebView * and WKView *.
621
622         * TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.h: Added.
623         * TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.m: Added.
624         (-[SyntheticBackingScaleFactorWindow initWithContentRect:styleMask:backing:defer:]): Simple
625         initializer.
626         (-[SyntheticBackingScaleFactorWindow setBackingScaleFactor:]): Simple setter.
627
628         (-[SyntheticBackingScaleFactorWindow backingScaleFactor]):
629         (-[SyntheticBackingScaleFactorWindow userSpaceScaleFactor]):
630         Overrides of NSWindow methods that WebKit uses to determine the device scale factor.
631
632 2011-08-18  Dmitry Lomov  <dslomov@google.com>
633
634         https://bugs.webkit.org/show_bug.cgi?id=66425
635         check-webkit-style should detect incorrectly formatted file change descriptions.
636         Description, if present, should be separated from colon with a space.
637
638         Reviewed by David Levin.
639
640         * Scripts/webkitpy/style/checkers/changelog.py: Fix.
641         * Scripts/webkitpy/style/checkers/changelog_unittest.py: Unit tests.
642
643 2011-08-18  Adam Barth  <abarth@webkit.org>
644
645         webkit-patch pretty-diff should be shown in main help
646         https://bugs.webkit.org/show_bug.cgi?id=66404
647
648         Reviewed by Dimitri Glazkov.
649
650         As requested by dglazkov.
651
652         * Scripts/webkitpy/tool/commands/prettydiff.py:
653
654 2011-08-17  Dmitry Lomov  <dslomov@google.com>
655
656         https://bugs.webkit.org/show_bug.cgi?id=66400
657         Fix TestWebKitAPI build on Mac OS.
658
659         Reviewed by David Levin.
660
661         * TestWebKitAPI/Configurations/Base.xcconfig: Added ICU headers to the HEADER_SEARCH_PATH.
662
663 2011-08-17  Dimitri Glazkov  <dglazkov@chromium.org>
664
665         garden-o-matic spring cleaning: move scripts, styles, and images in the respective directories.
666         https://bugs.webkit.org/show_bug.cgi?id=66427
667
668         Reviewed by Adam Barth.
669
670         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js: Removed.
671         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js: Removed.
672         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot_unittests.js: Removed.
673         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js: Removed.
674         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js: Removed.
675         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js: Removed.
676         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js: Removed.
677         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js: Removed.
678         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector_unittests.js: Removed.
679         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm.js: Removed.
680         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm_unittests.js: Removed.
681         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js: Removed.
682         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js: Removed.
683         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NRWTResultsParser.js: Removed.
684         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm.js: Removed.
685         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm_unittests.js: Removed.
686         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ORWTResultsParser.js: Removed.
687         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/PersistentCache.js: Removed.
688         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css: Removed.
689         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm.js: Removed.
690         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm_unittests.js: Removed.
691         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js: Removed.
692         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js: Removed.
693         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities_unittests.js: Removed.
694         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js: Removed.
695         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBugzilla.js: Removed.
696         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBuildbot.js: Removed.
697         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Removed.
698         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Removed.
699         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/bugzilla_unittests.js: Removed.
700         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js: Removed.
701         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js: Removed.
702         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js: Removed.
703         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js: Removed.
704         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js: Removed.
705         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers: Removed.
706         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.js: Removed.
707         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers/rebaseline.js: Removed.
708         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-green.png: Removed.
709         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-red.png: Removed.
710         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
711         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images: Added.
712         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-green.png: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-green.png.
713         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-red.png: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-red.png.
714         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html:
715         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css: Removed.
716         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js: Removed.
717         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js: Removed.
718         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js: Removed.
719         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net.js: Removed.
720         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js: Removed.
721         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/rebaseline.html:
722         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js: Removed.
723         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js: Removed.
724         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
725         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Bugzilla.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js.
726         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Buildbot.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js.
727         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Buildbot_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot_unittests.js.
728         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Builder.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js.
729         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Builder_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js.
730         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FailingTestsBugForm.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js.
731         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FailingTestsBugForm_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js.
732         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FlakyLayoutTestDetector.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js.
733         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FlakyLayoutTestDetector_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector_unittests.js.
734         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FlakyTestBugForm.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm.js.
735         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FlakyTestBugForm_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm_unittests.js.
736         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/LayoutTestHistoryAnalyzer.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js.
737         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/LayoutTestResultsLoader.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js.
738         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/NRWTResultsParser.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NRWTResultsParser.js.
739         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/NewBugForm.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm.js.
740         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/NewBugForm_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm_unittests.js.
741         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ORWTResultsParser.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ORWTResultsParser.js.
742         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/PersistentCache.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/PersistentCache.js.
743         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/TestRelatedBugForm.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm.js.
744         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/TestRelatedBugForm_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm_unittests.js.
745         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Trac.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js.
746         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Utilities.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js.
747         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Utilities_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities_unittests.js.
748         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js.
749         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/WebKitBugzilla.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBugzilla.js.
750         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/WebKitBuildbot.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBuildbot.js.
751         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js.
752         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js.
753         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/bugzilla_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/bugzilla_unittests.js.
754         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js.
755         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js.
756         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js.
757         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js.
758         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js.
759         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.
760         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.js.
761         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/main.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js.
762         ():
763         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js.
764         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js.
765         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net.js.
766         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js.
767         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js.
768         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js.
769         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/trac_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js.
770         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js.
771         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results.js.
772         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results_unittests.js.
773         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js.
774         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/unexpected-passes.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.js.
775         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/TestFailures.css: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css.
776         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/main.css: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css.
777         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
778         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js: Removed.
779         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js: Removed.
780         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results.js: Removed.
781         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results_unittests.js: Removed.
782         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js: Removed.
783         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.html:
784         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.js: Removed.
785
786 2011-08-17  Jochen Eisinger  <jochen@chromium.org>
787
788         Make SVNTest.test_svn_apply use the same timezone logic as VCSUtils.pm
789         https://bugs.webkit.org/show_bug.cgi?id=65877
790
791         Reviewed by Eric Seidel.
792
793         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
794
795 2011-08-17  Dimitri Glazkov  <dglazkov@chromium.org>
796
797         Remove base.keys and replace it with Object.keys.
798         https://bugs.webkit.org/show_bug.cgi?id=66422
799
800         Reviewed by Adam Barth.
801
802         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Removed base.keys.
803         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Removed unit tests for it.
804         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js: Replaced with Object.keys
805
806 2011-08-17  Dimitri Glazkov  <dglazkov@chromium.org>
807
808         garden-o-matic Summary view should have items in descending chronological order.
809         https://bugs.webkit.org/show_bug.cgi?id=66403
810
811         Reviewed by Adam Barth.
812
813         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Renamed "push" to "add" for clarity, cleaned up some stuff.
814         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Rewrote add to insert DOM elements in order.
815         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added unit tests.
816
817 2011-08-17  Dimitri Glazkov  <dglazkov@chromium.org>
818
819         Fix a few errors in garden-o-matic frontend unit tests.
820         https://bugs.webkit.org/show_bug.cgi?id=66421
821
822         Reviewed by Adam Barth.
823
824         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Changed my excellent test to view time as variable continuum.
825         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js: Tweaked the test to accommodate new builder names.
826         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Hurriedly covered up my prior sins.
827
828 2011-08-17  Adam Barth  <abarth@webkit.org>
829
830         Update Tools to account for (CG) being added to Chromium builder names
831         https://bugs.webkit.org/show_bug.cgi?id=66410
832
833         Reviewed by Adam Barth.
834
835         Some of these names will change back once we turn on Skia bots.
836
837         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js:
838         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
839         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
840         * Scripts/webkitpy/layout_tests/port/builders.py:
841         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
842         * TestResultServer/static-dashboards/builders.js:
843         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
844
845 2011-08-16  Dimitri Glazkov  <dglazkov@chromium.org>
846
847         Wire up relative time to garden-o-matic summary view.
848         https://bugs.webkit.org/show_bug.cgi?id=66343
849
850         Reviewed by Adam Barth.
851
852         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js: Add time to the commitData object. 
853         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js: Adjusted unit tests.
854         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Wired up relative date.
855         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated unit tests.
856         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js: Adjusted unit tests.
857
858 2011-08-17  Adam Roben  <aroben@apple.com>
859
860         Make run-api-tests run tests in alphabetical order
861
862         Fixes <http://webkit.org/b/66401> run-api-tests runs tests in a semi-random order
863
864         Reviewed by David Kilzer.
865
866         * Scripts/run-api-tests:
867         (runAllTests):
868         (runAllTestsInSuite):
869         Sort the lists of tests and suites before iterating over them.
870
871 2011-08-17  Adam Barth  <abarth@webkit.org>
872
873         garden-o-matic should be able to rebaseline expected failures
874         https://bugs.webkit.org/show_bug.cgi?id=66204
875
876         Reviewed by Dimitri Glazkov.
877
878         This patch introduces a new view for displaying expect, actual, and
879         differences between results.  The new view also has a fledgling
880         controller that handles some basic operations.  The new view is
881         exercised by rebaseline.html, which lets you rebaselines expected
882         failures, but the new view is not fully integrated into
883         garden-o-matic.html
884
885         More patches will be required to make this stuff fully working, but
886         this patch was already somewhat spiraling out of control.  Hopefully
887         this patch will serve as a good starting point for further development.
888
889         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers: Added.
890         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.js: Added.
891         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers/rebaseline.js: Added.
892         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
893         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
894         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
895         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/rebaseline.html: Added.
896         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
897         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
898         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
899         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results.js:
900         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results_unittests.js: Added.
901
902 2011-08-16  Chang Shu  <cshu@webkit.org>
903
904         Support reset in WebCore::Internals
905         https://bugs.webkit.org/show_bug.cgi?id=66307
906
907         Reviewed by Dimitri Glazkov.
908
909         Added call to resetInternalsObject in DRT.
910
911         * DumpRenderTree/chromium/TestShell.cpp:
912         (TestShell::resetTestController):
913         * DumpRenderTree/mac/DumpRenderTree.mm:
914         (resetWebViewToConsistentStateBeforeTesting):
915         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
916         (WebCore::WebPage::resetSettings):
917
918 2011-08-17  Alexis Menard  <alexis.menard@openbossa.org>
919
920         Add a new build slave for the Qt port on Mac OS SnowLeopard.
921         https://bugs.webkit.org/show_bug.cgi?id=66392
922
923         Modify the config file to include the new build slave.
924
925         Reviewed by Adam Roben.
926
927         * BuildSlaveSupport/build.webkit.org-config/config.json:
928
929 2011-08-17  Sam White  <samuel.white@rochester.edu>
930
931         AccessibilityObject levels are inconsistent
932         https://bugs.webkit.org/show_bug.cgi?id=66180
933         
934         Added the ability to get numeric attribute values using numberAttributeValue. This
935         function complements the existing stringAttributeValue and boolAttributeValue functions.
936         The addition of numberAttributeValue was necessary because the stringAttributeValue
937         function does a type check and will only return strings. This limitation made it
938         impossible to get values for attributes that returned an NSNumber.
939
940         Reviewed by Chris Fleizach.
941
942         * DumpRenderTree/AccessibilityUIElement.cpp:
943         (numberAttributeValueCallback):
944         (AccessibilityUIElement::getJSClass):
945         * DumpRenderTree/AccessibilityUIElement.h:
946         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
947         (AccessibilityUIElement::numberAttributeValue):
948         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
949         (AccessibilityUIElement::numberAttributeValue):
950         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
951         (AccessibilityUIElement::numberAttributeValue):
952
953 2011-08-17  Adam Roben  <aroben@apple.com>
954
955         Tell Trac logs always to display all specified revisions in a single page
956
957         Trac imposes a default limit of 100 revisions per log page. We need to tell it to allow more
958         revisions than that.
959
960         Fixes <http://webkit.org/b/66373> Links to Trac from TestFailures page don't always show all
961         relevant revisions
962
963         Reviewed by Daniel Bates.
964
965         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
966         (trac.logURL): Add a limit parameter to the log URL that allows all revisions to be seen in
967         a single page.
968
969         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js:
970         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js:
971         Updated tests for the above.
972
973 2011-08-17  Adam Roben  <aroben@apple.com>
974
975         Fix TestFailures's link to file a bug about TestFailures itself
976
977         Fixes <http://webkit.org/b/66387> REGRESSION (r92135): TestFailures page's link to file a
978         bug about itself is broken
979
980         Reviewed by Dan Bates.
981
982         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
983         (ViewController.prototype._domForAuxiliaryUIElements): Added a path separator to separate
984         the host from the path.
985
986 2011-08-17  Adam Roben  <aroben@apple.com>
987
988         Teach TestFailures to ignore unbelievably short test runs
989
990         Fixes <http://webkit.org/b/66385> TestFailures page thinks all tests passed in
991         http://build.webkit.org/builders/Windows%207%20Release%20(Tests)/builds/14956
992
993         Reviewed by Dan Bates.
994
995         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
996         (Builder.prototype.getNumberOfFailingTests): If it looks like all tests passed, but
997         run-webkit-tests took less than 10 seconds to run, assume that some weird error occurred
998         that caused it not to run any tests at all (as happened for a while due to
999         <http://webkit.org/b/64988>). Bumped the cache version to evict old, buggy cached data.
1000
1001         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:
1002         Test for the above.
1003
1004         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:
1005         (LayoutTestResultsLoader.prototype.start): Bumped the cache version to evict old, buggy cached data.
1006
1007 2011-08-16  Adam Barth  <abarth@webkit.org>
1008
1009         Add a CG qualifier similar to the GPU qualifier
1010         https://bugs.webkit.org/show_bug.cgi?id=66359
1011
1012         Reviewed by Eric Seidel.
1013
1014         Once we have a Skia configuration on Chromium Mac, we'll use this CG
1015         qualifier to note that expectations apply only to the CG configuration.
1016
1017         * Scripts/webkitpy/layout_tests/port/chromium.py:
1018         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1019
1020 2011-08-16  Eric Seidel  <eric@webkit.org>
1021
1022         REGRESSION(92717): WinPort needs to parse version information from port_name
1023         https://bugs.webkit.org/show_bug.cgi?id=66325
1024
1025         Unreviewed.  Fixing an exception/typo seen on the bots (and testing to make sure it works).
1026
1027         * Scripts/webkitpy/layout_tests/port/mac.py:
1028         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1029
1030 2011-08-16  Adam Barth  <abarth@webkit.org>
1031
1032         Change webkit-patch analyze-baselines to print in a more unix-friendly way
1033         https://bugs.webkit.org/show_bug.cgi?id=66349
1034
1035         Reviewed by James Robinson.
1036
1037         As requested by jamesr.
1038
1039         * Scripts/webkitpy/tool/commands/rebaseline.py:
1040
1041 2011-08-16  Eric Seidel  <eric@webkit.org>
1042
1043         REGRESSION(92717): WinPort needs to parse version information from port_name
1044         https://bugs.webkit.org/show_bug.cgi?id=66325
1045
1046         Reviewed by Adam Barth.
1047
1048         WinPort didn't have any port_name parsing logic.
1049         Seemed it was best to just share the logic from MacPort.
1050         Sharing the logic from MacPort seemed easiest with a shared superclass.
1051         Once I created ApplePort (the superclass) there was a bunch of logic to share.
1052         I found LeakDetector was just in the way when switching back and forth
1053         between win.py and mac.py so I moved it into its own file.
1054
1055         The only logic change here is that WinPort should now be
1056         able to parse port_name values like MacPort (and other ports)
1057         can.  The fact that ports do this in their constructors is
1058         wrong and a source of many bugs.  But at least now WinPort
1059         matches the status-quo.
1060
1061         * Scripts/webkitpy/layout_tests/port/apple.py: Added.
1062         * Scripts/webkitpy/layout_tests/port/leakdetector.py: Added.
1063         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py: Added.
1064         * Scripts/webkitpy/layout_tests/port/mac.py:
1065         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1066         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1067         * Scripts/webkitpy/layout_tests/port/win.py:
1068         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
1069
1070 2011-08-16  Adam Barth  <abarth@webkit.org>
1071
1072         Add webkit-patch analyze-baselines, as requested by jamesr.
1073
1074         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
1075         * Scripts/webkitpy/tool/commands/rebaseline.py:
1076
1077 2011-08-16  Adam Barth  <abarth@webkit.org>
1078
1079         Fold bulk-optimize-baselines into optimize-baselines
1080         https://bugs.webkit.org/show_bug.cgi?id=66345
1081
1082         Reviewed by James Robinson.
1083
1084         bulk-optimize-baselines is now a superset of optimize-baselines, so
1085         they can be combined.
1086
1087         * Scripts/webkitpy/tool/commands/rebaseline.py:
1088
1089 2011-08-16  Adam Barth  <abarth@webkit.org>
1090
1091         Move chromium-mac to chromium-cg-mac to prepare for Skia switchover
1092         https://bugs.webkit.org/show_bug.cgi?id=66334
1093
1094         Reviewed by Tony Chang.
1095
1096         This patch moves us closer to switching the Chromium port from
1097         CoreGraphics to Skia.  This patch teaches our tools that the current
1098         Chromium Mac configuration is actually chromium-cg-mac, which makes
1099         room for a future chromium-mac configuration that uses Skia.
1100
1101         Shortly after this patch lands, I'll do a server-side move of the
1102         chromium-mac and chromium-mac-leopard directories to chromium-cg-mac
1103         and chromium-cg-mac-leopard.
1104
1105         * BuildSlaveSupport/build.webkit.org-config/config.json:
1106         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
1107         * Scripts/webkitpy/common/config/build.py:
1108         * Scripts/webkitpy/common/config/build_unittest.py:
1109         * Scripts/webkitpy/layout_tests/port/base.py:
1110         * Scripts/webkitpy/layout_tests/port/builders.py:
1111         * Scripts/webkitpy/layout_tests/port/chromium.py:
1112         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1113         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1114         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1115         * Scripts/webkitpy/layout_tests/port/factory.py:
1116         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1117         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1118         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1119         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
1120         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
1121         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1122         * TestResultServer/static-dashboards/flakiness_dashboard.html:
1123
1124 2011-08-16  Dimitri Glazkov  <dglazkov@chromium.org>
1125
1126         garden-o-matic frontend needs a friendly relative time description method.
1127         https://bugs.webkit.org/show_bug.cgi?id=66324
1128
1129         Reviewed by Adam Barth.
1130
1131         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Added base.relativizeTime method.
1132         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Added unit tests.
1133         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Wired up Time widget to use it.
1134
1135 2011-08-16  Dimitri Glazkov  <dglazkov@chromium.org>
1136
1137         Summary view should not add multiple entries for the same test failure.
1138         https://bugs.webkit.org/show_bug.cgi?id=66318
1139
1140         Reviewed by Adam Barth.
1141
1142         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Added a simplistic updating button.
1143         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added ways to check for
1144             equality of ui.notifications.FailingTest, and whether ui.notifications.TestFailures already contains a given failure analysis.
1145         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added tests.
1146
1147 2011-08-16  Adam Roben  <aroben@apple.com>
1148
1149         Teach TestFailures that tests that have failed or passed many times in a row are not flaky
1150
1151         The basic strategy here is that once a test has failed or passed many times in a row we
1152         never again consider it as a possibly flaky test. It's a simple strategy but seems to result
1153         in many fewer false positives than our current behavior.
1154
1155         Fixes <http://webkit.org/b/66327> TestFailures page considers far too many tests to be
1156         flaky, including tests that failed for a while but then were fixed
1157
1158         Reviewed by Dan Bates.
1159
1160         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js:
1161         (FlakyLayoutTestDetector): Initialize new _buildCount property, which is used to track the
1162         number of non-too-many-failure builds we've seen.
1163         (FlakyLayoutTestDetector.prototype.incorporateTestResults): Don't track tests which haven't
1164         failed in the _maximumFailOrPassCount most recent builds. For other not-yet-considered-flaky
1165         tests, keep track of how many times they have passed or failed in a row. If they pass or
1166         fail more than _maximumFailOrPassCount times, consider them to be non-flaky. (Once a test is
1167         considered flaky it doesn't matter how many times it passes or fails.)
1168
1169         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector_unittests.js:
1170         Added tests for the above.
1171
1172 2011-08-16  Dimitri Glazkov  <dglazkov@chromium.org>
1173
1174         garden-o-matic needs a summary view with actions for each problem.
1175         https://bugs.webkit.org/show_bug.cgi?id=66144
1176
1177         Reviewed by Adam Barth.
1178
1179         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html: Added notifications tests.
1180         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Added.
1181         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added.
1182         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added.
1183         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css: Added.
1184         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Added.
1185
1186 2011-08-16  Dean Jackson  <dino@apple.com>
1187
1188         Adding Ted "hober" O'Connor as a non-committing contributor.
1189
1190         * Scripts/webkitpy/common/config/committers.py:
1191
1192 2011-08-16  Adam Roben  <aroben@apple.com>
1193
1194         Teach TestFailures how to interpret unfinished test runs
1195
1196         Fixes <http://webkit.org/b/66309> TestFailures thinks all tests passed in
1197         http://build.webkit.org/builders/Lion%20Intel%20Debug%20(Tests)/builds/136
1198
1199         Reviewed by David Kilzer.
1200
1201         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
1202         (Builder.prototype.getNumberOfFailingTests): Look for "isFinished" in the layout-test step
1203         rather than "isStarted" so that we don't count builds for which the test run never finished.
1204         Bumped the cache version to evict old, buggy cached data.
1205
1206         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:
1207         Added a test for the above, and made a somewhat synthetic test more realistic by including
1208         more of the actual JSON data from build.webkit.org.
1209
1210         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:
1211         (LayoutTestResultsLoader.prototype.start): Bumped the cache version to evict old, buggy
1212         cached data.
1213
1214 2011-08-16  Adam Roben  <aroben@apple.com>
1215
1216         Make Apple's Windows port fall back to Lion results instead of SnowLeopard
1217
1218         Apple's Windows port now uses Lion-era versions of CoreFoundation, ICU, etc., so in theory
1219         should match Lion's behavior.
1220
1221         Fixes <http://webkit.org/b/66302> Apple's Windows port matches Lion for some test results,
1222         but doesn't use Lion results
1223
1224         Reviewed by David Kilzer.
1225
1226         * Scripts/old-run-webkit-tests:
1227         (expectedDirectoryForTest):
1228         * Scripts/webkitpy/layout_tests/port/win.py:
1229         (WinPort.baseline_search_path):
1230         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
1231         (WinPortTest.test_baseline_search_path):
1232         Replaced mac-snowleopard with mac-lion.
1233
1234         * Scripts/webkitpy/common/config/build.py:
1235         (_should_file_trigger_build): Added an entry for the LayoutTests/platform/mac-lion
1236         directory, which all Apple Mac platforms and Apple Win platforms could potentially use
1237         results from. Removed Apple Win from being affected by mac-snowleopard changes, since it
1238         will no longer look there for results.
1239
1240         * Scripts/webkitpy/common/config/build_unittest.py:
1241         (ShouldBuildTest.test_should_build): Tests for the above changes.
1242
1243 2011-08-16  Dean Jackson  <dino@apple.com>
1244
1245         Move me from contributor to reviewer.
1246
1247         * Scripts/webkitpy/common/config/committers.py:
1248
1249 2011-08-15  Dimitri Glazkov  <dglazkov@chromium.org>
1250
1251         garden-o-matic frontend needs model.commitDataForRevisionRange function.
1252         https://bugs.webkit.org/show_bug.cgi?id=66252
1253
1254         Reviewed by Adam Barth.
1255
1256         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js: Added commitDataForRevisionRange method.
1257         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js: Added tests.
1258
1259 2011-08-15  Dimitri Glazkov  <dglazkov@chromium.org>
1260
1261         garden-o-matic frontend needs a generic way to track updates.
1262         https://bugs.webkit.org/show_bug.cgi?id=66245
1263
1264         Reviewed by Adam Barth.
1265
1266         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Added UpdateTracker.
1267         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Added tests.
1268
1269 2011-08-15  Adam Roben  <aroben@apple.com>
1270
1271         Teach TestWebKitAPI/gtest how to print JavaScript failures nicely
1272
1273         Failures now give output of the form: foo should be bar but is baz
1274
1275         Fixes <http://webkit.org/b/66240> It's hard to tell what the actual result of a failed JS
1276         test is in TestWebKitAPI's output
1277
1278         Reviewed by David Levin.
1279
1280         * TestWebKitAPI/JavaScriptTest.cpp:
1281         (TestWebKitAPI::JavaScriptCallbackContext::JavaScriptCallbackContext): Removed now-unused
1282         members.
1283         (TestWebKitAPI::javaScriptCallback): Changed to just store the result string in the context
1284         object, rather than doing any testing of it here.
1285         (TestWebKitAPI::runJSTest): Made this function a gtest predicate-formatter. This allows us
1286         to use a pretty error message when the test fails.
1287
1288         * TestWebKitAPI/JavaScriptTest.h: Changed runJSTest to a predicate-formatter, and added nice
1289         gtest-style macros that wrap it.
1290
1291         * TestWebKitAPI/Test.h: Removed now-unused TEST_ASSERT_RETURN.
1292
1293         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
1294         (TestWebKitAPI::TEST): Changed to use the new macros.
1295
1296         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
1297         (TestWebKitAPI::createSessionStateContainingFormData): Ditto. Note that this function no
1298         longer returns 0 when the JS test fails. That shouldn't have any effect on whether or not
1299         the test passes, though. Returning early seems to have been an unnecessary optimization.
1300
1301         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
1302         (TestWebKitAPI::TEST): Changed to use the new macros.
1303
1304 2011-08-15  Eric Seidel  <eric@webkit.org>
1305
1306         Move the Leaks bot back to ORWT until I can fix LeaksViewer regressions filed by Adam Roben in bug 66227 and 66228.
1307
1308         Unreviewed.
1309
1310         * Scripts/run-webkit-tests:
1311         (usingLeaks):
1312         (useNewRunWebKitTests):
1313
1314 2011-08-14  Adam Barth  <abarth@webkit.org>
1315
1316         Switch results detail view over to new-style object-oriented UI widgets
1317         https://bugs.webkit.org/show_bug.cgi?id=66200
1318
1319         Reviewed by Dimitri Glazkov.
1320
1321         This patch replaces my goofy template-based UI for the results
1322         comparison screen with new object-oriented UI widgets.
1323
1324         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1325         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
1326         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
1327         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
1328         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
1329         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results.js: Added.
1330         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
1331
1332 2011-08-13  Dimitri Glazkov  <dglazkov@chromium.org>
1333
1334         garden-o-matic's analyzeUnexpectedFailures needs a completion callback.
1335         https://bugs.webkit.org/show_bug.cgi?id=66166
1336
1337         Also changed base.RequestTracker to:
1338         a) fire callback immediately if requestsInFlight is 0;
1339         b) not barf if callback is not supplied.
1340
1341         Reviewed by Adam Barth.
1342
1343         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js: Started using completion callback.
1344         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js: Added completion callback.
1345         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Changed RequestTracker.
1346         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittest.js: Added unit tests.
1347
1348 2011-08-12  Mark Rowe  <mrowe@apple.com>
1349
1350         Be more forward-looking in the choice of compiler.
1351
1352         Rubber-stamped by Jon Honeycutt.
1353
1354         * DumpRenderTree/mac/Configurations/CompilerVersion.xcconfig:
1355         * MiniBrowser/Configurations/CompilerVersion.xcconfig:
1356         * TestWebKitAPI/Configurations/CompilerVersion.xcconfig:
1357         * WebKitTestRunner/Configurations/CompilerVersion.xcconfig:
1358
1359 2011-08-12  Sadrul Habib Chowdhury  <sadrul@chromium.org>
1360
1361         DRT: Add support for gesture events.
1362         https://bugs.webkit.org/show_bug.cgi?id=66105
1363
1364         Reviewed by Darin Fisher.
1365
1366         * DumpRenderTree/chromium/EventSender.cpp:
1367         (EventSender::EventSender):
1368         (EventSender::gestureScrollBegin):
1369         (EventSender::gestureScrollEnd):
1370         (EventSender::gestureTap):
1371         (EventSender::gestureEvent):
1372         * DumpRenderTree/chromium/EventSender.h:
1373
1374 2011-08-12  Andy Estes  <aestes@apple.com>
1375
1376         allowRoundingHacksCallback uses the wrong argument for 'thisObject'.
1377         https://bugs.webkit.org/show_bug.cgi?id=66158
1378
1379         Reviewed by Dan Bernstein.
1380
1381         * DumpRenderTree/LayoutTestController.cpp:
1382         (allowRoundingHacksCallback): The third argument is the 'this'
1383         JSObjectRef, not the second.
1384
1385 2011-08-12  Andy Estes  <aestes@apple.com>
1386
1387         Cancel in onbeforeunload dialog sometime causes a button to stop working.
1388         https://bugs.webkit.org/show_bug.cgi?id=26211
1389
1390         Reviewed by Alexey Proskuryakov.
1391
1392         Implement a new LayoutTestController method that a test can call to set
1393         the return value of DumpRenderTree's beforeunload UI delegate.
1394
1395         * DumpRenderTree/LayoutTestController.cpp:
1396         (LayoutTestController::LayoutTestController): Initialize
1397         m_shouldStayOnPageAfterHandlingBeforeUnload.
1398         (setShouldStayOnPageAfterHandlingBeforeUnloadCallback): Call
1399         LayoutTestController::setShouldStayOnPageAfterHandlingBeforeUnload().
1400         (LayoutTestController::staticFunctions): Register
1401         'setShouldStayOnPageAfterHandlingBeforeUnload' as a static function.
1402         * DumpRenderTree/LayoutTestController.h: 
1403         (LayoutTestController::shouldStayOnPageAfterHandlingBeforeUnload):
1404         (LayoutTestController::setShouldStayOnPageAfterHandlingBeforeUnload):
1405         * DumpRenderTree/chromium/LayoutTestController.cpp:
1406         (LayoutTestController::LayoutTestController): Initialize
1407         m_shouldStayOnPageAfterHandlingBeforeUnload and bind
1408         'setShouldStayOnPageAfterHandlingBeforeUnload' to its c++ setter.
1409         (LayoutTestController::reset): Reset
1410         m_shouldStayOnPageAfterHandlingBeforeUnload to false.
1411         (LayoutTestController::setShouldStayOnPageAfterHandlingBeforeUnload):
1412         Set m_shouldStayOnPageAfterHandlingBeforeUnload to the value passed in
1413         from JavaScript.
1414         * DumpRenderTree/chromium/LayoutTestController.h:
1415         (LayoutTestController::shouldStayOnPageAfterHandlingBeforeUnload):
1416         * DumpRenderTree/chromium/WebViewHost.cpp:
1417         (WebViewHost::runModalBeforeUnloadDialog): Add the correct logging and
1418         return the inverse of
1419         LayoutTestController::shouldStayOnPageAfterHandlingBeforeUnload().
1420         * DumpRenderTree/mac/UIDelegate.mm:
1421         (-[UIDelegate webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:]): Ditto.
1422         * DumpRenderTree/win/UIDelegate.cpp:
1423         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage): Ditto.
1424         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1425         Define setShouldStayOnPageAfterHandlingBeforeUnload().
1426         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1427         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue): Post a message
1428         to the Test Controller telling it what value it should return in its
1429         onbeforeunload UI delegate.
1430         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1431         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1432         (WTR::LayoutTestController::setShouldStayOnPageAfterHandlingBeforeUnload):
1433         Call InjectedBundle::postNewBeforeUnloadReturnValue().
1434         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1435         * WebKitTestRunner/TestController.cpp:
1436         (WTR::TestController::TestController): Initialize
1437         m_beforeUnloadReturnValue to true.
1438         (WTR::runBeforeUnloadConfirmPanel): Add the correct logging and return
1439         the value of TestController::beforeUnloadReturnValue().
1440         (WTR::TestController::resetStateToConsistentValues): Reset
1441         m_beforeUnloadReturnValue to true.
1442         * WebKitTestRunner/TestController.h:
1443         (WTR::TestController::beforeUnloadReturnValue):
1444         (WTR::TestController::setBeforeUnloadReturnValue):
1445         * WebKitTestRunner/TestInvocation.cpp:
1446         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Handle the
1447         message posted from the injected bundle by retrieving the message body
1448         as a WKBoolean and calling TestController::setBeforeUnloadReturnValue().
1449
1450 2011-08-12  Sam Weinig  <sam@webkit.org>
1451
1452         Move compiler specific macros to their own header
1453         https://bugs.webkit.org/show_bug.cgi?id=66119
1454
1455         Reviewed by Anders Carlsson.
1456
1457         * DumpRenderTree/ForwardingHeaders/wtf/Compiler.h: Added.
1458
1459 2011-08-11  Dimitri Glazkov  <dglazkov@chromium.org>
1460
1461         Add a way to extend DOM objects in garden-o-matic.
1462         https://bugs.webkit.org/show_bug.cgi?id=66096
1463
1464         Reviewed by Adam Barth.
1465
1466         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Added base.extends.
1467         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Added tests.
1468
1469 2011-08-11  MORITA Hajime  <morrita@google.com>
1470
1471         [Chromium][DRT] editing/spelling/spelling-backspace-between-lines.html fails
1472         https://bugs.webkit.org/show_bug.cgi?id=45438
1473
1474         Reviewed by Kent Tamura.
1475
1476         MockSpellCheck was assuming the input of spellCheckWord() is a word.
1477         But it can be a series of word. This change made spellCheckWord()
1478         understand simple word boundary which appears in tests.
1479         
1480         * DumpRenderTree/chromium/MockSpellCheck.cpp:
1481         (MockSpellCheck::spellCheckWord):
1482
1483 2011-08-11  Mark Rowe  <mrowe@apple.com>
1484
1485         Rework some Makefile logic to remove a double-negative.
1486
1487         Reviewed by Jon Honeycutt.
1488
1489         * DumpRenderTree/mac/PerlSupport/Makefile:
1490
1491 2011-08-11  Anders Carlsson  <andersca@apple.com>
1492
1493         Add a FIXME.
1494
1495         * TestWebKitAPI/TestsController.cpp:
1496         (TestWebKitAPI::TestsController::TestsController):
1497
1498 2011-08-11  Anders Carlsson  <andersca@apple.com>
1499
1500         Initialize threading before running any tests
1501         https://bugs.webkit.org/show_bug.cgi?id=66112
1502
1503         Reviewed by Adam Barth.
1504
1505         * TestWebKitAPI/TestsController.cpp:
1506         (TestWebKitAPI::TestsController::TestsController):
1507
1508 2011-08-11  Adam Barth  <abarth@webkit.org>
1509
1510         Add unexpected-passes.html to TestFailures for marking tests as passing
1511         https://bugs.webkit.org/show_bug.cgi?id=66102
1512
1513         Reviewed by Dimitri Glazkov.
1514
1515         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1516         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
1517             - Move some code into the library so it can be shared.
1518         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
1519         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
1520         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
1521             - Add round-trip unit tests.
1522         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.html: Added.
1523         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.js: Added.
1524             - I'm not entirely sure this feature should remain a separate HTML
1525               file, but it seemed better than cluttering up the main HTML file
1526               with too much extra stuff.
1527         * Scripts/webkitpy/tool/servers/gardeningserver.py:
1528         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1529             - The gardening server couldn't handle adding PASS expectations.  Now it can.
1530
1531 2011-08-11  Eric Seidel  <eric@webkit.org>
1532
1533         NRWT has wrong fallback order for Mac now that Lion exists
1534         https://bugs.webkit.org/show_bug.cgi?id=66093
1535
1536         Reviewed by Adam Barth.
1537
1538         ORWT used a different system for fallback orders than NRWT did.
1539         I moved win.py to match ORWT fallback orders in bug 64486.
1540         This bug moves mac.py to match ORWT fallback order
1541         and adds 'lion' as a supported OS version.
1542
1543         Because ChromiumMac shares OS version detection code with AppleMac
1544         this also added support for 'lion' to chromium mac.  Hopefully that's a good thing.
1545
1546         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1547         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1548         * Scripts/webkitpy/layout_tests/port/mac.py:
1549         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1550         * Scripts/webkitpy/layout_tests/port/win.py:
1551
1552 2011-08-11  Adam Barth  <abarth@webkit.org>
1553
1554         Update test results now that we use absolute URLs.
1555
1556         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js:
1557
1558 2011-08-11  Adam Barth  <abarth@webkit.org>
1559
1560         garden-o-matic should be able to determine when tests unexpectedly pass
1561         https://bugs.webkit.org/show_bug.cgi?id=66092
1562
1563         Reviewed by Dimitri Glazkov.
1564
1565         This patch just contains the library methods for extracting this
1566         information.  I'll add some UI in a subsequent patch.
1567
1568         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
1569         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js:
1570
1571 2011-08-11  Dimitri Glazkov  <dglazkov@chromium.org>
1572
1573         New expectation entries should be placed next to existing ones.
1574         https://bugs.webkit.org/show_bug.cgi?id=66066
1575
1576         Reviewed by Adam Barth.
1577
1578         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Added the notion of insertion point,
1579             which is computed as the last found reference to the same test.
1580         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added and adjusted unit tests.
1581
1582 2011-08-11  Dimitri Glazkov  <dglazkov@chromium.org>
1583
1584         Unreviewed, rolling out r92847.
1585         http://trac.webkit.org/changeset/92847
1586         https://bugs.webkit.org/show_bug.cgi?id=65986
1587
1588         Broke check-webkit-style
1589
1590         * Scripts/webkitpy/style/checker.py:
1591         * Scripts/webkitpy/style/checker_unittest.py:
1592
1593 2011-08-11  Dimitri Glazkov  <dglazkov@chromium.org>
1594
1595         Unreviewed, rolling out r92847.
1596         http://trac.webkit.org/changeset/92847
1597         https://bugs.webkit.org/show_bug.cgi?id=65986
1598
1599         Broke check-webkit-style
1600
1601         * Scripts/webkitpy/style/checker.py:
1602         * Scripts/webkitpy/style/checker_unittest.py:
1603
1604 2011-08-11  Pierre Rossi  <pierre.rossi@gmail.com>
1605
1606         [Qt] autotests shouldn't require config.h in the style check
1607         https://bugs.webkit.org/show_bug.cgi?id=65986
1608
1609         Remove the include rules from the style-check for Qt tests.
1610         Since for the most part it's just a matter of using the
1611         API provided by QtWebKit, enforcing the WebCore set of rules
1612         only seems to make sense in the case of MIMESniffing.
1613
1614         Reviewed by Benjamin Poulain.
1615
1616         * Scripts/webkitpy/style/checker.py:
1617         * Scripts/webkitpy/style/checker_unittest.py:
1618
1619 2011-08-11  Zsolt Fehér  <h490267@stud.u-szeged.hu>
1620
1621         [WK2] Implement waitForPolicyDelegate
1622         https://bugs.webkit.org/show_bug.cgi?id=42330
1623
1624         Reviewed by Csaba Osztrogonác.
1625
1626         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1627         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1628         (WTR::navigationTypeToString):
1629         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
1630         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1631         (WTR::LayoutTestController::LayoutTestController):
1632         (WTR::LayoutTestController::setCustomPolicyDelegate):
1633         (WTR::LayoutTestController::waitForPolicyDelegate):
1634         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1635         (WTR::LayoutTestController::isPolicyDelegateEnabled):
1636         (WTR::LayoutTestController::isPolicyDelegatePermissive):
1637
1638 2011-08-11  Adam Barth  <abarth@webkit.org>
1639
1640         rebaseline-expectations should use the release bots, not the debug
1641         bots.  The debug bots don't all run all the tests.  Also, delay
1642         updating test_expectations a long as possible to avoid clearing out
1643         lines that we'll need for other ports.
1644
1645         * Scripts/webkitpy/layout_tests/port/builders.py:
1646         * Scripts/webkitpy/tool/commands/rebaseline.py:
1647         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1648
1649 2011-08-10  Ryosuke Niwa  <rniwa@webkit.org>
1650
1651         r92792 inadvertently removed PlatformSpecificScheduler for all Snow Leopard bots.
1652         Revert it partially so that the remaining Snow Leopard bots can fulfill their duty.
1653
1654         * BuildSlaveSupport/build.webkit.org-config/config.json:
1655
1656 2011-08-10  Eric Seidel  <eric@webkit.org>
1657
1658         new-run-webkit-test's WinPort has no fallback logic
1659         https://bugs.webkit.org/show_bug.cgi?id=64486
1660
1661         Unreviewed.
1662
1663         Turns out that we've long had a subtle bug whereby if you didn't
1664         already have DumpRenderTree built, we might end up running unsupported tests
1665         because the DumpRenderTree --print-supported-features check would silently fail.
1666
1667         When I moved the call from using popen to using Executive.run_command, this silent
1668         failure became noisy.  (Breaking some bots.)
1669
1670         This re-orders our steps so that we always build DRT before collecting expectations,
1671         as well as adds a warning message when DumpRenderTree can't be found.
1672
1673         * Scripts/webkitpy/layout_tests/port/webkit.py:
1674         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1675
1676 2011-08-10  Eric Seidel  <eric@webkit.org>
1677
1678         new-run-webkit-test's WinPort has no fallback logic
1679         https://bugs.webkit.org/show_bug.cgi?id=64486
1680
1681         Unreviewed.  Fix test-webkitpy under Python 2.5.
1682
1683         * Scripts/webkitpy/layout_tests/port/win.py:
1684
1685 2011-08-10  Benjamin Poulain  <benjamin@webkit.org>
1686
1687         [Qt][WK2] MiniBrowser is firing twice the QDesktopWebView::mousePressEvent method
1688         https://bugs.webkit.org/show_bug.cgi?id=65875
1689
1690         Reviewed by Kenneth Rohde Christiansen.
1691
1692         For some reason, QWidget send fake mouse event on some platform, under certains conditions.
1693
1694         This causes mouse events to be sent twice in some cases. We work around the problem
1695         by defining the first touch point to be a primary touch point (case which hit some
1696         weird condition in QWidget, skipping the generation of fake mouse events).
1697
1698         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1699         (MiniBrowserApplication::notify):
1700
1701 2011-08-10  David Hyatt  <hyatt@apple.com>
1702
1703         https://bugs.webkit.org/show_bug.cgi?id=66004
1704
1705         Remove the regions and exclusions bots and also the flags in build-webkit, since I'm just turning
1706         the code on by default.
1707
1708         Reviewed by Adam Roben.
1709
1710         * BuildSlaveSupport/build.webkit.org-config/config.json:
1711         * Scripts/build-webkit:
1712
1713 2011-08-10  Oliver Hunt  <oliver@apple.com>
1714
1715         JSEvaluteScript does not return the correct object when given JSONP data
1716         https://bugs.webkit.org/show_bug.cgi?id=66003
1717
1718         Reviewed by Gavin Barraclough.
1719
1720         Add a test case.
1721
1722         * DumpRenderTree/mac/DumpRenderTree.mm:
1723         (testStringByEvaluatingJavaScriptFromString):
1724
1725 2011-08-10  Eric Seidel  <eric@webkit.org>
1726
1727         WIN: NRWT runs compositing tests on configurations that don't support compositing
1728         https://bugs.webkit.org/show_bug.cgi?id=64472
1729
1730         Reviewed by Adam Barth.
1731
1732         I think the code was just wrong.  It was never splitting the string
1733         into list pieces before.
1734         I've now tested the supported_features code and theoretically it
1735         should now work with Windows DRT.
1736
1737         I also made the list-lookup functions always return lists, to make
1738         it possible to clean up the list-transform code in the future
1739         (I opted not to do that cleanup in this patch, but at least now
1740         both types of feature lookup functions match return types.)
1741
1742         * Scripts/webkitpy/layout_tests/port/webkit.py:
1743         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1744
1745 2011-08-10  Eric Seidel  <eric@webkit.org>
1746
1747         Clean up ChromiumDriver a little
1748         https://bugs.webkit.org/show_bug.cgi?id=65995
1749
1750         Unreviewed.
1751
1752         Fix NRWT for chromium.  Silly python.
1753
1754         * Scripts/webkitpy/layout_tests/port/chromium.py:
1755
1756 2011-08-10  Eric Seidel  <eric@webkit.org>
1757
1758         Clean up ChromiumDriver a little
1759         https://bugs.webkit.org/show_bug.cgi?id=65995
1760
1761         Reviewed by Adam Barth.
1762
1763         - We no longer support threading, so remove threading specific code.
1764         - Add FIXMEs about using ServerProcess instead.
1765         - Condense option-mapping if-cascade into a for loop.
1766         - Unindent long if blocks by using early return.
1767         - Unwrap lines which are needlessly wrapped.
1768
1769         There should be no functional changes here, just code cleanup/dead-code removal.
1770
1771         * Scripts/webkitpy/layout_tests/port/chromium.py:
1772
1773 2011-08-10  Dimitri Glazkov  <dglazkov@chromium.org>
1774
1775         Unmuddle construction options for TestConfiguration.
1776         https://bugs.webkit.org/show_bug.cgi?id=65988
1777
1778         The TestConfiguration instance is now constructed only using actual values.
1779         Port-based construction is split into a "from_port" class method.
1780
1781         Reviewed by Eric Seidel.
1782
1783         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Added TestConfiguration.from_port
1784         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Adjusted code to accommodate the change.
1785         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Ditto.
1786         * Scripts/webkitpy/layout_tests/port/base.py: Ditto.
1787         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Ditto.
1788
1789 2011-08-10  Eric Seidel  <eric@webkit.org>
1790
1791         Leaks bot shows python logging prefixes as part of summary display
1792         https://bugs.webkit.org/show_bug.cgi?id=65931
1793
1794         Reviewed by Adam Barth.
1795
1796         The big part of this change is adding a unittesting system for
1797         master.cfg, so mere-mortals can make changes to build.webkit.org
1798         with greatly-reduced risk of breaking the world.
1799
1800         Turns out that in typing up my trival logging fix I made 2 typos,
1801         so hopefully the hour spent getting master.cfg to load was worth it. :)
1802
1803         I also tried to make mastercfg_unittest run as part of test-webkitpy
1804         but right now test-webkitpy requires that unittest files be located in
1805         a module-name-compatible directory.  'build.webkit.org-config' is not
1806         a valid module name.
1807
1808         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1809          - Fixed _parseNewRunWebKitTestsOutput to strip NRWT's python formatter prefix
1810            by using a new _strip_python_logging_prefix function.
1811          - Also fixed this function to file to work with a more modern
1812            simplejson version (which returns unicode objects instead of str objects)
1813            and filed a related bug with buildbot.net due to their handling of unicode builder names.
1814         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Added.
1815          - BuildBotConfigLoader is a huge pile of code just to get master.cfg to load.
1816          - The actual tiny unittest of the new _parseNewRunWebKitTestsOutput logic.
1817         * Scripts/webkitpy/thirdparty/__init__.py:
1818          - Add autoinstallation of buildbot (and jinja2) for use by mastercfg_unittest.py
1819
1820 2011-08-09  Dimitri Glazkov  <dglazkov@chromium.org>
1821
1822         garden-o-matic should extrapolate failures given a set of known results
1823         https://bugs.webkit.org/show_bug.cgi?id=65882
1824
1825         Reviewed by Adam Barth.
1826
1827         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Spuriously covered my old sins.
1828         * Scripts/webkitpy/layout_tests/port/builders.py: Augmented builders dictionary to contain build coverage specifiers,
1829             adjusted all call sites.
1830         * Scripts/webkitpy/tool/servers/gardeningserver.py: Added BuildCoverageExtrapolator, a thing that
1831             makes wider net for specific failures.
1832         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Added unit tests.
1833
1834 2011-08-10  Adam Barth  <abarth@webkit.org>
1835
1836         The URL we were computing for retrieving baselines was missing a slash
1837         character because our mocks had an extra slash character.  I've
1838         corrected both the code and the mock.
1839
1840         * Scripts/webkitpy/tool/commands/rebaseline.py:
1841         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1842         * Scripts/webkitpy/tool/mocktool.py:
1843
1844 2011-08-09  Adam Barth  <abarth@webkit.org>
1845
1846         Move the quote mark to the right place.
1847
1848         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
1849
1850 2011-08-09  Adam Barth  <abarth@webkit.org>
1851
1852         garden-o-matic should use huerstics to narrow regression range
1853         https://bugs.webkit.org/show_bug.cgi?id=65948
1854
1855         Reviewed by Dimitri Glazkov.
1856
1857         When analyzing a regression range, if one of the commit messages
1858         mentions the test in question, we now hueristically assume that
1859         revision caused the failure.  (I'm shamelessly stealing this idea from
1860         TestFailures.)
1861
1862         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
1863
1864 2011-07-13  Eric Seidel  <eric@webkit.org>
1865
1866         new-run-webkit-test's WinPort has no fallback logic
1867         https://bugs.webkit.org/show_bug.cgi?id=64486
1868
1869         Reviewed by Adam Roben.
1870
1871         I've tried to write a patch for bug 64439 twice now, and both times
1872         I've ended up re-writing half the port system.  So I'm breaking
1873         things up into smaller pieces, this being the first.
1874
1875         WinPort still does not have any port_name parsing, so when instantiated
1876         with the name "win-xp" (i.e. by the rebaseline server) it will just behave as the 'win' port.
1877         I'll fix this in a second pass when I standardize port_name parsing for all webkit ports.
1878
1879         Otherwise this should "just work" for windows.  I've not been able to test the
1880         version detection on my mac, but the unit tests show the code behaving as designed.
1881
1882         * Scripts/webkitpy/layout_tests/port/win.py:
1883         * Scripts/webkitpy/layout_tests/port/win_unittest.py: Added.
1884
1885 2011-08-09  Adam Barth  <abarth@webkit.org>
1886
1887         Teach build.webkit.org's garden-o-matic how to talk to the local server
1888         https://bugs.webkit.org/show_bug.cgi?id=65940
1889
1890         Reviewed by Dimitri Glazkov.
1891
1892         After this patch, the version of garden-o-matic on build.webkit.org is
1893         fully functional.  It can interact with the local server via CORS.
1894
1895         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
1896         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
1897         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
1898         * Scripts/webkitpy/tool/commands/gardenomatic.py:
1899         * Scripts/webkitpy/tool/servers/gardeningserver.py:
1900
1901 2011-08-09  Adam Barth  <abarth@webkit.org>
1902
1903         Enable CORS for garden-o-matic
1904         https://bugs.webkit.org/show_bug.cgi?id=65936
1905
1906         Reviewed by Dimitri Glazkov.
1907
1908         This patch will allow the hosted instance of garden-o-matic to
1909         communicate with the local server.
1910
1911         * Scripts/webkitpy/tool/servers/gardeningserver.py:
1912         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
1913
1914 2011-08-09  Adam Barth  <abarth@webkit.org>
1915
1916         Upgrade jquery in TestFailures
1917         https://bugs.webkit.org/show_bug.cgi?id=65935
1918
1919         Reviewed by Dimitri Glazkov.
1920
1921         Upgrade to a newer version of jQuery with better support for CORS and CSP.
1922
1923         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1924         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html:
1925         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
1926
1927 2011-08-09  Sheriff Bot  <webkit.review.bot@gmail.com>
1928
1929         Unreviewed, rolling out r92683.
1930         http://trac.webkit.org/changeset/92683
1931         https://bugs.webkit.org/show_bug.cgi?id=65921
1932
1933          "Breaks Qt --minimal build. Revert pending update of the Qt
1934         minimal configuration" (Requested by simathur on #webkit).
1935
1936         * QtTestBrowser/cookiejar.cpp:
1937         (TestBrowserCookieJar::TestBrowserCookieJar):
1938         * QtTestBrowser/launcherwindow.cpp:
1939         (LauncherWindow::createChrome):
1940         (LauncherWindow::setDiskCache):
1941         * QtTestBrowser/main.cpp:
1942         (LauncherApplication::handleUserOptions):
1943         * QtTestBrowser/webpage.cpp:
1944         (WebPage::openUrlInDefaultBrowser):
1945
1946 2011-08-09  Siddharth Mathur  <siddharth.mathur@nokia.com>
1947
1948         [Qt] Simplify code by removing QT_NO_DESKTOPSERVICES and QT_NO_NETWORKDISKCACHE
1949         https://bugs.webkit.org/show_bug.cgi?id=65880
1950
1951         Reviewed by Andreas Kling.
1952
1953         QDesktopServices and QNetworkDiskCache have been around for a while now. Kill flags which 
1954         check for their feature flags. Assume that any reasonable Qt build provides them. 
1955         * QtTestBrowser/cookiejar.cpp:
1956         (TestBrowserCookieJar::TestBrowserCookieJar):
1957         * QtTestBrowser/launcherwindow.cpp:
1958         (LauncherWindow::createChrome):
1959         (LauncherWindow::setDiskCache):
1960         * QtTestBrowser/main.cpp:
1961         (LauncherApplication::handleUserOptions):
1962         * QtTestBrowser/webpage.cpp:
1963         (WebPage::openUrlInDefaultBrowser):
1964
1965 2011-08-09  Adam Barth  <abarth@webkit.org>
1966
1967         BaselineOptimizer created the wrong baseline for fast/js/regexp-overflow.html
1968         https://bugs.webkit.org/show_bug.cgi?id=65891
1969
1970         Reviewed by Eric Seidel.
1971
1972         The problem was that platform/chromium contained a bogus expectation
1973         file that needed to be removed, but by the time we got around to
1974         removing it, we'd already moved the correct baseline into its place.
1975         After this patch, we copy the gold results into memory before
1976         reshuffling things on disk (and we delete bad things before adding good
1977         things).
1978
1979         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
1980         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
1981
1982 2011-08-08  Adam Barth  <abarth@webkit.org>
1983
1984         Chromium Windows bots can't figure out what SVN revision they're running
1985         https://bugs.webkit.org/show_bug.cgi?id=65893
1986
1987         Reviewed by Eric Seidel.
1988
1989         The comment in _engage_awesome_windows_hacks explains why we're making
1990         this change.  It's ugly and rediculous, but this approach seems better
1991         than using shell=True when calling popen.
1992
1993         * Scripts/webkitpy/common/checkout/scm/svn.py:
1994         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1995
1996 2011-08-08  Adam Barth  <abarth@webkit.org>
1997
1998         Remove deduplicate-tests
1999         https://bugs.webkit.org/show_bug.cgi?id=65886
2000
2001         Reviewed by Tony Chang.
2002
2003         This script is redundant with "webkit-patch bulk-optimize-baselines",
2004         which can find many more duplicates than deduplicate-tests because
2005         bulk-optimize-baselines can move results around whereas
2006         deduplicate-tests can only remove results.
2007
2008         * Scripts/deduplicate-tests: Removed.
2009         * Scripts/webkitpy/to_be_moved/deduplicate_tests.py: Removed.
2010         * Scripts/webkitpy/to_be_moved/deduplicate_tests_unittest.py: Removed.
2011
2012 2011-08-08  Adam Barth  <abarth@webkit.org>
2013
2014         scm.delete should delete empty parent directories as well
2015         https://bugs.webkit.org/show_bug.cgi?id=65878
2016
2017         Reviewed by Eric Seidel.
2018
2019         This behavior makes SVN match GIT (which has no concept of empty
2020         directories).  This bug comes up a lot when optimizing baselines, which
2021         often create empty directories when we're able to optimize everything
2022         out of a given folder.
2023
2024         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2025         * Scripts/webkitpy/common/checkout/scm/svn.py:
2026
2027 2011-08-08  Lucas Forschler  <lforschler@apple.com>
2028
2029         Add triggers for Lion WK2 test bots.
2030
2031         Reviewed by Stephanie Lewis.
2032
2033         * BuildSlaveSupport/build.webkit.org-config/config.json:
2034
2035 2011-08-08  Adam Barth  <abarth@webkit.org>
2036
2037         bulk-optimize-baselines should take directories on the command line
2038         https://bugs.webkit.org/show_bug.cgi?id=65879
2039
2040         Reviewed by Dimitri Glazkov.
2041
2042         Passing lists of tests via stdin is a pain.  It's easier if the command
2043         takes a list of tests on the command line, like run-webkit-tests.
2044
2045         * Scripts/webkitpy/tool/commands/rebaseline.py:
2046
2047 2011-08-08  Adam Barth  <abarth@webkit.org>
2048
2049         Deprecate rebaseline-chromium-webkit-tests
2050         https://bugs.webkit.org/show_bug.cgi?id=65873
2051
2052         Reviewed by Dimitri Glazkov.
2053
2054         This script never worked correctly and now is redundant with more
2055         modern infrastructure for rebaselining tests.  This patch deprecates
2056         the script in order to flush out any issues with the new tools.  Once
2057         folks are happy with the new tools, we'll delete this script.
2058
2059         * Scripts/rebaseline-chromium-webkit-tests:
2060
2061 2011-08-08  Dimitri Glazkov  <dglazkov@chromium.org>
2062
2063         garden-o-matic should only touch expectations that need updating.
2064         https://bugs.webkit.org/show_bug.cgi?id=65876
2065
2066         Reviewed by Adam Barth.
2067
2068         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Added reconstitute_only_these to TestExpectationSerializer.list_to_string,
2069             so that a caller could influence which lines to serialize from values.
2070         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added tests.
2071         * Scripts/webkitpy/tool/servers/gardeningserver.py: Started using reconstitute_only_these.
2072         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Added tests.
2073
2074 2011-08-08  Dimitri Glazkov  <dglazkov@chromium.org>
2075
2076         TestExpectationsEditor should return a list of updated expectations.
2077         https://bugs.webkit.org/show_bug.cgi?id=65872
2078
2079         Reviewed by Adam Barth.
2080
2081         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Added a list to store lines that are being updated.
2082         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Changed tests to account for updated lines.
2083
2084 2011-08-08  Jochen Eisinger  <jochen@chromium.org>
2085
2086         Fix SCM webkitpy unit test failures
2087         https://bugs.webkit.org/show_bug.cgi?id=65823
2088
2089         Reviewed by Eric Seidel.
2090
2091         * Scripts/webkitpy/common/checkout/scm/git.py:
2092         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2093
2094 2011-08-08  Eric Seidel  <eric@webkit.org>
2095
2096         Move the --leaks bot back over to NRWT now that I'm back
2097         from vacation and able to debug it.
2098
2099         Unreviewed.
2100
2101         * Scripts/run-webkit-tests:
2102         (usingWebKit2):
2103         (useNewRunWebKitTests):
2104
2105 2011-08-05  Dimitri Glazkov  <dglazkov@chromium.org>
2106
2107         Wire up updating expectations in garden-o-matic.
2108         https://bugs.webkit.org/show_bug.cgi?id=65794
2109
2110         Reviewed by Adam Barth.
2111
2112         * Scripts/webkitpy/layout_tests/port/factory.py: Moved _port_for_builder from rebaseline.py to here, rename to get_from_builder_name.
2113         * Scripts/webkitpy/tool/commands/rebaseline.py: Adapted callsites to new location.
2114         * Scripts/webkitpy/tool/servers/gardeningserver.py: Added GardeningExpectationsUpdater, which knows how to update expectations.
2115         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Added loads of tests.
2116
2117 2011-08-08  Jochen Eisinger  <jochen@chromium.org>
2118
2119         webkit-patch doesn't get along with renamed files
2120         https://bugs.webkit.org/show_bug.cgi?id=48075
2121
2122         Possibly a bit heavy handed - I removed all instances of -C and
2123         changed every instance of -M with '--no-renames' in git.py. This
2124         forces git to not try to tell us about renames at all, which is
2125         ultimately the behaviour we want. The old file is shown deleted,
2126         then the new file is shown added, followed by any changes that
2127         occurred. Also gets rid of the problem where deleting one file
2128         and adding another file which has similar content would
2129         unexpectedly show up as a rename, and fall out of a diff.
2130
2131         Based on a patch by Wyatt Carss.
2132
2133         Reviewed by Eric Seidel.
2134
2135         * Scripts/webkitpy/common/checkout/scm/git.py:
2136
2137 2011-08-07  Sam White  <samuel.white@rochester.edu>
2138
2139         Add the ability to search the AccessibilityObject cache
2140         https://bugs.webkit.org/show_bug.cgi?id=64994
2141         
2142         Added testing support for AccessibilityObject cache searching. Currently,
2143         only the mac platform is full supported and has had API exposed. Other
2144         platforms have only have this new functionality stubbed. Full implementation
2145         is a job suited only for an accessibility expert of each respective platform.
2146
2147         Reviewed by Chris Fleizach.
2148
2149         * DumpRenderTree/AccessibilityUIElement.cpp:
2150         (uiElementForSearchPredicateCallback):
2151         (AccessibilityUIElement::getJSClass):
2152         * DumpRenderTree/AccessibilityUIElement.h:
2153         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2154         (AccessibilityUIElement::uiElementForSearchPredicate):
2155         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2156         (AccessibilityUIElement::uiElementForSearchPredicate):
2157         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2158         (AccessibilityUIElement::uiElementForSearchPredicate):
2159
2160 2011-08-06  Adam Barth  <abarth@webkit.org>
2161
2162         Remove dead code in webkitpy
2163         https://bugs.webkit.org/show_bug.cgi?id=65818
2164
2165         Reviewed by Dimitri Glazkov.
2166
2167         This code was added to support the rebaseline2 command six months ago,
2168         but the rebaseline2 command was never finished and no one else has used
2169         this code since it was landed.  This patch removes the dead code.  If
2170         we revive rebaseline2, then we can revert this patch and recover the
2171         code.  Until then, this code is just dead weight.
2172
2173         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2174         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2175         * Scripts/webkitpy/common/net/testoutput.py: Removed.
2176         * Scripts/webkitpy/common/net/testoutput_unittest.py: Removed.
2177         * Scripts/webkitpy/common/net/testoutputset.py: Removed.
2178         * Scripts/webkitpy/common/net/testoutputset_unittest.py: Removed.
2179         * Scripts/webkitpy/common/system/directoryfileset.py: Removed.
2180         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Removed.
2181         * Scripts/webkitpy/layout_tests/port/base.py:
2182         * Scripts/webkitpy/layout_tests/port/chromium.py:
2183         * Scripts/webkitpy/layout_tests/port/webkit.py:
2184
2185 2011-08-06  Adam Barth  <abarth@webkit.org>
2186
2187         webkit-patch optimize-baselines can't handle promotions to base results directory
2188         https://bugs.webkit.org/show_bug.cgi?id=65819
2189
2190         Reviewed by Dimitri Glazkov.
2191
2192         This bug came up when testing the optimizer on some editing baselines.
2193
2194         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
2195         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
2196
2197 2011-08-06  Adam Barth  <abarth@webkit.org>
2198
2199         Add a small command to optimize baselines in bulk.
2200
2201         * Scripts/webkitpy/tool/commands/rebaseline.py:
2202
2203 2011-08-05  Dimitri Glazkov  <dglazkov@chromium.org>
2204
2205         Fix unit test breakage by plumbing convert_404_to_None in MockWeb.
2206
2207         * Scripts/webkitpy/tool/mocktool.py: Added missing parameter to MockWeb.get_binary
2208
2209 2011-08-05  Dimitri Glazkov  <dglazkov@chromium.org>
2210
2211         Garden-o-matic updateexpectations needs a unit test.
2212         https://bugs.webkit.org/show_bug.cgi?id=65780
2213
2214         Reviewed by Adam Barth.
2215
2216         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Added unit test.
2217
2218 2011-08-05  Anders Carlsson  <andersca@apple.com>
2219
2220         Future proof an Objective-C test
2221         https://bugs.webkit.org/show_bug.cgi?id=65788
2222
2223         Reviewed by Dan Bernstein.
2224
2225         Add isObjectInstanceOf to ObjCController.
2226
2227         * DumpRenderTree/mac/ObjCController.m:
2228         (+[ObjCController isSelectorExcludedFromWebScript:]):
2229         (+[ObjCController webScriptNameForSelector:]):
2230         (-[ObjCController isObject:instanceOf:]):
2231
2232 2011-08-05  Adam Barth  <abarth@webkit.org>
2233
2234         trac.js needs unittests
2235         https://bugs.webkit.org/show_bug.cgi?id=65673
2236
2237         Reviewed by Dimitri Glazkov.
2238
2239         This tests also have somewhat large fixtures.  I've trimmed the example
2240         XML down a bunch while still hitting interesting cases in the parsing.
2241
2242         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
2243         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js: Added.
2244
2245 2011-08-05  Adam Barth  <abarth@webkit.org>
2246
2247         Rebuild rebaseline-chromium-webkit-tests on top of modern infrastructure
2248         https://bugs.webkit.org/show_bug.cgi?id=65759
2249
2250         Reviewed by Dimitri Glazkov.
2251
2252         rebaseline-chromium-webkit-tests doesn't really fit into webkitpy's
2253         architecture, is poorly tested, and has a bunch of quirks.  This patch
2254         rebuilds the core functionality of rebaseline-chromium-webkit-tests on
2255         top of more modern infrastructure.  In the process, we get more code
2256         re-use and better testing.
2257
2258         Once we're satisfied with this new implementation, we can delete the
2259         old implementation.
2260
2261         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
2262         * Scripts/webkitpy/common/net/web.py:
2263         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2264         * Scripts/webkitpy/layout_tests/port/builders.py:
2265         * Scripts/webkitpy/layout_tests/port/chromium.py:
2266         * Scripts/webkitpy/layout_tests/port/factory.py:
2267         * Scripts/webkitpy/layout_tests/port/webkit.py:
2268         * Scripts/webkitpy/tool/commands/rebaseline.py:
2269         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2270
2271 2011-08-05  Anders Carlsson  <andersca@apple.com>
2272
2273         Remove PluginHalter
2274         https://bugs.webkit.org/show_bug.cgi?id=65729
2275
2276         Reviewed by Darin Adler.
2277
2278         Remove call to set the allowed plug-in run time.
2279
2280         * DumpRenderTree/mac/DumpRenderTree.mm:
2281         (resetDefaultsToConsistentValues):
2282
2283 2011-08-05  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>
2284
2285         Unreviewed build fix for Qt-Minimal buildbot
2286
2287         Use ~/.QtTestBrowser for the cookiejar when QDesktopServices
2288         is disabled.
2289
2290         Rubber-stamped by Holger Freyther.
2291
2292         * QtTestBrowser/cookiejar.cpp:
2293         (TestBrowserCookieJar::TestBrowserCookieJar):
2294
2295 2011-08-05  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
2296
2297         [Qt] QtTestBrowser: Add support for saving cookies on disk
2298         https://bugs.webkit.org/show_bug.cgi?id=65328
2299
2300         Simple cookiejar that saves cookies on disk.
2301
2302         Added menu options to clear cookies (Edit->Clear cookies) and
2303         disable disk cookies (Settings->[ ]Save Cookies on Disk).
2304
2305         Option -no-disk-cookies is also available.
2306
2307         Reviewed by Andreas Kling.
2308
2309         * QtTestBrowser/QtTestBrowser.pro:
2310         * QtTestBrowser/cookiejar.cpp: Added.
2311         * QtTestBrowser/cookiejar.h: Added.
2312         * QtTestBrowser/launcherwindow.cpp:
2313         * QtTestBrowser/launcherwindow.h:
2314         * QtTestBrowser/main.cpp:
2315
2316 2011-08-04  Adam Barth  <abarth@webkit.org>
2317
2318         model.js needs some unit testing
2319         https://bugs.webkit.org/show_bug.cgi?id=65730
2320
2321         Reviewed by Dimitri Glazkov.
2322
2323         These tests do not cover all the functions exported by the model
2324         module.  We'll need to add the remaining ones in the future.
2325
2326         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js: Added.
2327         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
2328
2329 2011-08-04  Adam Barth  <abarth@webkit.org>
2330
2331         Another speculative fix for the "svn revision on Windows" problem.
2332
2333         * Scripts/webkitpy/common/checkout/scm/git.py:
2334
2335 2011-08-04  Mark Rowe  <mrowe@apple.com>
2336
2337         Future-proof Xcode configuration settings.
2338
2339         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2340         * DumpRenderTree/mac/Configurations/CompilerVersion.xcconfig:
2341         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2342         * MiniBrowser/Configurations/Base.xcconfig:
2343         * MiniBrowser/Configurations/CompilerVersion.xcconfig:
2344         * MiniBrowser/Configurations/DebugRelease.xcconfig:
2345         * TestWebKitAPI/Configurations/Base.xcconfig:
2346         * TestWebKitAPI/Configurations/CompilerVersion.xcconfig:
2347         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
2348         * WebKitTestRunner/Configurations/Base.xcconfig:
2349         * WebKitTestRunner/Configurations/CompilerVersion.xcconfig:
2350         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2351
2352 2011-08-04  Adam Barth  <abarth@webkit.org>
2353
2354         Fancier debug logging.
2355
2356         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2357
2358 2011-08-04  David Levin  <levin@chromium.org>
2359
2360         [chromium] Fix assertion failure in ThreadIdentifierData::identifier in TestShell.
2361         https://bugs.webkit.org/show_bug.cgi?id=65685
2362
2363         Reviewed by Dmitry Titov.
2364
2365         * DumpRenderTree/chromium/WebViewHost.cpp:
2366         (WebViewHost::WebViewHost): Intialize WTF threading before
2367         anything in WTF is used. Usually this is done by WebViewImpl::WebViewImpl
2368         but in some cases code may use WTF without creating WebViewImpl and
2369         WTF code functionality may call WTF::currentThread, which requires
2370         this initialization now.
2371
2372 2011-08-04  Adam Barth  <abarth@webkit.org>
2373
2374         An educated guess at causing the Windows bots on build.webkit.org to
2375         find the SVN revision number.
2376
2377         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2378         * Scripts/webkitpy/layout_tests/port/base.py:
2379
2380 2011-08-04  Adam Barth  <abarth@webkit.org>
2381
2382         More logging to help debug the "no SVN rev on Chromium Windows bots"
2383         bug.  My current theory is that we're trying to detect the SCM system
2384         in the wrong directory.
2385
2386         * Scripts/webkitpy/layout_tests/port/base.py:
2387
2388 2011-08-04  Dimitri Glazkov  <dglazkov@chromium.org>
2389
2390         Speed up webkit-patch optimize-expectations significantly by not collecting test files.
2391         https://bugs.webkit.org/show_bug.cgi?id=65697
2392
2393         I neglected to realize that collecting test names is not necessary for this operation.
2394
2395         Reviewed by Adam Barth.
2396
2397         * Scripts/webkitpy/tool/commands/expectations.py: Changed to pass an empty list of test files.
2398
2399 2011-08-04  Adam Barth  <abarth@webkit.org>
2400
2401         checkout_unittest.js should have better coverage of checkout.js
2402         https://bugs.webkit.org/show_bug.cgi?id=65671
2403
2404         Reviewed by Dimitri Glazkov.
2405
2406         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
2407             - Remove unused functions.
2408         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js:
2409             - Test remaining public functions in the checkout module.
2410
2411 2011-08-04  Dmitry Lomov  <dslomov@google.com>
2412
2413         https://bugs.webkit.org/show_bug.cgi?id=65706
2414         Run run-unit-tests on release mode test bots.
2415         Reenabling after 61812 is fixed.
2416
2417         Reviewed by Adam Roben.
2418
2419         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2420
2421 2011-08-04  Adam Barth  <abarth@webkit.org>
2422
2423         builders.js needs unit tests
2424         https://bugs.webkit.org/show_bug.cgi?id=65670
2425
2426         Reviewed by Dimitri Glazkov.
2427
2428         This test requires somewhat large test fixtures, but using real
2429         examples seemed better than trimming them down too much.
2430
2431         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js:
2432         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js: Added.
2433         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
2434             - Note: trac_unittests.js doesn't exist (yet!).
2435
2436 2011-08-04  Alexis Menard  <alexis.menard@openbossa.org>
2437
2438         [Qt] Make navigation actions properly usable in QML.
2439         https://bugs.webkit.org/show_bug.cgi?id=65624
2440
2441         Fix compilation after the introduction of QWebNavigationController.
2442
2443         Reviewed by Benjamin Poulain.
2444
2445         * MiniBrowser/qt/BrowserView.cpp:
2446         (BrowserView::navigationAction):
2447
2448 2011-08-04  Adam Barth  <abarth@webkit.org>
2449
2450         Another subtle bug due to lack of testing in main.js.  :(
2451
2452         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
2453
2454 2011-08-04  Adam Barth  <abarth@webkit.org>
2455
2456         Fix types.  Sadly, main.js has no test coverage.  (I need to think
2457         about how to test this part of the code.)
2458
2459         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
2460
2461 2011-08-04  Adam Barth  <abarth@webkit.org>
2462
2463         bugzilla.js is missing unit tests
2464         https://bugs.webkit.org/show_bug.cgi?id=65656
2465
2466         Reviewed by Adam Roben.
2467
2468         Testing makes perfect.
2469
2470         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/bugzilla_unittests.js: Added.
2471         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js:
2472         (NetworkSimulator.prototype.runTest.get if):
2473         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
2474
2475 2011-08-04  Adam Barth  <abarth@webkit.org>
2476
2477         Add missing license blocks to garden-o-matic
2478         https://bugs.webkit.org/show_bug.cgi?id=65654
2479
2480         Reviewed by Dimitri Glazkov.
2481
2482         This patch is entirely boilerplate.
2483
2484         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
2485         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js:
2486         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js:
2487         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js:
2488         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
2489         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js:
2490         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
2491         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2492         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
2493         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
2494         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
2495         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net.js:
2496         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js:
2497         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
2498         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js:
2499         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
2500         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
2501         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
2502
2503 2011-08-04  Adam Barth  <abarth@webkit.org>
2504
2505         garden-o-matic needs a way to mock out the network
2506         https://bugs.webkit.org/show_bug.cgi?id=65653
2507
2508         Reviewed by Dimitri Glazkov.
2509
2510         This patch introduces the net module, which is a useful mock point for
2511         abstracting away the network.  Future patches will use this
2512         infrastructure to test some currently untested code.
2513
2514         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js:
2515         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
2516         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js:
2517         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js:
2518         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
2519         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2520         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html:
2521         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net.js: Added.
2522         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js: Added.
2523         (NetworkSimulator):
2524         (NetworkSimulator.prototype.scheduleCallback):
2525         (NetworkSimulator.prototype.runTest):
2526         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
2527         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js:
2528         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
2529         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2530
2531 2011-08-03  Adam Barth  <abarth@webkit.org>
2532
2533         Use failureInfo more pervasively in garden-o-matic
2534         https://bugs.webkit.org/show_bug.cgi?id=65650
2535
2536         Reviewed by Dimitri Glazkov.
2537
2538         These three variable appears in concert together many places.  This
2539         patch unifies the remaining uses into being failureInfo objects, which
2540         saves some marshalling.
2541
2542         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
2543         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
2544         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js:
2545         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
2546         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
2547
2548 2011-08-03  Adam Barth  <abarth@webkit.org>
2549
2550         garden-o-matic should be able to update expecations from the details pane
2551         https://bugs.webkit.org/show_bug.cgi?id=65648
2552
2553         Reviewed by Dimitri Glazkov.
2554
2555         The new button queues up the updates, which get executed all at once.
2556
2557         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2558         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
2559         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
2560
2561 2011-08-03  Adam Barth  <abarth@webkit.org>
2562
2563         Add UI to garden-o-matic for updating expectations
2564         https://bugs.webkit.org/show_bug.cgi?id=65644
2565
2566         Reviewed by Dimitri Glazkov.
2567
2568         The patch plumbs the UI back to the gardening server, but the gardening
2569         server endpoint is just a stub at this point.
2570
2571         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
2572         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2573         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
2574         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
2575         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2576         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
2577
2578 2011-08-03  Adam Barth  <abarth@webkit.org>
2579
2580         garden-o-matic details view should queue rebaselines for later execution
2581         https://bugs.webkit.org/show_bug.cgi?id=65636
2582
2583         Reviewed by Dimitri Glazkov.
2584
2585         This patch doesn't contain any confirmation UI, but we'll probably want
2586         that at some point.
2587
2588         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
2589         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2590         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
2591         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
2592
2593 2011-08-03  Kentaro Hara  <haraken@google.com>
2594
2595         Implement EventSender.scalePageBy()
2596         https://bugs.webkit.org/show_bug.cgi?id=58013
2597
2598         Reviewed by Darin Fisher.
2599
2600         Implemented EventSender.scalePageBy(f, x, y), which scales a page by a factor of f
2601         and then sets a scroll position to (x, y). Enabled the tests that had been waiting
2602         for the implementation of EventSender.scalePageBy(f, x, y).
2603
2604         Tests: compositing/scaling/tiled-layer-recursion.html
2605                fast/repaint/scale-page-shrink.html
2606                fast/dom/Element/scale-page-client-rects.html
2607                fast/dom/Range/scale-page-client-rects.html
2608                fast/events/scroll-in-scaled-page-with-overflow-hidden.html
2609                fast/dom/Element/scale-page-bounding-client-rect.html
2610                fast/dom/Range/scale-page-bounding-client-rect.html
2611
2612         * DumpRenderTree/chromium/EventSender.cpp:
2613         (EventSender::EventSender): Added bindings for scalePageBy().
2614         (EventSender::scalePageBy): A wrapper method for scalePage() in WebView.
2615         * DumpRenderTree/chromium/EventSender.h:
2616         * DumpRenderTree/chromium/TestShell.cpp:
2617         (TestShell::resetTestController): Resets the scale factor to 1.
2618
2619 2011-08-03  David Levin  <levin@chromium.org>
2620
2621         Rename WEBKIT_API to WEBKIT_EXPORT in check-webkit-style.
2622         https://bugs.webkit.org/show_bug.cgi?id=65652
2623
2624         Reviewed by Adam Barth.
2625
2626         * Scripts/webkitpy/style/checkers/cpp.py:
2627         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2628
2629 2011-08-03  Filip Pizlo  <fpizlo@apple.com>
2630
2631         Adding Filip Pizlo to committer list.
2632
2633         Unreviewed.
2634
2635         * Scripts/webkitpy/common/config/committers.py:
2636
2637 2011-08-03  Dimitri Glazkov  <dglazkov@chromium.org>
2638
2639         Add "optimize-expectations" command to webkit-patch.
2640         https://bugs.webkit.org/show_bug.cgi?id=65633
2641
2642         For now, only operates on Chromium test_expectations.txt and does not report errors/warnings.
2643
2644         Reviewed by Adam Barth.
2645
2646         * Scripts/webkitpy/tool/commands/__init__.py: Added command.
2647         * Scripts/webkitpy/tool/commands/expectations.py: Added.
2648
2649 2011-08-03  Dimitri Glazkov  <dglazkov@chromium.org>
2650
2651         Allow multiple bug identifiers in test expectations.
2652         https://bugs.webkit.org/show_bug.cgi?id=65642
2653
2654         Reviewed by Adam Barth.
2655
2656         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Tweaked to allow multiple bug ids.
2657         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added tests.
2658
2659 2011-08-03  Dimitri Glazkov  <dglazkov@chromium.org>
2660
2661         Teach BuilderToPort to distinguish between Release and Debug builders.
2662         https://bugs.webkit.org/show_bug.cgi?id=65628
2663
2664         Reviewed by Adam Barth.
2665
2666         * Scripts/webkitpy/tool/commands/rebaseline.py: Added a smart options object and passed it to port factory.
2667         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: Added tests.
2668
2669 2011-08-03  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
2670
2671         [Qt] Fix running qmltests for WK2 in the bot
2672         https://bugs.webkit.org/show_bug.cgi?id=65621
2673
2674         Reviewed by Csaba Osztrogonác.
2675
2676         The path for QML_IMPORT_PATH was assuming we were running the WK1 tests,
2677         but now there's the case for WK2 UIProcess tests as well.
2678
2679         * Scripts/run-qtwebkit-tests: add both possible paths to the QML_IMPORT_PATH.
2680
2681 2011-08-02  Dimitri Glazkov  <dglazkov@chromium.org>
2682
2683         Add a way to edit test expectations.
2684         https://bugs.webkit.org/show_bug.cgi?id=64922
2685
2686         Implements a TestExpectationsEditor, which provides a standard way to
2687         update and remove test expectations.
2688
2689         Reviewed by Adam Barth.
2690
2691         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Changed TestExpectationSerializer to skip lines that match no test configurations,
2692             added TestExpectationLine.is_flaky, added BugManager, a simple interface to be fleshed out later, and a TestExpectationsEditor, the big
2693             enchilada.
2694         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Loads of tests to capture desired behavior.
2695
2696 2011-08-03  Andreas Kling  <kling@webkit.org>
2697
2698         [Qt] MiniBrowser: Unbreak load progress indication.
2699         https://bugs.webkit.org/show_bug.cgi?id=65614
2700
2701         Reviewed by Kenneth Rohde Christiansen.
2702
2703         loadProgress() was renamed to loadProgressChanged().
2704
2705         * MiniBrowser/qt/BrowserWindow.cpp:
2706         (BrowserWindow::BrowserWindow):
2707         (BrowserWindow::onLoadProgressChanged):
2708         * MiniBrowser/qt/BrowserWindow.h:
2709
2710 2011-08-03  Martin Robinson  <mrobinson@igalia.com>
2711
2712         Build fix for WebKit2GTK+.
2713
2714         * WebKitTestRunner/GNUmakefile.am: Include libInternals as one of
2715         of the library dependencies of the injected bundle.
2716
2717 2011-08-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2718
2719         [GTK] Install web and plugin processes in libexecdir instead of bindir
2720         https://bugs.webkit.org/show_bug.cgi?id=65600
2721
2722         Reviewed by Martin Robinson.
2723
2724         Set WEBKIT_EXEC_PATH environment variable to use web and plugin
2725         process from current directory instead of the intalled ones.
2726
2727         * MiniBrowser/gtk/GNUmakefile.am:
2728         * MiniBrowser/gtk/main.c:
2729         (main):
2730         * WebKitTestRunner/GNUmakefile.am:
2731         * WebKitTestRunner/gtk/main.cpp:
2732         (main):
2733
2734 2011-08-02  Anders Carlsson  <andersca@apple.com>
2735
2736         Add mac-lion platform to old-run-webkit-tests
2737         https://bugs.webkit.org/show_bug.cgi?id=65577
2738
2739         * Scripts/old-run-webkit-tests:
2740         * Scripts/webkitdirs.pm:
2741         (isLion):
2742
2743 2011-08-02  Alexandru Chiculita  <achicu@adobe.com>
2744
2745         Buildbot: The Properties object has no "hasProperty" method in buildbot 8.3
2746         https://bugs.webkit.org/show_bug.cgi?id=65554
2747
2748         Using "has_key" instead of "hasProperty" in order to support buildbot 8.3.
2749
2750         Reviewed by Adam Roben.
2751
2752         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2753
2754 2011-08-02  Jochen Eisinger  <jochen@chromium.org>
2755
2756         Implement WebPermissionClient::allowPlugins for layout tests
2757         https://bugs.webkit.org/show_bug.cgi?id=33991
2758
2759         Reviewed by Adam Barth.
2760
2761         * DumpRenderTree/chromium/LayoutTestController.cpp:
2762         (LayoutTestController::LayoutTestController):
2763         (LayoutTestController::setPluginsAllowed):
2764         * DumpRenderTree/chromium/LayoutTestController.h:
2765         * DumpRenderTree/chromium/WebPermissions.cpp:
2766         (WebPermissions::allowPlugins):
2767         (WebPermissions::setPluginsAllowed):
2768         (WebPermissions::reset):
2769         * DumpRenderTree/chromium/WebPermissions.h:
2770
2771 2011-08-02  Adam Barth  <abarth@webkit.org>
2772
2773         TestFailures unit tests leak a global variable
2774         https://bugs.webkit.org/show_bug.cgi?id=65500
2775
2776         Reviewed by Adam Roben.
2777
2778         qunit detects the leak if you check the "noglobals" box on run-unittests.html.
2779
2780         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:
2781
2782 2011-08-02  Alexandru Chiculita  <achicu@adobe.com>
2783
2784         CSS Regions build bot should archive and upload output files
2785         https://bugs.webkit.org/show_bug.cgi?id=65200
2786
2787         Until now the buildbots would only upload the result archive if the 'trigger' parameters was specified. The
2788         upload was needed, because the testbots needed to download and use the archive. For CSS Regions we don't have
2789         a testbot yet, but we want to save the archive on the server for manual testing. Added new parameter
2790         in config.json, called "upload" that when set to "true" will force the upload to the buildmaster server.
2791
2792         The "features" argument is now taken into account when determining the name of the archive on the server. That
2793         was needed in order to avoid the CSS Regions Mac buildbot overwrite the SnowLeopard Mac build.
2794
2795         Reviewed by Adam Roben.
2796
2797         * BuildSlaveSupport/build.webkit.org-config/config.json:
2798         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2799
2800 2011-08-02  Patrick Gansterer  <paroga@webkit.org>
2801
2802         Fix _win32_check_running_pid on 64bit windows python
2803         https://bugs.webkit.org/show_bug.cgi?id=64950
2804
2805         Reviewed by Adam Roben.
2806
2807         Use the correct types for the PROCESSENTRY32 struct.
2808         th32DefaultHeapID is declared as ULONG_PTR and not as DWORD.
2809         Using 32bit for pointers instead of 64bit results in an ERROR_BAD_LENGTH
2810         failure, when calling the Process32First function.
2811         This is covered by the executive unittest.
2812
2813         * Scripts/webkitpy/common/system/executive.py:
2814
2815 2011-08-01  Adam Barth  <abarth@webkit.org>
2816
2817         garden-o-matic should call optimize-baselines when rebaselining tests
2818         https://bugs.webkit.org/show_bug.cgi?id=65499
2819
2820         Reviewed by Dimitri Glazkov.
2821
2822         I took the opportunity to modernize this code to use some of our more
2823         powerful primitives from base.
2824
2825         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js:
2826         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js:
2827         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
2828         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2829         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2830
2831 2011-08-01  Stephanie Lewis  <slewis@apple.com>
2832
2833         Finish reconfiguration started by Lucas Forschler
2834         Reconfigured slaves:
2835         Removed Leopard Intel Release (Build)
2836         Removed Leopard Intel Release (Tests)
2837         Remove apple-pixel-1
2838         Added Lion slaves from disabled Leopard slaves
2839
2840         Added builders:
2841         Lion Intel Release (Build)
2842         Lion Intel Debug (Build)
2843         Lion Intel Release (Tests)
2844         Lion Intel Release WK2 (Tests)
2845         Lion Intel Debug (Tests)
2846         Lion Intel Debug WK2 (Tests)
2847
2848         Added triggers:
2849         lion-intel-debug-tests
2850         lion-intel-debug-test-wk2
2851         lion-intel-release-tests
2852         lion-intel-release-tests-wk2
2853         
2854         Removed trigger:
2855         leopard-intel-release-tests
2856
2857         Added PlatformSpecificScheduler:
2858         mac-lion
2859
2860         Added "mac-lion" to build.py and build_unitttest.py
2861
2862         Reviewed by Mark Rowe.
2863
2864         * BuildSlaveSupport/build.webkit.org-config/config.json:
2865         * Scripts/webkitpy/common/config/build.py:
2866         * Scripts/webkitpy/common/config/build_unittest.py:
2867
2868  
2869 2011-08-01  Adam Barth  <abarth@webkit.org>
2870
2871         webkit-patch needs to be able to "optimize" the storage of baselines on disk
2872         https://bugs.webkit.org/show_bug.cgi?id=65418
2873
2874         Reviewed by Dimitri Glazkov.
2875
2876         If we're not careful when rebaselining tests, we can end up with lots
2877         of duplicate expected results files in the tree.  This patch adds a
2878         webkit-patch command that optimizes the storage of expected results on
2879         disk.
2880
2881         This command is similar to deduplicate-tests, except that it can move
2882         test results around rather than just remove duplicate results.
2883
2884         Unfortunately, this problem is very tricky because the baseline search
2885         structure is a hypergraph.  This patch include a huerstic optimizer
2886         that appears to work on a bunch of examples I've tried.  We'll likely
2887         need to refine it as gain experience.
2888
2889         * Scripts/webkitpy/common/system/filesystem.py:
2890         * Scripts/webkitpy/tool/commands/rebaseline.py:
2891
2892 2011-08-01  Dimitri Glazkov  <dglazkov@chromium.org>
2893
2894         Teach TestExpectationSerializer about parsed expectations.
2895         https://bugs.webkit.org/show_bug.cgi?id=65444
2896
2897         This is a bit largish in size, but the essentials are:
2898         * TestExpectationSerializer, given a parsed TestExpectationLine, can now spit out a pretty string.
2899         * We now store original content of the expectation line on TestExpectationLine.
2900         * Lots of tests.
2901
2902         Reviewed by Adam Barth.
2903
2904         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Fixed an issue where we didn't
2905             populate macros correctly, also fixed an issue where we incorrectly returned an empty list
2906             for all configurations.
2907         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added tests for those.
2908         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Removed vestiges of code long gone,
2909             refactored TestExpectationsSerializer to recognize and correctly serialize parsed TestExpectationLine instances,
2910             changed to store and use TestExpectationLine.original_string.
2911         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added tests.
2912
2913 2011-08-01  Adam Barth  <abarth@webkit.org>
2914
2915         Remove unused functionality from gardeningserver
2916         https://bugs.webkit.org/show_bug.cgi?id=65479
2917
2918         Reviewed by Dimitri Glazkov.
2919
2920         We now handle these operations directly from the front-end.  That means
2921         they work even without the gardening server running!
2922
2923         Also, add some missing files to the list of static files.
2924
2925         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2926         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2927
2928 2011-08-01  Dimitri Glazkov  <dglazkov@chromium.org>
2929
2930         Introduce SpecifierSorter, a thing that knows how specifiers should be ordered.
2931         https://bugs.webkit.org/show_bug.cgi?id=65413
2932
2933         Reviewed by Adam Barth.
2934
2935         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Added SpecifierSorter and converted
2936             existing code to use it.
2937         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added unit tests and cleaned up a bit.
2938
2939 2011-08-01  Adam Barth  <abarth@webkit.org>
2940
2941         Refactor bugzilla.js for use by garden-o-matic
2942         https://bugs.webkit.org/show_bug.cgi?id=65450
2943
2944         Reviewed by Dimitri Glazkov.
2945
2946         This patch refactors bugzilla.js to use the AsynchronousCache and
2947         updates the style to use a module instead of an object.  This patch
2948         then fixes all the existing code that uses this class to use the new
2949         API style.
2950
2951         This main benefit of this patch is we remove the tricky manual caching
2952         and this code is now available to use in garden-o-matic (since the
2953         dependency on Utilities.js is now gone).
2954
2955         I ran all the unit tests and poked around in TestFailures a bit to see
2956         that everything seemed to be working properly.
2957
2958         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js:
2959         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js:
2960         (FailingTestsBugForm):
2961         (FailingTestsBugForm.prototype._createBugTitle):
2962         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js:
2963         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm.js:
2964         (FlakyTestBugForm):
2965         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm_unittests.js:
2966         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm.js:
2967         (NewBugForm):
2968         (NewBugForm.prototype.domElement):
2969         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm_unittests.js:
2970         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm.js:
2971         (TestRelatedBugForm):
2972         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm_unittests.js:
2973         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
2974         (ViewController.prototype._displayBuilder.start):
2975         (ViewController.prototype._displayBuilder):
2976         (ViewController.prototype._domForAuxiliaryUIElements):
2977         (ViewController.prototype._domForNewAndExistingBugs.bugzilla.quickSearch):
2978         (ViewController.prototype._domForPossiblyFlakyTests.flakyList.appendChildren):
2979         (ViewController.prototype._domForPossiblyFlakyTests):
2980         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
2981         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2982         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html:
2983
2984 2011-08-01  Adam Barth  <abarth@webkit.org>
2985
2986         garden-o-matic shouldn't require local server to determine if compile failed
2987         https://bugs.webkit.org/show_bug.cgi?id=65446
2988
2989         Reviewed by Dimitri Glazkov.
2990
2991         This patch adds some basic bindings for the buildbot JSON API.  I
2992         wanted to use Buildbot.js an Builder.js from the original TestFailures,
2993         but they make a number of WebKit-specific assumptions.  We'll
2994         eventually need to reconcile these pieces of code.
2995
2996         I should really add tests for this code, but that will require me to
2997         build a better mock network.  I'll be happy to do that in a follow-up
2998         patch.
2999
3000         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js: Added.
3001             - It's very unclear to me whether didFail is correct.  Supposedly
3002               the first entry here is the exit code of the step, which is 0 on
3003               success.  I suspect we'll need to improve this function over time.
3004         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
3005         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
3006         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
3007
3008 2011-08-01  Adam Barth  <abarth@webkit.org>
3009
3010         garden-o-matic should show all failures, even ones that it can't find a regression range for
3011         https://bugs.webkit.org/show_bug.cgi?id=65447
3012
3013         Reviewed by Dimitri Glazkov.
3014
3015         Previously, we just wouldn't display test failures that we couldn't
3016         identify a regression range for (or whose regression range had fallen
3017         off the page).  This patch just displays them at the end of the list,
3018         which is slightly (but not much) better.
3019
3020         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
3021
3022 2011-08-01  Jeff Miller  <jeffm@apple.com>
3023
3024         Windows build fix after r92096.
3025
3026         * TestWebKitAPI/win/InjectedBundleControllerWin.cpp: Use #include, not #import, and don't include Foundation.h.
3027         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj: Add InjectedBundleControllerWin.cpp.
3028
3029 2011-07-31  Anders Carlsson  <andersca@apple.com>
3030
3031         DownloadDecideDestinationCrash WebKit2 API tests crashes
3032         https://bugs.webkit.org/show_bug.cgi?id=65442
3033
3034         Reviewed by Sam Weinig.
3035
3036         Copy the 18-characters.html file to the destination directory so we won't
3037         crash trying to make an URL for it.
3038
3039         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3040
3041 2011-07-31  Anders Carlsson  <andersca@apple.com>
3042
3043         Fix SpacebarScrolling WebKit2 API test
3044         https://bugs.webkit.org/show_bug.cgi?id=65431
3045
3046         Reviewed by Sam Weinig.
3047
3048         Add a way to do platform-specific bundle initialization, and use it to disable smooth
3049         scrolling. Also make it possible for a test to load the injected bundle without actually running
3050         a test from it.
3051
3052         * TestWebKitAPI/InjectedBundleController.cpp:
3053         (TestWebKitAPI::InjectedBundleController::initialize):
3054         * TestWebKitAPI/InjectedBundleController.h:
3055         * TestWebKitAPI/PlatformUtilities.cpp:
3056         (TestWebKitAPI::Util::createContextWithInjectedBundle):
3057         * TestWebKitAPI/PlatformUtilities.h:
3058         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3059         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
3060         (TestWebKitAPI::TEST):
3061         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm: Added.
3062         (TestWebKitAPI::InjectedBundleController::platformInitialize):
3063         * TestWebKitAPI/win/InjectedBundleControllerWin.cpp: Added.
3064         (TestWebKitAPI::InjectedBundleController::platformInitialize):
3065         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3066
3067 2011-07-31  Dimitri Glazkov  <dglazkov@chromium.org>
3068
3069         Use set comparison to find duplicate or overlapping specifiers in test expectations.
3070         https://bugs.webkit.org/show_bug.cgi?id=65430
3071
3072         Reviewed by Adam Barth.
3073
3074         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Changed to use set comparisons, because length
3075             of a set is wrong.
3076         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Added some unit tests to actually catch
3077             regressions.
3078
3079 2011-07-31  Xan Lopez  <xlopez@igalia.com>
3080
3081         Group dependencies CFLAGS together.
3082
3083         * GNUmakefile.am: ditto.
3084
3085 2011-07-31  Daniel Bates  <dbates@webkit.org>
3086
3087         Attempt to fix the GTK build after <http://trac.webkit.org/changeset/92059>
3088         (https://bugs.webkit.org/show_bug.cgi?id=65419).
3089
3090         * GNUmakefile.am: Add $(CAIRO_CFLAGS) to libWebCoreInternals_la_CPPFLAGS.
3091
3092 2011-07-30  Patrick Gansterer  <paroga@webkit.org>
3093
3094         Fix ports_unittest.py on native windows
3095         https://bugs.webkit.org/show_bug.cgi?id=64959
3096
3097         Reviewed by Adam Barth.
3098
3099         Replace WebKitPort.script_path with WebKitPort.script_shell_command.
3100         The latter includes the interpreter executable required on native windows.
3101
3102         * Scripts/webkitpy/common/config/ports_unittest.py:
3103
3104 2011-07-30  Adam Barth  <abarth@webkit.org>
3105
3106         Properly escape regular expressions.  (Maybe these shouldn't be regular
3107         expressions?)
3108
3109         * Scripts/webkitpy/tool/commands/rebaseline.py:
3110
3111 2011-07-30  Adam Barth  <abarth@webkit.org>
3112
3113         Add support for Win7 to garden-o-matic.
3114
3115         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
3116         * Scripts/webkitpy/tool/commands/rebaseline.py:
3117
3118 2011-07-30  Adam Barth  <abarth@webkit.org>
3119
3120         garden-o-matic regression ranges expand after fast bots start passing
3121         https://bugs.webkit.org/show_bug.cgi?id=65406
3122
3123         Reviewed by Dimitri Glazkov.
3124
3125         Once the gardener has fixed a problem, the fast bots pick up the fix,
3126         which means we end up using the slow bots to compute the regression
3127         range.  Unfortunately, the slow bots give us large regression ranges,
3128         leading to this strange effect where the regression range quality
3129         degrades as fixes roll in.
3130
3131         This patch causes us to remember the previous regression ranges we've
3132         seen and to use that information in the future, as long as it's
3133         consistent with the new information we receive.
3134
3135         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
3136
3137 2011-07-30  Adam Barth  <abarth@webkit.org>
3138
3139         garden-o-matic should have a Refresh button to update its display
3140         https://bugs.webkit.org/show_bug.cgi?id=65403
3141
3142         Reviewed by Dimitri Glazkov.
3143
3144         The refresh button should be faster and less disruptive than the browser's reload button.
3145
3146         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
3147         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
3148
3149 2011-07-30  Adam Barth  <abarth@webkit.org>
3150
3151         garden-o-matic should look for the "patch by" line in revisions ostensibly authored by the commit-queue
3152         https://bugs.webkit.org/show_bug.cgi?id=65231
3153
3154         Reviewed by Dimitri Glazkov.
3155
3156         The human readable name is easier to understand, especially when the patch is landed by the commit-queue.
3157
3158         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
3159
3160 2011-07-30  Adam Barth  <abarth@webkit.org>
3161
3162         garden-o-matic should strikeout revisions that have been rolled out
3163         https://bugs.webkit.org/show_bug.cgi?id=65227
3164
3165         Reviewed by Dimitri Glazkov.
3166
3167         This helps gardeners keep track of which problems have been solved.
3168
3169         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
3170         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
3171         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
3172         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
3173
3174 2011-07-30  Adam Barth  <abarth@webkit.org>
3175
3176         Add missing files to the server.
3177
3178         * Scripts/webkitpy/tool/servers/gardeningserver.py:
3179
3180 2011-07-29  Adam Barth  <abarth@webkit.org>
3181
3182         Actually import the logging module!
3183
3184         * Scripts/webkitpy/common/checkout/scm/git.py:
3185
3186 2011-07-29  Adam Barth  <abarth@webkit.org>
3187
3188         More debug logging.  Maybe we're running the git version of this
3189         function somehow?  (That would explain why it doesn't work!)
3190
3191         * Scripts/webkitpy/common/checkout/scm/git.py:
3192
3193 2011-07-29  Adam Barth  <abarth@webkit.org>
3194
3195         Add some temporary debug logging messages to try to understand why the
3196         windows bots can't figure out their current SVN revision.
3197
3198         * Scripts/webkitpy/common/checkout/scm/svn.py:
3199
3200 2011-07-29  Adam Barth  <abarth@webkit.org>
3201
3202         Chromium try servers should use downstream test_expectations
3203         https://bugs.webkit.org/show_bug.cgi?id=65390
3204
3205         Reviewed by Dirk Pranke.
3206
3207         Otherwise the try servers will report bogus failures.
3208
3209         * Scripts/webkitpy/layout_tests/port/chromium.py:
3210
3211 2011-07-29  Dimitri Glazkov  <dglazkov@chromium.org>
3212
3213         Fix an error in macro collapsing, refactor code to be pretty.
3214         https://bugs.webkit.org/show_bug.cgi?id=65387
3215
3216         My set math was wrong.
3217
3218         Reviewed by Adam Barth.
3219
3220         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Moved collapsing into a classmethod, fixed the math to be correct.
3221         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added unit tests.
3222
3223 2011-07-27  Ryuan Choi  <ryuan.choi@samsung.com>
3224
3225         Style bot complains about EFL-specific forward declaration naming.
3226         https://bugs.webkit.org/show_bug.cgi?id=64680
3227
3228         Exclude EFL-specific forward declarations from indentifiers with underscores checks.
3229
3230         Reviewed by Adam Barth.
3231
3232         * Scripts/webkitpy/style/checkers/cpp.py:
3233         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3234
3235 2011-07-27  Adam Roben  <aroben@apple.com>
3236
3237         Use wacky !svn/bc URLs consistently in Leaks Viewer
3238
3239         This ensures that any resources loaded via relative URLs will still get pulled from the same
3240         revision of Subversion.
3241
3242         Fixes <http://webkit.org/b/65267> Focus/exclude button glyphs don't load on Leaks Viewer
3243
3244         Reviewed by David Kilzer.
3245
3246         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Use the
3247         !svn/bc-style URL for inspector.css, too, just like we do for all other resources we pull
3248         from Subversion.
3249
3250 2011-07-27  Raphael Kubo da Costa  <kubo@profusion.mobi>
3251
3252         [EFL] Drop WorkQueueItemEfl.h in favour of the general WorkQueueItem.h
3253         https://bugs.webkit.org/show_bug.cgi?id=65269
3254
3255         Reviewed by Kent Tamura.
3256
3257         WorkQueueItemEfl.h was being included by efl's
3258         LayoutTestControllerEfl.cpp, however the top-level
3259         LayoutTestController still included WorkQueueItem.h, causing a lot of
3260         type mismatches when running the WorkQueueItem code.
3261
3262         We can stick to the original WorkQueueItem header by making a few
3263         changes to EFL's LayoutTestController.
3264
3265         This should make tests such as
3266         fast/loader/non-deferred-substitute-load.html stop crashing.
3267
3268         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3269         (LayoutTestController::queueLoad):
3270         * DumpRenderTree/efl/WorkQueueItemEfl.cpp:
3271         (LoadItem::invoke):
3272         (LoadHTMLStringItem::invoke):
3273         (ScriptItem::invoke):
3274         * DumpRenderTree/efl/WorkQueueItemEfl.h: Removed.
3275
3276 2011-07-27  Dimitri Glazkov  <dglazkov@chromium.org>
3277
3278         Re-add unit tests I accidentally zapped in r91878.
3279
3280         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Re-added unit tests.
3281
3282 2011-07-27  Dimitri Glazkov  <dglazkov@chromium.org>
3283
3284         Replace SpecificityCalculator with TestConfiguration-driven logic.
3285         https://bugs.webkit.org/show_bug.cgi?id=65206
3286
3287         Use our newly-acquired ability to expand modifiers into a set of
3288         matching TestConfiguration instances to calculate specificity and
3289         determine whether expectation applies to a given test configuration.
3290
3291         Also, store bug modifier on TestExpectationsLine.
3292
3293         Reviewed by Adam Barth.
3294
3295         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Replaced the logic of calculating specificity with
3296             test configuration matching, removed a bunch of code.
3297         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Removed a bunch of tests that aren't useful anymore.
3298
3299
3300 2011-07-27  Dimitri Glazkov  <dglazkov@chromium.org>
3301
3302         Allow ports to specify their own test expectation specifier macros.
3303         https://bugs.webkit.org/show_bug.cgi?id=65291
3304
3305         Reviewed by Adam Barth.
3306
3307         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Changed SpecificityCalculator to use port macros.
3308         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Ditto.
3309         * Scripts/webkitpy/layout_tests/port/base.py: Added configuration_specifier_macros to retrieve the macros.
3310         * Scripts/webkitpy/layout_tests/port/chromium.py: Overrode it to return Chromium's macros.
3311         * Scripts/webkitpy/layout_tests/port/test.py: Added test macros.
3312
3313 2011-07-27  Dimitri Glazkov  <dglazkov@chromium.org>
3314
3315         Allow TestConfigurationConverter report conversion errors.
3316         https://bugs.webkit.org/show_bug.cgi?id=65287
3317
3318         Also, fix a few miscellaneous testing issues.
3319
3320         Reviewed by Adam Barth.
3321
3322         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Added a way to report unknown modifier errors.
3323         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added a test for reporting errors.
3324         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: Fixed an error where an invalid TestConfiguration instance
3325             was created. 'default' is not a valid build type.
3326         * Scripts/webkitpy/layout_tests/port/test.py: Ditto. '' is not a valid version.
3327
3328 2011-07-27  Dimitri Glazkov  <dglazkov@chromium.org>
3329
3330         Teach all ports about their test configurations.
3331         https://bugs.webkit.org/show_bug.cgi?id=65278
3332
3333         Each Port object should return a valid set of all TestConfiguration instances,
3334         available for this port.
3335
3336         Reviewed by Philippe Normand.
3337
3338         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Removed TestConfiguration.all_test_configurations,
3339             since it is different for each port.
3340         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Removed related test.
3341         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Changed SpecificityCalculator to take a list of
3342             all test configurations as a param.
3343         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Adjusted arguments accordingly.
3344         * Scripts/webkitpy/layout_tests/port/base.py: Forced all ports to override generation of all test configurations.
3345         * Scripts/webkitpy/layout_tests/port/chromium.py: Implemented _generate_all_test_configurations for the port.
3346         * Scripts/webkitpy/layout_tests/port/gtk.py: Ditto.
3347         * Scripts/webkitpy/layout_tests/port/mac.py: Ditto.
3348         * Scripts/webkitpy/layout_tests/port/qt.py: Ditto.
3349         * Scripts/webkitpy/layout_tests/port/win.py:
3350         * Scripts/webkitpy/layout_tests/port/port_testcase.py: Added an extra test to ensure we're generating a good set.
3351         * Scripts/webkitpy/layout_tests/port/test.py: Implemented a fixed-in-time all_test_configurations for testing.
3352         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Added a mock all_test_configurations implementation.
3353         * Scripts/webkitpy/layout_tests/port/win_unittest.py: Added a unit test for the port.
3354
3355 2011-07-27  Benjamin Poulain  <benjamin@webkit.org>
3356
3357         [WK2][Qt] Move from QGraphicsView to Qt Scene Graph
3358         https://bugs.webkit.org/show_bug.cgi?id=62969
3359
3360         Reviewed by Andreas Kling.
3361
3362         Co-authored with Simon Hausmann  <simon.hausmann@nokia.com>
3363
3364         With the scene graph, the interface to have a window on screen is
3365         QSGCanvas. QGraphicsView is not used, and openGL is an enforced
3366         dependency.
3367
3368         Both the BrowserView and the WebKitTest runner are changed from
3369         QGraphicsView to QSGCanvas.
3370
3371         * MiniBrowser/qt/BrowserView.cpp:
3372         (BrowserView::BrowserView):
3373         (BrowserView::resizeEvent):
3374         (BrowserView::view):
3375         * MiniBrowser/qt/BrowserView.h:
3376         * MiniBrowser/qt/BrowserWindow.cpp:
3377         (BrowserWindow::BrowserWindow):
3378         (BrowserWindow::urlChanged):
3379         (BrowserWindow::~BrowserWindow):
3380         * MiniBrowser/qt/BrowserWindow.h:
3381         * MiniBrowser/qt/MiniBrowser.pro:
3382         * MiniBrowser/qt/main.cpp:
3383         (main):
3384         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3385         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3386         (WTR::WebView::WebView):
3387         (WTR::PlatformWebView::PlatformWebView):
3388         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3389
3390 2011-07-27  Sheriff Bot  <webkit.review.bot@gmail.com>
3391
3392         Unreviewed, rolling out r91792.
3393         http://trac.webkit.org/changeset/91792
3394         https://bugs.webkit.org/show_bug.cgi?id=65242
3395
3396         It broke NRWT on Qt and GTK (Requested by Ossy_night on
3397         #webkit).
3398
3399         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
3400         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
3401         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3402         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3403         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3404         * Scripts/webkitpy/layout_tests/port/test.py:
3405
3406 2011-07-26  Adam Barth  <abarth@webkit.org>
3407
3408         Switch to an older idiom that works on Python 2.5.
3409
3410         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
3411
3412 2011-07-26  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3413
3414         Add an exception to coding style check for EFL port.
3415         https://bugs.webkit.org/show_bug.cgi?id=65162
3416
3417         Add an exception of whitespace/declaration for EFL port. Because,
3418         '*' operator is next to variable in EFL coding style.
3419
3420         Reviewed by Kent Tamura.
3421
3422         * Scripts/webkitpy/style/checker.py:
3423
3424 2011-07-26  Keith Kyzivat  <keith.kyzivat@nokia.com>
3425
3426         [Qt] Add option to turn on disk caching in QtTestBrowser
3427         https://bugs.webkit.org/show_bug.cgi?id=65007
3428
3429         Reviewed by Noam Rosenthal.
3430
3431         Add menu item and command line option to turn on disk caching in
3432         QtTestBrowser. Simple QNetworkDiskCache added to the page's
3433         QNetworkAccssManager.
3434
3435         * QtTestBrowser/launcherwindow.cpp:
3436         (LauncherWindow::initializeView):
3437         (LauncherWindow::createChrome):
3438         (LauncherWindow::setDiskCache):
3439         * QtTestBrowser/launcherwindow.h:
3440         (WindowOptions::WindowOptions):
3441         * QtTestBrowser/main.cpp:
3442         (LauncherApplication::handleUserOptions):
3443
3444 2011-07-26  Sadrul Habib Chowdhury  <sadrul@chromium.org>
3445
3446         Add support for download='filename' attribute in anchors.
3447         https://bugs.webkit.org/show_bug.cgi?id=64580
3448
3449         Reviewed by Adam Barth.
3450
3451         * DumpRenderTree/chromium/WebViewHost.cpp:
3452         (WebViewHost::loadURLExternally):
3453         * DumpRenderTree/chromium/WebViewHost.h:
3454
3455 2011-07-26  Dan Bernstein  <mitz@apple.com>
3456
3457         Rubber-stamped by Anders Carlsson.
3458
3459         Update DumpRenderTree and API tests for the pictograph font family preference.
3460
3461         * DumpRenderTree/mac/DumpRenderTree.mm:
3462         (resetDefaultsToConsistentValues):
3463         * DumpRenderTree/win/DumpRenderTree.cpp:
3464         (resetDefaultsToConsistentValues):
3465         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
3466         (TestWebKitAPI::TEST):
3467         * WebKitTestRunner/TestController.cpp:
3468         (WTR::TestController::resetStateToConsistentValues):
3469
3470 2011-07-26  Dimitri Glazkov  <dglazkov@chromium.org>
3471
3472         Replace SpecificityCalculator with TestConfiguration-driven logic.
3473         https://bugs.webkit.org/show_bug.cgi?id=65206
3474
3475         Use our newly-acquired ability to expand modifiers into a set of
3476         matching TestConfiguration instances to calculate specificity and
3477         determine whether expectation applies to a given test configuration.
3478
3479         Also, store bug modifier on TestExpectationsLine.
3480
3481         Reviewed by Adam Barth.
3482
3483         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Added a way to report unknown modifier errors.
3484         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added a test for reporting errors.
3485         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Replaced the logic of calculating specificity with
3486             test configuration matching, removed a bunch of code.
3487         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Removed a bunch of tests that aren't useful anymore.
3488         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: Fixed an error where an invalid TestConfiguration instance
3489             was created. 'default' is not a valid build type.
3490         * Scripts/webkitpy/layout_tests/port/test.py: Ditto. '' is not a valid version.
3491
3492 2011-07-26  Adam Barth  <abarth@webkit.org>
3493
3494         Increase the information density in garden-o-matic
3495         https://bugs.webkit.org/show_bug.cgi?id=65141
3496
3497         Reviewed by Dimitri Glazkov.
3498
3499         This patch changes lets us show each revision on a single line,
3500         allowing use to show an entire day's worth of commits at once.
3501
3502         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
3503         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
3504         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
3505
3506 2011-07-26  Dimitri Glazkov  <dglazkov@chromium.org>
3507
3508         TestConfigurationConverter should not barf on invalid specifiers.
3509         https://bugs.webkit.org/show_bug.cgi?id=65194
3510
3511         Reviewed by Adam Barth.
3512
3513         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Refactored TestConfigurationConverter.to_config_set a bit,
3514             made it return empty set whenever an invalid specifier is encountered.
3515         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added corresponding tests.
3516
3517 2011-07-26  Dimitri Glazkov  <dglazkov@chromium.org>
3518
3519         Introduce a way to convert between specifier lists and TestConfiguration sets.
3520         https://bugs.webkit.org/show_bug.cgi?id=65094
3521
3522         Add TestConfigurationConverter, a facility to convert:
3523         1) a set of specifiers into a set of TestConfiguration instances;
3524         2) a set of TestConfiguration instances into a list of sets of specifiers.
3525
3526         Reviewed by Adam Barth.
3527
3528         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Added TestConfigurationConverter.
3529         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added tests for it.
3530
3531 2011-07-26  Alexandru Chiculita  <achicu@adobe.com>
3532
3533         CSS Regions build bot should build with "--css-regions" and "--css-exclusion" flags
3534         https://bugs.webkit.org/show_bug.cgi?id=65171
3535
3536         Added "features" parameter in config.json for "builder" objects. The parameter is optional and must be an array. All the items
3537         of the array will be passed to the build-webkit script. The items will automatically be prefixed with "--".
3538
3539         Reviewed by Adam Roben.
3540
3541         * BuildSlaveSupport/build.webkit.org-config/config.json:
3542         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3543
3544 2011-07-26  Chris Rogers  <crogers@google.com>
3545
3546         Avoid outputting #EOF twice for web audio tests in chromium DRT
3547         https://bugs.webkit.org/show_bug.cgi?id=65201
3548
3549         Reviewed by Dirk Pranke.
3550
3551         * DumpRenderTree/chromium/TestShell.cpp:
3552         (TestShell::dump):
3553
3554 2011-07-26  Adam Barth  <abarth@webkit.org>
3555
3556         Windows bots on build.chromium.org can't figure out the head_svn_revision
3557         https://bugs.webkit.org/show_bug.cgi?id=65156
3558
3559         Reviewed by Tony Chang.
3560
3561 &nb