Add JSC:RegExp functional tests
[WebKit-https.git] / Tools / ChangeLog
1 2011-09-02  Michael Saboff  <msaboff@apple.com>
2
3         Add JSC:RegExp functional tests
4         https://bugs.webkit.org/show_bug.cgi?id=67339
5
6         New perl script to build JavaScriptCore and run the RegExp tests.
7
8         Reviewed by Gavin Barraclough.
9
10         * Scripts/run-regexp-tests: Added.
11
12 2011-09-02  Michael Saboff  <msaboff@apple.com>
13
14         Add JSC:RegExp functional tests
15         https://bugs.webkit.org/show_bug.cgi?id=67339
16
17         New perl script to build JavaScriptCore and run the RegExp tests.
18
19         Reviewed by Gavin Barraclough.
20
21         * Scripts/run-regexp-tests: Added.
22
23 2011-09-02  Eric Seidel  <eric@webkit.org>
24
25         Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately
26         https://bugs.webkit.org/show_bug.cgi?id=67530
27
28         Unreviewed.  Fixing typo from previous commit.
29
30         Turns out there was *no* unittesting of WebKitDriver.  Added a basic test of _read_block
31         which exercises the code I previously made a typo in.
32
33         * Scripts/webkitpy/layout_tests/port/webkit.py:
34         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
35
36 2011-09-02  Eric Seidel  <eric@webkit.org>
37
38         Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately
39         https://bugs.webkit.org/show_bug.cgi?id=67530
40
41         Reviewed by Adam Barth.
42
43         No functional change, just reshuffling code.
44
45         * Scripts/webkitpy/layout_tests/port/webkit.py:
46
47 2011-09-02  Darin Adler  <darin@apple.com>
48
49         Added Subversion ignore for .pyc generated files.
50
51         * Scripts/webkitpy/layout_tests/models: Added property svn:ignore.
52         * Scripts/webkitpy/layout_tests/servers: Added property svn:ignore.
53         * Scripts/webkitpy/tool/servers: Added property svn:ignore.
54
55 2011-09-02  Adam Barth  <abarth@webkit.org>
56
57         Enable testing on mac-ews
58         https://bugs.webkit.org/show_bug.cgi?id=67505
59
60         Reviewed by Eric Seidel.
61
62         This patch enables testing on the Mac EWS, which should help
63         contributors not turn the Mac bots red.
64
65         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
66
67 2011-09-01  Beth Dakin  <bdakin@apple.com>
68
69         https://bugs.webkit.org/show_bug.cgi?id=67451
70         Add a test for going back to a cached page after changing the device scale factor
71
72         Reviewed by Adam Roben.
73
74         New test DeviceScaleFactorOnBack.mm inherits from WebKitAgnosticTest.
75         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
76         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm: Added.
77         (TestWebKitAPI::DeviceScaleFactorOnBack::url):
78         (TestWebKitAPI::DeviceScaleFactorOnBack::didLoadURL):
79         (TestWebKitAPI::DeviceScaleFactorOnBack::createWindow):
80         (TestWebKitAPI::DeviceScaleFactorOnBack::initializeView):
81         (TestWebKitAPI::DeviceScaleFactorOnBack::runTest):
82         (TestWebKitAPI::TEST_F):
83
84         Added new function to WebKitAgnosticTest to goBack. Separated 
85         waitForLoadToFinish() into its own function (instead of being a part of 
86         loadAndWaitUntilFinished()) so that it can be called from goBack as 
87         well. Also added initializeView() so we can set the cache model.
88         * TestWebKitAPI/mac/WebKitAgnosticTest.h:
89         (TestWebKitAPI::WebKitAgnosticTest::initializeView):
90         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
91         (TestWebKitAPI::WebKitAgnosticTest::WebKitAgnosticTest):
92         (TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test):
93         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
94         (TestWebKitAPI::WebKitAgnosticTest::loadURL):
95         (TestWebKitAPI::WebKitAgnosticTest::goBack):
96         (TestWebKitAPI::WebKitAgnosticTest::waitForLoadToFinish):
97
98 2011-09-02  Anders Carlsson  <andersca@apple.com>
99
100         Build fix.
101
102         * DumpRenderTree/TestNetscapePlugIn/Tests/PrivateBrowsing.cpp:
103         (PrivateBrowsing::ScriptableObject::pluginTest):
104
105 2011-09-02  Anders Carlsson  <andersca@apple.com>
106
107         Move private browsing test to a PluginTest subclass
108         https://bugs.webkit.org/show_bug.cgi?id=67498
109
110         Reviewed by Darin Adler.
111
112         * DumpRenderTree/DumpRenderTree.gypi:
113         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
114         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
115         (pluginGetProperty):
116         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
117         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
118         (PluginTest::NPP_SetValue):
119         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
120         * DumpRenderTree/TestNetscapePlugIn/Tests/PrivateBrowsing.cpp: Added.
121         (PrivateBrowsing::PrivateBrowsing):
122         (PrivateBrowsing::privateBrowsingEnabled):
123         (PrivateBrowsing::cachedPrivateBrowsingEnabled):
124         (PrivateBrowsing::ScriptableObject::hasProperty):
125         (PrivateBrowsing::ScriptableObject::getProperty):
126         (PrivateBrowsing::ScriptableObject::pluginTest):
127         (PrivateBrowsing::NPP_New):
128         (PrivateBrowsing::NPP_GetValue):
129         (PrivateBrowsing::NPP_SetValue):
130         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
131         (NPP_New):
132         (NPP_SetValue):
133         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
134         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
135         * GNUmakefile.am:
136
137 2011-09-02  Csaba Osztrogonác  <ossy@webkit.org>
138
139         [Qt] Build dependency problems
140         https://bugs.webkit.org/show_bug.cgi?id=38054
141
142         Trivial fix after r94288.
143
144         Rubber-stamped by Andras Becsi.
145
146         * Scripts/webkitdirs.pm: We should read the whole defaults.txt, not only the first two lines.
147         (buildQMakeProject):
148
149 2011-09-02  Andras Becsi  <andras.becsi@nokia.com>
150
151         Remove my old e-mail address and add my new one.
152
153         Rubber-stamped by Tor Arne Vestbø.
154
155         * Scripts/webkitpy/common/config/committers.py:
156
157 2011-09-02  Philippe Normand  <pnormand@igalia.com>
158
159         [GTK] run-gtk-tests leaves a zombie Xvfb process
160         https://bugs.webkit.org/show_bug.cgi?id=67389
161
162         Reviewed by Martin Robinson.
163
164         * Scripts/run-gtk-tests: Properly close STDIN and STDERR on the
165         child process instead of doing shell redirection.
166
167 2011-09-01  Mark Rowe  <mrowe@apple.com>
168
169         Fix the build by adding some more missing return types.
170
171         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
172         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
173
174 2011-09-01  Eric Seidel  <eric@webkit.org>
175
176         REGRESSION (NRWT): Leaks Viewer can't load leaks from test runs that used NRWT
177         https://bugs.webkit.org/show_bug.cgi?id=66228
178
179         Reviewed by Dirk Pranke.
180
181         ORWT used $(PROCESS)$(NUMBER)-leaks.txt for leaks filenames.
182         The LeaksViewer tool globs for all *-leaks.txt files.
183         This patch makes NRWT output $(PROCESS)-$(PID)-leaks.txt which should match.
184
185         In order to test this I had to fix a limitation in our MockFileSystem.glob
186         method.  However, doing so uncovered a typo and bug in the integration tests.
187         I've disabled the offending integration tests.
188
189         * Scripts/webkitpy/common/system/filesystem_mock.py:
190         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
191         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
192
193 2011-09-01  Dominic Mazzoni  <dmazzoni@google.com>
194
195         Adds a LayoutTestController method to make it possible to test
196         starting speech input via an API call.
197         https://bugs.webkit.org/show_bug.cgi?id=60170
198
199         Reviewed by Dimitri Glazkov.
200
201         * DumpRenderTree/LayoutTestController.h:
202         * DumpRenderTree/chromium/LayoutTestController.cpp:
203         (LayoutTestController::LayoutTestController):
204         (LayoutTestController::startSpeechInput):
205         * DumpRenderTree/chromium/LayoutTestController.h:
206         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
207         (LayoutTestController::startSpeechInput):
208         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
209         (LayoutTestController::startSpeechInput):
210         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
211         (LayoutTestController::startSpeechInput):
212         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
213         (LayoutTestController::startSpeechInput):
214         * DumpRenderTree/qt/LayoutTestControllerQt.h:
215         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
216         (LayoutTestController::startSpeechInput):
217         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
218         (LayoutTestController::startSpeechInput):
219
220 2011-09-01  Tim Horton  <hortont424@gmail.com>
221
222         Fix TestWebKitAPI build on clang-2.0
223
224         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
225
226 2011-09-01  Adam Barth  <abarth@webkit.org>
227
228         Remove unused "extension" parameter from rebaseline gardeningserver handler
229         https://bugs.webkit.org/show_bug.cgi?id=67384
230
231         Reviewed by James Robinson.
232
233         This parameter hasn't done anything in a while.
234
235         * Scripts/webkitpy/tool/commands/rebaseline.py:
236         * Scripts/webkitpy/tool/servers/gardeningserver.py:
237         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
238
239 2011-09-01  Eric Seidel  <eric@webkit.org>
240
241         Unreviewed.
242
243         Fix a typo in unittests.  Unfortunately fixing it
244         caused several assertions.  Just disabling the test
245         instead, since it was providing no value before due to the typo.
246
247         * Scripts/webkitpy/layout_tests/port/test.py:
248
249 2011-09-01  Adam Barth  <abarth@webkit.org>
250
251         Add a "rebaseline" button to the garden-o-matic summary page
252         https://bugs.webkit.org/show_bug.cgi?id=67382
253
254         Reviewed by Dimitri Glazkov.
255
256         As much as we might wish folks to not rebaseline entire test groups at
257         once, the truth is that doing so is a common operation.  Adding a
258         button for this operation is likely to make folks happy.
259
260         This patch also cleans up a bunch of plumbing surrounding failureInfo
261         objects.
262
263         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
264         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
265         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
266         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
267         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
268         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
269         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
270         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
271         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
272         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
273
274 2011-09-01  Adam Barth  <abarth@webkit.org>
275
276         garden-o-matic should let the gardener assign blame for a group of test failures
277         https://bugs.webkit.org/show_bug.cgi?id=67379
278
279         Reviewed by Dimitri Glazkov.
280
281         If a group of test failures has a large revision range, the gardener
282         might wish to blame a specific revision for the failure.  Currently,
283         this only effect of assigning blame in this way is to hide the other
284         suspect commits.
285
286         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
287         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
288         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
289
290 2011-09-01  Adam Barth  <abarth@webkit.org>
291
292         Hide garden-o-matic failure table until hover
293         https://bugs.webkit.org/show_bug.cgi?id=67376
294
295         Reviewed by Dimitri Glazkov.
296
297         This patch removes the failure table for build failures (because it
298         does not make sense) and hides the failure table for test groups until
299         the user hovers over the test failure block, reducing visual noise.
300
301         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
302         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
303         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
304
305 2011-09-01  Adam Barth  <abarth@webkit.org>
306
307         Switch garden-o-matic from commitData.title to commitData.summary
308         https://bugs.webkit.org/show_bug.cgi?id=67375
309
310         Reviewed by Dimitri Glazkov.
311
312         commitData.title is a string provided by Trac, which isn't great in all
313         cases.  commitData.summary is my attempt to find the most important
314         one-line summary of the commit.  This patch switches garden-o-matic
315         over to summary.
316
317         Also, this patch tweaks a bunch of CSS to tighten up the summary page
318         and reduce visual noise.
319
320         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
321         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
322         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
323
324 2011-09-01  Adam Barth  <abarth@webkit.org>
325
326         Group failing tests in garden-o-matic if there are more than three in a folder
327         https://bugs.webkit.org/show_bug.cgi?id=67373
328
329         Reviewed by Dimitri Glazkov.
330
331         Sometimes a failure will cause many tests in a given directory to fail.
332         When that happens, it's better to list the directory as a single item
333         (with a count) rather than spamming all the test names.
334
335         (This patch also updates a bunch of unit test expected results after my last commit.)
336
337         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
338         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
339         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
340         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
341         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
342
343 2011-09-01  Adam Barth  <abarth@webkit.org>
344
345         Lower the visual noise from the failing builders display
346         https://bugs.webkit.org/show_bug.cgi?id=67369
347
348         Reviewed by Dimitri Glazkov.
349
350         This patch ensures that the "Building" row in the failing builders
351         display is always last and dims it by 50% to reduce visual noise.  This
352         lets the gardener focus on the actual failures.
353
354         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
355         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
356         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css: Added.
357
358 2011-09-01  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
359
360         [Qt] Build dependency problems
361         https://bugs.webkit.org/show_bug.cgi?id=38054
362
363         Make clean build after the defines are changed.
364
365         Reviewed by Csaba Osztrogonác.
366
367         * Scripts/webkitdirs.pm:
368         (buildQMakeProject):
369
370 2011-08-31  Adam Barth  <abarth@webkit.org>
371
372         Move DumpRenderTree to WebKitPlatformSupport
373         https://bugs.webkit.org/show_bug.cgi?id=67331
374
375         Reviewed by Darin Fisher.
376
377         This patch update DumpRenderTree to account for the WebKitClient =>
378         WebKitPlatformSupport rename.
379
380         * DumpRenderTree/chromium/NotificationPresenter.cpp:
381         (NotificationPresenter::show):
382         * DumpRenderTree/chromium/Task.cpp:
383         (postTask):
384
385 2011-08-31  Eric Seidel  <eric@webkit.org>
386
387         Add queues.webkit.org/active-bots page to make it easy to see which bots are down
388         https://bugs.webkit.org/show_bug.cgi?id=67314
389
390         Reviewed by Adam Barth.
391
392         Very simple page.  Just lists all the bots, what queue they belong to and what we last heard from them.
393         If we haven't heard from a bot in the last 500 messages (last day or so), then it won't show up here.
394         This makes it very easy for me to see which of my cr-jail bots might be down at any one time.
395
396         I also moved a bunch of code into dashboard.css which belonged there.
397
398         * QueueStatusServer/handlers/activebots.py: Added.
399         * QueueStatusServer/main.py:
400         * QueueStatusServer/stylesheets/dashboard.css:
401         (.queue_bubble):
402         (.queue_name):
403         (.last_heard_from):
404         (.status_text):
405         (.alive):
406         (.behind):
407         (.dead):
408         * QueueStatusServer/templates/activebots.html: Added.
409         * QueueStatusServer/templates/dashboard.html:
410         * QueueStatusServer/templates/recentstatus.html:
411
412 2011-08-31  Oliver Hunt  <oliver@apple.com>
413
414         Move CheckedArithmeticOperations.cpp to the intended location
415
416         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
417         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp: Renamed from Tools/TestWebKitAPI/Tests/CheckedArithmeticOperations.cpp.
418
419 2011-08-31  Elliot Poger  <epoger@google.com>
420
421         add unittest to validate the complete set of Chromium configurations
422         https://bugs.webkit.org/show_bug.cgi?id=67211
423
424         Reviewed by Adam Barth.
425
426         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
427
428 2011-08-31  Nico Weber  <thakis@chromium.org>
429
430         Make ScrollAnimator(Chromium)?Mac check scrollAnimatorEnabled()
431         https://bugs.webkit.org/show_bug.cgi?id=67297
432
433         Reviewed by Tony Chang.
434
435         Explicitly disable smooth scrolling in chromium's DRT.
436
437         * DumpRenderTree/chromium/WebPreferences.cpp:
438         (WebPreferences::applyTo):
439
440 2011-08-31  Oliver Hunt  <oliver@apple.com>
441
442         Add Checked<> tests to windows build
443
444         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
445
446 2011-08-30  Oliver Hunt  <oliver@apple.com>
447
448         Add support for checked arithmetic
449         https://bugs.webkit.org/show_bug.cgi?id=67095
450
451         Reviewed by Sam Weinig.
452
453         Add test cases for Checked<>
454
455         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
456         * TestWebKitAPI/Tests/CheckedArithmeticOperations.cpp: Added.
457
458 2011-08-31  Adam Barth  <abarth@webkit.org>
459
460         Move summary.html to garden-o-matic.html.
461
462         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html.
463         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js.
464         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Removed.
465         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Removed.
466
467 2011-08-31  Noel Gordon  <noel.gordon@gmail.com>
468
469         [chromium] DRT linux should pass nativeKeyCode to plugins
470         https://bugs.webkit.org/show_bug.cgi?id=66679
471
472         Reviewed by Tony Chang.
473
474         * DumpRenderTree/chromium/EventSender.cpp:
475         (EventSender::keyDown):  Call a Chromium Linux GTK helper routine that returns the
476         (simulated) nativeKeyCode for the given input keyboard code.
477
478 2011-08-31  Adam Barth  <abarth@webkit.org>
479
480         Tighen up UI for garden-o-matic tab strip
481         https://bugs.webkit.org/show_bug.cgi?id=67266
482
483         Reviewed by Dimitri Glazkov.
484
485         This patch add CSS to move the tab strip to the edges of the page and
486         to remove some gratuitous border-radius.
487
488         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css:
489         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
490
491 2011-08-31  Adam Barth  <abarth@webkit.org>
492
493         garden-o-matic results view shouldn't be horrifically ugly
494         https://bugs.webkit.org/show_bug.cgi?id=67264
495
496         Reviewed by Dimitri Glazkov.
497
498         Minor tweak to the results view CSS to make it fit in better with the new tabbed UI.
499
500         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
501         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
502         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
503
504 2011-08-31  Adam Barth  <abarth@webkit.org>
505
506         garden-o-matic needs a tabstrip
507         https://bugs.webkit.org/show_bug.cgi?id=67263
508
509         Reviewed by Dimitri Glazkov.
510
511         This patch adds a basic tabstrip to garden-o-matic.  The results
512         details view now opens in the "Results" tab, and the user can flip back
513         and forth between the Summary and the Results tab quickly.  There's
514         also a stub for a "Commits" tab, which is disabled.
515
516         This patch isn't the most beautiful in the world, but it gets the ball
517         rolling on a multi-modal UI.
518
519         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
520         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
521         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
522         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css:
523         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
524
525 2011-08-31  Ai Makabi  <makabi@google.com>
526
527         Extract reference links from reftest test file.
528         https://bugs.webkit.org/show_bug.cgi?id=66838
529
530         Reviewed by Shinichiro Hamaji.
531
532         * Scripts/webkitpy/layout_tests/reftests/__init__.py: Added.
533         * Scripts/webkitpy/layout_tests/reftests/extract_reference_link.py: Added.
534         * Scripts/webkitpy/layout_tests/reftests/extract_reference_link_unittest.py: Added.
535
536 2011-08-03  Philippe Normand  <pnormand@igalia.com>
537
538         [webkitpy] missing log import in common/net/resultsjsonparser.py
539         https://bugs.webkit.org/show_bug.cgi?id=65606
540
541         Reviewed by Martin Robinson.
542
543         * Scripts/webkitpy/common/net/resultsjsonparser.py: Import the logging module.
544
545 2011-08-30  Philippe Normand  <pnormand@igalia.com>
546
547         [stylechecker] complains about NULL usage in some gst_structure_ calls
548         https://bugs.webkit.org/show_bug.cgi?id=67194
549
550         Reviewed by Martin Robinson.
551
552         Don't warn about NULL in some gst_structure_ calls. 0 can't be
553         used for these, a proper sentinel is required.
554
555         * Scripts/webkitpy/style/checkers/cpp.py:
556         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
557
558 2011-08-30  Adam Barth  <abarth@webkit.org>
559
560         Remove old-style UI from garden-o-matic
561         https://bugs.webkit.org/show_bug.cgi?id=67257
562
563         Reviewed by Dimitri Glazkov.
564
565         This code is nowhere near as awesome as the new hotness.  Let's remove
566         it so it doesn't weigh us down.
567
568         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Removed.
569         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/main.js: Removed.
570         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
571         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
572         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/unexpected-passes.js: Removed.
573         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.html: Removed.
574
575 2011-08-30  Takashi Toyoshima  <toyoshim@chromium.org>
576
577         [WebSocket] update pywebsocket to 0.6b5.
578         https://bugs.webkit.org/show_bug.cgi?id=66924
579
580         Reviewed by Kent Tamura.
581
582         pywebsocket 0.6b2 supported minimum features of Hybi-08 specification.
583         Now, pywebsocket 0.6b5 supports full features of Hybi-10 specification.
584         0.6b3 or later supports a closing handshake handler and it is useful to
585         verify client's closing handshake implementation.
586         0.6b4 supports AbortedByUserException. It is useful to eliminate
587         unnecessary server warning messages on intended abnormal closures.
588         0.6b5 supports Python 2.5.1 or Mac 10.5.
589
590         * Scripts/webkitpy/thirdparty/__init__.py:
591         Update download URL and directory path.
592
593 2011-08-30  Dan Bernstein  <mitz@apple.com>
594
595         Test for <rdar://problem/9281695> Add text search API for getting the DOM range of a text match
596         https://bugs.webkit.org/show_bug.cgi?id=67230
597
598         Reviewed by Darin Adler.
599
600         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
601         * TestWebKitAPI/Tests/mac/DOMRangeOfString.html: Added.
602         * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm: Added.
603         (-[DOMRangeOfStringFrameLoadDelegate webView:didFinishLoadForFrame:]):
604         (TestWebKitAPI::TEST):
605
606 2011-08-30  Aaron Colwell  <acolwell@chromium.org>
607
608         Add MediaSource API to HTMLMediaElement
609         https://bugs.webkit.org/show_bug.cgi?id=64731
610
611         Reviewed by Eric Carlson.
612
613         * Scripts/build-webkit:
614
615 2011-08-30  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
616
617         Emit last progress notification before calling dispatchDidFinishLoad
618         https://bugs.webkit.org/show_bug.cgi?id=28851
619
620         Reviewed by Adam Barth.
621
622         Implement dumpProgressFinishedCallback() in the layoutTestController for Qt,
623         Chromium and GTK ports. The first two were simple changes.
624
625         Some refactoring was needed in GTK port to assure that the dumps are emitted
626         correctly and the processing after the page load finished is in the right place.
627
628         To detect the load finished, we use the callback for the "load-status" notifier
629         signal of the top loading frame. And we use the deprecated "load-finished" signal
630         for dumping (if enabled) the progress finished expected output.
631
632         * DumpRenderTree/LayoutTestController.cpp:
633         (LayoutTestController::LayoutTestController):
634         (dumpProgressFinishedCallbackCallback):
635         (LayoutTestController::staticFunctions):
636         * DumpRenderTree/LayoutTestController.h:
637         (LayoutTestController::dumpProgressFinishedCallback):
638         (LayoutTestController::setDumpProgressFinishedCallback):
639         * DumpRenderTree/chromium/LayoutTestController.cpp:
640         (LayoutTestController::LayoutTestController):
641         (LayoutTestController::dumpProgressFinishedCallback):
642         (LayoutTestController::reset):
643         * DumpRenderTree/chromium/LayoutTestController.h:
644         (LayoutTestController::shouldDumpProgressFinishedCallback):
645         (LayoutTestController::setShouldDumpProgressFinishedCallback):
646         * DumpRenderTree/chromium/WebViewHost.cpp:
647         (WebViewHost::didStopLoading):
648         * DumpRenderTree/gtk/DumpRenderTree.cpp:
649         (webViewLoadFinished):
650         (topLoadingFrameLoadFinished):
651         (webFrameLoadStatusNotified):
652         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
653         (LayoutTestController::reset):
654         (LayoutTestController::dumpProgressFinishedCallback):
655         * DumpRenderTree/qt/LayoutTestControllerQt.h:
656
657 2011-08-30  Filip Pizlo  <fpizlo@apple.com>
658
659         JavaScriptCore does not have a good mechanism for performance
660         regression testing
661         https://bugs.webkit.org/show_bug.cgi?id=67177
662
663         Reviewed by Darin Adler.
664         
665         Added a new script, which allows for testing one, two, or more VMs
666         at once on SunSpider, V8, and Kraken benchmarks.  Benchmark/VM runs
667         are interleaved at random to minimize systematics.  The results
668         that bencher prints includes all possible relevant information about
669         how bencher was invoked.  Bencher can be easily used to measure
670         performance changes down to fractions of a percent.
671         
672         Bencher also includes experimental support for running benchmarks in
673         a DumpRenderTree release build.  This works in SunSpider and V8, but
674         not yet in Kraken.  Running benchmarks in DumpRenderTree more
675         closely mimics the performance when running in browser.
676
677         * Scripts/bencher: Added.
678
679 2011-08-29  Alexey Proskuryakov  <ap@apple.com>
680
681         DumpRenderTree should begin each test with an empty cookie store
682         https://bugs.webkit.org/show_bug.cgi?id=63545
683         <rdar://problem/5666907>
684
685         Reviewed by Darin Adler.
686
687         * DumpRenderTree/mac/DumpRenderTree.mm:
688         (resetDefaultsToConsistentValues):
689         (setDefaultsToConsistentValuesForTesting):
690         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
691         (LayoutTestController::setAlwaysAcceptCookies):
692         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
693         (WTR::InjectedBundle::beginTesting):
694         Use new SPIs to manipulate sessions.
695
696 2011-08-30  Sheriff Bot  <webkit.review.bot@gmail.com>
697
698         Unreviewed, rolling out r94055 and r94057.
699         http://trac.webkit.org/changeset/94055
700         http://trac.webkit.org/changeset/94057
701         https://bugs.webkit.org/show_bug.cgi?id=67191
702
703         Many failures on Mac 10.5 (Requested by toyoshim on #webkit).
704
705         * Scripts/webkitpy/thirdparty/__init__.py:
706
707 2011-08-30  Adam Barth  <abarth@webkit.org>
708
709         Chromium Android should not be a core builder
710         https://bugs.webkit.org/show_bug.cgi?id=67184
711
712         Reviewed by Ryosuke Niwa.
713
714         This bot hasn't been consistently green yet because it has never actually run!
715
716         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
717         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
718
719 2011-08-30  Takashi Toyoshima  <toyoshim@chromium.org>
720
721         [WebSocket] update pywebsocket to 0.6b4.
722         https://bugs.webkit.org/show_bug.cgi?id=66924
723
724         Reviewed by Kent Tamura.
725
726         pywebsocket 0.6b2 supported minimum features of Hybi-08 specification.
727         Now, pywebsocket 0.6b4 supports full features of Hybi-10 specification.
728         0.6b3 or later supports a closing handshake handler and it is useful to
729         verify client's closing handshake implementation.
730         0.6b4 supports AbortedByUserException. It is useful to eliminate
731         unnecessary server warning messages on intended abnormal closures.
732
733         * Scripts/webkitpy/thirdparty/__init__.py:
734         Update download URL and directory path.
735
736 2011-08-29  Tom Zakrajsek  <tomz@codeaurora.org>
737
738         sheriffbot "usage" help statements are wrong
739         https://bugs.webkit.org/show_bug.cgi?id=67170
740
741         Reviewed by Adam Barth.
742
743         * Scripts/webkitpy/tool/bot/irc_command.py:
744         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
745         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
746
747 2011-08-29  Adam Barth  <abarth@webkit.org>
748
749         Add support for chomium-mac (non-CoreGraphics) baselines
750         https://bugs.webkit.org/show_bug.cgi?id=67163
751
752         Reviewed by Eric Seidel.
753
754         This patch teaches the non-CG chromium-mac bots to look at non-CG
755         baselines.  However, the patch still leaves CG as the default set of
756         baselines.
757
758         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
759         * Scripts/webkitpy/common/config/build.py:
760         * Scripts/webkitpy/common/config/build_unittest.py:
761         * Scripts/webkitpy/layout_tests/port/builders.py:
762         * Scripts/webkitpy/layout_tests/port/chromium.py:
763         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
764         * Scripts/webkitpy/layout_tests/port/factory.py:
765         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
766         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
767         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
768         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
769
770 2011-08-29  Shawn Singh  <shawnsingh@chromium.org>
771
772         Small fix in chromium port of new-run-webkit-tests.
773         https://bugs.webkit.org/show_bug.cgi?id=67078
774
775         Reviewed by Dirk Pranke.
776
777         * Scripts/webkitpy/layout_tests/port/chromium.py:
778
779 2011-08-29  Sheriff Bot  <webkit.review.bot@gmail.com>
780
781         Unreviewed, rolling out r93987, r93992, r93995, r93998, and
782         r93999.
783         http://trac.webkit.org/changeset/93987
784         http://trac.webkit.org/changeset/93992
785         http://trac.webkit.org/changeset/93995
786         http://trac.webkit.org/changeset/93998
787         http://trac.webkit.org/changeset/93999
788         https://bugs.webkit.org/show_bug.cgi?id=67147
789
790         Many failing tests (Requested by ap on #webkit).
791
792         * DumpRenderTree/mac/DumpRenderTree.mm:
793         (setDefaultsToConsistentValuesForTesting):
794         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
795         (WTR::InjectedBundle::beginTesting):
796
797 2011-08-26  Alexey Proskuryakov  <ap@apple.com>
798
799         DumpRenderTree should begin each test with an empty cookie store
800         https://bugs.webkit.org/show_bug.cgi?id=63545
801         <rdar://problem/5666907>
802
803         Reviewed by Darin Adler.
804
805         * DumpRenderTree/mac/DumpRenderTree.mm:
806         (setDefaultsToConsistentValuesForTesting):
807         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
808         (WTR::InjectedBundle::beginTesting):
809         Tell WebCore to use a temporary session, starting with a clean cookie store.
810
811 2011-08-23  Chris Marrin  <cmarrin@apple.com>
812
813         [mac] requestAnimationFrame support for mac port
814         https://bugs.webkit.org/show_bug.cgi?id=59146
815
816         Reviewed by Simon Fraser.
817
818         Add support for request-animation-callback flag
819
820         * Scripts/build-webkit:
821
822 2011-08-27  Peter Beverloo  <peter@chromium.org>
823
824         Add a build bot for Chromium with OS(ANDROID)
825         https://bugs.webkit.org/show_bug.cgi?id=66687
826
827         Reviewed by Adam Barth.
828
829         * BuildSlaveSupport/build.webkit.org-config/config.json:
830
831 2011-08-27  Peter Beverloo  <peter@chromium.org>
832
833         Update the master build bot configuration script to properly
834         deal with the --chromium-android switch.
835         https://bugs.webkit.org/show_bug.cgi?id=66687
836
837         The --chromium-android switch is needed when running
838         update-webkit-chromium and build-webkit, as it'll tell the
839         scripts to pull in the right dependencies and cross-compile
840         WebKit using the Android NDK.
841
842         Reviewed by Adam Barth.
843
844         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
845
846 2011-08-27  Peter Beverloo  <peter@chromium.org>
847
848         Teach the update and build scripts how to handle dependencies
849         and cross-compiling rules for the Chromium port on OS(ANDROID).
850         https://bugs.webkit.org/show_bug.cgi?id=66687
851
852         Reviewed by Adam Barth.
853
854         * Scripts/build-webkit:
855         * Scripts/update-webkit:
856         * Scripts/update-webkit-chromium:
857         * Scripts/webkitdirs.pm:
858         (argumentsForConfiguration):
859         (isChromium):
860         (isChromiumAndroid):
861         (determineIsChromiumAndroid):
862         (buildChromium):
863
864 2011-08-26  Adam Barth  <abarth@webkit.org>
865
866         garden-o-matic should let me know that I need to run the local server
867         https://bugs.webkit.org/show_bug.cgi?id=66985
868
869         Reviewed by Dimitri Glazkov.
870
871         The patch triggers an alert dialog whenever the user tries to use a
872         feature that requires the local server.
873
874         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
875         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
876         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
877
878 2011-08-26  Dimitri Glazkov  <dglazkov@chromium.org>
879
880         garden-o-matic summary view should have pretty commit data information.
881         https://bugs.webkit.org/show_bug.cgi?id=67069
882
883         Reviewed by Adam Barth.
884
885         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added support for styling commit data.
886         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Changed tests.
887         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Defined global anchor color.
888         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Styled commit data.
889
890 2011-08-26  Dimitri Glazkov  <dglazkov@chromium.org>
891
892         Tweak the use of Open Sans in garden-o-matic summary view to make it look decent on Windows and Linux.
893         https://bugs.webkit.org/show_bug.cgi?id=67066
894
895         Reviewed by Adam Barth.
896
897         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Tweaked.
898         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Ditto.
899
900 2011-08-26  Raphael Kubo da Costa  <kubo@profusion.mobi>
901
902         [DRT] Include cairo.h in PixelDumpSupportCairo.h for EFL too.
903         https://bugs.webkit.org/show_bug.cgi?id=67041
904
905         Reviewed by Martin Robinson.
906
907         This is a follow-up to r89053: EFL's PixelDumpSupportEfl.cpp includes
908         PixelDumpSupportCairo.h, but the latter was #including cairo.h only
909         when the GTK+ port was being built.
910
911         * DumpRenderTree/cairo/PixelDumpSupportCairo.h:
912
913 2011-08-26  Dimitri Glazkov  <dglazkov@chromium.org>
914
915         Clean up and line up layout in garden-o-matic summary view.
916         https://bugs.webkit.org/show_bug.cgi?id=67057
917
918         1) Renamed ui.notifications.TestFailures to ui.notifications.TestsFailing to match BuildersFailing;
919         2) Rearranged DOM structure a bit to accommodate recent changes;
920         3) Added minimal CSS to line things up.
921
922         Reviewed by Adam Barth.
923
924         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Renamed TestFailures to TestsFailing.
925         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js: Added mocks for BuildersFailing.
926         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js: Renamed TestFailures to TestsFailing.
927         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js: Updated tests.
928         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Changed DOM structure.
929         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated tests.
930         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Tweaked common appearance.
931         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Added minimal layout/style.
932         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Added Google Web Fonts hook.
933         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Ditto.
934
935 2011-08-26  Alice Liu  <alice.liu@apple.com>
936
937         https://bugs.webkit.org/show_bug.cgi?id=66823
938         Add the request info to the WebPageProxy::CreateNewPage message
939
940         Reviewed by Anders Carlsson.
941
942         Update function declarations with additional parameter:
943         * MiniBrowser/gtk/BrowserWindow.c:
944         (createNewPage):
945         * MiniBrowser/mac/BrowserWindowController.m:
946         (createNewPage):
947         * MiniBrowser/win/BrowserView.cpp:
948         (createNewPage):
949         * WebKitTestRunner/TestController.cpp:
950         (WTR::TestController::createOtherPage):
951         * WebKitTestRunner/TestController.h:
952
953 2011-08-26  Noel Gordon  <noel.gordon@gmail.com>
954
955         Make show-pretty-diff work on linux
956         https://bugs.webkit.org/show_bug.cgi?id=67017
957
958         Reviewed by Adam Barth.
959
960         * Scripts/show-pretty-diff:
961
962 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
963
964         Reorganize garden-o-matic CSS files to match JS-built views.
965         https://bugs.webkit.org/show_bug.cgi?id=66998
966
967         Reviewed by Adam Barth.
968
969         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Added.
970         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Added.
971         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css: Added.
972         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css: Removed.
973         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Changed to use new CSS files.
974         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Ditto.
975
976 2011-08-25  Adam Barth  <abarth@webkit.org>
977
978         garden-o-matic should be able to roll out patches
979         https://bugs.webkit.org/show_bug.cgi?id=66982
980
981         Reviewed by Dimitri Glazkov.
982
983         This patch just wires the rollout event through the controller to the
984         local server, which is already set up to perform rollouts.
985
986         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
987         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
988         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
989         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
990
991 2011-08-25  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
992
993         [Qt] [WK2] Assert in computeViewportAttributes when MiniBrowser started with -touch
994         https://bugs.webkit.org/show_bug.cgi?id=66951
995
996         Reviewed by Andreas Kling.
997
998         Function computeViewportAttributes() gets called when height is still 0 because MiniBrowser sets
999         width and height one by one and setWidth cause geometryChange event in QTouchWebView. 
1000
1001         * MiniBrowser/qt/BrowserView.cpp:
1002         (BrowserView::resizeEvent):
1003
1004 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
1005
1006         garden-o-matic summary view should provide information on builders still in flight.
1007         https://bugs.webkit.org/show_bug.cgi?id=66992
1008
1009         Reviewed by Adam Barth.
1010
1011         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Added grabbing the list of in-flight builders.
1012         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js: Added buildersInFlightForRevision.
1013         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js: Added tests.
1014         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Split off updating builder results to own method.
1015         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added tests.
1016
1017 2011-08-25  Adam Barth  <abarth@webkit.org>
1018
1019         webkit-patch rebaseline-expectations don't work when run outside the root
1020         https://bugs.webkit.org/show_bug.cgi?id=66966
1021
1022         Reviewed by Eric Seidel.
1023
1024         Turns out tool.path() used to be relative, which caused problems when
1025         running webkit-patch outside the root directory.  This patch makes it
1026         absolute.  I checked all callers, and they all appear to want this
1027         behavior.
1028
1029         It was unclear to me how to test this change because we only really
1030         have a testing strategy for webkitpy, not for the main script.
1031
1032         * Scripts/webkit-patch:
1033
1034 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
1035
1036         garden-o-matic summary needs a mock view that could be used for working on styling
1037         https://bugs.webkit.org/show_bug.cgi?id=66971
1038
1039         Reviewed by Adam Barth.
1040
1041         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js: Added.
1042         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Added.
1043
1044 2011-08-25  Anders Carlsson  <andersca@apple.com>
1045
1046         Return the correct value for NPNVsupportsCarbonBool
1047         https://bugs.webkit.org/show_bug.cgi?id=66964
1048
1049         Add a test.
1050
1051         Reviewed by Adam Roben.
1052
1053         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1054         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Added.
1055         (SupportsCarbonEventModel::SupportsCarbonEventModel):
1056         (SupportsCarbonEventModel::testConvert):
1057         (SupportsCarbonEventModel::runTest):
1058         (SupportsCarbonEventModel::NPP_New):
1059
1060 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
1061
1062         garden-o-matic summary view should not be broken.
1063
1064         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css:
1065         (table.comparison): Added more specificity.
1066
1067 2011-08-25  Adam Barth  <abarth@webkit.org>
1068
1069         This command has been broken for a while.  This patch updates the
1070         callsite to the new API.
1071
1072         * Scripts/webkitpy/tool/commands/rebaseline.py:
1073
1074 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
1075
1076         garden-o-matic needs a way to report where and how tests are failing in the summary view.
1077         https://bugs.webkit.org/show_bug.cgi?id=66955
1078
1079         Introduce FailureGrid, your one-stop failure-indicating destination. 
1080
1081         Reviewed by Adam Barth.
1082
1083         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html: Added new scripts.
1084         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js: Added.
1085         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js: Added.
1086         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Updated to use FailureGrid.
1087         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated tests.
1088         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Added new scripts.
1089
1090 2011-08-25  Igor Oliveira  <igor.oliveira@openbossa.org>
1091
1092         Add myself to the committers list
1093         https://bugs.webkit.org/show_bug.cgi?id=66941
1094
1095         Reviewed by Andreas Kling.
1096
1097         * Scripts/webkitpy/common/config/committers.py:
1098
1099 2011-08-25  Sheriff Bot  <webkit.review.bot@gmail.com>
1100
1101         Unreviewed, rolling out r93767.
1102         http://trac.webkit.org/changeset/93767
1103         https://bugs.webkit.org/show_bug.cgi?id=66931
1104
1105         Broke Qt bot. (Requested by yutak on #webkit).
1106
1107         * Scripts/webkitpy/thirdparty/__init__.py:
1108
1109 2011-08-25  Takashi Toyoshima  <toyoshim@chromium.org>
1110
1111         [WebSocket] update pywebsocket to 0.6b3 which supports closing handshake test
1112         https://bugs.webkit.org/show_bug.cgi?id=66924
1113
1114         Reviewed by Kent Tamura.
1115
1116         * Scripts/webkitpy/thirdparty/__init__.py:
1117
1118 2011-08-24  Adam Barth  <abarth@webkit.org>
1119
1120         The user can't close the details view in garden-o-matic
1121         https://bugs.webkit.org/show_bug.cgi?id=66911
1122
1123         Reviewed by Dimitri Glazkov.
1124
1125         In addition to adding a close button, this patch changes the test
1126         selector to use a <select> element and refactors the test selector to
1127         share code with the builder selector.
1128
1129         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1130         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
1131         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js:
1132         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1133
1134 2011-08-24  James Robinson  <jamesr@chromium.org>
1135
1136         [chromium] Stacktrace not in test output when a test crashes
1137         https://bugs.webkit.org/show_bug.cgi?id=66806
1138
1139         Reviewed by Dirk Pranke.
1140
1141         Appends the .error and .text output when a test crashes since on chromium the .text contains the actual stack
1142         trace.
1143
1144         * Scripts/webkitpy/layout_tests/port/chromium.py:
1145
1146 2011-08-24  Adam Barth  <abarth@webkit.org>
1147
1148         Remove empty directory.
1149
1150         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui: Removed.
1151
1152 2011-08-24  Adam Barth  <abarth@webkit.org>
1153
1154         Finish writing up details-view in garden-o-matic
1155         https://bugs.webkit.org/show_bug.cgi?id=66891
1156
1157         Reviewed by Dimitri Glazkov.
1158
1159         This patch mostly just copies a bunch of CSS from main.css to
1160         summary.css.  Presumably we'll delete main.css soon.
1161
1162         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1163         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
1164         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js:
1165         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css:
1166         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
1167
1168 2011-08-24  James Robinson  <jamesr@chromium.org>
1169
1170         Some compositing LayoutTests flakily crashing on Mac 10.6
1171         https://bugs.webkit.org/show_bug.cgi?id=66740
1172
1173         Reviewed by Adam Barth.
1174
1175         Null-check obj->pluginTest before dereferencing it. This can be null in chromium if the plugin load fails, for
1176         example if the test attempts to load a PDF plugin the load will fail since we don't have such a thing in the
1177         chromium configuration.
1178
1179         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1180         (NPP_Destroy):
1181
1182 2011-08-24  Anton D'Auria  <adauria@apple.com>
1183
1184         No review necessary.
1185
1186         Adding myself to list of committers.
1187
1188         * Scripts/webkitpy/common/config/committers.py:
1189
1190 2011-08-24  Avi Drissman  <avi@google.com>
1191
1192         Crash when restoring NSGraphicsContext when running the Chromium GPU layout tests on Mac
1193         https://bugs.webkit.org/show_bug.cgi?id=66875
1194
1195         Reviewed by James Robinson.
1196
1197         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
1198         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
1199
1200 2011-08-23  Dimitri Glazkov  <dglazkov@chromium.org>
1201
1202         Make notifications appear in time order again.
1203         https://bugs.webkit.org/show_bug.cgi?id=66815
1204
1205         Reviewed by Adam Barth.
1206
1207         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added setting index of the notification.
1208         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated the test.
1209
1210 2011-08-23  James Robinson  <jamesr@chromium.org>
1211
1212         [chromium] Need a way to test lost compositor context recovery
1213         https://bugs.webkit.org/show_bug.cgi?id=66820
1214
1215         Reviewed by Kenneth Russell.
1216
1217         Exposes a LayoutTestController interface in chromium to simulate a
1218         lost compositor context.
1219
1220         * DumpRenderTree/chromium/LayoutTestController.cpp:
1221         (LayoutTestController::LayoutTestController):
1222         (LayoutTestController::loseCompositorContext):
1223         * DumpRenderTree/chromium/LayoutTestController.h:
1224
1225 2011-08-23  Dimitri Glazkov  <dglazkov@chromium.org>
1226
1227         Change garden-o-matic frontend builder array to be a configuration map.
1228         https://bugs.webkit.org/show_bug.cgi?id=66816
1229
1230         Reviewed by Adam Barth.
1231
1232         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js: Made kBuilders a map, with value being a configuration object.
1233         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: Adjusted callsites to expect a map.
1234         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/main.js: Ditto.
1235         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js: Ditto.
1236         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Ditto.
1237
1238 2011-08-23  Cary Clark  <caryclark@google.com>
1239
1240         Turn WebCanvas into CGContext before drawing scrollbar (DRT using Skia on Mac)
1241         https://bugs.webkit.org/show_bug.cgi?id=66803
1242
1243         This fixes the WebKit Canaries, in particular avoids a crash on tests
1244         like css1/basic/comments.html.
1245
1246         Reviewed by James Robinson.
1247
1248         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
1249         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
1250         The NSGraphicsContext call graphicsContextWithGraphicsPort takes a void*
1251         parameter, so it took a WebCanvas* (mapped to SkCanvas* in Skia-land)
1252         and treated it as if it were a CGContextRef.
1253
1254 2011-08-23  Patrick Gansterer  <paroga@webkit.org>
1255
1256         Fix mergeChangeLogs test on native windows
1257         https://bugs.webkit.org/show_bug.cgi?id=66797
1258
1259         Reviewed by Adam Roben.
1260
1261         Windows has no /tmp/ directory and the "TMPDIR" environment variable isn't set in the default setup.
1262         Add the "TEMP" environment variable as additional source for the temporary directory used in writeTempFile.
1263
1264         * Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl:
1265         (writeTempFile):
1266
1267 2011-08-23  Dimitri Glazkov  <dglazkov@chromium.org>
1268
1269         garden-o-matic relative time is wrong and updates too frequently.
1270         https://bugs.webkit.org/show_bug.cgi?id=66802
1271
1272         Reviewed by Adam Barth.
1273
1274         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js: Changed to account for rounding correctly.
1275         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js: Updated tests.
1276         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: Upped the interval to 1 minute.
1277
1278 2011-08-23  Patrick Gansterer  <paroga@webkit.org>
1279
1280         Add missing quotes around filenames in mergeChangeLogs
1281         https://bugs.webkit.org/show_bug.cgi?id=66794
1282
1283         Reviewed by Adam Roben.
1284
1285         * Scripts/VCSUtils.pm:
1286         (mergeChangeLogs):
1287
1288 2011-08-23  Patrick Gansterer  <paroga@webkit.org>
1289
1290         webkit-perl tests fail on win32 Perl due to lack of list form of pipe open implementation
1291         https://bugs.webkit.org/show_bug.cgi?id=49080
1292
1293         Reviewed by Adam Roben.
1294
1295         Use the string form of pipe open instead (like we do at all other places).
1296
1297         * Scripts/VCSUtils.pm:
1298         (mergeChangeLogs):
1299
1300 2011-08-23  Adam Barth  <abarth@webkit.org>
1301
1302         garden-o-matic summary should be able to examine failures
1303         https://bugs.webkit.org/show_bug.cgi?id=66748
1304
1305         Reviewed by Dimitri Glazkov.
1306
1307         This patch refactors a bunch of code from summary.js to independent
1308         controllers in controllers.js.  This patch also contains the first
1309         iteration of binding the "examine" event to a the behavior showing the
1310         details view for the tests.  There's more work to do here to make this
1311         work properly (and elegantly), but this patch is a start.
1312
1313         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
1314         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
1315         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1316         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers/rebaseline.js:
1317         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
1318         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
1319         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
1320         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
1321         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
1322
1323 2011-08-23  Adam Barth  <abarth@webkit.org>
1324
1325         webkitpy/common/config/build.py shouldn't mention non-existant Android directory
1326         https://bugs.webkit.org/show_bug.cgi?id=66737
1327
1328         Reviewed by Steve Block.
1329
1330         This directory doesn't exist anymore now that the Android port shares
1331         more code with Chromium.
1332
1333         * Scripts/webkitpy/common/config/build.py:
1334
1335 2011-08-22  Eric Seidel  <eric@webkit.org>
1336
1337         Hack start-queue.sh in an attempt to resurrect the cr-jail-1 cr-mac-ews bot.
1338         I won't have ssh access to the bot again for a couple days, so
1339         attempting to fix by changing this script.  If this doesn't
1340         work we'll just live with the it hung for now.
1341
1342         Unreviewed.
1343
1344         * EWSTools/start-queue.sh:
1345
1346 2011-08-22  Dimitri Glazkov  <dglazkov@chromium.org>
1347
1348         webkit-patch rebaseline-expectations command should not rearrange the entire test_expectations.txt file.
1349         https://bugs.webkit.org/show_bug.cgi?id=66727
1350
1351         Reviewed by Adam Barth.
1352
1353         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Made it possible to run TestExpectationSerializer without a TestConfigurationConverter,
1354             in which case the serializer treats all expectations as unparsed.
1355         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added unit tests.
1356
1357 2011-08-22  Dimitri Glazkov  <dglazkov@chromium.org>
1358
1359         Update unit test expectations after r93530.
1360
1361         * Scripts/webkitpy/layout_tests/port/factory_unittest.py: Updated.
1362         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: Ditto.
1363
1364 2011-08-22  Dimitri Glazkov  <dglazkov@chromium.org>
1365
1366         [Chromium] Expand CPU/GPU/Skia/CG into a matrix in graphics_type.
1367         https://bugs.webkit.org/show_bug.cgi?id=66705
1368
1369         Reviewed by Adam Barth.
1370
1371         * Scripts/webkitpy/layout_tests/port/chromium.py: Added plumbing for CG graphics types.
1372         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Adjusted unit test.
1373
1374 2011-08-22  James Robinson  <jamesr@chromium.org>
1375
1376         [chromium] Update builder names for chromium gpu bots due to CG switchover
1377         https://bugs.webkit.org/show_bug.cgi?id=66693
1378
1379         Reviewed by Dirk Pranke.
1380
1381         Update the port and builder names for the chromium mac gpu bots to
1382         account for the CG transition.
1383
1384         * Scripts/webkitpy/layout_tests/port/builders.py:
1385
1386 2011-08-22  Dirk Pranke  <dpranke@chromium.org>
1387
1388         fix the GPU bot names on the layout test dashboard
1389         https://bugs.webkit.org/show_bug.cgi?id=66697
1390
1391         Reviewed by Dimitri Glazkov.
1392
1393         * TestResultServer/static-dashboards/builders.js:
1394
1395 2011-08-22  Dimitri Glazkov  <dglazkov@chromium.org>
1396
1397         garden-o-matic's relative time display should be updated regularly.
1398         https://bugs.webkit.org/show_bug.cgi?id=66682
1399
1400         Reviewed by Adam Barth.
1401
1402         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Moved Time to ui.Time, added code for regular updates.
1403         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Changed to use ui.Time.
1404         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js: Added tests.
1405
1406 2011-08-22  Xianzhu Wang  <wangxianzhu@chromium.org>
1407
1408         Pass --makeargs of build-webkit to chromium linux builder
1409         https://bugs.webkit.org/show_bug.cgi?id=66361
1410
1411         Reviewed by Tony Chang.
1412
1413         * Scripts/build-webkit:
1414         * Scripts/webkitdirs.pm:
1415         (buildChromiumMakefile):
1416         (buildChromium):
1417
1418 2011-08-22  Peter Beverloo  <peter@chromium.org>
1419
1420         Add myself to the contributor list.
1421         https://bugs.webkit.org/show_bug.cgi?id=66674
1422
1423         Reviewed by Tony Gentilcore.
1424
1425         * Scripts/webkitpy/common/config/committers.py:
1426
1427 2011-08-22  Balazs Kelemen  <kbalazs@webkit.org>
1428
1429         [Qt] ImageDiff does not consider --tolerance
1430         https://bugs.webkit.org/show_bug.cgi?id=66299
1431
1432         Reviewed by Csaba Osztrogonác.
1433
1434         * DumpRenderTree/qt/ImageDiff.cpp:
1435         (main):
1436
1437 2011-08-22  Csaba Osztrogonác  <ossy@webkit.org>
1438
1439         Update contributor list.
1440
1441         Reviewed by Zoltan Herczeg.
1442
1443         * Scripts/webkitpy/common/config/committers.py:
1444
1445 2011-08-22  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
1446
1447         [ORWT] Fix --reset-results --add-platform-exceptions combo
1448         https://bugs.webkit.org/show_bug.cgi?id=65464
1449
1450         Reviewed by Csaba Osztrogonác.
1451
1452         * Scripts/old-run-webkit-tests:
1453
1454 2011-08-20  Adam Barth  <abarth@webkit.org>
1455
1456         garden-o-matic summary.html should have UI for examining failures
1457         https://bugs.webkit.org/show_bug.cgi?id=66625
1458
1459         Reviewed by Dimitri Glazkov.
1460
1461         This patch introduces the notion of UI actions and converts our
1462         existing manual <button> manipulation with this new abstraction.  The
1463         patch also adds an Examine button to failure notifications.  In a
1464         future patch, I'll add a controller that wires this button up to
1465         something useful.
1466
1467         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1468         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
1469         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js: Added.
1470         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js: Added.
1471         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
1472         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
1473         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1474         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
1475
1476 2011-08-20  Adam Barth  <abarth@webkit.org>
1477
1478         garden-o-matic summary page should indiciate compile failures
1479         https://bugs.webkit.org/show_bug.cgi?id=66624
1480
1481         Reviewed by Dimitri Glazkov.
1482
1483         This patch creates a notification-based UI for build failures.  The new
1484         UI displays the same information that used to be displayed in the
1485         infobar.  There's lots of room for improvement in surfacing more
1486         information, but this is a start.
1487
1488         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
1489         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
1490         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
1491
1492 2011-08-19  James Robinson  <jamesr@chromium.org>
1493
1494         [chromium] Default to experimental-fully-parallel mode for chromium gpu port
1495         https://bugs.webkit.org/show_bug.cgi?id=66606
1496
1497         Reviewed by Dirk Pranke.
1498
1499         The chromium GPU configuration does not (currently) contain any tests
1500         incompatible with --experimental-fully-parallel, and this flag is a
1501         significan speedup because of the directory canvas/philip/tests which
1502         contains 802 tests in the same directory. Setting this option by
1503         default on this configuration is a 2x speed in release, 44s to 22s,
1504         and a 3x speedup in debug, 223s to 77s, on linux on a 16 core machine.
1505
1506         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1507         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1508         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1509
1510 2011-08-19  Sheriff Bot  <webkit.review.bot@gmail.com>
1511
1512         Unreviewed, rolling out r93426.
1513         http://trac.webkit.org/changeset/93426
1514         https://bugs.webkit.org/show_bug.cgi?id=66607
1515
1516         Broke the Mac build by not building gtest.framework anymore
1517         (Requested by andersca on #webkit).
1518
1519         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
1520
1521 2011-08-19  James Robinson  <jamesr@chromium.org>
1522
1523         [chromium] Chromium GPU layout tests should use the normal process number selection, not force 1 worker
1524         https://bugs.webkit.org/show_bug.cgi?id=66603
1525
1526         Reviewed by Dirk Pranke.
1527
1528         The various ChromiumGpu ports should use the same child worker
1529         selection logic as other ports so they can run with full
1530         parallelization on multicore systems.
1531
1532         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1533         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1534
1535 2011-08-19  Alok Priyadarshi  <alokp@chromium.org>
1536
1537         [chromium] Remove dependency of WebThemeControlDRTWin on skia::PlatformCanvas
1538         https://bugs.webkit.org/show_bug.cgi?id=66570
1539
1540         Reviewed by Mihai Parparita.
1541
1542         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
1543         (WebThemeControlDRTWin::draw):
1544         (WebThemeControlDRTWin::drawTextField):
1545         (WebThemeControlDRTWin::drawProgressBar):
1546         * DumpRenderTree/chromium/WebThemeControlDRTWin.h:
1547
1548 2011-08-18  Dmitry Lomov  <dslomov@google.com>
1549
1550         TestWebKitAPI breaks on Windows due to fast malloc incompatibility.
1551         https://bugs.webkit.org/show_bug.cgi?id=66521
1552
1553         This patch ensures that gtest uses new and delete operators that are defined in JavaScriptCore.
1554
1555         Reviewed by David Levin.
1556
1557         * TestWebKitAPI/Tests/WTF/StringOperators.cpp: Removed redefinition of JS_EXPORTDATA.
1558
1559 2011-08-19  Adam Roben  <aroben@apple.com>
1560
1561         Add project file changes I left out in r93417
1562
1563         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1564
1565 2011-08-19  Adam Roben  <aroben@apple.com>
1566
1567         Add a helper class for swizzling ObjC instance methods to TestWebKitAPI
1568
1569         Fixes <http://webkit.org/b/66565> TestWebKitAPI needs a way to override instance methods of
1570         NSScreen
1571
1572         Reviewed by Anders Carlsson.
1573
1574         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
1575
1576         * TestWebKitAPI/Tests/TestWebKitAPI/mac/InstanceMethodSwizzler.mm: Added.
1577         (-[SimpleObject setValue:]): Original implementation.
1578
1579         (TestWebKitAPI::setValue2):
1580         (TestWebKitAPI::setValue3):
1581         Swizzled implementations.
1582
1583         (TestWebKitAPI::TEST): Test that we can swizzle and re-swizzle and un-swizzle an ObjC
1584         instance method.
1585
1586         * TestWebKitAPI/mac/InstanceMethodSwizzler.h: Added.
1587         * TestWebKitAPI/mac/InstanceMethodSwizzler.mm: Added.
1588         (TestWebKitAPI::InstanceMethodSwizzler::InstanceMethodSwizzler): Swizzle the method.
1589         (TestWebKitAPI::InstanceMethodSwizzler::~InstanceMethodSwizzler): Unswizzle the method.
1590
1591 2011-08-19  Tom Zakrajsek  <tomz@codeaurora.org>
1592
1593         Fix _path_to_apache() error reporting
1594         https://bugs.webkit.org/show_bug.cgi?id=66486
1595
1596         Reviewed by Ryosuke Niwa.
1597
1598         * Scripts/webkitpy/layout_tests/port/webkit.py:
1599
1600 2011-08-19  Adam Roben  <aroben@apple.com>
1601
1602         Windows build fix after r93404
1603
1604         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp: Added missing #include.
1605
1606 2011-08-19  Tony Gentilcore  <tonyg@chromium.org>
1607
1608         Add leandrogracia to the committers list
1609         https://bugs.webkit.org/show_bug.cgi?id=66552
1610
1611         Also fix line endings in file.
1612
1613         No reviewed required.
1614
1615         * Scripts/webkitpy/common/config/committers.py:
1616
1617 2011-08-19  Amruth Raj  <amruthraj@motorola.com>
1618
1619         Fix compilation issue in WebKitTestRunner
1620         https://bugs.webkit.org/show_bug.cgi?id=66554
1621
1622         Reviewed by Martin Robinson.
1623
1624         * WebKitTestRunner/PixelDumpSupport.cpp:
1625
1626 2011-08-19  Adam Roben  <aroben@apple.com>
1627
1628         Pull some of DynamicDeviceScaleFactor's code up into a shareable base class
1629
1630         This will make it easier to write other WebKit-agnostic tests
1631
1632         Fixes <http://webkit.org/b/66558> Would like to be able to reuse DynamicDeviceScaleFactor's
1633         code in other WebKit-agnostic tests
1634
1635         Reviewed by Anders Carlsson.
1636
1637         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
1638
1639         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm: Fixed copyright. Moved a bunch of
1640         code to WebKitAgnosticTest.h/mm. Changed to inherit from WebKitAgnosticTest.
1641         (TestWebKitAPI::DynamicDeviceScaleFactor::url): Simple getter.
1642         (TestWebKitAPI::DynamicDeviceScaleFactor::didLoadURL): Calls through to runTest.
1643         (TestWebKitAPI::DynamicDeviceScaleFactor::runTest): Removed loading code which
1644         WebKitAgnosticTest handles for us.
1645         (TestWebKitAPI::TEST_F): Removed view-creation code which WebKitAgnosticTest handles for us.
1646
1647         * TestWebKitAPI/mac/WebKitAgnosticTest.h: Added. Code came from DynamicDeviceScaleFactor.
1648         (TestWebKitAPI::WebKitAgnosticTest::loadAndWaitUntilDone): Code came from
1649         DynamicDeviceScaleFactor::runTest.
1650
1651         * TestWebKitAPI/mac/WebKitAgnosticTest.mm: Copied from Tools/TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm.
1652         (TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test): Code came from
1653         DynamicDeviceScaleFactor.WebKit.
1654         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test): Code came from
1655         DynamicDeviceScaleFactor.WebKit2.
1656
1657 2011-08-19  Adam Roben  <aroben@apple.com>
1658
1659         Clean up #includes in TestWebKitAPI
1660
1661         Fixes <http://webkit.org/b/66556> TestWebKitAPI's prefix header isn't very helpful
1662
1663         Reviewed by Anders Carlsson.
1664
1665         * TestWebKitAPI/TestWebKitAPIPrefix.h: Added wtf/Platform.h. Added gtest/gtest.h for C++
1666         files and WebKit/WebKit.h for ObjC files.
1667
1668         * TestWebKitAPI/InjectedBundleController.cpp:
1669         * TestWebKitAPI/JavaScriptTest.h:
1670         * TestWebKitAPI/PlatformUtilities.h:
1671         * TestWebKitAPI/PlatformWebView.h:
1672         * TestWebKitAPI/Test.h:
1673         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
1674         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
1675         * TestWebKitAPI/Tests/WTF/VectorReverse.cpp:
1676         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
1677         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
1678         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
1679         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
1680         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
1681         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
1682         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
1683         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
1684         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
1685         * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
1686         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
1687         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
1688         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
1689         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
1690         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
1691         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp:
1692         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
1693         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
1694         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1695         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
1696         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
1697         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
1698         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
1699         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
1700         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
1701         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
1702         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
1703         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
1704         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp:
1705         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
1706         * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp:
1707         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
1708         * TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp:
1709         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
1710         * TestWebKitAPI/TestsController.cpp:
1711         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
1712         Removed now-unnecessary #includes. Moved #includes of Test.h in with the rest of the
1713         #includes since it is no longer a special header.
1714
1715 2011-08-18  Dirk Pranke  <dpranke@chromium.org>
1716
1717         new-run-webkit-tests hung while acquiring http lock on snow leopard bots
1718         https://bugs.webkit.org/show_bug.cgi?id=64886
1719
1720         Temporarily disable the http locking to work around the issue.
1721         I'm not actually sure if this is going to work or improve things
1722         much.
1723
1724         Reviewed by Ryosuke Niwa.
1725
1726         * Scripts/webkitpy/layout_tests/port/mac.py:
1727
1728 2011-08-18  Tony Chang  <tony@chromium.org>
1729
1730         add embedded png checksums to WebKitTestRunner
1731         https://bugs.webkit.org/show_bug.cgi?id=66494
1732
1733         Looks like WebKitTestRunner has never supported embedded checksums.  This copies
1734         some code from DRT and adds it to the WebKitTestRunner.
1735
1736         Reviewed by Darin Adler.
1737
1738         * WebKitTestRunner/CyclicRedundancyCheck.cpp: Copied from Tools/DumpRenderTree
1739         * WebKitTestRunner/CyclicRedundancyCheck.h: Copied from Tools/DumpRenderTree
1740         * WebKitTestRunner/GNUmakefile.am: Add new files
1741         * WebKitTestRunner/PixelDumpSupport.cpp: Copied from Tools/DumpRenderTree
1742         * WebKitTestRunner/PixelDumpSupport.h: Copied from Tools/DumpRenderTree
1743         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Add new files
1744         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
1745         (WTR::dumpBitmap): Refactor to use PixelDumpSupport.
1746         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1747         * WebKitTestRunner/cg/TestInvocationCG.cpp:
1748         (WTR::dumpBitmap): Refactor to use PixelDumpSupport.
1749         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1750         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Add new files
1751
1752 2011-08-18  Shawn Singh  <shawnsingh@chromium.org>
1753
1754         https://bugs.webkit.org/show_bug.cgi?id=47240
1755
1756         Fixed a cygwin path problem in the chromium port of diff_image;
1757         Also made the return values of the diff_image function more consistent.
1758
1759         Reviewed by Dirk Pranke.
1760
1761         * Scripts/webkitpy/layout_tests/port/chromium.py:
1762
1763 2011-08-17  Alejandro G. Castro  <alex@igalia.com>
1764
1765         [GTK] Fix compilation problems with deprecations in gtk+
1766         https://bugs.webkit.org/show_bug.cgi?id=66073
1767
1768         Reviewed by Martin Robinson.
1769
1770         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1771         (main): G_CONST_RETURN was deprecated
1772         * GtkLauncher/main.c:
1773         (createWindow): Added gtk_box_new conditional compilation for
1774         gtk+-3.
1775         * MiniBrowser/gtk/BrowserWindow.c:
1776         (browser_window_init): Replaced gtk_vbox_new with gtk_box_new, we
1777         are just supporting gtk+-3 for WebKit2.
1778
1779 2011-08-18  Anders Carlsson  <andersca@apple.com>
1780
1781         Fix libc++ C++0x build
1782         https://bugs.webkit.org/show_bug.cgi?id=66479
1783
1784         Reviewed by Adam Roben.
1785
1786         Add missing includes.
1787
1788         * DumpRenderTree/LayoutTestController.cpp:
1789         * DumpRenderTree/mac/CheckedMalloc.cpp:
1790
1791 2011-08-18  Adam Roben  <aroben@apple.com>
1792
1793         Test that WebKit updates style when a WebView is moved between differently-scaled windows
1794
1795         Test for <http://webkit.org/b/66412> <rdar://problem/9971958> WebKit doesn't react when a
1796         WebView is moved between windows with different backing scale factors
1797
1798         Reviewed by Anders Carlsson.
1799
1800         * TestWebKitAPI/JavaScriptTest.cpp:
1801         (TestWebKitAPI::runJSTest): Moved a little bit of code from here...
1802         (TestWebKitAPI::compareJSResult): ...to here. Also made the error message more similar to
1803         gtest's built-in error messages.
1804
1805         * TestWebKitAPI/JavaScriptTest.h: Added overloads of runJSTest that take a WebView * and
1806         WKView * for convenience on Mac. Added compareJSResult helper function for implementing
1807         those overloads.
1808
1809         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
1810
1811         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm: Added.
1812         (-[FrameLoadDelegate initWithDidFinishLoadBoolean:]): Simple initializer.
1813         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]): Record that the load finished.
1814         (TestWebKitAPI::didFinishLoadForFrame): Record that the load finished.
1815         (TestWebKitAPI::setPageLoaderClient): Set up the client.
1816         (TestWebKitAPI::DynamicDeviceScaleFactor::DynamicDeviceScaleFactor): Simple constructor.
1817         (TestWebKitAPI::DynamicDeviceScaleFactor::createWindow): Creates a
1818         SyntheticBackingScaleFactorWindow and returns it.
1819         (TestWebKitAPI::DynamicDeviceScaleFactor::runTest): Loads devicePixelRatio.html and checks
1820         that WebKit uses the correct scale factor when the WebView is not in a window, is put in a
1821         window, is moved to a differently-scaled window, and is taken out of the window.
1822         (TestWebKitAPI::DynamicDeviceScaleFactor::loadURL): Helper function with overloads for
1823         WebKit1 and WebKit2.
1824         (TestWebKitAPI::TEST_F): Runs the test, with overloads for WebKit1 and WebKit2.
1825
1826         * TestWebKitAPI/Tests/mac/devicePixelRatio.html: Added.
1827
1828         * TestWebKitAPI/mac/JavaScriptTestMac.mm: Added.
1829         (TestWebKitAPI::runJSTest): Fairly simple overloads for WebView * and WKView *.
1830
1831         * TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.h: Added.
1832         * TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.m: Added.
1833         (-[SyntheticBackingScaleFactorWindow initWithContentRect:styleMask:backing:defer:]): Simple
1834         initializer.
1835         (-[SyntheticBackingScaleFactorWindow setBackingScaleFactor:]): Simple setter.
1836
1837         (-[SyntheticBackingScaleFactorWindow backingScaleFactor]):
1838         (-[SyntheticBackingScaleFactorWindow userSpaceScaleFactor]):
1839         Overrides of NSWindow methods that WebKit uses to determine the device scale factor.
1840
1841 2011-08-18  Dmitry Lomov  <dslomov@google.com>
1842
1843         https://bugs.webkit.org/show_bug.cgi?id=66425
1844         check-webkit-style should detect incorrectly formatted file change descriptions.
1845         Description, if present, should be separated from colon with a space.
1846
1847         Reviewed by David Levin.
1848
1849         * Scripts/webkitpy/style/checkers/changelog.py: Fix.
1850         * Scripts/webkitpy/style/checkers/changelog_unittest.py: Unit tests.
1851
1852 2011-08-18  Adam Barth  <abarth@webkit.org>
1853
1854         webkit-patch pretty-diff should be shown in main help
1855         https://bugs.webkit.org/show_bug.cgi?id=66404
1856
1857         Reviewed by Dimitri Glazkov.
1858
1859         As requested by dglazkov.
1860
1861         * Scripts/webkitpy/tool/commands/prettydiff.py:
1862
1863 2011-08-17  Dmitry Lomov  <dslomov@google.com>
1864
1865         https://bugs.webkit.org/show_bug.cgi?id=66400
1866         Fix TestWebKitAPI build on Mac OS.
1867
1868         Reviewed by David Levin.
1869
1870         * TestWebKitAPI/Configurations/Base.xcconfig: Added ICU headers to the HEADER_SEARCH_PATH.
1871
1872 2011-08-17  Dimitri Glazkov  <dglazkov@chromium.org>
1873
1874         garden-o-matic spring cleaning: move scripts, styles, and images in the respective directories.
1875         https://bugs.webkit.org/show_bug.cgi?id=66427
1876
1877         Reviewed by Adam Barth.
1878
1879         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js: Removed.
1880         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js: Removed.
1881         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot_unittests.js: Removed.
1882         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js: Removed.
1883         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js: Removed.
1884         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js: Removed.
1885         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js: Removed.
1886         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js: Removed.
1887         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector_unittests.js: Removed.
1888         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm.js: Removed.
1889         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm_unittests.js: Removed.
1890         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js: Removed.
1891         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js: Removed.
1892         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NRWTResultsParser.js: Removed.
1893         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm.js: Removed.
1894         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm_unittests.js: Removed.
1895         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ORWTResultsParser.js: Removed.
1896         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/PersistentCache.js: Removed.
1897         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css: Removed.
1898         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm.js: Removed.
1899         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm_unittests.js: Removed.
1900         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js: Removed.
1901         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js: Removed.
1902         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities_unittests.js: Removed.
1903         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js: Removed.
1904         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBugzilla.js: Removed.
1905         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBuildbot.js: Removed.
1906         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Removed.
1907         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Removed.
1908         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/bugzilla_unittests.js: Removed.
1909         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js: Removed.
1910         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js: Removed.
1911         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js: Removed.
1912         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js: Removed.
1913         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js: Removed.
1914         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers: Removed.
1915         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.js: Removed.
1916         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers/rebaseline.js: Removed.
1917         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-green.png: Removed.
1918         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-red.png: Removed.
1919         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1920         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images: Added.
1921         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-green.png: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-green.png.
1922         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-red.png: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-red.png.
1923         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html:
1924         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css: Removed.
1925         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js: Removed.
1926         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js: Removed.
1927         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js: Removed.
1928         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net.js: Removed.
1929         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js: Removed.
1930         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/rebaseline.html:
1931         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js: Removed.
1932         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js: Removed.
1933         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
1934         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Bugzilla.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js.
1935         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Buildbot.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js.
1936         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Buildbot_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot_unittests.js.
1937         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Builder.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js.
1938         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Builder_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js.
1939         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FailingTestsBugForm.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js.
1940         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FailingTestsBugForm_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js.
1941         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FlakyLayoutTestDetector.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js.
1942         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FlakyLayoutTestDetector_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector_unittests.js.
1943         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FlakyTestBugForm.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm.js.
1944         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FlakyTestBugForm_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm_unittests.js.
1945         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/LayoutTestHistoryAnalyzer.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js.
1946         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/LayoutTestResultsLoader.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js.
1947         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/NRWTResultsParser.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NRWTResultsParser.js.
1948         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/NewBugForm.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm.js.
1949         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/NewBugForm_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm_unittests.js.
1950         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ORWTResultsParser.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ORWTResultsParser.js.
1951         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/PersistentCache.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/PersistentCache.js.
1952         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/TestRelatedBugForm.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm.js.
1953         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/TestRelatedBugForm_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm_unittests.js.
1954         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Trac.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js.
1955         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Utilities.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js.
1956         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Utilities_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities_unittests.js.
1957         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js.
1958         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/WebKitBugzilla.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBugzilla.js.
1959         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/WebKitBuildbot.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBuildbot.js.
1960         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js.
1961         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js.
1962         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/bugzilla_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/bugzilla_unittests.js.
1963         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js.
1964         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js.
1965         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js.
1966         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js.
1967         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js.
1968         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.
1969         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.js.
1970         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/main.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js.
1971         ():
1972         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js.
1973         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js.
1974         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net.js.
1975         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js.
1976         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js.
1977         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js.
1978         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/trac_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js.
1979         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js.
1980         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results.js.
1981         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results_unittests.js.
1982         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js.
1983         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/unexpected-passes.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.js.
1984         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/TestFailures.css: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css.
1985         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/main.css: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css.
1986         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
1987         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js: Removed.
1988         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js: Removed.
1989         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results.js: Removed.
1990         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results_unittests.js: Removed.
1991         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js: Removed.
1992         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.html:
1993         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.js: Removed.
1994
1995 2011-08-17  Jochen Eisinger  <jochen@chromium.org>
1996
1997         Make SVNTest.test_svn_apply use the same timezone logic as VCSUtils.pm
1998         https://bugs.webkit.org/show_bug.cgi?id=65877
1999
2000         Reviewed by Eric Seidel.
2001
2002         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2003
2004 2011-08-17  Dimitri Glazkov  <dglazkov@chromium.org>
2005
2006         Remove base.keys and replace it with Object.keys.
2007         https://bugs.webkit.org/show_bug.cgi?id=66422
2008
2009         Reviewed by Adam Barth.
2010
2011         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Removed base.keys.
2012         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Removed unit tests for it.
2013         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js: Replaced with Object.keys
2014
2015 2011-08-17  Dimitri Glazkov  <dglazkov@chromium.org>
2016
2017         garden-o-matic Summary view should have items in descending chronological order.
2018         https://bugs.webkit.org/show_bug.cgi?id=66403
2019
2020         Reviewed by Adam Barth.
2021
2022         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Renamed "push" to "add" for clarity, cleaned up some stuff.
2023         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Rewrote add to insert DOM elements in order.
2024         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added unit tests.
2025
2026 2011-08-17  Dimitri Glazkov  <dglazkov@chromium.org>
2027
2028         Fix a few errors in garden-o-matic frontend unit tests.
2029         https://bugs.webkit.org/show_bug.cgi?id=66421
2030
2031         Reviewed by Adam Barth.
2032
2033         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Changed my excellent test to view time as variable continuum.
2034         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js: Tweaked the test to accommodate new builder names.
2035         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Hurriedly covered up my prior sins.
2036
2037 2011-08-17  Adam Barth  <abarth@webkit.org>
2038
2039         Update Tools to account for (CG) being added to Chromium builder names
2040         https://bugs.webkit.org/show_bug.cgi?id=66410
2041
2042         Reviewed by Adam Barth.
2043
2044         Some of these names will change back once we turn on Skia bots.
2045
2046         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js:
2047         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
2048         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
2049         * Scripts/webkitpy/layout_tests/port/builders.py:
2050         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2051         * TestResultServer/static-dashboards/builders.js:
2052         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
2053
2054 2011-08-16  Dimitri Glazkov  <dglazkov@chromium.org>
2055
2056         Wire up relative time to garden-o-matic summary view.
2057         https://bugs.webkit.org/show_bug.cgi?id=66343
2058
2059         Reviewed by Adam Barth.
2060
2061         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js: Add time to the commitData object. 
2062         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js: Adjusted unit tests.
2063         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Wired up relative date.
2064         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated unit tests.
2065         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js: Adjusted unit tests.
2066
2067 2011-08-17  Adam Roben  <aroben@apple.com>
2068
2069         Make run-api-tests run tests in alphabetical order
2070
2071         Fixes <http://webkit.org/b/66401> run-api-tests runs tests in a semi-random order
2072
2073         Reviewed by David Kilzer.
2074
2075         * Scripts/run-api-tests:
2076         (runAllTests):
2077         (runAllTestsInSuite):
2078         Sort the lists of tests and suites before iterating over them.
2079
2080 2011-08-17  Adam Barth  <abarth@webkit.org>
2081
2082         garden-o-matic should be able to rebaseline expected failures
2083         https://bugs.webkit.org/show_bug.cgi?id=66204
2084
2085         Reviewed by Dimitri Glazkov.
2086
2087         This patch introduces a new view for displaying expect, actual, and
2088         differences between results.  The new view also has a fledgling
2089         controller that handles some basic operations.  The new view is
2090         exercised by rebaseline.html, which lets you rebaselines expected
2091         failures, but the new view is not fully integrated into
2092         garden-o-matic.html
2093
2094         More patches will be required to make this stuff fully working, but
2095         this patch was already somewhat spiraling out of control.  Hopefully
2096         this patch will serve as a good starting point for further development.
2097
2098         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers: Added.
2099         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.js: Added.
2100         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers/rebaseline.js: Added.
2101         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2102         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
2103         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
2104         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/rebaseline.html: Added.
2105         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
2106         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
2107         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
2108         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results.js:
2109         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results_unittests.js: Added.
2110
2111 2011-08-16  Chang Shu  <cshu@webkit.org>
2112
2113         Support reset in WebCore::Internals
2114         https://bugs.webkit.org/show_bug.cgi?id=66307
2115
2116         Reviewed by Dimitri Glazkov.
2117
2118         Added call to resetInternalsObject in DRT.
2119
2120         * DumpRenderTree/chromium/TestShell.cpp:
2121         (TestShell::resetTestController):
2122         * DumpRenderTree/mac/DumpRenderTree.mm:
2123         (resetWebViewToConsistentStateBeforeTesting):
2124         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2125         (WebCore::WebPage::resetSettings):
2126
2127 2011-08-17  Alexis Menard  <alexis.menard@openbossa.org>
2128
2129         Add a new build slave for the Qt port on Mac OS SnowLeopard.
2130         https://bugs.webkit.org/show_bug.cgi?id=66392
2131
2132         Modify the config file to include the new build slave.
2133
2134         Reviewed by Adam Roben.
2135
2136         * BuildSlaveSupport/build.webkit.org-config/config.json:
2137
2138 2011-08-17  Sam White  <samuel.white@rochester.edu>
2139
2140         AccessibilityObject levels are inconsistent
2141         https://bugs.webkit.org/show_bug.cgi?id=66180
2142         
2143         Added the ability to get numeric attribute values using numberAttributeValue. This
2144         function complements the existing stringAttributeValue and boolAttributeValue functions.
2145         The addition of numberAttributeValue was necessary because the stringAttributeValue
2146         function does a type check and will only return strings. This limitation made it
2147         impossible to get values for attributes that returned an NSNumber.
2148
2149         Reviewed by Chris Fleizach.
2150
2151         * DumpRenderTree/AccessibilityUIElement.cpp:
2152         (numberAttributeValueCallback):
2153         (AccessibilityUIElement::getJSClass):
2154         * DumpRenderTree/AccessibilityUIElement.h:
2155         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2156         (AccessibilityUIElement::numberAttributeValue):
2157         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2158         (AccessibilityUIElement::numberAttributeValue):
2159         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2160         (AccessibilityUIElement::numberAttributeValue):
2161
2162 2011-08-17  Adam Roben  <aroben@apple.com>
2163
2164         Tell Trac logs always to display all specified revisions in a single page
2165
2166         Trac imposes a default limit of 100 revisions per log page. We need to tell it to allow more
2167         revisions than that.
2168
2169         Fixes <http://webkit.org/b/66373> Links to Trac from TestFailures page don't always show all
2170         relevant revisions
2171
2172         Reviewed by Daniel Bates.
2173
2174         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
2175         (trac.logURL): Add a limit parameter to the log URL that allows all revisions to be seen in
2176         a single page.
2177
2178         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js:
2179         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js:
2180         Updated tests for the above.
2181
2182 2011-08-17  Adam Roben  <aroben@apple.com>
2183
2184         Fix TestFailures's link to file a bug about TestFailures itself
2185
2186         Fixes <http://webkit.org/b/66387> REGRESSION (r92135): TestFailures page's link to file a
2187         bug about itself is broken
2188
2189         Reviewed by Dan Bates.
2190
2191         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
2192         (ViewController.prototype._domForAuxiliaryUIElements): Added a path separator to separate
2193         the host from the path.
2194
2195 2011-08-17  Adam Roben  <aroben@apple.com>
2196
2197         Teach TestFailures to ignore unbelievably short test runs
2198
2199         Fixes <http://webkit.org/b/66385> TestFailures page thinks all tests passed in
2200         http://build.webkit.org/builders/Windows%207%20Release%20(Tests)/builds/14956
2201
2202         Reviewed by Dan Bates.
2203
2204         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
2205         (Builder.prototype.getNumberOfFailingTests): If it looks like all tests passed, but
2206         run-webkit-tests took less than 10 seconds to run, assume that some weird error occurred
2207         that caused it not to run any tests at all (as happened for a while due to
2208         <http://webkit.org/b/64988>). Bumped the cache version to evict old, buggy cached data.
2209
2210         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:
2211         Test for the above.
2212
2213         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:
2214         (LayoutTestResultsLoader.prototype.start): Bumped the cache version to evict old, buggy cached data.
2215
2216 2011-08-16  Adam Barth  <abarth@webkit.org>
2217
2218         Add a CG qualifier similar to the GPU qualifier
2219         https://bugs.webkit.org/show_bug.cgi?id=66359
2220
2221         Reviewed by Eric Seidel.
2222
2223         Once we have a Skia configuration on Chromium Mac, we'll use this CG
2224         qualifier to note that expectations apply only to the CG configuration.
2225
2226         * Scripts/webkitpy/layout_tests/port/chromium.py:
2227         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2228
2229 2011-08-16  Eric Seidel  <eric@webkit.org>
2230
2231         REGRESSION(92717): WinPort needs to parse version information from port_name
2232         https://bugs.webkit.org/show_bug.cgi?id=66325
2233
2234         Unreviewed.  Fixing an exception/typo seen on the bots (and testing to make sure it works).
2235
2236         * Scripts/webkitpy/layout_tests/port/mac.py:
2237         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2238
2239 2011-08-16  Adam Barth  <abarth@webkit.org>
2240
2241         Change webkit-patch analyze-baselines to print in a more unix-friendly way
2242         https://bugs.webkit.org/show_bug.cgi?id=66349
2243
2244         Reviewed by James Robinson.
2245
2246         As requested by jamesr.
2247
2248         * Scripts/webkitpy/tool/commands/rebaseline.py:
2249
2250 2011-08-16  Eric Seidel  <eric@webkit.org>
2251
2252         REGRESSION(92717): WinPort needs to parse version information from port_name
2253         https://bugs.webkit.org/show_bug.cgi?id=66325
2254
2255         Reviewed by Adam Barth.
2256
2257         WinPort didn't have any port_name parsing logic.
2258         Seemed it was best to just share the logic from MacPort.
2259         Sharing the logic from MacPort seemed easiest with a shared superclass.
2260         Once I created ApplePort (the superclass) there was a bunch of logic to share.
2261         I found LeakDetector was just in the way when switching back and forth
2262         between win.py and mac.py so I moved it into its own file.
2263
2264         The only logic change here is that WinPort should now be
2265         able to parse port_name values like MacPort (and other ports)
2266         can.  The fact that ports do this in their constructors is
2267         wrong and a source of many bugs.  But at least now WinPort
2268         matches the status-quo.
2269
2270         * Scripts/webkitpy/layout_tests/port/apple.py: Added.
2271         * Scripts/webkitpy/layout_tests/port/leakdetector.py: Added.
2272         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py: Added.
2273         * Scripts/webkitpy/layout_tests/port/mac.py:
2274         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2275         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2276         * Scripts/webkitpy/layout_tests/port/win.py:
2277         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
2278
2279 2011-08-16  Adam Barth  <abarth@webkit.org>
2280
2281         Add webkit-patch analyze-baselines, as requested by jamesr.
2282
2283         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
2284         * Scripts/webkitpy/tool/commands/rebaseline.py:
2285
2286 2011-08-16  Adam Barth  <abarth@webkit.org>
2287
2288         Fold bulk-optimize-baselines into optimize-baselines
2289         https://bugs.webkit.org/show_bug.cgi?id=66345
2290
2291         Reviewed by James Robinson.
2292
2293         bulk-optimize-baselines is now a superset of optimize-baselines, so
2294         they can be combined.
2295
2296         * Scripts/webkitpy/tool/commands/rebaseline.py:
2297
2298 2011-08-16  Adam Barth  <abarth@webkit.org>
2299
2300         Move chromium-mac to chromium-cg-mac to prepare for Skia switchover
2301         https://bugs.webkit.org/show_bug.cgi?id=66334
2302
2303         Reviewed by Tony Chang.
2304
2305         This patch moves us closer to switching the Chromium port from
2306         CoreGraphics to Skia.  This patch teaches our tools that the current
2307         Chromium Mac configuration is actually chromium-cg-mac, which makes
2308         room for a future chromium-mac configuration that uses Skia.
2309
2310         Shortly after this patch lands, I'll do a server-side move of the
2311         chromium-mac and chromium-mac-leopard directories to chromium-cg-mac
2312         and chromium-cg-mac-leopard.
2313
2314         * BuildSlaveSupport/build.webkit.org-config/config.json:
2315         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
2316         * Scripts/webkitpy/common/config/build.py:
2317         * Scripts/webkitpy/common/config/build_unittest.py:
2318         * Scripts/webkitpy/layout_tests/port/base.py:
2319         * Scripts/webkitpy/layout_tests/port/builders.py:
2320         * Scripts/webkitpy/layout_tests/port/chromium.py:
2321         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2322         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2323         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2324         * Scripts/webkitpy/layout_tests/port/factory.py:
2325         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
2326         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2327         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
2328         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
2329         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
2330         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2331         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2332
2333 2011-08-16  Dimitri Glazkov  <dglazkov@chromium.org>
2334
2335         garden-o-matic frontend needs a friendly relative time description method.
2336         https://bugs.webkit.org/show_bug.cgi?id=66324
2337
2338         Reviewed by Adam Barth.
2339
2340         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Added base.relativizeTime method.
2341         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Added unit tests.
2342         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Wired up Time widget to use it.
2343
2344 2011-08-16  Dimitri Glazkov  <dglazkov@chromium.org>
2345
2346         Summary view should not add multiple entries for the same test failure.
2347         https://bugs.webkit.org/show_bug.cgi?id=66318
2348
2349         Reviewed by Adam Barth.
2350
2351         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Added a simplistic updating button.
2352         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added ways to check for
2353             equality of ui.notifications.FailingTest, and whether ui.notifications.TestFailures already contains a given failure analysis.
2354         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added tests.
2355
2356 2011-08-16  Adam Roben  <aroben@apple.com>
2357
2358         Teach TestFailures that tests that have failed or passed many times in a row are not flaky
2359
2360         The basic strategy here is that once a test has failed or passed many times in a row we
2361         never again consider it as a possibly flaky test. It's a simple strategy but seems to result
2362         in many fewer false positives than our current behavior.
2363
2364         Fixes <http://webkit.org/b/66327> TestFailures page considers far too many tests to be
2365         flaky, including tests that failed for a while but then were fixed
2366
2367         Reviewed by Dan Bates.
2368
2369         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js:
2370         (FlakyLayoutTestDetector): Initialize new _buildCount property, which is used to track the
2371         number of non-too-many-failure builds we've seen.
2372         (FlakyLayoutTestDetector.prototype.incorporateTestResults): Don't track tests which haven't
2373         failed in the _maximumFailOrPassCount most recent builds. For other not-yet-considered-flaky
2374         tests, keep track of how many times they have passed or failed in a row. If they pass or
2375         fail more than _maximumFailOrPassCount times, consider them to be non-flaky. (Once a test is
2376         considered flaky it doesn't matter how many times it passes or fails.)
2377
2378         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector_unittests.js:
2379         Added tests for the above.
2380
2381 2011-08-16  Dimitri Glazkov  <dglazkov@chromium.org>
2382
2383         garden-o-matic needs a summary view with actions for each problem.
2384         https://bugs.webkit.org/show_bug.cgi?id=66144
2385
2386         Reviewed by Adam Barth.
2387
2388         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html: Added notifications tests.
2389         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Added.
2390         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added.
2391         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added.
2392         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css: Added.
2393         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Added.
2394
2395 2011-08-16  Dean Jackson  <dino@apple.com>
2396
2397         Adding Ted "hober" O'Connor as a non-committing contributor.
2398
2399         * Scripts/webkitpy/common/config/committers.py:
2400
2401 2011-08-16  Adam Roben  <aroben@apple.com>
2402
2403         Teach TestFailures how to interpret unfinished test runs
2404
2405         Fixes <http://webkit.org/b/66309> TestFailures thinks all tests passed in
2406         http://build.webkit.org/builders/Lion%20Intel%20Debug%20(Tests)/builds/136
2407
2408         Reviewed by David Kilzer.
2409
2410         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
2411         (Builder.prototype.getNumberOfFailingTests): Look for "isFinished" in the layout-test step
2412         rather than "isStarted" so that we don't count builds for which the test run never finished.
2413         Bumped the cache version to evict old, buggy cached data.
2414
2415         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:
2416         Added a test for the above, and made a somewhat synthetic test more realistic by including
2417         more of the actual JSON data from build.webkit.org.
2418
2419         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:
2420         (LayoutTestResultsLoader.prototype.start): Bumped the cache version to evict old, buggy
2421         cached data.
2422
2423 2011-08-16  Adam Roben  <aroben@apple.com>
2424
2425         Make Apple's Windows port fall back to Lion results instead of SnowLeopard
2426
2427         Apple's Windows port now uses Lion-era versions of CoreFoundation, ICU, etc., so in theory
2428         should match Lion's behavior.
2429
2430         Fixes <http://webkit.org/b/66302> Apple's Windows port matches Lion for some test results,
2431         but doesn't use Lion results
2432
2433         Reviewed by David Kilzer.
2434
2435         * Scripts/old-run-webkit-tests:
2436         (expectedDirectoryForTest):
2437         * Scripts/webkitpy/layout_tests/port/win.py:
2438         (WinPort.baseline_search_path):
2439         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
2440         (WinPortTest.test_baseline_search_path):
2441         Replaced mac-snowleopard with mac-lion.
2442
2443         * Scripts/webkitpy/common/config/build.py:
2444         (_should_file_trigger_build): Added an entry for the LayoutTests/platform/mac-lion
2445         directory, which all Apple Mac platforms and Apple Win platforms could potentially use
2446         results from. Removed Apple Win from being affected by mac-snowleopard changes, since it
2447         will no longer look there for results.
2448
2449         * Scripts/webkitpy/common/config/build_unittest.py:
2450         (ShouldBuildTest.test_should_build): Tests for the above changes.
2451
2452 2011-08-16  Dean Jackson  <dino@apple.com>
2453
2454         Move me from contributor to reviewer.
2455
2456         * Scripts/webkitpy/common/config/committers.py:
2457
2458 2011-08-15  Dimitri Glazkov  <dglazkov@chromium.org>
2459
2460         garden-o-matic frontend needs model.commitDataForRevisionRange function.
2461         https://bugs.webkit.org/show_bug.cgi?id=66252
2462
2463         Reviewed by Adam Barth.
2464
2465         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js: Added commitDataForRevisionRange method.
2466         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js: Added tests.
2467
2468 2011-08-15  Dimitri Glazkov  <dglazkov@chromium.org>
2469
2470         garden-o-matic frontend needs a generic way to track updates.
2471         https://bugs.webkit.org/show_bug.cgi?id=66245
2472
2473         Reviewed by Adam Barth.
2474
2475         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Added UpdateTracker.
2476         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Added tests.
2477
2478 2011-08-15  Adam Roben  <aroben@apple.com>
2479
2480         Teach TestWebKitAPI/gtest how to print JavaScript failures nicely
2481
2482         Failures now give output of the form: foo should be bar but is baz
2483
2484         Fixes <http://webkit.org/b/66240> It's hard to tell what the actual result of a failed JS
2485         test is in TestWebKitAPI's output
2486
2487         Reviewed by David Levin.
2488
2489         * TestWebKitAPI/JavaScriptTest.cpp:
2490         (TestWebKitAPI::JavaScriptCallbackContext::JavaScriptCallbackContext): Removed now-unused
2491         members.
2492         (TestWebKitAPI::javaScriptCallback): Changed to just store the result string in the context
2493         object, rather than doing any testing of it here.
2494         (TestWebKitAPI::runJSTest): Made this function a gtest predicate-formatter. This allows us
2495         to use a pretty error message when the test fails.
2496
2497         * TestWebKitAPI/JavaScriptTest.h: Changed runJSTest to a predicate-formatter, and added nice
2498         gtest-style macros that wrap it.
2499
2500         * TestWebKitAPI/Test.h: Removed now-unused TEST_ASSERT_RETURN.
2501
2502         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
2503         (TestWebKitAPI::TEST): Changed to use the new macros.
2504
2505         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
2506         (TestWebKitAPI::createSessionStateContainingFormData): Ditto. Note that this function no
2507         longer returns 0 when the JS test fails. That shouldn't have any effect on whether or not
2508         the test passes, though. Returning early seems to have been an unnecessary optimization.
2509
2510         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
2511         (TestWebKitAPI::TEST): Changed to use the new macros.
2512
2513 2011-08-15  Eric Seidel  <eric@webkit.org>
2514
2515         Move the Leaks bot back to ORWT until I can fix LeaksViewer regressions filed by Adam Roben in bug 66227 and 66228.
2516
2517         Unreviewed.
2518
2519         * Scripts/run-webkit-tests:
2520         (usingLeaks):
2521         (useNewRunWebKitTests):
2522
2523 2011-08-14  Adam Barth  <abarth@webkit.org>
2524
2525         Switch results detail view over to new-style object-oriented UI widgets
2526         https://bugs.webkit.org/show_bug.cgi?id=66200
2527
2528         Reviewed by Dimitri Glazkov.
2529
2530         This patch replaces my goofy template-based UI for the results
2531         comparison screen with new object-oriented UI widgets.
2532
2533         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2534         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
2535         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
2536         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
2537         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
2538         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results.js: Added.
2539         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
2540
2541 2011-08-13  Dimitri Glazkov  <dglazkov@chromium.org>
2542
2543         garden-o-matic's analyzeUnexpectedFailures needs a completion callback.
2544         https://bugs.webkit.org/show_bug.cgi?id=66166
2545
2546         Also changed base.RequestTracker to:
2547         a) fire callback immediately if requestsInFlight is 0;
2548         b) not barf if callback is not supplied.
2549
2550         Reviewed by Adam Barth.
2551
2552         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js: Started using completion callback.
2553         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js: Added completion callback.
2554         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Changed RequestTracker.
2555         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittest.js: Added unit tests.
2556
2557 2011-08-12  Mark Rowe  <mrowe@apple.com>
2558
2559         Be more forward-looking in the choice of compiler.
2560
2561         Rubber-stamped by Jon Honeycutt.
2562
2563         * DumpRenderTree/mac/Configurations/CompilerVersion.xcconfig:
2564         * MiniBrowser/Configurations/CompilerVersion.xcconfig:
2565         * TestWebKitAPI/Configurations/CompilerVersion.xcconfig:
2566         * WebKitTestRunner/Configurations/CompilerVersion.xcconfig:
2567
2568 2011-08-12  Sadrul Habib Chowdhury  <sadrul@chromium.org>
2569
2570         DRT: Add support for gesture events.
2571         https://bugs.webkit.org/show_bug.cgi?id=66105
2572
2573         Reviewed by Darin Fisher.
2574
2575         * DumpRenderTree/chromium/EventSender.cpp:
2576         (EventSender::EventSender):
2577         (EventSender::gestureScrollBegin):
2578         (EventSender::gestureScrollEnd):
2579         (EventSender::gestureTap):
2580         (EventSender::gestureEvent):
2581         * DumpRenderTree/chromium/EventSender.h:
2582
2583 2011-08-12  Andy Estes  <aestes@apple.com>
2584
2585         allowRoundingHacksCallback uses the wrong argument for 'thisObject'.
2586         https://bugs.webkit.org/show_bug.cgi?id=66158
2587
2588         Reviewed by Dan Bernstein.
2589
2590         * DumpRenderTree/LayoutTestController.cpp:
2591         (allowRoundingHacksCallback): The third argument is the 'this'
2592         JSObjectRef, not the second.
2593
2594 2011-08-12  Andy Estes  <aestes@apple.com>
2595
2596         Cancel in onbeforeunload dialog sometime causes a button to stop working.
2597         https://bugs.webkit.org/show_bug.cgi?id=26211
2598
2599         Reviewed by Alexey Proskuryakov.
2600
2601         Implement a new LayoutTestController method that a test can call to set
2602         the return value of DumpRenderTree's beforeunload UI delegate.
2603
2604         * DumpRenderTree/LayoutTestController.cpp:
2605         (LayoutTestController::LayoutTestController): Initialize
2606         m_shouldStayOnPageAfterHandlingBeforeUnload.
2607         (setShouldStayOnPageAfterHandlingBeforeUnloadCallback): Call
2608         LayoutTestController::setShouldStayOnPageAfterHandlingBeforeUnload().
2609         (LayoutTestController::staticFunctions): Register
2610         'setShouldStayOnPageAfterHandlingBeforeUnload' as a static function.
2611         * DumpRenderTree/LayoutTestController.h: 
2612         (LayoutTestController::shouldStayOnPageAfterHandlingBeforeUnload):
2613         (LayoutTestController::setShouldStayOnPageAfterHandlingBeforeUnload):
2614         * DumpRenderTree/chromium/LayoutTestController.cpp:
2615         (LayoutTestController::LayoutTestController): Initialize
2616         m_shouldStayOnPageAfterHandlingBeforeUnload and bind
2617         'setShouldStayOnPageAfterHandlingBeforeUnload' to its c++ setter.
2618         (LayoutTestController::reset): Reset
2619         m_shouldStayOnPageAfterHandlingBeforeUnload to false.
2620         (LayoutTestController::setShouldStayOnPageAfterHandlingBeforeUnload):
2621         Set m_shouldStayOnPageAfterHandlingBeforeUnload to the value passed in
2622         from JavaScript.
2623         * DumpRenderTree/chromium/LayoutTestController.h:
2624         (LayoutTestController::shouldStayOnPageAfterHandlingBeforeUnload):
2625         * DumpRenderTree/chromium/WebViewHost.cpp:
2626         (WebViewHost::runModalBeforeUnloadDialog): Add the correct logging and
2627         return the inverse of
2628         LayoutTestController::shouldStayOnPageAfterHandlingBeforeUnload().
2629         * DumpRenderTree/mac/UIDelegate.mm:
2630         (-[UIDelegate webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:]): Ditto.
2631         * DumpRenderTree/win/UIDelegate.cpp:
2632         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage): Ditto.
2633         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2634         Define setShouldStayOnPageAfterHandlingBeforeUnload().
2635         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2636         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue): Post a message
2637         to the Test Controller telling it what value it should return in its
2638         onbeforeunload UI delegate.
2639         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2640         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2641         (WTR::LayoutTestController::setShouldStayOnPageAfterHandlingBeforeUnload):
2642         Call InjectedBundle::postNewBeforeUnloadReturnValue().
2643         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2644         * WebKitTestRunner/TestController.cpp:
2645         (WTR::TestController::TestController): Initialize
2646         m_beforeUnloadReturnValue to true.
2647         (WTR::runBeforeUnloadConfirmPanel): Add the correct logging and return
2648         the value of TestController::beforeUnloadReturnValue().
2649         (WTR::TestController::resetStateToConsistentValues): Reset
2650         m_beforeUnloadReturnValue to true.
2651         * WebKitTestRunner/TestController.h:
2652         (WTR::TestController::beforeUnloadReturnValue):
2653         (WTR::TestController::setBeforeUnloadReturnValue):
2654         * WebKitTestRunner/TestInvocation.cpp:
2655         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Handle the
2656         message posted from the injected bundle by retrieving the message body
2657         as a WKBoolean and calling TestController::setBeforeUnloadReturnValue().
2658
2659 2011-08-12  Sam Weinig  <sam@webkit.org>
2660
2661         Move compiler specific macros to their own header
2662         https://bugs.webkit.org/show_bug.cgi?id=66119
2663
2664         Reviewed by Anders Carlsson.
2665
2666         * DumpRenderTree/ForwardingHeaders/wtf/Compiler.h: Added.
2667
2668 2011-08-11  Dimitri Glazkov  <dglazkov@chromium.org>
2669
2670         Add a way to extend DOM objects in garden-o-matic.
2671         https://bugs.webkit.org/show_bug.cgi?id=66096
2672
2673         Reviewed by Adam Barth.
2674
2675         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Added base.extends.
2676         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Added tests.
2677
2678 2011-08-11  MORITA Hajime  <morrita@google.com>
2679
2680         [Chromium][DRT] editing/spelling/spelling-backspace-between-lines.html fails
2681         https://bugs.webkit.org/show_bug.cgi?id=45438
2682
2683         Reviewed by Kent Tamura.
2684
2685         MockSpellCheck was assuming the input of spellCheckWord() is a word.
2686         But it can be a series of word. This change made spellCheckWord()
2687         understand simple word boundary which appears in tests.
2688         
2689         * DumpRenderTree/chromium/MockSpellCheck.cpp:
2690         (MockSpellCheck::spellCheckWord):
2691
2692 2011-08-11  Mark Rowe  <mrowe@apple.com>
2693
2694         Rework some Makefile logic to remove a double-negative.
2695
2696         Reviewed by Jon Honeycutt.
2697
2698         * DumpRenderTree/mac/PerlSupport/Makefile:
2699
2700 2011-08-11  Anders Carlsson  <andersca@apple.com>
2701
2702         Add a FIXME.
2703
2704         * TestWebKitAPI/TestsController.cpp:
2705         (TestWebKitAPI::TestsController::TestsController):
2706
2707 2011-08-11  Anders Carlsson  <andersca@apple.com>
2708
2709         Initialize threading before running any tests
2710         https://bugs.webkit.org/show_bug.cgi?id=66112
2711
2712         Reviewed by Adam Barth.
2713
2714         * TestWebKitAPI/TestsController.cpp:
2715         (TestWebKitAPI::TestsController::TestsController):
2716
2717 2011-08-11  Adam Barth  <abarth@webkit.org>
2718
2719         Add unexpected-passes.html to TestFailures for marking tests as passing
2720         https://bugs.webkit.org/show_bug.cgi?id=66102
2721
2722         Reviewed by Dimitri Glazkov.
2723
2724         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2725         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
2726             - Move some code into the library so it can be shared.
2727         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
2728         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
2729         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
2730             - Add round-trip unit tests.
2731         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.html: Added.
2732         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.js: Added.
2733             - I'm not entirely sure this feature should remain a separate HTML
2734               file, but it seemed better than cluttering up the main HTML file
2735               with too much extra stuff.
2736         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2737         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2738             - The gardening server couldn't handle adding PASS expectations.  Now it can.
2739
2740 2011-08-11  Eric Seidel  <eric@webkit.org>
2741
2742         NRWT has wrong fallback order for Mac now that Lion exists
2743         https://bugs.webkit.org/show_bug.cgi?id=66093
2744
2745         Reviewed by Adam Barth.
2746
2747         ORWT used a different system for fallback orders than NRWT did.
2748         I moved win.py to match ORWT fallback orders in bug 64486.
2749         This bug moves mac.py to match ORWT fallback order
2750         and adds 'lion' as a supported OS version.
2751
2752         Because ChromiumMac shares OS version detection code with AppleMac
2753         this also added support for 'lion' to chromium mac.  Hopefully that's a good thing.
2754
2755         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2756         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2757         * Scripts/webkitpy/layout_tests/port/mac.py:
2758         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2759         * Scripts/webkitpy/layout_tests/port/win.py:
2760
2761 2011-08-11  Adam Barth  <abarth@webkit.org>
2762
2763         Update test results now that we use absolute URLs.
2764
2765         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js:
2766
2767 2011-08-11  Adam Barth  <abarth@webkit.org>
2768
2769         garden-o-matic should be able to determine when tests unexpectedly pass
2770         https://bugs.webkit.org/show_bug.cgi?id=66092
2771
2772         Reviewed by Dimitri Glazkov.
2773
2774         This patch just contains the library methods for extracting this
2775         information.  I'll add some UI in a subsequent patch.
2776
2777         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
2778         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js:
2779
2780 2011-08-11  Dimitri Glazkov  <dglazkov@chromium.org>
2781
2782         New expectation entries should be placed next to existing ones.
2783         https://bugs.webkit.org/show_bug.cgi?id=66066
2784
2785         Reviewed by Adam Barth.
2786
2787         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Added the notion of insertion point,
2788             which is computed as the last found reference to the same test.
2789         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added and adjusted unit tests.
2790
2791 2011-08-11  Dimitri Glazkov  <dglazkov@chromium.org>
2792
2793         Unreviewed, rolling out r92847.
2794         http://trac.webkit.org/changeset/92847
2795         https://bugs.webkit.org/show_bug.cgi?id=65986
2796
2797         Broke check-webkit-style
2798
2799         * Scripts/webkitpy/style/checker.py:
2800         * Scripts/webkitpy/style/checker_unittest.py:
2801
2802 2011-08-11  Dimitri Glazkov  <dglazkov@chromium.org>
2803
2804         Unreviewed, rolling out r92847.
2805         http://trac.webkit.org/changeset/92847
2806         https://bugs.webkit.org/show_bug.cgi?id=65986
2807
2808         Broke check-webkit-style
2809
2810         * Scripts/webkitpy/style/checker.py:
2811         * Scripts/webkitpy/style/checker_unittest.py:
2812
2813 2011-08-11  Pierre Rossi  <pierre.rossi@gmail.com>
2814
2815         [Qt] autotests shouldn't require config.h in the style check
2816         https://bugs.webkit.org/show_bug.cgi?id=65986
2817
2818         Remove the include rules from the style-check for Qt tests.
2819         Since for the most part it's just a matter of using the
2820         API provided by QtWebKit, enforcing the WebCore set of rules
2821         only seems to make sense in the case of MIMESniffing.
2822
2823         Reviewed by Benjamin Poulain.
2824
2825         * Scripts/webkitpy/style/checker.py:
2826         * Scripts/webkitpy/style/checker_unittest.py:
2827
2828 2011-08-11  Zsolt Fehér  <h490267@stud.u-szeged.hu>
2829
2830         [WK2] Implement waitForPolicyDelegate
2831         https://bugs.webkit.org/show_bug.cgi?id=42330
2832
2833         Reviewed by Csaba Osztrogonác.
2834
2835         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2836         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2837         (WTR::navigationTypeToString):
2838         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
2839         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2840         (WTR::LayoutTestController::LayoutTestController):
2841         (WTR::LayoutTestController::setCustomPolicyDelegate):
2842         (WTR::LayoutTestController::waitForPolicyDelegate):
2843         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2844         (WTR::LayoutTestController::isPolicyDelegateEnabled):
2845         (WTR::LayoutTestController::isPolicyDelegatePermissive):
2846
2847 2011-08-11  Adam Barth  <abarth@webkit.org>
2848
2849         rebaseline-expectations should use the release bots, not the debug
2850         bots.  The debug bots don't all run all the tests.  Also, delay
2851         updating test_expectations a long as possible to avoid clearing out
2852         lines that we'll need for other ports.
2853
2854         * Scripts/webkitpy/layout_tests/port/builders.py:
2855         * Scripts/webkitpy/tool/commands/rebaseline.py:
2856         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2857
2858 2011-08-10  Ryosuke Niwa  <rniwa@webkit.org>
2859
2860         r92792 inadvertently removed PlatformSpecificScheduler for all Snow Leopard bots.
2861         Revert it partially so that the remaining Snow Leopard bots can fulfill their duty.
2862
2863         * BuildSlaveSupport/build.webkit.org-config/config.json:
2864
2865 2011-08-10  Eric Seidel  <eric@webkit.org>
2866
2867         new-run-webkit-test's WinPort has no fallback logic
2868         https://bugs.webkit.org/show_bug.cgi?id=64486
2869
2870         Unreviewed.
2871
2872         Turns out that we've long had a subtle bug whereby if you didn't
2873         already have DumpRenderTree built, we might end up running unsupported tests
2874         because the DumpRenderTree --print-supported-features check would silently fail.
2875
2876         When I moved the call from using popen to using Executive.run_command, this silent
2877         failure became noisy.  (Breaking some bots.)
2878
2879         This re-orders our steps so that we always build DRT before collecting expectations,
2880         as well as adds a warning message when DumpRenderTree can't be found.
2881
2882         * Scripts/webkitpy/layout_tests/port/webkit.py:
2883         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2884
2885 2011-08-10  Eric Seidel  <eric@webkit.org>
2886
2887         new-run-webkit-test's WinPort has no fallback logic
2888         https://bugs.webkit.org/show_bug.cgi?id=64486
2889
2890         Unreviewed.  Fix test-webkitpy under Python 2.5.
2891
2892         * Scripts/webkitpy/layout_tests/port/win.py:
2893
2894 2011-08-10  Benjamin Poulain  <benjamin@webkit.org>
2895
2896         [Qt][WK2] MiniBrowser is firing twice the QDesktopWebView::mousePressEvent method
2897         https://bugs.webkit.org/show_bug.cgi?id=65875
2898
2899         Reviewed by Kenneth Rohde Christiansen.
2900
2901         For some reason, QWidget send fake mouse event on some platform, under certains conditions.
2902
2903         This causes mouse events to be sent twice in some cases. We work around the problem
2904         by defining the first touch point to be a primary touch point (case which hit some
2905         weird condition in QWidget, skipping the generation of fake mouse events).
2906
2907         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2908         (MiniBrowserApplication::notify):
2909
2910 2011-08-10  David Hyatt  <hyatt@apple.com>
2911
2912         https://bugs.webkit.org/show_bug.cgi?id=66004
2913
2914         Remove the regions and exclusions bots and also the flags in build-webkit, since I'm just turning
2915         the code on by default.
2916
2917         Reviewed by Adam Roben.
2918
2919         * BuildSlaveSupport/build.webkit.org-config/config.json:
2920         * Scripts/build-webkit:
2921
2922 2011-08-10  Oliver Hunt  <oliver@apple.com>
2923
2924         JSEvaluteScript does not return the correct object when given JSONP data
2925         https://bugs.webkit.org/show_bug.cgi?id=66003
2926
2927         Reviewed by Gavin Barraclough.
2928
2929         Add a test case.
2930
2931         * DumpRenderTree/mac/DumpRenderTree.mm:
2932         (testStringByEvaluatingJavaScriptFromString):
2933
2934 2011-08-10  Eric Seidel  <eric@webkit.org>
2935
2936         WIN: NRWT runs compositing tests on configurations that don't support compositing
2937         https://bugs.webkit.org/show_bug.cgi?id=64472
2938
2939         Reviewed by Adam Barth.
2940
2941         I think the code was just wrong.  It was never splitting the string
2942         into list pieces before.
2943         I've now tested the supported_features code and theoretically it
2944         should now work with Windows DRT.
2945
2946         I also made the list-lookup functions always return lists, to make
2947         it possible to clean up the list-transform code in the future
2948         (I opted not to do that cleanup in this patch, but at least now
2949         both types of feature lookup functions match return types.)
2950
2951         * Scripts/webkitpy/layout_tests/port/webkit.py:
2952         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2953
2954 2011-08-10  Eric Seidel  <eric@webkit.org>
2955
2956         Clean up ChromiumDriver a little
2957         https://bugs.webkit.org/show_bug.cgi?id=65995
2958
2959         Unreviewed.
2960
2961         Fix NRWT for chromium.  Silly python.
2962
2963         * Scripts/webkitpy/layout_tests/port/chromium.py:
2964
2965 2011-08-10  Eric Seidel  <eric@webkit.org>
2966
2967         Clean up ChromiumDriver a little
2968         https://bugs.webkit.org/show_bug.cgi?id=65995
2969
2970         Reviewed by Adam Barth.
2971
2972         - We no longer support threading, so remove threading specific code.
2973         - Add FIXMEs about using ServerProcess instead.
2974         - Condense option-mapping if-cascade into a for loop.
2975         - Unindent long if blocks by using early return.
2976         - Unwrap lines which are needlessly wrapped.
2977
2978         There should be no functional changes here, just code cleanup/dead-code removal.
2979
2980         * Scripts/webkitpy/layout_tests/port/chromium.py:
2981
2982 2011-08-10  Dimitri Glazkov  <dglazkov@chromium.org>
2983
2984         Unmuddle construction options for TestConfiguration.
2985         https://bugs.webkit.org/show_bug.cgi?id=65988
2986
2987         The TestConfiguration instance is now constructed only using actual values.
2988         Port-based construction is split into a "from_port" class method.
2989
2990         Reviewed by Eric Seidel.
2991
2992         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Added TestConfiguration.from_port
2993         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Adjusted code to accommodate the change.
2994         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Ditto.
2995         * Scripts/webkitpy/layout_tests/port/base.py: Ditto.
2996         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Ditto.
2997
2998 2011-08-10  Eric Seidel  <eric@webkit.org>
2999
3000         Leaks bot shows python logging prefixes as part of summary display
3001         https://bugs.webkit.org/show_bug.cgi?id=65931
3002
3003         Reviewed by Adam Barth.
3004
3005         The big part of this change is adding a unittesting system for
3006         master.cfg, so mere-mortals can make changes to build.webkit.org
3007         with greatly-reduced risk of breaking the world.
3008
3009         Turns out that in typing up my trival logging fix I made 2 typos,
3010         so hopefully the hour spent getting master.cfg to load was worth it. :)
3011
3012         I also tried to make mastercfg_unittest run as part of test-webkitpy
3013         but right now test-webkitpy requires that unittest files be located in
3014         a module-name-compatible directory.  'build.webkit.org-config' is not
3015         a valid module name.
3016
3017         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3018          - Fixed _parseNewRunWebKitTestsOutput to strip NRWT's python formatter prefix
3019            by using a new _strip_python_logging_prefix function.
3020          - Also fixed this function to file to work with a more modern
3021            simplejson version (which returns unicode objects instead of str objects)
3022            and filed a related bug with buildbot.net due to their handling of unicode builder names.
3023         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Added.
3024          - BuildBotConfigLoader is a huge pile of code just to get master.cfg to load.
3025          - The actual tiny unittest of the new _parseNewRunWebKitTestsOutput logic.
3026         * Scripts/webkitpy/thirdparty/__init__.py:
3027          - Add autoinstallation of buildbot (and jinja2) for use by mastercfg_unittest.py
3028
3029 2011-08-09  Dimitri Glazkov  <dglazkov@chromium.org>
3030
3031         garden-o-matic should extrapolate failures given a set of known results
3032         https://bugs.webkit.org/show_bug.cgi?id=65882
3033
3034         Reviewed by Adam Barth.
3035
3036         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Spuriously covered my old sins.
3037         * Scripts/webkitpy/layout_tests/port/builders.py: Augmented builders dictionary to contain build coverage specifiers,
3038             adjusted all call sites.
3039         * Scripts/webkitpy/tool/servers/gardeningserver.py: Added BuildCoverageExtrapolator, a thing that
3040             makes wider net for specific failures.
3041         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Added unit tests.
3042
3043 2011-08-10  Adam Barth  <abarth@webkit.org>
3044
3045         The URL we were computing for retrieving baselines was missing a slash
3046         character because our mocks had an extra slash character.  I've
3047         corrected both the code and the mock.
3048
3049         * Scripts/webkitpy/tool/commands/rebaseline.py:
3050         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3051         * Scripts/webkitpy/tool/mocktool.py:
3052
3053 2011-08-09  Adam Barth  <abarth@webkit.org>
3054
3055         Move the quote mark to the right place.
3056
3057         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
3058
3059 2011-08-09  Adam Barth  <abarth@webkit.org>
3060
3061         garden-o-matic should use huerstics to narrow regression range
3062         https://bugs.webkit.org/show_bug.cgi?id=65948
3063
3064         Reviewed by Dimitri Glazkov.
3065
3066         When analyzing a regression range, if one of the commit messages
3067         mentions the test in question, we now hueristically assume that
3068         revision caused the failure.  (I'm shamelessly stealing this idea from
3069         TestFailures.)
3070
3071         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
3072
3073 2011-07-13  Eric Seidel  <eric@webkit.org>
3074
3075         new-run-webkit-test's WinPort has no fallback logic
3076         https://bugs.webkit.org/show_bug.cgi?id=64486
3077
3078         Reviewed by Adam Roben.
3079
3080         I've tried to write a patch for bug 64439 twice now, and both times
3081         I've ended up re-writing half the port system.  So I'm breaking
3082         things up into smaller pieces, this being the first.
3083
3084         WinPort still does not have any port_name parsing, so when instantiated
3085         with the name "win-xp" (i.e. by the rebaseline server) it will just behave as the 'win' port.
3086         I'll fix this in a second pass when I standardize port_name parsing for all webkit ports.
3087
3088         Otherwise this should "just work" for windows.  I've not been able to test the
3089         version detection on my mac, but the unit tests show the code behaving as designed.
3090
3091         * Scripts/webkitpy/layout_tests/port/win.py:
3092         * Scripts/webkitpy/layout_tests/port/win_unittest.py: Added.
3093
3094 2011-08-09  Adam Barth  <abarth@webkit.org>
3095
3096         Teach build.webkit.org's garden-o-matic how to talk to the local server
3097         https://bugs.webkit.org/show_bug.cgi?id=65940
3098
3099         Reviewed by Dimitri Glazkov.
3100
3101         After this patch, the version of garden-o-matic on build.webkit.org is
3102         fully functional.  It can interact with the local server via CORS.
3103
3104         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
3105         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
3106         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
3107         * Scripts/webkitpy/tool/commands/gardenomatic.py:
3108         * Scripts/webkitpy/tool/servers/gardeningserver.py:
3109
3110 2011-08-09  Adam Barth  <abarth@webkit.org>
3111
3112         Enable CORS for garden-o-matic
3113         https://bugs.webkit.org/show_bug.cgi?id=65936
3114
3115         Reviewed by Dimitri Glazkov.
3116
3117         This patch will allow the hosted instance of garden-o-matic to
3118         communicate with the local server.
3119
3120         * Scripts/webkitpy/tool/servers/gardeningserver.py:
3121         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
3122
3123 2011-08-09  Adam Barth  <abarth@webkit.org>
3124
3125         Upgrade jquery in TestFailures
3126         https://bugs.webkit.org/show_bug.cgi?id=65935
3127
3128         Reviewed by Dimitri Glazkov.
3129
3130         Upgrade to a newer version of jQuery with better support for CORS and CSP.
3131
3132         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
3133         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html:
3134         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
3135
3136 2011-08-09  Sheriff Bot  <webkit.review.bot@gmail.com>
3137
3138         Unreviewed, rolling out r92683.
3139         http://trac.webkit.org/changeset/92683
3140         https://bugs.webkit.org/show_bug.cgi?id=65921
3141
3142          "Breaks Qt --minimal build. Revert pending update of the Qt
3143         minimal configuration" (Requested by simathur on #webkit).
3144
3145         * QtTestBrowser/cookiejar.cpp:
3146         (TestBrowserCookieJar::TestBrowserCookieJar):
3147         * QtTestBrowser/launcherwindow.cpp:
3148         (LauncherWindow::createChrome):
3149         (LauncherWindow::setDiskCache):
3150         * QtTestBrowser/main.cpp:
3151         (LauncherApplication::handleUserOptions):
3152         * QtTestBrowser/webpage.cpp:
3153         (WebPage::openUrlInDefaultBrowser):
3154
3155 2011-08-09  Siddharth Mathur  <siddharth.mathur@nokia.com>
3156
3157         [Qt] Simplify code by removing QT_NO_DESKTOPSERVICES and QT_NO_NETWORKDISKCACHE
3158         https://bugs.webkit.org/show_bug.cgi?id=65880
3159
3160         Reviewed by Andreas Kling.
3161
3162         QDesktopServices and QNetworkDiskCache have been around for a while now. Kill flags which 
3163         check for their feature flags. Assume that any reasonable Qt build provides them. 
3164         * QtTestBrowser/cookiejar.cpp:
3165         (TestBrowserCookieJar::TestBrowserCookieJar):
3166         * QtTestBrowser/launcherwindow.cpp:
3167         (LauncherWindow::createChrome):
3168         (LauncherWindow::setDiskCache):
3169         * QtTestBrowser/main.cpp:
3170         (LauncherApplication::handleUserOptions):
3171         * QtTestBrowser/webpage.cpp:
3172         (WebPage::openUrlInDefaultBrowser):
3173
3174 2011-08-09  Adam Barth  <abarth@webkit.org>
3175
3176         BaselineOptimizer created the wrong baseline for fast/js/regexp-overflow.html
3177         https://bugs.webkit.org/show_bug.cgi?id=65891
3178
3179         Reviewed by Eric Seidel.
3180
3181         The problem was that platform/chromium contained a bogus expectation
3182         file that needed to be removed, but by the time we got around to
3183         removing it, we'd already moved the correct baseline into its place.
3184         After this patch, we copy the gold results into memory before
3185         reshuffling things on disk (and we delete bad things before adding good
3186         things).
3187
3188         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
3189         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
3190
3191 2011-08-08  Adam Barth  <abarth@webkit.org>
3192
3193         Chromium Windows bots can't figure out what SVN revision they're running
3194         https://bugs.webkit.org/show_bug.cgi?id=65893
3195
3196         Reviewed by Eric Seidel.
3197
3198         The comment in _engage_awesome_windows_hacks explains why we're making
3199         this change.  It's ugly and rediculous, but this approach seems better
3200         than using shell=True when calling popen.
3201
3202         * Scripts/webkitpy/common/checkout/scm/svn.py:
3203         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3204
3205 2011-08-08  Adam Barth  <abarth@webkit.org>
3206
3207         Remove deduplicate-tests
3208         https://bugs.webkit.org/show_bug.cgi?id=65886
3209
3210         Reviewed by Tony Chang.
3211
3212         This script is redundant with "webkit-patch bulk-optimize-baselines",
3213         which can find many more duplicates than deduplicate-tests because
3214         bulk-optimize-baselines can move results around whereas
3215         deduplicate-tests can only remove results.
3216
3217         * Scripts/deduplicate-tests: Removed.
3218         * Scripts/webkitpy/to_be_moved/deduplicate_tests.py: Removed.
3219         * Scripts/webkitpy/to_be_moved/deduplicate_tests_unittest.py: Removed.
3220
3221 2011-08-08  Adam Barth  <abarth@webkit.org>
3222
3223         scm.delete should delete empty parent directories as well
3224         https://bugs.webkit.org/show_bug.cgi?id=65878
3225
3226         Reviewed by Eric Seidel.
3227
3228         This behavior makes SVN match GIT (which has no concept of empty
3229         directories).  This bug comes up a lot when optimizing baselines, which
3230         often create empty directories when we're able to optimize everything
3231         out of a given folder.
3232
3233         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3234         * Scripts/webkitpy/common/checkout/scm/svn.py:
3235
3236 2011-08-08  Lucas Forschler  <lforschler@apple.com>
3237
3238         Add triggers for Lion WK2 test bots.
3239
3240         Reviewed by Stephanie Lewis.
3241
3242         * BuildSlaveSupport/build.webkit.org-config/config.json:
3243
3244 2011-08-08  Adam Barth  <abarth@webkit.org>
3245
3246         bulk-optimize-baselines should take directories on the command line
3247         https://bugs.webkit.org/show_bug.cgi?id=65879
3248
3249         Reviewed by Dimitri Glazkov.
3250
3251         Passing lists of tests via stdin is a pain.  It's easier if the command
3252         takes a list of tests on the command line, like run-webkit-tests.
3253
3254         * Scripts/webkitpy/tool/commands/rebaseline.py:
3255
3256 2011-08-08  Adam Barth  <abarth@webkit.org>
3257
3258         Deprecate rebaseline-chromium-webkit-tests
3259         https://bugs.webkit.org/show_bug.cgi?id=65873
3260
3261         Reviewed by Dimitri Glazkov.
3262
3263         This script never worked correctly and now is redundant with more
3264         modern infrastructure for rebaselining tests.  This patch deprecates
3265         the script in order to flush out any issues with the new tools.  Once
3266         folks are happy with the new tools, we'll delete this script.
3267
3268         * Scripts/rebaseline-chromium-webkit-tests:
3269
3270 2011-08-08  Dimitri Glazkov  <dglazkov@chromium.org>
3271
3272         garden-o-matic should only touch expectations that need updating.
3273         https://bugs.webkit.org/show_bug.cgi?id=65876
3274
3275         Reviewed by Adam Barth.
3276
3277         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Added reconstitute_only_these to TestExpectationSerializer.list_to_string,
3278             so that a caller could influence which lines to serialize from values.
3279         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added tests.
3280         * Scripts/webkitpy/tool/servers/gardeningserver.py: Started using reconstitute_only_these.
3281         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Added tests.
3282
3283 2011-08-08  Dimitri Glazkov  <dglazkov@chromium.org>
3284
3285         TestExpectationsEditor should return a list of updated expectations.
3286         https://bugs.webkit.org/show_bug.cgi?id=65872
3287
3288         Reviewed by Adam Barth.
3289
3290         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Added a list to store lines that are being updated.
3291         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Changed tests to account for updated lines.
3292
3293 2011-08-08  Jochen Eisinger  <jochen@chromium.org>
3294
3295         Fix SCM webkitpy unit test failures
3296         https://bugs.webkit.org/show_bug.cgi?id=65823
3297
3298         Reviewed by Eric Seidel.
3299
3300         * Scripts/webkitpy/common/checkout/scm/git.py:
3301         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3302
3303 2011-08-08  Eric Seidel  <eric@webkit.org>
3304
3305         Move the --leaks bot back over to NRWT now that I'm back
3306         from vacation and able to debug it.
3307
3308         Unreviewed.
3309
3310         * Scripts/run-webkit-tests:
3311         (usingWebKit2):
3312         (useNewRunWebKitTests):
3313
3314 2011-08-05  Dimitri Glazkov  <dglazkov@chromium.org>
3315
3316         Wire up updating expectations in garden-o-matic.
3317         https://bugs.webkit.org/show_bug.cgi?id=65794
3318
3319         Reviewed by Adam Barth.
3320
3321         * Scripts/webkitpy/layout_tests/port/factory.py: Moved _port_for_builder from rebaseline.py to here, rename to get_from_builder_name.
3322         * Scripts/webkitpy/tool/commands/rebaseline.py: Adapted callsites to new location.
3323         * Scripts/webkitpy/tool/servers/gardeningserver.py: Added GardeningExpectationsUpdater, which knows how to update expectations.
3324         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Added loads of tests.
3325
3326 2011-08-08  Jochen Eisinger  <jochen@chromium.org>
3327
3328         webkit-patch doesn't get along with renamed files
3329         https://bugs.webkit.org/show_bug.cgi?id=48075
3330
3331         Possibly a bit heavy handed - I removed all instances of -C and
3332         changed every instance of -M with '--no-renames' in git.py. This
3333         forces git to not try to tell us about renames at all, which is
3334         ultimately the behaviour we want. The old file is shown deleted,
3335         then the new file is shown added, followed by any changes that
3336         occurred. Also gets rid of the problem where deleting one file
3337         and adding another file which has similar content would
3338         unexpectedly show up as a rename, and fall out of a diff.
3339
3340         Based on a patch by Wyatt Carss.
3341
3342         Reviewed by Eric Seidel.
3343
3344         * Scripts/webkitpy/common/checkout/scm/git.py:
3345
3346 2011-08-07  Sam White  <samuel.white@rochester.edu>
3347
3348         Add the ability to search the AccessibilityObject cache
3349         https://bugs.webkit.org/show_bug.cgi?id=64994
3350         
3351         Added testing support for AccessibilityObject cache searching. Currently,
3352         only the mac platform is full supported and has had API exposed. Other
3353         platforms have only have this new functionality stubbed. Full implementation
3354         is a job suited only for an accessibility expert of each respective platform.
3355
3356         Reviewed by Chris Fleizach.
3357
3358         * DumpRenderTree/AccessibilityUIElement.cpp:
3359         (uiElementForSearchPredicateCallback):
3360         (AccessibilityUIElement::getJSClass):
3361         * DumpRenderTree/AccessibilityUIElement.h:
3362         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3363         (AccessibilityUIElement::uiElementForSearchPredicate):
3364         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3365         (AccessibilityUIElement::uiElementForSearchPredicate):
3366         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3367         (AccessibilityUIElement::uiElementForSearchPredicate):
3368
3369 2011-08-06  Adam Barth  <abarth@webkit.org>
3370
3371         Remove dead code in webkitpy
3372         https://bugs.webkit.org/show_bug.cgi?id=65818
3373
3374         Reviewed by Dimitri Glazkov.
3375
3376         This code was added to support the rebaseline2 command six months ago,
3377         but the rebaseline2 command was never finished and no one else has used
3378         this code since it was landed.  This patch removes the dead code.  If
3379         we revive rebaseline2, then we can revert this patch and recover the
3380         code.  Until then, this code is just dead weight.
3381
3382         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3383         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3384         * Scripts/webkitpy/common/net/testoutput.py: Removed.
3385         * Scripts/webkitpy/common/net/testoutput_unittest.py: Removed.
3386         * Scripts/webkitpy/common/net/testoutputset.py: Removed.
3387         * Scripts/webkitpy/common/net/testoutputset_unittest.py: Removed.
3388         * Scripts/webkitpy/common/system/directoryfileset.py: Removed.
3389         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Removed.
3390         * Scripts/webkitpy/layout_tests/port/base.py:
3391         * Scripts/webkitpy/layout_tests/port/chromium.py:
3392         * Scripts/webkitpy/layout_tests/port/webkit.py:
3393
3394 2011-08-06  Adam Barth  <abarth@webkit.org>
3395
3396         webkit-patch optimize-baselines can't handle promotions to base results directory
3397         https://bugs.webkit.org/show_bug.cgi?id=65819
3398
3399         Reviewed by Dimitri Glazkov.
3400
3401         This bug came up when testing the optimizer on some editing baselines.
3402
3403         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
3404         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
3405
3406 2011-08-06  Adam Barth  <abarth@webkit.org>
3407
3408         Add a small command to optimize baselines in bulk.
3409
3410         * Scripts/webkitpy/tool/commands/rebaseline.py:
3411
3412 2011-08-05  Dimitri Glazkov  <dglazkov@chromium.org>
3413
3414         Fix unit test breakage by plumbing convert_404_to_None in MockWeb.
3415
3416         * Scripts/webkitpy/tool/mocktool.py: Added missing parameter to MockWeb.get_binary
3417
3418 2011-08-05  Dimitri Glazkov  <dglazkov@chromium.org>
3419
3420         Garden-o-matic updateexpectations needs a unit test.
3421         https://bugs.webkit.org/show_bug.cgi?id=65780
3422
3423         Reviewed by Adam Barth.
3424
3425         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Added unit test.
3426
3427 2011-08-05  Anders Carlsson  <andersca@apple.com>
3428
3429         Future proof an Objective-C test
3430         https://bugs.webkit.org/show_bug.cgi?id=65788
3431
3432         Reviewed by Dan Bernstein.
3433
3434         Add isObjectInstanceOf to ObjCController.
3435
3436         * DumpRenderTree/mac/ObjCController.m:
3437         (+[ObjCController isSelectorExcludedFromWebScript:]):
3438         (+[ObjCController webScriptNameForSelector:]):
3439         (-[ObjCController isObject:instanceOf:]):
3440
3441 2011-08-05  Adam Barth  <abarth@webkit.org>
3442
3443         trac.js needs unittests
3444         https://bugs.webkit.org/show_bug.cgi?id=65673
3445
3446         Reviewed by Dimitri Glazkov.
3447
3448         This tests also have somewhat large fixtures.  I've trimmed the example
3449         XML down a bunch while still hitting interesting cases in the parsing.
3450
3451         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
3452         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js: Added.
3453
3454 2011-08-05  Adam Barth  <abarth@webkit.org>
3455
3456         Rebuild rebaseline-chromium-webkit-tests on top of modern infrastructure
3457         https://bugs.webkit.org/show_bug.cgi?id=65759
3458
3459         Reviewed by Dimitri Glazkov.
3460
3461         rebaseline-chromium-webkit-tests doesn't really fit into webkitpy's
3462         architecture, is poorly tested, and has a bunch of quirks.  This patch
3463         rebuilds the core functionality of rebaseline-chromium-webkit-tests on
3464         top of more modern infrastructure.  In the process, we get more code
3465         re-use and better testing.
3466
3467         Once we're satisfied with this new implementation, we can delete the
3468         old implementation.
3469
3470         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
3471         * Scripts/webkitpy/common/net/web.py:
3472         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3473         * Scripts/webkitpy/layout_tests/port/builders.py:
3474         * Scripts/webkitpy/layout_tests/port/chromium.py:
3475         * Scripts/webkitpy/layout_tests/port/factory.py:
3476         * Scripts/webkitpy/layout_tests/port/webkit.py:
3477         * Scripts/webkitpy/tool/commands/rebaseline.py:
3478         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3479
3480 2011-08-05  Anders Carlsson  <andersca@apple.com>
3481
3482         Remove PluginHalter
3483         https://bugs.webkit.org/show_bug.cgi?id=65729
3484
3485         Reviewed by Darin Adler.
3486
3487         Remove call to set the allowed plug-in run time.
3488
3489         * DumpRenderTree/mac/DumpRenderTree.mm:
3490         (resetDefaultsToConsistentValues):
3491
3492 2011-08-05  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>
3493
3494         Unreviewed build fix for Qt-Minimal buildbot
3495
3496         Use ~/.QtTestBrowser for the cookiejar when QDesktopServices
3497         is disabled.
3498
3499         Rubber-stamped by Holger Freyther.
3500
3501         * QtTestBrowser/cookiejar.cpp:
3502         (TestBrowserCookieJar::TestBrowserCookieJar):
3503
3504 2011-08-05  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
3505
3506         [Qt] QtTestBrowser: Add support for saving cookies on disk
3507         https://bugs.webkit.org/show_bug.cgi?id=65328
3508
3509         Simple cookiejar that saves cookies on disk.
3510
3511         Added menu options to clear cookies (Edit->Clear cookies) and
3512         disable disk cookies (Settings->[ ]Save Cookies on Disk).
3513
3514         Option -no-disk-cookies is also available.
3515
3516         Reviewed by Andreas Kling.
3517
3518         * QtTestBrowser/QtTestBrowser.pro:
3519         * QtTestBrowser/cookiejar.cpp: Added.
3520         * QtTestBrowser/cookiejar.h: Added.
3521         * QtTestBrowser/launcherwindow.cpp:
3522         * QtTestBrowser/launcherwindow.h:
3523         * QtTestBrowser/main.cpp:
3524
3525 2011-08-04  Adam Barth  <abarth@webkit.org>
3526
3527         model.js needs some unit testing
3528         https://bugs.webkit.org/show_bug.cgi?id=65730
3529
3530         Reviewed by Dimitri Glazkov.
3531
3532         These tests do not cover all the functions exported by the model
3533         module.  We'll need to add the remaining ones in the future.
3534
3535         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js: Added.
3536         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
3537
3538 2011-08-04  Adam Barth  <abarth@webkit.org>
3539
3540         Another speculative fix for the "svn revision on Windows" problem.
3541
3542         * Scripts/webkitpy/common/checkout/scm/git.py:
3543
3544 2011-08-04  Mark Rowe  <mrowe@apple.com>
3545
3546         Future-proof Xcode configuration settings.
3547
3548         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3549         * DumpRenderTree/mac/Configurations/CompilerVersion.xcconfig:
3550         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3551         * MiniBrowser/Configurations/Base.xcconfig:
3552         * MiniBrowser/Configurations/CompilerVersion.xcconfig:
3553         * MiniBrowser/Configurations/DebugRelease.xcconfig:
3554         * TestWebKitAPI/Configurations/Base.xcconfig:
3555         * TestWebKitAPI/Configurations/CompilerVersion.xcconfig:
3556         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
3557         * WebKitTestRunner/Configurations/Base.xcconfig:
3558         * WebKitTestRunner/Configurations/CompilerVersion.xcconfig:
3559         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3560
3561 2011-08-04  Adam Barth  <abarth@webkit.org>
3562
3563         Fancier debug logging.
3564
3565         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3566
3567 2011-08-04  David Levin  <levin@chromium.org>
3568
3569         [chromium] Fix assertion failure in ThreadIdentifierData::identifier in TestShell.
3570         https://bugs.webkit.org/show_bug.cgi?id=65685
3571
3572         Reviewed by Dmitry Titov.
3573