e2c9c724dfecebf9a21011af111e7c48a17c1538
[WebKit-https.git] / Tools / ChangeLog
1 2011-09-22  Adam Roben  <aroben@apple.com>
2
3         Quote the WEBKITLIBRARIESDIR path before passing it to the shell/cygpath
4
5         Fixes <http://webkit.org/b/68621> build-webkit goes totally haywire on Windows if there are
6         spaces in the path to the WebKit source tree
7
8         Reviewed by John Sullivan.
9
10         * Scripts/webkitdirs.pm:
11         (setupCygwinEnv):
12
13 2011-09-22  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
14
15         [Qt] Use same DPI for application font as rest of app in DRT and WTR
16
17         QApplication will initialize the default application font based
18         on the application DPI at construction time, but we then override
19         the application DPI using QX11Info (hard-coding it to 96 for
20         consistency). This hard-coding is not reflected in the application
21         font, so we explicitly have update the font ourselves.
22
23         The 6 test results that are updated were originally produced with
24         a DPI of 75, as this is the default fallback DPI when a QFont is
25         constructed before QApplication. This was wrong, and the results
26         are updated to match a DPI of 96.
27
28         Reviewed by Csaba Osztrogonác.
29
30         * DumpRenderTree/qt/main.cpp:
31         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
32
33 2011-09-21  Anna Cavender  <annacc@chromium.org>
34
35         Update committers.py with a new contributor contact        
36         https://bugs.webkit.org/show_bug.cgi?id=68565
37
38         Reviewed by Eric Carlson.
39
40         * Scripts/webkitpy/common/config/committers.py:
41
42 2011-09-21  Chang Shu  <cshu@webkit.org>
43
44         [WK2] [Mac] Implement a more-complete MouseDown/MouseUp/MouseMoveTo functions for WebKit2 EventSender
45         https://bugs.webkit.org/show_bug.cgi?id=68108
46
47         This patch implements the event sender mouse events through WebKit2 UIProcess which is
48         closer to the real simulation than a WebProcess-only approach. The patch only supports Mac
49         platform as the first step so the existing code is still kept for other platforms.
50
51         Reviewed by Darin Adler.
52
53         * WebKitTestRunner/EventSenderProxy.h:
54         (WTR::EventSenderProxy::EventSenderProxy):
55         (WTR::EventSenderProxy::leapForward):
56         (WTR::EventSenderProxy::currentEventTime):
57         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
58         (WTR::EventSendingController::EventSendingController):
59         (WTR::EventSendingController::mouseDown):
60         (WTR::EventSendingController::mouseUp):
61         (WTR::EventSendingController::mouseMoveTo):
62         (WTR::EventSendingController::leapForward):
63         (WTR::EventSendingController::keyDown):
64         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
65         * WebKitTestRunner/TestController.cpp:
66         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
67         * WebKitTestRunner/mac/EventSenderProxy.mm:
68         (WTR::eventTypeForMouseButtonAndAction):
69         (WTR::operator==):
70         (WTR::EventSenderProxy::updateClickCountForButton):
71         (WTR::EventSenderProxy::mouseDown):
72         (WTR::EventSenderProxy::mouseUp):
73         (WTR::EventSenderProxy::mouseMoveTo):
74         (WTR::EventSenderProxy::keyDown):
75         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
76         (WTR::EventSenderProxy::keyDown):
77         (WTR::EventSenderProxy::mouseDown):
78         (WTR::EventSenderProxy::mouseUp):
79         (WTR::EventSenderProxy::mouseMoveTo):
80
81 2011-09-21  Dan Bernstein  <mitz@apple.com>
82
83         Tools part of: Prevent the WebKit frameworks from defining inappropriately-named Objective-C classes
84         https://bugs.webkit.org/show_bug.cgi?id=68451
85
86         Reviewed by Darin Adler.
87
88         * Scripts/check-for-inappropriate-objc-class-names: Added. Checks for
89         Objective-C classes with names not having one of a list of prefixes
90         passed on the command line.
91
92 2011-09-21  Xianzhu Wang  <wangxianzhu@chromium.org>
93
94         Ensure TestWebKitAPI works on mac, win, chromium-mac and chromium-linux
95         https://bugs.webkit.org/show_bug.cgi?id=68206
96
97         Reviewed by Tony Chang.
98
99         * Scripts/webkitdirs.pm:
100         (determineBaseProductDir): add support for chromium-mac
101         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
102         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
103
104 2011-09-21  Adam Barth  <abarth@webkit.org>
105
106         garden-o-matic command should explain that it is starting a local server
107         https://bugs.webkit.org/show_bug.cgi?id=68486
108
109         Reviewed by Dimitri Glazkov.
110
111         In the user study, both participants didn't understand why the
112         garden-o-matic command appeared to hang.  This patch adds an
113         explaination of what's going on.  It also adds a confirmation prompt
114         before launching the browser to give the user a chance to read the
115         text.  If that's too much of a speed bump, we can iterate.
116
117         * Scripts/webkitpy/tool/commands/gardenomatic.py:
118
119 2011-09-21  Chang Shu  <cshu@webkit.org>
120
121         [Qt] Implement KeyDown function for WebKit2 EventSender.
122         https://bugs.webkit.org/show_bug.cgi?id=56485
123
124         Implement the KeyDown function on Qt platform.
125
126         Reviewed by Andreas Kling.
127
128         * WebKitTestRunner/PlatformWebView.h:
129         * WebKitTestRunner/TestController.cpp:
130         (WTR::TestController::TestController):
131         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
132         * WebKitTestRunner/qt/EventSenderProxyQt.cpp: Added.
133         (WTR::getModifiers):
134         (WTR::EventSenderProxy::keyDown):
135         (buildModifierFlags):
136         (EventSenderProxy::keyDown):
137         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
138         (WTR::PlatformWebView::sendEvent):
139         * WebKitTestRunner/qt/WebKitTestRunner.pro:
140
141 2011-09-20  Adam Barth  <abarth@webkit.org>
142
143         garden-o-matic unit test fail because Safari 5.1 doesn't enumerate dictionaries in the same order as V8
144         https://bugs.webkit.org/show_bug.cgi?id=68496
145
146         Reviewed by Dimitri Glazkov.
147
148         This patch adds a bunch of sorting to make sure things happen in a
149         predictable order in both JavaScriptCore and V8.  We've talked before
150         about whether these two JavaScript engines should enumerate
151         dictionaries in the same order, but the consensus has been that they
152         shouldn't.  Personally, I disagree with that consensus, but such is life.
153
154         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
155         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
156         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
157         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
158
159 2011-09-20  Adam Barth  <abarth@webkit.org>
160
161         garden-o-matic doesn't work in Safari 5.1 because Safari 5.1 lacks Function.prototype.bind
162         https://bugs.webkit.org/show_bug.cgi?id=68495
163
164         Reviewed by Dimitri Glazkov.
165
166         This patch adds an implementation of Function.prototype.bind if the browser lacks one.
167
168         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
169
170 2011-09-20  Eric Seidel  <eric@webkit.org>
171
172         [NRWT] REGRESSION: Local loader tests are failing on machines that lost /tmp/LayoutTests symlink
173         https://bugs.webkit.org/show_bug.cgi?id=65781
174
175         Reviewed by Ryosuke Niwa.
176
177         Instead of making NRWT create the symlink, I made DumpRenderTree smart enough
178         to resolve the passed in url relative to the absolute url for the test.
179         For http tests, since the test url is an http url, we can't resolve relative
180         to the test path, and thus use a new LOCAL_RESOURCE_ROOT environment variable
181         for resolving.
182
183         I believe this is a better approach than the on used in the Qt and Chromium DRT's
184         (which resolves the path relative to the built location of the DRT executable)
185         and we should move this new code into a shared location in a follow-up patch.
186
187         It turns out that there was a second use for pathToLocalResource, used by one
188         test (http/tests/plugins/post-url-file.html) used for getting a path to /tmp.
189         To support this test I made the new pathToLocalResource smart enough to map
190         /tmp to DUMPRENDERTREE_TEMP (which is already defined for all ports).
191
192         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
193         (LayoutTestController::pathToLocalResource):
194         * Scripts/webkitpy/layout_tests/port/webkit.py: Set LOCAL_RESOURCE_ROOT for use by DRT.
195
196 2011-09-20  Tom Zakrajsek  <tomz@codeaurora.org>
197
198         Need to specify a django version, instead of using default
199         https://bugs.webkit.org/show_bug.cgi?id=68398
200
201         Reviewed by Eric Seidel.
202
203         * QueueStatusServer/__init__.py:
204         * QueueStatusServer/main.py:
205
206 2011-09-20  Tom Zakrajsek  <tomz@codeaurora.org>
207
208         Update committers.py with a few more contributor contacts
209         https://bugs.webkit.org/show_bug.cgi?id=68487
210
211         Reviewed by Eric Seidel.
212
213         * Scripts/webkitpy/common/config/committers.py:
214
215 2011-09-20  Leandro Pereira  <leandro@profusion.mobi>
216
217         Fix webkitpy unit tests after 95547 and 95549
218         https://bugs.webkit.org/show_bug.cgi?id=68483
219
220         Reviewed by Adam Barth.
221         
222         Fix tests for ChangeLog.touched_files() and ChangeLog.parse_entries_from_file().
223
224         * Scripts/webkitpy/common/checkout/changelog_unittest.py: While testing
225         parse_entries_from_file(), use StringIO and entry.reviewer_text().
226         While testing parse_latest_entry_from_file(), expect the correct
227         touched_files() list.
228
229 2011-09-20  Adam Barth  <abarth@webkit.org>
230
231         garden-o-matic makes it hard to compare images when scroll bars appear
232         https://bugs.webkit.org/show_bug.cgi?id=68482
233
234         Reviewed by Eric Seidel.
235
236         Because we autoscale image width, the images rescale if we overflow
237         vertically and get a scrollbar.  That makes it hard to compare two sets
238         of images.  This patch reserves space for the scrollbar so we won't
239         have the layout change.
240
241         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css:
242
243 2011-09-20  Sheriff Bot  <webkit.review.bot@gmail.com>
244
245         Unreviewed, rolling out r95565.
246         http://trac.webkit.org/changeset/95565
247         https://bugs.webkit.org/show_bug.cgi?id=68470
248
249         Broke builds (Requested by andersca on #webkit).
250
251         * MiniBrowser/gtk/BrowserWindow.c:
252         (mouseDidMoveOverElement):
253
254 2011-09-20  Nayan Kumar K  <nayankk@motorola.com>
255
256         Get hover'ed element URL from HitTest.
257         
258         mouseDidMoveOverElement now gets the hover'ed element link using
259         WKHitTestResult API's.
260         https://bugs.webkit.org/show_bug.cgi?id=68426
261
262         Reviewed by Anders Carlsson.
263
264         * MiniBrowser/gtk/BrowserWindow.c:
265         (mouseDidMoveOverElement):
266
267 2011-09-20  Leandro Pereira  <leandro@profusion.mobi>
268
269         Changelog class should have a method to return all entries
270         https://bugs.webkit.org/show_bug.cgi?id=68399
271         
272         Implement ChangeLog.parse_entries_from_file(). This method returns a generator
273         of ChangeLogEntry objects, ordered from the latest to the oldest entry in the file.
274
275         Reviewed by Ryosuke Niwa.
276
277         * Scripts/webkitpy/common/checkout/changelog.py: Copy parse_latest_entry_from_file()
278         and adapt it to become a generator.
279         * Scripts/webkitpy/common/checkout/changelog_unittest.py: Add test case.
280
281 2011-09-20  Jarred Nicholls  <jarred@sencha.com>
282
283         [Qt] Permit qrc resources to load in QWebSettings::setUserStyleSheetUrl()
284         https://bugs.webkit.org/show_bug.cgi?id=51159
285
286         Permit any URL with a local scheme to set a user style sheet. Allow qrc
287         resource URLs as arguments to QWebSettings::setUserStyleSheetUrl().
288         
289         Add DRT/WKTR qrc resource to test loading user style sheets from a qrc URL.
290
291         Reviewed by Kenneth Rohde Christiansen.
292
293         * DumpRenderTree/qt/DumpRenderTree.pro:
294         * DumpRenderTree/qt/DumpRenderTree.qrc: Added.
295         * DumpRenderTree/qt/resources/user.css: Added.
296         (body):
297         * WebKitTestRunner/qt/WebKitTestRunner.pro:
298         * WebKitTestRunner/qt/WebKitTestRunner.qrc: Added.
299         * WebKitTestRunner/qt/resources/user.css: Added.
300         (body):
301
302 2011-09-20  Leandro Pereira  <leandro@profusion.mobi>
303
304         ChangeLogEntry class should contain a list of touched files
305         https://bugs.webkit.org/show_bug.cgi?id=68115
306
307         Reviewed by Eric Seidel.
308         
309         Add method to return the list of files touched in a ChangeLog entry.
310
311         * Scripts/webkitpy/common/checkout/changelog.py: Add
312         touched_files_regexp and touched_files() method.
313         * Scripts/webkitpy/common/checkout/changelog_unittest.py: Implement
314         unit tests for touched_files() method.
315
316 2011-09-20  Sheriff Bot  <webkit.review.bot@gmail.com>
317
318         Unreviewed, rolling out r95526 and r95541.
319         http://trac.webkit.org/changeset/95526
320         http://trac.webkit.org/changeset/95541
321         https://bugs.webkit.org/show_bug.cgi?id=68443
322
323         It broke 6 tests (Requested by ossy_ on #webkit).
324
325         * DumpRenderTree/qt/main.cpp:
326         (main):
327         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
328         (WTR::activateFonts):
329
330 2011-09-20  Tom Zakrajsek  <tomz@codeaurora.org>
331
332         Fix patch and bug numbering in the mocktool simulation code
333         https://bugs.webkit.org/show_bug.cgi?id=68374
334
335         Reviewed by Adam Barth.
336
337         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
338         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
339         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
340         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
341         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
342         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
343         * Scripts/webkitpy/tool/commands/download_unittest.py:
344         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
345         * Scripts/webkitpy/tool/commands/queries_unittest.py:
346         * Scripts/webkitpy/tool/commands/queues_unittest.py:
347         * Scripts/webkitpy/tool/commands/queuestest.py:
348         * Scripts/webkitpy/tool/commands/upload_unittest.py:
349         * Scripts/webkitpy/tool/mocktool.py:
350         * Scripts/webkitpy/tool/steps/steps_unittest.py:
351         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
352
353 2011-09-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
354
355         [Qt] Don't override default QApplication font for DRT and WTR
356
357         Revision 95526 moved the relevant code below the QApplication
358         constructor, to fix a potential crash, and that made the code
359         take effect, breaking 6 tests.
360
361         We should rely on the QWebSettings to set default fonts, and
362         this QApplication::setFont() is a relic from when we didn't
363         have that option, so we remove the code.
364
365         Reviewed by Csaba Osztrogonác.
366
367         * DumpRenderTree/qt/main.cpp:
368         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
369
370 2011-09-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
371
372         WebKitTestRunner: Provide usage if run without arguments
373
374         If WTR is run without either one or more filenames, or
375         a '-' to indicate server mode, we don't need to start
376         up the test machinery. Doing so might actually crash,
377         as we'll exit the application immedeatly after anyways.
378
379         Reviewed by Simon Hausmann.
380
381         * WebKitTestRunner/TestController.cpp:
382         (WTR::TestController::initialize):
383
384 2011-09-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
385
386         [Qt] Don't use QFont before initializing QApplication
387
388         Could potentially result in crash.
389
390         Reviewed by Simon Hausmann.
391
392         * DumpRenderTree/qt/main.cpp:
393         (main):
394
395 2011-09-19  Adam Barth  <abarth@webkit.org>
396
397         Always enable ENABLE(EVENTSOURCE)
398         https://bugs.webkit.org/show_bug.cgi?id=68414
399
400         Reviewed by Eric Seidel.
401
402         * Scripts/build-webkit:
403
404 2011-09-19  David Levin  <levin@chromium.org>
405
406         Sheriffbot rollout should be more intuitive.
407         https://bugs.webkit.org/show_bug.cgi?id=68415
408
409         Reviewed by Adam Barth.
410
411         * Scripts/webkitpy/tool/bot/irc_command.py: Add support for revert and comma separated args.
412         * Scripts/webkitpy/tool/bot/irc_command_unittest.py: Add parsing tests for comma separated args
413           and a few others cases.
414         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: Verify that revert works.
415
416 2011-09-19  David Levin  <levin@chromium.org>
417
418         check-webkit-style generates bogus warning for StructuredExceptionHandlerSupressor.h
419         https://bugs.webkit.org/show_bug.cgi?id=68391
420
421         Reviewed by Darin Adler.
422
423         * Scripts/webkitpy/style/checkers/cpp.py: Skip __asm lines when doing style checks on a line.
424         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added a test for this.
425
426 2011-09-19  Alexis Menard  <alexis.menard@openbossa.org>
427
428         Style checker should not check public Qt WK2 API for parameter_name.
429         https://bugs.webkit.org/show_bug.cgi?id=68359
430
431         Reviewed by Andreas Kling.
432
433         The public Qt WK2 APIs have different rules than WebKit for parameters of methods in h files.
434         Add an exception in the style checker to disable the check. Also added the test for it.
435
436         * Scripts/webkitpy/style/checker.py:
437         * Scripts/webkitpy/style/checker_unittest.py:
438
439 2011-09-19  Leandro Pereira  <leandro@profusion.mobi>
440
441         GTK DRT leaks memory while comparing history items
442         https://bugs.webkit.org/show_bug.cgi?id=68086
443
444         Reviewed by Martin Robinson.
445         
446         webkit_web_history_item_get_target() returns a g_strdup()'d string,
447         so memory must be freed before compareHistoryItems() returns.
448
449         * DumpRenderTree/gtk/DumpRenderTree.cpp:
450         (compareHistoryItems): Use GOwnPtr to manage memory automatically.
451
452 2011-09-19  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
453
454         Buildbot marks a nrwt bot red when tests are missing results
455         https://bugs.webkit.org/show_bug.cgi?id=64812
456
457         Reviewed by Ryosuke Niwa.
458
459         * Scripts/webkitpy/layout_tests/controllers/manager.py:
460         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
461
462 2011-09-19  Jessie Berlin  <jberlin@apple.com>
463
464         Sites that use history pushState or replaceState are recorded in history in Private Browsing
465         mode.
466         https://bugs.webkit.org/show_bug.cgi?id=68208
467
468         Reviewed by Brady Eidson.
469
470         Add a test that the WKContextDidNavigateWithNavigationDataCallback (which is invoked by
471         updateGlobalHistory) is not called in Private Browsing when the page does history.pushState.
472
473         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp: Added.
474         (TestWebKitAPI::didNavigateWithNavigationData):
475         This is a context history client callback, so it should not be called when in Private
476         Browsing. Add a call to FAIL().
477         (TestWebKitAPI::didSameDocumentNavigationForFrame):
478         This is a page load client callback that happens after the didNavigateWithNavigationData
479         callback. End the test.
480         (TestWebKitAPI::TEST):
481         Enable Private Browsing and load a page that uses history.pushState.
482
483         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
484         Add PrivateBrowsingPushStateNoHistoryCallback.cpp and push-state.html.
485         * TestWebKitAPI/Tests/WebKit2/push-state.html: Added.
486         Ditto.
487         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
488         Ditto.
489         * TestWebKitAPI/win/copy-resources.cmd:
490         Ditto.
491
492 2011-09-16  Elliot Poger  <epoger@google.com>
493
494         add non-CG Webkit-Mac builds to flakiness dashboard
495         https://bugs.webkit.org/show_bug.cgi?id=68265
496
497         Reviewed by Adam Barth.
498
499         As Chromium-on-Mac approaches the switchover from Core Graphics to
500         Skia, we need to add the Skia version to the flakiness dashboard.
501
502         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
503         * TestResultServer/static-dashboards/builders.js:
504         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
505
506 2011-09-16  Jochen Eisinger  <jochen@chromium.org>
507
508         Rename FrameLoaderClient::allowImages to FrameLoaderClient::allowImage and include the image URL as parameter
509         https://bugs.webkit.org/show_bug.cgi?id=68071
510
511         Reviewed by Adam Barth.
512
513         * DumpRenderTree/chromium/WebPermissions.cpp:
514         (WebPermissions::allowImage):
515         * DumpRenderTree/chromium/WebPermissions.h:
516
517 2011-09-16  Tom Zakrajsek  <tomz@codeaurora.org>
518
519         update-webkit-chromium should retry the gclient call if it fails once
520         https://bugs.webkit.org/show_bug.cgi?id=68252
521
522         Reviewed by Adam Barth.
523
524         * Scripts/update-webkit-chromium:
525
526 2011-09-16  Rob Buis  <rbuis@rim.com>
527
528         Add Eli's rim address and change the nick.
529
530         * Scripts/webkitpy/common/config/committers.py:
531
532 2011-09-16  Anders Carlsson  <andersca@apple.com>
533
534         Add back the WKHitTestResultRef parameter to mouseDidMoveOverElement in an ABI preserving way
535         https://bugs.webkit.org/show_bug.cgi?id=68269
536
537         Reviewed by Geoffrey Garen.
538
539         Update client function signatures.
540
541         * MiniBrowser/gtk/BrowserWindow.c:
542         (browserWindowUIClientInit):
543         * MiniBrowser/mac/BrowserWindowController.m:
544         (mouseDidMoveOverElement):
545         (-[BrowserWindowController awakeFromNib]):
546         * MiniBrowser/win/BrowserView.cpp:
547         (BrowserView::create):
548         * WebKitTestRunner/TestController.cpp:
549         (WTR::TestController::createOtherPage):
550         (WTR::TestController::initialize):
551
552 2011-09-16  Anders Carlsson  <andersca@apple.com>
553
554         Temporarily remove the WKHitTestResultRef parameter to avoid breaking the WK2 ABI/API
555         https://bugs.webkit.org/show_bug.cgi?id=68266
556
557         Reviewed by John Sullivan.
558
559         * MiniBrowser/mac/BrowserWindowController.m:
560         (mouseDidMoveOverElement):
561
562 2011-09-16  Vincent Scheib  <scheib@chromium.org>
563
564         Add Vincent Scheib to the committers list.
565
566         * Scripts/webkitpy/common/config/committers.py:
567
568 2011-09-16  Sheriff Bot  <webkit.review.bot@gmail.com>
569
570         Unreviewed, rolling out r95285.
571         http://trac.webkit.org/changeset/95285
572         https://bugs.webkit.org/show_bug.cgi?id=68247
573
574         It broke a webkitpy test (Requested by ossy on #webkit).
575
576         * Scripts/webkitpy/layout_tests/controllers/manager.py:
577
578 2011-09-16  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
579
580         Buildbot marks a nrwt bot red when tests are missing results
581         https://bugs.webkit.org/show_bug.cgi?id=64812
582
583         Reviewed by Dirk Pranke.
584
585         * Scripts/webkitpy/layout_tests/controllers/manager.py:
586
587 2011-09-16  Martin Robinson  <mrobinson@igalia.com>
588
589         [GTK] Disable WebKit2 by default in configure.ac, but enable it with build-webkit
590         https://bugs.webkit.org/show_bug.cgi?id=68178
591
592         Reviewed by Xan Lopez.
593
594         Add a work-around to enable WebKit2 when using build-webkit.
595
596         * Scripts/webkitdirs.pm:
597         (buildAutotoolsProject): 
598
599 2011-09-15  James Robinson  <jamesr@chromium.org>
600
601         Add Antoine Labour and Shawn Singh to the contributors-but-not-committers list.
602
603         * Scripts/webkitpy/common/config/committers.py:
604
605 2011-09-15  Tom Zakrajsek  <tomz@codeaurora.org>
606
607         UpdateChangeLogsWithReviewer should be able to determine reviewer of latest reviewed patch in a bug
608         https://bugs.webkit.org/show_bug.cgi?id=68003
609
610         Reviewed by Adam Barth.
611
612         * Scripts/webkitpy/tool/mocktool.py:
613         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
614         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
615
616 2011-09-15  Tom Zakrajsek  <tomz@codeaurora.org>
617
618         Python version check is confusing in test-webkitpy
619         https://bugs.webkit.org/show_bug.cgi?id=68004
620
621         Reviewed by Adam Barth.
622
623         * Scripts/test-webkitpy:
624
625 2011-09-15  Eric Seidel  <eric@webkit.org>
626
627         Reviewed by Adam Barth.
628
629         webkit-patch should be able to find users and add them to bugzilla groups
630         https://bugs.webkit.org/show_bug.cgi?id=63351
631
632         These are both very basic commands.  But it's now possible to find
633         all users matching a regexp, as well as add all users matching a regexp
634         to a set of groups.
635
636         bugzilla.py already knew how to find users (for validate-committer-lists)
637         but now it has the ability to modify the user records.
638
639         I split some of the logic out into a new EditUsersParser class
640         to try and reduce the amount of code in Bugzilla/BugzillaQueries.
641
642         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
643         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
644         * Scripts/webkitpy/tool/commands/__init__.py:
645         * Scripts/webkitpy/tool/commands/adduserstogroups.py: Added.
646         * Scripts/webkitpy/tool/commands/findusers.py: Added.
647
648 2011-09-15  Eric Seidel  <eric@webkit.org>
649
650         Remove ENABLE(SVG_AS_IMAGE) since all major ports have it on by default
651         https://bugs.webkit.org/show_bug.cgi?id=68182
652
653         Reviewed by Adam Barth.
654
655         * Scripts/build-webkit:
656         * waf/build/settings.py:
657
658 2011-09-15  Eric Seidel  <eric@webkit.org>
659
660         Unreviewed.  Make contributor email look-up case-insensitive.
661
662         validate-committer-list was incorrectly reporting that "chang.shu@nokia.com"
663         was missing from committers.py due to case sensitivity.
664
665         This also includes a test expectations update to committers_unittest.py
666         after my previous change.
667
668         * Scripts/webkitpy/common/config/committers.py:
669         * Scripts/webkitpy/common/config/committers_unittest.py:
670         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
671
672 2011-09-15  Eric Seidel  <eric@webkit.org>
673
674         Unreviewed.  Updated this based on webkit-patch suggest-nominations and validate-committer-list output.
675
676         Add a bunch of email aliases to committers.py for regular contributors
677         who are committing using other email addresses than they have listed in the file.
678
679         * Scripts/webkitpy/common/config/committers.py:
680
681 2011-09-15  Eric Seidel  <eric@webkit.org>
682
683         Remove ENABLE_SVG_ANIMATION as all major ports have it on by default
684         https://bugs.webkit.org/show_bug.cgi?id=68022
685
686         Reviewed by Ryosuke Niwa.
687
688         * Scripts/build-webkit:
689         * waf/build/settings.py:
690
691 2011-09-15  Anders Carlsson  <andersca@apple.com>
692
693         Fix Mac build by including config.h where needed.
694
695         * TestWebKitAPI/Tests/TestWebKitAPI/mac/InstanceMethodSwizzler.mm:
696         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
697         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
698         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
699         * TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp:
700         * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:
701         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
702         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
703         * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm:
704         * TestWebKitAPI/mac/InstanceMethodSwizzler.mm:
705         * TestWebKitAPI/mac/JavaScriptTestMac.mm:
706         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
707         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
708         * TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.m:
709         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
710         * TestWebKitAPI/mac/main.mm:
711
712 2011-09-15  Xianzhu Wang  <wangxianzhu@chromium.org>
713
714         Let TestWebKitAPI work for chromium
715         https://bugs.webkit.org/show_bug.cgi?id=67756
716
717         Reviewed by Sam Weinig.
718
719         * Scripts/build-api-tests:
720         * Scripts/run-api-tests:
721         (isSupportedPlatform):
722         (runTest):
723         (populateTests):
724         * Scripts/webkitdirs.pm:
725         (determineBaseProductDir):
726         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
727         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
728         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
729         * TestWebKitAPI/InjectedBundleController.cpp:
730         * TestWebKitAPI/InjectedBundleMain.cpp:
731         * TestWebKitAPI/JavaScriptTest.cpp:
732         * TestWebKitAPI/PlatformUtilities.cpp:
733         * TestWebKitAPI/TestWebKitAPI.gypi: Added.
734         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
735         * TestWebKitAPI/TestWebKitAPIPrefix.h: Removed.
736         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
737         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
738         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
739         * TestWebKitAPI/Tests/WTF/VectorReverse.cpp:
740         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
741         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
742         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
743         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
744         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
745         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
746         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
747         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
748         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
749         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
750         * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
751         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
752         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
753         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
754         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
755         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
756         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp:
757         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp:
758         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp:
759         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
760         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash_Bundle.cpp:
761         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
762         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
763         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
764         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
765         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly_Bundle.cpp:
766         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
767         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
768         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
769         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
770         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
771         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
772         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
773         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp:
774         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
775         * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp:
776         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
777         * TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp:
778         * TestWebKitAPI/TestsController.cpp:
779         * TestWebKitAPI/config.h: Copied from TestWebKitAPI/TestWebKitAPIPrefix.h.
780         * TestWebKitAPI/win/InjectedBundleControllerWin.cpp:
781         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
782         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
783         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
784         * TestWebKitAPI/win/main.cpp:
785
786 2011-09-15  Jochen Eisinger  <jochen@chromium.org>
787
788         [chromium] extract normalization of LayoutTests URLs to a method of TestShell
789         https://bugs.webkit.org/show_bug.cgi?id=68145
790
791         This will allow for other classes in DumpRenderTree to reuse this functionality
792
793         Reviewed by David Levin.
794
795         * DumpRenderTree/chromium/TestShell.cpp:
796         (normalizeLayoutTestURLInternal):
797         (dumpHistoryItem):
798         (TestShell::normalizeLayoutTestURL):
799         * DumpRenderTree/chromium/TestShell.h:
800
801 2011-09-14  Ada Chan  <adachan@apple.com>
802
803         Add test for WKBundleFrameCopyWebArchive().
804         https://bugs.webkit.org/show_bug.cgi?id=67857
805
806         Reviewed by Anders Carlsson.
807
808         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp: Added.
809         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Do some basic sanity checks to make sure
810         the returned data is a valid webarchive.
811         (TestWebKitAPI::setInjectedBundleClient):
812         (TestWebKitAPI::didFinishLoadForFrame):
813         (TestWebKitAPI::TEST): Load simple.html in a WebView.  Wait for it to finish loading, and then ask the
814         injected bundle for the webarchive and check the returned webarchive.
815         * TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp: Added.
816         (TestWebKitAPI::WebArchiveTest::WebArchiveTest):
817         (TestWebKitAPI::WebArchiveTest::didReceiveMessage): Handle the "GetWebArchive" message and return
818         the web archive.
819
820         Add files to project.
821         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Also let Visual Studio reorder a file.
822         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
823         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
824
825 2011-09-14  Ryosuke Niwa  <rniwa@webkit.org>
826
827         committers.py should support multiple IRC nicknames
828         https://bugs.webkit.org/show_bug.cgi?id=68110
829
830         Reviewed by Eric Seidel.
831
832         Add multiple IRC nickname support to committers.py
833
834         * Scripts/webkitpy/common/config/committers.py:
835         * Scripts/webkitpy/common/config/committers_unittest.py:
836         * Scripts/webkitpy/tool/bot/irc_command.py:
837         * Scripts/webkitpy/tool/bot/sheriff.py:
838
839 2011-09-14  Jon Lee  <jonlee@apple.com>
840
841         Implement globalFlag for WebKitTestRunner
842         https://bugs.webkit.org/show_bug.cgi?id=68033
843         <rdar://problem/10119204>
844
845         Reviewed by Sam Weinig.
846
847         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Porting globalFlag from DRT
848         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
849         (WTR::LayoutTestController::LayoutTestController): initialize m_globalFlag to false
850         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: add m_globalFlag
851         (WTR::LayoutTestController::globalFlag): simple getter
852         (WTR::LayoutTestController::setGlobalFlag): simple setter
853
854 2011-09-13  Eric Seidel  <eric@webkit.org>
855
856         Remove ENABLE_SVG_USE as <use> is required by HTML5
857         https://bugs.webkit.org/show_bug.cgi?id=68019
858
859         Reviewed by Ryosuke Niwa.
860
861         * Scripts/build-webkit:
862         * waf/build/settings.py:
863
864 2011-09-14  Ryosuke Niwa  <rniwa@webkit.org>
865
866         Remove Jan Erik Hanssen (added in my r95078) from the list for now
867         since I can't confirm acceptable his committership.
868
869         * Scripts/webkitpy/common/config/committers.py:
870
871 2011-09-14  Jochen Eisinger  <jochen@chromium.org>
872
873         [chromium] Remove obsolete WebViewClient methods from DumpRenderTree.
874         https://bugs.webkit.org/show_bug.cgi?id=68066
875
876         Reviewed by Adam Barth.
877
878         * DumpRenderTree/chromium/WebViewHost.cpp:
879         * DumpRenderTree/chromium/WebViewHost.h:
880
881 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
882
883         committers.py is missing some contributors
884         https://bugs.webkit.org/show_bug.cgi?id=68059
885
886         Reviewed by Adam Barth.
887
888         Add David Barr, Jan Erik Hanssen, and Kim Grönholm.
889
890         Also add nicks of Alejandro G. Castro, Collin Jackson, and Matt Lilek.
891
892         * Scripts/webkitpy/common/config/committers.py:
893
894 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
895
896         Fix webkit python test after r95061.
897
898         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
899
900 2011-09-13  Xianzhu Wang  <wangxianzhu@chromium.org>
901
902         Add myself as a contributor. No review needed.
903
904         * Scripts/webkitpy/common/config/committers.py:
905
906 2011-09-13  Adam Barth  <abarth@webkit.org>
907
908         garden-o-matic has unfriendly error messages when the local server is not available
909         https://bugs.webkit.org/show_bug.cgi?id=68042
910
911         Reviewed by Dimitri Glazkov.
912
913         This patch moves us from using alert to showing the error inline in the
914         progress dialog.
915
916         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
917         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
918         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
919         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
920         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
921
922 2011-09-13  Adam Barth  <abarth@webkit.org>
923
924         FailureGrid in garden-o-matic should link to the builder's waterfall page
925         https://bugs.webkit.org/show_bug.cgi?id=68036
926
927         Reviewed by Dimitri Glazkov.
928
929         One of the users in the user study thought the configurations names in
930         the failure grid would link to the underlying bots.  That makes sense,
931         so this patch adds the behavior.
932
933         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
934         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
935         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
936         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
937
938 2011-09-13  Adam Barth  <abarth@webkit.org>
939
940         garden-o-matic should be able to mark failures as expected
941         https://bugs.webkit.org/show_bug.cgi?id=68027
942
943         Reviewed by Dimitri Glazkov.
944
945         All the back-end infrastructure exists for this operation.  This patch
946         just adds some UI to the front-end and wires that UI up to the back
947         end.  This exact UI will likely need some more polish, but this should
948         be a reasonable first cut.
949
950         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
951         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
952         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
953         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
954         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
955
956 2011-09-13  Adam Barth  <abarth@webkit.org>
957
958         garden-o-matic should tell you about the progress of your rebaseline
959         https://bugs.webkit.org/show_bug.cgi?id=67967
960
961         Reviewed by Dimitri Glazkov.
962
963         This patch adds ui.MessageBox, which is a light wrapper around jQuery
964         UI's dialog widget.  We then use ui.MessageBox to show status messages
965         about in-progress rebaselines.  As each baseline is downloaded, the
966         MessageBox updates.  This UI replaces our temporary "alert"-based UI.
967
968         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
969         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
970         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
971         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
972         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
973         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
974
975 2011-09-13  Leandro Pereira  <leandro@profusion.mobi>
976
977         GTK DumpRenderTree uses inefficient idioms to iterate over G[S]Lists
978         https://bugs.webkit.org/show_bug.cgi?id=68024
979
980         Reviewed by Gustavo Noronha Silva.
981         
982         Using g_list_count() and g_list_nth_data() together on a loop is
983         inneficient since they're both O(n). Iterate over lists in a saner
984         way.
985
986         * DumpRenderTree/gtk/DumpRenderTree.cpp:
987         (dumpHistoryItem): Reduce the scope for the 'kids' variable, and
988         iterate on it using g_list_next(). Free the list after done with it.
989         (dumpBackForwardListForWebView): Instead of appending (which is
990         expensive in GLists) history items and then iterating from the tail
991         of the itemsToPrint list, prepend items and walk forwards as usual.
992         (dumpBackForwardListForAllWebViews): Walk the list in a saner way,
993         remove the (unneeded) viewList variable.
994
995 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
996
997         Add Eric's IRC nick.
998
999         * Scripts/webkitpy/common/config/committers.py:
1000
1001 2011-09-13  Anders Carlsson  <andersca@apple.com>
1002
1003         Disable C++ exceptions when building with clang
1004         https://bugs.webkit.org/show_bug.cgi?id=68031
1005         <rdar://problem/9556880>
1006
1007         Reviewed by Mark Rowe.
1008
1009         * MiniBrowser/Configurations/Base.xcconfig:
1010         * TestWebKitAPI/Configurations/Base.xcconfig:
1011         * WebKitTestRunner/Configurations/Base.xcconfig:
1012
1013 2011-09-13  Ojan Vafai  <ojan@chromium.org>
1014
1015         [chromium] fix flakiness dashboard for chromium interactive tests
1016         https://bugs.webkit.org/show_bug.cgi?id=68029
1017
1018         Reviewed by Tony Chang.
1019
1020         * TestResultServer/static-dashboards/flakiness_dashboard.html:
1021         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
1022
1023 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
1024
1025         Add Alice and Aryeh to the list of contributors.
1026
1027         * Scripts/webkitpy/common/config/committers.py:
1028
1029 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
1030
1031         sheriffbot whois should also tell us email addresses
1032         https://bugs.webkit.org/show_bug.cgi?id=67975
1033
1034         Reviewed by Eric Seidel and David Levin.
1035
1036         Taught sheriffbot how to tell us contributor's email addresses.
1037
1038         * Scripts/webkitpy/tool/bot/irc_command.py:
1039         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1040
1041 2011-09-13  Eric Seidel  <eric@webkit.org>
1042
1043         Remove ENABLE_SVG_FOREIGN_OBJECT as it is a required part of HTML5
1044         https://bugs.webkit.org/show_bug.cgi?id=68018
1045
1046         Reviewed by Ryosuke Niwa.
1047
1048         * Scripts/build-webkit:
1049         * waf/build/settings.py:
1050
1051 2011-09-13  Chang Shu  <cshu@webkit.org>
1052
1053         [WK2] [Mac] Implement KeyDown function for WebKit2 EventSender.
1054         https://bugs.webkit.org/show_bug.cgi?id=57515
1055
1056         The code change in WebKitTestRunner first sends keydown event from InjectedBundle to
1057         TestController synchronously. The latter then sends simulated event to WebKit2 module,
1058         which is synchronous, too.
1059
1060         Reviewed by Darin Adler.
1061
1062         * WebKitTestRunner/EventSenderProxy.h: Added.
1063         (WTR::EventSenderProxy::EventSenderProxy):
1064         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
1065         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1066         (WTR::EventSendingController::keyDown):
1067         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1068         * WebKitTestRunner/PlatformWebView.h:
1069         (WTR::PlatformWebView::platformWindow):
1070         * WebKitTestRunner/TestController.cpp:
1071         (WTR::TestController::TestController):
1072         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
1073         * WebKitTestRunner/TestController.h:
1074         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1075         * WebKitTestRunner/mac/EventSenderProxy.mm: Added.
1076         (WTR::buildModifierFlags):
1077         (WTR::EventSenderProxy::keyDown):
1078
1079 2011-09-12  Leandro Pereira  <leandro@profusion.mobi>
1080
1081         [EFL] DRT: Add DumpRenderTreeEfl.h
1082         https://bugs.webkit.org/show_bug.cgi?id=63993
1083
1084         Reviewed by Eric Seidel.
1085         
1086         This header contains some global variables used by EFL's
1087         DumpRenderTree implementation.
1088
1089         * DumpRenderTree/DumpRenderTree.h: Include DumpRenderTreeEfl.h when
1090         appropriate.
1091         * DumpRenderTree/efl/DumpRenderTreeEfl.h: Added.
1092
1093 2011-09-12  Raphael Kubo da Costa  <kubo@profusion.mobi>
1094
1095         [EFL] Send the right key names for PageUp and PageDown.
1096         https://bugs.webkit.org/show_bug.cgi?id=67044
1097
1098         Reviewed by Kenneth Rohde Christiansen.
1099
1100         PlatformKeyboardEventEfl uses "Prior" and "Next" to refer to PageUp and
1101         PageDown (which is close to the defines in WindowsKeyboardCodes.h).
1102         However, EventSender was sending "Page_Up" and "Page_Down", so tests
1103         such as editing/input/page-up-down-scrolls.html were timing out due to
1104         the right key down events not being sent.
1105
1106         * DumpRenderTree/efl/EventSender.cpp:
1107         (keyPadNameFromJSValue):
1108         (keyNameFromJSValue):
1109
1110 2011-09-12  Eric Seidel  <eric@webkit.org>
1111
1112         sheriffbot whois is case sensitive
1113         https://bugs.webkit.org/show_bug.cgi?id=67972
1114
1115         Reviewed by Adam Barth.
1116
1117         I also fixed a typo in the "More than 5 contributors" message
1118         from my previous commit.
1119
1120         * Scripts/webkitpy/common/config/committers.py:
1121         * Scripts/webkitpy/common/config/committers_unittest.py:
1122         * Scripts/webkitpy/tool/bot/irc_command.py:
1123         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1124
1125 2011-09-12  Eric Seidel  <eric@webkit.org>
1126
1127         sheriffbot whois should be smarter
1128         https://bugs.webkit.org/show_bug.cgi?id=67971
1129
1130         Reviewed by Adam Barth.
1131
1132         This makes sheriffbot whois basically grep the committers list
1133         making it much easier to find a contributor by name.
1134
1135         Unfortunately the current unittests depend on the real committers.py
1136         file, so as we add more eric's to the project, this unittest result will
1137         change.  I think that's OK for now.  We'll fix it when it breaks.
1138
1139         * Scripts/webkitpy/common/config/committers.py:
1140         * Scripts/webkitpy/tool/bot/irc_command.py:
1141         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1142
1143 2011-09-12  Sheriff Bot  <webkit.review.bot@gmail.com>
1144
1145         Unreviewed, rolling out r94976.
1146         http://trac.webkit.org/changeset/94976
1147         https://bugs.webkit.org/show_bug.cgi?id=67953
1148
1149         Broke a bunch of security/load& tests (Requested by rniwa on
1150         #webkit).
1151
1152         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1153         (LayoutTestController::pathToLocalResource):
1154
1155 2011-09-12  Eric Seidel  <eric@webkit.org>
1156
1157         Rubber-stamped by Adam Barth.
1158
1159         Remove the "the tree is burning!" warning previously shown
1160         when landing patches.  It was a dream.  But it's just noise now.
1161
1162         Some bots will require a restart to notice the removal of the option
1163         so I've left the --ignore-builders option in for now.
1164
1165         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1166         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1167         * Scripts/webkitpy/tool/commands/download.py:
1168         * Scripts/webkitpy/tool/commands/download_unittest.py:
1169         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1170         * Scripts/webkitpy/tool/steps/__init__.py:
1171         * Scripts/webkitpy/tool/steps/commit.py:
1172         * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py: Removed.
1173         * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
1174
1175 2011-09-12  Eric Seidel  <eric@webkit.org>
1176
1177         [NRWT] REGRESSION: Local loader tests are failing on machines that lost /tmp/LayoutTests symlink
1178         https://bugs.webkit.org/show_bug.cgi?id=65781
1179
1180         Reviewed by Ryosuke Niwa.
1181
1182         Instead of making NRWT create the symlink, I just made DumpRenderTree smart enough
1183         to resolve the passed in url relative to the absolute url for the test.
1184
1185         I believe this is a better approach than the on used in the Qt and Chromium DRT's
1186         (which resolves the path relative to the built location of the DRT executable)
1187         and we should move this new code into a shared location in a follow-up patch.
1188
1189         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1190         (LayoutTestController::pathToLocalResource):
1191
1192 2011-09-12  Eric Seidel  <eric@webkit.org>
1193
1194         Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately
1195         https://bugs.webkit.org/show_bug.cgi?id=67530
1196
1197         Reviewed by Adam Barth.
1198
1199         I believe I've fixed the bug in the original patch which prompted the rollout.
1200         The previous patch was using the wrong deadline for the initial read,
1201         subtracting time.time() twice from the deadline value.
1202
1203         * Scripts/webkitpy/layout_tests/port/webkit.py:
1204         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1205
1206 2011-09-12  Balazs Kelemen  <kbalazs@webkit.org>
1207
1208         [Qt][WK2] WebKitTestRunner does not produce crash logs
1209         https://bugs.webkit.org/show_bug.cgi?id=67714
1210
1211         Reviewed by Chang Shu.
1212
1213         Added a simple way of generating backtrace on crash
1214         to the web process. The implementation is similar what
1215         we have in DRT. It depends on GNU libc functionality
1216         so it is only enabled where we are running in such an environment.
1217
1218         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
1219         (WTR::printBacktrace):
1220         (WTR::crashHandler):
1221         (WTR::InjectedBundle::platformInitialize):
1222
1223 2011-09-11  Filip Pizlo  <fpizlo@apple.com>
1224
1225         Added my IRC nick to the committers file.
1226
1227         * Scripts/webkitpy/common/config/committers.py:
1228
1229 2011-09-01  Filip Pizlo  <fpizlo@apple.com>
1230
1231         The executable allocator makes it difficult to free individual
1232         chunks of executable memory
1233         https://bugs.webkit.org/show_bug.cgi?id=66363
1234
1235         Reviewed by Oliver Hunt.
1236         
1237         Introduced a best-fit, balanced-tree based allocator. The allocator
1238         required a balanced tree that does not allocate memory and that
1239         permits the removal of individual nodes directly (as opposed to by
1240         key); neither AVLTree nor WebCore's PODRedBlackTree supported this.
1241         Changed all references to executable code to use a reference counted
1242         handle.
1243
1244         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1245         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp: Added.
1246         (TestWebKitAPI::TEST_F):
1247         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp: Added.
1248         (TestWebKitAPI::Pair::findExact):
1249         (TestWebKitAPI::Pair::remove):
1250         (TestWebKitAPI::Pair::findLeastGreaterThanOrEqual):
1251         (TestWebKitAPI::Pair::assertFoundAndRemove):
1252         (TestWebKitAPI::Pair::assertEqual):
1253         (TestWebKitAPI::Pair::assertSameValuesForKey):
1254         (TestWebKitAPI::Pair::testDriver):
1255         (TestWebKitAPI::TEST_F):
1256
1257 2011-09-10  Andy Estes  <aestes@apple.com>
1258
1259         Move myself from committers_unable_to_review to reviewers_list.
1260
1261         * Scripts/webkitpy/common/config/committers.py:
1262
1263 2011-09-10  Kevin Ollivier  <kevino@theolliviers.com>
1264
1265         [wx] Unreviewed build fix. MSW build fixes.
1266
1267         * DumpRenderTree/config.h:
1268         * waf/build/wxpresets.py:
1269
1270 2011-09-10  Andreas Kling  <kling@webkit.org>
1271
1272         Crash beneath WKURLIsEqual() when reloading in MiniBrowser.
1273         https://bugs.webkit.org/show_bug.cgi?id=59328
1274
1275         Reviewed by Kenneth Rohde Christiansen.
1276
1277         * MiniBrowser/mac/BrowserWindowController.m:
1278         (-[BrowserWindowController updateProvisionalURLForFrame:]): Add missing null check.
1279
1280 2011-09-10  Adam Barth  <abarth@webkit.org>
1281
1282         Build fix for Android.  DumpRenderTree is a client of the WebKit API
1283         and does not have access to notImplemented().
1284
1285         * DumpRenderTree/chromium/TestShellAndroid.cpp:
1286         (openStartupDialog):
1287
1288 2011-09-09  Alexey Proskuryakov  <ap@apple.com>
1289
1290         Add a script to create a monolithic script-test
1291         https://bugs.webkit.org/show_bug.cgi?id=67747
1292
1293         Reviewed by Darin Adler.
1294
1295         * Scripts/make-new-script-test: Added.
1296
1297 2011-09-09  Luiz Agostini  <luiz@webkit.org>
1298
1299         Adding myself to the reviewers list.
1300
1301         * Scripts/webkitpy/common/config/committers.py:
1302
1303 2011-09-09  Ryosuke Niwa  <rniwa@webkit.org>
1304
1305         Buildbot may use RunWebKitTest's evaluateCommand on bots that run nrwt
1306         https://bugs.webkit.org/show_bug.cgi?id=67855
1307
1308         Reviewed by Dirk Pranke.
1309
1310         The bug was caused by the fact some ports use RunWebKitTests instead of NewRunWebKitTests to run tests,
1311         and using RunWebKitTests.evaluateCommand after calling _parseNewRunWebKitTestsOutput.
1312
1313         Fixed the bug by merging evaluateCommand of RunWebKitTests and NewRunWebKitTests.
1314
1315         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1316
1317 2011-09-09  Mark Hahnenberg  <mhahnenberg@apple.com>
1318
1319         Add myself to committers.py
1320         https://bugs.webkit.org/show_bug.cgi?id=67853
1321
1322         Reviewed by Darin Adler.
1323
1324         * Scripts/webkitpy/common/config/committers.py:
1325
1326 2011-09-09  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1327
1328         [Qt] Remove common.pri
1329         https://bugs.webkit.org/show_bug.cgi?id=67814
1330
1331         Reviewed by Andreas Kling.
1332
1333         * Tools.pro:
1334
1335 2011-09-09  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
1336
1337         [NRWT] the nrwt check httpd with --no-http option
1338         https://bugs.webkit.org/show_bug.cgi?id=67835
1339
1340         Reviewed by Tony Chang.
1341
1342         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1343         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1344
1345 2011-09-09  Hao Zheng  <zhenghao@chromium.org>
1346
1347         [chromium] Implement DRT support for Android.
1348         https://bugs.webkit.org/show_bug.cgi?id=67590
1349
1350         Reviewed by Tony Chang.
1351
1352         Add 2 mechanism to make DRT interaction more robust on Android:
1353         - Send 'QUIT' to DRT to make it stop.
1354         - Wait until receiving '#READY' from DRT, so that DRT won't miss any
1355         input commands before it starts.
1356         And LayoutTestController.cpp needs to include <cctype> for 'tolower'
1357         and <clocale> for 'LC_ALL' to compile on Android.
1358
1359         Also change to use sigaction instead of signal for TestShellGtk.cpp,
1360         as signal() man page recommends using sigaction().
1361
1362         * DumpRenderTree/DumpRenderTree.gypi:
1363         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1364         (main):
1365         * DumpRenderTree/chromium/LayoutTestController.cpp:
1366         * DumpRenderTree/chromium/TestShellAndroid.cpp: Added.
1367         (AlarmHandler):
1368         (TestShell::waitTestFinished):
1369         (platformInit):
1370         (openStartupDialog):
1371         (checkLayoutTestSystemDependencies):
1372         * DumpRenderTree/chromium/TestShellGtk.cpp:
1373         (AlarmHandler):
1374         (TestShell::waitTestFinished):
1375
1376 2011-09-09  Kevin Ollivier  <kevino@theolliviers.com>
1377
1378         [wx] Unreviewed build fix. Add Source/JavaScriptCore/dfg directory to the build.
1379
1380         * waf/build/settings.py:
1381
1382 2011-09-09  Sheriff Bot  <webkit.review.bot@gmail.com>
1383
1384         Unreviewed, rolling out r94851.
1385         http://trac.webkit.org/changeset/94851
1386         https://bugs.webkit.org/show_bug.cgi?id=67847
1387
1388         It broke a webkitpy test (Requested by ossy on #webkit).
1389
1390         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1391
1392 2011-09-09  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
1393
1394         [NRWT] the nrwt check httpd with --no-http option
1395         https://bugs.webkit.org/show_bug.cgi?id=67835
1396
1397         Reviewed by Csaba Osztrogonác.
1398
1399         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1400
1401 2011-09-08  Brian Weinstein  <bweinstein@apple.com>
1402
1403         WebKit2: Assertion when calling didPerform*Redirect on null source/destination URL string
1404         https://bugs.webkit.org/show_bug.cgi?id=67794
1405         <rdar://problem/9892024>
1406         
1407         Add a test that we don't send a didPerformServerRedirect when a load is cancelled from willSendRequest.
1408
1409         Reviewed by Brady Eidson.
1410
1411         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp: Added.
1412         (TestWebKitAPI::didFinishLoadForFrame): Set flags on whether we've loaded the main frame, iframe, or both.
1413         (TestWebKitAPI::didPerformServerRedirect): Set a flag for whether we've performed a server redirect.
1414         (TestWebKitAPI::TEST): Set up a WKPageLoaderClient and WKContextHistoryClient, and load simple-iframe.html.
1415             Once both frames have loaded (main frame and blocked iframe), make sure that we have never called
1416             didPerformServerRedirect.
1417
1418         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp: Added.
1419         (TestWebKitAPI::LoadCanceledNoServerRedirectCallbackTest::LoadCanceledNoServerRedirectCallbackTest): Initialize
1420             our InjectedBundleTest.
1421         (TestWebKitAPI::LoadCanceledNoServerRedirectCallbackTest::willSendRequestForFrame): If we are dealing with a request
1422             from the main frame (the main resource in simple-iframe.html), allow it. If not (dealing with the iframe), block
1423             the request.
1424         (TestWebKitAPI::LoadCanceledNoServerRedirectCallbackTest::didCreatePage): Set up the WKBundlePageResourceLoadClient.
1425
1426         * TestWebKitAPI/Tests/WebKit2/simple-iframe.html: Added.
1427         
1428         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
1429         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Ditto.
1430         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj: Ditto.
1431         * TestWebKitAPI/win/copy-resources.cmd: Ditto.
1432
1433 2011-09-08  David Levin  <levin@chromium.org>
1434
1435         check-webkit-style: Ref|Own Ptr& should be allowed as a parameter.
1436         https://bugs.webkit.org/show_bug.cgi?id=67797
1437
1438         Reviewed by Eric Seidel.
1439
1440         * Scripts/webkitpy/style/checkers/cpp.py: Allow Ref/Own Ptr when it ends with &.
1441         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added test cases for this.
1442
1443 2011-09-08  Fady Samuel  <fsamuel@chromium.org>
1444
1445         Fixed Layout Mode should be adjustable from layoutTestController for testing on Chromium platforms
1446         https://bugs.webkit.org/show_bug.cgi?id=67723
1447
1448         Reviewed by Adam Barth.
1449
1450         * DumpRenderTree/chromium/EventSender.h:
1451         * DumpRenderTree/chromium/LayoutTestController.cpp:
1452         (LayoutTestController::LayoutTestController):
1453         (LayoutTestController::enableFixedLayoutMode):
1454         (LayoutTestController::setFixedLayoutSize):
1455         * DumpRenderTree/chromium/LayoutTestController.h:
1456
1457 2011-09-07  Matthew Delaney  <mdelaney@apple.com>
1458
1459         Add standalone script that filters the output of build-webkit to be more human-readable
1460         https://bugs.webkit.org/show_bug.cgi?id=44081
1461
1462         Reviewed by Daniel Bates.
1463
1464         * Scripts/filter-build-webkit: Added. Just need to feed it the output of
1465         a build script (e.g. build-webkit) and it spits out a prettier version.
1466         * Scripts/VCSUtils.pm: Refactored "possiblyColored" out of run-api-tests into VCSUtils.
1467         * Scripts/run-api-tests: Now includes VCSUtils to use "possiblyColored"
1468
1469 2011-09-07  Noel Gordon  <noel.gordon@gmail.com>
1470
1471         Add myself to committers.py                 
1472         https://bugs.webkit.org/show_bug.cgi?id=67696
1473
1474         Reviewed by Kent Tamura.
1475
1476         * Scripts/webkitpy/common/config/committers.py:
1477
1478 2011-09-07  Adam Barth  <abarth@webkit.org>
1479
1480         rebaseline button in garden-o-matic details view should work
1481         https://bugs.webkit.org/show_bug.cgi?id=67738
1482
1483         Reviewed by Dimitri Glazkov.
1484
1485         This patch wires up the rebaseline button in garden-o-matic results
1486         details view.  The button is current per-test, so there isn't a way to
1487         rebaseline individual bots.  This is a place to start.  If we decide we
1488         want per-bot rebaselining, we'll need to think of some better UI.
1489
1490         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1491         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
1492         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1493         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
1494
1495 2011-09-07  Eric Seidel  <eric@webkit.org>
1496
1497         Teach the PortFactory object how to pass along executive/user/filesystem to port objects (which fixes the failing rebaseline_test on bots)
1498         https://bugs.webkit.org/show_bug.cgi?id=67737
1499
1500         Reviewed by Adam Barth.
1501
1502         I got a little over-eager when deprecating host.port_factory in the previous commit.
1503         Turns out that Host.port_factory was already the "modern" port/factory.py
1504         it was just the Module object.  I un-deprecated the variable, and changed it from
1505         being the module to being an actual PortFactory, passing it a host object.
1506         I also taught PortFactory how to set user/executive/filesystem in the kwargs
1507         when instantiating a new Port object.
1508         This magically fixed the test_rebaseline test, since its now no longer talking
1509         to the real filesystem.
1510
1511         * Scripts/webkitpy/common/host.py:
1512         * Scripts/webkitpy/layout_tests/port/factory.py:
1513         * Scripts/webkitpy/tool/commands/queries.py:
1514         * Scripts/webkitpy/tool/mocktool.py:
1515
1516 2011-09-07  Eric Seidel  <eric@webkit.org>
1517
1518         Add a new PortFactory class for creating new-style ports and deprecate the old PortFactory
1519         https://bugs.webkit.org/show_bug.cgi?id=67734
1520
1521         Reviewed by Adam Barth.
1522
1523         Right now every place that creates a Port object has to be very careful
1524         to pass in a MockSCM/MockUser/MockFilesystem when appropriate.
1525         The correct fix is for port/factory.py (which creates most port objects)
1526         to know how to pass these in automatically.  However, currently all port/factory.py
1527         functions are free functions instead of being on an object.  This patch
1528         adds a new PortFactory object and deprecates the PortFactory for the old-style Port objects.
1529
1530         In a follow-up patch I will add PortFactory to the Host object and teach PortFactory how to
1531         pass along the proper scm/user/filesystem to the Port object.
1532
1533         * Scripts/webkitpy/common/host.py:
1534         * Scripts/webkitpy/layout_tests/port/factory.py:
1535         * Scripts/webkitpy/tool/commands/queries.py:
1536         * Scripts/webkitpy/tool/mocktool.py:
1537
1538 2011-09-07  Sheriff Bot  <webkit.review.bot@gmail.com>
1539
1540         Unreviewed, rolling out r94441.
1541         http://trac.webkit.org/changeset/94441
1542         https://bugs.webkit.org/show_bug.cgi?id=67731
1543
1544         "MacEWSes are backed up due to new machines not able to reach
1545         git.webkit.org.  Disabling tests for now" (Requested by
1546         eseidel2 on #webkit).
1547
1548         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1549
1550 2011-09-07  Elliot Poger  <epoger@google.com>
1551
1552         filter test_expectations properly for chromium-mac vs chromium-cg-mac
1553         https://bugs.webkit.org/show_bug.cgi?id=67324
1554
1555         Reviewed by Dirk Pranke.
1556
1557         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1558         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1559         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1560         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1561         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1562
1563 2011-09-07  Eric Boren  <borenet@gmail.com>
1564
1565         [Chromium] Modify WebTouchEvent structure to match WebCore::TouchEvent
1566         https://bugs.webkit.org/show_bug.cgi?id=66800
1567
1568         Reviewed by Darin Fisher.
1569
1570         * DumpRenderTree/chromium/EventSender.cpp:
1571         (EventSender::sendCurrentTouchEvent):
1572
1573 2011-09-07  Jarred Nicholls  <jarred@sencha.com>
1574
1575         [Qt][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
1576         https://bugs.webkit.org/show_bug.cgi?id=67254
1577
1578         Reviewed by Csaba Osztrogonác.
1579
1580         Translate file:///tmp/LayoutTests/* urls into the repository LayoutTests directory, which is
1581         derived from the running location of DumpRenderTree binary.
1582
1583         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1584         (LayoutTestController::pathToLocalResource):
1585         (LayoutTestController::setUserStyleSheetLocation): pass the url through pathToLocalResource
1586
1587 2011-09-07  Csaba Osztrogonác  <ossy@webkit.org>
1588
1589         REGRESSION(r94288) build-webkit doesn't work on Symbian
1590         https://bugs.webkit.org/show_bug.cgi?id=67706
1591
1592         * Scripts/webkitdirs.pm: Disable automatic clean build on Symbian, because it doesn't support shadow build.
1593         (buildQMakeProject):
1594
1595 2011-09-07  Csaba Osztrogonác  <ossy@webkit.org>
1596
1597         REGRESSION(r94288) build-webkit doesn't work on Windows
1598         https://bugs.webkit.org/show_bug.cgi?id=67646
1599
1600         Roll back r94655 with a small fix.
1601
1602         * Scripts/webkitdirs.pm:
1603         (buildQMakeProject):
1604
1605 2011-09-07  Sheriff Bot  <webkit.review.bot@gmail.com>
1606
1607         Unreviewed, rolling out r94635.
1608         http://trac.webkit.org/changeset/94635
1609         https://bugs.webkit.org/show_bug.cgi?id=67704
1610
1611         Linux Touch build is failing to compile this change.
1612         (Requested by loislo on #webkit).
1613
1614         * DumpRenderTree/chromium/EventSender.cpp:
1615         (EventSender::sendCurrentTouchEvent):
1616
1617 2011-09-07  Sheriff Bot  <webkit.review.bot@gmail.com>
1618
1619         Unreviewed, rolling out r94655.
1620         http://trac.webkit.org/changeset/94655
1621         https://bugs.webkit.org/show_bug.cgi?id=67703
1622
1623         It broke Leopard debug bot (Requested by ossy on #webkit).
1624
1625         * Scripts/webkitdirs.pm:
1626
1627 2011-09-07  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
1628
1629         REGRESSION(r94288) build-webkit doesn't work on Windows
1630         https://bugs.webkit.org/show_bug.cgi?id=67646
1631
1632         Reviewed by Csaba Osztrogonác.
1633
1634         * Scripts/webkitdirs.pm:
1635
1636 2011-09-06  Eric Boren  <borenet@gmail.com>
1637
1638         [Chromium] Modify WebTouchEvent structure to match WebCore::TouchEvent
1639         https://bugs.webkit.org/show_bug.cgi?id=66800
1640
1641         Reviewed by Darin Fisher.
1642
1643         * DumpRenderTree/chromium/EventSender.cpp:
1644         (EventSender::sendCurrentTouchEvent):
1645
1646 2011-09-06  Adam Barth  <abarth@webkit.org>
1647
1648         garden-o-matic details view should having working rebaseline and next/previous buttons
1649         https://bugs.webkit.org/show_bug.cgi?id=67659
1650
1651         Reviewed by Dimitri Glazkov.
1652
1653         This patch wires up basic back/forward buttons that let you traverse
1654         through the results we're examining in the details view.  This ended up
1655         being more code than I expected, but I wanted to keep all the state
1656         information in the DOM itself.
1657
1658         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1659         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
1660         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
1661
1662 2011-09-01  Dirk Pranke  <dpranke@chromium.org>
1663
1664         fix MockFileSystem.glob(), refactor filesystem tests
1665         https://bugs.webkit.org/show_bug.cgi?id=67462
1666
1667         Reviewed by Eric Seidel.
1668
1669         In debugging why my proposed change for MockFileSystem.glob()
1670         in bug 66228 didn't work, I stumbled across two real bugs
1671         that cancelled each other out for the unit tests. I fixed those
1672         (glob shouldn't recurse into subdirs, and we weren't populating
1673         self.dirs from self.files properly).
1674
1675         I have also created a "mixin" class for tests that can be shared
1676         between the real filesystem and the mock filesystem - MockFileSystem
1677         is being used enough it needs its own tests.
1678
1679         * Scripts/webkitpy/common/system/filesystem_mock.py:
1680         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py: Added.
1681         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1682
1683 2011-09-06  Anders Carlsson  <andersca@apple.com>
1684
1685         Move NPAPI headers in bridge to plugins
1686         https://bugs.webkit.org/show_bug.cgi?id=67661
1687
1688         Update forwarding headers.
1689
1690         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h:
1691         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h:
1692
1693 2011-09-06  Tony Chang  <tony@chromium.org>
1694
1695         [chromium] Check in 'build' for compiled binaries first
1696         https://bugs.webkit.org/show_bug.cgi?id=67549
1697
1698         Reviewed by Dirk Pranke.
1699
1700         I'm working on moving the windows build output to a common location
1701         rather than relative to the sln file.  Because of that, we need to
1702         check those build locations first for DumpRenderTree.exe.
1703
1704         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1705
1706 2011-09-06  Adam Barth  <abarth@webkit.org>
1707
1708         Use a hierarchial structure for the garden-o-matic results view
1709         https://bugs.webkit.org/show_bug.cgi?id=67620
1710
1711         Reviewed by Dimitri Glazkov.
1712
1713         This patch re-organizes the results view to use a hierachial structure
1714         for selection.  At the top-level are sections for each test.  Expanding
1715         the test section shows a tab selector for builders.
1716
1717         This structure prepares us for wiring up various actions to this view.
1718
1719         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1720         (.):
1721         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
1722         ():
1723         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1724         (.):
1725         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
1726         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
1727         (.results-view>.toolbar):
1728         (.results-view>.toolbar ul.actions):
1729         (.results-view>.toolbar ul.actions li):
1730         (.results-grid table):
1731         (.results-grid table td, .results-view table th):
1732         (.results-grid table th):
1733         (.results-grid .text-result):
1734         (.results-grid .image-result):
1735
1736 2011-09-06  Adam Barth  <abarth@webkit.org>
1737
1738         garden-o-matic's base.probe generates spam in the JavaScript console
1739         https://bugs.webkit.org/show_bug.cgi?id=67622
1740
1741         Reviewed by Dimitri Glazkov.
1742
1743         Now that we have CORS set up on the buildbot, we can use XMLHttpRequest
1744         instead of HTMLScriptElement to test whether results exist.  This
1745         reduces the console.log spam and saves bandwidth because we can use a
1746         HEAD request instead of a GET request.
1747
1748         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js:
1749
1750 2011-09-05  Adam Barth  <abarth@webkit.org>
1751
1752         Add a tab to garden-o-matic for viewing expected failures
1753         https://bugs.webkit.org/show_bug.cgi?id=67619
1754
1755         Reviewed by Dimitri Glazkov.
1756
1757         This patch adds a basic tab to garden-o-matic that shows all the tests
1758         failing on the bots, including the expected failures.  This patch
1759         mostly involves refactoring existing classes to allow new subclasses.
1760
1761         This view is useful for when gardeners mark tests as expected to fail
1762         and then rebaseline them later.
1763
1764         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1765         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
1766         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
1767         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js:
1768         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1769         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
1770         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
1771
1772 2011-09-05  Adam Barth  <abarth@webkit.org>
1773
1774         Fix global variable leak in garden-o-matic
1775         https://bugs.webkit.org/show_bug.cgi?id=67617
1776
1777         Reviewed by Dimitri Glazkov.
1778
1779         Caught by running the unit tests with noglobals turned on.
1780
1781         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1782
1783 2011-09-05  Balazs Kelemen  <kbalazs@webkit.org>
1784
1785         [Qt][WK2] Add pixel test support
1786         https://bugs.webkit.org/show_bug.cgi?id=66283
1787
1788         Reviewed by Andreas Kling.
1789
1790         Implemented pixel result generation by reusing the logic
1791         that we have in DumpRenderTree.
1792         * WebKitTestRunner/qt/TestInvocationQt.cpp:
1793         (WTR::dumpImage):
1794         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1795
1796 2011-09-04  Robin Dunn  <robin@alldunn.com>
1797
1798         [wx] Enable wxWebKit to run using the wxGC Cairo backend on platforms other than GTK.
1799         https://bugs.webkit.org/show_bug.cgi?id=67577
1800
1801         Reviewed by Kevin Ollivier.
1802
1803         * waf/build/settings.py:
1804
1805 2011-09-03  Kevin Ollivier  <kevino@theolliviers.com>
1806
1807         [wx] Unreviewed build fix. Add wtf/dtoa directory to build.
1808
1809         * waf/build/settings.py:
1810
1811 2011-09-03  Dan Bernstein  <mitz@apple.com>
1812
1813         32-bit build fix.
1814
1815         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
1816         (TestWebKitAPI::Util::toSTD):
1817
1818 2011-09-03  Dan Bernstein  <mitz@apple.com>
1819
1820         Move testStringByEvaluatingJavaScriptFromString() from DumpRenderTree to TestWebKitAPI
1821         https://bugs.webkit.org/show_bug.cgi?id=67559
1822
1823         Reviewed by Darin Adler.
1824
1825         * DumpRenderTree/mac/DumpRenderTree.mm:
1826         (dumpRenderTree): Moved testStringByEvaluatingJavaScriptFromString() from here and removed
1827         the call to it.
1828         * TestWebKitAPI/PlatformUtilities.h: Declared Util::toSTD(NSString *)
1829         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added StringByEvaluatingJavaScriptFromString.mm.
1830         * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm: Added.
1831         (TestWebKitAPI::TEST): Added. Moved testStringByEvaluatingJavaScriptFromString() to here.
1832         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
1833         (TestWebKitAPI::Util::toSTD): Added.
1834
1835 2011-09-03  Adam Barth  <abarth@webkit.org>
1836
1837         garden-o-matic results view should have a better results selector
1838         https://bugs.webkit.org/show_bug.cgi?id=67542
1839
1840         Reviewed by Dimitri Glazkov.
1841
1842         This patch adds a basic grid-based results selector to the results
1843         view.  Currently, this grid just shows how the tests fail on the
1844         various bots.  A future patch will let you select which failure to view
1845         and to mark the failures for rebaselining.
1846
1847         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
1848         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
1849           - Add some more basic functions for manipulating dictionaries.
1850         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1851         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1852         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
1853
1854 2011-09-03  Adam Barth  <abarth@webkit.org>
1855
1856         garden-o-matic results view should show Actual and Expected results for text failures
1857         https://bugs.webkit.org/show_bug.cgi?id=67536
1858
1859         Reviewed by Eric Seidel.
1860
1861         In the past, we didn't show actual and expected text results (we just
1862         showed the diff) because we didn't have the awesome six-by-two results
1863         grid.  Now that we do, we can move show these results.
1864
1865         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
1866         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
1867           - Fixed some typos that were preventing these unit tests from running.
1868         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
1869         (.):
1870         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
1871           - Report -actual.txt and -expected.txt as possible results URLs.
1872
1873 2011-09-03  Adam Barth  <abarth@webkit.org>
1874
1875         garden-o-matic shows "ghost" failures that are already fixed
1876         https://bugs.webkit.org/show_bug.cgi?id=67535
1877
1878         Reviewed by Eric Seidel.
1879
1880         About 10% of writes fail to stick on test-results.appspot.com.  This
1881         patch causes us to fetch the full_results.json blob directly from
1882         build.chromium.org rather than relying upon AppEngine.
1883
1884         Unforuntately, we still need to get historical information from
1885         AppEngine.  That will take several patches to fix becuase I need to
1886         change the bots to write the full_results.json file to the
1887         build-specific directory in addition to the zip file.
1888
1889         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
1890         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
1891         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
1892
1893 2011-09-03  Sheriff Bot  <webkit.review.bot@gmail.com>
1894
1895         Unreviewed, rolling out r94458.
1896         http://trac.webkit.org/changeset/94458
1897         https://bugs.webkit.org/show_bug.cgi?id=67558
1898
1899         Caused appcache test to fail on various bots (Requested by
1900         rniwa on #webkit).
1901
1902         * Scripts/webkitpy/layout_tests/port/webkit.py:
1903         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1904
1905 2011-09-03  Sheriff Bot  <webkit.review.bot@gmail.com>
1906
1907         Unreviewed, rolling out r94453.
1908         http://trac.webkit.org/changeset/94453
1909         https://bugs.webkit.org/show_bug.cgi?id=67557
1910
1911         Caused appcache test to fail on various bots (Requested by
1912         rniwa on #webkit).
1913
1914         * Scripts/webkitpy/layout_tests/port/webkit.py:
1915
1916 2011-09-02  Michael Saboff  <msaboff@apple.com>
1917
1918         Add JSC:RegExp functional tests
1919         https://bugs.webkit.org/show_bug.cgi?id=67339
1920
1921         New perl script to build JavaScriptCore and run the RegExp tests.
1922
1923         Reviewed by Gavin Barraclough.
1924
1925         * Scripts/run-regexp-tests: Added.
1926
1927 2011-09-02  Michael Saboff  <msaboff@apple.com>
1928
1929         Add JSC:RegExp functional tests
1930         https://bugs.webkit.org/show_bug.cgi?id=67339
1931
1932         New perl script to build JavaScriptCore and run the RegExp tests.
1933
1934         Reviewed by Gavin Barraclough.
1935
1936         * Scripts/run-regexp-tests: Added.
1937
1938 2011-09-02  Eric Seidel  <eric@webkit.org>
1939
1940         Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately
1941         https://bugs.webkit.org/show_bug.cgi?id=67530
1942
1943         Unreviewed.  Fixing typo from previous commit.
1944
1945         Turns out there was *no* unittesting of WebKitDriver.  Added a basic test of _read_block
1946         which exercises the code I previously made a typo in.
1947
1948         * Scripts/webkitpy/layout_tests/port/webkit.py:
1949         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1950
1951 2011-09-02  Eric Seidel  <eric@webkit.org>
1952
1953         Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately
1954         https://bugs.webkit.org/show_bug.cgi?id=67530
1955
1956         Reviewed by Adam Barth.
1957
1958         No functional change, just reshuffling code.
1959
1960         * Scripts/webkitpy/layout_tests/port/webkit.py:
1961
1962 2011-09-02  Darin Adler  <darin@apple.com>
1963
1964         Added Subversion ignore for .pyc generated files.
1965
1966         * Scripts/webkitpy/layout_tests/models: Added property svn:ignore.
1967         * Scripts/webkitpy/layout_tests/servers: Added property svn:ignore.
1968         * Scripts/webkitpy/tool/servers: Added property svn:ignore.
1969
1970 2011-09-02  Adam Barth  <abarth@webkit.org>
1971
1972         Enable testing on mac-ews
1973         https://bugs.webkit.org/show_bug.cgi?id=67505
1974
1975         Reviewed by Eric Seidel.
1976
1977         This patch enables testing on the Mac EWS, which should help
1978         contributors not turn the Mac bots red.
1979
1980         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1981
1982 2011-09-01  Beth Dakin  <bdakin@apple.com>
1983
1984         https://bugs.webkit.org/show_bug.cgi?id=67451
1985         Add a test for going back to a cached page after changing the device scale factor
1986
1987         Reviewed by Adam Roben.
1988
1989         New test DeviceScaleFactorOnBack.mm inherits from WebKitAgnosticTest.
1990         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1991         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm: Added.
1992         (TestWebKitAPI::DeviceScaleFactorOnBack::url):
1993         (TestWebKitAPI::DeviceScaleFactorOnBack::didLoadURL):
1994         (TestWebKitAPI::DeviceScaleFactorOnBack::createWindow):
1995         (TestWebKitAPI::DeviceScaleFactorOnBack::initializeView):
1996         (TestWebKitAPI::DeviceScaleFactorOnBack::runTest):
1997         (TestWebKitAPI::TEST_F):
1998
1999         Added new function to WebKitAgnosticTest to goBack. Separated 
2000         waitForLoadToFinish() into its own function (instead of being a part of 
2001         loadAndWaitUntilFinished()) so that it can be called from goBack as 
2002         well. Also added initializeView() so we can set the cache model.
2003         * TestWebKitAPI/mac/WebKitAgnosticTest.h:
2004         (TestWebKitAPI::WebKitAgnosticTest::initializeView):
2005         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
2006         (TestWebKitAPI::WebKitAgnosticTest::WebKitAgnosticTest):
2007         (TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test):
2008         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
2009         (TestWebKitAPI::WebKitAgnosticTest::loadURL):
2010         (TestWebKitAPI::WebKitAgnosticTest::goBack):
2011         (TestWebKitAPI::WebKitAgnosticTest::waitForLoadToFinish):
2012
2013 2011-09-02  Anders Carlsson  <andersca@apple.com>
2014
2015         Build fix.
2016
2017         * DumpRenderTree/TestNetscapePlugIn/Tests/PrivateBrowsing.cpp:
2018         (PrivateBrowsing::ScriptableObject::pluginTest):
2019
2020 2011-09-02  Anders Carlsson  <andersca@apple.com>
2021
2022         Move private browsing test to a PluginTest subclass
2023         https://bugs.webkit.org/show_bug.cgi?id=67498
2024
2025         Reviewed by Darin Adler.
2026
2027         * DumpRenderTree/DumpRenderTree.gypi:
2028         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2029         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2030         (pluginGetProperty):
2031         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
2032         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2033         (PluginTest::NPP_SetValue):
2034         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2035         * DumpRenderTree/TestNetscapePlugIn/Tests/PrivateBrowsing.cpp: Added.
2036         (PrivateBrowsing::PrivateBrowsing):
2037         (PrivateBrowsing::privateBrowsingEnabled):
2038         (PrivateBrowsing::cachedPrivateBrowsingEnabled):
2039         (PrivateBrowsing::ScriptableObject::hasProperty):
2040         (PrivateBrowsing::ScriptableObject::getProperty):
2041         (PrivateBrowsing::ScriptableObject::pluginTest):
2042         (PrivateBrowsing::NPP_New):
2043         (PrivateBrowsing::NPP_GetValue):
2044         (PrivateBrowsing::NPP_SetValue):
2045         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2046         (NPP_New):
2047         (NPP_SetValue):
2048         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2049         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2050         * GNUmakefile.am:
2051
2052 2011-09-02  Csaba Osztrogonác  <ossy@webkit.org>
2053
2054         [Qt] Build dependency problems
2055         https://bugs.webkit.org/show_bug.cgi?id=38054
2056
2057         Trivial fix after r94288.
2058
2059         Rubber-stamped by Andras Becsi.
2060
2061         * Scripts/webkitdirs.pm: We should read the whole defaults.txt, not only the first two lines.
2062         (buildQMakeProject):
2063
2064 2011-09-02  Andras Becsi  <andras.becsi@nokia.com>
2065
2066         Remove my old e-mail address and add my new one.
2067
2068         Rubber-stamped by Tor Arne Vestbø.
2069
2070         * Scripts/webkitpy/common/config/committers.py:
2071
2072 2011-09-02  Philippe Normand  <pnormand@igalia.com>
2073
2074         [GTK] run-gtk-tests leaves a zombie Xvfb process
2075         https://bugs.webkit.org/show_bug.cgi?id=67389
2076
2077         Reviewed by Martin Robinson.
2078
2079         * Scripts/run-gtk-tests: Properly close STDIN and STDERR on the
2080         child process instead of doing shell redirection.
2081
2082 2011-09-01  Mark Rowe  <mrowe@apple.com>
2083
2084         Fix the build by adding some more missing return types.
2085
2086         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2087         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
2088
2089 2011-09-01  Eric Seidel  <eric@webkit.org>
2090
2091         REGRESSION (NRWT): Leaks Viewer can't load leaks from test runs that used NRWT
2092         https://bugs.webkit.org/show_bug.cgi?id=66228
2093
2094         Reviewed by Dirk Pranke.
2095
2096         ORWT used $(PROCESS)$(NUMBER)-leaks.txt for leaks filenames.
2097         The LeaksViewer tool globs for all *-leaks.txt files.
2098         This patch makes NRWT output $(PROCESS)-$(PID)-leaks.txt which should match.
2099
2100         In order to test this I had to fix a limitation in our MockFileSystem.glob
2101         method.  However, doing so uncovered a typo and bug in the integration tests.
2102         I've disabled the offending integration tests.
2103
2104         * Scripts/webkitpy/common/system/filesystem_mock.py:
2105         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
2106         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
2107
2108 2011-09-01  Dominic Mazzoni  <dmazzoni@google.com>
2109
2110         Adds a LayoutTestController method to make it possible to test
2111         starting speech input via an API call.
2112         https://bugs.webkit.org/show_bug.cgi?id=60170
2113
2114         Reviewed by Dimitri Glazkov.
2115
2116         * DumpRenderTree/LayoutTestController.h:
2117         * DumpRenderTree/chromium/LayoutTestController.cpp:
2118         (LayoutTestController::LayoutTestController):
2119         (LayoutTestController::startSpeechInput):
2120         * DumpRenderTree/chromium/LayoutTestController.h:
2121         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2122         (LayoutTestController::startSpeechInput):
2123         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2124         (LayoutTestController::startSpeechInput):
2125         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2126         (LayoutTestController::startSpeechInput):
2127         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2128         (LayoutTestController::startSpeechInput):
2129         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2130         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2131         (LayoutTestController::startSpeechInput):
2132         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2133         (LayoutTestController::startSpeechInput):
2134
2135 2011-09-01  Tim Horton  <hortont424@gmail.com>
2136
2137         Fix TestWebKitAPI build on clang-2.0
2138
2139         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
2140
2141 2011-09-01  Adam Barth  <abarth@webkit.org>
2142
2143         Remove unused "extension" parameter from rebaseline gardeningserver handler
2144         https://bugs.webkit.org/show_bug.cgi?id=67384
2145
2146         Reviewed by James Robinson.
2147
2148         This parameter hasn't done anything in a while.
2149
2150         * Scripts/webkitpy/tool/commands/rebaseline.py:
2151         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2152         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2153
2154 2011-09-01  Eric Seidel  <eric@webkit.org>
2155
2156         Unreviewed.
2157
2158         Fix a typo in unittests.  Unfortunately fixing it
2159         caused several assertions.  Just disabling the test
2160         instead, since it was providing no value before due to the typo.
2161
2162         * Scripts/webkitpy/layout_tests/port/test.py:
2163
2164 2011-09-01  Adam Barth  <abarth@webkit.org>
2165
2166         Add a "rebaseline" button to the garden-o-matic summary page
2167         https://bugs.webkit.org/show_bug.cgi?id=67382
2168
2169         Reviewed by Dimitri Glazkov.
2170
2171         As much as we might wish folks to not rebaseline entire test groups at
2172         once, the truth is that doing so is a common operation.  Adding a
2173         button for this operation is likely to make folks happy.
2174
2175         This patch also cleans up a bunch of plumbing surrounding failureInfo
2176         objects.
2177
2178         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
2179         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
2180         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
2181         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
2182         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2183         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
2184         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
2185         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
2186         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
2187         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2188
2189 2011-09-01  Adam Barth  <abarth@webkit.org>
2190
2191         garden-o-matic should let the gardener assign blame for a group of test failures
2192         https://bugs.webkit.org/show_bug.cgi?id=67379
2193
2194         Reviewed by Dimitri Glazkov.
2195
2196         If a group of test failures has a large revision range, the gardener
2197         might wish to blame a specific revision for the failure.  Currently,
2198         this only effect of assigning blame in this way is to hide the other
2199         suspect commits.
2200
2201         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2202         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
2203         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
2204
2205 2011-09-01  Adam Barth  <abarth@webkit.org>
2206
2207         Hide garden-o-matic failure table until hover
2208         https://bugs.webkit.org/show_bug.cgi?id=67376
2209
2210         Reviewed by Dimitri Glazkov.
2211
2212         This patch removes the failure table for build failures (because it
2213         does not make sense) and hides the failure table for test groups until
2214         the user hovers over the test failure block, reducing visual noise.
2215
2216         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
2217         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2218         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
2219
2220 2011-09-01  Adam Barth  <abarth@webkit.org>
2221
2222         Switch garden-o-matic from commitData.title to commitData.summary
2223         https://bugs.webkit.org/show_bug.cgi?id=67375
2224
2225         Reviewed by Dimitri Glazkov.
2226
2227         commitData.title is a string provided by Trac, which isn't great in all
2228         cases.  commitData.summary is my attempt to find the most important
2229         one-line summary of the commit.  This patch switches garden-o-matic
2230         over to summary.
2231
2232         Also, this patch tweaks a bunch of CSS to tighten up the summary page
2233         and reduce visual noise.
2234
2235         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
2236         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2237         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
2238
2239 2011-09-01  Adam Barth  <abarth@webkit.org>
2240
2241         Group failing tests in garden-o-matic if there are more than three in a folder
2242         https://bugs.webkit.org/show_bug.cgi?id=67373
2243
2244         Reviewed by Dimitri Glazkov.
2245
2246         Sometimes a failure will cause many tests in a given directory to fail.
2247         When that happens, it's better to list the directory as a single item
2248         (with a count) rather than spamming all the test names.
2249
2250         (This patch also updates a bunch of unit test expected results after my last commit.)
2251
2252         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
2253         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
2254         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
2255         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
2256         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2257
2258 2011-09-01  Adam Barth  <abarth@webkit.org>
2259
2260         Lower the visual noise from the failing builders display
2261         https://bugs.webkit.org/show_bug.cgi?id=67369
2262
2263         Reviewed by Dimitri Glazkov.
2264
2265         This patch ensures that the "Building" row in the failing builders
2266         display is always last and dims it by 50% to reduce visual noise.  This
2267         lets the gardener focus on the actual failures.
2268
2269         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2270         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
2271         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css: Added.
2272
2273 2011-09-01  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
2274
2275         [Qt] Build dependency problems
2276         https://bugs.webkit.org/show_bug.cgi?id=38054
2277
2278         Make clean build after the defines are changed.
2279
2280         Reviewed by Csaba Osztrogonác.
2281
2282         * Scripts/webkitdirs.pm:
2283         (buildQMakeProject):
2284
2285 2011-08-31  Adam Barth  <abarth@webkit.org>
2286
2287         Move DumpRenderTree to WebKitPlatformSupport
2288         https://bugs.webkit.org/show_bug.cgi?id=67331
2289
2290         Reviewed by Darin Fisher.
2291
2292         This patch update DumpRenderTree to account for the WebKitClient =>
2293         WebKitPlatformSupport rename.
2294
2295         * DumpRenderTree/chromium/NotificationPresenter.cpp:
2296         (NotificationPresenter::show):
2297         * DumpRenderTree/chromium/Task.cpp:
2298         (postTask):
2299
2300 2011-08-31  Eric Seidel  <eric@webkit.org>
2301
2302         Add queues.webkit.org/active-bots page to make it easy to see which bots are down
2303         https://bugs.webkit.org/show_bug.cgi?id=67314
2304
2305         Reviewed by Adam Barth.
2306
2307         Very simple page.  Just lists all the bots, what queue they belong to and what we last heard from them.
2308         If we haven't heard from a bot in the last 500 messages (last day or so), then it won't show up here.
2309         This makes it very easy for me to see which of my cr-jail bots might be down at any one time.
2310
2311         I also moved a bunch of code into dashboard.css which belonged there.
2312
2313         * QueueStatusServer/handlers/activebots.py: Added.
2314         * QueueStatusServer/main.py:
2315         * QueueStatusServer/stylesheets/dashboard.css:
2316         (.queue_bubble):
2317         (.queue_name):
2318         (.last_heard_from):
2319         (.status_text):
2320         (.alive):
2321         (.behind):
2322         (.dead):
2323         * QueueStatusServer/templates/activebots.html: Added.
2324         * QueueStatusServer/templates/dashboard.html:
2325         * QueueStatusServer/templates/recentstatus.html:
2326
2327 2011-08-31  Oliver Hunt  <oliver@apple.com>
2328
2329         Move CheckedArithmeticOperations.cpp to the intended location
2330
2331         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2332         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp: Renamed from Tools/TestWebKitAPI/Tests/CheckedArithmeticOperations.cpp.
2333
2334 2011-08-31  Elliot Poger  <epoger@google.com>
2335
2336         add unittest to validate the complete set of Chromium configurations
2337         https://bugs.webkit.org/show_bug.cgi?id=67211
2338
2339         Reviewed by Adam Barth.
2340
2341         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2342
2343 2011-08-31  Nico Weber  <thakis@chromium.org>
2344
2345         Make ScrollAnimator(Chromium)?Mac check scrollAnimatorEnabled()
2346         https://bugs.webkit.org/show_bug.cgi?id=67297
2347
2348         Reviewed by Tony Chang.
2349
2350         Explicitly disable smooth scrolling in chromium's DRT.
2351
2352         * DumpRenderTree/chromium/WebPreferences.cpp:
2353         (WebPreferences::applyTo):
2354
2355 2011-08-31  Oliver Hunt  <oliver@apple.com>
2356
2357         Add Checked<> tests to windows build
2358
2359         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2360
2361 2011-08-30  Oliver Hunt  <oliver@apple.com>
2362
2363         Add support for checked arithmetic
2364         https://bugs.webkit.org/show_bug.cgi?id=67095
2365
2366         Reviewed by Sam Weinig.
2367
2368         Add test cases for Checked<>
2369
2370         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2371         * TestWebKitAPI/Tests/CheckedArithmeticOperations.cpp: Added.
2372
2373 2011-08-31  Adam Barth  <abarth@webkit.org>
2374
2375         Move summary.html to garden-o-matic.html.
2376
2377         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html.
2378         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js.
2379         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Removed.
2380         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Removed.
2381
2382 2011-08-31  Noel Gordon  <noel.gordon@gmail.com>
2383
2384         [chromium] DRT linux should pass nativeKeyCode to plugins
2385         https://bugs.webkit.org/show_bug.cgi?id=66679
2386
2387         Reviewed by Tony Chang.
2388
2389         * DumpRenderTree/chromium/EventSender.cpp:
2390         (EventSender::keyDown):  Call a Chromium Linux GTK helper routine that returns the
2391         (simulated) nativeKeyCode for the given input keyboard code.
2392
2393 2011-08-31  Adam Barth  <abarth@webkit.org>
2394
2395         Tighen up UI for garden-o-matic tab strip
2396         https://bugs.webkit.org/show_bug.cgi?id=67266
2397
2398         Reviewed by Dimitri Glazkov.
2399
2400         This patch add CSS to move the tab strip to the edges of the page and
2401         to remove some gratuitous border-radius.
2402
2403         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css:
2404         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
2405
2406 2011-08-31  Adam Barth  <abarth@webkit.org>
2407
2408         garden-o-matic results view shouldn't be horrifically ugly
2409         https://bugs.webkit.org/show_bug.cgi?id=67264
2410
2411         Reviewed by Dimitri Glazkov.
2412
2413         Minor tweak to the results view CSS to make it fit in better with the new tabbed UI.
2414
2415         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2416         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
2417         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
2418
2419 2011-08-31  Adam Barth  <abarth@webkit.org>
2420
2421         garden-o-matic needs a tabstrip
2422         https://bugs.webkit.org/show_bug.cgi?id=67263
2423
2424         Reviewed by Dimitri Glazkov.
2425
2426         This patch adds a basic tabstrip to garden-o-matic.  The results
2427         details view now opens in the "Results" tab, and the user can flip back
2428         and forth between the Summary and the Results tab quickly.  There's
2429         also a stub for a "Commits" tab, which is disabled.
2430
2431         This patch isn't the most beautiful in the world, but it gets the ball
2432         rolling on a multi-modal UI.
2433
2434         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2435         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
2436         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2437         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css:
2438         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
2439
2440 2011-08-31  Ai Makabi  <makabi@google.com>
2441
2442         Extract reference links from reftest test file.
2443         https://bugs.webkit.org/show_bug.cgi?id=66838
2444
2445         Reviewed by Shinichiro Hamaji.
2446
2447         * Scripts/webkitpy/layout_tests/reftests/__init__.py: Added.
2448         * Scripts/webkitpy/layout_tests/reftests/extract_reference_link.py: Added.
2449         * Scripts/webkitpy/layout_tests/reftests/extract_reference_link_unittest.py: Added.
2450
2451 2011-08-03  Philippe Normand  <pnormand@igalia.com>
2452
2453         [webkitpy] missing log import in common/net/resultsjsonparser.py
2454         https://bugs.webkit.org/show_bug.cgi?id=65606
2455
2456         Reviewed by Martin Robinson.
2457
2458         * Scripts/webkitpy/common/net/resultsjsonparser.py: Import the logging module.
2459
2460 2011-08-30  Philippe Normand  <pnormand@igalia.com>
2461
2462         [stylechecker] complains about NULL usage in some gst_structure_ calls
2463         https://bugs.webkit.org/show_bug.cgi?id=67194
2464
2465         Reviewed by Martin Robinson.
2466
2467         Don't warn about NULL in some gst_structure_ calls. 0 can't be
2468         used for these, a proper sentinel is required.
2469
2470         * Scripts/webkitpy/style/checkers/cpp.py:
2471         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2472
2473 2011-08-30  Adam Barth  <abarth@webkit.org>
2474
2475         Remove old-style UI from garden-o-matic
2476         https://bugs.webkit.org/show_bug.cgi?id=67257
2477
2478         Reviewed by Dimitri Glazkov.
2479
2480         This code is nowhere near as awesome as the new hotness.  Let's remove
2481         it so it doesn't weigh us down.
2482
2483         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Removed.
2484         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/main.js: Removed.
2485         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2486         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
2487         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/unexpected-passes.js: Removed.
2488         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.html: Removed.
2489
2490 2011-08-30  Takashi Toyoshima  <toyoshim@chromium.org>
2491
2492         [WebSocket] update pywebsocket to 0.6b5.
2493         https://bugs.webkit.org/show_bug.cgi?id=66924
2494
2495         Reviewed by Kent Tamura.
2496
2497         pywebsocket 0.6b2 supported minimum features of Hybi-08 specification.
2498         Now, pywebsocket 0.6b5 supports full features of Hybi-10 specification.
2499         0.6b3 or later supports a closing handshake handler and it is useful to
2500         verify client's closing handshake implementation.
2501         0.6b4 supports AbortedByUserException. It is useful to eliminate
2502         unnecessary server warning messages on intended abnormal closures.
2503         0.6b5 supports Python 2.5.1 or Mac 10.5.
2504
2505         * Scripts/webkitpy/thirdparty/__init__.py:
2506         Update download URL and directory path.
2507
2508 2011-08-30  Dan Bernstein  <mitz@apple.com>
2509
2510         Test for <rdar://problem/9281695> Add text search API for getting the DOM range of a text match
2511         https://bugs.webkit.org/show_bug.cgi?id=67230
2512
2513         Reviewed by Darin Adler.
2514
2515         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2516         * TestWebKitAPI/Tests/mac/DOMRangeOfString.html: Added.
2517         * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm: Added.
2518         (-[DOMRangeOfStringFrameLoadDelegate webView:didFinishLoadForFrame:]):
2519         (TestWebKitAPI::TEST):
2520
2521 2011-08-30  Aaron Colwell  <acolwell@chromium.org>
2522
2523         Add MediaSource API to HTMLMediaElement
2524         https://bugs.webkit.org/show_bug.cgi?id=64731
2525
2526         Reviewed by Eric Carlson.
2527
2528         * Scripts/build-webkit:
2529
2530 2011-08-30  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
2531
2532         Emit last progress notification before calling dispatchDidFinishLoad
2533         https://bugs.webkit.org/show_bug.cgi?id=28851
2534
2535         Reviewed by Adam Barth.
2536
2537         Implement dumpProgressFinishedCallback() in the layoutTestController for Qt,
2538         Chromium and GTK ports. The first two were simple changes.
2539
2540         Some refactoring was needed in GTK port to assure that the dumps are emitted
2541         correctly and the processing after the page load finished is in the right place.
2542
2543         To detect the load finished, we use the callback for the "load-status" notifier
2544         signal of the top loading frame. And we use the deprecated "load-finished" signal
2545         for dumping (if enabled) the progress finished expected output.
2546
2547         * DumpRenderTree/LayoutTestController.cpp:
2548         (LayoutTestController::LayoutTestController):
2549         (dumpProgressFinishedCallbackCallback):
2550         (LayoutTestController::staticFunctions):
2551         * DumpRenderTree/LayoutTestController.h:
2552         (LayoutTestController::dumpProgressFinishedCallback):
2553         (LayoutTestController::setDumpProgressFinishedCallback):
2554         * DumpRenderTree/chromium/LayoutTestController.cpp:
2555         (LayoutTestController::LayoutTestController):
2556         (LayoutTestController::dumpProgressFinishedCallback):
2557         (LayoutTestController::reset):
2558         * DumpRenderTree/chromium/LayoutTestController.h:
2559         (LayoutTestController::shouldDumpProgressFinishedCallback):
2560         (LayoutTestController::setShouldDumpProgressFinishedCallback):
2561         * DumpRenderTree/chromium/WebViewHost.cpp:
2562         (WebViewHost::didStopLoading):
2563         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2564         (webViewLoadFinished):
2565         (topLoadingFrameLoadFinished):
2566         (webFrameLoadStatusNotified):
2567         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2568         (LayoutTestController::reset):
2569         (LayoutTestController::dumpProgressFinishedCallback):
2570         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2571
2572 2011-08-30  Filip Pizlo  <fpizlo@apple.com>
2573
2574         JavaScriptCore does not have a good mechanism for performance
2575         regression testing
2576         https://bugs.webkit.org/show_bug.cgi?id=67177
2577
2578         Reviewed by Darin Adler.
2579         
2580         Added a new script, which allows for testing one, two, or more VMs
2581         at once on SunSpider, V8, and Kraken benchmarks.  Benchmark/VM runs
2582         are interleaved at random to minimize systematics.  The results
2583         that bencher prints includes all possible relevant information about
2584         how bencher was invoked.  Bencher can be easily used to measure
2585         performance changes down to fractions of a percent.
2586         
2587         Bencher also includes experimental support for running benchmarks in
2588         a DumpRenderTree release build.  This works in SunSpider and V8, but
2589         not yet in Kraken.  Running benchmarks in DumpRenderTree more
2590         closely mimics the performance when running in browser.
2591
2592         * Scripts/bencher: Added.
2593
2594 2011-08-29  Alexey Proskuryakov  <ap@apple.com>
2595
2596         DumpRenderTree should begin each test with an empty cookie store
2597         https://bugs.webkit.org/show_bug.cgi?id=63545
2598         <rdar://problem/5666907>
2599
2600         Reviewed by Darin Adler.
2601
2602         * DumpRenderTree/mac/DumpRenderTree.mm:
2603         (resetDefaultsToConsistentValues):
2604         (setDefaultsToConsistentValuesForTesting):
2605         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2606         (LayoutTestController::setAlwaysAcceptCookies):
2607         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2608         (WTR::InjectedBundle::beginTesting):
2609         Use new SPIs to manipulate sessions.
2610
2611 2011-08-30  Sheriff Bot  <webkit.review.bot@gmail.com>
2612
2613         Unreviewed, rolling out r94055 and r94057.
2614         http://trac.webkit.org/changeset/94055
2615         http://trac.webkit.org/changeset/94057
2616         https://bugs.webkit.org/show_bug.cgi?id=67191
2617
2618         Many failures on Mac 10.5 (Requested by toyoshim on #webkit).
2619
2620         * Scripts/webkitpy/thirdparty/__init__.py:
2621
2622 2011-08-30  Adam Barth  <abarth@webkit.org>
2623
2624         Chromium Android should not be a core builder
2625         https://bugs.webkit.org/show_bug.cgi?id=67184
2626
2627         Reviewed by Ryosuke Niwa.
2628
2629         This bot hasn't been consistently green yet because it has never actually run!
2630
2631         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2632         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2633
2634 2011-08-30  Takashi Toyoshima  <toyoshim@chromium.org>
2635
2636         [WebSocket] update pywebsocket to 0.6b4.
2637         https://bugs.webkit.org/show_bug.cgi?id=66924
2638
2639         Reviewed by Kent Tamura.
2640
2641         pywebsocket 0.6b2 supported minimum features of Hybi-08 specification.
2642         Now, pywebsocket 0.6b4 supports full features of Hybi-10 specification.
2643         0.6b3 or later supports a closing handshake handler and it is useful to
2644         verify client's closing handshake implementation.
2645         0.6b4 supports AbortedByUserException. It is useful to eliminate
2646         unnecessary server warning messages on intended abnormal closures.
2647
2648         * Scripts/webkitpy/thirdparty/__init__.py:
2649         Update download URL and directory path.
2650
2651 2011-08-29  Tom Zakrajsek  <tomz@codeaurora.org>
2652
2653         sheriffbot "usage" help statements are wrong
2654         https://bugs.webkit.org/show_bug.cgi?id=67170
2655
2656         Reviewed by Adam Barth.
2657
2658         * Scripts/webkitpy/tool/bot/irc_command.py:
2659         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2660         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
2661
2662 2011-08-29  Adam Barth  <abarth@webkit.org>
2663
2664         Add support for chomium-mac (non-CoreGraphics) baselines
2665         https://bugs.webkit.org/show_bug.cgi?id=67163
2666
2667         Reviewed by Eric Seidel.
2668
2669         This patch teaches the non-CG chromium-mac bots to look at non-CG
2670         baselines.  However, the patch still leaves CG as the default set of
2671         baselines.
2672
2673         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
2674         * Scripts/webkitpy/common/config/build.py:
2675         * Scripts/webkitpy/common/config/build_unittest.py:
2676         * Scripts/webkitpy/layout_tests/port/builders.py:
2677         * Scripts/webkitpy/layout_tests/port/chromium.py:
2678         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2679         * Scripts/webkitpy/layout_tests/port/factory.py:
2680         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
2681         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
2682         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
2683         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2684
2685 2011-08-29  Shawn Singh  <shawnsingh@chromium.org>
2686
2687         Small fix in chromium port of new-run-webkit-tests.
2688         https://bugs.webkit.org/show_bug.cgi?id=67078
2689
2690         Reviewed by Dirk Pranke.
2691
2692         * Scripts/webkitpy/layout_tests/port/chromium.py:
2693
2694 2011-08-29  Sheriff Bot  <webkit.review.bot@gmail.com>
2695
2696         Unreviewed, rolling out r93987, r93992, r93995, r93998, and
2697         r93999.
2698         http://trac.webkit.org/changeset/93987
2699         http://trac.webkit.org/changeset/93992
2700         http://trac.webkit.org/changeset/93995
2701         http://trac.webkit.org/changeset/93998
2702         http://trac.webkit.org/changeset/93999
2703         https://bugs.webkit.org/show_bug.cgi?id=67147
2704
2705         Many failing tests (Requested by ap on #webkit).
2706
2707         * DumpRenderTree/mac/DumpRenderTree.mm:
2708         (setDefaultsToConsistentValuesForTesting):
2709         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2710         (WTR::InjectedBundle::beginTesting):
2711
2712 2011-08-26  Alexey Proskuryakov  <ap@apple.com>
2713
2714         DumpRenderTree should begin each test with an empty cookie store
2715         https://bugs.webkit.org/show_bug.cgi?id=63545
2716         <rdar://problem/5666907>
2717
2718         Reviewed by Darin Adler.
2719
2720         * DumpRenderTree/mac/DumpRenderTree.mm:
2721         (setDefaultsToConsistentValuesForTesting):
2722         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2723         (WTR::InjectedBundle::beginTesting):
2724         Tell WebCore to use a temporary session, starting with a clean cookie store.
2725
2726 2011-08-23  Chris Marrin  <cmarrin@apple.com>
2727
2728         [mac] requestAnimationFrame support for mac port
2729         https://bugs.webkit.org/show_bug.cgi?id=59146
2730
2731         Reviewed by Simon Fraser.
2732
2733         Add support for request-animation-callback flag
2734
2735         * Scripts/build-webkit:
2736
2737 2011-08-27  Peter Beverloo  <peter@chromium.org>
2738
2739         Add a build bot for Chromium with OS(ANDROID)
2740         https://bugs.webkit.org/show_bug.cgi?id=66687
2741
2742         Reviewed by Adam Barth.
2743
2744         * BuildSlaveSupport/build.webkit.org-config/config.json:
2745
2746 2011-08-27  Peter Beverloo  <peter@chromium.org>
2747
2748         Update the master build bot configuration script to properly
2749         deal with the --chromium-android switch.
2750         https://bugs.webkit.org/show_bug.cgi?id=66687
2751
2752         The --chromium-android switch is needed when running
2753         update-webkit-chromium and build-webkit, as it'll tell the
2754         scripts to pull in the right dependencies and cross-compile
2755         WebKit using the Android NDK.
2756
2757         Reviewed by Adam Barth.
2758
2759         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2760
2761 2011-08-27  Peter Beverloo  <peter@chromium.org>
2762
2763         Teach the update and build scripts how to handle dependencies
2764         and cross-compiling rules for the Chromium port on OS(ANDROID).
2765         https://bugs.webkit.org/show_bug.cgi?id=66687
2766
2767         Reviewed by Adam Barth.
2768
2769         * Scripts/build-webkit:
2770         * Scripts/update-webkit:
2771         * Scripts/update-webkit-chromium:
2772         * Scripts/webkitdirs.pm:
2773         (argumentsForConfiguration):
2774         (isChromium):
2775         (isChromiumAndroid):
2776         (determineIsChromiumAndroid):
2777         (buildChromium):
2778
2779 2011-08-26  Adam Barth  <abarth@webkit.org>
2780
2781         garden-o-matic should let me know that I need to run the local server
2782         https://bugs.webkit.org/show_bug.cgi?id=66985
2783
2784         Reviewed by Dimitri Glazkov.
2785
2786         The patch triggers an alert dialog whenever the user tries to use a
2787         feature that requires the local server.
2788
2789         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
2790         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
2791         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
2792
2793 2011-08-26  Dimitri Glazkov  <dglazkov@chromium.org>
2794
2795         garden-o-matic summary view should have pretty commit data information.
2796         https://bugs.webkit.org/show_bug.cgi?id=67069
2797
2798         Reviewed by Adam Barth.
2799
2800         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added support for styling commit data.
2801         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Changed tests.
2802         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Defined global anchor color.
2803         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Styled commit data.
2804
2805 2011-08-26  Dimitri Glazkov  <dglazkov@chromium.org>
2806
2807         Tweak the use of Open Sans in garden-o-matic summary view to make it look decent on Windows and Linux.
2808         https://bugs.webkit.org/show_bug.cgi?id=67066
2809
2810         Reviewed by Adam Barth.
2811
2812         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Tweaked.
2813         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Ditto.
2814
2815 2011-08-26  Raphael Kubo da Costa  <kubo@profusion.mobi>
2816
2817         [DRT] Include cairo.h in PixelDumpSupportCairo.h for EFL too.
2818         https://bugs.webkit.org/show_bug.cgi?id=67041
2819
2820         Reviewed by Martin Robinson.
2821
2822         This is a follow-up to r89053: EFL's PixelDumpSupportEfl.cpp includes
2823         PixelDumpSupportCairo.h, but the latter was #including cairo.h only
2824         when the GTK+ port was being built.
2825
2826         * DumpRenderTree/cairo/PixelDumpSupportCairo.h:
2827
2828 2011-08-26  Dimitri Glazkov  <dglazkov@chromium.org>
2829
2830         Clean up and line up layout in garden-o-matic summary view.
2831         https://bugs.webkit.org/show_bug.cgi?id=67057
2832
2833         1) Renamed ui.notifications.TestFailures to ui.notifications.TestsFailing to match BuildersFailing;
2834         2) Rearranged DOM structure a bit to accommodate recent changes;
2835         3) Added minimal CSS to line things up.
2836
2837         Reviewed by Adam Barth.
2838
2839         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Renamed TestFailures to TestsFailing.
2840         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js: Added mocks for BuildersFailing.
2841         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js: Renamed TestFailures to TestsFailing.
2842         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js: Updated tests.
2843         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Changed DOM structure.
2844         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated tests.
2845         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Tweaked common appearance.
2846         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Added minimal layout/style.
2847         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Added Google Web Fonts hook.
2848         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Ditto.
2849
2850 2011-08-26  Alice Liu  <alice.liu@apple.com>
2851
2852         https://bugs.webkit.org/show_bug.cgi?id=66823
2853         Add the request info to the WebPageProxy::CreateNewPage message
2854
2855         Reviewed by Anders Carlsson.
2856
2857         Update function declarations with additional parameter:
2858         * MiniBrowser/gtk/BrowserWindow.c:
2859         (createNewPage):
2860         * MiniBrowser/mac/BrowserWindowController.m:
2861         (createNewPage):
2862         * MiniBrowser/win/BrowserView.cpp:
2863         (createNewPage):
2864         * WebKitTestRunner/TestController.cpp:
2865         (WTR::TestController::createOtherPage):
2866         * WebKitTestRunner/TestController.h:
2867
2868 2011-08-26  Noel Gordon  <noel.gordon@gmail.com>
2869
2870         Make show-pretty-diff work on linux
2871         https://bugs.webkit.org/show_bug.cgi?id=67017
2872
2873         Reviewed by Adam Barth.
2874
2875         * Scripts/show-pretty-diff:
2876
2877 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
2878
2879         Reorganize garden-o-matic CSS files to match JS-built views.
2880         https://bugs.webkit.org/show_bug.cgi?id=66998
2881
2882         Reviewed by Adam Barth.
2883
2884         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Added.
2885         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Added.
2886         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css: Added.
2887         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css: Removed.
2888         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Changed to use new CSS files.
2889         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Ditto.
2890
2891 2011-08-25  Adam Barth  <abarth@webkit.org>
2892
2893         garden-o-matic should be able to roll out patches
2894         https://bugs.webkit.org/show_bug.cgi?id=66982
2895
2896         Reviewed by Dimitri Glazkov.
2897
2898         This patch just wires the rollout event through the controller to the
2899         local server, which is already set up to perform rollouts.
2900
2901         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
2902         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2903         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2904         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
2905
2906 2011-08-25  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
2907
2908         [Qt] [WK2] Assert in computeViewportAttributes when MiniBrowser started with -touch
2909         https://bugs.webkit.org/show_bug.cgi?id=66951
2910
2911         Reviewed by Andreas Kling.
2912
2913         Function computeViewportAttributes() gets called when height is still 0 because MiniBrowser sets
2914         width and height one by one and setWidth cause geometryChange event in QTouchWebView. 
2915
2916         * MiniBrowser/qt/BrowserView.cpp:
2917         (BrowserView::resizeEvent):
2918
2919 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
2920
2921         garden-o-matic summary view should provide information on builders still in flight.
2922         https://bugs.webkit.org/show_bug.cgi?id=66992
2923
2924         Reviewed by Adam Barth.
2925
2926         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Added grabbing the list of in-flight builders.
2927         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js: Added buildersInFlightForRevision.
2928         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js: Added tests.
2929         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Split off updating builder results to own method.
2930         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added tests.
2931
2932 2011-08-25  Adam Barth  <abarth@webkit.org>
2933
2934         webkit-patch rebaseline-expectations don't work when run outside the root
2935         https://bugs.webkit.org/show_bug.cgi?id=66966
2936
2937         Reviewed by Eric Seidel.
2938
2939         Turns out tool.path() used to be relative, which caused problems when
2940         running webkit-patch outside the root directory.  This patch makes it
2941         absolute.  I checked all callers, and they all appear to want this
2942         behavior.
2943
2944         It was unclear to me how to test this change because we only really
2945         have a testing strategy for webkitpy, not for the main script.
2946
2947         * Scripts/webkit-patch:
2948
2949 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
2950
2951         garden-o-matic summary needs a mock view that could be used for working on styling
2952         https://bugs.webkit.org/show_bug.cgi?id=66971
2953
2954         Reviewed by Adam Barth.
2955
2956         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js: Added.
2957         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Added.
2958
2959 2011-08-25  Anders Carlsson  <andersca@apple.com>
2960
2961         Return the correct value for NPNVsupportsCarbonBool
2962         https://bugs.webkit.org/show_bug.cgi?id=66964
2963
2964         Add a test.
2965
2966         Reviewed by Adam Roben.
2967
2968         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2969         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Added.
2970         (SupportsCarbonEventModel::SupportsCarbonEventModel):
2971         (SupportsCarbonEventModel::testConvert):
2972         (SupportsCarbonEventModel::runTest):
2973         (SupportsCarbonEventModel::NPP_New):
2974
2975 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
2976
2977         garden-o-matic summary view should not be broken.
2978
2979         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css:
2980         (table.comparison): Added more specificity.
2981
2982 2011-08-25  Adam Barth  <abarth@webkit.org>
2983
2984         This command has been broken for a while.  This patch updates the
2985         callsite to the new API.
2986
2987         * Scripts/webkitpy/tool/commands/rebaseline.py:
2988
2989 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
2990
2991         garden-o-matic needs a way to report where and how tests are failing in the summary view.
2992         https://bugs.webkit.org/show_bug.cgi?id=66955
2993
2994         Introduce FailureGrid, your one-stop failure-indicating destination. 
2995
2996         Reviewed by Adam Barth.
2997
2998         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html: Added new scripts.
2999         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js: Added.
3000         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js: Added.
3001         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Updated to use FailureGrid.
3002         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated tests.
3003         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Added new scripts.
3004
3005 2011-08-25  Igor Oliveira  <igor.oliveira@openbossa.org>
3006
3007         Add myself to the committers list
3008         https://bugs.webkit.org/show_bug.cgi?id=66941
3009
3010         Reviewed by Andreas Kling.
3011
3012         * Scripts/webkitpy/common/config/committers.py:
3013
3014 2011-08-25  Sheriff Bot  <webkit.review.bot@gmail.com>
3015
3016         Unreviewed, rolling out r93767.
3017         http://trac.webkit.org/changeset/93767
3018         https://bugs.webkit.org/show_bug.cgi?id=66931
3019
3020         Broke Qt bot. (Requested by yutak on #webkit).
3021
3022         * Scripts/webkitpy/thirdparty/__init__.py:
3023
3024 2011-08-25  Takashi Toyoshima  <toyoshim@chromium.org>
3025
3026         [WebSocket] update pywebsocket to 0.6b3 which supports closing handshake test
3027         https://bugs.webkit.org/show_bug.cgi?id=66924
3028
3029         Reviewed by Kent Tamura.
3030
3031         * Scripts/webkitpy/thirdparty/__init__.py:
3032
3033 2011-08-24  Adam Barth  <abarth@webkit.org>
3034
3035         The user can't close the details view in garden-o-matic
3036         https://bugs.webkit.org/show_bug.cgi?id=66911
3037
3038         Reviewed by Dimitri Glazkov.
3039
3040         In addition to adding a close button, this patch changes the test
3041         selector to use a <select> element and refactors the test selector to
3042         share code with the builder selector.
3043
3044         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3045         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
3046         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js:
3047         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
3048
3049 2011-08-24  James Robinson  <jamesr@chromium.org>
3050
3051         [chromium] Stacktrace not in test output when a test crashes
3052         https://bugs.webkit.org/show_bug.cgi?id=66806
3053
3054         Reviewed by Dirk Pranke.
3055
3056         Appends the .error and .text output when a test crashes since on chromium the .text contains the actual stack
3057         trace.
3058
3059         * Scripts/webkitpy/layout_tests/port/chromium.py:
3060
3061 2011-08-24  Adam Barth  <abarth@webkit.org>
3062
3063         Remove empty directory.
3064
3065         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui: Removed.
3066
3067 2011-08-24  Adam Barth  <abarth@webkit.org>
3068
3069         Finish writing up details-view in garden-o-matic
3070         https://bugs.webkit.org/show_bug.cgi?id=66891
3071
3072         Reviewed by Dimitri Glazkov.
3073
3074         This patch mostly just copies a bunch of CSS from main.css to
3075         summary.css.  Presumably we'll delete main.css soon.
3076
3077         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3078         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
3079         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js:
3080         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css:
3081         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
3082
3083 2011-08-24  James Robinson  <jamesr@chromium.org>
3084
3085         Some compositing LayoutTests flakily crashing on Mac 10.6
3086         https://bugs.webkit.org/show_bug.cgi?id=66740
3087
3088         Reviewed by Adam Barth.
3089
3090         Null-check obj->pluginTest before dereferencing it. This can be null in chromium if the plugin load fails, for
3091         example if the test attempts to load a PDF plugin the load will fail since we don't have such a thing in the
3092         chromium configuration.
3093
3094         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3095         (NPP_Destroy):
3096
3097 2011-08-24  Anton D'Auria  <adauria@apple.com>
3098
3099         No review necessary.
3100
3101         Adding myself to list of committers.
3102
3103         * Scripts/webkitpy/common/config/committers.py:
3104
3105 2011-08-24  Avi Drissman  <avi@google.com>
3106
3107         Crash when restoring NSGraphicsContext when running the Chromium GPU layout tests on Mac
3108         https://bugs.webkit.org/show_bug.cgi?id=66875
3109
3110         Reviewed by James Robinson.
3111
3112         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
3113         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
3114
3115 2011-08-23  Dimitri Glazkov  <dglazkov@chromium.org>
3116
3117         Make notifications appear in time order again.
3118         https://bugs.webkit.org/show_bug.cgi?id=66815
3119
3120         Reviewed by Adam Barth.
3121
3122         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added setting index of the notification.
3123         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated the test.
3124
3125 2011-08-23  James Robinson  <jamesr@chromium.org>
3126
3127         [chromium] Need a way to test lost compositor context recovery
3128         https://bugs.webkit.org/show_bug.cgi?id=66820
3129
3130         Reviewed by Kenneth Russell.
3131
3132         Exposes a LayoutTestController interface in chromium to simulate a
3133         lost compositor context.
3134
3135         * DumpRenderTree/chromium/LayoutTestController.cpp:
3136         (LayoutTestController::LayoutTestController):
3137         (LayoutTestController::loseCompositorContext):
3138         * DumpRenderTree/chromium/LayoutTestController.h:
3139
3140 2011-08-23  Dimitri Glazkov  <dglazkov@chromium.org>
3141
3142         Change garden-o-matic frontend builder array to be a configuration map.
3143         https://bugs.webkit.org/show_bug.cgi?id=66816
3144
3145         Reviewed by Adam Barth.
3146
3147         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js: Made kBuilders a map, with value being a configuration object.
3148         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: Adjusted callsites to expect a map.
3149         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/main.js: Ditto.
3150         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js: Ditto.
3151         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Ditto.
3152
3153 2011-08-23  Cary Clark  <caryclark@google.com>
3154
3155         Turn WebCanvas into CGContext before drawing scrollbar (DRT using Skia on Mac)
3156         https://bugs.webkit.org/show_bug.cgi?id=66803
3157
3158         This fixes the WebKit Canaries, in particular avoids a crash on tests
3159         like css1/basic/comments.html.
3160
3161         Reviewed by James Robinson.
3162
3163         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
3164         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
3165         The NSGraphicsContext call graphicsContextWithGraphicsPort takes a void*
3166         parameter, so it took a WebCanvas* (mapped to SkCanvas* in Skia-land)
3167         and treated it as if it were a CGContextRef.
3168
3169 2011-08-23  Patrick Gansterer  <paroga@webkit.org>
3170
3171         Fix mergeChangeLogs test on native windows
3172         https://bugs.webkit.org/show_bug.cgi?id=66797
3173
3174         Reviewed by Adam Roben.
3175
3176         Windows has no /tmp/ directory and the "TMPDIR" environment variable isn't set in the default setup.
3177         Add the "TEMP" environment variable as additional source for the temporary directory used in writeTempFile.
3178
3179         * Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl:
3180         (writeTempFile):
3181
3182 2011-08-23  Dimitri Glazkov  <dglazkov@chromium.org>
3183
3184         garden-o-matic relative time is wrong and updates too frequently.
3185         https://bugs.webkit.org/show_bug.cgi?id=66802
3186
3187         Reviewed by Adam Barth.
3188
3189         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js: Changed to account for rounding correctly.
3190         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js: Updated tests.
3191         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: Upped the interval to 1 minute.
3192
3193 2011-08-23  Patrick Gansterer  <paroga@webkit.org>
3194
3195         Add missing quotes around filenames in mergeChangeLogs
3196         https://bugs.webkit.org/show_bug.cgi?id=66794
3197
3198         Reviewed by Adam Roben.
3199
3200         * Scripts/VCSUtils.pm:
3201         (mergeChangeLogs):
3202
3203 2011-08-23  Patrick Gansterer  <paroga@webkit.org>
3204
3205         webkit-perl tests fail on win32 Perl due to lack of list form of pipe open implementation
3206         https://bugs.webkit.org/show_bug.cgi?id=49080
3207
3208         Reviewed by Adam Roben.
3209
3210         Use the string form of pipe open instead (like we do at all other places).
3211
3212         * Scripts/VCSUtils.pm:
3213         (mergeChangeLogs):
3214
3215 2011-08-23  Adam Barth  <abarth@webkit.org>
3216
3217         garden-o-matic summary should be able to examine failures
3218         https://bugs.webkit.org/show_bug.cgi?id=66748
3219
3220         Reviewed by Dimitri Glazkov.
3221
3222         This patch refactors a bunch of code from summary.js to independent
3223         controllers in controllers.js.  This patch also contains the first
3224         iteration of binding the "examine" event to a the behavior showing the
3225         details view for the tests.  There's more work to do here to make this
3226         work properly (and elegantly), but this patch is a start.
3227
3228         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
3229         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
3230         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3231         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers/rebaseline.js:
3232         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
3233         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
3234         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
3235         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
3236         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
3237
3238 2011-08-23  Adam Barth  <abarth@webkit.org>
3239
3240         webkitpy/common/config/build.py shouldn't mention non-existant Android directory
3241         https://bugs.webkit.org/show_bug.cgi?id=66737
3242
3243         Reviewed by Steve Block.
3244
3245         This directory doesn't exist anymore now that the Android port shares
3246         more code with Chromium.
3247
3248         * Scripts/webkitpy/common/config/build.py:
3249
3250 2011-08-22  Eric Seidel  <eric@webkit.org>
3251
3252         Hack start-queue.sh in an attempt to resurrect the cr-jail-1 cr-mac-ews bot.
3253         I won't have ssh access to the bot again for a couple days, so
3254         attempting to fix by changing this script.  If this doesn't
3255         work we'll just live with the it hung for now.
3256
3257         Unreviewed.
3258
3259         * EWSTools/start-queue.sh:
3260
3261 2011-08-22  Dimitri Glazkov  <dglazkov@chromium.org>
3262
3263         webkit-patch rebaseline-expectations command should not rearrange the entire test_expectations.txt file.
3264         https://bugs.webkit.org/show_bug.cgi?id=66727
3265
3266         Reviewed by Adam Barth.
3267
3268         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Made it possible to run TestExpectationSerializer without a TestConfigurationConverter,
3269             in which case the serializer treats all expectations as unparsed.
3270         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added unit tests.
3271
3272 2011-08-22  Dimitri Glazkov  <dglazkov@chromium.org>
3273
3274         Update unit test expectations after r93530.
3275
3276         * Scripts/webkitpy/layout_tests/port/factory_unittest.py: Updated.
3277         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: Ditto.
3278
3279 2011-08-22  Dimitri Glazkov  <dglazkov@chromium.org>
3280
3281         [Chromium] Expand CPU/GPU/Skia/CG into a matrix in graphics_type.
3282         https://bugs.webkit.org/show_bug.cgi?id=66705
3283
3284         Reviewed by Adam Barth.
3285
3286         * Scripts/webkitpy/layout_tests/port/chromium.py: Added plumbing for CG graphics types.
3287         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Adjusted unit test.
3288
3289 2011-08-22  James Robinson  <jamesr@chromium.org>
3290
3291         [chromium] Update builder names for chromium gpu bots due to CG switchover
3292         https://bugs.webkit.org/show_bug.cgi?id=66693
3293
3294         Reviewed by Dirk Pranke.
3295
3296         Update the port and builder names for the chromium mac gpu bots to
3297         account for the CG transition.
3298
3299         * Scripts/webkitpy/layout_tests/port/builders.py:
3300
3301 2011-08-22  Dirk Pranke  <dpranke@chromium.org>
3302
3303         fix the GPU bot names on the layout test dashboard
3304         https://bugs.webkit.org/show_bug.cgi?id=66697
3305
3306         Reviewed by Dimitri Glazkov.
3307
3308         * TestResultServer/static-dashboards/builders.js:
3309
3310 2011-08-22  Dimitri Glazkov  <dglazkov@chromium.org>
3311
3312         garden-o-matic's relative time display should be updated regularly.
3313         https://bugs.webkit.org/show_bug.cgi?id=66682
3314
3315         Reviewed by Adam Barth.
3316
3317         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Moved Time to ui.Time, added code for regular updates.
3318         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Changed to use ui.Time.
3319         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js: Added tests.
3320
3321 2011-08-22  Xianzhu Wang  <wangxianzhu@chromium.org>
3322
3323         Pass --makeargs of build-webkit to chromium linux builder
3324         https://bugs.webkit.org/show_bug.cgi?id=66361
3325
3326         Reviewed by Tony Chang.
3327
3328         * Scripts/build-webkit:
3329         * Scripts/webkitdirs.pm:
3330         (buildChromiumMakefile):
3331         (buildChromium):
3332
3333 2011-08-22  Peter Beverloo  <peter@chromium.org>
3334
3335         Add myself to the contributor list.
3336         https://bugs.webkit.org/show_bug.cgi?id=66674
3337
3338         Reviewed by Tony Gentilcore.
3339
3340         * Scripts/webkitpy/common/config/committers.py:
3341
3342 2011-08-22  Balazs Kelemen  <kbalazs@webkit.org>
3343
3344         [Qt] ImageDiff does not consider --tolerance
3345         https://bugs.webkit.org/show_bug.cgi?id=66299
3346
3347         Reviewed by Csaba Osztrogonác.
3348
3349         * DumpRenderTree/qt/ImageDiff.cpp:
3350         (main):
3351
3352 2011-08-22  Csaba Osztrogonác  <ossy@webkit.org>
3353
3354         Update contributor list.
3355
3356         Reviewed by Zoltan Herczeg.
3357
3358         * Scripts/webkitpy/common/config/committers.py:
3359
3360 2011-08-22  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
3361
3362         [ORWT] Fix --reset-results --add-platform-exceptions combo
3363         https://bugs.webkit.org/show_bug.cgi?id=65464
3364
3365         Reviewed by Csaba Osztrogonác.
3366
3367         * Scripts/old-run-webkit-tests:
3368
3369 2011-08-20  Adam Barth  <abarth@webkit.org>
3370
3371         garden-o-matic summary.html should have UI for examining failures
3372         https://bugs.webkit.org/show_bug.cgi?id=66625
3373
3374         Reviewed by Dimitri Glazkov.
3375
3376         This patch introduces the notion of UI actions and converts our
3377         existing manual <button> manipulation with this new abstraction.  The
3378         patch also adds an Examine button to failure notifications.  In a
3379         future patch, I'll add a controller that wires this button up to
3380         something useful.
3381
3382         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
3383         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
3384         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js: Added.
3385         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js: Added.
3386         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
3387         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
3388         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
3389         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
3390
3391 2011-08-20  Adam Barth  <abarth@webkit.org>
3392
3393         garden-o-matic summary page should indiciate compile failures
3394         https://bugs.webkit.org/show_bug.cgi?id=66624
3395
3396         Reviewed by Dimitri Glazkov.
3397
3398         This patch creates a notification-based UI for build failures.  The new
3399         UI displays the same information that used to be displayed in the
3400         infobar.  There's lots of room for improvement in surfacing more
3401         information, but this is a start.
3402
3403         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
3404         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
3405         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
3406
3407 2011-08-19  James Robinson  <jamesr@chromium.org>
3408
3409         [chromium] Default to experimental-fully-parallel mode for chromium gpu port
3410         https://bugs.webkit.org/show_bug.cgi?id=66606
3411
3412         Reviewed by Dirk Pranke.
3413
3414         The chromium GPU configuration does not (currently) contain any tests
3415         incompatible with --experimental-fully-parallel, and this flag is a
3416         significan speedup because of the directory canvas/philip/tests which
3417         contains 802 tests in the same directory. Setting this option by
3418         default on this configuration is a 2x speed in release, 44s to 22s,
3419         and a 3x speedup in debug, 223s to 77s, on linux on a 16 core machine.
3420
3421         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3422         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3423         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3424
3425 2011-08-19  Sheriff Bot  <webkit.review.bot@gmail.com>
3426
3427         Unreviewed, rolling out r93426.
3428         http://trac.webkit.org/changeset/93426
3429         https://bugs.webkit.org/show_bug.cgi?id=66607
3430
3431         Broke the Mac build by not building gtest.framework anymore
3432         (Requested by andersca on #webkit).
3433
3434         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3435
3436 2011-08-19  James Robinson  <jamesr@chromium.org>
3437
3438         [chromium] Chromium GPU layout tests should use the normal process number selection, not force 1 worker
3439         https://bugs.webkit.org/show_bug.cgi?id=66603
3440
3441         Reviewed by Dirk Pranke.
3442
3443         The various ChromiumGpu ports should use the same child worker
3444         selection logic as other ports so they can run with full
3445         parallelization on multicore systems.
3446
3447         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3448         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3449
3450 2011-08-19  Alok Priyadarshi  <alokp@chromium.org>
3451
3452         [chromium] Remove dependency of WebThemeControlDRTWin on skia::PlatformCanvas
3453         https://bugs.webkit.org/show_bug.cgi?id=66570
3454
3455         Reviewed by Mihai Parparita.
3456
3457         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
3458         (WebThemeControlDRTWin::draw):
3459         (WebThemeControlDRTWin::drawTextField):
3460         (WebThemeControlDRTWin::drawProgressBar):
3461         * DumpRenderTree/chromium/WebThemeControlDRTWin.h:
3462
3463 2011-08-18  Dmitry Lomov  <dslomov@google.com>
3464
3465         TestWebKitAPI breaks on Windows due to fast malloc incompatibility.
3466         https://bugs.webkit.org/show_bug.cgi?id=66521
3467
3468         This patch ensures that gtest uses new and delete operators that are defined in JavaScriptCore.
3469
3470         Reviewed by David Levin.
3471
3472         * TestWebKitAPI/Tests/WTF/StringOperators.cpp: Removed redefinition of JS_EXPORTDATA.
3473
3474 2011-08-19  Adam Roben  <aroben@apple.com>
3475
3476         Add project file changes I left out in r93417
3477
3478         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3479
3480 2011-08-19  Adam Roben  <aroben@apple.com>
3481
3482         Add a helper class for swizzling ObjC instance methods to TestWebKitAPI
3483
3484         Fixes <http://webkit.org/b/66565> TestWebKitAPI needs a way to override instance methods of
3485         NSScreen
3486
3487         Reviewed by Anders Carlsson.
3488
3489         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
3490
3491         * TestWebKitAPI/Tests/TestWebKitAPI/mac/InstanceMethodSwizzler.mm: Added.
3492         (-[SimpleObject setValue:]): Original implementation.
3493
3494         (TestWebKitAPI::setValue2):
3495         (TestWebKitAPI::setValue3):
3496         Swizzled implementations.
3497
3498         (TestWebKitAPI::TEST): Test that we can swizzle and re-swizzle and un-swizzle an ObjC
3499         instance method.
3500
3501         * TestWebKitAPI/mac/InstanceMethodSwizzler.h: Added.
3502         * TestWebKitAPI/mac/InstanceMethodSwizzler.mm: Added.
3503         (TestWebKitAPI::InstanceMethodSwizzler::InstanceMethodSwizzler): Swizzle the method.
3504         (TestWebKitAPI::InstanceMethodSwizzler::~InstanceMethodSwizzler): Unswizzle the method.
3505
3506 2011-08-19  Tom Zakrajsek  <tomz@codeaurora.org>
3507
3508         Fix _path_to_apache() error reporting
3509         https://bugs.webkit.org/show_bug.cgi?id=66486
3510
3511         Reviewed by Ryosuke Niwa.
3512
3513         * Scripts/webkitpy/layout_tests/port/webkit.py:
3514
3515 2011-08-19  Adam Roben  <aroben@apple.com>
3516
3517         Windows build fix after r93404
3518
3519         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp: Added missing #include.
3520
3521 2011-08-19  Tony Gentilcore  <tonyg@chromium.org>
3522
3523         Add leandrogracia to the committers list
3524         https://bugs.webkit.org/show_bug.cgi?id=66552
3525
3526         Also fix line endings in file.
3527
3528         No reviewed required.
3529
3530         * Scripts/webkitpy/common/config/committers.py:
3531
3532 2011-08-19  Amruth Raj  <amruthraj@motorola.com>
3533
3534         Fix compilation issue in WebKitTestRunner
3535         https://bugs.webkit.org/show_bug.cgi?id=66554
3536
3537         Reviewed by Martin Robinson.
3538
3539         * WebKitTestRunner/PixelDumpSupport.cpp:
3540
3541 2011-08-19  Adam Roben  <aroben@apple.com>
3542
3543         Pull some of DynamicDeviceScaleFactor's code up into a shareable base class
3544
3545         This will make it easier to write other WebKit-agnostic tests
3546
3547         Fixes <http://webkit.org/b/66558> Would like to be able to reuse DynamicDeviceScaleFactor's
3548         code in other WebKit-agnostic tests
3549
3550         Reviewed by Anders Carlsson.
3551
3552         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
3553
3554         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm: Fixed copyright. Moved a bunch of
3555         code to WebKitAgnosticTest.h/mm. Changed to inherit from WebKitAgnosticTest.
3556         (TestWebKitAPI::DynamicDeviceScaleFactor::url): Simple getter.
3557         (TestWebKitAPI::DynamicDeviceScaleFactor::didLoadURL): Calls through to runTest.
3558         (TestWebKitAPI::DynamicDeviceScaleFactor::runTest): Removed loading code which
3559         WebKitAgnosticTest handles for us.
3560         (TestWebKitAPI::TEST_F): Removed view-creation code which WebKitAgnosticTest handles for us.
3561
3562         * TestWebKitAPI/mac/WebKitAgnosticTest.h: Added. Code came from DynamicDeviceScaleFactor.
3563         (TestWebKitAPI::WebKitAgnosticTest::loadAndWaitUntilDone): Code came from
3564         DynamicDeviceScaleFactor::runTest.
3565
3566         * TestWebKitAPI/mac/WebKitAgnosticTest.mm: Copied from Tools/TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm.
3567         (TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test): Code came from
3568         DynamicDeviceScaleFactor.WebKit.
3569         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test): Code came from
3570         DynamicDeviceScaleFactor.WebKit2.
3571
3572 2011-08-19  Adam Roben  <aroben@apple.com>
3573
3574         Clean up #includes in TestWebKitAPI
3575
3576         Fixes <http://webkit.org/b/66556> TestWebKitAPI's prefix header isn't very helpful
3577
3578         Reviewed by Anders Carlsson.
3579
3580         * TestWebKitAPI/TestWebKitAPIPrefix.h: Added wtf/Platform.h. Added gtest/gtest.h for C++
3581         files and WebKit/WebKit.h for ObjC files.
3582
3583         * TestWebKitAPI/InjectedBundleController.cpp:
3584         * TestWebKitAPI/JavaScriptTest.h:
3585         * TestWebKitAPI/PlatformUtilities.h:
3586         * TestWebKitAPI/PlatformWebView.h:
3587         * TestWebKitAPI/Test.h:
3588         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3589         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
3590         * TestWebKitAPI/Tests/WTF/VectorReverse.cpp:
3591         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
3592         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
3593         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
3594         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
3595         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
3596         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
3597         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
3598         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
3599         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
3600         * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
3601         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
3602         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
3603         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
3604         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
3605         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
3606         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp:
3607         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
3608         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
3609         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
3610         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
3611         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
3612         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
3613         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
3614         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
3615         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
3616         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
3617         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
3618         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
3619         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp:
3620         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
3621         * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp:
3622         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
3623         * TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp:
3624         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
3625         * TestWebKitAPI/TestsController.cpp:
3626         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
3627         Removed now-unnecessary #includes. Moved #includes of Test.h in with the rest of the
3628         #includes since it is no longer a special header.
3629
3630 2011-08-18  Dirk Pranke  <dpranke@chromium.org>
3631
3632         new-run-webkit-tests hung while acquiring http lock on snow leopard bots
3633         https://bugs.webkit.org/show_bug.cgi?id=64886
3634
3635         Temporarily disable the http locking to work around the issue.
3636         I'm not actually sure if this is going to work or improve things
3637         much.
3638
3639         Reviewed by Ryosuke Niwa.
3640
3641         * Scripts/webkitpy/layout_tests/port/mac.py:
3642
3643 2011-08-18  Tony Chang  <tony@chromium.org>
3644
3645         add embedded png checksums to WebKitTestRunner
3646         https://bugs.webkit.org/show_bug.cgi?id=66494
3647
3648         Looks like WebKitTestRunner has never supported embedded checksums.  This copies
3649         some code from DRT and adds it to the WebKitTestRunner.
3650
3651         Reviewed by Darin Adler.
3652
3653         * WebKitTestRunner/CyclicRedundancyCheck.cpp: Copied from Tools/DumpRenderTree
3654         * WebKitTestRunner/CyclicRedundancyCheck.h: Copied from Tools/DumpRenderTree
3655         * WebKitTestRunner/GNUmakefile.am: Add new files
3656         * WebKitTestRunner/PixelDumpSupport.cpp: Copied from Tools/DumpRenderTree
3657         * WebKitTestRunner/PixelDumpSupport.h: Copied from Tools/DumpRenderTree
3658         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Add new files
3659         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
3660         (WTR::dumpBitmap): Refactor to use PixelDumpSupport.
3661         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3662         * WebKitTestRunner/cg/TestInvocationCG.cpp:
3663         (WTR::dumpBitmap): Refactor to use PixelDumpSupport.
3664         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3665         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Add new files
3666
3667 2011-08-18  Shawn Singh  <shawnsingh@chromium.org>
3668
3669         https://bugs.webkit.org/show_bug.cgi?id=47240
3670
3671         Fixed a cygwin path problem in the chromium port of diff_image;
3672         Also made the return values of the diff_image function more consistent.
3673
3674         Reviewed by Dirk Pranke.
3675
3676         * Scripts/webkitpy/layout_tests/port/chromium.py:
3677
3678 2011-08-17  Alejandro G. Castro  <alex@igalia.com>
3679
3680         [GTK] Fix compilation problems with deprecations in gtk+
3681         https://bugs.webkit.org/show_bug.cgi?id=66073
3682
3683         Reviewed by Martin Robinson.
3684
3685         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3686         (main): G_CONST_RETURN was deprecated
3687         * GtkLauncher/main.c:
3688         (createWindow): Added gtk_box_new conditional compilation for
3689         gtk+-3.
3690         * MiniBrowser/gtk/BrowserWindow.c:
3691         (browser_window_init): Replaced gtk_vbox_new with gtk_box_new, we
3692         are just supporting gtk+-3 for WebKit2.
3693
3694 2011-08-18  Anders Carlsson  <andersca@apple.com>
3695
3696         Fix libc++ C++0x build
3697         https://bugs.webkit.org/show_bug.cgi?id=66479
3698
3699         Reviewed by Adam Roben.
3700
3701         Add missing includes.
3702
3703         * DumpRenderTree/LayoutTestController.cpp:
3704         * DumpRenderTree/mac/CheckedMalloc.cpp:
3705
3706 2011-08-18  Adam Roben  <aroben@apple.com>
3707
3708         Test that WebKit updates style when a WebView is moved between differently-scaled windows
3709
3710         Test for <http://webkit.org/b/66412> <rdar://problem/9971958> WebKit doesn't react when a
3711         WebView is moved between windows with different backing scale factors
3712
3713         Reviewed by Anders Carlsson.
3714
3715         * TestWebKitAPI/JavaScriptTest.cpp:
3716         (TestWebKitAPI::runJSTest): Moved a little bit of code from here...
3717         (TestWebKitAPI::compareJSResult): ...to here. Also made the error message more similar to
3718         gtest's built-in error messages.
3719
3720         * TestWebKitAPI/JavaScriptTest.h: Added overloads of runJSTest that take a WebView * and
3721         WKView * for convenience on Mac. Added compareJSResult helper function for implementing
3722         those overloads.
3723
3724         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
3725
3726         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm: Added.
3727         (-[FrameLoadDelegate initWithDidFinishLoadBoolean:]): Simple initializer.
3728         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]): Record that the load finished.
3729         (TestWebKitAPI::didFinishLoadForFrame): Record that the load finished.
3730         (TestWebKitAPI::setPageLoaderClient): Set up the client.
3731         (TestWebKitAPI::DynamicDeviceScaleFactor::DynamicDeviceScaleFactor): Simple constructor.
3732         (TestWebKitAPI::DynamicDeviceScaleFactor::createWindow): Creates a
3733         SyntheticBackingScaleFactorWindow and returns it.
3734         (TestWebKitAPI::DynamicDeviceScaleFactor::runTest): Loads devicePixelRatio.html and checks
3735         that WebKit uses the correct scale factor when the WebView is not in a window, is put in a
3736         window, is moved to a differently-scaled window, and is taken out of the window.
3737         (TestWebKitAPI::DynamicDeviceScaleFactor::loadURL): Helper function with overloads for
3738         WebKit1 and WebKit2.
3739         (TestWebKitAPI::TEST_F): Runs the test, with overloads for WebKit1 and WebKit2.
3740
3741         * TestWebKitAPI/Tests/mac/devicePixelRatio.html: Added.
3742
3743         * TestWebKitAPI/mac/JavaScriptTestMac.mm: Added.
3744         (TestWebKitAPI::runJSTest): Fairly simple overloads for WebView * and WKView *.
3745
3746         * TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.h: Added.
3747         * TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.m: Added.
3748         (-[SyntheticBackingScaleFactorWindow initWithContentRect:styleMask:backing:defer:]): Simple
3749         initializer.
3750         (-[SyntheticBackingScaleFactorWindow setBackingScaleFactor:]): Simple setter.
3751
3752         (-[SyntheticBackingScaleFactorWindow backingScaleFactor]):
3753         (-[SyntheticBackingScaleFactorWindow userSpaceScaleFactor]):
3754         Overrides of NSWindow methods that WebKit uses to determine the device scale factor.
3755
3756 2011-08-18  Dmitry Lomov  <dslomov@google.com>
3757
3758         https://bugs.webkit.org/show_bug.cgi?id=66425
3759         check-webkit-style should detect incorrectly formatted file change descriptions.
3760         Description, if present, should be separated from colon with a space.
3761
3762         Reviewed by David Levin.
3763
3764         * Scripts/webkitpy/style/checkers/changelog.py: Fix.
3765         * Scripts/webkitpy/style/checkers/changelog_unittest.py: Unit tests.
3766
3767 2011-08-18  Adam Barth  <abarth@webkit.org>
3768
3769         webkit-patch pretty-diff should be shown in main help
3770         https://bugs.webkit.org/show_bug.cgi?id=66404
3771
3772         Reviewed by Dimitri Glazkov.
3773
3774         As requested by dglazkov.
3775
3776         * Scripts/webkitpy/tool/commands/prettydiff.py:
3777
3778 2011-08-17  Dmitry Lomov  <dslomov@google.com>
3779
3780         https://bugs.webkit.org/show_bug.cgi?id=66400
3781         Fix TestWebKitAPI build on Mac OS.
3782
3783         Reviewed by David Levin.
3784
3785         * TestWebKitAPI/Configurations/Base.xcconfig: Added ICU headers to the HEADER_SEARCH_PATH.
3786
3787 2011-08-17  Dimitri Glazkov  <dglazkov@chromium.org>
3788
3789         garden-o-matic spring cleaning: move scripts, styles, and images in the respective directories.
3790         https://bugs.webkit.org/show_bug.cgi?id=66427
3791
3792         Reviewed by Adam Barth.
3793
3794         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js: Removed.
3795         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js: Removed.
3796         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot_unittests.js: Removed.
3797         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js: Removed.
3798         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js: Removed.
3799         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js: Removed.
3800         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js: Removed.
3801         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js: Removed.
3802         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector_unittests.js: Removed.
3803         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm.js: Removed.
3804         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm_unittests.js: Removed.
3805         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js: Removed.
3806         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js: Removed.
3807         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NRWTResultsParser.js: Removed.
3808         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm.js: Removed.
3809         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm_unittests.js: Removed.
3810         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ORWTResultsParser.js: Removed.
3811         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/PersistentCache.js: Removed.
3812         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css: Removed.
3813         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm.js: Removed.
3814         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm_unittests.js: Removed.
3815         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js: Removed.
3816         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js: Removed.
3817         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities_unittests.js: Removed.
3818         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js: Removed.
3819         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBugzilla.js: Removed.
3820         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBuildbot.js: Removed.
3821         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Removed.
3822         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Removed.
3823         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/bugzilla_unittests.js: Removed.
3824         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js: Removed.
3825         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js: Removed.
3826         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js: Removed.
3827         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js: Removed.
3828         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js: Removed.
3829         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers: Removed.
3830         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.js: Removed.
3831         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers/rebaseline.js: Removed.
3832         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-green.png: Removed.
3833         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-red.png: Removed.
3834         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
3835         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images: Added.
3836         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-green.png: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-green.png.
3837         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-red.png: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-red.png.
3838         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html:
3839         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css: Removed.
3840         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js: Removed.
3841         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js: Removed.
3842         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js: Removed.
3843         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net.js: Removed.
3844         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js: Removed.
3845         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/rebaseline.html:
3846         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js: Removed.
3847         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js: Removed.
3848         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
3849         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Bugzilla.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js.
3850         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Buildbot.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js.
3851         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Buildbot_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot_unittests.js.
3852         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Builder.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js.
3853         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Builder_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js.
3854         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FailingTestsBugForm.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js.
3855         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FailingTestsBugForm_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js.
3856         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FlakyLayoutTestDetector.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js.
3857         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FlakyLayoutTestDetector_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector_unittests.js.
3858         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FlakyTestBugForm.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm.js.
3859         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FlakyTestBugForm_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm_unittests.js.
3860         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/LayoutTestHistoryAnalyzer.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js.
3861         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/LayoutTestResultsLoader.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js.
3862         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/NRWTResultsParser.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NRWTResultsParser.js.
3863         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/NewBugForm.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm.js.
3864         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/NewBugForm_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm_unittests.js.
3865         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ORWTResultsParser.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ORWTResultsParser.js.
3866         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/PersistentCache.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/PersistentCache.js.
3867         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/TestRelatedBugForm.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm.js.
3868         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/TestRelatedBugForm_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm_unittests.js.
3869         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Trac.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js.
3870         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Utilities.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js.
3871         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Utilities_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities_unittests.js.
3872         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js.
3873         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/WebKitBugzilla.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBugzilla.js.
3874         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/WebKitBuildbot.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBuildbot.js.
3875         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js.
3876         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js.
3877         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/bugzilla_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/bugzilla_unittests.js.
3878         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js.
3879         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js.
3880         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js.
3881         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js.
3882         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js.
3883         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.
3884         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.js.
3885         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/main.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js.
3886         ():
3887         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js.
3888         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js.
3889         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net.js.
3890         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js.
3891         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js.
3892         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js.
3893         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/trac_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js.
3894         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js.
3895         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results.js.
3896         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results_unittests.js.
3897         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js.
3898         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/unexpected-passes.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.js.
3899         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/TestFailures.css: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css.
3900         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/main.css: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css.
3901         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
3902         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js: Removed.
3903         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js: Removed.
3904         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results.js: Removed.
3905         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results_unittests.js: Removed.
3906         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js: Removed.
3907         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.html:
3908         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.js: Removed.
3909
3910 2011-08-17  Jochen Eisinger  <jochen@chromium.org>
3911
3912         Make SVNTest.test_svn_apply use the same timezone logic as VCSUtils.pm
3913         https://bugs.webkit.org/show_bug.cgi?id=65877
3914
3915         Reviewed by Eric Seidel.
3916
3917         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3918
3919 2011-08-17  Dimitri Glazkov  <dglazkov@chromium.org>
3920
3921         Remove base.keys and replace it with Object.keys.
3922         https://bugs.webkit.org/show_bug.cgi?id=66422
3923
3924         Reviewed by Adam Barth.
3925
3926         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Removed base.keys.
3927         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Removed unit tests for it.
3928         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js: Replaced with Object.keys
3929
3930 2011-08-17  Dimitri Glazkov  <dglazkov@chromium.org>
3931
3932         garden-o-matic Summary view should have items in descending chronological order.
3933         https://bugs.webkit.org/show_bug.cgi?id=66403
3934
3935         Reviewed by Adam Barth.
3936
3937         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Renamed "push" to "add" for clarity, cleaned up some stuff.
3938         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Rewrote add to insert DOM elements in order.
3939         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added unit tests.
3940
3941 2011-08-17  Dimitri Glazkov  <dglazkov@chromium.org>
3942
3943         Fix a few errors in garden-o-matic frontend unit tests.
3944         https://bugs.webkit.org/show_bug.cgi?id=66421
3945
3946         Reviewed by Adam Barth.
3947
3948         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Changed my excellent test to view time as variable continuum.
3949         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js: Tweaked the test to accommodate new builder names.
3950         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Hurriedly covered up my prior sins.
3951
3952 2011-08-17  Adam Barth  <abarth@webkit.org>
3953
3954         Update Tools to account for (CG) being added to Chromium builder names
3955         https://bugs.webkit.org/show_bug.cgi?id=66410
3956
3957         Reviewed by Adam Barth.
3958
3959         Some of these names will change back once we turn on Skia bots.
3960
3961         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js:
3962         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
3963         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
3964         * Scripts/webkitpy/layout_tests/port/builders.py:
3965         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3966         * TestResultServer/static-dashboards/builders.js:
3967         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
3968
3969 2011-08-16  Dimitri Glazkov  <dglazkov@chromium.org>
3970
3971         Wire up relative time to garden-o-matic summary view.
3972         https://bugs.webkit.org/show_bug.cgi?id=66343
3973
3974         Reviewed by Adam Barth.
3975
3976         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js: Add time to the commitData object. 
3977         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js: Adjusted unit tests.
3978         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Wired up relative date.
3979         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated unit tests.
3980         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js: Adjusted unit tests.
3981
3982 2011-08-17  Adam Roben  <aroben@apple.com>
3983
3984         Make run-api-tests run tests in alphabetical order
3985
3986         Fixes <http://webkit.org/b/66401> run-api-tests runs tests in a semi-random order
3987
3988         Reviewed by David Kilzer.
3989
3990         * Scripts/run-api-tests:
3991         (runAllTests):
3992         (runAllTestsInSuite):
3993         Sort the lists of tests and suites before iterating over them.
3994
3995 2011-08-17  Adam Barth  <abarth@webkit.org>
3996
3997         garden-o-matic should be able to rebaseline expected failures
3998         https://bugs.webkit.org/show_bug.cgi?id=66204
3999
4000         Reviewed by Dimitri Glazkov.
4001
4002         This patch introduces a new view for displaying expect, actual, and
4003         differences between results.  The new view also has a fledgling
4004         controller that handles some basic operations.  The new view is
4005         exercised by rebaseline.html, which lets you rebaselines expected
4006         failures, but the new view is not fully integrated into
4007         garden-o-matic.html
4008
4009         More patches will be required to make this stuff fully working, but
4010         this patch was already somewhat spiraling out of control.  Hopefully
4011         this patch will serve as a good starting point for further development.
4012
4013         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers: Added.
4014         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.js: Added.
4015         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers/rebaseline.js: Added.
4016         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
4017         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
4018         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
4019         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/rebaseline.html: Added.
4020         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
4021         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
4022         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
4023         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results.js:
4024         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results_unittests.js: Added.
4025
4026 2011-08-16  Chang Shu  <cshu@webkit.org>
4027
4028         Support reset in WebCore::Internals
4029         https://bugs.webkit.org/show_bug.cgi?id=66307
4030
4031         Reviewed by Dimitri Glazkov.
4032
4033         Added call to resetInternalsObject in DRT.
4034
4035         * DumpRenderTree/chromium/TestShell.cpp:
4036         (TestShell::resetTestController):
4037         * DumpRenderTree/mac/DumpRenderTree.mm:
4038         (resetWebViewToConsistentStateBeforeTesting):
4039         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4040         (WebCore::WebPage::resetSettings):
4041
4042 2011-08-17  Alexis Menard  <alexis.menard@openbossa.org>
4043
4044         Add a new build slave for the Qt port on Mac OS SnowLeopard.
4045         https://bugs.webkit.org/show_bug.cgi?id=66392
4046
4047         Modify the config file to include the new build slave.
4048
4049         Reviewed by Adam Roben.
4050
4051         * BuildSlaveSupport/build.webkit.org-config/config.json:
4052
4053 2011-08-17  Sam White  <samuel.white@rochester.edu>
4054
4055         AccessibilityObject levels are inconsistent
4056         https://bugs.webkit.org/show_bug.cgi?id=66180
4057         
4058         Added the ability to get numeric attribute values using numberAttributeValue. This
4059         function complements the existing stringAttributeValue and boolAttributeValue functions.
4060         The addition of numberAttributeValue was necessary because the stringAttributeValue
4061         function does a type check and will only return strings. This limitation made it
4062         impossible to get values for attributes that returned an NSNumber.
4063
4064         Reviewed by Chris Fleizach.
4065
4066         * DumpRenderTree/AccessibilityUIElement.cpp:
4067         (numberAttributeValueCallback):
4068         (AccessibilityUIElement::getJSClass):
4069         * DumpRenderTree/AccessibilityUIElement.h:
4070         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
4071         (AccessibilityUIElement::numberAttributeValue):
4072         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
4073         (AccessibilityUIElement::numberAttributeValue):
4074         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
4075         (AccessibilityUIElement::numberAttributeValue):
4076
4077 2011-08-17  Adam Roben  <aroben@apple.com>
4078
4079         Tell Trac logs always to display all specified revisions in a single page
4080
4081         Trac imposes a default limit of 100 revisions per log page. We need to tell it to allow more
4082         revisions than that.
4083
4084         Fixes <http://webkit.org/b/66373> Links to Trac from TestFailures page don't always show all
4085         relevant revisions
4086
4087         Reviewed by Daniel Bates.
4088
4089         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
4090         (trac.logURL): Add a limit parameter to the log URL that allows all revisions to be seen in
4091         a single page.
4092
4093         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js:
4094         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js:
4095         Updated tests for the above.
4096
4097 2011-08-17  Adam Roben  <aroben@apple.com>
4098
4099         Fix TestFailures's link to file a bug about TestFailures itself
4100
4101         Fixes <http://webkit.org/b/66387> REGRESSION (r92135): TestFailures page's link to file a
4102         bug about itself is broken
4103
4104         Reviewed by Dan Bates.
4105
4106         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
4107         (ViewController.prototype._domForAuxiliaryUIElements): Added a path separator to separate
4108         the host from the path.
4109
4110 2011-08-17  Adam Roben  <aroben@apple.com>
4111
4112         Teach TestFailures to ignore unbelievably short test runs
4113
4114         Fixes <http://webkit.org/b/66385> TestFailures page thinks all tests passed in
4115         http://build.webkit.org/builders/Windows%207%20Release%20(Tests)/builds/14956
4116
4117         Reviewed by Dan Bates.
4118
4119         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
4120         (Builder.prototype.getNumberOfFailingTests): If it looks like all tests passed, but
4121         run-webkit-tests took less than 10 seconds to run, assume that some weird error occurred
4122         that caused it not to run any tests at all (as happened for a while due to
4123         <http://webkit.org/b/64988>). Bumped the cache version to evict old, buggy cached data.
4124
4125         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:
4126         Test for the above.
4127
4128         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:
4129         (LayoutTestResultsLoader.prototype.start): Bumped the cache version to evict old, buggy cached data.
4130
4131 2011-08-16  Adam Barth  <abarth@webkit.org>
4132
4133         Add a CG qualifier similar to the GPU qualifier
4134         https://bugs.webkit.org/show_bug.cgi?id=66359
4135
4136         Reviewed by Eric Seidel.
4137
4138         Once we have a Skia configuration on Chromium Mac, we'll use this CG
4139         qualifier to note that expectations apply only to the CG configuration.
4140
4141         * Scripts/webkitpy/layout_tests/port/chromium.py:
4142         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
4143
4144 2011-08-16  Eric Seidel  <eric@webkit.org>
4145
4146         REGRESSION(92717): WinPort needs to parse version information from port_name
4147         https://bugs.webkit.org/show_bug.cgi?id=66325
4148
4149         Unreviewed.  Fixing an exception/typo seen on the bots (and testing to make sure it works).
4150
4151         * Scripts/webkitpy/layout_tests/port/mac.py:
4152         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
4153
4154 2011-08-16  Adam Barth  <abarth@webkit.org>
4155
4156         Change webkit-patch analyze-baselines to print in a more unix-friendly way
4157         https://bugs.webkit.org/show_bug.cgi?id=66349
4158
4159         Reviewed by James Robinson.
4160
4161         As requested by jamesr.
4162
4163         * Scripts/webkitpy/tool/commands/rebaseline.py:
4164
4165 2011-08-16  Eric Seidel  <eric@webkit.org>
4166
4167         REGRESSION(92717): WinPort needs to parse version information from port_name
4168         https://bugs.webkit.org/show_bug.cgi?id=66325
4169
4170         Reviewed by Adam Barth.
4171
4172         WinPort didn't have any port_name parsing logic.
4173         Seemed it was best to just share the logic from MacPort.
4174         Sharing the logic from MacPort seemed easiest with a shared superclass.
4175         Once I created ApplePort (the superclass) there was a bunch of logic to share.
4176         I found LeakDetector was just in the way when switching back and forth
4177         between win.py and mac.py so I moved it into its own file.
4178
4179         The only logic change here is that WinPort should now be
4180         able to parse port_name values like MacPort (and other ports)
4181         can.  The fact that ports do this in their constructors is
4182         wrong and a source of many bugs.  But at least now WinPort
4183         matches the status-quo.
4184
4185         * Scripts/webkitpy/layout_tests/port/apple.py: Added.
4186         * Scripts/webkitpy/layout_tests/port/leakdetector.py: Added.
4187         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py: Added.
4188         * Scripts/webkitpy/layout_tests/port/mac.py:
4189         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
4190         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
4191         * Scripts/webkitpy/layout_tests/port/win.py:
4192         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
4193
4194 2011-08-16  Adam Barth  <abarth@webkit.org>
4195
4196         Add webkit-patch analyze-baselines, as requested by jamesr.
4197
4198         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
4199         * Scripts/webkitpy/tool/commands/rebaseline.py:
4200
4201 2011-08-16  Adam Barth  <abarth@webkit.org>
4202
4203         Fold bulk-optimize-baselines into optimize-baselines
4204         https://bugs.webkit.org/show_bug.cgi?id=66345
4205
4206         Reviewed by James Robinson.
4207
4208         bulk-optimize-baselines is now a superset of optimize-baselines, so
4209         they can be combined.
4210
4211         * Scripts/webkitpy/tool/commands/rebaseline.py:
4212
4213 2011-08-16  Adam Barth  <abarth@webkit.org>
4214
4215         Move chromium-mac to chromium-cg-mac to prepare for Skia switchover
4216         https://bugs.webkit.org/show_bug.cgi?id=66334
4217
4218         Reviewed by Tony Chang.
4219
4220         This patch moves us closer to switching the Chromium port from
4221         CoreGraphics to Skia.  This patch teaches our tools that the current
4222         Chromium Mac configuration is actually chromium-cg-mac, which makes
4223         room for a future chromium-mac configuration that uses Skia.
4224
4225         Shortly after this patch lands, I'll do a server-side move of the
4226         chromium-mac and chromium-mac-leopard directories to chromium-cg-mac
4227         and chromium-cg-mac-leopard.
4228
4229         * BuildSlaveSupport/build.webkit.org-config/config.json:
4230         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
4231         * Scripts/webkitpy/common/config/build.py:
4232         * Scripts/webkitpy/common/config/build_unittest.py:
4233         * Scripts/webkitpy/layout_tests/port/base.py:
4234         * Scripts/webkitpy/layout_tests/port/builders.py:
4235         * Scripts/webkitpy/layout_tests/port/chromium.py:
4236         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
4237         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
4238         * Scripts/webkitpy/layout_tests/port/dryrun.py:
4239         * Scripts/webkitpy/layout_tests/port/factory.py:
4240         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
4241         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
4242         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: