e23579dbe9c6987aaf7f18fec4cf071e23b0694d
[WebKit-https.git] / Tools / ChangeLog
1 2011-06-16  Tommy Widenflycht  <tommyw@google.com>
2
3         Reviewed by Tony Gentilcore.
4
5         MediaStream API: Runtime enabled features
6         https://bugs.webkit.org/show_bug.cgi?id=62798
7
8         Add the WebRuntimeFeatures API for Media Streams and enable the feature by default in DumpRenderTree.
9
10         * DumpRenderTree/chromium/TestShell.cpp:
11         (TestShell::TestShell):
12
13 2011-06-16  Torsten Kurbad  <gentoo@tk-webart.de>
14
15         Reviewed by Eric Seidel.
16
17         Add support for sys.platform == 'linux3' by relaxing
18         conditional statements and/or extending lookup dicts.
19         This way, Linux kernels >=3.0-rc1 get supported in the
20         build process.
21         https://bugs.webkit.org/show_bug.cgi?id=62730
22
23         * Scripts/webkitpy/common/system/executive.py:
24         * Scripts/webkitpy/common/system/file_lock.py:
25         * Scripts/webkitpy/common/system/path_unittest.py:
26         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
27         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
28         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
29         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
30         * Scripts/webkitpy/layout_tests/port/factory.py:
31         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
32         * Scripts/webkitpy/layout_tests/port/qt.py:
33         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
34
35 2011-06-16  Sheriff Bot  <webkit.review.bot@gmail.com>
36
37         Unreviewed, rolling out r88796.
38         http://trac.webkit.org/changeset/88796
39         https://bugs.webkit.org/show_bug.cgi?id=62790
40
41         It made fast/dom/nodesFromRect-basic.html time out on Qt,
42         64-bit, debug mode (Requested by Ossy on #webkit).
43
44         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
45         (LayoutTestController::nodesFromRect):
46         * DumpRenderTree/qt/LayoutTestControllerQt.h:
47         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
48         (PlainTextController::plainText):
49         * DumpRenderTree/qt/PlainTextControllerQt.h:
50
51 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
52
53         Unreviewed, build fix.
54
55         Revert the patches in r88995 and r88999; the http servers don't
56         seem to be shutting down reliably.
57
58         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
59         * Scripts/webkitpy/layout_tests/port/base.py:
60         * Scripts/webkitpy/layout_tests/port/http_server.py:
61         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
62         * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Removed.
63         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
64         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
65
66 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
67
68         Unreviewed, build fix.
69
70         Add some debugging messages to triage problems introduced in
71         r88995.
72
73         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
74
75 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
76
77         Reviewed by Tony Chang.
78
79         nrwt: should clean up stale server processes from a previous run
80         https://bugs.webkit.org/show_bug.cgi?id=62615
81
82         This change fixes cases where NRWT might start a server and then
83         exit, leaving the server still running. Now NRWT should detect
84         this case and clean up on the next run, without shutting down
85         any processes it didn't start.
86
87         This change also fixes a bug in executive.kill_process on UNIX
88         where zombies weren't being handled properly.
89
90         * Scripts/webkitpy/common/system/executive.py:
91         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
92         * Scripts/webkitpy/layout_tests/port/base.py:
93         * Scripts/webkitpy/layout_tests/port/http_server.py:
94         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
95         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
96         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
97
98 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
99
100         Reviewed by Tony Chang.
101
102         nrwt: fix http, websocket server startup, shutdown
103         https://bugs.webkit.org/show_bug.cgi?id=62180
104
105         This change refactors all of the server-related code to
106         have consistent semantics. It pushes the start()/stop()
107         logic into the base class and adds four much smaller routines
108         for specialization:
109         _prepare_config() - for optionally writing config files etc.
110             to disk prior to starting the server
111         _remove_stale_log_files()
112         _spawn_process() - the actual launch of the subprocess
113         _cleanup_after_stop() - and custom cleanup code
114
115         Prior to this change the three server implementations were
116         fairly inconsistent, leading to lots of weirdness on the bots
117         with servers being left around, etc.
118
119         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
120         * Scripts/webkitpy/layout_tests/port/http_server.py:
121         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
122         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
123
124 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
125
126         Reviewed by Tony Chang.
127
128         webkitpy: clean up code prior to functional changes for server startup/shutdown
129         https://bugs.webkit.org/show_bug.cgi?id=62256
130
131         This patch does a bunch of minor cleanup of the code, but there
132         should be no functional changes except that all of the modules
133         will now use the same exception type. Other changes include
134         removing unused code paths and functions, pushing 'name' and
135         'pid_file' into the base class of the server objects, and using
136         the Filesystem object instead of the codecs, tempfile, and
137         shutils modules.
138
139         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
140         * Scripts/webkitpy/layout_tests/port/http_server.py:
141         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
142         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
143
144 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
145
146         Reviewed by Tony Chang.
147
148         webkitpy: add integration tests for new-run-webkit-httpd, stop calling shut_down_http_server
149         https://bugs.webkit.org/show_bug.cgi?id=62251
150
151         shut_down_http_server() was a total hack that was only used by
152         new-run-webkit-httpd, so I've moved the code there and switched
153         to using executive.kill_process() for the common case. The
154         method itself will be removed in the patch on bug 59993.
155
156         * Scripts/new-run-webkit-httpd:
157         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
158         * Scripts/webkitpy/layout_tests/port/http_server.py:
159         * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Added.
160         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
161
162 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
163
164         Unreviewed, build fix.
165
166         Fix test-webkitpy failure introduced in r88986.
167
168         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
169
170 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
171
172         Reviewed by Eric Seidel.
173
174         NRWT: doesn't support webarchives, has stale skipping logic.
175         https://bugs.webkit.org/show_bug.cgi?id=58293
176
177         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
178         * Scripts/webkitpy/layout_tests/port/base.py:
179         * Scripts/webkitpy/layout_tests/port/webkit.py:
180
181 2011-06-15  Jeremy Orlow  <jorlow@webkit.org>
182
183         Change my email to @webkit.org
184
185         * Scripts/webkitpy/common/config/committers.py:
186
187 2011-06-15  Nikolas Zimmermann  <nzimmermann@rim.com>
188
189         Reviewed by David Hyatt.
190
191         CSS 2.1: Support replaced elements with relative intrinsic sizes
192         https://bugs.webkit.org/show_bug.cgi?id=15849
193
194         CSS 2.1 failure: html4/replaced-intrinsic-ratio-001
195         https://bugs.webkit.org/show_bug.cgi?id=53099
196
197         Recognize *.htm tests in the old & new DRT implementation, needed for the vanilla css2.1 html4 tests.
198
199         * Scripts/old-run-webkit-tests:
200         * Scripts/webkitpy/layout_tests/port/test_files.py:
201
202 2011-06-15  Carlos Garcia Campos  <cgarcia@igalia.com>
203
204         Reviewed by Martin Robinson.
205
206         [GTK] Add a statusbar to MiniBrowser
207         https://bugs.webkit.org/show_bug.cgi?id=62634
208
209         It shows the url of the current hovered link.
210
211         * MiniBrowser/gtk/BrowserWindow.c:
212         (browserWindowConstructed): Create the GtkSatusbar.
213         (mouseDidMoveOverElement): Update statusbar text.
214         (browserWindowUIClientInit): Add implementation for
215         mouseDidMoveOverElement().
216         * MiniBrowser/gtk/GNUmakefile.am: Add new files to compilation.
217         * MiniBrowser/gtk/WebBundle/WebBundleMain.c: Added.
218         (mouseDidMoveOverElement): Pass the url of the current hovered
219         link to the UI process.
220         (didCreatePage): Set the UI client adding an implementation for
221         mouseDidMoveOverElement().
222         (WKBundleInitialize):
223         * MiniBrowser/gtk/main.c:
224         (createWKContextWithInjectedBundle): Create a global context with
225         the injected bundle.
226         (loadURI): Use the global context.
227         (main):
228
229 2011-06-14  Lucas Forschler  <lforschler@apple.com>
230
231         Reviewed by Stephanie Lewis.
232
233         https://bugs.webkit.org/show_bug.cgi?id=62495
234         Bug 62495 - combine windows and mac kill-old-processes script
235         Add a platform agnostic script.  Remove the recently added mac flavor.
236         Note: Leaving the windows one alone, since it is currently used by the WebKit bots.
237         
238         * BuildSlaveSupport/kill-old-processes: Added.
239         * BuildSlaveSupport/mac: Removed.
240         * BuildSlaveSupport/mac/kill-old-processes: Removed.
241
242 2011-06-14  Dirk Pranke  <dpranke@chromium.org>
243
244         Reviewed by Tony Chang.
245
246         nrwt: handle worker exceptions cleanly
247         https://bugs.webkit.org/show_bug.cgi?id=62614
248
249         This change modifiers new-run-webkit-tests to handle exceptions
250         raised by worker threads better, by:
251         - capturing the worker's stack and logging it in the manager
252         - propagating the worker's exception in the caller correctly
253         - attempting to cancel the workers and clean up even when
254           we get an unexpected exception
255
256         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
257         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
258         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
259         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
260
261 2011-06-14  Qi Zhang  <qi.2.zhang@nokia.com>
262
263         Reviewed by Laszlo Gombos.
264
265         [Qt] fast/dom/HTMLScriptElement/nested-execution.html failed
266         https://bugs.webkit.org/show_bug.cgi?id=62227
267
268         QtWebkit does not yet support different CacheModels. This change will 
269         expose setCacheModel() with a stub implementation, which is enough to pass the LayoutTest.
270
271         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
272         (LayoutTestController::setCacheModel):
273         * DumpRenderTree/qt/LayoutTestControllerQt.h:
274
275 2011-06-14  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
276
277         Reviewed by Andreas Kling.
278
279         [Qt] tst_QWebFrame::overloadedSlots() fails
280         https://bugs.webkit.org/show_bug.cgi?id=37319
281
282         Since we don't implictly convert 'document' object to QWebElement
283         in metacalls anymore, change the controller to expect QVariantMap instead.
284
285         The method plainText() was updated to use QVariantMap as well to let the bridge
286         do the conversion directly for us.
287
288         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
289         (LayoutTestController::nodesFromRect):
290         * DumpRenderTree/qt/LayoutTestControllerQt.h:
291         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
292         (PlainTextController::plainText):
293         * DumpRenderTree/qt/PlainTextControllerQt.h:
294
295 2011-06-14  Andras Becsi  <abecsi@webkit.org>
296
297         Reviewed by Csaba Osztrogonác.
298
299         Remove dead code in DumpRenderTree/TestNetscapePlugIn/main.cpp
300         https://bugs.webkit.org/show_bug.cgi?id=62630
301
302         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
303         (NPP_New): remove dead variable 'forceCarbon'
304
305 2011-06-13  Hayato Ito  <hayato@chromium.org>
306
307         Reviewed by Ojan Vafai.
308
309         [NRWT] Fix a WebKitDriver so that it returns an actual hash value if DRT returns that.
310         https://bugs.webkit.org/show_bug.cgi?id=59188
311
312         A current WebKitDriver doesn't try to return an actual hash value if DRT does not return an image.
313         WebKitDriver should always return an actual hash value if DRT returns that.
314
315         No tests since I'll add sample reftests to make sure mismatch reftests work later,
316         which should be in a separate patch.
317
318         * Scripts/webkitpy/layout_tests/port/webkit.py:
319
320 2011-06-13  Kent Tamura  <tkent@chromium.org>
321
322         [Chromium-win] Fix two wrong assertions exposed by r88757.
323
324         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
325         (WebThemeEngineDRTWin::paintTrackbar):
326
327 2011-06-13  Alexey Proskuryakov  <ap@apple.com>
328
329         Added an updated e-mail address for Matt Lilek, to make Bugzilla autocomplete
330         and commit queue happy.
331
332         * Scripts/webkitpy/common/config/committers.py:
333
334 2011-06-13  Chris Rogers  <crogers@google.com>
335
336         Unreviewed build fix.
337
338         Build fix to chromium DRT until we can rebaseline some tests
339         https://bugs.webkit.org/show_bug.cgi?id=62608
340
341         * DumpRenderTree/chromium/TestShell.cpp:
342         (TestShell::TestShell):
343
344 2011-06-13  Chris Rogers  <crogers@google.com>
345
346         Reviewed by Dirk Pranke.
347
348         Add Web Audio support to chromium DRT
349         https://bugs.webkit.org/show_bug.cgi?id=62306
350
351         * DumpRenderTree/chromium/LayoutTestController.cpp:
352         (LayoutTestController::LayoutTestController):
353         (LayoutTestController::reset):
354         (LayoutTestController::setEncodedAudioData):
355         * DumpRenderTree/chromium/LayoutTestController.h:
356         (LayoutTestController::encodedAudioData):
357         (LayoutTestController::shouldDumpAsAudio):
358         (LayoutTestController::setShouldDumpAsAudio):
359         * DumpRenderTree/chromium/TestEventPrinter.cpp:
360         (DRTPrinter::handleAudioHeader):
361         (TestShellPrinter::handleAudioHeader):
362         * DumpRenderTree/chromium/TestEventPrinter.h:
363         * DumpRenderTree/chromium/TestShell.cpp:
364         (TestShell::TestShell):
365         (TestShell::dump):
366
367 2011-06-13  Jaehun Lim  <ljaehun.lim@samsung.com>
368
369         Reviewed by Eric Seidel.
370
371         [EFL] Add load error handler to EWebLauncher
372         https://bugs.webkit.org/show_bug.cgi?id=62347
373
374         Add a handler function of "load,error" to EWebLauncher.
375         EWebLauncher now displays a simple error page on load errors.
376
377         * EWebLauncher/main.c:
378         (on_load_error):
379         (browserCreate):
380
381 2011-06-13  Martin Robinson  <mrobinson@igalia.com>
382
383         Reviewed by Eric Seidel.
384
385         [GTK] [Qt] Eliminate duplicate TestNetscapePlugin implementation
386         https://bugs.webkit.org/show_bug.cgi?id=62385
387
388         Remove duplicate TestNetscapePlugIn implementation. Having two copies
389         of this code makes keeping it in sync much more difficult. The files are
390         almost identical and this change ports the X11 changes to main.cpp.
391
392         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
393         (NPP_New): Do not set the plugin as windowless always. Doing this breaks
394         some results on Qt and this seems to be unnecessary for the moment.
395         (keyEventToChar): Added this helper which converts a X11 keycode into a char.
396         (handleEventX11): Use the handler to properly convert the keycode. Do not print
397         adjustCursorEvent output. The tests currently do not trigger this for Cocoa and thus
398         it should not be in the results.
399         (NPP_GetValue): Properly handle NPPVpluginNeedsXEmbed and make it clearer why the
400         XP_UNIX block is first by guarding against using a null instance.
401         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Update source list add
402         the XP_UNIX define for Linux.
403         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: Removed.
404         * GNUmakefile.am: Update source list.
405
406 2011-06-13  Sheriff Bot  <webkit.review.bot@gmail.com>
407
408         Unreviewed, rolling out r88671.
409         http://trac.webkit.org/changeset/88671
410         https://bugs.webkit.org/show_bug.cgi?id=62591
411
412         "didn't work" (Requested by dpranke on #webkit).
413
414         * Scripts/new-run-webkit-httpd:
415         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
416         * Scripts/webkitpy/layout_tests/port/http_server.py:
417         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
418         * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Removed.
419         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
420         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
421
422 2011-06-13  Nate Chapin  <japhet@chromium.org>
423
424         Reviewed by Darin Fisher.
425
426         New test method on TestNetscapePlugin for https://bugs.webkit.org/show_bug.cgi?id=61482.
427
428         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
429
430 2011-06-13  Dirk Pranke  <dpranke@chromium.org>
431
432         Reviewed by Tony Chang.
433
434         webkitpy: add integration tests for new-run-webkit-httpd, stop calling shut_down_http_server
435         https://bugs.webkit.org/show_bug.cgi?id=62251
436
437         shut_down_http_server() was a total hack that was only used by
438         new-run-webkit-httpd, so I've moved the code there and switched
439         to using executive.kill_process() for the common case. The
440         method itself will be removed in the patch on bug 59993.
441
442         * Scripts/new-run-webkit-httpd:
443         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
444         * Scripts/webkitpy/layout_tests/port/http_server.py:
445         * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Added.
446         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
447
448 2011-06-13  Tony Chang  <tony@chromium.org>
449
450         Reviewed by Dimitri Glazkov.
451
452         rename ENABLE_NEW_FLEXBOX to ENABLE_CSS3_FLEXBOX
453         https://bugs.webkit.org/show_bug.cgi?id=62578
454
455         * Scripts/build-webkit:
456
457 2011-06-13  Tony Chang  <tony@chromium.org>
458
459         Reviewed by Adam Barth.
460
461         rename ENABLE_FLEXBOX to ENABLE_NEW_FLEXBOX
462         https://bugs.webkit.org/show_bug.cgi?id=62545
463
464         * Scripts/build-webkit:
465
466 2011-06-13  Carlos Garcia Campos  <cgarcia@igalia.com>
467
468         Reviewed by Martin Robinson.
469
470         [GTK] Export an API similar to WebKit1
471         https://bugs.webkit.org/show_bug.cgi?id=57820
472
473         Build GtkLauncher2 for WebKit2. It's actually the same GtkLauncher
474         code, but linking to libwebkit2gtk.
475
476         * GNUmakefile.am:
477         * GtkLauncher/main.c:
478         (createBrowser):
479         (main):
480
481 2011-06-12  MORITA Hajime  <morrita@google.com>
482
483         Unreviewed, rolling out r88625.
484         http://trac.webkit.org/changeset/88625
485         https://bugs.webkit.org/show_bug.cgi?id=61073
486
487         Breaks SL Webkit2 Tests
488
489         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops:
490         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
491         * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops:
492         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
493         (WTR::InjectedBundlePage::didClearWindowForFrame):
494         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
495
496 2011-06-12  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
497
498         Reviewed by Antonio Gomes.
499
500         [Qt] LayoutTestController needs setTextDirection implementation
501         https://bugs.webkit.org/show_bug.cgi?id=62442
502
503         Implements LayoutController.setTextDirection.
504
505         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
506         (LayoutTestController::setTextDirection):
507         * DumpRenderTree/qt/LayoutTestControllerQt.h:
508
509 2011-06-12  Dominic Cooney  <dominicc@chromium.org>
510
511         Reviewed by Hajime Morita.
512
513         Add window.internals to WebKit2's WebKitTestRunner.
514         https://bugs.webkit.org/show_bug.cgi?id=61073
515
516         Test: fast/harness/internals-object.html
517
518         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops:
519         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
520         * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops:
521         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
522         (WTR::InjectedBundlePage::didClearWindowForFrame): initialize window.internals
523         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
524
525 2011-06-12  Sheriff Bot  <webkit.review.bot@gmail.com>
526
527         Unreviewed, rolling out r88616.
528         http://trac.webkit.org/changeset/88616
529         https://bugs.webkit.org/show_bug.cgi?id=62517
530
531         It broke editing/text-iterator/findString.html (Requested by
532         tonikitoo on #webkit).
533
534         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
535         * DumpRenderTree/qt/LayoutTestControllerQt.h:
536
537 2011-06-12  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
538
539         Reviewed by Antonio Gomes.
540
541         [Qt] LayoutTestController needs setTextDirection implementation
542         https://bugs.webkit.org/show_bug.cgi?id=62442
543
544         Implements LayoutController.setTextDirection.
545
546         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
547         (LayoutTestController::setTextDirection):
548         * DumpRenderTree/qt/LayoutTestControllerQt.h:
549
550 2011-06-10  Ryosuke Niwa  <rniwa@webkit.org>
551
552         Reviewed by Ojan Vafai.
553
554         new-run-webkit-tests: 'images' links on results.html don't work
555         https://bugs.webkit.org/show_bug.cgi?id=62194
556
557         Use relative path when generating images-diffs.html
558
559         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
560         Added _output_testname.
561
562 2011-06-10  Lucas Forschler  <lforschler@apple.com>
563
564         Reviewed by Stephanie Lewis.
565
566         Script to kill old processes on Mac.
567         This matches the windows version.
568         https://bugs.webkit.org/show_bug.cgi?id=62479  
569         
570         * BuildSlaveSupport/mac: Added.
571         * BuildSlaveSupport/mac/kill-old-processes: Added.
572
573 2011-06-10  Adam Barth  <abarth@webkit.org>
574
575         Reviewed by James Robinson.
576
577         When sheriffbot reports failures on IRC instead of saying "(and more..)" it should say the number of tests that are failing
578         https://bugs.webkit.org/show_bug.cgi?id=62489
579
580         * Scripts/webkitpy/tool/bot/sheriff.py:
581         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
582
583 2011-06-10  Tony Chang  <tony@chromium.org>
584
585         Reviewed by Ojan Vafai.
586
587         add a compile guard ENABLE(FLEXBOX)
588         https://bugs.webkit.org/show_bug.cgi?id=62049
589
590         * Scripts/build-webkit:
591
592 2011-06-10  Mark Rowe  <mrowe@apple.com>
593
594         Reviewed by Dimitri Glazkov.
595
596         <rdar://problem/9562114> Fix DumpRenderTree build for production configuration.
597
598         Ensure that DumpRenderTree can find libWebCoreTestSupport.dylib and the associated
599         header file.
600
601         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
602         * DumpRenderTree/mac/Configurations/Base.xcconfig:
603
604 2011-06-09  Csaba Osztrogonác  <ossy@webkit.org>
605
606         Unreviewed rolling out r88471, because it broke plugin tests on Qt.
607
608         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
609         (handleEventX11):
610         (NPP_GetValue):
611         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
612         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: Added.
613         (webkit_test_plugin_new_instance):
614         (webkit_test_plugin_destroy_instance):
615         (webkit_test_plugin_set_window):
616         (executeScript):
617         (webkit_test_plugin_new_stream):
618         (webkit_test_plugin_destroy_stream):
619         (webkit_test_plugin_stream_as_file):
620         (webkit_test_plugin_write_ready):
621         (webkit_test_plugin_write):
622         (webkit_test_plugin_print):
623         (keyEventToChar):
624         (webkit_test_plugin_handle_event):
625         (webkit_test_plugin_url_notify):
626         (webkit_test_plugin_get_value):
627         (webkit_test_plugin_set_value):
628         (NP_GetMIMEDescription):
629         (NP_Initialize):
630         (NP_Shutdown):
631         (NP_GetValue):
632         * GNUmakefile.am:
633
634 2011-06-09  Martin Robinson  <mrobinson@igalia.com>
635
636         Reviewed by Eric Seidel.
637
638         [GTK] Implement the next bit of the TextInputController (hasMarkedText and markedRange)
639         https://bugs.webkit.org/show_bug.cgi?id=55603
640
641         Add callbacks to support hasMarkedText and markedRange and also clean up existing 
642         TextInputController support.
643
644         * DumpRenderTree/gtk/TextInputController.cpp:
645         (setMarkedTextCallback): Accept parameters in terms of start and length, instead
646         of start and end. This matches the other ports. Do not use GLib style early returns.
647         (hasMarkedTextCallback): Added.
648         (markedRangeCallback): Added.
649         (insertTextCallback): Cleanup as described above.
650         (unmarkTextCallback): Cleanup as described above.
651         (firstRectForCharacterRangeCallback): Cleanup as described above.
652         (selectedRangeCallback): Cleanup as described above.
653
654 2011-06-09  Dirk Pranke  <dpranke@chromium.org>
655
656         Reviewed by Tony Chang.
657
658         nrwt: support webaudio in chromium driver
659         https://bugs.webkit.org/show_bug.cgi?id=62226
660
661         * Scripts/webkitpy/layout_tests/port/chromium.py:
662
663 2011-06-09  Dan Bernstein  <mitz@apple.com>
664
665         Reviewed by Anders Carlsson.
666
667         Added a test for Vector::reverse()
668         https://bugs.webkit.org/show_bug.cgi?id=62393
669
670         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
671         * TestWebKitAPI/Tests/WTF/VectorReverse.cpp: Added.
672         (TestWebKitAPI::TEST):
673         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
674
675 2011-06-09  Martin Robinson  <mrobinson@igalia.com>
676
677         Reviewed by Andreas Kling.
678
679         [GTK] [Qt] Eliminate duplicate TestNetscapePlugin implementation
680         https://bugs.webkit.org/show_bug.cgi?id=62385
681
682         Remove duplicate TestNetscapePlugIn implementation. Having two copies
683         of this code makes keeping it in sync much more difficult. The files are
684         almost identical and this change ports the X11 changes to main.cpp.
685
686         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
687         (keyEventToChar): Added this helper which converts a X11 keycode into a char.
688         (handleEventX11): Use the handler to properly convert the keycode. Do not print
689         adjustCursorEvent output. The tests currently do not trigger this for Cocoa and thus
690         it should not be in the results.
691         (NPP_GetValue): Properly handle NPPVpluginNeedsXEmbed.
692         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Update source list.
693         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: Removed.
694         * GNUmakefile.am: Update source list.
695
696 2011-06-09  Noel Gordon  <noel.gordon@gmail.com>
697
698         Reviewed by Tony Chang.
699
700         Test plugin should support event logging on the windows port.
701         https://bugs.webkit.org/show_bug.cgi?id=61721
702
703         The WebKit win port interprets a 0 return from plugin NPP_HandleEvent()
704         calls to mean the plugin handled the event.
705
706         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
707         (handleEventWin): Return 0 for each event on windows.
708
709 2011-06-09  Chang Shu  <cshu@webkit.org>
710
711         Reviewed by Andreas Kling.
712
713         [Qt] [WK2] Many editing tests failed on missing shouldBeginEditingInDOMRange:range printout
714         https://bugs.webkit.org/show_bug.cgi?id=62381
715
716         Activate QGraphicsScene and setFocus on QGraphicsItem to make sure the view has the focus.
717         QWKPagePrivate::isViewFocused() will check it later.
718
719         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
720         (WTR::PlatformWebView::PlatformWebView):
721
722 2011-06-09  Robert Hogan  <robert@webkit.org>
723
724         Reviewed by Andreas Kling.
725
726         Teach Qt about window.internals
727         https://bugs.webkit.org/show_bug.cgi?id=61074
728
729         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
730         (WebCore::DumpRenderTree::initJSObjects):
731
732 2011-06-09  Eric Seidel  <eric@webkit.org>
733
734         Reviewed by Adam Barth.
735
736         Disable running layout tests on Mac EWS bots (and fix cr-linux bots to run them again)
737         https://bugs.webkit.org/show_bug.cgi?id=62362
738
739         The mac bots are failing inspector tests.  We don't know why yet.
740         So for now, turning run-webkit-tests off for the mac-ews.
741
742         Also noticed that due to the wrong variable name the cr-linux
743         bots weren't running tests!
744
745         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
746
747 2011-06-09  Zoltan Herczeg  <zherczeg@inf.u-szeged.hu>
748
749         Reviewed by Csaba Osztrogonac.
750
751         [Qt][WK2] Canvas tests make css2.1 ones failing
752         https://bugs.webkit.org/show_bug.cgi?id=53427
753
754         Adding a workaround for this issue by mimicing the behaviour of DumpRenderTree.
755         Since the Qt port should eventually go to QRawFont, this issue will be resolved
756         in the future. Both clearMemoryCaches() and removeAllApplicationFonts() are
757         needed for the workaround.
758
759         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
760         (WTR::LayoutTestController::platformInitialize):
761
762 2011-06-09  Mario Sanchez Prada  <msanchez@igalia.com>
763
764         Reviewed by Chris Fleizach.
765
766         [GTK] Provide a way in DRT to check the platform name
767         https://bugs.webkit.org/show_bug.cgi?id=56855
768
769         Patch for adding 'platformName' static property to DRT's
770         LayoutController and provide platform specific implementations.
771
772         In principle, this feature will be only of interest for writing
773         accessibility tests, so that's why it's only implemented in the
774         Mac, Gtk and Win platforms.
775
776         * DumpRenderTree/LayoutTestController.h: New method platformName().
777         * DumpRenderTree/LayoutTestController.cpp:
778         (getPlatformNameCallback): New callback for 'platformName'.
779         (LayoutTestController::staticValues): New static property.
780
781         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
782         (LayoutTestController::platformName): Implemented.
783
784         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
785         (LayoutTestController::platformName): Implemented.
786
787         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
788         (LayoutTestController::platformName): Implemented.
789
790 2011-06-08  Mike Lawther  <mikelawther@chromium.org>
791
792         Reviewed by James Robinson.
793
794         Add mikelawther to committers.py
795         https://bugs.webkit.org/show_bug.cgi?id=62354
796
797         * Scripts/webkitpy/common/config/committers.py:
798
799 2011-06-08  Kent Tamura  <tkent@chromium.org>
800
801         [Chromium] Fix a typo.
802
803         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
804         (WebThemeControlDRTWin::draw):
805
806 2011-06-08  Kent Tamura  <tkent@chromium.org>
807
808         Reviewed by Hajime Morita.
809
810         [Chromium] Support vertical sliders in Windows DRT
811         https://bugs.webkit.org/show_bug.cgi?id=62352
812
813         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
814         (WebThemeControlDRTWin::draw):
815           Paint VerticalSliderThumbType and VerticalSliderTrackType.
816         * DumpRenderTree/chromium/WebThemeControlDRTWin.h:
817           Add VerticalSliderTrackType and VerticalSliderThumbType.
818         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
819         (WebThemeEngineDRTWin::paintTrackbar):
820           Convert Windows identifiers to the internal identifiers for vertical sliders.
821
822 2011-06-08  Ojan Vafai  <ojan@chromium.org>
823
824         Reviewed by Tony Chang.
825
826         add a short-flag for --experimental-fully-parallel
827         https://bugs.webkit.org/show_bug.cgi?id=62321
828
829         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
830
831 2011-06-08  Ryosuke Niwa  <rniwa@webkit.org>
832
833         Reviewed by Tony Chang.
834
835         new-run-webkit-tests: don't turn the tree red when there are new passes
836         https://bugs.webkit.org/show_bug.cgi?id=62311
837
838         Look for "new passes" instead of "passed unexpectedly" in evaluateCommand
839         to match commandComplete.
840
841         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
842
843 2011-06-08  Tom Hudson  <tomhudson@google.com>
844
845         Reviewed by Mihai Parparita.
846
847         Allow sorting in RebaselineServer based on 'metric' field in unexpected_results.json
848         https://bugs.webkit.org/show_bug.cgi?id=60964
849
850         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
851         Add 'Sort tests by metric' link.
852         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
853         (disableSorting): Activate 'Sort tests by metric' link.
854         (enableSorting): Deactivate 'Sort tests by metric' link.
855         (selectDirectory): Call enableSorting()/disableSorting() depending
856         on currently selected failure type, and sort tests if requested.
857         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
858         New .disabled-control class for deactivated links.
859
860 2011-06-08  Tom Sepez  <tsepez@chromium.org>
861
862         Reviewed by Adam Barth.
863
864         Add web permissions callbacks for mixed content blocking.
865         https://bugs.webkit.org/show_bug.cgi?id=61946
866
867         * DumpRenderTree/chromium/LayoutTestController.cpp:
868         (LayoutTestController::setAllowDisplayOfInsecureContent):
869         (LayoutTestController::setAllowRunningOfInsecureContent):
870         (LayoutTestController::overridePreference):
871         * DumpRenderTree/chromium/WebPermissions.cpp:
872         (WebPermissions::allowDisplayingInsecureContent):
873         (WebPermissions::allowRunningInsecureContent):
874         (WebPermissions::setDisplayingInsecureContentAllowed):
875         (WebPermissions::setRunningInsecureContentAllowed):
876         (WebPermissions::reset):
877         * DumpRenderTree/chromium/WebPermissions.h:
878
879 2011-06-08  Dirk Pranke  <dpranke@chromium.org>
880
881         Reviewed by Tony Chang.
882
883         webkitpy: fix typo causing us to skip the port unit tests in chromium_linux
884         https://bugs.webkit.org/show_bug.cgi?id=62259
885
886         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
887
888 2011-06-08  Ryosuke Niwa  <rniwa@webkit.org>
889
890         Reviewed by Tony Chang.
891
892         new-run-webkit-tests: master.cfg errors when nrwt successfully runs test
893         https://bugs.webkit.org/show_bug.cgi?id=62303
894
895         Access self.incorrectLayoutLines instead of incorrectLayoutLines in evaluateCommand.
896
897         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
898
899 2011-06-08  Greg Simon  <gregsimon@chromium.org>
900
901         Reviewed by Dimitri Glazkov.
902
903         Control Indexeddb backends from LayoutTestController
904         https://bugs.webkit.org/show_bug.cgi?id=61000
905
906         * DumpRenderTree/chromium/LayoutTestController.cpp:
907         (LayoutTestController::LayoutTestController):
908         (LayoutTestController::setOverrideIndexedDBBackingStore):
909         (LayoutTestController::clearAllDatabases):
910         * DumpRenderTree/chromium/LayoutTestController.h:
911
912 2011-06-08  Andreas Kling  <kling@webkit.org>
913
914         Add Pierre Rossi to contributors list for EZ-CC.
915
916         * Scripts/webkitpy/common/config/committers.py:
917
918 2011-06-08  Ilya Sherman  <isherman@chromium.org>
919
920         Reviewed by Andreas Kling.
921
922         Add Ilya Sherman to list of committers
923         https://bugs.webkit.org/show_bug.cgi?id=62270
924
925         * Scripts/webkitpy/common/config/committers.py:
926
927 2011-06-07  Ryosuke Niwa  <rniwa@webkit.org>
928
929         Reviewed by Tony Chang.
930
931         new-run-webkit-tests: Bot master should print useful information on waterfall/console for nrwt
932         https://bugs.webkit.org/show_bug.cgi?id=62178
933
934         Added commandComplete and evaluateCommand for NewRunWebKitTests class
935         to parse new-run-webkit-tests' results.
936
937         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
938
939 2011-06-07  Dirk Pranke  <dpranke@chromium.org>
940
941         Reviewed by Eric Seidel.
942
943         webkitpy: add a popen() call to executive
944         https://bugs.webkit.org/show_bug.cgi?id=62179
945
946         This change adds a popen() wrapper call to the Executive object.
947         This will allow other webkitpy scripts that currently call
948         subprocess directly to use Executive, instead.
949
950         No additional tests are necessary (the existing tests cover the code).
951
952         * Scripts/webkitpy/common/system/executive.py:
953
954 2011-06-07  Sam Weinig  <sam@webkit.org>
955
956         Reviewed by Anders Carlsson.
957
958         Remove repeated IPC traffic from SetRenderTreeSize message
959         https://bugs.webkit.org/show_bug.cgi?id=62244
960
961         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
962         (WTR::InjectedBundlePage::InjectedBundlePage):
963         Add stub for didLayoutForFrame.
964
965 2011-06-07  Dirk Pranke  <dpranke@chromium.org>
966
967         Reviewed by Tony Chang.
968
969         rebaseline-chromium-webkit-tests: fix baselining order for linux, linux_x86_64
970         https://bugs.webkit.org/show_bug.cgi?id=62241
971
972         * Scripts/webkitpy/layout_tests/port/chromium.py:
973
974 2011-06-07  Adam Barth  <abarth@webkit.org>
975
976         Rubber-stamped by Eric Seidel.
977
978         Enable tests on the mac-ews
979
980         When we bring the mac-ews back up, we're going to try running tests!
981
982         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
983
984 2011-06-07  Dmitry Lomov  <dslomov@google.com>
985
986         Reviewed by David Levin.
987
988         https://bugs.webkit.org/show_bug.cgi?id=62215
989         Allow comparisons with 0 in LIKELY and UNLIKELY macros.
990
991         * Scripts/webkitpy/style/checkers/cpp.py:
992         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
993
994 2011-06-07  Nico Weber  <thakis@chromium.org>
995
996         Reviewed by Dimitri Glazkov.
997
998         [chromium] -Wdelete-non-virtual-dtor pass for DumpRenderTree
999         https://bugs.webkit.org/show_bug.cgi?id=62210
1000
1001         The change to TestEventPrinter fixes a latent bug, because
1002         objects are deleted through the TestEventPrinter type, but none
1003         of the subclasses have destructors or non-POD members.
1004
1005         The changes to NotificationPresenter and WebViewHost do _not_ to fix a
1006         real bug, they just make clang's -Wdelete-non-virtual-dtor happy. As
1007         discussed at http://codereview.chromium.org/7094005/, we prefer making
1008         leaf class destructors virtual over making the leaf classes final.
1009
1010         * DumpRenderTree/chromium/NotificationPresenter.cpp:
1011         (NotificationPresenter::~NotificationPresenter):
1012         * DumpRenderTree/chromium/NotificationPresenter.h:
1013         * DumpRenderTree/chromium/TestEventPrinter.cpp:
1014         (TestEventPrinter::~TestEventPrinter):
1015         * DumpRenderTree/chromium/TestEventPrinter.h:
1016         * DumpRenderTree/chromium/WebViewHost.h:
1017
1018 2011-06-06  Ryosuke Niwa  <rniwa@webkit.org>
1019
1020         Reviewed by Dirk Pranke.
1021
1022         [chromium] Chromium bots on build.webkit.org don't upload results.html
1023         https://bugs.webkit.org/show_bug.cgi?id=61961
1024
1025         Don't fix the path on chromium port erroneously.
1026
1027         * BuildSlaveSupport/test-result-archive:
1028
1029 2011-06-06  Martin Robinson  <mrobinson@igalia.com>
1030
1031         Fix the GTK+ build by ensuring that the autogenerated sources
1032         necessary for libWebCoreInternals are recorded in a predeclared
1033         variable before assigning to BUILT_SOURCES.
1034
1035         * GNUmakefile.am: Predeclare libwebcoreinternals_built_sources.
1036
1037 2011-06-06  Yong Li  <yoli@rim.com>
1038
1039         Reviewed by Eric Seidel.
1040
1041         https://bugs.webkit.org/show_bug.cgi?id=62097
1042         Fix the problem that integral bitfield check incorrectly barked at ?: expressions.
1043
1044         * Scripts/webkitpy/style/checkers/cpp.py:
1045         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1046
1047 2011-06-06  Xan Lopez  <xlopez@igalia.com>
1048
1049         Reviewed by Martin Robinson.
1050
1051         [GTK] Enable feature/symbol detection in NWRT/GTK
1052         https://bugs.webkit.org/show_bug.cgi?id=62136
1053
1054         Disable feature detection through DRT, since we don't support it,
1055         and set the libwebcore patch correctly so that symbol detection
1056         through 'nm' works.
1057
1058         * Scripts/webkitpy/layout_tests/port/gtk.py:
1059
1060 2011-06-06  Shishir Agrawal  <shishir@chromium.org>
1061
1062         Reviewed by Tony Gentilcore.
1063
1064         Add a "prerender" state for page visibility.
1065         https://bugs.webkit.org/show_bug.cgi?id=62062
1066
1067         * DumpRenderTree/chromium/LayoutTestController.cpp:
1068         (LayoutTestController::setPageVisibility):
1069
1070 2011-06-06  Csaba Osztrogonác  <ossy@webkit.org>
1071
1072         [Qt] Implement download feature for QtTestBrowser
1073         https://bugs.webkit.org/show_bug.cgi?id=61865
1074
1075         Buildfix for --minimal and CONFIG+=qt_minimal build after r88161.
1076
1077         * QtTestBrowser/launcherwindow.cpp:
1078         (LauncherWindow::LauncherWindow):
1079         * QtTestBrowser/launcherwindow.h:
1080
1081 2011-06-06  Barát Tibor  <Barat.Tibor@stud.u-szeged.hu>
1082
1083         Reviewed by Csaba Osztrogonác.
1084
1085         [Qt] Implement download feature for QtTestBrowser
1086         https://bugs.webkit.org/show_bug.cgi?id=61865
1087
1088         * QtTestBrowser/launcherwindow.cpp:
1089         (LauncherWindow::LauncherWindow):
1090         (LauncherWindow::downloadRequest):
1091         (LauncherWindow::fileDownloadFinished):
1092         * QtTestBrowser/launcherwindow.h:
1093
1094 2011-06-04  Dominic Cooney  <dominicc@chromium.org>
1095
1096         Reviewed by Dimitri Glazkov.
1097
1098         Make DumpRenderTree initialize window.internals.
1099         https://bugs.webkit.org/show_bug.cgi?id=61076
1100
1101         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: link WebCoreTestSupport.
1102         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1103         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
1104
1105 2011-06-06  Alexandru Chiculita  <achicu@adobe.com>
1106
1107         Reviewed by Kent Tamura.
1108
1109         Add ENABLE_CSS_EXCLUSIONS support for build-webkit script
1110         https://bugs.webkit.org/show_bug.cgi?id=61628
1111
1112         * Scripts/build-webkit:
1113
1114 2011-06-06  Mihnea Ovidenie  <mihnea@adobe.com>
1115
1116         Reviewed by Kent Tamura.
1117
1118         Add ENABLE(CSS_REGIONS) guard for CSS Regions support
1119         https://bugs.webkit.org/show_bug.cgi?id=61631
1120
1121         * Scripts/build-webkit:
1122
1123 2011-06-06  Carlos Garcia Campos  <cgarcia@igalia.com>
1124
1125         Unreviewed. Fix the GTK+ build.
1126
1127         * GNUmakefile.am: Use javascriptcore_cflags when building libWebCoreInternals.
1128
1129 2011-06-05  Alexey Proskuryakov  <ap@apple.com>
1130
1131         Add an e-mail address for Cameron McCormack that matches Bugzilla (so that auto-completion
1132         works properly).
1133
1134         * Scripts/webkitpy/common/config/committers.py:
1135
1136 2011-06-04  Kevin Ollivier  <kevino@theolliviers.com>
1137
1138         [wx] Unreviewed build fix. Update git branch build dir handling to match what other
1139         WebKit scripts expect, so other scripts work properly with wx.
1140
1141         * waf/build/build_utils.py:
1142         * waf/build/settings.py:
1143
1144 2011-06-04  Kevin Ollivier  <kevino@theolliviers.com>
1145
1146         [wx] Unreviewed build fix. Restore the PPC build and allow users to specify architectures
1147         to build on Mac.
1148
1149         * waf/build/settings.py:
1150         * wx/install-unix-extras:
1151
1152 2011-06-04  Kevin Ollivier  <kevino@theolliviers.com>
1153
1154         [wx] Unreviewed build fixes for recent trunk changes.
1155
1156         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1157         (LayoutTestController::setTextDirection):
1158         * waf/build/settings.py:
1159
1160 2011-06-04  Martin Robinson  <mrobinson@igalia.com>
1161
1162         Fix the GTK+ build.
1163
1164         * GNUmakefile.am: Add some missing newline escape.
1165
1166 2011-06-03  Martin Robinson  <mrobinson@igalia.com>
1167
1168         Try to fix the GTK+ bulid.
1169
1170         * GNUmakefile.am: Add JSDOMWrapper.cpp to the libWebCoreInternals
1171         source list.
1172
1173 2011-06-03  Dirk Pranke  <dpranke@chromium.org>
1174
1175         Reviewed by Adam Barth.
1176
1177         nrwt: should skip chromium test expectation overrides on upstream bots
1178         https://bugs.webkit.org/show_bug.cgi?id=61888
1179
1180         * Scripts/webkitpy/layout_tests/port/chromium.py:
1181         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1182
1183 2011-06-03  Dirk Pranke  <dpranke@chromium.org>
1184
1185         Reviewed by Ojan Vafai.
1186
1187         new-run-webkit-tests: minor logging, code cleanup
1188         https://bugs.webkit.org/show_bug.cgi?id=62055
1189
1190         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
1191         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
1192
1193 2011-06-03  Martin Robinson  <mrobinson@igalia.com>
1194
1195         Try to fix the build failure on the GTK+ 32-bit Release bot.
1196
1197         * GNUmakefile.am: Add JSInternal.{cpp,h} to the BUILT_SOURCES list.
1198
1199 2011-05-31  Martin Robinson  <mrobinson@igalia.com>
1200
1201         Reviewed by Ryosuke Niwa.
1202
1203         [GTK] Support smart replace for the pasteboard
1204         https://bugs.webkit.org/show_bug.cgi?id=61734
1205
1206         Call into the DumpRenderTreeSupportGtk hooks to toggle smart replace.
1207         This is required to produce consistent test results.
1208
1209         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1210         (resetDefaultsToConsistentValues): Set the smart replace setting to on by default.
1211         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1212         (LayoutTestController::setSmartInsertDeleteEnabled): Added an implementation of this
1213         methods which calls into DumpRenderTreeSupportGtk.
1214
1215 2011-06-03  Martin Robinson  <mrobinson@igalia.com>
1216
1217         Reviewed by Dimitri Glazkov.
1218
1219         Teach Gtk build about window.internals
1220         https://bugs.webkit.org/show_bug.cgi?id=61071
1221
1222         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1223         (webViewWindowObjectCleared): Inject the new internals object when the
1224         window object clears.
1225         * GNUmakefile.am: Add new source files and includes necessary for window.internals.
1226         Also do a little bit of cleanup.
1227
1228 2011-06-03  Dirk Pranke  <dpranke@chromium.org>
1229
1230         Reviewed by Tony Chang.
1231
1232         Worker may not be stopped after LT.
1233         https://bugs.webkit.org/show_bug.cgi?id=61847
1234
1235         Re-submit a variant of the first fix for this bug. It's possible
1236         that actually calling cleanup() in the worker threads was taking
1237         too long and we triggered the assertions in the manager thread.
1238
1239         I've bumped up the timeout in the manager and added better
1240         diagnostics. I also cleaned up the cleanup() code a bit because
1241         there was some unnecessary if-checks.
1242
1243         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
1244         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
1245
1246 2011-06-03  Dirk Pranke  <dpranke@chromium.org>
1247
1248         Reviewed by Tony Chang.
1249
1250         nrwt: fix duplicate logging regression
1251         https://bugs.webkit.org/show_bug.cgi?id=61981
1252
1253         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1254
1255 2011-06-03  Robert Kroeger  <rjkroege@chromium.org>
1256
1257         Reviewed by Adam Barth.
1258
1259         Modified addTouchPoint to correctly re-use touchPoint id values starting
1260         from the lowest not-un-use touchPoint id as is done by the embedder
1261         APIs. (Fixes BUGCR36415)
1262
1263         https://bugs.webkit.org/show_bug.cgi?id=62016
1264
1265         * DumpRenderTree/chromium/EventSender.cpp:
1266         (EventSender::addTouchPoint):
1267
1268 2011-06-03  Cary Clark  <caryclark@google.com>
1269
1270         Reviewed by Eric Seidel.
1271
1272         Draw DRT scroll bar thumb with CG when WebKit renders with Skia
1273         https://bugs.webkit.org/show_bug.cgi?id=61534
1274
1275         Skia on Mac uses Skia to render WebKit, and CG
1276         to render UI elements. The CG elements need a
1277         transcribed graphics context that preserves the
1278         canvas matrix, and the canvas clip.
1279
1280         The SkiaBitLocker utility class sets up a CGContext
1281         from the SkCanvas, locks the bitmap's bits, and
1282         releases the lock when the class goes out of scope.
1283
1284         The SkiaBitLocker implementation is described by
1285         this patch:
1286         http://codereview.chromium.org/7031006/
1287
1288         When WebKit uses Skia for rendering, the WebCanvas
1289         is an SkCanvas. Create an equivalent CGContext to
1290         draw the scrollbar thumb.
1291
1292         As the Chrome Mac port does not yet use Skia, this
1293         patch has no effect and requires no tests.
1294
1295         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
1296         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
1297
1298 2011-06-03  Andras Becsi  <abecsi@webkit.org>
1299
1300         Unreviewed build fix.
1301
1302         Fix typo.
1303
1304         * Scripts/old-run-webkit-tests:
1305
1306 2011-06-03  Andras Becsi  <abecsi@webkit.org>
1307
1308         Reviewed by Csaba Osztrogonác.
1309
1310         Print error message when there is no httpd present on the system
1311         https://bugs.webkit.org/show_bug.cgi?id=61939
1312
1313         * Scripts/old-run-webkit-tests: Propose to run with --no-httpd.
1314         * Scripts/webkitperl/httpd.pm:
1315
1316 2011-06-03  Mikhail Naganov  <mnaganov@chromium.org>
1317
1318         Reviewed by Yury Semikhatsky.
1319
1320         Web Inspector: [Chromium] cpu-profiler-profiling layout test is flaky on Linux Debug.
1321         https://bugs.webkit.org/show_bug.cgi?id=61533
1322
1323         Skip cpu-profiler-profiling in debug, implement a fast headless alternative.
1324
1325         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
1326         (DRTDevToolsAgent::setJavaScriptProfilingEnabled):
1327         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
1328         * DumpRenderTree/chromium/LayoutTestController.cpp:
1329         (LayoutTestController::LayoutTestController):
1330         (LayoutTestController::setJavaScriptProfilingEnabled):
1331         * DumpRenderTree/chromium/LayoutTestController.h:
1332         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1333         (LayoutTestController::setJavaScriptProfilingEnabled):
1334         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1335         (WTR::LayoutTestController::setJavaScriptProfilingEnabled):
1336         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1337
1338 2011-06-02  Dirk Pranke  <dpranke@chromium.org>
1339
1340         Reviewed by Tony Chang.
1341
1342         NRWT needs a way to log to a file without including backspaces without needing --verbose
1343         https://bugs.webkit.org/show_bug.cgi?id=60328
1344
1345         This change modifies NRWT so that if it can tell if it is
1346         writing to a terminal, it will overwrite any messages printed
1347         in the 'one-line-progress' and 'updates' print options, and if
1348         not (or if --verbose was specified) the messages will be printed
1349         without backspaces.
1350
1351         If the overwriting updates are disabled, one-line-progress will
1352         only print every 10 seconds instead of on every update. This
1353         ensures that we still get updates once in a while while the
1354         tests are running, even if we're not in --verbose mode. Note
1355         that one-line-progress will now still be printed in --verbose,
1356         since it's useful as long as you're not flooded with the
1357         updates.
1358
1359         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
1360         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1361         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1362
1363 2011-06-02  Martin Robinson  <mrobinson@igalia.com>
1364
1365         Reviewed by Gustavo Noronha Silva.
1366
1367         [GTK] autogen.sh is run twice for each buld on the bots
1368         https://bugs.webkit.org/show_bug.cgi?id=61951
1369
1370         * Scripts/webkitdirs.pm: Only check the previous autotools arguments
1371         for the WebKit project. This prevents build-jsc runs from forcing subsequent
1372         build-webkit runs to re-rerun autogen.sh.
1373
1374 2011-06-02  Sheriff Bot  <webkit.review.bot@gmail.com>
1375
1376         Unreviewed, rolling out r87946.
1377         http://trac.webkit.org/changeset/87946
1378         https://bugs.webkit.org/show_bug.cgi?id=61965
1379
1380         Cause NRWT to break (Requested by abarth|gardener on #webkit).
1381
1382         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
1383
1384 2011-06-02  Dimitri Glazkov  <dglazkov@chromium.org>
1385
1386         Reviewed by Darin Adler.
1387
1388         Add build logistics and plumbing for window.internals object.
1389         https://bugs.webkit.org/show_bug.cgi?id=60313
1390
1391         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linking new WebCoreTestSupport library.
1392         * DumpRenderTree/chromium/TestShell.cpp:
1393         (TestShell::bindJSObjectsToWindow): Added injection code.
1394         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1395         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): Ditto.
1396
1397 2011-06-02  Hao Zheng  <zhenghao@chromium.org>
1398
1399         Reviewed by Dirk Pranke.
1400
1401         Call cleanup() explicitly at the end of worker.run().
1402         https://bugs.webkit.org/show_bug.cgi?id=61847
1403
1404         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
1405
1406 2011-06-02  Dimitri Glazkov  <dglazkov@chromium.org>
1407
1408         Unreviewed, rolling out r87926.
1409         http://trac.webkit.org/changeset/87926
1410         https://bugs.webkit.org/show_bug.cgi?id=60313
1411
1412         Fails to find WebCoreTestSupport.dylib on bots.
1413
1414         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1415         * DumpRenderTree/chromium/TestShell.cpp:
1416         (TestShell::bindJSObjectsToWindow):
1417         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1418         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
1419
1420 2011-05-21  Dimitri Glazkov  <dglazkov@chromium.org>
1421
1422         Reviewed by Darin Adler.
1423
1424         Add build logistics and plumbing for window.internals object.
1425         https://bugs.webkit.org/show_bug.cgi?id=60313
1426
1427         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linking new WebCoreTestSupport library.
1428         * DumpRenderTree/chromium/TestShell.cpp:
1429         (TestShell::bindJSObjectsToWindow): Added injection code.
1430         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1431         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): Ditto.
1432
1433 2011-06-02  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1434
1435         Reviewed by Eric Seidel.
1436
1437         Adjust efl coding style to more efl directories
1438         https://bugs.webkit.org/show_bug.cgi?id=61903
1439
1440         * Scripts/webkitpy/style/checker.py: Adjust efl coding style to efl directories.
1441
1442 2011-06-01  Dirk Pranke  <dpranke@chromium.org>
1443
1444         Reviewed by Tony Chang.
1445
1446         old-run-webkit-tests: add support for audio files
1447         https://bugs.webkit.org/show_bug.cgi?id=57992
1448
1449         * Scripts/old-run-webkit-tests:
1450
1451 2011-06-01  Jochen Eisinger  <jochen@chromium.org>
1452
1453         Reviewed by Adam Barth.
1454
1455         Implement layoutTestController.setImagesAllowed for controlling the respective behavior of the WebPermissionClient
1456         https://bugs.webkit.org/show_bug.cgi?id=34314
1457
1458         * DumpRenderTree/DumpRenderTree.gypi:
1459         * DumpRenderTree/chromium/LayoutTestController.cpp:
1460         (LayoutTestController::LayoutTestController):
1461         (LayoutTestController::setImagesAllowed):
1462         (LayoutTestController::setStorageAllowed):
1463         * DumpRenderTree/chromium/LayoutTestController.h:
1464         * DumpRenderTree/chromium/WebPermissions.cpp: Copied from Tools/DumpRenderTree/chromium/WebPermissions.h.
1465         (WebPermissions::WebPermissions):
1466         (WebPermissions::~WebPermissions):
1467         (WebPermissions::allowImages):
1468         (WebPermissions::allowStorage):
1469         (WebPermissions::setImagesAllowed):
1470         (WebPermissions::setStorageAllowed):
1471         (WebPermissions::reset):
1472         * DumpRenderTree/chromium/WebPermissions.h:
1473
1474 2011-06-01  Noel Gordon  <noel.gordon@gmail.com>
1475
1476         Reviewed by Tony Chang.
1477
1478         Test plugin should support event logging on the windows port.
1479         https://bugs.webkit.org/show_bug.cgi?id=61721
1480
1481         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1482         (handleEventWin): Well, handle them.
1483
1484 2011-06-01  Daniel Cheng  <dcheng@chromium.org>
1485
1486         Reviewed by Tony Chang.
1487
1488         [chromium] Use correct file name for dragging out images.
1489         https://bugs.webkit.org/show_bug.cgi?id=24887
1490
1491         * DumpRenderTree/chromium/EventSender.cpp:
1492         (EventSender::EventSender):
1493         (EventSender::dumpFilenameBeingDragged):
1494         * DumpRenderTree/chromium/EventSender.h:
1495
1496 2011-06-01  Dirk Pranke  <dpranke@chromium.org>
1497
1498         Reviewed by Tony Chang.
1499
1500         nrwt: make webaudio work w/o content-length header
1501         https://bugs.webkit.org/show_bug.cgi?id=61819
1502
1503         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1504         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
1505         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1506         * Scripts/webkitpy/layout_tests/port/webkit.py:
1507
1508 2011-06-01  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
1509
1510         Reviewed by Andreas Kling.
1511
1512         [Qt][WK2] Add QGLWidget viewport support to MiniBrowser
1513         https://bugs.webkit.org/show_bug.cgi?id=61802
1514
1515         Add command line parameter and menu item to MiniBrowser application 
1516         enabling use of QGLWidget for browser viewport.
1517
1518         * MiniBrowser/qt/BrowserWindow.cpp:
1519         (BrowserWindow::BrowserWindow):
1520         (BrowserWindow::toggleGLViewport):
1521         * MiniBrowser/qt/BrowserWindow.h:
1522         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1523         (MiniBrowserApplication::handleUserOptions):
1524         * MiniBrowser/qt/MiniBrowserApplication.h:
1525         (WindowOptions::WindowOptions):
1526
1527 2011-06-01  Martin Robinson  <mrobinson@igalia.com>
1528
1529         Reviewed by Xan Lopez.
1530
1531         Print out autogen arguments when they differ from the last set, to help
1532         with debugging build issues.
1533
1534         * Scripts/webkitdirs.pm: Print out previous and current build arguments
1535         when they differ.
1536
1537 2011-06-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1538
1539         Reviewed by Martin Robinson.
1540
1541         [GTK] run-launcher should run MiniBrowser in WebKit2
1542         https://bugs.webkit.org/show_bug.cgi?id=61858
1543
1544         * Scripts/run-launcher: Check whether -2 command line option has
1545         been passed and run MiniBrowser instead of GtkLauncher.
1546
1547 2011-05-31  Hao Zheng  <zhenghao@chromium.org>
1548
1549         Reviewed by Dirk Pranke.
1550
1551         Fix exception in verbose printing mode.
1552         https://bugs.webkit.org/show_bug.cgi?id=61723
1553
1554         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1555
1556 2011-05-31  Yong Li  <yoli@rim.com>
1557
1558         Reviewed by Eric Seidel.
1559
1560         https://bugs.webkit.org/show_bug.cgi?id=54807
1561         We have been assuming plain bitfields (like "int a : 31") are always signed integers.
1562         However some compilers can treat them as unsigned. For example, RVCT 4.0 states plain
1563         bitfields (declared without either signed or unsigned qualifiers) are treats as unsigned.
1564         http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0348c/Babjddhe.html
1565         Although we can use "--signed-bitfields" flag to make RVCT 4.0 behave as most other compilers,
1566         always using "signed"/"unsigned" qualifier to declare integral type bitfields is still a good
1567         rule we should have in order to make our code independent from compilers and compiler flags.
1568
1569         * Scripts/webkitpy/style/checkers/cpp.py:
1570
1571 2011-05-31  Hironori Bono  <hbono@chromium.org>
1572
1573         Reviewed by Eric Seidel.
1574
1575         Add a JavaScript function layoutTestController.setTextDirection().
1576         https://bugs.webkit.org/show_bug.cgi?id=50952
1577
1578         This change adds a new JavaScript function setTextDirection() to the
1579         LayoutTestController class of Safari and Chrome to write layout tests
1580         that changes the text direction of an editable element.
1581
1582         * DumpRenderTree/LayoutTestController.cpp:
1583         (setTextDirectionCallback):
1584         (LayoutTestController::staticFunctions):
1585         * DumpRenderTree/LayoutTestController.h:
1586         * DumpRenderTree/chromium/LayoutTestController.cpp:
1587         (LayoutTestController::LayoutTestController):
1588         (LayoutTestController::setTextDirection):
1589         * DumpRenderTree/chromium/LayoutTestController.h:
1590         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1591         (LayoutTestController::setTextDirection):
1592         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1593         (LayoutTestController::setTextDirection):
1594         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1595         (LayoutTestController::setTextDirection):
1596
1597 2011-05-31  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
1598
1599         Reviewed by Simon Hausmann.
1600
1601         [Qt] User-agent list of Qt test browsers is very outdated
1602         https://bugs.webkit.org/show_bug.cgi?id=61531
1603
1604         The user can edit the user-agent manually, so there's no need to have
1605         a super complete and up to date list, but it's nice to have it
1606         minimally updated.
1607
1608         * MiniBrowser/qt/useragentlist.txt:
1609         * QtTestBrowser/useragentlist.txt:
1610
1611 2011-03-30  Martin Robinson  <mrobinson@igalia.com>
1612
1613         Reviewed by Adam Roben.
1614
1615         [GTK] [WebKit2] Implement a basic WebKitTestRunner
1616         https://bugs.webkit.org/show_bug.cgi?id=57068
1617
1618         Add an implementation of WebKitTestRunner for GTK+.
1619
1620         * Scripts/build-webkittestrunner: Added knowledge of GTK+ TestRunner.
1621         * Scripts/old-run-webkit-tests: Ditto.
1622         * Scripts/run-launcher: Ditto.
1623         * Scripts/webkitdirs.pm: Ditto.
1624         * WebKitTestRunner/GNUmakefile.am: Added.
1625         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1626         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp: Added.
1627         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
1628         * WebKitTestRunner/InjectedBundle/gtk/LayoutTestControllerGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
1629         * WebKitTestRunner/PlatformWebView.h:
1630         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp: Added.
1631         * WebKitTestRunner/gtk/TestControllerGtk.cpp: Added.
1632         * WebKitTestRunner/gtk/TestInvocationGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
1633         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1634         * WebKitTestRunner/gtk/main.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
1635         (main): Added.
1636
1637 2011-05-31  Dirk Pranke  <dpranke@chromium.org>
1638
1639         Reviewed by Tony Chang.
1640
1641         new-run-webkit-tests: doesn't wait for children if it gets a ctrl-c
1642         https://bugs.webkit.org/show_bug.cgi?id=60241
1643
1644         * Scripts/new-run-webkit-tests:
1645
1646 2011-05-31  Eric Seidel  <eric@webkit.org>
1647
1648         Reviewed by David Kilzer.
1649
1650         webkitpy should create zips with zip -9
1651         https://bugs.webkit.org/show_bug.cgi?id=61789
1652
1653         Dave Kilzer suggested we add this to make zips uploaded to bugzilla smaller.
1654
1655         * Scripts/webkitpy/common/system/workspace.py:
1656         * Scripts/webkitpy/common/system/workspace_unittest.py:
1657
1658 2011-05-31  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
1659
1660         Reviewed by Csaba Osztrogonác.
1661
1662         [Qt] Implement find feature for QtTestBrowser
1663         https://bugs.webkit.org/show_bug.cgi?id=61425
1664
1665         Buildfix for --minimal and CONFIG+=qt_minimal build.
1666
1667         * QtTestBrowser/launcherwindow.cpp:
1668         (LauncherWindow::LauncherWindow):
1669         (LauncherWindow::createChrome):
1670         * QtTestBrowser/launcherwindow.h:
1671
1672 2011-05-31  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
1673
1674         Reviewed by Csaba Osztrogonác.
1675
1676         [Qt] Implement find feature for QtTestBrowser
1677         https://bugs.webkit.org/show_bug.cgi?id=61425
1678
1679         * QtTestBrowser/launcherwindow.cpp:
1680         (LauncherWindow::LauncherWindow):
1681         (LauncherWindow::createChrome):
1682         (LauncherWindow::showFindBar):
1683         (LauncherWindow::find):
1684         * QtTestBrowser/launcherwindow.h:
1685
1686 2011-05-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1687
1688         Reviewed by Martin Robinson.
1689
1690         [GTK] Implement JavaScript dialogs in MiniBrowser
1691         https://bugs.webkit.org/show_bug.cgi?id=61725
1692
1693         * MiniBrowser/gtk/BrowserWindow.c:
1694         (WKStringGetCString): Helper function to get a UTF-8 c string from
1695         a WKStringRef.
1696         (WKURLGetCString): Helper function to get a UTF-8 c string from a
1697         WKURLRef.
1698         (browserWindowUpdateURL): Update to use WKURLGetCString.
1699         (didReceiveTitleForFrame): Update to use WKStringGetCString.
1700         (createMessageDialog): Create a GtkMessageDialog.
1701         (runJavaScriptAlert):
1702         (runJavaScriptConfirm):
1703         (runJavaScriptPrompt):
1704         (browserWindowUIClientInit):
1705
1706 2011-05-29  Yuta Kitamura  <yutak@chromium.org>
1707
1708         Reviewed by Kent Tamura.
1709
1710         WebSocket closing handshake
1711         https://bugs.webkit.org/show_bug.cgi?id=35721
1712
1713         * Scripts/webkitpy/thirdparty/__init__.py:
1714         Pull in pywebsocket 0.6b1. We need to update pywebsocket
1715         to get the right behavior of closing handshake.
1716
1717 2011-05-29  Daniel Bates  <dbates@rim.com>
1718
1719         Reviewed by David Kilzer.
1720
1721         REGRESSION (r86515): svn-apply ignores diffs that omit line count in chunk range
1722         https://bugs.webkit.org/show_bug.cgi?id=61162
1723
1724         Fixes an issue where svn-apply may ignore a diff that contains a chunk range line
1725         that omits a line count. In particular, the chunk range regular expression does
1726         not match a chunk range line that omits a line count. GNU diff(1) will omit the
1727         line count in the chunk range if the line count is exactly 1. For example, appending
1728         a new line to the end of an existing file F that contains exactly one line of text will
1729         be represented in a diff with a chunk range line that omits the line count for F.
1730
1731         * Scripts/VCSUtils.pm:
1732           (parseChunkRange): Added.
1733         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl: Added.
1734         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
1735           - Added unit test "Git: Append new line to the end of an existing file".
1736
1737 2011-05-28  Adam Barth  <abarth@webkit.org>
1738
1739         Reviewed by Eric Seidel.
1740
1741         EWS builds patches that fail to build twice, which seems useless and slows down the bots
1742         https://bugs.webkit.org/show_bug.cgi?id=55585
1743
1744         This patch switches all the early warning system bots over to the new
1745         PatchAnalysisTask-based infrastructure.  This patch makes these bots
1746         more efficient (in the case where patches fail to build) and paves the
1747         way for running tests on these bots!
1748
1749         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1750         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
1751         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1752         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1753         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1754         * Scripts/webkitpy/tool/commands/queues.py:
1755
1756 2011-05-28  Kenichi Ishibashi  <bashi@chromium.org>
1757
1758         Reviewed by Kent Tamura.
1759
1760         Add bashi as a committer.
1761
1762         https://bugs.webkit.org/show_bug.cgi?id=61685
1763
1764         * Scripts/webkitpy/common/config/committers.py:
1765
1766 2011-05-27  Adam Barth  <abarth@webkit.org>
1767
1768         Reviewed by Eric Seidel.
1769
1770         When checking whether the tree is red, the EWS posts a link to the wrong log
1771         https://bugs.webkit.org/show_bug.cgi?id=61072
1772
1773         We need to cache the original script error because that contains the
1774         failure log we want to upload.  If we don't cache that script error,
1775         self._script_error will get overwritten when we sanity check the clean
1776         tree (and it also has test failures).
1777
1778         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1779             - This testing approach is slightly goofy.  We'd like to use
1780               assertRaisesRegexp, but that's not available until Python 2.7.
1781         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1782
1783 2011-05-27  Jochen Eisinger  <jochen@chromium.org>
1784
1785         Reviewed by Adam Barth.
1786
1787         Add layoutTestController.setStorageAllowed() to control whether access
1788         to the localStorage API is enabled via the WebPermissionClient
1789         https://bugs.webkit.org/show_bug.cgi?id=61581
1790
1791         * DumpRenderTree/chromium/LayoutTestController.cpp:
1792         (LayoutTestController::LayoutTestController):
1793         (LayoutTestController::setStorageAllowed):
1794         * DumpRenderTree/chromium/LayoutTestController.h:
1795         * DumpRenderTree/chromium/TestShell.cpp:
1796         (TestShell::TestShell):
1797         (TestShell::createNewWindow):
1798         * DumpRenderTree/chromium/TestShell.h:
1799         * DumpRenderTree/chromium/WebPermissions.h: Added.
1800         (WebPermissions::WebPermissions):
1801         (WebPermissions::allowStorage):
1802         (WebPermissions::setStorageAllowed):
1803         (WebPermissions::reset):
1804
1805 2011-05-27  Dirk Pranke  <dpranke@chromium.org>
1806
1807         Reviewed by Eric Seidel.
1808
1809         NRWT: clean up metered_stream code in preparation for 'nooverwriting' patch
1810         https://bugs.webkit.org/show_bug.cgi?id=60326
1811
1812         This patch removes a lot of the complexity from the
1813         metered_stream implementation that was unnecessary since there
1814         was only one caller and the logic could be coordinated better.
1815
1816         There should be no functional changes in this patch, just code
1817         getting deleted and cleaned up.
1818
1819         * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
1820         * Scripts/webkitpy/layout_tests/layout_package/metered_stream_unittest.py:
1821         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1822         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1823
1824 2011-05-27  Dirk Pranke  <dpranke@chromium.org>
1825
1826         Reviewed by Eric Seidel.
1827
1828         NRWT: minor cleanup in printing module
1829         https://bugs.webkit.org/show_bug.cgi?id=60329
1830
1831         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1832
1833 2011-05-27  Steve Lacey  <sjl@chromium.org>
1834
1835         Reviewed by David Levin.
1836
1837         Add sjl@chromium.org as a committer.
1838
1839         https://bugs.webkit.org/show_bug.cgi?id=61672
1840
1841         * Scripts/webkitpy/common/config/committers.py:
1842
1843 2011-05-27  Dirk Pranke  <dpranke@chromium.org>
1844
1845         Reviewed by Adam Barth.
1846
1847         NRWT: remove --print detailed-progress
1848         https://bugs.webkit.org/show_bug.cgi?id=60324
1849
1850         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
1851         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1852         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1853         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1854
1855 2011-05-27  Dirk Pranke  <dpranke@chromium.org>
1856
1857         Reviewed by Ojan Vafai.
1858
1859         NRWT: debug messages from the workers are being logged twice
1860         https://bugs.webkit.org/show_bug.cgi?id=60428
1861
1862         It looks like when the workers are run in separate processes
1863         we end up getting two copies of every log message they print.
1864         This has to do with the multiprocessing module on UNIX cloning
1865         the log configuration in a way I wasn't expecting, and so two
1866         log handlers end up getting registered.
1867
1868         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
1869         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1870         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1871         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1872
1873 2011-05-27  Adam Roben  <aroben@apple.com>
1874
1875         Always decode tester names from location.hash
1876
1877         When navigating directly to a tester-specific URL (e.g.,
1878         <http://build.webkit.org/TestFailures/#/Windows%207%20Release%20(Tests)>), you could end up
1879         with a URL-encoded tester name in the page, and then the encoded name could make its way
1880         into Bugzilla bugs. Bad!
1881
1882         Reviewed by David Kilzer.
1883
1884         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1885         (ViewController.prototype.parseHash): Pass the tester name we got from location.hash through
1886         decodeURIComponent before trying to use it.
1887
1888 2011-05-27  Adam Roben  <aroben@apple.com>
1889
1890         Remove testing code that snuck into r87528
1891
1892         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1893         (ViewController.prototype._domForNewBugLink): Remove a line I was using for some testing.
1894
1895 2011-05-27  Adam Roben  <aroben@apple.com>
1896
1897         Add links to TestFailures to easily file bugs about failing tests
1898
1899         Fixes <http://webkit.org/b/61636> <rdar://problem/9514886> TestFailures page should have
1900         links to file bugs for failing tests
1901
1902         Reviewed by David Kilzer.
1903
1904         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
1905         (Builder.prototype.resultsPageURL): New helper function to return the URL to results.html
1906         for a particular build.
1907         (Builder.prototype._getFailingTests): Use resultsPageURL.
1908
1909         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1910         (ViewController.prototype._displayBuilder): Add links to file bugs about each set of
1911         failures.
1912         (ViewController.prototype._domForBuildName): Use resultsPageURL.
1913         (ViewController.prototype._domForNewBugLink): Added. Creates an element that represents the
1914         new bug link. The bug has a title, description, and URL already filled in for you!
1915
1916 2011-05-27  Sheriff Bot  <webkit.review.bot@gmail.com>
1917
1918         Unreviewed, rolling out r87464.
1919         http://trac.webkit.org/changeset/87464
1920         https://bugs.webkit.org/show_bug.cgi?id=61643
1921
1922         client-close/server-close tests are flaky on Chromium Mac and
1923         Windows (Requested by aklein on #webkit).
1924
1925         * Scripts/webkitpy/thirdparty/__init__.py:
1926
1927 2011-05-27  Alexey Proskuryakov  <ap@apple.com>
1928
1929         Added Douglas Davidson to contributors list for easier CC'ing.
1930
1931         * Scripts/webkitpy/common/config/committers.py:
1932
1933 2011-05-26  Mihai Parparita  <mihaip@chromium.org>
1934
1935         Reviewed by Adam Barth.
1936
1937         Fix worldID and destinationDomain argument names
1938         https://bugs.webkit.org/show_bug.cgi?id=61571
1939
1940         As part of working on r87423, I noticed a couple of inconsistencies in
1941         argument names:
1942         - We would use worldId in .h files but worldID in .cpp files.
1943           Standardize on the latter
1944         - SecurityOrigin::addOriginAccessWhitelistEntry would take a
1945           destinationDomains argument, even though the actual parameter was for
1946           a single domain (renamed to be singular).
1947
1948         * DumpRenderTree/LayoutTestController.h:
1949         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1950         (LayoutTestController::evaluateScriptInIsolatedWorld):
1951
1952 2011-05-26  Yuta Kitamura  <yutak@chromium.org>
1953
1954         Reviewed by Kent Tamura.
1955
1956         WebSocket closing handshake
1957         https://bugs.webkit.org/show_bug.cgi?id=35721
1958
1959         * Scripts/webkitpy/thirdparty/__init__.py:
1960         Pull in pywebsocket 0.6b1. We need to update pywebsocket
1961         to get the right behavior of closing handshake.
1962
1963 2011-05-26  Qi Zhang  <qi.2.zhang@nokia.com>
1964
1965         Reviewed by Andreas Kling.
1966
1967         WebKitTestRunner needs layoutTestController.setAuthorAndUserStylesEnabled
1968         https://bugs.webkit.org/show_bug.cgi?id=42676
1969
1970         Implemented layoutTestController.setAuthorAndUserStylesEnabled for WebKitTestRunner.
1971
1972         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1973         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1974         (WTR::InjectedBundle::beginTesting):
1975         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1976         (WTR::LayoutTestController::setAuthorAndUserStylesEnabled):
1977         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1978
1979 2011-05-26  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>
1980
1981         Reviewed by Andreas Kling.
1982
1983         [Qt] QtTestBrowser "Switch User Agent" dialog is broken
1984         https://bugs.webkit.org/show_bug.cgi?id=61527
1985
1986         The setMaximumHeight() call is unecessary and breaks the dialog at
1987         least on my setup.
1988
1989         * QtTestBrowser/launcherwindow.cpp:
1990         (LauncherWindow::showUserAgentDialog):
1991
1992 2011-05-02  Robert Hogan  <robert@webkit.org>
1993
1994         Reviewed by Adam Roben.
1995
1996         [Qt] Allow popup windows from plugins when initiated by a user gesture
1997
1998         https://bugs.webkit.org/show_bug.cgi?id=41292
1999
2000         Support parameters introduced in plugin-initiate-popup-window.html
2001
2002         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2003         (webkit_test_plugin_new_instance):
2004         (webkit_test_plugin_handle_event):
2005
2006 2011-05-26  Mihai Parparita  <mihaip@chromium.org>
2007
2008         Reviewed by Adam Barth.
2009
2010         Support cross-origin XMLHttpRequest in isolated worlds
2011         https://bugs.webkit.org/show_bug.cgi?id=59843
2012
2013         Expose setIsolatedWorldSecurityOrigin in LayoutTestController.
2014
2015         * DumpRenderTree/chromium/LayoutTestController.cpp:
2016         (LayoutTestController::LayoutTestController):
2017         (LayoutTestController::setIsolatedWorldSecurityOrigin):
2018         * DumpRenderTree/chromium/LayoutTestController.h:
2019
2020 2011-05-25  Brian Weinstein  <bweinstein@apple.com>
2021
2022         Reviewed by Adam Roben.
2023
2024         WebKit2: Status bar, toolbar, and menu bar checks should be in the injected bundle
2025         https://bugs.webkit.org/show_bug.cgi?id=61474
2026         <rdar://problem/9468337>
2027
2028         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2029         (WTR::InjectedBundlePage::InjectedBundlePage): Add empty entries in the WKBundlePageUIClient.
2030
2031 2011-05-26  Andreas Kling  <kling@webkit.org>
2032
2033         Unreviewed, correct address to webkit-committers mailing list.
2034
2035         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2036
2037 2011-05-25  Adam Roben  <aroben@apple.com>
2038
2039         Don't assume that builds finish in the order they were started
2040
2041         Fixes <http://webkit.org/b/61464> TestFailures page shows failures from a not-most-recent
2042         build when one slave is taking a long time to finish a build
2043
2044         Reviewed by Antti Koivisto.
2045
2046         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
2047         (Builder.prototype.getMostRecentCompletedBuildNumber): Don't assume that all builds that are
2048         newer than the oldest in-progress build are also themselves in progress. Just check whether
2049         each build is actually in progress (as signified by its presence in the currentBuilds set).
2050
2051 2011-05-25  Adam Roben  <aroben@apple.com>
2052
2053         Correctly detect cases where only a single test failed/crashed/timed out
2054
2055         Fixes <http://webkit.org/b/61463> TestFailures page doesn't show testers with only a single
2056         failing test
2057
2058         Reviewed by Darin Adler.
2059
2060         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
2061         (Builder.prototype.getNumberOfFailingTests): Don't require "test cases" to be plural. It
2062         will be singular when only a single test fails/crashes/times out.
2063
2064         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
2065         (ViewController.prototype._displayTesters): Only pluralize "test" when more than one test
2066         failed/crashed/timed out.
2067
2068 2011-05-26  Tom Hudson  <tomhudson@google.com>
2069
2070         Reviewed by Tony Chang.
2071
2072         Add flags to Chromium ImageDiff to write image comparison metrics on
2073         stdout.
2074         https://bugs.webkit.org/show_bug.cgi?id=60569
2075
2076         * DumpRenderTree/chromium/ImageDiff.cpp:
2077         (Image::createFromStdin): Fix spelling.
2078         (maxOf3): New function to do 3-way maximum.
2079         (getRedComponent): Extract red component from ABGR packed encoding.
2080         (getGreenComponent): Extract green component from ABGR packed encoding.
2081         (getBlueComponent): Extract blue component from ABGR packed encoding.
2082         (weightedPercentageDifferent): Determine % of pixels different in two
2083         images multiplied by intensity difference of each pixel.
2084         (printHelp): Document new arguments.
2085         (compareImages): Parameterize.
2086         (untestedCompareImages): Parameterize.
2087         (diffImages): Parameterize; write results on stdout if requested.
2088         (main): Parse new arguments.
2089
2090 2011-05-25  Qi Zhang  <qi.2.zhang@nokia.com>
2091
2092         Reviewed by Simon Hausmann.
2093
2094         WebKitTestRunner needs layoutTestController.setPrivateBrowsingEnabled
2095         https://bugs.webkit.org/show_bug.cgi?id=42697
2096
2097         Implemented layoutTestController.setPrivateBrowsingEnabled for WebKitTestRunner.
2098
2099         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2100         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2101         (WTR::InjectedBundle::beginTesting):
2102         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2103         (WTR::LayoutTestController::setPrivateBrowsingEnabled):
2104         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2105
2106 2011-05-25  Jon Honeycutt  <jhoneycutt@apple.com>
2107
2108         REGRESSION (WebKit2): Crash in Flash on USA Today photo gallery
2109         https://bugs.webkit.org/show_bug.cgi?id=61428
2110         <rdar://problem/9457006>
2111
2112         Reviewed by Adam Roben.
2113
2114         The crash occurs when Flash posts a message to a window that it
2115         creates, and in processing the message, it calls NPN_Evaluate to
2116         evaluate JavaScript that removes the plug-in from the page. Flash then
2117         crashes when we return to Flash code.
2118
2119         This test emulates that behavior.
2120
2121         * DumpRenderTree/TestNetscapePlugIn/win/CallJSThatDestroysPlugin.cpp: Added.
2122         (CallJSThatDestroysPlugin::CallJSThatDestroysPlugin):
2123         Initialize member vars.
2124         (CallJSThatDestroysPlugin::~CallJSThatDestroysPlugin):
2125         Remove our custom property from the message window, and destroy it.
2126         (CallJSThatDestroysPlugin::NPP_Destroy):
2127         Set m_isDestroyed, log that the plug-in was destroyed, and notify the
2128         layout test controller that we're done.
2129         (wndProc):
2130         Get the PluginTest object, and call its runTest() function.
2131         (CallJSThatDestroysPlugin::NPP_New):
2132         Setup the test: register a class for the message-only window, create
2133         it, and post a message to it to run the test.
2134         (CallJSThatDestroysPlugin::runTest):
2135         Execute JS that removes the plug-in from the page, and if we're not
2136         destroyed, log a success message.
2137
2138         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2139         Add new test to project.
2140
2141 2011-05-25  Tony Chang  <tony@chromium.org>
2142
2143         Reviewed by Adam Barth.
2144
2145         webkitpy's NetworkTransaction shouldn't use mechanize
2146         https://bugs.webkit.org/show_bug.cgi?id=61450
2147
2148         mechanize.HTTPError is just an alias for urllib2.HTTPError, so
2149         use urllib2 directly.  Re-add NetworkTransaction to
2150         test_results_uploader.py (reverting r87124).
2151
2152         * Scripts/webkitpy/common/net/networktransaction.py:
2153         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
2154
2155 2011-05-25  Kevin Ollivier  <kevino@theolliviers.com>
2156
2157         [Chromium] Unreviewed build fix. Do not define WTF/JS_EXPORT_PRIVATE to JS_EXPORTDATA
2158         until the port begins using those export macros.
2159
2160         * DumpRenderTree/chromium/config.h:
2161
2162 2011-05-25  Sheriff Bot  <webkit.review.bot@gmail.com>
2163
2164         Unreviewed, rolling out r87257.
2165         http://trac.webkit.org/changeset/87257
2166         https://bugs.webkit.org/show_bug.cgi?id=61457
2167
2168         This broke layout tests, see bug 61431. (Requested by
2169         hwennborg on #webkit).
2170
2171         * DumpRenderTree/chromium/LayoutTestController.cpp:
2172         (LayoutTestController::LayoutTestController):
2173         (LayoutTestController::clearAllDatabases):
2174         * DumpRenderTree/chromium/LayoutTestController.h:
2175
2176 2011-05-25  Qi Zhang  <qi.2.zhang@nokia.com>
2177
2178         Reviewed by Andreas Kling.
2179
2180         [Qt] fast/css/disabled-author-styles.html failed
2181         https://bugs.webkit.org/show_bug.cgi?id=61438
2182
2183         Implemented API setAuthorAndUserStylesEnabled in LayoutTestControllerQt.
2184
2185         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2186         (WebCore::WebPage::resetSettings):
2187         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2188         (LayoutTestController::setAuthorAndUserStylesEnabled):
2189         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2190
2191 2011-05-25  Adam Roben  <aroben@apple.com>
2192
2193         Identify, rather than skip, builds where run-webkit-tests exited early due to too many failures
2194
2195         Fixes <http://webkit.org/b/61441> TestFailures page should show when run-webkit-tests
2196         started exiting early due to too many crashes, timeouts, or failures
2197
2198         Reviewed by David Kilzer.
2199
2200         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
2201         (Builder.prototype.getNumberOfFailingTests): Rather than returning -1 ("unknown") when
2202         run-webkit-tests exits early due to too many failures, pass that information in another
2203         argument to the callback.
2204         (Builder.prototype.startFetchingBuildHistory): Updated the documentation comment to reflect
2205         the new structure of the object passed to the callback.
2206         (Builder.prototype._getFailingTests): Updated to expect a tooManyFailures boolean from
2207         getNumberOfFailingTests and to pass that along to our own callbacks.
2208         (Builder.prototype._incorporateBuildHistory): Updated to expect a tooManyFailures boolean
2209         from _getFailingTests and to store that value in the history object.
2210
2211         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
2212         (.info): Added.
2213
2214         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
2215         (ViewController.prototype._displayBuilder): Updated for change in structure to the history
2216         object and to add a note when run-webkit-tests exited early due to too many failures.
2217         (ViewController.prototype._displayTesters): Renamed testersAndFailureCounts to
2218         latestBuildInfos since each entry now contains more than just the tester and failure count.
2219         Now displays a message for testers where the latest build exited early due to too many
2220         failures. Updated to expect a tooManyFailures boolean from getNumberOfFailingTests and to
2221         store that value in latestBuildInfos.
2222
2223 2011-05-24  Keishi Hattori  <keishi@webkit.org>
2224
2225         Reviewed by Kent Tamura.
2226
2227         Disable textfield implementation of <input type=color>. Add INPUT_COLOR feature flag. Add input color sanitizer.
2228         https://bugs.webkit.org/show_bug.cgi?id=61273
2229
2230         * Scripts/build-webkit: Added INPUT_COLOR feature flag.
2231
2232 2011-05-24  Greg Simon  <gregsimon@chromium.org>
2233
2234         Reviewed by Dimitri Glazkov.
2235
2236         Control Indexeddb backends from LayoutTestController
2237         https://bugs.webkit.org/show_bug.cgi?id=61000
2238
2239         * DumpRenderTree/chromium/LayoutTestController.cpp:
2240         (LayoutTestController::LayoutTestController):
2241         (LayoutTestController::setOverrideIndexedDBBackingStore):
2242         (LayoutTestController::clearAllDatabases):
2243         * DumpRenderTree/chromium/LayoutTestController.h:
2244
2245 2011-05-24  Robert Hogan  <robert@webkit.org>
2246
2247         Reviewed by Ryosuke Niwa.
2248
2249         [Qt] Fix fast/events/selectstart-by-single-click-with-shift.html
2250         https://bugs.webkit.org/show_bug.cgi?id=61393
2251
2252         * DumpRenderTree/qt/EventSenderQt.h:
2253         * DumpRenderTree/qt/EventSenderQt.cpp:
2254         (getModifiers): static function for interpreting modifiers
2255         (EventSender::mouseDown): Respect keyboard modifiers
2256         (EventSender::keyDown): use new static function
2257         (EventSender::sendOrQueueEvent): whitespace fix
2258
2259 2011-05-24  Jay Civelli  <jcivelli@chromium.org>
2260
2261         Reviewed by Adam Barth.
2262
2263         Adding MHTML reading support.
2264         https://bugs.webkit.org/show_bug.cgi?id=7168
2265
2266         * Scripts/build-webkit:
2267         * Scripts/old-run-webkit-tests:
2268         * Scripts/webkitperl/features.pm:
2269         * Scripts/webkitpy/layout_tests/port/test_files.py:
2270         * Scripts/webkitpy/layout_tests/port/webkit.py:
2271
2272 2011-05-24  Stephen White  <senorblanco@chromium.org>
2273
2274         Reviewed by Kenneth Russell.
2275
2276         Remove most style checks on Source/ThirdParty/glu, since it doesn't
2277         follow WebKit style.
2278         https://bugs.webkit.org/show_bug.cgi?id=61365
2279
2280         * Scripts/webkitpy/style/checker.py:
2281
2282 2011-05-24  Adam Roben  <aroben@apple.com>
2283
2284         Don't allow forcing builds through the build.webkit.org web interface
2285
2286         Someone has been forcing bogus builds.
2287
2288         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2289
2290 2011-05-24  Qi Zhang  <qi.2.zhang@nokia.com>
2291
2292         Reviewed by Adam Roben.
2293
2294         WebKitTestRunner needs layoutTestController.setJavaScriptCanAccessClipboard
2295         https://bugs.webkit.org/show_bug.cgi?id=42669
2296
2297         Fixes the regression issue caused by patch 94265. The patch didn't intialize the setting before the 
2298         layouttest starting, it will make the test cases after editing/execCommand/clipboard-access.html failed.
2299         Because that case changed the setting.
2300
2301         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2302         (WTR::InjectedBundle::beginTesting):
2303
2304 2011-05-24  Csaba Osztrogonác  <ossy@webkit.org>
2305
2306         Reviewed by Kenneth Rohde Christiansen.
2307
2308         [ORWT]Make --skipped=only option work with parameters with LayoutTests/ prefix
2309         https://bugs.webkit.org/show_bug.cgi?id=61052
2310
2311         * Scripts/old-run-webkit-tests:
2312
2313 2011-05-24  Adam Roben  <aroben@apple.com>
2314
2315         Make TestFailures show how many tests are failing on each tester, and omit testers with no failures
2316
2317         Fixes <http://webkit.org/b/61063> <rdar://problem/9460533> TestFailures page shows testers
2318         that don't have any failing tests, which isn't useful
2319
2320         Reviewed by David Kilzer.
2321
2322         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js:
2323         (Buildbot.prototype.getTesters): Renamed from getTesterNames. Now returns Builder objects
2324         instead of name strings.
2325         (Buildbot.prototype._buildersForNames): Added. Helper function to convert an array of
2326         builder names into an array of builders.
2327
2328         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
2329         (Builder.prototype.getMostRecentCompletedBuildNumber): Added. Returns the build number of
2330         the most recently completed build, or -1 if there is no such build.
2331         (Builder.prototype.getNumberOfFailingTests): Added. Returns the number of tests that failed
2332         in the given build, or -1 if the number could not be determined. Some of this code came from
2333         _getFailingTests.
2334         (Builder.prototype._getBuildJSON): Added. Code came from _getFailingTests.
2335         (Builder.prototype._getFailingTests): Changed to use new _getBuildJSON and
2336         getNumberOfFailingTests functions.
2337
2338         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
2339         (ViewController.prototype._displayTesters): Get the current number of test failures for each
2340         tester and show it in the list. Omit testers that have no failures at all. We keep the
2341         testers and failure counts in an array and sort it before displaying the current data, as
2342         the order in which data will be fetched is unpredictable.
2343
2344 2011-05-23  Tony Chang  <tony@chromium.org>
2345
2346         Reviewed by Ojan Vafai.
2347
2348         [nrwt] don't use NetworkTranslation when uploading results
2349         https://bugs.webkit.org/show_bug.cgi?id=61315
2350
2351         This avoids autoinstalling mechanize.  It didn't matter anyway
2352         because test_results_uploader.py wasn't using mechanize to make the
2353         request so NetworkTransaction::run wasn't doing anything extra
2354         (it only matters if it catches mechanize.HTTPError).
2355
2356         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
2357
2358 2011-05-23  Tony Chang  <tony@chromium.org>
2359
2360         Reviewed by Dirk Pranke.
2361
2362         [chromium] fix the rebaseline tool to work with Linux GPU failures
2363         https://bugs.webkit.org/show_bug.cgi?id=61312
2364
2365         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2366
2367 2011-05-23  Darin Adler  <darin@apple.com>
2368
2369         Ignore generated .pyc files in a directory full of python code.
2370
2371         * Scripts/webkitpy/common/checkout/scm: Added property svn:ignore.
2372
2373 2011-05-23  Adam Barth  <abarth@webkit.org>
2374
2375         Reviewed by Eric Seidel.
2376
2377         sheriffbot should give more details about the failures in IRC
2378         https://bugs.webkit.org/show_bug.cgi?id=61233
2379
2380         With this patch, sheriffbot will annonce the set of failing tests,
2381         which might help folks triage the problem.
2382
2383         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2384         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
2385
2386 2011-05-23  Sheriff Bot  <webkit.review.bot@gmail.com>
2387
2388         Unreviewed, rolling out r87078.
2389         http://trac.webkit.org/changeset/87078
2390         https://bugs.webkit.org/show_bug.cgi?id=61294
2391
2392         Patch contains errors and seems likely to break a bunch of
2393         bots (Requested by abarth on #webkit).
2394
2395         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2396         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2397         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2398
2399 2011-05-23  Alice Boxhall  <aboxhall@chromium.org>
2400
2401         Reviewed by Ojan Vafai.
2402
2403         Convert json_results_generator.py to output version 4 JSON.
2404         https://bugs.webkit.org/show_bug.cgi?id=60869
2405
2406         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2407         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2408         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2409
2410 2011-05-23  Patrick Gansterer  <paroga@webkit.org>
2411
2412         Reviewed by Adam Barth.
2413
2414         Move generation of shell_command from port to executive
2415         https://bugs.webkit.org/show_bug.cgi?id=61251
2416
2417         After move it's possible to use the code in other places too.
2418
2419         * Scripts/webkitpy/common/config/ports.py:
2420         * Scripts/webkitpy/common/system/executive.py:
2421
2422 2011-05-23  Qi Zhang  <qi.2.zhang@nokia.com>
2423
2424         Reviewed by Darin Adler.
2425
2426         WebKitTestRunner needs layoutTestController.setJavaScriptCanAccessClipboard
2427         https://bugs.webkit.org/show_bug.cgi?id=42669
2428
2429         Implement setJavaScriptCanAccessClipboard in WebKitTestRunner.
2430
2431         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2432         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2433         (WTR::LayoutTestController::setJavaScriptCanAccessClipboard):
2434         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2435
2436 2011-05-22  Robert Hogan  <robert@webkit.org>
2437
2438         Reviewed by Kenneth Rohde Christiansen.
2439
2440         Fix policyDelegate in Qt DRT
2441         https://bugs.webkit.org/show_bug.cgi?id=61247
2442
2443         Use the 'policy delegate' implemented in FrameLoaderClient
2444         for layout tests. The partial implementation in DumpRenderTreeQt
2445         is redundant, so remove it.
2446
2447         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2448         (WebCore::WebPage::acceptNavigationRequest):
2449         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2450         (LayoutTestController::waitForPolicyDelegate):
2451
2452 2011-05-22  Patrick Gansterer  <paroga@webkit.org>
2453
2454         Reviewed by Darin Adler.
2455
2456         Use double quotes for filename arguments
2457         https://bugs.webkit.org/show_bug.cgi?id=61250
2458
2459         Windows does not support single quotes on the command line,
2460         so replace them with double quotes.
2461
2462         * Scripts/prepare-ChangeLog:
2463
2464 2011-05-20  Simon Fraser  <simon.fraser@apple.com>
2465
2466         Reviewed by Sam Weinig.
2467
2468         WebKitTestRunner needs layoutTestController.pauseTransitionAtTimeOnElementWithId
2469         https://bugs.webkit.org/show_bug.cgi?id=42550
2470         
2471         Implement pauseTransitionAtTimeOnElementWithId in WebKitTestRunner.
2472
2473         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2474         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2475         Copy the code for pausing animations, FIXME comments and all.
2476         (WTR::LayoutTestController::pauseTransitionAtTimeOnElementWithId):
2477         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2478
2479 2011-05-20  Alok Priyadarshi  <alokp@chromium.org>
2480
2481         Reviewed by Stephen White.
2482
2483         Adding myself to the committers list.
2484
2485         * Scripts/webkitpy/common/config/committers.py:
2486
2487 2011-05-19  Adam Roben  <aroben@apple.com>
2488
2489         Test that the WebKit2 UI process doesn't crash when starting a download
2490
2491         Test for <http://webkit.org/b/61142> <rdar://problem/9471680> REGRESSION (r86812): Crash
2492         (preceded by assertion) in fastMalloc when downloading a file
2493
2494         Reviewed by Darin Adler.
2495
2496         * TestWebKitAPI/Tests/WebKit2/18-characters.html: Added.
2497
2498         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp: Added.
2499         (TestWebKitAPI::decidePolicyForNavigationAction): Start a download.
2500         (TestWebKitAPI::decideDestinationWithSuggestedFilename): Record that the download was
2501         started, cancel the download, and return a bogus string.
2502
2503         (TestWebKitAPI::setContextDownloadClient):
2504         (TestWebKitAPI::setPagePolicyClient):
2505         Simple helper functions.
2506
2507         (TestWebKitAPI::TEST): Load 18-characters.html, which should trigger a download thanks to
2508         our policy client, and run until we know that the download was started. If we haven't
2509         crashed, we win!
2510
2511         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2512         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2513         * TestWebKitAPI/win/copy-resources.cmd:
2514         Added new files.
2515
2516 2011-05-20  Kent Tamura  <tkent@chromium.org>
2517
2518         Reviewed by Ryosuke Niwa.
2519
2520         Fix style errors in DumpRenderTree/chromium/.
2521         https://bugs.webkit.org/show_bug.cgi?id=61172
2522
2523         * DumpRenderTree/chromium/CppBoundClass.cpp:
2524         (CppBoundClass::getAsCppVariant):
2525         (CppBoundClass::bindToJavascript):
2526         * DumpRenderTree/chromium/CppBoundClass.h:
2527         (CppBoundClass::GetterCallback::~GetterCallback):
2528         (CppBoundClass::CppBoundClass):
2529         (CppBoundClass::Callback::~Callback):
2530         (CppBoundClass::MemberCallback::MemberCallback):
2531         (CppBoundClass::MemberCallback::~MemberCallback):
2532         (CppBoundClass::MemberGetterCallback::MemberGetterCallback):
2533         (CppBoundClass::MemberGetterCallback::~MemberGetterCallback):
2534         * DumpRenderTree/chromium/CppVariant.h:
2535         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2536         (DRTDevToolsAgent::~DRTDevToolsAgent):
2537         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
2538         (DRTDevToolsClient::sendFrontendLoaded):
2539         * DumpRenderTree/chromium/DRTDevToolsClient.h:
2540         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2541         (main):
2542         * DumpRenderTree/chromium/EventSender.cpp:
2543         (SavedEvent::SavedEvent):
2544         (EventSender::EventSender):
2545         (EventSender::keyDown):
2546         * DumpRenderTree/chromium/EventSender.h:
2547         * DumpRenderTree/chromium/ImageDiff.cpp:
2548         (Image::Image):
2549         * DumpRenderTree/chromium/LayoutTestController.cpp:
2550         (LayoutTestController::LayoutTestController):
2551         (LayoutTestController::WorkQueue::reset):
2552         (WorkItemBackForward::WorkItemBackForward):
2553         (WorkItemLoadingScript::WorkItemLoadingScript):
2554         (WorkItemNonLoadingScript::WorkItemNonLoadingScript):
2555         (WorkItemLoad::WorkItemLoad):
2556         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
2557         (LayoutTestController::pathToLocalResource):
2558         * DumpRenderTree/chromium/LayoutTestController.h:
2559         (LayoutTestController::WorkItem::~WorkItem):
2560         (LayoutTestController::WorkQueue::WorkQueue):
2561         * DumpRenderTree/chromium/MockSpellCheck.cpp:
2562         (MockSpellCheck::MockSpellCheck):
2563         (MockSpellCheck::~MockSpellCheck):
2564         * DumpRenderTree/chromium/MockSpellCheck.h:
2565         * DumpRenderTree/chromium/NotificationPresenter.h:
2566         (NotificationPresenter::NotificationPresenter):
2567         * DumpRenderTree/chromium/Task.cpp:
2568         (WebTask::WebTask):
2569         * DumpRenderTree/chromium/Task.h:
2570         (TaskList::TaskList):
2571         * DumpRenderTree/chromium/TestEventPrinter.cpp:
2572         (DRTPrinter::DRTPrinter):
2573         (TestShellPrinter::TestShellPrinter):
2574         * DumpRenderTree/chromium/TestNavigationController.cpp:
2575         (TestNavigationEntry::TestNavigationEntry):
2576         (TestNavigationEntry::~TestNavigationEntry):
2577         (TestNavigationController::TestNavigationController):
2578         (TestNavigationController::reload):
2579         (TestNavigationController::loadEntry):
2580         (TestNavigationController::didNavigateToEntry):
2581         * DumpRenderTree/chromium/TestNavigationController.h:
2582         (TestShellExtraData::TestShellExtraData):
2583         * DumpRenderTree/chromium/TestShell.cpp:
2584         (dumpHistoryItem):
2585         * DumpRenderTree/chromium/TestShell.h:
2586         (TestParams::TestParams):
2587         * DumpRenderTree/chromium/TestShellWin.cpp:
2588         (TestShell::waitTestFinished):
2589         * DumpRenderTree/chromium/TestWebWorker.h:
2590         (TestWebWorker::startWorkerContext):
2591         (TestWebWorker::terminateWorkerContext):
2592         (TestWebWorker::postMessageToWorkerContext):
2593         (TestWebWorker::clientDestroyed):
2594         (TestWebWorker::postMessageToWorkerObject):
2595         (TestWebWorker::postExceptionToWorkerObject):
2596         (TestWebWorker::postConsoleMessageToWorkerObject):
2597         (TestWebWorker::confirmMessageFromWorkerObject):
2598         (TestWebWorker::reportPendingActivity):
2599         (TestWebWorker::workerContextClosed):
2600         (TestWebWorker::~TestWebWorker):
2601         * DumpRenderTree/chromium/TextInputController.cpp:
2602         * DumpRenderTree/chromium/WebThemeControlDRTWin.h:
2603         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
2604         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
2605         (WebThemeEngineDRTWin::paintButton):
2606         (WebThemeEngineDRTWin::paintMenuList):
2607         (WebThemeEngineDRTWin::paintTrackbar):
2608         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h:
2609         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
2610         * DumpRenderTree/chromium/WebViewHost.cpp:
2611         (WebViewHost::navigate):
2612         (WebViewHost::updateSessionHistory):
2613         (WebViewHost::paintInvalidatedRegion):
2614         * DumpRenderTree/chromium/WebViewHost.h:
2615
2616 2011-05-19  Dmitry Lomov  <dslomov@google.com>
2617
2618         Reviewed by Adam Roben.
2619
2620         Detect hangs in run-api-tests
2621         https://bugs.webkit.org/show_bug.cgi?id=48043
2622
2623         * Scripts/run-api-tests: Added test timeouts
2624
2625 2011-05-19  Dmitry Lomov  <dslomov@google.com>
2626
2627         Reviewed by Adam Roben.
2628
2629         run-api-tests should run one test per process
2630         https://bugs.webkit.org/show_bug.cgi?id=61088
2631
2632         * Scripts/run-api-tests: Resurrecting the previous revison of this file, with fixes to system call under Windows, 
2633         return code, and parsing GTest output format.
2634
2635 2011-05-15  Robert Hogan  <robert@webkit.org>
2636
2637         Reviewed by Antonio Gomes.
2638
2639         [Qt][GTK] plugins/get-url-with-javascript-url.html fails
2640         https://bugs.webkit.org/show_bug.cgi?id=60834
2641         Fix unix test plugin for plugins/get-url-with-javascript-url.html
2642
2643         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2644         (webkit_test_plugin_new_stream):
2645         (webkit_test_plugin_write_ready):
2646         (webkit_test_plugin_write):
2647
2648 2011-05-19  Sheriff Bot  <webkit.review.bot@gmail.com>
2649
2650         Unreviewed, rolling out r86869, r86873, r86875, and r86877.
2651         http://trac.webkit.org/changeset/86869
2652         http://trac.webkit.org/changeset/86873
2653         http://trac.webkit.org/changeset/86875
2654         http://trac.webkit.org/changeset/86877
2655         https://bugs.webkit.org/show_bug.cgi?id=61139
2656
2657         broke builds and debug DRT (Requested by rniwa on #webkit).
2658
2659         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2660         * DumpRenderTree/chromium/TestShell.cpp:
2661         (TestShell::bindJSObjectsToWindow):
2662         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2663         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
2664
2665 2011-05-18  Dimitri Glazkov  <dglazkov@chromium.org>
2666
2667         Reviewed by Darin Adler.
2668
2669         Add build logistics and plumbing for window.internals object.
2670         https://bugs.webkit.org/show_bug.cgi?id=60313
2671
2672         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linking new WebCoreTestSupport library.
2673         * DumpRenderTree/chromium/TestShell.cpp:
2674         (TestShell::bindJSObjectsToWindow): Added injection code.
2675         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2676         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): Ditto.
2677
2678 2011-05-19  Zsolt Fehér  <h490267@stud.u-szeged.hu>
2679
2680         Reviewed by Csaba Osztrogonác.
2681
2682         [Qt] Implement eventSender.scalePageBy
2683         https://bugs.webkit.org/show_bug.cgi?id=60015
2684
2685         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2686         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2687         * DumpRenderTree/qt/EventSenderQt.cpp:
2688         (EventSender::scalePageBy):
2689         * DumpRenderTree/qt/EventSenderQt.h:
2690
2691 2011-05-19  Kenichi Ishibashi  <bashi@chromium.org>
2692
2693         Reviewed by Kent Tamura.
2694
2695         [Chromium] IME candidate window appears wrong position in an iframe
2696         https://bugs.webkit.org/show_bug.cgi?id=61023
2697
2698         Call the focused frame's firstRectForCharacterRange() instead of the
2699         main frame so that DRT behaves as the same as Chromium.
2700
2701         * DumpRenderTree/chromium/TextInputController.cpp:
2702         (TextInputController::firstRectForCharacterRange):
2703
2704 2011-05-18  Adam Roben  <aroben@apple.com>
2705
2706         Add a new page to build.webkit.org to help find when tests started failing
2707
2708         The page is accessible at <http://build.webkit.org/TestFailures/>. It is pretty minimalist
2709         right now, but already shows some useful information. It's somewhat similar to webkit-patch
2710         failure-reason and sheriffbot, and perhaps can be combined with them eventually. It's a
2711         little more convenient than either of them, though, because it's all done in the browser
2712         (and thus it's easy to go directly to the relevant test results).
2713
2714         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js: Added.
2715         (Buildbot): This class represents a Buildbot server.
2716         (Buildbot.prototype.buildURL): Returns the URL for the summary page for a particular build.
2717         (Buildbot.prototype.builderNamed): Returns a Builder with the given name.
2718         (Buildbot.prototype.getTesterNames): Fetches the names of all testers and passes them to the
2719         callback.
2720         (Buildbot.prototype.parseBuildName): Breaks up a build name into its constituent parts. Must
2721         be implemented by a derived class that understands this server's build naming scheme.
2722         (Buildbot.prototype.resultsDirectoryURL): Returns the URL for the results directory for a
2723         particular build.
2724
2725         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js: Added.
2726         (Builder): This class represents one builder on the buildbot.
2727         (Builder.prototype.buildURL): Returns the URL for the summary page for a particular build.
2728         (Builder.prototype.failureDiagnosisTextAndURL): Returns data that provides a little more
2729         information about a particular test failure.
2730         (Builder.prototype.startFetchingBuildHistory): Periodically calls the callback with
2731         information about when tests started failing.
2732         (Builder.prototype.resultsDirectoryURL): Returns the URL for the results directory for a
2733         particular build.
2734         (Builder.prototype._getBuildNames): Fetches the names of all builds and passes them to the
2735         callback.
2736         (Builder.prototype._getFailingTests): Fetches the results.html page for the given build and
2737         extracts all the failing tests listed in it, passing them to the callback.
2738         (Builder.prototype._incorporateBuildHistory): Gets the failing tests for the specified
2739         build, merges them into the build history, and calls the callback telling it whether the
2740         next build should be fetched to provide more information.
2741
2742         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
2743         Added. Just some simple styles.
2744
2745         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js: Added.
2746         (createDefinitionList): Takes an array of pairs and turns them into a DL element.
2747         (getResource): Wrapper around XMLHttpRequest.
2748         (Array.prototype.findFirst): Finds the first element matching the given predicate and
2749         returns it.
2750         (Array.prototype.last): Returns the last element of the array.
2751
2752         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js: Added.
2753         (ViewController): This class contains the main logic for displaying the page.
2754         (ViewController.loaded): Just calls through to parseHash.
2755         (ViewController.parseHash): Either starts analyzing failures on a particular builder, or
2756         shows the list of all testers so one can be chosen. This function is called when the page
2757         loads and whenever we get a hashchange event.
2758         (ViewController._displayBuilder): Asks the builder to fetch build history, and displays it
2759         as it is fetched. The display ends up grouping tests by when they started failing.
2760         (ViewController._displayTesters): Gets the list of testers and displays it.
2761
2762         (ViewController._domForBuildName):
2763         (ViewController._domForFailedTest):
2764         Helper functions to create descriptions and links for a particular build or failed test.
2765
2766         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBuildbot.js: Added.
2767         (WebKitBuildbot): Calls up to the base class constructor with the correct base URL.
2768         (WebKitBuildbot.prototype.parseBuildName): Parses a build.webkit.org-style build name.
2769
2770         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Added. Just
2771         loads all the files and sets up a ViewController, which does the rest.
2772
2773         * BuildSlaveSupport/build.webkit.org-config/templates/root.html: Added a link to the new
2774         page.
2775
2776 2011-05-18  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
2777
2778         Reviewed by Csaba Osztrogonác.
2779
2780         [Qt] Implement layoutTestController.setValueForUser()
2781         https://bugs.webkit.org/show_bug.cgi?id=60956
2782
2783         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2784         (LayoutTestController::setValueForUser):
2785         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2786
2787 2011-05-16  Robert Hogan  <robert@webkit.org>
2788
2789         Reviewed by Kenneth Rohde Christiansen.
2790
2791         plugins/invalidate_rect.html fails on linux ports
2792
2793         - Make the unix test netscape plugin recognize the onPaintEvent
2794           and windowedPlugin parameters.
2795
2796         https://bugs.webkit.org/show_bug.cgi?id=54051
2797
2798         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2799         (handleEventX11):
2800         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2801         (LayoutTestController::displayInvalidatedRegion):
2802         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2803         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2804         (webkit_test_plugin_new_instance):
2805         (webkit_test_plugin_handle_event):
2806
2807 2011-05-17  Tony Chang  <tony@chromium.org>
2808
2809         Reviewed by Ojan Vafai.
2810
2811         [chromium] move Lucid 64 bit results into LayoutTests/platform/chromium-linux
2812         https://bugs.webkit.org/show_bug.cgi?id=60895
2813
2814         Update the tools to handle the move.  Lucid 32 results now go in
2815         chromium-linux-x86 and the default platform on Linux is now x86_64.
2816
2817         * Scripts/webkitpy/layout_tests/deduplicate_tests.py: Default to x86_64
2818         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
2819         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: Default to Lucid
2820         * Scripts/webkitpy/layout_tests/port/base.py: ditto
2821         * Scripts/webkitpy/layout_tests/port/chromium_linux.py: Update directory fallback and default to Lucid 64
2822         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
2823         * Scripts/webkitpy/layout_tests/port/test.py: Update tests to default to x86_64
2824         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Update bot names.
2825         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py: Whitespace cleanup.
2826
2827 2011-05-17  Adam Roben  <aroben@apple.com>
2828
2829         Make run-api-tests work on Windows when there are spaces in the path
2830
2831         Fixes <http://webkit.org/b/60954> REGRESSION (r86511): run-api-tests fails if there are
2832         spaces in the path to TestWebKitAPI.exe
2833
2834         Reviewed by David Levin.
2835
2836         * Scripts/run-api-tests:
2837         (runTestTool): Use the "direct object" form of system() to avoid having the path to
2838         TestWebKitAPI.exe be split by the shell.
2839
2840 2011-05-16  Ian Henderson  <ianh@apple.com>
2841
2842         Reviewed by Joseph Pecoraro.
2843
2844         Page::goToItem doesn't work while loading is deferred
2845         https://bugs.webkit.org/show_bug.cgi?id=60412
2846
2847         Add setDefersLoading and goBack methods to LayoutTestController.  We
2848         need to use goBack() instead of history.back() because the latter goes
2849         through NavigationScheduler, hence doesn't exhibit the bug.
2850
2851         * DumpRenderTree/LayoutTestController.cpp:
2852         (goBackCallback):
2853         (setDefersLoadingCallback):
2854         (LayoutTestController::staticFunctions):
2855         * DumpRenderTree/LayoutTestController.h:
2856         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2857         (LayoutTestController::goBack):
2858         (LayoutTestController::setDefersLoading):
2859         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2860         (LayoutTestController::goBack):
2861         (LayoutTestController::setDefersLoading):
2862         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2863         (LayoutTestController::goBack):
2864         (LayoutTestController::setDefersLoading):
2865         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2866         (LayoutTestController::goBack):
2867         (LayoutTestController::setDefersLoading):
2868
2869 2011-05-16  Sam Weinig  <sam@webkit.org>
2870
2871         Reviewed by Anders Carlsson.
2872
2873         TestWebKitAPI should build with clang if it can
2874         https://bugs.webkit.org/show_bug.cgi?id=60918
2875
2876         * TestWebKitAPI/Configurations/CompilerVersion.xcconfig:
2877         Update CompilerVersion.xcconfig to match others.
2878
2879         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2880         Add CompilerVersion.xcconfig to the project.
2881
2882         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
2883         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
2884         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2885         (TestWebKitAPI::didSameDocumentNavigationForFrame):
2886         Add some casts to quiet warnings from clang.
2887
2888 2011-05-16  Dirk Pranke  <dpranke@chromium.org>
2889
2890         Reviewed by David Levin.
2891
2892         add dpranke as a reviewer
2893         https://bugs.webkit.org/show_bug.cgi?id=60919
2894
2895         * Scripts/webkitpy/common/config/committers.py:
2896
2897 2011-05-16  Robert Hogan  <robert@webkit.org>
2898
2899         Reviewed by Anders Carlsson.
2900
2901         [Gtk] plugins/get-url-notify-with-url-that-fails-to-load.html crashes on buildbot
2902
2903         https://bugs.webkit.org/show_bug.cgi?id=60838
2904
2905         The unix test plugin needs to call the test's NPP_URLNotify
2906         rather than the browsers.
2907
2908         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2909         (webkit_test_plugin_url_notify):
2910
2911 2011-05-16  Brent Fulgham  <bfulgham@webkit.org>
2912
2913         Rubber-stamped by Adam Roben.
2914
2915         Adding myself as a reviewer.
2916         * Scripts/webkitpy/common/config/committers.py:
2917
2918 2011-05-16  Sam Weinig  <sam@webkit.org>
2919
2920         Fix typo pointed out by Dave Levin.
2921
2922         * TestWebKitAPI/PlatformUtilities.h:
2923         (TestWebKitAPI::Util::assertWKStringEqual):
2924         Strig -> String.
2925
2926 2011-05-16  Sam Weinig  <sam@webkit.org>
2927
2928         Reviewed by David Levin.
2929
2930         Convert api tester over to using gtest expectations directly
2931         https://bugs.webkit.org/show_bug.cgi?id=60862
2932
2933         * TestWebKitAPI/PlatformUtilities.cpp:
2934         (TestWebKitAPI::Util::toSTD):
2935         * TestWebKitAPI/PlatformUtilities.h:
2936         (TestWebKitAPI::Util::assertWKStrigEqual):
2937         Add convenience macro to compare WK2 strings. Add some overloads of toSTD to make
2938         the implementation of the macro simpler.
2939
2940         * TestWebKitAPI/Test.h:
2941         Remove TEST_ASSERT forwarder.
2942
2943         [Test changes elided]
2944
2945 2011-05-16  David Kilzer  <ddkilzer@apple.com>
2946
2947         <http://webkit.org/b/60913> C++ exceptions should not be enabled when building with llvm-gcc-4.2
2948         <rdar://problem/9446430>
2949
2950         Reviewed by Mark Rowe.
2951
2952         * MiniBrowser/Configurations/Base.xcconfig: Fixed typo.
2953         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
2954         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
2955
2956 2011-05-16  Jon Lee  <jonlee@apple.com>
2957
2958         Reviewed by Simon Fraser.
2959
2960         Can't horizontally scroll iframes and overflow because wheel events are always accepted
2961         https://bugs.webkit.org/show_bug.cgi?id=60779
2962
2963         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2964         (WTR::InjectedBundlePage::InjectedBundlePage): Set new default method to nil.
2965
2966 2011-05-16  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>
2967
2968         Reviewed by Csaba Osztrogonác.
2969
2970         [Qt] Tools.pro misses include(common.pri)
2971         https://bugs.webkit.org/show_bug.cgi?id=60883
2972
2973         It includes features.pri, which depends on common.pri (the build is
2974         not broken today with the default options, but this is the right
2975         thing to do).
2976
2977         * Tools.pro:
2978
2979 2011-05-15  Dominic Cooney  <dominicc@chromium.org>
2980
2981         Unreviewed: adding myself to committers.py.
2982
2983         * Scripts/webkitpy/common/config/committers.py:
2984
2985 2011-05-15  Daniel Bates  <dbates@webkit.org>
2986
2987         Reviewed by Chris Jerdonek.
2988
2989         svn-apply can't handle Git diff that only changes executable bit
2990         https://bugs.webkit.org/show_bug.cgi?id=60848
2991
2992         Fixes an issue where svn-{apply, unapply} fail to handle a Git diff for a file
2993         that only has an executable bit change.
2994
2995         * Scripts/VCSUtils.pm:
2996           - Modified regex $chunkRangeRegEx to match chunk range with ending text, say: @@ -2,6 +2,18 @@ foo().
2997         (parseDiff): Modified to count the number of text chunks in the diff. This should also help towards
2998         fixing <https://bugs.webkit.org/show_bug.cgi?id=29684>.
2999         * Scripts/svn-apply:
3000         (patch): Only use standard patch tool if the patch is non-empty and for a text file (i.e. not a binary patch).
3001         * Scripts/svn-unapply:
3002         (patch): Ditto.
3003         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
3004           - Updated expected results for test cases to account for numTextChunks.
3005           - Fixed malformed chunk range in test cases: "Git: simple", and "Git: Git diff followed by SVN diff".
3006           - Added test case "Git: file that only has an executable bit change".
3007         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
3008           - Updated expected results for test cases to account for numTextChunks.
3009
3010 2011-05-15  Sam Weinig  <sam@webkit.org>
3011
3012         Fix windows build.
3013
3014         * TestWebKitAPI/win/main.cpp:
3015         (main):
3016
3017 2011-05-15  Sam Weinig  <sam@webkit.org>
3018
3019         Reviewed by David Levin.
3020
3021         Make API tester more gtest friendly
3022         https://bugs.webkit.org/show_bug.cgi?id=60859
3023
3024         * Scripts/run-api-tests:
3025         Numerous changes:
3026         - Remove logic to run tests one at a time.
3027         - Remove logic to build up a list of tests, instead just pass --gtest_list_tests to 
3028           the test runner and allow gtest to print it for us.
3029         - Forward stdout from the test tool to stdout, even in non-verbose runs.
3030         - Run test tool from the current working directory instead of the root webkit
3031           directory.
3032
3033         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3034         Move plist to be with other bundle sources.
3035
3036         * TestWebKitAPI/TestsController.cpp:
3037         (TestWebKitAPI::TestsController::TestsController):
3038         (TestWebKitAPI::TestsController::run):
3039         * TestWebKitAPI/TestsController.h:
3040         * TestWebKitAPI/mac/main.mm:
3041         Simplify TestController down to a single run function. We should consider removing the class
3042         entirely at some point.
3043
3044 2011-05-15  Sheriff Bot  <webkit.review.bot@gmail.com>
3045
3046         Unreviewed, rolling out r86504.
3047         http://trac.webkit.org/changeset/86504
3048         https://bugs.webkit.org/show_bug.cgi?id=60853
3049
3050         "Broke Qt EventSender in editing/selection tests" (Requested
3051         by mwenge on #webkit).
3052
3053         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3054         (WebCore::WebPage::WebPage):
3055         (WebCore::DumpRenderTree::DumpRenderTree):
3056         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3057         (WebCore::DumpRenderTree::initJSObjects):
3058         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3059         (WebCore::DumpRenderTree::eventSender):
3060         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3061         (webkit_test_plugin_new_instance):
3062         (webkit_test_plugin_set_window):
3063         (webkit_test_plugin_handle_event):
3064
3065 2011-05-12  Robert Hogan  <robert@webkit.org>
3066
3067         Reviewed by Benjamin Poulain.
3068
3069         [Qt] fix http/tests/plugins/plugin-document-has-focus.html
3070
3071         The support for this test added to the unix test plugin here
3072         may allow other platforms to pass it (nearly everyone
3073         skips it). On Qt it required a bit of trickiness with
3074         the page's EventSender object to get it working fully though,
3075         so only unskipping Qt here.
3076
3077         https://bugs.webkit.org/show_bug.cgi?id=60722
3078
3079         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3080         (WebCore::WebPage::WebPage):
3081         (WebCore::WebPage::eventSender):
3082         (WebCore::DumpRenderTree::DumpRenderTree):
3083         (WebCore::DumpRenderTree::initJSObjects):
3084         (WebCore::DumpRenderTree::createWindow):
3085         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3086         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3087         (webkit_test_plugin_new_instance):
3088         (webkit_test_plugin_set_window):
3089         (webkit_test_plugin_handle_event):
3090
3091 2011-05-14  Arno Renevier  <arno@renevier.net>
3092
3093         Reviewed by Martin Robinson.
3094
3095         make run-gtk-tests executable
3096         https://bugs.webkit.org/show_bug.cgi?id=59278
3097
3098         * Scripts/run-gtk-tests:
3099
3100 2011-05-14  Anders Carlsson  <andersca@apple.com>
3101
3102         Reviewed by Kevin Decker.
3103
3104         NPP_URLNotify is not called if a URL passed to NPN_GetURLNotify fails to load
3105         https://bugs.webkit.org/show_bug.cgi?id=60823
3106         <rdar://problem/9430386>
3107
3108         Add test that calls NPN_GetURLNotify on a URL that can't be loaded, and checks if NPP_URLNotify is called.
3109
3110         * DumpRenderTree/DumpRenderTree.gypi:
3111         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3112         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLNotifyWithURLThatFailsToLoad.cpp: Added.
3113         (GetURLNotifyWithURLThatFailsToLoad::GetURLNotifyWithURLThatFailsToLoad):
3114         (GetURLNotifyWithURLThatFailsToLoad::NPP_New):
3115         (GetURLNotifyWithURLThatFailsToLoad::NPP_URLNotify):
3116         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3117         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3118         * GNUmakefile.am:
3119
3120 2011-05-14  Sheriff Bot  <webkit.review.bot@gmail.com>
3121
3122         Unreviewed, rolling out r86476.
3123         http://trac.webkit.org/changeset/86476
3124         https://bugs.webkit.org/show_bug.cgi?id=60832
3125
3126         It made plugins/get-url-notify-with-url-that-fails-to-
3127         load.html crash on GTK (Requested by Ossy on #webkit).
3128
3129         * DumpRenderTree/DumpRenderTree.gypi:
3130         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3131         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLNotifyWithURLThatFailsToLoad.cpp: Removed.
3132         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3133         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3134         * GNUmakefile.am:
3135
3136 2011-05-13  Anders Carlsson  <andersca@apple.com>
3137
3138         Reviewed by Sam Weinig.
3139
3140         NPP_URLNotify is not called if a URL passed to NPN_GetURLNotify fails to load
3141         https://bugs.webkit.org/show_bug.cgi?id=60823
3142         <rdar://problem/9430386>
3143
3144         Add test that calls NPN_GetURLNotify on a URL that can't be loaded, and checks if NPP_URLNotify is called.
3145
3146         * DumpRenderTree/DumpRenderTree.gypi:
3147         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3148         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLNotifyWithURLThatFailsToLoad.cpp: Added.
3149         (GetURLNotifyWithURLThatFailsToLoad::GetURLNotifyWithURLThatFailsToLoad):
3150         (GetURLNotifyWithURLThatFailsToLoad::NPP_New):
3151         (GetURLNotifyWithURLThatFailsToLoad::NPP_URLNotify):
3152         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3153         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3154         * GNUmakefile.am:
3155
3156 2011-05-13  Anders Carlsson  <andersca@apple.com>
3157
3158         Build fix.
3159
3160         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLWithJavaScriptURL.cpp:
3161
3162 2011-05-13  Anders Carlsson  <andersca@apple.com>
3163
3164         Reviewed by Sam Weinig.
3165
3166         NPN_GetURL with a javascript: URL doesn't send back the result in the stream
3167         https://bugs.webkit.org/show_bug.cgi?id=60810
3168
3169         Add a test that calls NPN_GetURL on a javascript: URL and checks that it gets back the expected result.
3170
3171         * DumpRenderTree/DumpRenderTree.gypi:
3172         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3173         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3174         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3175         * GNUmakefile.am:
3176         Add files.
3177
3178         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
3179         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
3180         Add new NPN and NPP wrappers and sort them according to the order they appear in npfunctions.h
3181
3182         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLWithJavaScriptURL.cpp: Added.
3183         (GetURLWithJavaScriptURL::GetURLWithJavaScriptURL):
3184         (GetURLWithJavaScriptURL::NPP_New):
3185         (GetURLWithJavaScriptURL::NPP_NewStream):
3186         (GetURLWithJavaScriptURL::NPP_DestroyStream):
3187         (GetURLWithJavaScriptURL::NPP_WriteReady):
3188         (GetURLWithJavaScriptURL::NPP_Write):
3189         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3190         (NPP_NewStream):
3191         (NPP_WriteReady):
3192         (NPP_Write):
3193         (NPP_URLNotify):
3194         call the PluginTest NPP wrappers.
3195
3196 2011-05-13  Sheriff Bot  <webkit.review.bot@gmail.com>
3197
3198         Unreviewed, rolling out r86447.
3199         http://trac.webkit.org/changeset/86447
3200         https://bugs.webkit.org/show_bug.cgi?id=60809
3201
3202         "Broke some uses of EventSender object on Qt" (Requested by
3203         mwenge on #webkit).
3204
3205         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3206         (WebCore::WebPage::WebPage):
3207         (WebCore::DumpRenderTree::DumpRenderTree):
3208         (WebCore::DumpRenderTree::initJSObjects):
3209         (WebCore::DumpRenderTree::createWindow):
3210         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3211         (WebCore::DumpRenderTree::eventSender):
3212         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3213         (webkit_test_plugin_new_instance):
3214         (webkit_test_plugin_set_window):
3215         (webkit_test_plugin_handle_event):
3216
3217 2011-05-13  Robert Hogan  <robert@webkit.org>
3218
3219         Reviewed by Benjamin Poulain.
3220
3221         [Qt] fix http/tests/plugins/plugin-document-has-focus.html
3222
3223         The support for this test added to the unix test plugin here
3224         may allow other platforms to pass it (nearly everyone
3225         skips it). On Qt it required a bit of trickiness with
3226         the page's EventSender object to get it working fully though,
3227         so only unskipping Qt here.
3228
3229         https://bugs.webkit.org/show_bug.cgi?id=60722
3230
3231         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3232         (WebCore::WebPage::WebPage):
3233         (WebCore::WebPage::eventSender):
3234         (WebCore::DumpRenderTree::DumpRenderTree):
3235         (WebCore::DumpRenderTree::initJSObjects):
3236         (WebCore::DumpRenderTree::createWindow):
3237         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3238         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3239         (webkit_test_plugin_new_instance):
3240         (webkit_test_plugin_set_window):
3241         (webkit_test_plugin_handle_event):
3242
3243 2011-05-13  Adam Roben  <aroben@apple.com>
3244
3245         Exclude the Leopard NRWT bot from the core builder set
3246
3247         Fixes <http://webkit.org/b/60392> Leopard Intel Release (NRWT) shouldn't be a core builder
3248
3249         Reviewed by Darin Adler.
3250
3251         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3252         (BuildBot.__init__): Tighten up the Leopard regexp to only allow the non-NRWT Leopard bots
3253         in the core builder set.
3254
3255         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3256         (BuildBotTest.test_builder_name_regexps): Updated to match the current set of builders and
3257         regexps.
3258
3259 2011-05-13  Adam Roben  <aroben@apple.com>
3260
3261         Group all the NRWT bots together
3262
3263         This also gets the new NRWT bots out of the middle of Apple's bots. Since these new NRWT
3264         bots are experimental, it seems best not to clutter up the non-experimental bots with
3265         experimental ones.
3266
3267         Fixes <http://webkit.org/b/60769> New "(NRWT)" bots are right in the middle of Apple's bots
3268         on build.webkit.org
3269
3270         Reviewed by Dan Bernstein.
3271
3272         * BuildSlaveSupport/build.webkit.org-config/config.json: Moved the "(NRWT)" bots next to the
3273         Chromium testers, which also use new-run-webkit-tests.
3274
3275 2011-05-13  Adam Roben  <aroben@apple.com>
3276
3277         Add a plugin test that dumps the plugin window's rect
3278
3279         Part of the test for <http://webkit.org/b/60194> <rdar://problem/9383760> REGRESSION
3280         (r79167): Windowed plugins in Google Reader don't move when the article list is scrolled
3281
3282         Reviewed by Dan Bernstein.
3283
3284         * DumpRenderTree/TestNetscapePlugIn/Tests/win/DumpWindowRect.cpp: Added.
3285         (DumpWindowRect::DumpWindowRect): Just call up to the base class.
3286         (DumpWindowRect::performWindowGeometryTest): Find our window rect relative to the test
3287         harness window and log it.
3288
3289         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added DumpWindowRect.
3290
3291 2011-05-13  Adam Roben  <aroben@apple.com>
3292
3293         Move code required for most tests of plugin window geometry into a base class
3294
3295         WebKit2's asynchronous plugin window positioning makes testing window geometry tricky. By
3296         having all the trickiness in a shared base class, writing new window geometry tests will be
3297         much easier.
3298
3299         Fixes <http://webkit.org/b/60776> It's hard to write tests that check plugin window geometry
3300
3301         Reviewed by Anders Carlsson.
3302
3303         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowRegionIsSetToClipRect.cpp:
3304         (WindowRegionIsSetToClipRect::WindowRegionIsSetToClipRect): Changed to inherit from the new
3305         WindowGeometryTest base class. Most of the code from this class was moved to the new base
3306         class.
3307         (WindowRegionIsSetToClipRect::performWindowGeometryTest): Renamed from checkWindowRegion.
3308         This is called by the base class when it is safe to check the window's geometry. Note that
3309         the m_didCheckWindowRegion logic was removed completely; it has never been needed and was
3310         just vestigial code from an earlier version of this test.
3311
3312         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added new
3313         WindowGeometryTest class.
3314
3315         * DumpRenderTree/TestNetscapePlugIn/win/WindowGeometryTest.cpp: Added. Code came from
3316         WindowRegionIsSetToClipRect.
3317         (WindowGeometryTest::finishTest): This is the only change from WindowRegionIsSetToClipRect.
3318         We now call the new virtual performWindowGeometryTest function instead of checkWindowRegion.
3319         Subclasses can implement that function to perform their own tests.
3320
3321         * DumpRenderTree/TestNetscapePlugIn/win/WindowGeometryTest.h: Added.
3322
3323 2011-05-13  Zoltan Herczeg  <zherczeg@webkit.org>
3324
3325         Reviewed by Csaba Osztrogonác.
3326
3327         Missing 2nd #EOF if WebProcess is killed.
3328         https://bugs.webkit.org/show_bug.cgi?id=60761
3329
3330         If the WebProcess is killed, only one #EOF is yielded
3331         by WebKitTestRunner. However, run-webkit-test wait for
3332         a second #EOF, which signals the finishing of pixel dump.
3333         Since this never happens, run-webkit-test waits forever.
3334
3335         * WebKitTestRunner/TestInvocation.cpp:
3336         (WTR::TestInvocation::dump):
3337         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3338         * WebKitTestRunner/TestInvocation.h:
3339
3340 2011-05-13  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
3341
3342         Reviewed by Csaba Osztrogonác.
3343
3344         [NRWT] chromium-linux tests shouldn't run on other platforms
3345         https://bugs.webkit.org/show_bug.cgi?id=60162
3346
3347         Remove _tests_for_other_platforms defs because r82753
3348         implemented it properly in the baseclass in webkit.py.
3349
3350         * Scripts/webkitpy/layout_tests/port/gtk.py:
3351         * Scripts/webkitpy/layout_tests/port/qt.py:
3352         * Scripts/webkitpy/layout_tests/port/win.py:
3353
3354 2011-05-12  Ryuan Choi  <ryuan.choi@samsung.com>
3355
3356         Reviewed by Antonio Gomes.
3357
3358         [EFL] Remove unused option of EWeblauncher
3359         https://bugs.webkit.org/show_bug.cgi?id=60747
3360
3361         Remove sudo-workaround option.
3362         This option is not used and make other option wrong.
3363
3364         * EWebLauncher/main.c:
3365
3366 2011-05-12  Lucas Forschler  <lforschler@apple.com>
3367
3368         Reviewed by Stephanie Lewis.
3369
3370         Fix config.json to address missing WK2 builder/tester config.
3371         Fix naming of machines (xserve not macpro)
3372
3373         * BuildSlaveSupport/build.webkit.org-config/config.json:
3374
3375 2011-05-12  Lucas Forschler  <lforschler@apple.com>
3376
3377         Reviewed by Stephanie Lewis.
3378
3379         Add SnowLeopard Debug builder and Test bot.
3380         apple-xserve-8 = SL Debug Tester.
3381         apple-xserve-9 = SL Debug Builder.
3382         
3383         * BuildSlaveSupport/build.webkit.org-config/config.json:
3384
3385 2011-05-12  Adam Barth  <abarth@webkit.org>
3386
3387         This patch disables sheriffbot's bug postings.  He's just been way too
3388         spammy recently due to test flakiness.
3389
3390         * Scripts/webkitpy/tool/commands/sheriffbot.py:
3391         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
3392
3393 2011-05-11  Brian Weinstein  <bweinstein@apple.com>
3394
3395         Reviewed by Anders Carlsson.
3396
3397         After relaunching an unresponsive web process, web page stops responding to mouse movement
3398         https://bugs.webkit.org/show_bug.cgi?id=60669
3399         <rdar://problem/9409934>
3400         
3401         This test follows the steps needed to reproduce this bug:
3402         1) Hang the web process
3403         2) While the web process is hung, move the mouse (so WebPageProxy thinks it is processing a mouse move event)
3404         3) Kill and restart the WebProcess
3405         4) Move the mouse
3406         
3407         We are testing that we receive mouse move events after the WebProcess has restarted.
3408
3409         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp: Added.
3410         (TestWebKitAPI::didFinishLoadForFrame): Set a flag that we finished loading.
3411         (TestWebKitAPI::processDidBecomeUnresponsive): Kill the web process once we become unresponsive.
3412         (TestWebKitAPI::processDidCrash): Reload the page when the process crashes, which restarts the web process.
3413         (TestWebKitAPI::setPageLoaderClient):
3414         (TestWebKitAPI::TEST):
3415         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash_Bundle.cpp: Added.
3416         (TestWebKitAPI::MouseMoveAfterCrashTest::MouseMoveAfterCrashTest):
3417         (TestWebKitAPI::MouseMoveAfterCrashTest::didReceiveMessage):
3418         * TestWebKitAPI/Tests/WebKit2/mouse-move-listener.html: Added.
3419
3420         * TestWebKitAPI/PlatformWebView.h:
3421         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3422         (TestWebKitAPI::PlatformWebView::simulateMouseMove): Sends the messages that simulate a mouse move.
3423         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
3424         (TestWebKitAPI::PlatformWebView::simulateMouseMove): Ditto.
3425
3426         Add new files.
3427         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3428         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3429         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
3430         * TestWebKitAPI/win/copy-resources.cmd:
3431
3432 2011-05-12  Tomasz Morawski  <t.morawski@samsung.com>
3433
3434         Reviewed by Antonio Gomes.
3435
3436         [EFL] Added initialization/shutdown for ecore_file library
3437         https://bugs.webkit.org/show_bug.cgi?id=60457
3438
3439         Added initialization and shuthown for ecore_file library and replaced
3440         realpath function to ecore_file_realpath.
3441
3442         * EWebLauncher/main.c:
3443         (quit):
3444         (findThemePath):
3445         (main):
3446
3447 2011-05-12  Young Han Lee  <joybro@company100.net>
3448
3449         Reviewed by Kenneth Rohde Christiansen.
3450
3451         [Qt] Implement layoutTestController.layerTreeAsText()
3452         https://bugs.webkit.org/show_bug.cgi?id=60367
3453
3454         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3455         (LayoutTestController::layerTreeAsText):
3456         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3457
3458 2011-05-11  Eric Seidel  <eric@webkit.org>
3459
3460         Reviewed by David Levin.
3461
3462         Teach validate-committer-lists how to validate committers bugzilla_email()
3463         https://bugs.webkit.org/show_bug.cgi?id=60651
3464
3465         It turns out we currently have 9 committers with invalid values for their
3466         bugzilla_email field (meaning we don't know what email is their bugzilla account).
3467         "Alexander Kellett" <lypanov@mac.com>
3468         "Andre Boule" <aboule@apple.com>
3469         "Cameron McCormack" <cam@webkit.org>
3470         "Chris Petersen" <cpetersen@apple.com>
3471         "Eli Fidler" <eli@staikos.net>
3472         "Matt Lilek" <webkit@mattlilek.com>
3473         "Pierre d'Herbemont" <pdherbemont@free.fr>
3474         "Scott Violet" <sky@chromium.org>
3475         "Adam Treat" <treat@kde.org>
3476
3477         Most of those haven't committed in a very long time, so it's not suprising
3478         that we haven't noticed that their bugzilla emails are bogus.
3479
3480         * Scripts/validate-committer-lists:
3481         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3482         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3483
3484 2011-05-11  Dmitry Lomov  <dslomov@google.com>
3485
3486         Reviewed by David Levin.
3487
3488         https://bugs.webkit.org/show_bug.cgi?id=59561
3489         Switch TestWebKitAPI to GTest
3490
3491         Fixes Makefiles and WinCairo build as well
3492
3493         * Makefile:
3494         * Scripts/build-api-tests:
3495         * Scripts/run-api-tests:
3496         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
3497         * TestWebKitAPI/Test.h:
3498         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3499         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
3500         (TestWebKitAPI::TEST):
3501         * TestWebKitAPI/TestsController.cpp:
3502         (TestWebKitAPI::TestsController::TestsController):
3503         (TestWebKitAPI::TestsController::dumpTestNames):
3504         (TestWebKitAPI::TestsController::runTestNamed):
3505         (TestWebKitAPI::TestsController::runAllTests):
3506         * TestWebKitAPI/TestsController.h:
3507         * TestWebKitAPI/mac/main.mm:
3508         (main):
3509
3510 2011-05-11  Eric Seidel  <eric@webkit.org>
3511
3512         Reviewed by Alexey Proskuryakov.
3513
3514         Add Luke Macpherson to committers.py as a Contributor
3515         https://bugs.webkit.org/show_bug.cgi?id=60639
3516
3517         * Scripts/webkitpy/common/config/committers.py:
3518
3519 2011-05-11  Noam Rosenthal  <noam.rosenthal@nokia.com>
3520
3521         Reviewed by Kenneth Rohde Christiansen.
3522
3523         [Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2 branch
3524         https://bugs.webkit.org/show_bug.cgi?id=60439
3525
3526         Patch 4/12: Update the build script to enable 3D rendering by default for Qt.
3527
3528         * Scripts/build-webkit:
3529
3530 2011-05-11  Brian Weinstein  <bweinstein@apple.com>
3531
3532         Reviewed by Adam Roben.
3533
3534         REGRESSION (r86161): WKPreferences API test failing on Windows
3535         https://bugs.webkit.org/show_bug.cgi?id=60658
3536
3537         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
3538         (TestWebKitAPI::TEST):
3539
3540 2011-05-11  Alice Boxhall  <aboxhall@chromium.org>
3541
3542         Reviewed by Ojan Vafai.
3543
3544         Modify jsonresults_unittest.py to use a dict format for its test data, and modify jsonresults.py to flatten hierarchical directory structures in input JSON.
3545         https://bugs.webkit.org/show_bug.cgi?id=60521
3546
3547         First steps towards making the results JSON all hierarchical.
3548
3549         * TestResultServer/model/jsonresults.py:
3550         * TestResultServer/model/jsonresults_unittest.py:
3551
3552 2011-05-11  Kevin Ollivier  <kevino@theolliviers.com>
3553
3554         [wx] Build fix, adding new LayoutTestController method stubs.
3555
3556         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3557         (LayoutTestController::localStorageDiskUsageForOrigin):
3558         (LayoutTestController::applicationCacheDiskUsageForOrigin):
3559
3560 2011-05-11  Jessie Berlin  <jberlin@apple.com>
3561
3562         Reviewed by Darin Adler.
3563
3564         [WebKit2] exceededDatabaseQuota function on WKPageUIClient needs to provide information
3565         about the usage for both the origin overall and the database in question.
3566         https://bugs.webkit.org/show_bug.cgi?id=60573
3567
3568         * WebKitTestRunner/TestController.cpp:
3569         (WTR::exceededDatabaseQuota):
3570
3571 2011-05-10  Stephen White  <senorblanco@chromium.org>
3572
3573         Reviewed by David Levin.
3574
3575         Adding myself as a reviewer.
3576         https://bugs.webkit.org/show_bug.cgi?id=60587
3577
3578         * Scripts/webkitpy/common/config/committers.py:
3579
3580 2011-05-11  Eric Seidel  <eric@webkit.org>
3581
3582         Reviewed by Csaba Osztrogonác.
3583
3584         queues.webkit.org should show 1000+ instead of 1000 when we hit the query limit
3585         https://bugs.webkit.org/show_bug.cgi?id=60614
3586
3587         AppEngine has a result limit of 1000.  We hit that when trying
3588         to find out how many patches the style-queue (and other queues)
3589         have passed in the last 30 days.  So lets display 1000+ instead
3590         of 1000 to avoid confusion. (Ossy was asking about this in #webkit tonight.)
3591
3592         I also made the status pages show "never" instead of just "ago" when we
3593         haven't seen a pass or boot message in the last 1000 messages.
3594
3595         * QueueStatusServer/handlers/queuestatus.py:
3596         * QueueStatusServer/templates/queuestatus.html:
3597
3598 2011-05-11  Adam Barth  <abarth@webkit.org>
3599
3600         Reviewed by Eric Seidel.
3601
3602         sheriffbot shouldn't spam bugs when it can't figure out who to blame
3603         https://bugs.webkit.org/show_bug.cgi?id=60613
3604
3605         This patch limits the number of bugs sheriffbot will spam to three.
3606         Ideally, we'd come up with some smarter huerstics, but hopefully this
3607         will cut down on the bugmail spam for slow bots.
3608
3609         * Scripts/webkitpy/tool/commands/sheriffbot.py:
3610
3611 2011-05-10  Eric Seidel  <eric@webkit.org>
3612
3613         Reviewed by Adam Barth.
3614
3615         EWS bots should be robust against test-webkitpy hangs
3616         https://bugs.webkit.org/show_bug.cgi?id=60579
3617
3618         Added a killAfterTimeout subroutine, which takes a child_pid
3619         and timeout, and will setup a watchdog process to kill that child
3620         after the timeout.  killAfterTimeout will waitpid on the child.
3621
3622         * EWSTools/start-queue.sh:
3623
3624 2011-05-10  MORITA Hajime  <morrita@google.com>
3625
3626         Unreviewed, moved myself to the reviewers list.
3627
3628         * Scripts/webkitpy/common/config/committers.py:
3629
3630 2011-05-10  Anton D'Auria  <adauria@apple.com>
3631
3632         Reviewed by David Levin.
3633
3634         StorageTracker should report actual local storage usage on disk
3635         https://bugs.webkit.org/show_bug.cgi?id=60558
3636
3637         * DumpRenderTree/LayoutTestController.cpp:
3638         (localStorageDiskUsageForOriginCallback):
3639         (LayoutTestController::staticFunctions):
3640         * DumpRenderTree/LayoutTestController.h:
3641         * DumpRenderTree/chromium/LayoutTestController.cpp:
3642         (LayoutTestController::LayoutTestController):
3643         (LayoutTestController::localStorageDiskUsageForOrigin):
3644         * DumpRenderTree/chromium/LayoutTestController.h:
3645         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3646         (LayoutTestController::localStorageDiskUsageForOrigin):
3647         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3648         (LayoutTestController::localStorageDiskUsageForOrigin):
3649         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3650         (LayoutTestController::localStorageDiskUsageForOrigin):
3651         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3652         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3653         (LayoutTestController::localStorageDiskUsageForOrigin):
3654
3655 2011-05-10  Anton D'Auria  <adauria@apple.com>
3656
3657         Reviewed by Alexey Proskuryakov.
3658
3659         Add ApplicationCache API to get disk usage per origin
3660         https://bugs.webkit.org/show_bug.cgi?id=57127
3661
3662         Added test that loads two frames with ~15Kb image, checks usage,
3663         deletes app cache, verifies usage is 0.
3664
3665         * DumpRenderTree/LayoutTestController.cpp:
3666         (applicationCacheDiskUsageForOriginCallback):
3667         (LayoutTestController::staticFunctions):
3668         * DumpRenderTree/LayoutTestController.h:
3669         * DumpRenderTree/chromium/LayoutTestController.cpp: Added stub.
3670         (LayoutTestController::LayoutTestController):
3671         (LayoutTestController::applicationCacheDiskUsageForOrigin):
3672         * DumpRenderTree/chromium/LayoutTestController.h:
3673         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added stub.
3674         (LayoutTestController::applicationCacheDiskUsageForOrigin):
3675         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3676         (LayoutTestController::applicationCacheDiskUsageForOrigin):
3677         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added stub.
3678         (LayoutTestController::applicationCacheDiskUsageForOrigin):
3679         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3680         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Added stub.
3681         (LayoutTestController::applicationCacheDiskUsageForOrigin):
3682
3683 2011-05-10  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
3684
3685         Unreviewed, adding Rafael Antognolli as a committer.
3686
3687         * Scripts/webkitpy/common/config/committers.py:
3688
3689 2011-05-10  Chris Evans  <cevans@chromium.org>
3690
3691         Reviewed by Adam Barth.
3692
3693         Add WebCore::Setting to block displaying and/or running insecure content on secure pages
3694         https://bugs.webkit.org/show_bug.cgi?id=58378
3695
3696         * DumpRenderTree/chromium/LayoutTestController.cpp:
3697         (LayoutTestController::LayoutTestController):
3698         (LayoutTestController::setAllowDisplayOfInsecureContent):
3699         (LayoutTestController::setAllowRunningOfInsecureContent):
3700         * DumpRenderTree/chromium/LayoutTestController.h:
3701         * DumpRenderTree/chromium/WebPreferences.cpp:
3702         (WebPreferences::reset):
3703         (WebPreferences::applyTo):
3704         * DumpRenderTree/chromium/WebPreferences.h:
3705         Add plumbing for new settings to Chromium DRT.
3706
3707 2011-05-10  Enrica Casucci  <enrica@apple.com>
3708
3709         Reviewed by Beth Dakin.
3710
3711         Added my name to the reviewers list and removed my name from
3712         to committer-only list.
3713
3714         * Scripts/webkitpy/common/config/committers.py:
3715
3716 2011-05-10  David Levin  <levin@chromium.org>
3717
3718         Reviewed by Shinichiro Hamaji.
3719
3720         check-webkit-style shouldn't filter the errors using the modified lines for the xml and test expectations checkers.
3721         https://bugs.webkit.org/show_bug.cgi?id=60466
3722
3723         * Scripts/webkitpy/style/checker.py: (unrelated) style fix.
3724         * Scripts/webkitpy/style/checker_unittest.py: Remove the file_path check since
3725           that property was removed.
3726         * Scripts/webkitpy/style/checkers/test_expectations.py: Turn off the line
3727           filtering for errors.
3728         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Add testing to
3729           verify that the line filtering is turned off.
3730         * Scripts/webkitpy/style/checkers/xml.py: Turn off the line filtering for errors
3731           and remove the unused file_path parameter.
3732         * Scripts/webkitpy/style/checkers/xml_unittest.py: Add testing to verify that the
3733           line filtering is turned off (and fix test_no_error).
3734         * Scripts/webkitpy/style/error_handlers.py: Added a way to turn off the filtering
3735           of errors based on the lines changed in the patch.
3736         * Scripts/webkitpy/style/error_handlers_unittest.py: Added a test for turning off
3737           the filtering.
3738
3739 2011-05-10  Adam Roben  <aroben@apple.com>
3740
3741         Update some plugin tests to work with WebKit2's asynchronous windowed plugin positioning on Windows
3742
3743         Fixes <http://webkit.org/b/60442> <rdar://problem/9403200> REGRESSION (r85795):
3744         platform/win/plugins/window-geometry-initialized-before-set-window.html and
3745         platform/win/plugins/window-region-is-set-to-clip-rect.html failing on Windows 7 Release
3746         (WebKit2 Tests)
3747
3748         Reviewed by Anders Carlsson.
3749
3750         * DumpRenderTree/TestNetscapePlugIn/Tests/win/NPNInvalidateRectInvalidatesWindow.cpp:
3751         (NPNInvalidateRectInvalidatesWindow::NPP_SetWindow): Moved some code from here to the new
3752         WindowedPluginTest::testHarnessWindow function.
3753
3754         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowGeometryInitializedBeforeSetWindow.cpp:
3755         (WindowGeometryInitializedBeforeSetWindow::NPP_SetWindow): Only check the window's size, not
3756         its position. In WebKit2, the position won't have been set yet, so we can't test it. But it
3757         turns out only the size mattered for <http://webkit.org/b/46716>, which this test was
3758         created for.
3759
3760         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowRegionIsSetToClipRect.cpp:
3761         (WindowRegionIsSetToClipRect::WindowRegionIsSetToClipRect): Converted to be a
3762         WindowedPluginTest, and initialized new members.
3763         (WindowRegionIsSetToClipRect::startTest): Make our plugin window visible, and set things up
3764         to ensure we get a WM_WINDOWPOSCHANGED message about it becoming visible.
3765         (WindowRegionIsSetToClipRect::finishTest): Check that the window region is what we expect,
3766         then clean up and tell the test harness we're done.
3767         (WindowRegionIsSetToClipRect::checkWindowRegion): Moved code to check the window region here
3768         from NPP_SetWindow. Changed to use the fancy new log() function instead of pluginLog().
3769         (WindowRegionIsSetToClipRect::showTestHarnessWindowIfNeeded): Show the test harness's window
3770         if it is hidden. This is needed to ensure we get a WM_WINDOWPOSCHANGED message when our own
3771         window becomes visible.
3772         (WindowRegionIsSetToClipRect::hideTestHarnessWindowIfNeeded): Hide the test harness's window
3773         if it was hidden at the start of the test.
3774         (WindowRegionIsSetToClipRect::wndProc): When our timer fires, tell the UI process to paint.
3775         This should cause our window to become visible and our window region to get set. When we get
3776         a WM_WINDOWPOSCHANGED message, we can finally finish the test.
3777         (WindowRegionIsSetToClipRect::NPP_GetValue): Return our script object.
3778         (WindowRegionIsSetToClipRect::ScriptObject::hasMethod): We only have one method:
3779         "startTest".
3780         (WindowRegionIsSetToClipRect::ScriptObject::invoke): Call through to the PluginTest object.
3781
3782         * DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.cpp:
3783         (WindowedPluginTest::testHarnessWindow):
3784         * DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.h:
3785         Added this helper function. Code came from NPNInvalidateRectInvalidatesWindow.
3786
3787 2011-05-10  Csaba Osztrogonác  <ossy@webkit.org>
3788
3789         Reviewed by Kenneth Rohde Christiansen.
3790
3791         [Qt] Add new qt-4.8 platform for layout testing
3792         https://bugs.webkit.org/show_bug.cgi?id=60544
3793
3794         * Scripts/old-run-webkit-tests:
3795         * Scripts/webkitdirs.pm:
3796
3797 2011-05-09  Sheriff Bot  <webkit.review.bot@gmail.com>
3798
3799         Unreviewed, rolling out r86108.
3800         http://trac.webkit.org/changeset/86108
3801         https://bugs.webkit.org/show_bug.cgi?id=60533
3802
3803         Broke makefile based builds and Cairo (Requested by weinig on
3804         #webkit).
3805
3806         * Scripts/build-api-tests:
3807         * Scripts/run-api-tests:
3808         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
3809         * TestWebKitAPI/Test.h:
3810         (TestWebKitAPI::Test::~Test):
3811         (TestWebKitAPI::Test::name):
3812         (TestWebKitAPI::Test::Register::Register):
3813         (TestWebKitAPI::Test::Register::create):
3814         (TestWebKitAPI::Test::Test):
3815         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3816         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
3817         (TestWebKitAPI::TEST):
3818         * TestWebKitAPI/TestsController.cpp:
3819         (TestWebKitAPI::TestsController::TestsController):
3820         (TestWebKitAPI::TestsController::dumpTestNames):
3821         (TestWebKitAPI::TestsController::runTestNamed):
3822         (TestWebKitAPI::TestsController::testFailed):
3823         (TestWebKitAPI::TestsController::registerCreateTestFunction):
3824         * TestWebKitAPI/TestsController.h:
3825         * TestWebKitAPI/mac/main.mm:
3826         (main):
3827
3828 2011-05-09  Hayato Ito  <hayato@chromium.org>
3829
3830         Reviewed by Ojan Vafai.
3831
3832         Skip reftests if pixel tests are disabled.
3833
3834         https://bugs.webkit.org/show_bug.cgi?id=59078
3835
3836         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
3837         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
3838         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
3839         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3840
3841 2011-05-09  Chang Shu  <cshu@webkit.org>
3842
3843         Reviewed by Kenneth Rohde Christiansen.
3844
3845         [Qt] DumpRenderTreeQt needs an implementation of unmarkText
3846         https://bugs.webkit.org/show_bug.cgi?id=60499
3847
3848         The implementation is similar to gtk.
3849
3850         * DumpRenderTree/qt/TextInputControllerQt.cpp:
3851         (TextInputController::unmarkText):
3852         * DumpRenderTree/qt/TextInputControllerQt.h:
3853
3854 2011-05-09  James Robinson  <jamesr@chromium.org>
3855
3856         Reviewed by Eric Seidel.
3857
3858         [chromium] Teach new-run-webkit-tests to follow symlinks when trying to determine the arch of DumpRenderTree on linux
3859         https://bugs.webkit.org/show_bug.cgi?id=60520
3860
3861         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3862
3863 2011-05-09  Dmitry Lomov  <dslomov@google.com>
3864
3865         Reviewed by Sam Weinig.
3866
3867         Switch TestWebKitAPI to GTest
3868         https://bugs.webkit.org/show_bug.cgi?id=59561
3869
3870         * Scripts/build-api-tests:
3871         * Scripts/run-api-tests:
3872         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
3873         * TestWebKitAPI/Test.h:
3874         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3875         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
3876         (TestWebKitAPI::TEST):
3877         * TestWebKitAPI/TestsController.cpp:
3878         (TestWebKitAPI::TestsController::TestsController):
3879         (TestWebKitAPI::TestsController::dumpTestNames):
3880         (TestWebKitAPI::TestsController::runTestNamed):
3881         (TestWebKitAPI::TestsController::runAllTests):
3882         * TestWebKitAPI/TestsController.h:
3883         * TestWebKitAPI/mac/main.mm:
3884         (main):
3885
3886 2011-05-09  Igor Oliveira  <igor.oliveira@openbossa.org>
3887
3888         Reviewed by Andreas Kling.
3889
3890         [Qt] DRT eventSender.addTouchPoint method is not setting the start position
3891         https://bugs.webkit.org/show_bug.cgi?id=60487
3892
3893         When adding a new touch point, the start position of this point needs to be set.
3894
3895         * DumpRenderTree/qt/EventSenderQt.cpp:
3896         (EventSender::addTouchPoint):
3897
3898 2011-05-09  Robert Hogan  <robert@webkit.org>
3899
3900         Reviewed by Adam Roben.
3901
3902         https://bugs.webkit.org/show_bug.cgi?id=57137
3903
3904         Unskip plugins/embed-prefers-plugins-for-images.html
3905
3906         Add image/png mime-type to test netscape plugin on Unix.
3907
3908         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3909         (NP_GetMIMEDescription):
3910
3911 2011-05-09  Alice Boxhall  <aboxhall@chromium.org>
3912
3913         Reviewed by Ojan Vafai.
3914
3915         Pull jsonresults_unittest test cases out into separate test methods.
3916         https://bugs.webkit.org/show_bug.cgi?id=60418
3917
3918         * TestResultServer/model/jsonresults_unittest.py:
3919
3920 2011-05-09  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
3921
3922         Reviewed by Andreas Kling.
3923
3924         [Qt] fix fast/dom/Geolocation/window-close-crash.html
3925         https://bugs.webkit.org/show_bug.cgi?id=60458
3926
3927         Update all pages with Mock position/error/permission.
3928
3929         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3930         (LayoutTestController::setGeolocationPermission):
3931         (LayoutTestController::setMockGeolocationError):
3932         (LayoutTestController::setMockGeolocationPosition):
3933
3934 2011-05-09  Shishir Agrawal  <shishir@chromium.org>
3935
3936         Reviewed by Tony Gentilcore.
3937
3938         Implement Page Visibility API.
3939         https://bugs.webkit.org/show_bug.cgi?id=54181
3940
3941         * DumpRenderTree/LayoutTestController.cpp:
3942         (setPageVisibilityCallback):
3943         (resetPageVisibilityCallback):
3944         (LayoutTestController::staticFunctions):
3945         * DumpRenderTree/LayoutTestController.h:
3946         (LayoutTestController::setPageVisibility):
3947         (LayoutTestController::resetPageVisibility):
3948         * DumpRenderTree/chromium/LayoutTestController.cpp:
3949         (LayoutTestController::LayoutTestController):
3950         (LayoutTestController::resetPageVisibility):
3951         (LayoutTestController::setPageVisibility):
3952         * DumpRenderTree/chromium/LayoutTestController.h:
3953
3954 2011-05-07  Adam Barth  <abarth@webkit.org>
3955
3956         Reviewed by Eric Seidel.
3957
3958         Testing EWS spins on patches with a large number of failures
3959         https://bugs.webkit.org/show_bug.cgi?id=60441
3960
3961         In cases where the tree has a small number of persistent failures but a
3962         patch has a large number of failures, we weren't believing any results.
3963         That lead to us retrying the patch forever while we waited for
3964         trustworthy results that would never come.
3965
3966         This patch loosens the semantics of unexpected_failures to return a
3967         subset (rather than the exact set) of unexpected failures.  In the case
3968         where the tree has a bounded number of failures and the patch has an
3969         unbounded number of failures, we can accurately compute such a subset
3970         and reject the patch.
3971
3972         * Scripts/webkitpy/tool/bot/expectedfailures.py:
3973         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
3974         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
3975         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3976         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3977
3978 2011-05-07  Joe Mason  <jmason@rim.com>
3979
3980         Reviewed by Daniel Bates.
3981
3982         FrameLoader::isProcessingUserGesture is wrong in dispatchWillPerformClientRedirect
3983         https://bugs.webkit.org/show_bug.cgi?id=52211
3984
3985         Dump isUserProcessingGesture in willPerformClientRedirect so that the layout tests can be extended.
3986         (For the Mac and Chromium ports - other ports don't support dumping user gestures in DRT.)
3987
3988         * DumpRenderTree/chromium/WebViewHost.cpp:
3989         (WebViewHost::willPerformClientRedirect):
3990         (WebViewHost::didStartProvisionalLoad):
3991         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3992         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
3993
3994 2011-05-07  Daniel Bates  <dbates@webkit.org>
3995
3996         Attempt to fix the build; remove some more references to isTiger(), which was removed in changeset 86007
3997         <http://trac.webkit.org/changeset/86007> (bug #60438).
3998
3999         * Scripts/old-run-webkit-tests:
4000           - Removed reference to isTiger() from openDumpTool(), captureSavedCrashLog(), and
4001             file local variable. 
4002
4003 2011-05-07  Pratik Solanki  <psolanki@apple.com>
4004
4005         Reviewed by Darin Adler.
4006
4007         Remove references to Tiger in scripts
4008         https://bugs.webkit.org/show_bug.cgi?id=60438
4009
4010         Remove isTiger() and all of the code that depends on it.
4011
4012         * Scripts/build-webkit:
4013         * Scripts/ensure-valid-python:
4014         * Scripts/gdb-safari:
4015         * Scripts/webkitdirs.pm:
4016
4017 2011-05-06  David Grogan  <dgrogan@chromium.org>
4018
4019         Reviewed by Eric Seidel.
4020
4021         update link to message about mac 64bit git binaries
4022         https://bugs.webkit.org/show_bug.cgi?id=60411
4023
4024         The original message implied (correctly, at-the-time) that
4025         http://code.google.com/p/git-osx-installer/ doesn't provide 64-bit
4026         binaries. The new message notes that they do. This might prevent someone
4027         else from spending a few minutes confused.
4028
4029         * Scripts/webkitpy/common/checkout/scm/git.py:
4030
4031 2011-05-06  Dirk Pranke  <dpranke@chromium.org>
4032
4033         Reviewed by Ojan Vafai.
4034
4035         new-run-webkit-tests: crashes in race with crashing DRT
4036         https://bugs.webkit.org/show_bug.cgi?id=60238
4037
4038         This fixes a race where if we wrote the URL to DRT and
4039         DRT crashed immediately, we could get a broken pipe
4040         error back during the write() and not handle it correctly,
4041         causing NRWT to also crash.
4042
4043         * Scripts/webkitpy/layout_tests/port/server_process.py:
4044         * Scripts/webkitpy/layout_tests/port/webkit.py:
4045
4046 2011-05-06  Adam Barth  <abarth@webkit.org>
4047
4048         Reviewed by Eric Seidel.
4049
4050         Add a --skip-integrationtests mode to test-webkitpy
4051         https://bugs.webkit.org/show_bug.cgi?id=60354
4052
4053         These two test suites account for 2/3 of test-webkitpy's running time
4054         because they're not actually unit tests.  They're integration tests.
4055         This patch adds the ability to skip integration tests by passing a
4056         command line argument to test-webkitpy.  The buildbots will continue to
4057         run these integration tests to make sure they don't regress.  This
4058         option is for use by developers when working on parts of the code that
4059         are well-covered by unit tests.
4060
4061         * Scripts/webkitpy/common/system/file_lock_integrationtest.py: Copied from Tools/Scripts/webkitpy/common/system/file_lock_unittest.py.
4062         * Scripts/webkitpy/common/system/file_lock_unittest.py: Removed.
4063         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Copied from Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py.
4064         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: Removed.
4065         * Scripts/webkitpy/test/main.py:
4066
4067 2011-05-06  Adam Barth  <abarth@webkit.org>
4068
4069         Reviewed by Eric Seidel.
4070
4071         The results.zip generated by the Chromium EWS are too big
4072         https://bugs.webkit.org/show_bug.cgi?id=60352
4073
4074         Currently results.zip created by the Chromium EWS bot contain roughly
4075         1000 tests that we expect to fail.  These test results are not helpful
4076         to contributors.
4077
4078         There are several approaches to solving this problem:
4079
4080         1) We could be more selective about which files to include in the zip.
4081         2) We could ask new-run-webkit-tests not to generate results for
4082            expected failures.
4083         3) We could ask new-run-webkit-tests not to run tests that we expect to
4084            fail.
4085
4086         This patch takes approach (3).  Currently, we're ignoring the outcome
4087         of failing tests anyway, so there's not much point in actually running
4088         them.  As a side benefit, this will speed up the test run by about 6%.
4089         In the future, we might revisit this decision and choose another
4090         approach.
4091
4092         * Scripts/webkitpy/common/config/ports.py:
4093         * Scripts/webkitpy/common/config/ports_unittest.py:
4094
4095 2011-05-06  Gabor Rapcsanyi  <rgabor@webkit.org>
4096
4097         Reviewed by Csaba Osztrogonác.
4098
4099         [Qt] Use qt-arm platform instead of qt-linux on ARM platform.
4100
4101         * Scripts/old-run-webkit-tests:
4102
4103 2011-05-06  Adam Barth  <abarth@webkit.org>
4104
4105         Reviewed by Ojan Vafai.
4106
4107         Add an option to NRWT to skip failing tests
4108         https://bugs.webkit.org/show_bug.cgi?id=60295
4109
4110         This option is similar to the way old-run-webkit-tests works.  We're
4111         planning to use this option on the testing EWS bots because they don't
4112         use information from failing tests yet.
4113
4114         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
4115         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4116         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
4117
4118 2011-05-04  Philippe Normand  <pnormand@igalia.com>
4119
4120         Reviewed by Dimitri Glazkov.
4121
4122         Implement LayoutTestController::pseudoShadowId()
4123         https://bugs.webkit.org/show_bug.cgi?id=60034
4124
4125         shadowPseudoId support in the various LayoutTestController
4126         implementations.
4127
4128         * DumpRenderTree/LayoutTestController.cpp:
4129         (shadowPseudoIdCallback):
4130         (LayoutTestController::staticFunctions):
4131         * DumpRenderTree/LayoutTestController.h:
4132         * DumpRenderTree/chromium/LayoutTestController.cpp:
4133         (LayoutTestController::LayoutTestController):
4134         (LayoutTestController::shadowPseudoId):
4135         * DumpRenderTree/chromium/LayoutTestController.h:
4136         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4137         (LayoutTestController::shadowPseudoId):
4138         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
4139         (LayoutTestController::shadowPseudoId):
4140         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4141         (LayoutTestController::shadowPseudoId):
4142         * DumpRenderTree/qt/LayoutTestControllerQt.h:
4143         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4144         (LayoutTestController::shadowPseudoId):
4145         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
4146         (LayoutTestController::shadowPseudoId):
4147         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
4148         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
4149         (WTR::LayoutTestController::shadowPseudoId):
4150         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
4151
4152 2011-05-06  Adam Barth  <abarth@webkit.org>
4153
4154         EWS can't reject patches
4155         https://bugs.webkit.org/show_bug.cgi?id=60345
4156
4157         We're supposed to use patch.id() for the attachment ID, silly.
4158
4159         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
4160         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
4161
4162 2011-05-05  Steve Lacey  <sjl@chromium.org>
4163
4164         Reviewed by Ojan Vafai.
4165
4166         Fix generation of results html file by passing relative path to scm
4167         methods.
4168         Generate diff images for results html file.
4169
4170         https://bugs.webkit.org/show_bug.cgi?id=60086
4171
4172         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
4173         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
4174
4175 2011-05-05  Andy Estes  <aestes@apple.com>
4176
4177         Reviewed by Daniel Bates.
4178
4179         update-webkit should handle Internal using a different VCS than OpenSource.
4180         https://bugs.webkit.org/show_bug.cgi?id=60310
4181
4182         isGit() and isSVN() cache their results, so Internal will always be
4183         updated using the VCS commands used for OpenSource. If Internal uses a
4184         different VCS, this will fail. Fix this by calling isGitDirectory() and
4185         isSVNDirectory() instead, which do not cache their results.
4186
4187         * Scripts/update-webkit:
4188
4189 2011-05-05  Dirk Pranke  <dpranke@chromium.org>
4190
4191         Reviewed by Ojan Vafai.
4192
4193         nrwt: revamp integration tests incl. tests for servers
4194         https://bugs.webkit.org/show_bug.cgi?id=59985
4195
4196         This change adds the ability to run "integration tests" that
4197         depend on (and affect) the local environment on your machine.
4198         These tests can be run manually by invoking python on the
4199         test file in question and passing the '-i' flag, but are
4200         not run automatically as part of test-webkitpy.
4201
4202         Integration tests are identified by being methods named as
4203         "integration_test_*" instead of "test_*", and we use a
4204         custom TestLoader instead of the default one provided by
4205         unittest.
4206
4207         This change also adds a protected "_default_to_apache" method
4208         to the port object so we can do the right thing when starting
4209         and stopping web servers with less mechanism.
4210
4211         * Scripts/webkitpy/layout_tests/port/base.py:
4212         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
4213         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
4214         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
4215         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
4216         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
4217
4218 2011-05-05  Adam Roben  <aroben@apple.com>
4219
4220         Robustify DRT's pixel-dumping code against semi-random alpha channel values on Windows
4221
4222         DRT generates a pixel dump on Windows using the WM_PRINT message. This message (just like
4223         most of GDI) doesn't write anything meaningful into the alpha channel. In some cases, the
4224         alpha channel will even get filled with zeros (like when ::GradientFill is used). To
4225         safeguard against this, we fill the alpha channel with constant full opacity after the
4226         WM_PRINT message is handled to ensure we end up with an opaque image. (Note that we can't
4227         just ignore the alpha channel when creating the PNG; Mac's pixel results have an alpha
4228         channel, and we want to be able to compare Mac and Windows pixel results, so Windows pixel
4229         results need an alpha channel, too.)
4230
4231         Fixes <http://webkit.org/b/60300> draws-gradient.html's pixel results can't be correctly
4232         generated due to alpha channel weirdness
4233
4234         Reviewed by Sam Weinig.
4235
4236         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
4237         (makeAlphaChannelOpaque): Added this helper function to fill a bitmap's alpha channel with
4238         constant full opacity.
4239         (createBitmapContextFromWebView): Make the bitmap's alpha channel opaque before wrapping it
4240         in a CGContext or cairo_surface.
4241
4242 2011-05-05  Adam Roben  <aroben@apple.com>
4243
4244         Add support for layoutTestController.dumpAsText(true) to WebKitTestRunner
4245
4246         Passing true tells the test harness to dump pixels even though we're not dumping a render
4247         tree.
4248
4249         Fixes <http://webkit.org/b/60298> Calling layoutTestController.dumpAsText(true) in
4250         WebKitTestRunner doesn't result in pixel results being generated
4251
4252         Reviewed by Sam Weinig.
4253
4254         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added dumpPixels
4255         argument to dumpAsText.
4256
4257         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4258         (WTR::InjectedBundlePage::dump): Updated for dumpAsText change.
4259
4260         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
4261         (WTR::LayoutTestController::dumpAsText): Store the dumpPixels argument.
4262
4263         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Updated for IDL change.
4264
4265         * WebKitTestRunner/win/InjectedBundle.vcproj: Added .idl files as a convenience for Windows
4266         developers.
4267
4268 2011-05-05  Dirk Pranke  <dpranke@chromium.org>
4269
4270         Reviewed by Ojan Vafai.
4271
4272         new-run-webkit-tests: merge os, version fields in test config
4273         https://bugs.webkit.org/show_bug.cgi?id=60004
4274
4275         This change removes the 'o/s' field from the TestConfiguration
4276         object, and changes the 'MAC', 'WIN', and 'LINUX' modifiers in
4277         the expectations file to macros that expand to the version names
4278         for each platform.
4279
4280         This means that you can once again put any subset of the
4281         operating system versions on a single line, e.g.:
4282           BUGX LEOPARD XP LINUX : fast/html/foo.html = FAIL
4283
4284         This change will break any existing test_expectations.txt
4285         file that uses the "OS-VERSION" macros, which are no longer
4286         needed. It turns out they were never needed, as just VERSION
4287         by itself was sufficient. The test_expectations.txt file should
4288         be updated accordingly prior to landing this change.
4289
4290         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
4291         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
4292         * Scripts/webkitpy/layout_tests/port/base.py:
4293
4294 2011-05-05  Tony Chang  <tony@chromium.org>
4295
4296         Reviewed by Adam Barth.
4297
4298         [chromium] switch from Lucida to free fonts for Hindi and Thai
4299         https://bugs.webkit.org/show_bug.cgi?id=60287
4300
4301         The fonts are provided by the ttf-thai-tlwg and ttf-indic-fonts
4302         packages on Lucid. There are actually multiple Thai fonts in the
4303         package, so I just picked one.
4304
4305         * DumpRenderTree/chromium/TestShellGtk.cpp:
4306         (setupFontconfig):
4307
4308 2011-05-05  Tony Chang  <tony@chromium.org>
4309
4310         Reviewed by Ojan Vafai.
4311
4312         [chromium] google-chrome-64 builds should now fallback to chromium-linux-x86_64 results
4313         https://bugs.webkit.org/show_bug.cgi?id=60290
4314
4315         It used to be that google-chrome-32 was hardy32, google-chrome-64 was
4316         hardy64, chromium-linux was hardy32 and chromium-linux-x86_64 was
4317         lucid64.  Because of that, google-chrome-64 used to skip the
4318         chromium-linux-x86_64 results since they were more incorrect.
4319
4320         Now that we're switching to lucid for google-chrome, we want
4321         google-chrome-64 to fall back to chromium-linux-x86_64.
4322
4323         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
4324
4325 2011-05-05  Dirk Pranke  <dpranke@chromium.org>
4326
4327         Reviewed by Ojan Vafai.
4328
4329         new-run-webkit-te