[LFC][Floats] Add support for placing formatting roots in-between floats.
[WebKit-https.git] / Tools / ChangeLog
1 2019-02-21  Zalan Bujtas  <zalan@apple.com>
2
3         [LFC][Floats] Add support for placing formatting roots in-between floats.
4         https://bugs.webkit.org/show_bug.cgi?id=194902
5
6         Reviewed by Antti Koivisto.
7
8         * LayoutReloaded/misc/LFC-passing-tests.txt:
9
10 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
11
12         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
13         https://bugs.webkit.org/show_bug.cgi?id=194901
14
15         Unreviewed build fix.
16
17         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
18         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
19         WPEBackend-fdo-0.1 as library name.
20
21 2019-02-21  Rob Buis  <rbuis@igalia.com>
22
23         Update MIME type parser
24         https://bugs.webkit.org/show_bug.cgi?id=180526
25
26         Reviewed by Darin Adler.
27
28         Add tests involving leading and trailing whitespace, non-token
29         characters and quoted strings.
30
31         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
32         (TestWebKitAPI::TEST):
33
34 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
35
36         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
37         https://bugs.webkit.org/show_bug.cgi?id=194884
38
39         Reviewed by Michael Catanzaro.
40
41         * PlatformWin.cmake:
42
43 2019-02-20  Chris Dumez  <cdumez@apple.com>
44
45         Add API test for <rdar://problem/47471222>
46         https://bugs.webkit.org/show_bug.cgi?id=194847
47
48         Reviewed by Alex Christensen.
49
50         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
51
52 2019-02-20  Chris Dumez  <cdumez@apple.com>
53
54         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
55         https://bugs.webkit.org/show_bug.cgi?id=194872
56         <rdar://problem/47924500>
57
58         Reviewed by Alex Christensen.
59
60         Add API test coverage.
61
62         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
63
64 2019-02-20  Jer Noble  <jer.noble@apple.com>
65
66         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
67         https://bugs.webkit.org/show_bug.cgi?id=191332
68
69         Reviewed by Dean Jackson.
70
71         * Scripts/git-is-in-range: Added.
72
73 2019-02-20  Andy Estes  <aestes@apple.com>
74
75         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
76         https://bugs.webkit.org/show_bug.cgi?id=194869
77
78         Rubber-stamped by Jer Noble.
79
80         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
81         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
82         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
83         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
84         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
85         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
86
87 2019-02-20  Chris Dumez  <cdumez@apple.com>
88
89         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
90         https://bugs.webkit.org/show_bug.cgi?id=194857
91         <rdar://problem/47759323>
92
93         Reviewed by Alex Christensen.
94
95         Add API test coverage.
96
97         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
98
99 2019-02-20  Chris Dumez  <cdumez@apple.com>
100
101         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
102         https://bugs.webkit.org/show_bug.cgi?id=194829
103         <rdar://problem/47889906>
104
105         Reviewed by Alexey Proskuryakov.
106
107         Every time the TestOptions were changing we were creating both a new Web view and
108         a new WKContext, which would start a new Network process. In most cases, we only
109         need to contruct a new Web view and we do can keep reusing the same WKContext.
110         This patch implements this optimization and thus avoids spinning a lot of new
111         Network processes while running the layout tests.
112
113         * WebKitTestRunner/TestController.cpp:
114         (WTR::TestController::generateContextConfiguration const):
115         (WTR::TestController::generatePageConfiguration):
116         (WTR::TestController::createWebViewWithOptions):
117         (WTR::TestController::resetPreferencesToConsistentValues):
118         (WTR::updateTestOptionsFromTestHeader):
119         * WebKitTestRunner/TestController.h:
120         * WebKitTestRunner/TestOptions.h:
121         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
122         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
123         (WTR::TestOptions::hasSameInitializationOptions const):
124         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
125         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
126         (WTR::TestController::platformAddTestOptions const):
127
128 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
129
130         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
131         https://bugs.webkit.org/show_bug.cgi?id=167941
132
133         Reviewed by Carlos Garcia Campos.
134
135         * MiniBrowser/gtk/main.c:
136         (filterSavedCallback): Added.
137         (main): Support loading a JSON rule set file for content filtering.
138         * MiniBrowser/wpe/main.cpp:
139         (filterSavedCallback): Added.
140         (main): Support loading a JSON rule set file for content filtering.
141         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
142         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
143         (WTF::derefGPtr): Ditto.
144         (testEmptyStore):
145         (testSaveInvalidFilter):
146         (testSaveLoadFilter):
147         (testSavedFilterIdentifierMatch):
148         (testRemoveFilter):
149         (testSaveMultipleFilters):
150         (testSaveFilterFromFile):
151         (testFilterPersistence):
152         (beforeAll):
153         (afterAll):
154         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
155         (removeOldInjectedContentAndResetLists): Also reset content filters.
156         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
157         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
158         the element affected by the style sheet.
159         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
160         and returns it to be used by tests.
161         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
162         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
163         (serverCallback): Add support for serving a CSS style sheet for testing.
164         (beforeAll): Add call to testUserContentManagerContentFilter().
165         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
166
167 2019-02-19  Keith Rollin  <krollin@apple.com>
168
169         Add timing information to build output
170         https://bugs.webkit.org/show_bug.cgi?id=194839
171         <rdar://problem/48219609>
172
173         Reviewed by Alexey Proskuryakov.
174
175         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
176         emit each project's build time to its output. E.g.,
177
178             ** BUILD SUCCEEDED ** [0.132 sec]
179
180         * Scripts/webkitdirs.pm:
181         (XcodeOptions):
182
183 2019-02-19  Truitt Savell  <tsavell@apple.com>
184
185         Unreviewed, rolling out r241784.
186
187         Broke all OpenSource builds.
188
189         Reverted changeset:
190
191         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
192         instances view"
193         https://bugs.webkit.org/show_bug.cgi?id=172848
194         https://trac.webkit.org/changeset/241784
195
196 2019-02-19  Zalan Bujtas  <zalan@apple.com>
197
198         [LFC][Floats] Remove redundant intersecting logic
199         https://bugs.webkit.org/show_bug.cgi?id=194804
200
201         Reviewed by Antti Koivisto.
202
203         * LayoutReloaded/misc/LFC-passing-tests.txt:
204
205 2019-02-19  Dean Jackson  <dino@apple.com>
206
207         Clean-up output from generate-xcfilelists so it can be filtered
208         https://bugs.webkit.org/show_bug.cgi?id=194795
209
210         Reviewed by Joseph Pecoraro (and Keith Rollin).
211
212         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
213         make a slight tweak to filter-build-webkit so such lines are marked
214         as plain.
215
216         * Scripts/filter-build-webkit:
217         * Scripts/generate-xcfilelists:
218
219 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
220
221         pytest is not correctly auto-installed
222         https://bugs.webkit.org/show_bug.cgi?id=194707
223
224         Reviewed by Carlos Garcia Campos.
225
226         * Scripts/webkitpy/thirdparty/__init__.py:
227         (AutoinstallImportHook._install_pytest):
228
229 2019-02-18  Chris Dumez  <cdumez@apple.com>
230
231         REGRESSION (PSON): Can't access optumbank.com from myuhc.com
232         https://bugs.webkit.org/show_bug.cgi?id=194797
233         <rdar://problem/48055151>
234
235         Reviewed by Geoffrey Garen.
236
237         Add API test coverage.
238
239         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
240
241 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
242
243         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
244         https://bugs.webkit.org/show_bug.cgi?id=194670
245         <rdar://problem/39066529>
246
247         Reviewed by Tim Horton.
248
249         Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
250         pasted in an editable area as attachment elements.
251
252         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
253         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
254         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
255         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
256         (TestWebKitAPI::TEST):
257         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
258         (WTR::InjectedBundlePage::InjectedBundlePage):
259
260 2019-02-18  Alex Christensen  <achristensen@webkit.org>
261
262         Fix API test after r241728
263        ​https://bugs.webkit.org/show_bug.cgi?id=194723
264
265         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
266         (TEST):
267         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
268
269 2019-02-18  Daniel Bates  <dabates@apple.com>
270
271         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
272         https://bugs.webkit.org/show_bug.cgi?id=192824
273         <rdar://problem/47100332>
274
275         Reviewed by Wenson Hsieh.
276
277         Fix a bug where the wrong usage code was used for F13 thru F24.
278
279         * WebKitTestRunner/ios/HIDEventGenerator.mm:
280         (keyCodeForDOMFunctionKey):
281
282 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
283
284         Bytecode cache should a have a boot-specific validation
285         https://bugs.webkit.org/show_bug.cgi?id=194769
286         <rdar://problem/48149509>
287
288         Reviewed by Keith Miller.
289
290         Add test for WTF::bootSessionUUIDString()
291
292         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
293         * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
294         (TEST):
295
296 2019-02-18  Alex Christensen  <achristensen@webkit.org>
297
298         Disable safe browsing in WKWebView and remove its WKPreferences API
299         https://bugs.webkit.org/show_bug.cgi?id=194723
300         <rdar://problem/48122993>
301
302         Reviewed by Geoffrey Garen.
303
304         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
305         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
306         (TEST):
307         (safeBrowsingView):
308         Make tests use SPI instead of API.
309
310 2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
311
312         Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
313         https://bugs.webkit.org/show_bug.cgi?id=194586
314
315         Reviewed by Ross Kirsling.
316
317         * DumpRenderTree/win/DumpRenderTree.cpp:
318         (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
319         * Scripts/webkitpy/port/driver.py:
320         (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
321
322 2019-02-17  David Kilzer  <ddkilzer@apple.com>
323
324         Unreviewed, rolling out r241620.
325
326         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
327         (Requested by ddkilzer on #webkit.)
328
329         Reverted changeset:
330
331         "[WTF] Add environment variable helpers"
332         https://bugs.webkit.org/show_bug.cgi?id=192405
333         https://trac.webkit.org/changeset/241620
334
335 2019-02-16  Zalan Bujtas  <zalan@apple.com>
336
337         [LFC] RenderImage's default intrinsic size is 0.
338         https://bugs.webkit.org/show_bug.cgi?id=194745
339
340         Reviewed by Antti Koivisto.
341
342         * LayoutReloaded/misc/LFC-passing-tests.txt:
343
344 2019-02-16  Zalan Bujtas  <zalan@apple.com>
345
346         [LFC][BFC] Add support for block replaced intrinsic width.
347         https://bugs.webkit.org/show_bug.cgi?id=194705
348
349         Reviewed by Simon Fraser.
350
351         * LayoutReloaded/misc/LFC-passing-tests.txt:
352
353 2019-02-16  Zalan Bujtas  <zalan@apple.com>
354
355         [LFC] Apply min/max width constraints to preferred width computation
356         https://bugs.webkit.org/show_bug.cgi?id=194739
357
358         Reviewed by Simon Fraser.
359
360         * LayoutReloaded/misc/LFC-passing-tests.txt:
361
362 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
363
364         [WTF] Add environment variable helpers
365         https://bugs.webkit.org/show_bug.cgi?id=192405
366
367         Reviewed by Michael Catanzaro.
368
369         * DumpRenderTree/mac/DumpRenderTree.mm:
370         (libraryPathForDumpRenderTree):
371         * DumpRenderTree/win/DumpRenderTree.cpp:
372         (libraryPathForDumpRenderTree):
373         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
374         (setUpIOSLayoutTestCommunication):
375         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
376         (beforeAll):
377         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
378         (main):
379         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
380         (WebKitTestBus::run):
381         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
382         (WTR::getOutputDir):
383         (WTR::initializeFontConfigSetting):
384         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
385         (WTR::InjectedBundle::platformInitialize):
386         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
387         (WTR::topLevelPath):
388         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
389         (WTR::topLevelPath):
390         (WTR::getOutputDir):
391         (WTR::activateFonts):
392         * WebKitTestRunner/TestController.cpp:
393         (WTR::TestController::libraryPathForTesting):
394         (WTR::TestController::generateContextConfiguration const):
395         (WTR::TestController::generatePageConfiguration):
396         (WTR::TestController::decideDestinationWithSuggestedFilename):
397         (WTR::TestController::platformAdjustContext):
398         * WebKitTestRunner/TestController.h:
399         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
400         (WTR::TestController::cocoaPlatformInitialize):
401         (WTR::TestController::platformAdjustContext):
402         * WebKitTestRunner/gtk/main.cpp:
403         (main):
404         * WebKitTestRunner/mac/TestControllerMac.mm:
405         (WTR::TestController::configureContentExtensionForTest):
406         * WebKitTestRunner/wpe/main.cpp:
407         (main):
408         Utilize WTF::Environment where possible.
409
410 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
411
412         [iOS] WKWebView callout bar is missing Change Writing Direction item
413         https://bugs.webkit.org/show_bug.cgi?id=190015
414         <rdar://problem/44810366>
415
416         Reviewed by Tim Horton.
417
418         Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
419         macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
420
421         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
422         (TestWebKitAPI::TEST):
423
424 2019-02-15  Chris Dumez  <cdumez@apple.com>
425
426         Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
427         https://bugs.webkit.org/show_bug.cgi?id=194717
428         <rdar://problem/47884404>
429
430         Reviewed by Brady Eidson.
431
432         Add API test coverage.
433
434         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
435
436 2019-02-15  Youenn Fablet  <youenn@apple.com>
437
438         Make navigator.mediaDevices SecureContext
439         https://bugs.webkit.org/show_bug.cgi?id=194666
440
441         Reviewed by Eric Carlson.
442
443         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
444         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
445         (TEST_F):
446
447 2019-02-15  Brian Burg  <bburg@apple.com>
448
449         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
450         https://bugs.webkit.org/show_bug.cgi?id=194411
451         <rdar://problem/47787614>
452
453         Reviewed by Joseph Pecoraro.
454
455         Remove unnecessary soft linking macro usage.
456
457         * DumpRenderTree/mac/TestRunnerMac.mm:
458         (TestRunner::inspectorTestStubURL):
459         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
460         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
461         (WTR::TestRunner::inspectorTestStubURL):
462
463 2019-02-15  Commit Queue  <commit-queue@webkit.org>
464
465         Unreviewed, rolling out r241559 and r241566.
466         https://bugs.webkit.org/show_bug.cgi?id=194710
467
468         Causes layout test crashes under GuardMalloc (Requested by
469         ryanhaddad on #webkit).
470
471         Reverted changesets:
472
473         "[WTF] Add environment variable helpers"
474         https://bugs.webkit.org/show_bug.cgi?id=192405
475         https://trac.webkit.org/changeset/241559
476
477         "Unreviewed build fix for WinCairo Debug after r241559."
478         https://trac.webkit.org/changeset/241566
479
480 2019-02-15  Zalan Bujtas  <zalan@apple.com>
481
482         [LFC] Out-of-flow box is never a float box
483         https://bugs.webkit.org/show_bug.cgi?id=194704
484
485         Reviewed by Antti Koivisto.
486
487         * LayoutReloaded/misc/LFC-passing-tests.txt:
488
489 2019-02-10  Darin Adler  <darin@apple.com>
490
491         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
492         https://bugs.webkit.org/show_bug.cgi?id=194487
493
494         Reviewed by Daniel Bates.
495
496         * DumpRenderTree/win/DumpRenderTree.cpp:
497         (applicationId): Use makeString instead of String::format.
498         (main): Ditto.
499         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
500         (TestWebKitAPI::Util::createURLForResource): Ditto.
501         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
502         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Ditto.
503
504         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
505         (WTR::attributeSetToString): Use StringBuilder functions directly instead of g_strconcat.
506         (WTR::attributesOfElement): Use StringBuilder functions directly instead of String::format.
507         (WTR::createStringWithAttributes): Use appendLiteral.
508         (WTR::AccessibilityUIElement::helpText const): Ditto.
509         (WTR::AccessibilityUIElement::attributedStringForRange): Use StringBuilder functions
510         directly instead of using String::format.
511         (WTR::AccessibilityUIElement::url): Use makeString instead of String::format.
512         (WTR::stringAtOffset): Use StringBuilder::appendNumber instead of String::format.
513
514 2019-02-15  Truitt Savell  <tsavell@apple.com>
515
516         Unreviewed, rolling out r241564.
517
518         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
519
520         Reverted changeset:
521
522         "[Mac] WebInspectorUI.framework does not need to be soft-
523         linked anymore"
524         https://bugs.webkit.org/show_bug.cgi?id=194411
525         https://trac.webkit.org/changeset/241564
526
527 2019-02-15  Saam barati  <sbarati@apple.com>
528
529         [WebAssembly] Write a new register allocator for Air O0 and make BBQ use it
530         https://bugs.webkit.org/show_bug.cgi?id=194036
531
532         Reviewed by Yusuke Suzuki.
533
534         * Scripts/run-jsc-stress-tests:
535
536 2019-02-14  Tim Horton  <timothy_horton@apple.com>
537
538         Fix the build.
539
540         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
541         (WTR::UIScriptController::drawSquareInEditableImage):
542         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
543         (TestWebKitAPI::drawSquareInEditableImage):
544
545 2019-02-14  Tim Horton  <timothy_horton@apple.com>
546
547         Fix the build.
548
549         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
550         (WTR::UIScriptController::drawSquareInEditableImage):
551         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
552         (TestWebKitAPI::drawSquareInEditableImage):
553
554 2019-02-14  Brian Burg  <bburg@apple.com>
555
556         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
557         https://bugs.webkit.org/show_bug.cgi?id=194411
558         <rdar://problem/47787614>
559
560         Reviewed by Joseph Pecoraro.
561
562         Remove unnecessary soft linking macro usage.
563
564         * DumpRenderTree/mac/TestRunnerMac.mm:
565         (TestRunner::inspectorTestStubURL):
566         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
567         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
568         (WTR::TestRunner::inspectorTestStubURL):
569
570 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
571
572         [ews-app] status bubble should fetch builder name info from BuilderMapping table
573         https://bugs.webkit.org/show_bug.cgi?id=194599
574
575         Reviewed by Lucas Forschler.
576
577         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
578         (StatusBubble._build_bubble):
579
580 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
581
582         [ews-app] Set Foreign Key in Django build model
583         https://bugs.webkit.org/show_bug.cgi?id=194667
584
585         Reviewed by Lucas Forschler.
586
587         * BuildSlaveSupport/ews-app/ews/models/build.py:
588         (Build):
589
590 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
591
592         [WTF] Add environment variable helpers
593         https://bugs.webkit.org/show_bug.cgi?id=192405
594
595         Reviewed by Michael Catanzaro.
596
597         * DumpRenderTree/mac/DumpRenderTree.mm:
598         (libraryPathForDumpRenderTree):
599         * DumpRenderTree/win/DumpRenderTree.cpp:
600         (libraryPathForDumpRenderTree):
601         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
602         (setUpIOSLayoutTestCommunication):
603         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
604         (TestWebKitAPI::strip):
605         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
606         (beforeAll):
607         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
608         (main):
609         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
610         (WebKitTestBus::run):
611         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
612         (WTR::getOutputDir):
613         (WTR::initializeFontConfigSetting):
614         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
615         (WTR::InjectedBundle::platformInitialize):
616         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
617         (WTR::topLevelPath):
618         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
619         (WTR::topLevelPath):
620         (WTR::getOutputDir):
621         (WTR::activateFonts):
622         * WebKitTestRunner/TestController.cpp:
623         (WTR::TestController::libraryPathForTesting):
624         (WTR::TestController::generateContextConfiguration const):
625         (WTR::TestController::generatePageConfiguration):
626         (WTR::TestController::decideDestinationWithSuggestedFilename):
627         (WTR::TestController::platformAdjustContext):
628         * WebKitTestRunner/TestController.h:
629         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
630         (WTR::TestController::cocoaPlatformInitialize):
631         (WTR::TestController::platformAdjustContext):
632         * WebKitTestRunner/gtk/main.cpp:
633         (main):
634         * WebKitTestRunner/mac/TestControllerMac.mm:
635         (WTR::TestController::configureContentExtensionForTest):
636         * WebKitTestRunner/wpe/main.cpp:
637         (main):
638         Utilize WTF::Environment where possible.
639
640 2019-02-14  Chris Dumez  <cdumez@apple.com>
641
642         [PSON] Introduce a WebContent Process cache
643         https://bugs.webkit.org/show_bug.cgi?id=194594
644         <rdar://problem/46793397>
645
646         Reviewed by Geoff Garen.
647
648         Update API tests to turn on the WebContent Process cache.
649
650         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
651
652 2019-02-14  Jiewen Tan  <jiewen_tan@apple.com>
653
654         Unreviewed, build fix after r241480
655
656         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
657         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
658         (-[DragAndDropSimulator initWithWebView:]):
659
660 2019-02-14  Chris Fleizach  <cfleizach@apple.com>
661
662         AX: ARIA Reflection was disabled in error
663         https://bugs.webkit.org/show_bug.cgi?id=194647
664         <rdar://problem/48068336>
665
666         Reviewed by Ryosuke Niwa.
667
668         Remove test override now that this feature should be enabled by default.
669
670         * WebKitTestRunner/TestController.cpp:
671         (WTR::TestController::resetPreferencesToConsistentValues):
672
673 2019-02-14  Commit Queue  <commit-queue@webkit.org>
674
675         Unreviewed, rolling out r241486.
676         https://bugs.webkit.org/show_bug.cgi?id=194655
677
678         causing API failures in builds (Requested by ShawnRoberts on
679         #webkit).
680
681         Reverted changeset:
682
683         "[Cocoa] Media elements will restart network buffering just
684         before suspending"
685         https://bugs.webkit.org/show_bug.cgi?id=193691
686         https://trac.webkit.org/changeset/241486
687
688 2019-02-14  Zalan Bujtas  <zalan@apple.com>
689
690         [LFC][BFC][MarginCollapse] Replaced boxes don't collapse through their margins
691         https://bugs.webkit.org/show_bug.cgi?id=194622
692
693         Reviewed by Antti Koivisto.
694
695         * LayoutReloaded/misc/LFC-passing-tests.txt:
696
697 2019-02-14  Zalan Bujtas  <zalan@apple.com>
698
699         [LFC] Shrink-to-fit-width should be constrained by min/max width
700         https://bugs.webkit.org/show_bug.cgi?id=194653
701
702         Reviewed by Antti Koivisto.
703
704         * LayoutReloaded/misc/LFC-passing-tests.txt:
705
706 2019-02-13  Ryosuke Niwa  <rniwa@webkit.org>
707
708         Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
709         https://bugs.webkit.org/show_bug.cgi?id=194641
710
711         Reviewed by Geoffrey Garen.
712
713         Added a call to WKBundleFrameGetParentFrame to an existing test for didRemoveFrameFromHierarchy
714         so that the test would fail without this fix.
715
716         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
717         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
718
719 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
720
721         [ews-app] Change log level for a log statement
722
723         Unreviewed minor fix.
724
725         * BuildSlaveSupport/ews-app/ews/models/patch.py:
726         (Patch.save_patch):
727
728 2019-02-13  Jer Noble  <jer.noble@apple.com>
729
730         [Cocoa] Media elements will restart network buffering just before suspending
731         https://bugs.webkit.org/show_bug.cgi?id=193691
732
733         Reviewed by Eric Carlson.
734
735         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
736         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
737         (TEST):
738
739 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
740
741         [ews-app] Fetch builder id to name mapping
742         https://bugs.webkit.org/show_bug.cgi?id=194355
743
744         Reviewed by Lucas Forschler.
745
746         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
747         (Buildbot.get_builder_id_to_name_mapping):
748         (Buildbot._get_display_name_from_builder_name):
749
750 2019-02-12  Jiewen Tan  <jiewen_tan@apple.com>
751
752         Further restricting webarchive loads
753         https://bugs.webkit.org/show_bug.cgi?id=194567
754         <rdar://problem/47610130>
755
756         Reviewed by Youenn Fablet.
757
758         Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
759         navigations on drop.
760
761         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
762         * TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.
763         (-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
764         (-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
765         (-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
766         (TestWebKitAPI::TEST):
767         * TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
768         * TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
769         * TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
770         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
771         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
772         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
773         (-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):
774
775 2019-02-13  John Wilander  <wilander@apple.com>
776
777         Store Ad Click Attribution requests in the network process
778         https://bugs.webkit.org/show_bug.cgi?id=194510
779         <rdar://problem/47650118>
780
781         Reviewed by Alex Christensen and Daniel Bates.
782
783         This patch adds two TestRunner functions:
784         - dumpAdClickAttribution()
785         - clearAdClickAttribution()
786
787         They call into the network process to dump and clear Ad Click
788         Attribution state, respectively.
789
790         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
791         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
792         (WTR::TestRunner::dumpAdClickAttribution):
793         (WTR::TestRunner::clearAdClickAttribution):
794         * WebKitTestRunner/InjectedBundle/TestRunner.h:
795         * WebKitTestRunner/TestController.cpp:
796         (WTR::TestController::resetStateToConsistentValues):
797         (WTR::AdClickAttributionStringResultCallbackContext::AdClickAttributionStringResultCallbackContext):
798         (WTR::adClickAttributionStringResultCallback):
799         (WTR::TestController::dumpAdClickAttribution):
800         (WTR::AdClickAttributionVoidCallbackContext::AdClickAttributionVoidCallbackContext):
801         (WTR::adClickAttributionVoidCallback):
802         (WTR::TestController::clearAdClickAttribution):
803         * WebKitTestRunner/TestController.h:
804         * WebKitTestRunner/TestInvocation.cpp:
805         (WTR::TestInvocation::dumpResults):
806         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
807         (WTR::TestInvocation::dumpAdClickAttribution):
808         * WebKitTestRunner/TestInvocation.h:
809
810 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
811
812         [ews-app] Generate status-bubble
813         https://bugs.webkit.org/show_bug.cgi?id=194572
814
815         Reviewed by Lucas Forschler.
816
817         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
818         (StatusBubble._build_bubble):
819         (StatusBubble._should_show_bubble_for):
820         (StatusBubble._build_bubbles_for_patch):
821
822 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
823
824         [ews-app] Add status bubble html template
825         https://bugs.webkit.org/show_bug.cgi?id=194571
826
827         Reviewed by Lucas Forschler.
828
829         * BuildSlaveSupport/ews-app/ews/templates: Added.
830         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Copied from QueueStatusServer/templates/statusbubble.html.
831
832 2019-02-12  Chris Dumez  <cdumez@apple.com>
833
834         Regression(PSON) MESSAGE_CHECK() hit under WebPageProxy::didFailProvisionalLoadForFrameShared()
835         https://bugs.webkit.org/show_bug.cgi?id=194568
836         <rdar://problem/47944490>
837
838         Reviewed by Ryosuke Niwa.
839
840         Add API test coverage.
841
842         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
843         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
844
845 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
846
847         webkitpy: Remove bug_dummy from parsed test expectations
848         https://bugs.webkit.org/show_bug.cgi?id=194562
849         <rdar://problem/47853999>
850
851         Reviewed by Lucas Forschler.
852
853         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
854         (TestExpectationParser):
855         (TestExpectationParser.expectation_for_skipped_test): Remove DUMMY_BUG_MODIFIER from
856         skipped tests.
857         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
858
859 2019-02-12  Aakash Jain  <aakash_jain@apple.com>
860
861         [ews-app] Add method to fetch patch
862         https://bugs.webkit.org/show_bug.cgi?id=194518
863
864         Reviewed by Lucas Forschler.
865
866         * BuildSlaveSupport/ews-app/ews/models/patch.py:
867         (Patch.get_patch):
868
869 2019-02-12  Zalan Bujtas  <zalan@apple.com>
870
871         [LFC] Expand tests coverage (60 new tests -> 860)
872
873         Unreviewed test gardening (run-singly, --child-processes=1).
874
875         * LayoutReloaded/misc/LFC-passing-tests.txt:
876
877 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
878
879         Allow pages to trigger programmatic paste from script on iOS
880         https://bugs.webkit.org/show_bug.cgi?id=194271
881         <rdar://problem/47808810>
882
883         Reviewed by Tim Horton.
884
885         Add support for interacting with the callout bar on iOS during layout tests. See below for more detail.
886
887         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
888         (WTR::UIScriptController::platformSetDidShowMenuCallback):
889         (WTR::UIScriptController::platformSetDidHideMenuCallback):
890         (WTR::UIScriptController::rectForMenuAction const):
891
892         Add new mechanisms to make it possible to interact with and query the state of the callout menu on iOS. This
893         includes determining the rect (in content view coordinates) of the menu's controls, and callbacks to register
894         for when the menu is shown or hidden.
895
896         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
897         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
898         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
899         (WTR::UIScriptController::setDidShowMenuCallback):
900         (WTR::UIScriptController::didShowMenuCallback const):
901         (WTR::UIScriptController::setDidHideMenuCallback):
902         (WTR::UIScriptController::didHideMenuCallback const):
903         (WTR::UIScriptController::platformSetDidShowMenuCallback):
904         (WTR::UIScriptController::platformSetDidHideMenuCallback):
905         (WTR::UIScriptController::rectForMenuAction const):
906         * TestRunnerShared/UIScriptContext/UIScriptController.h:
907         * WebKitTestRunner/TestController.cpp:
908         (WTR::TestController::resetPreferencesToConsistentValues):
909         (WTR::updateTestOptionsFromTestHeader):
910         * WebKitTestRunner/TestOptions.h:
911
912         Add a new test option to determine whether DOM paste is enabled. DOM paste is currently enabled everywhere by
913         default, but these new programmatic paste tests require it to be disabled in order for confirmation UI to show.
914
915         (WTR::TestOptions::hasSameInitializationOptions const):
916         * WebKitTestRunner/UIScriptControllerCocoa.mm:
917         (WTR::UIScriptController::calendarType const):
918         (WTR::UIScriptController::platformUndoManager const):
919         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
920         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
921         (-[TestRunnerWKWebView initWithFrame:configuration:]):
922         (-[TestRunnerWKWebView dealloc]):
923         (-[TestRunnerWKWebView _didShowMenu]):
924         (-[TestRunnerWKWebView _didHideMenu]):
925
926         Listen to when the callout bar is presented and dismissed, and invoke testing callbacks as needed.
927
928         * WebKitTestRunner/ios/TestControllerIOS.mm:
929         (WTR::handleMenuWillHideNotification):
930         (WTR::handleMenuDidHideNotification):
931         (WTR::TestController::platformInitialize):
932         (WTR::TestController::platformDestroy):
933         (WTR::TestController::platformResetStateToConsistentValues):
934
935         Additionally ensure that any callout menu presented by a previous layout test is dismissed before running the
936         next test by hiding the callout bar if necessary, and then waiting for the "DidHide" notification.
937
938         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
939         (WTR::forEachViewInHierarchy):
940         (WTR::findViewInHierarchyOfType):
941
942         Move `forEachViewInHierarchy` so that we can use it throughout the file, and then add some additional helper
943         functions that dig through a given view's hierarchy in search of a view of a given class.
944
945         (WTR::UIScriptController::selectionStartGrabberViewRect const):
946         (WTR::UIScriptController::selectionEndGrabberViewRect const):
947         (WTR::UIScriptController::selectionCaretViewRect const):
948         (WTR::UIScriptController::selectionRangeViewRects const):
949         (WTR::UIScriptController::platformSetDidShowMenuCallback):
950         (WTR::UIScriptController::platformSetDidHideMenuCallback):
951
952         Tweak these to use `platformContentView` instead of grabbing the content view from WKWebView directly.
953
954         (WTR::UIScriptController::rectForMenuAction const):
955
956         Add a new UIScriptController method to get the rect of the action in the contextual menu (on iOS, this is the
957         callout bar) whose label matches the given string.
958
959         (WTR::UIScriptController::platformContentView const):
960
961         Add a `platformContentView()` helper on UIScriptController so that we can stop grabbing the value for key
962         "_currentContentView" from various places in this file. Additionally, rewrite `platformUndoManager()` in terms
963         of this new helper, and move the code out from iOS/macOS-specific files into UIScriptControllerCocoa.
964
965         (WTR::UIScriptController::platformUndoManager const): Deleted.
966         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
967         (WTR::UIScriptController::platformContentView const):
968         (WTR::UIScriptController::platformUndoManager const): Deleted.
969
970 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
971
972         webkitpy: No option to only show unexpected failures in results.html for iPad
973         https://bugs.webkit.org/show_bug.cgi?id=194554
974         <rdar://problem/47922442>
975
976         Rubber-stamped by Aakash Jain.
977
978         Just because a TestExpecations file does not exist for a specific platform does not mean that
979         TestExpecations are not being used, given that platforms inherit test expectations.
980
981         * Scripts/webkitpy/port/base.py:
982         (Port.uses_test_expectations_file): Check all possible locations of a TestExpectations file.
983         * Scripts/webkitpy/port/base_unittest.py:
984         (PortTest.test_uses_test_expectations_file):
985
986 2019-02-12  Alex Christensen  <achristensen@webkit.org>
987
988         Remove setDefersLoading infrastructure from WebKit2
989         https://bugs.webkit.org/show_bug.cgi?id=194506
990
991         Reviewed by Brady Eidson.
992
993         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
994         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
995         (WTR::TestRunner::setDefersLoading): Deleted.
996         * WebKitTestRunner/InjectedBundle/TestRunner.h:
997
998 2019-02-12  Alex Christensen  <achristensen@webkit.org>
999
1000         WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage
1001         https://bugs.webkit.org/show_bug.cgi?id=194522
1002         <rdar://problem/47789393>
1003
1004         Reviewed by Chris Dumez.
1005
1006         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1007         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm: Added.
1008         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1009         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1010
1011 2019-02-12  Andy Estes  <aestes@apple.com>
1012
1013         [iOSMac] Enable Parental Controls Content Filtering
1014         https://bugs.webkit.org/show_bug.cgi?id=194521
1015         <rdar://39732376>
1016
1017         Reviewed by Tim Horton.
1018
1019         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1020
1021 2019-02-12  Zalan Bujtas  <zalan@apple.com>
1022
1023         [LFC][IFC] Add intrinsic width support for float boxes.
1024         https://bugs.webkit.org/show_bug.cgi?id=194528
1025
1026         Reviewed by Antti Koivisto.
1027
1028         Expand tests coverage (2 new tests -> 800).
1029         (This is the correct test ordering --runs-singly --child-processes=1)
1030
1031         * LayoutReloaded/misc/LFC-passing-tests.txt:
1032
1033 2019-02-12  Rob Buis  <rbuis@igalia.com>
1034
1035         Implement serializing in MIME type parser
1036         https://bugs.webkit.org/show_bug.cgi?id=193909
1037
1038         Reviewed by Darin Adler.
1039
1040         Add various tests involving upper case, non-ASCII, control/null characters,
1041         various HTTP whitespace, single quotes and an unpaired surrogate.
1042
1043         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
1044         (TestWebKitAPI::escapeNonASCIIPrintableCharacters):
1045         (TestWebKitAPI::serializeIfValid):
1046         (TestWebKitAPI::TEST):
1047
1048 2019-02-11  Myles C. Maxfield  <mmaxfield@apple.com>
1049
1050         [Cocoa] Ask platform for generic font family mappings
1051         https://bugs.webkit.org/show_bug.cgi?id=187723
1052         <rdar://problem/41892438>
1053
1054         Reviewed by Brent Fulgham.
1055
1056         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
1057
1058         * DumpRenderTree/mac/DumpRenderTree.mm:
1059         (allowedFontFamilySet):
1060         * WebKitTestRunner/mac/TestControllerMac.mm:
1061         (WTR::allowedFontFamilySet):
1062
1063 2019-02-11  Adrian Perez de Castro  <aperez@igalia.com>
1064
1065         [GTK][WPE] Add content extensions support in WKTR and unskip layout tests
1066         https://bugs.webkit.org/show_bug.cgi?id=193622
1067
1068         Reviewed by Michael Catanzaro.
1069
1070         This adds support for loading content extension rule sets from the JSON files which
1071         accompany the corresponding layout test, using the C API. The Cocoa specific parts
1072         of WKTR for this could be removed, but that is left for a follow-up patch with
1073         cleanups.
1074
1075         * Scripts/webkitperl/FeatureList.pm: Add an option to toggle CONTENT_EXTENSIONS.
1076         * WebKitTestRunner/TestController.cpp:
1077         (WTR::testPath): Subtract one from the length when constructing the result std::string to
1078         avoid having the null-terminator copied into the result.
1079         (WTR::TestController::configureViewForTest): Call configureContentExtensionForTest() as
1080         part of the preparations to run a test.
1081         (WTR::ContentExtensionStoreCallbackContext::ContentExtensionStoreCallbackContext): Added.
1082         (WTR::contentExtensionStoreCallback): Added.
1083         (WTR::contentExtensionJSONPath): Used to calculate the path to the JSON rule set to be
1084         used for content extensions test.
1085         (WTR::TestController::configureContentExtensionForTest): Added, handles enabling content
1086         extensions and compiling the JSON rule set for tests involving content extensions.
1087         (WTR::TestController::resetContentExtensions): Removes the content extension built for
1088         testing and disables content extensions.
1089         (WTR::TestController::resetPreferencesToConsistentValues): Add a call to
1090         resetContentExtensions().
1091         (WTR::TestController::userContentController): Added implementation for ports other than Cocoa.
1092         * WebKitTestRunner/TestController.h: Add declarations for resetContentExtensions(),
1093         configureContentExtensionForTest(), and userContentController().
1094
1095 2019-02-11  Daniel Bates  <dabates@apple.com>
1096
1097         [iOS] Mouse/Touch/Pointer events are missing modifier keys
1098         https://bugs.webkit.org/show_bug.cgi?id=191446
1099         <rdar://problem/45929460>
1100
1101         Reviewed by Tim Horton.
1102
1103         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
1104
1105         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1106         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1107         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1108         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1109         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1110         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1111         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1112         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1113         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1114         (WTR::arrayLength):
1115         (WTR::parseModifierArray):
1116         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
1117         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1118         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
1119         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1120
1121 2019-02-11  Commit Queue  <commit-queue@webkit.org>
1122
1123         Unreviewed, rolling out r241272 and r241276.
1124         https://bugs.webkit.org/show_bug.cgi?id=194514
1125
1126         Broke the Apple Internal build and the fix requires human
1127         intervention :( (Requested by dydz on #webkit).
1128
1129         Reverted changesets:
1130
1131         "[iOS] Mouse/Touch/Pointer events are missing modifier keys"
1132         https://bugs.webkit.org/show_bug.cgi?id=191446
1133         https://trac.webkit.org/changeset/241272
1134
1135         "Fix internal iOS build after r241272"
1136         https://bugs.webkit.org/show_bug.cgi?id=191446
1137         https://trac.webkit.org/changeset/241276
1138
1139 2019-02-11  Truitt Savell  <tsavell@apple.com>
1140
1141         Unreviewed, rolling out r241269.
1142
1143         Caused 5 layout tests crashes on Mac WK1
1144
1145         Reverted changeset:
1146
1147         "DumpRenderTree should report unknown options"
1148         https://bugs.webkit.org/show_bug.cgi?id=191303
1149         https://trac.webkit.org/changeset/241269
1150
1151 2019-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1152
1153         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
1154         https://bugs.webkit.org/show_bug.cgi?id=194313
1155
1156         Reviewed by Tim Horton.
1157
1158         Add a helper to determine whether the web view is presenting modal UI.
1159
1160         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1161         (WTR::UIScriptController::isPresentingModally const):
1162         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1163         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1164         (WTR::UIScriptController::isPresentingModally const):
1165         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1166         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1167         (WTR::UIScriptController::calendarType const): Deleted.
1168         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1169         (WTR::UIScriptController::isPresentingModally const):
1170         (WTR::UIScriptController::calendarType const):
1171         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1172         (WTR::UIScriptController::calendarType const):
1173
1174 2019-02-11  Joseph Pecoraro  <pecoraro@apple.com>
1175
1176         GCHeapInspector: Show the retained sizes in more places
1177         https://bugs.webkit.org/show_bug.cgi?id=194464
1178
1179         Reviewed by Simon Fraser.
1180
1181         * GCHeapInspector/gc-heap-inspector.html:
1182         * GCHeapInspector/script/interface.js:
1183         (HeapInspectorUtils.humanReadableSize):
1184         (HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
1185         (HeapInspectorUtils.spanForNode.span.span):
1186         (HeapSnapshotInspector.prototype.buildAllObjectsByType):
1187         (HeapSnapshotInspector.prototype.buildRoots):
1188
1189 2019-02-11  Daniel Bates  <dabates@apple.com>
1190
1191         [iOS] Mouse/Touch/Pointer events are missing modifier keys
1192         https://bugs.webkit.org/show_bug.cgi?id=191446
1193         <rdar://problem/45929460>
1194
1195         Reviewed by Tim Horton.
1196
1197         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
1198
1199         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1200         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1201         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1202         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1203         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1204         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1205         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1206         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1207         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1208         (WTR::arrayLength):
1209         (WTR::parseModifierArray):
1210         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
1211         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1212         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
1213         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1214
1215 2019-02-11  Darshan Kadu  <dkadu@igalia.com>
1216
1217         DumpRenderTree should report unknown options
1218         https://bugs.webkit.org/show_bug.cgi?id=191303
1219
1220         Reviewed by Frédéric Wang.
1221
1222         Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
1223         to report unknown options.
1224         Added and assigned test options which are currently used in tests.
1225
1226         * DumpRenderTree/TestOptions.cpp:
1227         (TestOptions::TestOptions):
1228
1229 2019-02-11  Truitt Savell  <tsavell@apple.com>
1230
1231         Unreviewed, rolling out r241229.
1232
1233         Revision broke internal builds for watchOS.
1234
1235         Reverted changeset:
1236
1237         "[Cocoa] Ask platform for generic font family mappings"
1238         https://bugs.webkit.org/show_bug.cgi?id=187723
1239         https://trac.webkit.org/changeset/241229
1240
1241 2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
1242
1243         [WinCairo][MiniBrowser] Basic authentication always fails.
1244         https://bugs.webkit.org/show_bug.cgi?id=194496
1245
1246         Reviewed by Don Olmstead.
1247
1248         * MiniBrowser/win/DialogHelper.h:
1249         (Dialog::getText):
1250
1251 2019-02-11  Philippe Normand  <pnormand@igalia.com>
1252
1253         [GStreamer] GstMappedBuffer testsuite build fails
1254         https://bugs.webkit.org/show_bug.cgi?id=194495
1255
1256         Reviewed by Carlos Garcia Campos.
1257
1258         Fix the build by explicitely adding the gstreamer1.0-audio include
1259         directories to the include path.
1260
1261         * TestWebKitAPI/PlatformGTK.cmake:
1262         * TestWebKitAPI/PlatformWPE.cmake:
1263
1264 2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
1265
1266         [GTK][WPE] Add enable-javascript-markup setting
1267         https://bugs.webkit.org/show_bug.cgi?id=193439
1268
1269         Reviewed by Michael Catanzaro.
1270
1271         Add test cases to check the new setting.
1272
1273         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1274         (testWebKitSettings):
1275         (testWebKitSettingsJavaScriptMarkup):
1276         (beforeAll):
1277
1278 2019-02-10  Darin Adler  <darin@apple.com>
1279
1280         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
1281         https://bugs.webkit.org/show_bug.cgi?id=194485
1282
1283         Reviewed by Daniel Bates.
1284
1285         * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
1286
1287 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
1288
1289         Add more tests for clampTo<>()
1290         https://bugs.webkit.org/show_bug.cgi?id=194462
1291
1292         Reviewed by Geoffrey Garen.
1293
1294         Darin suggested to test the very last floating point number
1295         at the boundaries when truncating to integer.
1296         I added test for max/min and max-1/min-1.
1297
1298         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1299         (TestWebKitAPI::TEST):
1300
1301 2019-02-09  Darin Adler  <darin@apple.com>
1302
1303         Eliminate unnecessary String temporaries by using StringConcatenateNumbers
1304         https://bugs.webkit.org/show_bug.cgi?id=194021
1305
1306         Reviewed by Geoffrey Garen.
1307
1308         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
1309         (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
1310         to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
1311
1312 2019-02-09  Zalan Bujtas  <zalan@apple.com>
1313
1314         [LFC][IFC] Add intrinsic width support for basic inline containers
1315         https://bugs.webkit.org/show_bug.cgi?id=194473
1316
1317         Reviewed by Antti Koivisto.
1318
1319         Expand tests coverage (11 new tests -> 798)
1320
1321         * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
1322
1323 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
1324
1325         Fix MiniBrowser's entitlements
1326         https://bugs.webkit.org/show_bug.cgi?id=192431
1327
1328         Reviewed by Joseph Pecoraro.
1329
1330         MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
1331         files, making it impossible to load any extension.
1332
1333         * MiniBrowser/MiniBrowser.entitlements:
1334
1335 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
1336
1337         [Cocoa] Ask platform for generic font family mappings
1338         https://bugs.webkit.org/show_bug.cgi?id=187723
1339         <rdar://problem/41892438>
1340
1341         Reviewed by Brent Fulgham.
1342
1343         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
1344
1345         * DumpRenderTree/mac/DumpRenderTree.mm:
1346         (allowedFontFamilySet):
1347         * WebKitTestRunner/mac/TestControllerMac.mm:
1348         (WTR::allowedFontFamilySet):
1349
1350 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
1351
1352         [GTK] Implement back/forward touchpad gesture
1353         https://bugs.webkit.org/show_bug.cgi?id=193919
1354
1355         Reviewed by Michael Catanzaro.
1356
1357         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1358         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
1359
1360 2019-02-08  Alex Christensen  <achristensen@webkit.org>
1361
1362         Add SPI to use networking daemon instead of XPC service
1363         https://bugs.webkit.org/show_bug.cgi?id=194427
1364
1365         Reviewed by Geoffrey Garen
1366
1367         * MiniBrowser/MiniBrowser.entitlements:
1368
1369 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
1370
1371         [ews-build] Ensure that every builder in config.json has short name
1372         https://bugs.webkit.org/show_bug.cgi?id=194461
1373
1374         Reviewed by Lucas Forschler.
1375
1376         * BuildSlaveSupport/ews-build/loadConfig.py:
1377         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
1378
1379 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
1380
1381         [ews-build] Add short name to config.json
1382         https://bugs.webkit.org/show_bug.cgi?id=194456
1383
1384         Reviewed by Lucas Forschler.
1385
1386         * BuildSlaveSupport/ews-build/config.json: Added short name.
1387         * BuildSlaveSupport/ews-build/loadConfig.py:
1388         (loadBuilderConfig): Set the short name as the builder description.
1389
1390 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
1391
1392         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
1393         https://bugs.webkit.org/show_bug.cgi?id=194418
1394
1395         Reviewed by Lucas Forschler.
1396
1397         Do not include errors trying when finding crashlogs at the end of
1398         a run-webkit-tests run since we don't process those errors.
1399
1400         * Scripts/webkitpy/port/darwin.py:
1401         (DarwinPort._look_for_all_crash_logs_in_log_dir):
1402         * Scripts/webkitpy/port/ios_device.py:
1403         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
1404         * Scripts/webkitpy/port/watch_device.py:
1405         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
1406
1407 2019-02-08  Beth Dakin  <bdakin@apple.com>
1408
1409         Add afterScreenUpdates to WKSnapshotConfiguration
1410         https://bugs.webkit.org/show_bug.cgi?id=194362
1411         -and corresponding-
1412         <rdar://problem/40655528> Please add an "after screen updates" property to 
1413         WKSnapshotConfiguration (to solve blank snapshots)
1414
1415         Reviewed by Tim Horton.
1416
1417         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
1418         (TEST):
1419
1420 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
1421
1422         clampTo(): do not convert the input to double when dealing with integers
1423         https://bugs.webkit.org/show_bug.cgi?id=194263
1424         <rdar://problem/47692312>
1425
1426         Reviewed by Darin Adler.
1427
1428         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1429         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
1430         (TestWebKitAPI::testClampFloatingPointToInteger):
1431         (TestWebKitAPI::testClampSameSignIntegers):
1432         (TestWebKitAPI::testClampUnsignedToSigned):
1433         (TestWebKitAPI::testClampSignedToUnsigned):
1434
1435 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
1436
1437         webkitpy: Respect --dedicated-simulators flag
1438         https://bugs.webkit.org/show_bug.cgi?id=194416
1439         <rdar://problem/47894722>
1440
1441         Reviewed by Lucas Forschler.
1442
1443         * Scripts/webkitpy/port/device_port.py:
1444         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
1445         available devices can be safely ignored.
1446
1447 2019-02-07  Keith Rollin  <krollin@apple.com>
1448
1449         Remove extra copy of 100x100-red.tga
1450         https://bugs.webkit.org/show_bug.cgi?id=194371
1451         <rdar://problem/47873465>
1452
1453         Reviewed by Said Abou-Hallawa.
1454
1455         In order to help it pass its tests, Bug 194190 added a second copy of
1456         the file 100x100-red.tga. However, it turns out that this additional
1457         file wasn't actually needed, and that that sole previous copy was
1458         sufficient. At the same time, this second copy -- which was copied to
1459         the same location in the build output as the first copy -- now caused
1460         XCBuild to complain because there were two production rules for the
1461         same output file. Address this by removing the newly-added extra copy.
1462
1463         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1464         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
1465
1466 2019-02-07  Alex Christensen  <achristensen@webkit.org>
1467
1468         Deprecate WKBundlePageSetDefersLoading
1469         https://bugs.webkit.org/show_bug.cgi?id=191394
1470
1471         Reviewed by Dean Jackson.
1472
1473         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1474         (WTR::TestRunner::setDefersLoading):
1475
1476 2019-02-07  Zalan Bujtas  <zalan@apple.com>
1477
1478         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
1479         https://bugs.webkit.org/show_bug.cgi?id=194391
1480
1481         Reviewed by Antti Koivisto.
1482
1483         * LayoutReloaded/misc/LFC-passing-tests.txt:
1484
1485 2019-02-06  Keith Rollin  <krollin@apple.com>
1486
1487         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
1488         https://bugs.webkit.org/show_bug.cgi?id=193975
1489         <rdar://problem/47643306>
1490
1491         Reviewed by Tim Horton.
1492
1493         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
1494         the Info.plist file into the bundle. This step is not necessary as the
1495         implicit "bundle up all the build products into a framework" build
1496         phase does this already. Having the Copy Bundle Resources phase do
1497         this causes a conflict under XCBuild, which objects to two build
1498         phases producing the same file (Info.plist). Address this by removing
1499         Info.plist from the Copy Bundle Resources phase.
1500
1501         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
1502
1503 2019-02-06  Keith Rollin  <krollin@apple.com>
1504
1505         Really enable the automatic checking and regenerations of .xcfilelists during builds
1506         https://bugs.webkit.org/show_bug.cgi?id=194357
1507         <rdar://problem/47861231>
1508
1509         Reviewed by Chris Dumez.
1510
1511         Bug 194124 was supposed to enable the automatic checking and
1512         regenerating of .xcfilelist files during the build. While related
1513         changes were included in that patch, the change to actually enable the
1514         operation somehow was omitted. This patch actually enables the
1515         operation. The check-xcfilelist.sh scripts now check
1516         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
1517         from the checking.
1518
1519         * DumpRenderTree/Scripts/check-xcfilelists.sh:
1520         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
1521
1522 2019-02-06  David Kilzer  <ddkilzer@apple.com>
1523
1524         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
1525         <https://webkit.org/b/194286>
1526         <rdar://problem/47815558>
1527
1528         Reviewed by Alexey Proskuryakov.
1529
1530         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1531         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
1532         WKRetainPtr<> to avoid leaking the WKDataRef.
1533
1534 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
1535
1536         Unreviewed, fix a typo
1537
1538         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
1539
1540 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
1541
1542         [GTK][WPE] force libpsl build to use ICU in jhbuild
1543         https://bugs.webkit.org/show_bug.cgi?id=194288
1544
1545         Reviewed by Carlos Garcia Campos.
1546
1547         * gtk/jhbuild.modules:
1548         Require ICU for libpsl build in jhbuild, like done in WPE.
1549
1550 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
1551
1552         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
1553         https://bugs.webkit.org/show_bug.cgi?id=194209
1554
1555         Reviewed by Carlos Garcia Campos.
1556
1557         Enhance TestCookieManager to ensure this doesn't happen again.
1558
1559         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
1560         (testCookieManagerPersistentStorage):
1561         (beforeAll):
1562
1563 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1564
1565         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
1566         https://bugs.webkit.org/show_bug.cgi?id=194324
1567
1568         Reviewed by Andy Estes.
1569
1570         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
1571         part of the name is already implicit, since this is in testing code in TestOptions.
1572
1573         * WebKitTestRunner/TestController.cpp:
1574         (WTR::TestController::generateContextConfiguration const):
1575         (WTR::updateTestOptionsFromTestHeader):
1576         * WebKitTestRunner/TestOptions.h:
1577         (WTR::TestOptions::hasSameInitializationOptions const):
1578
1579 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1580
1581         [ews-build] Allow * as platform for builders and workers
1582         https://bugs.webkit.org/show_bug.cgi?id=188533
1583
1584         Reviewed by Lucas Forschler.
1585
1586         * BuildSlaveSupport/ews-build/loadConfig.py:
1587         (checkWorkersAndBuildersForConsistency):
1588
1589 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1590
1591         [ews-build] Add few bots to config.json
1592         https://bugs.webkit.org/show_bug.cgi?id=194304
1593
1594         Reviewed by Lucas Forschler.
1595
1596         * BuildSlaveSupport/ews-build/config.json:
1597
1598 2019-02-05  Keith Rollin  <krollin@apple.com>
1599
1600         Enable the automatic checking and regenerations of .xcfilelists during builds
1601         https://bugs.webkit.org/show_bug.cgi?id=194124
1602         <rdar://problem/47721277>
1603
1604         Reviewed by Tim Horton.
1605
1606         Bug 193790 add a facility for checking -- during build time -- that
1607         any needed .xcfilelist files are up-to-date and for updating them if
1608         they are not. This facility was initially opt-in by setting
1609         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
1610         the process seemed robust. Its now time to enable this facility and
1611         make it opt-out. If there is a need to disable this facility, set and
1612         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
1613         running `make` or `build-webkit`, or before running Xcode from the
1614         command line.
1615
1616         Additionally, remove the step that generates a list of source files
1617         going into the UnifiedSources build step. It's only necessarily to
1618         specify Sources.txt and SourcesCocoa.txt as inputs.
1619
1620         * Scripts/generate-xcfilelists:
1621
1622 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
1623
1624         [GTK][WPE] force libpsl build to use ICU in jhbuild
1625         https://bugs.webkit.org/show_bug.cgi?id=194288
1626
1627         Reviewed by Philippe Normand.
1628
1629         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
1630         This can cause build failures if libidn is detected but libunistring is not available.
1631
1632         Make sure that ICU is used for runtime and builtin PSL data.
1633
1634         * gtk/jhbuild.modules:
1635         * wpe/jhbuild.modules:
1636
1637 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1638
1639         [ews-app] Modified timestamp should be updated on updating data
1640         https://bugs.webkit.org/show_bug.cgi?id=194295
1641
1642         Reviewed by Lucas Forschler.
1643
1644         * BuildSlaveSupport/ews-app/ews/models/build.py:
1645         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1646         * BuildSlaveSupport/ews-app/ews/models/step.py:
1647
1648 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
1649
1650         Unreviewed, rolling out r240742.
1651
1652         Causes crashes on iOS simulator.
1653
1654         Reverted changeset:
1655
1656         "[iOS] Keyups for non-modifier keys identified as "Dead" when
1657         not focused in a content-editable element"
1658         https://bugs.webkit.org/show_bug.cgi?id=192824
1659         https://trac.webkit.org/changeset/240742
1660
1661 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
1662
1663         run-webkit-tests emits message "...running None" when running tests
1664         https://bugs.webkit.org/show_bug.cgi?id=194133
1665         <rdar://problem/47724738>
1666
1667         Reviewed by Lucas Forschler.
1668
1669         * Scripts/webkitpy/xcode/device_type.py:
1670         (DeviceType.__str__): Use both version mapping tables and use just the variant
1671         name if no version name is available.
1672         * Scripts/webkitpy/xcode/device_type_unittest.py:
1673         (DeviceTypeTest):
1674         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
1675         an associated named.
1676
1677 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
1678
1679         [WPE] require python3-setuptools for meson build in jhbuild
1680         https://bugs.webkit.org/show_bug.cgi?id=194287
1681
1682         Reviewed by Philippe Normand.
1683
1684         python3-setuptools is needed to build meson in jhbuild.
1685         It is already required by the GTK port.
1686
1687         * wpe/install-dependencies:
1688
1689 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1690
1691         [ews-app] Add method to save BuilderMapping to database
1692         https://bugs.webkit.org/show_bug.cgi?id=194264
1693
1694         Reviewed by Lucas Forschler.
1695
1696         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1697         (BuilderMapping.__str__):
1698         (BuilderMapping):
1699         (BuilderMapping.save_mapping):
1700         (BuilderMapping.update_mapping):
1701         (BuilderMapping.get_existing_mapping):
1702         (BuilderMapping.is_valid_mapping):
1703
1704 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1705
1706         [ews-app] Add timestamp fields for BuilderMappings
1707         https://bugs.webkit.org/show_bug.cgi?id=194266
1708
1709         Reviewed by Lucas Forschler.
1710
1711         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1712         (BuilderMapping):
1713
1714 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
1715
1716         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
1717         https://bugs.webkit.org/show_bug.cgi?id=174816
1718
1719         Reviewed by Michael Catanzaro.
1720
1721         Add tests for webkit_uri_for_display().
1722
1723         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
1724         (testURIForDisplayUnaffected):
1725         (testURIForDisplayAffected):
1726         (beforeAll):
1727         (afterAll):
1728         * TestWebKitAPI/glib/CMakeLists.txt:
1729
1730 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
1731
1732         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
1733         https://bugs.webkit.org/show_bug.cgi?id=194158
1734         <rdar://problem/47737268>
1735
1736         Rubber-stamped by Aakash Jain.
1737
1738         * Scripts/webkitpy/port/device_port.py:
1739         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
1740
1741 2019-02-04  Said Abou-Hallawa  <said@apple.com>
1742
1743         [CG] Enable setAdditionalSupportedImageTypes for WK1
1744         https://bugs.webkit.org/show_bug.cgi?id=194190
1745
1746         Reviewed by Tim Horton.
1747
1748         Add a test similar to the one under WebKit Cocoa but make it create a
1749         WebView instead of a WKWebView.
1750
1751         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1752         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
1753         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
1754         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
1755         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
1756         (TestWebKitAPI::runTest):
1757         (TestWebKitAPI::TEST):
1758
1759 2019-02-04  Zalan Bujtas  <zalan@apple.com>
1760
1761         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
1762         https://bugs.webkit.org/show_bug.cgi?id=194168
1763
1764         Reviewed by Simon Fraser.
1765
1766         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
1767
1768         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1769         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
1770         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
1771         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
1772         (TEST):
1773         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
1774         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
1775
1776 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
1777
1778         REGRESSION (r237269): webkit-patch what-broke is broken 
1779         https://bugs.webkit.org/show_bug.cgi?id=193025
1780
1781         Reviewed by Aakash Jain.
1782
1783         * Scripts/webkitpy/common/host.py:
1784         (Host.buildbot):
1785         (Host.bugzilla): Renamed to 'buildbot'.
1786
1787 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1788
1789         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
1790         https://bugs.webkit.org/show_bug.cgi?id=194207
1791
1792         Reviewed by Tim Horton.
1793
1794         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
1795         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
1796         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
1797         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
1798         start and delete forwards to remove the original attachment.
1799
1800         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1801         (TestWebKitAPI::TEST):
1802
1803 2019-02-04  Youenn Fablet  <youenn@apple.com>
1804
1805         Capture state should be managed consistently when doing process swapping
1806         https://bugs.webkit.org/show_bug.cgi?id=194122
1807         <rdar://problem/47609293>
1808
1809         Reviewed by Eric Carlson.
1810
1811         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1812         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
1813         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
1814         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
1815         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1816         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1817         (WTR::TestRunner::isDoingMediaCapture const):
1818         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1819         * WebKitTestRunner/TestController.cpp:
1820         (WTR::TestController::isDoingMediaCapture const):
1821         * WebKitTestRunner/TestController.h:
1822         * WebKitTestRunner/TestInvocation.cpp:
1823         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1824         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1825         (WTR::TestController::isDoingMediaCapture const):
1826
1827 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
1828
1829         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
1830         https://bugs.webkit.org/show_bug.cgi?id=194142
1831
1832         Reviewed by Ross Kirsling.
1833
1834         There three 'separator' variables in TestController.cpp. Renamed
1835         it 'pathSeparator', and unified them.
1836
1837         * WebKitTestRunner/TestController.cpp:
1838         (WTR::TestController::generateContextConfiguration const):
1839         (WTR::createTestURL):
1840         (WTR::TestController::platformAdjustContext):
1841
1842 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
1843
1844         Make setNeedsLayout on the root more explicitly about triggering its side-effects
1845         https://bugs.webkit.org/show_bug.cgi?id=194198
1846
1847         Reviewed by Antti Koivisto.
1848
1849         No need to set the banner heights on navigation now, since Page stores them.
1850
1851         * MiniBrowser/mac/WK2BrowserWindowController.m:
1852         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
1853
1854 2019-02-03  John Wilander  <wilander@apple.com>
1855
1856         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
1857         https://bugs.webkit.org/show_bug.cgi?id=194104
1858         <rdar://problem/47649991>
1859
1860         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
1861
1862         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1863         (TestWebKitAPI::TEST):
1864             Changed numeric types from unsigned short to uint32_t.
1865
1866 2019-02-02  David Kilzer  <ddkilzer@apple.com>
1867
1868         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
1869         <https://webkit.org/b/194178>
1870         <rdar://problem/47753473>
1871
1872         Reviewed by Alexey Proskuryakov.
1873
1874         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1875         (WTR::uninstallFakeHelvetica): Pass nullptr into
1876         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
1877
1878 2019-02-02  Zalan Bujtas  <zalan@apple.com>
1879
1880         [LFC] Initialize ICB's style with fixed width/height.
1881         https://bugs.webkit.org/show_bug.cgi?id=194188
1882
1883         Reviewed by Antti Koivisto.
1884
1885         * LayoutReloaded/misc/LFC-passing-tests.txt:
1886
1887 2019-02-02  Zalan Bujtas  <zalan@apple.com>
1888
1889         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
1890         https://bugs.webkit.org/show_bug.cgi?id=194185
1891
1892         Reviewed by Antti Koivisto.
1893
1894         * LayoutReloaded/misc/LFC-passing-tests.txt:
1895
1896 2018-12-16  Darin Adler  <darin@apple.com>
1897
1898         Convert additional String::format clients to alternative approaches
1899         https://bugs.webkit.org/show_bug.cgi?id=192746
1900
1901         Reviewed by Alexey Proskuryakov.
1902
1903         * WebKitTestRunner/TestController.cpp:
1904         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
1905         as an intermediate in code that ultimately constructs a WTF::String.
1906         (WTR::userMediaOriginHash): Use makeString.
1907         (WTR::TestController::didNavigateWithNavigationData): More of the same.
1908         (WTR::TestController::didPerformClientRedirect): Ditto.
1909         (WTR::TestController::didPerformServerRedirect): Ditto.
1910         (WTR::TestController::didUpdateHistoryTitle): Ditto.
1911
1912 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
1913
1914         [ews-build] Add unit test to verify builder keys
1915         https://bugs.webkit.org/show_bug.cgi?id=194152
1916
1917         Reviewed by Lucas Forschler.
1918
1919         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
1920         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
1921
1922 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1923
1924         [LFC] Expand tests coverage (12 new tests -> 787)
1925
1926         Unreviewed test gardening.
1927
1928         * LayoutReloaded/misc/LFC-passing-tests.txt:
1929
1930 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1931
1932         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
1933         https://bugs.webkit.org/show_bug.cgi?id=194163
1934
1935         Reviewed by Simon Fraser.
1936
1937         775
1938
1939         * LayoutReloaded/misc/LFC-passing-tests.txt:
1940
1941 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1942
1943         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
1944         https://bugs.webkit.org/show_bug.cgi?id=194140
1945         <rdar://problem/47728098>
1946
1947         Reviewed by Tim Horton.
1948
1949         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1950         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1951         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
1952
1953         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
1954         test to induce an IPC deadlock when presenting a modal alert during touch start.
1955
1956         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1957         * WebKitTestRunner/TestController.cpp:
1958         (WTR::runJavaScriptAlert):
1959
1960         Add a client callback function for running JavaScript alerts.
1961
1962         (WTR::TestController::createOtherPage):
1963         (WTR::TestController::generateContextConfiguration const):
1964
1965         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
1966         the fix in this patch.
1967
1968         (WTR::TestController::createWebViewWithOptions):
1969
1970         Plumb TestOptions to generateContextConfiguration.
1971
1972         (WTR::TestController::resetPreferencesToConsistentValues):
1973         (WTR::TestController::resetStateToConsistentValues):
1974         (WTR::updateTestOptionsFromTestHeader):
1975         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
1976         (WTR::TestController::handleJavaScriptAlert):
1977         * WebKitTestRunner/TestController.h:
1978         * WebKitTestRunner/TestInvocation.cpp:
1979         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1980         * WebKitTestRunner/TestOptions.h:
1981         (WTR::TestOptions::hasSameInitializationOptions const):
1982
1983 2019-02-01  Chris Dumez  <cdumez@apple.com>
1984
1985         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
1986         https://bugs.webkit.org/show_bug.cgi?id=193740
1987         <rdar://problem/47527267>
1988
1989         Reviewed by Alex Christensen.
1990
1991         Add API test coverage.
1992
1993         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1994
1995 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
1996
1997         [ews-app] Add display name field to BuilderMapping model
1998         https://bugs.webkit.org/show_bug.cgi?id=194153
1999
2000         Reviewed by Lucas Forschler.
2001
2002         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2003         (BuilderMapping):
2004
2005 2019-02-01  Youenn Fablet  <youenn@apple.com>
2006
2007         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
2008         https://bugs.webkit.org/show_bug.cgi?id=194155
2009
2010         Reviewed by Eric Carlson.
2011
2012         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
2013         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
2014         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
2015
2016 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2017
2018         [LFC] Adjust replaced element's intrinsic ratio
2019         https://bugs.webkit.org/show_bug.cgi?id=194154
2020
2021         Reviewed by Antti Koivisto.
2022
2023         761
2024
2025         * LayoutReloaded/misc/LFC-passing-tests.txt:
2026
2027 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2028
2029         [WPE] Show test results in minibrowser
2030         https://bugs.webkit.org/show_bug.cgi?id=194150
2031
2032         Reviewed by Žan Doberšek.
2033
2034         * Scripts/webkitpy/port/wpe.py:
2035         (WPEPort.show_results_html_file):
2036
2037 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2038
2039         [WPE] MiniBrowser: add ky bindings for back/forward navigation
2040         https://bugs.webkit.org/show_bug.cgi?id=194151
2041
2042         Reviewed by Žan Doberšek.
2043
2044         ALT + <- go back
2045         ALT + -> go forward
2046
2047         * MiniBrowser/wpe/main.cpp:
2048         (main):
2049
2050 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2051
2052         [LFC] Set intrinsic size on Layout::Replaced
2053         https://bugs.webkit.org/show_bug.cgi?id=194139
2054
2055         Reviewed by Antti Koivisto.
2056
2057         744
2058
2059         * LayoutReloaded/misc/LFC-passing-tests.txt:
2060
2061 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2062
2063         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
2064         https://bugs.webkit.org/show_bug.cgi?id=194146
2065
2066         Reviewed by Xabier Rodriguez-Calvar.
2067
2068         It allows to open relative paths.
2069
2070         * MiniBrowser/wpe/main.cpp:
2071         (main):
2072
2073 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
2074
2075         Update flakiness dashboard configuration after recent queue changes
2076         https://bugs.webkit.org/show_bug.cgi?id=194127
2077
2078         Rubber-stamped by Aakash Jain.
2079
2080         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
2081
2082         * TestResultServer/static-dashboards/builders.jsonp:
2083
2084 2019-01-31  Youenn Fablet  <youenn@apple.com>
2085
2086         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
2087         https://bugs.webkit.org/show_bug.cgi?id=194106
2088         <rdar://problem/47676333>
2089
2090         Reviewed by Ryosuke Niwa.
2091
2092         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2093         (TestWebKitAPI::didFinishNavigation):
2094         (TestWebKitAPI::TEST):
2095         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
2096
2097 2019-01-31  Chris Dumez  <cdumez@apple.com>
2098
2099         Page zoom level is lost after a process swap or a crash
2100         https://bugs.webkit.org/show_bug.cgi?id=194105
2101         <rdar://problem/47610781>
2102
2103         Reviewed by Alex Christensen.
2104
2105         Add API test coverage.
2106
2107         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2108         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
2109
2110 2019-01-31  Alex Christensen  <achristensen@webkit.org>
2111
2112         Revert r238819 which is unneeded and caused a performance regression.
2113         https://bugs.webkit.org/show_bug.cgi?id=192272
2114         <rdar://problem/46664625>
2115
2116         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
2117         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
2118         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
2119
2120 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
2121
2122         Formalize WebKitAdditions mechanism of LoadOptimizer
2123         https://bugs.webkit.org/show_bug.cgi?id=193886
2124         <rdar://problem/47696809>
2125
2126         Reviewed by Brent Fulgham.
2127
2128         * MiniBrowser/MiniBrowser.entitlements:
2129         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
2130
2131 2019-01-31  Zalan Bujtas  <zalan@apple.com>
2132
2133         [LFC] Margin before/after/start/end initial value is 0 and not auto.
2134         https://bugs.webkit.org/show_bug.cgi?id=194090
2135
2136         Reviewed by Antti Koivisto.
2137
2138         * LayoutReloaded/misc/LFC-passing-tests.txt:
2139
2140 2019-01-31  Zalan Bujtas  <zalan@apple.com>
2141
2142         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
2143         https://bugs.webkit.org/show_bug.cgi?id=194074
2144
2145         Reviewed by Antti Koivisto.
2146
2147         * LayoutReloaded/misc/LFC-passing-tests.txt:
2148
2149 2019-01-31  Zalan Bujtas  <zalan@apple.com>
2150
2151         [LFC][BFC] Add support for block level replaced box.
2152         https://bugs.webkit.org/show_bug.cgi?id=194071
2153
2154         Reviewed by Antti Koivisto.
2155
2156         * LayoutReloaded/misc/LFC-passing-tests.txt:
2157
2158 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
2159
2160         Fix WebKitTestRunner's testPath with Windows full paths
2161         https://bugs.webkit.org/show_bug.cgi?id=194012
2162
2163         Reviewed by Alex Christensen.
2164
2165         updateTestOptionsFromTestHeader failed to open test files because
2166         testPath returned wrong file paths. It returned a path "/C:/..."
2167         if a URL "file:///C:/..." was given.
2168
2169         * WebKitTestRunner/TestController.cpp:
2170         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
2171
2172 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
2173
2174         [WPE] Bump font related dependencies to match the GTK+ port
2175         https://bugs.webkit.org/show_bug.cgi?id=194017
2176
2177         Reviewed by Žan Doberšek.
2178
2179         * wpe/jhbuild.modules:
2180         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
2181         * wpe/patches/icudata-stdlibs.patch: Added.
2182
2183 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
2184
2185         Enable swipe tests on iOS
2186         https://bugs.webkit.org/show_bug.cgi?id=194076
2187
2188         Reviewed by Geoffrey Garen.
2189
2190         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
2191         it causes a debug assertion failure in runUIScript.
2192
2193         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2194         (WTR::UIScriptController::beginBackSwipe):
2195         (WTR::UIScriptController::completeBackSwipe):
2196
2197 2019-01-30  Keith Rollin  <krollin@apple.com>
2198
2199         Use correct printf format specifier
2200         https://bugs.webkit.org/show_bug.cgi?id=194062
2201         <rdar://problem/47686167>
2202
2203         Reviewed by Alexey Proskuryakov.
2204
2205         LayoutTestSpellChecker.mm is trying to format a variable of type
2206         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
2207         actually an unsigned long long. Fix this by formatting with %llu.
2208
2209         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
2210         (-[LayoutTestTextCheckingResult description]):
2211
2212 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
2213
2214         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
2215         https://bugs.webkit.org/show_bug.cgi?id=193979
2216
2217         Reviewed by Wenson Hsieh.
2218
2219         Fix the test for iOS. Make the test work with iOS UA string.
2220
2221         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2222
2223 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
2224
2225         Replace High Sierra LLINT CLoop bot due to hardware failure
2226         https://bugs.webkit.org/show_bug.cgi?id=194066
2227
2228         Reviewed by Aakash Jain.
2229
2230         * BuildSlaveSupport/build.webkit.org-config/config.json:
2231
2232 2019-01-30  Keith Rollin  <krollin@apple.com>
2233
2234         [NSDragItem init] is unavailable
2235         https://bugs.webkit.org/show_bug.cgi?id=194059
2236         <rdar://problem/47685715>
2237
2238         Reviewed by Wenson Hsieh.
2239
2240         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
2241         DumpRenderTree and TestWebKitAPI, which both try to create an
2242         NSDragItem in a manner that invokes this method. Address this by using
2243         -initWithPasteboardWriter instead.
2244
2245         Note that the parameter passed to initWithPasteboardWriter is likely
2246         incorrect. In both cases, the object passed does not conform to
2247         NSPasteboardWriting. However, with this fix, we're no worse off than
2248         before, and can now perform builds with newer compilers and SDKs until
2249         a real fix can be crafted. That work is tracked in
2250         https://bugs.webkit.org/show_bug.cgi?id=194060
2251
2252         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
2253         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
2254         * TestWebKitAPI/mac/TestDraggingInfo.mm:
2255         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
2256
2257 2019-01-30  Daniel Bates  <dabates@apple.com>
2258
2259         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
2260         https://bugs.webkit.org/show_bug.cgi?id=192824
2261         <rdar://problem/47100332>
2262
2263         Reviewed by Wenson Hsieh.
2264
2265         Fix a bug where the wrong usage code was used for F13 thru F24.
2266
2267         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2268         (keyCodeForDOMFunctionKey):
2269
2270 2019-01-30  Chris Dumez  <cdumez@apple.com>
2271
2272         Regression(PSON) Load hang can occur on history navigation
2273         https://bugs.webkit.org/show_bug.cgi?id=194030
2274         <rdar://problem/47656939>
2275
2276         Reviewed by Antti Koivisto.
2277
2278         Add API test coverage.
2279
2280         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2281
2282 2019-01-30  Zalan Bujtas  <zalan@apple.com>
2283
2284         [LFC] Expand tests coverage.
2285
2286         Unreviewed test gardening.
2287
2288         * LayoutReloaded/misc/LFC-passing-tests.txt:
2289
2290 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
2291
2292         [Flatpak] Add openjpeg support
2293         https://bugs.webkit.org/show_bug.cgi?id=194019
2294
2295         Reviewed by Michael Catanzaro.
2296
2297         * flatpak/org.webkit.CommonModules.yaml:
2298
2299 2019-01-30  Commit Queue  <commit-queue@webkit.org>
2300
2301         Unreviewed, rolling out r240708.
2302         https://bugs.webkit.org/show_bug.cgi?id=194022
2303
2304         It broke WPE build (Requested by KaL on #webkit).
2305
2306         Reverted changeset:
2307
2308         "[WPE] Bump font related dependencies to match the GTK+ port"
2309         https://bugs.webkit.org/show_bug.cgi?id=194017
2310         https://trac.webkit.org/changeset/240708
2311
2312 2019-01-30  Zalan Bujtas  <zalan@apple.com>
2313
2314         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
2315         https://bugs.webkit.org/show_bug.cgi?id=194001
2316
2317         Reviewed by Antti Koivisto.
2318
2319         * LayoutReloaded/misc/LFC-passing-tests.txt:
2320
2321 2019-01-30  Zalan Bujtas  <zalan@apple.com>
2322
2323         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
2324         https://bugs.webkit.org/show_bug.cgi?id=194020
2325
2326         Reviewed by Antti Koivisto.
2327
2328         * LayoutReloaded/misc/LFC-passing-tests.txt:
2329
2330 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
2331
2332         AX: Support color well on iOS
2333         https://bugs.webkit.org/show_bug.cgi?id=194010
2334
2335         Reviewed by Joanmarie Diggs.
2336
2337         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2338         (WTR::AccessibilityUIElement::stringAttributeValue):
2339
2340 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2341
2342         [WPE] Bump font related dependencies to match the GTK+ port
2343         https://bugs.webkit.org/show_bug.cgi?id=194017
2344
2345         Reviewed by Žan Doberšek.
2346
2347         * wpe/jhbuild.modules:
2348         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
2349         * wpe/patches/icudata-stdlibs.patch: Added.
2350
2351 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
2352
2353         [Mac] Update window scale API usage
2354         https://bugs.webkit.org/show_bug.cgi?id=193991
2355         rdar://problem/47614795
2356
2357         Reviewed by Tim Horton.
2358
2359         * DumpRenderTree/mac/DumpRenderTree.mm:
2360         (changeWindowScaleIfNeeded):
2361         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2362         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2363         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
2364
2365 2019-01-29  Chris Dumez  <cdumez@apple.com>
2366
2367         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
2368         https://bugs.webkit.org/show_bug.cgi?id=193977
2369         <rdar://problem/47643716>
2370
2371         Reviewed by Geoff Garen.
2372
2373         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
2374         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
2375         to the previous provisional committing *before* we make the last load. 
2376
2377         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2378
2379 2019-01-29  Youenn Fablet  <youenn@apple.com>
2380
2381         Adopt new SPI to evaluate server certificate trust
2382         https://bugs.webkit.org/show_bug.cgi?id=193355
2383
2384         Reviewed by Alex Christensen.
2385
2386         Add infrastructure to handle HTTPS server trust evaluation testing.
2387
2388         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2389         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2390         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
2391         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
2392         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
2393         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2394         * WebKitTestRunner/TestController.cpp:
2395         (WTR::TestController::resetPreferencesToConsistentValues):
2396         (WTR::TestController::didReceiveAuthenticationChallenge):
2397         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
2398         * WebKitTestRunner/TestController.h:
2399         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
2400         * WebKitTestRunner/TestInvocation.cpp:
2401         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2402         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2403         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
2404
2405 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2406
2407         [ews-build] Add build step to print bot Configuration
2408         https://bugs.webkit.org/show_bug.cgi?id=193887
2409
2410         Reviewed by Lucas Forschler.
2411
2412         * BuildSlaveSupport/ews-build/steps.py:
2413         (PrintConfiguration): Build step to print configuration.
2414         * BuildSlaveSupport/ews-build/factories.py:
2415
2416 2019-01-29  Chris Dumez  <cdumez@apple.com>
2417
2418         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
2419         https://bugs.webkit.org/show_bug.cgi?id=193967
2420         <rdar://problem/47635348>
2421
2422         Reviewed by Alex Christensen.
2423
2424         Add API test coverage.
2425
2426         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2427         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
2428
2429 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2430
2431         [ews-app] Handle incoming results data
2432         https://bugs.webkit.org/show_bug.cgi?id=193973
2433
2434         Reviewed by Lucas Forschler.
2435
2436         * BuildSlaveSupport/ews-app/ews/views/results.py:
2437
2438 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2439
2440         [ews-app] Make the results url generic
2441         https://bugs.webkit.org/show_bug.cgi?id=193928
2442
2443         Reviewed by Lucas Forschler.
2444
2445         * BuildSlaveSupport/ews-app/ews/urls.py:
2446
2447 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2448
2449         [ews-build] Configure buildbot to send events to ews-app
2450         https://bugs.webkit.org/show_bug.cgi?id=193968
2451
2452         Reviewed by Lucas Forschler.
2453
2454         * BuildSlaveSupport/ews-build/events.py: Added.
2455         * BuildSlaveSupport/ews-build/master.cfg:
2456
2457 2019-01-29  Keith Rollin  <krollin@apple.com>
2458
2459         Add .xcfilelists to Run Script build phases
2460         https://bugs.webkit.org/show_bug.cgi?id=193792
2461         <rdar://problem/47201785>
2462
2463         Reviewed by Alex Christensen.
2464
2465         As part of supporting XCBuild, update the necessary Run Script build
2466         phases in their Xcode projects to refer to their associated
2467         .xcfilelist files.
2468
2469         Note that the addition of these files bumps the Xcode project version
2470         number to something that's Xcode 10 compatible. This change means that
2471         older versions of the Xcode IDE can't read these projects. Nor can it
2472         fully load workspaces that refer to these projects (the updated
2473         projects are shown as non-expandable placeholders). `xcodebuild` can
2474         still build these projects; it's just that the IDE can't open them.
2475
2476         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2477         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2478
2479 2019-01-29  John Wilander  <wilander@apple.com>
2480
2481         Add data abstraction and validation for Ad Click Attribution
2482         https://bugs.webkit.org/show_bug.cgi?id=193916
2483         <rdar://problem/47603481>
2484
2485         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
2486
2487         Ad click attribution has two steps. First, the storage of an ad
2488         campaign ID for a click that takes the user to a destination
2489         site. Second, a conversion on the destination site that can be
2490         attributed to the ad click.
2491
2492         This patch adds a class that represents a request for ad click
2493         attribution. Validation makes sure that the bits of entropy
2494         reported through this mechanism is limited.
2495
2496         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2497         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
2498         (TestWebKitAPI::TEST):
2499
2500 2019-01-29  Chris Dumez  <cdumez@apple.com>
2501
2502         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
2503         https://bugs.webkit.org/show_bug.cgi?id=193932
2504         <rdar://problem/47598947>
2505
2506         Reviewed by Brady Eidson.
2507
2508         Add API test coverage.
2509
2510         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2511
2512 2019-01-29  Zalan Bujtas  <zalan@apple.com>
2513
2514         Adding new passing LFC tests.
2515
2516         Unreviewed test gardening.
2517
2518         * LayoutReloaded/misc/LFC-passing-tests.txt:
2519
2520 2019-01-29  Zalan Bujtas  <zalan@apple.com>
2521
2522         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
2523         https://bugs.webkit.org/show_bug.cgi?id=193964
2524
2525         Reviewed by Antti Koivisto.
2526
2527         * LayoutReloaded/misc/LFC-passing-tests.txt:
2528
2529 2019-01-29  Zalan Bujtas  <zalan@apple.com>
2530
2531         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
2532         https://bugs.webkit.org/show_bug.cgi?id=193954
2533
2534         Reviewed by Antti Koivisto.
2535
2536         * LayoutReloaded/misc/LFC-passing-tests.txt:
2537
2538 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
2539
2540         WebDriver: add support for running subtests
2541         https://bugs.webkit.org/show_bug.cgi?id=193904
2542
2543         Reviewed by Michael Catanzaro.
2544
2545         pytest already supports it by passing test.py::subtest, so we can do the same.
2546
2547         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
2548         (get_item_name): Made this global.
2549         (CollectRecorder.__init__): Receive the parameter to ignore.
2550         (CollectRecorder.pytest_collectreport): Collect also the subtests.
2551         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
2552         (collect): Add parameter to ignore.
2553         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
2554         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
2555         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
2556         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
2557         (WebDriverTestRunnerSelenium.run): Ditto.
2558         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
2559         (WebDriverTestRunnerW3C.collect_tests): Ditto.
2560         (WebDriverTestRunnerW3C.run): Ditto.
2561
2562 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
2563
2564         User agent string override for navigator.userAgent should be site specific quirks
2565         https://bugs.webkit.org/show_bug.cgi?id=193950
2566
2567         Reviewed by Brent Fulgham.
2568
2569         Updated per the _WKWebsitePolicies rename.
2570
2571         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2572         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2573
2574 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
2575
2576         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
2577         https://bugs.webkit.org/show_bug.cgi?id=193941
2578
2579         Reviewed by Alex Christensen.
2580
2581         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
2582         * TestWebKitAPI/Tests/WTF/Condition.cpp:
2583         * TestWebKitAPI/Tests/WTF/Lock.cpp:
2584         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
2585         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
2586         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
2587         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
2588         * TestWebKitAPI/Tests/WTF/Time.cpp:
2589         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
2590         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
2591         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2592         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
2593
2594 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
2595
2596         Unreviewed, reorder my emails to fix autocomplete in bugzilla
2597
2598         * Scripts/webkitpy/common/config/contributors.json:
2599
2600 2019-01-28  Andy Estes  <aestes@apple.com>
2601
2602         [watchOS] Enable Parental Controls content filtering
2603         https://bugs.webkit.org/show_bug.cgi?id=193939
2604         <rdar://problem/46641912>
2605
2606         Reviewed by Ryosuke Niwa.
2607
2608         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2609
2610 2019-01-28  David Kilzer  <ddkilzer@apple.com>
2611
2612         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
2613         <https://webkit.org/b/193884>
2614
2615         Reviewed by Jiewen Tan.
2616
2617         * Scripts/webkitpy/style/checkers/cpp.py:
2618         (check_language): Add LocalAuthentication to
2619         `frameworks_with_soft_links`.
2620
2621 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
2622
2623         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
2624         https://bugs.webkit.org/show_bug.cgi?id=193891
2625
2626         Reviewed by Ross Kirsling.
2627
2628         There were three problems in window sizes of WebView and the host window.
2629         1. The sizes of pixel image output were incorrect.
2630         2. The host window is going to appear after window.resize was invoked.
2631         3. window.resize resized only the host window, not WebView.
2632
2633         This change solves them with a following approach.
2634         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
2635         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
2636            as well as DumpRenderTree in order to match the client area and the window area.
2637         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
2638         d. PlatformWebView::setWindowFrame changes both window sizes.
2639         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
2640
2641         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2642         (WTR::PlatformWebView::PlatformWebView): Create the host window
2643         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
2644         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
2645         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
2646
2647 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2648
2649         [ews-app] Add method to save Step data to database
2650         https://bugs.webkit.org/show_bug.cgi?id=193890
2651
2652         Reviewed by Lucas Forschler.
2653
2654         * BuildSlaveSupport/ews-app/ews/models/step.py:
2655         (Step.save_step): Method to save step data.
2656         (Step.update_step): Method to update step data.
2657         (Step.get_existing_step): Method to fetch existing step from database.
2658         (Step.is_valid_result): Method to validate valid step result.
2659
2660 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2661
2662         [ews-app] Add method to save Build data to database
2663         https://bugs.webkit.org/show_bug.cgi?id=193735
2664
2665         Reviewed by Lucas Forschler.
2666
2667         * BuildSlaveSupport/ews-app/ews/models/build.py:
2668         (Build.save_build): Method to save build information to database.
2669         (Build.get_existing_build): Method to fetch existing build from database.
2670         (Build.is_valid_result): Method to validate build result.
2671         * BuildSlaveSupport/ews-app/ews/common/util.py:
2672         (is_valid_int_id): Method to validate valid id.
2673
2674 2019-01-28  Chris Dumez  <cdumez@apple.com>
2675
2676         Regression(PSON) Crash under WebPageProxy::didStartProgress()
2677         https://bugs.webkit.org/show_bug.cgi?id=193915
2678         <rdar://problem/47560907>
2679
2680         Reviewed by Alex Christensen.
2681
2682         Add API test coverage.
2683
2684         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2685
2686 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2687
2688         [ews-app] Rename id variables
2689         https://bugs.webkit.org/show_bug.cgi?id=193883
2690
2691         Reviewed by Lucas Forschler.
2692
2693         * BuildSlaveSupport/ews-app/ews/models/build.py:
2694         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2695         * BuildSlaveSupport/ews-app/ews/models/step.py:
2696         * BuildSlaveSupport/ews-app/ews/urls.py:
2697         * BuildSlaveSupport/ews-app/ews/views/patch.py:
2698         * BuildSlaveSupport/ews-app/ews/views/results.py:
2699         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2700
2701 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2702
2703         [ews-app] Allow certain fields to be empty
2704         https://bugs.webkit.org/show_bug.cgi?id=193892
2705
2706         Reviewed by Lucas Forschler.
2707
2708         * BuildSlaveSupport/ews-app/ews/models/build.py:
2709         * BuildSlaveSupport/ews-app/ews/models/step.py:
2710
2711 2019-01-28  Rob Buis  <rbuis@igalia.com>
2712
2713         Update MIME type parser
2714         https://bugs.webkit.org/show_bug.cgi?id=180526
2715
2716         Reviewed by Frédéric Wang.
2717
2718         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
2719         (TestWebKitAPI::TEST):
2720
2721 2019-01-28  Zalan Bujtas  <zalan@apple.com>
2722
2723         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
2724         https://bugs.webkit.org/show_bug.cgi?id=193896
2725
2726         Reviewed by Antti Koivisto.
2727
2728         * LayoutReloaded/misc/LFC-passing-tests.txt:
2729
2730 2018-12-15  Darin Adler  <darin@apple.com>
2731
2732         Replace many uses of String::format with more type-safe alternatives
2733         https://bugs.webkit.org/show_bug.cgi?id=192742
2734
2735         Reviewed by Mark Lam.
2736
2737         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2738         (WTR::cacheTestRunnerCallback): Use makeString.
2739         * WebKitTestRunner/TestController.cpp:
2740         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
2741         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
2742
2743 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
2744
2745         Use a load optimizer for some sites
2746         https://bugs.webkit.org/show_bug.cgi?id=193881
2747         <rdar://problem/46325455>
2748
2749         Reviewed by Brent Fulgham.
2750
2751         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2752         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
2753
2754 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
2755
2756         AX: Introduce a static accessibility tree
2757         https://bugs.webkit.org/show_bug.cgi?id=193348
2758         <rdar://problem/47203295>
2759
2760         Reviewed by Ryosuke Niwa.
2761
2762         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2763
2764 2019-01-26  Zalan Bujtas  <zalan@apple.com>
2765
2766         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
2767         https://bugs.webkit.org/show_bug.cgi?id=193867
2768
2769         Reviewed by Antti Koivisto.
2770
2771         * LayoutReloaded/misc/LFC-passing-tests.txt:
2772
2773 2019-01-26  Zalan Bujtas  <zalan@apple.com>
2774
2775         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
2776         https://bugs.webkit.org/show_bug.cgi?id=193865
2777
2778         Reviewed by Antti Koivisto.
2779
2780         * LayoutReloaded/misc/LFC-passing-tests.txt:
2781
2782 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
2783
2784         Need a mechanism to override navigator.userAgent
2785         https://bugs.webkit.org/show_bug.cgi?id=193762
2786         <rdar://problem/47504939>
2787
2788         Reviewed by Brent Fulgham.
2789
2790         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
2791
2792         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2793         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2794         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
2795
2796 2019-01-25  Dean Jackson  <dino@apple.com>
2797
2798         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
2799         https://bugs.webkit.org/show_bug.cgi?id=193831
2800         <rdar://problem/47399263>
2801
2802         Reviewed by Chris Dumez.
2803
2804         Two new tests that exercise cross-origin and same-origin System
2805         Previews.
2806
2807         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2808
2809 2019-01-25  Keith Rollin  <krollin@apple.com>
2810
2811         Update Xcode projects with "Check .xcfilelists" build phase
2812         https://bugs.webkit.org/show_bug.cgi?id=193790
2813         <rdar://problem/47201374>
2814
2815         Reviewed by Alex Christensen.
2816
2817         Support for XCBuild includes specifying inputs and outputs to various
2818         Run Script build phases. These inputs and outputs are specified as
2819         .xcfilelist files. Once created, these .xcfilelist files need to be
2820         kept up-to-date. In order to check that they are up-to-date or not,
2821         add an Xcode build step that invokes an external script that performs
2822         the checking. If the .xcfilelists are found to be out-of-date, update
2823         them, halt the build, and instruct the developer to restart the build
2824         with up-to-date files.
2825
2826         At this time, the checking and regenerating is performed only if the
2827         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
2828         who want to use this facility can set this variable and test out the
2829         checking/regenerating. Once it seems like there are no egregious
2830         issues that upset a developer's workflow, we'll unconditionally enable
2831         this facility.
2832
2833         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2834         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
2835         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
2836         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2837
2838 2019-01-25  Keith Rollin  <krollin@apple.com>
2839
2840         Update Xcode projects with "Apply Configuration to XCFileLists" build target
2841         https://bugs.webkit.org/show_bug.cgi?id=193781
2842         <rdar://problem/47201153>
2843
2844         Reviewed by Alex Christensen.
2845
2846         Part of generating the .xcfilelists used as part of adopting XCBuild
2847         includes running `make DerivedSources.make` from a standalone script.
2848         It’s important for this invocation to have the same environment as
2849         when the actual build invokes `make DerivedSources.make`. If the
2850         environments are different, then the two invocations will provide
2851         different results. In order to get the same environment in the
2852         standalone script, have the script launch xcodebuild targeting the
2853         "Apply Configuration to XCFileLists" build target, which will then
2854         re-invoke our standalone script. The script is now running again, this
2855         time in an environment with all workspace, project, target, xcconfig
2856         and other environment variables established.
2857
2858         The "Apply Configuration to XCFileLists" build target accomplishes
2859         this task via a small embedded shell script that consists only of:
2860
2861             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
2862
2863         The process that invokes "Apply Configuration to XCFileLists" first
2864         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
2865         evaluated and exports it into the shell environment. When xcodebuild
2866         is invoked, it inherits the value of this variable and can `eval` the
2867         contents of that variable. Our external standalone script can then set
2868         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
2869         of command-line parameters needed to restart itself in the appropriate
2870         state.
2871
2872         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2873         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2874
2875 2019-01-25  Alex Christensen  <achristensen@webkit.org>
2876
2877         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
2878         https://bugs.webkit.org/show_bug.cgi?id=193802
2879         <rdar://problem/46010580>
2880
2881         Reviewed by Andy Estes.
2882
2883         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2884         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
2885         (TEST):
2886
2887 2019-01-25  Daniel Bates  <dabates@apple.com>
2888
2889         [iOS] uiController.keyDown() does not translate Control modified key
2890         https://bugs.webkit.org/show_bug.cgi?id=192898
2891
2892         Reviewed by Wenson Hsieh.
2893
2894         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
2895         key translation, as applicable. Among other cases, key translation occurs when performing
2896         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
2897         also makes the behavior of uiController.keyDown() more closely match the behavior of a
2898         human pressing down and releasing key(s) using a hardware keyboard.
2899
2900         * WebKitTestRunner/ios/HIDEventGenerator.h:
2901         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2902         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
2903
2904         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
2905         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
2906         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2907         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2908         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
2909         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2910         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
2911         (-[HIDEventGenerator longPress:completionBlock:]):
2912         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
2913         Update code for above renaming.
2914
2915         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
2916         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
2917
2918         (-[HIDEventGenerator keyDown:]): Added.
2919         (-[HIDEventGenerator keyUp:]): Added.
2920         (-[HIDEventGenerator keyPress:completionBlock:]):
2921         (-[HIDEventGenerator eventDispatchThreadEntry:]):
2922         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
2923         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2924         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
2925         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
2926         (WTR::parseModifier): Deleted.
2927
2928 2019-01-25  Keith Rollin  <krollin@apple.com>
2929
2930         Complete the implementation of generate-xcfilelists
2931         https://bugs.webkit.org/show_bug.cgi?id=193782
2932
2933         Reviewed by Alex Christensen.
2934
2935         A preliminary version of generate-xcfilelists was added in r238008.
2936         This patch updates that script in order to:
2937
2938         - Support checking of .xcfilelists
2939         - Perform better execution of `make DerivedSources.make` by
2940           relaunching generate-xcfilelists under xcodebuild
2941         - Support incremental generation and checking of .xcfilelists
2942         - Support supplementary .xcfilelists files from WebKitAdditions
2943         - Support being wrapped by parallel version of generate-xcfilelists in
2944           Internal that adds support for (re)generating WebKit projects in
2945           that repo.
2946         - Support builds that have been performed in WebKitBuild as well as
2947           ~/Library/Developer/code/DerivedData
2948         - Increase robustness and debugging facilities.
2949
2950         * Scripts/generate-xcfilelists:
2951
2952 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
2953
2954         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
2955         https://bugs.webkit.org/show_bug.cgi?id=193297
2956         <rdar://problem/47158841>
2957
2958         Unreviewed test case fix.
2959
2960         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
2961         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
2962
2963         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2964         (TEST):
2965
2966 2019-01-25  Keith Rollin  <krollin@apple.com>
2967
2968         Update existing .xcfilelists
2969         https://bugs.webkit.org/show_bug.cgi?id=193791
2970         <rdar://problem/47201706>
2971
2972         Reviewed by Alex Christensen.
2973
2974         Many .xcfilelist files were added in r238824 in order to support
2975         XCBuild. Update these with recent changes to the set of build files
2976         and with the current generate-xcfilelist script.
2977
2978         * DumpRenderTree/DerivedSources-input.xcfilelist:
2979         * DumpRenderTree/DerivedSources-output.xcfilelist:
2980         * WebKitTestRunner/DerivedSources-input.xcfilelist:
2981         * WebKitTestRunner/DerivedSources-output.xcfilelist:
2982
2983 2019-01-25  Keith Rollin  <krollin@apple.com>
2984
2985         Fix missing dependencies in extract-dependencies-from-makefile
2986         https://bugs.webkit.org/show_bug.cgi?id=193783
2987         <rdar://problem/47201571>
2988
2989         Reviewed by Alex Christensen.
2990
2991         The extract-dependencies-from-makefile script generates .xcfilelists
2992         for XCBuild by invoking a makefile in --debug mode, parsing the
2993         dependency information in the output, and extracting information
2994         regarding targets and dependents. However, the way `make` emits this
2995         dependency information is not rigorous, and so we need to determine
2996         what lines to look for and parse by trial and error. This approach
2997         didn't coriginally atch all the information we needed to collect, so
2998         update the script to look for the additional lines we now know to look
2999         for.
3000
3001         * Scripts/extract-dependencies-from-makefile:
3002         (Parser):
3003         (Parser.addTarget):
3004         (Parser.addPrereq):
3005         (Parser.doParse):
3006
3007 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
3008
3009         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
3010         https://bugs.webkit.org/show_bug.cgi?id=193297
3011         <rdar://problem/47158841>
3012
3013         Reviewed by Alex Christensen.
3014
3015         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
3016             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
3017         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3018         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
3019         activating the message used to trigger the callback when it is set.
3020
3021 2019-01-25  Alex Christensen  <achristensen@webkit.org>
3022
3023         WKWebView.goBack should reload if there is a safe browsing warning
3024         https://bugs.webkit.org/show_bug.cgi?id=193805
3025         <rdar://problem/46908216>
3026
3027         Reviewed by Geoff Garen.
3028
3029         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3030         (+[Simple3LookupContext sharedLookupContext]):
3031         (-[Simple3LookupContext lookUpURL:completionHandler:]):
3032         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
3033         (TEST):
3034
3035 2019-01-25  Chris Dumez  <cdumez@apple.com>
3036
3037         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
3038         https://bugs.webkit.org/show_bug.cgi?id=193788
3039         <rdar://problem/47531231>
3040
3041         Reviewed by Alex Christensen.
3042
3043         Add API test coverage.
3044
3045         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3046         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
3047
3048 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
3049
3050         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
3051         https://bugs.webkit.org/show_bug.cgi?id=193771
3052
3053         Unreviewed infrastructure fix.
3054
3055         * Scripts/webkitpy/port/darwin.py:
3056         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
3057
3058 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
3059
3060         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
3061
3062 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
3063
3064         Add contributors.json entries for Ling Ho and for a new bot watchers group.
3065
3066         * Scripts/webkitpy/common/config/contributors.json:
3067
3068 2019-01-25  Chris Dumez  <cdumez@apple.com>
3069
3070         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
3071         https://bugs.webkit.org/show_bug.cgi?id=193779
3072         <rdar://problem/46170903>
3073
3074         Reviewed by Antti Koivisto.
3075
3076         Add API test that quickly navigates forward to a previous process without waiting for it to
3077         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
3078         the process' previous page when reconnecting the it for the forward navigation.
3079
3080         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3081
3082 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
3083
3084         Need a way for JavaScript (or bundle) code to participate in undo
3085         https://bugs.webkit.org/show_bug.cgi?id=190009
3086         <rdar://problem/44807048>
3087
3088         Reviewed by Ryosuke Niwa.
3089
3090         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
3091         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
3092
3093         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3094         (WTR::UIScriptController::lastUndoLabel const):
3095         (WTR::UIScriptController::firstRedoLabel const):
3096         (WTR::UIScriptController::platformUndoManager const):
3097         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3098         (WTR::UIScriptController::lastUndoLabel const):
3099         (WTR::UIScriptController::firstRedoLabel const):
3100         (WTR::UIScriptController::platformUndoManager const):
3101         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3102         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3103         (WTR::UIScriptController::lastUndoLabel const):
3104         (WTR::UIScriptController::firstRedoLabel const):
3105         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3106         * WebKitTestRunner/UIScriptControllerCocoa.mm:
3107         (WTR::UIScriptController::lastUndoLabel const):
3108         (WTR::UIScriptController::firstRedoLabel const):
3109         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3110         (WTR::UIScriptController::platformUndoManager const):
3111         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
3112         (WTR::UIScriptController::platformUndoManager const):
3113
3114 2019-01-25  Zalan Bujtas  <zalan@apple.com>
3115
3116         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
3117         https://bugs.webkit.org/show_bug.cgi?id=193824
3118
3119         Reviewed by Antti Koivisto.
3120
3121         * LayoutReloaded/misc/LFC-passing-tests.txt:
3122
3123 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
3124
3125         Update macOS JSC bot configurations
3126         https://bugs.webkit.org/show_bug.cgi?id=193739
3127
3128         Reviewed by Alexey Proskuryakov.
3129
3130         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
3131         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3132         (BubbleQueueServer): Move JSC EWS to Mojave section.
3133         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3134         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
3135         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
3136
3137 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
3138
3139         [Win][WebKitTestRunner] Implement EventSenderProxy
3140         https://bugs.webkit.org/show_bug.cgi?id=193755
3141
3142         Reviewed by Don Olmstead.
3143
3144         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
3145         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
3146         (WTR::EventSenderProxy::dispatchMessage):
3147         (WTR::EventSenderProxy::EventSenderProxy):
3148         (WTR::EventSenderProxy::mouseDown):
3149         (WTR::EventSenderProxy::mouseUp):
3150         (WTR::EventSenderProxy::mouseMoveTo):
3151         (WTR::EventSenderProxy::mouseScrollBy):
3152         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
3153
3154 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
3155
3156         Unreviewed fix for API test failure after r240437.
3157
3158         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
3159
3160         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
3161
3162 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
3163
3164         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
3165         https://bugs.webkit.org/show_bug.cgi?id=193787
3166         <rdar://problem/47497634>
3167
3168         Reviewed by Alexey Proskuryakov.
3169
3170         * Scripts/webkitdirs.pm:
3171         (iosSimulatorApplicationsPath): Pick from available runtime directories.
3172
3173 2019-01-24  Truitt Savell  <tsavell@apple.com>
3174
3175         Unreviewed, rolling out r240446.
3176
3177         Casued 5 API failures
3178
3179         Reverted changeset:
3180
3181         "Activate the WebResourceLoadStatisticsStore in the
3182         NetworkProcess and deactivate it in the UIProcess."
3183         https://bugs.webkit.org/show_bug.cgi?id=193297
3184         https://trac.webkit.org/changeset/240446
3185
3186 2019-01-24  Zalan Bujtas  <zalan@apple.com>
3187
3188         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
3189         https://bugs.webkit.org/show_bug.cgi?id=193741
3190         <rdar://problem/47135030>
3191
3192         Reviewed by Antti Koivisto and Simon Fraser.
3193
3194         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3195         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
3196         (TestWebKitAPI::TEST):
3197
3198 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
3199
3200         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
3201         https://bugs.webkit.org/show_bug.cgi?id=193297
3202         <rdar://problem/47158841>
3203
3204         Reviewed by Alex Christensen.
3205
3206         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3207         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
3208         activating the message used to trigger the callback when it is set.
3209
3210 2019-01-24  John Wilander  <wilander@apple.com>
3211
3212         Add Ad Click Attribution as an internal/experimental feature
3213         https://bugs.webkit.org/show_bug.cgi?id=193685
3214         <rdar://problem/47450399>
3215
3216         Reviewed by Brent Fulgham.
3217
3218         Added test option adClickAttributionEnabled.
3219
3220         * DumpRenderTree/TestOptions.cpp:
3221         (TestOptions::TestOptions):
3222         * DumpRenderTree/TestOptions.h:
3223         * DumpRenderTree/mac/DumpRenderTree.mm:
3224         (setWebPreferencesForTestOptions):
3225
3226 2019-01-24  Antti Koivisto  <antti@apple.com>
3227
3228         [PSON] Flash on back navigation on Mac
3229         https://bugs.webkit.org/show_bug.cgi?id=193716
3230         <rdar://problem/47148458>
3231
3232         Reviewed by Chris Dumez.
3233
3234         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3235
3236         Closing of the previous page is delayed so waiting for didFinishNavigation is
3237         not sufficient to guarantee we have received all the messages. Wait for them.
3238
3239 2019-01-24  Chris Dumez  <cdumez@apple.com>
3240
3241         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
3242         https://bugs.webkit.org/show_bug.cgi?id=193761
3243         <rdar://problem/47456405>
3244
3245         Reviewed by Alex Christensen.
3246
3247         Add API test coverage.
3248
3249         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3250
3251 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
3252
3253         webkitpy: Missing PID in crashlog name should not be fatal
3254         https://bugs.webkit.org/show_bug.cgi?id=193771
3255
3256         If we can't determine the PID of a crashlog, just ignore the crashlog instead
3257         of raising an exception.
3258
3259         Reviewed by Lucas Forschler.
3260
3261         * Scripts/webkitpy/port/darwin.py:
3262         (DarwinPort._merge_crash_logs):
3263
3264 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
3265
3266         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
3267         https://bugs.webkit.org/show_bug.cgi?id=193746
3268
3269         Reviewed by Youenn Fablet.
3270
3271         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
3272         so we'd best just not call it.
3273
3274         * Scripts/webkitpy/w3c/test_exporter.py:
3275         (WebPlatformTestExporter.create_branch_with_patch):
3276
3277 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
3278
3279         Move FileSystem to WTF
3280         https://bugs.webkit.org/show_bug.cgi?id=193602
3281
3282         Reviewed by Yusuke Suzuki.
3283
3284         * DumpRenderTree/win/DumpRenderTree.cpp:
3285         * TestWebKitAPI/CMakeLists.txt:
3286         * TestWebKitAPI/PlatformGTK.cmake:
3287         * TestWebKitAPI/PlatformJSCOnly.cmake:
3288         * TestWebKitAPI/PlatformPlayStation.cmake:
3289         * TestWebKitAPI/PlatformWPE.cmake:
3290         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3291         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
3292         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
3293         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
3294         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
3295         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
3296         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3297         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3298         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
3299         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3300
3301 2019-01-24  Philippe Normand  <pnormand@igalia.com>
3302
3303         [WPE] Remove hard dependency on subprocess32 for the API tests
3304
3305         Rubber-stamped by Carlos Garcia Campos.
3306
3307         * glib/api_test_runner.py:
3308         (TestRunner._run_test_qt): Lazily import subprocess32 and check
3309         its presence only when running WPEQt tests.
3310
3311 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
3312
3313         [GLIB] Expose JavaScriptCore options in GLib public API
3314         https://bugs.webkit.org/show_bug.cgi?id=188742
3315
3316         Reviewed by Michael Catanzaro.
3317
3318         Add a test for the new API.
3319
3320         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3321         (testsJSCOptions):
3322         (main):
3323
3324 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
3325
3326         [GTK][WPE] Support JPEG 2000 images
3327         https://bugs.webkit.org/show_bug.cgi?id=186272
3328
3329         Reviewed by Žan Doberšek.
3330
3331         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
3332
3333         * gtk/jhbuild.modules:
3334         * wpe/jhbuild.modules:
3335
3336 2019-01-23  David Kilzer  <ddkilzer@apple.com>
3337
3338         check-webkit-style should warn when using soft-linking macros in a header
3339         <https://webkit.org/b/193750>
3340
3341         Reviewed by Darin Adler.
3342
3343         * Scripts/webkitpy/style/checkers/cpp.py:
3344         (check_language): Add softlink/header check by refactoring the
3345         softlink/framework check.
3346         (CppChecker): Enable softlink/header check by default.
3347         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3348         (CppStyleTest.test_softlink_framework): Rename from
3349         CppStyleTest.test_softlink() and change test framework name in
3350         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
3351         files. Set file_name for macros that only appear in headers.
3352         (CppStyleTest.test_softlink_header): Add tests for using
3353         soft-link macros in headers.
3354
3355 2019-01-23  Chris Dumez  <cdumez@apple.com>
3356
3357         Deprecate API to limit the maximum number of WebProcesses
3358         https://bugs.webkit.org/show_bug.cgi?id=193725
3359         <rdar://problem/47464879>
3360
3361         Reviewed by Geoff Garen.
3362
3363         Update existing API tests to stop using deprecated API.
3364
3365         * MiniBrowser/mac/AppDelegate.m:
3366         (defaultConfiguration):
3367         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3368         (TestWebKitAPI::TEST):
3369         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
3370         (TestWebKitAPI::TEST):
3371         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3372         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
3373         (TEST):
3374         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
3375         (TEST):
3376
3377 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
3378
3379         [ews-app] Rename ews model buildermappings to buildermapping
3380         https://bugs.webkit.org/show_bug.cgi?id=193729
3381
3382         Reviewed by Lucas Forschler.
3383
3384         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
3385         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
3386         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
3387
3388 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
3389
3390         [ews-app] Rename ews model steps to step
3391         https://bugs.webkit.org/show_bug.cgi?id=193697
3392
3393         Reviewed by Lucas Forschler.
3394
3395         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
3396         (Step): Renamed Steps to Step.
3397
3398 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
3399
3400         Clean up IndexedDB files between tests
3401         https://bugs.webkit.org/show_bug.cgi?id=192796
3402         <rdar://problem/46824999>
3403
3404         Reviewed by Geoffrey Garen.
3405
3406         * DumpRenderTree/mac/DumpRenderTree.mm:
3407         (runTest):
3408         * WebKitTestRunner/TestController.cpp:
3409         (WTR::TestController::resetStateToConsistentValues):
3410         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
3411         (WTR::RemoveAllIndexedDatabasesCallback):
3412         (WTR::TestController::ClearIndexedDatabases):
3413         * WebKitTestRunner/TestController.h:
3414         * WebKitTestRunner/TestInvocation.cpp:
3415         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3416
3417 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
3418
3419         [ews-app] Rename ews model Builds to Build
3420         https://bugs.webkit.org/show_bug.cgi?id=193695
3421
3422         Reviewed by Lucas Forschler.
3423
3424         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
3425         (Build): Renamed Builds to Build.
3426
3427 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
3428
3429         webkitpy: Wait longer when launching WebKitTestRunner
3430         https://bugs.webkit.org/show_bug.cgi?id=193734
3431
3432         Reviewed by Aakash Jain.
3433
3434         * Scripts/webkitpy/port/simulator_process.py:
3435         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
3436
3437 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
3438
3439         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
3440         https://bugs.webkit.org/show_bug.cgi?id=193182
3441         <rdar://problem/47452154>
3442
3443         Reviewed by Tim Horton.
3444
3445         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
3446         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
3447         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
3448
3449         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
3450         preventing later tests from recognizing gestures.
3451
3452         * WebKitTestRunner/ios/TestControllerIOS.mm:
3453         (WTR::TestController::platformResetStateToConsistentValues):
3454
3455         Cancel all touches in the UIApplication when resetting to a consistent state between tests.
3456
3457 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
3458
3459         webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
3460         https://bugs.webkit.org/show_bug.cgi?id=193722
3461         <rdar://problem/47481475>
3462
3463         Reviewed by Lucas Forschler.
3464
3465         iPhone and iPad ports should both use the iOS config.
3466
3467         * Scripts/webkitpy/port/ios_simulator.py:
3468         (IPhoneSimulatorPort.__init__):
3469         (IPadSimulatorPort.__init__):
3470
3471 2019-01-23  Rob Buis  <rbuis@igalia.com>
3472
3473         Update MIME type parser
3474         https://bugs.webkit.org/show_bug.cgi?id=180526
3475
3476         Reviewed by Frédéric Wang.
3477
3478         Add unit tests for both parse modes of ParsedContentType.
3479
3480         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3481         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added.
3482         (TestWebKitAPI::TEST):
3483
3484 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
3485
3486         [ews-app] fetch loop should not stop on network issues
3487         https://bugs.webkit.org/show_bug.cgi?id=193666
3488
3489         Reviewed by Lucas Forschler.
3490
3491         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3492         (FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
3493
3494 2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3495
3496         [iOS] Multiple WKWebViewAutofillTests are flaky failures
3497         https://bugs.webkit.org/show_bug.cgi?id=189165
3498         <rdar://problem/47433765>
3499
3500         Reviewed by Tim Horton.
3501
3502         These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to
3503         immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular,
3504         the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI
3505         process in sufficient to ensure that any previous action that blurred the focused element in the web process
3506         would make its way to the UI process by the time the layer tree commit is finished.
3507
3508         However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread.
3509         This means that if a layer tree flush was already scheduled in the web process before the element was blurred,
3510         the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test
3511         will fail because it asks for -_autofillContext too early.
3512
3513         To fix this, we tweak these tests to actually wait until the intended input session change triggered by script
3514         is handled in the UI process.
3515
3516         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
3517
3518         Tweak some of these tests to wait for input session changes before checking for the presence of an autofill
3519         context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions
3520         by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new
3521         input session.
3522
3523         (-[AutofillTestView textInputHasAutofillContext]):
3524
3525         Remove the incorrect presentation update here. This helper now assumes that the UI process is up to date.
3526
3527         * TestWebKitAPI/cocoa/TestWKWebView.h:
3528         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3529         (nextInputSessionChangeCount):
3530
3531         Monotonically increasing identifier that's incremented whenever an input session is started in the UI process.
3532         This includes changing the focused element from one to another.
3533
3534         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
3535         (-[TestWKWebView didStartFormControlInteraction]):
3536         (-[TestWKWebView didEndFormControlInteraction]):
3537         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
3538
3539         Add a helper to evaluate JavaScript and wait for this script to cause some change in the input session. This
3540         handles three cases: (1) changing focus from an element that doesn't require an input session to one that does,
3541         (2) changing focus between elements that require input sessions, and (3) changing focus from an input session
3542         that doesn't require an input session to one that doesn't.
3543
3544 2019-01-22  David Kilzer  <ddkilzer@apple.com>
3545
3546         check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters
3547         <https://webkit.org/b/193676>
3548
3549         Reviewed by Alexey Proskuryakov.
3550
3551         * Scripts/webkitpy/style/checkers/cpp.py:
3552         (check_member_initialization_list):
3553         - Don't report missing whitespace around colon if the colon at
3554           the start of the line is formatted correctly.
3555         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3556         (WebKitStyleTest.test_member_initialization_list):
3557         - Add a test for a missing permutation of existing tests.
3558         - Add a test this false-positive.
3559         - Add blank lines between subtests to make them easier to read.
3560
3561 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
3562
3563         [build.webkit.org] Unit-test failure after r237113
3564         https://bugs.webkit.org/show_bug.cgi?id=193669
3565
3566         Reviewed by Michael Catanzaro.
3567
3568         * BuildSlaveSupport/build.webkit.org-config/factories.py:
3569         (Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has 
3570         multiple or zero flags.
3571
3572 2019-01-22  Tadeu Zagallo  <tzagallo@apple.com>
3573
3574         Cache bytecode to disk
3575         https://bugs.webkit.org/show_bug.cgi?id=192782
3576         <rdar://problem/46084932>
3577
3578         Reviewed by Keith Miller.
3579
3580         Add test helper to execute bytecode-cache tests: it executes each test
3581         twice, the first with JSC_diskCachePath set to a temporary directory
3582         and second with JSC_forceDiskCache=true (in addition to the cache path)
3583         to guarantee that only the disk cache is being used and no new
3584         UnlinkedCodeBlocks are being created.
3585
3586         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh: Added.
3587         * Scripts/run-jsc-stress-tests:
3588
3589 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
3590
3591         [css-logical] Implement flow-relative margin, padding and border shorthands
3592         https://bugs.webkit.org/show_bug.cgi?id=188697
3593
3594         Reviewed by Simon Fraser and Antti Koivisto.
3595
3596         * DumpRenderTree/TestOptions.cpp:
3597         (TestOptions::TestOptions):
3598         * DumpRenderTree/TestOptions.h:
3599         * DumpRenderTree/mac/DumpRenderTree.mm:
3600         (setWebPreferencesForTestOptions):
3601         Allow tests to enable the CSSLogicalEnabled flag in WK1.
3602
3603         * Scripts/webkitpy/style/checkers/jsonchecker.py:
3604         (JSONCSSPropertiesChecker.check_codegen_properties):
3605         Allow CSS property definitions to have a 'runtime-flag' parameter which
3606         disables the property when the specified runtime flag is disabled.
3607
3608 2019-01-21  Fujii Hironori  <Hironori.Fujii@sony.com>
3609
3610         [GTK][WPE] libgcrypt-1.7.6 can't be compiled on Ubuntu 18.10
3611         https://bugs.webkit.org/show_bug.cgi?id=193643
3612
3613         Reviewed by Michael Catanzaro.
3614
3615         * gtk/jhbuild.modules: Bumped to libgcrypt-1.8.4.
3616         * wpe/jhbuild.modules: Ditto.
3617
3618 2019-01-21  Zalan Bujtas  <zalan@apple.com>
3619
3620         [LFC][Floats] Take float top position into account when computing containing block height.
3621         https://bugs.webkit.org/show_bug.cgi?id=193655
3622
3623         Reviewed by Antti Koivisto.
3624
3625         * LayoutReloaded/misc/LFC-passing-tests.txt:
3626
3627 2019-01-21  David Kilzer  <ddkilzer@apple.com>
3628
3629         Switch remaining VideoToolbox soft-linking in WebCore over to VideoToolboxSoftLink.{cpp,h}
3630         <https://webkit.org/b/193645>
3631         <rdar://problem/47421574>
3632
3633         Reviewed by Alex Christensen.
3634
3635         - Now checks for local soft-linking of all frameworks that have
3636           their own *SoftLinking.{cpp,h,mm} files.
3637         - Changes softlink/uikit warning to softlink/framework.
3638
3639         * Scripts/webkitpy/style/checkers/cpp.py:
3640         (check_language):
3641         (CppChecker):
3642         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3643         (CppStyleTest):
3644
3645 2019-01-20  Saam Barati  <sbarati@apple.com>
3646
3647         Rollout r240210: It broke tests on iOS
3648         https://bugs.webkit.org/show_bug.cgi?id=193640
3649
3650         Unreviewed.
3651
3652         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper:
3653         * Scripts/run-jsc-stress-tests:
3654
3655 2019-01-20  chris fleizach  <cfleizach@apple.com>
3656
3657         AX: Support returning relative frames for accessibility
3658         https://bugs.webkit.org/show_bug.cgi?id=193414
3659         <rdar://problem/47268501>
3660
3661         Reviewed by Zalan Bujtas.
3662
3663         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3664         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3665         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3666         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3667         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3668         (WTR::attributesOfElement):
3669         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3670
3671 2019-01-20  Yusuke Suzuki  <ysuzuki@apple.com>
3672
3673         Unreviewed, add my new email address
3674
3675         * Scripts/webkitpy/common/config/contributors.json:
3676
3677 2019-01-19  Zalan Bujtas  <zalan@apple.com>
3678
3679         [LFC][BFC] <body>'s overflow property value is propagated to viewport
3680         https://bugs.webkit.org/show_bug.cgi?id=193617
3681
3682         Reviewed by Antti Koivisto.
3683
3684         * LayoutReloaded/misc/LFC-passing-tests.txt:
3685
3686 2019-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
3687
3688         Unreviewed, rolling out r240209.
3689
3690         Broke GTK/WPE injected bundle
3691
3692         Reverted changeset:
3693
3694         "AX: Support returning relative frames for accessibility"
3695         https://bugs.webkit.org/show_bug.cgi?id=193414
3696         https://trac.webkit.org/changeset/240209