Implement the Remote Playback API.
[WebKit-https.git] / Tools / ChangeLog
1 2019-10-07  Jer Noble  <jer.noble@apple.com>
2
3         Implement the Remote Playback API.
4         https://bugs.webkit.org/show_bug.cgi?id=162971
5
6         Reviewed by Youenn Fablet.
7
8         Enable RemotePlayback for DumpRenderTree and WebKitTestRunner.
9
10         * DumpRenderTree/mac/DumpRenderTree.mm:
11         (resetWebPreferencesToConsistentValues):
12         * WebKitTestRunner/TestController.cpp:
13         (WTR::TestController::resetPreferencesToConsistentValues):
14
15 2019-10-29  Yusuke Suzuki  <ysuzuki@apple.com>
16
17         [JSC] Add fast path for String#localeCompare
18         https://bugs.webkit.org/show_bug.cgi?id=202676
19
20         Reviewed by Mark Lam.
21
22         * TestWebKitAPI/Tests/WTF/StringView.cpp:
23         (TestWebKitAPI::TEST):
24
25 2019-10-27  Wenson Hsieh  <wenson_hsieh@apple.com>
26
27         Add enterkeyhint support
28         https://bugs.webkit.org/show_bug.cgi?id=189546
29         <rdar://problem/51021148>
30
31         Reviewed by Tim Horton.
32
33         Add new API tests to check the resulting UIReturnKeyType that gets set on text input traits in the UI process,
34         given the different values for "enterkeyhint". Also verifies that the default behaviors of search fields and
35         text input fields inside actionable form elements is to show "Search" or "Go" as the return key by default,
36         unless a different value for "enterkeyhint" is specified.
37
38         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
39         * TestWebKitAPI/Tests/ios/EnterKeyHintTests.mm: Added.
40         (-[TestWKWebView test:enterKeyHint:returnKeyType:]):
41         (TestWebKitAPI::enterKeyHintTestCases):
42         (TestWebKitAPI::createWebViewAndInputDelegateForTesting):
43         (TestWebKitAPI::TEST):
44
45 2019-10-29  Truitt Savell  <tsavell@apple.com>
46
47         Unreviewed, rolling out r251639.
48
49         Caused flakey API failures for GetDisplayMediaTest.Constraints
50
51         Reverted changeset:
52
53         "Enforce user gesture for getUserMedia in case a previous
54         getUserMedia call was denied"
55         https://bugs.webkit.org/show_bug.cgi?id=203362
56         https://trac.webkit.org/changeset/251639
57
58 2019-10-29  Chris Dumez  <cdumez@apple.com>
59
60         Notification permissions are not remembered for origins without port
61         https://bugs.webkit.org/show_bug.cgi?id=203537
62         <rdar://problem/55281080>
63
64         Reviewed by Brady Eidson.
65
66         Add API test coverage.
67
68         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
69         * TestWebKitAPI/Tests/WebKit/WKSecurityOrigin.cpp: Added.
70         (TestWebKitAPI::TEST):
71
72 2019-10-29  Kate Cheney  <katherine_cheney@apple.com>
73
74        Removed duplicate email address.
75
76         * Scripts/webkitpy/common/config/contributors.json:
77
78 2019-10-29  Kate Cheney  <katherine_cheney@apple.com>
79
80         Edited email address for commiting.
81
82         * Scripts/webkitpy/common/config/contributors.json:
83
84 2019-10-28  Kate Cheney  <katherine_cheney@apple.com>
85
86         Added myself as a committer.
87
88         * Scripts/webkitpy/common/config/contributors.json:
89
90 2019-10-28  Alex Christensen  <achristensen@webkit.org>
91
92         Remove unused _WKProcessPoolConfiguration SPI
93         https://bugs.webkit.org/show_bug.cgi?id=203066
94
95         Reviewed by Youenn Fablet.
96
97         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
98         (TEST):
99
100 2019-10-28  Brady Eidson  <beidson@apple.com>
101
102         Expose _printOperationWithPrintInfo: SPI as API
103         <rdar://problem/36557179> and https://bugs.webkit.org/show_bug.cgi?id=203496
104
105         Reviewed by Andy Estes.
106
107         * MiniBrowser/mac/WK2BrowserWindowController.m:
108         (-[WK2BrowserWindowController printWebView:]):
109
110 2019-10-28  Jonathan Bedard  <jbedard@apple.com>
111
112         results.webkit.org: Show results which are missing expectations
113         https://bugs.webkit.org/show_bug.cgi?id=203494
114         <rdar://problem/56436643>
115
116         Reviewed by Aakash Jain.
117
118         * resultsdbpy/resultsdbpy/view/static/css/timeline.css:
119         (.dot.warning): Add warning dot with dark-orange color.
120         * resultsdbpy/resultsdbpy/view/static/js/expectations.js:
121         (Expectations.colorMap): Add warning.
122         (Expectations.failureTypes): Ditto.
123         (Expectations.failureTypeMap): Ditto.
124         (Expectations.symbolMap): Ditto.
125         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
126         (Legend): Add warning bubble.
127
128 2019-10-28  John Wilander  <wilander@apple.com>
129
130         Storage Access API: Make the API work with the experimental 3rd-party cookie blocking
131         https://bugs.webkit.org/show_bug.cgi?id=203428
132         <rdar://problem/56626949>
133
134         Reviewed by Alex Christensen.
135
136         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
137         (WTR::TestRunner::statisticsCallDidSetShouldDowngradeReferrerCallback):
138         (WTR::TestRunner::statisticsCallDidSetShouldBlockThirdPartyCookiesCallback):
139             Both of these were missing resets of their m_hasSet*Callback booleans.
140
141 2019-10-28  Jonathan Bedard  <jbedard@apple.com>
142
143         results.webkit.org: Report more descriptive configurations for non-Apple ports
144         https://bugs.webkit.org/show_bug.cgi?id=203490
145         <rdar://problem/56658244>
146
147         Reviewed by Carlos Alberto Lopez Perez.
148
149         * Scripts/webkitpy/port/gtk.py:
150         (GtkPort):
151         (GtkPort.configuration_for_upload): Return use GTK as the platform.
152         * Scripts/webkitpy/port/gtk_unittest.py:
153         (GtkPortTest):
154         (GtkPortTest.test_default_upload_configuration):
155         * Scripts/webkitpy/port/win.py:
156         (WinCairoPort.configuration_for_upload): Use wincairo as the platform.
157         * Scripts/webkitpy/port/wpe.py:
158         (WPEPort):
159         (WPEPort.configuration_for_upload): Use WPE as the platform.
160         * Scripts/webkitpy/port/wpe_unittest.py:
161         (WPEPortTest):
162         (WPEPortTest.test_default_upload_configuration):
163
164 2019-10-28  Aakash Jain  <aakash_jain@apple.com>
165
166         [ews] Improve summary for CompileWebKit and CompileJSC build step
167         https://bugs.webkit.org/show_bug.cgi?id=203487
168
169         Reviewed by Jonathan Bedard.
170
171         * BuildSlaveSupport/ews-build/steps.py:
172         (CompileWebKit.getResultSummary): Method to generate custom status message.
173         (CompileJSC.getResultSummary): Ditto.
174         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
175
176 2019-10-21  Jiewen Tan  <jiewen_tan@apple.com>
177
178         [WebAuthn] Warn users when multiple NFC tags present
179         https://bugs.webkit.org/show_bug.cgi?id=200932
180         <rdar://problem/54890736>
181
182         Reviewed by Brent Fulgham.
183
184         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
185         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
186         (-[TestWebAuthenticationPanelDelegate panel:updateWebAuthenticationPanel:]):
187         (TestWebKitAPI::TEST):
188         Adds a new test for -[_WKWebAuthenticationPanelDelegate panel:updateWebAuthenticationPanel:].
189         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-nfc-multiple-tags.html: Added.
190
191 2019-10-27  Claudio Saavedra  <csaavedra@igalia.com>
192
193         [GTK][WPE] Test PublicSuffix.TopPrivatelyControlledDomain is failing since r250589
194         https://bugs.webkit.org/show_bug.cgi?id=203193
195
196         Reviewed by Carlos Garcia Campos.
197
198         * TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp:
199         (TestWebKitAPI::TEST_F): Add a test for a domain consisting only of dots.
200
201 2019-10-26  youenn fablet  <youenn@apple.com>
202
203         Enforce user gesture for getUserMedia in case a previous getUserMedia call was denied
204         https://bugs.webkit.org/show_bug.cgi?id=203362
205
206         Reviewed by Eric Carlson.
207
208         Update test to take into account the ability to reask permission.
209         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
210         (TestWebKitAPI::TEST_F):
211
212 2019-10-26  Chris Lord  <clord@igalia.com>
213
214         Put OffscreenCanvas behind a build flag
215         https://bugs.webkit.org/show_bug.cgi?id=203146
216
217         Reviewed by Ryosuke Niwa.
218
219         Put OffscreenCanvas behind a build flag and enable the runtime setting
220         when running tests on platforms where it's built (GTK and WPE).
221
222         * Scripts/webkitperl/FeatureList.pm:
223         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
224         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
225         (WTR::InjectedBundle::beginTesting):
226         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
227         (WTR::TestRunner::setOffscreenCanvasEnabled):
228         * WebKitTestRunner/InjectedBundle/TestRunner.h:
229
230 2019-10-25  Jonathan Bedard  <jbedard@apple.com>
231
232         Python 3: Add support in webkitpy.common.checkout
233         https://bugs.webkit.org/show_bug.cgi?id=201956
234
235         Reviewed by Dewei Zhu.
236
237         * Scripts/test-webkitpy-python3: Add webkitpy.common.checkout.
238         * Scripts/webkitpy/common/checkout/changelog.py: Import Python 3 compatible unicdoe.
239         * Scripts/webkitpy/common/checkout/changelog_unittest.py: Import Python 3 compatible StringIO.
240         * Scripts/webkitpy/common/checkout/checkout.py: Use Python 3 compatible reduce.
241         (Checkout._modified_files_matching_predicate): Convert iterators into lists before returning.
242         (Checkout.suggested_reviewers): Ditto.
243         * Scripts/webkitpy/common/checkout/checkout_mock.py: Use full import paths.
244         * Scripts/webkitpy/common/checkout/checkout_unittest.py: Use full import paths, convert
245         iterators into lists.
246         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py: Use full import paths, use Python 3
247         compatible StringIO.
248         * Scripts/webkitpy/common/config/committers.py:
249         (Contributor.__hash__): Committers need to be hashable to be inserted into a set.
250
251 2019-10-25  Jonathan Bedard  <jbedard@apple.com>
252
253         Python 3: Add support in webkitpy.xcode
254         https://bugs.webkit.org/show_bug.cgi?id=203417
255
256         Reviewed by Dewei Zhu.
257
258         * Scripts/test-webkitpy-python3: Add webkitpy.xcode.
259         * Scripts/webkitpy/common/system/filesystem_mock.py:
260         (ReadableBinaryFileObject.seek): Add seek function to mirror actual binary file
261         behavior and support plistlib.
262         * Scripts/webkitpy/xcode/simulated_device.py:
263         (SimulatedDeviceManager._disambiguate_device_type): Use values instead of itervalues.
264         (SimulatedDeviceManager._get_device_identifier_for_type): Use items instead of iteritems.
265         (SimulatedDeviceManager.device_count_for_type): Use values instead of itervalues.
266         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
267         (SimulatedDeviceTest.mock_host_for_simctl): Use items instead of iteritems.
268         (change_state_to): Explicitly use bytes to edit a binary file.
269
270 2019-10-25  Aakash Jain  <aakash_jain@apple.com>
271
272         [EWS] Status page should show compiler ERRORS
273         https://bugs.webkit.org/show_bug.cgi?id=203418
274
275         Reviewed by Jonathan Bedard.
276
277         * BuildSlaveSupport/ews-build/steps.py:
278         (BuildLogLineObserver): Class for Analyzing build logs and extracting error logs.
279         (CompileWebKit.start): Initialize the log observer.
280         (CompileWebKit):
281         (CompileWebKit.errorReceived): Add the error to the errors log.
282
283 2019-10-25  Matt Lewis  <jlewis3@apple.com>
284
285         Rolling out r251579,r251162,r251512,r251500, and r251498 for build failures
286         and test failures
287
288         Unreviewed rollout.
289
290         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
291         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
292         (-[TestWebAuthenticationPanelDelegate panel:updateWebAuthenticationPanel:]):
293         (-[TestWebAuthenticationPanelUIDelegate _webView:runWebAuthenticationPanel:initiatedByFrame:completionHandler:]):
294         (TestWebKitAPI::TEST):
295         (-[TestWebAuthenticationPanelUIDelegate panel]): Deleted.
296         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-nfc-multiple-tags.html: Removed.
297         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid.html: Removed.
298
299 2019-10-24  Wenson Hsieh  <wenson_hsieh@apple.com>
300
301         [iOS 13] fast/forms/ios/accessory-bar-navigation.html is a flaky failure
302         https://bugs.webkit.org/show_bug.cgi?id=203294
303         <rdar://problem/54520848>
304
305         Reviewed by Tim Horton.
306
307         This layout test consistently fails when it is the first test to involve bringing up the keyboard that is run in
308         a newly created iOS simulator. This is because a software keyboard is presented when focusing the input fields
309         in the test, and the test expectation (which depends on the visual viewport) requires a hardware keyboard.
310
311         WebKitTestRunner already simulates the hardware keyboard being attached using the call to GraphicsServices SPI
312         in TestController::platformResetStateToConsistentValues. However, this was effectively a no-op in the case where
313         the simulated device has never (in its lifetime, even through reboots) brought up an input view. This is because
314         -[UIKeyboardImpl hardwareKeyboardAvailabilityChanged] is never called, due to UIInputResponderController never
315         having an active instance with an input view set. As a result, the automaticMinimizationEnabled property of
316         UIKeyboardImpl is never set to its correct initial value (which depends on GSEventIsHardwareKeyboardAttached()).
317
318         This leads to UIKeyboardImpl not automatically minimizing itself even though the hardware keyboard is attached
319         (but only until the next time the keyboard is shown, after a hardware keyboard availability change notification
320         has been sent, which occurs between every layout test).
321
322         To work around this source of flakiness, we ensure that the keyboard preference for enabling automatic
323         minimization has been set to @YES by the time we attempt to simulate connecting the hardware keyboard by calling
324         GSEventIsHardwareKeyboardAttached. Note that the extra step of writing the value to com.apple.Preferences is
325         necessary because logic in TextInput.framework exists that periodically wipes out any cached values for keyboard
326         preferences on UIInputResponderController, and then attempts to regenerate them by reading defaults in
327         com.apple.Preferences. However, the same logic also fails to actually update com.apple.Preferences before
328         reading from it, which results in a software keyboard *very* rarely appearing again when running layout tests
329         that don't expect to observe a software keyboard.
330
331         * WebKitTestRunner/ios/TestControllerIOS.mm:
332
333 2019-10-24  Ryosuke Niwa  <rniwa@webkit.org>
334
335         Add exclusion rules to text manipulation SPI
336         https://bugs.webkit.org/show_bug.cgi?id=203398
337         <rdar://problem/56567256>
338
339         Reviewed by Wenson Hsieh.
340
341         Added tests for including & excluding content based on element names and attribute values.
342
343         Also added a test to make sure _startTextManipulationsWithConfiguration calls the completion handler
344         even when the _WKTextManipulationDelegate isn't set.
345
346         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
347
348 2019-10-25  Jonathan Bedard  <jbedard@apple.com>
349
350         results.webkit.org: Report the correct flavor for leaks
351         https://bugs.webkit.org/show_bug.cgi?id=203413
352
353         Reviewed by Aakash Jain.
354
355         * BuildSlaveSupport/build.webkit.org-config/steps.py:
356         (RunWebKit1LeakTests.start):
357
358 2019-10-25  Ross Kirsling  <ross.kirsling@sony.com>
359
360         test262-runner should be able to pass JSC a feature flag
361         https://bugs.webkit.org/show_bug.cgi?id=203301
362
363         Reviewed by Keith Miller.
364
365         * Scripts/test262/Runner.pm:
366         Recognize mapping from 262 features to JSC runtime options.
367
368 2019-10-25  Jonathan Bedard  <jbedard@apple.com>
369
370         Python 3: Add support in webkitpy.common.checkout.scm
371         https://bugs.webkit.org/show_bug.cgi?id=203277
372
373         Reviewed by Stephanie Lewis.
374
375         * Scripts/test-webkitpy-python3: Add webkitpy.common.checkout.scm, add --all flag.
376         * Scripts/webkitpy/common/checkout/scm/detection.py: Use full import paths.
377         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py: Ditto.
378         * Scripts/webkitpy/common/checkout/scm/git.py:
379         (Git.revisions_changing_file): Convert filter iterator to list.
380         (Git.prepend_svn_revision): Patches need to be bytes.
381         * Scripts/webkitpy/common/checkout/scm/scm.py: Import unicode.
382         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py: Use full import paths,
383         differentiate between binary and text files, replace assertItemsEqual with sorted,
384         list fix regexes on byte arrays.
385         * Scripts/webkitpy/common/checkout/scm/stub_repository.py: Use full import paths.
386         * Scripts/webkitpy/common/checkout/scm/stub_repository_unittest.py: Use full import paths.
387         * Scripts/webkitpy/common/checkout/scm/svn.py: Use full import paths.
388         (SVN.diff_for_revision): Diff for revision should be byte array.
389         (SVN.propget): Use Python 3 compatible encoding.
390
391 2019-10-23  Ryosuke Niwa  <rniwa@webkit.org>
392
393         Add a mechanism to find and manipulate text by paragraphs
394         https://bugs.webkit.org/show_bug.cgi?id=203286
395
396         Reviewed by Wenson Hsieh.
397
398         Added basic API tests for the new SPI.
399
400         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
401         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm: Added.
402         (-[TextManipulationDelegate init]):
403         (-[TextManipulationDelegate _webView:didFindItem:forFrame:]):
404         (-[TextManipulationDelegate items]):
405         (TestWebKitAPI::createItem):
406
407 2019-10-24  Matt Lewis  <jlewis3@apple.com>
408
409         Unreviewed, rolling out r251558.
410
411         This broke internal builds
412
413         Reverted changeset:
414
415         "Add a mechanism to find and manipulate text by paragraphs"
416         https://bugs.webkit.org/show_bug.cgi?id=203286
417         https://trac.webkit.org/changeset/251558
418
419 2019-10-24  Brady Eidson  <beidson@apple.com>
420
421         Expose pageZoom as API.
422         https://bugs.webkit.org/show_bug.cgi?id=203381
423
424         Reviewed by Andy Estes.
425
426         * MiniBrowser/mac/WK2BrowserWindowController.m:
427         (-[WK2BrowserWindowController toggleZoomMode:]):
428         (-[WK2BrowserWindowController resetZoom:]):
429         (-[WK2BrowserWindowController canResetZoom]):
430         (-[WK2BrowserWindowController currentZoomFactor]):
431         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
432
433 2019-10-23  Ryosuke Niwa  <rniwa@webkit.org>
434
435         Add a mechanism to find and manipulate text by paragraphs
436         https://bugs.webkit.org/show_bug.cgi?id=203286
437
438         Reviewed by Wenson Hsieh.
439
440         Added basic API tests for the new SPI.
441
442         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
443         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm: Added.
444         (-[TextManipulationDelegate init]):
445         (-[TextManipulationDelegate _webView:didFindItem:forFrame:]):
446         (-[TextManipulationDelegate items]):
447         (TestWebKitAPI::createItem):
448
449 2019-10-24  Brady Eidson  <beidson@apple.com>
450
451         Formalize PDF snapshot API.
452         https://bugs.webkit.org/show_bug.cgi?id=203374
453
454         Reviewed by Tim Horton.
455
456         * MiniBrowser/mac/WK2BrowserWindowController.m:
457         (-[WK2BrowserWindowController saveAsPDF:]):
458
459         * TestWebKitAPI/Tests/WebKitCocoa/PDFSnapshot.mm:
460         (TestWebKitAPI::TEST):
461
462 2019-10-24  Andy Estes  <aestes@apple.com>
463
464         [Cocoa] Make it possible to convert SharedBuffer segments and data views to NSData without copying
465         https://bugs.webkit.org/show_bug.cgi?id=203348
466
467         Reviewed by Alex Christensen.
468
469         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm:
470         (TestWebKitAPI::TEST_F):
471
472 2019-10-23  Wenson Hsieh  <wenson_hsieh@apple.com>
473
474         [iOS 13] imported/mozilla/svg/text/textpath-selection.svg is flaky
475         https://bugs.webkit.org/show_bug.cgi?id=203247
476         <rdar://problem/52124292>
477
478         Reviewed by Tim Horton.
479
480         Roughly 1 in 3000 runs, this test fails due to an image diff, where only the expectation or test page shows a
481         native selection view on iOS. Both the test and expectation create DOM selections on the page, which is then
482         followed by a native selection view on the page at some point in the future.
483
484         This "point in the future" depends on both WebKit implementation details (i.e. when the next remote layer tree
485         commit happens) as well as UIKit implementation details (for example, many methods in UITextSelectionView and
486         UIWKTextInteractionAssistant will schedule changes to UIView geometry using a runloop timer, instead of applying
487         the updates immediately). Because of the latter, it's impractical to expect native selection views on iOS to
488         always appear or not appear after finishing this layout test.
489
490         To mitigate this rare source of flakiness, we hide these native text selection views when snapshotting iOS
491         WKWebViews for the purposes of ref and pixel testing.
492
493         Note that we still have a considerable number of layout tests that inspect these native selection views on iOS,
494         but they work by waiting until the native selection views reach a particular state (e.g. by polling for the
495         number of ranged selection subviews, or the presence of selection handles, or waiting for a caret selection with
496         a given geometry, etc.), which ensures that they are robust against subtle changes to the timing of selection
497         updates in the UI process.
498
499         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
500         (WTR::PlatformWebView::windowSnapshotImage):
501
502 2019-10-23  Chris Dumez  <cdumez@apple.com>
503
504         WebBackForwardCache::removeEntriesMatching() may re-enter and crash
505         https://bugs.webkit.org/show_bug.cgi?id=203341
506         <rdar://problem/56553939>
507
508         Reviewed by Geoffrey Garen.
509
510         Add API test coverage.
511
512         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
513
514 2019-10-23  Megan Gardner  <megan_gardner@apple.com>
515
516         Rename force-press-related functions to refer to context menus, and fix a former force-press test
517         https://bugs.webkit.org/show_bug.cgi?id=202663
518         <rdar://problem/52699530>
519
520         Reviewed by Dean Jackson.
521
522         Rename all relevant fuctions to more correctly reflect that this does not specifically
523         require a force press to activate any longer.
524
525         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
526         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
527         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
528         (WTR::UIScriptController::setDidShowContextMenuCallback):
529         (WTR::UIScriptController::didShowContextMenuCallback const):
530         (WTR::UIScriptController::setDidDismissContextMenuCallback):
531         (WTR::UIScriptController::didDismissContextMenuCallback const):
532         (WTR::UIScriptController::setDidShowForcePressPreviewCallback): Deleted.
533         (WTR::UIScriptController::didShowForcePressPreviewCallback const): Deleted.
534         (WTR::UIScriptController::setDidDismissForcePressPreviewCallback): Deleted.
535         (WTR::UIScriptController::didDismissForcePressPreviewCallback const): Deleted.
536         * TestRunnerShared/UIScriptContext/UIScriptController.h:
537         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
538         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
539         (-[TestRunnerWKWebView resetInteractionCallbacks]):
540         (-[TestRunnerWKWebView _didShowContextMenu]):
541         (-[TestRunnerWKWebView _didDismissContextMenu]):
542         (-[TestRunnerWKWebView _didShowForcePressPreview]): Deleted.
543         (-[TestRunnerWKWebView _didDismissForcePressPreview]): Deleted.
544         * WebKitTestRunner/ios/UIScriptControllerIOS.h:
545         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
546         (WTR::UIScriptControllerIOS::setDidShowContextMenuCallback):
547         (WTR::UIScriptControllerIOS::setDidDismissContextMenuCallback):
548         (WTR::UIScriptControllerIOS::setDidShowForcePressPreviewCallback): Deleted.
549         (WTR::UIScriptControllerIOS::setDidDismissForcePressPreviewCallback): Deleted.
550
551 2019-10-23  Aakash Jain  <aakash_jain@apple.com>
552
553         [EWS] Multiple builds are triggered for one patch sometimes in new EWS
554         https://bugs.webkit.org/show_bug.cgi?id=199417
555
556         Reviewed by Jonathan Bedard.
557
558         * BuildSlaveSupport/ews-app/ews/fetcher.py:
559         (BugzillaPatchFetcher.fetch): Set the flag before sending the patch to buildbot. Unset it in case of failure. 
560         Also added additional check for sent_to_buildbot flag before processing patch.
561         * BuildSlaveSupport/ews-app/ews/models/patch.py:
562         (Patch.save_patch): Improved logging.
563         (Patch.set_sent_to_buildbot): Modified to accept sent_to_buildbot paramater, and set the value accordingly.
564
565 2019-10-23  Truitt Savell  <tsavell@apple.com>
566
567         Unreviewed, rolling out r251261.
568
569         This broke multiple tests
570
571         Reverted changeset:
572
573         "Using version 1 CFRunloopSource for faster task dispatch"
574         https://bugs.webkit.org/show_bug.cgi?id=202874
575         https://trac.webkit.org/changeset/251261
576
577 2019-10-23  Aakash Jain  <aakash_jain@apple.com>
578
579         [ews] iOS-13-Simulator-WK2-Tests-EWS is failing with an KeyError exception
580         https://bugs.webkit.org/show_bug.cgi?id=203281
581
582         Reviewed by Jonathan Bedard.
583
584         * BuildSlaveSupport/ews-build/layout_test_failures.py:
585         (LayoutTestFailures.results_from_string.get_failing_tests): Gracefully handle the case of missing 'report' key.
586
587 2019-10-23  Jonathan Bedard  <jbedard@apple.com>
588
589         Python 3: Add support in webkitpy.results
590         https://bugs.webkit.org/show_bug.cgi?id=202478
591
592         Reviewed by Carlos Alberto Lopez Perez.
593
594         * Scripts/test-webkitpy-python3: Add webkitpy.results.
595         * Scripts/webkitpy/results/upload.py:
596         (Upload.Encoder.default): Use range instead of xrange.
597         (Upload.create_configuration): Support items iteration for Python 3.
598         (Upload.create_run_stats): Change iteritems to items.
599         (Upload.create_test_result): Ditto.
600         * Scripts/webkitpy/results/upload_unittest.py:
601         (UploadTest.Options.__init__): Change iteritems to items.
602         (UploadTest.normalize): Ditto.
603
604 2019-10-22  Jiewen Tan  <jiewen_tan@apple.com>
605
606         [WebAuthn] Supply FrameInfo in -[WKUIDelegatePrivate _webView:runWebAuthenticationPanel:initiatedByFrame:completionHandler:]
607         https://bugs.webkit.org/show_bug.cgi?id=202563
608         <rdar://problem/55973968>
609
610         Reviewed by Brent Fulgham.
611
612         Adds new test contents into existing tests.
613
614         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
615         (-[TestWebAuthenticationPanelUIDelegate init]):
616         (-[TestWebAuthenticationPanelUIDelegate _webView:runWebAuthenticationPanel:initiatedByFrame:completionHandler:]):
617         (-[TestWebAuthenticationPanelUIDelegate frame]):
618         (TestWebKitAPI::TEST):
619
620 2019-10-23  Wenson Hsieh  <wenson_hsieh@apple.com>
621
622         Unreviewed, fix tvOS and watchOS engineering builds after r251377
623
624         -[UIPasteboard itemProviders] is only available on iOS.
625
626         * TestWebKitAPI/Tests/WebKitCocoa/ClipboardTests.mm:
627         (writeMultipleObjectsToPlatformPasteboard):
628
629 2019-10-23  Jonathan Bedard  <jbedard@apple.com>
630
631         Python 3: 2to3 script may not be in a user's path
632         https://bugs.webkit.org/show_bug.cgi?id=203213
633
634         Reviewed by Dewei Zhu.
635
636         * Scripts/webkitpy/thirdparty/__init__.py:
637         (AutoinstallImportHook.__init__): Remove executive dependencies.
638         (AutoinstallImportHook._install_beautifulsoup): Use multiprocess because 2to3 sets
639         Some undesirable global logging state.
640
641 2019-10-23  Tim Horton  <timothy_horton@apple.com>
642
643         prepare-ChangeLog should whine about not having tests in WebKit-only patches
644         https://bugs.webkit.org/show_bug.cgi?id=203027
645
646         Reviewed by Ryosuke Niwa.
647
648         * Scripts/prepare-ChangeLog:
649         (generateNewChangeLogs):
650         Put the "No new tests" or list of newly added tests in the deeper
651         of the WebCore or WebKit ChangeLogs, depending on which directories
652         the patch touches.
653
654         This is mostly intended to encourage tests for WebKit-only changes.
655
656 2019-10-22  Aakash Jain  <aakash_jain@apple.com>
657
658         [ews] Status bubble should show previous failures if any in case patch is skipped
659         https://bugs.webkit.org/show_bug.cgi?id=203261
660
661         Reviewed by Jonathan Bedard.
662
663         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
664         (StatusBubble._build_bubble): Display build information from previous builds for skipped patch in
665         case there are multiple builds.
666
667 2019-10-22  Alex Christensen  <achristensen@webkit.org>
668
669         Re-enable legacy TLS by default, keep runtime switch
670         https://bugs.webkit.org/show_bug.cgi?id=203253
671
672         Reviewed by Geoffrey Garen.
673
674         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
675         (TestWebKitAPI::TEST):
676         (TestWebKitAPI::getWebSocketEventWebKitLegacy):
677
678 2019-10-22  Aakash Jain  <aakash_jain@apple.com>
679
680         [ews] Download the build archive from master when download from S3 fails
681         https://bugs.webkit.org/show_bug.cgi?id=203263
682
683         Reviewed by Jonathan Bedard.
684
685         * BuildSlaveSupport/ews-build/steps.py:
686         (DownloadBuiltProduct.evaluateCommand):
687         (DownloadBuiltProductFromMaster): Build step to download the archive from build master.
688         (DownloadBuiltProductFromMaster.getResultSummary): Added custom failure message.
689         (DownloadBuiltProductFromMaster.evaluateCommand): Overrided to ensure it doesn't use this method from base
690         class DownloadBuiltProduct.
691         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
692
693 2019-10-22  youenn fablet  <youenn@apple.com>
694
695         Remove mayHaveServiceWorkerRegisteredForOrigin
696         https://bugs.webkit.org/show_bug.cgi?id=203055
697
698         Reviewed by Alex Christensen.
699
700         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
701         Remove obsolete test.
702
703 2019-10-22  Antti Koivisto  <antti@apple.com>
704
705         operator==(Vector, Vector) should work with different inline capacities
706         https://bugs.webkit.org/show_bug.cgi?id=203245
707
708         Reviewed by Alex Christensen.
709
710         * TestWebKitAPI/Tests/WTF/Vector.cpp:
711         (TestWebKitAPI::TEST):
712
713 2019-10-22  Carlos Alberto Lopez Perez  <clopez@igalia.com>
714
715         Add a script to run ImageDiff manually
716         https://bugs.webkit.org/show_bug.cgi?id=203226
717
718         Reviewed by Adrian Perez de Castro.
719
720         This allows to manually run the ImageDiff tool more easily, that
721         is sometimes useful when debugging problems with it.
722
723         * Scripts/run-imagediff: Added.
724
725 2019-10-21  Yusuke Suzuki  <ysuzuki@apple.com>
726
727         [JSC] Thread JSGlobalObject* instead of ExecState*
728         https://bugs.webkit.org/show_bug.cgi?id=202392
729
730         Reviewed by Geoffrey Garen.
731
732         * DumpRenderTree/TestRunner.cpp:
733
734 2019-10-22  Dirk Schulze  <krit@webkit.org>
735
736         Restore my committer status.
737
738         Uneviewed.
739
740         * Scripts/webkitpy/common/config/contributors.json:
741
742 2019-10-21  Zhifei Fang  <zhifei_fang@apple.com>
743
744         [results.webkit.org] Change dot and lengend dot use same mechanism to center text and image
745         https://bugs.webkit.org/show_bug.cgi?id=203216
746
747         Reviewed by Jonathan Bedard.
748
749         * resultsdbpy/resultsdbpy/view/static/library/css/docs.yaml:
750         * resultsdbpy/resultsdbpy/view/static/library/css/index.html:
751         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
752         (.dot *):
753         (.dot img, .dot .text):
754         (.dot>img, .dot>.text):
755         (.dot.small img, .dot.small .text):
756         (.dot.small>img, .dot.small>.text):
757         (.dot.medium img, .dot.medium .text):
758         (.dot.medium>img, .dot.medium>.text):
759         (.dot.large img, .dot.large .text):
760         (.dot.large>img, .dot.large>.text):
761         (.lengend>.item .dot):
762         (.lengend>.item .dot img, .lengend>.item .dot .text):
763         (.lengend>.item .dot>img, .lengend>.item .dot>.text):
764         (.dot.small *): Deleted.
765         (.dot img, .dot.small img): Deleted.
766         (.dot.medium *): Deleted.
767         (.dot.medium img): Deleted.
768         (.dot.large *): Deleted.
769         (.dot.large img): Deleted.
770         (.lengend>.item .dot .text): Deleted.
771         (.lengend>.item .dot img): Deleted.
772
773 2019-10-21  youenn fablet  <youenn@apple.com>
774
775         Move service worker registration matching for navigation loads to network process
776         https://bugs.webkit.org/show_bug.cgi?id=203144
777
778         Reviewed by Chris Dumez.
779
780         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
781         We are now creating a WebSWClientConnection whenever receiving a WebSWClientConnection message
782         from NetworkProcess. It is free to do so given it no longer requires sending some IPC.
783         Update the tests accordingly.
784         A future patch will remove the service worker registration bit feature and corresponding test.
785
786 2019-10-21  Simon Fraser  <simon.fraser@apple.com>
787
788         TestWebKitAPI.ScrollViewScrollabilityTests.ScrollableWithOverflowHiddenAndInputView is failing on iPad simulator
789         https://bugs.webkit.org/show_bug.cgi?id=203053
790
791         Reviewed by Wenson Hsieh.
792         
793         Make ScrollableWithOverflowHiddenAndInputView only test the results on iPhones. Test is not designed for ipad.
794
795         * TestWebKitAPI/Tests/ios/ScrollViewScrollabilityTests.mm:
796         (TestWebKitAPI::TEST):
797
798 2019-10-21  Jonathan Bedard  <jbedard@apple.com>
799
800         results.webkit.org: Add ability to display time on bubbles
801         https://bugs.webkit.org/show_bug.cgi?id=203202
802         <rdar://problem/56436621>
803
804         Rubber-stamped by Aakash Jain.
805
806         * resultsdbpy/resultsdbpy/view/static/js/timeline.js: Add switch to show times under each bubble.
807         * resultsdbpy/resultsdbpy/view/templates/search.html: Correctly update timeline on callback.
808
809 2019-10-21  Dean Jackson  <dino@apple.com>
810
811         Dispatch AR event on the originating anchor element
812         https://bugs.webkit.org/show_bug.cgi?id=203198
813         <rdar://55743929>
814
815         Reviewed by Simon Fraser.
816
817         Improve this test, most importantly so that it
818         actually works :)
819
820         Retrieve the ElementIdentifier for the <a> element,
821         and trigger a system preview action on it.
822
823         * TestWebKitAPI/Tests/WebKitCocoa/SystemPreview.mm:
824         (-[TestSystemPreviewTriggeredHandler userContentController:didReceiveScriptMessage:]):
825         (TestWebKitAPI::TEST):
826         * TestWebKitAPI/Tests/WebKitCocoa/system-preview-trigger.html:
827
828 2019-10-21  Alex Christensen  <achristensen@webkit.org>
829
830         ServiceWorker tests should use TCPServer instead of WKURLSchemeHandler
831         https://bugs.webkit.org/show_bug.cgi?id=203141
832
833         Reviewed by Youenn Fablet.
834
835         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
836         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
837         (-[SWMessageHandlerForRestoreFromDiskTest userContentController:didReceiveScriptMessage:]):
838         (-[SWSchemes handledRequests]): Deleted.
839         (-[SWSchemes webView:startURLSchemeTask:]): Deleted.
840         (-[SWSchemes webView:stopURLSchemeTask:]): Deleted.
841         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerTCPServer.h: Added.
842         (ServiceWorkerTCPServer::ServiceWorkerTCPServer):
843         (ServiceWorkerTCPServer::request):
844         (ServiceWorkerTCPServer::requestWithLocalhost):
845         (ServiceWorkerTCPServer::requestWithFragment):
846         (ServiceWorkerTCPServer::userAgentsChecked):
847         (ServiceWorkerTCPServer::requestWithFormat):
848         * TestWebKitAPI/Tests/WebKitCocoa/StorageQuota.mm:
849         (-[StorageSchemes webView:startURLSchemeTask:]): Deleted.
850         (-[StorageSchemes webView:stopURLSchemeTask:]): Deleted.
851
852 2019-10-21  Jonathan Bedard  <jbedard@apple.com>
853
854         Python 3: Add support in webkitpy.common.config
855         https://bugs.webkit.org/show_bug.cgi?id=202463
856
857         Reviewed by Dewei Zhu.
858
859         * Scripts/test-webkitpy-python3: Add webkitpy.common.config to the test list.
860         * Scripts/webkitpy/common/config/committers.py:
861         (Contributor.__init__): Convert lists to maps.
862         (Contributor.__str__): __str__ will always return the native string type.
863         (Contributor.__unicode__): Use .format() string.
864         (CommitterList._exclusive_contributors): Convert filter to list.
865         (CommitterList._exclusive_committers): Ditto.
866         (CommitterList.contributors_by_search_string): Ditto.
867         * Scripts/webkitpy/common/config/committervalidator_unittest.py: Use full import paths.
868         * Scripts/webkitpy/common/config/contributionareas_unittest.py: Use full import paths.
869         * Scripts/webkitpy/common/config/ports.py:
870         (DeprecatedPort.makeArgs): Use 'in' instead of has_key.
871         * Scripts/webkitpy/common/config/urls_unittest.py:
872         * Scripts/webkitpy/common/unicode_compatibility.py:
873         (encode_for): Encode string for type.
874         * Scripts/webkitpy/thirdparty/BeautifulSoup.py: Make html5lib import auto-install compatible.
875         * Scripts/webkitpy/thirdparty/__init__.py:
876         (AutoinstallImportHook.find_module): Add html5lib.
877         (AutoinstallImportHook._install_html5lib): Make html5lib a stand-alone installed package.
878         (AutoinstallImportHook._install_mechanize): Install html5lib.
879         (AutoinstallImportHook._install_beautifulsoup): Ditto.
880
881 2019-10-21  Wenson Hsieh  <wenson_hsieh@apple.com>
882
883         [Clipboard API] Implement ClipboardItem.getType() for platform clipboard items
884         https://bugs.webkit.org/show_bug.cgi?id=203168
885
886         Reviewed by Tim Horton.
887
888         Add support for the new layout tests, as well as a new API test.
889
890         * DumpRenderTree/ios/UIScriptControllerIOS.h:
891         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
892         (WTR::UIScriptControllerIOS::copyText):
893
894         Implement UIScriptController.copyText in WebKit1. This is used in one of the new layout tests, which passes in
895         WebKit1 on macOS and iOS.
896
897         * DumpRenderTree/mac/DumpRenderTreePasteboard.mm:
898         (-[LocalPasteboard declareTypes:owner:]):
899         (-[LocalPasteboard addTypes:owner:]):
900         (-[LocalPasteboard _addTypesWithoutUpdatingChangeCount:owner:]):
901
902         Adjust logic when declaring types on the platform pasteboard, such that it behaves more like the platform; when
903         declaring types, even if the owner doesn't change, the change count should still get bumped up by 1.
904
905         * DumpRenderTree/mac/UIScriptControllerMac.h:
906         * DumpRenderTree/mac/UIScriptControllerMac.mm:
907         (WTR::UIScriptControllerMac::copyText):
908         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
909         * TestWebKitAPI/Tests/WebKitCocoa/ClipboardTests.mm: Added.
910         (-[TestWKWebView readClipboard]):
911         (createWebViewForClipboardTests):
912         (writeMultipleObjectsToPlatformPasteboard):
913
914         Add a new API test to verify that clipboard items contain the right data when writing multiple items (each with
915         different sets of types) to the platform pasteboard using native APIs.
916
917         * TestWebKitAPI/Tests/WebKitCocoa/clipboard.html: Added.
918         * WebKitTestRunner/mac/WebKitTestRunnerPasteboard.mm:
919         (-[LocalPasteboard declareTypes:owner:]):
920         (-[LocalPasteboard addTypes:owner:]):
921         (-[LocalPasteboard _addTypesWithoutUpdatingChangeCount:owner:]):
922
923 2019-10-21  Jonathan Bedard  <jbedard@apple.com>
924
925         Python 3: Add support in webkitpy.common.net
926         https://bugs.webkit.org/show_bug.cgi?id=202464
927
928         Reviewed by Dewei Zhu.
929
930         * Scripts/test-webkitpy-python3: Add webkitpy.common.net.
931         * Scripts/webkitpy/common/net/credentials_unittest.py: Replace raw_input with input for Python3.
932         * Scripts/webkitpy/common/net/ewsserver.py:
933         * Scripts/webkitpy/common/net/resultsjsonparser.py:
934         (ParsedJSONResults.__init__): Sort results by test name.
935         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
936         (test_basic): Sort results by test name.
937         * Scripts/webkitpy/common/net/statusserver.py:
938         (StatusServer._fetch_url):
939         * Scripts/webkitpy/common/net/unittestresults_unittest.py:
940
941 2019-10-18  Aakash Jain  <aakash_jain@apple.com>
942
943         EWS should have a way to retry a patch
944         https://bugs.webkit.org/show_bug.cgi?id=196599
945
946         Reviewed by Jonathan Bedard.
947
948         * BuildSlaveSupport/ews-app/ews/models/build.py:
949         (Build): Add the retried field to keep track of whether a build is requested to be retried or not.
950         (Build.set_retried): Method to set the retried field.
951         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Added the 'Retry failed builds' button.
952         * BuildSlaveSupport/ews-app/ews/views/retrypatch.py:
953         (RetryPatch.post): Added a check if the build is already retried. Also, set the retried flag appropriately.
954         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
955         (StatusBubble._build_bubble): Updated the status-bubble to in-progress while waiting for build to be retried.
956         (StatusBubble._build_bubbles_for_patch): Display the retry button only if there are failed builds.
957         * BuildSlaveSupport/ews-app/ews/migrations/0002_build_retried.py: Added database migration.
958
959 2019-10-21  Alicia Boya García  <aboya@igalia.com>
960
961         [MSE][GStreamer] Revert WebKitMediaSrc rework temporarily
962         https://bugs.webkit.org/show_bug.cgi?id=203078
963
964         Reviewed by Carlos Garcia Campos.
965
966         * Scripts/webkitpy/style/checker.py:
967
968 2019-10-21  Carlos Garcia Campos  <cgarcia@igalia.com>
969
970         Unreviewed. Mark some more WTF unit tests as slow for GTK and WPE
971
972         * TestWebKitAPI/glib/TestExpectations.json:
973
974 2019-10-21  Carlos Garcia Campos  <cgarcia@igalia.com>
975
976         [GTK][WPE] Check we don't leak the WebKitWebContext in all tests
977         https://bugs.webkit.org/show_bug.cgi?id=202981
978
979         Reviewed by Žan Doberšek.
980
981         Also include the number of references left in leaks report.
982
983         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
984         (Test::Test):
985         (Test::~Test):
986
987 2019-10-18  Jiewen Tan  <jiewen_tan@apple.com>
988
989         [WebAuthn] Warn users when no credentials are found
990         https://bugs.webkit.org/show_bug.cgi?id=203147
991         <rdar://problem/55931123>
992
993         Reviewed by Brent Fulgham.
994
995         Adds new tests for _WKWebAuthenticationPanelUpdateNoCredentialsFound.
996
997         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
998         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
999         (-[TestWebAuthenticationPanelDelegate panel:updateWebAuthenticationPanel:]):
1000         (TestWebKitAPI::TEST):
1001         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-hid-cancel.html:
1002         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-hid-no-credentials.html: Added.
1003         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-hid.html:
1004         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-nfc.html:
1005         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-u2f-no-credentials.html: Added.
1006
1007 2019-10-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1008
1009         [Clipboard API] Refactor Pasteboard::read() to take an optional item index
1010         https://bugs.webkit.org/show_bug.cgi?id=203161
1011
1012         Reviewed by Tim Horton.
1013
1014         Add a couple of new API tests to verify that the web archive type identifier ("com.apple.webarchive") is (1)
1015         written to the pasteboard when copying a rich text selection, and (2) is read when attempting to paste web
1016         content.
1017
1018         * TestWebKitAPI/Tests/WebKitCocoa/CopyHTML.mm:
1019         * TestWebKitAPI/Tests/WebKitCocoa/PasteWebArchive.mm:
1020
1021 2019-10-18  Jonathan Bedard  <jbedard@apple.com>
1022
1023         Python 3: Add support in webkitpy.common.watchlist
1024         https://bugs.webkit.org/show_bug.cgi?id=202473
1025
1026         Reviewed by Dewei Zhu.
1027
1028         * Scripts/test-webkitpy-python3: Add webkitpy.common.watchlist.
1029         * Scripts/webkitpy/common/watchlist/watchlist.py:
1030         (WatchList.find_matching_definitions): Use items instead of iteritems.
1031         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py:
1032         (WatchListTest.test_filename_definition_no_matches): Back-slash needs to be escaped.
1033         (WatchListTest.test_filename_definition): Ditto.
1034         (WatchListTest.test_cc_rules_simple): Ditto.
1035         (WatchListTest.test_cc_rules_complex): Ditto.
1036         (WatchListTest.test_cc_and_message_rules_complex): Ditto.
1037         (WatchListTest.test_cc_and_message_rules_no_matches): Ditto.
1038         (WatchListTest.test_more_and_less_match): Ditto.
1039         (WatchListTest.test_complex_match): Ditto.
1040         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
1041         (WatchListParserTest.test_bad_definition): Back-slash needs to be escaped.
1042         (WatchListParserTest.test_bad_filename_regex): Ditto.
1043         (WatchListParserTest.test_bad_more_regex): Ditto.
1044         (WatchListParserTest.test_bad_match_type): Ditto.
1045         (WatchListParserTest.test_match_type_typo): Ditto.
1046         (WatchListParserTest.test_empty_cc_rule): Ditto.
1047         (WatchListParserTest.test_cc_rule_with_invalid_email): Ditto.
1048         (WatchListParserTest.test_cc_rule_with_secondary_email): Ditto.
1049         (WatchListParserTest.test_empty_message_rule): Ditto.
1050         (WatchListParserTest.test_unused_defintion): Ditto.
1051         (WatchListParserTest.test_cc_rule_with_undefined_defintion_with_suggestion): Ditto.
1052
1053 2019-10-18  Raphael Kubo da Costa  <rakuco@webkit.org>
1054
1055         Remove myself from the CMake watchlist
1056         https://bugs.webkit.org/show_bug.cgi?id=203166
1057
1058         Reviewed by Aakash Jain.
1059
1060         * Scripts/webkitpy/common/config/watchlist:
1061
1062 2019-10-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1063
1064         Unreviewed, remove an extraneous header import after r251279
1065
1066         Address a post-landing review comment.
1067
1068         * DumpRenderTree/mac/DumpRenderTreePasteboard.mm:
1069
1070 2019-10-18  Jiewen Tan  <jiewen_tan@apple.com>
1071
1072         [WebAuthn] Implement AuthenticatorCancel
1073         https://bugs.webkit.org/show_bug.cgi?id=191523
1074         <rdar://problem/55920204>
1075
1076         Reviewed by Brent Fulgham.
1077
1078         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1079         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
1080         (TestWebKitAPI::TEST):
1081         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
1082         (-[TestWebAuthenticationPanelUIDelegate webView:runWebAuthenticationPanel:initiatedByFrame:completionHandler:]):
1083         (TestWebKitAPI::TEST):
1084         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-hid-cancel.html: Copied from Tools/TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-hid.html.
1085         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-hid.html:
1086         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-nfc.html:
1087         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion.html:
1088
1089 2019-10-18  Brian Burg  <bburg@apple.com>
1090
1091         Cleanup: Stop setting -ApplePersistenceIgnoreState when running debug Mac WebKit
1092         https://bugs.webkit.org/show_bug.cgi?id=203156
1093
1094         Reviewed by Jonathan Bedard.
1095
1096         This is no longer needed. The new value has been supported since 2014.
1097
1098         * Scripts/webkitdirs.pm:
1099         (argumentsForRunAndDebugMacWebKitApp):
1100
1101 2019-10-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1102
1103         [Clipboard API] Support navigator.clipboard.read()
1104         https://bugs.webkit.org/show_bug.cgi?id=203021
1105
1106         Reviewed by Ryosuke Niwa.
1107
1108         Make adjustments to WebKitTestRunner and DumpRenderTree to support the new layout tests. See below for more
1109         details.
1110
1111         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1112         * DumpRenderTree/mac/DumpRenderTreePasteboard.mm:
1113         (-[LocalPasteboard pasteboardItems]):
1114
1115         Fixes an existing issue with the mock NSPasteboard used for layout tests. Currently, our logic for converting
1116         the contents of the platform pasteboard to NSPasteboardItem simply writes the pasteboard data as-is to
1117         NSPasteboardItems. However, these pasteboard types may be legacy pasteboard types, in which case
1118         NSPasteboardItem will simply handle the call to `-setData:forType:` as a no-op. AppKit has logic in this
1119         scenario to canonicalize these legacy pasteboard types to their modern counterparts, but this is absent in
1120         DumpRenderTreePasteboard and WebKitTestRunnerPasteboard.
1121
1122         Address this by teaching the mock pasteboards to convert legacy types to modern types when generating platform
1123         pasteboard items.
1124
1125         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1126         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1127         (WTR::UIScriptController::copyText):
1128
1129         Add a new UIScriptController method to write a string to the platform pasteboard. This patch adds support for
1130         this new testing hook on macOS and iOS, in WebKit2 (WebKitTestRunner).
1131
1132         * TestRunnerShared/mac/NSPasteboardAdditions.h: Copied from Tools/WebKitTestRunner/mac/UIScriptControllerMac.h.
1133         * TestRunnerShared/mac/NSPasteboardAdditions.mm: Added.
1134         (+[NSPasteboard _modernPasteboardType:]):
1135
1136         Add a helper to convert legacy pasteboard types (and dynamic UTIs that map to legacy pasteboard types) to
1137         modern pasteboard types, suitable for writing to NSPasteboardItems on macOS.
1138
1139         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1140         * WebKitTestRunner/ios/UIScriptControllerIOS.h:
1141         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1142         (WTR::UIScriptControllerIOS::copyText):
1143         * WebKitTestRunner/mac/UIScriptControllerMac.h:
1144         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1145         (WTR::UIScriptControllerMac::copyText):
1146         * WebKitTestRunner/mac/WebKitTestRunnerPasteboard.mm:
1147
1148         Apply the same fix for WebKitTestRunner's mock NSPasteboard.
1149
1150         (-[LocalPasteboard _clearContentsWithoutUpdatingChangeCount]):
1151         (-[LocalPasteboard clearContents]):
1152
1153         Make -clearContents clear out all the contents on the mock pasteboard, instead of crashing in AppKit.
1154
1155         (-[LocalPasteboard declareTypes:owner:]):
1156         (-[LocalPasteboard pasteboardItems]):
1157
1158 2019-10-17  Mark Lam  <mark.lam@apple.com>
1159
1160         Use constexpr in more places and remove some unnecessary external linkage.
1161         https://bugs.webkit.org/show_bug.cgi?id=203115
1162
1163         Reviewed by Yusuke Suzuki.
1164
1165         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
1166         (TestWebKitAPI::TEST):
1167         * TestWebKitAPI/Tests/mac/IsNavigationActionTrusted.mm:
1168
1169 2019-10-17  Sihui Liu  <sihui_liu@apple.com>
1170
1171         Using version 1 CFRunloopSource for faster task dispatch
1172         https://bugs.webkit.org/show_bug.cgi?id=202874
1173
1174         Reviewed by Geoffrey Garen.
1175
1176         Fix a flaky test.
1177
1178         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
1179
1180 2019-10-17  Jonathan Bedard  <jbedard@apple.com>
1181
1182         Python 3: Add support in webkitpy.common.net.buildbot 
1183         https://bugs.webkit.org/show_bug.cgi?id=202466
1184
1185         Reviewed by Stephanie Lewis.
1186
1187         * Scripts/test-webkitpy-python3: Add webkitpy.common.net.buildbot to the test list.
1188         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1189         (Builder.url_encoded_name): Call compatible urllib quote.
1190         (Builder.revision_build_pairs_with_results): Convert iterator to list before returning.
1191         (Build.results_url): Call compatible urllib quote.
1192         (BuildBot._parse_last_build_cell):renderContents needs to be decoded in Python 3.
1193         (BuildBot._parse_current_build_cell): BeautifulSoup and bs4 render breaks differently.
1194         (BuildBot._fetch_build_dictionary): Call compatible urllib quote.
1195         * Scripts/webkitpy/common/net/regressionwindow.py:
1196         (RegressionWindow.revisions): Convert range(...) to list.
1197
1198 2019-10-17  Aakash Jain  <aakash_jain@apple.com>
1199
1200         [ews] status bubbles should show details from all the builds in case build is retried
1201         https://bugs.webkit.org/show_bug.cgi?id=203117
1202
1203         Reviewed by Jonathan Bedard.
1204
1205         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1206         (StatusBubble._build_bubble): Display messages from all the builds (including retried builds) for a patch on a queue.
1207         (StatusBubble._steps_messages_from_multiple_builds): Method to generate status using information from all the retried builds. 
1208         (StatusBubble.get_all_builds_for_queue): Method to get all the builds instead of just the latest one.
1209         (StatusBubble.get_latest_build_for_queue): Modified to use the new get_all_builds_for_queue() method.
1210
1211 2019-10-17  Emilio Cobos Álvarez  <emilio@crisal.io>
1212
1213         [GTK] Explicitly use Python 2 in jhbuild-wrapper
1214         https://bugs.webkit.org/show_bug.cgi?id=202790
1215
1216         Reviewed by Adrian Perez de Castro.
1217
1218         jhbuildutils.py requires Python 2 for the moment, so using just
1219         `python` fails in distros where Python 3 is the default.
1220
1221         * jhbuild/jhbuild-wrapper:
1222
1223 2019-10-17  Paulo Matos  <pmatos@igalia.com>
1224
1225         Check values of variables before extracting index in perl
1226         https://bugs.webkit.org/show_bug.cgi?id=202333
1227
1228         Reviewed by Jonathan Bedard.
1229
1230         If compiler doesn't properly report the host and target it was
1231         compiled for, lacking better information we just go ahead and assume
1232         there is no cross compilation involved.
1233         
1234         * Scripts/webkitdirs.pm:
1235         (isCrossCompilation):
1236
1237 2019-10-17  Pablo Saavedra  <psaavedra@igalia.com>
1238
1239         Add a driver for MiniBrowser running with WPE for
1240         benchmark_runner
1241         https://bugs.webkit.org/show_bug.cgi?id=202994
1242
1243         Reviewed by Žan Doberšek.
1244
1245         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_minibrowserwpe_driver.py: Added.
1246         (WPEMiniBrowserDriver):
1247         (WPEMiniBrowserDriver.launch_url):
1248         (WPEMiniBrowserDriver.launch_driver):
1249
1250 2019-10-17  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1251
1252         run-buildbot-test: sqlalchemy exception when upgrading the database
1253         https://bugs.webkit.org/show_bug.cgi?id=202927
1254
1255         Reviewed by Adrian Perez de Castro.
1256
1257         Update the version of sqlalchemy-migrate for pip used for the test.
1258         That fixes the exception when upgrading the database.
1259
1260         * BuildSlaveSupport/build.webkit.org-config/run-buildbot-test.py:
1261
1262 2019-10-16  Andy Estes  <aestes@apple.com>
1263
1264         [Quick Look] Test that legacy web views load previews before deciding content policy
1265         https://bugs.webkit.org/show_bug.cgi?id=202971
1266
1267         Reviewed by Alex Christensen.
1268
1269         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
1270         (-[QuickLookLegacyDelegate webView:decidePolicyForMIMEType:request:frame:decisionListener:]):
1271         (TEST):
1272         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]): Deleted.
1273
1274 2019-10-16  Chris Dumez  <cdumez@apple.com>
1275
1276         Rename PageCache to BackForwardCache
1277         https://bugs.webkit.org/show_bug.cgi?id=203048
1278
1279         Reviewed by Alex Christensen.
1280
1281         Rename PageCache to BackForwardCache for clarity and consistency with the UIProcess's WebBackForwardCache.
1282
1283         * DumpRenderTree/TestOptions.cpp:
1284         (TestOptions::TestOptions):
1285         * DumpRenderTree/TestOptions.h:
1286         * DumpRenderTree/TestRunner.cpp:
1287         (overridePreferenceCallback):
1288         * DumpRenderTree/mac/DumpRenderTree.mm:
1289         (setWebPreferencesForTestOptions):
1290         * DumpRenderTree/win/DumpRenderTree.cpp:
1291         (resetWebPreferencesToConsistentValues):
1292         (setWebPreferencesForTestOptions):
1293         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic.cpp:
1294         (TestWebKitAPI::TEST):
1295         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache.cpp:
1296         (TestWebKitAPI::TEST):
1297         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache_Bundle.cpp:
1298         (TestWebKitAPI::DOMWindowExtensionNoCache::willDisconnectDOMWindowExtensionFromGlobalObject):
1299         (TestWebKitAPI::DOMWindowExtensionNoCache::didReconnectDOMWindowExtensionToGlobalObject):
1300         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache.cpp:
1301         (TestWebKitAPI::TEST):
1302         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
1303         (TestWebKitAPI::DidRemoveFrameFromHiearchyInBackForwardCacheTest::DidRemoveFrameFromHiearchyInBackForwardCacheTest):
1304         (TestWebKitAPI::DidRemoveFrameFromHiearchyInBackForwardCacheTest::didCreatePage):
1305         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
1306         (TestWebKitAPI::TEST):
1307         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1308         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1309         (testWebKitSettings):
1310         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1311         (WTR::TestRunner::overridePreference):
1312         * WebKitTestRunner/TestController.cpp:
1313         (WTR::TestController::resetPreferencesToConsistentValues):
1314         (WTR::updateTestOptionsFromTestHeader):
1315         * WebKitTestRunner/TestOptions.h:
1316         (WTR::TestOptions::hasSameInitializationOptions const):
1317         * lldb/lldb_webkit.py:
1318         (WebCoreFrame_SummaryProvider):
1319         (WebCoreDocument_SummaryProvider):
1320         (WebCoreDocumentProvider.page_cache_state):
1321
1322 2019-10-16  Jonathan Bedard  <jbedard@apple.com>
1323
1324         Python 3: Add support in webkitpy.common.net.bugzilla
1325         https://bugs.webkit.org/show_bug.cgi?id=202468
1326
1327         Reviewed by Stephanie Lewis.
1328
1329         Make the irc library we use Python 3 compatible.
1330
1331         * Scripts/test-webkitpy-python3: Add webkitpy.common.net.bugzilla to the test list.
1332         * Scripts/webkitpy/thirdparty/irc/ircbot.py: Use full import paths.
1333         * Scripts/webkitpy/thirdparty/irc/irclib.py: Fix exceptions, printing for Python 3.
1334         (Connection._get_socket): 
1335         (ServerConnection.connect):
1336         (ServerConnection.process_data):
1337         (ServerConnection.disconnect):
1338         (ServerConnection.send_raw):
1339         (DCCConnection.connect):
1340         (DCCConnection.listen):
1341         (DCCConnection.disconnect):
1342         (DCCConnection.process_data):
1343         (DCCConnection.privmsg):
1344
1345 2019-10-16  John Wilander  <wilander@apple.com>
1346
1347         Resource Load Statistics (experimental): Block all third-party cookies on websites without prior user interaction
1348         https://bugs.webkit.org/show_bug.cgi?id=203017
1349         <rdar://problem/56262708>
1350
1351         Reviewed by Alex Christensen.
1352
1353         These changes are test infrastructure to be able to toggle the function
1354         through testRunner.setStatisticsShouldBlockThirdPartyCookies().
1355
1356         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1357         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1358         (WTR::InjectedBundle::didReceiveMessageToPage):
1359         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1360         (WTR::TestRunner::setStatisticsShouldBlockThirdPartyCookies):
1361         (WTR::TestRunner::statisticsCallDidSetShouldBlockThirdPartyCookiesCallback):
1362         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1363         * WebKitTestRunner/TestController.cpp:
1364         (WTR::TestController::setStatisticsShouldBlockThirdPartyCookies):
1365         * WebKitTestRunner/TestController.h:
1366         * WebKitTestRunner/TestInvocation.cpp:
1367         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1368         (WTR::TestInvocation::didSetShouldBlockThirdPartyCookies):
1369         * WebKitTestRunner/TestInvocation.h:
1370
1371 2019-10-16  Kate Cheney  <katherine_cheney@apple.com>
1372
1373         WKWebsiteDataStoreStatisticsResetToConsistentState() should call store.setUseITPDatabase(false)
1374         https://bugs.webkit.org/show_bug.cgi?id=203020
1375         <rdar://problem/56314484>
1376
1377         Reviewed by Chris Dumez.
1378
1379         Added a completion handler to setUseITPDatabase() to avoid race
1380         conditions.
1381
1382         * WebKitTestRunner/TestController.cpp:
1383         (WTR::TestController::setUseITPDatabase):
1384
1385 2019-10-16  Fujii Hironori  <Hironori.Fujii@sony.com>
1386
1387         DumpRenderTree should clear WTFLogChannelState::OnWithAccumulation state set by testRunner.accummulateLogsForChannel
1388         https://bugs.webkit.org/show_bug.cgi?id=203024
1389
1390         Reviewed by Alex Christensen.
1391
1392         If a test case calls testRunner.accummulateLogsForChannel("IndexedDB"),
1393         all subsequent IndexedDB tests also dump the log.
1394         This is unnecessarily bloating DumpRenderTree log because
1395         DumpRenderTree is run with --debug-rwt-logging switch on Buildbot.
1396
1397         Add a function to clear WTFLogChannelState::OnWithAccumulation
1398         state, and call it for every test execution.
1399
1400         * DumpRenderTree/mac/DumpRenderTree.mm:
1401         (resetWebViewToConsistentStateBeforeTesting):
1402         * DumpRenderTree/win/DumpRenderTree.cpp:
1403         (resetWebViewToConsistentStateBeforeTesting):
1404         Call WebCoreTestSupport::clearAllLogChannelsToAccumulate.
1405
1406 2019-10-16  Wenson Hsieh  <wenson_hsieh@apple.com>
1407
1408         Remove an API test workaround that is no longer needed
1409         https://bugs.webkit.org/show_bug.cgi?id=203037
1410
1411         Reviewed by Tim Horton.
1412
1413         This worked around <rdar://problem/51510554> by avoiding codepaths that resulted in failure to read dropped
1414         content from NSItemProviders on iOS. <rdar://problem/51510554> is fixed in iOS 13, so we can remove this hack.
1415
1416         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1417         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
1418         (applyWorkaroundToAllowWritingAttributedStringsToItemProviders): Deleted.
1419
1420 2019-10-16  Pablo Saavedra  <psaavedra@igalia.com>
1421
1422         [Tools] Add a driver for cog for benchmark_runner.py
1423         https://bugs.webkit.org/show_bug.cgi?id=202995
1424
1425         Reviewed by Žan Doberšek.
1426
1427         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_cog_driver.py: Added.
1428         (CogBrowserDriver):
1429         (CogBrowserDriver.launch_url):
1430         (CogBrowserDriver.launch_driver):
1431         (CogFdoBrowserDriver):
1432         (CogFdoBrowserDriver.launch_url):
1433
1434 2019-10-16  Youenn Fablet  <youenn@apple.com>
1435
1436         WebAudioSourceProviderAVFObjC::provideInput should set its WebAudioBufferList parameters correctly
1437         https://bugs.webkit.org/show_bug.cgi?id=202930
1438         <rdar://problem/56006776>
1439
1440         Reviewed by Eric Carlson.
1441
1442         Add a test that has an audio track that goes from 1 to 2 channels while being piped to a WebAudio pipeline.
1443
1444         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1445         * TestWebKitAPI/Tests/WebKit/GetUserMedia.mm:
1446         (-[GUMMessageHandler userContentController:didReceiveScriptMessage:]):
1447         (TestWebKitAPI::TEST):
1448         * TestWebKitAPI/Tests/WebKit/getUserMedia-webaudio.html: Added.
1449
1450 2019-10-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1451
1452         [GTK][WPE] Add user messages API
1453         https://bugs.webkit.org/show_bug.cgi?id=202847
1454
1455         Reviewed by Adrian Perez de Castro.
1456
1457         Add a test to check the new API.
1458
1459         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
1460         (UserMessageTest::webViewUserMessageReceivedCallback):
1461         (UserMessageTest::webContextUserMessageReceivedCallback):
1462         (UserMessageTest::UserMessageTest):
1463         (UserMessageTest::~UserMessageTest):
1464         (UserMessageTest::sendMessage):
1465         (UserMessageTest::sendMedssageToAllExtensions):
1466         (UserMessageTest::viewUserMessageReceived):
1467         (UserMessageTest::contextUserMessageReceived):
1468         (UserMessageTest::waitUntilViewMessageReceived):
1469         (UserMessageTest::waitUntilContextMessageReceived):
1470         (readFileDescritpor):
1471         (testWebExtensionUserMessages):
1472         (beforeAll):
1473         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1474         (documentLoadedCallback):
1475         (pageMessageReceivedCallback):
1476         (pageCreatedCallback):
1477         (extensionMessageReceivedCallback):
1478         (webkit_web_extension_initialize_with_user_data):
1479
1480 2019-10-15  Aakash Jain  <aakash_jain@apple.com>
1481
1482         Improve summary for WebKitPerl Tests build step
1483         https://bugs.webkit.org/show_bug.cgi?id=203006
1484
1485         Reviewed by Jonathan Bedard.
1486
1487         * BuildSlaveSupport/ews-build/steps.py:
1488         (RunWebKitPerlTests.getResultSummary): Override method to customize summary.
1489         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
1490
1491 2019-10-15  Zhifei Fang  <zhifei_fang@apple.com>
1492
1493         Tool to mark jsc test skip/enable
1494         https://bugs.webkit.org/show_bug.cgi?id=202063
1495
1496         Reviewed by Keith Miller.
1497
1498         * Scripts/run-javascriptcore-tests:
1499         (runJSCStressTests):
1500         * Scripts/run-jsc-stress-tests:
1501
1502 2019-10-15  Peng Liu  <peng.liu6@apple.com>
1503
1504         [Picture-in-Picture Web API] Implement HTMLVideoElement.requestPictureInPicture() / Document.exitPictureInPicture()
1505         https://bugs.webkit.org/show_bug.cgi?id=201024
1506
1507         Reviewed by Eric Carlson.
1508
1509         Add configurations for Picture-in-Picture API and enable it in the test runner.
1510
1511         * Scripts/webkitperl/FeatureList.pm:
1512         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1513         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1514         (WTR::InjectedBundle::beginTesting):
1515         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1516         (WTR::TestRunner::setPictureInPictureAPIEnabled):
1517         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1518
1519 2019-10-15  Jiewen Tan  <jiewen_tan@apple.com>
1520
1521         [WebAuthn] Rename -[WKUIDelegatePrivate webView:runWebAuthenticationPanel:initiatedByFrame:completionHandler:] to -[WKUIDelegatePrivate _webView:runWebAuthenticationPanel:initiatedByFrame:completionHandler:]
1522         https://bugs.webkit.org/show_bug.cgi?id=202564
1523         <rdar://problem/55974027>
1524
1525         Reviewed by Brent Fulgham.
1526
1527         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
1528         (-[TestWebAuthenticationPanelUIDelegate _webView:runWebAuthenticationPanel:initiatedByFrame:completionHandler:]):
1529         (-[TestWebAuthenticationPanelUIDelegate webView:runWebAuthenticationPanel:initiatedByFrame:completionHandler:]): Deleted.
1530
1531 2019-10-15  Aakash Jain  <aakash_jain@apple.com>
1532
1533         [ews] Use python 3 compatible way to represent octal in buildbot code
1534         https://bugs.webkit.org/show_bug.cgi?id=202999
1535
1536         Reviewed by Jonathan Bedard.
1537
1538         * BuildSlaveSupport/ews-build/buildbot.tac:
1539         * BuildSlaveSupport/ews-build/steps.py:
1540
1541 2019-10-15  Jonathan Bedard  <jbedard@apple.com>
1542
1543         results.webkit.org: Add os version to various unix ports
1544         https://bugs.webkit.org/show_bug.cgi?id=202955
1545
1546         Rubber-stamped by Aakash Jain.
1547
1548         * Scripts/webkitpy/common/system/platforminfo.py:
1549         (PlatformInfo.__init__): Use platform.release() to defined the os_version.
1550
1551 2019-10-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1552
1553         REGRESSION: editing/async-clipboard/clipboard-interfaces.html is failing in WebKit1
1554         https://bugs.webkit.org/show_bug.cgi?id=202940
1555         <rdar://problem/56262298>
1556
1557         Reviewed by Ryosuke Niwa.
1558
1559         Add some plumbing to support the async clipboard API experimental test option in Windows.
1560
1561         * DumpRenderTree/win/DumpRenderTree.cpp:
1562         (setWebPreferencesForTestOptions):
1563
1564 2019-10-15  Jiewen Tan  <jiewen_tan@apple.com>
1565
1566         [WebAuthn] Write more tests for _WKWebAuthenticationPanel
1567         https://bugs.webkit.org/show_bug.cgi?id=202565
1568         <rdar://problem/55974128>
1569
1570         Reviewed by Brent Fulgham.
1571
1572         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1573         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
1574         (-[TestWebAuthenticationPanelDelegate panel:dismissWebAuthenticationPanelWithResult:]):
1575         (-[TestWebAuthenticationPanelUIDelegate init]):
1576         (-[TestWebAuthenticationPanelUIDelegate webView:runWebAuthenticationPanel:initiatedByFrame:completionHandler:]):
1577         (TestWebKitAPI::TEST):
1578         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-hid.html: Added.
1579         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-nfc.html: Added.
1580
1581 2019-10-15  Alex Christensen  <achristensen@webkit.org>
1582
1583         Pass CORS-enabled schemes through WebProcess instead of having them NetworkProcess-global
1584         https://bugs.webkit.org/show_bug.cgi?id=202891
1585
1586         Reviewed by Youenn Fablet.
1587
1588         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1589         (-[SWMessageHandlerWithExpectedMessage userContentController:didReceiveScriptMessage:]):
1590         Use EXPECT_WK_STREQ so I can see what is going on on EWS.
1591
1592 2019-10-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1593
1594         Unreviewed. Fix several GTK tests in /WebKit2Gtk/TestUIClient crashing since r241988
1595
1596         This was not caused by r241988, but revealed the existing bug. We were not creating the new WebKitWebView in
1597         UIClientTest with the related WebKitWebView. Since r241988, the new WebPageProxy drawing area is passed to
1598         creationParameters(), but it's nullptr because the WebPageProxy hasn't been initialized yet. When using related
1599         views, the new WebPageProxy is already initialized because it has running processes on creation.
1600
1601         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
1602         (testWebViewCreateNavigationData):
1603
1604 2019-10-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1605
1606         Unreviewed. Fix GTK test /WebKit2Gtk/TestWebViewEditor
1607
1608         It's failing since we delay the web process launch until the first load. Load about:blank in the test
1609         constructor to fix it.
1610
1611         * TestWebKitAPI/Tests/WebKitGtk/TestWebViewEditor.cpp:
1612
1613 2019-10-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1614
1615         Unreviewed. Fix GTK test /webkit/Authentication/authentication-storage after r249962
1616
1617         The test was still using the legacy private browsing API that is a no-op since r249962. This partch updates the
1618         test to use a ephemeral WebView instead.
1619
1620         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
1621         (EphemeralAuthenticationTest::setup):
1622         (EphemeralAuthenticationTest::teardown):
1623         (testWebViewAuthenticationEphemeral):
1624         (testWebViewAuthenticationStorage):
1625         (beforeAll):
1626         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
1627         (WebViewTest::initializeWebView):
1628         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h:
1629
1630 2019-10-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1631
1632         Unreviewed. Fix GTK test /webkit/WebKitSettings/webkit-settings after r249962.
1633
1634         Stop testing WebKitSettings:enable-private-browsing.
1635
1636         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1637         (testWebKitSettings):
1638
1639 2019-10-15  Alicia Boya García  <aboya@igalia.com>
1640
1641         gdb webkit.py: Fix iterator error in Python3
1642         https://bugs.webkit.org/show_bug.cgi?id=202926
1643
1644         Reviewed by Jonathan Bedard.
1645
1646         Some distros use Python3 for gdb, so the script needs to be compatible with both versions for it to work.
1647
1648         * gdb/webkit.py:
1649         (WTFVectorPrinter.Iterator.__next__):
1650
1651 2019-10-14  Zhifei FANG  <zhifei_fang@apple.com>
1652
1653         results.webkit.org: TypeError when evaluating empty commits
1654         https://bugs.webkit.org/show_bug.cgi?id=202936
1655
1656         Reviewed by Jonathan Bedard.
1657
1658         *resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js: Draw empty line when invaild scales or dots state pass in
1659
1660 2019-10-14  Jonathan Bedard  <jbedard@apple.com>
1661
1662         Python 3: Add support in webkitpy.common.net.bugzilla
1663         https://bugs.webkit.org/show_bug.cgi?id=202465
1664
1665         Reviewed by Dewei Zhu.
1666
1667         * Scripts/test-webkitpy-python3: Add webkitpy.common.net.bugzilla to the test list.
1668         * Scripts/webkitpy/common/net/bugzilla/__init__.py: Use full import paths.
1669         * Scripts/webkitpy/common/net/bugzilla/attachment_unittest.py: Ditto.
1670         * Scripts/webkitpy/common/net/bugzilla/bug.py: Ditto.
1671         (Bug.commit_revision): Dictionary sorting is no longer well defined in Python 3.
1672         * Scripts/webkitpy/common/net/bugzilla/bug_unittest.py: Use full import paths.
1673         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py: Ditto.
1674         (EditUsersParser.login_userid_pairs_from_edit_user_results): Return list, not an iterator.
1675         (EditUsersParser.user_dict_from_edit_user_page): HTML_ENTITIES is logically connected to BeautifulSoup, not
1676         BeautifulStoneSoup. 
1677         (BugzillaQueries._parse_attachment_ids_request_query): Explicitly cast date_tag to unicode.
1678         (Bugzilla._parse_attachment_element): Legacy BeautifulSoup and bs4 Elements have different function calls.
1679         (Bugzilla._file_object_for_upload): Use BytesIO instead of StringIO.
1680         (Bugzilla.create_bug):
1681         (reopen_bug): Access map as list, not iterator.
1682         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py: Use full import paths.
1683         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py: Ditto.
1684         * Scripts/webkitpy/common/net/bugzilla/test_expectation_updater.py:
1685         (TestExpectationUpdater._update_from_generic_attachment): Use items over iteritems().
1686         (TestExpectationUpdater._update_from_platform_specific_attachment): Ditto.
1687         (TestExpectationUpdater.do_update): Ditto.
1688         * Scripts/webkitpy/common/net/buildbot/buildbot.py: Use Python 2/3 compatible urllib.
1689         * Scripts/webkitpy/common/net/credentials.py: Use import statement to force autoinstall logic.
1690         * Scripts/webkitpy/common/net/file_uploader.py: Use Python 2/3 compatible urllib.
1691         (FileUploader._upload_data.callback):
1692         (FileUploader):
1693         * Scripts/webkitpy/common/net/resultsjsonparser.py:
1694         (JSONTestResult._tokenize): Force map() call to return a list.
1695         * Scripts/webkitpy/common/net/web_mock.py: Use Python 2/3 compatible urllib.
1696         * Scripts/webkitpy/common/system/autoinstall.py:
1697         (AutoInstaller.install): Return True if install was required, otherwise, return False.
1698         * Scripts/webkitpy/common/system/filesystem_mock.py:
1699         (MockFileSystem.__init__): Encode strings before writing them to the filesystem.
1700         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: Use Python 2/3 compatible urllib.
1701         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1702         (TestExpectationParser): Use items over iteritems().
1703         * Scripts/webkitpy/layout_tests/models/test_failures.py: Use Python 3 compatible Pickle library.
1704         * Scripts/webkitpy/layout_tests/models/test_results.py: Ditto.
1705         * Scripts/webkitpy/port/darwin_testcase.py:
1706         (DarwinTest.test_crashlog_path): Use dictionary for files.
1707         * Scripts/webkitpy/test/main.py:
1708         (Tester._run_tests): Update directories excluded from testing.
1709         * Scripts/webkitpy/thirdparty/BeautifulSoup.py: Replaced.
1710         (BeautifulSoup):Wrapper class making bs4 BeautifulSoup compatible with legacy BeautifulSoup calls.
1711         (BeautifulStoneSoup): Ditto.
1712         * Scripts/webkitpy/thirdparty/BeautifulSoup_legacy.py: Copied from Tools/Scripts/webkitpy/thirdparty/BeautifulSoup.py.
1713         * Scripts/webkitpy/thirdparty/__init__.py:
1714         (AutoinstallImportHook.__init__): Accept executive.
1715         (AutoinstallImportHook.find_module): Add beautifulsoup.
1716         (AutoinstallImportHook._install_beautifulsoup): bs4 must be converted via 2to3 before use in Python 3.
1717         (AutoinstallImportHook._install): Return result from installer.
1718         * Scripts/webkitpy/thirdparty/mock.py:
1719         (Mock.reset_mock): Use values() instead of itervalues().
1720
1721 2019-10-14  Matt Mokary  <mmokary@apple.com>
1722
1723         FindController::findString always updates foundStringMatchIndex even if match is the same as before
1724         https://bugs.webkit.org/show_bug.cgi?id=201775
1725         <rdar://problem/55352425>
1726
1727         Reviewed by Tim Horton.
1728
1729         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewFindString.mm:
1730         (TestWebKitAPI::TEST):
1731         _WKFindOptionsNoIndexChange test
1732
1733 2019-10-14  Andy Estes  <aestes@apple.com>
1734
1735         REGRESSION (r243682): Quick Look previews loaded from the memory cache render with the wrong content type
1736         https://bugs.webkit.org/show_bug.cgi?id=202935
1737         <rdar://problem/54318133>
1738
1739         Reviewed by Tim Horton.
1740
1741         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
1742         (TEST):
1743         * TestWebKitAPI/cocoa/TestWKWebView.h:
1744         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1745         (-[WKWebView synchronouslyGoBack]):
1746         (-[WKWebView synchronouslyGoForward]):
1747
1748 2019-10-14  Alex Christensen  <achristensen@webkit.org>
1749
1750         REGRESSION: [iOS 13?] TestWebKitAPI.SharedBufferTest.tryCreateArrayBufferLargeSegments is failing
1751         https://bugs.webkit.org/show_bug.cgi?id=201902
1752
1753         Reviewed by Ryosuke Niwa.
1754
1755         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp:
1756         (TestWebKitAPI::TEST_F):
1757
1758 2019-10-14  Saam Barati  <sbarati@apple.com>
1759
1760         Canonicalize how we prepare the prototype chain for inline caching
1761         https://bugs.webkit.org/show_bug.cgi?id=202827
1762         <rdar://problem/56193919>
1763
1764         Reviewed by Yusuke Suzuki.
1765
1766         * Scripts/run-jsc-stress-tests:
1767
1768 2019-10-14  Nikolas Zimmermann  <nzimmermann@igalia.com>
1769
1770         Update my nickname.
1771
1772         Unreviewed.
1773
1774         * Scripts/webkitpy/common/config/contributors.json:
1775
1776 2019-10-14  Nikolas Zimmermann  <nzimmermann@igalia.com>
1777
1778         Fix Tools/Scripts/update-webkitgtk-libs build failure in 'gst-plugins-bad'
1779         https://bugs.webkit.org/show_bug.cgi?id=202931
1780
1781         Reviewed by Philippe Normand.
1782
1783         OpenEXR dependency is not required and causes a build failure on Ubuntu
1784         19.04 with OpenEXR 2.2.1, as described here:
1785         https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/1089
1786
1787         * gstreamer/jhbuild.modules: Disable openexr in meson build options.
1788
1789 2019-10-14  Jonathan Bedard  <jbedard@apple.com>
1790
1791         results.webkit.org: Make recent=False more usable
1792         https://bugs.webkit.org/show_bug.cgi?id=202873
1793
1794         Rubber-stamped by Aakash Jain.
1795
1796         * resultsdbpy/resultsdbpy/model/configuration_context.py:
1797         (ConfigurationContext.search_for_configuration): If no configuration is specified,
1798         use a set of configurations defined by recent platform.
1799         * resultsdbpy/resultsdbpy/model/configuration_context_unittest.py:
1800         (ConfigurationContextTest.test_expired_configurations): Test that recent=False works.
1801
1802 2019-10-14  Adrian Perez de Castro  <aperez@igalia.com>
1803
1804         Unreviewed, set Adrian Perez de Castro as WebKit Reviewer
1805
1806         * Scripts/webkitpy/common/config/contributors.json:
1807
1808 2019-10-14  youenn fablet  <youenn@apple.com>
1809
1810         Reuse existing web processes for running service workers
1811         https://bugs.webkit.org/show_bug.cgi?id=202195
1812
1813         Reviewed by Chris Dumez.
1814
1815         Add support for enforcing a separate process for service workers.
1816         This is useful for tests trying to crash the service worker process.
1817
1818         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1819         Update test to use serviceWorkerProcessCount.
1820         Add test to check for in process and out of process service workers.
1821         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1822         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1823         (WTR::TestRunner::setUseSeparateServiceWorkerProcess):
1824         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1825         * WebKitTestRunner/TestController.cpp:
1826         (WTR::TestController::resetStateToConsistentValues):
1827         * WebKitTestRunner/TestInvocation.cpp:
1828         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1829
1830 2019-10-12  Chris Dumez  <cdumez@apple.com>
1831
1832         Back/Forward cache does not work after doing a favorite navigation
1833         https://bugs.webkit.org/show_bug.cgi?id=202762
1834         <rdar://problem/56126911>
1835
1836         Reviewed by Antti Koivisto.
1837
1838         Add API test coverage.
1839
1840         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1841
1842 2019-10-12  Ryosuke Niwa  <rniwa@webkit.org>
1843
1844         requestIdleCallback cannot be enabled in DumpRenderTree on Windows
1845         https://bugs.webkit.org/show_bug.cgi?id=202876
1846
1847         Reviewed by Wenson Hsieh.
1848
1849         Added the missing plumbing for Windows port.
1850
1851         * DumpRenderTree/win/DumpRenderTree.cpp:
1852         (setWebPreferencesForTestOptions):
1853
1854 2019-10-11  Aakash Jain  <aakash_jain@apple.com>
1855
1856         Update build.webkit.org basedir
1857         https://bugs.webkit.org/show_bug.cgi?id=202856
1858
1859         Reviewed by Jonathan Bedard.
1860
1861         * BuildSlaveSupport/build.webkit.org-config/buildbot.tac: Updated basedir. Also increased the
1862         size of twistd.log files and reduced number of files for easier maintenance.
1863
1864 2019-10-11  Aakash Jain  <aakash_jain@apple.com>
1865
1866         [ews] Services EWS should also run build.webkit.org unit tests
1867         https://bugs.webkit.org/show_bug.cgi?id=202864
1868
1869         Reviewed by Jonathan Bedard.
1870
1871         * BuildSlaveSupport/ews-build/factories.py:
1872         (ServicesFactory.__init__): Added new RunBuildWebKitUnitTests step.
1873         * BuildSlaveSupport/ews-build/steps.py:
1874         (CheckPatchRelevance): Added paths for build.webkit.org code.
1875         (RunBuildWebKitUnitTests): Build step to run build.webkit.org unit tests.
1876         (RunBuildWebKitUnitTests.__init__): Set workdir, timeout and logEnviron.
1877         (RunBuildWebKitUnitTests.getResultSummary): Customize Buildbot messages for this build step.
1878         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1879
1880 2019-10-11  Chris Dumez  <cdumez@apple.com>
1881
1882         Move SuspendedPage logic from WebProcessPool to new WebBackForwardCache class
1883         https://bugs.webkit.org/show_bug.cgi?id=202660
1884
1885         Reviewed by Antti Koivisto.
1886
1887         Drop test that relied on reusing a SuspendedPage's process from a loadHTMLStringLoad (optimization).
1888         This no longer works now that SuspendedPages are owned by their associated back/forward item because
1889         we currently do not create a back/forward item for loadHTMLString requests. Suspending a page for a
1890         loadHTMLString was also wasteful since there was no way to restore that page (given that there was
1891         no WebBackForwardListItem to go back to).
1892
1893         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1894
1895 2019-10-11  Brian Burg  <bburg@apple.com>
1896
1897         Remove some dead code in webkitpy's mac.py
1898         https://bugs.webkit.org/show_bug.cgi?id=202853
1899
1900         Reviewed by Alexey Proskuryakov.
1901
1902         - Remove _build_java_test_support as it no longer does anything.
1903         - Remove _check_port_build as it's only used to build Java test support.
1904         - Remove unused is_mavericks() function.
1905         - Remove a log stripping pattern that was fixed several releases ago.
1906
1907         * Scripts/webkitpy/port/base.py:
1908         (Port.check_build):
1909         (Port.check_api_test_build):
1910         (Port._check_driver):
1911         (Port._check_port_build): Deleted.
1912         * Scripts/webkitpy/port/mac.py:
1913         (MacPort.operating_system):
1914         (MacPort.default_child_processes):
1915         (MacPort.logging_patterns_to_strip):
1916         (MacPort.is_mavericks): Deleted.
1917         (MacPort._build_java_test_support): Deleted.
1918         (MacPort._check_port_build): Deleted.
1919
1920 2019-10-11  Aakash Jain  <aakash_jain@apple.com>
1921
1922         [build.webkit.org] API tests should output result summary in json format
1923         https://bugs.webkit.org/show_bug.cgi?id=202854
1924
1925         Reviewed by Jonathan Bedard.
1926
1927         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1928         (RunAPITests): Output results in json format as well.
1929
1930 2019-10-11  Jonathan Bedard  <jbedard@apple.com>
1931
1932         Unreviewed, rolling out r250945.
1933
1934         Broke 18 Debug API tests
1935
1936         Reverted changeset:
1937
1938         "Add support for CompactPointerTuple<..., OptionSet<...>>"
1939         https://bugs.webkit.org/show_bug.cgi?id=201316
1940         https://trac.webkit.org/changeset/250945
1941
1942 2019-10-10  Fujii Hironori  <Hironori.Fujii@sony.com>
1943
1944         [WinCairo] auto-installing raises exception "Inner message: global name 'urllib2' is not defined" since r250869
1945         https://bugs.webkit.org/show_bug.cgi?id=202839
1946
1947         Reviewed by Jonathan Bedard.
1948
1949         * Scripts/webkitpy/common/system/autoinstall.py:
1950         (AutoInstaller._download_to_stream): Replaced urllib2.urlopen with urlopen.
1951
1952 2019-10-10  Kenneth Russell  <kbr@chromium.org>
1953
1954         New html5lib requires newer version of six.py than that shipped in macOS 10.14.6
1955         https://bugs.webkit.org/show_bug.cgi?id=202830
1956
1957         Autoinstall six along with html5lib.
1958
1959         Reviewed by Jonathan Bedard.
1960
1961         * Scripts/webkitpy/thirdparty/__init__.py:
1962         (AutoinstallImportHook._install_mechanize):
1963         (AutoinstallImportHook._install_pytest):
1964
1965 2019-10-10  Jonathan Bedard  <jbedard@apple.com>
1966
1967         results.webkit.org: Sort out certificates on Catalina
1968         https://bugs.webkit.org/show_bug.cgi?id=202837
1969
1970         Unreviewed infrastructure repair.
1971
1972         This is a temporary strategy until we sort out our certificates on the newly
1973         deployed Catalina bots.
1974
1975         * Scripts/webkitpy/results/upload.py:
1976         (Upload.upload):
1977         (Upload.upload_archive):
1978         * Scripts/webkitpy/results/upload_unittest.py:
1979         (UploadTest.test_upload):
1980         (UploadTest.test_archive_upload):
1981
1982 2019-10-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1983
1984         W3C test importer breaks svg files.
1985         https://bugs.webkit.org/show_bug.cgi?id=202806
1986
1987         Reviewed by Jonathan Bedard.
1988
1989         The WebKit W3C importer tries to rewrite the xml/html/css files
1990         when importing the tests to rewrite paths and such.
1991
1992         The issue is that to decide if rewrite the file or not uses the
1993         mimetype and the current code was comparing for something like
1994         if "xml" in str(mimetype[0])
1995
1996         But svg files have mimetype "image/svg+xml" so the previous code
1997         was trying to rewrite svg files, breaking them.
1998
1999         This patches changes that code to only rewrite if the mimetype
2000         also contains the "application/" or "text/" string.
2001
2002         It also adds an info log (printed when verbose enabled) to tell
2003         that a file has been rewritten.
2004
2005         * Scripts/webkitpy/w3c/test_importer.py:
2006         (TestImporter.import_tests):
2007
2008 2019-10-10  Jonathan Bedard  <jbedard@apple.com>
2009
2010         results.webkit.org: Serve correct exit codes when aborting
2011         https://bugs.webkit.org/show_bug.cgi?id=202817
2012
2013         Rubber-stamped by Aakash Jain.
2014
2015         * resultsdbpy/resultsdbpy/view/view_routes.py:
2016         (ViewRoutes.error): Return exit code along with html string.
2017
2018 2019-10-10  Matt Lewis  <jlewis3@apple.com>
2019
2020         Emergency unittest fix for wkbuild.
2021
2022         Unreviewed test fix.
2023
2024         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
2025         (ShouldBuildTest):
2026
2027 2019-10-10  Aakash Jain  <aakash_jain@apple.com>
2028
2029         Updated new Catalina queues names as per new Buildbot naming scheme
2030         https://bugs.webkit.org/show_bug.cgi?id=202816
2031
2032         Reviewed by Jonathan Bedard.
2033
2034         * BuildSlaveSupport/build.webkit.org-config/config.json: Renamed builder name and removed spaces.
2035         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js: Ditto.
2036         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
2037
2038 2019-10-10  Matt Lewis  <jlewis3@apple.com>
2039
2040         Fixing build scheduling for Catalina queues.
2041         https://bugs.webkit.org/show_bug.cgi?id=202814
2042
2043         Reviewed by Aakash Jain.
2044
2045         * BuildSlaveSupport/build.webkit.org-config/config.json: Drive By fix of Trigger.
2046         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
2047         (_should_file_trigger_build):
2048
2049 2019-10-10  Sihui Liu  <sihui_liu@apple.com>
2050
2051         Add a unit test for StorageQuotaManager
2052         https://bugs.webkit.org/show_bug.cgi?id=202755
2053
2054         Reviewed by Youenn Fablet.
2055
2056         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2057         * TestWebKitAPI/Tests/WebCore/StorageQuotaManager.cpp: Added.
2058         (TestWebKitAPI::TEST):
2059
2060 2019-10-10  Wenson Hsieh  <wenson_hsieh@apple.com>
2061
2062         Support programmatic paste requests on macOS
2063         https://bugs.webkit.org/show_bug.cgi?id=202773
2064         <rdar://problem/48957166>
2065
2066         Reviewed by Tim Horton.
2067
2068         Adds new testing support to enable us to test programmatic paste requests on macOS.
2069
2070         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2071
2072         Add a few new UIScriptController methods:
2073         - activateAtPoint(x, y, callback): used to activate content underneath at (x, y), in root view coordinates
2074           (WKWebView on macOS, and WKContentView on iOS). On macOS, this moves the mouse to the given location and
2075           clicks.
2076         - chooseMenuAction(action, callback): used to select a menu item with the given title.
2077         - dismissMenu(): dismisses the platform menu.
2078
2079         Note that dismissMenu and chooseMenuAction currently only work for the DOM paste menu, but could be extended in
2080         the future to handle the system context menu.
2081
2082         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2083         (WTR::UIScriptController::dismissMenu):
2084         (WTR::UIScriptController::chooseMenuAction):
2085         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2086         (WTR::UIScriptController::activateAtPoint):
2087         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2088         (WTR::TestController::cocoaResetStateToConsistentValues):
2089         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2090         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2091         (-[TestRunnerWKWebView initWithFrame:configuration:]):
2092         (-[TestRunnerWKWebView _didShowMenu]):
2093         (-[TestRunnerWKWebView _didHideMenu]):
2094
2095         Make these present across both macOS and iOS. On macOS, we listen for NSMenuDidBeginTrackingNotification and
2096         NSMenuDidEndTrackingNotification to know when a menu has been shown or dismissed.
2097
2098         (-[TestRunnerWKWebView dismissActiveMenu]):
2099         (-[TestRunnerWKWebView resetInteractionCallbacks]):
2100
2101         Make these available on both iOS and macOS. The only interaction callbacks on macOS are currently
2102         didShowMenuCallback and didHideMenuCallback.
2103
2104         (-[TestRunnerWKWebView _willHideMenu]):
2105         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.h:
2106         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.mm:
2107         (WTR::UIScriptControllerCocoa::setDidShowMenuCallback):
2108         (WTR::UIScriptControllerCocoa::setDidHideMenuCallback):
2109         (WTR::UIScriptControllerCocoa::dismissMenu):
2110         (WTR::UIScriptControllerCocoa::isShowingMenu const):
2111
2112         Move these implementations into UIScriptControllerCocoa, from UIScriptControllerIOS.
2113
2114         * WebKitTestRunner/ios/TestControllerIOS.mm:
2115         (WTR::TestController::platformResetStateToConsistentValues):
2116
2117         Instead of clearing all interaction callbacks in TestControllerIOS, do it in TestControllerCocoa where it
2118         affects both macOS and iOS.
2119
2120         * WebKitTestRunner/ios/UIScriptControllerIOS.h:
2121         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2122         (WTR::UIScriptControllerIOS::activateAtPoint):
2123         (WTR::UIScriptControllerIOS::singleTapAtPointWithModifiers):
2124         (WTR::UIScriptControllerIOS::chooseMenuAction):
2125         (WTR::UIScriptControllerIOS::rectForMenuAction const):
2126         (WTR::UIScriptControllerIOS::setDidShowMenuCallback): Deleted.
2127         (WTR::UIScriptControllerIOS::setDidHideMenuCallback): Deleted.
2128         (WTR::UIScriptControllerIOS::isShowingMenu const): Deleted.
2129
2130         Abstract rectForMenuAction and singleTapAtPointWithModifiers out into private helper methods, such that they can
2131         be used from within other script controller methods.
2132
2133         * WebKitTestRunner/mac/UIScriptControllerMac.h:
2134         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2135
2136         Implement the new script controller hooks on macOS.
2137
2138         (WTR::UIScriptControllerMac::clearAllCallbacks):
2139         (WTR::UIScriptControllerMac::chooseMenuAction):
2140         (WTR::UIScriptControllerMac::activateAtPoint):
2141
2142 2019-10-10  Jonathan Bedard  <jbedard@apple.com>
2143
2144         results.webkit.org: Increase default limit for test results (Follow-up fix)
2145         https://bugs.webkit.org/show_bug.cgi?id=202757
2146
2147         Unreviewed follow-up fix.
2148
2149         * resultsdbpy/resultsdbpy/view/templates/commits.html: Switch default and maximum limits.
2150
2151 2019-10-10  Jonathan Bedard  <jbedard@apple.com>
2152
2153         results.webkit.org: Start reporting results
2154         https://bugs.webkit.org/show_bug.cgi?id=202639
2155
2156         Reviewed by Dewei Zhu.
2157
2158         * BuildSlaveSupport/build.webkit.org-config/loadConfig.py:
2159         (loadBuilderConfig): Load API key for results.webkit.org.
2160         * BuildSlaveSupport/build.webkit.org-config/make_passwords_json.py:
2161         (create_mock_slave_passwords_dict): Add mock for API key.
2162         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2163         (RunWebKitTests): Start reporting to results.webkit.org.
2164         (RunWebKitTests.__init__): Do not print the environment to hide the API key.
2165         (RunWebKitTests.start): Add the API key to the environment.
2166         (RunAPITests): Start reporting to results.webkit.org.
2167         (RunAPITests.__init__): Do not print the environment to hide the API key.
2168         (RunAPITests.start): Add the API key to the environment.
2169         (RunPythonTests): Start reporting to results.webkit.org.
2170         (RunPythonTests.__init__): Do not print the environment to hide the API key.
2171         (RunPythonTests.start): Add the API key to the environment.
2172         * Scripts/webkitpy/results/upload.py:
2173         (Upload):
2174         (Upload.upload): Add API_KEY, if it exists, to the request.
2175         (Upload.upload_archive): Ditto.
2176
2177 2019-10-09  Russell Epstein  <repstein@apple.com>
2178
2179         Unreviewed, rolling out r250930.
2180
2181         Broke watchOS Builds
2182
2183         Reverted changeset:
2184
2185         "Add support for CompactPointerTuple<..., OptionSet<...>>"
2186         https://bugs.webkit.org/show_bug.cgi?id=201316
2187         https://trac.webkit.org/changeset/250930
2188
2189 2019-10-09  Jiewen Tan  <jiewen_tan@apple.com>
2190
2191         [WebAuthn] Move the mock testing entrance to Internals
2192         https://bugs.webkit.org/show_bug.cgi?id=202560
2193         <rdar://problem/55973793>
2194
2195         Reviewed by Chris Dumez.
2196
2197         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2198         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2199         (WTR::TestRunner::setWebAuthenticationMockConfiguration): Deleted.
2200         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2201         * WebKitTestRunner/TestController.cpp:
2202         (WTR::TestController::setWebAuthenticationMockConfiguration): Deleted.
2203         * WebKitTestRunner/TestController.h:
2204         * WebKitTestRunner/TestInvocation.cpp:
2205         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2206
2207 2019-10-09  Daniel Bates  <dabates@apple.com>
2208
2209         Add support for CompactPointerTuple<..., OptionSet<...>>
2210         https://bugs.webkit.org/show_bug.cgi?id=201316
2211
2212         Reviewed by Yusuke Suzuki.
2213
2214         Add a test to ensure we encode and decode a compact pointer tuple correctly when an uint8_t and
2215         a OptionSet<> as the byte value portion of the tuple.
2216
2217         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2218         * TestWebKitAPI/Tests/WTF/CompactPointerTuple.cpp: Added.
2219         (TestWebKitAPI::TEST):
2220
2221 2019-10-09  Simon Fraser  <simon.fraser@apple.com>
2222
2223         Rename WheelEventTestTrigger and improve naming in related code
2224         https://bugs.webkit.org/show_bug.cgi?id=202772
2225
2226         Reviewed by Tim Horton.
2227
2228         Change the "test trigger" terminology to "monitor wheel events"; after all, tests
2229         call monitorWheelEvents() and callAfterScrollingCompletes(), and this is not triggering
2230         a test.
2231
2232         * DumpRenderTree/mac/DumpRenderTree.mm:
2233         (resetWebViewToConsistentStateBeforeTesting):
2234         * WebKitTestRunner/TestController.cpp:
2235         (WTR::TestController::resetStateToConsistentValues):
2236
2237 2019-10-09  Daniel Bates  <dabates@apple.com>
2238
2239         Add support for CompactPointerTuple<..., OptionSet<...>>
2240         https://bugs.webkit.org/show_bug.cgi?id=201316
2241
2242         Reviewed by Yusuke Suzuki.
2243
2244         Add a test to ensure we encode and decode a compact pointer tuple correctly when an uint8_t and
2245         a OptionSet<> as the byte value portion of the tuple.
2246
2247         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2248         * TestWebKitAPI/Tests/WTF/CompactPointerTuple.cpp: Added.
2249         (TestWebKitAPI::TEST):
2250
2251 2019-10-09  Jonathan Bedard  <jbedard@apple.com>
2252
2253         results.webkit.org: Increase default limit for test results
2254         https://bugs.webkit.org/show_bug.cgi?id=202757
2255
2256         Rubber-stamped by Aakash Jain.
2257
2258         * resultsdbpy/resultsdbpy/controller/suite_controller.py:
2259         (SuiteController): Increase DEFAULT_LIMIT.
2260         * resultsdbpy/resultsdbpy/controller/test_controller.py:
2261         (TestController): Ditto.
2262         * resultsdbpy/resultsdbpy/view/static/js/commit.js:
2263         (_CommitBank.prototype._load): Make commit shards larger.
2264         * resultsdbpy/resultsdbpy/view/static/js/drawer.js: Increase default slider size.
2265         * resultsdbpy/resultsdbpy/view/templates/commits.html: Keep smaller slider size.
2266
2267 2019-10-09  Dean Jackson  <dino@apple.com>
2268
2269         Provide an alternate command-line flag for timeout in run-webkit-tests
2270         https://bugs.webkit.org/show_bug.cgi?id=202758
2271         <rdar://problem/56124032>
2272
2273         Reviewed by Tim Horton.
2274
2275         I always get the flag "--time-out-ms" wrong.
2276         Everywhere else we use the single-word version of "timeout", including
2277         the documentation for --time-out-ms!
2278
2279         Add an alternate that is just "--timeout", and update the documentation
2280         to mention it is measured in milliseconds.
2281
2282         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2283         (parse_args):
2284
2285 2019-10-09  youenn fablet  <youenn@apple.com>
2286
2287         Remove testRunner.setWebRTCUnifiedPlanEnabled
2288         https://bugs.webkit.org/show_bug.cgi?id=202700
2289
2290         Reviewed by Eric Carlson.
2291
2292         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2293         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2294         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2295
2296 2019-10-09  Carlos Garcia Campos  <cgarcia@igalia.com>
2297
2298         REGRESSION(r250597): [GTK][WPE] 2.27.1 shows HTML content as text/plain in custom protocols when passing a charset in content type
2299         https://bugs.webkit.org/show_bug.cgi?id=202633
2300
2301         Reviewed by Žan Doberšek.
2302
2303         Add a test case.
2304
2305         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
2306         (testWebContextURIScheme):
2307
2308 2019-10-08  Jiewen Tan  <jiewen_tan@apple.com>
2309
2310         Partially undo r250811
2311         https://bugs.webkit.org/show_bug.cgi?id=202715
2312         <rdar://problem/56084287>
2313
2314         Reviewed by Chris Dumez.
2315
2316         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
2317         Modified to crash if SerializedScriptValue doesn't wrap CryptoKey objects.
2318
2319 2019-10-08  Jonathan Bedard  <jbedard@apple.com>
2320
2321         REGRESSION (r250375): [old EWS] JSC EWS is always marking Patches as success
2322         https://bugs.webkit.org/show_bug.cgi?id=202419
2323
2324         Rubber-stamped by Aakash Jain.
2325
2326         * Scripts/webkitpy/common/system/executive.py:
2327         (Executive._run_command_with_teed_output): Return exit code.
2328         * Scripts/webkitpy/common/system/executive_unittest.py:
2329         (ExecutiveTest.test_run_command_with_bad_command): Test that exceptions are raised
2330         For non-zero exit codes.
2331
2332 2019-10-08  Jonathan Bedard  <jbedard@apple.com>
2333
2334         Python 3: Add support to auto-importer
2335         https://bugs.webkit.org/show_bug.cgi?id=201955
2336
2337         Reviewed by Aakash Jain.
2338
2339         * Scripts/test-webkitpy-python3: Auto-install everything.
2340         * Scripts/webkitpy/common/system/autoinstall.py: Import urlopen and urlparse for Python3.
2341         * Scripts/webkitpy/thirdparty/__init__.py:
2342         (AutoinstallImportHook.find_module): Update function definition for Python3.
2343         (AutoinstallImportHook._install_mechanize): Use Python 2/3 compatible version of mechanize.
2344         (AutoinstallImportHook._install_requests): Update urllib3 and requests version.
2345         (AutoinstallImportHook._install_coverage): Use Python 2/3 compatible version of coverage.
2346         (AutoinstallImportHook.greater_than_equal_to_version): Use range instead of xrange.
2347         (AutoinstallImportHook._install_selenium): Update urllib3 version.
2348         (AutoinstallImportHook.install_chromedriver): 
2349         (AutoinstallImportHook.install_geckodriver):
2350         (AutoinstallImportHook.get_latest_pypi_url):
2351         (AutoinstallImportHook.install_binary):
2352         * Scripts/webkitpy/thirdparty/__init___unittest.py:
2353         (ThirdpartyTest):
2354         (ThirdpartyTest.test_import_hook): Deleted.
2355
2356 2019-10-08  Yury Semikhatsky  <yurys@chromium.org>
2357
2358         Restore my committer status.
2359
2360         Uneviewed.
2361
2362         * Scripts/webkitpy/common/config/contributors.json:
2363
2364 2019-10-08  Kate Cheney  <katherine_cheney@apple.com>
2365
2366         Implement Telemetry and Dumping Routines for SQLite backend (195088)
2367         https://bugs.webkit.org/show_bug.cgi?id=195088
2368         <rdar://problem/54213407>
2369
2370         Reviewed by John Wilander.
2371
2372         Updated the current testing for telemetry which only tested 3
2373         statistics. With this patch it now tests 10 statistics.
2374         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2375         (WTR::InjectedBundle::didReceiveMessageToPage):
2376         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2377         (WTR::TestRunner::statisticsDidRunTelemetryCallback):
2378         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2379
2380 2019-10-08  Timothy Hatcher  <timothy@apple.com>
2381
2382         Copying white text from dark mode WebKit apps and pasting in a light mode app results in white (invisible) text.
2383         https://bugs.webkit.org/show_bug.cgi?id=202662
2384         rdar://problem/48677354
2385
2386         Reviewed by Megan Gardner.
2387
2388         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2389         * TestWebKitAPI/Tests/WebKitCocoa/CopyRTF.mm: Added.
2390         (readRTFDataFromPasteboard):
2391         (copyAttributedStringFromHTML):
2392         (checkColor):
2393         (TEST):
2394
2395 2019-10-08  Brady Eidson  <beidson@apple.com>
2396
2397         Service Worker Fetch events should time out.
2398         https://bugs.webkit.org/show_bug.cgi?id=202188
2399
2400         Reviewed by Alex Christensen.
2401
2402         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2403         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2404         (WTR::TestRunner::setServiceWorkerFetchTimeout):
2405         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2406         * WebKitTestRunner/TestController.cpp:
2407         (WTR::TestController::resetStateToConsistentValues):
2408         (WTR::TestController::setServiceWorkerFetchTimeoutForTesting):
2409         * WebKitTestRunner/TestController.h:
2410         * WebKitTestRunner/TestInvocation.cpp:
2411         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2412
2413 2019-10-08  Matt Lewis  <jlewis3@apple.com>
2414
2415         Unreviewed, rolling out r250784.
2416
2417         Broke running layout tests.
2418
2419         Reverted changeset:
2420
2421         "results.webkit.org: Start reporting results"
2422         https://bugs.webkit.org/show_bug.cgi?id=202639
2423         https://trac.webkit.org/changeset/250784
2424
2425 2019-10-08  Matt Lewis  <jlewis3@apple.com>
2426
2427         Make iPhone simulators pass --iPhone-simulator instead of --iOS
2428         https://bugs.webkit.org/show_bug.cgi?id=202701
2429
2430         Reviewed by Aakash Jain.
2431
2432         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2433         (appendCustomTestingFlags):
2434
2435 2019-10-08  Aakash Jain  <aakash_jain@apple.com>
2436
2437         [ews-build] Do not print worker environment variables in each build step [part 3]
2438         https://bugs.webkit.org/show_bug.cgi?id=202698
2439
2440         Reviewed by Jonathan Bedard.
2441
2442         * BuildSlaveSupport/ews-build/steps.py:
2443         (RunJavaScriptCoreTests.__init__): Disabled logging of environment variables.
2444         (ExtractTestResults.__init__): Ditto.
2445         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
2446
2447 2019-10-08  Matt Lewis  <jlewis3@apple.com>
2448
2449         Fixing the triggerable templates in the config for catalina.
2450         https://bugs.webkit.org/show_bug.cgi?id=202652
2451
2452         Reviewed by Jonathan Bedard.
2453
2454         * BuildSlaveSupport/build.webkit.org-config/config.json:
2455
2456 2019-10-07  Ryosuke Niwa  <rniwa@webkit.org>
2457
2458         Add IDL for requestIdleCallback
2459         https://bugs.webkit.org/show_bug.cgi?id=202653
2460
2461         Reviewed by Geoffrey Garen.
2462
2463         * DumpRenderTree/TestOptions.cpp:
2464         (TestOptions::TestOptions):
2465         * DumpRenderTree/TestOptions.h:
2466         * DumpRenderTree/mac/DumpRenderTree.mm:
2467         (setWebPreferencesForTestOptions):
2468
2469 2019-10-07  Jiewen Tan  <jiewen_tan@apple.com>
2470
2471         Only wrapping CryptoKeys for IDB during serialization
2472         https://bugs.webkit.org/show_bug.cgi?id=202500
2473         <rdar://problem/52445927>
2474
2475         Reviewed by Chris Dumez.
2476
2477         Modifies IndexedDB.StructuredCloneBackwardCompatibility test to include CryptoKeys.
2478
2479         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBStructuredCloneBackwardCompatibility.mm:
2480         (-[StructuredCloneBackwardCompatibilityNavigationDelegate _webCryptoMasterKeyForWebView:]):
2481         (TEST):
2482         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3:
2483         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3-shm:
2484         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3-wal:
2485         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBStructuredCloneBackwardCompatibilityRead.html:
2486         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBStructuredCloneBackwardCompatibilityWrite.html:
2487
2488 2019-10-07  Dean Jackson  <dino@apple.com>
2489
2490         Various filter-build-webkit updates
2491         https://bugs.webkit.org/show_bug.cgi?id=202558
2492
2493         Reviewed by Tim Horton.
2494
2495         Add rules for:
2496         - RuleScriptExecution
2497         - tapi
2498         - plutil
2499         - A postprocessing ANGLE script
2500         - "Prepare build"
2501         - Signing Identity
2502
2503         * Scripts/filter-build-webkit:
2504
2505 2019-10-07  Saam Barati  <sbarati@apple.com>
2506
2507         Allow OSR exit to the LLInt
2508         https://bugs.webkit.org/show_bug.cgi?id=197993
2509
2510         Reviewed by Tadeu Zagallo.
2511
2512         * Scripts/run-jsc-stress-tests:
2513
2514 2019-10-07  Kate Cheney  <katherine_cheney@apple.com>
2515
2516         Domain relationships in the ITP Database should be inserted in a single query and ignore repeat insert attempts. (202604)
2517         https://bugs.webkit.org/show_bug.cgi?id=202604
2518         <rdar://problem/55995831>
2519
2520         Reviewed by Chris Dumez. 
2521
2522         Updates to testing infrastructure to test successful list-merging of
2523         top domains into the ITP SQLite database and test against repeat
2524         inserts.
2525         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2526         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2527         (WTR::TestRunner::setStatisticsMergeStatistic):
2528         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
2529         (WTR::TestRunner::isStatisticsOnlyInDatabaseOnce):
2530         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2531         * WebKitTestRunner/TestController.cpp:
2532         (WTR::TestController::setStatisticsMergeStatistic):
2533         (WTR::TestController::isStatisticsOnlyInDatabaseOnce):
2534         * WebKitTestRunner/TestController.h:
2535         * WebKitTestRunner/TestInvocation.cpp:
2536         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2537
2538 2019-10-07  Matt Lewis  <jlewis3@apple.com>
2539
2540         Bring up queues for Catalina
2541         https://bugs.webkit.org/show_bug.cgi?id=202652
2542
2543         Reviewed by Jonathan Bedard.
2544
2545         * BuildSlaveSupport/build.webkit.org-config/config.json:
2546         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2547         (WebKitBuildbot):
2548         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2549
2550 2019-10-07  Antoine Quint  <graouts@apple.com>
2551
2552         Crash in WebKitTestRunnerApp: invocation function for block in WTR::UIScriptControllerIOS::sendEventStream
2553         https://bugs.webkit.org/show_bug.cgi?id=202646
2554         <rdar://problem/54576522>
2555
2556         Reviewed by Tim Horton.
2557
2558         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2559         (WTR::UIScriptControllerIOS::sendEventStream):
2560
2561 2019-10-07  Jonathan Bedard  <jbedard@apple.com>
2562
2563         results.webkit.org: Start reporting results
2564         https://bugs.webkit.org/show_bug.cgi?id=202639
2565
2566         Reviewed by Dewei Zhu.
2567
2568         * BuildSlaveSupport/build.webkit.org-config/loadConfig.py:
2569         (loadBuilderConfig): Load API key for results.webkit.org.
2570         * BuildSlaveSupport/build.webkit.org-config/make_passwords_json.py:
2571         (create_mock_slave_passwords_dict): Add mock for API key.
2572         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2573         (RunWebKitTests): Start reporting to results.webkit.org.
2574         (RunWebKitTests.__init__): Do not print the environment to hide the API key.
2575         (RunWebKitTests.start): Add the API key to the environment.
2576         (RunAPITests): Start reporting to results.webkit.org.
2577         (RunAPITests.__init__): Do not print the environment to hide the API key.
2578         (RunAPITests.start): Add the API key to the environment.
2579         (RunPythonTests): Start reporting to results.webkit.org.
2580         (RunPythonTests.__init__): Do not print the environment to hide the API key.
2581         (RunPythonTests.start): Add the API key to the environment.
2582         * Scripts/webkitpy/results/upload.py:
2583         (Upload):
2584         (Upload.upload): Add API_KEY, if it exists, to the request.
2585         (Upload.upload_archive): Ditto.
2586
2587 2019-10-07  Matt Lewis  <jlewis3@apple.com>
2588
2589         Unreviewed, rolling out r250750.
2590
2591         Reverting change as this broke interal test over the weekend.
2592
2593         Reverted changeset:
2594
2595         "Allow OSR exit to the LLInt"
2596         https://bugs.webkit.org/show_bug.cgi?id=197993
2597         https://trac.webkit.org/changeset/250750
2598
2599 2019-10-07  youenn fablet  <youenn@apple.com>
2600
2601         [iOS] Unmuting capture of a page is not working
2602         https://bugs.webkit.org/show_bug.cgi?id=202627
2603
2604         Reviewed by Eric Carlson.
2605
2606         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2607         * TestWebKitAPI/Tests/WebKit/GetUserMedia.mm: Added.
2608         (-[GetUserMediaCaptureUIDelegate _webView:requestMediaCaptureAuthorization:decisionHandler:]):
2609         (-[GetUserMediaCaptureUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
2610         (-[GetUserMediaTestView haveStream:]):
2611         (TestWebKitAPI::waitUntilCaptureState):
2612         (TestWebKitAPI::TEST):
2613         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
2614
2615 2019-10-07  Philippe Normand  <pnormand@igalia.com>
2616
2617         [GStreamer][JHBuild] Update to 1.16.1
2618         https://bugs.webkit.org/show_bug.cgi?id=202619
2619
2620         Reviewed by Žan Doberšek.
2621
2622         * flatpak/org.webkit.CommonModules.yaml:
2623         * gstreamer/jhbuild.modules:
2624         * gstreamer/patches/gst-plugins-bad-do-not-retry-downloads-during-shutdown.patch: Removed.
2625         * gstreamer/patches/gst-plugins-good-glibc-2.30-compat.patch: Removed.
2626         * gstreamer/patches/gst-plugins-good-scaletempo-Advertise-interleaved-layout-in-caps-temp.patch: Removed.
2627
2628 2019-10-04  Saam Barati  <sbarati@apple.com>
2629
2630         Allow OSR exit to the LLInt
2631         https://bugs.webkit.org/show_bug.cgi?id=197993
2632
2633         Reviewed by Tadeu Zagallo.
2634
2635         * Scripts/run-jsc-stress-tests:
2636
2637 2019-10-04  Matt Lewis  <jlewis3@apple.com>
2638
2639         Fix iPad testers platform for downloading build product and fixing tests to run
2640         https://bugs.webkit.org/show_bug.cgi?id=202365
2641
2642         Reviewed by Jonathan Bedard.
2643
2644         * BuildSlaveSupport/build.webkit.org-config/config.json: Added device_model.
2645         * BuildSlaveSupport/build.webkit.org-config/factories.py: Added device_model property.
2646         (Factory.__init__):
2647         (BuildFactory.__init__):
2648         (TestFactory.__init__):
2649         (BuildAndTestFactory.__init__):
2650         (BuildAndTestLLINTCLoopFactory.__init__):
2651         (BuildAndTest32bitJSCFactory.__init__):
2652         (BuildAndRemoteJSCTestsFactory.__init__):
2653         (TestWebKit1LeaksFactory.__init__):
2654         (TestJSCFactory.__init__):
2655         (Test262Factory.__init__):
2656         (BuildAndPerfTestFactory.__init__):
2657         (DownloadAndPerfTestFactory.__init__):
2658         * BuildSlaveSupport/build.webkit.org-config/loadConfig.py: Added device_model to loaded properties.
2659         (loadBuilderConfig):
2660         * BuildSlaveSupport/build.webkit.org-config/steps.py: Added ability to run based on device_model to
2661         WebKit Tests and API tests for iPad and iPhone simulators.
2662         (ConfigureBuild.__init__):
2663         (ConfigureBuild.start):
2664         (appendCustomTestingFlags):
2665         (RunWebKitTests.start):
2666         (RunAPITests.start):
2667
2668 2019-10-04  Jonathan Bedard  <jbedard@apple.com>
2669
2670         results.webkit.org: Remove percentages from bubbles
2671         https://bugs.webkit.org/show_bug.cgi?id=202591
2672
2673         Rubber-stamped by Aakash Jain.
2674
2675         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
2676         (inPlaceCombine): Add 'worst' key to combined results.
2677         (TimelineFromEndpoint.constructor): Use the 'worst' key to populate the tag
2678         instead of a percentage.
2679
2680 2019-10-04  Aakash Jain  <aakash_jain@apple.com>
2681
2682         [EWS] Assign webkit-misc to various queues
2683         https://bugs.webkit.org/show_bug.cgi?id=202584
2684
2685         Reviewed by Jonathan Bedard.
2686
2687         * BuildSlaveSupport/ews-build/config.json:
2688
2689 2019-10-03  Aakash Jain  <aakash_jain@apple.com>
2690
2691         [ews] wincairo queue should use del instead of rm command (follow-up fix)
2692         https://bugs.webkit.org/show_bug.cgi?id=202477
2693
2694         Reviewed by Jonathan Bedard.
2695
2696         * BuildSlaveSupport/ews-build/steps.py:
2697         (CleanUpGitIndexLock.start): Use regular 'rm' command on windows as it use cygwin.
2698         * BuildSlaveSupport/ews-build/steps_unittest.py:
2699         (TestCleanUpGitIndexLock.test_success_windows): Added unit-test for windows.
2700
2701 2019-10-04  Jiewen Tan  <jiewen_tan@apple.com>
2702
2703         [WebAuthn] Implement _WKWebAuthenticationPanel SPI
2704         https://bugs.webkit.org/show_bug.cgi?id=202559
2705         <rdar://problem/55932094>
2706
2707         Reviewed by Brent Fulgham.
2708
2709         This patch adds a very limited test case to _WKWebAuthenticationPanel.
2710         Bug 202560 and Bug 202565 will follow up to write more tests.
2711
2712         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2713         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm: Added.
2714         (-[TestWebAuthenticationPanelDelegate panel:dismissWebAuthenticationPanelWithResult:]):
2715         (-[TestWebAuthenticationPanelUIDelegate webView:runWebAuthenticationPanel:initiatedByFrame:completionHandler:]):
2716         (TestWebKitAPI::TEST):
2717         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion.html: Added.
2718         * WebKitTestRunner/TestController.cpp:
2719         (WTR::runWebAuthenticationPanel):
2720         (WTR::TestController::createWebViewWithOptions):
2721
2722 2019-10-04  Alex Christensen  <achristensen@webkit.org>
2723
2724         Move WKProcessPool._registerURLSchemeServiceWorkersCanHandle to _WKWebsiteDataStoreConfiguration
2725         https://bugs.webkit.org/show_bug.cgi?id=202553
2726
2727         Reviewed by Youenn Fablet.
2728
2729         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2730         * TestWebKitAPI/Tests/WebKitCocoa/StorageQuota.mm:
2731
2732 2019-10-04  Alex Christensen  <achristensen@webkit.org>
2733
2734         Simplify sandbox enabling macros
2735         https://bugs.webkit.org/show_bug.cgi?id=202536
2736
2737         Reviewed by Brent Fulgham.
2738
2739         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2740
2741 2019-10-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2742
2743         [GTK][WPE] Print the revision number on command "--version" of the MiniBrowser
2744         https://bugs.webkit.org/show_bug.cgi?id=202581
2745
2746         Reviewed by Carlos Garcia Campos.
2747
2748         When WebKit its build from source repository instead of a tarball
2749         we can print the SVN revision to be more precise about the version
2750         of WebKit when the option --version is passed to the MiniBrowser.
2751
2752         * MiniBrowser/gtk/main.c:
2753         (main):
2754         * MiniBrowser/wpe/main.cpp:
2755         (main):
2756
2757 2019-10-04  Carlos Garcia Campos  <cgarcia@igalia.com>
2758
2759         Unreviewed. Fix GTK distcheck
2760
2761         * gtk/manifest.txt.in: Add Source/WebKit/Resources/gtk to the tarball.
2762
2763 2019-10-03  Per Arne Vollan  <pvollan@apple.com>
2764
2765         REGRESSION(249649): Unable to open local files in MiniBrowser on macOS
2766         https://bugs.webkit.org/show_bug.cgi?id=201798
2767
2768         Reviewed by Brent Fulgham.
2769
2770         Added API test WKWebView.LoadFileWithLoadRequest.
2771
2772         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm:
2773
2774 2019-10-03  Jonathan Bedard  <jbedard@apple.com>
2775
2776         Add myself to various tools watchlists
2777         https://bugs.webkit.org/show_bug.cgi?id=202532
2778
2779         Reviewed by Aakash Jain.
2780
2781         * Scripts/webkitpy/common/config/watchlist: Add myself to the watchlist of
2782         PerformanceTests, SVNScripts, webkitperl and webkitpy.
2783
2784 2019-10-03  Jiewen Tan  <jiewen_tan@apple.com>
2785
2786         Support googleLegacyAppidSupport extension
2787         https://bugs.webkit.org/show_bug.cgi?id=202427
2788         <rdar://problem/55887473>
2789
2790         Reviewed by Brent Fulgham.
2791
2792         Adds an API test for googleLegacyAppidSupport extension.
2793
2794         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2795         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
2796         (TestWebKitAPI::constructMakeCredentialRequest):
2797         (TestWebKitAPI::constructMakeCredentialRequestWithGoogleLegacyAppidSupport):
2798         (TestWebKitAPI::TEST):
2799
2800 2019-10-03  Thibault Saunier  <tsaunier@igalia.com>
2801
2802         REGRESSION(r249428): [GStreamer] VP9 video rendered green
2803         https://bugs.webkit.org/show_bug.cgi?id=201422
2804
2805         Adding patches in -base to fix the issue.
2806
2807         Reviewed by Philippe Normand.
2808
2809         * gstreamer/jhbuild.modules:
2810         * gstreamer/patches/base-0001-glupload-Add-VideoMetas-and-GLSyncMeta-to-the-raw-up.patch: Added.
2811
2812 2019-10-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2813
2814         [GTK] Make PSON optional
2815         https://bugs.webkit.org/show_bug.cgi?id=200967
2816
2817         Reviewed by Michael Catanzaro.
2818
2819         Enable PSON in MiniBrowser and unit tests. Also add more tests to page-id to check that we can still talk to the
2820         right web process after cross-site history navigation.
2821
2822         * MiniBrowser/gtk/main.c:
2823         (main):
2824         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
2825         (testWebExtensionPageID):
2826         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2827         (Test::Test):
2828
2829 2019-10-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2830
2831         [GTK][WPE] Add WebKitWebView:page-id property
2832         https://bugs.webkit.org/show_bug.cgi?id=201642
2833
2834         Reviewed by Michael Catanzaro.
2835
2836         Add a test case to check the new property.
2837
2838         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
2839         (checkTitle):
2840         (testWebExtensionGetTitle):
2841         (webViewPageIDChanged):
2842         (testWebExtensionPageID):
2843         (beforeAll):
2844
2845 2019-10-02  Jonathan Bedard  <jbedard@apple.com>
2846
2847         results.webkit.org: Only automatically search when multiple lines are pasted
2848         https://bugs.webkit.org/show_bug.cgi?id=202496
2849
2850         Rubber-stamped by Aakash Jain.
2851
2852         * resultsdbpy/resultsdbpy/view/static/js/search.js:
2853         (SearchBar): If only a single line has been pasted, do not automatically dispatch
2854         the search.
2855
2856 2019-10-02  Jonathan Bedard  <jbedard@apple.com>
2857
2858         Python 3: Add test-webkitpy for Python 3 (Follow-up fix)
2859         https://bugs.webkit.org/show_bug.cgi?id=201954
2860
2861         Unreviewed follow-up fix.
2862
2863         * Scripts/test-webkitpy-python3: Add copyright.
2864
2865 2019-10-02  Thibault Saunier  <tsaunier@igalia.com>
2866
2867         [GSTreamer] Let playbin handle redirects for us when appropriate
2868         https://bugs.webkit.org/show_bug.cgi?id=195326
2869
2870         Added required patche in GStreamer
2871
2872         Reviewed by Xabier Rodriguez-Calvar.
2873
2874         * gstreamer/patches/base-0001-playbin-Handle-error-message-with-redirection-indica.patch: Added.
2875         * gstreamer/patches/good-0001-qtdemux-Specify-REDIRECT-information-in-error-messag.patch: Added.
2876
2877 2019-10-01  Aakash Jain  <aakash_jain@apple.com>
2878
2879         [ews] Add API endpoint to retry failed builds for a patch
2880         https://bugs.webkit.org/show_bug.cgi?id=202424
2881
2882         Reviewed by Jonathan Bedard.
2883
2884         * BuildSlaveSupport/ews-app/ews/urls.py: Added url mapping for /retry.
2885         * BuildSlaveSupport/ews-app/ews/views/retrypatch.py: Added.
2886         (RetryPatch.get): Display the web-form to retry the patch. Retry button which will be added soon will 
2887         use this form.
2888         (RetryPatch.post): Handle the post request and retry the patch.
2889         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2890         (StatusBubble.find_failed_builds_for_patch): Method to find failed builds for a patch.
2891         * BuildSlaveSupport/ews-app/ews/templates/retry.html: Added, similar to submittoews.html. This
2892         allows to retry a patch through a web-form as well.
2893
2894 2019-10-02  Kate Cheney  <katherine_cheney@apple.com>
2895
2896         Updated resource load statistics are never merged into the SQLite Database backend (202372).
2897         https://bugs.webkit.org/show_bug.cgi?id=202372
2898         <rdar://problem/55854542>
2899
2900         Reviewed by Brent Fulgham. 
2901
2902         Added testing functionality to the mergeStatistics() function of the 
2903         SQLite backend.
2904
2905         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2906         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2907         (WTR::InjectedBundle::didReceiveMessageToPage):
2908         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2909         (WTR::TestRunner::setStatisticsMergeStatistic):
2910         (WTR::TestRunner::statisticsCallDidSetMergeStatisticCallback):
2911         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2912         * WebKitTestRunner/TestController.cpp:
2913         (WTR::TestController::setStatisticsMergeStatistic):
2914         * WebKitTestRunner/TestController.h:
2915         * WebKitTestRunner/TestInvocation.cpp:
2916         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2917         (WTR::TestInvocation::didMergeStatistic):
2918         * WebKitTestRunner/TestInvocation.h:
2919
2920 2019-10-02  Aakash Jain  <aakash_jain@apple.com>
2921
2922         [ews] windows or wincairo queue should use del instead of rm command
2923         https://bugs.webkit.org/show_bug.cgi?id=202477
2924
2925         Reviewed by Jonathan Bedard.
2926
2927         * BuildSlaveSupport/ews-build/steps.py:
2928         (CleanUpGitIndexLock.start): Use 'del' command instead of rm for windows and wincairo.
2929         * BuildSlaveSupport/ews-build/steps_unittest.py:
2930         (TestCleanUpGitIndexLock.test_success_wincairo): Added unit-test.
2931
2932 2019-10-02  youenn fablet  <youenn@apple.com>
2933
2934         Add a test to check the case of launching two service worker processes shortly one after the other
2935         https://bugs.webkit.org/show_bug.cgi?id=202450
2936
2937         Reviewed by Chris Dumez.
2938
2939         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2940
2941 2019-10-02  Aakash Jain  <aakash_jain@apple.com>
2942
2943         [ews] Dedicate a bot for macOS-High-Sierra-Debug-Build-EWS queue
2944         https://bugs.webkit.org/show_bug.cgi?id=202469
2945
2946         Reviewed by Jonathan Bedard.
2947
2948         * BuildSlaveSupport/ews-build/config.json: Dedicate ews112 to macOS debug builder queue.
2949
2950 2019-10-01  Jonathan Bedard  <jbedard@apple.com>
2951
2952         Python 3: Add test-webkitpy for Python 3
2953         https://bugs.webkit.org/show_bug.cgi?id=201954
2954
2955         Reviewed by Aakash Jain.
2956
2957         * Scripts/test-webkitpy-python3: Added.
2958
2959 2019-10-02  Carlos Garcia Campos  <cgarcia@igalia.com>
2960
2961         [GTK][WPE] Stop using legacy custom protocol implementation
2962         https://bugs.webkit.org/show_bug.cgi?id=202407
2963
2964         Reviewed by Žan Doberšek.
2965
2966         Remove the tests to check failure after committed, because it's not possible to test it with current code.
2967
2968         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
2969         (testWebContextURIScheme):
2970
2971 2019-10-01  Alexey Shvayka  <shvaikalesh@gmail.com>
2972
2973         [win-ews] No such file or directory: u'/cygdrive/C/cygwin/home/buildbot/WebKit/WebKitBuild/Release/bin32/layout-test-results/pywebsocket.ws.log-out.txt'
2974         https://bugs.webkit.org/show_bug.cgi?id=188640
2975
2976         Reviewed by Alex Christensen.
2977
2978         1. Properly shutdown WebSocket server so that port 8880 is released.
2979         2. Prevent failure of WebSocket tests when launched in freshly cloned repository.
2980
2981         * Scripts/new-run-webkit-websocketserver:
2982         (main): Tweak import and use class constants of PyWebSocket directly.
2983         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
2984         (PyWebSocket._prepare_config): Create test output directory if it doesn't exist.
2985
2986 2019-10-01  Alex Christensen  <achristensen@webkit.org>
2987
2988         Progress towards a functioning CMake build on Mac
2989         https://bugs.webkit.org/show_bug.cgi?id=202443
2990
2991         Rubber-stamped by Tim Horton.
2992
2993         * DumpRenderTree/PlatformMac.cmake:
2994         * MiniBrowser/mac/CMakeLists.txt:
2995         * TestRunnerShared/cocoa/ClassMethodSwizzler.mm:
2996         * TestWebKitAPI/CMakeLists.txt:
2997         * TestWebKitAPI/PlatformMac.cmake:
2998         * WebKitTestRunner/PlatformMac.cmake:
2999
3000 2019-10-01  John Wilander  <wilander@apple.com>
3001
3002         Storage Access API: document.hasStorageAccess() should return true when the cookie policy allows access
3003         https://bugs.webkit.org/show_bug.cgi?id=202435
3004         <rdar://problem/55718526>
3005
3006         Reviewed by Brent Fulgham.
3007
3008         This change makes sure topPrivatelyControlledDomain() correctly handles domains
3009         with leading dots, as often used in cookie domains.
3010
3011         * TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp:
3012         (TestWebKitAPI::TEST_F):
3013
3014 2019-10-01  Jonathan Bedard  <jbedard@apple.com>
3015
3016         results.webkit.org: Standardize styles in the drawer
3017         https://bugs.webkit.org/show_bug.cgi?id=202428
3018
3019         Rubber-stamped by Aakash Jain.
3020
3021         * resultsdbpy/resultsdbpy/view/static/css/search.css: Rename boldInverseColor.
3022         * resultsdbpy/resultsdbpy/view/static/css/tooltip.css: Ditto.
3023         * resultsdbpy/resultsdbpy/view/static/js/drawer.js: Move style specifications into webkit.css.
3024         * resultsdbpy/resultsdbpy/view/static/js/timeline.js: Ditto.
3025         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
3026         (.input>label): Use the boldInverseColor instead of grey.
3027         (.input>input[type="text"][required], .input>input[type="number"][required],): Darken the border,
3028         decrease the font weight.
3029         (.input>input[type="text"][required]~label, .input>input[type="number"][required]~label,): Use the inverseColor instead of grey.
3030
3031 2019-10-01  Antti Koivisto  <antti@apple.com>
3032
3033         [CSS Shadow Parts] Parse 'part' attribute
3034         https://bugs.webkit.org/show_bug.cgi?id=202409
3035
3036         Reviewed by Ryosuke Niwa.
3037
3038         * DumpRenderTree/mac/DumpRenderTree.mm:
3039         (enableExperimentalFeatures):
3040
3041 2019-10-01  Aakash Jain  <aakash_jain@apple.com>
3042
3043         Follow-up fix to r250572 to fix a typo.
3044         [ews] Add method to retry a build using Buildbot API
3045         https://bugs.webkit.org/show_bug.cgi?id=202408
3046
3047         Unreviewed follow-up fix.
3048
3049         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
3050
3051 2019-10-01  Aakash Jain  <aakash_jain@apple.com>
3052
3053         [ews] Add method to retry a build using Buildbot API
3054         https://bugs.webkit.org/show_bug.cgi?id=202408
3055
3056         Reviewed by Jonathan Bedard.
3057
3058         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
3059         (Buildbot.retry_build): Method to retry given build using Buildbot API.
3060
3061 2019-10-01  David Kilzer  <ddkilzer@apple.com>
3062
3063         clang-tidy: Fix unnecessary copying/ref churn of for loop variables in Tools
3064         <https://webkit.org/b/202387>
3065
3066         Reviewed by Darin Adler.
3067
3068         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3069         (WTR::TestController::setAllowedMenuActions): Make loop variable
3070         a reference to fix unnecessary copying/ref churn.
3071
3072 2019-10-01  Nikolas Zimmermann  <nzimmermann@igalia.com>
3073
3074         Update my affiliation - since today I work for Igalia.
3075
3076         Unreviewed.
3077
3078         * Scripts/webkitpy/common/config/contributors.json:
3079
3080 2019-10-01  Keith Miller  <keith_miller@apple.com>
3081
3082         Add support for the Wasm multi-value proposal
3083         https://bugs.webkit.org/show_bug.cgi?id=202250
3084
3085         Reviewed by Saam Barati.
3086
3087         * Scripts/run-jsc-stress-tests:
3088
3089 2019-10-01  youenn fablet  <youenn@apple.com>
3090
3091         Remove races condition when validating capture sandbox extension revocation
3092         https://bugs.webkit.org/show_bug.cgi?id=202133
3093         <rdar://problem/55660905>
3094
3095         Reviewed by Eric Carlson.
3096
3097         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3098         Updated test to not use page cache so that on going back, the page is reloaded and will call getUserMedia again.
3099
3100 2019-09-30  Alex Christensen  <achristensen@webkit.org>
3101
3102         Resurrect Mac CMake build
3103         https://bugs.webkit.org/show_bug.cgi?id=202384
3104
3105         Rubber-stamped by Tim Horton.
3106
3107         * DumpRenderTree/PlatformMac.cmake:
3108         * TestWebKitAPI/PlatformMac.cmake:
3109
3110 2019-09-30  Zhifei Fang  <zhifei_fang@apple.com>
3111
3112         [results.webkit.org Timeline] New axis style
3113         https://bugs.webkit.org/show_bug.cgi?id=202292
3114
3115         Reviewed by Jonathan Bedard.
3116
3117         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
3118
3119 2019-09-30  Alex Christensen  <achristensen@webkit.org>
3120
3121         Move DownloadMonitor test speed multiplier from WebProcessPool to WebsiteDataStoreConfiguration
3122         https://bugs.webkit.org/show_bug.cgi?id=202339
3123
3124         Reviewed by Youenn Fablet.
3125
3126         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3127         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
3128
3129 2019-09-30  Carlos Garcia Campos  <cgarcia@igalia.com>
3130
3131         [GTK] IconDatabase is not thread-safe
3132         https://bugs.webkit.org/show_bug.cgi?id=201303
3133
3134         Reviewed by Žan Doberšek.
3135
3136         Rewrite the WebKitFaviconDatabase tests, splitting tests cases again and making them independent to each other.
3137
3138         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
3139         (testFaviconDatabaseInitialization):
3140         (testFaviconDatabaseGetFavicon):
3141         (ephemeralViewFaviconChanged):
3142         (testFaviconDatabaseEphemeral):
3143         (testFaviconDatabaseClear):
3144         (beforeAll):
3145         (afterAll):
3146         * TestWebKitAPI/glib/TestExpectations.json: TestWebKitFaviconDatabase shouls always pass now.
3147
3148 2019-09-30  Carlos Garcia Campos  <cgarcia@igalia.com>
3149
3150         [GTK][WPE] Add about:gpu
3151         https://bugs.webkit.org/show_bug.cgi?id=202305
3152
3153         Reviewed by Žan Doberšek.
3154
3155         Allow to use about:gpu in MiniBrowser. Add a script to get the current svn revision.
3156
3157         * MiniBrowser/gtk/BrowserTab.c:
3158         (getInternalURI):
3159         * MiniBrowser/gtk/main.c:
3160         (argumentToURL):
3161         * MiniBrowser/wpe/main.cpp:
3162         (main):
3163         * glib/svn-revision: Added.
3164
3165 2019-09-27  Andres Gonzalez  <andresg_22@apple.com>
3166
3167         Support accessibility for <figure> element on iOS.
3168         https://bugs.webkit.org/show_bug.cgi?id=202272
3169         <rdar://problem/54789907>
3170
3171         Reviewed by Chris Fleizach.
3172
3173         Implemented titleUIElement and roleDescription properties for <figure> elements on iOS.
3174         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3175         (WTR::AccessibilityUIElement::titleUIElement):
3176         (WTR::AccessibilityUIElement::roleDescription):
3177
3178 2019-09-27  Alex Christensen  <achristensen@webkit.org>
3179
3180         Move shouldUseTestingNetworkSession from NetworkProcessCreationParameters to NetworkSessionCreationParameters
3181         https://bugs.webkit.org/show_bug.cgi?id=202327
3182
3183         Reviewed by Tim Horton.
3184
3185         * WebKitTestRunner/TestController.cpp:
3186         (WTR::TestController::websiteDataStore):
3187
3188 2019-09-27  Alex Christensen  <achristensen@webkit.org>
3189
3190         Move service worker process termination delay disabling from process pool to website data store
3191         https://bugs.webkit.org/show_bug.cgi?id=202308
3192
3193         Reviewed by Chris Dumez.
3194
3195         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3196
3197 2019-09-27  Alex Christensen  <achristensen@webkit.org>
3198
3199         Remove unused WebProcessPool::setCanHandleHTTPSServerTrustEvaluation
3200         https://bugs.webkit.org/show_bug.cgi?id=202285
3201
3202         Reviewed by Youenn Fablet.
3203
3204         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
3205         (-[ServerTrustDelegate webView:didFinishNavigation:]):
3206         (-[ServerTrustDelegate webView:didFailProvisionalNavigation:withError:]):
3207         (-[ServerTrustDelegate waitForDidFinishNavigation]):
3208         (-[ServerTrustDelegate waitForDidFailProvisionalNavigationError]):
3209         (-[ServerTrustDelegate authenticationChallengeCount]):
3210         (-[ServerTrustDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
3211         (TestWebKitAPI::TEST):
3212         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3213         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3214         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation): Deleted.
3215         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess): Deleted.
3216         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount): Deleted.
3217         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3218         * WebKitTestRunner/TestController.cpp:
3219         (WTR::TestController::resetStateToConsistentValues):
3220         (WTR::TestController::didReceiveAuthenticationChallenge):
3221         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const): Deleted.
3222         * WebKitTestRunner/TestController.h:
3223         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const): Deleted.
3224         * WebKitTestRunner/TestInvocation.cpp:
3225         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3226         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3227         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const): Deleted.
3228
3229 2019-09-27  Alex Christensen  <achristensen@webkit.org>
3230
3231         Remove unused APIProcessPoolConfiguration::diskCacheSpeculativeValidationEnabled
3232         https://bugs.webkit.org/show_bug.cgi?id=202290
3233
3234         Reviewed by Carlos Garcia Campos.
3235
3236         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
3237         (TEST):
3238         * WebKitTestRunner/TestController.cpp:
3239         (WTR::TestController::websiteDataStore):
3240         (WTR::TestController::generatePageConfiguration):
3241
3242 2019-09-27  Youenn Fablet  <youenn@apple.com>
3243
3244         Make IsNSURLSessionWebSocketEnabled an experimental flag
3245         https://bugs.webkit.org/show_bug.cgi?id=202135
3246         <rdar://problem/55694721>
3247
3248         Reviewed by Geoff Garen.
3249
3250         * WebKitTestRunner/TestController.cpp:
3251         (WTR::TestController::resetPreferencesToConsistentValues):
3252         Set preference to false by default.
3253
3254 2019-09-27  Jiewen Tan  <jiewen_tan@apple.com>
3255
3256         SubFrameSOAuthorizationSession should ensure messages are posted in the right order to the parent frame
3257         https://bugs.webkit.org/show_bug.cgi?id=202061
3258         <rdar://problem/55485666>
3259
3260         Reviewed by Youenn Fablet.
3261
3262         Adds tests that check the order of messages posted by SubFrameSOAuthorizationSession.
3263
3264         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
3265         (-[TestSOAuthorizationScriptMessageHandler userContentController:didReceiveScriptMessage:]):
3266         (resetState):
3267         (TestWebKitAPI::TEST):
3268
3269 2019-09-26 Kate Cheney <katherine_cheney@apple.com>
3270
3271         Resource Load Statistics: Downgrade all third-party referrer headers
3272         https://bugs.webkit.org/show_bug.cgi?id=201353
3273         <rdar://problem/54895650>
3274
3275         Majority of this patch was written by John Wilander <wilander@apple.com>.
3276
3277         Reviewed by Brent Fulgham. 
3278
3279         The changes to the TestRunner facilitates an opt-out for test cases
3280         that either test the referrer mechanism explicitly or tests that
3281         rely on the full referrer to be sent. 
3282
3283         The new boolean variable and early return in 
3284         TestRunner::setStatisticsShouldDowngradeReferrer() prevent the same
3285         event from trying to set multiple TestRunner callbacks.
3286
3287         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3288         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3289         (WTR::InjectedBundle::didReceiveMessageToPage):
3290         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3291         (WTR::TestRunner::setStatisticsShouldDowngradeReferrer):
3292         (WTR::TestRunner::statisticsCallDidSetShouldDowngradeReferrerCallback):
3293         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3294         * WebKitTestRunner/TestController.cpp:
3295         (WTR::TestController::setStatisticsShouldDowngradeReferrer):
3296         * WebKitTestRunner/TestController.h:
3297         * WebKitTestRunner/TestInvocation.cpp:
3298         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3299         (WTR::TestInvocation::didSetShouldDowngradeReferrer):
3300         * WebKitTestRunner/TestInvocation.h:
3301
3302 2019-09-26  Dean Jackson  <dino@apple.com>
3303
3304         Build fix.
3305
3306         * TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm:
3307         (-[TestContextMenuImageWithoutConfigurationUIDelegate webView:contextMenuConfigurationForElement:completionHandler:]): Deleted.
3308         (-[TestContextMenuImageWithoutConfigurationUIDelegate webView:contextMenuWillPresentForElement:]): Deleted.
3309         (-[TestContextMenuImageWithoutConfigurationUIDelegate webView:contextMenuForElement:willCommitWithAnimator:]): Deleted.
3310         (-[TestContextMenuImageWithoutConfigurationUIDelegate webView:contextMenuDidEndForElement:]): Deleted.
3311
3312 2019-09-26  Dean Jackson  <dino@apple.com>
3313
3314         ContextMenu on a link in an email no longer shows web preview
3315         https://bugs.webkit.org/show_bug.cgi?id=201120
3316         <rdar://54353617>
3317
3318         Reviewed by Wenson Hsieh.
3319
3320         Test context menus on a link that is also an image.
3321
3322         * TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm:
3323         (contextMenuWebViewDriver):
3324         (-[TestContextMenuImageWithoutConfigurationUIDelegate webView:contextMenuConfigurationForElement:completionHandler:]):
3325         (-[TestContextMenuImageWithoutConfigurationUIDelegate webView:contextMenuWillPresentForElement:]):
3326         (-[TestContextMenuImageWithoutConfigurationUIDelegate webView:contextMenuForElement:willCommitWithAnimator:]):
3327         (-[TestContextMenuImageWithoutConfigurationUIDelegate webView:contextMenuDidEndForElement:]):
3328         (TEST):
3329
3330 2019-09-26  Frederic Wang  <fwang@igalia.com>
3331
3332         run-safari --ios-simulator is no longer working with Xcode 11
3333         https://bugs.webkit.org/show_bug.cgi?id=199852
3334
3335         Path of MobileSafari.app has changed in Xcode 11. This patch updates
3336         the run-safari script to use the new path. This removes support for
3337         running Safari on iOS < 13, see discussions on bug 177595.
3338
3339         Reviewed by Jonathan Bedard.
3340
3341         * Scripts/webkitdirs.pm:
3342         (iosSimulatorApplicationsPath):
3343
3344 2019-09-26  Zhifei Fang  <zhifei_fang@apple.com>
3345
3346         [results.webkit.org] Timeline support Image inner label
3347         https://bugs.webkit.org/show_bug.cgi?id=202180
3348
3349         Reviewed by Jonathan Bedard.
3350
3351         * resultsdbpy/resultsdbpy/view/static/js/expectations.js:
3352         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
3353         (.lengend>.item .dot img): support img symbol for lengend and dot
3354         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
3355         (Timeline.CanvasSeriesComponent): Support user pass a Image object or a image url as inner label
3356
3357 2019-09-26  Chris Dumez  <cdumez@apple.com>
3358
3359         Stop using testRunner.overridePreference() to turn on Page Cache
3360         https://bugs.webkit.org/show_bug.cgi?id=202274
3361
3362         Reviewed by Alex Christensen.
3363
3364         * DumpRenderTree/TestRunner.cpp:
3365         (overridePreferenceCallback):
3366         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3367         (WTR::TestRunner::overridePreference):
3368
3369 2019-09-26  Jonathan Bedard  <jbedard@apple.com>
3370
3371         results.webkit.org: Use cursor: pointer for clickable elements
3372         https://bugs.webkit.org/show_bug.cgi?id=202268
3373
3374         Rubber-stamped by Aakash Jain.
3375
3376         * resultsdbpy/resultsdbpy/view/static/js/drawer.js: Give collapse button a pointer for cursor.
3377         * resultsdbpy/resultsdbpy/view/templates/search.html: Make 'X' to close test timeline a link-button.
3378
3379 2019-09-26  Kate Cheney  <katherine_cheney@apple.com>
3380
3381         Enable LayoutTests using ResourceLoadStatistics SQLite backend (195420) 
3382         https://bugs.webkit.org/show_bug.cgi?id=195420                          
3383         <rdar://problem/54213551>                                               
3384
3385         Reviewed by Brent Fulgham.                                             
3386
3387         Added in logic to send a message from the UIProcess to the Network      
3388         Process which will initalize the ITP Database backend to allow for      
3389         layout testing.                                                         
3390         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3391         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3392         (WTR::TestRunner::setUseITPDatabase):
3393         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3394         * WebKitTestRunner/TestController.cpp:
3395         (WTR::TestController::setUseITPDatabase):
3396         * WebKitTestRunner/TestController.h:
3397         * WebKitTestRunner/TestInvocation.cpp:
3398         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3399
3400 2019-09-26  Wenson Hsieh  <wenson_hsieh@apple.com>
3401
3402         TestWebKitAPI.WebKit.ReloadWithDifferingInitialScale is failing consistently
3403         https://bugs.webkit.org/show_bug.cgi?id=202273
3404
3405         Reviewed by Aakash Jain.
3406
3407         The content width scaling limits added in r250361 prevent this test from scaling down the content width (2000px
3408         wide) to fit the viewport (375px). To avoid this issue, change the content width from 2000px to 1500px, which is
3409         still a very wide content width for a web page.
3410
3411         * TestWebKitAPI/Tests/WebKitCocoa/ReloadWithDifferingInitialScale.mm:
3412
3413 2019-09-26  Alexey Shvayka  <shvaikalesh@gmail.com>
3414
3415         toExponential, toFixed, and toPrecision should allow arguments up to 100
3416         https://bugs.webkit.org/show_bug.cgi?id=199163
3417
3418         Reviewed by Ross Kirsling.
3419
3420         Adjust StringNumberFixedWidth test due to lowering kMaxFixedDigitsBeforePoint.
3421
3422         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
3423
3424 2019-09-26  Jiewen Tan  <jiewen_tan@apple.com>
3425
3426         TestWebKitAPI.SOAuthorizationSubFrame.AuthorizationOptions is failing consistently on iOS API tests EWS
3427         https://bugs.webkit.org/show_bug.cgi?id=202249
3428
3429         Reviewed by Alex Christensen.
3430
3431         Swizzles +[AKAuthorizationController isURLFromAppleOwnedDomain:] following other tests.
3432
3433         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
3434         (TestWebKitAPI::TEST):
3435
3436 2019-09-25  Alex Christensen  <achristensen@webkit.org>
3437
3438         Add replacement SPI on _WKWebsiteDataStoreConfiguration for enabling speculative cache validation and IPC-free server trust evaluation
3439         https://bugs.webkit.org/show_bug.cgi?id=202251
3440
3441         Reviewed by Tim Horton.
3442
3443         Adopt new SPI instead of deprecated SPI.
3444
3445         * MiniBrowser/mac/AppDelegate.m:
3446         (persistentDataStore):
3447         (defaultConfiguration):
3448         (-[BrowserAppDelegate fetchDefaultStoreWebsiteData:]):
3449         (-[BrowserAppDelegate fetchAndClearDefaultStoreWebsiteData:]):
3450         (-[BrowserAppDelegate clearDefaultStoreWebsiteData:]):
3451
3452 2019-09-25  Jonathan Bedard  <jbedard@apple.com>
3453
3454         Python 3: Add support in webkitpy.common.system
3455         https://bugs.webkit.org/show_bug.cgi?id=201826
3456         <rdar://problem/55452671>
3457
3458         Reviewed by Stephanie Lewis.
3459
3460         Tested compatibility by running 'python3 -m unittest webkitpy.common.system.<_unittest>' on
3461         each of the effected files.
3462
3463         * Scripts/webkitpy/common/checkout/changelog.py: Import StringIO from io module.
3464         (set_reviewer):
3465         (set_short_description_and_bug_url):
3466         * Scripts/webkitpy/common/checkout/checkout.py:  Import StringIO from io module.
3467         (Checkout._latest_entry_for_changelog_at_revision):
3468         * Scripts/webkitpy/common/config/committers.py:
3469         (CommitterList.load_json): iteritems -> items.
3470         * Scripts/webkitpy/common/net/networktransaction.py:
3471         (NetworkTransaction.run): urllib2 is urllib in Python3. 
3472         * Scripts/webkitpy/common/system/abstractexecutive.py:
3473         (AbstractExecutive._stringify_args):
3474         (AbstractExecutive.command_for_printing): The str type is unicode in Python3.
3475         * Scripts/webkitpy/common/system/crashlogs_unittest.py: Explicitly encode and decode binary crashlogs.
3476         * Scripts/webkitpy/common/system/environment_unittest.py: Use absolute imports.
3477         * Scripts/webkitpy/common/system/executive.py:
3478         (ScriptError.message_with_output): The str type is unicode in Python3.
3479         (Executive.WrappedPopen): Python3's Popen object is a context manager. To allow us to use it as one,
3480         our Python2 Popen needs to be one as well.
3481         (Executive.WrappedPopen.__init__):
3482         (Executive.WrappedPopen.__enter__):
3483         (Executive.WrappedPopen.__exit__):
3484         (Executive._run_command_with_teed_output): Simplify loop, decode unicode strings.
3485         (Executive.run_and_throw_if_fail): The child output file should not be unicode strings.
3486         (Executive.running_pids): Use the Popen context manager to guarantee clean-up.
3487         (Executive._compute_stdin):
3488         (Executive.run_command): Use the Popen context manager to guarantee clean-up.
3489         (Executive._stringify_args): The str type is unicode in Python3.
3490         (Executive.popen): Return a context manager if the Popen object is not one.
3491         * Scripts/webkitpy/common/system/executive_mock.py:
3492         (MockProcess.__init__): StringIO -> BytesIO.
3493         (MockProcess.__enter__):
3494         (MockProcess):
3495         (MockProcess.__exit__):
3496         * Scripts/webkitpy/common/system/executive_unittest.py:
3497         (ExecutiveTest.test_auto_stringify_args): Use the Popen context manager to guarantee clean-up.
3498         (ExecutiveTest.test_popen_args): Ditto.
3499         (ExecutiveTest.serial_test_kill_process): Ditto.
3500         (ExecutiveTest.serial_test_kill_all): Ditto.
3501         * Scripts/webkitpy/common/system/filesystem.py:
3502         (FileSystem.read_binary_file): Use 'open' instead of 'file'.
3503         (FileSystem.write_binary_file): Ditto.
3504         (FileSystem.write_text_file): The str type is unicode in Python3. 
3505         (FileSystem.relpath):
3506         (FileSystem.remove): The WindowsError is just anther OSError in Python3.
3507         (FileSystem._WindowsError): Deleted.
3508         * Scripts/webkitpy/common/system/filesystem_mock.py:
3509         (MockFileSystem.glob): filter returns a generator instead of a list.
3510         (WritableBinaryFileObject.__init__): Binary files are comprised of bytes, not string in Python3.
3511         (WritableBinaryFileObject.write): Ditto.
3512         (ReadableTextFileObject.__init__): Ditto.
3513         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
3514         (MockFileSystemTest.test_normpath):
3515         (MockFileSystemTest.test_dirs_under): assertEquals -> assertEqual.
3516         * Scripts/webkitpy/common/system/filesystem_unittest.py:
3517         (RealFileSystemTest.test_read_and_write_file): Explicitly define byte arrays instead of strings.
3518         (RealFileSystemTest.test_remove_file_with_retry.remove_with_exception): The WindowsError is just
3519         anther OSError in Python3.
3520         * Scripts/webkitpy/common/system/outputcapture.py:
3521         * Scripts/webkitpy/common/system/outputtee_unittest.py:
3522         (SimpleTeeTest.test_simple_tee):
3523         * Scripts/webkitpy/common/system/path.py:
3524         (_escape): urllib library has been broken into parts.
3525         * Scripts/webkitpy/common/system/pemfile.py:
3526         (_parse_pem_format.find_end): Python3 does not define a maxint.
3527         * Scripts/webkitpy/common/system/pemfile_unittest.py:
3528         * Scripts/webkitpy/common/system/platforminfo.py:
3529         (PlatformInfo.total_bytes_memory): Not 'long' type in Python3.
3530         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
3531         (TestPlatformInfo.test_real_code): assertNotEquals -> assertNotEqual.
3532         (TestPlatformInfo.test_display_name): Ditto.
3533         * Scripts/webkitpy/common/system/profiler.py:
3534         (ProfilerFactory.create_profiler): Manually implement ifilter.
3535         * Scripts/webkitpy/common/system/profiler_unittest.py: Use absolute imports.
3536         * Scripts/webkitpy/common/system/stack_utils_unittest.py:
3537         (current_thread_id): items() returns a generator in Python3.
3538         * Scripts/webkitpy/common/system/systemhost.py: Use absolute imports.
3539         * Scripts/webkitpy/common/system/urlfetcher.py: Removed.
3540         * Scripts/webkitpy/common/system/urlfetcher_mock.py: Removed.
3541         * Scripts/webkitpy/common/system/user.py:
3542         (User.prompt): Use absolute imports, raw_input -> input.
3543         (User.prompt_with_multiple_lists):
3544         (User.prompt_with_list):
3545         (User.confirm):
3546         * Scripts/webkitpy/common/unicode.py: Tooling to manage compatibility between Python 2
3547         and Python 3 unicode handling.
3548         * Scripts/webkitpy/common/system/user_mock.py:
3549         (MockUser.prompt): raw_input -> input.
3550         (MockUser.prompt_with_list): Ditto.
3551         * Scripts/webkitpy/common/version.py:
3552         (Version.from_iterable): xrange -> range.
3553         (Version.from_name): Use absolute import path.
3554         (Version.__contains__): xrange -> range.
3555         (Version.__str__): xrange -> range.
3556         (Version.__cmp__): amp is no longer an operator in Python3, but versions are comprised
3557         Of integers, so subtraction has the same effect.
3558         (Version):
3559         (Version.__eq__): __cmp__ operator is no longer respected, so we need to implement
3560         each comparison.
3561         (Version.__ne__): Ditto.
3562         (Version.__lt__): Ditto.
3563         (Version.__le__): Ditto.
3564         (Version.__gt__): Ditto.
3565         (Version.__ge__): Ditto.
3566         * Scripts/webkitpy/common/version_name_map.py:
3567         (VersionNameMap._automap_to_major_version):
3568         (VersionNameMap.to_name): xrange -> range.
3569         (VersionNameMap.from_name): iteritems -> items.
3570         * Scripts/webkitpy/common/version_name_map_unittest.py: Use absolute imports.
3571         * Scripts/webkitpy/common/version_unittest.py: Ditto.
3572         * Scripts/webkitpy/common/wavediff.py:
3573         (WaveDiff.__init__): StringIO -> BytesIO.
3574         * Scripts/webkitpy/port/__init__.py:
3575         (outside):
3576
3577 2019-09-25  Aakash Jain  <aakash_jain@apple.com>
3578
3579         [EWS] RunJavaScriptCoreTestsToT should use the same command as RunJavaScriptCoreTests
3580         https://bugs.webkit.org/show_bug.cgi?id=202216
3581
3582         Reviewed by Jonathan Bedard.
3583
3584         * BuildSlaveSupport/ews-build/steps.py:
3585         (RunJavaScriptCoreTestsToT): Removed the command so as to use the command from base class.
3586         * BuildSlaveSupport/ews-build/steps_unittest.py: Updatd unit-tests.
3587
3588 2019-09-25  Aakash Jain  <aakash_jain@apple.com>
3589
3590         [ews] JSC queues should run or skip tests based on runTests key from config.json
3591         https://bugs.webkit.org/show_bug.cgi?id=202223
3592
3593         Reviewed by Jonathan Bedard.
3594
3595         * BuildSlaveSupport/ews-build/config.json: Added the runTests key.
3596         * BuildSlaveSupport/ews-build/factories.py:
3597         (JSCTestsFactory.__init__): Add RunJavaScriptCoreTests step based on runTests key.
3598         * BuildSlaveSupport/ews-build/loadConfig.py:
3599         (loadBuilderConfig): Pass the runTests key to the factory.
3600         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
3601         (ConfigDotJSONTest.test_builder_keys): Added the runTests key.
3602
3603 2019-09-25  Jonathan Bedard  <jbedard@apple.com>
3604
3605         results.webkit.org: Add investigation drawer
3606         https://bugs.webkit.org/show_bug.cgi?id=202106
3607
3608         Reviewed by Dewei Zhu.
3609
3610         * resultsdbpy/resultsdbpy/view/static/js/drawer.js: Support multiple 'main' classes.
3611         * resultsdbpy/resultsdbpy/view/static/js/expectations.js: Added.
3612         (Expectations.colorMap): Return a dictionary mapping type strings to colors.
3613         (Expectations.stringToStateId): Map a string to a state ID for sorting.
3614         (Expectations.typeForId): Return a type string given an ID.
3615         (Expectations.symbolForId): Return a symbol for a type given an ID.
3616         (Expectations.colorForId): Return a color given an ID.
3617         (Expectations.unexpectedResults): Given a list of actual results and expected results,
3618         return a state.
3619         (Expectations):
3620         * resultsdbpy/resultsdbpy/view/static/js/investigate.js: Added.
3621         (commitsForUuid):
3622         (testRunLink):
3623         (elapsed):
3624         (percentage):
3625         (contentForAgregateData):
3626         (contentForData):
3627         (_InvestigateDrawer):
3628         (_InvestigateDrawer.prototype.isRendered):
3629         (_InvestigateDrawer.prototype.expand): Expand the investigation drawer.
3630         (_InvestigateDrawer.prototype.collapse): Collapse the investigation drawer.