[WebAuthN] Support CTAP HID authenticators on macOS
[WebKit-https.git] / Tools / ChangeLog
1 2018-11-13  Jiewen Tan  <jiewen_tan@apple.com>
2
3         [WebAuthN] Support CTAP HID authenticators on macOS
4         https://bugs.webkit.org/show_bug.cgi?id=188623
5         <rdar://problem/43353777>
6
7         Reviewed by Brent Fulgham and Chris Dumez.
8
9         This patch adds support for the mock testing and entitlements to allow minibrowser to talk
10         to hid devices.
11
12         * MiniBrowser/MiniBrowser.entitlements:
13         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
14         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
15
16 2018-11-13  Ryosuke Niwa  <rniwa@webkit.org>
17
18         WebKit.GeolocationTransitionToLowAccuracy API crashes when enabling PSON
19         https://bugs.webkit.org/show_bug.cgi?id=191616
20
21         Reviewed by Chris Dumez.
22
23         The crash was caused by WKView in autorelease pool invoking stopUpdatingCallback after
24         GeolocationTransitionToLowAccuracyStateTracker in the stack had been destroyed,
25         resulting in the use-after-free.
26
27         Made the tests more robust by clearing geolocation provider before exiting each test
28         since we can't really prevent WKView from entering an autorelease pool.
29
30         Also made WebKit.GeolocationTransitionToLowAccuracy wait for the success callback
31         instead of simply the end of the navigation so that the test would continue to work
32         even if a web content process was created for the second web view (lowAccuracyWebView)
33
34         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
35         (TestWebKitAPI::setupGeolocationProvider): Moved "*" to match the WebKit coding style guideline.
36         (TestWebKitAPI::clearGeolocationProvider): Added.
37         (TestWebKitAPI::runJavaScriptAlert): Added.
38         (TestWebKitAPI::didFinishNavigation): Deleted.
39         * TestWebKitAPI/Tests/WebKit/geolocationWatchPosition.html:
40
41 2018-11-13  Chris Dumez  <cdumez@apple.com>
42
43         WKProcessPool.InitialWarmedProcessUsed API is failing with PSON enabled
44         https://bugs.webkit.org/show_bug.cgi?id=191618
45
46         Reviewed by Ryosuke Niwa.
47
48         Update API test to explicitly disable automatic process prewarning since it is testing
49         manual prewarming.
50
51         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
52         (TEST):
53
54 2018-11-13  Chris Dumez  <cdumez@apple.com>
55
56         Several Service Worker API tests are failing when enabling PSON
57         https://bugs.webkit.org/show_bug.cgi?id=191619
58
59         Reviewed by Youenn Fablet.
60
61         Update tests to use _webProcessCountIgnoringPrewarmed instead of _webProcessCount so that they are
62         not impacted by process prewarming.
63
64         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
65
66 2018-11-13  Wenson Hsieh  <wenson_hsieh@apple.com>
67
68         [iOS] Do not show selection UI for editable elements with opacity near zero
69         https://bugs.webkit.org/show_bug.cgi?id=191442
70         <rdar://problem/45958625>
71
72         Reviewed by Simon Fraser.
73
74         Add a couple of new testing helpers to UIScriptController.
75
76         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
77         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
78         (WTR::UIScriptController::textSelectionRangeRects const):
79         (WTR::UIScriptController::selectionCaretViewRect const):
80         (WTR::UIScriptController::selectionRangeViewRects const):
81         * TestRunnerShared/UIScriptContext/UIScriptController.h:
82         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
83         (WTR::UIScriptController::textSelectionRangeRects const):
84
85         Rename `selectionRangeViewRects` to `textSelectionRangeRects`. This allows us to draw a distinction between
86         `textSelectionRangeRects`/`textSelectionCaretRect`, which retrieve information about selection rects known
87         to the text interaction assistant, and `selectionCaretViewRect`/`selectionRangeViewRects`, which retrieve the
88         actual frames of the selection views used to draw overlaid selection UI. This difference is important in the
89         new layout tests added in this patch, which only suppress caret rendering (i.e. selection views remain hidden).
90
91         Also, drive-by fix a leaked `NSMutableArray`.
92
93         (WTR::UIScriptController::selectionStartGrabberViewRect const):
94         (WTR::UIScriptController::selectionEndGrabberViewRect const):
95         (WTR::UIScriptController::selectionCaretViewRect const):
96         (WTR::UIScriptController::selectionRangeViewRects const):
97
98         Testing helpers to grab the frames of caret and selection views, in WKContentView's coordinate space. These
99         rects are also clamped to WKContentView bounds.
100
101 2018-11-13  Daniel Bates  <dabates@apple.com>
102
103         Consolidate WebKit UIKitSPI.h and UIKitTestSPI.h
104         https://bugs.webkit.org/show_bug.cgi?id=173341
105         <rdar://problem/32752890>
106
107         Reviewed by Simon Fraser.
108
109         There is little value to making a distinction between forward declarations
110         of UIKit SPI needed in the WebKit layer and just for testing. Moreover,
111         the contents of these two headers can conflict with each other following
112         r218275 as DumpRenderTree includes both headers. Instead we should remove
113         UIKitTestSPI.h and have WebKitTestRunner include the WebKit variant, UIKitSPI.h.
114
115         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
116         * DumpRenderTree/mac/DumpRenderTree.mm:
117         * TestRunnerShared/spi/UIKitTestSPI.h: Removed.
118         * WebKitTestRunner/Configurations/Base.xcconfig:
119         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
120         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
121         * WebKitTestRunner/ios/GeneratedTouchesDebugWindow.mm:
122         * WebKitTestRunner/ios/HIDEventGenerator.h:
123         * WebKitTestRunner/ios/HIDEventGenerator.mm:
124         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
125         * WebKitTestRunner/ios/TestControllerIOS.mm:
126         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
127         * WebKitTestRunner/ios/mainIOS.mm:
128
129 2018-11-13  Takashi Komori  <Takashi.Komori@sony.com>
130
131         Remove WebKitTestRunnerLib's build warnings.
132         https://bugs.webkit.org/show_bug.cgi?id=191580
133
134         Reviewed by Fujii Hironori.
135
136         Include cmakeconfig.h in precompiled header.
137
138         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
139
140 2018-11-12  Darshan Kadu  <darsh7807@gmail.com>
141
142         Implement Cache API support for WPE/GTK
143         https://bugs.webkit.org/show_bug.cgi?id=178316
144
145         Reviewed by Michael Catanzaro.
146
147         Called WKWebsiteDataStoreSetCacheStoragePerOriginQuota function to set the cache limit to 400 * 1200
148         on all the platforms in TestController.cpp. Also, removed the setCacheStoragePerOriginQuota call from TestControllerCocoa.mm
149
150         * WebKitTestRunner/TestController.cpp:
151         (WTR::TestController::generatePageConfiguration):
152         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
153         (WTR::initializeWebViewConfiguration):
154
155 2018-11-12  Christopher Reid  <chris.reid@sony.com>
156
157         [Curl] Reject entire cookie if the domain fails a tailmatch.
158         https://bugs.webkit.org/show_bug.cgi?id=191406
159
160         Reviewed by Youenn Fablet.
161
162         Added unittests for Curl cookie implementation.
163
164         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
165         (TestWebKitAPI::Curl::CurlCookies::RejectTailmatchFailureDomain):
166
167 2018-11-12  Alex Christensen  <achristensen@webkit.org>
168
169         [iOS] Implement safe browsing in WebKit
170         https://bugs.webkit.org/show_bug.cgi?id=191441
171
172         Reviewed by Tim Horton.
173
174         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
175         (checkTitleAndClick):
176         (TEST):
177
178 2018-11-12  Basuke Suzuki  <basuke.suzuki@sony.com>
179
180         [Curl] Add API Test for Curl cookie backend.
181         https://bugs.webkit.org/show_bug.cgi?id=191493
182
183         Reviewed by Youenn Fablet.
184
185         Add unit test to TestWebCore.
186
187         * TestWebKitAPI/PlatformWin.cmake:
188         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp: Added.
189
190 2018-11-12  Tim Horton  <timothy_horton@apple.com>
191
192         Make it possible to edit images inline
193         https://bugs.webkit.org/show_bug.cgi?id=191352
194         <rdar://problem/30107985>
195
196         Reviewed by Dean Jackson.
197
198         * WebKitTestRunner/TestController.cpp:
199         (WTR::updateTestOptionsFromTestHeader):
200         * WebKitTestRunner/TestOptions.h:
201         (WTR::TestOptions::hasSameInitializationOptions const):
202         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
203         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
204         (WTR::TestController::platformCreateWebView):
205         Add a test option to enable editable images.
206
207         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
208         (WTR::UIScriptController::drawSquareInEditableImage):
209         (WTR::UIScriptController::numberOfStrokesInEditableImage):
210         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
211         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
212         (WTR::UIScriptController::drawSquareInEditableImage):
213         (WTR::UIScriptController::numberOfStrokesInEditableImage):
214         * TestRunnerShared/UIScriptContext/UIScriptController.h:
215         * TestRunnerShared/spi/PencilKitTestSPI.h: Added.
216         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
217         (WTR::findEditableImageCanvas):
218         (WTR::UIScriptController::drawSquareInEditableImage):
219         (WTR::UIScriptController::numberOfStrokesInEditableImage):
220         Add the ability to draw on a PKCanvasView that is a subview of the WKWebView,
221         and also to retrieve the number of strokes currently on the PKCanvasView.
222         Currently this just takes the first canvas; we might need to make it
223         take an identifier or something in the future if we need tests with multiple
224         canvases. The indirect testing mechanism is required because PKCanvasView
225         can currently not actually paint its strokes in the Simulator.
226
227 2018-11-12  Ryan Haddad  <ryanhaddad@apple.com>
228
229         [MediaStream] Screen capture should be an experimental feature on OSX only
230         https://bugs.webkit.org/show_bug.cgi?id=191552
231
232         Unreviewed test gardening.
233
234         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm: Only run these tests on macOS.
235
236 2018-11-12  Don Olmstead  <don.olmstead@sony.com>
237
238         Shipped PNGs include bad profiles: iCCP: known incorrect sRGB profile
239         https://bugs.webkit.org/show_bug.cgi?id=189230
240         <rdar://problem/44050379>
241
242         Reviewed by Joseph Pecoraro.
243
244         Runs all png images through zopflipng. This results in a smaller file
245         size and takes care of this issue as a byproduct.
246
247         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-green.png:
248         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-red.png:
249         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/ElCapitan.png:
250         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/ElCapitan@2x.png:
251         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/GTK.png:
252         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/GTK@2x.png:
253         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/HighSierra.png:
254         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/HighSierra@2x.png:
255         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10.png:
256         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10@2x.png:
257         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10Simulator.png:
258         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10Simulator@2x.png:
259         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11.png:
260         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11@2x.png:
261         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11Simulator.png:
262         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11Simulator@2x.png:
263         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS12.png:
264         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS12@2x.png:
265         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS12Simulator.png:
266         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS12Simulator@2x.png:
267         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9.png:
268         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9@2x.png:
269         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9Simulator.png:
270         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9Simulator@2x.png:
271         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice.png:
272         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice@2x.png:
273         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSSimulator.png:
274         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSSimulator@2x.png:
275         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mavericks.png:
276         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mavericks@2x.png:
277         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mojave.png:
278         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mojave@2x.png:
279         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion.png:
280         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion@2x.png:
281         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/PlatformRing.png:
282         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/PlatformRing@2x.png:
283         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
284         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png:
285         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE.png:
286         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE@2x.png:
287         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows10.png:
288         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows10@2x.png:
289         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows7.png:
290         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows7@2x.png:
291         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows8.png:
292         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows8@2x.png:
293         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WindowsXP.png:
294         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WindowsXP@2x.png:
295         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Yosemite.png:
296         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Yosemite@2x.png:
297
298 2018-11-12  Tim Horton  <timothy_horton@apple.com>
299
300         Modernize WebKit Tools Xcode projects for localization's sake
301         https://bugs.webkit.org/show_bug.cgi?id=191495
302
303         Reviewed by Alexey Proskuryakov.
304
305         * ContentExtensionTester/ContentExtensionTester.xcodeproj/project.pbxproj:
306         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
307         * EditingHistory/EditingHistory.xcodeproj/project.pbxproj:
308         * FontWithFeatures/FontWithFeatures.xcodeproj/project.pbxproj:
309         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
310         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
311         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
312         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
313         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
314         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
315         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
316         * lldb/lldbWebKitTester/lldbWebKitTester.xcodeproj/project.pbxproj:
317         These are less important because they're not localized, but since
318         I made the style checker complain, it now complains any time anyone
319         touches any of these projects... so upgrade them.
320
321 2018-11-12  Jonathan Bedard  <jbedard@apple.com>
322
323         webkitpy: Check for specific process instead of using data migrator
324         https://bugs.webkit.org/show_bug.cgi?id=191551
325         <rdar://problem/45993156>
326
327         Rubber-stamped by Aakash Jain.
328
329         It's possible for the data migrator process to be stuck, but for a simulator to be
330         usable. Use device-specific processes to detect when a device is usable.
331
332         * Scripts/webkitpy/xcode/simulated_device.py:
333         (SimulatedDeviceManager._wait_until_device_is_usable):
334         (SimulatedDeviceManager):
335         (SimulatedDeviceManager.initialize_devices): Explicitly wait until a device is usable
336         since this implies that a device is booted.
337         (SimulatedDeviceManager.swap): Ditto.
338         (SimulatedDevice.is_usable): Check that a device is booted and that a device-specific
339         process indicating the device is usable can be found.
340         (SimulatedDeviceManager.wait_until_data_migration_is_done): Deleted.
341         * Scripts/webkitpy/xcode/simulated_device_unittest.py: Update simctl_json so that
342         it triggers the logic in is_usable()
343
344 2018-11-12  Takashi Komori  <Takashi.Komori@sony.com>
345
346         Resurrect WebKitTestRunner for Windows port
347         https://bugs.webkit.org/show_bug.cgi?id=189257
348
349         Reviewed by Fujii Hironori.
350
351         Implement WebKitTestRunner for WinCairo.
352
353         * PlatformWin.cmake:
354         * Scripts/build-webkittestrunner:
355         * WebKitTestRunner/CMakeLists.txt:
356         * WebKitTestRunner/EventSenderProxy.h:
357         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
358         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
359         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
360         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
361         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
362         (WTR::rangeToStr):
363         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
364         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
365         (WTR::TestRunner::TestRunner):
366         * WebKitTestRunner/InjectedBundle/TestRunner.h:
367         * WebKitTestRunner/InjectedBundle/win/AccessibilityControllerWin.cpp: Added.
368         (WTR::AccessibilityController::resetToConsistentState):
369         (WTR::AccessibilityController::accessibleElementById):
370         (WTR::AccessibilityController::platformName):
371         (WTR::AccessibilityController::rootElement):
372         (WTR::AccessibilityController::focusedElement):
373         (WTR::AccessibilityController::addNotificationListener):
374         (WTR::AccessibilityController::removeNotificationListener):
375         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp: Added.
376         (WTR::AccessibilityUIElement::AccessibilityUIElement):
377         (WTR::AccessibilityUIElement::~AccessibilityUIElement):
378         (WTR::AccessibilityUIElement::isEqual):
379         (WTR::AccessibilityUIElement::getChildren):
380         (WTR::AccessibilityUIElement::getChildrenWithRange):
381         (WTR::AccessibilityUIElement::childrenCount):
382         (WTR::AccessibilityUIElement::elementAtPoint):
383         (WTR::AccessibilityUIElement::indexOfChild):
384         (WTR::AccessibilityUIElement::childAtIndex):
385         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
386         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
387         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
388         (WTR::AccessibilityUIElement::ariaControlsElementAtIndex):
389         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
390         (WTR::AccessibilityUIElement::rowAtIndex):
391         (WTR::AccessibilityUIElement::selectedChildAtIndex const):
392         (WTR::AccessibilityUIElement::selectedChildrenCount const):
393         (WTR::AccessibilityUIElement::selectedRowAtIndex):
394         (WTR::AccessibilityUIElement::titleUIElement):
395         (WTR::AccessibilityUIElement::parentElement):
396         (WTR::AccessibilityUIElement::disclosedByRow):
397         (WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
398         (WTR::AccessibilityUIElement::attributesOfDocumentLinks):
399         (WTR::AccessibilityUIElement::attributesOfChildren):
400         (WTR::AccessibilityUIElement::allAttributes):
401         (WTR::AccessibilityUIElement::stringAttributeValue):
402         (WTR::AccessibilityUIElement::numberAttributeValue):
403         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue const):
404         (WTR::AccessibilityUIElement::rowHeaders const):
405         (WTR::AccessibilityUIElement::columnHeaders const):
406         (WTR::AccessibilityUIElement::uiElementAttributeValue const):
407         (WTR::AccessibilityUIElement::boolAttributeValue):
408         (WTR::AccessibilityUIElement::isAttributeSettable):
409         (WTR::AccessibilityUIElement::isAttributeSupported):
410         (WTR::AccessibilityUIElement::parameterizedAttributeNames):
411         (WTR::AccessibilityUIElement::role):
412         (WTR::AccessibilityUIElement::subrole):
413         (WTR::AccessibilityUIElement::roleDescription):
414         (WTR::AccessibilityUIElement::computedRoleString):
415         (WTR::AccessibilityUIElement::title):
416         (WTR::AccessibilityUIElement::description):
417         (WTR::AccessibilityUIElement::orientation const):
418         (WTR::AccessibilityUIElement::stringValue):
419         (WTR::AccessibilityUIElement::language):
420         (WTR::AccessibilityUIElement::helpText const):
421         (WTR::AccessibilityUIElement::x):
422         (WTR::AccessibilityUIElement::y):
423         (WTR::AccessibilityUIElement::width):
424         (WTR::AccessibilityUIElement::height):
425         (WTR::AccessibilityUIElement::clickPointX):
426         (WTR::AccessibilityUIElement::clickPointY):
427         (WTR::AccessibilityUIElement::intValue const):
428         (WTR::AccessibilityUIElement::minValue):
429         (WTR::AccessibilityUIElement::maxValue):
430         (WTR::AccessibilityUIElement::valueDescription):
431         (WTR::AccessibilityUIElement::insertionPointLineNumber):
432         (WTR::AccessibilityUIElement::isPressActionSupported):
433         (WTR::AccessibilityUIElement::isIncrementActionSupported):
434         (WTR::AccessibilityUIElement::isDecrementActionSupported):
435         (WTR::AccessibilityUIElement::isEnabled):
436         (WTR::AccessibilityUIElement::isRequired const):
437         (WTR::AccessibilityUIElement::isFocused const):
438         (WTR::AccessibilityUIElement::isSelected const):
439         (WTR::AccessibilityUIElement::isSelectedOptionActive const):
440         (WTR::AccessibilityUIElement::isExpanded const):
441         (WTR::AccessibilityUIElement::isChecked const):
442         (WTR::AccessibilityUIElement::isIndeterminate const):
443         (WTR::AccessibilityUIElement::hierarchicalLevel const):
444         (WTR::AccessibilityUIElement::speakAs):
445         (WTR::AccessibilityUIElement::ariaIsGrabbed const):
446         (WTR::AccessibilityUIElement::ariaDropEffects const):
447         (WTR::AccessibilityUIElement::lineForIndex):
448         (WTR::AccessibilityUIElement::rangeForLine):
449         (WTR::AccessibilityUIElement::rangeForPosition):
450         (WTR::AccessibilityUIElement::boundsForRange):
451         (WTR::AccessibilityUIElement::stringForRange):
452         (WTR::AccessibilityUIElement::attributedStringForRange):
453         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
454         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
455         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
456         (WTR::AccessibilityUIElement::selectTextWithCriteria):
457         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
458         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
459         (WTR::AccessibilityUIElement::attributesOfColumns):
460         (WTR::AccessibilityUIElement::attributesOfRows):
461         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
462         (WTR::AccessibilityUIElement::attributesOfHeader):
463         (WTR::AccessibilityUIElement::rowCount):
464         (WTR::AccessibilityUIElement::columnCount):
465         (WTR::AccessibilityUIElement::indexInTable):
466         (WTR::AccessibilityUIElement::rowIndexRange):
467         (WTR::AccessibilityUIElement::columnIndexRange):
468         (WTR::AccessibilityUIElement::cellForColumnAndRow):
469         (WTR::AccessibilityUIElement::horizontalScrollbar const):
470         (WTR::AccessibilityUIElement::verticalScrollbar const):
471         (WTR::AccessibilityUIElement::selectedTextRange):
472         (WTR::AccessibilityUIElement::setSelectedTextRange):
473         (WTR::AccessibilityUIElement::increment):
474         (WTR::AccessibilityUIElement::decrement):
475         (WTR::AccessibilityUIElement::showMenu):
476         (WTR::AccessibilityUIElement::press):
477         (WTR::AccessibilityUIElement::setSelectedChild const):
478         (WTR::AccessibilityUIElement::setSelectedChildAtIndex const):
479         (WTR::AccessibilityUIElement::removeSelectionAtIndex const):
480         (WTR::AccessibilityUIElement::clearSelectedChildren const):
481         (WTR::AccessibilityUIElement::accessibilityValue const):
482         (WTR::AccessibilityUIElement::documentEncoding):
483         (WTR::AccessibilityUIElement::documentURI):
484         (WTR::AccessibilityUIElement::url):
485         (WTR::AccessibilityUIElement::addNotificationListener):
486         (WTR::AccessibilityUIElement::removeNotificationListener):
487         (WTR::AccessibilityUIElement::isFocusable const):
488         (WTR::AccessibilityUIElement::isSelectable const):
489         (WTR::AccessibilityUIElement::isMultiSelectable const):
490         (WTR::AccessibilityUIElement::isVisible const):
491         (WTR::AccessibilityUIElement::isOffScreen const):
492         (WTR::AccessibilityUIElement::isCollapsed const):
493         (WTR::AccessibilityUIElement::isIgnored const):
494         (WTR::AccessibilityUIElement::isSingleLine const):
495         (WTR::AccessibilityUIElement::isMultiLine const):
496         (WTR::AccessibilityUIElement::hasPopup const):
497         (WTR::AccessibilityUIElement::takeFocus):
498         (WTR::AccessibilityUIElement::takeSelection):
499         (WTR::AccessibilityUIElement::addSelection):
500         (WTR::AccessibilityUIElement::removeSelection):
501         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
502         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
503         (WTR::AccessibilityUIElement::textMarkerRangeLength):
504         (WTR::AccessibilityUIElement::previousTextMarker):
505         (WTR::AccessibilityUIElement::nextTextMarker):
506         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
507         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
508         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
509         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
510         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
511         (WTR::AccessibilityUIElement::startTextMarkerForBounds):
512         (WTR::AccessibilityUIElement::textMarkerForPoint):
513         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
514         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRange):
515         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions):
516         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
517         (WTR::AccessibilityUIElement::indexForTextMarker):
518         (WTR::AccessibilityUIElement::isTextMarkerValid):
519         (WTR::AccessibilityUIElement::textMarkerForIndex):
520         (WTR::AccessibilityUIElement::startTextMarker):
521         (WTR::AccessibilityUIElement::endTextMarker):
522         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
523         (WTR::AccessibilityUIElement::scrollToMakeVisible):
524         (WTR::AccessibilityUIElement::scrollToGlobalPoint):
525         (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
526         (WTR::AccessibilityUIElement::supportedActions const):
527         (WTR::AccessibilityUIElement::pathDescription const):
528         (WTR::AccessibilityUIElement::mathPostscriptsDescription const):
529         (WTR::AccessibilityUIElement::mathPrescriptsDescription const):
530         (WTR::AccessibilityUIElement::classList const):
531         (WTR::AccessibilityUIElement::characterAtOffset):
532         (WTR::AccessibilityUIElement::wordAtOffset):
533         (WTR::AccessibilityUIElement::lineAtOffset):
534         (WTR::AccessibilityUIElement::sentenceAtOffset):
535         * WebKitTestRunner/InjectedBundle/win/ActivateFontsWin.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp.
536         (WTR::activateFonts):
537         (WTR::installFakeHelvetica):
538         (WTR::uninstallFakeHelvetica):
539         * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp.
540         (WTR::InjectedBundle::platformInitialize):
541         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.cpp: Added.
542         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h: Copied from Tools/WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp.
543         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp.
544         (WTR::TestRunner::pathToLocalResource):
545         (WTR::TestRunner::inspectorTestStubURL):
546         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
547         (WTR::TestRunner::platformInitialize):
548         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
549         (WTR::TestRunner::installFakeHelvetica):
550         * WebKitTestRunner/PlatformWebView.h:
551         * WebKitTestRunner/PlatformWin.cmake: Added.
552         * WebKitTestRunner/TestController.cpp:
553         (WTR::TestController::resetStateToConsistentValues):
554         (WTR::createTestURL):
555         * WebKitTestRunner/TestInvocation.cpp:
556         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
557         * WebKitTestRunner/win/EventSenderProxyWin.cpp: Added.
558         (WTR::EventSenderProxy::EventSenderProxy):
559         (WTR::EventSenderProxy::~EventSenderProxy):
560         (WTR::EventSenderProxy::mouseDown):
561         (WTR::EventSenderProxy::mouseUp):
562         (WTR::EventSenderProxy::mouseMoveTo):
563         (WTR::EventSenderProxy::mouseScrollBy):
564         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
565         (WTR::EventSenderProxy::continuousMouseScrollBy):
566         (WTR::EventSenderProxy::leapForward):
567         (WTR::EventSenderProxy::keyDown):
568         * WebKitTestRunner/win/PlatformWebViewWin.cpp: Added.
569         (WTR::registerWindowClass):
570         (WTR::PlatformWebView::PlatformWebView):
571         (WTR::PlatformWebView::~PlatformWebView):
572         (WTR::PlatformWebView::resizeTo):
573         (WTR::PlatformWebView::page):
574         (WTR::PlatformWebView::focus):
575         (WTR::PlatformWebView::windowFrame):
576         (WTR::PlatformWebView::setWindowFrame):
577         (WTR::PlatformWebView::didInitializeClients):
578         (WTR::PlatformWebView::addChromeInputField):
579         (WTR::PlatformWebView::removeChromeInputField):
580         (WTR::PlatformWebView::addToWindow):
581         (WTR::PlatformWebView::removeFromWindow):
582         (WTR::PlatformWebView::setWindowIsKey):
583         (WTR::PlatformWebView::makeWebViewFirstResponder):
584         (WTR::generateCairoSurfaceFromBitmap):
585         (WTR::PlatformWebView::windowSnapshotImage):
586         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
587         (WTR::PlatformWebView::setNavigationGesturesEnabled):
588         (WTR::PlatformWebView::forceWindowFramesChanged):
589         (WTR::PlatformWebView::drawsBackground const):
590         (WTR::PlatformWebView::setDrawsBackground):
591         * WebKitTestRunner/win/TestControllerWin.cpp: Added.
592         (WTR::exceptionFilter):
593         (WTR::runRunLoopUntil):
594         (WTR::TestController::notifyDone):
595         (WTR::TestController::setHidden):
596         (WTR::TestController::platformInitialize):
597         (WTR::TestController::platformPreferences):
598         (WTR::TestController::platformDestroy):
599         (WTR::toWK):
600         (WTR::TestController::platformInitializeContext):
601         (WTR::TestController::platformRunUntil):
602         (WTR::TestController::platformDidCommitLoadForFrame):
603         (WTR::TestController::initializeInjectedBundlePath):
604         (WTR::TestController::initializeTestPluginDirectory):
605         (WTR::TestController::runModal):
606         (WTR::TestController::platformContext):
607         (WTR::TestController::platformLibraryPathForTesting):
608         (WTR::TestController::platformConfigureViewForTest):
609         (WTR::TestController::platformResetPreferencesToConsistentValues):
610         (WTR::TestController::updatePlatformSpecificTestOptionsForTest const):
611         * WebKitTestRunner/win/WebKitTestRunnerPrefix.cpp: Added.
612         * WebKitTestRunner/win/main.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp.
613         (dllLauncherEntryPoint):
614
615 2018-11-12  Alicia Boya García  <aboya@igalia.com>
616
617         [MSE][GStreamer] Introduce AbortableTaskQueue
618         https://bugs.webkit.org/show_bug.cgi?id=190902
619
620         Reviewed by Xabier Rodriguez-Calvar.
621
622         Tests for AbortableTaskQueue are included.
623
624         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
625         * TestWebKitAPI/PlatformGTK.cmake:
626         * TestWebKitAPI/Tests/WebCore/AbortableTaskQueue.cpp: Added.
627         (TestWebKitAPI::TEST):
628         (TestWebKitAPI::FancyResponse::FancyResponse):
629         (TestWebKitAPI::FancyResponse::operator=):
630         (TestWebKitAPI::DeterministicScheduler::DeterministicScheduler):
631         (TestWebKitAPI::DeterministicScheduler::ThreadContext::ThreadContext):
632         (TestWebKitAPI::DeterministicScheduler::ThreadContext::waitMyTurn):
633         (TestWebKitAPI::DeterministicScheduler::ThreadContext::yieldToThread):
634
635 2018-11-11  Fujii Hironori  <Hironori.Fujii@sony.com>
636
637         run-bindings-tests is timing out in some WinCairo bots
638         https://bugs.webkit.org/show_bug.cgi?id=191348
639
640         Reviewed by Alex Christensen.
641
642         BuildBot kills run-bindings-tests if it outputs nothing for 20
643         minutes. run-bindings-tests runs very slowly in WinCairo Docker,
644         and it takes more than 30 minutes to finish. And, Windows Python
645         buffers the progress output.
646
647         * Scripts/webkitpy/bindings/main.py:
648         (BindingsTests.detect_changes): Call sys.stdout.flush() after the
649         test case result is output.
650
651 2018-11-11  Wenson Hsieh  <wenson_hsieh@apple.com>
652
653         Implement a new edit command to change the enclosing list type
654         https://bugs.webkit.org/show_bug.cgi?id=191487
655         <rdar://problem/45955922>
656
657         Reviewed by Ryosuke Niwa.
658
659         Add a new API test to verify that `-[WKWebView _changeListType:]` is hooked up to the corresponding editing
660         command in WebCore. See the new layout test for a test that exercises more nuanced corner cases.
661
662         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
663         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
664         (-[TestWKWebView setPosition:offset:]):
665         (-[TestWKWebView setBase:baseOffset:extent:extentOffset:]):
666         (TestWebKitAPI::webViewForEditActionTestingWithPageNamed):
667         (TestWebKitAPI::TEST):
668         * TestWebKitAPI/Tests/WebKitCocoa/editable-nested-lists.html: Added.
669
670 2018-11-11  Dan Bernstein  <mitz@apple.com>
671
672         ProcessPoolConfiguration::copy() doesn’t copy m_customWebContentServiceBundleIdentifier
673         https://bugs.webkit.org/show_bug.cgi?id=191514
674
675         Reviewed by Geoffrey Garen.
676
677         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
678         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm: Added.
679         (TEST):
680
681 2018-11-11  Benjamin Poulain  <benjamin@webkit.org>
682
683         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
684         https://bugs.webkit.org/show_bug.cgi?id=191492
685
686         Reviewed by Alex Christensen.
687
688         Update file name.
689
690         * DumpRenderTree/mac/DumpRenderTree.mm:
691         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
692         * WebKitTestRunner/mac/TestControllerMac.mm:
693
694 2018-11-10  Benjamin Poulain  <benjamin@webkit.org>
695
696         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
697         https://bugs.webkit.org/show_bug.cgi?id=191492
698
699         Reviewed by Alex Christensen.
700
701         * DumpRenderTree/mac/DumpRenderTree.mm:
702         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
703         * WebKitTestRunner/mac/TestControllerMac.mm:
704
705 2018-11-10  Ryan Haddad  <ryanhaddad@apple.com>
706
707         Unreviewed, rolling out r238065.
708
709         Breaks internal builds.
710
711         Reverted changeset:
712
713         "Make it possible to edit images inline"
714         https://bugs.webkit.org/show_bug.cgi?id=191352
715         https://trac.webkit.org/changeset/238065
716
717 2018-11-10  Michael Catanzaro  <mcatanzaro@igalia.com>
718
719         [WPE][GTK] API test /webkit/WebKitSettings/webkit-settings is failing
720         https://bugs.webkit.org/show_bug.cgi?id=191221
721
722         Unreviewed, fix a typo from the previous patch. After disabling the setting, we should test
723         that it is disabled, but we're testing that it is enabled, because I failed to update this
724         line.
725
726         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
727         (testWebKitSettings):
728
729 2018-11-10  Tim Horton  <timothy_horton@apple.com>
730
731         Make it possible to edit images inline
732         https://bugs.webkit.org/show_bug.cgi?id=191352
733         <rdar://problem/30107985>
734
735         Reviewed by Dean Jackson.
736
737         * WebKitTestRunner/TestController.cpp:
738         (WTR::updateTestOptionsFromTestHeader):
739         * WebKitTestRunner/TestOptions.h:
740         (WTR::TestOptions::hasSameInitializationOptions const):
741         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
742         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
743         (WTR::TestController::platformCreateWebView):
744         Add a test option to enable editable images.
745
746         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
747         (WTR::UIScriptController::drawSquareInEditableImage):
748         (WTR::UIScriptController::numberOfStrokesInEditableImage):
749         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
750         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
751         (WTR::UIScriptController::drawSquareInEditableImage):
752         (WTR::UIScriptController::numberOfStrokesInEditableImage):
753         * TestRunnerShared/UIScriptContext/UIScriptController.h:
754         * TestRunnerShared/spi/PencilKitTestSPI.h: Added.
755         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
756         (WTR::findEditableImageCanvas):
757         (WTR::UIScriptController::drawSquareInEditableImage):
758         (WTR::UIScriptController::numberOfStrokesInEditableImage):
759         Add the ability to draw on a PKCanvasView that is a subview of the WKWebView,
760         and also to retrieve the number of strokes currently on the PKCanvasView.
761         Currently this just takes the first canvas; we might need to make it
762         take an identifier or something in the future if we need tests with multiple
763         canvases. The indirect testing mechanism is required because PKCanvasView
764         can currently not actually paint its strokes in the Simulator.
765
766 2018-11-09  Chris Dumez  <cdumez@apple.com>
767
768         Suspended page persists even after back/forward list item is gone
769         https://bugs.webkit.org/show_bug.cgi?id=191488
770         <rdar://problem/45953006>
771
772         Reviewed by Geoffrey Garen.
773
774         Add API test coverage.
775
776         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
777
778 2018-11-09  Wenson Hsieh  <wenson_hsieh@apple.com>
779
780         [Cocoa] Implement SPI on WKWebView to increase and decrease list levels
781         https://bugs.webkit.org/show_bug.cgi?id=191471
782         <rdar://problem/45952472>
783
784         Reviewed by Tim Horton.
785
786         Add an API test to ensure that list levels can be incremented and decremented via WKWebView SPI.
787
788         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
789         (TestWebKitAPI::webViewForEditActionTesting):
790         (TestWebKitAPI::TEST):
791
792 2018-11-09  Basuke Suzuki  <basuke.suzuki@sony.com>
793
794         [Curl][WebKit] Implement Proxy configuration API.
795         https://bugs.webkit.org/show_bug.cgi?id=189053
796
797         Reviewed by Youenn Fablet.
798
799         Added Proxy Settings dialog to call newly added API.
800
801         * MiniBrowser/win/BrowserWindow.h:
802         * MiniBrowser/win/Common.cpp:
803         (askProxySettings):
804         (askCredential):
805         (authDialogProc): Deleted.
806         * MiniBrowser/win/Common.h:
807         * MiniBrowser/win/DialogHelper.h: Added.
808         (Dialog::run):
809         (Dialog::doalogProc):
810         (Dialog::handle):
811         (Dialog::setup):
812         (Dialog::update):
813         (Dialog::validate):
814         (Dialog::updateOkButton):
815         (Dialog::command):
816         (Dialog::ok):
817         (Dialog::cancel):
818         (Dialog::close):
819         (Dialog::hDlg):
820         (Dialog::item):
821         (Dialog::setEnabled):
822         (Dialog::setText):
823         (Dialog::getText):
824         (Dialog::getTextLength):
825         (Dialog::RadioGroup::RadioGroup):
826         (Dialog::RadioGroup::set):
827         (Dialog::RadioGroup::get):
828         (Dialog::radioGroup):
829         * MiniBrowser/win/MainWindow.cpp:
830         (MainWindow::WndProc):
831         * MiniBrowser/win/MiniBrowserLib.rc:
832         * MiniBrowser/win/MiniBrowserLibResource.h:
833         * MiniBrowser/win/WebKitBrowserWindow.cpp:
834         (createWKURL):
835         (WebKitBrowserWindow::WebKitBrowserWindow):
836         (WebKitBrowserWindow::updateProxySettings):
837         (WebKitBrowserWindow::loadURL):
838         (WebKitBrowserWindow::loadHTMLString):
839         (WebKitBrowserWindow::openProxySettings):
840         * MiniBrowser/win/WebKitBrowserWindow.h:
841         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
842         (WebKitLegacyBrowserWindow::openProxySettings):
843         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
844
845 2018-11-09  Wenson Hsieh  <wenson_hsieh@apple.com>
846
847         [Cocoa] Introduce WKWebView SPI to insert nested ordered and unordered lists
848         https://bugs.webkit.org/show_bug.cgi?id=191410
849         <rdar://problem/45898610>
850
851         Reviewed by Dean Jackson.
852
853         Move WKWebViewEditActions from iOS to WebKitCocoa, and enable the relevant WKWebViewEditActions tests on macOS.
854         Additionally, add new API tests to verify that `-_pasteAsQuotation:` and `-_insertNested(Un)OrderedList:` are
855         hooked up to their respective editing commands.
856
857         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
858         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm: Renamed from Tools/TestWebKitAPI/Tests/ios/WKWebViewEditActions.mm.
859         (-[TestWKWebView querySelectorExists:]):
860         (-[TestWKWebView insertString:]):
861
862         Add a helper method to insert a piece of text. This abstracts platform differences between iOS and macOS, by
863         invoking the WKWebView directly on macOS and calling on the content view on iOS.
864
865         (TestWebKitAPI::webViewForEditActionTesting):
866         (TestWebKitAPI::TEST):
867
868 2018-11-09  Philippe Normand  <pnormand@igalia.com>
869
870         [Flatpak] Refactoring and drive-by fixes
871         https://bugs.webkit.org/show_bug.cgi?id=191421
872
873         Reviewed by Michael Catanzaro.
874
875         * Scripts/webkitdirs.pm:
876         (inFlatpakSandbox): Flatpak now has a /.flatpak-info file when in
877         the sandbox, so rely on this.
878         * flatpak/flatpakutils.py:
879         (expand_manifest): Pass explicit keywords to load_manifest() and
880         remove unused local variable.
881         (WebkitFlatpak.clean_args): Move hard-coded sdk/runtime infos to the manifest file.
882         (WebkitFlatpak.run_in_sandbox): Add support for extra environment variables.
883         (WebkitFlatpak.setup_dev_env): Stop build at final app. Refactor
884         build_type handling a bit.
885         * flatpak/org.webkit.CommonModules.yaml: Added.
886         * flatpak/org.webkit.WPE.yaml: wpebackend upstream was renamed to libwpe.
887         * flatpak/org.webkit.WebKit.yaml: Move common dependencies
888         declaration to CommonModules, so it can be reused later when we
889         add support for building extra libraries depending on WPE.
890
891 2018-11-08  Said Abou-Hallawa  <sabouhallawa@apple.com>
892
893 onal supported image formats
894         https://bugs.webkit.org/show_bug.cgi?id=190454
895
896         Reviewed by Simon Fraser.
897
898         Test opening a TGA image in WebView which is not allowed by default. The
899         TGA format will be allowed through WKWebViewConfiguration.
900
901         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
902         * TestWebKitAPI/Tests/WebKitCocoa/100x100-red.tga: Added.
903         * TestWebKitAPI/Tests/WebKitCocoa/400x400-green.png: Added.
904         * TestWebKitAPI/Tests/WebKitCocoa/AdditionalSupportedImageTypes.mm: Added.
905         (runTest):
906         (TEST):
907
908 2018-11-08  Jiewen Tan  <jiewen_tan@apple.com>
909
910         Unreviewed, a proper build fix for r237983
911
912         Don't include header PublicKeyCredential.h in CtapResponseTest.cpp.
913
914         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
915         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/CtapRequestTest.cpp.
916         (TestWebKitAPI::TEST):
917         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/CtapResponseTest.cpp.
918         (TestWebKitAPI::getTestCorruptedSignResponse):
919         (TestWebKitAPI::getTestCredentialRawIdBytes):
920         (TestWebKitAPI::convertToVector):
921         (TestWebKitAPI::TEST):
922
923 2018-11-08  Keith Rollin  <krollin@apple.com>
924
925         Create .xcfilelist files
926         https://bugs.webkit.org/show_bug.cgi?id=191324
927         <rdar://problem/45852819>
928
929         Reviewed by Alex Christensen.
930
931         As part of preparing for enabling XCBuild, create and use .xcfilelist
932         files. These files are using during Run Script build phases in an
933         Xcode project. If a Run Script build phase produces new files that are
934         used later as inputs to subsequent build phases, XCBuild needs to know
935         about these files. These files can be either specified in an "output
936         files" section of the Run Script phase editor, or in .xcfilelist files
937         that are associated with the Run Script build phase.
938
939         This patch takes the second approach. It consists of three sets of changes:
940
941         - Modify the DerivedSources.make files to have a
942           'print_all_generated_files" target that produces a list of the files
943           they create.
944
945         - Create a shell script that produces .xcfilelist files from the
946           output of the previous step, as well as for the files created in the
947           Generate Unified Sources build steps.
948
949         - Add the new .xcfilelist files to the associated projects.
950
951         Note that, with these changes, the Xcode workspace and projects can no
952         longer be fully loaded into Xcode 9. Xcode will attempt to load the
953         projects that have .xcfilelist files associated with them, but will
954         fail and display a placeholder for those projects instead. It's
955         expected that all developers are using Xcode 10 by now and that not
956         being able to load into Xcode 9 is not a practical issue. Keep in mind
957         that this is strictly an IDE issue, and that the projects can still be
958         built with `xcodebuild`.
959
960         Also note that the shell script that creates the .xcfilelist files can
961         also be used to verify that the set of files that's currently checked
962         in is up-to-date. This checking can be used as part of a check-in hook
963         or part of check-webkit-style to sooner catch cases where the
964         .xcfilelist files need to be regenerated.
965
966         * DumpRenderTree/DerivedSources.make:
967         * DumpRenderTree/DerivedSources.xcfilelist: Added.
968         * Scripts/generate-xcfilelists: Added.
969         * WebKitTestRunner/DerivedSources.make:
970         * WebKitTestRunner/DerivedSources.xcfilelist: Added.
971
972 2018-11-08  Jiewen Tan  <jiewen_tan@apple.com>
973
974         Unreviewed, a quick build fix for r237983
975
976         Temporarily make CtapRequestTest.cpp/CtapResponseTest.cpp to mac only to avoid iOS build failures.
977
978         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
979         * TestWebKitAPI/Tests/WebCore/mac/CtapRequestTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp.
980         (TestWebKitAPI::TEST):
981         * TestWebKitAPI/Tests/WebCore/mac/CtapResponseTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp.
982         (TestWebKitAPI::getTestCorruptedSignResponse):
983         (TestWebKitAPI::getTestCredentialRawIdBytes):
984         (TestWebKitAPI::convertToVector):
985         (TestWebKitAPI::TEST):
986
987 2018-11-05  Ryan Haddad  <ryanhaddad@apple.com>
988
989         Fix steps_unittest.py failures related to recent Win10/Win7 changes
990         https://bugs.webkit.org/show_bug.cgi?id=191290
991
992         Reviewed by Alexey Proskuryakov.
993
994         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update expected results.
995
996 2018-11-08  Dean Jackson  <dino@apple.com>
997
998         Add a String literal that returns a String
999         https://bugs.webkit.org/show_bug.cgi?id=191425
1000         <rdar://problem/45914556>
1001
1002         Reviewed by Sam Weinig.
1003
1004         Test _str.
1005
1006         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
1007         (TestWebKitAPI::TEST):
1008
1009 2018-11-08  Jonathan Bedard  <jbedard@apple.com>
1010
1011         webkitpy: Generalize trailing SDK specifier (Part 2)
1012         https://bugs.webkit.org/show_bug.cgi?id=191275
1013         <rdar://problem/45703660>
1014
1015         Rubber-stamped by Aakash Jain.
1016
1017         Re-landing this change, configuration issues have been resolved.
1018
1019         * Scripts/webkitpy/port/ios_device.py:
1020         (IOSDevicePort): Use normalized SDK.
1021         * Scripts/webkitpy/port/ios_simulator.py:
1022         (IOSSimulatorPort): Use normalized SDK.
1023         (IOSSimulatorPort._build_driver_flags): Use platform SDK in build driver flags.
1024
1025 2018-11-08  Jiewen Tan  <jiewen_tan@apple.com>
1026
1027         [WebAuthN] Import CTAP device request/response converters from Chromium
1028         https://bugs.webkit.org/show_bug.cgi?id=190784
1029         <rdar://problem/45460333>
1030
1031         Reviewed by Brent Fulgham.
1032
1033         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1034         * TestWebKitAPI/Tests/WebCore/CBORValueTest.cpp:
1035         (TestWebKitAPI::TEST):
1036         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp: Added.
1037         (TestWebKitAPI::TEST):
1038         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp: Added.
1039         (TestWebKitAPI::getTestCorruptedSignResponse):
1040         (TestWebKitAPI::getTestCredentialRawIdBytes):
1041         (TestWebKitAPI::convertToVector):
1042         (TestWebKitAPI::TEST):
1043         * TestWebKitAPI/Tests/WebCore/FidoTestData.h: Added.
1044
1045 2018-11-07  Caio Lima  <ticaiolima@gmail.com>
1046
1047         [BigInt] Add support to BigInt into ValueAdd
1048         https://bugs.webkit.org/show_bug.cgi?id=186177
1049
1050         Reviewed by Keith Miller.
1051
1052         * Scripts/run-jsc-benchmarks:
1053
1054 2018-11-07  Sihui Liu  <sihui_liu@apple.com>
1055
1056         RELEASE_ASSERT(!m_hardClosedForUserDelete) fails in WebCore::IDBServer::UniqueIDBDatabase::invokeOperationAndTransactionTimer
1057         https://bugs.webkit.org/show_bug.cgi?id=191326
1058         <rdar://problem/45769269>
1059
1060         Reviewed by Geoffrey Garen.
1061
1062         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1063         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.html: Added.
1064         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm: Added.
1065         (-[IndexedDBUserDeleteMessageHandler userContentController:didReceiveScriptMessage:]):
1066         (TEST):
1067
1068 2018-11-07  Daniel Bates  <dabates@apple.com>
1069
1070         Override +[UIKeyboard isInHardwareKeyboardMode] in WebKitTestRunner and DumpRenderTree
1071         https://bugs.webkit.org/show_bug.cgi?id=190141
1072
1073         Reviewed by Darin Adler.
1074
1075         Override +[UIKeyboard isInHardwareKeyboardMode] to always return NO so as to make test
1076         runs deterministic regardless of whether a hardware keyboard is attached.
1077
1078         * DumpRenderTree/mac/DumpRenderTree.mm:
1079         (overrideIsInHardwareKeyboardMode): Added.
1080         (prepareConsistentTestingEnvironment):
1081         * TestRunnerShared/spi/UIKitTestSPI.h: Forward declare SPI.
1082         * WebKitTestRunner/ios/TestControllerIOS.mm:
1083         (overrideIsInHardwareKeyboardMode): Added.
1084         (WTR::TestController::platformInitialize):
1085
1086 2018-11-07  Jonathan Bedard  <jbedard@apple.com>
1087
1088         Unreviewed, rolling out r237913.
1089
1090         Breaks running tests on Mac without iOS SDK installed
1091
1092         Reverted changeset:
1093
1094         "webkitpy: Generalize trailing SDK specifier (Part 2)"
1095         https://bugs.webkit.org/show_bug.cgi?id=191275
1096         https://trac.webkit.org/changeset/237913
1097
1098 2018-11-07  Zamiul Haque  <zhaque@apple.com>
1099
1100         Force a gregorian calendar to show for credit card expiration date inputs
1101         (autocomplete='cc-exp'*) regardless of default system settings.
1102         https://bugs.webkit.org/show_bug.cgi?id=191096
1103         rdar://problem/42640256
1104
1105         Reviewed by Tim Horton.
1106
1107         Implemented simulateForeignDefaultCalendar and calendarType to be used
1108         for changing the default calendar returned by the system (ie. [NSCalendar
1109         currentCalendar]) and getting the calendar type identifier of a presented date
1110         picker.
1111
1112         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1113         (WTR::UIScriptController::isShowingDataListSuggestions const):
1114         (WTR::UIScriptController::calendarType const):
1115         (WTR::UIScriptController::setDefaultCalendarType):
1116         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1117         (WTR::UIScriptController::calendarType const):
1118         (WTR::UIScriptController::setDefaultCalendarType):
1119         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1120         (WTR::UIScriptController::selectionEndGrabberViewRect const):
1121         (WTR::UIScriptController::calendarType const): Deleted.
1122         * WebKitTestRunner/TestController.cpp:
1123         * WebKitTestRunner/TestController.h:
1124         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1125         (WTR::UIScriptController::calendarType const):
1126         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1127         (WTR::swizzledCalendar):
1128         (WTR::TestController::getOverriddenCalendarIdentifier const):
1129         (WTR::TestController::setDefaultCalendarType):
1130         (WTR::TestController::cocoaResetStateToConsistentValues):
1131         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1132         (WTR::UIScriptController::selectionEndGrabberViewRect const):
1133         (WTR::UIScriptController::calendarType const): Deleted.
1134
1135 2018-11-06  Jonathan Bedard  <jbedard@apple.com>
1136
1137         webkitpy: Boot a single worker for custom devices
1138         https://bugs.webkit.org/show_bug.cgi?id=191312
1139         <rdar://problem/45848717>
1140
1141         Rubber-stamped by Aakash Jain.
1142
1143         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1144         (Manager.run): Custom devices only run a hand-full of tests. Booting multiple
1145         simulators is expensive and unneeded for these tests.
1146         * Scripts/webkitpy/port/ios.py:
1147         (IOSPort. child_processes): No reason to memoize this call, and it prevents
1148         overriding the number of child processes when booting custom devices.
1149
1150 2018-11-06  Jonathan Bedard  <jbedard@apple.com>
1151
1152         webkitpy: Generalize trailing SDK specifier (Part 2)
1153         https://bugs.webkit.org/show_bug.cgi?id=191275
1154         <rdar://problem/45703660>
1155
1156         Reviewed by Aakash Jain.
1157
1158         * Scripts/webkitpy/port/ios_device.py:
1159         (IOSDevicePort): Use normalized SDK.
1160         * Scripts/webkitpy/port/ios_simulator.py:
1161         (IOSSimulatorPort): Use normalized SDK.
1162         (IOSSimulatorPort._build_driver_flags): Use platform SDK in build driver flags.
1163
1164 2018-11-06  Justin Fan  <justin_fan@apple.com>
1165
1166         [WebGPU] Experimental prototype for WebGPURenderPipeline and WebGPUSwapChain
1167         https://bugs.webkit.org/show_bug.cgi?id=191291
1168
1169         Reviewed by Myles Maxfield.
1170
1171         Properly disable WEBGPU on all non-Metal platforms for now.
1172
1173         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1174
1175 2018-11-06  Aakash Jain  <aakash_jain@apple.com>
1176
1177         [ews-app] Add URL configuration for OpenSource EWS Django app
1178         https://bugs.webkit.org/show_bug.cgi?id=191132
1179
1180         Rubber-stamped by Lucas Forschler.
1181
1182         * BuildSlaveSupport/ews-app/ews-app/urls.py: Added entry for ews.urls.
1183         * BuildSlaveSupport/ews-app/ews/urls.py: Added.
1184
1185 2018-11-06  Youenn Fablet  <youenn@apple.com>
1186
1187         Make mDNS ICE Candidate an experimental flag again
1188         https://bugs.webkit.org/show_bug.cgi?id=191262
1189
1190         Reviewed by Dean Jackson.
1191
1192         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1193         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1194         (WTR::TestRunner::setWebRTCMDNSICECandidatesEnabled):
1195         (WTR::TestRunner::setMDNSICECandidatesEnabled): Deleted.
1196         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1197
1198 2018-11-06  Aakash Jain  <aakash_jain@apple.com>
1199
1200         [ews-app] Add views for OpenSource EWS Django app
1201         https://bugs.webkit.org/show_bug.cgi?id=191131
1202
1203         Rubber-stamped by Lucas Forschler.
1204
1205         * BuildSlaveSupport/ews-app/ews/views/index.py: Added.
1206         * BuildSlaveSupport/ews-app/ews/views/patch.py:
1207         * BuildSlaveSupport/ews-app/ews/views/results.py: Added.
1208         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py: Added.
1209
1210 2018-11-06  Aakash Jain  <aakash_jain@apple.com>
1211
1212         [ews-app] Add models for OpenSource EWS Django app
1213         https://bugs.webkit.org/show_bug.cgi?id=191123
1214
1215         Reviewed by Lucas Forschler.
1216
1217         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
1218         * BuildSlaveSupport/ews-app/ews/models/buildermappings.py: Added.
1219         * BuildSlaveSupport/ews-app/ews/models/builds.py: Added.
1220         * BuildSlaveSupport/ews-app/ews/models/patch.py:
1221         * BuildSlaveSupport/ews-app/ews/models/steps.py: Added.
1222
1223 2018-11-06  Aakash Jain  <aakash_jain@apple.com>
1224
1225         [ews-app] Fix Invalid HTTP_HOST header
1226         https://bugs.webkit.org/show_bug.cgi?id=191325
1227
1228         Reviewed by Lucas Forschler.
1229
1230         Changing ALLOWED_HOSTS to * as the landing page should be publicly accessible.
1231
1232         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1233
1234 2018-11-06  Aakash Jain  <aakash_jain@apple.com>
1235
1236         [ews-app] Rename EWS_app to ews-app - part 2
1237         https://bugs.webkit.org/show_bug.cgi?id=191317
1238
1239         Reviewed by Lucas Forschler.
1240
1241         * BuildSlaveSupport/ews-app/EWS_app: Removed.
1242         * BuildSlaveSupport/ews-app/ews-app: Moved from BuildSlaveSupport/ews-app/EWS_app.
1243         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1244         * BuildSlaveSupport/ews-app/ews-app/urls.py:
1245         * BuildSlaveSupport/ews-app/ews-app/wsgi.py:
1246         * BuildSlaveSupport/ews-app/manage.py:
1247
1248 2018-11-06  Aakash Jain  <aakash_jain@apple.com>
1249
1250         [ews-app] Rename EWS_app to ews-app - part 1
1251         https://bugs.webkit.org/show_bug.cgi?id=191317
1252
1253         Reviewed by Lucas Forschler.
1254
1255         * BuildSlaveSupport/EWS_app: Removed.
1256         * BuildSlaveSupport/ews-app: Moved from BuildSlaveSupport/EWS_app.
1257
1258 2018-11-06  Myles C. Maxfield  <mmaxfield@apple.com>
1259
1260         Spelling dots are drawn in the wrong place
1261         https://bugs.webkit.org/show_bug.cgi?id=190764
1262
1263         Reviewed by Dean Jackson.
1264
1265         Previously, it was impossible for WebKitTestRunner to draw spelling dots. This patch adds support for a header
1266         at the top of test files, of the form <!-- webkit-test-runner [ spellCheckingDots=true ] --> which will cause
1267         dots to be drawn.
1268
1269         * WebKitTestRunner/TestController.cpp:
1270         (WTR::TestController::resetStateToConsistentValues):
1271         (WTR::updateTestOptionsFromTestHeader):
1272         (WTR::TestController::platformResetStateToConsistentValues):
1273         * WebKitTestRunner/TestController.h:
1274         * WebKitTestRunner/TestOptions.h:
1275         (WTR::TestOptions::hasSameInitializationOptions const):
1276         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1277         (WTR::TestController::cocoaResetStateToConsistentValues):
1278         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1279         * WebKitTestRunner/ios/TestControllerIOS.mm:
1280         (WTR::TestController::platformResetStateToConsistentValues):
1281         * WebKitTestRunner/mac/TestControllerMac.mm:
1282         (WTR::TestController::platformResetStateToConsistentValues):
1283
1284 2018-11-06  Don Olmstead  <don.olmstead@sony.com>
1285
1286         Feature flags not present for Visual Studio when using build-webkit
1287         https://bugs.webkit.org/show_bug.cgi?id=191288
1288
1289         Reviewed by Fujii Hironori.
1290
1291         Passes feature flags to Visual studio builds within build-webkit.
1292         Removes cmakeBasedPortArguments as it is no longer in use.
1293
1294         * Scripts/build-jsc:
1295         * Scripts/build-webkit:
1296         * Scripts/webkitdirs.pm:
1297         (cmakeBasedPortArguments): Deleted.
1298
1299 2018-11-06  Per Arne Vollan  <pvollan@apple.com>
1300
1301         REGRESSION (r230523): Caps lock indicator not shown in password field
1302         https://bugs.webkit.org/show_bug.cgi?id=190056
1303
1304         Reviewed by Ryosuke Niwa.
1305
1306         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1307         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1308         (WTR::TestRunner::toggleCapsLock):
1309         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1310         * WebKitTestRunner/TestController.h:
1311         * WebKitTestRunner/TestInvocation.cpp:
1312         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1313         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1314         (WTR::TestController::toggleCapsLock):
1315
1316 2018-11-06  Sihui Liu  <sihui_liu@apple.com>
1317
1318         IndexedDB: WAL file keeps growing
1319         https://bugs.webkit.org/show_bug.cgi?id=191294
1320         <rdar://problem/41333493>
1321
1322         Reviewed by Chris Dumez.
1323
1324         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1325         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize-1.html: Added.
1326         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize-2.html: Added.
1327         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm: Added.
1328         (-[IndexedDBFileSizeMessageHandler userContentController:didReceiveScriptMessage:]):
1329         (TEST):
1330
1331 2018-11-06  Alex Christensen  <achristensen@webkit.org>
1332
1333         Fix tests after r237863
1334         https://bugs.webkit.org/show_bug.cgi?id=191315
1335
1336         Reviewed by Chris Dumez.
1337
1338         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1339         With the timing change of r237863, the WKWebView progressed further than before when loading main.html so it completed before main2.html.
1340         This test was meant to test that main2.html does eventually load, and it doesn't matter if main.html loads before it.  I updated the test
1341         to verify that main2.html eventually loads, making this test less timing dependent.
1342
1343 2018-11-06  Ryan Haddad  <ryanhaddad@apple.com>
1344
1345         Unreviewed, rolling out r237834.
1346
1347         Tests for this change crash on iOS Simulator
1348
1349         Reverted changeset:
1350
1351         "Spelling dots are drawn in the wrong place"
1352         https://bugs.webkit.org/show_bug.cgi?id=190764
1353         https://trac.webkit.org/changeset/237834
1354
1355 2018-11-05  Alex Christensen  <achristensen@webkit.org>
1356
1357         [Mac] Implement safe browsing in WebKit
1358         https://bugs.webkit.org/show_bug.cgi?id=188871
1359
1360         Reviewed by Tim Horton.
1361
1362         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1363         (-[SafeBrowsingNavigationDelegate webView:didCommitNavigation:]):
1364         (+[TestServiceLookupResult resultWithProvider:phishing:malware:unwantedSoftware:]):
1365         (-[TestLookupContext lookUpURL:completionHandler:]):
1366         (simpleURL):
1367         (safeBrowsingView):
1368         (TEST):
1369         (-[SafeBrowsingNavigationDelegate webView:didFinishNavigation:]): Deleted.
1370         (+[TestServiceLookupResult resultWithProvider:phishing:malware:unwantedSoftware:knownToBeUnsafe:]): Deleted.
1371         (-[TestServiceLookupResult isKnownToBeUnsafe]): Deleted.
1372         * TestWebKitAPI/Utilities.h:
1373
1374 2018-11-05  Jonathan Bedard  <jbedard@apple.com>
1375
1376         webkitpy: Generalize trailing SDK specifier (Part 1)
1377         https://bugs.webkit.org/show_bug.cgi?id=191275
1378         <rdar://problem/45703660>
1379
1380         Reviewed by Lucas Forschler.
1381
1382         * Scripts/webkitpy/common/system/platforminfo.py:
1383         (PlatformInfo.available_sdks): List all installed SDKs with version numbers stripped out.
1384         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
1385         (TestPlatformInfo):
1386         (TestPlatformInfo.test_available_sdks):
1387
1388 2018-11-05  Myles C. Maxfield  <mmaxfield@apple.com>
1389
1390         Spelling dots are drawn in the wrong place
1391         https://bugs.webkit.org/show_bug.cgi?id=190764
1392
1393         Reviewed by Dean Jackson.
1394
1395         Previously, it was impossible for WebKitTestRunner to draw spelling dots. This patch adds support for a header
1396         at the top of test files, of the form <!-- webkit-test-runner [ spellCheckingDots=true ] --> which will cause
1397         dots to be drawn.
1398
1399         * WebKitTestRunner/TestController.cpp:
1400         (WTR::TestController::resetStateToConsistentValues):
1401         (WTR::updateTestOptionsFromTestHeader):
1402         (WTR::TestController::platformResetStateToConsistentValues):
1403         * WebKitTestRunner/TestController.h:
1404         * WebKitTestRunner/TestOptions.h:
1405         (WTR::TestOptions::hasSameInitializationOptions const):
1406         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1407         (WTR::TestController::cocoaResetStateToConsistentValues):
1408         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1409         * WebKitTestRunner/ios/TestControllerIOS.mm:
1410         (WTR::TestController::platformResetStateToConsistentValues):
1411         * WebKitTestRunner/mac/TestControllerMac.mm:
1412         (WTR::TestController::platformResetStateToConsistentValues):
1413
1414 2018-11-05  Chris Dumez  <cdumez@apple.com>
1415
1416         Use same limit for page cache and suspended pages
1417         https://bugs.webkit.org/show_bug.cgi?id=191266
1418
1419         Reviewed by Geoffrey Garen.
1420
1421         Update API tests accordingly.
1422
1423         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1424
1425 2018-11-05  Basuke Suzuki  <Basuke.Suzuki@sony.com>
1426
1427         [style] Exclude style check for auto generated files.
1428         https://bugs.webkit.org/show_bug.cgi?id=191118
1429
1430         Reviewed by Eric Carlson.
1431
1432         Some files checked in to the repository are generated by other tools. In this patch,
1433         "MiniBrowserLibResource.h" is the file generated and managed by resource editor of
1434         VisualStudio.
1435
1436         There's no need to check these files because it's not practical to fix the style errors
1437         or it's hard to maintain those fixes.
1438
1439         * Scripts/webkitpy/style/checkers/cpp.py:
1440         (is_generated_file):
1441         (CppChecker.check):
1442
1443 2018-11-05  Thibault Saunier  <tsaunier@igalia.com>
1444
1445         [Flatpak] Build libx264 as it is the h264 encoder we support in WebRTC
1446         https://bugs.webkit.org/show_bug.cgi?id=190680
1447
1448         Reviewed by Philippe Normand.
1449
1450         * flatpak/org.webkit.WebKit.yaml:
1451
1452 2018-11-05  Daniel Bates  <dabates@apple.com>
1453
1454         [lldb-webkit] Fix formatting nits in Document and Frame summary strings
1455         https://bugs.webkit.org/show_bug.cgi?id=191094
1456
1457         Reviewed by Andy Estes.
1458
1459         Format boolean as 1/0 when printing Frame summary to be consistent with the formatting of
1460         booleans in other summary strings, substitute "inMainFrame" for "isMainFrame" in the printed
1461         Document summary and add closing brace '}' to both Frame and Document summary strings to make
1462         them look pretty.
1463
1464         * lldb/lldb_webkit.py:
1465         (WebCoreFrame_SummaryProvider):
1466         (WebCoreDocument_SummaryProvider):
1467
1468 2018-11-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1469
1470         [iOS] Allow WKWebView clients to customize bar button item groups in the accessory view when editing
1471         https://bugs.webkit.org/show_bug.cgi?id=191240
1472         <rdar://problem/44872806>
1473
1474         Reviewed by Tim Horton.
1475
1476         Add new API tests to verify that setting leading and trailing bar button groups on WKWebView sets the first
1477         responder's (i.e. WKContentView's) leading and trailing bar button groups, and that this can also be achieved by
1478         overriding `-[WKWebView inputAssistantItem]`.
1479
1480         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1481         (-[InputAssistantItemTestingWebView fakeLeadingBarButtonItemAction]):
1482         (-[InputAssistantItemTestingWebView fakeTrailingBarButtonItemAction]):
1483         (+[InputAssistantItemTestingWebView barButtonIcon]):
1484         (+[InputAssistantItemTestingWebView leadingItemsForWebView:]):
1485         (+[InputAssistantItemTestingWebView trailingItemsForWebView:]):
1486         (-[InputAssistantItemTestingWebView inputAssistantItem]):
1487         (TestWebKitAPI::TEST):
1488
1489 2018-11-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1490
1491         [iOS] Changing view scale sometimes does not zoom the page to the new initial scale when the page is zoomed in when ignoring meta viewport
1492         https://bugs.webkit.org/show_bug.cgi?id=191226
1493         <rdar://problem/45781765>
1494
1495         Reviewed by Tim Horton.
1496
1497         Add a missing check for `shouldIgnoreMetaViewport` when comparing TestOptions, to ensure that "ignore meta
1498         viewport" state doesn't unexpectedly persist after running a layout test that ignores meta viewport.
1499
1500         * WebKitTestRunner/TestOptions.h:
1501         (WTR::TestOptions::hasSameInitializationOptions const):
1502
1503 2018-11-05  Commit Queue  <commit-queue@webkit.org>
1504
1505         Unreviewed, rolling out r237784 and r237788.
1506         https://bugs.webkit.org/show_bug.cgi?id=191270
1507
1508         Caused mediastream layout test failures (Requested by
1509         ryanhaddad on #webkit).
1510
1511         Reverted changesets:
1512
1513         "[MediaStream] User should not be prompted again after denying
1514         getDisplayMedia request"
1515         https://bugs.webkit.org/show_bug.cgi?id=191227
1516         https://trac.webkit.org/changeset/237784
1517
1518         "[MediaStream] User should not be prompted again after denying
1519         getDisplayMedia request"
1520         https://bugs.webkit.org/show_bug.cgi?id=191227
1521         https://trac.webkit.org/changeset/237788
1522
1523 2018-11-05  Lucas Forschler  <lforschler@apple.com>
1524
1525         https://bugs.webkit.org/show_bug.cgi?id=191268
1526         Remove unused bots.
1527
1528         rubber-stamped by Alexey Proskuryakov.
1529
1530         * BuildSlaveSupport/build.webkit.org-config/config.json:
1531         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1532         (WebKitBuildbot):
1533
1534 2018-11-05  Michael Catanzaro  <mcatanzaro@igalia.com>
1535
1536         [WPE][GTK] API test runner fails to respect default build type
1537         https://bugs.webkit.org/show_bug.cgi?id=190247
1538
1539         Reviewed by Carlos Garcia Campos.
1540
1541         Problem is it's looking for a release build, even though I've run set-webkit-configuration
1542         --debug. It should look for a debug build unless I explicitly pass --release.
1543
1544         * glib/api_test_runner.py:
1545         (TestRunner.__init__):
1546
1547 2018-11-05  Thibault Saunier  <tsaunier@igalia.com>
1548
1549         [GStreamer][WebRTC] Add webrtcencoder bin to cleanup and refactor the way we set encoders
1550         https://bugs.webkit.org/show_bug.cgi?id=190674
1551
1552         Reviewed by Philippe Normand.
1553
1554         webrtcencoder is a simple GstBin with a set of well known GStreamer encoders which
1555         it can use to implement encoding for different formats exposing a trimmed down unified API.
1556
1557         It also adds proper handling of H264 profiles.
1558
1559         The added files follow GStreamer coding style as we aim at upstreaming the element
1560         in the future.
1561
1562         Reviewed by Philippe Normand.
1563
1564         * Scripts/webkitpy/style/checker.py:
1565
1566 2018-11-05  Michael Catanzaro  <mcatanzaro@igalia.com>
1567
1568         [WPE][GTK] API test /webkit/WebKitSettings/webkit-settings is failing
1569         https://bugs.webkit.org/show_bug.cgi?id=191221
1570
1571         Reviewed by Carlos Garcia Campos.
1572
1573         This test ensures that MSE is disabled by default, but we now enable it by default, so
1574         reverse the semantics of the test.
1575
1576         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1577         (testWebKitSettings):
1578
1579 2018-11-05  Michael Catanzaro  <mcatanzaro@igalia.com>
1580
1581         REGRESSION(r237031): [GTK] Test /webkit/WebKitWebView/settings is failing
1582         https://bugs.webkit.org/show_bug.cgi?id=191225
1583
1584         Reviewed by Alejandro G. Castro.
1585
1586         Fix a memory leak causing this test to fail.
1587
1588         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
1589         (WebViewTest::initializeWebView):
1590
1591 2018-11-04  Zan Dobersek  <zdobersek@igalia.com>
1592
1593         [webkitpy] Support WPE in the run-web-platform-tests script
1594         https://bugs.webkit.org/show_bug.cgi?id=191183
1595
1596         Reviewed by Alex Christensen.
1597
1598         * Scripts/webkitpy/w3c/wpt_runner.py:
1599         (parse_args): Support `--wpe` as an argument that specifies WPE as the
1600         target port. Additionally, the `--display-server` flag now accepts
1601         `headless` as a valid value, enabling the WPE WebDriver to run in
1602         headless mode.
1603
1604 2018-11-04  Fujii Hironori  <Hironori.Fujii@sony.com>
1605
1606         [Win] Use C++14, not C++17
1607         https://bugs.webkit.org/show_bug.cgi?id=191101
1608
1609         Reviewed by Alex Christensen.
1610
1611         std::basic_string::data() returns a read-only const buffer in
1612         C++14.
1613
1614         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1615         (createString): Use std::vector instead of std::wstring.
1616         (createUTF8String): Use std::vector instead of std::string.
1617
1618 2018-11-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1619
1620         [Cocoa] Fold common UIScriptController functionality on macOS and iOS into UIScriptControllerCocoa.mm
1621         https://bugs.webkit.org/show_bug.cgi?id=191231
1622
1623         Reviewed by Simon Fraser.
1624
1625         Moves some UIScriptController method implementations specific to iOS and macOS into UIScriptControllerCocoa, so
1626         it can be shared between iOS-family and macOS platforms. See below for more details.
1627
1628         No change in behavior.
1629
1630         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1631         (WTR::UIScriptController::overridePreference):
1632
1633         Add a method stub for DumpRenderTree.
1634
1635         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1636         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1637         (WTR::UIScriptController::doAsyncTask):
1638         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution):
1639
1640         Unify these method implementations.
1641
1642         (WTR::UIScriptController::removeViewFromWindow):
1643         (WTR::UIScriptController::addViewToWindow):
1644
1645         Move the macOS implementation to UIScriptControllerCocoa. On iOS, this method currently only adds the web view
1646         to the window, and does not attempt to invoke the given completion block; additionally, invoking the completion
1647         block after a presentation update (as done on macOS) causes pageoverlay/overlay-remove-reinsert-view.html to
1648         begin failing consistently. This patch does not attempt to change behavior, but adds a FIXME describing this.
1649
1650         (WTR::UIScriptController::overridePreference):
1651         (WTR::UIScriptController::findString):
1652         (WTR::UIScriptController::contentsOfUserInterfaceItem const):
1653
1654         Move these from UIScriptControllerMac to UIScriptControllerCocoa, so that it is now implemented on iOS as well.
1655
1656         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1657         (WTR::UIScriptController::doAsyncTask): Deleted.
1658         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution): Deleted.
1659         (WTR::UIScriptController::contentsOfUserInterfaceItem const): Deleted.
1660         (WTR::UIScriptController::findString): Deleted.
1661         (WTR::UIScriptController::removeViewFromWindow): Deleted.
1662         (WTR::UIScriptController::addViewToWindow): Deleted.
1663         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1664         (WTR::UIScriptController::doAsyncTask): Deleted.
1665         (WTR::UIScriptController::contentsOfUserInterfaceItem const): Deleted.
1666         (WTR::UIScriptController::overridePreference): Deleted.
1667         (WTR::UIScriptController::findString): Deleted.
1668         (WTR::UIScriptController::removeViewFromWindow): Deleted.
1669         (WTR::UIScriptController::addViewToWindow): Deleted.
1670         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution): Deleted.
1671
1672 2018-11-04  Eric Carlson  <eric.carlson@apple.com>
1673
1674         [MediaStream] User should not be prompted again after denying getDisplayMedia request
1675         https://bugs.webkit.org/show_bug.cgi?id=191227
1676         <rdar://problem/45784512>
1677
1678         Reviewed by Youenn Fablet.
1679
1680         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
1681         (-[GetDisplayMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
1682         (TestWebKitAPI::GetDisplayMediaTest::promptForCapture):
1683         (TestWebKitAPI::TEST_F):
1684
1685 2018-11-04  Zalan Bujtas  <zalan@apple.com>
1686
1687         [LFC][BFC] Add support for percentage height in quirks mode.
1688         https://bugs.webkit.org/show_bug.cgi?id=191232
1689
1690         Reviewed by Antti Koivisto.
1691
1692         * LayoutReloaded/misc/LFC-passing-tests.txt:
1693
1694 2018-11-04  Zalan Bujtas  <zalan@apple.com>
1695
1696         [LFC][BCF] Add support for block level non-replaced inflow height percentage
1697         https://bugs.webkit.org/show_bug.cgi?id=191229
1698
1699         Reviewed by Antti Koivisto.
1700
1701         * LayoutReloaded/misc/LFC-passing-tests.txt:
1702
1703 2018-11-02  Zalan Bujtas  <zalan@apple.com>
1704
1705         [LFC][BFC] Resolve percentage height values.
1706         https://bugs.webkit.org/show_bug.cgi?id=191224
1707
1708         Reviewed by Antti Koivisto.
1709
1710         * LayoutReloaded/misc/LFC-passing-tests.txt:
1711
1712 2018-11-03  Alex Christensen  <achristensen@webkit.org>
1713
1714         Mac production builds should sign the network process xpc service with entitlements
1715         https://bugs.webkit.org/show_bug.cgi?id=191209
1716         <rdar://problem/45377609>
1717
1718         Reviewed by Geoff Garen.
1719
1720         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1721         * TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm: Added.
1722         (TEST):
1723
1724 2018-11-02  Alex Christensen  <achristensen@webkit.org>
1725
1726         Unreviewed, rolling out r237761.
1727
1728         Makes most API tests timeout and WK2 tests crash
1729
1730         Reverted changeset:
1731
1732         "Mac production builds should sign the network process xpc
1733         service with entitlements"
1734         https://bugs.webkit.org/show_bug.cgi?id=191209
1735         https://trac.webkit.org/changeset/237761
1736
1737 2018-11-02  Michael Catanzaro  <mcatanzaro@igalia.com>
1738
1739         Unreviewed API test gardening
1740
1741         * TestWebKitAPI/glib/TestExpectations.json:
1742
1743 2018-11-02  Justin Michaud  <justin_michaud@apple.com>
1744
1745         Add new global object and preliminary Worklets support for CSS painting api
1746         https://bugs.webkit.org/show_bug.cgi?id=190979
1747
1748         Reviewed by Chris Dumez.
1749
1750         * Scripts/webkitpy/bindings/main.py:
1751         (BindingsTests.generate_supplemental_dependency):
1752         (BindingsTests.main):
1753
1754 2018-11-02  Alex Christensen  <achristensen@webkit.org>
1755
1756         Mac production builds should sign the network process xpc service with entitlements
1757         https://bugs.webkit.org/show_bug.cgi?id=191209
1758         <rdar://problem/45377609>
1759
1760         Reviewed by Geoff Garen.
1761
1762         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1763         * TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm: Added.
1764         (TEST):
1765
1766 2018-11-02  Lucas Forschler  <lforschler@apple.com>
1767
1768         Add Windows 10 archive bots
1769         https://bugs.webkit.org/show_bug.cgi?id=190964
1770         
1771         This Change updates the Apple Windows Buildbot configuration.
1772         - Add Windows 10 specific builders and testers for release and debug.
1773         - Refactor Windows -> Windows 7.
1774         - Remove Windows 7 Debug.
1775
1776         Reviewed by Aakash Jain.
1777
1778         * BuildSlaveSupport/build.webkit.org-config/config.json:
1779
1780 2018-11-02  Philippe Normand  <pnormand@igalia.com>
1781
1782         [GTK][WPE] Enable GST_DEBUG_NO_COLOR environment variable pass-through
1783
1784         Rubber-stamped by Michael Catanzaro.
1785
1786         This variable is useful to get rid of shell color escapes in tests stderr files.
1787
1788         * Scripts/webkitpy/port/gtk.py:
1789         (GtkPort.setup_environ_for_server):
1790         * Scripts/webkitpy/port/wpe.py:
1791         (WPEPort.setup_environ_for_server):
1792
1793 2018-11-02  Aakash Jain  <aakash_jain@apple.com>
1794
1795         Add Basic Django web app for OpenSource EWS
1796         https://bugs.webkit.org/show_bug.cgi?id=191091
1797
1798         Reviewed by Lucas Forschler.
1799
1800         * BuildSlaveSupport/EWS_app/manage.py: Added, auto-generated by Django.
1801         * BuildSlaveSupport/EWS_app/EWS_app/__init__.py: Added, auto-generated by Django.
1802         * BuildSlaveSupport/EWS_app/EWS_app/settings.py: Added, auto-generated by Django.
1803         * BuildSlaveSupport/EWS_app/EWS_app/urls.py: Added, auto-generated by Django.
1804         * BuildSlaveSupport/EWS_app/EWS_app/wsgi.py: Added, auto-generated by Django.
1805         * BuildSlaveSupport/EWS_app/ews/__init__.py: Added.
1806         * BuildSlaveSupport/EWS_app/ews/admin.py: Added, auto-generated by Django.
1807         * BuildSlaveSupport/EWS_app/ews/apps.py: Added, auto-generated by Django.
1808         * BuildSlaveSupport/EWS_app/ews/migrations/__init__.py: Added.
1809         * BuildSlaveSupport/EWS_app/ews/tests.py: Added, auto-generated by Django.
1810         * BuildSlaveSupport/EWS_app/ews/models/__init__.py: Added.
1811         * BuildSlaveSupport/EWS_app/ews/models/patch.py: Added.
1812         * BuildSlaveSupport/EWS_app/ews/views/__init__.py: Added.
1813         * BuildSlaveSupport/EWS_app/ews/views/patch.py: Added.
1814
1815 2018-11-02  Daniel Bates  <dabates@apple.com>
1816
1817         [iOS] WebKit should dispatch DOM events when a modifier key is pressed
1818         https://bugs.webkit.org/show_bug.cgi?id=190487
1819
1820         Reviewed by Tim Horton.
1821
1822         Update the code for renamed enumerations. For WebKitTestRunner, removed comment that does not
1823         match my observations when using the simulator to simulate iOS 12 and add support for testing
1824         right-hand side modifiers.
1825
1826         * DumpRenderTree/mac/EventSendingController.mm:
1827         (modifierFlags):
1828         (-[EventSendingController keyDown:withModifiers:withLocation:]):
1829         (-[EventSendingController setTouchModifier:value:]):
1830         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1831         (hidUsageCodeForCharacter):
1832
1833 2018-11-02  Chris Dumez  <cdumez@apple.com>
1834
1835         [PSON] Reuse SuspendedPages' process when possible, for performance
1836         https://bugs.webkit.org/show_bug.cgi?id=191166
1837
1838         Reviewed by Geoffrey Garen.
1839
1840         Add API test coverage.
1841
1842         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1843
1844 2018-11-02  Zalan Bujtas  <zalan@apple.com>
1845
1846         [LFC][IFC] Add support for intrinsic width calculation
1847         https://bugs.webkit.org/show_bug.cgi?id=191144
1848
1849         Reviewed by Antti Koivisto.
1850
1851         * LayoutReloaded/misc/LFC-passing-tests.txt:
1852
1853 2018-11-01  Philippe Normand  <pnormand@igalia.com>
1854
1855         [Apache] Self-signed SSL certificate RSA key is considered too weak
1856         https://bugs.webkit.org/show_bug.cgi?id=191156
1857
1858         Reviewed by Michael Catanzaro.
1859
1860         * Scripts/webkitpy/common/system/pemfile.py:
1861
1862 2018-11-02  Zan Dobersek  <zdobersek@igalia.com>
1863
1864         Unreviewed follow-up to r237678.
1865
1866         * wpe/jhbuild.modules: The patch element apparently has to be a child
1867         of the branch in order for Jhbuild to properly detect and apply the
1868         patch file.
1869
1870 2018-11-01  Ross Kirsling  <ross.kirsling@sony.com>
1871
1872         build-jsc --wincairo should update WinCairo libraries
1873         https://bugs.webkit.org/show_bug.cgi?id=191170
1874
1875         Reviewed by Fujii Hironori.
1876
1877         * Scripts/build-jsc:
1878
1879 2018-11-01  John Wilander  <wilander@apple.com>
1880
1881         In WebCore::ResourceLoadObserver, use document.sessionID().isEphemeral() when possible and check for page existence when not
1882         https://bugs.webkit.org/show_bug.cgi?id=191119
1883         <rdar://problem/44176965>
1884
1885         Reviewed by Chris Dumez.
1886
1887         This is an API test for a WebKitLegacy WebView that is first closed and then
1888         JavaScript is handed a keyboard event.
1889
1890         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1891         * TestWebKitAPI/Tests/WebKitLegacy/mac/ClosingWebView.mm: Added.
1892         (-[ClosingWebViewThenSendingItAKeyDownEventLoadDelegate webView:didFinishLoadForFrame:]):
1893         (-[KeyboardEventListener handleEvent:]):
1894         (TestWebKitAPI::TEST):
1895
1896 2018-11-01  Sihui Liu  <sihui_liu@apple.com>
1897
1898         Add a storage limit for IndexedDB
1899         https://bugs.webkit.org/show_bug.cgi?id=190598
1900         <rdar://problem/44654715>
1901
1902         Reviewed by Chris Dumez.
1903
1904         Add API for testing.
1905
1906         * DumpRenderTree/TestRunner.cpp:
1907         (setIDBPerOriginQuotaCallback):
1908         (TestRunner::staticFunctions):
1909         * DumpRenderTree/TestRunner.h:
1910         * DumpRenderTree/mac/TestRunnerMac.mm:
1911         (TestRunner::setIDBPerOriginQuota):
1912         * DumpRenderTree/win/TestRunnerWin.cpp:
1913         (TestRunner::setIDBPerOriginQuota):
1914         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1915         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1916         (WTR::TestRunner::setIDBPerOriginQuota):
1917         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1918         * WebKitTestRunner/TestController.cpp:
1919         (WTR::TestController::setIDBPerOriginQuota):
1920         * WebKitTestRunner/TestController.h:
1921         * WebKitTestRunner/TestInvocation.cpp:
1922         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1923
1924 2018-11-01  Chris Dumez  <cdumez@apple.com>
1925
1926         [PSON] WebPageProxy::receivedNavigationPolicyDecision() should not schedule the new load asynchronously when process-swapping
1927         https://bugs.webkit.org/show_bug.cgi?id=191076
1928
1929         Reviewed by Geoffrey Garen.
1930
1931         Add API test coverage.
1932
1933         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1934         (-[PSONNavigationDelegate init]):
1935         (-[PSONNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1936
1937 2018-11-01  Adrian Perez de Castro  <aperez@igalia.com>
1938
1939         Fix build with VIDEO and WEB_AUDIO disabled
1940         https://bugs.webkit.org/show_bug.cgi?id=191147
1941         <rdar://problem/45726710>
1942
1943         Unreviewed build fix.
1944
1945         This adds the missing compilation guards in the WPE MiniBrowser.
1946
1947         * MiniBrowser/wpe/main.cpp:
1948         (main): Condition GST includes and calls.
1949
1950 2018-10-31  Zalan Bujtas  <zalan@apple.com>
1951
1952         [LFC][IFC] Add support for inline-block elements.
1953         https://bugs.webkit.org/show_bug.cgi?id=191143
1954
1955         Reviewed by Antti Koivisto.
1956
1957         * LayoutReloaded/misc/LFC-passing-tests.txt:
1958
1959 2018-11-01  Claudio Saavedra  <csaavedra@igalia.com>
1960
1961         [WPE] Add missing libsoup patch to jhbuild
1962         https://bugs.webkit.org/show_bug.cgi?id=191149
1963
1964         Reviewed by Žan Doberšek.
1965
1966         * wpe/jhbuild.modules:
1967         * wpe/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch: Added.
1968
1969 2018-11-01  Claudio Saavedra  <csaavedra@igalia.com>
1970
1971         Fix build with VIDEO and WEB_AUDIO disabled
1972         https://bugs.webkit.org/show_bug.cgi?id=191147
1973
1974         Reviewed by Philippe Normand.
1975
1976         * MiniBrowser/gtk/main.c:
1977         (main): Condition GST includes and calls
1978
1979 2018-10-31  Justin Michaud  <justin_michaud@apple.com>
1980
1981         Add Justin Michaud to the list of WebKit Committers
1982         https://bugs.webkit.org/show_bug.cgi?id=191142
1983
1984         * Scripts/webkitpy/common/config/contributors.json:
1985
1986 2018-10-31  Guillaume Emont  <guijemont@igalia.com>
1987
1988         Don't run JIT tests on 32-bit platforms
1989         https://bugs.webkit.org/show_bug.cgi?id=191074
1990
1991         Reviewed by Michael Catanzaro.
1992
1993         * Scripts/run-jsc-stress-tests:
1994
1995 2018-10-30  Wenson Hsieh  <wenson_hsieh@apple.com>
1996
1997         [Cocoa] Attachment dropped from one web view to another is missing its file wrapper
1998         https://bugs.webkit.org/show_bug.cgi?id=190530
1999         <rdar://problem/45232149>
2000
2001         Reviewed by Tim Horton.
2002
2003         Add a test to verify that copying different types of attachments and pasting in a new web view inserts
2004         attachments in the second web view that are backed by _WKAttachment objects, whose NSFileWrappers hold data that
2005         is equivalent to the original file wrappers used to insert attachments in the first web view.
2006
2007         Existing API tests verify that when copying and pasting within a single web view, the pasted attachment element
2008         is still backed by the same NSFileWrapper instance.
2009
2010         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2011         (TestWebKitAPI::TEST):
2012
2013 2018-10-30  Fujii Hironori  <Hironori.Fujii@sony.com>
2014
2015         [Win] Remove obsolete code for Visual Studio Express in webkitdirs.pm
2016         https://bugs.webkit.org/show_bug.cgi?id=190949
2017
2018         Reviewed by Alex Christensen.
2019
2020         Visual Studio 2017 Community is the alternative.
2021
2022         * Scripts/webkitdirs.pm: Remove $willUseVCExpressWhenBuilding variable.
2023         (setupCygwinEnv): Remove obsolete code for Visual Studio Express.
2024         (buildVisualStudioProject): Ditto.
2025         (dieIfWindowsPlatformSDKNotInstalled): Deleted.
2026         (usingVisualStudioExpress): Deleted.
2027
2028 2018-10-30  Fujii Hironori  <Hironori.Fujii@sony.com>
2029
2030         [Win][Direct2D] Support building DumpRenderTree for Direct2D
2031         https://bugs.webkit.org/show_bug.cgi?id=191093
2032         <rdar://problem/45685706>
2033
2034         Unreviewed build fix.
2035
2036         error C2065: 'renderTarget': undeclared identifier
2037
2038         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
2039         (createBitmapContextFromWebView): Restored the previous implementation.
2040
2041 2018-10-30  Don Olmstead  <don.olmstead@sony.com>
2042
2043         [PlayStation] Enable JavaScriptCore
2044         https://bugs.webkit.org/show_bug.cgi?id=191072
2045
2046         Reviewed by Brent Fulgham.
2047
2048         Add platform scripts for building the PlayStation port.
2049         perl Tools/Scripts/build-webkit --playstation
2050
2051         * Scripts/build-webkit:
2052         * Scripts/build-webkittestrunner:
2053         * Scripts/webkitdirs.pm:
2054         (argumentsForConfiguration):
2055         (determineConfigurationProductDir):
2056         (isPlayStation): Added.
2057         (getMSBuildPlatformArgument): Added.
2058         (buildVisualStudioProject):
2059         (wrapperPrefixIfNeeded):
2060         (generateBuildSystemFromCMakeProject):
2061         * TestWebKitAPI/PlatformPlayStation.cmake: Added.
2062
2063 2018-10-30  Brent Fulgham  <bfulgham@apple.com>
2064
2065         [Win][Direct2D] Support building DumpRenderTree for Direct2D
2066         https://bugs.webkit.org/show_bug.cgi?id=191093
2067         <rdar://problem/45685706>
2068
2069         Reviewed by Alex Christensen.
2070
2071         * DumpRenderTree/PixelDumpSupport.cpp: Update for Direct2D use.
2072         * DumpRenderTree/PlatformWin.cmake: Add support for Direct2D build.
2073         * DumpRenderTree/win/PixelDumpSupportDirect2D.cpp: Added.
2074         (pixelDumpSystemFactory): Added.
2075         (printPNG): Create stub.
2076         (computeMD5HashStringForBitmapContext): Ditto.
2077         (dumpBitmap): Ditto.
2078         * DumpRenderTree/win/PixelDumpSupportDirect2D.h: Added.
2079         (BitmapContext::createByAdoptingBitmapAndContext):
2080         (BitmapContext::~BitmapContext):
2081         (BitmapContext::platformContext const):
2082         (BitmapContext::BitmapContext):
2083         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
2084         (createBitmapContextFromWebView): Update to support Direct2D.
2085         * MiniBrowser/win/MiniBrowserReplace.h: Drive-by fix: The old WebKit
2086         logo is no longer available at this location. Switch to the new logo.
2087
2088 2018-10-30  Jonathan Bedard  <jbedard@apple.com>
2089
2090         webkitpy: Support alternate simctl list outputs
2091         https://bugs.webkit.org/show_bug.cgi?id=191090
2092         <rdar://problem/45684255>
2093
2094         Rubber-stamped by Aakash Jain.
2095
2096         * Scripts/webkitpy/xcode/simulated_device.py:
2097         (SimulatedDeviceManager._create_runtimes): Support alternative availability format.
2098         (SimulatedDeviceManager._create_device_with_runtime): Ditto.
2099         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
2100         (test_available_devices): Add iOS 12 with alternative availability format.
2101
2102 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
2103
2104         Clean up some obsolete MAX_ALLOWED macros
2105         https://bugs.webkit.org/show_bug.cgi?id=190916
2106
2107         Reviewed by Tim Horton.
2108
2109         * TestWebKitAPI/Tests/WTF/darwin/WeakLinking.cpp:
2110         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
2111         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2112
2113 2018-10-30  Claudio Saavedra  <csaavedra@igalia.com>
2114
2115         [GTK][WPE] Fixes to the PublicSuffix implementation
2116         https://bugs.webkit.org/show_bug.cgi?id=191031
2117
2118         Reviewed by Michael Catanzaro.
2119
2120         * TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp:
2121         (TestWebKitAPI::TEST_F): Remove a test for a domain
2122         that is not registrable and shouldn't be tested there.
2123
2124 2018-10-29  Tim Horton  <timothy_horton@apple.com>
2125
2126         Modernize WebKit nibs and lprojs for localization's sake
2127         https://bugs.webkit.org/show_bug.cgi?id=190911
2128         <rdar://problem/45349466>
2129
2130         Reviewed by Dan Bernstein.
2131
2132         * Scripts/check-inspector-strings:
2133         * Scripts/update-webkit-localizable-strings:
2134         * gtk/manifest.txt.in:
2135         * wpe/manifest.txt.in:
2136         English->en
2137
2138 2018-10-29  Daniel Bates  <dabates@apple.com>
2139
2140         [lldb-webkit] Last aliased enumerator in OptionSet is printed; should print first enumerator
2141         https://bugs.webkit.org/show_bug.cgi?id=191036
2142
2143         Reviewed by Andy Estes.
2144
2145         Prefer the first enumerator (in parse order) when pretty-printing an OptionSet that is parameterized
2146         by an enum that contains two or more enumerators with the same value. For example, suppose
2147         you have the following enum:
2148
2149         enum Flag {
2150             A = 1 << 0,
2151             AAlias = A,
2152         };
2153
2154         Then pretty-printing OptionSet<Flag>(Flag::A) should print A instead of AAlias. A side effect of
2155         this change is that OptionSet<Flag>(Flag::AAlias) will also print A as its only member as we cannot
2156         differentiate between A and Alias. This should be acceptable in practice as aliased enumerators
2157         tend to be used in bounds checks as opposed to code that adds to a set.
2158
2159         * lldb/lldbWebKitTester/main.cpp:
2160         (testSummaryProviders):
2161         * lldb/lldb_webkit.py:
2162         (WTFOptionSetProvider.update):
2163         * lldb/lldb_webkit_unittest.py:
2164         (TestSummaryProviders.serial_test_WTFOptionSetProvider_simple):
2165         (TestSummaryProviders):
2166         (TestSummaryProviders.serial_test_WTFOptionSetProvider_aliased_flag):
2167
2168 2018-10-29  Daniel Bates  <dabates@apple.com>
2169
2170         [llbd-webkit] Add summaries for Document, Frame, and SecurityOrigin
2171         https://bugs.webkit.org/show_bug.cgi?id=191033
2172
2173         Reviewed by Andy Estes.
2174
2175         For Documents we display its origin, URL, whether it's in the main frame, and its page cache state.
2176         We display the same details in the summary for a Frame because its Document tends to be the most
2177         interesting aspect of it. For SecurityOrigin we display its origin, domain (affects cookie access),
2178         and whether the origin has universal access.
2179
2180         * lldb/lldb_webkit.py:
2181         (__lldb_init_module):
2182         Register new summary providers.
2183
2184         (WebCoreSecurityOrigin_SummaryProvider):
2185         (WebCoreFrame_SummaryProvider):
2186         (WebCoreDocument_SummaryProvider):
2187         Add new summary providers.
2188
2189         (StdOptionalWrapper):
2190         (StdOptionalWrapper.__init__):
2191         (StdOptionalWrapper.has_value):
2192         (StdOptionalWrapper.value):
2193         Convenience data type that provides access to the fields of a std::optional<>.
2194         
2195         (WebCoreSecurityOriginProvider):
2196         (WebCoreSecurityOriginProvider.__init__):
2197         (WebCoreSecurityOriginProvider.is_unique):
2198         (WebCoreSecurityOriginProvider.scheme):
2199         (WebCoreSecurityOriginProvider.host):
2200         (WebCoreSecurityOriginProvider.port):
2201         (WebCoreSecurityOriginProvider.domain):
2202         (WebCoreSecurityOriginProvider.has_universal_access):
2203         (WebCoreSecurityOriginProvider.to_string):
2204         (WebCoreFrameProvider):
2205         (WebCoreFrameProvider.__init__):
2206         (WebCoreFrameProvider.is_main_frame):
2207         (WebCoreFrameProvider.document):
2208         (WebCoreDocumentProvider):
2209         (WebCoreDocumentProvider.__init__):
2210         (WebCoreDocumentProvider.url):
2211         (WebCoreDocumentProvider.origin):
2212         (WebCoreDocumentProvider.page_cache_state):
2213         (WebCoreDocumentProvider.frame):
2214
2215 2018-10-29  Chris Dumez  <cdumez@apple.com>
2216
2217         [PSON] When Safari restores session state after launching, going back and forward does not swap processes
2218         https://bugs.webkit.org/show_bug.cgi?id=190975
2219         <rdar://problem/45059256>
2220
2221         Reviewed by Antti Koivisto.
2222
2223         Add API test coverage.
2224
2225         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2226
2227 2018-10-29  Zalan Bujtas  <zalan@apple.com>
2228
2229         [LFC][IFC] Compute estimated margin top for inline formatting root's ancestors
2230         https://bugs.webkit.org/show_bug.cgi?id=191018
2231
2232         Reviewed by Antti Koivisto.
2233
2234         * LayoutReloaded/misc/LFC-passing-tests.txt:
2235
2236 2018-10-29  Zalan Bujtas  <zalan@apple.com>
2237
2238         [LFC] Add support for inflow non replaced content height when the box is an inline formatting root.
2239         https://bugs.webkit.org/show_bug.cgi?id=191011
2240
2241         Reviewed by Antti Koivisto.
2242
2243         * LayoutReloaded/misc/LFC-passing-tests.txt:
2244
2245 2018-10-29  Zalan Bujtas  <zalan@apple.com>
2246
2247         Missing from r237549
2248
2249         Reviewed by Antti Koivisto.
2250
2251         * LayoutReloaded/misc/LFC-passing-tests.txt:
2252
2253 2018-10-29  Zalan Bujtas  <zalan@apple.com>
2254
2255         [LFC][IFC] Add support for simple intruding floats.
2256         https://bugs.webkit.org/show_bug.cgi?id=190998
2257
2258         Reviewed by Antti Koivisto.
2259
2260         * LayoutReloaded/misc/LFC-passing-tests.txt:
2261
2262 2018-10-29  Zalan Bujtas  <zalan@apple.com>
2263
2264         [LFC][IFC] Inline layout produces separate runs when float is present.
2265         https://bugs.webkit.org/show_bug.cgi?id=190980
2266
2267         Reviewed by Antti Koivisto.
2268
2269         * LayoutReloaded/misc/LFC-passing-tests.txt:
2270
2271 2018-10-29  Tadeu Zagallo  <tzagallo@apple.com>
2272
2273         New bytecode format for JSC
2274         https://bugs.webkit.org/show_bug.cgi?id=187373
2275         <rdar://problem/44186758>
2276
2277         Reviewed by Filip Pizlo.
2278
2279         Do not force ENABLE_JIT=true when $forceCLoop is false.
2280
2281         * Scripts/build-jsc:
2282
2283 2018-10-29  Claudio Saavedra  <csaavedra@igalia.com>
2284
2285         [GTK] Try to fix the xserver-xorg build in the Ubuntu LTS bot
2286
2287         Unreviewed build fix
2288
2289         The build fails because of some array-bound check related
2290         to strcmp() macro optimizations. Disabling selective Werrors
2291         when building xserver-xorg might get past this.
2292
2293         * gtk/jhbuild.modules: Add --disable-selective-werror to xserver-xorg
2294         configuration.
2295
2296 2018-10-29  Claudio Saavedra  <csaavedra@igalia.com>
2297
2298         [GTK] Update API test expectations after r237383
2299         https://bugs.webkit.org/show_bug.cgi?id=186913
2300
2301         Unreviewed gardening.
2302
2303         * TestWebKitAPI/glib/TestExpectations.json: Remove
2304         passing TestSSL tests.
2305
2306 2018-10-28  Zan Dobersek  <zdobersek@igalia.com>
2307
2308         [WPE] Add the WebKitVersion.h header
2309         https://bugs.webkit.org/show_bug.cgi?id=191015
2310
2311         Reviewed by Michael Catanzaro.
2312
2313         * MiniBrowser/wpe/main.cpp:
2314         (automationStartedCallback): Remove the FIXME and finally enable the
2315         webkit_application_info_set_version() call.
2316         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp: Remove
2317         this FIXME as well and remove the custom WEBKIT_*_VERSION macros.
2318
2319 2018-10-28  Fujii Hironori  <Hironori.Fujii@sony.com>
2320
2321         [Win] Remove obsolete code for vcxproj builds in build-api-tests and build-jsc
2322         https://bugs.webkit.org/show_bug.cgi?id=190948
2323
2324         Reviewed by Brent Fulgham.
2325
2326         vcxproj files have been removed in Bug 154388.
2327
2328         * Scripts/build-api-tests: Removed obsolete code to build vcproj.
2329         * Scripts/build-jsc:
2330         (buildMyProject): Ditto. Removed a condition of buiding bmalloc
2331         which is not used because Windows ports are using CMake.
2332
2333 2018-10-28  Geoffrey Garen  <ggaren@apple.com>
2334
2335         HashMap should support selecting a random entry
2336         https://bugs.webkit.org/show_bug.cgi?id=190814
2337
2338         Reviewed by Ryosuke Niwa.
2339
2340         * TestWebKitAPI/Tests/WTF/HashMap.cpp: Renamed IsRandom to
2341         IsEvenlyDistributed to reflect the fact that we're only testing the
2342         distribution. Added a test case that covers more table densities and
2343         the remove() operation.
2344
2345 2018-10-27  Charlie Turner  <cturner@igalia.com>
2346
2347         [GTK] Add bubblewrap feature option
2348         https://bugs.webkit.org/show_bug.cgi?id=190981
2349
2350         Reviewed by Xabier Rodriguez-Calvar.
2351
2352         Without this, it was not possible to disable the bubblewrap sandbox
2353         from the webkit build scripts.
2354
2355         * Scripts/webkitperl/FeatureList.pm:
2356
2357 2018-10-26  Commit Queue  <commit-queue@webkit.org>
2358
2359         Unreviewed, rolling out r237479 and r237484.
2360         https://bugs.webkit.org/show_bug.cgi?id=190978
2361
2362         broke JSC on iOS (Requested by tadeuzagallo on #webkit).
2363
2364         Reverted changesets:
2365
2366         "New bytecode format for JSC"
2367         https://bugs.webkit.org/show_bug.cgi?id=187373
2368         https://trac.webkit.org/changeset/237479
2369
2370         "Gardening: Build fix after r237479."
2371         https://bugs.webkit.org/show_bug.cgi?id=187373
2372         https://trac.webkit.org/changeset/237484
2373
2374 2018-10-26  Tadeu Zagallo  <tzagallo@apple.com>
2375
2376         New bytecode format for JSC
2377         https://bugs.webkit.org/show_bug.cgi?id=187373
2378         <rdar://problem/44186758>
2379
2380         Reviewed by Filip Pizlo.
2381
2382         Do not force ENABLE_JIT=true when $forceCLoop is false.
2383
2384         * Scripts/build-jsc:
2385
2386 2018-10-26  Geoffrey Garen  <ggaren@apple.com>
2387
2388         HashMap should support selecting a random entry
2389         https://bugs.webkit.org/show_bug.cgi?id=190814
2390
2391         Reviewed by Antti Koivisto.
2392
2393         * TestWebKitAPI/Tests/WTF/HashMap.cpp: Updated the Random_IsRandom to
2394         more thoroughly test for randomness.
2395
2396 2018-10-26  Antti Koivisto  <antti@apple.com>
2397
2398         hashSet.remove(hashSet.random()) doesn't build
2399         https://bugs.webkit.org/show_bug.cgi?id=190953
2400
2401         Reviewed by Chris Dumez.
2402
2403         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
2404         (TestWebKitAPI::TEST):
2405
2406 2018-10-26  Zalan Bujtas  <zalan@apple.com>
2407
2408         [LFC][IFC] Layout floats as part of the inline content
2409         https://bugs.webkit.org/show_bug.cgi?id=190942
2410
2411         Reviewed by Antti Koivisto.
2412
2413         * LayoutReloaded/misc/LFC-passing-tests.txt:
2414
2415 2018-10-26  Alicia Boya García  <aboya@igalia.com>
2416
2417         [MSE][WTF][Media] Invalid MediaTime should be falsy
2418         https://bugs.webkit.org/show_bug.cgi?id=190893
2419
2420         Reviewed by Jer Noble.
2421
2422         This patch adds additional API tests for the conversions from
2423         MediaTime to boolean.
2424
2425         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
2426         (TestWebKitAPI::TEST):
2427
2428 2018-10-25  Chris Dumez  <cdumez@apple.com>
2429
2430         [PSON] Navigating cross-site with locked history but unlocked back/forward list fails to create a new BackForwardListItem
2431         https://bugs.webkit.org/show_bug.cgi?id=190915
2432         <rdar://problem/45059069>
2433
2434         Reviewed by Geoffrey Garen.
2435
2436         Add API test coverage.
2437
2438         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2439
2440 2018-10-25  Joseph Pecoraro  <pecoraro@apple.com>
2441
2442         Web Inspector: Add a watchlist message rule to warn about feature checking new inspector protocol changes
2443         https://bugs.webkit.org/show_bug.cgi?id=190896
2444
2445         Reviewed by Matt Baker.
2446
2447         * Scripts/webkitpy/common/config/watchlist:
2448
2449 2018-10-25  Geoffrey Garen  <ggaren@apple.com>
2450
2451         HashMap should support selecting a random entry
2452         https://bugs.webkit.org/show_bug.cgi?id=190814
2453
2454         Reviewed by Antti Koivisto.
2455
2456         Unit testing is fun and easy!
2457
2458         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
2459         (TestWebKitAPI::ZeroHash::hash):
2460         (TestWebKitAPI::TEST):
2461
2462 2018-10-24  Tim Horton  <timothy_horton@apple.com>
2463
2464         REGRESSION (r237331): DismissingActionSheetShouldNotDismissPresentingViewController times out
2465         https://bugs.webkit.org/show_bug.cgi?id=190897
2466
2467         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
2468         (TestWebKitAPI::TEST):
2469         Disable the test for now.
2470
2471 2018-10-24  Alexey Proskuryakov  <ap@apple.com>
2472
2473         Clean up some obsolete macOS version guards
2474         https://bugs.webkit.org/show_bug.cgi?id=190887
2475
2476         Reviewed by Dan Bernstein.
2477
2478         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2479         (__simulated_forceClickAssociatedEventsMask):
2480         (-[TestWKWebViewHostWindow _mouseDownAtPoint:simulatePressure:clickCount:]):
2481         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2482         (WTR::initializeWebViewConfiguration):
2483         * WebKitTestRunner/mac/EventSenderProxy.mm:
2484         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
2485
2486 2018-10-24  Megan Gardner  <megan_gardner@apple.com>
2487
2488         Turn on Conic Gradients
2489         https://bugs.webkit.org/show_bug.cgi?id=190810
2490
2491         Reviewed by Tim Horton.
2492
2493         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2494
2495 2018-10-24  Pablo Saavedra  <psaavedra@igalia.com>
2496
2497         [WPE] Fix CMake rules in for TestWebKitAPIBase library building in developer mode
2498         https://bugs.webkit.org/show_bug.cgi?id=190328
2499
2500         Reviewed by Michael Catanzaro.
2501
2502         * TestWebKitAPI/CMakeLists.txt:
2503         * TestWebKitAPI/PlatformWPE.cmake:
2504
2505 2018-10-24  Chris Dumez  <cdumez@apple.com>
2506
2507         [PSON] When navigating back and forth, 'about:blank' shows up in the back/forward list
2508         https://bugs.webkit.org/show_bug.cgi?id=190846
2509         <rdar://problem/45058938>
2510
2511         Reviewed by Antti Koivisto.
2512
2513         Add API test coverage.
2514
2515         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2516
2517 2018-10-24  Claudio Saavedra  <csaavedra@igalia.com>
2518
2519         [GTK] TestSSL failing because of missing libsoup patch
2520         https://bugs.webkit.org/show_bug.cgi?id=190869
2521
2522         Reviewed by Michael Catanzaro.
2523
2524         * gtk/jhbuild.modules: Add the patch below to fix the API test TestSSL
2525         * gtk/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch: Added.
2526
2527 2018-10-23  Justin Fan  <justin_fan@apple.com>
2528
2529         [WebGPU] Rename old GPU* implementation files to GPULegacy* for WebMetal
2530         https://bugs.webkit.org/show_bug.cgi?id=190817
2531
2532         Reviewed by Dean Jackson.
2533
2534         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2535         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/GPUBuffer.mm.
2536         (TestWebKitAPI::TEST_F):
2537         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Copied from Tools/TestWebKitAPI/Tests/WebCore/mac/GPUFunction.mm.
2538         (TestWebKitAPI::TEST_F):
2539         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/GPUDevice.mm.
2540         (TestWebKitAPI::TEST_F):
2541         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/GPUFunction.mm.
2542         (TestWebKitAPI::TEST_F):
2543         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/GPULibrary.mm.
2544         (TestWebKitAPI::TEST_F):
2545         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/GPUTest.h.
2546
2547 2018-10-23  Chris Dumez  <cdumez@apple.com>
2548
2549         [PSON] Add support for cross-site client-side redirects
2550         https://bugs.webkit.org/show_bug.cgi?id=190806
2551         <rdar://problem/45047344>
2552
2553         Reviewed by Geoffrey Garen.
2554
2555         Add API test coverage.
2556
2557         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2558         (-[PSONNavigationDelegate _webView:willPerformClientRedirectToURL:delay:]):
2559         (-[PSONNavigationDelegate _webView:didPerformClientRedirectFromURL:toURL:]):
2560
2561 2018-10-23  Claudio Saavedra  <csaavedra@igalia.com>
2562
2563         [WPE][GTK] Pass full certificate chain in CertificateInfo coder
2564         https://bugs.webkit.org/show_bug.cgi?id=190789
2565
2566         Reviewed by Michael Catanzaro.
2567
2568         When the network process serializes certificate data to other
2569         processes through the argument coders, the certificate chain, if
2570         present, is lost. In practice this means that applications using
2571         the public API to process certificate info have no details on the
2572         certificate chain, other than the very basics included in the
2573         certificate. Serialize the entire chain if available in the
2574         certificate.
2575
2576         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
2577         (testSSL): Test that the self-signed certificate has no bogus
2578         issuer certificate.
2579
2580 2018-10-22  Tim Horton  <timothy_horton@apple.com>
2581
2582         REGRESSION (r237331): InteractionDeadlockAfterCrash API test fails
2583         https://bugs.webkit.org/show_bug.cgi?id=190801
2584         <rdar://problem/43674361>
2585
2586         * TestWebKitAPI/Tests/WebKitCocoa/InteractionDeadlockAfterCrash.mm:
2587         (TEST):
2588         Use a parented WKWebView for this test, otherwise none of the assertions
2589         about gesture recognizers work anymore.
2590
2591 2018-10-22  Ryan Haddad  <ryanhaddad@apple.com>
2592
2593         REGRESSION (r234081): TestWebKitAPI.VideoControlsManager.VideoControlsManagerAudioElementFollowingUserInteraction is a flaky timeout
2594         https://bugs.webkit.org/show_bug.cgi?id=187972
2595
2596         Unreviewed test gardening.
2597
2598         * TestWebKitAPI/Tests/WebKitCocoa/VideoControlsManager.mm:
2599         (TestWebKitAPI::TEST): Disable the flaky test.
2600
2601 2018-10-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2602
2603         [iOS] [Datalist] fast/forms/datalist/datalist-show-hide.html fails
2604         https://bugs.webkit.org/show_bug.cgi?id=190777
2605
2606         Reviewed by Tim Horton.
2607
2608         Implement isShowingDataListSuggestions on iOS. See below for more details.
2609
2610         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2611         (WTR::UIScriptController::isShowingDataListSuggestions const):
2612
2613         Add a stub implementation for DumpRenderTree.
2614
2615         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2616         (WTR::UIScriptController::isShowingDataListSuggestions const):
2617
2618         Move this stub implementation to !PLATFORM(COCOA).
2619
2620         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2621         (WTR::forEachViewInHierarchy):
2622
2623         Add a helper function to apply a given function to a UIView and each of its subviews, recursively.
2624
2625         (WTR::UIScriptController::isShowingDataListSuggestions const):
2626
2627         For iOS, return whether the UIRemoteKeyboardWindow contains a subview of type WKDataListSuggestionsPickerView.
2628
2629 2018-10-19  Dan Bernstein  <mitz@apple.com>
2630
2631         [macOS] MiniBrowser has an unused injected bundle
2632         https://bugs.webkit.org/show_bug.cgi?id=190770
2633
2634         Reviewed by Tim Horton.
2635
2636         * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig: Removed.
2637         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Removed the MiniBrowserBundle target,
2638           the Copy Bundle build phase in the MiniBrowser target, and references to removed files.
2639         * MiniBrowser/MiniBrowserWebProcessPlugIn.h: Removed.
2640         * MiniBrowser/MiniBrowserWebProcessPlugIn.m: Removed.
2641         * MiniBrowser/mac/Bundle: Removed.
2642
2643 2018-10-19  Wenson Hsieh  <wenson_hsieh@apple.com>
2644
2645         [iOS] [Datalist] Can't pick datalist suggestions in a stock WKWebView
2646         https://bugs.webkit.org/show_bug.cgi?id=190621
2647         <rdar://problem/45310649>
2648
2649         Reviewed by Tim Horton.
2650
2651         Add a UIScriptController hook to resign first responder on WKWebView. See LayoutTests/ChangeLog for more detail.
2652
2653         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2654         (WTR::UIScriptController::resignFirstResponder):
2655         * DumpRenderTree/mac/UIScriptControllerMac.mm:
2656         (WTR::UIScriptController::resignFirstResponder):
2657         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2658         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2659         (WTR::UIScriptController::resignFirstResponder):
2660         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2661         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2662         (WTR::UIScriptController::resignFirstResponder):
2663         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2664         (WTR::PlatformWebView::makeWebViewFirstResponder):
2665
2666         Implement this method stub on iOS, to ensure that TestController::resetStateToConsistentValues restores first
2667         responder on the WKWebView when running iOS layout tests.
2668
2669         * WebKitTestRunner/ios/TestControllerIOS.mm:
2670         (WTR::TestController::platformResetStateToConsistentValues):
2671
2672         After resigning first responder to dismiss any on-screen keyboard, ensure that we restore first responder.
2673
2674 2018-10-19  Dean Jackson  <dino@apple.com>
2675
2676         ASSERTION FAILED: !frame().animation().hasAnimations() in WebCore::FrameView::didDestroyRenderTree()
2677         https://bugs.webkit.org/show_bug.cgi?id=186946
2678         <rdar://problem/41724248>
2679
2680         Reviewed by Antoine Quint.
2681
2682         If the incoming test has different enableWebAnimationsCSSIntegration options,
2683         then we need to create a new WebView.
2684
2685         * DumpRenderTree/TestOptions.cpp:
2686         (TestOptions::webViewIsCompatibleWithOptions const):
2687
2688 2018-10-19  Charlie Turner  <cturner@igalia.com>
2689
2690         [EME] Fix crash during tracing in  gst_qtdemux_request_protection_context
2691         https://bugs.webkit.org/show_bug.cgi?id=190738
2692
2693         Reviewed by Xabier Rodriguez-Calvar.
2694
2695         Add a GStreamer patch to avoid crashing when the run-time logging
2696         level is TRACE. There was a missing null check which caused many
2697         tests to crash.
2698
2699         * gstreamer/patches/gst-plugins-good-0013-Avoid-warning-when-reporting-about-decryptors.patch: Added.
2700
2701 2018-10-18  Alicia Boya García  <aboya@igalia.com>
2702
2703         [Media] Use nanoseconds as MaximumTimeScale
2704         https://bugs.webkit.org/show_bug.cgi?id=190631
2705
2706         Rebased MediaTime tests covering timescales over the maximum.
2707
2708         Reviewed by Jer Noble.
2709
2710         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
2711         (TestWebKitAPI::TEST):
2712
2713 2018-10-18  Dean Johnson  <dean_johnson@apple.com>
2714
2715         clean-webkit pulls in many unnecessary dependencies in webkitpy
2716         https://bugs.webkit.org/show_bug.cgi?id=190732
2717
2718         Reviewed by Alexey Proskuryakov.
2719
2720         * Scripts/webkitpy/common/host.py:
2721         (Host.__init__): Split out 'bugs', 'bugzilla', and 'web' to only be created when used.
2722         (Host):
2723         (Host.bugs):
2724         (Host.bugzilla):
2725         (Host.web):
2726
2727 2018-10-18  Chris Dumez  <cdumez@apple.com>
2728
2729         [PSON] SuspendedPages do not report meaningful domains in Activity Monitor
2730         https://bugs.webkit.org/show_bug.cgi?id=190721
2731         <rdar://problem/45059699>
2732
2733         Reviewed by Alex Christensen.
2734
2735         Add API test coverage.
2736
2737         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2738
2739 2018-10-18  Alexey Proskuryakov  <ap@apple.com>
2740
2741         Switch from PLATFORM(IOS) to PLATFORM(IOS_FAMILY)
2742         https://bugs.webkit.org/show_bug.cgi?id=190729
2743
2744         Reviewed by Tim Horton.
2745
2746         * DumpRenderTree/AccessibilityController.h:
2747         * DumpRenderTree/AccessibilityTextMarker.h:
2748         * DumpRenderTree/AccessibilityUIElement.cpp:
2749         (AccessibilityUIElement::getJSClass):
2750         * DumpRenderTree/AccessibilityUIElement.h:
2751         * DumpRenderTree/DumpRenderTreeFileDraggingSource.h:
2752         * DumpRenderTree/TestRunner.cpp:
2753         (getSecureEventInputIsEnabledCallback):
2754         (TestRunner::staticFunctions):
2755         (TestRunner::callUIScriptCallback):
2756         * DumpRenderTree/TestRunner.h:
2757         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
2758         * DumpRenderTree/ios/AccessibilityTextMarkerIOS.mm:
2759         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2760         * DumpRenderTree/ios/DumpRenderTreeAppMain.mm:
2761         * DumpRenderTree/ios/DumpRenderTreeBrowserView.mm:
2762         * DumpRenderTree/ios/TextInputControllerIOS.m:
2763         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2764         * DumpRenderTree/mac/AppleScriptController.m:
2765         * DumpRenderTree/mac/DumpRenderTree.mm:
2766         (createWebViewAndOffscreenWindow):
2767         (destroyWebViewAndOffscreenWindow):
2768         (resetWebPreferencesToConsistentValues):
2769         (setDefaultsToConsistentValuesForTesting):
2770         (allocateGlobalControllers):
2771         (releaseGlobalControllers):
2772         (addTestPluginsToPluginSearchPath):
2773         (prepareConsistentTestingEnvironment):
2774         (dumpRenderTree):
2775         (DumpRenderTreeMain):
2776         (dumpFrameAsPDF):
2777         (dumpBackForwardListForAllWindows):
2778         (updateDisplay):
2779         (dump):
2780         (resetWebViewToConsistentStateBeforeTesting):
2781         (runTest):
2782         (displayWebView):
2783         (displayAndTrackRepaintsWebView):
2784         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
2785         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
2786         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2787         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
2788         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2789         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2790         (-[DumpRenderTreeWindow close]):
2791         (-[DumpRenderTreeWindow webView]):
2792         (-[DumpRenderTreeWindow webViewStartedAcceleratedCompositing:]):
2793         * DumpRenderTree/mac/EventSendingController.h:
2794         * DumpRenderTree/mac/EventSendingController.mm:
2795         (+[EventSendingController isSelectorExcludedFromWebScript:]):
2796         (+[EventSendingController webScriptNameForSelector:]):
2797         (-[EventSendingController dealloc]):
2798         (-[EventSendingController currentEventTime]):
2799         (-[EventSendingController clearKillRing]):
2800         (modifierFlags):
2801         (-[EventSendingController mouseDown:withModifiers:]):
2802         (-[EventSendingController scalePageBy:atX:andY:]):
2803         (-[EventSendingController mouseUp:withModifiers:]):
2804         (-[EventSendingController mouseMoveToX:Y:]):
2805         (-[EventSendingController mouseScrollByX:andY:continuously:]):
2806         (-[EventSendingController keyDown:withModifiers:withLocation:]):
2807         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2808         (-[FrameLoadDelegate init]):
2809         (-[FrameLoadDelegate dealloc]):
2810         (-[FrameLoadDelegate processWork:]):
2811         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
2812         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
2813         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
2814         * DumpRenderTree/mac/LayoutTestHelper.m:
2815         * DumpRenderTree/mac/MockGeolocationProvider.mm:
2816         (-[MockGeolocationProvider timerFired]):
2817         * DumpRenderTree/mac/TestRunnerMac.mm:
2818         (TestRunner::setMainFrameIsFirstResponder):
2819         (TestRunner::setAutomaticLinkDetectionEnabled):
2820         (TestRunner::setUseDashboardCompatibilityMode):
2821         (TestRunner::isCommandEnabled):
2822         (TestRunner::inspectorTestStubURL):
2823         (TestRunner::apiTestNewWindowDataLoadBaseURL):
2824         (TestRunner::abortModal):
2825         (TestRunner::setTextDirection):
2826         (TestRunner::addChromeInputField):
2827         (TestRunner::removeChromeInputField):
2828         (TestRunner::focusWebView):
2829         (TestRunner::setBackingScaleFactor):
2830         (TestRunner::imageCountInGeneralPasteboard const):
2831         * DumpRenderTree/mac/UIDelegate.h:
2832         * DumpRenderTree/mac/UIDelegate.mm:
2833         (-[UIDelegate modalWindowWillClose:]):
2834         (-[UIDelegate webViewRunModal:]):
2835         (-[UIDelegate webView:supportsFullScreenForElement:withKeyboard:]):
2836         (-[UIDelegate dealloc]):
2837         * Scripts/check-for-inappropriate-objc-class-names:
2838         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2839         * TestRunnerShared/spi/UIKitTestSPI.h:
2840         * TestWebKitAPI/Tests/WTF/darwin/WeakLinking.cpp:
2841         * TestWebKitAPI/Tests/WebCore/MarkedText.cpp:
2842         (WebCore::operator<<):
2843         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
2844         (TestWebKitAPI::TEST):
2845         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:
2846         (TestWebKitAPI::WebCoreNSURLSessionTest::SetUp):
2847         * TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp:
2848         * TestWebKitAPI/Tests/WebKit/NoHistoryItemScrollToFragment.mm:
2849         (TestWebKitAPI::TEST):
2850         * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
2851         (TestWebKitAPI::TEST):
2852         * TestWebKitAPI/Tests/WebKitCocoa/AdditionalReadAccessAllowedURLs.mm:
2853         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
2854         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegate.mm:
2855         (TEST):
2856         * TestWebKitAPI/Tests/WebKitCocoa/BundleRangeHandle.mm:
2857         (TEST):
2858         * TestWebKitAPI/Tests/WebKitCocoa/BundleRangeHandlePlugIn.mm:
2859         (-[BundleRangeHandlePlugIn webProcessPlugInBrowserContextController:didFinishDocumentLoadForFrame:]):
2860         * TestWebKitAPI/Tests/WebKitCocoa/Coding.mm:
2861         (TEST):
2862         * TestWebKitAPI/Tests/WebKitCocoa/CopyHTML.mm:
2863         * TestWebKitAPI/Tests/WebKitCocoa/CopyURL.mm:
2864         (createWebViewWithCustomPasteboardDataEnabled):
2865         * TestWebKitAPI/Tests/WebKitCocoa/Copying.mm:
2866         (TEST):
2867         * TestWebKitAPI/Tests/WebKitCocoa/DataDetection.mm:
2868         * TestWebKitAPI/Tests/WebKitCocoa/DoAfterNextPresentationUpdateAfterCrash.mm:
2869         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
2870         * TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm:
2871         * TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm:
2872         * TestWebKitAPI/Tests/WebKitCocoa/FixedLayoutSize.mm:
2873         * TestWebKitAPI/Tests/WebKitCocoa/FontAttributes.mm:
2874         * TestWebKitAPI/Tests/WebKitCocoa/Geolocation.mm:
2875         * TestWebKitAPI/Tests/WebKitCocoa/InteractionDeadlockAfterCrash.mm:
2876         * TestWebKitAPI/Tests/WebKitCocoa/LocalStorageClear.mm:
2877         (defaultWebsiteCacheDirectory):
2878         (defaultApplicationCacheDirectory):
2879         (TEST):
2880         * TestWebKitAPI/Tests/WebKitCocoa/NSFileManagerExtras.mm:
2881         * TestWebKitAPI/Tests/WebKitCocoa/NowPlaying.mm:
2882         * TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm:
2883         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm:
2884         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
2885         * TestWebKitAPI/Tests/WebKitCocoa/PasteMixedContent.mm:
2886         (TestWebKitAPI::TEST):
2887         * TestWebKitAPI/Tests/WebKitCocoa/PasteRTFD.mm:
2888         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
2889         * TestWebKitAPI/Tests/WebKitCocoa/RenderedImageWithOptions.mm:
2890         (runTestWithWidth):
2891         * TestWebKitAPI/Tests/WebKitCocoa/RenderedImageWithOptionsPlugIn.mm:
2892         (-[RenderedImageWithOptionsPlugIn renderImageWithWidth:completionHandler:]):
2893         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2894         * TestWebKitAPI/Tests/WebKitCocoa/ShrinkToFit.mm:
2895         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
2896         * TestWebKitAPI/Tests/WebKitCocoa/VisibleContentRect.mm:
2897         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2898         (platformCopyRichTextWithMultipleAttachments):
2899         (platformCopyRichTextWithImage):
2900         (platformCopyPNG):
2901         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
2902         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewTargetForAction.mm:
2903         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
2904         * TestWebKitAPI/Tests/WebKitCocoa/WKPDFViewStablePresentationUpdateCallback.mm:
2905         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
2906         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-leaks.mm:
2907         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
2908         (TEST):
2909         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2910         (TEST):
2911         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2912         (TEST):
2913         * TestWebKitAPI/Tests/WebKitCocoa/_WKInputDelegate.mm:
2914         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
2915         * TestWebKitAPI/Tests/WebKitLegacy/ios/SnapshotViaRenderInContext.mm:
2916         * TestWebKitAPI/Tests/WebKitLegacy/mac/AccessingPastedImage.mm:
2917         * TestWebKitAPI/Tests/ios/AccessibilityTestsIOS.mm:
2918         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
2919         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2920         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
2921         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2922         * TestWebKitAPI/Tests/ios/RenderingProgressTests.mm:
2923         * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
2924         * TestWebKitAPI/Tests/ios/SetTimeoutFunction.mm:
2925         * TestWebKitAPI/Tests/ios/SynchronousTimeoutTests.mm:
2926         * TestWebKitAPI/Tests/ios/TestInputDelegate.h:
2927         * TestWebKitAPI/Tests/ios/TestInputDelegate.mm:
2928         * TestWebKitAPI/Tests/ios/TextAutosizingBoost.mm:
2929         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
2930         * TestWebKitAPI/Tests/ios/WKScrollViewDelegate.mm:
2931         * TestWebKitAPI/Tests/ios/WKScrollViewTests.mm:
2932         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
2933         * TestWebKitAPI/Tests/ios/WKWebViewEditActions.mm:
2934         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
2935         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
2936         (-[WKWebView _test_waitForDidFinishNavigation]):
2937         * TestWebKitAPI/cocoa/TestWKWebView.h:
2938         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2939         * TestWebKitAPI/config.h:
2940         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2941         * TestWebKitAPI/ios/TestWKWebViewController.h:
2942         * TestWebKitAPI/ios/TestWKWebViewController.mm:
2943         * TestWebKitAPI/ios/UIKitSPI.h:
2944         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2945         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2946         (WTR::InjectedBundle::beginTesting):
2947         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
2948         (WTR::TestRunner::inspectorTestStubURL):
2949         * WebKitTestRunner/TestController.cpp:
2950         (WTR::TestController::webProcessName):
2951         (WTR::TestController::networkProcessName):
2952         * WebKitTestRunner/TestInvocation.cpp:
2953         (WTR::TestInvocation::invoke):
2954         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2955         * WebKitTestRunner/cg/TestInvocationCG.cpp:
2956         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2957         (WTR::initializeWebViewConfiguration):
2958         (WTR::TestController::platformCreateWebView):
2959         (WTR::TestController::imageCountInGeneralPasteboard const):
2960         (WTR::TestController::addTestKeyToKeychain):
2961         (WTR::TestController::cleanUpKeychain):
2962         (WTR::TestController::keyExistsInKeychain):
2963         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2964         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2965         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2966
2967 2018-10-18  Chris Dumez  <cdumez@apple.com>
2968
2969         [PSON] Cap number of SuspendedPageProxy objects and allow a WebPageProxy to have more than one
2970         https://bugs.webkit.org/show_bug.cgi?id=190688
2971         <rdar://problem/45354095>
2972
2973         Reviewed by Antti Koivisto.
2974
2975         Extended API test coverage to confirm that:
2976         - We do not accumulate more than 3 suspended processes.
2977         - We can navigate back 3 times and use the page cache for each of these loads.
2978
2979         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2980
2981 2018-10-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2982
2983         Enable the datalist element by default on iOS and macOS
2984         https://bugs.webkit.org/show_bug.cgi?id=190594
2985         <rdar://problem/45281159>
2986
2987         Reviewed by Ryosuke Niwa and Tim Horton.
2988
2989         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2990
2991 2018-10-17  Chris Fleizach  <cfleizach@apple.com>
2992
2993         AX: Certain tags should identify their context to iOS API
2994         https://bugs.webkit.org/show_bug.cgi?id=190622
2995         <rdar://problem/45308194>
2996
2997         Reviewed by Zalan Bujtas.
2998
2999         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3000         (AccessibilityUIElement::stringAttributeValue):
3001         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3002         (WTR::AccessibilityUIElement::stringAttributeValue):
3003
3004 2018-10-16  Sihui Liu  <sihui_liu@apple.com>
3005
3006         Add a switch for Web SQL
3007         https://bugs.webkit.org/show_bug.cgi?id=190271
3008
3009         Reviewed by Ryosuke Niwa.
3010
3011         * WebKitTestRunner/TestController.cpp:
3012         (WTR::TestController::resetPreferencesToConsistentValues):
3013
3014 2018-10-16  Alex Christensen  <achristensen@webkit.org>
3015
3016         Remove InjectedBundleBackForwardList
3017         https://bugs.webkit.org/show_bug.cgi?id=190640
3018
3019         Reviewed by Chris Dumez.
3020
3021         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3022         (WTR::InjectedBundle::dumpBackForwardListsForAllPages):
3023         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3024         (WTR::InjectedBundlePage::prepare):
3025         (WTR::InjectedBundlePage::dumpHistory):
3026         (WTR::hasPrefix): Deleted.
3027         (WTR::compareByTargetName): Deleted.
3028         (WTR::dumpBackForwardListItem): Deleted.
3029         (WTR::InjectedBundlePage::dumpBackForwardList): Deleted.
3030         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3031         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3032         (WTR::TestRunner::clearBackForwardList):
3033
3034 2018-10-16  Dominik Infuehr  <dinfuehr@igalia.com>
3035
3036         Unreviewed, added myself to contributors.json.
3037
3038         * Scripts/webkitpy/common/config/contributors.json:
3039
3040 2018-10-16  Justin Michaud  <justin_michaud@apple.com>
3041
3042         Implement feature flag and bindings for CSS Painting API
3043         https://bugs.webkit.org/show_bug.cgi?id=190237
3044
3045         Reviewed by Ryosuke Niwa.
3046
3047         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3048
3049 2018-10-16  Philippe Normand  <pnormand@igalia.com>
3050
3051         Unreviewed, GTK Ubuntu LTS Jhbuild prospective build fix
3052
3053         * gstreamer/jhbuild.modules:
3054
3055 2018-10-16  Philippe Normand  <pnormand@igalia.com>
3056
3057         [GTK][JHBuild] Disable libmount support in glib
3058
3059         Rubber-stamped by Alejandro G. Castro.
3060
3061         This feature doesn't seem required for our setup.
3062
3063         * gtk/jhbuild.modules:
3064
3065 2018-10-15  Justin Fan  <justin_fan@apple.com>
3066
3067         Add WebGPU 2018 feature flag and experimental feature flag
3068         https://bugs.webkit.org/show_bug.cgi?id=190509
3069
3070         Reviewed by Dean Jackson.
3071
3072         Re-add ENABLE_WEBGPU, an experimental feature flag, and a RuntimeEnabledFeature
3073         for the 2018 WebGPU prototype.
3074
3075         * DumpRenderTree/TestOptions.cpp:
3076         (TestOptions::TestOptions):
3077         * DumpRenderTree/TestOptions.h:
3078         * DumpRenderTree/mac/DumpRenderTree.mm:
3079         (setWebPreferencesForTestOptions):
3080         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3081
3082 2018-10-15  Ryan Haddad  <ryanhaddad@apple.com>
3083
3084         Update bot configuration for Sierra archive queues
3085         https://bugs.webkit.org/show_bug.cgi?id=190605
3086
3087         Reviewed by Aakash Jain.
3088
3089         * BuildSlaveSupport/build.webkit.org-config/config.json:
3090
3091 2018-10-15  Timothy Hatcher  <timothy@apple.com>
3092
3093         Add support for prefers-color-scheme media query
3094         https://bugs.webkit.org/show_bug.cgi?id=190499
3095         rdar://problem/45212025
3096
3097         Reviewed by Dean Jackson.
3098
3099         * Scripts/webkitperl/FeatureList.pm: Added ENABLE_DARK_MODE_CSS as dark-mode-css.
3100         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Added ENABLE_DARK_MODE_CSS.
3101
3102 2018-10-15  Patrick Griffis  <pgriffis@igalia.com>
3103
3104         [JHBuild] Add xdg-dbus-proxy module
3105         https://bugs.webkit.org/show_bug.cgi?id=190589
3106
3107         Reviewed by Michael Catanzaro.
3108
3109         * gtk/jhbuild.modules:
3110
3111 2018-10-15  Patrick Griffis  <pgriffis@igalia.com>
3112
3113         [GTK] Add new sandboxing dependencies to install-dependencies
3114         https://bugs.webkit.org/show_bug.cgi?id=190588
3115
3116         Reviewed by Michael Catanzaro.
3117
3118         * gtk/install-dependencies:
3119
3120 2018-10-15  Chris Dumez  <cdumez@apple.com>
3121
3122         Experiment: target=_blank on anchors should imply rel=noopener
3123         https://bugs.webkit.org/show_bug.cgi?id=190481
3124
3125         Reviewed by Alex Christensen.
3126
3127         Add API test coverage to make sure we can now swap process when target=_blank
3128         is specified on an anchor but rel=noopener is not.
3129
3130         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3131
3132 2018-10-15  Wenson Hsieh  <wenson_hsieh@apple.com>
3133
3134         [iOS] Can't select text after dismissing the keyboard when changing focus
3135         https://bugs.webkit.org/show_bug.cgi?id=190563
3136         <rdar://problem/44613559>
3137
3138         Reviewed by Tim Horton.
3139
3140         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3141         (WTR::UIScriptController::isShowingKeyboard const):
3142
3143         Add a new UIScriptController method that returns whether the keyboard is shown. See `ui-helper.js` for more
3144         details.
3145
3146         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3147         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3148         (WTR::UIScriptController::isShowingKeyboard const):
3149         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3150         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3151         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3152
3153         Also rename the `isShowingKeyboard` Objective-C property to the more canonical `showingKeyboard`, with
3154         `isShowingKeyboard` as the getter method.
3155
3156         (-[TestRunnerWKWebView _invokeShowKeyboardCallbackIfNecessary]):
3157         (-[TestRunnerWKWebView _invokeHideKeyboardCallbackIfNecessary]):
3158         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3159         (WTR::UIScriptController::isShowingKeyboard const):
3160
3161 2018-10-15  Ryan Haddad  <ryanhaddad@apple.com>
3162
3163         Unreviewed, fix JSC tests after WebGPUShadingLanguageRI directory was removed in r237115.
3164
3165         * Scripts/run-javascriptcore-tests:
3166         (runJSCStressTests): Remove wsl-tests.yaml.
3167
3168 2018-10-15  Christopher Reid  <chris.reid@sony.com>
3169
3170         [Curl][WinCairo] Add Public Suffix support to WinCairo
3171         https://bugs.webkit.org/show_bug.cgi?id=183060
3172
3173         Reviewed by Alex Christensen.
3174
3175         Share mac's PublicSuffix tests with all ports.
3176
3177         * TestWebKitAPI/PlatformWin.cmake:
3178         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3179         * TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp:
3180         * TestWebKitAPI/Tests/mac/PublicSuffix.mm: Removed.
3181
3182 2018-10-15  Myles C. Maxfield  <mmaxfield@apple.com>
3183
3184         [WHLSL] Migrated WebGPUShadingLanguageRI to the W3C
3185         https://bugs.webkit.org/show_bug.cgi?id=190555
3186
3187         Unreviewed.
3188
3189         Migrated to https://github.com/gpuweb/WHLSL/tree/master/Source
3190
3191         * WebGPUShadingLanguageRI/AddressSpace.js: Removed.
3192         * WebGPUShadingLanguageRI/All.js: Removed.
3193         * WebGPUShadingLanguageRI/AllocateAtEntryPoints.js: Removed.
3194         * WebGPUShadingLanguageRI/AnonymousVariable.js: Removed.
3195         * WebGPUShadingLanguageRI/ArrayRefType.js: Removed.
3196         * WebGPUShadingLanguageRI/ArrayType.js: Removed.
3197         * WebGPUShadingLanguageRI/Assignment.js: Removed.
3198         * WebGPUShadingLanguageRI/AutoWrapper.js: Removed.
3199         * WebGPUShadingLanguageRI/Block.js: Removed.
3200         * WebGPUShadingLanguageRI/BoolLiteral.js: Removed.
3201         * WebGPUShadingLanguageRI/Break.js: Removed.
3202         * WebGPUShadingLanguageRI/BuiltInSemantic.js: Removed.
3203         * WebGPUShadingLanguageRI/BuiltinMatrixGetter.js: Removed.
3204         * WebGPUShadingLanguageRI/BuiltinMatrixSetter.js: Removed.
3205         * WebGPUShadingLanguageRI/BuiltinVectorGetter.js: Removed.
3206         * WebGPUShadingLanguageRI/BuiltinVectorSetter.js: Removed.
3207         * WebGPUShadingLanguageRI/CallExpression.js: Removed.
3208         * WebGPUShadingLanguageRI/CallFunction.js: Removed.
3209         * WebGPUShadingLanguageRI/Casts.js: Removed.
3210         * WebGPUShadingLanguageRI/Check.js: Removed.
3211         * WebGPUShadingLanguageRI/CheckLiteralTypes.js: Removed.
3212         * WebGPUShadingLanguageRI/CheckLoops.js: Removed.
3213         * WebGPUShadingLanguageRI/CheckNativeFuncStages.js: Removed.
3214         * WebGPUShadingLanguageRI/CheckRecursion.js: Removed.
3215         * WebGPUShadingLanguageRI/CheckRecursiveTypes.js: Removed.
3216         * WebGPUShadingLanguageRI/CheckReturns.js: Removed.
3217         * WebGPUShadingLanguageRI/CheckTypesWithArguments.js: Removed.
3218         * WebGPUShadingLanguageRI/CheckUnreachableCode.js: Removed.
3219         * WebGPUShadingLanguageRI/CheckWrapped.js: Removed.
3220         * WebGPUShadingLanguageRI/Checker.js: Removed.
3221         * WebGPUShadingLanguageRI/CloneProgram.js: Removed.
3222         * WebGPUShadingLanguageRI/CommaExpression.js: Removed.
3223         * WebGPUShadingLanguageRI/ConstexprFolder.js: Removed.
3224         * WebGPUShadingLanguageRI/Continue.js: Removed.
3225         * WebGPUShadingLanguageRI/ConvertPtrToArrayRefExpression.js: Removed.
3226         * WebGPUShadingLanguageRI/CreateLiteral.js: Removed.
3227         * WebGPUShadingLanguageRI/CreateLiteralType.js: Removed.
3228         * WebGPUShadingLanguageRI/DereferenceExpression.js: Removed.
3229         * WebGPUShadingLanguageRI/DoWhileLoop.js: Removed.
3230         * WebGPUShadingLanguageRI/DotExpression.js: Removed.
3231         * WebGPUShadingLanguageRI/EArrayRef.js: Removed.
3232         * WebGPUShadingLanguageRI/EBuffer.js: Removed.
3233         * WebGPUShadingLanguageRI/EBufferBuilder.js: Removed.
3234         * WebGPUShadingLanguageRI/EPtr.js: Removed.
3235         * WebGPUShadingLanguageRI/EnumLiteral.js: Removed.
3236         * WebGPUShadingLanguageRI/EnumMember.js: Removed.
3237         * WebGPUShadingLanguageRI/EnumType.js: Removed.
3238         * WebGPUShadingLanguageRI/EvaluationCommon.js: Removed.
3239         * WebGPUShadingLanguageRI/Evaluator.js: Removed.
3240         * WebGPUShadingLanguageRI/Expression.js: Removed.
3241         * WebGPUShadingLanguageRI/ExpressionFinder.js: Removed.
3242         * WebGPUShadingLanguageRI/ExternalOrigin.js: Removed.
3243         * WebGPUShadingLanguageRI/Field.js: Removed.
3244         * WebGPUShadingLanguageRI/FindHighZombies.js: Removed.
3245         * WebGPUShadingLanguageRI/FlattenedStructOffsetGatherer.js: Removed.
3246         * WebGPUShadingLanguageRI/FloatLiteral.js: Removed.
3247         * WebGPUShadingLanguageRI/FloatLiteralType.js: Removed.
3248         * WebGPUShadingLanguageRI/FoldConstexprs.js: Removed.
3249         * WebGPUShadingLanguageRI/ForLoop.js: Removed.
3250         * WebGPUShadingLanguageRI/Func.js: Removed.
3251         * WebGPUShadingLanguageRI/FuncAttribute.js: Removed.
3252         * WebGPUShadingLanguageRI/FuncDef.js: Removed.
3253         * WebGPUShadingLanguageRI/FuncNumThreadsAttribute.js: Removed.
3254         * WebGPUShadingLanguageRI/FuncParameter.js: Removed.
3255         * WebGPUShadingLanguageRI/FunctionLikeBlock.js: Removed.
3256         * WebGPUShadingLanguageRI/HighZombieFinder.js: Removed.
3257         * WebGPUShadingLanguageRI/IdentityExpression.js: Removed.
3258         * WebGPUShadingLanguageRI/IfStatement.js: Removed.
3259         * WebGPUShadingLanguageRI/IndexExpression.js: Removed.
3260         * WebGPUShadingLanguageRI/InferTypesForCall.js: Removed.
3261         * WebGPUShadingLanguageRI/Inline.js: Removed.
3262         * WebGPUShadingLanguageRI/Inliner.js: Removed.
3263         * WebGPUShadingLanguageRI/IntLiteral.js: Removed.
3264         * WebGPUShadingLanguageRI/IntLiteralType.js: Removed.
3265         * WebGPUShadingLanguageRI/Intrinsics.js: Removed.
3266         * WebGPUShadingLanguageRI/LayoutBuffers.js: Removed.
3267         * WebGPUShadingLanguageRI/Lexer.js: Removed.
3268         * WebGPUShadingLanguageRI/LexerToken.js: Removed.
3269         * WebGPUShadingLanguageRI/LiteralTypeChecker.js: Removed.
3270         * WebGPUShadingLanguageRI/LogicalExpression.js: Removed.
3271         * WebGPUShadingLanguageRI/LogicalNot.js: Removed.
3272         * WebGPUShadingLanguageRI/LoopChecker.js: Removed.
3273         * WebGPUShadingLanguageRI/MakeArrayRefExpression.js: Removed.
3274         * WebGPUShadingLanguageRI/MakePtrExpression.js: Removed.
3275         * WebGPUShadingLanguageRI/MatrixType.js: Removed.
3276         * WebGPUShadingLanguageRI/Metal/MSLBackend.js: Removed.
3277         * WebGPUShadingLanguageRI/Metal/MSLCodegenAll.js: Removed.
3278         * WebGPUShadingLanguageRI/Metal/MSLCompileResult.js: Removed.
3279         * WebGPUShadingLanguageRI/Metal/MSLConstexprEmitter.js: Removed.
3280         * WebGPUShadingLanguageRI/Metal/MSLFunctionDeclaration.js: Removed.
3281         * WebGPUShadingLanguageRI/Metal/MSLFunctionDefinition.js: Removed.
3282         * WebGPUShadingLanguageRI/Metal/MSLFunctionForwardDeclaration.js: Removed.
3283         * WebGPUShadingLanguageRI/Metal/MSLInsertTrapParameter.js: Removed.
3284         * WebGPUShadingLanguageRI/Metal/MSLNameMangler.js: Removed.
3285         * WebGPUShadingLanguageRI/Metal/MSLNativeFunctionCall.js: Removed.
3286         * WebGPUShadingLanguageRI/Metal/MSLStatementEmitter.js: Removed.
3287         * WebGPUShadingLanguageRI/Metal/MSLTypeAttributes.js: Removed.
3288         * WebGPUShadingLanguageRI/Metal/MSLTypeAttributesMap.js: Removed.
3289         * WebGPUShadingLanguageRI/Metal/MSLTypeUnifier.js: Removed.
3290         * WebGPUShadingLanguageRI/Metal/TypeOf.js: Removed.
3291         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/.gitignore: Removed.
3292         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/AppDelegate.h: Removed.
3293         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/AppDelegate.m: Removed.
3294         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Assets.xcassets/AppIcon.appiconset/Contents.json: Removed.
3295         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Assets.xcassets/Contents.json: Removed.
3296         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Base.lproj/Main.storyboard: Removed.
3297         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CompileResult.h: Removed.
3298         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CompileResult.m: Removed.
3299         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.h: Removed.
3300         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.m: Removed.
3301         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CustomMetalView.h: Removed.
3302         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CustomMetalView.m: Removed.
3303         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Default.whlsl: Removed.
3304         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Julia.whlsl: Removed.
3305         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Mandelbrot.whlsl: Removed.
3306         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Info.plist: Removed.
3307         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.h: Removed.
3308         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.m: Removed.
3309         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OnscreenRenderer.h: Removed.
3310         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OnscreenRenderer.m: Removed.
3311         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/Renderer.h: Removed.
3312         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/Renderer.m: Removed.
3313         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestCallArgument.h: Removed.
3314         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestCallArgument.m: Removed.
3315         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestDescription.h: Removed.
3316         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestDescription.m: Removed.
3317         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.h: Removed.
3318         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m: Removed.
3319         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.h: Removed.
3320         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m: Removed.
3321         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.h: Removed.
3322         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m: Removed.
3323         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/WHLSL.entitlements: Removed.
3324         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/_SharedMetal.txt: Removed.
3325         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/main.m: Removed.
3326         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL Tests.xcodeproj/project.pbxproj: Removed.
3327         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL ToyTests/Info.plist: Removed.
3328         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL ToyTests/WHLSL_ToyTests.m: Removed.
3329         * WebGPUShadingLanguageRI/Metal/WhlslToMsl.html: Removed.
3330         * WebGPUShadingLanguageRI/Metal/WhlslToMsl.js: Removed.
3331         * WebGPUShadingLanguageRI/NameContext.js: Removed.
3332         * WebGPUShadingLanguageRI/NameFinder.js: Removed.
3333         * WebGPUShadingLanguageRI/NameResolver.js: Removed.
3334         * WebGPUShadingLanguageRI/NativeFunc.js: Removed.
3335         * WebGPUShadingLanguageRI/NativeType.js: Removed.
3336         * WebGPUShadingLanguageRI/Node.js: Removed.
3337         * WebGPUShadingLanguageRI/NormalUsePropertyResolver.js: Removed.
3338         * WebGPUShadingLanguageRI/NullLiteral.js: Removed.
3339         * WebGPUShadingLanguageRI/NullType.js: Removed.
3340         * WebGPUShadingLanguageRI/OperatorAnderIndexer.js: Removed.
3341         * WebGPUShadingLanguageRI/OperatorArrayRefLength.js: Removed.
3342         * WebGPUShadingLanguageRI/OriginKind.js: Removed.
3343         * WebGPUShadingLanguageRI/OverloadResolutionFailure.js: Removed.
3344         * WebGPUShadingLanguageRI/Parse.js: Removed.
3345         * WebGPUShadingLanguageRI/Prepare.js: Removed.
3346         * WebGPUShadingLanguageRI/Program.js: Removed.
3347         * WebGPUShadingLanguageRI/ProgramWithUnnecessaryThingsRemoved.js: Removed.
3348         * WebGPUShadingLanguageRI/PropertyAccessExpression.js: Removed.
3349         * WebGPUShadingLanguageRI/PropertyResolver.js: Removed.
3350         * WebGPUShadingLanguageRI/PtrType.js: Removed.
3351         * WebGPUShadingLanguageRI/ReadModifyWriteExpression.js: Removed.
3352         * WebGPUShadingLanguageRI/RecursionChecker.js: Removed.
3353         * WebGPUShadingLanguageRI/RecursiveTypeChecker.js: Removed.
3354         * WebGPUShadingLanguageRI/ReferenceType.js: Removed.
3355         * WebGPUShadingLanguageRI/ResolveNames.js: Removed.
3356         * WebGPUShadingLanguageRI/ResolveOverloadImpl.js: Removed.
3357         * WebGPUShadingLanguageRI/ResolveProperties.js: Removed.
3358         * WebGPUShadingLanguageRI/ResolveTypeDefs.js: Removed.
3359         * WebGPUShadingLanguageRI/ResourceSemantic.js: Removed.
3360         * WebGPUShadingLanguageRI/Return.js: Removed.
3361         * WebGPUShadingLanguageRI/ReturnChecker.js: Removed.
3362         * WebGPUShadingLanguageRI/ReturnException.js: Removed.
3363         * WebGPUShadingLanguageRI/Rewriter.js: Removed.
3364         * WebGPUShadingLanguageRI/SPIR-V.js: Removed.
3365         * WebGPUShadingLanguageRI/SPIRV.html: Removed.
3366         * WebGPUShadingLanguageRI/SPIRVCodegen.js: Removed.
3367         * WebGPUShadingLanguageRI/SPIRVTypeAnalyzer.js: Removed.
3368         * WebGPUShadingLanguageRI/SPIRVVariableAnalyzer.js: Removed.
3369         * WebGPUShadingLanguageRI/Sampler.js: Removed.
3370         * WebGPUShadingLanguageRI/Semantic.js: Removed.
3371         * WebGPUShadingLanguageRI/SpecializationConstantSemantic.js: Removed.
3372         * WebGPUShadingLanguageRI/StageInOutSemantic.js: Removed.
3373         * WebGPUShadingLanguageRI/StandardLibrary.js: Removed.
3374         * WebGPUShadingLanguageRI/StatementCloner.js: Removed.
3375         * WebGPUShadingLanguageRI/StructLayoutBuilder.js: Removed.
3376         * WebGPUShadingLanguageRI/StructType.js: Removed.
3377         * WebGPUShadingLanguageRI/SwitchCase.js: Removed.
3378         * WebGPUShadingLanguageRI/SwitchStatement.js: Removed.
3379         * WebGPUShadingLanguageRI/SynthesizeArrayOperatorLength.js: Removed.
3380         * WebGPUShadingLanguageRI/SynthesizeCopyConstructorOperator.js: Removed.
3381         * WebGPUShadingLanguageRI/SynthesizeDefaultConstructorOperator.js: Removed.
3382         * WebGPUShadingLanguageRI/SynthesizeEnumFunctions.js: Removed.
3383         * WebGPUShadingLanguageRI/SynthesizeStructAccessors.js: Removed.
3384         * WebGPUShadingLanguageRI/TernaryExpression.js: Removed.
3385         * WebGPUShadingLanguageRI/Test.html: Removed.
3386         * WebGPUShadingLanguageRI/Test.js: Removed.
3387         * WebGPUShadingLanguageRI/Texture.js: Removed.
3388         * WebGPUShadingLanguageRI/TextureOperations.js: Removed.
3389         * WebGPUShadingLanguageRI/TrapStatement.js: Removed.
3390         * WebGPUShadingLanguageRI/Type.js: Removed.
3391         * WebGPUShadingLanguageRI/TypeDef.js: Removed.
3392         * WebGPUShadingLanguageRI/TypeDefResolver.js: Removed.
3393         * WebGPUShadingLanguageRI/TypeOverloadResolutionFailure.js: Removed.
3394         * WebGPUShadingLanguageRI/TypeRef.js: Removed.
3395         * WebGPUShadingLanguageRI/TypedValue.js: Removed.
3396         * WebGPUShadingLanguageRI/UintLiteral.js: Removed.
3397         * WebGPUShadingLanguageRI/UintLiteralType.js: Removed.
3398         * WebGPUShadingLanguageRI/UnificationContext.js: Removed.
3399         * WebGPUShadingLanguageRI/UnreachableCodeChecker.js: Removed.
3400         * WebGPUShadingLanguageRI/Value.js: Removed.
3401         * WebGPUShadingLanguageRI/VariableDecl.js: Removed.
3402         * WebGPUShadingLanguageRI/VariableRef.js: Removed.
3403         * WebGPUShadingLanguageRI/VectorType.js: Removed.
3404         * WebGPUShadingLanguageRI/VisitingSet.js: Removed.
3405         * WebGPUShadingLanguageRI/Visitor.js: Removed.
3406         * WebGPUShadingLanguageRI/WLexicalError.js: Removed.
3407         * WebGPUShadingLanguageRI/WSyntaxError.js: Removed.
3408         * WebGPUShadingLanguageRI/WTrapError.js: Removed.
3409         * WebGPUShadingLanguageRI/WTypeError.js: Removed.
3410         * WebGPUShadingLanguageRI/WhileLoop.js: Removed.
3411         * WebGPUShadingLanguageRI/WrapChecker.js: Removed.
3412         * WebGPUShadingLanguageRI/index.html: Removed.
3413         * WebGPUShadingLanguageRI/spirv.core.grammar.json: Removed.
3414         * WebGPUShadingLanguageRI/wsl-tests.yaml: Removed.
3415
3416 2018-10-15  Philippe Normand  <pnormand@igalia.com>
3417
3418         [GTK] Disable MSE build support on Debian and Ubuntu LTS bots
3419         https://bugs.webkit.org/show_bug.cgi?id=190581
3420
3421         Reviewed by Michael Catanzaro.
3422
3423         These bots don't use JHBuild and their host GStreamer version is
3424         too old for the GStreamer MSE backend. Version 1.14 is needed at least.
3425
3426         * BuildSlaveSupport/build.webkit.org-config/config.json:
3427
3428 2018-10-15  Alex Christensen  <achristensen@webkit.org>
3429
3430         Use pragma once in WTF
3431         https://bugs.webkit.org/show_bug.cgi?id=190527
3432
3433         Reviewed by Chris Dumez.
3434
3435         Put WorkQueue in namespace DRT so it does not conflict with WTF::WorkQueue.
3436
3437         * DumpRenderTree/TestRunner.cpp:
3438         (TestRunner::queueLoadHTMLString):
3439         (TestRunner::queueLoadAlternateHTMLString):
3440         (TestRunner::queueBackNavigation):
3441         (TestRunner::queueForwardNavigation):
3442         (TestRunner::queueLoadingScript):
3443         (TestRunner::queueNonLoadingScript):
3444         (TestRunner::queueReload):
3445         * DumpRenderTree/WorkQueue.cpp:
3446         (WorkQueue::singleton): Deleted.
3447         (WorkQueue::WorkQueue): Deleted.
3448         (WorkQueue::queue): Deleted.
3449         (WorkQueue::dequeue): Deleted.
3450         (WorkQueue::count): Deleted.
3451         (WorkQueue::clear): Deleted.
3452         (WorkQueue::processWork): Deleted.
3453         * DumpRenderTree/WorkQueue.h:
3454         (WorkQueue::setFrozen): Deleted.
3455         * DumpRenderTree/WorkQueueItem.h:
3456         * DumpRenderTree/mac/DumpRenderTree.mm:
3457         (runTest):
3458         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3459         (-[FrameLoadDelegate processWork:]):
3460         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]):
3461         * DumpRenderTree/mac/TestRunnerMac.mm:
3462         (TestRunner::notifyDone):
3463         (TestRunner::forceImmediateCompletion):
3464         (TestRunner::queueLoad):
3465         * DumpRenderTree/win/DumpRenderTree.cpp:
3466         (runTest):
3467         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3468         (FrameLoadDelegate::processWork):
3469         (FrameLoadDelegate::locationChangeDone):
3470         * DumpRenderTree/win/TestRunnerWin.cpp:
3471         (TestRunner::notifyDone):
3472         (TestRunner::forceImmediateCompletion):
3473         (TestRunner::queueLoad):
3474
3475 2018-10-14  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
3476
3477         [JSC] Remove Option::useAsyncIterator
3478         https://bugs.webkit.org/show_bug.cgi?id=190567
3479
3480         Reviewed by Saam Barati.
3481
3482         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3483
3484 2018-10-15  Claudio Saavedra  <csaavedra@igalia.com>
3485
3486         [WPE] Silence a unused-parameter warning
3487
3488         Unreviewed.
3489         * MiniBrowser/wpe/main.cpp:
3490         (decidePermissionRequest):
3491
3492 2018-10-12  Guillaume Emont  <guijemont@igalia.com>
3493
3494         [Tools][webkitpy] fix handling of JSCTESTS_OPTIONS
3495         https://bugs.webkit.org/show_bug.cgi?id=190537
3496
3497         Reviewed by Alexey Proskuryakov.
3498
3499         In DeprecatedPort.run_javascriptcore_tests_command() JSCTESTS_OPTIONS
3500         needs to be split before adding it to the command since it is treated
3501         as a list of args.
3502
3503         * Scripts/webkitpy/common/config/ports.py:
3504         (DeprecatedPort.run_javascriptcore_tests_command):
3505
3506 2018-10-12  Wenson Hsieh  <wenson_hsieh@apple.com>
3507
3508         [iOS] Allow SPI clients to lay out at arbitrarily scaled sizes and scale to fit the view
3509         https://bugs.webkit.org/show_bug.cgi?id=190504
3510         <rdar://problem/45117760>
3511
3512         Reviewed by Tim Horton.
3513
3514         Teach UIScriptController to set WKWebView's view scale via a new `setViewScale` method, supported in WebKit2 on
3515         macOS and iOS.
3516
3517         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3518         (WTR::UIScriptController::setViewScale):
3519         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3520         (WTR::UIScriptController::setViewScale):
3521         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3522         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3523         (WTR::UIScriptController::setViewScale):
3524         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3525         * WebKitTestRunner/UIScriptControllerCocoa.mm: Added.
3526
3527         Add a new file for UIScriptController methods on Cocoa platforms.
3528
3529         (WTR::UIScriptController::setViewScale):
3530         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3531         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3532         (WTR::TestController::cocoaResetStateToConsistentValues):
3533
3534         Ensure that _viewScale is reset to 1 after running a layout test.
3535
3536 2018-10-12  Aakash Jain  <aakash_jain@apple.com>
3537
3538         [ews-build] Rename iOS-11-Simulator-Tests-EWS to iOS-11-Simulator-WK2-Tests-EWS
3539         https://bugs.webkit.org/show_bug.cgi?id=190536
3540
3541         Reviewed by Alexey Proskuryakov.
3542
3543         * BuildSlaveSupport/ews-build/config.json: Renamed iOS-11-Simulator-Tests-EWS to iOS-11-Simulator-WK2-Tests-EWS.
3544
3545 2018-10-11  Youenn Fablet  <youenn@apple.com>
3546
3547         IOS 12 - Service worker cache not shared when added to homescreen
3548         https://bugs.webkit.org/show_bug.cgi?id=190269
3549         <rdar://problem/45009961>
3550
3551         Reviewed by Alex Christensen.
3552
3553         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3554         Add test to ensure that CacheStorage use the default website data store parameters.
3555
3556 2018-10-11  Tim Horton  <timothy_horton@apple.com>
3557
3558         Clicking on bookmarklet crashes at NavigationState::willRecordNavigationSnapshot
3559         https://bugs.webkit.org/show_bug.cgi?id=190476
3560         <rdar://problem/32757191>
3561
3562         Reviewed by Megan Gardner.
3563
3564         * TestWebKitAPI/Tests/WebKitCocoa/SnapshotStore.mm:
3565         (TEST):
3566         Add a test that we don't crash.
3567
3568 2018-10-11  Tim Horton  <timothy_horton@apple.com>
3569
3570         REGRESSION (r237037): Cannot use webkit-patch upload, always fails with unknown 'cc_radar'
3571
3572         * Scripts/webkitpy/tool/steps/options.py:
3573         (Options):
3574         Fix the name of the variable that the --cc-radar option writes into.
3575
3576 2018-10-10  Dean Jackson  <dino@apple.com>
3577
3578         Add --cc-radar option to webkit-patch bug creation
3579         https://bugs.webkit.org/show_bug.cgi?id=190451
3580         <rdar://problem/45176671>
3581
3582         Reviewed by Antoine Quint.
3583
3584         Add a new command line option to automatically
3585         CC radar to new or updated bugs.
3586
3587         * Scripts/webkitpy/tool/commands/commandtest.py:
3588         (CommandsTest.assert_execute_outputs):
3589         * Scripts/webkitpy/tool/commands/upload.py:
3590         (CreateBug.__init__):
3591         (CreateBug.execute):
3592         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3593         (test_prepare_with_cc):
3594         (test_prepare_with_radar):
3595         (test_prepare_with_cc_and_radar):
3596         * Scripts/webkitpy/tool/steps/createbug.py:
3597         (CreateBug.options):
3598         (CreateBug.run):
3599         * Scripts/webkitpy/tool/steps/options.py:
3600         (Options):
3601
3602 2018-10-11  Claudio Saavedra  <csaavedra@igalia.com>
3603
3604         [GStreamer] Do not build gstgtk plugins
3605         https://bugs.webkit.org/show_bug.cgi?id=190463
3606
3607         Reviewed by Xabier Rodriguez-Calvar.
3608
3609         These plugins pull a GTK+ dependency that, at least in WPE,
3610         is unnecessary. The GTK+ port doesn't need it either, as far
3611         as I can tell.
3612
3613         * gstreamer/jhbuild.modules: Disable gstgtk plugins
3614
3615 2018-10-11  Alejandro G. Castro  <alex@igalia.com>
3616