Mitigate scrollbar differences when running pixel tests
[WebKit-https.git] / Tools / ChangeLog
1 2012-01-12  Simon Fraser  <simon.fraser@apple.com>
2
3         Mitigate scrollbar differences when running pixel tests
4         https://bugs.webkit.org/show_bug.cgi?id=67217
5
6         Reviewed by Dan Bernstein.
7         
8         Enable mock scrollbars by default for tests.
9
10         * DumpRenderTree/mac/DumpRenderTree.mm:
11         (resetDefaultsToConsistentValues):
12         * WebKitTestRunner/TestController.cpp:
13         (WTR::TestController::resetStateToConsistentValues):
14
15 2012-01-12  Ryosuke Niwa  <rniwa@webkit.org>
16
17         Need a script to run tests in PerformanceTests
18         https://bugs.webkit.org/show_bug.cgi?id=76132
19
20         Reviewed by Adam Barth.
21
22         Add run-perf-tests to run performance tests using parser/resources/runner.js.
23         Unfortunately, there isn't an easy way of telling which test uses which format
24         so hard-code directory that uses Chromium perf-bot style (only inspector perf. tests for now).
25
26         All test outputs are re-formatted to match Chromium perf-bot style.
27
28         * Scripts/run-inspector-perf-tests.py:
29         * Scripts/run-perf-tests: Added.
30         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
31         (PerfTestsRunner):
32         (PerfTestsRunner.__init__):
33         (PerfTestsRunner._collect_tests):
34         (PerfTestsRunner.run):
35         (PerfTestsRunner._print_status):
36         (PerfTestsRunner._run_tests_set):
37         (PerfTestsRunner._process_chromium_style_test_result):
38         (PerfTestsRunner._should_ignore_line_in_parser_test_result):
39         (PerfTestsRunner._process_parser_test_result):
40         (PerfTestsRunner._run_single_test):
41         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
42         (MainTest.TestDriver.run_test):
43         (create_runner):
44         (run_test):
45         (test_run_test_set):
46         (test_run_test_set_for_parser_tests):
47         (test_collect_tests):
48
49 2012-01-12  Dirk Pranke  <dpranke@chromium.org>
50
51         webkitpy: clean up port unit tests in preparation for making port_name mandatory
52         https://bugs.webkit.org/show_bug.cgi?id=76123
53
54         Reviewed by Adam Barth.
55
56         This change updates the unit tests to be more consistent in how
57         ports are created, in preparation for making port_name a
58         mandatory parameter to the constructor and removing any version
59         interpretation from it.
60
61         There should be no functional changes in this patch, but some
62         tests that are no longer relevant have been removed or reworked.
63
64         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
65         (PortTest.test_get_option__default):
66         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
67         (ChromiumLinuxPortTest):
68         (ChromiumLinuxPortTest.assert_architecture):
69         (ChromiumLinuxPortTest.test_determine_architecture_fails):
70         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
71         (ChromiumMacPortTest):
72         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
73         (ChromiumPortTest):
74         (ChromiumPortTest.test_all_test_configurations):
75         (ChromiumPortTest.TestMacPort.__init__):
76         (ChromiumPortTest.TestLinuxPort.__init__):
77         (ChromiumPortTest.TestWinPort.__init__):
78         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
79         (ChromiumWinTest):
80         * Scripts/webkitpy/layout_tests/port/efl_unittest.py:
81         (EflPortTest):
82         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
83         (GtkPortTest):
84         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
85         (MacTest):
86         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
87         (MockDRTPortTest):
88         (MockDRTPortTest.make_port):
89         * Scripts/webkitpy/layout_tests/port/qt.py:
90         (QtPort._port_flag_for_scripts):
91         (QtPort.__init__):
92         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
93         (QtPortTest):
94         (QtPortTest._assert_search_path):
95         (QtPortTest.test_baseline_search_path):
96         (QtPortTest.test_operating_system):
97         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
98         (WebKitPortTest):
99         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
100         (WinPortTest):
101         (WinPortTest._assert_search_path):
102         (WinPortTest.test_baseline_search_path):
103         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
104         (get_test_config.TestMacPort.__init__):
105
106 2012-01-12  Dirk Pranke  <dpranke@chromium.org>
107
108         test-webkitpy: clean up logging and provide a real --help message
109         https://bugs.webkit.org/show_bug.cgi?id=76142
110
111         Reviewed by Adam Barth.
112
113         This test is mostly more refactoring - it calls objects in
114         unittest directly instead of routing through unittest.main() --
115         in order to gain more control over the logging and to provide a
116         correct --help message. This will also give us a better
117         foundation for adding more feautures down the road.
118
119         This patch adds different levels of logging controlled by the
120         '-s', '-q', and '-v' options (see --help for details), and
121         removes the --verbose-logging option.
122
123         * Scripts/test-webkitpy:
124         * Scripts/webkitpy/test/main.py:
125         (Tester):
126         (Tester.clean_packages):
127         (Tester.__init__):
128         (Tester.parse_args):
129         (Tester.configure):
130         (Tester._configure_logging):
131         (Tester.find_modules):
132         (Tester._exclude):
133         (Tester._modules_from_paths):
134         (Tester.run_tests):
135
136 2012-01-12  Simon Hausmann  <simon.hausmann@nokia.com>
137
138         Make the new WTF module build on Qt
139         https://bugs.webkit.org/show_bug.cgi?id=76163
140
141         Reviewed by Tor Arne Vestbø.
142
143         * qmake/mkspecs/modules/wtf.prf: Pull in WTF from the new location.
144
145 2012-01-12  Vsevolod Vlasov  <vsevik@chromium.org>
146
147         Unreviewed, mac DumpRenderTree fix.
148
149         * DumpRenderTree/mac/UIDelegate.mm:
150         (-[UIDelegate webView:addMessageToConsole:withSource:]):
151
152 2012-01-12  Vsevolod Vlasov  <vsevik@chromium.org>
153
154         WebKitTestRunner should not print console message line number when it is equal to zero.
155         https://bugs.webkit.org/show_bug.cgi?id=76167
156
157         Reviewed by Csaba Osztrogonác.
158
159         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
160         (WTR::InjectedBundlePage::willAddMessageToConsole):
161
162 2012-01-11  Vsevolod Vlasov  <vsevik@chromium.org>
163
164         Make default console messages line numbers consistent.
165         https://bugs.webkit.org/show_bug.cgi?id=74075
166
167         Reviewed by Pavel Feldman.
168
169         Unset line numbers are not printed to console now.
170         Added Source/WebCore/inspector to efl DumpRenderTree include path.
171
172         * DumpRenderTree/chromium/WebViewHost.cpp:
173         (WebViewHost::didAddMessageToConsole):
174         * DumpRenderTree/efl/CMakeLists.txt:
175         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
176         (onConsoleMessage):
177         * DumpRenderTree/gtk/DumpRenderTree.cpp:
178         (webViewConsoleMessage):
179         * DumpRenderTree/mac/UIDelegate.mm:
180         (-[UIDelegate webView:addMessageToConsole:withSource:]):
181         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
182         (WebCore::WebPage::javaScriptConsoleMessage):
183         * DumpRenderTree/win/UIDelegate.cpp:
184         (UIDelegate::webViewAddMessageToConsole):
185         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
186         (LayoutWebViewEventHandler::OnConsoleMessageEvent):
187
188 2012-01-10  Dirk Pranke  <dpranke@chromium.org>
189
190         test-webkitpy: push more logic into webkitpy.test.main, clean up code
191         https://bugs.webkit.org/show_bug.cgi?id=76021
192
193         Reviewed by Eric Seidel.
194
195         I plan to add more functionality to test-webkitpy, but it is
196         difficult to hack on now; this patch is the first of two that
197         brings test-webkitpy more inline with current coding style by
198         pushing more logic into the webkitpy.test.main.Tester class (so
199         that it will be testable itself).
200         
201         There should be no functional changes in this patch.
202
203         * Scripts/test-webkitpy:
204         (_path_from_webkit_root):
205         * Scripts/webkitpy/test/main.py:
206         (Tester):
207         (Tester.init):
208         (Tester.configure_logging):
209         (Tester.configure_logging.filter):
210         (Tester.clean_packages):
211         (Tester.run_tests):
212
213 2012-01-11  Wei Jia  <wjia@chromium.org>
214
215         implement layout tests for <video> with media stream
216         https://bugs.webkit.org/show_bug.cgi?id=74882
217
218         Reviewed by Kent Tamura.
219
220         * DumpRenderTree/DumpRenderTree.gypi:
221         * DumpRenderTree/chromium/WebUserMediaClientMock.cpp: Added.
222         (WebKit::WebUserMediaClientMock::create):
223         (WebKit::WebUserMediaClientMock::IsMockStream):
224         (WebKit::WebUserMediaClientMock::requestUserMedia):
225         (WebKit::WebUserMediaClientMock::cancelUserMediaRequest):
226         * DumpRenderTree/chromium/WebUserMediaClientMock.h: Added.
227         (WebKit::WebUserMediaClientMock::~WebUserMediaClientMock):
228         (WebKit::WebUserMediaClientMock::WebUserMediaClientMock):
229         * DumpRenderTree/chromium/WebViewHost.cpp:
230         (WebViewHost::userMediaClient):
231         (WebViewHost::userMediaClientMock):
232         (WebViewHost::createMediaPlayer):
233         (WebViewHost::mediaStreamUtil):
234         (WebViewHost::testMediaStreamClient):
235         * DumpRenderTree/chromium/WebViewHost.h:
236
237 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
238
239         Unreviewed, build fix.
240
241         Fix chromium-win's version remapping to work correctly on Win 7 SP1.
242
243         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
244         (ChromiumWinPort.__init__):
245
246 2012-01-11  Ryosuke Niwa  <rniwa@webkit.org>
247
248         Sheriffbot build fix. Don't emit empty lines on IRC.
249
250         * Scripts/webkitpy/tool/bot/irc_command.py:
251         (LastGreenRevision.execute):
252
253 2012-01-11  Ryosuke Niwa  <rniwa@webkit.org>
254
255         last-green-revision should report the revision that succeeded on all bots
256         https://bugs.webkit.org/show_bug.cgi?id=76109
257
258         Reviewed by Adam Barth.
259
260         Add an algorithm to find the last known good revision among the specified bots. For a revision to be
261         considered green by this algorithm, all matching builders must have a successful run at the revision
262         or two consecutive successful runs before and after the revision.
263
264         Also fixed a bug in irc_command that the result wasn't posted on IRC properly and a bug in queries.py
265         that resulted in an exception when the user didn't pass BUILDER_NAME argument.
266
267         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
268         (BuildBot._revisions_for_builder):
269         (BuildBot):
270         (BuildBot._find_green_revision):
271         (BuildBot.last_green_revision):
272         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
273         (MockBuildBot.last_green_revision):
274         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
275         (test_revisions_for_builder):
276         (test_find_green_revision):
277         (test_last_green_revision):
278         * Scripts/webkitpy/tool/bot/irc_command.py:
279         (LastGreenRevision.execute):
280         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
281         (SheriffIRCBotTest.test_lgr):
282         * Scripts/webkitpy/tool/commands/queries.py:
283         (LastGreenRevision):
284
285 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
286
287         Unreviewed, fix build bustage on win32 introduced by r104725.
288
289         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
290         (MockDRTPortTest.make_port):
291         (MockChromiumDRTTest.test_pixeltest__fails):
292
293 2012-01-11  Jochen Eisinger  <jochen@chromium.org>
294
295         [Chromium] mimic the (old) behavior of the mac port for (re)setting the color profile
296         https://bugs.webkit.org/show_bug.cgi?id=75618
297
298         Eventually, we should get away from setting the display's color profile, as the mac port is doing now.
299
300         Reviewed by Tony Chang.
301
302         * DumpRenderTree/chromium/LayoutTestHelper.mm:
303         (installLayoutTestColorProfile):
304         (restoreUserColorProfile):
305         (main):
306
307 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
308
309         test-webkitpy: fix -v and eliminate some spurious warnings
310         https://bugs.webkit.org/show_bug.cgi?id=76099
311
312         Reviewed by Adam Barth.
313
314         when we added support for --xml output, we broke the -v flag.
315
316         Also, fix the code to swallow a harmless warning from
317         VCSUtils.pm and fix a deprecated warning in jsonchecker.py.
318
319         test-webkitpy is now silent again except for the one known
320         logging issue.
321
322         * Scripts/webkitpy/common/checkout/checkout.py:
323         (Checkout.commit_message_for_this_commit):
324         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
325         (test_commit_message_for_this_commit):
326         * Scripts/webkitpy/style/checkers/jsonchecker.py:
327         (JSONChecker.check):
328         (JSONChecker.line_number_from_json_exception):
329         * Scripts/webkitpy/test/main.py:
330         (Tester.run_tests):
331
332 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
333
334         webkitpy: webkitpy.layout_tests.port tests should only use MockSystemHost, not MockHost
335         https://bugs.webkit.org/show_bug.cgi?id=76084
336
337         Reviewed by Adam Barth.
338
339         This will help make it easier to catch layering violations. This
340         change just refactors test code; there are no changes to
341         production code.
342
343         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
344         (PortTest.make_port):
345         (PortTest.test_find_no_paths_specified):
346         (PortTest.test_find_one_test):
347         (PortTest.test_find_glob):
348         (PortTest.test_find_with_skipped_directories):
349         (PortTest.test_find_with_skipped_directories_2):
350         (PortTest.test_parse_reftest_list):
351         (PortTest.test_httpd_returns_error_code):
352         (PortTest.test_virtual_methods):
353         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
354         (ChromiumGpuTest.assert_port_works):
355         (ChromiumGpuTest._assert_baseline_path):
356         (ChromiumGpuTest.test_graphics_type):
357         (ChromiumGpuTest.test_default_tests_paths.test_paths):
358         (ChromiumGpuTest.test_test_files):
359         (ChromiumGpuTest.test_test_files.test_paths):
360         (ChromiumGpuTest):
361         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
362         (ChromiumLinuxPortTest.assert_architecture):
363         (ChromiumLinuxPortTest.test_check_illegal_port_names):
364         (ChromiumLinuxPortTest.test_determine_architecture_fails):
365         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
366         (DriverTest.make_port):
367         (DriverTest):
368         (DriverTest.assertVirtual):
369         (DriverTest._assert_wrapper):
370         (DriverTest.test_virtual_driver_methods):
371         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
372         (MockDRTPortTest.make_port):
373         (MockDRTPortTest.test_port_name_in_constructor):
374         (MockDRTTest.assertTest):
375         (MockDRTTest.test_main):
376         (MockChromiumDRTTest.test_pixeltest__fails):
377         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
378         (QtPortTest._assert_search_path):
379         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
380         (TestWebKitPort.__init__):
381         (WebKitPortUnitTests.test_default_options):
382         (test_runtime_feature_list):
383         (test_test_expectations):
384
385 2012-01-11  Ojan Vafai  <ojan@chromium.org>
386
387         Style skipped tests in the flakiness dashboard
388         https://bugs.webkit.org/show_bug.cgi?id=76091
389
390         Reviewed by Tony Chang.
391
392         * TestResultServer/static-dashboards/dashboard_base.js:
393         Removed "FLAKY" from this list since we don't ever mark individual runs
394         as flaky. Also deleted an outdated line.
395         * TestResultServer/static-dashboards/flakiness_dashboard.html:
396
397 2012-01-11  Ojan Vafai  <ojan@chromium.org>
398
399         Remove gtest normalization code from the test results server
400         https://bugs.webkit.org/show_bug.cgi?id=76089
401
402         Reviewed by Tony Chang.
403
404         The normalization now happens on the gtest side.
405
406         * TestResultServer/model/jsonresults.py:
407         (JsonResults.merge):
408         * TestResultServer/model/jsonresults_unittest.py:
409         (JsonResultsTest.test_gtest):
410
411 2012-01-11  Ojan Vafai  <ojan@chromium.org>
412
413         Be more aggressive about deleting unnecessary results from the test-results-server json files
414         https://bugs.webkit.org/show_bug.cgi?id=76086
415
416         Reviewed by Tony Chang.
417
418         Remove any tests that only contain skip/pass/nodata values whose runtime
419         is less than 5 seconds.
420
421         * TestResultServer/model/jsonresults.py:
422         (JsonResults._normalize_results_json):
423         * TestResultServer/model/jsonresults_unittest.py:
424         (JsonResultsTest.test_merge_remove_test):
425         (JsonResultsTest.test_merge_keep_test_with_all_pass_but_slow_time):
426
427 2012-01-11  Ryosuke Niwa  <rniwa@webkit.org>
428
429         last-green-revision should give us per-bot information
430         https://bugs.webkit.org/show_bug.cgi?id=76011
431
432         Reviewed by Adam Barth.
433
434         Rewrote last-green-revision command. Instead of finding a revision for which all bots succeeded,
435         we report the latest green run on each bot from the last 100 runs.
436
437         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
438         (BuildBot._fetch_builder_page):
439         (BuildBot):
440         (BuildBot._green_revision_for_builder):
441         (BuildBot.last_green_revision):
442         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
443         (test_green_revision_for_builder):
444         (test_last_green_revision):
445         * Scripts/webkitpy/tool/bot/irc_command.py:
446         (LastGreenRevision.execute):
447         * Scripts/webkitpy/tool/commands/queries.py:
448         (LastGreenRevision.execute):
449
450 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
451
452         webkitpy: clean up version detection in webkitpy.layout_tests.port
453         https://bugs.webkit.org/show_bug.cgi?id=76016
454
455         Reviewed by Adam Barth.
456
457         This change updates the code in webkitpy.layout_tests.port to
458         use the new os_name and os_version fields on host.platform. This
459         gets layout_tests.port out of the version parsing business. Most
460         of the diffs are just cleaning up test code to accomodate the
461         changes.
462
463         * Scripts/webkitpy/common/system/executive_mock.py:
464         (MockExecutive):
465         (MockExecutive.ignore_error):
466         (MockExecutive2):
467         (MockExecutive2.ignore_error):
468         * Scripts/webkitpy/common/system/platforminfo_mock.py:
469         (MockPlatformInfo.is_mac):
470         (MockPlatformInfo.is_linux):
471         (MockPlatformInfo.is_win):
472         * Scripts/webkitpy/common/system/systemhost_mock.py:
473         (MockSystemHost.__init__):
474         * Scripts/webkitpy/layout_tests/port/apple.py:
475         (ApplePort.__init__):
476         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
477         (ChromiumMacPort.__init__):
478         (ChromiumMacPort.check_wdiff):
479         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
480         (ChromiumMacPortTest):
481         (ChromiumMacPortTest.assert_name):
482         (ChromiumMacPortTest.test_versions):
483         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
484         (ChromiumPortTest.test_all_test_configurations):
485         (ChromiumPortTest.TestMacPort.__init__):
486         (ChromiumPortTest.TestLinuxPort.__init__):
487         (ChromiumPortTest.TestWinPort.__init__):
488         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
489         (ChromiumWinPort.__init__):
490         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
491         (ChromiumWinTest):
492         (ChromiumWinTest.assert_name):
493         (ChromiumWinTest.test_versions):
494         (ChromiumWinTest.test_baseline_path):
495         (ChromiumWinTest.test_build_path):
496         * Scripts/webkitpy/layout_tests/port/factory.py:
497         (PortFactory._port_name_from_arguments_and_options):
498         (PortFactory.get):
499         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
500         (FactoryTest):
501         (FactoryTest.setUp):
502         (FactoryTest.assert_port):
503         (FactoryTest.test_mac):
504         (FactoryTest.test_win):
505         (FactoryTest.test_google_chrome):
506         (FactoryTest.test_gtk):
507         (FactoryTest.test_qt):
508         (FactoryTest.test_chromium_gpu):
509         (FactoryTest.test_chromium_gpu_linux):
510         (FactoryTest.test_chromium_gpu_mac):
511         (FactoryTest.test_chromium_gpu_win):
512         (FactoryTest.test_chromium_mac):
513         (FactoryTest.test_chromium_linux):
514         (FactoryTest.test_chromium_win):
515         (FactoryTest.test_unknown_specified):
516         (FactoryTest.test_unknown_default):
517         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
518         (TestGoogleChromePort):
519         (TestGoogleChromePort._verify_baseline_path):
520         (TestGoogleChromePort._verify_expectations_overrides):
521         (TestGoogleChromePort.test_get_google_chrome_port):
522         * Scripts/webkitpy/layout_tests/port/mac.py:
523         (MacPort):
524         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
525         (MacTest):
526         (assert_name):
527         (test_tests_for_other_platforms):
528         (test_version):
529         (test_versions):
530         (test_is_version_methods):
531         (test_setup_environ_for_server):
532         (_assert_search_path):
533         (test_show_results_html_file):
534         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
535         (PortTestCase):
536         (PortTestCase.make_port):
537         * Scripts/webkitpy/layout_tests/port/win.py:
538         (WinPort):
539         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
540         (WinPortTest):
541         (WinPortTest.test_show_results_html_file):
542         (WinPortTest._assert_search_path):
543         (WinPortTest._assert_version):
544
545 2012-01-11  Hugo Parente Lima  <hugo.lima@openbossa.org>
546
547         [Qt][WK2] Remove workaround introduced into bug 75470
548         https://bugs.webkit.org/show_bug.cgi?id=75889
549
550         Reviewed by Tor Arne Vestbø.
551
552         * MiniBrowser/qt/qml/BrowserWindow.qml:
553
554 2012-01-10  Dmitry Lomov  <dslomov@google.com>
555
556         [Chromium] Remove obsolete references to WebWorker class.
557         https://bugs.webkit.org/show_bug.cgi?id=76020
558
559         Reviewed by David Levin.
560
561         * DumpRenderTree/chromium/TestWebWorker.h: Removed.
562         * DumpRenderTree/chromium/WebViewHost.cpp:
563         * DumpRenderTree/chromium/WebViewHost.h:
564
565 2012-01-11  Csaba Osztrogonác  <ossy@webkit.org>
566
567         [Qt] Some css3 filter tests are failing after r104698
568         https://bugs.webkit.org/show_bug.cgi?id=76055
569
570         Reviewed by Simon Hausmann.
571
572         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
573         (LayoutTestController::overridePreference): Add WebKitAcceleratedCompositingEnabled preference.
574
575 2012-01-11  Tony Chang  <tony@chromium.org>
576
577         Don't remove 0 byte files when running build-webkit --chromium
578         https://bugs.webkit.org/show_bug.cgi?id=75997
579
580         Reviewed by Csaba Osztrogonác.
581
582         If QTDIR is set, isQt() is true even when running build-webkit --chromium.
583
584         * Scripts/webkitdirs.pm:
585         (determineIsQt):
586
587 2012-01-10  David Kilzer  <ddkilzer@apple.com>
588
589         Add TestWebKitAPI tests for KURL
590         <http://webkit.org/b/75774>
591
592         Reviewed by Adam Barth.
593
594         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add a
595         WebCore folder and KURL.cpp source file to the project.
596         * TestWebKitAPI/Tests/WebCore/KURL.cpp: Added.
597         (TestWebKitAPI::WebCore::SetUp): Initialize the main thread
598         during setup since this test doesn't go through WebKit or
599         WebKit2.
600         (TestWebKitAPI::TEST_F): Add two basic tests.
601
602 2012-01-10  David Kilzer  <ddkilzer@apple.com>
603
604         Extract common code for comparing WTF::String objects into WTFStringUtilities.h
605
606         Reviewed by Adam Barth.
607
608         Needed for: <http://webkit.org/b/75774> Add TestWebKitAPI tests for KURL
609
610         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add
611         WTFStringUtilities.h to the project.
612         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp: Update to use
613         WTFStringUtilities.h.
614         * TestWebKitAPI/WTFStringUtilities.h: Added.
615         (WTF::operator<<):
616
617 2012-01-10  Vincent Scheib  <scheib@chromium.org>
618
619         Clarify run-webkit-tests options reset-results and new-baseline
620         https://bugs.webkit.org/show_bug.cgi?id=75993
621
622         Reviewed by Dirk Pranke.
623
624         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
625         (parse_args):
626
627 2012-01-10  Simon Fraser  <simon.fraser@apple.com>
628
629         Disabled mock scrollbars should draw differently
630         https://bugs.webkit.org/show_bug.cgi?id=75995
631
632         Reviewed by James Robinson.
633
634         When the scrollbar is disabled, paint the entire track of
635         mock scrollbars with a lighter gray, and hide the thumb.
636
637         * DumpRenderTree/mac/DumpRenderTree.mm:
638         (-[DRTMockScroller drawKnob]):
639         (-[DRTMockScroller drawRect:]):
640
641 2012-01-10  James Robinson  <jamesr@chromium.org>
642
643         [chromium] Run webkit_unit_tests as part of webkit-patch build-and-test
644         https://bugs.webkit.org/show_bug.cgi?id=75988
645
646         Reviewed by Adam Barth.
647
648         * Scripts/webkitpy/common/config/ports.py:
649         (WebKitPort.run_webkit_unit_tests_command):
650         (WebKitPort):
651         (ChromiumPort.run_webkit_unit_tests_command):
652         (ChromiumPort):
653         * Scripts/webkitpy/common/config/ports_mock.py:
654         (MockPort.run_webkit_unit_tests_command):
655         * Scripts/webkitpy/tool/commands/download_unittest.py:
656         (DownloadCommandsTest.test_build_and_test):
657         (test_land):
658         (test_land_red_builders):
659         * Scripts/webkitpy/tool/steps/runtests.py:
660         (RunTests.run):
661         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
662
663 2012-01-09  Dirk Pranke  <dpranke@chromium.org>
664
665         webkitpy: add os_name, os_version to platforminfo
666         https://bugs.webkit.org/show_bug.cgi?id=75931
667
668         Reviewed by Eric Siedel.
669
670         As a first step in cleaning up the version parsing logic in
671         webkitpy.layout_tests.port, this adds common routines for
672         getting the os_name and os_version fields to the PlatformInfo
673         class. Nothing uses them yet but I've added FIXME's to some of
674         the code that needs to be deleted in the port files.
675
676         * Scripts/webkitpy/common/system/platforminfo.py:
677         (PlatformInfo.__init__):
678         (PlatformInfo):
679         (PlatformInfo._determine_os_name):
680         (PlatformInfo._determine_mac_version):
681         (PlatformInfo._determine_linux_version):
682         (PlatformInfo._determine_win_version):
683         (PlatformInfo.display_name):
684         (PlatformInfo.total_bytes_memory):
685         (PlatformInfo._compute_bytes_from_vm_stat_output):
686         (PlatformInfo.free_bytes_memory):
687         * Scripts/webkitpy/common/system/platforminfo_unittest.py: Added.
688         (TestPlatformInfo):
689         (TestPlatformInfo.make_info):
690         (TestPlatformInfo.make_info.mock_run_command):
691         (TestPlatformInfo.setUp):
692         (TestPlatformInfo.tearDown):
693         (TestPlatformInfo.test_basic):
694         (TestPlatformInfo.integration_test_basic):
695         (TestPlatformInfo.test_display_name_mac):
696         (TestPlatformInfo.test_display_name_win32):
697         (TestPlatformInfo.test_memory_mac):
698         (TestPlatformInfo.test_memory_win32):
699         (TestPlatformInfo.test_determine_os_name):
700         (TestPlatformInfo.test_determine_mac_version):
701         (TestPlatformInfo.test_determine_linux_version):
702         (TestPlatformInfo.test_determine_win_version_from_tuple):
703         (TestPlatformInfo.test_determine_win_version_from_cmd):
704         * Scripts/webkitpy/layout_tests/port/apple.py:
705         (ApplePort.__init__):
706         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
707         (ChromiumMacPort.__init__):
708         * Scripts/webkitpy/layout_tests/port/mac.py:
709         (MacPort):
710         * Scripts/webkitpy/layout_tests/port/win.py:
711         (WinPort):
712
713 2012-01-10  Adam Roben  <aroben@apple.com>
714
715         Make it possible to type data: URLs into MiniBrowser on Windows
716
717         Fixes <http://webkit.org/b/75084> Crash when trying to navigate to a data: URL in
718         MiniBrowser on Windows
719
720         Reviewed by Darin Adler.
721
722         * MiniBrowser/win/BrowserWindow.cpp:
723         (BrowserWindow::handleMessage): Instead of checking for an "http://" prefix when deciding
724         whether to prepend "http://", just look for whether the typed URL contains a colon. If it
725         does, we assume it already has a scheme and don't modify it.
726
727 2012-01-10  Adam Roben  <aroben@apple.com>
728
729         Make MiniBrowser automatically escape invalid URL characters typed in its URL field
730
731         Fixes <http://webkit.org/b/75086> Crash when typing a data: URL containing double-quotes in
732         MiniBrowser on Windows
733
734         Reviewed by Darin Adler.
735
736         * MiniBrowser/win/BrowserView.cpp:
737         (BrowserView::goToURL): Pass the typed string through
738         CFURLCreateStringByAddingPercentEscapes before trying to create a URL from it.
739
740 2012-01-10  Ben Wells  <benwells@chromium.org>
741
742         Adding myself (benwells) to committers.py
743         https://bugs.webkit.org/show_bug.cgi?id=75971
744
745         Reviewed by Ojan Vafai.
746
747         * Scripts/webkitpy/common/config/committers.py:
748
749 2012-01-10  Mario Sanchez Prada  <msanchez@igalia.com>
750
751         AX: support helpText() in DumpRenderTree
752         https://bugs.webkit.org/show_bug.cgi?id=40193
753
754         Reviewed by Chris Fleizach.
755
756         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
757         (AccessibilityUIElement::helpText): Implemented.
758
759 2012-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
760
761         Unreviewed, rolling out r104572.
762         http://trac.webkit.org/changeset/104572
763         https://bugs.webkit.org/show_bug.cgi?id=75967
764
765         It broke zillion tests (Requested by Ossy on #webkit).
766
767         * DumpRenderTree/qt/EventSenderQt.cpp:
768         (EventSender::EventSender):
769         (EventSender::sendOrQueueEvent):
770         (EventSender::replaySavedEvents):
771         (EventSender::eventFilter):
772         * DumpRenderTree/qt/EventSenderQt.h:
773
774 2012-01-10  Hugo Parente Lima  <hugo.lima@openbossa.org>
775
776         [Qt] fast/events/dont-loose-last-event test fails on WK1
777         https://bugs.webkit.org/show_bug.cgi?id=73894
778
779         Reviewed by Simon Hausmann.
780
781         Empty the entire event queue when requested besides using
782         sendEvent instead of postEvent to make sure all events were
783         delivered.
784         This commit also removes not working DRT code to handle drag and drop,
785         for more refs see: https://bugs.webkit.org/show_bug.cgi?id=31332
786
787         * DumpRenderTree/qt/EventSenderQt.cpp:
788         (EventSender::EventSender):
789         (EventSender::sendOrQueueEvent):
790         (EventSender::replaySavedEvents):
791         * DumpRenderTree/qt/EventSenderQt.h:
792
793 2012-01-10  No'am Rosenthal  <noam.rosenthal@nokia.com>
794
795         [Qt] Enable CSS_FILTERS in Qt build
796         https://bugs.webkit.org/show_bug.cgi?id=75777
797
798         Add the CSS_FILTERS feature flag to Qt.
799
800         Reviewed by Kenneth Rohde Christiansen.
801
802         * qmake/mkspecs/features/features.prf:
803
804 2012-01-10  Simon Hausmann  <simon.hausmann@nokia.com>
805
806         [Qt] Unreviewed -Werror build fix.
807
808         * MiniBrowser/qt/MiniBrowserApplication.cpp:
809         (MiniBrowserApplication::MiniBrowserApplication): Re-order initialization to match
810         declaration.
811
812 2012-01-10  Simon Hausmann  <simon.hausmann@nokia.com>
813
814         [Qt] Remove dependency to uitools
815         https://bugs.webkit.org/show_bug.cgi?id=75952
816
817         Reviewed by Tor Arne Vestbø.
818
819         QUiLoader is used for creating QLabel/QProgressBar widgets for
820         a layout test, to verify some widget embedding feature. Unfortunately
821         in Qt 5, QUiLoader is part of qttools, which depends on webkit, which
822         depends on qttools. Since we don't really _need_ QUiLoader for our tests,
823         let's break the circular dependency.
824
825         * DumpRenderTree/qt/DumpRenderTree.pro:
826         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
827         (WebCore::WebPage::createPlugin):
828         * QtTestBrowser/QtTestBrowser.pro:
829         * QtTestBrowser/launcherwindow.h:
830         * QtTestBrowser/webpage.cpp:
831         (WebPage::createPlugin):
832         * qmake/mkspecs/features/minimal_qt.prf:
833         * qmake/mkspecs/features/uitools.prf: Removed.
834
835 2012-01-10  Alexander Færøy  <alexander.faeroy@nokia.com>
836
837         [Qt] Don't expose m_windowOptions as part of the public interface in MiniBrowserApplication
838         https://bugs.webkit.org/show_bug.cgi?id=75894
839
840         Reviewed by Tor Arne Vestbø.
841
842         * MiniBrowser/qt/MiniBrowserApplication.h:
843         (MiniBrowserApplication::windowOptions):
844         * MiniBrowser/qt/main.cpp:
845         (main):
846
847 2012-01-10  Simon Hausmann  <simon.hausmann@nokia.com>
848
849         [Qt] DRT crashes with Qt 5
850         https://bugs.webkit.org/show_bug.cgi?id=75951
851
852         Reviewed by Ossy.
853
854         * DumpRenderTree/qt/fonts.conf: Add missing last-resort font fallback for Qt 5 where
855         Qt relies on font-config to define the default font family.
856
857 2012-01-10  Csaba Osztrogonác  <ossy@webkit.org>
858
859         [Qt] REGRESSION(r100130): Clean build feature is broken.
860         https://bugs.webkit.org/show_bug.cgi?id=75863
861
862         Reviewed by Tor Arne Vestbø.
863
864         * Scripts/webkitdirs.pm:
865         (buildQMakeProject):
866
867 2012-01-10  Zeno Albisser  <zeno@webkit.org>
868
869         [Qt][WK2] Fix keyboard shortcuts in MiniBrowser.
870         https://bugs.webkit.org/show_bug.cgi?id=75885
871
872         In QML events are propagated through parents. But since the
873         WebView may consume key events, a shortcut might never reach
874         the top QtQuickItem.
875         Therefore an application wide event handling function in C++
876         needs to take care of shortcuts for MiniBrowser.
877
878         Reviewed by Kenneth Rohde Christiansen.
879
880         * MiniBrowser/qt/BrowserWindow.cpp:
881         (BrowserWindow::reload):
882         (BrowserWindow::focusAddressBar):
883         * MiniBrowser/qt/BrowserWindow.h:
884         * MiniBrowser/qt/MiniBrowserApplication.cpp:
885         (MiniBrowserApplication::notify):
886         * MiniBrowser/qt/qml/BrowserWindow.qml:
887
888 2012-01-10  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
889
890         Add --efl alias for --platform=efl to run-webkit-test
891         https://bugs.webkit.org/show_bug.cgi?id=75937
892
893         Reviewed by Andreas Kling.
894         
895         * Scripts/run-webkit-tests: Add --efl alias.
896         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Add --efl alias.
897         (parse_args):
898
899 2012-01-09  Dan Bernstein  <mitz@apple.com>
900
901         -[DOMRange renderedImageForcingBlackText:] fails with non-user-selectable text
902         https://bugs.webkit.org/show_bug.cgi?id=75920
903
904         Reviewed by Darin Adler.
905
906         * TestWebKitAPI/Tests/mac/RenderedImageFromDOMRange.mm:
907         (TestWebKitAPI::TEST): Added a test for a range in a
908         -webkit-user-select: none; block.
909
910 2012-01-09  Dirk Pranke  <dpranke@chromium.org>
911
912         webkitpy.layout_tests.port.mock_drt_unittest.MockChromiumDRTTest has been failing on cr-win
913         https://bugs.webkit.org/show_bug.cgi?id=75884
914
915         Reviewed by Ryosuke Niwa.
916
917         Fix regression introduced (revealed?) in r104340. Chromium file         
918         url syntax is different on win32 and the test results weren't           
919         expecting that.                                                         
920
921         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
922         (TestExpectations._report_errors):
923         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
924         (test_parse_error_nonfatal):
925         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
926         (MockDRTTest.input_line):
927         (MockChromiumDRTTest.test_pixeltest__fails):
928         * Scripts/webkitpy/layout_tests/port/test.py:
929         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
930         (TestRebaseliner.make_rebaseliner):
931         (TestRebaseliner.test_one_platform):
932         (TestRebaseliner.test_all_platforms):
933         (TestRebaseliner.test_png_file_with_comment):
934         (TestRebaseliner.test_png_file_with_comment_remove_old_checksum):
935         (TestRebaseliner.test_png_file_with_comment_as_duplicate):
936         (TestRealMain.test_all_platforms):
937
938 2012-01-09  Dirk Pranke  <dpranke@chromium.org>
939
940         Fix regression in test-webkitpy introduced by removing the webkitpy/python24 directory.
941
942         Unreviewed, build fix.
943
944         test-webkitpy had a built-in self-test routine to verify that
945         deleting the .pyc files worked correctly. When I removed the
946         python24 directory in r104482, I broke the self-test.
947
948         I have deleted the self-test for now. Since I am reworking
949         test-webkitpy I will make sure the new version is adequately
950         tested.
951
952         * Scripts/test-webkitpy:
953         (configure_logging):
954         (_clean_pyc_files):
955         (_clean_packages):
956         (init):
957
958 2012-01-09  Justin Novosad  <junov@chromium.org>
959
960         [Chromium] remove all references to the legacy accelerated 2d Canvas
961         implementation
962         https://bugs.webkit.org/show_bug.cgi?id=75108
963
964         Purging an old settings flag that is no longer referenced
965
966         Reviewed by Darin Fisher.
967
968         * DumpRenderTree/chromium/DumpRenderTree.cpp:
969         (main):
970         * DumpRenderTree/chromium/TestShell.cpp:
971         (TestShell::TestShell):
972         (TestShell::resetWebSettings):
973         * DumpRenderTree/chromium/TestShell.h:
974         (TestShell::setAccelerated2dCanvasEnabled):
975         * DumpRenderTree/chromium/WebPreferences.cpp:
976         (WebPreferences::reset):
977         (WebPreferences::applyTo):
978         * DumpRenderTree/chromium/WebPreferences.h:
979
980 2012-01-09  Adam Roben  <aroben@apple.com>
981
982         Convert Cygwin paths to Windows paths before passing them to DRT
983
984         Fixes <http://webkit.org/b/64468> <rdar://problem/10663409> WIN: DumpRenderTree hangs under
985         NRWT
986
987         I couldn't find a way to test this because I couldn't figure out how to override the
988         cygpath function as it is used by WebKitDriver.
989
990         Reviewed by Dirk Pranke.
991
992         * Scripts/webkitpy/layout_tests/port/webkit.py:
993         (WebKitDriver._command_from_driver_input): On Cygwin, convert the test's path to a
994         Windows-style path before passing it to DRT.
995
996 2012-01-06  Dirk Pranke  <dpranke@chromium.org>
997
998         webkitpy: revamp version checking
999         https://bugs.webkit.org/show_bug.cgi?id=75765
1000
1001         Reviewed by Adam Barth.
1002
1003         The version-checking code in webkitpy/python24/versioning seems really
1004         awkward and overdesigned, especially since we don't support python 2.4
1005         any more.
1006
1007         In addition, I am tired of getting warnings about Python 2.6 being "a
1008         newer release than what is supported" :).
1009
1010         I'm taking a page from the depot_tools python code and just creating a
1011         new webkitpy.common.version_check module that will print a message on
1012         stderr and call sys.exit() if we're running an unsupported version.
1013
1014         * Scripts/check-webkit-style:
1015         * Scripts/new-run-webkit-httpd:
1016         * Scripts/new-run-webkit-tests:
1017         * Scripts/rebaseline-chromium-webkit-tests:
1018         * Scripts/test-webkitpy:
1019         (configure_logging):
1020         (init):
1021         * Scripts/webkit-patch:
1022         (main):
1023         * Scripts/webkitpy/common/system/executive.py:
1024         (Executive._child_process_encoding):
1025         (Executive._should_encode_child_process_arguments):
1026         * Scripts/webkitpy/common/version_check.py: Copied from Tools/Scripts/rebaseline-chromium-webkit-tests.
1027         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1028         * Scripts/webkitpy/python24/__init__.py: Removed.
1029         * Scripts/webkitpy/python24/versioning.py: Removed.
1030         * Scripts/webkitpy/python24/versioning_unittest.py: Removed.
1031
1032 2012-01-09  Adam Barth  <abarth@webkit.org>
1033
1034         Remove Chromium Mac CG from the flakiness dashboard
1035         https://bugs.webkit.org/show_bug.cgi?id=75873
1036
1037         Reviewed by Ojan Vafai.
1038
1039         This configuration no longer exists.
1040
1041         * TestResultServer/static-dashboards/builders.js:
1042         * TestResultServer/static-dashboards/flakiness_dashboard.html:
1043         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
1044         (testOverrideJustBuildType):
1045         (testPlatformAndBuildType):
1046
1047 2012-01-06  Adam Roben  <aroben@apple.com>
1048
1049         Print an error message when NRWT can't run Apache
1050
1051         Fixes <http://webkit.org/b/75712> NRWT mysteriously exits when Apache returns an error code
1052
1053         Reviewed by Dirk Pranke.
1054
1055         * Scripts/webkitpy/layout_tests/port/base.py:
1056         (Port.check_httpd): Print an error message when Apache returns an error code instead of
1057         failing silently.
1058
1059         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1060         (PortTest.test_check_httpd_success): Test that we don't print anything when we successfully
1061         run Apache.
1062         (PortTest.test_httpd_returns_error_code): Test that we print an error message when Apache
1063         fails.
1064
1065 2012-01-09  Gabor Rapcsanyi  <rgabor@webkit.org>
1066
1067         [Gtk][ARM] Cross compiler buildbot is failing after r103040
1068         https://bugs.webkit.org/show_bug.cgi?id=75846
1069
1070         Reviewed by Philippe Normand.
1071
1072         * Scripts/webkitdirs.pm:
1073         (runAutogenForAutotoolsProjectIfNecessary):
1074
1075 2012-01-09  Alexander Færøy  <ahf@0x90.dk>
1076
1077         [Qt] Add support for dynamically enabling and disabling touch mocking in the Qt MiniBrowser
1078         https://bugs.webkit.org/show_bug.cgi?id=75807
1079
1080         This patch adds a new icon to navigationbar of the Qt MiniBrowser
1081         which allows you to dynamically toggle whether touch mocking is
1082         enabled or disabled.
1083
1084         Reviewed by Tor Arne Vestbø.
1085
1086         * MiniBrowser/qt/MiniBrowser.qrc:
1087         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1088         (MiniBrowserApplication::notify):
1089         * MiniBrowser/qt/MiniBrowserApplication.h:
1090         (WindowOptions::WindowOptions):
1091         (WindowOptions::touchMockingEnabled):
1092         (WindowOptions::setTouchMockingEnabled):
1093         * MiniBrowser/qt/icons/touch.png: Added.
1094         * MiniBrowser/qt/qml/BrowserWindow.qml:
1095
1096 2012-01-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1097
1098         Unreviewed. Fix make distcheck issues.
1099
1100         * MiniBrowser/gtk/GNUmakefile.am:
1101
1102 2012-01-08  Sheriff Bot  <webkit.review.bot@gmail.com>
1103
1104         Unreviewed, rolling out r104421.
1105         http://trac.webkit.org/changeset/104421
1106         https://bugs.webkit.org/show_bug.cgi?id=75816
1107
1108         Need to rebaseline some tests on Linux (Requested by noamr on
1109         #webkit).
1110
1111         * qmake/mkspecs/features/features.prf:
1112
1113 2012-01-08  Adam Barth  <abarth@webkit.org>
1114
1115         Remove support for Chromium Mac CG from garden-o-matic
1116         https://bugs.webkit.org/show_bug.cgi?id=75814
1117
1118         Reviewed by Eric Seidel.
1119
1120         This configuration no longer exists.  This patch is mostly a matter of
1121         updating config.js and removing the examples from the unit tests.
1122
1123         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
1124         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1125         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
1126         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
1127         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
1128
1129 2012-01-08  No'am Rosenthal  <noam.rosenthal@nokia.com>
1130
1131         [Qt] Enable CSS_FILTERS in Qt build
1132         https://bugs.webkit.org/show_bug.cgi?id=75777
1133
1134         Add the CSS_FILTERS feature flag to Qt.
1135
1136         Reviewed by Kenneth Rohde Christiansen.
1137
1138         * qmake/mkspecs/features/features.prf:
1139
1140 2012-01-08  Ryosuke Niwa  <rniwa@webkit.org>
1141
1142         Categorize bots by ports instead of core/non-core separation
1143         https://bugs.webkit.org/show_bug.cgi?id=75766
1144
1145         Reviewed by Eric Seidel.
1146
1147         Rename categorizes so as to preserve the original ordering of bots per Eric's suggestion
1148         (Chromium still comes before GTK and Qt).
1149
1150         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1151         (loadBuilderConfig):
1152         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1153
1154 2012-01-08  Ryosuke Niwa  <rniwa@webkit.org>
1155
1156         Remove the concept of core builders from webkitpy
1157         https://bugs.webkit.org/show_bug.cgi?id=75809
1158
1159         Reviewed by Ryosuke Niwa.
1160
1161         Treat all bots equally since core/non-core sepration has been removed from build.webkit.org,
1162         and remove the relevant code.
1163
1164         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1165         (BuildBot.__init__):
1166         (BuildBot._matches_regexps):
1167         (BuildBot._builder_statuses_with_names_matching_regexps):
1168         (BuildBot.builder_statuses):
1169         (BuildBot.failure_map):
1170         (BuildBot._latest_builds_from_builders):
1171         (BuildBot.last_green_revision):
1172         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
1173         (MockBuildBot.builder_statuses):
1174         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1175         (test_status_parsing):
1176         (test_last_green_revision):
1177         (test_last_green_revision.mock_builds_from_builders):
1178
1179 2012-01-08  Adam Barth  <abarth@webkit.org>
1180
1181         Remove Chromium Mac CG concept from webkitpy
1182         https://bugs.webkit.org/show_bug.cgi?id=75810
1183
1184         Reviewed by Ryosuke Niwa.
1185
1186         This configuration no longer exists.  We can remove all the supporting
1187         code from webkitpy.
1188
1189         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
1190         (BaselineOptimizerTest.test_move_baselines):
1191         (BaselineOptimizerTest.test_chromium_covers_mac_win_linux):
1192         (BaselineOptimizerTest.test_chromium_mac_redundant_with_apple_mac):
1193         (BaselineOptimizerTest.test_common_directory_includes_root):
1194         (BaselineOptimizerTest.test_complex_shadowing):
1195         * Scripts/webkitpy/common/config/build.py:
1196         (_should_file_trigger_build):
1197         * Scripts/webkitpy/common/config/build_unittest.py:
1198         (ShouldBuildTest):
1199         * Scripts/webkitpy/layout_tests/port/builders.py:
1200         * Scripts/webkitpy/layout_tests/port/chromium.py:
1201         (ChromiumPort):
1202         (ChromiumPort._generate_all_test_configurations):
1203         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1204         (_default_tests_paths):
1205         (ChromiumGpuLinuxPort.tests):
1206         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1207         (ChromiumGpuTest.integration_test_chromium_gpu_mac):
1208         (ChromiumGpuTest.assert_port_works):
1209         (ChromiumGpuTest.test_baseline_paths):
1210         (ChromiumGpuTest.test_graphics_type):
1211         (ChromiumGpuTest.test_default_tests_paths):
1212         (ChromiumGpuTest.test_test_files):
1213         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1214         (ChromiumMacPort):
1215         (ChromiumMacPort.__init__):
1216         (ChromiumMacPort.baseline_search_path):
1217         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1218         (ChromiumMacPortTest.test_graphics_type):
1219         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1220         (ChromiumPortTest.test_all_test_configurations):
1221         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1222         * Scripts/webkitpy/layout_tests/port/factory.py:
1223         (PortFactory._port_name_from_arguments_and_options):
1224         (PortFactory.get):
1225         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1226         (FactoryTest.test_chromium_gpu_mac):
1227         (FactoryTest.test_chromium_mac):
1228         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1229         (GetGoogleChromePortTest._verify_expectations_overrides):
1230         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1231         (MockChromiumDRTTest.test_chromium_parse_options):
1232         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
1233         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
1234         (test_url_fetcher):
1235         (test_zip_factory):
1236         (test_archive):
1237         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1238         (TestRebaseline.test_rebaseline_expectations):
1239
1240 2012-01-08  Ryosuke Niwa  <rniwa@webkit.org>
1241
1242         Categorize bots by ports instead of core/non-core separation
1243         https://bugs.webkit.org/show_bug.cgi?id=75766
1244
1245         Reviewed by Adam Barth.
1246
1247         Get rid of the concept of core/non-core builders, and categorize build bots by ports instead.
1248
1249         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1250         (loadBuilderConfig):
1251         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1252
1253 2012-01-08  Sheriff Bot  <webkit.review.bot@gmail.com>
1254
1255         Unreviewed, rolling out r104403.
1256         http://trac.webkit.org/changeset/104403
1257         https://bugs.webkit.org/show_bug.cgi?id=75803
1258
1259         It broke all tests on Qt5 (Requested by Ossy_weekend on
1260         #webkit).
1261
1262         * qmake/mkspecs/features/features.prf:
1263
1264 2012-01-08  No'am Rosenthal  <noam.rosenthal@nokia.com>
1265
1266         [Qt] Enable CSS_FILTERS in Qt build
1267         https://bugs.webkit.org/show_bug.cgi?id=75777
1268
1269         Add the CSS_FILTERS feature flag to Qt.
1270
1271         Reviewed by Kenneth Rohde Christiansen.
1272
1273         * qmake/mkspecs/features/features.prf:
1274
1275 2012-01-04  Kentaro Hara  <haraken@chromium.org>
1276
1277         Rewrite the CSS parser of prepare-ChangeLog with unittests.
1278         https://bugs.webkit.org/show_bug.cgi?id=75202
1279
1280         Reviewed by David Kilzer.
1281
1282         The current CSS parser can just parse simple CSSes like
1283
1284             foo bar baz {
1285                 property1: value;
1286                 property2: value;
1287             }
1288
1289         , and cannot parse comments nor a CSS in which a selector and {
1290         appears in different lines. This patch rewrites the CSS parser
1291         (i.e. get_selector_line_ranges_for_css()) so that it can parse more CSSes
1292         shown in css_unittests.css.
1293
1294         Test: Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests.css
1295
1296         * Scripts/prepare-ChangeLog:
1297         (get_selector_line_ranges_for_css):
1298         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
1299         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests-expected.txt: Added.
1300         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests.css: Added.
1301         (element1):
1302         (element2):
1303         (element3):
1304         (element4.p):
1305         (element5.p.q.r.s):
1306         (element6#p):
1307         (element7 element8):
1308         (element9.p element10.q):
1309         (element11#p element12#q):
1310         (element13, element14):
1311         (.p):
1312         (#p):
1313         (.p element15 #q element16.r element17#s):
1314         (element18:target):
1315         (element19):
1316         (element20):
1317         (element21):
1318         (element22):
1319
1320 2012-01-04  Kentaro Hara  <haraken@chromium.org>
1321
1322         The Perl parser of prepare-ChangeLog can parse here-documents
1323         https://bugs.webkit.org/show_bug.cgi?id=73208
1324
1325         Reviewed by David Kilzer.
1326
1327         Currently prepare-ChangeLog cannot recognize here-documents in Perl,
1328         which results in wrong subroutine names in ChangeLogs.
1329         With this patch, prepare-ChangeLog can judge whether the line of "}"
1330         is the end of a subroutine or a line inside a here-document.
1331
1332         Test: Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl
1333
1334         * Scripts/prepare-ChangeLog:
1335         (get_function_line_ranges_for_perl):
1336         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt:
1337         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl:
1338         Added test cases for here-documents.
1339         (func7):
1340         (func8):
1341         (func9):
1342         (func10):
1343         (func11):
1344         (func12):
1345         (func13):
1346         (func14):
1347         (func15):
1348         (func16):
1349
1350 2012-01-08  Kentaro Hara  <haraken@chromium.org>
1351
1352         Add unittests for the JavaScript parser of prepare-ChangeLog
1353         https://bugs.webkit.org/show_bug.cgi?id=75201
1354
1355         Reviewed by David Kilzer.
1356
1357         javascript_unittests.js is a unittest for get_function_line_ranges_for_javascript()
1358         of prepare-ChangeLog.
1359
1360         * Scripts/prepare-ChangeLog:
1361         (get_function_line_ranges_for_javascript): Before this patch, a string found was just
1362         omitted from parsing. Thus,
1363
1364             str = "foo"
1365             function func() {
1366             }
1367
1368         was recognized as equivalent to
1369
1370             str = function func() {
1371             }
1372
1373         This patch replaces a string with a dummy identifier 'string_appeared_here'
1374         to tell the parser that a string appeared there.
1375
1376         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
1377         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt: Added.
1378         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests.js: Added.
1379         (func1):
1380         (func2):
1381         (func3):
1382         (func4):
1383         (func5):
1384         (func6):
1385         (func7):
1386         (func8):
1387         (func9):
1388         (func10):
1389         (func11):
1390         (func12):
1391         (funcOverloaded):
1392         (Func1.prototype.get x1):
1393         (Func1.prototype.get x2):
1394         (Func1.prototype.set x1):
1395         (Func1.prototype.set x3):
1396         (Func2.prototype.func13):
1397         (Func2.prototype.func14):
1398         (Func2.prototype.func15):
1399         (func16.func17):
1400         (func16.func18):
1401         (func16.func19):
1402         (func16):
1403
1404 2012-01-08  David Levin  <levin@chromium.org>
1405
1406         [chromium] Add layout test support for autosize code in FrameView.
1407         https://bugs.webkit.org/show_bug.cgi?id=73631
1408
1409         Reviewed by Dmitry Titov.
1410
1411         * DumpRenderTree/chromium/LayoutTestController.cpp:
1412         (LayoutTestController::LayoutTestController): Expose the new autoresize method.
1413         (LayoutTestController::reset): Set the autoresize mode back to false.
1414         (LayoutTestController::enableAutoResizeMode): A way to turn on autoresizing from javascript code in DumpRenderTree.
1415         * DumpRenderTree/chromium/LayoutTestController.h:
1416         * DumpRenderTree/chromium/WebViewHost.cpp:
1417         (WebViewHost::didAutoResize): Handle the autoresize callback so that the outer bounds change appropriately.
1418         * DumpRenderTree/chromium/WebViewHost.h:
1419
1420 2012-01-07  Zan Dobersek  <zandobersek@gmail.com>
1421
1422         [WK2][GTK] Each test takes roughly half a second to load
1423         https://bugs.webkit.org/show_bug.cgi?id=70699
1424
1425         Reviewed by Martin Robinson.
1426
1427         Set the XDG_CACHE_HOME environment variable when testing with
1428         WebKitTestRunner. This way the testing is started with a non-existing
1429         application cache. If the cache exists and is not empty, the emptying
1430         and vacuuming that is performed before every test can consume a lot of
1431         time.
1432
1433         This is just a temporary workaround until it becomes possible to set
1434         a desired directory to be used as the application cache location through
1435         WebKitWebContext.
1436
1437         * Scripts/webkitpy/layout_tests/port/gtk.py:
1438         (GtkPort.setup_environ_for_server):
1439
1440 2012-01-07  Zan Dobersek  <zandobersek@gmail.com>
1441
1442         [GTK] Enable requestAnimationFrame in build-webkit
1443         https://bugs.webkit.org/show_bug.cgi?id=75773
1444
1445         Reviewed by Martin Robinson.
1446
1447         Enable requestAnimationFrame for the Gtk port.
1448
1449         * Scripts/build-webkit:
1450
1451 2012-01-06  Jarred Nicholls  <jarred@sencha.com>
1452
1453         Unreviewed build-webkit fix for Chromium to properly use make if gyp generates Makefiles.
1454
1455         * Scripts/webkitdirs.pm:
1456         (buildChromium):
1457         Missing parentheses.
1458
1459 2012-01-06  Simon Fraser  <simon.fraser@apple.com>
1460
1461         Fix DRT build on case-sensitive file systems.
1462
1463         Fix case of include of WebDynamicScrollBarsView.h
1464         
1465         * DumpRenderTree/mac/DumpRenderTree.mm:
1466
1467 2012-01-06  Simon Fraser  <simon.fraser@apple.com>
1468
1469         Pixel results from DumpRenderTree and WebKitTestRunner don't match because of colorspace issues
1470         https://bugs.webkit.org/show_bug.cgi?id=75662
1471
1472         Reviewed by Dan Bernstein.
1473         
1474         The pixel results generated by DumpRenderTree and WebKitTestRunner differed because
1475         of color profile issues. Fix by keeping everything in device RGB and ensuring that the
1476         test window uses the main display's color space, so that the pixel values in the bitmap
1477         that gets checksummed are identical to the CSS colors.
1478         
1479         Removed the code that switches the display profile in DRT, since that is no longer required.
1480
1481         * DumpRenderTree/PixelDumpSupport.h: Remove unused function declarations.
1482         * DumpRenderTree/mac/DumpRenderTree.mm:
1483         (crashHandler): Remove code that switches display profiles.
1484         (prepareConsistentTestingEnvironment): Ditto.
1485         (dumpRenderTree): Ditto.
1486         * DumpRenderTree/mac/PixelDumpSupportMac.mm: Ditto.
1487         (createBitmapContext): Use DeviceRGB for the bitmap colorspace.
1488         (createBitmapContextFromWebView): Add comment about the colorspace handling.
1489         * WebKitTestRunner/cg/TestInvocationCG.cpp:
1490         (WTR::createCGContextFromImage): Use a RetainPtr, add comment.
1491         (WTR::computeMD5HashStringForContext): Simplify the #ifdefs around the braces.
1492         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1493         (WTR::PlatformWebView::PlatformWebView): Set the window's colorspace to that of the main display.
1494         (WTR::PlatformWebView::windowSnapshotImage): Add comment about colorspaces.
1495
1496 2012-01-06  David Kilzer  <ddkilzer@apple.com>
1497
1498         run-api-tests: specify individual suites and tests on the command-line
1499
1500         Reviewed by Adam Roben.
1501
1502         Fixes: <http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests
1503
1504         The run-api-tests script will now accept a list of arguments on
1505         the command-line that are used as prefix filters.  To run all
1506         tests in a suite that starts with "WTF" (WTF and WTF_Vector)
1507         use:
1508
1509             $ run-api-tests WTF
1510
1511         To run only the tests in the "WTF" suite, not the "WTF_Vector"
1512         suite, use:
1513
1514             $ run-api-tests WTF.
1515
1516         * Scripts/run-api-tests: Filter tests if any prefix arguments
1517         are passed on the command-line.
1518
1519 2012-01-06  David Kilzer  <ddkilzer@apple.com>
1520
1521         run-api-tests: change internal representation of tests to array of "SuiteName.TestName" strings
1522
1523         Reviewed by Adam Roben.
1524
1525         Part of: <http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests
1526
1527         * Scripts/run-api-tests:
1528         (dumpTestsBySuite): Update to accept array of tests instead of
1529         hash data structure.
1530         (runTestsBySuite): Ditto.
1531         (listAllTests): Rename from populateTests().  Update to return
1532         an array of tests instad of the hash data structure.
1533
1534 2012-01-05  Dirk Pranke  <dpranke@chromium.org>
1535
1536         webkitpy: clean up test/uri conversion routines
1537         https://bugs.webkit.org/show_bug.cgi?id=75648
1538
1539         Reviewed by Eric Seidel.
1540
1541         This change moves test_to_uri and uri_to_test from the Port
1542         class to the Driver class (the routines were only being
1543         called by the drivers), and removes a bunch of stale and/or
1544         busted logic.
1545
1546         * Scripts/webkitpy/layout_tests/port/base.py:
1547         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1548         * Scripts/webkitpy/layout_tests/port/chromium.py:
1549         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1550         * Scripts/webkitpy/layout_tests/port/driver.py:
1551         (is_http_test):
1552         (test_to_uri):
1553         (uri_to_test):
1554         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1555         (run_one_test):
1556         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1557         (MockDRTTest.input_line):
1558         (input_line):
1559         (expected_output):
1560         * Scripts/webkitpy/layout_tests/port/test.py:
1561         * Scripts/webkitpy/layout_tests/port/webkit.py:
1562         (_command_from_driver_input):
1563
1564 2012-01-06  Simon Fraser  <simon.fraser@apple.com>
1565
1566         Mitigate scrollbar differences when running pixel tests
1567         https://bugs.webkit.org/show_bug.cgi?id=67217
1568
1569         Reviewed by Dan Bernstein.
1570         
1571         Add an NSScroller subclass that draws mock scrollbars identically
1572         to the WebCore mock scrollbar theme, and register it with the
1573         WebDynamicScrollbarsView.
1574
1575         * DumpRenderTree/mac/DumpRenderTree.mm:
1576         (-[DRTMockScroller rectForPart:]):
1577         (-[DRTMockScroller drawKnob]):
1578         (-[DRTMockScroller drawRect:]):
1579         (registerMockScrollbars):
1580         (prepareConsistentTestingEnvironment):
1581
1582 2012-01-05  Jon Lee  <jonlee@apple.com>
1583
1584         Update DRT on Mac to draw resize handles on text areas.
1585
1586         Reviewed by John Sullivan.
1587
1588         Enable resize handles on text areas so that we don't have to create two different sets of pixel test results,
1589         between WK1 and WK2. This will require rebaselining existing textarea pixel tests.
1590
1591         * DumpRenderTree/mac/DumpRenderTree.mm:
1592         (resetDefaultsToConsistentValues):
1593
1594 2012-01-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1595
1596         [Qt] Move listing of include paths and libs to pri files in sources
1597
1598         Includepaths are sometimes modified by non-Qt contributors so keeping
1599         them in files inside Sources makes it more likely that they are updated
1600         along with project files for the other ports.
1601
1602         Using pri files instead of prf files for this also has the benefit that
1603         the include() from the main target file can be parsed and followed by
1604         Qt Creator -- something that does not work with load().
1605
1606         Dependency from a target to a library through the WEBKIT variable are
1607         handled through forwarding-files in Tools/qmake/mkspecs/modules, which
1608         set the source root of the module and include the right pri file.
1609
1610         Ideally we'd use the variant of include() that takes an optional
1611         namespace to read the variables into, or the fromfile() function,
1612         but both of these add an overhead of about 40% on the total qmake
1613         runtime, due to making a deep copy of all the variables in the
1614         project or re-reading all the prf files from scratch.
1615
1616         Reviewed by Simon Hausmann.
1617         Reviewed by Ossy.
1618
1619         * qmake/mkspecs/features/default_post.prf:
1620         * qmake/mkspecs/modules/javascriptcore.prf: Added.
1621         * qmake/mkspecs/modules/webcore.prf: Added.
1622         * qmake/mkspecs/modules/webkit2.prf: Added.
1623         * qmake/mkspecs/modules/wtf.prf: Added.
1624
1625 2012-01-06  JungJik Lee  <jungjik.lee@samsung.com>
1626
1627         [EFL] Add pre-render handling code in EWebLauncher.
1628         https://bugs.webkit.org/show_bug.cgi?id=73430
1629
1630         Reviewed by Zoltan Herczeg.
1631
1632         Add pre-render handling code by pressing Insert key.
1633
1634         * EWebLauncher/main.c:
1635         (on_key_down):
1636
1637 2012-01-06  Csaba Osztrogonác  <ossy@webkit.org>
1638
1639         NRWT should use test_expectation.txt on wk2 platforms
1640         https://bugs.webkit.org/show_bug.cgi?id=75417
1641
1642         Reviewed by Dirk Pranke.
1643
1644         * Scripts/webkitpy/layout_tests/port/webkit.py:
1645         (path_to_test_expectations_file):
1646         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1647         (test_path_to_test_expectations_file):
1648
1649 2012-01-05  Jochen Eisinger  <jochen@chromium.org>
1650
1651         Don't hardcode expected file URIs in as they depend on the platform
1652         https://bugs.webkit.org/show_bug.cgi?id=75666
1653
1654         Reviewed by Dirk Pranke.
1655
1656         * Scripts/webkitpy/layout_tests/port/win.py:
1657         (WinPort.show_results_html_file):
1658         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1659         (MainTest.test_unexpected_failures):
1660         (MainTest.test_results_directory_default):
1661         (MainTest.test_results_directory_relative):
1662
1663 2012-01-05  Anders Carlsson  <andersca@apple.com>
1664
1665         Crash when trying to invalidate the NPRuntimeObjectMap for a plug-in in a subframe
1666         https://bugs.webkit.org/show_bug.cgi?id=75667
1667         <rdar://problem/10389454>
1668
1669         Reviewed by Kevin Decker.
1670
1671         Add an evaluate method to the plug-in test scriptable object that can be used to evaluate a given JS string.
1672
1673         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1674         (PluginTest::executeScript):
1675         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
1676         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeObjectFromDestroyedPlugin.cpp:
1677         (NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::hasMethod):
1678         (NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::invoke):
1679         (NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::hasProperty):
1680
1681 2012-01-05  Dirk Pranke  <dpranke@chromium.org>
1682
1683         webkitpy: clean up port factory methods
1684         https://bugs.webkit.org/show_bug.cgi?id=75590
1685
1686         Reviewed by Eric Seidel.
1687
1688         This change consolidates much of the "factory method" logic
1689         of determining which port objects to create for a given set
1690         of configurations by merging the separate factory methods in
1691         chromium_gpu and google_chrome into PortFactory so that at least
1692         all of the logic is in one place.
1693
1694         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1695         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1696         * Scripts/webkitpy/layout_tests/port/factory.py:
1697         (_port_name_from_arguments_and_options):
1698         (get):
1699         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1700         (test_google_chrome):
1701         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
1702         (GoogleChromeLinux32Port):
1703         (GoogleChromeLinux32Port.baseline_search_path):
1704         (test_expectations_overrides):
1705         (architecture):
1706         (GoogleChromeLinux64Port):
1707         (GoogleChromeLinux64Port.baseline_search_path):
1708         (GoogleChromeMacPort):
1709         (GoogleChromeMacPort.baseline_search_path):
1710         (GoogleChromeWinPort):
1711         (GoogleChromeWinPort.baseline_search_path):
1712         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1713         (_verify_baseline_path):
1714
1715 2012-01-05  Jochen Eisinger  <jochen@chromium.org>
1716
1717         Replace webkitpy.common.system.filesystem.file_path_as_url with webkitpy.common.system.path.abspath_to_uri
1718         https://bugs.webkit.org/show_bug.cgi?id=75617
1719
1720         Reviewed by Dirk Pranke.
1721
1722         * Scripts/webkitpy/common/system/filesystem.py:
1723         (FileSystem.exists):
1724         * Scripts/webkitpy/common/system/filesystem_mock.py:
1725         (MockFileSystem.exists):
1726         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1727         (GenericFileSystemTests.teardown_generic_test_dir):
1728         * Scripts/webkitpy/layout_tests/port/base.py:
1729         (Port.to.show_results_html_file):
1730         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1731         (MainTest.test_results_directory_absolute):
1732
1733 2012-01-05  Adam Roben  <aroben@apple.com>
1734
1735         Remove some unnecessary code from old-run-webkit-tests
1736
1737         Thanks to r104187/r104188, we no longer need to set PATH before launching DumpRenderTree or
1738         WebKitTestRunner.
1739
1740         Fixes <http://webkit.org/b/75640> ORWT unnecessarily sets PATH before launching DRT/WTR on
1741         Windows
1742
1743         Reviewed by Eric Seidel.
1744
1745         * Scripts/old-run-webkit-tests:
1746         (top level):
1747         (openDumpTool):
1748         Removed calls to setPathForRunningWebKitApp.
1749
1750 2012-01-05  Adam Roben  <aroben@apple.com>
1751
1752         Teach NRWT to use run-safari to open results.html on Apple's Windows port
1753
1754         NRWT was trying to use User.open_url, which doesn't work on Cygwin. But run-safari is
1755         better, since we always want to open results.html using the user's build of WebKit, not
1756         whatever their default browser is.
1757
1758         Fixes <http://webkit.org/b/75629> <rdar://problem/10648621> NRWT fails to open results.html
1759         for Apple's Windows port
1760
1761         Reviewed by Eric Seidel.
1762
1763         * Scripts/webkitpy/layout_tests/port/win.py:
1764         (WinPort.show_results_html_file): Changed to use run_safari, like MacPort does. Also removed
1765         an obsolete comment.
1766
1767         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
1768         (WinPortTest.test_show_results_html_file): Updated expected results.
1769
1770 2012-01-05  Adam Roben  <aroben@apple.com>
1771
1772         Prepend Safari.exe's path to the command-line passed to CreateProcess
1773
1774         Safari expects the first argument in the command-line to be the path to Safari.exe itself.
1775         This is how things get set up when Safari is launched normally (e.g., by Explorer). Safari
1776         thus ignores the first argument when looking for command-line arguments. WebKitLauncherWin
1777         was not including the path to Safari.exe in the command-line, so Safari was ignoring the
1778         first argument that WebKitLauncherWin was trying to pass to it.
1779
1780         Fixes <http://webkit.org/b/56571> First argument passed to WebKit.exe is ignored by Safari
1781
1782         Reviewed by Steve Falkenburg.
1783
1784         * WebKitLauncherWin/WebKitLauncherWin.cpp:
1785         (_tWinMain): Construct a command-line for CreateProcess that first contains a double-quoted
1786         path to Safari.exe, then contains any arguments that were passed to WebKitLauncherWin.
1787
1788 2012-01-05  Adam Roben  <aroben@apple.com>
1789
1790         Stop using explicit memory management in WebKitLauncherWin
1791
1792         We now use stack-allocated STL objects instead.
1793
1794         Prep work for <http://webkit.org/b/56571> First argument passed to WebKit.exe is ignored by
1795         Safari
1796
1797         Reviewed by Steve Falkenburg.
1798
1799         * WebKitLauncherWin/WebKitLauncherWin.cpp:
1800         (getStringValue):
1801         (applePathFromRegistry):
1802         (safariInstallDir):
1803         (safariBrowserExe):
1804         (_tWinMain):
1805         Changed to use stack-allocated STL objects instead of malloc/free.
1806
1807 2012-01-05  Adam Roben  <aroben@apple.com>
1808
1809         Turn WebKitTestRunner into a stub .exe launcher and a .dll that contains all the real code
1810
1811         This allows us to add the Safari and Apple Application Support directories to PATH before
1812         trying to load WebKit so that SafariTheme.dll, CoreGraphics.dll and friends can be found.
1813
1814         Fixes <http://webkit.org/b/75486> <rdar://problem/10638124> NRWT fails to launch Apple's
1815         Windows port of DumpRenderTree/WebKitTestRunner
1816
1817         Reviewed by Steve Falkenburg.
1818
1819         * WebKitTestRunner/WebKitTestRunner.sln: Added WebKitTestRunnerLauncher and
1820         ImageDiffLauncher, which I forgot to add to this .sln when that project was created.
1821
1822         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
1823         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1824         Changed to build WebKitTestRunner.dll instead of WebKitTestRunner.exe.
1825
1826         * WebKitTestRunner/win/WebKitTestRunnerLauncher.vcproj: Copied from
1827         Tools/WebKitTestRunner/win/WebKitTestRunner.vcproj but changed to build
1828         the stub launcher.
1829
1830         * WebKitTestRunner/win/WebKitTestRunnerLauncherCommon.vsprops: Added.
1831         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebug.vsprops: Added.
1832         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebugAll.vsprops: Added.
1833         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebugCairoCFLite.vsprops: Added.
1834         * WebKitTestRunner/win/WebKitTestRunnerLauncherProduction.vsprops: Added.
1835         * WebKitTestRunner/win/WebKitTestRunnerLauncherRelease.vsprops: Added.
1836         * WebKitTestRunner/win/WebKitTestRunnerLauncherReleaseCairoCFLite.vsprops: Added.
1837
1838         * WebKitTestRunner/win/main.cpp:
1839         (dllLauncherEntryPoint): Renamed from main. This is what the stub launcher calls.
1840
1841 2012-01-05  Adam Roben  <aroben@apple.com>
1842
1843         Turn DumpRenderTree into a stub .exe launcher and a .dll that contains all the real code
1844
1845         This allows us to add the Safari and Apple Application Support directories to PATH before
1846         trying to load WebKit so that SafariTheme.dll, CoreGraphics.dll and friends can be found.
1847
1848         Part of <http://webkit.org/b/75486> <rdar://problem/10638124> NRWT fails to launch Apple's
1849         Windows port of DumpRenderTree/WebKitTestRunner
1850
1851         Reviewed by Steve Falkenburg.
1852
1853         * DumpRenderTree/DumpRenderTree.sln: Added DumpRenderTreeLauncher and ImageDiffLauncher,
1854         which I forgot to add to this .sln when that project was created.
1855
1856         * DumpRenderTree/win/DumpRenderTree.cpp:
1857         (dllLauncherEntryPoint): Renamed from main. This is what the stub launcher calls.
1858
1859         * DumpRenderTree/win/DumpRenderTree.vcproj:
1860         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
1861         Changed to build DumpRenderTree.dll instead of DumpRenderTree.exe.
1862
1863         * DumpRenderTree/win/DumpRenderTreeLauncher.vcproj: Added.
1864         * DumpRenderTree/win/DumpRenderTreeLauncherCommon.vsprops: Added.
1865         * DumpRenderTree/win/DumpRenderTreeLauncherDebug.vsprops: Added.
1866         * DumpRenderTree/win/DumpRenderTreeLauncherDebugAll.vsprops: Added.
1867         * DumpRenderTree/win/DumpRenderTreeLauncherDebugCairoCFLite.vsprops: Added.
1868         * DumpRenderTree/win/DumpRenderTreeLauncherProduction.vsprops: Added.
1869         * DumpRenderTree/win/DumpRenderTreeLauncherRelease.vsprops: Added.
1870         * DumpRenderTree/win/DumpRenderTreeLauncherReleaseCairoCFLite.vsprops: Added.
1871
1872         * win/DLLLauncher/DLLLauncherMain.cpp:
1873         (modifyPath): Moved code to modify PATH here from main/wWinMain. Changed to also prepend
1874         Safari's directory to PATH so that SafariTheme.dll can be found.
1875
1876         (main):
1877         (wWinMain):
1878         Changed to use the new modifyPath function.
1879
1880 2012-01-05  Alexander Færøy  <alexander.faeroy@nokia.com>
1881
1882         [Qt] Never enable FontConfig on Mac OS X
1883         https://bugs.webkit.org/show_bug.cgi?id=75616
1884
1885         Reviewed by Tor Arne Vestbø.
1886
1887         * qmake/mkspecs/features/features.prf:
1888
1889 2012-01-05  Alpha Lam  <hclam@chromium.org>
1890
1891         Unreviewed, rolling out r104159.
1892         http://trac.webkit.org/changeset/104159
1893         https://bugs.webkit.org/show_bug.cgi?id=75590
1894
1895         Chromium port GPU tests cannot be executed.
1896
1897         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1898         (get):
1899         (_default_tests_paths):
1900         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1901         (ChromiumGpuTest.assert_port_works):
1902         * Scripts/webkitpy/layout_tests/port/factory.py:
1903         (PortFactory._port_name_from_arguments_and_options):
1904         (PortFactory):
1905         (PortFactory._get_kwargs):
1906         (PortFactory.get):
1907         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1908         (FactoryTest.test_google_chrome.names):
1909         (FactoryTest.test_google_chrome):
1910         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
1911         (GetGoogleChromePort):
1912         (GetGoogleChromePort.GoogleChromeLinux32Port):
1913         (GetGoogleChromePort.GoogleChromeLinux32Port.baseline_search_path):
1914         (GetGoogleChromePort.GoogleChromeLinux32Port.test_expectations_overrides):
1915         (GetGoogleChromePort.GoogleChromeLinux32Port.architecture):
1916         (GetGoogleChromePort.GoogleChromeLinux64Port):
1917         (GetGoogleChromePort.GoogleChromeLinux64Port.baseline_search_path):
1918         (GetGoogleChromePort.GoogleChromeLinux64Port.test_expectations_overrides):
1919         (GetGoogleChromePort.GoogleChromeLinux64Port.architecture):
1920         (GetGoogleChromePort.GoogleChromeMacPort):
1921         (GetGoogleChromePort.GoogleChromeMacPort.baseline_search_path):
1922         (GetGoogleChromePort.GoogleChromeMacPort.test_expectations_overrides):
1923         (GetGoogleChromePort.GoogleChromeWinPort):
1924         (GetGoogleChromePort.GoogleChromeWinPort.baseline_search_path):
1925         (GetGoogleChromePort.GoogleChromeWinPort.test_expectations_overrides):
1926         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1927         (GetGoogleChromePortTest._verify_baseline_path):
1928         (GetGoogleChromePortTest._verify_expectations_overrides):
1929
1930 2012-01-05  Dirk Pranke  <dpranke@chromium.org>
1931
1932         webkitpy: clean up port factory methods
1933         https://bugs.webkit.org/show_bug.cgi?id=75590
1934
1935         Reviewed by Eric Seidel.
1936
1937         This change consolidates much of the "factory method" logic
1938         of determining which port objects to create for a given set
1939         of configurations by merging the separate factory methods in
1940         chromium_gpu and google_chrome into PortFactory so that at least
1941         all of the logic is in one place.
1942
1943         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1944         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1945         * Scripts/webkitpy/layout_tests/port/factory.py:
1946         (_port_name_from_arguments_and_options):
1947         (get):
1948         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1949         (test_google_chrome):
1950         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
1951         (GoogleChromeLinux32Port):
1952         (GoogleChromeLinux32Port.baseline_search_path):
1953         (test_expectations_overrides):
1954         (architecture):
1955         (GoogleChromeLinux64Port):
1956         (GoogleChromeLinux64Port.baseline_search_path):
1957         (GoogleChromeMacPort):
1958         (GoogleChromeMacPort.baseline_search_path):
1959         (GoogleChromeWinPort):
1960         (GoogleChromeWinPort.baseline_search_path):
1961         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1962         (_verify_baseline_path):
1963
1964 2012-01-04  Adam Roben  <aroben@apple.com>
1965
1966         Turn ImageDiff into a stub .exe launcher and a .dll that contains all the real code
1967
1968         This allows us to add the Apple Application Support directory to PATH before trying to load
1969         WebKit so that CoreGraphics.dll and friends can be found.
1970
1971         Fixes <http://webkit.org/b/75572> ImageDiff.exe can't be run without first munging PATH
1972
1973         Reviewed by Anders Carlsson.
1974
1975         * DumpRenderTree/win/ImageDiff.vcproj:
1976         * DumpRenderTree/win/ImageDiffCommon.vsprops:
1977         Changed to build ImageDiff.dll instead of ImageDiff.exe.
1978
1979         * DumpRenderTree/win/ImageDiffLauncher.vcproj: Copied from
1980         Tools/DumpRenderTree/win/ImageDiff.vcproj but changed to build the stub launcher.
1981
1982         * DumpRenderTree/win/ImageDiffLauncherCommon.vsprops: Added.
1983         * DumpRenderTree/win/ImageDiffLauncherDebug.vsprops: Added.
1984         * DumpRenderTree/win/ImageDiffLauncherDebugAll.vsprops: Added.
1985         * DumpRenderTree/win/ImageDiffLauncherDebugCairoCFLite.vsprops: Added.
1986         * DumpRenderTree/win/ImageDiffLauncherProduction.vsprops: Added.
1987         * DumpRenderTree/win/ImageDiffLauncherRelease.vsprops: Added.
1988         * DumpRenderTree/win/ImageDiffLauncherReleaseCairoCFLite.vsprops: Added.
1989
1990         * DumpRenderTree/win/ImageDiffWin.cpp: Added.
1991         (dllLauncherEntryPoint): This function is called by the stub launcher and just calls through
1992         to main.
1993
1994         * win/DLLLauncher/DLLLauncherMain.cpp:
1995         (main):
1996         (wWinMain):
1997         Added support for launching console programs. When USE_CONSOLE_ENTRY_POINT is defined, the
1998         stub launcher acts as a console program and calls a console version of
1999         dllLauncherEntryPoint.
2000
2001 2012-01-04  Adam Roben  <aroben@apple.com>
2002
2003         Turn MiniBrowser into a stub .exe launcher and a .dll that contains all the real code
2004
2005         This allows us to add the Apple Application Support directory to PATH before trying to load
2006         WebKit so that CoreGraphics.dll and friends can be found.
2007
2008         Fixes <http://webkit.org/b/68576> <rdar://problem/10163853> MiniBrowser fails to launch when
2009         double-clicked
2010
2011         Reviewed by Anders Carlsson.
2012
2013         * MiniBrowser/MiniBrowser.vcproj:
2014         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
2015         Changed to build MiniBrowser.dll instead of MiniBrowser.exe.
2016
2017         * MiniBrowser/Configurations/MiniBrowserLauncherCommon.vsprops: Added.
2018         * MiniBrowser/Configurations/MiniBrowserLauncherDebug.vsprops: Added.
2019         * MiniBrowser/Configurations/MiniBrowserLauncherDebugAll.vsprops: Added.
2020         * MiniBrowser/Configurations/MiniBrowserLauncherDebugCairoCFLite.vsprops: Added.
2021         * MiniBrowser/Configurations/MiniBrowserLauncherProduction.vsprops: Added.
2022         * MiniBrowser/Configurations/MiniBrowserLauncherRelease.vsprops: Added.
2023         * MiniBrowser/Configurations/MiniBrowserLauncherReleaseCairoCFLite.vsprops: Added.
2024
2025         * MiniBrowser/MiniBrowserLauncher.vcproj: Copied from Tools/MiniBrowser/MiniBrowser.vcproj
2026         but changed to build the stub launcher.
2027
2028         * MiniBrowser/win/main.cpp: Moved the /manifestdependency code to DLLLauncherMain.cpp, since
2029         it needs to be compiled into the .exe instead of the .dll.
2030         (DllMain): Added. We use this to store the DLL's HINSTANCE.
2031         (dllLauncherEntryPoint): Renamed from _tWinMain. This is what gets called by the
2032         DLLLauncherMain code.
2033
2034         * win/DLLLauncher/DLLLauncherMain.cpp: Moved the /manifestdependency code from MiniBrowser
2035         to here.
2036
2037 2012-01-04  Adam Roben  <aroben@apple.com>
2038
2039         Make WinLauncher's window frame respond to clicks/drags again
2040
2041         Fixes <http://webkit.org/b/75562> REGRESSION (r84990): Can't drag WinLauncher by its title
2042         bar when Aero is disabled
2043
2044         Reviewed by Brent Fulgham.
2045
2046         * WinLauncher/WinLauncher.cpp:
2047         (WndProc): Always call up to our parent wndproc when we don't handle WM_NCHITTEST ourselves.
2048         Also removed an unnecessary "break" keyword.
2049
2050 2012-01-04  Adam Roben  <aroben@apple.com>
2051
2052         Turn WinLauncher into a stub .exe launcher and a .dll that contains all the real code
2053
2054         This allows us to add the Apple Application Support directory to PATH before trying to load
2055         WebKit so that CoreGraphics.dll and friends can be found. Eventually all our WebKit apps
2056         should use this mechanism.
2057
2058         Fixes <http://webkit.org/b/68578> <rdar://problem/10163861> WinLauncher fails to launch when
2059         double-clicked
2060
2061         Reviewed by Anders Carlsson.
2062
2063         * WinLauncher/WinLauncher.cpp: Removed InitInstance.
2064         (DllMain): Added. Stores the DLL HINSTANCE in the global hInst variable. This used to be
2065         done by the now-removed InitInstance function.
2066         (dllLauncherEntryPoint): Renamed from _tWinMain. This is the function that our stub launcher
2067         calls. Merged code from InitInstance into this function, and change to use the global hInst
2068         variable, which corresponds to WinLauncher.dll, rather than the HINSTANCE passed into this
2069         function, which corresponds to WinLauncher.exe.
2070
2071         * WinLauncher/WinLauncher.vcproj:
2072         * WinLauncher/WinLauncherCommon.vsprops:
2073         Changed to build WinLauncher.dll instead of WinLauncher.exe.
2074
2075         * WinLauncher/WinLauncherLauncher.rc: Added.
2076         * WinLauncher/WinLauncherLauncherResource.h: Added.
2077         This just references the WinLauncher.ico file to set the application icon (though it looks
2078         like that's a default icon).
2079
2080         * WinLauncher/WinLauncherLauncher.vcproj: Copied from Tools/WinLauncher/WinLauncher.vcproj
2081         but changed to build WinLauncher.exe using the new DLLLauncherMain.cpp file.
2082
2083         * WinLauncher/WinLauncherLauncherCommon.vsprops: Added.
2084         * WinLauncher/WinLauncherLauncherDebug.vsprops: Added.
2085         * WinLauncher/WinLauncherLauncherDebugAll.vsprops: Added.
2086         * WinLauncher/WinLauncherLauncherDebugCairoCFLite.vsprops: Added.
2087         * WinLauncher/WinLauncherLauncherProduction.vsprops: Added.
2088         * WinLauncher/WinLauncherLauncherRelease.vsprops: Added.
2089         * WinLauncher/WinLauncherLauncherReleaseCairoCFLite.vsprops: Added.
2090
2091         * win/DLLLauncher/DLLLauncherMain.cpp: Added.
2092         (enableTerminationOnHeapCorruption): Uses HeapSetInformation to tell Windows to kill the
2093         program if it detects heap corruption.
2094         (getStringValue): Helper function to read a string value from the registry.
2095         (applePathFromRegistry): Helper function to read the InstallDir for a given Apple
2096         application from the registry.
2097         (appleApplicationSupportDirectory): Helper function to return the path to the Apple
2098         Application Support directory.
2099         (copyEnvironmentVariable): Helper function to copy an environment variable's value.
2100         (prependPath): Helper function to prepend a directory to the PATH.
2101         (fatalError): Helper function to display an error to the user.
2102         (wWinMain): Add Apple Application Support to the PATH, then load our DLL and call its
2103         dllLauncherEntryPoint function.
2104
2105 2012-01-05  Kentaro Hara  <haraken@chromium.org>
2106
2107         prepare-ChangeLog cannot parse python code that nests classes and defs
2108         https://bugs.webkit.org/show_bug.cgi?id=75524
2109
2110         Reviewed by Ryosuke Niwa.
2111
2112         This patch fixes the python parser of prepare-ChangeLog so that it can parse
2113         python code that nests classes and defs, like this:
2114
2115         class C:
2116             pass
2117             def f():
2118                 pass
2119             pass
2120
2121         Also, this patch fixes the python parser so that it inserts a dummy line
2122         at the end of the file to pop out all popped scopes.
2123
2124         * Scripts/prepare-ChangeLog:
2125         (get_function_line_ranges_for_python):
2126
2127         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests.py:
2128         Added test cases that nest classes and defs.
2129         (func7):
2130         (func7.func8):
2131         (func7.func8.func9):
2132         (Class2):
2133         (Class2.Class3):
2134         (Class2.Class3.Class4):
2135         (Class5):
2136         (Class5.func10):
2137         (Class5.func11):
2138         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests-expected.txt:
2139
2140 2012-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
2141
2142         [GTK] Rename webkit_web_view_load_alternate_html as webkit_web_view_replace_content in WebKit2 GTK+
2143         https://bugs.webkit.org/show_bug.cgi?id=75433
2144
2145         Reviewed by Martin Robinson.
2146
2147         * MiniBrowser/gtk/BrowserWindow.c:
2148         (webViewLoadFailed): Reset the progress bar when load fails.
2149         (browserWindowConstructed): Connect to load-failed signal.
2150
2151 2012-01-04  Dan Bernstein  <mitz@apple.com>
2152
2153         Add a --target-web-process option to the debug-* scripts. When specified, the scripts will
2154         start WebProcess under gdb and WebProcess will then run the client executable.
2155
2156         This is the Tools part of fixing <http://webkit.org/b/75444> Debugging WebProcess requires running a UI process first and waiting to attach
2157
2158         Reviewed by Anders Carlsson.
2159
2160         * Scripts/webkitdirs.pm:
2161         (shouldTargetWebProcess): Added.
2162         (determineShouldTargetWebProcess): Added. Checks for --target-web-process.
2163         (execMacWebKitAppForDebugging): Changed to target gdb at WebProcess and pass the path to the
2164         app using the -client-executable option if targeting the web process.
2165
2166 2012-01-04  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
2167
2168         Adding myself to committers list.
2169
2170         Unreviewed.
2171
2172         * Scripts/webkitpy/common/config/committers.py:
2173
2174 2012-01-04  David Kilzer  <ddkilzer@apple.com>
2175
2176         Revert fix for Bug 75064: TestWebKitAPI: initialize the main thread before running tests
2177
2178         This reverts commit r103546.
2179
2180         * TestWebKitAPI/TestsController.cpp:
2181         (TestWebKitAPI::TestsController::TestsController):
2182
2183 2012-01-04  James Robinson  <jamesr@chromium.org>
2184
2185         [chromium] Move WebMimeRegistry and dependencies to Source/Platform
2186         https://bugs.webkit.org/show_bug.cgi?id=74583
2187
2188         Reviewed by Darin Fisher.
2189
2190         Teaches the WEBKIT_EXPORT check about the chromium WebKit platform API header location.
2191
2192         * Scripts/webkitpy/style/checkers/cpp.py:
2193         (check_function_definition):
2194
2195 2012-01-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2196
2197         [Qt] Fix link order of static libraries and unbreak QtWin32
2198
2199         We were keeping the correct static link order between the intermediate
2200         WebKit libraries, but not the internal dependencies for each of those
2201         libraries. The load() will in some instances mess with LIBS, so we need
2202         to ensure that the dependent libraries are added after the library we
2203         are linking against.
2204
2205         Reviewed by Simon Hausmann.
2206
2207         * qmake/mkspecs/features/default_post.prf:
2208
2209 2012-01-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2210
2211         [Qt] Introduce new qmake variable 'WEBKIT' for signaling dependencies
2212
2213         The custom qmake variable 'WEBKIT' is used for signaling that a
2214         target depends in some way on other subproject of the WebKit
2215         project. For now this is limited to the set of intermediate
2216         libraries: wtf, javascriptcore, webcore, and webkit2.
2217
2218         This replaces the previous convension of using load(foo) for
2219         just include paths, and CONFIG += foo to also link against foo.
2220
2221         Adding a dependency results in additional include paths being
2222         available, and potentially linking to the library. This is
2223         decided by the build system based on conditions such as what
2224         kind of target is being built and the general build config.
2225
2226         An advantage to his approach is that it simplifies the individual
2227         foo.prf files, for example by allowing us to use INCLUDEPATH +=
2228         and LIBS += as normal instead of prepending.
2229
2230         Reviewed by Simon Hausmann.
2231
2232         * DumpRenderTree/qt/DumpRenderTree.pro:
2233         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2234         * QtTestBrowser/QtTestBrowser.pro:
2235         * WebKitTestRunner/InjectedBundle/Target.pri:
2236         * WebKitTestRunner/Target.pri:
2237         * qmake/README:
2238         * qmake/mkspecs/features/default_post.prf:
2239         * qmake/mkspecs/features/functions.prf:
2240         * qmake/mkspecs/features/javascriptcore.prf:
2241         * qmake/mkspecs/features/qtwebkit.prf:
2242         * qmake/mkspecs/features/webcore.prf:
2243         * qmake/mkspecs/features/webkit2.prf:
2244         * qmake/mkspecs/features/wtf.prf:
2245
2246 2012-01-04  Alexander Færøy  <ahf@0x90.dk>
2247
2248         [Qt] Add UI for JavaScript Prompt dialog in the Qt MiniBrowser
2249         https://bugs.webkit.org/show_bug.cgi?id=75488
2250
2251         Reviewed by Tor Arne Vestbø.
2252
2253         * MiniBrowser/qt/MiniBrowser.qrc:
2254         * MiniBrowser/qt/qml/BrowserWindow.qml:
2255         * MiniBrowser/qt/qml/Dialog.qml:
2256         * MiniBrowser/qt/qml/DialogLineInput.qml: Copied from Tools/MiniBrowser/qt/qml/Dialog.qml.
2257         * MiniBrowser/qt/qml/PromptDialog.qml: Copied from Tools/MiniBrowser/qt/qml/Dialog.qml.
2258
2259 2012-01-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2260
2261         [Qt] Use rpath for WTR's InjectedBundle to pick up the right QtWebKit
2262
2263         It wasn't really a problem at runtime since the right QtWebKit was
2264         already loaded as a dependency of the web process, but the ldd output
2265         would still be busted.
2266
2267         Reviewed by Simon Hausmann.
2268
2269         * WebKitTestRunner/InjectedBundle/Target.pri:
2270
2271 2012-01-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2272
2273         [Qt] Move use of $$qtLibraryTarget() to a single place
2274
2275         Reviewed by Kenneth Rohde Christiansen.
2276
2277         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2278         * WebKitTestRunner/InjectedBundle/Target.pri:
2279         * qmake/mkspecs/features/default_post.prf:
2280         * qmake/mkspecs/features/webcore.prf:
2281
2282 2012-01-04  Mary Wu  <mary.wu@torchmobile.com.cn>
2283
2284         Enable DOWNLOAD_ATTRIBUTE in BlackBerry porting
2285         https://bugs.webkit.org/show_bug.cgi?id=75238
2286
2287         Reviewed by Antonio Gomes.
2288
2289         Add ENABLE_DOWNLOAD_ATTRIBUTE webkit feature into the build script so that 
2290         it could initiate download directly if it has the download attribute in the link 
2291         and doesn't need to open new blank page for the target="_blank". Enabling this 
2292         feature in the BlackBerry porting also prepares for later blob feature implementation.
2293
2294         * Scripts/build-webkit: Modified to handle ENABLE_DOWNLOAD_ATTRIBUTE. Make it default on
2295         for the BlackBerry porting.
2296
2297 2012-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2298
2299         [GTK] Fix a runtime warning when hovering hyperlink auditing setting in MiniBroweser settings dialog
2300         https://bugs.webkit.org/show_bug.cgi?id=75475
2301
2302         Reviewed by Martin Robinson.
2303
2304         The problem is that the property blurb contains <a ping> and tree
2305         view uses gtk_tooltip_set_markup() internally, so we need to
2306         escape the text.
2307
2308         * MiniBrowser/gtk/BrowserSettingsDialog.c:
2309         (browserSettingsDialogConstructed): Escape property blurb before
2310         storing it in the GtkTreeModel.
2311
2312 2012-01-03  Jochen Eisinger  <jochen@chromium.org>
2313
2314         When showing results.html pass a correct URL to webbrowser.open
2315         https://bugs.webkit.org/show_bug.cgi?id=75438
2316
2317         Reviewed by Adam Barth.
2318
2319         * Scripts/webkitpy/common/system/filesystem.py:
2320         (file_path_as_url):
2321         * Scripts/webkitpy/common/system/filesystem_mock.py:
2322         (file_path_as_url):
2323         * Scripts/webkitpy/common/system/filesystem_unittest.py:
2324         (test_file_path_as_url):
2325         * Scripts/webkitpy/layout_tests/port/base.py:
2326         (show_results_html_file):
2327         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
2328         (test_show_results_html_file):
2329         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2330         (test_results_directory_relative):
2331
2332 2012-01-03  Ojan Vafai  <ojan@chromium.org>
2333
2334         shrink the header on the flakiness dashboard
2335         https://bugs.webkit.org/show_bug.cgi?id=65153
2336
2337         Reviewed by Adam Roben.
2338
2339         Move some of the "show" links to be to the right of the header
2340         instead of below the header when they content they're showing
2341         is hidden. That way we don't waste vertical space on them.
2342
2343         No new tests. This code is covered by existing tests.
2344
2345         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2346
2347 2012-01-03  Ryosuke Niwa  <rniwa@webkit.org>
2348
2349         Add a tool to analyze change logs
2350         https://bugs.webkit.org/show_bug.cgi?id=72243
2351
2352         Reviewed by Eric Seidel.
2353
2354         Add the initial implementation of analyze-changelog command. This version supports parsing multiple changelogs
2355         in a single directory and summarizes the result in json files. It also copies summary.html to the output directory
2356         for visualizing json files.
2357
2358         Usage: webkit-patch analyze-changelog [--changelog-count N] <CHANGELOG_DIR> <OUTPUT_DIR>
2359         where CHANGELOG_DIR is the directory to look for changelogs, OUTPUT_DIR is the directory into which the tool
2360         generates json files, and N is the number of changelogs to parse.
2361
2362         * Scripts/webkitpy/common/config/contributionareas.py: Added names().
2363         * Scripts/webkitpy/common/system/filesystem_mock.py: Added readline and iterator support to ReadableTextFileObject.
2364         * Scripts/webkitpy/tool/commands/__init__.py:
2365         * Scripts/webkitpy/tool/commands/analyzechangelog.py: Added.
2366         * Scripts/webkitpy/tool/commands/analyzechangelog_unittest.py: Added.
2367         * Scripts/webkitpy/tool/commands/data/summary.html: Added.
2368         * Scripts/webkitpy/tool/steps/options.py:
2369
2370 2012-01-03  Ryosuke Niwa  <rniwa@webkit.org>
2371
2372         Add a tool to analyze change logs
2373         https://bugs.webkit.org/show_bug.cgi?id=72243
2374
2375         Reviewed by Eric Seidel.
2376
2377         Add the initial implementation of analyze-changelog command. This version supports parsing multiple changelogs
2378         in a single directory and summarizes the result in json files. It also copies summary.html to the output directory
2379         for visualizing json files.
2380
2381         Usage: webkit-patch analyze-changelog [--changelog-count N] <CHANGELOG_DIR> <OUTPUT_DIR>
2382         where CHANGELOG_DIR is the directory to look for changelogs, OUTPUT_DIR is the directory into which the tool
2383         generates json files, and N is the number of changelogs to parse.
2384
2385         * Scripts/webkitpy/common/config/contributionareas.py: Added names().
2386         * Scripts/webkitpy/common/system/filesystem_mock.py: Added readline and iterator support to ReadableTextFileObject.
2387         * Scripts/webkitpy/tool/commands/__init__.py:
2388         * Scripts/webkitpy/tool/commands/analyzechangelog.py: Added.
2389         * Scripts/webkitpy/tool/commands/analyzechangelog_unittest.py: Added.
2390         * Scripts/webkitpy/tool/commands/data/summary.html: Added.
2391         * Scripts/webkitpy/tool/steps/options.py:
2392
2393 2012-01-03  Adam Roben  <aroben@apple.com>
2394
2395         Make Port subclasses override the operating_system method rather than setting an attribute
2396
2397         Without this patch, any use of Port.operating_system() within a port's __init__ method would
2398         return the default value ("mac"). This was confusing the version-checking logic inside
2399         ApplePort.__init__ on Windows.
2400
2401         Fixes <http://webkit.org/b/75479> <rdar://problem/10637385> REGRESSION (r102161): NRWT
2402         crashes on launch on Windows 7 SP1
2403
2404         Reviewed by Eric Seidel.
2405
2406         * Scripts/webkitpy/layout_tests/port/apple.py:
2407         (ApplePort.__init__): Replaced uses of self._operating_system with self.operating_system().
2408
2409         * Scripts/webkitpy/layout_tests/port/base.py:
2410         (Port.__init__): Removed code that set the self._operating_system attribute. Subclasses
2411         should now override the operating_system method instead.
2412         (Port.operating_system): Changed to always return "mac". Subclasses should override to
2413         return something else.
2414
2415         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2416         (ChromiumLinuxPort.__init__):
2417         (ChromiumLinuxPort.operating_system):
2418         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2419         (ChromiumMacPort.__init__):
2420         (ChromiumMacPort.operating_system):
2421         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2422         (ChromiumWinPort.__init__):
2423         (ChromiumWinPort.operating_system):
2424         * Scripts/webkitpy/layout_tests/port/mac.py:
2425         (MacPort.__init__):
2426         (MacPort.operating_system):
2427         * Scripts/webkitpy/layout_tests/port/win.py:
2428         (WinPort.__init__):
2429         (WinPort.operating_system):
2430         Changed to override the operating_system method rather than setting the _operating_system
2431         attribute, since setting the attribute isn't sufficient for code inside __init__ methods.
2432
2433         * Scripts/webkitpy/layout_tests/port/qt.py:
2434         (QtPort.__init__):
2435         (QtPort._path_to_webcore_library):
2436         Changed to use self.operating_system() instead of self._operating_system, for consistency
2437         with other Port-related code.
2438
2439         (QtPort.operating_system): Added this override of Port.operating_system that returns the
2440         value we determined in our __init__ method.
2441
2442         * Scripts/webkitpy/layout_tests/port/test.py:
2443         (TestPort.operating_system): Added this override of Port.operating_system that returns the
2444         value we determined in our __init__ method.
2445
2446         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2447         (PortTest.test_operating_system):
2448         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
2449         (ChromiumLinuxPortTest.test_operating_system):
2450         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2451         (ChromiumMacPortTest.test_operating_system):
2452         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2453         (ChromiumWinPortTest.test_operating_system):
2454         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2455         (MacPortTest.test_operating_system):
2456         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2457         (QtPortTest.test_operating_system):
2458         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
2459         (WinPortTest.test_operating_system):
2460         Test that all ports return the expected operating system string.
2461
2462 2012-01-03  Mario Sanchez Prada  <msanchez@igalia.com>
2463
2464         [GTK] run-gtk-test should ignore files with names without a "test" or "Test" prefix
2465         https://bugs.webkit.org/show_bug.cgi?id=75474
2466
2467         Reviewed by Philippe Normand.
2468
2469         * Scripts/run-gtk-tests: Ignore files whose name does not start
2470         with a "test" (for WK1's API tests) or a "Test" prefix (for WK2).
2471
2472 2012-01-03  Alexander Færøy  <alexander.faeroy@nokia.com>
2473
2474         [Qt] Add UI for JavaScript Confirmation dialog in the Qt MiniBrowser
2475         https://bugs.webkit.org/show_bug.cgi?id=75472
2476
2477         Reviewed by Tor Arne Vestbø.
2478
2479         * MiniBrowser/qt/MiniBrowser.pro:
2480         * MiniBrowser/qt/MiniBrowser.qrc:
2481         * MiniBrowser/qt/qml/BrowserWindow.qml:
2482         * MiniBrowser/qt/qml/ConfirmDialog.qml: Added.
2483
2484 2012-01-03  Alexander Færøy  <alexander.faeroy@nokia.com>
2485
2486         [Qt] Add UI for JavaScript Alert dialog in the Qt MiniBrowser
2487         https://bugs.webkit.org/show_bug.cgi?id=75471
2488
2489         Reviewed by Tor Arne Vestbø.
2490
2491         Add simple UI for JavaScript Alert dialogs. This patch also adds a
2492         simple DialogButton QML type and a Dialog QML type which will be
2493         reusable for other JavaScript dialogs.
2494
2495         * MiniBrowser/qt/MiniBrowser.qrc:
2496         * MiniBrowser/qt/qml/AlertDialog.qml: Added.
2497         * MiniBrowser/qt/qml/BrowserWindow.qml:
2498         * MiniBrowser/qt/qml/Dialog.qml: Added.
2499         * MiniBrowser/qt/qml/DialogButton.qml: Added.
2500
2501 2012-01-03  Rafael Brandao  <rafael.lobo@openbossa.org>
2502
2503         [Qt][WK2] MiniBrowser doesn't show url bar
2504         https://bugs.webkit.org/show_bug.cgi?id=75470
2505
2506         Reviewed by Tor Arne Vestbø.
2507
2508         * MiniBrowser/qt/qml/BrowserWindow.qml: Remove clipping until it is fixed
2509         on QtDeclarative (QTBUG-23422).
2510
2511 2012-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2512
2513         [GTK] Simplify loader client WebKit2 GTK+ API
2514         https://bugs.webkit.org/show_bug.cgi?id=74605
2515
2516         Reviewed by Gustavo Noronha Silva.
2517
2518         * gtk/generate-gtkdoc: Ignore WebKitWebLoaderClient since it's now
2519         private API.
2520
2521 2012-01-03  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2522
2523         [Qt] Clean up detection of fontconfig
2524
2525         We decide in features.prf whether or not fontconfig is available, and
2526         set the HAVE_FONTCONFIG define accordingly. All leaf project files
2527         should use this define to decide whether or not to link against
2528         fontconfig, not do their own detection.
2529
2530         We don't need to add link_pkgconfig to CONFIG in each project file,
2531         as we selectivly enable that configuration in defaults_post when
2532         needed.
2533
2534         Reviewed by Ossy.
2535
2536         * DumpRenderTree/qt/DumpRenderTree.pro:
2537         * QtTestBrowser/QtTestBrowser.pro:
2538         * WebKitTestRunner/InjectedBundle/Target.pri:
2539         * qmake/mkspecs/features/unix/default_post.prf:
2540         * qmake/mkspecs/features/unix/default_pre.prf:
2541
2542 2012-01-03  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2543
2544         [Qt] Introduce qmake replace function for the active build config
2545
2546         Reviewed by Ossy.
2547
2548         * qmake/mkspecs/features/default_post.prf:
2549         * qmake/mkspecs/features/functions.prf:
2550
2551 2012-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2552
2553         [GTK] Use gdk_screen_get_monitor_workarea() when available for screenAvailableRect()
2554         https://bugs.webkit.org/show_bug.cgi?id=75435
2555
2556         Reviewed by Martin Robinson.
2557
2558         * GNUmakefile.am: Make sure DRT links to X11.
2559         * WebKitTestRunner/GNUmakefile.am: Make sure WTR links to X11.
2560
2561 2011-12-04  Philippe Normand  <pnormand@igalia.com>
2562
2563         [WK2][GTK] WebSettings support in MiniBrowser
2564         https://bugs.webkit.org/show_bug.cgi?id=73773
2565
2566         Reviewed by Martin Robinson.
2567
2568         Patch heavily inspired from the WebKit GtkLauncher to support
2569         command-line WebSettings. Example: --enable-fullscreen=TRUE.
2570         The full list of options can be consulted with --help-websettings.
2571
2572         * MiniBrowser/gtk/main.c:
2573         (loadURI):
2574         (parseOptionEntryCallback):
2575         (isValidParameterType):
2576         (getOptionEntriesFromWebKitSettings):
2577         (addSettingsGroupToContext):
2578         (main):
2579
2580 2012-01-02  Philippe Normand  <pnormand@igalia.com>
2581
2582         [GTK] GtkLauncher settings improvements
2583         https://bugs.webkit.org/show_bug.cgi?id=75439
2584
2585         Reviewed by Martin Robinson.
2586
2587         * GtkLauncher/main.c:
2588         (filenameToURL): We can use NULL in C.
2589         (isValidParameterType): Utility function to filter GParamTypes
2590         that can be edited.
2591         (getOptionEntriesFromWebKitWebSettings): Avoid handling
2592         construct-only properties and use the isValidParameterType
2593         function. Makes the code a bit cleaner.
2594
2595 2012-01-02  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2596
2597         [EFL] Remove whitespace/declaration style exception
2598         https://bugs.webkit.org/show_bug.cgi?id=75424
2599
2600         Reviewed by David Levin.
2601
2602         Remove *whitespace/eclaration* style rule. However, EWebLauncher and MiniBrowser are EFL simple
2603         application. So, they still need to use EFL coding style.
2604
2605         * Scripts/webkitpy/style/checker.py:
2606
2607 2012-01-02  Carlos Garcia Campos  <cgarcia@igalia.com>
2608
2609         [GTK] Add a way to change web view settings in MiniBrowser
2610         https://bugs.webkit.org/show_bug.cgi?id=71568
2611
2612         Reviewed by Philippe Normand.
2613
2614         Add a preferences button to the toolbar that shows a dialog to
2615         change settings of the current web view. It uses a GtkTreeView
2616         with a custom cell renderer to support multiple types of values.
2617
2618         * MiniBrowser/gtk/BrowserCellRendererVariant.c: Added.
2619         (browserCellRendererVariantFinalize):
2620         (browserCellRendererVariantGetProperty):
2621         (browserCellRendererVariantSetModeForValue):
2622         (browserCellRendererVariantSetProperty):
2623         (browserCellRendererVariantGetRendererForValue):
2624         (browserCellRendererVariantCellRendererTextEdited):
2625         (browserCellRendererVariantCellRendererSpinEdited):
2626         (browserCellRendererVariantCellRendererActivate):
2627         (browserCellRendererVariantCellRendererRender):
2628         (browserCellRendererVariantCellRendererStartEditing):
2629         (browserCellRendererVariantCellRendererGetPreferredWidth):
2630         (browserCellRendererVariantCellRendererGetPreferredHeight):
2631         (browserCellRendererVariantCellRendererGetPreferredWidthForHeight):
2632         (browserCellRendererVariantCellRendererGetPreferredHeightForWidth):
2633         (browserCellRendererVariantCellRendererGetAlignedArea):
2634         (browser_cell_renderer_variant_init):
2635         (browser_cell_renderer_variant_class_init):
2636         (browser_cell_renderer_variant_new):
2637         * MiniBrowser/gtk/BrowserCellRendererVariant.h: Added.
2638         * MiniBrowser/gtk/BrowserSettingsDialog.c: Added.
2639         (cellRendererChanged):
2640         (browserSettingsDialogSetProperty):
2641         (browser_settings_dialog_init):
2642         (browserSettingsDialogConstructed):
2643         (browser_settings_dialog_class_init):
2644         (browser_settings_dialog_new):
2645         * MiniBrowser/gtk/BrowserSettingsDialog.h: Added.
2646         * MiniBrowser/gtk/BrowserWindow.c:
2647         (settingsCallback):
2648         (browser_window_init):
2649         * MiniBrowser/gtk/GNUmakefile.am:
2650         * MiniBrowser/gtk/browser-marshal.list: Added.
2651
2652 2012-01-02  Carlos Garcia Campos  <cgarcia@igalia.com>
2653
2654         [GTK] Implement create/ready-to-show/close signals in MiniBrowser
2655         https://bugs.webkit.org/show_bug.cgi?id=74711
2656
2657         Reviewed by Philippe Normand.
2658
2659         * MiniBrowser/gtk/BrowserWindow.c:
2660         (webViewClose): Destroy the window.
2661         (webViewReadyToShow): Use WindowProperties of the new view to
2662         setup and show the window.
2663         (webViewCreate): Create a new view and add it to a browser window.
2664         (browser_window_init):
2665         (browserWindowConstructed): Connect to WebKitWebView::create signal.
2666
2667 2011-12-31  Dan Bernstein  <mitz@apple.com>
2668
2669         MiniBrowser sets the WKView’s frame incorrectly
2670         https://bugs.webkit.org/show_bug.cgi?id=75393
2671
2672         Reviewed by Anders Carlsson.
2673
2674         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Removed Make Launchable build phase,
2675         which is not needed since the binray is linked with the frameworks search path set to the
2676         built products directory.
2677         * MiniBrowser/mac/BrowserWindowController.m:
2678         (-[BrowserWindowController awakeFromNib]): Changed to set the WKView’s frame to its
2679         container’s bounds rather than its frame.
2680         * MiniBrowser/mac/make-launchable.sh: Removed.
2681
2682 2011-12-29  Dan Bernstein  <mitz@apple.com>
2683
2684         debug-safari --no-saved-state fails to start the debugger
2685         https://bugs.webkit.org/show_bug.cgi?id=75374
2686
2687         Reviewed by Sam Weinig.
2688
2689         * Scripts/webkitdirs.pm:
2690         (execMacWebKitAppForDebugging): Pass the --args option to gdb so that it passes arguments to
2691         the executable being debugged.
2692
2693 2011-12-29  Sam Weinig  <sam@webkit.org>
2694
2695         It should be easier to iterate a Vector backwards
2696         https://bugs.webkit.org/show_bug.cgi?id=75359
2697
2698         Reviewed by Anders Carlsson.
2699
2700         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2701         * TestWebKitAPI/TestWebKitAPI.gypi:
2702         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2703         Add new Vector test.
2704
2705         * TestWebKitAPI/Tests/Vector.cpp: Added.
2706         (TestWebKitAPI::TEST):
2707         Test Vector iterators, reverse_iterators and new reversed proxy.
2708
2709 2011-12-28  Dmitry Lomov  <dslomov@google.com>
2710
2711         [WebWorkers][Chromium] Remove remains of cross-process dedicated worker implementation.
2712         https://bugs.webkit.org/show_bug.cgi?id=66509
2713         Just renames, merges and removal of dead code. Here are the list of renames:
2714           - WebCommonWorkerClient merged with WebWorkerClient and renamed to WebSharedWorkerClient
2715           - NewWebCommonWorkerClient renamed to WebCommonWorkerClient
2716           - WebWorkerBase merged into WebSharedWorkerImpl
2717           - NewWebWorkerBase renamed into WebWorkerBase
2718  
2719         Reviewed by David Levin.
2720
2721         * DumpRenderTree/chromium/TestWebWorker.h:
2722         (TestWebWorker::createWorker):
2723         * DumpRenderTree/chromium/WebViewHost.cpp:
2724         (WebViewHost::createWorker):
2725         * DumpRenderTree/chromium/WebViewHost.h:
2726
2727 2011-12-28  Sheriff Bot  <webkit.review.bot@gmail.com>
2728
2729         Unreviewed, rolling out r103785.
2730         http://trac.webkit.org/changeset/103785
2731         https://bugs.webkit.org/show_bug.cgi?id=75332
2732
2733         Broke builders; looks like clobbering didnt help (Requested by
2734         dslomov on #webkit).
2735
2736         * DumpRenderTree/chromium/TestWebWorker.h:
2737         (TestWebWorker::createWorker):
2738         * DumpRenderTree/chromium/WebViewHost.cpp:
2739         (WebViewHost::createWorker):
2740         * DumpRenderTree/chromium/WebViewHost.h:
2741
2742 2011-12-28  Dmitry Lomov  <dslomov@google.com>
2743
2744
2745         [WebWorkers][Chromium] Remove remains of cross-process dedicated worker implementation.
2746         https://bugs.webkit.org/show_bug.cgi?id=66509
2747         Just renames, merges and removal of dead code. Here are the list of renames:
2748           - WebCommonWorkerClient merged with WebWorkerClient and renamed to WebSharedWorkerClient
2749           - NewWebCommonWorkerClient renamed to WebCommonWorkerClient
2750           - WebWorkerBase merged into WebSharedWorkerImpl
2751           - NewWebWorkerBase renamed into WebWorkerBase
2752  
2753         Reviewed by David Levin.
2754
2755         * DumpRenderTree/chromium/TestWebWorker.h:
2756         (TestWebWorker::createWorker):
2757         * DumpRenderTree/chromium/WebViewHost.cpp:
2758         (WebViewHost::createWorker):
2759         * DumpRenderTree/chromium/WebViewHost.h:
2760
2761 2011-12-28  Sheriff Bot  <webkit.review.bot@gmail.com>
2762
2763         Unreviewed, rolling out r103620.
2764         http://trac.webkit.org/changeset/103620
2765         https://bugs.webkit.org/show_bug.cgi?id=75316
2766
2767         Causes many crashes (Requested by abarth on #webkit).
2768
2769         * DumpRenderTree/chromium/LayoutTestController.cpp:
2770         (LayoutTestController::LayoutTestController):
2771         (LayoutTestController::reset):
2772         * DumpRenderTree/chromium/LayoutTestController.h:
2773         * DumpRenderTree/chromium/WebViewHost.cpp:
2774         * DumpRenderTree/chromium/WebViewHost.h:
2775
2776 2011-12-27  Sheriff Bot  <webkit.review.bot@gmail.com>
2777
2778         Unreviewed, rolling out r103734.
2779         http://trac.webkit.org/changeset/103734
2780         https://bugs.webkit.org/show_bug.cgi?id=75278
2781
2782         Broke cr-mac (Requested by dslomov on #webkit).
2783
2784         * DumpRenderTree/chromium/TestWebWorker.h:
2785         (TestWebWorker::createWorker):
2786         * DumpRenderTree/chromium/WebViewHost.cpp:
2787         (WebViewHost::createWorker):
2788         * DumpRenderTree/chromium/WebViewHost.h:
2789
2790 2011-12-27  Dmitry Lomov  <dslomov@google.com>
2791
2792
2793         [WebWorkers][Chromium] Remove remains of cross-process dedicated worker implementation.
2794         https://bugs.webkit.org/show_bug.cgi?id=66509
2795         Just renames, merges and removal of dead code. Here are the list of renames:
2796           - WebCommonWorkerClient merged with WebWorkerClient and renamed to WebSharedWorkerClient
2797           - NewWebCommonWorkerClient renamed to WebCommonWorkerClient
2798           - WebWorkerBase merged into WebSharedWorkerImpl
2799           - NewWebWorkerBase renamed into WebWorkerBase
2800  
2801         Reviewed by David Levin.
2802
2803         * DumpRenderTree/chromium/TestWebWorker.h:
2804         (TestWebWorker::createWorker):
2805         * DumpRenderTree/chromium/WebViewHost.cpp:
2806         (WebViewHost::createWorker):
2807         * DumpRenderTree/chromium/WebViewHost.h:
2808
2809 2011-12-27  Anders Carlsson  <andersca@apple.com>
2810
2811         Function should handle wrapping/unwrapping RefPtr and PassRefPtr
2812         https://bugs.webkit.org/show_bug.cgi?id=75266
2813
2814         Reviewed by Sam Weinig.
2815
2816         * TestWebKitAPI/Tests/WTF/Functional.cpp:
2817         (TestWebKitAPI::Number::create):
2818         (TestWebKitAPI::Number::~Number):
2819         (TestWebKitAPI::Number::value):
2820         (TestWebKitAPI::Number::Number):
2821         (TestWebKitAPI::multiplyNumberByTwo):
2822         (TestWebKitAPI::TEST):
2823
2824 2011-12-24  Kentaro Hara  <haraken@chromium.org>
2825
2826         Add unittests for the C++ parser of prepare-ChangeLog
2827         https://bugs.webkit.org/show_bug.cgi?id=75191
2828
2829         Reviewed by Ryosuke Niwa.
2830
2831         cpp_unittests.cpp is the unittests for get_function_line_ranges_for_cpp()
2832         of prepare-ChangeLog.
2833
2834         * Scripts/prepare-ChangeLog:
2835         (get_function_line_ranges): Renames get_function_line_ranges_for_c()
2836         to get_function_line_ranges_for_cpp().
2837         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
2838         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt: Added.
2839         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp: Added.
2840         (func1):
2841         (func2):
2842         (func3):
2843         (func4):
2844         (func5):
2845         (func6):
2846         (func7):
2847         (func8):
2848         (func9):
2849         (func10):
2850         (func11):
2851         (func12):
2852         (func13):
2853         (func14):
2854         (func15):
2855         (funcOverloaded):
2856         (Class::func16):
2857         (Class1::Class2::func17):
2858         (Class2::func18):
2859         (Class2::func19):
2860         (Class2::func20):
2861         (Class2::func21):
2862         (Class2::func22):
2863         (func23):
2864         (func24):
2865         (Class2::func25):
2866         (Class1::func26):
2867         (Class2::func27):
2868         (Class3::func28):
2869         (Class7::operator+):
2870         (Class100::Class100):
2871         (Class101::~Class101):
2872         (Class102::Class102):
2873         (Class103::Class103):
2874         (Struct1::func29):
2875         (Struct2::func30):
2876         (NameSpace1::func30):
2877         (NameSpace1::NameSpace2::func31):
2878
2879 2011-12-24  Kentaro Hara  <haraken@chromium.org>
2880
2881         Add unittests for the Java parser of prepare-ChangeLog
2882         https://bugs.webkit.org/show_bug.cgi?id=75195
2883
2884         Reviewed by Ryosuke Niwa.
2885
2886         java_unittests.java is unittest cases for get_function_line_ranges_for_java()
2887         of prepare-ChangeLog.
2888
2889         * Scripts/prepare-ChangeLog:
2890         (get_function_line_ranges_for_java): Fixed a parser bug.
2891
2892             interface I
2893             {
2894                 void f()
2895                 {
2896                 }
2897             }
2898
2899         should be recognized as "I.f", and
2900
2901             class C interface I
2902             {
2903                 void f()
2904                 {
2905                 }
2906             }
2907
2908         should be recognized as "C.f".
2909         Without this patch, both are recognized as "I.f".
2910
2911         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
2912         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/java_unittests-expected.txt: Added.
2913         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/java_unittests.java: Added.
2914         (Simple):
2915         (Simple.func1):
2916         (Simple.func2):
2917         (Simple.func3):
2918         (Simple.func4):
2919         (Simple.func5):
2920         (Simple.func6):
2921         (Simple.func7):
2922         (Simple.func8):
2923         (Simple.func9):
2924         (Simple.func10):
2925         (Simple.funcOverloaded):
2926         (Simple.func11):
2927         (Simple.func12):
2928         (Simple.func13):
2929         (Simple.func14):
2930         (Simple.func15):
2931         (Simple.func16):
2932         (Simple.func17):
2933         (Simple.func18):
2934         (Simple.func19):
2935         (Simple.func20):
2936         (Simple.func21):
2937         (Derived1):
2938         (Derived1.Derived1):
2939         (Derived1.func22):
2940         (Interface1):
2941         (Interface2):
2942         (Interface2.func23):
2943         (Derived2):
2944         (Derived2.Derived2):
2945         (Derived2.func23):
2946
2947 2011-12-24  Kentaro Hara  <haraken@chromium.org>
2948
2949         Add unittests for the Python parser of prepare-ChangeLog
2950         https://bugs.webkit.org/show_bug.cgi?id=75197
2951
2952         Reviewed by Ryosuke Niwa.
2953
2954         python_unittests.py is the unittest for get_function_line_ranges_for_python()
2955         of prepare-ChangeLog. The unittest just contains classes and defs that are not nested.
2956         This is because the current python parser is wrong, and it cannot correctly parse nested
2957         classes and defs (even one def in a class), nor class inheritance.
2958         We will fix it in another patch.
2959
2960         * Scripts/prepare-ChangeLog:
2961         (get_function_line_ranges_for_python): Ignores comment lines that starts from #.
2962         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
2963         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests-expected.txt: Added.
2964         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests.py: Added.
2965         (func1):
2966         (func2):
2967         (func3):
2968         (funcInsideComment):
2969         (func4):
2970         (func5):
2971         (func6):
2972         (funcOverloaded):
2973         (Class1):
2974
2975 2011-12-24  Dan Bernstein  <mitz@apple.com>
2976
2977         Set SHARED_PRECOMPS_DIR when Xcode is set to use a custom build product path.
2978
2979         Reviewed by Anders Carlsson.
2980
2981         * Scripts/webkitdirs.pm:
2982         (determineBaseProductDir):
2983
2984 2011-12-24  Dan Bernstein  <mitz@apple.com>
2985
2986         Make build-webkit aware of additional Xcode build location defaults.
2987
2988         Reviewed by Anders Carlsson.
2989
2990         * Scripts/webkitdirs.pm:
2991         (determineXcodeVersion): Added. This was previously in determineBaseProductDir().
2992         (readXcodeUserDefault): Added. Factored out from determineBaseProductDir().
2993         (determineBaseProductDir): Changed to check for a custom build location
2994         style specified as an absolute location.
2995
2996 2011-12-24  Ryosuke Niwa  <rniwa@webkit.org>
2997
2998         Unreviewed, rolling out r103619.
2999         http://trac.webkit.org/changeset/103619
3000         https://bugs.webkit.org/show_bug.cgi?id=66509
3001
3002         Broke chromium clang build
3003
3004         * DumpRenderTree/chromium/TestWebWorker.h:
3005         (TestWebWorker::createWorker):
3006         * DumpRenderTree/chromium/WebViewHost.cpp:
3007         (WebViewHost::createWorker):
3008         * DumpRenderTree/chromium/WebViewHost.h:
3009
3010 2011-12-23  Daniel Bates  <dbates@webkit.org>
3011
3012         Provide option to disable Mac OS 10.7 application resume when using
3013         {debug, run}-{safari, minibrowser, test-runner, test-webkit-api}, and run-webkit-app
3014         https://bugs.webkit.org/show_bug.cgi?id=66902
3015
3016         Reviewed by David Kilzer.
3017
3018         Add an optional command line argument --no-saved-state to disable
3019         application resume (state restoration) for the session on Mac OS 10.7.
3020
3021         For instance, when debugging an issue in Safari it is useful to be able
3022         to temporarily disable application resume. Currently you can disable
3023         application resume when launching Safari from within Xcode. We should
3024         expose a similar option in our command line tools.
3025
3026         * Scripts/debug-minibrowser: Call printHelpAndExitForRunAndDebugWebKitAppIfNeeded()
3027         to print a help message and exit() if the command line argument --help was given.
3028         * Scripts/debug-safari: Ditto.
3029         * Scripts/debug-test-runner: Ditto.
3030         * Scripts/run-minibrowser: Ditto.
3031         * Scripts/run-safari: Ditto.
3032         * Scripts/run-test-runner: Ditto.
3033         * Scripts/run-test-webkit-api: Ditto.
3034         * Scripts/run-webkit-app: Ditto.
3035         * Scripts/webkitdirs.pm:
3036         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Added.
3037         (argumentsForRunAndDebugMacWebKitApp): Added.
3038         (runMacWebKitApp): If the --no-saved-state command line argument was given then
3039         disable application resume for the session.
3040         (execMacWebKitAppForDebugging): Ditto.
3041
3042 2011-12-23  Dmitry Lomov  <dslomov@google.com>
3043
3044         [WebWorkers][Chromium] Remove remains of cross-process dedicated worker implementation.
3045         https://bugs.webkit.org/show_bug.cgi?id=66509
3046         Just renames, merges and removal of dead code. Here are the list of renames:
3047           - WebCommonWorkerClient merged with WebWorkerClient and renamed to WebSharedWorkerClient
3048           - NewWebCommonWorkerClient renamed to WebCommonWorkerClient
3049           - WebWorkerBase merged into WebSharedWorkerImpl
3050           - NewWebWorkerBase renamed into WebWorkerBase
3051  
3052         Reviewed by David Levin.
3053
3054         * DumpRenderTree/chromium/TestWebWorker.h:
3055         (TestWebWorker::createWorker):
3056         * DumpRenderTree/chromium/WebViewHost.cpp:
3057         (WebViewHost::createWorker):
3058         * DumpRenderTree/chromium/WebViewHost.h:
3059
3060 2011-12-23  Kentaro Hara  <haraken@chromium.org>
3061
3062         Let parser_unittests.pl call different language parsers
3063         https://bugs.webkit.org/show_bug.cgi?id=75081
3064
3065         Reviewed by David Kilzer.
3066
3067         We introduced parser_unittests.pl in bug 74994 , but it is implemented
3068         to always call get_function_line_ranges_for_perl(). In order to enable unittests
3069         for other languages, this patch lets parser_unittests.pl call different language
3070         parsers depending on the languages.
3071
3072         Test: Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl
3073
3074         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
3075
3076 2011-12-22  Adam Roben  <aroben@apple.com>
3077
3078         Snow Leopard test fix
3079
3080         * Scripts/webkitpy/test/main.py:
3081         (Tester.run_tests): Python 2.6.1 doesn't seem to like specifying testRunner=None to
3082         unittest.main, even though that's the default. So now we explicitly specify a
3083         TextTestRunner.
3084
3085 2011-12-22  Chris Fleizach  <cfleizach@apple.com>
3086
3087         AX: attributed strings do not include AXHeading information when a link is contained within the heading
3088         https://bugs.webkit.org/show_bug.cgi?id=75059
3089
3090         Reviewed by Darin Adler.
3091
3092         Support the ability to check if an arbitrary attribute is present within an
3093         attributed string that can be retrieved through an AccessibilityTextMarkerRange.
3094
3095         * DumpRenderTree/AccessibilityUIElement.cpp:
3096         (attributedStringForTextMarkerRangeContainsAttributeCallback):
3097         (AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
3098         (AccessibilityUIElement::getJSClass):
3099         * DumpRenderTree/AccessibilityUIElement.h:
3100         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3101         (AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
3102         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3103         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
3104         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3105         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3106         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3107         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
3108
3109 2011-12-22  David Kilzer  <ddkilzer@apple.com>
3110
3111         run-api-tests: runAllTests() and runTest() should not use global variables
3112
3113         Reviewed by Adam Roben.
3114
3115         Part of: <http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests
3116
3117         * Scripts/run-api-tests:
3118         (runTestsBySuite): Rename from runAllTests().  Add arguments for
3119         list of tests and $verbose.
3120         (runTest): Add $verbose argument.
3121
3122 2011-12-22  David Kilzer  <ddkilzer@apple.com>
3123
3124         run-api-tests: inline runAllTestsInSuite() into runAllTests()
3125
3126         Reviewed by Adam Roben.
3127
3128         Part of: <http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests
3129
3130         In order to make it easy to run one or more individual suites,
3131         or one more individual tests, it's easier to call a single
3132         method with different data structures than individual methods.
3133
3134         * Scripts/run-api-tests:
3135         (runAllTests): Inline runAllTestsInSuite().
3136
3137 2011-12-22  Adam Roben  <aroben@apple.com>
3138
3139         Add a --xml flag to test-webkitpy
3140
3141         test-webkitpy --xml will, in addition to providing the standard text output on stdout, write
3142         JUnit-style XML files to a test-webkitpy-xml-reports subdirectory in the working directory.
3143         This is useful for working with tools that consume JUnit-style XML files.
3144
3145         Fixes <http://webkit.org/b/75090> Would like a way to generate JUnit-style XML files when
3146         running test-webkitpy
3147
3148         Reviewed by Darin Adler.
3149
3150         * Scripts/webkitpy/test/main.py:
3151         (Tester.run_tests): If the --xml flag is passed, create an XMLTestRunner and pass it to
3152         unittest.main(). Otherwise pass no test runner so that unittest will choose its own default.
3153
3154         * Scripts/webkitpy/thirdparty/__init__.py:
3155         (AutoinstallImportHook.find_module):
3156         (AutoinstallImportHook._install_xmlrunner):
3157         Added code to install unittest-xml-reporting as webkitpy.thirdparty.autoinstalled.xmlrunner.
3158         This change is untested because it's basically impossible to get a test to pass when --xml
3159         is passed to test-webkitpy (because xmlrunner will already have been imported by the time
3160         the test runs).
3161
3162 2011-12-22  David Kilzer  <ddkilzer@apple.com>
3163
3164         TestWebKitAPI: initialize the main thread before running tests
3165         <http://webkit.org/b/75064>
3166
3167         Reviewed by Adam Roben.
3168
3169         * TestWebKitAPI/TestsController.cpp:
3170         (TestWebKitAPI::TestsController::TestsController): Call
3171         WTF::initializeMainThread() to prevent assertions in Debug
3172         builds.
3173
3174 2011-12-22  David Kilzer  <ddkilzer@apple.com>
3175
3176         run-api-tests: dumpAllTests() should not use global variables
3177
3178         Reviewed by Adam Roben.
3179
3180         Part of: <http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests
3181
3182         * Scripts/run-api-tests: Renamed $dump to $dumpTests.
3183         (dumpTestsBySuite): Rename from dumpAllTests() and pass in
3184         global data as an argument.  Sort suite names and test names
3185         alphabetically to match output when running tests.
3186
3187 2011-12-22  Leo Yang  <leo.yang@torchmobile.com.cn>
3188
3189         [BlackBerry] Enable blob for the BlackBerry porting
3190         https://bugs.webkit.org/show_bug.cgi?id=75074
3191
3192         Reviewed by George Staikos.
3193
3194         * Scripts/build-webkit:
3195
3196 2011-12-22  Kentaro Hara  <haraken@chromium.org>
3197
3198         Add unittests for the Perl parser of prepare-ChangeLog
3199         https://bugs.webkit.org/show_bug.cgi?id=74994
3200
3201         Reviewed by David Kilzer.
3202
3203         This patch adds unittests for get_function_line_ranges_for_perl() of prepare-ChangeLog.
3204
3205         Test: Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl
3206
3207         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl: Added.
3208         Runs unittests specified in @testFiles.
3209         You can reset expected results by specifying a --reset-results option.
3210         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl: Added.
3211         Contains simple methods.
3212         (func1):
3213         (func2):
3214         (func3):
3215         (func4):
3216         (func5):
3217         (func6):
3218         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt: Added.
3219         This test result is generated by the --reset-results option.
3220
3221 2011-12-21  Eric Seidel  <eric@webkit.org>
3222
3223         Add webkit.review.bot@gmail.com and commit-queue@webkit.org as "contributors"
3224         so that they appear in the bugzilla autocomplete CC list.
3225         I also removed the "radar" irc nick (which I believe does not exist)
3226         and removed the uneeded [] around the radar bugzilla email.
3227
3228         Unreviewed.
3229
3230         * Scripts/webkitpy/common/config/committers.py:
3231
3232 2011-12-21  Daniel Bates  <dbates@rim.com>
3233
3234         Teach build-jsc how to build JavaScriptCore for the EFL, BlackBerry, and WinCE ports
3235         https://bugs.webkit.org/show_bug.cgi?id=74985
3236
3237         Reviewed by Eric Seidel.
3238
3239         * Scripts/build-jsc:
3240         * Scripts/webkitdirs.pm:
3241         (cmakeBasedPortName): Added.
3242
3243 2011-12-21  Daniel Bates  <dbates@rim.com>
3244
3245         Extract BlackBerry CMake arguments from build-webkit into separate function
3246         https://bugs.webkit.org/show_bug.cgi?id=74981
3247
3248         Reviewed by Rob Buis.
3249
3250         Towards adding support for using Tools/Scripts/build-jsc for the BlackBerry port, move
3251         the CMake argument logic from Tools/Scripts/build-webkit to function webkitdirs::blackberryCMakeArguments()
3252         and have cmakeBasedPortArguments() call this function for the BlackBerry CMake argument list.
3253         This will allow us to get the BlackBerry CMake arguments in Tools/Scripts/build-jsc so
3254         that we can pass them to the CMake build system when building JavaScriptCore.
3255
3256         * Scripts/build-webkit: Move construction of CMake argument list from here to
3257         webkitdirs::blackberryCMakeArguments(). Also, remove exported function blackberryTargetArchitecture()
3258         since it's only called within webkitdirs.pm now. Formerly we exported this function so that we could
3259         call it from build-webkit.
3260         * Scripts/webkitdirs.pm:
3261         (blackberryCMakeArguments): Added.
3262         (cmakeBasedPortArguments): Modified to call blackberryCMakeArguments() when building the
3263         BlackBerry port.
3264
3265 2011-12-21  Daniel Bates  <dbates@webkit.org>
3266
3267         Extract WinCE CMake arguments from build-webkit into separate function
3268         https://bugs.webkit.org/show_bug.cgi?id=74983
3269
3270         Reviewed by Rob Buis.
3271
3272         Towards adding support for using Tools/Scripts/build-jsc for the WinCE port, extract the
3273         WinCE-specific CMake argument from Tools/Scripts/build-webkit into webkitdirs::cmakeBasedPortArguments().
3274         This will allow us to get the WinCE-specific CMake argument in Tools/Scripts/build-jsc so
3275         that we can pass it to the CMake build system when building JavaScriptCore.
3276
3277         * Scripts/build-webkit:
3278         * Scripts/webkitdirs.pm:
3279         (cmakeBasedPortArguments): Added.
3280
3281 2011-12-21  Kentaro Hara  <haraken@chromium.org>
3282
3283         In prepare-ChangeLog, replace constant global variables with "use constant"
3284         https://bugs.webkit.org/show_bug.cgi?id=74992
3285
3286         Reviewed by Ryosuke Niwa.
3287
3288         This patch replaces the following constant global variables with "use constant"s.
3289             - $changeLogTimeZone
3290             - $SVN
3291             - $GIT
3292             - %supportedTestExtensions
3293
3294         * Scripts/prepare-ChangeLog:
3295         (changeLogNameFromArgs):
3296         (changeLogEmailAddressFromArgs):
3297         (resolveConflictedChangeLogs):
3298         (generateNewChangeLogs):
3299         (diffCommand):
3300         (statusCommand):
3301         (createPatchCommand):
3302         (findOriginalFileFromSvn):
3303         (determinePropertyChanges):
3304         (generateFileList):
3305         (reviewerAndDescriptionForGitCommit):
3306
3307 2011-12-20  Dirk Pranke  <dpranke@chromium.org>
3308
3309         nrwt: rename field references from _fs to _filesystem
3310         https://bugs.webkit.org/show_bug.cgi?id=74898
3311
3312         Reviewed by Adam Barth.
3313
3314         This is a simple cleanup; most of the code uses
3315         self._filesystem, but some used self._fs; this change renames
3316         the latter to the former to be more consistent.
3317
3318         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3319         (Manager.__init__):
3320         (Manager.collect_tests):
3321         (Manager._strip_test_dir_prefix):
3322         (Manager._split_into_chunks_if_necessary):
3323         (Manager.results_directory):
3324         (Manager._clobber_old_results):
3325         (Manager._upload_json_files):
3326         (Manager.print_config):
3327         (Manager._copy_results_html_file):
3328         (Manager._show_results_html_file):
3329         (Manager._log_worker_stack):
3330         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3331         (JSONLayoutResultsGenerator._normalize_results_json):
3332         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3333         (JSONResultsGeneratorBase.__init__):
3334         (JSONResultsGeneratorBase.generate_json_output):
3335         (JSONResultsGeneratorBase.generate_times_ms_file):
3336         (JSONResultsGeneratorBase.upload_json_files):
3337         (JSONResultsGeneratorBase._get_svn_revision):
3338         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3339         (Base.__init__):
3340
3341 2011-12-20  Kentaro Hara  <haraken@chromium.org>
3342
3343         Replace webkitperl/run-leaks_unittest/RunLeaks.pm with webkitperl/LoadAsModule.pm
3344         https://bugs.webkit.org/show_bug.cgi?id=74836
3345
3346         Reviewed by David Kilzer.
3347
3348         webkitperl/run-leaks_unittest/RunLeaks.pm can be used for unit-testing of run-leaks only.
3349         This patch creates more generalized webkitperl/LoadAsModule.pm, which can be also used
3350         for unit-testing of other Perl scripts. We are planning to use it for unit-testing
3351         of prepare-ChangeLog.
3352
3353         Using LoadAsModule.pm, you can load a Perl script as follows.
3354         The first argument is the arbitrary package name you want to use, and the second argument
3355         is the name of the Perl script you want to load.
3356
3357             use LoadAsModule qw(RunLeaks run-leaks);
3358             RunLeaks::someFunctionDefinedInRunLeaks(...);
3359
3360         Tests: Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl
3361                Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl
3362                Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl
3363
3364         * Scripts/webkitperl/LoadAsModule.pm: Added.
3365         * Scripts/webkitperl/run-leaks_unittest/RunLeaks.pm: Removed.
3366         (import):
3367         (readFile):
3368         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl: Used LoadAsModule instead of RunLeaks.
3369         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl: Ditto.
3370         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl: Ditto.
3371
3372 2011-12-20  Balazs Kelemen  <kbalazs@webkit.org>
3373
3374         [Qt] WK2 Debugging quirks need some improvement
3375         https://bugs.webkit.org/show_bug.cgi?id=74859
3376
3377         Reviewed by Simon Hausmann.
3378
3379         Improvements added to make debugging WebKit2 more
3380         confortable and efficient:
3381         1. Unify debugging quirks. From now all of them are controlled
3382         by the QT_WEBKIT2_DEBUG environment variable.
3383         2. Disable crash handlers for WebKitTestRunner if debugging quirks
3384         are used to make it possible to use postmortem debugging via core dumps
3385         which is extremely useful for debugging bugs triggered by layout tests.
3386         3. Disable test timeout for WebKitTestRunner if debugging quirks
3387         are used because that makes debugging impossible.
3388
3389         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
3390         (WTR::InjectedBundle::platformInitialize):
3391         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
3392         (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
3393         * WebKitTestRunner/qt/TestControllerQt.cpp:
3394         (WTR::TestController::platformRunUntil):
3395
3396 2011-12-20  Rafael Brandao  <rafael.lobo@openbossa.org>
3397
3398         [Qt][WK2] Implement favicon support
3399         https://bugs.webkit.org/show_bug.cgi?id=71082
3400
3401         Reviewed by Simon Hausmann.
3402
3403         A favorite icon was added on MiniBrowser's url bar as example.
3404         We display a default icon when the page doesn't have an icon ready.
3405
3406         * MiniBrowser/qt/MiniBrowser.qrc:
3407         * MiniBrowser/qt/icons/favicon.png: Added.
3408         * MiniBrowser/qt/qml/BrowserWindow.qml:
3409
3410 2011-12-19  Sam Weinig  <sam@webkit.org>
3411
3412         Add support for scrollLineDown: and scrollLineUp: NSResponder selectors
3413         https://bugs.webkit.org/show_bug.cgi?id=74907
3414
3415         Reviewed by Dan Bernstein.
3416
3417         Add ScrollByLineCommands API test.
3418
3419         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3420         * TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm: Added.
3421         * TestWebKitAPI/Tests/WebKit2/simple-tall.html: Added.
3422
3423 2011-12-19  Dirk Pranke  <dpranke@chromium.org>
3424
3425         webkitpy: remove port.executive, port.filesystem, port.user properties
3426         https://bugs.webkit.org/show_bug.cgi?id=74896
3427
3428         Reviewed by Eric Seidel.
3429
3430         Following on the refactoring of the port and host objects, this
3431         removes the public executive, filesystem, and user properties
3432         from the Port interface (protected versions of executive and
3433         filesystem still exist). There is still some more clean up to
3434         make the code more consistent and rearrange some other files to
3435         talk to Hosts directly instead of getting them off of the Port
3436         class.
3437
3438         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3439         (Manager.__init__):
3440         (Manager.results_directory):
3441         (Manager._log_worker_stack):
3442         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3443         (ManagerTest.test_fallback_path_in_config):
3444         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
3445         (_InlineManager.start_worker):
3446         (_InlineWorkerConnection.__init__):
3447         * Scripts/webkitpy/layout_tests/controllers/worker.py:
3448         (Worker.safe_init):
3449         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
3450         (TestConfiguration.from_port):
3451         * Scripts/webkitpy/layout_tests/port/base.py:
3452         (Port.__init__):
3453         (Port.tests):
3454         (Port.show_results_html_file):
3455         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3456         (PortTest.test_layout_tests_skipping):
3457         (PortTest.test_test_dirs):
3458         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3459         (_set_up_derived_options):
3460         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3461         (PerfTestsRunner.__init__):
3462         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
3463         (HtmlGenerator.__init__):
3464         (HtmlGenerator.show_html):
3465         (real_main):
3466         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
3467         (TestHtmlGenerator.make_generator):
3468
3469 2011-12-19  Daniel Bates  <dbates@webkit.org>
3470
3471         Pass command line arguments to GDB when debugging a Mac WebKit application
3472         https://bugs.webkit.org/show_bug.cgi?id=72829
3473
3474         Reviewed by David Kilzer.
3475
3476         Pass through any command line arguments given to debug-{safari, minibrowser}
3477         to GDB so that they may influence the application instance launched by GDB.
3478
3479         * Scripts/webkitdirs.pm:
3480         (execMacWebKitAppForDebugging):
3481
3482 2011-12-19  Dirk Pranke  <dpranke@chromium.org>
3483
3484         webkitpy: remove executive,filesystem,user parameters from Port constructor
3485         https://bugs.webkit.org/show_bug.cgi?id=74878
3486
3487         Reviewed by Eric Seidel.
3488
3489         This change concludes the refactoring that makes Host a required
3490         parameter for Port and ensures that all access to filesystem,
3491         executives, etc. is going through the Host.
3492
3493         * Scripts/webkitpy/layout_tests/port/base.py:
3494         (Port.__init__):
3495
3496 2011-12-19  Dirk Pranke  <dpranke@chromium.org>
3497
3498         webkitpy: finish refactoring port classes to make a host mandatory
3499         https://bugs.webkit.org/show_bug.cgi?id=74566
3500
3501         Reviewed by Eric Seidel.
3502
3503         This change makes all Port objects take a required (System)Host
3504         parameter, and updates the TestPort object to no longer create a
3505         mock filesystem or add files to the existing filesystem by
3506         default.
3507
3508         * Scripts/webkitpy/layout_tests/port/base.py:
3509         (Port.__init__):
3510         * Scripts/webkitpy/layout_tests/port/factory.py:
3511         (PortFactory.__init__):
3512         (PortFactory._get_kwargs):
3513         * Scripts/webkitpy/layout_tests/port/test.py:
3514         (TestInstance.__init__):
3515         (TestPort.__init__):
3516         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3517         (passing_run):
3518         (logging_run):
3519         (get_tests_run):
3520         (MainTest.test_single_file):
3521         (MainTest.test_stderr_is_saved):
3522         (MainTest.test_test_list):
3523         (MainTest.test_test_list_with_prefix):
3524         (MainTest.test_missing_and_unexpected_results):
3525         (MainTest.test_missing_and_unexpected_results_with_custom_exit_code):
3526         (MainTest.test_crash_with_stderr):
3527         (MainTest.test_no_image_failure_with_image_diff):
3528         (MainTest.test_crash_log):
3529         (MainTest.test_web_process_crash_log):
3530         (MainTest.test_exit_after_n_failures_upload):
3531         (MainTest.test_results_directory_absolute):
3532         (MainTest.test_results_directory_relative):
3533         (MainTest.test_retries_directory):
3534         (MainTest.test_tolerance.get_port_for_run):
3535         (MainTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
3536         (EndToEndTest.test_end_to_end):
3537         (EndToEndTest.test_reftest_with_two_notrefs):
3538         (RebaselineTest.test_reset_results):
3539         (RebaselineTest.test_missing_results):
3540         (RebaselineTest.test_new_baseline):
3541         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
3542         (Rebaseliner.__init__):
3543         (main):
3544         (real_main):
3545         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
3546         (test_host_port_and_filesystem):
3547         (TestRebaseliner.make_rebaseliner):
3548         (TestRealMain.test_all_platforms):
3549         (TestHtmlGenerator.make_generator):
3550
3551 2011-12-19  Dirk Pranke  <dpranke@chromium.org>
3552
3553         webkitpy: update unit tests in preparation for making host a mandatory parameter to Port objects
3554         https://bugs.webkit.org/show_bug.cgi?id=74562
3555
3556         Reviewed by Eric Seidel.
3557
3558         Apart from a minor change to style/checkers/test_expectations.py
3559         to take a host as a parameter to a TestExpectationsChecker(),
3560         there are only refactoring changes to unit tests here.
3561
3562         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
3563         (TestResultWriterTest.test_reftest_diff_image):
3564         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3565         (JSONGeneratorTest._test_json_generation):
3566         (JSONGeneratorTest.test_test_timings_trie):
3567         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3568         (Base.__init__):
3569         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3570         (PortTest.make_port):
3571         (PortTest.test_layout_tests_skipping):
3572         (PortTest.test_test_dirs):
3573         (PortTest.test_additional_platform_directory):
3574         (PortTest.test_uses_test_expectations_file):
3575         (PortTest.test_find_no_paths_specified):
3576         (PortTest.test_find_one_test):
3577         (PortTest.test_find_glob):
3578         (PortTest.test_find_with_skipped_directories):
3579         (PortTest.test_find_with_skipped_directories_2):
3580         (PortTest.test_parse_reftest_list):
3581         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3582         (DryRunPort.__init__):
3583         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
3584         (FactoryTest.setUp):
3585         (FactoryTest.tearDown):
3586         (FactoryTest.assert_port):
3587         (FactoryTest.assert_platform_port):
3588         (FactoryTest.test_unknown_specified):
3589         (FactoryTest.test_unknown_default):
3590         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
3591         (GetGoogleChromePortTest._verify_expectations_overrides):
3592         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
3593         (MockDRTPortTest.make_port):
3594         (MockDRTTest.assertTest):
3595         (MockDRTTest.test_main):
3596         (MockChromiumDRTTest.test_pixeltest__fails):
3597         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
3598         (QtPortTest._assert_search_path):
3599         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3600         (TestWebKitPort.__init__):
3601         (WebKitPortTest.test_skipped_directories_for_symbols):
3602         (test_skipped_directories_for_features):
3603         (test_skipped_layout_tests):
3604         (test_skipped_file_search_paths):
3605         (test_root_option):
3606         (test_test_expectations):
3607         (test_build_driver):
3608         (test_linux_distro_detection):
3609         (test_apache_config_file_name_for_platform):
3610         (test_path_to_apache_config_file):
3611         (WebKitDriverTest.test_read_block):
3612         * Scripts/webkitpy/style/checkers/test_expectations.py:
3613         (TestExpectationsChecker.__init__):
3614         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
3615         (TestExpectationsTestCase._expect_port_for_expectations_path):
3616         (TestExpectationsTestCase.assert_lines_lint):
3617         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
3618         (get_test_config.TestMacPort):
3619
3620 2011-12-19  Raphael Kubo da Costa  <kubo@profusion.mobi>
3621
3622         [Efl] Fix path returned by builtDylibPathForName in webkitdirs.pm
3623         https://bugs.webkit.org/show_bug.cgi?id=74854
3624
3625         Reviewed by Csaba Osztrogonác.
3626
3627         Since r101052, libewebkit.so is built in a different location, so we
3628         need to adjust the path returned by builtDylibPathForName.
3629
3630         usesPerConfigurationBuildDirectory also needs to be fixed, as the&