Unreviewed, rolling out r245418.
[WebKit-https.git] / Tools / ChangeLog
1 2019-05-17  Commit Queue  <commit-queue@webkit.org>
2
3         Unreviewed, rolling out r245418.
4         https://bugs.webkit.org/show_bug.cgi?id=197989
5
6         New API test causing crashes on Mojave testers (Requested by
7         ShawnRoberts on #webkit).
8
9         Reverted changeset:
10
11         "Add a unit test for client certificate authentication"
12         https://bugs.webkit.org/show_bug.cgi?id=197800
13         https://trac.webkit.org/changeset/245418
14
15 2019-05-17  Aakash Jain  <aakash_jain@apple.com>
16
17         [ews-build] Add build step to Transfer archive to S3
18         https://bugs.webkit.org/show_bug.cgi?id=197922
19
20         Reviewed by Jonathan Bedard.
21
22         * BuildSlaveSupport/ews-build/steps.py:
23         (TransferToS3):
24         (TransferToS3.finished): Invoke triggers after transfer is successful.
25         (TransferToS3.getResultSummary): Create more readable failure string.
26         (UploadBuiltProduct.finished): Deleted. Moved the trigger invocation after TransferToS3.
27         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
28
29 2019-05-16  Carlos Garcia Campos  <cgarcia@igalia.com>
30
31         [GTK] Need WebKitContextMenuItemType to open emoji picker
32         https://bugs.webkit.org/show_bug.cgi?id=176760
33
34         Reviewed by Michael Catanzaro.
35
36         Update context menu test to check insert emoji action is included in default context menu for editable content.
37
38         * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
39
40 2019-05-16  Aakash Jain  <aakash_jain@apple.com>
41
42         [ews-build] Download archives from S3
43         https://bugs.webkit.org/show_bug.cgi?id=197949
44
45         Reviewed by Jonathan Bedard.
46
47         * BuildSlaveSupport/ews-build/steps.py:
48         (DownloadBuiltProduct): Updated to use S3 URL.
49         (DownloadBuiltProduct.getResultSummary): Method to display custom failure string.
50         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
51
52 2019-05-16  David Kilzer  <ddkilzer@apple.com>
53
54         REGRESSION (r15133): Fix leak of JSStringRef in minidom
55         <https://webkit.org/b/197968>
56         <rdar://problem/50872430>
57
58         Reviewed by Joseph Pecoraro.
59
60         * TestWebKitAPI/Tests/WebKitObjC/UserContentTest.mm:
61         (expectScriptValueIsString): Drive-by fix to use adopt() instead
62         of JSRetainPtr<JSStringRef> string(Adopt, JSValueToStringCopy(...)).
63
64 2019-05-16  David Kilzer  <ddkilzer@apple.com>
65
66         REGRESSION (r84160): Leak of OpaqueJSString under WTR::JSTestRunner::pathToLocalResource (32 bytes) in com.apple.WebKit.WebContent running layout tests
67         <https://webkit.org/b/197965>
68
69         Reviewed by Joseph Pecoraro.
70
71         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
72         (WTR::TestRunner::pathToLocalResource): Don't call
73         JSStringRetain() here because the JSRetainPtr<JSStringRef>
74         return type will increment the retain count for us.
75
76 2019-05-16  Alex Christensen  <achristensen@webkit.org>
77
78         Add a unit test for client certificate authentication
79         https://bugs.webkit.org/show_bug.cgi?id=197800
80
81         Reviewed by Youenn Fablet.
82
83         Make better abstractions for reading and writing from/to TCPServer.
84         Add a unit test that causes a client certificate authentication challenge to happen.
85
86         * TestWebKitAPI/TCPServer.cpp:
87         (TestWebKitAPI::TCPServer::TCPServer):
88         (TestWebKitAPI::TCPServer::read):
89         (TestWebKitAPI::TCPServer::write):
90         (TestWebKitAPI::TCPServer::respondWithChallengeThenOK):
91         (TestWebKitAPI::TCPServer::respondWithOK):
92         * TestWebKitAPI/TCPServer.h:
93         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
94         (credentialWithIdentity):
95         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
96         (TEST):
97         (-[ClientCertificateDelegate webView:didFinishNavigation:]):
98         (-[ClientCertificateDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
99         (-[ClientCertificateDelegate challengeCount]):
100         (TestWebKitAPI::TEST):
101         (respondWithChallengeThenOK): Deleted.
102         (credentialWithIdentityAndKeychainPath): Deleted.
103         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
104         (TEST):
105         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
106         (TestWebKitAPI::TEST):
107         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
108         (TEST):
109         (readRequest): Deleted.
110         (writeResponse): Deleted.
111         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
112         (TestWebKitAPI::TEST):
113         (TestWebKitAPI::respondWithChallengeThenOK): Deleted.
114
115 2019-05-16  Alex Christensen  <achristensen@webkit.org>
116
117         Add SPI to set a list of hosts to which to send custom header fields cross-origin
118         https://bugs.webkit.org/show_bug.cgi?id=197397
119
120         Reviewed by Geoff Garen.
121
122         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
123         (TEST):
124         (expectLegacyHeaders):
125         (expectHeaders):
126         (-[CustomHeaderFieldsDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
127         (-[CustomHeaderFieldsDelegate webView:startURLSchemeTask:]):
128         (-[CustomHeaderFieldsDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
129
130 2019-05-15  Aakash Jain  <aakash_jain@apple.com>
131
132         Replace double-quotes with single quotes in steps.py
133         https://bugs.webkit.org/show_bug.cgi?id=197921
134
135         Reviewed by Jonathan Bedard.
136
137         * BuildSlaveSupport/ews-build/steps.py:
138
139 2019-05-15  Keith Rollin  <krollin@apple.com>
140
141         Rewrite generate-xcfilelists in Python
142         https://bugs.webkit.org/show_bug.cgi?id=197622
143         <rdar://problem/50508222>
144
145         Reviewed by Jonathan Bedard, Alex Christensen.
146
147         For a number of reasons, rewrite generate-xcfilelists in Python:
148
149         - The previous bash script was large and unmaintainable.
150         - We have more internal expertise with Python than with bash.
151         - The bash script used temporary files in /tmp that got stranded and
152           were owned by root, making them awkward to clear out.
153           <rdar://problem/49490262>
154         - We needed to complete support for engineers that built with Xcode
155           rather than the command line.
156         - There are some bugs leading to mildly corrupted .xcfilelist files.
157           It's not apparent the source of the bugs, but one general reason
158           might be due to approaches born of using bash. Rewriting in Python
159           may clear these up.
160
161         * Scripts/generate-xcfilelists:
162         * Scripts/webkitpy/common/attribute_saver.py: Added.
163         (AttributeSaver):
164         (AttributeSaver.__init__):
165         (AttributeSaver.__enter__):
166         (AttributeSaver.__exit__):
167         * Scripts/webkitpy/common/attribute_saver_unittest.py: Added.
168         (AttributeSaverTest):
169         (AttributeSaverTest.SimpleTestClass):
170         (AttributeSaverTest.SimpleTestClass.__init__):
171         (AttributeSaverTest.test_class):
172         (AttributeSaverTest.test_normal_default):
173         (AttributeSaverTest.test_normal_value):
174         (AttributeSaverTest.test_normal_value_on_exception):
175         (AttributeSaverTest.test_normal_value_on_normal_exit):
176         (AttributeSaverTest.test_normal_value_with_finally_on_exception):
177         (AttributeSaverTest.test_normal_value_with_finally_on_normal_exit):
178         (AttributeSaverTest.test_normal_value_with_else_on_exception):
179         (AttributeSaverTest.test_normal_value_with_else_on_normal_exit):
180         * Scripts/webkitpy/generate_xcfilelists_lib/__init__.py: Added.
181         * Scripts/webkitpy/generate_xcfilelists_lib/application.py: Added.
182         (Application):
183         (Application.__init__):
184         (Application.run):
185         (Application._initialize):
186         (Application._initialize.collect_attributes):
187         (Application._create_parser):
188         (_validate_args):
189         (_cmd_generate):
190         (_cmd_check):
191         (_cmd_subgenerate):
192         (_cmd_help):
193         (_do_generate):
194         (_do_merge):
195         (_report_results):
196         (_report_merge_results):
197         (_report_remediation_steps):
198         (_report_remediation_steps.add_to_message):
199         (_any_have_errors):
200         (_any_have_actions):
201         (_log_progress):
202         (_log_results):
203         (get_generate_xcfilelists_script_path):
204         (_get_root_dir):
205         (get_opensource_dir):
206         (get_build_scripts_dir):
207         (get_extract_dependencies_from_makefile_script):
208         (get_xcode_built_products_dir):
209         (_getenv):
210         * Scripts/webkitpy/generate_xcfilelists_lib/generators.py: Added.
211         (BaseGenerator):
212         (BaseGenerator.__init__):
213         (BaseGenerator.__str__):
214         (BaseGenerator.generate):
215         (BaseGenerator._sublaunch_under_xcode):
216         (BaseGenerator.subgenerate):
217         (BaseGenerator.merge):
218         (BaseGenerator.pickle_to_file):
219         (BaseGenerator.has_action):
220         (BaseGenerator.has_error):
221         (BaseGenerator.is_valid):
222         (BaseGenerator.report_error):
223         (BaseGenerator._generate_derived):
224         (BaseGenerator._merge_derived):
225         (BaseGenerator._generate_unified):
226         (BaseGenerator._merge_unified):
227         (BaseGenerator._replace):
228         (BaseGenerator._unexpand):
229         (BaseGenerator._find_added_lines):
230         (BaseGenerator._merge_added_lines):
231         (BaseGenerator._get_file_lines):
232         (BaseGenerator._getenv):
233         (BaseGenerator._get_project_file_path):
234         (BaseGenerator._get_project_dir):
235         (BaseGenerator._get_project_file_name):
236         (BaseGenerator._get_project_name):
237         (BaseGenerator._get_sym_root):
238         (BaseGenerator._get_obj_root):
239         (BaseGenerator._get_shared_precomps_dir):
240         (BaseGenerator._get_build_dirs):
241         (BaseGenerator._get_build_dirs.define_xcode_build_dirs):
242         (BaseGenerator._get_build_dirs.define_xcode_build_dirs.read_xcode_user_default):
243         (BaseGenerator._get_build_dirs.define_command_line_build_dirs):
244         (BaseGenerator._get_derived_sources_dir):
245         (BaseGenerator._get_xcfilelist_dir):
246         (BaseGenerator._get_input_derived_xcfilelist_project_path):
247         (BaseGenerator._get_output_derived_xcfilelist_project_path):
248         (BaseGenerator._get_input_unified_xcfilelist_project_path):
249         (BaseGenerator._get_output_unified_xcfilelist_project_path):
250         (BaseGenerator._get_generate_derived_sources_script):
251         (BaseGenerator._get_generate_unified_sources_script):
252         (JavaScriptCoreGenerator):
253         (JavaScriptCoreGenerator._get_project_file_path):
254         (JavaScriptCoreGenerator._get_generate_derived_sources_script):
255         (JavaScriptCoreGenerator._get_generate_unified_sources_script):
256         (WebCoreGenerator):
257         (WebCoreGenerator._get_project_file_path):
258         (WebCoreGenerator._get_generate_derived_sources_script):
259         (WebCoreGenerator._get_generate_unified_sources_script):
260         (WebKitGenerator):
261         (WebKitGenerator._get_project_file_path):
262         (WebKitGenerator._get_derived_sources_dir):
263         (WebKitGenerator._get_generate_derived_sources_script):
264         (WebKitGenerator._get_generate_unified_sources_script):
265         (DumpRenderTreeGenerator):
266         (DumpRenderTreeGenerator._get_project_file_path):
267         (DumpRenderTreeGenerator._get_generate_derived_sources_script):
268         (WebKitTestRunnerGenerator):
269         (WebKitTestRunnerGenerator._get_project_file_path):
270         (WebKitTestRunnerGenerator._get_generate_derived_sources_script):
271         * Scripts/webkitpy/generate_xcfilelists_lib/util.py: Added.
272         (debug_log):
273         (LogEntryHelper):
274         (LogEntryHelper.__init__):
275         (LogEntryHelper.log_entry):
276         (LogEntryHelper.log_result):
277         (LogEntryHelper.log_exception):
278         (LogEntryHelper._print):
279         (LogEntryExit):
280         (LogEntryExit._show_debug_logging):
281         (LogEntryExitClass):
282         (LogEntryExitClass._show_debug_logging):
283         (LogEntryExitGlobal):
284         (LogEntryExitGlobal._show_debug_logging):
285         (subprocess_run):
286         (is_running_under_xcode):
287         (CheckValidItemAction):
288         (CheckValidItemAction.__init__):
289         (CheckValidItemAction.__call__):
290         (CheckValidItemAction.validate_item):
291         (CheckCommandAction):
292         (CheckCommandAction.__call__):
293         (InvalidCommandError):
294         (InvalidArgumentError):
295         (InvalidConfigurationError):
296         (CalledProcessError):
297         (CalledProcessError.__str__):
298         * Scripts/webkitpy/xcode/__init__.py:
299         (xcode_hash_for_path):
300         (xcode_hash_for_path.convert_to_string):
301         * Scripts/webkitpy/xcode/sdk.py: Added.
302         (SDK):
303         (SDK.__init__):
304         (SDK.__repr__):
305         (SDK.as_xcode_specification):
306         (SDK.get_preferred_sdk_for_platform):
307         (SDK._parse_sdk):
308         * Scripts/webkitpy/xcode/sdk_unittest.py: Added.
309         (SDKTest):
310
311 2019-05-15  Aakash Jain  <aakash_jain@apple.com>
312
313         [ews-build] Enabling uploading EWS archives to S3
314         https://bugs.webkit.org/show_bug.cgi?id=197914
315
316         Reviewed by Jonathan Bedard.
317
318         * BuildSlaveSupport/Shared: Added.
319         * BuildSlaveSupport/Shared/transfer-archive-to-s3: Moved from Tools/BuildSlaveSupport/build.webkit.org-config/transfer-archive-to-s3.
320         (archiveExists): Replace tab with space.
321         (main): Added main method.
322         * BuildSlaveSupport/build.webkit.org-config/steps.py:
323         (TransferToS3): Updated path to the script.
324         * BuildSlaveSupport/build.webkit.org-config/transfer-archive-to-s3: Moved to Shared folder.
325
326 2019-05-15  Wenson Hsieh  <wenson_hsieh@apple.com>
327
328         inputmode="numeric" should show a number pad with digits 0-9, instead of the numeric keyplane
329         https://bugs.webkit.org/show_bug.cgi?id=197916
330         <rdar://problem/50815427>
331
332         Reviewed by Timothy Hatcher.
333
334         Re-enable this previously flaky test, and rebaseline the result to to expect UIKeyboardTypeNumberPad for
335         inputmode="numeric".
336
337         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
338         (TestWebKitAPI::TEST):
339
340 2019-05-15  Youenn Fablet  <youenn@apple.com>
341
342         Reuse existing WebPageProxy quota handler for NetworkProcessProxy quota requests
343         https://bugs.webkit.org/show_bug.cgi?id=197463
344         <rdar://problem/47403621>
345
346         Reviewed by Alex Christensen.
347
348         * TestWebKitAPI/Tests/WebKitCocoa/StorageQuota.mm: Added.
349         (-[QuotaDelegate init]):
350         (-[QuotaDelegate _webView:decideDatabaseQuotaForSecurityOrigin:currentQuota:currentOriginUsage:currentDatabaseUsage:expectedUsage:decisionHandler:]):
351         (-[QuotaDelegate quotaDelegateCalled]):
352         (-[QuotaDelegate grantQuota]):
353         (-[StorageSchemes webView:startURLSchemeTask:]):
354         (-[StorageSchemes webView:stopURLSchemeTask:]):
355         (-[QuotaMessageHandler userContentController:didReceiveScriptMessage:]):
356         (doTest):
357
358 2019-05-15  Youenn Fablet  <youenn@apple.com>
359
360         Constant crashes under WebPage::isThrottleable() after r245299
361         https://bugs.webkit.org/show_bug.cgi?id=197902
362         <rdar://problem/50793796>
363
364         Reviewed by Alex Christensen.
365
366         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
367
368 2019-05-15  Philippe Normand  <pnormand@igalia.com>
369
370         [GTK][jhbuild] misc cleanups and bumps
371         https://bugs.webkit.org/show_bug.cgi?id=197913
372
373         Reviewed by Xabier Rodriguez-Calvar.
374
375         * gstreamer/jhbuild.modules: Bump to libva 2.4.1 and switch to Meson.
376         * gtk/jhbuild.modules: Bump to Brotli 1.0.5 and Wayland 1.16.
377
378 2019-05-15  Chris Dumez  <cdumez@apple.com>
379
380         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
381         https://bugs.webkit.org/show_bug.cgi?id=195102
382         <rdar://problem/48456786>
383
384         Reviewed by Alex Christensen.
385
386         Try to wait longer for the number of processes to reach the expected number
387         and before failing.
388
389         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
390
391 2019-05-15  Alex Christensen  <achristensen@webkit.org>
392
393         Allow NSFileCoordinator to be called from WebContent process
394         https://bugs.webkit.org/show_bug.cgi?id=197895
395         <rdar://problem/50107679>
396
397         Reviewed by Brent Fulgham.
398
399         Add a unit test that verifies calling the block succeeds.
400
401         * TestWebKitAPI/Tests/WebKitCocoa/AdditionalReadAccessAllowedURLsPlugin.mm:
402         (-[AdditionalReadAccessAllowedURLsPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
403
404 2019-05-14  Andy Estes  <aestes@apple.com>
405
406         [Apple Pay] Payment APIs should be completely disabled in web views into which clients have injected user scripts
407         https://bugs.webkit.org/show_bug.cgi?id=197751
408         <rdar://problem/50631563>
409
410         Reviewed by Alex Christensen.
411
412         Added new API tests.
413
414         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm:
415         (-[TestApplePayScriptMessageHandler initWithAPIsAvailableExpectation:canMakePaymentsExpectation:]):
416         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
417         (TestWebKitAPI::TEST):
418         (-[TestApplePayScriptMessageHandler initWithExpectation:]): Deleted.
419         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html:
420
421 2019-05-14  Youenn Fablet  <youenn@apple.com>
422
423         A service worker process should app nap when all its clients app nap
424         https://bugs.webkit.org/show_bug.cgi?id=185626
425         <rdar://problem/46785908>
426
427         Reviewed by Alex Christensen.
428
429         Allow to enable app nap through test header.
430
431         * WebKitTestRunner/TestController.cpp:
432         (WTR::TestController::resetPreferencesToConsistentValues):
433         (WTR::updateTestOptionsFromTestHeader):
434         * WebKitTestRunner/TestOptions.h:
435         (WTR::TestOptions::hasSameInitializationOptions const):
436
437 2019-05-14  Commit Queue  <commit-queue@webkit.org>
438
439         Unreviewed, rolling out r245281.
440         https://bugs.webkit.org/show_bug.cgi?id=197887
441
442         Broke API Test TestWebKitAPI.Challenge.ClientCertificate
443         (Requested by aakashjain on #webkit).
444
445         Reverted changeset:
446
447         "Add a unit test for client certificate authentication"
448         https://bugs.webkit.org/show_bug.cgi?id=197800
449         https://trac.webkit.org/changeset/245281
450
451 2019-05-14  Youenn Fablet  <youenn@apple.com>
452
453         Add support for webkit-test-runner options to WPT importer
454         https://bugs.webkit.org/show_bug.cgi?id=197826
455
456         Reviewed by Alex Christensen.
457
458         In case of overwriting an existing test, check if the existing test
459         contains a <!-- webkit-test-runner --> comment and insert it back if
460         needed in the new test.
461
462         For exporter, forbid creating a WPT PR if there are changes containing
463         the webkit-test-runner string.
464
465         * Scripts/webkitpy/w3c/test_converter.py:
466         (convert_for_webkit):
467         (_W3CTestConverter.__init__):
468         (_W3CTestConverter.add_webkit_test_runner_options_if_needed):
469         (_W3CTestConverter.handle_starttag):
470         (_W3CTestConverter.handle_comment):
471         (_W3CTestConverter.handle_decl):
472         (_W3CTestConverter.handle_pi):
473         * Scripts/webkitpy/w3c/test_exporter.py:
474         (WebPlatformTestExporter.write_git_patch_file):
475         (WebPlatformTestExporter.make_pull_request):
476         * Scripts/webkitpy/w3c/test_importer.py:
477         (TestImporter.webkit_test_runner_options):
478         (TestImporter):
479         (TestImporter.add_webkit_test_runner_options_to_content):
480         (TestImporter.copy_html_file):
481         (TestImporter.write_html_template):
482         (TestImporter.write_html_files_for_templated_js_tests):
483         (TestImporter.import_tests):
484         * Scripts/webkitpy/w3c/test_importer_unittest.py:
485         (test_manual_slow_test):
486         (test_webkit_test_runner_options):
487
488 2019-05-14  Aakash Jain  <aakash_jain@apple.com>
489
490         [ews-app] Status bubble should turn orange when any build step fails
491         https://bugs.webkit.org/show_bug.cgi?id=197812
492
493         Reviewed by Jonathan Bedard.
494
495         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
496         (StatusBubble._build_bubble): Turn status-bubble orange if there is any failed step in the on-going build.
497         (StatusBubble._does_build_contains_any_failed_step): Method to check if build contains any failed step.
498
499 2019-05-14  Alex Christensen  <achristensen@webkit.org>
500
501         Add a unit test for client certificate authentication
502         https://bugs.webkit.org/show_bug.cgi?id=197800
503
504         Reviewed by Youenn Fablet.
505
506         Make better abstractions for reading and writing from/to TCPServer.
507         Add a unit test that causes a client certificate authentication challenge to happen.
508
509         * TestWebKitAPI/TCPServer.cpp:
510         (TestWebKitAPI::TCPServer::TCPServer):
511         (TestWebKitAPI::TCPServer::read):
512         (TestWebKitAPI::TCPServer::write):
513         (TestWebKitAPI::TCPServer::respondWithChallengeThenOK):
514         (TestWebKitAPI::TCPServer::respondWithOK):
515         * TestWebKitAPI/TCPServer.h:
516         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
517         (credentialWithIdentity):
518         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
519         (TEST):
520         (-[ClientCertificateDelegate webView:didFinishNavigation:]):
521         (-[ClientCertificateDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
522         (-[ClientCertificateDelegate challengeCount]):
523         (TestWebKitAPI::TEST):
524         (respondWithChallengeThenOK): Deleted.
525         (credentialWithIdentityAndKeychainPath): Deleted.
526         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
527         (TEST):
528         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
529         (TestWebKitAPI::TEST):
530         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
531         (TEST):
532         (readRequest): Deleted.
533         (writeResponse): Deleted.
534         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
535         (TestWebKitAPI::TEST):
536         (TestWebKitAPI::respondWithChallengeThenOK): Deleted.
537
538 2019-05-14  Said Abou-Hallawa  <sabouhallawa@apple.com>
539
540         [CG] Adding support for HEIF-sequence ('public.heics') images
541         https://bugs.webkit.org/show_bug.cgi?id=197384
542
543         Reviewed by Simon Fraser.
544
545         * DumpRenderTree/TestOptions.cpp:
546         (TestOptions::TestOptions):
547         * DumpRenderTree/TestOptions.h:
548         * DumpRenderTree/mac/DumpRenderTree.mm:
549         (resetWebViewToConsistentStateBeforeTesting):
550         Parse the new webkit-test-runner paramter: additionalSupportedImageTypes.
551         Make DRT call setAdditionalSupportedImageTypesForTesting() before starting
552         the test.
553
554         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
555         (WTR::InjectedBundle::stringForKey):
556         (WTR::InjectedBundle::beginTesting):
557         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
558         * WebKitTestRunner/TestController.cpp:
559         (WTR::TestController::resetStateToConsistentValues):
560         (WTR::updateTestOptionsFromTestHeader):
561         * WebKitTestRunner/TestInvocation.cpp:
562         (WTR::TestInvocation::createTestSettingsDictionary):
563         * WebKitTestRunner/TestOptions.h:
564         (WTR::TestOptions::hasSameInitializationOptions const):
565         Parse the new webkit-test-runner paramter: additionalSupportedImageTypes.
566         Make WTR call setAdditionalSupportedImageTypesForTesting() before starting
567         the test.
568
569 2019-05-12  Yusuke Suzuki  <ysuzuki@apple.com>
570
571         [JSC] Compress Watchpoint size by using enum type and Packed<> data structure
572         https://bugs.webkit.org/show_bug.cgi?id=197730
573
574         Reviewed by Filip Pizlo.
575
576         * TestWebKitAPI/CMakeLists.txt:
577         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
578         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
579         (TestWebKitAPI::TEST):
580         * TestWebKitAPI/Tests/WTF/Packed.cpp: Added.
581         (TestWebKitAPI::TEST):
582
583 2019-05-10  Chris Dumez  <cdumez@apple.com>
584
585         Unreviewed, fix ProcessSwap.OpenerLinkAfterAPIControlledProcessSwappingOfOpener API test
586
587         It became flaky after r245198.
588
589         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
590
591 2019-05-10  Youenn Fablet  <youenn@apple.com>
592
593         A service worker instance should be terminated when its SWServer is destroyed
594         https://bugs.webkit.org/show_bug.cgi?id=197801
595         <rdar://problem/50587270>
596
597         Reviewed by Chris Dumez.
598
599         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
600
601 2019-05-10  Chris Dumez  <cdumez@apple.com>
602
603         Do not wait until requestPermission() is called to fire deviceorientation events if permission was already granted
604         https://bugs.webkit.org/show_bug.cgi?id=197750
605
606         Reviewed by Geoffrey Garen.
607
608         Add API test coverage.
609
610         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
611         (TEST):
612
613 2019-05-10  Keith Miller  <keith_miller@apple.com>
614
615         Remove legacy test262 import script
616         https://bugs.webkit.org/show_bug.cgi?id=197788
617
618         Reviewed by Yusuke Suzuki.
619
620         import-test262-tests doesn't work anymore. We should be using test262-import instead.
621
622         * Scripts/import-test262-tests: Removed.
623
624 2019-05-10  Charlie Turner  <cturner@igalia.com>
625
626         [WPE] Forward libepoxy cflags
627         https://bugs.webkit.org/show_bug.cgi?id=197784
628
629         Reviewed by Žan Doberšek.
630
631         Patch by Zan Dobersek.
632
633         * wpe/backends/CMakeLists.txt: This is required to keep
634         -DMESA_EGL_NO_X11_HEADERS in the build, if we don't do this, EGL ends
635         up trying to include X11 headers even when they're not present in the
636         environment.
637
638 2019-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
639
640         Fix a bunch of compiler warnings
641         https://bugs.webkit.org/show_bug.cgi?id=197785
642
643         Reviewed by Don Olmstead.
644
645         Add preprocessor guards to avoid -Wunused-function warnings.
646
647         * TestWebKitAPI/Tests/WebCore/FloatRect.cpp:
648         * TestWebKitAPI/Tests/WebCore/IntRect.cpp:
649         * TestWebKitAPI/Tests/WebCore/TransformationMatrix.cpp:
650
651 2019-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
652
653         [WPE][GTK] Add webkit_frame_get_id() API
654         https://bugs.webkit.org/show_bug.cgi?id=197270
655
656         Reviewed by Carlos Garcia Campos.
657
658         This was hard, but I added a test to verify that two different WebKitFrames of the same
659         WebKitWebPage return two different frame IDs.
660
661         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
662         (WebKitFrameTest::willSubmitFormCallback):
663         (WebKitFrameTest::testSubframe):
664         (registerTests):
665         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
666         (testWebKitFrameSubframe):
667         (beforeAll):
668         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
669         (willSubmitFormCallback):
670         * TestWebKitAPI/Tests/WebKitGLib/resources/form-in-frame.html: Added.
671         * TestWebKitAPI/Tests/WebKitGLib/resources/webkitglib-tests.gresource.xml:
672
673 2019-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
674
675         [WPE][GTK] Add WebKitWebPage::did-associate-form-controls-for-frame and deprecate original did-associate-form-controls
676         https://bugs.webkit.org/show_bug.cgi?id=197271
677
678         Reviewed by Youenn Fablet.
679
680         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
681         (formControlsAssociatedForFrameCallback):
682         (pageCreatedCallback):
683         (formControlsAssociatedCallback): Deleted.
684
685 2019-05-10  Adrian Perez de Castro  <aperez@igalia.com>
686
687         [Flatpak] Use the safe PyYAML loader if available
688         https://bugs.webkit.org/show_bug.cgi?id=197771
689
690         Reviewed by Philippe Normand.
691
692         * flatpak/flatpakutils.py:
693         (load_manifest): Use yaml.safe_load() if available, with yaml.load()
694         still used as fallback when the former is not provided by the module.
695
696 2019-05-09  Fujii Hironori  <Hironori.Fujii@sony.com>
697
698         WinCairo WebKitTestRunner should take platform/wk2/TestExpectations into account
699         https://bugs.webkit.org/show_bug.cgi?id=197734
700
701         Reviewed by Don Olmstead.
702
703         * Scripts/webkitpy/port/win.py:
704         (WinCairoPort._search_paths): Add 'wk2' and
705         additional_platform_directory to paths as well as other ports do.
706
707 2019-05-09  Daniel Bates  <dabates@apple.com>
708
709         [iOS] Numpad comma key has incorrect keyIdentifier property
710         https://bugs.webkit.org/show_bug.cgi?id=197753
711         <rdar://problem/50636274>
712
713         Reviewed by Brent Fulgham.
714
715         Recognize "numpadComma" and return the appropriate HID usage code.
716
717         * WebKitTestRunner/ios/HIDEventGenerator.mm:
718         (hidUsageCodeForCharacter):
719
720 2019-05-09  Eric Carlson  <eric.carlson@apple.com>
721
722         Refine AudioSession route sharing policy
723         https://bugs.webkit.org/show_bug.cgi?id=197742
724         <rdar://problem/50590818>
725
726         Reviewed by Darin Adler.
727
728         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
729         (TestWebKitAPI::TEST):
730
731 2019-05-09  Alex Christensen  <achristensen@webkit.org>
732
733         Remove unnecessary test SPI after r244883
734         https://bugs.webkit.org/show_bug.cgi?id=197575
735
736         Reviewed by Tim Horton.
737
738         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
739         (TEST):
740         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
741         (TestWebKitAPI::TEST):
742
743 2019-05-09  Aakash Jain  <aakash_jain@apple.com>
744
745         [ews-app] Add migrations file to repository
746         https://bugs.webkit.org/show_bug.cgi?id=197729
747
748         Reviewed by Jonathan Bedard.
749
750         * BuildSlaveSupport/ews-app/ews/migrations/0001_initial.py: Added. Auto-generated by Django based on models' information.
751
752 2019-05-09  Aakash Jain  <aakash_jain@apple.com>
753
754         [ews-build] Fix formatting issues and typos
755         https://bugs.webkit.org/show_bug.cgi?id=197737
756
757         Reviewed by Jonathan Bedard.
758
759         * BuildSlaveSupport/ews-build/steps.py:
760         (CompileWebKit.evaluateCommand): Removed extra empty line.
761         * BuildSlaveSupport/ews-build/steps_unittest.py:
762         (TestRunWebKitPerlTests): Fixed typo.
763         * BuildSlaveSupport/ews-app/ews/models/step.py:
764         (Step.save_step): Changed log level to info so that it is logged in production.
765
766 2019-05-09  Aakash Jain  <aakash_jain@apple.com>
767
768         [ews-app] Production and Development env should configure DEBUG appropriately
769         https://bugs.webkit.org/show_bug.cgi?id=197700
770
771         Reviewed by Jonathan Bedard.
772
773         * BuildSlaveSupport/ews-app/ews-app/settings.py:
774
775 2019-05-09  Xan López  <xan@igalia.com>
776
777         [CMake] Detect SSE2 at compile time
778         https://bugs.webkit.org/show_bug.cgi?id=196488
779
780         Reviewed by Carlos Garcia Campos.
781
782         * Scripts/webkitdirs.pm:
783         (generateBuildSystemFromCMakeProject): Do not add SSE2 flags here
784         for x86 builds. This is now handled in WebKitCompilerFlags.cmake.
785
786 2019-05-08  Adrian Perez de Castro  <aperez@igalia.com>
787
788         [WPE] Update dependencies to use libwpe + WPEBackend-fdo 1.3.0
789         https://bugs.webkit.org/show_bug.cgi?id=197697
790
791         Reviewed by Žan Doberšek.
792
793         * flatpak/org.webkit.WPEModules.yaml: Bump version and update checksums.
794         * wpe/jhbuild.modules: Ditto.
795
796 2019-05-08  Don Olmstead  <don.olmstead@sony.com>
797
798         Update ANGLE
799         https://bugs.webkit.org/show_bug.cgi?id=197676
800
801         Reviewed by Alex Christensen.
802
803         * TestWebKitAPI/PlatformWin.cmake:
804         Remove unnecessary library linkage.
805
806 2019-05-08  Stephan Szabo  <stephan.szabo@sony.com> and Fujii Hironori  <Hironori.Fujii@sony.com>
807
808         [Win] build-webkit should be ready for Visual Studio 2019
809         https://bugs.webkit.org/show_bug.cgi?id=196622
810
811         Reviewed by Ross Kirsling.
812
813         1. Accommodated to the new msbuild.exe location of VS 2019.
814         2. Removed the hard coded "Visual Studio 15" generator.
815
816         build-webkit is going to choose a Visual Studio generator version
817         matching with the latest installed VS. If you invoke vcvars.bat
818         before build-webkit, it chooses the corresponding Visual Studio
819         generator version by cheking 'VisualStudioVersion' env var which
820         is set by vcvars.bat.
821
822         * Scripts/webkitdirs.pm: Renamed $vcBuildPath to $msBuildPath. Removed $msBuildInstallDir.
823         (msBuildPath): When looking for MSBuild, look in
824         "MSBuild\Current\bin" (the new expected location) and fallback
825         to "MSBuild\15.0\bin" if we can't find an MSBuild.exe in the
826         first location.
827         (msBuildInstallDir): Renamed to msBuildPath.
828         (generateBuildSystemFromCMakeProject): Use -A switch to specify x64.
829         Add -G "Visual Studio " switch if a env var 'VisualStudioVersion'
830
831 2019-05-08  Don Olmstead  <don.olmstead@sony.com>
832
833         [PlayStation] Update port options
834         https://bugs.webkit.org/show_bug.cgi?id=197723
835
836         Reviewed by Ross Kirsling.
837
838         ICU headers were missing from TestWTF.
839
840         * TestWebKitAPI/PlatformPlayStation.cmake:
841
842 2019-05-08  Alex Christensen  <achristensen@webkit.org>
843
844         Don't crash when DOMNode.addEventListener:listener:useCapture: is called with a nil listener
845         https://bugs.webkit.org/show_bug.cgi?id=197712
846         <rdar://problem/50429770>
847
848         Reviewed by Tim Horton.
849
850         * TestWebKitAPI/Tests/WebKitLegacy/mac/DeallocWebViewInEventListener.mm:
851         (TestWebKitAPI::TEST):
852
853 2019-05-08  Jonathan Bedard  <jbedard@apple.com>
854
855         Change my status to be a WebKit reviewer.
856
857         * Scripts/webkitpy/common/config/contributors.json:
858
859 2019-05-08  Ryan Haddad  <ryanhaddad@apple.com>
860
861         Unreviewed, rolling out r244952.
862
863         Caused inspector to appear blank.
864
865         Reverted changeset:
866
867         "Web Inspector: Provide UIString descriptions to improve
868         localizations"
869         https://bugs.webkit.org/show_bug.cgi?id=195132
870         https://trac.webkit.org/changeset/244952
871
872 2019-05-08  Wenson Hsieh  <wenson_hsieh@apple.com>
873
874         TestRunnerWKWebView's menu callbacks should be cleared upon UI script completion
875         https://bugs.webkit.org/show_bug.cgi?id=197685
876
877         Reviewed by Alex Christensen.
878
879         Fixes a bug in the test runner wherein didShowMenuCallback and didHideMenuCallback are not reset upon UI script
880         completion. See LayoutTests/ChangeLog for more details.
881
882         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
883         (WTR::UIScriptController::platformClearAllCallbacks):
884
885 2019-05-07  Oriol Brufau  <obrufau@igalia.com>
886
887         Unreviewed. Add myself as a committer.
888
889         * Scripts/webkitpy/common/config/contributors.json:
890
891 2019-05-07  Ryan Haddad  <ryanhaddad@apple.com>
892
893         Unreviewed, rolling out r245038.
894
895         Breaks internal builds.
896
897         Reverted changeset:
898
899         "Add SPI to set a list of hosts to which to send custom header
900         fields cross-origin"
901         https://bugs.webkit.org/show_bug.cgi?id=197397
902         https://trac.webkit.org/changeset/245038
903
904 2019-05-07  Joonghun Park  <pjh0718@gmail.com>
905
906         Unreviewed. Add myself as a committer.
907
908         * Scripts/webkitpy/common/config/contributors.json:
909
910 2019-05-07  Eric Carlson  <eric.carlson@apple.com>
911
912         Define media buffering policy
913         https://bugs.webkit.org/show_bug.cgi?id=196979
914         <rdar://problem/28383861>
915
916         Reviewed by Jer Noble.
917
918         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
919         * TestWebKitAPI/Tests/WebKitCocoa/MediaBufferingPolicy.mm: Added.
920         (waitUntilBufferingPolicyIsEqualTo):
921         (TEST):
922
923 2019-05-07  Alex Christensen  <achristensen@webkit.org>
924
925         Add SPI to set a list of hosts to which to send custom header fields cross-origin
926         https://bugs.webkit.org/show_bug.cgi?id=197397
927
928         Reviewed by Geoff Garen.
929
930         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
931         (TEST):
932         (expectLegacyHeaders):
933         (expectHeaders):
934         (-[CustomHeaderFieldsDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
935         (-[CustomHeaderFieldsDelegate webView:startURLSchemeTask:]):
936         (-[CustomHeaderFieldsDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
937
938 2019-05-07  Keith Rollin  <krollin@apple.com>
939
940         Add option to build-webkit to control whether or not XCBuild is used
941         https://bugs.webkit.org/show_bug.cgi?id=197668
942         <rdar://problem/50549728>
943
944         Reviewed by Tim Horton.
945
946         Add --[no-]xcbuild to build-webkit to force the use of XCBuild or not.
947         Also update build-webkit and the makefiles with the foundation for
948         automatically using XCBuild when the conditions allow it. This latter
949         facility is currently turned off until Xcode fully supports building
950         WebKit with XCBuild.
951
952         * Scripts/build-webkit:
953         * Scripts/webkitdirs.pm:
954         (XcodeOptions):
955         (canUseXCBuild):
956
957 2019-05-07  Andy Estes  <aestes@apple.com>
958
959         run-bindings-tests should test global scope constructor generation
960         https://bugs.webkit.org/show_bug.cgi?id=197669
961
962         Reviewed by Alex Christensen.
963
964         * Scripts/webkitpy/bindings/main.py:
965         Updated to specify --testGlobalContextName and --testGlobalScopeConstructorsFile when
966         invoking preprocess-idls.pl.
967
968 2019-05-07  Youenn Fablet  <youenn@apple.com>
969
970         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageDefaultDirectories
971         https://bugs.webkit.org/show_bug.cgi?id=195997
972         <rdar://problem/50509884>
973
974         Reviewed by Chris Dumez.
975
976         Spin test until successful.
977
978         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
979
980 2019-05-07  Adrian Perez de Castro  <aperez@igalia.com>
981
982         [Flatpak] webkit-build fails due to missing GTK2 in build environment
983         https://bugs.webkit.org/show_bug.cgi?id=197352
984
985         Reviewed by Philippe Normand.
986
987         The Flatpak runtimes do not include GTK 2.x anymore, which means that we need
988         to build it ourselves on top in order to be able to build the GTK 2.x plugin
989         process.
990
991         * flatpak/org.webkit.GTK.yaml: Add gtk2 package.
992
993 2019-05-07  Wenson Hsieh  <wenson_hsieh@apple.com>
994
995         [macOS] Avoid crashing the UI process when writing empty data to the pasteboard
996         https://bugs.webkit.org/show_bug.cgi?id=197644
997         <rdar://problem/50526364>
998
999         Reviewed by Tim Horton.
1000
1001         Add a new API test to exercise a possible scenario where we may crash while writing data to the pasteboard.
1002
1003         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegate.mm:
1004         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
1005         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1006         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:pasteboardDataForRange:]):
1007
1008 2019-05-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1009
1010         [GTK][WPE] MiniBrowser: load about:blank for new web views in automation mode
1011         https://bugs.webkit.org/show_bug.cgi?id=197651
1012
1013         Reviewed by Žan Doberšek.
1014
1015         This is required since the process creation was delayed until something is loaded in the view.
1016
1017         * MiniBrowser/gtk/BrowserWindow.c:
1018         (browser_window_get_or_create_web_view_for_automation):
1019         * MiniBrowser/wpe/main.cpp:
1020         (main):
1021
1022 2019-05-06  Tim Horton  <timothy_horton@apple.com>
1023
1024         _overrideViewportWithArguments does not work when called before loading
1025         https://bugs.webkit.org/show_bug.cgi?id=197638
1026         <rdar://problem/50505111>
1027
1028         Reviewed by Wenson Hsieh.
1029
1030         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:
1031         (TEST):
1032
1033 2019-05-04  Per Arne Vollan  <pvollan@apple.com>
1034
1035         -[WKWebsiteDataStore removeDataOfTypes:forDataRecords:completionHandler:] doesn't delete _WKWebsiteDataTypeCredentials
1036         https://bugs.webkit.org/show_bug.cgi?id=197510
1037
1038         Reviewed by Alex Christensen.
1039
1040         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
1041         (TestWebKitAPI::TEST):
1042
1043 2019-05-06  Keith Rollin  <krollin@apple.com>
1044
1045         Temporarily disable generate-xcfilelists
1046         https://bugs.webkit.org/show_bug.cgi?id=197619
1047         <rdar://problem/50507392>
1048
1049         Reviewed by Alex Christensen.
1050
1051         We need to perform a significant update to the generate-xcfilelist
1052         scripts. This work involves coordinated work with another facility. If
1053         the work does not occur in tandem, the build will be broken. To avoid
1054         this, disable the invoking of the scripts during the transition. The
1055         checking will be restored once the new scripts are in place.
1056
1057         * DumpRenderTree/Scripts/check-xcfilelists.sh:
1058         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
1059
1060 2019-05-04  Alex Christensen  <achristensen@webkit.org>
1061
1062         Revert r244953 and r244954 because they broke internal builds.
1063         https://bugs.webkit.org/show_bug.cgi?id=197534
1064
1065         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
1066         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
1067         * DumpRenderTree/mac/DumpRenderTree.mm:
1068         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1069         * DumpRenderTree/mac/TestRunnerMac.mm:
1070         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1071         * TestWebKitAPI/Tests/WebKitCocoa/CopyURL.mm:
1072         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1073         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
1074         * TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm:
1075         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
1076         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewFindString.mm:
1077         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1078         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
1079         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
1080         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1081         * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
1082         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1083         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1084         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
1085         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1086         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1087         * TestWebKitAPI/ios/UIKitSPI.h: Added.
1088         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1089         * WebKitTestRunner/ios/GeneratedTouchesDebugWindow.mm:
1090         * WebKitTestRunner/ios/HIDEventGenerator.h:
1091         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1092         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1093         * WebKitTestRunner/ios/TestControllerIOS.mm:
1094         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1095         * WebKitTestRunner/ios/mainIOS.mm:
1096
1097 2019-05-04  Alex Christensen  <achristensen@webkit.org>
1098
1099         Merge the three UIKitSPI.h files into a single one in PAL
1100         https://bugs.webkit.org/show_bug.cgi?id=197534
1101
1102         Reviewed by Darin Adler.
1103
1104         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
1105         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
1106         * DumpRenderTree/mac/DumpRenderTree.mm:
1107         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1108         * DumpRenderTree/mac/TestRunnerMac.mm:
1109         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1110         * TestWebKitAPI/Tests/WebKitCocoa/CopyURL.mm:
1111         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1112         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
1113         * TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm:
1114         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
1115         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewFindString.mm:
1116         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1117         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
1118         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
1119         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1120         * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
1121         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1122         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1123         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
1124         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1125         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1126         * TestWebKitAPI/ios/UIKitSPI.h: Removed.
1127         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1128         * WebKitTestRunner/ios/GeneratedTouchesDebugWindow.mm:
1129         * WebKitTestRunner/ios/HIDEventGenerator.h:
1130         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1131         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1132         * WebKitTestRunner/ios/TestControllerIOS.mm:
1133         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1134         * WebKitTestRunner/ios/mainIOS.mm:
1135
1136 2019-05-04  Nikita Vasilyev  <nvasilyev@apple.com>
1137
1138         Web Inspector: Provide UIString descriptions to improve localizations
1139         https://bugs.webkit.org/show_bug.cgi?id=195132
1140         <rdar://problem/48457817>
1141
1142         Reviewed by Devin Rousso.
1143
1144         Allow WI.UIString to take:
1145         - WI.UIString(string, key, comment)
1146         - WI.UIString(string, comment)
1147         - WI.UIString(string)
1148
1149         * Scripts/extract-localizable-js-strings:
1150
1151 2019-05-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1152
1153         REGRESSION (r244897): Caret may appear wider than normal after zooming to focus an editable element
1154         https://bugs.webkit.org/show_bug.cgi?id=197579
1155
1156         Reviewed by Tim Horton.
1157
1158         Fixes a couple of flaky layout tests (ModifyInputAssistantItemBarButtonGroups and
1159         OverrideInputAssistantItemBarButtonGroups) by programmatically blurring focused elements and waiting for the
1160         input session to change, rather than relying on -resignFirstResponder and -waitForNextPresentationUpdate to
1161         ensure that the the focused element has been blurred.
1162
1163         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1164
1165 2019-05-02  Alexey Proskuryakov  <ap@apple.com>
1166
1167         Add a tool to block spammer accounts
1168         https://bugs.webkit.org/show_bug.cgi?id=197537
1169
1170         Reviewed by Darin Adler.
1171
1172         Usage: block-spammers email1 email2 ...
1173
1174         The tool finds and hides all bugs and comments from this account. Before any work
1175         is done, these bugs and comments are displayed for confirmation.
1176
1177         * Scripts/block-spammers: Added.
1178         (get_bugzilla_token):
1179         (invalidate_bugzilla_token):
1180         (get_user_info):
1181         (get_user_info_self):
1182         (can_use_this_tool):
1183         (disable_user):
1184         (get_bugs_created_by_user):
1185         (get_bugs_commented_on_by_user):
1186         (get_comments):
1187         (hide_bug):
1188         (hide_comments):
1189         (ask_yes_no):
1190         (sanitized_string):
1191         (main):
1192
1193 2019-05-03  Jonathan Bedard  <jbedard@apple.com>
1194
1195         run-apit-tests: Add --iterations and --repeat-each
1196         https://bugs.webkit.org/show_bug.cgi?id=197563
1197
1198         Reviewed by Aakash Jain.
1199
1200         * Scripts/webkitpy/api_tests/manager.py:
1201         (Manager.run): Add --iterations and --repeat-each/
1202         * Scripts/webkitpy/api_tests/run_api_tests.py:
1203         (parse_args): Duplicate the test list based on --iterations and --repeat-each.
1204
1205 2019-05-03  Aakash Jain  <aakash_jain@apple.com>
1206
1207         New EWS: Clicking on white bubble navigates to page with only bubbles
1208         https://bugs.webkit.org/show_bug.cgi?id=197520
1209
1210         Reviewed by Lucas Forschler.
1211
1212         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Disable clicking if bubble doesn't have any url.
1213
1214 2019-05-03  Daniel Bates  <dabates@apple.com>
1215
1216         [lldb-webkit] Support adding pretty-printing for qualified types
1217         https://bugs.webkit.org/show_bug.cgi?id=197518
1218
1219         Reviewed by Darin Adler.
1220
1221         Remove all "::"s from the name of the specified type when computing the name for the Python classes
1222         that will provide summary and synthetic details as LLDB is not happy about registering such classes
1223         when they contain :: in their name.
1224
1225         * lldb/lldb_webkit.py:
1226         (addSummaryAndSyntheticFormattersForRawBitmaskType):
1227
1228 2019-05-03  Aakash Jain  <aakash_jain@apple.com>
1229
1230         New EWS: patches on recently added queues listed as #1 for older bugs
1231         https://bugs.webkit.org/show_bug.cgi?id=197496
1232
1233         Reviewed by Lucas Forschler.
1234
1235         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1236         (StatusBubble._build_bubble):
1237         (StatusBubble._queue_position):
1238
1239 2019-05-03  Aakash Jain  <aakash_jain@apple.com>
1240
1241         webkit-patch --no-review upload does not submit patch to New EWS
1242         https://bugs.webkit.org/show_bug.cgi?id=197519
1243         <rdar://problem/50424887>
1244
1245         Reviewed by Lucas Forschler.
1246
1247         * Scripts/webkitpy/tool/steps/submittoews.py:
1248         (SubmitToEWS.run): Submit to both old and new EWS.
1249         * Scripts/webkitpy/common/config/urls.py: Added url for new EWS server.
1250         * Scripts/webkitpy/common/net/ewsserver.py: Added.
1251         (EWSServer._server_url): Method to return server url.
1252         (EWSServer._post_patch_to_ews): Method to post patch to ews.
1253         (EWSServer.submit_to_ews): Method to submit the patch to ews using NetworkTransaction.
1254         * Scripts/webkitpy/common/net/ewsserver_mock.py: Added Mock EWS Server.
1255         * Scripts/webkitpy/common/net/ewsserver_unittest.py: Added unit-test for EWS Server.
1256         * Scripts/webkitpy/common/net/statusserver_mock.py:
1257         (MockStatusServer.submit_to_ews): Updated the log text.
1258         * Scripts/webkitpy/tool/commands/queues_unittest.py: Updated unit-tests.
1259         * Scripts/webkitpy/tool/commands/upload_unittest.py: Ditto.
1260         * Scripts/webkitpy/tool/main.py:
1261         (WebKitPatch.__init__): Initialize ews_server. 
1262         * Scripts/webkitpy/tool/mocktool.py:
1263         (MockTool.__init__): Ditto.
1264
1265 2019-05-03  Chris Dumez  <cdumez@apple.com>
1266
1267         ASSERTION FAILED: [weakThis->m_view window] == weakThis->m_targetWindowForMovePreparation
1268         https://bugs.webkit.org/show_bug.cgi?id=197574
1269         <rdar://problem/50453181>
1270
1271         Reviewed by Tim Horton.
1272
1273         Add API test coverage.
1274
1275         * TestWebKitAPI/Tests/WebKitCocoa/PrepareForMoveToWindow.mm:
1276         (TEST):
1277
1278 2019-05-03  Yusuke Suzuki  <ysuzuki@apple.com>
1279
1280         [JSC] Generator CodeBlock generation should be idempotent
1281         https://bugs.webkit.org/show_bug.cgi?id=197552
1282
1283         Reviewed by Keith Miller.
1284
1285         * Scripts/run-javascriptcore-tests:
1286         (runJSCStressTests):
1287         * Scripts/run-jsc-stress-tests:
1288
1289 2019-05-03  Commit Queue  <commit-queue@webkit.org>
1290
1291         Unreviewed, rolling out r244881.
1292         https://bugs.webkit.org/show_bug.cgi?id=197559
1293
1294         Breaks compilation of jsconly on linux, breaking compilation
1295         for jsc-i386-ews, jsc-mips-ews and jsc-armv7-ews (Requested by
1296         guijemont on #webkit).
1297
1298         Reverted changeset:
1299
1300         "[CMake] Refactor WEBKIT_MAKE_FORWARDING_HEADERS into
1301         WEBKIT_COPY_FILES"
1302         https://bugs.webkit.org/show_bug.cgi?id=197174
1303         https://trac.webkit.org/changeset/244881
1304
1305 2019-05-03  Zan Dobersek  <zdobersek@igalia.com>
1306
1307         Unreviewed WPE build fix after r244898.
1308
1309         * WebKitTestRunner/wpe/TestControllerWPE.cpp:
1310         (WTR::TestController::abortModal): Add the missing (no-op) definition.
1311
1312 2019-05-02  Alex Christensen  <achristensen@webkit.org>
1313
1314         Mark U+01C0 as a homograph of U+006C
1315         https://bugs.webkit.org/show_bug.cgi?id=197526
1316         <rdar://problem/50301904>
1317
1318         Reviewed by Tim Horton.
1319
1320         * TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
1321         (TestWebKitAPI::TEST):
1322
1323 2019-05-02  Chris Dumez  <cdumez@apple.com>
1324
1325         Add test coverage for <rdar://problem/49731231>
1326         https://bugs.webkit.org/show_bug.cgi?id=196730
1327         <rdar://problem/49731231>
1328
1329         Reviewed by Ryosuke Niwa.
1330
1331         Add support for testRunner.abortModal() in macOS's WebKitTestRunner in order
1332         to match DumpRenderTree.
1333
1334         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1335         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1336         (WTR::TestRunner::abortModal):
1337         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1338         * WebKitTestRunner/TestController.cpp:
1339         (WTR::TestController::runModal):
1340         * WebKitTestRunner/TestController.h:
1341         * WebKitTestRunner/TestInvocation.cpp:
1342         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1343         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1344         (WTR::TestController::abortModal):
1345         * WebKitTestRunner/ios/TestControllerIOS.mm:
1346         (WTR::TestController::abortModal):
1347         * WebKitTestRunner/mac/TestControllerMac.mm:
1348         (WTR::TestController::abortModal):
1349         * WebKitTestRunner/win/TestControllerWin.cpp:
1350         (WTR::TestController::abortModal):
1351
1352 2019-05-02  Christopher Reid  <chris.reid@sony.com>
1353
1354         [CMake] Add support for LTO builds
1355         https://bugs.webkit.org/show_bug.cgi?id=188986
1356
1357         Reviewed by Don Olmstead.
1358
1359         Add support to configure --lto-mode with cmake builds.
1360
1361         * Scripts/build-webkit:
1362         * Scripts/webkitdirs.pm:
1363         (generateBuildSystemFromCMakeProject):
1364
1365 2019-05-02  John Wilander  <wilander@apple.com>
1366
1367         Make both filterForRegistrableDomains() in WebKit::NetworkProcess use WebCore::RegistrableDomain::uncheckedCreateFromHost()
1368         https://bugs.webkit.org/show_bug.cgi?id=197521
1369         <rdar://problem/49651503>
1370
1371         Reviewed by Brent Fulgham.
1372
1373         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
1374         (TestWebKitAPI::TEST):
1375            Added a test for host strings with leading dots since they are
1376            often used for the domain attribute in cookies.
1377
1378 2019-05-02  Per Arne Vollan  <pvollan@apple.com>
1379
1380         -[WKWebsiteDataStore removeDataOfTypes:forDataRecords:completionHandler:] doesn't delete _WKWebsiteDataTypeCredentials
1381         https://bugs.webkit.org/show_bug.cgi?id=197510
1382
1383         Reviewed by Alex Christensen.
1384
1385         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
1386         (TestWebKitAPI::TEST):
1387
1388 2019-05-02  Don Olmstead  <don.olmstead@sony.com>
1389
1390         [CMake] Refactor WEBKIT_MAKE_FORWARDING_HEADERS into WEBKIT_COPY_FILES
1391         https://bugs.webkit.org/show_bug.cgi?id=197174
1392
1393         Reviewed by Alex Christensen.
1394
1395         Make TestJSC dependent on JavaScriptCorePrivateFrameworkHeaders.
1396
1397         * TestWebKitAPI/PlatformGTK.cmake:
1398         * TestWebKitAPI/PlatformWPE.cmake:
1399
1400 2019-05-02  Alex Christensen  <achristensen@webkit.org>
1401
1402         Build fix for internal branch.
1403
1404         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1405         RetainPtr.h was not explicitly included.
1406
1407 2019-05-02  Jonathan Bedard  <jbedard@apple.com>
1408
1409         webkitpy: Ignore errors when shutting down an already shutdown simulator
1410         <https://bugs.webkit.org/show_bug.cgi?id=197514>
1411         <rdar://problem/50390247>
1412
1413         Reviewed by Lucas Forschler.
1414
1415         * Scripts/webkitpy/xcode/simulated_device.py:
1416         (SimulatedDevice._shut_down):
1417
1418 2019-05-02  Frederic Wang  <fwang@igalia.com>
1419
1420         [GTK][WPE] Disable "thin", "thick", "medium" values of mfrac@linethickness at runtime
1421         https://bugs.webkit.org/show_bug.cgi?id=196142
1422
1423         This patch introduces some experimental runtime flag to let users
1424         disable MathML features that are removed from MathML Core [1]. For now,
1425         these features are only disabled on GTK and WPE ports.
1426
1427         [1] https://mathml-refresh.github.io/mathml-core/
1428
1429         Reviewed by Rob Buis.
1430
1431         * DumpRenderTree/TestOptions.cpp:
1432         (TestOptions::TestOptions):
1433         * DumpRenderTree/TestOptions.h:
1434         * DumpRenderTree/mac/DumpRenderTree.mm:
1435         (setWebPreferencesForTestOptions):
1436
1437 2019-05-01  Don Olmstead  <don.olmstead@sony.com>
1438
1439         TestWebKitAPI config.h should be aware of what suite is being built
1440         https://bugs.webkit.org/show_bug.cgi?id=196583
1441
1442         Reviewed by Konstantin Tokarev.
1443
1444         Migrate to WEBKIT_EXECUTABLE to define the Test* executables. As an added
1445         benefit the macro defines BUILDING_* for the executable which allows the includes
1446         of the config.h to be tailored to the test suite being built. Because of that the
1447         dependencies of the Test* executable are specific to the test suite which may
1448         speed up the build.
1449
1450         Some source files were including "PlatformUtilities.h" which includes WebKit headers
1451         when "Utilities.h" is what was needed.
1452
1453         * TestWebKitAPI/CMakeLists.txt:
1454         * TestWebKitAPI/PlatformGTK.cmake:
1455         * TestWebKitAPI/PlatformJSCOnly.cmake:
1456         * TestWebKitAPI/PlatformMac.cmake:
1457         * TestWebKitAPI/PlatformPlayStation.cmake:
1458         * TestWebKitAPI/PlatformUtilities.h:
1459         * TestWebKitAPI/PlatformWPE.cmake:
1460         * TestWebKitAPI/PlatformWin.cmake:
1461         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
1462         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1463         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
1464         * TestWebKitAPI/Tests/WebCore/LineBreaking.mm:
1465         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm:
1466         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:
1467         * TestWebKitAPI/config.h:
1468
1469 2019-05-01  Jiewen Tan  <jiewen_tan@apple.com>
1470
1471         Move Document::domainIsRegisterable to SecurityOrigin::isMatchingRegistrableDomainSuffix
1472         https://bugs.webkit.org/show_bug.cgi?id=181950
1473         <rdar://problem/43357371>
1474
1475         Reviewed by Brent Fulgham.
1476
1477         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
1478         (TestWebKitAPI::TEST_F):
1479
1480 2019-05-01  Aakash Jain  <aakash_jain@apple.com>
1481
1482         Remove webkitpy and bindings EWS queues from dashboard
1483         https://bugs.webkit.org/show_bug.cgi?id=197475
1484
1485         Reviewed by Alexey Proskuryakov.
1486
1487         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1488
1489 2019-05-01  Aakash Jain  <aakash_jain@apple.com>
1490
1491         Remove webkitpy and bindings test queues from old EWS
1492         https://bugs.webkit.org/show_bug.cgi?id=197468
1493
1494         Reviewed by Alexey Proskuryakov.
1495
1496         * QueueStatusServer/config/queues.py:
1497
1498 2019-04-30  Tim Horton  <timothy_horton@apple.com>
1499
1500         Fix the WebKitTestRunner build
1501         https://bugs.webkit.org/show_bug.cgi?id=197449
1502         <rdar://problem/50334169>
1503
1504         Reviewed by Alexey Proskuryakov.
1505
1506         * WebKitTestRunner/mac/EventSenderProxy.mm:
1507         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
1508         (WTR::EventSenderProxy::mouseForceChanged):
1509         Use some SPI instead of IPI.
1510
1511 2019-04-30  Chris Dumez  <cdumez@apple.com>
1512
1513         Regression(PSON) URL scheme handlers can no longer respond asynchronously
1514         https://bugs.webkit.org/show_bug.cgi?id=197426
1515         <rdar://problem/50256169>
1516
1517         Reviewed by Brady Eidson.
1518
1519         Add API test coverage.
1520
1521         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1522         (-[PSONScheme setShouldRespondAsynchronously:]):
1523         (-[PSONScheme webView:startURLSchemeTask:]):
1524         (-[PSONScheme webView:stopURLSchemeTask:]):
1525
1526 2019-04-30  Chris Dumez  <cdumez@apple.com>
1527
1528         Unreviewed, rolling out r244802.
1529
1530         Caused an API test failure
1531
1532         Reverted changeset:
1533
1534         "Regression(PSON) URL scheme handlers can no longer respond
1535         asynchronously"
1536         https://bugs.webkit.org/show_bug.cgi?id=197426
1537         https://trac.webkit.org/changeset/244802
1538
1539 2019-04-30  Chris Dumez  <cdumez@apple.com>
1540
1541         Regression(PSON) URL scheme handlers can no longer respond asynchronously
1542         https://bugs.webkit.org/show_bug.cgi?id=197426
1543         <rdar://problem/50256169>
1544
1545         Reviewed by Brady Eidson.
1546
1547         Add API test coverage.
1548
1549         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1550         (-[PSONScheme setShouldRespondAsynchronously:]):
1551         (-[PSONScheme webView:startURLSchemeTask:]):
1552         (-[PSONScheme webView:stopURLSchemeTask:]):
1553
1554 2019-04-30  Chris Dumez  <cdumez@apple.com>
1555
1556         Only use a related page's process if that page has not been closed yet
1557         https://bugs.webkit.org/show_bug.cgi?id=197393
1558         <rdar://problem/50302423>
1559
1560         Reviewed by Tim Horton.
1561
1562         Add API test coverage.
1563
1564         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1565
1566 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
1567
1568         [ews-build] Enable Bindings tests queue on new EWS
1569         https://bugs.webkit.org/show_bug.cgi?id=197424
1570
1571         Reviewed by Lucas Forschler.
1572
1573         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1574         (StatusBubble):
1575         * BuildSlaveSupport/ews-build/config.json:
1576
1577 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
1578
1579         [ews-build] Configure ews151 for running various tests
1580         https://bugs.webkit.org/show_bug.cgi?id=197419
1581
1582         Reviewed by Lucas Forschler.
1583
1584         * BuildSlaveSupport/ews-build/config.json:
1585
1586 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
1587
1588         [ews-build] Parse and display bindings test failures
1589         https://bugs.webkit.org/show_bug.cgi?id=197423
1590
1591         Reviewed by Lucas Forschler.
1592
1593         * BuildSlaveSupport/ews-build/steps.py:
1594         (RunBindingsTests.__init__): Set timeout of 5 minutes.
1595         (RunBindingsTests.start): Initialize log_observer for json output.
1596         (RunBindingsTests.getResultSummary): Update step and build summary based on bindings test results.
1597         (RunBindingsTests._addToLog): Method to add message to log.
1598         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-test accordingly.
1599
1600 2019-04-30  Pablo Saavedra  <psaavedra@igalia.com>
1601
1602         Unreviewed. Add myself as a committer.
1603
1604         * Scripts/webkitpy/common/config/contributors.json:
1605
1606 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
1607
1608         [ews-build] Enable webkitpy queue on new EWS
1609         https://bugs.webkit.org/show_bug.cgi?id=197396
1610
1611         Reviewed by Lucas Forschler.
1612
1613         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1614         (StatusBubble):
1615         * BuildSlaveSupport/ews-build/config.json:
1616
1617 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
1618
1619         [ews-build] Parse and display webkitpy failures
1620         https://bugs.webkit.org/show_bug.cgi?id=197395
1621
1622         Reviewed by Lucas Forschler.
1623
1624         * BuildSlaveSupport/ews-build/steps.py:
1625         (RunWebKitPyTests.start): Initialize log_observer for json output.
1626         (RunWebKitPyTests.getResultSummary): Update step and build summary based on webkitpy results.
1627         (RunWebKitPyTests._addToLog): Method to add message to log.
1628         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-test accordingly.
1629
1630 2019-04-29  Alex Christensen  <achristensen@webkit.org>
1631
1632         <rdar://problem/50299396> Fix internal High Sierra build
1633         https://bugs.webkit.org/show_bug.cgi?id=197388
1634
1635         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1636         * MiniBrowser/Configurations/Base.xcconfig:
1637         * MobileMiniBrowser/Configurations/Base.xcconfig:
1638         * TestWebKitAPI/Configurations/Base.xcconfig:
1639         * WebKitTestRunner/Configurations/Base.xcconfig:
1640
1641 2019-04-29  Youenn Fablet  <youenn@apple.com>
1642
1643         Remove spurious GVA printf logging
1644         https://bugs.webkit.org/show_bug.cgi?id=197368
1645         <rdar://problem/35975256>
1646
1647         Reviewed by Alexey Proskuryakov.
1648
1649         * Scripts/webkitpy/port/mac.py:
1650         (MacPort.logging_patterns_to_strip):
1651
1652 2019-04-29  Youenn Fablet  <youenn@apple.com>
1653
1654         getDisplayMedia should be called on user gesture
1655         https://bugs.webkit.org/show_bug.cgi?id=197356
1656         <rdar://problem/50296074>
1657
1658         Reviewed by Eric Carlson.
1659
1660         Update test configuration to inject internals
1661         so that we can use it to simulate a user click to call getDisplayMedia.
1662
1663         * TestWebKitAPI/Tests/WebKit/getDisplayMedia.html:
1664         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
1665         (TestWebKitAPI::GetDisplayMediaTest::SetUp):
1666
1667 2019-04-26  Stephanie Lewis  <slewis@apple.com>
1668
1669         run-benchmarks should have an intial prep and restore env call for tasks that are too expensive to do for every iteration
1670         https://bugs.webkit.org/show_bug.cgi?id=197339
1671
1672         Reviewed by Dewei Zhu.
1673
1674         Add two new functions prepare_inital_env and restore_env_after_all_testing around the entire
1675         test run for setup steps that are too expensive to do every iteration.
1676
1677         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1678         (BenchmarkRunner._run_benchmark):
1679         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
1680         (BrowserDriver):
1681         (BrowserDriver.prepare_initial_env):
1682         (BrowserDriver.restore_env_after_all_testing):
1683         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
1684         (LinuxBrowserDriver.prepare_initial_env):
1685         (LinuxBrowserDriver.restore_env_after_all_testing):
1686         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1687         (OSXBrowserDriver.prepare_initial_env):
1688         (OSXBrowserDriver.restore_env_after_all_testing):
1689
1690 2019-04-28  Andy Estes  <aestes@apple.com>
1691
1692         Fix the watchOS engineering build.
1693
1694         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm:
1695         (TestWebKitAPI::TEST): AVVideoPerformanceMetrics does not exist on watchOS.
1696
1697 2019-04-27  Chris Dumez  <cdumez@apple.com>
1698
1699         [WKTR] Move test timeout handling to the UIProcess
1700         https://bugs.webkit.org/show_bug.cgi?id=197333
1701
1702         Reviewed by Darin Adler.
1703
1704         Move test timeout handling in WebKitTestRunner to the UIProcess to play nicely with PSON. Previously,
1705         we'd start the timeout timer in the InjectedBundle, which would fail to account of the time spent in
1706         every WebContent process in the case of swapping.
1707
1708         Also, because of process caching, the timeout timer would sometime fire in a cached process and it
1709         would lead to crashes when firing the timer.
1710
1711         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1712         (WTR::InjectedBundle::didReceiveMessageToPage):
1713         (WTR::InjectedBundle::done):
1714         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1715         (WTR::InjectedBundle::shouldDumpPixels const):
1716         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1717         (WTR::TestRunner::TestRunner):
1718         (WTR::TestRunner::waitUntilDone):
1719         (WTR::TestRunner::setWaitUntilDone):
1720         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1721         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
1722         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1723         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp:
1724         * WebKitTestRunner/InjectedBundle/wpe/TestRunnerWPE.cpp:
1725         * WebKitTestRunner/TestInvocation.cpp:
1726         (WTR::TestInvocation::TestInvocation):
1727         (WTR::TestInvocation::createTestSettingsDictionary):
1728         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1729         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1730         (WTR::TestInvocation::initializeWaitToDumpWatchdogTimerIfNeeded):
1731         (WTR::TestInvocation::invalidateWaitToDumpWatchdogTimer):
1732         (WTR::TestInvocation::waitToDumpWatchdogTimerFired):
1733         (WTR::TestInvocation::setWaitUntilDone):
1734         (WTR::TestInvocation::done):
1735         * WebKitTestRunner/TestInvocation.h:
1736
1737 2019-04-25  Yusuke Suzuki  <ysuzuki@apple.com>
1738
1739         [JSC] linkPolymorphicCall now does GC
1740         https://bugs.webkit.org/show_bug.cgi?id=197306
1741
1742         Reviewed by Saam Barati.
1743
1744         The test is sensitive to allocations and even adding $vm makes it non-reproducible.
1745         To add this test, we add `runWithoutBaseOption`.
1746
1747         * Scripts/run-jsc-stress-tests:
1748
1749 2019-04-26  Alexey Proskuryakov  <ap@apple.com>
1750
1751         Update inactive reviewers' status to 'contributor'.
1752
1753         Accidentally skipped one at first.
1754
1755         * Scripts/webkitpy/common/config/contributors.json:
1756
1757 2019-04-26  Alexey Proskuryakov  <ap@apple.com>
1758
1759         Update inactive reviewers' status to 'contributor'.
1760
1761         * Scripts/webkitpy/common/config/contributors.json: The change.
1762
1763         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1764         * Scripts/webkitpy/common/checkout/checkout_mock.py:
1765         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1766         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
1767         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1768         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
1769         * Scripts/webkitpy/tool/commands/queries_unittest.py:
1770         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1771         Sadly, regression tests operate on a crazy mix of mock and live data for
1772         contributors.json. It would be a substantial project to mock all code paths,
1773         so changing the tests instead.
1774
1775 2019-04-26  Eric Carlson  <eric.carlson@apple.com>
1776
1777         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
1778         https://bugs.webkit.org/show_bug.cgi?id=197171
1779         <rdar://problem/47454979>
1780
1781         Reviewed by Youenn Fablet.
1782
1783         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1784         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
1785         (TestWebKitAPI::TEST):
1786
1787 2019-04-26  David Kilzer  <ddkilzer@apple.com>
1788
1789         WebKitTestRunner leaks an NSDictionary and multiple JSStringRef objects
1790         <https://webkit.org/b/197314>
1791         <rdar://problem/50245252>
1792
1793         Reviewed by Simon Fraser.
1794
1795         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1796         (WTR::UIScriptController::lastUndoLabel const):
1797         (WTR::UIScriptController::firstRedoLabel const):
1798         - Use adopt(JSStringCreateWithCFString(...)) to fix leaks.
1799
1800         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1801         (-[HIDEventGenerator sendEventStream:completionBlock:]):
1802         - Call -autorelease to fix leak of NSDictionary.
1803
1804         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1805         (WTR::UIScriptController::accessibilitySpeakSelectionContent const):
1806         (WTR::UIScriptController::selectFormPopoverTitle const):
1807         (WTR::UIScriptController::textContentType const):
1808         (WTR::UIScriptController::formInputLabel const):
1809         (WTR::UIScriptController::scrollingTreeAsText const):
1810         - Use adopt(JSStringCreateWithCFString(...)) to fix leaks.
1811
1812 2019-04-26  Jonathan Bedard  <jbedard@apple.com>
1813
1814         webkitpy: Running a single test will always use the default device
1815         https://bugs.webkit.org/show_bug.cgi?id=195472
1816         <rdar://problem/48724825>
1817
1818         Reviewed by Lucas Forschler.
1819
1820         It makes more sense to have the Manager class handle the case where a user specifically requests a test which is
1821         skipped on the current configuration. This changes the behavior when running part of a test shard, now tests explicitly
1822         requested will be run regardless of what shard they are in.
1823
1824         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
1825         (LayoutTestFinder.skip_tests): Caller should manage running skipped tests which were explicitly requested.
1826         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1827         (Manager.run): If a test is marked as skipped for the configuration, but was specifically requested, run it anyways
1828         on the default device type.
1829         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1830         (RunTest.test_run_chunk): Explicitly requesting a test will override sharing behavior.
1831         (RunTest.test_run_part): Ditto.
1832
1833 2019-04-26  Alex Christensen  <achristensen@webkit.org>
1834
1835         Add ENABLE(CONTENT_EXTENSIONS) and namespace ContentExtensions to ResourceLoadInfo.h
1836         https://bugs.webkit.org/show_bug.cgi?id=197165
1837
1838         Reviewed by Youenn Fablet.
1839
1840         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1841
1842 2019-04-26  Ryan Haddad  <ryanhaddad@apple.com>
1843
1844         Replace iOS build queue hardware
1845         https://bugs.webkit.org/show_bug.cgi?id=197312
1846
1847         Reviewed by Aakash Jain.
1848
1849         * BuildSlaveSupport/build.webkit.org-config/config.json:
1850         Use newer hardware that supports macOS Mojave.
1851
1852 2019-04-26  Yoshiaki Jitsukawa  <yoshiaki.jitsukawa@sony.com>
1853
1854         check-webkit-style complains the first block in while loop.
1855         https://bugs.webkit.org/show_bug.cgi?id=197307
1856
1857         The style checker shouldn't complain about an open brace on
1858         its own line if the last non-whitespace character on the previous
1859         non-blank line is another open brace, because it's likely to
1860         indicate the begining of a nested code block.
1861
1862         Reviewed by Alex Christensen.
1863
1864         * Scripts/webkitpy/style/checkers/cpp.py:
1865         (check_braces):
1866         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1867         (WebKitStyleTest.test_braces):
1868
1869 2019-04-26  Sihui Liu  <sihui_liu@apple.com>
1870
1871         Stop IDB transactions to release locked database files when network process is ready to suspend
1872         https://bugs.webkit.org/show_bug.cgi?id=196372
1873         <rdar://problem/48930116>
1874
1875         Reviewed by Brady Eidson.
1876
1877         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1878         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.html: Added.
1879         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.mm: Added.
1880         (-[IndexedDBSuspendImminentlyMessageHandler userContentController:didReceiveScriptMessage:]):
1881         (runTestAndCheckResult):
1882         (keepNetworkProcessActive):
1883         (TEST):
1884
1885 2019-04-25  Simon Fraser  <simon.fraser@apple.com>
1886
1887         REGRESSION (r234330): 3 legacy-animation-engine/compositing tests are flaky failures
1888         https://bugs.webkit.org/show_bug.cgi?id=188357
1889         <rdar://problem/42986633>
1890
1891         Reviewed by Dean Jackson.
1892
1893         DumpRenderTree had no code that set page.setCompositingPolicyOverride() to Normal, so some
1894         tests would fall into low memory mode and have different behavior.
1895         
1896         Fix by moving the code that calls setCompositingPolicyOverride(Normal) from the WK2 layer
1897         to Internals, so it's shared by DRT and WTR.
1898         
1899         We no longer need the WK2 C SPI glue.
1900
1901         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1902         (WTR::InjectedBundlePage::prepare):
1903
1904 2019-04-25  Jonathan Bedard  <jbedard@apple.com>
1905
1906         webkitpy: Including skipped tests in the final count
1907         https://bugs.webkit.org/show_bug.cgi?id=197298
1908         <rdar://problem/49705424>
1909
1910         Reviewed by Lucas Forschler.
1911
1912         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
1913         (BuildBotPrinter.print_run_results): The total number of tests run should exclude delibrately skipped tests.
1914
1915 2019-04-25  Timothy Hatcher  <timothy@apple.com>
1916
1917         Disable date and time inputs on iOSMac.
1918         https://bugs.webkit.org/show_bug.cgi?id=197287
1919         rdar://problem/46794376
1920
1921         Reviewed by Wenson Hsieh.
1922
1923         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1924
1925 2019-04-25  Alex Christensen  <achristensen@webkit.org>
1926
1927         Fix test-webkitpy after r244653
1928         https://bugs.webkit.org/show_bug.cgi?id=197131
1929
1930         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
1931         Also use C++17.
1932
1933 2019-04-25  Per Arne Vollan  <pvollan@apple.com>
1934
1935         -[WKWebsiteDataStore fetchDataRecordsOfTypes:completionHandler:] never returns _WKWebsiteDataTypeCredentials
1936         https://bugs.webkit.org/show_bug.cgi?id=196991
1937         <rdar://problem/45507423>
1938
1939         Reviewed by Alex Christensen.
1940
1941         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
1942         (-[NavigationTestDelegate init]):
1943         (-[NavigationTestDelegate waitForDidFinishNavigation]):
1944         (-[NavigationTestDelegate webView:didFinishNavigation:]):
1945         (-[NavigationTestDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1946         (TestWebKitAPI::TEST):
1947         (TEST): Deleted.
1948
1949 2019-04-25  Alex Christensen  <achristensen@webkit.org>
1950
1951         Revert some code accidentally committed with r244653
1952         https://bugs.webkit.org/show_bug.cgi?id=197131
1953
1954         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
1955         (TestWebKitAPI::TEST):
1956
1957 2019-04-25  Alex Christensen  <achristensen@webkit.org>
1958
1959         Start using C++17
1960         https://bugs.webkit.org/show_bug.cgi?id=197131
1961
1962         Reviewed by Darin Adler.
1963
1964         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1965         * MiniBrowser/Configurations/Base.xcconfig:
1966         * MobileMiniBrowser/Configurations/Base.xcconfig:
1967         * TestWebKitAPI/Configurations/Base.xcconfig:
1968         * WebKitTestRunner/Configurations/Base.xcconfig:
1969
1970 2019-04-25  Commit Queue  <commit-queue@webkit.org>
1971
1972         Unreviewed, rolling out r244627.
1973         https://bugs.webkit.org/show_bug.cgi?id=197282
1974
1975         Causing internal build failures (Requested by ShawnRoberts on
1976         #webkit).
1977
1978         Reverted changeset:
1979
1980         "Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
1981         https://bugs.webkit.org/show_bug.cgi?id=197171
1982         https://trac.webkit.org/changeset/244627
1983
1984 2019-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1985
1986         [GTK] Hardcoded text color in input fields
1987         https://bugs.webkit.org/show_bug.cgi?id=126907
1988
1989         Reviewed by Michael Catanzaro.
1990
1991         Add dark-mode command line option to MiniBrowser.
1992
1993         * MiniBrowser/gtk/main.c:
1994         (main):
1995
1996 2019-04-24  Zalan Bujtas  <zalan@apple.com>
1997
1998         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
1999         https://bugs.webkit.org/show_bug.cgi?id=196948
2000         <rdar://problem/49927131>
2001
2002         Reviewed by Tim Horton.
2003
2004         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
2005         (TEST):
2006         The expected order of incoming events is
2007         1. didInvalidateIntrinsicContentSize
2008         2. didFirstLayout
2009         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
2010         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
2011         (and remember, all we care about is ordering).
2012
2013 2019-04-24  Eric Carlson  <eric.carlson@apple.com>
2014
2015         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
2016         https://bugs.webkit.org/show_bug.cgi?id=197171
2017         <rdar://problem/47454979>
2018
2019         Reviewed by Youenn Fablet.
2020
2021         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2022         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
2023         (TestWebKitAPI::TEST):
2024
2025 2019-04-24  Brady Eidson  <beidson@apple.com>
2026
2027         XMLHTTPRequest POSTs to a custom WKURLSchemeHandler protocol are missing the HTTP body.
2028         https://bugs.webkit.org/show_bug.cgi?id=191362
2029
2030         Reviewed by Alex Christensen.
2031
2032         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm: Add a test that POSTs all sorts of things
2033           from an XHR to a custom protocol.
2034
2035 2019-04-25  Simon Fraser  <simon.fraser@apple.com>
2036
2037         DumpRenderTree doesn't call Internals::resetToConsistentState() before the first test
2038         https://bugs.webkit.org/show_bug.cgi?id=197273
2039
2040         Reviewed by Dean Jackson.
2041
2042         Reorder code so that we create gTestRunner before calling resetWebViewToConsistentStateBeforeTesting(),
2043         so that WebCoreTestSupport::resetInternalsObject() is always run.
2044
2045         * DumpRenderTree/mac/DumpRenderTree.mm:
2046         (resetWebViewToConsistentStateBeforeTesting):
2047         (runTest):
2048
2049 2019-04-24  John Wilander  <wilander@apple.com>
2050
2051         Age out unconverted Ad Click Attributions after one week.
2052         https://bugs.webkit.org/show_bug.cgi?id=197238
2053         <rdar://problem/50177349>
2054
2055         Reviewed by Chris Dumez.
2056
2057         This patch adds infrastructure to allow tests to expire all unconverted
2058         attributions early.
2059
2060         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2061         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2062         (WTR::TestRunner::markAdClickAttributionsAsExpiredForTesting):
2063         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2064         * WebKitTestRunner/TestController.cpp:
2065         (WTR::TestController::markAdClickAttributionsAsExpiredForTesting):
2066         * WebKitTestRunner/TestController.h:
2067         * WebKitTestRunner/TestInvocation.cpp:
2068         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2069
2070 2019-04-24  Chris Dumez  <cdumez@apple.com>
2071
2072         Fix flaky crashes in a couple of PSON API tests
2073         https://bugs.webkit.org/show_bug.cgi?id=197239
2074
2075         Reviewed by Tim Horton.
2076
2077         Do not adopt the NSURLRequest returned by [NSURLRequest requestWithURL:].
2078
2079         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2080
2081 2019-04-24  Simon Fraser  <simon.fraser@apple.com>
2082
2083         Make it possible to control the renderTreeAsText output by setting options on testRunner
2084         https://bugs.webkit.org/show_bug.cgi?id=197133
2085
2086         Reviewed by Sam Weinig.
2087
2088         Add testRunner.setRenderTreeDumpOptions() and expose the subset of RenderAsTextFlag flags
2089         that make sense in testing (those that don't dump unstable data like addresses), and plumb
2090         these flags through the various framework layers.
2091
2092         Convert RenderAsTextBehavior to an OptionSet<RenderAsTextFlag>.
2093
2094         Fix code generation in WebKitTestRunner to generate bindings for IDL const values,
2095         and hand-code DumpRenderTree bindings.
2096
2097         Some cleanup of the TestRunners, using member initializers.
2098
2099         * DumpRenderTree/TestRunner.cpp:
2100         (TestRunner::TestRunner):
2101         (setRenderTreeDumpOptionsCallback):
2102         (TestRunner::staticFunctions):
2103         (TestRunner::setRenderTreeDumpOptions):
2104         * DumpRenderTree/TestRunner.h:
2105         (TestRunner::renderTreeDumpOptions const):
2106         * DumpRenderTree/mac/DumpRenderTree.mm:
2107         (dump):
2108         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2109         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2110         (WTR::InjectedBundlePage::dump):
2111         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2112         (WTR::TestRunner::TestRunner):
2113         (WTR::TestRunner::setRenderTreeDumpOptions):
2114         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2115         (WTR::TestRunner::renderTreeDumpOptions const):
2116
2117 2019-04-24  Alex Christensen  <achristensen@webkit.org>
2118
2119         WKContentRuleLists should have a maximum FileProtection of CompleteUnlessOpen
2120         https://bugs.webkit.org/show_bug.cgi?id=197078
2121         <rdar://problem/49564348>
2122
2123         Reviewed by Geoff Garen.
2124
2125         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2126         (TEST_F):
2127         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]): Deleted.
2128         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]): Deleted.
2129         Unfortunately, setting the NSFileProtectionKey attribute is only supported on iOS devices.
2130
2131 2019-04-24  Alex Christensen  <achristensen@webkit.org>
2132
2133         Add unit test for r239322
2134         https://bugs.webkit.org/show_bug.cgi?id=197236
2135
2136         Reviewed by Chris Dumez.
2137
2138         I initially developed this as a unit test for rdar://problem/48797895 but it seems that isn't quite ready.
2139         May as well add the test infrastructure which was needed before and will be needed in the future.
2140
2141         * TestWebKitAPI/TCPServer.cpp:
2142         (TestWebKitAPI::TCPServer::TCPServer):
2143         * TestWebKitAPI/TCPServer.h:
2144         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2145         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
2146         (TestWebKitAPI::TEST):
2147         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2148         (TestWebKitAPI::downloadAtRate):
2149         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
2150         (TEST):
2151         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm: Added.
2152         (-[ProxyDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2153         (-[ProxyDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2154         (TestWebKitAPI::TEST):
2155         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
2156         (TEST):
2157
2158 2019-04-24  Chris Dumez  <cdumez@apple.com>
2159
2160         URL set by document.open() is communicated with the WebPageProxy but not the WebFrameProxy
2161         https://bugs.webkit.org/show_bug.cgi?id=197214
2162         <rdar://problem/49237544>
2163
2164         Reviewed by Alex Christensen.
2165
2166         Extend API test coverage.
2167
2168         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
2169         (TEST):
2170
2171 2019-04-24  Philippe Normand  <pnormand@igalia.com>
2172
2173         [Build][GStreamer] Update to 1.16.0
2174         https://bugs.webkit.org/show_bug.cgi?id=197157
2175
2176         Reviewed by Xabier Rodriguez-Calvar.
2177
2178         The upstreamed patches were removed and a new one was added for a
2179         regression detected in the scaletempo GStreamer element. The GNOME
2180         Flatpak was migrated to 3.32 and I switched a few modules to Meson
2181         on the way, as it is the preferred build system now in GStreamer
2182         1.16.
2183
2184         * flatpak/files/httpd-autogen.sh:
2185         * flatpak/flatpakutils.py:
2186         (FlatpakPackage.install):
2187         (WebkitFlatpak.run_in_sandbox):
2188         * flatpak/org.webkit.CommonModules.yaml:
2189         * flatpak/org.webkit.WebKit.yaml:
2190         * gstreamer/jhbuild.modules:
2191         * gstreamer/patches/gst-plugins-bad-0001-aomenc-Add-support-for-10-12bit-decoding.patch: Removed.
2192         * gstreamer/patches/gst-plugins-bad-0002-aomenc-Handle-8-bit_depth-images-with-AOM_IMG_FMT_HI.patch: Removed.
2193         * gstreamer/patches/gst-plugins-bad-0003-fdkaacenc-Remove-MODE_2_1.patch: Removed.
2194         * gstreamer/patches/gst-plugins-bad-0004-fdkaacdec-Use-WAV-channel-mapping-instead-of-interleave-setting.patch: Removed.
2195         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Removed.
2196         * gstreamer/patches/gst-plugins-base-0001-parsebin-Post-STREAM_COLLECTION-on-EVENT_STREAM_COLL.patch: Removed.
2197         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Detect-and-expose-CEA-608-708-Closed-Caption.patch: Removed.
2198         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Do-not-run-the-preferred-decryptor-context-q.patch: Removed.
2199         * gstreamer/patches/gst-plugins-good-0002-qtdemux-Do-not-unref-a-NULL-stream_tags.patch: Removed.
2200         * gstreamer/patches/gst-plugins-good-0002-qtdemux-add-context-for-a-preferred-protection.patch: Removed.
2201         * gstreamer/patches/gst-plugins-good-0003-qtdemux-Clarify-field-name-about-stream-encryption-s.patch: Removed.
2202         * gstreamer/patches/gst-plugins-good-0003-qtdemux-also-push-buffers-without-encryption-info-in.patch: Removed.
2203         * gstreamer/patches/gst-plugins-good-0004-qtdemux-Add-initial-support-for-AV1-demuxing.patch: Removed.
2204         * gstreamer/patches/gst-plugins-good-0005-qtdemux-Extract-AV1-codec_data-and-put-it-in-the-cap.patch: Removed.
2205         * gstreamer/patches/gst-plugins-good-0006-qtdemux-Recognize-more-AV1-atoms.patch: Removed.
2206         * gstreamer/patches/gst-plugins-good-0011-matroska-Add-the-WebM-encrypted-content-support-in-m.patch: Removed.
2207         * gstreamer/patches/gst-plugins-good-0012-matroskdemux-do-not-use-MapInfo.data-after-unmapping.patch: Removed.
2208         * gstreamer/patches/gst-plugins-good-0013-Avoid-warning-when-reporting-about-decryptors.patch: Removed.
2209         * gstreamer/patches/gst-plugins-good-0014-pulse-Mark-default-devices-as-default.patch: Removed.
2210         * gstreamer/patches/gst-plugins-good-scaletempo-Advertise-interleaved-layout-in-caps-temp.patch: Added.
2211         * gstreamer/patches/gstreamer-0001-protection-Add-a-new-definition-for-unspecified-syst.patch: Removed.
2212         * gstreamer/patches/gstreamer-0002-protection-Fix-the-string-to-define-unspecified-syst.patch: Removed.
2213
2214 2019-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2215
2216         [GTK] MiniBrowser: also set the passed bg-color when receiving arguments
2217         https://bugs.webkit.org/show_bug.cgi?id=197156
2218
2219         Reviewed by Michael Catanzaro.
2220
2221         The background color is only set when MiniBrowser is launched without arguments. This regressed when tabs
2222         support was added.
2223
2224         * MiniBrowser/gtk/BrowserTab.c:
2225         (browser_tab_set_background_color): Set the passed in color as web view background color.
2226         * MiniBrowser/gtk/BrowserTab.h:
2227         * MiniBrowser/gtk/BrowserWindow.c:
2228         (browser_window_init): Initialize backgroundColor.
2229         (browser_window_append_view): Call browser_tab_set_background_color().
2230         (browser_window_set_background_color): Save the passed in color. This function should now be called before tabs
2231         are added.
2232         * MiniBrowser/gtk/main.c:
2233         (main): Call browser_window_set_background_color() before creating the tabs.
2234
2235 2019-04-23  John Wilander  <wilander@apple.com>
2236
2237         Move Ad Click Attribution from internal feature to experimental feature
2238         https://bugs.webkit.org/show_bug.cgi?id=197218
2239         <rdar://problem/47651691>
2240
2241         Reviewed by Brent Fulgham.
2242
2243         * DumpRenderTree/TestOptions.cpp:
2244         (TestOptions::TestOptions):
2245
2246 2019-04-23  Andy Estes  <aestes@apple.com>
2247
2248         [iOS] QuickLook documents loaded from file: URLs should be allowed to perform same-document navigations
2249         https://bugs.webkit.org/show_bug.cgi?id=196749
2250         <rdar://problem/35773454>
2251
2252         Reviewed by Daniel Bates.
2253
2254         Added a new QuickLook API test and added new expectations to existing QuickLook tests.
2255
2256         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
2257         (-[QuickLookDelegate webView:didStartProvisionalNavigation:]):
2258         (-[QuickLookDelegate webView:didFinishNavigation:]):
2259         (-[QuickLookDelegate _webView:didFailNavigation:withError:userInfo:]):
2260         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
2261         (runTest):
2262         (runTestDecideBeforeLoading):
2263         (runTestDecideAfterLoading):
2264         (TEST):
2265
2266 2019-04-23  John Wilander  <wilander@apple.com>
2267
2268         Remove Ad Click Attribution data when removing website data
2269         https://bugs.webkit.org/show_bug.cgi?id=197215
2270         <rdar://problem/47668988>
2271
2272         Reviewed by Chris Dumez.
2273
2274         This patch adds test infrastructure to delete Ad Click Attribution data
2275         through WebsiteDataStore::removeData().
2276
2277         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2278         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2279         (WTR::TestRunner::clearAdClickAttribution):
2280         (WTR::TestRunner::clearAdClickAttributionsThroughWebsiteDataRemoval):
2281         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2282         * WebKitTestRunner/TestController.cpp:
2283         (WTR::TestController::clearAdClickAttributionsThroughWebsiteDataRemoval):
2284         * WebKitTestRunner/TestController.h:
2285         * WebKitTestRunner/TestInvocation.cpp:
2286         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2287
2288 2019-04-23  Jonathan Bedard  <jbedard@apple.com>
2289
2290         webkitpy: Kill unresponsive worker processes
2291         https://bugs.webkit.org/show_bug.cgi?id=197205
2292         <rdar://problem/50104388>
2293
2294         Reviewed by Lucas Forschler.
2295
2296         * Scripts/webkitpy/common/message_pool.py:
2297         (_MessagePool.__init__): Add close timeout.
2298         (_MessagePool._close): Send termination before joining workers, kill unresponsive workers.
2299
2300 2019-04-23  Alex Christensen  <achristensen@webkit.org>
2301
2302         Add unit tests for WKWebView.serverTrust
2303         https://bugs.webkit.org/show_bug.cgi?id=197202
2304
2305         Reviewed by Youenn Fablet
2306
2307         * TestWebKitAPI/TCPServer.cpp:
2308         (TestWebKitAPI::deleter<BIO>::operator()):
2309         (TestWebKitAPI::deleter<SSL>::operator()):
2310         (TestWebKitAPI::deleter<X509>::operator()):
2311         (TestWebKitAPI::deleter<SSL_CTX>::operator()):
2312         (TestWebKitAPI::deleter<EVP_PKEY>::operator()):
2313         (TestWebKitAPI::TCPServer::TCPServer):
2314         (TestWebKitAPI::TCPServer::listenForConnections):
2315         * TestWebKitAPI/TCPServer.h:
2316         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2317         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
2318         (TestWebKitAPI::TEST):
2319         (verifyCertificateAndPublicKey):
2320         (-[ServerTrustDelegate webView:didFinishNavigation:]):
2321         (-[ServerTrustDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2322         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2323         (TestWebKitAPI::downloadAtRate):
2324         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
2325         (TEST):
2326         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
2327         (TEST):
2328
2329 2019-04-23  Commit Queue  <commit-queue@webkit.org>
2330
2331         Unreviewed, rolling out r244556.
2332         https://bugs.webkit.org/show_bug.cgi?id=197212
2333
2334         Causing build failures on multiple builders (Requested by
2335         ShawnRoberts on #webkit).
2336
2337         Reverted changeset:
2338
2339         "Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
2340         https://bugs.webkit.org/show_bug.cgi?id=197171
2341         https://trac.webkit.org/changeset/244556
2342
2343 2019-04-23  Alex Christensen  <achristensen@webkit.org>
2344
2345         Fix iOS build.
2346         https://bugs.webkit.org/show_bug.cgi?id=195537
2347
2348         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2349         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
2350         AdoptWK constructor is private now.  Use adoptWK instead.
2351
2352 2019-04-23  Andres Gonzalez  <andresg_22@apple.com>
2353
2354         Accessibility text search and selection API enhancements.
2355         https://bugs.webkit.org/show_bug.cgi?id=197095
2356         <rdar://problem/48181791>
2357
2358         Reviewed by Chris Fleizach.
2359
2360         Added new API JS binding code for searchTextWithCriteria to both WTR and DRT.
2361
2362         * DumpRenderTree/AccessibilityTextMarker.h:
2363         * DumpRenderTree/AccessibilityUIElement.cpp:
2364         (searchTextWithCriteriaCallback):
2365         (AccessibilityUIElement::getJSClass):
2366         * DumpRenderTree/AccessibilityUIElement.h:
2367         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2368         (convertVectorToObjectArray):
2369         (convertNSArrayToVector):
2370         (searchTextParameterizedAttributeForCriteria):
2371         (AccessibilityUIElement::getLinkedUIElements):
2372         (AccessibilityUIElement::getDocumentLinks):
2373         (AccessibilityUIElement::getChildren):
2374         (AccessibilityUIElement::getChildrenWithRange):
2375         (AccessibilityUIElement::rowHeaders const):
2376         (AccessibilityUIElement::columnHeaders const):
2377         (AccessibilityUIElement::uiElementArrayAttributeValue const):
2378         (AccessibilityUIElement::searchTextWithCriteria):
2379         (AccessibilityUIElement::attributesOfColumnHeaders):
2380         (AccessibilityUIElement::attributesOfRowHeaders):
2381         (AccessibilityUIElement::attributesOfColumns):
2382         (AccessibilityUIElement::attributesOfRows):
2383         (AccessibilityUIElement::attributesOfVisibleCells):
2384         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2385         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2386         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2387         (WTR::convertVectorToObjectArray):
2388         (WTR::convertNSArrayToVector):
2389         (WTR::searchTextParameterizedAttributeForCriteria):
2390         (WTR::AccessibilityUIElement::getLinkedUIElements):
2391         (WTR::AccessibilityUIElement::getDocumentLinks):
2392         (WTR::AccessibilityUIElement::getUIElementsWithAttribute const):
2393         (WTR::AccessibilityUIElement::getChildren):
2394         (WTR::AccessibilityUIElement::getChildrenWithRange):
2395         (WTR::AccessibilityUIElement::rowHeaders const):
2396         (WTR::AccessibilityUIElement::columnHeaders const):
2397         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue const):
2398         (WTR::AccessibilityUIElement::searchTextWithCriteria):
2399         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
2400         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
2401         (WTR::AccessibilityUIElement::attributesOfColumns):
2402         (WTR::AccessibilityUIElement::attributesOfRows):
2403         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
2404         (WTR::convertElementsToObjectArray): Deleted.
2405
2406 2019-04-23  Guy Lewin  <guy@lewin.co.il>
2407
2408         Multiple File Input Icon Set Regardless of File List
2409         https://bugs.webkit.org/show_bug.cgi?id=195537
2410
2411         Reviewed by Alexey Proskuryakov.
2412
2413         Add setOpenPanelFilesMediaIcon to TestRunner in order to test icon and
2414         display string in iOS file inputs
2415
2416         * DumpRenderTree/TestRunner.cpp:
2417         (SetOpenPanelFilesMediaIconCallback):
2418         (TestRunner::staticFunctions):
2419         (TestRunner::setOpenPanelFilesMediaIcon):
2420         * DumpRenderTree/TestRunner.h:
2421         (TestRunner::openPanelFilesMediaIcon const):
2422         * DumpRenderTree/mac/UIDelegate.mm:
2423         (-[UIDelegate webView:runOpenPanelForFileButtonWithResultListener:allowMultipleFiles:]):
2424         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2425         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2426         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
2427         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2428         * WebKitTestRunner/TestController.cpp:
2429         (WTR::runOpenPanel):
2430         (WTR::TestController::resetStateToConsistentValues):
2431         * WebKitTestRunner/TestController.h:
2432         (WTR::TestController::openPanelFileURLsMediaIcon const):
2433         (WTR::TestController::setOpenPanelFileURLsMediaIcon):
2434         * WebKitTestRunner/TestInvocation.cpp:
2435         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2436
2437 2019-04-23  Eric Carlson  <eric.carlson@apple.com>
2438
2439         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
2440         https://bugs.webkit.org/show_bug.cgi?id=197171
2441         <rdar://problem/47454979>
2442
2443         Reviewed by Youenn Fablet.
2444
2445         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2446         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
2447         (TestWebKitAPI::TEST):
2448
2449 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
2450
2451         [ews-build] Add unit tests for UnApplyPatchIfRequired
2452         https://bugs.webkit.org/show_bug.cgi?id=197197
2453
2454         Reviewed by Lucas Forschler.
2455
2456         * BuildSlaveSupport/ews-build/steps_unittest.py:
2457         (TestUnApplyPatchIfRequired):
2458         (TestUnApplyPatchIfRequired.test_success):
2459         (TestUnApplyPatchIfRequired.test_failure):
2460         (TestUnApplyPatchIfRequired.test_skip):
2461
2462 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
2463
2464         [ews-build] Add unit tests for CleanWorkingDirectory
2465         https://bugs.webkit.org/show_bug.cgi?id=197195
2466
2467         Reviewed by Lucas Forschler.
2468
2469         * BuildSlaveSupport/ews-build/steps_unittest.py:
2470         (TestCleanWorkingDirectory):
2471         (TestCleanWorkingDirectory.test_success):
2472         (TestCleanWorkingDirectory.test_failure):
2473
2474 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
2475
2476         [ews-build] Use explicit imports instead of wildcard imports
2477         https://bugs.webkit.org/show_bug.cgi?id=197194
2478
2479         Reviewed by Lucas Forschler.
2480
2481         * BuildSlaveSupport/ews-build/factories.py:
2482         * BuildSlaveSupport/ews-build/loadConfig.py:
2483         * BuildSlaveSupport/ews-build/steps_unittest.py:
2484
2485 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
2486
2487         [ews-build] Add unit tests for DownloadBuiltProduct
2488         https://bugs.webkit.org/show_bug.cgi?id=197193
2489
2490         Reviewed by Lucas Forschler.
2491
2492         * BuildSlaveSupport/ews-build/steps_unittest.py:
2493         (TestDownloadBuiltProduct):
2494         (TestDownloadBuiltProduct.setUp):
2495         (TestDownloadBuiltProduct.tearDown):
2496         (TestDownloadBuiltProduct.test_success):
2497         (TestDownloadBuiltProduct.test_failure):
2498
2499 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
2500
2501         [ews-app] Exception while loading status-bubble when no build step has started
2502         https://bugs.webkit.org/show_bug.cgi?id=196676
2503
2504         Reviewed by Lucas Forschler.
2505
2506         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2507         (StatusBubble.get_build_timestamp): Check if build step is present before accessing its timestamp.
2508
2509 2019-04-23  Stephan Szabo  <stephan.szabo@sony.com>
2510
2511         [PlayStation] Support running of JSC tests on remote playstation devices
2512         https://bugs.webkit.org/show_bug.cgi?id=197170
2513
2514         Reviewed by Ross Kirsling.
2515
2516         Script changes
2517
2518         * Scripts/run-javascriptcore-tests:
2519         (runJSCStressTests): Pass arguments for playstation to
2520         run-jsc-stress-tests
2521         * Scripts/run-jsc-stress-tests:
2522         Handle $hostOS=="playstation" for determineArchitecture, turning
2523         off $isFTLPlatform and runProfiler and defaulting test writer.
2524         * Scripts/webkitdirs.pm:
2525         (jscPath): PlayStation WebKit executables have .elf extension
2526         (executableProductDir): PlayStation builds on Windows hosts but
2527         uses bin directory rather than bin64/bin32 for executable output
2528         location.
2529         * Scripts/webkitruby/jsc-stress-test-writer-playstation.rb: Added.
2530
2531 2019-04-23  Don Olmstead  <don.olmstead@sony.com>
2532
2533         [CMake][Win] Use target oriented design for WebKit
2534         https://bugs.webkit.org/show_bug.cgi?id=197173
2535
2536         Reviewed by Alex Christensen.
2537
2538         * TestWebKitAPI/PlatformWin.cmake: Add WebKitFrameworkHeaders as a dependency.
2539         * TestWebKitAPI/Tests/WebKit/curl/Certificates.cpp: Remove unused header.
2540
2541 2019-04-23  Chris Dumez  <cdumez@apple.com>
2542
2543         [Process-Swap-On-Navigation] WebKit hangs when going back to a form submission's page due to Process-Swap-On-Navigation on iOS 12.2 and higher
2544         https://bugs.webkit.org/show_bug.cgi?id=197097
2545         <rdar://problem/50048318>
2546
2547         Reviewed by Alex Christensen.
2548
2549         Add API test coverage.
2550
2551         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2552         (-[PSONScheme webView:startURLSchemeTask:]):
2553
2554 2019-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2555
2556         [ATK] Implement AtkComponentIface scroll_to methods
2557         https://bugs.webkit.org/show_bug.cgi?id=196856
2558
2559         Reviewed by Michael Catanzaro.
2560
2561         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2562         (WTR::AccessibilityUIElement::scrollToMakeVisible): Call atk_component_scroll_to().
2563         (WTR::AccessibilityUIElement::scrollToGlobalPoint): Call atk_component_scroll_to_point().
2564         * gtk/jhbuild.modules: Bump atk, at-spi2-core and at-spi2-atk to their latest stable version.
2565
2566 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
2567
2568         [ews-build] Improve summary for UploadBuiltProduct step
2569         https://bugs.webkit.org/show_bug.cgi?id=197182
2570
2571         Reviewed by Lucas Forschler.
2572
2573         * BuildSlaveSupport/ews-build/steps.py:
2574         (UploadBuiltProduct): Added descriptionDone.
2575         (UploadBuiltProduct.getResultSummary): Overrided getResultSummary.
2576         * BuildSlaveSupport/ews-build/steps_unittest.py:
2577         (TestUploadBuiltProduct.test_success): Updated unit-test.
2578         (TestUploadBuiltProduct.test_failure): Added unit-test for failure case.
2579
2580 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
2581
2582         [ews-build] Trigger queues only after uploading the archive
2583         https://bugs.webkit.org/show_bug.cgi?id=197180
2584
2585         Reviewed by Lucas Forschler.
2586
2587         * BuildSlaveSupport/ews-build/factories.py:
2588         (Factory.__init__):
2589         (BuildFactory.__init__): Remove trigger step from factories.
2590         (BuildFactory.propertiesToPassToTriggers): Deleted.
2591         * BuildSlaveSupport/ews-build/steps.py:
2592         (ConfigureBuild.__init__): Confiure triggers property.
2593         (Trigger): Step to trigger other queues.
2594         (Trigger.propertiesToPassToTriggers): Method to construct properties to pass to triggerred builds.
2595         (UploadBuiltProduct.finished): Trigger builds after upload is successful.
2596
2597 2019-04-22  Alex Christensen  <achristensen@webkit.org>
2598
2599         Deprecate WKContextCreateWithInjectedBundlePath
2600         https://bugs.webkit.org/show_bug.cgi?id=197169
2601
2602         Reviewed by Youenn Fablet.
2603
2604         * TestWebKitAPI/PlatformUtilities.cpp:
2605         (TestWebKitAPI::Util::createContextWithInjectedBundle):
2606         Use WKContextCreateWithConfiguration instead of WKContextCreateWithInjectedBundlePath after having set its injected bundle path.
2607
2608 2019-04-22  Alex Christensen  <achristensen@webkit.org>
2609
2610         REGRESSION(r230681) Do not use stored credentials if WKBundlePageResourceLoadClient.shouldUseCredentialStorage returns false
2611         https://bugs.webkit.org/show_bug.cgi?id=197093
2612         <rdar://problem/49708268>
2613
2614         Reviewed by Chris Dumez.
2615
2616         Add a test that does two loads.  The first load shouldUseCredentialStorage returns true and we provide a persistent credential.
2617         The second load shouldUseCredentialStorage returns false and we verify that a challenge is received with no suggested credential.
2618         We also need to make the TCPServer able to handle more than one connection because we need these two loads to come from the same protection space,
2619         and our current Cocoa implementation of NetworkSession uses two NSURLSessions that don't share a connection cache, one for loads with credentials
2620         and one for loads without credentials, so there are two TCP connections to the same server in this test.
2621
2622         * TestWebKitAPI/TCPServer.cpp:
2623         (TestWebKitAPI::TCPServer::TCPServer):
2624         (TestWebKitAPI::TCPServer::~TCPServer):
2625         (TestWebKitAPI::TCPServer::socketBindListen):
2626         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests): Deleted.
2627         * TestWebKitAPI/TCPServer.h:
2628         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2629         * TestWebKitAPI/Tests/WebKitCocoa/BasicProposedCredentialPlugIn.mm: Added.
2630         (-[BasicProposedCredentialPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2631         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
2632         (respondWithChallengeThenOK):
2633         (TestWebKitAPI::TEST):
2634         (-[ProposedCredentialDelegate webView:didFinishNavigation:]):
2635         (-[ProposedCredentialDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2636         (TEST):
2637
2638 2019-04-22  Chris Dumez  <cdumez@apple.com>
2639
2640         Delayed WebProcessLaunch may break the _relatedWebView SPI
2641         https://bugs.webkit.org/show_bug.cgi?id=197160
2642
2643         Reviewed by Alex Christensen.
2644
2645         Add API test coverage.
2646
2647         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2648
2649 2019-04-22  Dean Johnson  <dean_johnson@apple.com>
2650
2651         Use curl to download packages for webkitpy autoinstaller
2652         https://bugs.webkit.org/show_bug.cgi?id=197164
2653
2654         Reviewed by Darin Adler.
2655
2656         * Scripts/webkitpy/common/system/autoinstall.py:
2657         (AutoInstaller._download): Use curl(1) to download packages necessary for
2658         webkitpy/thirdparty/autoinstalled since Python2's urllib2 module can result in unnecessary
2659         errors which are not present when using curl(1).
2660
2661 2019-04-22  Chris Dumez  <cdumez@apple.com>
2662
2663         Unreviewed, rolling out r244502.
2664
2665         Caused crashes on the bots
2666
2667         Reverted changeset:
2668
2669         "Delayed WebProcessLaunch may break the _relatedWebView SPI"
2670         https://bugs.webkit.org/show_bug.cgi?id=197160
2671         https://trac.webkit.org/changeset/244502
2672
2673 2019-04-22  Ryan Haddad  <ryanhaddad@apple.com>
2674
2675         Unreviewed, rolling out r244437.
2676
2677         Still breaks internal tests.
2678
2679         Reverted changeset:
2680
2681         "InjectedBundle parameters often need initialization function
2682         called before unarchiving"
2683         https://bugs.webkit.org/show_bug.cgi?id=189709
2684         https://trac.webkit.org/changeset/244437
2685
2686 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
2687
2688         [ews-build] Use singular verb in failure description in case of single api test failure
2689         https://bugs.webkit.org/show_bug.cgi?id=197013
2690
2691         Reviewed by Lucas Forschler.
2692
2693         * BuildSlaveSupport/ews-build/steps.py:
2694         (AnalyzeAPITestsResults.analyzeResults):
2695
2696 2019-04-22  Chris Dumez  <cdumez@apple.com>
2697
2698         Delayed WebProcessLaunch may break the _relatedWebView SPI
2699         https://bugs.webkit.org/show_bug.cgi?id=197160
2700
2701         Reviewed by Alex Christensen.
2702
2703         Add API test coverage.
2704
2705         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2706
2707 2019-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2708
2709         REGRESSION(r241289): [GTK] accessibility/removed-continuation-element-causes-crash.html and accessibility/removed-anonymous-block-child-causes-crash.html crashes
2710         https://bugs.webkit.org/show_bug.cgi?id=194630
2711
2712         Reviewed by Michael Catanzaro.
2713
2714         Return early from getAttributeSet() is passed in accessible is nullptr.
2715
2716         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2717
2718 2019-04-21  Wenson Hsieh  <wenson_hsieh@apple.com>
2719
2720         Defer EditorState updates until the next layer tree flush in a few additional circumstances
2721         https://bugs.webkit.org/show_bug.cgi?id=197145
2722         <rdar://problem/50078170>
2723
2724         Reviewed by Darin Adler.
2725
2726         Adjusts several editing API tests to wait for a presentation update following a selection change, programmatic
2727         focus, or showing the font manager.
2728
2729         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
2730         (TestWebKitAPI::TEST):
2731         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewTargetForAction.mm:
2732         (TEST):
2733         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
2734         (TestWebKitAPI::TEST):
2735
2736 2019-04-21  Brian Burg  <bburg@apple.com>
2737
2738         WebDriver: add hooks to make it possible to easily run WPT WebDriver web server by itself
2739         https://bugs.webkit.org/show_bug.cgi?id=197125
2740         <rdar://problem/50061468>
2741
2742         Reviewed by Darin Adler.
2743
2744         Sometimes I want to run wptserve independently of tests. Make it easier to script that
2745         using this class rather than making our own ./wpt serve invocation.
2746
2747         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:
2748         (WebDriverW3CWebServer):
2749         (WebDriverW3CWebServer.document_root): Expose this to clients.
2750         (WebDriverW3CWebServer.wait): Add a method that blocks until the server dies.
2751
2752         (WebDriverW3CWebServer.__enter__):
2753         (WebDriverW3CWebServer.__exit__):
2754         Make it possible to use the web server with a 'with' statement.
2755
2756 2019-04-20  Don Olmstead  <don.olmstead@sony.com>
2757
2758         [CMake][Win] Use target oriented design for WebKitLegacy
2759         https://bugs.webkit.org/show_bug.cgi?id=197112
2760
2761         Reviewed by Konstantin Tokarev.
2762
2763         Fix includes and libraries for DumpRenderTree after changes to WebKitLegacy targets.
2764
2765         * DumpRenderTree/CMakeLists.txt:
2766         * DumpRenderTree/PlatformWin.cmake:
2767         * DumpRenderTree/win/EventSender.cpp:
2768
2769 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
2770
2771         Update text for old EWS submit button
2772         https://bugs.webkit.org/show_bug.cgi?id=197140
2773
2774         Reviewed by Alexey Proskuryakov.
2775
2776         * QueueStatusServer/templates/statusbubble.html:
2777
2778 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
2779
2780         [ews-app] New EWS should poll bugzilla more frequently
2781         https://bugs.webkit.org/show_bug.cgi?id=197138
2782
2783         Reviewed by Alexey Proskuryakov.
2784
2785         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2786         (FetchLoop.__init__):
2787
2788 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
2789
2790         [ews-app] Submit to EWS buttons are not aligned properly with status-bubbles
2791         https://bugs.webkit.org/show_bug.cgi?id=197139
2792
2793         Reviewed by Alexey Proskuryakov.
2794
2795         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
2796         * QueueStatusServer/templates/statusbubble.html:
2797
2798 2019-04-20  Chris Dumez  <cdumez@apple.com>
2799
2800         Unreviewed, fix iOS build with recent SDKs.
2801
2802         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2803
2804 2019-04-19  Keith Miller  <keith_miller@apple.com>
2805
2806         Add script to merge run_benchmark jsons
2807         https://bugs.webkit.org/show_bug.cgi?id=197107
2808
2809         Reviewed by Michael Saboff.
2810
2811         The script basically recursively decends through all json objects until it gets
2812         to an array or JSON primitive and concats or takes the first value, respectively.
2813
2814         This patch also adds +x bits to the compare-results script so it
2815         can be run directly from the command line. I had to add a new line so that svn
2816         will accept the change... yay svn!
2817
2818         * Scripts/compare-results:
2819         * Scripts/merge-result-jsons: Added.
2820         (readJSONFile):
2821         (deepAppend):
2822         (mergeJSONs):
2823         (main):
2824
2825 2019-04-18  Ryosuke Niwa  <rniwa@webkit.org>
2826
2827         Crash in FrameLoader::stopAllLoaders via [WebView dealloc] inside ~ObjCEventListener
2828         https://bugs.webkit.org/show_bug.cgi?id=197079
2829
2830         Reviewed by Darin Adler.
2831
2832         Added a regression test. It hits a slightly different backtrace but of the same class of issues.
2833
2834         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2835         * TestWebKitAPI/Tests/WebKitLegacy/mac/DeallocWebViewInEventListener.mm: Added.
2836
2837 2019-04-18  Commit Queue  <commit-queue@webkit.org>
2838
2839         Unreviewed, rolling out r244434.
2840         https://bugs.webkit.org/show_bug.cgi?id=197089
2841
2842         caused 1 API test failure (Requested by zalan on #webkit).
2843
2844         Reverted changeset:
2845
2846         "Regression (r244291): Broken API Test
2847         AutoLayoutRenderingProgressRelativeOrdering"
2848         https://bugs.webkit.org/show_bug.cgi?id=196948
2849         https://trac.webkit.org/changeset/244434
2850
2851 2019-04-18  Wenson Hsieh  <wenson_hsieh@apple.com>
2852
2853         Add new compatibility mode API on WKNavigation
2854         https://bugs.webkit.org/show_bug.cgi?id=197069
2855         <rdar://problem/50025800>
2856
2857         Reviewed by Tim Horton.
2858
2859         Add a block property for -didCommitNavigation to TestNavigationDelegate.
2860
2861         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
2862         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
2863         (-[TestNavigationDelegate webView:didCommitNavigation:]):
2864
2865 2019-04-18  Don Olmstead  <don.olmstead@sony.com>
2866
2867         [CMake] Make WebCore headers copies
2868         https://bugs.webkit.org/show_bug.cgi?id=182512
2869         <rdar://problem/37510435>
2870
2871         Reviewed by Alex Christensen.
2872
2873         Added WebCorePrivateFrameworkHeaders as a dependency of TestWebKitAPI for all
2874         ports.
2875
2876         WebCore now uses WebCore_PRIVATE_INCLUDE_DIRECTORIES for all ports. Any includes
2877         of WebCore headers using "*.h" were modified to <WebCore/*.h>
2878
2879         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
2880         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h:
2881         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h:
2882         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h:
2883         * TestWebKitAPI/CMakeLists.txt:
2884         * TestWebKitAPI/PlatformWin.cmake:
2885         * TestWebKitAPI/Tests/WebCore/AbortableTaskQueue.cpp:
2886         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp:
2887         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2888
2889 2019-04-18  Jer Noble  <jer.noble@apple.com>
2890
2891         Add support for parsing FairPlayStreaming PSSH boxes.
2892         https://bugs.webkit.org/show_bug.cgi?id=197064
2893
2894         Reviewed by Eric Carlson.
2895
2896         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp:
2897         (TestWebKitAPI::TEST):
2898
2899 2019-04-18  Brent Fulgham  <bfulgham@apple.com>
2900
2901         InjectedBundle parameters often need initialization function called before unarchiving
2902         https://bugs.webkit.org/show_bug.cgi?id=189709
2903         <rdar://problem/44573653>
2904
2905         Reviewed by Ryosuke Niwa.
2906
2907         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
2908         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
2909
2910 2019-04-18  Zalan Bujtas  <zalan@apple.com>
2911
2912         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
2913         https://bugs.webkit.org/show_bug.cgi?id=196948
2914         <rdar://problem/49927131>
2915
2916         Reviewed by Tim Horton.
2917
2918         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
2919         (TEST): 
2920         The expected order of incoming events is
2921         1. didInvalidateIntrinsicContentSize
2922         2. didFirstLayout
2923         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
2924         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
2925         (and remember, all we care about is ordering).
2926
2927 2019-04-18  Ryan Haddad  <ryanhaddad@apple.com>
2928
2929         Unreviewed, rolling out r244299.
2930
2931         Breaks internal tests.
2932
2933         Reverted changeset:
2934
2935         "InjectedBundle parameters often need initialization function
2936         called before unarchiving"
2937         https://bugs.webkit.org/show_bug.cgi?id=189709
2938         https://trac.webkit.org/changeset/244299
2939
2940 2019-04-18  Yusuke Suzuki  <ysuzuki@apple.com>
2941
2942         [WTF] StringBuilder should set correct m_is8Bit flag when merging
2943         https://bugs.webkit.org/show_bug.cgi?id=197053
2944
2945         Reviewed by Saam Barati.
2946
2947         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2948         (TestWebKitAPI::TEST):
2949
2950 2019-04-17  Tim Horton  <timothy_horton@apple.com>
2951
2952         [iOS Sim Debug] REGRESSION (r244151) TestWebKitAPI.WebKit.OverrideViewportArguments is failing (197028)
2953         https://bugs.webkit.org/show_bug.cgi?id=197028
2954         <rdar://problem/49985290>
2955
2956         Reviewed by Wenson Hsieh.
2957
2958         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:
2959         (TEST):
2960         Liberal application of waitForNextPresentationUpdate works around a race
2961         where if the page rapidly changes its viewport arguments (or an API client
2962         rapidly changes its viewport arguments), we'd get stuck thinking that the
2963         user had intentionally zoomed the page, and stop resetting the initial scale.
2964         This deserves a separate bug, but no need to keep the test failing while
2965         we think about it.
2966
2967 2019-04-17  Tim Horton  <timothy_horton@apple.com>
2968
2969         REGRESSION (r241988): Switching tabs is slow
2970         https://bugs.webkit.org/show_bug.cgi?id=197037
2971         <rdar://problem/49951473>
2972
2973         Reviewed by Simon Fraser.
2974
2975         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2976         * TestWebKitAPI/Tests/WebKitCocoa/ReparentWebViewTimeout.mm: Added.
2977         (TEST):
2978         * TestWebKitAPI/cocoa/TestWKWebView.h:
2979         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2980         (-[TestWKWebView addToTestWindow]):
2981         Add a test that hangs without this fix.
2982
2983 2019-04-17  Truitt Savell  <tsavell@apple.com>
2984
2985         Unreviewed, rolling out r244400.
2986
2987         Caused testing to exit early with assertionon Debug WK2
2988
2989         Reverted changeset:
2990
2991         "UI↔Web deadlock when printing with a JavaScript alert
2992         visible"
2993         https://bugs.webkit.org/show_bug.cgi?id=196839
2994         https://trac.webkit.org/changeset/244400
2995
2996 2019-04-17  Brady Eidson  <beidson@apple.com>
2997
2998         Link clicks in PDFs shouldn't send referrer headers.
2999         <rdar://problem/21142581> and https://bugs.webkit.org/show_bug.cgi?id=196980
3000
3001         Reviewed by Tim Horton.
3002
3003         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3004         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm: Added.
3005         (putPDFBytesCallback):
3006         (emptyReleaseInfoCallback):
3007         (createPDFWithLinkToURL):
3008         (TEST):
3009
3010 2019-04-17  Tim Horton  <timothy_horton@apple.com>
3011
3012         UI↔Web deadlock when printing with a JavaScript alert visible
3013         https://bugs.webkit.org/show_bug.cgi?id=196839
3014         <rdar://problem/49157642>
3015
3016         Reviewed by Andy Estes.
3017
3018         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3019         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewPrintFormatter.mm: Added.
3020         (-[PrintOnAlertUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3021         (TEST):
3022
3023 2019-04-17  Alex Christensen  <achristensen@webkit.org>
3024
3025         WKRetainPtr's adoption constructor should be private
3026         https://bugs.webkit.org/show_bug.cgi?id=197019
3027
3028         Reviewed by Tim Horton.
3029
3030         * DumpRenderTree/mac/DumpRenderTree.mm:
3031         (dumpFramesAsText):
3032         * TestWebKitAPI/InjectedBundleController.cpp:
3033         (TestWebKitAPI::InjectedBundleController::initialize):
3034         * TestWebKitAPI/PlatformUtilities.cpp:
3035         (TestWebKitAPI::Util::createContextWithInjectedBundle):
3036         (TestWebKitAPI::Util::createInitializationDictionaryForInjectedBundleTest):
3037         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
3038         (TestWebKitAPI::Util::toWK):
3039         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
3040         (TestWebKitAPI::TEST):
3041         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
3042         (TestWebKitAPI::TEST):
3043         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
3044         (TestWebKitAPI::TEST):
3045         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic.cpp:
3046         (TestWebKitAPI::TEST):
3047         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic_Bundle.cpp:
3048         (TestWebKitAPI::DOMWindowExtensionBasic::initialize):
3049         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache.cpp:
3050         (TestWebKitAPI::TEST):
3051         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache_Bundle.cpp:
3052         (TestWebKitAPI::DOMWindowExtensionNoCache::initialize):
3053         * TestWebKitAPI/Tests/WebKit/DeferredViewInWindowStateChange.mm:
3054         (TestWebKitAPI::TEST):
3055         * TestWebKitAPI/Tests/WebKit/DidNotHandleKeyDown.cpp:
3056         (TestWebKitAPI::TEST):
3057         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
3058         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
3059         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash.cpp:
3060         (TestWebKitAPI::TEST):
3061         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash_Bundle.cpp:
3062         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
3063         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
3064         (TestWebKitAPI::TEST):
3065         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
3066         (TestWebKitAPI::TEST):
3067         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
3068         (TestWebKitAPI::TEST):
3069         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
3070         (TestWebKitAPI::TEST):
3071         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
3072         (TestWebKitAPI::TEST):
3073         * TestWebKitAPI/Tests/WebKit/Find.cpp:
3074         (TestWebKitAPI::TEST):
3075         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
3076         (TestWebKitAPI::TEST):
3077         * TestWebKitAPI/Tests/WebKit/FirstMeaningfulPaintMilestone.cpp:
3078         (TestWebKitAPI::TEST):
3079         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
3080         (TestWebKitAPI::TEST):
3081         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
3082         (TestWebKitAPI::TEST):
3083         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
3084         (TestWebKitAPI::TEST):
3085         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
3086         (TestWebKitAPI::TEST):
3087         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
3088         (TestWebKitAPI::TEST):
3089         * TestWebKitAPI/Tests/WebKit/GetInjectedBundleInitializationUserDataCallback.cpp:
3090         (TestWebKitAPI::TEST):
3091         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle.cpp:
3092         (TestWebKitAPI::TEST):
3093         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle_Bundle.cpp:
3094         (TestWebKitAPI::HitTestResultNodeHandleTest::getContextMenuFromDefaultMenu):
3095         * TestWebKitAPI/Tests/WebKit/InjectedBundleBasic.cpp:
3096         (TestWebKitAPI::TEST):
3097         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior.cpp:
3098         (TestWebKitAPI::TEST):
3099         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior_Bundle.cpp:
3100         (TestWebKitAPI::InjectedBundleNoDisableOverrideBuiltinsBehaviorTest::initialize):
3101         (TestWebKitAPI::InjectedBundleDisableOverrideBuiltinsBehaviorTest::initialize):
3102         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest.cpp:
3103         (TestWebKitAPI::TEST):
3104         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest_Bundle.cpp:
3105         (TestWebKitAPI::InjectedBundleFrameHitTestTest::frameLoadFinished):
3106         * TestWebKitAPI/Tests/WebKit/InjectedBundleInitializationUserDataCallbackWins.cpp:
3107         (TestWebKitAPI::TEST):
3108         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen.cpp:
3109         (TestWebKitAPI::TEST):
3110         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
3111         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
3112         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
3113         (TestWebKitAPI::TEST):
3114         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
3115         (TestWebKitAPI::loadAlternateHTMLString):
3116         (TestWebKitAPI::TEST):
3117         * TestWebKitAPI/Tests/WebKit/LoadCanceledNoServerRedirectCallback.cpp:
3118         (TestWebKitAPI::TEST):
3119         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
3120         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
3121         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
3122         (TestWebKitAPI::buildAndPerformTest):
3123         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
3124         (TestWebKitAPI::TEST):
3125         * TestWebKitAPI/Tests/WebKit/MouseMoveAfterCrash.cpp:
3126         (TestWebKitAPI::TEST):
3127         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayout.cpp:
3128         (TestWebKitAPI::TEST):
3129         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFails.cpp:
3130         (TestWebKitAPI::TEST):
3131         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
3132         (TestWebKitAPI::TEST):
3133         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
3134         (TestWebKitAPI::TEST):
3135         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
3136         (TestWebKitAPI::TEST):
3137         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
3138         (TestWebKitAPI::TEST):
3139         * TestWebKitAPI/Tests/WebKit/PasteboardNotifications.mm:
3140         (TestWebKitAPI::TEST):
3141         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
3142         (TestWebKitAPI::TEST):
3143         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
3144         (TestWebKitAPI::TEST):
3145         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
3146         (TestWebKitAPI::TEST):
3147         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
3148         (TestWebKitAPI::TEST):
3149         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
3150         (TestWebKitAPI::TEST):
3151         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
3152         (TestWebKitAPI::TEST):
3153         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
3154         (TestWebKitAPI::TEST):
3155         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
3156         (TestWebKitAPI::TEST):
3157         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
3158         (TestWebKitAPI::TEST):
3159         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
3160         (TestWebKitAPI::TEST):
3161         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
3162         (TestWebKitAPI::TEST):
3163         * TestWebKitAPI/Tests/WebKit/SpacebarScrolling.cpp:
3164         (TestWebKitAPI::TEST):
3165         * TestWebKitAPI/Tests/WebKit/StopLoadingDuringDidFailProvisionalLoad.cpp:
3166         (TestWebKitAPI::TEST):
3167         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
3168         (TestWebKitAPI::TEST):
3169         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3170         (TestWebKitAPI::TEST):
3171         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
3172         (TestWebKitAPI::TEST):
3173         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
3174         (TestWebKitAPI::TEST):
3175         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
3176         (TestWebKitAPI::TEST):
3177         * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
3178         (TestWebKitAPI::TEST):
3179         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
3180         (TestWebKitAPI::TEST):
3181         * TestWebKitAPI/Tests/WebKit/WillSendSubmitEvent.cpp:
3182         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
3183         * TestWebKitAPI/Tests/WebKit/mac/AttributedSubstringForProposedRangeWithImage.mm:
3184         (TestWebKitAPI::TEST):
3185         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuDownload.mm:
3186         (TestWebKitAPI::TEST):
3187         * TestWebKitAPI/Tests/WebKit/mac/CustomBundleParameter.mm:
3188         (TestWebKitAPI::TEST):
3189         * TestWebKitAPI/Tests/WebKit/mac/EditorCommands.mm:
3190         (TestWebKitAPI::TEST):
3191         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
3192         (TestWebKitAPI::TEST):
3193         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
3194         (TestWebKitAPI::TEST):
3195         * TestWebKitAPI/Tests/WebKit/mac/InjectedBundleAppleEvent.cpp:
3196         (TestWebKitAPI::TEST):
3197         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
3198         (TestWebKitAPI::TEST):
3199         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
3200         (TestWebKitAPI::TEST):
3201         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
3202         (TestWebKitAPI::TEST):
3203         * TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
3204         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm:
3205         (TEST):
3206         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
3207         (TEST):
3208         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3209         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3210         (TEST):
3211         * TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm:
3212         (TestWebKitAPI::TEST):
3213         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
3214         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
3215         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3216         (WTR::getMenuItemTitleCallback):
3217         (WTR::createMouseMessageBody):
3218         (WTR::EventSendingController::mouseDown):
3219         (WTR::EventSendingController::mouseUp):
3220         (WTR::EventSendingController::mouseMoveTo):
3221         (WTR::EventSendingController::mouseForceClick):
3222         (WTR::EventSendingController::startAndCancelMouseForceClick):
3223         (WTR::EventSendingController::mouseForceDown):
3224         (WTR::EventSendingController::mouseForceUp):
3225         (WTR::EventSendingController::mouseForceChanged):
3226         (WTR::EventSendingController::leapForward):
3227         (WTR::EventSendingController::scheduleAsynchronousClick):
3228         (WTR::createKeyDownMessageBody):
3229         (WTR::EventSendingController::keyDown):
3230         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
3231         (WTR::EventSendingController::mouseScrollBy):
3232         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
3233         (WTR::EventSendingController::continuousMouseScrollBy):
3234         (WTR::EventSendingController::addTouchPoint):
3235         (WTR::EventSendingController::updateTouchPoint):
3236         (WTR::EventSendingController::setTouchModifier):
3237         (WTR::EventSendingController::setTouchPointRadius):
3238         (WTR::EventSendingController::touchStart):
3239         (WTR::EventSendingController::touchMove):
3240         (WTR::EventSendingController::touchEnd):
3241         (WTR::EventSendingController::touchCancel):
3242         (WTR::EventSendingController::clearTouchPoints):
3243         (WTR::EventSendingController::releaseTouchPoint):
3244         (WTR::EventSendingController::cancelTouchPoint):
3245         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3246         (WTR::InjectedBundle::didCreatePage):
3247         (WTR::InjectedBundle::didReceiveMessage):
3248         (WTR::InjectedBundle::didReceiveMessageToPage):
3249         (WTR::InjectedBundle::booleanForKey):
3250         (WTR::InjectedBundle::done):
3251         (WTR::InjectedBundle::dumpToStdErr):
3252         (WTR::InjectedBundle::outputText):
3253         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
3254         (WTR::InjectedBundle::postAddChromeInputField):
3255         (WTR::InjectedBundle::postRemoveChromeInputField):
3256         (WTR::InjectedBundle::postFocusWebView):
3257         (WTR::InjectedBundle::postSetBackingScaleFactor):
3258         (WTR::InjectedBundle::postSetWindowIsKey):
3259         (WTR::InjectedBundle::postSetViewSize):
3260         (WTR::InjectedBundle::postSimulateWebNotificationClick):
3261         (WTR::InjectedBundle::postSetAddsVisitedLinks):
3262         (WTR::InjectedBundle::setGeolocationPermission):
3263         (WTR::InjectedBundle::setMockGeolocationPosition):
3264         (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
3265         (WTR::InjectedBundle::isGeolocationProviderActive const):
3266         (WTR::InjectedBundle::imageCountInGeneralPasteboard const):
3267         (WTR::InjectedBundle::setUserMediaPersistentPermissionForOrigin):
3268         (WTR::InjectedBundle::userMediaPermissionRequestCountForOrigin const):
3269         (WTR::InjectedBundle::resetUserMediaPermissionRequestCountForOrigin):
3270         (WTR::InjectedBundle::setCustomPolicyDelegate):
3271         (WTR::InjectedBundle::setHidden):
3272         (WTR::InjectedBundle::setCacheModel):
3273         (WTR::InjectedBundle::shouldProcessWorkQueue const):
3274         (WTR::InjectedBundle::processWorkQueue):
3275         (WTR::InjectedBundle::queueBackNavigation):
3276         (WTR::InjectedBundle::queueForwardNavigation):
3277         (WTR::InjectedBundle::queueLoad):
3278         (WTR::InjectedBundle::queueLoadHTMLString):
3279         (WTR::InjectedBundle::queueReload):
3280         (WTR::InjectedBundle::queueLoadingScript):
3281         (WTR::InjectedBundle::queueNonLoadingScript):
3282         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3283         (WTR::frameToStr):
3284         (WTR::InjectedBundlePage::InjectedBundlePage):
3285         (WTR::dumpFrameDescriptionSuitableForTestResult):
3286         (WTR::dumpFrameScrollPosition):
3287         (WTR::dumpDescendantFrameScrollPositions):
3288         (WTR::dumpFrameText):
3289         (WTR::dumpDescendantFramesText):
3290         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3291         (WTR::TestRunner::shouldDumpPixels const):
3292         (WTR::TestRunner::setDumpPixels):
3293         (WTR::TestRunner::whatToDump const):
3294         (WTR::TestRunner::setWhatToDump):
3295         (WTR::TestRunner::setWaitUntilDone):
3296         (WTR::TestRunner::shouldWaitUntilDone const):
3297         (WTR::TestRunner::setShouldDumpFrameLoadCallbacks):
3298         (WTR::TestRunner::shouldDumpFrameLoadCallbacks):
3299         (WTR::TestRunner::clearAllDatabases):
3300         (WTR::TestRunner::setIDBPerOriginQuota):
3301         (WTR::TestRunner::originsWithApplicationCache):
3302         (WTR::TestRunner::setCanOpenWindows):
3303         (WTR::TestRunner::setXSSAuditorEnabled):
3304         (WTR::TestRunner::setMediaDevicesEnabled):
3305         (WTR::TestRunner::setWebRTCMDNSICECandidatesEnabled):
3306         (WTR::TestRunner::setWebRTCUnifiedPlanEnabled):
3307         (WTR::TestRunner::setCustomUserAgent):
3308         (WTR::TestRunner::setWebAPIStatisticsEnabled):
3309         (WTR::TestRunner::setModernMediaControlsEnabled):
3310         (WTR::TestRunner::setWebGL2Enabled):
3311         (WTR::TestRunner::setWritableStreamAPIEnabled):
3312         (WTR::TestRunner::setReadableByteStreamAPIEnabled):
3313         (WTR::TestRunner::setEncryptedMediaAPIEnabled):
3314         (WTR::TestRunner::setAllowsAnySSLCertificate):
3315         (WTR::TestRunner::setPluginsEnabled):
3316         (WTR::TestRunner::setValueForUser):
3317         (WTR::TestRunner::setAudioResult):
3318         (WTR::TestRunner::didReceiveServerRedirectForProvisionalNavigation const):
3319         (WTR::TestRunner::clearDidReceiveServerRedirectForProvisionalNavigation):
3320         (WTR::TestRunner::setAlwaysAcceptCookies):
3321         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
3322         (WTR::TestRunner::isDoingMediaCapture const):
3323         (WTR::TestRunner::queueLoad):
3324         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
3325         (WTR::TestRunner::setHandlesAuthenticationChallenges):
3326         (WTR::TestRunner::setShouldLogCanAuthenticateAgainstProtectionSpace):
3327         (WTR::TestRunner::setShouldLogDownloadCallbacks):
3328         (WTR::TestRunner::setAuthenticationUsername):
3329         (WTR::TestRunner::setAuthenticationPassword):
3330         (WTR::TestRunner::secureEventInputIsEnabled const):
3331         (WTR::TestRunner::setBlockAllPlugins):
3332         (WTR::TestRunner::setPluginSupportedMode):
3333         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
3334         (WTR::TestRunner::setShouldDecideResponsePolicyAfterDelay):
3335         (WTR::TestRunner::setNavigationGesturesEnabled):
3336         (WTR::TestRunner::setIgnoresViewportScaleLimits):
3337         (WTR::TestRunner::setShouldDownloadUndisplayableMIMETypes):
3338         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
3339         (WTR::TestRunner::terminateNetworkProcess):
3340         (WTR::TestRunner::terminateServiceWorkerProcess):
3341         (WTR::TestRunner::runUIScript):
3342         (WTR::TestRunner::setStatisticsDebugMode):
3343         (WTR::TestRunner::setStatisticsPrevalentResourceForDebugMode):
3344         (WTR::TestRunner::setStatisticsLastSeen):
3345         (WTR::TestRunner::setStatisticsPrevalentResource):
3346         (WTR::TestRunner::setStatisticsVeryPrevalentResource):
3347         (WTR::TestRunner::dumpResourceLoadStatistics):
3348         (WTR::TestRunner::isStatisticsPrevalentResource):
3349         (WTR::TestRunner::isStatisticsVeryPrevalentResource):
3350         (WTR::TestRunner::isStatisticsRegisteredAsSubresourceUnder):
3351         (WTR::TestRunner::isStatisticsRegisteredAsSubFrameUnder):
3352         (WTR::TestRunner::isStatisticsRegisteredAsRedirectingTo):
3353         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
3354         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
3355         (WTR::TestRunner::setStatisticsGrandfathered):
3356         (WTR::TestRunner::isStatisticsGrandfathered):
3357         (WTR::TestRunner::setStatisticsSubframeUnderTopFrameOrigin):
3358         (WTR::TestRunner::setStatisticsSubresourceUnderTopFrameOrigin):
3359         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectTo):
3360         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectFrom):
3361         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectTo):
3362         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectFrom):
3363         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
3364         (WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
3365         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
3366         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
3367         (WTR::TestRunner::statisticsUpdateCookieBlocking):
3368         (WTR::TestRunner::statisticsSubmitTelemetry):
3369         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
3370         (WTR::TestRunner::setStatisticsIsRunningTest):
3371         (WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
3372         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
3373         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
3374         (WTR::TestRunner::setStatisticsGrandfatheringTime):
3375         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
3376         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
3377         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
3378         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
3379         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
3380         (WTR::TestRunner::statisticsDeleteCookiesForHost):
3381         (WTR::TestRunner::setStatisticsCacheMaxAgeCap):
3382         (WTR::TestRunner::statisticsResetToConsistentState):
3383         (WTR::TestRunner::setStorageAccessAPIEnabled):
3384         (WTR::TestRunner::getAllStorageAccessEntries):
3385         (WTR::TestRunner::addMockMediaDevice):
3386         (WTR::TestRunner::clearMockMediaDevices):
3387         (WTR::TestRunner::removeMockMediaDevice):
3388         (WTR::TestRunner::resetMockMediaDevices):
3389         (WTR::TestRunner::connectMockGamepad):
3390         (WTR::TestRunner::disconnectMockGamepad):
3391         (WTR::TestRunner::setMockGamepadDetails):
3392         (WTR::TestRunner::setMockGamepadAxisValue):
3393         (WTR::TestRunner::setMockGamepadButtonValue):
3394         (WTR::TestRunner::removeAllSessionCredentials):
3395         (WTR::TestRunner::clearDOMCache):
3396         (WTR::TestRunner::clearDOMCaches):
3397         (WTR::TestRunner::hasDOMCache):
3398         (WTR::TestRunner::domCacheSize):
3399         (WTR::TestRunner::setAllowStorageQuotaIncrease):
3400         (WTR::TestRunner::getApplicationManifestThen):
3401         (WTR::TestRunner::injectUserScript):
3402         (WTR::TestRunner::sendDisplayConfigurationChangedMessageForTesting):
3403         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
3404         (WTR::TestRunner::addTestKeyToKeychain):
3405         (WTR::TestRunner::cleanUpKeychain):
3406         (WTR::TestRunner::keyExistsInKeychain):
3407         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
3408         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
3409         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
3410         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
3411         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
3412         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
3413         * WebKitTestRunner/TestController.cpp:
3414         (WTR::TestController::initialize):
3415         (WTR::parseStringTestHeaderValueAsRelativePath):
3416         (WTR::updateTestOptionsFromTestHeader):
3417         (WTR::TestController::runTest):
3418         (WTR::TestController::didReceiveLiveDocumentsList):
3419         (WTR::TestController::didReceiveMessageFromInjectedBundle):
3420         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
3421         (WTR::TestController::didFinishNavigation):
3422         (WTR::TestController::didReceiveAuthenticationChallenge):
3423         * WebKitTestRunner/TestInvocation.cpp:
3424         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3425         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3426         (WTR::TestInvocation::uiScriptDidComplete):
3427         (WTR::TestInvocation::didReceiveAllStorageAccessEntries):
3428         * WebKitTestRunner/WebNotificationProvider.cpp:
3429         (WTR::WebNotificationProvider::closeWebNotification):
3430         * WebKitTestRunner/WorkQueueManager.cpp:
3431         (WTR::ScriptItem::ScriptItem):
3432         (WTR::WorkQueueManager::queueLoad):
3433         (WTR::WorkQueueManager::queueLoadHTMLString):
3434
3435 2019-04-17  Alex Christensen  <achristensen@webkit.org>
3436
3437         Add a comment to make my test from r244139 less mysterious.
3438         https://bugs.webkit.org/show_bug.cgi?id=196744
3439
3440         As suggested by Darin Adler.
3441
3442         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
3443         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
3444
3445 2019-04-17  Chris Dumez  <cdumez@apple.com>
3446
3447         Remember device orientation permission for the duration of the browsing session
3448         https://bugs.webkit.org/show_bug.cgi?id=196992
3449         <rdar://problem/49946067>
3450
3451         Reviewed by Alex Christensen.
3452
3453         Add API test coverage.
3454
3455         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
3456         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3457         (TEST):
3458
3459 2019-04-17  Aakash Jain  <aakash_jain@apple.com>
3460
3461         [ews-app] Clicking 'submit to new ews' doesn't reload status-bubble
3462         https://bugs.webkit.org/show_bug.cgi?id=196675
3463
3464         Reviewed by Lucas Forschler.
3465
3466         * BuildSlaveSupport/ews-app/ews/views/submittoews.py:
3467         (SubmitToEWS): Added @xframe_options_exempt similar to statusbubble.py
3468
3469 2019-04-16  Wenson Hsieh  <wenson_hsieh@apple.com>
3470
3471         [iOS] [WebKit2] Add support for honoring -[UIMenuItem dontDismiss]
3472         https://bugs.webkit.org/show_bug.cgi?id=196919
3473         <rdar://problem/41630459>
3474
3475         Reviewed by Tim Horton.
3476
3477         Add iOS support for several new testing hooks. See below for more detail.
3478
3479         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3480         (WTR::UIScriptController::isDismissingMenu const):
3481
3482         Add a new script controller method to query whether the platform menu (on iOS, the callout bar) is done
3483         dismissing. We consider the menu to be dismissing in between the `-WillHide` and `-DidHide` notifications sent
3484         by UIKit when dismissing the callout bar (i.e. UIMenuController).
3485
3486         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3487         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3488         (WTR::UIScriptController::isDismissingMenu const):
3489         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3490         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3491         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3492         (WTR::InjectedBundle::didReceiveMessageToPage):
3493         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3494         (WTR::TestRunner::setAllowedMenuActions):
3495
3496         Add a new helper method to specify a list of allowed actions when bringing up the menu. On iOS, in the case of
3497         actions supported by the platform, this matches against method selector names (for instance, "SelectAll", or
3498         "Copy", or "Paste"). In the case of the custom actions installed via `installCustomMenuAction`, we instead match
3499         against the name of the custom action.
3500
3501         (WTR::TestRunner::installCustomMenuAction):
3502
3503         Add a new helper method to install a custom action for the context menu (on iOS, this is the callout bar). This
3504         takes the name of the action (which appears in a button in the callout bar), whether the action should cause
3505         the callout bar to automatically dismiss, and finally, a JavaScript callback that is invoked when the action is
3506         triggered.
3507
3508         (WTR::TestRunner::performCustomMenuAction):
3509
3510         Invoked when the custom menu action is triggered.
3511
3512         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3513         * WebKitTestRunner/TestController.cpp:
3514         (WTR::TestController::installCustomMenuAction):
3515         (WTR::TestController::setAllowedMenuActions):
3516         * WebKitTestRunner/TestController.h:
3517         * WebKitTestRunner/TestInvocation.cpp:
3518         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3519         (WTR::TestInvocation::performCustomMenuAction):
3520
3521         Add plumbing to call back into the injected bundle when performing the custom action.
3522
3523         * WebKitTestRunner/TestInvocation.h:
3524         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3525         (WTR::TestController::installCustomMenuAction):
3526         (WTR::TestController::setAllowedMenuActions):
3527         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3528         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3529         (-[TestRunnerWKWebView initWithFrame:configuration:]):
3530         (-[TestRunnerWKWebView becomeFirstResponder]):
3531         (-[TestRunnerWKWebView _addCustomItemToMenuControllerIfNecessary]):
3532
3533         Helper method that converts web view's current custom menu action info into a UIMenuItem, and adds it to the
3534         shared menu controller. This is also invoked when the web view becomes first responder, which matches behavior
3535         in the Mail app on iOS.
3536
3537         (-[TestRunnerWKWebView installCustomMenuAction:dismissesAutomatically:callback:]):
3538         (-[TestRunnerWKWebView setAllowedMenuActions:]):
3539         (-[TestRunnerWKWebView resetCustomMenuAction]):
3540         (-[TestRunnerWKWebView performCustomAction:]):
3541         (-[TestRunnerWKWebView canPerformAction:withSender:]):
3542         (-[TestRunnerWKWebView _willHideMenu]):
3543         (-[TestRunnerWKWebView _didHideMenu]):
3544         * WebKitTestRunner/ios/TestControllerIOS.mm:
3545         (WTR::TestController::platformResetStateToConsistentValues):
3546
3547         Reset both any custom installed actions on the shared menu controller, as well as the list of allowed actions,
3548         if specified.
3549
3550         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3551         (WTR::UIScriptController::isDismissingMenu const):
3552
3553 2019-04-16  Megan Gardner  <megan_gardner@apple.com>
3554
3555         Allow sharing from imageSheet on an image document
3556         https://bugs.webkit.org/show_bug.cgi?id=196891
3557         <rdar://problem/25377386>
3558
3559         Reviewed by Tim Horton.
3560
3561         Test to make sure that the correct imageURL is extracted from an image element.
3562
3563         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
3564         (TestWebKitAPI::TEST):
3565
3566 2019-04-16  Alex Christensen  <achristensen@webkit.org>
3567
3568         REGRESSION(r244162) Clearing website data from ephemeral WKWebsiteDataStore should finish instead of asserting or hanging
3569         https://bugs.webkit.org/show_bug.cgi?id=196995
3570
3571         Reviewed by Brady Eidson.
3572
3573         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
3574         (TEST):
3575
3576 2019-04-16  Chris Dumez  <cdumez@apple.com>
3577
3578         URL set by document.open() is not communicated to the UIProcess
3579         https://bugs.webkit.org/show_bug.cgi?id=196941
3580         <rdar://problem/49237544>
3581
3582         Reviewed by Geoff Garen.
3583
3584         Add API test coverage.
3585
3586         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3587         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
3588         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
3589         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3590         (TEST):
3591
3592 2019-04-16  Commit Queue  <commit-queue@webkit.org>
3593
3594         Unreviewed, rolling out r244321.
3595         https://bugs.webkit.org/show_bug.cgi?id=196968
3596
3597         Causing all WK2 Debug builds to exit early after Assertion
3598         failures. (Requested by ShawnRoberts on #webkit).
3599
3600         Reverted changeset:
3601
3602         "URL set by document.open() is not communicated to the
3603         UIProcess"
3604         https://bugs.webkit.org/show_bug.cgi?id=196941
3605         https://trac.webkit.org/changeset/244321
3606
3607 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
3608
3609         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
3610         https://bugs.webkit.org/show_bug.cgi?id=196948
3611
3612         Reviewed by Zalan Bujtas.
3613
3614         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
3615         (TEST): Disabling the test for now to keep infrastructure happy, while the root-cause is being investigated.
3616
3617 2019-04-15  Chris Dumez  <cdumez@apple.com>
3618
3619         URL set by document.open() is not communicated to the UIProcess
3620         https://bugs.webkit.org/show_bug.cgi?id=196941
3621         <rdar://problem/49237544>
3622
3623         Reviewed by Geoffrey Garen.
3624
3625         Add API test coverage.
3626
3627         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3628         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
3629         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
3630         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3631         (TEST):
3632
3633 2019-04-15  Dean Johnson  <dean_johnson@apple.com>
3634
3635         Using Tools/Scripts/clean-webkit should not install requests
3636         https://bugs.webkit.org/show_bug.cgi?id=196940
3637
3638         Reviewed by Lucas Forschler.
3639
3640         * Scripts/webkitpy/common/system/autoinstall.py: Drive-by fix for no logging handlers
3641         existing, depending on the path autoinstalled is run through.
3642         * Scripts/webkitpy/port/base.py: Import webkitpy.results.upload.Upload only where it's
3643         needed.
3644         (Port.configuration_for_upload):
3645         (Port.commits_for_upload):
3646
3647 2019-04-15  Alex Christensen  <achristensen@webkit.org>
3648
3649         Add a DiagnosticLogging method taking an arbitrary dictionary of values.
3650         https://bugs.webkit.org/show_bug.cgi?id=196773
3651
3652         Reviewed by Jer Noble.
3653
3654         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDiagnosticLogging.mm:
3655         (-[TestLoggingDelegate _webView:logDiagnosticMessage:description:valueDictionary:]):
3656         (TEST):
3657
3658 2019-04-15  Aakash Jain  <aakash_jain@apple.com>