Dashboard Cleanup: Do not generate the page if we are about to reload.
[WebKit-https.git] / Tools / ChangeLog
1 2013-01-10  Julie Parent  <jparent@chromium.org>
2
3         Dashboard Cleanup: Do not generate the page if we are about to reload.
4         https://bugs.webkit.org/show_bug.cgi?id=106584
5
6         Reviewed by Dirk Pranke.
7
8         Move the logic to determine if we should generate the page into
9         parseParameters() since that is where we have the knowledge to
10         determine it, and return that value to handleLocationChange, 
11         rather than passing the changed parameters back to handleLocationChange
12         and having it make the decision.
13         
14         This is logically equivalent, save one case: when we are about to do
15         a reload, we know that there is no reason to generate the page.  Old
16         code was causing an extra page generation in this case.
17         
18         * TestResultServer/static-dashboards/dashboard_base.js:
19         (parseParameters):
20         (handleLocationChange):
21
22 2013-01-10  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
23
24         [jhbuild] Use the "configure" script to build glib
25         https://bugs.webkit.org/show_bug.cgi?id=106569
26
27         Reviewed by Martin Robinson.
28
29         So far both EFL and GTK have been using autogen.sh to build glib.
30         While that does work most of the time, it's not really needed since
31         we are downloading and building stable releases from tarballs.
32         Additionally, autogen.sh fails to work with automake 1.13 due to the
33         usage of some macros that have been removed (this has already been
34         fixed in glib master).
35
36         * efl/jhbuild.modules:
37         * gtk/jhbuild.modules:
38
39 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
40
41         Changing tests to be consistent and use self.scm rather then recreating the scm object.
42         (Missed a couple)
43         https://bugs.webkit.org/show_bug.cgi?id=106536
44
45         Reviewed by Eric Seidel.
46
47         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
48
49 2013-01-10  Tony Chang  <tony@chromium.org>
50
51         Speed up supplemental dependency computation
52         https://bugs.webkit.org/show_bug.cgi?id=106503
53
54         Reviewed by Adam Barth.
55
56         Pass the IDL attributes file for generating the bindings in WebKitTestRunner.
57
58         * WebKitTestRunner/CMakeLists.txt:
59
60 2013-01-10  Zan Dobersek  <zandobersek@gmail.com>
61
62         Remove the ENABLE_ANIMATION_API feature define occurences
63         https://bugs.webkit.org/show_bug.cgi?id=106544
64
65         Reviewed by Simon Fraser.
66
67         The Animation API code was removed in r137243. The ENABLE_ANIMATION_API
68         feature define handling still lingers in various build systems and configurations
69         but is of no use, so it should be removed.
70
71         * Scripts/webkitperl/FeatureList.pm:
72         * qmake/mkspecs/features/features.pri:
73
74 2013-01-10  Carlos Garcia Campos  <cgarcia@igalia.com>
75
76         [GTK] Add support for loading web process extensions
77         https://bugs.webkit.org/show_bug.cgi?id=105631
78
79         Reviewed by Gustavo Noronha Silva.
80
81         * MiniBrowser/gtk/GNUmakefile.am:
82         * MiniBrowser/gtk/main.c:
83         (main): Set WEBKIT_INJECTED_BUNDLE env var to use the injected
84         bundle lib from build dir.
85         * Scripts/webkitpy/style/checker.py: Add exceptions for GTK+ API
86         located in WebProcess/InjectedBundle/API/gtk.
87         * gtk/generate-gtkdoc:
88         (get_webkit2_options): Scan also files in
89         WebProcess/InjectedBundle/API/gtk to generate API docs.
90         (get_webkit2_options.injected_bundle_src_path): Helper function to
91         build paths in WebProcess/InjectedBundle/API/gtk.
92
93 2013-01-10  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
94
95         [EFL][WK2] Writing immediately to created windows (open) fails
96         https://bugs.webkit.org/show_bug.cgi?id=105276
97
98         Reviewed by Kenneth Rohde Christiansen.
99
100         Do not reset 'about:blank' url for the new pages in mini browser.
101
102         * MiniBrowser/efl/main.c:
103         (window_create):
104
105 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
106
107         Changing tests to be consistent and use self.scm rather then recreating the scm object.
108         https://bugs.webkit.org/show_bug.cgi?id=106536
109
110         Reviewed by Eric Seidel.
111
112         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
113
114 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
115
116         Converting to unittest2 so we can use assertItemsEqual, making tests
117         not dependent on order of items.
118         https://bugs.webkit.org/show_bug.cgi?id=106532
119
120         Before:
121         Ran 1733 tests in 38.385s
122         FAILED (failures=1, errors=22)
123
124         After:
125         Ran 1733 tests in 32.298s
126         FAILED (failures=0, errors=22)
127
128         Reviewed by Eric Seidel.
129
130         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
131         * Scripts/webkitpy/thirdparty/__init__.py:
132         (AutoinstallImportHook._install_unittest2):
133
134 2013-01-10  Christophe Dumez  <christophe.dumez@intel.com>
135
136         [EFL] Add gstreamer 1.0.5 to jhbuild
137         https://bugs.webkit.org/show_bug.cgi?id=106178
138
139         Reviewed by Laszlo Gombos.
140
141         Add gstreamer 1.0.5 to EFL's jhbuild configuration.
142
143         * efl/jhbuild.modules:
144
145 2013-01-09  Alan Cutter  <alancutter@chromium.org>
146
147         Updated parameters in GCE build scripts so they now work.
148         https://bugs.webkit.org/show_bug.cgi?id=106523
149
150         Reviewed by Adam Barth.
151
152         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
153         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
154         * EWSTools/cold-boot.sh:
155
156 2013-01-09  Mark Pilgrim  <pilgrim@chromium.org>
157
158         [Chromium] Remove some stray references to WebKitPlatformSupport.h in DumpRenderTree
159         https://bugs.webkit.org/show_bug.cgi?id=106520
160
161         Reviewed by James Robinson.
162
163         Part of a larger refactoring series. See tracking bug 82948.
164
165         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
166         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
167
168 2013-01-09  Julie Parent  <jparent@chromium.org>
169
170         Dashboard cleanup: Remove code for currentState and window.location.hash getting out of state
171         https://bugs.webkit.org/show_bug.cgi?id=106514
172
173         This is old code, as these can no longer get out of sync.
174         permmaLinkURLHash is generated from currentState, which is set only
175         from the location.  The commment about how these can get out of sync
176         refers to a function that no longer exists.
177         
178         Reviewed by Dirk Pranke.
179
180         * TestResultServer/static-dashboards/dashboard_base.js:
181         (handleLocationChange):
182
183 2013-01-09  Julie Parent  <jparent@chromium.org>
184
185         Dashboard Cleanup: Reload the page as soon as we know we need to.
186         https://bugs.webkit.org/show_bug.cgi?id=106515
187
188         No need to continue parsing all of the data once we know that
189         we need to do a reload.
190         
191         Reviewed by Dirk Pranke.
192
193         * TestResultServer/static-dashboards/dashboard_base.js:
194         (parseParameters):
195
196 2013-01-09  Eric Seidel  <eric@webkit.org>
197
198         run-perf-tests --chromium-android --profile should show symbols for the kernel
199         https://bugs.webkit.org/show_bug.cgi?id=106498
200
201         Reviewed by Adam Barth.
202
203         Turns out this was easy, once I finally read the output from "perf report".
204         It appears there may be a bug in "perf record" on android, as it complains
205         about not being able to read from /proc/kallsyms even when
206         /proc/sys/kernel/kptr_restrict is 0.  For now I've not bothered
207         to keep /proc/sys/kernel/kptr_restrict as 0 during the actual record
208         but rather just flip it to 0 long enough to grab the /proc/kallsyms
209         and then flip it back to whatever the device had.
210
211         /proc/sys/kernel/kptr_restrict controls what /proc/kallsyms returns
212         on Linux.  /proc/kallsyms contains a mapping of kernel addresses
213         to symbol names.  Its world-readable, but will return all 0s if you
214         don't have permission to see the kernel symbols.  kptr_restrict
215         supports values 0, 1, 2.  Where 0 means "everyone can see the real symbols"
216         1 is only a specific group, and 2 is "no one, not even root".
217         By default kptr_restrict is 2 on Android it seems.
218         More kptr_restrict docs: http://lwn.net/Articles/420403/
219
220         I also took this opportunity to clean up how the perf record command
221         was built for use/display in AndroidPerf.profile_after_exit and
222         change to always using long-form names for the arguments (to hopefully help readability).
223
224         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
225         (AndroidPerf.__init__):
226         (profile_after_exit):
227         (ChromiumAndroidDriver.__init__):
228         (ChromiumAndroidDriver._update_kallsyms_cache):
229         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
230
231 2013-01-09  Julie Parent  <jparent@chromium.org>
232
233         Dashboard cleanup: remove dead code.
234         https://bugs.webkit.org/show_bug.cgi?id=106509
235
236         Reviewed by Dirk Pranke.
237
238         * TestResultServer/static-dashboards/dashboard_base.js:
239         (parseParameters):
240
241 2013-01-09  Joanmarie Diggs  <jdiggs@igalia.com>
242
243         [GTK] accessibility/aria-labelledby-overrides-label.html requires a proper baseline
244         https://bugs.webkit.org/show_bug.cgi?id=105638
245
246         Reviewed by Martin Robinson.
247
248         The test was failing for two reasons:
249         - AccessibilityRenderObject::correspondingLabelForControlElement() was
250           not ignoring the ARIA labelled-by property
251         - AccessibilityController::accessibleElementById() was not implemented
252
253         Because getting an element by ID cannot be done in the UIProcess, the
254         decision was made to expose the element's ID as an accessible attribute
255         of the object.
256
257         In addition, fixing the bug in AccessibilityRenderObject made it possible
258         to eliminate the Gtk platform-specific expectations for another test.
259
260         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
261         (childElementById): Added. Walks the tree looking for the AtkObject
262         Attribute which exposes the HTML element's ID.
263         (AccessibilityController::accessibleElementById): Implemented.
264         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
265         (AccessibilityUIElement::title): Modified to print out "AXTitle: " even
266         when there is no title, as is done with the Mac port.
267         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
268         (WTR):
269         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
270         (WTR::childElementById): Added. Walks the tree looking for the AtkObject
271         Attribute which exposes the HTML element's ID.
272         (WTR):
273         (WTR::AccessibilityController::accessibleElementById): Implemented.
274         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
275         (WTR::AccessibilityUIElement::title): Modified to print out "AXTitle: "
276         even when there is no title, as is done with the Mac port.
277
278 2013-01-09  Gregg Tavares  <gman@google.com>
279
280         Add Gregg Tavares as a committer
281         https://bugs.webkit.org/show_bug.cgi?id=106492
282
283         Unreviewed.
284
285         * Scripts/webkitpy/common/config/committers.py:
286
287 2013-01-09  Roger Fong  <roger_fong@apple.com>
288
289         Enable seamless iFrames for Windows DRT.
290         https://bugs.webkit.org/show_bug.cgi?id=106468.
291
292         Rubberstamped by Timothy Horton.
293
294         * DumpRenderTree/win/DumpRenderTree.cpp:
295         (resetDefaultsToConsistentValues):
296
297 2013-01-09  Christophe Dumez  <christophe.dumez@intel.com>
298
299         [WK2] Implement eventSender.scheduleAsynchronousKeyDown
300         https://bugs.webkit.org/show_bug.cgi?id=93979
301
302         Reviewed by Benjamin Poulain.
303
304         Implement eventSender.scheduleAsynchronousKeyDown() in
305         WebKitTestRunner.
306
307         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
308         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
309         (WTR::createKeyDownMessageBody):
310         (WTR::EventSendingController::keyDown):
311         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
312         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
313         (EventSendingController):
314         * WebKitTestRunner/TestController.cpp:
315         (WTR::TestController::didReceiveKeyDownMessageFromInjectedBundle):
316         (WTR::TestController::didReceiveMessageFromInjectedBundle):
317         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
318         * WebKitTestRunner/TestController.h:
319         (TestController):
320
321 2013-01-09  Jochen Eisinger  <jochen@chromium.org>
322
323         [chromium] move resource load callback dumping to TestRunner library
324         https://bugs.webkit.org/show_bug.cgi?id=106449
325
326         Reviewed by Adam Barth.
327
328         * DumpRenderTree/chromium/DRTTestRunner.cpp:
329         (DRTTestRunner::DRTTestRunner):
330         (DRTTestRunner::reset):
331         * DumpRenderTree/chromium/DRTTestRunner.h:
332         (DRTTestRunner):
333         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
334         (WebKit):
335         (WebTestRunner::WebTestDelegate::makeURLErrorDescription):
336         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
337         (WebKit):
338         (WebTestProxyBase):
339         (WebTestRunner::WebTestProxy::assignIdentifierToRequest):
340         (WebTestRunner::WebTestProxy::willRequestResource):
341         (WebTestRunner::WebTestProxy::willSendRequest):
342         (WebTestRunner::WebTestProxy::didReceiveResponse):
343         (WebTestRunner::WebTestProxy::didFinishResourceLoad):
344         (WebTestRunner::WebTestProxy::didFailResourceLoad):
345         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
346         (WebTestRunner::WebTestRunner::shouldDumpResourceLoadCallbacks):
347         (WebTestRunner::WebTestRunner::shouldDumpResourceRequestCallbacks):
348         (WebTestRunner::WebTestRunner::shouldDumpResourceResponseMIMETypes):
349         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
350         (WebTestRunner::TestRunner::TestRunner):
351         (WebTestRunner::TestRunner::reset):
352         (WebTestRunner::TestRunner::shouldDumpResourceLoadCallbacks):
353         (WebTestRunner::TestRunner::shouldDumpResourceRequestCallbacks):
354         (WebTestRunner::TestRunner::shouldDumpResourceResponseMIMETypes):
355         (WebTestRunner):
356         (WebTestRunner::TestRunner::dumpResourceLoadCallbacks):
357         (WebTestRunner::TestRunner::dumpResourceRequestCallbacks):
358         (WebTestRunner::TestRunner::dumpResourceResponseMIMETypes):
359         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
360         (TestRunner):
361         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
362         (WebTestRunner::WebTestProxyBase::reset):
363         (WebTestRunner):
364         (WebTestRunner::WebTestProxyBase::assignIdentifierToRequest):
365         (WebTestRunner::WebTestProxyBase::willRequestResource):
366         (WebTestRunner::WebTestProxyBase::willSendRequest):
367         (WebTestRunner::WebTestProxyBase::didReceiveResponse):
368         (WebTestRunner::WebTestProxyBase::didFinishResourceLoad):
369         (WebTestRunner::WebTestProxyBase::didFailResourceLoad):
370         * DumpRenderTree/chromium/WebViewHost.cpp:
371         (WebViewHost::willSendRequest):
372         (WebViewHost::makeURLErrorDescription):
373         (WebViewHost::reset):
374         * DumpRenderTree/chromium/WebViewHost.h:
375         (WebViewHost):
376
377 2013-01-09  Dan Carney  <dcarney@google.com>
378
379         [chromium] move dumpcreateview methods to testrunner library
380         https://bugs.webkit.org/show_bug.cgi?id=106434
381
382         Reviewed by Adam Barth.
383
384         * DumpRenderTree/chromium/DRTTestRunner.cpp:
385         (DRTTestRunner::DRTTestRunner):
386         (DRTTestRunner::reset):
387         * DumpRenderTree/chromium/DRTTestRunner.h:
388         (DRTTestRunner):
389         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
390         (WebTestRunner::WebTestRunner::shouldDumpCreateView):
391         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
392         (WebTestRunner::TestRunner::TestRunner):
393         (WebTestRunner::TestRunner::reset):
394         (WebTestRunner::TestRunner::shouldDumpCreateView):
395         (WebTestRunner):
396         (WebTestRunner::TestRunner::dumpCreateView):
397         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
398         (TestRunner):
399
400 2013-01-09  Csaba Osztrogonác  <ossy@webkit.org>
401
402         webkitpy cleanup: Merge additional_comment_text into comment_text
403         https://bugs.webkit.org/show_bug.cgi?id=106421
404
405         Reviewed by Adam Barth.
406
407         * Scripts/webkitpy/common/config/committervalidator.py:
408         (CommitterValidator.reject_patch_from_commit_queue):
409         (CommitterValidator.reject_patch_from_review_queue):
410         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
411         (Bugzilla.set_flag_on_attachment):
412         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
413         (MockBugzilla.set_flag_on_attachment):
414         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
415         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
416         (AbstractEarlyWarningSystem._post_reject_message_on_bug):
417         * Scripts/webkitpy/tool/commands/queues_unittest.py:
418
419 2013-01-09  Mario Sanchez Prada  <mario.prada@samsung.com>
420
421         [GTK] Raise version of gdk-pixbuf in jhbuild up to 2.26.5
422         https://bugs.webkit.org/show_bug.cgi?id=106464
423
424         Reviewed by Martin Robinson.
425
426         Current version in jhbuild.modules (2.26.0) is giving trouble to
427         when trying to build WebKitGTK from scratch, due to a segmentation
428         fault error in gdk-pixbuf-query-loader during the 'make'
429         phase. Raising the version to 2.26.5 fixes this issue.
430
431         * gtk/jhbuild.modules: Version raised, checksums updated.
432
433 2013-01-09  János Badics  <jbadics@inf.u-szeged.hu>
434
435         [Qt][NRWT] Pass --timeout to DRT/WTR if a test is marked as SLOW.
436         https://bugs.webkit.org/show_bug.cgi?id=90968.
437
438         Reviewed by Csaba Osztrogonác.
439
440         Added functionality in DRT and WTR to use any timeout value while running
441         slow tests (eventually, any test). Now NRWT --time-out-ms determines the
442         timeout value for the test. Added a flag in NRWT (supports_per_test_timeout)
443         to indicate whether the current port supports setting timeout value
444         per test (it's False by default; I enabled it only on Qt).
445         Also corrected a typo in driver.py
446
447         * DumpRenderTree/DumpRenderTree.h:
448         (TestCommand::TestCommand):
449         (TestCommand):
450         * DumpRenderTree/DumpRenderTreeCommon.cpp:
451         (parseInputLine):
452         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
453         (WebCore::DumpRenderTree::processLine):
454         * Scripts/webkitpy/layout_tests/port/base.py:
455         (Port.supports_per_test_timeout):
456         * Scripts/webkitpy/layout_tests/port/driver.py:
457         (Driver.run_test):
458         (Driver._command_from_driver_input):
459         * Scripts/webkitpy/layout_tests/port/qt.py:
460         (QtPort.supports_per_test_timeout):
461         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
462         (WTR::InjectedBundle::InjectedBundle):
463         (WTR::InjectedBundle::didReceiveMessage):
464         (WTR::InjectedBundle::beginTesting):
465         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
466         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
467         (WTR::TestRunner::setCustomTimeout):
468         (WTR):
469         * WebKitTestRunner/InjectedBundle/TestRunner.h:
470         (TestRunner):
471         * WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp:
472         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
473         * WebKitTestRunner/TestController.cpp:
474         (WTR::TestController::TestController):
475         (WTR::TestController::getCustomTimeout):
476         (WTR):
477         (WTR::TestCommand::TestCommand):
478         (TestCommand):
479         (WTR::parseInputLine):
480         (WTR::TestController::runTest):
481         (WTR::TestController::runUntil):
482         * WebKitTestRunner/TestController.h:
483         (TestController):
484         * WebKitTestRunner/TestInvocation.cpp:
485         (WTR::TestInvocation::TestInvocation):
486         (WTR::TestInvocation::setCustomTimeout):
487         (WTR):
488         (WTR::TestInvocation::invoke):
489         * WebKitTestRunner/TestInvocation.h:
490         (TestInvocation):
491
492 2013-01-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
493
494         Regression(r138681): Add HAVE(ACCESSIBILITY) guard to atk files
495         https://bugs.webkit.org/show_bug.cgi?id=106290
496
497         Reviewed by Martin Robinson.
498
499         Some atk files don't use HAVE(ACCESSIBILITY). It might make build errors when
500         the macro isn't enabled.
501
502         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
503
504 2013-01-08  Martin Robinson  <mrobinson@igalia.com>
505
506         WebKitTestRunner needs support for setHandlesAuthenticationChallenges
507         https://bugs.webkit.org/show_bug.cgi?id=103653
508
509         Reviewed by Anders Carlsson.
510
511         Implement setHandlesAuthenticationChallenges in the UIProcess by sending credentials
512         and the enabled boolean to the UIProcess and then implementing the didReceiveAuthenticationChallengeInFrame
513         client callback.
514
515         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Exposed the new TestRunner
516         methods to the JavaScript API.
517         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
518         (WTR::TestRunner::setHandlesAuthenticationChallenges): Added this callback for the JavaScript API.
519         (WTR::TestRunner::setAuthenticationUsername): Ditto.
520         (WTR::TestRunner::setAuthenticationPassword): Ditto.
521         * WebKitTestRunner/InjectedBundle/TestRunner.h:
522         (TestRunner): Added new declarations for the above.
523         * WebKitTestRunner/TestController.cpp:
524         (WTR::TestController::createWebViewWithOptions): Hook up the new didReceiveSynchronousMessageFromInjectedBundle
525         callback.
526         (WTR::TestController::resetStateToConsistentValues): Reset the credentials and enabled boolean between tests.
527         (WTR::TestController::didReceiveAuthenticationChallengeInFrame): Handle the callback by using
528         the authentication information passed from the InjectedBundle.
529         * WebKitTestRunner/TestController.h:
530         (WTR::TestController::setHandlesAuthenticationChallenges): Added setter to allow TestInvocation
531         to communicate with the TestController.
532         (WTR::TestController::setAuthenticationUsername): Ditto.
533         (WTR::TestController::setAuthenticationPassword): Ditto.
534         (TestController):
535         * WebKitTestRunner/TestInvocation.cpp:
536         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Handle the messages sending authentication
537         information from the InjectedBundle.
538         (WTR::TestInvocation::outputText): Added this method so that the TestController can output
539         text to the TestInvocation text output.
540         * WebKitTestRunner/TestInvocation.h:
541         (TestInvocation): Added declaration for new method.
542
543 2013-01-08  Benjamin Poulain  <benjamin@webkit.org>
544
545         Add myself as a watcher for Web Geolocation
546
547         Unreviewed.
548
549         * Scripts/webkitpy/common/config/watchlist:
550
551 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
552
553         [webkitpy] Call setup_test_run method of the parent Port interface when method is called on subclasses
554         https://bugs.webkit.org/show_bug.cgi?id=106364
555
556         Reviewed by Eric Seidel.
557
558         When the setup_test_run method is called on the subclasses of the base Port
559         interface, the parent method should also be called via super(), despite the
560         parent method not doing anything at the moment.
561
562         The according calls to super() are required in the ChromiumPort, EflPort
563         and GtkPort implementations.
564
565         * Scripts/webkitpy/layout_tests/port/chromium.py:
566         (ChromiumPort.setup_test_run):
567         * Scripts/webkitpy/layout_tests/port/efl.py:
568         (EflPort.setup_test_run):
569         * Scripts/webkitpy/layout_tests/port/gtk.py:
570         (GtkPort.setup_test_run):
571
572 2013-01-08  Julie Parent  <jparent@chromium.org>
573
574         Dashboard cleanup: Remove globals g_buildersThatFailedToLoad and g_staleBuilders
575         https://bugs.webkit.org/show_bug.cgi?id=106356
576
577         g_buildersThatFailedToLoad and g_staleBuilders were globals defined in
578         dashboard_base, assigned by Loader, and used only by dashboard_base to
579         create error messages.  Moved the variables to be privates on the Loader
580         object, moved error message creation to _getLoadingErrorMessages on the
581         Loader object, and now pass the errors back to dashboard base via the
582         resourceLoadingComplete callback.
583         
584         Also removed the now unused clearError function, it was only being used
585         by unit tests to clean up global state.
586         
587         Reviewed by Dirk Pranke.
588
589         * TestResultServer/static-dashboards/dashboard_base.js:
590         (resourceLoadingComplete):
591         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
592         * TestResultServer/static-dashboards/loader.js:
593         (.):
594         * TestResultServer/static-dashboards/loader_unittests.js:
595
596 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
597
598         [EFL][GTK] Make the PulseAudioSanitizer an object on the EflPort, GtkPort
599         https://bugs.webkit.org/show_bug.cgi?id=106354
600
601         Reviewed by Eric Seidel.
602
603         Put the PulseAudioSanitizer object on the EflPort and GtkPort interfaces
604         instead of those two inheriting from it. Also add a mock object of the
605         sanitizer that's used in unit tests.
606
607         * Scripts/webkitpy/layout_tests/port/efl.py:
608         (EflPort):
609         (EflPort.__init__):
610         (EflPort.setup_test_run):
611         (EflPort.clean_up_test_run):
612         * Scripts/webkitpy/layout_tests/port/efl_unittest.py: Also correct the
613         importing order.
614         (EflPortTest.make_port): Put a mock PulseAudioSanitizer on the instance.
615         * Scripts/webkitpy/layout_tests/port/gtk.py:
616         (GtkPort):
617         (GtkPort.__init__):
618         (GtkPort.setup_test_run):
619         (GtkPort.clean_up_test_run):
620         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py: Also correct the
621         importing order.
622         (GtkPortTest.make_port): Put a mock PulseAudioSanitizer on the instance.
623         * Scripts/webkitpy/layout_tests/port/pulseaudio_sanitizer.py:
624         (PulseAudioSanitizer.unload_pulseaudio_module): Stylize the method as public.
625         (PulseAudioSanitizer.restore_pulseaudio_module): Ditto.
626         * Scripts/webkitpy/layout_tests/port/pulseaudio_sanitizer_mock.py: Added.
627         (PulseAudioSanitizerMock): A simple mock interface for PulseAudioSanitizer.
628         (PulseAudioSanitizerMock.unload_pulseaudio_module):
629         (PulseAudioSanitizerMock.restore_pulseaudio_module):
630
631 2013-01-08  Jochen Eisinger  <jochen@chromium.org>
632
633         [chromium] move dumpFrameLoadCallbacks and friends to the TestRunner library
634         https://bugs.webkit.org/show_bug.cgi?id=106324
635
636         Reviewed by Adam Barth.
637
638         Since the frame load callbacks are part of the WebFrameClient, the
639         WebTestProxy is now intercepting both WebViewClient and WebFrameClient
640         methods.
641
642         * DumpRenderTree/chromium/DRTTestRunner.cpp:
643         (DRTTestRunner::DRTTestRunner):
644         (DRTTestRunner::reset):
645         * DumpRenderTree/chromium/DRTTestRunner.h:
646         (DRTTestRunner):
647         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
648         (WebTestInterfaces):
649         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
650         (WebKit):
651         (WebTestProxyBase):
652         (WebTestRunner):
653         (WebTestRunner::WebTestProxy::WebTestProxy):
654         (WebTestProxy):
655         (WebTestRunner::WebTestProxy::didInvalidateRect):
656         (WebTestRunner::WebTestProxy::didScrollRect):
657         (WebTestRunner::WebTestProxy::scheduleComposite):
658         (WebTestRunner::WebTestProxy::scheduleAnimation):
659         (WebTestRunner::WebTestProxy::setWindowRect):
660         (WebTestRunner::WebTestProxy::show):
661         (WebTestRunner::WebTestProxy::didAutoResize):
662         (WebTestRunner::WebTestProxy::postAccessibilityNotification):
663         (WebTestRunner::WebTestProxy::startDragging):
664         (WebTestRunner::WebTestProxy::shouldBeginEditing):
665         (WebTestRunner::WebTestProxy::shouldEndEditing):
666         (WebTestRunner::WebTestProxy::shouldInsertNode):
667         (WebTestRunner::WebTestProxy::shouldInsertText):
668         (WebTestRunner::WebTestProxy::shouldChangeSelectedRange):
669         (WebTestRunner::WebTestProxy::shouldDeleteRange):
670         (WebTestRunner::WebTestProxy::shouldApplyStyle):
671         (WebTestRunner::WebTestProxy::didBeginEditing):
672         (WebTestRunner::WebTestProxy::didChangeSelection):
673         (WebTestRunner::WebTestProxy::didChangeContents):
674         (WebTestRunner::WebTestProxy::didEndEditing):
675         (WebTestRunner::WebTestProxy::registerIntentService):
676         (WebTestRunner::WebTestProxy::dispatchIntent):
677         (WebTestRunner::WebTestProxy::willPerformClientRedirect):
678         (WebTestRunner::WebTestProxy::didCancelClientRedirect):
679         (WebTestRunner::WebTestProxy::didStartProvisionalLoad):
680         (WebTestRunner::WebTestProxy::didReceiveServerRedirectForProvisionalLoad):
681         (WebTestRunner::WebTestProxy::didFailProvisionalLoad):
682         (WebTestRunner::WebTestProxy::didCommitProvisionalLoad):
683         (WebTestRunner::WebTestProxy::didReceiveTitle):
684         (WebTestRunner::WebTestProxy::didFinishDocumentLoad):
685         (WebTestRunner::WebTestProxy::didHandleOnloadEvents):
686         (WebTestRunner::WebTestProxy::didFailLoad):
687         (WebTestRunner::WebTestProxy::didFinishLoad):
688         (WebTestRunner::WebTestProxy::didChangeLocationWithinPage):
689         (WebTestRunner::WebTestProxy::didDisplayInsecureContent):
690         (WebTestRunner::WebTestProxy::didRunInsecureContent):
691         (WebTestRunner::WebTestProxy::didDetectXSS):
692         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
693         (WebTestRunner::WebTestRunner::setTestIsRunning):
694         (WebTestRunner::WebTestRunner::shouldDumpFrameLoadCallbacks):
695         (WebTestRunner::WebTestRunner::setShouldDumpFrameLoadCallbacks):
696         (WebTestRunner::WebTestRunner::shouldDumpUserGestureInFrameLoadCallbacks):
697         (WebTestRunner::WebTestRunner::stopProvisionalFrameLoads):
698         (WebTestRunner::WebTestRunner::shouldDumpTitleChanges):
699         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
700         (WebTestRunner::TestRunner::TestRunner):
701         (WebTestRunner::TestRunner::reset):
702         (WebTestRunner::TestRunner::setTestIsRunning):
703         (WebTestRunner):
704         (WebTestRunner::TestRunner::shouldDumpFrameLoadCallbacks):
705         (WebTestRunner::TestRunner::setShouldDumpFrameLoadCallbacks):
706         (WebTestRunner::TestRunner::shouldDumpUserGestureInFrameLoadCallbacks):
707         (WebTestRunner::TestRunner::stopProvisionalFrameLoads):
708         (WebTestRunner::TestRunner::shouldDumpTitleChanges):
709         (WebTestRunner::TestRunner::dumpFrameLoadCallbacks):
710         (WebTestRunner::TestRunner::dumpUserGestureInFrameLoadCallbacks):
711         (WebTestRunner::TestRunner::setStopProvisionalFrameLoads):
712         (WebTestRunner::TestRunner::dumpTitleChanges):
713         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
714         (TestRunner):
715         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
716         (WebTestInterfaces::Internal):
717         (WebTestRunner::WebTestInterfaces::Internal::webView):
718         (WebTestRunner::WebTestInterfaces::Internal::Internal):
719         (WebTestRunner::WebTestInterfaces::Internal::setWebView):
720         (WebTestRunner):
721         (WebTestRunner::WebTestInterfaces::Internal::setTestIsRunning):
722         (WebTestRunner::WebTestInterfaces::setWebView):
723         (WebTestRunner::WebTestInterfaces::setTestIsRunning):
724         (WebTestRunner::WebTestInterfaces::webView):
725         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
726         (WebTestRunner::WebTestProxyBase::willPerformClientRedirect):
727         (WebTestRunner):
728         (WebTestRunner::WebTestProxyBase::didCancelClientRedirect):
729         (WebTestRunner::WebTestProxyBase::didStartProvisionalLoad):
730         (WebTestRunner::WebTestProxyBase::didReceiveServerRedirectForProvisionalLoad):
731         (WebTestRunner::WebTestProxyBase::didFailProvisionalLoad):
732         (WebTestRunner::WebTestProxyBase::didCommitProvisionalLoad):
733         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
734         (WebTestRunner::WebTestProxyBase::didFinishDocumentLoad):
735         (WebTestRunner::WebTestProxyBase::didHandleOnloadEvents):
736         (WebTestRunner::WebTestProxyBase::didFailLoad):
737         (WebTestRunner::WebTestProxyBase::didFinishLoad):
738         (WebTestRunner::WebTestProxyBase::didChangeLocationWithinPage):
739         (WebTestRunner::WebTestProxyBase::didDisplayInsecureContent):
740         (WebTestRunner::WebTestProxyBase::didRunInsecureContent):
741         (WebTestRunner::WebTestProxyBase::didDetectXSS):
742         * DumpRenderTree/chromium/TestShell.cpp:
743         (TestShell::runFileTest):
744         (TestShell::testFinished):
745         * DumpRenderTree/chromium/TestShell.h:
746         (TestShell):
747         * DumpRenderTree/chromium/WebViewHost.cpp:
748         (WebViewHost::didStartProvisionalLoad):
749         (WebViewHost::didReceiveServerRedirectForProvisionalLoad):
750         (WebViewHost::didFailProvisionalLoad):
751         (WebViewHost::didCommitProvisionalLoad):
752         (WebViewHost::didReceiveTitle):
753         (WebViewHost::didFailLoad):
754         (WebViewHost::didFinishLoad):
755         * DumpRenderTree/chromium/WebViewHost.h:
756         (WebViewHost):
757
758 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
759
760         [GTK] Lower the default timeout value for WebKitTestRunner
761         https://bugs.webkit.org/show_bug.cgi?id=106353
762
763         Reviewed by Dirk Pranke.
764
765         The default timeout value for WebKitTestRunner should be lowered.
766         The current value (80 seconds) is irrational and just leads to producing
767         text failures for layout tests that genuinely time out. This just leads
768         to more deviation from the GTK WK1 port in terms of test expectations.
769
770         The value used is the same as when running the DumpRenderTree, that's
771         6 seconds in release builds and 12 seconds in debug builds.
772
773         * Scripts/webkitpy/layout_tests/port/gtk.py:
774         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
775         (GtkPortTest.test_default_timeout_ms):
776
777 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
778
779         test-webkitpy shows failure output on my linux box
780         https://bugs.webkit.org/show_bug.cgi?id=101261
781
782         Reviewed by Eric Seidel.
783
784         Mock out the PulseAudioSanitizer methods when creating testing instances
785         of EflPort and GtkPort interfaces in unit tests. This stops throwing up
786         PulseAudio output when the sanitizer was trying to unload modules which
787         were already unloaded by another unit test that was being run in parallel.
788
789         * Scripts/webkitpy/layout_tests/port/efl_unittest.py:
790         (EflPortTest):
791         (EflPortTest.make_port):
792         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
793         (GtkPortTest):
794         (GtkPortTest.make_port):
795
796 2013-01-08  Julie Parent  <jparent@chromium.org>
797
798         Dashboard Cleanup: Remove g_hasDoneInitialPageGeneration
799         https://bugs.webkit.org/show_bug.cgi?id=106254
800
801         Remove the global variable g_hasDoneInitialPageGeneration.  It was used
802         only to figure out if we should call addBuilderLoadErrors during
803         handleLocationChange, which was called when the loader completed and on
804         any hash change, but we only ever wanted to call addBuilderLoadErrors
805         on the initial loader load.  Moved the call of addBuilderLoadErrors to
806         resourceLoadingComplete rather than handleLocationChange, so now we
807         only call it when we want to, and the check can go away completely.
808
809         Reviewed by Dirk Pranke.
810
811         * TestResultServer/static-dashboards/dashboard_base.js:
812         (addBuilderLoadErrors):
813         (resourceLoadingComplete):
814         (handleLocationChange):
815         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
816
817 2013-01-08  Dominic Mazzoni  <dmazzoni@google.com>
818
819         Add aboxhall@chromium.org to accessibility watchlist.
820
821         Unreviewed.
822
823         * Scripts/webkitpy/common/config/watchlist:
824
825 2013-01-08  Dan Winship  <danw@gnome.org>
826
827         Add Apache 2.4 support for Fedora 18
828         https://bugs.webkit.org/show_bug.cgi?id=104478
829
830         Reviewed by Martin Robinson.
831
832         Apache 2.4's httpd.conf is slightly incompatible with 2.2's, so we
833         need a separate config.
834
835         * Scripts/webkitpy/layout_tests/port/base.py:
836         (Port._apache_version):
837         (Port._apache_config_file_name_for_platform):
838         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
839         * Scripts/run-webkit-httpd:
840         * Scripts/webkitperl/httpd.pm:
841         (getApacheVersion):
842         (getDefaultConfigForTestDirectory):
843         (getHTTPDConfigPathForTestDirectory):
844
845 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
846
847         Make the override-feature-defines script compatible with Python v3
848         https://bugs.webkit.org/show_bug.cgi?id=105742
849
850         Reviewed by Martin Robinson.
851
852         Instead of printing output through a statement, use the print function and format
853         the output using the str.format method. This makes the script runnable with Python v3.
854
855         * gtk/override-feature-defines:
856         (adjust_feature_defines_makefile):
857
858 2013-01-08  Heikki Paajanen  <heikki.paajanen@palm.com>
859
860         [Qt] Fix libxml2 config test
861         https://bugs.webkit.org/show_bug.cgi?id=106317
862
863         Reviewed by Simon Hausmann.
864
865         Don't assume standard include/libxml2, libxml-2.0.pc should know
866         where it's headers are.
867
868         * qmake/config.tests/libxml2/libxml2.cpp: Fix include
869
870 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
871
872         [GTK] Make Tools/gtk/generate-gtkdoc compatible with Python 3
873         https://bugs.webkit.org/show_bug.cgi?id=106195
874
875         Reviewed by Philippe Normand.
876
877         Perform changes in the generate-gtkdoc script and common and gtkdoc modules
878         to make the Python code compatible with Python 3. This includes modifying
879         print statements, exception handling, dictionary iteration and
880         byte-sequence-to-string conversion.
881
882         * gtk/common.py:
883         (get_build_path):
884         (pkg_config_file_variable):
885         (gtk_version_of_pkg_config_file):
886         * gtk/generate-gtkdoc:
887         (print_missing_api):
888         * gtk/gtkdoc.py:
889         (GTKDoc.__init__):
890         (GTKDoc._run_command):
891
892 2013-01-02  Steve Block  <steveblock@chromium.org>
893
894         Add chromium.org email address for Steve Block.
895
896         Unreviewed.
897
898         * Scripts/webkitpy/common/config/committers.py:
899
900 2013-01-07  Filip Pizlo  <fpizlo@apple.com>
901
902         Rationalize closure call heuristics and profiling
903         https://bugs.webkit.org/show_bug.cgi?id=106270
904
905         Reviewed by Oliver Hunt.
906         
907         Add ability to use display-profiler-output via a pipe, and add the ability to dump
908         all generated code ('display *' or 'd *').
909
910         * Scripts/display-profiler-output:
911
912 2013-01-07  Ryosuke Niwa  <rniwa@webkit.org>
913
914         Sorted more xcodeproj files.
915
916         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
917         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
918         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
919
920 2013-01-07  Ryosuke Niwa  <rniwa@webkit.org>
921
922         Sorted xcodeproj files.
923
924         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
925         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
926
927 2013-01-07  Dan Bernstein  <mitz@apple.com>
928
929         [mac] WebKit1 clients can’t tell when a frame has been removed from the hierarchy
930         https://bugs.webkit.org/show_bug.cgi?id=106261
931
932         Reviewed by Simon Fraser.
933
934         Added a test for -[WebFrameLoadDelegate webView:didRemoveFrameFromHierarchy:].
935
936         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
937         * TestWebKitAPI/Tests/mac/WebViewDidRemoveFrameFromHierarchy.mm: Added.
938         (-[DidRemoveFrameFromHierarchyFrameLoadDelegate webView:didFinishLoadForFrame:]):
939         (-[DidRemoveFrameFromHierarchyFrameLoadDelegate webView:didRemoveFrameFromHierarchy:]):
940         (TestWebKitAPI):
941         (TestWebKitAPI::TEST):
942
943 2013-01-07  Ojan Vafai  <ojan@chromium.org>
944
945         Add the Apple MountainLion bots to garden-o-matic.
946         Eventually, we really should move away from hardcoding
947         the list of bots.
948
949         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
950
951 2013-01-07  Jochen Eisinger  <jochen@chromium.org>
952
953         [chromium] move web audio related methods to testrunner library
954         https://bugs.webkit.org/show_bug.cgi?id=106211
955
956         Reviewed by Adam Barth.
957
958         * DumpRenderTree/chromium/DRTTestRunner.cpp:
959         (DRTTestRunner::DRTTestRunner):
960         (DRTTestRunner::reset):
961         * DumpRenderTree/chromium/DRTTestRunner.h:
962         (DRTTestRunner):
963         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
964         (WebKit):
965         (WebTestRunner::WebTestRunner::shouldDumpAsAudio):
966         (WebTestRunner::WebTestRunner::audioData):
967         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
968         (WebTestRunner::TestRunner::TestRunner):
969         (WebTestRunner::TestRunner::reset):
970         (WebTestRunner::TestRunner::shouldDumpAsAudio):
971         (WebTestRunner):
972         (WebTestRunner::TestRunner::audioData):
973         (WebTestRunner::TestRunner::setAudioData):
974         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
975         (TestRunner):
976         * DumpRenderTree/chromium/TestShell.cpp:
977         (TestShell::dump):
978
979 2013-01-07  Mike West  <mkwst@chromium.org>
980
981         Make the IFRAME_SEAMLESS flag runtime-enabled.
982         https://bugs.webkit.org/show_bug.cgi?id=106213
983
984         Reviewed by Ojan Vafai.
985
986         * DumpRenderTree/chromium/TestShell.cpp:
987         (TestShell::TestShell):
988         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
989         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
990         * DumpRenderTree/gtk/DumpRenderTree.cpp:
991         (resetDefaultsToConsistentValues):
992         * DumpRenderTree/mac/DumpRenderTree.mm:
993         (resetDefaultsToConsistentValues):
994         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
995         (WebCore::WebPage::resetSettings):
996         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
997         (WTR::InjectedBundle::beginTesting):
998             Ensure that seamless IFrames are enabled for layout tests in each of
999             the ports that support seamless IFrames.
1000
1001 2013-01-07  Jochen Eisinger  <jochen@chromium.org>
1002
1003         [chromium] move dumpAsText and friends to the TestRunner library
1004         https://bugs.webkit.org/show_bug.cgi?id=106222
1005
1006         Reviewed by Adam Barth.
1007
1008         This moves dumpAsText, dumpChildFramesAsText, and dumpChildFrameScrollPositions to the TestRunner library.
1009
1010         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1011         (DRTTestRunner::DRTTestRunner):
1012         (DRTTestRunner::reset):
1013         * DumpRenderTree/chromium/DRTTestRunner.h:
1014         (DRTTestRunner):
1015         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1016         (WebTestRunner::WebTestRunner::shouldDumpAsText):
1017         (WebTestRunner::WebTestRunner::setShouldDumpAsText):
1018         (WebTestRunner::WebTestRunner::shouldGeneratePixelResults):
1019         (WebTestRunner::WebTestRunner::setShouldGeneratePixelResults):
1020         (WebTestRunner::WebTestRunner::shouldDumpChildFrameScrollPositions):
1021         (WebTestRunner::WebTestRunner::shouldDumpChildFramesAsText):
1022         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1023         (WebTestRunner::TestRunner::TestRunner):
1024         (WebTestRunner::TestRunner::reset):
1025         (WebTestRunner::TestRunner::shouldDumpAsText):
1026         (WebTestRunner):
1027         (WebTestRunner::TestRunner::setShouldDumpAsText):
1028         (WebTestRunner::TestRunner::shouldGeneratePixelResults):
1029         (WebTestRunner::TestRunner::setShouldGeneratePixelResults):
1030         (WebTestRunner::TestRunner::shouldDumpChildFrameScrollPositions):
1031         (WebTestRunner::TestRunner::shouldDumpChildFramesAsText):
1032         (WebTestRunner::TestRunner::dumpAsText):
1033         (WebTestRunner::TestRunner::dumpChildFrameScrollPositions):
1034         (WebTestRunner::TestRunner::dumpChildFramesAsText):
1035         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1036         (TestRunner):
1037
1038 2013-01-07  Ryosuke Niwa  <rniwa@webkit.org>
1039
1040         Build fix attempt after r138810.
1041
1042         Apparently python 2.6 is really bad at floating point computation.
1043
1044         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
1045         (MainTest.test_run_memory_test):
1046
1047 2013-01-07  Ryosuke Niwa  <rniwa@webkit.org>
1048
1049         Extract a class to represent a test result to simplify PerfTest.parse_output and PageLoadPerfTest._run_with_driver
1050         https://bugs.webkit.org/show_bug.cgi?id=106172
1051
1052         Reviewed by Tony Chang.
1053
1054         Extracted PerfTestMetric, which represents a test result and knows how to compute statistics and convert itself
1055         to a dictionary. A metric is a type of measurement each test makes such as "Time", "Malloc", and "JSHeap".
1056         A single test (e.g. html5-full-render.html) may have multiple metrics, each of which is reported as a separate
1057         test on perf-o-matic and perf. test's results page.
1058
1059         Also, use python's compute_statistics instead of reading statistics off of DriverOutput to simplify the code.
1060
1061         * Scripts/webkitpy/performance_tests/perftest.py:
1062         (PerfTestMetric): Added.
1063         (PerfTestMetric.__init__): Added.
1064         (PerfTestMetric.metric): Added.
1065         (PerfTestMetric.has_values): Added.
1066         (PerfTestMetric.legacy_chromium_bot_compatible_test_name): Added. Following the legacy convention, "Malloc" and
1067         "JSHeap" will use "test_name:Malloc" whereas "Time" uses "test_name" itself. We should eventually move these
1068         conversions to be done on the client side (perf-o-matic and results page).
1069         (PerfTestMetric.append): Added.
1070         (PerfTestMetric.to_dict): Added. Computes the statistics and generates the dictionary object that represents
1071         a result for this metric.
1072         (PerfTestMetric.metric_to_unit): Added. Each metric maps to exactly one unit (it's not one-to-one).
1073         (PerfTestMetric.compute_statistics): Moved from PerfTest.
1074
1075         (PerfTest._create_driver): Extracted from PerfTest.run.
1076         (PerfTest.run): Given an array of PerfTestMetric, generate the results dictionary. Also print out results
1077         as needed.
1078         (PerfTest._run_with_driver):
1079         (PerfTest): Removed _result_classes and _result_class_regex. "result class" is the old name for "metric".
1080         (PerfTest.parse_output): Dramatically simplified. We now just return an array of PerfTestMetric's. Also ignore
1081         all keys except "values". We rely on PerfTestMetric to compute the statistics for us.
1082
1083         (ChromiumStylePerfTest.run): Added and merged _run_with_driver. Since chromium style perf tests are so different
1084         from other perf tests, there isn't much point in sharing the code here.
1085
1086         (PageLoadingPerfTest._run_with_driver): Simplified. Just create an array of PerfTestMetric's without computing
1087         statistics for the measured values.
1088
1089         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1090         (TestPerfTestMetric): Added.
1091         (TestPerfTestMetric.test_init_set_missing_unit): Added.
1092         (TestPerfTestMetric.test_legacy_chromium_bot_compatible_test_name): Added.
1093         (TestPerfTestMetric.test_has_values): Added.
1094         (TestPerfTestMetric.test_append): Added.
1095         (TestPerfTestMetric.test_compute_statistics.compute_statistics):
1096         (TestPerfTestMetric.test_compute_statistics): Added a trivial test case.
1097
1098         (TestPerfTest._assert_results_are_correct): Updated as needed.
1099         (TestPageLoadingPerfTest.test_run): Ditto. Notice that we no longer log anything in _run_with_driver. It's done
1100         in PerfTest.run now after generating the results dictionary.
1101         (TestPageLoadingPerfTest.test_run_with_memory_output): Ditto.
1102
1103 2013-01-07  Julien Chaffraix  <jchaffraix@webkit.org>
1104
1105         Support size_t multiplication and division operators on LayoutUnit
1106         https://bugs.webkit.org/show_bug.cgi?id=83848
1107
1108         Reviewed by Emil A Eklund.
1109
1110         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
1111         Added some simple tests for the new operators using size_t.
1112
1113 2013-01-07  Csaba Osztrogonác  <ossy@webkit.org>
1114
1115         [Qt] run-webkit-tests cleanup for parallel NRWT
1116         https://bugs.webkit.org/show_bug.cgi?id=106220
1117
1118         Reviewed by Dirk Pranke.
1119
1120         * Scripts/run-webkit-tests:
1121         (useNewRunWebKitTests):
1122         * Scripts/webkitpy/layout_tests/port/qt.py:
1123         (QtPort):
1124         (QtPort.default_child_processes):
1125
1126 2013-01-07  Philippe Normand  <pnormand@igalia.com>
1127
1128         Create a GStreamerAudio watchlist and add myself to it.
1129
1130         Unreviewed.
1131
1132         * Scripts/webkitpy/common/config/watchlist:
1133
1134 2013-01-05  Ryosuke Niwa  <rniwa@webkit.org>
1135
1136         Add svn:executable to a bunch of scripts in BuildSlaveSupport.
1137         Also removed the empty mac directory.
1138
1139         * BuildSlaveSupport/built-product-archive: Added property svn:executable.
1140         * BuildSlaveSupport/download-built-product: Added property svn:executable.
1141         * BuildSlaveSupport/mac: Removed.
1142         * BuildSlaveSupport/test-result-archive: Added property svn:executable.
1143
1144 2013-01-04  Ryosuke Niwa  <rniwa@webkit.org>
1145
1146         Add a script to delete stale zero-byte build files
1147         https://bugs.webkit.org/show_bug.cgi?id=106131
1148
1149         Reviewed by Tony Chang.
1150
1151         Delete zero-byte build files on Mac port for now. It doesn't do anything on other ports.
1152
1153         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1154         (DeleteStaleBuildFiles): Added.
1155         (Factory.__init__): Add DeleteStaleBuildFiles step.
1156         * BuildSlaveSupport/delete-stale-build-files: Added.
1157         (main): Delete zero-byte files except ones intentionally generated by our build process.
1158         (webkitBuildDirectory): Copied from build-product-archive.
1159
1160 2013-01-04  Michael Pruett  <michael@68k.org>
1161
1162         [GTK] Fix build error on GTK due to r138836
1163         https://bugs.webkit.org/show_bug.cgi?id=106154
1164
1165         Reviewed by Kentaro Hara.
1166
1167         * GNUmakefile.am:
1168
1169 2013-01-04  Dan Bernstein  <mitz@apple.com>
1170
1171         [mac] WebKit1 has no equivalent of WKBundleNodeHandleCopyHTMLTableCellElementCellAbove
1172         https://bugs.webkit.org/show_bug.cgi?id=106121
1173
1174         Reviewed by Adele Peterson.
1175
1176         Added test for -[DOMTHMLTableCellElement _cellAbove].
1177
1178         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1179         * TestWebKitAPI/Tests/mac/DOMHTMLTableCellCellAbove.mm: Added.
1180         (-[HTMLTableCellElementCellAboveTest webView:didFinishLoadForFrame:]):
1181         (TestWebKitAPI):
1182         (TestWebKitAPI::expectCellAboveCell):
1183         (TestWebKitAPI::TEST):
1184         * TestWebKitAPI/Tests/mac/DOMHTMLTableCellElementCellAbove.html: Added.
1185
1186 2013-01-04  Eric Seidel  <eric@webkit.org>
1187
1188         FlakyTestReporter should be re-enabled and taught how to post patches
1189         https://bugs.webkit.org/show_bug.cgi?id=103839
1190
1191         Reviewed by Adam Barth.
1192
1193         This moves LayoutTestResultsReader off of the DeprecatedPort object.
1194         It also adds a real Port object to the EWS and CommitQueue objects
1195         using a new PatchProcessingQueue superclass.
1196         PatchProcessingQueue doesn't seem to be the cleanest insertion point
1197         but works for this purpose.
1198         I also moved _upload_results_archive_for_patch into PatchProcessingQueue
1199         to resolve a FIXME.
1200
1201         This required some hacks/shiming between the non-specific "old"
1202         port names which the EWS system is currently using, and the new
1203         port objects.  This shimming is done in PatchProcessingQueue._new_port_name_from_old.
1204
1205         Hopefully this will fix the flaky test reporter and results uploading.
1206         Certainly it's another small step towards getting rid of the old ports.py
1207         infrastructure and making the NRWT Port class common webkitpy infrastructure.
1208
1209         Now that DeprecatedPort is no longer used for the results directory
1210         I removed all the explicit results-dir code which webkit-patch was using
1211         in --non-interactive mode to tell NRWT to use a results-dir it understood. :)
1212
1213         * Scripts/webkitpy/common/config/ports.py:
1214         (DeprecatedPort.run_perl_unittests_command):
1215         * Scripts/webkitpy/common/config/ports_mock.py:
1216         (MockPort.name):
1217         * Scripts/webkitpy/common/system/outputcapture.py:
1218         (OutputCapture.assert_outputs):
1219         * Scripts/webkitpy/layout_tests/port/apple.py:
1220         (ApplePort.determine_full_port_name):
1221         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
1222         (LayoutTestResultsReader.__init__):
1223         (LayoutTestResultsReader):
1224         (LayoutTestResultsReader._read_file_contents):
1225         (LayoutTestResultsReader._create_layout_test_results):
1226         (LayoutTestResultsReader._create_unit_test_results):
1227         (LayoutTestResultsReader.results):
1228         (LayoutTestResultsReader.archive):
1229         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
1230         (LayoutTestResultsReaderTest.test_missing_layout_test_results):
1231         (LayoutTestResultsReaderTest.test_create_unit_test_results):
1232         (test_missing_unit_test_results_path):
1233         (test_layout_test_results):
1234         (test_archive_last_layout_test_results):
1235         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1236         (AbstractEarlyWarningSystem):
1237         (AbstractEarlyWarningSystem.__init__):
1238         (AbstractEarlyWarningSystem.begin_work_queue):
1239         (AbstractEarlyWarningSystem.run_command):
1240         * Scripts/webkitpy/tool/commands/queues.py:
1241         (AbstractPatchQueue.work_item_log_path):
1242         (PatchProcessingQueue):
1243         (PatchProcessingQueue._new_port_name_from_old):
1244         (PatchProcessingQueue.begin_work_queue):
1245         (PatchProcessingQueue._upload_results_archive_for_patch):
1246         (CommitQueue):
1247         (CommitQueue.begin_work_queue):
1248         (CommitQueue.run_command):
1249         (AbstractReviewQueue):
1250         (AbstractReviewQueue.__init__):
1251         (AbstractReviewQueue.begin_work_queue):
1252         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1253         (AbstractPatchQueueTest.test_next_patch):
1254         (PatchProcessingQueueTest):
1255         (PatchProcessingQueueTest.test_upload_results_archive_for_patch):
1256         * Scripts/webkitpy/tool/steps/runtests.py:
1257         (RunTests.run):
1258         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
1259
1260 2013-01-04  Dana Jansens  <danakj@chromium.org>
1261
1262         [chromium] Remove lost-compositor-context layout tests
1263         https://bugs.webkit.org/show_bug.cgi?id=106089
1264
1265         Reviewed by James Robinson.
1266
1267         Remove the loseCompositorContext() test function.
1268
1269         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1270         (WebTestRunner::TestRunner::TestRunner):
1271         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1272         (TestRunner):
1273
1274 2013-01-04  Adam Klein  <adamk@chromium.org>
1275
1276         Remove ENABLE_MUTATION_OBSERVERS #define
1277         https://bugs.webkit.org/show_bug.cgi?id=105459
1278
1279         Reviewed by Ryosuke Niwa.
1280
1281         * Scripts/webkitperl/FeatureList.pm:
1282         * qmake/mkspecs/features/features.pri:
1283
1284 2013-01-04  Ryosuke Niwa  <rniwa@webkit.org>
1285
1286         Statistics used in perftest_unittest.py and perftest_integrationtest.py are bogus
1287         https://bugs.webkit.org/show_bug.cgi?id=106078
1288
1289         Reviewed by Tony Chang.
1290
1291         This patch updates values for individual iterations in dummy performance tests used in
1292         perftest_unittest.py and perftest_integrationtest.py so that they match up with
1293         statistics such as stdev and median reported in those tests. This change is required
1294         to resolve the bug 97510.
1295
1296         This patch also refactors integration tests by extracting *TestData classes that
1297         centralizes the definitions of each dummy performance test's text (DRT output),
1298         runner output, and parsed results (JSON) so that we may share more data between
1299         python tests.
1300
1301         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1302         (MainTest._assert_results_are_correct): Extracted from test_parse_output.
1303         Use self.assertAlmostEqual when comparing the standard deviation.
1304         (MainTest.test_parse_output):
1305         (test_parse_output_with_failing_line):
1306         (test_parse_output_with_description): Use _assert_results_are_correct.
1307         (test_parse_output_with_subtests): Ditto.
1308
1309         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
1310         (InspectorPassTestData): Extracted from tests below.
1311         (EventTargetWrapperTestData): Ditto.
1312         (SomeParserTestData): Ditto.
1313         (MemoryTestData): Ditto.
1314         (TestDriver.run_test): Moved test definitions out of the method.
1315         (MainTest._normalize_output): Truncate standard deviations at 5th decimal point.
1316         (MainTest._load_output_json): Extracted from create_runner.
1317         (MainTest.create_runner):
1318         (MainTest.test_run_test_set_for_parser_tests):
1319         (MainTest.test_run_memory_test):
1320         (MainTest._test_run_with_json_output):
1321         (MainTest.test_run_with_json_output):
1322         (MainTest.test_run_with_description):
1323         (MainTest.test_run_generates_json_by_default):
1324         (MainTest.test_run_merges_output_by_default):
1325         (MainTest.test_run_respects_reset_results):
1326         (MainTest.test_run_generates_and_show_results_page):
1327         (MainTest.test_run_with_slave_config_json):
1328         (MainTest.test_run_with_multiple_repositories):
1329
1330 2013-01-04  Martin Robinson  <mrobinson@igalia.com>
1331
1332         [GTK] [WebKit2] Clicking on a word that is selected in an editable area deletes it
1333         https://bugs.webkit.org/show_bug.cgi?id=106045
1334
1335         Reviewed by Carlos Garcia Campos.
1336
1337         Update test results to confirm that compositions without preedits do not trigger
1338         a composition confirmation.
1339
1340         * TestWebKitAPI/Tests/gtk/InputMethodFilter.cpp:
1341         (TestWebKitAPI::verifyCanceledComposition):
1342
1343 2013-01-04  Sailesh Agrawal  <sail@chromium.org>
1344
1345         [Mac] [WK2] platform/mac/fast/events/numpad-keycode-mapping.html fails
1346         https://bugs.webkit.org/show_bug.cgi?id=105958
1347
1348         Reviewed by Alexey Proskuryakov.
1349
1350         Ported code from DumpRenderTree to WebKitTestRunner to map all numpad keys.
1351
1352         * WebKitTestRunner/mac/EventSenderProxy.mm:
1353         (KeyMappingEntry):
1354         (WTR):
1355         (WTR::EventSenderProxy::keyDown): Added all numpad keys.
1356
1357 2013-01-03  Chris Fleizach  <cfleizach@apple.com>
1358
1359         REGRESSION: [Mac] Intermittent crash in WTR::AccessibilityUIElement::isEqual
1360         https://bugs.webkit.org/show_bug.cgi?id=106073
1361
1362         Reviewed by Ryosuke Niwa.
1363
1364         Check that the element being compared to is not nil. 
1365         This crash is happening because one of the accessibility tests does an isEqual comparison within a callback function.
1366         It looks like occasionally, one of the elements passed in to the isEqual is nil because the notification handler is on the accessibility
1367         controller, and the notification is being delivered after the document objects are cleared. This shouldn't happen but I've seen it 
1368         sometimes before on parallel WebKitTestRunner runs.
1369
1370         * DumpRenderTree/AccessibilityUIElement.cpp:
1371         (AccessibilityUIElement::isEqual):
1372         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1373         (WTR::AccessibilityUIElement::isEqual):
1374
1375 2013-01-03  Tim 'mithro' Ansell  <mithro@mithis.com>
1376
1377         Downloads can be flaky, so try downloading multiple times.
1378         https://bugs.webkit.org/show_bug.cgi?id=105976
1379
1380         Reviewed by Eric Seidel.
1381
1382         * Scripts/webkitpy/common/system/autoinstall.py:
1383         (AutoInstaller._download_to_stream):
1384
1385 2013-01-03  Eric Seidel  <eric@webkit.org>
1386
1387         Rename Tool.port to deprecated_port in preparation for removing more callers
1388         https://bugs.webkit.org/show_bug.cgi?id=106076
1389
1390         Reviewed by Ryosuke Niwa.
1391
1392         This resolves a long-standing FIXME to rename this method. :)
1393
1394         * Scripts/webkitpy/tool/bot/botinfo.py:
1395         (BotInfo.summary_text):
1396         * Scripts/webkitpy/tool/bot/irc_command.py:
1397         (Rollout._update_working_copy):
1398         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
1399         (LayoutTestResultsReader._create_layout_test_results):
1400         (LayoutTestResultsReader._create_unit_test_results):
1401         (LayoutTestResultsReader._results_directory):
1402         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
1403         (test_missing_unit_test_results_path):
1404         * Scripts/webkitpy/tool/main.py:
1405         (WebKitPatch.deprecated_port):
1406         * Scripts/webkitpy/tool/mocktool.py:
1407         (MockTool.deprecated_port):
1408         * Scripts/webkitpy/tool/steps/build.py:
1409         (Build.build):
1410         * Scripts/webkitpy/tool/steps/checkstyle.py:
1411         (CheckStyle.run):
1412         * Scripts/webkitpy/tool/steps/commit.py:
1413         (Commit._check_test_expectations):
1414         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1415         (PrepareChangeLog.run):
1416         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
1417         (PrepareChangeLogForDEPSRoll.run):
1418         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
1419         (PrepareChangeLogForRevert.run):
1420         * Scripts/webkitpy/tool/steps/runtests.py:
1421         (RunTests.run):
1422         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1423         (StepsTest.test_runtests_args):
1424         * Scripts/webkitpy/tool/steps/update.py:
1425         (Update._update_command):
1426
1427 2013-01-03  Eric Seidel  <eric@webkit.org>
1428
1429         Add myself to the webkitpy watchlist.
1430
1431         Unreviewed.
1432
1433         * Scripts/webkitpy/common/config/watchlist:
1434
1435 2013-01-03  Ryosuke Niwa  <rniwa@webkit.org>
1436
1437         Cleanup perftest* tests and add a test for computing statistics
1438         https://bugs.webkit.org/show_bug.cgi?id=105685
1439
1440         Reviewed by Eric Seidel.
1441
1442         Add a test for PerfTest.compute_statistics (moved and renamed from PageLoadingPerfTest.calculate_statistics) and
1443         extracted perftestsrunner_itegrationtests.py from perftestsrunner_unittests.py.
1444
1445         Also fixed a bug in compute_statistics that the mean ('avg') value can have a large rounding errors in some cases.
1446
1447         * Scripts/webkitpy/performance_tests/perftest.py:
1448         (PerfTest.compute_statistics): Moved from PageLoadingPerfTest to prepare for the bug 97510. Also compute the mean
1449         directly from sorted_values instead of using the one from Knuth's online algorithm. This approach gives more
1450         accurate result for the mean.
1451         (PageLoadingPerfTest.run_single):
1452         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1453         (MainTest.test_compute_statistics):
1454         (MainTest.test_compute_statistics.compute_statistics): Added.
1455         (TestPageLoadingPerfTest.test_run): floatify values.
1456         (TestPageLoadingPerfTest.test_run_with_memory_output): Ditto. Also got rid of ".0" from mean values now that Python
1457         correctly recognizes them as integers.
1458
1459         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py: Copied from
1460         Tools/Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py.
1461         (TestDriver): Moved out of MainTest.
1462         (MainTest): Got rid of assertWritten and all unit tests.
1463         (MainTest._normalize_output): Renamed from normalizeFinishedTime to match the PEP8 naming convention.
1464         (MainTest.test_run_test_set_kills_drt_per_run.TestDriverWithStopCount):
1465         (MainTest.test_run_test_set_for_parser_tests):
1466         (MainTest.test_run_memory_test):
1467         (MainTest._test_run_with_json_output):
1468         (MainTest.test_run_generates_json_by_default):
1469         (MainTest.test_run_merges_output_by_default):
1470         (MainTest.test_run_respects_reset_results):
1471         (MainTest.test_run_generates_and_show_results_page): Use runner.load_output_json() instead of manually loading and
1472         parsing output JSON files. Just verify that the output path is correct instead.
1473         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1474         (MainTest): Removed all integration tests.
1475         (MainTest.create_runner): Simplified.
1476
1477 2013-01-03  Julie Parent  <jparent@chromium.org>
1478
1479         Dashboard cleanup: remove usage of global g_defaultBuilderName
1480         https://bugs.webkit.org/show_bug.cgi?id=106043
1481
1482         Use now public defaultBuilder() from the BuilderGroup, rather
1483         than global variable.
1484
1485         Also eliminates the setup() and initBuilders() functions since we
1486         no longer need to track the global.
1487
1488         Reviewed by Adam Barth.
1489
1490         * TestResultServer/static-dashboards/builders.js:
1491         (BuilderGroup.prototype.defaultBuilder):
1492         (BuilderGroup.prototype.master):
1493         * TestResultServer/static-dashboards/dashboard_base.js:
1494         (parseParameters):
1495         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1496         (updateDefaultBuilderState):
1497         * TestResultServer/static-dashboards/loader.js:
1498         (.):
1499         * TestResultServer/static-dashboards/loader_unittests.js:
1500
1501 2013-01-03  Ryosuke Niwa  <rniwa@webkit.org>
1502
1503         Disable an intermittently failing unit test for now.
1504         The failure is tracked by the bug 106051.
1505
1506         * TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.mm:
1507         (TestWebKitAPI::TEST):
1508
1509 2013-01-03  Dan Bernstein  <mitz@apple.com>
1510
1511         No way to obtain a DOMNode given a JS wrapper for a Node
1512         https://bugs.webkit.org/show_bug.cgi?id=106033
1513
1514         Added a test for +[DOMNode _nodeFromJSWrapper:].
1515
1516         Reviewed by Sam Weinig.
1517
1518         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1519         * TestWebKitAPI/Tests/mac/DOMNodeFromJSObject.mm: Added.
1520         (TestWebKitAPI):
1521         (TestWebKitAPI::TEST):
1522
1523 2013-01-03  Emil A Eklund  <eae@chromium.org>
1524
1525         Fix overflow in LayoutUnit::ceil and floor for SATURATED_LAYOUT_ARITHMETIC
1526         https://bugs.webkit.org/show_bug.cgi?id=105961
1527
1528         Reviewed by Levi Weintraub.
1529         
1530         Add tests for LayoutUnit::ceil and floor.
1531
1532         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
1533         (TestWebKitAPI::TEST):
1534         (TestWebKitAPI):
1535
1536 2013-01-03  Julie Parent  <jparent@chromium.org>
1537
1538         Add unit test for default builder for the dashboards.
1539         https://bugs.webkit.org/show_bug.cgi?id=105972
1540
1541         Reviewed by Dirk Pranke.
1542
1543         * TestResultServer/static-dashboards/loader_unittests.js:
1544
1545 2013-01-03  Tony Chang  <tony@chromium.org>
1546
1547         Generate internal.settings from Settings.in
1548         https://bugs.webkit.org/show_bug.cgi?id=104740
1549
1550         Reviewed by Adam Barth.
1551
1552         * GNUmakefile.am: Compile new generated files on GTK+.
1553         * qmake/mkspecs/features/default_post.prf: Qt: Make it so an action
1554         with both extra_sources and add_output_to_sources=false will still
1555         compile the files in extra_sources. This makes it possible to compile
1556         InternalSettingsGenerated.cpp and not be confused by
1557         InternalSettingsGenerated.idl.
1558
1559 2013-01-03  Zan Dobersek  <zandobersek@gmail.com>
1560
1561         [style] WebIDL-reflecting uppercase enums reported as style violation
1562         https://bugs.webkit.org/show_bug.cgi?id=105832
1563
1564         Reviewed by Tony Chang.
1565
1566         Recognize the enum as WebIDL-reflecting one if there's a comment present that
1567         indicates this. In enums spanning over multiple lines, the comment is expected
1568         on the first line. In enums placed in one line, the comment is expected at the
1569         end of that line.
1570
1571         WebIDL-reflecting enum values are required to be written in uppercase and as such
1572         violate the common rule of these values being written in InterCaps. Annotating
1573         enums this way makes it possible to avoid false style violation reports.
1574
1575         The comment is of form '// Web(?:Kit)?IDL enum'.
1576
1577         * Scripts/webkitpy/style/checkers/cpp.py:
1578         (_EnumState.__init__):
1579         (_EnumState.process_clean_line):
1580         (check_enum_casing):
1581         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1582         (NoNonVirtualDestructorsTest.test_enum_casing):
1583
1584 2013-01-03  Tim 'mithro' Ansell  <mithro@mithis.com>
1585
1586         Adding favicon.ico to the garden-o-matic.
1587         https://bugs.webkit.org/show_bug.cgi?id=105982
1588
1589         Reviewed by Adam Barth.
1590
1591         * Scripts/webkitpy/tool/servers/gardeningserver.py:
1592         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon.ico:
1593
1594 2013-01-03  Jonathan Liu  <net147@gmail.com>
1595
1596         [Qt] Fix library linking order
1597         https://bugs.webkit.org/show_bug.cgi?id=105818
1598
1599         Some Qt libraries are linked before the private static libraries
1600         that depend on them which results in QtWebKit failing to link.
1601
1602         Copy Qt module dependencies from QT to QT_PRIVATE when creating
1603         module to ensure the Qt libraries are linked after the private
1604         static libraries that depend on them.
1605
1606         Reviewed by Tor Arne Vestbø.
1607
1608         * qmake/mkspecs/features/default_post.prf:
1609
1610 2013-01-02  Byungwoo Lee  <bw80.lee@samsung.com>
1611
1612         [EFL][WK2] Fix tooltip bugs in MiniBrowser.
1613         https://bugs.webkit.org/show_bug.cgi?id=102209
1614
1615         Reviewed by Gyuyoung Kim.
1616
1617         Set tooltip on the elm_window instead of ewk_view, and add delay to
1618         show the tooltip window.
1619
1620         Setting tooltip on the ewk_view makes elementary error message because
1621         ewk_view is not an elementary widget. To remove the error message,
1622         tooltip should be set on the elm_window.
1623
1624         Most browsers show the tooltip after a mouse pointer stays on an
1625         element object that has tooltip text.
1626         But elm_tooltip widget itself doesn't have delay or handle mouse
1627         events to show/hide.
1628
1629         So additional codes are added to show/hide tooltip widget along with
1630         mouse events.
1631           1) When a mouse pointer stays for a second on an element which has
1632              tooltip text, then tooltip widget is displayed.
1633           2) When a mouse pointer is moved or out of ewk_view, hide the tooltip
1634              widget.
1635
1636         * MiniBrowser/efl/main.c:
1637         (_Tooltip_Information):
1638         (_Browser_Window):
1639         (on_tooltip_show):
1640         (window_tooltip_hide):
1641         (window_tooltip_update):
1642         (on_mouse_in):
1643         (on_mouse_move):
1644         (on_mouse_out):
1645         (window_free):
1646         (on_tooltip_text_set):
1647         (on_tooltip_text_unset):
1648         (window_create):
1649
1650 2013-01-02  Tony Chang  <tony@chromium.org>
1651
1652         Unreviewed, rolling out r138661.
1653         http://trac.webkit.org/changeset/138661
1654         https://bugs.webkit.org/show_bug.cgi?id=104740
1655
1656         Compile problems on EFL
1657
1658         * GNUmakefile.am:
1659         * qmake/mkspecs/features/default_post.prf:
1660
1661 2013-01-02  Tony Chang  <tony@chromium.org>
1662
1663         Generate internal.settings from Settings.in
1664         https://bugs.webkit.org/show_bug.cgi?id=104740
1665
1666         Reviewed by Adam Barth.
1667
1668         * GNUmakefile.am: Compile new generated files on GTK+.
1669         * qmake/mkspecs/features/default_post.prf: Qt: Make it so an action
1670         with both extra_sources and add_output_to_sources=false will still
1671         compile the files in extra_sources. This makes it possible to compile
1672         InternalSettingsGenerated.cpp and not be confused by
1673         InternalSettingsGenerated.idl.
1674
1675 2013-01-02  Adam Barth  <abarth@webkit.org>
1676
1677         Remove old-run-webkit-tests support from webkitpy
1678         https://bugs.webkit.org/show_bug.cgi?id=105619
1679
1680         Reviewed by Eric Seidel.
1681
1682         This patch removes support for webkitpy parsing the
1683         old-run-webkit-tests results format. There doesn't seem to be any
1684         reason to keep this code around anymore now that most bots have
1685         switched to new-run-webkit-tests.
1686
1687         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1688         (Builder.fetch_layout_test_results):
1689         * Scripts/webkitpy/common/net/layouttestresults.py:
1690         (path_for_layout_test):
1691         (LayoutTestResults.results_from_string):
1692         (LayoutTestResults):
1693         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1694         (LayoutTestResultsTest.test_results_from_string):
1695         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1696         (test_flaky_test_failure):
1697         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
1698         (LayoutTestResultsReaderTest.test_missing_layout_test_results):
1699         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1700         (PatchAnalysisTask._test_patch):
1701         * Scripts/webkitpy/tool/commands/queuestest.py:
1702         (QueuesTest.assert_queue_outputs):
1703
1704 2013-01-02  Heikki Paajanen  <heikki.paajanen@palm.com>
1705
1706         [Qt][WK2] Add simple UI to find text from page
1707         https://bugs.webkit.org/show_bug.cgi?id=96481
1708
1709         Reviewed by Jocelyn Turcotte.
1710
1711         Find bar that slides between navigation bar and WebView.
1712
1713         * MiniBrowser/qt/BrowserWindow.cpp:
1714         (BrowserWindow::toggleFind):
1715         * MiniBrowser/qt/BrowserWindow.h:
1716         (BrowserWindow):
1717         * MiniBrowser/qt/MiniBrowser.qrc:
1718         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1719         (MiniBrowserApplication::notify):
1720         * MiniBrowser/qt/icons/find.png: Added.
1721         * MiniBrowser/qt/qml/BrowserWindow.qml:
1722
1723 2013-01-02  Christophe Dumez  <christophe.dumez@intel.com>
1724
1725         Regression(r138603): Caused 2 webkitpy tests to fail
1726         https://bugs.webkit.org/show_bug.cgi?id=105913
1727
1728         Reviewed by Kentaro Hara.
1729
1730         Fix 2 webkitpy tests that started to fail after
1731         r138603.
1732
1733         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1734         (IRCCommandTest._sheriff_test_data_url): Make sure the
1735         returned test file URL is valid no matter what the
1736         current working directory is.
1737         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
1738         (IRCBotTest.test_help): Add "sheriffs" command to the
1739         list of available commands.
1740
1741 2013-01-01  Christophe Dumez  <christophe.dumez@intel.com>
1742
1743         [WK2] plugins/clicking-missing-plugin-fires-delegate.html is failing
1744         https://bugs.webkit.org/show_bug.cgi?id=105897
1745
1746         Reviewed by Alexey Proskuryakov.
1747
1748         Dump in WebKitTestRunner the message that is expected by layout tests
1749         when the missing plugin button is clicked.
1750
1751         * WebKitTestRunner/TestController.cpp:
1752         (WTR::TestController::createWebViewWithOptions):
1753         (WTR::TestController::unavailablePluginButtonClicked):
1754         (WTR):
1755         * WebKitTestRunner/TestController.h:
1756         (TestController):
1757
1758 2013-01-01  KwangYong Choi  <ky0.choi@samsung.com>
1759
1760         [EFL] Enable MHTML feature
1761         https://bugs.webkit.org/show_bug.cgi?id=105815
1762
1763         Reviewed by Laszlo Gombos.
1764
1765         Enable MHTML feature for EFL port by default.
1766
1767         * Scripts/webkitperl/FeatureList.pm:
1768
1769 2013-01-01  Alan Cutter  <alancutter@chromium.org>
1770
1771         sheriff-bot should know who the gardeners/sheriffs are
1772         https://bugs.webkit.org/show_bug.cgi?id=105698
1773
1774         Reviewed by Eric Seidel.
1775
1776         Added a "sheriffs" command to sheriffbot to fetch the current Chromium Webkit sheriffs.
1777
1778         * Scripts/webkitpy/tool/bot/irc_command.py:
1779         (Current):
1780         (Current._retrieve_webkit_sheriffs):
1781         (Current.execute):
1782         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1783         (IRCCommandTest.test_current):
1784         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_0.js: Added.
1785         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_1.js: Added.
1786         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_2.js: Added.
1787         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_malformed.js: Added.
1788         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_zero.js: Added.
1789
1790 2012-12-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1791
1792         [GTK] Move ImageDiff to the Tools directory root
1793         https://bugs.webkit.org/show_bug.cgi?id=105421
1794
1795         Reviewed by Kenneth Rohde Christiansen.
1796
1797         * DumpRenderTree/gtk/GNUmakefile.ImageDiff.am: Removed.
1798         * GNUmakefile.am:
1799         * ImageDiff/gtk/ImageDiff.cpp: Renamed from Tools/DumpRenderTree/gtk/ImageDiff.cpp.
1800
1801 2012-12-30  Mike West  <mkwst@chromium.org>
1802
1803         Add myself to watchlists for CSP and console logs.
1804         https://bugs.webkit.org/show_bug.cgi?id=105874
1805
1806         Reviewed by Dirk Pranke.
1807
1808         Because I really, really, really need more email.
1809
1810         * Scripts/webkitpy/common/config/committers.py:
1811             Add mkwst+watchlist@chromium.org as a contributor.
1812         * Scripts/webkitpy/common/config/watchlist:
1813             Create watchlist categories for 1) the various mechanisms used to
1814             generate console messages, and 2) CSP usage and files.
1815
1816 2012-12-30  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1817
1818         [EFL] Enable TEMPLATE_ELEMENT feature
1819         https://bugs.webkit.org/show_bug.cgi?id=105865
1820         
1821         Reviewed by Laszlo Gombos.
1822
1823         * Scripts/webkitperl/FeatureList.pm: Enable template element feature for EFL port.
1824
1825 2012-12-30  Zan Dobersek  <zandobersek@gmail.com>
1826
1827         Unreviewed GTK gardening of the unit tests.
1828
1829         Skip the TestInspectorServer unit test that's timing out completely.
1830
1831         * Scripts/run-gtk-tests:
1832         (TestRunner):
1833
1834 2012-12-29  Ilya Tikhonovsky  <loislo@chromium.org>
1835
1836         Web Inspector: Native Memory Instrumentation plugin: do not generate 'not instrumented' warning for instrumented mutable members.
1837         https://bugs.webkit.org/show_bug.cgi?id=105855
1838
1839         Reviewed by Vsevolod Vlasov.
1840
1841         Extract MemberExpr from ImplicitCastExpr. It happens when we instrument a mutable member because
1842         addMember expects const T& and the mutable ref to member implicitly converts into const ref to member.
1843
1844         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp:
1845         (ReportMemoryUsageVisitor):
1846         (clang::AddMemberCallVisitor::VisitCallExpr):
1847         (clang::ReportMemoryUsageVisitor::VisitCXXMethodDecl):
1848         (clang::ReportMemoryUsageVisitor::checkMembersCoverage):
1849
1850 2012-12-29  Ilya Tikhonovsky  <loislo@chromium.org>
1851
1852         Web Inspector: Native Memory Instrumentation plugin: move function bodies out of class declarations.
1853         https://bugs.webkit.org/show_bug.cgi?id=105852
1854
1855         Reviewed by Alexander Pavlov.
1856
1857         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp:
1858         (clang):
1859         (AddMemberCallVisitor):
1860         (ReportMemoryUsageVisitor):
1861         (clang::ReportMemoryUsageAction::ParseArgs):
1862         (clang::AddMemberCallVisitor::VisitCallExpr):
1863         (clang::ReportMemoryUsageVisitor::VisitCXXMethodDecl):
1864         (clang::ReportMemoryUsageVisitor::emitWarning):
1865         (clang::ReportMemoryUsageVisitor::findInstrumentationMethod):
1866         (clang::ReportMemoryUsageVisitor::needsToBeInstrumented):
1867         (clang::ReportMemoryUsageVisitor::CheckMembersCoverage):
1868
1869 2012-12-29  Zan Dobersek  <zandobersek@gmail.com>
1870
1871         [webkitpy] Omit webkitpy/thirdparty/BeautifulSoup.py from code coverage checking
1872         https://bugs.webkit.org/show_bug.cgi?id=105835
1873
1874         Reviewed by Dirk Pranke.
1875
1876         The BeautifulSoup module is a third-party import and as such we don't have much control
1877         over its testing. Because of that it should be omitted from code coverage checking.
1878
1879         * Scripts/webkitpy/test/main.py:
1880         (Tester._run_tests):
1881
1882 2012-12-28  Martin Robinson  <mrobinson@igalia.com>
1883
1884         [GTK][WK2] Add support for IME Composition
1885         https://bugs.webkit.org/show_bug.cgi?id=65093
1886
1887         Reviewed by Carlos Garcia Campos.
1888
1889         Update unit tests for GtkInputMethodFilter to note whether or not an event
1890         was a fake event synthesized for composition purposes. This is now used
1891         for WebKit2.
1892
1893         * TestWebKitAPI/Tests/gtk/InputMethodFilter.cpp:
1894         (TestWebKitAPI::TestInputMethodFilter::sendSimpleKeyEvent):
1895         (TestWebKitAPI::TestInputMethodFilter::sendKeyEventWithCompositionResults):
1896         (TestWebKitAPI::TEST):
1897         * gtk/generate-gtkdoc:
1898         (get_webkit2_options): Skip new files in the WebKit2 source directory for documentation
1899         generation.
1900
1901 2012-12-27  Ilya Tikhonovsky  <loislo@chromium.org>
1902
1903         Web Inspector: Native Memory Instrumentation. Update clang plugin according to the current state of memory instrumentation code.
1904         https://bugs.webkit.org/show_bug.cgi?id=105800
1905
1906         Reviewed by Yury Semikhatsky.
1907
1908         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp:
1909         (clang::ReportMemoryUsageConsumer::ReportMemoryUsageConsumer):
1910         (clang):
1911
1912 2012-12-27  Zan Dobersek  <zandobersek@gmail.com>
1913
1914         Create a GTK build system watchlist and add myself to it
1915         https://bugs.webkit.org/show_bug.cgi?id=105769
1916
1917         Reviewed by Dirk Pranke.
1918
1919         Add a GTK build system watchlist, watching the configure.ac, GNUmakefile.am files
1920         and the input GNUmakefile.features.am.in file. The GNUmakefile.list.am files are
1921         omitted on purpose due to relatively high change rate they are exposed to.
1922
1923         The new watchlist would be of use to me as the GTK build system recently went
1924         through a series of changes that included a changed policy on adding configuration
1925         flags to configure.ac and subsequent additions to GNUmakefile.am files. A PSA on the
1926         mailing list about this change will be published later, but I'd also like to be
1927         notified of any pending changes to these files just so I can check the changes are
1928         in compliance with the new policy.
1929
1930         * Scripts/webkitpy/common/config/watchlist:
1931
1932 2012-12-26  Ilya Tikhonovsky  <loislo@chromium.org>
1933
1934         Unreviewed. Replace find("Tools") with rfind("Tools") because base dir of WebKit may have Tools word.
1935         As example ..../DevTools/src/third_party/WebKit
1936
1937         * Scripts/webkitpy/common/webkit_finder.py:
1938         (WebKitFinder.webkit_base):
1939
1940 2012-12-25  Christophe Dumez  <christophe.dumez@intel.com>
1941
1942         [EFL][WK2] Refactor snapshot taking code
1943         https://bugs.webkit.org/show_bug.cgi?id=105687
1944
1945         Reviewed by Kenneth Rohde Christiansen.
1946
1947         Call WKViewCreateSnapshot() instead of WKViewGetSnapshot()
1948         since the function was renamed to follow naming style.
1949
1950         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1951         (WTR::PlatformWebView::windowSnapshotImage):
1952
1953 2012-12-24  Ilya Tikhonovsky  <loislo@chromium.org>
1954
1955         Web Inspector: Native Memory Instrumentation: propagate member type as edge type to the serialized heap graph.
1956         https://bugs.webkit.org/show_bug.cgi?id=105725
1957
1958         Reviewed by Yury Semikhatsky.
1959
1960         MemberType value names were adjusted according to Style Guide.
1961         Existing tests were extended with link type validation.
1962
1963         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
1964
1965 2012-12-24  Xiaobo Wang  <xbwang@torchmobile.com.cn>
1966
1967         [BlackBerry] DRT - Crashed when running pixels tests
1968         https://bugs.webkit.org/show_bug.cgi?id=105711
1969
1970         RIM PR 270003
1971
1972         Reviewed by George Staikos.
1973
1974         Calling window->post() here will result in buffer swapping which is
1975         only allowed in UI thread now, and I found we don't need to call it
1976         for GL renderer.
1977
1978         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
1979         (createBitmapContextFromWebView):
1980
1981 2012-12-22  Dan Winship  <danw@gnome.org>
1982
1983         Add a patch to fix libxml2 2.9.0 regression
1984         https://bugs.webkit.org/show_bug.cgi?id=104494
1985
1986         Reviewed by Martin Robinson.
1987
1988         * gtk/jhbuild.modules:
1989         * gtk/patches/libxml2-2.9.0-dtd.patch: patch from upstream
1990
1991 2012-12-23  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1992
1993         Unreviewed update of status to reviewer.
1994
1995         * Scripts/webkitpy/common/config/committers.py:
1996
1997 2012-12-23  Philippe Normand  <pnormand@igalia.com>
1998
1999         [GTK][jhbuild] Bump GStreamer to 1.0.4
2000         https://bugs.webkit.org/show_bug.cgi?id=105640
2001
2002         Reviewed by Martin Robinson.
2003
2004         * gtk/jhbuild.modules: Update GStreamer modules to 1.0.4.
2005
2006 2012-12-21  Nico Weber  <thakis@chromium.org>
2007
2008         chromium: webkit-build-directory doesn't handle ninja output dirs
2009         https://bugs.webkit.org/show_bug.cgi?id=105671
2010
2011         Reviewed by Daniel Bates.
2012
2013         Teach webkit-build-directory to detect the ninja build directory.
2014
2015         * Scripts/webkitdirs.pm:
2016         (determineBaseProductDir):
2017         (determineIsChromiumNinja):
2018
2019 2012-12-21  Ryosuke Niwa  <rniwa@webkit.org>
2020
2021         [Mountain Lion] platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation.html failing
2022         https://bugs.webkit.org/show_bug.cgi?id=95477
2023
2024         Reviewed by Sam Weinig.
2025
2026         Co-authored by Jia Pu.
2027
2028         Specify a fixed autocorrection dictionary in resetDefaultsToConsistentValues() so that
2029         we can have consistent autocorrection behavior when running tests.
2030
2031         * DumpRenderTree/mac/DumpRenderTree.mm:
2032         (resetDefaultsToConsistentValues):
2033         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2034         (WTR::InjectedBundle::platformInitialize):
2035
2036 2012-12-21  Zan Dobersek  <zandobersek@gmail.com>
2037
2038         [GTK] Add WebKit1-specific TestExpectations file
2039         https://bugs.webkit.org/show_bug.cgi?id=97562
2040
2041         Reviewed by Dirk Pranke.
2042
2043         Implement the expectations_files method inside the GtkPort class that
2044         returns the list of the TestExpectations files the current test configuration
2045         requires. The method is implemented in a similar way as on the EFL port.
2046         A unit test is also added.
2047
2048         * Scripts/webkitpy/layout_tests/port/gtk.py:
2049         (GtkPort._search_paths):
2050         (GtkPort):
2051         (GtkPort.expectations_files):
2052         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
2053         (GtkPortTest.test_expectations_files):
2054
2055 2012-12-21  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2056
2057         [EFL] Enable feature option for the CSS sticky position
2058         https://bugs.webkit.org/show_bug.cgi?id=105630
2059
2060         Reviewed by Kenneth Rohde Christiansen.
2061
2062         Enable CSS sticky position feature by default for the
2063         EFL port. This feature option was added in r138252.
2064
2065         No new tests. Existing layout tests pass.
2066
2067         * Scripts/webkitperl/FeatureList.pm:
2068
2069 2012-12-21  Jussi Kukkonen  <jussi.kukkonen@intel.com>
2070
2071         [WK2] REGRESSION(r138232): It made 4 tests timeout
2072         https://bugs.webkit.org/show_bug.cgi?id=105623
2073
2074         Reviewed by Kenneth Rohde Christiansen.
2075
2076         r138232 changed functionality so that empty text output
2077         no longer leads to a dump() call, which leads to a timeout.
2078         Instead do a text dump if there is text output or if there
2079         is no audio output.
2080
2081         * WebKitTestRunner/TestInvocation.cpp:
2082         (WTR::TestInvocation::dumpResults):
2083
2084 2012-12-21  Zeno Albisser  <zeno@webkit.org>
2085
2086         [Qt][Mac] run-launcher cannot find Qt5WebKitWidgets.
2087         https://bugs.webkit.org/show_bug.cgi?id=105309
2088
2089         On Windows the library name is Qt5WebKitWidgets as well.
2090         So r138136 should not have adjusted the library name for Windows.
2091
2092         Reviewed by Simon Hausmann.
2093
2094         * Scripts/webkitdirs.pm:
2095         (builtDylibPathForName):
2096
2097 2012-12-21  Zeno Albisser  <zeno@webkit.org>
2098
2099         [Qt] Add new TestExpectations for qt-5.0-mac-wk2.
2100         https://bugs.webkit.org/show_bug.cgi?id=105424
2101
2102         This change will allow us to run a very specific
2103         subset of the available LayoutTests on a mac buildbot.
2104         The new baseline search path for mac will look as follows:
2105         qt-5.0-mac-wk2 -> qt-5.0-wk2 -> qt-5.0 -> qt-mac -> qt
2106
2107         Reviewed by Dirk Pranke.
2108
2109         * Scripts/webkitpy/layout_tests/port/qt.py:
2110         (QtPort._search_paths):
2111         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2112         (QtPortTest):
2113
2114 2012-12-20  Ryuan Choi  <ryuan.choi@samsung.com>
2115
2116         [EFL] Build break with latest EFL libraries.
2117         https://bugs.webkit.org/show_bug.cgi?id=104827
2118
2119         Reviewed by Laszlo Gombos.
2120
2121         The eo EFL package is introduced and evas and ecore use it since 1.8.
2122         While introducing Eo, EFL changed several structures of Evas and Ecore
2123         from own specific class to Eo.
2124
2125         So, this patch adds FindEo and changes declaration of Evas, Evas_Object,
2126         Ecore_Timer to build with latest EFL libraries.
2127
2128         * DumpRenderTree/efl/CMakeLists.txt: Includes eo EFL library.
2129         * EWebLauncher/CMakeLists.txt: Ditto.
2130         * MiniBrowser/efl/CMakeLists.txt: Ditto.
2131         * ImageDiff/PlatformEfl.cmake: Ditto.
2132         * TestWebKitAPI/PlatformEfl.cmake: Ditto.
2133         * TestWebKitAPI/PlatformWebView.h: Modified declaration of Evas_Object.
2134         * WebKitTestRunner/InjectedBundle/TestRunner.h: Modified declaration of Ecore_Timer.
2135         * WebKitTestRunner/PlatformEfl.cmake: Includes eo EFL library.
2136         * WebKitTestRunner/PlatformWebView.h: Modified declaration of Evas_Object.
2137
2138 2012-12-20  Dirk Pranke  <dpranke@chromium.org>
2139
2140         TestExpectation fallback is broken
2141         https://bugs.webkit.org/show_bug.cgi?id=105583
2142
2143         Reviewed by Ryosuke Niwa.
2144
2145         When I added support for the -wk2 in port names, it looks
2146         like I broke the way we computed the list of TestExpectations
2147         files so that the implementation-version directory was left out :(.
2148         Fixed and cleaned up the tests.
2149
2150         * Scripts/webkitpy/layout_tests/port/base.py:
2151         (Port.expectations_files):
2152         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2153         (TestWebKitPort.__init__):
2154         (PortTestCase.test_skipped_directories_for_symbols):
2155         (test_skipped_directories_for_features):
2156         (test_skipped_directories_for_features_no_matching_tests_in_test_list):
2157         (test_skipped_tests_for_unsupported_features_empty_test_list):
2158         (test_skipped_layout_tests):
2159         (test_expectations_files):
2160
2161 2012-12-20  Anders Carlsson  <andersca@apple.com>
2162
2163         Don't include WebKit2 headers when building TestWebKitAPI on windows
2164         https://bugs.webkit.org/show_bug.cgi?id=105582
2165
2166         Reviewed by Tim Horton.
2167
2168         * TestWebKitAPI/config.h:
2169         * TestWebKitAPI/win/main.cpp:
2170
2171 2012-12-20  Ryosuke Niwa  <rniwa@webkit.org>
2172
2173         REGRESSION(r133820?): SimplifyMarkupTest API test asserts
2174         https://bugs.webkit.org/show_bug.cgi?id=105370
2175
2176         Reviewed by Simon Fraser.
2177
2178         Re-enable the test.
2179
2180         * TestWebKitAPI/Tests/mac/SimplifyMarkup.mm:
2181         (TestWebKitAPI::TEST):
2182
2183 2012-12-20  Nico Weber  <thakis@chromium.org>
2184
2185         chromium nrwt: Pick the newest binary found in DEFAULT_BUILD_DIRECTORIES, not the first
2186         https://bugs.webkit.org/show_bug.cgi?id=105498
2187
2188         Reviewed by Dirk Pranke.
2189
2190         Use the newest binary available rather than an than always picking one
2191         build directory over another based on iteration order.
2192
2193         * Scripts/webkitpy/layout_tests/port/chromium.py:
2194         (ChromiumPort._static_build_path):
2195         Check for timestamps.
2196         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2197         (ChromiumMacPortTest.test_build_path_timestamps):
2198         Test that out / xcodebuild selection happens based on timestamps
2199         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2200         (ChromiumWinPortTest.test_build_path_timestamps):
2201         Test that out / build selection happens based on timestamps
2202
2203 2012-12-19  Simon Fraser  <simon.fraser@apple.com>
2204
2205         Lots of sticky tests failing in WK2
2206         https://bugs.webkit.org/show_bug.cgi?id=105464
2207
2208         Reviewed by Beth Dakin.
2209
2210         WebKitTestRunner had a race between snapshotting in the UI process,
2211         and resettting after the test in the web process. InjectedBundle::done()
2212         was a bad place to call page()->resetAfterTest(), because of this race;
2213         it could reset the scroll position before the UI snapshot had been obtained.
2214         
2215         Fix by moving the call to page()->resetAfterTest() into didReceiveMessage(),
2216         for the "Reset" message which will come in before the next test.
2217
2218         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2219         (WTR::InjectedBundle::didReceiveMessage):
2220         (WTR::InjectedBundle::done):
2221
2222 2012-12-19  Filip Pizlo  <fpizlo@apple.com>
2223
2224         DFG speculation checks that take JumpList should consolidate OSRExits
2225         https://bugs.webkit.org/show_bug.cgi?id=105401
2226
2227         Reviewed by Oliver Hunt.
2228
2229         Update the profiler to understand that an OSR exit may have multiple
2230         candidate exit sites.
2231
2232         * Scripts/display-profiler-output:
2233
2234 2012-12-20  Eric Seidel  <eric@webkit.org>
2235
2236         EWSes do not need to dump build/test logs when things pass
2237         https://bugs.webkit.org/show_bug.cgi?id=105402
2238
2239         Reviewed by Dirk Pranke.
2240
2241         When we were first writing the commit-queue and EWS system
2242         and running them locally, we thought it was important to see the
2243         build/test output as it happened.  Now these queues have been running
2244         for years, and we don't use this feature anymore.  So this patch
2245         makes us stop tee-ing the output directly to stdout, and instead
2246         only print any output from commands when they fail.
2247
2248         I also added some logging when we execute each command
2249         since we are no longer printing the command output itself.
2250         This should make it much easier to see errors with the EWS
2251         system itself, now that all the passing-build output is removed.
2252
2253         This required updating a zillion unittests, since we have a bunch of
2254         "integration" style testing of the queue-bots.  Many of the unittests for the bots were
2255         already approximating this behavior by using a "logging" Executive.
2256         I disabled logging in those cases to avoid redundant logging in those tests.
2257
2258         * Scripts/webkitpy/common/system/executive.py:
2259         (Executive.command_for_printing):
2260         (Executive.run_command):
2261         * Scripts/webkitpy/common/system/executive_mock.py:
2262         (MockExecutive.command_for_printing):
2263         (MockExecutive.run_command):
2264         * Scripts/webkitpy/common/system/executive_unittest.py:
2265         (ExecutiveTest.test_auto_stringify_args):
2266         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2267         (EarlyWarningSytemTest._default_expected_logs):
2268         (_test_ews):
2269         (_test_ewses):
2270         * Scripts/webkitpy/tool/commands/queues.py:
2271         (AbstractQueue.run_webkit_patch):
2272         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2273         (AbstractQueueTest._assert_run_webkit_patch):
2274         (CommitQueueTest.test_commit_queue):
2275         (test_rollout):
2276         (test_rollout_lands):
2277         (test_manual_reject_during_processing):
2278         (StyleQueueTest.test_style_queue_with_style_exception):
2279         (test_style_queue_with_watch_list_exception):
2280
2281 2012-12-20  Dominic Mazzoni  <dmazzoni@google.com>
2282
2283         AX: support clickPoint in DRT for chromium
2284         https://bugs.webkit.org/show_bug.cgi?id=97359
2285
2286         Reviewed by Chris Fleizach.
2287
2288         Implement clickPointX, clickPointY, and elementAtPoint for Chromium, so that
2289         several more tests can pass.
2290
2291         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
2292         (WebTestRunner::AccessibilityUIElement::AccessibilityUIElement):
2293         (WebTestRunner::AccessibilityUIElement::clickPointXGetterCallback):
2294         (WebTestRunner):
2295         (WebTestRunner::AccessibilityUIElement::clickPointYGetterCallback):
2296         (WebTestRunner::AccessibilityUIElement::elementAtPointCallback):
2297         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h:
2298         (AccessibilityUIElement):
2299
2300 2012-12-20  Dan Bernstein  <mitz@apple.com>
2301
2302         prepare-ChangeLog adds "Additional information of the change such as approach, rationale" where it doesn't make sense
2303         https://bugs.webkit.org/show_bug.cgi?id=99268
2304
2305         Reviewed by Alexey Proskuryakov.
2306
2307         * Scripts/prepare-ChangeLog:
2308         (generateNewChangeLogs): Removed the "Additional information of the change" line.
2309
2310 2012-12-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2311
2312         Unreviewed. Skip unit test /webkit/atk/getTextInParagraphAndBodyModerate
2313
2314         * Scripts/run-gtk-tests:
2315         (TestRunner):
2316
2317 2012-12-20  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2318
2319         [Qt] Move ImageDiff to the Tools directory root
2320         https://bugs.webkit.org/show_bug.cgi?id=105420
2321
2322         Reviewed by Tor Arne Vestbø.
2323
2324         Moved ImageDiff from outside DumpRenderTree because it is also a
2325         dependency when running pixel tests for WebKit2.
2326
2327         * ImageDiff/ImageDiff.pro: Renamed from Tools/DumpRenderTree/qt/ImageDiff.pro.
2328         * ImageDiff/qt/ImageDiff.cpp: Renamed from Tools/DumpRenderTree/qt/ImageDiff.cpp.
2329         * Tools.pro:
2330
2331 2012-12-20  Zan Dobersek  <zandobersek@gmail.com>
2332
2333         [GTK] Remove the --enable-unstable-features configuration option
2334         https://bugs.webkit.org/show_bug.cgi?id=105327
2335
2336         Reviewed by Martin Robinson.
2337
2338         Add a missing feature option for the CSS sticky position feature.
2339
2340         * Scripts/webkitperl/FeatureList.pm:
2341
2342 2012-12-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2343
2344         Unreviewed. Skip unit test WebKit2.ForceRepaint that times out
2345
2346         * Scripts/run-gtk-tests:
2347         (TestRunner):
2348
2349 2012-12-20  Dominik Röttsches  <dominik.rottsches@intel.com>
2350
2351         [EFL] MiniBrowser does not play Infinite Gangnam Style
2352         https://bugs.webkit.org/show_bug.cgi?id=103531
2353
2354         Reviewed by Kenneth Rohde Christiansen.
2355
2356         For EFL we would like this feature to be built by default.
2357
2358         * Scripts/webkitperl/FeatureList.pm:
2359
2360 2012-12-20  Csaba Osztrogonác  <ossy@webkit.org>
2361
2362         [Qt] EWS bots should call qmake always
2363         https://bugs.webkit.org/show_bug.cgi?id=90049
2364
2365         Reviewed by Simon Hausmann.
2366
2367         * Scripts/webkitdirs.pm:
2368         (buildQMakeProjects):
2369
2370 2012-12-20  Jochen Eisinger  <jochen@chromium.org>
2371
2372         [chromium] fix stray printf in TestRunner's WebTestProxy
2373         https://bugs.webkit.org/show_bug.cgi?id=105515
2374
2375         Reviewed by Ryosuke Niwa.
2376
2377         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2378         (WebTestRunner::WebTestProxyBase::shouldInsertNode):
2379
2380 2012-12-20  Dominik Röttsches  <dominik.rottsches@intel.com>
2381
2382         [WK2] WebAudio WKTR support
2383         https://bugs.webkit.org/show_bug.cgi?id=95084
2384
2385         Reviewed by Kenneth Rohde Christiansen.
2386
2387         Implementing audio data dump support for WebKitTestRunner,
2388         by adding the API to the IDL, enabling IPC for transferring
2389         the audio data as bytebuffer and dumping it according
2390         to run-webkit-tests script's expectations.
2391         This enables audio testing on WebKit2 ports.
2392         Based on initial wip-patch from Philippe Normand - thanks.
2393
2394         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Adding setAudioData API.
2395         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Assign audio buffer data to a local WKDataRef after extracting it from WK2 using WKBundleDataFromUint8Array bundle API.
2396         (WTR::TestRunner::setAudioData):
2397         (WTR):
2398         * WebKitTestRunner/InjectedBundle/TestRunner.h: Add a whatToDump state for dumping Audio.
2399         (TestRunner):
2400         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: Add audio to the message that's transferred to the WKTR process.
2401         (WTR::InjectedBundle::done):
2402         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: Allow setting and audio result handle to be transferred.
2403         (WTR::InjectedBundle::setAudioResult):
2404         (InjectedBundle):
2405         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2406         (WTR::InjectedBundlePage::dump): Dummy handling the Audio case in the switch, build fix for Mac.
2407         * WebKitTestRunner/TestInvocation.cpp: Audio dump support, dump audio if we haven't received a text dump from the web process.
2408         (WTR::TestInvocation::dumpResults):
2409         (WTR):
2410         (WTR::TestInvocation::dumpAudio):
2411         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Storing received audio data before dumping.
2412         * WebKitTestRunner/TestInvocation.h:
2413         (TestInvocation):
2414
2415 2012-12-20  Alberto Garcia  <agarcia@igalia.com>
2416
2417         [GTK] Count failed and timed out tests separately
2418         https://bugs.webkit.org/show_bug.cgi?id=105448
2419
2420         Reviewed by Carlos Garcia Campos.
2421
2422         Display the number of tests that fail, time out and are skipped
2423         separately in the buildbot page.
2424
2425         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2426         (RunGtkAPITests.commandComplete):
2427         (RunGtkAPITests.evaluateCommand):
2428         (RunGtkAPITests.getText2):
2429         * Scripts/run-gtk-tests:
2430         (TestRunner.run_tests):
2431
2432 2012-12-19  Ryosuke Niwa  <rniwa@webkit.org>
2433
2434         PerfTest.parse_output does too much
2435         https://bugs.webkit.org/show_bug.cgi?id=105391
2436
2437         Reviewed by Tony Chang.
2438
2439         Moved the code to filter lines into PerfTest._filter_output, which has been renamed from _filter_stderr.
2440         Also moved the code to output test results into PerfTest._run_with_driver.
2441
2442         * Scripts/webkitpy/performance_tests/perftest.py:
2443         (PerfTest.__init__): Added _description.
2444         (PerfTest.description): Added.
2445         (PerfTest._run_with_driver): Moved the code to output test description and test results.
2446         (PerfTest._filter_output): Moved and renamed from PerfTest._filter_stderr.
2447         (PerfTest.parse_output): Removed the code to output test results. Return test results and description
2448         respectively. Also removed the code that allowed some tests to omit values since all tests report each
2449         iteration now since r136492.
2450         (PerfTest.output_statistics): Removed the code to print test description, now done in _run_with_driver.
2451         (ChromiumStylePerfTest._run_with_driver): Added. Chromium style tests are sufficiently different from
2452         regular PerfTest that it doesn't make much sense to share _run_with_driver. But really, we should just
2453         get rid of this type of test altogether in favor of regular performance tests that uses runner.js.
2454         (ChromiumStylePerfTest.parse_and_log_output): Renamed from parse_output.
2455         (PageLoadingPerfTest._run_with_driver): Removed the explicit '' for the test description.
2456         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2457         (MainTest.test_parse_output): Removed the expected logs since parse_output no longer prints out results.
2458         Also added a call to _filter_output since parse_output doesn't filter the output text anymore.
2459         (MainTest.test_parse_output_with_failing_line): Added a call to _filter_output. Also added ',' after 'Time:'
2460         so that it's not string-concatenated with the next line.
2461         (MainTest.test_parse_output_with_description): Added; a test for PerfTest.description().
2462         (MainTest.test_parse_output_with_subtests): Removed the expected logs, and added a call to _filter_output.
2463
2464 2012-12-19  Alexis Menard  <alexis@webkit.org>
2465
2466         Implement CSS parsing for CSS transitions unprefixed.
2467         https://bugs.webkit.org/show_bug.cgi?id=104804
2468
2469         Reviewed by Dean Jackson.
2470
2471         Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
2472         to cover the work of unprefixing Transforms, Animations and 
2473         Transitions. It will let the possibility of each ports to turn it off 
2474         in their release branches until we're confident that these CSS 
2475         properties are ready to be unprefixed.
2476
2477         * Scripts/webkitperl/FeatureList.pm:
2478         * qmake/mkspecs/features/features.pri:
2479
2480 2012-12-19  Julien Chaffraix  <jchaffraix@webkit.org>
2481
2482         2 clampTo unit tests are failing
2483         https://bugs.webkit.org/show_bug.cgi?id=105253
2484
2485         Reviewed by Emil A Eklund.
2486
2487         Removed clampToUnsigned as it was actually testing exactly what
2488         clampToUnsignedLong was doing. Also made clampToIntFloat more robust
2489         to precision loss (fix suggested by Emil).
2490
2491         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2492
2493 2012-12-19  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2494
2495         [EFL] Move ImageDiff to the Tools directory root
2496         https://bugs.webkit.org/show_bug.cgi?id=105305
2497
2498         Reviewed by Laszlo Gombos.
2499
2500         We previously moved this directory from the DRT directory to
2501         efl/ImageDiff. The major reason for doing so was because ImageDiff does
2502         not depend on DumpRenderTree but for legacy reasons was living inside the
2503         DRT folder, even though it is needed when running pixel tests for WK2.
2504
2505         Now we are moving to Tool directory root as other ports agreed to do the same.
2506
2507         * CMakeLists.txt:
2508         * ImageDiff/CMakeLists.txt: Added.
2509         * ImageDiff/PlatformEfl.cmake: Added.
2510         * ImageDiff/efl/ImageDiff.cpp: Renamed from Tools/efl/ImageDiff/ImageDiff.cpp.
2511         * efl/ImageDiff/CMakeLists.txt: Removed.
2512
2513 2012-12-19  Zeno Albisser  <zeno@webkit.org>
2514
2515         [Qt][Mac] run-launcher cannot find Qt5WebKitWidgets.
2516         https://bugs.webkit.org/show_bug.cgi?id=105309
2517
2518         The version number is only used as a part
2519         of the library name on Linux.
2520
2521         Reviewed by Kenneth Rohde Christiansen.
2522
2523         * Scripts/webkitdirs.pm:
2524         (builtDylibPathForName):
2525
2526 2012-12-19  Alberto Garcia  <agarcia@igalia.com>
2527
2528         [GTK] Tests that time out are not considered as failures.
2529         https://bugs.webkit.org/show_bug.cgi?id=105318
2530
2531         Reviewed by Martin Robinson.
2532
2533         Fix parsing of the GTK API tests log files.
2534
2535         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2536         (RunGtkAPITests.commandComplete):
2537
2538 2012-12-18  Ilya Tikhonovsky  <loislo@chromium.org>
2539
2540         Unreviewed, rolling out r138061.
2541         https://bugs.webkit.org/show_bug.cgi?id=105396
2542
2543         Original patch:
2544         http://trac.webkit.org/changeset/138061
2545         https://bugs.webkit.org/show_bug.cgi?id=97359
2546
2547         It is crashing on Debug bots
2548
2549         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
2550         (WebTestRunner::AccessibilityUIElement::AccessibilityUIElement):
2551         (WebTestRunner::AccessibilityUIElement::elementAtPointCallback):
2552         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h:
2553         (AccessibilityUIElement):
2554
2555 2012-12-18  Alice Liu  <alice.liu@apple.com>
2556
2557         Test for https://bugs.webkit.org/show_bug.cgi?id=105106
2558         Add SPI to WebKit1 WebFrame for hit testing
2559
2560         Reviewed by Dan Bernstein.
2561
2562         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added file Tests/mac/ElementAtPointInWebFrame.mm
2563         * TestWebKitAPI/Tests/mac/ElementAtPointInWebFrame.mm: Added.
2564         (TestWebKitAPI::TEST): Loads html with two divs positioned in the 2nd and 4th quadrants of the webview.
2565         Then hit-tests at three points, expecting to hit the two divs and body element. 
2566
2567 2012-12-18  Alice Liu  <alice.liu@apple.com>
2568
2569         Test for https://bugs.webkit.org/show_bug.cgi?id=105262
2570         Add SPI to WebKit1 WebFrame for node conversion to JSValueRef
2571
2572         Reviewed by Anders Carlsson.
2573
2574         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added file Tests/mac/JSWrapperForNodeInWebFrame.mm.mm
2575         * TestWebKitAPI/Tests/mac/JSWrapperForNodeInWebFrame.mm.mm: Added.
2576         (TestWebKitAPI::TEST): Tests for the correct JS wrapper for a DOMNode, provided a WebScriptWorld.
2577         Loads html with a single div element. In an isolated world, creates a property on that node.
2578         Also, in the standard world, creates a different property on that node.  Then tests for 4 things:
2579             - Existence of the isolated property in the isolated world.
2580             - Existence of the standard property in the standard world.
2581             - Non-existence of the isolated property in the standard world.
2582             - Non-existence of the standard property in the isolated world.
2583
2584 2012-12-18  Simon Fraser  <simon.fraser@apple.com>
2585
2586         Disable the SimplifyMarkup API test, wich asserts in debug builds.
2587         Tracked by https://bugs.webkit.org/show_bug.cgi?id=105370.
2588         
2589         * TestWebKitAPI/Tests/mac/SimplifyMarkup.mm:
2590         (TestWebKitAPI::TEST):
2591
2592 2012-12-18  Joseph Pecoraro  <pecoraro@apple.com>
2593
2594         [Mac] Add Build Phase to Check Headers for Inappropriate Macros (Platform.h macros)
2595         https://bugs.webkit.org/show_bug.cgi?id=104279
2596
2597         Reviewed by David Kilzer.
2598
2599         Add a build phase script that checks a framework's header files for
2600         Platform.h and Compiler.h macros. Also add some tests for the script.
2601
2602         * Scripts/check-for-inappropriate-macros-in-external-headers: Added.
2603         Script to be used in build phases to check for inappropriate macros in headers.
2604
2605         * Scripts/test-webkitruby: Added.
2606         Script that can be used to run all webkitruby tests.
2607
2608         * Scripts/test-webkit-scripts:
2609         Also run the ruby tests.
2610
2611         * Scripts/webkitruby/check-for-inappropriate-macros-in-external-headers-tests/fake-data-failing-expected.txt: Added.
2612         * Scripts/webkitruby/check-for-inappropriate-macros-in-external-headers-tests/pass-expected.txt: Added.
2613         * Scripts/webkitruby/check-for-inappropriate-macros-in-external-headers-tests/resources/Fake.framework/Headers/Fail.h: Added.
2614         * Scripts/webkitruby/check-for-inappropriate-macros-in-external-headers-tests/resources/Fake.framework/Headers/Pass.h: Added.
2615         * Scripts/webkitruby/check-for-inappropriate-macros-in-external-headers-tests/run-test.rb: Added.
2616         Tests for the new script.
2617
2618 2012-12-18  Dominic Mazzoni  <dmazzoni@google.com>
2619
2620         AX: support clickPoint in DRT for chromium
2621         https://bugs.webkit.org/show_bug.cgi?id=97359
2622
2623         Reviewed by Chris Fleizach.
2624
2625         Implement clickPointX, clickPointY, and elementAtPoint for Chromium, so that
2626         several more tests can pass.
2627
2628         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
2629         (WebTestRunner::AccessibilityUIElement::AccessibilityUIElement):
2630         (WebTestRunner::AccessibilityUIElement::clickPointXGetterCallback):
2631         (WebTestRunner):
2632         (WebTestRunner::AccessibilityUIElement::clickPointYGetterCallback):
2633         (WebTestRunner::AccessibilityUIElement::elementAtPointCallback):
2634         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h:
2635         (AccessibilityUIElement):
2636
2637 2012-12-18  Ryosuke Niwa  <rniwa@webkit.org>
2638
2639         Build fix after r138045.
2640
2641         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2642         (PerfTestsRunner._collect_tests): Use relative_path. We skip only when this path
2643         is not explicitly specified. The condition was backwards but never matched so we
2644         always ran the test regardless of whether it's listed in the skipped list or not.
2645         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2646         (test_collect_tests_with_ignored_skipped_list): Renamed so that it actually runs.
2647
2648 2012-12-18  Emil A Eklund  <eae@chromium.org>
2649
2650         TestWebKitAPI/Tests/WebCore/LayoutUnit fails on mac
2651         https://bugs.webkit.org/show_bug.cgi?id=105332
2652         
2653         Reviewed by Levi Weintraub.
2654         
2655         Create new test suite for LayoutUnit tests as the KURL tests are
2656         of the incompatible TEST_F type.
2657
2658         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
2659         (TestWebKitAPI):
2660         (TestWebKitAPI::TEST_F):
2661
2662 2012-12-18  Ryosuke Niwa  <rniwa@webkit.org>
2663
2664         Running a skipped test with run-perf-tests could alert the user
2665         https://bugs.webkit.org/show_bug.cgi?id=105219
2666
2667         Reviewed by Eric Seidel.
2668
2669         Force run skipped performance tests explicitly specified in the command line.
2670         Also warn the user when the specified paths don't exist.
2671
2672         * Scripts/webkitpy/layout_tests/port/base.py:
2673         (Port.relative_test_filename):
2674         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2675         (PerfTestsRunner._parse_args):
2676         (PerfTestsRunner._collect_tests):
2677         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2678         (test_collect_tests_with_skipped_list_and_files):
2679
2680 2012-12-18  Yaron Friedman  <yfriedman@chromium.org>
2681
2682         Chrome Android java output is too verbose
2683         https://bugs.webkit.org/show_bug.cgi?id=105247
2684
2685         Reviewed by Tony Chang.
2686
2687         Pass -quiet to ant to suppress extraneous output.
2688
2689         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2690         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
2691
2692 2012-12-18  Ryosuke Niwa  <rniwa@webkit.org>
2693
2694         Consider removing --pause-before-testing option
2695         https://bugs.webkit.org/show_bug.cgi?id=105248
2696
2697         Reviewed by Eric Seidel.
2698
2699         Remove --pause-before-testing option.
2700
2701         * Tools/Scripts/webkitpy/layout_tests/port/driver.py:
2702         (DriverProxy.start): Removed.
2703         * Scripts/webkitpy/performance_tests/perftest.py:
2704         (PerfTest.__init__):
2705         (PerfTest.test_path): Renamed from path_or_url.
2706         (PerfTest.run):
2707         (PerfTest): Removed "driver" argument.
2708         (PerfTest._run_with_driver):
2709         (PerfTest.run_single):
2710         (ChromiumStylePerfTest.__init__):
2711         (PageLoadingPerfTest.__init__):
2712         (PageLoadingPerfTest.run_single):
2713         (PageLoadingPerfTest._run_with_driver): Renamed from run so that PerfTest.run can create a driver for us.
2714         (ReplayPerfTest.__init__):
2715         (ReplayPerfTest.prepare):
2716         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2717         (TestPageLoadingPerfTest.test_run):
2718         (TestPageLoadingPerfTest.test_run_with_memory_output):
2719         (TestPageLoadingPerfTest.test_run_with_bad_output):
2720         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2721         (PerfTestsRunner._parse_args):
2722         (PerfTestsRunner._run_tests_set): Removed the code to create a driver and pause before running the test.
2723         (PerfTestsRunner._run_single_test): Removed "driver" argument.
2724         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2725         (run_test):
2726         (test_run_test_pause_before_testing): Removed.
2727
2728 2012-12-18  Alberto Garcia  <agarcia@igalia.com>
2729
2730         [GTK] Tests that time out are not considered as failures.
2731         https://bugs.webkit.org/show_bug.cgi?id=105318
2732
2733         Reviewed by Martin Robinson.
2734
2735         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2736         (RunGtkAPITests.commandComplete):
2737         Consider log lines that end with TIMEOUT as errors.
2738
2739         * Scripts/run-gtk-tests:
2740         (TestRunner.run_tests):
2741         Consider timeouts as failures when returning the number of failed
2742         tests.
2743
2744 2012-12-18  Pravin D  <pravin.d@samsung.com>
2745
2746         Unreviewed, adding secondary email.
2747
2748         * Scripts/webkitpy/common/config/committers.py:
2749
2750 2012-12-18  Pravin D  <pravin.d@samsung.com>
2751
2752         Unreviewed, promoting myself to committer's list.
2753
2754         * Scripts/webkitpy/common/config/committers.py:
2755
2756 2012-12-18  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2757
2758         [EFL] ImageDiff does not build on WebKit2 only builds
2759         https://bugs.webkit.org/show_bug.cgi?id=105288
2760
2761         Reviewed by Kenneth Rohde Christiansen.
2762
2763         Moved ImageDiff to the efl/ folder inside Tools/ (so we don't pollute
2764         the folder with things which are EFL-specific.
2765
2766         ImageDiff will be built by default now regardless of WebKit API flavor
2767         you choose.
2768
2769         * CMakeLists.txt:
2770         * DumpRenderTree/efl/CMakeLists.txt:
2771         * efl/ImageDiff/CMakeLists.txt: Added.
2772         * efl/ImageDiff/ImageDiff.cpp: Renamed from Tools/DumpRenderTree/efl/ImageDiff.cpp.
2773
2774 2012-12-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2775
2776         [EFL][WK2] When creating new windows, use the opener's context
2777         https://bugs.webkit.org/show_bug.cgi?id=105283
2778
2779         Reviewed by Laszlo Gombos.
2780
2781         Use the context of the opener if exists.
2782
2783         * MiniBrowser/efl/main.c:
2784         (on_key_down):
2785         (on_window_create):
2786         (window_create):
2787         (elm_main):
2788
2789 2012-12-18  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2790
2791         [EFL][WK2] Gardening of TestWebKitAPI tests
2792         https://bugs.webkit.org/show_bug.cgi?id=105268
2793
2794         Reviewed by Kenneth Rohde Christiansen.
2795
2796         Some tests were marked as failing but are passing and the newly added
2797         LayoutUnit should have it's own binary because it conflicts with the
2798         fixture used by KURL and is failing on the bots because of that.
2799
2800         * TestWebKitAPI/CMakeLists.txt:
2801         * TestWebKitAPI/PlatformEfl.cmake:
2802
2803 2012-12-18  Jochen Eisinger  <jochen@chromium.org>
2804
2805         [chromium] move webintent related methods to TestRunner library
2806         https://bugs.webkit.org/show_bug.cgi?id=105164
2807
2808         Reviewed by Darin Fisher.
2809
2810         Also deleted the unused deliveredIntentFailure and
2811         deliveredIntentResult methods.
2812
2813         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2814         (DRTTestRunner::DRTTestRunner):
2815         * DumpRenderTree/chromium/DRTTestRunner.h:
2816         (DRTTestRunner):
2817         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2818         (WebKit):
2819         (WebTestRunner::WebTestDelegate::setCurrentWebIntentRequest):
2820         (WebTestRunner::WebTestDelegate::currentWebIntentRequest):
2821         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
2822         (WebKit):
2823         (WebTestProxyBase):
2824         (WebTestRunner::WebTestProxy::registerIntentService):
2825         (WebTestRunner::WebTestProxy::dispatchIntent):
2826         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2827         (WebTestRunner::TestRunner::TestRunner):
2828         (WebTestRunner::TestRunner::sendWebIntentResponse):
2829         (WebTestRunner):
2830         (WebTestRunner::TestRunner::deliverWebIntent):
2831         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2832         (TestRunner):
2833         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2834         (WebTestRunner::WebTestProxyBase::postAccessibilityNotification):
2835         (WebTestRunner::WebTestProxyBase::registerIntentService):
2836         (WebTestRunner):
2837         (WebTestRunner::WebTestProxyBase::dispatchIntent):
2838         * DumpRenderTree/chromium/WebViewHost.cpp:
2839         (WebViewHost::setCurrentWebIntentRequest):
2840         (WebViewHost::currentWebIntentRequest):
2841         * DumpRenderTree/chromium/WebViewHost.h:
2842         (WebKit):
2843         (WebViewHost):
2844
2845 2012-12-18  Jochen Eisinger  <jochen@chromium.org>
2846
2847         [chromium] move editing callback dumping to the WebTestProxy
2848         https://bugs.webkit.org/show_bug.cgi?id=105013
2849
2850         Reviewed by Darin Fisher.
2851
2852         To decide whether or not to dump the editing callbacks, the WebTestProxy
2853         needs to query the TestRunner. For this purpose, I introduce a
2854         WebTestRunner class that just exposes the shouldDumpEditingCallbacks
2855         method. In contrast to e.g. WebEventSender, the WebTestRunner is just
2856         an interface, and it is not owned by the WebTestInterfaces, but the
2857         embedder of the TestRunner library must provide it. This will change
2858         once all TestRunner methods are in the library.
2859
2860         * DumpRenderTree/DumpRenderTree.gypi:
2861         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2862         (DRTTestRunner::DRTTestRunner):
2863         (DRTTestRunner::reset):
2864         * DumpRenderTree/chromium/DRTTestRunner.h:
2865         (DRTTestRunner):
2866         (DRTTestRunner::taskList):
2867         (DRTTestRunner::WorkQueue::taskList):
2868         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2869         (WebTestRunner):
2870         (WebTestInterfaces):
2871         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
2872         (WebKit):
2873         (WebTestRunner):
2874         (WebTestProxyBase):
2875         (WebTestRunner::WebTestProxy::shouldBeginEditing):
2876         (WebTestRunner::WebTestProxy::shouldEndEditing):
2877         (WebTestRunner::WebTestProxy::shouldInsertNode):
2878         (WebTestRunner::WebTestProxy::shouldInsertText):
2879         (WebTestRunner::WebTestProxy::shouldChangeSelectedRange):
2880         (WebTestRunner::WebTestProxy::shouldDeleteRange):
2881         (WebTestRunner::WebTestProxy::shouldApplyStyle):
2882         (WebTestRunner::WebTestProxy::didBeginEditing):
2883         (WebTestRunner::WebTestProxy::didChangeSelection):
2884         (WebTestRunner::WebTestProxy::didChangeContents):
2885         (WebTestRunner::WebTestProxy::didEndEditing):
2886         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h.
2887         (WebTestRunner):
2888         (WebTestRunner::WebTestRunner::shouldDumpEditingCallbacks):
2889         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2890         (WebTestRunner::TestRunner::TestRunner):
2891         (WebTestRunner::TestRunner::~TestRunner):
2892         (WebTestRunner):
2893         (WebTestRunner::TestRunner::reset):
2894         (WebTestRunner::TestRunner::shouldDumpEditingCallbacks):
2895         (WebTestRunner::TestRunner::dumpEditingCallbacks):
2896         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2897         (TestRunner):
2898         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2899         (WebTestRunner::WebTestInterfaces::Internal::testRunner):
2900         (WebTestRunner::WebTestInterfaces::Internal::setTestRunner):
2901         (WebTestInterfaces::Internal):
2902         (WebTestRunner::WebTestInterfaces::Internal::Internal):
2903         (WebTestRunner::WebTestInterfaces::testRunner):
2904         (WebTestRunner):
2905         (WebTestRunner::WebTestInterfaces::setTestRunner):
2906         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2907         (WebTestRunner::WebTestProxyBase::postAccessibilityNotification):
2908         (WebTestRunner):
2909         (WebTestRunner::WebTestProxyBase::shouldBeginEditing):
2910         (WebTestRunner::WebTestProxyBase::shouldEndEditing):
2911         (WebTestRunner::WebTestProxyBase::shouldInsertNode):
2912         (WebTestRunner::WebTestProxyBase::shouldInsertText):
2913         (WebTestRunner::WebTestProxyBase::shouldChangeSelectedRange):
2914         (WebTestRunner::WebTestProxyBase::shouldDeleteRange):
2915         (WebTestRunner::WebTestProxyBase::shouldApplyStyle):
2916         (WebTestRunner::WebTestProxyBase::didBeginEditing):
2917         (WebTestRunner::WebTestProxyBase::didChangeSelection):
2918         (WebTestRunner::WebTestProxyBase::didChangeContents):
2919         (WebTestRunner::WebTestProxyBase::didEndEditing):
2920         * DumpRenderTree/chromium/TestShell.cpp:
2921         (TestShell::initialize):
2922         (TestShell::createNewWindow):
2923         * DumpRenderTree/chromium/WebViewHost.cpp:
2924         (WebViewHost::shouldBeginEditing):
2925         (WebViewHost::shouldEndEditing):
2926         (WebViewHost::shouldInsertNode):
2927         (WebViewHost::shouldInsertText):
2928         (WebViewHost::shouldChangeSelectedRange):
2929         (WebViewHost::shouldDeleteRange):
2930         (WebViewHost::shouldApplyStyle):
2931         * DumpRenderTree/chromium/WebViewHost.h:
2932         (WebViewHost):
2933
2934 2012-12-17  Jochen Eisinger  <jochen@chromium.org>
2935
2936         [chromium] Fix methods in TestRunner that directly modify the settings instead of going through WebPreferences
2937         https://bugs.webkit.org/show_bug.cgi?id=105154
2938
2939         Reviewed by Tony Chang.
2940
2941         If the settings are modified directly, the embedder can't keep track of
2942         them and might accidentially override the changed settings.
2943
2944         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
2945         (WebPreferences):
2946         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2947         (WebTestRunner::TestRunner::TestRunner):
2948         (WebTestRunner::TestRunner::setAsynchronousSpellCheckingEnabled):
2949         (WebTestRunner):
2950         (WebTestRunner::TestRunner::setMinimumTimerInterval):
2951         (WebTestRunner::TestRunner::setTouchDragDropEnabled):
2952         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2953         (TestRunner):
2954         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2955         (WebTestRunner::WebPreferences::reset):
2956         (WebTestRunner::WebPreferences::applyTo):
2957
2958 2012-12-17  Julien Chaffraix  <jchaffraix@webkit.org>
2959
2960         Unreviewed unit test skipping.
2961
2962         Filed https://bugs.webkit.org/show_bug.cgi?id=105253 to re-enable them.
2963
2964         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2965         (TestWebKitAPI):
2966         (TestWebKitAPI::TEST):
2967
2968 2012-12-17  Dean Jackson  <dino@apple.com>
2969
2970         Unreviewed. Add Silvia Pfeiffer to contributor list.
2971
2972         * Scripts/webkitpy/common/config/committers.py:
2973
2974 2012-12-17  Dirk Pranke  <dpranke@chromium.org>
2975
2976         build.webkit.org - add more google windows bots
2977         https://bugs.webkit.org/show_bug.cgi?id=105225
2978
2979         Reviewed by Eric Seidel.
2980
2981         Adds two more windows bots (google-windows-3, a builder, and
2982         google-windows-4, a tester) for the Chromium configs.
2983
2984         * BuildSlaveSupport/build.webkit.org-config/config.json:
2985
2986 2012-12-17  Eric Seidel  <eric@webkit.org>
2987
2988         Cleanup --profiler=perf code a little and allow up to 1000 report files (instead of 100)
2989         https://bugs.webkit.org/show_bug.cgi?id=105217
2990
2991         Reviewed by Dirk Pranke.
2992
2993         Previously --profile would fail strangely if find_unused_filename returned None
2994         (which would happen as soon as we had 100 report files).
2995         Now we'll search through 1000 filenames before giving up (and assert if we failed to find one).
2996         I also made some minor cleanups to the output of perf, and tried to make the
2997         commands more self-documenting by using long-names for args.
2998
2999         * Scripts/webkitpy/common/system/profiler.py:
3000         (SingleFileOutputProfiler.__init__):
3001         (Perf.attach_to_pid):
3002         (Perf.profile_after_exit):
3003
3004 2012-12-17  Sheriff Bot  <webkit.review.bot@gmail.com>
3005
3006         Unreviewed, rolling out r137198.
3007         http://trac.webkit.org/changeset/137198
3008         https://bugs.webkit.org/show_bug.cgi?id=105212
3009
3010         This patch is causing API behavior compatibility problems
3011         (Requested by zdobersek on #webkit).
3012
3013         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3014         (willSendRequestCallback):
3015
3016 2012-12-17  Elliott Sprehn  <esprehn@chromium.org>
3017
3018         Unreviewed. Adding myself to committers list.
3019
3020         * Scripts/webkitpy/common/config/committers.py:
3021
3022 2012-12-17  Dirk Pranke  <dpranke@chromium.org>
3023
3024         nrwt: shuffle code around for cleanup in run_webkit_tests.py
3025         https://bugs.webkit.org/show_bug.cgi?id=105078
3026
3027         Reviewed by Ojan Vafai.
3028
3029         This patch reorders functions so that run_webkit_tests can be
3030         understood in a top-down matter better, and to make things slightly
3031         more sensible when I merge manager.py into it.
3032
3033         Also, this adds tests for the actual main() routine, which had several
3034         bugs get through testing a week or two ago.
3035
3036         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3037         (main):
3038         (parse_args):
3039         (_set_up_derived_options):
3040         (run):
3041         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3042         (RunTest):
3043         (RunTest.test_no_http_tests):
3044         (PortTest.disabled_test_mac_lion):
3045         (MainTest):
3046         (MainTest.test_exception_handling):
3047         (MainTest.test_exception_handling.interrupting_run):
3048         (MainTest.test_exception_handling.successful_run):
3049         (MainTest.test_exception_handling.successful_run.FakeRunDetails):
3050         (MainTest.test_exception_handling.exception_raising_run):
3051
3052 2012-12-17  Dirk Pranke  <dpranke@chromium.org>
3053
3054         webkitpy: move --lint-test-files code into its own module
3055         https://bugs.webkit.org/show_bug.cgi?id=105077
3056
3057         Reviewed by Eric Seidel.
3058
3059         It really didn't need to be in run_webkit_tests.py anymore.
3060         This patch adds a new lint-test-expectations scripts to Tools/Scripts;
3061         rwt --lint-test-files is still supported for backwards compatibility
3062         for now.
3063
3064         * Scripts/lint-test-expectations: Added.
3065         * Scripts/webkitpy/layout_tests/lint_test_expectations.py: Added.
3066         (lint):
3067         (main):
3068         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py: Added.
3069         (FakePort):
3070         (FakePort.__init__):
3071         (FakePort.test_configuration):
3072         (FakePort.expectations_dict):
3073         (FakePort.skipped_layout_tests):
3074         (FakePort.all_test_configurations):
3075         (FakePort.configuration_specifier_macros):
3076         (FakePort.get_option):
3077         (FakeFactory):
3078         (FakeFactory.__init__):
3079         (FakeFactory.get):
3080         (FakeFactory.all_port_names):
3081         (LintTest):
3082         (LintTest.test_all_configurations):
3083         (LintTest.test_lint_test_files):
3084         (LintTest.test_lint_test_files__errors):
3085         (MainTest):
3086         (MainTest.test_success):
3087         (MainTest.test_success.interrupting_lint):
3088         (MainTest.test_success.successful_lint):
3089         (MainTest.test_success.exception_raising_lint):
3090         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3091         (main):
3092         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3093         (StreamTestingMixin.assertNotEmpty):
3094
3095 2012-12-17  Adam Klein  <adamk@chromium.org>
3096
3097         build-webkit: rename --template-tag to --template-element to match ENABLE #define name
3098         https://bugs.webkit.org/show_bug.cgi?id=105072
3099
3100         Reviewed by Laszlo Gombos.
3101
3102         * Scripts/webkitperl/FeatureList.pm:
3103
3104 2012-12-17  Julien Chaffraix  <jchaffraix@webkit.org>
3105
3106         Add some unit testing for WTF::clampTo* functions
3107         https://bugs.webkit.org/show_bug.cgi?id=105060
3108
3109         Reviewed by Emil A Eklund.
3110
3111         The new tests are targeted at clamping to int / unsigned and float as those are
3112         the one explicitely exposed through more dedicated functions (like clampToInteger,
3113         clampToPositiveInteger and clampToFloat).
3114
3115         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
3116
3117 2012-12-17  Eric Seidel  <eric@webkit.org>
3118
3119         rpt --profile --chromium-android throws exception
3120         https://bugs.webkit.org/show_bug.cgi?id=105061
3121
3122         Reviewed by Daniel Bates.
3123
3124         Somehow popen(args) got turned into popen(*args) at some point,
3125         which caused my new stringify code to fail when args was passed by name.
3126         Fixed and tested.
3127
3128         * Scripts/webkitpy/common/system/executive.py:
3129         (Executive._stringify_args):
3130         (Executive):
3131         (Executive.popen):
3132         * Scripts/webkitpy/common/system/executive_unittest.py:
3133         (ExecutiveTest.test_popen_args):
3134
3135 2012-12-17  Mark Pilgrim  <pilgrim@chromium.org>
3136
3137         Use Platform::current() instead of webKitPlatformSupport() in DumpRenderTree
3138         https://bugs.webkit.org/show_bug.cgi?id=105054
3139
3140         Reviewed by Jochen Eisinger.
3141
3142         Part of a refactoring series; see tracking bug 82948.
3143
3144         * DumpRenderTree/chromium/NotificationPresenter.cpp:
3145         (NotificationPresenter::show):
3146         * DumpRenderTree/chromium/Task.cpp:
3147         (postTask):
3148         * DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp:
3149
3150 2012-12-17  Emil A Eklund  <eae@chromium.org>
3151
3152         Clamp values in LayoutUnit::operator/ when SATURATED_LAYOUT_ARITHMETIC is enabled
3153         https://bugs.webkit.org/show_bug.cgi?id=104955
3154
3155         Reviewed by Julien Chaffraix.
3156
3157         Add tests for LayoutUnit.
3158
3159         * TestWebKitAPI/CMakeLists.txt:
3160         * TestWebKitAPI/ForwardingHeaders: Added.
3161         * TestWebKitAPI/ForwardingHeaders/WebCore: Added.
3162         * TestWebKitAPI/ForwardingHeaders/WebCore/LayoutUnit.h: Added.
3163         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
3164         * TestWebKitAPI/TestWebKitAPI.gypi:
3165         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3166         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp: Added.
3167         (TestWebKitAPI):
3168         (TestWebKitAPI::TEST):
3169         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3170
3171 2012-12-17  Jochen Eisinger  <jochen@chromium.org>
3172
3173         [chromium] removed unused preferences from testRunner.overridePreference
3174         https://bugs.webkit.org/show_bug.cgi?id=105169
3175
3176         Reviewed by Tony Chang.
3177
3178         Most notably this removes the code related to font family maps which is
3179         now handled via window.internals.settings
3180
3181         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
3182         (WebPreferences):
3183         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3184         (WebTestRunner::TestRunner::overridePreference):
3185         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3186         (TestRunner):
3187         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
3188         (WebTestRunner::WebPreferences::applyTo):
3189
3190 2012-12-17  James Robinson  <jamesr@chromium.org>
3191
3192         [chromium] Move creation of WebLayerTreeView to WebWidgetClient
3193         https://bugs.webkit.org/show_bug.cgi?id=105071
3194
3195         Reviewed by Adrienne Walker.
3196
3197         Update WebViewHost for the new WebWidgetClient interface.
3198
3199         * DumpRenderTree/chromium/WebViewHost.cpp:
3200         (WebViewHost::initializeLayerTreeView):
3201         (WebViewHost::layerTreeView):
3202         (WebViewHost::~WebViewHost):
3203         * DumpRenderTree/chromium/WebViewHost.h:
3204         (WebViewHost):
3205
3206 2012-12-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3207
3208         [EFL][WK2] window_create doesn't receive the url
3209         https://bugs.webkit.org/show_bug.cgi?id=105184
3210
3211         Reviewed by Alexis Menard.
3212
3213         * MiniBrowser/efl/main.c: Use the url supplied to window_create
3214         (on_window_create):
3215
3216 2012-12-17  Ilya Tikhonovsky  <loislo@chromium.org>
3217
3218         Web Inspector: Native Memory Instrumentation: MemoryInstrumentation doesn't detect reportMemoryUsage method defined in a base class.
3219         https://bugs.webkit.org/show_bug.cgi?id=105026
3220
3221         Reviewed by Yury Semikhatsky.
3222
3223         Old SFINAE test was replaced with new one based on this article:
3224         http://stackoverflow.com/questions/1966362/sfinae-to-check-for-inherited-member-functions
3225
3226         New test which covers this problem was added.
3227
3228         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
3229
3230 2012-12-17  Anthony Scian  <ascian@rim.com>
3231
3232         [Blackberry] Static code analysis warning fixes
3233         https://bugs.webkit.org/show_bug.cgi?id=105129
3234
3235         Reviewed by Rob Buis.
3236
3237         Added null checks for fopen calls, no recovery attempted; access fault prevention only.
3238
3239         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
3240         (BlackBerry::WebKit::createFile):
3241         (BlackBerry::WebKit::DumpRenderTree::runTest):
3242
3243 2012-12-17  John Mellor  <johnme@chromium.org>
3244
3245         Add Anton Vayvod and Tim Volodine as contributors in committers.py
3246         https://bugs.webkit.org/show_bug.cgi?id=105025
3247
3248         Unreviewed. Adds two contributors to committers.py.
3249         They are initially contributing to the Text Autosizing feature (master bug: 84186).
3250
3251         * Scripts/webkitpy/common/config/committers.py:
3252
3253 2012-12-17  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3254
3255         Unreviewed, add myself to committers.py.
3256
3257         * Scripts/webkitpy/common/config/committers.py:
3258
3259 2012-12-17  Oswald Buddenhagen  <oswald.buddenhagen@digia.com>
3260
3261         [Qt] remove some unnecessary CONFIG additions
3262
3263         Reviewed by Simon Hausmann.
3264
3265         qt is already added by spec_pre.prf, warn_on and depend_includepath by
3266         default_pre.prf.
3267
3268         * qmake/mkspecs/features/default_post.prf:
3269
3270 2012-12-17  Ilya Tikhonovsky  <loislo@chromium.org>
3271
3272         Unreviewed, rolling out r137892.
3273         http://trac.webkit.org/changeset/137892
3274         https://bugs.webkit.org/show_bug.cgi?id=105026
3275
3276         it broke compilation on windows
3277
3278         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
3279
3280 2012-12-14  Ilya Tikhonovsky  <loislo@chromium.org>
3281
3282         Web Inspector: Native Memory Instrumentation: MemoryInstrumentation doesn't detect reportMemoryUsage method defined in a base class.
3283         https://bugs.webkit.org/show_bug.cgi?id=105026
3284
3285         Reviewed by Yury Semikhatsky.
3286
3287         Old SFINAE test was replaced with new one based on this article:
3288         http://stackoverflow.com/questions/1966362/sfinae-to-check-for-inherited-member-functions
3289
3290         New test which covers this problem was added.
3291
3292         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
3293
3294 2012-12-17  Oswald Buddenhagen  <oswald.buddenhagen@digia.com>
3295
3296         [Qt] rely on automatic output directory setup
3297
3298         Reviewed by Simon Hausmann.
3299
3300         Now being a proper qt module (by virtue of having load(qt_build_config)
3301         in .qmake.conf), webkit gets the path setup goodies for free.
3302
3303         This also fixes Makefile.api.Debug/Release trying to generate qrc_WebKit.cpp
3304         at the same time, instead of the debug and release version ending up in different
3305         directories as they should.
3306
3307         * qmake/mkspecs/features/default_pre.prf:
3308
3309 2012-12-17  Charles Wei  <charles.wei@torchmobile.com.cn>
3310
3311         [BlackBerry] Need to re-enable video track
3312         https://bugs.webkit.org/show_bug.cgi?id=105155
3313
3314         Reviewed by George Staikos.
3315
3316         Just enable Video Track for BlackBerry.
3317
3318         * Scripts/webkitperl/FeatureList.pm:
3319
3320 2012-12-17  János Badics  <jbadics@inf.u-szeged.hu>
3321
3322         Unreviewed. Added myself to committers.py
3323
3324         * Scripts/webkitpy/common/config/committers.py:
3325
3326 2012-12-17  Jonathan Liu  <net147@gmail.com>
3327
3328         Fix linking of libraries with -Wl,-whole-archive
3329         https://bugs.webkit.org/show_bug.cgi?id=104436
3330
3331         Reviewed by Simon Hausmann.
3332
3333         If there is more than one library in LIBS linked with
3334         -Wl,-whole-archive -l... -Wl,-no-whole-archive, qmake tries to
3335         merge the duplicate flags in LIBS which causes linking to fail.
3336
3337         Add no_smart_library_merge to CONFIG to prevent the duplicate
3338         flags from being removed when using -Wl,-whole-archive.
3339
3340         * qmake/mkspecs/features/functions.prf:
3341
3342 2012-12-16  Arvid Nilsson  <anilsson@rim.com>
3343
3344         [BlackBerry] Adapt to new BlackBerry::Platform::TouchPoint API
3345         https://bugs.webkit.org/show_bug.cgi?id=105143
3346         RIM PR 171941
3347
3348         Reviewed by Rob Buis.
3349         Internally reviewed by George Staikos.
3350
3351         Adapt to new method names and encapsulation of TouchPoint data members.
3352
3353         * DumpRenderTree/blackberry/EventSender.cpp:
3354         (addTouchPointCallback):
3355         (updateTouchPointCallback):
3356         (touchEndCallback):
3357         (releaseTouchPointCallback):
3358         (sendTouchEvent):
3359
3360 2012-12-16  Maciej Stachowiak  <mjs@apple.com>
3361
3362         Add a script to compute the mean and 95% confidence interval (using two-sided t-test) of a sample set
3363         https://bugs.webkit.org/show_bug.cgi?id=105148
3364
3365         Reviewed by Filip Pizlo.
3366
3367         Usage examples:
3368         
3369         $ sampstat --help
3370         Usage: sampstat [options] [FILES]
3371           Compute the mean and 95% confidence interval of a sample set.
3372           Standard input or files must contain two or more decimal numbers, one per line.
3373         
3374         Options:
3375           -h, --help            show this help message and exit
3376           -u UNIT, --unit=UNIT  assume values are in units of UNIT
3377           -v, --verbose         print all values (with units)
3378         
3379         $ sampstat -u MB memresults.txt
3380         2356.90 MB +/- 101.34 MB (4.3%)
3381         
3382         $ sampstat -v -u MB memresults.txt
3383               2318.21 MB
3384               2399.56 MB
3385               2352.93 MB
3386         ----------------
3387         Mean: 2356.90 MB +/- 101.34 MB (4.3%)
3388         
3389
3390         * Scripts/sampstat: Added.
3391         (sum): Helper function to compute the sum of a list.
3392         (arithmeticMean): Compute the meam of a list.
3393         (standardDeviation): Compute the sample standard deviation (unbiased estimator).
3394         (standardError): Compute the sample standard error.
3395         (tDist): Compute t(.025, n-1), the t-value for atwo-sided 95% confidence interval. 
3396         (twoSidedConfidenceInterval): Compute the two-sided confidence interval range about the mean.
3397
3398 2012-12-15  Nima Ghanavatian  <nghanavatian@rim.com>
3399
3400         [BlackBerry] Pass key modifiers with touch and mouse events
3401         https://bugs.webkit.org/show_bug.cgi?id=105108
3402
3403         Reviewed by Rob Buis.
3404
3405         Update DRT to new api.
3406
3407         Internally reviewed by Gen Mak.
3408
3409         * DumpRenderTree/blackberry/EventSender.cpp:
3410         (mouseDownCallback):
3411         (mouseUpCallback):
3412         (mouseMoveToCallback):
3413
3414 2012-12-15  Zan Dobersek  <zandobersek@gmail.com>
3415
3416         Stop the XvfbDriver before proceeding with its starting setup
3417         https://bugs.webkit.org/show_bug.cgi?id=105006
3418
3419         Reviewed by Philippe Normand.
3420
3421         Just as with the base Driver implementation, stop the XvfbDriver
3422         before proceeding with setting up lock files and a new Xvfb instance.
3423         This forces any driver or Xvfb instances that are currently under
3424         the driver's control to be closed/killed and cleaned up after.
3425
3426         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
3427         (XvfbDriver._start):
3428
3429 2012-12-14  Dirk Pranke  <dpranke@chromium.org>
3430
3431         webkitpy: make port_name a required parameter to the non-test ports
3432         https://bugs.webkit.org/show_bug.cgi?id=105057
3433
3434         Reviewed by Eric Seidel.
3435
3436         This is just minor code cleanup along the path to making Port
3437         constructors simpler and pushing more logic into the port factory.
3438
3439         * Scripts/webkitpy/layout_tests/port/base.py:
3440         (Port.__init__):
3441         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3442         (PortTest.make_port):
3443         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3444         (TestWebKitPort.__init__):
3445         * Scripts/webkitpy/layout_tests/port/test.py:
3446         (TestPort):
3447         (TestPort.determine_full_port_name):
3448         (TestPort.__init__):
3449         * Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py:
3450         (XvfbDriverTest.make_driver):
3451         (XvfbDriverTest.test_stop):
3452
3453 2012-12-14  Dirk Pranke  <dpranke@chromium.org>
3454
3455         garden-o-matic doesn't know about reftests
3456         https://bugs.webkit.org/show_bug.cgi?id=101976
3457
3458         Reviewed by Eric Seidel.
3459
3460         Attempt to make garden-o-matic properly aware of reftests again.
3461
3462         This is re-landing r137407 with a change to
3463         rebaselineWithStatusUpdates() to actually pass the filtered
3464         failureInofLost to checkout.rebaseline().
3465
3466         Unfortunately, the testing coverage for this whole module is almost
3467         non-existent, and it's not obvious that there's a good way to
3468         stub out checkout.rebaseline() to test that the right thing
3469         happens. I verified the change manually.
3470
3471         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3472         (.):
3473         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
3474         (.):
3475         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
3476
3477 2012-12-14  Ryosuke Niwa  <rniwa@webkit.org>
3478
3479         "Running 1 DumpRenderTree over X shards" is not a helpful output
3480         https://bugs.webkit.org/show_bug.cgi?id=104858
3481
3482         Reviewed by Dirk Pranke.
3483
3484         The word "shard" is not typically used in test frameworks. This word is confusing for many WebKit
3485         contributors who typically don't have much experience on distributed computations and databases.
3486         So only print this message out in the debug mode.
3487
3488         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3489         * Scripts/webkitpy/layout_tests/views/printing.py:
3490         (Printer.print_workers_and_shards):
3491
3492 2012-12-13  Eric Seidel  <eric@webkit.org>
3493
3494         Add --profiler=PROFILER option to run-perf-tests to allow specifying which profiler to use on platforms with many
3495         https://bugs.webkit.org/show_bug.cgi?id=104891
3496
3497         Reviewed by Ryosuke Niwa.
3498
3499         I also implemented a very simple "Sample" Profiler using
3500         Mac OS X's /usr/bin/sample command line tool.
3501
3502         The real reason for this abstraction is to make it easy
3503         to support both perf and pprof on linux which seem to
3504         be about equally popular among those I ask in the Chrome team.
3505
3506         * Scripts/webkitpy/common/system/profiler.py:
3507         (ProfilerFactory.create_profiler):
3508         (ProfilerFactory):
3509         (ProfilerFactory.available_profilers_by_name):
3510         (ProfilerFactory.default_profiler_name):
3511         (Sample):
3512         (Sample.__init__):
3513         (Sample.attach_to_pid):
3514         (Sample.profile_after_exit):
3515         (IProfiler.attach_to_pid):
3516         * Scripts/webkitpy/layout_tests/port/driver.py:
3517         (Driver.__init__):
3518         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3519         (PerfTestsRunner._parse_args):
3520
3521 2012-12-13  Eric Seidel  <eric@webkit.org>
3522
3523         Unreviewed, fixing typo in python unittest.
3524
3525         I changed the default profiler on linux from pprof to perf in
3526         bug 104971.  I failed to update the unittest results at that time.
3527
3528         * Scripts/webkitpy/common/system/profiler_unittest.py:
3529         (ProfilerFactoryTest.test_basic):
3530
3531 2012-12-13  Ian Vollick  <vollick@chromium.org>
3532
3533         [chromium] Add a virtual test suite for enabling opt-in to composited scrolling
3534         https://bugs.webkit.org/show_bug.cgi?id=104911
3535
3536         Reviewed by Dirk Pranke.
3537
3538         Adds two virtual tests suites to run the tests in
3539         compositing/overflow/ and scrollbars/ with the flag
3540         --enable-accelerated-overflow-scroll, which I've also plumbed through
3541         in the usual way.
3542
3543         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3544         (main):
3545         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
3546         (WebPreferences):
3547         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
3548         (WebTestRunner::WebPreferences::reset):
3549         (WebTestRunner::WebPreferences::applyTo):
3550         * DumpRenderTree/chromium/TestShell.cpp:
3551         (TestShell::TestShell):
3552         (TestShell::resetWebSettings):
3553         * DumpRenderTree/chromium/TestShell.h:
3554         (TestShell::setAcceleratedCompositingForOverflowScrollEnabled):
3555         (TestShell):
3556         * Scripts/webkitpy/layout_tests/port/chromium.py:
3557         (ChromiumPort.virtual_test_suites):
3558
3559 2012-12-13  Eric Seidel  <eric@webkit.org>
3560
3561         Use 'perf' to profile on linux instead of google-pprof by default
3562         https://bugs.webkit.org/show_bug.cgi?id=104971
3563
3564         Reviewed by Dirk Pranke.
3565
3566         This makes Chromium Linux match Chromium Android and use the perf
3567         tool by default.  Once https://bugs.webkit.org/show_bug.cgi?id=104891
3568         lands it will be possible to use pprof again on Linux.
3569
3570         This is slightly more advanced than the AndroidPerf profiler as
3571         instead of using a timeout on "perf record" I instead watch
3572         for the termination of the target process and then control-C
3573         the 'perf record' process.  This required me to add two new
3574         methods to Executive, one to have a limited-time wait() and
3575         the second to be able to send a control-C.  I chose to add
3576         these to Executive to make them easier to mock/fix-for-win32
3577         at a later time if needed.
3578
3579         * Scripts/webkitpy/common/system/executive.py:
3580         (Executive.wait_limited):
3581         (Executive.interrupt):
3582         * Scripts/webkitpy/common/system/profiler.py:
3583         (ProfilerFactory.create_profiler):
3584         (Perf):
3585         (Perf.__init__):
3586         (Perf._perf_path):
3587         (Perf.attach_to_pid):
3588         (Perf._first_ten_lines_of_profile):
3589         (Perf.profile_after_exit):
3590
3591 2012-12-13  Julie Parent  <jparent@chromium.org>
3592
3593         Dashboard cleanup: remove usage of global g_builders.
3594         https://bugs.webkit.org/show_bug.cgi?id=104941
3595
3596         Reviewed by Dirk Pranke.
3597
3598         The dashboards use a lot of global state, which makes hacking on them
3599         complicated. This change removes the use of one such global: g_builders.
3600         In most cases, we can just use currentBuilderGroup().builders instead,
3601         which is now currentBuilders().
3602         Surprisingly, the most changes were required to the unit tests, since
3603         they were even bigger offenders of bad hygiene, relying on global state
3604         set by other tests, randomly clobbering global variables in ways the
3605         real code doesn't, etc.
3606
3607         * TestResultServer/static-dashboards/builders.js:
3608         (BuilderGroup.prototype.setup):
3609         * TestResultServer/static-dashboards/dashboard_base.js:
3610         (.switch.return):
3611         (htmlForTestTypeSwitcher):
3612         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3613         (generatePage):
3614         (getAllTestsTrie):
3615         (processTestRunsForAllBuilders):
3616         (showPopupForBuild):
3617         (generatePageForExpectationsUpdate):
3618         (loadExpectationsLayoutTests):
3619         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3620         (resetGlobals):
3621         (stubResultsByBuilder):
3622         (test):
3623         * TestResultServer/static-dashboards/loader.js:
3624         (.):
3625         * TestResultServer/static-dashboards/loader_unittests.js:
3626
3627 2012-12-13  Eric Seidel  <eric@webkit.org>