Need a mechanism to override navigator.userAgent
[WebKit-https.git] / Tools / ChangeLog
1 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
2
3         Need a mechanism to override navigator.userAgent
4         https://bugs.webkit.org/show_bug.cgi?id=193762
5         <rdar://problem/47504939>
6
7         Reviewed by Brent Fulgham.
8
9         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
10
11         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
12         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
13         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
14
15 2019-01-25  Dean Jackson  <dino@apple.com>
16
17         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
18         https://bugs.webkit.org/show_bug.cgi?id=193831
19         <rdar://problem/47399263>
20
21         Reviewed by Chris Dumez.
22
23         Two new tests that exercise cross-origin and same-origin System
24         Previews.
25
26         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
27
28 2019-01-25  Keith Rollin  <krollin@apple.com>
29
30         Update Xcode projects with "Check .xcfilelists" build phase
31         https://bugs.webkit.org/show_bug.cgi?id=193790
32         <rdar://problem/47201374>
33
34         Reviewed by Alex Christensen.
35
36         Support for XCBuild includes specifying inputs and outputs to various
37         Run Script build phases. These inputs and outputs are specified as
38         .xcfilelist files. Once created, these .xcfilelist files need to be
39         kept up-to-date. In order to check that they are up-to-date or not,
40         add an Xcode build step that invokes an external script that performs
41         the checking. If the .xcfilelists are found to be out-of-date, update
42         them, halt the build, and instruct the developer to restart the build
43         with up-to-date files.
44
45         At this time, the checking and regenerating is performed only if the
46         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
47         who want to use this facility can set this variable and test out the
48         checking/regenerating. Once it seems like there are no egregious
49         issues that upset a developer's workflow, we'll unconditionally enable
50         this facility.
51
52         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
53         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
54         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
55         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
56
57 2019-01-25  Keith Rollin  <krollin@apple.com>
58
59         Update Xcode projects with "Apply Configuration to XCFileLists" build target
60         https://bugs.webkit.org/show_bug.cgi?id=193781
61         <rdar://problem/47201153>
62
63         Reviewed by Alex Christensen.
64
65         Part of generating the .xcfilelists used as part of adopting XCBuild
66         includes running `make DerivedSources.make` from a standalone script.
67         It’s important for this invocation to have the same environment as
68         when the actual build invokes `make DerivedSources.make`. If the
69         environments are different, then the two invocations will provide
70         different results. In order to get the same environment in the
71         standalone script, have the script launch xcodebuild targeting the
72         "Apply Configuration to XCFileLists" build target, which will then
73         re-invoke our standalone script. The script is now running again, this
74         time in an environment with all workspace, project, target, xcconfig
75         and other environment variables established.
76
77         The "Apply Configuration to XCFileLists" build target accomplishes
78         this task via a small embedded shell script that consists only of:
79
80             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
81
82         The process that invokes "Apply Configuration to XCFileLists" first
83         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
84         evaluated and exports it into the shell environment. When xcodebuild
85         is invoked, it inherits the value of this variable and can `eval` the
86         contents of that variable. Our external standalone script can then set
87         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
88         of command-line parameters needed to restart itself in the appropriate
89         state.
90
91         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
92         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
93
94 2019-01-25  Alex Christensen  <achristensen@webkit.org>
95
96         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
97         https://bugs.webkit.org/show_bug.cgi?id=193802
98         <rdar://problem/46010580>
99
100         Reviewed by Andy Estes.
101
102         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
103         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
104         (TEST):
105
106 2019-01-25  Daniel Bates  <dabates@apple.com>
107
108         [iOS] uiController.keyDown() does not translate Control modified key
109         https://bugs.webkit.org/show_bug.cgi?id=192898
110
111         Reviewed by Wenson Hsieh.
112
113         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
114         key translation, as applicable. Among other cases, key translation occurs when performing
115         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
116         also makes the behavior of uiController.keyDown() more closely match the behavior of a
117         human pressing down and releasing key(s) using a hardware keyboard.
118
119         * WebKitTestRunner/ios/HIDEventGenerator.h:
120         * WebKitTestRunner/ios/HIDEventGenerator.mm:
121         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
122
123         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
124         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
125         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
126         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
127         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
128         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
129         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
130         (-[HIDEventGenerator longPress:completionBlock:]):
131         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
132         Update code for above renaming.
133
134         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
135         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
136
137         (-[HIDEventGenerator keyDown:]): Added.
138         (-[HIDEventGenerator keyUp:]): Added.
139         (-[HIDEventGenerator keyPress:completionBlock:]):
140         (-[HIDEventGenerator eventDispatchThreadEntry:]):
141         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
142         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
143         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
144         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
145         (WTR::parseModifier): Deleted.
146
147 2019-01-25  Keith Rollin  <krollin@apple.com>
148
149         Complete the implementation of generate-xcfilelists
150         https://bugs.webkit.org/show_bug.cgi?id=193782
151
152         Reviewed by Alex Christensen.
153
154         A preliminary version of generate-xcfilelists was added in r238008.
155         This patch updates that script in order to:
156
157         - Support checking of .xcfilelists
158         - Perform better execution of `make DerivedSources.make` by
159           relaunching generate-xcfilelists under xcodebuild
160         - Support incremental generation and checking of .xcfilelists
161         - Support supplementary .xcfilelists files from WebKitAdditions
162         - Support being wrapped by parallel version of generate-xcfilelists in
163           Internal that adds support for (re)generating WebKit projects in
164           that repo.
165         - Support builds that have been performed in WebKitBuild as well as
166           ~/Library/Developer/code/DerivedData
167         - Increase robustness and debugging facilities.
168
169         * Scripts/generate-xcfilelists:
170
171 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
172
173         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
174         https://bugs.webkit.org/show_bug.cgi?id=193297
175         <rdar://problem/47158841>
176
177         Unreviewed test case fix.
178
179         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
180         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
181
182         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
183         (TEST):
184
185 2019-01-25  Keith Rollin  <krollin@apple.com>
186
187         Update existing .xcfilelists
188         https://bugs.webkit.org/show_bug.cgi?id=193791
189         <rdar://problem/47201706>
190
191         Reviewed by Alex Christensen.
192
193         Many .xcfilelist files were added in r238824 in order to support
194         XCBuild. Update these with recent changes to the set of build files
195         and with the current generate-xcfilelist script.
196
197         * DumpRenderTree/DerivedSources-input.xcfilelist:
198         * DumpRenderTree/DerivedSources-output.xcfilelist:
199         * WebKitTestRunner/DerivedSources-input.xcfilelist:
200         * WebKitTestRunner/DerivedSources-output.xcfilelist:
201
202 2019-01-25  Keith Rollin  <krollin@apple.com>
203
204         Fix missing dependencies in extract-dependencies-from-makefile
205         https://bugs.webkit.org/show_bug.cgi?id=193783
206         <rdar://problem/47201571>
207
208         Reviewed by Alex Christensen.
209
210         The extract-dependencies-from-makefile script generates .xcfilelists
211         for XCBuild by invoking a makefile in --debug mode, parsing the
212         dependency information in the output, and extracting information
213         regarding targets and dependents. However, the way `make` emits this
214         dependency information is not rigorous, and so we need to determine
215         what lines to look for and parse by trial and error. This approach
216         didn't coriginally atch all the information we needed to collect, so
217         update the script to look for the additional lines we now know to look
218         for.
219
220         * Scripts/extract-dependencies-from-makefile:
221         (Parser):
222         (Parser.addTarget):
223         (Parser.addPrereq):
224         (Parser.doParse):
225
226 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
227
228         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
229         https://bugs.webkit.org/show_bug.cgi?id=193297
230         <rdar://problem/47158841>
231
232         Reviewed by Alex Christensen.
233
234         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
235             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
236         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
237         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
238         activating the message used to trigger the callback when it is set.
239
240 2019-01-25  Alex Christensen  <achristensen@webkit.org>
241
242         WKWebView.goBack should reload if there is a safe browsing warning
243         https://bugs.webkit.org/show_bug.cgi?id=193805
244         <rdar://problem/46908216>
245
246         Reviewed by Geoff Garen.
247
248         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
249         (+[Simple3LookupContext sharedLookupContext]):
250         (-[Simple3LookupContext lookUpURL:completionHandler:]):
251         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
252         (TEST):
253
254 2019-01-25  Chris Dumez  <cdumez@apple.com>
255
256         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
257         https://bugs.webkit.org/show_bug.cgi?id=193788
258         <rdar://problem/47531231>
259
260         Reviewed by Alex Christensen.
261
262         Add API test coverage.
263
264         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
265         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
266
267 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
268
269         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
270         https://bugs.webkit.org/show_bug.cgi?id=193771
271
272         Unreviewed infrastructure fix.
273
274         * Scripts/webkitpy/port/darwin.py:
275         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
276
277 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
278
279         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
280
281 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
282
283         Add contributors.json entries for Ling Ho and for a new bot watchers group.
284
285         * Scripts/webkitpy/common/config/contributors.json:
286
287 2019-01-25  Chris Dumez  <cdumez@apple.com>
288
289         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
290         https://bugs.webkit.org/show_bug.cgi?id=193779
291         <rdar://problem/46170903>
292
293         Reviewed by Antti Koivisto.
294
295         Add API test that quickly navigates forward to a previous process without waiting for it to
296         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
297         the process' previous page when reconnecting the it for the forward navigation.
298
299         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
300
301 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
302
303         Need a way for JavaScript (or bundle) code to participate in undo
304         https://bugs.webkit.org/show_bug.cgi?id=190009
305         <rdar://problem/44807048>
306
307         Reviewed by Ryosuke Niwa.
308
309         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
310         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
311
312         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
313         (WTR::UIScriptController::lastUndoLabel const):
314         (WTR::UIScriptController::firstRedoLabel const):
315         (WTR::UIScriptController::platformUndoManager const):
316         * DumpRenderTree/mac/UIScriptControllerMac.mm:
317         (WTR::UIScriptController::lastUndoLabel const):
318         (WTR::UIScriptController::firstRedoLabel const):
319         (WTR::UIScriptController::platformUndoManager const):
320         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
321         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
322         (WTR::UIScriptController::lastUndoLabel const):
323         (WTR::UIScriptController::firstRedoLabel const):
324         * TestRunnerShared/UIScriptContext/UIScriptController.h:
325         * WebKitTestRunner/UIScriptControllerCocoa.mm:
326         (WTR::UIScriptController::lastUndoLabel const):
327         (WTR::UIScriptController::firstRedoLabel const):
328         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
329         (WTR::UIScriptController::platformUndoManager const):
330         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
331         (WTR::UIScriptController::platformUndoManager const):
332
333 2019-01-25  Zalan Bujtas  <zalan@apple.com>
334
335         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
336         https://bugs.webkit.org/show_bug.cgi?id=193824
337
338         Reviewed by Antti Koivisto.
339
340         * LayoutReloaded/misc/LFC-passing-tests.txt:
341
342 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
343
344         Update macOS JSC bot configurations
345         https://bugs.webkit.org/show_bug.cgi?id=193739
346
347         Reviewed by Alexey Proskuryakov.
348
349         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
350         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
351         (BubbleQueueServer): Move JSC EWS to Mojave section.
352         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
353         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
354         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
355
356 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
357
358         [Win][WebKitTestRunner] Implement EventSenderProxy
359         https://bugs.webkit.org/show_bug.cgi?id=193755
360
361         Reviewed by Don Olmstead.
362
363         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
364         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
365         (WTR::EventSenderProxy::dispatchMessage):
366         (WTR::EventSenderProxy::EventSenderProxy):
367         (WTR::EventSenderProxy::mouseDown):
368         (WTR::EventSenderProxy::mouseUp):
369         (WTR::EventSenderProxy::mouseMoveTo):
370         (WTR::EventSenderProxy::mouseScrollBy):
371         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
372
373 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
374
375         Unreviewed fix for API test failure after r240437.
376
377         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
378
379         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
380
381 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
382
383         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
384         https://bugs.webkit.org/show_bug.cgi?id=193787
385         <rdar://problem/47497634>
386
387         Reviewed by Alexey Proskuryakov.
388
389         * Scripts/webkitdirs.pm:
390         (iosSimulatorApplicationsPath): Pick from available runtime directories.
391
392 2019-01-24  Truitt Savell  <tsavell@apple.com>
393
394         Unreviewed, rolling out r240446.
395
396         Casued 5 API failures
397
398         Reverted changeset:
399
400         "Activate the WebResourceLoadStatisticsStore in the
401         NetworkProcess and deactivate it in the UIProcess."
402         https://bugs.webkit.org/show_bug.cgi?id=193297
403         https://trac.webkit.org/changeset/240446
404
405 2019-01-24  Zalan Bujtas  <zalan@apple.com>
406
407         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
408         https://bugs.webkit.org/show_bug.cgi?id=193741
409         <rdar://problem/47135030>
410
411         Reviewed by Antti Koivisto and Simon Fraser.
412
413         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
414         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
415         (TestWebKitAPI::TEST):
416
417 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
418
419         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
420         https://bugs.webkit.org/show_bug.cgi?id=193297
421         <rdar://problem/47158841>
422
423         Reviewed by Alex Christensen.
424
425         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
426         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
427         activating the message used to trigger the callback when it is set.
428
429 2019-01-24  John Wilander  <wilander@apple.com>
430
431         Add Ad Click Attribution as an internal/experimental feature
432         https://bugs.webkit.org/show_bug.cgi?id=193685
433         <rdar://problem/47450399>
434
435         Reviewed by Brent Fulgham.
436
437         Added test option adClickAttributionEnabled.
438
439         * DumpRenderTree/TestOptions.cpp:
440         (TestOptions::TestOptions):
441         * DumpRenderTree/TestOptions.h:
442         * DumpRenderTree/mac/DumpRenderTree.mm:
443         (setWebPreferencesForTestOptions):
444
445 2019-01-24  Antti Koivisto  <antti@apple.com>
446
447         [PSON] Flash on back navigation on Mac
448         https://bugs.webkit.org/show_bug.cgi?id=193716
449         <rdar://problem/47148458>
450
451         Reviewed by Chris Dumez.
452
453         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
454
455         Closing of the previous page is delayed so waiting for didFinishNavigation is
456         not sufficient to guarantee we have received all the messages. Wait for them.
457
458 2019-01-24  Chris Dumez  <cdumez@apple.com>
459
460         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
461         https://bugs.webkit.org/show_bug.cgi?id=193761
462         <rdar://problem/47456405>
463
464         Reviewed by Alex Christensen.
465
466         Add API test coverage.
467
468         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
469
470 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
471
472         webkitpy: Missing PID in crashlog name should not be fatal
473         https://bugs.webkit.org/show_bug.cgi?id=193771
474
475         If we can't determine the PID of a crashlog, just ignore the crashlog instead
476         of raising an exception.
477
478         Reviewed by Lucas Forschler.
479
480         * Scripts/webkitpy/port/darwin.py:
481         (DarwinPort._merge_crash_logs):
482
483 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
484
485         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
486         https://bugs.webkit.org/show_bug.cgi?id=193746
487
488         Reviewed by Youenn Fablet.
489
490         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
491         so we'd best just not call it.
492
493         * Scripts/webkitpy/w3c/test_exporter.py:
494         (WebPlatformTestExporter.create_branch_with_patch):
495
496 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
497
498         Move FileSystem to WTF
499         https://bugs.webkit.org/show_bug.cgi?id=193602
500
501         Reviewed by Yusuke Suzuki.
502
503         * DumpRenderTree/win/DumpRenderTree.cpp:
504         * TestWebKitAPI/CMakeLists.txt:
505         * TestWebKitAPI/PlatformGTK.cmake:
506         * TestWebKitAPI/PlatformJSCOnly.cmake:
507         * TestWebKitAPI/PlatformPlayStation.cmake:
508         * TestWebKitAPI/PlatformWPE.cmake:
509         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
510         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
511         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
512         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
513         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
514         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
515         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
516         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
517         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
518         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
519
520 2019-01-24  Philippe Normand  <pnormand@igalia.com>
521
522         [WPE] Remove hard dependency on subprocess32 for the API tests
523
524         Rubber-stamped by Carlos Garcia Campos.
525
526         * glib/api_test_runner.py:
527         (TestRunner._run_test_qt): Lazily import subprocess32 and check
528         its presence only when running WPEQt tests.
529
530 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
531
532         [GLIB] Expose JavaScriptCore options in GLib public API
533         https://bugs.webkit.org/show_bug.cgi?id=188742
534
535         Reviewed by Michael Catanzaro.
536
537         Add a test for the new API.
538
539         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
540         (testsJSCOptions):
541         (main):
542
543 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
544
545         [GTK][WPE] Support JPEG 2000 images
546         https://bugs.webkit.org/show_bug.cgi?id=186272
547
548         Reviewed by Žan Doberšek.
549
550         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
551
552         * gtk/jhbuild.modules:
553         * wpe/jhbuild.modules:
554
555 2019-01-23  David Kilzer  <ddkilzer@apple.com>
556
557         check-webkit-style should warn when using soft-linking macros in a header
558         <https://webkit.org/b/193750>
559
560         Reviewed by Darin Adler.
561
562         * Scripts/webkitpy/style/checkers/cpp.py:
563         (check_language): Add softlink/header check by refactoring the
564         softlink/framework check.
565         (CppChecker): Enable softlink/header check by default.
566         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
567         (CppStyleTest.test_softlink_framework): Rename from
568         CppStyleTest.test_softlink() and change test framework name in
569         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
570         files. Set file_name for macros that only appear in headers.
571         (CppStyleTest.test_softlink_header): Add tests for using
572         soft-link macros in headers.
573
574 2019-01-23  Chris Dumez  <cdumez@apple.com>
575
576         Deprecate API to limit the maximum number of WebProcesses
577         https://bugs.webkit.org/show_bug.cgi?id=193725
578         <rdar://problem/47464879>
579
580         Reviewed by Geoff Garen.
581
582         Update existing API tests to stop using deprecated API.
583
584         * MiniBrowser/mac/AppDelegate.m:
585         (defaultConfiguration):
586         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
587         (TestWebKitAPI::TEST):
588         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
589         (TestWebKitAPI::TEST):
590         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
591         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
592         (TEST):
593         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
594         (TEST):
595
596 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
597
598         [ews-app] Rename ews model buildermappings to buildermapping
599         https://bugs.webkit.org/show_bug.cgi?id=193729
600
601         Reviewed by Lucas Forschler.
602
603         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
604         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
605         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
606
607 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
608
609         [ews-app] Rename ews model steps to step
610         https://bugs.webkit.org/show_bug.cgi?id=193697
611
612         Reviewed by Lucas Forschler.
613
614         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
615         (Step): Renamed Steps to Step.
616
617 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
618
619         Clean up IndexedDB files between tests
620         https://bugs.webkit.org/show_bug.cgi?id=192796
621         <rdar://problem/46824999>
622
623         Reviewed by Geoffrey Garen.
624
625         * DumpRenderTree/mac/DumpRenderTree.mm:
626         (runTest):
627         * WebKitTestRunner/TestController.cpp:
628         (WTR::TestController::resetStateToConsistentValues):
629         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
630         (WTR::RemoveAllIndexedDatabasesCallback):
631         (WTR::TestController::ClearIndexedDatabases):
632         * WebKitTestRunner/TestController.h:
633         * WebKitTestRunner/TestInvocation.cpp:
634         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
635
636 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
637
638         [ews-app] Rename ews model Builds to Build
639         https://bugs.webkit.org/show_bug.cgi?id=193695
640
641         Reviewed by Lucas Forschler.
642
643         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
644         (Build): Renamed Builds to Build.
645
646 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
647
648         webkitpy: Wait longer when launching WebKitTestRunner
649         https://bugs.webkit.org/show_bug.cgi?id=193734
650
651         Reviewed by Aakash Jain.
652
653         * Scripts/webkitpy/port/simulator_process.py:
654         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
655
656 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
657
658         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
659         https://bugs.webkit.org/show_bug.cgi?id=193182
660         <rdar://problem/47452154>
661
662         Reviewed by Tim Horton.
663
664         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
665         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
666         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
667
668         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
669         preventing later tests from recognizing gestures.
670
671         * WebKitTestRunner/ios/TestControllerIOS.mm:
672         (WTR::TestController::platformResetStateToConsistentValues):
673
674         Cancel all touches in the UIApplication when resetting to a consistent state between tests.
675
676 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
677
678         webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
679         https://bugs.webkit.org/show_bug.cgi?id=193722
680         <rdar://problem/47481475>
681
682         Reviewed by Lucas Forschler.
683
684         iPhone and iPad ports should both use the iOS config.
685
686         * Scripts/webkitpy/port/ios_simulator.py:
687         (IPhoneSimulatorPort.__init__):
688         (IPadSimulatorPort.__init__):
689
690 2019-01-23  Rob Buis  <rbuis@igalia.com>
691
692         Update MIME type parser
693         https://bugs.webkit.org/show_bug.cgi?id=180526
694
695         Reviewed by Frédéric Wang.
696
697         Add unit tests for both parse modes of ParsedContentType.
698
699         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
700         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added.
701         (TestWebKitAPI::TEST):
702
703 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
704
705         [ews-app] fetch loop should not stop on network issues
706         https://bugs.webkit.org/show_bug.cgi?id=193666
707
708         Reviewed by Lucas Forschler.
709
710         * BuildSlaveSupport/ews-app/ews/fetcher.py:
711         (FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
712
713 2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
714
715         [iOS] Multiple WKWebViewAutofillTests are flaky failures
716         https://bugs.webkit.org/show_bug.cgi?id=189165
717         <rdar://problem/47433765>
718
719         Reviewed by Tim Horton.
720
721         These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to
722         immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular,
723         the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI
724         process in sufficient to ensure that any previous action that blurred the focused element in the web process
725         would make its way to the UI process by the time the layer tree commit is finished.
726
727         However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread.
728         This means that if a layer tree flush was already scheduled in the web process before the element was blurred,
729         the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test
730         will fail because it asks for -_autofillContext too early.
731
732         To fix this, we tweak these tests to actually wait until the intended input session change triggered by script
733         is handled in the UI process.
734
735         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
736
737         Tweak some of these tests to wait for input session changes before checking for the presence of an autofill
738         context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions
739         by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new
740         input session.
741
742         (-[AutofillTestView textInputHasAutofillContext]):
743
744         Remove the incorrect presentation update here. This helper now assumes that the UI process is up to date.
745
746         * TestWebKitAPI/cocoa/TestWKWebView.h:
747         * TestWebKitAPI/cocoa/TestWKWebView.mm:
748         (nextInputSessionChangeCount):
749
750         Monotonically increasing identifier that's incremented whenever an input session is started in the UI process.
751         This includes changing the focused element from one to another.
752
753         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
754         (-[TestWKWebView didStartFormControlInteraction]):
755         (-[TestWKWebView didEndFormControlInteraction]):
756         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
757
758         Add a helper to evaluate JavaScript and wait for this script to cause some change in the input session. This
759         handles three cases: (1) changing focus from an element that doesn't require an input session to one that does,
760         (2) changing focus between elements that require input sessions, and (3) changing focus from an input session
761         that doesn't require an input session to one that doesn't.
762
763 2019-01-22  David Kilzer  <ddkilzer@apple.com>
764
765         check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters
766         <https://webkit.org/b/193676>
767
768         Reviewed by Alexey Proskuryakov.
769
770         * Scripts/webkitpy/style/checkers/cpp.py:
771         (check_member_initialization_list):
772         - Don't report missing whitespace around colon if the colon at
773           the start of the line is formatted correctly.
774         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
775         (WebKitStyleTest.test_member_initialization_list):
776         - Add a test for a missing permutation of existing tests.
777         - Add a test this false-positive.
778         - Add blank lines between subtests to make them easier to read.
779
780 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
781
782         [build.webkit.org] Unit-test failure after r237113
783         https://bugs.webkit.org/show_bug.cgi?id=193669
784
785         Reviewed by Michael Catanzaro.
786
787         * BuildSlaveSupport/build.webkit.org-config/factories.py:
788         (Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has 
789         multiple or zero flags.
790
791 2019-01-22  Tadeu Zagallo  <tzagallo@apple.com>
792
793         Cache bytecode to disk
794         https://bugs.webkit.org/show_bug.cgi?id=192782
795         <rdar://problem/46084932>
796
797         Reviewed by Keith Miller.
798
799         Add test helper to execute bytecode-cache tests: it executes each test
800         twice, the first with JSC_diskCachePath set to a temporary directory
801         and second with JSC_forceDiskCache=true (in addition to the cache path)
802         to guarantee that only the disk cache is being used and no new
803         UnlinkedCodeBlocks are being created.
804
805         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh: Added.
806         * Scripts/run-jsc-stress-tests:
807
808 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
809
810         [css-logical] Implement flow-relative margin, padding and border shorthands
811         https://bugs.webkit.org/show_bug.cgi?id=188697
812
813         Reviewed by Simon Fraser and Antti Koivisto.
814
815         * DumpRenderTree/TestOptions.cpp:
816         (TestOptions::TestOptions):
817         * DumpRenderTree/TestOptions.h:
818         * DumpRenderTree/mac/DumpRenderTree.mm:
819         (setWebPreferencesForTestOptions):
820         Allow tests to enable the CSSLogicalEnabled flag in WK1.
821
822         * Scripts/webkitpy/style/checkers/jsonchecker.py:
823         (JSONCSSPropertiesChecker.check_codegen_properties):
824         Allow CSS property definitions to have a 'runtime-flag' parameter which
825         disables the property when the specified runtime flag is disabled.
826
827 2019-01-21  Fujii Hironori  <Hironori.Fujii@sony.com>
828
829         [GTK][WPE] libgcrypt-1.7.6 can't be compiled on Ubuntu 18.10
830         https://bugs.webkit.org/show_bug.cgi?id=193643
831
832         Reviewed by Michael Catanzaro.
833
834         * gtk/jhbuild.modules: Bumped to libgcrypt-1.8.4.
835         * wpe/jhbuild.modules: Ditto.
836
837 2019-01-21  Zalan Bujtas  <zalan@apple.com>
838
839         [LFC][Floats] Take float top position into account when computing containing block height.
840         https://bugs.webkit.org/show_bug.cgi?id=193655
841
842         Reviewed by Antti Koivisto.
843
844         * LayoutReloaded/misc/LFC-passing-tests.txt:
845
846 2019-01-21  David Kilzer  <ddkilzer@apple.com>
847
848         Switch remaining VideoToolbox soft-linking in WebCore over to VideoToolboxSoftLink.{cpp,h}
849         <https://webkit.org/b/193645>
850         <rdar://problem/47421574>
851
852         Reviewed by Alex Christensen.
853
854         - Now checks for local soft-linking of all frameworks that have
855           their own *SoftLinking.{cpp,h,mm} files.
856         - Changes softlink/uikit warning to softlink/framework.
857
858         * Scripts/webkitpy/style/checkers/cpp.py:
859         (check_language):
860         (CppChecker):
861         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
862         (CppStyleTest):
863
864 2019-01-20  Saam Barati  <sbarati@apple.com>
865
866         Rollout r240210: It broke tests on iOS
867         https://bugs.webkit.org/show_bug.cgi?id=193640
868
869         Unreviewed.
870
871         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper:
872         * Scripts/run-jsc-stress-tests:
873
874 2019-01-20  chris fleizach  <cfleizach@apple.com>
875
876         AX: Support returning relative frames for accessibility
877         https://bugs.webkit.org/show_bug.cgi?id=193414
878         <rdar://problem/47268501>
879
880         Reviewed by Zalan Bujtas.
881
882         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
883         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
884         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
885         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
886         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
887         (WTR::attributesOfElement):
888         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
889
890 2019-01-20  Yusuke Suzuki  <ysuzuki@apple.com>
891
892         Unreviewed, add my new email address
893
894         * Scripts/webkitpy/common/config/contributors.json:
895
896 2019-01-19  Zalan Bujtas  <zalan@apple.com>
897
898         [LFC][BFC] <body>'s overflow property value is propagated to viewport
899         https://bugs.webkit.org/show_bug.cgi?id=193617
900
901         Reviewed by Antti Koivisto.
902
903         * LayoutReloaded/misc/LFC-passing-tests.txt:
904
905 2019-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
906
907         Unreviewed, rolling out r240209.
908
909         Broke GTK/WPE injected bundle
910
911         Reverted changeset:
912
913         "AX: Support returning relative frames for accessibility"
914         https://bugs.webkit.org/show_bug.cgi?id=193414
915         https://trac.webkit.org/changeset/240209
916
917 2019-01-12  Dan Bernstein  <mitz@apple.com>
918
919         [Cocoa] Avoid importing directly from subumbrella frameworks
920         https://bugs.webkit.org/show_bug.cgi?id=186016
921         <rdar://problem/40591038>
922
923         Reviewed by Sam Weinig.
924
925         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
926           LaunchServices header.
927         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
928           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
929         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
930           when using SDKs earlier than 10.13.
931         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
932           and OTHER_CPLUSPLUSFLAGS.
933         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
934           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
935         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
936           LaunchServices header.
937
938 2019-01-20  Tadeu Zagallo  <tzagallo@apple.com>
939
940         Cache bytecode to disk
941         https://bugs.webkit.org/show_bug.cgi?id=192782
942         <rdar://problem/46084932>
943
944         Reviewed by Keith Miller.
945
946         Add test helper to execute bytecode-cache tests: it executes each test
947         twice, the first with JSC_diskCachePath set to a temporary directory
948         and second with JSC_forceDiskCache=true (in addition to the cache path)
949         to guarantee that only the disk cache is being used and no new
950         UnlinkedCodeBlocks are being created.
951
952         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper: Added.
953         * Scripts/run-jsc-stress-tests:
954
955 2019-01-20  chris fleizach  <cfleizach@apple.com>
956
957         AX: Support returning relative frames for accessibility
958         https://bugs.webkit.org/show_bug.cgi?id=193414
959         <rdar://problem/47268501>
960
961         Reviewed by Zalan Bujtas.
962
963         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
964         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
965         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
966         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
967         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
968         (WTR::attributesOfElement):
969         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
970
971 2019-01-20  Antoine Quint  <graouts@apple.com>
972
973         Add a POINTER_EVENTS feature flag
974         https://bugs.webkit.org/show_bug.cgi?id=193577
975         <rdar://problem/47408511>
976
977         Unreviewed. Also enable Pointer Events for iosmac.
978
979         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
980
981 2019-01-19  Zalan Bujtas  <zalan@apple.com>
982
983         [LFC][Floats] Ensure that floats in FloatingContext::m_floats are always horizontally ordered.
984         https://bugs.webkit.org/show_bug.cgi?id=193613
985
986         Reviewed by Antti Koivisto.
987
988         * LayoutReloaded/misc/LFC-passing-tests.txt:
989
990 2019-01-19  Antoine Quint  <graouts@apple.com>
991
992         Add a POINTER_EVENTS feature flag
993         https://bugs.webkit.org/show_bug.cgi?id=193577
994
995         Reviewed by Dean Jackson.
996
997         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
998
999 2019-01-18  Zhifei FANG  <zhifei_fang@apple.com>
1000
1001         Disable the run-jsc-stress-test remote host key check [second round].
1002         https://bugs.webkit.org/show_bug.cgi?id=192988
1003
1004         Reviewed by Dewei Zhu.
1005
1006         * Scripts/run-jsc-stress-tests:
1007
1008 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
1009
1010         [build.webkit.org] unit-test failure Builder GTK Linux 32-bit Release doesn't exist
1011         https://bugs.webkit.org/show_bug.cgi?id=193597
1012
1013         Reviewed by Lucas Forschler.
1014
1015         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1016
1017 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
1018
1019         [build.webkit.org] api tests failures are incorrectly named as unit test failures
1020         https://bugs.webkit.org/show_bug.cgi?id=193595
1021
1022         Reviewed by Lucas Forschler.
1023
1024         * BuildSlaveSupport/build.webkit.org-config/factories.py: Renamed RunUnitTests to RunAPITests.
1025         * BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
1026         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
1027
1028 2019-01-18  Chris Dumez  <cdumez@apple.com>
1029
1030         Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
1031         https://bugs.webkit.org/show_bug.cgi?id=193588
1032         <rdar://problem/47131566>
1033
1034         Reviewed by Alex Christensen.
1035
1036         Add layout test coverage.
1037
1038         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1039
1040 2019-01-18  Jer Noble  <jer.noble@apple.com>
1041
1042         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
1043         https://bugs.webkit.org/show_bug.cgi?id=189553
1044
1045         Reviewed by Tim Horton.
1046
1047         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
1048
1049         * ContentExtensionTester/Configurations/Base.xcconfig:
1050         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
1051         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1052         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
1053         * ImageDiff/cg/Configurations/Base.xcconfig:
1054         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
1055         * MiniBrowser/Configurations/Base.xcconfig:
1056         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
1057         * MobileMiniBrowser/Configurations/Base.xcconfig:
1058         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
1059         * Scripts/webkitpy/style/checker.py:
1060         (_all_categories):
1061         (FileType):
1062         (CheckerDispatcher._file_type):
1063         (CheckerDispatcher._create_checker):
1064         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
1065         (SDKVariantChecker):
1066         (SDKVariantChecker.__init__):
1067         (SDKVariantChecker.check):
1068         * TestWebKitAPI/Configurations/Base.xcconfig:
1069         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
1070         * WebEditingTester/Configurations/Base.xcconfig:
1071         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
1072         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
1073         * WebKitTestRunner/Configurations/Base.xcconfig:
1074         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
1075         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
1076         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
1077
1078 2019-01-18  David Kilzer  <ddkilzer@apple.com>
1079
1080         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
1081         <https://webkit.org/b/193568>
1082         <rdar://problem/47381130>
1083
1084         Reviewed by Alex Christensen.
1085
1086         Make sure no one re-introduces UIKit soft-linking by adding a
1087         style rule.
1088
1089         * Scripts/webkitpy/style/checkers/cpp.py:
1090         (check_language): Add softlink/uikit check.
1091         (CppChecker): Enable softlink/uikit check.
1092         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1093         (CppStyleTest): Add test for softlink/uikit.
1094
1095 2019-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
1096
1097         [GTK] install-dependencies tool looks for libunistring-dev for dnf
1098         https://bugs.webkit.org/show_bug.cgi?id=193584
1099
1100         Change "-dev" to "-devel".
1101
1102         Reviewed by Michael Catanzaro.
1103
1104         * gtk/install-dependencies:
1105
1106 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
1107
1108         webkitpy: Add iPhone and iPad ports
1109         https://bugs.webkit.org/show_bug.cgi?id=193537
1110         <rdar://problem/47353390>
1111
1112         Reviewed by Lucas Forschler.
1113
1114         Add --iphone-simulator and --ipad-simulator commands to run-webkit-tests which separate iPhone and iPad into separate
1115         ports. Note that this separation is optional, the --ios-simulator command remains.
1116
1117         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1118         (RunTest.test_device_type_test_division): Drive-by fix.
1119         (RunTest.test_device_type_specific_listing): Ditto.
1120         (RunTest.test_ipad_test_division):
1121         (RunTest):
1122         (RunTest.test_ipad_listing):
1123         * Scripts/webkitpy/port/factory.py:
1124         (platform_options): Add --iphone-simulator and --ipad-simulator flags.
1125         (PortFactory):
1126         * Scripts/webkitpy/port/ios_simulator.py:
1127         (IPhoneSimulatorPort):
1128         (IPadSimulatorPort):
1129
1130 2019-01-18  Chris Dumez  <cdumez@apple.com>
1131
1132         Regression(PSON) Scroll position is not always restored properly when navigating back
1133         https://bugs.webkit.org/show_bug.cgi?id=193578
1134         <rdar://problem/47386331>
1135
1136         Reviewed by Tim Horton.
1137
1138         Add API test coverage.
1139
1140         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1141
1142 2019-01-18  Youenn Fablet  <youenn@apple.com>
1143
1144         Add a new SPI to request for cache storage quota increase
1145         https://bugs.webkit.org/show_bug.cgi?id=193323
1146
1147         Reviewed by Alex Christensen.
1148
1149         Implement WebsiteDataStore quota delegate to handle quota requests.
1150         By default, do not update quota.
1151         Update quota if test calls the new testRunner.allowCacheStorageQuotaIncrease method.
1152
1153         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1154         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1155         (WTR::TestRunner::allowCacheStorageQuotaIncrease):
1156         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1157         * WebKitTestRunner/TestController.cpp:
1158         (WTR::TestController::allowCacheStorageQuotaIncrease):
1159         * WebKitTestRunner/TestController.h:
1160         * WebKitTestRunner/TestInvocation.cpp:
1161         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1162         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1163         (-[CacheStorageQuotaManager init]):
1164         (-[CacheStorageQuotaManager _requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
1165         (WTR::initializeWebViewConfiguration):
1166         (WTR::TestController::cocoaResetStateToConsistentValues):
1167         (WTR::TestController::allowCacheStorageQuotaIncrease):
1168
1169 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
1170
1171         [ews-build] Pass owner to the triggered builds
1172         https://bugs.webkit.org/show_bug.cgi?id=193574
1173
1174         Reviewed by Lucas Forschler.
1175
1176         * BuildSlaveSupport/ews-build/factories.py:
1177         (BuildFactory.propertiesToPassToTriggers):
1178
1179 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
1180
1181         [ews-app] Send patch author as a build property
1182         https://bugs.webkit.org/show_bug.cgi?id=193560
1183
1184         Reviewed by Lucas Forschler.
1185
1186         * BuildSlaveSupport/ews-app/ews/fetcher.py:
1187         (BugzillaPatchFetcher.fetch):
1188
1189 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
1190
1191         webkitpy: Implement device type specific expected results (Follow-up fix)
1192         https://bugs.webkit.org/show_bug.cgi?id=192162
1193         <rdar://problem/46345449>
1194
1195         Unreviewed infrastructure fix.
1196
1197         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1198         (Manager.run): Don't boot a device if no tests are available to run on it.
1199
1200 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
1201
1202         webkitpy: Implement device type specific expected results (Follow-up fix)
1203         https://bugs.webkit.org/show_bug.cgi?id=192162
1204         <rdar://problem/46345449>
1205
1206         Unreviewed infrastructure fix.
1207
1208         * Scripts/webkitpy/api_tests/manager.py:
1209         (Manager._initialize_devices): Use DEVICE_TYPE when running API tests.
1210
1211 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
1212
1213         webkitpy: Implement device type specific expected results (Part 2)
1214         https://bugs.webkit.org/show_bug.cgi?id=192162
1215         <rdar://problem/46345449>
1216
1217         Rubber-stamped by Aakash Jain.
1218
1219         This change uses device_type to select a different set of TestExpectation files based on the type of device running
1220         tests. This requires multiple baseline search paths to be used in a single instantiation of run-webkit-tests. Note
1221         that while multiple baseline search paths are used, any single test will only ever be run on a single device type.
1222
1223         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
1224         (LayoutTestFinder.find_tests): Pass device_type through.
1225         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py:
1226         (LayoutTestFinderTests.test_touched_but_skipped_test): Allow device_type to be passed in.
1227         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1228         (Manager.__init__): Make _expectations an OrderedDict indexed by device_type, add current_device_type.
1229         (Manager._collect_tests): Pass device type to test finder.
1230         (Manager._needs_web_platform_test):
1231         (Manager._prepare_lists): Index _expectations by device type.
1232         (Manager._test_input_for_file):
1233         (Manager._test_is_slow): Ditto.
1234         (Manager._test_should_dump_jsconsolelog_in_stderr):
1235         (Manager._test_should_dump_jsconsolelog_in_stderr): Ditto.
1236         (Manager._get_test_inputs):
1237         (Manager._update_worker_count):
1238         (Manager._set_up_run): Use current_device_type instead of passing device_type in.
1239         (Manager.run): Re-write function to gather and parse expectations from multiple baseline search paths. In the event
1240         that a test can be run on multiple device types, the first device in the device type list which is eligible will be
1241         the one which runs the test.
1242         (Manager._run_test_subset):
1243         (Manager._run_tests): Index _expectations by current_device_type.
1244         (Manager._print_expectation_line_for_test): Ditto.
1245         (Manager._print_expectations_for_subset): Ditto.
1246         (Manager.print_expectations): Re-write function to gather and parse expectations from multiple baseline search paths.
1247         Unlike run, this function will behave the same regardless of what devices are available.
1248         (Manager._custom_device_for_test): Deleted.
1249         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1250         (ManagerTest.test_uses_custom_device): Deleted.
1251         (ManagerTest.test_uses_custom_device.get_manager): Deleted.
1252         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1253         (JSONLayoutResultsGenerator.__init__): Pass expectations as a dictionary indexed by device type.
1254         (JSONLayoutResultsGenerator._insert_failure_summaries): The number of fixable tests must take into consideration
1255         all of the expectations.
1256         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
1257         (FakePort.skipped_layout_tests): Allow device_type to be passed in.
1258         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1259         (TestExpectations.__init__): Allow device_type to be passed through.
1260         (TestExpectations.parse_all_expectations): Pick expectations_dict by device type.
1261         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Allow device_type to be passed in.
1262         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1263         (summarize_results):
1264         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
1265         (summarized_results): Expectations are stored in a dictionary indexed by device_type. When determining the expectation
1266         a test ran with, one must check all expectations to find the first non-skip expectation.
1267         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1268         (RunTest.test_device_type_test_division):
1269         (RunTest):
1270         (RunTest.test_device_type_specific_listing):
1271         * Scripts/webkitpy/port/base.py:
1272         (Port): Add default values for DEVICE_TYPE and DEFAULT_DEVICE_TYPES.
1273         (Port.supported_device_types): The result of this function will change based on what devices are available.
1274         * Scripts/webkitpy/port/device_port.py:
1275         (DevicePort._device_type_with_version): Replace DEFAULT_DEVICE_TYPE with DEVICE_TYPE.
1276         (DevicePort.default_child_processes): DEVICE_TYPE is a general type, so the built-in comparison of the DeviceType object
1277         can be used.
1278         (DevicePort.supported_device_types): Generates a list of device types determined by the available devices, if there are
1279         any, or the DEFAULT_DEVICE_TYPES of the port.
1280         * Scripts/webkitpy/port/ios.py:
1281         (IOSPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
1282         * Scripts/webkitpy/port/ios_simulator.py:
1283         (IOSSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the devices currently used to run layout tests.
1284         * Scripts/webkitpy/port/watch.py:
1285         (WatchPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
1286         * Scripts/webkitpy/port/watch_simulator.py:
1287         (WatchSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the device currently used to run layout tests.
1288         * Scripts/webkitpy/xcode/device_type.py:
1289         (DeviceType):
1290         (DeviceType.__hash__): Allow DeviceType to be used as a dictionary index.
1291
1292 2019-01-18  Philippe Normand  <pnormand@igalia.com>
1293
1294         [WPE] run-qt-wpe-minibrowser needlessly expects a --wpe argument
1295         https://bugs.webkit.org/show_bug.cgi?id=193575
1296
1297         Reviewed by Michael Catanzaro.
1298
1299         Allow the script to run without explicit port argument because
1300         it's specific to the WPE port anyway.
1301
1302         * Scripts/run-qt-wpe-minibrowser: Manually insert --wpe in argv
1303         and simplify the rest of the code accordingly.
1304
1305 2019-01-18  Charlie Turner  <cturner@igalia.com>
1306
1307         [GStreamer][EME][ClearKey] Request keys from CDMInstance rather than passing via bus messages
1308         https://bugs.webkit.org/show_bug.cgi?id=192229
1309
1310         Reviewed by Xabier Rodriguez-Calvar.
1311
1312         * MiniBrowser/wpe/main.cpp:
1313         (main): Enable encrypted-media by default.
1314
1315 2019-01-18  Philippe Normand  <pnormand@igalia.com>
1316
1317         [Flatpak] Missing KeyboardInterrupt exception handler
1318         https://bugs.webkit.org/show_bug.cgi?id=193570
1319
1320         Reviewed by Michael Catanzaro.
1321
1322         * flatpak/flatpakutils.py:
1323         (WebkitFlatpak.run_in_sandbox): Basic KeyboardInterrupt handling.
1324
1325 2019-01-18  Zalan Bujtas  <zalan@apple.com>
1326
1327         [LFC][BFC][MarginCollapsing] Collapsing through should not ignore floats.
1328         https://bugs.webkit.org/show_bug.cgi?id=193564
1329
1330         Reviewed by Antti Koivisto.
1331
1332         * LayoutReloaded/misc/LFC-passing-tests.txt:
1333
1334 2019-01-18  Zalan Bujtas  <zalan@apple.com>
1335
1336         [LFC] Do not skip float boxes that are not part of the current formatting context when computing bottom.
1337         https://bugs.webkit.org/show_bug.cgi?id=193562
1338
1339         Reviewed by Antti Koivisto.
1340
1341         * LayoutReloaded/misc/LFC-passing-tests.txt:
1342
1343 2019-01-18  Zalan Bujtas  <zalan@apple.com>
1344
1345         [LFC][BFC] Check for inflow children while computing height for block formatting context roots.
1346         https://bugs.webkit.org/show_bug.cgi?id=193555
1347
1348         Reviewed by Antti Koivisto.
1349
1350         * LayoutReloaded/misc/LFC-passing-tests.txt:
1351
1352 2019-01-18  Philippe Normand  <pnormand@igalia.com>
1353
1354         [WPE] Add Qt extension
1355         https://bugs.webkit.org/show_bug.cgi?id=191464
1356
1357         Reviewed by Carlos Garcia Campos.
1358
1359         MiniBrowser and API tests for the WPE Qt API. To run the
1360         MiniBrowser a new script is introduced. Example invocation:
1361
1362         $ run-qt-wpe-minibrowser -platform wayland https://webkit.org
1363
1364         Also note-worthy is the introduction of the python2-subprocess32
1365         dependency to run the GLib API tests.
1366
1367         * MiniBrowser/wpe/CMakeLists.txt:
1368         * MiniBrowser/wpe/qt/CMakeLists.txt: Added.
1369         * MiniBrowser/wpe/qt/main.cpp: Added.
1370         (main):
1371         * MiniBrowser/wpe/qt/main.qml: Added.
1372         * MiniBrowser/wpe/qt/qml.qrc: Added.
1373         * Scripts/run-gtk-tests:
1374         (GtkTestRunner.is_google_test):
1375         (GtkTestRunner):
1376         (GtkTestRunner.is_qt_test):
1377         * Scripts/run-qt-wpe-minibrowser: Added.
1378         * Scripts/run-wpe-tests:
1379         (WPETestRunner):
1380         (WPETestRunner.is_google_test):
1381         (WPETestRunner.is_qt_test):
1382         * TestWebKitAPI/Tests/WPEQt/TestLoad.cpp: Added.
1383         (TestLoad::main):
1384         * TestWebKitAPI/Tests/WPEQt/TestLoadHtml.cpp: Added.
1385         (TestLoadHtml::main):
1386         * TestWebKitAPI/Tests/WPEQt/TestLoadRequest.cpp: Added.
1387         (TestLoadRequest::main):
1388         * TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp: Added.
1389         (TestRunJavaScript::main):
1390         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.cpp: Added.
1391         (waitForSignal):
1392         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.h: Added.
1393         (LoadSpy::LoadSpy):
1394         (LoadSpy::~LoadSpy):
1395         (LoadSpy::onLoadingChanged):
1396         (LoadStartedCatcher::LoadStartedCatcher):
1397         (LoadStartedCatcher::~LoadStartedCatcher):
1398         (LoadStartedCatcher::onLoadingChanged):
1399         (waitForLoadSucceeded):
1400         (waitForLoadFailed):
1401         * TestWebKitAPI/glib/CMakeLists.txt:
1402         * flatpak/flatpakutils.py:
1403         (WebkitFlatpak.load_from_args):
1404         (WebkitFlatpak.__init__):
1405         (WebkitFlatpak.clean_args):
1406         (WebkitFlatpak.run_in_sandbox):
1407         * flatpak/org.webkit.CommonModules.yaml:
1408         * flatpak/org.webkit.WPE.yaml:
1409         * flatpak/org.webkit.WPEModules.yaml:
1410         * flatpak/org.webkit.WPEQT.yaml: Copied from Tools/flatpak/org.webkit.WebKit.yaml.
1411         * flatpak/org.webkit.WebKit.yaml:
1412         * glib/api_test_runner.py:
1413         (TestRunner._run_test_qt):
1414         (TestRunner.is_qt_test):
1415         (TestRunner._run_test):
1416
1417 2019-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1418
1419         [iOS] Content offset jumps erratically when autoscrolling near scroll view content inset areas
1420         https://bugs.webkit.org/show_bug.cgi?id=193494
1421         <rdar://problem/46859627>
1422
1423         Reviewed by Simon Fraser and Tim Horton.
1424
1425         Add a new test option to add a top content inset to the test runner's WKWebView's scroll view, and automatically
1426         scroll to reveal this top content inset area when beginning the test (i.e., scroll to (0, -topContentInset)).
1427
1428         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1429         (WTR::UIScriptController::contentOffsetX const):
1430         (WTR::UIScriptController::contentOffsetY const):
1431         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1432         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1433         (WTR::UIScriptController::contentOffsetX const):
1434         (WTR::UIScriptController::contentOffsetY const):
1435         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1436
1437         Also add new UIScriptController methods to ask for the content offset of the platform scroll view.
1438
1439         * WebKitTestRunner/TestController.cpp:
1440         (WTR::updateTestOptionsFromTestHeader):
1441         * WebKitTestRunner/TestOptions.h:
1442         (WTR::TestOptions::hasSameInitializationOptions const):
1443         * WebKitTestRunner/ios/TestControllerIOS.mm:
1444         (WTR::TestController::platformResetStateToConsistentValues):
1445         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1446         (WTR::UIScriptController::contentOffsetX const):
1447         (WTR::UIScriptController::contentOffsetY const):
1448
1449 2019-01-17  Truitt Savell  <tsavell@apple.com>
1450
1451         Unreviewed, rolling out r240124.
1452
1453         This commit broke an internal build.
1454
1455         Reverted changeset:
1456
1457         "SDK_VARIANT build destinations should be separate from non-
1458         SDK_VARIANT builds"
1459         https://bugs.webkit.org/show_bug.cgi?id=189553
1460         https://trac.webkit.org/changeset/240124
1461
1462 2019-01-17  Alex Christensen  <achristensen@webkit.org>
1463
1464         Fix string concatenation API test after r239920
1465         https://bugs.webkit.org/show_bug.cgi?id=193551
1466         <rdar://problem/47359304>
1467
1468         Reviewed by Youenn Fablet.
1469
1470         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
1471         (TestWebKitAPI::TEST):
1472         Cocoa platforms' interpretation of UChar/unsigned short equality is not affected by ICU's recent change of UChar's type
1473         in WebKit's build configuration like it apparently is on Linux.
1474
1475 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
1476
1477         [ews-build] validate-patch should handle the case when bug_id is None
1478         https://bugs.webkit.org/show_bug.cgi?id=193547
1479
1480         Reviewed by Lucas Forschler.
1481
1482         * BuildSlaveSupport/ews-build/steps.py:
1483         (ValidatePatch._is_bug_closed): Gracefully handle the case when bug_id is None.
1484         (ValidatePatch.start): If bug_id is set as None in build properties, fetch it from the patch.
1485
1486 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
1487
1488         [ews-build] Add patch author information in build
1489         https://bugs.webkit.org/show_bug.cgi?id=193465
1490
1491         Reviewed by Lucas Forschler.
1492
1493         * BuildSlaveSupport/ews-build/steps.py:
1494         (ValidatePatch._is_patch_obsolete):
1495
1496 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
1497
1498         [ews-build] Pass bug_id to the triggered builds
1499         https://bugs.webkit.org/show_bug.cgi?id=193548
1500
1501         Reviewed by Lucas Forschler.
1502
1503         * BuildSlaveSupport/ews-build/factories.py:
1504         (BuildFactory.propertiesToPassToTriggers):
1505
1506 2019-01-17  Jer Noble  <jer.noble@apple.com>
1507
1508         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
1509         https://bugs.webkit.org/show_bug.cgi?id=189553
1510
1511         Reviewed by Tim Horton.
1512
1513         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
1514
1515         * ContentExtensionTester/Configurations/Base.xcconfig:
1516         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
1517         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1518         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
1519         * ImageDiff/cg/Configurations/Base.xcconfig:
1520         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
1521         * MiniBrowser/Configurations/Base.xcconfig:
1522         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
1523         * MobileMiniBrowser/Configurations/Base.xcconfig:
1524         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
1525         * Scripts/webkitpy/style/checker.py:
1526         (_all_categories):
1527         (FileType):
1528         (CheckerDispatcher._file_type):
1529         (CheckerDispatcher._create_checker):
1530         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
1531         (SDKVariantChecker):
1532         (SDKVariantChecker.__init__):
1533         (SDKVariantChecker.check):
1534         * TestWebKitAPI/Configurations/Base.xcconfig:
1535         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
1536         * WebEditingTester/Configurations/Base.xcconfig:
1537         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
1538         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
1539         * WebKitTestRunner/Configurations/Base.xcconfig:
1540         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
1541         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
1542         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
1543
1544 2019-01-17  Zalan Bujtas  <zalan@apple.com>
1545
1546         [LFC][BFC] An element with transform is a containing block for positioned descendants.
1547         https://bugs.webkit.org/show_bug.cgi?id=193534
1548
1549         Reviewed by Antti Koivisto.
1550
1551         * LayoutReloaded/misc/LFC-passing-tests.txt:
1552
1553 2019-01-17  Zalan Bujtas  <zalan@apple.com>
1554
1555         [LFC][BFC][Quirk] Take body padding and border into account when stretching height.
1556         https://bugs.webkit.org/show_bug.cgi?id=193528
1557
1558         Reviewed by Antti Koivisto.
1559
1560         * LayoutReloaded/misc/LFC-passing-tests.txt:
1561
1562 2019-01-17  Zalan Bujtas  <zalan@apple.com>
1563
1564         [LFC][BFC] For height computation, the bottom edge of the last line box value should include top border/padding
1565         https://bugs.webkit.org/show_bug.cgi?id=193520
1566
1567         Reviewed by Antti Koivisto.
1568
1569         * LayoutReloaded/misc/LFC-passing-tests.txt:
1570
1571 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
1572
1573         [ews-build] unapply-patch step should not update source
1574         https://bugs.webkit.org/show_bug.cgi?id=193234
1575
1576         Reviewed by Lucas Forschler.
1577
1578         * BuildSlaveSupport/ews-build/steps.py:
1579         (CleanWorkingDirectory): Use clean-webkit script to clean the working directory.
1580         (UnApplyPatchIfRequired): Use CleanWorkingDirectory as base class.
1581
1582 2019-01-16  Youenn Fablet  <youenn@apple.com>
1583
1584         Add a new SPI for controlling getUserMedia
1585         https://bugs.webkit.org/show_bug.cgi?id=192793
1586
1587         Reviewed by Eric Carlson.
1588
1589         * MiniBrowser/mac/WK2BrowserWindowController.m:
1590         (-[WK2BrowserWindowController _webView:requestUserMediaAuthorizationForFrame:devices:decisionHandler:]):
1591         (-[WK2BrowserWindowController _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
1592         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
1593         (-[NavigationWhileGetUserMediaPromptDisplayedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
1594         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
1595         (-[GetUserMediaRepromptUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
1596         * TestWebKitAPI/Tests/WebKit/MediaStreamTrackDetached.mm:
1597         (-[MediaStreamTrackDetachedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
1598         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
1599         (-[UserMediaUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
1600         (-[UserMediaUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
1601         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
1602         (-[SimulateFailedSandboxUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
1603         (-[SimulateFailedSandboxUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
1604
1605 2019-01-16  Zalan Bujtas  <zalan@apple.com>
1606
1607         [LFC][BFC] Inflow non-replaced used width should not be negative.
1608         https://bugs.webkit.org/show_bug.cgi?id=193495
1609
1610         Reviewed by Antti Koivisto.
1611
1612         * LayoutReloaded/misc/LFC-passing-tests.txt:
1613
1614 2019-01-16  Chris Dumez  <cdumez@apple.com>
1615
1616         Regression(PSON) View becomes blank after click a cross-site download link
1617         https://bugs.webkit.org/show_bug.cgi?id=193361
1618         <rdar://problem/47099573>
1619
1620         Reviewed by Geoffrey Garen.
1621
1622         Add API test coverage.
1623
1624         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1625         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1626
1627 2019-01-16  Zalan Bujtas  <zalan@apple.com>
1628
1629         [LFC][Out-of-flow] Set used vertical margin values when top/height/bottom are non-auto.
1630         https://bugs.webkit.org/show_bug.cgi?id=193470
1631
1632         Reviewed by Antti Koivisto.
1633
1634         * LayoutReloaded/misc/LFC-passing-tests.txt:
1635
1636 2019-01-16  Zalan Bujtas  <zalan@apple.com>
1637
1638         [LFC] Adjust margin box verification.
1639         https://bugs.webkit.org/show_bug.cgi?id=193482
1640
1641         Reviewed by Antti Koivisto.
1642
1643         * LayoutReloaded/misc/LFC-passing-tests.txt:
1644
1645 2019-01-15  Sihui Liu  <sihui_liu@apple.com>
1646
1647         Fix API test WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming after 193354
1648         https://bugs.webkit.org/show_bug.cgi?id=193451
1649
1650         Reviewed by Geoffrey Garen.
1651
1652         * TestWebKitAPI/Tests/WebKitCocoa/DuplicateCompletionHandlerCalls.mm:
1653         (TEST):
1654         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1655         (runWebsiteDataStoreCustomPaths):
1656
1657 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
1658
1659         webkitpy: Support boolean simctl isAvailable
1660         https://bugs.webkit.org/show_bug.cgi?id=193472
1661         <rdar://problem/47296150>
1662
1663         Reviewed by Ryosuke Niwa.
1664
1665         * Scripts/webkitpy/xcode/simulated_device.py:
1666         (SimulatedDeviceManager._create_runtimes):
1667         (SimulatedDeviceManager._create_device_with_runtime):
1668
1669 2019-01-15  Chris Dumez  <cdumez@apple.com>
1670
1671         Unreviewed, rolling out r239993, r239995, r239997, and
1672         r239999.
1673
1674         Caused assertions under
1675         ViewGestureController::disconnectFromProcess()
1676
1677         Reverted changesets:
1678
1679         "Regression(PSON) View becomes blank after click a cross-site
1680         download link"
1681         https://bugs.webkit.org/show_bug.cgi?id=193361
1682         https://trac.webkit.org/changeset/239993
1683
1684         "Unreviewed iOS build fix after r239993."
1685         https://trac.webkit.org/changeset/239995
1686
1687         "Fix iOS build after r239993"
1688         https://bugs.webkit.org/show_bug.cgi?id=193361
1689         https://trac.webkit.org/changeset/239997
1690
1691         "Unreviewed, revert part of r239997 as it is not needed to fix
1692         the build."
1693         https://trac.webkit.org/changeset/239999
1694
1695 2019-01-15  Tim Horton  <timothy_horton@apple.com>
1696
1697         Cannot tab out of WKWebView on macOS
1698         https://bugs.webkit.org/show_bug.cgi?id=161448
1699         <rdar://problem/28100085>
1700
1701         Reviewed by Dean Jackson.
1702
1703         Add a test that tabbing into and out of WKWebView works correctly.
1704
1705         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1706         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
1707         (WebKit2_CommandBackForwardTest::SetUp):
1708         (-[CommandBackForwardOffscreenWindow isKeyWindow]): Deleted.
1709         (-[CommandBackForwardOffscreenWindow isVisible]): Deleted.
1710         * TestWebKitAPI/Tests/WebKitCocoa/TabOutOfWebView.mm: Added.
1711         (-[FocusableView canBecomeKeyView]):
1712         (TEST):
1713         * TestWebKitAPI/mac/OffscreenWindow.h: Added.
1714         * TestWebKitAPI/mac/OffscreenWindow.mm: Added.
1715         (-[OffscreenWindow initWithSize:]):
1716         (-[OffscreenWindow isKeyWindow]):
1717         (-[OffscreenWindow isVisible]):
1718         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1719         (TestWebKitAPI::PlatformWebView::initialize):
1720         (-[ActiveOffscreenWindow isKeyWindow]): Deleted.
1721         (-[ActiveOffscreenWindow isVisible]): Deleted.
1722         Factor ActiveOffscreenWindow out into OffscreenWindow and share it.
1723
1724 2019-01-15  Ryan Haddad  <ryanhaddad@apple.com>
1725
1726         Adjust the arguments passed to run-javascriptcore-tests for the 32-bit JSC bot
1727         https://bugs.webkit.org/show_bug.cgi?id=193459
1728
1729         Reviewed by Mark Lam.
1730
1731         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1732         (Run32bitJSCTests): This queue should not run JIT, testair, testb3, or testmasm.
1733
1734 2019-01-15  Chris Dumez  <cdumez@apple.com>
1735
1736         Regression(PSON) View becomes blank after click a cross-site download link
1737         https://bugs.webkit.org/show_bug.cgi?id=193361
1738         <rdar://problem/47099573>
1739
1740         Reviewed by Geoff Garen.
1741
1742         Add API test coverage.
1743
1744         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1745         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1746
1747 2019-01-15  Zalan Bujtas  <zalan@apple.com>
1748
1749         [LFC][Out-of-flow] Ignore bottom when the vertical values are over-constrained
1750         https://bugs.webkit.org/show_bug.cgi?id=193448
1751
1752         Reviewed by Antti Koivisto.
1753
1754         * LayoutReloaded/misc/LFC-passing-tests.txt:
1755
1756 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
1757
1758         webkitpy: Implement device type specific expected results (Part 1)
1759         https://bugs.webkit.org/show_bug.cgi?id=192162
1760
1761         Reviewed by Lucas Forschler.
1762
1763         Device type specific expected results covers two related ideas. The first (covered by this change)
1764         is where to search for -expected.* files. The second is which tests to run based on the
1765         TestExpectations.txt file.
1766
1767         After this change, the baseline search path will be determined by the type of device running a
1768         test. Device type will be passed into any function which picks a file based on the baseline search
1769         path.
1770
1771         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1772         (Worker._update_test_input): Pass device_type to self._port.reference_files(...).
1773         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1774         (Manager.run): Print baseline search path for each round of devices.
1775         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1776         (SingleTestRunner.__init__): Pass device_type into expected_*(...).
1777         (SingleTestRunner._expected_driver_output): Ditto.
1778         (SingleTestRunner._driver_input): Ditto.
1779         * Scripts/webkitpy/layout_tests/views/printing.py:
1780         (Printer.print_config): Move printing of baseline search path to a separate function.
1781         (Printer.print_baseline_search_path): Moved from Printer.print_config.
1782         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1783         (Testprinter.test_print_config):
1784         (Testprinter.test_print_baseline_search_path):
1785         * Scripts/webkitpy/port/base.py:
1786         (Port.baseline_search_path): Pass device_type through.
1787         (Port._expected_baselines_for_suffixes): Ditto.
1788         (Port.expected_baselines): Ditto.
1789         (Port.expected_filename): Ditto.
1790         (Port.expected_checksum): Ditto.
1791         (Port.expected_image): Ditto.
1792         (Port.expected_audio): Ditto.
1793         (Port.expected_text): Ditto.
1794         (Port.reference_files): Ditto.
1795         (Port.tests): Ditto.
1796         (Port._expanded_paths): Ditto.
1797         (Port.skipped_layout_tests): Ditto.
1798         (Port.expectations_dict): Ditto.
1799         (Port._port_specific_expectations_files): Ditto.
1800         (Port.expectations_files): Ditto.
1801         (Port.test_search_path): Ditto.
1802         (Port._tests_for_other_platforms): Ditto.
1803         * Scripts/webkitpy/port/base_unittest.py:
1804         (PortTest.test_additional_platform_directory): Accept, but do not use, device_type.
1805         (PortTest.test_nonexistant_expectations): Ditto.
1806         (test_ref_tests_platform_directory): Ditto.
1807         * Scripts/webkitpy/port/darwin.py:
1808         (DarwinPort._port_specific_expectations_files): Accept device_type.
1809         * Scripts/webkitpy/port/driver.py:
1810         (DriverProxy):
1811         (DriverProxy.host): Expose _target_host for device_type information.
1812         * Scripts/webkitpy/port/gtk.py:
1813         (GtkPort._port_specific_expectations_files): Accept, but do not use, device_type.
1814         * Scripts/webkitpy/port/ios.py:
1815         (IOSPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
1816         * Scripts/webkitpy/port/mac.py:
1817         (MacPort. default_baseline_search_path): Ditto.
1818         * Scripts/webkitpy/port/port_testcase.py:
1819         (TestWebKitPort._tests_for_other_platforms): Accept, but do not use, device_type.
1820         * Scripts/webkitpy/port/test.py:
1821         * Scripts/webkitpy/port/watch.py:
1822         (WatchPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
1823         * Scripts/webkitpy/port/win.py:
1824         (WinPort.test_search_path): Accept, but do not use, device_type.
1825         * Scripts/webkitpy/port/wpe.py:
1826         (WPEPort._port_specific_expectations_files): Ditto.
1827         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
1828         (get_test_baselines.AllPlatformsPort.baseline_search_path): Ditto.
1829
1830 2019-01-15  Zalan Bujtas  <zalan@apple.com>
1831
1832         [LFC] Use the containing block's padding box to position out-of-flow elements.
1833         https://bugs.webkit.org/show_bug.cgi?id=193431
1834
1835         Reviewed by Antti Koivisto.
1836
1837         * LayoutReloaded/misc/LFC-passing-tests.txt:
1838
1839 2019-01-14  Tim Horton  <timothy_horton@apple.com>
1840
1841         Move a test implementation file that got misplaced in the Xcode project
1842
1843         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1844
1845 2019-01-14  Commit Queue  <commit-queue@webkit.org>
1846
1847         Unreviewed, rolling out r239901, r239909, r239910, r239912,
1848         r239913, and r239914.
1849         https://bugs.webkit.org/show_bug.cgi?id=193407
1850
1851         These revisions caused an internal failure (Requested by
1852         Truitt on #webkit).
1853
1854         Reverted changesets:
1855
1856         "[Cocoa] Avoid importing directly from subumbrella frameworks"
1857         https://bugs.webkit.org/show_bug.cgi?id=186016
1858         https://trac.webkit.org/changeset/239901
1859
1860         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
1861         https://trac.webkit.org/changeset/239909
1862
1863         "Tried to fix the build."
1864         https://trac.webkit.org/changeset/239910
1865
1866         "Fixed iOS builds after r239910."
1867         https://trac.webkit.org/changeset/239912
1868
1869         "More build fixing."
1870         https://trac.webkit.org/changeset/239913
1871
1872         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
1873         https://trac.webkit.org/changeset/239914
1874
1875 2019-01-14  Mark Lam  <mark.lam@apple.com>
1876
1877         Re-enable ability to build --cloop builds.
1878         https://bugs.webkit.org/show_bug.cgi?id=192955
1879         <rdar://problem/46882363>
1880
1881         Reviewed by Saam barati and Keith Miller.
1882
1883         The --cloop build option was being ignored this whole time since r236381.
1884         This patch makes it possible to build CLoop builds again.
1885
1886         * Scripts/build-jsc:
1887         * Scripts/webkitperl/FeatureList.pm:
1888         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1889
1890 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
1891
1892         webkitpy: Expose device_type from host-like objects
1893         https://bugs.webkit.org/show_bug.cgi?id=193406
1894         <rdar://problem/47262305>
1895
1896         Reviewed by Lucas Forschler.
1897
1898         Devices should expose device_type. As a result, all host objects should
1899         provide a device_type property, even if they do not yet define a device_type.
1900
1901         * Scripts/webkitpy/common/system/systemhost.py:
1902         (SystemHost):
1903         (SystemHost.device_type):
1904         * Scripts/webkitpy/common/system/systemhost_mock.py:
1905         (MockSystemHost):
1906         (MockSystemHost.device_type):
1907         * Scripts/webkitpy/port/device.py:
1908         (Device):
1909         (Device.device_type):
1910         * Scripts/webkitpy/xcode/simulated_device.py:
1911         (SimulatedDeviceManager._find_exisiting_device_for_request):
1912         (SimulatedDeviceManager._disambiguate_device_type):
1913         (SimulatedDeviceManager._does_fulfill_request):
1914         (SimulatedDeviceManager.device_count_for_type):
1915         (SimulatedDeviceManager.initialize_devices):
1916         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
1917         (test_available_devices):
1918         (test_swapping_devices):
1919
1920 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
1921
1922         webkitpy: Support alternate simctl device list output (Follow-up fix)
1923         https://bugs.webkit.org/show_bug.cgi?id=193362
1924         <rdar://problem/47122965>
1925
1926         Rubber-stamped by Lucas Forschler.
1927
1928         * Scripts/webkitpy/xcode/simulated_device.py:
1929         (SimulatedDeviceManager.populate_available_devices):
1930
1931 2019-01-14  Wenson Hsieh  <wenson_hsieh@apple.com>
1932
1933         [iOS] Expose SPI to access the current sentence boundary and selection state
1934         https://bugs.webkit.org/show_bug.cgi?id=193398
1935         <rdar://problem/45893108>
1936
1937         Reviewed by Dean Jackson.
1938
1939         Add an API test to verify that an SPI client can observe changes in the `@"_selectionAttributes"` key path on
1940         WKWebView, and that inserting text, deleting, and changing the selection cause selection attributes to change as
1941         expected.
1942
1943         * TestWebKitAPI/EditingTestHarness.h:
1944         * TestWebKitAPI/EditingTestHarness.mm:
1945         (-[EditingTestHarness moveBackward]):
1946         (-[EditingTestHarness moveForward]):
1947         (-[EditingTestHarness moveForwardAndExpectEditorStateWith:]):
1948
1949         Add a couple of new helper methods on EditingTestHarness.
1950
1951         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
1952         (-[SelectionChangeObserver initWithWebView:]):
1953         (-[SelectionChangeObserver webView]):
1954         (-[SelectionChangeObserver observeValueForKeyPath:ofObject:change:context:]):
1955         (-[SelectionChangeObserver currentSelectionAttributes]):
1956
1957 2019-01-14  Zalan Bujtas  <zalan@apple.com>
1958
1959         [LFC][BFC] Add basic box-sizing support.
1960         https://bugs.webkit.org/show_bug.cgi?id=193392
1961
1962         Reviewed by Antti Koivisto.
1963
1964         * LayoutReloaded/misc/LFC-passing-tests.txt:
1965
1966 2019-01-14  Charlie Turner  <cturner@igalia.com>
1967
1968         [WPE] API test gardening
1969         https://bugs.webkit.org/show_bug.cgi?id=193319
1970
1971         Reviewed by Michael Catanzaro.
1972
1973         * TestWebKitAPI/glib/TestExpectations.json: Remove some now
1974         passing tests.
1975
1976 2019-01-14  Charlie Turner  <cturner@igalia.com>
1977
1978         [GStreamer] Add sharedBuffer utility to GstMappedBuffer, and a testsuite
1979         https://bugs.webkit.org/show_bug.cgi?id=192977
1980
1981         Reviewed by Carlos Garcia Campos.
1982
1983         * TestWebKitAPI/PlatformGTK.cmake: Build the new GStreamer test harness
1984         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
1985         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp: Added.
1986         (TestWebKitAPI::GStreamerTest::SetUp):
1987         (TestWebKitAPI::GStreamerTest::TearDown):
1988         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.h: Added.
1989         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp: Added.
1990         (TestWebKitAPI::TEST_F):
1991
1992 2019-01-14  Charlie Turner  <cturner@igalia.com>
1993
1994         [WPE] Workaround for incorrect template specialization being selected when UChar=char16_t
1995         https://bugs.webkit.org/show_bug.cgi?id=193332
1996
1997         Reviewed by Michael Catanzaro.
1998
1999         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: When UChar is
2000         defined as a char16_t, which changed in ICU 59, the
2001         StringTypeAdapter<UnsignedInt, ...> overload catches casts to
2002         unsigned short. This test is relying on the behaviour that
2003         UChar=unsigned short, which doesn't hold across platforms and ICU
2004         library versions. The full fix would be a special syntax for
2005         literal characters so that these ambiguities do not arise. That
2006         work is proposed in https://bugs.webkit.org/show_bug.cgi?id=193101.
2007         (TestWebKitAPI::TEST):
2008
2009 2019-01-14  Carlos Garcia Campos  <cgarcia@igalia.com>
2010
2011         Unreviewed. [GTK][WPE] Run distcheck with gtkdoc and MiniBrowser enabled
2012
2013         * Scripts/make-dist:
2014         (Distcheck.configure):
2015
2016 2019-01-13  Aakash Jain  <aakash_jain@apple.com>
2017
2018         [ews-build] Update macOS queue configurations
2019         https://bugs.webkit.org/show_bug.cgi?id=193365
2020         <rdar://problem/47221073>
2021
2022         Unreviewed, renamed mac-high-sierra to mac-highsierra to match with build.webkit.org configuration.
2023
2024         * BuildSlaveSupport/ews-build/config.json:
2025
2026 2019-01-13  Zalan Bujtas  <zalan@apple.com>
2027
2028         [LFC] Adjust assert for statically positioned fixed elements
2029         https://bugs.webkit.org/show_bug.cgi?id=193385
2030
2031         Reviewed by Antti Koivisto.
2032
2033         * LayoutReloaded/misc/LFC-passing-tests.txt:
2034
2035 2019-01-13  Philippe Normand  <pnormand@igalia.com>
2036
2037         [WPE][MiniBrowser] Ephemeral WebContext leaks in automation mode
2038         https://bugs.webkit.org/show_bug.cgi?id=193387
2039
2040         Reviewed by Carlos Garcia Campos.
2041
2042         * MiniBrowser/wpe/main.cpp:
2043         (main):
2044
2045 2019-01-12  Timothy Hatcher  <timothy@apple.com>
2046
2047         Have prefers-color-scheme: light always match on macOS versions before Mojave.
2048         https://bugs.webkit.org/show_bug.cgi?id=191655
2049         rdar://problem/46074680
2050
2051         Reviewed by Megan Gardner.
2052
2053         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
2054         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
2055
2056 2019-01-12  Dan Bernstein  <mitz@apple.com>
2057
2058         [Cocoa] Avoid importing directly from subumbrella frameworks
2059         https://bugs.webkit.org/show_bug.cgi?id=186016
2060         <rdar://problem/40591038>
2061
2062         Reviewed by Sam Weinig.
2063
2064         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
2065           LaunchServices header.
2066         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
2067           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
2068         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
2069           when using SDKs earlier than 10.13.
2070         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
2071           and OTHER_CPLUSPLUSFLAGS.
2072         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
2073           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
2074         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
2075           LaunchServices header.
2076
2077 2019-01-11  John Wilander  <wilander@apple.com>
2078
2079         Compile out Web API Statistics Collection
2080         https://bugs.webkit.org/show_bug.cgi?id=193370
2081         <rdar://problem/45388584>
2082
2083         Reviewed by Brent Fulgham.
2084
2085         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2086             Defined ENABLE_WEB_API_STATISTICS, off by default.
2087
2088 2019-01-11  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
2089
2090         [WPE] Add gtk-doc
2091         https://bugs.webkit.org/show_bug.cgi?id=178900
2092
2093         Reviewed by Michael Catanzaro.
2094
2095         Add Tools/gtkdoc to manifest.txt.in files.
2096         This should have been done in r238853 and caused failure in building WebKitGTK+ unstable release 2.23.2.
2097
2098         * gtk/manifest.txt.in: Add Tools/gtkdoc directory.
2099         * wpe/manifest.txt.in: Add Tools/gtkdoc directory and uncomment lines to move documentation artifacts.
2100
2101 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2102
2103         [iOS] Precision drop state thrashes when dragging near the top edge of an editable element
2104         https://bugs.webkit.org/show_bug.cgi?id=193364
2105         <rdar://problem/47214117>
2106
2107         Reviewed by Tim Horton.
2108
2109         Add a test to verify that dragging near the top of a textarea element does not flag the drop proposal as
2110         precise, whereas dragging near the middle of the textarea does.
2111
2112         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2113         (TestWebKitAPI::TEST):
2114
2115 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
2116
2117         webkitpy: Support alternate simctl device list output
2118         https://bugs.webkit.org/show_bug.cgi?id=193362
2119         <rdar://problem/47122965>
2120
2121         Reviewed by Lucas Forschler.
2122
2123         * Scripts/webkitpy/xcode/simulated_device.py:
2124         (SimulatedDeviceManager.populate_available_devices):
2125
2126 2019-01-11  Aakash Jain  <aakash_jain@apple.com>
2127
2128         [ews-build] Update macOS queue configurations
2129         https://bugs.webkit.org/show_bug.cgi?id=193365
2130
2131         Reviewed by Lucas Forschler.
2132
2133         * BuildSlaveSupport/ews-build/config.json:
2134
2135 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
2136
2137         webkitpy: Incorporate device type into baseline search path
2138         https://bugs.webkit.org/show_bug.cgi?id=193356
2139         <rdar://problem/47215515>
2140
2141         Reviewed by Lucas Forschler.
2142
2143         We need a way to include device type in the baseline search path for iOS to support device specific test expectations.
2144
2145         * Scripts/webkitpy/port/base.py:
2146         (Port.default_baseline_search_path): Allow device type to be passed in.
2147         * Scripts/webkitpy/port/gtk.py:
2148         (GtkPort.default_baseline_search_path): Ignore device type.
2149         * Scripts/webkitpy/port/ios.py:
2150         (IOSPort.default_baseline_search_path): Optionally allow device type to be incorporated into the baseline search path.
2151         (IOSPort.test_expectations_file_position): Update index for the additional device-type specific baseline search path.
2152         * Scripts/webkitpy/port/ios_device_unittest.py:
2153         (IOSDeviceTest):
2154         * Scripts/webkitpy/port/ios_simulator_unittest.py:
2155         (IOSSimulatorTest):
2156         * Scripts/webkitpy/port/mac.py:
2157         (MacPort.default_baseline_search_path): Ignore device type.
2158         * Scripts/webkitpy/port/watch.py:
2159         (WatchPort.default_baseline_search_path): Ditto.
2160         * Scripts/webkitpy/port/win.py:
2161         (WinPort.default_baseline_search_path): Ditto.
2162         (WinCairoPort.default_baseline_search_path): Ditto.
2163         * Scripts/webkitpy/port/wpe.py:
2164         (WPEPort.default_baseline_search_path): Ditto.
2165
2166 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
2167
2168         webkitpy: Print abbreviated baseline search path that includes only folders that exist
2169         https://bugs.webkit.org/show_bug.cgi?id=193352
2170         <rdar://problem/47210736>
2171
2172         Reviewed by Lucas Forschler.
2173
2174         * Scripts/webkitpy/layout_tests/views/printing.py:
2175         (Printer.print_config): Print list on only baseline search paths which exist. 
2176         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
2177         (Testprinter.test_print_config):
2178
2179 2019-01-11  Joseph Pecoraro  <pecoraro@apple.com>
2180
2181         Cleanup possible WK*Copy/Create leaks in WebKitTestRunner
2182         https://bugs.webkit.org/show_bug.cgi?id=193340
2183
2184         Reviewed by David Kilzer.
2185
2186         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2187         (WTR::InjectedBundle::didReceiveMessageToPage):
2188         Pull the strings out into a WKRetainPtr.
2189
2190         * WebKitTestRunner/WebNotificationProvider.cpp:
2191         (WTR::WebNotificationProvider::closeWebNotification):
2192         Adopt the created value into the WKRetainPtr.
2193
2194         * WebKitTestRunner/mac/TestControllerMac.mm:
2195         (WTR::generateWhitelist):
2196         Immediately adopt a created value to avoid potential mistakes.
2197
2198 2019-01-11  Dominik Infuehr  <dinfuehr@igalia.com>
2199
2200         Enable DFG on ARM/Linux again
2201         https://bugs.webkit.org/show_bug.cgi?id=192496
2202
2203         Reviewed by Yusuke Suzuki.
2204
2205         After changing the bytecode format DFG was disabled on all 32-bit
2206         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
2207         on ARM by default.
2208
2209         * Scripts/run-jsc-stress-tests:
2210
2211 2019-01-11  Timothy Hatcher  <timothy@apple.com>
2212
2213         Unreviewed, fix #ifdef in API test added in r239851.
2214         https://bugs.webkit.org/show_bug.cgi?id=193327
2215         rdar://problem/47093222
2216
2217         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm:
2218
2219 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2220
2221         Introduce IDL files for runtime-enabled UndoManager and UndoItem JavaScript API
2222         https://bugs.webkit.org/show_bug.cgi?id=193109
2223         <rdar://problem/44807048>
2224
2225         Reviewed by Ryosuke Niwa.
2226
2227         Introduce and respect a test option to enable the UndoManager API.
2228
2229         * WebKitTestRunner/TestController.cpp:
2230         (WTR::updateTestOptionsFromTestHeader):
2231         * WebKitTestRunner/TestOptions.h:
2232         (WTR::TestOptions::hasSameInitializationOptions const):
2233         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2234         (WTR::TestController::platformCreateWebView):
2235
2236 2019-01-11  Zalan Bujtas  <zalan@apple.com>
2237
2238         [LFC][BFC][MarginCollapsing] Adjust vertical position when box margin collapses through.
2239         https://bugs.webkit.org/show_bug.cgi?id=193346
2240
2241         Reviewed by Antti Koivisto.
2242
2243         * LayoutReloaded/misc/LFC-passing-tests.txt:
2244
2245 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
2246
2247         Unreviewed, fix typo that breaks dashboard link.
2248
2249         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2250         (WebKitBuildbot):
2251
2252 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
2253
2254         Update macOS queue configurations
2255         https://bugs.webkit.org/show_bug.cgi?id=193329
2256
2257         Reviewed by Alexey Proskuryakov.
2258
2259         * BuildSlaveSupport/build.webkit.org-config/config.json:
2260         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2261         (BubbleQueueServer):
2262         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2263         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2264         (WebKitBuildbot):
2265         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2266         (table.queue-grid tr.platform.macos-sierra img.logo): Deleted.
2267         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2268
2269 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
2270
2271         MiniBrowser should be able to navigate to about:blank
2272         https://bugs.webkit.org/show_bug.cgi?id=193345
2273
2274         Reviewed by Simon Fraser.
2275
2276         * MiniBrowser/mac/BrowserWindowController.m:
2277         (-[BrowserWindowController addProtocolIfNecessary:]):
2278         Don't prepend "http://" to "about:" prefixed URLs like "about:blank".
2279
2280         * MiniBrowser/mac/WK1BrowserWindowController.m:
2281         (-[WK1BrowserWindowController fetch:]):
2282         * MiniBrowser/mac/WK2BrowserWindowController.m:
2283         (-[WK2BrowserWindowController fetch:]):
2284         Clean up the code that uses this to match style.
2285
2286 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
2287
2288         Remove MiniBrowser custom "Process Swap" menu item which does not work
2289         https://bugs.webkit.org/show_bug.cgi?id=193344
2290
2291         Reviewed by Simon Fraser.
2292
2293         There is a menu item under the Experimental menu that does work.
2294
2295         * MiniBrowser/mac/AppDelegate.m:
2296         (defaultConfiguration):
2297         * MiniBrowser/mac/SettingsController.h:
2298         * MiniBrowser/mac/SettingsController.m:
2299         (-[SettingsController _populateMenu]):
2300         (-[SettingsController validateMenuItem:]):
2301         (-[SettingsController processSwapOnNavigationEnabled]): Deleted.
2302         (-[SettingsController toggleProcessSwapOnNavigation:]): Deleted.
2303
2304 2019-01-10  Timothy Hatcher  <timothy@apple.com>
2305
2306         Add WKBundlePage SPI to temporarily force light or dark appearance on a page.
2307         https://bugs.webkit.org/show_bug.cgi?id=193327
2308         rdar://problem/47093222
2309
2310         Reviewed by Tim Horton.
2311
2312         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2313         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm: Added.
2314         (TestWebKitAPI::didFinishNavigation):
2315         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
2316         (TestWebKitAPI::TEST):
2317         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm: Added.
2318         (TestWebKitAPI::ForceLightAppearanceInBundleTest::ForceLightAppearanceInBundleTest):
2319         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didCreatePage):
2320         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didReceiveMessage):
2321         * TestWebKitAPI/Tests/WebKit/mac/dark-mode.html: Added.
2322
2323 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
2324
2325         Leak of WKWebProcessPlugInHitTestResult (160 bytes) in com.apple.WebKit.WebContent running layout tests
2326         https://bugs.webkit.org/show_bug.cgi?id=193338
2327         <rdar://problem/46664774>
2328
2329         Reviewed by David Kilzer.
2330
2331         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2332         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
2333
2334 2019-01-10  Commit Queue  <commit-queue@webkit.org>
2335
2336         Unreviewed, rolling out r239825.
2337         https://bugs.webkit.org/show_bug.cgi?id=193330
2338
2339         Broke tests on armv7/linux bots (Requested by guijemont on
2340         #webkit).
2341
2342         Reverted changeset:
2343
2344         "Enable DFG on ARM/Linux again"
2345         https://bugs.webkit.org/show_bug.cgi?id=192496
2346         https://trac.webkit.org/changeset/239825
2347
2348 2019-01-10  Zhifei Fang  <zhifei_fang@apple.com>
2349
2350         Disable the run-jsc-stress-test remote host key check.
2351         https://bugs.webkit.org/show_bug.cgi?id=192988
2352
2353         Reviewed by Alexey Proskuryakov.
2354
2355         * Scripts/run-jsc-stress-tests:
2356
2357 2019-01-10  John Wilander  <wilander@apple.com>
2358
2359         Override the session configuration for cookieAcceptPolicy
2360         https://bugs.webkit.org/show_bug.cgi?id=190925
2361         <rdar://problem/45497382>
2362
2363         Reviewed by Alexey Proskuryakov and Alex Christensen.
2364
2365         Test infrastructure for setting a first-party-only cookie policy.
2366
2367         * DumpRenderTree/TestRunner.cpp:
2368         (setOnlyAcceptFirstPartyCookiesCallback):
2369         (TestRunner::staticFunctions):
2370         * DumpRenderTree/TestRunner.h:
2371         * DumpRenderTree/mac/TestRunnerMac.mm:
2372         (TestRunner::setOnlyAcceptFirstPartyCookies):
2373         * DumpRenderTree/win/TestRunnerWin.cpp:
2374         (TestRunner::setOnlyAcceptFirstPartyCookies):
2375         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2376         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2377         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
2378         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2379         * WebKitTestRunner/TestInvocation.cpp:
2380         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2381
2382 2019-01-09  Matt Rajca  <mrajca@apple.com>
2383
2384         Put per-document autoplay behavior behind runtime website policies quirk instead of a compile time flag
2385         https://bugs.webkit.org/show_bug.cgi?id=193301
2386
2387         Reviewed by Jer Noble.
2388         
2389         Added API tests.
2390
2391         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2392         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2393         (TEST):
2394         * TestWebKitAPI/Tests/WebKitCocoa/autoplaying-multiple-media-elements.html: Added.
2395
2396 2019-01-10  Zalan Bujtas  <zalan@apple.com>
2397
2398         [LFC][BFC][MarginCollapsing] Take collapsed through siblings into account when computing vertical position
2399         https://bugs.webkit.org/show_bug.cgi?id=193310
2400
2401         Reviewed by Antti Koivisto.
2402
2403         * LayoutReloaded/misc/LFC-passing-tests.txt:
2404
2405 2019-01-10  Dominik Infuehr  <dinfuehr@igalia.com>
2406
2407         Enable DFG on ARM/Linux again
2408         https://bugs.webkit.org/show_bug.cgi?id=192496
2409
2410         Reviewed by Yusuke Suzuki.
2411
2412         After changing the bytecode format DFG was disabled on all 32-bit
2413         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
2414         on ARM by default.
2415
2416         * Scripts/run-jsc-stress-tests:
2417
2418 2019-01-09  Fujii Hironori  <Hironori.Fujii@sony.com>
2419
2420         [Win][MiniBrowser] wchar_t strings shouldn't be treated as BSTR
2421         https://bugs.webkit.org/show_bug.cgi?id=193271
2422
2423         Reviewed by Brent Fulgham.
2424
2425         BSTR is a special data structure created by SysAllocString, not a
2426         wchar_t null-terminated string.
2427
2428         * DumpRenderTree/win/TestRunnerWin.cpp:
2429         (TestRunner::setDatabaseQuota): Use L"" instead of "" for _bstr_t.
2430         * MiniBrowser/win/MiniBrowserWebHost.cpp:
2431         (MiniBrowserWebHost::didFinishLoadForFrame): Use _bstr_t to create
2432         BSTR from wide string literals.
2433
2434 2019-01-09  Alexey Proskuryakov  <ap@apple.com>
2435
2436         Tweak wording for build/version_check style checker error
2437         https://bugs.webkit.org/show_bug.cgi?id=193256
2438
2439         Reviewed by Tim Horton.
2440
2441         * Scripts/webkitpy/style/checkers/cpp.py:
2442         (check_os_version_checks):
2443         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2444         (WebKitStyleTest.test_os_version_checks):
2445
2446 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
2447
2448         [ews-build] Add link to bug along with bug title
2449         https://bugs.webkit.org/show_bug.cgi?id=193293
2450
2451         Reviewed by Lucas Forschler.
2452
2453         * BuildSlaveSupport/ews-build/steps.py:
2454         (ValidatePatch._is_bug_closed): Fetch bug title from Bugzilla and add it to the build.
2455         (ConfigureBuild.add_bug_id_url): Deleted.
2456         (ConfigureBuild.getBugURL): Deleted.
2457
2458 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
2459
2460         [ews-build] Use https for ews-build server
2461         https://bugs.webkit.org/show_bug.cgi?id=193193
2462
2463         Reviewed by Lucas Forschler.
2464
2465         * BuildSlaveSupport/ews-build/steps.py:
2466
2467 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
2468
2469         [ews-build] Parse and display number of style failures
2470         https://bugs.webkit.org/show_bug.cgi?id=193280
2471
2472         Reviewed by Lucas Forschler.
2473
2474         * BuildSlaveSupport/ews-build/steps.py:
2475         (CheckStyle): Use TestWithFailureCount as base class.
2476         (CheckStyle.countFailures): Count the number of style failures.
2477
2478 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
2479
2480         [ews-build] use patch_id instead of ewspatchid
2481         https://bugs.webkit.org/show_bug.cgi?id=193235
2482
2483         Reviewed by Lucas Forschler.
2484
2485         * BuildSlaveSupport/ews-build/factories.py: Replaced ewspatchid with patch_id.
2486         * BuildSlaveSupport/ews-build/steps.py: Ditto.
2487         * BuildSlaveSupport/ews-build/steps_unittest.py: Ditto.
2488
2489 2019-01-09  Zalan Bujtas  <zalan@apple.com>
2490
2491         [LFC][BFC][MarginCollapsing] Add support for peculiar cases.
2492         https://bugs.webkit.org/show_bug.cgi?id=192625
2493
2494         Reviewed by Antti Koivisto.
2495
2496         * LayoutReloaded/misc/LFC-passing-tests.txt:
2497
2498 2019-01-09  Michael Catanzaro  <mcatanzaro@igalia.com>
2499
2500         [WPE][GTK] Purge use of g_assert() under TestWebKitAPI
2501         https://bugs.webkit.org/show_bug.cgi?id=192841
2502
2503         Reviewed by Carlos Garcia Campos.
2504
2505         There are separate g_assert_*() macros for use in tests, which we use inconsistently
2506         currently. Use them always. We'll get nicer error messages now when tests fail, and the
2507         assertions will now run during tests even if G_DISABLE_ASSERT is used when building.
2508
2509         Note that the documentation of g_assert() says that it is not to be used when writing tests.
2510
2511         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2512         * TestWebKitAPI/Tests/WebKitGLib/EditorTest.cpp:
2513         (WebKitWebEditorTest::testSelectionChanged):
2514         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
2515         (WebKitFrameTest::testMainFrame):
2516         (WebKitFrameTest::testURI):
2517         (WebKitFrameTest::testJavaScriptContext):
2518         (WebKitFrameTest::testJavaScriptValues):
2519         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
2520         (testWebViewAuthenticationRequest):
2521         (testWebViewAuthenticationLoadCancelled):
2522         (testWebViewAuthenticationFailure):
2523         (testWebViewAuthenticationStorage):
2524         (ProxyAuthenticationTest::ProxyAuthenticationTest):
2525         (testWebViewAuthenticationProxy):
2526         (testWebViewAuthenticationProxyHTTPS):
2527         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
2528         (testAutomationSessionRequestSession):
2529         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp:
2530         (testBackForwardListNavigation):
2531         (testWebKitWebViewSessionState):
2532         (testWebKitWebViewSessionStateWithFormData):
2533         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
2534         (ConsoleMessageTest::consoleMessageReceivedCallback):
2535         (testWebKitConsoleMessageConsoleAPI):
2536         (testWebKitConsoleMessageJavaScriptException):
2537         (testWebKitConsoleMessageNetworkError):
2538         (testWebKitConsoleMessageSecurityError):
2539         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
2540         (testCookieManagerAcceptPolicy):
2541         (testCookieManagerCookiesChanged):
2542         (testCookieManagerPersistentStorage):
2543         (testCookieManagerPersistentStorageDeleteAll):
2544         (testCookieManagerEphemeral):
2545         * TestWebKitAPI/Tests/WebKitGLib/TestDOMElement.cpp:
2546         (testWebKitDOMElementAutoFill):
2547         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
2548         (downloadLocalFileSuccessfully):
2549         (createFileAtDestination):
2550         (testDownloadOverwriteDestinationDisallowed):
2551         (testDownloadLocalFileError):
2552         (testDownloadRemoteFile):
2553         (testDownloadRemoteFileError):
2554         (testWebViewDownloadURI):
2555         (testPolicyResponseDownload):
2556         (testPolicyResponseDownloadCancel):
2557         (testDownloadMIMEType):
2558         (contextMenuCallback):
2559         (testContextMenuDownloadActions):
2560         (testBlobDownload):
2561         * TestWebKitAPI/Tests/WebKitGLib/TestEditor.cpp:
2562         (testWebKitWebEditorSelectionChanged):
2563         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
2564         (testWebKitFrameMainFrame):
2565         (testWebKitFrameURI):
2566         (testWebKitFrameJavaScriptContext):
2567         (testWebKitFrameJavaScriptValues):
2568         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2569         (LoadStopTrackingTest::loadFailed):
2570         (testWebViewTitle):
2571         (testURIRequestHTTPHeaders):
2572         (testURIRequestHTTPMethod):
2573         (testURIResponseHTTPHeaders):
2574         (testRedirectToDataURI):
2575         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
2576         (testProcessPerWebView):
2577         (testWebProcessLimit):
2578         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
2579         (testWebViewResources):
2580         (testWebResourceLoading):
2581         (testWebResourceSuggestedFilename):
2582         (testWebResourceGetData):
2583         (testWebResourceGetDataError):
2584         (testWebViewResourcesHistoryCache):
2585         (testWebResourceSendRequest):
2586         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
2587         (testSSL):
2588         (testInsecureContent):
2589         (testTLSErrorsPolicy):
2590         (testTLSErrorsRedirect):
2591         (testTLSErrorsHTTPAuth):
2592         (testLoadFailedWithTLSErrors):
2593         (testSubresourceLoadFailedWithTLSErrors):
2594         (httpsServerCallback):
2595         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2596         (testWebViewCreateNavigationData):
2597         (testWebViewJavaScriptDialogs):
2598         (testWebViewWindowProperties):
2599         (testWebViewMouseTarget):
2600         (testWebViewFileChooserRequest):
2601         (testWebViewColorChooserRequest):
2602         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
2603         (testWebExtensionGetTitle):
2604         (testDocumentLoadedSignal):
2605         (testWebKitWebViewProcessCrashed):
2606         (testWebExtensionWindowObjectCleared):
2607         (testWebExtensionIsolatedWorld):
2608         (permissionRequestCallback):
2609         (didAssociateFormControlsCallback):
2610         (testWebExtensionFormControlsAssociated):
2611         (FormSubmissionTest::FormSubmissionTest):
2612         (FormSubmissionTest::testFormSubmissionResult):
2613         (testWebExtensionFormSubmissionSteps):
2614         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
2615         (testNotInitialized):
2616         (testClearDatabase):
2617         (testPrivateBrowsing):
2618         (testGetFavicon):
2619         (testWebViewFavicon):
2620         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp:
2621         (testFindControllerTextFound):
2622         (testFindControllerTextNotFound):
2623         (testFindControllerMatchCount):
2624         (testFindControllerMaxMatchCount):
2625         (testFindControllerNext):
2626         (testFindControllerPrevious):
2627         (testFindControllerCountedMatches):
2628         (testFindControllerOptions):
2629         (testFindControllerHide):
2630         (testFindControllerInstance):
2631         (testFindControllerGetters):
2632         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitPolicyClient.cpp:
2633         (testNavigationPolicy):
2634         (testResponsePolicy):
2635         (testNewWindowPolicy):
2636         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp:
2637         (testSecurityOriginBasicConstructor):
2638         (testSecurityOriginURIConstructor):
2639         (testSecurityOriginDefaultPort):
2640         (testSecurityOriginFileURI):
2641         (testOpaqueSecurityOrigin):
2642         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2643         (testWebKitSettings):
2644         (testWebKitSettingsNewWithSettings):
2645         (testWebKitSettingsUserAgent):
2646         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
2647         (testWebViewNewWithUserContentManager):
2648         (isStyleSheetInjectedForURLAtPath):
2649         (isScriptInjectedForURLAtPath):
2650         (testUserContentManagerInjectedStyleSheet):
2651         (testUserContentManagerInjectedScript):
2652         (UserScriptMessageTest::scriptMessageReceived):
2653         (UserScriptMessageTest::waitUntilMessageReceived):
2654         (UserScriptMessageTest::runJavaScriptFinished):
2655         (testUserContentManagerScriptMessageReceived):
2656         (testUserContentManagerScriptMessageInWorldReceived):
2657         (testUserContentManagerScriptMessageFromDOMBindings):
2658         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
2659         (testWebContextDefault):
2660         (testWebContextEphemeral):
2661         (testWebContextGetPlugins):
2662         (testWebContextURIScheme):
2663         (testWebContextSpellChecker):
2664         (testWebContextLanguages):
2665         (consoleMessageReceivedCallback):
2666         (testWebContextSecurityFileXHR):
2667         (ProxyTest::ProxyTest):
2668         (testWebContextProxySettings):
2669         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
2670         (testWebViewWebContext):
2671         (testWebViewWebBackend):
2672         (testWebViewEphemeral):
2673         (testWebViewCustomCharset):
2674         (testWebViewSettings):
2675         (testWebViewRunJavaScript):
2676         (testWebViewCanShowMIMEType):
2677         (testWebViewSubmitForm):
2678         (testWebViewSave):
2679         (testWebViewPageVisibility):
2680         (testWebViewSnapshot):
2681         (testWebViewNotification):
2682         (testWebViewNotificationInitialPermissionAllowed):
2683         (testWebViewNotificationInitialPermissionDisallowed):
2684         (testWebViewIsPlayingAudio):
2685         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
2686         (WebsiteDataTest::WebsiteDataTest):
2687         (WebsiteDataTest::remove):
2688         (WebsiteDataTest::clear):
2689         (testWebsiteDataConfiguration):
2690         (testWebsiteDataEphemeral):
2691         (testWebsiteDataCache):
2692         (testWebsiteDataStorage):
2693         (testWebsiteDataDatabases):
2694         (testWebsiteDataAppcache):
2695         (testWebsiteDataCookies):
2696         (testWebsiteDataDeviceIdHashSalt):
2697         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
2698         (emitDocumentLoaded):
2699         (emitURIChanged):
2700         (sendRequestCallback):
2701         (contextMenuCallback):
2702         (consoleMessageSentCallback):
2703         (emitFormControlsAssociated):
2704         (formControlsAssociatedCallback):
2705         (emitFormSubmissionEvent):
2706         (willSubmitFormCallback):
2707         (windowObjectCleared):
2708         (methodCallCallback):
2709         (registerGResource):
2710         (webkit_web_extension_initialize_with_user_data):
2711         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.cpp:
2712         (checkLeaks):
2713         (WebProcessTest::create):
2714         (runTest):
2715         * TestWebKitAPI/Tests/WebKitGtk/AutocleanupsTest.cpp:
2716         (AutocleanupsTest::testWebProcessAutocleanups):
2717         * TestWebKitAPI/Tests/WebKitGtk/DOMClientRectTest.cpp:
2718         (WebKitDOMClientRectTest::testDivBoundingClientRectPosition):
2719         (WebKitDOMClientRectTest::testDivClientRectsPositionAndLength):
2720         * TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp:
2721         (WebKitDOMDOMWindowTest::testSignals):
2722         (WebKitDOMDOMWindowTest::testDispatchEvent):
2723         (WebKitDOMDOMWindowTest::testGetComputedStyle):
2724         * TestWebKitAPI/Tests/WebKitGtk/DOMNodeFilterTest.cpp:
2725         (WebKitDOMNodeFilterTest::testTreeWalker):
2726         (WebKitDOMNodeFilterTest::testNodeIterator):
2727         * TestWebKitAPI/Tests/WebKitGtk/DOMNodeTest.cpp:
2728         (WebKitDOMNodeTest::testHierarchyNavigation):
2729         (WebKitDOMNodeTest::testInsertion):
2730         (WebKitDOMNodeTest::testTagNamesNodeList):
2731         (WebKitDOMNodeTest::testTagNamesHTMLCollection):
2732         (WebKitDOMNodeTest::testDOMCache):
2733         * TestWebKitAPI/Tests/WebKitGtk/DOMXPathNSResolverTest.cpp:
2734         (WebKitDOMXPathNSResolverTest::evaluateFooChildTextAndCheckResult):
2735         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
2736         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
2737         * TestWebKitAPI/Tests/WebKitGtk/TestAutocleanups.cpp:
2738         (testUIProcessAutocleanups):
2739         (testWebProcessAutocleanups):
2740         * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
2741         (testContextMenuPopulateMenu):
2742         (testContextMenuDismissed):
2743         * TestWebKitAPI/Tests/WebKitGtk/TestDOMClientRect.cpp:
2744         (testWebKitDOMClientRectDivBoundingClientRectPosition):
2745         (testWebKitDOMClientRectDivClientRectsPositionAndLength):
2746         * TestWebKitAPI/Tests/WebKitGtk/TestDOMDOMWindow.cpp:
2747         (testWebKitDOMDOMWindowSignals):
2748         (testWebKitDOMDOMWindowDispatchEvent):
2749         (testWebKitDOMDOMWindowGetComputedStyle):
2750         * TestWebKitAPI/Tests/WebKitGtk/TestDOMNode.cpp:
2751         (testWebKitDOMNodeHierarchyNavigation):
2752         (testWebKitDOMNodeInsertion):
2753         (testWebKitDOMNodeTagNamesNodeList):
2754         (testWebKitDOMNodeTagNamesHTMLCollection):
2755         (testWebKitDOMObjectCache):
2756         * TestWebKitAPI/Tests/WebKitGtk/TestDOMNodeFilter.cpp:
2757         (testWebKitDOMNodeFilterTreeWalker):
2758         (testWebKitDOMNodeFilterNodeIterator):
2759         * TestWebKitAPI/Tests/WebKitGtk/TestDOMXPathNSResolver.cpp:
2760         (testWebKitDOMXPathNSResolverNative):
2761         (testWebKitDOMXPathNSResolverCustom):
2762         * TestWebKitAPI/Tests/WebKitGtk/TestInspector.cpp:
2763         (testInspectorDefault):
2764         (testInspectorManualAttachDetach):
2765         (testInspectorCustomContainerDestroyed):
2766         * TestWebKitAPI/Tests/WebKitGtk/TestInspectorServer.cpp:
2767         (startTestServer):
2768         (testInspectorServerPageList):
2769         * TestWebKitAPI/Tests/WebKitGtk/TestOptionMenu.cpp:
2770         (OptionMenuTest::showOptionMenuCallback):
2771         (OptionMenuTest::menuCloseCallback):
2772         (OptionMenuTest::close):
2773         (OptionMenuTest::activateItem):
2774         (OptionMenuTest::selectItem):
2775         (testOptionMenuSimple):
2776         (testOptionMenuGroups):
2777         (testOptionMenuActivate):
2778         (testOptionMenuSelect):
2779         * TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp:
2780         (testPrintOperationPrintSettings):
2781         (webViewPrintCallback):
2782         (testPrintOperationPrint):
2783         (testPrintCustomWidget):
2784         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
2785         (checkAtspiAccessible):
2786         (testAtspiBasicHierarchy):
2787         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitVersion.cpp:
2788         (testWebKitCheckVersion):
2789         * TestWebKitAPI/Tests/WebKitGtk/TestWebViewEditor.cpp:
2790         (testWebViewEditorCutCopyPasteNonEditable):
2791         (testWebViewEditorCutCopyPasteEditable):
2792         (testWebViewEditorSelectAllNonEditable):
2793         (testWebViewEditorSelectAllEditable):
2794         (loadContentsAndTryToCutSelection):
2795         (testWebViewEditorNonEditable):
2796         (testWebViewEditorEditable):
2797         (testWebViewEditorEditorStateTypingAttributes):
2798         (testWebViewEditorInsertImage):
2799         (testWebViewEditorCreateLink):
2800         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
2801         (loadChangedCallback):
2802         (loadFailedCallback):
2803         (loadFailedWithTLSErrorsCallback):
2804         (LoadTrackingTest::LoadTrackingTest):
2805         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
2806         (registerGResource):
2807         (removeNonEmptyDirectory):
2808         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2809         (Test::adoptView):
2810         (Test::~Test):
2811         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
2812         (WebKitTestBus::getOrCreateConnection):
2813         (WebKitTestBus::createProxy):
2814         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp:
2815         (WebKitTestServer::getWebSocketURIForPath const):
2816         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
2817         (WebViewTest::initializeWebView):
2818         (WebViewTest::loadURI):
2819         (WebViewTest::loadHtml):
2820         (WebViewTest::loadPlainText):
2821         (WebViewTest::loadBytes):
2822         (WebViewTest::loadRequest):
2823         (WebViewTest::loadAlternateHTML):
2824         (WebViewTest::goBack):
2825         (WebViewTest::goForward):
2826         (WebViewTest::goToBackForwardListItem):
2827         (resourceGetDataCallback):
2828         (WebViewTest::mainResourceData):
2829         (WebViewTest::javascriptResultToCString):
2830         (WebViewTest::javascriptResultToNumber):
2831         (WebViewTest::javascriptResultToBoolean):
2832         (WebViewTest::javascriptResultIsNull):
2833         (WebViewTest::javascriptResultIsUndefined):
2834         (onSnapshotReady):
2835         (WebViewTest::runWebProcessTest):
2836         * TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp:
2837         (WebViewTest::platformInitializeWebView):
2838         (WebViewTest::showInWindow):
2839         (WebViewTest::showInWindowAndWaitUntilMapped):
2840         (WebViewTest::mouseMoveTo):
2841         (WebViewTest::emitPopupMenuSignal):
2842         (WebViewTest::keyStroke):
2843         (WebViewTest::doMouseButtonEvent):
2844
2845 2019-01-09  Philippe Normand  <pnormand@igalia.com>
2846
2847         [WPE] API tests can't run in flatpak environment
2848         https://bugs.webkit.org/show_bug.cgi?id=193242
2849
2850         Reviewed by Michael Catanzaro.
2851
2852         * Scripts/run-wpe-tests: Add --wpe to arguments passed to
2853         flatpakutils so that it knows which port it's dealing with.
2854         * glib/common.py: Remove build_dir globals so that subsequent
2855         calls actually take args into account.
2856         (library_build_path):
2857         (binary_build_path):
2858
2859 2019-01-08  Dean Jackson  <dino@apple.com>
2860
2861         Blob references for System Previews don't get a correct file extension
2862         https://bugs.webkit.org/show_bug.cgi?id=193268
2863         <rdar://problem/47133037>
2864
2865         Reviewed by Tim Horton.
2866
2867         New test that a Blob download of a USDZ file gets named correctly.
2868
2869         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2870         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2871         (-[BlobWithUSDZExtensionDownloadDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2872         (-[BlobWithUSDZExtensionDownloadDelegate _downloadDidFinish:]):
2873         (TEST):
2874         * TestWebKitAPI/Tests/WebKitCocoa/SystemPreviewBlobNaming.html: Added.
2875
2876 2019-01-08  Jiewen Tan  <jiewen_tan@apple.com>
2877
2878         [WebAuthN] Support U2F HID Authenticators on macOS
2879         https://bugs.webkit.org/show_bug.cgi?id=191535
2880         <rdar://problem/47102027>
2881
2882         Reviewed by Brent Fulgham.
2883
2884         This patch:
2885         1) adds support for U2F mocking mechanism;
2886         2) updates tests to reflect U2fCommandConstructor changes.
2887
2888         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp:
2889         (TestWebKitAPI::TEST):
2890         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2891         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2892         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
2893
2894 2019-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
2895
2896         [iOS] Dispatch a synthetic mousedown event prior to starting drags
2897         https://bugs.webkit.org/show_bug.cgi?id=193229
2898         <rdar://problem/46717097>
2899
2900         Reviewed by Tim Horton.
2901
2902         Add a cross-platform drag and drop test to verify that calling `preventDefault()` on the mousedown event
2903         prevents a drag from starting.
2904
2905         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
2906         * TestWebKitAPI/Tests/WebKitCocoa/link-and-target-div.html:
2907
2908         Tweak this test to make it robust when dragging the link to the target element multiple times in a single test.
2909
2910 2019-01-08  Zhifei Fang  <zhifei_fang@apple.com>
2911   
2912         Layout test will generate a perf metric file to results dir.
2913         https://bugs.webkit.org/show_bug.cgi?id=192030
2914         <rdar://problem/32779516>
2915
2916         Reviewed by Aakash Jain.
2917
2918         Layout test running time will be collected to a perf metric file.
2919         For now, instead of outputing running time of all tests (which is huge),
2920         we aggregate them by test directories which are at most two level deep. 
2921
2922         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2923         (Manager._end_test_run):
2924         (Manager._output_perf_metrics):
2925         (Manager._print_expectation_line_for_test):
2926         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2927         (add_test_perf_metric):
2928         (test_perf_metrics):
2929         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2930         (JSONGeneratorTest.test_test_timings_trie):
2931         (JSONGeneratorTest):
2932         (JSONGeneratorTest.test_test_perf_metrics):
2933         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2934         (RebaselineTest.test_reset_results):
2935         (RebaselineTest.test_missing_results):
2936         (RebaselineTest.test_new_baseline):
2937
2938 2019-01-08  Patrick Griffis  <pgriffis@igalia.com>
2939
2940         [WPE][GTK] Add php-json to install-dependencies
2941         https://bugs.webkit.org/show_bug.cgi?id=193233
2942
2943         Reviewed by Michael Catanzaro.
2944
2945         * gtk/install-dependencies:
2946         * wpe/install-dependencies:
2947
2948 2019-01-08  Chris Dumez  <cdumez@apple.com>
2949
2950         Regression(PSON-r239182): Blank view when navigating back and forth between google.com and stack overflow
2951         https://bugs.webkit.org/show_bug.cgi?id=193224
2952         <rdar://problem/47097726>
2953
2954         Reviewed by Alex Christensen.
2955
2956         Add API test coverage.
2957
2958         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2959
2960 2019-01-07  David Kilzer  <ddkilzer@apple.com>
2961
2962         Leak of ScrollCompletionCallbackData (16 bytes) in com.apple.WebKit.WebContent running WebKit layout tests
2963         <https://webkit.org/b/193222>
2964         <rdar://problem/46862309>
2965
2966         Reviewed by Joseph Pecoraro.
2967
2968         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2969         (WTR::executeCallback): Fix camel case of variable name.
2970         (WTR::EventSendingController::callAfterScrollingCompletes): If
2971         WKBundlePageRegisterScrollOperationCompletionCallback() returns
2972         false, make sure to release the ScrollCompletionCallbackData
2973         object.  This fixes the leak.
2974
2975 2019-01-07  Fujii Hironori  <Hironori.Fujii@sony.com>
2976
2977         [Win] EWS: wincairo-ews cannot apply a patch with *.png
2978         https://bugs.webkit.org/show_bug.cgi?id=193044
2979
2980         Reviewed by Daniel Bates.
2981
2982         WinCairo EWS bots are using Windows Perl. Binary files should be
2983         opened as binary mode.
2984
2985         * Scripts/svn-apply:
2986         (handleGitBinaryChange): Use 'binmode' for binary file handles.
2987
2988 2019-01-07  Don Olmstead  <don.olmstead@sony.com>
2989
2990         [CMake] Add ENABLE_CSS_TYPED_OM option
2991         https://bugs.webkit.org/show_bug.cgi?id=193216
2992
2993         Reviewed by Michael Catanzaro.
2994
2995         * Scripts/webkitperl/FeatureList.pm:
2996
2997 2019-01-07  David Kilzer  <ddkilzer@apple.com>
2998
2999         Prefer RetainPtr<NSObject> to RetainPtr<NSObject *>
3000         <https://webkit.org/b/193056>
3001
3002         Reviewed by Alex Christensen.
3003
3004         * Scripts/webkitpy/style/checker.py:
3005         - Ignore use of new runtime/retainptr check in
3006           Tools/TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm since it
3007           contains tests to ensure RetainPtr<NSObject *> is compatible
3008           with RetainPtr<NSObject>.
3009
3010         * Scripts/webkitpy/style/checkers/cpp.py:
3011         (check_language):
3012         (CppChecker):
3013         - Add checker for use of '*' in RetainPtr<> type.  A for loop
3014           was used instead of a single regex so that angle brackets
3015           could be matched up when checking the type contained within
3016           the RetainPtr<> type.
3017
3018         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3019         (CppStyleTest):
3020         - Add unit test for new runtime/retainptr check.
3021
3022         * TestRunnerShared/EventSerialization/mac/EventSerializerMac.h:
3023         * TestWebKitAPI/EditingTestHarness.h:
3024         - Remove '*' from RetainPtr<> type.
3025
3026         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3027         - Add cf/RetainPtr.cpp back to TestWTFLibrary target!  This
3028           regressed in r201938.
3029
3030         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
3031         (TestWebKitAPI::TEST):
3032         - Update tests to match RetainPtr.mm tests (except for the
3033           `*SimilarNSType` tests since there is no CF equivalent of
3034           RetainPtr<NSString> and RetainPtr<NSString *>).
3035
3036         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
3037         (TestWebKitAPI::TEST):
3038         - Update tests to:
3039           - Not conflict by name with equivalent CF tests in
3040             RetainPtr.cpp.
3041           - Add test cases for RetainPtr<NSObject>,
3042             RetainPtr<NSObject *> and RetainPtr<id> were appropriate.
3043           - Add `*SimilarNSType` tests for converting between
3044             RetainPtr<NSObject> and RetainPtr<NSObject *>.
3045           - Change `0` to `nil` as appropriate.
3046           - Re-alphabetize the tests by name.
3047           - Add Optional<RetainPtr<>> tests.
3048           - Add retainPtr() tests.
3049
3050         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
3051         (-[DownloadProgressTestRunner _download:decideDestinationWithSuggestedFilename:completionHandler:]):
3052         * TestWebKitAPI/Tests/WebKitCocoa/IconLoadingDelegate.mm:
3053         (TEST):
3054         - Remove '*' from RetainPtr<> type.
3055
3056         * TestWebKitAPI/Tests/WebKitCocoa/JITEnabled.mm:
3057         (TEST(WebKit, JITEnabled)):
3058         - Add missing WTFMove().  Apparently a temporary was being
3059           created before in the argument list due to mismatched
3060           RetainPtr<> types.
3061
3062         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3063         * TestWebKitAPI/Tests/WebKitCocoa/VideoControlsManager.mm:
3064         (TestWebKitAPI::setUpWebViewForTestingVideoControlsManager):
3065         (TestWebKitAPI::TEST):
3066         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3067         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
3068         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
3069         (WTR::resourcesDirectoryURL):
3070         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
3071         (WTR::InjectedBundle::platformInitialize):
3072         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3073         - Remove '*' from RetainPtr<> type.
3074
3075 2019-01-07  Eric Carlson  <eric.carlson@apple.com>
3076
3077         A MediaTime timescale must never be zero
3078         https://bugs.webkit.org/show_bug.cgi?id=193156
3079         <rdar://problem/32504501>
3080
3081         Reviewed by Jer Noble.
3082
3083         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
3084         (TestWebKitAPI::TEST): Add tests for zero timescale.
3085
3086 2019-01-07  Youenn Fablet  <youenn@apple.com>
3087
3088         API test broken: TestWebKitAPI.WebKit.CustomDataStorePathsVersusCompletionHandlers
3089         https://bugs.webkit.org/show_bug.cgi?id=193175
3090
3091         Reviewed by Chris Dumez.
3092
3093         Updated API test as we bumped the SW schema to version 4.
3094
3095         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3096         * TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-4.sqlite3: Renamed from Tools/TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-3.sqlite3.
3097         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3098         (TEST):
3099
3100 2019-01-06  Fujii Hironori  <Hironori.Fujii@sony.com>
3101
3102         [Win][Clang] Fix compilation warnings of MiniBrowser
3103         https://bugs.webkit.org/show_bug.cgi?id=193029
3104
3105         Reviewed by Ross Kirsling.
3106
3107         * MiniBrowser/win/MiniBrowserWebHost.h: Removed unused m_oldFont
3108         and m_URLBarFont. Reorder member variables to fix -Wreorder
3109         warning.
3110         * MiniBrowser/win/PageLoadTestClient.cpp:
3111         (PageLoadTestClient::PageLoadTestClient): Reorder the member initializer list.
3112         * MiniBrowser/win/PageLoadTestClient.h: Removed 'virtual' of
3113         pageLoadStartedAtTime and pageLoadEndedAtTime. Removed unused
3114         m_currentURLIndex.
3115         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3116         (WebKitBrowserWindow::WebKitBrowserWindow): Initialize
3117         navigationClient with '{ }' to fix the missing field warning.
3118         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
3119         (initDocStruct): Changed the argument type docname to const.
3120
3121 2019-01-06  Jiewen Tan  <jiewen_tan@apple.com>
3122
3123         [WebAuthN] Import U2F command/response converters from Chromium
3124         https://bugs.webkit.org/show_bug.cgi?id=193150
3125         <rdar://problem/47054028>
3126
3127         Reviewed by Brent Fulgham.
3128
3129         Adds API tests.
3130
3131         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3132         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp:
3133         (TestWebKitAPI::getTestAttestedCredentialDataBytes):
3134         (TestWebKitAPI::getTestAuthenticatorDataBytes):
3135         (TestWebKitAPI::getTestAttestationObjectBytes):
3136         (TestWebKitAPI::getTestSignResponse):
3137         (TestWebKitAPI::getTestU2fRegisterResponse):
3138         (TestWebKitAPI::TEST):
3139         (TestWebKitAPI::convertToVector): Deleted.
3140         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
3141         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp: Added.
3142         (TestWebKitAPI::constructMakeCredentialRequest):
3143         (TestWebKitAPI::constructGetAssertionRequest):
3144         (TestWebKitAPI::TEST):
3145
3146 2019-01-05  Oriol Brufau  <obrufau@igalia.com>
3147
3148         [GTK] Add python3-setuptools, libunistring-dev, bison and flex dependencies
3149         https://bugs.webkit.org/show_bug.cgi?id=193136
3150
3151         Reviewed by Michael Catanzaro.
3152
3153         * gtk/install-dependencies:
3154         Add python3-setuptools, libunistring-dev, bison and flex to install-dependencies,
3155         they are needed by update-webkitgtk-libs.
3156
3157 2019-01-05  Aakash Jain  <aakash_jain@apple.com>
3158
3159         Unreviewed follow-up fix to r239650
3160         https://bugs.webkit.org/show_bug.cgi?id=193140
3161         <rdar://problem/47063037>
3162
3163         Typecast patch_id to string.
3164
3165         * BuildSlaveSupport/ews-build/steps.py:
3166         (ValidatePatch._is_patch_obsolete):
3167
3168 2019-01-04  Daniel Bates  <dabates@apple.com>
3169
3170         [lldb-webkit]: Add support for pretty-printing raw bitmask types
3171         https://bugs.webkit.org/show_bug.cgi?id=193024
3172
3173         Reviewed by Jer Noble.
3174
3175         Add support infrastructure to pretty-print a raw bitmask type. Included is a pretty-printer
3176         for the bitmask type WebEventFlags as an example.
3177
3178         Exposed a new function lldb_webkit.addSummaryAndSyntheticFormattersForRawBitmaskType()
3179         that can be used to register summary and synthetic child formatters for a bitmask type.
3180         For example, consider the following enum and bitmask typedefs:
3181
3182         typedef enum {
3183             A = 1 << 0,
3184             B = 1 << 1,
3185             C = 1 << 2,
3186         } SpecialFlagValues;
3187         typedef unsigned SpecialFlags;
3188
3189         To teach lldb-webkit how to pretty print SpecialFlags types, add the following code inside
3190         __lldb_init_module():
3191
3192             addSummaryAndSyntheticFormattersForRawBitmaskType(debugger, "SpecialFlags", {
3193                     1 << 0: "A",
3194                     1 << 1: "B",
3195                     1 << 2: "C",
3196             })
3197
3198         * lldb/lldb_webkit.py:
3199         (addSummaryAndSyntheticFormattersForRawBitmaskType):
3200         (addSummaryAndSyntheticFormattersForRawBitmaskType.GeneratedRawBitmaskProvider):
3201         (addSummaryAndSyntheticFormattersForRawBitmaskType.raw_bitmask_summary_provider):
3202         (addSummaryAndSyntheticFormattersForRawBitmaskType.lldb_webkit):
3203         A convenience function to dynamically creaste a synthetic formatter class and summary
3204         string function for the specified bitmask type and enumerator value to name map. This
3205         function register the dynamically created class and function with LLDB.
3206
3207         (__lldb_init_module):
3208         (FlagEnumerationProvider):
3209         (FlagEnumerationProvider._enumerator_value_to_name_map):
3210         (FlagEnumerationProvider._bitmask):
3211         (FlagEnumerationProvider._update):
3212         (FlagEnumerationProvider.has_children):
3213         (FlagEnumerationProvider.num_children):
3214         (FlagEnumerationProvider.get_child_index):
3215         (FlagEnumerationProvider.get_child_at_index):
3216         (FlagEnumerationProvider.update):
3217         Extract out provider logic from WTFOptionSetProvider into a base class that can be shared.
3218
3219         (WTFOptionSetProvider):
3220         (WTFOptionSetProvider._enumerator_value_to_name_map):
3221         (WTFOptionSetProvider._bitmask):
3222         (WTFOptionSetProvider._update):
3223         Write in terms of the base class.
3224
3225         (RawBitmaskProviderBase):
3226         (RawBitmaskProviderBase._enumerator_value_to_name_map):
3227         (RawBitmaskProviderBase._bitmask):
3228         Added. Base synthetic formatter class for a raw bitmask type. Derived classes are expected to
3229         override the class variable ENUMERATOR_VALUE_TO_NAME_MAP with a dictionary of the form:
3230         {
3231             1 << 0: "A",
3232             1 << 1: "B",
3233             1 << 2: "C",
3234         }
3235         It is not necessary to instantiate such a derived class directory. Instead use the convenience
3236         function addSummaryAndSyntheticFormattersForRawBitmaskType.
3237
3238         (WTFOptionSetProvider.has_children): Deleted.
3239         (WTFOptionSetProvider.num_children): Deleted.
3240         (WTFOptionSetProvider.get_child_index): Deleted.
3241         (WTFOptionSetProvider.get_child_at_index): Deleted.
3242         (WTFOptionSetProvider.update): Deleted.
3243
3244 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
3245
3246         [ews-build] Add build step to validate the patch before processing it
3247         https://bugs.webkit.org/show_bug.cgi?id=193140
3248
3249         Reviewed by Lucas Forschler.
3250
3251         * BuildSlaveSupport/ews-build/factories.py:
3252         (Factory.__init__): Added ValidatePatch step.
3253         * BuildSlaveSupport/ews-build/steps.py:
3254         (ValidatePatch):
3255         (ValidatePatch.fetch_data_from_url): Fetch data from a url.
3256         (ValidatePatch.get_patch_json): Get patch json data.
3257         (ValidatePatch.get_bug_json): Get bug json data.
3258         (ValidatePatch.get_bug_id_from_patch): Get bug id from a patch id.
3259         (ValidatePatch._is_patch_obsolete): Check if the patch is obsolete.
3260         (ValidatePatch._is_patch_review_denied): Check if the patch is marked r-.
3261         (ValidatePatch._is_bug_closed): Check if the bug is already closed.
3262         (ValidatePatch.skip_build): Skip the build.
3263         (ValidatePatch.start):
3264
3265 2019-01-04  Alex Christensen  <achristensen@webkit.org>
3266
3267         Progress towards fixing Mac CMake build
3268         https://bugs.webkit.org/show_bug.cgi?id=193105
3269
3270         Reviewed by Don Olmstead.
3271
3272         * TestWebKitAPI/PlatformMac.cmake:
3273
3274 2019-01-04  Alex Christensen  <achristensen@webkit.org>
3275
3276         Fix API test after r239631
3277         https://bugs.webkit.org/show_bug.cgi?id=193118
3278
3279         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3280         (TestWebKitAPI::TEST):
3281         This test relied on m_maximumProcessCount being set to 1 in ProcessPoolConfiguration::createWithLegacyOptions.
3282         Do the same thing via the API to fix the test.
3283
3284 2019-01-04  Jer Noble  <jer.noble@apple.com>
3285
3286         [WebKitLegacy] Media playback pauses on scroll
3287         https://bugs.webkit.org/show_bug.cgi?id=192829
3288
3289         Reviewed by Eric Carlson.
3290
3291         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3292         * TestWebKitAPI/Tests/WebKitCocoa/StopSuspendResumeAllMedia.mm: Added.
3293         (TestWebKitAPI::TEST):
3294         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm: Added.
3295         (-[ScrollingDoesNotPauseMediaDelegate webViewDidFinishLoad:]):
3296         (-[ScrollingDoesNotPauseMediaDelegate uiWebView:didCommitLoadForFrame:]):
3297         (-[ScrollingDoesNotPauseMediaDelegate handleEvent:]):
3298         (TestWebKitAPI::TEST):
3299
3300 2019-01-04  Chris Dumez  <cdumez@apple.com>
3301
3302         Add support for toggling device orientation API support per site
3303         https://bugs.webkit.org/show_bug.cgi?id=193143
3304         <rdar://problem/46605724>
3305
3306         Reviewed by Alex Christensen.
3307
3308         Add API test coverage.
3309
3310         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3311         (-[DataMappingSchemeHandler setTaskHandler:]):
3312         (-[DataMappingSchemeHandler webView:startURLSchemeTask:]):
3313         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationEventEnabled:]):
3314         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3315         (-[WebsitePoliciesDeviceOrientationDelegate webView:didFinishNavigation:]):
3316
3317 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
3318
3319         [ews-build] use svn-apply script to apply the patches
3320         https://bugs.webkit.org/show_bug.cgi?id=193138
3321
3322         Reviewed by Lucas Forschler.
3323
3324         * BuildSlaveSupport/ews-build/factories.py:
3325         (Factory.__init__): Add the ApplyPatch step.
3326         * BuildSlaveSupport/ews-build/steps.py:
3327         (CheckOutSource): Added step name.
3328         (CheckOutSource.__init__): Used alwaysUseLatest so that it doesn't apply patch.
3329         (ApplyPatch): Build step to apply patch using svn-apply script.
3330         (UnApplyPatchIfRequired):
3331         (UnApplyPatchIfRequired.__init__): Deleted, since the alwaysUseLatest parameter is now in base class.
3332
3333 2019-01-04  Alex Christensen  <achristensen@webkit.org>
3334
3335         Deprecate WKContextCreate
3336         https://bugs.webkit.org/show_bug.cgi?id=193118
3337
3338         Reviewed by Brady Eidson.
3339
3340         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3341         (WebKitBrowserWindow::WebKitBrowserWindow):
3342         * TestWebKitAPI/Tests/WebKit/AboutBlankLoad.cpp:
3343         (TestWebKitAPI::TEST):
3344         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
3345         (TestWebKitAPI::TEST):
3346         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
3347         (TestWebKitAPI::TEST):
3348         * TestWebKitAPI/Tests/WebKit/CookieManager.cpp:
3349         (TestWebKitAPI::TEST):
3350         * TestWebKitAPI/Tests/WebKit/DownloadDecideDestinationCrash.cpp:
3351         (TestWebKitAPI::TEST):
3352         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
3353         (TestWebKitAPI::TEST):
3354         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
3355         (TestWebKitAPI::TEST):
3356         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
3357         (TestWebKitAPI::TEST):
3358         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
3359         (TestWebKitAPI::TEST):
3360         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
3361         (TestWebKitAPI::TEST):
3362         * TestWebKitAPI/Tests/WebKit/Find.cpp:
3363         (TestWebKitAPI::TEST):
3364         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
3365         (TestWebKitAPI::TEST):
3366         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
3367         (TestWebKitAPI::TEST):
3368         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
3369         (TestWebKitAPI::TEST):
3370         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
3371         (TestWebKitAPI::TEST):
3372         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
3373         (TestWebKitAPI::TEST):
3374         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
3375         (TestWebKitAPI::TEST):
3376         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
3377         (TestWebKitAPI::TEST):
3378         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
3379         (TestWebKitAPI::loadAlternateHTMLString):
3380         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
3381         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
3382         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
3383         (TestWebKitAPI::buildAndPerformTest):
3384         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
3385         (TestWebKitAPI::TEST):
3386         * TestWebKitAPI/Tests/WebKit/NavigationClientDefaultCrypto.cpp:
3387         (TestWebKitAPI::TEST):
3388         * TestWebKitAPI/Tests/WebKit/PageGroup.cpp:
3389         (TestWebKitAPI::TEST):
3390         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
3391         (TestWebKitAPI::TEST):
3392         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
3393         (TestWebKitAPI::TEST):
3394         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
3395         (TestWebKitAPI::TEST):
3396         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
3397         (TestWebKitAPI::TEST):
3398         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
3399         (TestWebKitAPI::TEST):
3400         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
3401         (TestWebKitAPI::TEST):
3402         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
3403         (TestWebKitAPI::TEST):
3404         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
3405         (TestWebKitAPI::TEST):
3406         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
3407         (TestWebKitAPI::TEST):
3408         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
3409         (TestWebKitAPI::TEST):
3410         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
3411         (TestWebKitAPI::TEST):
3412         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
3413         (TestWebKitAPI::TEST):
3414         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
3415         (TestWebKitAPI::TEST):
3416         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
3417         (TestWebKitAPI::TEST):
3418         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3419         (TestWebKitAPI::TEST):
3420         * TestWebKitAPI/Tests/WebKit/WKPageConfiguration.cpp:
3421         (TestWebKitAPI::TEST):
3422         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
3423         (TestWebKitAPI::TEST):
3424         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
3425         (TestWebKitAPI::TEST):
3426         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
3427         (TestWebKitAPI::TEST):
3428         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
3429         (TestWebKitAPI::TEST):
3430         * TestWebKitAPI/Tests/WebKit/WebCoreStatisticsWithNoWebProcess.cpp:
3431         (TestWebKitAPI::TEST):
3432         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
3433         (TestWebKitAPI::TEST):
3434         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
3435         (TestWebKitAPI::TEST):
3436         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
3437         (WebKit2_CommandBackForwardTestWKView::SetUp):
3438         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
3439         (TestWebKitAPI::TEST):
3440         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
3441         (TestWebKitAPI::TEST):
3442         * TestWebKitAPI/Tests/WebKitCocoa/SchemeRegistry.mm:
3443         (TestWebKitAPI::TEST):
3444         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
3445         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
3446
3447 2019-01-03  Matt Rajca  <mrajca@apple.com>
3448
3449         Make DidPlayMediaPreventedFromPlaying autoplay event more generic.
3450         https://bugs.webkit.org/show_bug.cgi?id=193128
3451         rdar://34554231
3452
3453         Reviewed by Jer Noble.
3454
3455         Today, the "DidPlayMediaPreventedFromPlaying" autoplay event is only sent for
3456         media prevented from autoplaying. It could be generalized to a "DidPlayMediaWithUserGesture"
3457         event along with a flag that indicates whether or not autoplay was actually prevented.
3458
3459         Tests: existing API tests were updated to reflect the new names. New API tests
3460         were added for the new case in which the "DidPlayMediaWithUserGesture" event is sent.
3461
3462         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3463         * TestWebKitAPI/Tests/WebKit/long-test.mp4: Added.
3464         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3465         (TEST):
3466         * TestWebKitAPI/Tests/WebKitCocoa/audio-with-play-button.html: Added.
3467         * TestWebKitAPI/Tests/WebKitCocoa/video-with-play-button.html: Added.
3468
3469 2019-01-04  Chris Dumez  <cdumez@apple.com>
3470
3471         [PSON] Calling history.back() from inside the load event handler prevents process-swapping
3472         https://bugs.webkit.org/show_bug.cgi?id=193120
3473
3474         Reviewed by Alex Christensen.
3475
3476         Add API test coverage.
3477
3478         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3479
3480 2019-01-04  Chris Dumez  <cdumez@apple.com>
3481
3482         Crash under WebProcessPool::addSuspendedPage()
3483         https://bugs.webkit.org/show_bug.cgi?id=193110
3484
3485         Reviewed by Youenn Fablet.
3486
3487         Add API test coverage.
3488
3489         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3490
3491 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
3492
3493         [ews-build] Check patch relevance before applying the patch
3494         https://bugs.webkit.org/show_bug.cgi?id=193102
3495
3496         Reviewed by Lucas Forschler.
3497
3498         * BuildSlaveSupport/ews-build/factories.py:
3499         (Factory.__init__): Moved CheckPatchRelevance step to base class.
3500
3501 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
3502
3503         [ews-build] Check patch relevance step should print patch id
3504         https://bugs.webkit.org/show_bug.cgi?id=193137
3505
3506         Reviewed by Lucas Forschler.
3507
3508         * BuildSlaveSupport/ews-build/steps.py:
3509         (CheckPatchRelevance.start): Update the status to include patch id.
3510
3511 2019-01-04  Jonathan Bedard  <jbedard@apple.com>
3512
3513         webkitpy: Increase simulator teardown timeout
3514         https://bugs.webkit.org/show_bug.cgi?id=193141
3515         <rdar://problem/46174217>
3516
3517         Rubber-stamped by Aakash Jain.
3518
3519         * Scripts/webkitpy/xcode/simulated_device.py:
3520         (SimulatedDeviceManager.tear_down): Use SIMULATOR_BOOT_TIMEOUT.
3521
3522 2019-01-03  Ross Kirsling  <ross.kirsling@sony.com>
3523
3524         test262-runner misbehaves when test file YAML has a trailing space
3525         https://bugs.webkit.org/show_bug.cgi?id=193053
3526
3527         Reviewed by Yusuke Suzuki.
3528
3529         * Scripts/test262/Runner.pm:
3530         (parseData):
3531         Accept trailing space when parsing a test file's YAML block.
3532
3533 2019-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3534
3535         UserMedia test should use WKPageNavigationClient
3536         https://bugs.webkit.org/show_bug.cgi?id=192913
3537
3538         Reviewed by Youenn Fablet.
3539
3540         The test currently uses the deprecated WKPageLoaderClient. It should use
3541         WKPageNavigationClient instead, which provides the same callback under a similar name.
3542
3543         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3544         (TestWebKitAPI::TEST):
3545
3546 2019-01-02  Alex Christensen  <achristensen@webkit.org>
3547
3548         Homograph with LATIN SMALL LETTER R WITH FISHHOOK
3549         https://bugs.webkit.org/show_bug.cgi?id=192944
3550
3551         Reviewed by Tim Horton.
3552
3553         * TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
3554         (TestWebKitAPI::TEST):
3555
3556 2019-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
3557
3558         Add support for using the current text selection as the find string on iOS
3559         https://bugs.webkit.org/show_bug.cgi?id=193034
3560         <rdar://problem/45138739>
3561
3562         Reviewed by Tim Horton.
3563
3564         Add a new API test to verify that the new WebKit SPI (_stringForFind, _takeFindStringFromSelection:, and
3565         _setStringForFind) works as expected.
3566
3567         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3568         * TestWebKitAPI/Tests/WebKitCocoa/UseSelectionAsFindString.mm: Added.
3569
3570 2019-01-02  Aakash Jain  <aakash_jain@apple.com>
3571
3572         [ews-build] Use git on OpenSource EWS bots
3573         https://bugs.webkit.org/show_bug.cgi?id=193092
3574
3575         Reviewed by Lucas Forschler.
3576
3577         * BuildSlaveSupport/ews-build/steps.py:
3578         (CheckOutSource): Use git instead of svn.
3579         (CheckOutSource.__init__): Use timeout of 2 hours since the initial checkout might take a long time.
3580
3581 2019-01-02  Daniel Bates  <dabates@apple.com>
3582
3583         [lldb-webkit] Remove broken code to print WTF::OptionSet::m_storage
3584         https://bugs.webkit.org/show_bug.cgi?id=193023
3585
3586         Reviewed by Simon Fraser.
3587
3588         The code to print WTF::OptionSet::m_storage as an item in the set never worked and does
3589         not seem meaningful to fix because WTF::OptionSet::m_storage is just the sum of the printed
3590         enumerator values. We should just remove this code.
3591
3592         * lldb/lldb_webkit.py:
3593         (WTFOptionSetProvider.has_children):
3594         (WTFOptionSetProvider.num_children):
3595         (WTFOptionSetProvider.get_child_index):
3596         (WTFOptionSetProvider.get_child_at_index):
3597
3598 2018-12-29  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
3599
3600         .ycm_extra_conf.py should handle XXXInlines.h
3601         https://bugs.webkit.org/show_bug.cgi?id=193055
3602
3603         Reviewed by Carlos Garcia Campos.
3604
3605         compile_commands.json database only records flags and options for cpp source files.
3606         So, when we open headers, this database does not have any information for that.
3607         Our .ycm_extra_conf.py alleviates this by using XXX.cpp's configuration for XXX.h.
3608         But this mitigation does not handle XXXInlines.h well since we do not have XXXInlines.cpp.
3609         This patch adds support for XXXInlines.h in .ycm_extra_conf.py. When XXXInlines.h is queried,
3610         we attempt to find XXX.cpp and use the configuration if it exists.
3611
3612         * gtk/ycm_extra_conf.py:
3613         (getImplementationFilename):
3614         (FlagsForFile):
3615
3616 2018-12-31  Carlos Garcia Campos  <cgarcia@igalia.com>
3617
3618         Unreviewed. Support PHP 7.3 in Debian.
3619
3620         Add 7.3 to the list of php versions supported in Debian.
3621
3622         * Scripts/webkitpy/port/base.py:
3623         (Port._debian_php_version):
3624
3625 2018-12-27  Alex Christensen  <achristensen@webkit.org>
3626
3627         Resurrect Mac CMake build
3628         https://bugs.webkit.org/show_bug.cgi?id=192658
3629
3630         Reviewed by Yusuke Suzuki.
3631
3632         * DumpRenderTree/PlatformMac.cmake:
3633         * MiniBrowser/mac/CMakeLists.txt:
3634         * TestWebKitAPI/PlatformMac.cmake:
3635
3636 2018-12-26  Adrian Perez de Castro  <aperez@igalia.com>
3637
3638         [Tools] Remove references to Bison and Flex