df124897524f05e4be1f603016574ce03f73d707
[WebKit-https.git] / Tools / ChangeLog
1 2017-04-25  Zan Dobersek  <zdobersek@igalia.com>
2
3         Unreviewed follow-up to r215739.
4
5         * gtk/patches/libgcrypt-use-only-dev-urandom-for-testing.patch: Add the missing
6         libgcrypt patch that enforces the use of /dev/urandom.
7
8 2017-04-25  Zan Dobersek  <zdobersek@igalia.com>
9
10         [GTK] Add libgpg-error, libgcrypt libraries to JHBuild
11         https://bugs.webkit.org/show_bug.cgi?id=171270
12
13         Reviewed by Michael Catanzaro.
14
15         * gtk/jhbuild.modules: Add the latest stable versions of libgpg-error and libgcrypt
16         libraries to the webkitgtk-testing-dependencies metamodule. This will help people
17         that use systems that don't yet provide libgcrypt >= 1.7.0.
18
19 2017-04-25  Carlos Alberto Lopez Perez  <clopez@igalia.com>
20
21         [GTK] Improve an unit test for the JHBuild wrapper.
22         https://bugs.webkit.org/show_bug.cgi?id=168036
23
24         Unreviewed follow-up patch after r215727
25
26         * Scripts/webkitpy/port/base_unittest.py:
27         (test_jhbuild_wrapper): Improve the unit test by ensuring the directory
28         wasn't there before calling MockFileSystem.maybe_make_directory(), and
29         also that it exists after calling it.
30
31 2017-04-25  Carlos Alberto Lopez Perez  <clopez@igalia.com>
32
33         [GTK] ImageDiff should be run by jhbuild-wrapper in case of using jhbuild
34         https://bugs.webkit.org/show_bug.cgi?id=168036
35
36         Reviewed by Michael Catanzaro.
37
38         Call ImageDiff with the JHBuild wrapper if we should use it.
39         Also add some unit tests for the JHBuild wrapper feature.
40
41         * Scripts/webkitpy/port/base.py:
42         (Port._should_use_jhbuild): Use self._filesystem instead of os.path to allow mock testing.
43         * Scripts/webkitpy/port/base_unittest.py:
44         (test_jhbuild_wrapper): Add a test for port._should_use_jhbuild()
45         * Scripts/webkitpy/port/image_diff.py:
46         (ImageDiffer._start): The actual fix, use the wrapper if we should.
47         * Scripts/webkitpy/port/image_diff_unittest.py: Removed. This two tests are now integrated in port_testcase
48         * Scripts/webkitpy/port/port_testcase.py:
49         (PortTestCase):
50         (PortTestCase.test_diff_image): Test the command with wrapper and without it.
51         (PortTestCase.test_diff_image_passed): Moved from image_diff_unittest.py
52         (PortTestCase.test_diff_image_failed): Moved from image_diff_unittest.py
53
54 2017-04-25  Wenson Hsieh  <wenson_hsieh@apple.com>
55
56         Support reading NSURL titles from the pasteboard when performing data interaction
57         https://bugs.webkit.org/show_bug.cgi?id=171156
58         <rdar://problem/31356937>
59
60         Reviewed by Tim Horton.
61
62         Adds a new unit test, DataInteractionTests.ExternalSourceTitledNSURL.
63
64         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
65         (TestWebKitAPI::TEST):
66
67 2017-04-24  Wenson Hsieh  <wenson_hsieh@apple.com>
68
69         Respect fidelity order when reading web content from item providers
70         https://bugs.webkit.org/show_bug.cgi?id=171155
71         <rdar://problem/31356937>
72
73         Reviewed by Tim Horton.
74
75         Adds a new unit test (DataInteractionTests.RespectsExternalSourceFidelityRankings). See WebCore ChangeLog for
76         more details.
77
78         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
79         (TestWebKitAPI::TEST):
80
81 2017-04-24  Carlos Alberto Lopez Perez  <clopez@igalia.com>
82
83         SyntaxError fix after r215702.
84         https://bugs.webkit.org/show_bug.cgi?id=168944
85
86         Unreviewed "build" fix.
87
88         * BuildSlaveSupport/built-product-archive:
89         (archiveBuiltProduct):
90
91 2017-04-24  Jonathan Bedard  <jbedard@apple.com>
92
93         Package ImageDiff built with host SDK
94         https://bugs.webkit.org/show_bug.cgi?id=168944
95         <rdar://problem/30745642>
96
97         Reviewed by David Kilzer.
98
99         iOS Simulator and iOS device should archive the ImageDiff built for the host
100         machine.
101
102         * BuildSlaveSupport/built-product-archive:
103         (determineWebKitBuildDirectories): Add _hostBuildDirectory for iOS.
104         (archiveBuiltProduct): Archive Mac products for iOS so that ImageDiff is included.
105
106 2017-04-24  Keith Miller  <keith_miller@apple.com>
107
108         ThreadMessage API tests failing on release bots
109         https://bugs.webkit.org/show_bug.cgi?id=171246
110
111         Reviewed by Saam Barati.
112
113         Need to make sure that C++ doesn't optimize away our spin loop.
114
115         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
116         (runThreadMessageTest):
117         (TEST):
118
119 2017-04-24  Alex Christensen  <achristensen@webkit.org>
120
121         Reduce copies and allocations in SharedBuffer::append
122         https://bugs.webkit.org/show_bug.cgi?id=170956
123
124         Reviewed by Andreas Kling.
125
126         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm:
127         (TestWebKitAPI::TEST_F):
128
129 2017-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
130
131         [GTK] Switch to use ENABLE_REMOTE_INSPECTOR instead of ENABLE_INSPECTOR_SERVER for the remote inspector
132         https://bugs.webkit.org/show_bug.cgi?id=166680
133
134         Reviewed by Michael Catanzaro.
135
136         Update remote inspector unit tests.
137
138         * TestWebKitAPI/Tests/WebKit2Gtk/InspectorTestServer.cpp:
139         (main):
140         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
141         (connectToInspectorServer):
142         (waitUntilInspectorServerIsReady):
143         (startTestServer):
144         (testInspectorServerPageList):
145         (beforeAll):
146
147 2017-04-23  Youenn Fablet  <youenn@apple.com>
148
149         Add a tool to update expected.txt files from EWS bot results
150         https://bugs.webkit.org/show_bug.cgi?id=169538
151
152         Reviewed by Ryosuke Niwa.
153
154         This script updates expected-txt files from bugzilla posted EWS results.
155         It uses mac-wk2 as the generic baseline and adds platform-specific results if other ports
156         have results different from the generic baseline.
157
158         * Scripts/update-test-expectations-from-bugzilla: Added.
159         * Scripts/webkitpy/common/net/bugzilla/test_expectation_updater.py: Added.
160         * Scripts/webkitpy/common/net/bugzilla/test_expectation_updater_unittest.py: Added.
161         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py: Adding helper routines.
162
163 2017-04-22  Youenn Fablet  <youenn@apple.com>
164
165         Add an option to import tip-of-tree WPT tests
166         https://bugs.webkit.org/show_bug.cgi?id=171152
167
168         Reviewed by Joseph Pecoraro.
169
170         Adding a '-t' option to import tip of tree WPT tests.
171         Updating importer based on the fact that csswg-test is no longer a thing. 
172
173         * Scripts/webkitpy/w3c/test_downloader.py:
174         (TestDownloader.download_tests):
175         * Scripts/webkitpy/w3c/test_importer.py:
176         (configure_logging):
177         (TestImporter.do_import):
178         (TestImporter.write_import_log):
179
180 2017-04-22  Wenson Hsieh  <wenson_hsieh@apple.com>
181
182         File inputs only accept UTI types that can be inserted into contenteditable areas when dropping
183         https://bugs.webkit.org/show_bug.cgi?id=171177
184         <rdar://problem/31765379>
185
186         Reviewed by Andy Estes.
187
188         Tests uploading a JSON file to a file input.
189
190         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
191         (TestWebKitAPI::TEST):
192
193 2017-04-21  Wenson Hsieh  <wenson_hsieh@apple.com>
194
195         Support writing link titles to the pasteboard when beginning data interaction on a link
196         https://bugs.webkit.org/show_bug.cgi?id=171154
197         <rdar://problem/31356937>
198
199         Reviewed by Andy Estes.
200
201         Augments an existing unit test, DataInteractionTests.LinkToInput, to also check that the fetching the NSURL from
202         the source UIItemProvider generated by performing data interaction results in an NSURL with the _title attribute
203         matching the title of the link.
204
205         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
206         (TestWebKitAPI::TEST):
207
208 2017-04-21  Michael Catanzaro  <mcatanzaro@igalia.com>
209
210         Unreviewed, rolling out r215608.
211
212         Hundreds of test failures on GTK bot
213
214         Reverted changeset:
215
216         "Reduce copies and allocations in SharedBuffer::append"
217         https://bugs.webkit.org/show_bug.cgi?id=170956
218         http://trac.webkit.org/changeset/215608
219
220 2017-04-21  Wenson Hsieh  <wenson_hsieh@apple.com>
221
222         [WK2] Add delegate hooks for overriding unhanded data interaction operations
223         https://bugs.webkit.org/show_bug.cgi?id=171005
224         <rdar://problem/31669646>
225
226         Reviewed by Tim Horton.
227
228         Adds a new API test checking that normal WebKit behavior when vending updated data interaction operations may
229         be overridden, resulting in a data interaction operation being performed when it otherwise would not have. Also
230         adjusts for some changes in WebKit2 (See WebKit2 ChangeLog for more details).
231
232         New API test:
233         DataInteractionTests.OverrideDataInteractionOperation
234
235         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
236         (-[UIItemProvider registerDataRepresentationForTypeIdentifier:withData:]):
237         (TestWebKitAPI::TEST):
238         * TestWebKitAPI/ios/DataInteractionSimulator.h:
239         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
240         (-[DataInteractionSimulator initWithWebView:]):
241         (-[DataInteractionSimulator dealloc]):
242         (-[DataInteractionSimulator _webView:dataInteractionOperationWasHandled:forSession:itemProviders:]):
243         (-[DataInteractionSimulator _webView:willUpdateDataInteractionOperationToOperation:forSession:]):
244         (-[DataInteractionSimulator webViewDidPerformDataInteractionControllerOperation:]): Deleted.
245
246 2017-04-21  Ryan Haddad  <ryanhaddad@apple.com>
247
248         Temporarily disable two flaky API tests.
249
250         Unreviewed test gardening.
251
252         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm:
253         (TEST):
254         * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm:
255         (TEST):
256
257 2017-04-21  Keith Miller  <keith_miller@apple.com>
258
259         Unreviewed, rolling out r215634.
260
261         underlying build issues should have been fixed
262
263         Reverted changeset:
264
265         "Unreviewed, rolling out r215620 and r215623."
266         https://bugs.webkit.org/show_bug.cgi?id=171139
267         http://trac.webkit.org/changeset/215634
268
269 2017-04-21  Aakash Jain  <aakash_jain@apple.com>
270
271         Bubbles on dashboard doesn't turn red for test262 failures
272         https://bugs.webkit.org/show_bug.cgi?id=171129
273
274         Reviewed by Alexey Proskuryakov.
275
276         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Added test262-test.
277
278 2017-04-21  Commit Queue  <commit-queue@webkit.org>
279
280         Unreviewed, rolling out r215620 and r215623.
281         https://bugs.webkit.org/show_bug.cgi?id=171139
282
283         broke arm64 build (Requested by keith_miller on #webkit).
284
285         Reverted changesets:
286
287         "Add signaling API"
288         https://bugs.webkit.org/show_bug.cgi?id=170976
289         http://trac.webkit.org/changeset/215620
290
291         "Unreviewed, fix Cloop build."
292         http://trac.webkit.org/changeset/215623
293
294 2017-04-20  Keith Miller  <keith_miller@apple.com>
295
296         Add signaling API
297         https://bugs.webkit.org/show_bug.cgi?id=170976
298
299         Reviewed by Filip Pizlo.
300
301         Add tests for ThreadMessages.
302
303         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
304         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp: Added.
305         (runThreadMessageTest):
306         (TEST):
307
308 2017-04-20  Conrad Shultz  <conrad_shultz@apple.com>
309
310         commit-log-editor should respect the git editor if one is set
311         https://bugs.webkit.org/show_bug.cgi?id=171085
312         <rdar://problem/31745506>
313
314         Reviewed by Daniel Bates.
315
316         * Scripts/commit-log-editor:
317         If Git is available, consider GIT_LOG_EDITOR and any global Git editor preference when
318         deciding which editor to present. We examine the global editor preference since that may be
319         set automatically by installers or third-party tools.
320
321 2017-04-21  Alex Christensen  <achristensen@webkit.org>
322
323         Reduce copies and allocations in SharedBuffer::append
324         https://bugs.webkit.org/show_bug.cgi?id=170956
325
326         Reviewed by Andreas Kling.
327
328         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm:
329         (TestWebKitAPI::TEST_F):
330
331 2017-04-20  Konstantin Tokarev  <annulen@yandex.ru>
332
333         [cmake] Define FORWARDING_HEADERS_DIR in WebKitFS and use it everywhere
334         https://bugs.webkit.org/show_bug.cgi?id=171071
335
336         Reviewed by Michael Catanzaro.
337
338         "${DERIVED_SOURCES_DIR}/ForwardingHeaders" path occurs very often in the
339         build system files. GTK-specifc FORWARDING_HEADERS_DIR variable should
340         be available for all ports.
341
342         * DumpRenderTree/PlatformMac.cmake:
343         * MiniBrowser/mac/CMakeLists.txt:
344         * MiniBrowser/win/CMakeLists.txt:
345         * TestWebKitAPI/PlatformJSCOnly.cmake:
346         * TestWebKitAPI/PlatformMac.cmake:
347         * TestWebKitAPI/PlatformWin.cmake:
348         * WebKitTestRunner/PlatformMac.cmake:
349
350 2017-04-20  Joseph Pecoraro  <pecoraro@apple.com>
351
352         Test262 bot does not go red with failures
353         https://bugs.webkit.org/show_bug.cgi?id=171044
354
355         Reviewed by Aakash Jain.
356
357         The piped output of run-jsc-stress-tests is different from
358         its non-piped output. Switch to parsing the correct output.
359
360         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
361         (RunTest262Tests.countFailures):
362         Just count the number of lines that start with "FAIL:".
363
364         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
365         (RunTest262TestsTest.test_no_regressions_output):
366         (test_failure_output):
367         (test_failures_output):
368         Updated tests with new sample output produced partially from bots and
369         locally. In cases of failure the return code of run-jsc-stress-tests
370         is still 0 so update the expected return code in the tests.
371
372 2017-04-20  Brady Eidson  <beidson@apple.com>
373
374         WebContent process becomes unresponsive after returning nil from async version of -webView:createWebViewWithConfiguration:...
375         <rdar://problem/31739023> and https://bugs.webkit.org/show_bug.cgi?id=171090
376
377         Reviewed by Andy Estes.
378
379         * TestWebKitAPI/Tests/WebKit2/open-and-close-window.html:
380         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
381         (resetToConsistentState):
382         (-[OpenAndCloseWindowUIDelegate webViewDidClose:]):
383         (-[OpenAndCloseWindowUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
384         (TEST):
385         (-[OpenAndCloseWindowUIDelegateAsync _webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:completionHandler:]):
386
387 2017-04-20  Wenson Hsieh  <wenson_hsieh@apple.com>
388
389         [ios-simulator] PositionInformationTests API tests are timing out
390         https://bugs.webkit.org/show_bug.cgi?id=171089
391
392         Rubber-stamped by Tim Horton.
393
394         Addresses failures observed in the new position information tests added in r215573 by only running them if the
395         DATA_INTERACTION feature flag is enabled.
396
397         * TestWebKitAPI/Tests/ios/PositionInformationTests.mm:
398
399 2017-04-20  Brady Eidson  <beidson@apple.com>
400
401         Skip WebKit2.OpenAndCloseWindowAsyncCallbackException for now.
402         https://bugs.webkit.org/show_bug.cgi?id=171083
403
404         Unreviewed.
405
406         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
407
408 2017-04-20  Brady Eidson  <beidson@apple.com>
409
410         Add CompletionHandlerCallChecker to SPI added in r215545.
411         https://bugs.webkit.org/show_bug.cgi?id=171067
412
413         Reviewed by Dan Bernstein.
414
415         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
416         (TEST):
417         (-[OpenAndCloseWindowUIDelegateAsync _webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:completionHandler:]):
418
419 2017-04-20  Wenson Hsieh  <wenson_hsieh@apple.com>
420
421         [WK2] -[WKContentView doAfterPositionInformationUpdate:atPosition:] should be robust against synchronous reentrancy
422         https://bugs.webkit.org/show_bug.cgi?id=170922
423         <rdar://problem/31634990>
424
425         Reviewed by Tim Horton.
426
427         Adds six new unit tests for retrieving interaction information at a given position in the UI process. See
428         WebKit2 ChangeLog for more details.
429
430         * TestWebKitAPI/Tests/ios/PositionInformationTests.mm:
431         (-[_WKDraggableElementInfo expectToBeLink:image:atPoint:]):
432         (TestWebKitAPI::TEST):
433         (TestWebKitAPI::expectCGPointsToBeEqual): Deleted.
434
435 2017-04-20  Xan Lopez  <xlopez@igalia.com>
436
437         [GTK][jhbuild] Update glib and glib-networking to the latest stable versions
438         https://bugs.webkit.org/show_bug.cgi?id=170942
439
440         Reviewed by Carlos Garcia Campos.
441
442         Update glib and glib-networking to the last stable releases. This
443         is needed to get working TLS certificate verification at all at
444         least in Fedora.
445
446         * gtk/install-dependencies: add libmount, needed for newer glib.
447         * gtk/jhbuild.modules: update glib and glib-networking to last
448         stable releases.
449
450 2017-04-20  Joanmarie Diggs  <jdiggs@igalia.com>
451
452         [ATK] Implement support for DPub ARIA roles
453         https://bugs.webkit.org/show_bug.cgi?id=170679
454
455         Reviewed by Chris Fleizach.
456
457         Add DPub ARIA landmark roles to roleToString().
458
459         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
460
461 2017-04-19  Joseph Pecoraro  <pecoraro@apple.com>
462
463         Remove WebKitTestRunner code for enabling features that are already enabled by default
464         https://bugs.webkit.org/show_bug.cgi?id=171033
465
466         Reviewed by Ryosuke Niwa.
467
468         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
469         (WTR::InjectedBundle::beginTesting):
470         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
471         (WTR::TestRunner::setShadowDOMEnabled): Deleted.
472         (WTR::TestRunner::setCustomElementsEnabled): Deleted.
473         (WTR::TestRunner::setFetchAPIEnabled): Deleted.
474         (WTR::TestRunner::setDownloadAttributeEnabled): Deleted.
475         * WebKitTestRunner/InjectedBundle/TestRunner.h:
476
477 2017-04-19  Youenn Fablet  <youenn@apple.com>
478
479         [Mac] Allow customizing H264 encoder
480         https://bugs.webkit.org/show_bug.cgi?id=170829
481
482         Reviewed by Alex Christensen.
483
484         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
485
486 2017-04-19  Brady Eidson  <beidson@apple.com>
487
488         Add asynchronous equivalent of -[<WKUIDelegate> webView:createWebViewWithConfiguration:...].
489         <rdar://problem/30699851> and https://bugs.webkit.org/show_bug.cgi?id=171018
490
491         Reviewed by Tim Horton.
492
493         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
494         (TEST):
495         (-[OpenAndCloseWindowUIDelegateAsync webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
496         (-[OpenAndCloseWindowUIDelegateAsync _webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:completionHandler:]):
497
498 2017-04-19  Brady Eidson  <beidson@apple.com>
499
500         REGRESSION (r213168): An extra Web Content process is spun up on launch and is never closed.
501         <rdar://problem/30774839> and https://bugs.webkit.org/show_bug.cgi?id=171002
502
503         Reviewed by Alex Christensen.
504
505         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
506         * TestWebKitAPI/Tests/WebKit2Cocoa/InitialWarmedProcessUsed.mm: Added.
507
508 2017-04-19  Brent Fulgham  <bfulgham@apple.com>
509
510         [WK2] Run tests with ResourceLoadStatistics enabled
511         https://bugs.webkit.org/show_bug.cgi?id=170952
512
513         Reviewed by Andy Estes.
514
515         Excercise the load statistics code during tests.
516
517         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
518         (WTR::initializeWebViewConfiguration):
519
520 2017-04-19  Bill Ming  <mbbill@gmail.com>
521
522         close_fds should be set to False on Windows.
523         https://bugs.webkit.org/show_bug.cgi?id=170838
524
525         Reviewed by Brent Fulgham.
526
527         * Scripts/webkitpy/common/system/executive.py:
528         (Executive._should_close_fds):
529
530 2017-04-19  David Kilzer  <ddkilzer@apple.com>
531
532         Stop using strcpy() in WebKit::EnvironmentUtilities::stripValuesEndingWithString()
533         <https://webkit.org/b/170994>
534         <rdar://problem/29889932>
535
536         Reviewed by Brent Fulgham.
537
538         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
539         (EnvironmentUtilitiesTest.cpp): Add to TestWebKitAPILibrary
540         target.
541         * TestWebKitAPI/Tests/WebKit2/EnvironmentUtilitiesTest.cpp: Add.
542         (TestWebKitAPI::strip): Helper method to set/get environment
543         variable for testing.
544         (TestWebKitAPI::WebKit2_StripValuesEndingWithString_Test): Add
545         tests.
546
547 2017-04-19  JF Bastien  <jfbastien@apple.com>
548
549         WebAssembly: add script which can import GCC torture tests
550         https://bugs.webkit.org/show_bug.cgi?id=170740
551
552         Reviewed by Saam Barati.
553
554         Add a script which can import the GCC torture tests and create a
555         yaml file to run them as part of jsc's WebAssembly regression
556         tests.
557
558         This patch doesn't commit the tests themselves because they're
559         licensed differently.
560
561         * Scripts/run-jsc-stress-tests: learn how to run
562         Emscripten-generated .js+.wasm files, and do a bit of cleanup on
563         the options because WebAssembly is enabled by default.
564         * Scripts/update-wasm-gcc-torture.py: Added.
565         (parse_args):
566         (update_lkgr):
567         (untar_torture):
568         (list_js_files):
569         (waterfall_known_failures):
570         (create_yaml):
571         (main):
572
573 2017-04-19  Youenn Fablet  <youenn@apple.com>
574
575         Import web-platform-tests/tools
576         https://bugs.webkit.org/show_bug.cgi?id=170718
577
578         Reviewed by Alex Christensen.
579
580         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
581         (main):
582         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
583         (WebPlatformTestServer.ports_to_forward):
584         (WebPlatformTestServer._prepare_config):
585         (WebPlatformTestServer._install_modules): Deleted.
586         * Scripts/webkitpy/w3c/test_importer.py:
587         (TestImporter.write_html_files_for_templated_js_tests):
588
589 2017-04-18  Wenson Hsieh  <wenson_hsieh@apple.com>
590
591         [WK2] Add infrastructure and unit tests for file uploads using data interaction
592         https://bugs.webkit.org/show_bug.cgi?id=170903
593         <rdar://problem/31314689>
594
595         Reviewed by Tim Horton.
596
597         Adds 5 new unit tests covering different cases of uploading files through data interaction, as well as
598         infrastructure for simulating UIItemProviders that load file data. Makes a few adjustments to the
599         DataInteractionSimulator along the way, detailed in the per-method annotations below. See
600         <https://bugs.webkit.org/show_bug.cgi?id=170880> for more details about the change this patch is testing.
601
602         New tests:
603         DataInteractionTests.ExternalSourceImageToFileInput
604         DataInteractionTests.ExternalSourceHTMLToUploadArea
605         DataInteractionTests.ExternalSourceImageAndHTMLToSingleFileInput
606         DataInteractionTests.ExternalSourceImageAndHTMLToMultipleFileInput
607         DataInteractionTests.ExternalSourceImageAndHTMLToUploadArea
608
609         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
610         (testIconImage):
611         (temporaryURLForDataInteractionFileLoad):
612         (cleanUpDataInteractionTemporaryPath):
613
614         Creates and tears down temporary file directories for testing data interaction.
615
616         (-[UIItemProvider registerFileRepresentationForTypeIdentifier:withData:filename:]):
617         (TestWebKitAPI::TEST):
618         * TestWebKitAPI/ios/DataInteractionSimulator.h:
619         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
620
621         Make necessary changes to be able to test what happens when data interaction ends over an element with no
622         operation. Previously, we would always simulate performing a data interaction operation when ending the
623         simulation, but this causes us to wait indefinitely for a data operation response to arrive in the UI process.
624         Instead, we need to note whether or not the content view is allowing data interaction, and only perform an
625         operation and wait for the -didPerform call if the operation was allowed. Otherwise, we immediately transition
626         the phase to Cancelled and end the run.
627
628         (-[DataInteractionSimulator _resetSimulatedState]):
629         (-[DataInteractionSimulator runFrom:to:]):
630         (-[DataInteractionSimulator _concludeDataInteractionAndPerformOperationIfNecessary]):
631         (-[DataInteractionSimulator _advanceProgress]):
632         (-[DataInteractionSimulator externalItemProviders]):
633         (-[DataInteractionSimulator setExternalItemProviders:]):
634
635         Previously, we hard-coded DataInteractionSimulator to only support a single external item provider. In order to
636         test the scenario where multiple files are being "data interacted" into a file-type input, we generalize this to
637         take multiple item providers.
638
639         (-[DataInteractionSimulator externalItemProvider]): Deleted.
640         (-[DataInteractionSimulator setExternalItemProvider:]): Deleted.
641
642 2017-04-18  John Wilander  <wilander@apple.com>
643
644         Make WebCore::topPrivatelyControlledDomain() return "localhost" for localhost
645         https://bugs.webkit.org/show_bug.cgi?id=170798
646         <rdar://problem/31595108>
647
648         Reviewed by Alex Christensen.
649
650         * TestWebKitAPI/Tests/mac/PublicSuffix.mm:
651         (TestWebKitAPI::TEST_F):
652             Added two negative test cases for WebCore::isPublicSuffix().
653             Added test cases with mixed case domains, localhost, and
654             non-ASCII for WebCore::topPrivatelyControlledDomain().
655
656 2017-04-18  Jonathan Bedard  <jbedard@apple.com>
657
658         Unreviewed, rolling out r215346 and 215361.
659
660         The problem these changes were fixing was addressed in
661         <https://trac.webkit.org/changeset/215416/webkit>.
662
663         Reverted changesets:
664
665         "webkitpy: Ignore previously launched pid when system is under
666         stress"
667         https://bugs.webkit.org/show_bug.cgi?id=170741
668         http://trac.webkit.org/changeset/215346
669         http://trac.webkit.org/changeset/215361
670
671 2017-04-17  Alex Christensen  <achristensen@webkit.org>
672
673         Allow Variants of RetainPtrs
674         https://bugs.webkit.org/show_bug.cgi?id=170923
675
676         Reviewed by Tim Horton and Sam Weinig.
677
678         * TestWebKitAPI/Tests/WTF/Variant.cpp:
679         (TestWebKitAPI::TEST):
680         Add tests for RetainPtr and for another class with overloaded operator& to verify such classes can
681         work in Variants.
682
683 2017-04-17  Brady Eidson  <beidson@apple.com>
684
685         Make WKHTTPCookieStore public.
686         <rdar://problem/31024691> and https://bugs.webkit.org/show_bug.cgi?id=170920
687
688         Reviewed by Geoffrey Garen.
689
690         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
691         (TEST):
692
693 2017-04-17  Youenn Fablet  <youenn@apple.com>
694
695         Disable outdated WritableStream API
696         https://bugs.webkit.org/show_bug.cgi?id=170749
697         <rdar://problem/31446233>
698
699         Reviewed by Alex Christensen.
700
701         Replacing READABLE_STREAM_API, READABLE_BYTE_STREAM_API and WRITABLE_STREAM_API compilation flag by:
702         - A STREAMS_API compilation flag.
703         - A ReadableByteStreamAPI and WritableStreamAPI runtime flags, turned off except for RWT and DRT.
704
705         * DumpRenderTree/mac/DumpRenderTree.mm:
706         (enableExperimentalFeatures):
707         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
708         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
709         (WTR::InjectedBundle::beginTesting):
710         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
711         (WTR::TestRunner::setFetchAPIEnabled):
712         (WTR::TestRunner::setWritableStreamAPIEnabled):
713         (WTR::TestRunner::setReadableByteStreamAPIEnabled):
714         * WebKitTestRunner/InjectedBundle/TestRunner.h:
715
716 2017-04-17  Tim Horton  <timothy_horton@apple.com>
717
718         Provide a viewport parameter to disable clipping to the safe area
719         https://bugs.webkit.org/show_bug.cgi?id=170766
720         <rdar://problem/31564634>
721
722         Reviewed by Beth Dakin.
723
724         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
725         (WTR::UIScriptController::setObscuredInsets):
726         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
727         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
728         (WTR::UIScriptController::setObscuredInsets):
729         * TestRunnerShared/UIScriptContext/UIScriptController.h:
730         * WebKitTestRunner/ios/TestControllerIOS.mm:
731         (WTR::TestController::platformResetStateToConsistentValues):
732         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
733         (WTR::UIScriptController::setObscuredInsets):
734         Add a UIScriptController mechanism to install obscured insets
735         on the web view.
736
737 2017-04-17  Dan Bernstein  <mitz@apple.com>
738
739         [Cocoa] Move isNullFunctionPointer down into WTF
740         https://bugs.webkit.org/show_bug.cgi?id=170892
741
742         Reviewed by Sam Weinig.
743
744         * TestWebKitAPI/Configurations/TestWTF.xcconfig:
745         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
746         * TestWebKitAPI/Tests/WTF/darwin/WeakLinking.cpp: Added.
747         (TestWebKitAPI::TEST):
748         * TestWebKitAPI/Tests/WTF/darwin/libTestWTFAlwaysMissing-iOS-v2.tbd: Added.
749         * TestWebKitAPI/Tests/WTF/darwin/libTestWTFAlwaysMissing-iOS.tbd: Added.
750         * TestWebKitAPI/Tests/WTF/darwin/libTestWTFAlwaysMissing-macOS-v2.tbd: Added.
751         * TestWebKitAPI/Tests/WTF/darwin/libTestWTFAlwaysMissing-macOS.tbd: Added.
752
753 2017-04-17  Jonathan Bedard  <jbedard@apple.com>
754
755         webkitpy: Correct poll when killing ServerProcess
756
757         Unreviewed infrastructure fix.
758
759         * Scripts/webkitpy/port/server_process.py:
760         (ServerProcess._kill): A polled process equaling 'None' means the process is running.
761
762 2017-04-17  Eric Carlson  <eric.carlson@apple.com>
763
764         [MediaStream] Enable getUserMedia API test
765         https://bugs.webkit.org/show_bug.cgi?id=170901
766         <rdar://problem/31656594>
767
768         Reviewed by Youenn Fablet.
769
770         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add test.
771
772         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
773         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack):
774         (TestWebKitAPI::TEST): Enable capture with mock devices.
775         * TestWebKitAPI/Tests/WebKit2/getUserMedia.html: Update to mediaDevices.getUserMedia
776
777 2017-04-17  Xan Lopez  <xan@igalia.com>
778
779         [GTK] Update the Fedora dependencies for WebKitGTK+
780         https://bugs.webkit.org/show_bug.cgi?id=170590
781
782         Reviewed by Carlos Alberto Lopez Perez.
783
784         * gtk/install-dependencies: add a bunch of modules necessary to
785         get a proper set of GStreamer codecs for WebRTC.
786
787 2017-04-16  Sam Weinig  <sam@webkit.org>
788
789         [WebIDL] Switch IDLAttributes.txt over to a more structured format so that more information can be added for each attribute
790         https://bugs.webkit.org/show_bug.cgi?id=170843
791
792         Reviewed by Chris Dumez.
793
794         * DumpRenderTree/DerivedSources.make:
795         * WebKitTestRunner/DerivedSources.make:
796         * Scripts/webkitpy/bindings/main.py:
797         (BindingsTests.generate_from_idl):
798         Pass IDLAttributes.json, as it is now mandatory to have one.
799
800 2017-04-14  Mark Lam  <mark.lam@apple.com>
801
802         Update architectures in xcconfig files.
803         https://bugs.webkit.org/show_bug.cgi?id=170867
804         <rdar://problem/31628104>
805
806         Reviewed by Joseph Pecoraro.
807
808         * DumpRenderTree/mac/Configurations/Base.xcconfig:
809         * MobileMiniBrowser/Configurations/Base.xcconfig:
810         * TestWebKitAPI/Configurations/Base.xcconfig:
811         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
812         * WebKitTestRunner/Configurations/Base.xcconfig:
813
814 2017-04-14  Brady Eidson  <beidson@apple.com>
815
816         Fix basic WKURLSchemeHandler bugs.
817         <rdar://problem/30647559> and https://bugs.webkit.org/show_bug.cgi?id=170862
818
819         Reviewed by Andy Estes.
820
821         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
822         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm: Added.
823         (-[SchemeHandler initWithData:mimeType:]):
824         (-[SchemeHandler dealloc]):
825         (-[SchemeHandler webView:startTask:]):
826         (-[SchemeHandler webView:stopTask:]):
827         (TEST):
828
829 2017-04-14  Bill Ming  <mbbill@gmail.com>
830
831         webkit-patch failed to detect git repository
832         https://bugs.webkit.org/show_bug.cgi?id=170859
833
834         Reviewed by Daniel Bates.
835
836         Windows cmd does not accept single quoted path. So, using
837         double quotes here will provide better platform compatibility.
838
839         * Scripts/VCSUtils.pm:
840         (isGitDirectory):
841         (isGitSVNDirectory):
842         (svnRevisionForDirectory):
843         (svnInfoForPath):
844
845 2017-04-14  Ryan Haddad  <ryanhaddad@apple.com>
846
847         Unreviewed, rolling out r215374.
848
849         This change causes LayoutTests to exit early with crashes on
850         Sierra.
851
852         Reverted changeset:
853
854         "webkitpy: Ignore previously launched pid when system is under
855         stress"
856         https://bugs.webkit.org/show_bug.cgi?id=170741
857         http://trac.webkit.org/changeset/215374
858
859 2017-04-14  Dan Bernstein  <mitz@apple.com>
860
861         [ios-simulator] API test WebKit2.AdditionalReadAccessAllowedURLs is failing
862         https://bugs.webkit.org/show_bug.cgi?id=170856
863
864         Disabled the newly-added test in the Simulator, which doesn’t enforce sandboxing.
865
866         * TestWebKitAPI/Tests/WebKit2Cocoa/AdditionalReadAccessAllowedURLs.mm:
867
868 2017-04-14  Jonathan Bedard  <jbedard@apple.com>
869
870         webkitpy: Ignore previously launched pid when system is under stress
871         https://bugs.webkit.org/show_bug.cgi?id=170741
872
873         Unreviewed infrastructure fix.
874
875         Drivers are destroyed between failing layout tests, which is not necessary and
876         prevents the work-around implemented in https://bugs.webkit.org/show_bug.cgi?id=170741.
877
878         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
879         (Worker._kill_driver): Do not destroy drivers when they are stopped.
880         * Scripts/webkitpy/port/driver.py:
881         (Driver.stop): Reset driver values set in initializer.
882
883 2017-04-14  Andy Estes  <aestes@apple.com>
884
885         [ios-simulator] API test WebKit2.WKWebProcessPlugInRangeHandle timing out
886         https://bugs.webkit.org/show_bug.cgi?id=167594
887
888         Re-enabled this API test now that webkit.org/b/161967 is fixed.
889
890         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm:
891         (TEST):
892
893 2017-04-14  Andy Estes  <aestes@apple.com>
894
895         [ios-simulator] API test WebKit2.DataDetectionReferenceDate timing out
896         https://bugs.webkit.org/show_bug.cgi?id=161967
897
898         Reviewed by Alexey Proskuryakov.
899
900         * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm:
901         (TEST): Re-enabled WebKit2.DataDetectionReferenceDate.
902
903 2017-04-14  Ryan Haddad  <ryanhaddad@apple.com>
904
905         Unreviewed, rolling out r215363.
906
907         This change causes LayoutTests to exit early with crashes.
908
909         Reverted changeset:
910
911         "webkitpy: Ignore previously launched pid when system is under
912         stress"
913         https://bugs.webkit.org/show_bug.cgi?id=170741
914         http://trac.webkit.org/changeset/215363
915
916 2017-04-14  Jonathan Bedard  <jbedard@apple.com>
917
918         webkitpy: Ignore previously launched pid when system is under stress
919         https://bugs.webkit.org/show_bug.cgi?id=170741
920
921         Unreviewed infrastructure fix.
922
923         Drivers are destroyed between failing layout tests, which is not necessary and
924         prevents the work-around implemented in https://bugs.webkit.org/show_bug.cgi?id=170741.
925
926         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
927         (Worker._kill_driver): Do not destroy drivers when they are stopped.
928
929 2017-04-14  Jonathan Bedard  <jbedard@apple.com>
930
931         webkitpy: Ignore previously launched pid when system is under stress
932         https://bugs.webkit.org/show_bug.cgi?id=170741
933
934         Unreviewed infrastructure fix.
935
936         Server processes are destroyed in the driver, which is not necessary and prevents
937         the work-around implemented in https://bugs.webkit.org/show_bug.cgi?id=170741.
938
939         * Scripts/webkitpy/port/driver.py:
940         (Driver.run_test): Do not destroy server process.
941         (Driver._start): Only create the server process if it is None.
942         (Driver.stop): Do not destroy server process.
943
944 2017-04-13  Dan Bernstein  <mitz@apple.com>
945
946         [Cocoa] Allow clients to specify in _WKProcessPoolConfiguration additional directory sandbox extensions
947         https://bugs.webkit.org/show_bug.cgi?id=170387
948
949         Reviewed by Sam Weinig.
950
951         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
952         * TestWebKitAPI/Tests/WebKit2Cocoa/AdditionalReadAccessAllowedURLs.mm: Added.
953         (TEST):
954         * TestWebKitAPI/Tests/WebKit2Cocoa/AdditionalReadAccessAllowedURLsPlugin.mm: Added.
955         (-[AdditionalReadAccessAllowedURLsPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
956         (-[AdditionalReadAccessAllowedURLsPlugIn dealloc]):
957         (-[AdditionalReadAccessAllowedURLsPlugIn readStringFromURL:completionHandler:]):
958         * TestWebKitAPI/Tests/WebKit2Cocoa/AdditionalReadAccessAllowedURLsProtocol.h: Added.
959
960 2017-04-13  Jonathan Bedard  <jbedard@apple.com>
961
962         webkitpy: Ignore previously launched pid when system is under stress
963         https://bugs.webkit.org/show_bug.cgi?id=170741
964
965         Reviewed by David Kilzer.
966
967         We have seen cases where xcrun simctl launch will return a pid of a previous
968         process and the process will appear to be running even though it is crashing.
969         Ensure that the PID that simulator_process is receiving is not the pid of the
970         previously run process.
971
972         * Scripts/webkitpy/port/simulator_process.py:
973         (SimulatorProcess._start): Check to make sure we aren't receiving an old PID.
974
975 2017-04-13  Jonathan Bedard  <jbedard@apple.com>
976
977         Build ImageDiff with host SDK
978         https://bugs.webkit.org/show_bug.cgi?id=168531
979
980         Reviewed by David Kilzer.
981
982         ImageDiff should be built and run with the host SDK, not the target SDK.
983         Build ImageDiff twice, once for the target SDK and once for the host
984         as an intermediate step towards building for only the host SDK.
985
986         * ImageDiff/Makefile: Added.
987         * Makefile: Add ImageDiff to list of targets.
988         * Scripts/build-imagediff: Build bmalloc and WTF for the host.
989         * Scripts/build-webkit: Build ImageDiff for host.
990         * Scripts/webkitdirs.pm: Export extractNonMacOSHostConfiguration.
991         (extractNonMacOSHostConfiguration): Remove non-host configuration data from the array.
992         * Scripts/webkitperl/webkitdirs_unittest/extractNonMacOSHostConfiguration.pl: Added.
993         * Scripts/webkitpy/port/base.py:
994         (Port.check_build): Attempt to build image diff if not found.
995         (Port.check_image_diff): Enable logging flag.
996         (Port._build_image_diff): Allow webkitpy to build image-diff during testing.
997
998 2017-04-12  Alex Christensen  <achristensen@webkit.org>
999
1000         Clean up SharedBuffer public functions
1001         https://bugs.webkit.org/show_bug.cgi?id=170795
1002
1003         Reviewed by Andreas Kling.
1004
1005         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp:
1006         (TestWebKitAPI::TEST_F):
1007
1008 2017-04-12  Dan Bernstein  <mitz@apple.com>
1009
1010         [Mac] Future-proof .xcconfig files
1011         https://bugs.webkit.org/show_bug.cgi?id=170802
1012
1013         Reviewed by Tim Horton.
1014
1015         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1016         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1017         * MiniBrowser/Configurations/Base.xcconfig:
1018         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1019         * TestWebKitAPI/Configurations/Base.xcconfig:
1020         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1021         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1022         * WebKitTestRunner/Configurations/Base.xcconfig:
1023         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1024
1025 2017-04-12  Alex Christensen  <achristensen@webkit.org>
1026
1027         Remove unused SharedBuffer::wrapCFDataArray
1028         https://bugs.webkit.org/show_bug.cgi?id=170794
1029
1030         Reviewed by Brady Eidson.
1031
1032         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm:
1033         (TestWebKitAPI::TEST_F):
1034
1035 2017-04-12  Yusuke Suzuki  <utatane.tea@gmail.com>
1036
1037         [WTF] Introduce Thread class and use RefPtr<Thread> and align Windows Threading implementation semantics to Pthread one
1038         https://bugs.webkit.org/show_bug.cgi?id=170502
1039
1040         Reviewed by Mark Lam.
1041
1042         Mechanical change. Use Thread:: APIs.
1043
1044         * DumpRenderTree/JavaScriptThreading.cpp:
1045         (runJavaScriptThread):
1046         (startJavaScriptThreads):
1047         (stopJavaScriptThreads):
1048         * DumpRenderTree/mac/DumpRenderTree.mm:
1049         (testThreadIdentifierMap):
1050         * TestWebKitAPI/Tests/WTF/Condition.cpp:
1051         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1052         (TestWebKitAPI::runLockTest):
1053         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1054
1055 2017-04-12  Alex Christensen  <achristensen@webkit.org>
1056
1057         Modernize vector adoption
1058         https://bugs.webkit.org/show_bug.cgi?id=170758
1059
1060         Reviewed by Geoffrey Garen.
1061
1062         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp:
1063         (TestWebKitAPI::TEST_F):
1064
1065 2017-04-11  Dean Jackson  <dino@apple.com>
1066
1067         Disable outdated WritableStream API
1068         https://bugs.webkit.org/show_bug.cgi?id=170749
1069         <rdar://problem/31446233>
1070
1071         Reviewed by Tim Horton.
1072
1073         The API we implement is no longer accurate. Disable it until we
1074         are compatible with the new specification
1075
1076         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1077
1078 2017-04-11  David Quesada  <david_quesada@apple.com>
1079
1080         Add SPI for handling geolocation authorization requests
1081         https://bugs.webkit.org/show_bug.cgi?id=170362
1082         rdar://problem/17508627
1083
1084         Reviewed by Alex Christensen.
1085
1086         Add API tests for the new WKUIDelegate SPI for allowing or denying websites permission
1087         to use geolocation. Adopt the new WKProcessPool._coreLocationProvider property to
1088         provide a stub object to simulate the various configurations of geolocation permissions:
1089         1. The app doesn't have permission to use geolocation.
1090         2. The app is allowed to use geolocation, but the UI delegate denies the web view permission.
1091         3. The app is allowed to use geolocation, and the UI delegate allows the web view permission.
1092
1093         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1094         * TestWebKitAPI/Tests/WebKit2Cocoa/Geolocation.mm: Added.
1095         (-[TestCoreLocationProvider setListener:]):
1096         (-[TestCoreLocationProvider requestGeolocationAuthorization]):
1097         (-[TestCoreLocationProvider start]):
1098         (-[TestCoreLocationProvider stop]):
1099         (-[TestCoreLocationProvider setEnableHighAccuracy:]):
1100         (expectException):
1101         (-[GeolocationTestUIDelegate _webView:requestGeolocationAuthorizationForURL:frame:decisionHandler:]):
1102         (-[GeolocationTestUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1103         (TestWebKitAPI::TEST):
1104         * TestWebKitAPI/Tests/WebKit2Cocoa/GeolocationGetCurrentPositionResult.html: Added.
1105
1106 2017-04-10  Matt Rajca  <mrajca@apple.com>
1107
1108         Change autoplay state to "prevented" when media is paused due to restrictions.
1109         https://bugs.webkit.org/show_bug.cgi?id=170686
1110
1111         Reviewed by Alex Christensen.
1112
1113         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1114         * TestWebKitAPI/Tests/WebKit2/autoplay-muted-with-controls.html: Added test.
1115         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1116         (TEST):
1117
1118 2017-04-11  Yusuke Suzuki  <utatane.tea@gmail.com>
1119
1120         [WebCore][JSC] ResourceUsageData.{timeOfNextEdenCollection,timeOfNextFullCollection} should be MonotonicTime
1121         https://bugs.webkit.org/show_bug.cgi?id=170725
1122
1123         Reviewed by Sam Weinig.
1124
1125         * TestWebKitAPI/Tests/WTF/Time.cpp:
1126         (TestWebKitAPI::TEST):
1127
1128 2017-04-10  Alex Christensen  <achristensen@webkit.org>
1129
1130         Revert r215217
1131         https://bugs.webkit.org/show_bug.cgi?id=170703
1132
1133         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1134
1135 2017-04-10  Alex Christensen  <achristensen@webkit.org>
1136
1137         Continue enabling WebRTC
1138         https://bugs.webkit.org/show_bug.cgi?id=170703
1139
1140         Reviewed by Youenn Fablet.
1141
1142         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1143
1144 2017-04-10  Kocsen Chung  <kocsen_chung@apple.com>
1145
1146         Have parseRevisionProperty use default repo name as the Buildbot key.
1147         https://bugs.webkit.org/show_bug.cgi?id=170696
1148
1149         Reviewed by Daniel Bates.
1150
1151         Previously, we needed to set a key and a fallbackKey when addressing
1152         Buildbot data for Internal. That is no longer necessary as we can make a safe assumption
1153         that the repo name maps exactly to that key for every repository other
1154         than WebKit.
1155
1156         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1157         Set `key = repositoryName` and only use fallback keys when dealing with WebKit.
1158
1159 2017-04-10  Aakash Jain  <aakash_jain@apple.com>
1160
1161         Add test262 JavaScriptCore tests to dashboard
1162         https://bugs.webkit.org/show_bug.cgi?id=170711
1163
1164         Rubber-stamped by Joseph Pecoraro.
1165
1166         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1167         (WebKitBuildbot): Added test262 JSC tests to dashboard.
1168
1169 2017-04-10  Alex Christensen  <achristensen@webkit.org>
1170
1171         REGRESSION(r195479) First main resource load in new WebProcess bypasses content extensions
1172         https://bugs.webkit.org/show_bug.cgi?id=170707
1173         <rdar://problem/27788755>
1174
1175         Reviewed by Tim Horton.
1176
1177         * TestWebKitAPI/Tests/WebKit2Cocoa/WKUserContentExtensionStore.mm:
1178         (-[ContentExtensionDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1179         (TEST_F):
1180         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1181         (-[ContentBlockingWebsitePoliciesDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1182         (-[ContentBlockingWebsitePoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
1183         (TEST):
1184
1185 2017-04-10  Alex Christensen  <achristensen@webkit.org>
1186
1187         Add API to get available content extension identifiers in a WKContentExtensionStore
1188         https://bugs.webkit.org/show_bug.cgi?id=170093
1189
1190         Reviewed by Geoffrey Garen.
1191
1192         * TestWebKitAPI/Tests/WebKit2Cocoa/WKUserContentExtensionStore.mm:
1193         (TEST_F):
1194
1195 2017-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
1196
1197         Refactor DataInteractionTests.UnresponsivePageDoesNotHangUI to not check against a fixed time interval
1198         https://bugs.webkit.org/show_bug.cgi?id=170658
1199
1200         Reviewed by Tim Horton.
1201
1202         Uses ignoreSynchronousMessagingTimeoutsForTesting to ensure that this test times out if data interaction
1203         preparation is synchronous, or passes if it is asynchronous.
1204
1205         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1206         (TestWebKitAPI::TEST):
1207         * TestWebKitAPI/cocoa/TestWKWebView.h:
1208         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1209         (-[TestWKWebView initWithFrame:]):
1210         (-[TestWKWebView initWithFrame:configuration:processPoolConfiguration:]):
1211         (-[TestWKWebView _setUpTestWindow:]):
1212
1213 2017-04-10  Brent Fulgham  <bfulgham@apple.com>
1214
1215         [WK2][macOS] Block access to Apple Events before launch.
1216         https://bugs.webkit.org/show_bug.cgi?id=170626
1217         <rdar://problem/16079334>
1218
1219         Reviewed by Alexey Proskuryakov.
1220
1221         Add a new TestWebKitAPI test that fails if Apple Events are sent.
1222
1223         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
1224         * TestWebKitAPI/Tests/WebKit2/mac/InjectedBundleAppleEvent.cpp: Added.
1225         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
1226         (TestWebKitAPI::didFinishLoadForFrame):
1227         (TestWebKitAPI::TEST):
1228         * TestWebKitAPI/Tests/WebKit2/mac/InjectedBundleAppleEvent_Bundle.cpp: Added.
1229         (TestWebKitAPI::InjectedBundleAppleEventTest::InjectedBundleAppleEventTest):
1230         (TestWebKitAPI::InjectedBundleAppleEventTest::didCreatePage):
1231
1232 2017-04-10  Guillaume Emont  <guijemont@igalia.com>
1233
1234         [JSC] Do not run FTL stress tests on MIPS
1235         https://bugs.webkit.org/show_bug.cgi?id=170684
1236
1237         Reviewed by Carlos Alberto Lopez Perez.
1238
1239         run-jsc-stress-tests does not correctly detect MIPS platforms, and its
1240         logic to detect if the platform supports FTL ignores that MIPS does
1241         not support FTL. This adds detection of MIPS (with the magic number
1242         determined empirically) and fixes the determination of whether we
1243         support FTL.
1244
1245         * Scripts/run-jsc-stress-tests:
1246
1247 2017-04-10  Jonathan Bedard  <jbedard@apple.com>
1248
1249         webkitpy: Increase estimate for processes run by iOS Simulators
1250         https://bugs.webkit.org/show_bug.cgi?id=170678
1251         <rdar://problem/31534061>
1252
1253         Reviewed by Aakash Jain.
1254
1255         Previously, it was estimated that each simulated iOS device would run about 100
1256         processes.  With newer versions of iOS, this is closer to 125.
1257
1258         * Scripts/webkitpy/port/ios_simulator.py:
1259         (IOSSimulatorPort): Increase process estimate from 100 to 125.
1260
1261 2017-04-10  Adrian Perez de Castro  <aperez@igalia.com>
1262
1263         [GTK] Misplaced right click menu on web page due to deprecated gtk_menu_popup()
1264         https://bugs.webkit.org/show_bug.cgi?id=170553
1265
1266         Reviewed by Michael Catanzaro.
1267
1268         Use gtk_menu_popup_at_pointer() and gtk_menu_popup_at_rect() when
1269         building with GTK+ 3.22 or newer. This allows the Wayland GTK+ backend
1270         to properly position popup menus, and also avoids using functions
1271         which were deprecated starting at that GTK+ release.
1272
1273         * MiniBrowser/gtk/BrowserSearchBar.c:
1274         (searchEntryMenuIconPressedCallback):
1275         Update MiniBrowser to use gtk_menu_popup_at_pointer().
1276
1277 2017-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
1278
1279         REGRESSION (r214403): fast/events/drag-to-navigate.html and fast/events/only-valid-drop-targets-receive-file-drop.html failing
1280         https://bugs.webkit.org/show_bug.cgi?id=170677
1281         <rdar://problem/31512633>
1282
1283         Reviewed by Tim Horton.
1284
1285         Fixes two drag and drop LayoutTests by introducing and enabling a TestOptions switch (enableDragDestinationActionLoad)
1286         to allow dropping URLs to trigger page navigation.
1287
1288         * DumpRenderTree/TestOptions.h:
1289         * DumpRenderTree/TestOptions.mm:
1290         (TestOptions::TestOptions):
1291         * DumpRenderTree/mac/DumpRenderTree.mm:
1292         (resetWebViewToConsistentStateBeforeTesting):
1293         * DumpRenderTree/mac/UIDelegate.h:
1294         * DumpRenderTree/mac/UIDelegate.mm:
1295         (-[UIDelegate resetToConsistentStateBeforeTesting:]):
1296         (-[UIDelegate webView:dragDestinationActionMaskForDraggingInfo:]):
1297
1298 2017-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
1299
1300         update-webkit-dependency should report $response->message for diagnose
1301         https://bugs.webkit.org/show_bug.cgi?id=170666
1302
1303         Reviewed by Alex Christensen.
1304
1305         * Scripts/update-webkit-dependency: Print $response->message to STDERR if an error happens.
1306
1307 2017-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
1308
1309         Data interaction on an image enclosed by an anchor should vend the anchor's URL
1310         https://bugs.webkit.org/show_bug.cgi?id=170660
1311         <rdar://problem/31043220>
1312
1313         Reviewed by Tim Horton.
1314
1315         Adds two new unit tests covering cases where data interaction is triggered from an image nested underneath an
1316         anchor. In one of the tests, the link has an href, and in the other, its href is missing, in which case we
1317         should fall back to the image URL instead. Also fixes a related unit test that was trying to check selection
1318         rects, but should not be.
1319
1320         See WebCore ChangeLog for more details.
1321
1322         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1323         * TestWebKitAPI/Tests/WebKit2Cocoa/image-in-link-and-input.html: Added.
1324         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1325         (TestWebKitAPI::TEST):
1326
1327 2017-04-10  Carlos Garcia Campos  <cgarcia@igalia.com>
1328
1329         [GTK] Remove the GDK dependency from ImageDiff
1330         https://bugs.webkit.org/show_bug.cgi?id=85299
1331
1332         Reviewed by Žan Doberšek.
1333
1334         Add a cairo only implementation of ImageDiff. We currently have 3 different implementations of ImageDiff: the
1335         Gdk based one used by GTK+ port, the cairo based one used by WinCairo and the CG based one. Most of the code is
1336         actually common in all of them, but it's duplicated. So, I've taken advantage of this patch to refactor the
1337         ImageDiff code to share the common implementation. This patch adds the cross-platform code, and the cairo
1338         implementation and enables it in the GTK+ port. In follow up patches we can move WinCairo to this implementation
1339         and also add CG implementation.
1340
1341         * ImageDiff/CMakeLists.txt:
1342         * ImageDiff/Cairo.cmake: Added.
1343         * ImageDiff/ImageDiff.cpp: Added.
1344         (main):
1345         * ImageDiff/PlatformGTK.cmake:
1346         * ImageDiff/PlatformImage.cpp: Added.
1347         (ImageDiff::PlatformImage::isCompatible):
1348         (ImageDiff::PlatformImage::difference):
1349         * ImageDiff/PlatformImage.h: Added.
1350         * ImageDiff/cairo/PlatformImageCairo.cpp: Added.
1351         (ImageDiff::PlatformImage::createFromStdin):
1352         (ImageDiff::PlatformImage::createFromDiffData):
1353         (ImageDiff::PlatformImage::PlatformImage):
1354         (ImageDiff::PlatformImage::~PlatformImage):
1355         (ImageDiff::PlatformImage::width):
1356         (ImageDiff::PlatformImage::height):
1357         (ImageDiff::PlatformImage::rowBytes):
1358         (ImageDiff::PlatformImage::hasAlpha):
1359         (ImageDiff::PlatformImage::pixels):
1360         (ImageDiff::PlatformImage::writeAsPNGToStdout):
1361         * ImageDiff/gtk/ImageDiff.cpp: Removed.
1362
1363 2017-04-10  Carlos Garcia Campos  <cgarcia@igalia.com>
1364
1365         REGRESSION(r214426): [GTK] Test media/video-click-dblckick-standalone.html started to fail in the bots after r214426
1366         https://bugs.webkit.org/show_bug.cgi?id=170667
1367
1368         Reviewed by Žan Doberšek.
1369
1370         In r214666 we disabled modern media controls runtime feature for the GTK+ port, but layout tests still override
1371         that value.
1372
1373         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1374         (WTR::TestController::updatePlatformSpecificTestOptionsForTest): Disable modern media controls.
1375
1376 2017-04-10  Carlos Garcia Campos  <cgarcia@igalia.com>
1377
1378         WTR: Avoid conversion from platform image to WKImage and then to platform image again when dumping pixel results
1379         https://bugs.webkit.org/show_bug.cgi?id=170653
1380
1381         Reviewed by Tim Horton.
1382
1383         When dumping pixels from a web view snapshot, we create a platform image that is then converted to a WKImage,
1384         which is a ShareableBitmap, so the image is rendered into a graphics context. Then we immediately extract the
1385         platform image back from the WKImage to dump the pixels. We could avoid that conversion by taking the web
1386         snapshot from TestInvocation::dumpPixelsAndCompareWithExpected().
1387
1388         * WebKitTestRunner/PlatformWebView.h: Add PlatformImage typedef and use it as return value of windowSnapshotImage().
1389         * WebKitTestRunner/TestInvocation.cpp:
1390         (WTR::TestInvocation::dumpResults): Pass the WKImage to dumpPixelsAndCompareWithExpected() only when pixel
1391         results were created in the web process.
1392         * WebKitTestRunner/TestInvocation.h: Make WKImage a default paramater of dumpPixelsAndCompareWithExpected().
1393         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
1394         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create the cairo surface from the given WKimage in case
1395         of web contents snapshot, and use PlatformWebView::windowSnapshotImage() in case of web view snapshot.
1396         * WebKitTestRunner/cg/TestInvocationCG.cpp:
1397         (WTR::createCGContextFromCGImage): Changed to receive a CGImageRef and renamed.
1398         (WTR::createCGContextFromImage): Get the CGImageRef from the WKImage and call createCGContextFromCGImage().
1399         (WTR::paintRepaintRectOverlay): It receives now the image size instead of the WKImage.
1400         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create the CGContextRef from the WKImage in case of web
1401         contents snpashot, and use PlatformWebView::windowSnapshotImage() in case of web view snapshot.
1402         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1403         (WTR::PlatformWebView::windowSnapshotImage): Return the cairo surface instead of creating a WKImage. Also use
1404         RGB24 format to match what mac does (kCGWindowImageShouldBeOpaque).
1405         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1406         (WTR::PlatformWebView::windowSnapshotImage): Return the CGImageRef instead of creating a WKImage.
1407         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1408         (WTR::PlatformWebView::windowSnapshotImage): Ditto.
1409
1410 2017-04-10  Chris Dumez  <cdumez@apple.com>
1411
1412         Drop Timer::startOneShot() overload taking a double
1413         https://bugs.webkit.org/show_bug.cgi?id=170659
1414
1415         Reviewed by Yusuke Suzuki.
1416
1417         Drop Timer::startOneShot() overload taking a double as people should use Seconds type now.
1418
1419         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
1420         (TestWebKitAPI::TEST):
1421         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
1422         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
1423
1424 2017-04-09  Wenson Hsieh  <wenson_hsieh@apple.com>
1425
1426         [WK2] Add infrastructure to perform actions after an asynchronous position information request finishes
1427         https://bugs.webkit.org/show_bug.cgi?id=170658
1428         <rdar://problem/31431450>
1429
1430         Reviewed by Tim Horton.
1431
1432         Adds a new test verifying that when a web page is unresponsive, the process of preparing for data interaction
1433         does not also cause the UI process to spin. We assume here that the call to prepare must be asynchronous, so it
1434         should complete before the unresponsiveness timeout is triggered.
1435
1436         See WebKit2 ChangeLog for more details.
1437
1438         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1439         (TestWebKitAPI::TEST):
1440
1441 2017-04-09  Chris Dumez  <cdumez@apple.com>
1442
1443         Drop Timer::startRepeating() overload taking a double
1444         https://bugs.webkit.org/show_bug.cgi?id=170656
1445
1446         Reviewed by Yusuke Suzuki.
1447
1448         Drop Timer::startRepeating() overload taking a double as people should use Seconds type now.
1449
1450         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
1451         (TestWebKitAPI::TEST):
1452
1453 2017-04-09  Youenn Fablet  <youenn@apple.com>
1454
1455         Resync WPT tests up to 23cd07d4685d81024b7440e042f8bbdb33e7ddec
1456         https://bugs.webkit.org/show_bug.cgi?id=170647
1457
1458         Reviewed by Sam Weinig.
1459
1460         * Scripts/webkitpy/common/checkout/scm/git.py:
1461         (Git.fetch): Fetching origin remote in case there is more than one.
1462
1463 2017-04-08  Simon Fraser  <simon.fraser@apple.com>
1464
1465         Update CSSProperties.json with correct fill-and-stroke status, and other cleanup
1466         https://bugs.webkit.org/show_bug.cgi?id=170643
1467
1468         Reviewed by Chris Dumez.
1469         
1470         Update the CSSProperties.json style checker to allow:
1471             - comments in codegen_properties
1472             - obsolete-category and obsolete-url in specification blocks
1473             - renamed "done" to "supported"
1474             
1475         Fix some references to codegen_properties to be codegen-properties.
1476
1477         * Scripts/webkitpy/style/checkers/jsonchecker.py:
1478         (JSONCSSPropertiesChecker.validate_status_type):
1479         (JSONCSSPropertiesChecker.validate_property_specification):
1480         (JSONCSSPropertiesChecker.check_codegen_properties):
1481
1482 2017-04-08  Youenn Fablet  <youenn@apple.com>
1483
1484         WebRTC tests gardening
1485         https://bugs.webkit.org/show_bug.cgi?id=170508
1486
1487         Reviewed by Eric Carlson.
1488
1489         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1490
1491 2017-04-07  Keith Miller  <keith_miller@apple.com>
1492
1493         Add a PriorityQueue class
1494         https://bugs.webkit.org/show_bug.cgi?id=170579
1495
1496         Reviewed by Saam Barati.
1497
1498         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1499         * TestWebKitAPI/Tests/WTF/PriorityQueue.cpp: Added.
1500         (operator  _z ):
1501         (enqueue):
1502         (dequeue):
1503         (TEST):
1504         (compareMove):
1505
1506 2017-04-07  Ryosuke Niwa  <rniwa@webkit.org>
1507
1508         Replace ES6SampleBench by ARES-6 in run-benchmark
1509         https://bugs.webkit.org/show_bug.cgi?id=170585
1510
1511         Reviewed by Saam Barati.
1512
1513         Updated the plan file for ES6SampleBench to run ARES-6 instead. Also increased the number of iterations
1514         from 4 to 8 to match teh default, and reduced the number of browser instances to use from 5 to 3.
1515
1516         * Scripts/webkitpy/benchmark_runner/data/patches/ARES-6.patch: Renamed from ES6SampleBench.patch.
1517         * Scripts/webkitpy/benchmark_runner/data/plans/ares6.plan: Renamed from es6bench.plan.
1518
1519 2017-04-07  Myles C. Maxfield  <mmaxfield@apple.com>
1520
1521         REGRESSION(r211382): Complex text with justification erroneously overflows containers
1522         https://bugs.webkit.org/show_bug.cgi?id=170399
1523         <rdar://problem/31442008>
1524
1525         Reviewed by Simon Fraser.
1526
1527         Check for the invariant that the sum of the advances is equal to m_totalWidth.
1528
1529         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
1530         (TestWebKitAPI::TEST_F):
1531
1532 2017-04-07  Ryan Haddad  <ryanhaddad@apple.com>
1533
1534         [ios-simulator] API test WebKit2.WKWebProcessPlugInRangeHandle timing out
1535         https://bugs.webkit.org/show_bug.cgi?id=167594
1536
1537         Unreviewed test gardening.
1538
1539         Disable this test because it is still timing out on the bots.
1540
1541         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm:
1542         (TEST):
1543
1544 2017-04-07  Jonathan Bedard  <jbedard@apple.com>
1545
1546         REGRESSION (r214553): Allow layout-tests to be run from Xcode without re-directing stdout, stdin and stderr
1547         https://bugs.webkit.org/show_bug.cgi?id=170601
1548         <rdar://problem/31492696>
1549
1550         Reviewed by Simon Fraser.
1551
1552         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
1553         (setUpIOSLayoutTestCommunication): Skip TCP setup if no port is in the environment.
1554         (tearDownIOSLayoutTestCommunication): Only teardown if TCP was used.
1555
1556 2017-04-07  Aakash Jain  <aakash_jain@apple.com>
1557
1558         Add support for test262 JavaScriptCore tests
1559         https://bugs.webkit.org/show_bug.cgi?id=170523
1560
1561         Reviewed by Daniel Bates.
1562
1563         * BuildSlaveSupport/build.webkit.org-config/config.json: Added bot433 and bot434.
1564         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1565         (RunTest262Tests): Added class to run Test262 tests.
1566         (RunTest262Tests.start): Added.
1567         (RunTest262Tests.countFailures): Method to count the failures.
1568         (Test262Factory): Added Test262 factory class.
1569         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1570         (RunTest262TestsTest): Added unit tests.
1571         (RunTest262TestsTest.assertResults): Helper method.
1572         (RunTest262TestsTest.test_no_regressions_output): Added test case.
1573         (test_failure_output): Same. 
1574         (test_failures_output): Same.
1575
1576 2017-04-07  Caio Lima  <ticaiolima@gmail.com>
1577
1578         [JSC] Change --debug option to --debugger
1579         https://bugs.webkit.org/show_bug.cgi?id=170587
1580
1581         Reviewed by Keith Miller.
1582
1583         * Scripts/run-jsc:
1584
1585         This patch is changing the new debugger flag for Tools/Scripts/run-jsc
1586         to --debugger to avoid shadowing --debug flag used to run JSC with
1587         Debug build.
1588
1589 2017-04-07  Brent Fulgham  <bfulgham@apple.com>
1590
1591         WebKit should percent encode single quotes in query strings
1592         https://bugs.webkit.org/show_bug.cgi?id=170561
1593         <rdar://problem/7415154>
1594
1595         Reviewed by Alex Christensen.
1596
1597         Add a test case for single-quote in the URL query string.
1598
1599         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1600
1601 2017-04-06  Myles C. Maxfield  <mmaxfield@apple.com>
1602
1603         Make FontWithFeatures test font pass OTS
1604         https://bugs.webkit.org/show_bug.cgi?id=169788
1605
1606         Reviewed by Tim Horton.
1607
1608         OTS, or the OpenType Sanitizer, is a check which tells if fonts are properly formed.
1609         Previously, our FontWithFeatures test font did not pass this check. This patch updates
1610         the font to pass the checks. Now, we can use this font on other platforms, and
1611         contribute the font to the W3C for testing the CSS Fonts level 3 spec.
1612
1613         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
1614         (Generator::appendCFFTable):
1615         (Generator::Feature::operator<):
1616         (Generator::appendGSUBTable):
1617         (Generator::appendOS2Table):
1618         (Generator::appendFormat4CMAPTable):
1619         (Generator::appendHEADTable):
1620         (Generator::appendHHEATable):
1621         (Generator::NameRecord::operator<):
1622         (Generator::appendNameSubtable):
1623         (Generator::appendNAMETable):
1624
1625 2017-04-06  Alexey Proskuryakov  <ap@apple.com>
1626
1627         Disable flaky WebKit2.ResizeWithHiddenContentDoesNotHang
1628         for https://bugs.webkit.org/show_bug.cgi?id=170195
1629
1630         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
1631
1632 2017-04-06  Ryan Haddad  <ryanhaddad@apple.com>
1633
1634         Unreviewed, rolling out r215046.
1635
1636         This change broke internal builds.
1637
1638         Reverted changeset:
1639
1640         "WebRTC tests gardening"
1641         https://bugs.webkit.org/show_bug.cgi?id=170508
1642         http://trac.webkit.org/changeset/215046
1643
1644 2017-04-06  Youenn Fablet  <youenn@apple.com>
1645
1646         WebRTC tests gardening
1647         https://bugs.webkit.org/show_bug.cgi?id=170508
1648
1649         Reviewed by Eric Carlson.
1650
1651         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1652
1653 2017-04-06  Jonathan Bedard  <jbedard@apple.com>
1654
1655         REGRESSION: Simulators failing to install after launch_app times out
1656         <rdar://problem/31478107>
1657
1658         Unreviewed infrastructure fix.
1659
1660         * Scripts/webkitpy/xcode/simulated_device.py:
1661         (SimulatedDevice.launch_app._install_timeout): Raise RuntimeError, not Exception.
1662
1663 2017-04-05  Joseph Pecoraro  <pecoraro@apple.com>
1664
1665         test262: module test progressions need updated expectations (@@iterator changes)
1666         https://bugs.webkit.org/show_bug.cgi?id=170535
1667
1668         Reviewed by Saam Barati.
1669
1670         * Scripts/run-jsc-stress-tests:
1671         Add :failDueToOutdatedOrBadTest to distinguish between a test failure
1672         in JavaScriptCore or an outdated or incorrect test262 test.
1673
1674 2017-04-05  Joseph Pecoraro  <pecoraro@apple.com>
1675
1676         Remove run-jsc-stress-tests benign warning about otool '-S' switch
1677         https://bugs.webkit.org/show_bug.cgi?id=170527
1678
1679         Reviewed by Aakash Jain.
1680
1681         * Scripts/run-jsc-stress-tests:
1682         The switch is not necessary and produces an error.
1683
1684 2017-04-05  Jonathan Bedard  <jbedard@apple.com>
1685
1686         webkitpy: Add pid logging for simulator processes
1687         https://bugs.webkit.org/show_bug.cgi?id=170505
1688
1689         Reviewed by Alexey Proskuryakov.
1690
1691         * Scripts/webkitpy/port/simulator_process.py:
1692         (SimulatorProcess._start.handler): Add pid to exception.
1693         (SimulatorProcess._start): Ditto.
1694         * Scripts/webkitpy/xcode/simulated_device.py:
1695         (SimulatedDevice.launch_app): Log pid when the process fails to launch and when
1696         a pid is successfully returned.
1697
1698 2017-04-05  Ryan Haddad  <ryanhaddad@apple.com>
1699
1700         Unreviewed, rolling out r214932.
1701
1702         This change broke an internal build.
1703
1704         Reverted changeset:
1705
1706         "[ios-simulator] API test WebKit2.DataDetectionReferenceDate
1707         timing out"
1708         https://bugs.webkit.org/show_bug.cgi?id=161967
1709         http://trac.webkit.org/changeset/214932
1710
1711 2017-04-05  Ryan Haddad  <ryanhaddad@apple.com>
1712
1713         Unreviewed, rolling out r214962.
1714
1715         Roll r214937 back in because it wasn't at fault for the build
1716         breakage.
1717
1718         Reverted changeset:
1719
1720         "Unreviewed, rolling out r214937."
1721         https://bugs.webkit.org/show_bug.cgi?id=170365
1722         http://trac.webkit.org/changeset/214962
1723
1724 2017-04-05  Ryan Haddad  <ryanhaddad@apple.com>
1725
1726         Unreviewed, rolling out r214937.
1727
1728         This change broke an internal build.
1729
1730         Reverted changeset:
1731
1732         "REGRESSION (r202472): Data Detection overwrites existing
1733         links in detected ranges"
1734         https://bugs.webkit.org/show_bug.cgi?id=170365
1735         http://trac.webkit.org/changeset/214937
1736
1737 2017-04-05  Jonathan Bedard  <jbedard@apple.com>
1738
1739         Increase timeouts for simulator testing
1740         Unreviewed infrastructure fix.
1741
1742         r214895 was not sufficient, increasing timeouts again.
1743
1744         * Scripts/webkitpy/xcode/simulated_device.py:
1745         (SimulatedDevice.install_app): Increase timeout from 3 to 10 seconds.
1746
1747 2017-04-05  Aakash Jain  <aakash_jain@apple.com>
1748
1749         Formatting fix to remove extra space.
1750
1751         Unreviewed formatting fix.
1752
1753         * Scripts/webkitdirs.pm:
1754         (isEmbeddedWebKit): Remove extra space.
1755
1756 2017-04-05  Aakash Jain  <aakash_jain@apple.com>
1757
1758         Rename isIOSLikeWebKit to isEmbeddedWebKit.
1759
1760         Rubber-stamped by Alexey Proskuryakov. 
1761
1762         * Scripts/webkitdirs.pm:
1763         (isEmbeddedWebKit): Added
1764         (isIOSLikeWebKit): Deleted.
1765
1766 2017-04-05  Alex Christensen  <achristensen@webkit.org>
1767
1768         Fix CMake build.
1769
1770         * TestRunnerShared/EventSerialization/mac/EventSerializerMac.mm:
1771         * TestRunnerShared/spi/CoreGraphicsSPI.h: Removed.
1772         * TestRunnerShared/spi/CoreGraphicsTestSPI.h: Copied from Tools/TestRunnerShared/spi/CoreGraphicsSPI.h.
1773         There is a CoreGraphicsSPI.h in WebCore and the CMake build was finding the wrong one.
1774         Since we just inherit the include paths from WebCore in the CMake build and since this SPI is only used for testing,
1775         I just renamed CoreGraphicsSPI.h to CoreGraphicsTestSPI.h to avoid any name collisions.
1776         * WebKitTestRunner/PlatformMac.cmake:
1777         Add some missing files.
1778         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1779
1780 2017-04-05  Keith Miller  <keith_miller@apple.com>
1781
1782         Add debug option to run-jsc script
1783         https://bugs.webkit.org/show_bug.cgi?id=170503
1784
1785         Reviewed by Yusuke Suzuki.
1786
1787         Adds a new option to the run-jsc script so that when passed
1788         "--debug" it will wrap the jsc call with an lldb invocation. If
1789         someone wishes to use a different debugger they can set the
1790         DEBUGGER environment variable. Additionally, run-jsc now exits
1791         with the exit status of the jsc call.
1792
1793         * Scripts/run-jsc:
1794
1795 2017-04-05  Andy Estes  <aestes@apple.com>
1796
1797         REGRESSION (r202472): Data Detection overwrites existing links in detected ranges
1798         https://bugs.webkit.org/show_bug.cgi?id=170365
1799         <rdar://problem/29205721>
1800
1801         Reviewed by Tim Horton.
1802
1803         * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm:
1804         (expectLinkCount): Changed to only query links with the x-apple-data-detectors attribute.
1805         (TEST): Re-enabled the test, which now passes.
1806
1807 2017-04-05  Andy Estes  <aestes@apple.com>
1808
1809         [ios-simulator] API test WebKit2.WKWebProcessPlugInRangeHandle timing out
1810         https://bugs.webkit.org/show_bug.cgi?id=167594
1811
1812         Re-enabled this API test now that webkit.org/b/161967 is fixed.
1813
1814         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm:
1815         (TEST):
1816
1817 2017-04-05  Andy Estes  <aestes@apple.com>
1818
1819         [ios-simulator] API test WebKit2.DataDetectionReferenceDate timing out
1820         https://bugs.webkit.org/show_bug.cgi?id=161967
1821
1822         Reviewed by Alexey Proskuryakov.
1823
1824         * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm:
1825         (TEST): Re-enabled WebKit2.DataDetectionReferenceDate.
1826
1827 2017-04-04  Simon Fraser  <simon.fraser@apple.com>
1828
1829         Various settings in Minibrowser are off by default, and should be on
1830         https://bugs.webkit.org/show_bug.cgi?id=170465
1831         rdar://problem/31421543
1832
1833         Reviewed by Tim Horton.
1834
1835         Explicitly set preferences that should be on by default to enabled, if they have not been
1836         set previously.
1837
1838         * MiniBrowser/mac/SettingsController.m:
1839         (-[SettingsController init]):
1840
1841 2017-04-04  JF Bastien  <jfbastien@apple.com>
1842
1843         Add JF Bastien as reviewer
1844         https://bugs.webkit.org/show_bug.cgi?id=170481
1845
1846         Reviewed by Mark Lam.
1847
1848         * Scripts/webkitpy/common/config/contributors.json:
1849
1850 2017-04-04  Jonathan Bedard  <jbedard@apple.com>
1851
1852         Increase timeouts for simulator testing
1853
1854         Unreviewed infrastructure fix.
1855
1856         * Scripts/webkitpy/port/simulator_process.py:
1857         (SimulatorProcess._start): Increase timeout from 3 to 6 seconds.
1858         * Scripts/webkitpy/xcode/simulated_device.py:
1859         (SimulatedDevice.install_app): Increase timeout from 1 to 3 seconds.
1860
1861 2017-04-04  Tim Horton  <timothy_horton@apple.com>
1862
1863         [Mac] -[WKWebView findMatchesForString:relativeToMatch:findOptions:maxResults:resultCollector:] invokes the resultCollector with didWrap = NO even when it wraps
1864         https://bugs.webkit.org/show_bug.cgi?id=165801
1865         <rdar://problem/29649535>
1866
1867         Reviewed by Wenson Hsieh.
1868
1869         * TestWebKitAPI/Tests/WebKit2Cocoa/FindInPage.mm:
1870         (TEST):
1871         Add some tests for wrapping finds.
1872
1873 2017-04-03  Joseph Pecoraro  <pecoraro@apple.com>
1874
1875         Add some new patterns to filter-build-webkit
1876         https://bugs.webkit.org/show_bug.cgi?id=170429
1877
1878         Reviewed by Alexey Proskuryakov.
1879
1880         * Scripts/filter-build-webkit:
1881         (setOutputFormatOption):
1882
1883 2017-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1884
1885         Data interaction should register type identifiers in order of priority
1886         https://bugs.webkit.org/show_bug.cgi?id=170428
1887         <rdar://problem/30633296>
1888
1889         Reviewed by Tim Horton.
1890
1891         Augments existing unit tests to check for the existence and priority of type identifiers in the UIItemProviders
1892         created upon starting data interaction. Also fixes a race condition in one of the unit tests and adds a new unit
1893         test for data interaction from a textarea to an input.
1894
1895         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1896         (checkTypeIdentifierPrecedesOtherTypeIdentifier):
1897         (TestWebKitAPI::TEST):
1898         * TestWebKitAPI/ios/DataInteractionSimulator.h:
1899         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1900         (-[DataInteractionSimulator _advanceProgress]):
1901         (-[DataInteractionSimulator sourceItemProviders]):
1902         (-[DataInteractionSimulator _webView:showCustomSheetForElement:]):
1903
1904 2017-04-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1905
1906         [GTK][JHBuild] Update mesa repository url for tarballs
1907         https://bugs.webkit.org/show_bug.cgi?id=170431
1908
1909         Reviewed by Michael Catanzaro.
1910
1911         * gtk/jhbuild.modules:
1912
1913 2017-04-03  Joseph Pecoraro  <pecoraro@apple.com>
1914
1915         TestWebKitAPI: Warning: Multiple build commands for Ahem.ttf
1916         https://bugs.webkit.org/show_bug.cgi?id=170430
1917
1918         Reviewed by Alexey Proskuryakov.
1919
1920         * TestWebKitAPI/Tests/mac/Ahem.ttf: Removed.
1921         Eliminate one of the copies of Ahem.ttf.
1922
1923         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1924         Once eliminated, there is now only one Ahem.ttf that is copied
1925         to the Resources bundle. Drive-by sort the project file.
1926
1927 2017-04-03  Simon Fraser  <simon.fraser@apple.com>
1928
1929         Allow MiniBrowser windows to receive local file drags again
1930         https://bugs.webkit.org/show_bug.cgi?id=170422
1931
1932         Reviewed by Wenson Hsieh.
1933
1934         Adopt the new UIDelegate SPI to allow drops.
1935
1936         * MiniBrowser/mac/WK2BrowserWindowController.m:
1937         (-[WK2BrowserWindowController _webView:dragDestinationActionMaskForDraggingInfo:]):
1938
1939 2017-04-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1940
1941         [GTK][JHBuild] Fetch libvpx from a release tarball instead of git
1942         https://bugs.webkit.org/show_bug.cgi?id=170426
1943
1944         Reviewed by Michael Catanzaro.
1945
1946         * gtk/jhbuild.modules:
1947
1948 2017-04-03  Nan Wang  <n_wang@apple.com>
1949
1950         AX: Expose link children when doing search predication on iOS
1951         https://bugs.webkit.org/show_bug.cgi?id=170424
1952         <rdar://problem/31413335>
1953
1954         Reviewed by Chris Fleizach.
1955
1956         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1957         (AccessibilityUIElement::uiElementForSearchPredicate):
1958         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1959         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1960
1961 2017-04-03  Brian Burg  <bburg@apple.com>
1962
1963         run-safari should support launching with custom language and locale
1964         https://bugs.webkit.org/show_bug.cgi?id=170397
1965
1966         Reviewed by Alexey Proskuryakov.
1967
1968         Hook up -AppleLanguages and -AppleLocale to command line options.
1969
1970         * Scripts/webkitdirs.pm:
1971         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded):
1972         (argumentsForRunAndDebugMacWebKitApp):
1973
1974 2017-04-03  Jonathan Bedard  <jbedard@apple.com>
1975
1976         webkitpy: Provide option to skip install
1977         https://bugs.webkit.org/show_bug.cgi?id=170344
1978
1979         Reviewed by Alexey Proskuryakov.
1980
1981         Installing can take time for on device testing.  Provide an option to skip install
1982         and use whatever driver is currently installed on the device or simulator.
1983
1984         * Scripts/webkitpy/port/base.py:
1985         (Port.check_build): Do not check driver if skipping install.
1986         * Scripts/webkitpy/port/factory.py:
1987         (platform_options): Add '--no-install' option.
1988         * Scripts/webkitpy/port/ios.py:
1989         (IOSPort.setup_test_run): Check install option before installing.
1990
1991 2017-04-03  Keith Miller  <keith_miller@apple.com>
1992
1993         WebAssembly: Update spec tests
1994         https://bugs.webkit.org/show_bug.cgi?id=170361
1995
1996         Rubber-stamped by Saam Barati.
1997
1998         Update the runner to know the new wasm spec test harness code.
1999
2000         * Scripts/run-jsc-stress-tests:
2001
2002 2017-04-01  Alexey Proskuryakov  <ap@apple.com>
2003
2004         Rolling back <https://trac.webkit.org/r214697>, as it made WebKit2.DataDetectionReferenceDate time out.
2005
2006         Was REGRESSION (r202472): Data Detection overwrites existing links in detected ranges
2007         https://bugs.webkit.org/show_bug.cgi?id=170365
2008
2009         * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm:
2010
2011 2017-04-01  Csaba Osztrogonác  <ossy@webkit.org>
2012
2013         Mac cmake buildfix after 214586.
2014         https://bugs.webkit.org/show_bug.cgi?id=170381
2015
2016         Unreviewed speculative buildfix.
2017
2018         * WebKitTestRunner/PlatformMac.cmake:
2019
2020 2017-04-01  Csaba Osztrogonác  <ossy@webkit.org>
2021
2022         Unreviewed speculative Mac cmake buildfix after r214586, just for fun.
2023         https://bugs.webkit.org/show_bug.cgi?id=161675
2024
2025         * WebKitTestRunner/PlatformMac.cmake:
2026
2027 2017-03-31  Jonathan Bedard  <jbedard@apple.com>
2028
2029         webkitpy: Add target host concept
2030         https://bugs.webkit.org/show_bug.cgi?id=170186
2031         <rdar://problem/31301797>
2032
2033         Reviewed by Alexey Proskuryakov.
2034
2035         Adding the idea of a target host. Target hosts are objects conforming to the
2036         structure of the SystemHost object in Scripts/webkitpy/common/system/systemhost.py
2037         Target hosts are the hosts associated with a worker process.
2038
2039         * Scripts/webkitpy/common/system/filesystem.py:
2040         (FileSystem.map_base_host_path): Convert a path from an absolute path on the base
2041         host to an absolute path on this host.
2042         (FileSystem.move_to_base_host): Move file from this host to the base host.
2043         (FileSystem.move_from_base_host): Move file from the base host to this host.
2044         (FileSystem.copy_to_base_host): Copy file from this host to the base host.
2045         (FileSystem.copy_from_base_host): Copy file from the base host to this host.
2046         * Scripts/webkitpy/common/system/filesystem_mock.py:
2047         (MockFileSystem.map_base_host_path): Convert a path from an absolute path on the base
2048         host to an absolute path on this host.
2049         (MockFileSystem.move_to_base_host): Move file from this host to the base host.
2050         (MockFileSystem.move_from_base_host): Move file from the base host to this host.
2051         (MockFileSystem.copy_to_base_host): Copy file from this host to the base host.
2052         (MockFileSystem.copy_from_base_host): Copy file from the base host to this host.
2053         * Scripts/webkitpy/port/base.py:
2054         (Port.target_host): Return host determined by worker number.
2055         (Port.abspath_for_test): Accept optional target_host argument to return location
2056         of test on a target host.
2057         (Port._driver_tempdir): Accept optional target_host argument to return a temporary
2058         directory on a target host.
2059         (Port.sample_process): Accept optional target_host argument to sample process on
2060         a target host.
2061         * Scripts/webkitpy/port/darwin.py:
2062         (DarwinPort.sample_process): Run sample process on target host.
2063         (DarwinPort.sample_file_path): Accept directory for file.
2064         (DarwinPort.spindump_file_path): Ditto.
2065         * Scripts/webkitpy/port/darwin_testcase.py:
2066         (DarwinTest.test_spindump): Check file movement.
2067         (DarwinTest.test_sample_process): Ditto.
2068         (DarwinTest.test_sample_process_exception):
2069         * Scripts/webkitpy/port/driver.py:
2070         (Driver.__init__): Add and set self._target_host variable.
2071         (Driver._start): Pass target host to _driver_tempdir().
2072         (Driver.stop): Call the target host's rmtree.
2073         (Driver._check_for_driver_timeout): Pass target host to sample_process.
2074         (Driver._check_for_driver_crash_or_unresponsiveness): Ditto.
2075         (Driver._command_from_driver_input): Pass target host to abspath_for_test and map
2076         layout test directory to target host.
2077         * Scripts/webkitpy/port/ios.py:
2078         (IOSPort):
2079         (IOSPort.target_host): Replaced device_for_worker_number.
2080         (IOSPort.setup_test_run): Replace device_for_worker_number with target_host.
2081         (IOSPort.device_for_worker_number): Replaced with target_host.
2082         * Scripts/webkitpy/port/server_process.py:
2083         (ServerProcess.__init__): Accept target_host instead of worker_number.
2084         (ServerProcess._start): Replace _host with _target_host.
2085         (ServerProcess._handle_timeout): Ditto.
2086         (ServerProcess._kill): Ditto.
2087         * Scripts/webkitpy/port/simulator_process.py:
2088         (SimulatorProcess.__init__): Accept target_host instead of worker_number.
2089         (SimulatorProcess._start): Replace _device with _target_host.
2090         (SimulatorProcess.stop): Ditto.
2091         (SimulatorProcess._kill): Deleted.
2092
2093 2017-03-31  Jonathan Bedard  <jbedard@apple.com>
2094
2095         Unreviewed fix after r214569
2096         https://bugs.webkit.org/show_bug.cgi?id=170255
2097
2098         Unreviewed infrastructure fix.
2099
2100         * Scripts/webkitpy/port/ios.py:
2101         (IOSPort.clean_up_test_run): Check if the device is defined before teardown.
2102
2103 2017-03-31  Andy Estes  <aestes@apple.com>
2104
2105         REGRESSION (r202472): Data Detection overwrites existing links in detected ranges
2106         https://bugs.webkit.org/show_bug.cgi?id=170365
2107         <rdar://problem/29205721>
2108
2109         Reviewed by Tim Horton.
2110
2111         * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm:
2112         (expectLinkCount): Changed to only query links with the x-apple-data-detectors attribute.
2113         (TEST): Re-enabled the test, which now passes.
2114
2115 2017-03-31  Tim Horton  <timothy_horton@apple.com>
2116
2117         Mail can get stuck underneath FindController::findStringMatches after searching in a long message
2118         https://bugs.webkit.org/show_bug.cgi?id=170326
2119         <rdar://problem/30330395>
2120
2121         Reviewed by Simon Fraser.
2122
2123         * TestWebKitAPI/Tests/WebKit2Cocoa/FindInPage.mm:
2124         (TEST):
2125
2126 2017-03-31  Carlos Garcia Campos  <cgarcia@igalia.com>
2127
2128         Unreviewed. Fix WTR crashes in GTK+ port after r214413.
2129
2130         Fixes: http/tests/ssl/upgrade-origin-usage.html
2131                http/tests/websocket/tests/hybi/network-process-crash-error.html
2132                http/tests/websocket/tests/hybi/simple-wss.html
2133
2134         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2135         (WTR::TestController::platformContext): Return the context.
2136
2137 2017-03-30  Sam Weinig  <sam@webkit.org>
2138
2139         Expose the WKView SPI, _prepareForMoveToWindow:withCompletionHandler as WKWebView SPI
2140         https://bugs.webkit.org/show_bug.cgi?id=170315
2141
2142         Reviewed by Simon Fraser.
2143
2144         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2145         * TestWebKitAPI/Tests/WebKit2Cocoa/PrepareForMoveToWindow.mm: Added.
2146         Add test showing the completion handler is called.
2147
2148 2017-03-30  Filip Pizlo  <fpizlo@apple.com>
2149
2150         Air should support linear scan for optLevel<2
2151         https://bugs.webkit.org/show_bug.cgi?id=170161
2152
2153         Reviewed by Saam Barati.
2154         
2155         This makes us run a bunch of JS tests at optLevel=1 to force testing of this new compiler
2156         pipeline.
2157
2158         * Scripts/run-jsc-stress-tests:
2159
2160 2017-03-30  Aakash Jain  <aakash_jain@apple.com>
2161
2162         Support tvOS and watchOS in webkitdirs.pm
2163         https://bugs.webkit.org/show_bug.cgi?id=170267
2164
2165         Reviewed by Alexey Proskuryakov.
2166
2167         * Scripts/webkitdirs.pm:
2168         (determineXcodeSDK): Evaluate sdk for tvos and watchos.
2169         (xcodeSDKPlatformName): Added support for tvos and watchos.
2170         (determinePortName): Same.
2171         (isAppleCocoaWebKit): Same.
2172         (willUseAppleTVDeviceSDK): Added.
2173         (willUseAppleTVSimulatorSDK): Added.
2174         (willUseWatchDeviceSDK): Added.
2175         (willUseWatchSimulatorSDK): Added.
2176         (isTVOSWebKit): Added.
2177         (isWATCHOSWebKit): Added.
2178         (isIOSLikeWebKit): Added.
2179
2180 2017-03-30  Wenson Hsieh  <wenson_hsieh@apple.com>
2181
2182         [WK2] Touches should not cancel when showing a custom action sheet while data interaction is active
2183         https://bugs.webkit.org/show_bug.cgi?id=170291
2184         <rdar://problem/31301388>
2185
2186         Reviewed by Tim Horton.
2187
2188         Adds support for testing how the custom action sheet presentation codepath interacts with data interaction, as
2189         well as a new unit test. In this case, we force data interaction to fail if touches are canceled on the
2190         shared UIApplication, and verify that data interaction completes successfully.
2191
2192         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2193         (TestWebKitAPI::TEST):
2194         * TestWebKitAPI/ios/DataInteractionSimulator.h:
2195         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2196         (-[DataInteractionSimulatorApplication _cancelAllTouches]):
2197         (-[DataInteractionSimulator initWithWebView:]):
2198         (-[DataInteractionSimulator simulateAllTouchesCanceled:]):
2199         (-[DataInteractionSimulator runFrom:to:]):
2200         (-[DataInteractionSimulator _advanceProgress]):
2201         (-[DataInteractionSimulator _webView:showCustomSheetForElement:]):
2202
2203 2017-03-30  Per Arne Vollan  <pvollan@apple.com>
2204
2205         [Win] Pass close_fds = True in Python popen call.
2206         https://bugs.webkit.org/show_bug.cgi?id=170172
2207
2208         Reviewed by Brent Fulgham.
2209
2210         This was previously not supported on Windows, but in Python 2.7.10 it is.
2211
2212         * Scripts/webkitpy/common/system/executive.py:
2213         (Executive._should_close_fds):
2214         * Scripts/webkitpy/port/server_process.py:
2215         (ServerProcess._start):
2216
2217 2017-03-30  Aakash Jain  <aakash_jain@apple.com>
2218
2219         Change my status to be a WebKit reviewer.
2220
2221         Unreviewed status update edit.
2222
2223         * Scripts/webkitpy/common/config/contributors.json:
2224
2225 2017-03-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2226
2227         Change my status to be a WebKit reviewer.
2228
2229         Unreviewed status update edit.
2230
2231         * Scripts/webkitpy/common/config/contributors.json:
2232
2233 2017-03-29  Tim Horton  <timothy_horton@apple.com>
2234
2235         Swipe gesture tests don't work on macOS Sierra
2236         https://bugs.webkit.org/show_bug.cgi?id=161675
2237         <rdar://problem/23379930>
2238
2239         Reviewed by Darin Adler.
2240
2241         * DumpRenderTree/mac/UIScriptControllerMac.mm:
2242         (WTR::UIScriptController::platformPlayBackEventStream):
2243         (WTR::UIScriptController::beginBackSwipe):
2244         (WTR::UIScriptController::completeBackSwipe):
2245         * TestRunnerShared/EventSerialization/mac/EventSerializerMac.h: Copied from Tools/DumpRenderTree/mac/UIScriptControllerMac.mm.
2246         * TestRunnerShared/EventSerialization/mac/EventSerializerMac.mm: Added.
2247         (eventIsOfType):
2248         (eventIsOfTypes):
2249         (eventIsOfGestureType):
2250         (eventIsOfGestureTypes):
2251         (+[EventSerializer dictionaryForEvent:relativeToTime:]):
2252         (+[EventSerializer createEventForDictionary:inWindow:relativeToTime:]):
2253         (+[EventSerializer playEventStream:inWindow:completionHandler:]):
2254         * TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.h: Copied from Tools/WebKitTestRunner/mac/UIScriptControllerMac.mm.
2255         * TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm: Added.
2256         (beginSwipeBackEventStream):
2257         (completeSwipeBackEventStream):
2258         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2259         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2260         (WTR::UIScriptController::playBackEventStream):
2261         (WTR::UIScriptController::beginBackSwipe):
2262         (WTR::UIScriptController::completeBackSwipe):
2263         (WTR::UIScriptController::platformPlayBackEventStream):
2264         (WTR::UIScriptController::platformClearAllCallbacks): Deleted.
2265         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2266         * TestRunnerShared/spi/CoreGraphicsSPI.h: Added.
2267         * TestRunnerShared/spi/IOKitSPI.h: Renamed from Tools/WebKitTestRunner/ios/IOKitSPI.h.
2268         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2269         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2270         (WTR::playBackEvents):
2271         (WTR::UIScriptController::beginBackSwipe):
2272         (WTR::UIScriptController::completeBackSwipe):
2273         (WTR::UIScriptController::platformPlayBackEventStream):
2274
2275 2017-03-29  Jonathan Bedard  <jbedard@apple.com>
2276
2277         webkitpy: Robust test clean-up
2278         https://bugs.webkit.org/show_bug.cgi?id=170255
2279
2280         Reviewed by Alexey Proskuryakov.
2281
2282         On-device testing is the motivation for this change.  Failure to run clean-up functions can
2283         result in zombie processes, residual NFS mounts and other undesirable remnants from a failed
2284         test run.  Make an effort to clean-up even if exceptions are thrown during set-up or clean-up.
2285
2286         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2287         (Manager._set_up_run): Clean up test run if set-up fails.
2288         * Scripts/webkitpy/port/ios.py:
2289         (IOSPort.clean_up_test_run): Continue cleaning up devices even after an exception is thrown.
2290
2291 2017-03-29  Jonathan Bedard  <jbedard@apple.com>
2292
2293         Simulator testing stops after the first crash
2294         <rdar://problem/31325362>
2295
2296         Unreviewed infrastructure fix.
2297
2298         * Scripts/webkitpy/xcode/simulated_device.py:
2299         (SimulatedDevice):
2300         (SimulatedDevice.launch_app): Increase timeout when attempting to launch app.
2301
2302 2017-03-29  Jonathan Bedard  <jbedard@apple.com>
2303
2304         webkitpy: Standardize web-server port definitions
2305         https://bugs.webkit.org/show_bug.cgi?id=170144
2306         <rdar://problem/31284026>
2307
2308         Reviewed by Daniel Bates.
2309
2310         Default web-server ports should be declared in global variables.
2311         Add functions to web-servers which return the ports these servers
2312         are using so that other tools can forward them.
2313
2314         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
2315         (LayoutTestApacheHttpd.__init__): Use shared constants in http_server_base.py.
2316         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
2317         (TestLayoutTestApacheHttpd.test_start_cmd): Check port_to_forward for expected values.
2318         * Scripts/webkitpy/layout_tests/servers/http_server.py:
2319         (Lighttpd.__init__): Use shared constants in http_server_base.py.
2320         (Lighttpd._prepare_config): Ditto.
2321         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
2322         (HttpServerBase): Add default port constants.
2323         (HttpServerBase.ports_to_forward): Add function to return ports used for http server.
2324         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
2325         (TestHttpServer.test_start_cmd): Check port_to_forward for expected values.
2326         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2327          (WebPlatformTestServer.ports_to_forward): Add function to return ports used for web-platform tests.
2328         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
2329         (PyWebSocket): Make default port values public.
2330         (PyWebSocket.__init__): Use public default port.
2331         (PyWebSocket.ports_to_forward): Return port used in an array.
2332         * Scripts/webkitpy/port/base.py:
2333         (Port.to.ports_to_forward): Return all ports used the various web-servers managed by the port object.
2334         (Port.to.start_websocket_server): Use PyWebSocket port constants.
2335
2336 2017-03-29  Wenson Hsieh  <wenson_hsieh@apple.com>
2337
2338         Links with empty hrefs should not be drag sources
2339         https://bugs.webkit.org/show_bug.cgi?id=170241
2340         <rdar://problem/31305505>
2341
2342         Reviewed by Tim Horton.
2343
2344         Adds a new API test: DataInteractionTests.LinkWithEmptyHREF.
2345
2346         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2347         (TestWebKitAPI::TEST):
2348         * TestWebKitAPI/ios/DataInteractionSimulator.h:
2349
2350         Expose the current phase of the data interaction simulator for verifying behaviors in unit tests.
2351
2352         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2353         (-[DataInteractionSimulator phase]):
2354
2355 2017-03-29  Jonathan Bedard  <jbedard@apple.com>
2356
2357         Use TCP instead of FIFOs for Simulator/Device communication
2358         https://bugs.webkit.org/show_bug.cgi?id=169419
2359         <rdar://problem/30949615>
2360
2361         Reviewed by Alexey Proskuryakov.
2362
2363         Using TCP instead of FIFOs when communicating with devices allows the device being tested
2364         to be on a different machine then the one handling the management of the test run.
2365
2366         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2367         * DumpRenderTree/mac/DumpRenderTree.mm:
2368         (dumpRenderTree): Call setUp/tearDownIOSLayoutTestCommunication() instead of using FIFOs.
2369         * Scripts/webkitpy/port/device.py:
2370         (Device.__init__): Initialize the listening_socket.
2371         (Device.listening_port): Return port of listening socket.
2372         (Device.prepare_for_testing): Open listening socket on an open port, prepare platform device
2373         fro testing.
2374         (Device.finished_testing): Close listening socket associated with this device, call the
2375         platform device's finished_testing function if it exists.
2376         * Scripts/webkitpy/port/ios.py:
2377         (IOSPort.setup_test_run): Prepare each device for testing.
2378         (IOSPort.clean_up_test_run): Notify each device that testing has completed.
2379         * Scripts/webkitpy/port/ios_simulator.py:
2380         (IOSSimulatorPort): Work around device persistence bug.
2381         (IOSSimulatorPort.__init__): Ditto.
2382         * Scripts/webkitpy/port/simulator_process.py:
2383         (SimulatorProcess):
2384         (SimulatorProcess.NonBlockingFileFromSocket): Add to work around shortcomings in
2385         Python 2’s makefile.
2386         (SimulatorProcess.NonBlockingFileFromSocket.__init__): Initialize file with socket.
2387         (SimulatorProcess.ReadFileSocket.close): Close file and then socket;
2388         (SimulatorProcess.__init__): Pass TCP port over environment, remove FIFO names.
2389         (SimulatorProcess.__getattr__): Expose all file attributes.
2390         (SimulatorProcess._accept_connection_create_file): Wait for connection from server and
2391         create and return a file-like object from the incoming connection.
2392         (SimulatorProcess._start): Use TCP connections instead of FIFOs.
2393         (SimulatorProcess._start.handler): Output server port in timeout exception.
2394         (SimulatorProcess._reset): Deleted.
2395         * TestRunnerShared/IOSLayoutTestCommunication.cpp: Added.
2396         (connectToServer): Return socket connected to the provided server address.
2397         (setupiOSLayoutTestCommunication): Connect stdin, stdout and stderr as socket to a
2398         TCP server running on localhost.
2399         (tearDownIOSLayoutTestCommunication): Close stdin, stdout and stderr TCP sockets.
2400         * TestRunnerShared/IOSLayoutTestCommunication.h: Added.
2401         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2402         * WebKitTestRunner/ios/TestControllerIOS.mm:
2403         (WTR::TestController::platformInitialize): Call setUpIOSLayoutTestCommunication()
2404         instead of using FIFOs.
2405         (WTR::TestController::platformDestroy): Call tearDownIOSLayoutTestCommunication().
2406
2407 2017-03-29  Jonathan Bedard  <jbedard@apple.com>
2408
2409         webkitpy: Add IOSDevicePort and IOSPort tests
2410         https://bugs.webkit.org/show_bug.cgi?id=170206
2411         <rdar://problem/31308364>
2412
2413         Reviewed by Alexey Proskuryakov.
2414
2415         * Scripts/webkitpy/port/darwin_testcase.py: Removed unused import.
2416         * Scripts/webkitpy/port/ios_device_unittest.py: Added.
2417         (iosDeviceTest): Contains tests for the IOSDevicePort.
2418         (iosDeviceTest.make_port): Creates an IOSDevicePort with arguments.
2419         (iosDeviceTest.test_operating_system): Check for the correct operating system.
2420         * Scripts/webkitpy/port/ios_simulator_unittest.py: Moved from Tools/Scripts/webkitpy/port/ios_unittest.py.
2421         (iosSimulatorTest): Inherit from ios_testcase.
2422         (iosSimulatorTest.make_port): Ditto.
2423         (iosSimulatorTest.test_get_crash_log): Ditto.
2424         * Scripts/webkitpy/port/ios_testcase.py: Added.
2425         (iOSTest): Contains shared tests for the IOSDevicePort and IOSSimulatorPort.
2426         (iOSTest.test_driver_name): Tests for iOS app driver.
2427         (iOSTest.test_baseline_searchpath): Check that ios and ios-wk1 are in the baseline search path.
2428         * Scripts/webkitpy/port/ios_unittest.py: Moved to ios_simulator_unittest.py.
2429         * Scripts/webkitpy/port/port_testcase.py:
2430         (PortTestCase): Rename is_simulator to disable_setup to more accurately describe it's meaning.
2431         (PortTestCase.test_diff_image): Use disable_setup instead of is_simulator.
2432         (PortTestCase.test_diff_image_crashed): Ditto.
2433
2434 2017-03-28  Jason Marcell  <jmarcell@apple.com>
2435
2436         Fix `index-expected.txt` for dashboard test results.
2437         https://bugs.webkit.org/show_bug.cgi?id=170214
2438
2439         Reviewed by Alexey Proskuryakov.
2440
2441         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index-expected.txt:
2442
2443 2017-03-28  Alexey Proskuryakov  <ap@apple.com>
2444
2445         Bot watcher's dashboard has separate settings for "mac" and "macos"
2446         https://bugs.webkit.org/show_bug.cgi?id=170164
2447
2448         Reviewed by Tim Horton.
2449
2450         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
2451         (Settings.prototype.parsePlatformFamily): Aded a special case for "macos".
2452
2453 2017-03-28  Alexey Proskuryakov  <ap@apple.com>
2454
2455         Fix dashboard test results on the dashboard
2456         https://bugs.webkit.org/show_bug.cgi?id=170158
2457
2458         Reviewed by Tim Horton.
2459
2460         Link to result diff instead of stdio. Looking at the diff, I wonder if it can be
2461         further improved, as it's not super readable, but stdio is entirely useless in this context.
2462
2463         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
2464         (Buildbot.prototype.dashboardTestResultsURLForIteration): Generate formatted diff link.
2465
2466         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2467         Fixed a typo in step name, so that it's actually treated as productive.
2468
2469         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2470         (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus):
2471         (BuildbotTesterQueueView.prototype.update):
2472         (BuildbotTesterQueueView.prototype._presentPopoverForGenericTestFailures):
2473         Added special handling for dashboard test results.
2474
2475 2017-03-28  Aakash Jain  <aakash_jain@apple.com>
2476
2477         Fix Dashboard test _presentPopoverForJavaScriptCoreTestRegressions
2478         https://bugs.webkit.org/show_bug.cgi?id=170193
2479
2480         Reviewed by Alexey Proskuryakov.
2481
2482         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js:
2483         Fixed the order of arguments.
2484
2485 2017-03-28  Aakash Jain  <aakash_jain@apple.com>
2486
2487         Dashboard tests fails to fetch the revision from commits
2488         https://bugs.webkit.org/show_bug.cgi?id=170191
2489
2490         Reviewed by Alexey Proskuryakov.
2491
2492         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockTrac.js:
2493         Added recordedCommitIndicesByRevisionNumber.
2494         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js:
2495         (setup): Populated trac.recordedCommitIndicesByRevisionNumber since the dashboard code uses this variable.
2496
2497 2017-03-28  Timothy Horton  <timothy_horton@apple.com>
2498
2499         Safari crashes when attempting to close tab that is displaying PDF
2500         https://bugs.webkit.org/show_bug.cgi?id=170201
2501         <rdar://problem/31242019>
2502
2503         Reviewed by Wenson Hsieh.
2504
2505         * TestWebKitAPI/Tests/WebKit2Cocoa/DoAfterNextPresentationUpdateAfterCrash.mm:
2506         (TEST):
2507         Add a test for doAfterNextStablePresentationUpdate just like the existing
2508         non-stable one.
2509
2510 2017-03-28  Jonathan Bedard  <jbedard@apple.com>
2511
2512         webkitpy: Use host pattern for devices
2513         https://bugs.webkit.org/show_bug.cgi?id=170121
2514
2515         Reviewed by Daniel Bates.
2516
2517         Devices should be treated like hosts throughout webkitpy
2518         so that more code can be re-used.  Add the needed properties
2519         and use executive over custom implemented polling/killing
2520         functions.
2521
2522         * Scripts/webkitpy/port/device.py:
2523         (Device):
2524         (Device.executive): Add optional executive property.
2525         (Device.filesystem): Add optional filesystem property.
2526         (Device.user): Add optional user property.
2527         (Device.platform): Add optional platform property.
2528         (Device.workspace): Add optional workspace property.
2529         (Device.poll): Deleted.
2530         * Scripts/webkitpy/port/simulator_process.py:
2531         (SimulatorProcess.Popen.poll): Use the devices executive.
2532         (SimulatorProcess.stop): Ditto.
2533         (SimulatorProcess._kill): Ditto.
2534         * Scripts/webkitpy/xcode/simulated_device.py:
2535         (SimulatedDevice.__init__): Add executive, filesystem, user, platform
2536         and workspace to the platform device.
2537         (SimulatedDevice.poll): Deleted.
2538
2539 2017-03-28  Aakash Jain  <aakash_jain@apple.com>
2540
2541         Dashboard test fails with error: latestIterationGetter is not a function
2542         https://bugs.webkit.org/show_bug.cgi?id=170167
2543
2544         Reviewed by Alexey Proskuryakov.
2545
2546         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js:
2547         (this.view._latestProductiveIteration): Configure _latestProductiveIteration in setup.
2548
2549 2017-03-27  Lucas Forschler  <lforschler@apple.com>
2550
2551         Another test v8.
2552
2553 2017-03-27  Lucas Forschler  <lforschler@apple.com>
2554
2555         Another test v7.
2556
2557 2017-03-27  Lucas Forschler  <lforschler@apple.com>
2558
2559         Another test v6.
2560
2561 2017-03-27  Lucas Forschler  <lforschler@apple.com>
2562
2563         Another test v5.
2564
2565 2017-03-27  Lucas Forschler  <lforschler@apple.com>
2566
2567         Another test v4.
2568
2569 2017-03-27  Lucas Forschler  <lforschler@apple.com>
2570
2571         Another test v3.
2572
2573 2017-03-27  Lucas Forschler  <lforschler@apple.com>
2574
2575         Another test v2.
2576
2577 2017-03-27  Lucas Forschler  <lforschler@apple.com>
2578
2579         Another test.
2580
2581 2017-03-27  Lucas Forschler  <lforschler@apple.com>
2582
2583         <rdar://problem/30949128>
2584         Update build.webkit.org to use port 16000 for PBChangeSource.
2585         
2586         Reviewed by Alexey Proskuryakov.
2587
2588         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2589
2590 2017-03-27  Jason Marcell  <jmarcell@apple.com>
2591
2592         Bots should run the dashboard tests
2593         https://bugs.webkit.org/show_bug.cgi?id=168994
2594
2595         Reviewed by Daniel Bates and David Kilzer.
2596
2597         We pull the `--results-directory` argument value out so that `RunDashboardTests` can override it so that we can separately run the dashboard layout tests.
2598
2599         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2600         (RunWebKitTests): Define a class variable called resultDirectory for the `--results-directory` argument so that subclasses can override this if needed.
2601         (RunWebKitTests.start): Set the `--results-directory` argument value to the value of self.resultDirectory.
2602         (RunDashboardTests): Subclass of RunWebKitTests in which we run the layout tests for the Bot Watcher's Dashboard.
2603         (RunDashboardTests.start): Override the `--layout-tests-directory` to point to the dashboard layout tests.
2604         (ExtractTestResults.addCustomURLs): Update the current results URL label to indicate that it links to layout tests results and add a new link to link to dashboard layout test results.
2605         (TestFactory.__init__): Update unit tests to account for new RunDashboardTests step.
2606         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2607         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2608
2609 2017-03-27  Jonathan Bedard  <jbedard@apple.com>
2610
2611         webkitpy: Look for 'ios' test expectations for IOSPorts
2612         https://bugs.webkit.org/show_bug.cgi?id=169413
2613
2614         Reviewed by Alexey Proskuryakov.
2615
2616         Test expectations for iOS tests should include the 'ios' folder.  Modify
2617         default_baseline_search_path to include 'ios' folder and derivatives for
2618         IOSPort.
2619
2620         * Scripts/webkitpy/port/ios.py:
2621         (IOSPort._generate_all_test_configurations): Moved from IOSSimulatorPort.
2622         (IOSPort.default_baseline_search_path): Add ios expectations along with port specific expectations.
2623         (IOSPort.test_expectations_file_position): Added for testing.
2624         * Scripts/webkitpy/port/ios_simulator.py:
2625         (IOSSimulatorPort._generate_all_test_configurations): Moved to IOSPort.
2626         (IOSSimulatorPort.default_baseline_search_path): Moved to IOSPort.
2627
2628 2017-03-27  Jonathan Bedard  <jbedard@apple.com>
2629
2630         REGRESSION: Reseting _device_map on each child process
2631         <rdar://problem/31274476>
2632
2633         Unreviewed infrastructure fix.
2634
2635         * Scripts/webkitpy/port/ios_simulator.py:
2636         (IOSSimulatorPort): Add _DEVICE_MAP class variable.
2637         (IOSSimulatorPort.__init__): Use shared class variable
2638         (IOSSimulatorPort._device_for_worker_number_map): Use _DEVICE_MAP class variable
2639         (IOSSimulatorPort._create_devices): Ditto.
2640         (IOSSimulatorPort._quit_ios_simulator): Ditto.
2641         (IOSSimulatorPort.clean_up_test_run): Ditto.
2642
2643 2017-03-27  Jonathan Bedard  <jbedard@apple.com>
2644
2645         REGRESSION: Failing to iterate over Simulator.managed_devices map
2646         <rdar://problem/31274476>
2647
2648         Unreviewed infrastructure fix.
2649
2650         * Scripts/webkitpy/port/ios_simulator.py:
2651         (IOSSimulatorPort._create_devices): Iterate through managed_devices by worker number.
2652
2653 2017-03-27  Alex Christensen  <achristensen@webkit.org>
2654
2655         Make WebSockets work in network process
2656         https://bugs.webkit.org/show_bug.cgi?id=169930
2657
2658         Reviewed by Youenn Fablet.
2659
2660         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2661         Add terminateNetworkProcess for the new test
2662         http/tests/websocket/tests/hybi/network-process-crash-error.html
2663         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2664         (WTR::TestRunner::setAllowsAnySSLCertificate):
2665         (WTR::TestRunner::terminateNetworkProcess):
2666         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2667         * WebKitTestRunner/TestController.cpp:
2668         (WTR::TestController::setAllowsAnySSLCertificate):
2669         (WTR::TestController::terminateNetworkProcess):
2670         * WebKitTestRunner/TestController.h:
2671         * WebKitTestRunner/TestInvocation.cpp:
2672         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2673         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2674         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2675         (WTR::TestController::platformContext):
2676         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2677         (WTR::TestController::platformContext):
2678         (WTR::TestController::platformLibraryPathForTesting):
2679         Add some infrastructure for http/tests/websocket/tests/hybi/simple-wss.html
2680         which calls testRunner.setAllowsAnySSLCertificate.  It used to only be effective
2681         for the WebProcess, but SocketStreamHandleImpl::createStreams is now in the NetworkProcess,
2682         and we need its call to Settings::allowsAnySSLCertificate to be loosened for this test,
2683         which tests that wss works, but our test certificate has an invalid certificate chain.
2684         We want production software to not have the ability to have its security weakened, so this
2685         is a test code path that is only implemented in WebKitTestRunner.
2686
2687 2017-03-25  Jonathan Bedard  <jbedard@apple.com>
2688
2689         webkitpy: Use generalized device instead of platform specific one
2690         https://bugs.webkit.org/show_bug.cgi?id=170078
2691
2692         Reviewed by Daniel Bates.
2693
2694         SimulatedDevice is re-created each time 'xcrun simctl list' is called.  Device
2695         should remain persistent.  Changing Device to a more explicit interface.
2696         SimulatedDevice no longer inherits from Device and IOSSimulator returns Devices
2697         wrapping SimulatedDevices.
2698
2699         * Scripts/webkitpy/port/device.py: Added.
2700         (Device):
2701         (Device.__init__): Construct with platform device.
2702         (Device.install_app): Install app at app path on platform device.
2703         (Device.launch_app): Launch app with bundle ID on platform device.
2704         (Device.poll): Poll platform device.
2705         (Device.udid): Access platform device UDID.
2706         (Device.__nonzero__): Check if instantiated with a valid platform device.
2707         (Device.__eq__): Compare by udid.
2708         (Device.__ne__): Ditto.
2709         (Device.__repr__): Print out platform_device representation.
2710         * Scripts/webkitpy/port/ios_simulator.py:
2711         (IOSSimulatorPort.__init__): Initialize the _device_map to an empty dictionary.
2712         (IOSSimulatorPort._device_for_worker_number_map):  Return self._device_map.
2713         (IOSSimulatorPort._create_simulators): Call Simulator.managed_devices directly.
2714         (IOSSimulatorPort._create_devices): Place Simulator.managed_devices into the
2715         device map.
2716         (IOSSimulatorPort._quit_ios_simulator): Reset self._device_map.
2717         * Scripts/webkitpy/xcode/device.py: Removed.
2718         * Scripts/webkitpy/xcode/simulated_device.py:
2719         (SimulatedDevice):
2720         (SimulatedDevice.__init__): Move host, name and did to SimulatedDevice.
2721         (SimulatedDevice.__eq__): Compare two simulated devices.
2722         (SimulatedDevice.__ne__): Ditto.
2723         (SimulatedDevice.__repr__): Print name and udid.
2724
2725 2017-03-25  Adrian Perez de Castro  <aperez@igalia.com>
2726
2727         [GTK] No value returned from PrintCustomWidgetTest::createWebKitPrintOperation() in TestPrinting.cpp
2728         https://bugs.webkit.org/show_bug.cgi?id=170059
2729
2730         Reviewed by Carlos Garcia Campos.
2731
2732         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp: Use "void" as return type in the declaration,
2733         the only use of the method in this same file ignores the returned value anyway.
2734
2735 2017-03-24  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
2736
2737         webkitpy should be able to run API tests
2738         https://bugs.webkit.org/show_bug.cgi?id=170028
2739
2740         Reviewed by Alexey Proskuryakov.
2741
2742         * Scripts/webkitpy/common/config/ports.py:
2743         (DeprecatedPort.run_api_tests_command): Added.
2744         * Scripts/webkitpy/port/base.py:
2745         (Port.api_results_directory): Added.
2746         * Scripts/webkitpy/tool/steps/runtests.py:
2747         (RunTests.run): Check if we should be running API tests.
2748         (RunTests._run_api_tests): Generate script to run API tests with json output.
2749         * Scripts/webkitpy/tool/steps/steps_unittest.py: Unit tests.
2750
2751 2017-03-24  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
2752
2753         Add JSON results for API tests
2754         https://bugs.webkit.org/show_bug.cgi?id=170021
2755
2756         Reviewed by Alexey Proskuryakov.
2757
2758         * Scripts/run-api-tests:
2759         (runTestsBySuite): Appends failures and timeouts to JSON data.
2760         (writeJsonDataIfApplicable): Writes JSON data to a file.
2761
2762 2017-03-24  Lucas Forschler  <lforschler@apple.com>
2763
2764         update committer_auth.py to be python 2.7 compliant
2765         https://bugs.webkit.org/show_bug.cgi?id=170063
2766         
2767         Reviewed by Alexey Proskuryakov.
2768
2769         * BuildSlaveSupport/build.webkit.org-config/committer_auth.py:
2770         (CommitterAuth.authenticate):
2771             convert e.message to e.args[0]
2772
2773 2017-03-24  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
2774
2775         webkitpy: Parse JSON results from run-api-tests
2776         https://bugs.webkit.org/show_bug.cgi?id=170062
2777
2778         Reviewed by Alexey Proskuryakov.
2779
2780         * Scripts/webkitpy/common/net/apitestresults.py: Added.
2781         (APITestResults): Structure to represent API test results.
2782         (APITestResults.__init__):
2783         (APITestResults.intersection): Return the failures common to both sets of results.
2784         (APITestResults.results_from_string): Create an APITestResults object from a JSON results string.
2785         (APITestResults.equals): Return True if both results were the same.
2786         (APITestResults.is_subset): Return True if failing tests are a subset of the other failing tests.
2787         (APITestResults.all_passed): Return True if everything passed.
2788         (APITestResults.failing_tests): List of tests that didn't pass.
2789         (APITestResults.did_exceed_test_failure_limit): Always False.
2790         * Scripts/webkitpy/common/net/apitestresults_unittest.py: Added.
2791         (APITestResultsTest): Unit tests.
2792         * Scripts/webkitpy/tool/bot/apitestresultsreader.py: Added.
2793         (APITestResultsReader): Read contents of JSON results file.
2794
2795 2017-03-24  Alex Christensen  <achristensen@webkit.org>
2796
2797         REGRESSION: Content Blocker: Blocking "a[href*=randomString]" doesn't work
2798         https://bugs.webkit.org/show_bug.cgi?id=169167
2799
2800         Reviewed by Simon Fraser.
2801
2802         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2803         (TestWebKitAPI::TEST_F):
2804         Test an example of a selector that was incorrectly determined to be invalid.
2805
2806 2017-03-24  Jonathan Bedard  <jbedard@apple.com>
2807
2808         Increase timeout for booting simulators.
2809         <rdar://problem/31080009>
2810
2811         Unreviewed infrastructure fix.
2812
2813         * Scripts/webkitpy/xcode/simulator.py:
2814         (Simulator.wait_until_device_is_booted): Increase timeout.
2815         (Simulator.wait_until_device_is_in_state): Increase timeout.
2816
2817 2017-03-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2818
2819         Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/javascript-dialogs after r214277.
2820
2821         Since r214277 beforeunload events are not fired unless there's some user interaction, so we need to simulate it
2822         in our unit tests to work.
2823
2824         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
2825         (testWebViewJavaScriptDialogs):
2826
2827 2017-03-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2828
2829         [GTK] Add MIMETypeRegistry implementation using xdgmime and remove the GTK+ one
2830         https://bugs.webkit.org/show_bug.cgi?id=170001
2831
2832         Reviewed by Michael Catanzaro.
2833
2834         Ignore style of xdgmime sources.
2835
2836         * Scripts/webkitpy/tool/steps/checkstyle.py:
2837
2838 2017-03-23  Wenson Hsieh  <wenson_hsieh@apple.com>
2839
2840         Dragging on a large image should not revert to a file icon if data interaction is enabled
2841         https://bugs.webkit.org/show_bug.cgi?id=170018
2842         <rdar://problem/31184508>
2843
2844         Reviewed by Tim Horton.
2845
2846         Add new tests for data interaction. LargeImageToTargetDiv verifies the change made in this patch, while
2847         AttachmentElementItemProviders was a test that was previously removed due to <rdar://problem/31038797>.
2848
2849         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2850         * TestWebKitAPI/Tests/WebKit2Cocoa/large-red-square.png: Added.
2851         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2852         (TestWebKitAPI::TEST):
2853
2854 2017-03-23  Fujii Hironori  <Hironori.Fujii@sony.com>
2855
2856         Update WinCairoRequirements.zip
2857         https://bugs.webkit.org/show_bug.cgi?id=169950
2858
2859         Reviewed by Alex Christensen.
2860
2861         * Scripts/update-webkit-wincairo-libs: Replace $winCairoLibsURL.
2862
2863 == Rolled over to ChangeLog-2017-03-23 ==