Remove ENABLE(JAVASCRIPT_DEBUGGER) guards
[WebKit-https.git] / Tools / ChangeLog
1 2014-01-29  Csaba Osztrogonác  <ossy@webkit.org>
2
3         Remove ENABLE(JAVASCRIPT_DEBUGGER) guards
4         https://bugs.webkit.org/show_bug.cgi?id=127840
5
6         Reviewed by Mark Lam.
7
8         * Scripts/webkitperl/FeatureList.pm:
9
10 2014-01-29  Krzysztof Czech  <k.czech@samsung.com>
11
12         [ATK] Expose aria-describedby with ATK_RELATION_DESCRIBED_BY
13         https://bugs.webkit.org/show_bug.cgi?id=121684
14
15         Reviewed by Mario Sanchez Prada.
16
17         Implementing helpText by using relation ATK_RELATION_DESCRIBED_BY.
18
19         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
20         (AccessibilityUIElement::helpText):
21         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
22         (WTR::AccessibilityUIElement::helpText):
23
24 2014-01-27  Chris Fleizach  <cfleizach@apple.com>
25
26         AX: Support @scope in HTML tables
27         https://bugs.webkit.org/show_bug.cgi?id=127688
28
29         Reviewed by Mario Sanchez Prada.
30
31         Add support for rowHeaders and columnHeaders.
32
33         * DumpRenderTree/AccessibilityUIElement.cpp:
34         (convertElementsToObjectArray):
35         (columnHeadersCallback):
36         (rowHeadersCallback):
37         (uiElementArrayAttributeValueCallback):
38         (AccessibilityUIElement::columnHeaders):
39         (AccessibilityUIElement::rowHeaders):
40         (AccessibilityUIElement::getJSClass):
41         * DumpRenderTree/AccessibilityUIElement.h:
42         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
43         (AccessibilityUIElement::rowHeaders):
44         (AccessibilityUIElement::columnHeaders):
45         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
46         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
47         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
48         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue):
49         (WTR::AccessibilityUIElement::rowHeaders):
50         (WTR::AccessibilityUIElement::columnHeaders):
51         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
52         (WTR::convertElementsToObjectArray):
53         (WTR::AccessibilityUIElement::rowHeaders):
54         (WTR::AccessibilityUIElement::columnHeaders):
55         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue):
56
57 2014-01-28  Daniel Bates  <dabates@apple.com>
58
59         Teach Buildbot dashboard to parse alternative revision format
60         https://bugs.webkit.org/show_bug.cgi?id=127561
61
62         Reviewed by Alexey Proskuryakov.
63
64         Add support for extracting the OpenSource and Internal revision numbers when Buildbot
65         returns a dictionary for the value of property got_revision.
66
67         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
68         (isMultiCodebaseGotRevisionProperty): Added.
69         (parseRevisionProperty): Added; parses Buildbot revision property, which can either be a
70         string or a dictionary.
71         (BuildbotIteration.prototype.update.): Modified to call parseRevisionProperty() to determine
72         the OpenSource and Internal revision numbers.
73
74 2014-01-28  Adrian Perez de Castro  <aperez@igalia.com>
75
76         [GTK] Add API to allow setting the process model in WebKitWebContext
77         https://bugs.webkit.org/show_bug.cgi?id=125463
78
79         Reviewed by Carlos Garcia Campos.
80
81         Implements accessors in WebKitWebContext for the process model.
82         The default behavior is unchanged, and a single web process is
83         used. Using WEBKIT_PROCESS_MODEL_ONE_SECONDARY_PROCESS_PER_WEB_VIEW
84         as the process model will make use one web process for each
85         WebKitWebView. This also enables the network process. Setting
86         the process model must be done as early as possible, before the
87         very first web process is spawned.
88
89         * MiniBrowser/gtk/main.c:
90         (main):
91         Enable multiple process mode if the MINIBROWSER_MULTIPROCESS
92         environment variable is defined and not empty.
93         * TestWebKitAPI/GNUmakefile.am:
94         Add new TestMultiprocess test case.
95         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
96         Add new TestMultiprocess test case.
97         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp: Added.
98         (loadChanged):
99         (testMultipleSecondaryProcesses):
100         (initializeWebExtensions):
101         (beforeAll):
102         (afterAll):
103         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
104         (methodCallCallback):
105         Implement the GetProcessIdentifier D-Bus method.
106         (makeBusName):
107         Choose a different bus name when the web extension is used
108         from TestMultiprocess.
109         (webkit_web_extension_initialize_with_user_data):
110         Use makeBusName() to choose the bus name.
111
112 2014-01-28  Carlos Garcia Campos  <cgarcia@igalia.com>
113
114         [SOUP] Remove soupURIToKURL
115         https://bugs.webkit.org/show_bug.cgi?id=127104
116
117         Reviewed by Martin Robinson.
118
119         * TestWebKitAPI/GNUmakefile.am: Add soup cppflags to WebCore unit
120         tests, because URL.h now includes GUniquePtrSoup.h.
121         * TestWebKitAPI/CMakeLists.txt: Ditto.
122         * WebKitTestRunner/PlatformEfl.cmake: Add soup cppflags to WTR,
123         because URL.h now includes GUniquePtrSoup.h.
124
125 2014-01-27  Carlos Garcia Campos  <cgarcia@igalia.com>
126
127         [GTK] Make webkit_uri_scheme_request_get_web_view() work with CustomProtocols
128         https://bugs.webkit.org/show_bug.cgi?id=127614
129
130         Reviewed by Gustavo Noronha Silva.
131
132         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp: Bring
133         back the custom URI scheme WebView check.
134
135 2014-01-27  Tim Horton  <timothy_horton@apple.com>
136
137         Revert yet one more tiny part of r162629 that didn't get reverted in r162883
138
139         * WebKitTestRunner/TestController.cpp:
140         (WTR::TestController::pluginLoadPolicy):
141         * WebKitTestRunner/TestController.h:
142
143 2014-01-27  Tim Horton  <timothy_horton@apple.com>
144
145         Revert one more tiny part of r162629 that didn't get reverted in r162883.
146
147         ... which was also causing test failures!
148
149         * WebKitTestRunner/TestController.cpp:
150         (WTR::TestController::createWebViewWithOptions):
151
152 2014-01-27  David Farler  <dfarler@apple.com>
153
154         iOS DumpRenderTree.app dies loading fonts
155         https://bugs.webkit.org/show_bug.cgi?id=127730
156
157         Reviewed by Daniel Bates.
158
159         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
160         - Add Ahem to the __DATA section
161         * DumpRenderTree/mac/DumpRenderTree.mm:
162         (activateFontsIOS):
163         - Load "WeightWatcher100" instead.
164
165 2014-01-27  Alexey Proskuryakov  <ap@apple.com>
166
167         [Mac] Extra logging output from run-safari --no-saved-state
168         https://bugs.webkit.org/show_bug.cgi?id=127732
169
170         Reviewed by Daniel Bates.
171
172         * Scripts/webkitdirs.pm: (argumentsForRunAndDebugMacWebKitApp): Use an option that
173         disables saved state without logging.
174
175 2014-01-27  Tim Horton  <timothy_horton@apple.com>
176
177         Revert the parts of r162629 that add a new pluginLoadPolicy and the context menu item.
178
179         We're leaving the parts that make us use PDFPlugin instead of showing the blocked
180         plugin indicator intact, though.
181
182         * WebKitTestRunner/TestController.cpp:
183         (WTR::TestController::createWebViewWithOptions):
184
185 2014-01-27  Andy Estes  <aestes@apple.com>
186
187         Scrub WebKit API headers of WTF macros
188         https://bugs.webkit.org/show_bug.cgi?id=127706
189
190         Reviewed by David Kilzer.
191
192         * Scripts/check-for-inappropriate-macros-in-external-headers: Modified
193         the regex to require a '(' after the macro name in order to be
194         considered a match. This prevents things like 'ENABLE_SOME_FEATURE'
195         from being flagged as an ENABLE() macro.
196
197 2014-01-27  Commit Queue  <commit-queue@webkit.org>
198
199         Unreviewed, rolling out r162846.
200         http://trac.webkit.org/changeset/162846
201         https://bugs.webkit.org/show_bug.cgi?id=127695
202
203         "Broke the WebKit Bot Watcher's Dashboard; will fix offline"
204         (Requested by dydz on #webkit).
205
206         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
207         (BuildbotIteration.prototype.update.):
208
209 2014-01-27  Daniel Bates  <dabates@apple.com>
210
211         Add support for displaying results from multiple Buildbots on WebKit Bot Watcher's Dashboard
212         https://bugs.webkit.org/show_bug.cgi?id=127564
213
214         Reviewed by Alexey Proskuryakov.
215
216         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
217         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
218
219 2014-01-27  Daniel Bates  <dabates@apple.com>
220
221         Teach Buildbot dashboard to parse alternative revision format
222         https://bugs.webkit.org/show_bug.cgi?id=127561
223
224         Reviewed by Alexey Proskuryakov.
225
226         Add support for extracting the OpenSource and Internal revision numbers when Buildbot
227         returns a dictionary for the value of property got_revision.
228
229         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
230         (parseRevisionProperty): Added; parses Buildbot revision property, which can either be a
231         string or a dictionary.
232         (BuildbotIteration.prototype.update.): Modified to call parseRevisionProperty() to determine
233         the OpenSource and Internal revision numbers.
234
235 2014-01-27  Carlos Garcia Campos  <cgarcia@igalia.com>
236
237         [GTK] Implement custom URI schemes with CustomProtocols
238         https://bugs.webkit.org/show_bug.cgi?id=127091
239
240         Reviewed by Gustavo Noronha Silva.
241
242         Temporarily disable the WebKitWebView check until we figure out
243         how to implement it with CustomProtocols.
244
245         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
246
247 2014-01-26  Alexey Proskuryakov  <ap@apple.com>
248
249         REGRESSION(r127412): http/tests/misc/link-rel-icon-beforeload.html is broken.
250
251         * DumpRenderTree/mac/TestRunnerMac.mm: (TestRunner::setIconDatabaseEnabled):
252         Fixed an incorrect ifdef.
253
254 2014-01-26  Brendan Long  <b.long@cablelabs.com>
255
256         [GTK] DumpRenderTree prints out suggesting to set WEBKIT_TOP_LEVEL when fonts are missing but doesn't use it.
257         https://bugs.webkit.org/show_bug.cgi?id=110602
258
259         Reviewed by Philippe Normand.
260
261         * DumpRenderTree/gtk/DumpRenderTree.cpp:
262         (getTopLevelPath): Use WEBKIT_TOP_LEVEL environment variable if it exists.
263         (initializeFonts): Fix printing of expected font path (fontPath is guaranteed to be null here).
264
265 2014-01-24  Andy Estes  <aestes@apple.com>
266
267         [iOS] Upstream changes in Tools/DumpRenderTree
268         https://bugs.webkit.org/show_bug.cgi?id=127412
269
270         Reviewed by Simon Fraser.
271
272         Upstream all iOS changes. Added a new target called DumpRenderTree.app,
273         which builds the DumpRenderTree static library into an app bundle as
274         expected by the iOS Simulator.
275
276         * DumpRenderTree/AccessibilityTextMarker.h:
277         * DumpRenderTree/AccessibilityUIElement.h:
278         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
279         * DumpRenderTree/DumpRenderTreeFileDraggingSource.h:
280         * DumpRenderTree/DumpRenderTreePrefix.h:
281         * DumpRenderTree/PixelDumpSupport.cpp:
282         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
283         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
284         * DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm:
285         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
286         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
287         * DumpRenderTree/TestNetscapePlugIn/TestObject.cpp:
288         * DumpRenderTree/TestNetscapePlugIn/TestObject.h:
289         * DumpRenderTree/TestNetscapePlugIn/Tests/DocumentOpenInDestroyStream.cpp:
290         * DumpRenderTree/TestNetscapePlugIn/Tests/EvaluateJSAfterRemovingPluginElement.cpp:
291         * DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp:
292         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeObjectFromDestroyedPlugin.cpp:
293         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeRemoveProperty.cpp:
294         * DumpRenderTree/TestNetscapePlugIn/Tests/NullNPPGetValuePointer.cpp:
295         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
296         * DumpRenderTree/TestNetscapePlugIn/Tests/PluginScriptableNPObjectInvokeDefault.cpp:
297         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
298         * DumpRenderTree/TestRunner.cpp:
299         * DumpRenderTree/TestRunner.h:
300         * DumpRenderTree/cg/ImageDiffCG.cpp:
301         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
302         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
303         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
304         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h: Added.
305         * DumpRenderTree/ios/DumpRenderTreeBrowserView.mm: Added.
306         * DumpRenderTree/ios/Info.plist: Added.
307         * DumpRenderTree/ios/PerlSupport/DumpRenderTreeSupport.c: Added.
308         * DumpRenderTree/ios/PerlSupport/DumpRenderTreeSupportPregenerated.pm: Added.
309         * DumpRenderTree/ios/PerlSupport/DumpRenderTreeSupport_wrapPregenerated.c: Added.
310         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Changes: Added.
311         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/IPhoneSimulatorNotification.xs: Added.
312         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/MANIFEST: Added.
313         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Makefile.PL: Added.
314         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/README: Added.
315         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm: Added.
316         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/ppport.h: Added.
317         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/t/IPhoneSimulatorNotification.t: Added.
318         * DumpRenderTree/ios/PerlSupport/Makefile: Added.
319         * DumpRenderTree/ios/PixelDumpSupportIOS.mm: Added.
320         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
321         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
322         * DumpRenderTree/mac/AppleScriptController.m:
323         * DumpRenderTree/mac/Configurations/Base.xcconfig:
324         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
325         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
326         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig: Added.
327         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig:
328         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig:
329         * DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig: Added.
330         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig:
331         * DumpRenderTree/mac/DumpRenderTree.mm:
332         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
333         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
334         * DumpRenderTree/mac/DumpRenderTreeMac.h:
335         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
336         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
337         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
338         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
339         * DumpRenderTree/mac/EditingDelegate.h:
340         * DumpRenderTree/mac/EventSendingController.h:
341         * DumpRenderTree/mac/EventSendingController.mm:
342         * DumpRenderTree/mac/FrameLoadDelegate.mm:
343         * DumpRenderTree/mac/HistoryDelegate.h:
344         * DumpRenderTree/mac/LayoutTestHelper.m:
345         * DumpRenderTree/mac/MockGeolocationProvider.mm:
346         * DumpRenderTree/mac/NavigationController.h:
347         * DumpRenderTree/mac/ObjCPlugin.h:
348         * DumpRenderTree/mac/ObjCPlugin.m:
349         * DumpRenderTree/mac/ObjCPluginFunction.h:
350         * DumpRenderTree/mac/PolicyDelegate.h:
351         * DumpRenderTree/mac/ResourceLoadDelegate.h:
352         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
353         * DumpRenderTree/mac/TestRunnerMac.mm:
354         * DumpRenderTree/mac/TextInputController.h:
355         * DumpRenderTree/mac/TextInputController.m:
356         * DumpRenderTree/mac/UIDelegate.h:
357         * DumpRenderTree/mac/UIDelegate.mm:
358
359 2014-01-25  Darin Adler  <darin@apple.com>
360
361         Call deprecatedCharacters instead of characters at more call sites
362         https://bugs.webkit.org/show_bug.cgi?id=127631
363
364         Reviewed by Sam Weinig.
365
366         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
367         (TestWebKitAPI::expectBuilderContent):
368         (TestWebKitAPI::expectEmpty):
369         (TestWebKitAPI::TEST):
370         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
371         (TestWebKitAPI::TEST):
372         Use the new name.
373
374 2014-01-25  Anders Carlsson  <andersca@apple.com>
375
376         Modernize HashTable threading code
377         https://bugs.webkit.org/show_bug.cgi?id=127621
378
379         Reviewed by Darin Adler.
380
381         Explicitly include headers that used to be brought in by HashTable.h
382
383         * DumpRenderTree/JavaScriptThreading.cpp:
384
385 2014-01-24  Eric Carlson  <eric.carlson@apple.com>
386
387         Unreviewed. Add Philip Jägenstedt to watch and contributor lists.
388
389         * Scripts/webkitpy/common/config/contributors.json:
390         * Scripts/webkitpy/common/config/watchlist:
391
392 2014-01-23  David Farler  <dfarler@apple.com>
393
394         Make WebKitTestRunner work with iOS
395         https://bugs.webkit.org/show_bug.cgi?id=127448
396
397         Reviewed by Simon Fraser.
398
399         Combined patch from Simon below with some additional xcconfig cleanups,
400         rebasing and stubbing out a couple of new functions that popped up
401         since then.
402
403         2013-12-03  Simon Fraser  <simon.fraser@apple.com>
404
405                 <rdar://problem/15515469> Get WebKitTestRunner working on iOS
406
407                 Get WebKitTestRunner limping on iOS. Main parts:
408                 - Stub out lots of accessibility-related functions.
409                 - Stub out EventSender
410                 - Create target to make a bundled app that runs in the simulator,
411                   and copy the injected bundle library into it.
412                 - Make a UIWindow and WKView to load tests in
413
414                 It runs, load tests, and dumps results to output. More work will be
415                 required once we can execute it via the webkitpy scripts.
416
417         * WebKitTestRunner/Configurations/Base.xcconfig:
418         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
419         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
420         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
421         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm: Added.
422         (WTR::AccessibilityController::addNotificationListener):
423         (WTR::AccessibilityController::removeNotificationListener):
424         (WTR::AccessibilityController::platformName):
425         (WTR::AccessibilityController::logAccessibilityEvents):
426         (WTR::AccessibilityController::resetToConsistentState):
427         (WTR::findAccessibleObjectById):
428         (WTR::AccessibilityController::accessibleElementById):
429         * WebKitTestRunner/InjectedBundle/ios/AccessibilityNotificationHandler.h: Added.
430         * WebKitTestRunner/InjectedBundle/ios/AccessibilityTextMarkerIOS.mm: Copied from Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h.
431         (WTR::AccessibilityTextMarker::isEqual):
432         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm: Added.
433         (WTR::AccessibilityUIElement::AccessibilityUIElement):
434         (WTR::AccessibilityUIElement::~AccessibilityUIElement):
435         (WTR::AccessibilityUIElement::isEqual):
436         (WTR::AccessibilityUIElement::getLinkedUIElements):
437         (WTR::AccessibilityUIElement::getDocumentLinks):
438         (WTR::AccessibilityUIElement::getChildren):
439         (WTR::AccessibilityUIElement::getChildrenWithRange):
440         (WTR::AccessibilityUIElement::childrenCount):
441         (WTR::AccessibilityUIElement::elementAtPoint):
442         (WTR::AccessibilityUIElement::indexOfChild):
443         (WTR::AccessibilityUIElement::childAtIndex):
444         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
445         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
446         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
447         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
448         (WTR::AccessibilityUIElement::rowAtIndex):
449         (WTR::AccessibilityUIElement::selectedChildAtIndex):
450         (WTR::AccessibilityUIElement::selectedChildrenCount):
451         (WTR::AccessibilityUIElement::selectedRowAtIndex):
452         (WTR::AccessibilityUIElement::titleUIElement):
453         (WTR::AccessibilityUIElement::parentElement):
454         (WTR::AccessibilityUIElement::disclosedByRow):
455         (WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
456         (WTR::AccessibilityUIElement::attributesOfDocumentLinks):
457         (WTR::AccessibilityUIElement::attributesOfChildren):
458         (WTR::AccessibilityUIElement::allAttributes):
459         (WTR::AccessibilityUIElement::stringAttributeValue):
460         (WTR::AccessibilityUIElement::numberAttributeValue):
461         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue):
462         (WTR::AccessibilityUIElement::uiElementAttributeValue):
463         (WTR::AccessibilityUIElement::boolAttributeValue):
464         (WTR::AccessibilityUIElement::isAttributeSettable):
465         (WTR::AccessibilityUIElement::isAttributeSupported):
466         (WTR::AccessibilityUIElement::parameterizedAttributeNames):
467         (WTR::AccessibilityUIElement::role):
468         (WTR::AccessibilityUIElement::subrole):
469         (WTR::AccessibilityUIElement::roleDescription):
470         (WTR::AccessibilityUIElement::title):
471         (WTR::AccessibilityUIElement::description):
472         (WTR::AccessibilityUIElement::orientation):
473         (WTR::AccessibilityUIElement::stringValue):
474         (WTR::AccessibilityUIElement::language):
475         (WTR::AccessibilityUIElement::helpText):
476         (WTR::AccessibilityUIElement::x):
477         (WTR::AccessibilityUIElement::y):
478         (WTR::AccessibilityUIElement::width):
479         (WTR::AccessibilityUIElement::height):
480         (WTR::AccessibilityUIElement::clickPointX):
481         (WTR::AccessibilityUIElement::clickPointY):
482         (WTR::AccessibilityUIElement::intValue):
483         (WTR::AccessibilityUIElement::minValue):
484         (WTR::AccessibilityUIElement::maxValue):
485         (WTR::AccessibilityUIElement::valueDescription):
486         (WTR::AccessibilityUIElement::insertionPointLineNumber):
487         (WTR::AccessibilityUIElement::isPressActionSupported):
488         (WTR::AccessibilityUIElement::isIncrementActionSupported):
489         (WTR::AccessibilityUIElement::isDecrementActionSupported):
490         (WTR::AccessibilityUIElement::isEnabled):
491         (WTR::AccessibilityUIElement::isRequired):
492         (WTR::AccessibilityUIElement::isFocused):
493         (WTR::AccessibilityUIElement::isSelected):
494         (WTR::AccessibilityUIElement::isSelectedOptionActive):
495         (WTR::AccessibilityUIElement::isIndeterminate):
496         (WTR::AccessibilityUIElement::isExpanded):
497         (WTR::AccessibilityUIElement::isChecked):
498         (WTR::AccessibilityUIElement::hierarchicalLevel):
499         (WTR::AccessibilityUIElement::classList):
500         (WTR::AccessibilityUIElement::speak):
501         (WTR::AccessibilityUIElement::ariaIsGrabbed):
502         (WTR::AccessibilityUIElement::ariaDropEffects):
503         (WTR::AccessibilityUIElement::lineForIndex):
504         (WTR::AccessibilityUIElement::rangeForLine):
505         (WTR::AccessibilityUIElement::rangeForPosition):
506         (WTR::AccessibilityUIElement::boundsForRange):
507         (WTR::AccessibilityUIElement::stringForRange):
508         (WTR::AccessibilityUIElement::attributedStringForRange):
509         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
510         (WTR::uiElementCountForSearchPredicate):
511         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
512         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
513         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
514         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
515         (WTR::AccessibilityUIElement::attributesOfColumns):
516         (WTR::AccessibilityUIElement::attributesOfRows):
517         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
518         (WTR::AccessibilityUIElement::attributesOfHeader):
519         (WTR::AccessibilityUIElement::rowCount):
520         (WTR::AccessibilityUIElement::columnCount):
521         (WTR::AccessibilityUIElement::indexInTable):
522         (WTR::AccessibilityUIElement::rowIndexRange):
523         (WTR::AccessibilityUIElement::columnIndexRange):
524         (WTR::AccessibilityUIElement::cellForColumnAndRow):
525         (WTR::AccessibilityUIElement::horizontalScrollbar):
526         (WTR::AccessibilityUIElement::verticalScrollbar):
527         (WTR::AccessibilityUIElement::scrollToMakeVisible):
528         (WTR::AccessibilityUIElement::selectedTextRange):
529         (WTR::AccessibilityUIElement::setSelectedTextRange):
530         (WTR::AccessibilityUIElement::increment):
531         (WTR::AccessibilityUIElement::decrement):
532         (WTR::AccessibilityUIElement::showMenu):
533         (WTR::AccessibilityUIElement::press):
534         (WTR::AccessibilityUIElement::setSelectedChild):
535         (WTR::AccessibilityUIElement::accessibilityValue):
536         (WTR::AccessibilityUIElement::documentEncoding):
537         (WTR::AccessibilityUIElement::documentURI):
538         (WTR::AccessibilityUIElement::url):
539         (WTR::AccessibilityUIElement::addNotificationListener):
540         (WTR::AccessibilityUIElement::removeNotificationListener):
541         (WTR::AccessibilityUIElement::isFocusable):
542         (WTR::AccessibilityUIElement::isSelectable):
543         (WTR::AccessibilityUIElement::isMultiSelectable):
544         (WTR::AccessibilityUIElement::isVisible):
545         (WTR::AccessibilityUIElement::isOffScreen):
546         (WTR::AccessibilityUIElement::isCollapsed):
547         (WTR::AccessibilityUIElement::isIgnored):
548         (WTR::AccessibilityUIElement::hasPopup):
549         (WTR::AccessibilityUIElement::takeFocus):
550         (WTR::AccessibilityUIElement::takeSelection):
551         (WTR::AccessibilityUIElement::addSelection):
552         (WTR::AccessibilityUIElement::removeSelection):
553         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
554         (WTR::AccessibilityUIElement::textMarkerRangeLength):
555         (WTR::AccessibilityUIElement::previousTextMarker):
556         (WTR::AccessibilityUIElement::nextTextMarker):
557         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
558         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
559         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
560         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
561         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
562         (WTR::AccessibilityUIElement::startTextMarkerForBounds):
563         (WTR::AccessibilityUIElement::textMarkerForPoint):
564         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
565         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
566         (WTR::AccessibilityUIElement::indexForTextMarker):
567         (WTR::AccessibilityUIElement::isTextMarkerValid):
568         (WTR::AccessibilityUIElement::textMarkerForIndex):
569         (WTR::AccessibilityUIElement::startTextMarker):
570         (WTR::AccessibilityUIElement::endTextMarker):
571         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
572         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
573         (WTR::AccessibilityUIElement::pathDescription):
574         (WTR::AccessibilityUIElement::supportedActions):
575         * WebKitTestRunner/InjectedBundle/ios/ActivateFontsIOS.mm: Copied from Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h.
576         (WTR::activateFonts):
577         * WebKitTestRunner/InjectedBundle/ios/EventSenderProxyIOS.mm: Added.
578         (WTR::EventSenderProxy::EventSenderProxy):
579         (WTR::EventSenderProxy::~EventSenderProxy):
580         (WTR::EventSenderProxy::updateClickCountForButton):
581         (WTR::EventSenderProxy::mouseDown):
582         (WTR::EventSenderProxy::mouseUp):
583         (WTR::EventSenderProxy::mouseMoveTo):
584         (WTR::EventSenderProxy::leapForward):
585         (WTR::EventSenderProxy::keyDown):
586         (WTR::EventSenderProxy::mouseScrollBy):
587         (WTR::EventSenderProxy::continuousMouseScrollBy):
588         (WTR::EventSenderProxy::addTouchPoint):
589         (WTR::EventSenderProxy::updateTouchPoint):
590         (WTR::EventSenderProxy::setTouchModifier):
591         (WTR::EventSenderProxy::setTouchPointRadius):
592         (WTR::EventSenderProxy::touchStart):
593         (WTR::EventSenderProxy::touchMove):
594         (WTR::EventSenderProxy::touchEnd):
595         (WTR::EventSenderProxy::touchCancel):
596         (WTR::EventSenderProxy::clearTouchPoints):
597         (WTR::EventSenderProxy::releaseTouchPoint):
598         (WTR::EventSenderProxy::cancelTouchPoint):
599         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm: Copied from Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h.
600         (WTR::InjectedBundle::platformInitialize):
601         * WebKitTestRunner/InjectedBundle/ios/InjectedBundlePageIOS.mm: Copied from Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h.
602         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
603         * WebKitTestRunner/Makefile:
604         * WebKitTestRunner/TestController.cpp:
605         (WTR::TestController::initialize):
606         * WebKitTestRunner/TestController.h:
607         * WebKitTestRunner/TestInvocation.cpp:
608         (WTR::TestInvocation::invoke):
609         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
610         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
611         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Added.
612         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Added.
613         (-[AppDelegate application:didFinishLaunchingWithOptions:]):
614         (-[AppDelegate applicationWillResignActive:]):
615         (-[AppDelegate applicationDidEnterBackground:]):
616         (-[AppDelegate applicationWillEnterForeground:]):
617         (-[AppDelegate applicationDidBecomeActive:]):
618         (-[AppDelegate applicationWillTerminate:]):
619         * WebKitTestRunner/WebKitTestRunnerApp/Images.xcassets/AppIcon.appiconset/Contents.json: Added.
620         * WebKitTestRunner/WebKitTestRunnerApp/Images.xcassets/LaunchImage.launchimage/Contents.json: Added.
621         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist: Added.
622         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Prefix.pch: Added.
623         * WebKitTestRunner/WebKitTestRunnerApp/en.lproj/InfoPlist.strings: Added.
624         * WebKitTestRunner/WebKitTestRunnerApp/main.m: Added.
625         (main):
626         * WebKitTestRunner/WebKitTestRunnerAppTests-Info.plist: Added.
627         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests-Info.plist: Added.
628         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests.m: Added.
629         (-[WebKitTestRunnerAppTests setUp]):
630         (-[WebKitTestRunnerAppTests tearDown]):
631         (-[WebKitTestRunnerAppTests testExample]):
632         * WebKitTestRunner/WebKitTestRunnerAppTests/en.lproj/InfoPlist.strings: Added.
633         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
634         * WebKitTestRunner/cg/TestInvocationCG.cpp:
635         * WebKitTestRunner/iOS.xcconfig: Added.
636         * WebKitTestRunner/ios/PlatformWebViewIOS.mm: Added.
637         (-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:relatedToPage:useTiledDrawing:]):
638         (-[TestRunnerWKView _shouldUseTiledDrawingArea]):
639         (-[WebKitTestRunnerWindow isKeyWindow]):
640         (-[WebKitTestRunnerWindow setFrameOrigin:]):
641         (-[WebKitTestRunnerWindow setFrame:]):
642         (-[WebKitTestRunnerWindow frameRespectingFakeOrigin]):
643         (-[WebKitTestRunnerWindow backingScaleFactor]):
644         (WTR::PlatformWebView::PlatformWebView):
645         (WTR::PlatformWebView::resizeTo):
646         (WTR::PlatformWebView::~PlatformWebView):
647         (WTR::PlatformWebView::page):
648         (WTR::PlatformWebView::focus):
649         (WTR::PlatformWebView::windowFrame):
650         (WTR::PlatformWebView::setWindowFrame):
651         (WTR::PlatformWebView::didInitializeClients):
652         (WTR::PlatformWebView::addChromeInputField):
653         (WTR::PlatformWebView::removeChromeInputField):
654         (WTR::PlatformWebView::makeWebViewFirstResponder):
655         (WTR::PlatformWebView::windowSnapshotImage):
656         (WTR::PlatformWebView::viewSupportsOptions):
657         * WebKitTestRunner/ios/TestControllerIOS.mm: Added.
658         (WTR::TestController::notifyDone):
659         (WTR::TestController::platformInitialize):
660         (WTR::TestController::platformDestroy):
661         (WTR::TestController::initializeInjectedBundlePath):
662         (WTR::TestController::initializeTestPluginDirectory):
663         (WTR::TestController::platformRunUntil):
664         (WTR::TestController::platformInitializeContext):
665         (WTR::TestController::runModal):
666         (WTR::TestController::platformLibraryPathForTesting):
667         * WebKitTestRunner/ios/WebArchiveDumpSupportIOS.mm: Copied from Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h.
668         (createCFURLResponseFromResponseData):
669         (supportedNonImageMIMETypes):
670         * WebKitTestRunner/ios/mainIOS.mm: Copied from Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h.
671         (-[WebKitTestRunnerApp _runTestController]):
672         (-[WebKitTestRunnerApp applicationDidFinishLaunching:]):
673         (main):
674
675 2014-01-24  Enrique Ocaña González  <eocanha@igalia.com>
676
677         [GTK] Put cache files in XDG_CACHE_HOME
678         https://bugs.webkit.org/show_bug.cgi?id=123458
679
680         Reviewed by Martin Robinson.
681
682         * GtkLauncher/main.c:
683         (createBrowser):
684
685 2014-01-23  Max Vujovic  <mvujovic@adobe.com>
686
687         Remove CSS Custom Filters code and tests
688         https://bugs.webkit.org/show_bug.cgi?id=127382
689
690         Reviewed by Simon Fraser.
691
692         * DumpRenderTree/gtk/DumpRenderTree.cpp:
693         (resetDefaultsToConsistentValues):
694         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
695         (TestRunner::overridePreference):
696
697 2014-01-23  Tim Horton  <timothy_horton@apple.com>
698
699         PDFPlugin: Use PDFPlugin even if there's an external plugin installed, if it's blocked
700         https://bugs.webkit.org/show_bug.cgi?id=127415
701         <rdar://problem/12482452>
702
703         Reviewed by Sam Weinig.
704
705         Adopt the new page loader client plugin load callback.
706
707         * WebKitTestRunner/TestController.cpp:
708         (WTR::TestController::createWebViewWithOptions):
709         (WTR::TestController::pluginLoadPolicy):
710         * WebKitTestRunner/TestController.h:
711
712 2014-01-23  peavo@outlook.com  <peavo@outlook.com>
713
714         [Curl] There is no way to specify cache folder.
715         https://bugs.webkit.org/show_bug.cgi?id=125028
716
717         Reviewed by Brent Fulgham.
718
719         Enable disc cache in WinLauncher by setting cache folder location.
720
721         * WinLauncher/WinLauncher.cpp:
722         (getAppDataFolder): Added function to get app data folder.
723         (setCacheFolder): Added function to set cache folder.
724         (createCrashReport): Use new getAppDataFolder function.
725         (wWinMain): Use function setCacheFolder to set cache folder location.
726
727 2014-01-23  Daniel Bates  <dabates@apple.com>
728
729         build-webkit --sdk=iphonesimulator doesn't think it's building iOS
730         https://bugs.webkit.org/show_bug.cgi?id=127379
731
732         Reviewed by Simon Fraser.
733
734         Teach build-webkit to recognize --sdk=X.
735
736         Currently, build-webkit recognizes --sdk X to specify X as the Xcode SDK to use, which is also
737         considered when determining the WebKit port to build. But build-webkit advertises --sdk=X in its
738         help message. We should teach build-webkit to recognize both --sdk X and --sdk=X to make its handling
739         of --sdk more consistent with the handling of other build-webkit options that take a value (e.g. --prefix).
740
741         * Scripts/webkitdirs.pm:
742         (checkForArgumentAndRemoveFromArrayRefGettingValue): Added.
743         (checkForArgumentAndRemoveFromARGVGettingValue): Modified to call checkForArgumentAndRemoveFromArrayRefGettingValue().
744         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRefGettingValue.pl: Added.
745
746 2014-01-23  Commit Queue  <commit-queue@webkit.org>
747
748         Unreviewed, rolling out r162612.
749         http://trac.webkit.org/changeset/162612
750         https://bugs.webkit.org/show_bug.cgi?id=127488
751
752         broke the build (Requested by mhahnenberg on #webkit).
753
754         * Scripts/build-jsc:
755         * jsc-cli/jsc-cli.xcodeproj/project.pbxproj: Removed.
756         * jsc-cli/jsc-cli/CLIInstance.h: Removed.
757         * jsc-cli/jsc-cli/CLIInstance.m: Removed.
758         * jsc-cli/jsc-cli/JSModule.h: Removed.
759         * jsc-cli/jsc-cli/JSModule.m: Removed.
760         * jsc-cli/jsc-cli/JSRunLoopThread.h: Removed.
761         * jsc-cli/jsc-cli/JSRunLoopThread.m: Removed.
762         * jsc-cli/jsc-cli/ReadEvalPrintLoop.h: Removed.
763         * jsc-cli/jsc-cli/ReadEvalPrintLoop.m: Removed.
764         * jsc-cli/jsc-cli/RunLoopThread.h: Removed.
765         * jsc-cli/jsc-cli/RunLoopThread.m: Removed.
766         * jsc-cli/jsc-cli/ScriptInputSource.h: Removed.
767         * jsc-cli/jsc-cli/ScriptInputSource.m: Removed.
768         * jsc-cli/jsc-cli/main.m: Removed.
769
770 2014-01-23  Mark Hahnenberg  <mhahnenberg@apple.com>
771
772         Basic framework for a modern jsc CLI
773         https://bugs.webkit.org/show_bug.cgi?id=127435
774
775         Reviewed by Geoffrey Garen.
776
777         The most basic components of a modern jsc command line interface consist of the following:
778
779         - A simple REPL to enter commands and receive results
780         - The ability to define a module (which consists of various internal methods as well as a 
781           set of externally visible methods)
782         - The ability to load other modules at runtime
783         - The ability to interact with the underlying platform to perform various "privileged" 
784           functions (e.g. opening files, printing to the stdout, etc.)
785         
786         The basic architecture will look something like the following:
787         - If the tool is run in REPL mode (i.e. no command line arguments), it will start the REPL 
788           on the main thread and start a secondary thread with a run loop to handle various inputs 
789           from the REPL thread.
790         - If the tool is given a script to run, it will evaluate that script (and any scripts that 
791           it might transitively load) within the run loop on the secondary thread while the main 
792           thread blocks until it has completed.
793
794         * Scripts/build-jsc:
795         * jsc-cli: Added.
796         * jsc-cli/jsc-cli: Added.
797         * jsc-cli/jsc-cli.xcodeproj: Added.
798         * jsc-cli/jsc-cli.xcodeproj/project.pbxproj: Added.
799         * jsc-cli/jsc-cli/CLIInstance.h: Added.
800         * jsc-cli/jsc-cli/CLIInstance.m: Added.
801         (-[CLIInstance init]):
802         (-[CLIInstance loadFile:]):
803         (-[CLIInstance run]):
804         * jsc-cli/jsc-cli/JSModule.h: Added.
805         * jsc-cli/jsc-cli/JSModule.m: Added.
806         (coreModules):
807         (isCoreModule):
808         (classForModule):
809         (coreModuleFullPath):
810         (resolveModuleAsFile):
811         (resolveModuleAsDirectory):
812         (nodeModulePaths):
813         (resolveAsNodeModule):
814         (+[JSModule resolve:atPath:]):
815         (globalModuleCache):
816         (isCached):
817         (cachedModule):
818         (cacheModule):
819         (+[JSModule require:atPath:]):
820         (+[JSModule require:atPath:inContext:]):
821         (-[JSModule platformObjectInContext:]):
822         (-[JSModule initWithId:filename:context:]):
823         (-[JSModule dealloc]):
824         (-[JSModule didStartLoading]):
825         (-[JSModule didFinishLoading]):
826         (-[JSModule require:]):
827         (-[JSModule exports]):
828         * jsc-cli/jsc-cli/JSRunLoopThread.h: Added.
829         * jsc-cli/jsc-cli/JSRunLoopThread.m: Added.
830         (jsThreadMain):
831         (+[JSRunLoopThread threadMain]):
832         (-[JSRunLoopThread initWithFiles:andContext:]):
833         (-[JSRunLoopThread startRunLoop]):
834         (-[JSRunLoopThread start]):
835         (-[JSRunLoopThread join]):
836         (-[JSRunLoopThread didReceiveInput:]):
837         (-[JSRunLoopThread performCallback:withError:]):
838         (-[JSRunLoopThread performCallback:withArguments:]):
839         (-[JSRunLoopThread didFinishRunLoopInitialization]):
840         * jsc-cli/jsc-cli/ReadEvalPrintLoop.h: Added.
841         * jsc-cli/jsc-cli/ReadEvalPrintLoop.m: Added.
842         (-[ReadEvalPrintLoop initWithJSThread:]):
843         (prompt):
844         (escapeStringForOutput):
845         (-[ReadEvalPrintLoop processNextInput]):
846         (-[ReadEvalPrintLoop run]):
847         * jsc-cli/jsc-cli/RunLoopThread.h: Added.
848         * jsc-cli/jsc-cli/RunLoopThread.m: Added.
849         (+[RunLoopThread threadMain]):
850         (-[RunLoopThread init]):
851         (-[RunLoopThread dealloc]):
852         (-[RunLoopThread didFinishRunLoopInitialization]):
853         (-[RunLoopThread start]):
854         (-[RunLoopThread join]):
855         * jsc-cli/jsc-cli/ScriptInputSource.h: Added.
856         * jsc-cli/jsc-cli/ScriptInputSource.m: Added.
857         (scriptInputSourceScheduleRoutine):
858         (scriptInputSourcePerformRoutine):
859         (scriptInputSourceCancelRoutine):
860         (-[ScriptInputSource initWithContext:]):
861         (-[ScriptInputSource dealloc]):
862         (-[ScriptInputSource addToCurrentRunLoop]):
863         (-[ScriptInputSource removeFromRemoteRunLoop]):
864         (-[ScriptInputSource didReceiveScript:]):
865         (-[ScriptInputSource didReceiveSignal]):
866         (-[ScriptInputSource runScriptRemotely:]):
867         (-[ScriptInputSource finishAsyncCallback:withResult:]):
868         * jsc-cli/jsc-cli/main.m: Added.
869         (main):
870
871 2014-01-23  László Langó  <llango.u-szeged@partner.samsung.com>
872
873         Remove a FIXME comment that is already fixed.
874         https://bugs.webkit.org/show_bug.cgi?id=127468
875
876         Reviewed by Csaba Osztrogonác.
877
878         * Scripts/webkitpy/style/filereader.py:
879         (TextFileReader.__init__):
880
881 2014-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
882
883         [GLIB] Use GUniquePtr instead of GOwnPtr
884         https://bugs.webkit.org/show_bug.cgi?id=127431
885
886         Reviewed by Martin Robinson.
887
888         GUniquePtr is a template alias of std::unique_ptr with a custom
889         deleter that replaces GOwnPtr. GOwnPtr is still used for the cases
890         where the output pointer is needed, but it will also be replaced soon.
891
892         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
893         (printAccessibilityEvent):
894         (axObjectEventListener):
895         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
896         (indexRangeInTable):
897         (AccessibilityUIElement::role):
898         (AccessibilityUIElement::title):
899         (AccessibilityUIElement::description):
900         (AccessibilityUIElement::stringValue):
901         (AccessibilityUIElement::language):
902         (AccessibilityUIElement::lineForIndex):
903         (AccessibilityUIElement::selectedTextRange):
904         (AccessibilityUIElement::url):
905         * DumpRenderTree/efl/AccessibilityControllerEfl.cpp:
906         (AccessibilityController::accessibleElementById):
907         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
908         (AccessibilityController::accessibleElementById):
909         * DumpRenderTree/gtk/DumpRenderTree.cpp:
910         (getOutputDir):
911         (getFontsPath):
912         (initializeFonts):
913         (dumpFramesAsText):
914         (compareHistoryItems):
915         (dumpHistoryItem):
916         (soupURIToStringPreservingPassword):
917         (resetDefaultsToConsistentValues):
918         (temporaryDatabaseDirectory):
919         (webViewTitleChanged):
920         (webFrameLoadStatusNotified):
921         (pathFromSoupURI):
922         (convertWebResourceToURLPath):
923         (urlSuitableForTestResult):
924         (descriptionSuitableForTestResult):
925         (willSendRequestCallback):
926         (frameLoadEventCallback):
927         * DumpRenderTree/gtk/EditingCallbacks.cpp:
928         (dumpNodePath):
929         (dumpRange):
930         (shouldApplyStyle):
931         * DumpRenderTree/gtk/EventSender.cpp:
932         (contextClickCallback):
933         (beginDragWithFilesCallback):
934         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
935         (TestRunner::pathToLocalResource):
936         (TestRunner::queueLoad):
937         (TestRunner::removeOriginAccessWhitelistEntry):
938         (TestRunner::setMockGeolocationPositionUnavailableError):
939         (TestRunner::setIconDatabaseEnabled):
940         (TestRunner::findString):
941         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
942         (TestRunner::overridePreference):
943         (TestRunner::addUserScript):
944         (TestRunner::addUserStyleSheet):
945         (TestRunner::setTextDirection):
946         * DumpRenderTree/gtk/TextInputController.cpp:
947         (setMarkedTextCallback):
948         (insertTextCallback):
949         (doCommandCallback):
950         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
951         (LoadHTMLStringItem::invoke):
952         * TestWebKitAPI/PlatformGTK.cmake:
953         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
954         (WebKitDOMNodeTest::testTagNames):
955         * TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp:
956         (testBackForwardListLimitAndCache):
957         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
958         (testContextMenuSmartSeparators):
959         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
960         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
961         (testDownloadLocalFile):
962         (testDownloadLocalFileError):
963         (addContentDispositionHTTPHeaderToResponse):
964         (serverCallback):
965         (testDownloadRemoteFileError):
966         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
967         (startTestServer):
968         (testInspectorServerPageList):
969         (openRemoteDebuggingSession):
970         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
971         (testPrintOperationPrint):
972         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
973         (addCacheHTTPHeadersToResponse):
974         (serverCallback):
975         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
976         (httpsServerCallback):
977         (httpServerCallback):
978         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
979         (testWebViewJavaScriptDialogs):
980         (testWebViewWindowProperties):
981         (testWebViewFileChooserRequest):
982         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
983         (testWebExtensionWindowObjectCleared):
984         (testWebExtensionIsolatedWorld):
985         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitAccessibility.cpp:
986         (startTestServer):
987         (checkAtspiAccessible):
988         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
989         (serverCallback):
990         (testClearDatabase):
991         (testGetFaviconURI):
992         (webkitFaviconDatabaseFinalizedCallback):
993         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
994         (testWebContextGetPlugins):
995         (testWebContextURIScheme):
996         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
997         (testWebViewRunJavaScript):
998         (testWebViewMode):
999         (testWebViewPageVisibility):
1000         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebViewGroup.cpp:
1001         (isStyleSheetInjectedForURLAtPath):
1002         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
1003         (testWebViewEditorCutCopyPasteNonEditable):
1004         (testWebViewEditorCutCopyPasteEditable):
1005         (testWebViewEditorSelectAllNonEditable):
1006         (testWebViewEditorSelectAllEditable):
1007         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1008         (sendRequestCallback):
1009         (methodCallCallback):
1010         * TestWebKitAPI/gtk/PlatformUtilitiesGtk.cpp:
1011         (TestWebKitAPI::Util::createInjectedBundlePath):
1012         (TestWebKitAPI::Util::createURLForResource):
1013         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
1014         (TestWebKitAPI::doKeyStroke):
1015         (TestWebKitAPI::doMouseButtonEvent):
1016         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
1017         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
1018         (loadFailedCallback):
1019         (LoadTrackingTest::loadURI):
1020         (LoadTrackingTest::loadHtml):
1021         (LoadTrackingTest::loadPlainText):
1022         (LoadTrackingTest::loadRequest):
1023         (LoadTrackingTest::reload):
1024         (LoadTrackingTest::goBack):
1025         (LoadTrackingTest::goForward):
1026         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
1027         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.cpp:
1028         (registerGResource):
1029         (removeNonEmptyDirectory):
1030         (main):
1031         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
1032         (Test::getWebKit1TestResoucesDir):
1033         (Test::getResourcesDir):
1034         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.cpp:
1035         (WebKitTestBus::run):
1036         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp:
1037         (WebKitTestServer::WebKitTestServer):
1038         (WebKitTestServer::getURIForPath):
1039         * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.cpp:
1040         (WebProcessTestRunner::runTest):
1041         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
1042         (resourceGetDataCallback):
1043         (WebViewTest::mainResourceData):
1044         (WebViewTest::mouseMoveTo):
1045         (WebViewTest::keyStroke):
1046         (WebViewTest::doMouseButtonEvent):
1047         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
1048         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
1049         (WTR::AccessibilityController::accessibleElementById):
1050         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1051         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1052         (WTR::AccessibilityUIElement::role):
1053         (WTR::AccessibilityUIElement::title):
1054         (WTR::AccessibilityUIElement::description):
1055         (WTR::AccessibilityUIElement::stringValue):
1056         (WTR::AccessibilityUIElement::language):
1057         (WTR::AccessibilityUIElement::lineForIndex):
1058         (WTR::AccessibilityUIElement::selectedTextRange):
1059         (WTR::AccessibilityUIElement::url):
1060         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1061         (WTR::getOutputDir):
1062         (WTR::getFontsPath):
1063         (WTR::initializeFontConfigSetting):
1064         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
1065         (WTR::topLevelPath):
1066         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
1067         (WTR::TestRunner::pathToLocalResource):
1068         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1069         (WTR::TestController::initializeInjectedBundlePath):
1070         (WTR::TestController::initializeTestPluginDirectory):
1071
1072 2014-01-05  Martin Robinson  <mrobinson@igalia.com>
1073
1074         [GTK] [CMake] run-webkit-tests should support the CMake build
1075         https://bugs.webkit.org/show_bug.cgi?id=126503
1076
1077         Reviewed by Daniel Bates.
1078
1079         Update run-launcher and gtk.py to work properly when dealing with the CMake port.
1080         run-webkit-tests does not need the --gtkcmake flag, but run-launcher does.
1081
1082         * Scripts/run-launcher: Work properly with the gtkcmake flag.
1083         * Scripts/webkitpy/port/gtk.py:
1084         (GtkPort._is_cmake_build): Added this helper which looks for the CMakeCache
1085         file to detect a CMake build.
1086         (GtkPort._built_executables_path): Added this helper to locate the built executable path.
1087         (GtkPort._built_libraries_path): Added this helper to locate the built library path.
1088         (GtkPort._port_flag_for_scripts): Use --gtkcmake when appropriate.
1089         (GtkPort.setup_environ_for_server): The way CMake builds libraries differs from GTK+.
1090         (GtkPort._path_to_driver): Use the new helper.
1091         (GtkPort._path_to_image_diff): Use the new helper.
1092         (GtkPort._path_to_webcore_library): Use the new helper.
1093         (GtkPort.build_webkit_command): Use --gtkcmake when appropriate.
1094
1095 2014-01-22  Ryuan Choi  <ryuan.choi@samsung.com>
1096
1097         [EFL] Remove unnecessary smart method since ewk_view_tiled removed
1098         https://bugs.webkit.org/show_bug.cgi?id=127417
1099
1100         Reviewed by Gyuyoung Kim.
1101
1102         * EWebLauncher/main.c:
1103         (on_key_down): Removed shortcut to test pre render.
1104
1105 2014-01-22  Myles C. Maxfield  <mmaxfield@apple.com>
1106
1107         Remove CSS3_TEXT_DECORATION define
1108         https://bugs.webkit.org/show_bug.cgi?id=127333
1109
1110         This is required for unprefixing the text-decoration-* CSS properties.
1111
1112         Reviewed by Simon Fraser.
1113
1114         * Configurations/FeatureDefines.xcconfig:
1115
1116 2014-01-22  Andy Estes  <aestes@apple.com>
1117
1118         [iOS] Prepare for upstreaming DumpRenderTree changes
1119         https://bugs.webkit.org/show_bug.cgi?id=127412
1120
1121         Reviewed by Simon Fraser.
1122
1123         Unlike on Mac where DumpRenderTree is a command-line tool, on iOS it is
1124         an application bundle. Instead of upstreaming a separate target for the
1125         app that duplicates the 'Compile Sources' phase of the tool, separate
1126         out the compilation into a static library target that both the
1127         command-line tool and the app can link against. Also, perform some
1128         unrelated cleanup.
1129
1130         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Updated the
1131         project file format from 2.4- to 3.2-compatible. Removed the
1132         'Copy Headers' build phase and removed all files from the
1133         'Compile Sources' build phase of DumpRenderTree. Added some files that
1134         were missing from the project. Created a 'DumpRenderTree (Library)'
1135         target for building the static library and made the 'DumpRenderTree'
1136         target depend on it. Added a 'Compile Sources' build phase to this
1137         target that builds the same files the DumpRenderTree target used to.
1138         Created DumpRenderTreeMain.mm as the only source file of the
1139         DumpRenderTree target, since targets won't link a binary without at
1140         least one source file. Made DumpRenderTree (Library) use
1141         DumpRenderTreeLibrary.xcconfig and made LayoutTestHelper use
1142         BaseTarget.xcconfig (so that it doesn't try to link libDumpRenderTree.a).
1143         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Moved
1144         definitions of GCC_ENABLE_OBJC_EXCEPTIONS and GCC_PREFIX_HEADER from
1145         DumpRenderTree.xcconfig to here so that LayoutTestHelper can use them.
1146         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Passed
1147         -force_load $(BUILT_PRODUCTS_DIR)libDumpRenderTree.a to OTHER_LDFLAGS.
1148         This is needed to correctly link a static library containing an Objective-C
1149         category (see <https://developer.apple.com/library/mac/qa/qa1490/_index.html>).
1150         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig: Added.
1151         * DumpRenderTree/mac/DumpRenderTree.mm:
1152         (DumpRenderTreeMain): Renamed from main.
1153         * DumpRenderTree/mac/DumpRenderTreeMac.h: Added declaration of DumpRenderTreeMain.
1154         * DumpRenderTree/mac/DumpRenderTreeMain.mm: Added.
1155         (main): Called DumpRenderTreeMain from main.
1156
1157 2014-01-15  Martin Robinson  <mrobinson@igalia.com>
1158
1159         [GTK][CMake] build-webkit should try harder to avoid re-running cmake
1160         https://bugs.webkit.org/show_bug.cgi?id=127073
1161
1162         Reviewed by Daniel Bates.
1163
1164         * Scripts/build-webkit: Unify all the ports that call buildCMakeProjectOrExit with
1165         the new isCMakeBuild conditional. This allows us to share more code between ports.
1166         Pass the build arguments to the removeCMakeCache function.
1167         * Scripts/webkitdirs.pm:
1168         (runAutogenForAutotoolsProjectIfNecessary): Renamed mustReRunAutogen to cachedArgumentFileOutOfDate
1169         because it's now shared with the CMake build.
1170         (cachedArgumentFileOutOfDate): Renamed.
1171         (cmakeCachePath): Added this helper which gets the CMakeCache.txt path.
1172         (shouldRemoveCMakeCache): Tries to preserve current behavior for all ports, 
1173         except GTK+ which examines the OptionsGTK.cmake and OptionsCommon.cmake file
1174         as well as checking if build-webkit has been run with different arguments.
1175         (removeCMakeCache): Call shouldRemoveCMakeCache now.
1176         (generateBuildSystemFromCMakeProject): Exit early if CMakeCache.txt exists for GTK+.
1177         (isCMakeBuild): Added.
1178
1179 2014-01-22  Thiago de Barros Lacerda  <thiago.lacerda@openbossa.org>
1180
1181         [EFL][GTK] Get EFL and GTK compiling with ACCESSIBILITY disabled
1182         https://bugs.webkit.org/show_bug.cgi?id=127119
1183
1184         Reviewed by Mario Sanchez Prada.
1185
1186         Guarding ACCESSIBILITY code in DumpRenderTree and WebKitTestRunner with HAVE(ACCESSIBILITY).
1187
1188         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1189         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1190         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1191         (resetDefaultsToConsistentValues):
1192         (webViewWindowObjectCleared):
1193         (main):
1194         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1195         (WTR::AccessibilityController::platformName):
1196         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1197         (WTR::AccessibilityUIElement::isIndeterminate):
1198
1199 2014-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1200
1201
1202         [GTK] Add GUniquePtr
1203         https://bugs.webkit.org/show_bug.cgi?id=127170
1204
1205         Reviewed by Gustavo Noronha Silva.
1206
1207         Add unit tests for GUniquePtr.
1208
1209         * TestWebKitAPI/GNUmakefile.am: Add new file to compilation.
1210         * TestWebKitAPI/Tests/WTF/gobject/GUniquePtr.cpp: Added.
1211         (log):
1212         (takeLogStr):
1213         (TestWebKitAPI::TEST):
1214
1215 2014-01-22  Jinwoo Song  <jinwoo7.song@samsung.com>
1216
1217         Remove Nix files from Tools
1218         https://bugs.webkit.org/show_bug.cgi?id=127418
1219
1220         Reviewed by Csaba Osztrogonác.
1221
1222         * Scripts/build-webkit:
1223         * Scripts/update-webkit-libs-jhbuild:
1224         * Scripts/webkitdirs.pm:
1225         (determineArchitecture):
1226         (argumentsForConfiguration):
1227         (jscProductDir):
1228         (builtDylibPathForName):
1229         (isAppleWebKit):
1230         (launcherPath):
1231         (launcherName):
1232         (checkRequiredSystemConfig):
1233         (copyInspectorFrontendFiles):
1234         (jhbuildWrapperPrefixIfNeeded):
1235         (buildCMakeProjectOrExit):
1236         (cmakeBasedPortName):
1237         * Scripts/webkitpy/common/config/ports.py:
1238         (DeprecatedPort.port):
1239         (EflWK2Port.build_webkit_command):
1240         * Scripts/webkitpy/port/factory.py:
1241         (platform_options):
1242         (PortFactory):
1243         * Scripts/webkitpy/port/nix.py: Removed.
1244         * Scripts/webkitpy/port/nix_unittest.py: Removed.
1245
1246 2014-01-21  Benjamin Poulain  <benjamin@webkit.org>
1247
1248         Add Ian and Ricky to the contributor list
1249
1250         * Scripts/webkitpy/common/config/contributors.json:
1251         I am too old to remember all those email addresses :)
1252
1253 2014-01-21  David Farler  <dfarler@apple.com>
1254
1255         Upstream package-root for iOS
1256
1257         Reviewed by Daniel bates.
1258
1259         * Scripts/package-root: Added.
1260         (usage):
1261         * Scripts/webkitdirs.pm:
1262         (XcodeSDKPath): Added function.
1263
1264 2014-01-21  Daniel Bates  <dabates@apple.com>
1265
1266         [iOS] Tools/Makefile shouldn't build modules DumpRenderTree, gtest, or TestWebKitAPI
1267         https://bugs.webkit.org/show_bug.cgi?id=127368
1268
1269         Reviewed by Tim Horton.
1270
1271         Similar to the build-webkit change in <https://bugs.webkit.org/show_bug.cgi?id=127364>,
1272         we don't want to build DumpRenderTree, gtest, or TestWebKitAPI when running make in
1273         Tools.
1274
1275         * Makefile:
1276
1277 2014-01-21  Daniel Bates  <dabates@apple.com>
1278
1279         [iOS] Don't build DumpRenderTree, gtest, or TestWebKitAPI
1280         https://bugs.webkit.org/show_bug.cgi?id=127364
1281
1282         Reviewed by Simon Fraser.
1283
1284         For now, don't build DumpRenderTree and TestWebKitAPI for iOS as these
1285         projects fail to build because we need to upstream the relevant iOS changes.
1286         Also, don't build gtest, which is a dependency of TestWebKitAPI since we
1287         aren't building TestWebKitAPI.
1288
1289         * Scripts/build-webkit:
1290
1291 2014-01-21  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1292
1293         Unreviewed, remove myself from some watchlist entries.
1294
1295         * Scripts/webkitpy/common/config/watchlist:
1296
1297 2014-01-21  Zalan Bujtas  <zalan@apple.com>
1298
1299         Use 64 as the default value for the subpixel denominator.
1300
1301         Reviewed by Simon Fraser.
1302
1303         * lldb/lldb_webkit.py:
1304         (WebCoreLayoutUnitProvider.to_string):
1305
1306 2014-01-21  ChangSeok Oh  <changseok.oh@collabora.com>
1307
1308         [GTK] Fix a c++11 compliance issue for fontconfig
1309         https://bugs.webkit.org/show_bug.cgi?id=127283
1310
1311         Reviewed by Martin Robinson.
1312
1313         fontconfig-2.8.0 is not compliant with C++11. So I propose to apply a
1314         hotfix until bumping fontconfig up.
1315
1316         * gtk/jhbuild.modules:
1317         * gtk/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Added.
1318
1319 2014-01-21  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
1320
1321         run-jsc-stress-tests should accept --child-processes option and WEBKIT_TEST_CHILD_PROCESSES env.var
1322         like run_webkit_test does
1323         https://bugs.webkit.org/show_bug.cgi?id=127349
1324
1325         Reviewed by Csaba Osztrogonác.
1326
1327         * Scripts/run-jsc-stress-tests:
1328
1329 2014-01-21  Adrian Perez de Castro  <aperez@igalia.com>
1330
1331         [GTK] Allow passing extra data to web extensions
1332         https://bugs.webkit.org/show_bug.cgi?id=125990
1333
1334         Reviewed by Carlos Garcia Campos.
1335
1336         Allow passing additional information to the injected bundle. On top
1337         of the string containing the path to the web extensions directory,
1338         a GVariant can be set with additional data using
1339         webkit_web_context_set_web_extensions_initialization_user_data().
1340         Also, a new initialize-web-extensions signal is emitted before
1341         launching a new WebProcess to allow setting different user data
1342         for each process. The GVariant is serialized as a string, passed
1343         to the injected bundle, and the injected bundle deserializes back
1344         the data, which is passed to web extensions which define the
1345         webkit_web_extension_initialize_with_user_data() function (for
1346         backwards compatibility, webkit_web_extension_initialize() is
1347         used as a fallback.)
1348
1349         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
1350         (initializeWebExtensions): Handles the initialize-web-extensions
1351         signal, and sets the web extensions directory and the initialization
1352         user data.
1353         (testWebExtensionInitializationUserData): New test case for checking
1354         the user data passed on initialization to web extensions.
1355         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1356         (methodCallCallback): Added implementation for the
1357         GetInitializationUserData D-Bus method, used by
1358         testWebExtensionInitializationUserData().
1359         (webkit_web_extension_initialize_with_user_data): Define the
1360         initialization function with the additional user data parameter.
1361
1362 2014-01-21  Siddharth Mathur  <s.mathur@ieee.org>
1363
1364         Change my email address in contributors.json.
1365
1366         Unreviewed.
1367
1368         * Scripts/webkitpy/common/config/contributors.json:
1369
1370 2014-01-21  Krzysztof Czech  <k.czech@samsung.com>
1371
1372         [ATK] Expose aria-flowto through ATK_RELATION_FLOWS_TO
1373         https://bugs.webkit.org/show_bug.cgi?id=127291
1374
1375         Reviewed by Mario Sanchez Prada.
1376
1377         Implemented AccessibilityUIElement::ariaFlowToElementAtIndex method.
1378
1379         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1380         (AccessibilityUIElement::ariaFlowToElementAtIndex):
1381         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1382         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
1383
1384 2014-01-20  Zalan Bujtas  <zalan@apple.com>
1385
1386         Force float division when calculating CSS px value.
1387
1388         Reviewed by Simon Fraser.
1389
1390         Note that in Python 3, this is the default behavior.
1391
1392         * lldb/lldb_webkit.py:
1393         (WebCoreLayoutUnitProvider.to_string):
1394
1395 2014-01-20  Alexey Proskuryakov  <ap@apple.com>
1396
1397         build.webkit.org/dashboard should display information about patches in EWS
1398         https://bugs.webkit.org/show_bug.cgi?id=127006
1399
1400         Reviewed by Ryosuke Niwa.
1401
1402         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
1403         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Bugzilla.js: Added.
1404         (Bugzilla.prototype.detailsURLForAttachment):
1405         Added a class for Bugzilla. So far, the only thing it can do is build patch URLs,
1406         which is needed when one wants to do something with a patch EWS is stuck on.
1407
1408         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
1409         Create a Bugzilla instance.
1410
1411         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
1412         (EWS.prototype.jsonQueueLengthURL):
1413         (EWS.prototype.jsonQueueStatusURL):
1414         Build JSON ULRs here, not in EWSQueue, as this is how other classes are structured.
1415
1416         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
1417         (EWSQueue.prototype.get statusPageURL): Changed to use a URL provided by EWS instead
1418         of second guessing.
1419         (EWSQueue.prototype.get chartsPageURL): Added.
1420         (EWSQueue.prototype.get loadedDetailedStatus): Tells whether we currently have
1421         additional data already loaded (it's reset with every update).
1422         (EWSQueue.prototype.get patches): Get patch queue.
1423         (EWSQueue.prototype.get bots): Get bots.
1424         (EWSQueue.prototype.update): Changed to use a specialized cheaper URL.
1425         (EWSQueue.prototype.loadDetailedStatus): Load and transform detailed status JSON.
1426
1427         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js:
1428         (EWSQueueView.prototype.update.appendQueue): Add a popover is there are any patches
1429         in the queue.
1430         (EWSQueueView.prototype.addLinkToRow): A helper to build the popover.
1431         (EWSQueueView.prototype.addTextToRow): Ditto.
1432         (EWSQueueView.prototype._addQueueHeadingToPopover): Ditto.
1433         (EWSQueueView.prototype._addBotsHeadingToPopover): Ditto.
1434         (EWSQueueView.prototype._addDividerToPopover): Ditto.
1435         (EWSQueueView.prototype._timeIntervalString): A helper to format a timestamp into a
1436         relative string.
1437         (EWSQueueView.prototype._popoverContentForEWSQueue): Build the popover.
1438         (EWSQueueView.prototype._presentPopoverForEWSQueue): Start loading data, and present
1439         it when done.
1440
1441         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
1442         Added rules for EWS popover. Removed a duplicate rule for build-logs-popover.
1443         Changed a few difficult to read padding styles to padding-left.
1444
1445 2014-01-20  Alexey Proskuryakov  <ap@apple.com>
1446
1447         Fix webkitpy tests.
1448
1449         * Scripts/webkitpy/common/net/web_mock.py: (MockBrowser.set_handle_robots):
1450         Added a mock implementation, as we now call this function.
1451
1452 2014-01-20  Darin Adler  <darin@apple.com>
1453
1454         Update style checker and tests to deal with override instead of OVERRIDE
1455         https://bugs.webkit.org/show_bug.cgi?id=127175
1456
1457         Reviewed by Anders Carlsson.
1458
1459         * Scripts/webkitpy/style/checkers/cpp.py:
1460         (check_braces): Use override instead of OVERRIDE.
1461         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1462         (CppStyleTest.test_brace_at_begin_of_line): Ditto.
1463
1464 2014-01-20  Alexey Proskuryakov  <ap@apple.com>
1465
1466         EWS should provide better information to Dashboard via JSON
1467         https://bugs.webkit.org/show_bug.cgi?id=127265
1468
1469         Reviewed by Ryosuke Niwa.
1470
1471         * QueueStatusServer/app.yaml: Updated version.
1472
1473         * QueueStatusServer/main.py:
1474         * QueueStatusServer/handlers/queuelengthjson.py:
1475         Added a way to cheaply get only the queue length, which is all the dashboard
1476         needs unless a popover is opened.
1477
1478         * QueueStatusServer/handlers/queuestatusjson.py: Updated to return more information
1479         that we will need. Changed some field names to be more meaningful. Fixed bot listing
1480         to understand that a bot can be reprurposed and used in a different queue.
1481
1482 2014-01-20  Alexey Proskuryakov  <ap@apple.com>
1483
1484         Make uploading results to EWS work despite robots.txt
1485         https://bugs.webkit.org/show_bug.cgi?id=127296
1486
1487         Reviewed by Ryosuke Niwa.
1488
1489         * Scripts/webkitpy/common/net/statusserver.py: (StatusServer.__init__): Disable
1490         checking robots.txt.
1491
1492         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py: (Bugzilla._get_browser):
1493         Removed a comment saying that we would want to stop doing this. Not checking
1494         robots.txt is more efficient than checking it.
1495
1496 2014-01-19  Ryuan Choi  <ryuan.choi@samsung.com>
1497
1498         [EFL][WK1] Remove and refactor the APIs which use single and base keyword
1499         https://bugs.webkit.org/show_bug.cgi?id=127214
1500
1501         Reviewed by Gyuyoung Kim.
1502
1503         Followed the changes of API.
1504
1505         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
1506         (drtViewAdd):
1507         * EWebLauncher/main.c:
1508         (windowCreate):
1509
1510 2014-01-19  Eunmi Lee  <eunmi15.lee@samsung.com>
1511
1512         [EFL][WK2] Add touch events option to MiniBrowser.
1513         https://bugs.webkit.org/show_bug.cgi?id=127262
1514
1515         Reviewed by Gyuyoung Kim.
1516
1517         As a default, touch events are disabled and mouse events are enabled.
1518         If touch events option sets to true, touch events are enabled and mouse
1519         events are disabled.
1520
1521         * MiniBrowser/efl/main.c:
1522         (window_create):
1523         (elm_main):
1524
1525 2014-01-19  Zalan Bujtas  <zalan@apple.com>
1526
1527         Pretty print LayoutUnit, LayoutPoint, and LayoutSize in lldb and gdb.
1528         https://bugs.webkit.org/show_bug.cgi?id=126080
1529
1530         Reviewed by Sam Weinig.
1531
1532         This changes the output of printing LayoutUnits to be in px but it also
1533         preserves the original LayoutUnit value.
1534
1535         This will lead to lldb output like: (and it works even when subpixel is disabled)
1536
1537         (const WebCore::LayoutRect) $0 = {
1538             m_location = { x = 2.25px (144), y = 1px (64)}
1539             m_size = { width = 13.75px (880), height = 20px (1280) }
1540
1541
1542         And gdb output like:
1543
1544         m_frameRect = {
1545             m_location = LayoutPoint(0px (0), 0px(0)),
1546             m_size = LayoutSize(8px (512), 5px (320))
1547         }
1548
1549         This patch is based on patch by bjonesbe@adobe.com and for Blink by cbiesinger@chromium.org.
1550
1551         * gdb/webkit.py:
1552         (WebCoreLayoutUnitPrinter):
1553         (WebCoreLayoutUnitPrinter.__init__):
1554         (WebCoreLayoutUnitPrinter.to_string):
1555         (WebCoreLayoutSizePrinter):
1556         (WebCoreLayoutSizePrinter.__init__):
1557         (WebCoreLayoutSizePrinter.to_string):
1558         (WebCoreLayoutPointPrinter):
1559         (WebCoreLayoutPointPrinter.__init__):
1560         (WebCoreLayoutPointPrinter.to_string):
1561         (add_pretty_printers):
1562         * lldb/lldb_webkit.py:
1563         (__lldb_init_module):
1564         (WebCoreLayoutUnit_SummaryProvider):
1565         (WebCoreLayoutSize_SummaryProvider):
1566         (WebCoreLayoutPoint_SummaryProvider):
1567         (WebCoreLayoutUnitProvider):
1568         (WebCoreLayoutUnitProvider.__init__):
1569         (WebCoreLayoutUnitProvider.to_string):
1570         (WebCoreLayoutSizeProvider):
1571         (WebCoreLayoutSizeProvider.__init__):
1572         (WebCoreLayoutSizeProvider.get_width):
1573         (WebCoreLayoutSizeProvider.get_height):
1574         (WebCoreLayoutPointProvider):
1575         (WebCoreLayoutPointProvider.__init__):
1576         (WebCoreLayoutPointProvider.get_x):
1577         (WebCoreLayoutPointProvider.get_y):
1578
1579 2014-01-18  Alexey Proskuryakov  <ap@apple.com>
1580
1581         Add robots.txt to http://webkit-queues.appspot.com
1582         https://bugs.webkit.org/show_bug.cgi?id=127240
1583
1584         * QueueStatusServer/app.yaml: Added required "upload" attribute for robots.txt.
1585
1586 2014-01-18  Alexey Proskuryakov  <ap@apple.com>
1587
1588         Add robots.txt to http://webkit-queues.appspot.com
1589         https://bugs.webkit.org/show_bug.cgi?id=127240
1590
1591         Reviewed by Ryosuke Niwa.
1592
1593         * QueueStatusServer/app.yaml: Added robots.txt as a static file. Updated version.
1594
1595         * QueueStatusServer/robots.txt: Added.
1596
1597 2014-01-18  Alberto Garcia  <berto@igalia.com>
1598
1599         Tools/Scripts/test-webkitperl fails: 'tempdir' can't be called as a method
1600         https://bugs.webkit.org/show_bug.cgi?id=127217
1601
1602         Reviewed by Daniel Bates.
1603
1604         The syntax File::Temp->tempdir() was explicitly made invalid
1605         following <https://github.com/Perl-Toolchain-Gang/File-Temp/commit/c8920b2161ab6900a09e02b9410e0e4c3d74f565>
1606         which was included in File::Temp v2.30, shipped with Perl v5.18.0.
1607
1608         Use File::Temp::tempdir() instead.
1609
1610         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
1611
1612 2014-01-18  Alexey Proskuryakov  <ap@apple.com>
1613
1614         build.webkit.org/dashboard should have image diff links in test results popovers
1615         https://bugs.webkit.org/show_bug.cgi?id=127188
1616
1617         Reviewed by Timothy Hatcher.
1618
1619         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1620         (Buildbot.prototype.layoutTestImagesURLForIteration):
1621         (Buildbot.prototype.layoutTestImageDiffURLForIteration):
1622         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1623         (BuildbotIteration.prototype.loadLayoutTestResults):
1624         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1625         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions.addFailureInfoLink):
1626         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions.addFailureInfoText):
1627         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions):
1628
1629 2014-01-18  Anders Carlsson  <andersca@apple.com>
1630
1631         Remove ENABLE_THREADED_HTML_PARSER defines everywhere
1632         https://bugs.webkit.org/show_bug.cgi?id=127225
1633
1634         Reviewed by Andreas Kling.
1635
1636         This concludes the removal of over 8.8 million lines of threaded parser code.
1637
1638         * Scripts/webkitperl/FeatureList.pm:
1639
1640 2014-01-17  Alexey Proskuryakov  <ap@apple.com>
1641
1642         build.webkit.org/dashboard should have diff links in test results popovers
1643         https://bugs.webkit.org/show_bug.cgi?id=126986
1644
1645         Reviewed by Tim Horton.
1646
1647         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1648         (Buildbot.prototype.layoutTestCrashLogURLForIteration):
1649         (Buildbot.prototype.layoutTestStderrURLForIteration):
1650         (Buildbot.prototype.layoutTestDiffURLForIteration):
1651         (Buildbot.prototype.layoutTestPrettyDiffURLForIteration):
1652         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1653         (BuildbotIteration.prototype.loadLayoutTestResults):
1654         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1655         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions):
1656
1657 2014-01-17  Matthew Hanson  <matthew_hanson@apple.com>
1658
1659         Add the bare minimum support for branches to the bot-watchers dashboard
1660         https://bugs.webkit.org/show_bug.cgi?id=127124
1661
1662         This patch simply introduces the notion of branches into the bot-watchers dashboard.
1663         Subsequent patches will build functionality on top of this simple bit of infrastructure.
1664
1665         Reviewed by Timothy Hatcher.
1666
1667         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1668         (BuildbotQueue): store the branch property in the BuildbotQueue constructor
1669         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1670         Initialize the Dashboard.Branch object
1671
1672 2014-01-17  Chris Fleizach  <cfleizach@apple.com>
1673
1674         platform/mac/accessibility/aria-multiline.html sometimes asserts in AccessibilityController::removeNotificationListener
1675         https://bugs.webkit.org/show_bug.cgi?id=127141
1676
1677         Reviewed by Alexey Proskuryakov.
1678
1679         Make sure to reset the notification handler each time.
1680
1681         * DumpRenderTree/AccessibilityController.cpp:
1682         (AccessibilityController::resetToConsistentState):
1683         * DumpRenderTree/AccessibilityController.h:
1684         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
1685         (AccessibilityController::platformResetToConsistentState):
1686         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
1687         (AccessibilityController::platformResetToConsistentState):
1688         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
1689         (AccessibilityController::~AccessibilityController):
1690         (AccessibilityController::platformResetToConsistentState):
1691         (AccessibilityController::removeNotificationListener):
1692         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1693         (AccessibilityController::platformResetToConsistentState):
1694
1695 2014-01-17  Alberto Garcia  <berto@igalia.com>
1696
1697         [GTK] Test /webkit/download/not-found fails in GTK Linux 64-bit Release bot
1698         https://bugs.webkit.org/show_bug.cgi?id=82329
1699
1700         Reviewed by Carlos Garcia Campos.
1701
1702         Unskip, this is working fine now.
1703
1704         * Scripts/run-gtk-tests:
1705         (TestRunner):
1706
1707 2014-01-17  Alberto Garcia  <berto@igalia.com>
1708
1709         [GTK] Test /webkit/webview/icon-uri times out in GTK Linux 64-bit Release bot
1710         https://bugs.webkit.org/show_bug.cgi?id=82328
1711
1712         Reviewed by Carlos Garcia Campos.
1713
1714         This was caused by the icon database being corrupted in the
1715         Release bot. After removing it the test works fine so it can be
1716         run again.
1717
1718         * Scripts/run-gtk-tests:
1719         (TestRunner):
1720
1721 2014-01-16  Alexey Proskuryakov  <ap@apple.com>
1722
1723         Test results popovers at http://build.webkit.org/dashboard should link to stderr
1724         https://bugs.webkit.org/show_bug.cgi?id=126929
1725
1726         Reviewed by Timothy Hatcher.
1727
1728         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1729         (Buildbot.prototype.layoutTestCrashLogURLForIteration): Renamed for consistency.
1730         (Buildbot.prototype.layoutTestStderrURLForIteration): Added.
1731
1732         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1733         (BuildbotIteration.prototype.loadLayoutTestResults): Store has_stderr attribute.
1734
1735         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1736         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions):
1737         Add a link to stderr output if present.
1738
1739         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
1740         (.test-results-popover .additional-link): Style with light grey (will use the same style
1741         for diff links).
1742
1743 2014-01-16  Ryosuke Niwa  <rniwa@webkit.org>
1744
1745         Automate DoYouEvenBench
1746         https://bugs.webkit.org/show_bug.cgi?id=124497
1747
1748         Reviewed by Geoffrey Garen.
1749
1750         * Scripts/webkitpy/performance_tests/perftest.py:
1751         (PerfTestMetric.__init__): Added the aggregator name as an argument.
1752         (PerfTestMetric.aggregator): Added.
1753         (PerfTest._metrics_regex): Made the subtest name match non-greedy so that the metric names will be
1754         won't be eagerly parsed as a part of the subtest name. e.g. "Time" and "Total" in "a:Time:Total"
1755         should be parsed as the metric and the aggregator respectively.
1756         (PerfTest._run_with_driver): Pass in the aggregator name.
1757         (PerfTest._ensure_metrics): Ditto. Also split the subtest name by / as required by DoYouEvenBench
1758         which generates subtests of subtests within a single test file.
1759
1760         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1761         (test_parse_output_with_subtests_and_total): Added.
1762
1763         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1764         (_generate_results_dict): Add the aggregator name to the JSON when one is available.
1765
1766         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
1767         (TestWithSubtestsData): Added a sub test with an aggregator and a sub-sub test.
1768
1769 2014-01-16  Chris Fleizach  <cfleizach@apple.com>
1770
1771         platform/mac/accessibility/aria-multiline.html sometimes asserts in AccessibilityController::removeNotificationListener
1772         https://bugs.webkit.org/show_bug.cgi?id=127141
1773
1774         Reviewed by Alexey Proskuryakov.
1775
1776         Don't assert that the notification handler needs to be cleaned up. Deallocing the controller should be enough to clean up as it is.
1777
1778         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
1779         (AccessibilityController::~AccessibilityController):
1780
1781 2014-01-16  Ryosuke Niwa  <rniwa@webkit.org>
1782
1783         EWS shouldn't comment on Bugzilla for failing builds or style errors
1784         https://bugs.webkit.org/show_bug.cgi?id=127079
1785
1786         Reviewed by Anders Carlsson.
1787
1788         Since patch authors and reviewers could retrieve this information from bubbles,
1789         we shouldn't spam the Bugzilla with useless comments.
1790
1791         We still post style errors but not python paths we used since it's a pure noise.
1792
1793         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1794         (AbstractEarlyWarningSystem._post_reject_message_on_bug):
1795         * Scripts/webkitpy/tool/commands/queues.py:
1796         (StyleQueue.review_patch):
1797
1798 2014-01-15  Roger Fong  <roger_fong@apple.com>
1799
1800         Add support for handling WebGL load policies.
1801         https://bugs.webkit.org/show_bug.cgi?id=126935
1802         <rdar://problem/15790448>.
1803
1804         Reviewed by Timothy Horton.
1805
1806         * WebKitTestRunner/TestController.cpp: Update WKPageLoaderClient to V4.
1807         (WTR::TestController::createWebViewWithOptions):
1808
1809 2014-01-16  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
1810
1811         Remove workaround for compilers not supporting explicit override control
1812         https://bugs.webkit.org/show_bug.cgi?id=127111
1813
1814         Reviewed by Anders Carlsson.
1815
1816         Now all compilers support explicit override control, this workaround can be removed.
1817
1818         * DumpRenderTree/gtk/fonts/fonts.conf:
1819         * Scripts/do-webcore-rename:
1820         Removed this rename operation from the list of contemplated future renames.
1821         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp:
1822         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest_Bundle.cpp:
1823         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
1824         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp:
1825         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
1826
1827 2014-01-16  Oliver Hunt  <oliver@apple.com>
1828
1829         Stop run-jsc from consuming stderr output
1830         https://bugs.webkit.org/show_bug.cgi?id=127115
1831
1832         Reviewed by Mark Lam.
1833
1834         Simple patch to make run-jsc easier to deal with
1835
1836         * Scripts/run-jsc:
1837
1838 2014-01-16  Eva Balazsfalvi  <balazsfalvi.eva@stud.u-szeged.hu>
1839
1840         Tools/gtk/generate-feature-defines-files doesn't work with older versions of python
1841         https://bugs.webkit.org/show_bug.cgi?id=126323
1842
1843         Reviewed by Csaba Osztrogonác.
1844
1845         * gtk/generate-feature-defines-files:
1846
1847 2014-01-16  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
1848
1849         [EFL][WK2] Implement TestController::setHidden
1850         https://bugs.webkit.org/show_bug.cgi?id=127036
1851
1852         Reviewed by Gyuyoung Kim.
1853
1854         WebKitTestRunner needs TestController::setHidden implementation to
1855         properly handle page visibility API layout tests after r161105.
1856
1857         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1858         (WTR::TestController::setHidden):
1859
1860 2014-01-16  Zan Dobersek  <zdobersek@igalia.com>
1861
1862         [GTK][MiniBrowser] The progress entry reset callback can be fired after the BrowserWindow is destroyed
1863         https://bugs.webkit.org/show_bug.cgi?id=127083
1864
1865         Reviewed by Carlos Garcia Campos.
1866
1867         When the load progress reaches 1.0 (i.e. 100%), a timeout callback is set up in webViewLoadProgressChanged.
1868         The progress entry is then reset back to 0 in that callback and the timeout source is removed.
1869
1870         The callback can be fired after the relevant BrowserWindow and its progress entry are destroyed, causing
1871         assertion failures in gtk_entry_set_progress_fraction due to an invalid GtkEntry object. To avoid that,
1872         To avoid that, the ID of the timeout source is stored on the BrowserWindow and is destroyed when the
1873         BrowserWindow object is being finalized, preventing the callback from firing.
1874
1875         * MiniBrowser/gtk/BrowserWindow.c:
1876         (resetEntryProgress):
1877         (webViewLoadProgressChanged):
1878         (browserWindowFinalize):
1879
1880 2014-01-15  Alexey Proskuryakov  <ap@apple.com>
1881
1882         DumpRenderTree doesn't disable web preferences autosave
1883         https://bugs.webkit.org/show_bug.cgi?id=127062
1884
1885         Reviewed by Dan Bernstein.
1886
1887         * DumpRenderTree/mac/DumpRenderTree.mm: (prepareConsistentTestingEnvironment):
1888         Do it.
1889
1890 2014-01-15  Dean Jackson  <dino@apple.com>
1891
1892         Improve filter-build-webkit, especially for iOS builds
1893         https://bugs.webkit.org/show_bug.cgi?id=81046
1894
1895         Reviewed by Joseph Pecoraro.
1896
1897         Lots of updates to the filtering rules, mostly from the
1898         iOS build output. Other highlights include:
1899         - ignoring escape sequences for color ouput
1900         - detecting escaped spaces in file name regexps
1901
1902         * Scripts/filter-build-webkit:
1903         (shouldIgnoreLine):
1904
1905 2014-01-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1906
1907         [GTK] Web process sometimes crashes when printing in synchronous mode
1908         https://bugs.webkit.org/show_bug.cgi?id=126979
1909
1910         Reviewed by Gustavo Noronha Silva.
1911
1912         * Scripts/run-gtk-tests:
1913         (TestRunner): Unskip
1914         /webkit2/WebKitPrintOperation/close-after-print.
1915
1916 2014-01-15  ChangSeok Oh  <changseok.oh@collabora.com>
1917
1918         [EFL] Change test font installed path to webkitgtk-font-tests
1919         https://bugs.webkit.org/show_bug.cgi?id=126723
1920
1921         Reviewed by Gyuyoung Kim.
1922
1923         I'd like to change the test fonts installed directory from 'webkitgtk-test-fonts-0.0.3'
1924         to 'webkitgtk-test-fonts'. webkitgtk-test-fonts-0.0.3 doesn't match the path
1925         hard-coded in FontManagement.cpp#105
1926
1927         * DumpRenderTree/PlatformEfl.cmake:
1928         * WebKitTestRunner/PlatformEfl.cmake:
1929         * efl/jhbuild.modules:
1930
1931 2014-01-14  Ryosuke Niwa  <rniwa@webkit.org>
1932
1933         Make DoYouEvenBench runnable by run-perf-tests
1934         https://bugs.webkit.org/show_bug.cgi?id=127030
1935
1936         Reviewed by Andreas Kling.
1937
1938         Ignore console messages spit out by DoYouEvenBench and support aggregator names such as
1939         ":Total" to appear at the end of a test name. We don't do anything with it for now.
1940
1941         * Scripts/webkitpy/performance_tests/perftest.py:
1942         (PerfTest._metrics_regex): Handle aggregator names such as ":Total". We'll pass it down
1943         to the JSON in a follow up patch for the perf dashboard.
1944         (PerfTest._lines_to_ignore_in_parser_result): Added lines to ignore for DoYouEvenBench.
1945
1946 2014-01-14  Carlos Garcia Campos  <cgarcia@igalia.com>
1947
1948         [GTK] UI process crashes when the web process crashes while printing
1949         https://bugs.webkit.org/show_bug.cgi?id=126977
1950
1951         Reviewed by Gustavo Noronha Silva.
1952
1953         Add new test case to check that closing the window right after
1954         printing works. It's skipped for now, because this patch only
1955         fixes the UI process crash, but not the web process one.
1956
1957         * Scripts/run-gtk-tests:
1958         (TestRunner): Skip
1959         /webkit2/WebKitPrintOperation/close-after-print.
1960         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
1961         (testPrintOperationPrintPrinter):
1962         (findPrintToFilePrinter):
1963         (testPrintOperationPrint):
1964         (testPrintOperationErrors):
1965         (testPrintOperationCloseAfterPrint):
1966         (beforeAll):
1967
1968 2014-01-14  Brent Fulgham  <bfulgham@apple.com>
1969
1970         [WIN] Set MSBuild environment variable to avoid long-lived processes locking log files
1971         https://bugs.webkit.org/show_bug.cgi?id=127002
1972
1973         Reviewed by David Kilzer.
1974
1975         * Scripts/webkitdirs.pm:
1976         (setupAppleWinEnv): Export MSBUILDDISABLENODEREUSE=1 to the environment.
1977
1978 2014-01-14  Commit Queue  <commit-queue@webkit.org>
1979
1980         Unreviewed, rolling out r162000.
1981         http://trac.webkit.org/changeset/162000
1982         https://bugs.webkit.org/show_bug.cgi?id=127009
1983
1984         API versioning is wrong (Requested by rfong on #webkit).
1985
1986         * MiniBrowser/mac/WK2BrowserWindowController.m:
1987         (-[WK2BrowserWindowController awakeFromNib]):
1988         * WebKitTestRunner/TestController.cpp:
1989         (WTR::TestController::createOtherPage):
1990         (WTR::TestController::createWebViewWithOptions):
1991
1992 2014-01-13  Roger Fong  <roger_fong@apple.com>
1993
1994         Add support for handling WebGL load policies.
1995         https://bugs.webkit.org/show_bug.cgi?id=126935
1996         <rdar://problem/15790448>.
1997
1998         Reviewed by Brent Fulgham.
1999
2000         * MiniBrowser/mac/WK2BrowserWindowController.m:
2001         (-[WK2BrowserWindowController awakeFromNib]):
2002         * WebKitTestRunner/TestController.cpp:
2003         (WTR::TestController::createWebViewWithOptions):
2004
2005 2014-01-14  Zan Dobersek  <zdobersek@igalia.com>
2006
2007         [GTK] Skip FontConfig initialization in WebKitTestRunner if requested
2008         https://bugs.webkit.org/show_bug.cgi?id=120110
2009
2010         Reviewed by Martin Robinson.
2011
2012         Skip the FontConfig settings initialization in WebKitTestRunner if the
2013         WEBKIT_SKIP_WEBKITTESTRUNNER_FONTCONFIG_INITIALIZATION environment variable is set.
2014         This is useful when profiling the WebKitTestRunner execution, where at the startup
2015         this step takes considerable amount of time and disturbs the profiling output.
2016
2017         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
2018         (WTR::initializeFontConfigSetting):
2019
2020 2014-01-14  Brian J. Burg  <burg@cs.washington.edu>
2021
2022         Add ENABLE(WEB_REPLAY) feature flag to the build system
2023         https://bugs.webkit.org/show_bug.cgi?id=126949
2024
2025         Reviewed by Joseph Pecoraro.
2026
2027         * Scripts/webkitperl/FeatureList.pm:
2028
2029 2014-01-14  László Langó  <llango.u-szeged@partner.samsung.com>
2030
2031         REGRESSION (r160085): check-webkit-style: utf8' codec can't decode byte 0x89 in position 0: invalid start byte.
2032         https://bugs.webkit.org/show_bug.cgi?id=126702
2033
2034         Reviewed by Alexey Proskuryakov.
2035
2036         Resolve regression and remove a FIXME comment that is already fixed.
2037
2038         * Scripts/webkitpy/common/system/filesystem.py:
2039         (FileSystem.open_text_file_for_reading):
2040         * Scripts/webkitpy/common/system/filesystem_unittest.py:
2041         (RealFileSystemTest.test_read_and_write_file):
2042         * Scripts/webkitpy/style/filereader.py:
2043         (TextFileReader._read_lines):
2044         * Scripts/webkitpy/style/filereader_unittest.py:
2045         (TextFileReaderTest.test_count_delete_only_file):
2046         (TextFileReaderTest):
2047         (TextFileReaderTest.test_process_malformed_file):
2048
2049 2014-01-02  Brian Holt  <brian.holt@samsung.com>
2050
2051         [GTK] Parse Valgrind xml leak files
2052         https://bugs.webkit.org/show_bug.cgi?id=119446
2053
2054         Reviewed by Alejandro G. Castro.
2055
2056         Parse the xml files generated by Valgrind to yield useful
2057         information about the memory leaks.
2058
2059         * Scripts/webkitpy/port/gtk.py:
2060         (GtkPort.__init__):
2061         (GtkPort.setup_test_run): Clear the previous output files before new
2062         run.
2063         (GtkPort.print_leaks_summary):
2064
2065         * Scripts/webkitpy/port/leakdetector_valgrind.py: Added.
2066         Parse the xml files generated by Valgrind and summarise leaks
2067         into an easily understandable list.
2068         (get_text_of):
2069         (get_CDATA_of):
2070         (gather_frames):
2071         (ValgrindError):
2072         (ValgrindError.__init__):
2073         (ValgrindError.__str__):
2074         (ValgrindError.unique_string):
2075         (ValgrindError.error_hash):
2076         (ValgrindError.__hash__):
2077         (ValgrindError.__eq__):
2078         (LeakDetectorValgrind):
2079         (LeakDetectorValgrind.__init__):
2080         (LeakDetectorValgrind._parse_leaks_output):
2081         (LeakDetectorValgrind.leaks_files_in_results_directory):
2082         (LeakDetectorValgrind.clean_leaks_files_from_results_directory):
2083         (LeakDetectorValgrind.parse_and_print_leaks_detail):
2084
2085         * Scripts/webkitpy/port/leakdetector_valgrind_unittest.py: Added.
2086         (make_mock_valgrind_output):
2087         (make_mock_incomplete_valgrind_output):
2088         (make_mock_valgrind_results):
2089         (make_mock_valgrind_results_incomplete):
2090         (make_mock_valgrind_results_empty):
2091         (make_mock_valgrind_results_misformatted):
2092         (mock_run_cppfilt_command):
2093         (LeakDetectorValgrindTest):
2094         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_pass):
2095         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_incomplete):
2096         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_empty):
2097         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_misformatted):
2098         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_pass):
2099         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_incomplete):
2100         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_empty):
2101         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_misformatted):
2102
2103 2014-01-13  Lucas Forschler  <lforschler@apple.com>
2104
2105         Update the LLINT CLoop Bot build infrastructure
2106         https://bugs.webkit.org/show_bug.cgi?id=126604
2107         
2108         Unreviewed.
2109         
2110         * BuildSlaveSupport/build.webkit.org-config/config.json:
2111         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2112         (CompileLLINTCLoop):
2113         (RunLLINTCLoopTests):
2114         (BuildAndTestLLINTCLoopFactory):
2115         (BuildAndTestLLINTCLoopFactory.__init__):
2116
2117 2014-01-13  Jinwoo Song  <jinwoo7.song@samsung.com>
2118
2119         [EFL][WK2] Disable failing API tests
2120         https://bugs.webkit.org/show_bug.cgi?id=126960
2121
2122         Reviewed by Gyuyoung Kim.
2123
2124         Disable WKViewUserViewportToContents test until bug 126261 is resolved.
2125
2126         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
2127         (TestWebKitAPI::TEST):
2128
2129 2014-01-13  Daniel Batyai  <dbatyai.u-szeged@partner.samsung.com>
2130
2131         Remove wdiff
2132         https://bugs.webkit.org/show_bug.cgi?id=124766
2133
2134         Reviewed by Ryosuke Niwa.
2135
2136         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
2137         (ResultsJSONParserTest):
2138         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2139         (TestResultWriter):
2140         (TestResultWriter.create_text_diff_and_write_result):
2141         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2142         (summarize_results):
2143         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2144         (RunTest.test_output_diffs):
2145         * Scripts/webkitpy/port/base.py:
2146         (Port.__init__):
2147         (Port.driver_stop_timeout):
2148         (Port.check_image_diff):
2149         (Port.repository_paths):
2150         (Port._path_to_lighttpd_php):
2151         * Scripts/webkitpy/port/base_unittest.py:
2152         (PortTest.test_default_child_processes):
2153         (PortTest.test_pretty_patch_script_error):
2154         * Scripts/webkitpy/port/port_testcase.py:
2155         (PortTestCase.test_diff_image_crashed):
2156         * Scripts/webkitpy/port/test.py:
2157         (TestPort.operating_system):
2158
2159 2014-01-13  Martin Robinson  <mrobinson@igalia.com>
2160
2161         Build fix for the GTK+ CMake port
2162
2163         * TestWebKitAPI/PlatformGTK.cmake: The WKConnection test is no longer with us.
2164
2165 2014-01-13  Adrian Perez de Castro  <aperez@igalia.com>
2166
2167         [GTK] Add cast in call to g_object_add_weak_pointer in MiniBrowser
2168         https://bugs.webkit.org/show_bug.cgi?id=126881
2169
2170         Reviewed by Carlos Garcia Campos.
2171
2172         * MiniBrowser/gtk/BrowserWindow.c:
2173         (browser_window_new):
2174         Explicitly cast GtkWindow** to gpointer* in call to
2175         g_object_add_weak_pointer to avoid compiler warnings.
2176
2177 2014-01-13  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
2178
2179         Remove parsing of old-run-webkit-tests output from master.cfg
2180         https://bugs.webkit.org/show_bug.cgi?id=126690
2181
2182         Reviewed by Csaba Osztrogonác.
2183
2184         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2185         Removed parsing of ORWT output, as it is not used anymore.
2186         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2187         Updated unit tests accordingly.
2188
2189 2014-01-13  Commit Queue  <commit-queue@webkit.org>
2190
2191         Unreviewed, rolling out r161808.
2192         http://trac.webkit.org/changeset/161808
2193         https://bugs.webkit.org/show_bug.cgi?id=126874
2194
2195         This patch make several files to be always regenerated on
2196         every make (Requested by KaL on #webkit).
2197
2198         * WebKitTestRunner/GNUmakefile.am:
2199
2200 2014-01-13  Adrian Perez de Castro  <aperez@igalia.com>
2201
2202         [GTK] Make MiniBrowser windows non-transient by default
2203         https://bugs.webkit.org/show_bug.cgi?id=126840
2204
2205         Reviewed by Carlos Garcia Campos.
2206
2207         Instead of making new browser windows transient as soon as they are
2208         created, save the pointer to the parent window and set the transient
2209         state later on when handling the "run-as-modal" signal. This makes
2210         it easier to use the MiniBrowser to do tests involving multiple
2211         windows, and will be useful as well when multi-web-process mode is
2212         enabled for the GTK port.
2213
2214         * MiniBrowser/gtk/BrowserWindow.c:
2215         (webViewRunAsModal): Set the parent window using
2216         gtk_window_set_transient_for() using the saved parent
2217         window.
2218         (browser_window_new): Save the parent window using
2219         g_object_set_data() instead of making the new window
2220         transient immediately.
2221
2222 2014-01-12  Sergio Correia  <sergio.correia@openbossa.org>
2223
2224         [EFL][WK2] Make API tests work again
2225         https://bugs.webkit.org/show_bug.cgi?id=126769
2226
2227         Reviewed by Gyuyoung Kim.
2228
2229         The EFL and WK2 test binaries are currently being generated at *TestWebKitAPI/
2230         [E]WebKit2, respectively, and this causes problems because the logic to find
2231         where WebProcess is to look in the same directory of the running process and
2232         then proceed to use LIBEXECDIR (typically /usr/loca/bin).
2233
2234         This patch introduces a WEBKIT_EXEC_PATH environment variable, inspired in the
2235         Gtk port, which allows us to look for WebProcess initially in this directory,
2236         if it's defined.
2237
2238         * TestWebKitAPI/efl/main.cpp:
2239         (main): Define WEBKIT_EXEC_PATH to be used by WebKit2 API tests.
2240
2241 2014-01-12  Daniel Bates  <dabates@apple.com>
2242
2243         [iOS] Fix the build
2244
2245         For now, ensure we build WebKit System Interface before we build WebKit.
2246         We'll remove this constraint and the constraint to build WebKit Additions
2247         in a subsequent commit.
2248
2249         * Scripts/build-webkit:
2250
2251 2014-01-12  Carlos Garcia Campos  <cgarcia@igalia.com>
2252
2253         Unreviewed. Fix make distcheck.
2254
2255         * gtk/GNUmakefile.am: Add generate-inspector-gresource-manifest.py
2256         to EXTRA_DIST.
2257
2258 2014-01-12  Tobias Mueller  <tobiasmue@gnome.org>
2259
2260         --disable-dependency-tracking causes build failure due to missing directories
2261         https://bugs.webkit.org/show_bug.cgi?id=94488
2262
2263         Reviewed by Gustavo Noronha Silva.
2264
2265         Autotools build fix: Ensure output directory existing
2266         before generating DerivedSources. This allows for
2267         --disable-dependency-tracking to be run.
2268
2269
2270         * WebKitTestRunner/GNUmakefile.am: Added a new target of the directory in which files are meant to be stored.
2271
2272 2014-01-12  Carlos Garcia Campos  <cgarcia@igalia.com>
2273
2274         [GTK] Fix return value of WebKitDownload::created-destination
2275         https://bugs.webkit.org/show_bug.cgi?id=126741
2276
2277         Reviewed by Martin Robinson.
2278
2279         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp: Fix return
2280         value of several callbacks.
2281
2282 2014-01-11  Sam Weinig  <sam@webkit.org>
2283
2284         Add support for null StringViews
2285         https://bugs.webkit.org/show_bug.cgi?id=126827
2286
2287         Reviewed by Anders Carlsson.
2288
2289         Add new test for StringView.
2290
2291         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2292         * TestWebKitAPI/Tests/WTF/StringView.cpp: Added.
2293         (TestWebKitAPI::TEST):
2294
2295 2014-01-10  Benjamin Poulain  <bpoulain@apple.com>
2296
2297         Remove the BlackBerry port from trunk
2298         https://bugs.webkit.org/show_bug.cgi?id=126715
2299
2300         Reviewed by Anders Carlsson.
2301
2302         * DumpRenderTree/DumpRenderTree.h:
2303         * DumpRenderTree/PixelDumpSupport.cpp:
2304
2305 2014-01-10  Daniel Bates  <dabates@apple.com>
2306
2307         [iOS] Fix project build order
2308
2309         Ensure we build WebKitAdditions before WebCore (if applicable). Also, we don't
2310         build WebInspectorUI, Tools/MiniBrowser, or Tools/WebKitTestRunner on iOS at the
2311         time of writing.
2312
2313         * Scripts/build-webkit:
2314
2315 2014-01-10  Mario Sanchez Prada  <mario.prada@samsung.com>
2316
2317         Move platformName property from testRunner to accessibilityController
2318         https://bugs.webkit.org/show_bug.cgi?id=126689
2319
2320         Reviewed by Chris Fleizach.
2321
2322         Move the platformName property from the testRunner into
2323         accessibilityController, since this is a concept that has only be
2324         used by accessibility tests since it got added, and also because
2325         the real intention was not to distinguish among "ports" (mac, win,
2326         gtk, efl) but between platforms (atk, mac, win).
2327
2328         This change will be very useful to merge GTK's roles-exposed.html
2329         and Mac's role-subrole-roledescription.html into one single test,
2330         since we will be specifying in the test itself which elements are
2331         supported in which accessibility "platform". In this context,
2332         being able to check accessibilityController.platformName directly
2333         against a list of supported accessibility platforms (e.g. "atk,mac")
2334         will certainly maintain the code cleaner and simpler.
2335
2336         * DumpRenderTree/TestRunner.h:
2337         (TestRunner::platformName): Removed.
2338         * DumpRenderTree/TestRunner.cpp:
2339         (getPlatformNameCallback): Removed.
2340         (TestRunner::staticValues): Removed platformName
2341         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2342         (TestRunner::platformName): Removed.
2343         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
2344         (TestRunner::platformName): Removed.
2345         * DumpRenderTree/mac/TestRunnerMac.mm:
2346         (TestRunner::platformName): Removed.
2347         * DumpRenderTree/win/TestRunnerWin.cpp:
2348         (TestRunner::platformName): Removed.
2349
2350         * DumpRenderTree/AccessibilityController.h:
2351         (AccessibilityController::platformName): Added.
2352         * DumpRenderTree/AccessibilityController.cpp:
2353         (getPlatformNameCallback): Added.
2354         (AccessibilityController::getJSClass): Added platformName.
2355         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
2356         (AccessibilityController::platformName): Added, returning "atk".
2357         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2358         (AccessibilityController::platformName): Ditto, returning "mac".
2359         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
2360         (AccessibilityController::platformName): Ditto, returning "ios".
2361         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2362         (AccessibilityController::platformName): Ditto, returning "win".
2363
2364         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2365         (platformName): Removed.
2366         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2367         (TestRunner::platformName): Removed.
2368         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
2369         (TestRunner::platformName): Removed.
2370         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
2371         (TestRunner::platformName): Removed.
2372         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
2373         (TestRunner::platformName): Removed.
2374         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp:
2375         (TestRunner::platformName): Removed.
2376
2377         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
2378         (WTR:AccessibilityController::platformName): Added.
2379         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
2380         (platformName): Added.
2381         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
2382         (WTR::AccessibilityController::platformName): Added, returning "atk".
2383         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
2384         (WTR::AccessibilityController::platformName): Added, returning "mac".
2385
2386 2014-01-10  Benjamin Poulain  <bpoulain@apple.com>
2387
2388         Remove the BlackBerry port from trunk
2389         https://bugs.webkit.org/show_bug.cgi?id=126715
2390
2391         Reviewed by Anders Carlsson.
2392
2393         * Scripts/webkitpy/common/config/watchlist:
2394
2395 2014-01-09  Benjamin Poulain  <bpoulain@apple.com>
2396
2397         Remove the BlackBerry files outside WebCore
2398         https://bugs.webkit.org/show_bug.cgi?id=126715
2399
2400         Reviewed by Anders Carlsson.
2401
2402         * DumpRenderTree/blackberry: Removed.
2403
2404 2014-01-10  Simon Fraser  <simon.fraser@apple.com>
2405
2406         Remove knowledge of Blackberry from build scripts
2407         https://bugs.webkit.org/show_bug.cgi?id=126766
2408
2409         Reviewed by Anders Carlsson.
2410         
2411         Remove isBlackBerry() and references to it, and rmeove
2412         blackberry-related stuff from the watchlist.
2413
2414         * Scripts/build-webkit:
2415         * Scripts/webkit-build-directory:
2416         * Scripts/webkitdirs.pm:
2417         (determineBaseProductDir):
2418         (argumentsForConfiguration):
2419         (builtDylibPathForName):
2420         (isAppleWebKit):
2421         (buildCMakeProjectOrExit):
2422         (cmakeBasedPortArguments):
2423         (cmakeBasedPortName):
2424         * Scripts/webkitperl/FeatureList.pm:
2425         * Scripts/webkitpy/common/config/watchlist:
2426
2427 2014-01-10  Daniel Bates  <dabates@apple.com>
2428
2429         [iOS] Fix up simulator build and enable default features
2430
2431         Rubber-stamped by Joseph Pecoraro.
2432
2433         * Scripts/webkitdirs.pm:
2434         (determineArchitecture):
2435         (determinePassedArchitecture):
2436         * Scripts/webkitperl/FeatureList.pm: Also expose command line option to toggle ENABLE_PLUGIN_PROXY_FOR_VIDEO (enabled
2437         by default only in iOS).
2438
2439 2014-01-10  Daniel Bates  <dabates@apple.com>
2440
2441         [iOS] Upstream WebCore and Tools miscellaneous changes
2442         https://bugs.webkit.org/show_bug.cgi?id=126698
2443
2444         Reviewed by David Kilzer.
2445
2446         * Scripts/check-for-inappropriate-objc-class-names:
2447         * Scripts/check-for-webkit-framework-include-consistency:
2448
2449 2014-01-09  Dan Bernstein  <mitz@apple.com>
2450
2451         [Cocoa] Promote WKBackForwardList{,Item}.h to public
2452         https://bugs.webkit.org/show_bug.cgi?id=126707
2453
2454         Reviewed by Sam Weinig.
2455
2456         * Scripts/check-for-webkit-framework-include-consistency: Account for stale private headers
2457         left behind in the build products directory after a private header is made public.
2458
2459 2014-01-09  Carlos Garcia Campos  <cgarcia@igalia.com>
2460
2461         [SOUP] Partial file left on disk after a download fails or is cancelled in WebKit2
2462         https://bugs.webkit.org/show_bug.cgi?id=126686
2463
2464         Reviewed by Martin Robinson.
2465
2466         Test that partial files are not left on disk after a download has
2467         been cancelled after the destination has been decided. To make
2468         sure the download is cancelled after the destination has been
2469         decided and before the operation finishes, we cancel the download
2470         in the destination decided callback, and we use an infinite
2471         resource that writes chunks to the response body and never
2472         completes the body.
2473
2474         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
2475         (addContentDispositionHTTPHeaderToResponse): Helper function to
2476         add the Content-Disposition to the response headers.
2477         (writeNextChunkIdle): Write next chunk to response body.
2478         (writeNextChunk): Write next chunk in an idle to avoid flooding
2479         the network with the inifnite resource.
2480         (serverCallback): Add an inifinite resource.
2481         (testDownloadRemoteFileError): Check that partial file is not
2482         present after the download has been cancelled.
2483
2484 2014-01-09  Roland Takacs  <rtakacs@inf.u-szeged.hu>
2485
2486         Move myself to the committers list.
2487
2488         Unreviewed.
2489
2490         * Scripts/webkitpy/common/config/contributors.json:
2491
2492 2014-01-08  Seokju Kwon  <seokju@webkit.org>
2493
2494         [GTK] Unreviewed build fix after r161522.
2495
2496         * TestWebKitAPI/GNUmakefile.am: Remove WKConnection.cpp and WKConnection_Bundle.cpp.
2497
2498 2014-01-08  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
2499
2500         Missleading style error when mixing system and non-system header include lines.
2501         https://bugs.webkit.org/show_bug.cgi?id=126564
2502
2503         Reviewed by Ryosuke Niwa.
2504
2505         * Scripts/webkitpy/style/checkers/cpp.py:
2506         (check_include_line):
2507         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2508         (OrderOfIncludesTest.test_check_alphabetical_include_order):
2509         (OrderOfIncludesTest.test_public_primary_header):
2510
2511 2014-01-08  Seokju Kwon  <seokju@webkit.org>
2512
2513         [EFL] Unreviewed build fix after r161522.
2514
2515         * TestWebKitAPI/CMakeLists.txt:
2516         * TestWebKitAPI/PlatformEfl.cmake:
2517
2518 2014-01-08  Anders Carlsson  <andersca@apple.com>
2519
2520         Remove WKConnectionRef tests
2521         https://bugs.webkit.org/show_bug.cgi?id=126666
2522
2523         Reviewed by Dan Bernstein.
2524
2525         The WKConnectionRef is poorly designed but thankfully not used anywhere. 
2526         Remove the API tests as a first step towards killing the entire thing.
2527
2528         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2529         * TestWebKitAPI/Tests/WebKit2/WKConnection.cpp: Removed.
2530         * TestWebKitAPI/Tests/WebKit2/WKConnection_Bundle.cpp: Removed.
2531
2532 2014-01-08  Commit Queue  <commit-queue@webkit.org>
2533
2534         Unreviewed, rolling out r161512.
2535         http://trac.webkit.org/changeset/161512
2536         https://bugs.webkit.org/show_bug.cgi?id=126655
2537
2538         Broke webkitpy tests (Requested by ap on #webkit).
2539
2540         * Scripts/webkitpy/port/gtk.py:
2541         (GtkPort.__init__):
2542         (GtkPort.setup_test_run):
2543         (GtkPort._port_specific_expectations_files):
2544         * Scripts/webkitpy/port/leakdetector_valgrind.py: Removed.
2545         * Scripts/webkitpy/port/leakdetector_valgrind_unittest.py: Removed.
2546
2547 2014-01-08  Commit Queue  <commit-queue@webkit.org>
2548
2549         Unreviewed, rolling out r161517.
2550         http://trac.webkit.org/changeset/161517
2551         https://bugs.webkit.org/show_bug.cgi?id=126659
2552
2553         The fix didn't completely remove the problem and is now
2554         standing in the way of the rollout of the offending patch
2555         (Requested by zdobersek on #webkit).
2556
2557         * Scripts/webkitpy/port/gtk.py:
2558         (GtkPort.__init__):
2559
2560 2014-01-08  Zan Dobersek  <zdobersek@igalia.com>
2561
2562         Unreviewed. Attempting to fix webkitpy tests after r161512.
2563
2564         * Scripts/webkitpy/port/gtk.py:
2565         (GtkPort.__init__): Construct LeakDetectorValgrin only if leak detection is enabled.
2566
2567 2014-01-08  Brian Holt  <brian.holt@samsung.com>
2568
2569         [GTK] Parse Valgrind xml leak files
2570         https://bugs.webkit.org/show_bug.cgi?id=119446
2571
2572         Reviewed by Alejandro G. Castro.
2573
2574         Parse the xml files generated by Valgrind to yield useful
2575         information about the memory leaks.
2576
2577         * Scripts/webkitpy/port/gtk.py:
2578         (GtkPort.__init__):
2579         (GtkPort.setup_test_run): Clear the previous output files before new
2580         run.
2581         (GtkPort.print_leaks_summary):
2582
2583         * Scripts/webkitpy/port/leakdetector_valgrind.py: Added.
2584         Parse the xml files generated by Valgrind and summarise leaks
2585         into an easily understandable list.
2586         (get_text_of):
2587         (get_CDATA_of):
2588         (gather_frames):
2589         (ValgrindError):
2590         (ValgrindError.__init__):
2591         (ValgrindError.__str__):
2592         (ValgrindError.unique_string):
2593         (ValgrindError.error_hash):
2594         (ValgrindError.__hash__):
2595         (ValgrindError.__eq__):
2596         (LeakDetectorValgrind):
2597         (LeakDetectorValgrind.__init__):
2598         (LeakDetectorValgrind._parse_leaks_output):
2599         (LeakDetectorValgrind.leaks_files_in_results_directory):
2600         (LeakDetectorValgrind.clean_leaks_files_from_results_directory):
2601         (LeakDetectorValgrind.parse_and_print_leaks_detail):
2602
2603         * Scripts/webkitpy/port/leakdetector_valgrind_unittest.py: Added.
2604         (make_mock_valgrind_output):
2605         (make_mock_incomplete_valgrind_output):
2606         (make_mock_valgrind_results):
2607         (make_mock_valgrind_results_incomplete):
2608         (make_mock_valgrind_results_empty):
2609         (make_mock_valgrind_results_misformatted):
2610         (LeakDetectorValgrindTest):
2611         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_pass):
2612         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_incomplete):
2613         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_empty):
2614         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_misformatted):
2615         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_pass):
2616         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_incomplete):
2617         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_empty):
2618         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_misformatted):
2619
2620 2014-01-08  Commit Queue  <commit-queue@webkit.org>
2621
2622         Unreviewed, rolling out r161427.
2623         http://trac.webkit.org/changeset/161427
2624         https://bugs.webkit.org/show_bug.cgi?id=126645
2625
2626         Emits a stye error on any newly added files (Requested by ap
2627         on #webkit).
2628
2629         * Scripts/webkitpy/style/checkers/cpp.py:
2630         (check_style):
2631         (CppChecker):
2632         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2633         (WebKitStyleTest.test_other):
2634
2635 2014-01-08  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
2636
2637         Remove run-webkit-tests wrapper script as all platform are using NRWT now.
2638         https://bugs.webkit.org/show_bug.cgi?id=126580
2639
2640         Reviewed by Csaba Osztrogonác.
2641
2642         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2643         (RunWebKitTests): Passing --debug-rwt-logging here instead of the
2644         run-webkit-tests script.
2645         * Scripts/new-run-webkit-tests: Renamed to run-webkit-tests.
2646         * Scripts/run-webkit-tests: Removed, as it was just a temporary hack.
2647
2648 2014-01-08  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
2649
2650         Update the list of non-committer u-szeged contributors
2651         https://bugs.webkit.org/show_bug.cgi?id=126640
2652
2653         Reviewed by Csaba Osztrogonác.
2654
2655         * Scripts/webkitpy/common/config/contributors.json:
2656
2657 2014-01-08  Alberto Garcia  <berto@igalia.com>
2658
2659         Fix some compilation warnings
2660         https://bugs.webkit.org/show_bug.cgi?id=126635
2661
2662         Reviewed by Csaba Osztrogonác.
2663
2664         * GtkLauncher/main.c:
2665         (createWindow): This function is not supposed to receive any
2666         parameter, yet we are passing one.
2667
2668 2014-01-08  Brian Holt  <brian.holt@samsung.com>
2669
2670         [GTK][WK2] unskip passing unit tests
2671         https://bugs.webkit.org/show_bug.cgi?id=126637
2672
2673         Reviewed by Carlos Garcia Campos.
2674
2675         Unskip TestResources and TestAuthentication unit tests since they
2676         are passing both under Xvfb and X.
2677
2678         * Scripts/run-gtk-tests:
2679         (TestRunner):
2680
2681 2014-01-08  Alberto Garcia  <berto@igalia.com>
2682
2683         REGRESSION(r160304): [GTK] Disable libtool fast install
2684         https://bugs.webkit.org/show_bug.cgi?id=126381
2685
2686         Reviewed by Gustavo Noronha Silva.
2687
2688         Disable the libtool fast-install mode in developer/test builds.
2689
2690         In this mode binaries are generated ready to be used directly from
2691         the build tree. Otherwise they would need to be relinked when they
2692         are executed, which can take a lot of resources, particularly in
2693         debug builds.
2694
2695         * Scripts/webkitdirs.pm:
2696         (runAutogenForAutotoolsProjectIfNecessary):
2697
2698 2014-01-08  Zan Dobersek  <zdobersek@igalia.com>
2699
2700         Unreviewed GTK gardening.
2701
2702         * Scripts/run-gtk-tests:
2703         (TestRunner): Skipping the snapshot test case from the TestWebKitWebView test suite.
2704         The test is failing due to issues with Xvfb, with the problem being handled in bug #120404.
2705
2706 2014-01-07  Lucas Forschler  <lforschler@apple.com>
2707
2708         Add buildbot infrasctructure for building and testing JSC cloop
2709         https://bugs.webkit.org/show_bug.cgi?id=126604
2710
2711         Reviewed by Geoffrey Garen.
2712
2713         * BuildSlaveSupport/build.webkit.org-config/config.json:
2714         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2715         (CompileCLOOP):
2716         (RunCLOOPTests):
2717         (RunCLOOPTests.countFailures):
2718         (BuildAndTestCLOOP):
2719
2720 2014-01-07  Brian Burg  <bburg@apple.com>
2721
2722         Unreviewed. Add myself as a committer.
2723
2724         * Scripts/webkitpy/common/config/contributors.json:
2725
2726 2014-01-07  Alexey Proskuryakov  <ap@apple.com>
2727
2728         Popovers at build.webkit.org/dashboard could have titles
2729         https://bugs.webkit.org/show_bug.cgi?id=126495
2730
2731         Reviewed by Timothy Hatcher.
2732
2733         Added titles to all popovers except for pending revisions one, which I would like
2734         to improve more (probably add an ETA).
2735
2736         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
2737         (BuildbotBuilderQueueView.prototype._presentPopoverFailureLogs): Moved code for 
2738         adding a title to base class.
2739
2740         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2741         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Moved code for inserting
2742         a divider to a separate function.
2743         (BuildbotQueueView.prototype._presentPopoverForRevisionRange): Added a title.
2744         (BuildbotQueueView.prototype._presentNoChangePopover): Updated the text to match
2745         title from above function.
2746         (BuildbotQueueView.prototype._revisionPopoverContentForIteration): Renamed "contentElement"
2747         variable to "content" to match all other code.
2748         (BuildbotQueueView.prototype._addIterationHeadingToPopover): Added.
2749         (BuildbotQueueView.prototype._addDividerToPopover): Added.
2750
2751         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2752         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions): Add a title.
2753         (BuildbotTesterQueueView.prototype._presentPopoverForLayoutTestRegressions): Ditto.
2754         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds): Ditto.
2755
2756         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
2757
2758 2014-01-07  Alexey Proskuryakov  <ap@apple.com>
2759
2760         There should be a delay when quickly switching to a different popover at build.webkit.org/dashboard
2761         https://bugs.webkit.org/show_bug.cgi?id=126472
2762
2763         Reviewed by Timothy Hatcher.
2764
2765         Added a delay when quickly switching to a different popover, making it easier to
2766         move mouse pointer from active element to its popover without accidentally opening
2767         a different popover.
2768
2769         Used this code to add a delay before creating a popover. This doesn't change UI
2770         behavior, as there was alerady a delay before it became visible, but it avoids
2771         flooding buildbot server with http requests when quickly moving the mouse over
2772         dashboard page.
2773
2774         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Popover.js:
2775         Fixed a case where popover could get stuck. If content was updated while fade-out
2776         transition was already in place, the transition was removed for no good reason.
2777
2778         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js:
2779         (PopoverTracker._onblur): While at it, also taught popovers to disappear on window blur.
2780
2781         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Popover.css:
2782         (.popover.step-in): Now that PopoverTracker has a 200ms delay of its own, reduced
2783         popover delay from 1s to 800ms.
2784
2785 2014-01-07  Alexey Proskuryakov  <ap@apple.com>
2786
2787         Improve display of failed builds at build.webkit.org/dashboard
2788         https://bugs.webkit.org/show_bug.cgi?id=126542
2789         <rdar://problem/15753550>
2790
2791         Reviewed by Timothy Hatcher.
2792
2793         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
2794         Instead of hardcoding step name, look for the first step that failed.
2795         While at it, added a popover with more links. There are multiple, and it's good
2796         to have a choice of which one to look at in each situation.
2797
2798         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2799         (BuildbotIteration.prototype.get successful): Being successful is not the opposite
2800         of having failed. Many iterations are interrupted for whatever reason internal to
2801         Buildbot, and these are suppoed to be orange, not red.
2802         (BuildbotIteration.prototype.get productive): Changed to exclude inerrupted iterations,
2803         not only WillRetry ones.
2804         (BuildbotIteration.prototype.get failed): Changed to only include iterations that
2805         actually failed, more likely indicating a problem with code base.
2806         (BuildbotIteration.prototype.get firstFailedStepName):
2807         (BuildbotIteration.prototype.failureLogURL): Expose informaiton about failure.
2808         (BuildbotIteration.prototype.get failureLogs): Ditto.
2809         (BuildbotIteration.prototype.update): Store complete results for the failed step.
2810         Not every failure stops the iteration, so we could have multiple failed steps,
2811         but let's see if seeing just the first one will be enough.
2812
2813         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2814         (BuildbotQueue.prototype.get firstRecentUnsuccessfulIteration): Updated to work in
2815         terms of successful iterations.
2816         (BuildbotQueue.prototype.get mostRecentSuccessfulIteration): Ditto.
2817
2818         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2819         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Updated to work in
2820         terms of successful iterations.
2821
2822         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2823         Removed code to create a path to build output, we now take it from results JSON.
2824
2825         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
2826         Added styles for the new popover.
2827
2828 2014-01-07  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
2829
2830         defined constants should use all uppercase names with words separated by underscores.
2831         https://bugs.webkit.org/show_bug.cgi?id=126055
2832
2833         Reviewed by Alexey Proskuryakov.
2834
2835         * Scripts/webkitpy/style/checkers/cpp.py:
2836         (check_style):
2837         (CppChecker):
2838         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2839         (WebKitStyleTest.test_define_constants):
2840
2841 2014-01-07  Brian Holt  <brian.holt@samsung.com>
2842
2843         Unreviewed. Add myself as a committer.
2844
2845         * Scripts/webkitpy/common/config/contributors.json:
2846
2847 2014-01-07  Csaba Osztrogonác  <ossy@webkit.org>
2848
2849         Remove the WinCE buildbot from build.webkit.org
2850         https://bugs.webkit.org/show_bug.cgi?id=126517
2851
2852         Reviewed by Alexey Proskuryakov.
2853
2854         * BuildSlaveSupport/build.webkit.org-config/config.json:
2855         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2856         (appendCustomBuildFlags):
2857
2858 2014-01-07  Krzysztof Czech  <k.czech@samsung.com>
2859
2860         [EFL] Change ATK version to 2.11.4
2861         https://bugs.webkit.org/show_bug.cgi?id=126573
2862
2863         Reviewed by Gyuyoung Kim.
2864
2865         ATK 2.11.4 introduces some new roles, that are already being used by WebKit.
2866
2867         * efl/jhbuild.modules:
2868
2869 2014-01-07  Alberto Garcia  <berto@igalia.com>
2870
2871         [GTK][EFL] Use function jhbuildWrapperPrefixIfNeeded to run launcher
2872         https://bugs.webkit.org/show_bug.cgi?id=117275
2873
2874         Reviewed by Carlos Garcia Campos.
2875
2876         If we are not using the internal jhbuild we must not use the
2877         jhbuild-wrapper script, else it will try to download and install
2878         it.
2879
2880         * Scripts/run-launcher:
2881
2882 2014-01-07  Krzysztof Czech  <k.czech@samsung.com>
2883
2884         [ATK] Expose aria-checked mixed state as ATK_STATE_INDETERMINATE
2885         https://bugs.webkit.org/show_bug.cgi?id=125855
2886
2887         Reviewed by Mario Sanchez Prada.
2888
2889         Added new function isIndeterminate for testing aria-checked mixed state.
2890         I provided respective, but empty function in mac port. Mac testing it differently.
2891
2892         * DumpRenderTree/AccessibilityUIElement.cpp:
2893         (getIsIndeterminate):
2894         (AccessibilityUIElement::getJSClass):
2895         * DumpRenderTree/AccessibilityUIElement.h:
2896         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2897         (AccessibilityUIElement::isIndeterminate):
2898         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm: Added empty function.
2899         (AccessibilityUIElement::isIndeterminate):
2900         * DumpRenderTree/mac/AccessibilityUIElementMac.mm: Added empty function.
2901         (AccessibilityUIElement::isIndeterminate):
2902         * DumpRenderTree/win/AccessibilityUIElementWin.cpp: Added empty function.
2903         (AccessibilityUIElement::isIndeterminate):
2904         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2905         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2906         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2907         (WTR::AccessibilityUIElement::isIndeterminate):
2908         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2909         (WTR::AccessibilityUIElement::isIndeterminate):
2910
2911 2014-01-06  Mark Rowe  <mrowe@apple.com>
2912
2913         <https://webkit.org/b/126560> Fix incorrectness in use of some AppKit enums
2914
2915         Reviewed by Ryosuke Niwa.
2916
2917         * DumpRenderTree/mac/DumpRenderTree.mm:
2918         (-[DRTMockScroller rectForPart:]): Move to using an if with early return instead of a switch
2919         with a single case. This avoids the potential for warnings about unhandled cases.
2920         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2921         (WTR::PlatformWebView::PlatformWebView): Cast the argument to NSBackingStoreType.
2922
2923 2014-01-04  Carlos Garcia Campos  <cgarcia@igalia.com>
2924
2925         [GTK] Move all GTK/GObject unit tests to Tools/TestWebKitAPI
2926         https://bugs.webkit.org/show_bug.cgi?id=126342
2927
2928         Reviewed by Gustavo Noronha Silva.
2929
2930         * CMakeLists.txt: Include the new unit tests subdirectories.
2931         * Scripts/run-gtk-tests: Update to refer to the new build locations.
2932         * Scripts/webkitpy/style/checker.py: Update the style checker.
2933         * Scripts/webkitpy/style/checker_unittest.py:
2934         * TestWebKitAPI/GNUmakefile.am:
2935         * TestWebKitAPI/Tests/WebKit2Gtk/AccessibilityTestServer.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/AccessibilityTestServer.cpp.
2936         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Added.
2937         * TestWebKitAPI/Tests/WebKit2Gtk/DOMDOMWindowTest.cpp: Added.
2938         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/DOMNodeTest.cpp.
2939         * TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/FrameTest.cpp.
2940         * TestWebKitAPI/Tests/WebKit2Gtk/InspectorTestServer.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/InspectorTestServer.cpp.
2941         * TestWebKitAPI/Tests/WebKit2Gtk/LoadTrackingTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/LoadTrackingTest.cpp.
2942         * TestWebKitAPI/Tests/WebKit2Gtk/LoadTrackingTest.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/LoadTrackingTest.h.
2943         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestAuthentication.cpp.
2944         * TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestBackForwardList.cpp.
2945         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestContextMenu.cpp.
2946         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestCookieManager.cpp.
2947         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMDOMWindow.cpp: Added.
2948         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestDOMNode.cpp.
2949         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestDownloads.cpp.
2950         * TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestFrame.cpp.
2951         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspector.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestInspector.cpp.
2952         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestInspectorServer.cpp.
2953         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestLoaderClient.cpp.
2954         * TestWebKitAPI/Tests/WebKit2Gtk/TestMain.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestMain.cpp.
2955         * TestWebKitAPI/Tests/WebKit2Gtk/TestMain.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestMain.h.
2956         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestPrinting.cpp.
2957         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestResources.cpp.
2958         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestSSL.cpp.
2959         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestUIClient.cpp.
2960         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebExtensions.cpp.
2961         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitAccessibility.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitAccessibility.cpp.
2962         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitFaviconDatabase.cpp.
2963         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFindController.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitFindController.cpp.
2964         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitPolicyClient.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitPolicyClient.cpp.
2965         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitSettings.cpp.
2966         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitVersion.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitVersion.cpp.
2967         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebContext.cpp.
2968         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebView.cpp.
2969         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebViewGroup.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebViewGroup.cpp.
2970         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebViewEditor.cpp.
2971         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebExtensionTest.cpp.
2972         * TestWebKitAPI/Tests/WebKit2Gtk/WebKitTestBus.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebKitTestBus.cpp.
2973         * TestWebKitAPI/Tests/WebKit2Gtk/WebKitTestBus.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebKitTestBus.h.
2974         * TestWebKitAPI/Tests/WebKit2Gtk/WebKitTestServer.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebKitTestServer.cpp.
2975         * TestWebKitAPI/Tests/WebKit2Gtk/WebKitTestServer.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebKitTestServer.h.
2976         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTest.cpp.
2977         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTest.h.
2978         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTestRunner.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTestRunner.cpp.
2979         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTestRunner.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTestRunner.h.
2980         * TestWebKitAPI/Tests/WebKit2Gtk/WebViewTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebViewTest.cpp.
2981         * TestWebKitAPI/Tests/WebKit2Gtk/WebViewTest.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebViewTest.h.
2982         * TestWebKitAPI/Tests/WebKit2Gtk/resources/link-title.js: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/resources/link-title.js.
2983         * TestWebKitAPI/Tests/WebKit2Gtk/resources/test-cert.pem: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/resources/test-cert.pem.
2984         * TestWebKitAPI/Tests/WebKit2Gtk/resources/test-key.pem: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/resources/test-key.pem.
2985         * TestWebKitAPI/Tests/WebKit2Gtk/resources/webkit2gtk-tests.gresource.xml: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/resources/webkit2gtk-tests.gresource.xml.
2986         * TestWebKitAPI/Tests/WebKitGtk/CMakeLists.txt: Added.
2987         * TestWebKitAPI/Tests/WebKitGtk/resources/blank.ico: Renamed from Source/WebKit/gtk/tests/resources/blank.ico.
2988         * TestWebKitAPI/Tests/WebKitGtk/resources/test.html: Renamed from Source/WebKit/gtk/tests/resources/test.html.
2989         * TestWebKitAPI/Tests/WebKitGtk/resources/test.ogg: Renamed from Source/WebKit/gtk/tests/resources/test.ogg.
2990         * TestWebKitAPI/Tests/WebKitGtk/resources/test.pdf: Renamed from Source/WebKit/gtk/tests/resources/test.pdf.
2991         * TestWebKitAPI/Tests/WebKitGtk/resources/test.txt: Renamed from Source/WebKit/gtk/tests/resources/test.txt.
2992         * TestWebKitAPI/Tests/WebKitGtk/test_utils.c: Renamed from Source/WebKit/gtk/tests/test_utils.c.
2993         * TestWebKitAPI/Tests/WebKitGtk/test_utils.h: Renamed from Source/WebKit/gtk/tests/test_utils.h.
2994         * TestWebKitAPI/Tests/WebKitGtk/testapplicationcache.c: Renamed from Source/WebKit/gtk/tests/testapplicationcache.c.
2995         * TestWebKitAPI/Tests/WebKitGtk/testatk.c: Renamed from Source/WebKit/gtk/tests/testatk.c.
2996         * TestWebKitAPI/Tests/WebKitGtk/testatkroles.c: Renamed from Source/WebKit/gtk/tests/testatkroles.c.
2997         * TestWebKitAPI/Tests/WebKitGtk/testcontextmenu.c: Renamed from Source/WebKit/gtk/tests/testcontextmenu.c.
2998         * TestWebKitAPI/Tests/WebKitGtk/testcopyandpaste.c: Renamed from Source/WebKit/gtk/tests/testcopyandpaste.c.
2999         * TestWebKitAPI/Tests/WebKitGtk/testdomdocument.c: Renamed from Source/WebKit/gtk/tests/testdomdocument.c.
3000         * TestWebKitAPI/Tests/WebKitGtk/testdomdomwindow.c: Renamed from Source/WebKit/gtk/tests/testdomdomwindow.c.
3001         * TestWebKitAPI/Tests/WebKitGtk/testdomnode.c: Renamed from Source/WebKit/gtk/tests/testdomnode.c.
3002         * TestWebKitAPI/Tests/WebKitGtk/testdownload.c: Renamed from Source/WebKit/gtk/tests/testdownload.c.
3003         * TestWebKitAPI/Tests/WebKitGtk/testfavicondatabase.c: Renamed from Source/WebKit/gtk/tests/testfavicondatabase.c.
3004         * TestWebKitAPI/Tests/WebKitGtk/testglobals.c: Renamed from Source/WebKit/gtk/tests/testglobals.c.
3005         * TestWebKitAPI/Tests/WebKitGtk/testhittestresult.c: Renamed from Source/WebKit/gtk/tests/testhittestresult.c.
3006         * TestWebKitAPI/Tests/WebKitGtk/testhttpbackend.c: Renamed from Source/WebKit/gtk/tests/testhttpbackend.c.
3007         * TestWebKitAPI/Tests/WebKitGtk/testkeyevents.c: Renamed from Source/WebKit/gtk/tests/testkeyevents.c.
3008         * TestWebKitAPI/Tests/WebKitGtk/testloading.c: Renamed from Source/WebKit/gtk/tests/testloading.c.
3009         * TestWebKitAPI/Tests/WebKitGtk/testmimehandling.c: Renamed from Source/WebKit/gtk/tests/testmimehandling.c.
3010         * TestWebKitAPI/Tests/WebKitGtk/testnetworkrequest.c: Renamed from Source/WebKit/gtk/tests/testnetworkrequest.c.
3011         * TestWebKitAPI/Tests/WebKitGtk/testnetworkresponse.c: Renamed from Source/WebKit/gtk/tests/testnetworkresponse.c.
3012         * TestWebKitAPI/Tests/WebKitGtk/testwebbackforwardlist.c: Renamed from Source/WebKit/gtk/tests/testwebbackforwardlist.c.
3013         * TestWebKitAPI/Tests/WebKitGtk/testwebdatasource.c: Renamed from Source/WebKit/gtk/tests/testwebdatasource.c.
3014         * TestWebKitAPI/Tests/WebKitGtk/testwebframe.c: Renamed from Source/WebKit/gtk/tests/testwebframe.c.
3015         * TestWebKitAPI/Tests/WebKitGtk/testwebhistoryitem.c: Renamed from Source/WebKit/gtk/tests/testwebhistoryitem.c.
3016         * TestWebKitAPI/Tests/WebKitGtk/testwebinspector.c: Renamed from Source/WebKit/gtk/tests/testwebinspector.c.
3017         * TestWebKitAPI/Tests/WebKitGtk/testwebplugindatabase.c: Renamed from Source/WebKit/gtk/tests/testwebplugindatabase.c.
3018         * TestWebKitAPI/Tests/WebKitGtk/testwebresource.c: Renamed from Source/WebKit/gtk/tests/testwebresource.c.
3019         * TestWebKitAPI/Tests/WebKitGtk/testwebsettings.c: Renamed from Source/WebKit/gtk/tests/testwebsettings.c.
3020         * TestWebKitAPI/Tests/WebKitGtk/testwebview.c: Renamed from Source/WebKit/gtk/tests/testwebview.c.
3021         * TestWebKitAPI/Tests/WebKitGtk/testwindow.c: Renamed from Source/WebKit/gtk/tests/testwindow.c.
3022
3023 2014-01-06  Alexey Proskuryakov  <ap@apple.com>
3024
3025         Gtk and Efl API test results confuse the dashboard
3026         https://bugs.webkit.org/show_bug.cgi?id=126535
3027
3028         Reviewed by Tim Horton.
3029
3030         Added "API tests" step as "platform api tests".
3031
3032         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
3033         (Buildbot.prototype.platformAPITestResultsURLForIteration):
3034         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3035         (BuildbotIteration):
3036         (BuildbotIteration.prototype.update):
3037         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3038         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
3039         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds):
3040
3041 2014-01-06  Tim Horton  <timothy_horton@apple.com>
3042
3043         build.webkit.org/dashboard should still function if localStorage is disabled
3044         https://bugs.webkit.org/show_bug.cgi?id=126511
3045
3046         Reviewed by Alexey Proskuryakov.
3047
3048         If localStorage is disabled, we should carry on with a warning.
3049
3050         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
3051         Don't show the gear if localStorage isn't working.
3052
3053         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
3054         (QueueView.prototype._updateHiddenState):
3055         Bail if localStorage isn't working.
3056
3057         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
3058         (Settings.prototype.available):
3059
3060 2014-01-02  Roger Fong  <roger_fong@apple.com>
3061
3062         Set VSINSTALLDIR in win ews start script.
3063         https://bugs.webkit.org/show_bug.cgi?id=126407
3064
3065         Reviewed by Brent Fulgham.
3066
3067         * EWSTools/start-queue-win.sh:
3068
3069 2014-01-06  Bem Jones-Bey  <bjonesbe@adobe.com>
3070
3071         Adding myself as a reviewer.
3072
3073         Unreviewed.
3074
3075         * Scripts/webkitpy/common/config/contributors.json:
3076
3077 2014-01-06  Zan Dobersek  <zdobersek@igalia.com>
3078
3079         Unreviewed. Unbreaking JSC tests after r161328.
3080
3081         * Scripts/webkitdirs.pm:
3082         (cmakeBasedPortName): Only recognize the GTK port as CMake-based if actually building
3083         through the CMake build system (i.e. passing --gtkcmake to build-webkit).
3084
3085 2014-01-05  Martin Robinson  <mrobinson@igalia.com>
3086
3087         [GTK][CMake] Add support for building the GTK+ port with cmake to build-webkit
3088         https://bugs.webkit.org/show_bug.cgi?id=126212
3089
3090         Reviewed by Daniel Bates.
3091
3092         Allow building the GTK+ cmake port with --gtkcmake.
3093
3094         * Scripts/build-webkit: Use the new isGtkCMake function to head down the CMake path
3095         when appropriate. Skip the autotoos path when isGtkAutotools is false.
3096         * Scripts/webkitdirs.pm: Add an isGtkCMake path in addition to the newly renamed isGtkAutotools.
3097         Add isGtk which checks isGtkCMake || isGtkAutotools
3098         (determineArchitecture): Use the CMake path for GTK+ when appropriate.
3099         (argumentsForConfiguration): use --gtkcmake when appropriate.
3100         (jscProductDir): Look in the CMake directory when appropriate.
3101         (builtDylibPathForName): CMake builds the library into a different directory, so handle that.
3102         (determineIsGtkCMake): Added.
3103         (isGtkCMake): Added.
3104         (isGtkAutotools): Renamed from isGtk.
3105         (isGtk): New function which returns isGtkAutotools || isGtkCMake.
3106         (determineIsGtkAutotools): Renamed from determineIsGtk.
3107         (cmakeBasedPortName): Added a GTK+ path.
3108
3109 2014-01-04  Martin Robinson  <mrobinson@igalia.com>
3110
3111         [GTK] [CMake] Fix the video and audio build
3112         https://bugs.webkit.org/show_bug.cgi?id=126464
3113
3114         Reviewed by Philippe Normand.
3115
3116         * GtkLauncher/CMakeLists.txt: Add GStreamer includes and libraries, since GtkLauncher uses it.
3117
3118 2014-01-03  Alexey Proskuryakov  <ap@apple.com>
3119
3120         It's confusing to have two elements link to the same URL at build.webkit.org/dashboard
3121         https://bugs.webkit.org/show_bug.cgi?id=126467
3122
3123         Reviewed by Geoffrey Garen.
3124
3125         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
3126         (StatusLineView): Don't linkify the label text, the bubble is easier to target with mouse
3127         pointer, or to tap.
3128
3129 2014-01-03  Alexey Proskuryakov  <ap@apple.com>
3130
3131         build.webkit.org/dashboard says "failed build" even if it's another step that failed
3132         https://bugs.webkit.org/show_bug.cgi?id=126461
3133
3134         Reviewed by Geoffrey Garen.
3135
3136         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
3137         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus): Link to main
3138         build page if it's not the compilation that failed. Use text from buildbot for description.
3139         Show a yellow icon if it's a different kind of failure.
3140
3141         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3142         (BuildbotIteration.prototype.update): Record whether it was compile-webkit step that failed.
3143
3144 2014-01-03  Bem Jones-Bey  <bjonesbe@adobe.com>
3145
3146         setup-git-clone fails to get email address from git
3147         https://bugs.webkit.org/show_bug.cgi?id=126446
3148
3149         Reviewed by Ryosuke Niwa.
3150
3151         The setup-git-clone command fails to get an email address from git
3152         because of a bug in VCSUtils. This patch fixes that bug, and also
3153         makes it so that when VCSUtils fails for real because of a local
3154         misconfiguration, the error message is actually presented to the user
3155         of setup-git-clone.
3156
3157         * Scripts/VCSUtils.pm:
3158         (gitConfig): Call isGit() instead of accessing $isGit directly to make
3159             sure that $isGit is properly initialized.
3160         * Scripts/webkitpy/tool/commands/setupgitclone.py:
3161         (SetupGitClone.execute): Pull out username and email acquistion to
3162             it's own method.
3163         (SetupGitClone._get_username_and_email): Catch the exception thrown
3164             when VCSUtils fails and print out the error message so that the
3165             user actually knows why the command failed.
3166
3167 2014-01-03  Alexey Proskuryakov  <ap@apple.com>
3168
3169         It feels too hard to get rid of a popover at build.webkit.org/dashboard
3170         https://bugs.webkit.org/show_bug.cgi?id=126451
3171
3172         Reviewed by Simon Fraser.
3173
3174         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Popover.css:
3175         (.popover.fade-out): Reduced the timeout - 200 ms is enough to not have flicker
3176         when moving the mouse from an element to its popover.
3177
3178 2014-01-03  Alexey Proskuryakov  <ap@apple.com>
3179
3180         Please add a way to quick peek at failing tests at build.webkit.org/dashboard
3181         https://bugs.webkit.org/show_bug.cgi?id=122181
3182
3183         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3184         (BuildbotQueueView.prototype._presentNoChangePopover): Update one more place for
3185         popover.present signature change.
3186
3187 2014-01-03  Alexey Proskuryakov  <ap@apple.com>
3188
3189         Please add a way to quick peek at failing tests at build.webkit.org/dashboard
3190         https://bugs.webkit.org/show_bug.cgi?id=122181
3191
3192         Reviewed by Timothy Hatcher and Timothy Horton.
3193
3194         Detailed results are saved by run-webkit-tests to full_results.json (which is actually
3195         JSONP). Dashboard will load them on demand.
3196
3197         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
3198         (Buildbot.prototype.layoutTestResultsURLForIteration): Moved from WebKitBuildbot.js
3199         and made it use a function from WebKitBuildbot that builds results directory path.
3200         (Buildbot.prototype.layoutTestFullResultsURLForIteration): Added a function that builds
3201         a URL for full_results.json.
3202         (Buildbot.prototype.layoutTestCrashLogForIteration): Added a function that builds
3203         a URL for a crash log.
3204
3205         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3206         (BuildbotIteration.prototype.loadLayoutTestResults): Load and cache layout test results for
3207         the iteration.
3208
3209         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:        
3210         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Updated for changed
3211         popover API (see below).
3212         (BuildbotQueueView.prototype._presentPopoverForRevisionRange): Ditto.
3213
3214         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3215         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Added a check
3216         for iterations that were interrupted (previously, they were displayed incorrectly,
3217         often as passes). Install popover trackers for failure bubbles for which we can currently
3218         display something useful.
3219         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions): Build
3220         a popover for layout test regressions when we have the data loaded on demand.
3221         We have test paths, special indicators for crashes/timeouts, and links to test history
3222         at flakiness dashboard.
3223         (BuildbotTesterQueueView.prototype._presentPopoverForLayoutTestRegressions): Show
3224         the popover for layout test regressions. Just shows "Loading..." until the data is
3225         loaded.
3226         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds): List
3227         types of failures if there are multiple. There is a lot of similarity with
3228         appendBuilderQueueStatus(), but I couldn't find a good way to share the code.
3229
3230         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
3231         Create a global test history object, which is used for links in layout test popover.
3232
3233         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Popover.js:
3234         Changed the API to be more like WebInspector again, allowing for changing content
3235         of an existing popover. As the size of a popover can change, making the mouse pointer
3236         enter it without a mousenter event, install a handler for mousewheel instead, and block
3237         document scrolling from this event handler when needed.
3238
3239         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
3240         (StatusLineView.prototype.get statusBubbleElement): Added an accessor for status
3241         bubble element, making it possible to install a popover on it.
3242
3243         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
3244         (JSON.load): Added the ability to load JSONP by providing an optional callback name.
3245
3246         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3247         (WebKitBuildbot.prototype.layoutTestResultsDirectoryURLForIteration): Switched from
3248         building a complete results URL to only building one for root results path. This is
3249         the part that depends on specific buildbot installation, everything relative to it
3250         is the same.
3251
3252         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitTestHistory.js: Added.
3253         Build a path to test history page. In the future, we may consider adding code to
3254         load the data and display it inline.
3255
3256         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
3257         Added styles for this new popover.
3258
3259         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html: Added
3260         a new file, WebKitTestHistory.js.
3261
3262 2014-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3263
3264         REGRESSION(r161214): [GTK] WebKit2 C API tests fail to run after r161214
3265         https://bugs.webkit.org/show_bug.cgi?id=126430
3266
3267         Reviewed by Martin Robinson.
3268
3269         * Scripts/run-gtk-tests:
3270         (TestRunner._setup_testing_environment):
3271         * gtk/common.py: Use common.tests_library_build_path() instead.
3272         (tests_library_build_path): Helper funtion that returns the path
3273         where the tests libraries are built.
3274
3275 2014-01-03  Martin Robinson  <mrobinson@igalia.com>
3276
3277         [CMake] Build TestWebKitAPI tests into a directory structure
3278         https://bugs.webkit.org/show_bug.cgi?id=126358
3279
3280         Reviewed by Gyuyoung Kim.
3281
3282         WebKitGTK+ builds the TestWebKitAPI tests into a "TestWebKitAPI" directory. This
3283         is useful for keeping the "bin" directory tidy during building and will make it easier
3284         to integrate the CMake build into the existing WebKitGTK+ scripts.
3285
3286         * TestWebKitAPI/CMakeLists.txt: Set the output directory of all TestWebKitAPI binaries
3287         and make the names simpler now that the directory identifies what category the test is in.
3288
3289 2014-01-03  Alexey Proskuryakov  <ap@apple.com>
3290
3291         Provide a visual clue when element has a popover at build.webkit.org/dashboard
3292         https://bugs.webkit.org/show_bug.cgi?id=126281
3293
3294         Reviewed by Timothy Hatcher.
3295
3296         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js:
3297         (PopoverTracker): Add a class name to elements with popovers.
3298
3299         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3300         (*): We have -webkit-user-select:none, so let's also not show text selection cursor.
3301         I might have broke that recently.
3302         (*:link): Show hand cursor over links.
3303         (.popover-tracking:hover): Put a shadow on hover over element with popovers.
3304
3305         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
3306         (.status-line .message .revision-number): Show text selection cursor on our only
3307         selectable text element.
3308         (.status-line .bubble.popover-tracking:hover): Text in a bubble looks better with
3309         a white shadow than with a dark one on hover.
3310
3311 2014-01-02  Carlos Garcia Campos  <cgarcia@igalia.com>
3312
3313         [GTK] Add API to WebKitResponsePolicyDecision to check if the MIME type can be shown
3314         https://bugs.webkit.org/show_bug.cgi?id=124652
3315
3316         Reviewed by Martin Robinson.
3317
3318         * MiniBrowser/gtk/BrowserWindow.c:
3319         (webViewDecidePolicy): Use the new API instead of
3320         webkit_web_view_can_show_mime_type().
3321
3322 2014-01-02  Carlos Garcia Campos  <cgarcia@igalia.com>
3323
3324         REGRESSION(r160304): [GTK] Disable libtool fast install
3325         https://bugs.webkit.org/show_bug.cgi?id=126381
3326
3327         Reviewed by Martin Robinson.
3328
3329         Remove -no-fast-install ld flag since fast install is now disabled
3330         globally.
3331
3332         * GNUmakefile.am:
3333         * GtkLauncher/GNUmakefile.am:
3334         * MiniBrowser/gtk/GNUmakefile.am:
3335         * TestWebKitAPI/GNUmakefile.am:
3336         * WebKitTestRunner/GNUmakefile.am:
3337
3338 2014-01-02  Ryuan Choi  <ryuan.choi@samsung.com>
3339
3340         Unreviewed. Add myself to EFL and related watch lists.
3341
3342         * Scripts/webkitpy/common/config/watchlist:
3343
3344 2014-01-02  Danilo Cesar Lemes de Paula  <danilo.cesar@collabora.co.uk>
3345
3346         [GTK] fixing ycm_extra_conf.py file
3347         https://bugs.webkit.org/show_bug.cgi?id=126371
3348
3349         It's an attempt to fix three problems with the current ycm_extra_conf file.
3350         The current implementation assumes that it's a symlink, which is not true.
3351         Usually python creates a pyc file, and this is what you get in __file__.
3352         the .pyc is not a symlink, and the current implementation doesn't work
3353         if that's the case.
3354
3355         It also assumes that the user is in the root folder.
3356         If the user is in WebkitBuild/Debug and open a file as ../../Source/* it won't work.
3357
3358         Last but not least, "elif flag in FLAGS_PRECEDING_PATHS" emits an
3359         exception since "flag" doesn't exists.
3360
3361         All those things were fixed.
3362
3363         Reviewed by Martin Robinson.
3364
3365         * gtk/ycm_extra_conf.py:
3366         (transform_relative_paths_to_absolute_paths):
3367
3368 2014-01-02  Alexey Proskuryakov  <ap@apple.com>
3369
3370         Bindings tests results links are broken at build.webkit.org/dashboard
3371         https://bugs.webkit.org/show_bug.cgi?id=126402
3372
3373         Reviewed by Tim Horton.
3374
3375         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
3376         (Buildbot.prototype.bindingsTestResultsURLForIteration): Fixed a typo that was there
3377         since the beginning.
3378
3379 2014-01-02  Alexey Proskuryakov  <ap@apple.com>
3380
3381         "+" is very confusing at http://build.webkit.org/dashboard
3382         https://bugs.webkit.org/show_bug.cgi?id=126400
3383
3384         Reviewed by Tim Horton.
3385
3386         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3387         (BuildbotQueueView.prototype._appendPendingRevisionCount): Instead of listing open
3388         source and internal counts separately, simply add them. One can always open a popover
3389         for more detail.
3390
3391 2014-01-02  Alexey Proskuryakov  <ap@apple.com>
3392
3393         Accessing Trac from build.webkit.org/dashboard should enable XMLHttpRequest.withCredentials
3394         https://bugs.webkit.org/show_bug.cgi?id=126391
3395
3396         Reviewed by Dan Bernstein.
3397
3398         Make it conditional, as trac.webkit.org doesn't work when withCredentials is enabled.
3399         One can request credentials use via Initialization.js.
3400
3401         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
3402         (Trac):
3403         (Trac.prototype.update):
3404         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
3405         (loadXML):
3406
3407 2014-01-02  Commit Queue  <commit-queue@webkit.org>
3408
3409         Unreviewed, rolling out r160846.
3410         http://trac.webkit.org/changeset/160846
3411         https://bugs.webkit.org/show_bug.cgi?id=126395
3412
3413         Breaks build scripts for Windows when Visual Studio is not
3414         installed in Program Files (Requested by rfong on #webkit).
3415
3416         * Scripts/webkitdirs.pm:
3417         (visualStudioInstallDir):
3418
3419 2014-01-02  Martin Robinson  <mrobinson@igalia.com>
3420
3421         [GTK] [CMake] run-gtk-tests should run with the cmake build
3422         https://bugs.webkit.org/show_bug.cgi?id=126341
3423
3424         Reviewed by Carlos Garcia Campos.
3425
3426         * Scripts/run-gtk-tests:
3427         (TestRunner.__init__): Use the new calling conventions for the common script.
3428         (TestRunner._setup_testing_environment): Ditto.
3429         * gtk/common.py:
3430         (set_build_types): Added set_build_types, to avoid having build_type arguments
3431         for all functions in common.
3432         (binary_build_path): Added this function which gets the path to the built binaries.
3433         (get_build_path): Removed the build_types argument.
3434         (build_path): Removed the build_types argument and call get_build_path directly now.
3435
3436 2014-01-02  Alexey Proskuryakov  <ap@apple.com>
3437
3438         https://bugs.webkit.org/show_bug.cgi?id=126391
3439         Accessing Trac from build.webkit.org/dashboard should enable XMLHttpRequest.withCredentials
3440
3441         Rubber-stamped by Dan Bernstein.
3442
3443         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
3444         (loadXML): Quick and dirty fix, with a FIXME.
3445
3446 2014-01-01  Martin Robinson  <mrobinson@igalia.com>
3447
3448         [GTK] Rename libtestnetscapeplugin to libTestNetscapePlugin
3449         https://bugs.webkit.org/show_bug.cgi?id=126349
3450
3451         Reviewed by Carlos Garcia Campos.
3452
3453         All CMake ports use "libTestNetscapePlugin," so choosing the same
3454         name in the autotools port will make the transition easier.
3455
3456         * GNUmakefile.am: Rename the plugin library.
3457
3458 2014-01-01  ChangSeok Oh  <changseok.oh@collabora.com>
3459
3460         [GTK][WK2] Back items are shown in reverse order in MiniBrowser
3461         https://bugs.webkit.org/show_bug.cgi?id=126354
3462
3463         Reviewed by Carlos Garcia Campos.
3464
3465         The latest visited site for backward history should be placed on the top of a history stack
3466         as a common behavior. However currently its order is reverse.
3467
3468         * MiniBrowser/gtk/BrowserWindow.c:
3469         (browserWindowUpdateNavigationActions):
3470
3471 2013-12-30  Martin Robinson  <mrobinson@igalia.com>
3472
3473         [GTK] Make the output directory of GObject unit tests binaries consistent with the CMake build
3474         https://bugs.webkit.org/show_bug.cgi?id=126297
3475
3476         Reviewed by Philippe Normand.
3477
3478         * Scripts/run-gtk-tests: Looks for the tests in the new directories.
3479         (TestRunner): Ditto.
3480         (TestRunner._run_test): Ditto.
3481
3482 2013-12-30  Alexey Proskuryakov  <ap@apple.com>
3483
3484         full_results.json should distinguish unexpected failures from expected ones
3485         https://bugs.webkit.org/show_bug.cgi?id=126300
3486
3487         Reviewed by Timothy Hatcher.
3488
3489         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
3490         (summarize_results): Add "report" element to JSON, which tells the consumer how
3491         this result was counted for summary.
3492
3493         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3494         Updated results to include the new element.
3495
3496         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
3497         (print_unexpected_results): Added a comment pointing to another place that
3498         summarizes results, and should stay in sync.
3499
3500 2013-12-30  Ryuan Choi  <ryuan.choi@samsung.com>
3501
3502         Replace remaning CoreIPC namespace to IPC
3503         https://bugs.webkit.org/show_bug.cgi?id=126305
3504
3505         Reviewed by Anders Carlsson.
3506
3507         * TestWebKitAPI/CMakeLists.txt: Replaced CoreIPC includes to IPC.
3508         * TestWebKitAPI/efl/PlatformWebView.cpp: Removed temporal define for IPC.
3509         * WebKitTestRunner/CMakeLists.txt: Replaced CoreIPC includes to IPC.
3510         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp: Removed temporal define for IPC.
3511
3512 2013-12-30  Brendan Long  <self@brendanlong.com>
3513
3514         Add myself to the committers list.
3515
3516         Unreviewed.
3517
3518         * Scripts/webkitpy/common/config/contributors.json:
3519
3520 2013-12-30  Carlos Garcia Campos  <cgarcia@igalia.com>
3521
3522         [GTK] Split WebKit2APITests/TestWebKitWebView
3523         https://bugs.webkit.org/show_bug.cgi?id=126284
3524
3525         Reviewed by Philippe Normand.
3526
3527         Skip only WebKitWebView/mouse-target and all TestAuthentication
3528         tests that are timing out when running under xvfb.
3529
3530         * Scripts/run-gtk-tests:
3531         (TestRunner):
3532
3533 2013-12-29  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
3534
3535         [EFL][WK2] Disable geolocation API test
3536         https://bugs.webkit.org/show_bug.cgi?id=125851
3537
3538         Reviewed by Gyuyoung Kim.
3539
3540         Geolocation is turned off by default in EFL port, so it shouldn't be tested.
3541
3542         * TestWebKitAPI/PlatformEfl.cmake: Move Geolocation to test_webkit2_api_fail_BINARIES.
3543
3544 2013-12-29  Ryuan Choi  <ryuan.choi@samsung.com>
3545
3546         [EFL] Remove ewk_view_tiled
3547         https://bugs.webkit.org/show_bug.cgi?id=125961
3548
3549         Reviewed by Gyuyoung Kim.
3550
3551         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3552         (shouldUseTiledBackingStore):
3553         Moved from DumpRenderTreeChrome to enable WebCore's TiledBackingStore
3554         instead of switching ewk_view_tiled.
3555         (DumpRenderTreeChrome::createView):
3556         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
3557         (drtViewAdd):
3558         * EWebLauncher/main.c: Removed ewk_view_tiled option.
3559         (windowCreate):
3560         (parseUserArguments):
3561
3562 2013-12-29  Alexey Proskuryakov  <ap@apple.com>
3563
3564         Pending revision popover is slightly misplaced at build.webkit.org/dashboard
3565         https://bugs.webkit.org/show_bug.cgi?id=126278
3566
3567         Reviewed by Timothy Hatcher.
3568
3569         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3570         (BuildbotQueueView.prototype._appendPendingRevisionCount): Create a span for the text,
3571         as StatusLineView message element has extra padd