[buildbot] clean-build script should remove untracked files and revert local changes too
[WebKit-https.git] / Tools / ChangeLog
1 2015-03-31  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2
3         [buildbot] clean-build script should remove untracked files and revert local changes too
4         https://bugs.webkit.org/show_bug.cgi?id=142400
5
6         Reviewed by Ryosuke Niwa.
7
8         This patch cleans the WebKit folder by reverting tracked files changes and deleting SCM untracked files, including SCM ignored files.
9         A helper routine SCM.discard_untracked_files is added for that purpose.
10
11         * BuildSlaveSupport/clean-build:
12         (main): Making call to Scripts/clean-webkit
13         * Scripts/clean-webkit: Added.
14         (main): Revert changes and delete untracked files.
15         * Scripts/webkitpy/common/checkout/scm/scm.py:
16         (SCM.discard_untracked_files): Helper function to discard untracked files or folders found by SCM.
17         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
18         (SCMTest._shared_test_discard_untracked_files):
19         (test_discard_untracked_files): Tests that untracked file and untracked folder get discarded correctly.
20
21 2015-03-31  Youenn Fablet  <youenn.fablet@crf.canon.fr>
22
23         Python SCM should be able to retrieve untracked files
24         https://bugs.webkit.org/show_bug.cgi?id=143135
25
26         Reviewed by Ryosuke Niwa.
27
28         This patch introduces SCM.untracked_files to retrieve a list of untracked files.
29         Ignored files may be included or not in this list according boolean passed to the function.
30
31         * Scripts/webkitpy/common/checkout/scm/git.py:
32         (Git.untracked_files):
33         * Scripts/webkitpy/common/checkout/scm/scm.py:
34         (SCM.untracked_files):
35         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
36         (SCMTest._shared_test_untracked_files):
37         (test_untracked_files):
38         (GitSVNTest.test_untracked_files):
39         * Scripts/webkitpy/common/checkout/scm/svn.py:
40         (SVN.untracked_files):
41
42 2015-03-30  Alex Christensen  <achristensen@webkit.org>
43
44         [Content Extensions] Correctly handle regular expressions matching everything
45         https://bugs.webkit.org/show_bug.cgi?id=143235
46
47         Reviewed by Benjamin Poulain.
48
49         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
50         (TestWebKitAPI::checkCompilerError):
51         (TestWebKitAPI::TEST_F):
52         Test ContentExtensionErrors.
53
54 2015-03-30  Alexey Proskuryakov  <ap@apple.com>
55
56         DumpRenderTree should set NSWindowDisplayWithRunLoopObserver
57         https://bugs.webkit.org/show_bug.cgi?id=143241
58         rdar://problem/20351297
59
60         Reviewed by Mark Lam.
61
62         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
63
64 2015-03-30  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
65
66         [CMake][EFL] Remove redundant library link and include path
67         https://bugs.webkit.org/show_bug.cgi?id=143221
68
69         Reviewed by Csaba Osztrogonác.
70
71         * ImageDiff/PlatformEfl.cmake: Remove unnecessary library link and include path.
72
73 2015-03-30  Sam Weinig  <sam@webkit.org>
74
75         [Content Extensions] Flesh out the UserContentExtensionStore
76         https://bugs.webkit.org/show_bug.cgi?id=143123
77
78         Reviewed by Benjamin Poulain.
79
80         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
81         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm: Added.
82         Add tests for _WKUserContentExtensionStore.
83
84 2015-03-30  Marcos Chavarría Teijeiro  <chavarria1991@gmail.com>
85
86         Update install-dependencies Fedora packages after r181624
87         https://bugs.webkit.org/show_bug.cgi?id=143215
88
89         Add json-glib, libv4l, openssl and pulseaudio development packages to
90         the Fedora list providing we need them to build WebKit dependencies
91         for this distribution.
92
93         Reviewed by Philippe Normand.
94
95         * gtk/install-dependencies:
96
97 2015-03-30  Commit Queue  <commit-queue@webkit.org>
98
99         Unreviewed, rolling out r182119.
100         https://bugs.webkit.org/show_bug.cgi?id=143196
101
102         problem with syntax (Requested by youenn on #webkit).
103
104         Reverted changeset:
105
106         "[buildbot] clean-build script should remove untracked files
107         and revert local changes too"
108         https://bugs.webkit.org/show_bug.cgi?id=142400
109         http://trac.webkit.org/changeset/182119
110
111 2015-03-30  Benjamin Poulain  <benjamin@webkit.org>
112
113         Start the features.json files
114         https://bugs.webkit.org/show_bug.cgi?id=143207
115
116         Reviewed by Darin Adler.
117
118         I kept the style checking light. We'll have to figure
119         what is the best format for each field.
120
121         * Scripts/webkitpy/style/checker.py:
122         (CheckerDispatcher._create_checker):
123         * Scripts/webkitpy/style/checkers/jsonchecker.py:
124         (JSONContributorsChecker.check):
125         (JSONFeaturesChecker):
126         (JSONFeaturesChecker.check):
127
128 2015-03-29  Youenn Fablet  <youenn.fablet@crf.canon.fr>
129
130         [buildbot] clean-build script should remove untracked files and revert local changes too
131         https://bugs.webkit.org/show_bug.cgi?id=142400
132
133         Reviewed by Ryosuke Niwa.
134
135         This patch cleans the WebKit folder by deleting SCM untracked files and reverting changes for tracked files.
136
137         * BuildSlaveSupport/clean-build:
138         (main): Adding call to Tools/Scripts/clean-webkit.
139         * Scripts/clean-webkit: Added.
140         (main): Removes untracked and changed files.
141         * Scripts/webkitpy/common/checkout/scm/git.py:
142         (Git.untracked_files): Retrieves GIT untracked files.
143         * Scripts/webkitpy/common/checkout/scm/scm.py:
144         (SCM.untracked_files): Retrieves SVN untracked files.
145         (SCM):
146         (SCM.discard_untracked_files): Deletes untracked files/folders.
147         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
148         (SCMTest._shared_test_untracked_files): Unit testing for untracked files.
149         (test_untracked_files):
150         (GitSVNTest.test_untracked_files):
151         * Scripts/webkitpy/common/checkout/scm/svn.py:
152         (SVN.untracked_files):
153
154 2015-03-27  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
155
156         [CMake] Remove unnecessary INCLUDE_IF_EXISTS macro 
157         https://bugs.webkit.org/show_bug.cgi?id=143138
158
159         Reviewed by Csaba Osztrogonác.
160
161         INCLUDE_IF_EXISTS isn't used except for 2 places. However those uses can
162         be replaced with WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS.
163
164         * ImageDiff/CMakeLists.txt:
165         Use WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS() instead of INCLUDE_IF_EXISTS.
166         * WebKitTestRunner/CMakeLists.txt: ditto.
167
168 2015-03-27  Myles C. Maxfield  <mmaxfield@apple.com>
169
170         Support building WTF on Windows without Cygwin
171         https://bugs.webkit.org/show_bug.cgi?id=143084
172
173         Reviewed by Brent Fulgham.
174
175         Windows without Cygwin doesn't have curl, unzip, or grep. Luckily, Perl does all of these things.
176         This patch also migrates to using File::Spec->catfile() for directory separators.
177
178         * Scripts/update-webkit-dependency:
179         (wanted):
180         * Scripts/update-webkit-support-libs:
181         (wanted):
182         (downloadExpectedVersionNumber):
183         (zipFileVersion):
184         (toUnixPath): Deleted.
185         * Scripts/webkitdirs.pm:
186         (determineSourceDir):
187         (windowsSourceSourceDir):
188         (windowsLibrariesDir):
189         (windowsOutputDir):
190         (checkInstalledTools):
191         (buildVisualStudioProject):
192
193 2015-03-27  Alex Christensen  <achristensen@webkit.org>
194
195         Fix WinCairo bot.
196         https://bugs.webkit.org/show_bug.cgi?id=143086
197
198         Reviewed by Brent Fulgham.
199
200         * Scripts/webkitdirs.pm:
201         (buildVisualStudioProject):
202         (runSvnUpdateAndResolveChangeLogs):
203         Use ActivePerl-friendly perl.
204
205 2015-03-27  Csaba Osztrogonác  <ossy@webkit.org>
206
207         URTBF after r182059 to fix the EFL build.
208
209         * TestWebKitAPI/CMakeLists.txt:
210
211 2015-03-26  Alexey Proskuryakov  <ap@apple.com>
212
213         Layout test results URL loads in WK1 but not WK2 minibrowser
214         https://bugs.webkit.org/show_bug.cgi?id=143117
215
216         Reviewed by Tim Horton.
217
218         * MiniBrowser/mac/WK2BrowserWindowController.m:
219         (-[WK2BrowserWindowController fetch:]): Fix this, international domain names, and
220         everything.
221         (-[WK2BrowserWindowController updateTextFieldFromURL:]): Ditto.
222
223 2015-03-26  Jer Noble  <jer.noble@apple.com>
224
225         Add --allowed-host support to run-webkit-tests
226         https://bugs.webkit.org/show_bug.cgi?id=142938
227
228         Reviewed by Brent Fulgham.
229
230         Accept --allowed-host arguments from run-webkit-tests and pass them through to
231         DumpRenderTree and WebKitTestRunner.
232
233         Drive-by fix: Depending on the value of the --layout-test-dir parameter, layout test results
234         are placed in the wrong location. The argument is compared with each tests's path, and if a
235         relative path or a path with '..' was used, results are placed alongside the test. Take the
236         absolute path of the --layout-test-dir argument, collapsing path components like '..'.
237
238         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
239         (parse_args):
240         * Scripts/webkitpy/port/base.py:
241         (Port.__init__):
242         (Port.allowed_hosts):
243         * Scripts/webkitpy/port/driver.py:
244         (Driver.cmd_line):
245
246 2015-03-26  Jer Noble  <jer.noble@apple.com>
247
248         [Mac] Add an --allowed-host argument to DRT and WKTR to allow tests to connect to non-localhost servers
249         https://bugs.webkit.org/show_bug.cgi?id=142931
250
251         Reviewed by Brent Fulgham.
252
253         Currently, both DRT and WKTR will refuse to allow network connections to non-localhost servers
254         over HTTP/HTTPS. For certain testing scenarios, however, it would be useful if both DRT and
255         WKTR could be allowed to make HTTP/HTTPS connections to certain, specific servers defined at
256         runtime.
257
258         To allow this, add an optional argument to DRT and WKTR, --allowed-host, which will add the specified
259         hostname to a whitelist; requests to these hosts will allowed to proceed normally.
260
261         Drive-by fix: in InjectedBundlePage::willSendRequestForFrame, we get the top loading frame from the
262         injected bundle. But after the main resource load completes, the bundle nulls out it's pointer to the
263         top loading frame, which causes a subsequent crash when further resources are requested. Instead, get
264         the top loading frame from the page, as we do elsewhere in this class.
265
266         * DumpRenderTree/TestRunner.h:
267         (TestRunner::allowedHosts):
268         (TestRunner::setAllowedHosts):
269         * DumpRenderTree/mac/DumpRenderTree.mm:
270         (initializeGlobalsFromCommandLineOptions):
271         (runTest):
272         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
273         (isAllowedHost):
274         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
275         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
276         (WTR::InjectedBundle::didReceiveMessage):
277         (WTR::InjectedBundle::isAllowedHost):
278         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
279         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
280         (WTR::isAllowedHost):
281         (WTR::InjectedBundlePage::willSendRequestForFrame):
282         * WebKitTestRunner/InjectedBundle/TestRunner.h:
283         * WebKitTestRunner/Options.cpp:
284         (WTR::handleOptionAllowedHost):
285         (WTR::OptionsHandler::OptionsHandler):
286         * WebKitTestRunner/Options.h:
287         * WebKitTestRunner/TestController.cpp:
288         (WTR::TestController::initialize):
289         (WTR::TestController::resetStateToConsistentValues):
290         * WebKitTestRunner/TestController.h:
291
292 2015-03-26  Brady Eidson  <beidson@apple.com>
293
294         Apply ContentExtension actions after redirects.
295         <rdar://problem/20062613> and https://bugs.webkit.org/show_bug.cgi?id=143055
296
297         Reviewed by Alex Christensen.
298
299         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
300         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): Dump the fact that the load error is kWKErrorCodeCannotShowURL
301           which is specifically interesting to a new test.
302
303 2015-03-26  Csaba Osztrogonác  <ossy@webkit.org>
304
305         [EFL] Disable building libseccomp on AArch64
306         https://bugs.webkit.org/show_bug.cgi?id=143094
307
308         Reviewed by Gyuyoung Kim.
309
310         * efl/jhbuildrc:
311
312 2015-03-26  Csaba Osztrogonác  <ossy@webkit.org>
313
314         [jhbuild] git should use only 1 thread for cloning jhbuild
315         https://bugs.webkit.org/show_bug.cgi?id=143095
316
317         Reviewed by Gyuyoung Kim.
318
319         * jhbuild/jhbuild-wrapper:
320         (clone_jhbuild):
321
322 2015-03-25  Joseph Pecoraro  <pecoraro@apple.com>
323
324         Update prepare-ChangeLog to work with ES6 Class syntax
325         https://bugs.webkit.org/show_bug.cgi?id=143069
326
327         Reviewed by Timothy Hatcher.
328
329         * Scripts/prepare-ChangeLog:
330         (get_function_line_ranges_for_javascript):
331         Better handle ES6 Class syntax.
332
333         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt:
334         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests.js:
335         (BaseClass):
336         (DerivedClass):
337         (DerivedClass.staticMethod):
338         (DerivedClass.prototype.method.nestedFunctionInsideMethod):
339         (DerivedClass.prototype.method):
340         (DerivedClass.prototype.get getter):
341         (namespace.MyClass):
342         (namespace.MyClass.staticMethod):
343         (namespace.MyClass.prototype.method.nestedFunctionInsideMethod):
344         (namespace.MyClass.prototype.method):
345         (namespace.MyClass.prototype.get getter):
346         Proof!
347
348 2015-03-25  Filip Pizlo  <fpizlo@apple.com>
349
350         Use JITCompilationCanFail in more places, and make the fail path of JITCompilationMustSucceed a crash instead of attempting GC
351         https://bugs.webkit.org/show_bug.cgi?id=142993
352
353         Reviewed by Mark Lam.
354         
355         Bunch of support for testing executable allocation failure.
356
357         * Scripts/jsc-stress-test-helpers/js-executable-allocation-fuzz: Added.
358         (fail):
359         * Scripts/run-javascriptcore-tests:
360         (runJSCStressTests):
361         * Scripts/run-jsc-stress-tests:
362
363 2015-03-25  Myles C. Maxfield  <mmaxfield@apple.com>
364
365         Fix Windows build from r181977.
366
367         Unreviewed.
368
369         * Scripts/update-webkit-dependency:
370
371 2015-03-25  Sam Weinig  <sam@webkit.org>
372
373         Address additional review feedback from https://bugs.webkit.org/show_bug.cgi?id=143059.
374
375         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
376         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
377
378 2015-03-25  Myles C. Maxfield  <mmaxfield@apple.com>
379
380         Migrate update-webkit for Windows to not require Cygwin
381         https://bugs.webkit.org/show_bug.cgi?id=143040
382
383         Reviewed by Brent Fulgham.
384
385         * Scripts/update-webkit-dependency:
386         (wanted):
387         (toUnixPath): Deleted.
388         * Scripts/webkitdirs.pm:
389         (fontExists):
390         (checkInstalledTools):
391         (setupAppleWinEnv):
392
393 2015-03-25  Sam Weinig  <sam@webkit.org>
394
395         [Content Extensions] Convert content extension compiling to return error codes and write its output using a client
396         https://bugs.webkit.org/show_bug.cgi?id=143059
397
398         Reviewed by Alex Christensen.
399
400         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
401         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
402         Update for new interface of compileRuleList().
403
404 2015-03-25  Alex Christensen  <achristensen@webkit.org>
405
406         [Content Extensions] Add multi-DFA compiling and interpreting.
407         https://bugs.webkit.org/show_bug.cgi?id=143010
408
409         Reviewed by Benjamin Poulain.
410
411         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
412         (TestWebKitAPI::testRequest):
413         (TestWebKitAPI::TEST_F):
414         Add some tests for ignore-previous-rules and large rulesets.
415
416 2015-03-25  Alexey Proskuryakov  <ap@apple.com>
417
418         Mavericks WK1 still runs JSC tests
419         https://bugs.webkit.org/show_bug.cgi?id=143035
420
421         Reviewed by Csaba Osztrogonác.
422
423         * BuildSlaveSupport/build.webkit.org-config/config.json: Bring Mavericks WK1 in line
424         with other bots.
425
426         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Updated the tests
427         accordingly.
428
429 2015-03-25  Commit Queue  <commit-queue@webkit.org>
430
431         Unreviewed, rolling out r181932.
432         https://bugs.webkit.org/show_bug.cgi?id=143041
433
434         The test fails most of the time on bots (Requested by ap on
435         #webkit).
436
437         Reverted changeset:
438
439         "[Content Extensions] Add multi-DFA compiling and
440         interpreting."
441         https://bugs.webkit.org/show_bug.cgi?id=143010
442         http://trac.webkit.org/changeset/181932
443
444 2015-03-24  Alex Christensen  <achristensen@webkit.org>
445
446         [Content Extensions] Add multi-DFA compiling and interpreting.
447         https://bugs.webkit.org/show_bug.cgi?id=143010
448
449         Reviewed by Benjamin Poulain.
450
451         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
452         (TestWebKitAPI::testRequest):
453         (TestWebKitAPI::TEST_F):
454         Add some tests for ignore-previous-rules and large rulesets.
455
456 2015-03-24  Benjamin Poulain  <bpoulain@apple.com>
457
458         Make URL filter patterns matching consistent and add a simple canonicalization step
459         https://bugs.webkit.org/show_bug.cgi?id=142998
460
461         Reviewed by Alex Christensen.
462
463         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
464
465 2015-03-24  Csaba Osztrogonác  <ossy@webkit.org>
466
467         [EFL] Add OpenWebRTC in jhbuild
468         https://bugs.webkit.org/show_bug.cgi?id=142778
469
470         Reviewed by Gyuyoung Kim.
471
472         Original patch by Philippe Normand <pnormand@igalia.com>
473
474         * efl/install-dependencies: Dependencies for OpenWebRTC.
475         * efl/jhbuild.modules: build OpenWebRTC, libusrsctp, libnice and
476         the openwebrtc gst plugins.
477
478 2015-03-23  Brent Fulgham  <bfulgham@apple.com>
479
480         Regression(r181257): WTF_WorkQueue.Simple is flaky
481         https://bugs.webkit.org/show_bug.cgi?id=142560
482
483         Remove the check that the refCount has returned to one after the
484         individual tasks have completed. It's too nondeterministic when
485         the reference count will be reduced.
486
487         Reviewed by Alexey Proskuryakov
488
489         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
490         (TestWebKitAPI::TEST): Remove test that refCount is back to 1.
491
492 2015-03-23  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
493
494         [CMake][EFL] Put failure API test excutables into failure directory
495         https://bugs.webkit.org/show_bug.cgi?id=142965
496
497         Reviewed by Csaba Osztrogonác.
498
499         Move failing WK2 API test executables to *bin/TestWebKitAPI/WebKit2/failure* directory.
500
501         * TestWebKitAPI/CMakeLists.txt: Fix a typo. Change *testBaseName* with *testName*.
502         * TestWebKitAPI/PlatformEfl.cmake: Additionally remove unnecessary SHARED_CORE and comment for SeccompFilters test.
503
504 2015-03-22  Benjamin Poulain  <benjamin@webkit.org>
505
506         CSS Selectors: fix attribute case-insensitive matching of Contain and List
507         https://bugs.webkit.org/show_bug.cgi?id=142932
508
509         Reviewed by Darin Adler.
510
511         Add tests for the new features and fix some existing tests using the 
512         stringFromUTF8() utility recently added by Dhi.
513
514         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
515         (TestWebKitAPI::stringFromUTF8):
516         * TestWebKitAPI/Tests/WTF/StringView.cpp:
517
518 2015-03-22  Michael Catanzaro  <mcatanzaro@igalia.com>
519
520         [GTK] install-dependencies should install orc
521         https://bugs.webkit.org/show_bug.cgi?id=142955
522
523         Reviewed by Martin Robinson.
524
525         Install orc, needed by openwebrtc
526
527         * gtk/install-dependencies:
528
529 2015-03-22  Benjamin Poulain  <bpoulain@apple.com>
530
531         Detect when url filter pattern with groups match the empty string
532         https://bugs.webkit.org/show_bug.cgi?id=142930
533
534         Reviewed by Sam Weinig.
535
536         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
537
538 2015-03-22  Anders Carlsson  <andersca@apple.com>
539
540         _WKWebsiteDataStore should clear WebSQL databases
541         https://bugs.webkit.org/show_bug.cgi?id=142947
542
543         Reviewed by Sam Weinig.
544
545         Add a variable that keeps track of the types of data we want to operate on, for easier debugging.
546
547         * MiniBrowser/mac/WK2BrowserWindowController.m:
548         (-[WK2BrowserWindowController fetchWebsiteData:]):
549         (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
550         (-[WK2BrowserWindowController clearWebsiteData:]):
551
552 2015-03-20  Mark Hahnenberg  <mhahnenb@gmail.com>
553
554         GCTimer should know keep track of nested GC phases
555         https://bugs.webkit.org/show_bug.cgi?id=142675
556
557         Reviewed by Darin Adler.
558
559         Adds a tool to aid in parsing the GC phase timing output into a
560         tree-like structure based on the parent-child relationships
561         of nested GC phases.
562
563         * Scripts/parse-gc-phase-timings: Added.
564         (Timing):
565         (Timing.__init__):
566         (Timing.__unicode__):
567         (Timing.__str__):
568         (Timing.__repr__):
569         (parse_input):
570         (print_timing_node):
571         (print_timing_tree):
572         (link_parents):
573         (main):
574
575 2015-03-20  Brent Fulgham  <bfulgham@apple.com>
576
577         [Win] Temporarily turn of EWS Windows tests while I debug the test failure.
578
579         * Scripts/webkitpy/common/config/ews.json:
580
581 2015-03-20  Philippe Normand  <pnormand@igalia.com>
582
583         [GTK][jhbuild] Fix flakey failures due to unstable googlecode repository
584         https://bugs.webkit.org/show_bug.cgi?id=142867
585
586         Rubber-stamped by Csaba Osztrogon.
587
588         * gtk/jhbuild.modules: Use Ossy's libusrsctp Github fork. Also use
589         a fixed revision for the openwebrtc-gst-plugins.
590
591 2015-03-19  Ryosuke Niwa  <rniwa@webkit.org>
592
593         Unreviewed build fix. Don't try to report stats for all benchmarks.
594         Just report the geometric mean of preferred means.
595
596         * Scripts/run-jsc-benchmarks:
597
598 2015-03-19  Ryosuke Niwa  <rniwa@webkit.org>
599
600         run-jsc-benchmarks should only report preferred mean
601         https://bugs.webkit.org/show_bug.cgi?id=142874
602
603         Reviewed by Geoffrey Garen.
604
605         Just collect statistics for the preferred mean.
606
607         * Scripts/run-jsc-benchmarks:
608
609 2015-03-19  Alex Christensen  <achristensen@webkit.org>
610
611         [Content Extensions] Test regular expression parse failures.
612         https://bugs.webkit.org/show_bug.cgi?id=142872
613
614         Reviewed by Benjamin Poulain.
615
616         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
617         (TestWebKitAPI::testPatternStatus):
618         (TestWebKitAPI::TEST_F):
619         Added tests for each parsing status.
620
621 2015-03-19  Alex Christensen  <achristensen@webkit.org>
622
623         Fix API tests after r181754.
624
625         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
626         (TestWebKitAPI::testRequest):
627
628 2015-03-19  Brady Eidson  <beidson@apple.com>
629
630         Part of content extensions should apply css selectors
631         https://bugs.webkit.org/show_bug.cgi?id=142604
632
633         Reviewed by Alex Christensen.
634
635         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
636         (WebCore::ContentExtensions::operator<<):
637
638 2015-03-19  Brent Fulgham  <bfulgham@apple.com>
639
640         [Win] Activate tests on EWS
641         https://bugs.webkit.org/show_bug.cgi?id=142850
642
643         Reviewed by Alexey Proskuryakov.
644
645         * Scripts/webkitpy/common/config/ews.json: Add me as
646         the EWS bot watcher, and activate tests.
647
648 2015-03-19  Csaba Osztrogonác  <ossy@webkit.org>
649
650         [GTK] Fix inspector userinterface related incremental build issue
651         https://bugs.webkit.org/show_bug.cgi?id=142849
652
653         Reviewed by Carlos Garcia Campos.
654
655         * Scripts/webkitdirs.pm:
656         (shouldRemoveCMakeCache):
657
658 2015-03-18  Alex Christensen  <achristensen@webkit.org>
659
660         [ContentExtensions] Prepare for compiling stylesheets of selectors to be used on every page.
661         https://bugs.webkit.org/show_bug.cgi?id=142799
662
663         Reviewed by Brady Eidson.
664
665         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
666         (TestWebKitAPI::testPattern):
667         (TestWebKitAPI::TEST_F):
668         Start testing regex failures.
669
670 2015-03-18  Dhi Aurrahman  <diorahman@rockybars.com>
671
672         Fix StringView typos after r181525 and r181558
673         https://bugs.webkit.org/show_bug.cgi?id=142772
674
675         Reviewed by Darin Adler.
676
677         Add some tests in [1] to cover the StringView::startsWith, 
678         StringView::startsWithIgnoringASCIICase, StringView::endsWith and 
679         StringView::endsWithIgnoringASCIICase implementations.
680
681         * TestWebKitAPI/Tests/WTF/StringView.cpp:
682         (TestWebKitAPI::TEST):
683
684 2015-03-18  Dana Burkart  <dburkart@apple.com>
685
686         Remove extraneous import to fix the build.
687
688         Unreviewed.
689
690         * Scripts/webkitpy/port/driver.py:
691
692 2015-03-18  Dana Burkart  <dburkart@apple.com>
693
694         ASAN_OPTIONS=allocator_may_return_null=1 needs to be set 
695         https://bugs.webkit.org/show_bug.cgi?id=142547
696
697         Reviewed by Alexey Proskuryakov.
698
699         * Scripts/webkitpy/port/driver.py:
700         (Driver._setup_environ_for_driver):
701
702 2015-03-18  Alexey Proskuryakov  <ap@apple.com>
703
704         Tweak how AppleSystemFontOSSubversion default is added
705         https://bugs.webkit.org/show_bug.cgi?id=142835
706
707         Reviewed by Dan Bernstein.
708
709         * DumpRenderTree/mac/DumpRenderTree.mm:
710         (setDefaultsToConsistentValuesForTesting):
711
712 2015-03-18  Dan Bernstein  <mitz@apple.com>
713
714         prepare-ChangeLog doesn't understand C string literals split across multiple lines with \
715         https://bugs.webkit.org/show_bug.cgi?id=142815
716
717         Reviewed by Darin Adler.
718
719         * Scripts/prepare-ChangeLog:
720         (get_function_line_ranges_for_cpp): If the line ends with a backslash instead of a matching
721         quotation mark, use new variable $quotation_mark to remember what we are looking for, and
722         keep consuming the quoted text until the matching quotation mark is reached. Emit the
723         warning only if a line ends without a backslash before the matching quotation mark was found.
724
725 2015-03-18  Joseph Pecoraro  <pecoraro@apple.com>
726
727         Remove unused "preprocessor" parameter to sub-CodeGenerators
728         https://bugs.webkit.org/show_bug.cgi?id=142793
729
730         Reviewed by Darin Adler.
731
732         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
733         (new):
734
735 2015-03-18  Csaba Osztrogonác  <ossy@webkit.org>
736
737         [EFL] Bump gstreamer version to 1.4.4
738         https://bugs.webkit.org/show_bug.cgi?id=142782
739
740         Reviewed by Philippe Normand.
741
742         * efl/jhbuild.modules:
743         * efl/patches/gst-libav.patch:
744         * efl/patches/gst-plugins-bad-remove-gnustep-support.patch: Added.
745         * efl/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Removed.
746
747 2015-03-17  Tim Horton  <timothy_horton@apple.com>
748
749         Fix the iOS build.
750
751         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
752         (WTR::InjectedBundle::platformInitialize):
753
754 2015-03-17  Dean Jackson  <dino@apple.com>
755
756         check-webkit-style should allow "bool a : 1"
757         https://bugs.webkit.org/show_bug.cgi?id=142794
758
759         Reviewed by Brent Fulgham.
760
761         We should allow member bitfields of the form:
762
763         bool m_var : 1;
764
765         It seems that Visual Studio 8 was the last compiler that
766         wasn't happy about not using unsigned here. We already have
767         about 500 cases (in WebCore) where people were ignoring this rule.
768
769         * Scripts/webkitpy/style/checkers/cpp.py:
770         (check_language): Allow "bool".
771         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add tests.
772         (CppStyleTest.test_enum_bitfields):
773         (CppStyleTest.test_plain_integral_bitfields):
774
775 2015-03-17  Benjamin Poulain  <bpoulain@apple.com>
776
777         Compile character ranges targeting the same state as range check in the bytecode
778         https://bugs.webkit.org/show_bug.cgi?id=142759
779
780         Reviewed by Alex Christensen.
781
782         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
783         (TestWebKitAPI::TEST_F):
784
785 2015-03-17  Youenn Fablet  <youenn.fablet@crf.canon.fr>
786
787         W3C test parser and converter should use test importer host
788         https://bugs.webkit.org/show_bug.cgi?id=142729
789
790         Reviewed by Bem Jones-Bey.
791
792         When instantiated by TestImporter, TestParser and TestConverter are now using the same host.
793         This enables adding more TestImporter unit testing.
794         This patch also ensures that the git object instantiated by TestDownloader is using the
795         same Executive and FileSystem object as TestDownloader, again to enable TestImporter/TestDownloader unit testing.
796
797         * Scripts/webkitpy/common/system/filesystem_mock.py:
798         (MockFileSystem.copytree): Fixes implementation as it creates a runtime error.
799         * Scripts/webkitpy/w3c/test_downloader.py:
800         (TestDownloader.git): Set the executive of the git object to the one of TestDownloader. Refactoring in a new git function for future reuse.
801         (TestDownloader.checkout_test_repository): Making use of the new git function.
802         * Scripts/webkitpy/w3c/test_importer.py:
803         (TestImporter.find_importable_tests): Adding host as parameter to the parser.
804         (TestImporter.import_tests): Adding host as parameter to the converter.
805         * Scripts/webkitpy/w3c/test_importer_unittest.py:
806         (TestImporterTest.create_test_download_importer): Creating a test downloader mock, to be reused by other tests.
807         (TestImporterTest):
808         (TestImporterTest.test_harnesslinks_conversion): Adding test to check that test harness links are converted for CSS tests but not WPT tests. 
809         * Scripts/webkitpy/w3c/test_parser.py:
810         (TestParser.__init__): Adding host as parameter constructor.
811
812 2015-03-17  Carlos Garcia Campos  <cgarcia@igalia.com>
813
814         [GTK] WebKitDOM objects leaking
815         https://bugs.webkit.org/show_bug.cgi?id=118788
816
817         Reviewed by Darin Adler and Sergio Villar Senin.
818
819         Update DOMObjectCache unit test to check that DOM objects are also
820         released when new contents are loaded in the web view, and the old
821         document is detached from the frame.
822
823         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
824         (testWebKitDOMObjectCache):
825         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
826         (runTest):
827
828 2015-03-17  Youenn Fablet  <youenn.fablet@crf.canon.fr>
829
830         W3C test importer default import folder should be LayoutTests/imported/w3c
831         https://bugs.webkit.org/show_bug.cgi?id=142728
832
833         Reviewed by Bem Jones-Bey.
834
835         * Scripts/webkitpy/w3c/test_importer.py:
836         (parse_args): Updating the default destination option value to 'imported/w3c'.
837
838 2015-03-17  Philippe Normand  <pnormand@igalia.com>
839
840         [GTK] basic OpenWebRTC build support
841         https://bugs.webkit.org/show_bug.cgi?id=142393
842
843         Reviewed by Carlos Garcia Campos.
844
845         * gtk/jhbuild.modules: Add OpenWebRTC and its dependencies. This
846         is not the upstream OpenWebRTC repository. This temporary fork
847         contains a few patches needed by WebKit for audio/video rendering.
848
849 2015-03-17  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
850
851         [CMake][EFL] Build test tools only for developer mode
852         https://bugs.webkit.org/show_bug.cgi?id=142761
853
854         Reviewed by Csaba Osztrogonác.
855
856         Do not build EFL MiniBrowser, WebKitTestRunner, and ImageDiff on production mode.
857
858         * CMakeLists.txt:
859
860 2015-03-17  Joseph Pecoraro  <pecoraro@apple.com>
861
862         Remove never used "useLayerOnTop" bindings generator argument
863         https://bugs.webkit.org/show_bug.cgi?id=142773
864
865         Reviewed by Darin Adler.
866
867         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
868         (new):
869
870 2015-03-16  Ryosuke Niwa  <rniwa@webkit.org>
871
872         Enable ES6 classes by default
873         https://bugs.webkit.org/show_bug.cgi?id=142774
874
875         Reviewed by Gavin Barraclough.
876
877         * Scripts/webkitperl/FeatureList.pm:
878
879 2015-03-16  Alexey Proskuryakov  <ap@apple.com>
880
881         Fix webkitpy tests after r181585.
882
883         Looks like "me" cannot be anyone's email, it's a special case.
884
885         * Scripts/webkitpy/common/config/contributors.json:
886
887 2015-03-16  Alexey Proskuryakov  <ap@apple.com>
888
889         Add tolerance to WebAudio tests
890         https://bugs.webkit.org/show_bug.cgi?id=142676
891
892         Reviewed by Tim Horton.
893
894         * Scripts/webkitpy/common/wavediff.py: Added. Based on Jer Noble's work.
895
896         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
897         (TestResultWriter.create_audio_diff_and_write_result):
898         * Scripts/webkitpy/layout_tests/models/test_failures.py:
899         (FailureAudio.write_failure):
900         * Scripts/webkitpy/port/base.py:
901         (Port.do_audio_results_differ):
902         Diff audio failures.
903
904         * Scripts/webkitpy/port/test.py: Added a test for the tolerance, fixed existing
905         tests to use real parseable WAV data, and got rid of base64, which there didn't
906         seem to have been any reason for.
907
908 2015-03-16  Alexey Proskuryakov  <ap@apple.com>
909
910         [Mac] fast/forms/text-control-intrinsic-widths.html fails when MS Office is installed
911         https://bugs.webkit.org/show_bug.cgi?id=142720
912
913         Reviewed by Myles C. Maxfield.
914
915         Activate system copies of Microsoft fonts for the current process, thus overriding
916         any other ones that could be preferred by the system otherwise.
917
918         * DumpRenderTree/mac/DumpRenderTree.mm:
919         (activateSystemCoreWebFonts):
920         (adjustFonts):
921         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
922         (WTR::activateSystemCoreWebFonts):
923         (WTR::activateFonts):
924
925 2015-03-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
926
927         Created Streams API watchlist
928         https://bugs.webkit.org/show_bug.cgi?id=142684
929
930         Reviewed by Benjamin Poulain.
931
932         * Scripts/webkitpy/common/config/watchlist: Created StreamsAPI
933         watchlist and added Benjamin, Youenn and me to it.
934
935 2015-03-15  Benjamin Poulain  <benjamin@webkit.org>
936
937         CSS: fix the case-insensitive matching of the attribute selectors Begin, End and Hyphen
938         https://bugs.webkit.org/show_bug.cgi?id=142715
939
940         Reviewed by Brent Fulgham.
941
942         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
943         (TestWebKitAPI::TEST):
944
945 2015-03-15  Benjamin Poulain  <bpoulain@apple.com>
946
947         Change the exact attribute matching to be ASCII case-insensitive
948         https://bugs.webkit.org/show_bug.cgi?id=142609
949
950         Reviewed by Darin Adler.
951
952         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
953         * TestWebKitAPI/Tests/WTF/StringView.cpp:
954
955 2015-03-13  Youenn Fablet  <youenn.fablet@crf.canon.fr>
956
957         WebKit test infrastructure should automate the process of cloning W3C test suite and importing tests from it
958         https://bugs.webkit.org/show_bug.cgi?id=134764
959
960         Reviewed by Ryosuke Niwa.
961
962         TestDownloader is introduced to download W3C tests from the official
963         W3C tests repositories (https://github.com/w3c/web-platform-tests.git
964         and https://github.com/w3c/csswg-test.git).
965         TestDownloader clones the repositories and checkouts revisions of the tests
966         defined in LayoutTests/imported/w3c/resources/TestRepositories.
967
968         Similarly to https://codereview.chromium.org/148173016,
969         TestDownloader copies part of the files based on the rules
970         defined in LayoutTests/imported/w3c/resources/ImportExpectations.
971
972         TestDownloader is used by TestImporter when no source directory is provided.
973
974         * Scripts/webkitpy/w3c/test_downloader.py: Added.
975         (TestDownloader):
976         (TestDownloader.default_options):
977         (TestDownloader.load_test_repositories):
978         (TestDownloader.__init__):
979         (TestDownloader.checkout_test_repository):
980         (TestDownloader._init_paths_from_expectations):
981         (TestDownloader._add_test_suite_paths):
982         (TestDownloader._empty_directory):
983         (TestDownloader.copy_tests):
984         (TestDownloader.download_tests):
985         * Scripts/webkitpy/w3c/test_importer.py:
986         (main):
987         (parse_args):
988         (TestImporter.__init__):
989         (TestImporter.do_import):
990         (TestImporter.test_downloader):
991         (TestImporter.find_importable_tests.should_keep_subdir):
992         (TestImporter.should_convert_test_harness_links):
993         (TestImporter.import_tests):
994         (TestImporter.write_import_log):
995
996 2015-03-12  Alexey Proskuryakov  <ap@apple.com>
997
998         [Mavericks] Test snapshots are 1600x1200 on Retina devices
999         https://bugs.webkit.org/show_bug.cgi?id=142630
1000
1001         Reviewed by Tim Horton.
1002
1003         * WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::windowSnapshotImage):
1004         Removed an ifdef that disabled the fix on Mavericks.
1005
1006 2015-03-12  Csaba Osztrogonác  <ossy@webkit.org>
1007
1008         Remove isWK2 cruft from webkitdirs.pm after r170426
1009         https://bugs.webkit.org/show_bug.cgi?id=142618
1010
1011         Reviewed by Daniel Bates.
1012
1013         * Scripts/webkitdirs.pm:
1014         (isWK2): Deleted.
1015
1016 2015-03-12  Alexey Proskuryakov  <ap@apple.com>
1017
1018         testRunner.setAlwaysAcceptCookies does not work with NetworkProcess
1019         https://bugs.webkit.org/show_bug.cgi?id=138687
1020
1021         Reviewed by Carlos Garcia Campos.
1022
1023         Always change cookie policy from UI process, as changing it from WebProcess doesn't
1024         affect other processes.
1025
1026         The implementation is imperfect, because the change happens asynchronously, but I
1027         don't expect it to be a problem in practice.
1028
1029         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1030         (WTR::InjectedBundle::beginTesting):
1031         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1032         (WTR::TestRunner::setAlwaysAcceptCookies):
1033         * WebKitTestRunner/TestInvocation.cpp:
1034         (WTR::TestInvocation::invoke):
1035         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1036
1037 2015-03-12  Csaba Osztrogonác  <ossy@webkit.org>
1038
1039         [EFL] Enable building EFL 1.13 with NEON support
1040         https://bugs.webkit.org/show_bug.cgi?id=142619
1041
1042         Reviewed by Gyuyoung Kim.
1043
1044         * efl/jhbuild.modules:
1045
1046 2015-03-11  Alex Christensen  <achristensen@webkit.org>
1047
1048         [Content Extensions] Add resource type and load type triggers.
1049         https://bugs.webkit.org/show_bug.cgi?id=142422
1050
1051         Reviewed by Benjamin Poulain.
1052
1053         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1054         (TestWebKitAPI::testRequest):
1055         (TestWebKitAPI::mainDocumentRequest):
1056         (TestWebKitAPI::TEST_F):
1057         (TestWebKitAPI::testURL): Deleted.
1058
1059 2015-03-10  Sam Weinig  <sam@webkit.org>
1060
1061         Allow adding a button in input elements for auto fill related functionality
1062         <rdar://problem/19782066>
1063         https://bugs.webkit.org/show_bug.cgi?id=142564
1064
1065         Reviewed by Anders Carlsson.
1066
1067         * WebKitTestRunner/TestController.cpp:
1068         (WTR::TestController::createOtherPage):
1069         (WTR::TestController::createWebViewWithOptions):
1070         Update for new callback.
1071
1072 2015-03-11  Benjamin Poulain  <bpoulain@apple.com>
1073
1074         Add basic support for BOL and EOL assertions to the URL Filter parser
1075         https://bugs.webkit.org/show_bug.cgi?id=142568
1076
1077         Reviewed by Alex Christensen.
1078
1079         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1080         (TestWebKitAPI::TEST_F):
1081
1082 2015-03-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1083
1084         [GTK] Add support for handling TLS errors to MiniBrowser
1085         https://bugs.webkit.org/show_bug.cgi?id=142576
1086
1087         Reviewed by Sergio Villar Senin.
1088
1089         It's useful for testing TLS errors handling itself, but also to
1090         allow ignoring TLS errors when testing.
1091
1092         * MiniBrowser/gtk/BrowserWindow.c:
1093         (webViewLoadFailedWithTLSerrors):
1094         (browserWindowConstructed):
1095
1096 2015-03-11  Myles C. Maxfield  <mmaxfield@apple.com>
1097
1098         Use out-of-band messaging for RenderBox::firstLineBaseline() and RenderBox::inlineBlockBaseline()
1099         https://bugs.webkit.org/show_bug.cgi?id=142569
1100
1101         Reviewed by David Hyatt.
1102
1103         Test Optional::valueOrCompute().
1104
1105         * TestWebKitAPI/Tests/WTF/Optional.cpp:
1106         (TestWebKitAPI::TEST):
1107
1108 2015-03-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1109
1110         [GTK] Add an option to enable MiniBrowser for non developer builds and always install it
1111         https://bugs.webkit.org/show_bug.cgi?id=126688
1112
1113         Reviewed by Gustavo Noronha Silva.
1114
1115         * CMakeLists.txt: Build testing tools only for developer builds,
1116         but MiniBrowser when ENABLE_MINIBROWSER option is ON.
1117         * MiniBrowser/gtk/CMakeLists.txt: Only add
1118         -DWEBKIT_INJECTED_BUNDLE_PATH to the build for developer builds,
1119         and add a rule to install the MiniBrowser.
1120         * MiniBrowser/gtk/main.c:
1121         (main): Only set WEBKIT_INJECTED_BUNDLE_PATH env var for developer
1122         builds.
1123
1124 2015-03-11  Brent Fulgham  <bfulgham@apple.com>
1125
1126         Add some DateMath tests to TestWebKitAPI
1127         https://bugs.webkit.org/show_bug.cgi?id=142565
1128
1129         Reviewed by Alexey Proskuryakov.
1130
1131         * TestWebKitAPI/CMakeLists.txt: Add new DateMath.cpp file.
1132         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Ditto.
1133         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters: Ditto.
1134         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto."
1135         * TestWebKitAPI/Tests/WTF/DateMath.cpp: Added.
1136
1137 2015-03-10  Brent Fulgham  <bfulgham@apple.com>
1138
1139         Regression(r181257): WTF_WorkQueue.Simple is flaky
1140         https://bugs.webkit.org/show_bug.cgi?id=142560
1141
1142         Unreviewed attempt to improve test stability.
1143
1144         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp: Check the reference count for
1145         the WorkQueue a little later to redue flakiness.
1146
1147 2015-03-10  Myles C. Maxfield  <mmaxfield@apple.com>
1148
1149         Migrate from SystemUIFontSelect to AppleSystemFontOSSubversion
1150         https://bugs.webkit.org/show_bug.cgi?id=142555
1151
1152         Reviewed by Simon Fraser.
1153
1154         * DumpRenderTree/mac/DumpRenderTree.mm:
1155         (setDefaultsToConsistentValuesForTesting):
1156         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1157         (WTR::InjectedBundle::platformInitialize):
1158
1159 2015-03-10  Alex Christensen  <achristensen@webkit.org>
1160
1161         Use unsigned for HashSet size.
1162         https://bugs.webkit.org/show_bug.cgi?id=142518
1163
1164         Reviewed by Benjamin Poulain.
1165
1166         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1167         (TestWebKitAPI::TEST):
1168         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
1169         (TestWebKitAPI::testInitialCapacity):
1170         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
1171         (TestWebKitAPI::TEST):
1172
1173 2015-03-10  Daniel Bates  <dabates@apple.com>
1174
1175         [iOS] Add WebKitSystemInterface for iOS 8.2
1176         https://bugs.webkit.org/show_bug.cgi?id=142505
1177
1178         Rubber-stamped by Anders Carlsson.
1179
1180         Make copy-webkitlibraries-to-product-directory install libWebKitSystemInterfaceIOS{Device, Simulator}8.2.a.
1181         I inadvertently forgot to add libWebKitSystemInterfaceIOS{Device, Simulator}8.2.a to script
1182         copy-webkitlibraries-to-product-directory in r181286.
1183
1184         * Scripts/copy-webkitlibraries-to-product-directory:
1185
1186 2015-03-10  Benjamin Poulain  <bpoulain@apple.com>
1187
1188         Extend URL filter's Term definition to support groups/subpatterns
1189         https://bugs.webkit.org/show_bug.cgi?id=142519
1190
1191         Reviewed by Alex Christensen.
1192
1193         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1194         (TestWebKitAPI::testURL):
1195
1196 2015-03-06  Jer Noble  <jer.noble@apple.com>
1197
1198         Add an option to run-webkit-tests to override the LayoutTests/ directory
1199         https://bugs.webkit.org/show_bug.cgi?id=142418
1200
1201         Reviewed by David Kilzer.
1202
1203         Add an arugment to run-webkit-tests which, when set, overrides the port's default LayoutTests
1204         directory. The base port will parse the options during initialization and store the override
1205         location if present. layout_tests_dir() will return this overridden location if set.
1206
1207         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1208         (parse_args):
1209         * Scripts/webkitpy/port/base.py:
1210         (Port.__init__):
1211         (Port.layout_tests_dir):
1212
1213 2015-03-09  Martin Robinson  <mrobinson@igalia.com>
1214
1215         [CMake] Enable WorkQueue tests for CMake ports
1216         https://bugs.webkit.org/show_bug.cgi?id=142473
1217
1218         Reviewed by Darin Adler.
1219
1220         * TestWebKitAPI/CMakeLists.txt: Add the WorkQueue tests source file to
1221         the list of source files.
1222         * Tools/TestWebKitAPI/PlatformEfl.cmake: Add the DispatchQueueEfl directory
1223         to the list of include directories for EFL.
1224
1225 2015-03-09  David Kilzer  <ddkilzer@apple.com>
1226
1227         Attempt to fix timeouts on iOS Simulator layout tests
1228
1229         * Scripts/webkitpy/port/ios.py:
1230         (IOSSimulatorPort.setup_test_run): Most layout test runs on iOS
1231         Simulator end after the first 50 tests time out.  Some analysis
1232         this past weekend shows that the 'Booted' status in the output
1233         of `xcrun simctl list` is not sufficient (and watching the test
1234         run shows that SpringBoard hasn't fully started to the point
1235         where it's displaying icons on the home screen).  The workaround
1236         until we have a better fix is to add an arbitrary timeout to let
1237         SpringBoard finish launching.  In practice, 15 seconds is
1238         probably enough, but 30 seconds should nearly always work.
1239
1240 2015-03-09  Per Arne Vollan  <peavo@outlook.com>
1241
1242         Unreviewed. Add myself as a committer.
1243
1244         * Scripts/webkitpy/common/config/contributors.json:
1245
1246 2015-03-09  David Kilzer  <ddkilzer@apple.com>
1247
1248         Attempt to fix WTF_WorkQueue.TwoQueues timeout test failure
1249
1250         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
1251         (TestWebKitAPI::TEST): Change delay from 50ns to 50ms, and add
1252         an expectation that will fail if we hit the race condition.
1253         This test is inherently racy and will deadlock if the first job
1254         for queue2 takes the mutex lock before the second job for
1255         queue1.
1256
1257 2015-03-08  Brent Fulgham  <bfulgham@apple.com>
1258
1259         [Win] WTF::WorkQueue does not balance ref/deref properly
1260         https://bugs.webkit.org/show_bug.cgi?id=142471
1261
1262         Reviewed by Antti Koivisto.
1263
1264         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
1265         (TestWebKitAPI::TEST): Check that the refcount is correct.
1266
1267 2015-03-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1268
1269         Do not show passing test result on output of EFL layout test
1270         https://bugs.webkit.org/show_bug.cgi?id=142380
1271
1272         Reviewed by Darin Adler.
1273
1274         To show passing tests has caused inconvenience when we detect problem tests
1275         in output of layout test. So this patch applies '--debug-rwt-logging' except for EFL port
1276         in order not to show passing tests in the output of EFL layout test.
1277
1278         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1279         (RunWebKitTests.start):
1280
1281 2015-03-08  Brent Fulgham  <bfulgham@apple.com>
1282
1283         Unreviewed build fix.
1284
1285         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
1286         (TestWebKitAPI::TEST): Remove two unused variables.
1287
1288 2015-03-08  Brent Fulgham  <bfulgham@apple.com>
1289
1290         Add some WorkQueue tests to TestWebKitAPI
1291         https://bugs.webkit.org/show_bug.cgi?id=142447
1292
1293         Reviewed by Sam Weinig.
1294
1295         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1296         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
1297         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1298         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp: Added.
1299         (TestWebKitAPI::simpleTest):
1300         (TestWebKitAPI::longTest):
1301         (TestWebKitAPI::thirdTest):
1302         (TestWebKitAPI::finishedTests):
1303         (TestWebKitAPI::TEST):
1304         (TestWebKitAPI::longTest2):
1305
1306 2015-03-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1307
1308         Remove willDestroyFrame in WKBundlePageLoaderClient
1309         https://bugs.webkit.org/show_bug.cgi?id=142389
1310
1311         Reviewed by Anders Carlsson.
1312
1313         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1314         (WTR::InjectedBundlePage::InjectedBundlePage):
1315
1316 2015-03-07  Brent Fulgham  <bfulgham@apple.com>
1317
1318         [Win] Increase TestWebKitAPI Test Coverage[Win] Increase TestWebKitAPI Test Coverage
1319         https://bugs.webkit.org/show_bug.cgi?id=142433
1320
1321         Reviewed by Darin Adler.
1322
1323         Include more TestWebKitAPI tests when building for Windows. Also
1324         fix a build error in MetaAllocator.cpp caused by one of the
1325         Microsoft headers #defining 'small'.
1326
1327         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1328         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
1329         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
1330
1331 2015-03-06  Sam Weinig  <sam@webkit.org>
1332
1333         [Content Extensions] Move compiling of content extensions to the UIProcess
1334         https://bugs.webkit.org/show_bug.cgi?id=142402
1335
1336         Reviewed by Benjamin Poulain.
1337
1338         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1339         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: Copied from Tools/TestWebKitAPI/Tests/WebCore/ContentFilter.cpp.
1340         (TestWebKitAPI::InMemoryCompiledContentExtension::create):
1341         (TestWebKitAPI::InMemoryCompiledContentExtension::~InMemoryCompiledContentExtension):
1342         (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
1343         (TestWebKitAPI::TEST_F):
1344         * TestWebKitAPI/Tests/WebCore/ContentFilter.cpp: Removed.
1345         Update test for new name (ContentFilter -> ContentExtensions) and API (CompiledContentExtension
1346         is now abstract).
1347
1348 2015-03-06  Brent Fulgham  <bfulgham@apple.com>
1349
1350         [Win] Correct Windows build.
1351
1352         Rubberstamped by Michael Saboff
1353
1354         * win/AssembleBuildLogs/AssembleLogs.cmd: Correct cut/paste error
1355         in the GOTO labels.
1356
1357 2015-03-06  Carlos Garcia Campos  <cgarcia@igalia.com>
1358
1359         [GTK] Test /webkit2/WebKitWebView/sync-request-on-max-conns might fail after finished
1360         https://bugs.webkit.org/show_bug.cgi?id=142385
1361
1362         Reviewed by Sergio Villar Senin.
1363
1364         Use stack allocated GMainLoopSources to make sure they are
1365         cancelled automatically if the test finishes before they have
1366         been processed.
1367
1368         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1369         (testWebViewSyncRequestOnMaxConns):
1370
1371 2015-03-06  Csaba Osztrogonác  <ossy@webkit.org>
1372
1373         Remove Mountain Lion libraries since ML isn't supported
1374         https://bugs.webkit.org/show_bug.cgi?id=142332
1375
1376         Reviewed by Darin Adler.
1377
1378         * Scripts/copy-webkitlibraries-to-product-directory:
1379
1380 2015-03-06  Carlos Alberto Lopez Perez <clopez@igalia.com> and Youenn Fablet  <youenn.fablet@crf.canon.fr>
1381
1382         Layout tests imported/w3c/web-platform-tests certificates should not be tracked on WebKit VCS
1383         https://bugs.webkit.org/show_bug.cgi?id=142083
1384
1385         Reviewed by Simon Fraser.
1386
1387         Modifying on the fly wpt config.json to set the directory where to generate/read certificates as a subfolder of the layout test results folder.
1388
1389         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1390         (WebPlatformTestServer._copy_webkit_test_files):
1391
1392 2015-03-06  Csaba Osztrogonác  <ossy@webkit.org>
1393
1394         setup-git-clone fails due to the failure to download python-irclib-0.4.8
1395         https://bugs.webkit.org/show_bug.cgi?id=141946
1396
1397         Reviewed by Ryosuke Niwa.
1398
1399         Check in ircbot.py and irclib.py to avoid network problems in the future.
1400
1401         * Scripts/webkitpy/common/net/irc/ircbot.py:
1402         * Scripts/webkitpy/thirdparty/__init__.py:
1403         (AutoinstallImportHook.find_module):
1404         (AutoinstallImportHook._install_irc): Deleted.
1405         * Scripts/webkitpy/thirdparty/__init___unittest.py:
1406         (ThirdpartyTest.test_imports):
1407         * Scripts/webkitpy/thirdparty/irc/__init__.py: Added.
1408         * Scripts/webkitpy/thirdparty/irc/ircbot.py: Added.
1409         * Scripts/webkitpy/thirdparty/irc/irclib.py: Added.
1410
1411 2015-03-06  David Kilzer  <ddkilzer@apple.com>
1412
1413         Dashboard: Perf bot status is missing for Apple {Mavericks,Yosemite} Release builds
1414
1415         See also fix to config.json in r181097.
1416
1417         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1418         (WebKitBuildbot): Add missing "WK2" to the names of the perf
1419         bots.
1420
1421 2015-03-06  Csaba Osztrogonác  <ossy@webkit.org>
1422
1423         run-jsc-stress-tests should determine the architecture from ELF binaries
1424         https://bugs.webkit.org/show_bug.cgi?id=142335
1425
1426         Reviewed by Darin Adler.
1427
1428         * Scripts/run-jsc-stress-tests:
1429
1430 2015-03-05  David Kilzer  <ddkilzer@apple.com>
1431
1432         [iOS] TestExpectations for ios-simulator-wk2 should fall back to 'wk2' after 'ios-simulator'
1433         <http://webkit.org/b/142226>
1434
1435         Reviewed by Darin Adler.
1436
1437         * Scripts/webkitpy/port/ios.py:
1438         (IOSSimulatorPort.default_baseline_search_path): Switch the
1439         TestExpectations order of ios-simulator-wk2 from this:
1440           ios-simulator-wk2, wk2, ios-simulator
1441         To this:
1442           ios-simulator-wk2, ios-simualtor, wk2
1443
1444 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
1445
1446         [Win] Provide tiered logging from MSBuild -- Errors on top, Warnings after
1447         https://bugs.webkit.org/show_bug.cgi?id=142370
1448
1449         Reviewed by Dean Jackson.
1450
1451         * Scripts/webkitdirs.pm:
1452         (buildVisualStudioProject): Tell MSBuild to output log files to two separate
1453         logs, one for warnings, the other for errors.
1454         * win/AssembleBuildLogs/AssembleLogs.cmd: Combine the error and warning logs
1455         into the standard BuildOutput.htm document.
1456
1457 2015-03-05  David Kilzer  <ddkilzer@apple.com>
1458
1459         Dashboard has trouble parsing iOS test output
1460         <http://webkit.org/b/142364>
1461
1462         Reviewed by Alex Christensen.
1463
1464         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
1465         (BuildbotTestResults.prototype._parseResults.resultSummarizer):
1466         Add fallback path to build a regex using 'matchString' so that
1467         it matches anywhere in the line.  In practice, 'matchString' is
1468         a prefix for the label following the number.
1469
1470 2015-03-05  Alex Christensen  <achristensen@webkit.org>
1471
1472         Fix linker warnings in TestWebKitAPI.
1473         https://bugs.webkit.org/show_bug.cgi?id=141912
1474
1475         Reviewed by David Kilzer.
1476
1477         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1478         Do not export TearDownTestCase or SetUpTestCase symbols.
1479
1480 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
1481
1482         [Win] Unreviewed EWS fix.
1483
1484         * Scripts/webkitdirs.pm:
1485         (buildVisualStudioProject): Dial logging back to 'ErrorsOnly' to see if that makes
1486         the EWS output more usable.
1487
1488 2015-03-05  Chris Dumez  <cdumez@apple.com>
1489
1490         Regression(r173761): ASSERTION FAILED: !is8Bit() in StringImpl::characters16()
1491         https://bugs.webkit.org/show_bug.cgi?id=142350
1492
1493         Reviewed by Michael Saboff and Benjamin Poulain.
1494
1495         Add API test for WTFString::hasInfixStartingAt() to make sure it doesn't
1496         crash if the string is 8-bit but the pattern is 16-bit (and vice-versa).
1497
1498         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
1499         (TestWebKitAPI::TEST):
1500
1501 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
1502
1503         [Win] Ensure build target directory exists when launching MSBuild
1504         https://bugs.webkit.org/show_bug.cgi?id=142360
1505
1506         Reviewed by Dean Jackson.
1507
1508         Create the build output directory (if it doesn't exist) before
1509         launching MSBuild so that it can immediately begin writing logs.
1510
1511         * Scripts/webkitdirs.pm:
1512         (buildVisualStudioProject):
1513
1514 2015-03-05  Chris Dumez  <cdumez@apple.com>
1515
1516         run-webkit-tests and run-perf-tests should use WebKitTestRunner by default
1517         https://bugs.webkit.org/show_bug.cgi?id=142325
1518
1519         Reviewed by Csaba Osztrogonác.
1520
1521         run-webkit-tests and run-perf-tests now use WebKitTestRunner by default.
1522         As a result, "--webkit-test-runner / -2" parameters are replaced by
1523         "--dump-render-tree / -1" so developers can run DumpRenderTree rather
1524         than WebKitTestRunner.
1525
1526         * BuildSlaveSupport/build.webkit.org-config/config.json:
1527         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1528         (RunWebKit1Tests):
1529         (RunWebKit1Tests.start):
1530         (RunWebKit1LeakTests):
1531         (RunWebKit1LeakTests.start):
1532         (RunAndUploadPerfTestsWebKit1):
1533         (RunAndUploadPerfTestsWebKit1.start):
1534         (TestFactory):
1535         (TestWebKit1LeaksFactory):
1536         (TestWebKit1LeaksFactory.__init__):
1537         (TestWebKit1Factory):
1538         (TestWebKit1AllButJSCFactory):
1539         (TestAllButJSCFactory):
1540         (BuildAndPerfTestWebKit1Factory):
1541         (BuildAndPerfTestWebKit1Factory.__init__):
1542         (BuildAndPerfTestFactory):
1543         (BuildAndPerfTestFactory.__init__):
1544         (DownloadAndPerfTestWebKit1Factory):
1545         (DownloadAndPerfTestWebKit1Factory.__init__):
1546         (DownloadAndPerfTestFactory):
1547         (DownloadAndPerfTestFactory.__init__):
1548         (RunWebKitLeakTests): Deleted.
1549         (RunWebKitLeakTests.start): Deleted.
1550         (RunWebKit2Tests): Deleted.
1551         (RunWebKit2Tests.start): Deleted.
1552         (RunAndUploadPerfTestsWebKit2): Deleted.
1553         (RunAndUploadPerfTestsWebKit2.start): Deleted.
1554         (TestLeaksFactory): Deleted.
1555         (TestLeaksFactory.__init__): Deleted.
1556         (TestWebKit2Factory): Deleted.
1557         (TestWebKit2AndJSCFactory): Deleted.
1558         (BuildAndPerfTestWebKit2Factory): Deleted.
1559         (BuildAndPerfTestWebKit2Factory.__init__): Deleted.
1560         (DownloadAndPerfTestWebKit2Factory): Deleted.
1561         (DownloadAndPerfTestWebKit2Factory.__init__): Deleted.
1562         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1563         (parse_args):
1564         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1565         (PerfTestsRunner._parse_args):
1566         * Scripts/webkitpy/port/port_testcase.py:
1567         (PortTestCase.test_build_driver):
1568
1569 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
1570
1571         [Win] Switch to MSBuild so we get more useful stdout logging in buildbot
1572         https://bugs.webkit.org/show_bug.cgi?id=140845
1573
1574         Reviewed by David Kilzer.
1575
1576         Update 'webkitdirs.pm' to locate the MSBuild used with Visual Studio 2013
1577         and generate suitable build commands to drive a full build from our
1578         existing solution files.
1579
1580         * Scripts/webkitdirs.pm:
1581         (msBuildInstallDir): Added.
1582         (determineConfigurationForVisualStudio): Revise to use MSBuild command
1583         line arguments to drive the build.
1584         (setupCygwinEnv): Warn user if MSBuild cannot be located.
1585         (buildVisualStudioProject): Revise to use MSBuild command line arguments
1586         to specify build architecture.
1587         * win/AssembleBuildLogs/AssembleLogs.cmd: MSBuild doesn't produce individual
1588         output logs, so don't attempt to consolidate them. Also: Drive-by fix: Don't
1589         bother looking for CoreUI or SafariTheme build logs.
1590
1591 2015-03-05  Csaba Osztrogonác  <ossy@webkit.org>
1592
1593         [buildbot] mastercfg_unittest.py should be runnable easily
1594         https://bugs.webkit.org/show_bug.cgi?id=142219
1595
1596         Reviewed by Chris Dumez.
1597
1598         Buildbot 0.8.6p1 runs on build.webkit org with Twisted 12.1.0, which is
1599         the last Twisted version works together with this buildbot version.
1600
1601         * Scripts/webkitpy/common/system/autoinstall.py:
1602         (AutoInstaller): Added prepend_to_search_path argument to be able
1603         to prefer autoinstalled package to system package.
1604         (AutoInstaller.__init__):
1605         (AutoInstaller._set_up_target_dir):
1606         (AutoInstaller._extract_tar): Renamed from _extract_targz, now it works with tar.bz2 too.
1607         (AutoInstaller._prepare_package):
1608         (AutoInstaller._extract_targz): Renamed to _extract_tar.
1609         * Scripts/webkitpy/thirdparty/__init__.py:
1610         (AutoinstallImportHook._install_buildbot): Autoinstall Twisted 12.1.0.
1611
1612 2015-03-05  Lukasz Bialek  <l.bialek@samsung.com>
1613
1614         [EFL][WK2] Crash when "Download Linked File" from MiniBrowser context menu is clicked
1615         https://bugs.webkit.org/show_bug.cgi?id=131162
1616
1617         Reviewed by Gyuyoung Kim.
1618
1619         * MiniBrowser/efl/main.c:
1620         (on_download_request):
1621         (on_download_finished):
1622         (on_download_failed):
1623         (window_create):
1624         Adapt download callbacks to new callback mechanism
1625
1626 2015-03-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1627
1628         Unreviewed. Fix /webkit2/WebKitWebResource/mime-type after r180927.
1629
1630         In r180927 we updated the libsoup version used by the jhbuild. In
1631         this new version the sniffer uses image/x-icon instead of
1632         image/vnd.microsoft.icon for blank.ico resource.
1633
1634         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1635         (testWebResourceMimeType):
1636
1637 2015-03-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1638
1639         [SOUP] Check TLS errors as soon as they are set in the SoupMessage
1640         https://bugs.webkit.org/show_bug.cgi?id=142244
1641
1642         Reviewed by Sergio Villar Senin.
1643
1644         Check that the SSL server doesn't process any request in case of
1645         TLS errors when the policy is set to FAIL.
1646
1647         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
1648         (testTLSErrorsPolicy):
1649         (testTLSErrorsRedirect):
1650         (testTLSErrorsHTTPAuth):
1651         (testLoadFailedWithTLSErrors):
1652         (testSubresourceLoadFailedWithTLSErrors):
1653         (httpsServerCallback):
1654
1655 2015-03-05  Pawel Forysiuk  <p.forysiuk@samsung.com>
1656
1657         [EFL] REGRESSION (r178685): ASSERTION FAILED: !parameters.mediaKeyStorageDirectory.isEmpty()
1658         https://bugs.webkit.org/show_bug.cgi?id=141154
1659
1660         Reviewed by Jer Noble.
1661
1662         Unlike GTK, EFL port enables ENABLE_ENCRYPTED_MEDIA_V2 build option by default.
1663
1664         For the sake of completeness WebKitTestRunner should specify temporary
1665         folder for MediaKeysStorageDirecory as well as IndexedDB, LocalStorage, etc.
1666
1667         Default non legacy paths are set up in ProcessPoolConfiguration constructor.
1668         They use WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation
1669         to get data storage paths. Only Mac port has an actual implementation of it.
1670         However, WebKitTestRunner overrides them in favour of unique temporary dir
1671         which is taken from libraryPathForTesting().
1672
1673         Since WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation
1674         is not implemented for EFL and GTK ports it returns an empty string.
1675         All default data folders besides MediaKeys are overridden in TestRunner
1676         code with unique temporary folders derived from DUMPRENDERTREE_TEMP
1677         env variable.
1678
1679         GTK port does not enable encrypted keys by default so
1680         WebMediaKeyStorageManager::initialize() code path is never triggered.
1681
1682         * WebKitTestRunner/TestController.cpp:
1683         (WTR::TestController::initialize): Set MediaKeysStorageDirectory for all
1684         WebKit ports.
1685
1686 2015-03-05  Csaba Osztrogonác  <ossy@webkit.org>
1687
1688         [buildbot] Add regression test to check which builder runs which tests
1689         https://bugs.webkit.org/show_bug.cgi?id=142166
1690
1691         Reviewed by Alexey Proskuryakov.
1692
1693         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1694         (BuildStepsConstructorTest.createTest):
1695         (BuildStepsTest):
1696         (BuildStepsTest.generateTests):
1697         (BuildStepsTest.createTest):
1698         (BuildStepsTest.createTest.doTest):
1699         (BuildStepsTest.test_unnecessary_expected_results):
1700
1701 2015-03-04  Commit Queue  <commit-queue@webkit.org>
1702
1703         Unreviewed, rolling out r181054.
1704         https://bugs.webkit.org/show_bug.cgi?id=142320
1705
1706         Broke the api tests (Requested by sundiamonde on #webkit).
1707
1708         Reverted changeset:
1709
1710         "Fix linker warnings in TestWebKitAPI."
1711         https://bugs.webkit.org/show_bug.cgi?id=141912
1712         http://trac.webkit.org/changeset/181054
1713
1714 2015-03-04  Alex Christensen  <achristensen@webkit.org>
1715
1716         Fix linker warnings in TestWebKitAPI.
1717         https://bugs.webkit.org/show_bug.cgi?id=141912
1718
1719         Reviewed by David Kilzer.
1720
1721         * TestWebKitAPI/Configurations/Base.xcconfig:
1722         Use GCC_SYMBOLS_PRIVATE_EXTERN like we do in WebCore.
1723
1724 2015-03-04  Alexey Proskuryakov  <ap@apple.com>
1725
1726         [Mac] Set SystemUIFontSelect in DRT and WKTR
1727         https://bugs.webkit.org/show_bug.cgi?id=142303
1728
1729         Reviewed by Myles C. Maxfield.
1730
1731         * DumpRenderTree/mac/DumpRenderTree.mm:
1732         (setDefaultsToConsistentValuesForTesting):
1733         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1734         (WTR::InjectedBundle::platformInitialize):
1735
1736 2015-03-04  Chris Dumez  <cdumez@apple.com>
1737
1738         Mac Perf bots should use WebKitTestRunner instead of DumpRenderTree
1739         https://bugs.webkit.org/show_bug.cgi?id=142314
1740         <rdar://problem/20046835>
1741
1742         Reviewed by Ryosuke Niwa.
1743
1744         Mac Perf bots should use WebKitTestRunner instead of DumpRenderTree
1745         to get WK2 code coverage.
1746
1747         * BuildSlaveSupport/build.webkit.org-config/config.json:
1748
1749 2015-03-04  Alex Christensen  <achristensen@webkit.org>
1750
1751         Move content extensions test to properly named directory.
1752         https://bugs.webkit.org/show_bug.cgi?id=142299
1753
1754         Reviewed by Tim Horton.
1755
1756         * WebKitTestRunner/mac/TestControllerMac.mm:
1757         (WTR::TestController::platformConfigureViewForTest):
1758
1759 2015-03-04  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1760
1761         W3C test importer should use filesystem instead of os.walk
1762         https://bugs.webkit.org/show_bug.cgi?id=142085
1763
1764         Reviewed by Bem Jones-Bey.
1765
1766         Added FileSystem.dirs_under to remove the use of os.walk in test importer.
1767         Added MockFileSystem.dirs_under and MockFileSystem.getsize to enable unit testing of test importer.
1768         Added unit test for FileSystem.dirs_under and MockFileSystem.dirs_under.
1769
1770         Made use of FileSystem.dirs_under within TestImporter.find_importable_tests.
1771         Added a unit test to check that test importer is now black-box testable using a Mock system.
1772
1773         * Scripts/webkitpy/common/system/filesystem.py:
1774         (FileSystem.dirs_under): Returns a list of filtered sub-directories.
1775         (FileSystem.dirs_under.filter_all):
1776         * Scripts/webkitpy/common/system/filesystem_mock.py:
1777         (MockFileSystem.dirs_under):
1778         (MockFileSystem.dirs_under.filter_all):
1779         (MockFileSystem.getsize):
1780         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
1781         (MockFileSystemTest.test_dirs_under):
1782         (MockFileSystemTest.test_dirs_under.filter_dir):
1783         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1784         (RealFileSystemTest.test_sep):
1785         (RealFileSystemTest):
1786         (RealFileSystemTest.test_dirs_under):
1787         (RealFileSystemTest.test_dirs_under.filter_this_dir):
1788         * Scripts/webkitpy/w3c/test_importer.py:
1789         (TestImporter.do_import):
1790         (TestImporter.find_importable_tests.should_keep_subdir):
1791         (TestImporter.find_importable_tests):
1792         (TestImporter.should_keep_subdir): Deleted.
1793         (TestImporter.should_skip_file): Deleted.
1794         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1795         (TestImporterTest.test_import_dir_with_empty_init_py): Added test to ensure empty __init__.py are no longer empty once imported.
1796
1797 2015-03-04  Timothy Horton  <timothy_horton@apple.com>
1798
1799         [WebEditingTester] Add support for the find and replace bar
1800         https://bugs.webkit.org/show_bug.cgi?id=142247
1801
1802         Reviewed by Enrica Casucci.
1803
1804         While it's not hooked up yet in WKWebView, adding support for the
1805         find bar to WebEditingTester will help us implement that functionality.
1806
1807         * WebEditingTester/AppDelegate.h:
1808         * WebEditingTester/AppDelegate.m:
1809         (-[WebEditingAppDelegate performTextFinderAction:]):
1810         * WebEditingTester/MainMenu.xib:
1811         Receive performTextFinderAction: and forward it to the frontmost WebDocumentController.
1812
1813         * WebEditingTester/WK2WebDocumentController.m:
1814         (-[WK2WebDocumentController awakeFromNib]):
1815         (-[WK2WebDocumentController performTextFinderAction:]):
1816         (-[WK2WebDocumentController findBarView]):
1817         (-[WK2WebDocumentController setFindBarView:]):
1818         (-[WK2WebDocumentController isFindBarVisible]):
1819         (-[WK2WebDocumentController setFindBarVisible:]):
1820         (-[WK2WebDocumentController findBarViewDidChangeHeight]):
1821         (-[WK2WebDocumentController layout]):
1822         Implement performTextFinderAction: for WebKit2, and have a NSTextFinder
1823         pointing at the WKWebView (currently nothing will work, but the bar will
1824         show up). Install and uninstall the bar as needed.
1825
1826         * WebEditingTester/WebDocument.xib:
1827         Don't use a full-size content view. There's no need, and it makes find
1828         bar layout harder.
1829
1830         * WebEditingTester/WebDocumentController.h:
1831         * WebEditingTester/WebDocumentController.m:
1832         (-[WebDocumentController performTextFinderAction:]):
1833
1834 2015-03-03  Sam Weinig  <sam@webkit.org>
1835
1836         [Content Extensions] Split parsing and compiling of content extensions into their own files
1837         https://bugs.webkit.org/show_bug.cgi?id=142259
1838
1839         Reviewed by Anders Carlsson.
1840
1841         Add basic unit test for the content filter compiler.
1842
1843         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1844         * TestWebKitAPI/Tests/WebCore/ContentFilter.cpp: Added.
1845         (WebCore::ContentExtensions::operator<<):
1846         (TestWebKitAPI::ContentFilterTest::SetUp):
1847         (TestWebKitAPI::TEST_F):
1848
1849 2015-03-04  Matthew Mirman  <mmirman@apple.com>
1850
1851         Cleaned up BuildAndTestFactory to not be a near duplicate of TestFactory
1852         https://bugs.webkit.org/show_bug.cgi?id=142230
1853
1854         Reviewed by Csaba Osztrogonác.
1855
1856         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1857         (TestFactory):
1858         (TestFactory.getProduct): Added
1859         (TestFactory.__init__): moved downloader to getProduct
1860         (BuildAndTestFactory):        
1861         (BuildAndTestFactory.getProduct): Added
1862         (BuildAndTestFactory.__init__): made to call TestFactory.__init__ and append steps to the end.
1863         (BuildAndTestWebKit2Factory): Deleted.  Wasn't used anywhere.
1864
1865 2015-03-04  Debarshi Ray  <debarshir@gnome.org>
1866
1867         [GTK] WebView should hold a reference on WebContext because non-default contexts are a reality
1868         https://bugs.webkit.org/show_bug.cgi?id=142225
1869
1870         Reviewed by Carlos Garcia Campos.
1871
1872         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1873         (testWebViewWebContextLifetime):
1874         (beforeAll):
1875
1876 2015-03-03  David Kilzer  <ddkilzer@apple.com>
1877
1878         [iOS] Crash logs can't be found on ios-simulator because WebKitTestRunner returns the wrong process name
1879         <http://webkit.org/b/142243>
1880
1881         Reviewed by Alexey Proskuryakov.
1882
1883         * WebKitTestRunner/TestController.cpp:
1884         (WTR::TestController::webProcessName):
1885         (WTR::TestController::networkProcessName):
1886         - Return the same process name on iOS and Mac because they both
1887           use the same process name for local engineering builds.
1888
1889 2015-03-03  David Kilzer  <ddkilzer@apple.com>
1890
1891         check-webkit-style: Add exception for FrameworkSoftLink.h header order
1892         <http://webkit.org/b/141872>
1893
1894         Reviewed by Alex Christensen.
1895
1896         * Scripts/webkitpy/style/checkers/cpp.py: Remove unneeded
1897         semi-colons in various places and fix whitespace.
1898         (_IncludeState): Add _SOFT_LINK_HEADER and _SOFT_LINK_SECTION
1899         constants.
1900         (_IncludeState.__init__): Add self._visited_soft_link_section
1901         boolean state variable.
1902         (_IncludeState.visited_soft_link_section): Getter for
1903         self._visited_soft_link_section.
1904         (_IncludeState.check_next_include_order): Update state machine
1905         for soft-link headers.  Add check that soft-link headers always
1906         appear last.
1907         (_classify_include): Add check for soft-link header type.
1908         (check_include_line): Return early if there is a soft-link
1909         header error.
1910
1911         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1912         (OrderOfIncludesTest.test_public_primary_header): Add tests for
1913         including soft-link headers.
1914         (OrderOfIncludesTest.test_classify_include): Add test for
1915         _SOFT_LINK_HEADER type.
1916
1917 2015-03-03  Alexey Proskuryakov  <ap@apple.com>
1918
1919         build.webkit.org/dashboard: Don't repeatedly handle each test type
1920         https://bugs.webkit.org/show_bug.cgi?id=142211
1921
1922         Reviewed by Tim Horton and Matt Hanson.
1923
1924         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1925         (Buildbot.prototype.javascriptTestResultsURLForIteration): Deleted.
1926         (Buildbot.prototype.apiTestResultsURLForIteration): Deleted.
1927         (Buildbot.prototype.platformAPITestResultsURLForIteration): Deleted.
1928         (Buildbot.prototype.webkitpyTestResultsURLForIteration): Deleted.
1929         (Buildbot.prototype.webkitperlTestResultsURLForIteration): Deleted.
1930         (Buildbot.prototype.bindingsTestResultsURLForIteration): Deleted.
1931         Removed functions that build a link to test step results. The buildbot provides
1932         these links in JSON.
1933
1934         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1935         (BuildbotIteration): Put failing tests into an array, instead of named variables.
1936         (BuildbotIteration.ProductiveSteps): Removed step names that are not used on build.webkit.org.
1937         We can easily add them to the map as needed.
1938         (BuildbotIteration.TestSteps): Added a list of test steps to be displayed by test queues.
1939         (BuildbotIteration.prototype._parseData): Moved code for parsing step results away
1940         to BuildbotTestResults class. We used to parse here, build an intermediate data structure,
1941         and then build a BuildbotTestResults object, which was strange.
1942         (BuildbotIteration.prototype.loadLayoutTestResults): Ditto.
1943
1944         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1945         Corrected an unrelated assertion that was buggy, and kept firing.
1946
1947         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
1948         (BuildbotTestResults):
1949         (BuildbotTestResults.prototype._parseResults.resultSummarizer):
1950         (BuildbotTestResults.prototype._parseResults):
1951         (BuildbotTestResults.prototype.addFullLayoutTestResults):
1952         Moved the code for parsing JSON results for a single step here.
1953
1954         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1955         (BuildbotTesterQueueView.prototype._testStepFailureDescription):
1956         (BuildbotTesterQueueView.prototype._testStepFailureDescriptionWithCount):
1957         (BuildbotTesterQueueView.prototype._presentPopoverForGenericTestFailures):
1958         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Deleted.
1959         (BuildbotTesterQueueView.prototype.update): Deleted.
1960         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds): Deleted.
1961         Updated for the new data structures. One behavior change is that we now display individual
1962         counts when multiple test kinds fail, e.g. "1 javascript test failure, 83+ layout
1963         test failures, 3 platform api test failures".
1964
1965 2015-03-03  Matthew Mirman  <mmirman@apple.com>
1966
1967         JSC tests should not be repeated twice for each branch builder, and should if possible have their own queue.
1968         https://bugs.webkit.org/show_bug.cgi?id=142094
1969
1970         Reviewed by Csaba Osztrogonác.
1971
1972         * BuildSlaveSupport/build.webkit.org-config/config.json: Added bots 155 and 157
1973         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1974         (TestFactory):
1975         (TestFactory.__init__): Made running of JSC tests conditional.
1976         (TestAllButJSCFactory):
1977         (TestJSCFactory): Added.
1978         (TestJSCFactory.__init__):
1979         (TestWebKit2AndJSCFactory): Added factory to not run JSC tests on WebKit2.
1980
1981 2015-03-03  David Kilzer  <ddkilzer@apple.com>
1982
1983         `build-webkit --help` is wrong about how to build for the iOS simulator
1984         <http://webkit.org/b/142223>
1985
1986         Reviewed by Csaba Osztrogonác.
1987
1988         * Scripts/build-webkit: Fix help.
1989
1990 2015-03-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1991
1992         Unreviewed. Bump libsoup version to 2.49.91.1 to fix 32 bit build.
1993
1994         * gtk/jhbuild.modules:
1995
1996 2015-03-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1997
1998         [SOUP] Synchronous XMLHttpRequests can time out when we reach the max connections limit
1999         https://bugs.webkit.org/show_bug.cgi?id=141508
2000
2001         Reviewed by Sergio Villar Senin.
2002
2003         Add a unit test to check that synchronous XHRs load even if the
2004         maximum connection limits are reached.
2005
2006         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2007         (testWebViewSyncRequestOnMaxConns):
2008         (serverCallback):
2009         (beforeAll):
2010         * gtk/jhbuild.modules: Bump libsoup version to 2.49.91.
2011
2012 2015-03-02  Alexey Proskuryakov  <ap@apple.com>
2013
2014         Update the name of ASan build step.
2015
2016         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2017
2018 2015-03-02  Jer Noble  <jer.noble@apple.com>
2019
2020         [WK1][WK2][Mac] Fullscreen animation is incorrect when page is scaled.
2021         https://bugs.webkit.org/show_bug.cgi?id=142121
2022
2023         Reviewed by Simon Fraser.
2024
2025         Add a test which changes the WebView's page scale, then enters fullscreen mode, and verifies
2026         that the initial and final screen rects for the web content are as expected.
2027
2028         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2029         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.html: Added.
2030         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm: Added.
2031         (-[FullscreenStateDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
2032         (runJavaScriptAlert):
2033         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
2034         (TestWebKitAPI::FullscreenZoomInitialFrame::teardownView):
2035         (TestWebKitAPI::FullscreenZoomInitialFrame::setPageScale):
2036         (TestWebKitAPI::FullscreenZoomInitialFrame::sendMouseDownEvent):
2037         (TestWebKitAPI::FullscreenZoomInitialFrame::runTest):
2038         (TestWebKitAPI::TEST_F):
2039
2040 2015-03-01  David Kilzer  <ddkilzer@apple.com>
2041
2042         LayoutTestRealy: Prepend __XPC_ to the key, not the value!
2043
2044         Follow-up fix for:
2045
2046         LayoutTestRelay: App environment variables not set for --guard-malloc or --leaks
2047         <http://webkit.org/b/142145>
2048
2049         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2050         (-[LTRelayController _environmentVariables]): Fix think-o.
2051
2052 2015-03-01  David Kilzer  <ddkilzer@apple.com>
2053
2054         LayoutTestRelay: App environment variables not set for --guard-malloc or --leaks
2055         <http://webkit.org/b/142145>
2056
2057         Reviewed by Simon Fraser.
2058
2059         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2060         (-[LTRelayController _environmentVariables]): Add.
2061         (-[LTRelayController launchApp]): Use -_environmentVariables.
2062
2063 2015-02-28  David Kilzer  <ddkilzer@apple.com>
2064
2065         [iOS] Stop running webkit-build-directory on every layout test
2066
2067         This was originally fixed by David Farler for Bug 135409 in
2068         r172602.
2069
2070         * Scripts/webkitpy/port/ios.py:
2071         (IOSSimulatorPort.relay_path): Mark as @memoized so it doesn't
2072         run webkit-build-directory every time it's called.
2073
2074 2015-02-28  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2075
2076         W3C importer should use filesystem instead of shutil/host
2077         https://bugs.webkit.org/show_bug.cgi?id=142012
2078
2079         Reviewed by Bem Jones-Bey.
2080
2081         Removed direct use of python shutil and os, except for os.walk which will require its own fix.
2082
2083         * Scripts/webkitpy/w3c/test_importer.py:
2084         (main):
2085         (TestImporter.do_import):
2086         (TestImporter.find_importable_tests):
2087         (TestImporter.import_tests):
2088         (TestImporter.remove_deleted_files):
2089         (TestImporter.write_import_log):
2090
2091 2015-02-28  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2092
2093         W3C test importer should use filesystem to read and write files
2094         https://bugs.webkit.org/show_bug.cgi?id=142084
2095
2096         Reviewed by Bem Jones-Bey.
2097
2098         Use of FileSystem.write_binary_file, read_text_file and write_text_file in lieu of open().
2099
2100         * Scripts/webkitpy/w3c/test_importer.py:
2101         (TestImporter.import_tests):
2102         (TestImporter.remove_deleted_files):
2103         (TestImporter.write_import_log):
2104
2105 2015-02-27  Sam Weinig  <sam@webkit.org>
2106
2107         Add WebKit2 SPI to create a DOM File object
2108         https://bugs.webkit.org/show_bug.cgi?id=142109
2109
2110         Reviewed by Tim Horton.
2111
2112         Add a test for WKBundleFileHandleRef.
2113
2114         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2115         * TestWebKitAPI/Tests/WebKit2/WKBundleFileHandle.cpp: Added.
2116         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
2117         (TestWebKitAPI::didFinishLoadForFrame):
2118         (TestWebKitAPI::TEST):
2119         * TestWebKitAPI/Tests/WebKit2/WKBundleFileHandle_Bundle.cpp: Added.
2120         (TestWebKitAPI::WKBundleFileHandleTest::WKBundleFileHandleTest):
2121         * TestWebKitAPI/Tests/WebKit2/bundle-file.html: Added.
2122
2123 2015-02-27  Michael Saboff  <msaboff@apple.com>
2124
2125         Add ability for run-jsc-benchmarks to set library path from test binary when run on a build bot
2126         https://bugs.webkit.org/show_bug.cgi?id=142112
2127
2128         Reviewed by Filip Pizlo.
2129
2130         Added check for VMs in the form of <someDir>/{DumpRenderTree,webkitTestRunner,jsc} and use
2131         <someDir> as the library path.
2132
2133         * Scripts/run-jsc-benchmarks:
2134
2135 2015-02-27  Alex Christensen  <achristensen@webkit.org>
2136
2137         [WinCairo] Unreviewed build fix.
2138
2139         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props:
2140         Use TestWebKitAPIPrefix.h like in TestWebKitAPICommon.props.
2141
2142 2015-02-27  Anders Carlsson  <andersca@apple.com>
2143
2144         Add infrastructure for handling website data in the network process
2145         https://bugs.webkit.org/show_bug.cgi?id=142092
2146
2147         Reviewed by Andreas Kling.
2148
2149         Add a menu item that will fetch all website data, delete the returned data records, and
2150         fetch all website data again so we can confirm that it's all empty.
2151
2152         * MiniBrowser/mac/WK2BrowserWindowController.m:
2153         (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
2154
2155 2015-02-26  Brent Fulgham  <bfulgham@apple.com>
2156
2157         [Win] Remove remaining SafariTheme cruft
2158         https://bugs.webkit.org/show_bug.cgi?id=142075
2159
2160         Reviewed by Anders Carlsson.
2161
2162         Remove reference to SafariTheme-switching preference.
2163
2164         * DumpRenderTree/win/DumpRenderTree.cpp:
2165         (resetWebPreferencesToConsistentValues):
2166         (prepareConsistentTestingEnvironment):
2167
2168 2015-02-26  Doug Russell  <d_russell@apple.com>
2169
2170         AX: Expose caret browsing preference to accessibility API
2171         https://bugs.webkit.org/show_bug.cgi?id=141862
2172
2173         Reviewed by Chris Fleizach.
2174
2175         Exposing the caret browsing setting on WebCore::Frame via the accessibility API would allow assistive tech apps to enable it contextually (for example, when the assistive tech app is running).
2176         Enabling caret browsing when assistive tech apps are running greatly improves the reliability of keyboard navigation on the web. Most especially in cases where selection would be disrupted by focus events.
2177
2178         * DumpRenderTree/AccessibilityUIElement.cpp:
2179         (setBoolAttributeValueCallback):
2180         (selectedTextMarkerRangeCallback):
2181         (resetSelectedTextMarkerRangeCallback):
2182         (AccessibilityUIElement::setBoolAttributeValue):
2183         (AccessibilityUIElement::selectedTextMarkerRange):
2184         (AccessibilityUIElement::resetSelectedTextMarkerRange):
2185         (AccessibilityUIElement::getJSClass):
2186         * DumpRenderTree/AccessibilityUIElement.h:
2187         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2188         (AccessibilityUIElement::setBoolAttributeValue):
2189         (AccessibilityUIElement::selectedTextMarkerRange):
2190         (AccessibilityUIElement::resetSelectedTextMarkerRange):
2191         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2192         (WTR::AccessibilityUIElement::selectedTextMarkerRange):
2193         (WTR::AccessibilityUIElement::resetSelectedTextMarkerRange):
2194         (WTR::AccessibilityUIElement::setBoolAttributeValue):
2195         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2196         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2197         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2198         (WTR::AccessibilityUIElement::setBoolAttributeValue):
2199         (WTR::AccessibilityUIElement::selectedTextMarkerRange):
2200         (WTR::AccessibilityUIElement::resetSelectedTextMarkerRange):
2201
2202 2015-02-26  Brent Fulgham  <bfulgham@apple.com>
2203
2204         [Win] Remove WebKitExportGenerator project (and related)
2205         https://bugs.webkit.org/show_bug.cgi?id=142035
2206
2207         Reviewed by Dean Jackson.
2208
2209         * win/AssembleBuildLogs/AssembleLogs.cmd: Don't look for a
2210         build log from WebKitExportGenerator.
2211
2212 2015-02-26  Csaba Osztrogonác  <ossy@webkit.org>
2213
2214         [EFL] Bump EFL version to 1.13.0
2215         https://bugs.webkit.org/show_bug.cgi?id=141708
2216
2217         Reviewed by Gyuyoung Kim.
2218
2219         * efl/jhbuild.modules:
2220
2221 2015-02-26  Sam Weinig  <sam@webkit.org>
2222
2223         Check in missing WebEditingTester.xcconfig file.
2224
2225         * WebEditingTester/Configurations/WebEditingTester.xcconfig: Added.
2226
2227 2015-02-26  Csaba Osztrogonác  <ossy@webkit.org>
2228
2229         [webkitpy] Remove skipped file related crufts
2230         https://bugs.webkit.org/show_bug.cgi?id=142046
2231
2232         Reviewed by Ryosuke Niwa.
2233
2234         * Scripts/webkitpy/port/base.py:
2235         (Port.skipped_layout_tests):
2236         (Port._tests_from_skipped_file_contents): Deleted.
2237         (Port): Deleted.
2238         (Port._expectations_from_skipped_files): Deleted.
2239         * Scripts/webkitpy/port/mac_unittest.py:
2240         (MacTest.test_default_timeout_ms):
2241         (MacTest): Deleted.
2242         (test_tests_from_skipped_file_contents): Deleted.
2243
2244 2015-02-26  Brent Fulgham  <bfulgham@apple.com>
2245
2246         [Win] Unreviewed WinCairo build fix after r180653.
2247
2248         TestWebKitAPI should know about proper WEBCORE_EXPORT definitions.
2249
2250         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2251         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
2252         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props:
2253         * TestWebKitAPI/win/TestWebKitAPIPrefix.cpp: Added.
2254         * TestWebKitAPI/win/TestWebKitAPIPrefix.h: Added.
2255
2256 2015-02-25  Brent Fulgham  <bfulgham@apple.com>
2257
2258         [Win] Use WEBCORE_EXPORT instead of Definition file
2259         https://bugs.webkit.org/show_bug.cgi?id=141734
2260
2261         Reviewed by Alex Christensen.
2262
2263         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2264         Use a precompiled header so we can define our export macros properly.
2265         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj.filters:
2266         Visual studio automatic update stuff.
2267         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props:
2268         Set up Precompiled Header use for project..
2269         * DumpRenderTree/win/DumpRenderTreePrefix.cpp: Added.
2270         * DumpRenderTree/DumpRenderTreePrefix.h: Update with proper export
2271         declarations for building DumpRenderTree as a client of
2272         WebCore/WebKit.
2273
2274 2015-02-25  Mark Lam  <mark.lam@apple.com>
2275
2276         ASan does not like JSC::MachineThreads::tryCopyOtherThreadStack.
2277         <https://webkit.org/b/141672>
2278
2279         Reviewed by Alexey Proskuryakov.
2280
2281         ASan does not like the fact that we memcpy the stack for GC scans.  So,
2282         we're working around this by using our own memcpy (asanUnsafeMemcpy)
2283         implementation that we can tell ASan to ignore.
2284
2285         Also removed the previous added directive to ignore *tryCopyOtherThreadStack*
2286         which isn't effective for working around this issue. 
2287
2288         * asan/webkit-asan-ignore.txt:
2289
2290 2015-02-25  Benjamin Poulain  <bpoulain@apple.com>
2291
2292         CodeBlock crashes when dumping op_push_name_scope
2293         https://bugs.webkit.org/show_bug.cgi?id=141953
2294
2295         Reviewed by Filip Pizlo.
2296
2297         * Scripts/run-jsc-stress-tests:
2298
2299 2015-02-25  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2300
2301         W3C test importer should use argparse instead of optparse
2302         https://bugs.webkit.org/show_bug.cgi?id=142013
2303
2304         Reviewed by Bem Jones-Bey.
2305
2306         * Scripts/webkitpy/w3c/test_importer.py:
2307         (main): Updating according argparse.
2308         (parse_args): Moving from optparse to argparse.
2309
2310 2015-02-25  Brady Eidson  <beidson@apple.com>
2311
2312         Get rid of TestInvocation::pathOrURL
2313         https://bugs.webkit.org/show_bug.cgi?id=142021
2314
2315         Reviewed by Tim Horton.
2316
2317         The pathOrURL string is a relative path used as an argument to WebKitTestRunner,
2318         but most code that uses it expected an absolute path.
2319
2320         This gets rid of the member and replaces all uses with a more descriptive "urlContains" method.
2321
2322         * WebKitTestRunner/TestController.cpp:
2323         (WTR::TestController::updateWebViewSizeForTest):
2324         (WTR::TestController::updateWindowScaleForTest):
2325         (WTR::shouldUseFixedLayout):
2326         (WTR::TestController::updateLayoutTypeForTest):
2327
2328         * WebKitTestRunner/TestInvocation.cpp:
2329         (WTR::TestInvocation::TestInvocation):
2330         (WTR::TestInvocation::urlContains):
2331         (WTR::TestInvocation::shouldLogFrameLoadDelegates):
2332         (WTR::TestInvocation::shouldLogHistoryClientCallbacks):
2333         (WTR::TestInvocation::invoke):
2334         (WTR::shouldLogFrameLoadDelegates): Deleted.
2335         (WTR::shouldLogHistoryClientCallbacks): Deleted.
2336         * WebKitTestRunner/TestInvocation.h:
2337         (WTR::TestInvocation::pathOrURL): Deleted.
2338
2339         * WebKitTestRunner/ios/TestControllerIOS.mm:
2340         (WTR::shouldMakeViewportFlexible):
2341         (WTR::TestController::platformConfigureViewForTest):
2342
2343         * WebKitTestRunner/mac/TestControllerMac.mm:
2344         (WTR::shouldUseThreadedScrolling):
2345         (WTR::TestController::platformConfigureViewForTest):
2346
2347 2015-02-25  Brady Eidson  <beidson@apple.com>
2348
2349         Layout test support for user content filters
2350         https://bugs.webkit.org/show_bug.cgi?id=142018
2351
2352         Reviewed by Tim Horton.
2353
2354         * WebKitTestRunner/TestController.cpp:
2355         (WTR::TestController::resetStateToConsistentValues): Clear all user content filters between tests.
2356
2357         * WebKitTestRunner/mac/TestControllerMac.mm:
2358         (WTR::TestController::platformConfigureViewForTest): For all tests with usercontentfilter/ in their path try to load a matching .json
2359           file before loading the test itself.
2360
2361 2015-02-24  Sam Weinig  <sam@webkit.org>
2362
2363         Convert WebEditingTester to use xcconfig files
2364         https://bugs.webkit.org/show_bug.cgi?id=141879
2365
2366         Reviewed by Darin Adler.
2367
2368         Add xcconfig files to WebEditingTester based on the ones used by MiniBrowser.
2369
2370         * WebEditingTester/Configurations: Added.
2371         * WebEditingTester/Configurations/Base.xcconfig: Added.
2372         * WebEditingTester/Configurations/DebugRelease.xcconfig: Added.
2373         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
2374
2375 2015-02-24  Andy Estes  <aestes@apple.com>
2376
2377         Teach MiniBrowser how to disable per-window web processes
2378         https://bugs.webkit.org/show_bug.cgi?id=141988
2379
2380         Reviewed by Darin Adler.
2381
2382         * MiniBrowser/mac/AppDelegate.m:
2383         (defaultConfiguration): Created a _WKProcessPoolConfiguration with maximumProcessCount == 1 if per-window web processes are disabled.
2384         * MiniBrowser/mac/SettingsController.h:
2385         * MiniBrowser/mac/SettingsController.m:
2386         (-[SettingsController _populateMenu]): Added a new Settings menu item.
2387         (-[SettingsController validateMenuItem:]): Validated the new Settings menu item.
2388         (-[SettingsController togglePerWindowWebProcessesDisabled:]): Displayed an alert informing the user that MiniBrowser must be restarted for the setting to take effect.
2389         (-[SettingsController perWindowWebProcessesDisabled]): Returned the value from user defaults.
2390
2391 2015-02-24  Alexey Proskuryakov  <ap@apple.com>
2392
2393         Bot watcher's dashboard sometimes hits an assertion: data.num_missing === this.layoutTestResults.testsWithMissingResults.length
2394         https://bugs.webkit.org/show_bug.cgi?id=141889
2395
2396         Reviewed by Darin Adler.
2397
2398         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2399
2400 2015-02-24  Yusuke Suzuki  <utatane.tea@gmail.com>
2401
2402         REGRESSION(r179429): Can't type comments in Facebook
2403         https://bugs.webkit.org/show_bug.cgi?id=141859
2404
2405         Reviewed by Brent Fulgham.
2406
2407         Drop javaScriptExperimentsEnabled and specify JavaScriptRuntimeFlagsAllEnabled as KJavaScriptRuntimeFlags.
2408
2409         * DumpRenderTree/mac/DumpRenderTree.mm:
2410         (resetWebPreferencesToConsistentValues):
2411         * DumpRenderTree/win/DumpRenderTree.cpp:
2412         (resetWebPreferencesToConsistentValues):
2413         * WebKitTestRunner/TestController.cpp:
2414         (WTR::TestController::resetPreferencesToConsistentValues):
2415
2416 2015-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
2417
2418         Crash loading local file with WebPageProxy::loadAlternateHTMLString
2419         https://bugs.webkit.org/show_bug.cgi?id=141867
2420
2421         Reviewed by Anders Carlsson.
2422
2423         * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
2424         (TestWebKitAPI::loadAlternateHTMLString): Split most of this test into a function so it can
2425         be shared with the new test.
2426         (TestWebKitAPI::TEST): Add a cross-platform test for this crash.
2427         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp: Add a GTK+ test for this crash.
2428         (testLoadAlternateHTMLForLocalPage):
2429         (beforeAll):
2430
2431 2015-02-24  David Kilzer  <ddkilzer@apple.com>
2432
2433         [iOS] Implement WTR::activateFonts() to fix missing fonts in WebKit2 test runs
2434         <http://webkit.org/b/141900>
2435
2436         Reviewed by Myles C. Maxfield.
2437
2438         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
2439         (OTHER_LDFLAGS_BASE): Link to CoreText.framework.
2440         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm: Rename from Tools/WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm.
2441         - Rename to share code with iOS.
2442         - Add USE(APPKIT) around AppKit-specific headers and code.
2443         - Fix a check-webkit-style warning.
2444         * WebKitTestRunner/InjectedBundle/ios/ActivateFontsIOS.mm: Remove.
2445         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2446         - Rename mac/ActivateFonts.mm to cocoa/ActivateFontsCocoa.mm.
2447         - Remove ios/ActivateFontsIOS.mm.
2448         - Fix InjectedBundle/cocoa group to represent the directory on
2449           disk.  Includes a change to InjectedBundlePageCocoa.mm.
2450
2451 2015-02-23  Commit Queue  <commit-queue@webkit.org>
2452
2453         Unreviewed, rolling out r180547 and r180550.
2454         https://bugs.webkit.org/show_bug.cgi?id=141957
2455
2456         Broke 10 Windows tests. (Requested by bfulgham_ on #webkit).
2457
2458         Reverted changesets:
2459
2460         "REGRESSION(r179429): Can't type comments in Facebook"
2461         https://bugs.webkit.org/show_bug.cgi?id=141859
2462         http://trac.webkit.org/changeset/180547
2463
2464         "Constructor returning null should construct an object instead
2465         of null"
2466         https://bugs.webkit.org/show_bug.cgi?id=141640
2467         http://trac.webkit.org/changeset/180550
2468
2469 2015-02-23  Yusuke Suzuki  <utatane.tea@gmail.com>
2470
2471         REGRESSION(r179429): Can't type comments in Facebook
2472         https://bugs.webkit.org/show_bug.cgi?id=141859
2473
2474         Reviewed by Geoffrey Garen.
2475
2476         Drop javaScriptExperimentsEnabled and specify JavaScriptRuntimeFlagsAllEnabled as KJavaScriptRuntimeFlags.
2477
2478         * DumpRenderTree/mac/DumpRenderTree.mm:
2479         (resetWebPreferencesToConsistentValues):
2480         * WebKitTestRunner/TestController.cpp:
2481         (WTR::TestController::resetPreferencesToConsistentValues):
2482
2483 2015-02-23  KwangHyuk Kim  <hyuki.kim@samsung.com>
2484
2485         [EFL] fix eo errors
2486         https://bugs.webkit.org/show_bug.cgi?id=141909
2487
2488         Reviewed by Gyuyoung Kim.
2489
2490         Fix eo errors that occur whenever minibrowser is launched.
2491         - elm_obj_entry_text_style_user_push can only be applied for elm_entry
2492         - elm_obj_win_resize_object_add's first parameter should be elm_win
2493
2494         * MiniBrowser/efl/main.c:
2495         (window_create):
2496
2497 2015-02-23  Ryosuke Niwa  <rniwa@webkit.org>
2498
2499         Unreviewed build fix after r180535. Removed the test case that wasn't compiling.
2500
2501         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
2502         (TestWebKitAPI::TEST):
2503
2504 2015-02-23  Brent Fulgham  <bfulgham@apple.com>
2505
2506         WTF::WeakPtr should rename 'forgot' to 'clear' and support nullptr assignment
2507         https://bugs.webkit.org/show_bug.cgi?id=141935
2508
2509         Reviewed by Myles C. Maxfield.
2510
2511         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
2512         (TestWebKitAPI::TEST): Updated for 'clear' method rename, and added a few
2513         tests for assigning from nullptr.
2514
2515 2015-02-23  Brent Fulgham  <bfulgham@apple.com>
2516
2517         WTF::WeakPtr should have a 'forget' method.
2518         https://bugs.webkit.org/show_bug.cgi?id=141923
2519
2520         Reviewed by Myles C. Maxfield.
2521
2522         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
2523         (TestWebKitAPI::TEST): Added 'Forget' tests case.
2524
2525 2015-02-23  Alexey Proskuryakov  <ap@apple.com>
2526
2527         build.webkit.org/dashboard CrashOnly queues should not show two green bubbles
2528         https://bugs.webkit.org/show_bug.cgi?id=141920
2529
2530         Reviewed by Tim Horton.
2531
2532         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2533         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
2534         Do the same thing as we do for regular green bubbles.
2535
2536 2015-02-23  Alexey Proskuryakov  <ap@apple.com>
2537
2538         Bot watcher's dashboard doesn't show a popover for commit history when all commits were to another branch
2539         https://bugs.webkit.org/show_bug.cgi?id=141925
2540
2541         Reviewed by Tim Horton.
2542
2543         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2544         (BuildbotQueueView.prototype._presentPopoverForRevisionRange):
2545
2546 2015-02-23  Anders Carlsson  <andersca@apple.com>
2547
2548         Add API for fetching website data records to _WKWebsiteDataStore
2549         https://bugs.webkit.org/show_bug.cgi?id=141926
2550
2551         Reviewed by Beth Dakin.
2552
2553         * MiniBrowser/mac/MainMenu.xib:
2554         * MiniBrowser/mac/WK2BrowserWindowController.m:
2555         (-[WK2BrowserWindowController fetchWebsiteData:]):
2556         Add menu item to fetch and dump website data.
2557
2558 2015-02-23  David Kilzer  <ddkilzer@apple.com>
2559
2560         [iOS] run-webkit-tests --leaks is broken because IOSSimulatorPort has no is_snowleopard attribute
2561         <http://webkit.org/b/141884>
2562
2563         Reviewed by Alexey Proskuryakov.
2564
2565         * Scripts/webkitpy/port/leakdetector.py:
2566         (LeakDetector._callstacks_to_exclude_from_leaks): Remove
2567         snowleopard, lion and older leaks.  Add known leak for
2568         mavericks, but check Port.operating_system before calling
2569         Port.is_mavericks.
2570         * Scripts/webkitpy/port/mac.py:
2571         (MacPort.is_snowleopard): Delete.
2572         (MacPort.is_lion): Delete.
2573         (MacPort.is_mavericks): Add.
2574
2575 2015-02-23  Alexey Proskuryakov  <ap@apple.com>
2576
2577         build.webkit.org/dashboard should filter out commits to other branches
2578         https://bugs.webkit.org/show_bug.cgi?id=140362
2579
2580         Reviewed by Tim Horton.
2581
2582         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2583         (BuildbotQueue):
2584         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2585         (BuildbotQueueView.prototype._presentPopoverForPendingCommits):
2586         (BuildbotQueueView.prototype._presentPopoverForRevisionRange):
2587         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration):
2588         (BuildbotQueueView.prototype.revisionContentForIteration):
2589         (BuildbotQueueView.prototype._appendPendingRevisionCount): Deleted.
2590         (BuildbotQueueView.prototype._popoverLinesForCommitRange): Deleted.
2591         (BuildbotQueueView.prototype._revisionPopoverContentForIteration): Deleted.
2592         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
2593         (Trac.prototype.get oldestRecordedRevisionNumber):
2594         (Trac.prototype.commitsOnBranch):
2595         (Trac.prototype._xmlTimelineURL):
2596         (Trac.prototype._convertCommitInfoElementToObject):
2597         (Trac.prototype._update):
2598         (Trac.prototype.startPeriodicUpdates):
2599         (Trac.prototype.loadMoreHistoricalData):
2600         (Trac.prototype.update): Deleted.
2601
2602 2015-02-21  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2603
2604         Tests don't work on some bots: Failed to stop wptwk
2605         https://bugs.webkit.org/show_bug.cgi?id=141235
2606
2607         Reviewed by Ryosuke Niwa.
2608
2609         Logging of server subprocesses in launcher script.
2610         Killing of server subprocesses when stopping/before starting.
2611         Removed empty __init.py__ file creation as importer now ensures these files cannot be empty anymore.
2612
2613         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
2614         (main): Removed empty __init.py__ file creation as importer now ensures these files cannot be empty anymore. Added logging in a file of server subprocesses to clean them in case of abnormal shutdown. 
2615         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2616         (WebPlatformTestServer.__init__):
2617         (WebPlatformTestServer._stop_running_subservers): Kill server subprocesses based on file created by wpt launcher.
2618         (WebPlatformTestServer):
2619         (WebPlatformTestServer.stop): Overriden to ensure killing subprocesses in case of orphaned process.
2620         (WebPlatformTestServer._stop_running_server): Killing of wpt launcher process after regular shutdown. 
2621         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
2622         (TestWebPlatformTestServer.test_server_closes_previously_spawned_instance): Reworked the test to call start/stop with an existing pid file.
2623         (TestWebPlatformTestServer.test_import_web_platform_test_modules): No change.
2624         (TestWebPlatformTestServer):
2625         (TestWebPlatformTestServer.test_corrupted_subserver_files): Checked that server subprocess cleaning does not throw in case of bad server pid file.
2626
2627 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
2628
2629         [WebEditingTester] Allow dropping HTML files on the app
2630         https://bugs.webkit.org/show_bug.cgi?id=141834
2631
2632         Reviewed by Simon Fraser.
2633
2634         * WebEditingTester/AppDelegate.m:
2635         (-[WebEditingAppDelegate openDocument:]):
2636         (-[WebEditingAppDelegate application:openFile:]):
2637         Implement application:openFile:, factoring file loading code out of openDocument.
2638
2639         * WebEditingTester/Info.plist:
2640         Register as an editor for HTML files.
2641
2642         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
2643         Enrica is not an organization.
2644
2645 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
2646
2647         [WebEditingTester] Expand "WK" to "WebKit" in a few places
2648         https://bugs.webkit.org/show_bug.cgi?id=141833
2649
2650         Reviewed by Anders Carlsson.
2651
2652         * WebEditingTester/AppDelegate.h:
2653         * WebEditingTester/AppDelegate.m:
2654         (-[WebEditingAppDelegate newEditor:]):
2655         (-[WebEditingAppDelegate toggleUseWebKit2ByDefault:]):
2656         (-[WebEditingAppDelegate validateMenuItem:]):
2657         (-[WebEditingAppDelegate _updateNewWindowKeyEquivalents]):
2658         (-[WebEditingAppDelegate applicationDidFinishLaunching:]): Deleted.
2659         (-[WebEditingAppDelegate applicationWillTerminate:]): Deleted.
2660         (-[WebEditingAppDelegate showOperations:]): Deleted.
2661         * WebEditingTester/MainMenu.xib:
2662         The WK abbreviation is unnaturally grating in menu items for some reason.
2663
2664 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
2665
2666         [WebEditingTester] Add a custom protocol for loading canned content
2667         https://bugs.webkit.org/show_bug.cgi?id=141830
2668
2669         Reviewed by Enrica Casucci.
2670
2671         Add a canned:// protocol handler, which can be used to emulate behaviors
2672         in WebKit client apps (like Mail) that use custom protocol handlers,
2673         which can have important effects on editing (mostly, the URLs are only
2674         valid inside of the client application, but not when copied/dragged out).
2675
2676         For now, we only support two canned files:
2677
2678             canned://dice is a PNG of dice (stolen from LayoutTests/)
2679             canned://text is the string "canned text" served as text/html
2680
2681         In the future we could support things like very large (generated) files,
2682         progressive loading, etc. to further simulate conditions in other apps.
2683
2684         * WebEditingTester/AppDelegate.m:
2685         (-[WebEditingAppDelegate applicationDidFinishLaunching:]):
2686         Register the protocol with CFNetwork, and the scheme with WebKit2.
2687
2688         * WebEditingTester/Canned Content/dice.png: Added.
2689         * WebEditingTester/CannedContent.h: Added.
2690         * WebEditingTester/CannedContent.m: Added.
2691         (-[CannedContent initWithRequest:cachedResponse:client:]):
2692         (+[CannedContent canonicalRequestForRequest:]):
2693         (+[CannedContent canInitWithRequest:]):
2694         We only want to handle canned:// URLs.
2695
2696         (-[CannedContent startLoading]):
2697         For now, immediately load the two files we know about.
2698         Otherwise, immediately fail the load.
2699
2700         (-[CannedContent stopLoading]):
2701         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
2702
2703 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
2704
2705         [WebEditingTester] Implement an open panel
2706         https://bugs.webkit.org/show_bug.cgi?id=141829
2707
2708         Reviewed by Simon Fraser.
2709
2710         * WebEditingTester/AppDelegate.m:
2711         (-[WebEditingAppDelegate _useWebKit1ForOpeningDocument:]):
2712         (-[WebEditingAppDelegate _useWebKit2ForOpeningDocument:]):
2713         (-[WebEditingAppDelegate openDocument:]):
2714         Add an open panel (with radio buttons to pick which WebKit to open with).
2715         Loads the file as an HTML string.
2716
2717 2015-02-20  Simon Fraser  <simon.fraser@apple.com>
2718
2719         [WebEditingTester] @properties, dot syntax, and remember the window position
2720         https://bugs.webkit.org/show_bug.cgi?id=141843
2721
2722         Reviewed by Tim Horton.
2723         
2724         Modernize a bit with more dot syntax, use @property for the web views,
2725         and give the main window an Autosave name so it remembers the widow position.
2726
2727         * WebEditingTester/WK1WebDocumentController.m:
2728         (-[WK1WebDocumentController awakeFromNib]):
2729         (-[WK1WebDocumentController loadHTMLString:]):
2730         * WebEditingTester/WK2WebDocumentController.m:
2731         (-[WK2WebDocumentController awakeFromNib]):
2732         * WebEditingTester/WebDocument.xib:
2733
2734 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
2735
2736         [WebEditingTester] Hook up key equivalents for new window action
2737         https://bugs.webkit.org/show_bug.cgi?id=141828
2738
2739         Reviewed by Enrica Casucci.
2740
2741         * WebEditingTester/AppDelegate.h:
2742         * WebEditingTester/AppDelegate.m:
2743         (-[WebEditingAppDelegate applicationDidFinishLaunching:]):
2744         (-[WebEditingAppDelegate newEditor:]):
2745         (-[WebEditingAppDelegate _defaultWebDocumentControllerClass]):
2746         (-[WebEditingAppDelegate toggleUseWK2ByDefault:]):
2747         (-[WebEditingAppDelegate _updateNewWindowKeyEquivalents]):
2748         (defaultConfiguration): Deleted.
2749         (-[WebEditingAppDelegate applicationWillTerminate:]): Deleted.
2750         Move WKWebViewConfiguration setup into WK2WebDocumentController.
2751         Remove unused application termination code.
2752         Update new-window menu item key equivalents when launching and when
2753         changing the use-WebKit2-by-default setting.
2754         Make WebDocumentController subclasses all initialized the same way,
2755         and use that to factor out alloc/init.
2756         Rename loadContent to loadHTMLString for future use.
2757
2758         * WebEditingTester/MainMenu.xib:
2759         Add default key equivalents.
2760         Cmd-N will always make the default kind of window (controlled by the pref).
2761         Cmd-Opt-N will always make the other kind.
2762         The menu items are configured as alternates so they only show up if you
2763         press alt (just like in MiniBrowser).
2764
2765         * WebEditingTester/WK1WebDocumentController.m:
2766         (-[WK1WebDocumentController loadHTMLString:]):
2767         (-[WK1WebDocumentController loadContent]): Deleted.
2768         * WebEditingTester/WK2WebDocumentController.h:
2769         * WebEditingTester/WK2WebDocumentController.m:
2770         (defaultConfiguration):
2771         (-[WK2WebDocumentController awakeFromNib]):
2772         (-[WK2WebDocumentController loadHTMLString:]):
2773         (-[WK2WebDocumentController initWithConfiguration:]): Deleted.
2774         (-[WK2WebDocumentController dealloc]): Deleted.
2775         * WebEditingTester/WebDocumentController.h:
2776         * WebEditingTester/WebDocumentController.m:
2777         (-[WebDocumentController init]):
2778         (-[WebDocumentController initWithWindow:]):
2779         (+[WebDocumentController defaultEditingSource]):
2780         (-[WebDocumentController loadHTMLString:]):
2781         (-[WebDocumentController windowDidLoad]): Deleted.
2782         (-[WebDocumentController defaultEditingSource]): Deleted.
2783         (-[WebDocumentController applicationTerminating]): Deleted.
2784         (-[WebDocumentController loadContent]): Deleted.
2785
2786 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
2787
2788         [WebEditingTester] ARC-ify WebEditingTester
2789         https://bugs.webkit.org/show_bug.cgi?id=141827
2790
2791         Reviewed by Sam Weinig.
2792
2793         * WebEditingTester/AppDelegate.m:
2794         (-[WebEditingAppDelegate showOperations:]):
2795         * WebEditingTester/EditingOperations.m:
2796         (editingOperations):
2797         * WebEditingTester/WK1WebDocumentController.m:
2798         (-[WK1WebDocumentController dealloc]): Deleted.
2799         * WebEditingTester/WK2WebDocumentController.m:
2800         (-[WK2WebDocumentController dealloc]): Deleted.
2801         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
2802         Turn on ARC and remove a few retain/release/autorelease calls.
2803         We don't need to implement dealloc in either document controller
2804         because WebView and WKWebView's UIDelegate property does not hold a
2805         strong reference.
2806
2807 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
2808
2809         [WebEditingTester] Factor out list of editing operations
2810         https://bugs.webkit.org/show_bug.cgi?id=141826
2811
2812         Reviewed by Sam Weinig.
2813
2814         * WebEditingTester/AppDelegate.m:
2815         (-[WebEditingAppDelegate showOperations:]):
2816         * WebEditingTester/EditingOperations.h: Added.
2817         * WebEditingTester/EditingOperations.m: Added.
2818         (editingOperations):
2819         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
2820         Move EditingOperations array to its own file, and make it an NSArray
2821         instead of a C array. Adjust accordingly in showOperations:.
2822
2823 2015-02-20  Michael Saboff  <msaboff@apple.com>
2824
2825         DFG JIT needs to check for stack overflow at the start of Program and Eval execution
2826         https://bugs.webkit.org/show_bug.cgi?id=141676
2827
2828         Reviewed by Filip Pizlo.
2829
2830         Set the newly added --maximumEvalCacheableSourceLength option for eager test runs.  This is needed
2831         to allow the eval out of stack tests to tier up.  Without this option, we don't cache the likely
2832         large string expression that we want to eval.
2833
2834         * Scripts/run-jsc-stress-tests:
2835
2836 2015-02-19  Daniel Bates  <dabates@apple.com>
2837
2838         REGRESSION (r180239): run-webkit-test fails to boot simulator device that was booted by previous test run
2839         https://bugs.webkit.org/show_bug.cgi?id=141815
2840         <rdar://problem/19893933>
2841
2842         Reviewed by Simon Fraser.
2843
2844         Fixes an issue where run-webkit-tests would fail to boot the WebKit Tester simulator device if it
2845         was booted by iOS Simulator in a previous run of run-webkit-test.
2846
2847         * Scripts/webkitpy/port/ios.py:
2848         (IOSSimulatorPort.check_sys_deps): Added logic moved from IOSSimulatorPort.setup_test_run().
2849         (IOSSimulatorPort.setup_test_run): Moved logic to quit the iOS Simulator app and wait for the
2850         testing device to be in the shutdown state from here to IOSSimulatorPort.check_sys_deps().
2851
2852 2015-02-19  David Kilzer  <ddkilzer@apple.com>
2853
2854         check-webkit-style: do not warn about missing primary header for *SoftLink.cpp files
2855         <http://webkit.org/b/141799>
2856
2857         Reviewed by Alex Christensen.
2858
2859         * Scripts/webkitpy/style/checkers/cpp.py:
2860         (_IncludeState.check_next_include_order): Don't emit a warning
2861         if the primary header exists and the source file name ends with
2862         "SoftLink.cpp".  Add 'filename' argument to method.
2863         (check_include_line): Pass in 'filename'.
2864
2865         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2866         (OrderOfIncludesTest.test_check_next_include_order__no_config):
2867         (OrderOfIncludesTest.test_check_next_include_order__no_self):
2868         (OrderOfIncludesTest.test_check_next_include_order__likely_then_config):
2869         (OrderOfIncludesTest.test_check_next_include_order__other_then_config):
2870         (OrderOfIncludesTest.test_check_next_include_order__config_then_other_then_likely):
2871         - Add test filename arguments for calls to
2872           check_next_include_order().
2873         (OrderOfIncludesTest.test_primary_header): Add test for a file
2874         name ending in "SoftLink.cpp".
2875
2876 2015-02-18  Enrica Casucci  <enrica@apple.com>
2877
2878         Add new tool to test editable Webviews.
2879         https://bugs.webkit.org/show_bug.cgi?id=141772
2880
2881         Reviewed by Tim Horton.
2882
2883         Adding WebEditingTester, a Cocoa application to
2884         test WK1 and Wk2 views in editable mode.
2885
2886         * WebEditingTester: Added.
2887         * WebEditingTester/AppDelegate.h: Added.
2888         * WebEditingTester/AppDelegate.m: Added.
2889         (-[WebEditingAppDelegate init]):
2890         (defaultConfiguration):
2891         (-[WebEditingAppDelegate applicationDidFinishLaunching:]):
2892         (-[WebEditingAppDelegate applicationWillTerminate:]):
2893         (-[WebEditingAppDelegate newEditor:]):
2894         (-[WebEditingAppDelegate showOperations:]):
2895         (-[WebEditingAppDelegate useWebKit2ByDefault]):
2896         (-[WebEditingAppDelegate toggleUseWK2ByDefault:]):
2897         (-[WebEditingAppDelegate validateMenuItem:]):
2898         * WebEditingTester/Info.plist: Added.
2899         * WebEditingTester/MainMenu.xib: Added.
2900         * WebEditingTester/WK1WebDocumentController.h: Added.
2901         * WebEditingTester/WK1WebDocumentController.m: Added.
2902         (-[WK1WebDocumentController awakeFromNib]):
2903         (-[WK1WebDocumentController loadContent]):
2904         (-[WK1WebDocumentController dealloc]):
2905         (-[WK1WebDocumentController pasteAsMarkup:]):
2906         * WebEditingTester/WK2WebDocumentController.h: Added.
2907         * WebEditingTester/WK2WebDocumentController.m: Added.
2908         (-[WK2WebDocumentController initWithConfiguration:]):
2909         (-[WK2WebDocumentController pasteAsMarkup:]):
2910         (-[WK2WebDocumentController awakeFromNib]):
2911         (-[WK2WebDocumentController dealloc]):
2912         (-[WK2WebDocumentController loadContent]):
2913         * WebEditingTester/WebDocument.xib: Added.
2914         * WebEditingTester/WebDocumentController.h: Added.
2915         * WebEditingTester/WebDocumentController.m: Added.
2916         (-[WebDocumentController initWithWindow:]):
2917         (-[WebDocumentController windowDidLoad]):
2918         (-[WebDocumentController defaultEditingSource]):
2919         (-[WebDocumentController applicationTerminating]):
2920         (-[WebDocumentController loadContent]):
2921         * WebEditingTester/WebEditingTester.xcodeproj: Added.
2922         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj: Added.
2923         * WebEditingTester/main.m: Added.
2924         (main):
2925
2926 2015-02-18  Csaba Osztrogonác  <ossy@webkit.org>
2927
2928         Run JSC tests on ARM EFL bots
2929         https://bugs.webkit.org/show_bug.cgi?id=141165
2930
2931         Reviewed by Alexey Proskuryakov.
2932
2933         * BuildSlaveSupport/build.webkit.org-config/config.json:
2934         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2935         (RunJavaScriptCoreTests.countFailures):
2936         (RunRemoteJavaScriptCoreTests):
2937         (RunRemoteJavaScriptCoreTests.start):
2938         (BuildAndRemoteJSCTestsFactory):
2939         (BuildAndRemoteJSCTestsFactory.__init__):
2940
2941 2015-02-18  Alexey Proskuryakov  <ap@apple.com>
2942
2943         Streamline unexported function build fixes
2944         https://bugs.webkit.org/show_bug.cgi?id=141761
2945
2946         Reviewed by Alex Christensen.
2947
2948         * Scripts/check-for-weak-vtables-and-externals: (readXcode5SymbolsToIgnore): Deleted.
2949         We don't need to ignore symbols that are not exported due to the .unexp file.
2950
2951 2015-02-18  Timothy Horton  <timothy_horton@apple.com>
2952
2953         Remove more references to WebCore.exp.in
2954         https://bugs.webkit.org/show_bug.cgi?id=141747
2955
2956         Reviewed by Alexey Proskuryakov.
2957
2958         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
2959         (ShouldBuildTest):
2960
2961 2015-02-17  Myles C. Maxfield  <mmaxfield@apple.com>
2962
2963         Windows test results should not fall back to mac-mountainlion after r180176
2964         https://bugs.webkit.org/show_bug.cgi?id=141719
2965
2966         Reviewed by Brent Fulgham.
2967
2968         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
2969         (_should_file_trigger_build):
2970         * Scripts/webkitpy/port/win.py:
2971         (WinPort.default_baseline_search_path):
2972         * Scripts/webkitpy/port/win_unittest.py:
2973         (WinPortTest.test_baseline_search_path):
2974
2975 2015-02-17  Daniel Bates  <dabates@apple.com>
2976
2977         [iOS] run-webkit-tests should check that simctl can boot and shutdown simulator device before running tests
2978         https://bugs.webkit.org/show_bug.cgi?id=141718
2979
2980         Reviewed by Alex Christensen.
2981
2982         We should only run layout tests if simctl can successfully boot and shutdown the testing device.
2983
2984         * Scripts/webkitpy/port/ios.py:
2985         (IOSSimulatorPort.check_sys_deps): Modified to call Simulator.check_simulator_device_and_erase_if_needed().
2986         Log a error and return False if we are unable to boot the simulator device so that the caller can take
2987         appropriate action, say exit(3) before running any layout tests.
2988         * Scripts/webkitpy/xcode/simulator.py:
2989         (Simulator._boot_and_shutdown_simulator_device): Added. Boot and then shut down the simulator device
2990         with the specified UDID.
2991         (Simulator.check_simulator_device_and_erase_if_needed): Added. Checks that simulator device
2992         with the specified UDID can successfully boot and shut down. We make at most two attempts to
2993         boot and shut down the device, erasing the device between tries so as to restore the device
2994         to a known good state.
2995
2996 2015-02-17  Daniel Bates  <dabates@apple.com>
2997
2998         run_webkit_tests.py should not know about iOS Simulator details
2999         https://bugs.webkit.org/show_bug.cgi?id=141711
3000
3001         Reviewed by Alex Christensen.
3002
3003         Run_webkit_tests.py should only parse the iOS-specific command
3004         line options --runtime and --device-type. Let the port-specific
3005         logic in ios.py validate the parsed options and instantiate
3006         internal data structures.
3007
3008         Currently run_webkit_tests.py parses the iOS-specific command
3009         line options --runtime and --device-type, validates them, and
3010         instantiates internal data structures from the parsed strings.
3011         Instead the validation logic and instantiation of internal
3012         data structures should be handled by the iOS port object.
3013
3014         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3015         (_set_up_derived_options): Remove logic to validate --runtime and --device-type
3016         and instantiate internal data structures for them.
3017         * Scripts/webkitpy/port/driver.py:
3018         (IOSSimulatorDriver.cmd_line): Modified to reference IOSSimulatorPort.simulator_runtime
3019         and IOSSimulatorPort.simulator_device_type for the iOS Simulator runtime and device type,
3020         respectively.
3021         * Scripts/webkitpy/port/ios.py: Sort the list of imports.
3022         (IOSSimulatorPort.simulator_runtime): Added. Instantiates a Runtime
3023         object from --runtime, if specified. Otherwise, instantiates a Runtime
3024         object for the latest installed iphonesimulator SDK version.
3025         (IOSSimulatorPort.simulator_device_type): Added. Instantiates a DeviceType
3026         object from --device-type, if specified. Otherwise, instantiates
3027         a DeviceType object for a iPhone 5 or iPhone 5s when on a 32-bit and 64-bit
3028         machine, respectively.
3029         (IOSSimulatorPort.check_sys_deps): Added. Validate if the chosen iOS simulator
3030         runtime is available to use.
3031         (IOSSimulatorPort.testing_device): Modified to make use of properties simulator_device_type
3032         and simulator_runtime for the iOS Simulator device type and runtime, respectively.
3033         * Scripts/webkitpy/xcode/simulator.py:
3034         (Runtime.from_version_string): Added. Turns around and calls Runtime.from_identifier()
3035         with a runtime identifier for the specified iOS version.
3036
3037 2015-02-17  Dana Burkart  <dburkart@apple.com>
3038
3039         ASan does not like JSC::MachineThreads::tryCopyOtherThreadStack
3040         https://bugs.webkit.org/show_bug.cgi?id=141672
3041
3042         Reviewed by David Kilzer.
3043
3044         * asan/webkit-asan-ignore.txt:
3045
3046 2015-02-17  Alex Christensen  <achristensen@webkit.org>
3047
3048         Remove WebCore.exp.in and clean up.
3049         https://bugs.webkit.org/show_bug.cgi?id=141491
3050
3051         Reviewed by Andreas Kling.
3052
3053         * Scripts/sort-export-file: Removed.
3054         * Scripts/webkitpy/style/checker.py:
3055         (_all_categories):
3056         (FileType):
3057         (CheckerDispatcher._file_type):
3058         (CheckerDispatcher._create_checker):
3059         Don't check if the export files are sorted.
3060         * Scripts/webkitpy/style/checkers/exportfile.py: Removed.
3061         * Scripts/webkitpy/style/checkers/exportfile_unittest.py: Removed.
3062
3063 2015-02-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3064
3065         Unreviewed. Fix GTK+ make distcheck.
3066
3067         Do not exclude bmalloc directory from the tarball.
3068
3069         * gtk/manifest.txt.in:
3070
3071 2015-02-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3072
3073         Unreviewed. Fix /webkit2/WebKitDOMNode/dom-cache after r180214.
3074
3075         I forgot to add the return of a bool function.
3076
3077         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
3078         (WebKitDOMNodeTest::testDOMCache):
3079
3080 2015-02-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3081
3082         [GTK] GObject DOM bindings object are cached forever
3083         https://bugs.webkit.org/show_bug.cgi?id=141558
3084
3085         Reviewed by Sergio Villar Senin.
3086
3087         Add checks for all DOM objects to ensure they are not leaked. Also
3088         add a dedicated test for the DOM Object Cache.
3089
3090         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp:
3091         (WebKitDOMNodeFilterTest::testTreeWalker):
3092         (WebKitDOMNodeFilterTest::testNodeIterator):
3093         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
3094         (WebKitDOMNodeTest::testHierarchyNavigation):
3095         (WebKitDOMNodeTest::testInsertion):
3096         (WebKitDOMNodeTest::testTagNames):
3097         (WebKitDOMNodeTest::testDOMCache):
3098         (registerTests):
3099         * TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp:
3100         (WebKitDOMXPathNSResolverTest::evaluateFooChildTextAndCheckResult):
3101         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
3102         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
3103         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
3104         (testWebKitDOMObjectCache):
3105         (beforeAll):
3106         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
3107         (documentLoadedCallback):
3108
3109 2015-02-16  Carlos Garcia Campos  <cgarcia@igalia.com>
3110
3111         [GTK] WebKitFrame objects are never released
3112         https://bugs.webkit.org/show_bug.cgi?id=141641
3113
3114         Reviewed by Martin Robinson.
3115
3116         Add a way to check GObjects leaks for WebProcess tests and check
3117         WebKitFrame objects are not leaked.
3118
3119         * TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp:
3120         (WebKitFrameTest::testMainFrame):
3121         (WebKitFrameTest::testURI):
3122         (WebKitFrameTest::testJavaScriptContext):
3123         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
3124         (WebProcessTest::assertObjectIsDeletedWhenTestFinishes):
3125         (runTest):
3126         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
3127
3128 2015-02-16  Tim Horton  <timothy_horton@apple.com>
3129
3130         Fix the MiniBrowser build with newer clang
3131
3132         * MiniBrowser/mac/SettingsController.m:
3133         (-[SettingsController _toggleBooleanDefault:]):
3134         * MiniBrowser/mac/WK1BrowserWindowController.m:
3135         (-[WK1BrowserWindowController windowWillClose:]):
3136         * MiniBrowser/mac/WK2BrowserWindowController.m:
3137         (-[WK2BrowserWindowController windowWillClose:]):
3138         NSApp is id and clang gets confused about which -delegate we're talking about.
3139
3140 2015-02-16  Antti Koivisto  <antti@apple.com>
3141
3142         Develop/Disable Caches does not properly disable disk cache
3143         https://bugs.webkit.org/show_bug.cgi?id=141636
3144
3145         Reviewed by Anders Carlsson.
3146
3147         Make testRunner.setCacheModel() use the WKContext interface so the model gets passed to
3148         the network process too.
3149
3150         This makes setCacheModel asynchronous but there don't seem to be any tests that expect otherwise.
3151
3152         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3153         (WTR::InjectedBundle::beginTesting):
3154         (WTR::InjectedBundle::setCacheModel):
3155         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3156         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3157
3158             Forward to TestController.
3159
3160         (WTR::TestRunner::setCacheModel):
3161         * WebKitTestRunner/TestInvocation.cpp:
3162         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3163
3164 2015-02-16  Andrzej Badowski  <a.badowski@samsung.com>
3165
3166         Unreviewed. Add myself as a committer.
3167
3168         * Scripts/webkitpy/common/config/contributors.json:
3169
3170 2015-02-15  David Kilzer  <ddkilzer@apple.com>
3171
3172         REGRESSION (r180082): WebCore Debug builds fail on Mavericks due to weak export symbols
3173         <http://webkit.org/b/141607>
3174
3175         * Scripts/check-for-weak-vtables-and-externals: Ignore weak
3176         externals in Source/WebCore/Configurations/WebCore.unexp when
3177         building with Xcode 5.x.
3178         (readXcode5SymbolsToIgnore): Add.
3179
3180 2015-02-15  KwangHyuk Kim  <hyuki.kim@samsung.com>
3181
3182         [EFL] fix Evas GL engine error.
3183         https://bugs.webkit.org/show_bug.cgi?id=141621
3184
3185         Reviewed by Gyuyoung Kim.
3186
3187         As new elm engine api was added from efl 1.10, replace elm_config_preferred_engine_set with elm_config_accel_preference_set.
3188
3189         * MiniBrowser/efl/main.c:
3190         (elm_main):
3191
3192 2015-02-14  Csaba Osztrogonác  <ossy@webkit.org>
3193
3194         [buildbot] Enable run-api-tests on release Mac bots
3195         https://bugs.webkit.org/show_bug.cgi?id=141518
3196
3197         Reviewed by Darin Adler.
3198
3199         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3200         (RunUnitTests):
3201         (BuildFactory.__init__):
3202         (TestFactory.__init__):
3203         (BuildAndTestFactory.__init__):
3204         (RunUnitTests.start): Deleted.
3205         (unitTestsSupported): Deleted.
3206
3207 2015-02-13  Anders Carlsson  <andersca@apple.com>
3208
3209         Add a move constructor and move assignment operator to Deque
3210         https://bugs.webkit.org/show_bug.cgi?id=141571
3211
3212         Reviewed by Andreas Kling.
3213
3214         * TestWebKitAPI/Tests/WTF/Deque.cpp:
3215         (TestWebKitAPI::TEST):
3216
3217 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
3218
3219         run-jsc-stress-tests --remote should skip profiler tests
3220         https://bugs.webkit.org/show_bug.cgi?id=141470
3221
3222         Reviewed by Filip Pizlo.
3223
3224         * Scripts/run-jsc-stress-tests:
3225
3226 2015-02-13  Anders Carlsson  <andersca@apple.com>
3227
3228         Add an initializer list constructor to Deque
3229         https://bugs.webkit.org/show_bug.cgi?id=141565
3230
3231         Reviewed by Andreas Kling.
3232
3233         * TestWebKitAPI/Tests/WTF/Deque.cpp:
3234         (TestWebKitAPI::TEST):
3235
3236 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
3237
3238         [buildbot] Remove buildJSCTool cruft from master.cfg
3239         https://bugs.webkit.org/show_bug.cgi?id=141513
3240
3241         Reviewed by Alexey Proskuryakov.
3242
3243         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3244         (RunJavaScriptCoreTests):
3245         (RunJavaScriptCoreTests.start):
3246         (RunWebKitTests):
3247         (RunWebKitTests.start):
3248         (TestFactory.__init__):
3249         (TestLeaksFactory.__init__):
3250         (RunJavaScriptCoreTests.__init__): Deleted.
3251         (RunWebKitTests.__init__): Deleted.
3252
3253 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
3254
3255         Unreviewed, remove empty directories.
3256
3257         * DumpRenderTree/gtk: Removed.
3258         * DumpRenderTree/gtk/fonts: Removed.
3259         * DumpRenderTree/unix: Removed.
3260         * DumpRenderTree/unix/TestNetscapePlugin: Removed.
3261         * GtkLauncher: Removed.
3262         * TestWebKitAPI/Tests/WebKitGtk: Removed.
3263         * TestWebKitAPI/Tests/WebKitGtk/resources: Removed.
3264         * WebKitTestRunner/WebKitTestRunnerAppTests: Removed.
3265         * WebKitTestRunner/WebKitTestRunnerAppTests/en.lproj: Removed.
3266
3267 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
3268
3269         Remove Windows cruft from Tools/Scripts/build-webkittestrunner
3270         https://bugs.webkit.org/show_bug.cgi?id=141519
3271
3272         Reviewed by Alexey Proskuryakov.
3273
3274         * Scripts/build-webkittestrunner:
3275
3276 2015-02-12  Alex Christensen  <achristensen@webkit.org>
3277
3278         Removed empty directory.
3279
3280         * WinCELauncher: Removed.
3281
3282 2015-02-12  Csaba Osztrogonác  <ossy@webkit.org>
3283
3284         run-jsc-stress-tests --remote should be able add the necessary libraries to the bundle on Linux
3285         https://bugs.webkit.org/show_bug.cgi?id=141202
3286
3287         Reviewed by Darin Adler.
3288
3289         * Scripts/run-jsc-stress-tests:
3290
3291 2015-02-12  Brent Fulgham  <bfulgham@apple.com>
3292
3293         [Win] Test bot infrastructure should not try to find/use old Safari DLLs
3294         https://bugs.webkit.org/show_bug.cgi?id=141517
3295
3296         Reviewed by Anders Carlsson.
3297
3298         We do not need to locate or use the DLL's that came with Safari, so stop
3299         failing when we cannot find them. Also remove some old Qt cruft from this
3300         script.
3301
3302         * BuildSlaveSupport/built-product-archive:
3303         (archiveBuiltProduct): 
3304         (extractBuiltProduct):
3305
3306 2015-02-11  Brent Fulgham  <bfulgham@apple.com>
3307
3308         [Win] [64-bit] Work around MSVC2013 Runtime Bug
3309         https://bugs.webkit.org/show_bug.cgi?id=141498
3310         <rdar://problem/19803642>
3311
3312         Reviewed by Anders Carlsson.
3313
3314         Disable FMA3 instruction use in the MSVC math library to
3315         work around a VS2013 runtime crash. We can remove this
3316         workaround when we switch to VS2015.
3317
3318         * DumpRenderTree/cg/ImageDiffCG.cpp: Call _set_FMA3_enable(0) to
3319         disable FMA3 support.
3320         * DumpRenderTree/win/DumpRenderTree.cpp: Ditto.
3321         * DumpRenderTree/win/ImageDiffCairo.cpp: Ditto.
3322         * DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
3323         * Scripts/webkitperl/httpd.pm: Ditto.
3324         * TestWebKitAPI/win/main.cpp: Ditto.
3325         * WinLauncher/Common.cpp: Ditto.
3326         * win/DLLLauncher/DLLLauncherMain.cpp: Ditto.
3327
3328 2015-02-12  Csaba Osztrogonác  <ossy@webkit.org>
3329
3330         run-jsc-stress-tests should accept remote host config from JSON file
3331         https://bugs.webkit.org/show_bug.cgi?id=141509
3332
3333         Reviewed by Michael Saboff.
3334
3335         * Scripts/run-javascriptcore-tests:
3336         (runJSCStressTests):
3337         * Scripts/run-jsc-stress-tests:
3338
3339 2015-02-12  Carlos Garcia Campos  <cgarcia@igalia.com>
3340
3341         [GTK] Add API to allow overriding the default color chooser implementation
3342         https://bugs.webkit.org/show_bug.cgi?id=98935
3343
3344         Reviewed by Gustavo Noronha Silva.
3345
3346         Add a color chooser implementation for MiniBrowser using
3347         GtkPopover when the GTK+ version is recent enough.
3348         And a test case to check the new color chooser API.
3349
3350         * MiniBrowser/gtk/BrowserWindow.c:
3351         (colorChooserRGBAChanged):
3352         (popoverColorClosed):
3353         (colorChooserRequestFinished):
3354         (runColorChooserCallback):
3355         (browserWindowConstructed):
3356         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
3357         (testWebViewColorChooserRequest):
3358         (beforeAll):
3359
3360 2015-02-11  Csaba Osztrogonác  <ossy@webkit.org>
3361
3362         Make run-jsc-stress-tests --remote work with make-based runner
3363         https://bugs.webkit.org/show_bug.cgi?id=141079
3364
3365         Reviewed by Darin Adler.
3366
3367         * Scripts/run-javascriptcore-tests:
3368         (runJSCStressTests): Pass through the --shell-runner and --make-runner arguments.
3369         * Scripts/run-jsc-stress-tests: Made the make-based runner the default runner,
3370         except for remote testing on Darwin. Unified runShellTestRunner and runMakeTestRunner
3371         to avoid code duplication.
3372
3373 2015-02-11  Csaba Osztrogonác  <ossy@webkit.org>
3374
3375         run-jsc-stress tests should detect the number of processors on the remote machine too
3376         https://bugs.webkit.org/show_bug.cgi?id=141196
3377
3378         Reviewed by Darin Adler.
3379
3380         * Scripts/run-javascriptcore-tests:
3381         (runJSCStressTests): Pass through the --child-processes argument.
3382         * Scripts/run-jsc-stress-tests: Added determineNumberOfProcessors function
3383         to detect the number of local and remote processors with the same algorithm.
3384         Additionally introduced $numChildProcesses to emphasize it isn't necessarily
3385         same as $numProcessors.
3386
3387 2015-02-11  Csaba Osztrogonác  <ossy@webkit.org>
3388
3389         run-jsc-stress-tests should pass JSC_timeout to remote hosts
3390         https://bugs.webkit.org/show_bug.cgi?id=141164
3391
3392         Reviewed by Darin Adler.
3393
3394         Additonally removed IMPORTANT_ENVS, since JSC_timeout was the only one.
3395
3396         * Scripts/run-jsc-stress-tests:
3397
3398 2015-02-11  Carlos Garcia Campos  <cgarcia@igalia.com>
3399
3400         [GTK] Add default color chooser implementation using GtkColorChooserDialog
3401         https://bugs.webkit.org/show_bug.cgi?id=141392
3402
3403         Reviewed by Gustavo Noronha Silva.
3404
3405         Enable INPUT_TYPE_COLOR by default for GTK+ port.
3406
3407         * Scripts/webkitperl/FeatureList.pm:
3408
3409 2015-02-09  Csaba Osztrogonác  <ossy@webkit.org>
3410
3411         run-jsc-stress-tests shell test runner should run tests in fixed order
3412         https://bugs.webkit.org/show_bug.cgi?id=141383
3413
3414         Reviewed by Darin Adler.
3415
3416         * Scripts/jsc-stress-test-helpers/shell-runner.sh:
3417
3418 2015-02-08  Chris Fleizach  <cfleizach@apple.com>
3419
3420         AX: VoiceOver appears unresponsive when JavaScript alerts are triggered via focus or blur events
3421         https://bugs.webkit.org/show_bug.cgi?id=140485
3422
3423         Reviewed by Anders Carlsson.
3424
3425         Implement takeFocus() as a way to set focus through accessibility wrappers.
3426
3427         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3428         (AccessibilityUIElement::takeFocus):
3429         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3430         (WTR::AccessibilityUIElement::takeFocus):
3431
3432 2015-02-08  Darin Adler  <darin@apple.com>
3433
3434         Remove the SVG instance tree
3435         https://bugs.webkit.org/show_bug.cgi?id=140602
3436
3437         Reviewed by Dean Jackson.
3438
3439         * Scripts/check-for-global-initializers: Removed special case for
3440         SVGElementInstance.o.
3441
3442 2015-02-07  David Kilzer  <ddkilzer@apple.com>
3443
3444         [iOS] run-webkit-tests fails due to simulator devices from previous SDK installs being marked as unavailable
3445         <http://webkit.org/b/141365>
3446
3447         Reviewed by Daniel Bates.
3448
3449         * Scripts/webkitpy/xcode/simulator.py:
3450         (Simulator): Add unavailable_version_re precompiled regex.
3451         (Simulator._parse_devices): Check for unavailable versions and
3452         ignore them if found when parsing the output of
3453         `xcrun simctl list`.
3454         * Scripts/webkitpy/xcode/simulator_unittest.py:
3455         (test_unavailable_devices): Add test with output from
3456         `xcrun simctl list` with unavailable runtimes that fails before
3457         the fix.
3458
3459 2015-02-07  Chris Dumez  <cdumez@apple.com>
3460
3461         Add Vector::removeFirstMatching() / removeAllMatching() methods taking lambda functions
3462         https://bugs.webkit.org/show_bug.cgi?id=141321
3463
3464         Reviewed by Darin Adler.
3465
3466         Use new Vector::removeFirstMatching() / removeAllMatching() methods.
3467
3468 2015-02-07  David Kilzer  <ddkilzer@apple.com>
3469
3470         [iOS] Make Simulator class testable
3471         <http://webkit.org/b/141358>
3472
3473         Rubber-stamped by Darin Adler.
3474
3475         * Scripts/webkitpy/common/system/platforminfo.py:
3476         (PlatformInfo.xcode_simctl_list): Move `xcrun simctl list`
3477         command to here from Simulator.refresh() in xcode/simulator.py
3478         so that the output of the command can be mocked.
3479
3480         * Scripts/webkitpy/common/system/platforminfo_mock.py:
3481         (MockPlatformInfo.__init__): Set self.expected_xcode_simctl_list
3482         to None.
3483         (MockPlatformInfo.xcode_simctl_list): Add method that returns
3484         self.expected_xcode_simctl_list expectation.
3485
3486         * Scripts/webkitpy/xcode/simulator.py: Add missing copyright
3487         and license header.
3488         (Simulator.__init__): Add optional 'host' parameter to make it
3489         possible to pass in a mock object for testing.  Set self._host
3490         to 'host' parameter or create Host() object.
3491         (Simulator.refresh): Call new PlatformInfo.xcode_simctl_list()
3492         method.
3493
3494         * Scripts/webkitpy/xcode/simulator_unittest.py: Add unit test
3495         for current code.
3496         (SimulatorTest):
3497         (SimulatorTest.setUp):
3498         (SimulatorTest._set_expected_xcrun_simctl_list):
3499         (SimulatorTest.test_simulator_device_types):
3500         (test_invalid_device_types_header):
3501         (test_invalid_runtimes_header):
3502         (test_invalid_devices_header):
3503
3504 2015-02-07  Csaba Osztrogonác  <ossy@webkit.org>
3505
3506         run-jsc-stress-tests --remote should use the default ssh port
3507         https://bugs.webkit.org/show_bug.cgi?id=141287
3508
3509         Reviewed by Darin Adler.
3510
3511         * Scripts/run-jsc-stress-tests: Extended URI module to be able to handle ssh scheme with the default 22 port number.
3512
3513 2015-02-06  Dana Burkart  <dburkart@apple.com>
3514
3515         dashboard: BuildbotTesterQueueView crashesOnly logic is wrong
3516         https://bugs.webkit.org/show_bug.cgi?id=141349
3517
3518         Reviewed by Alexey Proskuryakov.
3519
3520         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3521         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
3522         (BuildbotTesterQueueView.prototype.update):
3523
3524 2015-02-06  Alexey Proskuryakov  <ap@apple.com>
3525
3526         Report network process crashes during layout tests
3527         https://bugs.webkit.org/show_bug.cgi?id=139646
3528
3529         Reviewed by Anders Carlsson.
3530
3531         * WebKitTestRunner/TestController.cpp:
3532         (WTR::TestController::initialize):
3533         (WTR::TestController::networkProcessName):
3534         (WTR::TestController::networkProcessDidCrash):
3535         * WebKitTestRunner/TestController.h:
3536
3537 2015-02-06  Csaba Osztrogonác  <ossy@webkit.org>
3538
3539         run-jsc-stress-tests --remote should create remote directory before copying the bundle
3540         https://bugs.webkit.org/show_bug.cgi?id=141329
3541
3542         Reviewed by Michael Saboff.
3543
3544         * Scripts/run-jsc-stress-tests:
3545
3546 2015-02-06  Carlos Garcia Campos  <cgarcia@igalia.com>
3547
3548         [GTK] Remove WebKitWebView::close-notification signal
3549         https://bugs.webkit.org/show_bug.cgi?id=141330
3550
3551         Reviewed by Gustavo Noronha Silva.
3552
3553         Update notifications unit tests according to the API changes, and
3554         add a test case to check that onclose event is fired when a
3555         notification is closed by the user.
3556
3557         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
3558         (testWebViewNotification):
3559
3560 2015-02-05  Alexey Proskuryakov  <ap@apple.com>
3561
3562         Dashboard doesn't consider building ASan a productive step
3563         https://bugs.webkit.org/show_bug.cgi?id=141312
3564
3565         Reviewed by Simon Fraser.
3566
3567         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3568
3569 2015-02-05  Daniel Bates  <dabates@apple.com>
3570
3571         [iOS] webkitpy.xcode.simulator.Runtime.from_identifier() returns wrong result for non-existent runtime
3572         https://bugs.webkit.org/show_bug.cgi?id=141306
3573
3574         Reviewed by Alexey Proskuryakov.
3575
3576         The function webkitpy.xcode.simulator.Runtime.from_identifier always returns a Runtime object
3577         corresponding to the last-most runtime parsed from the output of `simctl list` for any non-
3578         existent runtime.
3579
3580         * Scripts/webkitpy/xcode/simulator.py:
3581         (Runtime.from_identifier):
3582
3583 2015-02-05  Daniel Bates  <dabates@apple.com>
3584
3585         LayoutTestRelay does not install DumpRenderTree.app/WebKitTestRunnerApp.app
3586         https://bugs.webkit.org/show_bug.cgi?id=139746
3587         <rdar://problem/19283658>
3588
3589         Reviewed by Alexey Proskuryakov.
3590
3591         Fixes an issues where LayoutTestRelay may fail to install DumpRenderTree.app/WebKitTestRunnerApp.app
3592         if the simulator device is not in state Booted.
3593
3594         Currently run-webkit-test --ios-sim executes LayoutTestRelay immediately after
3595         launching/relaunching the iOS Simulator app and a simulator app can only be installed
3596         on a device that is in the Booted state. LayoutTestRelay may run before the
3597         device is booted and hence fail to install DumpRenderTree.app/WebKitTestRunnerApp.app.
3598         We should defer executing LayoutTestRelay until the simulator device booted by
3599         iOS Simulator is in the Booted state.
3600
3601         * Scripts/webkitpy/port/ios.py: Import webkitpy.xcode.simulator.Simulator to avoid prefixing
3602         Simulator methods with the module name, simulator.
3603         (IOSSimulatorPort.setup_test_run): Wait for the simulator device to be in the Booted state
3604         after launching iOS Simulator. Also, wait until the simulator device is in the Shutdown state
3605         before launching iOS Simulator to boot it.
3606         (IOSSimulatorPort.testing_device): Fix up caller since we now import webkitpy.xcode.simulator.Simulator.
3607         (IOSSimulatorPort.simulator_path): Deleted; moved this function to class Simulator and renamed to device_directory().
3608         * Scripts/webkitpy/xcode/simulator.py:
3609         (Device.__init__): Remove parameter state and an instance variable of the same name, which represented
3610         the state of the device when we created this object as part of parsing the output of `simctl list`. Callers
3611         interested in the state of the device are more likely interested in the current state of the device as
3612         opposed to the state of the device when the Device object was created.
3613         (Device.state): Added; turn around and call Simulator.device_state() for the current state of the device.
3614         (Device.path): Extracted implementation into Simulator.device_directory() so that it can be called
3615         from both this function and Simulator.device_state().
3616         (Device.create): Use Simulator.wait_until_device_is_in_state() to simplify the implementation of this function.
3617         (Simulator.DeviceState): Added; class of constants.
3618         (Simulator.wait_until_device_is_in_state): Added; this function does not return until the specified
3619         device is in the specified state.
3620         (Simulator.device_state): Added; parses the state of the device from the appropriate CoreSimulator device.plist file.
3621         (Simulator.device_directory): Added.
3622         (Simulator._parse_devices): Do not pass argument state to Device constructor as it no longer accepts it.
3623
3624 2015-02-05  Alexey Proskuryakov  <ap@apple.com>
3625
3626         Disable retries on Mac debug testers
3627         https://bugs.webkit.org/show_bug.cgi?id=141296
3628
3629         Reviewed by Simon Fraser.
3630
3631         * BuildSlaveSupport/build.webkit.org-config/config.json:
3632
3633 2015-02-05  Dan Bernstein  <mitz@apple.com>
3634
3635         Need a way to force $xcodeSDK in webkitdirs.pm
3636         https://bugs.webkit.org/show_bug.cgi?id=141291
3637
3638         Reviewed by Anders Carlsson.
3639
3640         * Scripts/webkitdirs.pm:
3641         (setXcodeSDK): Added.
3642
3643 2015-02-05  Youenn Fablet  <youenn.fablet@crf.canon.fr> and Xabier Rodriguez Calvar <calvaris@igalia.com>
3644
3645         [Streams API] Implement a barebone ReadableStream interface
3646         https://bugs.webkit.org/show_bug.cgi?id=141045
3647
3648         Reviewed by Benjamin Poulain.
3649
3650         * Scripts/webkitperl/FeatureList.pm: Added streams-api compilation switch.
3651
3652 2015-02-04  Joseph Pecoraro  <pecoraro@apple.com>
3653
3654         filter-build-webkit: reduce more unfiltered output
3655         https://bugs.webkit.org/show_bug.cgi?id=141282
3656
3657         Reviewed by Daniel Bates.
3658
3659         * Scripts/filter-build-webkit:
3660         Report CompileDTraceScript and Preprocess lines as successful.
3661
3662 2015-02-04  Dana Burkart  <dburkart@apple.com>
3663
3664         Botwatcher's Dashboard is cramped
3665         https://bugs.webkit.org/show_bug.cgi?id=140273
3666
3667         Reviewed by Alexey Proskuryakov.
3668
3669         Add a heading key which will allow for arbitrary headings in builder queues.
3670
3671         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
3672     &n