de06a42ff9dffbbbb28404ef0099367133a7aead
[WebKit-https.git] / Tools / ChangeLog
1 2011-01-14  Eric Seidel  <eric@webkit.org>
2
3         Unreviewed.  Make it work in python 2.5.
4
5         webkit-patch suggest-reviewers dies when ChangeLogs are missing
6         https://bugs.webkit.org/show_bug.cgi?id=49158
7
8         * Scripts/webkitpy/common/checkout/api_unittest.py:
9
10 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
11
12         Unreviewed, rolling out r75774.
13         http://trac.webkit.org/changeset/75774
14         https://bugs.webkit.org/show_bug.cgi?id=52431
15
16         gtk builds were broken (Requested by loislo2 on #webkit).
17
18         * Scripts/webkitpy/common/checkout/scm.py:
19
20 2011-01-14  David Levin  <levin@chromium.org>
21
22         Reviewed by Shinichiro Hamaji.
23
24         check-webkit-style: _FunctionState should detect pure functions.
25         https://bugs.webkit.org/show_bug.cgi?id=52428
26
27         * Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
28         is a pure virtual function.
29         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
30         virtual functions are correctly detected.
31
32 2011-01-13  Ilya Tikhonovsky  <loislo@chromium.org>
33
34         Reviewed by Yury Semikhatsky.
35
36         Just small fix for problem with check-webkit-style.
37         It just didn't work for this patch.
38         Old code can't concatenate a list of strings with None.
39
40         * Scripts/webkitpy/common/checkout/scm.py:
41
42 2011-01-13  David Levin  <levin@chromium.org>
43
44         Reviewed by Shinichiro Hamaji.
45
46         check-webkit-style: _FunctionState should use Position to know where items are.
47         https://bugs.webkit.org/show_bug.cgi?id=52424
48
49         * Scripts/webkitpy/style/checkers/cpp.py:
50         (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers.
51         (detect_functions): Changed to pass Position's to _FunctionState.begin and
52         did some minor clean-up.
53         (*): Other changes are simply about converting to use the Position's in_FunctionState
54         instead of line numbers.
55         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code
56         to verify the positions stored in _FunctionState.
57
58 2011-01-13  Eric Seidel  <eric@webkit.org>
59
60         Reviewed by David Levin.
61
62         webkit-patch suggest-reviewers dies when ChangeLogs are missing
63         https://bugs.webkit.org/show_bug.cgi?id=49158
64
65         This is not the most elegant, but it is a very safe fix to this bug.
66         One advantage of catching ScriptError like this instead of adding a
67         new added_or_modified_files or fixing all changed_files callers
68         to use a more specific change_files variant, is that we catch
69         all kinds of ScriptErrors which might cause our (non-essential)
70         suggest-reviewers code to fail out.  This should make passing
71         --suggest-reviewers to webkit-patch upload much more robust
72         and may even make it possible for us to make it default.
73
74         The root of the problem here is that SCM.changed_files includes
75         deleted ChangeLog paths (from moves, etc) which then when we ask
76         SVN/Git for the contents of the file at that revision, the command
77         errors out and Executive.run_command raises a ScriptError.
78
79         In the future we might fix this differently by making all current
80         callers of chagned_files use a more specific method for requesting
81         what types of changes they're interested in (adds, modifies, deletes, etc.)
82
83         * Scripts/webkitpy/common/checkout/api.py:
84         * Scripts/webkitpy/common/checkout/api_unittest.py:
85
86 2011-01-13  Dan Bernstein  <mitz@apple.com>
87
88         Reviewed by Alexey Proskuryakov.
89
90         <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
91         https://bugs.webkit.org/show_bug.cgi?id=52419
92
93         Allow to further control the behavior of the willSendRequest delegate callback by making it
94         set a different URL in the new request.
95
96         * DumpRenderTree/LayoutTestController.cpp:
97         (addURLToRedirectCallback): Added.
98         (LayoutTestController::staticFunctions): Added addURLToRedirect.
99         (LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
100         (LayoutTestController::redirectionDestinationForURL): Added this getter.
101         * DumpRenderTree/LayoutTestController.h:
102         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
103         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
104         if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
105         change the URL in the new request to the redirect destination.
106
107 2011-01-13  Eric Seidel  <eric@webkit.org>
108
109         Reviewed by Mihai Parparita.
110
111         webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
112         https://bugs.webkit.org/show_bug.cgi?id=52416
113
114         Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717 
115         UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data
116
117         I also added FIXMEs about the changed_files returning deleted files problem
118         which is causing the other most common exception for suggest-reviewers
119         (and is probably breaking sheriff-bots blame detection).
120
121         * Scripts/webkitpy/common/checkout/api.py:
122         * Scripts/webkitpy/common/checkout/api_unittest.py:
123         * Scripts/webkitpy/common/checkout/scm.py:
124
125 2011-01-13  Eric Seidel  <eric@webkit.org>
126
127         Reviewed by Adam Barth.
128
129         results archives from commit-queue are too large to upload
130         https://bugs.webkit.org/show_bug.cgi?id=52405
131
132         * Scripts/webkitpy/common/system/filesystem.py:
133         * Scripts/webkitpy/common/system/filesystem_mock.py:
134         * Scripts/webkitpy/tool/commands/queues.py:
135
136 2011-01-13  Alejandro G. Castro  <alex@igalia.com>
137
138         Reviewed by Martin Robinson.
139
140         [gtk] Zero-sized font does not yet work
141         https://bugs.webkit.org/show_bug.cgi?id=49793
142
143         Set minimum-font-size to 0 for the DRT.
144
145         * DumpRenderTree/gtk/DumpRenderTree.cpp:
146         (resetDefaultsToConsistentValues):
147
148 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
149
150         Reviewed by Darin Adler.
151
152         Make old-run-webkit-tests more robust on buildbots
153         https://bugs.webkit.org/show_bug.cgi?id=52364
154
155         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.
156
157 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
158
159         Reviewed by Darin Adler.
160
161         Make old-run-webkit-tests more robust on buildbots
162         https://bugs.webkit.org/show_bug.cgi?id=52364
163
164         * Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.
165
166 2011-01-13  Tony Chang  <tony@chromium.org>
167
168         Reviewed by Kent Tamura.
169
170         [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
171         https://bugs.webkit.org/show_bug.cgi?id=52332
172
173         Forked Info.plist is not longer needed.
174
175         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.
176
177 2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>
178
179         Reviewed by Timothy Hatcher.
180
181         Web Inspector: Cleanup after r75613 -- make all UI-facing strings
182         to be passed directly to WebInspector.UIString
183
184         https://bugs.webkit.org/show_bug.cgi?id=52365
185
186         * Scripts/check-inspector-strings:
187
188 2011-01-13  Sheriff Bot  <webkit.review.bot@gmail.com>
189
190         Unreviewed, rolling out r74881.
191         http://trac.webkit.org/changeset/74881
192         https://bugs.webkit.org/show_bug.cgi?id=52357
193
194         The EFL builder has been red for days (Requested by abarth on
195         #webkit).
196
197         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
198         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
199
200 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
201
202         Reviewed by David Levin.
203
204         Add beforeunload support to WebKitTestRunner
205         https://bugs.webkit.org/show_bug.cgi?id=52353
206         
207         This makes a number of currently failing tests pass.
208
209         * WebKitTestRunner/TestController.cpp:
210         (WTR::runBeforeUnloadConfirmPanel):
211         (WTR::createOtherPage):
212         (WTR::TestController::initialize):
213
214 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
215
216         Reviewed by Sam Weinig.
217
218         Detect, identify and recover from WebProcess crashes in run-webkit-tests
219         https://bugs.webkit.org/show_bug.cgi?id=52330
220
221         * Scripts/old-run-webkit-tests: Detect when the regression test tool reports
222         a web process crash.
223         * WebKitTestRunner/TestController.cpp:
224         (WTR::TestController::initialize): Set up a processDidCrash
225         callback.
226         (WTR::TestController::processDidCrash): Report that the Web process
227         crashed.
228         * WebKitTestRunner/TestController.h:
229
230 2011-01-12  David Levin  <levin@chromium.org>
231
232         Reviewed by Shinichiro Hamaji.
233
234         check-webkit-style -- close_expression function doesn't work correctly.
235         https://bugs.webkit.org/show_bug.cgi?id=52272
236
237         * Scripts/webkitpy/style/checkers/cpp.py:
238         (Position.__str__): Added a way to convert it to a string which is useful in tests.
239         (Position.__cmp__): Added a way to compare Position which is useful in tests and
240         generally useful (for upcoming code changes).
241         (close_expression): Changed to use Position for input and output.
242         Also, fixed many bugs such as only working correctly for parenthesis,
243         not working correctly if given an offset in a line and not finding
244         the real closing element if there were multiple closing elements in
245         the same line.
246         (detect_functions): Adjusted due to the change in arguments for
247         close_expression.
248         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
249         (CppStyleTestBase.assert_positions_equal): Added a way to verify that
250         two positions are the same.
251         (CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
252         (CppStyleTest.test_close_expression): Added tests to catch the issues
253         that were fixed.
254
255 2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>
256
257         Unreviewed, rolling out r75576.
258         http://trac.webkit.org/changeset/75576
259         https://bugs.webkit.org/show_bug.cgi?id=52304
260
261         broke rebaseline-chromium-webkit-test (Requested by thakis on
262         #webkit).
263
264         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
265         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
266         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
267         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
268         * Scripts/webkitpy/layout_tests/port/base.py:
269         * Scripts/webkitpy/layout_tests/port/chromium.py:
270         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
271         * Scripts/webkitpy/layout_tests/port/test.py:
272         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
273         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
274         * Scripts/webkitpy/style/checkers/test_expectations.py:
275         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
276
277 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
278
279         Reviewed by Darin Adler.
280
281         Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
282         https://bugs.webkit.org/show_bug.cgi?id=52307
283
284         * Scripts/old-run-webkit-tests:
285
286 2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>
287
288         Reviewed by Martin Robinson.
289
290         [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
291         https://bugs.webkit.org/show_bug.cgi?id=50867
292
293         Fixed library extention for Mac in webkitdirs.pm and type conflict in
294         TestNetscapePlugin.cpp 
295
296         * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
297         * Scripts/webkitdirs.pm:
298
299 2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>
300
301         Reviewed by Pavel Feldman.
302
303         Add check-inspector-strings script.
304
305         https://bugs.webkit.org/show_bug.cgi?id=52295
306
307         * Scripts/check-inspector-strings: Added.
308
309 2011-01-12  Adam Roben  <aroben@apple.com>
310
311         Advertise the .testnetscape file extension on Windows
312
313         Fixes <http://webkit.org/b/52298>
314         plugins/no-mime-with-valid-extension.html fails on Windows
315
316         Reviewed by Dan Bernstein.
317
318         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a
319         FileExtents field to map the .testnetscape file extension to the
320         application/x-webkit-test-netscape MIME type, just as we do on Mac.
321
322 2011-01-12  Adam Barth  <abarth@webkit.org>
323
324         Reviewed by Eric Seidel.
325
326         Make webkit-patch support subdirectories for SVN checkouts
327         https://bugs.webkit.org/show_bug.cgi?id=52261
328
329         os.relpath does not exist on Python 2.5, so we need to call our version
330         of the API.
331
332         * Scripts/webkitpy/common/checkout/scm.py:
333
334 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
335
336         Reviewed by Eric Seidel.
337
338         Close additional pages opened during a test once the test completes.
339         https://bugs.webkit.org/show_bug.cgi?id=52276
340
341         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
342         (WTR::InjectedBundle::done):
343
344 2011-01-11  David Levin  <levin@chromium.org>
345
346         Reviewed by Eric Seidel.
347
348         Errors should be separated from the command line in bot messages.
349         https://bugs.webkit.org/show_bug.cgi?id=52275
350
351         * Scripts/webkitpy/common/system/executive.py:
352         (ScriptError.message_with_output): Added a newline to separate the command
353         line from the errors.
354         * Scripts/webkitpy/common/system/executive_unittest.py:
355         (ScriptErrorTest.test_message_with_output): Added tests for the various code
356         paths in message_with_output.
357
358 2011-01-11  Eric Seidel  <eric@webkit.org>
359
360         Unreviewed.
361
362         commit-queue should know how to upload archived results (for test flakes or general failures)
363         https://bugs.webkit.org/show_bug.cgi?id=52048
364
365         The zips are mostly empty due to forgetting -r.
366         Expected diffs were not being pulled from the archive due
367         to the archive having longer paths than I realized.
368
369         * Scripts/webkitpy/common/system/workspace.py:
370         * Scripts/webkitpy/common/system/workspace_unittest.py:
371         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
372         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
373
374 2011-01-11  Dirk Pranke  <dpranke@chromium.org>
375
376         Reviewed by Ojan Vafai.
377
378         The current modifier parsing code in test_expectations is
379         fragile and hard-coded, so it's not easy to understand the logic
380         or easily add new types of modifiers (like GPU vs. CPU testing
381         for graphics tests, or 32-bit vs. 64-bit differences).
382
383         This is the first of two patches that will add in more generic
384         support and then eliminate the GPU-specific test expectations
385         files for Chromium.
386
387         This patch adds two standalone objects for handling modifiers. The
388         rules for interpreting modifiers, precedence, and conflicts are
389         given in the docstring to the ModifierMatcher class, which
390         returns ModifierMatchResult objects.
391         
392         This patch also adds routines to the Port interface and a
393         default set of values in the base object, in order to obtain the
394         values needed on a given test run. These values are then passed
395         to the expectation parser. This also allows us to clean up the
396         logic used to lint all of the different configurations in a
397         single test_expectations.txt file.
398
399         The next patch will merge in the separate GPU expectations file.
400
401         https://bugs.webkit.org/show_bug.cgi?id=51222
402
403         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
404         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
405         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
406         * Scripts/webkitpy/layout_tests/port/base.py:
407         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
408         * Scripts/webkitpy/layout_tests/port/chromium.py:
409         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
410         * Scripts/webkitpy/layout_tests/port/test.py:
411         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
412         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
413
414 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
415
416         Reviewed by Adam Barth.
417
418         Make webkit-patch support subdirectories for SVN checkouts
419         https://bugs.webkit.org/show_bug.cgi?id=52261
420
421         * Scripts/webkitpy/common/checkout/scm.py:
422         * Scripts/webkitpy/style_references.py:
423         * Scripts/webkitpy/tool/main.py:
424         * Scripts/webkitpy/tool/steps/preparechangelog.py:
425
426 2011-01-11  Eric Seidel  <eric@webkit.org>
427
428         Unreviewed.
429
430         commit-queue should know how to upload archived results (for test flakes or general failures)
431         https://bugs.webkit.org/show_bug.cgi?id=52048
432
433         I changed the API for archive_last_layout_test_results w/o updating the implementation.  Oops.
434         This fixes an exception seen on the commit-queue when attempting to report flaky tests.
435
436         * Scripts/webkitpy/common/system/workspace.py:
437         * Scripts/webkitpy/common/system/workspace_unittest.py:
438         * Scripts/webkitpy/tool/commands/queues.py:
439
440 2011-01-11  Sam Weinig  <sam@webkit.org>
441
442         Roll r75474 back in.
443
444 2011-01-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
445
446         Reviewed by Kenneth Rohde Christiansen.
447
448         [Qt] Remove uses of QFuture since it isn't supported on all platforms.
449         https://bugs.webkit.org/show_bug.cgi?id=51204
450
451         * QtTestBrowser/webpage.h:
452         (QtNAMThread::QtNAMThread):
453         (QtNAMThread::networkAccessManager):
454         (QtNAMThread::run):
455
456 2011-01-11  Peter Varga  <pvarga@webkit.org>
457
458         Unreviewed.
459
460         Add myself to committers' list.
461
462         * Scripts/webkitpy/common/config/committers.py:
463
464 2011-01-11  Eric Seidel  <eric@webkit.org>
465
466         Reviewed by Adam Barth.
467
468         commit-queue should know how to upload archived results (for test flakes or general failures)
469         https://bugs.webkit.org/show_bug.cgi?id=52048
470
471         Now the queue will always upload results.  Either the entire zip, or just
472         the diffs.txt in the case of text failures.
473
474         This should make understanding flakes much easier, and paves the way
475         for having the EWS run layout tests (and upload failures).
476
477         In order to upload .zip files I had to teach bugzilla.py to autodetect
478         mime types from the filename.  Since mimetypes.py doesn't include a mapping
479         for .patch files, I have it add one before calling guess_type.
480
481         We may find that always uploading the whole zip instead of just the -diffs.txt
482         file is preferable, but for now I'm keeping the old behavior because it makes
483         quickly understanding text failures easy.
484
485         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
486         * Scripts/webkitpy/common/system/workspace.py: Added.
487         * Scripts/webkitpy/common/system/workspace_unittest.py: Added.
488         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
489         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
490         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
491         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
492         * Scripts/webkitpy/tool/commands/queues.py:
493         * Scripts/webkitpy/tool/commands/queues_unittest.py:
494
495 2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
496
497         Unreviewed, rolling out r75464.
498         http://trac.webkit.org/changeset/75464
499         https://bugs.webkit.org/show_bug.cgi?id=52193
500
501         Followup rollout for 75474 (Requested by Ossy on #webkit).
502
503         * MiniBrowser/mac/BrowserWindowController.m:
504         (-[BrowserWindowController awakeFromNib]):
505         * MiniBrowser/win/BrowserView.cpp:
506         (BrowserView::create):
507         * WebKitTestRunner/TestController.cpp:
508         (WTR::createOtherPage):
509         (WTR::TestController::initialize):
510
511 2011-01-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
512
513         Reviewed by Csaba Osztrogonác.
514
515         [Qt] Baseline qt_minimal configuration
516         https://bugs.webkit.org/show_bug.cgi?id=51313
517
518         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
519         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add
520         QT_NO_UNDOSTACK guard.
521
522         * QtTestBrowser/launcherwindow.cpp:
523         (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER
524         guards.
525         (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard.
526         (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard.
527         (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard.
528         (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
529
530         * QtTestBrowser/launcherwindow.h:
531         * QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
532         * QtTestBrowser/locationedit.h: Ditto.
533
534         * QtTestBrowser/mainwindow.cpp:
535         (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and
536         QT_NO_UNDOSTACK guards.
537         (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard.
538         (MainWindow::changeLocation): Ditto.
539         (MainWindow::openFile): Add QT_NO_FILEDIALOG guard.
540         (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
541
542         * QtTestBrowser/webpage.cpp:
543         (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard.
544         (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
545
546         * QtTestBrowser/webview.cpp:
547         (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard.
548         (WebViewGraphicsBased::animatedYFlip): Ditto.
549
550 2011-01-10  Sam Weinig  <sam@webkit.org>
551
552         Fix build.
553
554         * MiniBrowser/mac/BrowserWindowController.m:
555         (-[BrowserWindowController awakeFromNib]):
556         * MiniBrowser/win/BrowserView.cpp:
557         (BrowserView::create):
558         * WebKitTestRunner/TestController.cpp:
559         (WTR::createOtherPage):
560         (WTR::TestController::initialize):
561
562 2011-01-10  Eric Seidel  <eric@webkit.org>
563
564         Reviewed by Ojan Vafai.
565
566         style-queue messages are way too long for big patches
567         https://bugs.webkit.org/show_bug.cgi?id=52161
568
569         We definitely could build much fancier list-to-string-with-limit functions
570         but this should be sufficient for our needs at the moment.
571
572         * Scripts/webkitpy/common/system/executive.py:
573         * Scripts/webkitpy/common/system/executive_unittest.py:
574
575 2011-01-10  Tony Chang  <tony@chromium.org>
576
577         Unreviewed, rolling out r75398.
578         http://trac.webkit.org/changeset/75398
579         https://bugs.webkit.org/show_bug.cgi?id=52008
580
581         Some layout tests are crashing on Chromium Win.
582
583         * DumpRenderTree/chromium/WebViewHost.cpp:
584         (WebViewHost::updatePaintRect):
585         * DumpRenderTree/chromium/WebViewHost.h:
586
587 2011-01-10  Adam Roben  <aroben@apple.com>
588
589         Roll out r75392
590
591         It isn't needed now that r75289 has been rolled out.
592
593         * Scripts/run-javascriptcore-tests:
594
595 2011-01-10  Maciej Stachowiak  <mjs@apple.com>
596
597         Reviewed by Anders Carlsson.
598
599         WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
600         https://bugs.webkit.org/show_bug.cgi?id=52160
601
602         * WebKitTestRunner/mac/TestControllerMac.mm:
603         (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
604         Anything that can make runUntil() conditions turn true will happen on a run loop cycle
605         anyway.
606
607 2011-01-10  Tony Chang  <tony@chromium.org>
608
609         Reviewed by Mihai Parparita.
610
611         [chromium] fix for animated gif layout tests
612         https://bugs.webkit.org/show_bug.cgi?id=52008
613
614         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
615             to trigger gif animations.
616         (WebViewHostPaintTask::WebViewHostPaintTask):
617         (WebViewHostPaintTask::runIfValid):
618         (WebViewHost::updatePaintRect):
619         * DumpRenderTree/chromium/WebViewHost.h:
620         (WebViewHost::taskList):
621
622 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
623
624         Reviewed by Xan Lopez.
625
626         [GTK] Fix gtk2 compilation for master
627         https://bugs.webkit.org/show_bug.cgi?id=51885
628
629         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
630         (createBitmapContextFromWebView): Replaced the old
631         gdk_drawable_get_size with gdk_pixmap_get_size.
632
633 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
634
635         Reviewed by Laszlo Gombos.
636
637         [WINCE] Reenable NPAPI after r75203
638         https://bugs.webkit.org/show_bug.cgi?id=52109
639
640         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
641         it with !isEfl(), because EFL port does not support NPAPI (yet).
642
643         * Scripts/build-webkit:
644
645 2011-01-10  Adam Roben  <aroben@apple.com>
646
647         Skip some asserting JS tests
648
649         See <http://webkit.org/b/52156>.
650
651         * Scripts/run-javascriptcore-tests:
652
653 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
654
655         Reviewed by Xan Lopez.
656
657         [GTK] build-webkit disable Blob support via arguments passed to automake
658         https://bugs.webkit.org/show_bug.cgi?id=52097
659
660         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
661         build-webkit.
662
663 2011-01-10  Adam Roben  <aroben@apple.com>
664
665         Use the same name and description for TestNetscapePlugin on Windows and
666         Mac
667
668         Fixes <http://webkit.org/b/52151>
669         fast/frames/iframe-reparenting-plugins.html fails on Windows
670
671         Reviewed by Steve Falkenburg.
672
673         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
674         the name and description from Mac's Info.plist.
675
676 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
677
678         Reviewed by Laszlo Gombos.
679
680         [Qt][WK2] Guard gcc-specific syntax
681
682         Non-gcc based compliers choke on the "-include"
683         syntax for preinclude, place guard around it.
684
685         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
686         * WebKitTestRunner/qt/WebKitTestRunner.pro:
687
688 2011-01-10  Andreas Kling  <kling@webkit.org>
689
690         Reviewed by Simon Hausmann.
691
692         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
693         https://bugs.webkit.org/show_bug.cgi?id=52111
694
695         When getting a createNewPage() callback from QWKPage, create the
696         new page with the same QWKContext as the page that is passed to
697         the callback.
698
699         * MiniBrowser/qt/BrowserView.h:
700         * MiniBrowser/qt/BrowserWindow.cpp:
701         (newPageFunction):
702         (BrowserWindow::BrowserWindow):
703         * MiniBrowser/qt/BrowserWindow.h:
704
705 2011-01-10  Andreas Kling  <kling@webkit.org>
706
707         Reviewed by Kenneth Rohde Christiansen.
708
709         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
710
711         BrowserView set its own useless createNewPage() callback on QWKPage.
712         This was immediately overridden by BrowserWindow anyway, so remove
713         the BrowserView one.
714
715         * MiniBrowser/qt/BrowserView.cpp:
716         (BrowserView::BrowserView):
717
718 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
719
720         Reviewed by Jeremy Orlow.
721
722         [Chromium] Remove non-client-based Geolocation code
723         https://bugs.webkit.org/show_bug.cgi?id=50921
724
725         * DumpRenderTree/chromium/LayoutTestController.cpp:
726         (LayoutTestController::setGeolocationPermission):
727         (LayoutTestController::setMockGeolocationPosition):
728         (LayoutTestController::setMockGeolocationError):
729         * DumpRenderTree/chromium/WebViewHost.cpp:
730         (WebViewHost::geolocationClientMock):
731         (WebViewHost::reset):
732         * DumpRenderTree/chromium/WebViewHost.h:
733
734 2011-01-10  Eric Seidel  <eric@webkit.org>
735
736         Reviewed by Adam Barth.
737
738         Commit bot tried to land r? cq+ patch
739         https://bugs.webkit.org/show_bug.cgi?id=36638
740
741         It should now be possible to post a patch with r? and cq+ and the
742         commit-queue will correctly wait for the r+ before attempting to land the patch.
743         (This was a feature requested by several users.)
744
745         One caveat: We don't actually reject r-, cq+ patches from the queue
746         (we just ignore them), but I think that's OK for now.
747
748         I also noticed that setting r- once a commit-queue node had grabbed
749         a patch would not properly cancel the landing.  That's fixed and
750         tested in this patch.
751
752         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
753         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
754         * Scripts/webkitpy/tool/bot/feeders.py:
755         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
756
757 2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>
758
759         Reviewed by Kenneth Rohde Christiansen.
760
761         [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
762         https://bugs.webkit.org/show_bug.cgi?id=51934
763
764         When accessing the network from the destructor of QWebPage, the network access manager
765         was already deleted because the object WebPage was already destructed.
766
767         This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
768         The object is now destructed in the destructor of QObject.
769
770         * QtTestBrowser/webpage.cpp:
771         (WebPage::WebPage):
772         (WebPage::setQnamThreaded):
773         * QtTestBrowser/webpage.h:
774         (QtNAMThread::QtNAMThread):
775
776 2011-01-08  Eric Seidel  <eric@webkit.org>
777
778         Reviewed by Ojan Vafai.
779
780         test_failures.py should not mention TestShell (long live DumpRenderTree!)
781         https://bugs.webkit.org/show_bug.cgi?id=52067
782
783         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
784         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
785
786         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
787
788 2011-01-08  Eric Seidel  <eric@webkit.org>
789
790         Reviewed by Mihai Parparita.
791
792         commit-queue hangs when the ChangeLog diff is bad
793         https://bugs.webkit.org/show_bug.cgi?id=52072
794
795         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
796         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
797
798 2011-01-08  Adam Barth  <abarth@webkit.org>
799
800         Teach svn-apply how to re-write WebCore to Source/WebCore.
801
802         * Scripts/VCSUtils.pm:
803
804 2011-01-07  Adam Barth  <abarth@webkit.org>
805
806         Rubber-stamped by Eric Seidel.
807
808         Move WebCore to Source
809         https://bugs.webkit.org/show_bug.cgi?id=52050
810
811         Update the tools to understand WebCore's new location.
812
813         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
814         * DumpRenderTree/wscript:
815         * GNUmakefile.am:
816         * Scripts/build-webkit:
817         * Scripts/do-file-rename:
818         * Scripts/do-webcore-rename:
819         * Scripts/generate-qt-inspector-resource:
820         * Scripts/prepare-ChangeLog:
821         * Scripts/run-bindings-tests:
822         * Scripts/update-iexploder-cssproperties:
823         * Scripts/update-sources-list.py:
824         * Scripts/update-webkit-localizable-strings:
825         * Scripts/webkitdirs.pm:
826         * Scripts/webkitpy/common/config/build.py:
827         * Scripts/webkitpy/common/config/build_unittest.py:
828         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
829         * Scripts/webkitpy/style/checker.py:
830         * Scripts/webkitpy/style/checker_unittest.py:
831         * WebKitTestRunner/DerivedSources.pro:
832         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
833         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
834         * wx/browser/wscript:
835         * wx/build/settings.py:
836
837 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
838
839         Reviewed by Sam Weinig.
840
841         Make WebKitTestRunner rest between loads more robust to avoid test crashes
842         https://bugs.webkit.org/show_bug.cgi?id=52086
843
844         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
845         (WTR::InjectedBundle::didReceiveMessage):
846         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
847         (WTR::LayoutTestController::notifyDone):
848         * WebKitTestRunner/TestController.cpp:
849         (WTR::TestController::resetStateToConsistentValues):
850         (WTR::TestController::run):
851
852 2011-01-07  James Robinson  <jamesr@chromium.org>
853
854         Revert "Implement mozilla's animationTime property"
855         https://bugs.webkit.org/show_bug.cgi?id=51952
856
857         This approach isn't quite right.
858
859         * DumpRenderTree/chromium/WebViewHost.cpp:
860         (WebViewHost::paintInvalidatedRegion):
861
862 2011-01-07  Adam Roben  <aroben@apple.com>
863
864         Build master fix
865
866         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
867         (RunWebKitTests.start): Don't try to concatenate a list and a string.
868
869 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
870
871         Reviewed by Csaba Osztrogonác.
872
873         run-qtwebkit-tests should be able to kill a testsuite.
874
875         Add new option in the script that can setup a timeout for a test.
876         If the test execution takes more then specified time then the test
877         would be terminated.
878
879         [Qt] run-qtwebkit-tests needs timeout
880         https://bugs.webkit.org/show_bug.cgi?id=51894
881
882         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
883         * Scripts/run-qtwebkit-tests:
884
885 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
886
887         Unreviewed fix after r75233.
888
889         Based on idea from Eric Seidel.
890
891         Add remote zip file handling to webkitpy.
892         https://bugs.webkit.org/show_bug.cgi?id=50901
893
894         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
895
896 2011-01-07  Shane Stephens  <shanestephens@google.com>
897
898         Reviewed by Eric Seidel.
899
900         svn-apply: should support git binary delta diffs
901         https://bugs.webkit.org/show_bug.cgi?id=38864
902
903         * Scripts/VCSUtils.pm:
904         * Scripts/svn-apply:
905
906 2011-01-06  Julie Parent  <jparent@chromium.org>
907
908         Reviewed by Eric Seidel.
909
910         Test Result Server not removing old results.
911         https://bugs.webkit.org/show_bug.cgi?id=52012
912
913         * TestResultServer/model/jsonresults.py:
914         Fix off-by-one: Truncate if >= num_runs, not just >.
915         * TestResultServer/model/jsonresults_unittest.py:
916         Add unit test to test that merging in a new result with the same value
917         as the last result causes previous result to fall off.
918
919 2011-01-06  James Kozianski  <koz@chromium.org>
920
921         Reviewed by Mihai Parparita.
922
923         Add classes to provide a consistent interface to a set of files.
924         https://bugs.webkit.org/show_bug.cgi?id=50901
925
926         These classes allow us to write code that is agnostic to whether a
927         particular set of files resides in a local directory or in a zip file
928         on a remote machine.
929
930         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
931         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
932         * Scripts/webkitpy/common/system/fileset.py: Added.
933         * Scripts/webkitpy/common/system/filesystem.py:
934         * Scripts/webkitpy/common/system/filesystem_mock.py:
935         * Scripts/webkitpy/common/system/zipfileset.py: Added.
936         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
937
938 2011-01-06  Eric Seidel  <eric@webkit.org>
939
940         Reviewed by Adam Barth.
941
942         NetworkTransaction should log the url it is retrying
943         https://bugs.webkit.org/show_bug.cgi?id=52043
944
945         * Scripts/webkitpy/common/net/networktransaction.py:
946         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
947
948 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
949
950         Windows build fix.
951         Import os before using it.
952
953         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
954
955 2011-01-06  Eric Seidel  <eric@webkit.org>
956
957         Reviewed by Adam Barth.
958
959         StyleQueue fails to report errors when patches have many files
960         https://bugs.webkit.org/show_bug.cgi?id=52042
961
962         This is one of at least two errors preventing style error reporting at the moment.
963         When we moved to passing the list of files to check explicitly,
964         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
965         We could change the type of the QueueStatus.message type, or we could
966         just teach statusserver.py how to clamp values (and warn when it does).
967         I chose the latter path.
968
969         * Scripts/webkitpy/common/net/statusserver.py:
970
971 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
972
973         Reviewed by Stephanie Lewis.
974         
975         Fix syntax error in script.
976
977         Windows bots need to archive/unarchive builds to/from configuration-specific directories
978         https://bugs.webkit.org/show_bug.cgi?id=51996
979
980         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
981
982 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
983
984         Unreviewed, fixing WinCE build after r75196.
985
986         WinCE port does not (yet) support NPAPI.
987
988         * Scripts/build-webkit:
989
990 2011-01-06  Xan Lopez  <xlopez@igalia.com>
991
992         Reviewed by Darin Adler.
993
994         File::Spec->rel2abs in sunspider-compare-results mangles parameters
995         https://bugs.webkit.org/show_bug.cgi?id=52015
996
997         * Scripts/sunspider-compare-results: call rel2abs on our arguments
998         after the platform has been detected, otherwise the script will
999         mangle things like '--gtk' into '/a/path/--gtk', breaking the
1000         detection.
1001
1002 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1003
1004         Reviewed by Eric Seidel.
1005
1006         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
1007         https://bugs.webkit.org/show_bug.cgi?id=51346
1008
1009         * Scripts/build-webkit:
1010
1011 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
1012
1013         Reviewed by Adam Roben.
1014
1015         Windows bots need to archive/unarchive builds to/from configuration-specific directories
1016         https://bugs.webkit.org/show_bug.cgi?id=51996
1017         
1018         After the configuration directory change, we were archiving the incorrect directory for
1019         build product, so we were running tests on the wrong binaries.
1020         
1021         This change archives the correct directory, and also unarchives it into a configuration-
1022         specific directory.
1023
1024         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
1025         * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
1026
1027 2011-01-06  Eric Seidel  <eric@webkit.org>
1028
1029         Reviewed by Mihai Parparita.
1030
1031         commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
1032         https://bugs.webkit.org/show_bug.cgi?id=52002
1033
1034         See an example of this here:
1035         https://bugs.webkit.org/show_bug.cgi?id=51314#c2
1036
1037         It's due to the fact that we pass around TestFailure() instance
1038         objects and yet expect them to all compare to be the same.
1039
1040         This is bad.  We should either have shared instances of these values
1041         or we should just pass around the class names.  There are already hacks
1042         in place to make TestFailure objects pass equality tests, I just added
1043         a __hash__ implementation so they can be used in sets as expected.
1044
1045         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1046         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1047
1048 2011-01-06  Evan Martin  <evan@chromium.org>
1049
1050         Reviewed by Tony Chang.
1051
1052         [gdb] handle inaccessible memory and UChar*
1053         https://bugs.webkit.org/show_bug.cgi?id=52003
1054
1055         To pretty-print a UChar*, we just grope around in the memory
1056         looking for a terminating NUL.  We need to handle the exception
1057         that can occur when we poke into an invalid location.
1058
1059         Additionally, the logic for choosing which pretty-printer would
1060         early return before hitting the point where we'd use the UChar*
1061         printer.  (Did this ever work?  How did it regress?)
1062
1063         * gdb/webkit.py:
1064
1065 2011-01-05  Brian Weinstein  <bweinstein@apple.com>
1066
1067         Reviewed by Ada Chan.
1068
1069         WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
1070         https://bugs.webkit.org/show_bug.cgi?id=51969
1071         
1072         Add shouldLoadResourceForFrame to WTR::InjectedBundlePage.
1073
1074         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1075         (WTR::InjectedBundlePage::InjectedBundlePage):
1076         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation.
1077         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1078
1079 2011-01-06  James Robinson  <jamesr@chromium.org>
1080
1081         Reviewed by Simon Fraser.
1082
1083         Implement mozilla's animationTime property
1084         https://bugs.webkit.org/show_bug.cgi?id=51952
1085
1086         Chromium DRT support for webkitAnimationTime.
1087
1088         * DumpRenderTree/chromium/WebViewHost.cpp:
1089         (WebViewHost::paintInvalidatedRegion):
1090
1091 2011-01-06  Julie Parent  <jparent@chromium.org>
1092
1093         Reviewed by Tony Chang.
1094
1095         Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
1096         https://bugs.webkit.org/show_bug.cgi?id=51217
1097
1098         * TestResultServer/model/jsonresults.py:
1099         Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value.
1100         Adds missing documentation.
1101         * TestResultServer/model/jsonresults_unittest.py:
1102         Add unit test to test that truncation happens at smaller value than JSON_RESULTS_MAX_BUILDS.
1103         Update test_merge to take a number of builds to truncate at.
1104
1105 2011-01-06  Adam Barth  <abarth@webkit.org>
1106
1107         Reviewed by Eric Seidel.
1108
1109         The EWS should log outside of the working directory
1110         https://bugs.webkit.org/show_bug.cgi?id=51986
1111
1112         This patch prepare us for using git clean -x -d -f in the EWS wrapper
1113         script, which will actually clean the working copy back to a pristine
1114         state instead of leaving untracked directories and ignored files.
1115
1116         * Scripts/webkitpy/tool/commands/queues.py:
1117         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1118
1119 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
1120
1121         Windows build fix.
1122         Back out attempted change to built-product-archive.
1123
1124         * BuildSlaveSupport/built-product-archive:
1125
1126 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
1127
1128         Windows build fix.
1129         Include configuration name when unpacking a build archive.
1130
1131         Needed, since we split Windows build results into configuration-specific directories
1132         under WebKitOutputDir.
1133
1134         * BuildSlaveSupport/built-product-archive:
1135
1136 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
1137
1138         Reviewed by Darin Adler.
1139
1140         Debug and Release builds on Windows clobber each other
1141         https://bugs.webkit.org/show_bug.cgi?id=49185
1142
1143         Changes the structure of WebKitBuild build products directory so we
1144         completely separate each build configuration into independent directories.
1145         
1146         Although we previously had per-configuration directories for obj, this change adds
1147         per-configuration directories for bin, lib, obj, and include. Each configuration's
1148         build products are stored within a directory inside of WebKitBuild.
1149         
1150         Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
1151         defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
1152
1153         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
1154         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd:
1155         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd:
1156         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
1157         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
1158         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd:
1159         * DumpRenderTree/win/ImageDiffCommon.vsprops:
1160         * DumpRenderTree/win/ImageDiffPostBuild.cmd:
1161         * DumpRenderTree/win/ImageDiffPreBuild.cmd:
1162         * FindSafari/FindSafari.vcproj:
1163         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
1164         * MiniBrowser/MiniBrowserPostBuild.cmd:
1165         * MiniBrowser/MiniBrowserPreBuild.cmd:
1166         * Scripts/webkitdirs.pm:
1167         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
1168         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops:
1169         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd:
1170         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd:
1171         * TestWebKitAPI/win/copy-resources.cmd:
1172         * WebKitAPITest/WebKitAPITestCommon.vsprops:
1173         * WebKitAPITest/WebKitAPITestPostBuild.cmd:
1174         * WebKitAPITest/WebKitAPITestPreBuild.cmd:
1175         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
1176         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
1177         * WebKitTestRunner/win/InjectedBundle.vcproj:
1178         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops:
1179         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd:
1180         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd:
1181         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
1182         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd:
1183         * WinLauncher/WinLauncherCommon.vsprops:
1184         * WinLauncher/WinLauncherPostBuild.cmd:
1185         * WinLauncher/WinLauncherPreBuild.cmd:
1186
1187 2011-01-05  Jan Erik Hanssen  <jhanssen@sencha.com>
1188
1189         Reviewed by Ariya Hidayat.
1190
1191         [Qt] TestNetscapePlugin doesn't link on OS X
1192         https://bugs.webkit.org/show_bug.cgi?id=51948
1193
1194         Only add a dependency on libX11 on X11 systems
1195
1196         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1197
1198 2011-01-05  Jeff Miller  <jeffm@apple.com>
1199
1200         Reviewed by Adam Roben.
1201
1202         check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
1203         https://bugs.webkit.org/show_bug.cgi?id=51970
1204
1205         * Scripts/webkitpy/style/checker.py:
1206         Add -readability/naming for WebKit2 C API directories.
1207
1208 2011-01-05  Eric Seidel  <eric@webkit.org>
1209
1210         Unreviewed, just fixing one more log error from my previous python patch.
1211
1212         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1213         https://bugs.webkit.org/show_bug.cgi?id=51802
1214
1215         webkit-patch failure-reason was logging about parsing errors
1216         due to my misunderstanding of how BeautifulSoup.findAll worked.
1217
1218         Fixed, and added a unit test.
1219
1220         * Scripts/webkitpy/common/net/layouttestresults.py:
1221         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1222
1223 2011-01-05  Benjamin Poulain  <benjamin.poulain@nokia.com>
1224
1225         Reviewed by Kenneth Rohde Christiansen.
1226
1227         [Qt] [WK2] Add the possibility to open window from the WebProcess in Minibrowser
1228         https://bugs.webkit.org/show_bug.cgi?id=51951
1229
1230         Set a function to QWKPage::setCreateNewPageFunction() in Minibrowser so there is a way
1231         to create new window from WebKit.
1232
1233         * MiniBrowser/qt/BrowserWindow.cpp:
1234         (newPageFunction):
1235         (BrowserWindow::BrowserWindow):
1236         (BrowserWindow::page): Added to avoid the indirect access to QWKPage spread in the class
1237         (BrowserWindow::newWindow):
1238         (BrowserWindow::updateUserAgentList):
1239         (BrowserWindow::showUserAgentDialog):
1240         * MiniBrowser/qt/BrowserWindow.h: Add the global variable backingStoreTypeForNewWindow to
1241         define the type of the backing store used for new windows.
1242         * MiniBrowser/qt/main.cpp:
1243         (main):
1244
1245 2011-01-05  Eric Seidel  <eric@webkit.org>
1246
1247         Reviewed by Ojan Vafai.
1248
1249         commit-queue should report failure type when reporting flaky tests
1250         https://bugs.webkit.org/show_bug.cgi?id=51900
1251
1252         This patch was a ridiculous amount of plumbing.  In the end I like
1253         the NRWT-style TestResult class even less.  But now we're passing
1254         a list of TestResult objects from the queue to the FlakyTestReporter.
1255         Thus the FlakyTestReporter can more easily report what type of failure
1256         occurred.
1257
1258         In the process, I found that I was not alone in finding TestResult
1259         cumbersome to use.  A bunch of code was trying to create a TestResult
1260         object with default values.  However since the constructor didn't make
1261         this easy, some places were getting it wrong (including the TestResult unit test)!
1262         I've fixed the TestResult constructor to have default values for non-essential
1263         arguments.
1264
1265         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1266         * Scripts/webkitpy/common/net/layouttestresults.py:
1267         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1268         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1269         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1270         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1271         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
1272         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
1273         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1274         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1275         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1276         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1277         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1278         * Scripts/webkitpy/tool/commands/queues.py:
1279         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1280
1281 2011-01-05  Eric Seidel  <eric@webkit.org>
1282
1283         Unreviewed.
1284
1285         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1286         https://bugs.webkit.org/show_bug.cgi?id=51802
1287
1288         Add another unit test to cover a previously missing import.
1289
1290         * Scripts/webkitpy/common/net/layouttestresults.py:
1291         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1292
1293 2011-01-05  Mihai Parparita  <mihaip@chromium.org>
1294
1295         Reviewed by David Levin.
1296
1297         Add mihaip@chromium.org as a reviewer
1298         https://bugs.webkit.org/show_bug.cgi?id=51966
1299         
1300         Add myself as a reviewer.
1301
1302         * Scripts/webkitpy/common/config/committers.py:
1303
1304 2011-01-05  James Simonsen  <simonjam@chromium.org>
1305
1306         Unreviewed. Adding myself to the list of committers.
1307
1308         * Scripts/webkitpy/common/config/committers.py:
1309
1310 2011-01-05  Eric Seidel  <eric@webkit.org>
1311
1312         Unreviewed.
1313
1314         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1315         https://bugs.webkit.org/show_bug.cgi?id=51802
1316
1317         Fix two exceptions seen on the bots after my original commit.
1318
1319         * Scripts/webkitpy/common/net/layouttestresults.py:
1320         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1321
1322 2011-01-05  Kundu Suchismita  <suchi.kundu@nokia.com>
1323
1324         Reviewed by Andreas Kling.
1325
1326         [Qt]Add local storage settings to QtTestBrowser command line arguments 
1327         https://bugs.webkit.org/show_bug.cgi?id=51750
1328
1329         * QtTestBrowser/main.cpp:
1330         (LauncherApplication::handleUserOptions):
1331          Local storage settings can be enable form command line arguments for
1332          QtTestBrowser.
1333
1334 2011-01-05  Chris Fleizach  <cfleizach@apple.com>
1335
1336         Reviewed by Martin Robinson.
1337
1338         GTK: AX: DRT needs to use correct root object method.
1339         https://bugs.webkit.org/show_bug.cgi?id=51911
1340
1341         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1342         (AccessibilityController::rootElement):
1343
1344 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1345
1346         Rubber-stamped by Csaba Osztrogonác.
1347
1348         Based on idea from Péter Gál.
1349
1350         * Scripts/webkitpy/tool/bot/sheriff.py: Remove unnecessary apostrophes around revision numbers.
1351
1352 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1353
1354         Reviewed by Adam Barth.
1355
1356         sheriff-bot should be able to do multi-revision rollouts
1357         https://bugs.webkit.org/show_bug.cgi?id=51176
1358
1359         * Scripts/webkitpy/tool/bot/irc_command.py:
1360         * Scripts/webkitpy/tool/bot/sheriff.py:
1361         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
1362
1363 2011-01-05  Eric Seidel  <eric@webkit.org>
1364
1365         Reviewed by Adam Barth.
1366
1367         queues.webkit.org should have per-bot status pages
1368         https://bugs.webkit.org/show_bug.cgi?id=51906
1369
1370         Just adds a /queue-status/QUEUE_NAME/bots/BOT_ID page to show
1371         statuses from a single queue.  Now that we have many bots servicing
1372         some queues (commit-queue, win-ews, etc.) its easy to have the messages
1373         you care about scroll off the end of the 15-message limit on the main page.
1374
1375         Eventually we should probably rename /queue-status to /queue or /queues,
1376         but that's fodder for another patch.
1377
1378         * QueueStatusServer/handlers/queuestatus.py:
1379         * QueueStatusServer/index.yaml:
1380         * QueueStatusServer/main.py:
1381         * QueueStatusServer/templates/includes/singlequeuestatus.html:
1382          - This probably should use a custom filter instead of hard-coding
1383            the URL scheme here, but I couldn't figure out how to easily
1384            create such a filter.  Most filters work with "strings" so we can't
1385            pass the status object.  We could add a method to the status
1386            object and call that, but that seemed a bit strange too.
1387         * QueueStatusServer/templates/queuestatus.html:
1388
1389 2011-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1390
1391         Unreviewed. Adding myself to the list of committers.
1392
1393         * Scripts/webkitpy/common/config/committers.py:
1394
1395 2011-01-04  Koan-Sin Tan  <koansin.tan@gmail.com>
1396
1397         Reviewed by David Levin.
1398
1399         check-webkit-style treated some macros with parentheses after #elif as function calls
1400         https://bugs.webkit.org/show_bug.cgi?id=51695
1401
1402         Ingore function call space checking in any preprocessor directives
1403         (things starting with #). Change search() to match() because 
1404         preprocessor directives are supposed to be in the beginning of lines.
1405
1406         * Scripts/webkitpy/style/checkers/cpp.py:
1407         * Scripts/webkitpy/style/checkers/cpp_unittest.py: make sure there is no false positives for #elif cases
1408
1409 2011-01-04  Søren Gjesse  <sgjesse@chromium.org>
1410
1411         Reviewed by Tony Chang.
1412
1413         Change the --multi-load test option to --stress-opt
1414         https://bugs.webkit.org/show_bug.cgi?id=50751
1415
1416         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1417         (runTest):
1418         (main):
1419         * DumpRenderTree/chromium/TestShell.cpp:
1420         (TestShell::TestShell):
1421         * DumpRenderTree/chromium/TestShell.h:
1422         (TestShell::stressOpt):
1423         (TestShell::setStressOpt):
1424         (TestShell::stressDeopt):
1425         (TestShell::setStressDeopt):
1426         (TestShell::javaScriptFlags):
1427         (TestShell::setJavaScriptFlags):
1428         * Scripts/webkitpy/layout_tests/port/chromium.py:
1429         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1430
1431 2011-01-04  Chris Fleizach  <cfleizach@apple.com>
1432
1433         Reviewed by Sam Weinig.
1434
1435         WK2: Support Accessibility
1436         https://bugs.webkit.org/show_bug.cgi?id=51859
1437
1438         Use rootObject() method to get top of accessibility tree.
1439
1440         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
1441         (AccessibilityController::focusedElement):
1442         (AccessibilityController::rootElement):
1443
1444 2011-01-03  Martin Robinson  <mrobinson@igalia.com>
1445
1446         Reviewed by Darin Adler.
1447
1448         Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
1449         https://bugs.webkit.org/show_bug.cgi?id=51846
1450
1451         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Change usage of PlatformRefPtr
1452         back to GRefPtr.
1453
1454 2011-01-04  Zhe Su  <suzhe@chromium.org>
1455
1456         Reviewed by Kenneth Russell.
1457
1458         Fix insertText, setMarkedText and unmarkText methods of
1459         TextInputController to call corresponding methods of WebKit::WebView
1460         rather than WebKit::WebFrame. This change matches the behavior of
1461         chromium browser.
1462         insertText corresponds to WebView::confirmComposition(text)
1463         setMarkedText corresponds to WebView::setComposition(...)
1464         unmarkText corresponds to WebView::confirmComposition()
1465         https://bugs.webkit.org/show_bug.cgi?id=51693
1466
1467         * DumpRenderTree/chromium/TextInputController.cpp:
1468         (TextInputController::insertText):
1469         (TextInputController::setMarkedText):
1470         (TextInputController::unmarkText):
1471
1472 2011-01-04  Dihan Wickremasuriya  <dihan.wickremasuriya@nokia.com>
1473
1474         Reviewed by Laszlo Gombos.
1475
1476         [Qt] [Symbian] Do not remove 0 byte sized files from productDir
1477
1478         On Symbian productDir points to the source directory. Removing all the
1479         empty files from the productDir directory corrupts the svn repository.
1480
1481         * Scripts/build-webkit:
1482
1483 2011-01-03  Yi Shen  <yi.4.shen@nokia.com>
1484
1485         Reviewed by Adam Barth.
1486
1487         [Qt] Add SelectAll option to the context menu for the editor
1488         https://bugs.webkit.org/show_bug.cgi?id=50049
1489
1490         Set shortcut for the SelectAll action.
1491
1492         * QtTestBrowser/mainwindow.cpp:
1493         (MainWindow::buildUI):
1494
1495 2011-01-03  David Levin  <levin@chromium.org>
1496
1497         Reviewed by Eric Seidel.
1498
1499         check-webkit-style shouldn't consider "value" automatically to be a meaningless name.
1500         https://bugs.webkit.org/show_bug.cgi?id=51842
1501
1502         * Scripts/webkitpy/style/checkers/cpp.py: Remove the check for value.
1503         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Remove the test for value.
1504
1505 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
1506
1507         Reviewed by David Kilzer.
1508
1509         [WINCE] Adds a build slave.
1510         https://bugs.webkit.org/show_bug.cgi?id=50523
1511
1512         * BuildSlaveSupport/build.webkit.org-config/config.json: Add an
1513         entry for a release build of the WinCE port.
1514         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform
1515         flag to build the WinCE port.
1516
1517 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
1518
1519         Reviewed by David Kilzer.
1520
1521         Add WinCE support to build-webkit
1522         https://bugs.webkit.org/show_bug.cgi?id=51642
1523
1524         * Scripts/build-webkit:
1525         * Scripts/webkitdirs.pm:
1526
1527 2011-01-03  Eric Seidel  <eric@webkit.org>
1528
1529         Reviewed by Adam Barth.
1530
1531         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1532         https://bugs.webkit.org/show_bug.cgi?id=51802
1533
1534         I'm not the biggest fan of the test_failures or test_results classes,
1535         but it's better to have one shared set of classes, than separate ones
1536         for new vs. old run-webkit-test result handling.
1537
1538         This moves the ORWT results class "LayoutTestResults" over to using
1539         TestResult and TestFailure classes, making it easy for us to
1540         make all our sheriff-bot and other webkitpy code NRWT ready.
1541
1542         This also makes it a trivial patch to generate results.json information
1543         from ORWT results.html files (for flaky test analysis, etc.) as well
1544         as making it a one-liner to report test failure types when the
1545         commit-queue sees flaky tests.
1546
1547         This patch tried not to add new functionality, but only to replace
1548         the guts of LayoutTestResults, while adding unit tests and hoping
1549         not to break anything.
1550
1551         I also moved callers which assumed User.prompt* were static/class methods
1552         to using them as instance methods (since we'll eventually want to make them such).
1553
1554         In the process of re-writing things, I broke the rebaseline command, so I wrote
1555         a unit test to catch my breakage were I do do so again in the future.
1556
1557         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1558         * Scripts/webkitpy/common/net/layouttestresults.py:
1559         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1560         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1561         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
1562         * Scripts/webkitpy/tool/commands/queries.py:
1563         * Scripts/webkitpy/tool/commands/rebaseline.py:
1564         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1565         * Scripts/webkitpy/tool/mocktool.py:
1566
1567 2011-01-03  Adam Barth  <abarth@webkit.org>
1568
1569         Reviewed by Simon Fraser.
1570
1571         webkit-patch shouldn't waste time cleaning a working directory that's already clean
1572         https://bugs.webkit.org/show_bug.cgi?id=51840
1573
1574         * Scripts/webkitpy/common/checkout/scm.py:
1575
1576 2011-01-03  Adam Barth  <abarth@webkit.org>
1577
1578         Reviewed by Simon Fraser.
1579
1580         webkit-patch should only hide update output if --quiet
1581         https://bugs.webkit.org/show_bug.cgi?id=51838
1582
1583         As requested by smfr.
1584
1585         * Scripts/webkitpy/tool/steps/update.py:
1586
1587 2011-01-03  Adam Barth  <abarth@webkit.org>
1588
1589         Reviewed by David Levin.
1590
1591         commit-queue shouldn't reject patches twice if two bots process the same patch
1592         https://bugs.webkit.org/show_bug.cgi?id=51805
1593
1594         Before raising an error, we first check whether the patch is still in
1595         the commit-queue.  This check is still racy, of course, but the time
1596         window is much smaller.
1597
1598         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1599
1600 2011-01-03  Sam Weinig  <sam@webkit.org>
1601
1602         Reviewed by Anders Carlsson.
1603
1604         Make run-api-tests less chatty.
1605         https://bugs.webkit.org/show_bug.cgi?id=51831
1606
1607         - Make script quiet by default and add --verbose option (replacing --quiet).
1608         - When not verbose, pipe stdout and stderr to devnull.
1609
1610         * Scripts/run-api-tests:
1611
1612 2011-01-03  Pratik Solanki  <psolanki@apple.com>
1613
1614         Unreviewed. Adding myself to committers.py.
1615
1616         * Scripts/webkitpy/common/config/committers.py:
1617
1618 2011-01-03  Koan-Sin Tan  <koansin.tan@gmail.com>
1619
1620         Reviewed by Xan Lopez.
1621
1622         "Tool/Scripts/run-launcher --gtk" stopped working after 74855
1623         https://bugs.webkit.org/show_bug.cgi?id=51806
1624
1625         Originally, the $libraryName is 'JavaScriptCore'. When building release 
1626         one, the $libraryDir was 'WebKitBuild/Release/JavaScriptCore/../.libs/'
1627         which doesn't exist anymore ('WebKitBuild/Release/JavaScriptCore'
1628         is 'WebKitBuild/Release/Source/JavaScriptCore' now), and 
1629         'WebKitBuild/Release/Source/JavaScriptCore/../../.libs' looks weird,
1630         so make it 'WebKitBuild/Release/.libs'
1631
1632         * Scripts/webkitdirs.pm: 
1633
1634 2011-01-02  Patrick Gansterer  <paroga@webkit.org>
1635
1636         Reviewed by Adam Barth.
1637
1638         Make EFL a core builder
1639         https://bugs.webkit.org/show_bug.cgi?id=51804
1640
1641         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1642         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1643
1644 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
1645
1646         [Qt] Unreviewed fix after r74855 and r74875.
1647
1648         * BuildSlaveSupport/built-product-archive:
1649          - Create directories explicitly.
1650          - Pass shell=True to subprocess.call().
1651
1652 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
1653
1654         [Qt] Unreviewed fix after r74855.
1655
1656         Move JavaScriptCore to Source
1657         https://bugs.webkit.org/show_bug.cgi?id=51604
1658
1659         * BuildSlaveSupport/built-product-archive: JavaScriptCore -> Source/JavaScriptCore
1660
1661 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
1662
1663         [Qt] Unreviewed run-javasriptcore-tests fix after r74855.
1664
1665         Move JavaScriptCore to Source
1666         https://bugs.webkit.org/show_bug.cgi?id=51604
1667
1668         * Scripts/webkitdirs.pm:
1669
1670 2011-01-02  Robert Hogan  <robert@webkit.org>
1671
1672         Unreviewed, build fix.
1673
1674         [Qt] Fix DRT build after 74855
1675
1676         * DumpRenderTree/qt/DumpRenderTree.pro:
1677
1678 2011-01-01  Adam Barth  <abarth@webkit.org>
1679
1680         Remove the assumption from the Qt and Gtk builds that every project is
1681         in the root directory.
1682
1683         * Scripts/build-webkit:
1684
1685 2011-01-01  Adam Barth  <abarth@webkit.org>
1686
1687         Reviewed by Eric Seidel.
1688
1689         Teach svn-apply how to apply patches even though JavaScriptCore has moved
1690         https://bugs.webkit.org/show_bug.cgi?id=51796
1691
1692         After this change, svn-apply will magically apply patches to
1693         JavaScriptCore/foo to Source/JavaScriptCore/foo.
1694
1695         * Scripts/VCSUtils.pm:
1696
1697 2011-01-01  Adam Barth  <abarth@webkit.org>
1698
1699         Reviewed by Eric Seidel.
1700
1701         Move JavaScriptCore to Source
1702         https://bugs.webkit.org/show_bug.cgi?id=51604
1703
1704         Update references to JavaScriptCore to point to the new location.
1705
1706         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1707         * DumpRenderTree/qt/DumpRenderTree.pro:
1708         * DumpRenderTree/qt/ImageDiff.pro:
1709         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1710         * DumpRenderTree/wscript:
1711         * Scripts/build-jsc:
1712         * Scripts/build-webkit:
1713         * Scripts/do-file-rename:
1714         * Scripts/do-webcore-rename:
1715         * Scripts/run-javascriptcore-tests:
1716         * Scripts/update-javascriptcore-test-results:
1717         * Scripts/webkitdirs.pm:
1718         * Scripts/webkitpy/common/config/build_unittest.py:
1719         * Scripts/webkitpy/style/checker.py:
1720         * Scripts/webkitpy/style/checker_unittest.py:
1721         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1722         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1723         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1724         * wx/build/settings.py:
1725
1726 2011-01-01  Adam Barth  <abarth@webkit.org>
1727
1728         Reviewed by Eric Seidel.
1729
1730         Move Sources to Source
1731         https://bugs.webkit.org/show_bug.cgi?id=51794
1732
1733         Update scripts to point to the new location.
1734
1735         * Scripts/build-webkit:
1736         * Scripts/do-file-rename:
1737         * Scripts/do-webcore-rename:
1738         * Scripts/webkitpy/common/config/build.py:
1739         * Scripts/webkitpy/common/config/build_unittest.py:
1740
1741 2010-12-31  Kent Tamura  <tkent@chromium.org>
1742
1743         Reviewed by Eric Seidel.
1744
1745         [DRT/Chromium] Enable mock spell checker on non-OSX
1746         https://bugs.webkit.org/show_bug.cgi?id=51401
1747
1748         * DumpRenderTree/chromium/WebViewHost.cpp:
1749         (WebViewHost::spellCheck):
1750
1751 2010-12-31  Adam Barth  <abarth@webkit.org>
1752
1753         Reviewed by Ariya Hidayat.
1754
1755         Remove Tools/Scripts/wkstyle
1756         https://bugs.webkit.org/show_bug.cgi?id=51774
1757
1758         This script appears to not have been touched in a while and seems to
1759         have been replaced by check-webkit-style.
1760
1761         * Scripts/wkstyle: Removed.
1762
1763 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
1764
1765         Unreviewed. Coding style fix.
1766
1767         * DumpRenderTree/chromium/TestShell.h:
1768
1769 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
1770
1771         Reviewed by Pavel Feldman.
1772
1773         Web Inspector: [Chromium] Inspector's tests are very slow on Win(Dbg).
1774
1775         It was a problem with Chromium DRT. DevToolsAgent object instance was
1776         attached not only to the inspected page but to the DevTools window too.
1777         As result all the inspector files were interpreted as a content of inspected page
1778         and were transfered to the DevTools scripts panel for debugging etc.
1779
1780         https://bugs.webkit.org/show_bug.cgi?id=51735
1781
1782         * DumpRenderTree/chromium/TestShell.cpp:
1783         (TestShell::TestShell):
1784         (TestShell::bindJSObjectsToWindow):
1785         (TestShell::createNewWindow):
1786         * DumpRenderTree/chromium/TestShell.h:
1787
1788 2010-12-31  Adam Barth  <abarth@webkit.org>
1789
1790         Rubber-stamped by Eric Seidel.
1791
1792         Move PageLoadTests to PerformanceTests/PageLoad
1793         https://bugs.webkit.org/show_bug.cgi?id=51771
1794
1795         Update references to PageLoadTests to point to the new location.
1796
1797         * Scripts/run-pageloadtest:
1798         * Scripts/webkitpy/common/config/build.py:
1799
1800 2010-12-31  Adam Barth  <abarth@webkit.org>
1801
1802         Rubber-stamped by Eric Seidel.
1803
1804         Move SunSpider into PerformanceTests
1805         https://bugs.webkit.org/show_bug.cgi?id=51769
1806
1807         Update these scripts to point to the new location.
1808
1809         * Scripts/run-sunspider:
1810         * Scripts/sunspider-compare-results:
1811
1812 2010-12-30  Mihai Parparita  <mihaip@chromium.org>
1813
1814         Reviewed by Kent Tamura.
1815
1816         [Chromium] Add WebThemeEngineDRTMac so that Chromium DRT scrollbar rendering can match the Mac port's
1817         https://bugs.webkit.org/show_bug.cgi?id=51728
1818         
1819         Add implementation of the Mac WebThemeEngine that uses an NSScroller
1820         to render top-level scrollbars. This makes them match the Mac port's
1821         use of an NSScrollView, which means that we'll be able to share more
1822         pixel baselines.
1823         
1824         The new rendering code will not be activated until the 
1825         USE_WEB_THEME_ENGINE_TO_PAINT_THUMB #define is fliped in
1826         ScrollbarThemeChromiumMac.
1827
1828         * DumpRenderTree/DumpRenderTree.gypi:
1829         * DumpRenderTree/chromium/TestShellMac.mm:
1830         (platformInit):
1831         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Added.
1832         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Added.
1833         (+[FakeActiveWindow alwaysActiveWindow]):
1834         (+[FakeActiveWindow alwaysInactiveWindow]):
1835         (-[FakeActiveWindow initWithActiveControls:]):
1836         (-[FakeActiveWindow _hasActiveControls]):
1837         (WebThemeEngineDRTMac::paintScrollbarThumb):
1838         (stateToHIEnableState):
1839         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
1840         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
1841
1842 2010-12-30  Konstantin Tokarev  <annulen@yandex.ru>
1843
1844         Reviewed by David Kilzer.
1845
1846         [Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is
1847         used
1848         https://bugs.webkit.org/show_bug.cgi?id=51672
1849
1850         * DumpRenderTree/qt/DumpRenderTree.pro: Replaced USE_SYSTEM_MALLOC
1851         with USE_SYSTEM_MALLOC=1
1852         * WebKitTestRunner/qt/WebKitTestRunner.pro: Replaced USE_SYSTEM_MALLOC
1853         with USE_SYSTEM_MALLOC=1
1854
1855 2010-12-30  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1856
1857         Reviewed by David Kilzer.
1858
1859         [Qt] [Symbian] Fix build-webkit script for Symbian
1860         https://bugs.webkit.org/show_bug.cgi?id=51509
1861
1862         Set the OUTPUT_DIR for Symbian to be the same as the source
1863         directory.
1864
1865         * Scripts/webkitdirs.pm:
1866
1867 2010-12-30  Martin Robinson  <mrobinson@igalia.com>
1868
1869         Reviewed by Darin Adler.
1870
1871         check-webkit-style should ignore NULL usage in calls to gtk_widget_style_get
1872         https://bugs.webkit.org/show_bug.cgi?id=51758
1873
1874         Add a check-webkit-style exception for gtk_widget_style_get and NULL usage.
1875
1876         * Scripts/webkitpy/style/checkers/cpp.py: Add the exception.
1877         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
1878
1879 2010-12-29  Patrick Gansterer  <paroga@webkit.org>
1880
1881         Unreviewed WinCE buildfix.
1882
1883         * WinCELauncher/main.cpp: Add missing include.
1884
1885 2010-12-29  Daniel Bates  <dbates@rim.com>
1886
1887         Reviewed by Darin Adler.
1888
1889         svn-apply updates date of wrong change log entry for a change log diff that
1890         contains two consecutive entries with the same author and date
1891         https://bugs.webkit.org/show_bug.cgi?id=46061
1892
1893         Fixes an issue where the date of the wrong change log entry may be modified.
1894         Moreover, changes fixChangeLogPatch() to move entries inserted earlier
1895         in a ChangeLog file to the top of the file.
1896
1897         Currently, fixChangeLogPatch() explicitly bails out and returns an unchanged
1898         diff when it detects that the diff inserts a change log entry earlier in a
1899         ChangeLog. It is unusual to land a patch that has such a deliberate ChangeLog
1900         change. With the advent of the commit-queue this functionality of bailing out
1901         and hence landing the patch as-is is harmful to the accuracy of the ChangeLog.
1902         Instead, we should always move the change log entry to the top of the ChangeLog file.
1903
1904         A side-effect of this change is that setChangeLogDateAndReviewer() now updates
1905         the date line of the correct change log entry in a ChangeLog diff.
1906
1907         * Scripts/VCSUtils.pm: Modified fixChangeLogPatch() to move entries inserted earlier to the top.
1908
1909         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
1910           Updated the following unit tests now that we move entries inserted earlier to the top:
1911           - "fixChangeLogPatch: New entry inserted in middle."
1912             (formerly named "fixChangeLogPatch: [no change] New entry inserted in middle.")
1913
1914           - "fixChangeLogPatch: New entry inserted earlier in the file, but after an entry with the same author and date."
1915             (formerly named "fixChangeLogPatch: [no change] New entry inserted earlier in the file, but after an entry with the same author and date.")
1916
1917         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl: Added.
1918
1919 2010-12-29  Konstantin Tokarev  <annulen@yandex.ru>
1920
1921         Reviewed by Eric Seidel.
1922
1923         [Qt] Fixed compatibility with gold linker on X11 platforms
1924         https://bugs.webkit.org/show_bug.cgi?id=51700
1925
1926         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1927         Linked TestNetscapePlugin with libX11 on Unix platforms
1928
1929 2010-12-29  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
1930
1931         Reviewed by Darin Adler.
1932
1933         Circular dependency in webkitpy.common.checkout.changelog module
1934         https://bugs.webkit.org/show_bug.cgi?id=50475
1935
1936         Remove automatic import of api.Checkout module when any checkout/
1937         submodule is imported (e.g.: when checkout.scm.Git is imported).
1938
1939         * Scripts/webkitpy/common/checkout/__init__.py:
1940
1941 2010-12-29  Martin Robinson  <mrobinson@igalia.com>
1942
1943         Reviewed by Ojan Vafai.
1944
1945         prepare-ChangeLog should support the -g option for specifying the git-commit
1946         https://bugs.webkit.org/show_bug.cgi?id=51708
1947
1948         Add a -g shortcut for the --git-commit prepare-ChangeLog option. This matches
1949         webkit-patch, though the exact meaning of the two options remain different.
1950
1951         * Scripts/prepare-ChangeLog: Add -g.
1952
1953 2010-12-29  Kent Hansen  <kent.hansen@nokia.com>
1954
1955         Reviewed by Simon Hausmann.
1956
1957         [Qt] Fix compilation with Qt in namespace
1958         https://bugs.webkit.org/show_bug.cgi?id=51701
1959
1960         * QtTestBrowser/webview.h:
1961
1962 2010-12-28  Daniel Bates  <dbates@rim.com>
1963
1964         Reviewed by Sam Weinig.
1965
1966         Substitute // MARK: for compiler-specific #pragma mark
1967         https://bugs.webkit.org/show_bug.cgi?id=51657
1968
1969         Fix future compilation warnings about "#pragma mark" on GTK+ bots by
1970         substituting  "// MARK:" for "#pragma mark", which provides
1971         analogous code-bookmarking functionality under Xcode.
1972
1973         Also, for consistency, we should substitute "// MARK:" for compiler-
1974         specific "#pragma mark" in the source files for the Mac port.
1975
1976         * DumpRenderTree/AccessibilityTextMarker.cpp:
1977         * DumpRenderTree/cf/WebArchiveDumpSupport.h:
1978         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
1979         * DumpRenderTree/mac/ObjCController.m:
1980         * MiniBrowser/mac/AppDelegate.m:
1981         * MiniBrowser/mac/BrowserWindowController.m:
1982
1983 2010-12-28  Xan Lopez  <xlopez@igalia.com>
1984
1985         Reviewed by Eric Seidel.
1986
1987         Add --no-build option to run-sunspider
1988         https://bugs.webkit.org/show_bug.cgi?id=51658
1989
1990         * Scripts/run-sunspider: add --no-build flag to skip building
1991         phase.
1992
1993 2010-12-27  Daniel Bates  <dbates@rim.com>
1994
1995         Rubber-stamped by Martin Robinson.
1996
1997         Append the directory Tools/DumpRenderTree to the list of directories that
1998         do-webcore-rename should search so that it can rename DRT files and
1999         source code.
2000
2001         * Scripts/do-webcore-rename:
2002
2003 2010-12-27  Eric Seidel  <eric@webkit.org>
2004
2005         Reviewed by Adam Barth.
2006
2007         build-webkit should detect missing Java SDK and explain how to install it
2008         https://bugs.webkit.org/show_bug.cgi?id=51651
2009
2010         * Scripts/build-webkit:
2011
2012 2010-12-26  Martin Robinson  <mrobinson@igalia.com>
2013
2014         Reviewed by Daniel Bates.
2015
2016         [GTK] Add support for build-jsc
2017         https://bugs.webkit.org/show_bug.cgi?id=51625
2018
2019         Add GTK+ support to build-jsc now that building the jsc executable as
2020         a standalone target is easy.
2021
2022         * Scripts/build-jsc: Call buildGtkProject for the GTK+ case now.
2023         * Scripts/build-webkit: Pass in the proper target name to buildGtkProject.
2024         * Scripts/webkitdirs.pm: Actually process the project parameter in buildGtkProject
2025         and pass it along to buildAutotoolsProject.
2026
2027 2010-12-27  David Levin  <levin@chromium.org>
2028
2029         Reviewed by Eric Seidel.
2030
2031         check-webkit-style check for meaningless variable names in function declarations.
2032         https://bugs.webkit.org/show_bug.cgi?id=51523
2033
2034         * Scripts/webkitpy/style/checker.py: Exempted JavaScriptCore/jit/JITStubs.cpp
2035         from the new check and whitespace/parens because the syntax is unusual and
2036         produced a fair number of positives for these checks.
2037         * Scripts/webkitpy/style/checkers/cpp.py:
2038         (_convert_to_lower_with_underscores): Used as a canonical form for type names
2039         and parameter names when determining if the parameter name is useless.
2040         (_create_acronym): Used to check for redundant variable names in cases like "ExceptionCode ec"
2041         (Parameter.lower_with_underscores_name): Gives back the parameter name in a lower_with_underscore
2042         format.
2043         (_check_parameter_name_against_text):  Checks to see if the parameter name is in the
2044         text or an acronym of it.
2045         (check_function_definition): Checks function definitions for meaningless variable names.
2046         (process_line): Added call to check_function_definition.
2047         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2048         (CppFunctionsTest.test_convert_to_lower_with_underscores): Test for _convert_to_lower_with_underscores.
2049         (CppFunctionsTest.test_create_acronym): Test for _create_acronym.
2050         (CppFunctionsTest.test_check_parameter_against_text): Test for _check_parameter_against_text.
2051         (CppStyleTestBase.perform_single_line_lint): Removed the parameter name check
2052         because when only checking a snippet, there are a lot of bogus functions.
2053         (CppStyleTestBase.perform_multi_line_lint): Ditto and removed a bogus filter
2054         that I put there previously and just noticed.
2055         (WebKitStyleTest.test_parameter_names): Tests for the functionality -- both
2056         check_function_definition and process_line.
2057
2058 2010-12-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2059
2060         Reviewed by Martin Robinson.
2061
2062         [GTK] Disable flash plugin in GtkLauncher when using gtk3
2063         https://bugs.webkit.org/show_bug.cgi?id=51591
2064
2065         Flash plugin uses gtk2 that is incompatible with gtk3 making
2066         webkit crash when it's built with gtk3.
2067
2068         * GtkLauncher/main.c:
2069         (main):
2070
2071 2010-12-25  Adam Barth  <abarth@webkit.org>
2072
2073         Reviewed by Eric Seidel.
2074
2075         Move ANGLE to Sources/ThirdParty
2076         https://bugs.webkit.org/show_bug.cgi?id=51605
2077
2078         * Scripts/build-webkit:
2079           - Point to the new ANGLE location.
2080
2081 2010-12-26  David Levin  <levin@chromium.org>
2082
2083         Reviewed by Eric Seidel.
2084
2085         check-webkit-style should be able to parse function declaration parameters.
2086         https://bugs.webkit.org/show_bug.cgi?id=51451
2087
2088         * Scripts/webkitpy/style/checkers/cpp.py:
2089         (Position.__init__): Holds simple position information (row, column).
2090         (Parameter.__init__): Holds information about a parameter.
2091         (SingleLineView.__init): Converts multiple lines into a single line for simpler searches.
2092         (SingleLineView.convert_column_to_row): Returns the original row given a column.
2093         (create_skeleton_parameters): Simplifies a parameter list for easier searching.
2094         (find_parameter_name_index): Finds where the parameter name is.
2095         (parameter_list): Generates the list of parameters for a function.
2096         (_FunctionState.begin): Added information to allow determining the parameters
2097         on demand.
2098         (_FunctionState.get_parameter_list): Returns a tuple of function parameters.
2099         (detect_functions): Improve function detection for operator functions and
2100         determine where the parameters end and pass that to _FunctionState.begin.
2101         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2102         (CppFunctionsTest.test_parameter): Verifies Parameter functionality.
2103         (CppFunctionsTest.test_single_line_view): Verifies SingleLineView functionality.
2104         (CppFunctionsTest.test_create_skeleton_parameters): Verifies create_skeleton_parameters.
2105         (CppFunctionsTest.test_find_parameter_name_index): Verifies find_parameter_name_index.
2106         (CppFunctionsTest.test_parameter_list): Does some minimal verification for parameter list.
2107         Much more thorough verification is done as part of FunctionDetectionTest.test_parameter_list.
2108         (FunctionDetectionTest.perform_function_detection): Added support for verifying
2109         the parameters found.
2110         (FunctionDetectionTest.test_function_declaration_detection): Added more function
2111         detection test to verify that we catch the operator functions.
2112         (FunctionDetectionTest.test_ignore_macros): Verify that function detection ignores macros.
2113         (FunctionDetectionTest.test_parameter_list): Added tests to verify the parameter parsing.
2114         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Removed
2115         because the error. The test is about the bad function name. Fixing the name makes the test exactly like
2116         test_function_length_check_definition_severity1_for_test.
2117
2118 2010-12-25  Patrick Gansterer  <paroga@webkit.org>
2119
2120         Unreviewed WinCE buildfix after r74334.
2121
2122         * CMakeListsWinCE.txt:
2123
2124 2010-12-24  Sheriff Bot  <webkit.review.bot@gmail.com>
2125
2126         Unreviewed, rolling out r74632.
2127         http://trac.webkit.org/changeset/74632
2128         https://bugs.webkit.org/show_bug.cgi?id=51600
2129
2130         makes test-webkitpy hang forever on GTK (Requested by philn-tp
2131         on #webkit).
2132
2133         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2134         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2135
2136 2010-12-24  Ryuan Choi  <ryuan.choi@samsung.com>
2137
2138         Reviewed by Kenneth Rohde Christiansen.
2139
2140         [EFL] Screen doesn't be rendered when changing size of EWebLauncher
2141         https://bugs.webkit.org/show_bug.cgi?id=43528
2142
2143         Remove on_resize because ewk_view_fixed_layout_size_set should not be
2144         called on callback of EVAS_CALLBACK_RESIZE. As it change size of
2145         FrameView, rendering was ignored when _ewk_view_smart_calculate was
2146         called.
2147
2148         * EWebLauncher/main.c:
2149         (browserCreate):
2150
2151 2010-12-24  Eric Seidel  <eric@webkit.org>
2152
2153         Reviewed by Adam Barth.
2154
2155         webkit-patch (or a pre-commit hook) needs to prevent bad ChangeLog changes
2156         https://bugs.webkit.org/show_bug.cgi?id=28291
2157
2158         This is a start.  At least now webkit-patch will prompt when your ChangeLog looks questionable.
2159         We could do more advanced things, like parsing the ChangeLog (with changelog.py) and comparing that
2160         to strings with find in the diff.
2161         Since non-interactive always returns the default, this should cause patches with bad changelogs to fail on the commit-queue.
2162
2163         * Scripts/webkitpy/common/checkout/api.py:
2164         * Scripts/webkitpy/common/checkout/diff_parser.py:
2165         * Scripts/webkitpy/tool/steps/abstractstep.py:
2166         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
2167         * Scripts/webkitpy/tool/steps/validatechangelogs.py: Copied from Tools/Scripts/webkitpy/tool/steps/validatereviewer.py.
2168         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
2169         * Scripts/webkitpy/tool/steps/validatereviewer.py:
2170
2171 2010-12-24  Dirk Pranke  <dpranke@chromium.org>
2172
2173         Reviewed by Kenneth Russell.
2174
2175         Modify new-run-webkit-tests to shut up and exit when all the threads
2176         are wedged so that test runs complete faster and we don't end up
2177         w/ enormous log files.
2178
2179         https://bugs.webkit.org/show_bug.cgi?id=51572
2180
2181         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2182         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2183
2184 2010-12-24  Eric Seidel  <eric@webkit.org>
2185
2186         Reviewed by David Levin.
2187
2188         commit-queue should better explain how it will re-open bugs and follow duplicate chains
2189         https://bugs.webkit.org/show_bug.cgi?id=51549
2190
2191         I've had multiple people ask me about the commit-queue's behavior
2192         regarding reporting flaky tests.  I figured it would be best to just
2193         have the queue explain itself in the bugs it files.
2194
2195         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2196         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2197
2198 2010-12-24  Shinichiro Hamaji  <hamaji@chromium.org>
2199
2200         Reviewed by Eric Seidel.
2201
2202         check-webkit-style: should ignore "wrong" namings in JavaScriptCore/qt
2203         https://bugs.webkit.org/show_bug.cgi?id=51467
2204
2205         * Scripts/webkitpy/style/checker.py:
2206         * Scripts/webkitpy/style/checker_unittest.py:
2207
2208 2010-12-23  Adam Barth  <abarth@webkit.org>
2209
2210         Rubber-stamped by Eric Seidel.
2211
2212         Move JavaScriptGlue into Sources
2213         https://bugs.webkit.org/show_bug.cgi?id=51583
2214
2215         These tools refer to JavaScriptGlue and need to be updated to its new
2216         location.
2217
2218         * Scripts/build-webkit:
2219         * Scripts/do-file-rename:
2220         * Scripts/do-webcore-rename:
2221         * Scripts/webkitpy/common/config/build.py:
2222         * Scripts/webkitpy/common/config/build_unittest.py:
2223
2224 2010-12-23  Lucas Forschler  <lforschler@apple.com>
2225
2226         Reviewed by Eric Seidel.
2227
2228         Bug 51539 - update iexploder scripts to point to new location
2229
2230         * Scripts/run-iexploder-tests:
2231         * Scripts/update-iexploder-cssproperties:
2232
2233 2010-12-23  Evan Martin  <evan@chromium.org>
2234
2235         Reviewed by Ryosuke Niwa.
2236
2237         [chromium] LayoutTestController warning in float->int conversion
2238         https://bugs.webkit.org/show_bug.cgi?id=51553
2239
2240         Rather than reading an int, converting to a float, then getting a compiler
2241         warning on passing the float to something that expects an int, instead
2242         just pass around ints.
2243
2244         No tests, fixes a compiler warning.
2245
2246         * DumpRenderTree/chromium/LayoutTestController.cpp:
2247         (parsePageSizeParameters):
2248         (LayoutTestController::pageNumberForElementById):
2249         (LayoutTestController::numberOfPages):
2250
2251 2010-12-23  Lucas Forschler  <lforschler@apple.com>
2252
2253         Reviewed by Darin Adler.
2254
2255         Bug 51537 - iexploder needs cleanup
2256         
2257         * iExploder/htdocs: Removed.
2258         * iExploder/htdocs/config.rb: Removed.
2259         * iExploder/htdocs/cssproperties.in: Removed.
2260         * iExploder/htdocs/cssvalues.in: Removed.
2261         * iExploder/htdocs/htmlattrs.in: Removed.
2262         * iExploder/htdocs/htmltags.in: Removed.
2263         * iExploder/htdocs/htmlvalues.in: Removed.
2264         * iExploder/htdocs/iexploder.cgi: Removed.
2265         * iExploder/htdocs/iexploder.rb: Removed.
2266         * iExploder/htdocs/index.html: Removed.
2267         * iExploder/htdocs/webserver.rb: Removed.
2268         * iExploder/iexploder-1.7.2/output: Removed.
2269         * iExploder/tools: Removed.
2270         * iExploder/tools/lasthit.rb: Removed.
2271         * iExploder/tools/osx_last_crash.rb: Removed.
2272         * iExploder/tools/showtest.rb: Removed.
2273
2274 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2275
2276         Reviewed by Kenneth Rohde Christiansen.
2277
2278         [EFL] Make 'single' the default backing store in EWebLauncher
2279         https://bugs.webkit.org/show_bug.cgi?id=51534
2280
2281         'single' is the simplest backing store and the one intended to be the
2282         default in the test browser. By mistake the tiled backing store was
2283         left as default in r72617.
2284
2285         * EWebLauncher/main.c:
2286         (browserCreate): ditto.
2287
2288 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2289
2290         Reviewed by Kenneth Rohde Christiansen.
2291
2292         [EFL] Subject: [webkit 4/4] [EFL] Remove non-sense workaround
2293         https://bugs.webkit.org/show_bug.cgi?id=51533
2294
2295         There's no point in concatenating env("HOME") with "blah", so remove
2296         option from EWebLauncher.
2297
2298         * EWebLauncher/main.c:
2299         (main): ditto.
2300
2301 2010-12-23  Ilya Tikhonovsky  <loislo@chromium.org>
2302
2303         Reviewed by Eric Seidel.
2304
2305         Web Inspector: chromium: inspector's tests are quite slow especially at windows(Debug).
2306
2307         Almost all inspector's tests become flaky on chromium Win(dbg) after switching to DRT.
2308         I just discovered that we have two additional GC runs per each WebViewHost.
2309         Test_shell had no such calls.
2310         These gc runs eat 15% of cpu time.
2311
2312         https://bugs.webkit.org/show_bug.cgi?id=51479
2313
2314         * DumpRenderTree/chromium/WebViewHost.cpp:
2315         (WebViewHost::~WebViewHost):
2316
2317 2010-12-22  Dirk Pranke  <dpranke@chromium.org>
2318
2319         Reviewed by Ojan Vafai.
2320
2321         This change splits out the TestRunner class into its own file.
2322         When we fork the code for message passing, we will create a new
2323         TestRunner, and this change will allow that to be more modular.
2324
2325         While we're at it, split out TestInput and ResultSummary into
2326         their own files, to reduce the size of run_webkit_tests to
2327         something more managable.
2328
2329         https://bugs.webkit.org/show_bug.cgi?id=51092
2330
2331         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2332         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
2333         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2334         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
2335         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
2336         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2337         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2338
2339  2010-12-22  Dirk Pranke  <dpranke@chromium.org>
2340
2341         Reviewed by Ojan Vafai.
2342
2343         nrwt multiprocessing - start over, prepare to fork the code
2344  
2345         This code cleans up the signatures and implementation of the
2346         TestRunner class so we can easily fork it to run either the
2347         stable implementation or the new, unstable message-passing
2348         implementation. The two variants will have different
2349         implementations of the run_tests() method. We will switch
2350         between the two based on the setting for the '--worker-model'
2351         switch. We rename the two currently valid values to 'old-inline'
2352         and 'old-threads'.
2353
2354         https://bugs.webkit.org/show_bug.cgi?id=51081
2355
2356         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2357         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2358
2359 2010-12-22  Victor Wang  <victorw@chromium.org>
2360
2361         Reviewed by Darin Fisher.
2362
2363         [Chromium] Update chromium archive test result url in rebaseline script.
2364
2365         https://bugs.webkit.org/show_bug.cgi?id=51503
2366
2367         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2368
2369 2010-12-22  Lucas Forschler  <lforschler@apple.com>
2370
2371         Reviewed by Alice Liu.
2372
2373         <rdar://problem/8633222> record-memory-win needs to record memory used by the webprocess.
2374         Verified on Chrome, Safari, and IE.
2375         With this change, we will record memory from a parent browser window and all child processes.
2376
2377         * record-memory-win/main.cpp:
2378         (ProcessArgs):
2379         (PrintUsage):
2380         (getMemoryInfo):
2381         (printProcessInfo):
2382         (evalProcesses):
2383         (UseImage):
2384         (QueryContinuously):
2385         (ElapsedTime):
2386
2387 2010-12-22  Lucas Forschler  <lforschler@apple.com>
2388
2389         Unreviewed rollout r74489, because it was missing changelog.
2390
2391         * record-memory-win/main.cpp:
2392         
2393 2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>
2394
2395         Adding myself as a reviewer.
2396
2397         * Scripts/webkitpy/common/config/committers.py:
2398
2399 2010-12-22  Andrew Scherkus  <scherkus@chromium.org>
2400
2401         Unreviewed.  Adding myself to committers.py.
2402
2403         * Scripts/webkitpy/common/config/committers.py:
2404
2405 2010-12-22  Ariya Hidayat  <ariya@sencha.com>
2406
2407         Reviewed by Kenneth Rohde Christiansen.
2408
2409         TestNetscapePlugIn should use #if defined
2410         https://bugs.webkit.org/show_bug.cgi?id=51471
2411
2412         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2413         (NP_Initialize):
2414         (NPP_New):
2415
2416 2010-12-22  Ilya Tikhonovsky  <loislo@chromium.org>
2417
2418         Reviewed by Yury Semikhatsky.
2419
2420         Web Inspector: [chromium] DRT inspector layout tests are flaky in debug.
2421
2422         DevTools window should be closed explicitly because it has custom deinitialization code.
2423
2424         https://bugs.webkit.org/show_bug.cgi?id=50722
2425
2426         * DumpRenderTree/chromium/TestShell.cpp:
2427         (TestShell::closeRemainingWindows):
2428
2429 2010-12-22  David Levin  <levin@chromium.org>
2430
2431         Reviewed by Shinichiro Hamaji.
2432
2433         check-webkit-style shouldn't complaint about underscores in variables in objective C files.
2434         https://bugs.webkit.org/show_bug.cgi?id=51452
2435
2436         * Scripts/webkitpy/style/checkers/cpp.py:
2437         (_FileState.__init__): Added the information to determine if a file is C or Objective C.
2438         Using the file extension if possible but falling back to the file contents if we have a header file.
2439         (_FileState.is_objective_c): Determine if we have an Objective C by examining the file contents if needed.
2440         (_FileState.is_c_or_objective_c):
2441         (check_using_std): Changed to using _FileState to determine the file type.
2442         (check_max_min_macros): Ditto.
2443         (check_for_null): Ditto.
2444         (check_style): Changed the parameters to various calls since they now need _FileState
2445         to determine the file type.
2446         (check_language): Added the file_state parameter so it could be passed
2447         to check_identifier_name_in_declaration.
2448         (check_identifier_name_in_declaration): Don't warn about underscores in variables if
2449         this is an Objective C file.
2450         (_process_lines): Added information for the _FileState constructor (and moved the
2451         call to a place that had the information).
2452         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2453         (CppFunctionsTest.test_is_c_or_objective_c): Changed the tests to use FileState and exercise
2454         its functionality.
2455         (WebKitStyleTest.test_names): Add tests for underscores in Objective C files.
2456
2457 2010-12-21  Andy Estes  <aestes@apple.com>
2458
2459         Reviewed by Mark Rowe.
2460
2461         Do not build non-Intel architectures for WebKit2-related projects.
2462         https://bugs.webkit.org/show_bug.cgi?id=51440
2463
2464         * MiniBrowser/Configurations/Base.xcconfig: Only build for i386 and x86_64.
2465         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
2466         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
2467
2468 2010-12-21  Mihai Parparita  <mihaip@chromium.org>
2469
2470         Reviewed by Darin Fisher.
2471
2472         [Chromium] Rename WebThemeEngine/ControlDRT to WebThemeEngine/ControlDRTWin
2473         https://bugs.webkit.org/show_bug.cgi?id=51406 
2474         
2475         Rename WebThemeControlDRT to WebThemeControlDRTWin and WebThemeEngineDRT
2476         to WebThemeEngineDRTWin and update references everywhere.
2477
2478         * DumpRenderTree/DumpRenderTree.gypi:
2479         * DumpRenderTree/chromium/TestShellWin.cpp:
2480         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.cpp.
2481         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.h.
2482         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.cpp.
2483         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.h.
2484
2485 2010-12-21  Anders Carlsson  <andersca@apple.com>
2486
2487         Reviewed by John Sullivan.
2488
2489         Clicking missing plug-in text does not show a sheet
2490         https://bugs.webkit.org/show_bug.cgi?id=51403
2491
2492         Update for changes to the WebPageUIClient.
2493
2494         * MiniBrowser/mac/BrowserWindowController.m:
2495         (-[BrowserWindowController awakeFromNib]):
2496         * WebKitTestRunner/TestController.cpp:
2497         (WTR::createOtherPage):
2498         (WTR::TestController::initialize):
2499
2500 2010-12-21  Eric Seidel  <eric@webkit.org>
2501
2502         Reviewed by Adam Barth.
2503
2504         commit-queue will report constant failures as flaky if other tests flake
2505         https://bugs.webkit.org/show_bug.cgi?id=51272
2506
2507         This patch just removes functionality and adds testing.
2508         Previously we attempted to report flaky tests when we had
2509         two different tests fail in a row.  However, since we stop
2510         running the tests at the first failure, our code was wrong in
2511         trying to determine flakiness from the incomplete runs.
2512
2513         Originally I posted an alternate patch:
2514         https://bug-51272-attachments.webkit.org/attachment.cgi?id=77078
2515         which fixed our flaky logic in this case, however it was decided
2516         that that patch would be too difficult to maintain, so now
2517         I'm just removing the broken logic.
2518
2519         This will dramatically cut-down on our flaky-test false positives
2520         at the (small) cost of the queues being unable to report
2521         any flakiness if the tree is very flaky.  (With at least one test
2522         flaking on every run, we'll never report failures anymore.)  I think
2523         this is a tradeoff worth making.
2524
2525         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2526         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2527
2528 2010-12-20  Eric Seidel  <eric@webkit.org>
2529
2530         Reviewed by Adam Barth.
2531
2532         commit-queue wrongly rejects patches when it can't update itself
2533         https://bugs.webkit.org/show_bug.cgi?id=46636
2534
2535         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2536         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2537         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2538
2539 2010-12-20  Adam Barth  <abarth@webkit.org>
2540
2541         Move web sites to Websites directory
2542         https://bugs.webkit.org/show_bug.cgi?id=51323
2543
2544         Update references to BugsSite to point to the new location.
2545
2546         This patch was never officially reviewed (because it was too large to
2547         upload to bugs.webkit.org), but it was discussed on webkit-dev and Mark
2548         Rowe gave me the green light.
2549
2550         * Scripts/old-run-webkit-tests:
2551         * Scripts/webkitpy/common/config/build.py:
2552         * Scripts/webkitpy/common/config/build_unittest.py:
2553         * Scripts/webkitpy/common/prettypatch.py:
2554         * Scripts/webkitpy/layout_tests/port/base.py:
2555         * Scripts/webkitpy/style/main.py:
2556
2557 2010-12-20  Adrienne Walker  <enne@google.com>
2558
2559         Unreviewed. Adding myself to the list of committers.
2560
2561         * webkitpy/common/config/committers.py:
2562
2563 2010-12-20  Mark Rowe  <mrowe@apple.com>
2564
2565         Reviewed by Dan Bernstein.
2566
2567         <rdar://problem/8757601> Don't install header files in to the Resources directory.
2568
2569         * Scripts/check-for-inappropriate-files-in-framework: Don't allow .h files in the
2570         Resources directory.
2571
2572 2010-12-20  Eric Seidel  <eric@webkit.org>
2573
2574         Reviewed by Adam Barth.
2575
2576         commit-queue should include bot id when attaching failure diffs
2577         https://bugs.webkit.org/show_bug.cgi?id=51280
2578
2579         This is a tiny change to include the bot id in the name of the attachment.
2580         Most of this diff is just changing the unit test expectations
2581         now that I hid the comment printing when the comment is None.
2582
2583         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2584         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2585         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2586         * Scripts/webkitpy/tool/mocktool.py:
2587
2588 2010-12-20  Jeff Miller  <jeffm@apple.com>
2589
2590         Reviewed by Dan Bernstein.
2591
2592         Tools/vcbin/midl.exe needs to be rebuilt
2593         https://bugs.webkit.org/show_bug.cgi?id=51347
2594
2595         * vcbin/midl.exe: Rebuilt.
2596
2597 2010-12-20  David Levin  <levin@chromium.org>
2598
2599         Reviewed by Ariya Hidayat.
2600
2601         .gitignore and webkit-tools-completion.sh have references to WebKitTools that should be Tools.
2602         https://bugs.webkit.org/show_bug.cgi?id=51343
2603
2604         Follow up from the WebKitTools -> Tools rename.
2605
2606         * Scripts/webkit-tools-completion.sh:
2607
2608 2010-12-20  Cosmin Truta  <ctruta@chromium.org>
2609
2610         Reviewed by James Robinson.
2611
2612         new-run-webkit-tests ignores trailing EOL differences in text tests
2613         https://bugs.webkit.org/show_bug.cgi?id=36983
2614
2615         Changed the handling of new-line characters within new-run-webkit-tests
2616         to match old-run-webkit-tests.  Differences in leading and trailing empty
2617         lines in text expectation files are no longer ignored.
2618
2619         * Scripts/webkitpy/layout_tests/port/base.py:
2620         * Scripts/webkitpy/layout_tests/port/test.py:
2621         Added unit tests.  Removed old duplicate unit test entries.
2622         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2623
2624 2010-12-20  David Levin  <levin@chromium.org>
2625
2626         Reviewed by Shinichiro Hamaji.
2627
2628         check-webkit-style should detect function declarations (and trivial functions).
2629         https://bugs.webkit.org/show_bug.cgi?id=51303
2630
2631         * Scripts/webkitpy/style/checkers/cpp.py:
2632         (_FunctionState.begin): Add is_declaration and changed the line count
2633         start to begin at -1 (which will keep the results consistent, since
2634         the starting line number passed in is one less in this change).
2635         (detect_functions): changed function detection to now catch trivial
2636         functions and declarations.
2637         (check_pass_ptr_usage): Don't check for Pass*Ptr on the first line
2638         of the function as this may look at return values (when processing
2639         a declaration).
2640         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2641         (FunctionDetectionTest.perform_function_detection): Basic mechanics
2642         of testing the function detection.
2643         (FunctionDetectionTest.test_basic_function_detection): Test a simple
2644         function.
2645         (FunctionDetectionTest.test_function_declaration_detection): Test a
2646         declaration.
2647         (FunctionDetectionTest.test_non_functions): A test case for a case
2648         that caused the code to fail due to the { being in quotes.
2649         (PassPtrTest.test_pass_ref_ptr_return_value): Added some more test
2650         cases to help catch false alarms for return values.
2651         (PassPtrTest.test_pass_ref_ptr_member_variable): Ensure that
2652         we don't get false alarms for member variables either.
2653
2654 2010-12-20  Ryuan Choi  <ryuan.choi@samsung.com>
2655
2656         Reviewed by Antonio Gomes.
2657
2658         [CMAKE] Rename WEBKITTOOLS_DIR to TOOLS_DIR
2659         https://bugs.webkit.org/show_bug.cgi?id=51319
2660
2661         * CMakeListsEfl.txt:
2662
2663 2010-12-18  Adam Barth  <abarth@webkit.org>
2664
2665         Reviewed by Sam Weinig.
2666
2667         Move WebKitExamplePlugins to Examples
2668         https://bugs.webkit.org/show_bug.cgi?id=51291
2669
2670         * Scripts/webkitpy/common/config/build.py:
2671
2672 2010-12-17  Csaba Osztrogonác  <ossy@webkit.org>
2673
2674         Unreviewed Qt buildfix after r74301.
2675
2676         Rename WebKitTools to Tools
2677         https://bugs.webkit.org/show_bug.cgi?id=49861
2678
2679         * MiniBrowser/DerivedSources.pro:
2680         * MiniBrowser/qt/MiniBrowser.pro:
2681
2682 2010-12-17  Dan Bernstein  <mitz@apple.com>
2683
2684         Reviewed by Simon Fraser.
2685
2686         Rename WebKitTools to Tools
2687         https://bugs.webkit.org/show_bug.cgi?id=49861
2688
2689         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2690         * CodeCoverage/README:
2691         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2692         (WebCore::DumpRenderTree::initializeFonts):
2693         * EWSTools/start-commit-queue.sh:
2694         * EWSTools/start-queue.sh:
2695         * GNUmakefile.am:
2696         * MIDLWrapper/MIDLWrapper.cpp:
2697         (wmain):
2698         * MiniBrowser/qt/MiniBrowser.pro:
2699         * Scripts/build-api-tests:
2700         * Scripts/build-dumprendertree:
2701         * Scripts/build-webkit:
2702         * Scripts/build-webkittestrunner:
2703         * Scripts/generate-coverage-data:
2704         * Scripts/old-run-webkit-tests:
2705         * Scripts/run-api-tests:
2706         * Scripts/run-iexploder-tests:
2707         * Scripts/run-javascriptcore-tests:
2708         * Scripts/run-mangleme-tests:
2709         * Scripts/run-sunspider:
2710         * Scripts/run-webkit-websocketserver:
2711         * Scripts/sunspider-compare-results:
2712         * Scripts/test-webkitperl:
2713         * Scripts/test-webkitpy:
2714         * Scripts/update-iexploder-cssproperties:
2715         * Scripts/update-webkit:
2716         * Scripts/update-webkit-localizable-strings:
2717         * Scripts/webkitdirs.pm:
2718         * Scripts/webkitpy/common/checkout/scm.py:
2719         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2720         * Scripts/webkitpy/common/config/committervalidator.py:
2721         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
2722         * Scripts/webkitpy/common/config/ports.py:
2723         * Scripts/webkitpy/common/config/ports_unittest.py:
2724         * Scripts/webkitpy/common/system/logutils_unittest.py:
2725         * Scripts/webkitpy/common/system/ospath_unittest.py:
2726         * Scripts/webkitpy/layout_tests/port/chromium.py:
2727         * Scripts/webkitpy/layout_tests/port/config.py:
2728         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2729         * Scripts/webkitpy/layout_tests/port/http_server.py:
2730         * Scripts/webkitpy/layout_tests/port/test.py:
2731         * Scripts/webkitpy/style/checker.py:
2732         * Scripts/webkitpy/style/checker_unittest.py:
2733         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
2734         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2735         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2736         * WebKitTestRunner/DerivedSources.pro:
2737         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2738         (WTR::activateFonts):
2739         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2740         * wx/build/build_utils.py:
2741
2742 2010-12-16  Antonio Gomes  <agomes@rim.com>
2743
2744         Reviewed by Martin Robinson.
2745
2746         Settings::editingBehaviorType() incorrectly returns mac for the gtk build when running tests
2747         https://bugs.webkit.org/show_bug.cgi?id=51163
2748
2749         Since GTK+'s default editing behavior was changed to UNIX in r70975 (see webkitwebsettings.cpp),
2750         GTK+'s DRT should also reset to UNIX after each test execution.
2751
2752         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2753         (resetDefaultsToConsistentValues):
2754
2755 2010-12-17  David Levin  <levin@chromium.org>
2756
2757         Reviewed by Eric Seidel.
2758
2759         check-webkit-style should understand WTF #include guards
2760         https://bugs.webkit.org/show_bug.cgi?id=44911
2761
2762         * Scripts/webkitpy/style/checkers/cpp.py:
2763         (get_header_guard_cpp_variable): modify to suggest the WTF style
2764         of header guard when appropriate.
2765         (check_for_header_guard): handle multiple return values from
2766         get_header_guard_cpp_variable
2767         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2768         (CppStyleTest.test_build_header_guard): Added tests for the WTF
2769         header style.
2770
2771 2010-12-16  David Levin  <levin@chromium.org>
2772
2773         Reviewed by Eric Seidel.
2774
2775         test-webkitpy: unittest for the xml.py checker displays a decprecation warning.
2776         https://bugs.webkit.org/show_bug.cgi?id=51210
2777
2778         The error only shows up when using python 2.6 or later.
2779
2780         * Scripts/webkitpy/style/checkers/xml.py: Replace the usage of
2781         the decprecated field error,message with something equivalent.
2782
2783 2010-12-16  Mihai Parparita  <mihaip@chromium.org>
2784
2785         Reviewed by Eric Seidel.
2786
2787         Add --exit-after-n-failures/crashes to NRWT
2788         https://bugs.webkit.org/show_bug.cgi?id=51160
2789         
2790         Abort test run (in a similar way to how control-C is handled) when
2791         --exit-after-n-failures/crashes-or-timeouts are passed and we've reached
2792         that number of unexpected failures/crashes/timeouts.
2793
2794         * Scripts/webkitpy/layout_tests/port/test.py:
2795         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2796         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2797
2798 2010-12-16  David Levin  <levin@chromium.org>
2799
2800         Reviewed by Shinichiro Hamaji.
2801
2802         check-webkit-style unit tests has some duplicate boilerplate code.
2803         https://bugs.webkit.org/show_bug.cgi?id=49519
2804
2805         * Scripts/webkitpy/style/checkers/cpp.py:
2806         (update_include_state): Replaced the "io" parameter with the global
2807         configuration _unit_test_config. This allowed not calling into
2808         functions at a low level and also not plumbing through the injection
2809         information through many levels of code.
2810         (check_for_include_what_you_use): Ditto.
2811         (process_file_data): Added the ability to set up the unit test config
2812         to allow for injection.
2813         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2814         (ErrorCollector.__init__): Added support for having a filter for errors.
2815         (ErrorCollector.__call__): Ditto.
2816         (CppStyleTestBase.process_file_data): Added the ability to set unit_test_config.
2817         (CppStyleTestBase.perform_lint): Consolidated logic for the perform functions.
2818         (CppStyleTestBase.perform_single_line_lint): Replace specific calls to
2819         functions in the cpp.py with generic processing and a filter that
2820         indicates what errors should be kept.
2821         (CppStyleTestBase.perform_multi_line_lint): Ditto.
2822         (CppStyleTestBase.perform_language_rules_check): Ditto.
2823         (CppStyleTestBase.perform_function_lengths_check): Ditto.
2824         (CppStyleTestBase.perform_pass_ptr_check): Ditto.
2825         (CppStyleTestBase.perform_include_what_you_use): Ditto.
2826         (CppStyleTest.test_multi_line_comments): Added another
2827         error message which applies to the test case.
2828         (CppStyleTest.test_spacing_for_binary_ops): Fixed test
2829         to not have config.h, since it is processed as a header file.
2830         (CppStyleTest.test_static_or_global_stlstrings): Fixed variable name
2831         style and indentation in checked code.
2832         (OrderOfIncludesTest.test_check_preprocessor_in_include_section):
2833         Fixed line number.
2834         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error):
2835         Ditto.
2836
2837 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
2838
2839         Unreviewed, rolling out r74136.
2840         http://trac.webkit.org/changeset/74136
2841         https://bugs.webkit.org/show_bug.cgi?id=51135
2842
2843         r74136 breaks chromium canary bots because some tests are not
2844         rebaselined correctly to resolve EOL differences (Requested by
2845         jianli on #webkit).
2846
2847         * Scripts/webkitpy/layout_tests/port/base.py:
2848         * Scripts/webkitpy/layout_tests/port/test.py:
2849         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2850
2851 2010-12-15  Adam Roben  <aroben@apple.com>
2852
2853         Teach check-webkit-style to check .vcproj and .vsprops files for XML
2854         syntax errors
2855
2856         Fixes <http://webkit.org/b/51103> check-webkit-style should check for
2857         XML syntax errors in .vcproj/.vsprops files
2858
2859         Reviewed by Dave Levin.
2860
2861         * Scripts/webkitpy/style/checker.py: Added lists of file extensions
2862         that should be treated as XML and that should be allowed to contain
2863         carriage returns. (These lists happen to be identical currently.)
2864         (FileType): Added a new XML type.
2865         (CheckerDispatcher.should_check_and_strip_carriage_returns): Added.
2866         Just does a simple file extension check.
2867         (CheckerDispatcher._file_type): Added a case for XML files.
2868         (CheckerDispatcher._create_checker): Ditto. We use XMLChecker for XML
2869         files (surprise!).
2870         (StyleProcessor.process): Ask the dispatcher whether we should pass the
2871         lines through the carriage checker.
2872
2873         * Scripts/webkitpy/style/checker_unittest.py:
2874         (CheckerDispatcherCarriageReturnTest.test_should_check_and_strip_carriage_returns):
2875         Added. Checks a few file names to see if carriage returns are allowed
2876         or not.
2877         (CheckerDispatcherDispatchTest.assert_checker_xml): Added. Similar to
2878         other assert_checker_* functions.
2879         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
2880         test_*_paths functions.
2881         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
2882         test_*_paths functions.
2883         (CheckerDispatcherDispatchTest.test_none_paths): Removed the vcproj
2884         file from this test case, as vcproj files now have a type.
2885         (StyleProcessor_CodeCoverageTest.MockDispatcher.should_check_and_strip_carriage_returns):
2886         Added. Similar to the other should_* functions.
2887         (StyleProcessor_CodeCoverageTest.test_process__carriage_returns_not_stripped):
2888         Added. Checks that carriage returns aren't checked for or stripped for
2889         allowed files.
2890
2891         * Scripts/webkitpy/style/checkers/xml.py: Added.
2892         (XMLChecker.__init__): Simple init method.
2893         (XMLChecker.check): Pass each line through the expat parser, and record
2894         a style error for any errors thrown by the parser.
2895
2896         * Scripts/webkitpy/style/checkers/xml_unittest.py: Added.
2897         (XMLCheckerTest.assert_no_error): Checks that the given XML does not
2898         produce a style error.
2899         (XMLCheckerTest.assert_error): Checks that the given XML produces an
2900         error of the given category on the given line.
2901         (XMLCheckerTest.mock_handle_style_error): Does nothing. Used for
2902         checking that the XMLChecker constructor works properly.
2903         (XMLCheckerTest.test_conflict_marker): Tests that conflict markers
2904         cause a style error (see, e.g., r73887).
2905         (XMLCheckerTest.test_extra_closing_tag): Tests that extra closing tags
2906         cause a style error (see, e.g., r73773).
2907         (XMLCheckerTest.test_init): Tests that the XMLChecker constructor works
2908         properly.
2909         (XMLCheckerTest.test_missing_closing_tag): Tests that missing closing
2910         tags cause a style error (see, e.g., r72795).
2911         (XMLCheckerTest.test_no_error): Tests that valid XML does not cause a
2912         style error.
2913
2914 2010-12-15  Lucas Forschler  <lforschler@apple.com>
2915
2916         Reviewed by Stephanie Lewis.
2917
2918         https://bugs.webkit.org/show_bug.cgi?id=51117
2919         Add a new leopard test bot
2920         really really commit to trunk this time.
2921
2922         * BuildSlaveSupport/build.webkit.org-config/config.json:
2923
2924 2010-12-15  Sam Weinig  <sam@webkit.org>
2925
2926         Reviewed by Anders Carlsson.
2927
2928         WebKit2: Can't add files to an <input type=file>
2929         https://bugs.webkit.org/show_bug.cgi?id=51087
2930
2931         * MiniBrowser/mac/BrowserWindowController.m:
2932         (runOpenPanel):
2933         (-[BrowserWindowController awakeFromNib]):
2934         Add simple implementation of runOpenPanel callback.
2935
2936         * MiniBrowser/win/BrowserView.cpp:
2937         (BrowserView::create):
2938         * WebKitTestRunner/TestController.cpp:
2939         (WTR::createOtherPage):
2940         (WTR::TestController::initialize):
2941         Stub out runOpenPanel callback. 
2942
2943 2010-12-14  Eric Seidel  <eric@webkit.org>
2944
2945         Reviewed by Adam Barth.
2946
2947         commit-queue should upload failure diffs when tests flake
2948         https://bugs.webkit.org/show_bug.cgi?id=51051
2949
2950         To make this testable I needed to pipe FileSystem down onto tool.
2951         We've wanted it there for a long time anyway.
2952
2953         This patch is kinda a big hack.  But we don't have a nice
2954         way to read results.html files.  I think this will need further
2955         revision before this code actually feels clean.
2956
2957         As part of testing this change, I had to make MockBugzilla.create_bug
2958         actually return an id (like it should) which required updating
2959         a few other unit test results (for the better).
2960
2961         The results_matching_keys change in layouttestresults/rebasline
2962         was an alternate path which I decided not to use in the end, but
2963         I left the change as it seemed an improvement.
2964
2965         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2966         * Scripts/webkitpy/common/net/layouttestresults.py:
2967         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2968         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2969         * Scripts/webkitpy/tool/commands/queues.py:
2970         * Scripts/webkitpy/tool/commands/rebaseline.py:
2971         * Scripts/webkitpy/tool/main.py:
2972         * Scripts/webkitpy/tool/mocktool.py:
2973
2974 2010-12-15  Cosmin Truta  <ctruta@chromium.org>
2975
2976         Reviewed by James Robinson.
2977
2978         new-run-webkit-tests ignores trailing EOL differences in text tests
2979         https://bugs.webkit.org/show_bug.cgi?id=36983
2980
2981         Changed the handling of new-line characters within new-run-webkit-tests
2982         to match old-run-webkit-tests.  Differences in leading and trailing empty
2983         lines in text expectation files are no longer ignored.
2984
2985         * Scripts/webkitpy/layout_tests/port/base.py:
2986         * Scripts/webkitpy/layout_tests/port/test.py:
2987         Added unit tests.  Removed old duplicate unit test entries.
2988         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2989
2990 2010-12-15  Ojan Vafai  <ojan@chromium.org>
2991
2992         Reviewed by Adam Barth.
2993
2994         make status-bubble white-space:nowrap so we can measure it's width without wrapping
2995         https://bugs.webkit.org/show_bug.cgi?id=51149
2996
2997         * QueueStatusServer/templates/statusbubble.html:
2998
2999 2010-12-15  Ojan Vafai  <ojan@chromium.org>
3000
3001         Reviewed by Adam Barth.
3002
3003         have the statusbubble postMessage it's metrics so that embedders can properly size the iframe
3004         https://bugs.webkit.org/show_bug.cgi?id=51125
3005
3006         * QueueStatusServer/templates/statusbubble.html:
3007
3008 2010-12-15  Darin Adler  <darin@apple.com>
3009
3010         * Scripts/webkitpy/common/net/buildbot: Added property svn:ignore.
3011
3012 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
3013
3014         Unreviewed, rolling out r74117.
3015         http://trac.webkit.org/changeset/74117
3016         https://bugs.webkit.org/show_bug.cgi?id=51113
3017
3018         This broke the GTK1 build. (Requested by mrobinson on
3019         #webkit).
3020
3021         * Scripts/webkitdirs.pm:
3022
3023 2010-12-15  Amruth Raj  <amruthraj@motorola.com> and Ravi Kasibhatla  <ravi.kasibhatla@motorola.com>
3024
3025         Reviewed by Martin Robinson.
3026
3027         Change generate-forwarding-headers.pl for GTK port usage 
3028         (https://bugs.webkit.org/show_bug.cgi?id=37369)
3029
3030         * Scripts/webkitdirs.pm: Added changes to build webkit2 for GTK port using build-webkit script.
3031
3032 2010-12-14  Kent Tamura  <tkent@chromium.org>
3033
3034         Reviewed by Jian Li.
3035
3036         [DRT/Chromium] Remove another unnecessary error message
3037         https://bugs.webkit.org/show_bug.cgi?id=51083
3038
3039         * DumpRenderTree/chromium/WebViewHost.cpp:
3040         (WebViewHost::didInvalidateRect):
3041
3042 2010-12-14  Lucas Forschler  <lforschler@apple.com>
3043
3044         Reviewed by Stephanie Lewis.
3045
3046         Add a new Leopard Debug Test WK2 Bot
3047
3048         * BuildSlaveSupport/build.webkit.org-config/config.json:
3049
3050 2010-12-14  Ojan Vafai  <ojan@chromium.org>
3051
3052         Fix python unittests after http://trac.webkit.org/changeset/74070.
3053
3054         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
3055
3056 2010-12-14  Kent Tamura  <tkent@chromium.org>
3057
3058         Reviewed by Jian Li.
3059
3060         [DRT/Chromium] Remove a unnecessary error message
3061         https://bugs.webkit.org/show_bug.cgi?id=51069
3062
3063         * DumpRenderTree/chromium/WebViewHost.cpp:
3064         (WebViewHost::paintInvalidatedRegion):
3065
3066 2010-12-14  Benjamin Kalman  <kalman@chromium.org>
3067
3068         Reviewed by Ojan Vafai.
3069
3070         Using BUG/BUGWK in test_expectations is error prone, should use BUGCR/BUGWK
3071         https://bugs.webkit.org/show_bug.cgi?id=48926
3072
3073         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3074         Add presubmit check that BUG isn't used, either BUGCR/BUGWK/BUGV8_.
3075
3076 2010-12-14  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3077
3078         Reviewed by Eric Seidel.
3079
3080         [Qt] [Symbian] Do not use pkg-config on Symbian as it is not supported
3081         https://bugs.webkit.org/show_bug.cgi?id=50231
3082
3083         Guard CONFIG+=link_pkgconfig with !symbian.
3084
3085         * DumpRenderTree/qt/DumpRenderTree.pro:
3086         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3087         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3088
3089 2010-12-14  Philippe Normand  <pnormand@igalia.com>
3090
3091         Reviewed by Ojan Vafai.
3092
3093         [new-run-webkit-tests] expectations parsing is slow
3094         https://bugs.webkit.org/show_bug.cgi?id=50635
3095
3096         Avoid expensive iteration of all the tests when checking if a test
3097         file is to be skipped or not.
3098
3099         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3100         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
3101         * Scripts/webkitpy/layout_tests/port/test.py:
3102
3103 2010-12-14  Mario Sanchez Prada  <msanchez@igalia.com>
3104
3105         Reviewed by Xan Lopez.
3106
3107         [Gtk] Implement STATE_FOCUSED, STATE_FOCUSABLE, and corresponding events for text objects
3108         https://bugs.webkit.org/show_bug.cgi?id=27048
3109
3110         Add support in DRT for checking whether an accessibility UI
3111         element is focusable and/or focused. Implemented for GTK.
3112
3113         * DumpRenderTree/AccessibilityUIElement.cpp:
3114         (getIsFocusedCallback): New.
3115         (getIsFocusableCallback): New.
3116         (AccessibilityUIElement::getJSClass): Add the new available
3117         callbacks for isFocused and isFocusable.
3118         * DumpRenderTree/AccessibilityUIElement.h:
3119         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3120         (AccessibilityUIElement::isFocused): New, implemented by checking
3121         whether the related AtkState value is in the object's state set.
3122         (AccessibilityUIElement::isFocusable): Ditto.
3123         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3124         (AccessibilityUIElement::isFocused): New, dummy implementation.
3125         (AccessibilityUIElement::isFocusable): Ditto.
3126         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3127         (AccessibilityUIElement::isFocused): Ditto.
3128         (AccessibilityUIElement::isFocusable): Ditto.
3129
3130 2010-12-14  Eric Seidel  <eric@webkit.org>
3131
3132         Reviewed by Ojan Vafai.
3133
3134         webkit-patch should warn users when they're using a 32-bit git on a 64-bit system
3135         https://bugs.webkit.org/show_bug.cgi?id=50715
3136
3137         This patch makes webkit-patch print the following:
3138
3139         Warning: This machine is 64-bit, but the git binary (/usr/local/git/bin/git) does not support 64-bit.
3140         Install a 64-bit git for better performance, see:
3141         https://lists.webkit.org/pipermail/webkit-dev/2010-December/015249.html
3142
3143         I wrote this mostly because I have approximately 8 machines that I use
3144         and making sure each one is using a good Git install seemed folly.
3145         webkit-patch makes a lot of git calls, so using a fast git can shave
3146         several seconds in every invocation.  See the webkit-dev thread for more info.
3147
3148         This message will print twice during 'webkit-patch upload',
3149         once from webkit-patch and once from check-webkit-style.
3150
3151         Unfortunately there is no good way to test this due to how machine-dependent
3152         the code is.  I considered writing a test for the log message, but it seemed not worth it.
3153
3154         * Scripts/webkitpy/common/checkout/scm.py:
3155
3156 2010-12-13  Eric Seidel  <eric@webkit.org>
3157
3158         Reviewed by Adam Barth.
3159
3160         FlakyTestReporter doesn't understand bots running from multiple email addresses
3161         https://bugs.webkit.org/show_bug.cgi?id=50960
3162
3163         This explains at least one of the dupes of:
3164         https://bugs.webkit.org/show_bug.cgi?id=50863
3165         that we saw filed by the commit-queue this morning.
3166         I think the other one was explained by my previous fix to result counting code.
3167
3168         Since this is really hard to test with a unit test, instead I
3169         create a new (possibly useful in the future) command
3170         which given a layout test path will return you
3171         the one bug which our tools would assume it the flaky test bug.
3172         If some other script wants to use bug-for-test we'll
3173         need to extend it with some options like --create-if-missing or similar.
3174
3175         * Scripts/webkitpy/common/net/bugzilla/bug.py:
3176         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3177         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3178         * Scripts/webkitpy/tool/commands/__init__.py:
3179         * Scripts/webkitpy/tool/commands/bugfortest.py: Added.
3180
3181 2010-12-13  Mihai Parparita  <mihaip@chromium.org>
3182
3183         Reviewed by James Robinson.
3184
3185         Add option to build-webkit to not build WebKit2
3186         https://bugs.webkit.org/show_bug.cgi?id=50988
3187         
3188         Add support for a --no-webkit2 option to build-webkit. It seems to save
3189         ~1 minute from clean builds and ~10 seconds from no-op builds.
3190
3191         * Scripts/build-webkit:
3192
3193 2010-12-13  Lucas Forschler  <lforschler@apple.com>
3194
3195         Reviewed by Dave Kilzer.
3196
3197         Update iexploder from 1.3.2 to 1.7.2
3198         Move 1.3.2 into its own subdir
3199         Add 1.7.2 into its own subdir
3200         update scripts to point to new 1.3.2 location (avoid breaking existing scripts)
3201
3202         * Scripts/run-iexploder-tests:
3203         * Scripts/update-iexploder-cssproperties:
3204         * iExploder/CHANGELOG.txt: Removed.
3205         * iExploder/LICENSE.txt: Removed.
3206         * iExploder/README.txt: Removed.
3207         * iExploder/htdocs: Removed.
3208         * iExploder/iexploder-1.3.2: Added.
3209         * iExploder/iexploder-1.3.2/CHANGELOG.txt: Copied from iExploder/CHANGELOG.txt.
3210         * iExploder/iexploder-1.3.2/LICENSE.txt: Copied from iExploder/LICENSE.txt.
3211         * iExploder/iexploder-1.3.2/README.txt: Copied from iExploder/README.txt.
3212         * iExploder/iexploder-1.3.2/htdocs: Added.
3213         * iExploder/iexploder-1.3.2/htdocs/config.rb: Copied from iExploder/htdocs/config.rb.
3214         * iExploder/iexploder-1.3.2/htdocs/cssproperties.in: Copied from iExploder/htdocs/cssproperties.in.
3215         * iExploder/iexploder-1.3.2/htdocs/cssvalues.in: Copied from iExploder/htdocs/cssvalues.in.
3216         * iExploder/iexploder-1.3.2/htdocs/htmlattrs.in: Copied from iExploder/htdocs/htmlattrs.in.
3217         * iExploder/iexploder-1.3.2/htdocs/htmltags.in: Copied from iExploder/htdocs/htmltags.in.
3218         * iExploder/iexploder-1.3.2/htdocs/htmlvalues.in: Copied from iExploder/htdocs/htmlvalues.in.
3219         * iExploder/iexploder-1.3.2/htdocs/iexploder.cgi: Copied from iExploder/htdocs/iexploder.cgi.
3220         * iExploder/iexploder-1.3.2/htdocs/iexploder.rb: Copied from iExploder/htdocs/iexploder.rb.
3221         * iExploder/iexploder-1.3.2/htdocs/index.html: Copied from iExploder/htdocs/index.html.
3222         * iExploder/iexploder-1.3.2/htdocs/webserver.rb: Copied from iExploder/htdocs/webserver.rb.
3223         * iExploder/iexploder-1.3.2/tools: Added.
3224         * iExploder/iexploder-1.3.2/tools/lasthit.rb: Copied from iExploder/tools/lasthit.rb.
3225         * iExploder/iexploder-1.3.2/tools/osx_last_crash.rb: Copied from iExploder/tools/osx_last_crash.rb.
3226         * iExploder/iexploder-1.3.2/tools/showtest.rb: Copied from iExploder/tools/showtest.rb.
3227         * iExploder/iexploder-1.7.2: Added.
3228         * iExploder/iexploder-1.7.2/ChangeLog.txt: Added.
3229         * iExploder/iexploder-1.7.2/LICENSE.txt: Added.
3230         * iExploder/iexploder-1.7.2/README.txt: Added.
3231         * iExploder/iexploder-1.7.2/output: Added.
3232         * iExploder/iexploder-1.7.2/src: Added.
3233         * iExploder/iexploder-1.7.2/src/browser_harness.rb: Added.
3234         * iExploder/iexploder-1.7.2/src/config.yaml: Added.
3235         * iExploder/iexploder-1.7.2/src/css-atrules: Added.
3236         * iExploder/iexploder-1.7.2/src/css-atrules/mozilla: Added.
3237         * iExploder/iexploder-1.7.2/src/css-atrules/webkit: Added.
3238         * iExploder/iexploder-1.7.2/src/css-properties: Added.
3239         * iExploder/iexploder-1.7.2/src/css-properties/dillo: Added.
3240         * iExploder/iexploder-1.7.2/src/css-properties/gtkhtml: Added.
3241         * iExploder/iexploder-1.7.2/src/css-properties/internet_explorer6: Added.
3242         * iExploder/iexploder-1.7.2/src/css-properties/mozilla: Added.
3243         * iExploder/iexploder-1.7.2/src/css-properties/webkit: Added.
3244         * iExploder/iexploder-1.7.2/src/css-pseudo: Added.
3245         * iExploder/iexploder-1.7.2/src/css-pseudo/mozilla: Added.
3246         * iExploder/iexploder-1.7.2/src/css-pseudo/webkit: Added.
3247         * iExploder/iexploder-1.7.2/src/css-values: Added.
3248         * iExploder/iexploder-1.7.2/src/css-values/dillo: Added.
3249         * iExploder/iexploder-1.7.2/src/css-values/gtkhtml: Added.
3250         * iExploder/iexploder-1.7.2/src/css-values/mozilla: Added.
3251         * iExploder/iexploder-1.7.2/src/css-values/other: Added.
3252         * iExploder/iexploder-1.7.2/src/css-values/webkit: Added.
3253         * iExploder/iexploder-1.7.2/src/headers: Added.
3254         * iExploder/iexploder-1.7.2/src/headers/dillo: Added.
3255         * iExploder/iexploder-1.7.2/src/headers/gtkhtml: Added.
3256         * iExploder/iexploder-1.7.2/src/headers/mozilla: Added.
3257         * iExploder/iexploder-1.7.2/src/headers/webkit: Added.
3258         * iExploder/iexploder-1.7.2/src/html-attrs: Added.
3259         * iExploder/iexploder-1.7.2/src/html-attrs/dillo: Added.
3260         * iExploder/iexploder-1.7.2/src/html-attrs/gtkhtml: Added.
3261         * iExploder/iexploder-1.7.2/src/html-attrs/internet_explorer6: Added.
3262         * iExploder/iexploder-1.7.2/src/html-attrs/mozilla: Added.
3263         * iExploder/iexploder-1.7.2/src/html-attrs/other: Added.
3264         * iExploder/iexploder-1.7.2/src/html-attrs/webkit: Added.
3265         * iExploder/iexploder-1.7.2/src/html-tags: Added.
3266         * iExploder/iexploder-1.7.2/src/html-tags/dillo: Added.
3267         * iExploder/iexploder-1.7.2/src/html-tags/gtkhtml: Added.
3268         * iExploder/iexploder-1.7.2/src/html-tags/mozilla: Added.
3269         * iExploder/iexploder-1.7.2/src/html-tags/other: Added.
3270         * iExploder/iexploder-1.7.2/src/html-tags/webkit: Added.
3271         * iExploder/iexploder-1.7.2/src/html-values: Added.
3272         * iExploder/iexploder-1.7.2/src/html-values/dillo: Added.
3273         * iExploder/iexploder-1.7.2/src/html-values/gtkhtml: Added.
3274         * iExploder/iexploder-1.7.2/src/html-values/mozilla: Added.
3275         * iExploder/iexploder-1.7.2/src/html-values/other: Added.
3276         * iExploder/iexploder-1.7.2/src/html-values/webkit: Added.
3277         * iExploder/iexploder-1.7.2/src/iexploder.cgi: Added.
3278         * iExploder/iexploder-1.7.2/src/iexploder.rb: Added.
3279         * iExploder/iexploder-1.7.2/src/index.html: Added.
3280         * iExploder/iexploder-1.7.2/src/media: Added.
3281         * iExploder/iexploder-1.7.2/src/media/blank.ogg: Added.
3282         * iExploder/iexploder-1.7.2/src/media/blank.snd: Added.
3283         * iExploder/iexploder-1.7.2/src/media/blank.wav: Added.
3284         * iExploder/iexploder-1.7.2/src/media/bug.bmp: Added.
3285         * iExploder/iexploder-1.7.2/src/media/bug.gif: Added.
3286         * iExploder/iexploder-1.7.2/src/media/bug.ico: Added.
3287         * iExploder/iexploder-1.7.2/src/media/bug.jng: Added.
3288         * iExploder/iexploder-1.7.2/src/media/bug.jpg: Added.
3289         * iExploder/iexploder-1.7.2/src/media/bug.png: Added.
3290         * iExploder/iexploder-1.7.2/src/media/bug.svg: Added.
3291         * iExploder/iexploder-1.7.2/src/media/bug.tiff: Added.
3292         * iExploder/iexploder-1.7.2/src/media/bug.xbm: Added.
3293         * iExploder/iexploder-1.7.2/src/media/bug.xpm: Added.
3294         * iExploder/iexploder-1.7.2/src/mime-types: Added.
3295         * iExploder/iexploder-1.7.2/src/mime-types/dillo: Added.
3296         * iExploder/iexploder-1.7.2/src/mime-types/mozilla: Added.
3297         * iExploder/iexploder-1.7.2/src/mime-types/webkit: Added.
3298         * iExploder/iexploder-1.7.2/src/protocols: Added.
3299         * iExploder/iexploder-1.7.2/src/protocols/dillo: Added.
3300         * iExploder/iexploder-1.7.2/src/protocols/gtkhtml: Added.
3301         * iExploder/iexploder-1.7.2/src/protocols/mozilla: Added.
3302         * iExploder/iexploder-1.7.2/src/protocols/webkit: Added.
3303         * iExploder/iexploder-1.7.2/src/scanner.rb: Added.
3304         * iExploder/iexploder-1.7.2/src/version.rb: Added.
3305         * iExploder/iexploder-1.7.2/src/webserver.rb: Added.
3306         * iExploder/iexploder-1.7.2/testcases: Added.
3307         * iExploder/iexploder-1.7.2/testcases/testcase-Linux_x86_64_rv2.0b6pre_Gecko-20100904_Firefox-4.0b6pre-TEST-8375-1_59.html: Added.
3308         * iExploder/iexploder-1.7.2/testcases/testcase-Opera-9.80_Linux_x86_64_en_Presto-2.6.30_Version-10.61-16704-3_108,3.html: Added.
3309         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_Chrome-7.0.529.0-TEST-611-3_36,9.html: Added.
3310         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_hrome-7.0.529.0-TEST-55313622206-3_6,0.html: Added.
3311         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-120813-8_72,56,24,8,0.html: Added.
3312         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-121240-3_81,3.html: Added.
3313         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-4800-5_80,65,15.html: Added.
3314         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-TEST-23583190347-3_15,12.html: Added.
3315         * iExploder/iexploder-1.7.2/tools: Added.
3316         * iExploder/iexploder-1.7.2/tools/lasthit.rb: Added.
3317         * iExploder/iexploder-1.7.2/tools/osx_last_crash.rb: Added.
3318         * iExploder/iexploder-1.7.2/tools/release_src.sh: Added.
3319         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh: Added.
3320         * iExploder/tools: Removed.
3321
3322 2010-12-13  Sam Weinig  <sam@webkit.org>
3323
3324         Reviewed by Anders Carlsson.
3325
3326         Remove associated page concept from WKView constructor
3327         https://bugs.webkit.org/show_bug.cgi?id=50983
3328
3329         Step 1: Remove associate page constructors from WKView and make
3330         all views use the shared namespace for the context.
3331
3332         * TestWebKitAPI/PlatformWebView.h:
3333         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3334         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
3335         * WebKitTestRunner/PlatformWebView.h:
3336         * WebKitTestRunner/TestController.cpp:
3337         (WTR::createOtherPage):
3338         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3339         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3340         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3341
3342 2010-12-13  Sam Weinig  <sam@webkit.org>
3343
3344         Reviewed by Anders Carlsson.
3345
3346         Change the WebKit2 public API so there is no explicit WKPageNamespace object
3347         https://bugs.webkit.org/show_bug.cgi?id=50898
3348
3349         * MiniBrowser/mac/AppDelegate.h:
3350         * MiniBrowser/mac/AppDelegate.m:
3351         * MiniBrowser/mac/BrowserWindowController.h:
3352         * MiniBrowser/mac/BrowserWindowController.m:
3353         * MiniBrowser/win/BrowserView.cpp:
3354         Convert MiniBrowser to not use PageNamespaces.
3355
3356         * TestWebKitAPI/PlatformWebView.h:
3357         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
3358         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
3359         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
3360         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
3361         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
3362         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
3363         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
3364         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
3365         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
3366         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
3367         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
3368         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
3369         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
3370         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3371         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
3372         Convert TestWebKitAPI to not use PageNamespaces.
3373
3374         * WebKitTestRunner/PlatformWebView.h:
3375         * WebKitTestRunner/TestController.cpp:
3376         * WebKitTestRunner/TestController.h:
3377         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3378         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3379         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3380         Convert WebKitTestRunner to not use PageNamespaces.
3381
3382 2010-12-13  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3383
3384         Reviewed by Eric Seidel.
3385
3386         webkit-patch rollout should be able to do multi-revision rollouts
3387         https://bugs.webkit.org/show_bug.cgi?id=33336
3388
3389         Make it possible to pass more than one revision to webkit-patch.
3390
3391         * Scripts/webkitpy/common/checkout/api.py:
3392         * Scripts/webkitpy/common/checkout/changelog.py:
3393         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3394         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
3395         * Scripts/webkitpy/tool/commands/download.py:
3396         * Scripts/webkitpy/tool/commands/download_unittest.py:
3397         * Scripts/webkitpy/tool/mocktool.py:
3398         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
3399         * Scripts/webkitpy/tool/steps/revertrevision.py:
3400
3401 2010-12-13  Eric Seidel  <eric@webkit.org>
3402
3403         Unreviewed.
3404
3405         Teach webkit-patch how to search bugzilla
3406         https://bugs.webkit.org/show_bug.cgi?id=50500
3407
3408         webkit-patch bug-search fails when there is only one result.
3409         Turns out we needed a bit more logic in our result count parsing code.
3410
3411         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3412         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3413
3414 2010-12-13  Antti Koivisto  <antti@apple.com>
3415
3416         Reviewed by Alexey Proskuryakov.
3417
3418         Add setSerializeHTTPLoads function to allow testing resource load order on OS X.
3419         https://bugs.webkit.org/show_bug.cgi?id=50758
3420
3421         * DumpRenderTree/LayoutTestController.cpp:
3422         (setSerializeHTTPLoadsCallback):
3423         (LayoutTestController::staticFunctions):
3424         * DumpRenderTree/LayoutTestController.h:
3425         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3426         (LayoutTestController::setSerializeHTTPLoads):
3427         * DumpRenderTree/mac/DumpRenderTree.mm:
3428         (resetDefaultsToConsistentValues):
3429         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3430         (LayoutTestController::setSerializeHTTPLoads):
3431         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3432         (LayoutTestController::setSerializeHTTPLoads):
3433
3434 2010-12-13  Dimitri Glazkov  <dglazkov@chromium.org>
3435
3436         Reviewed by Ojan Vafai.
3437
3438         Remove "use-drt" option from test step command line, since the option was removed in r73748.
3439         https://bugs.webkit.org/show_bug.cgi?id=50936
3440
3441         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed the option.
3442
3443 2010-12-13  Patrick Gansterer  <paroga@webkit.org>
3444
3445         Reviewed by Csaba Osztrogonác.
3446
3447         Add revlink to BuildBot status
3448         https://bugs.webkit.org/show_bug.cgi?id=50914
3449
3450         This adds a hyperlink to trac changeset on the revision numbers. 
3451
3452         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3453
3454 2010-12-13  Andras Becsi  <abecsi@webkit.org>
3455
3456         Reviewed by Csaba Osztrogonác.
3457
3458         [Qt][WK2] Fix build if WebKitTools are not available
3459         https://bugs.webkit.org/show_bug.cgi?id=50242
3460
3461         * MiniBrowser/qt/MiniBrowser.pro: Correct the comment.
3462         * Scripts/webkitdirs.pm: Added WebKitTools/MiniBrowser to $subdirs.
3463         * MiniBrowser/DerivedSources.pro: Added.
3464
3465 2010-12-13  Eric Seidel  <eric@webkit.org>
3466
3467         Reviewed by Adam Barth.
3468
3469         EWS Queues should remove orpahned pyc files before starting
3470         https://bugs.webkit.org/show_bug.cgi?id=50904
3471
3472         A previous check added a platform.py which caused
3473         EWS bots on some platforms to hit an import exception.
3474         The platform.py file was removed in a subsequent commit, but
3475         the EWS bots in question stayed stuck.  This change will
3476         fix those bots once restarted (and prevent this in the future).
3477
3478         I also went ahead and unified start-queue and start-commit-queue
3479         since they were nearly identical.  I also added bot_id support
3480         to both force all EWSes to have bot ids as well as get rid of the one
3481         remaining reason why I had my own copies of these scripts.
3482         Hopefully this will be enough to get all the other bot admins
3483         (ahem, Adam, ahem) to move to using these checked in copies as well.
3484
3485         * EWSTools/start-commit-queue.sh: Removed.
3486         * EWSTools/start-queue.sh:
3487
3488 2010-10-28  MORITA Hajime  <morrita@google.com>
3489
3490         Reviewed by Ojan Vafai.
3491
3492         spellcheck does not check pasted text
3493         https://bugs.webkit.org/show_bug.cgi?id=40092
3494
3495         Added LayoutTestController::setAsynchronousSpellCheckingEnabled()
3496         to control the setting.
3497
3498         * DumpRenderTree/LayoutTestController.cpp:
3499         (setAsynchronousSpellCheckingEnabledCallback):
3500         (LayoutTestController::staticFunctions):
3501         * DumpRenderTree/LayoutTestController.h:
3502         * DumpRenderTree/chromium/LayoutTestController.h:
3503         * DumpRenderTree/chromium/LayoutTestController.cpp:
3504         (LayoutTestController::LayoutTestController):
3505         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
3506         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3507         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
3508         * DumpRenderTree/mac/DumpRenderTree.mm:
3509         (resetDefaultsToConsistentValues):
3510         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3511         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
3512         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3513         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3514         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
3515         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3516         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
3517         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3518         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
3519
3520 2010-12-12  Sam Weinig  <sam@webkit.org>
3521
3522         Reviewed by Anders Carlsson.
3523
3524         Fix failing API test. It turns out that a pop-state event
3525         is sent before every fragment navigation, so we have to test
3526         for it in addition in PageLoadDidChangeLocationWithinPageForFrame.
3527
3528         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
3529         (TestWebKitAPI::didSameDocumentNavigationForFrame):
3530
3531 2010-12-12  Alejandro G. Castro  <alex@igalia.com>
3532
3533         Reviewed by Eric Seidel.
3534
3535         [GTK] Add new-run-webkit-tests support to gtk
3536         https://bugs.webkit.org/show_bug.cgi?id=50681
3537
3538         Adding the basic support to run the new-run-webkit-tests.
3539
3540         * Scripts/webkitpy/layout_tests/port/gtk.py:
3541
3542 2010-10-11  Diego Gonzalez  <diegohcg@webkit.org>
3543
3544         Reviewed by Kenneth Rohde Christiansen.
3545
3546         [Qt] Mock DeviceOrientation client for DRT
3547         https://bugs.webkit.org/show_bug.cgi?id=47490
3548
3549         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3550         (WebCore::DumpRenderTree::DumpRenderTree):
3551         (WebCore::DumpRenderTree::~DumpRenderTree):
3552         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3553         (LayoutTestController::setMockDeviceOrientation):
3554
3555 2010-12-11  Philippe Normand  <pnormand@igalia.com>
3556
3557         Reviewed by Gustavo Noronha Silva.
3558
3559         [GTK] launcher: disable the Mozilla-style fullscreen API
3560         https://bugs.webkit.org/show_bug.cgi?id=50874
3561
3562         Disabling the fullscreen API until its implementation for GTK is
3563         mature enough. The webview setting for it is already FALSE by
3564         default.
3565
3566         * GtkLauncher/main.c:
3567         (createWindow):
3568
3569 2010-12-10  Eric Seidel  <eric@webkit.org>
3570
3571         Reviewed by Adam Barth.
3572
3573         commit-queue flaky test messages show cryptic version information for mac os x
3574         https://bugs.webkit.org/show_bug.cgi?id=50864
3575
3576         Turns out platform.platform() returns kernel version information
3577         which isn't helpful, and just plain confusing on Mac
3578         (OS X 10.6.5 uses Darwin Kernel 10.5.0).
3579
3580         So I've updated PlatformInfo.display_name() to special case
3581         mac.  I also found a bad use of sys.platform in the process
3582         and fixed that.  (sys.platform always returns 'darwin' on mac).
3583
3584         * Scripts/webkitpy/common/system/platforminfo.py:
3585         * Scripts/webkitpy/common/system/user.py:
3586         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3587         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3588         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3589
3590 2010-12-10  Eric Seidel  <eric@webkit.org>
3591
3592         Unreviewed.
3593
3594         Exception seen while reporting flaky test with commit-queue.
3595         Just a missing include.
3596
3597         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3598         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3599
3600 2010-12-10  Kinuko Yasuda  <kinuko@chromium.org>
3601
3602         Reviewed by Eric Seidel.
3603
3604         [Chromium] Remove old JSONResultsGenerator script that existed for backward-compatibility
3605         https://bugs.webkit.org/show_bug.cgi?id=50796
3606
3607         Also updating the test code to use JSONResultsGeneratorBase and
3608         to improve test coverage for incremental cases.
3609
3610         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3611         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3612
3613 2010-12-10  Joseph Pecoraro  <joepeck@webkit.org>
3614
3615         Reviewed by Darin Adler.
3616
3617         prepare-ChangeLog --help doesn't mention --bug shorthand -b
3618         https://bugs.webkit.org/show_bug.cgi?id=50835
3619
3620         * Scripts/prepare-ChangeLog: be more explicit about -b and match file style.
3621
3622 2010-12-10  Eric Seidel  <eric@webkit.org>
3623
3624         Reviewed by Adam Barth.
3625
3626         Bugs created by the commit-queue should all block on a master bug
3627         https://bugs.webkit.org/show_bug.cgi?id=50857
3628
3629         This makes all bugs created by the commit-queue block on:
3630         https://bugs.webkit.org/show_bug.cgi?id=50856
3631
3632         In the process of testing this, I found that the existing
3633         create_bug code was wrong.  I also found that existing
3634         unit tests for create-rollout used invalid values
3635         for options.blocks.  I fixed both issues and tested.
3636
3637         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3638         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3639         * Scripts/webkitpy/tool/commands/commandtest.py:
3640         * Scripts/webkitpy/tool/commands/download_unittest.py:
3641         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3642         * Scripts/webkitpy/tool/mocktool.py:
3643         * Scripts/webkitpy/tool/steps/options.py:
3644
3645 2010-12-10  Eric Seidel  <eric@webkit.org>
3646
3647         Reviewed by Adam Barth.
3648
3649         Teach webkitpy how to follow duplicate chains when posting comments on flake bugs
3650         https://bugs.webkit.org/show_bug.cgi?id=50853
3651
3652         I also discovered when doing this that the code was posting
3653         the comment on the wrong bug, but that's fixed here too.
3654
3655         * Scripts/webkitpy/common/net/bugzilla/bug.py:
3656         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3657         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3658         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3659         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3660         * Scripts/webkitpy/tool/mocktool.py:
3661
3662 2010-12-10  Anders Carlsson  <andersca@apple.com>
3663
3664         Reviewed by John Sullivan.
3665
3666         Make WKContextGetStatistics gather global statistics
3667         https://bugs.webkit.org/show_bug.cgi?id=50850
3668
3669         Remove the code that gets the statistics and fills in the per context
3670         statistics information for now.
3671
3672         * MiniBrowser/mac/BrowserStatisticsWindowController.m:
3673         (-[BrowserStatisticsWindowController refreshStatistics:]):
3674
3675 2010-12-10  Eric Seidel  <eric@webkit.org>
3676
3677         Unreviewed.
3678
3679         commit-queue should report port/platform information when commenting on flaky test bugs
3680         https://bugs.webkit.org/show_bug.cgi?id=50839
3681
3682         Renamed platform.py to platforminfo.py.  This broke import platform in executive.py
3683         which was only used by new run webkit tests (and clearly not unit tested).
3684
3685         * Scripts/webkitpy/common/system/platforminfo.py: Renamed from WebKitTools/Scripts/webkitpy/common/system/platform.py.
3686         * Scripts/webkitpy/tool/main.py:
3687         * Scripts/webkitpy/tool/mocktool.py:
3688
3689 2010-12-10  Eric Seidel  <eric@webkit.org>
3690
3691         Reviewed by Tony Chang.
3692
3693         commit-queue should report port/platform information when commenting on flaky test bugs
3694         https://bugs.webkit.org/show_bug.cgi?id=50839
3695
3696         This was a suggestion from Tony Chang this morning.
3697         I added a platform.py class so I could easily mock the platform call,
3698         but that may not be the final solution for this mocking.
3699         We'll try it and see.
3700
3701         * Scripts/webkitpy/common/system/platform.py: Added.
3702         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3703         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3704         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3705         * Scripts/webkitpy/tool/main.py:
3706         * Scripts/webkitpy/tool/mocktool.py:
3707
3708 2010-12-10  Krithigassree Sambamurthy  <krithigassree.sambamurthy@nokia.com>
3709
3710         Reviewed by Joseph Pecoraro.
3711
3712         Bug 43455 - [Qt]: Implement Application Cache Quotas
3713         https://bugs.webkit.org/show_bug.cgi?id=43455
3714
3715         Introduce functions to allow new appcache layout test origin-quota.html
3716         to work correctly under Qt.
3717
3718         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3719         (WebCore::DumpRenderTree::DumpRenderTree):
3720         (WebCore::DumpRenderTree::dumpApplicationCacheQuota):
3721         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3722
3723         Introduce functions to allow new appcache layout test origin-quota.html
3724         to be successful under qt. Changes required because LayoutTestControllerQt
3725         does not inherit from LayoutController.
3726
3727         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3728         (LayoutTestController::reset):
3729         (LayoutTestController::clearAllApplicationCaches):
3730         (LayoutTestController::setApplicationCacheOriginQuota):
3731         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3732         (LayoutTestController::shouldDumpApplicationCacheDelegateCallbacks):
3733         (LayoutTestController::dumpApplicationCacheDelegateCallbacks):
3734
3735 2010-12-10  Eric Seidel  <eric@webkit.org>
3736
3737         Reviewed by Adam Barth.
3738
3739         Move buildbot.py into its own module so we can split it out into one-file-per-class
3740         https://bugs.webkit.org/show_bug.cgi?id=50806
3741
3742         We're adding more buildbot logic these days, so it makes sense
3743         to give buildbot its own module.
3744
3745         * Scripts/webkitpy/common/net/buildbot/__init__.py: Added.
3746         * Scripts/webkitpy/common/net/buildbot/buildbot.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/buildbot.py.
3747         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/buildbot_unittest.py.
3748         * Scripts/webkitpy/common/net/failuremap.py:
3749         * Scripts/webkitpy/common/net/regressionwindow.py:
3750         * Scripts/webkitpy/tool/commands/rebaseline.py:
3751
3752 2010-12-10  Tony Chang  <tony@chromium.org>
3753
3754         Reviewed by Eric Seidel.
3755
3756         Use FileSystem::remove when cleaning up http lock files
3757         https://bugs.webkit.org/show_bug.cgi?id=50830
3758
3759         * Scripts/webkitpy/layout_tests/port/http_lock.py:
3760
3761 2010-12-10  Joone Hur  <joone@kldp.org>
3762
3763         Reviewed by Martin Robinson.
3764
3765         [GTK] DRT needs layoutTestController.setCacheModel
3766         https://bugs.webkit.org/show_bug.cgi?id=50705
3767         
3768         webkit_set_cache_mode() is called to set the cache model.
3769         
3770         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3771         (LayoutTestController::setCacheModel): Set the cache model. 
3772
3773 2010-12-10  Tony Chang  <tony@chromium.org>
3774
3775         Reviewed by Ojan Vafai.
3776
3777         [chromium] remove --use-drt and add --use-test-shell
3778         https://bugs.webkit.org/show_bug.cgi?id=50701
3779
3780         * Scripts/webkitpy/common/config/ports.py:
3781         * Scripts/webkitpy/common/config/ports_unittest.py:
3782         * Scripts/webkitpy/layout_tests/port/chromium.py:
3783         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3784         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3785         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3786         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3787         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3788         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3789         * Scripts/webkitpy/layout_tests/port/webkit.py:
3790         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3791         * Scripts/webkitpy/style/checkers/test_expectations.py:
3792         * Scripts/webkitpy/tool/commands/queries.py:
3793
3794 2010-12-10  John Knottenbelt  <jknotten@chromium.org>
3795
3796         Reviewed by Steve Block.
3797
3798         [Chromium] Implement mocks for client-based geolocation
3799         https://bugs.webkit.org/show_bug.cgi?id=46895
3800
3801         * DumpRenderTree/chromium/LayoutTestController.cpp:
3802         (LayoutTestController::setGeolocationPermission):
3803         (LayoutTestController::setMockGeolocationPosition):
3804         (LayoutTestController::setMockGeolocationError):
3805         * DumpRenderTree/chromium/LayoutTestController.h:
3806         * DumpRenderTree/chromium/WebViewHost.cpp:
3807         (WebViewHost::geolocationClient):
3808         (WebViewHost::geolocationClientMock):
3809         (WebViewHost::reset):
3810         * DumpRenderTree/chromium/WebViewHost.h:
3811
3812 2010-12-10  Alejandro G. Castro  <alex@igalia.com>
3813
3814         Reviewed by Martin Robinson.
3815
3816         [GTK] Add hasSpellingMarker support to the DRT
3817         https://bugs.webkit.org/show_bug.cgi?id=50739
3818
3819         Implemented the hasSpellingMarker to support spelling tests.
3820
3821         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3822         (LayoutTestController::hasSpellingMarker):
3823
3824 2010-12-10  Eric Seidel  <eric@webkit.org>
3825
3826         Reviewed by Ojan Vafai.
3827
3828         webkit-patch: not possible to use build-and-test with local commits
3829         https://bugs.webkit.org/show_bug.cgi?id=33378
3830
3831         Make --no-clean not even check if we have local commits.
3832         It's unclear to me why the code was originally written this way.
3833         I was unable to dig up a reason from svn history.
3834
3835         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
3836         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
3837
3838 2010-12-10  Mario Sanchez Prada  <msanchez@igalia.com>
3839
3840         Reviewed by Martin Robinson.
3841
3842         [GTK] AX: implement isEnabled in DRT
3843         https://bugs.webkit.org/show_bug.cgi?id=50814
3844
3845         Implement AccessibilityUIElement::isEnabled() for GTK.
3846
3847         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3848         (checkElementState): New function to refactor common code.
3849         (AccessibilityUIElement::isEnabled): Implement this by checking
3850         the current state of the AtkObject.
3851         (AccessibilityUIElement::isSelected): Use the new
3852         checkElementState function.
3853
3854 2010-12-10  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3855
3856         Reviewed by Kenneth Rohde Christiansen.
3857
3858         [Qt][WK2] Add the QWKContext API class to wrap the WebContext.
3859         https://bugs.webkit.org/show_bug.cgi?id=50750
3860
3861         * MiniBrowser/qt/BrowserView.cpp:
3862         (BrowserView::BrowserView):
3863         * MiniBrowser/qt/BrowserView.h:
3864         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3865         (WTR::WebView::WebView):
3866
3867 2010-12-10  Joone Hur  <joone@kldp.org>
3868
3869         Reviewed by Xan Lopez.
3870
3871         [GTK] Unskipping some test cases in userscripts dependent on addUserStyleSheet
3872         https://bugs.webkit.org/show_bug.cgi?id=50808
3873
3874         Unskipping the following test cases:
3875         userscripts/mixed-case-stylesheet.html
3876         userscripts/simple-stylesheet.html
3877         userscripts/user-style-all-frames.html
3878
3879         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3880         (LayoutTestController::addUserStyleSheet):
3881
3882 2010-12-10  Joone Hur  <joone@kldp.org>
3883
3884         Reviewed by Eric Seidel.
3885
3886         [GTK] Add DRT support for pageProperty, isPageBoxVisible, pageSizeAndMarginsInPixels, and addUserStyleSheet
3887         https://bugs.webkit.org/show_bug.cgi?id=50783
3888
3889         This patch allows to unskip the following test cases:
3890         printing/page-rule-selection.html
3891         printing/page-format-data.html
3892
3893         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3894         (LayoutTestController::pageProperty): Added.
3895         (LayoutTestController::isPageBoxVisible): Ditto.
3896         (LayoutTestController::pageSizeAndMarginsInPixels): Ditto.
3897         (LayoutTestController::addUserStyleSheet): Ditto.
3898
3899 2010-12-10  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3900
3901         Reviewed by Kenneth Rohde Christiansen.
3902
3903         [Qt] Make QtTestBrowser spawn QNAM in a secondary thread.
3904
3905         A menu allows to switch QNAM back to the same thread.
3906
3907         * QtTestBrowser/launcherwindow.cpp:
3908         (LauncherWindow::initializeView):
3909         (LauncherWindow::createChrome):
3910         (LauncherWindow::toggleThreadedQnam):
3911         * QtTestBrowser/launcherwindow.h:
3912         (WindowOptions::WindowOptions):
3913         * QtTestBrowser/webpage.cpp:
3914         (WebPage::WebPage):
3915         (WebPage::setQnamThreaded):
3916         * QtTestBrowser/webpage.h:
3917         (QnamThread::QnamThread):
3918         (QnamThread::~QnamThread):
3919         (QnamThread::networkAccessManager):
3920         (QnamThread::run):
3921
3922 2010-12-10  Martin Robinson  <mrobinson@igalia.com>
3923
3924         Reviewed by Xan Lopez.
3925
3926         [Gtk] style="font-family: courier" makes text disappear
3927         https://bugs.webkit.org/show_bug.cgi?id=47452
3928
3929         Add a test that verifies that fonts without valid charmaps are
3930         never selected.
3931
3932         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3933         (initializeFonts): Initialize DRT with our font (derived from Ahem)
3934         that has no valid charmap.
3935         * DumpRenderTree/gtk/fonts/FontWithNoValidEncoding.fon: Added.
3936         * DumpRenderTree/gtk/fonts/fonts.conf: Updated settings to override users'
3937         settings which may disable selection of bitmap fonts.
3938
3939 2010-12-10  Eric Seidel  <eric@webkit.org>
3940
3941         Unreviewed.
3942
3943         The commit-queue should file bugs about flaky tests it encounters
3944         https://bugs.webkit.org/show_bug.cgi?id=50803
3945
3946         create_bug_for_flaky_test was insufficiently tested, thus buggy.
3947         Now it's tested.
3948
3949         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3950         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3951
3952 2010-12-10  Eric Seidel  <eric@webkit.org>
3953
3954         Unreviewed.  Somehow this last-minute edit didn't quite get committed.
3955
3956         The commit-queue should file bugs about flaky tests it encounters
3957         https://bugs.webkit.org/show_bug.cgi?id=50803
3958
3959         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3960
3961 2010-12-09  Eric Seidel  <eric@webkit.org>
3962
3963         Reviewed by Adam Barth.
3964
3965         The commit-queue should file bugs about flaky tests it encounters
3966         https://bugs.webkit.org/show_bug.cgi?id=50803
3967
3968         This change got a bit big.  I also added a new config.urls file
3969         because I needed to share the view_source_url code with committervalidator.py.
3970
3971         This adds a new class FlakyTestReporter which holds all the logic about
3972         reporting flaky tests to bugzilla.
3973
3974         Right now this code knows how to look up bugs for flaky tests.
3975         If it can't find a bug filed from the commit-queue, it will open a new
3976         one, ccing the relevant people and adding information about the failure.
3977
3978         It is not yet smart enough to chase down duplicate chains, or to include
3979         the actual failure diff.  But those can be added in later iterations.
3980
3981         * Scripts/webkitpy/common/checkout/api.py:
3982         * Scripts/webkitpy/common/checkout/changelog.py:
3983         * Scripts/webkitpy/common/checkout/commitinfo.py:
3984         * Scripts/webkitpy/common/config/committervalidator.py:
3985         * Scripts/webkitpy/common/config/urls.py: Copied from WebKitTools/Scripts/webkitpy/tool/comments.py.
3986         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3987         * Scripts/webkitpy/tool/bot/flakytestreporter.py: Added.
3988         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/comments.py.
3989         * Scripts/webkitpy/tool/bot/irc_command.py:
3990         * Scripts/webkitpy/tool/bot/sheriff.py:
3991         * Scripts/webkitpy/tool/commands/download.py:
3992         * Scripts/webkitpy/tool/commands/queues.py:
3993         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3994         * Scripts/webkitpy/tool/comments.py:
3995         * Scripts/webkitpy/tool/mocktool.py:
3996         * Scripts/webkitpy/tool/steps/commit.py:
3997
3998 2010-12-09  Eric Seidel  <eric@webkit.org>
3999
4000         Reviewed by Adam Barth.
4001
4002         Teach webkit-patch how to search bugzilla
4003         https://bugs.webkit.org/show_bug.cgi?id=50500
4004
4005         This is a step towards teaching webkitpy how to file
4006         new bugs for flaky tests and update them when new flakes occur.
4007
4008         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
4009         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
4010         * Scripts/webkitpy/tool/commands/__init__.py:
4011         * Scripts/webkitpy/tool/commands/bugsearch.py: Added.
4012
4013 2010-12-09  Adam Barth  <abarth@webkit.org>
4014
4015         Reviewed by Ojan Vafai.
4016
4017         commit-queue errors out due to local commits
4018         https://bugs.webkit.org/show_bug.cgi?id=50766
4019
4020         We seem to be tripping over having local commits in the working copy a
4021         lot recently.  I don't quite fully understand what the issue is, but
4022         this patch attempts to solve the problem by adding an explicit clean
4023         step before processing a patch.  Previously, we did the cleaning as
4024         part of the apply-attachment step, so this might not actually fix the
4025         problem.
4026
4027         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
4028         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
4029         * Scripts/webkitpy/tool/commands/queues_unittest.py:
4030
4031 2010-12-09  Dirk Pranke  <dpranke@chromium.org>
4032
4033         Reviewed by Ojan Vafai.
4034
4035         Make new-run-webkit-tests --lint-test-files log slightly better
4036         messages and return -1 if lint fails. Remove the
4037         'suppress_errors' keyword param to the TestExpectationsFile
4038         class, and clean up logging and exception raising for error
4039         handling. Also add more unit tests and clean up the unit test code a bit.
4040
4041         https://bugs.webkit.org/show_bug.cgi?id=50205
4042
4043         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4044         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
4045         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py
4046         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py
4047         * Scripts/webkitpy/layout_tests/port/chromium.py:
4048         * Scripts/webkitpy/style/checkers/test_expectations.py:
4049         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
4050
4051 2010-12-09  Tony Chang  <tony@chromium.org>
4052
4053         Unreviewed, fix for windows code.  We were catching the wrong
4054         exception in Windows.
4055
4056         * Scripts/webkitpy/common/system/filesystem.py:
4057
4058 2010-12-09  Antonio Gomes  <agomes@rim.com>
4059
4060         Reviewed by Martin Robinson.
4061
4062         [Gtk] Populate DumpRenderTreeSupportGtk (part IV)
4063         https://bugs.webkit.org/show_bug.cgi?id=48429
4064
4065         Adjust call sites of webkit_thread_count to use the DumpRenderTreeSupportGtk version now.
4066
4067         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4068         (LayoutTestController::workerThreadCount):
4069
4070 2010-12-06  Philippe Normand  <pnormand@igalia.com>
4071
4072         Reviewed by Martin Robinson.
4073
4074         [GTK] Support the Mozilla-style Fullscreen Javascript API
4075         https://bugs.webkit.org/show_bug.cgi?id=50572
4076
4077         Enable the Javascript Fullscreen support in the GtkLauncher. Also
4078         make DRT update the Chrome when the WebView settings have been
4079         reset to consistent values.
4080
4081         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4082         (resetDefaultsToConsistentValues):
4083         * GtkLauncher/main.c:
4084         (create_window):
4085         * Scripts/build-webkit:
4086
4087 2010-12-09  Koan-Sin Tan  <koansin.tan@gmail.com>
4088
4089         Reviewed by Tor Arne Vestbø
4090
4091         [Qt] run-launcher doesn't start the browser on Mac OS X 10.6
4092         https://bugs.webkit.org/show_bug.cgi?id=50742
4093
4094         check not only QtWebKit.framework/QtWebKit but also libQtWebKit.dylib
4095
4096         * Scripts/webkitdirs.pm:
4097
4098 2010-12-09  Joone Hur  <joone@kldp.org>
4099
4100          Reviewed by Martin Robinson.
4101
4102          [GTK] Support for viewport meta tag
4103          https://bugs.webkit.org/show_bug.cgi?id=45443
4104
4105          Add support for testing the viewport properties for WebKitGtk.
4106
4107          * DumpRenderTree/LayoutTestController.cpp:
4108          (dumpConfigurationForViewportCallback): Added this JS callback to set the size of the visible viewport.
4109          (LayoutTestController::staticFunctions):
4110          * DumpRenderTree/LayoutTestController.h:
4111          * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4112          (LayoutTestController::dumpConfigurationForViewport): Added this function to test the viewport properties.
4113          * DumpRenderTree/mac/LayoutTestControllerMac.mm:
4114          (LayoutTestController::dumpConfigurationForViewport): Ditto.
4115          * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4116          (LayoutTestController::dumpConfigurationForViewport): Ditto.
4117          * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4118          (LayoutTestController::dumpConfigurationForViewport): Ditto.
4119          * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
4120          (LayoutTestController::dumpConfigurationForViewport): Ditto.
4121
4122 2010-12-08  William Siegrist <wsiegrist@apple.com>
4123
4124         Reviewed by Eric Seidel.
4125
4126         Migrate buildbot.py from xmlrpc to json.
4127         https://bugs.webkit.org/show_bug.cgi?id=50647
4128
4129         * Scripts/webkitpy/common/net/buildbot.py:
4130
4131 2010-12-08  Tony Chang  <tony@chromium.org>
4132
4133         Reviewed by Eric Seidel.
4134
4135         make starting the websocket server more reliable on windows
4136         https://bugs.webkit.org/show_bug.cgi?id=50712
4137
4138         * Scripts/webkitpy/common/system/filesystem.py:
4139         (remove): Substitute method for os.remove to retry on error on Windows
4140         * Scripts/webkitpy/common/system/filesystem_unittest.py:
4141         * Scripts/webkitpy/layout_tests/port/http_server_base.py: Use FileSystem.remove
4142
4143 2010-12-08  Jessie Berlin  <jberlin@apple.com>
4144
4145         Reviewed by Adam Roben.
4146
4147         WebKit2: Implement WebChromeClient::exceededDatabaseQuota
4148         https://bugs.webkit.org/show_bug.cgi?id=50656
4149
4150         * MiniBrowser/mac/BrowserWindowController.m:
4151         (-[BrowserWindowController awakeFromNib]):
4152         Indicate that exceededDatabaseQuota is not implemented.
4153         * MiniBrowser/win/BrowserView.cpp:
4154         (BrowserView::create):
4155         Ditto.
4156         * WebKitTestRunner/TestController.cpp:
4157         (WTR::createOtherPage):
4158         Ditto.
4159         (WTR::TestController::initialize):
4160         Ditto.
4161
4162 2010-12-08  Antonio Gomes  <agomes@rim.com>
4163
4164         Reviewed by Martin Robinson.
4165
4166         [Gtk] Populate DumpRenderTreeSupportGtk (part III)
4167         https://bugs.webkit.org/show_bug.cgi?id=48429
4168
4169         Moved the following methods from webkitprivate.h to DumpRenderTreeSupportGtk.cpp|h:
4170         * webkit_gc_collect_javascript_objects;
4171         * webkit_gc_collect_javascript_objects_on_alternate_thread;
4172         * webkit_gc_count_javascript_objects;
4173         * webkit_web_frame_layout.
4174
4175         These were all only used by GTK+ DRT.
4176
4177         * DumpRenderTree/gtk/EventSender.cpp:
4178         (dispatchEvent):
4179         * DumpRenderTree/gtk/GCControllerGtk.cpp:
4180         (GCController::collect):
4181         (GCController::collectOnAlternateThread):
4182         (GCController::getJSObjectCount):
4183
4184 2010-12-07  Tony Chang  <tony@chromium.org>
4185
4186         Reviewed by Ojan Vafai.
4187
4188         [chromium] force NRWT to use DRT
4189         https://bugs.webkit.org/show_bug.cgi?id=50359
4190
4191         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4192
4193 2010-12-06  Sam Weinig  <sam@webkit.org>
4194
4195         Reviewed by Anders Carlsson.
4196
4197         Generalize didChangeLocationWithinPageForFrame for all same document navigations
4198         https://bugs.webkit.org/show_bug.cgi?id=50584
4199
4200         * MiniBrowser/mac/BrowserWindowController.m:
4201         (didSameDocumentNavigationForFrame):
4202         (-[BrowserWindowController awakeFromNib]):
4203         (-[BrowserWindowController didSameDocumentNavigationForFrame:]):
4204         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
4205         (TestWebKitAPI::didSameDocumentNavigationForFrame):
4206         (TestWebKitAPI::TEST):
4207         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4208         (WTR::InjectedBundlePage::InjectedBundlePage):
4209         (WTR::InjectedBundlePage::didSameDocumentNavigationForFrame):
4210         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
4211         * WebKitTestRunner/TestController.cpp:
4212         (WTR::TestController::initialize):
4213
4214 2010-12-06  Kinuko Yasuda  <kinuko@chromium.org>
4215
4216         Reviewed by Ojan Vafai.
4217
4218         Make TestResultsServer return 404 for non-existing results files.
4219         https://bugs.webkit.org/show_bug.cgi?id=50581
4220
4221         * TestResultServer/handlers/testfilehandler.py:
4222
4223 2010-12-06  Tony Chang  <tony@chromium.org>
4224
4225         Reviewed by Ojan Vafai.
4226
4227         [chromium] fix an assert hit in DRT
4228         https://bugs.webkit.org/show_bug.cgi?id=50575
4229
4230         This class uses WTF's RefPtr, but expects chrome's base::RefPtr
4231         semantics.
4232
4233         Otherwise, we hit ASSERTION FAILED: !m_adoptionIsRequired
4234         (third_party/WebKit/JavaScriptCore/wtf/RefCounted.h:37 void
4235         WTF::RefCountedBase::ref()).
4236
4237         * DumpRenderTree/chromium/TestWebWorker.h:
4238         (TestWebWorker::TestWebWorker):
4239
4240 2010-12-02  Ojan Vafai  <ojan@chromium.org>
4241
4242         Reviewed by Eric Seidel.
4243
4244         make webkit-patch command work when the git branch is not synced to the remote svn branch
4245         https://bugs.webkit.org/show_bug.cgi?id=50424
4246
4247         * Scripts/webkitpy/common/checkout/scm.py:
4248         * Scripts/webkitpy/common/checkout/scm_unittest.py:
4249
4250 2010-12-06  Patrick Gansterer  <paroga@webkit.org>
4251
4252         Reviewed by Andreas Kling.
4253
4254         [WINCE] Add build system
4255         https://bugs.webkit.org/show_bug.cgi?id=50522
4256
4257         * CMakeListsWinCE.txt: Added.
4258
4259 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
4260
4261         Reviewed by Tony Chang.
4262
4263         Allow the Chromium port to have Leopard-specific baselines
4264         https://bugs.webkit.org/show_bug.cgi?id=50506
4265
4266         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
4267
4268 2010-12-03  Tony Chang  <tony@chromium.org>
4269
4270         Reviewed by Kent Tamura.
4271
4272         [chromium] fix 2 bugs with inspector tests in DRT
4273         https://bugs.webkit.org/show_bug.cgi?id=50492
4274
4275         Tasks can outlive the tasklist (even when canceled) so this was
4276         causing a crash when ~WebTask() ran.  Avoid this by unregistering
4277         when a task is canceled.
4278
4279         Also fix an assert when closing devtool windows by copying some
4280         logic from test_shell.
4281
4282         * DumpRenderTree/chromium/Task.cpp:
4283         (WebTask::~WebTask):
4284         (TaskList::revokeAll):
4285         * DumpRenderTree/chromium/Task.h: Canceling a task now removes it from
4286             the tasklist (since the task can outlive the tasklist).
4287         * DumpRenderTree/chromium/TestShell.h:
4288         (TestShell::devToolsWebView):
4289         * DumpRenderTree/chromium/WebViewHost.cpp:
4290         (WebViewHost::~WebViewHost): Don't load about:blank when closing
4291             a window if the window has devtools loaded.  This avoids an
4292             ASSERT and matches test_shell.
4293
4294 2010-12-06  Alejandro G. Castro  <alex@igalia.com>
4295
4296         Reviewed by Martin Robinson.
4297
4298         [GTK] Fix GtkLauncher.c style, use webkit style
4299         https://bugs.webkit.org/show_bug.cgi?id=50542
4300
4301         * GtkLauncher/main.c:
4302         (activateUriEntryCb):
4303         (updateTitle):
4304         (linkHoverCb):
4305         (notifyTitleCb):
4306         (notifyLoadStatusCb):
4307         (notifyProgressCb):
4308         (destroyCb):
4309         (goBackCb):
4310         (goForwardCb):
4311         (create_webViewCb):
4312         (webViewReadyCb):
4313         (closeWebViewCb):
4314         (createBrowser):
4315         (createStatusbar):
4316         (createToolbar):
4317         (createWindow):
4318         (main):
4319
4320 2010-12-04  Antonio Gomes  <agomes@rim.com>
4321
4322         Reviewed by Martin Robinson.