de010ec36de6f26f8c5b1d5f87dba4478838aaf7
[WebKit-https.git] / Tools / ChangeLog
1 2020-03-26  Daniel Bates  <dabates@apple.com>
2
3         WebPage::selectPositionAtPoint() does not focus an element in a non-focused frame
4         https://bugs.webkit.org/show_bug.cgi?id=209559
5         <rdar://problem/60887055>
6
7         Reviewed by Wenson Hsieh.
8
9         Add a test.
10
11         * TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm:
12         (TEST):
13
14 2020-03-26  Fujii Hironori  <Hironori.Fujii@sony.com>
15
16         WebKitTestRunner should enable ResourceLoadStatistics also for non-Cocoa ports
17         https://bugs.webkit.org/show_bug.cgi?id=209410
18
19         Reviewed by Youenn Fablet.
20
21         Cocoa WebKitTestRunner always enables ResourceLoadStatistics.
22         Other ports should do so.
23
24         * WebKitTestRunner/TestController.cpp:
25         (WTR::TestController::platformAdjustContext): Enable ResourceLoadStatistics
26         by using WKWebsiteDataStoreSetResourceLoadStatisticsEnabled.
27
28 2020-03-26  Kate Cheney  <katherine_cheney@apple.com>
29
30         Guard AppBound domain protections with PLATFORM(iOS_FAMILY)
31         https://bugs.webkit.org/show_bug.cgi?id=209615
32         <rdar://problem/60931014>
33
34         Reviewed by Darin Adler.
35
36         Tests should only be run on iOS.
37
38         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
39
40 2020-03-26  Aakash Jain  <aakash_jain@apple.com>
41
42         [ews] status-bubble for tester queues should point to tester queue while waiting in queue (Follow-up fix)
43         https://bugs.webkit.org/show_bug.cgi?id=209598
44
45         Unreviewed follow-up fix.
46
47         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
48         (StatusBubble._build_bubble): Display the tester name in tester's status-bubble hover-over message.
49
50 2020-03-26  Aakash Jain  <aakash_jain@apple.com>
51
52         [ews] status-bubble for tester queues should point to tester queue while waiting in queue
53         https://bugs.webkit.org/show_bug.cgi?id=209598
54
55         Reviewed by Jonathan Bedard.
56
57         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
58         (StatusBubble._build_bubble):
59
60 2020-03-26  Chris Fleizach  <cfleizach@apple.com>
61
62         AX: WKTR: Don't update isolated tree mode behavior if not required
63         https://bugs.webkit.org/show_bug.cgi?id=209555
64         <rdar://problem/60885094>
65
66         Reviewed by Darin Adler.
67
68         If the isolated tree mode has not changed, then we should not poke at the mechanisms for turning it on/off.
69         This might have the side effect of turning on accessibility unexpectedly.
70
71         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
72         (WTR::AccessibilityController::setAccessibilityIsolatedTreeMode):
73
74 2020-03-26  Philippe Normand  <pnormand@igalia.com>
75
76         [Flatpak SDK] Pass all the arguments of build-webkit to webkit-flatpak
77         https://bugs.webkit.org/show_bug.cgi?id=209558
78
79         Reviewed by Žan Doberšek.
80
81         When using flatpak some of the arguments we pass to build-webkit
82         are not meant to be used by that script but by webkit-flatpak. However we are
83         not passing all of them to webkit-flatpak but just the configuration ones
84         (port, release/debug...). This means that all the arguments that configure the
85         behaviour of webkit-flatpak are lost.
86
87         * Scripts/webkitdirs.pm:
88         (runInFlatpak): Filter-out Flatpak SDK-specific arguments to a
89         separate array, passed to webkit-flatpak.
90
91 2020-03-26  Commit Queue  <commit-queue@webkit.org>
92
93         Unreviewed, reverting r259035.
94         https://bugs.webkit.org/show_bug.cgi?id=209597
95
96         broke windows layout-tests (Requested by aakashjain on
97         #webkit).
98
99         Reverted changeset:
100
101         "[Win] lld-link: error: /manifestdependency: is not allowed in
102         .drectve"
103         https://bugs.webkit.org/show_bug.cgi?id=204831
104         https://trac.webkit.org/changeset/259035
105
106 2020-03-26  Philippe Normand  <pnormand@igalia.com>
107
108         [Flatpak SDK] update-webkitgtk-libs fails
109         https://bugs.webkit.org/show_bug.cgi?id=209546
110
111         Reviewed by Žan Doberšek.
112
113         Simplify the code a bit, add a `--assumeyes` argument to the
114         `flatpak update` command to make it non-interactive and improve
115         error handling/reporting a bit as well.
116
117         * flatpak/flatpakutils.py:
118         (FlatpakObject.flatpak):
119         (WebkitFlatpak.main):
120         (WebkitFlatpak.run):
121         (WebkitFlatpak.install_all):
122         (WebkitFlatpak.update_all): Deleted.
123
124 2020-03-26  Philippe Normand  <pnormand@igalia.com>
125
126         [Flatpak SDK] Crash post-mortem debugging is broken
127         https://bugs.webkit.org/show_bug.cgi?id=209537
128
129         Reviewed by Žan Doberšek.
130
131         webkit-flatpak --gdb now properly launches gdb to inspect the last
132         crash reported to coredumpctl. The -m argument can be used to
133         select another crash dump.
134
135         * flatpak/flatpakutils.py:
136         (WebkitFlatpak.clean_args):
137         (WebkitFlatpak.run_in_sandbox):
138         (WebkitFlatpak.run_gdb):
139
140 2020-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
141
142         [Win] lld-link: error: /manifestdependency: is not allowed in .drectve
143         https://bugs.webkit.org/show_bug.cgi?id=204831
144
145         Reviewed by Ross Kirsling.
146
147         * TestWebKitAPI/win/main.cpp:
148         * win/DLLLauncher/DLLLauncherMain.cpp:
149
150 2020-03-25  Alexey Shvayka  <shvaikalesh@gmail.com>
151
152         Invalid numeric and named references should be early syntax errors
153         https://bugs.webkit.org/show_bug.cgi?id=178175
154
155         Reviewed by Ross Kirsling.
156
157         Removes FIXME as YarrParser is correct not to throw errors as it is
158         parsing in non-Unicode mode. Also adds a few named groups tests.
159
160         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
161
162 2020-03-25  Zhifei Fang  <zhifei_fang@apple.com>
163
164         [Timeline] A better default get label function, which fit the assumpation the label is always a string
165         https://bugs.webkit.org/show_bug.cgi?id=209567
166
167         Reviewed by Jonathan Bedard.
168
169         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
170
171 2020-03-25  Zhifei Fang  <zhifei_fang@apple.com>
172
173         [Timeline] Fix the out of bound dot index
174         https://bugs.webkit.org/show_bug.cgi?id=209492
175
176         Reviewed by Jonathan Bedard.
177
178         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
179         (Timeline.CanvasSeriesComponent):
180
181 2020-03-25  Daniel Bates  <dabates@apple.com>
182
183         Element context character rects may be in wrong coordinate system
184         https://bugs.webkit.org/show_bug.cgi?id=209493
185         <rdar://problem/60840261>
186
187         Reviewed by Wenson Hsieh.
188
189         Add some tests.
190
191         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
192         (TEST):
193
194 2020-03-25  Doug Kelly  <dougk@apple.com>
195
196         Unreviewed, add new committer to contributors.json
197
198         * Scripts/webkitpy/common/config/contributors.json:
199
200 2020-03-25  Frank Yang  <guowei_yang@apple.com>
201
202         Unprefix -webkit-text-orientation
203         https://bugs.webkit.org/show_bug.cgi?id=196139
204
205         Reviewed by Myles C. Maxfield.
206
207         This change is made to add the extra flag "related-property" in CSSProperty.json
208         in the jsonchecker so that the jsonchecker would not complain about unrecognized key
209
210         * Scripts/webkitpy/style/checkers/jsonchecker.py: added check for related-property
211         (JSONCSSPropertiesChecker.check_codegen_properties): 
212
213 2020-03-25  Aakash Jain  <aakash_jain@apple.com>
214
215         [ews] commit-queue should comment on bug if it fails to find any modified ChangeLog
216         https://bugs.webkit.org/show_bug.cgi?id=209550
217
218         Reviewed by Jonathan Bedard.
219
220         * BuildSlaveSupport/ews-build/steps.py:
221         (FindModifiedChangeLogs): Set haltOnFailure to false.
222         (FindModifiedChangeLogs.getResultSummary):
223         (FindModifiedChangeLogs.evaluateCommand): Add build steps to comment on bug and set cq- on patch appropriately.
224         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
225
226 2020-03-25  Aakash Jain  <aakash_jain@apple.com>
227
228         [ews] status-bubble should link to buildbot queue while waiting in queue
229         https://bugs.webkit.org/show_bug.cgi?id=209543
230
231         Reviewed by Jonathan Bedard.
232
233         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
234         (StatusBubble._build_bubble): Link to buildbot queue whil patch is waiting in queue.
235         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
236         (Buildbot.update_icons_for_queues_mapping): Generate the mapping for shortname to full queue name.
237
238 2020-03-25  Ting-Wei Lan  <lantw44@gmail.com>
239
240         [GTK] Add user agent quirk for auth.mayohr.com
241         https://bugs.webkit.org/show_bug.cgi?id=209378
242
243         Reviewed by Michael Catanzaro.
244
245         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
246         (TestWebKitAPI::assertUserAgentForURLHasNoSafariVersionQuirk):
247         (TestWebKitAPI::TEST):
248
249 2020-03-24  Daniel Bates  <dabates@apple.com>
250
251         Unreviewed, reverting r258945.
252
253         Revert change that broke API tests while I investigate
254         offline.
255
256         Reverted changeset:
257
258         "Element context character rects may be in wrong coordinate
259         system"
260         https://bugs.webkit.org/show_bug.cgi?id=209493
261         https://trac.webkit.org/changeset/258945
262
263 2020-03-24  Jiewen Tan  <jiewen_tan@apple.com>
264
265         Unreviewed, skips a test for iOS
266
267         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
268
269 2020-03-24  Jonathan Bedard  <jbedard@apple.com>
270
271         results.webkit.org: Documentation for uncollapsed failure endpoints is wrong
272         https://bugs.webkit.org/show_bug.cgi?id=209496
273
274         Rubber-stamped by Aakash Jain.
275
276         * resultsdbpy/resultsdbpy/view/templates/documentation.html:
277
278 2020-03-24  Jonathan Bedard  <jbedard@apple.com>
279
280         results.webkit.org: Filter suite results by expectation by default
281         https://bugs.webkit.org/show_bug.cgi?id=209500
282
283         Rubber-stamped by Aakash Jain.
284
285         * resultsdbpy/resultsdbpy/view/static/js/timeline.js: Allow the Legend constructor
286         to set a willFilterExpected default.
287         * resultsdbpy/resultsdbpy/view/templates/suite_results.html:
288
289 2020-03-24  Per Arne Vollan  <pvollan@apple.com>
290
291         [Cocoa] Fix launch time regression with CF prefs direct mode enabled
292         https://bugs.webkit.org/show_bug.cgi?id=209244
293
294         Reviewed by Darin Adler.
295
296         * TestWebKitAPI/Tests/WebKit/PreferenceChanges.mm:
297         (TEST):
298         (sharedInstanceMethodOverride):
299
300 2020-03-24  Jonathan Bedard  <jbedard@apple.com>
301
302         results.webkit.org: Correct UUID capitalization in documentation
303         https://bugs.webkit.org/show_bug.cgi?id=209497
304
305         Reviewed by Aakash Jain.
306
307         * resultsdbpy/resultsdbpy/view/templates/documentation.html:
308
309 2020-03-24  Aakash Jain  <aakash_jain@apple.com>
310
311         [ews] commit-queue should comment on bug if it fails to create git commit
312         https://bugs.webkit.org/show_bug.cgi?id=209487
313
314         Reviewed by Jonathan Bedard.
315
316         * BuildSlaveSupport/ews-build/steps.py:
317         (CreateLocalGITCommit):
318         (CreateLocalGITCommit.start):
319         (CreateLocalGITCommit.evaluateCommand):
320         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
321
322 2020-03-24  Daniel Bates  <dabates@apple.com>
323
324         Element context character rects may be in wrong coordinate system
325         https://bugs.webkit.org/show_bug.cgi?id=209493
326         <rdar://problem/60840261>
327
328         Reviewed by Wenson Hsieh.
329
330         Add some tests.
331
332         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
333         (TEST):
334
335 2020-03-24  Aakash Jain  <aakash_jain@apple.com>
336
337         [ews] position in queue shown in status-bubble is larger than actual position
338         https://bugs.webkit.org/show_bug.cgi?id=209481
339
340         Reviewed by Jonathan Bedard.
341
342         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
343         (StatusBubble._queue_position): Use created timestamp instead of modified.
344
345 2020-03-24  Daniel Bates  <dabates@apple.com>
346
347         [iOS][WK2] Set text trait isSingleLineDocument
348         https://bugs.webkit.org/show_bug.cgi?id=209391
349         <rdar://problem/60705870>
350
351         Reviewed by Darin Adler.
352
353         Add a test.
354
355         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
356         (TestWebKitAPI::TEST):
357         * TestWebKitAPI/ios/UIKitSPI.h: Expose more SPI.
358
359 2020-03-24  Alex Christensen  <achristensen@webkit.org>
360
361         Unreviewed, reverting r258862.
362
363         SPI was not what was needed
364
365         Reverted changeset:
366
367         "Add SPI to move localStorage to a different domain"
368         https://bugs.webkit.org/show_bug.cgi?id=209260
369         https://trac.webkit.org/changeset/258862
370
371 2020-03-24  Chris Lord  <clord@igalia.com>
372
373         [GTK][WPE] WEB_PROCESS_CMD_PREFIX and others have stopped working
374         https://bugs.webkit.org/show_bug.cgi?id=209478
375
376         Make sure *_PROCESS_CMD_PREFIX variables are whitelisted in the Flatpak sandbox.
377
378         Reviewed by Philippe Normand.
379
380         * flatpak/flatpakutils.py:
381         (WebkitFlatpak.run_in_sandbox):
382
383 2020-03-23  Simon Fraser  <simon.fraser@apple.com>
384
385         [mac-wk1] fast/scrolling/arrow-key-scroll-in-rtl-document.html is a flaky timeout
386         https://bugs.webkit.org/show_bug.cgi?id=209427
387
388         Reviewed by Wenson Hsieh.
389         
390         0 => NULL
391
392         * DumpRenderTree/mac/DumpRenderTree.mm:
393         (invalidateAnyPreviousWaitToDumpWatchdog):
394
395 2020-03-23  Dean Jackson  <dino@apple.com>
396
397         webkitpy Git class must expose the repository URL
398         https://bugs.webkit.org/show_bug.cgi?id=209439
399         <rdar://problem/60792668>
400
401         Reviewed by Simon Fraser.
402
403         Some internal tools were relying on the svn_url() method
404         that was changed/removed in r258164. Add a replacement.
405
406         * Scripts/webkitpy/common/checkout/scm/git.py:
407         (Git.svn_repository_url):
408
409 2020-03-23  Alex Christensen  <achristensen@webkit.org>
410
411         Fix memory leak introduced in r257726
412         https://bugs.webkit.org/show_bug.cgi?id=208399
413
414         Reviewed by John Wilander.
415
416         * WebKitTestRunner/TestController.cpp:
417         (WTR::TestController::websiteDataStore):
418         We were leaking page configurations.
419
420 2020-03-23  John Wilander  <wilander@apple.com>
421
422         Add the capability to change all of a website's cookies to SameSite=Strict
423         https://bugs.webkit.org/show_bug.cgi?id=209369
424         <rdar://problem/60710690>
425
426         Reviewed by Alex Christensen and David Kilzer.
427
428         These changes add TestRunner function statisticsSetToSameSiteStrictCookies().
429
430         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
431         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
432         (WTR::InjectedBundle::didReceiveMessageToPage):
433         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
434         (WTR::TestRunner::statisticsSetToSameSiteStrictCookies):
435         (WTR::TestRunner::statisticsCallDidSetToSameSiteStrictCookiesCallback):
436         * WebKitTestRunner/InjectedBundle/TestRunner.h:
437         * WebKitTestRunner/TestController.cpp:
438         (WTR::TestController::setStatisticsToSameSiteStrictCookies):
439         * WebKitTestRunner/TestController.h:
440         * WebKitTestRunner/TestInvocation.cpp:
441         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
442         (WTR::TestInvocation::didSetToSameSiteStrictCookies):
443         * WebKitTestRunner/TestInvocation.h:
444
445 2020-03-23  Nikos Mouchtaris  <nmouchtaris@apple.com>
446
447         Uneviewed, added myself to contributors.json.
448
449         * Scripts/webkitpy/common/config/contributors.json:
450
451 2020-03-23  Daniel Bates  <dabates@apple.com>
452
453         Support inserting text or dictation alternative by simulating keyboard input
454         https://bugs.webkit.org/show_bug.cgi?id=209380
455         <rdar://problem/59445102>
456
457         Reviewed by Darin Adler.
458
459         Add tests to ensure that DOM events are dispatched on insertion when shouldSimulateKeyboardInput
460         is enabled.
461
462         I also added a convenience assertion function, EXPECT_NS_EQUAL, that can
463         compare NSObjects so long as they implement -isEqual and -description. I
464         make use of this to compare the actual array of fired DOM events types to
465         an expected array.
466
467         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
468         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
469         (TestWebKitAPI::shouldSimulateKeyboardInputOnTextInsertionOverride):
470         (TestWebKitAPI::TEST):
471         * TestWebKitAPI/cocoa/TestCocoa.h:
472         (TestWebKitAPI::Util::assertNSObjectsAreEqual): Added.
473         (EXPECT_NS_EQUAL): Added.
474         * TestWebKitAPI/ios/insert-text.html: Added.
475
476 2020-03-23  Kate Cheney  <katherine_cheney@apple.com>
477
478         Add checks for app-bound navigations when evaluating user style sheets
479         https://bugs.webkit.org/show_bug.cgi?id=209368
480         <rdar://problem/60204230>
481
482         Reviewed by Brent Fulgham.
483
484         Tested cases based on those in UserContentController.mm.
485
486         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
487         (-[InAppBrowserSchemeHandler webView:startURLSchemeTask:]):
488         (expectScriptEvaluatesToColor):
489         (TEST):
490
491
492 2020-03-23  Alex Christensen  <achristensen@webkit.org>
493
494         Add SPI to move localStorage to a different domain
495         https://bugs.webkit.org/show_bug.cgi?id=209260
496         <rdar://problem/60285683>
497
498         Reviewed by Brady Eidson.
499
500         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
501         (TEST):
502
503 2020-03-23  youenn fablet  <youenn@apple.com>
504
505         Disable TestWebKitAPI.ProcessSwap.GetUserMediaCaptureState if getUserMedia is not supported
506         https://bugs.webkit.org/show_bug.cgi?id=209428
507
508         Reviewed by Jonathan Bedard.
509
510         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
511
512 2020-03-23  Chris Lord  <clord@igalia.com>
513
514         Add missing committer status to Chris Lord in contributors.json
515
516         Unreviewed
517
518         * Scripts/webkitpy/common/config/contributors.json:
519
520 2020-03-23  youenn fablet  <youenn@apple.com>
521
522         StringView::startsWith and String::startsWith do not treat null strings the same
523         https://bugs.webkit.org/show_bug.cgi?id=209273
524
525         Reviewed by Darin Adler.
526
527         * TestWebKitAPI/Tests/WTF/StringView.cpp:
528         (TestWebKitAPI::TEST):
529         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
530         (TestWebKitAPI::TEST):
531
532 2020-03-22  Antoine Quint  <graouts@apple.com>
533
534         DocumentTimeline / CSSTransition objects are leaking on CNN.com
535         https://bugs.webkit.org/show_bug.cgi?id=208069
536         <rdar://problem/59680143>
537
538         Reviewed by Simon Fraser, Geoffrey Garen and Darin Adler.
539
540         Add a test that checks that a ListHashSet containing RefPtr<> types correctly calls the destructor for those items when the assignment operator is used.
541
542         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
543         (TestWebKitAPI::ListHashSetReferencedItem::create):
544         (TestWebKitAPI::ListHashSetReferencedItem::ListHashSetReferencedItem):
545         (TestWebKitAPI::ListHashSetReferencedItem::~ListHashSetReferencedItem):
546         (TestWebKitAPI::FakeElementAnimationRareData::FakeElementAnimationRareData):
547         (TestWebKitAPI::FakeElementAnimationRareData::~FakeElementAnimationRareData):
548         (TestWebKitAPI::FakeElementAnimationRareData::collection):
549         (TestWebKitAPI::FakeElementAnimationRareData::setCollection):
550         (TestWebKitAPI::TEST):
551
552 2020-03-21  Michael Catanzaro  <mcatanzaro@gnome.org>
553
554         [GTK] Use ${PYTHON_EXECUTABLE} to run generate-gtkdoc
555         https://bugs.webkit.org/show_bug.cgi?id=208970
556
557         Reviewed by Konstantin Tokarev.
558
559         We are allowed to use /usr/bin/env in this script because it's not installed (so not
560         packaged). Therefore we can make the shebang compatible with FreeBSD in this particularl
561         case.
562
563         * gtkdoc/generate-gtkdoc:
564
565 2020-03-20  Jonathan Bedard  <jbedard@apple.com>
566
567         run-webkit-tests: Report MacCatalyst as a unique platform
568         https://bugs.webkit.org/show_bug.cgi?id=209361
569
570         Rubber-stamped by Aakash Jain.
571
572         * Scripts/webkitpy/port/mac.py:
573         (MacCatalystPort):
574         (MacCatalystPort.configuration_for_upload): Treat MacCatalyst as a separate platform from Mac.
575
576 2020-03-20  Alex Christensen  <achristensen@webkit.org>
577
578         CORS-disabling SPI introduced in r253978 should make responses non-opaque
579         https://bugs.webkit.org/show_bug.cgi?id=209351
580         <rdar://problem/60024850>
581
582         Reviewed by Chris Dumez.
583
584         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
585
586 2020-03-20  Aakash Jain  <aakash_jain@apple.com>
587
588         commit-queue should skip building and testing if patch already passed tests on mac-wk2 queue
589         https://bugs.webkit.org/show_bug.cgi?id=208938
590
591         Reviewed by Jonathan Bedard.
592
593         * BuildSlaveSupport/ews-build/steps.py:
594         (RunWebKitTests.doStepIf): Skip testing if patch already passed mac-wk2 tests.
595         (CheckPatchStatusOnEWSQueues): Build-step to check patch status on other queues.
596         (CheckPatchStatusOnEWSQueues.get_patch_status):
597         (CheckPatchStatusOnEWSQueues.start):
598         * BuildSlaveSupport/ews-build/steps_unittest.py:
599         (test_skip_for_mac_wk2_passed_patch_on_commit_queue): Added unit-tests.
600         * BuildSlaveSupport/ews-build/factories.py: Added build-step to check the patch status on other queues.
601         * BuildSlaveSupport/ews-build/factories_unittest.py: Updated unit-test.
602         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py: Added the new step status to STEPS_TO_HIDE.
603
604 2020-03-20  Aakash Jain  <aakash_jain@apple.com>
605
606         [ews] Better organize patch status api data
607         https://bugs.webkit.org/show_bug.cgi?id=209342
608
609         Reviewed by Jonathan Bedard.
610
611         * BuildSlaveSupport/ews-app/ews/views/status.py:
612         (Status._build_status):
613         (Status._build_statuses_for_patch): Updated to return dictionary instead of list.
614         (Status.get): Remove safe=false now that we are returning a dictionary.
615
616 2020-03-20  Tim Horton  <timothy_horton@apple.com>
617
618         Upstream a variety of Cocoa-platform HAVE and ENABLE macros
619         https://bugs.webkit.org/show_bug.cgi?id=209307
620
621         Reviewed by Andy Estes.
622
623         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
624
625 2020-03-20  Jacob Uphoff  <jacob_uphoff@apple.com>
626
627         Unreviewed, reverting r258748.
628
629         This commit broke the Catalina build
630
631         Reverted changeset:
632
633         "Upstream a variety of Cocoa-platform HAVE and ENABLE macros"
634         https://bugs.webkit.org/show_bug.cgi?id=209307
635         https://trac.webkit.org/changeset/258748
636
637 2020-03-20  Aakash Jain  <aakash_jain@apple.com>
638
639         [ews] commit-queue should comment on bug if patch fails to apply
640         https://bugs.webkit.org/show_bug.cgi?id=209334
641
642         Reviewed by Jonathan Bedard.
643
644         * BuildSlaveSupport/ews-build/steps.py:
645         (ApplyPatch):
646         (ApplyPatch.evaluateCommand): Overridden to check build status and queue name and comment on bug accordingly.
647         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
648         (TestApplyPatch):
649         (TestApplyPatch.setUp):
650         (TestApplyPatch.setUp.mock_start):
651         (TestApplyPatch.tearDown):
652         (TestApplyPatch.test_success):
653         (TestApplyPatch.test_failure):
654         (TestApplyPatch.test_failure_on_commit_queue):
655
656 2020-03-20  Aakash Jain  <aakash_jain@apple.com>
657
658         [EWS] Limit number of builds to display in status-bubble hover over message in case of lot of retried builds
659         https://bugs.webkit.org/show_bug.cgi?id=209122
660
661         Reviewed by Jonathan Bedard.
662
663         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
664         (StatusBubble._build_bubble):
665
666 2020-03-19  Tim Horton  <timothy_horton@apple.com>
667
668         Upstream a variety of Cocoa-platform HAVE and ENABLE macros
669         https://bugs.webkit.org/show_bug.cgi?id=209307
670
671         Reviewed by Andy Estes.
672
673         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
674
675 2020-03-19  Alex Christensen  <achristensen@webkit.org>
676
677         Remove test failing after r258734
678         https://bugs.webkit.org/show_bug.cgi?id=209303
679
680         We removed the functionality it was testing because it did nothing useful except call the callback.
681         I'm about to remove the only user of WKContextGetStatistics.
682
683         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
684         * TestWebKitAPI/Tests/WebKit/WebCoreStatisticsWithNoWebProcess.cpp: Removed.
685
686 2020-03-19  Aakash Jain  <aakash_jain@apple.com>
687
688         commit-queue status-bubble shows incorrect position in queue
689         https://bugs.webkit.org/show_bug.cgi?id=209313
690
691         Reviewed by Jonathan Bedard.
692
693         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
694         (StatusBubble._queue_position):
695
696 2020-03-19  Takashi Komori  <Takashi.Komori@sony.com>
697
698         [Curl] Add an API returns description of verification errors.
699         https://bugs.webkit.org/show_bug.cgi?id=208913
700
701         Reviewed by Fujii Hironori.
702
703         WKCertificateInfoCopyVerificationErrorDescription returns the description of SSL verification error as human readable string.
704         Browser can display more precise error information with this API.
705
706         API Test: Curl.CertificateAPI
707
708         * MiniBrowser/win/Common.cpp:
709         (askServerTrustEvaluation):
710         * MiniBrowser/win/Common.h:
711         * MiniBrowser/win/WebKitBrowserWindow.cpp:
712         (createPEMString):
713         (WebKitBrowserWindow::canTrustServerCertificate):
714         * TestWebKitAPI/Tests/WebKit/curl/Certificates.cpp:
715         (TestWebKitAPI::Curl::TEST):
716
717 2020-03-19  Aakash Jain  <aakash_jain@apple.com>
718
719         Update build.webkit.org link for EWS
720         https://bugs.webkit.org/show_bug.cgi?id=209280
721
722         Reviewed by Alexey Proskuryakov.
723
724         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
725
726 2020-03-19  Stephan Szabo  <stephan.szabo@sony.com>
727
728         [WinCairo] extract-built-product fails after r258612
729         https://bugs.webkit.org/show_bug.cgi?id=209285
730
731         extractBuiltProduct also references the old name for the
732         requirements on wincairo.
733
734         Reviewed by Ross Kirsling.
735
736         * BuildSlaveSupport/built-product-archive:
737
738 2020-03-19  Philippe Normand  <pnormand@igalia.com>
739
740         [Flatpak SDK] Release logs not sent to journald when running within the SDK runtime
741         https://bugs.webkit.org/show_bug.cgi?id=209223
742
743         Reviewed by Carlos Alberto Lopez Perez.
744
745         flatpak build doesn't expose a --socket option for white-listing
746         the systemd journal socket. So white-list everything in /run. 🤷
747
748         * flatpak/flatpakutils.py:
749         (WebkitFlatpak.run_in_sandbox):
750
751 2020-03-19  Charlie Turner  <cturner@igalia.com>
752
753         Fix many warnings with Clang 7.0 on GTK x86-64 in Debug.
754         https://bugs.webkit.org/show_bug.cgi?id=209146
755
756         Reviewed by Darin Adler.
757
758         * TestWebKitAPI/Tests/WebCore/TransformationMatrix.cpp:
759         (TestWebKitAPI::TEST):
760         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
761         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
762         (testDownloadMIMEType):
763         (testContextMenuDownloadActions):
764         * TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp:
765
766 2020-03-19  Carlos Garcia Campos  <cgarcia@igalia.com>
767
768         [GTK][WPE] REGRESSION(r258626): flatpak is used even when WEBKIT_JHBUILD is set
769         https://bugs.webkit.org/show_bug.cgi?id=209278
770
771         Reviewed by Philippe Normand.
772
773         This happens when using an external jhbuild, because shouldUseFlatpak() assumes that no command prefix always
774         means flatpak.
775
776         * Scripts/webkitdirs.pm:
777         (shouldUseFlatpak): Return early if WEBKIT_JHBUILD is set.
778
779 2020-03-19  Philippe Normand  <pnormand@igalia.com>
780
781         [CMake] cache not cleared when build-webkit options change
782         https://bugs.webkit.org/show_bug.cgi?id=209277
783
784         Reviewed by Adrian Perez de Castro.
785
786         * Scripts/webkitdirs.pm:
787         (shouldRemoveCMakeCache): The expected function signature never
788         included the cache file path. Remove it.
789
790 2020-03-18  Philippe Normand  <pnormand@igalia.com>
791
792         REGRESSION(r258626): webkit-dirs warning
793         https://bugs.webkit.org/show_bug.cgi?id=209221
794
795         Reviewed by Adrian Perez de Castro.
796
797         * Scripts/webkitdirs.pm:
798         (buildCMakeProjectOrExit): Fix Perl Warning. 😎
799
800 2020-03-19  Chris Lord  <clord@igalia.com>
801
802         Add Chris Lord (clord@igalia.com) to the list of contributors
803         https://bugs.webkit.org/show_bug.cgi?id=209274
804
805         Unreviewed
806
807         * Scripts/webkitpy/common/config/contributors.json:
808
809 2020-03-19  Ryan Haddad  <ryanhaddad@apple.com>
810
811         Remove commit queue bubble from bot watchers dashboard
812         https://bugs.webkit.org/show_bug.cgi?id=209271
813
814         Reviewed by Alexey Proskuryakov.
815
816         Remove commit queue bubble from bot watchers dashboard now that it has moved to the new EWS.
817
818         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
819         (BubbleQueueServer): 
820
821 2020-03-18  Simon Fraser  <simon.fraser@apple.com>
822
823         eventSender.monitorWheelEvents() is very fragile
824         https://bugs.webkit.org/show_bug.cgi?id=197819
825         <rdar://problem/51319456>
826
827         Reviewed by Tim Horton.
828
829         Deflake tests using eventSender.monitorWheelEvents() by fixing several causes of flakiness,
830         adding back changes from r257844 that were reverted in r258558.
831         
832         First, have EventSendingController keep track of whether it's seen then "end" event
833         for the scrolling and momentum phases, and pass this down to WheelEventTestMonitor, which
834         now waits until it sees these, which prevents premature triggering which was a common cause of
835         failure before.
836         
837         Second, remove WheelEventTestMonitor's 1/60s timer and instead have WheelEventTestMonitor test
838         for completion in a callout from the end of Page::updateRendering(), which makes it test
839         and fire at a more consistent time.
840         
841         Third, push WheelEventTestMonitor to the ScrollingTree, so that reasons for deferral
842         can be added on the scrolling thread. This fixes an issue where the RunLoop::main().dispatch()
843         used to send the "ScrollingThreadSyncNeeded" reason to the main thread would get delayed,
844         also resulting in a premature trigger.
845
846         * DumpRenderTree/mac/EventSendingController.h:
847         * DumpRenderTree/mac/EventSendingController.mm:
848         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
849         (-[EventSendingController monitorWheelEvents]):
850         (-[EventSendingController callAfterScrollingCompletes:]):
851         * DumpRenderTree/win/EventSender.cpp:
852         (mouseScrollBy):
853         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
854         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
855         (WTR::EventSendingController::monitorWheelEvents):
856         (WTR::EventSendingController::callAfterScrollingCompletes):
857         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
858
859 2020-03-18  John Wilander  <wilander@apple.com>
860
861         WebResourceLoadStatisticsStore::requestStorageAccessUnderOpener() should call its ephemeral counterpart when appropriate
862         https://bugs.webkit.org/show_bug.cgi?id=209245
863         <rdar://problem/60511121>
864
865         Reviewed by Chris Dumez.
866
867         These changes to the TestRunner makes sure that
868         - statisticsClearInMemoryAndPersistentStore()
869         - statisticsClearInMemoryAndPersistentStoreModifiedSinceHours()
870         ... use their own StatisticsDidClearInMemoryAndPersistentStoreCallbackID
871         and adds the infrastructure for that.
872
873         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
874         (WTR::InjectedBundle::didReceiveMessageToPage):
875         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
876         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
877         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
878         (WTR::TestRunner::statisticsCallClearInMemoryAndPersistentStoreCallback):
879         * WebKitTestRunner/InjectedBundle/TestRunner.h:
880         * WebKitTestRunner/TestController.cpp:
881         (WTR::TestController::statisticsClearInMemoryAndPersistentStore):
882         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
883         * WebKitTestRunner/TestInvocation.cpp:
884         (WTR::TestInvocation::didClearStatisticsInMemoryAndPersistentStore):
885         * WebKitTestRunner/TestInvocation.h:
886
887 2020-03-18  Wenson Hsieh  <wenson_hsieh@apple.com>
888
889         REGRESSION (r257214): Targeted preview animates to the wrong place when dropping in editable content
890         https://bugs.webkit.org/show_bug.cgi?id=209218
891         <rdar://problem/60560831>
892
893         Reviewed by Tim Horton.
894
895         Augment the drag and drop test harness to verify that for all targeted previews, if they have container views,
896         those views must be parented (i.e. they must be connected to a UIWindow).
897
898         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
899         (-[DragAndDropSimulator _concludeDropAndPerformOperationIfNecessary]):
900         (-[DragAndDropSimulator _expectNoDropPreviewsWithUnparentedContainerViews]):
901         (-[DragAndDropSimulator _invokeDropAnimationCompletionBlocksAndConcludeDrop]):
902
903 2020-03-18  Aakash Jain  <aakash_jain@apple.com>
904
905         [ews] commit-queue should comment on bug in case of test failures
906         https://bugs.webkit.org/show_bug.cgi?id=209226
907
908         Reviewed by Jonathan Bedard.
909
910         * BuildSlaveSupport/ews-build/steps.py:
911         (AnalyzeLayoutTestsResults.report_failure): Comment on bug and set cq- in case of test failure on commit-queue.
912         (BuildLogLineObserver.outLineReceived): Drive-by fix to use single quotes instead of double quotes.
913         (SetBuildSummary): Ditto.
914         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-test.
915
916 2020-03-18  Philippe Normand  <pnormand@igalia.com>
917
918         REGRESSION (r258626): test262 tests failing to run on macOS with error 'Undefined subroutine &Test262::Runner::setConfiguration'
919         https://bugs.webkit.org/show_bug.cgi?id=209238
920
921         Reviewed by Jonathan Bedard.
922
923         * Scripts/test262-runner: Perform the flatpak check on Linux only.
924
925 2020-03-18  Stephan Szabo  <stephan.szabo@sony.com>
926
927         [WinCairo] archive-built-product fails after r258612
928         https://bugs.webkit.org/show_bug.cgi?id=209237
929
930         Reviewed by Alex Christensen.
931
932         * BuildSlaveSupport/built-product-archive:
933         Update name of version file for requirements version
934         file for wincairo.
935
936 2020-03-18  Aakash Jain  <aakash_jain@apple.com>
937
938         commit-queue should allow patches which are reviewed by patch author
939         https://bugs.webkit.org/show_bug.cgi?id=209231
940
941         Reviewed by Jonathan Bedard.
942
943         * BuildSlaveSupport/ews-build/steps.py:
944         (BugzillaMixin._does_patch_have_acceptable_review_flag):
945
946 2020-03-18  Philippe Normand  <pnormand@igalia.com>
947
948         [JHBuild] Flatpak used for run-minibrowser even when forcing jhbuild
949         https://bugs.webkit.org/show_bug.cgi?id=209222
950
951         Reviewed by Carlos Alberto Lopez Perez.
952
953         * Scripts/webkitdirs.pm:
954         (runInFlatpakIfAvailable): If a command wrapper is required it
955         means Flatpak shouldn't be used.
956
957 2020-03-18  Aakash Jain  <aakash_jain@apple.com>
958
959         [ews] commit-queue should comment on bug in case patch fails to build
960         https://bugs.webkit.org/show_bug.cgi?id=209227
961
962         Reviewed by Jonathan Bedard.
963
964         * BuildSlaveSupport/ews-build/steps.py:
965         (AnalyzeCompileWebKitResults.start):
966         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-test.
967
968 2020-03-18  Philippe Normand  <pnormand@igalia.com>
969
970         [GTK][WPE] Migrate to Flatpak-based dev SDK
971         https://bugs.webkit.org/show_bug.cgi?id=205658
972
973         Reviewed by Carlos Alberto Lopez Perez.
974
975         JHBuild will now be used only if the WEBKIT_JHBUILD environment
976         variable is set to 1, which is the case for the time being on the
977         GTK and WPE EWS/build bots.
978
979         By default the build dependencies are now locally installed from a
980         Flatpak repository hosted at https://software.igalia.com. The
981         repository can be regenerated with the scripts from the
982         webkit-flatpak-sdk Github project
983         (https://github.com/Igalia/webkit-flatpak-sdk). This is done
984         transparently with the update-webkit{gtk,wpe}-libs scripts. As
985         there is no need to rebuild the dependencies from scratch, the
986         developer user-experience should now be much more friendly and
987         overall build times reduced.
988
989         As an additional commodity, the new environment supports the
990         GStreamer gst-build-based workflow. Just set the GST_BUILD_PATH
991         environment variable to your gst-build path. This feature was
992         contributed by Thibault Saunier.
993
994         The JHBuild infrastructure will be removed once all the bots have
995         been switched over to Flatpak.
996
997         * BuildSlaveSupport/ews-build/steps.py:
998         (InstallGtkDependencies):
999         (InstallWpeDependencies):
1000         (CompileWebKit.start):
1001         * BuildSlaveSupport/gtk/buildbot/run:
1002         * Scripts/build-webkit:
1003         * Scripts/run-bindings-tests:
1004         * Scripts/run-builtins-generator-tests:
1005         * Scripts/run-gtk-tests:
1006         * Scripts/run-javascriptcore-tests:
1007         * Scripts/run-minibrowser:
1008         * Scripts/run-qt-wpe-minibrowser:
1009         * Scripts/run-webdriver-tests:
1010         * Scripts/run-wpe-tests:
1011         * Scripts/test-webkitperl:
1012         * Scripts/test-webkitpy:
1013         * Scripts/test262-runner:
1014         * Scripts/update-webkit-flatpak: Renamed from Tools/Scripts/update-webkitgtk-flatpak.
1015         * Scripts/update-webkitgtk-libs:
1016         * Scripts/update-webkitwpe-flatpak: Removed.
1017         * Scripts/update-webkitwpe-libs:
1018         * Scripts/webkitdirs.pm:
1019         (getUserFlatpakPath):
1020         (inFlatpakSandbox):
1021         (runInFlatpakIfAvailable):
1022         (wrapperPrefixIfNeeded):
1023         (shouldUseJhbuild):
1024         (shouldUseFlatpak):
1025         (shouldRemoveCMakeCache):
1026         * Scripts/webkitpy/common/system/executive.py:
1027         (Executive.kill_all):
1028         * Scripts/webkitpy/port/base.py:
1029         (Port._path_to_apache):
1030         (Port._should_run_as_pixel_test):
1031         (Port._in_flatpak_sandbox):
1032         * Scripts/webkitpy/port/gtk.py:
1033         (GtkPort.setup_environ_for_server):
1034         (GtkPort._get_crash_log):
1035         * Scripts/webkitpy/port/linux_get_crash_log.py:
1036         (GDBCrashLogGenerator):
1037         (GDBCrashLogGenerator.__init__):
1038         (GDBCrashLogGenerator.generate_crash_log):
1039         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
1040         (GDBCrashLogGeneratorTest.test_generate_crash_log):
1041         * Scripts/webkitpy/port/wpe.py:
1042         (WPEPort.setup_environ_for_server):
1043         (WPEPort._get_crash_log):
1044         * Scripts/webkitpy/port/xvfbdriver.py:
1045         (XvfbDriver._setup_environ_for_test):
1046         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1047         (WTR::getFontsPath):
1048         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
1049         (WTR::getFontsPath):
1050         * flatpak/files/default.xkm: Removed.
1051         * flatpak/files/httpd-autogen.sh: Removed.
1052         * flatpak/flatpakutils.py:
1053         (check_flatpak):
1054         (FlatpakRepos.update):
1055         (FlatpakPackage.__repr__):
1056         (FlatpakPackage.__str__):
1057         (WebkitFlatpak.load_from_args):
1058         (WebkitFlatpak.__init__):
1059         (WebkitFlatpak.clean_args):
1060         (WebkitFlatpak.setup_builddir):
1061         (WebkitFlatpak):
1062         (WebkitFlatpak.setup_gstbuild):
1063         (WebkitFlatpak.run_in_sandbox):
1064         (WebkitFlatpak.run):
1065         (WebkitFlatpak.has_environment):
1066         (WebkitFlatpak.save_config):
1067         (WebkitFlatpak.setup_dev_env):
1068         (WebkitFlatpak.install_all):
1069         (WebkitFlatpak.run_gdb):
1070         * flatpak/org.webkit.CommonModules.yaml: Removed.
1071         * flatpak/org.webkit.GTK.yaml: Removed.
1072         * flatpak/org.webkit.WPE.yaml: Removed.
1073         * flatpak/org.webkit.WPEModules.yaml: Removed.
1074         * flatpak/org.webkit.WPEQT.yaml: Removed.
1075         * flatpak/org.webkit.WebKit.yaml: Removed.
1076         * flatpak/patches/httpd-0001-configure-use-pkg-config-for-PCRE-detection.patch: Removed.
1077         * flatpak/patches/libgcrypt-0001-Use-pkg-config-to-detect-gpg-error.patch: Removed.
1078         * flatpak/patches/xvfb-0001-HACK-Avoid-compiling-a-kbm-file.patch: Removed.
1079
1080 2020-03-17  Kate Cheney  <katherine_cheney@apple.com>
1081
1082         Expand In-App-Browser-Privacy testing
1083         https://bugs.webkit.org/show_bug.cgi?id=209142
1084         <rdar://problem/60496618>
1085
1086         Reviewed by Darin Adler.
1087
1088         Expanded test coverage by adding new tests and creating a custom url
1089         scheme handler to get around the fact that local file loads are
1090         always classified as app-bound.
1091
1092         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1093         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
1094         (-[InAppBrowserSchemeHandler webView:startURLSchemeTask:]):
1095         If the path indicates testing user scripts on load, notify the script message
1096         handler that the navigation has finished. If the path indicates
1097         testing user-agent scripts, set the window.wkUserScriptInjected
1098         variable to true. A user agent script will attempt to read this
1099         variable and should fail.
1100
1101         (-[InAppBrowserSchemeHandler webView:stopURLSchemeTask:]):
1102         (initializeInAppBrowserPrivacyTestSettings):
1103         Basic test setup. Initialize the main run loop and make sure we are
1104         starting with a clean state.
1105
1106         (TEST):
1107         Add tests for all protocols checked in shouldBeTreatedAsAppBound,
1108         except for blob files which must be generated within the web content.
1109
1110         * TestWebKitAPI/Tests/WebKitCocoa/in-app-browser-privacy-local-file.html: Added.
1111         Basic html document to test local file loads are classified as
1112         app-bound.
1113
1114         * TestWebKitAPI/Tests/WebKitCocoa/in-app-browser-privacy-test-user-agent-script.html: Removed.
1115         * TestWebKitAPI/Tests/WebKitCocoa/in-app-browser-privacy-test-user-script.html: Removed.
1116         These files are no longer needed as their content is directly copied
1117         into the URL scheme handler.
1118
1119 2020-03-17  Chris Dumez  <cdumez@apple.com>
1120
1121         REGRESSION: [ macOS wk1 ] ASSERTION FAILED: _notifications.contains(notificationID) imported/w3c/web-platform-tests/notifications/constructor-basic.html is flaky crashing
1122         https://bugs.webkit.org/show_bug.cgi?id=207307
1123         <rdar://problem/59206964>
1124
1125         Reviewed by Alex Christensen.
1126
1127         When [MockWebNotificationProvider reset] was called at the end of the test, it would remove all
1128         notifications from the map but not tell WebCore that the notification were discarded. As a result,
1129         WebCore would later tell the MockWebNotificationProvider to cancel the notification but this
1130         notification would no longer be in the map, causing us to hit an assertion in debug.
1131
1132         To address the issue, we now call Notification::finalize() in [MockWebNotificationProvider reset]
1133         to let WebCore know the notification was discarded. This is similar to what is already done for
1134         WebKit2 in WebNotificationManager::clearNotifications().
1135
1136         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
1137         (-[MockWebNotificationProvider reset]):
1138
1139 2020-03-17  Don Olmstead  <don.olmstead@sony.com>
1140
1141         [WinCairo][FTW] Update path to requirements download
1142         https://bugs.webkit.org/show_bug.cgi?id=209202
1143
1144         Reviewed by Ross Kirsling.
1145
1146         Repository was renamed from WinCairoRequirements to WebKitRequirements in the
1147         WebKitForWindows org on GitHub. Additionally the .zip file was renamed to
1148         WebKitRequirementsWin64.zip.
1149
1150         * Scripts/update-webkit-wincairo-libs.py:
1151
1152 2020-03-17  Aakash Jain  <aakash_jain@apple.com>
1153
1154         [ews] Resubmit patches to commit-queue which were cq- by commit-queue and later cq+
1155         https://bugs.webkit.org/show_bug.cgi?id=208920
1156
1157         Reviewed by Jonathan Bedard.
1158
1159         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
1160         (Buildbot.update_builder_name_to_id_mapping): Method to generate builder name to id mapping.
1161         (Buildbot.fetch_pending_and_inprogress_builds): Method to fetch pendign and in-progress builds from buildbot.
1162         (Buildbot.get_patches_in_queue): Method to fetch list of patches which are pending or are in-progress on buildbot.
1163         * BuildSlaveSupport/ews-app/ews/common/bugzilla.py:
1164         (Bugzilla.get_cq_plus_timestamp): Get UTC timestamp when cq+ flag was set.
1165         * BuildSlaveSupport/ews-app/ews/fetcher.py:
1166         (FetchLoop.run): Update builder name to id mapping. We just need to update it one-time, since we need the id only
1167         for commit-queue which isn't expected to change.
1168         (BugzillaPatchFetcher.fetch_commit_queue_patches):
1169         (BugzillaPatchFetcher.send_patches_to_buildbot): Allow sending the patch again to commit-queue.
1170         (BugzillaPatchFetcher.patches_to_send_to_commit_queue): Find patches which needs to be sent to commit-queue. Filter
1171         out patches which are already waiting or in-progress on commit-queue, or whose recent build was completed after
1172         setting cq+ flag on bugzilla.
1173
1174 2020-03-17  Chris Dumez  <cdumez@apple.com>
1175
1176         [WKTR] testRunner API that takes in a completion handler should use async IPC
1177         https://bugs.webkit.org/show_bug.cgi?id=209187
1178
1179         Reviewed by John Wilander.
1180
1181         testRunner API that takes in a completion handler should use async IPC. This hangs
1182         the WebProcess for no reason and can cause deadlocks if the UIProcess then tries
1183         to IPC the WebProcess as a result of this testRunner call.
1184
1185         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1186         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
1187         (WTR::TestRunner::statisticsUpdateCookieBlocking):
1188         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
1189         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
1190         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
1191         (WTR::TestRunner::setStatisticsShouldDowngradeReferrer):
1192         (WTR::TestRunner::setStatisticsFirstPartyWebsiteDataRemovalMode):
1193         (WTR::TestRunner::statisticsResetToConsistentState):
1194         (WTR::TestRunner::getAllStorageAccessEntries):
1195         (WTR::TestRunner::removeAllSessionCredentials):
1196         (WTR::TestRunner::getApplicationManifestThen):
1197         * WebKitTestRunner/TestInvocation.cpp:
1198         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1199         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1200
1201 2020-03-17  Aakash Jain  <aakash_jain@apple.com>
1202
1203         [ews-app] Timestamp shown in status-bubble hover-over message is in future
1204         https://bugs.webkit.org/show_bug.cgi?id=196628
1205
1206         Reviewed by Jonathan Bedard.
1207
1208         * BuildSlaveSupport/ews-build/events.py:
1209         (JSONProducer.json_serialize_datetime): Keep the timestamp in UTC, instead of converting it to local time zone.
1210         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1211         (StatusBubble.get_all_builds_for_queue): Sort the queues based on build number instead of start time, since the 
1212         timestamps for new builds might be less than timestamps for old builds which completed immediately prior to this change.
1213
1214 2020-03-17  Alex Christensen  <achristensen@webkit.org>
1215
1216         Add WKUIDelegatePrivate SPI _webView:printFrame:completionHandler:
1217         https://bugs.webkit.org/show_bug.cgi?id=209192
1218         <rdar://problem/51313336>
1219
1220         Reviewed by Geoff Garen.
1221
1222         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
1223         (-[PrintDelegateWithCompletionHandler _webView:printFrame:completionHandler:]):
1224         (-[PrintDelegateWithCompletionHandler waitForPrintFrameCall]):
1225         (TEST):
1226
1227 2020-03-17  Chris Dumez  <cdumez@apple.com>
1228
1229         Use less sync IPC for ITP testRunner methods
1230         https://bugs.webkit.org/show_bug.cgi?id=209184
1231
1232         Reviewed by Alex Christensen.
1233
1234         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1235         (WTR::TestRunner::setStatisticsDebugMode):
1236         (WTR::TestRunner::setStatisticsPrevalentResourceForDebugMode):
1237         (WTR::TestRunner::setStatisticsLastSeen):
1238         (WTR::TestRunner::setStatisticsMergeStatistic):
1239         (WTR::TestRunner::setStatisticsPrevalentResource):
1240         (WTR::TestRunner::setStatisticsVeryPrevalentResource):
1241         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
1242         * WebKitTestRunner/TestInvocation.cpp:
1243         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1244         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1245
1246 2020-03-17  Chris Dumez  <cdumez@apple.com>
1247
1248         [WKTR] Crash when trying to open a new window in an ephemeral session test
1249         https://bugs.webkit.org/show_bug.cgi?id=209181
1250
1251         Reviewed by Geoffrey Garen.
1252
1253         Make sure that the new WKWebView is using the same data store as its related WKWebView.
1254
1255         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1256         (WTR::TestController::platformCreateOtherPage):
1257
1258 2020-03-17  Jacob Uphoff  <jacob_uphoff@apple.com>
1259
1260         Unreviewed, reverting r257844.
1261
1262         this revision caused a test to start timing out
1263
1264         Reverted changeset:
1265
1266         "(r256513) [ Mac ] fast/scrolling/programmatic-scroll-to-zero-
1267         zero.html is a flaky failure"
1268         https://bugs.webkit.org/show_bug.cgi?id=207948
1269         https://trac.webkit.org/changeset/257844
1270
1271 2020-03-16  Justin Michaud  <justin_michaud@apple.com>
1272
1273         Add personal email to Tools/Scripts/webkitpy/common/config/contributors.json
1274         https://bugs.webkit.org/show_bug.cgi?id=209151
1275
1276         Reviewed by Yusuke Suzuki.
1277
1278         * Scripts/webkitpy/common/config/contributors.json:
1279
1280 2020-03-16  Chris Dumez  <cdumez@apple.com>
1281
1282         Crash under WebCookieCache::clearForHost()
1283         https://bugs.webkit.org/show_bug.cgi?id=209149
1284         <rdar://problem/60453086>
1285
1286         Reviewed by Alex Christensen.
1287
1288         Add API test coverage.
1289
1290         * TestWebKitAPI/Tests/WebKitCocoa/CookiePrivateBrowsing.mm:
1291         (TEST):
1292
1293 2020-03-16  Keith Rollin  <krollin@apple.com>
1294
1295         Remove support for WebKitSystemInterface
1296         https://bugs.webkit.org/show_bug.cgi?id=208894
1297         <rdar://problem/60297590>
1298
1299         Reviewed by Brent Fulgham.
1300
1301         This project provided support for facilities that are now handled
1302         elsewhere and is no longer needed.
1303
1304         * Scripts/copy-webkitlibraries-to-product-directory:
1305
1306 2020-03-16  Per Arne Vollan  <pvollan@apple.com>
1307
1308         [macOS] Accessibility sandbox regressions
1309         https://bugs.webkit.org/show_bug.cgi?id=209065
1310
1311         Reviewed by Brent Fulgham.
1312
1313         * TestWebKitAPI/Tests/WebKit/EnableAccessibility.mm:
1314         (TEST):
1315         * TestWebKitAPI/Tests/WebKit/GrantAccessToPreferencesService.mm:
1316         (TEST):
1317
1318 2020-03-16  Ryan Haddad  <ryanhaddad@apple.com>
1319
1320         Unreviewed infrastructure fix.
1321
1322         * BuildSlaveSupport/ews-build/config.json: Temporarily remove ews114
1323         while the hardware is out for repair.
1324
1325 2020-03-13  Sergio Villar Senin  <svillar@igalia.com>
1326
1327         [WebXR] IDLs, stubs and build configuration for WPE
1328         https://bugs.webkit.org/show_bug.cgi?id=208702
1329
1330         Reviewed by Dean Jackson.
1331
1332         * Scripts/webkitperl/FeatureList.pm: Added WebXR.
1333         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Added ENABLE_WEBXR, off by default.
1334
1335 2020-03-16  Per Arne Vollan  <pvollan@apple.com>
1336
1337         [Cocoa] Limit set of classes that can be decoded when a preference has changed
1338         https://bugs.webkit.org/show_bug.cgi?id=208012
1339
1340         Reviewed by Brent Fulgham.
1341
1342         * TestWebKitAPI/Tests/WebKit/PreferenceChanges.mm:
1343         (TEST):
1344
1345 2020-03-16  youenn fablet  <youenn@apple.com>
1346
1347         Unique origins should not be Potentially Trustworthy
1348         https://bugs.webkit.org/show_bug.cgi?id=209049
1349
1350         Reviewed by Darin Adler.
1351
1352         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
1353         (TestWebKitAPI::TEST_F):
1354
1355 2020-03-15  Fujii Hironori  <Hironori.Fujii@sony.com>
1356
1357         KeyedDecoderGeneric fails to allocate Vector while decoding broken data
1358         https://bugs.webkit.org/show_bug.cgi?id=207324
1359
1360         Reviewed by Darin Adler.
1361
1362         * TestWebKitAPI/Tests/WebCore/KeyedCoding.cpp:
1363         (TestWebKitAPI::generateRandomData): Added.
1364         (TestWebKitAPI::KeyedCoding.DecodeRandomData): Added a new test decoding random data.
1365
1366 2020-03-15  Yusuke Suzuki  <ysuzuki@apple.com>
1367
1368         Should not use variable-length-array (VLA)
1369         https://bugs.webkit.org/show_bug.cgi?id=209043
1370
1371         Reviewed by Mark Lam.
1372
1373         * ContentExtensionTester/Configurations/Base.xcconfig:
1374         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
1375
1376 2020-03-13  Alex Christensen  <achristensen@webkit.org>
1377
1378         WKWebView._negotiatedLegacyTLS should be correct after back/forward navigations
1379         https://bugs.webkit.org/show_bug.cgi?id=209011
1380         <rdar://problem/59370588>
1381
1382         Reviewed by Youenn Fablet.
1383
1384         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
1385         (TestWebKitAPI::TEST):
1386
1387 2020-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
1388
1389         [watchOS] Don’t display empty text suggestions in Quickboard when editing input fields
1390         https://bugs.webkit.org/show_bug.cgi?id=209089
1391
1392         Reviewed by Tim Horton.
1393
1394         Add an API test for watchOS. Also rename a few occurrences of "Autofill" to "AutoFill", to reflect the official
1395         marketing name for the feature.
1396
1397         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1398         (runUntilReceivesAutoplayEvent):
1399
1400         Additionally fix the watchOS engineering build for arm64_32, which was failing due to comparisons between 64-bit
1401         and 32-bit integers. This is because this function took a `WKAutoplayEvent` (a 32-bit integer), but compared
1402         against the `_WKAutoplayEvent` type (an NSInteger that is 64 bits on this architecture). There didn't seem to
1403         be any compelling reason to compare against different types here (especially since we only set
1404         `receivedAutoplayEvent` under the Objective-C delegate method that provides a `_WKAutoplayEvent`), so I changed
1405         these all to be `_WKAutoplayEvent`.
1406
1407         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1408         (-[AutoFillTestView _autofillInputView]):
1409         (-[AutoFillTestView textInputHasAutoFillContext]):
1410         (TestWebKitAPI::TEST):
1411         (-[AutofillTestView initWithFrame:]): Deleted.
1412         (-[AutofillTestView _autofillInputView]): Deleted.
1413         (-[AutofillTestView textInputHasAutofillContext]): Deleted.
1414         * TestWebKitAPI/ios/UIKitSPI.h:
1415
1416 2020-03-13  Chris Dumez  <cdumez@apple.com>
1417
1418         Unreviewed, reverting r256232.
1419
1420         Caused ResizeObserver tests to become flaky
1421
1422         Reverted changeset:
1423
1424         "[DRT] InternalSettingsGenerated::resetToConsistentState() may
1425         override TestOptions"
1426         https://bugs.webkit.org/show_bug.cgi?id=207481
1427         https://trac.webkit.org/changeset/256232
1428
1429 2020-03-13  Kate Cheney  <katherine_cheney@apple.com>
1430
1431         [ iOS and Mac wk2 ] http/tests/in-app-browser-privacy/ tests failing
1432         https://bugs.webkit.org/show_bug.cgi?id=209016
1433         <rdar://problem/60329530> 
1434
1435         Reviewed by Chris Dumez.
1436
1437         Re-initialize the app-bound domains when the correct
1438         TestOptions parameter is set.
1439
1440         * WebKitTestRunner/TestController.cpp:
1441         (WTR::TestController::createWebViewWithOptions):
1442         (WTR::TestController::reinitializeAppBoundDomains):
1443         * WebKitTestRunner/TestController.h:
1444
1445 2020-03-13  Kate Cheney  <katherine_cheney@apple.com>
1446
1447         Report all third party loads on a per-page basis
1448         https://bugs.webkit.org/show_bug.cgi?id=209032
1449         <rdar://problem/60397323>
1450
1451         Reviewed by Chris Dumez.
1452
1453         Mostly naming updates to reflect the change in use for this SPI call.
1454         It now returns all loaded third party domains, not just prevalent ones.
1455
1456         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1457         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1458         (WTR::InjectedBundle::didReceiveMessageToPage):
1459         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1460         (WTR::TestRunner::getLoadedThirdPartyDomains):
1461         (WTR::TestRunner::callDidReceiveLoadedThirdPartyDomainsCallback):
1462         (WTR::TestRunner::getPrevalentDomains): Deleted.
1463         (WTR::TestRunner::callDidReceivePrevalentDomainsCallback): Deleted.
1464         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1465         * WebKitTestRunner/TestController.cpp:
1466         (WTR::TestController::resetStateToConsistentValues):
1467         (WTR::TestController::getLoadedThirdPartyDomains):
1468         (WTR::TestController::clearLoadedThirdPartyDomains):
1469         (WTR::TestController::getPrevalentDomains): Deleted.
1470         (WTR::TestController::clearPrevalentDomains): Deleted.
1471         * WebKitTestRunner/TestController.h:
1472         * WebKitTestRunner/TestInvocation.cpp:
1473         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1474         (WTR::TestInvocation::didReceiveLoadedThirdPartyDomains):
1475         (WTR::TestInvocation::didReceivePrevalentDomains): Deleted.
1476         * WebKitTestRunner/TestInvocation.h:
1477         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1478         (WTR::TestController::getLoadedThirdPartyDomains):
1479         (WTR::TestController::clearLoadedThirdPartyDomains):
1480         (WTR::TestController::getPrevalentDomains): Deleted.
1481         (WTR::TestController::clearPrevalentDomains): Deleted.
1482
1483 2020-03-13  Aakash Jain  <aakash_jain@apple.com>
1484
1485         [ews] run FindModifiedChangeLogs early in the build
1486         https://bugs.webkit.org/show_bug.cgi?id=209060
1487
1488         Reviewed by Jonathan Bedard.
1489
1490         * BuildSlaveSupport/ews-build/factories.py:
1491         * BuildSlaveSupport/ews-build/factories_unittest.py: Updated unit-test.
1492
1493 2020-03-13  Diego Pino Garcia  <dpino@igalia.com>
1494
1495         [GTK] Add EWS testers to run GTK layout tests
1496         https://bugs.webkit.org/show_bug.cgi?id=207648
1497
1498         Reviewed by Carlos Alberto Lopez Perez and Aakash Jain.
1499
1500         Queue 'GTK-Webkit2-EWS' was renamed to 'GTK-Build-EWS'.
1501         A new queue, named 'GTK-WK2-Tests-EWS', was added for WK2
1502         tests (layout tests).
1503
1504         * BuildSlaveSupport/ews-build/config.json: Added new queue for
1505         WK2 tests.
1506         * BuildSlaveSupport/ews-build/factories.py:
1507         (GTKTestsFactory):
1508         * BuildSlaveSupport/ews-build/factories_unittest.py:
1509         (TestCommitQueueFactory.test_commit_queue_factory):
1510         (TestGTKFactory): Added unit-test.
1511         (TestGTKFactory.test_gtk_factory):
1512         * BuildSlaveSupport/ews-build/loadConfig.py:
1513         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
1514         (TagsForBuilderTest.test_getTagsForBuilder):
1515
1516 2020-03-13  Aakash Jain  <aakash_jain@apple.com>
1517
1518         Add API endpoint in EWS django app to provide patch status in json format
1519         https://bugs.webkit.org/show_bug.cgi?id=208940
1520
1521         Reviewed by Jonathan Bedard.
1522
1523         * BuildSlaveSupport/ews-app/ews/urls.py: Added url for new api endpoint.
1524         * BuildSlaveSupport/ews-app/ews/views/status.py: Added.
1525
1526 2020-03-13  Kate Cheney  <katherine_cheney@apple.com>
1527
1528         WebKit2UseRemoteLayerTreeDrawingArea should be reset to NO between layout tests
1529         https://bugs.webkit.org/show_bug.cgi?id=209055
1530         <rdar://problem/60272692>
1531
1532         Reviewed by Simon Fraser.
1533
1534         Now that WebKitTestRunner has a bundleID, its' user default values
1535         persist between tests. This patch resets WebKit2UseRemoteLayerTreeDrawingArea
1536         to NO before running tests. It will be set to YES in PlatformWebView
1537         if specified by the test.
1538
1539         * WebKitTestRunner/mac/main.mm:
1540         (setDefaultsToConsistentValuesForTesting):
1541
1542 2020-03-13  Konstantin Tokarev  <annulen@yandex.ru>
1543
1544         [CMake] Eleminate mismatches between Find* module names and variables they set
1545         https://bugs.webkit.org/show_bug.cgi?id=208948
1546
1547         Reviewed by Michael Catanzaro.
1548
1549         * wpe/backends/CMakeLists.txt:
1550
1551 2020-03-13  Aakash Jain  <aakash_jain@apple.com>
1552
1553         [ews-app] reduce logging
1554         https://bugs.webkit.org/show_bug.cgi?id=209062
1555
1556         Reviewed by Jonathan Bedard.
1557
1558         * BuildSlaveSupport/ews-app/ews/common/bugzilla.py:
1559         (BugzillaBeautifulSoup.authenticate):
1560         (BugzillaBeautifulSoup._load_query):
1561
1562 2020-03-13  Ryosuke Niwa  <rniwa@webkit.org>
1563
1564         Crash in TextIterator::node via TextManipulationController::replace
1565         https://bugs.webkit.org/show_bug.cgi?id=209048
1566
1567         Reviewed by Wenson Hsieh.
1568
1569         Added a regression test.
1570
1571         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
1572         (TextManipulation.CompleteTextManipulationShouldReplaceContentsAroundParagraphWithJustImage):
1573
1574 2020-03-13  Saam Barati  <sbarati@apple.com>
1575
1576         Pull in JS tests from "Internal" when there are "Internal" tests in an adjacent directory
1577         https://bugs.webkit.org/show_bug.cgi?id=209038
1578
1579         Reviewed by Keith Miller.
1580
1581         This allows us to automatically pull in some tests that are in non open sourced Apple
1582         checkouts.
1583
1584         * Scripts/run-javascriptcore-tests:
1585         (runJSCStressTests):
1586
1587 2020-03-12  Ryosuke Niwa  <rniwa@webkit.org>
1588
1589         Crash in TextManipulationController::replace
1590         https://bugs.webkit.org/show_bug.cgi?id=209021
1591
1592         Reviewed by Wenson Hsieh.
1593
1594         Added a regression test.
1595
1596         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
1597         (TextManipulation.CompleteTextManipulationShouldReplaceContentFollowedAfterImageInCSSTable):
1598
1599 2020-03-12  Per Arne Vollan  <pvollan@apple.com>
1600
1601         [macOS] _AXSApplicationAccessibilityEnabled should not be called
1602         https://bugs.webkit.org/show_bug.cgi?id=208953
1603
1604         Reviewed by Brent Fulgham.
1605
1606         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1607
1608 2020-03-12  Kate Cheney  <katherine_cheney@apple.com>
1609
1610         Resource load statistics data summary should return all third party data
1611         https://bugs.webkit.org/show_bug.cgi?id=209000
1612         <rdar://problem/60348306>
1613
1614         Reviewed by John Wilander.
1615
1616         Marked only 2 of 3 domains prevalent in data summary tests to ensure
1617         the call returns all third parties, not just prevalent ones.
1618         Added a more aggressive check for the size of the array at the
1619         beginning of the test to ensure the array is still returning 3 values. 
1620         Also removed the ASSERT statements as they seem to cause timeouts (not
1621         clear crashes) when they are not true, which is hard to debug.
1622         If these values are nil, the test will fail in the EXPECT_WK_STREQ
1623         checks, we don't need ASSERT statements.
1624
1625         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1626         (TEST):
1627
1628 2020-03-12  Jonathan Bedard  <jbedard@apple.com>
1629
1630         resultsdpy: Add script to run local instance
1631         https://bugs.webkit.org/show_bug.cgi?id=208746
1632
1633         Rubber-stamped by Aakash Jain.
1634
1635         * resultsdbpy/resultsdbpy/example: Added.
1636         * resultsdbpy/resultsdbpy/example/__init__.py: Added.
1637         * resultsdbpy/resultsdbpy/example/environment.py: Added.
1638         (Environment): Organize environment variables used by results database.
1639         (ModelFromEnvironment): Construct the database model from the environment.
1640         (main): Create and drop tables, if required.
1641         * resultsdbpy/resultsdbpy/example/main.py: Added.
1642         (health): Web-server health check.
1643         (handle_errors):
1644         (main): Run results database web-server.
1645         * resultsdbpy/resultsdbpy/example/worker.py: Added.
1646         (main): Asynchronously process uploaded results.
1647         * resultsdbpy/resultsdbpy/run: Added.
1648
1649 2020-03-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1650
1651         run-webkit-tests --use-gpu-process should enable GPU Process for canvas
1652         https://bugs.webkit.org/show_bug.cgi?id=209004
1653
1654         Reviewed by Tim Horton.
1655
1656         Add "RenderCanvasInGPUProcessEnabled" to the list of internal features that should be enabled when
1657         `use_gpu_process` is specified.
1658
1659         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1660         (parse_args):
1661
1662 2020-03-12  Matt Lewis  <jlewis3@apple.com>
1663
1664         Make flatpack import for run-webkit-tests only happen on linux systems
1665         https://bugs.webkit.org/show_bug.cgi?id=208954
1666
1667         Reviewed by Philippe Normand.
1668
1669         * Scripts/run-webkit-tests: Added an if statement to find the system platform
1670         to determine if we need the flatpackutils import. 
1671
1672 2020-03-12  Alex Christensen  <achristensen@webkit.org>
1673
1674         WKWebView.hasOnlySecureContent should be correct after back/forward navigations
1675         https://bugs.webkit.org/show_bug.cgi?id=207609
1676
1677         Reviewed by Ryosuke Niwa.
1678
1679         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
1680         (TestWebKitAPI::TEST):
1681
1682 2020-03-12  Daniel Bates  <dabates@apple.com>
1683
1684         FocusController::setFocusedElement() should tell client of refocused element
1685         https://bugs.webkit.org/show_bug.cgi?id=208880
1686
1687         Reviewed by Wenson Hsieh.
1688
1689         Adds a test to ensure that calling -selectPositionAtPoint on an already focused element tries
1690         to start an input session. Currently, it does not even try.
1691
1692         * TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm:
1693         (TEST):
1694
1695 2020-03-12  Michael Catanzaro  <mcatanzaro@gnome.org>
1696
1697         [GTK] Use #!/usr/bin/python3 shebang to run generate-gtkdoc
1698         https://bugs.webkit.org/show_bug.cgi?id=208970
1699
1700         Reviewed by Daniel Bates.
1701
1702         Fedora and Ubuntu are both patching generate-gtkdoc to use #!/usr/bin/python3 rather than
1703         #!/usr/bin/env python.
1704
1705         #!/usr/bin/env and /usr/bin/python are both banned in Fedora packages. I guess Ubuntu
1706         probably has similar rules.
1707
1708         Note this is the only script that attempts to use /usr/bin/python in tarball builds.
1709         Everything else that does so is probably only used by webkit-build.
1710
1711         https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_multiple_python_runtimes
1712
1713         * gtkdoc/generate-gtkdoc:
1714
1715 2020-03-11  Jiewen Tan  <jiewen_tan@apple.com>
1716
1717         [WebAuthn] Formalize the Keychain schema
1718         https://bugs.webkit.org/show_bug.cgi?id=183533
1719         <rdar://problem/43347926>
1720
1721         Reviewed by Brent Fulgham.
1722
1723         Modifies the test infra to use Credential ID as the unique identifier for a credential instead of
1724         the original combination of RP ID and user handle.
1725
1726         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1727         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1728         (WTR::TestRunner::cleanUpKeychain):
1729         (WTR::TestRunner::keyExistsInKeychain):
1730         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1731         * WebKitTestRunner/TestController.h:
1732         * WebKitTestRunner/TestInvocation.cpp:
1733         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1734         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1735         (WTR::TestController::cleanUpKeychain):
1736         (WTR::TestController::keyExistsInKeychain):
1737
1738 2020-03-11  Keith Miller  <keith_miller@apple.com>
1739
1740         Test262-runner should always consider crashes as new failures
1741         https://bugs.webkit.org/show_bug.cgi?id=208943
1742
1743         Reviewed by Yusuke Suzuki.
1744
1745         Right now the runner will consider crashes with no output as passes, which is obviously bad.
1746         Since we should never crash on a conformance test we should consider a crash as a new failure
1747         100% of the time.
1748
1749         * Scripts/test262/Runner.pm:
1750         (processFile):
1751         (runTest):
1752         (processResult):
1753
1754 2020-03-11  Chris Dumez  <cdumez@apple.com>
1755
1756         Assertion hit under WebPageProxy::suspendCurrentPageIfPossible() when bypassing certificate warning page
1757         https://bugs.webkit.org/show_bug.cgi?id=208927
1758         <rdar://problem/55448331>
1759
1760         Reviewed by Alex Christensen.
1761
1762         Add API test coverage.
1763
1764         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1765
1766 2020-03-11  Diego Pino Garcia  <dpino@igalia.com>
1767
1768         [GTK] Switch EWS api-gtk bot from buildAndTest to testOnly
1769         https://bugs.webkit.org/show_bug.cgi?id=208860
1770
1771         Reviewed by Carlos Alberto Lopez Perez.
1772
1773         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1774         (StatusBubble): Added 'api-gtk'.
1775         * BuildSlaveSupport/ews-build/config.json:
1776         * BuildSlaveSupport/ews-build/factories.py:
1777         (BuildFactory.__init__): Call InstallGTKDependencies() if platform is
1778         GTK.
1779         (TestFactory.__init__): Call InstallGTKDependencies() if platform is
1780         GTK.
1781         (GTKBuildFactory):
1782         (GTKBuildFactory.__init__): Deleted.
1783         (GTKBuildAndTestFactory): Deleted.
1784         (GTKBuildAndTestFactory.__init__): Deleted.
1785         (GTKAPIBuildAndTestFactory): Deleted.
1786         * BuildSlaveSupport/ews-build/loadConfig.py:
1787
1788 2020-03-11  Aakash Jain  <aakash_jain@apple.com>
1789
1790         [ews] Add unit test to prevent multiple schedulers for a builder.
1791         https://bugs.webkit.org/show_bug.cgi?id=208917
1792
1793         Reviewed by Carlos Alberto Lopez Perez.
1794
1795         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
1796         (ConfigDotJSONTest.test_multiple_scheduers_for_builder): Added unit test.
1797         (TagsForBuilderTest): Fixed a typo.
1798
1799 2020-03-11 Philippe Normand  <pnormand@igalia.com>
1800
1801         [GTK] Failing API tests under the Flatpak SDK environment
1802         https://bugs.webkit.org/show_bug.cgi?id=208871
1803
1804         Reviewed by Michael Catanzaro.
1805
1806         The load-failed signal callback should return a boolean result,
1807         otherwise we enter in unknown territory depending on how the
1808         toolchain compiles this, possibly triggering bad behavior (with
1809         GCC 9.2 from the Flatpak SDK) or not caring at all (with current
1810         GCC toolchain on buildbots).
1811
1812         Patch suggested by Michael Catanzaro.
1813
1814         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
1815         (loadFailedCallback):
1816
1817 2020-03-10  Don Olmstead  <don.olmstead@sony.com>
1818
1819         Sync FeatureList.pm with CMake definitions
1820         https://bugs.webkit.org/show_bug.cgi?id=208866
1821
1822         Reviewed by Michael Catanzaro.
1823
1824         * Scripts/webkitperl/FeatureList.pm:
1825
1826 2020-03-10  Aakash Jain  <aakash_jain@apple.com>
1827
1828         [ews] Add unit tests for commit queue factory
1829         https://bugs.webkit.org/show_bug.cgi?id=208862
1830
1831         Reviewed by Jonathan Bedard.
1832
1833         * BuildSlaveSupport/ews-build/factories_unittest.py:
1834         (TestCommitQueueFactory):
1835         (TestCommitQueueFactory.test_commit_queue_factory): Added unit-test for commit-queue factory.
1836
1837 2020-03-10  Aakash Jain  <aakash_jain@apple.com>
1838
1839         [ews-app] Status bubble should only display important messages in pop-over - part 3
1840         https://bugs.webkit.org/show_bug.cgi?id=208865
1841
1842         Reviewed by Jonathan Bedard.
1843
1844         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1845         (StatusBubble): Added more strings to STEPS_TO_HIDE.
1846
1847 2020-03-10  Lauro Moura  <lmoura@igalia.com>
1848
1849         [WPE] MiniBrowser: Close child WebViews when exiting
1850         https://bugs.webkit.org/show_bug.cgi?id=208689
1851
1852         Reviewed by Carlos Garcia Campos.
1853
1854         Store created views so we can release them before exiting.
1855
1856         * MiniBrowser/wpe/main.cpp:
1857         (webViewClose):
1858         (createWebView):
1859         (main):
1860
1861 2020-03-10  Aakash Jain  <aakash_jain@apple.com>
1862
1863         Add ValidateCommiterAndReviewer and ValidateChangeLogAndReviewer build steps in commit-queue
1864         https://bugs.webkit.org/show_bug.cgi?id=208861
1865
1866         Reviewed by Jonathan Bedard.
1867
1868         * BuildSlaveSupport/ews-build/factories.py:
1869         (Factory.__init__): Remove verifycqplus parameter.
1870         (CommitQueueFactory): Inherit from factory.BuildFactory base class instead of custom Factory class.
1871         (CommitQueueFactory.__init__): Add required build steps, especially ValidateCommiterAndReviewer, 
1872         UpdateWorkingDirectory and ValidateChangeLogAndReviewer.
1873
1874 2020-03-10  Philippe Normand  <pnormand@igalia.com>
1875
1876         [GTK] API favicon test flaky timeouts
1877         https://bugs.webkit.org/show_bug.cgi?id=208189
1878
1879         Reviewed by Carlos Garcia Campos.
1880
1881         Sometimes the favicon changes already during the load. Keeping
1882         track of it in the WebView favicon property notification handler
1883         gets us rid of the race.
1884
1885         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
1886         (testFaviconDatabaseGetFavicon):
1887
1888 2020-03-10  Aakash Jain  <aakash_jain@apple.com>
1889
1890         Generate commit-queue status bubble from new EWS
1891         https://bugs.webkit.org/show_bug.cgi?id=208811
1892
1893         Reviewed by Jonathan Bedard.
1894
1895         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1896         (StatusBubble._build_bubbles_for_patch):
1897
1898 2020-03-09  Don Olmstead  <don.olmstead@sony.com>
1899
1900         Remove obsolete feature flags
1901         https://bugs.webkit.org/show_bug.cgi?id=208830
1902
1903         Reviewed by Alex Christensen.
1904
1905         Remove ENABLE_CUSTOM_SCHEME_HANDLER and ENABLE_MAC_VIDEO_TOOLBOX since they
1906         are no longer used.
1907
1908         Also remove ENABLE_POINTER_EVENTS since the FeaturesDefines.xcconfig was not modified
1909         when the compilation flag was removed in r258148.
1910
1911         Remove ENABLE_ACCELERATED_OVERFLOW_SCROLLING, ENABLE_CSS_IMAGE_ORIENTATION,
1912         ENABLE_CUSTOM_SCHEME_HANDLER, and ENABLE_FETCH_API from FeatureList.pm.
1913
1914         * Scripts/webkitperl/FeatureList.pm:
1915         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1916
1917 2020-03-09  Kate Cheney  <katherine_cheney@apple.com>
1918
1919         WebKitTestRunner bundleID should not be cleared before every test
1920         https://bugs.webkit.org/show_bug.cgi?id=208823
1921         <rdar://problem/60204539>
1922
1923         Reviewed by Per Arne Vollan.
1924
1925         This is causing test failures for layout tests which rely on the Info.plist 
1926         bundle identifier (not the one set via the override method).
1927
1928         * WebKitTestRunner/TestController.cpp:
1929         (WTR::TestController::createWebViewWithOptions):
1930         (WTR::TestController::ensureViewSupportsOptionsForTest):
1931         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1932
1933 2020-03-09  Per Arne Vollan  <pvollan@apple.com>
1934
1935         [macOS] Notification observer is not removed
1936         https://bugs.webkit.org/show_bug.cgi?id=208834
1937
1938         Reviewed by Tim Horton.
1939
1940         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1941         * TestWebKitAPI/Tests/WebKit/EnableAccessibility.mm: Added.
1942         (TEST):
1943
1944 2020-03-06  Brian Burg  <bburg@apple.com>
1945
1946         upload.py gets confused by git-svn checkouts, unable to upload test results from my desk build
1947         https://bugs.webkit.org/show_bug.cgi?id=208729
1948         <rdar://problem/60105447>
1949
1950         Reviewed by Jonathan Bedard.
1951
1952         Improve upload.py to look for the svn branch and revision for the 'webkit'
1953         project and prefer those to the git equivalents (eg, prefer trunk/rNNNNN to master/<hash>).
1954
1955         * Scripts/webkitpy/common/checkout/scm/git.py:
1956         (Git):
1957         (Git.git_svn_id_regexp):
1958         (Git._field_from_git_svn_id):
1959         (Git.svn_revision):
1960         (Git.svn_branch):
1961         (Git.svn_url):
1962         (Git.native_branch):
1963         Refactor svn revision, branch, url to use the same regexp and helper code.
1964
1965         * Scripts/webkitpy/common/checkout/scm/stub_repository.py:
1966         (StubRepository.svn_branch):
1967         Expose a stub since this is used unconditionally by Port.commits_for_upload.
1968
1969         * Scripts/webkitpy/common/checkout/scm/svn.py:
1970         (SVN.svn_branch):
1971         (SVN.native_revision):
1972         (SVN):
1973         (SVN.native_branch):
1974         Refactor so the actual implementation is contained in svn_revision / svn_branch.
1975         The native_* methods call out to the SVN equivalents since this is an SVN repository.
1976
1977         * Scripts/webkitpy/port/base.py:
1978         (Port.commits_for_upload):
1979         Add special git-svn handling for the WebKit repository so that SVN branch and revision
1980         is preferred over the git equivalents.
1981
1982 2020-03-09  Antoine Quint  <graouts@apple.com>
1983
1984         TestWebKitAPI fails to build on watchOS
1985         https://bugs.webkit.org/show_bug.cgi?id=208820
1986
1987         Reviewed by Tim Horton.
1988
1989         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
1990
1991 2020-03-09  Jonathan Bedard  <jbedard@apple.com>
1992
1993         resultsdbpy: Add tool to manage resultsdbpy container
1994         https://bugs.webkit.org/show_bug.cgi?id=208743
1995
1996         Rubber-stamped by Aakash Jain.
1997
1998         Add tool to start, stop and restart the resultsdbpy Docker container.
1999
2000         * resultsdbpy/resultsdbpy/container: Added.
2001
2002 2020-03-09  Carlos Garcia Campos  <cgarcia@igalia.com>
2003
2004         [GTK][WPE] Surrounding text for input methods should not be limited to the current paragraph
2005         https://bugs.webkit.org/show_bug.cgi?id=208706
2006
2007         Reviewed by Žan Doberšek.
2008
2009         Add test case to check surrounding text in multiline context.
2010
2011         * TestWebKitAPI/Tests/WebKitGLib/TestInputMethodContext.cpp:
2012         (testWebKitInputMethodContextSurrounding):
2013
2014 2020-03-08  Per Arne Vollan  <pvollan@apple.com>
2015
2016         [iOS] Mapping to UTI from tag and tag class should be performed in the UI process
2017         https://bugs.webkit.org/show_bug.cgi?id=208783
2018
2019         Reviewed by Brent Fulgham.
2020
2021         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2022
2023 2020-03-07  Ross Kirsling  <ross.kirsling@sony.com>
2024
2025         Replace the use of term "rollout" to "revert" in various tools
2026         https://bugs.webkit.org/show_bug.cgi?id=208775
2027
2028         Reviewed by Ryosuke Niwa.
2029
2030         See this webkit-dev thread for the originating discussion:
2031         https://lists.webkit.org/pipermail/webkit-dev/2020-March/031132.html
2032
2033         'rollout' is a confusing term to anyone unacquainted with WebKit;
2034         consensus seems to be that 'revert' would be the best replacement (as opposed to 'rollback').
2035
2036         Given the long legacy of this term within WebKit, it's important to deprecate and not remove 'rollout' commands.
2037         As such, this patch aims to make 'revert' the preferred term everywhere without making 'rollout' fail.
2038
2039         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Trac.js:
2040         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
2041         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2042         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js:
2043         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/trac_unittests.js:
2044         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2045         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
2046         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js:
2047         * BuildSlaveSupport/ews-build/steps.py:
2048         * BuildSlaveSupport/ews-build/steps_unittest.py:
2049         * Scripts/webkit-tools-completion.sh:
2050         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2051         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2052         * Scripts/webkitpy/common/checkout/scm/svn.py:
2053         * Scripts/webkitpy/common/net/bugzilla/attachment.py:
2054         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
2055         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2056         * Scripts/webkitpy/tool/bot/feeders.py:
2057         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
2058         * Scripts/webkitpy/tool/bot/irc_command.py:
2059         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2060         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
2061         * Scripts/webkitpy/tool/bot/sheriff.py:
2062         * Scripts/webkitpy/tool/commands/download.py:
2063         * Scripts/webkitpy/tool/commands/download_unittest.py:
2064         * Scripts/webkitpy/tool/commands/newcommitbot.py:
2065         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
2066         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2067         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
2068         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2069         * Scripts/webkitpy/tool/steps/__init__.py:
2070         * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
2071         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
2072         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
2073         * Scripts/webkitpy/tool/steps/reopenbugafterrevert.py: Renamed from Tools/Scripts/webkitpy/tool/steps/reopenbugafterrollout.py.
2074
2075 2020-03-07  David Quesada  <david_quesada@apple.com>
2076
2077         Crash in -[_WKRemoteObjectRegistry _invokeMethod:] block when calling a reply block after the web view has deallocated
2078         https://bugs.webkit.org/show_bug.cgi?id=208781
2079         rdar://problem/60061016
2080
2081         Reviewed by Alex Christensen.
2082
2083         Add a test that recreates the conditions of this crash:
2084         - Send a message from the injected bundle to the UI process that contains a reply block.
2085         - Hold a reference to the reply block.
2086         - Let the web view deallocate.
2087         - Call the block, and expect not to crash.
2088
2089         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.h:
2090         (localObjectInterface):
2091         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.mm:
2092         (-[LocalObject doSomethingWithCompletionHandler:]):
2093         (TEST):
2094         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistryPlugIn.mm:
2095         (-[RemoteObjectRegistryPlugIn callUIProcessMethodWithReplyBlock]):
2096
2097 2020-03-07  Ryosuke Niwa  <rniwa@webkit.org>
2098
2099         TextManipulationController should work with ARIA labels
2100         https://bugs.webkit.org/show_bug.cgi?id=208759
2101
2102         Reviewed by Wenson Hsieh.
2103
2104         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
2105         (TextManipulation.StartTextManipulationFindAttributeContent): Added.
2106         (TextManipulation.CompleteTextManipulationShouldPreserveOrderOfBlockImage): Updated
2107         the expected number of tokens for the first item as the very first image is correctly
2108         detected per the code change. 
2109         (TextManipulation.CompleteTextManipulationShouldReplaceAttributeContent): Added.
2110
2111 2020-03-07  Alex Christensen  <achristensen@webkit.org>
2112
2113         Regression r258042: Failing API test TestWebKitAPI.URLSchemeHandler.Frames
2114         https://bugs.webkit.org/show_bug.cgi?id=208767
2115
2116         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
2117         The frameID of the main frame before loading is only 0 on Mac right now.
2118         The test is still good because it validates that execution works in the main frame before loading.
2119
2120 2020-03-06  Aakash Jain  <aakash_jain@apple.com>
2121
2122         [ews] commit queue is not skipping layout tests for rollout patches
2123         https://bugs.webkit.org/show_bug.cgi?id=208716
2124
2125         Unreviewed minor fix.
2126
2127         * BuildSlaveSupport/ews-build/steps.py:
2128         (RunWebKitTests.doStepIf):
2129         (RunWebKit1Tests.doStepIf): Moved to base class RunWebKitTests.
2130         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-test.
2131
2132 2020-03-05  Sam Weinig  <weinig@apple.com>
2133
2134         Move JavaScriptCore related feature defines from FeatureDefines.xcconfig to PlatformEnableCocoa.h
2135         https://bugs.webkit.org/show_bug.cgi?id=207436
2136         <rdar://problem/59296762>
2137
2138         Reviewed by Darin Adler.
2139
2140         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2141         Remove JSC related defines.
2142
2143 2020-03-07  Chris Fleizach  <cfleizach@apple.com>
2144
2145         AX: Provide a way to run tests in isolated tree mode
2146         https://bugs.webkit.org/show_bug.cgi?id=208629
2147         <rdar://problem/60075583>
2148
2149         Reviewed by Ryosuke Niwa.
2150
2151         Provide the ability to run tests for accessibility in the isolated tree mode.
2152         This sends a flag over to the injected bundle which calls the right HIServices override so that
2153         the system thinks it is in isolated mode.
2154
2155         * Scripts/compare-webkit-configurations:
2156         (flag_for_comparison):
2157         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2158         (parse_args):
2159         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2160         (parse_args):
2161         * Scripts/webkitpy/port/driver.py:
2162         (Driver.cmd_line):
2163         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2164         (WTR::AccessibilityController::AccessibilityController):
2165         (WTR::AccessibilityController::setAccessibilityIsolatedTreeMode):
2166         (WTR::AccessibilityController::updateIsolatedTreeMode):
2167         (WTR::AccessibilityController::executeOnAXThreadIfPossible):
2168         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
2169         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2170         (WTR::InjectedBundle::didReceiveMessageToPage):
2171         (WTR::InjectedBundle::beginTesting):
2172         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2173         * WebKitTestRunner/Options.cpp:
2174         (WTR::handleOptionAccessibilityIsolatedTreeMode):
2175         (WTR::OptionsHandler::OptionsHandler):
2176         * WebKitTestRunner/Options.h:
2177         * WebKitTestRunner/TestController.cpp:
2178         (WTR::TestController::initialize):
2179         (WTR::TestController::resetPreferencesToConsistentValues):
2180         (WTR::TestController::resetStateToConsistentValues):
2181         * WebKitTestRunner/TestController.h:
2182         (WTR::TestController::accessibilityIsolatedTreeMode const):
2183
2184 2020-03-06  Per Arne Vollan  <pvollan@apple.com>
2185
2186         [Cocoa] Re-enable CFPrefs direct mode
2187         https://bugs.webkit.org/show_bug.cgi?id=208690
2188
2189         Reviewed by Brent Fulgham.
2190
2191         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2192         * TestWebKitAPI/Tests/WebKit/GrantAccessToPreferencesService.mm: Added.
2193         (TEST):
2194         * TestWebKitAPI/Tests/ios/AccessibilityTestsIOS.mm:
2195         (TestWebKitAPI::TEST):
2196
2197 2020-03-06  Kate Cheney  <katherine_cheney@apple.com>
2198
2199         UIProcess needs mechanism to specify AppBound domains
2200         https://bugs.webkit.org/show_bug.cgi?id=208528
2201         <rdar://problem/59980340>
2202
2203         Reviewed by Brent Fulgham.
2204
2205         Added test app-bound domains to the plist and tested that the domains
2206         are properly stored in the website data store after a navigation.
2207
2208         * TestWebKitAPI/Info.plist:
2209         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
2210         (TEST):
2211
2212 2020-03-06  Alex Christensen  <achristensen@webkit.org>
2213
2214         Add SPI to disable cross origin access control checks
2215         https://bugs.webkit.org/show_bug.cgi?id=208748
2216
2217         Reviewed by Tim Hatcher.
2218
2219         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
2220         Add a test that verifies this SPI allows Access-Control-Allow-Origin: * with credentials.
2221
2222 2020-03-06  Basuke Suzuki  <basuke.suzuki@sony.com>
2223
2224         [webkitpy] Fix executive on Windows to run wpt server correctly
2225         https://bugs.webkit.org/show_bug.cgi?id=208693
2226
2227         Reviewed by Jonathan Bedard.
2228
2229         Bug fix for Windows environment a) fixing a typo. b) fixing path
2230         c) fix how to kill subprocesses.
2231
2232         * Scripts/webkitpy/common/system/executive.py:
2233         (Executive._windows_kill_command):
2234         (Executive.interrupt):
2235         (Executive.kill_all):
2236         * Scripts/webkitpy/port/base.py:
2237         (Port.web_platform_test_server_doc_root):
2238
2239 2020-03-06  Alex Christensen  <achristensen@webkit.org>
2240
2241         Evaluating JavaScript in main frame before loading should succeed
2242         https://bugs.webkit.org/show_bug.cgi?id=208733
2243
2244         Reviewed by Tim Horton.
2245
2246         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
2247
2248 2020-03-06  Ryosuke Niwa  <rniwa@webkit.org>
2249
2250         TextManipulationController should preserve images
2251         https://bugs.webkit.org/show_bug.cgi?id=208692
2252
2253         Reviewed by Wenson Hsieh.
2254
2255         Added tests for preserving images and their ordering.
2256
2257         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
2258         (TextManipulation.CompleteTextManipulationShouldPreserveImagesAsExcludedTokens):
2259         (TextManipulation.CompleteTextManipulationShouldPreserveSVGAsExcludedTokens):
2260         (TextManipulation.CompleteTextManipulationShouldPreserveOrderOfBlockImage):
2261
2262 2020-03-06  David Quesada  <david_quesada@apple.com>
2263
2264         Add _WKResourceLoadInfo.resourceType SPI
2265         https://bugs.webkit.org/show_bug.cgi?id=208723
2266
2267         Reviewed by Alex Christensen.
2268
2269         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
2270         (TEST):
2271
2272 2020-03-06  Jonathan Bedard  <jbedard@apple.com>
2273
2274         Stop reporting to webkit-test-results.webkit.org
2275         https://bugs.webkit.org/show_bug.cgi?id=207218
2276
2277         Reviewed by Alexey Proskuryakov.
2278
2279         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2280         (RunWebKitTests):
2281
2282 2020-03-06  Sihui Liu  <sihui_liu@apple.com>
2283
2284         UIProcess crash after using _prepareForMoveToWindow, then deallocating the WKWebView before moving to the window
2285         https://bugs.webkit.org/show_bug.cgi?id=208365
2286         <rdar://problem/59877296>
2287
2288         Reviewed by Geoffrey Garen.
2289
2290         * TestWebKitAPI/Tests/WebKitCocoa/PrepareForMoveToWindow.mm:
2291         (TEST):
2292
2293 2020-03-06  Aakash Jain  <aakash_jain@apple.com>
2294
2295         EWS should be able to fetch patch status for security bugs while processing them
2296         https://bugs.webkit.org/show_bug.cgi?id=206511
2297
2298         Reviewed by Alexey Proskuryakov.
2299
2300         * BuildSlaveSupport/ews-build/steps.py:
2301         (BugzillaMixin.fetch_data_from_url_with_authentication): Method to fetch data from bugzilla using api key.
2302         (BugzillaMixin.get_patch_json): 
2303         (BugzillaMixin.get_bug_json):
2304         (BugzillaMixin._is_bug_closed):
2305         (ApplyPatch.hideStepIf): Use 'sensitive' build property instead of 'validated'.
2306         (TransferToS3.hideStepIf): Ditto.
2307
2308 2020-03-06  Aakash Jain  <aakash_jain@apple.com>
2309
2310         [ews] commit-queue should show the trac url for the commit on the build page
2311         https://bugs.webkit.org/show_bug.cgi?id=208715
2312
2313         Reviewed by Jonathan Bedard.
2314
2315         * BuildSlaveSupport/ews-build/steps.py:
2316         (PushCommitToWebKitRepo.evaluateCommand):
2317
2318 2020-03-06  Alex Christensen  <achristensen@webkit.org>
2319
2320         Fix ResourceLoadDelegate.LoadInfo API test after r257816
2321         https://bugs.webkit.org/show_bug.cgi?id=208550
2322
2323         * TestWebKitAPI/cocoa/HTTPServer.mm:
2324         (TestWebKitAPI::HTTPServer::respondToRequests):
2325         Sometimes we need a separate read to read the HTTP body after a request header, sometimes it comes in the same read.
2326         If it comes in the same read, send the response immediately.  Otherwise read the HTTP body then send the response.
2327
2328 2020-03-06  Lauro Moura <lmoura@igalia.com>
2329
2330         [WPE][WebDriver] MiniBrowser should react to close session commands
2331         https://bugs.webkit.org/show_bug.cgi?id=207529
2332
2333         Reviewed by Carlos Garcia Campos.
2334
2335         Do not call g_object_unref on the first created view if it has already
2336         been disposed in the "close" signal handler.
2337
2338         Based on original patch by Yury Semikhatsky.
2339
2340         * MiniBrowser/wpe/main.cpp:
2341         (main):
2342
2343 2020-03-06  Michael Catanzaro  <mcatanzaro@gnome.org>
2344
2345         [WPE][GTK] Use Firefox user agent quirk more aggressively on Google Docs
2346         https://bugs.webkit.org/show_bug.cgi?id=208647
2347
2348         Reviewed by Carlos Garcia Campos.
2349
2350         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2351         (TestWebKitAPI::TEST):
2352
2353 2020-03-05  Alex Christensen  <achristensen@webkit.org>
2354
2355         Add WKNavigationDelegatePrivate SPI to inform application of subframe navigations
2356         https://bugs.webkit.org/show_bug.cgi?id=208670
2357
2358         Reviewed by Brady Eidson.
2359
2360         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
2361         (-[FrameNavigationDelegate waitForNavigations:]):
2362         (-[FrameNavigationDelegate requests]):
2363         (-[FrameNavigationDelegate frames]):
2364         (-[FrameNavigationDelegate callbacks]):
2365         (-[FrameNavigationDelegate _webView:didStartProvisionalLoadWithRequest:inFrame:]):
2366         (-[FrameNavigationDelegate _webView:didFailProvisionalLoadWithRequest:inFrame:withError:]):
2367         (-[FrameNavigationDelegate _webView:didCommitLoadWithRequest:inFrame:]):
2368         (-[FrameNavigationDelegate _webView:didFailLoadWithRequest:inFrame:withError:]):
2369         (-[FrameNavigationDelegate _webView:didFinishLoadWithRequest:inFrame:]):
2370         (TEST):
2371
2372 2020-03-05  Alex Christensen  <achristensen@webkit.org>
2373
2374         Add WKFrameInfo._parentFrameHandle SPI
2375         https://bugs.webkit.org/show_bug.cgi?id=208674
2376
2377         Reviewed by Brady Eidson.
2378
2379         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
2380
2381 2020-03-05  Jiewen Tan  <jiewen_tan@apple.com>
2382
2383         [WebAuthn] Implement SPI -[_WKWebAuthenticationPanelDelegate panel:selectAssertionResponse:source:completionHandler:]
2384         https://bugs.webkit.org/show_bug.cgi?id=208626
2385         <rdar://problem/60074148>
2386
2387         Reviewed by Brent Fulgham.
2388
2389         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2390         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
2391         (-[TestWebAuthenticationPanelDelegate panel:selectAssertionResponse:source:completionHandler:]):
2392         (TestWebKitAPI::TEST):
2393         (-[TestWebAuthenticationPanelDelegate panel:selectAssertionResponse:completionHandler:]): Deleted.
2394         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-hid-multiple-accounts.html:
2395         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-la.html: Added.
2396
2397 2020-03-05  Antoine Quint  <graouts@apple.com>
2398
2399         Page-specific UserStyleSheets should wait until the initial empty document has been removed to be injected
2400         https://bugs.webkit.org/show_bug.cgi?id=208644
2401         <rdar://problem/60042429>
2402
2403         Reviewed by Brady Eidson.
2404
2405         Add new tests for -[_WKUserStyleSheet initWithSource:forWKWebView:forMainFrameOnly:userContentWorld:]) that check:
2406         
2407         1. that a _WKUserStyleSheet can be added immediately after a WKWebView's creation and will be injected once the initial
2408            empty document has been removed in favor of the document for the requested URL,
2409         2. that removing a _WKUserStyleSheet immediately after it was added but before the initial empty document was removed
2410            correctly does not injected the style sheet.
2411
2412         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
2413
2414 2020-03-05  Aakash Jain  <aakash_jain@apple.com>
2415
2416         [ews] Add build step to push commit to WebKit repository
2417         https://bugs.webkit.org/show_bug.cgi?id=208589
2418
2419         Reviewed by Jonathan Bedard.
2420
2421         * BuildSlaveSupport/ews-build/steps.py:
2422         (PushCommitToWebKitRepo): Build step to push the local commit to WebKit repository.
2423         (PushCommitToWebKitRepo.start): Initialize log observer.
2424         (PushCommitToWebKitRepo.evaluateCommand): Check command return status and comment on bug accordingly.
2425         (PushCommitToWebKitRepo.comment_text_for_bug): Generate comment text for commenting on bug.
2426         (PushCommitToWebKitRepo.svn_revision_from_commit_text): Extract the svn revision from commit text.
2427         (PushCommitToWebKitRepo.getResultSummary): Set custom failure message.
2428         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
2429         * BuildSlaveSupport/ews-build/factories.py:
2430
2431 2020-03-05  Aakash Jain  <aakash_jain@apple.com>
2432
2433         [ews] Add unit tests for ValidateCommiterAndReviewer build step
2434         https://bugs.webkit.org/show_bug.cgi?id=208262
2435
2436         Reviewed by Jonathan Bedard.
2437
2438         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests for ValidateCommiterAndReviewer.
2439
2440 2020-03-05  Aakash Jain  <aakash_jain@apple.com>
2441
2442         commit-queue should run WK2 tests instead of WK1 tests
2443         https://bugs.webkit.org/show_bug.cgi?id=208544
2444
2445         Reviewed by Jonathan Bedard.
2446
2447         * BuildSlaveSupport/ews-build/factories.py:
2448
2449 2020-03-05  Aakash Jain  <aakash_jain@apple.com>
2450
2451         [ews] ValidateCommiterAndReviewer should validate emails in case insensitive manner
2452         https://bugs.webkit.org/show_bug.cgi?id=208645
2453
2454         Reviewed by Alexey Proskuryakov.
2455
2456         * BuildSlaveSupport/ews-build/steps.py:
2457         (ValidateCommiterAndReviewer.load_contributors):
2458         (ValidateCommiterAndReviewer.start):
2459
2460 2020-03-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2461
2462         style-checker: Add UAF to the list of security words to warn about.
2463         https://bugs.webkit.org/show_bug.cgi?id=208643
2464
2465         Reviewed by Jonathan Bedard.
2466
2467         UAF is a common acronym used for use after free.
2468
2469         * Scripts/webkitpy/style/checkers/changelog.py:
2470         (ChangeLogChecker.check_for_unwanted_security_phrases):
2471
2472 2020-03-04  Basuke Suzuki  <basuke.suzuki@sony.com>
2473
2474         [MSVC] Add .natvis support of WebKit types
2475         https://bugs.webkit.org/show_bug.cgi?id=193119
2476
2477         Reviewed by Don Olmstead.
2478
2479         To help the WebKit developer while debugging, this file defines how
2480         WebKit types are displayed in debugger of Visual Studio.
2481         Very limited set of WebKit types, but it changes the world.
2482
2483         * VisualStudio/WebKit.natvis: Added.
2484
2485 2020-03-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2486
2487         Add system trace points around display list replay
2488         https://bugs.webkit.org/show_bug.cgi?id=208616
2489
2490         Reviewed by Simon Fraser.
2491
2492         Add a new "Display list replay" trace point.
2493
2494         * Tracing/SystemTracePoints.plist:
2495
2496 2020-03-04  Alex Christensen  <achristensen@webkit.org>
2497
2498         Call globalObjectIsAvailableForFrame before evaluating JavaScript in newly created worlds
2499         https://bugs.webkit.org/show_bug.cgi?id=208615
2500         <rdar://problem/59406743>
2501
2502         Reviewed by Alex Christensen.
2503
2504         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2505         * TestWebKitAPI/Tests/WebKitCocoa/ContentWorldPlugIn.mm: Added.
2506         (-[ContentWorldPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2507         (-[ContentWorldPlugIn webProcessPlugInBrowserContextController:globalObjectIsAvailableForFrame:inScriptWorld:]):
2508         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
2509         (TEST):
2510         Also make a test written in bug 206310 actually run code.
2511
2512 2020-03-04  Aakash Jain  <aakash_jain@apple.com>
2513
2514         [build.webkit.org] Remove leaks queue
2515         https://bugs.webkit.org/show_bug.cgi?id=208580
2516
2517         Reviewed by Jonathan Bedard.
2518
2519         * BuildSlaveSupport/build.webkit.org-config/config.json:
2520         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2521         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2522
2523 2020-03-04  Alex Christensen  <achristensen@webkit.org>
2524
2525         Add SPI to evaluate JavaScript in an iframe
2526         https://bugs.webkit.org/show_bug.cgi?id=208605
2527
2528         Reviewed by Brady Eidson.
2529
2530         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
2531
2532 2020-03-03  Jiewen Tan  <jiewen_tan@apple.com>
2533
2534         [WebAuthn] Implement -[_WKWebAuthenticationPanelDelegate panel:decidePolicyForLocalAuthenticatorWithCompletionHandler:] SPI
2535         https://bugs.webkit.org/show_bug.cgi?id=208533
2536         <rdar://problem/60010184>
2537
2538         Reviewed by Alex Christensen.
2539
2540         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2541         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
2542         (-[TestWebAuthenticationPanelDelegate panel:decidePolicyForLocalAuthenticatorWithCompletionHandler:]):
2543         (TestWebKitAPI::TEST):
2544         (-[TestWebAuthenticationPanelDelegate panel:verifyUserWithAccessControl:completionHandler:]): Deleted.
2545         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-la.html: Removed.
2546
2547 2020-03-04  Alex Christensen  <achristensen@webkit.org>
2548
2549         callAsyncJavaScript with an invalid parameter and no completionHandler should not crash
2550         https://bugs.webkit.org/show_bug.cgi?id=208593
2551
2552         Reviewed by Brady Eidson.
2553
2554         * TestWebKitAPI/Tests/WebKitCocoa/AsyncFunction.mm:
2555         (TestWebKitAPI::TEST):
2556
2557 2020-03-04  Alex Christensen  <achristensen@webkit.org>
2558
2559         WKWebView's frames accessor should return a traversable type
2560         https://bugs.webkit.org/show_bug.cgi?id=208591
2561
2562         Reviewed by Brady Eidson.
2563
2564         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
2565
2566 2020-03-04  Antoine Quint  <graouts@apple.com>
2567
2568         Add an SPI to allow UserStyleSheet injection to target a specific WKWebView
2569         https://bugs.webkit.org/show_bug.cgi?id=208575
2570         <rdar://problem/59773690>
2571
2572         Reviewed by Brady Eidson.
2573
2574         Add new tests for the new SPI which check:
2575         
2576         1. that specifying forWKWebView: when initializing a _WKUserStyleSheet will inject the provided CSS source in the
2577            specified WKWebView alone,
2578         2. that the same test works with two WKWebViews with a shared WKWebKitConfiguration,
2579         3. that a WKWebView-specific _WKUserStyleSheet can be removed,
2580         4. that a WKWebView-specific _WKUserStyleSheet can be added twice and removed once and be removed as expected,
2581         5. and that a WKWebView-specific _WKUserStyleSheet is automatically removed when navigating to a new page,
2582         6. and that the same test also works with PSON enabled.
2583
2584         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
2585
2586 2020-03-04  Ryan Haddad  <ryanhaddad@apple.com>
2587
2588         [macOS] test-lldb-webkit failing on debug bots
2589         https://bugs.webkit.org/show_bug.cgi?id=208545
2590
2591         Reviewed by Jonathan Bedard.
2592
2593         The lldb-webkit-test step must pass in the build configuration as an
2594         argument to the test-lldb-webkit script so that it uses the lldbWebKitTester
2595         binary that is downloaded with the rest of the build products. Without this
2596         argument, the bots expect to find the binary in the 'WebKitBuild/Release' directory
2597         regardless of their actual build configuration.
2598
2599         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2600         (RunLLDBWebKitTests): Pass in the build configuration to the test-lldb-webkit script.
2601         * Scripts/test-lldb-webkit:
2602         (LldbTester.parse_args): Capitalize the constants for Debug / Release since that is what webkitpy expects.
2603
2604 2020-03-04  Aakash Jain  <aakash_jain@apple.com>
2605
2606         [ews] Add build step to create local git commit for commit-queue (follow-up fix)
2607         https://bugs.webkit.org/show_bug.cgi?id=208539
2608
2609         Unreviewed follow-up fix.
2610
2611         * BuildSlaveSupport/ews-build/steps.py:
2612
2613 2020-03-04  Daniel Bates  <dabates@apple.com>
2614
2615         Should use -bounds instead of -frame in RequestTextInputContext.mm tests
2616         https://bugs.webkit.org/show_bug.cgi?id=208565
2617
2618         Reviewed by Wenson Hsieh.
2619
2620         Pass the bounds of the web view to -synchronouslyRequestTextInputContextsInRect: instead
2621         of its frame as a means to find all the editable elements in the visible content area
2622         of the web view.
2623
2624         Coincidentally this makes no difference to the test results right now because the web view
2625         happens to be located at the origin (0, 0) in the window. However if in the future the
2626         web view would be located at some other point then the tests may fail because the rectangle
2627         passed to -synchronouslyRequestTextInputContextsInRect: would no longer represent the
2628         rectangle for the visible content area.
2629
2630         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2631         (TEST):
2632
2633 2020-03-04  Daniel Bates  <dabates@apple.com>
2634
2635         Organize tests in RequestTextInputContext.mm tests under test name RequestTextInputContext
2636         https://bugs.webkit.org/show_bug.cgi?id=208564
2637
2638         Reviewed by Alex Christensen.
2639
2640         Group the tests in RequestTextInputContext.mm under the test case name RequestTextInputContext
2641         to make it easy to run just these tests.
2642
2643         Currently, the tests are organized under the test case name WebKit. This means you need to
2644         pass run-api-tests the name of each sub-test as there is no easy way to run them all without
2645         also running all the TestWebKitAPI.WebKit sub-tests. Instead organize them under RequestTextInputContext
2646         so that a person can run just these test using:
2647         
2648                 run-api-tests --debug TestWebKitAPI.RequestTextInputContext
2649
2650         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2651         (TEST):
2652
2653 2020-03-04  Aakash Jain  <aakash_jain@apple.com>
2654
2655         [ews] Add build step to create local git commit for commit-queue
2656         https://bugs.webkit.org/show_bug.cgi?id=208539
2657
2658         Reviewed by Jonathan Bedard.
2659
2660         * BuildSlaveSupport/ews-build/steps.py:
2661         (CreateLocalGITCommit): Build step to create local git commit.
2662         (CreateLocalGITCommit.start):
2663         (CreateLocalGITCommit.getResultSummary): Set custom failure message.
2664         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests and restructured imports.
2665         * BuildSlaveSupport/ews-build/factories.py:
2666
2667 2020-03-04  Simon Fraser  <simon.fraser@apple.com>
2668
2669         (r256513) [ Mac ] fast/scrolling/programmatic-scroll-to-zero-zero.html is a flaky failure
2670         https://bugs.webkit.org/show_bug.cgi?id=207948
2671
2672         Reviewed by Zalan Bujtas.
2673
2674         EventSendingController needs to trigger layout so that the WebHTMLView is not 0x0,
2675         so that it receives the wheel events.
2676
2677         * DumpRenderTree/mac/EventSendingController.mm:
2678         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
2679         * DumpRenderTree/win/EventSender.cpp:
2680         (mouseScrollBy):
2681
2682 2020-03-04  Andres Gonzalez  <andresg_22@apple.com>
2683
2684         REGRESSION (r257739): two fast/events/autoscroll test have started to fail
2685         https://bugs.webkit.org/show_bug.cgi?id=208520
2686         <rdar://problem/60000214>
2687
2688         Reviewed by Chris Fleizach.
2689
2690         Calling InjectedBundle::singleton().page()->page() in the constructor
2691         of the AccessibilityController is having this side effect on iOS.
2692         So #if to MAC where it's actually being used.
2693
2694         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2695         (WTR::AccessibilityController::AccessibilityController):
2696
2697 2020-03-03  Alex Christensen  <achristensen@webkit.org>
2698
2699         Add SPI _WKResourceLoadInfo.loadedFromCache
2700         https://bugs.webkit.org/show_bug.cgi?id=208554
2701
2702         Reviewed by Wenson Hsieh.
2703
2704         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
2705         (TEST):
2706
2707 2020-03-03  Ryosuke Niwa  <rniwa@webkit.org>
2708
2709         Batch observations and completions of text manipulations
2710         https://bugs.webkit.org/show_bug.cgi?id=208406
2711
2712         Reviewed by Wenson Hsieh.
2713
2714         Updated the existing tests to use new APIs, and added new tests for batching finding & replacing
2715         multiple paragraphs at once.
2716
2717         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
2718         (-[TextManipulationDelegate _webView:didFindTextManipulationItems:]):
2719         (-[TextManipulationDelegate items]):
2720         (-[LegacyTextManipulationDelegate init]):
2721         (-[LegacyTextManipulationDelegate _webView:didFindTextManipulationItem:]):
2722         (TextManipulation.StartTextManipulationSupportsLegacyDelegateCallback): Added.
2723         (TextManipulation.LegacyCompleteTextManipulationReplaceSimpleSingleParagraph): Added.
2724         (TextManipulation.CompleteTextManipulationReplaceMultipleSimpleParagraphsAtOnce): Added.
2725         (TextManipulation.CompleteTextManipulationShouldBatchItemCallback): Added.
2726         (TextManipulation.CompleteTextManipulationFailWhenItemIdentifierIsDuplicated): Added.
2727         (TextManipulation.CompleteTextManipulationCanHandleSubsetOfItemsToFail): Added.
2728
2729 2020-03-03  Per Arne Vollan  <pvollan@apple.com>
2730
2731         [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
2732         https://bugs.webkit.org/show_bug.cgi?id=208415
2733
2734         Reviewed by Brent Fulgham.
2735
2736         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2737         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
2738         (TEST):
2739
2740 2020-03-03  Alex Christensen  <achristensen@webkit.org>
2741
2742         Add response to _WKResourceLoadDelegate didCompleteWithError callback
2743         https://bugs.webkit.org/show_bug.cgi?id=208553
2744
2745         Reviewed by Simon Fraser.
2746
2747         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
2748         (-[TestResourceLoadDelegate webView:resourceLoad:didCompleteWithError:response:]):
2749         (TEST):
2750         (-[TestResourceLoadDelegate webView:resourceLoad:didCompleteWithError:]): Deleted.
2751
2752 2020-03-03  Brady Eidson  <beidson@apple.com>
2753
2754         API Test [Mojave+ WK2 Debug ] TestWebKitAPI.WKAttachmentTestsMac.InsertDroppedFilePromisesAsAttachments is a flaky crash.
2755         https://bugs.webkit.org/show_bug.cgi?id=198795
2756
2757         Reviewed by Chris Dumez.
2758
2759         This test appears to no longer be flaky.
2760         
2761         Let's re-enable it.
2762         
2763         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2764         (TestWebKitAPI::TEST):
2765
2766 2020-03-03  Alex Christensen  <achristensen@webkit.org>
2767
2768         Requests sent to _WKResourceLoadDelegate should include HTTPBody
2769         https://bugs.webkit.org/show_bug.cgi?id=208550
2770
2771         Reviewed by Tim Hatcher.
2772
2773         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
2774         (TEST):
2775         * TestWebKitAPI/cocoa/HTTPServer.mm:
2776         (TestWebKitAPI::HTTPServer::respondToRequests):
2777         HTTPServer now looks for Content-Length in its request.
2778         If it finds this header, that means that the HTTP body is going to be received in another read, then the response should be sent after receiving that.
2779
2780 2020-03-03  Alex Christensen  <achristensen@webkit.org>
2781
2782         Expose originalURL and originalHTTPMethod on _WKResourceLoadInfo
2783         https://bugs.webkit.org/show_bug.cgi?id=208522
2784
2785         Reviewed by Brian Weinstein.
2786
2787         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
2788         (TEST):
2789
2790 2020-03-03  Aakash Jain  <aakash_jain@apple.com>
2791
2792         commit-queue should update working directory and reapply patch just before commiting
2793         https://bugs.webkit.org/show_bug.cgi?id=208521
2794
2795         Reviewed by Jonathan Bedard.
2796
2797         * BuildSlaveSupport/ews-build/factories.py:
2798
2799 2020-03-03  Matt Lewis  <jlewis3@apple.com>
2800
2801         Add Unittest to commits_for_upload() and fix multiple unittests for several test suites.
2802         https://bugs.webkit.org/show_bug.cgi?id=208485
2803
2804         Reviewed by Jonathan Bedard.
2805
2806         * Scripts/webkitpy/common/checkout/scm/stub_repository.py:
2807         (StubRepository.__init__): Fixing the constructor to call upon the parent class as we were not doing this before. It also means
2808         that we don't have to recreate the variables that are already created.
2809         * Scripts/webkitpy/common/checkout/scm/stub_repository_unittest.py: High level changed the imports to better reflect what we are using
2810         from each module, rather than making extra imports that we don't need.
2811         (StubRepositoryTest.mock_host_for_stub_repository): Since we are calling both an executive and a filesystem mock for most of the
2812         tests. it makes more sense to create a mock host with the files needed, than it does to instantiate each of these as separate objects
2813         and not part of the host.
2814         (StubRepositoryTest.test_in_working_directory): Changed the filesystem call to the host call.
2815         (StubRepositoryTest.test_native_revision): Changed the filesystem call to the host call.
2816         (StubRepositoryTest.test_native_branch): Changed the filesystem call to the host call.
2817         (StubRepositoryTest.test_svn_revision): Changed the filesystem call to the host call.
2818         (StubRepositoryTest.test_find_checkout_root): Changed the filesystem call to the host call.
2819         (StubRepositoryTest.test_find_checkout_root_failure): Changed the filesystem call to the host call.
2820         (StubRepositoryTest.test_find_parent_path_matching_callback_condition_with_file_system): Changed the filesystem call to the host call.
2821         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py: 
2822         (SummarizedResultsTest.test_svn_revision_exists): Changed the name to original test to better reflect that it was just looking to see
2823         if we were geting any value at all
2824         (SummarizedResultsTest.test_svn_revision): Added a test to make sure that the revision we are getting is what we expect to get and make
2825         sure we aren't gabking the wrong key:value pair
2826         * Scripts/webkitpy/port/base_unittest.py: Changed from MockSystemHost to MockHost as we want the extras that
2827         come with the MockHosts and MockHost inherits from MockSystemHost.
2828         (PortTest.make_port): Changed the port to call MockHost that will creat the required stub_repository files.
2829         (test_commits_for_upload): Added amissing test for commits_for_upload as this has been an issue when trying to make changes
2830         to the various upload steps.
2831
2832 2020-03-03  Aakash Jain  <aakash_jain@apple.com>
2833
2834         [ews] Add build step to find list of modified changelogs
2835         https://bugs.webkit.org/show_bug.cgi?id=208514
2836
2837         Reviewed by Jonathan Bedard.
2838
2839         * BuildSlaveSupport/ews-build/factories.py:
2840         * BuildSlaveSupport/ews-build/steps.py:
2841         (FindModifiedChangeLogs): Build step to find modified ChangeLogs.
2842         (FindModifiedChangeLogs.start): Initialize log observer.
2843         (FindModifiedChangeLogs.getResultSummary): Set custom failure message.
2844         (FindModifiedChangeLogs.evaluateCommand):
2845         (FindModifiedChangeLogs.is_path_to_changelog): Check if the file is a ChangeLog.
2846         (FindModifiedChangeLogs._status_regexp): Regex to match files from git output.
2847         (FindModifiedChangeLogs.extract_changelogs): Method to get list of ChangeLogs from git output.
2848         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
2849
2850 2020-03-03  Ryan Haddad  <ryanhaddad@apple.com>
2851
2852         [iOS EWS] TestWebKitAPI.WKWebsiteDataStore.RemoveAndFetchData is failing
2853         https://bugs.webkit.org/show_bug.cgi?id=208451
2854
2855         Unreviewed test gardening.
2856
2857         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm: Disable the test for iOS since it is slowing down EWS.
2858
2859 2020-03-03  Jiten Mehta  <jmehta@apple.com>
2860
2861         Adopt HTTP Alternative Services Storage
2862         https://bugs.webkit.org/show_bug.cgi?id=208387
2863
2864         Reviewed by Alex Christensen.
2865
2866         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2867         (checkUntilEntryFound):
2868         (TEST):
2869
2870 2020-03-03  Kate Cheney  <katherine_cheney@apple.com>
2871
2872         Check for navigation to app-bound domain during script evaluation
2873         https://bugs.webkit.org/show_bug.cgi?id=208319
2874         <rdar://problem/57569321>
2875
2876         Reviewed by Brent Fulgham.
2877
2878         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2879         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm: Added.
2880         (-[TestInAppBrowserScriptMessageHandler userContentController:didReceiveScriptMessage:]):
2881         (TEST):
2882         * TestWebKitAPI/Tests/WebKitCocoa/in-app-browser-privacy-test-user-agent-script.html: Added.
2883         * TestWebKitAPI/Tests/WebKitCocoa/in-app-browser-privacy-test-user-script.html: Added.
2884
2885 2020-03-03  Commit Queue  <commit-queue@webkit.org>
2886
2887         Unreviewed, rolling out r257754.
2888         https://bugs.webkit.org/show_bug.cgi?id=208513
2889
2890         Introduced API test failure (Requested by perarne on #webkit).
2891
2892         Reverted changeset:
2893
2894         "[Cocoa] Mapping from MIME type to UTI type should be done in
2895         the UI process"
2896         https://bugs.webkit.org/show_bug.cgi?id=208415
2897         https://trac.webkit.org/changeset/257754
2898
2899 2020-03-03  Diego Pino Garcia  <dpino@igalia.com>
2900
2901         REGRESSION(r257726): [GTK] LayoutTests crashing after r257726
2902         https://bugs.webkit.org/show_bug.cgi?id=208506
2903
2904         Reviewed by Carlos Garcia Campos.
2905
2906         * WebKitTestRunner/TestController.cpp:
2907         (WTR::TestController::platformAdjustContext): Remove unnecessary code.
2908
2909 2020-03-02  Ben Nham  <nham@apple.com>
2910
2911         Add performance probes for HTML parsing
2912         https://bugs.webkit.org/show_bug.cgi?id=208271
2913
2914         Reviewed by Daniel Bates.
2915
2916         This adds probes that show which lines of HTML are have been parsed.
2917
2918         * Tracing/SystemTracePoints.plist:
2919
2920 2020-03-02  Per Arne Vollan  <pvollan@apple.com>
2921
2922         [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
2923         https://bugs.webkit.org/show_bug.cgi?id=208415
2924
2925         Reviewed by Brent Fulgham.
2926
2927         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2928         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
2929         (TEST):
2930
2931 2020-03-02  Jacob Uphoff  <jacob_uphoff@apple.com>
2932
2933         Unreviewed, rolling out r257725.
2934
2935         This commit caused 10 API tests to fail
2936
2937         Reverted changeset:
2938
2939         "[Cocoa] Mapping from MIME type to UTI type should be done in
2940         the UI process"
2941         https://bugs.webkit.org/show_bug.cgi?id=208415
2942         https://trac.webkit.org/changeset/257725
2943
2944 2020-03-02  Saam Barati  <sbarati@apple.com>
2945
2946         Don't skip tests unnecessarily on arm64
2947         https://bugs.webkit.org/show_bug.cgi?id=208470
2948         <rdar://problem/59968869>
2949
2950         Reviewed by Tadeu Zagallo.
2951
2952         * Scripts/run-jsc-stress-tests:
2953
2954 2020-03-02  Andres Gonzalez  <andresg_22@apple.com>
2955
2956         Fix for LayoutTests/accessibility/mac/search-text/search-text.html in IsolatedTree mode.
2957         https://bugs.webkit.org/show_bug.cgi?id=208434
2958
2959         Reviewed by Chris Fleizach.
2960
2961         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2962         (WTR::AccessibilityController::AccessibilityController): Initializes m_useAXThread.
2963         (WTR::AccessibilityController::rootElement): No need to set m_useAXThread here since it is initialize in the constructor.
2964         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
2965         (WTR::AccessibilityController::accessibleElementById): Same as above.
2966
2967 2020-03-02  John Wilander  <wilander@apple.com>
2968
2969         ResourceLoadStatistics: Enable cookie blocking and the Storage Access API in ephemeral sessions
2970         https://bugs.webkit.org/show_bug.cgi?id=208399
2971         <rdar://problem/24731650>
2972
2973         Reviewed by Brent Fulgham.
2974
2975         The majority of the changes in WTR::TestController is (partially) fixing a bug
2976         where the TestRunner would statically use the default website datastore instead
2977         of the website data store configure for the page. This worked for persistent
2978         storage testing but not for ephemeral sessions which is what this patch is all
2979         about. The previous TestController::websiteDataStore() is now called
2980         TestController::defaultWebsiteDataStore() and the new
2981         TestController::websiteDataStore() returns the configured website data store.
2982         Most of the use of the default website data store should probably change but
2983         that's not really for this patch to deal with. I did however move all of
2984         resource load statistics' use to the new TestController::websiteDataStore().
2985
2986         A new TestRunner function was added: isStatisticsEphemeral()
2987         It allows test cases to query the ephemeral status of resource load statistics.
2988
2989         One problem that is mitigated in this patch but not fully fixed is that for
2990         Cocoa platforms, the TestRunner sets up two ephemeral sessions, once in
2991         TestController::generatePageConfiguration() via C API 
2992         WKPageConfigurationSetWebsiteDataStore(), and then again in 
2993         TestControllerCocoa's initializeWebViewConfiguration() via Cocoa API
2994         [copiedConfiguration setWebsiteDataStore:ephemeralWebsiteDataStore].
2995         I tried removing the latter since one session for all platforms should be
2996         Enough but got broken behavior as a result. So now both are still there
2997         and both enable resource load statistics.
2998
2999         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3000         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3001         (WTR::TestRunner::isStatisticsEphemeral):
3002         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3003         * WebKitTestRunner/TestController.cpp:
3004         (WTR::TestController::defaultWebsiteDataStore):
3005         (WTR::TestController::websiteDataStore):
3006         (WTR::TestController::generatePageConfiguration):
3007         (WTR::TestController::resetPreferencesToConsistentValues):
3008         (WTR::TestController::resetStateToConsistentValues):
3009         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
3010         (WTR::TestController::decidePolicyForNavigationAction):
3011         (WTR::TestController::platformAdjustContext):
3012         (WTR::TestController::clearServiceWorkerRegistrations):
3013         (WTR::TestController::clearDOMCache):
3014         (WTR::TestController::clearDOMCaches):
3015         (WTR::TestController::clearIndexedDatabases):
3016         (WTR::TestController::clearLocalStorage):
3017         (WTR::TestController::hasDOMCache):
3018         (WTR::TestController::domCacheSize):
3019         (WTR::TestController::setStatisticsEnabled):
3020         (WTR::TestController::isStatisticsEphemeral):
3021         (WTR::TestController::setStatisticsDebugMode):
3022         (WTR::TestController::setStatisticsPrevalentResourceForDebugMode):
3023         (WTR::TestController::setStatisticsLastSeen):
3024         (WTR::TestController::setStatisticsMergeStatistic):
3025         (WTR::TestController::setStatisticsPrevalentResource):
3026         (WTR::TestController::setStatisticsVeryPrevalentResource):
3027         (WTR::TestController::dumpResourceLoadStatistics):
3028         (WTR::TestController::isStatisticsPrevalentResource):
3029         (WTR::TestController::isStatisticsVeryPrevalentResource):
3030         (WTR::TestController::isStatisticsRegisteredAsSubresourceUnder):
3031         (WTR::TestController::isStatisticsRegisteredAsSubFrameUnder):
3032         (WTR::TestController::isStatisticsRegisteredAsRedirectingTo):
3033         (WTR::TestController::setStatisticsHasHadUserInteraction):
3034         (WTR::TestController::isStatisticsHasHadUserInteraction):
3035         (WTR::TestController::isStatisticsOnlyInDatabaseOnce):
3036         (WTR::TestController::setStatisticsGrandfathered):
3037         (WTR::TestController::isStatisticsGrandfathered):
3038         (WTR::TestController::setUseITPDatabase):
3039         (WTR::TestController::setStatisticsSubframeUnderTopFrameOrigin):
3040         (WTR::TestController::setStatisticsSubresourceUnderTopFrameOrigin):
3041         (WTR::TestController::setStatisticsSubresourceUniqueRedirectTo):
3042         (WTR::TestController::setStatisticsSubresourceUniqueRedirectFrom):
3043         (WTR::TestController::setStatisticsTopFrameUniqueRedirectTo):
3044         (WTR::TestController::setStatisticsTopFrameUniqueRedirectFrom):
3045         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
3046         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
3047         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
3048         (WTR::TestController::statisticsUpdateCookieBlocking):
3049         (WTR::TestController::statisticsSubmitTelemetry):
3050         (WTR::TestController::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
3051         (WTR::TestController::setStatisticsIsRunningTest):
3052         (WTR::TestController::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
3053         (WTR::TestController::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
3054         (WTR::TestController::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
3055         (WTR::TestController::setStatisticsGrandfatheringTime):
3056         (WTR::TestController::setStatisticsMaxStatisticsEntries):
3057         (WTR::TestController::setStatisticsPruneEntriesDownTo):
3058         (WTR::TestController::statisticsClearInMemoryAndPersistentStore):
3059         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
3060         (WTR::TestController::statisticsClearThroughWebsiteDataRemoval):
3061         (WTR::TestController::statisticsDeleteCookiesForHost):
3062         (WTR::TestController::isStatisticsHasLocalStorage):
3063         (WTR::TestController::setStatisticsCacheMaxAgeCap):
3064         (WTR::TestController::hasStatisticsIsolatedSession):
3065         (WTR::TestController::setStatisticsShouldDowngradeReferrer):
3066         (WTR::TestController::setStatisticsShouldBlockThirdPartyCookies):
3067         (WTR::TestController::setStatisticsFirstPartyWebsiteDataRemovalMode):
3068         (WTR::TestController::statisticsResetToConsistentState):
3069         (WTR::TestController::clearAdClickAttributionsThroughWebsiteDataRemoval):
3070         * WebKitTestRunner/TestController.h:
3071         * WebKitTestRunner/TestInvocation.cpp:
3072         (WTR::TestInvocation::invoke):
3073         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3074         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3075         (WTR::initializeWebViewConfiguration):
3076         (WTR::TestController::platformCreateWebView):
3077
3078 2020-03-02  Per Arne Vollan  <pvollan@apple.com>
3079
3080         [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
3081         https://bugs.webkit.org/show_bug.cgi?id=208415
3082
3083         Reviewed by Brent Fulgham.
3084
3085         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3086         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
3087         (TEST):
3088
3089 2020-03-02  Daniel Bates  <dabates@apple.com>
3090
3091         Page::editableElementsInRect() should find nested editable elements and return found elements in paint order
3092         https://bugs.webkit.org/show_bug.cgi?id=208352
3093         <rdar://problem/59867815>
3094
3095         Reviewed by Wenson Hsieh.
3096
3097         Update test results to reflect the new behavior. To do this I also need to fix up the test code
3098         to actually scroll the web content. This also means we now execute the same code on both Mac and
3099         iOS to do the scrolling: window.scrollTo(0, 5000). Also fixed up sub-test "Inputs scrolled outside
3100         the requested rect; should not be included." to use a 10000px height <div> so that you can scroll
3101         to a y position of 5000. Otherwise, it's impossible to do because the page height is < 5000px.
3102
3103         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
3104         (TEST):
3105
3106 2020-03-02  Jacob Uphoff  <jacob_uphoff@apple.com>
3107
3108         Unreviewed, rolling out r257687.
3109
3110         This commit caused debug tests to crash for macOS & iOS
3111
3112         Reverted changeset:
3113
3114         "[Cocoa] Mapping from MIME type to UTI type should be done in
3115         the UI process"
3116         https://bugs.webkit.org/show_bug.cgi?id=208415
3117         https://trac.webkit.org/changeset/257687
3118
3119 2020-03-01  Wenson Hsieh  <wenson_hsieh@apple.com>
3120
3121         Unreviewed, rolling out r257618.
3122
3123         This allegedly causes Safari to crash when closing a window
3124         (see rdar://problem/59922725).
3125
3126         Reverted changeset:
3127
3128         "UIProcess crash after using _prepareForMoveToWindow, then
3129         deallocating the WKWebView before moving to the window"
3130         https://bugs.webkit.org/show_bug.cgi?id=208365
3131         https://trac.webkit.org/changeset/257618
3132
3133 2020-02-29  Yusuke Suzuki  <ysuzuki@apple.com>
3134
3135         Remove std::lock_guard
3136         https://bugs.webkit.org/show_bug.cgi?id=206451
3137
3138         Reviewed by Anders Carlsson.
3139
3140         Add std::lock_guard lint rule to prevent from using it.
3141
3142         * Scripts/webkitpy/style/checkers/cpp.py:
3143         (check_lock_guard):
3144         (check_style):
3145         (CppChecker):
3146         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3147         (WebKitStyleTest.test_lock_guard):
3148         * TestWebKitAPI/Tests/WTF/Condition.cpp:
3149         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
3150         * TestWebKitAPI/Tests/WTF/bmalloc/IsoHeap.cpp:
3151         (assertHasObjects):
3152         (assertHasOnlyObjects):
3153         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
3154         (WTR::AXThread::dispatch):
3155         (WTR::AXThread::dispatchFunctionsFromAXThread):
3156         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
3157         (WTR::AXThread::initializeRunLoop):
3158
3159 2020-02-29  Per Arne Vollan  <pvollan@apple.com>
3160
3161         [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
3162         https://bugs.webkit.org/show_bug.cgi?id=208415
3163
3164         Reviewed by Brent Fulgham.
3165
3166         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3167         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
3168         (TEST):
3169
3170 2020-02-28  Fujii Hironori  <Hironori.Fujii@sony.com>
3171
3172         Unreviewed, rolling out r257565.
3173
3174         It broke WinCairo MiniBrowser
3175
3176         Reverted changeset:
3177
3178         "[CMake] Use WEBKIT_EXECUTABLE in MiniBrowser"
3179         https://bugs.webkit.org/show_bug.cgi?id=206894
3180         https://trac.webkit.org/changeset/257565
3181
3182 2020-02-28  Aakash Jain  <aakash_jain@apple.com>
3183
3184         EWS fails to retry build in case of kill-old-processes exception
3185         https://bugs.webkit.org/show_bug.cgi?id=208003
3186
3187         Reviewed by Jonathan Bedard.
3188
3189         * BuildSlaveSupport/ews-build/steps.py:
3190         (KillOldProcesses.evaluateCommand):
3191         (KillOldProcesses.getResultSummary):
3192
3193 2020-02-28  Aakash Jain  <aakash_jain@apple.com>
3194
3195         [ews] commit-queue should update the ChangeLog with Reviewer name
3196         https://bugs.webkit.org/show_bug.cgi?id=206535
3197
3198         Reviewed by Jonathan Bedard.
3199
3200         * BuildSlaveSupport/ews-build/steps.py:
3201         (ApplyPatch.start): Update the patch with the patch reviewer name if available.
3202
3203 2020-02-28  Jonathan Bedard  <jbedard@apple.com>
3204
3205         run-javascriptcore-tests: Make upload format valid
3206         https://bugs.webkit.org/show_bug.cgi?id=208341
3207
3208         Rubber-stamped by Aakash Jain.
3209
3210         * Scripts/run-javascriptcore-tests:
3211         (uploadResults): Remove. FIXME.
3212         * Scripts/webkitdirs.pm:
3213         (splitVersionString): Handle case where the subminor version number has a - in it.
3214         * Scripts/webkitperl/webkitdirs_unittest/splitVersion.pl: Add unit tests.
3215
3216 2020-02-28  youenn fablet  <youenn@apple.com>
3217
3218         [MacOS/iOS] Enable audio/video capture in GPUProcess by default
3219         https://bugs.webkit.org/show_bug.cgi?id=208130
3220
3221         Reviewed by Eric Carlson.
3222
3223         * WebKitTestRunner/TestOptions.h:
3224         Use GPU process to capture by default.
3225         We will remove this option once done verifying that every test works smoothly.
3226
3227 2020-02-28  Aakash Jain  <aakash_jain@apple.com>
3228
3229         [ews] commit queue should skip building and testing for rollout patches
3230         https://bugs.webkit.org/show_bug.cgi?id=208329
3231
3232         Reviewed by Jonathan Bedard.
3233
3234         * BuildSlaveSupport/ews-build/steps.py:
3235         (BugzillaMixin._is_patch_obsolete): Set rollout property appropriately.
3236         (CompileWebKit.doStepIf): Skip tests for rollout patches on commit-queue.
3237         (RunWebKit1Tests.doStepIf): Ditto.
3238         * BuildSlaveSupport/ews-build/steps_unittest.py:
3239         (TestCompileWebKit.test_skip_for_rollout_patches_on_commit_queue): Added unit-test.
3240         (TestRunWebKit1Tests.test_skip_for_rollout_patches_on_commit_queue): Ditto.
3241
3242 2020-02-28  Daniel Bates  <dabates@apple.com>
3243
3244         Update my watch list preferences and contributor's entry.
3245
3246         * Scripts/webkitpy/common/config/contributors.json:
3247         * Scripts/webkitpy/common/config/watchlist:
3248
3249 2020-02-27  Don Olmstead  <don.olmstead@sony.com>
3250
3251         Fix WebCore export macros for declspec
3252         https://bugs.webkit.org/show_bug.cgi?id=208363
3253
3254         Reviewed by Konstantin Tokarev.
3255
3256         Remove setting of WEBCORE_EXPORT and WEBCORE_TESTSUPPORT_EXPORT from the header
3257         files. Removed precompiled headers that were empty.
3258
3259         * DumpRenderTree/DumpRenderTreePrefix.h:
3260         * DumpRenderTree/win/DefaultPolicyDelegate.cpp: Added a missing config.h.
3261         * MiniBrowser/win/stdafx.h:
3262         * TestWebKitAPI/win/TestWebKitAPIPrefix.cpp: Removed.
3263         * TestWebKitAPI/win/TestWebKitAPIPrefix.h: Removed.
3264         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.cpp: Removed.
3265         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h: Removed.
3266         * WebKitTestRunner/PlatformFTW.cmake:
3267         * WebKitTestRunner/PlatformWin.cmake:
3268         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
3269
3270 2020-02-27  Tim Horton  <timothy_horton@apple.com>
3271
3272         UIProcess crash after using _prepareForMoveToWindow, then deallocating the WKWebView before moving to the window
3273         https://bugs.webkit.org/show_bug.cgi?id=208365
3274
3275         Reviewed by Alex Christensen.
3276
3277         * TestWebKitAPI/Tests/WebKitCocoa/PrepareForMoveToWindow.mm:
3278         (TEST):
3279         Add a test! It was a 100% repro crash before this change.
3280
3281 2020-02-27  Kate Cheney  <katherine_cheney@apple.com>
3282
3283         TestWebKitAPI and WebKitTestRunner should have bundle identifiers
3284         https://bugs.webkit.org/show_bug.cgi?id=208260
3285         <rdar://problem/59820107>
3286
3287         Reviewed by Tim Horton.
3288
3289         Followed instructions for adding an Info.plist for Single-File Tools
3290         found on https://developer.apple.com/library/archive/documentation/Security/Conceptual/CodeSigningGuide/Procedures/Procedures.html
3291
3292         The default WebsiteDataStore file path will change with this test to
3293         reflect the new bundleID so we must change expectations for any api
3294         tests which rely on knowing the path.
3295
3296         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
3297         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3298         * TestWebKitAPI/Tests/WebKitCocoa/IDBDeleteRecovery.mm:
3299         (TEST):
3300         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
3301         (TEST):
3302         * TestWebKitAPI/Tests/WebKitCocoa/IDBObjectStoreInfoUpgradeToV2.mm:
3303         (TEST):
3304         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBStructuredCloneBackwardCompatibility.mm:
3305         (TEST):
3306         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
3307         (TEST):
3308         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm:
3309         (TEST):
3310         * TestWebKitAPI/Tests/WebKitCocoa/LocalStorageClear.mm:
3311         (TEST):
3312         (defaultWebsiteCacheDirectory):
3313         * TestWebKitAPI/Tests/WebKitCocoa/LocalStorageNullEntries.mm:
3314         (TEST):
3315         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
3316         (TEST):
3317         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3318         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
3319         (TEST):
3320         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
3321         (TEST):
3322         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3323         (runWebsiteDataStoreCustomPaths):
3324         (TEST):
3325         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
3326         (TestWebKitAPI::resetTestState):
3327         Now that we set a bundleID, we have to reset the cache model between
3328         tests, otherwise it gets stored between tests.
3329
3330         (TestWebKitAPI::TEST):
3331         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
3332         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3333
3334 2020-02-27  Ryosuke Niwa  <rniwa@webkit.org>
3335
3336         TextManipulationController should not generate a new item for content in manipulated paragraphs
3337         https://bugs.webkit.org/show_bug.cgi?id=208286
3338
3339         Reviewed by Wenson Hsieh.
3340
3341         Added a regression test.
3342
3343         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
3344         (TextManipulation.InsertingContentIntoAlreadyManipulatedContentDoesNotCreateTextManipulationItem):
3345
3346 2020-02-27  Jonathan Bedard  <jbedard@apple.com>
3347
3348         run-javascriptcore-tests: Make upload format valid
3349         https://bugs.webkit.org/show_bug.cgi?id=208341
3350
3351         Reviewed by Aakash Jain.
3352
3353         * Scripts/run-javascriptcore-tests:
3354         (uploadResults): Print json blob for upload after failure for debugging.
3355
3356 2020-02-27  Don Olmstead  <don.olmstead@sony.com>
3357
3358         [CMake] Add WebKit::PAL target
3359         https://bugs.webkit.org/show_bug.cgi?id=198493
3360
3361         Reviewed by Michael Catanzaro.
3362
3363         Add workaround for Windows where PAL_FRAMEWORK_HEADERS_DIR is not propagating.
3364
3365         * DumpRenderTree/PlatformWin.cmake:
3366
3367 2020-02-27  Alex Christensen  <achristensen@webkit.org>
3368
3369         Add SPI to query WKFrameInfos in a WKWebView
3370         https://bugs.webkit.org/show_bug.cgi?id=208212
3371
3372         Reviewed by Brady Eidson.
3373
3374         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3375         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp: Removed.
3376         * WebKitTestRunner/TestController.cpp:
3377         (WTR::TestController::saltForOrigin):
3378
3379 2020-02-27  Jacob Uphoff  <jacob_uphoff@apple.com>
3380
3381         Unreviewed, rolling out r257530.
3382
3383         This commit seems to have broke the build internally for
3384         watchOS
3385
3386         Reverted changeset:
3387
3388         "Add SPI to query WKFrameInfos in a WKWebView"
3389         https://bugs.webkit.org/show_bug.cgi?id=208212
3390         https://trac.webkit.org/changeset/257530
3391
3392 2020-02-27  Don Olmstead  <don.olmstead@sony.com>
3393
3394         [CMake] Use WEBKIT_EXECUTABLE in MiniBrowser
3395         https://bugs.webkit.org/show_bug.cgi?id=206894
3396
3397         Reviewed by Adrian Perez de Castro.
3398
3399         Modify CMake ports to use WEBKIT_EXECUTABLE when creating their respective
3400         MiniBrowsers.
3401
3402         * MiniBrowser/gtk/CMakeLists.txt:
3403         * MiniBrowser/win/CMakeLists.txt:
3404         * MiniBrowser/wpe/CMakeLists.txt:
3405
3406 2020-02-26  Alex Christensen  <achristensen@webkit.org>
3407
3408         Remove unused WebsiteDataStore::setSourceApplicationBundleIdentifier
3409         https://bugs.webkit.org/show_bug.cgi?id=206456
3410
3411         Reviewed by Brady Eidson.
3412
3413         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3414         (TEST):
3415
3416 2020-02-26  Alex Christensen  <achristensen@webkit.org>
3417
3418         _WKUserContentWorld should be a wrapper around WKContentWorld
3419         https://bugs.webkit.org/show_bug.cgi?id=208274
3420
3421         Reviewed by Brady Eidson.
3422
3423         * TestWebKitAPI/Tests/WebKitCocoa/UserContentWorld.mm:
3424         (TEST):
3425         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
3426         (TEST):
3427
3428 2020-02-26  Ryan Haddad  <ryanhaddad@apple.com>
3429
3430         Unreviewed, rolling out r257522.
3431
3432         Caused 16 API test failures on the bots
3433
3434         Reverted changeset:
3435
3436         "TestWebKitAPI and WebKitTestRunner should have bundle
3437         identifiers"
3438         https://bugs.webkit.org/show_bug.cgi?id=208260
3439         https://trac.webkit.org/changeset/257522
3440
3441 2020-02-26  Alex Christensen  <achristensen@webkit.org>
3442
3443         Add SPI to query WKFrameInfos in a WKWebView
3444         https://bugs.webkit.org/show_bug.cgi?id=208212
3445
3446         Reviewed by Brady Eidson.
3447
3448         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3449         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp: Removed.
3450         * WebKitTestRunner/TestController.cpp:
3451         (WTR::TestController::saltForOrigin):
3452
3453 2020-02-26  Kate Cheney  <katherine_cheney@apple.com>
3454
3455         TestWebKitAPI and WebKitTestRunner should have bundle identifiers
3456         https://bugs.webkit.org/show_bug.cgi?id=208260
3457         <rdar://problem/59820107>
3458
3459         Reviewed by Tim Horton.
3460
3461         Followed instructions for adding an Info.plist for Single-File Tools
3462         found on https://developer.apple.com/library/archive/documentation/Security/Conceptual/CodeSigningGuide/Procedures/Procedures.html
3463
3464         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
3465         * TestWebKitAPI/Info.plist: Added.
3466         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3467         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
3468         * WebKitTestRunner/Info.plist: Added.
3469         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3470
3471 2020-02-26  Kate Cheney  <katherine_cheney@apple.com>
3472
3473         Tests should each use a unique ResourceLoadStatistics file path for its database store
3474         https://bugs.webkit.org/show_bug.cgi?id=208206
3475         <rdar://problem/59690272>
3476
3477         Reviewed by Brady Eidson.
3478
3479         Initialize a default website data store before checking for the ITP
3480         store to ensure the directory exists after the file has been deleted.
3481
3482         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3483         (TEST):
3484
3485 2020-02-26  Christopher Reid  <chris.reid@sony.com>
3486
3487         [Win] Implement NetworkCache::Data by using FileSystem::MappedFileData
3488         https://bugs.webkit.org/show_bug.cgi?id=197684
3489         <rdar://problem/59467397>
3490
3491         Reviewed by Yusuke Suzuki.
3492
3493         Add test for FileSystem::createFile
3494
3495         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
3496
3497 2020-02-26  Aakash Jain  <aakash_jain@apple.com>
3498
3499         [ews] commit-queue should verify patch committer and reviewer
3500         https://bugs.webkit.org/show_bug.cgi?id=206532
3501
3502         Reviewed by Jonathan Bedard.
3503
3504         * BuildSlaveSupport/ews-build/steps.py:
3505         (ValidateCommiterAndReviewer): Build step to validate patch commiter and reviewer.
3506         (ValidateCommiterAndReviewer._addToLog):
3507         (ValidateCommiterAndReviewer.getResultSummary):
3508         (ValidateCommiterAndReviewer.fail_build):
3509         (ValidateCommiterAndReviewer.load_contributors): Load contributors information.
3510         (ValidateCommiterAndReviewer.is_reviewer):
3511         (ValidateCommiterAndReviewer.is_committer):
3512         (ValidateCommiterAndReviewer.full_name_from_email):
3513         (ValidateCommiterAndReviewer.start):
3514
3515 2020-02-26  Daniel Bates  <dabates@apple.com>
3516
3517         [iOS] Send focus update immediately on becoming or resigning first responder
3518         https://bugs.webkit.org/show_bug.cgi?id=208082
3519         <rdar://problem/59688413>
3520
3521         Rubber-stamped by Jer Noble.
3522
3523         Add a test to ensure that selecting a position at a point after the web view
3524         becomes first responder is allowed. Such an operation is only allowed if the
3525         web view is focused.
3526
3527         * TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm:
3528         (-[TestWKWebView selectPositionAtPoint:]):
3529         (TEST):
3530         * TestWebKitAPI/ios/UIKitSPI.h: Forward declare SPI.
3531
3532 2020-02-26  Chris Dumez  <cdumez@apple.com>
3533
3534         Unreviewed, disable new DragAndDropTests.DragAndDropOnEmptyView API test on iOS.
3535
3536         The test was added for macOS and times out on iOS.
3537
3538         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
3539         (TEST):
3540
3541 2020-02-26  Youenn Fablet  <youenn@apple.com>
3542
3543         Use WebPageProxy preferences for capture instead of WebProcessPool configuration parameters
3544         https://bugs.webkit.org/show_bug.cgi?id=208238
3545
3546         Reviewed by Eric Carlson.
3547
3548         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
3549         (TEST):
3550         Remove use of deleted parameter.
3551
3552 2020-02-25  Devin Rousso  <drousso@apple.com>
3553
3554         Web Inspector: safari app extension isolated worlds and injected files use the extension's identifier instead of its name
3555         https://bugs.webkit.org/show_bug.cgi?id=206911
3556         <rdar://problem/58026635>
3557
3558         Reviewed by Brian Burg.
3559
3560         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
3561         (TestWebKitAPI::TEST):
3562         Add test for `WTF::HashSet::reserveInitialCapacity`.
3563
3564         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3565         (TestWebKitAPI::TEST):
3566         Actually check the value of `WTF::HashMap::capacity`.
3567
3568         * TestWebKitAPI/Tests/WebKitCocoa/_WKInspectorDelegate.mm: Added.
3569         (-[InspectorDelegate _webView:didAttachInspector:])
3570         (-[InspectorDelegate _webView:browserDomainEnabledForInspector:])
3571         (-[InspectorDelegate _webView:browserDomainDisabledForInspector:])
3572         (TestWebKitAPI::TEST):
3573         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
3574         (-[InspectorDelegate _webView:didAttachInspector:]): Deleted.
3575         (TestWebKitAPI::TEST): Deleted.
3576
3577 2020-02-25  Matt Lewis  <jlewis3@apple.com>
3578
3579         Add checkout_root to stubrepository.py
3580         https://bugs.webkit.org/show_bug.cgi?id=208213
3581
3582         Reviewed by Jonathan Bedard.
3583
3584         * Scripts/webkitpy/common/checkout/scm/stub_repository.py:
3585         (StubRepository.__init__):
3586
3587         We are creating our own class variable for checkout_root rather than calling the parent SCM variable
3588         because when initially we left out the parent constructor due to trying to override the fact that we don't actually have a SCM.
3589
3590 2020-02-25  Daniel Bates  <dabates@apple.com>
3591
3592         TestWebKitAPI.PasteMixedContent.CopyAndPasteWithCustomPasteboardDataOnly should wait until copy operation completes
3593         https://bugs.webkit.org/show_bug.cgi?id=208214
3594
3595         Reviewed by Wenson Hsieh.
3596
3597         Wait until the copy operation completes before loading the second web view and testing paste
3598         to ensure that something was actually copied to the clipboard.
3599
3600         * TestWebKitAPI/TestWebKitAPI.xcodeproj/xcshareddata/xcschemes/TestWebKitAPI.xcscheme:
3601         * TestWebKitAPI/Tests/WebKitCocoa/PasteMixedContent.mm:
3602         (TestWebKitAPI::TEST): Substitute -_synchronouslyExecuteEditCommand for -_executeEditCommand
3603         so that we wait until the command completes.
3604
3605 2020-02-25  Chris Dumez  <cdumez@apple.com>
3606
3607         REGRESSION (r256882): Can't drag an HTML file into a new (empty) Safari tab
3608         https://bugs.webkit.org/show_bug.cgi?id=208199
3609         <rdar://problem/59746887>
3610
3611         Reviewed by Alex Christensen.
3612
3613         Add API test coverage.
3614
3615         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
3616         (TEST):
3617
3618 2020-02-25  Sihui Liu  <sihui_liu@apple.com>
3619
3620         spinRunLoop should take a non-zero integer as parameter
3621         https://bugs.webkit.org/show_bug.cgi?id=208148
3622         <rdar://problem/59766682>
3623
3624         Unreviewed iOS build fix.
3625
3626         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
3627         (TestWebKitAPI::Util::spinRunLoop):
3628
3629 2020-02-25  Sihui Liu  <sihui_liu@apple.com>
3630
3631         spinRunLoop should take a non-zero integer as parameter
3632         https://bugs.webkit.org/show_bug.cgi?id=208148
3633
3634         Reviewed by Darin Adler.
3635
3636         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3637         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3638         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
3639         (TestWebKitAPI::Util::spinRunLoop):
3640
3641 2020-02-24  Yusuke Suzuki  <ysuzuki@apple.com>
3642
3643         [WTF] Add tests for CompactRefPtrTuple
3644         https://bugs.webkit.org/show_bug.cgi?id=208172
3645
3646         Reviewed by Darin Adler.
3647
3648         We copy tests from RefPtr for CompactRefPtrTuple to ensure that it is working correctly.
3649         Many of tests are not necessary since currently CompactRefPtrTuple is non-copyable / non-movable.
3650
3651         * TestWebKitAPI/CMakeLists.txt:
3652         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3653         * TestWebKitAPI/Tests/WTF/CompactRefPtrTuple.cpp: Added.
3654         (TestWebKitAPI::TEST):
3655
3656 2020-02-24  Aakash Jain  <aakash_jain@apple.com>
3657
3658         [ews] commit-queue should check that patch have appropriate review flag
3659         https://bugs.webkit.org/show_bug.cgi?id=208138
3660
3661         Reviewed by Jonathan Bedard.
3662
3663         * BuildSlaveSupport/ews-build/steps.py:
3664         (BugzillaMixin._is_patch_obsolete): Drive-by fix to set build properties for patch author, commiter and reviewer.
3665         (BugzillaMixin._is_patch_cq_plus):
3666         (BugzillaMixin._does_patch_have_acceptable_review_flag): Method to check if patch have r? or r- flag.
3667         (ValidatePatch.start):
3668
3669 2020-02-24  Jiewen Tan  <jiewen_tan@apple.com>
3670
3671         [WebAuthn] Implement SPI for the platform authenticator
3672         https://bugs.webkit.org/show_bug.cgi?id=208087
3673         <rdar://problem/59369305>
3674
3675         Reviewed by Brent Fulgham.
3676
3677         Besides adding API tests, this patch also teaches TestWebKitAPI to use restricted entitlements.
3678
3679         * TestWebKitAPI/Configurations/TestWebKitAPI-macOS.entitlements:
3680         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
3681         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3682         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
3683         (-[TestWebAuthenticationPanelDelegate panel:updateWebAuthenticationPanel:]):
3684         (-[TestWebAuthenticationPanelDelegate panel:selectAssertionResponse:completionHandler:]):
3685         (-[TestWebAuthenticationPanelDelegate panel:verifyUserWithAccessControl:completionHandler:]):
3686         (TestWebKitAPI::TEST):
3687         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-la.html: Copied from Tools/TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion.html.
3688         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-la-duplicate-credential.html: Added.
3689         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-la-error.html: Added.
3690         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-la.html: Added.
3691
3692 2020-02-24  Yusuke Suzuki  <ysuzuki@apple.com>
3693
3694         Unreviewed, updating LLDB test for CompactPointerTuple.
3695         https://bugs.webkit.org/show_bug.cgi?id=207827
3696
3697         * lldb/lldb_webkit.py:
3698         (WTFCompactPointerTupleProvider):
3699         (WTFCompactPointerTupleProvider.update):
3700
3701 2020-02-24  Ellie Epskamp-Hunt  <eepskamphunt@apple.com>
3702
3703         Provide alternate way to name Web Content process
3704         https://bugs.webkit.org/show_bug.cgi?id=205224
3705         rdar://57038084
3706
3707         Reviewed by Alex Christensen.
3708
3709         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3710         * TestWebKitAPI/Tests/WebKitCocoa/DisplayName.mm: Added.
3711         (TestWebKitAPI::TEST):
3712
3713 2020-02-24  Jonathan Bedard  <jbedard@apple.com>
3714
3715         results.webkit.org: Link to result archives
3716         https://bugs.webkit.org/show_bug.cgi?id=207646
3717         <rdar://problem/59395807>
3718
3719         Rubber-stamped by Aakash Jain.
3720
3721         * resultsdbpy/resultsdbpy/view/static/js/archiveRouter.js: Added.
3722         (_ArchiveRouter): Retrieve json from archive-router endpoint.
3723         (_ArchiveRouter.prototype._determineArgumentFromAncestry): Given an argument, default and ancestry values,
3724         return the most specific value.
3725         (_ArchiveRouter.prototype.hasArchive): Check if a suite and mode have an archive link.
3726         (_ArchiveRouter.prototype.pathFor): Construct the path for archive access.
3727         (_ArchiveRouter.prototype.labelFor): Return a label for an archive link.
3728         * resultsdbpy/resultsdbpy/view/static/js/investigate.js:
3729         (parametersForInstance): Extract from lambda function.
3730         (testRunLink): Use parametersForInstance instead of a lambda function.
3731         (archiveLink): Return an archive link for data. 
3732         (contentForData): Add archive link to view.
3733         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
3734         (TimelineFromEndpoint): Accept both suite and test.
3735         (TimelineFromEndpoint.prototype.render.onDotEnterFactory): Add archive link to pop-over.
3736         * resultsdbpy/resultsdbpy/view/templates/search.html: Pass suite and test to TimelineEndpoint.
3737         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Pass suite to TimelineEndpoint.
3738         * resultsdbpy/resultsdbpy/view/view_routes.py:
3739         (ViewRoutes.__init__): Add archive_route dictionary.
3740
3741 2020-02-24  Alex Christensen  <achristensen@webkit.org>
3742
3743         WKWebViewConfiguration._corsDisablingPatterns should also disable CORS for non-DocumentThreadableLoader loading
3744         https://bugs.webkit.org/show_bug.cgi?id=208035
3745         <rdar://problem/58011337>
3746
3747         Reviewed by Tim Hatcher.
3748
3749         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
3750
3751 2020-02-22  Darin Adler  <darin@apple.com>
3752
3753         Fix some include mistakes and make some coding style tweaks to WebKit and WebKitTestRunner
3754         https://bugs.webkit.org/show_bug.cgi?id=208099
3755
3756         Reviewed by Antti Koivisto.
3757
3758         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
3759         Sorted includes the traditional way. Added an include of AccessibilityCommonMac.h
3760         so we can use the -[NSString createJSStringRef] method.
3761         (-[NSString createJSStringRef]): Deleted. This is a duplicate of the method
3762         defined in AccessibilityCommonMac.mm, and was causing a linker warning.
3763
3764 2020-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3765
3766         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html is failing in iOS 13.4 beta
3767         https://bugs.webkit.org/show_bug.cgi?id=208096
3768         <rdar://problem/59632008>
3769
3770         Reviewed by Alexey Proskuryakov.
3771
3772         In the iOS 13.4 beta, the fix for <rdar://problem/56422337> changed -[UIDatePicker setCalendar:], such that
3773         if the new calendar locale matches that of the current calendar's locale (and several other properties of the
3774         new NSCalendar are also unchanged), then the UIDatePicker's calendar will also avoid changing.
3775
3776         In our layout tests, the mechanism we use to simulate the user changing their preferred calendar is no longer
3777         compatible with the above change since the swizzled NSCalendar instance does not have a locale set, so it will
3778         default to the same locale as the one used in the original NSCalendar. This means the call to -setCalendar: ends
3779         up being a no-op, so the test fails to override the simulated Japanese calendar type with a Gregorian calendar
3780         in the credit card expiry field.
3781
3782         To fix this, additionally specify a calendar locale identifier when generating the mock NSCalendar.
3783
3784         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3785         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3786         (WTR::UIScriptController::setDefaultCalendarType):
3787         * WebKitTestRunner/TestController.h:
3788
3789         Change m_overriddenCalendarIdentifier to m_overriddenCalendarAndLocaleIdentifiers, a pair of calendar
3790         identifier and calendar locale identifier.
3791
3792         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3793         (WTR::swizzledCalendar):
3794         (WTR::TestController::overriddenCalendarIdentifier const):
3795         (WTR::TestController::overriddenCalendarLocaleIdentifier const):
3796
3797         Clean these up by returning the `NSString *` instead of making another `RetainPtr`.
3798
3799         (WTR::TestController::setDefaultCalendarType):
3800
3801         Plumb the new calendar's locale identifier through this method.
3802
3803         (WTR::TestController::cocoaResetStateToConsistentValues):
3804         (WTR::TestController::getOverriddenCalendarIdentifier const): Deleted.
3805         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.h:
3806         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.mm:
3807         (WTR::UIScriptControllerCocoa::setDefaultCalendarType):
3808
3809 2020-02-21  Kate Cheney  <katherine_cheney@apple.com>
3810
3811         App-bound domains should have separate Network Sessions
3812         https://bugs.webkit.org/show_bug.cgi?id=208026
3813         <rdar://problem/59434006>
3814
3815         Reviewed by Brent Fulgham.
3816
3817         This patch is mostly test infrastructure involving 3 functions.
3818         One sets in-app browser privacy as enabled in the network process
3819         manually for the test. One ensures that setting the WebView category
3820         works properly, and the last one checks for an app-bound session for
3821         an app-bound navigation.
3822
3823         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3824         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3825         (WTR::InjectedBundle::didReceiveMessageToPage):
3826         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3827         (WTR::TestRunner::getWebViewCategory):
3828         (WTR::TestRunner::callDidReceiveWebViewCategoryCallback):
3829         (WTR::TestRunner::hasAppBoundSession):
3830         (WTR::TestRunner::setInAppBrowserPrivacyEnabled):
3831         (WTR::TestRunner::callDidSetInAppBrowserPrivacyEnabledCallback):
3832         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3833         * WebKitTestRunner/TestController.cpp:
3834         (WTR::TestController::ensureViewSupportsOptionsForTest):
3835         Clearing the bundleID should happen right before setting a new one, 
3836         otherwise it clears the ID after it is set and returns a null ID.
3837
3838         (WTR::TestController::resetStateToConsistentValues):
3839         (WTR::TestController::getWebViewCategory):
3840         (WTR::InAppBrowserPrivacyCallbackContext::InAppBrowserPrivacyCallbackContext):
3841         (WTR::inAppBrowserPrivacyBooleanResultCallback):
3842         (WTR::inAppBrowserPrivacyVoidResultCallback):
3843         (WTR::TestController::hasAppBoundSession):
3844         (WTR::TestController::setInAppBrowserPrivacyEnabled):
3845         * WebKitTestRunner/TestController.h:
3846         * WebKitTestRunner/TestInvocation.cpp:
3847         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3848         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3849         (WTR::TestInvocation::didSetInAppBrowserPrivacyEnabled):
3850         (WTR::TestInvocation::didReceivePrevalentDomains):
3851         (WTR::TestInvocation::didReceiveWebViewCategory):
3852         * WebKitTestRunner/TestInvocation.h:
3853         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3854         (WTR::TestController::getWebViewCategory):
3855
3856 2020-02-21  Jonathan Bedard  <jbedard@apple.com>
3857
3858         Build DumpRenderTree and WebKitTestRunner for macCatalyst
3859         https://bugs.webkit.org/show_bug.cgi?id=208068
3860         <rdar://problem/59676596>
3861
3862         Reviewed by Tim Horton.
3863
3864         * DumpRenderTree/ios/TextInputControllerIOS.m: Import WebKitLegacy explicitly.
3865         * DumpRenderTree/mac/Configurations/Base.xcconfig: Use cocoatouch instead of SDK.
3866         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Ditto.
3867         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig: Ditto.
3868         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig: Ditto.
3869         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Ditto.
3870         * DumpRenderTree/mac/EditingDelegate.mm: Import WebKitLegacy explicitly.
3871         * DumpRenderTree/mac/EventSendingController.h: Ditto.
3872         * DumpRenderTree/mac/ObjCPlugin.m: Ditto.
3873         * DumpRenderTree/mac/ResourceLoadDelegate.mm: Ditto.
3874         * Makefile: Add DumpRenderTree and WebKitTestRunner.
3875         * WebKitTestRunner/Configurations/Base.xcconfig: Use cocoatouch instead of SDK.
3876         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Ditto.
3877         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Ditto.
3878
3879 2020-02-21  Aakash Jain  <aakash_jain@apple.com>
3880
3881         [ews] Add build step to Validate ChangeLog for commit-queue
3882         https://bugs.webkit.org/show_bug.cgi?id=208064
3883
3884         Reviewed by Jonathan Bedard.
3885
3886         * BuildSlaveSupport/ews-build/steps.py:
3887         (ValidateChangeLogAndReviewer): Build step to validate ChangeLog.
3888         (ValidateChangeLogAndReviewer.start):
3889         (ValidateChangeLogAndReviewer.evaluateCommand): If the validation fails, comment on bug and mark patch as cq-.
3890         (SetCommitQueueMinusFlagOnPatch.start): End the build (after marking the patch cq-) if build_finish_summary property is set.
3891
3892 2020-02-21  Aakash Jain  <aakash_jain@apple.com>
3893
3894         [ews] Add build step to set cq- flag on bugzilla patch
3895         https://bugs.webkit.org/show_bug.cgi?id=208021
3896
3897         Reviewed by Jonathan Bedard.
3898
3899         * BuildSlaveSupport/ews-build/steps.py:
3900         (BugzillaMixin.set_cq_minus_flag_on_patch):
3901         (SetCommitQueueMinusFlagOnPatch):
3902         (SetCommitQueueMinusFlagOnPatch.start):
3903         (SetCommitQueueMinusFlagOnPatch.getResultSummary):
3904
3905 2020-02-20  Matt Lewis  <jlewis3@apple.com>
3906
3907         Stub repositories fail to upload some results due to missing head svn revision
3908         https://bugs.webkit.org/show_bug.cgi?id=207684
3909
3910         Reviewed by Jonathan Bedard.
3911
3912         * Scripts/webkitpy/common/host_mock.py: Added in call for creating stub repo checkout information for upload tests.
3913         (MockHost.__init__):
3914         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
3915         (summarize_results): Changed call to head_svn_revision to port.commits_for_upload() to bring
3916         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
3917         (SummarizedResultsTest.setUp): Added in new required parameter for testing.
3918         * Scripts/webkitpy/port/base.py:
3919         (Port.commits_for_upload): Removed the forced movement up the systems tree that prevented us 
3920         from using mock SCMs and more
3921         * Scripts/webkitpy/port/test.py: Added function to make the checkout_information.json for upload testing.
3922
3923 2020-02-21  Diego Pino Garcia  <dpino@igalia.com>
3924
3925         [JSCOnly] Add --verbose flag when running JavaScriptCore tests
3926         https://bugs.webkit.org/show_bug.cgi?id=208051
3927
3928         Reviewed by Carlos Alberto Lopez Perez.
3929
3930         Verbose flag prints out each test name executed. Without this flag
3931         stdout prints out one or two periods.
3932
3933         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3934         (RunJavaScriptCoreTests.start):
3935
3936 2020-02-21  Michael Catanzaro  <mcatanzaro@gnome.org>
3937
3938         [WPE][GTK] googleapis.com is a public suffix, defeating isGoogle() check in UserAgentQuirks.cpp
3939         https://bugs.webkit.org/show_bug.cgi?id=207984
3940
3941         Reviewed by Daniel Bates.
3942
3943         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3944         (TestWebKitAPI::TEST):
3945
3946 2020-02-20  Michael Catanzaro  <mcatanzaro@gnome.org>
3947
3948         [GTK] Improve user agent quirk for Google Docs and Google Drive
3949         https://bugs.webkit.org/show_bug.cgi?id=206506
3950
3951         Reviewed by Carlos Garcia Campos.
3952
3953         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3954         (TestWebKitAPI::assertUserAgentForURLHasFirefoxBrowserQuirk):
3955         (TestWebKitAPI::TEST):
3956
3957 2020-02-20  Fujii Hironori  <Hironori.Fujii@sony.com>
3958
3959         check-webkit-style: Check if *_EXPORT and *_EXPORT_PRIVATE macros are used under corresponding directories
3960         https://bugs.webkit.org/show_bug.cgi?id=207380
3961
3962         Reviewed by Jonathan Bedard.
3963
3964         Added a new rule 'build/export_macro'.
3965
3966         Removed a obsolete rule 'readability/webkit_export' which was used
3967         only by Chromium port (r148185).
3968
3969         * Scripts/webkitpy/style/checkers/cpp.py:
3970         (_FunctionState.export_macro):
3971         (check_function_definition):
3972         (_unix_path): Added.
3973         (is_generated_file): Use _unix_path.
3974         (check_has_config_header): Ditto.
3975         (CppChecker):
3976         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3977         (WebKitStyleTest.test_export_macro_check):
3978         (WebKitStyleTest.test_webkit_export_check): Deleted.
3979
3980 2020-02-20  Fujii Hironori  <Hironori.Fujii@sony.com>
3981
3982         [Win][MiniBrowser] Add prettier toolbar button icons
3983         https://bugs.webkit.org/show_bug.cgi?id=207999
3984
3985         Reviewed by Ross Kirsling.
3986
3987         Use a custom toolbar button icons instead of system stock icons.
3988
3989         Fixed a bug toolbar button dropdown arrows always looked being
3990         hovered. TBSTYLE_FLAT should be given.
3991
3992         Removed the window border line of Progress Indicator.
3993
3994         * MiniBrowser/win/MainWindow.cpp:
3995         (MainWindow::createToolbar):
3996         * MiniBrowser/win/MiniBrowserLib.rc:
3997         * MiniBrowser/win/MiniBrowserLibResource.h:
3998         * MiniBrowser/win/toolbar.bmp: Added.
3999
4000 2020-02-20  Aakash Jain  <aakash_jain@apple.com>
4001
4002         Update run-webkit-tests help description for skip-failing-tests
4003         https://bugs.webkit.org/show_bug.cgi?id=208031
4004
4005         Reviewed by Alexey Proskuryakov.
4006
4007         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4008
4009 2020-02-20  Chris Dumez  <cdumez@apple.com>
4010
4011         REGRESSION (r255677): Reloading tab with beforeunload prompt closes tab when asking to stay on page
4012         https://bugs.webkit.org/show_bug.cgi?id=208015
4013         <rdar://problem/59591630>
4014
4015         Reviewed by Geoffrey Garen.
4016
4017         Add API test coverage.
4018
4019         * TestWebKitAPI/Tests/WebKitCocoa/ModalAlerts.mm:
4020         (TEST):
4021
4022 2020-02-20  Tim Horton  <timothy_horton@apple.com>
4023
4024         WKWebView with non-zero origin has the wrong top content inset with NSWindowStyleMaskFullSizeContentView
4025         https://bugs.webkit.org/show_bug.cgi?id=207998
4026         <rdar://problem/40942425>
4027
4028         Reviewed by Sam Weinig.
4029
4030         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4031         * TestWebKitAPI/Tests/WebKitCocoa/TopContentInset.mm: Renamed from Tools/TestWebKitAPI/Tests/WebKitCocoa/FullscreenTopContentInset.mm.
4032         (-[FullscreenChangeMessageHandler userContentController:didReceiveScriptMessage:]):
4033         (TestWebKitAPI::TEST):
4034         Add some tests for top content insets.
4035
4036 2020-02-20  Jonathan Bedard  <jbedard@apple.com>
4037
4038         results.webkit.org: Correctly report JSC tests for windows (Follow-up fix)
4039         https://bugs.webkit.org/show_bug.cgi?id=207910
4040
4041         Unreviewed infrastructure fix.
4042
4043         * Scripts/run-javascriptcore-tests:
4044         (configurationForUpload): Use the major version instead of the sub-minor version
4045         for version name.
4046
4047 2020-02-20  Don Olmstead  <don.olmstead@sony.com>
4048
4049         [CMake] Add WPE::libwpe target
4050         https://bugs.webkit.org/show_bug.cgi?id=207970
4051
4052         Reviewed by Adrian Perez de Castro.
4053
4054         Use the WPE::libwpe target.
4055
4056         * MiniBrowser/wpe/CMakeLists.txt:
4057         * TestWebKitAPI/PlatformWPE.cmake:
4058         * TestWebKitAPI/glib/PlatformWPE.cmake:
4059         * wpe/backends/CMakeLists.txt:
4060
4061 2020-02-19  Fujii Hironori  <Hironori.Fujii@sony.com>
4062
4063         [Win][MiniBrowser] Add 'Go Home' menu item and toolbar button
4064         https://bugs.webkit.org/show_bug.cgi?id=207749
4065
4066         Reviewed by Ross Kirsling.
4067
4068         Added "Set Default URL to Current URL" menu item like Mac MiniBrowser.
4069
4070         * MiniBrowser/win/MainWindow.cpp:
4071         (MainWindow::createToolbar):
4072         (MainWindow::WndProc):
4073         (MainWindow::setDefaultURLToCurrentURL):
4074         (MainWindow::goHome): Added.
4075         (MainWindow::onURLBarEnter):
4076         * MiniBrowser/win/MainWindow.h:
4077         * MiniBrowser/win/MiniBrowserLib.rc:
4078         * MiniBrowser/win/MiniBrowserLibResource.h:
4079         * MiniBrowser/win/MiniBrowserReplace.h:
4080         * MiniBrowser/win/WinMain.cpp:
4081         (wWinMain):
4082
4083 2020-02-19  Peng Liu  <peng.liu6@apple.com>
4084
4085         Fix check-webkit-style errors related to AVFoundationSPI.h
4086         https://bugs.webkit.org/show_bug.cgi?id=207834
4087
4088         Reviewed by Daniel Bates.
4089
4090         Revert the change in r256770 regarding the headers ordering.
4091         Headers in the same category should be in sorted order (case sensitive, as done by the command-line sort tool or the Xcode sort selection command).
4092
4093         * Scripts/webkitpy/style/checkers/cpp.py:
4094         (check_include_line):
4095
4096 2020-02-19  Jonathan Bedard  <jbedard@apple.com>
4097
4098         results.webkit.org: Correctly report JSC tests for windows
4099         https://bugs.webkit.org/show_bug.cgi?id=207910
4100
4101         Rubber-stamped by Aakash Jain.
4102
4103         * Scripts/run-javascriptcore-tests:
4104         (configurationForUpload): Give Windows a version name.
4105         * Scripts/webkitdirs.pm:
4106         (determineWinVersion): Correctly parse Windows 10 version numbers, conform to
4107         Version dictionary.
4108
4109 2020-02-19  Chris Dumez  <cdumez@apple.com>
4110
4111         Unreviewed, fix assertions in storage access API layout tests after r256882.
4112
4113         Drop dead testRunner code to toggle storage access API feature.
4114
4115         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4116         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4117         (WTR::TestRunner::setStorageAccessAPIEnabled): Deleted.
4118         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4119         * WebKitTestRunner/TestInvocation.cpp:
4120         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
4121
4122 2020-02-18  Zan Dobersek  <zdobersek@igalia.com>
4123
4124         [WPE] Support 2D axis, smooth-motion events
4125         https://bugs.webkit.org/show_bug.cgi?id=207881
4126
4127         Reviewed by Carlos Garcia Campos.
4128
4129         * wpe/jhbuild.modules: Bump to a newer libwpe commit.
4130
4131 2020-02-18  Ryan Haddad  <ryanhaddad@apple.com>
4132
4133         Unreviewed, rolling out r256851.
4134
4135         Broke internal bots
4136
4137         Reverted changeset:
4138
4139         "Stub repositories fail to upload some results due to missing
4140         head svn revision"
4141         https://bugs.webkit.org/show_bug.cgi?id=207684
4142         https://trac.webkit.org/changeset/256851
4143
4144 2020-02-18  Fujii Hironori  <Hironori.Fujii@sony.com>
4145
4146         [Win][MiniBrowser] Support back/forward mouse buttons by handing APPCOMMAND_BROWSER_BACKWARD and APPCOMMAND_BROWSER_FORWARD
4147         https://bugs.webkit.org/show_bug.cgi?id=207883
4148
4149         Reviewed by Ross Kirsling.
4150
4151         Unlike other mouse buttons, 4th and 5th mouse buttons are
4152         processed differently. Clicking them dispatches WM_XBUTTONDOWN and
4153         WM_XBUTTONUP events to the window under the mouse cursor.
4154         Unhandled WM_XBUTTONUP events are automatically converted to
4155         WM_APPCOMMAND. And, unhandle WM_APPCOMMAND are propagated to the
4156         parent window.
4157         <https://docs.microsoft.com/en-us/windows/win32/inputdev/wm-appcommand>
4158
4159         Unlike other WM_* commands, WM_APPCOMMAND should return 1 if it is
4160         handled.
4161
4162         * MiniBrowser/win/BrowserWindow.h:
4163         * MiniBrowser/win/MainWindow.cpp:
4164         (MainWindow::WndProc):
4165         * MiniBrowser/win/WebKitBrowserWindow.cpp:
4166         (WebKitBrowserWindow::navigateForwardOrBackward):
4167         * MiniBrowser/win/WebKitBrowserWindow.h:
4168         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
4169         (WebKitLegacyBrowserWindow::navigateForwardOrBackward):
4170         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
4171
4172 2020-02-18  Alex Christensen  <achristensen@webkit.org>
4173
4174         Expand WKRemoteObjectCoder supported POD types to encode NSURLResponse types
4175         https://bugs.webkit.org/show_bug.cgi?id=207912
4176         <rdar://problem/59556922>
4177
4178         Reviewed by Brian Weinstein.
4179
4180         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.h:
4181         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.mm:
4182         (TEST):
4183         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistryPlugIn.mm:
4184         (-[RemoteObjectRegistryPlugIn sendRequest:response:challenge:error:completionHandler:]):
4185
4186 2020-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
4187
4188         [macOS] Web process may crash under ServicesOverlayController::buildPotentialHighlightsIfNeeded
4189         https://bugs.webkit.org/show_bug.cgi?id=207899
4190         <rdar://problem/55658207>
4191
4192         Reviewed by Tim Horton and Simon Fraser.
4193
4194         Make it possible to run tests on macOS with services controls enabled, via a new TestOptions flag.
4195
4196         * WebKitTestRunner/TestController.cpp:
4197         (WTR::updateTestOptionsFromTestHeader):
4198         * WebKitTestRunner/TestOptions.h:
4199         (WTR::TestOptions::hasSameInitializationOptions const):
4200         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4201         (WTR::TestController::platformCreateWebView):
4202
4203 2020-02-18  Matt Lewis  <jlewis3@apple.com>
4204
4205         Stub repositories fail to upload some results due to missing head svn revision
4206         https://bugs.webkit.org/show_bug.cgi?id=207684
4207
4208         Reviewed by Jonathan Bedard.
4209
4210         * Scripts/webkitpy/api_tests/run_api_tests.py:
4211         (main): Added initializing the scm to the host object.
4212         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
4213         (summarize_results): Changed call to head_svn_revision to port.commits_for_upload() to bring
4214         it in line with modern code.
4215         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4216         (main): Added inializing the scm to the host object.
4217         * Scripts/webkitpy/port/base.py:
4218         (Port.commits_for_upload): Removed the forced movement up the systems tree that prevented us
4219         from using mock SCMs and more
4220         * Scripts/webkitpy/test/main.py:
4221         (main):  Removed the forced movement up the systems tree, initialized the SCM on the host object,
4222         and converted the webkit_root variable to the SCM checkout root.
4223         (Tester._run_tests):
4224
4225 2020-02-18  Per Arne Vollan  <pvollan@apple.com>
4226
4227         Move [UIDevice currentDevice] calls to UI process
4228         https://bugs.webkit.org/show_bug.cgi?id=204320
4229
4230         Reviewed by Darin Adler.
4231
4232         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4233         * TestWebKitAPI/Tests/WebKit/LocalizedDeviceModel.mm: Added.
4234         (TEST):
4235
4236 2020-02-18  Simon Fraser  <simon.fraser@apple.com>
4237
4238         Move from "layer flush" terminology to "rendering update"
4239         https://bugs.webkit.org/show_bug.cgi?id=207870
4240
4241         Reviewed by Tim Horton.
4242
4243         Rename various functions and member variables to move away from the legacy "layer flush"
4244         terminology and instead use "rendering update", matching Page::updateRendering(). The fact
4245         that we have layers is an implementation detail.
4246         
4247         Change LayerFlushThrottlingState to be an OptionSet<>.
4248
4249         * Tracing/SystemTracePoints.plist:
4250
4251 2020-02-17  Zhifei Fang  <zhifei_fang@apple.com>
4252
4253         [Webkit.css] Adding popover style element
4254         This help to prevent us reinventing the wheel ever again
4255         https://bugs.webkit.org/show_bug.cgi?id=207787
4256
4257         Reviewed by Dean Jackson.
4258
4259         * resultsdbpy/resultsdbpy/view/static/library/css/docs.yaml:
4260         * resultsdbpy/resultsdbpy/view/static/library/css/index.html:
4261         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
4262         (.popover):
4263         (.popover>.content):
4264         (.popover.display):
4265         (.popover .arrow):
4266         (.popover .arrow.point-top):
4267         (.popover .arrow.point-bottom):
4268         (.popover .arrow.point-left):
4269         (.popover .arrow.point-right):
4270         (@media (prefers-color-scheme: dark) .popover>.content):
4271         (@media (prefers-color-scheme: dark) .popover.display):
4272         (@media (prefers-color-scheme: dark) .popover .arrow):
4273         (.popover>.content>.section): Deleted.
4274         (.popover:focus>.content, .popover:hover>.content): Deleted.
4275         (.popover.right>.content): Deleted.
4276         (.popover.right :focus>.content, .popover.right:hover>.content): Deleted.
4277         (.popover.left>.content): Deleted.
4278         (.popover.left :focus>.content, .popover.left:hover>.content): Deleted.
4279         (.popover.bottom>.content): Deleted.
4280         (.popover.bottom :focus>.content, .popover.bottom:hover>.content): Deleted.
4281
4282 2020-02-17  Brent Fulgham  <bfulgham@apple.com>
4283
4284         Update WebKit Tools to issue mach extensions as needed
4285         https://bugs.webkit.org/show_bug.cgi?id=207850
4286         <rdar://problem/59521019>
4287
4288         Reviewed by Per Arne Vollan.
4289
4290         Revise the codesign settings for our testing tools to allow the process to vend mach extensions
4291         to its child processes (WebContent, GPU, Network, etc.) as needed.
4292
4293         * MiniBrowser/MiniBrowser.entitlements:
4294         * TestWebKitAPI/Configurations/TestWebKitAPI-macOS.entitlements: Added.
4295         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
4296         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4297         * WebKitTestRunner/Configurations/WebKitTestRunner.entitlements:
4298
4299 2020-02-17  Peng Liu  <peng.liu6@apple.com>
4300
4301         Fix check-webkit-style errors related to AVFoundationSPI.h
4302         https://bugs.webkit.org/show_bug.cgi?id=207834
4303
4304         Reviewed by Eric Carlson.
4305
4306         We need to use case-insensitive comparison to check whether the headers are alphabetically sorted in each header section.
4307         Soft-link headers can be included as either "file.h" or <file.h>.
4308
4309         * Scripts/webkitpy/style/checkers/cpp.py:
4310         (_classify_include):
4311         (check_include_line):
4312
4313 2020-02-17  Keith Rollin  <krollin@apple.com>
4314
4315         Unreviewed build fix after r256715.
4316
4317         Fix tvOS and watchOS builds.
4318
4319         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
4320
4321 2020-02-17  Per Arne Vollan  <pvollan@apple.com>
4322
4323         Use CF prefs direct mode in the WebContent process
4324         https://bugs.webkit.org/show_bug.cgi?id=203420
4325
4326         Reviewed by Brent Fulgham.
4327
4328         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4329         * TestWebKitAPI/Tests/WebKit/PreferenceChanges.mm: Added.
4330         (TEST):
4331
4332 2020-02-17  Aakash Jain  <aakash_jain@apple.com>
4333
4334         EWS should be able to file Bugzilla